[stable/nextcloud] recommended upgrade method unknown; leads to non-functional nextcloud

Describe the bug
Upgrading to the latest chart version by doing:
helm upgrade -f nextcloud.yaml nextcloud stable/nextcloud

Where nextcloud.yaml is my values yaml, results in a non functioning nextcloud
Version of Helm and Kubernetes:
 helm version
Client: &version.Version{SemVer:"v2.14.3", GitCommit:"0e7f3b6637f7af8fcfddb3d2941fcc7cbebb0085", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.1", GitCommit:"5270352a09c7e8b6e8c9593002a73535276507c0", GitTreeState:"clean"}

kubectl version
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-21T15:34:43Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-21T15:23:49Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
stable/nextcloud
What happened:
mariadb comes up but has many failed logins:
2019-09-12 12:39:06 0 [Note] /opt/bitnami/mariadb/sbin/mysqld (mysqld 10.3.15-MariaDB-log) starting as process 1 ...
2019-09-12 12:39:06 0 [Note] InnoDB: Using Linux native AIO
2019-09-12 12:39:06 0 [Note] InnoDB: Mutexes and rw_locks use GCC atomic builtins
2019-09-12 12:39:06 0 [Note] InnoDB: Uses event mutexes
2019-09-12 12:39:06 0 [Note] InnoDB: Compressed tables use zlib 1.2.8
2019-09-12 12:39:06 0 [Note] InnoDB: Number of pools: 1
2019-09-12 12:39:06 0 [Note] InnoDB: Using SSE2 crc32 instructions
2019-09-12 12:39:06 0 [Note] InnoDB: Initializing buffer pool, total size = 128M, instances = 1, chunk size = 128M
2019-09-12 12:39:06 0 [Note] InnoDB: Completed initialization of buffer pool
2019-09-12 12:39:06 0 [Note] InnoDB: If the mysqld execution user is authorized, page cleaner thread priority can be changed. See the man page of setpriority().
2019-09-12 12:39:06 0 [Note] InnoDB: 128 out of 128 rollback segments are active.
2019-09-12 12:39:06 0 [Note] InnoDB: Creating shared tablespace for temporary tables
2019-09-12 12:39:06 0 [Note] InnoDB: Setting file './ibtmp1' size to 12 MB. Physically writing the file full; Please wait ...
2019-09-12 12:39:06 0 [Note] InnoDB: File './ibtmp1' size is now 12 MB.
2019-09-12 12:39:06 0 [Note] InnoDB: Waiting for purge to start
2019-09-12 12:39:06 0 [Note] InnoDB: 10.3.15 started; log sequence number 831329155; transaction id 7721613
2019-09-12 12:39:06 0 [Note] InnoDB: Loading buffer pool(s) from /bitnami/mariadb/data/ib_buffer_pool
2019-09-12 12:39:06 0 [Note] Plugin 'FEEDBACK' is disabled.
2019-09-12 12:39:06 6 [Warning] InnoDB: Table mysql/innodb_table_stats has length mismatch in the column name table_name.  Please run mysql_upgrade
2019-09-12 12:39:06 6 [Warning] InnoDB: Table mysql/innodb_index_stats has length mismatch in the column name table_name.  Please run mysql_upgrade
2019-09-12 12:39:06 0 [Note] InnoDB: Buffer pool(s) load completed at 190912 12:39:06
2019-09-12 12:39:06 0 [Note] Server socket created on IP: '<IP_ADDRESS>'.
2019-09-12 12:39:06 0 [Warning] 'proxies_priv' entry '@% root@nextcloud-mariadb-master-0' ignored in --skip-name-resolve mode.
2019-09-12 12:39:06 0 [ERROR] Incorrect definition of table mysql.event: expected column 'sql_mode' at position 14 to have type set('REAL_AS_FLOAT','PIPES_AS_CONCAT','ANSI_QUOTES','IGNORE_SPACE','IGNORE_BAD_TABLE_OPTIONS','ONLY_FULL_GROUP_BY','NO_UNSIGNED_SUBTRACTION','NO_DIR_IN_CREATE','POSTGRESQL','ORACLE','MSSQL','DB2','MAXDB','NO_KEY_OPTIONS','NO_TABLE_OPTIONS','NO_FIELD_OPTIONS','MYSQL323','MYSQL40','ANSI','NO_AUTO_VALUE_ON_ZERO','NO_BACKSLASH_ESCAPES','STRICT_TRANS_TABLES','STRICT_ALL_TABLES','NO_ZERO_IN_DATE','NO_ZERO_DATE','INVALID_DATES','ERROR_FOR_DIVISION_BY_ZERO','TRADITIONAL','NO_AUTO_CREATE_USER','HIGH_NOT_PRECEDENCE','NO_ENGINE_SUBSTITUTION','PAD_CHAR_TO_FULL_LENGTH','EMPTY_STRING_IS_NULL','SIMULTANEOUS_ASSIGNMENT'), found type set('REAL_AS_FLOAT','PIPES_AS_CONCAT','ANSI_QUOTES','IGNORE_SPACE','IGNORE_BAD_TABLE_OPTIONS','ONLY_FULL_GROUP_BY','NO_UNSIGNED_SUBTRACTION','NO_DIR_IN_CREATE','POSTGRESQL','ORACLE','MSSQL','DB2','MAXDB','NO_KEY_OPTIONS','NO_TABLE_OPTIONS','NO_FIELD_OPTIONS','MYSQL323','MYSQL40','ANSI','NO_AUTO_VALU
2019-09-12 12:39:06 0 [ERROR] mysqld: Event Scheduler: An error occurred when initializing system tables. Disabling the Event Scheduler.
2019-09-12 12:39:06 0 [Note] Reading of all Master_info entries succeded
2019-09-12 12:39:06 0 [Note] Added new Master_info '' to hash table
2019-09-12 12:39:06 0 [Note] /opt/bitnami/mariadb/sbin/mysqld: ready for connections.
Version: '10.3.15-MariaDB-log'  socket: '/opt/bitnami/mariadb/tmp/mysql.sock'  port: 3306  Source distribution
2019-09-12 12:39:29 9 [Warning] Access denied for user 'root'@'localhost' (using password: NO)
2019-09-12 12:39:29 10 [Warning] Access denied for user 'root'@'localhost' (using password: NO)
2019-09-12 12:39:39 11 [Warning] Access denied for user 'root'@'localhost' (using password: YES)
2019-09-12 12:39:45 12 [Warning] Access denied for user 'root'@'localhost' (using password: YES)
2019-09-12 12:39:45 13 [Warning] Access denied for user 'root'@'localhost' (using password: YES)
2019-09-12 12:39:49 14 [Warning] Access denied for user 'root'@'localhost' (using password: YES)
2019-09-12 12:39:52 15 [Warning] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2019-09-12 12:39:52 16 [Warning] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2019-09-12 12:39:59 17 [Warning] Access denied for user 'root'@'localhost' (using password: YES)
2019-09-12 12:40:08 18 [Warning] Access denied for user 'root'@'localhost' (using password: YES)
2019-09-12 12:40:09 19 [Warning] Access denied for user 'root'@'localhost' (using password: YES)
2019-09-12 12:40:11 20 [Warning] Access denied for user 'root'@'localhost' (using password: YES)
2019-09-12 12:40:19 21 [Warning] Access denied for user 'root'@'localhost' (using password: YES)
2019-09-12 12:40:29 22 [Warning] Access denied for user 'root'@'localhost' (using password: YES)

consequently, the main pod complains with the following errors:
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using <IP_ADDRESS>. Set the 'ServerName' directive globally to suppress this message
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using <IP_ADDRESS>. Set the 'ServerName' directive globally to suppress this message
[Thu Sep 12 12:11:15.428485 2019] [mpm_prefork:notice] [pid 1] AH00163: Apache/2.4.38 (Debian) PHP/7.3.9 configured -- resuming normal operations
[Thu Sep 12 12:11:15.428531 2019] [core:notice] [pid 1] AH00094: Command line: 'apache2 -D FOREGROUND'
[Thu Sep 12 12:11:53.563797 2019] [php7:error] [pid 30] [client <IP_ADDRESS>:40970] PHP Fatal error:  Uncaught Doctrine\\DBAL\\DBALException: Failed to connect to the database: An exception occurred in driver: SQLSTATE[HY000] [2002] Connection refused in /var/www/html/lib/private/DB/Connection.php:64\nStack trace:\n#0 /var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php(448): OC\\DB\\Connection->connect()\n#1 /var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php(410): Doctrine\\DBAL\\Connection->getDatabasePlatformVersion()\n#2 /var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php(354): Doctrine\\DBAL\\Connection->detectDatabasePlatform()\n#3 /var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php(710): Doctrine\\DBAL\\Connection->getDatabasePlatform()\n#4 /var/www/html/lib/private/DB/Connection.php(151): Doctrine\\DBAL\\Connection->setTransactionIsolation(2)\n#5 /var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DriverManager.php(181): OC\\DB\\Connection->__construct(Array, Object(Doctrine\\DBAL\\Driver\\PDOMySql\\Driver), Object(Doctrine\\DBAL\\Configuration), Object( in /var/www/html/lib/private/DB/Connection.php on line 64

What you expected to happen:
Nextcloud is upgraded without a hitch
How to reproduce it (as minimally and precisely as possible):

install old version (15.0.x) - use mariadb
upgrade to new version
see how it fails

Anything else we need to know:
Seems this is related to secrets being regenerated every time you upgrade. My solution was to rollback, and manually copy the secrets of the mariadb root and replication password. Than re-apply the upgrade, and then edit the secrets by hand to the original value.

/assign

So would you mind sharing your nextcloud values?
One suggestions from my side would be to use existing secret function of mariadb chart. Then it won´t be created or touched during upgrade.

is there a way to get the values from kubernetes/helm itself? I'd hate to give you a yml from my laptop which might represent the full truth.

Is the root password getting regenerated and reinstalled somewhere? It doesn't appear to be limited to just upgrading nextcloud. I simply rebooted my machines and I've now got the mariadb containers failing with the same output.

So from my perspective it is a point with missing configuration in mariadb values. In mariadb values.yaml there is a block which describes your issue.
rootUser:
  ## MariaDB admin password
  ## ref: https://github.com/bitnami/bitnami-docker-mariadb#setting-the-root-password-on-first-run
  ##
  password:
  ##
  ## Option to force users to specify a password. That is required for 'helm upgrade' to work properly.
  ## If it is not force, a random password will be generated.
  forcePassword: false

So I will close this issue and add forcePassword to the the nextcloud default values, just to be sure.
/close

Nice find. What would be the recommended approach for recovering an instance that has had this happen?
Does anyone know of a way to reset the root and replication passwords in the pod? I've tried googling around looking for ways to do this but so far everything I've found is assuming it's running outside of a container and you can kill mysqld.

Can confirm, btw, if I set forcePassword and rootUser.password and replication.password I can successfully upgrade an instance from 16.0.3 to 16.0.5 by changing the image tag and running helm upgrade --install nextcloud -f values.yaml, and I can restart the database pods and they will start back up successfully. I tested this on a separate installation.
Half tempted to back up the old install and restore to a new deployment, rather than keep trying to fight the container to reset root password.
Related: #5167

aren't there 2 issues at hand then? I could really bring back my mariadb cluster by looking in the helm history for the values of the secrets, re apply those, and it would resolve itself.

You can look at the values of past generated secrets? If that's possible, that would fix my install too...

This is my values.yaml profile
## Official nextcloud image version
## ref: https://hub.docker.com/r/library/nextcloud/tags/
##
image:
  repository: nextcloud
  tag: 16.0.3-apache
  pullPolicy: IfNotPresent
  # pullSecrets:
  #   - myRegistrKeySecretName

nameOverride: ""
fullnameOverride: ""

# Number of replicas to be deployed
replicaCount: 1

## Allowing use of ingress controllers
## ref: https://kubernetes.io/docs/concepts/services-networking/ingress/
##
ingress:
  enabled: false
  annotations: {}
  #  nginx.ingress.kubernetes.io/proxy-body-size: 4G
  #  kubernetes.io/tls-acme: "true"
  #  certmanager.k8s.io/cluster-issuer: letsencrypt-prod
  #  nginx.ingress.kubernetes.io/server-snippet: |-
  #    server_tokens off;
  #    proxy_hide_header X-Powered-By;

  #    rewrite ^/.well-known/webfinger /public.php?service=webfinger last;
  #    rewrite ^/.well-known/host-meta /public.php?service=host-meta last;
  #    rewrite ^/.well-known/host-meta.json /public.php?service=host-meta-json;
  #    location = /.well-known/carddav {
  #      return 301 $scheme://$host/remote.php/dav;
  #    }
  #    location = /.well-known/caldav {
  #      return 301 $scheme://$host/remote.php/dav;
  #    }
  #    location = /robots.txt {
  #      allow all;
  #      log_not_found off;
  #      access_log off;
  #    }
  #    location ~ \.(?:png|html|ttf|ico|jpg|jpeg)$ {
  #      try_files $uri /index.php$request_uri;
  #      # Optional: Don't log access to other assets
  #      access_log off;
  #    }
  #    location ~ ^/(?:build|tests|config|lib|3rdparty|templates|data)/ {
  #      deny all;
  #    }
  #    location ~ ^/(?:autotest|occ|issue|indie|db_|console) {
  #      deny all;
  #    }
  #  tls:
  #    - secretName: nextcloud-tls
  #      hosts:
  #        - nextcloud.kube.home

nextcloud:
  host: <IP_ADDRESS>
  username: admin
  password: passwd
  update: 0
  datadir: /var/www/html/data
  tableprefix:
  mail:
    enabled: false
    fromAddress: user
    domain: domain.com
    smtp:
      host: domain.com
      secure: ssl
      port: 465
      authtype: LOGIN
      name: user
      password: pass
  # PHP Configuration files
  # Will be injected in /usr/local/etc/php/conf.d
  phpConfigs: {}
  # Default config files
  # IMPORTANT: Will be used only if you put extra configs, otherwise default will come from nextcloud itself
  # Default confgurations can be found here: https://github.com/nextcloud/docker/tree/master/16.0/apache/config
  defaultConfigs:
    # To protect /var/www/html/config
    .htaccess: true
    # Redis default configuration
    redis.config.php: true
    # Apache configuration for rewrite urls
    apache-pretty-urls.config.php: true
    # Define APCu as local cache
    apcu.config.php: true
    # Apps directory configs
    apps.config.php: true
    # Used for auto configure database
    autoconfig.php: true
    # SMTP default configuration
    smtp.config.php: true
  # Extra config files created in /var/www/html/config/
  # ref: https://docs.nextcloud.com/server/15/admin_manual/configuration_server/config_sample_php_parameters.html#multiple-config-php-file
  configs: {}

  # For example, to use S3 as primary storage
  # ref: https://docs.nextcloud.com/server/13/admin_manual/configuration_files/primary_storage.html#simple-storage-service-s3
  #
  #  configs:
  #    s3.config.php: |-
  #      <?php
  #      $CONFIG = array (
  #        'objectstore' => array(
  #          'class' => '\\OC\\Files\\ObjectStore\\S3',
  #          'arguments' => array(
  #            'bucket'     => 'my-bucket',
  #            'autocreate' => true,
  #            'key'        => 'xxx',
  #            'secret'     => 'xxx',
  #            'region'     => 'us-east-1',
  #            'use_ssl'    => true
  #          )
  #        )
  #      );

internalDatabase:
  enabled: false
  name: nextcloud

##
## External database configuration
##
externalDatabase:
  enabled: false

  ## Supported database engines: mysql or postgresql
  type: mysql

  ## Database host
  host:

  ## Database user
  user: nextcloud

  ## Database password
  password:

  ## Database name
  database: nextcloud

##
## MariaDB chart configuration
##
mariadb:
  ## Whether to deploy a mariadb server to satisfy the applications database requirements. To use an external database set this to false and configure the externalDatabase parameters
  enabled: true

  db:
    name: nextcloud
    user: admin
    password: "123456"
  replication:
    enabled: false
  ## Enable persistence using Persistent Volume Claims
  ## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/
  ##
  master:
    persistence:
      enabled: true
      storageClass: nextcloud
      accessMode: ReadWriteOnce
      size: 8Gi

redis:
  enabled: false
  usePassword: false

## Cronjob to execute Nextcloud background tasks
## ref: https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/background_jobs_configuration.html#cron-jobs
##
cronjob:
  enabled: false
  # Nexcloud image is used as default but only curl is needed
  image: {}
    # repository: nextcloud
    # tag: 16.0.3-apache
    # pullPolicy: IfNotPresent
    # pullSecrets:
    #   - myRegistrKeySecretName
  # Every 15 minutes
  # Note: Setting this to any any other value than 15 minutes might
  #  cause issues with how nextcloud background jobs are executed
  schedule: "*/15 * * * *"
  annotations: {}
  # Set curl's insecure option if you use e.g. self-signed certificates
  curlInsecure: false
  failedJobsHistoryLimit: 5
  successfulJobsHistoryLimit: 2
  # If not set, nextcloud deployment one will be set
  # resources:
    # We usually recommend not to specify default resources and to leave this as a conscious
    # choice for the user. This also increases chances charts run on environments with little
    # resources, such as Minikube. If you do want to specify resources, uncomment the following
    # lines, adjust them as necessary, and remove the curly braces after 'resources:'.
    # limits:
    #  cpu: 100m
    #  memory: 128Mi
    # requests:
    #  cpu: 100m
    #  memory: 128Mi

  # If not set, nextcloud deployment one will be set
  # nodeSelector: {}

  # If not set, nextcloud deployment one will be set
  # tolerations: []

  # If not set, nextcloud deployment one will be set
  # affinity: {}

service:
  type: NodePort
  port: 8080
  loadBalancerIP: nil

## Enable persistence using Persistent Volume Claims
## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/
##
persistence:
  # Nextcloud Data (/var/www/html)
  enabled: true
  annotations: {}
  ## nextcloud data Persistent Volume Storage Class
  ## If defined, storageClassName: <storageClass>
  ## If set to "-", storageClassName: "", which disables dynamic provisioning
  ## If undefined (the default) or set to null, no storageClassName spec is
  ##   set, choosing the default provisioner.  (gp2 on AWS, standard on
  ##   GKE, AWS & OpenStack)
  ##
  storageClass: "nextcloud"

  ## A manually managed Persistent Volume and Claim
  ## Requires persistence.enabled: true
  ## If defined, PVC must be created manually before volume will be bound
  # existingClaim:

  accessMode: ReadWriteOnce
  size: 8Gi

resources: {}
  # We usually recommend not to specify default resources and to leave this as a conscious
  # choice for the user. This also increases chances charts run on environments with little
  # resources, such as Minikube. If you do want to specify resources, uncomment the following
  # lines, adjust them as necessary, and remove the curly braces after 'resources:'.
  # limits:
  #  cpu: 100m
  #  memory: 128Mi
  # requests:
  #  cpu: 100m
  #  memory: 128Mi

## Liveness and readiness probe values
## Ref: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#container-probes
##
livenessProbe:
  enabled: true
  initialDelaySeconds: 30
  periodSeconds: 15
  timeoutSeconds: 5
  failureThreshold: 3
  successThreshold: 1
readinessProbe:
  enabled: true
  initialDelaySeconds: 30
  periodSeconds: 15
  timeoutSeconds: 5
  failureThreshold: 3
  successThreshold: 1

nodeSelector: {}

tolerations: []

affinity: {}

The deployment cannot be started after the installation is complete, the log shows
[root@k8s-master ~]# kubectl logs -f nextcloud-76b78c795f-s9kv8 -n nextcloud
Initializing nextcloud <IP_ADDRESS> ...

The probe tells me
Events:
  Type     Reason     Age                From                Message
  ----     ------     ----               ----                -------
  Normal   Scheduled  66s                default-scheduler   Successfully assigned nextcloud/nextcloud-76b78c795f-s9kv8 to k8s-node2
  Normal   Pulled     65s                kubelet, k8s-node2  Container image "nextcloud:16.0.3-apache" already present on machine
  Normal   Created    64s                kubelet, k8s-node2  Created container nextcloud
  Normal   Started    63s                kubelet, k8s-node2  Started container nextcloud
  Warning  Unhealthy  11s (x2 over 26s)  kubelet, k8s-node2  Liveness probe failed: Get http://<IP_ADDRESS>:80/status.php: dial tcp <IP_ADDRESS>:80: connect: connection refused
  Warning  Unhealthy  1s (x3 over 31s)   kubelet, k8s-node2  Readiness probe failed: Get http://<IP_ADDRESS>:80/status.php: dial tcp <IP_ADDRESS>:80: connect: connection refused

I want to know why I can't connect to port 80?
How to solve this problem?
I am using stable/nextcloud installed by helm.
Helm version is v2.14.1
Tiller version is v2.14.1
Kubeadm version is v1.15.1

@happinesslijian is your issue related to the problem described in the OP ?

Thanks @ftab for explanation. I think this will help other to recover their installation after upgrade. Additionally more details on that should be addressed to the mariadb helm chart collaborators cause I´m not yet that familiar with the chart.
@happinesslijian I don´t think your problem is related to this issue. Any way it is extremely difficult to find out what your problem is if you paste a complete values.yaml. in your values.yaml you only need values that differ from the values.yaml defaults in the chart. With this it would be a lot easier to figure out what might be a problem. I do not really want to go through each property and check if it differs from default values.yaml. Pod logs would also help. And maybe it´s more a topic for a help forum like https://help.nextcloud.com . Thx.


disable the mouse interaction when click on a button

Hello Matthew,
Thank you for this amazing script!
I would like to ask you if there is a possible way to disable the mouse interaction when I click on a button rather than set the value of draggable to false once I initialize the viewer?

No, not at the moment. It's currently only configurable on initialization.

thanks for your response!
Well, I have last question can I fixed or freeze a scene in the cubemap, for example if i click on a button then the current scene is fixed?

You can extract the current view with:
viewer.getRenderer().render(viewer.getPitch() / 180 * Math.PI, viewer.getYaw() / 180 * Math.PI, viewer.getHfov() / 180 * Math.PI, {returnImage: true});

where viewer is the Pannellum viewer instance; this returns the view as a PNG image encoded as a data URI. Alternatively, you can disable all interaction (not just mouse interaction) with:
viewer.setPitchBounds([viewer.getPitch(), viewer.getPitch()]);
viewer.setYawBounds([viewer.getYaw(), viewer.getYaw()]);
viewer.setHfovBounds([viewer.getHfov(), viewer.getHfov()]);

Thanks a million, dear Matthew. It works as I wanted:).


General classifier

This pull request resolves #327 .
The details of the pull request:
modify the export data and preprocessing functions. Standardize the input formats.

Pull Request Test Coverage Report for Build 1231

132 of 137 (96.35%)  changed or added relevant lines in 2 files are covered.
7 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.008%) to 93.705%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

autokeras/tabular/tabular_preprocessor.py
56
58
96.55%

autokeras/tabular/tabular_supervised.py
76
79
96.2%

Files with Coverage Reduction
New Missed Lines
%

autokeras/nn/layers.py
1
95.0%

autokeras/tabular/tabular_supervised.py
1
94.03%

autokeras/nn/model_trainer.py
2
91.94%

autokeras/tabular/tabular_preprocessor.py
3
91.96%

Totals

Change from base Build 1183:
0.008%

Covered Lines:
3662

Relevant Lines:
3908

💛  - Coveralls


Better looking default indentation for nested latex lists

By default, nested enumerates are indented with too many spaces (relative to how things are indented in DOOM).
This small PR changes the defaults to match DOOM indentation standards.

Thanks again!


Added default newsletter subscription for new members

refs https://github.com/TryGhost/Team/issues/1469
Currently, all new members get auto subscribed to the default newsletters. This change adds same behavior with multiple newsletters by auto subscribing all available newsletters on site for new members(If flag is enabled).

adds newsletters service for working with newsletter data
bumps @tryghost/members-api package which handles default subscription
adds new test fixture/data for newsletters

Shouldn't the changes to the members API take into account the newsletter subscribe_on_signup flag?

@matthanley Based on the working doc, we want to attach all existing newsletters on a member signup for 🛹 version. This will be taken into account though down the line in cycle as we wire up other parts of newsletter management.


Added my name to Mentors.md

@Ankita297 hey, if you have any projects please send the pr or dm me i will add it.


Update ContentSyncState checksums when bulk updating WebsiteContent

Pre-Flight checklist

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
Fixes #1040
What's this PR do?
Bulk updates ContentSyncState.current_checksum values, while running the markdown_cleanup management command.
How should this be manually tested?
In a shell, pick a site, save a page's markdown to a corrupted value, and set checksums for WebsiteContent objects with markdown to the wrong value:
from content_sync.models import *
from websites.models import *
content = WebsiteContent.objects.filter(type="page").first()
content.markdown = '\[!\[Small groups of students talking at tables in a classroom. In the foreground, an instructor stands near a pair of students talking to each other.\]({{\< resource\
    ...: _file 68aab975-18a3-39e4-91a6-bd54c8f35356 >}})\]({{\<'
content.save()
sync_state = content.content_sync_state
sync_state.current_checksum = "wrong"
sync_state.save()
ContentSyncState.objects.filter(current_checksum="wrong").count()

Run docker-compose exec web python manage.py markdown_cleanup legacy_shortcode_datafix_1_of_2 -o one.csv -c
Check that the checksum values are no longer "wrong".
ContentSyncState.objects.filter(current_checksum="wrong").count()

Codecov Report

Merging #1047 (5fd1f2b) into master (934657b) will increase coverage by 4.17%.
The diff coverage is n/a.

:exclamation: Current head 5fd1f2b differs from pull request most recent head 1984192. Consider uploading reports for the commit 1984192 to get more accurate results

@@            Coverage Diff             @@
##           master    #1047      +/-   ##
==========================================
+ Coverage   91.10%   95.27%   +4.17%
==========================================
  Files         200       96     -104
  Lines        7652     2623    -5029
  Branches     1333      549     -784
==========================================
- Hits         6971     2499    -4472
+ Misses        596      124     -472
+ Partials       85        0      -85

Impacted Files
Coverage Δ

...s/management/commands/markdown_cleaning/cleaner.py

videos/api.py

localdev/configs/api.py

users/factories.py

main/permissions.py

main/serializers.py

websites/config_schema/api.py

gdrive_sync/factories.py

gdrive_sync/models.py

gdrive_sync/tasks.py

... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 934657b...1984192. Read the comment docs.

@ChristopherChudzicki the changes should be synced to the git main branch when:

the user saves edits from the UI
the user publishes to draft or live from the UI
the mass-publish management command is run (which should hit the same publish code as above)

The files chosen for syncing should be ones where their associated ContentSyncState.synced_checksum != current_checksum

There is also a content_sync.tasks.sync_unsynced_websites task which can be run to sync to git without publishing.

Maybe that sync_unsynced_websites task should be run as the last step of this command, actually.  What do you think?  Unless the mass-publish task is typically run after this command anyway, in which case it would be duplicating effort.

Sure, just added it in, with an option to skip it, but will run by default as long as commit=True

@mbertrand Sooooo I am pretty sure I totally misunderstood this yesterday, but I think I get it now.

Prior to this PR markdown_cleanup was editing the markdown entries, but since this was done through bulk update, the current_checksum was not being updated. So the database recorded things as "in sync" even though they were not really in sync. Consequently, a subsequent sync would miss changes we had made.
With this PR:

whenever commiting, we update the current checksum, so that a subsequent sync will update github appropriately
and by default (i.e., without --skip-sync) we db --> github

Does that sound correct? Thanks for your patience with my misunderstandings :)

Yup, that sounds right!


Group Kotlin multiplatform artifacts together

Request details
One of the problems when publishing kotlin multiplatform artifacts is that each artifact for each platform is displayed separately.

It would be nice to be able to group different platform artifacts together in expandable sub list.

KMP follows standard Maven structure for each artifact & adding this kind of feature to cover this niche doesn't really make much sense. Reposilite is supposed to work in a client-agnostic way, so I think this is not something we can address at this moment.


Bump com.github.spullara.mustache.java:compiler from 0.9.10 to 0.9.11

Description
Manually creating a version bump of com.github.spullara.mustache.java:compiler from 0.9.10 to 0.9.11 because the dependabot PR has been having issues with the gradle check.
Check List

[X] New functionality includes testing.

[X] All tests pass

[X] New functionality has been documented.

[X] New functionality has javadoc added

[X] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[X] Commits are signed per the DCO using --signoff
[X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[X] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock The dependabot PR is failing on that test.
ref: https://build.ci.opensearch.org/job/gradle-check/30414/console
I had to update the test for this dependency update.

@cwperks I assume that addition to including the field in the catch is expected?

Another backport bites the dust @cwperks please.

@dblock Here's the backport: https://github.com/opensearch-project/OpenSearch/pull/13353
Yes there was a change in the error message in the library and the test expected the message in a certain format.  See the change here


Website Interface (UI/UX) could be improved

The current Random Text Generator interface can be improvised to enhance User Interface and User Experience (UI/UX) of the tool. It could also include options to set output customizations, offer additional features like "copy to clipboard", "Re-Generate Random Text", and many more.
Any additional ideas are also welcome.

I would like to contribute to this project .. Can u assign it to me?

Sure @Aagam-Jain-113, go for it!


Update Module-12-Microsoft-Defender-for-Cloud-database-protection.md

Cleaned up formatting issues

Retrying via file upload, file has been cleaned up


POST: error

first time I POST /pourCup is OK, then I working otherthing about 40min, POST/pourCup again, get this error, but GET is  OK.
{
  "error": {
    "statusCode": 500,
    "name": "Error",
    "message": "Error trying invoke business network. Error: No valid responses from any peers.\nResponse from attempted peer comms was an error: Error: 2 UNKNOWN: error executing chaincode: transaction returned with failure: Error: Failed to add object with ID 'CJB0119' in collection with ID 'Asset:org.ibm.coffee.cupCoffee' as the object already exists",
    "stack": "Error: Error trying invoke business network. Error: No valid responses from any peers.\nResponse from attempted peer comms was an error: Error: 2 UNKNOWN: error executing chaincode: transaction returned with failure: Error: Failed to add object with ID 'CJB0119' in collection with ID 'Asset:org.ibm.coffee.cupCoffee' as the object already exists\n    at _initializeChannel.then.then.then.then.catch (/home/composer/.npm-global/lib/node_modules/@ibmblockchain/composer-rest-server/node_modules/composer-connector-hlfv1/lib/hlfconnection.js:957:34)\n    at <anonymous>"
  }
}

You have to give a unique cupID to each cup. Seems like CJB0119 already
exists
On Fri, Sep 7, 2018 at 5:15 AM Fuyao-Jiang<EMAIL_ADDRESS>wrote:

first time I POST /pourCup is OK, then I working otherthing about 40min,
POST/pourCup again, get this error, but GET is OK.
{
"error": {
"statusCode": 500,
"name": "Error",
"message": "Error trying invoke business network. Error: No valid responses from any peers.\nResponse from attempted peer comms was an error: Error: 2 UNKNOWN: error executing chaincode: transaction returned with failure: Error: Failed to add object with ID 'CJB0119' in collection with ID 'Asset:org.ibm.coffee.cupCoffee' as the object already exists",
"stack": "Error: Error trying invoke business network. Error: No valid responses from any peers.\nResponse from attempted peer comms was an error: Error: 2 UNKNOWN: error executing chaincode: transaction returned with failure: Error: Failed to add object with ID 'CJB0119' in collection with ID 'Asset:org.ibm.coffee.cupCoffee' as the object already exists\n    at _initializeChannel.then.then.then.then.catch (/home/composer/.npm-global/lib/node_modules/@ibmblockchain/composer-rest-server/node_modules/composer-connector-hlfv1/lib/hlfconnection.js:957:34)\n    at "
}
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/IBM/blockchainbean/issues/8, or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ8gZewLSt4Hgs6vV946kfVw9dpnlIDrks5uYeS9gaJpZM4WeHCs
.

@horeaporutiu  Thx


eqref doesn't work when we have an in-line equation

for example
md"""
$(eqref("eq1")) is with $x+2$
"""

Hi, This is more of a known problem of conflicts with LaTeX $ and julia interpolation $ when both of them appear in a markdown macro (see https://github.com/JuliaLang/julia/issues/36946 for example):
Using the alternative inline latex synthax with double backtick instead of $ solves the issue (though at the moment the equation number is put in a newline of its own, but that should be fixable


fix fatal error if no matches found

wasn't checking if matches weren't found - now does. program would crash if the length was 0, now it just returns to ignore that jawn. my b for not checking that in the OG commit/PR

v nice I hadn't actually tested this edge case yet


Simplify utility module configuration

For setopt CORRECT. Let the user uncomment a line with the setopt directly in the configuration file, instead of having a flag variable for it.

LGTM, I'll merge this weekend.

25 days later, this will be merged. Sorry about the long wait! :/


background image on cloud

I can add a background image to canvas locally, but it does not appear on the cloud
I'm using:
streamlit==1.10.0
streamlit-drawable-canvas==0.9.0

It doesn't work on basic example either, I can't add a background image

Hello,
Yes, this is a duplicate of #70, it broke since v0.9.0, you can downgrade to 0.8.0 for now until it's fixed.
I will close this as duplicate if you don't mind


sim: Add a few configs to run examples/{module,sotest}

@yamt aren't these commits already in your WIP PR?
I can merge it, but maybe you'd want to drop the commits and rebase from the other PR.

@Ouss4 please merge this. i created a separate PR (this) because i want to keep the WIP one minimum.


Issues running dev example

Server-side React render was discarded. Make sure that your initial render does not contain any client-side code.
Cloned -> npm install -> npm run dev -> visit localhost:3000
Any ideas? Thanks!
Edit: Works fine with production

Also running into the following error (seems to correct itself after restarting the app):
ReferenceError: ApiClient is not defined
   at new ApiClient (/home/matt/src/react-redux-universal-hot-example/src/ApiClient.js:15:7)
   at /home/matt/src/react-redux-universal-hot-example/src/server.js:37:18
   at Layer.handle [as handle_request] (/home/matt/src/react-redux-universal-hot-example/node_modules/express/lib/router/layer.js:95:5)
   at trim_prefix (/home/matt/src/react-redux-universal-hot-example/node_modules/express/lib/router/index.js:312:13)
   at /home/matt/src/react-redux-universal-hot-example/node_modules/express/lib/router/index.js:280:7
   at Function.process_params (/home/matt/src/react-redux-universal-hot-example/node_modules/express/lib/router/index.js:330:12)
   at next (/home/matt/src/react-redux-universal-hot-example/node_modules/express/lib/router/index.js:271:10)
   at SendStream.error (/home/matt/src/react-redux-universal-hot-example/node_modules/serve-static/index.js:120:7)
   at emitOne (events.js:77:13)
   at SendStream.emit (events.js:166:7)

Experiencing exactly the same issue on current master. Also, the ApiError was already described here:
https://github.com/erikras/react-redux-universal-hot-example/issues/14
It's really a strange on-off thing. But I would guess that it doesn't work 70% of the time. Even when building the production code.

@babsonmatt About the Server-side React render was discarded, that's because of the the redux-devtools. I've added another console message (not committed yet) that informs of that. Confirm that turning __DEVTOOLS__: false in webpack/dev.config.js fixes it.

@erikras set __DEVTOOLS__: false as you suggested but still receiving the same error.  devtools no longer appear, so they appear to be turned off, but the error persists

Okay, I know what this is. It's due to the way client.js is outputting an array inside a <div>. I've fixed it on my local copy. I'll be committing and pushing later today.

@erikras thanks!  Any thoughts on the ApiClient issue by any chance? Seems to come and go.

Okay, do a pull and see if it's any better.

@erikas looks good, thanks

still running into ReferenceError: ApiClient is not defined

@sallespro What Node version?

iojs v2.0.1

node v0.12.7

Hmm... It's working fine for me in node v0.10.32 and v0.12.4. But this almost sounds more like a babel-runtime problem. Things to try:

Renaming the class to SomethingElse. (shouldn't help)
Putting the formatUrl() function at another place in the file, like after the ApiClient class or inside it. Maybe that's messing up the reading of the class definition?

yes, Putting the formatUrl() function after the Class declaration made it smoother for Babel.

(duplicated comment for convenience) See above pull request and https://github.com/erikras/react-redux-universal-hot-example/issues/14#issuecomment-212573715 for what I'm hoping is the true fix for this problem

Same here.dest.firstChild.attributes['data-react-checksum'] is undefined and Server-side React render was discarded

is this fixed? I also have the same issue still, when loading images.

@AndrewRayCode  ^^^ thought?


Question about the data preprocess

Hello, thank you so much for making your work open source.
I am trying to use other data from DAVIS. But the source virtual view created by render_source_vv.py is bad.
This is the original image.

This is the virtual view image.

But I think the model reconstructed by colmap is good enough.

I wonder if there is some mismatch between colmap output and dynamic-video-depth. Or could you please give me a pair of input and output for colmap and dynamic-video-depth to help me find out my mistake.
Thank you a lot!

Hi, the virtual view image looks OK to me. Why do you think it's bad?

Thanks for your reply!

This is virtual view image provided by you. I think it may be closer to the real situation, which reflecting the depth and disparity.
And the image resolution seems to be lower.
https://github.com/google/dynibar/assets/65765708/b45da9a1-015a-4fee-a598-146434851a7b
I try to set the novel view camera offset fixed to be (0, 0, 0.1). But the output is not as good as your demo. I am trying to find out why.
Maybe I should check the NSFF part?


Revert signature prefix change

This fixes compatibility between devnet signatures and berkeley.

!ci-build-me

!ci-build-me


run.c - Enhance arg parse : optional parameters

It would be ideal to specify parameters without having to set all. One could use getopt for that but it is not portable. So we roll our own minimal one.
Usage:
run <checkpoint_file> -t [temperature] -s [steps] -p [prompt]

Minimum:
run <checkpoint_file>

The following are optional:
-t [temperature] -s [steps] -p [prompt]
if they are omitted, default values are used.
The order of -t -s -p does not matter but the checkpoint_file has to be the first parameter.
To keep it simple without needing for extended checks, if the parameter to the last option is missing, the current default value is used instead.
Updated README.MD to reflect changes.
Incorporated requirement from: https://github.com/karpathy/llama2.c/pull/218#issuecomment-1662596666

TODO:
Wait for status on https://github.com/karpathy/llama2.c/pull/218
If required add https://github.com/karpathy/llama2.c/pull/218#issuecomment-1662596666

Ok I wrote my own here:
https://github.com/karpathy/llama2.c/commit/dcef5ff7c720265752b7963c244c70846d6be252
Thank you for the inspiration!


sysconf adding few more constants.

e.g. _SC_NGROUPS_MAX can be useful for socket ancillary data.

@rustbot ready


Fixed typo.

Hi Dirk,
Thanks for taking a look at the project, and thank you for ImageMagik which we have recently made use of. Let me know if you have any questions.
Trevor


Investigate memory usage

Problem

We haven't put any effort towards investigating whether or not there are any memory leaks / improvements that could be made.
Suggested solution

TBD
Additional context

https://discord.com/channels/933860922039099444/933860923117043718/1047108450737459281

This would be useful to improve upon as running a profile with memray shows a mem overhead of about 600MB for a large schema as all the types etc are loaded


Certificate version for EV3 Brick

It is necessary to test the libraries for the following devices:

EV3 Brick

With the following Debian versions:

Debian Stretch

The tests to execute are:

[x] EV3 Brick + Debian Stretch

With this large testing scope, it is required to find a infrastructure solution to create a Testing Lab for the project. Related issue: https://github.com/ev3dev-lang-java/ev3dev-lang-java/issues/479

Executed regression

In the next release, i will certificate the rest of platforms.


Fixed #1258 - add fewer empty-records

My attempt at a fix for #1258. Changed so that only the exact number of empty records required to fill the height of the grid are created, rounded down. Any leftover space is filled with another empty record of partial height. This way there is no extra "content" that can be accidentally scrolled in certain situations.

Sorry about that, not sure how that got past me! I just put out another PR that should fix this issue. Thank you for reporting it!


Error when calling WriteRecord in Timestream-Write #1510

this issue still persists.
https://github.com/aws/aws-sdk-cpp/issues/1510

Hi @Dashing-Nelson ,
I see, thanks for opening a new one, it does make it easier to see.
We'll take another look.


Add sample code and test cases for validating proof key implementations

From @MarcinJuraszek:
There is a pair of inputs for each of possible cases:

Validate successfully using X-WOPI-Proof and current Key from Discovery
Validate successfully using X-WOPI-ProofOld and current Key from Discovery
Validate successfullyusing X-WOPI-Proof and old Key from Discovery
Validation fails

I generated those using custom certificate, all the keys information is included in the test code itself so it's not bound to any Certificate changes we make in our environments.
You can find the code on Gist: https://gist.github.com/MarcinJuraszek/54477a568c9a2ed851ef - just change ProofKeysHelper.Validate() method with your implementation of Proof Keys validation logic.

https://github.com/Microsoft/Office-Online-Test-Tools-and-Documentation/pull/36/files


Enable US datacenters

I don't currently see a way to override auth url / api url via environment var's found here: https://github.com/commercetools/commercetools-sunrise-java-starter/blob/aeb752c9af9526ac27bb1ac234260bea311c7a9b/conf/prod.conf or https://github.com/commercetools/commercetools-sunrise-java-starter/blob/43da4b50f8f9685e757816a00ac39237747d4213/app.json

Thanks for reporting, for now you can use this as 'prod.conf' workaround:
include "application"

application.setup.enabled = false
application.metrics.enabled = false

# The project key for your commercetools platform project.
ctp.projectKey = ${CTP_PROJECT_KEY}

# The client ID of your commercetools platform project.
ctp.clientId = ${CTP_CLIENT_ID}

# The client secret of your commercetools platform project.
ctp.clientSecret = ${CTP_CLIENT_SECRET}

#ctp.authUrl and ctp.apiUrl are already known as properties, so no code changes necessary
ctp.authUrl = ${CTP_AUTH_URL}
ctp.apiUrl = ${CTP_API_URL}

or even hardcode them for the US (snippet):
ctp.apiUrl = "https://api.commercetools.co"
ctp.authUrl = "https://auth.commercetools.co"

@allcentury As far as I can see it, this is possible now. Can we close this issue? If so, feel free,

Thanks!


Update to the latest Graphiti and Vapor versions

Recent version of Graphiti added support for UUID as a scalar type, which is the default type for id fields in Fluent 4.

Thanks for the PR. Looks good so far.

Likewise, maybe this one could warrant a new release tag?

I agree, I just pushed another change regarding Fluent support. I also want to update the Readme a bit before tagging it with a 2.0.0 tag.


[FEATURE] Report Building Support

Notemate is great already as a tool for parsing and understanding notes. But I think it can be even more powerful by making or adding support for generating different sorts of artifacts like reports, newsletters, and more. Some idea for functions could be:

Parse over time periods to collect notes
Pull summaries from notes quickly
Automate generation of note digests
Note analytics

Word clouds
Notes generated over time

Just some ideas before I forget!

Hey @SevorisDoe,
I am having an internal debate on what tools/functionality to include within NoteMate for making reports or newsletters. I have a prototype branch called tcp-reports that contain functions at the moment to create parts of a report. What is your opinion on this functionality being added into NoteMate? I'll keep prototyping it, but it feels like it should perhaps be a tutorial as opposed to directly supported functionality within NoteMate...
Thanks!


[Enhancement] s3 sdk support path-style-access

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

This PR is to support access s3-compatible object storage in path style.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_admit_test

https://docs.aws.amazon.com/zh_cn/AmazonS3/latest/userguide/VirtualHosting.html

@MergifyIO backport branch-2.3

@MergifyIO backport branch-2.4


Explicitly make certain internal traces private

Goal

Testing

Release Notes

WHAT:
WHY:
WHO:

#837  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on  Graphite


feat: add load balancer

IIUC, I believe we need a new field in the RisingWave to tell the operator which service type will be set for the frontend's service. Is it necessary for other services?


Don't Log First Exception when Connecting to Proxy

Description
Fixes https://github.com/Azure/azure-sdk-for-java/issues/30148
Updates Netty proxy handling to not throw an exception on the first attempt to connect to the proxy. Credentials aren't applied on the first request so it is common for this to fail.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

/azp run java - core - tests

/azp run java - core

Running live test for Storage is showing OutOfMemoryErrors which need to be investigated further before merging

Hey! We still need this fix. It would be nice if it wasn't lost.

Wasn't lost! Just been bogged down with a few other tasks. I'm getting back around to this now 😄

Hey! We still need this fix. It would be nice if it wasn't lost.

Wasn't lost! Just been bogged down with a few other tasks. I'm getting back around to this now 😄

No problem, I just commented to remove the flag. Thanks for pulling it off!


[HOTFIX] fix some issues on doc

Why is this PR needed?
What changes were proposed in this PR?
fix some issues on doc
Does this PR introduce any user interface change?

No
Yes. (please explain the change and update document)

Is any new testcase added?

No
Yes

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/989/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2702/

LGTM.
I see this is in Chinese Doc.
we can review once fully and fix it at once.


Implement support for image stores

Container creation currently only works for ubuntu trusty containers using the download template.
In order to properly support container creation, we'll need image stores.
Please see the specs document for details.

Image stores are no more, the current design is to solely focus on LXD image server and then have external scripts or products feed images in there.


Missing setting for email validation

  missing setting for email validation: email-domain or authenticated-emails-file required.
      use email-domain=* to authorize all email addresses

I've tried all variations of email-domain, email-domains,"","mydomain.com" , [""], ".mydomain.com" etc.
Keep on getting the error message above.
System:
Ubuntu 17.04, 4.10.0-30-generic
oauth2_proxy-2.2.0.linux-amd64.go1.8.1

I have also placed a file "emails", with one email per line in the same directory as the .cfg file.
My cfg entry is authenticated_emails_file = "./emails"
The result in the error log is this:
2017/08/05 23:26:14 watcher.go:65: failed to add emails to watcher: no such file or directory```

I have the following: authenticated_emails_file = "/var/oauth2_proxy/emails"
Containing one email<EMAIL_ADDRESS>When I sign on with another gmail email, it still allows me to pass.
What am I doing wrong?

We use this commandline:  /path/to/bin/oauth2_proxy -email-domain=company.de -authenticated-emails-file=/path/to/additional-authorized-emails [...] to let every account from the company autenticate (via  -email-domain=company.de) and some additional test accounts (like<EMAIL_ADDRESS>via entries in that file -authenticated-emails-file=/path/to/additional-authorized-emails).

Thank you. I have even gone so far as to omit the email-domain entirely. It is still allowing accounts that are not in the emails file. Will try again tomorrow.

If I comment out the emails file, and enter a value (in the conf file) for email-domain="remcam.net" or email-domains=["remcam.net"] (as per https://raw.githubusercontent.com/bitly/oauth2_proxy/master/contrib/oauth2_proxy.cfg.example) , it gives me this:
main.go:103: Invalid configuration:  missing setting for email validation: email-domain or authenticated-emails-file required.  use email-domain=* to authorize all email addresses
I have also tried variations on ".remcam.net", "*.remcam.net" (as per some examples on the net) etc.

The problem stems from here in Options.go, line 136:
		msgs = append(msgs, "missing setting for email validation: email-domain or authenticated-emails-file required.\n      use email-domain=* to authorize all email addresses") }```
Somehow o.EmailDomans (String[]) isn't populated.

jan-schulz-k24 : I am using these cmd line settings:
    -email-domain=remcam.net
    -cookie-secure=true
    -cookie-domain=remcam.net
    -cookie-expire=24h
    -authenticated-emails-file="emails"

Still validating every user. I have a cookie remover which removes all cookies for the site, so that can't be the problem. Anybody have any idea?
PS. The email-domain setting isn't read correctly fron the config file. Only cli is not throwing an exception.

Your issue with email-domain vs email-domains is that for the command-line argument it is singular, repeated, and using dashes: -email-domain=first.com -email-domain=second.com, while for the config file it is plural, array, and using underscores: email_domains = ["first.com", "second.com"], see https://github.com/bitly/oauth2_proxy/blob/v2.2/options.go#L32 (also note that in the config authenticated_emails_file uses underscores).
Once you've specified the options correctly, you'll want to not specify email-domain, because any email in that domain will be accepted regardless of authenticated-emails-file. It's a "union" rather than an "intersection" between those rules - see https://github.com/bitly/oauth2_proxy/blob/v2.2/validator.go#L80

Thanks, I have the settings where it won't just fail with the email-domains error. I now have a problem that all users are validated, even those not in the domain<EMAIL_ADDRESS>or outside the authenticated emails file (s@remcam.net). Please see https://github.com/bitly/oauth2_proxy/issues/434 . If you have an idea why that is, I'd appreciate it very much!


Make it possible in Prisma Schema to mark an index as manually maintained, so Migrate doesn't try to drop/create it

Problem
This idea is from https://github.com/prisma/prisma/issues/9885
When Prisma Migrate doesn't know about some index syntax, it would drop / create it.
Suggested solution
To avoid that, the suggestion is to add a property to mark a given index as manually maintained, so Prisma Migrate knows it exists but doesn't try to create/drop it.
Example
@@unique([user_uuid, platform, active], map: "active_account_idx", manual: true)

Alternatives
Support more indexes, like https://github.com/prisma/prisma/issues/6974
Additional context

Same issue here with additional predicate (soft deletion and  CREATE UNIQUE INDEX ... WHERE "deletedAt" IS NULL.
I like the idea of manual indexes. Have you found any workaround @Jolg42 ?

This would be very helpful to me as I have many different databases that undergo long data ingests. I often have to drop indices prior to large data loads, and then re-add them after. This can get pretty wonky if I misspell an index name when I add them back.
I wish I could tell Prisma to not worry about certain indices because I am often dropping and recreating them myself.

@Jolg42 do you have any progress estimates there when Prisma team is going to fix that?

We like Prisma so much, but this is a major shortcoming. Any type of "ignore the index named ____" would be so helpful.

also need this feature, this is a huge pain point for our team

Same here, I've added a fuzzy search index manually in order to use it with raw or typedSql, but it keeps dropping it.


docs(security): change bugbounty provider from h1 to bugcrowd

Our bugbounty program is now with Bugcrowd. The HackerOne program is deprecated.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (390e69b) 63.13% compared to head (e7f0669) 63.13%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   63.13%   63.13%
=======================================
  Files          19       19
  Lines        2083     2083
=======================================
  Hits         1315     1315
  Misses        768      768


Allowed day is sporadically getting greyed out

Hi, I'm using a DateRangeLimiter to disable all days before the following week's Monday.
There's a funny issue where sometimes the Monday is greyed out. 90% of the time it's enabled-colored (expected behavior), but 10% of the time the day is greyed out - it works appropriately if the user taps on it. It's just the initial rendering greys it out.
I've tried debugging and stepping through the code, and can tell something different is happening in the cases where it's being greyed out.

You don't need a custom DateRangeLimiter for this. You should use setMinDate() with the appropriate value.
The DateRangeLimiter is hard to implement with very subtle interactions between its various methods. It is highly likely you made a mistake there.

Thanks for the response. The date range limiter also disables all weekends. Is that something that can be done through alternate means as well?


Swift: HUD only shows up the first time

First of all, thank you for the great library! Really useful!
Unfortunately I am kind of stuck implementing SVProgressHUD.
When the app launches, it instantiates a custom location class (NSObject). The user gets notified about wether his location could be found or not. So far everything works like a charm.
And this is my code:
let rootView = (UIApplication.sharedApplication().delegate as! AppDelegate).window?.rootViewController as! SlideMenuController
...
SVProgressHUD.setBackgroundColor(UIColor.blackColor().colorWithAlphaComponent(0.5))
SVProgressHUD.setForegroundColor(UIColor.whiteColor())
SVProgressHUD.setViewForExtension(rootView.view)
SVProgressHUD.show()
...
SVProgressHUD.showSuccessWithStatus("Location found")
My problem is, I'd like to show notifications in other parts of the app as well, but everytime I implement it somewhere else nothing happens. I tried different views for setViewForExtension but still nothing.
Does someone have a similar problem or a solution for this?
Thanks for helping me :)

Could you supply a demo program? I do not use Swift at the moment for my projects.

For me it's not firing at all if we call it in the ViewDidLoad function.

Working again in 8.3 using Swift!

I tried different ways but couldn't find a working solution. I ended up using another framework. Still, i'd appreciate if someone could tell me how to fix this.

What version of iOS sdk? Using swift with cocoapods use_frameworks! ?
Sent from my iPhone
Envoyé de mon iPhone

On Jun 1, 2015, at 07:47, Julian Meier<EMAIL_ADDRESS>wrote:
I tried different ways but couldn't find a working solution. I ended up using another framework. Still, i'd appreciate if someone could tell me how to fix this.
—
Reply to this email directly or view it on GitHub.

iOS 8.2 (use_frameworks! used). Should I give it another try on iOS 8.3?

@arm0nic Your issue might be related to this: https://github.com/TransitApp/SVProgressHUD/pull/303

Probably, thanks!


Adding a dedicated kind for Type Kinds in Data.Morpheus.Kind?

Currently, SCALAR,  OBJECT and, so forth, is defined in Data.Morpheus.Kind module, and they all have the kind of *.
https://github.com/morpheusgraphql/morpheus-graphql/blob/213512236069aad4c987a619a751516f6e98227e/src/Data/Morpheus/Kind.hs#L16-L34
As their kind is *, KIND type family accepts any *-kinded types such as Bool or Int, which is unexpected and undesirable.
And this will emit an unfriendly error message:
    • No instance for (morpheus-graphql-0.1.1:Data.Morpheus.Resolve.Introspect.Introspect
                         Deity
                         Bool
                         morpheus-graphql-0.1.1:Data.Morpheus.Types.Internal.Data.DataArguments)
        arising from a use of ‘interpreter’
    • In the expression: interpreter rootResolver
      In an equation for ‘mythologyApi’:
          mythologyApi = interpreter rootResolver
   |
38 | mythologyApi = interpreter rootResolver
   |                ^^^^^^^^^^^^^^^^^^^^^^^^

Instead of defining empty data types separately, we can define them with DataKinds extension. In this way the types will have the type of GQL_KIND, not *.
module Data.Morpheus.Kind
  ( SCALAR
  , OBJECT
  , ENUM
  , WRAPPER
  , UNION
  , INPUT_OBJECT
  , INPUT_UNION
  , GQL_KIND -- newly exported
  )
where

-- I wish I had type data...
-- https://github.com/ghc-proposals/ghc-proposals/blob/master/proposals/0032-type-data.rst
data GQL_KIND
  = SCALAR
  | OBJECT
  | ENUM
  | INPUT_OBJECT
  | UNION
  | INPUT_UNION
  | WRAPPER

type SCALAR = 'SCALAR
type OBJECT = 'OBJECT
type ENUM = 'ENUM
type INPUT_OBJECT = 'INPUT_OBJECT
type UNION = 'UNION
type INPUT_UNION = 'INPUT_UNION
type WRAPPER = 'WRAPPER

We'll also need the following changes additionally. (needs DataKinds)
 class GQLType a where
-  type KIND a :: *
+  type KIND a :: GQL_KIND

-class Decode a b where
+class Decode a (b :: GQL_KIND) where

-newtype WithGQLKind a b = WithGQLKind
+newtype WithGQLKind a (b :: GQL_KIND) = WithGQLKind

Then, we'll get a relatively straightforward error message, on mistakenly passing Bool as an argument to the KIND type family.
    • Expected kind ‘Data.Morpheus.Kind.GQL_KIND’,
        but ‘Bool’ has kind ‘*’
    • In the type ‘Bool’
      In the type instance declaration for ‘KIND’
      In the instance declaration for ‘GQLType Deity’
   |
24 |   type KIND Deity = Bool
   |                     ^^^^

If I'm misunderstanding something, please let me know.
(Especially, you may want to keep KIND open-ended.)
Thanks!

thank you. great idea. current error messages  is pain for me too

Okay, then I can send a pull request.
btw, do you have any good idea on the name for GQL_KIND? I'm not sure it's the best name.
I've noticed it's very similar to what is called "Type Kinds" in the GraphQL spec, but not exactly the same.

i think GQL_KIND sound good, it has not exactly same structure as TypeKind

I've sent a pull request! (#204)

i approved it. thank you :)


Appstudio update rhtap-demo-component-taou

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: rhtap-demo-component-taou-on-pull-request-
creating pipelinerun rhtap-demo-component-taou-on-pull-request- in namespace rhtap-demo-dev-lejh-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: rhtap-demo-component-taou-on-pull-request-
creating pipelinerun rhtap-demo-component-taou-on-pull-request- in namespace rhtap-demo-dev-tycw-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


Adding more models

Hey @ashleyhindle I've been working on a super similar project to standardize job board API responses in PHP. I've got 13 providers so far.
Anyway, I'd like to start adding more models to your project using the the providers I've got. Any objection to me making a PR to add Dice, Careerbuilder, Indeed, and maybe others?

Hey @karllhughes,
Super happy to have any and all help if the providers offer jobs that are remote friendly!

Okay, I see @ashleyhindle, thanks!


operator edp-keycloak-operator (1.20.0)

Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Are you familiar with our operator pipeline?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want to use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Your submission should not

[x] Add more than one operator bundle per PR
[x] Modify any operator
[x] Rename an operator
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description of the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/pipeline restart community-hosted-pipeline

/pipeline restart community-hosted-pipeline

/pipeline restart community-release-pipeline

Hello @Allda. Could you assist me in resolving the issue with the publishing operator? It appears that the publishing logic is not running correctly.

@SergK I found an issue in the image reference in the registry. The issue should be fixed and I'll retrigger the release pipeline.


Correct the step index in prestage-cluster-service-host-create.md

Correct the step index in prestage-cluster-service-host-create.md.
To fix duplicate Step  5

Thanks, @tungbq!


user mode: use /var/run/user/$UID for other dirs as well

This moves the configmap/secrets/emptydir stuff under /var/run/user/$UID
when run with the -u flag.
A user mode ran systemk still needs CAP_CHOWN to the chown the dir to
the user of the pod - but we may be able to ignore that error.
Previously systemk would just not run any pods in usermode because it
can create any of the volumes for the pod.
Signed-off-by: Miek Gieben<EMAIL_ADDRESS>

[ Quoting<EMAIL_ADDRESS>in "Re: [virtual-kubelet/systemk] user ..." ]

@pires commented on this pull request.
LGTM but question about changing ownership of files.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
In internal/provider/volumes.go:

@@ -216,7 +220,6 @@ func writeFile(dir, file, uid, gid string, data []byte) error {

// chown chowns name with uid and gid.
func chown(name, uid, gid string) error {
I realized all of this can be empty. Is this a valid case in user mode too?

well, yes. Except 'chown' is very limited to normal users, iirc you need to own the
file(s) and then you can only chgrp to groups you're a member of


add working steps for Encoding a message by Hamming Code( for both right to left and left to right as well)

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like

A clear and concise description of what you want to happen.

i would like to work on this issue

Go ahead
Deadline 10 May,2021


replaced DataStructures.jl dependency with OrderedCollections.jl

resolves #71

Can you cap the version of OrderedCollections? Likely not crucial here but required by the General repo I think, see other caps in Project.toml

I see did not know that. Will remember for the future.

Why did it first did not error and now does?

Looks like the load test failed, maybe try manually and diagnose?

Manually everything passes the tests

But the first commit also passes the tests and the second doens't, but nothing changes except the  capped the version of OrderedCollections.jl.


feat: docker support for local mode

Might be nice to generate the docker image from Nix rather than doing a Nix build inside docker, but seems fine to me.

I agree with you, but some of the team members asked if we could provide a way of an easy local deployment for someone who doesn't have or want to install the nix ecosystem on their machine.


improved the stat test and included a test for fstat.

Looks good. Would you mind squashing into on commit? I'm not 100% sure what github thinks is going on here.

I was confused myself after the pull request :-)
I will try to squash this. Might take a few days as I have limited computer access at home right now.


Redesign EQUAL_WAVE_WRAPPER for identical wave references

It is not connected to the DimLabel patch, but I find the following code failing unexpected:
	Make/N=0 w1
	WAVE w2=w1

	CHECK_EQUAL_WAVES(w1,w2)

Originally posted by @MichaelHuth in https://github.com/byte-physics/igor-unit-testing-framework/pull/44#issuecomment-472812939

Yes that needs to be changed.

So the better solution would be to output nothing if two wave references point to the same wave? Sounds like we could need an additional assertion *EQUAL_WAVE_REFERENCES to check if both wave references are the same, so basically split *EQUAL_WAVES into two assertions.

@MathiasAugstein (Please mention me on direct questions.)

So the better solution would be to output nothing if two wave references point to the same wave?

Currently we fail with an error if both wave references are not identical. And that should not fail anymore.
@MichaelHuth Feel free to object here.

Sounds like we could need an additional assertion *EQUAL_WAVE_REFERENCES to check if both wave references are the same, so basically split *EQUAL_WAVES into two assertions.

Yes we could do that in the future, please create a new issue for that.

Just remove the !WaveRefsEqual check from EQUAL_WAVE_WRAPPER and adapt tests and documentation.


feat: liveness probe timeout configure

This patch provides the configuration for the allowed time before the
liveness probe failure, the livenessProbeFailureThreshold is caculated
by this configuration using:
FAILURE_THRESHOLD = ceil(livenessProbeTimeout / 10)
closes: #4642

Besides the minor code suggestions, this patch is triggering a restart on every PG cluster once we update the operator. This happens because the Pod specification we store in the annotations is different:
--- cluster-example-1.before.json       2024-05-30 13:40:13.871662145 +0200
+++ cluster-example-1.after.json        2024-05-30 13:40:19.168357874 +0200
@@ -149,17 +149,18 @@
         }
       ],
       "livenessProbe": {
         "httpGet": {
           "path": "/healthz",
           "port": 8000
         },
         "timeoutSeconds": 5,
-        "periodSeconds": 10
+        "periodSeconds": 10,
+        "failureThreshold": 3
       },
       "readinessProbe": {
         "httpGet": {
           "path": "/readyz",
           "port": 8000
         },
         "timeoutSeconds": 5,
         "periodSeconds": 10

Since the actual configuration didn't change, we should not trigger a restart.
Another point: this new parameter should be documented in the "Startup, liveness and readiness probes" section of the instance manager documentation.

Besides the minor code suggestions, this patch is triggering a restart on every PG cluster once we update the operator. This happens because the Pod specification we store in the annotations is different:
--- cluster-example-1.before.json       2024-05-30 13:40:13.871662145 +0200
+++ cluster-example-1.after.json        2024-05-30 13:40:19.168357874 +0200
@@ -149,17 +149,18 @@
         }
       ],
       "livenessProbe": {
         "httpGet": {
           "path": "/healthz",
           "port": 8000
         },
         "timeoutSeconds": 5,
-        "periodSeconds": 10
+        "periodSeconds": 10,
+        "failureThreshold": 3
       },
       "readinessProbe": {
         "httpGet": {
           "path": "/readyz",
           "port": 8000
         },
         "timeoutSeconds": 5,
         "periodSeconds": 10

Since the actual configuration didn't change, we should not trigger a restart.
Another point: this new parameter should be documented in the "Startup, liveness and readiness probes" section of the instance manager documentation.

Thank you for this comments, this is real a good aspect to considering

addressed comments and trigger a new e2e https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/9348920588

We should document that in the "Startup, liveness and readiness probes" section of the instance manager documentation.

I did it @litaocdl

/ok-to-merge E2E tests green


Join to Component when there are multiple components on jira__daily_issue_field_history

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the issue
In our organization we can have multiple components for one jira story.  We added component to our list of columns we want to see in the dbt_project.yml issue_field_history_columns variable and it seems to work up to a point.  In reviewing the jira__daily_issue_field_history there is a join in the set_values CTE where it does not account for the fact we can have multiple values.  If we could add the join further up stream to get the correct values that would be greatly beneficial.
Relevant error log or model output
As a work around we have had to
- flatten the components column from the jira__issue_enhanced dbt model
- then join to stg_jira__component to get the actual name of the component
- then listagg the name partitioning by the issue_id

`with test as (
SELECT trim(f.value) as component_id, a.* --f.value as component_id_new, a.*
FROM ANALYTICS.JIRA.JIRA_ISSUE a,
LATERAL SPLIT_TO_TABLE(a.components, ',') f
WHERE ISSUE_ID IN (948017,
                   925164)
)

select a.issue_id
   ,a.components
    ,a.component_id
    ,b.component_name
    ,coalesce(b.component_name, a.component_id) as new_component_name
from test a
left join analytics.stg.stg_jira__component b on a.component_id = b.component_id::varchar
;  `

![image](https://github.com/fivetran/dbt_jira/assets/127148173/7482fee9-7a99-4807-a8a9-40589ebbc94d)

Thanks!

Expected behavior
That the components all are the names of the components and not just those where a story has one component listed
dbt Project configurations
issue_field_history_columns: ['Story Points','Summary','Components']
Package versions
version: 0.15.0
What database are you using dbt with?
snowflake
dbt Version
1.7.9
Additional Context
No response
Are you willing to open a PR to help address this issue?

[X] Yes.
[ ] Yes, but I will need assistance and will schedule time during our office hours for guidance
[ ] No.

Hi @abrown-calix ,thanks for opening this. I'm understanding that you wish to be able to bring multiple values that can be tired to a Jira entity through in the model. This is a limitation that we're aware of and we have a Feature Request opened here that you may follow.
Thanks for sharing your workaround! I see you're open to creating a PR, we welcome that! Let me know if you have other notes you'd like to share.


fix: abstain/mock prposoals were disabled

Overview

Abstain/Mock proposals were disabled since their threshold is 0.
Added a guard to disable voting on proposals to check if category is not Abstain or Mock
Jira: ENG-363

@PhearZero @kylebeee @HashMapsData2Value FYI


[sql] How to add migrations

Hello, am trying to add a new migration using the plugin tauri-plugin-sql, but the migrations don't seem to be running and no errors are thrown?
Here is my code below.
    tauri::Builder::default()
        // .menu(menu)
        .plugin(
            tauri_plugin_sql::Builder::default()
                .add_migrations(
                    "sqlite:inventory_system.db",
                    vec![
                        Migration {
                            version: 1,
                            description: "create users",
                            sql: include_str!("../migrations/1.sql"),
                            kind: MigrationKind::Up,
                        },
                        Migration {
                            version: 2,
                            description: "create inventory & inventory history ",
                            sql: include_str!("../migrations/2.sql"),
                            kind: MigrationKind::Up,
                        },
                        Migration {
                            version: 3,
                            description: "create transactions & transaction details",
                            sql: include_str!("../migrations/3.sql"),
                            kind: MigrationKind::Up,
                        },
                        Migration {
                            version: 4,
                            description: "added VAT on transaction columns",
                            sql: include_str!("../migrations/4.sql"),
                            kind: MigrationKind::Up,
                        },
                        Migration {
                            version: 5,
                            description: "added location on inventory table",
                            sql: include_str!("../migrations/5.sql"),
                            kind: MigrationKind::Up,
                        },
                    ],
                )
                .build(),
        )
        .invoke_handler(tauri::generate_handler![export_xls])
        .run(tauri::generate_context!())
        .expect("error while running tauri application");

I don't see any output, but in my case, the file is located in ${localDataDir}/.

Same here, migrations are never ran.

This needs to be added to the docs to make it more clear. I went on a wild goose chase thinking I was missing something. tauri-plugin-sql is useful only if the interfacing is done via the frontend code since the functions load, execute are not public.
If rust code needs to interface with db, other alternatives needs to be considered as of now.
This can be made more convenient if the DbInstances struct is public, one can access the the dbpools via the state.

@thulasi-ram we discussed it in #506 but I think your suggestion is better. Would you make a PR or do you want me to do it?
It will be really usefull to me to be able to access it from Rust side.

I went through 506 and its basically what you had suggested. Please do so if it works for you. But I'd want for sure to discuss more about the maintainers views on this. There's couple of ways we can go from here and everyone's opinion can differ.

Limit scope of plugin-sql to frontend calls only and make it clear in the docs. The maintenance burden is lighter and the authors can focus on other aspects of tauri. But this plugin becomes a really thin shell and folks having use cases for rust <=> sql need to look into other thirdparty options.
Increase the scope of the plugin to include rust <=> sql integration via a nicer api, but this runs quickly into the risk of Greenspun's tenth rule but for ORMs
Increase the scope of the plugin to include rust <=> sql integration via exposing DbInstances. While this approach seems like a good compromise it runs into the risk of maintaining backwards compatibility and Hyrums law. So this option needs the authors to weigh the pros and cons carefully. Obl XKCD
Maintain a separate 3rd party plugin and facilitate the ecosystem with multiple options like Diesel, Sqlx and other flavours of ORMS. From 506 I gather that this can be a more sensible option for you given the maintainers currently lean on option 2.

Cheers

Great write-up! And yeah, it really isn't as simple as it may seem at first :/

Initially that was the main idea behind plugins, to expose rust stuff to the pretty limited javascript side, so we felt adding extensive rust apis was a bit besides the point. Since then we reconsidered, especially since we get regular feedback asking us for rust apis. But yeah, we couldn't think of (or decide on) the best approach yet either so here we are...
At least in the context of the sql plugin i don't think this is the solution. I don't think we're currently able to maintain that. Unless we talk about the same api as we have in js already, at which point it probably still needs 3. to cover more than just simple use cases. Either way, i feel like sqlx' api is really solid and reconstructing that would be a bit weird. And anything close to an ORM is imo completely out of the question for this plugin. If somebody needs an ORM they should always use a dedicated crate for that.
Again in the context of this plugin, i feel like this is the way to go even though it can get tricky with versioning. If sqlx is exposed as part of the public api we can only update its major (or since it's 0.x, minor) version in major plugin versions which in turn are bound to the tauri versions according to our current plans. We could do some feature flag stuff to support multiple versions of course but i don't really know what to think about that. Maybe we could also solve this via a policy ala "We may upgrade sqlx in minor plugin releases..." so that users lock to minor versions until they can update both crates at once.
No opinion on that since you said 3rd party :D Just wanted to say that we don't really lean on option 2 for this plugin, i may was just confused by the store plugin example. Right now i feel like no.3 is the best and maybe a touch of no.2 sprinkled on top (talking about porting the javascript api to rust for really simple uses cases)

p.s. i feel like this should be discussed in 506 instead, if you wanna repost your comment over there i'll do the same with this one - if not that's also fine, i'm not that strict about it 🤷

Reposting https://github.com/tauri-apps/plugins-workspace/issues/1555#issuecomment-2230691367 here in case someone lands on this ticket:

[…] it seems the current fix is to load the DB from the client side:
import Database from "@tauri-apps/plugin-sql";
const db = await Database.load("sqlite:mydatabase.db"); // <- same db name from plugin setup!

The reason is that the migrations are run on the load() command implementation v2/plugins/sql/src/plugin.rs#L166-L169 and not when the plugin is initialized.

I left https://github.com/tauri-apps/plugins-workspace/issues/1555 open, because the current behavior goes against the expectations and the documentation itself.

Alright folks, after a bit of source-code reading, it seems the migrations can actually be run on plugin initialization!
On tauri.conf.json, add:
{
  "plugins": {
    "sql": {
      "preload": ["dbname"]
    }
  }
}

The v2 plugin documentation has a section explaining how to add initialization configuration to a plugin: https://v2.tauri.app/develop/plugins/#plugin-configuration
And tauri-plugin-sql already implements the necessary code to read and execute the migrations based on that: https://github.com/tauri-apps/plugins-workspace/blob/v2/plugins/sql/src/plugin.rs#L302-L316


limit auto scaling batch size to the size of the training dataset

What does this PR do?

Fixes #3259
and releated to #3266
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?
[x] Did you verify new and existing tests pass locally with your changes?
[x] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@awaelchli maybe I made a mistake in rebase, mind push your local branch before sync and resolve conflicts...

@Borda I had to redo all the changes again because the batch size scaling was all moved to a new place and now there appears to be a tuner class? I hope this bugfix can be merged before any further modifications are made to the tuner.


refactor(components, app): Standardize card components

overview
This PR addresses the Card component standardization of RFC #2029.

Card component is  now a white div with a box-shadow that receives a title and children.
title prop has been left optional (for now) but according to design:
All cards should receive a title, and that title should always be capitalized, font-size-header, and font-weight-regular.
Cards now have no padding, and their contents have no default layout or styling. This should all be handled by children.
This PR also adds and implements a few layout atoms to the app which became necessary after ripping display:flex out of card contents
This PR also gets settings pages aligned with design screens

changelog
-refactor(components): Standardize card components
-refactor(app): Add and implement layout atoms in existing card contents
review requests
Standard review.
Please make sure RobotSettings InstrumentSettings AppSettings and Resources pages look and behave as expected in the app.
@b-cooper I believe there was only 1 instance of a card in the app, and you made a one off to avoid any conflicts that would arise from this refactor. Please confirm everything looks ok in PD.
Please keep an eye out for any leftover CSS that might now be obsolete.
Question:
Some of the apps cards contents require flexbox. Some did fine with inline block and some fractions that in retrospect could have been been handled by CardContentFlex. Do we have any preference for inline-block over flex?

@b-cooper I implemented a fix to the PD cards. Please take a look and let me know if this is acceptable. The PD is a strange, foreign land!


Dataset Masking: Per-Sample Training Weight

Closes #125.

This apparently breaks the code with non-masked data. Looking into it.

@alexjc hi Alex, I just pip install scikit-neuralnetwork (0.4)  and would like to use nn.fit(X_train, y_train, w_train) as shown in the Per-sample weighting example. However, I don't see that w variable in my fit() function in the sknn source code. What could be the reason? Thank you.

We haven't yet pushed fit() with weight to PIP. It's in master only.
There's a different documentation page for stable (linked from PIP) here: scikit-neuralnetwork.readthedocs.org/en/stable/guide_beginners.html

Thanks Alex, let me take a look!


[FEATURE] Storing data in local storage

🎇 Description
Hi, I saw you closed the Issue #83 of implementing MongoDB, but I would want to suggest adding a local storage property to store data. It will still stay with Vanilla Javasciprt and I think having multiple records saved in your browser will make the development eaiser for making things like grid layout, moving cards by drag and drop... or maybe connecting records to the progress bar.
Well then, I'll have to edit script.js.
Let me know and assign me if it's ok.
Thank you 😄
🖼 Screenshots
No response

Sure, please go ahead.✨

Updated the pull request! Waiting for the review 😄


Add roll control and reaction wheel

for integration with flight control to allow use of raw values as well as from dmp

Lgtm. Pending tuning of the PID values which you could do later.

Closing this as it is a duplicate and an older version of #26


1123 Node Vulnerability

Initial PR related to #1123.
Working on fixing failing tests and carrying out manual tests, which will be for Part 2.
The implementation is based on advice from @noescape00 :

Commit https://github.com/stratisproject/StratisBitcoinFullNode/pull/1991/commits/a007c27c77dd6e074da18b4fd57aed2ede082d39 is Part 2.
Part 3 commit, I will focus on fixing broken integration tests.

Made some changes based on @majikandy's comments.  This afternoon will look at creating an integration test(s) to cover the CloseClientNotWhiteListedDuringIBD() logic.

running the integration tests now

This is for master branch, please make sure the tests pass

@ferdeen did you run the tests? Did they pass?

Following tests are failing

@noescape00,  @Aprogiena
I ran the unit tests against that last few PR reviews.
Let me run the int tests again over the weekend and get back to you.
Cheers.

It has been mentioned on the planning call that this issue if implemented as it was is quite likely to damage some integration test and I think this is what happened


thanos relies on accurate time and time drift might cause  unexpected query results

I have a three-node Retain cluster with --receive.replication-factor of 2 and when I reboot one of them, it appears
receive-writer tenant=default-tenant msg="Error on ingesting samples that are too old or are too far into the future issue
Error fetching server time detected 30 secods time difference between your browser and the server thanos relies on accurate time and time drift might cause unexpected query result

TSDB_PATH="./receiveData"
GRPC_ADDRESS="<IP_ADDRESS>:10912"
HTTP_ADDRESS="<IP_ADDRESS>:10911"
REPLICATION_FACTOR=3
LABEL_REPLICA="receive_replica="0""
LABEL_CLUSTER="receive_cluster="pre""
LOCAL_ENDPOINT="<IP_ADDRESS>:10912"
HASHRING_FILE="./hashring.json"
REMOTE_WRITE_ADDRESS="<IP_ADDRESS>:10918"
OBJSTORE_CONFIG_FILE="bucket_config.yml"
thanos receive
--tsdb.path=$TSDB_PATH
--grpc-address=$GRPC_ADDRESS
--http-address=$HTTP_ADDRESS
--receive.replication-factor=$REPLICATION_FACTOR
--label="$LABEL_REPLICA"
--label="$LABEL_CLUSTER"
--receive.local-endpoint="$LOCAL_ENDPOINT"
--receive.hashrings-file=$HASHRING_FILE
--remote-write.address=$REMOTE_WRITE_ADDRESS
--objstore.config-file=$OBJSTORE_CONFIG_FILE
--- hashring.json
[
{
"endpoints":[
"<IP_ADDRESS>:10912",
"<IP_ADDRESS>:10912",
"<IP_ADDRESS>:10912"
]
}
]
When I restart any Receive, the entire Seek cluster is unavailable, and the reboot can only be restored after the local data is fully understood

Please see the discussion here. We either need to forbid replication factor 2 because it doesn't allow for any downtime or you need to switch to 3.


Remove SolveParameters.RootDir?

Maybe there's still a reason to have this...but it seems like not, now that we take the root project's PackageTree as its own argument. At most, we'd need a vendor dir path, but since none of that checking exists at all right now, that's not a good argument for it either.

Nah, gonna keep it in. We'll likely want it sooner or later.


OSFUSE-103: Updated maven settings to use the same repository configu…

…ration as JBoss Fuse platform

retest this please


getColumns doesn't work as expected on vector

Hi guys,
Here’s the issue : I have my vector X (say from 0 to 10), and I try to access to some of its items through indices (say indices 3, 5, 8).
INDArray x = Nd4j.create(new double[]{0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10});

System.out.println(x.columns()); // 11 columns
int[] index = new int[]{2, 3, 4};
System.out.println(x.getColumns(index));
// output : [2.00, 3.00, 4.00] , which is fine

But then I tried this, and the results was not what I expected :
NDArray x = Nd4j.create(new double[]{0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10});

int[] index = new int[]{2, 2, 4}; //retrieve the same columns twice
System.out.println(x.getColumns(index));
// output : [2.00, 3.00, 4.00] , expected  [2.00, 2.00, 4.00]

Actually it seems the first indice retrieve the right columns, but then any following int value are just increasing by one the indice of the next columns ( but the int value itself should be the indice of the next column).
NDArray x = Nd4j.create(new double[]{0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10});

int[] index = new int[]{5, 8, 9}; //retrieve the same columns twice
System.out.println(x.getColumns(index));
// output : [5.00, 6.00, 7.00], expected  [5.00, 8.00, 9.00]

Any Ideas ? I might be missing very basics things, or maybe I'm not using the right method ?

This thing will be probably migrated to pullRows/pull nativeOp: https://github.com/deeplearning4j/nd4j/issues/1381

https://github.com/deeplearning4j/nd4j/pull/1392


Added settings and got rid of warnings

Still need to think of mechanism for user specific settings...

Looks good.


Stickers : vegetables category is empty

vegetable category stickers are not present, it is filled with previously used category

fixes


Product attributes not visible on product details page

What I'm trying to achieve
See product attributes values on the product details page.
Steps to reproduce the problem

Fresh master clone
Add two shirts with various size and color attributes
Go to product details page
No attributes under product description

What I expected to happen
An html table as shown in https://github.com/mirumee/saleor/blob/65e00b0d1497d329320b33c8bcdbe1fa8febfb9d/templates/product/details.html#L200-L207 showing the product attribute name and value.
Python-3.7.4
Gentoo Linux kv 5.0.13
Chromium-77.0.3865.35

I'm on newest master after running populatedb on fresh DB. Here is my product details page:

"Material: Cotton" is a product attribute in this case. If I understand correctly, it isn't rendered in your case?

I'm on newest master after running populatedb on fresh DB. Here is my product details page:

"Material: Cotton" is a product attribute in this case. If I understand correctly, it isn't rendered in your case?

Try adding a new product with a custom attribute though. I only had issues with new products not existing ones.

Hi, @likewhoa thanks for the finding. I created a patch in https://github.com/mirumee/saleor/pull/4705. The issue was that the field visible_in_storefront of the Attribute model (product_attribute) was being set to False by default by the dashboard 1.0 due to mistake that was on the form.
To make your affected attributes appear, you have multiple possibilities:

You could delete and recreate the attribute, the values, reassign the values to the products, etc. (hardest solution)
You could update all attributes to be visible through SQL (./manage.py dbshell):

UPDATE product_attribute SET visible_in_storefront = TRUE WHERE visible_in_storefront is FALSE;

You could use the saleor-dashboard, go to the "Configuration" section, and in the attributes page, toggle the field Visible on Product Page in Storefront of the affected attributes and hit save.


fet(vm-creation): show only "my" and "featured" types of templates/ISO (#1659)

Pull Request Test Coverage Report for Build 1815

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.003%) to 53.437%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/app/template/template-filters/template-filters.component.ts
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/app/template/template-filters/template-filters.component.ts
1
54.55%

Totals

Change from base Build 1814:
-0.003%

Covered Lines:
9527

Relevant Lines:
15824

💛  - Coveralls


Incompatible: requires IDE build 193.* or earlier

I am using the IDE below, could you please support that version? Thanks in advance!
Android Studio Flamingo | 2022.2.1 Patch 2
Build #AI-222.4459.24.2221.10121639, built on May 12, 2023
Runtime version: 17.0.6+0-b2043.56-9586694 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 10 10.0
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 8
Registry:
external.system.auto.import.disabled=true
ide.text.editor.with.preview.show.floating.toolbar=false
gradle.version.catalogs.dynamic.support=true

Solution found:

IDE -> File -> Settings -> Plugins -> Click the Gear next to the install button.
Click Manage Plugin repositories.
Add this link to the list: https://github.com/sgpublic/lombok-plugin-action/releases/download/plugin-repository/plugin-repository.
Install/upgrade Lombok in the marketplace.


Pills

Rework the colour themeing of the pills. What they currently are just isn't good enough

New pills being introduced as part of #39


XSS Vulnerabilities

I believe the textarea input is vulnerable to xss. It uses $value to between the textarea tags. We haven't escaped this value. We need to be using htmlentities($output, ENT_QUOTES, 'UTF-8') to escape any user provided output, as none of it should be able to break the html.
There are other locations, other than textarea where we should be doing this escaping. Anywhere we accept user/developer input and render it should be escaped.

Thanks for the heads up, feel free to submit a PR if you'd like, otherwise I'll try and get to it today! Thanks!


registerDevice fails with code 400 - The request signature is invalid

Bug report
Here's the bulk of my code:
  generateRandomKey = () => {
    const key = forge.random.getBytesSync(16);
    return forge.util.bytesToHex(key);
  }

  setup = async () => {
    const permittedIps = [];
    const apiKey = 'API_KEY'; //change this
    const encriptionKey = this.generateRandomKey();
    const bunqJSClient = new BunqJSClient();

    bunqJSClient.setKeepAlive(false);

    // run the bunq application with our API key
    await bunqJSClient.run(apiKey, permittedIps, 'SANDBOX', encriptionKey);

    // install a new keypair
    await bunqJSClient.install();

    //  register this device
    await bunqJSClient.registerDevice();

    //  register a new session
    // await bunqJSClient.registerSession();
  }

The installation goes fine. When it goes to registerDevice, the server returns 400 with the error description "The request signature is invalid.".
If it can help to resolve the error I can host and provide the react-native app. It's a simple autogenerated native react app (https://facebook.github.io/react-native/docs/getting-started.html) with these dependencies:
  "dependencies": {
    "@bunq-community/bunq-js-client": "^0.36.2",
    "node-forge": "^0.7.6",
    "react": "16.6.3",
    "react-native": "0.57.8",
    "url": "^0.11.0"
  },

I haven't tested for react native but what might be going on is that the User-Agent header is ignored/wrong. If it isn't or if it is overwritten somehow it will cause an invalid signature error.
You could test the code found here and check if the navigator object exists and if the navigator.userAgent value is correct.
For NodeJS it sets a custom header and for the browser it uses the navigator->userAgent value since setting a custom User-Agent header isn't allowed.

This is the value of navigator.userAgent:
"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36"
I don't get your last sentence: you're saying that I cannot set a custom header, but you're doing it for Node? 😄
By the way, do you still think that the header is the problem?