Incorrect ES5 code emitted for closures in loops when noCheck is enabled

🔎 Search Terms
ES5, noCheck, loop, closures, transpilation, transpileModule
🕗 Version & Regression Information
This broke in either https://github.com/microsoft/TypeScript/pull/57934 or https://github.com/microsoft/TypeScript/pull/58364
⏯ Playground Link
https://www.typescriptlang.org/dev/bug-workbench/?target=1&noCheck=true#code/PTAEAEDsHsGEAsCmBjA1gLlAFwE4FdEAoECLAQxwHNEtNEBnAVmLHHvmgHcBRAWwEsshQsmiR6WUADNxoALygA2gF0A3ISnQcoABSjxkgG5kANgVDQpSgIwAaUACZ7AZnsAWZQEpQAb0KgA6XEAOgAHPHYdHW85AD5dH1BjM0RQAF9PT3U0kTEJUBwGPBNJBRl6YN4yUJ0ZeXiZaKzc8WgTRGCTaEodQvpirE8gA
💻 Code
// @noCheck: true
// @target: es5
// @showEmit

const fns = [];
for (const value of [1, 2, 3]) {
    fns.push(() => ({ value }));
}
const result = fns.map(fn => fn());
console.log(result)

🙁 Actual behavior
The following incorrect code is produced:
"use strict";
var fns = [];
for (var _i = 0, _a = [1, 2, 3]; _i < _a.length; _i++) {
    var value = _a[_i];
    fns.push(function () { return ({ value: value }); });
}
var result = fns.map(function (fn) { return fn(); });
console.log(result);

Which evaluates to this incorrect value: [{ value: 3 }, { value: 3 }, { value: 3 }]
🙂 Expected behavior
The following should be produced:
"use strict";
var fns = [];
var _loop_1 = function (value) {
    fns.push(function () { return ({ value: value }); });
};
for (var _i = 0, _a = [1, 2, 3]; _i < _a.length; _i++) {
    var value = _a[_i];
    _loop_1(value);
}
var result = fns.map(function (fn) { return fn(); });
console.log(result);

Which would evaluate to: [{ value: 1 }, { value: 2 }, { value: 3 }]
Additional information about the issue
transpileModule(ts, { compilerOptions: { target: ScriptTarget.ES5 } }) started producing incorrect code in TypeScript 5.5, since I believe noCheck: true is the default there.

@weswigham / @DanielRosenwasser any thoughts on this?

I was looking at this last night; this seems like a flag case missed in https://github.com/microsoft/TypeScript/pull/58364 (but I didn't spend enough time on it to actually figure out where or fix anything).

checkIdentifierCalculateNodeCheckFlags  is supposed to drop into checkNestedBlockScopedBinding, which should in turn call getEnclosingIterationStatement to get the containing loop and set LoopWithCapturedBlockScopedBinding on it, thus enabling the transform. If the symbol is missing declarations/is the unknown symbol, it definitely would not do so, since it walks up to the iteration statement from the symbol's value declaration and not the usage, though that's a bit strange - in the non-noCheck case, we get the symbol with getResolvedSymbol(node) directly on the identifier, while in the noCheck case we're using getSymbolAtLocation within checkSingleIdentifier - these functions must behave differently on binding pattern identifiers?

Thank you for a very quick fix!


Add multicluster CA main function.

This is the initial version for the multicluster CA main function.
Docker image build script, tests and deployment yaml files are coming in following PRs.

@myidpt: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
b58b0ea21bdacef249805d4beead1e26c0ca4177
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
b58b0ea21bdacef249805d4beead1e26c0ca4177
link
/test e2e-smoke

prow/istio-presubmit.sh
fd4a3bcae4b5bc09f1b1cf4a84ed5cf24bcab2b1
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


docs(README): mention bob AUR package

Hello!
I packaged bob for Arch Linux in the AUR:

https://aur.archlinux.org/packages/bob

This PR updates README.md to reflect this 🐻

@orhun hey that's very cool of you!
I do have a question tho why not call it bob-git or something as there is already bob-bin

btw nice PR number.

@orhun hey that's very cool of you! I do have a question tho why not call it bob-git or something as there is already bob-bin

bob-bin: installs the latest upstream binary
bob: compiles the latest release from source
bob-git (doesn't exist): compiles from the last commit

btw nice PR number.

Hell yeah!

@orhun Oh I see


Forgot password page

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 3

Complexity increasing per file
==============================
- src/components/auth/ForgotPassword.js  4
- src/components/auth/ForgotPasswordStyled.js  1

Clones added
============
- src/state/auth/authActionCreator.js  3

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 4

Complexity increasing per file
==============================
- src/components/auth/ForgotPasswordStyled.js  1
- src/components/auth/ForgotPassword.js  4
- src/components/auth/ResetPassword.js  9

Clones added
============
- src/components/auth/Login.js  1
- src/components/auth/ResetPassword.js  2
- src/components/auth/Signup.js  1
- src/state/auth/authActionCreator.js  7

See the complete overview on Codacy


destination name is capitalized in list screen

What happened?
The name of the connection is being capitalized for some reason.
What did you expect to happen?
Not to auto capitalize the list of connection items
How'd it happen?

What's your environment like?
0.16.0 92ad590

Tags are all capitalized for some reason I don't understand in multiple places.

Closing to address separately since technically different issues. The first was destination, now this is tags.


Rewrite SSA Verifier and add it into tests.

Rewrite SSA Verifier
The old SSA verifier is not usable, thus I rewrite it. Now the verifier could support following check:

Basic Block: Every basic block could only have one unconditional outgoing edge or two conditional outgoing edges.
Expression

Every Opcode node should have the same operands as it need, except for OpCall and OpStore.
OpNarrow(w)/OpWidth(w) nodes should have the same width with w.
OpCmp/OpGt/OpLt nodes' width must be 1.
OpCall/OpStore/OpLoad do not care about width (for it is not consummate)
Other Opcode nodes should have the same width with its every operand (operands also do not include OpStore/OpLoad)

Use-Def Chain

Opcode node should not have a back-edge use.
Because of Phi, it's possible to have multi-nodes SCC, but it should have at least one operand which is out of this SCC, or to say it reachable.

Bugs
Thanks to this verifier, I found some bugs and fix them.
Basic Block check
I fix a bug in phiplacer.rs at finish point. If the exit block is not the last one we processed, it may make a wrong unconditional edge from some blocks to exit node.
Expression check

In SCCP, when we emit ssa, we may use a const node to replace an opcode node, which could change the node's width. Thus I add an OpNarrow for the OpConst to adapt width.
In SCCP, change OpAdd/OpSub's operation, to avoid integer overflow
In phiplacement.rs, when write register, some operations may lead operands' width unbalanced. And also, writing a register into a node with different width should be careful.

Use-Def Chain check
This fix happened in the last PR, In add_block function, if we replace node A with node B, but node A is still a variable residence, it may be used after a read_variable, and cause a back-edge use.
Something need to do
I have add the verify test in most test in tests/, but because I'm not so familiar with grep_and_replace / x86_idioms function, so I haven't add verify into these two. Especially x86_idioms is in backend, I'm not sure whether we should keep width balanced.

Btw, there are still some problems left for SCCP, especially for overflow and width.

I merged it to get ready for restruction


ParseJson suddenly very slow

Hello !!!
the sub ParseJson suddenly became very slow in one computer only (a recent one i7-7 Gen), I didn't change anything in the code, 3 minutes for a little json,
after test I noticed that this row of code takes a long time to execute (a couple of second for each iteration) :
json_CopyMemory ByVal json_UnsignedAdd(StrPtr(json_buffer),  json_BufferPosition), ByVal StrPtr(json_Append),  json_AppendLength
do you have an idea where this comes from?

I believe I now have the exact same problem. It broke my process dependent on this converter.  It must be one of these latest Excel 2017 updates that broke this.   This is on Windows side.
My json is about 80k large, and when i interrupt the loop it seems stuck in the subroutine:
'Private Sub json_BufferAppend(ByRef json_buffer As String, _
ByRef json_Append As Variant, _
ByRef json_BufferPosition As Long, _
ByRef json_BufferLength As Long)'

@Locke  try with this, it works for me
https://github.com/PGS62/VBA-JSON/blob/0a88ffd8fd4a73ba58ba6b95cd463271062d0180/JsonConverter.bas

Hi guys,
struggling here, not so familiar with Git
i've downloaded and installed the new JsonConverter.bas file
but now i have an error message on Dim cSA As New clsStringAppend -> Compile error - user defined type not defined.
Any guidance appreciated

@hlalibe you have just to add the class clsStringAppend.cls in your project

@hlalibe in your project insert a new Class Module from menu and copy the code into

ok got it,
but i had to comment out these 4 first lines to avoid compiling errors
VERSION 1.0 CLASS
BEGIN
MultiUse = -1  'True
END

@rachid-adf
Thanks a lot for your solution!

Hi There,
@rachid-adf @Locke Could you take a look at the link and let me know whether mine is the same problem as yours... I can't quite decide.
https://github.com/VBA-tools/VBA-Web/issues/345
Thanks,
Duncan

Hey @rachid-adf, I've been getting "Compile error: Expected: end of statement", while running the class module code you've shared above.
Could you please help me on this ?

Hey @rachid-adf, I've been getting "Compile error: Expected: end of statement", while running the class module code you've shared above.
Could you please help me on this ?

Hi @iamanubhavp, juste delete all text before  Option Explicit, and also delete the rows numbers

@rachid-adf, I already tried doing that. I think the issue here is with the way I'm running this code. I think I need to import the code .BAS & .cls file.
Is that correct ?

@iamanubhavp What version of VBA-JSON are you using? The clsStringAppend approach is part of v2.3.0 and later (you can download the latest version here: https://github.com/VBA-tools/VBA-JSON/releases/latest

Thanks @timhall , I resolved it by importing .bas & .cls files rather than  copy/pasting the code into the modules.


FTS: Full-Text Search API Epic

Problem Statement
Searching for information is one of the most common tasks on the internet. We use Google to search the world-wide web, but many applications also want a more focused search to offer their users.
There are a couple specialized tools for doing full-text search like meilisearch and Algolia, but this is yet another tool you need to setup and manage. Additionally, most of the databases we support have built-in support for full-text search. Since your application likely requires a database, it's often easiest to start with the database's full-text search support.
Unfortunately, Prisma doesn't expose these capabilities yet, so you can't take advantage of the database's built-in support. This issue aims to change that.
Tasks

[x] #7960
[x] #8271
[x] #7961
[ ] https://github.com/prisma/prisma-engines/pull/2137
[ ] #8694
[ ] #8695
[ ] https://github.com/prisma/docs/issues/2137

References

Community Issue: #1684
Internal Document

O.O

Which connectors will support this? (all of them?, it's not clear from the description)

Algolia in docs provides much more than just a full search query though so probably not.
It's much faster for a docs usecase and matches typos and more (analytics, synonyms...).

Algolia makes it much more convenient. But both SQLite and PostgreSQL (I guess MySQL too) can match typos, synonyms, and have other features.

@Jolg42, we're focusing on Postgres right now. In the future we'd like to support MySQL and SQLite, but for those databases, we need to define indexes in the Prisma Schema.
@molebox, it would be some work to migrate over but it should be possible!

Since these epics are more for our internal planning, I'm going to lock this issue. Please feel free to comment in the original Feature Request issue.


Update during-and-after-your-data-move.md

Added UAE dates

@denisebmsft - PR is ready for final review. Thank you.


Added boost, tbb, ilmbase, pyilmbase and openexr docker builder jobs

This PR introduces new 3rdparty jenkins jobs that build binaries of the VFX Platform packages on linux.
So far, here is a list of jobs and their inter-dependencies:
[('boost', []),
 ('tbb', []),
 ('ilmbase', []),
 ('pyilmbase', ['boost', 'ilmbase']),
 ('openexr', ['ilmbase'])
]

For now the jobs are not uploading their artifacts to nexus, so building pyilmbase and openexr will fail on the jenkins platform.
A new build_local.py script allows running the whole chain of builds on a single machine with docker installed, binaries are pretty much guaranteed to be identical as the ones built by jenkins.

Closing as we now have a new aswf-docker repo.


fix: resolve console warning for propTypes of

Ref: https://github.com/facebook/prop-types/issues/228

This resolved my issue chnaging
From
textStyle={styles.spinnerTextStyle}
To
textStyle={{color:"white", fontSize: 17, lineHeight: 22}}

PR welcome


Auto generated method coverage doesn't filled

Describe the bug
Auto generated method doesn't filled coverage.
Expected behavior
filled coverage or do not check auto generated method
Reports

Coverage summary

Source code report

Environment

Kover Gradle Plugin version: : 0.7.3
Gradle version: 7.5.1
Kotlin project type: Kotlin
Coverage Toolset (if customized in build script): Kover
Other context important for this bug: mac OS m1

It's okay not to check for auto-generated methods using a workaround 😄

As far as I understand, by auto generated method you meant synthetic class-files like ...$merchants$1.
The fact that they are displayed to the user separately is a disadvantage of the Kover HTML report.

Closed in favor of https://github.com/Kotlin/kotlinx-kover/issues/498


Static-data example doesn't work on tag v0.1.4

I've recently adopted a codebase that uses v0.1.4 and so am trying to wrap my head around how it works. I downloaded the zip of the archive and opened examples/static-data/index.html in Chrome. According to the Network tab the following files 404:

examples/_build_/shared.js
examples/_build_/static-data.js

static-data.js is in the same folder so I could easily fix the path in index.html but I don't see shared.js anywhere. I tried npm i && npm start as mentioned in #46 but still no luck (I've reported that issue as well at #107).

@frankpinto I don't recall there being any super breaking changes on the follow 2 releases. There is some changes for the 1.0.0-rc*, are you unable to upgrade?

@sprjr sure, I think I'm going to try that now anyway as there's also an issue on this tag with iPhones I just ran into. You can't select anything.

any changelog or upgrade gotchas?


llvm/clang not installed with rocm-3.7 on centos

when upgrading from rocm-3.5 to rocm-3.7 on centos7, looks like llvm is not installed in /opt/rocm:
> yum autoremove rocm-opencl rocm-dkms rock-dkms
> yum update
> yum install rocm-dkms
Installing:
 rocm-dkms x86_64 3.7.0_20-1 ROCm 3.8 k
Installing for dependencies:
 hip-rocclr x86_64 3.7.20315_077bcfa0-1 ROCm 674 k
 hip-samples x86_64 3.7.20315_077bcfa0-1 ROCm 68 k
 rock-dkms noarch 1:3.7-20.el7 ROCm 7.4 M
 rocm-clang-ocl x86_64 <IP_ADDRESS>_rocm_rel_3.7_20_7b47f7d-1 ROCm 4.6 k
 rocm-dev x86_64 3.7.0_20-1 ROCm 4.2 k
 rocm-opencl x86_64 <IP_ADDRESS>3_rocm_rel_3.7_20_3f18143-1 ROCm 462 k
 rocm-opencl-devel x86_64 <IP_ADDRESS>3_rocm_rel_3.7_20_3f18143-1 ROCm 91 k
 rocm-utils x86_64 3.7.0_20-1 ROCm 3.8 k
 rocprofiler-dev x86_64 1.0.0-1 ROCm 211 k
 roctracer-dev x86_64 1.0.0-1 ROCm 265 k

> rpm -qa | grep rocm | sort
comgr-<IP_ADDRESS>_rocm_rel_3.7_20_6670e0d-1.x86_64
hsa-rocr-dev-1.2.30700.0_rocm_rel_3.7_20_99e66a7a-1.x86_64
rocm-clang-ocl-<IP_ADDRESS>_rocm_rel_3.7_20_7b47f7d-1.x86_64
rocm-cmake-<IP_ADDRESS>_rocm_rel_3.7_20_1d1caa5-1.x86_64
rocm-dbgapi-0.30.0_rocm_rel_3.7_20-1.x86_64
rocm-debug-agent-2.0.1_rocm_rel_3.7_20-1.x86_64
rocm-dev-3.7.0_20-1.x86_64
rocm-device-libs-<IP_ADDRESS>8_rocm_rel_3.7_20_5ff5319-1.x86_64
rocm-dkms-3.7.0_20-1.x86_64
rocm-gdb-9.2_rocm_rel_3.7_20-1.x86_64
rocminfo-1.30700.0-1.x86_64
rocm-opencl-<IP_ADDRESS>3_rocm_rel_3.7_20_3f18143-1.x86_64
rocm-opencl-devel-<IP_ADDRESS>3_rocm_rel_3.7_20_3f18143-1.x86_64
rocm-smi-1.0.0_204_rocm_rel_3.7_20_g08ebddd-1.x86_64
rocm-smi-lib64-<IP_ADDRESS>.rocm_rel_3.7_20_d325613-1.x86_64
rocm-utils-3.7.0_20-1.x86_64

> /opt/rocm-3.7.0/bin/hipcc --version
Can't exec "/opt/rocm-3.7.0/llvm/bin/clang++": No such file or directory at /opt/rocm-3.7.0/hip/bin/hipconfig line 141.

> ls /opt/rocm-3.7.0
total 48
4 bin/	4 hsa/	    4 lib/    4 oam/	 4 rocm_smi/	 4 roctracer/
4 hip/	4 include/  4 lib64/  4 opencl/  4 rocprofiler/  4 share/

hmm, looks like one needs to reinstall a few packages, such as llvm-amdgpu and hsa-amd-aqlprofile, as I'm guessing these are installed in /opt/rocm which is a soft link to the current version, but when you go from say 3.5 to 3.7, this gets lost.
perhaps the documentation could be updated?

"FRESH INSTALLATION OF AMD ROCm V3.7 RECOMMENDED
A fresh and clean installation of AMD ROCm v3.7 is recommended. An upgrade from previous releases to AMD ROCm v3.7 is not supported."
https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html

"FRESH INSTALLATION OF AMD ROCm V3.7 RECOMMENDED

so I'm not sure what part of  yum autoremove rocm-opencl rocm-dkms rock-dkms doesn't look like a "FRESH INSTALLATION"
The problem is that llvm-amdgpu is not part of the rocm metapackge, so it doesn't get removed, and reinstalled automatically. But hipcc requires llvm-amdgpu to function. Yet the installation of the metapackage breaks llvm-amdgpu (and other packages) as it moves the soft link of /opt/rocm to point to /opt/rocm-3.7.0. So either the dependencies of llvm-amdgpu need to be fixed, or it needs to be brought into rocm, or the instructions need some work, so that ALL packages that are installed in /opt/rocm are identified and the user is told to reinstall them.

I seemed to have a similar issue, which was alleviated by installing the explicitly named llvm-amdgpu package like so:
sudo apt install llvm-amdgpu4.2.0


Stop formatter from adding spaces inside braces.

I have problems when using parameters it works fine when using from inside vscode however the format that it creates causes problems when I place the report inside our database system. The formatter adds white space inside braces which causes the error.
I would like the option for the formatter to leave {staff_id} without whitespace instead of the current functionality changing it to { staff_id }

Same use case here, it would be awesome to have an option for this

I have the same need

Same here

Workaround is to disable formatting by setting "sqltools.formatLanguages": [],
Please make sure you restart VS Code after you do this.


module 'matplotlib.pyplot' has no attribute 'ishold'

Hi
When I run
show_map(romania_graph_data)
in search.ipynb, the search notbook I get this message:

AttributeError                            Traceback (most recent call last)
 in
----> 1 show_map(romania_graph_data)
~/notebook.py in show_map(graph_data, node_colors)
916     # draw the graph (both nodes and edges) with locations from romania_locations
917     nx.draw(G, pos={k: node_positions[k] for k in G.nodes()},
--> 918             node_color=[node_colors[node] for node in G.nodes()], linewidths=0.3, edgecolors='k')
919
920     # draw labels for nodes
/srv/conda/envs/notebook/lib/python3.7/site-packages/networkx/drawing/nx_pylab.py in draw(G, pos, ax, hold, **kwds)
124     if 'with_labels' not in kwds:
125         kwds['with_labels'] = 'labels' in kwds
--> 126     b = plt.ishold()
127     # allow callers to override the hold state by passing hold=True|False
128     h = kwds.pop('hold', None)
AttributeError: module 'matplotlib.pyplot' has no attribute 'ishold'
I am running on the binder environment
Thanks
Pub

Hi @pupinello ,
There are two ways I know of through which you can solve this error. You can either downgrade matplotlib to 2.2.3 or you can upgrade networkx package. In the latest version of networkx the issue might have been solved as I don't see the following lines of code there.

Hi @pupinello ,
There are two ways I know of through which you can solve this error. You can either downgrade matplotlib to 2.2.3 or you can upgrade networkx package. Upgrading networkx to 2.3 worked for me. Just follow:
pip uninstall networkx
pip install networkx
Thanks


Multiple copies of the same code

Its a bit difficult to navigate the code on this repository because there are several different versions of the code, corresponding to the different blog posts. There are a few things that you could do keep them separate without creating so many redundancies:

You could give them separate branches. This would require users who wanted to get one or the other to understand how to checkout different branches. You would be able to push fixes to earlier versions and propogate those changes to later versions by rebasing (although that would be a bit of a hassle.

You could tag them at each release point. This would allow you to keep the history nice and do some development on them. It would be easy to share the links to each release as well.

You could compress the whole repository as a certain point and then upload it as Blog_Post_1_release.zip or whatever. This would make it really easy for people to download the release that they want, but it would be impossible to maintain a specific release, unless you combined this strategy with one of the above.

Thanks for the suggestions Jake, I'll take a look at better ways to organize things. I'm working on some edits to the scaffold itself as well, which is also why the latest blog post is delayed.


Connect to API and refactor the code.

Connect to API.

Add redux-thunk to the project.
Use axios for making API calls.
Fetch book list from Bookstore API on Books page load.
Add an Action Creator, that returns a function.
Fetch list of books.
Dispatch another action (add an action type) that will pass API response to reducer and updates the state.
Refactor the add book and remove book features to persist the changes in the server.
Change the existing Action Creators, so they return functions.
Make changes by using API.
Dispatch an action (action type that existed before refactor) that will updates the state accordingly.

Please be sure to add the appropiate template to your readme file as its a key part of the general requirements 🤓


Proofread #1

Focused mainly on flow and punctuation rather than content. Where I wasn't able to reword I have tried tidying up.

@clazba great set of commits, thanks 👍 💯
Just made a couple small edits and merging it now


cmd/go: cc1: error: unrecognised debug output level "no-record-gcc-switches"

I am trying to build at tip on CentOS Linux and it fails with this error.
[rjammalamadaka@localhost src]$uname -a
Linux localhost.localdomain 2.6.32-573.12.1.el6.x86_64 #1 SMP Tue Dec 15 21:19:08 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
[rjammalamadaka@localhost src]$ go version
go version devel +387d5b8 Sat Feb 13 17:33:22 2016 +0000 linux/amd64
$ gcc --version
gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-16)
Copyright (C) 2010 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
runtime/cgo
cc1: error: unrecognised debug output level "no-record-gcc-switches"
runtime/debug
runtime/pprof
runtime/trace
internal/trace
go/internal/gccgoimporter
go/internal/gcimporter
testing
math/cmplx
net/internal/socktest
os/signal
internal/testenv
go/importer
runtime/race
testing/iotest
testing/quick
cmd/api
cmd/internal/obj/arm
cmd/internal/obj/arm64
cmd/internal/obj/mips
cmd/internal/obj/ppc64
cmd/internal/obj/x86
cmd/asm/internal/flags
cmd/asm/internal/lex
cmd/compile/internal/big
cmd/internal/gcprog
cmd/cover
cmd/asm/internal/arch
cmd/dist
cmd/asm/internal/asm
cmd/compile/internal/gc
cmd/asm
cmd/doc
cmd/fix
cmd/gofmt
cmd/link/internal/ld
cmd/newlink
cmd/nm
cmd/objdump
cmd/pack
cmd/link/internal/amd64
cmd/link/internal/arm
cmd/link/internal/arm64
cmd/link/internal/mips64
cmd/link/internal/ppc64
cmd/link/internal/x86
cmd/pprof/internal/profile
cmd/pprof/internal/svg
cmd/link
cmd/pprof/internal/tempfile
cmd/vet/internal/whitelist
cmd/vet
cmd/pprof/internal/plugin
cmd/pprof/internal/report
cmd/pprof/internal/symbolizer
cmd/pprof/internal/symbolz
cmd/yacc
cmd/pprof/internal/commands
cmd/pprof/internal/driver
cmd/compile/internal/amd64
cmd/compile/internal/arm
cmd/compile/internal/arm64
cmd/compile/internal/mips64
cmd/compile/internal/ppc64
cmd/compile/internal/x86
cmd/compile
[rjammalamadaka@localhost src]$
/cc: @ianlancetaylor

Should be fixed by https://golang.org/cl/19686 .


math/big: check padding of formatted NaN and Inf

Just a reminder to check if there are any issues related to #14421 in math/big (Floats).

No issues with Inf: http://play.golang.org/p/QSO6LF9Tlf
big.Float cannot be NaN


updated the SDK 7.0.304 version, but the bug won't go away.

The bugs I had in SDK 7.0.302 still seem to exist.
https://github.com/dotnet/razor/issues/8718#issue-1713326494

Same, I am running on sdk 7.0.304 and also tried out 7.0.400-preview.23274.1 and the bug is still there, though the components seem to render this time around. This occurs on both VS 17.6.4 and 17.7.0 Preview 2

The solution is the only thing I can do is force down the sdk version using global.json.

Can you confirm exactly which SDK + Visual Studio versions you are using? Thanks

@chsienki 7.0.304 + VS 17.6.4 for me. Also 7.0.400-preview.23274.1 and 17.7.0 Preview 2

Please don't close this, the issue is very annoying because I have to keep an instance of 17.5.4 installed to work with blazor projects.

Do you have a repro project that we can look at?

@jaredpar Here you go, though realistically all you need is a fresh blazor repo and add this:
@typeparam T where T : new()

LookAtMe

@code {

}

@Luk164 Could you confirm exactly which bug you're hitting? You mentioned above that "the components seem to render this time around" which makes me think that you are hitting a different bug than the comment linked above. This seems to be backed up by your repro file, which has no components.
Is it possible you're hitting https://github.com/dotnet/razor/issues/8572 instead?

@davidwengier RZ1017 I believe, so #8572 could be a match, but I am not sure. And yes it does indeed compile. I am currently stuck using VS17.5.4 as it is the last version I know of without the bug.

Thanks for confirming. That was fixed last week, so sadly there will be a little bit of a wait before its available in a VS release. Should be in the first preview of the next minor version of VS though.
The issue should fix itself when there is a project change of any kind, including just adding whitespace to the project file, but I understand that's not the most fun way to live :)

Closing as a dupe of #8572


Allow unused_unsafe for wasi

This change makes your PR pass the CI at libc repo

Ah I see this now, wound up getting merged directly.


feat: increase resource limits for providers

What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @whalecold

Release note:

NONE

/lgtm

/lgtm

/cherrypick release-0.5

/approve


Revert gc speed related optimization

What problem does this PR solve?
Issue Number: close #7925
Problem Summary: as stated in https://github.com/pingcap/tiflash/pull/7922
What is changed and how it works?
Revert gc related optimization in https://github.com/pingcap/tiflash/pull/7668 and https://github.com/pingcap/tiflash/pull/7779
Check List
Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-unit-test

/rebuild

/run-integration-test

/hold

/unhold


aggregateModules: fix x-compilation for out-of-tree kernel modules

Motivation for this change
Allows to cross-compile NixOS when boot.extraModulePackages is set.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

this looks reasonable. How could I check it works from my system: x86_64-linux", multi-user?: yes, version: nix-env (Nix) 2.2.2 machine ?

Hm, I tested this by cross-compiling NixOS Ext4 install image to aarch64-linux, but this is certainly not a minimal repro.


Remove media file only if it was uploaded

Description
Please describe your pull request:

Why is it necessary? When you use the Media Resource class for a local media import for article images e.g. the source image will be removed.
What does it improve? The source image will only be removed if it was uploaded via HTTP.
Does it have side effects? No.

Questions
Answers

BC breaks?
no

Tests pass?
yes

Related tickets?
no

How to test?
Write an image import using the Media resource and import a file with file:///path/to/my/file.jpg. The image should remain in the path after the import in Shopware.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/#/issues/SW-18242.
Please use this issue to track the state of your pull request.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-18767.
Please use this issue to track the state of your pull request.

Will this be merged in 5.2 or should I rebase/recreate this PR for 5.3?

hi @FiveDigital
we are going to merge this soon into 5.2

thanks @FiveDigital :+1:


downloadDependenciesFile fails when source repo doesn't have a dependencies file

Scenario: I'm downloading an individual file from a private repo using a known-good access token. I'm running paket install. This fails with "Credentials from authentication store for mytok are invalid."
Observation in the debugger:

Paket is requesting a paket.dependencies file from the source repo (the repo from which I'm fetching a file). This file does not exist.
I did not request paket.dependencies. Paket seems to think it should be there in the source repo.
Upon trying to retrieve the non-existent file checkCredentials fails ("The remote server returned an error: (404) Not Found."; this exception is swallowed), causing the error message above in GetAuthenticationForUrl. So it fails while trying to check dependencies.

Please verify that Paket should not require a paket.dependencies file in the source repo--the repo from which I'm fetching a file. This is undesirable behavior.
Let me know if you have questions. Here's the call stack when the exception is thrown; line numbers may be slightly off as I've added a little code for easier debugging:
 	Paket.Core.dll!Paket.ConfigFile.checkCredentials(string url = "https://raw.githubusercontent.com/SoundMetrics/arepo/longpath/command-module/paket.dependencies", Microsoft.FSharp.Core.FSharpOption<Paket.Utils.Auth> cred = Some({Paket.Utils.Auth.Token})) Line 126	F#
 	Paket.Core.dll!Paket.ConfigFile.GetAuthenticationForUrl(string source = "mytok", string url = "https://raw.githubusercontent.com/SoundMetrics/arepo/longpath/paket.dependencies") Line 157	F#
 	Paket.Core.dll!Paket.RemoteDownload.auth@81-1.Invoke(string key = "mytok") Line 81	F#
	Paket.Core.dll!Paket.RemoteDownload.downloadDependenciesFile@65<Paket.DependenciesFile>.Invoke(Microsoft.FSharp.Core.Unit unitVar = null) Line 79	F#

sUnfortunately I can' reproduce so this might be a little ping pong. I made a fix around that code. Can you please try with latest version?

This appears to work with Paket version <IP_ADDRESS>. Thanks!.


Directly use store object in data-store cache instead of a json string

Now in our ISPNDataStoreMgr, we are storing the store data as json
string, and when querying we need to deser the json to object each time.
As the query for store is a high frequent ops, this may cause some time
wasting, so we need to think about to use the store object directly in
cache.

I need further check on this seems it does not work correctly. Closed.


Docs/vpnclient

Added a troubleshooting guide to openvpn client connections

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@jnummelin Thank you, I update the doc with your review.

This makes #2001 obsolete?

Yes. this pull request include #2001

BTW the VPN client in particular is something that's very tricky, because of all the variety in client OS configurations.
The current "known issue" for this is something like #1705 (+ #264, #1243), but those are what I mean by the GitHub issues being disorganized...

The docs have been moved to https://github.com/kontena/docs, any docs PRs need to be re-submitted there.


Discriminator Inference: Not generating despite completely unique fields

What version of ogen are you using?
0.82.0
Can this issue be reproduced with the latest version?
Yes
What did you do?
Ran generator script in my repo to generate client:  (cd api-spec; npm run build:public && npm run build:internal) && ./generate.sh
Which has the following line in generate.sh:
go run<EMAIL_ADDRESS>--config=config.json --target client --clean ./api-spec/dist/public-api.yml
All of the types in the union with the issue have unique required fields, yet I get the error below when trying to generate.
 Adding that last line back in gives the error. This doesn't make sense, according to the docs (https://ogen.dev/docs/types/sumtype/#unique-fields-discriminator) you need to have unique required fields, which this entry definitely does, so I'm not sure how it can be changed to build a successfully generated client that includes endpoints reliant on this type.
What did you expect to see?
Successful generation of the client.
What did you see instead?

Feature "discriminator inference" is not implemented yet.
Try to create ogen.yml with:

generator:
        ignore_not_implemented: "discriminator inference"

or

generator:
        ignore_not_implemented: ["all"]

to skip unsupported operations.

generation failed:
    main.run
        /home/alex/go/pkg/mod/github.com/ogen-go/ogen@v0.82.0/cmd/ogen/main.go:308
exit status 1

It does seems like Run has no unique fields.

id is defined by many schemes, e.g. ApiKey
creator is defined by many schemes, e.g. ApiKey
hub_id is defined by many schemes, e.g. ApiKey
pipeline_id is defined by TriggerKey too
stages is defined by Pipeline too
state is defned by many schemes, e.g. ApiKey
events is defined by many schemes, e.g. ApiKey
variables is defined by Stack too

We should improve error reporting in that case, I think.


JSON Decode Error

Tried running the sample code and got a JSON Decode error.  Here is the stack trace:

JSONDecodeError                           Traceback (most recent call last)
Cell In[4], line 13
8 #pagination is for the list that you see at the right when searching
9 #you don't need to iterate over all the pages because zillow sends the whole data on mapresults at once on the first page
10 #however the maximum result zillow returns is 500, so if mapResults is 500
11 #try playing with the zoom or moving the coordinates, pagination won't help because you will always get at maximum 500 results
12 pagination = 1
---> 13 results_sold = pyzill.sold(pagination, ne_lat,ne_long,sw_lat,sw_long,zoom_value, "")
14 results_sale = pyzill.for_sale(pagination, ne_lat,ne_long,sw_lat,sw_long,zoom_value, "")
15 results_rent = pyzill.for_rent(pagination, ne_lat,ne_long,sw_lat,sw_long,zoom_value, "")
File ~/sandbox/lib/python3.10/site-packages/pyzill/search.py:120, in sold(pagination, ne_lat, ne_long, sw_lat, sw_long, zoom_value, proxy_url)
89     """get results of the listing that were sold, you will get a dictionary with the keywords
90     mapResults and listResults, use mapResults which contains all the listings from all paginations
91     listResults is more for the right side bar that you see when searching on zillow.
(...)
106         dict[str, Any]: listing of properties in JSON format
107     """
108     rent = {
109 		"sortSelection":  {"value": "globalrelevanceex"},
110 		"isNewConstruction":  {"value": False},
(...)
118 		"isRecentlySold":  {"value": True},
119 	}
--> 120     return search(pagination,ne_lat,ne_long,sw_lat,sw_long,zoom_value,rent,proxy_url)
File ~/sandbox/lib/python3.10/site-packages/pyzill/search.py:195, in search(pagination, ne_lat, ne_long, sw_lat, sw_long, zoom_value, filter_state, proxy_url)
187 proxies = {"http": proxy_url, "https": proxy_url} if proxy_url else None
188 response = requests.put(
189     url="https://www.zillow.com/async-create-search-page-state",
190     json=inputData,
(...)
193     impersonate="chrome110",
194 )
--> 195 data = response.json()
196 return data.get("cat1", {}).get("searchResults", {})
File ~/sandbox/lib/python3.10/site-packages/curl_cffi/requests/models.py:200, in Response.json(self, **kw)
198 def json(self, **kw):
199     """return a parsed json object of the content."""
--> 200     return loads(self.content, **kw)
File /usr/lib/python3.10/json/init.py:346, in loads(s, cls, object_hook, parse_float, parse_int, parse_constant, object_pairs_hook, **kw)
341     s = s.decode(detect_encoding(s), 'surrogatepass')
343 if (cls is None and object_hook is None and
344         parse_int is None and parse_float is None and
345         parse_constant is None and object_pairs_hook is None and not kw):
--> 346     return _default_decoder.decode(s)
347 if cls is None:
348     cls = JSONDecoder
File /usr/lib/python3.10/json/decoder.py:337, in JSONDecoder.decode(self, s, _w)
332 def decode(self, s, _w=WHITESPACE.match):
333     """Return the Python representation of s (a str instance
334     containing a JSON document).
335
336     """
--> 337     obj, end = self.raw_decode(s, idx=_w(s, 0).end())
338     end = _w(s, end).end()
339     if end != len(s):
File /usr/lib/python3.10/json/decoder.py:355, in JSONDecoder.raw_decode(self, s, idx)
353     obj, end = self.scan_once(s, idx)
354 except StopIteration as err:
--> 355     raise JSONDecodeError("Expecting value", s, err.value) from None
356 return obj, end
JSONDecodeError: Expecting value: line 1 column 1 (char 0)

I wasn't able to replicate the issue. Could you try using a VPN or a proxy to check if it works?
It's working well on my side. What probably happened is that you were making multiple calls to Zillow's server, and it flagged your IP

I apologize.  I just tried it again and it worked - without a VPN.  The only thing I did differently is I created a new virtual environment, so I could send over a package list.  So... don't know what to tell you.  Sorry to waste your time.

You will need to use residentials proxies, they block non residential IPs


Create reconciler for LogModule deployment.conf

Description
K8S-10615

Adds a base reconciler for the LogModule section
Adds a small secret reconciler for the deployment.conf of the LogModule

How can this be tested?
Deploy a dk with logModule.enabled=true:

check the conditions on the dk
check the secret was created (<dk>-logmodule-config)

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 87.09677% with 12 lines in your changes missing coverage. Please review.

Project coverage is 64.95%. Comparing base (174dbbd) to head (f1da51a).

Files with missing lines
Patch %
Lines

...lers/dynakube/logmodule/configsecret/reconciler.go
82.60%
7 Missing and 5 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3774      +/-   ##
==========================================
+ Coverage   64.85%   64.95%   +0.09%
==========================================
  Files         387      389       +2
  Lines       21214    21306      +92
==========================================
+ Hits        13759    13839      +80
- Misses       6133     6140       +7
- Partials     1322     1327       +5

Flag
Coverage Δ

unittests
64.95% <87.09%> (+0.09%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


WIP: enable grpc stats when enabling Bigtable stats

To get a full picture of metrics for the bigtable client, the customer would need to look at both operation metrics and grpc rpc metrics. This was previously disabled because grpc metrics had a bug that prevented the method and status tags from being populated. This was fixed in https://github.com/grpc/grpc-java/pull/5996 which was released in version 1.24

After some discussion with marcal, we decided that we should tag views with project/instance/table ids. So will need to create my own views for grpc level


test(v2): Make unit test is determinate

Motivation
Problem in docusaurus-plugin-content-blog.
Result of test different on local machine from server because order of blog posts depends on birthday of file.
Also two blog posts have similar date. It can affect to order.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
If you clone repository before 2020-02-27, maybe you don't have error.
For reproduce, you need recreate file docusaurus-plugin-content-blog/src/tests/fixtures/website/blog/no date.md
and run
yarn test docusaurus-plugin-content-blog

thanks 👍


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-30-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4308

Questions ?
Please refer to the Backport tool documentation


Fix setuptools installation

Installing directly from pip isn't working because setup.py lists
'py_modules="guided_diffusion', rather than
'package=["guided_diffusion"]'

Is there anything I need to do to merge this?


Adding ETag support for If-Match header

If-Match RFC: https://tools.ietf.org/html/rfc7232#section-3.1
sample of usage:
╰─$ curl -i -1 -H 'If-Match: "ec6632fd7da26584a7953727e320f28f92ac3b"' http://<IP_ADDRESS>:7000/api/service/v1/service-status
HTTP/1.0 412 PRECONDITION FAILED
ETag: "b794fc43a15de07a30d3a700f08c0805"
Date: Mon, 18 Dec 2017 10:03:15 GMT
Accept-Ranges: none
Connection: close
Server: Werkzeug/0.14.dev Python/3.5.2

╰─$ curl -i -1 -H 'If-Match: "b794fc43a15de07a30d3a700f08c0805"' http://<IP_ADDRESS>:7000/api/service/v1/service-status
HTTP/1.0 200 OK
Content-Type: application/json
Content-Length: 16
ETag: "b794fc43a15de07a30d3a700f08c0805"
Date: Mon, 18 Dec 2017 11:14:23 GMT
Accept-Ranges: none
Server: Werkzeug/0.14.dev Python/3.5.2

{"status": "OK"}

Closing in favor of #1223 which is basically the same thing sans reformatting.


Add Komi-san wa, Comyushou desu

TVDB entry is here

Looks good! Sorry caught COVID and wasn't online much past few days

No worries! Thanks for the merge; get rested!


win7 X64 run easyrdma_recv.exe and easyrdma_send.exe  Error creating session: -734010   Invalid address.

i have one linux server and one win7 ,  win7_x64 net driver is  MLNX_VPI_WinOF-5_35_All_Win7_x64 and close firewall . linux and win7 can ping each other . when i use nd_rping in win7  Will appear
 .im not sure its driver have problem.
when i run  easyrdma_recv.exe or easyrdma_send.exe   ,The console will generate  Error creating session: -734010   Invalid address.,but I am sure I have entered the correct address.
i dont kown     { (int)(0xC00000CC),            easyrdma_Error_InvalidAddress     }, // STATUS_BAD_NETWORK_NAME from DDK  In source easyrdma-add-examples/core/windows/RdmaErrorTranslation.cpp  38 line

It does seem like something to do with the Mellanox driver or the network setup itself. I'd encourage you to check with NVIDIA support instead.


feat: Add stars.add and stars.remove methods

Hey, I'm fine with the changes in general, but I wonder if you know this:

Stars can still be added via stars.add but they can no longer be viewed or interacted with by end-users. Additionally, the star_added event is no longer emitted. We recommend retiring any app functionality that relies on stars APIs.

Yes, I know about the deprecation of stars.
Actually stars.list does not work anymore (ie. it always send a empty list) but we can still receive events for "save for later" (add or remove) items as star_added and star_removed events.
Same, the methods stars.add and stars.remove still work for "save for later" items. Unfortunately, there is no "save for later" public API yet so I will rely on the stars API as long as it works 🤷


ci: golangci incorrectly configured

Summary of Bug
Warning: Unexpected input(s) 'skip-go-installation', valid inputs are ['version', 'args', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-pkg-cache', 'skip-build-cache']

observed in https://github.com/celestiaorg/celestia-app/runs/7532201959?check_suite_focus=true
Version
https://github.com/celestiaorg/celestia-app/pull/567/commits/a3b71c13917dd40ee6fac9ff2a11caa5ddca13b1
Steps to Reproduce
Run CI
For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

v3.0.0+ requires explicit setup-go installation step prior to using this action: uses: actions/setup-go@v3. The skip-go-installation option has been removed.

From https://github.com/golangci/golangci-lint-action

so I guess because of https://github.com/celestiaorg/celestia-app/blob/dbf250764c533434865e8bf3cb78938040c0fa99/.github/workflows/lint.yml#L18, we can simply remove https://github.com/celestiaorg/celestia-app/blob/dbf250764c533434865e8bf3cb78938040c0fa99/.github/workflows/lint.yml#L32
?

Yep exactly.
https://github.com/celestiaorg/celestia-app/blob/dbf250764c533434865e8bf3cb78938040c0fa99/.github/workflows/lint.yml#L16-L18
v3.0.0+ of golangci-lint requires actions/setup-go@v3 in a previous step (which we have). skip-go-installation is no longer respected in golangci-lint-action v3.0.0 so this PR removes it.


Might this be malware?

https://www.gnu.org/proprietary/malware-microsoft.en.html

Windows 10 is great, it got better. But data collection and forced "antivirus protection" is unnecessary and bloated. Why does Microsoft need to do this? when using a popular Linux distro you don't experience extensive data collection like you do on Microsoft's software.

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

I agree, Microsoft improved their products very well these past few years and I would very much recommend windows 10 to my company, colleagues and customers if it just made lighter to use and less "annoying".

There should be a report button for obvious spam like this.

There should be a report button for obvious spam and trolling like this.

With all due respect, is not spam nor trolling. If you read the relevant information I provided there are clear violations that Microsoft should follow up on before placing this software in any sort of reach for users.

I don't understand how this issue can be considered as spam, I really doubt people from Microsoft would like to discuss issues like this or even think about it. As a result most of our opinions would be tossed aside.
However, a response to the actual problem is never harmful.

I'll just answer to this:

Also, since Calculator as far as I can tell depends on the proprietary WinRT, it is neither fully-free nor auditable after compile-time.

This is true, but it's an irrelevant point. Nothing in GitHub's TOS prohibits this, which would be silly anyway.
Any further commentary would be feeding the trolls. You're not fooling anyone but yourselves pretending this is anything else.

Closing for being off-topic and opinion-based.  If there are specific issues that can be addressed, we welcome the constructive feedback following our Issue process.

lol wut

Good game.

Closing for being off-topic and opinion-based. If there are specific issues that can be addressed, we welcome the constructive feedback following our Issue process.

Good game. Great to see Microsoft making forward progress on critical issues.

How did you manage to completely miss the hypocrisy of promoting open software but then attempting to censor a github repo you don't like based on an opinionated hit-piece by a competitor?
This passive-aggressive nonsense achieves nothing and suffocates actual dialog between Microsoft & OSS communities.

Good game. Great to see Microsoft making forward progress on critical issues.

This isn't critical whatsoever.


Play conversations until the end

Right now, there's no way to view an entire conversation from start to finish.
When you load in a file, you should be able to load an entire conversation from said file and go test the entire thing. You can progress the dialogue by pressing a "Next" button on the UI.

I've added the next button and it'll go until you reach the exit. Once you reach the exit, you can't progress further and need to select elsewhere.

This has been done, and you can loop around.


Update action-fuel-toolchain to v0.2.0 in CI

Type of change

Other (describe below)

Changes
The following changes have been made:

Forc is set to 0.19.2
Core is set to 0.10.1

Notes

Once some recently created PRs go in then this can be bumped up again

Related Issues
Closes #199

Is this a draft or ready for review?


Add eval support

Current dependencies on/for this PR:

main

PR #73

PR #74

PR #75

PR #76

PR #77

PR #78

PR #86   👈

This comment was auto-generated by Graphite.


Add support for more recent versions of libicu

See http://icu-project.org/apiref/icu4c/
API changes are documented in there.  It seems the most recent versions of ubuntu are using 53, we should attempt to support the newer versions.

Hey, one of our system guy is telling me this:
Yeah. I've built it OK on 14.04 VM with libicu-dev 52.
Ubuntu 12.04 we use in prod does have old libicu-dev 48.
Both build OK with node 0.12. I have no warnings I had with 0.10.

Yeah I've had no issues on ubuntu with multiple version of libicu too.

This issue arises because people were having issues at reporting it to be version issues, but I think that was not actually the issue.

I guess we can just ask them to use Node.js 0.12 then.


Difficult to style the card

Hi lepture, I'm very new to web development and I am trying to include your style of github card on my website. I've been using a lot of the Flexible Box Model, but your card doesn't seem to be doing very well with centering vertically in my horizontal layout. Here is a screenshot:

Please let me know if you have any suggestions, I could be missing something obvious.
Here is the code I'm using.

The card is an iframe. You can wrap it with a div and style this div yourself.

I have tried wrapping it in a div and it still snaps from the center to the top once the page finishes loading

The iframe appears to be making itself much bigger than it needs to be. Here is a screenshot from Chrome (the card is on the very left being cut off by the screen):

As it is, the iframe has a size of 400 x 296 px, and as a result the surrounding div has a size of 400 x 300. However, looking at it, it shouldn't be anywhere near as tall as 300 px, it should be well less than 200px tall given its shape.

It is not mobile friendly too, can you please fix the fixed width issue?


failed to  run google circuit from https://datadryad.org/stash/dataset/doi:10.5061/dryad.k6t1rj8 , circuits  in /tests/input are ok.

it seems that Hyquas can only handle  two-qubit controlled gate?


ops.model.ModelError: ERROR invalid value "content-from-git/1" for option -s: getting filesystem attachment info: filesystem attachment "1" on "unit cos-configuration/0" not provisioned

Bug Description
It's a race condition in a deployment and the charm can turn into an error state.
unit-cos-configuration-ceph-0: 13:06:39 INFO juju.worker.uniter found queued "install" hook
unit-cos-configuration-ceph-0: 13:06:40 DEBUG unit.cos-configuration-ceph/0.juju-log ops 2.4.1 up and running.
unit-cos-configuration-ceph-0: 13:06:40 INFO unit.cos-configuration-ceph/0.juju-log Running legacy hooks/install.
unit-cos-configuration-ceph-0: 13:06:40 DEBUG unit.cos-configuration-ceph/0.juju-log ops 2.4.1 up and running.
unit-cos-configuration-ceph-0: 13:06:40 DEBUG unit.cos-configuration-ceph/0.juju-log Charm called itself via hooks/install.
unit-cos-configuration-ceph-0: 13:06:40 DEBUG unit.cos-configuration-ceph/0.juju-log Legacy hooks/install exited with status 0.
unit-cos-configuration-ceph-0: 13:06:41 ERROR unit.cos-configuration-ceph/0.juju-log Uncaught exception while in charm code:
Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-cos-configuration-ceph-0/charm/venv/ops/model.py", line 2693, in _run
    result = subprocess.run(args, **kwargs)  # type: ignore
  File "/usr/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '('/var/lib/juju/tools/unit-cos-configuration-ceph-0/storage-get', '-s', 'content-from-git/1', 'location', '--format=json')' returned non-zero exit status 2.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./src/charm.py", line 473, in <module>
    main(COSConfigCharm, use_juju_for_storage=True)
  File "/var/lib/juju/agents/unit-cos-configuration-ceph-0/charm/venv/ops/main.py", line 429, in main
    charm = charm_class(framework)
  File "./src/charm.py", line 84, in __init__
    self._git_sync_mount_point = self.model.storages["content-from-git"][0].location
  File "/var/lib/juju/agents/unit-cos-configuration-ceph-0/charm/venv/ops/model.py", line 1792, in location
    raw = self._backend.storage_get(self.full_id, "location")
  File "/var/lib/juju/agents/unit-cos-configuration-ceph-0/charm/venv/ops/model.py", line 2919, in storage_get
    out = self._run('storage-get', '-s', storage_name_id, attribute,
  File "/var/lib/juju/agents/unit-cos-configuration-ceph-0/charm/venv/ops/model.py", line 2695, in _run
    raise ModelError(e.stderr)
ops.model.ModelError: ERROR invalid value "content-from-git/1" for option -s: getting filesystem attachment info: filesystem attachment "1" on "unit cos-configuration-ceph/0" not provisioned

unit-cos-configuration-ceph-0: 13:06:41 ERROR juju.worker.uniter.operation hook "install" (via hook dispatching script: dispatch) failed: exit status 1

To Reproduce

juju deploy cos-lite --trust --channel latest/edge
juju deploy cos-configuration-k8s cos-configuration-ceph --config ...

Environment
prometheus-scrape-config-k8s  latest/edge   47
Relevant log output
$ juju show-status-log cos-configuration-ceph/0 --days 1
Time                   Type       Status       Message
01 Mar 2024 13:06:00Z  juju-unit  allocating
01 Mar 2024 13:06:00Z  workload   waiting      installing agent
01 Mar 2024 13:06:34Z  workload   waiting      agent initialising
01 Mar 2024 13:06:39Z  juju-unit  executing    running install hook
01 Mar 2024 13:06:41Z  juju-unit  error        hook failed: "install"
01 Mar 2024 13:06:46Z  workload   maintenance  installing charm software
01 Mar 2024 13:06:46Z  juju-unit  executing    running install hook
01 Mar 2024 13:06:50Z  juju-unit  executing    running prometheus-config-relation-created hook
01 Mar 2024 13:06:51Z  juju-unit  executing    running replicas-relation-created hook
01 Mar 2024 13:06:51Z  juju-unit  executing    running grafana-dashboards-relation-created hook
01 Mar 2024 13:06:52Z  juju-unit  executing    running leader-elected hook
01 Mar 2024 13:07:27Z  juju-unit  executing    running git-sync-pebble-ready hook
01 Mar 2024 13:07:29Z  juju-unit  executing    running content-from-git-storage-attached hook
01 Mar 2024 13:07:30Z  juju-unit  executing    running config-changed hook
01 Mar 2024 13:07:32Z  juju-unit  executing    running start hook
01 Mar 2024 13:07:34Z  juju-unit  executing    running grafana-dashboards-relation-joined hook for grafana/0
01 Mar 2024 13:07:36Z  juju-unit  executing    running grafana-dashboards-relation-changed hook for grafana/0
01 Mar 2024 13:07:37Z  juju-unit  executing    running replicas-relation-changed hook
01 Mar 2024 13:07:38Z  juju-unit  idle
01 Mar 2024 13:07:49Z  juju-unit  executing    running prometheus-config-relation-joined hook for prometheus/0
01 Mar 2024 13:07:51Z  juju-unit  executing    running prometheus-config-relation-changed hook for prometheus/0
01 Mar 2024 13:08:05Z  juju-unit  idle
01 Mar 2024 14:11:38Z  workload   active

Additional context
No response

Do you have any storage enabled on your k8s? This bug makes it sound like you possibly don't.

It was based on the cos-lite tutorial so hostpath storage was used.
As I stated it looked like a race condition.

Hi guys,
I've been affected by this issue as well when running integration tests that use a bundle that includes cos-configuration-k8. The error I receive is very similar:
Traceback (most recent call last):
  File "./src/charm.py", line 473, in <module>
    main(COSConfigCharm, use_juju_for_storage=True)
  File "/var/lib/juju/agents/unit-cos-configuration-0/charm/venv/ops/main.py", line 429, in main
    charm = charm_class(framework)
  File "./src/charm.py", line 84, in __init__
    self._git_sync_mount_point = self.model.storages["content-from-git"][0].location
  File "/var/lib/juju/agents/unit-cos-configuration-0/charm/venv/ops/model.py", line 1792, in location
    raw = self._backend.storage_get(self.full_id, "location")
  File "/var/lib/juju/agents/unit-cos-configuration-0/charm/venv/ops/model.py", line 2919, in storage_get
    out = self._run('storage-get', '-s', storage_name_id, attribute,
  File "/var/lib/juju/agents/unit-cos-configuration-0/charm/venv/ops/model.py", line 2695, in _run
    raise ModelError(e.stderr)
ops.model.ModelError: ERROR invalid value "content-from-git/1" for option -s: getting filesystem attachment info: filesystem attachment "1" on "unit cos-configuration/0" not provisioned

With a little bit of research and some help from the Observability team's Matrix channel, I think the problem occurs due to install hook being fired before the storage has been attached. In this case, the charm would not be able to access the storage and thus raise an exception.
I also found a similar issue in vault-k8s and they have fixed this by try-catch logic around accessing the storage.


Update mill-main, mill-scalalib to 0.11.1

About this PR
📦 Updates

com.lihaoyi:mill-main
com.lihaoyi:mill-scalalib

from 0.10.12 to 0.11.1
📜 GitHub Release Notes - Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (0.10.12).
You might want to review and update them manually.
build.sc

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.lihaoyi" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.lihaoyi" }
}]

labels: library-update, early-semver-major, semver-spec-minor, old-version-remains, commit-count:1

We keep the lower version for compatibility


Correct nested folders indentation

Maybe it would be great to make more unified indentation for folders and files. For now sometimes there is difficult to see which folder contains files.
Here is how it looks with vscode icons

Maybe with files icons aligned with folder's names it would be easier to locate nesting levels. Something like this.

Checklist:

[x] I'm sure this issue is not a duplicate?

I think this is not possible with the current Visual Studio Code api. The only thing we could do would be to modify the size of the icons but this would make the icons to be disaligned in tabs.
I think you should raise this issue into the vscode repo.


feat(cli): improve migration:check command to also print the schema diff

I think the migration:check command would be better if it also reported what the diff is. I am planning to run it in CI to ensure there isn't any migration drift, and I think it is helpful to have more information when it errors.
Example output:

This isn't super polished as I am not sure exactly how you'd prefer for it to work, so please let me know if there's any changes you'd like to see. Thanks!

Any reason you don't just use schema:update --dump?

Any reason you don't just use schema:update --dump?

I didn't know about that command. It looks like that should work for my use case. Feel free to close this PR then. 👍

this can be closed i think


Fix packet timebase handling during encoding.

We must not use the frame's timebase as frame is None while flushing the
encoder, which gives random results. In any case we know that frames were
rebased into the CodecContext's time_base.
For a lengthier discussion see #397

Problem solved by adding libx264 support to all our Travis builds (appveyor already had it).
As a nice side effect, we no longer skip test_encoding_h264.

I'm really liking this as our immediate solution.
I still want to go on that deep dive to finally decide, once and for all, how time works. But we don't have to do it today.

I agree - let's fix the immediate issue while retaining the overall behaviour and take a breath before we dive deeper. I'm now looking into the subleties of AVCodecContext.time_base vs AVStream.time_base


fix: the create-classroom modal changes size after user clicks drop-down menu

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #151

Fixed the width of the create-class drop down menu so it doesn't expand.
https://user-images.githubusercontent.com/112027089/197363279-5331facf-2710-4c04-bf29-9512d415dfb6.mp4

Hi there, thanks for taking this issue. Would it be possible to show us a video of the new behavior of the modal when things are selected? It would help us see the change between the old and the new. Thanks!

Hi there, thanks for taking this issue. Would it be possible to show us a video of the new behavior of the modal when things are selected? It would help us see the change between the old and the new. Thanks!

I added a video with the explanation to the pull request comments.

Awesome, great job! This looks good to me. @utsab I was thinking about also tagging this newly created issue, #167 since it's related to the UI of the modal. What do you think? Otherwise, this looks good to push.

Hey, there @imeltsner can you also make the same change in the edit feature under the ClassInviteTable.js component, for editOn modal, thank you.

Hi there, @egall18 I am from this micro-internship team. I'll be working on this.

Hello @egall18, I'm also from this micro-internship team. I will begin work on this issue as soon as possible.

Hi @egall18, I've made the same change to the editOn modal. Please review. Thanks.

Hi @egall18, I've made the same change to the editOn modal. Please review. Thanks.

LGTM


opening /* missing from catch.hpp single inculde (development)

I don't know if this was human-error or something wrong in the auto generation, but a single line /* is missing from the single include in the development branch around a comment
https://github.com/philsquared/Catch/blob/develop/single_include/catch.hpp#L1231

It's a generation issue (in the script that splices the headers together). I'll look into it properly at some stage but for now I've just changed the comment type to workaround the issue. The latest commit should be working again.
Sorry I didn't fix this sooner - I'm just going back over issues after a period away from the project. Someone else had reported this issue more recently too.


"DROP TABLE IF EXISTS tableid" does not execute callback

Hi,
I'm stuck with the above statement that does not execute a callback function in case the table did not exist.
Is there a workaround to execute the callback, even if there was no table to delete?
Thank you

Hmmmm. Good point...
Guess you could execute it sync by removing the callback argument.

Yep, but then it would not be async which is what I want =/


child Components are unnamed when jest run with --coverage flag

I get a different snapshot depending on whether Jest is run with --coverage. Specifically, when Jest is run with --coverage some but not all of the child components appear simply as <Component /> in the snapshot. When run without the --coverage flag all of the child Components appear in the snapshot with the correct name. Additionally, the components that appear as <Component /> are all stateless functional components written as arrow functions. The child components that retain their name regardless of the coverage flag are class components. I've had a lot of trouble trying to reproduce this issue in a mock repo, but thought it would still be helpful to put it on the project's radar. I can currently avoid the issue by always running tests with or without the coverage flag, but when I switch between the two I need to also update snapshots.

Hi!
Thanks for reporting the issue. It is a known issue to be fixed on Istanbul, see https://github.com/adriantoine/enzyme-to-json/issues/19#issuecomment-278634889.

Thanks! Sorry to waste your time. I missed that in my search before filing this issue.

No problem, thanks for reporting!


[Bug]: Can't use offline inference embedding

Your current environment
Collecting environment information...
/usr/local/cuda-11.1/targets/x86_64-linux/lib/libcudnn_adv_infer.so.8
/usr/local/cuda-11.1/targets/x86_64-linux/lib/libcudnn_adv_train.so.8
/usr/local/cuda-11.1/targets/x86_64-linux/lib/libcudnn_cnn_infer.so.8
/usr/local/cuda-11.1/targets/x86_64-linux/lib/libcudnn_cnn_train.so.8
/usr/local/cuda-11.1/targets/x86_64-linux/lib/libcudnn_ops_infer.so.8
/usr/local/cuda-11.1/targets/x86_64-linux/lib/libcudnn_ops_train.so.8
/usr/local/cuda-11.3/targets/x86_64-linux/lib/libcudnn.so.8
/usr/local/cuda-11.3/targets/x86_64-linux/lib/libcudnn_adv_infer.so.8
/usr/local/cuda-11.3/targets/x86_64-linux/lib/libcudnn_adv_train.so.8
/usr/local/cuda-11.3/targets/x86_64-linux/lib/libcudnn_cnn_infer.so.8
/usr/local/cuda-11.3/targets/x86_64-linux/lib/libcudnn_cnn_train.so.8
/usr/local/cuda-11.3/targets/x86_64-linux/lib/libcudnn_ops_infer.so.8
/usr/local/cuda-11.3/targets/x86_64-linux/lib/libcudnn_ops_train.so.8
/usr/local/cuda-11.7/targets/x86_64-linux/lib/libcudnn.so.8
/usr/local/cuda-11.7/targets/x86_64-linux/lib/libcudnn_adv_infer.so.8
/usr/local/cuda-11.7/targets/x86_64-linux/lib/libcudnn_adv_train.so.8
/usr/local/cuda-11.7/targets/x86_64-linux/lib/libcudnn_cnn_infer.so.8
/usr/local/cuda-11.7/targets/x86_64-linux/lib/libcudnn_cnn_train.so.8
/usr/local/cuda-11.7/targets/x86_64-linux/lib/libcudnn_ops_infer.so.8
/usr/local/cuda-11.7/targets/x86_64-linux/lib/libcudnn_ops_train.so.8
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      52 bits physical, 57 bits virtual
Byte Order:                         Little Endian
CPU(s):                             128
On-line CPU(s) list:                0-127
Vendor ID:                          GenuineIntel
Model name:                         Intel(R) Xeon(R) Platinum 8358 CPU @ 2.60GHz
CPU family:                         6
Model:                              106
Thread(s) per core:                 2
Core(s) per socket:                 32
Socket(s):                          2
Stepping:                           6
CPU max MHz:                        3400.0000
CPU min MHz:                        800.0000
BogoMIPS:                           5200.00
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass:    Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Enhanced IBRS, IBPB conditional, RSB filling, PBRSB-eIBRS SW sequence
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected
Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] torch==2.3.0
[pip3] triton==2.3.0
[pip3] vllm_nccl_cu12==<IP_ADDRESS>.4.0
[conda] numpy                     1.26.4                   pypi_0    pypi
[conda] nvidia-nccl-cu12          2.20.5                   pypi_0    pypi
[conda] torch                     2.3.0                    pypi_0    pypi
[conda] triton                    2.3.0                    pypi_0    pypi
[conda] vllm-nccl-cu12            <IP_ADDRESS>.4.0             pypi_0    pypiROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.4.2
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0    GPU1    GPU2    GPU3    GPU4    GPU5    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      PXB     PXB     PXB     SYS     SYS     0-31,64-95      0               N/A
GPU1    PXB      X      PXB     PXB     SYS     SYS     0-31,64-95      0               N/A
GPU2    PXB     PXB      X      PIX     SYS     SYS     0-31,64-95      0               N/A
GPU3    PXB     PXB     PIX      X      SYS     SYS     0-31,64-95      0               N/A
GPU4    SYS     SYS     SYS     SYS      X      PIX     32-63,96-127    1               N/A
GPU5    SYS     SYS     SYS     SYS     PIX      X      32-63,96-127    1               N/A
Legend:
X    = Self
SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
PIX  = Connection traversing at most a single PCIe bridge
NV#  = Connection traversing a bonded set of # NVLinks
🐛 Describe the bug
I use the example code of offline inference embedding at https://docs.vllm.ai/en/latest/getting_started/examples/offline_inference_embedding.html.  I only change the model path.
And I recieved this error as follow:
outputs = model.encode(prompts)
^^^^^^^^^^^^
AttributeError: 'LLM' object has no attribute 'encode'

Embedding models are going to be supported in v0.4.3
So, install from source to use now

Thank you very much. I will try to install new version.

Hello, I would like to ask why this error:
"---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
 in <cell line: 1>()
----> 1 outputs = model.encode(prompts)
10 frames
/content/vllm/vllm/model_executor/sampling_metadata.py in _prepare_seq_groups(seq_group_metadata_list, seq_lens, query_lens, device)
206
207         if seq_group_metadata.is_prompt:
--> 208             if sampling_params.seed is not None:
209                 seq_group_metadata.state.generator = torch.Generator(
210                     device=device).manual_seed(sampling_params.seed)
AttributeError: 'NoneType' object has no attribute 'seed'"occurs during use?
The model I'm using is llama3-8b, thanks!

Hello, I would like to ask why this error: "--------------------------------------------------------------------------- AttributeError Traceback (most recent call last) in <cell line: 1>() ----> 1 outputs = model.encode(prompts)
10 frames /content/vllm/vllm/model_executor/sampling_metadata.py in _prepare_seq_groups(seq_group_metadata_list, seq_lens, query_lens, device) 206 207 if seq_group_metadata.is_prompt: --> 208 if sampling_params.seed is not None: 209 seq_group_metadata.state.generator = torch.Generator( 210 device=device).manual_seed(sampling_params.seed) AttributeError: 'NoneType' object has no attribute 'seed'"occurs during use?
The model I'm using is llama3-8b, thanks!

If you're running the generic Llama-3-8b model, you are running with a generation model rather than an embedding model. I should update the encode API to fail more gracefully if called in this configuration.
If you want to use an embedding model, try:

https://huggingface.co/intfloat/e5-mistral-7b-instruct

Hello, I would like to ask why this error: "--------------------------------------------------------------------------- AttributeError Traceback (most recent call last) in <cell line: 1>() ----> 1 outputs = model.encode(prompts)
10 frames /content/vllm/vllm/model_executor/sampling_metadata.py in _prepare_seq_groups(seq_group_metadata_list, seq_lens, query_lens, device) 206 207 if seq_group_metadata.is_prompt: --> 208 if sampling_params.seed is not None: 209 seq_group_metadata.state.generator = torch.Generator( 210 device=device).manual_seed(sampling_params.seed) AttributeError: 'NoneType' object has no attribute 'seed'"occurs during use?
The model I'm using is llama3-8b, thanks!

If you're running the generic Llama-3-8b model, you are running with a generation model rather than an embedding model. I should update the encode API to fail more gracefully if called in this configuration.
If you want to use an embedding model, try:

https://huggingface.co/intfloat/e5-mistral-7b-instruct

Thank you very much for your quick reply! May I ask if there is an API for vllm if I want to extract the hidden state of the generation model?

Hello, I would like to ask why this error: "--------------------------------------------------------------------------- AttributeError Traceback (most recent call last) in <cell line: 1>() ----> 1 outputs = model.encode(prompts)
10 frames /content/vllm/vllm/model_executor/sampling_metadata.py in _prepare_seq_groups(seq_group_metadata_list, seq_lens, query_lens, device) 206 207 if seq_group_metadata.is_prompt: --> 208 if sampling_params.seed is not None: 209 seq_group_metadata.state.generator = torch.Generator( 210 device=device).manual_seed(sampling_params.seed) AttributeError: 'NoneType' object has no attribute 'seed'"occurs during use?
The model I'm using is llama3-8b, thanks!

If you're running the generic Llama-3-8b model, you are running with a generation model rather than an embedding model. I should update the encode API to fail more gracefully if called in this configuration.
If you want to use an embedding model, try:

https://huggingface.co/intfloat/e5-mistral-7b-instruct

Thank you very much for your quick reply! May I ask if there is an API for vllm if I want to extract the hidden state of the generation model?

Getting the hidden state of the generation model is exactly what I am struggling with. Have you found any good solutions?  All the tools I found are targeted for embedding model, not supporting llama3.


re null values

hi @hjboth
typo + i don't unterstand the example 😅
thanks,
sebastian

Hi @stewsk ,
what is your take here? (How) Should we change the example?

Thanks Steffen!


[Bug]: AssertionError when using SimpleWebPageReader with html2text

Bug Description
An AssertionError is raised when using SimpleWebPageReader from the llama-index-readers-web package. The issue appears to stem from how html2text is utilized within the SimpleWebPageReader class.
Version
llama-index==0.10.53 / llama-index-readers-web==0.1.22
Steps to Reproduce

Use SimpleWebPageReader to load a webpage.
Ensure that the webpage contains tags without src attributes.
Call the load_data method.

Relevant Logs/Tracbacks
File "/home/pn/app/backend/apps/searchcampaigns/services/llama.py", line 308, in update_search_results
    documents = SimpleWebPageReader(html_to_text=True).load_data(
  File "/home/pn/.local/lib/python3.11/site-packages/llama_index/readers/web/simple_web/base.py", line 66, in load_data
    response = html2text.html2text(response)
  File "/home/pn/.local/lib/python3.11/site-packages/html2text/__init__.py", line 947, in html2text
    return h.handle(html)
  File "/home/pn/.local/lib/python3.11/site-packages/html2text/__init__.py", line 142, in handle
    self.feed(data)
  File "/home/pn/.local/lib/python3.11/site-packages/html2text/__init__.py", line 139, in feed
    super().feed(data)
  File "/usr/local/lib/python3.11/html/parser.py", line 110, in feed
    self.goahead(0)
  File "/usr/local/lib/python3.11/html/parser.py", line 170, in goahead
    k = self.parse_starttag(i)
  File "/usr/local/lib/python3.11/html/parser.py", line 337, in parse_starttag
    self.handle_starttag(tag, attrs)
  File "/home/pn/.local/lib/python3.11/site-packages/html2text/__init__.py", line 191, in handle_starttag
    self.handle_tag(tag, dict(attrs), start=True)
  File "/home/pn/.local/lib/python3.11/site-packages/html2text/__init__.py", line 502, in handle_tag
    assert attrs["src"] is not None
           ^^^^^^^^^^^^^^^^^^^^^^^^

Pretty sure this is an issue with the html2text package, not llamaindex?

Good day!
Yes and no, llama-index-readers-web==0.1.22 uses html2text 2020.1.16 I've tried to update it to the latest version, but
llama-index-readers-web 0.1.22 requires html2text<2021.0.0,>=2020.1.16, but you have html2text 2024.2.26 which is incompatible.
as i see since html2text 2024.2.25 that issue was fixed


Set limit on length of Status.Conditions of a csv

Set a maximum length of Status.Conditions of ClusterServiceVersion
object(s). The oldest condition(s) should be removed from the list
as it grows over time to keep it at limit.
The default limit is set to 20.
Jira: https://jira.coreos.com/browse/OLM-963

/test unit

/retest

/retest

/retest

/test e2e-aws-olm

/test e2e-aws-olm

/retest

/test e2e-aws-olm

/test e2e-aws-olm