Improve performance of suggestionDiagnostics for convertToAsyncFunction

Previously we would unconditionally get the type of every functionExpression, which could take a while. Now we will first check if it syntactically looks like a promise handler before checking the type.
Also separated hasReturnStatementWithPromiseHandler from getReturnStatementsWithPromiseHandlers to avoid allocating arrays unnecessarily.

@andy-ms Are we also planning to improve cancellation granularity or is this expected to sufficiently mitigate the issue?

This doesn't add new cancellation calls. We could, but I think it would be better to see if this fixes the problem alone since the cost of checking the cancellation token at each function could hurt performance in the non-cancelled case.


Add query params inside anchors when we paste an email or an URL

Hey,
I changed how the regexp works based on this https://regex101.com/r/ubiAlt/1 which is based on yours and this one https://stackoverflow.com/a/44397627.
I added some tests for this:

Now if you paste test@example.com?subject=foo&body=bar inside Squire it will create an anchor with mailto:test@example.com?subject=foo&body=bar.

Thanks, I've simplified the regex matching the query params and merged this. Sorry for the delay.

Thx :+1:


rigsofrods: <IP_ADDRESS> -> 2021.04

Motivation for this change
RoR <IP_ADDRESS> is nearly 5 years old
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Closing due to inactivity from author.


refactor(spanner)!: avoid chrono::time_point for Spanner timestamps

Introduce new overloads for DatabaseAdminClient::CreateBackup() and
DatabaseAdminClient::UpdateBackupExpireTime() that take a Timestamp
instead of a std::chrono::system_clock::time_point. This guarantees
that we can set time instants with full Spanner resolution (ns). Mark
the old interfaces as deprecated.
Also avoid time_point when constructing Timestamp values in tests.
Relatedly, Timestamp has been crafted in such a way that conversion
from a protobuf::Timestamp cannot fail, so remove that possibility
in the signature of internal::TimestampFromProto() by eliminating
StatusOr<> from the return type.
BREAKING CHANGE:
Field DatabaseAdminConnection::CreateBackupParams::expire_time has
changed from std::chrono::system_clock::time_point to Timestamp.
This affects mocking of CreateBackup() in Spanner connection tests.

This change is

However, I think this is no longer a breaking change, though it does announce a deprecation and may deserve to be called out clearly in the next Release Notes. You may want to update this PR description to reflect that.

I will update the PR description during the "squash and merge".

Also, in the past for changes like this we've sometimes included an edit to the CHANGELOG.md file in the affecting PR, so that the PR author can write clear notes to users about what's actually changing. Consider doing that.

My plan was to defer that until merging into the main branch.  Updating CHANGELOG.md in this branch will just cause more conflicts.

I couldn't find those warnings in the build logs. Which build? Do you have a link?

They won't be in the build logs because we don't call the deprecated overloads.

If those show up all the time, might it break users who compile with -Werror?

Yes, I imagine that under -Wdeprecated-declarations and -Werror that the build would break.  But it seems it would be what they asked for.

To be clear, my concern is that if adding a formal deprecation tag warning here may break users, we may want to consider whether we actually want to use that tag, or if we just want to document that an overload/field is going away. I don't think we've used ABSL_DEPRECATED() yet, and I'm afraid I don't yet really understand its implications. If you do, please feel free to just enlighten me so that we can feel confident using it now and going forward.

I'm happy to take it away.  I don't claim to understand the full implications.  But if we choose to do that we should probably reopen #2857.

However, I think this is no longer a breaking change, though it does announce a deprecation and may deserve to be called out clearly in the next Release Notes. You may want to update this PR description to reflect that.

I will update the PR description during the "squash and merge".

Also, in the past for changes like this we've sometimes included an edit to the CHANGELOG.md file in the affecting PR, so that the PR author can write clear notes to users about what's actually changing. Consider doing that.

My plan was to defer that until merging into the main branch. Updating CHANGELOG.md in this branch will just cause more conflicts.

I once again failed to realize that this PR was to a non-master branch. Your plan SGTM.

I couldn't find those warnings in the build logs. Which build? Do you have a link?

They won't be in the build logs because we don't call the deprecated overloads.

Ahh. Since we need to make sure those overloads continue working, I think it would be good if we had some test that called them, even once.

If those show up all the time, might it break users who compile with -Werror?

Yes, I imagine that under -Wdeprecated-declarations and -Werror that the build would break. But it seems it would be what they asked for.

To be clear, my concern is that if adding a formal deprecation tag warning here may break users, we may want to consider whether we actually want to use that tag, or if we just want to document that an overload/field is going away. I don't think we've used ABSL_DEPRECATED() yet, and I'm afraid I don't yet really understand its implications. If you do, please feel free to just enlighten me so that we can feel confident using it now and going forward.

I'm happy to take it away. I don't claim to understand the full implications. But if we choose to do that we should probably reopen #2857.

We could reopen #2857 or create a new issue, but I think it would be good for us to understand the implications of ABSL_DEPRECATED on our customers before using it, because it has the ability to break our customers' builds. And to be clear, I'm only saying that I don't understand the implications.

Since we need to make sure those overloads continue working, I think it would be good if we had some test that called them, even once.

OK, done.  PTAL.
This, of course, requires the removal of the deprecation attributes, lest our clang-tidy build fails.  (I also find it irksome when packages elicit their own deprecation warnings during builds.  I'm looking at you, gtest.)

We could reopen #2857 or create a new issue

Reopened.


Always on top toolbar icon

Description of the new feature / enhancement
Am trying this out instead of using 4T Tray Minimiser.
Scenario when this would be used?
I find that having to use a keyboard shortcut is not as intuitive or efficient as a dedicated toolbar icon (a pin that moves from horizontal to vertical when the window is "always on top")
Supporting information
No response

Thanks for your message. This is a Duplicate of an other issue. Additional comments may be added there. /dup #15387
Have a peticular look a this comment


Create new tile by dragging from topbar

Is it possible to create a new predefined tile of width w and height h by dragging off a sidebar? I know this is possible and just wondering if anyone had got the wheel to work so I won't have to reinvent it.
I'm thinking about doing the following:

create a new griditem and bind it to Infinity, Infinity in layouts
somehow trigger onDragStart
then update layouts onDragStop

Thanks in advance.

This is not a bug or feature request so I am going to close it, but I recommend trying out Gitter or IRC for these kind of more open-ended questions.
At this point in time there is no first-party support for this, although this is a use case I will keep in mind for #346.


Scanner does not appear on my Ionic v7 app

Describe the bug
I am trying to use the barcode scanner in my Ionic app, and have configured everything the way it is written in the docs, but somehow the barcode scanner just does not show up.
I am using Ionic v7 and Capacitor v4.7.0, hence I am using version 3.0.3 of your package.
I have followed your advice I have inspected my DOM, but this does not add the div I should be able to see. Note that it does ask me for my permission to use the camera and when accepted it also says that it uses the camera, but there is just no overlay.
I will try updating the Capacitor version including the version of the package.
To Reproduce
Steps to reproduce the behavior:
Just try every step from the Installation guide along with the versions I am using to see the issue.
Expected behavior
Overlay should display.
Screenshots
If applicable, add screenshots to help explain your problem.
Version
v.3.0.3
Desktop (please complete the following information):

OS: macOS Monterey 12.6
Browser Chrome
Version 113.0.5672.126

Smartphone (please complete the following information):

Device: chrome://inspect
Browser: chrome

Additional context
Add any other context about the problem here.

I was facing the same issue. Even though I wasn't seeing the DIV it is supposed to add to the DOM I just added a display:none; to the class scanner-active as the documentation suggests and it worked.
body.scanner-active {
    --background: transparent;
    --ion-background-color: transparent;
    display: none;
}

No div will be added, the camera is in a native view behind the webview.


[185] Add key-stage acronym inflections

This makes humanize correctly upcase them.
Changes in this PR:
Before
[1] pry(main)> "ks1".humanize
=> "Ks1"

After
[1] pry(main)> "ks1".humanize
=> "KS1"

 Add acronym inflectors for key stages


Animations stop after approx one second if using with Haste module

Token Mold version 2.6
FVTT version 5.7
Browser and OS used. Or if the app itself is used. WIN 10 Chrome
Template Animations stop after approx one second if using with Haste module. It works fine otherwise. If you click anywhere in Foundry the animation starts again and stops after one second.
Console errors? (F12 or F11 in most browsers) None
Workflow to recreate the bug - Install Haste, Install MESS, create animated template from WEBM or MP4

Thanks for the report, but i won't fix that one, for multiple reasons:

Haste is used to improve performance, propably because one needs it. Using video textures is the opposite: it worsens performance for gain of fidelity.
I stated in the README that module conflicts may arise and that i do not really care about it for most parts.


Acro Sometimes Won't Accept User Input

Screenshot:
This happened with another user in a previous round.

Figured it out. If you type anything before trying to submit something, you're SOL.

Thanks. 👍


Not connecting to server

hi can I look into it

yeah sure

please assign this project to me

done


Python 3.12 Support

Please add Python 3.12 support to https://github.com/5yutan5/PyQtDarkTheme/blob/main/pyproject.toml

I created a PR here:  https://github.com/5yutan5/PyQtDarkTheme/pull/253

I am unable to get package working with 3.12.2. There seems to be no enable_hi_dpi or setup_theme in the package when installed with pip. installing with 3.11.3 worked fine for me.

AttributeError: module 'qdarktheme' has no attribute 'setup_theme'

AttributeError: module 'qdarktheme' has no attribute 'setup_theme'

+1 goddamn

AttributeError: module 'qdarktheme' has no attribute 'setup_theme'

The reason for this error is that you have the very old pyqtdarktheme <= 0.1.7 installed. That's the last version where the package maintainers did not specify an upper bound of supported python versions. Therefore, according to their metadata, those very old versions claim compatibility with all future python versions: pip looks through all versions until it finds one which claims to be compatible and installs that.

AttributeError: module 'qdarktheme' has no attribute 'setup_theme'

The reason for this error is that you have the very old pyqtdarktheme <= 0.1.7 installed. That's the last version where the package maintainers did not specify an upper bound of supported python versions. Therefore, according to their metadata, those very old versions claim compatibility with all future python versions: pip looks through all versions until it finds one which claims to be compatible and installs that.

The problem is that pip does not update beyond 0.1.7 if python version > 3.12 because of package requirements
The workaround I've found so far is to use the following command:
pip install pyqtdarktheme==2.1.0 --ignore-requires-python
My projects still working

@5yutan5 Do you have a few minutes to merge in #253 and publish a new release? It would be greatly appreciated.

have the same issue. Please fix

Any updates?


Caveats not shown when installing dependencies

brew config output
HOMEBREW_VERSION: 3.6.3-16-g76b87c4
ORIGIN: https://github.com/Homebrew/brew
HEAD: 76b87c4a00ed636bcf59c104b85863637609b66d
Last commit: 7 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: c03acfa3c6e27b0f666f5c35545a311bc4e37151
Core tap last commit: 44 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: vim
HOMEBREW_EVAL_ALL: set
HOMEBREW_MAKE_JOBS: 8
HOMEBREW_NO_ENV_HINTS: set
Homebrew Ruby: 2.6.8 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: octa-core 64-bit arm_firestorm_icestorm
Clang: 14.0.0 build 1400
Git: 2.37.0 => /Library/Developer/CommandLineTools/usr/bin/git
Curl: 7.79.1 => /usr/bin/curl
macOS: 12.6-arm64
CLT: <IP_ADDRESS>.1.1661618636
Xcode: N/A
Rosetta 2: false

brew doctor output
Your system is ready to brew.

Verification

[X] I ran brew update and am still able to reproduce my issue.
[X] I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?
Installing GDAL
What happened (include all command output)?

What did you expect to happen?
Text from Caveats section shown as is the case when running brew info for one of these dependency packages.
==> Caveats
expat is keg-only, which means it was not symlinked into /opt/homebrew,
because macOS already provides this software and installing another version in
(...)

==> Caveats
icu4c is keg-only, which means it was not symlinked into /opt/homebrew,
because macOS provides libicucore.dylib (but nothing else).
(...)

==> Caveats
libxml2 is keg-only, which means it was not symlinked into /opt/homebrew,
because macOS already provides this software and installing another version in
(...)

==> Caveats
krb5 is keg-only, which means it was not symlinked into /opt/homebrew,
because macOS already provides this software and installing another version in
(...)

==> Caveats
libpq is keg-only, which means it was not symlinked into /opt/homebrew,
because conflicts with postgres formula.
(...)

==> Caveats
Minizip headers installed in 'minizip' subdirectory, since they conflict
with the venerable 'unzip' library.
(...)

==> Caveats
openblas is keg-only, which means it was not symlinked into /opt/homebrew,
because macOS provides BLAS in Accelerate.framework.

Step-by-step reproduction instructions (by running brew commands)
See in section "What happened".

`brew reinstall` does not show the package's Caveat text either.

Only an uninstall/install seems to trigger the warning text from the caveat section, here done for the package krb5 package

`> brew uninstall --ignore-dependencies krb5 && brew install krb5`

I think this is intentional and from my perspective it's desirable. Why do you want caveats from dependencies?

Yes, now that I've thought about it some more (I suggested filing this issue at Homebrew/discussions#3697), it probably is better to avoid showing caveats for formulae installed as dependencies.

Closing the issue, as it seems to be a feature rather than a bug.


Add support for idempotent buffered producer

Support idempotent buffered producer.
Dependent on #24156
Documentation:

Design Proposal: https://gist.github.com/jsquire/1cc4db6b3ca4ef13d26dc5315483555b

The original PR is here:

https://github.com/Azure/azure-sdk-for-java/pull/14389
We did a release of azure-core-amqp 1.7.0-beta.2 with this support (https://github.com/Azure/azure-sdk-for-java/tree/azure-core-amqp_1.7.0-beta.2)
azure-messaging-eventhubs 5.4.0-beta.1 https://github.com/Azure/azure-sdk-for-java/tree/azure-messaging-eventhubs_5.4.0-beta.1

Hello, I'm working on a commercial project and we would like to make use of this feature. We have seen that other SDKs already support this, is there a timeline for it to get added to the Java SDK, or is there a way to do this with an EventHubBufferedProducerClient/EventHubBufferedProducerAsyncClient that we may have missed?
Thank you


Ignore lib directory while processing hooks

Hook spams like this:
.../hooks/lib/utils.py' is skipped: no executable permissions, chmod +x is required to run this hook"

We can patch this function to ignore the lib directory with hooks

Les't add a warning if there is a file with the executable permissions in the lib directory. I think we need this to prevent accidentally putting a hook in the folder where we ignore it.
The behavior also must be documented in all the docs: shell-operator, addon-operator, and deckhouse module development docs.

So what do we do?
The task was to get rid of many messages in the logs stating that files in the directory do not have permission to run. And it is suggested to simply ignore the lib directory from scanning.
In case we need to check that the lib directory contains executable files, we must scan it. And if there are such files, issue a warning.
Maybe then it's better not to ignore the lib directory from scanning. But just not display a warning that the file is not executable?
In this case, our system behavior will remain the same, but there will be less spam in the logs.
We just need to remove this warning.

Maybe it would be better to use something like that:
if !IsFileExecutable(f) && !strings.Contains(f.Name(), "/lib/") {
    log.Warnf("File '%s' is skipped: no executable permissions, chmod +x is required to run this hook", path)
    return nil
}


[TACHYON-1207] Added tests for lineage file system client

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7698/
Test PASSed.

LGTM, left one minor comment

LGTM

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7706/
Test PASSed.


Neomake seems to cause scroll lag

When I hold "j" with neomake enabled, the scrolling is a bit choppy and laggy. When I do the same without Neomake, scrolling is much, much better. I'm mostly wondering if this is unexpected behavior ... and how to further debug given that I'm still a vim novice.
To confirm my suspicion that Neovim was causing the slowness, I followed these directions and held "j" in a 300 line python file -- http://stackoverflow.com/questions/12213597/how-to-see-which-plugins-are-making-vim-slow -- which generated this report:
FUNCTIONS SORTED ON TOTAL TIME
count  total (s)   self (s)  function
  530   0.053772   0.004361  neomake#CursorMoved()
  530   0.029793             <SNR>63_Highlight_Matching_Pair()
  530   0.025060             neomake#EchoCurrentError()
    1   0.025025   0.001555  plug#end()
  530   0.024352             neomake#signs#PlaceVisibleSigns()
  530   0.010298   0.002646  <SNR>82_OnCursorMovedNormalMode()
  530   0.007652             <SNR>82_AllowedToCompleteInCurrentFile()
    1   0.007570   0.000216  <SNR>2_reload()
   24   0.007411   0.003825  <SNR>2_source()
   25   0.002936   0.001140  <SNR>2_add()
    1   0.002113   0.000538  <SNR>2_reorg_rtp()
   25   0.001457   0.001117  <SNR>2_infer_properties()
    1   0.001267   0.000762  <SNR>2_remove_rtp()
    2   0.000970   0.000587  <SNR>11_SynSet()
   68   0.000882   0.000330  <SNR>2_rtp()
   94   0.000800             <SNR>2_dirpath()
    1   0.000353   0.000145  plug#begin()
   73   0.000310             pymode#default()
    2   0.000307   0.000136  gitgutter#highlight#define_highlights()
   48   0.000282             <SNR>2_lines()

FUNCTIONS SORTED ON SELF TIME
count  total (s)   self (s)  function
  530              0.029793  <SNR>63_Highlight_Matching_Pair()
  530              0.025060  neomake#EchoCurrentError()
  530              0.024352  neomake#signs#PlaceVisibleSigns()
  530              0.007652  <SNR>82_AllowedToCompleteInCurrentFile()
  530   0.053772   0.004361  neomake#CursorMoved()
   24   0.007411   0.003825  <SNR>2_source()
  530   0.010298   0.002646  <SNR>82_OnCursorMovedNormalMode()
    1   0.025025   0.001555  plug#end()
   25   0.002936   0.001140  <SNR>2_add()
   25   0.001457   0.001117  <SNR>2_infer_properties()
   94              0.000800  <SNR>2_dirpath()
    1   0.001267   0.000762  <SNR>2_remove_rtp()
    2   0.000970   0.000587  <SNR>11_SynSet()
    1   0.002113   0.000538  <SNR>2_reorg_rtp()
   68   0.000882   0.000330  <SNR>2_rtp()
   73              0.000310  pymode#default()
   48              0.000282  <SNR>2_lines()
    1              0.000236  <SNR>16_defs()
    1   0.007570   0.000216  <SNR>2_reload()
    3              0.000207  <SNR>2_loaded_names()

Some details to help with debugging:
I'm using Neovim. This is the output when I run nvim --version:
NVIM 0.0.0-alpha+201509270027 (compiled Sep 26 2015 17:18:27)
Commit: ded4a502199b283ac7d1184db7eae250c1255ad0
Build type: RelWithDebInfo
Compilation: /usr/local/Library/ENV/4.3/clang -Wconversion -O2 -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -Wvla -std=gnu99 -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -I/tmp/neovim20150926-59053-cc24w4/build/config -I/tmp/neovim20150926-59053-cc24w4/src -I/tmp/neovim20150926-59053-cc24w4/deps-build/usr/include -I/tmp/neovim20150926-59053-cc24w4/deps-build/usr/include -I/tmp/neovim20150926-59053-cc24w4/deps-build/usr/include/luajit-2.0 -I/tmp/neovim20150926-59053-cc24w4/deps-build/usr/include -I/tmp/neovim20150926-59053-cc24w4/deps-build/usr/include -I/tmp/neovim20150926-59053-cc24w4/deps-build/usr/include -I/tmp/neovim20150926-59053-cc24w4/deps-build/usr/include -I/usr/local/opt/gettext/include -I/usr/include -I/tmp/neovim20150926-59053-cc24w4/build/src/nvim/auto -I/tmp/neovim20150926-59053-cc24w4/build/include
Compiled by<EMAIL_ADDRESS>
Optional features included (+) or not (-): +acl   +iconv    +jemalloc
For differences from Vim, see :help vim-differences

   system vimrc file: "$VIM/nvimrc"
     user vimrc file: "~/.nvimrc"
 2nd user vimrc file: "~/.nvim/nvimrc"
      user exrc file: "~/.exrc"
  fall-back for $VIM: "/usr/local/Cellar/neovim/HEAD/share/nvim"

Here is my vimrc: https://github.com/stockninja/dotfiles/blob/master/vim/nvimrc.symlink.

You are on quite an outdated neovim version, I would just suggest first that you upgrade to latest version as Neovim changes quite rapidly.

I have the same problem.
When I open the file, neomake only places signs for the visible area and when I start scrolling down, it keeps putting new signs and this causes scrolling lag. Forcing neomake to place all the signs (https://github.com/ivalkeen/neomake/blob/master/autoload/neomake/signs.vim#L126-L127) fixes scrolling lag for me, but probably is super slow for large files. I'm using neovim 0.1.2.
@benekastah do you have any ideas how to properly fix that?

GitGutter gets around the slowdown problem by displaying a (configurable) maximum number of symbols. It's hardly a "fix" but it does mean that opening large files won't be unbearably slow and that symbols don't have to be added on scroll. Just a thought.

The CursorMoved callback should behave better by now.
I am closing this in favor of https://github.com/neomake/neomake/pull/471 for now.


[BUG] Can't upload large image files via web UI

Describe the bug

When you try to upload large ISO or image files it errors out
To Reproduce
Steps to reproduce the behavior:

Navigate to the images page
Select upload file
Upload a file that is larger than 2 GB. I tested it with a server2019 ISO

Expected behavior

The upload should complete successfully.
Support bundle

supportbundle_c2f07121-0b02-46ef-8114-d5867098fd10_2022-02-09T19-34-58Z.zip
Environment:

Harvester ISO version: master-f303b27e-head
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): KVM virtualized environment

Additional context
Add any other context about the problem here.
This doesn't happen on v1.0.0. It was working fairly recently and stopped working in the last few days while I was testing. It appears to start uploading then resets the connection with a 500 error.

A quick test:
image harvester-master-amd64.iso is downloaded independently (url: https://releases.rancher.com/harvester/master/harvester-master-amd64.iso)
harvester-master-amd64-2.iso, harvester-master-amd64-3.iso are downloaded in parallel,
all are successful

@noahgildersleeve could you please try it again in your environment? and, when it happened, did you check your setup, was there adequate storage size ? thanks.

When uploading big size image (e.g. > 1G), the issue is highly reproduceable.
After the issue happened, refreshing Harvester WebUI  may encounter blank page with "Handler disconnected".
The workaround is using below command to delete the Harvester pod, then the WebUI will be reusable.
kubectl delete pod harvester-pod-name -n harvester-system
harvester-pod-name is like:
kubectl get pods -n harvester-system
NAME                                                   READY   STATUS    RESTARTS   AGE
harvester-d544ddb6f-phwhd                              1/1     Running   0          15h

Another test:
When uploading speed is fast, for instance, the client PC and Harvester cluster  are in same network, the harvester POD had such error message right after the uploading action starts.
but the uploading is still on-going
kubectl logs harvester-d544ddb6f-kbp2s -n harvester-system
time="2022-02-24T21:59:11Z" level=error msg="remotedialer buffer exceeded, length: 4224768"
time="2022-02-24T21:59:11Z" level=error msg="remotedialer buffer exceeded, length: 4241125"
time="2022-02-24T21:59:11Z" level=error msg="remotedialer buffer exceeded, length: 4257536"
time="2022-02-24T21:59:11Z" level=error msg="remotedialer buffer exceeded, length: 4273875"
time="2022-02-24T21:59:11Z" level=error msg="remotedialer buffer exceeded, length: 4306625"
time="2022-02-24T21:59:11Z" level=error msg="remotedialer buffer exceeded, length: 4323072"
time="2022-02-24T21:59:11Z" level=error msg="remotedialer buffer exceeded, length: 4339375"
time="2022-02-24T21:59:11Z" level=error msg="remotedialer buffer exceeded, length: 4372143"
...
time="2022-02-24T22:11:18Z" level=error msg="remotedialer buffer exceeded, length: 11774178"
time="2022-02-24T22:11:18Z" level=error msg="remotedialer buffer exceeded, length: 9922849"
time="2022-02-24T22:11:18Z" level=error msg="remotedialer buffer exceeded, length: 7760161"
time="2022-02-24T22:11:18Z" level=error msg="remotedialer buffer exceeded, length: 7776446"
time="2022-02-24T22:11:18Z" level=error msg="remotedialer buffer exceeded, length: 6318369"
time="2022-02-24T22:11:18Z" level=error msg="remotedialer buffer exceeded, length: 6334636"
time="2022-02-24T22:11:18Z" level=error msg="remotedialer buffer exceeded, length: 5793955"
time="2022-02-24T22:11:18Z" level=error msg="remotedialer buffer exceeded, length: 4335806"

3.7 GB ISO is uploaded successfully in 10 minutes

3 Harvester master-head (today) ISO are uploaded in parallel, all are successful
even though Harvester POD had error message, it looks self-healed.
kubectl logs harvester-d544ddb6f-kbp2s -n harvester-system
time="2022-02-24T22:23:57Z" level=error msg="remotedialer buffer exceeded, length: 4225524"
time="2022-02-24T22:23:57Z" level=error msg="remotedialer buffer exceeded, length: 4258292"
time="2022-02-24T22:23:57Z" level=error msg="remotedialer buffer exceeded, length: 4273875"
time="2022-02-24T22:23:57Z" level=error msg="remotedialer buffer exceeded, length: 4306643"
time="2022-02-24T22:23:57Z" level=error msg="remotedialer buffer exceeded, length: 4323828"

...
time="2022-02-24T22:26:09Z" level=error msg="remotedialer buffer exceeded, length: 10143932"
time="2022-02-24T22:26:09Z" level=error msg="remotedialer buffer exceeded, length: 8243334"
time="2022-02-24T22:26:09Z" level=error msg="remotedialer buffer exceeded, length: 6146182"
time="2022-02-24T22:26:09Z" level=error msg="remotedialer buffer exceeded, length: 6146236"
time="2022-02-24T22:26:09Z" level=error msg="remotedialer buffer exceeded, length: 6178950"
W0224 22:26:35.672889       8 transport.go:260] Unable to cancel request for *client.addQuery
W0224 22:26:35.673150       8 transport.go:260] Unable to cancel request for *client.addQuery

Tested in master-bfd6a8a9-head
Verification steps

Deploy Harvester from master-head ISO
Upload large ISO
Wait for it to complete
Upload second large ISO
Wait for it to complete

The images are uploading, but after the first ISO I did get the "Handler disconnected" error. I'm including the support bundle, but I'm going to create a new bug for that issue since it's out of scope of the original report.

supportbundle_f3da3adc-2aef-401f-beaa-bb13ac005b1c_2022-02-24T22-59-06Z.zip

As per the support bundle in issue description, following observation deserves a further discussion.
https://github.com/harvester/harvester/issues/1904#issue-1128947127
https://github.com/harvester/harvester/files/8035677/supportbundle_c2f07121-0b02-46ef-8114-d5867098fd10_2022-02-09T19-34-58Z.zip

Harvester node running environment:
12 core CPU with 16G memroy
OOM is in kernel log, Harvester (POD) is killed by kernel
-- Logs begin at Wed 2022-02-09 18:12:09 UTC, end at Wed 2022-02-09 19:35:17 UTC. --
Feb 09 18:12:09 localhost kernel: Linux version 5.3.18-59.37-default (geeko@buildhost) (gcc version 7.5.0 (SUSE Linux)) #1 SMP Mon Nov 22 12:29:04 UTC 2021 (d10168e)
Feb 09 18:12:09 localhost kernel: Command line: BOOT_IMAGE=(loop0)/boot/vmlinuz console=tty1 root=LABEL=COS_ACTIVE cos-img/filename=/cOS/active.img panic=0 net.ifnames=1 rd.cos.oemtimeout=120 rd.cos.oemlabel=COS_OEM
18:12:09 localhost kernel: Memory: 2065184K/16776676K available (12291K kernel code, 2236K rwdata, 4592K rodata, 2636K init, 13908K bss, 452780K reserved, 0K cma-reserved)
Feb 09 18:12:09 localhost kernel: smpboot: Total of 12 processors activated (91199.95 BogoMIPS)

Feb 09 19:32:34 harvester-master kernel: longhorn invoked oom-killer: gfp_mask=0x100cca(GFP_HIGHUSER_MOVABLE), order=0, oom_score_adj=999
Feb 09 19:32:34 harvester-master kernel: CPU: 9 PID: 7737 Comm: longhorn Tainted: G        W           5.3.18-59.37-default #1 SLE15-SP3
Feb 09 19:32:34 harvester-master kernel: Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-1ubuntu1.1 04/01/2014
Feb 09 19:32:34 harvester-master kernel: Node 0 Normal free:69,264kB min:110,776kB low:125,668kB high:140,560kB active_anon:13,456,596kB inactive_anon:13,968kB active_file:7372kB inactive_file:1012kB unevictable:12760kB writepending:0kB present:14680064kB managed:14389784kB mlocked:12760kB kernel_stack:45992kB pagetables:57984kB bounce:0kB free_pcp:13336kB local_pcp:1360kB free_cma:0kB
Feb 09 19:32:34 harvester-master kernel: oom-kill:constraint=CONSTRAINT_NONE,nodemask=(null),cpuset=6066f28a301347d9da0892fbaa8b71148d117ceba506c8fb5a47757aca0c12fd,mems_allowed=0,global_oom,task_memcg=/kubepods/burstable/pod623e2cd3-bedc-4ba7-a145-4eee01e6055c/0e94be5f668d12a7312e6b59fbc2925cf195cdaf70a7f802106f14e38b5f3bea,task=harvester,pid=1513,uid=0
Feb 09 19:32:34 harvester-master kernel: Out of memory: Killed process 1513 (harvester) total-vm:15594216kB, anon-rss:8411872kB, file-rss:0kB, shmem-rss:0kB
Feb 09 19:32:34 harvester-master kernel: oom_reaper: reaped process 1513 (harvester), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB

Timeline of what happened.
The Harvester POD is killed when downloading was ongoing, that's why the WebUI shows 500 error, and the downloading failed.

Why OOM?
When networking speed is fast enough (e.g, Harvester and uploading PC are in same/near network),  the networking transport is faster than disk writing, the data will be cached in Harvester POD, that is in memory.  Especially when multi uploading are in parallel.
In my local test, I encountered following message in Harvester POD, it is when Harvester saving data :
time="2022-02-24T14:06:33Z" level=error msg="remotedialer buffer exceeded, length: 4257680"
time="2022-02-24T14:06:33Z" level=error msg="remotedialer buffer exceeded, length: 4273155"

time="2022-02-24T14:06:43Z" level=error msg="remotedialer buffer exceeded, length: 7747427"
time="2022-02-24T14:06:43Z" level=error msg="remotedialer buffer exceeded, length: 7761030"
time="2022-02-24T14:06:43Z" level=error msg="remotedialer buffer exceeded, length: 7761246"
time="2022-02-24T14:06:43Z" level=debug msg="Wrote ping"
time="2022-02-24T14:06:44Z" level=error msg="remotedialer buffer exceeded, length: 7768236"

Considering system requirements:
https://docs.harvesterhci.io/v1.0/

Summary:
To reproduce 1904 issue:

Give Harvester node fewer memory, say 16G
Has fast networking, the uploading speed is faster than LH image writing
Uploading a couple of BIG ISO images in parallel
as long as Harvester POD caches enough uploading data, it is highly possible to reproduce.

Why my test https://github.com/harvester/harvester/issues/1904#issuecomment-1050335273 does not reproduce it? because my WIFI network speed is not fast enough, 3.7G ISO image takes 16 min, in @noahgildersleeve test, 5.17G files takes 12 min or less.
@noahgildersleeve : Could you please re-test with at lest 32G memory for the Harvester node.
@guangbochen @yasker :
For uploading image, should we limit the parallel count ? e.g, at most 2 uploading in parallel.

BTW, the feature here will also help:
https://github.com/harvester/harvester/issues/1154
[FEATURE] Hardware Spec preflight checking in the installer

well the thing is, 32gb is a ton of memory. not even vsphere has that amount. esxi only needs 8gig while vcenter needs 10g

@w13915984028 I retested this with 32GB of memory on my VM. It seemed to work fine. I uploaded both large image files one right after the other and the frontend didn't fail. I attached the support bundle and screenshots. Does this mean that this ticket is OK to close? It seems like the original scope of this ticket isn't the same as what the issue ended up being.

supportbundle_39ed8db0-18c8-4e1b-914b-cada6a5645a3_2022-03-02T18-52-30Z.zip

Thanks @noahgildersleeve , the new log proves our analysis.  In your test, the uploading speed is fairly high
I checked the support bundle, the Harvester POD has 59,162 lines of log, only lasts one minute, from 18:50:16 to 18:51:17,  all previous logs are overwritten)
Here we see, the maximum buffer exceed is 1,528,228,071,  apparently, the peak value could be higher up to 5G. But as the VM has 32G memory, it is enough to accommodate, OOM did not happen.
The enhancement #1956, is essential.
@yasker @guangbochen
2022-03-02T18:50:16.789512320Z time="2022-03-02T18:50:16Z" level=error msg="remotedialer buffer exceeded, length: 1,528,228,071"

2022-03-02T18:50:16.789512320Z time="2022-03-02T18:50:16Z" level=error msg="remotedialer buffer exceeded, length:<PHONE_NUMBER>"
2022-03-02T18:50:16.789555851Z time="2022-03-02T18:50:16Z" level=error msg="remotedialer buffer exceeded, length:<PHONE_NUMBER>"
2022-03-02T18:50:16.789559511Z time="2022-03-02T18:50:16Z" level=error msg="remotedialer buffer exceeded, length:<PHONE_NUMBER>"
2022-03-02T18:50:16.789562361Z time="2022-03-02T18:50:16Z" level=error msg="remotedialer buffer exceeded, length:<PHONE_NUMBER>"

2022-03-02T18:50:18.270682084Z time="2022-03-02T18:50:18Z" level=error msg="remotedialer buffer exceeded, length:<PHONE_NUMBER>"
2022-03-02T18:50:18.270917467Z time="2022-03-02T18:50:18Z" level=error msg="remotedialer buffer exceeded, length:<PHONE_NUMBER>"
2022-03-02T18:50:18.271053968Z time="2022-03-02T18:50:18Z" level=error msg="remotedialer buffer exceeded, length:<PHONE_NUMBER>"

2022-03-02T18:50:26.547697487Z time="2022-03-02T18:50:26Z" level=error msg="remotedialer buffer exceeded, length: 4599177"
2022-03-02T18:50:26.547841129Z time="2022-03-02T18:50:26Z" level=error msg="remotedialer buffer exceeded, length: 4566409"
2022-03-02T18:50:26.547962960Z time="2022-03-02T18:50:26Z" level=error msg="remotedialer buffer exceeded, length: 4533587"

@noahgildersleeve
I agree with you that this issue could be closed, all potential enhancements are tracked with new issues, they have connections with 1904.
#1940 gives us a good chance to investigate details and robustness of Harvester, thanks.

@w13915984028 @noahgildersleeve I feel we should keep this issue since this is what does the user see in the end. Whatever fix in #1955 or #1956 should be considered as a part of this issue. We're narrowing down this issue but haven't fixed it yet. I would prefer us to close it only when the user won't be impacted by the issue. cc @rebeccazzzz

Good to keep this root issue (#1904) open.
#1956 looks to be the key, and #1940 can also get benefits from #1956

The latest Harvester version with bumped Rancher version, which has pause/resume protocol, both #1904 and #1956 are solved.
Uploading big ISO images will not cause Harvester POD exhausting large amount of memory.
master-d8a7dfae-head

Tested in Harvester-Tested in master-d8a7dfae-head.
Verification steps

Upload two Windows Server ISOs (>5GB) to Harvester in KVM virtualized environment to simulate very fast network
Check harvester k8s pd logs
Check memory usage

Memory usage seemed fine and there weren't too many remotedialer errors
time="2022-03-21T21:36:42Z" level=error msg="Error during subscribe websocket: close sent"
time="2022-03-21T21:36:54Z" level=error msg="Error during subscribe websocket: close sent"
time="2022-03-21T21:37:44Z" level=error msg="Error during subscribe websocket: close sent"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4227072"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4259840"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4292608"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4259840"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4292608"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4325376"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4358144"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4390912"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4390912"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4423680"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4456448"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4456448"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4489216"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4521984"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4554752"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4587520"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4566199"
time="2022-03-21T21:38:55Z" level=error msg="remotedialer buffer exceeded, length: 4582574"
time="2022-03-21T21:42:20Z" level=error msg="Error during subscribe websocket: close sent"


Document incremental mTLS adoption on istio.io

Implementation: https://github.com/istio/istio/issues/5059
Design doc: https://docs.google.com/document/d/1fubdQ-HD_7IknE71HdaglgTkid1ScMq6LlIDvxKQDc4/edit

@wattli @diemtvu

Closed via https://github.com/istio/istio.github.io/pull/1565


Dropbox warning - move to an Ext4 drive or synching will stop in November

crosh> shell
chronos@localhost / $ sudo edit-chroot -all
Password:
name: xenial
encrypted: yes, unlocked
Entering /mnt/stateful_partition/crouton/chroots/xenial...
crouton: version 1-20180718130616~master:5d4c3014
release: xenial
architecture: amd64
xmethod: xiwi
targets: xfce,xiwi,touch
host: version 10895.40.0 (Official Build) beta-channel cave
kernel: Linux localhost 3.18.0-18121-g8c0cb17dd7e0 #1 SMP PREEMPT Wed Aug 29 13:55:15 PDT 2018 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
Not unmounting /mnt/stateful_partition/crouton/chroots/xenial as another instance is using it.
chronos@localhost / $

I've been getting warnings popup when logging in to an XFCE session  and today an email arrived from Dropbox saying I need to move Dropbox to an Ext4 drive.
I'm confused, as far as I can see my Dropbox folder under /home/ is already ext4. Is there a location  where Dropbox will be happy?
Dropbox pops up a warning every time I start an XFCE session.

Actually, since your chroot is encrypted, the filesystem is technically ecryptfs as far as Dropbox is concerned.
You'll need to make a share that uses the "shared" prefix to import an unencrypted directory into your chroot; Dropbox should be happy running from that.  Of course, then you'll have an unencrypted Dropbox directory on your system, so there's a tradeoff there.

The following recipe worked nicely for me on Crouton.
https://www.linuxuprising.com/2018/11/how-to-use-dropbox-on-non-ext4.html


Question regarding canonical space visualised in paper

Hey! Thanks for your work.
I was wondering how you visualised the canonical space in Figure 9 of your paper? The radiance network expects the time embedding, so I am not sure how to decode the canonical space without any time input. Hope you can give me some hints.
Thanks!

Thanks for your attention. We simply set the time to zero for the canonical space.


Polyfill must replace buggy iOS 7.1 implementation

iOS 7.1 Promise implementation has a bug: Promise.prototype.catch does not returns a promise, but undefined.
Just tried in the simulator: Promise.resolve().catch() returns undefined, I think this can be used as a test in the polyfill method to replace the built-in.

Oops! My fault Another library in my stack was patching adding its own Promise polyfill; closing. Sorry!


[Feature] Text Annotator

Summary
Users need a widget to annotate text

@Nikhil-Nandagopal Can you share an example of your idea of the user experience?

https://mcamac.github.io/react-text-annotate/

Hi @Nikhil-Nandagopal Any update on this widget? we are looking for this widget.

Hi @sivakumarjcn we're focusing on enabling custom widgets on the platform right now and with that, it's going to become very easy to add widgets like these soon. So unfortunately we're not prioritising this yet but we are going to make it really easy to add this and get it included soon. In the meanwhile you can try using the iframe to create a custom text annotator using a popular library.
https://docs.appsmith.com/reference/widgets/iframe#custom-widgets @GreenFlux could you help out with a few steps?

Hi @sivakumarjcn, here are a few general tips for working with iframes to build custom widgets.
https://discord.com/channels/725602949748752515/1082285677212876821/1082349228849893427
I would try to build whatever you want in codepen/codesandbox, or a local HTML file first. It can be hard to determine if code is failing due to Appsmith security/limitations, or if it's the HTML. So get a basic PoC working outside of Appsmith first, then either paste the HTML in the iframe SrcDoc or host it externally and then use the link in the iframe Url.

Thanks, @GreenFlux this is helpful to start with.


Delimiter auto-detection on CSV file datasets

Is your feature request related to a problem? Please describe.
Sometimes, it looks like that we can catch and suggest an appropriate column delimiter by reading a few lines. If we can do this and service to users, it would be very convenient and will prevent many unwanted outcomes.
Describe the solution you'd like
When reading CSV-stype datasets, load a few rows using some popular delimiters and decide the best.
If it's hard to decide, just comma would be fine.

This seems to be duplicated with https://github.com/metatron-app/metatron-discovery/issues/2187.


Emergency message packing is incorrect?

If I read https://www.can-cia.org/can-knowledge/canopen/special-function-protocols/ it states
The data content is defined as a 1 byte Error register (Index 1001h of the local object dictionary), a 16-bit Emergency error code, and up to 5 byte of manufacturer-specific error information.

But the code here https://github.com/CANopenNode/CANopenNode/blob/master/301/CO_Emergency.c#L746 doesn't support access to 5 bytes of manufacturer-specific error information. On the wire I see
byte[0] LSB of Error code
byte[1] MSB of Error code
byte[2] 0
byte[3] Error register value
...

I would have expected byte[2] to be the Error register value. Bytes on the wire were captured using PCAN and the code is running on an ESP32. SDOs reads and writes are working as expected.

should be infocode variable https://github.com/CANopenNode/CANopenNode/blob/master/301/CO_Emergency.h#L611

@martinwag - thanks for the prompt response. If I read https://www.can-cia.org/can-knowledge/canopen/special-function-protocols/ it states  up to 5 byte of manufacturer-specific error information. For a project I'm working on, I need to be able to specify all 5 bytes of the manufacturer-specific error information, not just the 4 bytes represented by the infocode variable. What are my options?

If I remember correctly one byte is used by the stack itself. If you need to use this byte you have to modify the stack source.

This python implementation shows what I would expect https://github.com/christiansandberg/canopen/blob/master/canopen/emcy.py#L8
I'll create a fork and make some changes for review.

I've had a look, one byte is used by the stack. You can change that in your fork, but changing it here will break compatibility.

Yes, I see that now. The message format is described here
 *   Byte | Description
 *   -----|-----------------------------------------------------------
 *   0..1 | @ref CO_EM_errorCode_t
 *   2    | @ref CO_errorRegister_t
 *   3    | Index of error condition (see @ref CO_EM_errorStatusBits_t).
 *   4..7 | Additional informative argument to CO_errorReport() function.

Question answered - closing. Thanks @martinwag


x/exp/vulncheck: build is broken on Darwin

e.g. https://build.golang.org/log/de563b42614dc1637638fa9ded142615c3f5c95e:
:: Running /Users/gopher/workdir/go/bin/go with args ["/Users/gopher/workdir/go/bin/go" "test" "-short" "golang.org/x/exp/vulncheck/..."] and env ["TERM_PROGRAM=Apple_Terminal" "TERM=xterm-256color" "SHELL=/bin/zsh" "TERM_PROGRAM_VERSION=440" "TERM_SESSION_ID=E6C2E110-E8A4-4525-9862-40077EBA57E1" "USER=gopher" "SSH_AUTH_SOCK=/private/tmp/com.apple.launchd.K3XKWJ0tct/Listeners" "PATH=/Users/gopher/workdir/go/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/Apple/usr/bin" "GO_BUILDER_ENV=macstadium_vm" "LaunchInstanceID=CE8E0400-C312-4768-AA59-30611A8A5421" "__CFBundleIdentifier=com.apple.Terminal" "LANG=en_US.UTF-8" "XPC_FLAGS=0x0" "XPC_SERVICE_NAME=0" "SHLVL=4" "HOME=/Users/gopher" "LOGNAME=gopher" "SECURITYSESSIONID=186a6" "_=./buildlet" "WORKDIR=/Users/gopher/workdir" "GO_BUILDER_NAME=darwin-amd64-11_0" "GOROOT_BOOTSTRAP=/Users/gopher/goboot" "GOROOT=/Users/gopher/workdir/go" "GOPATH=/Users/gopher/workdir/gopath" "GOPROXY=https://proxy.golang.org" "TMPDIR=/Users/gopher/workdir/tmp" "GOCACHE=/Users/gopher/workdir/gocache" "PWD=/Users/gopher/workdir/gopath/src/golang.org/x/exp/vulncheck"] in dir /Users/gopher/workdir/gopath/src/golang.org/x/exp/vulncheck

./checks.bash: line 38: shopt: globstar: invalid shell option name
head: **/*.go: No such file or directory
missing license header: **/*.go(B
head: **/*.bash: No such file or directory
missing license header: **/*.bash(B
go vet -all ./...

Installing: mvdan.cc/unparam(B
unparam ./...

Installing: github.com/client9/misspell/cmd/misspell(B
misspell -error .

go mod tidy

go: downloading honnef.co/go/tools v0.1.3
go: downloading github.com/BurntSushi/toml v0.3.1
FAILED; see errors above(B

cc @jba

This may technically be a 1.18 release blocker so I'd appreciate a quick fix.

(The relevant build dashboard page is https://build.golang.org/?repo=golang.org%2Fx%2Fexp.)


Terraform v0.12x changes not working if TMPDIR not set with trailing slash

Thanks for the update...however, I received the following error when running:
Check for merge conflicts................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
hookid: terraform_docs

mktemp: failed to create file via template ‘/tmpterraform-docs-XXXXXXXXXX’: Permission denied

Looked at code and ran export TMPDIR=/tmp/, then:
$ pre-commit run -a
Check for merge conflicts................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
hookid: terraform_docs

2019/06/18 11:15:40 At 34:15: nested object expected: LBRACE got: ASSIGN

Thanks!

@spongebrain just ran into the same issue.

@spongebrain mktemp is magic. :( Please use v1.16.0 where this was fixed (see c9ecd72).

The TMPDIR issue is resolved at v1.16.0.  Thanks much!!!
Insofar as the LBRACE vs ASSIGN issue...we're adopting the new v12 HCL format, and thus don't want to revert the code back to 11 syntax.  Are there plans to address that in a future version?

I am not sure that LBRACE vs ASSIGN issue you are talking about has anything to do with terraform-docs.
terraform-docs requires a code to look like Terraform 0.11 to be able to process it. This is what awk script is doing in a temporary folder.
You should be able to use Terraform 0.12 and let the terraform_docs hook do the magic.


Add flag to run Moondream in f16 precision

Using f16 on M1 Mac gives significant performance improvement

Thanks, I had to make a small tweak to your code as it seemed to break when using quantized on cuda.


Implement C++ code for Queue using Array

Add the code here
comment to get assigned.

I would like to work on this issue.

Go for it @akashrchandran


DTR november patch release notes

Deploy preview for docsdocker ready!
Built with commit 404326a94491cce946ec997d0e8214331b459466
https://deploy-preview-9865--docsdocker.netlify.com


Bitbucket build status sometimes not updated in ods-finish task

It seems that the Bitbucket build status is sometimes not updated in ods-finish task. There is no error in the logs, however the build is still "in progress". This was observed in a situation where many people worked on the same repository.

Haven't observed this in a long time, closing.


Cannot build app while offline, fails with "Could not resolve all task dependencies for configuration"

In situation of scarcity of reliable internet connection android building process produces the following error:
Could not resolve all task dependencies for configuration
There is no way to build an android app offine?

You can build an android app offline, but you need to have downloaded the correct Gradle resources first. For more information, see: https://stackoverflow.com/questions/32171524/how-to-configure-gradle-to-work-offline-using-cached-dependencies


HUB-31081: deletes webui for 2021.8.1 and above

For native Blackduck customers, the -blackduck-webui service needs to be deleted for versions 2021.8.1 and above.

As part of create blackduck native command, we also need to add delete the service logic where the version matters there (edited)


[BUG] Unable to run integration tests for remote endpoints

Integration tests with remote endpoints still rely on OpenSearch-min artifact to be published. This does not work for the release cycle as we need to test the artifact before publishing.
The problem lies with the way integration tests are written. Even though an external endpoint is provided, plugins use testcluster gradle plugin.
Follow up of: https://github.com/opensearch-project/OpenSearch/issues/1240

Closing this as the changes are merged.
Track the meta issue which tracks for all plugins #103


fixes #2245

Is the link to the mapping file still in the analysis list display?

yes

Codecov Report

Merging #2350 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #2350      +/-   ##
==========================================
+ Coverage   93.79%   93.79%   +<.01%
==========================================
  Files         163      163
  Lines       18589    18594       +5
==========================================
+ Hits        17435    17440       +5
  Misses       1154     1154

Impacted Files
Coverage Δ

...ta_pet/handlers/analysis_handlers/base_handlers.py
98.63% <ø> (ø)
:arrow_up:

...lers/analysis_handlers/tests/test_base_handlers.py
98.78% <ø> (ø)
:arrow_up:

qiita_db/analysis.py
95.96% <100%> (ø)
:arrow_up:

qiita_db/test/test_analysis.py
98.04% <100%> (+0.03%)
:arrow_up:

qiita_db/handlers/analysis.py
90.9% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 097e1bc...9d40d94. Read the comment docs.


Legacy docs search doesn't work.

Since the release of spatie/laravel-data v4, the docs for v3 (and earlier, although I've never tested those) are unsearchable.
To reproduce
Go here: https://spatie.be/docs/laravel-data/v3/introduction
Search in the sidebar input on the left.
No results will ever be found.

Same issue experienced for me.

More of spatie.be issue since it is a problem for all out packages, told one of my colleagues who's working on this.

@rubenvanassche Appreciate your forwarding it along. Just curious if there's any public place to track status of this! I'm sure it's not a major priority but we appreciate all you do. <3


Question: Is Appveyor still required?

After #596 was merged - now Travis CI verifies on both Linux and Windows.
The question is: is there a need for two CI tools?

Great observation - no, and anecdotally I found Appveyor to be slower than Travis. We can probably get rid of it, but I'll try to get input from @HamletDRC first.

@JoshuaKGoldberg  sure, get rid of Appveyor.


Reset Project Information window scroll on map click

From @msilski:

(1) When a user clicks on a map feature, selects that feature in the Project Information window, and scrolls down in the pop-up, when they click on another map feature, the Project Information window does not reset to the top. Can you reset the window to the top each time the user clicks on a map feature?

First click: pop-up has been scrolled down

Second click: pop-up remains scrolled-down

This works great. Hope it wasn't too difficult to implement.
This may or may not be related to the change, but I noticed that the map and its tools initially load a few pixels higher (as seen below), then drops down to its normal position. I don't think it's a deal-breaker, and it might be the trade-off with the fresh reset of the pop-up. Either way, could you look into why the map is loading this way? Thanks.

Nice catch! I didn't notice that when the site loaded on my local machine. I think that I have it fixed.


Doc: double encoding of comma in query param

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

A short explanation of the proposed change:

The documentation of the necessary double encoding of comma in query params was hard to understand. This is an attempt to improve it.

An explanation of the use cases your change solves

See https://cloudfoundry.slack.com/archives/C07C04W4Q/p1617029409045900

Links to any other associated PRs

[x] I have reviewed the contributing guide

[x] I have viewed, signed, and submitted the Contributor License Agreement

[x] I have made this pull request to the main branch

[ ] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

Looks good to me, see further conversation https://cloudfoundry.slack.com/archives/C07C04W4Q/p1617029409045900 for more details, merging, thank you @stephanme


Fix TypeError in get_embeddings_wrapper by Ensuring List Input

This pull request addresses a TypeError encountered in the get_embeddings_wrapper function within the Vertex AI vector search notebook. The error was caused by passing a pandas Series (df.title) directly to the function, which expects a list of strings.
Changes Made:

Modified the call to get_embeddings_wrapper by converting the Series df.title to a list of strings using tolist().
This change ensures compatibility with the expected input format of the model.get_embeddings method, preventing the TypeError.

Verified that the get_embeddings_wrapper function now correctly processes a list of strings without throwing a TypeError, and confirmed that the embeddings are successfully retrieved and added to the DataFrame.

Awesome, thank you for catching this and for the fix, @rocpoc !

Oh oops the folder vector-search/ was moved to embeddings/, so as an FYI I'll migrate your changes over to the notebooks in the embeddings/ folder in a separate pull request, as we currently have duplicate notebooks in both folders.


EKS-A - problem to make kepler work properly - very high / non realistic values

Hi
I have problem to make kepler working properly
Subsystem is EKS-A
OS Ubuntu 20.04
In grafana I see very high non realistic values
root@server3:~/tsis/kepler/kepler# kubectl logs kepler-exporter-p46rb -n kepler
I1113 09:19:19.651274       1 gpu.go:46] Failed to init nvml, err: could not init nvml: error opening libnvidia-ml.so.1: libnvidia-ml.so.1: cannot open shared object file: No such file or directory
I1113 09:19:19.658826       1 qat.go:35] Failed to init qat-telemtry err: could not get qat status exit status 127
I1113 09:19:19.670964       1 exporter.go:157] Kepler running on version: 9043798
I1113 09:19:19.670987       1 config.go:274] using gCgroup ID in the BPF program: true
I1113 09:19:19.671021       1 config.go:276] kernel version: 5.1
I1113 09:19:19.671135       1 config.go:301] The Idle power will be exposed. Are you running on Baremetal or using single VM per node?
I1113 09:19:19.671152       1 exporter.go:169] LibbpfBuilt: false, BccBuilt: true
I1113 09:19:19.671212       1 config.go:207] kernel source dir is set to /usr/share/kepler/kernel_sources
I1113 09:19:19.671274       1 exporter.go:188] EnabledBPFBatchDelete: true
I1113 09:19:19.671338       1 power.go:54] use sysfs to obtain power
I1113 09:19:19.671378       1 redfish.go:173] failed to initialize node credential: no supported node credential implementation
I1113 09:19:19.671475       1 power.go:56] use acpi to obtain power
I1113 09:19:19.788636       1 exporter.go:203] Initializing the GPU collector
I1113 09:19:25.793034       1 watcher.go:66] Using in cluster k8s config
I1113 09:19:25.893463       1 watcher.go:134] k8s APIserver watcher was started
W1113 09:19:28.162204       1 bcc_attacher.go:113] failed to load kprobe__set_page_dirty: Module: unable to find kprobe__set_page_dirty
ioctl(PERF_EVENT_IOC_SET_BPF): Bad file descriptor
ioctl(PERF_EVENT_IOC_SET_BPF): Bad file descriptor
W1113 09:19:28.263231       1 bcc_attacher.go:119] failed to attach kprobe/set_page_dirty or mark_buffer_dirty: failed to attach BPF kprobe: bad file descriptor. Kepler will not collect page cache write events. This will affect the DRAM power model estimation on VMs.
W1113 09:19:28.263267       1 bcc_attacher.go:125] failed to load kprobe__mark_page_accessed: Module: unable to find kprobe__mark_page_accessed
ioctl(PERF_EVENT_IOC_SET_BPF): Bad file descriptor
W1113 09:19:28.315246       1 bcc_attacher.go:129] failed to attach kprobe/mark_page_accessed: failed to attach BPF kprobe: bad file descriptor. Kepler will not collect page cache read events. This will affect the DRAM power model estimation on VMs.
I1113 09:19:28.347348       1 bcc_attacher.go:150] Successfully load eBPF module from using bcc
I1113 09:19:28.347380       1 bcc_attacher.go:208] Successfully load eBPF module from bcc with option: [-DMAP_SIZE=10240 -DNUM_CPUS=28 -DSAMPLE_RATE=0]
I1113 09:19:28.372048       1 container_energy.go:114] Using the Ratio/DynPower Power Model to estimate Container Platform Power
I1113 09:19:28.372062       1 container_energy.go:115] Container feature names: [cpu_instructions]
I1113 09:19:28.372080       1 container_energy.go:124] Using the Ratio/DynPower Power Model to estimate Container Component Power
I1113 09:19:28.372090       1 container_energy.go:125] Container feature names: [cpu_instructions cpu_instructions cache_miss   gpu_sm_util]
I1113 09:19:28.372151       1 process_power.go:113] Using the Ratio/DynPower Power Model to estimate Process Platform Power
I1113 09:19:28.372163       1 process_power.go:114] Container feature names: [cpu_instructions]
I1113 09:19:28.372180       1 process_power.go:123] Using the Ratio/DynPower Power Model to estimate Process Component Power
I1113 09:19:28.372229       1 process_power.go:124] Container feature names: [cpu_instructions cpu_instructions cache_miss   gpu_sm_util]
I1113 09:19:28.373514       1 exporter.go:267] Started Kepler in 8.702580335s
Seems problem is here:
W1113 09:19:28.263231       1 bcc_attacher.go:119] failed to attach kprobe/set_page_dirty or mark_buffer_dirty: failed to attach BPF kprobe: bad file descriptor. Kepler will not collect page cache write events. This will affect the DRAM power model estimation on VMs.
W1113 09:19:28.263267       1 bcc_attacher.go:125] failed to load kprobe__mark_page_accessed: Module: unable to find kprobe__mark_page_accessed
ioctl(PERF_EVENT_IOC_SET_BPF): Bad file descriptor
Can you pls assist?
Thank you!!!

Can you use the libbpf images?
quay.io/sustainable_computing_io/kepler:latest-libbpf

Hi thanks for response.
Log really looks good now but values are still non realistic
Check pics. Note - pods mostly have same (non initialized?) numbers.

@barby1138, just for confirmation, EKS operates on VMs, correct?
In the logs, Kepler is gathering hardware counters (HC) like CPU instructions.
However, VMs usually don't expose hardware counters, which could be a potential problem.
Could you please verify in Prometheus if Kepler metrics are displaying CPU instructions and eBPF time? And which values are you seeing?

Hi
This is EKS-anywhere
its installed on bare metal server (24 cores)

@barby1138 do you know the CPU model? Is it intel x86?
The problem seems to be related to the OTHER power consumption.
Maybe there is a problem measuring the platform power (i.e., total node power).
Can you get the plot of the following prometheus metrics?
irate(kepler_node_dram_joules_total{}[1m])
irate(kepler_node_other_joules_total{}[1m])
irate(kepler_node_package_joules_total{}[1m])
irate(kepler_node_platform_joules_total{}[1m])
kepler_container_cpu_instructions_total

Hello @marceloamaral
in which branch can we find the code changes for this image
quay.io/sustainable_computing_io/kepler:latest-libbpf

Hi - any updates?
thanks

@barby1138 as we can see the platform power is too high.
Can you run the sensors command in the host to get the node power?
We try to get the node power from the following paths:
hwmonPowerPath      = "/sys/class/hwmon/hwmon2/device/"
acpiPowerPath       = "/sys/devices/LNXSYSTM:00"

the file name is power*_average
Can you please also check those files?

Hi
root@server3:~# cat /sys/class/hwmon/hwmon2/device/power*_average
4294967295000
root@server3:~# ls /sys/devices/LNXSYSTM:00/LNXPWRBN:00
driver  hid  input  modalias  power  subsystem  uevent  wakeup
thanks

some additional info
root@server3:~# cat /sys/class/hwmon/hwmon2/device/power1_average_interval_max
3600000
root@server3:~# cat /sys/class/hwmon/hwmon2/device/power1_average_interval
1000
root@server3:~#
root@server3:~# cat /sys/class/hwmon/hwmon2/device/power1_accuracy
97.500%
root@server3:~#
root@server3:~#
root@server3:~# cat /sys/class/hwmon/hwmon2/device/status
15

any income?
thanks

@barby1138 your system power is too high.
In my system, I have:
cat /sys/devices/LNXSYSTM:00/LNXSYBUS:00/ACPI000D:00/power1_average
579000000

The value in in microwatts, so we have 579W
Your system has:
 cat /sys/class/hwmon/hwmon2/device/power*_average
4294967295000

So it has 4294967W. Which is a way too high for a gauge value.
I am guessing here, could it be that this power is a counter in your system?
Can you check how the value is changing?
Anyway, it seems to be a OS bug, might be better to ignore the platform and other power consumption.

The fix #1222 should also impact this issue.


ARROW-9803: [Go] Add initial support for s390x

The initial support will allow the unit tests to pass on s390x.
I appreciate your feedback.

How about adding a CI job for s390x + Go on Travis CI as the first step like https://github.com/apache/arrow/pull/7938 ?

cc @kiszk

How about adding a CI job for s390x + Go on Travis CI as the first step like #7938 ?

I can definitely look into adding that.  Will contact @kiszk.

Hello @emkornfield, wondering if this can be considered for merging?  I've updated the PR to use a constant to check for endianess.  Thanks.


Add implementation of padding_needed_for

Description says it all. The implementation has detailed comments. Happy to edit commit messages as needed.

Re-run the UI tests with:
TRYBUILD=overwrite ./cargo.sh +all -p zerocopy --features derive
TRYBUILD=overwrite ./cargo.sh +all -p zerocopy-derive

Looks like everything passes now; thanks for adding the kani test!


Proposing Trilok Geer for the Steering Committee

I recently put out a call for people to join the cert-manager steering commitee and Trilok Geer (@TrilokGeer) responded.
Trilok has joined several community meetings and is involved with cert-manager at his employer, Red Hat.
I'm happy to sponsor Trilok, and @ThatsMrTalbot also agreed to sponsor him in our standup today (2024-09-10).
This issue will track Ian's progress. Given that there are vacancies in the Steering Committee, there's no blocker on Trilok taking his seat, so this should be simple. The remaining steps are:

[x] @ThatsMrTalbot to confirm he's happy to sponsor
[ ] @TrilokGeer to confirm he's happy to join the steering committee based on the current STEERING.md
[ ] @TrilokGeer to confirm he has read and is happy with the changes coming to STEERING.md in https://github.com/cert-manager/community/pull/36

Thank you for the sponsorship @ThatsMrTalbot .
Thanks @SgtCoDFish for the thoughtful updates in https://github.com/cert-manager/community/pull/36.
I hereby confirm that I have read and agree with current STEERING.md and https://github.com/cert-manager/community/pull/36


[CP-16252] Fix JDBCRegistry refresh lock error (#16252)

(cherry picked from commit ed2c10815b941cbdae28661a2aee444c22f34554)

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Please format the code.

Done


Use of a slang expressions should be avoided in readthedocs

The unexpected term “sausage” can be found at
https://vulnerablecode.readthedocs.io/en/latest/tutorial_add_new_importer.html
and we should avoid terms that could be mis-interpreted
A lot of internal sausage about importers could be found inside
There is a similar problem at
https://vulnerablecode.readthedocs.io/en/latest/tutorial_add_new_improver.html
perhaps discussion would be a better word here than sausage.

Done.

Done and closing.


:sparkles: feat(chord_pattern): add symbol getter

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

21 of 23 (91.3%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 99.764%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/src/harmony/chord_pattern.dart
21
23
91.3%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
847

Relevant Lines:
849

💛  - Coveralls


Bugfix/udp listen address

Codecov Report

Merging #54 (e4b09b2) into master (d6afcb8) will decrease coverage by 3.57%.
The diff coverage is 8.00%.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   61.65%   58.07%   -3.58%
==========================================
  Files          30       30
  Lines        3492     3430      -62
==========================================
- Hits         2153     1992     -161
- Misses       1339     1438      +99

Impacted Files
Coverage Δ

turbo_tunnel/__main__.py
0.00% <0.00%> (-56.32%)
:arrow_down:

turbo_tunnel/socks.py
24.54% <4.34%> (-4.09%)
:arrow_down:

turbo_tunnel/__init__.py
85.71% <100.00%> (ø)

tests/__init__.py
80.00% <0.00%> (-20.00%)
:arrow_down:

turbo_tunnel/ssh.py
51.08% <0.00%> (-6.46%)
:arrow_down:

turbo_tunnel/utils.py
71.00% <0.00%> (-3.22%)
:arrow_down:

turbo_tunnel/server.py
73.15% <0.00%> (-2.82%)
:arrow_down:

turbo_tunnel/conf.py
76.11% <0.00%> (-1.66%)
:arrow_down:

... and 6 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Wont execute script if full path?

Hi again,
I seem to have an issue when running the script from the full path?
Executing on ID 1 [<IP_ADDRESS>] ...   1 Off
Executing on ID 2 [<IP_ADDRESS>] ...   2 Off
Executing on ID 3 [<IP_ADDRESS>] ...   3 Off

Returns this and does nothing
Where as running the script from the directory gives me;
Executing on ID 1 [<IP_ADDRESS>] ...   1 "method":"set_power","params":["off"]
Executing on ID 2 [<IP_ADDRESS>] ...   2 "method":"set_power","params":["off"]
Executing on ID 3 [<IP_ADDRESS>] ...   3 "method":"set_power","params":["off"]

And it works

What did you do exactly?

Ok so my use case is to turn off and on some lights using Tautulli when I start or stop playback in Plex. for this to work I need to execute the script using the full path.
user@machine:~$ /opt/Tautulli/script/yeelight-shell-scripts/yeelight.sh 0 Off/opt/Tautulli/script/yeelight-shell-scripts/yeelight.sh 0 On

This does not work;
If I navigate to the directory and run the script as below;
Works
user@machine:/opt/Tautulli/script/yeelight-shell-scripts$ ./yeelight-scene.sh 0 On
Executing on ID 1 [<IP_ADDRESS>] ...   1 "method":"set_power","params":["on"]
Executing on ID 2 [<IP_ADDRESS>] ...   2 "method":"set_power","params":["on"]
Executing on ID 3 [<IP_ADDRESS>] ...   3 "method":"set_power","params":["on"]

If I run it from the full path, I get a different output and it doesn't run.
user@machine:~$ /opt/Tautulli/script/yeelight-shell-scripts/yeelight.sh 0 On
Executing on ID 1 [<IP_ADDRESS>] ...   1 On
Executing on ID 2 [<IP_ADDRESS>] ...   2 On
Executing on ID 3 [<IP_ADDRESS>] ...   3 On

So it still runs, but there is something about the path that doesn't let it execute correctly?

Right, sorry. I got confused with the script names
I have tested it and it seems to be working when I run "yeelight-scene.sh 0 On" not "yeelight.sh 0 On"
Sorry to waste your time :)


delete_project_directory should delete the whole directory

Currently this iterates through dirs_basic, but quite often users or other libraries will add additional subdirectories. We need to use shutil to wipe the project directory, see previous discussion.

Resolved in 89442f3.


Some improvements to the OData service

Added ability to query for the count of objects matching a filter.
Added ability to query for nested fields.
Added progress information (using rich library) for long duration operations .. like the processing metadata.
Added function to show all [simple] values of an object.
Reworked described method to use rich panels and tables instead of using custom built ones.
Added poetry environment support (supersedes setup.py but still present for now)

I tried to change the email address i used in the commits and in the process I changed 2 of your commits as well :(
But it looks as though there's very little activity in this repo, not sure it'll ever be looked at 😄

From what I can tell this project is no longer maintained.
I've forked and and started publishing it as python-odata on PyPi, you can reach me for any changes you'd like to make.
I'm going to close this pull request now.


Scanned Images not Searchable in Apple Notes

Script works great and PDFs go into apple notes - THANKS
But running into this issue with the scanned notes: https://forums.macrumors.com/threads/apple-notes-search-in-pdfs-from-scanner-not-working.2373987/
Workaround is to open every scanned document in preview, save it and import the newly saved PDF. Not it indexes it.
Is there any possibility to add this functionality to your script?
Using scansnap as my scanner but it does seem to scan and not just capture it as an image.

I’m using ExactScan Pro and it OCRs when I scan, so I probably won’t be adding any steps to the script, but anyone is welcome to take the code and modify it. Sounds like maybe there is an issue with the scansnap software? Just a guess.
Best regards,
Ethan
Ethan Schoonover
E @.***
M @@.*** @.***>
T @ethanschoonover https://twitter.com/ethanschoonover
IG @ethan_schoonover https://www.instagram.com/ethan_schoonover/

On Oct 6, 2023, at 21:54, Mark Herring @.***> wrote:
Script works great and PDFs go into apple notes - THANKS
But running into this issue with the scanned notes: https://forums.macrumors.com/threads/apple-notes-search-in-pdfs-from-scanner-not-working.2373987/
Workaround is to open every scanned document in preview, save it and import the newly saved PDF. Not it indexes it.
Is there any possibility to add this functionality to your script?
Using scansnap as my scanner but it does seem to scan and not just capture it as an image.
—
Reply to this email directly, view it on GitHub https://github.com/altercation/apple-notes-inbox/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA3XBUG6PCLJBZ4NBNBHTTX6DOAVAVCNFSM6AAAAAA5WVA7YGVHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZTCMJYHEYDKMQ.
You are receiving this because you are subscribed to this thread.

Thanks for the advice. What scanning hardware are you using?

scansnap, though I don’t remember which model
Ethan Schoonover
E @.***
M @@.*** @.***>
T @ethanschoonover https://twitter.com/ethanschoonover
IG @ethan_schoonover https://www.instagram.com/ethan_schoonover/

On Oct 7, 2023, at 09:41, Mark Herring @.***> wrote:
Thanks for the advice. What scanning hardware are you using?
—
Reply to this email directly, view it on GitHub https://github.com/altercation/apple-notes-inbox/issues/1#issuecomment-1751766231, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA3XBUKAJ2XPZEUJ5VSOE3X6GA4RAVCNFSM6AAAAAA5WVA7YGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRG43DMMRTGE.
You are receiving this because you commented.


[BUG] The launcher takes too long to close along with the roblox tab, doesn't matter if i'm laggy or not

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
When I close the tab, it doesn't close until 1-2 minutes after, I also tried older versions of Bloxstrap but same issue.
When i finish the task in task manager it still doesn't close, even if I finish Bloxstrap itself.
The tab stays open as well which is what annoys me mostly.
Only happens after loading the game fully apparently.
The consuming Roblox does after closing it or finishing the task caps at 123 mb with 10% of CPU usage

What do you mean by "close the tab"?

The tab where you play roblox on, which would be the bloxstrap launcher
El dom, 10 de mar de 2024, 8:23 a. m., pizzaboxer @.***>
escribió:

What do you mean by "close the tab"?
—
Reply to this email directly, view it on GitHub
https://github.com/pizzaboxer/bloxstrap/issues/1426#issuecomment-1987191787,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BG2ORNMD6HFWC2SSF6EJUI3YXQ7D5AVCNFSM6AAAAABEOSAE7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBXGE4TCNZYG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

You're saying that Roblox still stays open for a few minutes even after trying to close it. Follow this, please:
https://github.com/pizzaboxer/bloxstrap/wiki/Uploading-your-Bloxstrap-configuration

Issue has been awaiting clarification for over a month, closing as stale. If you have anything further to add, just respond and I'll reopen.


sandbox oauth and updates

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

BingAds/customer-management-service/account.md
:white_check_mark:Succeeded

BingAds/customer-management-service/addaccount.md
:white_check_mark:Succeeded

BingAds/customer-management-service/advertiseraccount.md
:white_check_mark:Succeeded

BingAds/guides/TOC.yml
:white_check_mark:Succeeded

BingAds/guides/authentication-oauth.md
:white_check_mark:Succeeded

BingAds/guides/migration-guide.md
:white_check_mark:Succeeded

BingAds/guides/sandbox.md
:white_check_mark:Succeeded

BingAds/guides/sdk-authentication.md
:white_check_mark:Succeeded

BingAds/guides/show-ads-target-audience.md
:white_check_mark:Succeeded

BingAds/guides/walkthrough-desktop-application-csharp.md
:white_check_mark:Succeeded

BingAds/guides/walkthrough-desktop-application-java.md
:white_check_mark:Succeeded

BingAds/guides/walkthrough-desktop-application-php.md
:white_check_mark:Succeeded

BingAds/guides/walkthrough-desktop-application-python.md
:white_check_mark:Succeeded

BingAds/guides/walkthrough-web-application-csharp.md
:white_check_mark:Succeeded

BingAds/guides/walkthrough-web-application-java.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


We don't have documentation about "triaging"

Should we use this term? It's just the term GitHub uses for the role, but we can call it whatever we want. I think the main thing that needs to be explained is labeling issues. What do each of the labels mean and when do we use them? How do you share a link to a label in GitHub Markdown (e.g. https://github.com/nsidc/earthaccess/labels/hackathon is from pasting https://github.com/nsidc/earthaccess/labels/hackathon)? When to use "close issue as not planned"? What is a discussion vs an issue and when should we migrate between them (e.g. discussions for feature requests, issues for bugs?)? etc.

Stumbled on a great example which uses mermaid to draw a triage flowchart!!
https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md#issue-triaging-workflow

@mfisher87 Hey, I am thinking of working on this one, any specific opinions on this one?

Awesome, thanks Sherwin! I would love a flowchart diagram. In answering the questions in the description of the issue, I think it would be OK to leave some questions partially answered. For example, there are some labels like hackathon, good first issue, help wanted, etc. that we're really confident we want people to use and will stay around for a long time. But there are other labels, like "python", that I could imagine being removed or renamed to e.g. "impact/code". We can skip the ones we're not sure about for now, and perhaps once the PR is open others will share their ideas.

@mfisher87 I had a doubt regarding the flowchart. Should I come up with a flowchart different than the one you linked above in the 2nd comment. If yes, how can I decide or how would I know which are the hierarchies and what things are going to be listed under it? I have little idea about this one

I think we can use their flowchart as a base. There are some places I would make things more "Friendly". E.g. instead of "Close and ask to follow template", I'd suggest "Change to draft and ask to follow template".
We currently don't have prioritization labels, so we could omit that part. Or maybe we should add the prioritization labels and start using them! What do you think?
If you're comfortable doing a first draft and opening a PR, that could help start some conversation with the community that will guide us towards a solution.

I think we can use their flowchart as a base. There are some places I would make things more "Friendly". E.g. instead of "Close and ask to follow template", I'd suggest "Change to draft and ask to follow template".
We currently don't have prioritization labels, so we could omit that part. Or maybe we should add the prioritization labels and start using them! What do you think?
If you're comfortable doing a first draft and opening a PR, that could help start some conversation with the community that will guide us towards a solution.

I am thinking of coming up with the first draft. Then we can discuss further on  prioritization labels as well as the flowcharts.

@mfisher87 Hey Matt, I have been working on this one for a while now and I have run into some issues with mermaid, so should I make a PR with whatever I have done uptill now(barring the mermaid part) or should I complete the chart as well and then make the PR? Which option would you deem as plausible former or the latter one?

Feel free to open a PR in draft mode at any time if you'd like feedback or to enable other contributors to follow your progress! I'd appreciate if you'd include your work-in-progress mermaid code so we can take a look and see if we can help :)


expressions precedence

Hello,
I don't find any documentation about rust expression precedence rules in the book and reference. Could someone point me to it if it exists? If not, should it be added to the reference? Related forum post and rust issue #21799 and #44288.
Explanation:
In cases where expression parsing is ambiguous, there must be some expression precedence rules. For operator expressions it is documented in the reference as operator precedence. But for general expressions it is unclear, in ambiguous cases, which expression type takes precedence over the other. Two examples: 0..10.some_method() (range expr vs method call expr), &some_struct.some_method() (operator expr vs method call expr).
Thank you

Since .. and ... (which needs to be converted to ..= now) are already in the operator precedence listing, it would probably work to add . (field/method access), & (referencing), and [] (indexing) to the listing to solve this.

I'll second the request. Auto-deref magic makes precedence even less obvious, e.g. foo.bar doesn't work for *const _, because it needs to be (*foo).bar (and not *foo.bar).
Also syntex_syntax does not insert parenthesis when printing AST, so AST nodes with incorrect precedence generate invalid code :(

I didn't test much, but from what I could gather, the sequence is basically the following:

expressions such as break, return, closures, etc., have the same and lowest precedence. They accept an "open" expression after them. || a + b is || (a + b), not (|| a) + b.
followed by operator expressions (those documented on the reference)
followed by .field, .tupleField, .methodCal(), fnCallOrEnumVariant(), e[arrayIndex], which have the same precedence and are interpreted from left to right as they appear.
and precedence doesn't matter to expressions that enclose all of their subexpressions. For example tuples (e,e,e), arrays [e,e,e] and [e;3], parenthesized expressions(e), if, if let, for, while, etc..

Some tests I've made


Add saving indicator to PM report tab on PSR details

On the PM report tab, add the following:

[ ] Light gray upload icon when request to save is started
[ ] Green checkmark icon when request finishes successfully
[ ] Yellow exclamation icon when request fails

Place the icons in the blue bar oppose the Submit button
Icons

https://icons.getbootstrap.com/icons/cloud-upload-fill/
https://icons.getbootstrap.com/icons/check-circle-fill/
https://icons.getbootstrap.com/icons/exclamation-diamond-fill/

https://rxjs.dev/api/index/function/tap


Host release on GitHub

https://f-droid.org/packages/com.projectsexception.myapplist.open
Can the app be added to the GitHub releases

The title of this issue is incorrect.  The app has just been moved to the F-Droid archive, as befits having no releases since > a decade!  I  just took this screenshot seconds ago:

Damn that's dumb. They delete things off fdroid and move them to a different archive repo?
And it sucks that archive repo isn't compatible with obtainium.
My request to have the apk release hosted on GitHub under releases still stands

Damn that's dumb they delete the links of apps and move them to a separate repo?
I've modified the title, but regardless of semantics. They've delete the app repo URL.
GitHub has releases support, so the apk should be here

Good luck!  Even last activity in this repo was 9 years ago, so everyone now considers it abandonware.
But, it's open-source!  You could take on maintenance & updating, & release it yourself under the license.


Reenable compound assignment preference

PR Summary

Reenable compound assignment preference in .editorconfig.
PR Context

All violations of the rule should be fixed by now.
Fixes #17631
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

Okay, I already see some missed cases. I wonder what is different between the CI and my local environment?

Hm, one of them looks like a false positive. In /src/System.Management.Automation/singleshell/config/MshSnapinInfo.cs(1287,25):
                        if (s_defaultMshSnapins == null)
                        {
                            s_defaultMshSnapins = new List<DefaultPSSnapInInformation>()
                            {
#if !UNIX
                                new DefaultPSSnapInInformation("Microsoft.PowerShell.Diagnostics", "Microsoft.PowerShell.Commands.Diagnostics", null,
                                    "GetEventResources,Description", "GetEventResources,Vendor"),
#endif
                                new DefaultPSSnapInInformation("Microsoft.PowerShell.Host", "Microsoft.PowerShell.ConsoleHost", null,
                                    "HostMshSnapInResources,Description", "HostMshSnapInResources,Vendor"),

                                s_coreSnapin,

                                new DefaultPSSnapInInformation("Microsoft.PowerShell.Utility", "Microsoft.PowerShell.Commands.Utility", null,
                                    "UtilityMshSnapInResources,Description", "UtilityMshSnapInResources,Vendor"),

                                new DefaultPSSnapInInformation("Microsoft.PowerShell.Management", "Microsoft.PowerShell.Commands.Management", null,
                                    "ManagementMshSnapInResources,Description", "ManagementMshSnapInResources,Vendor"),

                                new DefaultPSSnapInInformation("Microsoft.PowerShell.Security", "Microsoft.PowerShell.Security", null,
                                    "SecurityMshSnapInResources,Description", "SecurityMshSnapInResources,Vendor")
                            };

#if !UNIX
                            if (!Utils.IsWinPEHost())
                            {
                                s_defaultMshSnapins.Add(new DefaultPSSnapInInformation("Microsoft.WSMan.Management", "Microsoft.WSMan.Management", null,
                                    "WsManResources,Description", "WsManResources,Vendor"));
                            }
#endif
                        }

It's not just an assignment inside the outer if, so analyzer shouldn't trigger here, what do you think?

I wonder what is different between the CI and my local environment?

The system is different, CI errored on Linux and macOS and I use Windows. 3 cases were inside #if UNIX hence why they didn't trigger for me.
4th one has #if !UNIX clause inside hence why it doesn't trigger on my local machine. But in CI Analyzer thinks there's no extra code inside and suggests this change. I'm not sure if it is correct behaviour.

It's not just an assignment inside the outer if, so analyzer shouldn't trigger here, what do you think?

We can rewrite the code block into this and it should please Analyzer on both platforms:
#if UNIX
                        s_defaultMshSnapins ??= new List<DefaultPSSnapInInformation>()
                        {
                            new DefaultPSSnapInInformation("Microsoft.PowerShell.Host", "Microsoft.PowerShell.ConsoleHost", null,
                                "HostMshSnapInResources,Description", "HostMshSnapInResources,Vendor"),

                            s_coreSnapin,

                            new DefaultPSSnapInInformation("Microsoft.PowerShell.Utility", "Microsoft.PowerShell.Commands.Utility", null,
                                "UtilityMshSnapInResources,Description", "UtilityMshSnapInResources,Vendor"),

                            new DefaultPSSnapInInformation("Microsoft.PowerShell.Management", "Microsoft.PowerShell.Commands.Management", null,
                                "ManagementMshSnapInResources,Description", "ManagementMshSnapInResources,Vendor"),

                            new DefaultPSSnapInInformation("Microsoft.PowerShell.Security", "Microsoft.PowerShell.Security", null,
                                "SecurityMshSnapInResources,Description", "SecurityMshSnapInResources,Vendor")
                        };
#else
                        if (s_defaultMshSnapins == null)
                        {
                            s_defaultMshSnapins = new List<DefaultPSSnapInInformation>()
                            {
                                new DefaultPSSnapInInformation("Microsoft.PowerShell.Diagnostics", "Microsoft.PowerShell.Commands.Diagnostics", null,
                                    "GetEventResources,Description", "GetEventResources,Vendor"),
                                new DefaultPSSnapInInformation("Microsoft.PowerShell.Host", "Microsoft.PowerShell.ConsoleHost", null,
                                    "HostMshSnapInResources,Description", "HostMshSnapInResources,Vendor"),

                                s_coreSnapin,

                                new DefaultPSSnapInInformation("Microsoft.PowerShell.Utility", "Microsoft.PowerShell.Commands.Utility", null,
                                    "UtilityMshSnapInResources,Description", "UtilityMshSnapInResources,Vendor"),

                                new DefaultPSSnapInInformation("Microsoft.PowerShell.Management", "Microsoft.PowerShell.Commands.Management", null,
                                    "ManagementMshSnapInResources,Description", "ManagementMshSnapInResources,Vendor"),

                                new DefaultPSSnapInInformation("Microsoft.PowerShell.Security", "Microsoft.PowerShell.Security", null,
                                    "SecurityMshSnapInResources,Description", "SecurityMshSnapInResources,Vendor")
                            };

                            if (!Utils.IsWinPEHost())
                            {
                                s_defaultMshSnapins.Add(new DefaultPSSnapInInformation("Microsoft.WSMan.Management", "Microsoft.WSMan.Management", null,
                                    "WsManResources,Description", "WsManResources,Vendor"));
                            }
                        }
#endif

Or we can ignore this rule locally.
I'll let the maintainers decide.

Hm, one of them looks like a false positive. In /src/System.Management.Automation/singleshell/config/MshSnapinInfo.cs(1287,25):

Please suppress locally.

@Molkree I guess CIs fail because we need to fix compound assignment in test code (weblistener).

@iSazonov, I am stumped, from failing tests I can only see that the WebListener did not start before the timeout was reached., with no pointers as to why. Any help here?

@Molkree Try compile test\tools\WebListener\ - I guess there are compound assignments we should fix.

Try compile test\tools\WebListener\

@iSazonov, thank you!


[Q] Unexpected token error

Just installed Graphite using homebrew.
Installation was done without error, and followed the step here to authenticate.
https://docs.graphite.dev/guides/graphite-cli/authenticating-the-cli
however any commands using gt gives me the following error. Tried to unstalled and reinstalled also but seems it is same.
What should be done to solve this error ? tried to google it but didn't really get the right answer.
Xcode version : 13.4.1
MacOs : Monterey 12.5.1
Installed graphite : v0.20.10.zip
/usr/local/Cellar/graphite/0.20.10/libexec/lib/node_modules/@withgraphite/graphite-cli/dist/src/background_tasks/post_traces.js:38
                auth: user_config_spf_1.userConfigFactory.loadIfExists()?.data.authToken,
                                                                         ^

SyntaxError: Unexpected token '.'
    at wrapSafe (internal/modules/cjs/loader.js:1054:16)
    at Module._compile (internal/modules/cjs/loader.js:1102:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)
    at Module.load (internal/modules/cjs/loader.js:986:32)
    at Function.Module._load (internal/modules/cjs/loader.js:879:14)
    at Module.require (internal/modules/cjs/loader.js:1026:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/usr/local/Cellar/graphite/0.20.10/libexec/lib/node_modules/@withgraphite/graphite-cli/dist/src/index.js:11:23)
    at Module._compile (internal/modules/cjs/loader.js:1138:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)

Hi @heejeongMin
Wrong repo. You're using https://graphite.dev/ but this repo is about https://graphiteapp.org/


what's the feature of a bad weights matrix?

In some cases I meet two troubles:

\sum_n W_nk is slightly large than 1, about 1.0005
huge covariance

I try to inspect the weights matrix, however it's difficult to figure out the underlying defects in the weights matrix
Can you give me some advice? Thanks!

Can you try this dataset with 4.0 now?  The solvers might be better able to converge.  You an also try bootstrapped errors, which will be more valid when analytical errors are failing.


CompilerMSL pass builtin struct members into functions.

Add and use Compiler::get_non_pointer_type() convenience functions.
Fixes issue #610.

@HansKristian-ARM
Is there a reason you didn't merge this PR?
Did you want me to do it...or are you waiting for other dev activities?

I generally wait for Travis to complete before merging accepted PRs.

Ah...okay...I figured Travis was done before your approval. Thanks for merging.


Automate validation of notebooks

To ensure that the example notebooks keep working as the codebase and data changes, we should automatically test them:

[ ] When dev is updated in the main PUDL repo and the nightly builds pass.
[ ] Whenever a new release tag is pushed to main in the main PUDL repo.

Particular versions of the example notebooks, corresponding to previously released versions of PUDL, should be tagged and obviously associated with that release, so they can be used with it if need be.

The new notebooks are automatically run on Kaggle whenever there's a data update, which is scheduled to happen once a week right now, so I think this is kinda done for now.


[DOCS] Links shouldn't be optional

Description
Links shouldn't be optional
This app is called LinkFree, if there will be no links in the user profile,
then what will be the use case for apps like LinkFree
Screenshots

Additional information
No response

Hey!! If this issue is still open I would like to work on the issue. If its not assigned to anyone please assign it to me

It will be a profile page, especially as people can now use markdown (or they could use milestones or events section)