VirtualBox: Update to support new B2D

This PR is for machine support for the new version of Boot2Docker.  This does the following:

Enable shared folders for all supported platforms (Mac, Win, Linux)
Restrict default shared folder to user home directory
Remove the SSH key loading via disk image
Cleanup B2D provisioner

This has been tested successfully on Mac, Windows and Linux with no issues so far.
To test, pre-built binaries are here:
ISO: https://s3.amazonaws.com/docker-mcn/public/b2d-next/docker-virtualbox-20150720-1148.iso
Mac: https://s3.amazonaws.com/docker-mcn/public/b2d-next/docker-machine_darwin-amd64
Win: https://s3.amazonaws.com/docker-mcn/public/b2d-next/docker-machine_windows-amd64.exe
Linux: https://s3.amazonaws.com/docker-mcn/public/b2d-next/docker-machine_linux-amd64

/cc @nathanleclaire @hairyhenderson @tianon @samalba @bfirsh

@tianon @nathanleclaire updated.  this now uses homedir instead of the env var.  Tested on Mac, Linux and Windows successfully.  PTAL

The integration tests will have to be updated to not reference overlay if this is the kernel version we're going to be sticking with --- the kernel isn't old enough :(

@nathanleclaire +1 -- I'll update

If we manage to get a 4.x we will lose aufs and will need to specify
overlay as the default explicitly, so we have a trade-off either way.

If we manage to get a 4.x we will lose aufs and will need to specify
overlay as the default explicitly, so we have a trade-off either way.

:(
I'm inclined to aufs for this release, but at any rate we will still need to update the integration tests as the --engine-storage-driver overlay test will no longer work.

@nathanleclaire already updated with btrfs.

Ah, nice @ehazlett

I've also updated the Fusion driver to use this.  /cc @frapposelli

We should make sure that hyper-v doesn't break as well. cc @ahmetalpbalkan

@nathanleclaire I am not a Windows or Hyper-V user. :-) I haven't ever tried machine with hyper-v either.

@nathanleclaire https://github.com/boot2docker/boot2docker/commit/3c22cf0924b6b531d68f9c568353115688d43474 just for you :heart:
(please don't hurt me @ehazlett; it's for the greater good! :see_no_evil:)

@nathanleclaire boot2docker/boot2docker@3c22cf0 just for you :heart:

Ah I thought this was going to be adding the ASCII art whale and I was going to post a very triumphant GIF

@tianon :+1: :D

I will attempt the hyper-v updates

@nathanleclaire:
FROM dockercore/iso

RUN { \
		echo 'VARIANT="Nathan LeClaire Edition"'; \
		echo 'VARIANT_ID=nathanleclaire'; \
	} >> /etc/os-release

COPY whale.txt /etc/motd
RUN echo 'cat /etc/motd' >> /home/docker/.bashrc

(untested, but should totally work -- save it as Dockerfile.nathanleclare in your checkout of the /tree/ng branch and run make nathanleclare.iso and it should "just work")

... and include https://github.com/boot2docker/boot2docker/blob/6247cc1e73eae6d03f5bfaeadad69b302cbea1eb/rootfs/rootfs/usr/local/etc/motd as whale.txt of course

So are we just marking upgrade as a big "TODO: BEFORE RELEASE" in this?  If the user goes to docker-machine upgrade vm a VM created with this PR, it won't go get the ISO, it will actually try to run apt-get upgrade which is what the Debian provisioner wants.

Something to note (we should probably make a separate issue as I am ready to merge this for now):
upgrade will be broken for local providers with this change as the provisioner will simply attempt a command like apt-get upgrade lxc-docker instead of actually upgrading the ISO.  It will need to be fixed before the release.
Other than that, LGTM

This now has upgrade support.

Now with Hyper-V support!

@tianon just for you ;) ^^

Fusion shared folders working again.  <3 to @tianon :D

@frapposelli any idea why vmtoolsd doesn't actually do any amount of automounting?

@nathanleclaire this should be good to go.  I believe we've closed the last few issues.

@tianon it does automount but only when you enable/disable shared folders at the hypervisor level.

@frapposelli oh, that's bizarre -- no auto-mount on boot for folders already set up then? :disappointed:

LGTM


Use Node.js v6.x

Node.js v4.x goes into maintenance mode as of 2017-04-01.
We should update our packaging to use Node.js v6.x by default.

@emedvedev maybe we should do this in conjunction with upgrading the hubot-slack version, to work around some issues with proxies & stability?  https://github.com/StackStorm/st2chatops/issues/56


Does not re-compute when in block helper

If I use the component as a block (so I can discard the "see more"), if the value being truncated is a value from a model and is externally changed, the value will not update in the template:
Does not update value of @model.name in the template when externally change
            <TruncateMultiline @lines=2 as |TM|>
<EMAIL_ADDRESS>            </TruncateMultiline>

However, if I invoke as an inline component, it works as expected and externally updating the @text value re-computes the value.
Update value of @model.name in the template when externally change
            <TruncateMultiline
<EMAIL_ADDRESS>                @lines=2
            />

I suppose that this is caused because didReceiveAttrs is triggered for the inline component, which triggers another truncate operation. But when used in block form, there's no signal to the component that it should re-toggle (i.e no @text arg is used).
This seems like a bit go a gnarly bug to fix and still allow composition via block form.
Perhaps the easiest way to mitigate this is to allow disabling 'seeMore' toggle when used in in-line?


Add Slash Pages

Using this as inspiration create and fill out your slash pages:

[ ] carry
[ ] colophon
[ ] defaults
[ ] ideas
[ ] interests
[ ] nope
[ ] now
[ ] podroll
[ ] til
[ ] uses

pages have been added, but after much trial and error, I need to remove the Save_as line in all of the pages directories to allow my settings to actually take effect


Make the multi view work now that the backend expects a JWT in a cookie

maybe make a thing that will generate JWTs that are valid for x days so we can generate one that is usable for the entire event.

Needed:

Update fetch() calls to include credentials. (This may already be there from attend.html/play.html paths)

Nice to have:

have the jwt tokens include a claim that allows accessing the multiview. This JWT can always be created by hand and shared at the start of the conference internally.


Slowness when MLT is active

Hello! Even without any active modules, other than MLT, I'm experiencing a lot of lag. Foundry is very slow, even on small maps, with few lights/walls/tokens/etc, including on maps where there is no MLT functionality being used. I didn't find any errors in the console, but it's definitely MLT, since it happens with only it activated, but not with all my other 117 modules (except MLT). Usually after 2 or 3 minutes with the same map active, the lag reduces, it seems like a loading problem.
I'm using MLT 1.7.5, Foundry 12.311 and D&D 5e 4.0.4. My module settings are: all activated, except for chat bubble synchronization. I'm using Foundry in medium performance mode, with 60 FPS.
Sorry for not having more information, please let me know if there is any other test I can do! Thanks.

It seems your are the only one with this issues, so it is difficult to state why do you see "slowdown". Could you provide more details about what you call "Slowdown" exactly ?

The screen freezes for 1-2 seconds, the interface stops responding. Sometimes I click on a button, close or open a window and the software takes a while to respond. Foundry's weather effects freeze and move constantly. The canvas takes a while to move or moves with small freezes.
I performed tests with several maps and without any other modules, but it was an already populated world. Later today I will make a new instance of Foundry installation, install MLT and test with an empty world, and then I will report back.
Thank you!

Hello again! I have run several tests and have not been able to find the source of the problem. It only occurs in a specific world. Even enabling only MLT and resetting the settings for that world to default, it still occurs. However, I have not been able to find a specific setting or situation in which it occurs. Therefore, I think this ticket can be closed. Sorry for the inconvenience!

Close as unique case


Incorrect EventID

Event ID 3001 should actually be Event ID 3000

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7c813d7c-1789-d0c9-c833-cbdd3f60e2b8
Version Independent ID: e5b7e6a7-2f78-dd58-b450-0d173935e26c
Content: Deploy Microsoft Teams Rooms management with Azure Monitor - Microsoft Teams
Content Source: Teams/rooms/azure-monitor-deploy.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

@troeh9 Thank you for submitting feedback and contributing to the docs. We are currently investigating this.
@Reeced40

@troeh9 thank you for reaching out. Are you referring to each instance in this article that should be changed to 3000?

@Reeced40 correct.  example would be the query in section "https://docs.microsoft.com/en-us/microsoftteams/rooms/azure-monitor-deploy#map-custom-fields"
Event | where Source == "SRS-App" and EventID == 3001
no data is returned when using 3001.  If you use 3000, the correct data is returned.  Any reference to 3001 should be changed to 3000


Add PowerZure

PowerZure is a PowerShell project created to assess and exploit resources within Microsoft’s cloud platform, Azure.
This PR is blocked until #269 is resolved.

Also @nos3curity I also just noticed that this has a dependency we might be able to solve either by manual installation within the package or through a preexisting chocolatey package:
Install-Module -Name Az

@nos3curity bump


Added dim parameter to tf.losses.softmax_cross_entropy

Added dim parameter to losses.softmax_cross_entropy. Fixes #20866

(for API owners) Yes, should be axis. Fine otherwise.

Nagging Assignee @caisq: It has been 22 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @caisq: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @caisq: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @caisq: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @caisq: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@Siddhant085 Sorry for the delay, but please take a look at the test failures, e.g.,
https://source.cloud.google.com/results/invocations/f9de5bb5-3450-4f3c-b30a-e978b5e2203b/targets/%2F%2Ftensorflow%2Fpython%2Fkernel_tests:losses_test/log

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

It has been 43 days that this pull-request has stalled. Please create a new pull-request with the requested changes.


Update side panel

References #19

[x] Side panel does not show email contents
[x] Side panel shows confidence score
[ ] Side panel shows spelling, grammar, and keyword partitions

Restructured sidebar to have collapsible sections for spelling and grammar, which involved some restructuring of the div structure.
[t:120]

Added keyword collapsible section and variable font sizes after seeing my work on a smaller screen.
[t:60]

Merged in edits with keywords and formatted them like the spelling and grammar. Also figured out a messy merge conflict.
[t:60]


Apps not installing in true system context

Hi there,
Just to let you know that when installing applications, they do not appear to be installing in true system context, for example, take the Azure Data Studio application, when installed via Intune, it installs into the System profile, rather than being specified to install for all users, so the installation is placed with the system profile at this location:

However, the application is not available to any users:

Logs:

I think what is missing is the --scope machine parameter on the installation commands.
Here's the intune app, it's specified as system:

you can add the scope in your install command.

Hi there,
I thought it did this automatically? I can see a function for machine scope? I'm using your intuneGUI, is it a simple case of adding an additional parameter of '--scope machine'

Hi there,
Was wondering if you saw my previous comment? :)

it sometimes depend on the apps themselves.

it sometimes depend on the apps themselves.

Thanks :), so in your tool, do I specify '--scope machine' in the command line parameters?


Fix: fix edgecase for tagging system

So I was playing around with my code and realized that if a person has tags less than the max limit ( 5 ) then the tag creator will return an empty array.
Although this won't break the workshops, I created this small change that will solve this issue.
So once this is merged if the person has less than 5 tags then those tags will become relevant for search,  if they have more than 5 then the first 5 will be chosen.

Thanks, @sampoder, you are awesome 🙌


GH: Receiver does not receive the desired commit

Hi!
I'm trying to receive a specific commit, but the ghp receiver component always get me another commit.

You should have the access to the project, in case it's needed.
The workaround is to grab the wrapped object url inside the commit. That works.
I'm a bit behind with master, since it's stable and I'm at the end of the project... So it might be that the problem is solved already. In case can you let me know?
I'm at 2.1.19-beta
Thanks! <3

afaik, yep - @AlanRynne fixed this in a previous release. He'll follow up with the specific commit (we know you're building your own!).

Correct! It wasn't fixed long ago though... You can find the code changes in this PR, in case you're not in the latest version:
https://github.com/specklesystems/speckle-sharp/pull/595/commits/f92afd690178f180772cf2d63df3a0020fcbb263

Thanks guys!


IllegalAccessError CompoundCacheKey

Hi, could you help me , what is this error ? how can i solved it
on logstash 5.6
[ERROR][logstash.inputs.jdbc     ] Unable to connect to database.
What MySQL version are you connecting to?
What Java version are you on?

If I remember correctly logstash 5 requires a different version of java. So you should've updated java and changed your MySQL jar.. If you didn't do that it may explain your issue.
I know MySQL works because it's included as part of the test suite.


Shortcut method to narrow column type

I have a legacy database where I use varchar to keep string codes which can only be one of select values (sort of enums but not using the actual database enums and not the JS level enums). So technically this column returns a runtime string value, which is fine, but I would like it to be typed as "foo" | "bar" both in query results and in query parameters.
What I'm currently using is:
type OrgType = "foo" | "bar"

class OrgTable extends BaseTable {
  columns = this.setColumns(t => ({
    type: t.varchar().parse(t => t as OrgType).encode((t: OrgType) => t),
  })
}

I was thinking that this is perhaps a fairly popular scenario which may deserve a dedicated shortcut, such as:
columns = this.setColumns(t => ({
  type: t.varchar().cast<OrgType>(), // just thinking. or may be .type()
})

Another way to use this would be:
columns = this.setColumns(t => ({
  data: t.json().cast<MyFancyJsonType>(),
})

as there is currently not much value in carefully describing the json structure with the t => t.object(...) callback.

asType sounds good.
I must admit I'm not sure how to code the actual function. All the other column methods use generic parameter to infer and alter the type of this, and thus are not supposed to accept user-provided parameters:
https://github.com/romeerez/orchid-orm/blob/577903ee8fba02d58b1da8fbe0d7fcc3faec819e/packages/core/src/columns/columnType.ts#L587-L595
However, the imaginary .asType<Type>() can't work like this. Ideas?
I can only think of some duct tape like: .asType(type<Type>()) using a type-hint no-op helper, which I think should only be used as last resort.
Also, I was wondering where the test was supposed to go. I only found packages/qb/pqb/src/columns/columnType.test.ts. Shouldn't tests against "core" methods such as nullable be moved outside of pqb?

OK, I can actually do something like:
asType<Type>() {
  return this as SetColumnType<typeof this, Type>;
}

Then it's the matter of updating type/inputType/outputType/queryType thoughtfully.

// base column type
export abstract class ColumnTypeBase<
  Type = unknown,
  // Ops will be used
  Ops extends BaseOperators = BaseOperators,
  InputType = Type,
  OutputType = Type,
  QueryType = Type,
  // Data will be used
  Data extends ColumnDataBase = ColumnDataBase,
> {
  // ...

  asType<Type, Input = Type, Output = Type, Query = Type>(
    this: ColumnTypeBase,
  ): ColumnTypeBase<Type, Ops, Input, Output, Query, Data> {
    return this as any;
  }
}

Here the main Type is passed from the user, 3 additional types can be passed optionally from the user and are defaulted to the main type. Ops and Data are applied from the class generics.
The last thing, Ops and Data are applied from the class generics, which isn't good:
// without `asType`:
const nullableColumn = someColumn.nullable()
nullableColumn.data.isNullable // has type `true`

// with `asType`:
const nullableColumn = someColumn.nullable().asType<number>()
nullableColumn.data.isNullable // no longer `true`, may lead to non-obvious bugs

Ops isn't going to be changed, so it's not a problem, only the Data is. To solve the problem above, each time when changing the column data we would need to also update the asType signature to apply the fresh Data type.
For simplicity and who knows how this negatively impacts TS performance, I think it's good enough to point in the docs that asType should applied before other methods such as nullable.

I was wondering where the test was supposed to go

I moved methods from pqb to core but didn't move the corresponding tests. Ideally, tests also should be moved, but it's not a big deal.

Idea: asType could be a standalone utility function setColumnType:
import { setColumnType } from 'orchid-orm or pqb';

type OrgType = "foo" | "bar"

class OrgTable extends BaseTable {
  columns = this.setColumns(t => ({
    type: setColumnType<OrgType>(t.varchar())
  })
}

It would simply replace existing type, inputType, etc with new ones, without problems as above. Stylistically I don't like it, but it solves the problem.

Another option is to add a generic to text columns.
text would have a single optional generic:
type: t.text<OrgType>()

varchar without limit is the same as using text (according to postgres docs). And in case if varchar has a limit it doesn't make much sense to apply a union type to it, as it's expected this union is validated somewhere in the app. Or, to have both the custom type and the limit, varchar could have a limit method instead of the parameter as it has now. t.varchar<OrgType>().limit(100).

I don't think we should return ColumnTypeBase, we lose the interface of the derived class. It won't be possible to do t.text().asType().primaryKey() and I think the entire table type might be broken.
I'm in favour of setColumnType<Type,Input,Output,Query>(t.column()) or the no-op typings helper t.column().asType(columnType<Type,Input,Output,Query>()) which I like slightly better as it chains consistently.

Merged your PR, thanks! Here are the docs of asType for reference.


How to change the color of the mode indicator and the separator

I'm using solarized with a > separator and the contrast is really low to the point my eyes hurt trying to distinguish the left triangle

How can I change the color itself without touching the colorscheme settings?

Changing some colors without changing the colorscheme is asked several times before (e.x. https://github.com/itchyny/lightline.vim/issues/381#issuecomment-523529581).
autocmd VimEnter * call SetupLightlineColors()
function SetupLightlineColors() abort
  let l:pallete = lightline#palette()
  let l:pallete.normal.left[0][3] = 196
  call lightline#colorscheme()
endfunction

Thanks, I did search but not for long enough it seems, sorry! Is it also possible to set the separator color that way or is it derived from the normal color?

The separator colors are automatically derived.


feat: introduce defines for single and double word cpu reg access

This is just a quick and dirty substitution of, i.e., cpu.HL.word as CPU_DREG_HL and cpu.HL.bytes.high as CPU_REG_H.
This should make the code much more readable and more fool-proof to write.
Please give me a quick opinion on this.

Do you mind (while you're at it) changing the Register union?
I think that the naming is not optimal right now since AF is not a register, but rather a register pair, I guess? Do you have any suggestions @mormod @Benzammour?

I think DoubleWordReg is a good option since its expressive. Something like DRegister could potentially be understood as the D Register sitting in the double word register DE.

DoubleWordRegister could also reference a register consisting of 2 words, which are not necessarily different registers.
I would opt for RegisterPair.

DoubleWordRegister could also reference a register consisting of 2 words, which are not necessarily different registers. I would opt for RegisterPair.

I would have agreed one second ago. I just skimmed through the CPU manual and found this:

Hence my answer from above is not correct AF actually is a register, simply not an 8bit register 🤔


⚠ WSINGRESOS - RECIBOPAGO has degraded performance

In f671d53, WSINGRESOS - RECIBOPAGO (https://srvshyweb.yucatan.gob.mx/cgi-bin/wspd_cgi.sh/WService=wsingresos/internet/servicios/wsRecibosPagosWeb.r) experienced degraded performance:

HTTP code: 200
Response time: 6294 ms

Resolved: WSINGRESOS - RECIBOPAGO performance has improved in 86708df after 27 minutes.


Feature/binder fix

This PR fixes several small but pressing errors that need to be fixed in the public documentation: binder proper code linking and JupyterLite removal, apart from different small fixes.

PR looks good!
One issue that needs to be corrected:
Why .\make.bat html in the README? This command is specific to Windows? If a Windows-specific command is required, please specific and also keep the previous and more standard Linux/macOS command make html.
Note: would be smart to create and issue for JupyterLite maybe (if does not exist)
Thanks!

Good point; I just reverted to make html command. I had had an issue in my Windows machine and hadn't properly understood the differences Windows/MacOS-Linux.
For the JupyterLite issue, it is detailed here: https://github.com/splineops/splineops/issues/30


Chart is not defined error when trying to import

I'm trying to set this plugin up with react-chartjs-2, according to your demo.
I read your Gotchas section, which shows that I have to import chartjs-plugin-dragdata.
But when I do that I just get:
ReferenceError: Chart is not defined
    at eval (webpack:///external_%22Chart%22?:1:18)
    at Object.chart.js (/Users/martaver/Projects/sightful/git/sightful/node_modules/chartjs-plugin-dragdata/dist/chartjs-plugin-dragdata.js:816:1)
    at __webpack_require__ (/Users/martaver/Projects/sightful/git/sightful/node_modules/chartjs-plugin-dragdata/dist/chartjs-plugin-dragdata.js:20:30)
    at eval (webpack:///./src/index.js?:2:66)
    at Module../src/index.js (/Users/martaver/Projects/sightful/git/sightful/node_modules/chartjs-plugin-dragdata/dist/chartjs-plugin-dragdata.js:805:1)
    at __webpack_require__ (/Users/martaver/Projects/sightful/git/sightful/node_modules/chartjs-plugin-dragdata/dist/chartjs-plugin-dragdata.js:20:30)
    at /Users/martaver/Projects/sightful/git/sightful/node_modules/chartjs-plugin-dragdata/dist/chartjs-plugin-dragdata.js:84:18
    at Object.<anonymous> (/Users/martaver/Projects/sightful/git/sightful/node_modules/chartjs-plugin-dragdata/dist/chartjs-plugin-dragdata.js:87:10)

My import code:
import Chart from 'chart.js';
import 'chartjs-plugin-dragdata';

Using version<EMAIL_ADDRESS><EMAIL_ADDRESS>(as per demo) and<EMAIL_ADDRESS>(also as per demo).
Without trying to import chartjs-plugin-dragdata, my Line chart renders fine (just not draggable, obviously).
Any idea what might be going on?

The line that fails is the export:
eval("module.exports = Chart;\n\n//# sourceURL=webpack:///external_%22Chart%22?");

Ahhhh got it!
Brain fart... I'm using nextjs and it was looking for the Chart instance during serverside render, probably on window (which didn't exist).

Thanks :D

That's good to now! I had a similar issue when trying to use the plugin in an Observable, where it silently failed to load due to a the missing window.Chart object... Anyway good you found it!

@martaver I am wondering how did you get this to work with NextJS? I have been trying to link the plugin to the react-chartjs-2 but it's not working. Can you please provide what extra code did you write specific to NextJS that helped connecting the plugin to the package?

Do we have a solution on how to use with nextjs?
@chrispahm @ylkhayat @martaver


IO.pipe gets stuck after feeding in 0x10000 bytes

The following code hangs in the IO.copy:
input = IO::Memory.new("a"*0x10001) # 0x10000 works, 0x10001 doesn't
reader, writer = IO.pipe
IO.copy(input, writer) # doesn't get past this copy in case of 0x10001 above
writer.close
while l=reader.gets
    # puts(l) # optionally clutter the console
end

It does work if I decrease by one byte.
What I actually wanted to do is to sandwich the bytes from one stream between some prologue and epilogue. For that I tried piping things together but somehow it didn't work out for larger chunks. (The above code is just the stripped-down version.)
I couldn't find any buffer size limitation - if there's a better way to achieve the goal.
I have crystal 1.3.0 on Ubuntu 18.04

I'm pretty sure this has something to do with using IO.pipe. In that some buffer fills up, and since nothing is reading the data it stays full and blocks waiting for that to happen. Try spawning another fiber for the IO.copy and writer.close part:
input = IO::Memory.new("a"*0x10001) # 0x10000 works, 0x10001 doesn't
reader, writer = IO.pipe
spawn do
  IO.copy(input, writer) # doesn't get past this copy in case of 0x10001 above
  writer.close
end
while l = reader.gets
  puts(l) # optionally clutter the console
end

this seems to do what you want.

yes :) it does!
I also tried fibers upfront with my original code, but it didn't work out - I have to put all of the "producer" logic into the fiber (obviously), then it also works there.
For the example above I somehow forgot to give it a try.
Thanks!

I'm wondering if there should be some mention of such gotchas in the API docs.


Using gulp ruby sass as a dependency in Elastic Beanstalk.

I am using it in gulpfile as follows:
.pipe($.changed('css', {extension: '.scss'}))
        .pipe($.changed('css', {extension: '.sass'}))
        .pipe($.rubySass({
            style: 'expanded',
            precision: 10,
            bundleExec: false
        }))
        .on('error', console.error.bind(console))

But the error is as follows despite being sass available on path
[12:03:22] Starting 'styles'...
{ [Error: spawn ENOENT: Missing the Sass executable. Please install and make available on your PATH.]
  message: 'spawn ENOENT: Missing the Sass executable. Please install and make available on your PATH.',
  showStack: false,
  showProperties: true,
  plugin: 'gulp-ruby-sass',
  __safety: { toString: [Function] } }
[12:03:22] 'css' all files 0 B

I have an open question as well
http://stackoverflow.com/questions/29895475/elastic-beanstalk-dependencies-not-available-in-npm-install/29937117#29937117
But whats important here is gulp-ruby-sass dosent work even if sass is installed in all ruby installations in elastic beanstalk I investigated the bundleExec option but that wasnt the case as well.

What happens when you run the sass gem directly from the command line? How does the OS know which versions of Ruby to use?

I ssh into the system and am installing the gem manually to locally install then use the it
cd /var/app/current
sudo chmod 757 -R ./public-debug && sass --update client/css:public-debug/css --sourcemap=auto

Yes, looks fine. FYI, you don't have to explicitly set it to false since that is the default.

In your script you are starting with $.changed(. GRS is a source adapter — it's used instead of gulp.src, and can't have any functions called before it in the stream.
Can you try again following the example in the readme, then re-open if the error persists.


lerna: remove caret ^ from dependencies version range

Which package/s are you suggesting this feature for?
Dashboard
Is your feature request related to a problem? Please describe
If we use older version of grid client for example 2.4.0, its dependencies that contain ^ will have newer version.

Describe the solution you'd like
on lerna version we should update the dependencies with the exact new version, without any version range comparator

Verified, Devnet v2.5.0.
The lerna: remove caret ^ is removed from all installed version.


Autologin

As a suggestion to add the ability to enable autologin (redirect) to the configured idp if the user is not authorized and local login is disabled.
I configured this in the webserver config, but it may be more correct in the service.
    location = / {
	return 301 https://$server_name/auth/oidc/sso;
    }

@ihard what is the use case for it? Is this so that users don't need to click an IDP login button on the login form?

Yes, skip one screen

It won't be an easy feature to implement: we allow adding multiple  OIDC providers and then if you select one of them for default redirect others will be unusable. Also, users should be aware why they redirected to OIDC (click that button themselves), otherwise you go to some site and land on google.com which is confusing..

The proposed option is relevant only for one idp, for example, when used in an organization. If this is difficult to implement, I will continue to use the redirect in the web server.

For now it would be better to link directly to the IdP in question, e.g. https://firezone.example.com/auth/oidc/google for OIDC or https://firezone.example.com/auth/identity for local email/password. Those URLs shouldn't change.
I'm not sure there's a good way to do this now without too much added complexity. We can revisit when #1123 is underway.


Add hopla hatch command - normal pets

Cli:
hopla hatch {egg_name} {potion_name}

split off: https://github.com/melvio/hopla/issues/170


made ath check optional, only if ath claim is provided in DPoP token

this is because the ath claim is a recent addition and the solid client libraries haven't caught up yet
also updated the specification links to the correct version, at time of writing the code.

Closing, as @Potherca made a simpler solution by just skipping the ath check for now


[Google Translate] ... Receiving error almost every time I use

Extension
https://www.raycast.com/gebeto/translate
Description

Error:
TypeError: Cannot read properties of null (reading '1')
Url: https://translate.google.com/_/TranslateWebserverUi/data/batchexecute?rpcids=MkEWBc&f.sid=-1835010324077553587&bl=boq_translate-webserver_20230517.08_p0&hl=en-US&soc-app=1&soc-platform=1&soc-device=1&_reqid=5027&rt=c

index.js:90:21
async b0:translate-form.js:28:11660

Steps To Reproduce
Error occurs when translating from French to English. Using the most recent version of Mac OS X on MacBook Pro 14-inch, 2021, Apple M1 Pro
Current Behaviour
No response
Expected Behaviour
No response

Fix is in progress, soon it will be fixed

https://github.com/raycast/extensions/pull/6666


Melhoria de mensagens de logs

Codecov Report

Merging #4 (299826c) into master (5d927be) will decrease coverage by 4.27%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   79.45%   75.17%   -4.28%
==========================================
  Files          11       12       +1
  Lines         404      427      +23
==========================================
  Hits          321      321
- Misses         83      106      +23

Flag
Coverage Δ

unittests
75.17% <0.00%> (-4.28%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

dbaas_base_provider/log.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d927be...299826c. Read the comment docs.

Hello @djoker! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tests/test_log/test_log.py:

Line 9:22: E231 missing whitespace after ','
Line 11:27: W291 trailing whitespace
Line 14:1: W293 blank line contains whitespace
Line 15:36: E231 missing whitespace after ','
Line 16:36: E231 missing whitespace after ','


Optimized siren endpoint

fix #92
Search on large siren (552081317 : 4000 results) was 16000 ms on local machine (3000 on server). Is now 100 ms on local machine.

Note : This version implies that all not siege sirets have is_siege='0' and all siege sirets have is_siege='1' but some tests indicates this is the case


chore(Dependencies) : update zio, zio-streams from 1.0.18 to 2.0.16

About this PR
📦 Updates

dev.zio:zio
dev.zio:zio-streams

from 1.0.18 to 2.0.16 ⚠
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Superseded by #650.


git-annex: add datalad/git-annex:release method

If I got it right we have

datalad/git-annex -- most recent (could be daily snapshot) build
datalad/git-annex:tested -- as above but the one which passed tests
so there is no way to install the most recent one (or that version if specified) from https://github.com/datalad/git-annex/releases as now should be 10.20220322.

Might be handy to be used in datalad testing instead of snapshot which has odd versioning (see https://git-annex.branchable.com/forum/standalone_tarballs_for_specific_versions/#comment-d15b771fb5d23ce0c8dfb7f1c25064c5)

@yarikoptic If the latest release lacks artifacts for the OS (as the current one does), should the script error or fall back to the most recent release that does have artifacts?


Fix for custom histories

Currently the EventListeners get added on import, which breaks custom histories which have to add them first.
getCurrentUrl would always get the previous url from the custom history
This is the fix we had to apply to get it to work like it should

Sweeeet I was going this would turn out to be a PR ;)

#118 includes this, should I close it?

If you're cool with that then I'd say yes ❤

I worked on both, I don't mind


Phpcs coding style symfony3

Migrate phpcs standard to symfony 3

I am extremely happy that the number of spaces between things is now consistent. I cannot tell everybody how much this issue has been troubling me...
Looks good mate, just merge it.


Another attempt at removing gopkg.in dependency

As discussed before, this would mean that we would have to maintain a separate master branch with pure-github package references and this would be the new master branch.

I guess you don't want to actually merge this to v5 branch?

this would be the new master branch.

Can you please elaborate? We can't just create master branch, because that would mean that you can only use latest version (master)...

Probably the easiest way forward is to just release v6 without gopkg.in...

No, I don't want to merge it into v5, there is just no other way to create a PR and raise your awareness.
Releasing a v6 is certainly an option. I - personally - am not sure how useful gopkg now is, in the era of vendoring (since Go1.5) but using it was your conscious decision so I don't want to "bully" you into dropping it :)

Okay, let's create branch v6 without gopkg.in. But I'd like to have some time to check if there are any breaking changes queued for v6 before tagging v6.0.0 release...

Closing, there is master branch with this changes.


Re-attempt at deploying Jekyll blog via Travis & Heroku

Changed Jekyll build commands to run on the Travis before_deploy lifecycle hook
Added --source flag so Jekyll outputs the correct files relative to where the Jekyll build command is run (/blog/bin)
Removed leftover initializer and rake task files from the previous Rails Jekyll blog- these were causing build errors during the Heroku deployment "rake assets:precompile" step

#624

Nice job, I know how bitchy Heroku can be for deploys. One of my discoveries was to put all devDependencies into dependencies. This was on an unrelated matter based on the MEAN Stack.
:rocket:


Next Steps

Hey! After finishing the steps included in the tutorial, how do you make sure its up and running correctly? is there a file you have to run, or do you just leave it and let it do its job? thanks!

If you've read the Getting Started section of the README it should be quite evident what you need to do.

@Katvios has the right suggestion. maybe could have been worded friendlier 😄 , but basically let the bot do its thing as suggested in the guide.


Pasting html table will create table inside slate/text block

Describe the bug
Pasting a html table from another website will not a new table block. Instead the block will stay text block with a table inside. This leads to the block not haveing the proper table sidebar
It used to work at least in some cases in older plone versions (15..).
To Reproduce
Steps to reproduce the behavior:

Go to https://6.demo.plone.org/add?type=Document
Paste the html table from https://en.wikipedia.org/wiki/Plone_(software)
-> It will not create proper table block

Expected behavior
It should create a new table block instead of table in slate block
Screenshots

Software (please complete the following information):

OS: Ubuntu 20.04.5 LTS
Browser: Firefox, Chrome
Volto 16.0.0-alpha.30
Plone 6.0.0b1
plone.restapi 8.25.1

Hey, @tiberiuichim @razvanMiu could one of you take a look?


Tasks (and TaskExecutions) are not === in the onDid(Start|End)Task callbacks.

VSCode Version: 1.44.2
OS Version: macOS 10.5.4

Steps to Reproduce:

Create a new extension using yo code.
Add the following to the 'activate' function body:

	let disposable = vscode.commands.registerCommand('extension.helloWorld', async () => {
		let echoTask = new vscode.Task({type: "taskbug"}, vscode.TaskScope.Workspace, 'echo', 'taskbug', new vscode.ProcessExecution('/bin/echo', ['hello world']));

		const echoTaskExecution = await vscode.tasks.executeTask(echoTask);

		vscode.tasks.onDidStartTaskProcess(e => {
			if (e.execution === echoTaskExecution) {
				console.log(`Detected that my task started with pid ${e.processId}`);
			} else if (e.execution.task === echoTask) {
				console.log(`Detected that my task started with pid ${e.processId}`);
			}
		});

		vscode.tasks.onDidEndTaskProcess(e => {
			if (e.execution === echoTaskExecution) {
				console.log(`Detected that my task exited with exit code ${e.exitCode}`);
			} else if (e.execution.task === echoTask) {
				console.log(`Detected that my task exited with exit code ${e.exitCode}`);
			}
		});
	});

Run debug the extension and run the 'Hello World' command.

If you break inside the onDidStartTaskProcess and onDidEndTaskProcess that comparison fail, which means its difficult to determine when the task starts or ends.
It's worth noting that in VSCode 1.43 the above comparisons both work, but in 1.44 this is not working.

Does this issue occur when all extensions are disabled?: Yes

I also checked Insiders for 1.45 and it also fails to compare the Task and TaskExecution objects in onDid(Start|End)TaskProcess callbacks.

Related bug for TaskExecutions being comparable https://github.com/microsoft/vscode/issues/47465

This bug actually completely broke our extension. Is the milestone to fix this still May 2020? This is very blocking, especially since otherwise there is no way to wait for a task to be done and then do something with the result of that task.

@ThadHouse There is a dirty workaround via vscode.tasks.onDidEndTask, see here:
https://stackoverflow.com/a/61703141/412240

@ashgti and @ThadHouse I have pushed a fix that solves the task executions not being equal. If you can, please install the insiders build tomorrow and verify that the issue you were seeing is resolved. If you still see a problem with the next insiders build, please let me know as soon as possible so I can have time to fix it before the next release.

Works for me! Thanks!

Added an API test.

After moving some code around in my extension, i'm seeing the race condition again. I've added some details to https://github.com/microsoft/vscode/issues/98080


Add support for Java 8 constants

Created from patch provided by @iloveeclipse, but only with significant
changes.

Great that this is merged!
How does the new artifact get into Maven Central? Should the issue also be closed?

It seems that it is not clear, who is maintaining the maven artifact, as it is not the author of jdepend. I would appreciate it too if somebody could create a release on maven central.
Btw. the version number in build.xml would have to be adjusted before.

Btw, there's a fork from @nidi3 available on Maven Central that includes various fixes: https://github.com/nidi3/jdepend
    <dependency>
      <groupId>guru.nidi</groupId>
      <artifactId>jdepend</artifactId>
      <version>2.9.5</version>
    </dependency>

Any progress on a new release?

use the force / fork ;)


cifar10 training

i trained my cifar10 based on your notebook file and cifar10.py to read. but batch accuracy only 10% with any cnn architectures and data augmentation or not (with 100000 iterations). do you know what happened? thanks!

Obviously I cannot know what happened from the 2 lines you wrote here. You can try posting your code on StackOverflow and see if anyone can help you there.


I would not have expected that toggle the comment state will change the setting file

Testing #2931

collapse all comments
observe: the user setting for githubPullRequests.commentExpandState changes to collapseAll

IMO the button should behave more like expand / collapse all in the explorer than auto save. I would have never expected that pressing the button changes a setting and makes this 'survive' a reload. IMO the setting should be used when we open VS Code but then for example collapsing all should not be remembered. But this is my take.

I can see how it would be confusing. I will update it to not write the setting.

I've been thinking about this some more, and I'm again leaning towards keeping the current behavior where the setting is changed. We persist UI state across reloads in many places (open editors, collapsed views, panel state, etc.), and this is just another UI state that will be persisted.

I am not arguing against persisting the UI state across reloads but to my knowledge the UI state is persisted per workspace. This setting is a user setting and might be synced to even other machines. So clicking a minus button in the UI has a far higher impact than I would have expected.

Here's what I landed on:

The Toggle command has been removed in favor of a Collapse command and an Expand command
The setting is no longer changed when you run the Expand/Collapse commands or the use the action on the comment widget.
The action on the comment widget is always "Collapse All Comments".


Feature/msbuild target framework

This is entirely untested!

This is entirely untested!

I don't know how to fix errors like this – that's why I went with Buildalyzer in the first place.
Amazon Lambda Tools for .NET Core applications (5.1.4)
Project Home: https://github.com/aws/aws-extensions-for-dotnet-cli, https://github.com/aws/aws-lambda-dotnet

Unknown error executing command: Could not load file or assembly 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

   at Amazon.Common.DotNetCli.Tools.Utilities.LookupTargetFrameworkFromProjectFile(String projectLocation)
   at Amazon.Lambda.Tools.Commands.PackageCommand.PerformActionAsync() in /Users/cosborn/Projects/slang/src/Amazon.Lambda.Tools/Commands/PackageCommand.cs:line 196
   at Amazon.Common.DotNetCli.Tools.Commands.BaseCommand`1.ExecuteAsync() in /Users/cosborn/Projects/slang/src/Amazon.Common.DotNetCli.Tools/Commands/BaseCommand.cs:line 46

Same error for the unit tests.

Ah, got it. The initialization was only added to the EB entry point, not Lambda nor unit tests. I'll continue working on this, thanks!

@slang25 I made the changes back upstream. Please do let me know what you think.


Add default pagesize to client

Set the default page size to 10. The client was sending a pagesize of 0 by default. Close #1362

Development on the client happening here.


(PUP-12076) Fix windows password compliance issue

Windows FIPS 2016 requires that the tests in acceptance/tests/resource/service/windows.rb should have passwords with a special character and a numeric character.

All windows platforms run the test in question and all of them pass the ad-hoc pipeline:
https://jenkins-platform.delivery.puppetlabs.net/view/puppet-agent/view/ad-hoc/job/platform_puppet-agent-extra_puppet-agent-integration-suite_adhoc-ad_hoc/1402/


Do not consider empty documents when parsing YAMLs

Is your feature request related to a problem? Please describe.
Some external manifest files might have empty documents, see e.g. https://github.com/glasskube/packages/pull/155. The repo client tries to parse them to unstructured objects, but fails because mandatory fields are missing.
Describe the solution you'd like
Ignore empty documents.
Additional context
This blocks https://github.com/glasskube/packages/pull/155.

Some clarification: I think parsing the emtpy document doesn't fail, but when we try to apply this "empty" unstructured.Unstructured instance there is an error.
I think something like this should work:
if len(object.Object) == 0 {
	// object is empty ...
}

can I take it?

@aminsaedi yeah just assigned it to you


Wrap text around image with an irregular paragraph shape

Description
I want to wrap text around an image and make the text closely surround the image with an irregular paragraph shape, as shown in the picture below.

(copied from stackexchange)
In LaTeX this is achieved by \parshape, so I wonder if there is any plan to provide a similar API or other ways to typeset text with irregular shapes.
Use Case
Many books contain similar typesetting since many layout engines support this feature (InDesign, Word, etc.).

(copied from stackexchange)

Very important feature request for the future of typst, I think.
I think #553 was closed prematurely, as the discussion within expressed numerous ideas about a more flexible floating placement system, and what was implemented for 0.12, while great, didn't fully fulfill the needs expressed in the issue, even those precisely scoped by its title, like 3 column layouts with 2 column span floating elements, a very common layout in magazines, newsletters and such.
The more flexible text placement required by this issue would perhaps allow for an easier implementation of the ideas expressed in #553.
The FOSS page layout design software Scribus already does this kind of text placement and its source code could be an inspiration for a typst implementation.

Wrapping text around shapes is definitely planned.
Regarding #553: I think it was the right decision to close it because it was the canonical issue for two column figures and that's what most of the >150 people that upvoted it wanted.
Yes, there were more requests in that issue, but it was not actionable as one work item. These other things are better served with separate issues like this one here.


CLOUDSTACK-8197 create MinVRVersion config item

move is complete. testing isn't and is invited as not all possible use-cases are clear yet

Looks good, let's wait for Travis build result.

Should we also raise another defect to fix this properly as outlined by you here?  http://markmail.org/message/cr4bfzvl6eyfisb5


improvements for build seed project example on windows

Thanks for your contribution, but as a sample docfx documentation project, I think there is no need to add something like build script...

OK. I will take this offline.


Android: Fix avatar not visible

Since RN v46, support for nested views inside Image component has been dropped and instead new component ImageBackground has been exposed for this use case.
https://github.com/facebook/react-native/commit/9637dd4a1b78d5f6da510b1b4ad10d45d67badbf

Good job!


Setup CI

Set up versioning and automatic build using appveyor, publish binaries under /releases page.

Looking forward, thanks!

@dnelson86 Ok, this should be setup now. First release here: https://github.com/masaeedu/win-sshfs/releases/tag/1.0.11


Laravel-Voyager: Not show relationship in Categories

Description
Not show relationship in Categories

Categories table

Create new Category

In list Category: not show parent name

We can't help you if we don't know what version you're using.  Please use the template in full.  Once you've updated the description, this issue can be reopened

Laravel: v5.7
Voyager: v1.1.10
PHP: 7.2
Database: MySql 5.7
Thanks you

We can't help you if we don't know what version you're using. Please use the template in full. Once you've updated the description, this issue can be reopened

This is version i used:
Laravel: v5.7
Voyager: v1.1.10
PHP: 7.2
Database: MySql 5.7
Thanks you @fletch3555 !

@cuongcx87, any particular reason you're building the relationship manually in the JSON details field?  I'm not sure that's supported since we've added https://docs.laravelvoyager.com/core-concepts/bread-builder#relationships

Closing due to inactivity.
Please use the "new" relationship functionality as posted above.

same problem here in 2020

This is for a much older version and likely a whole different problem.
If you think you found a bug please open a new issue.


Official support for Python 3.11 and Python 3.12?

AWS Lambda officially supports Python 3.11 and Python 3.12.
Would it be possible to test this library against those 2 new versions of Python?
From the setup.py it looks like there is no constraint preventing us from using it with runtimes higher than 3.10, however it's not tested.

The tests are failing in the Github actions because of 3.7 and the linting steps. I forked and added 3.11 and 3.12 to the test.yml, and commented out the previous two, and they passed.

Added explicit support to Python 3.13. 👍


CollectCosmosDiagnosticsForCancelledQuery

Issue:
For query operations, when configured with endToEndTimeout policy, if the operation is cancelled due to timeout, then the CosmosDiagnostics will be lost.
Fix:

Added cancelledRequestDiagnosticsTracker within CosmosQueryRequestOptions which will be used to track the cosmosDiagnostics for each cancelled request.
In Fetcher.java, populate cancelledRequestDiagnosticsTracker if a cancel signal is being captured and the request is not completed

TestResult:

Before the change:exception.getDiagnostics -> return null
After the cahnge:

API change check
API changes are not detected in this pull request.


The tutorial is broken due to a library error

This tutorial code sample is unfortunately broken, most likely due to a library error.
If I try to run a mvn clean package I get the following error.
2022-01-31 19:29:37.368  WARN 14380 --- [           main] o.s.w.c.s.GenericWebApplicationContext   : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.support.BeanDefinitionOverrideException: Invalid bean definition with name 'metaDataSourceAdvisor' defined in null: Cannot register bean definition [Root bean: class [org.springframework.security.access.intercept.aopalliance.MethodSecurityMetadataSourceAdvisor]; scope=; abstract=false; lazyInit=null; autowireMode=0; dependencyCheck=0; autowireCandidate=true; primary=false; factoryBeanName=null; factoryMethodName=null; initMethodName=null; destroyMethodName=null] for bean 'metaDataSourceAdvisor': There is already [Root bean: class [org.springframework.security.access.intercept.aopalliance.MethodSecurityMetadataSourceAdvisor]; scope=; abstract=false; lazyInit=null; autowireMode=0; dependencyCheck=0; autowireCandidate=true; primary=false; factoryBeanName=null; factoryMethodName=null; initMethodName=null; destroyMethodName=null] bound.

Basically, it looks like there is a duplicate bean definition somewhere. If I comment out the below dependency, then I am able to run mvn clean package and mvn spring-boot:run.
<dependency>
	<groupId>org.springframework.boot</groupId>
	<artifactId>spring-boot-starter-oauth2-client</artifactId>
</dependency>

However, if I do that, I (expectedly) get the default Spring Security login form page as below.

If I add spring.main.allow-bean-definition-overriding=true to my application.properties then I can build and deploy the application with the above dependency included. However, this is not specified in the tutorial.
This tutorial further does nothing with any Azure AD libraries in the source code. Consequently, there is no AAD authentication flow that ever is triggered.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3233e2cc-1075-1c20-d8f8-65161949e341
Version Independent ID: e3cef834-e81c-de56-9224-a22f7abdfb7e
Content: How to use the Spring Boot Starter for Azure Active Directory
Content Source: articles/java/spring-framework/configure-spring-boot-starter-java-app-with-azure-active-directory.md
Service: active-directory
GitHub Login: @KarlErickson
Microsoft Alias: brendm

Article has been updated since this issue was filed. Please file a new issue if there are still problems occurring.


Issues fetching source files.

I am in the process of migrating a project between two organization, and I'm hitting this error when pulling down source files.
I am able to pull down translations (using tx pull -a), and that works great, but when I try to pull down the the source files with tx pull -s, I get the error:
 Resource o:open-edx:p:edx-themes:r:themespo
 SUCCESS  Organization 'open-edx' fetched
 SUCCESS  Project 'edx-themes' fetched
Downloading source files
 SUCCESS  Resource themespo fetched
  ERROR   Downloading source file themes.po: directory '' does not exist
directory '' does not exist

Running with cli version 1.0.2 on macOS.

Hello @dianakhuang, thanks for bringing this to our attention!
We just released a new version v1.0.3 that should fix an assumption we made and resulted to this issue.
Please feel free to try it out and close the issue! Cheers!

@codegaze Thank you so much for your prompt response! It works great now.


[joss] Explanation of node indices in paper

This is feedback regarding the following paragraph in the paper:

A defining characteristic of retworkx graphs is that each node maps to a non-negative integer node index, and similarly, each edge maps to an edge index. Those indices uniquely determine nodes and edges in the graph. Moreover, the indices provide a clear separation between the underlying graph structure and the data associated with payloads

I don't quite understand what the last sentence is meant to communicate, can you clarify please?
And a suggestion regarding the description of indices:
To a reader who does not know retworkx, the statement that there are node indices is likely to seem redundant/uninteresting. Every single graph library I used, with the notable exception of NetworkX, had a well-defined ordering of nodes, and used the concept of node indices, i.e. the ith node in the node list.
In retworkx, however, "index" refers to something quite different from what is normally understood (i.e. an ordinal number). retworkx uses an integer ID that can have arbitrary values and is not related to the position of the node in the node order. This way, node IDs are stable upon node removal. If you can convey this information, that would improve the paper. The paragraph, as currently written, doesn't seem to communicate much.

On a related note, if I read about this, my first question would be: "This is a good way to uniquely identify nodes, but what about edges? How do we distinguish parallel edges?" It seems to me that not having a consistent way to refer to edges is one of the major shortcomings of the library. But this is well beyond what can be addressed during the review.

We addressed the comments on the paper, thanks for revieweing the paragraph. With regards to:

On a related note, if I read about this, my first question would be: "This is a good way to uniquely identify nodes, but what about edges? How do we distinguish parallel edges?" It seems to me that not having a consistent way to refer to edges is one of the major shortcomings of the library. But this is well beyond what can be addressed during the review.

I agree that distinguishing parallel edges out-of-the-box is not the strenght of retworkx. It all comes from a design decision and some technical limitations.
In NetworkX, multigraphs are represented by separate classes hence there are MultiGraph, MultiDiGraph along with the Graph and DiGraph classes. This allows NetworkX to store the key distinguishing edges for multigraphs. Because of Python is an interpreted language with duck typing, NetworkX methods can accept all the four classes without having to write additional code.
In retworkx, multigraphs are represented by the same classes that represent graphs with non-parallel edges: PyGraph and PyDiGraph. What differentiates a multigraph from the rest is that the attribute multigraph is set to true. This is more convenient for Rust development because Rust is statically typed, hence instead of having internal APIs for 4 types we only have APIs for 2 types (see API functions for PyGraph). The tradeoff is that the implementation for graphs with parallel edges is an extension of the implementation of graphs without parallel edges that did not have key to distinguish between edges.
However, there are some tricks that can help overcome this. For example, if you add edges following this pattern :
payload = {'weight': 1}
edge_index = graph.add_edge(node_a, node_b, payload)
graph.update_edge_by_index(edge_index, {**payload, 'index': edge_index} )

You are going to be able to distinguish between parallel edges in a WeightedEdgeList