Correct a typo in hook failure error message

(Thank you for a very useful package, and sorry for my pedantry!)

Thanks for correcting my horrible english :p

Thanks for correcting my horrible english :p


After connecting to clickhouse DB, both the "query" and "schedule" tabs seem disabled.

After connecting to clickhouse DB, both the "query" and "schedule" tabs seem disabled.

Can you please check the same from your end.
Originally posted by @tarzzz in https://github.com/plotly/falcon/pull/541#issuecomment-447388630

I found the same problem as mentioned above.

me to.


Screenshot support

Add command to capture screenshot from remote roku device.
Command: screenshot-and-save (specify location in user settings or roku-deploy.json)
Command: screenshot-to-clipboard

This has been implemented.


Safe erasure correctness

Partial proof of safe erasure correctness. There remain todos only for the case/proj on box optimizations.

This is for the erasure which is total and extracts a smaller environment with minimal dependencies.

I'll move away and finish the proofs that allow to build sets of kernel names before merging.

In the end, refactoring the Reflect files to avoid many duplication make template-coq depend on equations (for the EqDec class). I think that would simplify also other refactorings to allow this dependency, and I suspect most users rely on opam for programming with MetaCoq so it's not any harder to depend on Equations even if using only template-coq.

This would definitely simplify a lot of things! For one we could probably drop any dependency on Program.


Add hictk as a dependancy

Now allows cool/mcool as history inputs and converts to hic tracks with hictk
Track is a cool file output from the hicexplorer matrix builder:

Changes mostly black vs flake8 battle scars.

Installed and dependencies updated.


Galexie: enable resumabilty to be configurable

Need to capture some details on expected configuration. currently, the resumability feature has configurable cli toggle flag --resume true|false , with a default of being disabled, resume=false

No longer relevant


Add Hands-on ML book

I suggest adding my book to the list of TensorFlow books.  It covers everything from the Machine Learning basics using Scikit-Learn, to advanced Deep Learning topics (eg. Xavier/He initialization, batch normalization, data/model parallelism, RMS Prop, Adam optimization, the latest CNNs, RNNs, various Autoencoder architectures, Deep Q learning, and much more) using TensorFlow.  The code examples and exercise solutions are open sourced at https://github.com/ageron/handson-ml/.

Thanks @jtoy.


GH - 624: date_range() now supports a unit keyword "s" , "ms" , "us" , or "ns"

[ ] Closes #624
[x] Tests added: Please use assert_type() to assert the type of any return value

Still have issues with the pre-commit.   See https://github.com/pandas-dev/pandas-stubs/actions/runs/5312915959/jobs/9618117980?pr=734
There's another issue with respect to numpy 1.25.0 which we will have to investigate. For now, change the line in pyproject.toml to say numpy = "<=1.24.3" .

still have the pre-commit issue.
Also, there is a bug in pyright 1.1.314.  That will be fixed in 1.1.315 that is supposed to be released in a day or two.  In the meantime, you can change the line  pyright = ">= 1.1.310" to `pyright = "<= 1.1.313" .
See comment in https://github.com/pandas-dev/pandas-stubs/issues/729#issuecomment-1593309930

still have a failing pre-commit test.   See https://github.com/pandas-dev/pandas-stubs/actions/runs/5313940150/jobs/9621431339?pr=734
Please run pre-commit install in your environment and then do black pandas-stubs


bump: [#4684] Update applicationinsights dependency to version 2.x

Addresses # 4684
#minor
Description
This PR updates the applicationinsights package to version 2.9.6, the latest compatible version.
Upgrading to version 3.x will introduce breaking changes as it requires to initialize the instrumentation before the bot is executed ([issue](https ://github.com/microsoft/ApplicationInsights-node.js/issues/ 1375)).
Specific Changes

Updated applicationinsights from 1.7.5 to 2.9.6 in botbuilder-applicationinsights.
Updated applicationinsights from 1.7.5 to 2.9.6 in root's package.json file.

Testing
The following image shows the unit tests passing and the telemetry logged by a bot with the custom properties in place.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 84.997%

Totals

Change from base Build<PHONE_NUMBER>7:
-0.4%

Covered Lines:
20351

Relevant Lines:
22910

💛  - Coveralls


Update Manifest files to ship updated tests folder

What does this PR do?
Properly grafts the tests folder for all the checks that were still shipping test
Motivation
During the port of checks to pytest, it appears we missed a few and haven't been including the tests folder.
NOTE: The only two integrations left that ship test are: kubernetes and docker_daemon because they still have that directory.
Review checklist

[ ] PR has a meaningful title or PR has the no-changelog label attached
[ ] Feature or bugfix has tests
[ ] Git history is clean
[ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
[ ] If PR adds a configuration option, it has been added to the configuration file.

Additional Notes
Anything else we should know when reviewing?

Codecov Report

Merging #3068 into master will decrease coverage by 16.77%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3068       +/-   ##
===========================================
- Coverage   83.96%   67.19%   -16.78%
===========================================
  Files         642       30      -612
  Lines       36511     1463    -35048
  Branches     4311      207     -4104
===========================================
- Hits        30656      983    -29673
+ Misses       4594      397     -4197
+ Partials     1261       83     -1178

Very good catch!


WalletService misrepresents locally-managed address keys as watch-only addresses

When the WalletService requests getStoredAddresses, it incorrectly labels the addresses as a watch-only address.
Acceptance Criteria for this fix:

[x] Check that a WatchedScript is not accidentally re-added as a watch-only address on top of an already defined local key. (Fix proposal in https://github.com/OpenBazaar/multiwallet/pull/103)
[x] Migrate data which has been incorectly marked as WatchOnly (Fixed by https://github.com/OpenBazaar/multiwallet/pull/111)
[ ] A unit test asserting that AddWatchedScript should never add a script which already represents a key from the appropriate wallet. This may take some refactoring, but the idea would be that if the script represents a key returns in WalletService.km.GetKeys(), that it should never be indicated as watch-only.

@rodkeys we mentioned having this second checkbox item as part of the fix. Do you mind taking a look at incorporating that as well?
A unit test asserting that AddWatchedScript should never add a script which already represents a key from the appropriate wallet. This may take some refactoring, but the idea would be that if the script represents a key returns in WalletService.km.GetKeys(), that it should never be indicated as watch-only.

I'm cool with writing the unit test but I need a little direction

A unit test asserting that AddWatchedScript should never add a script which already represents a key from the appropriate wallet. This may take some refactoring, but the idea would be that if the script represents a key returns in WalletService.km.GetKeys(), that it should never be indicated as watch-only.

I'm asked to write a unit test to make sure that this won't happen but AFAICT there's currently nothing stopping this from happening in the code.
Chris' fix (https://github.com/OpenBazaar/multiwallet/pull/103/commits/ac178e7c483d2f9be684f04f2d951b5e95a0c8cc)  ignored WatchedScripts that correspond to already-existing keys, but it did not stop them from being added to the db.
Am I supposed to add a check in the code for WatchedScripts corresponding to existing keys and then write a unit test after that?

I don't know if it's worth making sure they;'re not added to the db. I suppose either way is OK.

I'm asked to write a unit test to make sure that this won't happen but AFAICT there's currently nothing stopping this from happening in the code.

Yes, there's nothing preventing this from happening. I was implying that we'd add it by writing the unit test (and making it pass). (Red-Green testing)
Create the scenario that we know will fail, then improve the Put to check the input isn't already part of  existing Keys(), then add it.

Attn: There's the bit of trying to share the KeyManager state with the Put request. Please keep those as orthogonal as possible.

I don't know if it's worth making sure they;'re not added to the db. I suppose either way is OK.

Yeah for now it's definitely not critical for getting this release ready.

Yes, there's nothing preventing this from happening. I was implying that we'd add it by writing the unit test (and making it pass). (Red-Green testing)
Create the scenario that we know will fail, then improve the Put to check the input isn't already part of existing Keys(), then add it.

Got it, thanks for the clarification.


ship cant submerge

I have watched the video and built exactly the same ship in the video and the submerge option just says "cant submerse" how would I fix this

Post your issue again, but this time follow the Contribution Guidelines.


Builder maintenance routine

Need to set up a maintenance routine/mechanism

Timed out jobs often don't collect their jobs. We need to pause the builder queue and then killall xcodebuild and killall swift-build
Docker jobs can also stick around:

spi@spi-dev ~> dpsa
NAMES                          STATUS              IMAGE
serene_perlman                 Up 5 hours          swift:4.2.4
spi_analyze_1                  Up 15 hours         registry.gitlab.com/finestructure/swiftpackageindex:2.0.0
spi_reconcile_1                Up 15 hours         registry.gitlab.com/finestructure/swiftpackageindex:2.0.0
spi_trigger_builds_1           Up 15 hours         registry.gitlab.com/finestructure/swiftpackageindex:2.0.0

This can probably be automated (but we'd need to name the jobs) to kill anthing older than 1.5h that isn't the infra

FWIW, the last few days have been free of zombie jobs. I think the downscaling helps in general, although there was a case of dev panicking even with downscaling in effect and the runner count reduced.
Right now I don't see of any further automation (just regular checking). Will keep this open a few days longer as a reminder to report observations.

Another staging panic (which required to login the builder account for it to pick up builds after the reboot) and a stuck docker job. The docker jobs in particular seem to be sucking a lot of performance out of machines where they happen.

It probably makes sense to check for the following every few days (at least twice a week):

excess load when there are no jobs running
docker ps -a to check for any jobs that aren't spi_* and running for longer than 1h
builder accounts being logged in (which isn't automatic on dev + prod) - i.e. just ensure that dev hasn't crashed and rebooted into the spi account only *)

*) On that note, perhaps we should default booting into the builder account instead of spi. Operationally, that's the more important one. Also, we'll automatically be notified about staging and can correct that easily when it happens. That's better than the silent failure.

Rather than change the default user, I wonder if we should just regularly run a script that checks who for the builder account being logged in, sending us an email (or some kind of notification) if it's not?

Mmm, that feels like it's quite a bit more complicated, mainly because we'd need to configure some sort of authentication to use an SMTP server.

I've set up a reminder to check the machines at least twice a week. I think that's the extent we can automate this to. Still think it'd be helpful to set dev to auto-login to builder to make it recover after a reboot but that's a detail. (Just to be clear: this was for dev only. prod doesn't really have crashing issues and of course we wouldn't want to risk the downtime there.)

I wonder if dev is the only machine that still has crashing issues on a regular basis whether we should look into those in a bit more detail? I wonder if further reducing the number of builders on that machine might help?
Manual ops tasks like this aren't great, of course, and I'm not super happy that they're falling to you by default either.
I wonder if it might be worth a conversation with MacStadium to see if we could sneak in one more machine with a spec similar to the prod machine that could take all of our Intel build tasks now that the backlog is done. That could be configured to boot into the builder user by default, as that'd be the only user with any kind of responsibility on that box.

dev crashed again earlier this morning (around 13:00 CET)

Also, I've been unable to connect to prod via Screens for a couple of days now. It's working fine otherwise - is processing jobs and handling requests and I'm able to connect via ssh. Just VNC isn't working :shrug:.

Yea I tried to connect to prod yesterday too and had the same. I checked everything was working ok, and was going to mention it to you. I guess it needs a reboot.


Add support for minimized attributes in TagHelpers.

Updated the Razor parser to understand minimized attributes instead of just treating them like plain text. This just involved encompassing minimized attributes in their own blocks just like the other attributes found on the HTML tag.
Updated TagHelperParseTreeRewriter to only accept minimized attributes for unbound attributes.
Updated IReadOnlyTagHelperAttribute/TagHelperAttribute to have a Minimized property to indicate that an attribute was minimized.
Updated parser level block structures to represent minimized attributes as null syntax tree nodes.
Updated chunk level structures to represent minimized attributes as null chunks.
Added parse level rewriting tests to validate new TagHelper rewritten structures for minimized attributes.
Updated existing parser tests to understand minimized attributes.
Added codegen test to validate understanding of minimized attributes.
Added TagHelperExecutionContext tests to validate maintaining of runtime TagHelperOutput tests.
Refactored part of the TagHelperParseTreeRewriterTest file into a base class file so we can make better rewriting tests.

#220

/cc @pranavkm or @dougbu

Updated TagHelperParseTreeRewriter to only accept minimized attributes for unbound attributes.

why aren't minimized attributes handled?  bound and unbound attributes use the same TagHelperAttribute class.
bound value of a string property named propertyName with a corresponding minimized attribute in Razor source is propertyName.  bound value of a bool or bool? property with a corresponding minimized attribute in Razor source is true.  any other property type is an error.
so far, this seems like #220 part 1 of at least 2.

@dougbu https://github.com/aspnet/Razor/issues/220#issuecomment-74000770

@dougbu https://github.com/aspnet/Razor/issues/220#issuecomment-74000770

ok though I don't see anything like an understandable / helpful error message if a user writes <form asp-anti-forgery >....  what exactly happens in that case from a Razor author perspective?  where is the error case tested?

:watch:

In response to https://github.com/aspnet/Razor/pull/372#issuecomment-98272605 : tons of validating tests in the TagHelperBlockRewriterTest.cs file. Razor author sees:
Attribute 'asp-anti-forgerery' on tag helper element 'form' requires a value. Tag helper bound attributes of type 'System.Boolean' cannot be empty or contain only whitespace.

@NTaylorMullen, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Updated.

Updated.

:watch: for less tests to wade through

Updated. Addressed all except https://github.com/aspnet/Razor/pull/372#discussion_r30013889

:watch:

Updated.

This has been open too long, Will get this in tomorrow afternoon and if more comments come in I will address them.

:shipit: after addressing the few remaining comments


Broken after uprgade to mattermost 3.1

It seems that the matterbridge it broken after the upgrade to Mattermost 3.1:
Receiving (from IRC) works. But sending out from MM to IRC causes the following error:
Jun 23 14:12:19 ???? matterbridge[????]: 2016/06/23 14:12:19 schema: invalid path "post_id"

Thanks for reporting. Fixed in v0.4.2


Incorrect error message on internal contract failure

When contract fails internally due to panic the following error message is returned:
Error:  ActionError: The used access key requires exactly one FunctionCall action

To reproduce try running any contract from the shell but pass wrong argument name.

Duplicate: https://github.com/near/near-shell/issues/276


Add correct hashbang executon and handling for various languages

Back in the beginning of time there was an issue dealing with the way powershell handles (executable) script files, most often seen in anything made in a native *nix environment. The idea is to be able to run hashbanged scripts from pwsh.
Q: What is a hashbanged script?
A: Pretty much any script starting with something like:
#!/usr/bin/env python3
# mypyscript -- This is any random python coded script executable from command line
print('Don't let hashbang issues disappear like teardrops in the sea!')
...

Yes, so you noticed this hashbang is not for windows. Well, yes a no. It is correct for WSL, but powershell doesn't understand it for the obvious reason, it is supposed to be path. However, if Windows powershell would like to maintain any compatibility with any future script handling, pwsh developers need to rethink this "path": /usr/bin/env and handle it as a virtual path like any of the other special windows paths.
Two things for sure.

It should not, under any circumstances, change what's in the original code.
Windows/Powershll dev's should not start putting their own Windows paths there.
(Instead consider removing the path altogether, by using just the interpreter's name, like #!python3, but maintaining full compatibility with the 20+ year /usr/bin/env and /bin/<interpreter> formats.

Steps to reproduce
./mypyscript

# doesn't work

Expected behavior
./mypyscript

Don't let hashbang issues disappear like teardrops in the sea!

We should be able to dot-execute any scripted code from powershell command line, when that code contain the correct hashbang for the scripting engine. (Eg. .ps1 .py .go .js etc.)
Actual behavior

Doesn't work:
Opens a window dialog, asking what you want to use to open this file.

A secondary issue, is that:
some installers actually modify the original code's first hashbang line.
This should never be allowed to happen!

A longer and far more technical and detailed discussion of this, was made in this issue:

https://github.com/PowerShell/PowerShell/issues/9430

But it's title is perhaps not ideal, to make it a very relevant issue, although it is the essence.
(Issue pertains to handling of . (dot) in the $env:PATHEXT. )
Furthermore there was an honest attempt by @mklement0 to provide a CMD-based work-around
as discussed in this SO question:

https://stackoverflow.com/questions/55601446/how-to-run-a-python-program-from-powershell-based-on-python-hashbang

IIRC shebangs/hashbangs are really handled in the kernel and not the shell and the Win32 subsystem on the NT kernel doesn't have a concept of shebangs. For non-executable files, Windows really uses the extension of the file to determine what program to use to open the file itself so when you do ./mypyscript with a shebang of #!/usr/bin/env python3 Windows has no idea what to do with it. Even trying to add support for interpreting Unix shebangs will be fraught with danger and IMO too magical, using #!/usr/bin/env python3 as an example:

On Windows Python is just installed with python.exe so there will be no python3.exe in the PATH
Even if there was, what Python 3 interpreter will be used if there are multiple present
If it was also just #!/usr/bin/python3 then it's the same issue, probably even more so because it's a hardcoded path and on Unix it won't rely on the PATH

Personally I think this would require too much magic and maintenance to achieve.

@eabase, while I like the idea in principle, I think @jborean93 is correct - we can't just do this automatically.
What may be worth considering is to propose a PowerShell-specific feature: something along the lines of a dedicated new filename extension, say .psx, with perhaps a custom shebang-line format that covers all platforms, and that PowerShell (only) would allow you to call without the filename extension even on Unix-like platforms.
On Unix-like platforms, for security reasons, the executable bit would have to be set too.
If this sounds interesting to you, I encourage you to open a new feature request and flesh this idea out (though I can't guarantee that others may find it interesting / unproblematic).

@mklement0

What may be worth considering is to propose a PowerShell-specific feature: something along the lines of a dedicated new filename extension, say .psx, with perhaps a custom shebang-line format that covers all platforms, and that PowerShell (only) would allow you to call without the filename extension even on Unix-like platforms.

I don't quite understand what you mean there. Are you proposing to handle files with a new extension like, myscript.psx or are you proposing a hashbang, like #!/usr/bin/enx psx?
I think maybe you're proposing the former, but regardless, from a portability perspective, I disagree with both. The whole point here, being that we should be able to execute any script (regardless platform) using the dot method.

On Unix-like platforms, for security reasons, the executable bit would have to be set too.

Yes, that is also needed, but I have no Widows experience for this, as all my Windows machines are completely permission free. The very first thing I do on any vanilla Windows machine is to turn off UAC, and enable Admin on all my shells by default. As a non-corporate sysop, I just find my life unbearable having those (sorry, but rather useless) productivity blocking features on. So until the day that windows group/file/execute policy/permissions become a one-click operation, that is how I will continue to operate. And in those few cases I have ran into file ownership trouble, Cygwin has come to the rescue and been my best friend for the last 20 years!
-- So yes, latest development Windows 10 version, always has Cygwin installed! (And no, WSL will never replace the lightness of Cygwin with all it's bloated VM features and gigabyte installs.)

If this sounds interesting to you, I encourage you to open a new feature request and flesh this idea out (though I can't guarantee that others may find it interesting / unproblematic).

I think the hacks presented in the linked SO post will have to do for now.

Are you proposing to handle files with a new extension like, myscript.psx?

Yes.

Windows machine is to turn off UAC, and enable Admin on all my shells by default.

Understood, but just to spell it out: You're choosing to bypass the platform's security features.
It is the equivalent of running all scripts on Unix with sudo / as root.

The whole point here, being that we should be able to execute any script (regardless platform) using the dot method.

Cross-platform abstractions are a wonderful thing, and I welcome them in general.
It is why I created the hack in the linked SO post, but it is just that: a hack.
Here, the only safe and predictable way forward is to create an abstraction in the realm of PowerShell, hence my suggestion.
The alternative on Windows is to stay in the realm of WSL and install PowerShell there - but that's not a true cross-platform solution.
However, you'll even be able to execute shebang-based scripts stored in the Windows file-system, as long as these script use LF-only newlines rather than Windows CRLF ones (WSL2 seemingly implicitly considers all Windows file-system files executable).

A terminology caveat:

dot-execute

This sounds like dot-sourcing, which is entirely unrelated to the issue at hand.
It is a general requirement in PowerShell, for security reasons, to explicitly signal the intent to invoke executables located in the current directory, using a path, which in the simplest case means prefixing the file name with .\ or ./.

Instead consider removing the path altogether, by using just the interpreter's name, like #!python3

Note that this is tantamount to calling for a PowerShell-specific abstraction, given that Unix shebang lines require full paths - and breaking the native shells on Unix-like platforms - which rely on the kernel's interpretation of the shebang lines, which would then fail - is ill-advised.

This sounds like dot-sourcing, which is entirely unrelated to the issue at hand.

Not sure what you're saying here, but I mean that with proper shebang behavior, you can execute the script with same method as in Powershell, with ./myscript.py, in the current scope, and without additional source dot in front. AFACT, this is how *nix behaves.

Note that this is tantamount to calling for a PowerShell-specific abstraction, given that Unix shebang lines require full paths - and breaking the native shells on Unix-like platforms - which rely on the kernel's interpretation of the shebang lines, which would then fail - is ill-advised.

Yes, Indeed. I didn't really like that, but it was not my idea, it was mentioned as a comment by Eryk Sun in that SO link.

Not sure what you're saying here

This was primarily a terminology quibble: we're talking about regular PowerShell invocation of external executables here, nothing to do with "dots", which makes people think of dot-sourcing, which is limited to in-process execution of PowerShell code directly in the caller's scope instead of a child scope.

in the current scope

Shebang-based scripts invariably run in a child process, the concept of a PowerShell scope therefore doesn't apply.

Here's how I could potentially see this happen without introducing new PowerShell constructs such as .psx, relying on PowerShell to directly act on Unix shebang lines (and note that I'm just a fellow PowerShell user, these are just my thoughts):

For backward compatibility and security reasons, an opt-in would be required:

The hack in the SO answer implicitly uses such an opt-in, by requiring . to be added to $env:PATHEXT in order to mark extension-less files as executable; however, given that the interpretation of such files would be PowerShell-specific, it's better not to modify an environment variable that other shells such as cmd.exe would see too, and instead use a PowerShell preference variable.

The security challenge there is that either way this would be a global switch, unlike in the Unix world, where each shebang-line-based script must individually have executable permission bit(s) set.

Conceivably, NTFS alternate data streams could be used, they way they are for blocking scripts downloaded from the internet, but that sounds obscure and cumbersome.

For security and predictability reasons, only #!/usr/bin/env <utility> would be supported - not also direct paths such as /usr/bin/python - and PowerShell would interpret that as having to look for <utility> in $env:PATH.

The upshot is that any cross-platform shebang-based scripts would have to be created using the form #!/usr/bin/env <utility>

I'm no security expert, so others will have to weigh in whether a global opt-in is acceptable or not.

Just for reference, this is what the Python3.8 Docs says about shebang:

To allow shebang lines in Python scripts to be portable between Unix and Windows, this launcher supports a number of ‘virtual’ commands to specify which interpreter to use. The supported virtual commands are:

/usr/bin/env python
/usr/bin/python
/usr/local/bin/python
python

and ...

For example, a shebang line of #!python has no version qualifier, while #!python3 has a version qualifier which specifies only a major version.
If no version qualifiers are found in a command, the environment variable PY_PYTHON can be set to specify the default version qualifier. If it is not set, the default is “3”. The variable can specify any value that may be passed on the command line, such as “3”, “3.7”, “3.7-32” or “3.7-64”. (Note that the “-64” option is only available with the launcher included with Python 3.7 or newer.)

Interesting, @eabase; didn't know about Python's shebang support.
Two observations:

Since Python is not a shell, it still relies on the underlying shell for invocation of scripts, which means that scripts have to have the .py extension in order to be executable (hacks aside) - something we would want to avoid.

Overlaying Windows-only functionality on a Unix concept - e.g. #!python3 and version/bit-ness specifiers - strikes me as ill-advised.

/usr/bin/env <binary> is unequivocally an expression of the intent to defer to $env:PATH to locate the binary.

/usr/bin/ <binary> (Linux) and /usr/local/bin/ <binary> (macOS) are defensibly so, though they aren't strictly, given that it is possible to preempt these locations in $env:PATH. Still, overall it makes sense to me to also defer to $env:PATH.

All others paths I still recommend not be supported, because there's no sensible guessing as to the intent, and with something like /bin/sh - signaling the intent to use the platform's default shell - there is no analog on Windows, and executing an arbitrary sh.exe somewhere in the path could be considered a security risk.

To flesh out the need for an opt-in: Without it, at least hypothetically, things may start executing that didn't execute before:

If you have a currently dormant extension-less shebang script somewhere in $env:PATH, calling it by file name only will start executing it - even if an *.exe file or file with any other extension listed in $env:PATHEXT with the same base name is also present.

Note: if there isn't a true executable with the same base name also present, you already do get execution of sorts: such a file is unexpectedly opened as a document, which I consider a bug that should be addressed separately - see #12632.

Similarly, if both a shebang script foo and foo.ps1 are present in the current directory, ./foo will then start executing foo, given that its file name is an exact match (this is how it already works on Unix).

@mklement0
I agree on all part in section A and B, as for the last section C, I don't have anything to add.
Perhaps we need to get someone into this thread, that doesn't agree and may have some sensible counter arguments?

@eabase, my recommendation is to open a new issue, of type "Feature Request/Idea", and to make a focused case based on our shared understanding, leaving the security / opt-in issue as an open question, soliciting feedback.


Fix flaky UJS integration test

Copule of changes:

Ensure that the UJS response is completed before asserting that no Turbo request was issued.

The form test should assert that a turbo:frame-load was indeed fired. It passed some times, even if it was mistakenly asserting that the event didn't happen, because the check is asynchronous so it could happen before the event was captured.

@kevinmcconnell makes sense, I've updated the test decription and moved it to  src/tests/integration.


docs: Update CODEOWNERS

Description
This PR use team as codeowner
List of Changes
updated file
Motivation and Context
Operational Excellence Task

CVE scan not needed


getDOMNode() has been deprecated. Use React.findDOMNode() instead.

https://facebook.github.io/react/blog/2015/03/10/react-v0.13.html
https://facebook.github.io/react/docs/component-api.html#getdomnode

Afaik the deprecation has nothing to do with refs. getDOMNode is deprecated and removed from Component class only.

thanks @vasanthk, mind updating this to latest master?

@ryanflorence Updated it to the latest master. Does it look fine now?

https://github.com/rackt/react-router/blob/0d053e301b3ddfecad4683f1b4d07897e90c56e8/examples/master-detail/app.js#L124-L125

@krzysiek1507 Modified it too. Thanks :)

Can you squash into a single commit please?

@gaearon Getting an 'error: could not apply' when I try to squash the commits. Wonder if few of my commits have become useless after a merge. Could you help me out with the squash?

@vasanthk
I usually do this:
git fetch upstream
git checkout mybranch
git merge upstream/master

# if necessary, resolve conflicts and git commit
# ...

git reset --soft upstream/master
git commit -am 'Some cool description for a single commit'
git push -f

@gaearon That worked. Thanks :+1:

:+1:


Support for yarn3 workspaces?

I'm encountering an issue while setting up frogbot in my project that utilizes yarn 3.6.1 with workspaces. It seems that the installation command provided in the frogbot configuration is not executing correctly.
Context:
Monorepo Structure:

frogbot-config.yml content:
- params:
    scan:
      projects:
        - installCommand: yarn // also tried: yarn install
          workingDirs:
            - packages/lib

Issue:
I'm encountering the following error:

It seems that frogbot is attempting to install dependencies with 'npm' despite specifying 'yarn' as the installation command in the configuration file.
Question:
Could it be that frogbot lacks support for yarn3 workspaces, or am I potentially setting up frogbot incorrectly?
I appreciate any insights or assistance you can provide on this matter. Thank you in advance for your help!

Hi @Feinminen ,
Frogbot indeed lacks support for yarn workspaces.
In addition, there is another problem in the way you configured your frogbot-config.yml: you set workingDirs param to packages/lib, which is not a yarn sub-project, but an npm project. if you want this sub-folder to be scanned as a yarn project, it should contain a yarn file. otherwise, frogbot will detect this sub-project as npm.
Another solution for you is to scan the entire project, and frogbot will use the yarn.lock file that already exists in your root directory.

Thanks for the clarification! I'm closing the question :)


Is it wrong here? It seems that the updated part should be gt.

Thanks for your nice reminder. We will revise this typo in the final version.

@Anthem0w0 Thanks for your nice reminder. We will revise this typo in the final version.

@Anthem0w0 We will revise this typo in the final version. Thanks for your kind reminder!


An extra block exists on Chicken Run in Community Games

Describe the bug
An extra block exists on Chicken Run in Community Games
Steps to reproduce the behavior
1.Navigate to https://arcade.makecode.com/beta
2.Community Games->Chicken Run->Open in Editor
Expect behavior
No extra block exists.
Actual behavior
An extra block exists on Chicken Run in Community Games

Additional context
OS: Windows(rs6)
arcade version: 0.18.4
Microsoft MakeCode version: 6.1.14

@KellyLuo1 Can you check if the behavior is same in live too?

@abchatra Yes, the same situation occurs in live.

Thanks @KellyLuo1 I am closing this. Even though it is valid bug, this is  a game developed by community member and it is ok to have disabled blocks.


Request: Change script order or allow for robust handling of duplicate emails

Our Admin would sometimes need to open another account for our users in AD and transfer their email address to the new account. The old account is then deactivated or given another email.
The sync script cannot transfer this to GitLab, as it first attempts to create new users and then update existing users. The first step fails, as the email for the new account is already taken by the existing account in GitLab. An update of existing accounts before this step would solve the issue. Alternatively, the script could handle duplicate emails in a more robust fashion and skip new account creation for duplicate emails without aborting execution and failing. These could then be created upon the script's second run.

It sounds very sensible to swap the order of these tasks, though there was a different problem raised when attempting to change their email address: https://github.com/Adambean/gitlab-ce-ldap-sync/issues/21


fix: reduce docker image size

What does this PR do?

Fixes #91
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

@G3root This needs a bit more work. We have an npm folder (from where we publish our npm package) with a package.json in there that also needs to be installed for this setup to work. The npm folder is imported locally as an npm package. Try building the Dockerfile locally and you'll see the errors.

@deepakprabhakara  i pushed some changes and it's working fine locally.

@G3root If you post a message on https://github.com/boxyhq/jackson/issues/91 I'll assign the issue to you as well

@G3root If you post a message on #91 I'll assign the issue to you as well

i just posted a message in that issue.

Looks good to me. The image size I got while testing is 384MB. Although one strange thing is that with the npm install sharp step added, the image size is even smaller 222MB (Not sure why).
@deepakprabhakara Thoughts ?

Looks good to me. The image size I got while testing is 384MB. Although one strange thing is that with the npm install sharp step added, the image size is even smaller 222MB (Not sure why).
@deepakprabhakara Thoughts ?

@niwsa What is the old image size? The npm install reducing the image size is very bizarre since docker images are layered.

@niwsa What is the old image size? The npm install reducing the image size is very bizarre since docker images are layered.

The current one is around 650MB.
➜ docker images boxyhq/jackson
REPOSITORY       TAG       IMAGE ID       CREATED      SIZE
boxyhq/jackson   latest    35add1c95024   4 days ago   649MB

The npm install reducing the image size is very bizarre since docker images are layered.

Did a bit of digging. I think this happens because npm install might run npm prune automatically which could remove some extraneous packages. Tested it locally with an RUN npm prune instead of RUN npm install sharp (before build instruction) and the final image size is identical.
Also we can do better. @G3root  You can remove the COPY --from=builder /app/npm ./npm step completely as the standalone build contains the jackson dependency inside it. This will bring the image size down to 169MB.

Tested the image locally against both SAML/OIDC providers and everything looks good.


feat: gitignore template updating

gitignore template updating
Add .history folder to gitignore template, some editors(for example vscode) created a new direction for making the local file history. May no one want to commit it 😉

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

@m-avagyan do you have a link for reference? Maybe this is added by a VS Code extension you are using? I don't see VS Code adding this folder on my side.

@patak-dev yes, I'm using the local-history extension, which is actual and this package also use many other developers

I agree with @bluwy. Thanks for the PR @m-avagyan, but to keep Vite maintainable it is better we don't try to add special treatment for every VS Code extension.


[NOCOMMIT] Approximate match all query benchmark

Description
This PR accompanies https://github.com/opensearch-project/OpenSearch/pull/16321 and adds a throwaway benchmark workload that enables range query approximation, to check if the changes there have the desired effect of reducing latency on match_all queries with a sort over a numeric field.
Related Issues
N/A
Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

{"run-benchmark-test": "id_14"}

{"run-benchmark-test": "id_14"}


[Device Support Request] TS0505B w/ _TZ3210_rcggc0ys

Problem description
Current Tuya bulbs in ZHA do not offer the Do Not Disturb, the Tuya power-on behavior version.
Solution description
Please add Do Not Disturb feature which seems to process Tuya custom cluster 0xef00 with DP 21.
Z2M support is here:
https://github.com/Koenkk/zigbee2mqtt/issues/19718
Screenshots/Video
Screenshots/Video
[Paste/upload your media here]

Device signature
Device signature
{
  "node_descriptor": {
    "logical_type": 1,
    "complex_descriptor_available": 0,
    "user_descriptor_available": 0,
    "reserved": 0,
    "aps_flags": 0,
    "frequency_band": 8,
    "mac_capability_flags": 142,
    "manufacturer_code": 4417,
    "maximum_buffer_size": 66,
    "maximum_incoming_transfer_size": 66,
    "server_mask": 10752,
    "maximum_outgoing_transfer_size": 66,
    "descriptor_capability_field": 0
  },
  "endpoints": {
    "1": {
      "profile_id": "0x0104",
      "device_type": "0x010d",
      "input_clusters": [
        "0x0000",
        "0x0003",
        "0x0004",
        "0x0005",
        "0x0006",
        "0x0008",
        "0x0300",
        "0x1000",
        "0xef00"
      ],
      "output_clusters": [
        "0x000a",
        "0x0019"
      ]
    },
    "242": {
      "profile_id": "0xa1e0",
      "device_type": "0x0061",
      "input_clusters": [],
      "output_clusters": [
        "0x0021"
      ]
    }
  },
  "manufacturer": "_TZ3210_rcggc0ys",
  "model": "TS0505B",
  "class": "zigpy.device.Device"
}

Diagnostic information
Diagnostic information
[Paste the diagnostic information here]

Logs
Logs
[Paste the logs here]

Custom quirk
Custom quirk
[Paste your custom quirk here]

Additional information
No response

It looks to use the Color Cluster:
https://github.com/Koenkk/zigbee-herdsman/blob/0408bcc7196a520f6314c9bb5e18e377d54a8667/src/zcl/definition/cluster.ts#L2198-L2458
Many Tuya Lamps has this same cluster. I hope it'd be implemented.

New updates: It indeed uses Color Cluster:
I must send a command to cluster 0x0300 (768) with attribute is 0xFA (250). Data is 0-disable DND, 1 - enable DND.
So, it's not something hard to implement.


Unable to compile SHARK

Hello. I would like to build and run the following CPP, but I am having trouble dealing with the different IREE versions.
https://github.com/nod-ai/SHARK/tree/main/cpp
The main problem is that the SHARK code is old and does not correspond to the IREE version.
The main error in the code [vulkan_inference_gui] is a bug where the following function does not exist
iree_vm_bytecode_module_size_benchmark_module_create
iree_tooling_load_module_from_flags
ParseToVariantList
I would like to support these, but I have searched for corresponding articles in IREE's GIT and internet search, but I am unable to figure out the function and status after the change.
I need your advice on how to solve these problems..
SampleCode
`
iree_vm_module_t* bytecode_module = nullptr;
const struct iree_file_toc_t* module_file_toc = iree_vm_bytecode_module_size_benchmark_module_create();
IREE_CHECK_OK(iree_vm_bytecode_module_create(
    iree_instance,
    iree_const_byte_span_t{
        reinterpret_cast<const uint8_t*>(module_file_toc->data),
        static_cast<iree_host_size_t>(module_file_toc->size) },
        iree_allocator_null(), iree_allocator_system(), &bytecode_module));

iree_status_t module_status = iree_tooling_load_module_from_flags(
    iree_instance, iree_allocator_system(), &bytecode_module);
if (!iree_status_is_ok(module_status))
    return -1;
iree_vm_context_t* iree_context = nullptr;
std::vector<iree_vm_module_t*> modules = { hal_module, bytecode_module };
IREE_CHECK_OK(iree_vm_context_create_with_modules(
    iree_instance, IREE_VM_CONTEXT_FLAG_NONE, modules.size(), modules.data(),
    iree_allocator_system(), &iree_context));
fprintf(stdout, "Context with modules is ready for use\n");

// Lookup the entry point function.
iree_vm_function_t main_function;
const char kMainFunctionName[] = "module.forward";
IREE_CHECK_OK(iree_vm_context_resolve_function(
    iree_context,
    iree_string_view_t{ kMainFunctionName, sizeof(kMainFunctionName) - 1 },
    &main_function));
iree_string_view_t main_function_name = iree_vm_function_name(&main_function);
fprintf(stdout, "Resolved main function named '%.*s'\n",
    (int)main_function_name.size, main_function_name.data);

iree_hal_allocator_t* allocator =
    iree_hal_device_allocator(iree_vk_device);

vm::ref<iree_vm_list_t> inputs;
iree_status_t input_status = ParseToVariantList(
    allocator,
    iree::span<const std::string>{FLAG_function_inputs.data(),
    FLAG_function_inputs.size()},
    iree_allocator_system(), & inputs);
if (!iree_status_is_ok(input_status))
    return -1;

vm::ref<iree_vm_list_t> outputs;
constexpr iree_hal_dim_t kOutputCount = 1000;
IREE_CHECK_OK(iree_vm_list_create(/*element_type=*/nullptr, kOutputCount * sizeof(float), iree_allocator_system(), &outputs));

`

I'm not sure how far that code has diverged from the iree-samples repo, but I did recently sync the IREE version there: https://github.com/iree-org/iree-samples/pull/216.
For API changes, I typically search the git history in IREE with e.g. git log -S iree_hal_buffer_view_allocate_buffer to find relevant commits.
We could also make more of an effort to put together a changelog / migration guide on our releases...

Thank you!

I'm not sure how far that code has diverged from the iree-samples repo, but I did recently sync the IREE version there: iree-org/iree-samples#216.
For API changes, I typically search the git history in IREE with e.g. git log -S iree_hal_buffer_view_allocate_buffer to find relevant commits.
We could also make more of an effort to put together a changelog / migration guide on our releases...

I've looked at the provided URL, but the CPP directory in question remains outdated. I was editing the cpp/vulkan_gui/vulkan_inference_gui.cc file, but I believe this code is outdated. For instance, the line #include "iree/vm/bytecode_module.h" needs to be included as bytecode/module, and the CMake folder needs to be changed accordingly. As for the other code, as per the question, it's necessary to search the logs one by one, and it is not functioning as a sample.


WebSocket Connection Dropped when Internet is Slow

This is particularly visible when in the file editor, if you have anything more than about 15 lines, it becomes impossible to use our file editor.
TLS is disabled, nginx reverse-proxy is in use.
In the server logs, the error is coming from this line.

Fixed, will be seen in next release.
It had to do with the nginx reverse proxy, for some reason we were only getting one byte from the Websocket header. Now I use ioctl/ioctlsocket to check the available length and check if we have enough before trying to read the header.


Purge vniTbl after cleaning up network sandbox

If we cleaned up a stale network sandbox and an entry for that exists in
vniTbl, then purge it from vniTbl. Otherwise when a new vxlan for that
vni is added to the network, we might destroy the network sandbox
created in the current life.
Signed-off-by: Jana Radhakrishnan<EMAIL_ADDRESS>

LGTM


setup instructions for iOS incorrectly say to add entire RNHockeyApp folder

The instructions say to add the entire RNHockeyApp folder to your project.
Add the RNHockeyApp/ folder to your project

Drag-and-drop from ./node_modules/react-native-hockeyapp/RNHockeyApp folder to your Project > Libraries.

This doesn't work, at least when performed against react-native v0.20.0.
The correct procedure is to add the two files inside the RNHockeyApp folder.

@JBerendes Update Readme instructions so the problem you have should be solved.   Let me know if it helps.

Hi guys, thanks for flagging this and making efforts to fix this. This still isn't clear however, even after the PR. Because the title says to Add the RNHockeyApp/ folder to your project, that's exactly what we did. It should read Add 2 files from the RNHockeyApp to your project to avoid ambiguity – if indeed that's what you're supposed to do.
At time of writing, we haven't got this working yet. I also notice the approach for adding libraries for this module appears to be different from all other react-native plugins. Other react-native plugins have an .xcodeproj folder that gets added to the Libraries directory. Whereas for this module it appears that I'm supposed to add RNHockeyApp.h and RNHockeyApp.m directly to the Libraries directory?
Finally, no instructions are given about which settings to select when importing these to Xcode. I.e:

Should 'Copy items if needed` be selected or not?
Should I select Create groups or Create folder references, or does it not matter?

Any ideas on the above?
Many thanks

I have released new version 0.4.0 that should work with rnpm link. It will do all the magic for you.

Do you mean with "all the magic" that the only steps necessary are npm install and rnpm link ?

@arthurvi Yes.

@martincik Hmm, then I had to open an issue. I just don't get it working: https://github.com/slowpath/react-native-hockeyapp/issues/20


shorten utf8string perf tests to around 1s per test

This is running for too long now to actually be useful when writing code

looks good


MatDepicterModule vs MatDatepickerModule

Issue with MatDatePicker finding it as MatDepicter
 src/app/modules/security/security.module.ts:15:10 - error TS2724: Module '"../../../../node_modules/@angular/material/datepicker"' has no exported member 'MatDatepickerModule'. Did you mean 'MatDepicterModule'?

    15 import { MatDatepickerModule } from '@angular/material/datepicker';
                ~~~~~~~~~~~~~~~~~~~

      node_modules/@angular/material/datepicker/datepicker-module.d.ts:28:22
        28 export declare class MatDepicterModule {
                                ~~~~~~~~~~~~~~~~~
        'MatDepicterModule' is declared here.

It seems like an issue on your end, because the source code has is as MatDatepickerModule and it hasn't really changed since it was introduced. See https://github.com/angular/components/blob/master/src/material/datepicker/datepicker-module.ts#L95

Closing due to lack of information.


Fix typo and add reference for arrow function

Added reference for arrow function

Thank you so much! This has been fixed now 👍


chore(portal): Fix policy creation for conditions disabled; tweak design

Fixes policy creation when policy_conditions is disabled
Updates design so that items are a little more aligned and text has more / consistent spacing around.

https://github.com/firezone/firezone/assets/167144/b9c29110-ae1c-4841-b999-a0da022f4a38
Test is failing though. Before sinking more time into this I wanted to open this PR to get @AndrewDryga's input.

I think we need a better icon. With all the changes the constraints form doesn't look like there are something that can be expanded there, instead, it looks exactly like a classic drag and drop UI element:

I think we need a better icon. With all the changes the constraints form doesn't look like there are something that can be expanded there, instead, it looks exactly like a classic drag and drop UI element:

K, will probably change it back

How's this? Back to chevrons, but framed them subtly to look more like buttons and stand out from the select input chevron inside the fields.

This bus could affect pentest, will merge when tests are green and can address more feedback in subsequent PRs.


np.where is expected !

Hi,guys
NumSharp is great!
recently I'm trying porting some python code to c#,
and I found there's no support of np.where,
I also noticed some issues about this problems ( #78 ,#362 )
actually there're a lot usages between pre-processing and post-processing,
though we can do it via loops, it's low performance.
is there a deadline or plan on this ?
thx!

Within a week I'll finish it.

@AvenSun I've been waiting the feature for two months as well.
I believe @Nucs will make it happen, big surprise for us.

@Nucs
It'll be a great news to all SciSharp fans.
looking forward to the PR.

This function is finished or not?

is this expected?


Set-RBCD Success Response wrong direction?

Hey there!
I think this there is a wording issue in Set-DomainRBCD:
[Set-DomainRBCD] Success! TARGETCOMPUTER is now in mycomputeraccount$'s msDS-AllowedToActOnBehalfOfOtherIdentity attribute

Shouldn't it be like this, as I'm editing the targets attribute?:
[Set-DomainRBCD] Success! mycomputeraccount$ is now in TARGETCOMPUTER's msDS-AllowedToActOnBehalfOfOtherIdentity attribute

Great tooling. Can't stop to praise :+1:

You're right! Thanks for pointing this out

This is now fixed. Closing this. Thanks again!


Issue/add test

Pull Request
Description
Add test for irradiance model for 'run all batches'
How Has This Been Tested?

[ ] No
[ ] Yes

Checklist:

[ ] My code follows OCF's coding style guidelines
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

Codecov Report

Merging #18 (bdfa79e) into main (9217b42) will increase coverage by 7.73%.
The diff coverage is 85.71%.

:exclamation: Current head bdfa79e differs from pull request most recent head 8a0c031. Consider uploading reports for the commit 8a0c031 to get more accurate results

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   83.63%   91.36%   +7.73%
==========================================
  Files          12       12
  Lines         336      336
==========================================
+ Hits          281      307      +26
+ Misses         55       29      -26

Impacted Files
Coverage Δ

nowcasting_forecast/app.py
88.88% <50.00%> (ø)

nowcasting_forecast/models/nwp_solar_simple.py
94.11% <100.00%> (+33.33%)
:arrow_up:

nowcasting_forecast/dataloader.py
90.00% <0.00%> (+45.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9217b42...8a0c031. Read the comment docs.


SMO20 supported?

Hi @elupus,
I have a SMO20 hooked up with a F2040-8. Do you know if either of these have a Modbus connection? In the HA component I see smo20 as a supported device, but I seem to remember back in the day when I needed to decide if the SMO40 was worth the extra €€€ that Modbus support was one of the distinctive features of the SMO40 over the SMO20. I hope I'm misremembering, as while I love your uplink api component so far, I rather hook up a esp32 directly at the smo and keep everything local.
Thnx,
Michiel

Found this https://github.com/yozik04/nibe/issues/41

For now i think we can consider it not supported.


fix: remove unused Command#isCustomCommand

It was introduced to prevent sending custom commands in cluster+pipeline: https://github.com/luin/ioredis/blob/80f4a454fb0d24392e4fa27fbd3f6f22b0bf938e/lib/pipeline.js#L250, and it's not used anymore.
Test plan:
Make sure the property is not used anymore.

@marcbachmann 👋 Can you take a look at this change if you have time?


SU-377

Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[ ] Create/update unit or integration tests for verifying the changes made.

[ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

This PR fixes below issues

VERTICAL loan priority will now work exactly the same as HORIZONTAL
When an advance payment is made then interest calculation of the very next installment will be calculated as (outstanding principal * daily interest rate *days in installment) + (outstanding principal * daily interest rate * number of days between installment start date and advance transaction date)


Update all epinio docs for SLC

fixes #377
We have decided to follow the documentation structure according to [0] recommended by @viccuad and format the Readme.md according to [1].
[0] https://documentation.divio.com/structure/
[1] https://guides.github.com/features/wikis/
Action Items

[x]  Update README.md
[ ] Update /docs/*.md according to new structure
[x] Update GIT URL Doc
[x] Update skip-traefik Doc
[x] Update skip-linkerd Doc
[x] Update two step installation process

(the doc structure was recommended to us by @mattfarina :)


make tags in base image building deterministic

make the input for base image picking irrelevant to the build commit on local build. this will make the build args part of the input deterministic and cachable.
the BUILDKITE_PULL_REQUEST and BUILDKITE_COMMIT will also be removed from follow up changes.

test proof: https://buildkite.com/ray-project/oss-ci-base-image-builder/builds/386


feat: adding an unused dependency checker

Which issue does this PR close?

Closes #.
Rationale for this change

Removing unused dependencies. Better for streamlining the project and frees up space.
What changes are included in this PR?

Adding cargo machete to CI.
How are these changes tested?

Build succeeds. All tests pass.

lots of conflicts. i will  resubmit.


Unable to connect to docker registry

When I try connecting to docker private registry(trail version install in one of my AWS servers) from a docker host I get the following error:
FATA[0000] Error response from daemon: v1 ping attempt failed with error: Get https://docker-registry.xyz.com/v1/_ping: x509: certificate signed by unknown authority. If this private registry supports only HTTP or HTTPS with an unknown CA certificate, please add --insecure-registry docker-registry.nearbuytools.com to the daemon's arguments. In the case of HTTPS, if you have access to the registry's CA certificate, no need for the flag; simply place the CA certificate at /etc/docker/certs.d/docker-registry.xyz.com/ca.crt
I tried docker login  command. the registry has a valid certificate and it is placed in the mentioned location.(i.e. etc/docker/certs.d/docker-registry.xyz.com/ca.crt )
Docker details:
sudo docker version
Client version: 1.6.0
Client API version: 1.18
Go version (client): go1.4.2
Git commit (client): 4749651
OS/Arch (client): linux/amd64
Server version: 1.6.0
Server API version: 1.18
Go version (server): go1.4.2
Git commit (server): 4749651
OS/Arch (server): linux/amd64
ubuntu@ip-172-20-0-9:~$ kubectl version
Client Version: version.Info{Major:"1", Minor:"0", GitVersion:"v1.0.7", GitCommit:"6234d6a0abd3323cd08c52602e4a91e47fc9491c", GitTreeState:"clean"}
Server Version: version.Info{Major:"1", Minor:"0", GitVersion:"v1.0.7", GitCommit:"6234d6a0abd3323cd08c52602e4a91e47fc9491c", GitTreeState:"clean"}

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

uname -a
Linux ip-172-20-0-9 3.19.0-33-generic #38-Ubuntu SMP Fri Nov 6 18:18:12 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
It is an EC2 instance. Other details are already given.

Just checking up; have you been able to solve this issue @mahehss? Wondering if this is related to https://github.com/docker/docker/issues/9118

I think this was fixed.


[FEAT] : Improve Market for Backend

✅ Checklist

[x] npx changeset was attached.
[ ] Covered by automatic tests.
[ ] Impact of the changes:

...

📝 Description
Discussed in
https://ledgerhq.atlassian.net/wiki/spaces/BE/pages/4867096580/2024-07-18+CVS+freshness+markets+traffic+analysis
Improvements in this PR :

Debounced search in LLD
Uppercase counterCurrency in LLM/LLD
lowercase search in LLM/LLD
2 characters are needed now to trigger search
sort ids when favorite filter in On

What's next ?

LLM pagination fix
Discrepancy between listing page and coin page

DEMO
https://github.com/user-attachments/assets/0438f0a8-7cb9-493f-ba12-a047ec2f8fb8
https://github.com/user-attachments/assets/bbb020bc-034b-4ea5-8513-cf0c54142ca5
❓ Context

JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

/generate-screenshots

/generate-screenshots

/generate-screenshots


How to use the GAN model [21] PPNG in your paper?

Could you share your method to demonstrate the visualization of deep features?
It's very interesting. Thanks.

This part is implemented by my partner and I am not very familiar with  the details. I have discussed with him but he is busy with another deadline recent days so I couldn't give a concrete answer right now. I will have another discussion with him before this weekend and after that I will give you a detailed answer . Thanks~

Thank you very much! The GAN's part in your paper is very exiting!!! Expecting...

yes, it's very  interesting thing. I too expect

Sorry for my delayed reply, here is the answer after I disscussed with my partner.
We used the version Noiseless joint PPGN-h proposed in the paper specifically. We replace the Encoder Network with an End2End trained model and then we get a Generator Network which is able to decode a image given a vector of feature. And it could help to visualize the mapped feature as well

Thank you. And I want to know whether the Noiseless joint PPGN-h is retrained with CelebA-1M or some other dataset.

Yes, it is trained on cleaned Celeb-1M

If could you share the model about reconstruction? That would be appreciated it.


fuse_file_info doesn't have nonseekable

I have a socket-like file that can be read, but not seeked.
On the C api, I can use fi.nonseekable = 1 to indicate that, but this doesn't seem to be present on fusepy.
Is that an error, or is there something I am missing?

(I noticed a few other mismatches which I don't really care right now, e.g., getattr has an extra fuse_file_info* argument for fgetattr)

It's likely this is not implemented, but I didn't have a chance to review that statement. If you would like to contribute a patch it would be appreciated.


[Issue-116] Upgrade Pravega 0.10 to the latest snapshot version

Signed-off-by: zhongle.wang<EMAIL_ADDRESS>Change log description
Upgrade pravega version to the latest commit pravega/pravega@a621c55
Purpose of the change
Fix #116
What the code does
Upgrade pravega version to the latest commit pravega/pravega@a621c55
How to verify it
gradlew build passes

Compatibility matrix updated.


Memory leak checker misses AtomicPtr

use std::{
    cell::UnsafeCell,
    ptr,
    sync::atomic::{AtomicPtr, Ordering},
};

fn leak() {
    static LEAK: AtomicPtr<usize> = AtomicPtr::new(ptr::null_mut());
    LEAK.store(Box::into_raw(Box::new(0usize)), Ordering::SeqCst);
}

fn no_leak() {
    struct Local(UnsafeCell<*mut usize>);

    unsafe impl Send for Local {}
    unsafe impl Sync for Local {}

    static LEAK: Local = Local(UnsafeCell::new(ptr::null_mut()));
    *unsafe { &mut *LEAK.0.get() } = Box::into_raw(Box::new(0usize));
}

fn main() {
    no_leak();
    // leak();
}

Miri considers memory leaks reachable through a static global as non-leaking. I'd expect the Atomic* case be non-leaking as well, however miri reports it as leaked memory.
The following memory was leaked: alloc1834 (Rust heap, size: 8, align: 8) {
    00 00 00 00 00 00 00 00                         │ ........
}

error: the evaluated program leaked memory

error: aborting due to previous error; 1 warning emitted

(This is a special case of https://github.com/rust-lang/miri/issues/1618.)

AtomicPtr casts the pointer to an integer before storing it. This prevents miri from seeing that the AtomicPtr keeps it alive.

So... we can either not do a cast in AtomicPtr (I guess a transmute will keep the provenance?) or we need to teach AtomicPtr to set the miri_static_root (but that would be overly permissive, as you could now also just do that in non-static code).

Yeah, I cannot think of a good way to ix this I am afraid... we cannot just randomly cast any integer we see to a pointer in the off chance that it represents an actual address. Ideally AtomicPtr would not cast pointers to integers, but the underlying problem here is that LLVM does not support atomic operations on pointers.
Probably I should not have closed https://github.com/rust-lang/miri/issues/1318, which is the same problem. Crossbeam is also affected by this (https://github.com/crossbeam-rs/crossbeam/issues/464).
Currently the best way to approach the problem is to call miri_static_root.

I guess we could push this down to the LLVM codegen layer so that the Rust intrinsic does support pointers, not sure if that would be a good idea.

Oh, I like this. That seems entirely reasonable to me

the underlying problem here is that LLVM does not support atomic operations on pointers

I was unable to find any recent information on this being true and changing it in rustc to just use pointers worked without any additional changes.

the underlying problem here is that LLVM does not support atomic operations on pointers

I was unable to find any recent information on this being true and changing it in rustc to just use pointers worked without any additional changes.

Uh I thought I had LLVM experts confirm that when I asked but maybe I misremember.

FWIW, this is also a problem when using -Zmiri-track-raw-pointers, which breaks int-to-ptr casts -- both Windows in general, and accessing the program argument on Unix systems, involve AtomicPtr and thus fail with -Zmiri-track-raw-pointers.

Status: @oli-obk started some work on supporting raw pointer types in the atomic intrinsics in https://github.com/rust-lang/rust/pull/77611, and then realized that this would need some support by the codegen backend since LLVM only supports atomic operations on integer types.

Just to double-check my understanding; is it expected that -Zmiri-track-raw-pointers will fail to track correctly when using AtomicPtr::compare_exchange and friends, since they still use pointers-as-integers under the hood (I think only load/store (https://github.com/rust-lang/rust/pull/77611) and swap (https://github.com/rust-lang/rust/pull/80236) have been "fixed")?

Yes. We need to fix this in libstd/rustc, miri is doing the right thing ™ and implementing workarounds just on the miri side is not feasible afaict

So looks like this comment was not accurate then?

If you have the time, could you remove all as *mut usize and as usize from the implementation of AtomicPtr and adjust the intrinsics accordingly?

I don't think there is anything left (though I might have missed something). Remaining operations are intentionally unsupported in atomic ptr, so I don't think we should support them in intrinsics either.

@jonhoo looking at the compare_exchange implementation, it does not seem to use int-to-ptr casts:
https://github.com/rust-lang/rust/blob/1cc0ae4cbbcb9909035b5b99fc20bf6b79f4010c/library/core/src/sync/atomic.rs#L1153
So actually I think I disagree with Oli, this is not expected. Do you have a small example of this going wrong?

Yes, that message indicates an int-to-ptr cast. But the question is where that cast is happening...

Anyway, AtomicPtr is likely innocent, so I will re-close this issue. Can you open a new issue for this problem?

Ugh, looking through the code again, I realized that I do cast between pointers and integers to manage a bit in a pointer as a lock. That's unfortunate, but explains the problem. Sorry for the noise!
Any news on whether Miri might gain capabilities for tracking pointers even in the presence of such casts and bit flips? Potentially with some extra code to tell Miri what's going on through an extern? These kinds of tricks are quite common in concurrency primitive libraries where Miri is invaluable.

Please open a new issue with a pointer to the relevant code. Ö=

Filed https://github.com/rust-lang/miri/issues/1993


Fix end position of diagnostic for LSP

I noticed that the diagnostics were always one character short when using vscode-rubocop, so I fixed it.
character of Position is zero-based
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#position

Character offset on a line in a document (zero-based).

And, Parser::Source::Range is also zero-based
https://github.com/whitequark/parser/blob/3e260d2e37bcb3de8705489d1c2799c26c7a2215/lib/parser/source/range.rb#L104

zero-based column number of the end of this range.

Therefore, -1 is not necessary.
Operation check on VSCode (with vscode-rubocop)

rubocop output json
demo.rb
require "rubocop"

class Foo
  def foo
    variable = 1
      b = 2
  end
end

$ bundle exec rubocop -f json demo.rb 2>/dev/null | jq

{
  "metadata": {
    "rubocop_version": "1.64.0",
    "ruby_engine": "ruby",
    "ruby_version": "3.3.1",
    "ruby_patchlevel": "55",
    "ruby_platform": "arm64-darwin22"
  },
  "files": [
    {
      "path": "demo.rb",
      "offenses": [
        {
          "severity": "convention",
          "message": "Missing frozen string literal comment.",
          "cop_name": "Style/FrozenStringLiteralComment",
          "corrected": false,
          "correctable": true,
          "location": {
            "start_line": 1,
            "start_column": 1,
            "last_line": 1,
            "last_column": 1,
            "length": 1,
            "line": 1,
            "column": 1
          }
        },
        {
          "severity": "convention",
          "message": "Missing top-level documentation comment for `class Foo`.",
          "cop_name": "Style/Documentation",
          "corrected": false,
          "correctable": false,
          "location": {
            "start_line": 3,
            "start_column": 1,
            "last_line": 3,
            "last_column": 9,
            "length": 9,
            "line": 3,
            "column": 1
          }
        },
        {
          "severity": "warning",
          "message": "Useless assignment to variable - `variable`.",
          "cop_name": "Lint/UselessAssignment",
          "corrected": false,
          "correctable": true,
          "location": {
            "start_line": 5,
            "start_column": 5,
            "last_line": 5,
            "last_column": 12,
            "length": 8,
            "line": 5,
            "column": 5
          }
        },
        {
          "severity": "convention",
          "message": "Inconsistent indentation detected.",
          "cop_name": "Layout/IndentationConsistency",
          "corrected": false,
          "correctable": true,
          "location": {
            "start_line": 6,
            "start_column": 7,
            "last_line": 6,
            "last_column": 11,
            "length": 5,
            "line": 6,
            "column": 7
          }
        },
        {
          "severity": "warning",
          "message": "Useless assignment to variable - `b`.",
          "cop_name": "Lint/UselessAssignment",
          "corrected": false,
          "correctable": true,
          "location": {
            "start_line": 6,
            "start_column": 7,
            "last_line": 6,
            "last_column": 7,
            "length": 1,
            "line": 6,
            "column": 7
          }
        }
      ]
    }
  ],
  "summary": {
    "offense_count": 5,
    "target_file_count": 1,
    "inspected_file_count": 1
  }
}

Before

After

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic Thank you for reviewing.
I added changelog/fix_fix_end_position_of_diagnostic.md.

@ksss Can you squash your commits into one?

Sure, done.

Thanks!


chore: 🤖 add VERSION file

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Every time I link my device it always auto-logout.

Every time I link my device it always auto-logout. On my device a message pops up and gives a link to : https://faq.whatsapp.com/general/seeing-devices-logged-out-unexpected-issue?lang=en
Please anyone can help me?

 Gtk-Message: 20:30:37.447: Failed to load module "xapp-gtk3-module" Gtk-Message: 20:30:37.748: Failed to load module "colorreload-gtk-module" Gtk-Message: 20:30:37.748: Failed to load module "window-decorations-gtk-module" js: Another connection wants to delete database 'wawc_db_enc'. Closing db now to resume the delete request. js: Another connection wants to delete database 'wawc_db_enc'. Closing db now to resume the delete request. js: Another connection wants to delete database 'model-storage'. Closing db now to resume the delete request. js: Another connection wants to delete database 'fts-storage'. Closing db now to resume the delete request. js: Dexie.delete('model-storage') was blocked js: Another connection wants to delete database 'wawc'. Closing db now to resume the delete request.

This is due to the recent switch of Whatsapp web, They are using the new version of Whatsapp now. I request you to update your application on your phone and clear the app cache and app data of Whatsie from settings. everything will work normally afterward.

Unfortunately its broken for me too. Don't have the problem with other third party apps.

I request you to logout from all sessions, clear Whatsie's application cache from settings, restart and Log back In.

I am experiencing the same issue. I logged out of everywhere (except my phone, the only way to "log out" I guess is to delete the app and re-install). I cleared the cache of Whatsie, and also tried uninstalling it and re-installing it.
I had no luck.

I had no luck. Any other suggestions?

Unfortunately it seems this Snap is borked. I switched to another app which works

I had no luck. Any other suggestions?

Unfortunately it seems this Snap is borked. I switched to another app which works

Sorry to hear that, but snap has nothing to do with this behavior.

Hi @keshavbhatt I am not saying snapd is the problem. Unfortunately its a bug with this particular app.

same here.
it only disconnects from your app.

The issue is being tracked at #48
hence closing it to avoid duplication.

The issue is being tracked at #48
hence closing it to avoid duplication.


Use UIApplication.class instead of UIApplication.flex_metaclass

Use UIApplication.class instead of UIApplication.flex_metaclass
See https://github.com/Flipboard/FLEX/issues/424, this somehow has issue on iOS 9 somehow from my internal reports, so I think this can be a speculative fix.

This is intentional. Copying my reply from the other thread:
Adding shortcuts to the metaclass makes them appear when you explore the class itself. Adding them to the class makes them appear on instances. You can add class properties as shortcuts to either
If something is crashing iOS 9, we need to find out what or why

I bet the issue is that the property isn't actually a property under iOS 9, so we would need to add the property at runtime like we're doing with a bunch of UIView properties.

Makes sense, can you give a pointer on where we are doing that for other properties?

Sure! Both haha. I'll mention you in the PR so you can see.


Publish inverter ID via simple_mqtt

I was wondering why this didn't happen for simple_mqtt, but for Home Assistant it did. It makes sense when you want to push data from multiple identical inverters to a single MQTT server, so you can distinguish between them.

[x] run cargo clippy and fix all issues
[x] run cargo fmt to format all source files

i also have another version running where the inverter ID is part of the published topic and not the payload, which for my personal setup makes more sense. if that's something you'd prefer, i can open another PR and close this one.

I think it would make sense to have the inverter ID as part of the published topic. It would be a breaking change however for the existing users and their applications that depend on the previously used topic. Maybe we can add a parameter "use_sn_in_topic" or something like that to make it optional

@DennisOSRM already seems to have started to implement reading environment variables in #61 as it looks like. what's the status of this?
the fix in this PR here should be done regardless i think, since the home assistant config already does that.
also there is #116 which requests that, basically. let me know if i should pick this up.

Oh yes, happy to consider PRs since I am somewhat spread thin with day job and other stuff right now. 👍🏽

alright. closing this one then.


Add support for Fabric v2.2

This involves the following steps:

Fabric machine api
Fabric machine protocol
Integration with Fabric codebase
Scripts to setup Fabric network, install/instantiate chaincode, create channel, join channel
Smallbank benchmark

Great Job..
Looking forward to test the 2.2 repo with my Alveo card and report test results..
Hope it will be out really soon since I want to migrate to HLF 2.x ASAP

Great Job.. Looking forward to test the 2.2 release with my Alveo card and report test results.. Hope it will be out really soon since I want to migrate to HLF 2.x ASAP

Thanks for your interest. The current timeline is end of June or early July for v2.2 because I am away on leave for the next 2 weeks. The code is already in v2.2 branch, but hasn't been fully merged into main branch and tested.

This is now done so closing the issue.


Improve logging documentation of configs

Issue Number

#961
Overview

[x] I have replicated (tried to do it) monitoring config needed to retrieve what happens when just defaultConfigStdout from iohk-monitoring-framework is called
[x] I have replicated (tried to do it) monitoring config needed to retrieve what happens when initTracer with Nothing from cli is called
[ ] I have updated CLI Manual

Comments
In order to test do :
$ stack test --ta '-m "initTracer"' cardano-wallet-cli:unit

It seems like it will be difficult for us to test and document the entire log config format, and that is really a job for the iohk-monitoring team.
The main use for this --logging-config option would probably be as a way to enable logging to file with rotation by log file size.

@rvl @KtorZ exactly, we probably should resign from giving user possibility of setting whole logging config, but expose some features like rotation, etc.
Nevertheless, the above findings may be of interest to iohk-monitoring-framework team

Hmmm. @paweljakubas , the goal for #961 I believe is simply to get some degree of documentation on our side. Pointing to some existing documentation / examples on the iohk-monitoring-framework would probably be sufficient.
For testing, I concur @rvl's remark, it's not our scope to check whether the framework works as intended. We already have a few test cases regarding logging and it's quite okay for the wallet backend already.

closing in favor of #1253


feat: LSDV-3025-7: Add filter that is equal or not equal as the speci…

…fied value
PR fulfills these requirements

[x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[x] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[x] Product design
[x] Frontend

What is the new behavior?
Filter component now have the possibility to filter items that is not equal or equal as the specified value
What libraries were added/updated?
no
Does this change affect performance?
no
Does this change affect security?
no
What alternative approaches were there?
na
What feature flags were used to cover this change?
fflag_feat_front_dev_3873_labeling_ui_improvements_short
Does this PR introduce a breaking change?
(check only one)

[x] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[ ] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[ ] integration
[x] unit

Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

/git merge develop

/git merge master


:farmer: CmdLine test regressions in gz-launch2-homebrew

Environment

OS Version: MacOS Monterey and Ventura
Binary build - Citadel

Description

Expected behavior: Tests should pass
Actual behavior: CmdLine Tests are failing

Steps to reproduce

Run a build in ign-launch2
See 2 test regressions

Output
Reference build: https://build.osrfoundation.org/job/ignition_launch-ci-ign-launch2-homebrew-amd64/59/
Failing tests:

CmdLine.Ls
CmdLine.EchoSelf

Log output:
The following tests FAILED:
	  3 - UNIT_ign_TEST (Failed)

Test 3 - UNIT_ign_TEST output:

test 3
    Start 3: UNIT_ign_TEST

3: Test command: /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/bin/UNIT_ign_TEST "--gtest_output=xml:/Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/test_results/UNIT_ign_TEST.xml"
3: Working Directory: /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/src
3: Test timeout computed to be: 240
3: Running main() from /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/ign-launch/test/gtest/src/gtest_main.cc
3: [==========] Running 3 tests from 1 test suite.
3: [----------] Global test environment set-up.
3: [----------] 3 tests from CmdLine
3: [ RUN      ] CmdLine.Ls
3: Running command [IGN_CONFIG_PATH=/Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/test/conf /usr/local/opt/ruby/bin/ruby /usr/local/bin/ign launch /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/ign-launch/test/config/ls.ign]
3: Library error: Problem running [launch]() from /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/lib/libignition-launch<IP_ADDRESS>.dylib.
3:
3: /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/ign-launch/src/ign_TEST.cc:63: Failure
3: Value of: output.find("CMakeFiles") != std::string::npos
3:   Actual: false
3: Expected: true
3: Library error: Problem running [launch]() from /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/lib/libignition-launch<IP_ADDRESS>.dylib.
3:
3: /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/ign-launch/src/ign_TEST.cc:64: Failure
3: Value of: output.find("Makefile") != std::string::npos
3:   Actual: false
3: Expected: true
3: Library error: Problem running [launch]() from /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/lib/libignition-launch<IP_ADDRESS>.dylib.
3:
3: [  FAILED  ] CmdLine.Ls (913 ms)
3: [ RUN      ] CmdLine.EchoSelf
3: /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/ign-launch/src/ign_TEST.cc:76: Failure
3: Expected equality of these values:
3:   filePath
3:     Which is: "/Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/ign-launch/test/config/echo.ign"
3:   output
3:     Which is: "Library error: Problem running [launch]() from /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/lib/libignition-launch<IP_ADDRESS>.dylib.\n"
3: Library error: Problem running [launch]() from /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/lib/libignition-launch<IP_ADDRESS>.dylib.
3:
3: [  FAILED  ] CmdLine.EchoSelf (211 ms)
3: [ RUN      ] CmdLine.HelpVsCompletionFlags
3: [       OK ] CmdLine.HelpVsCompletionFlags (212 ms)
3: [----------] 3 tests from CmdLine (1336 ms total)
3:
3: [----------] Global test environment tear-down
3: [==========] 3 tests from 1 test suite ran. (1336 ms total)
3: [  PASSED  ] 1 test.
3: [  FAILED  ] 2 tests, listed below:
3: [  FAILED  ] CmdLine.Ls
3: [  FAILED  ] CmdLine.EchoSelf
3:
3:  2 FAILED TESTS
3/6 Test #3: UNIT_ign_TEST ......................***Failed    1.41 sec

Gz-sim7 and ign-gazebo3 have similar issues reported here: https://github.com/gazebosim/gz-sim/issues/1867

This issue is still happening in homebrew both monterey and ventura OS versions.
Reference build: https://build.osrfoundation.org/job/gz_launch-ci-ign-launch2-homebrew-amd64/35/#showFailuresLink
Log output is similar:
/Users/jenkins/jenkins-agent/workspace/gz_launch-ci-ign-launch2-homebrew-amd64/gz-launch/src/ign_TEST.cc:63
Value of: output.find("CMakeFiles") != std::string::npos
  Actual: false
Expected: true
Library error: Problem running [launch]() from /Users/jenkins/jenkins-agent/workspace/gz_launch-ci-ign-launch2-homebrew-amd64/build/lib/libignition-launch<IP_ADDRESS>.dylib.

there was a big change between gz-launch2 and gz-launch5 in https://github.com/gazebosim/gz-launch/pull/121
backporting that change (if possible) may resolve this?


{app-insights}Add quotes for --dest-sas of app-insights

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

app-insights


Fixes #669 Log all unhandled exceptions to Event Log

Fixes #669 Log all unhandled exceptions to Event Log
Creates an event source and writes errors to it.
Also handles errors better in code paths that I happened to be trying to test.

:+1:


Jenkins fails health checks too quickly

If jenkins has already been running and you need to start it via the UI it can easily fail the health checks and the tasks get killed.
It seems the default number of checks for unhealthy is 2 checks and for healthy is 5.
This should probably be the other way around as it want jenkins to be health in the ALB sooner and only fail if it's really not responding

issue was with the upstream fargate component https://github.com/theonestack/hl-component-fargate-v2/releases/tag/0.7.2


Bug with showOwnValidation updating more than once in same computation

Seeing the following error since upgrading to 4.6 (currently on the latest version - i.e. 4.6.2):
index.js:172 Uncaught (in promise) Error: Assertion Failed: You attempted to update `showOwnValidation` on `BsFormElementWithChangesetValidationsSupport`, but it had already been used previously in the same computation.  Attempting to update a value after using it in a computation can cause logical errors, infinite revalidation bugs, and performance issues, and is not supported.

`showOwnValidation` was first used:

- While rendering:
  -top-level
    application

Stack trace for the update:
    at dirtyTagFor (validator.js:581)
    at setter (validator.js:867)
    at BsFormElementWithChangesetValidationsSupport.set [as showOwnValidation] (index.js:3959)
    at BsFormElementWithChangesetValidationsSupport.showValidationOnHandler (element.js:646)
    at BsFormElementWithChangesetValidationsSupport.showValidationOnHandler (element.js:68)
    at clear (runtime.js:144)
    at UpdatableBlockImpl.reset (runtime.js:1271)

After discussion on Discord with @jelhan, we've worked out that this is actually a bug in Ember Bootstrap rather than something I'm doing wrong in my app. Another user on Discord also reported seeing the same error.
I've managed to reproduce the error in the Ember Bootstrap repo using this test which reproduces the scenario in which I'm seeing a failing test in my application:
test('it has a show own validation bug', async function (assert) {
  assert.expect(1);
  this.set('submit', ({ name }) => assert.equal(name, 'Zoey'));
  this.set('beforeSubmit', (model) => {
    if (this.user) {
      model.set('name', this.user.name);
    }
  });

  await render(hbs`
    <BsForm
      @model={{this}}
      @onBefore={{this.beforeSubmit}}
      @onSubmit={{this.submit}}
      as |Form|
    >
      {{#unless this.user}}
        <Form.element @property="name" />
      {{/unless}}

      <Form.submitButton @defaultText="Submit" />
    </BsForm>
  `);

  await fillIn('input', 'Tomster');

  this.set('user', { name: 'Zoey' });

  await click('button');
});

@jelhan has suggested that removing these two lines probably fixes the problem, so I'm going to have a go at a PR:
https://github.com/kaliber5/ember-bootstrap/blob/69f6c239582c88f6fd8aeb3f78ebefe3554e6f7a/addon/components/bs-form/element.js#L582-L583

@basz @lindyhopchris Sorry for not coming back to this one earlier. Are you still able to reproduce with v4.9.0, which has been released just now? It may have been fixed by #1535.

Np. Shall test soon.

@jelhan bad news, I'm still seeing this even with v4.9.0

Looks like 4.9.0 solved my issues. Thank you guys! Not seen a single computation issue...


Cost Implications of LifeCycle in Blob Storage

There is no documentation regarding additional cost involved in lifecycle management. Is it free?
Since there is no api to search blobs via last modified, does Azure list all blobs to search last modified, does this list operation by azure count towards our cost of transaction? So if we have 1 million blobs, each 1 million list operation will be performed every 48 hours?
So the question in summary is, is listing by backend free or is it added to our cost of listing transaction and how frequently?
Please note, I am aware that LifeCycle management is free, the question is about listing and searching blobs cost by the azure backend service.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 392e90a0-af77-999e-39a1-78f09ffe0d06
Version Independent ID: 411ca9a3-4370-f9ca-f14c-5385e13d9075
Content: Hot, Cool, and Archive access tiers for blob data - Azure Storage
Content Source: articles/storage/blobs/access-tiers-overview.md
Service: storage
Sub-service: blobs
GitHub Login: @normesta
Microsoft Alias: normesta

@ackava Thank you for your feedback. We will investigate and update the thread further.

@ackava Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@normesta Any update on this question?

Hi @ackava I believe that @fhryo-msft might know best about any non-obvious cost mechanics involved in the backend processing required to complete a lifecycle management policy run. @fhryo-msft would you mind responding? Thank you!

List operations by LCM should be billed but i can be wrong. Adding LCM PM @santoshc1 to advise.

Thank you for your dedication to our documentation.
We sincerely apologize for the delayed response. After a careful review, we are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close

The question isn't answered, and documentation is not updated regarding this. Please reopen, if you need clarification, please ask, as per @fhryo-msft the answer is not clarified, Listing Blob cost will be billed, or will not be billed. Somebody needs to say yes or no and update the billing page.

Thanks @ackava - I created an internal work item for tracking (https://dev.azure.com/msft-skilling/content/_queries/query/fc947db6-8c76-4ec3-9983-3b8c0dfd3e99/) and we shall investigate with the appropriate folks.


Automated cherry pick of #4224: fix: 移除重复的manger注册

Cherry pick of #4224 on release/2.13.
#4224: fix: 移除重复的manger注册

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.13@d89d4dc). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.13   #4225   +/-   ##
==============================================
  Coverage                ?   6.87%
==============================================
  Files                   ?     519
  Lines                   ?   88088
  Branches                ?       0
==============================================
  Hits                    ?    6053
  Misses                  ?   81536
  Partials                ?     499

Flag
Coverage Δ

#aFlag
6.87% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d89d4dc...d0bf533. Read the comment docs.

/lgtm

/approve


Add form validation

Add form validation for email address
created validation.js file
updated index.html & main.css file

Hi @imranhossainemi and @dheerajsachdeva, can you please add a key feature of your app to your readme in the key features section

Hi @imranhossainemi and @dheerajsachdeva, can you please add a key feature of your app to your readme in the key features section

Check, ok/not ?