LIIKUNTA-63 | Add suggestion to free text search

Now while the user types, the UI should offer suggestions for the user. The suggestions should be in the currently chosen language.
Custom Dropdown implementation with Downshift
The Combobox in HDS doesn't support our usecase. The combobox is designed for selecting one option from many. Our usecase is a text field that allows the user to optionally choose from a curated option list. The technical detail that makes it impossible to use Combobox is that it doesn't allow us to control the value of the input, which is why we are not able to track the value of the input--and hence make searches with it.
I implemented a custom dropdown which uses the same tooling as HDS does for its dropdown implementation.
The implementation lends more from HDS than from the implementation in events.

Codecov Report

Merging #14 (7b9dd5e) into main (11758cc) will decrease coverage by 0.53%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   66.80%   66.26%   -0.54%
==========================================
  Files          38       38
  Lines         247      249       +2
  Branches       52       52
==========================================
  Hits          165      165
- Misses         82       84       +2

Impacted Files
Coverage Δ

src/api/utils.ts
40.00% <0.00%> (-10.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11758cc...7b9dd5e. Read the comment docs.


Add parent access support on embedded objects

Add backlinks support for embedded objects through the EmbeddedRealmObject.parent() extension function.
It provides access to the parent in runtime, and does not require defining particular property in the model as we need in backlinks.
closes https://github.com/realm/realm-kotlin/issues/1134

Added support for defining backlinks on EmbeddedRealmObjects models.


Async Support?

Any plans or idea on adding support for asynchronous rendering?
For example, allowing the following example to work.
elementOpen('div', '', null);
setTimeout(function() {
  text('hi');
  elementClose('div');
}, 1000);

This is typically only desirable for server side rendering. Since our initial goal is to support existing templating languages those could just use their existing string generation instead.

Dust.js is a pretty popular templating engine with asynchronous support. I'm sure there are other engines out there that support async rendering as well.

@kesne Oh, I've implemented a few of those myself. Just saying it is typically a very bad idea on the client because it leads to uncontrollable re-layouts.
If this comes up as something people want we can make  something like this work
elementOpen('div', '', null);
var context = saveContext();
setTimeout(function() {
  restoreContext(context);
  text('hi');
  elementClose('div');
}, 1000);

But I don't see very high priority.

I would also be concerned about people potentially kicking off a second render while the first is in progress, which could lead to strange behavior.
One reason why I think async rendering generally isn't handled by virtual DOM implementations is that invoking a render again when you have more data usually isn't too bad.

@cramforce I see your concern with it now. I think it's only dangerous if you don't have some sort of control between when re-layouts occur. Though I understand it being low-priority or generally out of scope for the project.
@sparhami That's true, I guess that's the alternative approach to this. Though if you have a cascading async layout it might get less-than-ideal. Although I guess if your site is structured like that you probably have bigger problems...


:bug: Fix mail compose not showing buttons sometimes

Fixes #682
Or at least hopefully, hard to say as it's not easy to reproduce.

based on the docs looks more like something that changed in the past and most likely ios bug behaviour now days. will see what happens
/*
 The behavior of tintColor for bars has changed on iOS 7.0. It no longer affects the bar's background
 and behaves as described for the tintColor property added to UIView.
 To tint the bar's background, please use -barTintColor.
 */
@property(null_resettable, nonatomic,strong) UIColor *tintColor;


Several small improvements to Compactor impl

Start threadpools when service is run, not when it is constructed (and importantly, after metrics have been fully initialized); this ensures that ServerContext, which is created during construction, is available before threadpools and metrics are started
Use Supplier to start lazily load security operation instead of calling abstract impl method in constructor (bad practice)
Remove unneeded second constructor with config overrides (can provide overridden config in test subclass instead)
Remove redundant printStartupMsg (already printed the same details in AbstractServer base class)
Make sure SuccessFulCompactor's close method is called in try-with-resources to remove unclosed resource warning in CompactorTest

One thing I'm not 100% certain about is whether there's any risk of starting these thread pools late, after the service starts up on its port. Is there any risk of these missing important work that came in after the service started, but before these thread pools started? I'm not sure.


Release cycle for rhyslbw/cardano-graphql-hasura

The compose file mentions rhyslbw/cardano-graphql-hasura:v1.0.0-rc.11 which located not in inputoutput dockerhub account https://github.com/input-output-hk/cardano-graphql/blob/master/docker-compose.yml#L46
docker-entrypoint.sh in that that image rhyslbw/cardano-graphql-hasura:v1.0.0-rc.11 (https://hub.docker.com/r/rhyslbw/cardano-graphql-hasura) varies a lot from script mentioned in docker-compose.build in repo https://github.com/input-output-hk/cardano-graphql/blob/master/hasura/docker-entrypoint.sh
The tags on the image itself are created daily, and there's no transparency into what commit/branch triggers the build. Can you please create a tagging policy for images attached to github tags are or at least realeses?

The tagging process can be seen in the Jenkinsfile. The only difference with cardano-graphql-hasura is the dockerhub scope, but that will move over to inputoutput soon. I suggest using the latest release rather than master

The inputoutput org now has the repo, and the most recent release has been pushed.
https://hub.docker.com/repository/docker/inputoutput/cardano-graphql-hasura


[Removal]:

Hotspot Name
Elegant shadow blackbird
Hotspot b58 Address
112j6gsc9NF7xFyt7mJQ8mxJeMTZ6VppE7wfuPjaUVX6TjjfPzYR
Discord Handle
1lamaboy#6484
Hotspot Manufacturer
Cotx
Removal Reason
I just bought this off an eBay user and it is not working. I just checked the cotx app and it is showing up as blacklisted. Please remove if possible.
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information

no longer on the denylist


/ignore for chat and messages

What module should this go under?

This goes under multiple modules - we can do that. So, messages, chat and mail.


Feature/ternary expression js compiler

Addresses issue #437
This PR enables compilation of ternary expressions (i.e. a ? b : c). Known as conditional expression in the babel js parser

Thanks! :)


embedding documentation

This PR just is affecting the documentation and should not interfere with other stuff, I will merge


custom formatting idea: -t,--title FIELDS for a list of fields to format into title line

If I have some log output where one or a few common (and short) fields are typically present and I want to approach one line per log record, then I could use:
... | ecslog -t reqId

to put the reqId field in the title line.   If/when have config file support, this could be a thing to add to custom formats.

A related idea from #15 discussion is:

add a oneline format (title line, then render the rest all on the same line after the message), perhaps with a -1 shortcut flag

Then one could use ecslog -1i reqId to get the above.   This isn't quite the same use case, however.

Perhaps -T for this. I suspect I'll want -t ... for time format options (#17).


When the screen contains emojis, the text font becomes bold.

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

All you have to do is include the emoji on the screen.
Then all the text fonts on the screen become bold (bold).
It only happens on iOS.

The first screen shot is what I intend.
However, problems arise when users use emojis.
A new Flutter version came out, but we haven't been using it for 2 months. because of this problem
Expected results
Normal, font thickness as I developed
Actual results
Depending on whether there are bold letters or emojis, the font thickness will continue to change.
It really hurts the user experience.
Code sample
Code sample
Text(
  'some.text',
  style: TextStyle(
      color: Color.fromRGBO(168, 168, 168, 1),
      letterSpacing: ScreenUtility().width(-0.75),
      fontSize: ScreenUtility().setSp(15),
      fontWeight: FontWeight.w500
  ),
)

Screenshots or Video

Screenshots / Video demonstration

https://github.com/flutter/flutter/assets/19974022/cae2860b-3c55-4d22-85cd-4e4ebe65d7d5

Logs
Logs
There are no logs.

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.10.6, on macOS 13.3.1 22E261 darwin-x64, locale ko-KR)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] IntelliJ IDEA Community Edition (version 2020.2.3)
[✓] VS Code (version 1.73.0)
[✓] Connected device (3 available)
[✓] Network resources

Hi @gjrjf, this was initially reported in https://github.com/flutter/flutter/issues/126514 and has since been fixed on the beta/master channels.
It seems like the change is not possible to CP into the stable branch which is why it has not been done. See https://github.com/flutter/flutter/issues/126514#issuecomment-1592315132.
You will either need to switch to the beta/master channels or disable impeller until the next stable release. See https://github.com/flutter/flutter/issues/126514#issuecomment-1592324167
Closing from here as this has already been fixed on the beta/master channels.
Thank you

3.10.6 is the same issue 🤢

3.10.6 is the same issue


Update Mint Mainnet Launch

Mint Dev Mainnet is Now Live

Duplicate of https://github.com/l2beat/l2beat/pull/3802 .
Mint already added.


Add support for sending lambdas

public class TestClient {
	public static void main(String[] argv) {
		try {
			QuickTask.execute("LocalHost", (Runnable) () -> {
				throw new Error("Test");
			});
		} catch (Exception e) {
			e.printStackTrace();
		}
	}
}

Triggers exception message on the server:
Jan 25, 2016 9:38:41 PM com.googlecode.mobilityrpc.session.impl.MobilitySessionImpl receiveIncomingExecutionRequest
SEVERE: Unexpected exception processing execution task, for connection id: <IP_ADDRESS>:64933:0, execution request: ExecutionRequest{serializedExecutableObject=111 bytes, serializationFormat=KRYO, executionMode=RETURN_RESPONSE, requestIdentifier=RequestIdentifier{sessionId=4aa76093-2798-425f-9dbc-07131e49f1dc, requestId=c41303bd-08e2-4127-8ee5-38eac2ac9e70, requestLabel='<no label>'}}
java.lang.IllegalStateException: Failed to process execution request, for connection id: <IP_ADDRESS>:64933:0, execution request: ExecutionRequest{serializedExecutableObject=111 bytes, serializationFormat=KRYO, executionMode=RETURN_RESPONSE, requestIdentifier=RequestIdentifier{sessionId=4aa76093-2798-425f-9dbc-07131e49f1dc, requestId=c41303bd-08e2-4127-8ee5-38eac2ac9e70, requestLabel='<no label>'}}
	at com.googlecode.mobilityrpc.session.impl.MobilitySessionImpl.receiveIncomingExecutionRequest(MobilitySessionImpl.java:371)
	at com.googlecode.mobilityrpc.protocol.processors.impl.ExecutionRequestMessageProcessor.process(ExecutionRequestMessageProcessor.java:39)
	at com.googlecode.mobilityrpc.protocol.processors.impl.ExecutionRequestMessageProcessor.process(ExecutionRequestMessageProcessor.java:31)
	at com.googlecode.mobilityrpc.controller.impl.MobilityControllerImpl$MessageProcessorTask.processMessage(MobilityControllerImpl.java:128)
	at com.googlecode.mobilityrpc.controller.impl.MobilityControllerImpl$MessageProcessorTask.run(MobilityControllerImpl.java:108)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.IllegalStateException: Exception deserializing object from 111 bytes data in KRYO format
	at com.googlecode.mobilityrpc.session.impl.MobilitySessionImpl.deserialize(MobilitySessionImpl.java:514)
	at com.googlecode.mobilityrpc.session.impl.MobilitySessionImpl.receiveIncomingExecutionRequest(MobilitySessionImpl.java:295)
	... 9 more
Caused by: com.esotericsoftware.kryo.KryoException: Unable to find class: TestClient$$Lambda$1/1599771323
Serialization trace:
wrapped (com.googlecode.mobilityrpc.quickstart.QuickTask$SessionReleasingRunnable)
	at com.esotericsoftware.kryo.util.DefaultClassResolver.readName(DefaultClassResolver.java:156)
	at com.esotericsoftware.kryo.util.DefaultClassResolver.readClass(DefaultClassResolver.java:133)
	at com.esotericsoftware.kryo.Kryo.readClass(Kryo.java:670)
	at com.esotericsoftware.kryo.serializers.ObjectField.read(ObjectField.java:118)
	at com.esotericsoftware.kryo.serializers.FieldSerializer.read(FieldSerializer.java:551)
	at com.esotericsoftware.kryo.Kryo.readClassAndObject(Kryo.java:790)
	at com.googlecode.mobilityrpc.serialization.impl.KryoSerializer.deserialize(KryoSerializer.java:88)
	at com.googlecode.mobilityrpc.session.impl.MobilitySessionImpl.deserialize(MobilitySessionImpl.java:508)
	... 10 more
Caused by: java.lang.ClassNotFoundException: TestClient$$Lambda$1/1599771323
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Unknown Source)
	at com.esotericsoftware.kryo.util.DefaultClassResolver.readName(DefaultClassResolver.java:154)
	... 17 more

However, if a formal inheritance class is made like the test code in #11, then the error is gone.

Sending Java 8 lambdas to remote machines is not officially supported yet. At the moment Mobility-RPC targets Java 6 and later, but some newer language features are not guaranteed to work.
I'm going to rename this issue to Add support for sending lambdas, as I want to add support for this.

Hi, I have in the past investigated serialization of lambdas. It basically works out of the box if Java serialization is used and the interface that the lambda is implementing is serializable. So the probable solution to this is to allow the user of Java serialization instead of Kryo.

The other solution is to enable lambda serialization in Kryo: https://github.com/magro/kryo/blob/bf803974ba6351d993093636aac00245f1ec28bc/test/com/esotericsoftware/kryo/serializers/Java8ClosureSerializerTest.java#L52
This could be done with reflection to prevent a dependency on Java8.

I'm not too concerned about Java 6 compatibility anymore. And I think Java 8 lambdas are quite a natural way to send tasks to remote machines.
@BrynCooke I like the second option, to enable Java 8 closure support in Kryo. If you have time to try that out by modifying the KryoSerializer class in mobility-rpc and testing locally, it would help. I'm totally open to merging pull requests which would help with this!
The main challenge I can envisage is that currently the mobility-rpc protocol supports sending only Runnable or Callable objects. Any other type of object to be sent (including lambdas) need to be wrapped in one of these. So the easiest solution if we want to send a lambda, is to write a helper method which wraps the lambda in a Runnable or Callable object. If this is possible then it should not be a problem to send a lambda.

Thanks, I'll create a PR.


Add authenticated check for Follows you

Fixes #1418
Changes:

add authenticated check for Follows you

I can't reproduce this problem. I'm not logged in and I can't make "Follows you" to display in any way (on production and staging as well).

Did you tried on mobile @Sekhmet ?

Doesn't happen for me on mobile as well. Should I visit user profile page directly or by navigating there using links? Neither causes problem for me.

@Sekhmet Its happening for me right now on staging

it happens when you directly go to the page sometimes

@Sekhmet good idea, just updated

As I can't reproduce I'm just guessing, but it wouldn't be better to set isFollowing to false by default and never check if user is following you, if you are not authenticated?

So this happens when you login and logout, and move around, looks like @bonustrack is experiencing it too on mobile - https://github.com/busyorg/busy/issues/1456
I updated it, I forgot why I was using a null check there, but could've been with something in the past, that is now fixed. Refactored it.


Reword announcement to focus less on the HP

The tone was a bit negative (and redundantly so!). There are plenty of entirely forward-looking reasons to kick off a new initiative.

Great improvement!


KAFKA-8126: Fix flaky tests in WorkerTest

What changes were proposed in this pull request?
Fix flaky test cases in WorkerTest by mocking the ExecutorService in Worker.  Previously, when using a real thread pool executor, the task may or may not have been run by the executor until the end of the test.
Related JIRA issues:

KAFKA-8126
KAFKA-8063
KAFKA-5141

How was this patch tested?
Ran all tests (./gradlew test).
Ran unit tests in connect/runtime repeatedly.

@mjsax @guozhangwang can you please review?

@rhauch could you please review?

Thanks @rhauch for reviewing and merging it.


Support reading 1.5.1 files

Implemented reading of 1.5.1 archives
Added RSA keys for Dirt 1-3, RD:Grid, Grid 2, F1 2010-2014 and a loop to cycle through the keys on reading to find the right one for each file
Fixed bug in Stream CopyPartialAsync extension where it would not throw if it tried to read past the stream end

Additional game archive versions to add to the wiki:

Game
Version

RD:Grid
1.4

Dirt 2
1.5.1

F1 2010
1.5.1

F1 2011
1.5.1

F1 2012
1.5.1

Dirt Showdown
1.6

F1 2013
1.6

F1 2014
1.6

F1 2015
1.6

F1 2016
1.6

F1 2019
1.6

Grid 2
1.6

Grid Autosport
1.6

010 Editor Binary Template:
https://github.com/EgoEngineModding/Ego-Engine-Modding/blob/master/src/010 Templates/nfs1.5.bt

There are two existing tests that are failing due to the bug fix to the stream extension. I wasn't sure how to fix it since I'm not familiar with the nefs writer code yet. Would appreciate if you can look into that. Otherwise this is ready to go.

Sorry for the late response on this; thanks for this PR! Looks like the failing tests were due to bad test data/cases going unnoticed prior to your fix for CopyPartialAsync. I can work on fixing those tests.


[TACHYON-626] Add a check for NULL metaDataManager

https://tachyon.atlassian.net/browse/TACHYON-626

This means the allocators and evictors don't need to do the check again, right? If so, the check should be removed from the individual allocators and evictors.

fine, my thought was that it won't hurt to check again but I will remove the check

We can’t automatically merge this pull request.

rebased from master, merge conflict resolved

Looks good overall, minor style comment.

+1 LGTM

+1 LGTM. though this PR will conflict with a few pending PRs --- so depending on the merge order, we need to resolve conflicts carefully to avoid regression.

thanks for speedy approval!

Thanks @miasantreble  :)


Fix race in shot profiles

Coverage decreased (-0.03%) to 92.203% when pulling c12b5b32296405df8586ae6ac24d59b20a1de7a1 on fix_race_in_shot_profiles into 8cf891d05be1e92e56bc480ff567a2a8f8734a18 on dev.


Tools/show sofaload diff

Issues associated with this PR
Your PR should present related issues you want to solve.
Sign the CLA
Make sure you have signed the CLA
Solutions
You should show your solutions about the issues in your PR, including the overall solutions,
details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases.
And you need to show the ut result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result
Code Style

Make sure Goimports has run
Show Golint result

i do not understand what is this


[Event Request] Application “Tests-Report”, Codeunit 134761 "Test Custom Reports"

[Event Request] Application “Tests-Report”, Codeunit 134761 "Test Custom Reports"

Could you please insert the OnTestInitialize Event at the beginning of the procedure Initialize?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Rename job_wrapper module

Some people say this import line is confusing from job_wrapper.call import call_job:

https://github.com/TheRacetrack/plugin-python-job-type/blob/master/sample/python-chain/entrypoint.py#L3
https://github.com/TheRacetrack/racetrack/blob/master/sample/python-chain/entrypoint.py#L3

job_wrapper is a mysterious package. It looks like it's a third-party lib installed from PyPI, while in fact, it's an internal package used by a job type plugin. Maybe it should be called racetrack_job_wrapper to fit in the other imports scheme from racetrack_commons import ..., from racetrack_client import ... to indicate a relationship with the racetrack ecosystem.

+1 for racetrack_job_wrapper


Enum in string interpolation uses integer value instead of name

Bug Report
Latest nightly (as of creating this issue) has this issue. Crystal v1.10.1 does not.
The following code:
enum Test
  Foo
end

puts "#{Test::Foo}"
puts Test::Foo

In the latest nightly produces:
0
Foo

and in v1.10.1:
Foo
Foo

This regression was introduced by #12671


fix most of the docstring errors

I made some minor changes to hopefully fix some docstrings in readthedocs

@ajshajib I expected that the pre-commit is formatting the lines to fulfill the PEP8 standards with black, or I am missing something?

@sibirrer, that's what it's expected to do, yes. But, it doesn't always work perfectly, unfortunately, particularly docformatter for docstring formatting. The black formatter itself works very well in my experience, but it only works on the code lines, not the docstrings. So, we still have to keep an eye out for blemishes. One reason the docformatter could break, is when it sees an unexpected way the docstring is laid out.  For example, the expected Sphinx option is :return: and not :returns:.


Problem on interception of fetch requests

Before you file a bug, have you:

Tried upgrading to newest version of PuppeteerSharp, to see if your issue has already been resolved and released? Yes
Checked existing open and closed issues, to see if the issue has already been reported? Yes
Tried reproducing your problem in a new isolated project? Yes
Considered if this is a general question and not a bug?. For general questions please use StackOverflow. Yes

Description
I am trying to intercept fetch requests from a web page to block them and decrease network usage.
Complete minimal example reproducing the issue
Browser browser = await Puppeteer.LaunchAsync(new LaunchOptions()
{
    Headless = false,
    Args = new string[]
    {
        "--incognito"
    },
    IgnoreHTTPSErrors = true
});

Page webPage = (await browser.PagesAsync())[0];

await webPage.SetCacheEnabledAsync(false);
await webPage.SetViewportAsync(new ViewPortOptions()
{
    Width = 1366,
    Height = 768
});
await webPage.SetUserAgentAsync("Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36'");

await webPage.SetRequestInterceptionAsync(true);
webPage.Request += WebPage_Request;

private async void WebPage_Request(object sender, RequestEventArgs e)
{
    List<string> imageFormats = new List<string>()
    {
        ".jpg",
        ".png",
        ".gif",
        ".svg"
    };
    List<string> videoFormats = new List<string>()
    {
        ".mp4",
        ".avi",
        ".flv",
        ".mov",
        ".wmv"
    };

    if (e.Request.ResourceType == ResourceType.Image || e.Request.ResourceType == ResourceType.Media || e.Request.ResourceType == ResourceType.Img || e.Request.ResourceType == ResourceType.StyleSheet || e.Request.ResourceType == ResourceType.Font)
    {
        await e.Request.AbortAsync();
        return;
    }
    else if (e.Request.Url.ToLower().Contains("google") ||
        e.Request.Url.ToLower().Contains("ads") ||
        e.Request.Url.ToLower().Contains("antiadblocksystems") ||
        e.Request.Url.ToLower().Contains("stats") ||
        e.Request.Url.ToLower().Contains("run-syndicate"))
    {
        await e.Request.AbortAsync();
        return;
    }

    string requestFormat = e.Request.Url.Split('.').Last().Split('?')[0];

    if (!string.IsNullOrEmpty(requestFormat))
    {
        if (imageFormats.Contains($".{requestFormat}") ||
            videoFormats.Contains($".{requestFormat}"))
        {
            await e.Request.AbortAsync();
            return;
        }
    }

    if (e.Request.ResourceType == ResourceType.Fetch)
    {
        Console.WriteLine("Fetch request intercepted");
    }

    await e.Request.ContinueAsync();
}

Expected behavior:
I expect the console's log line when i get a fetch request.
Actual behavior:
Browser ignores fetch requests and i can not intercept them. A lot of images (21 MB) gets loaded via fetch and i can not block them.
Versions

Which version of PuppeteerSharp are you using? 4.0.0
Which .NET runtime and version are you targeting? .NET 5.0

https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-setBlockedURLs
await page.Client.SendAsync("Network.setBlockedURLs", new Dictionary<string, object>
{
    ["urls"] = new string[]
    {
        // image formats
        "*.jpg", "*.png", "*.gif", "*.svg",
        // video formats
        "*.mp4", "*.avi", "*.flv", "*.mov", "*.wmv",
    },
}).ConfigureAwait(false);

Check out this upstream ticket: https://github.com/puppeteer/puppeteer/issues/4695
If the request is coming from a worker, interception is not currently possible.


Support Alpine Click Handler via modifier

Description
Adds support for calling alpineClickHandler() directly on an Action instead of having to override getAlpineClickHandler()
Action::make('test')
    ->alpineClickHandler(fn () => alert('Hello World'))

I've coined this idea multiple times in the past, but IIRC Dan wasn't a big fan of it.
I do agree it's needed though, but I'm not sure about the naming.

He told me the other day he would accept a PR for it.


Style recommendations

Purpose
Style recommendations to make code more Pythonic
Does this introduce a breaking change?
I hope not :) I haven't tried to get it all running, however.
Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[X] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test
Probably following the README. I'm hoping it's easy for you to test.

@diberry Suggestions/comments for you! One overall observation is that there is a lot of logging. I wonder if all that logging is actually helpful, or if some can be removed. Up to you since logging can help someone debug something not working, but generally, in production code, we probably wouldn't want that much logging since it incurs storage and CPU costs. Also doubles the length of code. I typically only have logging if I'm debugging something and that's the only way to see what's happening.


Various fixes for Exporting a certificate

Created a few fixes for exporting a certificate

Mask CertficateData property in Write-VerboseWithSecret. Resolves #25.
Add IncludeChain support for JKS in Export-VenafiCertificate. Fixes #24.
Add IncludePrivateKey support for JKS in Export-VenafiCertificate. I think this fixes #26).
Update Export-VenafiCertificate example to correct function name.

@gdbarron - thanks for the feedback. I think I've updated it all now. My re-tests look good too :+1:


How to use nested key as the join field

Hi all, wondering if someone could point me in the right direction? I have the following ReQL explorer command:
r.db('demo').table('employee').eqJoin(r.row('extras')('company_id'), r.db('demo').table("company")).zip()

Struggling a bit to translate that, i.e., joining on a nested key: r.row('extras')('company_id')
From the docs:

Note that Row does not work within subqueries to access nested documents; you should use anonymous functions to access those documents instead

Any help would be appreciated.

This seemed to work, simply chaining .Field.
Jotting this down in case it helps someone else.
cur, err := r.DB("demo").Table("employee").EqJoin(r.Row.Field("extras").Field("company_id"),
		r.DB("demo").Table("company")).Zip().Run(session)


Version 4.5.0 breaks percentage cropping

When using a predefined crop in Umbraco, it generates a URL like this: http://localhost:1823/media/1019/loebere-paa-strand.jpg?crop=0.020427188497102129,0,0.72831839298854173,0.6610013498588786&cropmode=percentage&width=246&height=221&rnd=130975950450000000
This works fine with ImageCropper.Web 4.4, but breaks with 4.5. It throws an ArgumentException in the Crop processor. And debugging, it is quite understandable why:
0.020427188497102129 in the URL somehow becomes a huge negative value (2.04271887E+16). THe bug seems to lie in the class GenericConvertableConverter, on this line:
return (T)Convert.ChangeType(value, t);
In short, it seems there has been some change regarding the parsing of float values, as that is where the issue comes from. In particular, commit 189908982cd1ddcec7bccd76d99d0266403779ca seems to be the problematic one.

I have a hypothesis that this is happening because I'm running on a system with da-DK culture. As no culture is passed into the ChangeType method, it uses the system culture. Hence it works on en-US system, but breaks in locales where we use comma as decimal separator. I'm testing this now - will produce a PR if this fixes it.

Yep, ammending the line by passing in the culture fixes the issue:
return (T)Convert.ChangeType(value, t, culture);

PR is here: https://github.com/JimBobSquarePants/ImageProcessor/pull/306

Thanks. Fixed


Effect Editor crash after editing parameters and deleting

Severity: Minor crash
Using RWE+ version 2.1.3
Steps to replicate:

Open any DP Leditor room file
Enter Effects editor
Select a effect already existing in the level or add a new one
Edit any parameter of it
Click "Delete effect from project(e)"
|> RWE+ Closes with the following error:

Expected Behavior:

Open any leditor room file
Enter Effects editor
Select a effect already existing in the level or add a new one
Edit any parameter of it
Click "Delete effect from project(e)"
|> Effect successfully gets removed from the project

Additional notes:

Not every effect or parameter seems to be causing this crash and I havent noticed it in non DP files yet. What I found consistant however was taking any plant like "Seed Pod" and changing the color
I tested 5 different files, 3 in DP leditor SU and 2 that came with RWE with all possible parameters on both a few plants and slime and rain moss. Only plants showed positive for the crash from what I could tell, there could be more
I havent submitted many GitHub issues before, if you have any criticism on how I can provide more helpful information feel free to let me know!

found issue
working on fix


PR 24 (filter fn) slows down SimpleIndexer to a complete crawl

Consider this
from tempfile import TemporaryDirectory
from time import perf_counter

import numpy as np
from jina import Document, DocumentArray, Flow

DIM = 128
VERSION = "0.7"
index_docs = DocumentArray(
    [Document(embedding=np.random.rand(DIM)) for _ in range(100_000)]
)
search_docs = DocumentArray(
    [Document(embedding=np.random.rand(DIM)) for _ in range(10_000)]
)

with TemporaryDirectory() as tmpdir:
    f = Flow().add(
        uses=f'jinahub://SimpleIndexer/v{VERSION}', uses_metas={'workspace': tmpdir}
    )
    with f:
        f.index(index_docs)

        t = perf_counter()
        f.search(search_docs)
        print(perf_counter() - t)

Here are the results from timing

version 0.7: 320
version 0.6: 32

we get a 10x slowdown! And I think this scales quadratically with size (for 10x smaller data the slowdown is ~3x). Therefore, for a million documents we have a 100x slowdown - completely unacceptable.
This is due to filter_fn introduced in https://github.com/jina-ai/executor-simpleindexer/pull/24. I think we need to immediately revert this PR and then move filtering to index time or the like

@tadejsv We are aware of the slow down when introducing this PR. But currently there's no way for us to validate the index docs since filtering cannot be done at index time as it does not have information such as traversal_paths. The original intention for this during refactoring as discussed was that SimpleIndexer should not be processing docs and traversing but should delegate this responsibility to Jina core.

I think we need to immediately revert this PR and then move filtering to index time or the like

I think this would very unsafe. One broken doc indexed could break the SimpleIndexer. Until we move filtering to index time, we should keep this for now.

@tadejsv We are aware of the slow down when introducing this PR. But currently there's no way for us to validate the index docs since filtering cannot be done at index time as it does not have information such as traversal_paths. The original intention for this during refactoring as discussed was that SimpleIndexer should not be processing docs and traversing but should delegate this responsibility to Jina core.

I think we need to immediately revert this PR and then move filtering to index time or the like

I think this would very unsafe. One broken doc indexed could break the SimpleIndexer. Until we move filtering to index time, we should keep this for now.

But u can do the filtering at index time urself.

@tadejsv  @JoanFM
I would like to elaborate on why I think having filtering is important and why it's not the best to immediately revert the PR without having any safeguards.
Imagine we have a flow with Downloader in it - a common use case. And we implement Downloader like the following:
class Downloader(Executor):
    @requests
    def download(self, docs: DocumentArray, **kwargs):
        for doc in docs:
            try:
                doc.convert_uri_to_buffer()
            except Exception:
                pass

However, URL download failure is very common problem. We can work around the problem by creating a new copy of new_docs,  appending only the docs with embeddings/blob/buffer and return new_docs. But this is not an obvious thing to do and users will forget. Performance may also be affected as a result. So it's very common for docs to have docs with no content/embedding when it's returned from the Downloader and when it is passed to SimpleIndexer. And this happens time after time in showcases/eaps. And without filtering this can be very dangerous. Even one invalid doc that gets added to index can break all subsequent searches.
I think the current filtering logic can be optimized and it would be great if we can move it to index time. However, when I repeated the above experiment and measured the time it takes to search 100 docs with 100000 indexed docs, the total time it takes is 2.2 seconds.  I don't think it's unusable or "completely unacceptable", given that downloading data from a few doc uris for searching could easily take more time than that. And we usually don't need to search for 100 docs with 100000 index docs from the eaps/showcase I have worked with. I think the real case when SimpleIndexer becomes unusable is when it cannot return any search results.

But u can do the filtering at index time urself.

But then in this case user will need to implement a Filter executor every time if they use SimpleIndexer which could be mentally taxing? And if we decide to implement an external filter logic, later when we actually move the filter logic to index time inside SimpleIndexer as this is necessary, then we won't need the external filter logic anymore and will have remove it again?
Can we do better with performance? Yes absolutely. But is it worth removing all safeguards just to revert this PR?
I am saying this is because docs with broken embedding gives us a lot of headaches in production.

I think the current filtering logic can be optimized and it would be great if we can move it to index time. However, when I repeated the above experiment and measured the time it takes to search 100 docs with 100000 indexed docs, the total time it takes is 2.2 seconds. I don't think it's unusable or "completely unacceptable", given that downloading data from a few doc uris for searching could easily take more time than that. And we usually don't need to search for 100 docs with 100000 index docs from the eaps/showcase I have worked with. I think the real case when SimpleIndexer becomes unusable is when it cannot return any search results

You are missing the point. The total time here does not matter, I listed it only as an illustration of how much slower SimpleIndexer became. Index and search time are also not really related. Note that also SimpleIndexer is much slower on single requests than it is if you batch requests - but the real-life use case for search is single requests.
We care about the following: how many queries per second, with queries coming in as search requests with one document, can the indexer handle. According to the benchmarking we did, SI was already at the bottom of the list, and even for smaller sizes of the dataset it is already struggling (e.g. for 200k docs it can process 7 queries per second for embedding of dim 128, and only 2 for embedding of dim 960). For comparison - our best performing indexer (hnsw) was processing 100 queries per second with 1 million documents indexed.
Now, with filtering added SimpleIndexer is let's say 10x slower - this makes it completely unusable, nobody will want a service where you have to wait a couple of seconds for search results to appear.
So then Simpleindexer would be usable only for cases with up to 10k documents in the index. Do we want this? What about scaling? Do we want to present and promote a produce that can not scale at all?

I am saying this is because docs with broken embedding gives us a lot of headaches in production.

Why did you not implement filtering of documents (using new_docs)? You say that users might forget about it - well, but you are professionals, and you seem to have thought about this a lot, if you decided that implementing filtering in SimpleIndexer was the best option. So why did you decide not to implement filtering at source - surely it would save you all the headaches that you had, and would be simpler than changing the whole infrastructure?

@winstonww ur concern is totally valid, but I think the performance degradation is big enough to not be part of default.
Have u checked the memory consumption when using filter and when not?
Could it make sense to have a cache of DAM searched for with the filter already passed? This would be invalidated at every index call but it could speed up the common case of index once search many times?
This cache could be per traversal paths and may be a good speed up at some potential memory consumption loss

@tadejsv

Do we want to present and promote a product that can not scale at all?

No, but we also want the product to be resilient. It's not fun to have to stop, clear the DAM and restart a service every time because of a single download failure.

nobody will want a service where you have to wait a couple of seconds for search results to appear

If we are searching images/3d models/audio and this is bound to happen at the moment because downloading the search data usually takes way longer.

well, but you are professionals,

SimpleIndexer is designed for everyone to use. It is meant also for beginners who just started out their way in Jina. If performance is the priority, then obviously we can go for faster indexers.
@JoanFM  I see your point, and will think about the alternatives suggested.

I agree with @tadejsv that it should be the job of upstream to guarantee as much as possible that the Documents are ready to be processed / stored.
We can also have this filter but I'd say we should make it a toggle-able feature. Like discussed here

@winstonww so I would still like to know - why didn't you go the way of filtering documents at source in your deployments?

@cristianmtr  @tadejsv
Aside from the inconvenience that we will have to warn community members clearly that if they wanted to use SimpleIndexer with preprocessors they built themselves they will have to ensure that all inputs provided to SimpleIndexer have to be valid otherwise it would result not just in a one-time crash but a permanent unrecoverable crash which signifies SimpleIndexer is error-prone, there are also other reasons as follows.
If we look at the executors in the Flow, most of the stateless executors and can still function correctly afterwards when they see invalid inputs. But for indexers, one invalid input can result in permanent damage. I would also argue that we want to err on the side of caution, we should be defensive at the most vulnerable stage of the pipeline. (i.e. the SimpleIndexer).
If we don't apply filtering at indexer, the current situation is that even one single uncaught exception at index/update from upstream can bring down the simple indexer permanently.  My understanding is that, each micro service should be resilient and should not be permanently brought down due to failure of other microservices. Otherwise, this becomes monolithic and services are highly coupled. If we look at most executors in the hub, we don't see something like the new_docs method applied to filter out invalid docs.  We also don't wrap each executor with a big try... catch Exception phrase to ensure no uncaught exception at all occurs (this is also dangerous and I am not suggesting we should do it).
It's always good to minimizes failure/errors upstream, but from the eaps/solutions I have worked with it may cause us trouble if we take this assumption for granted especially when component is vulnerable to permanently damage.

vulnerable to permanently damage.

It's only SI that can accept a doc of a diff emb shape that the existing vectors.
So there are two problems here:

no embeddings present in doc

SI will accept this, can NOT recover
other indexers will not accept this at all BUT the entire batch operation will fail; they continue to be operational

wrong embedding shape

SI will accept this, and can NOT recover
other indexers will not accept this at all BUT the entire batch operation will fail; they continue to be operational

Am I right here?
If so, I propose

a filter fn to catch and remove these (True by default, that can be toggled off per request or per indexer at init time)

SI will accept this, and can NOT recover
Yes if we revert the PR


sort: separate additional data from the Line struct

Data that was previously boxed inside the Line struct was moved to
separate vectors. Inside of each Line remains only an index that
allows to access that data.
This helps with keeping the Line struct small and therefore reduces
memory usage in most cases.
Additionally, this improves performance because one big allocation (the
vectors) are faster than many small ones (many boxes inside of each
Line). Those vectors can be reused as well, reducing the amount of
(de-)allocations.

Some benchmarks showing improvements

Sorting a 1.2M wordlist
Benchmark #1: target/release/sort shuffled_wordlist.txt
  Time (mean ± σ):      14.1 ms ±   0.4 ms    [User: 66.6 ms, System: 5.1 ms]
  Range (min … max):    13.5 ms …  15.9 ms    170 runs

Benchmark #2: ./oldsort shuffled_wordlist.txt
  Time (mean ± σ):      14.5 ms ±   0.4 ms    [User: 62.3 ms, System: 4.8 ms]
  Range (min … max):    13.7 ms …  16.8 ms    183 runs

Benchmark #3: sort shuffled_wordlist.txt
  Time (mean ± σ):      26.4 ms ±   1.0 ms    [User: 24.2 ms, System: 2.2 ms]
  Range (min … max):    25.6 ms …  34.8 ms    106 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet PC without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

Summary
  'target/release/sort shuffled_wordlist.txt' ran
    1.03 ± 0.04 times faster than './oldsort shuffled_wordlist.txt'
    1.87 ± 0.09 times faster than 'sort shuffled_wordlist.txt'

Sorting a 576K list of numbers (1 to 100000)

hyperfine "target/release/sort shuffled_numbers.txt -n" "./oldsort shuffled_numbers.txt -n" "sort shuffled_numbers.txt -n"
Benchmark #1: target/release/sort shuffled_numbers.txt -n
  Time (mean ± σ):      15.7 ms ±   0.4 ms    [User: 76.6 ms, System: 5.9 ms]
  Range (min … max):    14.9 ms …  16.9 ms    168 runs

Benchmark #2: ./oldsort shuffled_numbers.txt -n
  Time (mean ± σ):      25.0 ms ±   0.6 ms    [User: 79.1 ms, System: 6.8 ms]
  Range (min … max):    24.0 ms …  27.3 ms    110 runs

Benchmark #3: sort shuffled_numbers.txt -n
  Time (mean ± σ):      31.5 ms ±   0.6 ms    [User: 30.3 ms, System: 1.3 ms]
  Range (min … max):    30.7 ms …  34.9 ms    81 runs

Summary
  'target/release/sort shuffled_numbers.txt -n' ran
    1.60 ± 0.06 times faster than './oldsort shuffled_numbers.txt -n'
    2.01 ± 0.06 times faster than 'sort shuffled_numbers.txt -n'

This shows a performance improvement of about 60% in comparison to before this patch.
Please note that performance in comparison to GNU sort varies depending on the size of the file, as can be seen below:
Sorting a 76M list of numbers (1 to 10000000)
hyperfine "target/release/sort shuffled_numbers.txt -n" "./oldsort shuffled_numbers.txt -n" "sort shuffled_numbers.txt -n"
Benchmark #1: target/release/sort shuffled_numbers.txt -n
  Time (mean ± σ):      3.213 s ±  0.065 s    [User: 30.983 s, System: 0.155 s]
  Range (min … max):    3.140 s …  3.343 s    10 runs

Benchmark #2: ./oldsort shuffled_numbers.txt -n
  Time (mean ± σ):      4.889 s ±  0.060 s    [User: 30.456 s, System: 0.228 s]
  Range (min … max):    4.840 s …  5.040 s    10 runs

Benchmark #3: sort shuffled_numbers.txt -n
  Time (mean ± σ):      2.354 s ±  0.043 s    [User: 8.934 s, System: 0.286 s]
  Range (min … max):    2.309 s …  2.454 s    10 runs

Summary
  'sort shuffled_numbers.txt -n' ran
    1.37 ± 0.04 times faster than 'target/release/sort shuffled_numbers.txt -n'
    2.08 ± 0.05 times faster than './oldsort shuffled_numbers.txt -n'

This patch makes if faster, but GNU sort still has a performance advantage.
Sorting a 76M list of numbers (1 to 10000000) (human-numeric sort)
hyperfine "target/release/sort shuffled_numbers.txt -h" "./oldsort shuffled_numbers.txt -h" "sort shuffled_numbers.txt -h"
Benchmark #1: target/release/sort shuffled_numbers.txt -h
  Time (mean ± σ):      3.217 s ±  0.045 s    [User: 30.818 s, System: 0.159 s]
  Range (min … max):    3.129 s …  3.264 s    10 runs

Benchmark #2: ./oldsort shuffled_numbers.txt -h
  Time (mean ± σ):      4.913 s ±  0.069 s    [User: 30.492 s, System: 0.228 s]
  Range (min … max):    4.850 s …  5.053 s    10 runs

Benchmark #3: sort shuffled_numbers.txt -h
  Time (mean ± σ):      3.074 s ±  0.088 s    [User: 12.932 s, System: 0.288 s]
  Range (min … max):    3.000 s …  3.302 s    10 runs

Summary
  'sort shuffled_numbers.txt -h' ran
    1.05 ± 0.03 times faster than 'target/release/sort shuffled_numbers.txt -h'
    1.60 ± 0.05 times faster than './oldsort shuffled_numbers.txt -h'

As above, you can clearly see the improvement from this patch, but we don't fully reach GNU's performance. While we can't claim to be faster than GNU, we are clearly competitive. Who's faster depends on the individual workload and even the hardware used. Just for fun, below are the two benchmarks from above, but running from my hdd instead of my ssd.  This could be caused by (filesystem) caches that were not filled until after the first run. You should consider using the '--warmup' option to fill those caches before the actual benchmark. Alternatively, use the '--prepare' option to clear the caches before each timing run.

Summary
  'target/release/sort -h /mnt/hdd1/tmp/shuffled_numbers.txt -T/mnt/hdd1/tmp' ran
    2.17 ± 0.16 times faster than 'sort shuffled_numbers.txt -h /mnt/hdd1/tmp/shuffled_numbers.txt -T/mnt/hdd1/tmp'
    4.00 ± 0.09 times faster than './oldsort shuffled_numbers.txt -h /mnt/hdd1/tmp/shuffled_numbers.txt -T/mnt/hdd1/tmp'

Sorting a 76M list of numbers (1 to 10000000) (general-numeric sort)
Finally, we're significantly faster even with bigger files when doing a general-numeric sort (now even more than before):
hyperfine "target/release/sort shuffled_numbers.txt -g" "./oldsort shuffled_numbers.txt -g" "sort shuffled_numbers.txt -g"
Benchmark #1: target/release/sort shuffled_numbers.txt -g
  Time (mean ± σ):      2.214 s ±  0.058 s    [User: 13.472 s, System: 0.127 s]
  Range (min … max):    2.164 s …  2.348 s    10 runs

Benchmark #2: ./oldsort shuffled_numbers.txt -g
  Time (mean ± σ):      4.167 s ±  0.040 s    [User: 16.939 s, System: 0.216 s]
  Range (min … max):    4.121 s …  4.249 s    10 runs

Benchmark #3: sort shuffled_numbers.txt -g
  Time (mean ± σ):      4.639 s ±  0.064 s    [User: 21.838 s, System: 0.279 s]
  Range (min … max):    4.548 s …  4.747 s    10 runs

Summary
  'target/release/sort shuffled_numbers.txt -g' ran
    1.88 ± 0.05 times faster than './oldsort shuffled_numbers.txt -g'
    2.10 ± 0.06 times faster than 'sort shuffled_numbers.txt -g'

Impressive benchmarks!


Adds BLM banner

Summary
Adds a Black Lives Matter banner like other OSS projects of the React family
Test Plan
Local tests
cd website
yarn
yarn start

Screenshots

@yangshun I have no idea how to add a banner above the navbar. Is this possible with a declarative config like the one we have here in ?

Thank you @kedromelon!

@claudiopro you can use the announcement bar feature.
An example PR - https://github.com/facebookexperimental/Recoil/pull/241

Thank you @yangshun, I'll look into this today!

Because of this change, the site became inaccessible
What happened to links

It is hard to see links.


Fan accessory (Vornado Transom) recognised by plugin but not in Home app.

Describe Your Problem:
Hi Joey! Very excited for the new fan support. Thanks for all your work on this.
Getting my new Vornado Transom fan set up, I'm running into an odd issue: The fan accessory is recognized and is available in the Homebridge Accessories list, and can be turned on/off through the Homebridge web UI. However, the device is not appearing in the Apple Home app, or any other HomeKit frontends (Eve, Home+).
I've turned on plugin debugging, and the following output from the plugin comes out on start-up. Not sure if there's any subtle issue with the config data that would be preventing it being picked up outside of Homebridge?
Let me know if there are further debugging steps I can take to extract more info. Thanks!

I've verified that it's not appeared in the “Default Room”.
I also tried renaming the accessory from “Extractor Fan” to “Extractor”, to eliminate the chance that there was confusion from the accessory type also being in the name, or from having spaces in the device name

Logs:
[2/15/2024, 11:31:42 AM] [HomebridgeAlexaSmartHome] Extractor Fan ::: Attempting to add accessory(s) for device: {
  "id": "<UUID>",
  "displayName": "Extractor Fan",
  "description": "Vornado Transom",
  "supportedProperties": [
    "turnOff@<UUID>_4",
    "turnOff",
    "turnOn",
    "setModeValue@<UUID>_2",
    "setModeValue@<UUID>_1",
    "setRangeValue@<UUID>_3",
    "turnOn@<UUID>_4"
  ],
  "supportedTriggers": [],
  "supportedOperations": [
    "turnOff@<UUID>_4",
    "turnOff",
    "turnOn",
    "setModeValue@<UUID>_2",
    "setModeValue@<UUID>_1",
    "setRangeValue@<UUID>_3",
    "turnOn@<UUID>_4"
  ],
  "availability": "AVAILABLE",
  "icon": {
    "@iconType": "SmartHomeApplianceType",
    "value": "FAN"
  },
  "providerData": {
    "enabled": true,
    "relationships": [],
    "categoryType": "APPLIANCE",
    "deviceType": "FAN",
    "dmsDeviceIdentifiers": [
      {
        "deviceSerialNumber": "<SERIAL>",
        "deviceType": "A1AZ0VKGUB06NH"
      }
    ]
  }
}

[2/15/2024, 11:31:42 AM] [HomebridgeAlexaSmartHome] Extractor Fan ::: Current state: [
  {
    "namespace": "Alexa.ToggleController",
    "name": "toggleState",
    "value": "OFF",
    "instance": "4"
  },
  {
    "namespace": "Alexa.ModeController",
    "name": "mode",
    "value": "0",
    "instance": "2"
  },
  {
    "namespace": "Alexa.ModeController",
    "name": "mode",
    "value": "0",
    "instance": "1"
  },
  {
    "namespace": "Alexa.EndpointHealth",
    "name": "connectivity",
    "value": {
      "value": "OK"
    }
  },
  {
    "namespace": "Alexa.RangeController",
    "name": "rangeValue",
    "value": 67,
    "instance": "5"
  },
  {
    "namespace": "Alexa.PowerController",
    "name": "powerState",
    "value": "OFF"
  },
  {
    "namespace": "Alexa.RangeController",
    "name": "rangeValue",
    "value": 0,
    "instance": "3"
  }
]

Plugin Config:
{
    "devices": [
        "Extractor"
    ],
    "auth": {
        "refreshInterval": 4,
        "proxy": {
            "clientHost": "<hostname>.local",
            "port": 8868
        }
    },
    "amazonDomain": "amazon.com",
    "language": "en-US",
    "performance": {
        "cacheTTL": 60,
        "backgroundRefresh": true
    },
    "debug": true,
    "platform": "HomebridgeAlexaSmartHome"
}

Environment:

Plugin Version: v2.1.3
Homebridge Version: 1.7.0
Node.js Version:v18.19.0
Operating System: Ubuntu Jammy Jellyfish (22.04.3 LTS), via homebridge/homebridge Docker image.

Updating and closing as I think this was not a bug with the plugin. Instead I removed and re-added my Homebridge bridge in Apple Home and the missing device was discovered; it now works as expected. Thanks!


Build Data Prepper continuously

Is your feature request related to a problem? Please describe
The new Data Prepper tarball build in #1434 is only building and deploying once it is time to release. Data Prepper is a standalone application and can build nightly.
Describe the solution you'd like
Create a build of Data Prepper which builds all artifacts. This build can run against multiple branches. It can also produce nightly builds when changes are made to the project.
Additionally, Data Prepper would need a second promotion build to sign artifacts.
Data Prepper has the following artifacts which need to be built:

Docker image
Tarballs (linux only presently)
Maven artifacts

Describe alternatives you've considered
No response
Additional context
No response

[Triage] We will follow up after https://github.com/opensearch-project/opensearch-build/issues/1234

Data Prepper will now have its own staging GitHub Action. This will run regularly.
Since the Jenkins job in this project signs and uploads to production, it should not run aside from a manual request to promote a staging build. Thus, I'm closing this issue.


This clip from Yahoo reports "Can't extract content ID"

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.04.06. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.04.06

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[ x Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.04.06
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue required an account credentials please provide them or explain how one can obtain them.

I searched for other users with Yahoo videos that gave this error, and the threads said the Content ID problem was soon to be fixed. This video from an old SNL episode on Yahoo Screen reports a Content ID error as well.
Log:
C:\Users\Owner\Desktop>youtube-dl -v https://screen.yahoo.com/al-franken-decade-000000863.html
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'https://screen.yahoo.com/al-franken-decade-000000863.html']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2016.04.06
[debug] Python version 2.7.10 - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-78335-g9ee4c89, ffprobe N-78335-g9ee4c89, rtmpdump 2.4
[debug] Proxy map: {}
[Yahoo] al-franken-decade: Downloading webpage
ERROR: Unable to extract content ID; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "youtube_dl\YoutubeDL.pyo", line 669, in extract_info
  File "youtube_dl\extractor\common.pyo", line 323, in extract
  File "youtube_dl\extractor\yahoo.pyo", line 229, in _real_extract
  File "youtube_dl\extractor\common.pyo", line 627, in _search_regex
RegexNotFoundError: Unable to extract content ID; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Page Not Found
Sorry, but it looks like this video is no longer available.

Because yahoo does not.


New example: get an ECM snapshot from an external program

🎉 New feature
Summary

Add an example program showing how to instantiate a copy of the ECM from another process. This makes use of the serialized state message, which can be acquired from the /state service or topic. This makes it convenient to access all entity and component data without the need for dedicated messages for each component type.
Test it

See the new README for instructions.
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[x] Added example and/or tutorial
[x] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Is there any way to do the opposite? Set the ECM using a external program ?

Interesting idea, we don't have a transport interface for that right now, but it could be added. It would be quite powerful though, so I think that would be geared towards advanced users.


New command/option to open an existing pull request

I would like to have a command to open/browse an existing pull request.
Since pull-request is able to see if there's a pull-request already (at least when it tries to create one), this should be possible.
It should default to the current branch with its tracking remote/repo.
Related issue: https://github.com/github/hub/issues/880 - which is about displaying the URL to a pull request.

hub browse gets you most of the way there.

Yes, it helps in general.
But given https://github.com/github/hub/issues/896 you won't be on your fork / the branch necessarily.
(I assume that you mean that the branch is opened and you can click the link to the PR?!)

git config --global alias.pr-open \
  '!open $(hub pr list -f %U -h dwijnand:$(git rev-parse --abbrev-ref HEAD))'

to add a pr-open alias to your ~/.gitconfig
Replace dwijnand with your username, and open if not on macOS.

hub pr show has now landed in master https://github.com/github/hub/pull/2141

This is amazing, thank you 🥇
That time when issue hangs in your subscription for more than two years and then it finally pays off 💃

@dentuzhik You're welcome! Credit goes to @ashemesh @hmemcpy who eventually made contributions towards the feature ❤

Thanks very much for pushing it through! 🎉


Shows first the cross and after click the hamburguer

Please give me some help to fix that

Check your class of button.hamburger, maybe it has is-active class name already.


Fix broken pyassimp regression

This is a follow up to comments on the thread. There is also a separate issue created here. It fixes the broken pyassimp regression by installing libassimp-dev from apt and pyassimp from pip instead of directly installing pyassimp from apt.

Yeah you'll need 2 keys to fix the issue. One pip key for pyassimp should go here and should have a dependency listed on libassimp-dev(similar to what is done with the key for python-chainercv-pip), and then another key here for the libassimp-dev key.
I think that'd do it right @tfoote?

That would make rosdep be able to run. But it does not resolve the inability to release based on the pip versions. And we generally do not want pip versions overlaying/overlapping apt versions. It's often up to date once, but once the apt version gets fixed. The pip version will continue to overlay. As this is a confirmed bug upstream on launchpad. I'd recommend pushing hard there for a backport/fix as the long term proper way to fix this. In the mean time you can give developers instructions to work around the issue. If we deploy this via rosdep a lot of people will deploy the workaround without knowing it. And there's no automated way to roll back the workaround.

Unfortunately I doubt it'll get fixed in 16.04 as the developer doesn't seem very interested in fixing the issue considering it works with pip and in later versions of ubuntu. Also i'm not sure what automated work arounds exist outside of building from source yourself(to me this is not an acceptable solution). That's what has been recommended for moveit users.

Closing, recommended solution is push for a backport\fix from the original developers.


Add SendAndSubscribeTransactionStatuses endpoint

Add SendAndSubscribeTransactionStatuses to the SDK that was implemented for Access API.
Related issue: https://github.com/onflow/flow-go-sdk/issues/745

For this item there's new work kicking off that will refactor/redesign the websockets https://github.com/onflow/flow-go/issues/6163
While the existing endpoints will remain they will be marked as as deprecated. Since you are only just about to integrate this probably best to wait until the next websockets is released and no bother with the deprecated one since otherwise you'll have to go rounds on this with the first being pretty much as waste


SASL support connecting to a remote irc server

Any chance of getting SASL support? freenode doesn't allow you to connect from blacklisted ip ranges without SASL auth (behind a vpn/proxy)

Not sure how easy it would be for us to do. Just leaving this here as initial documentation of the IRC SASL protocol. http://ircv3.net/specs/extensions/sasl-3.1.html

I'm going to close this issue, since I don't think there's enough interest to get it implemented.
I don't mind a PR though :)

Going to re-open this issue, since it seems like Freenode blacklist AWS IP blocks. (Information from #convos on freenode)


Magically handle hot loading for phenomic content

The boilerplate code in phenomic.browser.js is so annoying. We should investigate on how to handle that.

Going to be fixed with #925

Ok in master!


[riverpod_generator] 3.0.0-dev.3 - No notifier generated when passing arguments to the request.

Hello,
first of all thank you for this nice project.
Describe the bug
I'm trying to generate the code after defining a notifier, passing argument to the request. The notifier attribute on the provider is not generated.
I'm using the example
https://github.com/bizz84/flutter-tips-and-tricks/blob/main/tips/0097-riverpod-notifier-build-argument/index.md
@riverpod
class ItemController extends _$ItemController {
  @override
  FutureOr<void> build({required String itemId}) {
    // no-op
  }

  Future<void> deleteItem() async {
    final repository = ref.read(itemsRepositoryProvider);
    await repository.deleteJob(itemId: itemId);
  }
}

Generating the code via dart run build_runner build is successful on no error is in the logs.
But The following attribute is not available :
itemController.notify
I would like to call:
ref.read(itemControllerProvider.notifier).deleteItem()
It's working when the build method has no attribute.
To Reproduce
flutter create test
cd test
flutter pub add riverpod riverpod_annotation dev:build_runner dev:riverpod_generator:3.0.0-dev.3
dart run build_runner build

Expected behavior
To have access to itemControllerProvider.notify
N.B : I could'nt test on the last version 3.0.0-dev.4 because of #3005 .
Thank you,

You need to pass the parameters
ref.read(itemControllerProvider(itemId: 42).notifier).deleteItem()


Only reset selected day or month if necessary

This is a change to only reset the day or month if necessary when the year or month is changed. Instead of always resetting the day or month, check if the currently selected day or month is valid. If it's valid, keep the current selection, otherwise reset like before. This also includes a change to update the submit id element on any change not just on a day change.

Thanks..


repo.mongodb.org 2.6.7 binary is down

http://repo.mongodb.org/apt/debian/dists/wheezy/mongodb-org/2.6.7/main/binary-amd64/Packages
Docker images will fail to setup
bash: line 7: docker: command not found
rm: cannot remove ‘/var/cache/apt/archives/lock’: No such file or directory
W: Failed to fetch http://repo.mongodb.org/apt/debian/dists/wheezy/mongodb
org/2.6.7/main/binary-amd64/Packages  404  Not Found

Are you sure that dockerImage: 'blakeberg/meteor-nodejs' option is working correctly? I tried multiple docker images that claim not to contain mongo but the error is the same.
What to do?

this must have been a mistake, related to error during mongo installation on the server, closed


Implement IIIF 2.1 features

This would actually help with some of the current DOS vectors (maximum size being the big one)

[x] Add support for "square" region keyword

[x] Advertise the feature "regionSquare" in the info response
[x] As with other features, this capability should only be available when configured (defaulting to being on)

[x] maxWidth, maxHeight, maxArea

[x] set up the example toml capabilities file to show these as maximum bounds for RAIS.  Make sane defaults RAIS uses in any server?
[x] When an info response is requested, if the image is bigger than the specified values in the capabilities (which may have defaults), report the capabilities which the image exceeds.  Note that if maxHeight is reported, maxWidth, per the spec, must be reported as well.  It may be easiest to just report all maximums anytime any one maximum is exceeded.
[x] If the image fits within the server's maximums, the info response can skip reporting any of the constraints since the image dimensions are already reported.
[x] When an image is requested and the size exceeds these settings, return a 400

Does this include requests for "full" images?  The specs state that "full" returns the image at its full size with no scaling, but they also state that a server may return a 400 when an image is requested at dimensions larger than the maximums defined in the info.json response.  It seems weird that "full" would suddenly stop working, but if somebody explicitly configures RAIS to only support a certain max size, it would be bad if "full" did work.

[ ] Add support for "max" size keyword

[ ] When "max" size is requested, return the size defined by the RAIS maximums if smaller than the full image

[ ] Expose new features "sizeByConfinedWh" and "sizeByDistortedWh"

The functionality is already supported, but isn't listed in the profile's features.  It may be easiest to just hard-code these as "always on" features rather than making them configurable, given the added complexity of verifying the requests.  sizeByConfinedWh would be fairly easy to disable -- but when would that be useful to do?  sizeByDistortedWh would be a lot more annoying to disable, requiring a check against the requested aspect ratio vs. image aspect ratio.  And again -- when would that be a useful thing to disable?  Neither of these is even remotely expensive to calculate.

Requests for invalid sizes are 501 errors instead of 400 - the request is not an invalid requests, it just isn't supported by the server


Ensure travis is testing with database urls.

Coverage increased (+0.2%) to 93.435% when pulling 2c67243e4c90484a80d3f49265e6d159b6eb7b94 on travis-checks into 44b4fdfeaf456d102ec77e3d85551259c012a720 on master.

Coverage decreased (-0.4%) to 92.779% when pulling 9b80911f5968184a9599598c337fcd876ae43206 on travis-checks into 44b4fdfeaf456d102ec77e3d85551259c012a720 on master.

Coverage increased (+0.2%) to 93.435% when pulling 74bcf42f56130d51a101c37506b20c57fcad914a on travis-checks into 44b4fdfeaf456d102ec77e3d85551259c012a720 on master.

all good.


Traceback function is not working

@controversial please guide me how traceback functions works

Hi @kazimshah: The traceback function works whenever you hover your mouse over a node on the graph. The node, along with its “ancestors,“ should highlight in yellow. Please feel free to reopen if I misunderstood your question!


Make better

@muan have a look around and let me know of glaring issues, please! 🙏

post titles line heights seem to big.
mismatching heading tags.
some heading levels are skipped (missing h2 on home page), check out muan/headings. And I think h1 should be jlord's weblog instead of Hello!?
the book covers should have alt text.
the footer links should probably be wrapped in a <nav aria-label="main">.

all pretty small stuff. seems largely fine!

seems largely fine!

😍

post titles line heights seem to big.

@muan do you mean style-wise or usability problematic?

And I think h1 should be jlord's weblog instead of Hello!?

You are probably going to be the one who is right but to me Hello is the title (so h1) and jlord's weblog is description/location/metadata? Which way makes sense for a screen reader to read it?

@muan do you mean style-wise or usability problematic?

Style-wise .

Which way makes sense for a screen reader to read it?

Heading outline is like table of contents. It depends on which TOC you think make more sense:
- Hello!
  - Posts

or
- jlord's weblog
  - Posts


Parallelize the ProgressBar

We should also probably use NUMBA :D

Yeah, I was just thinking about this. We'll probably need a Spark connector for large N as well.

I also think that returning an approximate progress value is a worthwhile tradeoff to consider making

Closed in v0.5.0


Dirt-road backup & restore

Gave it a shot of saving / loading both HeadState and ChainState. This is not using ADR18.
To check before merging:

[x] CHANGELOG is up to date
[x] Documentation

Re-requesting reviews as I have updated the documentation now with a verbatim copy of hydra-node --help to avoid duplication. @v0d1ch @ffakenz @abailly-iohk

@abailly-iohk not sure why, but I can't reply on the comments. Re the lwn article:
The sequence of steps in the "when to fsync" section is actually what the unliftio function does. Is adding a dependency for it worth it? I'd say yes (over vendoring).. until we do something else than write json to disk. An objective argument against could be performance, but I wouldn't know as I did not run any benchmarks.

I would personally have just done BS.writeFile ... because of the "dirt road" aspect of this feature and develop a better storage method on top of sqlite. The linked article is not actually the one I had in mind, which is a deep technical explanation of the things sqlite needs to do to ensure data is actually written on disk. Or perhaps was it postgresql? Anyway, the conclusion I drew from this is that it's much much safer to rely on this battle-tested and simple to use DB rather than trying to use Haskell's IO when one wants to provide strong durability guarantees.
That said I have been using basic file IO in production at Capital Match and never had an issue (except when we were not writing to disk but that's another story). Of course, load was rather small, with few spikes (can't remember the numbers but perhaps we had some 50tps in peak?).


[DC-1817] [Build - Pipeline] Leverage existing lookup tables for site validation

Overview
See JIRA ticket DC-1817 for details. This comment also helps understand the requirement.
--
Note 1
For functions that are still using the old GCS client, I added these two @mock.patch to the corresponding integration tests. We can safely remove the first patch statement after the GCS client migration is completed.
    @mock.patch("gcs_utils.LOOKUP_TABLES_DATASET_ID", dataset_id)
    @mock.patch("gcloud.gcs.LOOKUP_TABLES_DATASET_ID", dataset_id)

--
Note 2
After this PR is approved, I will update aou-res-curation-prod.lookup_tables.hpo_id_bucket_name table. Here is what I will do:

Add the new column service
Populate default or legacy to each of the values based on this new CSV file.

--
Note 3
There is (another PR)[https://github.com/all-of-us/curation-devops/pull/65] for curation-devops regarding this ticket.

@nishanthpp93 Thank you so much for reviewing this!
I updated the scripts. For the second point, I left a follow-up comment in this PR.
I also deployed the app to the test environment yesterday. One time without service specified in app.yaml and the other time service: beta. I confirmed that os.environ.get("GAE_SERVICE") works as expected. Here are screenshots from the experiment. (Each of the screenshots has an error message, but you can ignore that. It is because aou-res-curation-test:lookup_tables.hpo_id_bucket_name does not have test data.)


[Removal]:

Hotspot Name
Dapper Sky Peacock
Hotspot b58 Address
11U2D9TJnQdnTFZjmHJgX8MXAjaNBFYRiK9ewcN2UQZwyx42ErF
Discord Handle
No response
Hotspot Manufacturer
RAK
Removal Reason
I deployed my hotspot in real location, I do not know why it was listed in the denylist
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
no

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


Add a timeout to waitForPodRunning

Add a timeout, convert the function to return an error (which gives
a reasonable status message for callers).
Start converting glog to By.

cc @filbranden @satnam6502

Great! I look forward to getting insight into what is happening during these timeouts.

Our rule is to not merge during the weekend for various reasons. I wonder if it is worth making an exception for fixes to the e2e test framework because:

We should not be merging code during the weekend anyway...
Working on e2e improvements which can be disruptive can be done with lower impact...
We can monitor and understand the effect of e2e changes without other interference.

I'm somewhat torn on that policy question. On the one hand, I would've loved to see this go in to see what the bullets would be like when I looked this morning.
My suspicion is that you're about to see several tests go unstable with a 60s timeout. I may be a little ungenerous at a minute. Personally, though, I think we need to rewrite the tests (use less beefy images to pull, for instance) if that can't be the case, though, because a minute to schedule a pod is an eternity.
So yeah ... I think I'm fine with people merging test infrastructure stuff on a weekend with a caveat: I think the burden of ownership suddenly shifts to the merger. The PR writer isn't necessarily expecting it.

Actually, after a few more runs, my local e2es are a bit too flaky even for my taste with one minute. I'm going to bump this to 5m and we'll fight the good fight later.

I'm self-merging on LGTM. We're in the pipe, 5x5 now :)


EAX encryption support

This PR adds an implementation of EAX mode for AES encryption. The implementation encapsulates the existing AES classes (AES128BlockCipherEnc and AES256BlockCipherEnc) and provides support for encrypting and decrypting with EAX mode, with authentication tag creation and verification. Both the additional authenticated data ("header") and the payload can be streamed in chunks. An extra class (EAXSaved) provides support for optimizing processing of several messages that use the same key and the same header.
The EAX mode is then used in WeaveMessageLayer.cpp to support two new encryption formats for messages, called AES128EAX64 and AES128EAX128; these use EAX with a 128-bit key and authentication tags of size 64 and 128 bits, respectively.

Any updates on moving this PR along?

This PR is out of date.  I have an derivative of this branch (feature/jay/eax-support) that builds upon Thomas' work and begins to incorporate EAX support into the Weave session establishment protocols.  This work is incomplete, however, which is why I haven't created a new PR (see the commit messages on my branch for the current status).
In the meantime, this PR can be closed.  Thank you for your work on this, Thomas!


Why do ema models not need gradients only when there are pre-trained weights?

Why does ema model not need gradients only when loading pre-trained weights?
https://github.com/willisma/SiT/blob/main/train.py#L165
DiT's ema model always does not need gradients.
https://github.com/facebookresearch/DiT/blob/main/train.py#L148

Hi,
Thank you for spotting the issue, the ema model indeed does not require grad at all time. The code has been updated accordingly.


V0.9.2 causes error when deploying to function app

Downgrading to v0.9.1 solves the issue, but with version 0.9.2 my colleagues and I get the following error message deploying to a function app:
Operation 'Microsoft.Web/sites/read' failed as server encountered too many requests. Please try after '60' seconds. Tracking Id is ________

This has been fixed in v1.15.3 of Azure Functions.


Why is show arrrow not avaible on multi or tag select

Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-ivy-ppxcmt
Steps to reproduce
Open the link.
The first select has an arrow icon and a search icon when you open the select.
The second select is a multi-select and doesn't have an arrow icon.
While I added the [nzShowArrow] and set it on true.
In the documentation, there is no mention that the arrow icon doesn't work in multi-select mode.
What is expected?
That I see the arrow icon in multi-select
What is actually happening?
No arrow icon in multi-select

Environment
Info

ng-zorro-antd
9.3.0

Browser
Firefox Developer version 79.0b8 (64-bits), Firefox version 79.0b8 (64-bits), Google Chrome Version 84.0.4147.89 (64-bit)

[nzShowSearch] isn't also working in multi-select but that's mentioned in the documentation, but would it be possible to make it aviable in multi-select? If no, can you explain what the reason behind this choice is?

@hsuanxyz I made a PR #5650 to fix this issue

@vthinkxie
By ant-design are you referring to this library https://github.com/ant-design/ant-design/?
Because when I look in their docs I find the following:

So for multi-select and tags is by default on false. But it's possible to set the showArrow on true so you can see it.
Like you can see in the following example the icons work in multi and tag mode.
https://stackblitz.com/edit/react-vrppip?file=index.js

Hi @DepickereSven
you are right, can you submit a new PR to make showArrow work and keep it false when in multiple select?
thanks

@vthinkxie here is the PR #5785


UI Enhancement: Center Pokemon Generation Content on Webpage

The current state of the Pokemon generator webpage does not present an optimal user experience as the generated content is not centered on the page. This enhancement request focuses on improving the layout by centering the Pokemon generation content, ensuring a more visually appealing and user-friendly design.
Assign me this under JWOC'24

@NaveenChandraAdhikari  any updates?

Name : vishal malyan
Git : https://github.com/vishal2005025
I have read the issue and go through the code and I have some idea ..
I eagerly want to work on it .
please assign it to me .


selection sort article added

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Selection Sort Article Added
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#44

Please review @ankitaggarwal23 @HarshCasper @iamrajiv

Please review @ankitaggarwal23 @HarshCasper @iamrajiv

@HarshCasper Requested changes done


Installing materialize using jspm

When I try to install the materialize framework using jspm install github:dogfalo/materialize  I get error : error getting package config for github:dogfalo/materialize also the same error comes when I try installing it using :
jspm install github:dogfalo/materialize -o "{ main: 'js/bin/materialize.js', shim: { 'js/bin/materialize.js': ['jquery'] }, format: 'global', dependencies: { 'jquery': '*' }, registry: 'jspm'}"
How do I install materialize using jspm as well as install its dependencies?

I even get the same error when doing simply jspm install github:dogfalo/materialize. I have attached the screenshot.

I get the same error, but with 0.96.1 is all ok.

In 0.97.0 was missing a comma in package.json. This is fixed in master, but from jspm docs "Commit-based installs are not supported for the GitHub registry currently", so you can't install the version from master. Need to wait for the new version or use old 0.96.1.

i have same problem. Ok i'll wait

The issue is fixed , I have checked int on 0.97.0


All clippy warnings that currently block compliation

Versions:
rustc 1.79.0
clippy 0.1.79
Warnings:
clippy::default_constructed_unit_structs
clippy::single_char_pattern
clippy::len_zero
clippy::clone_on_copy
clippy::duplicated_attributes
After going back through to check for these I realised all of them, except clippy::duplicated_attributes, occur in tests and therefore can likely be ignored.
Changing
#![deny(warnings)]

to
#![cfg_attr(not(test), deny(warnings))]

would allow the crate to compile (assuming clippy::duplicated_attributes is resolved).
However I would recommend reading over this and considering if you even want to keep deny(warnings) in general.

Hrm, it seems that I was building this with the wrong clippy version all along, can now repro them. I think your suggestion of turning the deny(warnings) off in tests is sound - it's not like we care much about perf there.