Make bool an enum

Currently, bool is not an enum, but there's no strong reason for that state of affairs. Making it an enum would increase overall consistency in the language.
This is a backwards-compatible change (depending on the specifics) and has been postponed till after 1.0.
See https://github.com/rust-lang/rfcs/pull/330.

Whatever happened to this? =P
(is it still backwards compatible?)

We document:
https://doc.rust-lang.org/1.34.0/std/primitive.bool.html

If you cast a bool into an integer, true will be 1 and false will be 0.

Casting here likely refers to the as operator.
However as far as I can tell we currently make no promise about the memory representation of bool (other than size_of being 1 byte). We may want to keep it that way, for https://github.com/rust-lang/rfcs/pull/954.
If bool is a primitive rather an enum, we can (more easily) special-case its casting behavior in the language.

Wouldn't the casting behaviour still be possible with repr(u8)?
#[repr(u8)]
enum bool {
    false = 0,
    true = 1,
}

The problem with representing bool as an enum is that it's either backwards-compatible (bool, true, false) or it conforms to the CamelCase naming convention for enums defined in RFC #430 (Bool, True, False), not both.

@gorilskij I don't see how this is a big issue. Obviously we have to preserve true and false and be inconsistent with CamelCase
How is this that bad though?

@KrishnaSannasi I would tend to agree, both for compatibility and because bool is a basic enough type to warrant a lower case name. It's not bad, just unpleasantly inconsistent, especially in a language as relatively polished as Rust. It's not nice to have a builtin type that, were you to write it yourself, would raise a compiler warning.
There is another, more serious point. As proven by the fact that false = 0 and true = 1, bool is more than just a simple 2-variant enum, it has a u1 kind of numeric feeling to it, logical operations have a numerical operation feeling to them as well as evidenced by some of the notation (&& ~= *, || ~= +, ...) not to mention the fact that all those operations as well as the if/else construct depend on the bool type, it would be possible to do logic without all of that but with how fundamentally useful it is, I think it (bool and friends) deserves it's special status in Rust as in the vast majority of other languages.
As an example to illustrate what I mean, Haskell implements Bool as a true 2-variant type and defines the infix operators (&&, ||, ...) in the standard way to go along with it (note that logical not is called not, not ! to maintain consistency because it's a prefix operator, though Haskell does still bend the rules for prefix - but that's beside the point). This, I believe, is nice and idealistic but not suited to a more practical language like Rust.
TL;DR I think making bool an enum changes nothing from the implementation perspective and goes half-way in a direction I'm not sure we should be going from the purity perspective.

@goriskij

There is another, more serious point. As proven by the fact that false is 0 and true is 1, bool is more than just a simple 2-variant enum, it has a u1 kind of numeric feeling to it

This can be solved as @oberien showed earlier,
#[repr(u8)]
enum bool {
    false = 0,
    true = 1
}

and then special casing && and ||. The other operators (like !) can be implemented normally.
Note that there is movement to make && and || overloadable like all of the other operators. If that lands, then we can implement && and || normally for bool as well.

Perhaps you're right. I still think that in an ideal world it would be Bool, True and False, maybe that's something to consider for a future edition. What about if/else though? If bool is made to look like any other 2-variant enum won't it seem strange that it alone can be used in those statements? Opening up if/else to any 2-variant enum seems even more weird and magical.

What about if/else though? If bool is made to look like any other 2-variant enum won't it seem strange that it alone can be used in those statements? Opening up if/else to any 2-variant enum seems even more weird and magical.

Well, if and else are kinda special. We could define that
if $cond {
    $block
}

gets desugared to
match $cond {
    bool::true => $block,
    bool::false => (),
}

And similarly for if $cond { $block_t } else { $block_f } we could desugar to a match, this way it is still clear what is happening.

I still think that in an ideal world it would be Bool, True and False, maybe that's something to consider for a future edition

I don't think an edition can do this, it seems like to big of a breaking change.

Alternately, if $cond could be desugared to if let bool::true = $cond, which is more consistent and also works for match guards (although if let match guards are not actually implemented yet).

I understand that if and if/else can be treated as pure sugar but they are nonetheless (together with while which, as far as I can see, can't be desugared without recursion) very fundamental constructs in the language and very fundamentally depend on the bool type. Making the type an ordinary enum seems somehow dirty as it would lose it's intrinsic specialness yet retain a lot of special treatment, making it, as far as I can tell, the only enum "allowed" (without compiler complaint) to have a lowercase name seems like more of the same. I like reducing keywords and removing special behavior as much as anyone but I think this proposal does that too superficially.

for and while are already desugared to loop + match.

“Language items” are not dirty, they are often necessary. For example for loops need to know about the IntoIterator and Iterator traits, as well as the Option enum.
I think there is no real blocker to making bool an enum. We can make it work. But I also don’t see much benefits, so it may not be worth the bother.

But I also don’t see much benefits, so it may not be worth the bother.
I don't see any benefits other than "it looks cleaner" which I'd argue it doesn't due to, at least, the naming convention inconsistency.

No-one is suggesting we change the name. Using an enum instead of a bool would simplify some special-casing in the compiler, which would be an advantage.

I was talking about the issue purely from a user's point of view, I have no knowledge of compiler internals (or experience in this area for that matter). Just out of curiosity, how would switching to an enum representation help? It seems to me that a primitive type would be easier to write special cases for.
(btw, if this is not the place for such discussion, tell me, I'll move it somewhere else)

@gorilskij as @varkor said it would reduce special casing the compiler, so it would make the compiler simpler. Special casing only makes things more complex, not the other way around. For some things the complexity is justified, but with bool we could easily make it less special and thus simplify the compiler.

Oh, sorry, I misread it as "it would make it simpler to implement special casing." Thanks for clarifying.

@varkor What's the way forward on this? It seems like it's a good idea, given that it would reduce the special-casing in the compiler.

@jhpratt: there was a brief discussion on Discord about it a while ago. You'd probably want to talk to @oli-obk or @eddyb about it if you wanted to pursue it, who both had some ideas about it.

After a slight bit of discussion on Reddit, a couple things came up. Would the true and false keywords need to be removed? Intuitively, I don't think it would be possible to implement an enum bool { false, true } unless they weren't keywords (as otherwise raw identifiers would be necessary). Also, would removing keywords be backwards compatible?
I'll (finally) reach out on Discord to them to see if they have any ideas.

We can keep the keywords and have them refer to the variants of the enum. There might be some diagnostics changes to work out, but I don't think it'd be a problem.

I think it's mostly compiler-internal work that is blocking this. I tried it once and it's not super simple to do. Loads of code expects to know that something is a bool or make something a bool, and for this we right now have a very convenient way (tcx.types.bool). With this PR that would have to change to tcx.type_of(tcx.require_lang_item(lang_items::BoolEnum)). While we can totally abstract this to tcx.mk_bool(), it's still not the zero cost thing we had before and I think there were other inconveniences, too. So maybe there could be a preliminary PR that just removes tcx.types.bool in preparation of this change, so we can judge some of the fallout.

I have doubts that this "reduce special casing the compiler", bool is indeed special and built-in for the compiler in many senses.
I suspect it would be much easier to offload e.g. ! to the library (as an empty enum) than bool.

I'd think the similarities appear only in the nich layout stuff, so maybe some future layout code would be simpler if it could optimize some bools as enum discriminants.
At present, we always permit fields references, which imposes alignment constraints, and makes the layout less interesting.  We pack enum discriminants into left over space because one cannot take a separate reference to the discriminants.  I'd think composite types could conceivably restrict references to specific fields with some notation like !ref T or #[no_ref] T or #[packed] T.
As an example, size_of::<(bool, bool)>() = 2 while size_of::<(!ref bool, !ref bool)>() = 1, and ideally even size_of::<(!ref Option<bool>, !ref Option<bool>)>() = 1, but you cannot call &self methods on a !ref Option<bool> without first destructuring.  You might conceivably treat Copy types even more special here, not sure.  And folks might prefer bitfield notations like in C anyways.
At first blush anything like this sounds like an internal compiler concern, so not an issue worth considering right now.

Layout considerations are completely orthogonal to whether bool becomes an enum or not. If bool keeps not being an enum, this is just a few lines of code in a very encapsulated piece of code that would be affected for layout changes.

I think that 2014 or earlier would have been a good time for a change like this.
At this point doing it without breaking things would take non-trivial care while the benefits as far as I can tell are entirely theoretical. It would feel nice to have fewer special cases in the language, but is there any concrete benefit to users?
I think that formally deciding not to make this change (as opposed to it being merely postponed) should be an option on the table for @rust-lang/lang.

I would personally like to avoid considering whether bool should become a library type right now. I would also like to like to avoid making a formal decision that it should never become a library type as well. I'm personally happy with indecision for the foreseeable future. :)

@SimonSapin What's the harm in leaving this open, in case someone wanted to at least try it to see the admittedly uncertain benefits? That's what I was going to do, but @Centril said it would likely conflict with other ongoing work.

it would likely conflict with other ongoing work

It sounds like you answered your own question?

If this were a formal RFC submitted now, what should the Motivation section contain?
From the template:

Why are we doing this? What use cases does it support? What is the expected outcome?

The conflict with ongoing work would be temporary (iirc he said if-let chains), as the bits it would touch would eventually be completed. My interpretation of your original comment was a permanent (or at least indefinite) declination of the (pseudo-)RFC.

I think that formally deciding not to make this change (as opposed to it being merely postponed) should be an option on the table for @rust-lang/lang.

This is a compiler implementation detail and doesn't affect the language. The only possible user-facing change this could have is changing diagnostics, but these are easily special-cased anyway. While I don't think this ought to be a priority, if someone wants to try changing it to see whether the consequences for code clarity are advantageous, there's no reason to dissuade them (other than their time perhaps being better placed with more useful features).

why not use just 1 bit for bool like ziglang?
https://ziglang.org/documentation/0.9.1/#packed-struct
"bool fields use exactly 1 bit."

use just 1 bit for bool

If that were the case, then you [wouldn't be able to safely take a reference to the boolean]. Note that the section you are referring to is titled packed struct.

use just 1 bit for bool

If that were the case, then you wouldn't be able to safely take a reference to the boolean. Note that the section you are referring to is titled packed struct.

https://ziglang.org/documentation/0.9.1/#boolToInt
@boolToInt
@boolToInt(value: bool) u1

Converts true to @as(u1, 1) and false to @as(u1, 0).
If the value is known at compile-time, the return type is comptime_int instead of u1.

If you are responding to me, it’s not clear what the argument/point of the response is.
You asked why a Boolean can’t (universally?) be represented as a single bit. The answer is that you can’t take a reference to a bit (memory addresses only have byte granularity) and values in Rust can generally be referenced.
You’ll need to clarify what point your response is trying to make.

For what it's worth rust actually does use the i1 LLVM type to represent booleans. Bools only taking one byte within structs is a packed structs issue, so not relevant to this issue


Rocket #534 broke my plugin.

"I am sorry, but as always, with progress, old things will break. I will try to update my plugins as fast as i can and support the developers that want to update, i can't help if other developers don't update their plugins tho. Make sure to find out if eventual issues are caused by outdated plugins before submitting bug reports. A few core features were removed as i didn't like their implementation"
https://rocket.foundation/viewtopic.php?f=44&t=706

I have updated ...

Close!
I added wrong dll references... sorry...


gitignored file

a file in the template but gitignored in the project should persist in the filesystem
fixes #1162

Looks like you have to reformat the code. Run poe lint to do it automatically please.

Thanks @yajo  for your review

I hope this one is the good one :)

There war an issue with flake-check, I rebased and squashed on master


Fluid layout responsiveness

Am I right that fluid layout responsiveness is not yet complete in 2.0-wip branch? In examples/fluid.html, the page seems to behave as if the sidebar is not present, no matter which media query is in effect.
Is this planned to work for 2.0?

Seems like docs/index.html is behaving better than examples/fluid.html.

docs/index.html is responsive but it's not fluid. Is this a bug or fluid-container is not going to be responsive?

Its responsive and fluid BUT not optimized for that example.
for example the css should lose the min-width: 940px;
and the @media (max-width: 480px) should include something like:
.sidebar-left{padding-left: 20px;}
.sidebar-left .fluid-sidebar {margin-left: 0px;}

As the framework doesn't include percentage widths for the grid, can
it really be both fluid and responsive?
On Tue, Jan 24, 2012 at 3:08 PM, martijnmegens
<EMAIL_ADDRESS>wrote:

Its responsive and fluid BUT not optimized for that example.
for example the css should lose the min-width: 940px;
and the @media (max-width: 480px) should include something like:
.sidebar-left{padding-left: 20px;}
.sidebar-left .fluid-sidebar {margin-left: 0px;}

Reply to this email directly or view it on GitHub:
https://github.com/twitter/bootstrap/issues/930#issuecomment-3633701

--

Sent from my web browser

Saw an early version somewhere with percentages.
https://gist.github.com/1308554#file_responsive_fluid_grid.css

Why use pixels instead of percentages?
Pixels work fine when you use .span1 etc in your html. But with LESS, I'd like to do something like this:
header{ .makeColumn(12); }
#content { .makeColumn(8); }
#sidebar { .makeColumn(4); }
etc
But with mediaqueries, I have to redefine those elements for every width. When using percentages for the width/gutter, I would only have to change the container, and for the very small screens, define no width at once like:
.row > [class*="span"] , #content, #sidebar, .block, .large-block{
float: none;
display: block;
width: auto;
margin: 0;
}
The same goes for the normal content, instead of redefining all spans and offsets, you only change the container.

"Why use pixels instead of percentages?"
I'm not sure if that's addressed to the Bootstrap project or the
end-developer. You can certainly fork Bootstrap and use percentages,
but you do then have to deal with the consequences of using a fork.
On Wed, Jan 25, 2012 at 10:49 AM, Barryvdh
<EMAIL_ADDRESS>wrote:

Why use pixels instead of percentages?
Pixels work fine when you use .span1 etc in your html. But with LESS, I'd like to do something like this:
header{ .makeColumn(12); }
#content { .makeColumn(8); }
#sidebar { .makeColumn(4); }
etc
But with mediaqueries, I have to redefine those elements for every width. When using percentages for the width/gutter, I would only have to change the container, and for the very small screens, define no width at once like:
.row > [class*="span"] , #content, #sidebar, .block, .large-block{
   float: none;
   display: block;
   width: auto;
   margin: 0;
 }
The same goes for the normal content, instead of redefining all spans and offsets, you only change the container.

Reply to this email directly or view it on GitHub:
https://github.com/twitter/bootstrap/issues/930#issuecomment-3648711

--

Sent from my web browser

Yes, I know I can create a custom responsive grid, the question was adressed to the Bootstrap project itself.
I understand it is easier when you just have 1 grid, but working with fluid/resposive grids, percentages look more logical to me. Just wondering what the major disadvantages are, and why pixels are used by default in de responsive grid.

I agree, it would be great if Bootstrap adopted this. I suspect we
will have to wait until v2.x or v3 though.
On Wed, Jan 25, 2012 at 11:28 AM, Barryvdh
<EMAIL_ADDRESS>wrote:

Yes, I know I can create a custom responsive grid, the question was adressed to the Bootstrap project itself.
I understand it is easier when you just have 1 grid, but working with fluid/resposive grids, percentages look more logical to me. Just wondering what the major disadvantages are, and why pixels are used by default in de responsive grid.

Reply to this email directly or view it on GitHub:
https://github.com/twitter/bootstrap/issues/930#issuecomment-3649115

--

Sent from my web browser

I think part of the hesitation with percentages is that it makes nesting grids more difficult. As it is now, a .span1 is always the same width, regardless of whether it's at the top level, or nested two rows deep.

Yeah, fluid grids are tricky. Appropriate names are one of the difficulties with nesting. And when using fluid gutters, as the viewport becomes smaller the columns of text/media come closer together, and their separate content experiences greater proximity. This can reduce readability and blur the distinction between different parts of the site structure.
On top of that, most browsers handle the rounding of percentages differently and you don't end up with exact alignments between different sets of columns. Sometimes you can end up with really poor alignment; the current version of Opera is particularly bad with this.

Closing for now, it's not a target for 2.0. And the docs are working responsively as mentioned above.


createDraftBco: `${bcoURL}objects/drafts/create {"POST_api_objects_draft_create"...}

The API testing already exists and has been tested. Swagger page looks fine.
Issue: In code response, modify 300 code to 207 code to reflect 'some requests failed and some succeeded'.


First Pull Request

This pull request includes code for the skeleton of the application design wise.

Hi @stino-x
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not follow gitflow. kindly follow gitflow as demanded by the project requirements. Also make your PR title more descriptive.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


[VL] Setting higher value of Broadcast Hash Join threshold is degrading the performance of Spark with Gluten

Backend
VL (Velox)
Bug description
Setup: Running TPCDS benchmark on spark with gluten.
With increasing broadcast hash join threshold, the performance of TPCDS benchmark degrades (config: spark.sql.autoBroadcastJoinThreshold).

Config-Value
TPCDS Total Time Taken

10MB
795sec

50MB
870sec

100MB
890sec

We have jobs with BHJ threshold set to 200MB in vanilla spark. Such jobs are not showing any gains with Spark+Gluten.
Spark version
Spark-3.5.x
Spark configurations
spark.sql.autoBroadcastJoinThreshold
System information
No response
Relevant logs
No response

It's a known issue. The issue is Gluten/Velox broadcast raw table instead of hash table. So each task needs to build its own hash table from raw data. The solution is to build hashtable from driver or one task then broadcast. But the problem now is Velox doesn't support it yet.
we plan to fix it in next year.

Add the impact TPC-DS queries: q24a, q24b, q11, q65, q69, q85 as a record.

BHJ improvement proposal:
https://docs.google.com/document/d/1upEby9aJnBcMKul7HS5agSr1zwFR63Iq4QL1nYxuFvU/edit?tab=t.0


i18n incomplete

Not all the labels are translated. In particular,

Connect with .. buttons
Footer
CATEGORIES (in nav menu, exists in IT and ES but not in EN)
Hello, XXXX (signed user)
password change page (actually, should be removed)
days ago (in the list of questions and inside a question page)
Submit your answer
Signup form

Fixed.

"by" in question details is not translated
days ago (in the list of questions and inside a question page) is not yet translated


Issue with k8s.io/docs/tutorials/kubernetes-basics/deploy-interactive/

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
Interactive tutorial, module 2, step 3.  Click on command "kubectl proxy" opens a second interactive terminal (no apparent shell commands).  Then curl commands fail with error below:
curl: (7) Failed to connect to localhost port 8001: Connection refused
Second click on command "kubectl proxy" leads to the second terminal showing this:
$ kubectl proxy
Starting to serve on <IP_ADDRESS>:8001
Then curl commands execute as expected.
Proposed Solution:
Update the tutorial to prompt the user to manually open a second terminal, then click command "kubectl proxy".  But this is a workaround, not a solution.
Page to Update:
https://kubernetes.io/docs/tutorials/kubernetes-basics/deploy-interactive/

Server Version: version.Info{Major:"1", Minor:"5", GitVersion:"v1.5.2", GitCommit:"08e099554f3c31f6e6f07b448ab3ed78d0520507", GitTreeState:"clean", BuildDate:"1970-01-01T00:00:00Z", GoVersion:"go1.7.1", Compiler:"gc", Platform:"linux/amd64"}

Chrome browser version 63.0.3239.132 (Official Build) (64-bit)

Thanks for the feedback. We've moved this scenario to Minikube 1.9. Hopefully this will improve the kubectl proxy.
If you still have having problems, please update the issue.

/close


dynamically incraese the channel sizes

	if len(secretQueue) == env.SafeSecretBufferSize() {
		log.ErrorLn(
			&id,
			"processSecretQueue: there are too many k8s secrets queued. "+
				"The goroutine will BLOCK until the queue is cleared.",
		)
	}

	^ instead of erring out; double the buffer size until it reaches a hard limit.

Removing the assignee since it has been a while this issue was dormant :)


Fixed indentation

Coverage remained the same at 86.227% when pulling 96dd49e27bd9a977dbf7a8699c078d326cfc2824 on bennyn:patch-1 into 2b364d2697025a67245cf5d1f2f18b667d109843 on Rebilly:master.

@bennyn thanks!


chore: Remove temporary lenient lint settings

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (93d7b79) to head (800e3c3).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          161       161
=========================================
  Hits           161       161

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add comments for directory id instructions

Summary
What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[x] Docs
[ ] Build-related changes
[ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge
[ ] IE

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature
[ ] Related documents have been updated
[ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:

Well, I tested it and saw what happened. It's actually a bug, so I have to close this PR.
I'll fix it these days. But don't hesitate to inform me if you wish to take it.


Exclude binary files by default from no-unused-modules.

missingExports: true of the no-unused-modules rule should not report files that are in the bin field of package.json. Binary entry files are usually not meant to export variables but instead to communicate to the shell using stdout/stderr and exit codes.
What do you think? Thanks.

This seems like a duplicate of #1327?

#1327 was about unusedExports. This one is about missingExports. As opposed to unusedExports, this might only make sense for bin files.

ahh gotcha. I’d expect all those to be ignored for both tho, since entry points need not export anything, even main, and especially browser.

since entry points need not export anything, even main

As opposed to bin files, shouldn't most main files export something? Otherwise requiring them would not return a value.

They need not. Packages can be required solely for side effects - minority is irrelevant; what matters is that it’s nonzero and appropriate.
If a file is explicitly declared as an entry point - whether in the rule config, main, bin, or browser - then I’m convinced it’s useless to be checking for used exports.

This makes sense. Also this allows merging those two issues.


Add support for custom Embeds

Closes #8. Allows users to provide a custom Embed class to use in the program. Defaults to Discord.js' MessageEmbed class.

I didn't add the APIEmbed type as that is exported from discord-api-types and I didn't want to add another dependency without mentioning that first!

I didn't add the APIEmbed type as that is exported from discord-api-types and I didn't want to add another dependency without mentioning that first!

If EmbedOptions is resolving your issue then no need to add APIEmbed. I'll test it with object embed and then I'll merge it

Thank you for the pr.


Ignore file name case sensitivity change

Ignore more commits in git blame

Set to draft as I'm anticipating more commits to ignore and I don't want to make a PR for each one


Fix #236

This makes the default SDL scan codes match the web UX at m8.run and the keyboard mappings for https://github.com/adwuard/TrackerKB

Found a conflict, re-testing...

Thanks for the contribution! Will try to check it today

No problem. I think all of the _alt bindings can go away (m8c on the Pi doesn't complain if I remove them), but I didn't want to lose the field names. Testing this on your side should be as simple as plugging in a USB keyboard alongside the M8 headless and comparing with m8.run.

Any news on this?

Hey, sorry, I haven't gotten hands on an Android phone yet to test it out if onscreen buttons work properly or not...

Fair. But those changes don’t affect the onscreen buttons, just what is read from USB.
(I am actively trying to avoid reinstalling Android Studio on vacation, hence my asking :))

ah yeah I’ve already forgotten how I implemented it, should be gtg


Jetson orin not booting up

After resolving the issue in #2461, it still stuck in boot up process. Not able to login and collect logs

@nianyush can you reproduce this with the kairos images too?

relevant? https://forums.developer.nvidia.com/t/orin-nano-wont-boot-lt4launcher-attempting-recovery-boot/255302/4

relevant? https://forums.developer.nvidia.com/t/orin-nano-wont-boot-lt4launcher-attempting-recovery-boot/255302/4

meh... not. It seems that ours is booting into palette.

seems we moved the iscsi.conf from the framework image to: https://github.com/kairos-io/packages/blob/99dec691da2d34468e2fcf2e14d3b9d388848da4/packages/static/kairos-overlay-files/files/system/oem/12_nvidia.yaml#L8

However, the dracut configuration is needed while building the initramfs (and has to be added into the framework image)
@nianyush for the orin you might need to add a patch in the meantime in your Dockerfiles:
echo 'omit_dracutmodules+=" iscsi "' > /etc/dracut.conf.d/iscsi.conf

before generating the initramfs with dracut

Venkatesh confirmed that the jetson boots now


Update to official Docker Engine 1.12.2

Signed-off-by: Dieter Reuter<EMAIL_ADDRESS>

Just successfully tested on Pi 1 and Pi 3.
LTGM


Bazel build on Windows

Describe the bug
Not exactly a bug, more like a help request. I'm trying to build a simple c++ client which uses Modsec on windows. I want to use bazel for building my client. I have followed the steps listed here  for building the dll and it works fine. This is the bazel rule I have added for importing modsec to my client.
cc_import(
    name = "libmodsecurity",
    hdrs = glob(["modsecurity/**/*.h"]),
    static_library = "modsecurity/libModSecurity.lib",
    visibility = ["//visibility:public"],
)

where I've copied all the headers and libModSecurity.lib to a folder called modsecurity in the build directory.
This is my main
#include<iostream>

#include "modsecurity/modsecurity.h"
#include "modsecurity/rules_set.h"

const char *request = "" \
    "GET /index.html?param1=value1&param2=value1&param3=value1 HTTP/\n" \
    "AuThOrIzAtIoN: Basic QWxhZGRpbjpvcGVuIHNlc2FtZQ==\n" \
    "Host: localhost\n" \
    "Content-Length: 27\n" \
    "Content-Type: application/x-www-form-urlencoded\n";

int main() {
  std::cout<<"Hello world!\n";
  modsecurity::actions::disruptive::AllowType TYPE;
  modsecurity::ModSecurity* modsec = new modsecurity::ModSecurity();
  modsecurity::RulesSet* rules = new modsecurity::RulesSet();
  // modsecurity::Rules* rules = new modsecurity::Rules();
  modsec->setConnectorInformation("ModSecurity-test v0.0.1-alpha (ModSecurity test)");

    std::string json("");
    const char *err = NULL;
    int ret = 0;

    ret = modsec->processContentOffset(request, strlen(request),
        "o0,4v64,13v114,4v130,14v149,12t:lowercase", &json, &err);

    if (ret >= 0) {
        std::cout << json << std::endl;
    } else {
        std::cout << err << std::endl;
    }

  std::cout<<"Hello world!\n";
}

To Reproduce
Steps to reproduce the behavior:

Please clone this repo, https://github.com/varkey98/cppclient/blob/main/BUILD
Run .\bazel-6.4.0-windows-x86_64.exe run //:hello_world-load-dll-at-runtime

Expected behavior
It works just fine and prints the output of processContentOffset
Actual behavior
It just exits without printing any error.
Additional context
It sometimes works fine without any issues after hitting bazel run & bazel clean combination a number of times, but not a consistent behavior.
edit: Even the hello world statements are not getting printed

Update:
on modifying my import rule to this, it started working
cc_import(
    name = "libmodsecurity",
    hdrs = glob(["modsecurity/**/*.h"]),
    interface_library = "modsecurity/libModSecurity.lib",
    shared_library = "modsecurity/libModSecurity.dll",
    visibility = ["//visibility:public"],
)

Would be great if someone can confirm what I'm doing is indeed the correct way. Not very familiar with bazel as well, but want to learn how to use it as that's we use in my organization.

@eduar-hte - could you help in this?

We're mostly a MSBuild/CMake shop for C/C++ code, so I'm not a bazel expert. However, I think your approach is correct, as cc_import rules are intended for C/C++ precompiled  libraries, which would be the case for libModSecurity as it's built using CMake on Windows.
My only recommendation would be to organize the modsecurity headers, import library and shared library into an install like directory structure as follows:
project/
├── WORKSPACE
├── BUILD
├── main.cpp
└── install/
    ├── include/
    │   └── modsecurity (files from headers/modsecurity)
    ├── lib/
    │   └── libModSecurity.lib
    └── bin/
        └── libModSecurity.dll

The install directory would be useful to integrate other precompiled 3rd party libraries. Most CMake libraries have support for an install step that would generate and copy these files into a specified target path. However, the current Windows CMake build configuration doesn't have this yet, and you have to do it manually.
Then the cc_import rule for modsecurity would be:
cc_import(
    name = "modsecurity",
    hdrs = glob(["install/include/modsecurity/**/*.h"]),
    includes = ["install/include"],
    interface_library = "install/lib/libModSecurity.lib",
    shared_library = "install/bin/libModSecurity.dll",
    visibility = ["//visibility:public"],
)

Finally, I'd also check with your organization in case they have already guidelines on how to build and integrate 3rd party libraries not build using Bazel (and not rely on having a specific precompiled version).

Got, thanks a lot @airween @eduar-hte. Closing this issue :)


Error 500 when trying to add ed25519 ssh key

Gitea version (or commit ref): 1.4.0+rc2-2-g92a3061
Git version: 2.7.4
Operating system: CentOS 6
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant (try.gitea.io is offline)

Log gist: https://gist.github.com/allgoewer/5cdc94ce997b9e1e5b2eb23a5678bb64

Description
As the title says. When I try to add a ed25519 key, I get an Error 500
ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIMW2IwdNx+cZrptZLTa4JhtbkuJPmh0OsJRTlSWGJyrB testkey

Screenshots

I dont think it's a generic problem. I can't reproduce it in a fresh installation. I think CentOS6 is the problem here. It is pretty old with a very old OpenSSH release which does not support ed25519 keys (so far as i know).
The error 500 is not nice. Maybe the documentation should be updated to make clear that it is not a good idea to run Gitea on such old systems or even better there could be a check and a warning in the Webui if an unsupported OpenSSH version is running :-).

 Other than the missing ed25519 support, gitea seems to work fine.

Best would be to detect this when checking key and return correct error that OpenSSH server does not support such key

I'll close this now and please feel free to reopen it.

I have tried adding the deploy key provided in the issue description and it worked.
What always causes a 500 response for me is when I reuse an existing's deploy key title of the same repository, so maybe that was the issue @allgoewer experienced. It happens for any type of key, both in UI and API.


using optional handler for .command() causes inconsistent / default behavior

When using the optional 3rd argument to .command(), yargs behaves as if it has no knowledge of other declared argument types:
#!/usr/bin/env node
var argv = require('yargs')
    .boolean('v')
    .command('foo', 'do foo')                 // knows about -v
    .command('bar', 'do bar', function() {})  // as if -v was not declared
    .demand(1)
    .argv;
console.dir([argv.v, argv._])

Actual Results:
localhost$ ./test-yargs.js -v foo
[ true, [ 'foo' ] ]
localhost$ ./test-yargs.js -v bar
[ 'bar', [] ]

Expected Results:
localhost$ ./test-yargs.js -v foo
[ true, [ 'foo' ] ]
localhost$ ./test-yargs.js -v bar
[ true, [ 'bar' ] ]

Hey @burl, when you registry a handler for bar, it resets the argument parsing as it's passed into the closure. This is so you can document sub-commands. To get the behavior you're looking for, you could do something like this:
#!/usr/bin/env node
var argv = require('yargs')
    .boolean('v')
    .command('foo', 'do foo')                 // knows about -v
    .command('bar', 'do bar', function(yargs) {
       yargs.boolean('v')
           // document options specific to the command `bar`.
    })  // as if -v was not declared
    .demand(1)
    .argv;
console.dir([argv.v, argv._])

Any thoughts about how we could better document this. The problem that we're specifically trying to solve, is being able to document sub-commands -- without making documenting the top-level options too confusing.

Aah, I see now.  I was not expecting the reset state.  Perhaps just calling that out in the explanation for .command() is good enough.

I was attempting to parse a command line for a git-style interface with the concept of "global switches" in addition to commands and command options/switches.
ie:  command [global-switches...]  [other-switches-and-options....]
Git for instance lets one do this:
git --no-pager log -q
But, not:
git -q --no-pager log
because '-q' is not a valid global option.
(unfortunately, this is also valid and unambiguous to git:   git -p log -p)
So this is sort of like two contexts, divided by the position of the subcommand. The left context is "global" and the right context is "command".  Argument permutation may only happen within each context -- not across contexts, and the "global" context needs to become "strict" by default.  The option parser needs to know all the valid subcommands as well.
I'm doing this now by splitting process.argv into two arrays at the position of the first "non-option" looking item - then handle each separately.  Its working fine.

Do you think there are any improvements that could be made to the command handling in yargs itself? I'm trying to balance simplicity, with power -- want to be careful not to add too many dials and knobs. But, if you can think of any quick wins, open to suggestions.

I think that this issue should be re-opened and addressed.
Global options should be available to nested commands. This is the behaviour of most command line tools.
Re-adding the option for every nested command may be a workaround for simple interface but when dealing with larger amount of commands this is less practical and harder to maintain.
For the purpose of displaying help, each command could set whether it wants the global options to be displayed when asking for specific command help (defaults to false).
so:
mytool --help displays commands and global options
mytool command --help displays command specific options (unless it explicitly asks to display global options, then it should be displayed in separate section).
and mytool command -g will include the -g option, even if set outside of the command.
Thanks!

@danielvy Thanks for the suggestion!
I think we realize that yargs has a deficiency in easily supporting a multi-command interface (see issues #121, #174, #201, #202, #225), but it's a difficult problem to solve, especially when it comes to maintaining multiple contexts of options. For instance, how should mytool --help command or mytool -g command behave?
I'd be interested to hear what you think about this proposal to support an object syntax for defining commands and potential subcommands. It seems a uniform object model would allow us to more easily build command-specific features/configuration going forward (such as if global options should be included or not), and may provide a better way for yargs to handle context switching automatically.
Thoughts?

@danielvy @nexdrew perhaps we could open up a new issue, with a subject heading something like:
move towards improved v2 version of command handling?
The command feature is cool, but it's not quite all the way there -- needs improvement.

@nexdrew
I don't think that there is too much unsolvable ambiguity here. The "command" strings (as opposed to just "flagless" arguments the CLI expects) are known and finite.
So even if the CLI doesn't restrict a command to a certain position, it is clear what the user expects from the context.

mytool --help command

when the "command" matches a known command string, it should display the help for that command
when the "command" doesn't matches a known command string should display the global help

mytool -g command  should behave depending on whether the -g flag expects an argument:

If it does, it takes precedence and the command is treated as a global argument -g. If the user still wants to use the "command" as such it has to be done in a way that satisfies the -g flag (e.g. mytool -g argument command)
if it doesn't (e.g. -g is just a boolean)

if command matches a known command string, it is invoked and passed the -g flag
if there is no known "command", it should run the default command-less variant (if allowed), pass the -g flag and pass the (unknown) "command" as a "flagless" argument.

These are just my observations of the most common behaviour or CLI tools and I think it makes sense.


[DOCS] Add quasar and @quasar/extras dependencies reminder

Excelent module! Appreciate your time and effort. We are very close to having Quasar + Nuxt + SSR!
It would be nice to add in the docs a reminder to install quasar and @quasar/extras packages.
Some people may be misdirected into thinking that this nuxt module also installs the dependencies.
I personally imagined I would have to install them and I did, and didn't have issues, but then decided to test, and uninstalled them, and bam error, and I was like "I knew it!" haha.
My only issue was not adding the fonts in nuxt.config.ts under the quasar object so for example the up and down arrows of a QSelect wouldn't show.
Wishing you health and success!

Hello! Thanks a lot for the feedback!
Hopefully this PR (#2) will eliminate the confusion regarding peer dependencies and missing icons on components.
Cheers!


mrsk setup gives SSH-2.0-Ruby/Net::SSH_7.1.0: No such file or directory

Running mrsk setup gives:
Acquiring the deploy lock...
Pseudo-terminal will not be allocated because stdin is not a terminal.
-bash: line 1: SSH-2.0-Ruby/Net::SSH_7.1.0: No such file or directory

I'm running with the proxy_command config as follows:
ssh:
  proxy_command: ssh -i ~/somekey.pem user@host

Debian 11
Ruby 3.1.2
mrsk 0.14.0

The proxy_command is typically used when you need to connect through a proxy or intermediary host before accessing the destination. Are you using proxy_command solely to specify a different SSH key, or do you need it to connect through a specific proxy host?
If your goal is just to specify a custom SSH key, you don't need to (and actually should not) use proxy_command for that.
Instead, you can load the desired SSH key into your SSH agent using the following command:
ssh-add ~/somekey.pem

By doing this, the key will be available for SSH sessions without having to specify it directly in the command line.


Don't Test Exception Messages?

It is extremely verbose:final Exception e = assertThrows(IllegalStateException.class, builder::build);
assertEquals(ChestImpl.SLOT_OUT_OF_BOUNDS.formatted(slot, guiRows), e.getMessage());

It requires a lot of messages to be @VisibleForTesting (the alternative is being even more verbose)
It isn't that important to test

Note this is only talking about the exception messages. Exceptions will still be tested.

May reconsider later.


Support range copy in copyObject and copyPart

What changes are proposed in this pull request?
Please outline the changes and how this PR fixes the issue.
Why are the changes needed?
Please clarify why the changes are needed. For instance,

If you propose a new API, clarify the use case for a new API.
If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including

change in user-facing APIs
addition or removal of property keys
webui

LGTM.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.8 please

alluxio-bot, cherry-pick this to branch-2.10 please


Allow passing future values of known_covariates to TimeSeriesCloudPredictor.predict

Currently predict and predict_real_time methods of the TimeSeriesCloudPredictor do not accept the future values of known covariates, which is a major difference from the TimeSeriesPredictor API.  We should allow users to pass future values of known covariates at predict time.

Hi any updates on this? predict_real_time does accept kwargs, but they are not actually passed through to the function.


Parse json strings with datetime as SQL timestamp

Problem
At present EventNative parse all JSON strings as strings and creates SQL columns with text type by default (if typecast isn't configured). Sometimes it is inconvenient to configure explicit SQL timestamp typecasts to every field. It can be recognized by default.
Solution
All input JSON strings with ISO DateTime format pattern 2006-01-02T15:04:05.000000Z must be parsed as timestamp and be mapped into SQL type as SQL timestamp.

Need that

Need that


No property for styling Header and Footer of PaginatedDataTable

Steps to reproduce
1. Create a PaginatedDataTable
PaginatedDataTable(
              header: const Text('CSV Data',
                  style: TextStyle(color: Colors.white)),
              columns: columns,
              source: _DataSource(rows),
              rowsPerPage: rowsPerPage,
              onRowsPerPageChanged: (perPage) {
                setState(() {
                  rowsPerPage = perPage!;
                });
              },
              columnSpacing: 16.0,
              horizontalMargin: 16.0,
              showCheckboxColumn: false,
              arrowHeadColor: Colors.black,
            )

2. Realize there are no widget level properties to style the header or footer elements besides the arrows
3. Attempt to wrap the PaginatedDataTable in a Theme()
Theme(
            data: ThemeData(
              secondaryHeaderColor: Colors.black,
              bottomNavigationBarTheme: const BottomNavigationBarThemeData(
                  backgroundColor: Color.fromARGB(255, 38, 44, 48)),
              bannerTheme: const MaterialBannerThemeData(
                  backgroundColor: Color.fromARGB(255, 38, 44, 48)),
              //textTheme: const TextTheme(caption: TextStyle(color: Colors.white)),
              dataTableTheme: DataTableThemeData(
                headingRowColor: WidgetStateProperty.resolveWith<Color>(
                    (Set<WidgetState> states) {
                  // Set color for heading row
                  return const Color.fromARGB(255, 38, 44, 48); // example color
                }),
                dataRowColor: WidgetStateProperty.resolveWith<Color>(
                    (Set<WidgetState> states) {
                  // Set color for data rows
                  return const Color.fromARGB(255, 38, 44, 48); // example color
                }),
                // Add other customizations here
              ),
            ),
            child: PaginatedDataTable(
              header:
                  const Text('CSV Data', style: TextStyle(color: Colors.white)),
              columns: columns,
              source: _DataSource(rows),
              rowsPerPage: rowsPerPage,
              onRowsPerPageChanged: (perPage) {
                setState(() {
                  rowsPerPage = perPage!;
                });
              },
              columnSpacing: 16.0,
              horizontalMargin: 16.0,
              showCheckboxColumn: false,
              arrowHeadColor: Colors.white,
            ),
          ),

Expected results

Actual results

Code sample
Code sample
https://dartpad.dev/?id=f2c59d9e6099c1234669d7f9a13d9eb1
The method/class responsible for creating hardcoded dummy data for the columns and rows, throws a Null check operator used on a null value when using command
flutter create bug

to make a minimal environment, so dartpad is only option to reproduce.
The code snippet will work in a normal flutter project

Flutter Doctor output
Doctor output
PS Y:\CODING PROJECTS\flutter_logviewer\bug> flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.22.3, on Microsoft Windows [Version 10.0.19045.4651], locale en-CA)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[X] Android toolchain - develop for Android devices
    X Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Build Tools 2022 17.10.5)
[!] Android Studio (not installed)
[√] Connected device (3 available)
[√] Network resources

! Doctor found issues in 2 categories.

I have added the missing properties to the PaginatedDataTable Class
It is now possible to achieve the expected output with:
PaginatedDataTable(
              footerStyle: const TextStyle(color: Colors.white),
              headerBackgroundColor: const Color.fromARGB(255, 38, 44, 48),
              footerBackgroundColor: const Color.fromARGB(255, 38, 44, 48),
              header:
                  const Text('CSV Data', style: TextStyle(color: Colors.white)),
              columns: columns,
              source: _DataSource(rows),
              rowsPerPage: rowsPerPage,
              onRowsPerPageChanged: (perPage) {
                setState(() {
                  rowsPerPage = perPage!;
                });
              },
              columnSpacing: 16.0,
              horizontalMargin: 16.0,
              showCheckboxColumn: false,
              arrowHeadColor: Colors.white,
            ),

Thanks for the report and submitting a PR. Since this hasn't been implemented yet so I will mark this as a feature request rather than a bug.


Fix typo in renga-python pointer

Fixes #104

Hi @sleinen,
Thank you very much for your contribution. We would like to ask you to sign the contributor license agreement so we can include your changes in the @SwissDataScienceCenter organisation.
SDSC_Contributor_License_Agreement_v1.0.pdf
If you have any questions, please do not hesitate to contact us.
Best,
Jiri

Thanks @jirikuncar. We're trying to get the CLA in place for all people at SWITCH who are likely to contribute.  Stay tuned...

Took a while, but my boss sent the signed CLA earlier today, including my name (among others).

closing this for now as per the discussions that took place in January. Thanks @sleinen for spotting the typo!


Import rest of special docs to SQL

Import the rest of the entries in special docs tab into SQL
Scrape what we can
Export incomplete entries
Recruit volunteer(s) to fill in needed metadata
Reimport back to SQL
Integrate with https://bit.ly/ard-suggestion to simplify future process

the data should now be in sql, so it can be cleaned by the poor unfortunate souls that will do it


feat: Issue Credential adds REST support

Adds REST support for the  Issue Credential protocol.
Closes #1650
Signed-off-by: Andrii Soluk<EMAIL_ADDRESS>

assuming bdd-test for rest controllers coming next.

I did not think about it. Thanks for the hint :)


Readme generation

Draft of README.md.

Removed e-mail addresses & tapered excessively honest installation section.


[EUWE] Added ability to connect to the container provider. https://bugzilla.…

…redhat.com/show_bug.cgi?id=1378190
With container objects added to the service model, it would be great to have the ability to manipulate objects back in the provider from the service model.  This pull request accomplishes that by expose the "connect" method.
Links

https://bugzilla.redhat.com/show_bug.cgi?id=1440141

@kevensen is this an Euwe only issue? If no, please reference a PR for 'master' branch.

@simaishi - I'd certainly prefer to.  However it looks like the container service model from https://github.com/ManageIQ/manageiq/pull/12863 is no longer in the master branch.

@simaishi - I take that back.  The container model is still but the container provider modules are gone.

Hey @kevensen - Empty service models were removed upstream now that we dynamically create them as per PR https://github.com/ManageIQ/manageiq/pull/14465.
If you want to expose additional properties of a model the service model file needs to be recreated and modified.  This will need to happen upstream first so I will be closing this PR.
Having said that we do not expose the connect method on any provider directly to automate.  I would suggest opening a PR or git issue upstream where we can discuss your use cases and see if there is some other way to accomplish what you are trying to do.

@gmcculloug - Understood.  I've opened https://github.com/ManageIQ/manageiq/pull/14771.


Updating Twitter branding to X

Description:
The website currently references Twitter in the footer navigation links as shown in the attached image. Given Twitter's recent rebranding to "X", we need to update the footer to reflect this change.
Steps to Reproduce:
Navigate to the website's footer.
Observe the list of links which includes "Twitter".
Expected Behavior:
The link text should be updated from "Twitter" to "X".

I'm working on this issue.


Support AES encryption in native HLS downloader

I am trying to get an extractor for daisuki.net working, but the M3U8 playlists have encryption keys.
Example:
#EXTM3U
#EXT-X-TARGETDURATION:10
#EXT-X-ALLOW-CACHE:YES
#EXT-X-KEY:METHOD=AES-128,URI="https://bngn-vh.akamaihd.net/i/43383936/35470338/smil/CA/00020/356591040701399.smil/crypt.key?null=&id=AgCAvZDZFzu8D7zB%2fVWWIHWJSVAxHhHvQvX7rIh3HuHom+D7tYdUh3WhlOWdnZuvwpxzfRMVvdeH8w%3d%3d"
#EXT-X-PLAYLIST-TYPE:VOD
#EXT-X-VERSION:3
#EXT-X-MEDIA-SEQUENCE:1
#EXTINF:10.000,
http://bngn-vh.akamaihd.net/i/43383936/35470338/smil/CA/00020/356591040701399.smil/segment1_1000000_av.ts?null=&id=AgCAvZDZFzu8D7zB%2fVWWIHWJSVAxHhHvQvX7rIh3HuHom+D7tYdUh3WhlOWdnZuvwpxzfRMVvdeH8w%3d%3d
#EXTINF:10.000,
http://bngn-vh.akamaihd.net/i/43383936/35470338/smil/CA/00020/356591040701399.smil/segment2_1000000_av.ts?null=&id=AgCAvZDZFzu8D7zB%2fVWWIHWJSVAxHhHvQvX7rIh3HuHom+D7tYdUh3WhlOWdnZuvwpxzfRMVvdeH8w%3d%3d
#EXTINF:10.000,
http://bngn-vh.akamaihd.net/i/43383936/35470338/smil/CA/00020/356591040701399.smil/segment3_1000000_av.ts?null=&id=AgCAvZDZFzu8D7zB%2fVWWIHWJSVAxHhHvQvX7rIh3HuHom+D7tYdUh3WhlOWdnZuvwpxzfRMVvdeH8w%3d%3d
...

There's a proposed implementation in #5882.
Note that ffmpeg should be able to download it (although it doesn't support ressuming)

Haven't been able to pass cookies to ffmpeg successfully, which are needed for Daisuki.

you can use the code in this commit https://github.com/remitamine/youtube-dl/commit/801cfb8fa9e221d2e729d8b0d44446fe4281df03 to be able to pass cookies to ffmpeg.

Haven't been able to pass cookies to ffmpeg successfully, which are needed for Daisuki.
it should work using the master branch (https://github.com/rg3/youtube-dl/pull/6267#issuecomment-142416339)

Thanks to @remitamine (#8201), AES decryption will be supported in the next version.


[SPARK-47060][SQL][TESTS] Check SparkIllegalArgumentException instead of IllegalArgumentException in catalyst

What changes were proposed in this pull request?
In the PR, I propose to use checkError() in tests of catalyst to check SparkIllegalArgumentException, and its fields.
Why are the changes needed?
By checking SparkIllegalArgumentException and its fields like error class and message parameters prevents replacing SparkIllegalArgumentException back to IllegalArgumentException.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the modified test suites.
Was this patch authored or co-authored using generative AI tooling?
No.

Merging to master. Thank you, @cloud-fan for review.


[CLOSED] Remove section from the style guide manual

 Issue by kalleth
Monday 06 October 2014 at 11:52 GMT
Originally opened as https://github.com/alphagov/specialist-publisher/pull/270

A section has inadvertently been added to the style guide manual which
needs removing. We don't have the facility to unpublish manuals yet, nor
remove them from the (recently added) content store, so we're going to:

Remove the manual section from the manual in specialist-publisher
Republish the manual manually (heh).

This will make the manual section disappear from the table of contents and
specialist publisher, but it will still show up in site search.

kalleth included the following code: https://github.com/alphagov/specialist-publisher/pull/270/commits

 Comment by bestie
Monday 06 October 2014 at 12:25 GMT

Apologies if you need to get this live straight away but I think we should be writing general purpose reusable scripts for one off, surgical data pruning.
Migrations should be reserved for when the code and data diverge and need to be kept in sync.

 Comment by evilstreak
Monday 06 October 2014 at 13:14 GMT

That's a good sentiment, and we should probably be doing that for the general case. For this case I'd be hesitant to write a reusable script for it because it's for removing a section that's already been published, and the change this makes isn't a full, robust solution for removing it.
Once we have the ability to do that (we need content store to allow documents to be removed) then we should be doing this as a script, or better yet as a service which we can expose through the admin interface.
Since I'd like to deploy this in the Really Near Future, I'm going to go ahead and merge it


could you tell me how to persistent the message?

i want to use this as im mqtt broker ,but how to persistent the session topic and message to redis?
anyone can give me some suggestions.thx!

I'm also trying to figure this out... Neither session providers nor topic providers allow saving published messages.


Test against many DSPy use cases and different models from unify

install requirements:
git+https://github.com/OscarArroyoVega/dspy.git@add_unify_client                               unifyai
try a dspy minimum working example with unify client

Hello @Sanjay8602, Would you like to make some documentation improvements so you will appear as a contributor in this integration (because this test will not).  As reference, pick the Unify documentation style: https://github.com/unifyai/unify/blob/main/unify/clients.py and the branch/ file you can document is this: https://github.com/OscarArroyoVega/dspy/blob/add_unify_client/dsp/modules/unify.py

ok sure


Compiler creates incorrect flows in some cases

In testing out the symbol processing logic, I noticed that the compiled flows don't look right in my test case.
The relevant part of the script looks like this:

MoveToHomePosition
CycleStart 1
MoveRelLastLocal $L, 0, 4, 0,
Doit $T
MoveRelLastLocal $l, 4, 0, 0,
Doit $T
MoveRelLastLocal $L, 0, 0, -4,
Doit $T
MoveRelLastLocal $L, 0, 0, 4,
Doit $T
MoveRelHomeLocal $L, -4, 0, 0,
Doit $T
MoveRelHomeLocal $L, 0, -4, 0,
Doit $T
CycleEnd 1

A snippet from the compiled code looks like this:

send("Flow,0,MCS,1,0,0,0")
send("Flow,600,MLC,10,0,0,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,13.78,-6.6,0 ,13.78,-10.6,0")
send("Flow,600,MLC,10,0,0,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,17.78,-6.6,0 ,13.78,-10.6,0")
send("Flow,600,MLC,10,0,0,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,17.78,-6.6,-4 ,13.78,-10.6,0")
send("Flow,600,MLC,10,0,0,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,17.78,-6.6,0 ,13.78,-10.6,0")
send("Flow,600,MLC,10,0,0,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,9.78,-10.6,0 ,13.78,-10.6,0")
send("Flow,600,MLC,10,0,0,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,13.78,-10.6,0 ,13.78,-14.6,0 ,13.78,-10.6,0")
send("Flow,0,MCE,1,0,0,0")
send("Flow,0,DC,1,4,0,0,0")

Extracting the coordinates for leg 5 (which is what $L is defined as):

,13.78,    -6.6,     0
,17.78,    -6.6,     0
,17.78,    -6.6,    -4
,17.78,    -6.6,     0
,9.78,      -10.6,    0
,13.78,    -14.6,    0

This sequence should have ended up back at the local home position, (13.78, -10.6, 0 ), but Y coordinate (middle one) is wrong.
I don't think it's relevant, but the symbol file looks like this:

/ test symbol template (next line is blank)
/ comment with continuation starting with a space character
so I can drone on
in extended comments
/and now we actually define some symbols:
/ H is the name of the robot, for MQTT purposes
Andrew: Hexbot94B97E5F4A40
Doug:   Hexbot3C61054ADD98
H Hexbot3C61054ADD98
/ input file location, including relative path
I scripts\test-from-folder.txt
/ output file location, including absolute path
O C:\Users\DougElliott\AppData\Local\MQTT-FX\scripts\01__hb-test-from-folder.js
/ parameterized leg number that will be tested by resulting js code
L 5
/ number of test cycles to repeat (plus the initial one)
C 4
/ time interval in milliseconds for each leg movement
T 600

Needed to capture this case, since I'm going to modify these files in symbol testing. Will debug at next opportunity.

Doh!  I think this is a simple issue. The last 2 move commands in the cycle use the MoveRelHomeLocal operation. It should have been the MoveRelLastLocal operation, like the rest. When I fixed this and reran it, I got essentially the right numbers, but with a tiny error. Here are the last 2 legs data in the compiled flows:
,13.78,-6.6,0 ,13.78,-10.6,0")
,17.78,-6.6,0 ,13.78,-10.6,0")
,17.78,-6.6,-4 ,13.78,-10.6,0")
,17.78,-6.6,0 ,13.78,-10.6,0")
,13.780000000000001,-6.6,0 ,13.78,-10.6,0")
,13.780000000000001,-10.6,0 ,13.78,-10.6,0")
Looks like some rounding is in order. I think we said that 2 decimal places for coordinates measured in centimeters would be sufficient. I'm surprised that this hasn't shown up earlier. Still investigating.

I used Math.Round to round the number being output to 2 places before it was converted to a string. The numbers used in computations weren't affected, just what's output to the .js file. closing and doing a quick merge.


oci_cloud_guard_managed_list returns no result.

Describe the bug
oci_cloud_guard_managed_list returns no data for select * oci_cloud_guard_managed_list query
it's wired that the CLI also returns no data
turbot-macpro-raj:steampipe-plugin-aws raj$ oci cloud-guard managed-list list --compartment-id ocid1.compartment.oc1..aaaaaaaapyuoosutfn32hlejabcdfcneehnoggdfgdfgscasrwqktbjuncgf2ia
{
  "data": {
    "items": []
  }
}

Steampipe version (steampipe -v)
Example: v0.9.0
Plugin version (steampipe plugin list)
Example: v0.3.1
To reproduce
Steps to reproduce the behavior (please include relevant code and/or commands).
Create the managed list in Cloud Guard and execute  select * oci_cloud_guard_managed_list
Area to look for,
It could have been affected to few tables, need further deep investigation

Whether previous versions working? Yes, as the new table results show in the respective PR
Might have broken from the new SDK version, hence we might have to start checking since

Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context about the problem here.

https://github.com/turbot/steampipe-plugin-oci/issues/278


examples/camera: Fix some issues and update license

Summary
Fix some issues and update license to Apache2.

Fix  failure to open the video driver.
Change format from YUV422 to RGB565,
and add captured image output to LCD.
An application cannot exit by infinite loop.
In video-only mode without capturing still images,
do not allocate capture memory for still images to
reduce the memory usage.

Impact
examples/camera
Testing
Tested by spresense:example_camera

@SPRESENSE
apps/examples/camera/camera_main.c:639:44: error: Operator/assignment must be followed with whitespace

@SPRESENSE
Error: camera_main.c:488:9: error: too few arguments to function 'video_initialize'

I have no objection if we merge it as it is


ARROW-4609: [C++] Use google benchmark from toolchain

@xhochy CI is failing.

The linker command looks fishy:
: && /home/travis/build/apache/arrow/cpp-toolchain/bin/ccache /usr/lib/ccache/g++  -ggdb -O0  -Wall -Wconversion -Wno-sign-conversion -Werror -msse4.2  -B/home/travis/build/apache/arrow/cpp-toolchain/bin -g  -rdynamic src/arrow/CMakeFiles/arrow-column-benchmark.dir/column-benchmark.cc.o  -o debug/arrow-column-benchmark  -Wl,-rpath,/home/travis/build/apache/arrow/cpp-build/debug:/home/travis/build/apache/arrow/cpp-toolchain/lib debug/libarrow_benchmark_main.a debug/libarrow_testing.so.13.0.0 debug/libarrow.so.13.0.0 -ldl /home/travis/build/apache/arrow/cpp-toolchain/lib/libdouble-conversion.a /home/travis/build/apache/arrow/cpp-toolchain/lib/libboost_system.so /home/travis/build/apache/arrow/cpp-toolchain/lib/libboost_filesystem.so /home/travis/build/apache/arrow/cpp-toolchain/lib/libboost_regex.so /home/travis/build/apache/arrow/cpp-toolchain/lib/libgtest.a /home/travis/build/apache/arrow/cpp-toolchain/lib/libgmock_main.a /home/travis/build/apache/arrow/cpp-toolchain/lib/libgmock.a -ldl /home/travis/build/apache/arrow/cpp-toolchain/lib/libbenchmark.a -lpthread jemalloc_ep-prefix/src/jemalloc_ep/dist//lib/libjemalloc_pic.a -pthread -lrt -Wl,-rpath-link,/home/travis/build/apache/arrow/cpp-toolchain/lib && :

the -lpthread is wrong. Our handling of pthreads is dealt with by the Threads::Threads variable which correctly adds -pthread (@fsaintjacques  was just telling me about the difference between these two things). This unfortunately is coming from gbenchmark's cmake config
set_target_properties(benchmark::benchmark PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "-lpthread"
)

This is a bug in gbenchmark. We may have to patch gbenchmark in conda-forge. See
https://stackoverflow.com/a/39547577/776560
also
https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L397

https://github.com/apache/arrow/blob/master/cpp/CMakeLists.txt#L837

I just submitted a PR to gbenchmark
https://github.com/google/benchmark/pull/771

Google accepted my PR. In the meantime I think we can handle this in the conda-forge build
https://github.com/conda-forge/benchmark-feedstock/pull/4

Hm, it looks like the gbenchmark fix was not sufficient. It seems that the conda-forge packages for gbenchmark are not usable with the Ubuntu Xenial system compilers
cc @pitrou

libstdc++ on 18.04 (Bionic) does have the required symbols:
$ nm --defined-only --demangle /home/antoine/miniconda3/envs/pyarrow/lib/libstdc++.so.6 | \grep std::thread::_M_start_thread
00000000000b8738 T std::thread::_M_start_thread(std::shared_ptr<std::thread::_Impl_base>)
00000000000b869e T std::thread::_M_start_thread(std::shared_ptr<std::thread::_Impl_base>, void (*)())
00000000000b8576 T std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State> >, void (*)())

Perhaps it's a matter of linker option order? Does libbenchmark.a have to come before libarrow.so?

In Travis here I think the Ubuntu 16.04 toolchain is being used

What do you want to do with this patch? Seems that using the CF packages with Ubuntu Xenial's gcc 5.4 is a non-starter

I'm addressing this in https://github.com/apache/arrow/pull/3688


tf_expression: bed file format

I got tf_expression.py: get_genes function to work but I don't think the function is looking for a bed file per the definition of bed file format in the following reference:
https://genome.ucsc.edu/FAQ/FAQformat.html#format1
The file it successfully reads is: ALL_ARRAYS_NORMALIZED_MAXPROBE_LOG2_COORDS.sorted.txt
Whose format is:
CHR	START	STOP	GENE	<sample 1>	<sample 2>	...
The bed format does not seem to allow multiple scores, but rather expects 1 score and no more than 12 columns of data. Each column is a distinctly different piece of information rather than the same piece for different samples.

Yeah, it's pretty common to refer to file formats like we're using as "BED-like" files, due to the genome coordinates occupying the first three columns and using the BED convention for them (0-based). I guess I should be more explicit with my word choice, probably better to just refer to them as "tab-delimited data files in a BED-like format" since they aren't true BED files. Sorry for the confusion.


Cannot override the file input names used in the http request

Whatever I do to the  field the form names sent are files[0], files[1], ...
This complicates the backend. I want to override this name to be simply: myfiles, myfiles, ... (same).
Tried setting name="myfiles" but with no luck.

arrayKey: '' read the docs

@danialfarid thank you for your quick reply. That fixed my problem :)
btw the documentation needs more effort to make it easier to reach the information without having to read it in full.


[thi.ng/vectors] heading for a segment

Hi!
Sometimes I need to have the heading of a 2D line segment (befined by two points) as fast as possibile:
const headingSegment = (a , b) => Math.atan2(b[1] - a[1], b[0] - a[0])

Right now one possibile way to achieve this with existing packages could be:
const { direction, heading } = require<EMAIL_ADDRESS>heading(direction([], a, b), [0, 1])

But it requires a new array allocation for the direction.
Question: are there better ways to do it with existing package? Is it possibile to add it in umbrella/packages/vectors/src/heading.ts? In case, what would be a better name to have a non-confusing signature next the current ones?

I think that's a great idea & headingSegment is a good name for it. The current workaround using direction() is not great, since it also normalizes the direction vector, so you don't want to use this in this case...
i just released a new version of the package with these new fns:
https://github.com/thi-ng/umbrella/blob/master/packages/vectors/src/heading-segment.ts
Hth!

thanks!


Custom loader

One-line summary
I would like to add custom loader to echarts, because I want to use loader in another part of my application and the styles/look should be the same.
Version & Environment

ECharts version:  4.1.0
Browser version: chrome 70
OS Version: Windows 10 Pro

Expected behaviour
Define custom styles of loader and put them into echarts.

Hi, what do you mean by a loader, and what is it used for?

Make a loader by dom and cover it on the echarts container, does it meet the requirement?

It is possible (I think), but it's not the solution. It would be fine to use this - https://echarts.apache.org/api.html#echartsInstance.showLoading. I think it would be fine improvement in this package.

Loading styles may differ greatly for varied requirements. So I guess this has to be done by DOM, or do you have other suggestions on how we could provide this style setting in a more general way?

Hi, at least we should use .gif for the loading animation, for example, I want to use the loading dots instead of the loading cycle, I have a loading dots animated gif file, it could be perfect if I can directly use it.


Fixed "already defined" linking errors due to missing "inline" directives

For reference, this fixes #130. Thanks very much for the PR!


How should I auto import composition functions

Hey,
So far the plugin works great for importing vue, vue-router.
So as I am working with vue3, let's assume an example where I have two composition functions in my src/composition, named: useSearch.ts and useFilter.ts...
The first question is: Should I attempt to auto-import them into my components or because those functions will not be used as much as something like ref from vue3 I should just stick to normal imports?
If you advise me to do so, how should I be able to do that? I've attempted to create src/composition/index.ts where I export all of my functions and in vite.config.ts I added the below code, but it tells me when the app runes in the browser that it 'Failed to resolve import "src/composition"'
    AutoImport({       imports: ["vue", "vue-router", "@vueuse/head", { "src/composition": ["useSearch"] }],       dts: "src/auto-imports.d.ts",     }),

@AlexandruSerban142  配一个别名可以吗？
  composition：path.resolve(__dirname, 'src/composition')
import { useSearch } from 'composition'

hello, about the automatic introduction of custom composition API in the project, I have defined a path alias and resolver.
The simplest example 👇👇👇
// vite.config.ts
import { resolve } from 'path'
import { defineConfig } from "vite"
import Vue from '@vitejs/plugin-vue'
import type { Resolver } from 'unplugin-auto-import/dist/types'

const compositionResolver: Resolver = name => {
	const isCompositionApi = name.startsWith('use')
	if (isCompositionApi) {
	  return `~/composition/${name}`
	}
}

export default defineConfig({
  resolve: {
    alias: {
	'~/': `${resolve(__dirname, 'src')}/`
    }
  },
  plugins: [
    Vue(),
    AutoImport({
      resolvers: [compositionResolver]
    })
  ]
})

src/composition/useFoo.ts
// The default export will be loaded on demand
export default 200

src/App.vue
<script setup lang="ts">
 console.log(useFoo) // Automatic on demand，will log 200
</script>

//....

Of course, it's not safe, but I'm trying to use the node to solve this problem.
Here are the idea 👇👇👇
watch and collect all file names in the target directory, and judge when resolve 😁。
More specific engineering practices 👉 tov-template

你好，关于项目中的组合式 api 自动按需引入，我的做法是定义一个路径别名还有 resolver 解析器。
最简单的例子 👇👇👇
// vite.config.ts
import { resolve } from 'path'
import { defineConfig } from "vite"
import Vue from '@vitejs/plugin-vue'
import type { Resolver } from 'unplugin-auto-import/dist/types'

const compositionResolver: Resolver = name => {
	const isCompositionApi = name.startsWith('use')
	if (isCompositionApi) {
	  return `~/composition/${name}`
	}
}

export default defineConfig({
  resolve: {
    alias: {
	'~/': `${resolve(__dirname, 'src')}/`
    }
  },
  plugins: [
    Vue(),
    AutoImport({
      resolvers: [compositionResolver]
    })
  ]
})

src/composition/useFoo.ts
// 默认的导出将被自动按需引入
export default 200

src/App.vue
<script setup lang="ts">
 console.log(useFoo) // 按需自动引入，打印200
</script>

//....

当然这是不安全的，不过我尝试使用 node 去解决这个问题。
以下是我的想法 👇
监视并收集目标目录中的所有文件名，并在解析时判断。
更多的工程实践可见 👉 tov-template

For the context, here is how I implemented it in Nuxt 3 https://github.com/nuxt/framework/pull/1176
If anyone wants to work on it you could use it as some reference.

I like nuxt hooks，It's really convenient

For the context, here is how I implemented it in Nuxt 3 nuxt/framework#1176
If anyone wants to work on it you could use it as some reference.

Hey @antfu, I have a Nuxt 3 site that imports some external Vue components that rely on Vue and Nuxt imports. When these components are not external and placed in the Nuxt /components folder, the auto imports work fine. but when I move the packages out into the NPM package, they don't, which is to be expected I guess as only the /components and /composables folders implement the auto imports in Nuxt.
Is there a way for me to extend this functionality and get Nuxt to looks in my NPM packages folder too? I don't see anything in the Nuxt docs regarding this but wonder if there is an advanced way to do this?

This is a resolver that automatically loads modules under a specific directory 👉 vite-auto-import-resolvers
这是一个按需自动加载特定目录下模块的 resolver 👉 vite-auto-import-resolvers

I want to use react+vite+vite-auto-import-resolvers, but Vite seems not work very well with react.

This is already supported via dirs option

This is already supported via dirs option

Nice, I will recommend it in vite-auto-import-resolvers readme


Rename the following items: - "model Transaction" after upgrade from 2.1 to 2.2

The schema contains the model "Transaction" - this was fine in 2.1.3 but after upgrading to 2.2.2  - we're now receiving the following error:
Error:
Error: The schema at "/Users/aaron/Desktop/Ember/prisma/schema.prisma" contains reserved keywords.
       Rename the following items:
         - "model Transaction"
To learn more about how to rename models, check out https://pris.ly/d/naming-models

Feels like it could have something to do with the transactionsApi - is this expected?

Yes, that is indeed a side effect we are currently discussing internally as well.
Does this happen both with the transactionsApi feature flag enabled and disabled?

We don't have the transactionsApi enabled. Was this expected? Feels like a breaking change...

We are exploring how we want to deal with new client methods in a non breaking way. Please disable the experiment for now if this is breaking for you.
You can also do this if you want keep the name in the database for now:
model _Transaction {
// fields here
@@map("Transaction")
}

This is really a duplicate of https://github.com/prisma/prisma-engines/issues/892#issuecomment-656141929 but I will keep this open here as that repository is rarely searched by our users.

As it turns out the denylist was not behind the feature flag @pantharshit00 - so this is a very different bug. It hsould not have affected @aarshaw without enabling the feature flag which he did not do.


TypeScript (?) "API" section is obfuscatory

https://github.com/rbuckton/proposal-using-statement/tree/c0c82628c26be217937e22776f922ba8666a35da#api
I have no idea what this means. I assume it's using TypeScript because I know you work in that language, but I've never heard of SymbolConstructor or readonly.
It'd be better to describe this using prose.

I agree that this should also be described using prose, but I also believe that the API code sample is useful.
Fixed by f09a1ae4a33b82723086ce190aafc94805fe55ae


Devtools Issue meta[name=theme-color]

'meta[name=theme-color]' is not supported by Edge, Firefox, Firefox Android, Opera, Safari, iOS Safari.
Remove the tag from the server/template.js to fix the issue.

I can fix this issue! :)


[2.0][improvement](jdbc catalog) support sqlserver timestamp type read

Proposed changes
Issue Number: close #xxx
pick from (#31805)
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Session start and end events

Changes
This serves as an alternative/successor to #1042. Instead of describing a session change event, we have a session start and session end event instead.
Merge requirement checklist

[x] CONTRIBUTING.md guidelines followed.
[x] Change log entry added, according to the guidelines in When to add a changelog entry.

If your PR does not need a change log, start the PR title with [chore]

[x] schema-next.yaml updated with changes to existing conventions.

@breedx-splk I think it would be good to have folks from the event and client working groups to take a look and approve this? Are you in touch with them? We don't seem to have a GitHub team for them so not sure how to get attention.

3 approvals, are we waiting for anything else on this? 🙏🏻

@breedx-splk please resolve open discussions (if they are resolved) and it should be ready to go


Ability to set client certificate per API

Now client certificates can be set only on nginx configuration level.
We need to set them per connection.
Depends on https://github.com/openresty/lua-nginx-module/pull/997 and https://github.com/openresty/lua-resty-core/pull/89

User can set client certificate per API with TLS termination policy.


Update common-utils branch to 1.2

Signed-off-by: Ashish Agrawal<EMAIL_ADDRESS>Description
Update common-utils branch to 1.2
Issues Resolved
N/A
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #905 (369749e) into main (241cbb8) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
- Coverage   91.58%   91.36%   -0.22%
==========================================
  Files          87       87
  Lines        2294     2294
==========================================
- Hits         2101     2096       -5
- Misses        193      198       +5

Impacted Files
Coverage Δ

src/system/temporary_directory.py
82.75% <0.00%> (-13.80%)
:arrow_down:

src/system/os.py
92.30% <0.00%> (-7.70%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 241cbb8...369749e. Read the comment docs.


🐛 Fix bug when sourceField null/undefined

fixes #20

Thanks!
Do you think though the second check is necessary, when an empty string is equal to false in JS? I.e. !'' = true.

@thetre97 I have updated this bugfix with the requested changes and enabled the corresponding test around it too.

LGTM! Thank you.


Itch.io

The android and mac builds could go on Itch.io, and in fact they were previously, but for now they are only on this repo (releases) to minimize work and keep my itch.io page game-only.

I stopped publishing on itch.io a couple of months ago due to a spate of homophobic ("why is this site so gay?") posts.


How to use SentiCap dataset and FlickrStyle10k dataset?

Dear author, your paper is very creative and I am very interested in it. I am preparing to reproduce your experiment, but the code you provided does not seem to explain how to use the SentiCap dataset and FlickrStyle10k dataset. Can you give me some guidance? I would appreciate it if you could take the time to reply to me.

Thanks for your positive comment. We follow the dataset split in MSCap and MemCap to train a TextCNN classifier. Details of splits and code of TextCNN are as follows:

class textCNN(nn.Module):
    def __init__(self, kernel_num, vocab_size, kernel_size, embed_dim, dropout, class_num):
        super(textCNN, self).__init__()
        ci = 1  # input chanel size
        self.embed = nn.Embedding(vocab_size, embed_dim, padding_idx=1)
        self.conv11 = nn.Conv2d(ci, kernel_num, (kernel_size[0], embed_dim))
        self.conv12 = nn.Conv2d(ci, kernel_num, (kernel_size[1], embed_dim))
        self.conv13 = nn.Conv2d(ci, kernel_num, (kernel_size[2], embed_dim))
        self.dropout = nn.Dropout(dropout)
        self.fc1 = nn.Linear(len(kernel_size) * kernel_num, class_num)

    def init_embed(self, embed_matrix):
        self.embed.weight = nn.Parameter(torch.Tensor(embed_matrix))

    @staticmethod
    def conv_and_pool(x, conv):
        # x: (batch, 1, sentence_length,  )
        x = conv(x)
        # x: (batch, kernel_num, H_out, 1)
        x = F.relu(x.squeeze(3))
        # x: (batch, kernel_num, H_out)
        x = F.max_pool1d(x, x.size(2)).squeeze(2)
        #  (batch, kernel_num)
        return x

    def forward(self, x):
        # x: (batch, sentence_length)
        x = self.embed(x)
        # x: (batch, sentence_length, embed_dim)
        # TODO init embed matrix with pre-trained
        x = x.unsqueeze(1)
        # x: (batch, 1, sentence_length, embed_dim)
        x1 = self.conv_and_pool(x, self.conv11)  # (batch, kernel_num)
        x2 = self.conv_and_pool(x, self.conv12)  # (batch, kernel_num)
        x3 = self.conv_and_pool(x, self.conv13)  # (batch, kernel_num)
        x = torch.cat((x1, x2, x3), 1)  # (batch, 3 * kernel_num)
        x = self.dropout(x)
        logit = self.fc1(x)
        return logit

    def get_batch_captions_style_scores(self, captions, tokenizer, device):
        input_ids = tokenizer.batch_encode_plus(captions, padding=True)['input_ids']
        input_ids_ = torch.tensor(input_ids).to(device)
        logits = self.forward(input_ids_)
        probs = F.softmax(logits, dim=-1)
        predicts = logits.argmax(-1)

        return probs, predicts

    def init_weight(self):
        for m in self.modules():
            if isinstance(m, nn.Conv2d):
                n = m.kernel_size[0] * m.kernel_size[1] * m.out_channels
                m.weight.data.normal_(0, math.sqrt(2. / n))
                if m.bias is not None:
                    m.bias.data.zero_()
            elif isinstance(m, nn.BatchNorm2d):
                m.weight.data.fill_(1)
                m.bias.data.zero_()
            elif isinstance(m, nn.Linear):
                m.weight.data.normal_(0, 0.01)
                m.bias.data.zero_()

Your reply has been a great help to me. Thank you very much.

Dear author, I am reproduce your experiment of table 4. I set the parameter sentiment_type ，candidate_ k, num_ iterations,  α, β ，γ， sentence_ len is positive, 200, 15, 0.02, 2, 5, and 10. The test results show that BLEU-3 is 1.45, MENTOR is 7.65, and CLIP-S is 0.99, which is a little different from the results in Table 4. In addition, I trained a texCNN sentiment classifier to calculate Acc, but I was unable to obtain the Acc in the table. Could you tell me more about the experimental details in Table 4 and provide the complete code for calculating Acc?

Dear author, I have the same question about the results in Table 4, could you provide the complete code for training of TextCNN classifier and calculating Acc?

Can you tell me where the factual captions came from? Did you randomly choose from the coco test or somewhere else?

Dear author, I am reproduce your experiment of table 4. I set the parameter sentiment_type ，candidate_ k, num_ iterations, α, β ，γ， sentence_ len is positive, 200, 15, 0.02, 2, 5, and 10. The test results show that BLEU-3 is 1.45, MENTOR is 7.65, and CLIP-S is 0.99, which is a little different from the results in Table 4. In addition, I trained a texCNN sentiment classifier to calculate Acc, but I was unable to obtain the Acc in the table. Could you tell me more about the experimental details in Table 4 and provide the complete code for calculating Acc?

Can you tell me where the factual captions came from? Did you randomly choose from the coco test or somewhere else?


[Misc] improve logits processors logging message

Just a small improvement to the logits processors logging message so that the offending token_id is included in the error message.

/ready


Not being able to retrieve new metadata

Summary
Creating new metadata, a custom field for example, does not get retrieved. Results show "No results found". When I create the metadata by hand locally and then retrieve, it retrieves the field successfully. Is there a new setting? Me and my colleague are experiencing the same with ExperienceBundle.
Steps To Reproduce:

Create new custom field.
Try to retrieve by sfdx force:source:retrieve -m CustomField:Object.Field__c.

Expected result
Retrieves the new field.
Actual result
Doesn't find any results.
System Information

I am using zsh.

{
  "cliVersion": "sfdx-cli/7.163.0",
  "architecture": "darwin-x64",
  "nodeVersion": "node-v16.16.0",
  "pluginVersions": [
    "@oclif/plugin-autocomplete 1.3.0 (core)",
    "@oclif/plugin-commands 2.2.0 (core)",
    "@oclif/plugin-help 5.1.12 (core)",
    "@oclif/plugin-not-found 2.3.1 (core)",
    "@oclif/plugin-plugins 2.1.0 (core)",
    "@oclif/plugin-update 3.0.0 (core)",
    "@oclif/plugin-version 1.1.1 (core)",
    "@oclif/plugin-warn-if-update-available 2.0.4 (core)",
    "@oclif/plugin-which 2.1.0 (core)",
    "alias 2.1.0 (core)",
    "apex 1.1.0 (core)",
    "auth 2.2.3 (core)",
    "community 2.0.0 (core)",
    "config 1.4.17 (core)",
    "custom-metadata 2.0.0 (core)",
    "data 2.1.1 (core)",
    "generator 2.0.2 (core)",
    "info 2.0.1 (core)",
    "limits 2.0.1 (core)",
    "org 2.0.7 (core)",
    "schema 2.1.1 (core)",
    "signups 1.2.0 (core)",
    "source 2.0.11 (core)",
    "telemetry 2.0.0 (core)",
    "templates 55.1.0 (core)",
    "trust 2.0.3 (core)",
    "user 2.1.0 (core)",
    "@salesforce/sfdx-plugin-lwc-test 1.0.0 (core)",
    "salesforce-alm 54.7.1 (core)",
    "sfdmu 4.15.1 (user)",
    "sfpowerkit 4.2.13 (user)"
  ],
  "osVersion": "Darwin 21.6.0"
}

@jakobpack I'm unable to reproduce this with both latest (7.163.0) or latest-rc (7.164.1)
Are you able to provide steps to reproduce the issue? Thanks!

I found the problem. It occurs when multiple packageDirectories are present in sfdx-project.json.
Reducing them to only one path, fixes the problem.

@jakobpack Thanks for the update. I just tried to replicate it with the following

clone https://github.com/salesforcecli/sample-project-multiple-packages (this project already has multiple entries in packageDirectories
cd sample-project-multiple-pacakges
sfdx force:org:create -f config/project-scratch-def.json -s
sfdx force:org:open
Create new CustomField on Account
sfdx force:source:retrieve -m CustomField:Account.Test__c

Which was successful:
~/repos/salesforcecli/sample-project-multiple-packages (main*) » sfdx force:source:retrieve -m CustomField:Account.Test__c
Preparing retrieve request... done
=== Retrieved Source

 FULL NAME       TYPE        PROJECT PATH
 ─────────────── ─────────── ────────────────────────────────────────────────────────────────────
 Account.Test__c CustomField force-app/main/default/objects/Account/fields/Test__c.field-meta.xml

Are you able to share a repo that replicates it? Thanks!

Closing due to inactivity. If you are able to provide reproduction steps, please feel free to re-open this issue 🙇 Thanks!


browse() failed die to xml parser

Contentdirectory:1
response: Browse(
“<DIDL-Lite xmlns:dc="http://purl.org/dc/elements/1.1/"
xmlns:upnp=”urn:schemas-upnp-org:metadata-1-0/upnp/”
xmlns=”urn:schemas-upnp-org:metadata-1-0/DIDL-Lite/”>
<container id=”0” parentID=”-1” childCount=”2” restricted=”true”
searchable="true">

Contentdirectory:3, 4
Response: Browse("
<?xml version="1.0" encoding="UTF-8"?>
<DIDL-Lite
xmlns:dc="http://purl.org/dc/elements/1.1/"
xmlns="urn:schemas-upnp-org:metadata-1-0/DIDL-Lite/"
xmlns:upnp="urn:schemas-upnp-org:metadata-1-0/upnp/"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="
urn:schemas-upnp-org:metadata-1-0/DIDL-Lite/
http://www.upnp.org/schemas/av/didl-lite.xsd
urn:schemas-upnp-org:metadata-1-0/upnp/
http://www.upnp.org/schemas/av/upnp.xsd">
<container id="1" parentID="0" childCount="2" restricted="0">

If string:  <?xml version="1.0" encoding="UTF-8"?> is present in response than fail occur.
I fix this in my php-upnp server: https://github.com/rozhuk-im/ssdpd/commit/b28c21da527c583716d9f19d76c20986ed619533
But probably others upnp/dlna servers return htis string.
I use latest VLC for win in my tests.

I think you will need to report this to the VLC guys, libupnp just passes the XML through as a string to the client code.

This is xml parser problem.

I'm sure this won't get fixed in that old version. Maybe it's gone maybe not, but it definitely is way too long inactive.


Fix the flaky tests

Currently, the tests appear to be flaky in our CI (tldr: they're not).
That's because cargo-flaky doesn't handle workspaces correctly.
A simple fix is to simply cd in each sub-directory to run flaky test instead of running it at the root of the project.
But the real fix should be implemented in cargo-flaky; since our use-case is pretty simple and we're our only users, it should be fairly simple to extract all the existing modules and their associated paths and see if it matches the binary we're trying to run; if it's the case, we execute the process from this path.
In the future, we should definitely look into a better way to handle this process, I'm sure we're not the first one stumbling on this kind of issue.
Also, I took a quick glance at cargo-nextest and I must admit I did not really understand when they're changing their path before running their test, so maybe there is another way that I don't know.

More additional details about this issue in the old created one: https://github.com/meilisearch/meilisearch/issues/3196#issue-1478708954

https://github.com/meilisearch/meilisearch/pull/3348/files partially fixes the issue. However, we will have to add every new sub crate to the CI, which is not convenient. Ideally, we should revert this commit and fix cargo-flaky directly.


Provide script to simplify running of  podman/docker commands

As part of release publish a script which enables a partner to run the chart verifier docker image without having to use the full podman/docker command.

The script should be along the lines of the following (tested locally
against a CRC cluster):
  docker run --rm -i									\
	 -e KUBECONFIG=/.kube/config						\
	 -v "${HOME}/.kube":/.kube							\
	 "quay.io/redhat-certification/chart-verifier:main" \
	 verify												\
	 https://dperaza4dustbit.github.io/helm-chart/psql-service-0.1.7.tgz

The --kubeconfig flag is available but has an issue tracked in #116.


MenuBar Appium C# desktop app

Hello,
How to Access a menubar,example:Window->Create->New.
I tried to find it by name like app.FindElementbyName(“Window”).Click(); ,it’s clicking it,but then failed if I try and do the same but finding the other elements.I tried to do app.FindElementbyName(“Window”).FindElementbyName(“Create”).FindElementbyName(“New”).Click , the same Failed.
Any help please?

I don't know what kind of menubar you are using. I guess there are two possible ways to open the menubar: mouse clicking or mouse hover over.
From your description, most likely, the menu bar is opened when mouse is hovering over. In that case, you may need to use moveTo function other than click.
Another case is timing. After one user interaction like clicking, the next element may not be ready immediately like 'Create' , you may need to sleep some time to make 'Create' to show up and you can perform action on it. It's easy for you to implement a wait until function like below which Appium supports.
WebDriverWait wait=new WebDriverWait(driver, timeOutInSeconds)
wait.until(ExpectedConditions.elementToBeClickable(WebElement));


NIFI-13409 Enforcing lexiographical order of the identity mappings to match documentation

Summary
Referred documentation: https://nifi.apache.org/docs/nifi-docs/html/administration-guide.html#identity-mapping-properties
NIFI-13409
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[ ] Apache NiFi Jira issue created

Pull Request Tracking

[ ] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[ ] Pull Request based on current revision of the main branch
[ ] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 21

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

@simonbence Just following up on this, glad to help bring this to completion, so let me know if you have any questions about the comments provided earlier.

Hi @exceptionfactory !
For full disclosure, it looks like there is already an ordering within the mapping process: here
I take a looks of the usages and it seems to me that not all usages of the method is based (directly) on the result of the getMapping (example, so I could not safely say that the original ordering is enough.
The question comes however if with this addition we still need the original ordering or not. I would not disturb it within this ticket but later on it might be a reasonable move to remove that (after considering the possible implications)

Thanks for following up @simonbence. That's a good point about values already being sorted. The other reference you noted is for NiFi Registry, which is a different class. With the existing sorting, have you traced down where the sorting is not being applied on NiFi itself? It would seem to render the current set of changes unnecessary.


Broken @import declaration

Sails version: 1.0.2
Node version: 8.11.4
NPM version: 6.2.0
DB adapter name: N/A
DB adapter version: N/A
Operating system: Opensuse TW

Hello,
Im try to run my sails app to production but found problem about Grunt Broken @import declaration for importing css file. im try to rename .css file to .less but still not working. how to fix it ?

Hi @yogisaka I'm interested in looking into this problem, but I wasn't able to recreate it. Can you post the error messages you were getting and the code from you importer.less file?

thanks for response
im found error like this
Aborted due to warnings.
Running "cssmin:dist" (cssmin) task
Warning: Broken @import declaration of "spinners.css",Broken @import declaration of "materialdesignicons.min.css"

and code import from file name style.css
@import "spinners.css";@import "materialdesignicons.min.css";

but after this, im try rename again style.css to style.less. its work. but im found other problem again, css and js not work on html, after generate minify on production.min.css/.js my css and js not work. im try to fix my css and js file.
on config production file. can i write option to make not generate less file on specific file ?
but if cant do it, im try to fix my css and js file, thanks

@yogisaka LESS is backwards compatible with CSS meaning, you dont have to worry about changing your file type! You should be able to write/copy/edit your CSS in a .less file without any problems.
http://lesscss.org/

Thanks. im found this soulution my css and js. make grunt not run on production, its work again. because my css and js broken after run grunt.