Feature Add Oracle driver

Description
I wanted to use CodeIgniter4 in an Oracle environment.
Also, it was determined that support would be provided because ORACLE was described in the document.
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[x] User guide updated
[x] Conforms to style guide

The design of the program to get the insertId of this PR is not so good.
Please good solution.

I tried using this driver with Oracle 18C, it works fine.
Thank you @ytetsuro

@ytetsuro @lonnieezell
This repo has GitHub workflows with Oracle image.
https://github.com/yiisoft/db-oracle

@ytetsuro @lonnieezell
This repo has GitHub workflows with Oracle image.
https://github.com/yiisoft/db-oracle

I was working on tests for this at some point and the main problem I had, was how to set an empty database because by default oracle comes with a lot of additional tables that break our tests. Also, I think we need at least Oracle 12 to support "auto-increment" values.
Maybe this thing with a fresh database is trivial but my DevOps skills are low 😅

I was working on tests for this at some point and the main problem I had, was how to set an empty database because by default oracle comes with a lot of additional tables that break our tests. Also, I think we need at least Oracle 12 to support "auto-increment" values.
Maybe this thing with a fresh database is trivial but my DevOps skills are low 😅

Any update on the availability of OCI8 driver support for CI4 ?

@kenjis

This repo has GitHub workflows with Oracle images.

Very thanks.
Using the same idea, I checked the containers used in version 12c and above and found that quillbuilduser/oracle-18-xe was used.
The following repositories use this container.

https://github.com/getquill/quill
https://github.com/knex/knex/blob/01cfa98c2cdd9d2f8c91320d4551efdaa1768d21/scripts/docker-compose.yml
https://github.com/JetBrains/Exposed/blob/b6d00e51062c91c6b23a89de55f900e2e4f24225/buildScripts/docker/docker-compose-oracle.yml

@lonnieezell
@kenjis

we need to get Travis setup to be able to test it if possible

Changed GitHub Actions so that the OCI8 tests work with the above container.
Please review.

@ytetsuro @lonnieezell @michalsn @jkashwin @javawebmedia
What version of Oracle Database should this driver support?
12.1+?
12.2+?
18c+?
other?
And we need to add about this driver in
https://codeigniter4.github.io/CodeIgniter4/intro/requirements.html

@kenjis
Thanks for the quick feedback.

What version of Oracle Database should this driver support?

I think 12.1+.
I used the following version of this driver when I created it.

12.1
18c

The driver I created this time doesn't seem to use any of the features that were deprecated in 18c, so I think 12.1+ is fine.
https://docs.oracle.com/en/database/oracle/oracle-database/18/upgrd/behavior-change-deprecate-desupport-oracle-12c-rel-2.html#GUID-3BAFD95E-4D00-4F0F-BC80-6064F497F878

@ytetsuro

The design of the program to get the insertId of this PR is not so good.

What's wrong with it?

@kenjis

What's wrong with it?

My approach is to allow the last insert id to be retrieved only when a row is added with QueryBuilder::insert().

For developers, I think it would be better if the API asked for the table name and explored the SEQUENCE internally, what do you think?

I think passing the table name is better for developers.

My concern is that insertID() is defined as abstract in the parent class.

If we add a parameter, it is a breaking change.
https://3v4l.org/JTMSP
So we can't include the change in the next release.
We will add that feature in the future and I recommend that it not be included in this PR.
Incidentally, CI3 has the three type of insert_id():
public function insert_id()
public function insert_id($generator_name, $inc_by = 0) ... ibase
public function insert_id($name = NULL) ... pdo

Would it still be a disruptive change if it does not affect existing users by using the default argument feature as follows?

It is still a breaking change. If a user extends BaseConnection, it breaks.
https://3v4l.org/lnu0u

@kenjis
Thanks, good response.

If a SQL statement is INSERT, we get the table name. To do so, we need to parse the statement.

Good!
If it's an INSERT, the subquery won't be the target, so it'll be easy to parse the table name!
But, I have discovered a new problem.😭
The way we are thinking now, we will get an unintended id.
SEQUENCE is not unique for a connection.
This means that if you and I execute a write operation at the same time, and I get the last id, my process may get the id that you wrote.🤮
MySQL's last_insert_id is also set on a per-connection basis.

The ID that was generated is maintained in the server on a per-connection basis.

https://dev.mysql.com/doc/refman/8.0/en/information-functions.html#function_last-insert-id
With this in mind, at the moment I can't think of a way to get the last id with the query() method.😭😭

@ytetsuro Thanks!
It seems all the problems except the bug on storedProcedure() are solved.

There were 104 errors:

1) CodeIgniter\Database\Live\OCI8\CallStoredProcedureTest::testCallPackageProcedure
ErrorException: oci_execute(): ORA-06550: line 1, column 7:
PLS-00201: identifier 'CALCULATOR.PLUS' must be declared
ORA-06550: line 1, column 7:
PL/SQL: Statement ignored

/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/OCI8/Connection.php:201
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/BaseConnection.php:670
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/BaseConnection.php:598
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/OCI8/Connection.php:520
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/Live/OCI8/CallStoredProcedureTest.php:51

https://github.com/codeigniter4/CodeIgniter4/runs/4568866943?check_suite_focus=true

@kenjis
Hi.
Very thanks response and long-time review.

It seems all the problems except the bug on storedProcedure() are solved.

Fixed it.
Please help me.
I want to create stored procedure in migration.
But, happen following error when using oci_parse.
Is it possible to create a stored procedure using the oci8 extension?
ErrorException: oci_execute(): OCI_SUCCESS_WITH_INFO: ORA-24344: success with compilation error in
The documentation for oci_parse says to create it in advance.
https://www.php.net/manual/en/function.oci-parse.php#refsect1-function.oci-parse-examples
In the documentation of oci_bind_array_by_name, there is a sample to create a stored procedure, but this sample fails.
The error in case of failure is ORA-24344, which is the same error I saw this time.
https://www.php.net/manual/en/function.oci-bind-array-by-name.php#refsect1-function.oci-bind-array-by-name-examples
Current commit, the stored procedure is created in the workflow of github actions.
However, it is not a very satisfactory fix.
Do you know how to create a stored procedure using oci8?

Did you see https://www.oracle.com/technetwork/database/database-technologies/php/201212-ug-php-oracle-1884760.pdf ?
PL/SQL Success With Information Warnings (P.210 in the PDF) shows code to check for informational errors and warning.

@kenjis
Thank you.
I hadn't seen that.
When I checked it, there was a bug in the Connection class that removed the semicolon.
Fixed it.
https://github.com/codeigniter4/CodeIgniter4/pull/2487/commits/c3d82cb59234f07445c7671a07742d33740743cd#diff-dcb48cf393b982829be79ab49001306c5f06420ded11fe7c462462922ec92191L192-L195
This fix requires the removal of the semicolon for code outside of the OCI8 directory.
This is a fix only for OCI8.
Do you think this fix should be put out as a separate PR?
https://github.com/codeigniter4/CodeIgniter4/pull/2487/commits/c3d82cb59234f07445c7671a07742d33740743cd#diff-a07677ecb7c1a5d29e0d0a8e72f00b5b77b577508602ada4fb8c5c1e0c7c5916L1045-L1052

Do you think this fix should be put out as a separate PR?

Yes.
I don't get what the problem is at a sight.
Send another PR and explain it, please.

@kenjis
Thanks, response.
I made PR.
Please review.
https://github.com/codeigniter4/CodeIgniter4/pull/5513

It seems all the problems except the bug on storedProcedure() are solved.

Fixed it.
Please review.
I think this solves the problem of storedProcedure.
I couldn't confirm the problem 1 he was talking about, but I could confirm the problem 2, so I fixed it.
I also added a test to show that problem 1 could not be confirmed.

@kenjis @paulbalandan  I think we've all reviewed this in the past. Does anyone see anything we need to do in order to get this merged?

@lonnieezell I think this is completed. This feature will be included in v4.2.0.
I'm not sure Ci4 branching, so I hold off on merging.
At least I'm going to merge when develop will become a branch for 4.2.0.

@lonnieezell I think this is completed. This feature will be included in v4.2.0. I'm not sure Ci4 branching, so I hold off on merging. At least I'm going to merge when develop will become a branch for 4.2.0.

waiting for the new features

@ytetsuro CI 4.2 requires PHP 7.4 or later, and coding style has been changed for 7.4.
Can you rebase and run rector to fix the GitHub Action errors?

@kenjis
Very thanks long time review.
Of cource, i can!

@ytetsuro thanks for sticking with us on this one! Once you get those changes taken care of we'll be able to finally merge!

Thank you so much. Hopefully it is going to be release soon.

@ytetsuro This is one of the new big features in v4.2.0.
Can you add a short description to the changelog?
https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/changelogs/v4.2.0.rst#enhancements

@kenjis
Thanks for, feedback!

Can you rebase and run rector to fix the GitHub Action errors?

Fixed it!💪

Can you add a short description to the changelog?

Added it!
In addition, Added a document to the query method about the presence of semicolons for OCI8.
Please review.
https://github.com/codeigniter4/CodeIgniter4/pull/2487/commits/4698fc6b1b2a4ab36e2dff3910d060407d51f663

@kenjis
Thanks for, review!
I Fixed it!!💪
I think should add storedProcedure method in the document.
But where to write it I do not know.😭
https://forum.codeigniter.com/thread-76381-post-391902.html#pid391902
Another question is that the storedProcedure method seems to have been removed in CI3.🤔
If the reason is reasonable, I would like to remove the storedProcedure method in this PR as well.
https://github.com/bcit-ci/CodeIgniter/issues/3981#issuecomment-1006056197
What do you think?

@ytetsuro Please fix coding style.

I don't know why stored_procedure() was removed in v3.
Since v3 and v4 are developed separately, there is no need to make them the same.
I think deleting it will cause problems for users who are already using it.

Please fix coding style.

Fixed following!💪
https://github.com/codeigniter4/CodeIgniter4/pull/5581

I think deleting it will cause problems for users who are already using it.

Thanks for, feedback!!
I sure.

Random ordering is not currently supported in Oracle and will default to ASC instead.
https://codeigniter4.github.io/CodeIgniter4/database/query_builder.html?highlight=oracle

It this correct?

@kenjis

I don't know why stored_procedure() was removed in v3.
Since v3 and v4 are developed separately, there is no need to make them the same.
I think deleting it will cause problems for users who are already using it.

I am tempted to delete storedProcedure and getCursor after seeing this reply and narfbg's reply.
https://github.com/bcit-ci/CodeIgniter/issues/3981#issuecomment-1013785678
I understand that CodeIgniter3 and CodeIgniter4 are different, but as narfbg said, Database Driver abstracts Database operations, and this is the same for CodeIgniter4.
The return value of db_connect is also BaseConnection, and the user's IDE cannot determine that those methods exist.
I also agree that it would be annoying to users who are already using it.
To that end, here are the solutions I'm currently considering.
Which do you think is better?

create a file like Helpers/oci8_helper to realize storedProcedure in a different module from Database abstraction.
stop using original prepared statements when using OCI, and use a class that uses oci_bind_by_name to create queries.
Or if you have a better solution, please let me know.

It this correct?

Thanks for feedback.
Removed it.

Database Driver abstracts Database operations, and this is the same for CodeIgniter4.

I'm not sure CI4 aims to Database Driver abstraction.
If we aim to it, we cannot use any Database specific functionality,
and cannot add any Database Driver specific functionality to a specific driver.
We should remove callFunction(), because it does not work if a user changes the database.
Personally I think abstraction is Query Builder (and CodeIgniter\Model) and Forge.
And Stored Procedure is not so rare functionality, but not all databases have it.
It might be possible that BaseConnection has storedProcedure().

stop using original prepared statements when using OCI, and use a class that uses oci_bind_by_name to create queries.

I don't get what you mean. What is original prepared statements ?

@kenjis
Thanks for feedback.
I'm learning a lot. Thank you.

I'm not sure CI4 aims to Database Driver abstraction.
If we aim to it, we cannot use any Database specific functionality,
and cannot add any Database Driver specific functionality to a specific driver.

Indeed, I don't think we should add it!
I thought that inheriting from BaseConnection meant that I was abstracting the Database connection.
I don't think we should do that even as a Liskov substitution principle.
If it is to be a subclass of BaseConnection.
However, the idea that you should use PDO if you want abstraction may also exist...

We should remove callFunction(), because it does not work if a user changes the database.
Personally I think abstraction is Query Builder (and CodeIgniter\Model) and Forge.

I don't know why there is a callFunction that can only return boolean.
However, as you said, abstraction may not be the goal when there are callFunction and query methods.
Thank you. I learned a lot and understand.

And Stored Procedure is not so rare functionality, but not all databases have it.
It might be possible that BaseConnection has storedProcedure().

It's true that storedProcedure is not an ORACLE-specific feature.
MySQL can call storedProcedure in a CALL statement via the query method.
In OCI, I think we need to prepare a separate storedProcedure method because we need to allocate variables of reference and resource types.
I think because the binding process for prepared statements is a proprietary implementation.
This is because references and resource types can only be bound using functions such as oci_bind_by_name.
From the above, I feel that it would be better to implement it in 2.
What do you think?

I don't get what you mean. What are original prepared statements?

I'm sorry.
My explanation was not good.
I meant to stop the original binding implementation for prepared statement.
Specifically, we are considering whether it would be possible to design the binding process in the Query class so that the PreparedQuery class is used for binding.
By doing so, we believe that users will be able to execute storedProcedure in the query method, just like in MySQL.

$ composer cs-fix
$ vendor/bin/rector process file1 file2 ...

I would like to release Oracle driver with functionality that can upgrade CI 3.1 code to 4.x as soon as possible.
If we can execute stored procedures by the query() method, Does it provide value to the Oracle users?

If we can execute stored procedures by the query() method, Does it provide value to the Oracle users?

No.
I can't offer much value in being able to run storedProcedure in the query method.
However, I think I can provide value in stopping proprietary bindings.
For example, it will be able to store binary data.
Being able to execute storedProcedure from the query method is one such example.
https://www.php.net/manual/en/function.oci-bind-by-name.php#example-1789

@ytetsuro I don't fully understand your 2. plan, but it seems a good way to go.
But this PR is too long living and I really want to finish it.
Refactoring or improvements can be added later.
Can you fix the coding style error?

@kenjis
Thank you very much for supporting this PR for a very long time.

I don't fully understand your 2. plan, but it seems a good way to go.

I understood.
I would like to issue an issue with more details on this content when this PR is merged.
Thank you very much!!

The one of the oldest, and most commented PR has been merged!


Handle kernels which lack CONFIG_USER_NS

In GitLab by @jonathanmaw on Sep 21, 2017, 14:23
The error raised is "Creating new namespace failed, likely because the kernel does not support user namespaces.  bwrap must be installed setuid on such systems." Ensuring that the bwrap binary is setuid does not solve this problem.
Since the sandbox implementation won't work without being able to do user namespaces, the most appropriate course of action seems to be to raise that error a lot sooner, and in a less confusing way.

In GitLab by @tristanvb on Oct 15, 2017, 14:18
changed title from {-buildstream fails and prints an error message from bwrap when run on a system running a kernel lacking-} CONFIG_USER_NS to {+Need early exit and comprehensive error when host kernel lacks+} CONFIG_USER_NS

In GitLab by @tristanvb on Oct 15, 2017, 14:20
Note: even better than an early exit from the python code at startup, is probably to just handle this at install time and treat the user namespace requirement as any other dependency.

In GitLab by @jjardon on Oct 27, 2017, 09:19
This is a bit weird because I can run flatpaks in my system without any problem; but I can not use builstream; maybe the user namespace can be optional depending on the command line options? From bwrap code: https://github.com/projectatomic/bubblewrap/blob/master/bubblewrap.c#L1989

In GitLab by @jjardon on Oct 27, 2017, 11:38
flatpak used to use "--unshare-user", then switch to "--unshare-user-try":
https://github.com/flatpak/flatpak/commit/578d2cc9cfd9f86e60acb700760eed817d5afc44
but then it got completely removed:
https://github.com/flatpak/flatpak/commit/521e7e6a37d719002240426ca28aba43234a68df

In GitLab by @jjardon on Oct 27, 2017, 11:48
So seems flatpak in Arch is compiled with --with-priv-mode=setuid, wich will (if I understand this correctly) make flatpak run as root: From https://github.com/flatpak/flatpak/blob/daf65526e75a5733d54c479e4e5cfad4dd656ecc/configure.ac#L241:
AC_ARG_WITH(priv-mode,
            AS_HELP_STRING([--with-priv-mode=setuid/none],
                           [How to set privilege-raising during install (only needed if userns not working)]),
            [],
            [with_priv_mode="none"])

https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/flatpak#n56

In GitLab by @juergbi on Oct 27, 2017, 13:16
Flatpak applications still run as regular user even when bubblewrap is installed as setuid-root binary. bwrap switches back to the regular user id and drops most/all privileges (configurable) before executing the application. It would likely be possible to support this approach in BuildStream as well.

In GitLab by @jjardon on Oct 30, 2017, 12:29
FYI, @tristanvb told me to try --unshare-user-try instead --unshare-user but now bwrap complains with this error:
bwrap: Specifying --uid requires --unshare-user

In GitLab by @jjardon on Oct 30, 2017, 15:21
Removing the --uid and --gid use seems to work but not sure of the security implications of not using those

In GitLab by @tristanvb on Oct 31, 2017, 07:56
changed title from {-Need early exit and comprehensive error when host kernel lacks-} CONFIG_USER_NS to {+Handle kernels which lack+} CONFIG_USER_NS

In GitLab by @tristanvb on Oct 31, 2017, 08:10
So in light of recent discovery and research done by @jjardon, I've updated the title of this.
What I intend to do here is the following:

At startup time, detect if we can use user namespaces, by invoking bubblewrap and inspecting the results
Have the bubblewrap sandbox omit --ushare-user --uid 0 --gid 0 in the case they cannot be used
Issue a startup warning, included in any build logs, indicating that user namespaces are not available
Explicitly disable pushing of artifacts originating from builds which lack user namespaces

As far as I can see, there are possibly two issues with not having user namespaces:

Some builds might fail if and when they attempt to assign file ownership to uid 0 / gid 0

This part might be solved anyway by fixing issue #38

We dont want to trust artifacts built on machines which lack the user namespace feature

This is because the build environment is less locked down and deterministic. If a build script ever considers the active user uid/gid, then build output will not be reproducible from one build machine to another.

In GitLab by @tristanvb on Oct 31, 2017, 09:58
mentioned in commit fa53e974d61477707281179c6599e59c00d31678

In GitLab by @tristanvb on Oct 31, 2017, 09:58
mentioned in commit ce302c16bfd45adf17ce1ce2156b576de8e9b450

In GitLab by @tristanvb on Oct 31, 2017, 09:59
mentioned in merge request !132

In GitLab by @tristanvb on Oct 31, 2017, 10:07
mentioned in commit 2b6aa446e12ec0061df16b4e16539f6a1b32e346

In GitLab by @tristanvb on Oct 31, 2017, 10:07
mentioned in commit 2fe175ba60337feb45498284bedf0f19782d2059

In GitLab by @tristanvb on Oct 31, 2017, 11:16
mentioned in commit a9a2bcece3b90092d9260f5c46675a0e17df381d

In GitLab by @tristanvb on Oct 31, 2017, 11:16
mentioned in commit b539ef4664179ae26f4f9b9931b7b428560937ad

In GitLab by @tristanvb on Oct 31, 2017, 13:40
closed via merge request !132


Convert instruction is misleading

The header of convert page is misleading
https://github.com/UCLA-IRL/ndn-workspace-solid/blob/1070b50389ab86129c524886974e3cc72850811e/src/components/workspace/convert-testbed.tsx#L88-L92

Convert is designed for specific workspace deployments, not generic instructions
https://github.com/UCLA-IRL/ndn-workspace-solid/blob/1070b50389ab86129c524886974e3cc72850811e/src/App.tsx#L175

Suggest removing the convert page subheader, and move the convert instruction to the end (after how to create), and pointing out the scope.

PR merged


Add example to readme regarding UI projects

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.918%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1167

Relevant Lines:
1194

💛  - Coveralls


firewall is too permissive

it seems we are just blocking certain ports and leaving others open by default. let's think about doing it the other way round.
This is a good candidate: https://github.com/arno-iptables-firewall/aif

looks like port 8009 the tomcat proxy is open which is not a great idea :-P

we should also improve the ssl security with the use of ciphers on apache.

                  ssl_cipher => 'EECDH+ECDSA+AESGCM:EECDH+aRSA+AESGCM:EECDH+ECDSA+SHA384:EECDH+ECDSA+SHA256:EECDH+aRSA+SHA384:EECDH+aRS

                  ssl_protocol => 'all -SSLv2 -SSLv3',

                  ssl_honorcipherorder    => 'On',


Add support for EC2

The library currently does not support the EC2 API.
Related: https://github.com/aws-beam/aws-codegen/issues/24

In the meanwhile I am using this to get my required API call.
defmodule AWS.EC2 do
  def describe_network_interfaces(client, input, options \\ []) do
    request(client, "DescribeNetworkInterfaces", input, options)
  end

  @spec request(AWS.Client.t(), binary(), map(), list()) ::
          {:ok, Poison.Parser.t() | nil, Poison.Response.t()}
          | {:error, Poison.Parser.t()}
          | {:error, HTTPoison.Error.t()}
  defp request(client, action, input, options) do
    client = %{client | service: "ec2"}
    host = build_host("ec2", client)
    url = build_url(host, client)

    headers = [
      {"Host", host},
      {"Content-Type", "application/x-www-form-urlencoded"}
    ]

    input = Map.merge(input, %{"Action" => action, "Version" => "2016-11-15"})
    payload = AWS.Util.encode_query(input)
    headers = AWS.Request.sign_v4(client, "POST", url, headers, payload)

    case HTTPoison.post(url, payload, headers, options) do
      {:ok, %HTTPoison.Response{status_code: 200, body: ""} = response} ->
        {:ok, nil, response}

      {:ok, %HTTPoison.Response{status_code: 200, body: body} = response} ->
        {:ok, AWS.Util.decode_xml(body), response}

      {:ok, %HTTPoison.Response{body: body}} ->
        error = AWS.Util.decode_xml(body)
        {:error, error}

      {:error, %HTTPoison.Error{reason: reason}} ->
        {:error, %HTTPoison.Error{reason: reason}}
    end
  end

  defp build_host(_endpoint_prefix, %{region: "local"}) do
    "localhost"
  end

  defp build_host(endpoint_prefix, %{region: region, endpoint: endpoint}) do
    "#{endpoint_prefix}.#{region}.#{endpoint}"
  end

  defp build_url(host, %{:proto => proto, :port => port}) do
    "#{proto}://#{host}:#{port}/"
  end
end

Just curious (and I know it's more layers) but did you try https://hexdocs.pm/aws/AWS.AutoScaling.html
I also wish the ec2 api would be support tho

iex(1)> Mix.install [:aws, :jason, :hackney]

iex(2)> defmodule AWS.EC2 do
...(2)>   alias AWS.Request
...(2)>
...(2)>   def metadata do
...(2)>     %AWS.ServiceMetadata{
...(2)>       abbreviation: nil,
...(2)>       api_version: "2016-11-15",
...(2)>       content_type: "text/xml",
...(2)>       credential_scope: nil,
...(2)>       endpoint_prefix: "ec2",
...(2)>       global?: false,
...(2)>       protocol: "query",
...(2)>       service_id: "EC2",
...(2)>       signature_version: "v4",
...(2)>       signing_name: "ec2",
...(2)>       target_prefix: nil
...(2)>     }
...(2)>   end
...(2)>
...(2)>   def describe_instances(client, input, options \\ []) do
...(2)>     Request.request_post(client, metadata(), "DescribeInstances", input, options)
...(2)>   end
...(2)> end

iex(3)> client = AWS.Client.create("eu-north-1")

iex(4)> AWS.EC2.describe_instances(client, _input = %{})
{:ok,
 %{
   "DescribeInstancesResponse" => %{
     "requestId" => "57587f0e-31f9-4d70-8f27-87b738f39f2b",
     "reservationSet" => %{
       "item" => [
         %{
           "groupSet" => :none,
           "instancesSet" => %{
             "item" => %{
               "tagSet" => %{
               # ...

seems to work for me.

I've created two pull requests that would add support for ec2.
https://github.com/aws-beam/aws-codegen/pull/100
https://github.com/aws-beam/aws-elixir/pull/170


what's the mean of 61 in pyvesc/examples/get_values.py??????

My MayTech motor is Successfully working now, but I can't get rpm and position of motor...
and I can't understand the mean of 61 in ser.read(61)

61 is the framesize. It didnt work for me on firmware version 5 on VESC 6. I changed it to 78 and it works.
(To come up with 78 I hade a look here and printed len(buffer) framesize. https://github.com/LiamBindle/PyVESC/blob/45f372d3075a344c0d6d797565809140cab7cebe/pyvesc/protocol/packet/codec.py#L92-L93)

@psomers3 Any chance you would have time to implement this?

@LiamBindle I can try and remember to include this when I get around to messing with the project I used this on, but that will likely be a little while (~month).

That would be terrific. Thanks!


reduce the flexibility of Trane to produce useful problems.

Only filter and aggregation operation. A new evaluation module.

Hey @leix28  - I like where you're taking the work with PredictionProblemEvaluator. I don't think it's necessary to add a new class, FixWindowCutoffStrategy though. The existing cutoff strategy is more flexible, and can be used to do the same thing any of the code changes in CutoffStrategy or in related test_ files. I did quite a bit of work to make that possible.
To set up a constant cutoff, it requires you to create a function and pass it to CutoffStrategy
generate_fn = lambda x : np.datetime64(x['COL_NAME']) -  np.timedelta64(5 ,'D')
cutoff_strategy = CutoffStrategy(generate_fn, "Five days before COL_NAME")

It can also handle constant cutoffs. If you'd like, I can show you how to do that.
I haven't had time to look at the rest yet, but can do that on Thursday

Hi @RogerTangos, thank you very much for your comment. I don't expect you to review the code, and apparently, the code is not product-ready. But I'm very happy to take any advice.
I changed the cutoff strategy a little bit to try to generate multiple cutoff times for each entity.
For example, an entity can get 5 cutoff times, say Feb. 1, Mar. 1, ..., Jun. 1, then we can get 5 (feature, label) pairs. Use Jan. data to generate features and use Feb. data to generate labels; Use Feb. data to generate features and use Mar. data to generate labels; etc. In this setting, we can use the first 3 pairs as training data and the last 2 pairs as test data. It makes more sense to me. I'm not sure if we can do this in previous version.
I'm trying to catch a deadline, so I'll make changes to APIs frequently and the unit test may be out of date, but I'll fix them and make a PR to dev branch eventually.

Okie. I understand. Sorry - I didn't want to impose. This just showed up in my notifications and I thought I'd give it a look. Funny you should mention multiple cutoff strategies. I actually implemented it that way originally, but then backtracked after talking with Kalyan about it. Maybe once the deadline's over and if you haven't done it already, I can help work out a decent data structure for CutoffStrategy to return.
BTW, to run the tests locally, try $ tox. It's a lot faster than having travis rebuild everything, though TBH, that's what I did for my first few commits too.

Good luck with the deadline!

Okie. I understand. Sorry - I didn't want to impose. This just showed up in my notifications and I thought I'd give it a look. Funny you should mention multiple cutoff strategies. I actually implemented it that way originally, but then backtracked after talking with Kalyan about it. Maybe once the deadline's over and if you haven't done it already, I can help work out a decent data structure for CutoffStrategy to return multiple values. It's very capable of that with only minor code edits.
BTW, to run the tests locally, try $ tox. It's a lot faster than having travis rebuild everything, though TBH, that's what I did for my first few commits too.

I Tried. But lint passes on my local environment. I spent some time to figure that out. The problem is that trane is not a known_first_party. After adding that in setup.cfg, I got the same error on my local environment and I can fix the problem.


Add git tags for protocol versions

New versions should be tagged in git for easy checkout of old versions. Updates to old versions (like fixing spelling mistakes) should be done in a branch (instead of maintaining one file for each version). This allows easy cherry-picking of commits to multiple versions if needed.

Fully agree. Done.


Move command switch to command.js

This is a simple dropin patch that moves the command switch to its own file.  We can make it more OO if we want, but for now lets just get all of this out of app.js

This should also get the ball rolling on https://github.com/moose-team/friends/issues/117

:+1:

One question I have:  This is just a simple closure.... looks like there are some fancier prototype chain stuff going on in app.js.   Should I be passing self around differently?

@bcomnes I think it's sufficient for now, can be refactored as necessary :+1:

@bcomnes Adding you to moose-team!


Bregma values as listed in quicknii inaccurate

Hello,
I wanted to extract the bregma value for the WHS position of my registration and noticed it did not match well. Checking further, I believe the following registration of the Paxinos atlas (2007) to the WHS template should make a fairly good match between the bregma listed on each section plate and the reported value in QuickNII. It does not (of course relative depending on the level of accuracy desired). Get xml file here: Z:\ReferenceAtlas_Anchoring\Rat\RBSC_Paxinos-Watson\Edition6_2007\coronal\diagrams (Z is lagringshotell.uio.no)
I would be interested to hear if this is supposed to be only an approximate value or if it would be possible to improve this.

Todo list for new WHS release in 2024:

Transformation
Right/left hemisphere
Filebuilder fix


[Bug] When a bar type series, xAxis of type time display wrong dates

Version
4.9.0
Link to Minimal Reproduction
https://tinyurl.com/yeyphcu2
Steps to Reproduce

Create a chart with 2 series and an xAxis of type time
The first series has data from time to time. From date range 15th of March to 20th of March. This series is a line type
The second one has an empty array and is a bar type series

Current Behavior
The xAxis display wrong date range. In linked example, you can see label from 11/03 to 25/03 and it is not the valid dates.
Fun fact: if you switch the second series to a line type, the bug disappear and xAxis display valid label from dates with data.
Expected Behavior
I expect that xAxis display dates label that match the data of all series, even if the series is a bar type.
Environment
- OS: Windows 11
- Browser: Chrome 122.0.6261.129
- Framework<EMAIL_ADDRESS>
Any additional comments?
We have spot the bug on version 4.9.0 but I linked a sandbox which use<EMAIL_ADDRESS>Did I miss something in Documentation ?

Hello,
Any updates on this bug ?


test: add tests for transferOwnership on LSP7

What does this PR introduce?
Testing of the transferOwnership feature for LSP7.

@b00ste yes why not.

@skimaharvey @b00ste I will merge this PR. We can do the same tests for LSP8 in a different PR 🙂


/tps does not work on a server

I did /tps and on the server it gives me placeholder names.
Specifically
tps.uptime
tps.tps
tps.maxmem
tps.freemem

Oh whoops, looks like the names are not being translated, ill fix that in a little

Not just /tps but none of the names is translated.


fix: compile errors related to typings

install all the necessary typings from tsd so as internal typing references work.
hardcode immutable in tsd.d.ts (no available via tsd)
add angular2 as dependency in package.json (was ommited on last commit)
modify .gitigore to exclude tsd.d.ts

This PR will resolve #23

Looks good! :shipit:


Add products by machine number

Suggestion
So I was using this mod from the start of my new world. I am starting to make a basic mall and at this moment I am counting in machine number rather than items per second, items per belt, etc. It would be nice if we could add products by machine number. Had the same problem when adding my smelting columns to my factory in factory planner. Note: this is not the same as items per second per machine.

Hello, this is an old suggestion that isn't as easy to implement as you'd think. To determine an item amount from a machine amount, you'd need to know which machine. And to know that, you'd need to know which recipe to even use. And so you'd end up just specifying a whole recipe line in the item picker, which doesn't make sense. You're better off using the machine limit feature, which was added for this purpose. I know that it's not very intuitive.
All that said, I have some ideas for how to address this differently: #93
Closing this one as dupe


Distance AP

Hi I have a question about distance-wise ap.

Does the hoi instance, which participated in calculating ap, correspond to distance=0.1 when the distance between human & center box is between 0.1 and 0.2?
Or I would fully appreciate it if  you could provide code for calculate distance wise ap.
Thanks

It's a good idea to illustrate the performance by spatial.
I write the code to calculate these two APs based on GGNet's code. The distance-wise ap looks similar to this graph. However, the area-wise ap is different from yours.
If you could provide the evaluation code, I would appreciate it a lot.

It's a good idea to illustrate the performance by spatial. I write the code to calculate these two APs based on GGNet's code. The distance-wise ap looks similar to this graph. However, the area-wise ap is different from yours. If you could provide the evaluation code, I would appreciate it a lot.

hellow , do you deal with this problem? Could you provide the code?


WIP: Refactor Galley runtime in preparation for endpoints.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ozevren
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ayj
If they are not already assigned, you can assign the PR to them by writing /assign @ayj in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ozevren]
pilot/OWNERS
pkg/mcp/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-simpleTests

prow/istio-integ-local-tests.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-integ-local-tests.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-integ-local-tests.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
532167abaf792229b89128c0f57e5cf7b2d6ebdb
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
dae834a15616d89eb7e87099fc32f5ce0b683b60
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test istio-integ-local-tests

prow/e2e-simpleTests.sh
8fc324ac76e6a6a4cb719ab6833cb8637463dfc3
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test e2e-simpleTests

prow/istio-integ-k8s-tests.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test e2e-simpleTests

prow/istio-integ-k8s-tests.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test istio-integ-local-tests

prow/istio-pilot-multicluster-e2e.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test e2e-simpleTests

prow/istio-integ-k8s-tests.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
f40a87e9ca1151a518767d5e5420dca13fa7c3bc
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add workflow to sync templated repo from upstream on a schedule

https://github.com/narrowspark/template-sync-action

Suggestion for each module that is created with the template:

rename branch master to upstream and leave it untouchable, only for sync with vagrant-hashistack-template
make new branch which is going to be the default branch

Once the original template is updated, the developer of the module decides the necessity of rebase
upstream -> default

@fredrikhgrelland can you elaborate more why it should be done on schedule?

I would go with Option 1:
Use concrete linter version in original template instead of latest (bump periodically)
https://github.com/fredrikhgrelland/vagrant-hashistack/blob/master/.github/workflows/on_pr_master.yml#L37

Option 1 is always be the right one.

This is irrelevant becuase of #331 closing


IGNITE-17014 [Native Persistence 3.0] Porting FilePageStoreFactory and FilePageStore from 2.0

https://issues.apache.org/jira/browse/IGNITE-17014

Please make code review.

@ibessonov Please make code review.


Contributing Guidelines PR and branding process

Issue
The contributing guidelines is missing the PR and branching process.
Resolution
The guidelines should contain what branch to create PR's against.
Example: your branch -> master
It can also be extended to have different PR processes for different development in parallel. Example:
All swift 3 contributions
branch from swift3 -> fixes -> merge back to master
This is just an example and doesn't reflect the current branches, but this way there could be separate work going if needed such as when Swift 4 is released or minor 3.x swift versions.
Also a branching process would be helpful if there is a flow to follow such as:
branch from master -> create branch with a specific naming convention -> commit work -> PR back to master
Let me know what everyone's thoughts are on this. I can own completing the task if needed.

// cc @chris-pilcher @vincentngo

I actually just ran into an issue with this when opening a PR. I had to fork the repo first the make my changes there and make the PR against with that fork. It would be convenient to have that process for others to know that are starting to contribute to the project.

Archiving to #317


Merge pull request #100 from mono/fix-gh-14957

Fix https://github.com/mono/mono/issues/14957

Merged #104 instead.


Mark size consts as public

It would be nice to use these SIZE consts outside of rust-bitcoin.  Marking them as public in this MR.

Do you have some specific use case in mind? I suspect most uses of this are covered by consensus encoding/decoding APIs, weight prediction and so on. What is missing?

I have an external crate that is doing this computation:
/// The weight of a `TxIn` excluding the `script_sig` and `witness`.
pub const BASE_WEIGHT: Weight =
    Weight::from_vb_const(bitcoin::OutPoint::SIZE as u64 + bitcoin::Sequence::SIZE as u64);

previously I had added this to rust-bitcoin in case other libs need it, but it was ripped out, so I'm re-implementing it externally.

And what is BASE_WEIGHT used for? Is it possible that you're reimplementing transaction::predict_weight or something similar? Weight computation is generally tricky so I'd like to help with it much more than just publishing trivial constants. Ideally, people shouldn't need to write any such computation at all.

And what is BASE_WEIGHT used for?

Good question.  Base weight is used in coin-selection to compute the effective_value of each UTXO, for example here.

Great, that's something I'd love to see included as whole in the library, not just exposing some constants. Probably as a method on TxOut which could also identify P2PKH/ P2WPKH/... But also one that takes satisfaction_weight as a separate parameter.
However, regarding these selection algos, I wonder how they take into account that having more than 252 inputs changes the fee rate and if we should do anything about it.

Great, that's something I'd love to see included as whole in the library, not just exposing some constants. Probably as a method on TxOut which could also identify P2PKH/ P2WPKH/... But also one that takes satisfaction_weight as a separate parameter.

Yeah it would probably be better to just expose effective_value() on TxOut.  Even when effective_value() is available, is there a reason to keep these SIZE consts as private?

However, regarding these selection algos, I wonder how they take into account that having more than 252 inputs changes the fee rate and if we should do anything about it.

Hmm good point.  Yes, I absolutely think the selection algos should take into account when more than 252 inputs are selected and how that changes the fee_rate, thanks for mentioning that.  However, for the purpose of adding effective_value to rust-bitcoin, that doesn't matter.

is there a reason to keep these SIZE consts as private?

Yes, the name is horrible and it being present may lead people into dealing with it incorrectly. We should make the API easy to use correctly and hard to use incorrectly. That was our focus over past many months and it already uncovered bugs and prevented problems in downstream software.

However, for the purpose of adding effective_value to rust-bitcoin, that doesn't matter.

It may actually. If we expose a full blown selection algo then we don't need this method. Though I suspect there isn't "one right algo" and most of them will need to compute that as a basic primitive, so I'd still add it with documentation mentioning it's tricky to use correctly and that people should probably pick one of the existing algos.

Yes, the name is horrible and it being present may lead people into dealing with it incorrectly. We should make the API easy to use correctly and hard to use incorrectly. That was our focus over past many months and it already uncovered bugs and prevented problems in downstream software.

Ok, I can get behind just using the API and not exposing these conts.  We can close this in favor of adding effective_value to the api then.

It may actually. If we expose a full blown selection algo then we don't need this method. Though I suspect there isn't "one right algo" and most of them will need to compute that as a basic primitive, so I'd still add it with documentation mentioning it's tricky to use correctly and that people should probably pick one of the existing algos.

I think a full blown set of selection algo is a bit high-level for this crate and should just be added as a separate crate to rust-bitcoin instead which is my intent.

as a separate crate to rust-bitcoin instead which is my intent.

Definitely. It can be in the org though.


Mixing of dask.array and numpy.ndarray in Numba @guvectorize

It appears that dask.array and numpy.ndarray cannot be mixed when using Numba's @guvectorize decorator - see the minimal example below. It would be a nice feature if dask could resolve this (or at least raise a more helpful exception!). Regardless, this is a truly helpful package!
Minimal Example
import dask.array as da
import numpy as np
import numba as nb

# large array
x = np.random.random((300000, 100, 10))
y = da.from_array(x) # for the sake of the example

# small vector
v = np.ones(10)
w = da.from_array(v)

@nb.guvectorize([nb.void(nb.f8[:, :], nb.f8[:], nb.f8[:])],
                '(m, n), (n) -> (m)', target='parallel')
def test(arr, vec, out):
    # really just a test function
    out[:] = (arr + vec).sum(axis=1)

out1 = test(x, v) # works
out2 = test(y, w).compute() # works

out3 = test(y, v) # fails with ValueError

The following ValueError is raised ... (on dask version 2.30.0)
[...]
ValueError: `dtype` inference failed in `apply_gufunc`.

Please specify the dtype explicitly using the `output_dtypes` kwarg.

Original error is below:
------------------------
ValueError('test: Input operand 1 has a mismatch in its core dimension 0, with gufunc signature (m, n), (n) -> (m) (size 10 is different from 1)',)

Traceback:
---------
  File "<...>/miniconda3-latest/envs/<...>/lib/python3.6/site-packages/dask/array/core.py", line 377, in apply_infer_dtype
    o = func(*args, **kwargs)

Thanks for opening this issue. I can reproduce on lastest master and this feels like something that should be allowed. I am opening a PR now with a proposed fix.

Much appreciated! Agreed that it intuitively feels like this should work ... (the exception left me chasing my tail for a while)


[BUG] external_url

I tried different accounts and connections, but there is no change even though it says external URL has changed. Also, if there is 1 external_url in the profile, when I want to change it, it adds a 2nd external_url, that is, it does not edit or delete the old one.
`
from instagrapi import Client
USERNAME = 'username'
PASSWORD = 'pass'
cl = Client()
cl.login(USERNAME, PASSWORD)
account_info = cl.account_info().dict()
print(account_info)
cl.account_edit(external_url='https://URL')
`

cl.set_external_url(external_url='https://url/'')
This worked and added a link, but now it is necessary to delete the old one if it exists.

I saw a code here in past issues like this and it works.
`
def delete_external_links(api):
result = api.private_request("accounts/current_user/?edit=true")
time.sleep(5)
for link in result.get('user', {}).get('bio_links', []):
    print("DELETING LINK " + str(link))

    signed_body = f"signed_body=SIGNATURE.%7B%22_uid%22%3A%22{api.user_id}%22%2C%22_uuid%22%3A%22{api.uuid}%22%2C%22link_ids%22%3A%22%5B%5C%22{link.get('link_id', '')}%5C%22%5D%22%7D"

    response = api.private_request("accounts/remove_bio_links/", data=signed_body, with_signature=False)
    print(response)

    time.sleep(4) `

    Use;

    delete_external_links(cl)

I tried this and it removes only 1 link not if i have more than one. Do you know what the code would be if i need to remove more?

Solved by just re writing the code 2 times

cl.set_external_url(external_url='https://url/'') This worked and added a link, but now it is necessary to delete the old one if it exists.

su thanks man that worked


continually getting Command Invoke Failed

Hello,
I am trying to run a powershell script that does a lot of collection and currently writes a complex .json file with no problem. however when i invoke this i continually get "Command Invoke Failed". I am sure it comes down to how i am trying to return the object.
writing out our report
$report | add-member -membertype NoteProperty -Name controls -Value $controls
$doc = $report | ConvertTo-Json -Depth 4
$doc | ConvertTo-Json -Compress
$doc = $report | ConvertTo-Json -Depth 4
$obj = [PSCustomObject]@{name="obj"; value=$doc}
$obj | ConvertTo-Json -Compress
write-host $obj
how would i return a complex .json file back to node?
var runPowershell = (vcenter, tenant) => {
return new Promise((resolve, reject) => {
ps.addCommand('./controllers/vircenter.ps1 -vercenter ' + vcenter + ' -tenant ' + tenant);
ps.invoke().then(output => {
console.log(JSON.parse(output));
ps.dispose();
resolve(output);
}).catch(err => {
console.log('there was an error', err)
ps.dispose();
});
});
}
the error i get back looks something like this:
Property "Values" cannot be found.Property "Values" cannot be found.Property "Values" cannot be found.Property "Values" cannot be found.{"name":"obj","value":"{"Attrib1":"value1","Attrib2":\Value2","Attrib3":"Value3"},{"newAttrib1":"Value2",[{"array1":"arrVal1"}]
any help would be greatly appreciated!
Many thanks!

Closed due to lack of response


feat(provider): Alias Scheduler automatically

Coverage remained the same at 60.284% when pulling 1c0cf96979861ccbb7590d5af5ccd9fd1b0ea673 on webdevian:patch-1 into 54ebaaea2b5d241e9e226167c5fc301a6bd96ac4 on nrempel:master.

Hi @webdevian, thanks for the contribution!
The canonical method to create aliases for providers in AdonisJS is to set them in app/start.js http://adonisjs.com/docs/4.0/ioc-container#_aliases
You can accomplish this like this:
const aliases = {
  ...
  Scheduler: 'Adonis/Addons/Scheduler'
}


don't run cron if already running

is there any inbuilt function to only run the next tick if there is no other tick of the cronjob running still? In case i have a cronjob running every few seconds but sometimes it might finish slower then normal.

Hello @pixelpaulaus
I using a setInterval to check periodically whether a task needs to be performed, so when run time of your task is greater than the runtime node-cron will miss executions.


add cv_intersectConvexConvex

add cv_intersectConvexConvex
bool cv_isContourConvex(VecPoint contour);

isnt CvStatus* cv_isContourConvex(VecPoint contour, bool* rval, CvCallback_0 callback);
better to have the async work? or its not needed?

oh, okay then


Review existing data to verify no private sites/info are available

Private/Non-public sites defined as:
Officially Recognized = 'No'
Where Registry type is not 'Registered' or 'Federal'
Where any sites marked as Restricted are not accessible
Specific fields that are not public access:

official recognition details notes
legal address notes
chronology source of dates
remarks
decision history
all documents until reviewed

Data to be reviewed:
image description, document description, location description, images

I think the criteria above is incomplete - it is missing the BCRHP Submission Status = "Approved - Basic Record" and "Approved - Full Record" criteria.

Done in test


PDF file is not updated since v1.25

Description

In online doc, I can search and find info for the new feature signed SAF Identity tokens (IDT), and sample program ZWESECKG, but it cannot be found in PDF format.
The sections in PDF do not reflect the new doc structure and content. For example, the Setup section, Release Notes section.
Expected behavior

Update the PDF to capture the latest content on docs.zowe.org.

Hey @nannanli  Can I try this ?? . Can you please refer as where I can find information for all the sections that need to be added in the PDF report.


Support pydantic v2

Description
This provides soft support for Pydantic v2 by leaning on the compatibility layer for pydantic v1 added in pydantic v2.
The change amounts to trying to import v1 from v2 and in the case that it fails (meaning v2 isn't currently installed), it defaults to the v1 import pattern. The actual functionality of the imported classes / functions remains the same regardless of whether its coming from v1 or v2 so no major refactor or logic changes w/ testing is required.
NOTE: This should be a short term "bandaid" fix and replaced whenever the bandwidth to do so becomes available as its a really bad pattern to have in a code base. Its important to get this in though as major libraries are moving to full v2-only implementations and blocking updating them is worse than the quality of this code :P
Fixes #7393
Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
I ran all tests locally and verified they all passed.
Suggested Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@srhinos Thanks for tackling this!
Hmm, has langchain landed their official pydantic v2 migration yet?
I'd rather do the full migration tbh, as this looks like quite a few changes to revert when we do make the full switch 😅
What's your take on the situation?

@srhinos Thanks for tackling this!
Hmm, has langchain landed their official pydantic v2 migration yet?
I'd rather do the full migration tbh, as this looks like quite a few changes to revert when we do make the full switch 😅
What's your take on the situation?

See this post for the current state of their pydantic upgrade - https://github.com/langchain-ai/langchain/discussions/9337
tl;dr - langchain currently implements this same pattern supporting both v1 and v2 with no planned timetable for moving to v2. I think thats probably the smart move for now so people can continue using the newest versions of things and the tech debt doesn't continuously pile up.
If I was an active maintainer (which I am for my work repo :P), I'd accept this trade off to enable a short term bad pattern for the long term continued repo velocity.

also looks like mypy is blocking due to these lines: https://github.com/jerryjliu/llama_index/blob/main/llama_index/llm_predictor/base.py#L169-L173
Weird to bubble up here I think?

@srhinos hmmm llama index doesn't have a class name called BasePromptTemplate ? How did that pop up? 😅  It should be of type Prompt as the typing in the function specifies 🤔

Did you somehow get this unmerged PR in your code? https://github.com/jerryjliu/llama_index/pull/7319

I am super lost on that mypy error, that class is not even in PR branch either..

thanks for the contribution @srhinos


Implement server calls

Overview
Implement all Server calls in Rust based in the generated gRPC client.


How do I stop a script?

I just started a script in ConfigMgr 1806 and don't know how to stop it. It's running on 6000 machines.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7c7d1db7-6812-ff3c-9aac-0f55800ed665
Version Independent ID: a4499cf7-ed5a-710c-66e0-005563b9c015
Content: Create and run scripts - Configuration Manager
Content Source: sccm/apps/deploy-use/create-deploy-scripts.md
Product: configuration-manager
Technology: configmgr-app
GitHub Login: @mestew
Microsoft Alias: mstewart

Thanks @iamtechy for taking the time to share this with the Configuration Manager documentation team. I’m sorry that you’re having problems, and I want to make sure it gets to the right people that can help. There are a couple of options available to provide the best level of support for this:

Post on Configuration Manager forums. These are moderated by our community MVPs who are very experienced, knowledgeable, and helpful.
Use Microsoft Support to search for the issue, or open a case with professional support.
Contact your Microsoft Premier team, such as a Premier Field Engineer or Technical Account Manager.

I generally close such support requests, but I think in this instance we can check to see if there is a supported method for stopping a script, and include that detail in the documentation. I just can't promise any sort of turnaround on that followup, thus the information about about support options.

Scripts are currently unstoppable. I suggest filing product feedback. We'll look at adding a note for this issue to this article.

You can cancel scripts or at least it looks like it, i have not checked in any logs that its actually cancelled but if you go to Monitoring and then to Client Operations. Here you can right click and select cancel on Run Script actions. You can not see which script it refers to but it shows the time it was initiated.

Thanks again for the feedback. We recently moved this content to a new GitHub repository, so this issue is no longer tracked with the original article. As part of that process, we reviewed our backlog of feedback, and made some tough decisions on items that we don't think we'll realistically ever address. If you're passionate about this specific feedback, please refile it on the current article, now under docs.microsoft.com/mem/configmgr.
Thinking through this some more, the Client Operations node is for all fast channel (BGB) actions. So cancelling an action most likely just stops any client that hasn't already received from starting. In this instance, if the client has already received the instruction and the script is running, there's nothing currently out of the box to stop it.


Added Merge Sort and Bubble sort with Python

Description

Added the algorithm for merge sort and bubble sort.

Related Issue
fixes #204
fixes #201
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[x] New Algorithm (non-breaking change which adds functionality)

Checklist:

[ ] My code follows the code style of this project.

[x] I have read the CONTRIBUTING document.

It is fine since it is your first time. But please comment on the issue before you put up a pull request. Multiple people seemed to be working on this issue.

fixes #204
fixes #201

@GnikDroy Sorry I didn't know. I will Comment before making a PR next time. and I have renamed the variables as you recommended.

@prkhrv No problem. Happens to the best of us. This is your first time contributing anyway.
Could you keep the bubble sort algorithm in a function? Write some code that sorts a test array and prints out to screen. This will help us check your algorithm. Also, could you rename your variables in mergesort as well. Also, take @punkyoon advice and read the PEP8. It will help you.

@prkhrv Can you remove heap sort and implement a heap instead? You said in #206 you would contribute in heap. Heap Sort is #202 which was assigned to @punkyoon  and is addressed by pull request #213

Oh! Yeah, Now i saw that , I will sure :)


Update Github Actions

Story

As a developer, I want to have up-to-date CI actions since current ones are depricated. -->
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rationale

Current version of github actions gone depricated, needs to be updated.
Implementation details

Update used action versions
Priority

3
Scope

Ci/CD
Size

1 hour
What does "done" look like?

Updated .github/workflows files
Does this require updaes to documentation or other materials??

no
What testing is required?

manual
Is this a known/expected update?

no

This can be closed @zanete


Bottle Image is stuck on upload

Describe the bug
When creating a new Bottle, I can't save without selecting an image file and when I do and click update, the software is stuck on "Please wait, file upload in progress...."
To Reproduce
Steps to reproduce the behavior:

Go to Inventory > Bottles
Click on Actions > Add new
Fill out the information about the bottle and select an image file of the bottle.
Click on Add
The bottle record will never get saved and the screen is stuck at "Please wait, file upload in progress...."

Expected behavior
To be able to save the bottle record after uploading a bottle image.
Screenshots
Chrome:

Firefox:

Edge:

Please complete the following information:
OS: Windows 11
Browser: Edge, Version: 118.0.2088.76 (Official build) (64-bit)
Other browsers: Chrome, Firefox
Additional context
This issue is related to the closed issue #127. The issue is still exist in PV Version 9.8
This issue doesn't exist when creating a Bottle Lid.

I changed the name to "Dropper Stop 1oz Amber Glass Boston Round Bottles 30mL with Polycone Caps, Pack of 99" but I'm still getting stuck on the upload step.


Performance Issue with FeCAM_cifar100.json in Many-Shot CIL Scenarios

I used FeCAM_cifar100.json for many-shot CIL scenarios with/without pre-trained ResNet18 and achieved 62% average top-1 incremental accuracy. Is this expected, or could it indicate a mistake in my implementation? Thank you for your guidance.

Hi,
Without using pre-trained weights, it is expected to get an accuracy close to 62% after the last task.
If you are using pre-trained weights, the accuracy is expected to be better. To do so, you need to set pretrained option to True
self._network = CosineIncrementalNet(args, True) in models/fecam.py line 26.
The accuracy after the first task should at least be better. Try to change the shrinkage values and see if that makes a difference. If this doesn't work, let me know. I will try it on my end.


pythonPackages.mccabe fixup, hypothesis: 3.1.0 -> 3.5.2, flake8: 2.5.4 -> 2.6.2

Motivation for this change
mccabe was reverted in https://github.com/NixOS/nixpkgs/commit/25dcdc58d05a3e9421116a8bedd3a47815faf1f4 and the old version inited in https://github.com/NixOS/nixpkgs/commit/8eae96d70c18f2a1015796e8aa0ff84463f4711c
so we have the old version twice.
I also updated flake8 2.x to the latest released version to get rid of pep8
And while at it updated hypothesis.
We can split the hypothesis update I you prefer, but I built everything yesteday (3x webkit24x ...)
follow up to #19132
cc @FRidh @7c6f434c
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Oops, reacted to Hydra and missed the commit in-between. Looks reasonable.

It's a shame that the travis failure was ignored, since it pointed out the issue with this merge.

Hm, the status seemed to be «pending»… is there yet another way Travis misinforms?

Maybe Nix hits travis hard enough that stuff doesn't get run immediately? https://travis-ci.org/NixOS/nixpkgs/builds/164410021 suggests that the three actual checks all ran in < 3 minutes, but that the "total time" was 7+---so maybe that 4 minute discrepancy is the "pending" time?

Maybe Nix hits travis hard enough that stuff doesn't get run immediately? https://travis-ci.org/NixOS/nixpkgs/builds/164410021 suggests that the three actual checks all ran in < 3 minutes, but that the "total time" was 7+---so maybe that 4 minute discrepancy is the "pending" time?

That's totally possible and I consider that normal.
I just wonder if  ignored the existing Travis faiure or just didn't wait
for the failure to happen.


SQL Server Books Online reference does not seem to exist

Under "Bytes Per Row" There is a reference to:
"Row-Overflow Data Exceeding 8 KB" topic in SQL Server Books Online.
However, there is no link. Searching for this online in many different ways has not yielded a satisfactory result. Does this topic exist? I see many other people looking for updated documentation regarding this behavior in all versions of SQL Server, but no official documentation to definitively answer these questions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 780e3e16-ac52-1343-fe0a-a706c71ddb92
Version Independent ID: 6f09b278-faa0-6f0d-1013-c1ae62ca006c
Content: Maximum Capacity Specifications for SQL Server - SQL Server
Content Source: docs/sql-server/maximum-capacity-specifications-for-sql-server.md
Product: sql
GitHub Login: @MikeRayMSFT
Microsoft Alias: mikeray

@MikeRayMSFT (and @CamyDee), Mike, I found the old article that the text-only link was referring to. I have pasted in the content of the old article below, FWIWorth.
Caution, The five links to other articles, that are in the pasted article below, are all old MSDN archived links.  I awkwardly put next to each link the MSDN shortId (find these by finding the '[' character).
----  Very SLOW Link, archive:
http://<IP_ADDRESS>/en-us/library/ms186981(SQL.100).aspx
C:\JunkM
Issue-1765.PlainText-ms186981.Row-Overflow_Data_exceeding_8_KB.txt
# Row-Overflow Data Exceeding 8 KB

A table can contain a maximum of 8,060 bytes per row. In SQL Server 2008, this restriction is relaxed for tables that contain varchar, nvarchar, varbinary, sql_variant, or CLR user-defined type columns. The length of each one of these columns must still fall within the limit of 8,000 bytes; however, their combined widths can exceed the 8,060-byte limit. This applies to varchar, nvarchar, varbinary, sql_variant, or CLR user-defined type columns when they are created and modified, and also to when data is updated or inserted.

> [!NOTE]
> This restriction does not apply to varchar(max), nvarchar(max), varbinary(max), ntext, text, image, or xml columns. For more information about the storage of these columns, see [Using Large-Value Data Types](DONOTUSE_<IP_ADDRESS>/library/ms178158%28SQL.100%29), Using text and image Data[[ms189574]], and Using XML Data[[ms178051]].

## Row-Overflow Considerations

When you combine varchar, nvarchar, varbinary, sql_variant, or CLR user-defined type columns that exceed 8,060 bytes per row, consider the following:

- Surpassing the 8,060-byte row-size limit might affect performance because SQL Server still maintains a limit of 8 KB per page. When a combination of varchar, nvarchar, varbinary, sql_variant, or CLR user-defined type columns exceeds this limit, the SQL Server Database Engine moves the record column with the largest width to another page in the ROW_OVERFLOW_DATA allocation unit, while maintaining a 24-byte pointer on the original page. Moving large records to another page occurs dynamically as records are lengthened based on update operations. Update operations that shorten records may cause records to be moved back to the original page in the IN_ROW_DATA allocation unit. Also, querying and performing other select operations, such as sorts or joins on large records that contain row-overflow data slows processing time, because these records are processed synchronously instead of asynchronously.

- Therefore, when you design a table with multiple varchar, nvarchar, varbinary, sql_variant, or CLR user-defined type columns, consider the percentage of rows that are likely to flow over and the frequency with which this overflow data is likely to be queried. If there are likely to be frequent queries on many rows of row-overflow data, consider normalizing the table so that some columns are moved to another table. This can then be queried in an asynchronous JOIN operation.

- The length of individual columns must still fall within the limit of 8,000 bytes for varchar, nvarchar, varbinary, sql_variant, and CLR user-defined type columns. Only their combined lengths can exceed the 8,060-byte row limit of a table.

- The sum of other data type columns, including char and nchar data, must fall within the 8,060-byte row limit. Large object data is also exempt from the 8,060-byte row limit.

- The index key of a clustered index cannot contain varchar columns that have existing data in the ROW_OVERFLOW_DATA allocation unit. If a clustered index is created on a varchar column and the existing data is in the IN_ROW_DATA allocation unit, subsequent insert or update actions on the column that would push the data off-row will fail. For more information about allocation units, see Table and Index Organization[[ms189051]].

- You can include columns that contain row-overflow data as key or nonkey columns of a nonclustered index.

- The record-size limit for tables that use sparse columns is 8,018 bytes. When the converted data plus existing record data exceeds 8,018 bytes, MSSQLSERVER ERROR 576 is returned. When columns are converted between sparse and nonsparse types, Database Engine keeps a copy of the current record data. This temporarily doubles the storage that is required for the record.

- To obtain information about tables or indexes that might contain row-overflow data, use the sys.dm_db_index_physical_stats[[ms188917]] dynamic management function.

## See Also

Concepts
Assigning a Data Type to a Column

Also, a still active/fast link, that will likely be fully retired in 2019 without any forwarding redirector, is the following "social" MSDN, dated January 2014:

"SQL Server 2008 - Row-Overflow Data Exceeding 8 KB"

https://social.msdn.microsoft.com/Forums/sqlserver/en-US/24dbb445-292b-4433-a804-f524d32375e1/sql-server-2008-rowoverflow-data-exceeding-8-kb?forum=transactsql

Working with @pmasl and @bluefooted  on solution.

Fixed and merged changes

The mystery number of the PR is probably 9398.

@MikeRayMSFT Looks like Issue 1765 is Fixed, so I am sending this little @ notification to let you know.
You can probably close and finalize this Issue 1765 now.  Thanks.

Updated by @pmasl -thank you.
Thanks also to @CamyDee for raising this issue.

https://github.com/MicrosoftDocs/sql-docs/commit/b107bcde25df18e5b9c9d7d67d06fc39852d3afd


Server crashes when using item.DisplayName()

My give command shows up the item's display name based on the language the player is using. Right when I output the success of the command, the server crashes.
func (t Give) Run(source cmd.Source, output *cmd.Output) {
	targets := t.Player
	itemName := t.ItemName

	data, dataUsed := t.Data.Load()
	if !dataUsed {
		data = 0
	}

	name := string(itemName)
	if !strings.Contains(name, ":") {
		name = "minecraft:" + name
	}

	itemType, isItem := world.ItemByName(name, data)

	if !isItem || name == "air" {
		output.Errorf("Unknown item identifier provided %s", name)
		return
	}

	amount16, amountUsed := t.Amount.Load()
	amount := 0
	if !amountUsed {
		amount = 1
	} else {
		amount = int(math.Max(1, float64(amount16)))
	}

	langTag := language.English
	if p, ok := source.(*player.Player); ok {
		langTag = p.Locale()
	}

	var players = make([]*player.Player, 0)
	for _, target := range targets {
		plr, ok := target.(*player.Player)
		if !ok || plr == nil {
			continue
		}
		players = append(players, plr)
	}

	for _, p := range players {
		if p == nil {
			continue
		}
		given := giveItem(p, itemType, data, amount)
		output.Printf("Gave %s x%d to %s", item.DisplayName(itemType, langTag), given, p.Name())
	}
}

panic: should never happen [recovered]
        panic: should never happen

goroutine 33 [running]:
github.com/df-mc/dragonfly/server/session.(*Session).handlePackets.func1()
        C:/Users/Anthony/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.9-0.20230930211047-d519f75b5eb0/server/session/session.go:303 +0x69
panic({0x94eb00?, 0xe32860?})
        C:/Program Files/Go/src/runtime/panic.go:914 +0x21f
github.com/df-mc/dragonfly/server/item.DisplayName({0xe36c60, 0xc000d3f8d1}, {0xf8d1?, 0xd3?, {0x0?, 0x0?}})
        C:/Users/Anthony/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.9-0.20230930211047-d519f75b5eb0/server/item/item.go:220 +0xa6
github.com/imlighty/hardcore/server/cmd.Give.Run({{0xc000c1a0c0, 0x1, 0x1}, {0xc00037e7e0, 0xd}, {0x0, 0x0}, {0x0, 0x0}}, {0xe3e450, ...}, ...)
        D:/Projects/Hardcore/server/cmd/give.go:120 +0x5c9
github.com/df-mc/dragonfly/server/cmd.Command.executeRunnable({{0xc0010c85d0, 0x1, 0x1}, {0xa512d5, 0x4}, {0xa624b7, 0x19}, {0xc0017d8140, 0x3d}, {0x1652800, ...}}, ...)
        C:/Users/Anthony/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.9-0.20230930211047-d519f75b5eb0/server/cmd/command.go:269 +0x88d
github.com/df-mc/dragonfly/server/cmd.Command.Execute({{0xc0010c85d0, 0x1, 0x1}, {0xa512d5, 0x4}, {0xa624b7, 0x19}, {0xc0017d8140, 0x3d}, {0x1652800, ...}}, ...)
        C:/Users/Anthony/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.9-0.20230930211047-d519f75b5eb0/server/cmd/command.go:138 +0x298
github.com/df-mc/dragonfly/server/player.(*Player).ExecuteCommand(0xc000ada000, {0xc00020a120, 0x1e})
        C:/Users/Anthony/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.9-0.20230930211047-d519f75b5eb0/server/player/player.go:387 +0x367
github.com/df-mc/dragonfly/server/session.(*CommandRequestHandler).Handle(0x972a80?, {0xe3bab8?, 0xc00394a140?}, 0xc0005fe000?)
        C:/Users/Anthony/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.9-0.20230930211047-d519f75b5eb0/server/session/handler_command_request.go:22 +0xa2
github.com/df-mc/dragonfly/server/session.(*Session).handlePacket(0xc0005fe000, {0xe3bab8, 0xc00394a140})
        C:/Users/Anthony/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.9-0.20230930211047-d519f75b5eb0/server/session/session.go:432 +0x8d
github.com/df-mc/dragonfly/server/session.(*Session).handlePackets(0xc0005fe000)
        C:/Users/Anthony/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.9-0.20230930211047-d519f75b5eb0/server/session/session.go:312 +0xdc
created by github.com/df-mc/dragonfly/server/session.(*Session).Start in goroutine 1
        C:/Users/Anthony/go/pkg/mod/github.com/df-mc/dragonfly@v0.9.9-0.20230930211047-d519f75b5eb0/server/session/session.go:217 +0xa5

Process finished with the exit code 2

It happens specifically when giving myself blue_concrete

this also happens with a block.Log

turns out this only seems to work properly with british english, so use that instead for the time being


DNN-25715: return the interface list to match previous api.

Fix #2374 .

This is not a good fix, we should not be catering for bad code in CKEditor.
The GetFiles method returns IEnumerable<IFileInfo>. The problem is not the use of IFileInfo vs FileInfo. The problem is that CKEditorProvider attempts to cast the collection back to a concrete list
var files = (List<IFileInfo>)FolderManager.Instance.GetFiles(currentFolderInfo);

The path of least resistance is to change the usage of GetFiles in the provider so that it recreates the list there. Otherwise it's assuming the returned object is a List<> which is programming to a concrete type and not to the interface.
var files = FolderManager.Instance.GetFiles(currentFolderInfo).Cast<IFileInfo>().ToList();

I vote to close @dnnsoftware/tag

I agree the fix should be done in the provider as @tpluscode suggests.

I agree as well, closing.

Changes made in CK editor provider side: https://github.com/DNN-Connect/CKEditorProvider/pull/94


org.openrewrite.gradle.Assertions#withToolingModel moved to org.openrewrite.gradle.toolingapi.Assertions

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.ChangeMethodTargetToStatic?organizationId=T3BlblJld3JpdGU%3D

Superseded by #4023


Search should be categorized

Instead of having Entries like:
method: sort
method: substr
There should be a method category that has sort and substr elements.

See aad0a2ff00 for a first pass.


Make a compatibility matrix between kurtosis-go/lib and kurtosis-core

NOTE: This will be unnecessary if we run a Kurtosis Engine that can run different Kurtosis Core versions, which means that these libraries would contain the Kurtosis Core's version

Now that we publish Kurt Core version changes in the Libs changelog, this is less relevant. We still want to make Kurt Core transparent to the users, but until we get Kurtosis Engine we can't


Incorrect text and links - The Microsoft 365 Service Communications API has now been moved to Microsoft  Graph

In the section Track your message center tasks in Planner the text and the link in the following sentence is incorrect because the Microsoft 365 Service Communications API Overview has been replaced by Microsoft Graph
If you'd like to program an alternative way to get real-time service health information and Message Center communications, please reference Microsoft 365 Service Communications API Overview.
The correct text is 'please reference service communications API in Microsoft Graph'
The correct link is https://docs.microsoft.com/en-us/graph/api/resources/service-communications-api-overview?view=graph-rest-beta

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 29f3771a-247c-4f85-992a-e671285c70bd
Version Independent ID: f3c2890a-2470-9349-ff77-924cf8566365
Content: Message center - Microsoft 365 admin
Content Source: microsoft-365/admin/manage/message-center.md
Service: o365-administration
GitHub Login: @KwekuA
Microsoft Alias: kwekua

@nikki-c Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/7290
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @nikki-c Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Load glTF scenes as entity hierarchies

Currently, glTF scenes are loaded as pc.Model objects. A pc.Model has a hierarchy made up of pc.GraphNode objects. A pc.Entity is a sub-class of pc.GraphNode, the main difference being that an entity can have components but a graph node cannot. Until we make this change, we cannot fix issues #2061 and #2062. Note that this issue has significant overlap with #1035.
In the Editor, this would mean importing 3D scenes as template assets rather than model assets.

If it is imported as Template, will it allow modifying its hierarchy and override instances?
That would be very useful feature.

@zachpeterpaul is probably best placed to answer that. 😄

I think our plan is to make such templates very similar or even identical to our regular templates, which allow overrides, including changes to the hierarchy - adding new entities, deleting and reparenting. I think unity allows only adding new entities to an instance as an override, for deletion etc it forces you to edit the template itself

Hi there,
We've also run into this as an issue. We're unable to attach components to gltf children nodes once they've been imported into playcanvas. It would be fantastic to allow this ability!
I see there was a pull request #2345 that is trying to sort this. Is there an ETA on when a solution to this might be included?

Hi @tonetechnician - the mentioned RenderComponent in #2345 is indeed trying to sort this out, and so far handles glb's loaded into playcanvas at runtime. We're extending this to work on fbx and glb files imported into the Editor now, but that's a large project and will likely take few more months to finish. But we're actively working on it.

I see! Thanks @mvaligursky for the update, that's promising work.
I suppose if we wanted this functionality we could build out your branch and use that instead for the meanwhile then? We're not using the Playcanvas Editor at all currently, just the engine for viewing GLBs and applying some logic and handles to these imported. nodes.

You could build a branch with this PR and use it. I'm hoping there won't be many changes to this in the future. Here's an example of how you could load glb and create entity hierarchy using render component:
var url = "../assets/models/playcanvas-cube.glb";
app.assets.loadFromUrl(url, "container", function (err, asset) {
            // create instance using render component
            var entity = asset.resource.instantiateRenderEntity({
                castShadows: true
            });
            entity.setLocalPosition(0, 1.5, 0);
            app.root.addChild(entity);
}

At the moment both batching as well as runtime lightmap generation is supported and tested, which should be all that is needed on the engine side.

Closing this as this has been implemented and released.


Hyperlink in content text

Hello
Is there a way to add a hyperlink to the content text?

Someone asked for me to explain this in more detail:

Then you can add a template property to your steps with a reference to a TemplateRef and that will be used instead of the content property.

In whatever component that you use to initialize your tour steps, add a template to the html:
<ng-template #stepTemplate let-step="step">
  html tags will work here.

  You can also use info from the step:  {{step.content}}
</ng-template>

Then in your ts file, get a reference to that template like this:
@ViewChild('stepTemplate') stepTemplate: TemplateRef;

And use it in your tour step definition like this:
this.tourService.initialize([
  {
  anchorId: 'some.anchor.id',
  content: 'Some content',
  title: 'First',
}, {
  anchorId: 'another.anchor.id',
  content: 'Other content',
  template: this.stepTemplate,
  title: 'Second',
  },
]);

The first step will display the string content like normal, the second step will use a custom template.