Faulty sidebar links for search components outside of discovery context on mobile

Describe the bug
Links found within the sidebar of a search components (e.g. facets) outside of discovery context (so not on route "/search") link towards the "/search" page instead of their own.
To Reproduce
Steps to reproduce the behavior:

Visit a page that contains a search-component NOT on the "/search" route. Currently, I don't think there's a use-case for this on default dspace, so this can only be tested by adding <ds-search> to a component configured on a different route.
Switch to a mobile view (can use browser developer tools for this)
Open up the sidebar
Select a facet. This will link the user to the "/search" page, instead of staying on the current page and add the appropriate parameters.

Expected behavior
The user should stay on the current page with the appropriate parameters added to the url after clicking a facet.

Thanks @Atmire-Kristof .  My quick analysis is that this definitely sounds like a bug, but seems very low priority until we find a use case for this in default DSpace.  That said, I'll pull this over to our active board in case someone wants to donate a fix.


Extension resource Symbolic name for Resource that does not yet exist

Bicep version
06.10.61
Describe the bug
This might not be a bug as such.  We have a Policy that denies the creation of an NSG if it allows access to the Internet, however we need to create just such a policy and security are happy for us to put in a Policy Exemption.  However within bicep to deploy an Extension Resource (policyExemption) we need a symbolic name referencing an instance of the resource (NSG).  This would then create a dependency between the NSG and the policyExemption, and as the NSG will be denied if the policyExemption is not deployed we hit a blocking issue.
To Reproduce
Create and Assign Policy that blocks NSG's that allow AllInternet rule
Create NSG - blocked
Additional context
Ideally we would be able to refer to a resource Id within the Extension Resource Scope, but this is not allowed within bicep.

Can you share more details/code samples about how the policy exemption needs to be expressed in bicep? I'm not following where you are blocked

I see. I don't see this as a bicep issue, as you would have the same problem no matter what tool you are using. TBH, I'm struggling to understand how this would work. It is impossible to create an extension resource that extends a resource that doesn't exist. I'm going to share this with the policy team and see if they have any ideas or have come across the scenario.

Thanks for sharing your scenario-- we have related scenarios that have come up on our radar. Do these NSGs differ in configuration in any way from an NSG that would be denied-- for example, do you have a particular naming convention that you apply for these NSG resources being created?

@nehakulkarni123 There is nothing special about our naming convention, roughly following that MS best practice.  We would be hesitant to use names or tags for an exclusion as this could open up a potential hole in the policy.  All our other policy exemptions in this area are currently based on excluding the resource group (things like VM images etc), but as this is a PCI environment we need to lock down NSG's as far as possible.
Right now we disable the Policy Assignment, perform our deployment using Azure DevOps and Bicep as the base, and then re-enable the Policy Assignment so we will get notifications of any other exceptions.  Whilst this minimizes the time we are not protected by the Policies it does ensure we are notified in the case of an exception, so better then not having the policy but still a potential for manual intervention.


[#155463385] Use ops files

What
Generate the CF cloud-config and manifest fully with bosh interpolate using ops-files and get rid of spruce.
Changes:

we converted every CF manifest except the base one to an ops file
we changed the dynamic manifest generator scripts (for Grafana dashboards and VPC peering security groups) to generate ops files
we merged the base cloud config files into one main file
we converted all extra cloud config manifests to ops files
now the generation is only one step (bosh interpolate) in the Concourse pipeline
we moved the generation commands for cloud-config and the manifest into script files so we can test the same exact commands. This will make testing safer but sacrifices some clarity in the pipeline
we added additional tests to cover all aspects of the manifest generation (e.g. whether we add VPC peering for prod)

How to review

Deploy your CF from master
git checkout master
ENABLE_DATADOG=true SELF_UPDATE_PIPELINE=false<EMAIL_ADDRESS>make dev pipelines

Deploy your CF from this branch:
git checkout use_ops_files_155463385
BRANCH=use_ops_files_155463385 ENABLE_DATADOG=true SELF_UPDATE_PIPELINE=false<EMAIL_ADDRESS>make dev pipelines

In the cf-deploy/update-cloud-config and cf-deploy/cf-deploy jobs you should see no manifest diff and only the NATS instances (unreleated issue) should be redeployed

Who can review
Not @henrytk or me.

Works as described in dev environment.


SignChangeEvent lacks information about Player causing it

There are quite a lot of plugins which rely on signs containing a certain messsage, WirelessRedstone and TrainCarts being some more notable examples. Those plugins verify that only users permitted to do so can create those signs.
For those plugins it is invaluable that the SignChangeEvent provides which Player edited the sign - my proposal is that SignChangeEvent gets a public Optional<Player> getPlayer(), that will return an Optional.of() the player editing the sign if there is any or Optional.absent() if it was caused by something else.
This method should probably also be included in other events that can be caused by players.

Fixed in 0f3b893


Shield Generators by Frontier Developments not working as intended

Describe the bug
In using the mod "Shield Generators by Frontier Developments," the shield generators within the mod do not function as intended. Typically, bullets are supposed to be stopped by the shield, and their damage absorbed by the generator. Currently, the shield generated by all 3 generator types stop line of sight into them. This causes pawns to not be able to fire into the shield, nor select any targets within it or through it. Pawns can still shoot out of the shield without issue.
This issue does not generate an error.
To Reproduce
Steps to reproduce the behavior:

Enter any colony.
Place any Shield Generator (make sure it's powered.)
Attempt to have a pawn shoot into it.

Mod List
Shield Generators by Frontier Developments

@Psionic-Dragon can you please add a save with the conditions about to trigger? that would accelerate our time to resolution. thanks in advance!

@Psionic-Dragon can you please add a save with the conditions about to trigger? that would accelerate our time to resolution. thanks in advance!

this report does not have enough information


Actor Clustering / Distributed workflows

This library shows great promise as a replacement for Akka within the Cats ecosystem. However, one key feature is missing: Actor Clustering and a mechanism for distributed workflows.
Is there any plan to implement clustering in the near future?
Another key feature which I missing is persistent actor, is there any plan to implement this feature as well?

We are not currently working on clustering, but the cats-actors are designed in a way that won’t hinder or complicate the implementation when the time comes.
Implementing persistent actors should be relatively straightforward. The preStart method is of type F[], allowing you to connect to a database and enable this flow. Similarly, there is a postStop method of type F[] to handle cleanups before the actor stops. If you provide me with a sample of what you’re trying to achieve, I can look into it.
Feel free to contribute to both of these issues—it would be great to have more contributors to the project.

It's too much pressure to achieve functionality at the level of Akka or Pekko. Perhaps we can create a simpler version of the clustering workflow?

Personal opinion: the killer app of Akka / Pekko is Cluster Sharding -- it's the primary reason my own company is built around Akka.  Clustering on its own doesn't matter that much, but reliable cluster sharding is the primary reason I care about Actors at all: it's still arguably the best approach for serious CQRS / Event Sourced architectures.
(I totally agree that this is hard stuff, and have no intention of downplaying that.  Just mentioning that, from my POV, that's where the primary value is.  Take that data point as you will.)

Hello @stockstock2006 and @jducoeur,
Thank you very much for sharing your thoughts and perspective. I completely agree that cluster sharding would be an excellent feature, and I’m certainly open to considering different approaches. Could you share a bit more about what you have in mind?
At the moment, my time is a bit constrained, but I would be more than happy to collaborate on this to see it through. We’re currently working on a few adjustments to the FSM to better align it with our workflows, and we expect to release these updates either later today or tomorrow.


Filtering scenarios removed in 0.7?

In 0.6 there were CLI options to filter scenarios based on globs and/or tags, is that no longer available in 0.7?

It should still be there. Can you describe the problem that you're facing?

Oh, are globs being ignored? I might have just forgotten to re-add that during the refactor!

I'm not seeing anything obvious in the docs https://docs.rs/cucumber_rust/0.7.2/cucumber_rust/struct.Cucumber.html
To be clear I'm talking about the options here https://docs.rs/cucumber_rust/0.6.9/cucumber_rust/cli/struct.CliOptions.html


Add test suite

Problem
It's getting increasingly difficult to add features and make sure nothing's broken.
Idea
A suite of automated tests would be great to verify that everything's ok before merging new PRs.

Several tests and CI have been added as part of #237


readme.md

English:
How should I use these files relative to the released MOC files?
Current Translation:
我該如何使用與相對於已釋放的 MOC 檔案之這些檔案
Suggested Translation:
相對於發佈的 MOC 檔案，我應該如何使用這些檔案？
Description:
Mistranslation

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Run bugfix tool and waiting for result.


⚠ Bofrost.be has degraded performance

In 14eb6a5, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2330 ms

Resolved: Bofrost.be performance has improved in a29436f.


Grid Proxy Client free public IP field doesn't work as expected

The Grid Proxy Client free public IP field doesn't work as expected, see the screens below

Dashboard

Playground (Which uses the proxy client)

see node 106 and 107

Just a small note that public IPs in farm ID 3 will not work for node 106 and 107. Those nodes are there to test some new hardware and where added to farm ID 3 which is a dedicated node farm (did not remember at that time). Will remove them shortly and add them to a normal farm without public IPs until VLAN tagging is added to ZOS
I also noticed that farm ID 3 had one public IP reserved in the dashboard without any nodes in the farm (before I added node 106 & 107)

fixed and waiting for review.

Verified,

Devnet
a16e38d
TC2270 - Show Farm Information
TC2271 - Verify Farm Information from grid_proxy

The endpoint is the correct one with the right data returned at https://gridproxy.dev.grid.tf/farms?ret_count=true&page=1&size=10.
My deployment was reserving these IPs, and after deleting them, it shows them again as free public IPs.

Verified:

Devnet
2.3.0-alpha3


DL: CNN vis

https://github.com/aharley/nn_vis
Here is your next task:
Include
https://adamharley.com/nn_vis/cnn/3d.html
in CNN chapiter


Update changelog and documentation for nfAppIO and whnfAppIO

@vincenthz we should push a release to hackage after this. I am waiting for the bug fix described in the changelog.


Customize oauth login request to get refresh token from google

Google doesn't send a refresh token by default, these additional parameters are needed. So now "remember me" works, as the refresh token is automatically used to get a new token if the old one expired.

 Remember-me for OAuth User


Turn on windows tests in CI

Alrighty something isn't working @maritsandstad, over to you to work out what


Render to texture not working

Visual Studio is not capable of compiling your project anymore. This is, because you used GLenum drawBuffers[m_numTextures]; and Visual Studio doesn't want you to create dynamic arrays this way. The easy fix GLenum* drawBuffers = new GLenum[m_numTextures]; does not work either (but at least it compiles). It gives you this:

The whole -gray/brown/what have you- plane issue has in my opinion little to do with hardware.
I found out that when you don't use assimp for setting up the mesh where the scene will be rendered to, like Benny does in this tutorial, you just calculate the tangents and adjoin them as a vertex attribute: problem solved! I think the problem is caused by a badly shaped tbn matrix messing up the texture coordinates in the shaders. You can find the function which is responsible for doing this tangent calculations on GitHub,...somewhere in the mesh class. Here's some example of the rendering to texture scene, not using assimp (assimp will do this calculuation for you automatically). I rotated the camera a bit as you can see:

Peter


Resumes in Browser and Exported PDFs are blank

Case
BUG
Issue
The resumes shown in browser after running npm run dev are blank, as are the PDFs exported after running npm run export.
Info

Operating System: OSX
Node-Version: v10.4.0

Reproduce
I followed the README instructions. This is the terminal output from npm run dev:
→ npm run dev

><EMAIL_ADDRESS>dev /Users/wmartin/workspace/best-resume-ever
> node build/dev-server.js

> Starting dev server...
ℹ ｢wdm｣: wait until bundle finished:
(node:12886) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
ℹ ｢wdm｣: wait until bundle finished: /__webpack_hmr

 WARNING  Compiled with 4 warnings                                                                                8:29:37 PM

 warning

configuration
The 'mode' option has not been set, webpack will fallback to 'production' for this value. Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/concepts/mode/

 warning

asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
  static/fonts/opensans-condbold.790124b.eot (258 KiB)
  static/img/fontawesome-webfont.912ec66.svg (434 KiB)
  static/fonts/SourceSansPro-ExtraLight.abbaecf.ttf (285 KiB)
  static/fonts/SourceSansPro-Light.a663a1b.ttf (286 KiB)
  static/fonts/SourceSansPro-Regular.d165cf1.ttf (287 KiB)
  static/fonts/SourceSansPro-Semibold.c8eb654.ttf (286 KiB)
  static/fonts/SourceSansPro-Bold.1e9b84f.ttf (285 KiB)
  static/fonts/SourceSansPro-Black.587ba27.ttf (283 KiB)
  static/img/OpenSans-Light.d79f021.svg (258 KiB)
  static/img/OpenSans-LightItalic.b64e991.svg (291 KiB)
  static/img/OpenSans-Regular.f641a7d.svg (266 KiB)
  static/img/OpenSans-Italic.d6671d4.svg (291 KiB)
  static/img/OpenSans-Semibold.bb100c9.svg (1.11 MiB)
  static/img/OpenSans-SemiboldItalic.ddc348f.svg (289 KiB)
  static/img/OpenSans-Bold.d6291f8.svg (264 KiB)
  static/img/OpenSans-BoldItalic.a54aba8.svg (284 KiB)
  static/img/OpenSans-ExtraBold.8c5c497.svg (1.11 MiB)
  static/img/OpenSans-ExtraBoldItalic.9704305.svg (283 KiB)
  static/img/opensans-condlight.55ca06a.svg (817 KiB)
  static/img/opensans-condlightitalic.c00c6b0.svg (818 KiB)
  static/fonts/opensans-condbold.c28df5d.ttf (258 KiB)
  static/img/opensans-condbold.1e26591.svg (486 KiB)
  app.js (3.27 MiB)

 warning

entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  app (3.27 MiB)
      app.js

 warning

webpack performance recommendations:
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/

⚠ ｢wdm｣: Hash: 0f0cd0728a6344210209
Version: webpack 4.20.2
Time: 5836ms
Built at: 04/08/2019 8:29:37 PM
                                                    Asset       Size  Chunks                    Chunk Names
      static/fonts/SourceSansPro-BoldIt.ttf.7209467.woff2     35 KiB          [emitted]
                                static/img/id.087ce5d.jpg   23.6 KiB          [emitted]
                    static/fonts/Roboto-Thin.d3b4737.woff   82.3 KiB          [emitted]
             ... SNIPPETED
                     static/img/resume-purple.72ea863.png   26.4 KiB          [emitted]
               static/img/resume-side-bar-rtl.eb82423.png   53.9 KiB          [emitted]
             static/img/resume-left-right-rtl.7d7bb5b.png   56.9 KiB          [emitted]
                   static/img/resume-creative.1eb204b.png   26.5 KiB          [emitted]
                       static/img/resume-cool.9bb8b06.png   62.9 KiB          [emitted]
                              static/img/logo.1522a48.png     46 KiB          [emitted]
                                                   app.js   3.27 MiB       0  [emitted]  [big]  app
                                               index.html  391 bytes          [emitted]

Entrypoint app [big] = app.js
  [0] ./node_modules/vue/dist/vue.esm.js 286 KiB {0} [built]
  [1] ./node_modules/vue-loader/lib/runtime/componentNormalizer.js 2.63 KiB {0} [built]
  [6] ./node_modules/vue-hot-reload-api/dist/index.js 7.01 KiB {0} [built]
 [25] (webpack)/buildin/global.js 509 bytes {0} [built]
 [44] ./src/App.vue?vue&type=script&lang=js& + 1 modules 365 bytes {0} [built]
      | ./src/App.vue?vue&type=script&lang=js& 332 bytes [built]
      | ./node_modules/babel-loader/lib!./node_modules/vue-loader/lib??vue-loader-options!./src/App.vue?vue&type=script&lang=js& 33 bytes [built]
[104] ./src/App.vue 1.09 KiB {0} [built]
[108] multi ./build/dev-client ./src/main.js 40 bytes {0} [built]
[109] ./build/dev-client.js 245 bytes {0} [built]
[110] ./node_modules/eventsource-polyfill/dist/browserify-eventsource.js 852 bytes {0} [built]
[112] (webpack)-hot-middleware/client.js?noInfo=true&reload=true 7.59 KiB {0} [built]
[119] (webpack)-hot-middleware/client-overlay.js 2.16 KiB {0} [built]
[124] (webpack)-hot-middleware/process-update.js 4.26 KiB {0} [built]
[125] ./node_modules/timers-browserify/main.js 1.97 KiB {0} [built]
[128] ./src/App.vue?vue&type=style&index=0&lang=css& 556 bytes {0} [built]
[328] ./src/main.js + 2 modules 64.6 KiB {0} [built]
      | ./src/main.js 213 bytes [built]
      | ./src/router/index.js 325 bytes [built]
      | ./node_modules/vue-router/dist/vue-router.esm.js 64.1 KiB [built]
    + 314 hidden modules

WARNING in configuration
The 'mode' option has not been set, webpack will fallback to 'production' for this value. Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/concepts/mode/

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
  static/fonts/opensans-condbold.790124b.eot (258 KiB)
  static/img/fontawesome-webfont.912ec66.svg (434 KiB)
  static/fonts/SourceSansPro-ExtraLight.abbaecf.ttf (285 KiB)
  static/fonts/SourceSansPro-Light.a663a1b.ttf (286 KiB)
  static/fonts/SourceSansPro-Regular.d165cf1.ttf (287 KiB)
  static/fonts/SourceSansPro-Semibold.c8eb654.ttf (286 KiB)
  static/fonts/SourceSansPro-Bold.1e9b84f.ttf (285 KiB)
  static/fonts/SourceSansPro-Black.587ba27.ttf (283 KiB)
  static/img/OpenSans-Light.d79f021.svg (258 KiB)
  static/img/OpenSans-LightItalic.b64e991.svg (291 KiB)
  static/img/OpenSans-Regular.f641a7d.svg (266 KiB)
  static/img/OpenSans-Italic.d6671d4.svg (291 KiB)
  static/img/OpenSans-Semibold.bb100c9.svg (1.11 MiB)
  static/img/OpenSans-SemiboldItalic.ddc348f.svg (289 KiB)
  static/img/OpenSans-Bold.d6291f8.svg (264 KiB)
  static/img/OpenSans-BoldItalic.a54aba8.svg (284 KiB)
  static/img/OpenSans-ExtraBold.8c5c497.svg (1.11 MiB)
  static/img/OpenSans-ExtraBoldItalic.9704305.svg (283 KiB)
  static/img/opensans-condlight.55ca06a.svg (817 KiB)
  static/img/opensans-condlightitalic.c00c6b0.svg (818 KiB)
  static/fonts/opensans-condbold.c28df5d.ttf (258 KiB)
  static/img/opensans-condbold.1e26591.svg (486 KiB)
  app.js (3.27 MiB)

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  app (3.27 MiB)
      app.js

WARNING in webpack performance recommendations:
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/
Child html-webpack-plugin for "index.html":
         Asset      Size  Chunks  Chunk Names
    index.html  1.38 MiB       0
    Entrypoint undefined = index.html
    [0] ./node_modules/html-webpack-plugin/lib/loader.js!./index.html 543 bytes {0} [built]
    [1] ./node_modules/lodash/lodash.js 527 KiB {0} [built]
    [2] (webpack)/buildin/global.js 509 bytes {0} [built]
    [3] (webpack)/buildin/module.js 519 bytes {0} [built]
ℹ ｢wdm｣: Compiled with warnings.
> Listening at http://localhost:8080

When clicking one of the resume options in the browser this appears like:

Hi @williammartin , I've had the same problem in the past. You can try checking the browser console log to see if there is any error message. In my case I did something wrong on the data.yml file. When I fix it, the resume appeared normally.

Can confirm @gcartier94 it is a formatting issue. Correct the formatting it will display as normal.

I don't even remember creating this but since it sounds like it was probably my fault I'm gonna go ahead and close it. Thanks all.


can't execute phantomJs on CircleCI

Kinda related to other issues but this is more specific
I noticed that phantomjs would not start on Circle CI because the executable was not compatible with the arch.  (mach-o i386)
What's odd is that meteor-tool also installs phantomjs (could we just use that instead of downloading it twice??) but it the proper arch  (ELF 64-bit LSB executable)
For whatever reason phantomjs npm for xolvio:webdriver is not downloading the correct executable when running on CircleCI
./packages/xolvio_webdriver/.0.2.1.kj2el4++os+web.browser+web.cordova/npm/node_modules/phantomjs/lib/phantom/bin/phantomjs: Mach-O executable i386
./packages/meteor-tool/.<IP_ADDRESS>ef5dzv++os.linux.x86_64+web.browser+web.cordova/meteor-tool-os.linux.x86_64/dev_bundle/lib/node_modules/phantomjs/lib/phantom/bin/phantomjs: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.9, stripped

sorry for long replies, I've been away
I've noticed this also. @queso made a change that allows you to pass in a PHANTOM_PATH. I'm trying to figure out the meteor-tools path and to use that instead - that is the right approach I think

I am not sure it is right approach. The better approach would be to figure out why the npm phantom package isn't grabbing the right binary. Or make cucumber crap out when phantom doesn't start.

agreed, the getGhostDriver should have a timeout rather than linger forever.
I do recall something to do with having to run the process as a node process on linux boxes as opposed to a binary. I'll try to mess with that.

should be fixes in latest


Adding Pick-Seq attributes to the data model.

Modifying nucleic acid source and adding new attribs in order to support Pick-Seq.
Issue is here:
https://github.com/ncihtan/data-models/issues/269

looks good to me now :)


Codegen traps values when using function in useSelector

I noticed that when I toggled on and off the codeGeneratorYasmlPlugin that the example

export function CounterSetter() {
  const { increment } = useGlobalState();
  const state = useGlobalState((state) => ({
    test: state.counter * 2,
    rawr: "goes the lion",
  }));
  return <button onClick={() => increment()}>Increment {state.test}</button>;
}

The value in test could get trapped and never update on click.

I believe I knew this before. The issue I had tested is that increment is the only variable being used so with codegen that gets put automatically into the useGlobalState hook which causes counter to get trapped and never used.
I think this is the desired behavior even if it is not obvious.


update src/qt/bitcoin_locale.qrc and makefile.qt.include for new translations

per https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md
adding all the latest translations
https://www.loc.gov/standards/iso639-2/php/code_list.php
Went through the new pull requests and the existing translation files and organized / updated bitcoin_locale.qrc with the latest as of 3/25/2018 .. I think :smile:

file
language
pull req
already exists in master
entry in bitcoin_locale.qrc

src/qt/locale/bitcoin_en.ts
english

x
x

src/qt/locale/bitcoin_es.ts
spanish
334
x
x

src/qt/locale/bitcoin_fr.ts
french
333
x
x

src/qt/locale/bitcoin_nb.ts
Norwegian

x
x

src/qt/locale/bitcoin_nl.ts
dutch
384,363, 329,332
x
x

src/qt/locale/bitcoin_ru.ts
russian

x
x

src/qt/locale/bitcoin_tr.ts
turkish
331
x
x

src/qt/locale/bitcoin_pl.ts
polish

x

src/qt/locale/bitcoin_cn.ts
chinese
420

src/qt/locale/bitcoin_de.ts
german
311

src/qt/locale/bitcoin_el.ts
greek
359

src/qt/locale/bitcoin_it.ts
italian
319

src/qt/locale/bitcoin_ptbr.ts
brazilian portuguese
303

src/qt/locale/bitcoin_ro.ts
romanian/moldavian
367

src/qt/locale/bitcoin_ua.ts
ukranian
313

Compiles Windows OK, but errors out for Mac and UNIX.
Potential reasons because many of the files I'm including aren't technically merged yet and don't exist?

Mac error:

Undefined symbols for architecture x86_64:
"qInitResources_bitcoin_locale()", referenced from:
_main in qt_VERGE_qt-bitcoin.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [qt/VERGE-qt] Error 1
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
cat: src/test-suite.log: No such file or directory
The command "./building/${VERGE_PLATFORM}/build.sh" failed and exited with 1 during .

Linux error:

E: Could not get lock /var/lib/dpkg/lock - open (11: Resource temporarily unavailable)
E: Unable to lock the administration directory (/var/lib/dpkg/), is another process using it?
E: Could not get lock /var/lib/dpkg/lock - open (11: Resource temporarily unavailable)
E: Unable to lock the administration directory (/var/lib/dpkg/), is another process using it?
E: Could not get lock /var/lib/dpkg/lock - open (11: Resource temporarily unavailable)
E: Unable to lock the administration directory (/var/lib/dpkg/), is another process using it?
The command "./building/${VERGE_PLATFORM}/requirements.sh" failed and exited with 100 during

I'm pretty sure that once pulls: #420 , #311 , #359 , #319 , #303 , #367  , #313 are merged , this will compile fine ?
These 2 files contain updates for the new translations in the pulls above, and a fix for the polish one missing from bitcoin_locale.qrc
Comments / advice appreciated !

yes, the bitcoin_x.ts files needs to be there, hence the crashing

and since I can't push the ts files there, only verge devs can , this will just need to be merged "last".
After those other ones are merged... this can be merged and should work ok!
Thanks for reviewing @Max-Meldrum  !

and I know it's probably not good practice to do it this way - but I didn't want to go take all the new .ts files from other peoples repo's into mine and then create 1 big pull request... but if you think that's a better way to do it .. i will gladly.  I just feel dirty like I'm stealing credit :smile:

So i went and downloaded all the TS files from all the different repos.  I got 2 options
Option A)  Remove this pull request.  Add all their TS files to MY Repo.  Create new pull request
Option B)  Leave it as is -- and just try to work with the devs to make sure they do this one last
If I go the option A route -- it would essentially nullify the 'contribution' from the others?  I couldn't figure out how to really do a pull from their repo into my repo.  I could only figure out how to download the different TS files.
I guess in theory -- the devs could still merge all their requests.
The only reason I would be doing this is to try to get it to compile properly on this pull request.  I won't be able to get this to compile because the TS files are missing from the verge master repo.  They are sitting here as pull reqs, just not merged to master yet.
I don't know, someone tell me what to do :smile:

updating chart/status of pull reqs and translations

file
language
pull req
in master
bitcoin_locale.qrc
makeflile.qt.inc
merged

bitcoin_en.ts
english

x
x
x

bitcoin_es.ts
spanish
334
x
x
x

bitcoin_fr.ts
french
333
x
x
x

bitcoin_nb.ts
Norwegian

x
x
x

bitcoin_nl.ts
dutch
384,363, 329,332
x
x
x

bitcoin_ru.ts
russian

x
x
x

bitcoin_tr.ts
turkish
331, 320
x
x
x
3/26/2018**

bitcoin_pl.ts
polish

x

bitcoin_cn.ts
chinese
420
x

3/26/2018

bitcoin_de.ts
german
311
x

3/26/2018

bitcoin_el.ts
greek
359

bitcoin_it.ts
italian
319
x

3/26/2018

bitcoin_ptbr.ts
brazilian   portuguese
303

bitcoin_ro.ts
romanian/moldavian
367

bitcoin_ua.ts
ukranian
313

closing -- found a couple issues -- will make pull request with better version


Fixes MediaEngine: codec apt negotiation

codec has apt fmtp can't negotiation because it's
apt payloadtype can't be found in negotiation codecs.
rtx codec must be partial match if apt codec is partial.
fix eeb67e1.
Description
rtx codec must be partial match if apt codec is partial.
Reference issue
Fixes #1785

@cnderrauber :fire: thanks for fixing this so quick! Will test first thing in the morning and then merge, only have my phone on me :(

Merged with d2f672f343fa980c372b7b71e587fc9735eab41e great work @cnderrauber :)


Failing to run fipsinstall on HP-UX

Summary
We are building OpenSSL 3.0.7 on an HP-UX ia64 11.31 machine (Build Machine), and using the generated fips.so file to generate a FIPS configuration file on a different HP-UX machine (User Machine; also ia64 11.31). When we try to run openssl fipsinstall on the User Machine, it fails with Unable to find library 'libgcc_s.so.0'.
Does the fips.so file have a dependancy on gcc? Note that we had built OpenSSL using gcc, but the User Machine (the one on which we are running openssl fipsinstall) doesn't have gcc. It only has the bundled hpux cc compiler.
Details on how we built OpenSSL 3.0.7
Details on the Build Machine
$ uname -a
HP-UX s-1537-v B.11.31 U ia64 HP-UX

$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
Target: ia64-hp-hpux11.31
Configured with: ../gcc-4.8.5/configure --prefix=/opt/gcc-4.8.5 --enable-checking=release --with-gnu-as --with-as=/usr/local/bin/as --without-gnu-ld --with-ld=/usr/ccs/bin/ld --enable-languages=c,c++ --enable-shared --disable-nls --disable-libgcj --disable-libgomp --with-dwarf2 --enable-threads=posix --enable-targets=all CC='gcc -mlp64 -D_HPUX_SOURCE -D_INCLUDE_HPUX_SOURCE' CXX='g++ -mlp64 -D_HPUX_SOURCE -D_INCLUDE_HPUX_SOURCE' LDFLAGS=-mlp64 CFLAGS='-O2 -g -mlp64' CXXFLAGS='-O2 -g -mlp64' --disable-bootstrap
Thread model: posix
gcc version 4.8.5 (GCC)

Commands used to build OpenSSL
$ cd openssl-3.0.7
$ export CC=gcc; export CXX=g++; export CFLAGS="-pthread -O2 -g -mlp64 -D_GLIBCXX_USE_C99"; export CXXFLAGS="-pthread -O2 -g -mlp64 -D_GLIBCXX_USE_C99 -std=c++11"
$ ./Configure --prefix=/openssl_build_dir --openssldir=/openssl_build_dir hpux64-ia64-gcc no-shared enable-fips
$ gmake -j4
$ gmake install -j4

Details on running fipsinstall
Then we copied the generated openssl_build_dir/bin/openssl binary and openssl_build_dir/lib/hpux64/ossl-modules/fips.so file to the User Machine,  and ran this command:
$ /path/to/openssl fipsinstall -module /path/to/fips.so -out openssl-fips.cnf -provider_name fips
Failed to load FIPS module
INSTALL FAILED
00000001:error:12800067:DSO support routines:(unknown function):could not load the shared library:crypto/dso/dso_dlfcn.c:118:filename(/ossl-modules/fips.so): Unable to find library 'libgcc_s.so.0'.
00000001:error:12800067:DSO support routines:(unknown function):could not load the shared library:crypto/dso/dso_lib.c:152:
00000001:error:07880025:common libcrypto routines:(unknown function):reason(524325):crypto/provider_core.c:912:name=fips

As you can notice the above command fails to load the FIPS module. Does fipsinstall run successfully only on the machine that we built OpenSSL on?
We have a special use-case in which users would run our application on their machines, and in order to generate a FIPS configuration file on their machine, we bundle our application along with the openssl binary and the fips.so file. Is there some way to generate the FIPS configuration file, without bundling libgcc_s.so.0 object file too? We confirmed that copying libgcc_s.so.0 to the User Machine and adding its path to SHLIB_PATH helps run fipsinstall successfully.
Details on the User Machine
$ uname -a
HP-UX s-1537-v B.11.31 U ia64<PHONE_NUMBER> unlimited-user license

$ cc -V
(Bundled) cc: HP C/aC++ B3910B A.06.12 [Oct 11 2006]

$ which gcc
no gcc in /usr/local/bin /usr/sbin /usr/bin /usr/ccs/bin ...other directories in $PATH

Any help or pointers on this is greatly appreciated. Thanks!

First problem: 3.0.7 isn't FIPS validated.  You must build either 3.0.0 or 3.0.8 to get an approved FIPS provider.
Second problem: it looks like you need some kind of cross compilation setup.  libgcc_s.so.0 isn't part of OpenSSL it comes with the compiler you're using and the dependency is being added when the .so is built.  It might be possible to include this library inside the FIPS provider, this would require fiddling with the link line in a system dependent manner.


[FLINK-30919][docs] Fix typo for the sink ability part in the document of User-defined Sources & Sinks

What is the purpose of the change
To fix the typo in the document of User-defined Sources & Sinks
Brief change log
Verifying this change
Verify it by manually.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@ruanhang1993 Thanks for review. Merging....


Update README.md

Added Methode to load the scss files in an angular cli project

Coverage remained the same at 93.659% when pulling 5785f658076219994c4bdfdfd6ecf451dbe6dc31 on sebbi08:patch-1 into f23bf7026f8724d309dee52ab11edee45ffd2487 on mseemann:master.

hi. thx for your contribution. what is the benefit of your approach and not using the webpack special syntax?
@import '~@angular2-mdl-ext/popover/popover';
@import '~@angular2-mdl-ext/select/select';

i could not find a way to editthe webpack config since this is done completely by angular cli

you don't need to change the webpack config. just add this:
@import '~@angular2-mdl-ext/popover/popover';
@import '~@angular2-mdl-ext/select/select';
to your styles.scss file. webpack knows that '~@angular2-mdl-ext' is located in the node_modules folder...

ok that would have worked too but since i am using less as css pre-processor i'd not like to create a styles.scss just for importing these two modules

i don't know much about less. but https://github.com/webpack/less-loader seems to have the same possibility (see the Import section)

thats true but i cant import .scss/.css files into less

ok forgett it it is posible i just have so say i omittet the file ending and that it did not work
@import<EMAIL_ADDRESS>@import<EMAIL_ADDRESS>

never mind!


uniquery for evm indexer

make uniquery available for evm (kodadot/basick)

It is available sir
import { getClient } from '@kodadot1/uniquery'

const client = getClient('base')

const query = client.collectionListByName('harmony')

const res = await client.fetch(query)
console.log(res)

Thank you! Maybe indicate on the readme the list of available client?

Thank you! Maybe indicate on the readme the list of available client?

Yup I plan to reexport Prefix from 'kodadot1/static' so it is more user friendly

added in #52
released in 0.7.0-rc.1

published https://github.com/kodadot/uniquery/actions/runs/11181143417/job/31084457507


25 Mar 10:42:18 - [warn] [contextbrowser] /contextbrowser/flow/:id TypeError: context.getKeys is not a function

25 Mar 10:42:18 - [warn] [contextbrowser] /contextbrowser/flow/:id TypeError: context.getKeys is not a function

On Windows 10 with Node v6, latest Node-RED
No vars appear in the contextbrowser tab.

Have just installed on Win10 , node 6.9.5 without issues.
Did you patch node-red as discribed in the installation notes?
The feature request on the node-red forum found not its way to the node-red trello - so unfortunately still need to patch node-red everytime.

OK, that will be it I expect, sorry to have missed that.


Mixed float / int operators cast the wrong way

The following pixel shader:
float4 PixelMain(float a : TEXCOORD0) : SV_Target
{
float b = 1 - a;
return b;
}
Gives the following result:
#version 130
in float xsc_vary_TEXCOORD0;
out vec4 SV_Target0;
void main()
{
float b = float(1 - int(xsc_vary_TEXCOORD0));
SV_Target0 = b;
}
It casts the texcoord into int instead of converting 1 to float.

This is indeed a problem of the translation from HLSL's implicit casts to GLSL explicit casts, because GLSL only very restricted implicit casts.
Currently the right-hand-side of a binary expression is casted to match the type of the left-hand-side.
I think a function which determines the best suitable types for a binary expression should do the trick.

I continued with the translation of implicit conversions, and your code works now (but this is not the end of the story).
Here is the current example I use:
float4 VS(float x : TEXCOORD0) : SV_Position
{
    float  a = 1 + 1;
    float  b = 2 + x;
    float  c = 3.0 + x;
    float  d = x + 4;
    float  e = 5;
    float  f = -6 + x;
    float3 g = 3 + 1.5;
    float3 h = 1 + g + 2;
    float3 i = h*2.0;
    float3 j = h*2;
    float3 k = h+2.0;
    float3 l = h+2;
    return 1;
}

And this is the GLSL output:
#version 130

in float x;

void main()
{
    float a = float(1 + 1);
    float b = 2.0 + x;
    float c = 3.0 + x;
    float d = x + 4.0;
    float e = 5.0;
    float f = float(-6) + x;
    vec3 g = vec3(3.0 + 1.5);
    vec3 h = vec3(1) + g + vec3(2);
    vec3 i = h * 2.0;
    vec3 j = h * 2.0;
    vec3 k = h + vec3(2.0);
    vec3 l = h + vec3(2);
    gl_Position = vec4(1);
}


Observable.Delay throws PlatformNotSupportedException on Blazor WASM.

Bug
On Blazor WASM, Observable.Delay is not implemented.
Index.razor
@page "/"
@using System.Reactive.Linq
@using System.Reactive.Threading.Tasks

@code {

    protected override async Task OnInitializedAsync()
    {
        await Observable.Return(1)
            .Delay(TimeSpan.FromSeconds(1))
            .ToTask();
    }

}

Exception:
System.PlatformNotSupportedException: Operation is not supported on this platform.
   at System.Threading.Thread.ThrowIfNoThreadStart(Boolean internalThread)
   at System.Threading.Thread.Start(Object parameter, Boolean captureContext, Boolean internalThread)
   at System.Threading.Thread.Start(Object parameter)
   at System.Reactive.Concurrency.ConcurrencyAbstractionLayerImpl.StartThread(Action`1 action, Object state)
   at System.Reactive.Concurrency.DefaultScheduler.LongRunning.LongScheduledWorkItem`1[[System.Threading.CancellationToken, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]..ctor(CancellationToken state, Action`2 action)
   at System.Reactive.Concurrency.DefaultScheduler.LongRunning.ScheduleLongRunning[CancellationToken](CancellationToken state, Action`2 action)
   at System.Reactive.Linq.ObservableImpl.Delay`1.Base`1.L[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Reactive.Linq.ObservableImpl.Delay`1.Relative[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Reactive, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=94bc3704cddfc263]].ScheduleDrain()
   at System.Reactive.Linq.ObservableImpl.Delay`1.Relative.L[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].RunCore(Relative parent)
   at System.Reactive.Linq.ObservableImpl.Delay`1.Base`1._[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Reactive.Linq.ObservableImpl.Delay`1.Relative[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Reactive, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=94bc3704cddfc263]].Run(Relative parent)
   at System.Reactive.Linq.ObservableImpl.Delay`1.Relative[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Run(_ sink)
   at System.Reactive.Producer`2.<>c[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Reactive.Linq.ObservableImpl.Delay`1.Base`1._[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Reactive.Linq.ObservableImpl.Delay`1.Relative[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Reactive, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=94bc3704cddfc263]], System.Reactive, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=94bc3704cddfc263]].<SubscribeRaw>b__1_0(ValueTuple`2 tuple)
   at System.Reactive.Concurrency.Scheduler.<>c__75`1[[System.ValueTuple`2[[System.Reactive.Producer`2[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Reactive.Linq.ObservableImpl.Delay`1.Base`1._[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Reactive.Linq.ObservableImpl.Delay`1.Relative[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Reactive, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=94bc3704cddfc263]], System.Reactive, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=94bc3704cddfc263]], System.Reactive, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=94bc3704cddfc263],[System.Reactive.Linq.ObservableImpl.Delay`1.Base`1._[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Reactive.Linq.ObservableImpl.Delay`1.Relative[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Reactive, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=94bc3704cddfc263]], System.Reactive, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=94bc3704cddfc263]], System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].<ScheduleAction>b__75_0(IScheduler _, ValueTuple`2 tuple)
   at System.Reactive.Concurrency.CurrentThreadScheduler.Schedule[ValueTuple`2](ValueTuple`2 state, TimeSpan dueTime, Func`3 action)
   at System.Reactive.Concurrency.LocalScheduler.Schedule[ValueTuple`2](ValueTuple`2 state, Func`3 action)
   at System.Reactive.Concurrency.Scheduler.ScheduleAction[ValueTuple`2](IScheduler scheduler, ValueTuple`2 state, Action`1 action)
   at System.Reactive.Producer`2[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Reactive.Linq.ObservableImpl.Delay`1.Base`1._[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Reactive.Linq.ObservableImpl.Delay`1.Relative[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Reactive, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=94bc3704cddfc263]], System.Reactive, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=94bc3704cddfc263]].SubscribeRaw(IObserver`1 observer, Boolean enableSafeguard)
   at System.Reactive.Producer`2[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Reactive.Linq.ObservableImpl.Delay`1.Base`1._[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Reactive.Linq.ObservableImpl.Delay`1.Relative[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Reactive, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=94bc3704cddfc263]], System.Reactive, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=94bc3704cddfc263]].Subscribe(IObserver`1 observer)
   at System.Reactive.Threading.Tasks.TaskObservableExtensions.ToTask[Int32](IObservable`1 observable, CancellationToken cancellationToken, Object state)
--- End of stack trace from previous location ---
   at TabletsUI.Pages.Index.OnInitializedAsync() in ..\Pages\Index.razor:line 11
   at Microsoft.AspNetCore.Components.ComponentBase.RunInitAndSetParametersAsync()

The issue is slightly deeper than this. Observable.Delay itself isn't the problem—it can be made to work. Here's a modification that works around the issue you're seeing:
IScheduler sch = DefaultScheduler.Instance.DisableOptimizations();
await Observable.Return(1)
    .Delay(TimeSpan.FromSeconds(1), sch)
    .ToTask();

You should then see Delay work correctly. This demonstrates that Delay itself is perfectly capable of working on Blazor WASM.
So the question is why does it fail when used in the default way?
The basic problem here is this: by default all timed operators in Rx default to using SchedulerDefaults.TimeBasedOperations to run work at the necessary time. That property returns an instance of DefaultScheduler, and DefaultScheduler supports an optional scheduler feature: ISchedulerLongRunning which it implements by spinning up a new thread. Delay will use this scheduler feature if available, because the nature of Delay (an inherently very expensive operator, and not one you would use if your only goal was to generate a single notification 1 second from now) is that it can work a lot better if it has a thread to itself.
The problem of course is that you're not allowed to create new threads on WASM. The workaround above basically downgrades the scheduler to one where no optional features (such as long running operation support) are available. This is probably overkill. This may be disabling other optimizations that would actually work.
It might be that the most straightforward way for us to fix this is to have the ConcurrencyAbstractionLayerImpl detect when threads can't be created. It currently has this:
public bool SupportsLongRunning => true;

but if this were to return false on Blazor WASM, you would no longer need the workaround, because the DefaultScheduler checks that property and only tries to create new threads if it returns true.
There was a time where different builds of Rx for different environments would hard-code SupportsLongRunning either to true or false because some of our build targets just didn't support creation of new threads at all.
The problem for WASM is that it's not a distinct build target. Because of the "One .NET" initiative, it just ends up being net6.0.
Presumably there's some way to discover at runtime that thread creation is unavailable—other libraries must have encountered this problem on WASM before. So it might just be a case of finding out what the preferred way is to ask "Are we allowed to create new threads?" and making SupportsLongRunning report that.
However, there might well be other WASM-specific problems. The root cause of why it was possible for this to blow up like this is that we've never executed our test suites on WASM.
So rather than merely fixing up this one symptom, I think the best thing to do would be to work out how to run the full Rx test suite on Blazor WASM. That would reveal any other issues.

Note to self: maybe https://devblogs.microsoft.com/dotnet/introducing-ms-test-runner/ could help with this?


[about input signal] I don't know how to calculate input force.

in the low level code,
def pwm_converter_callback(msg):
31     global motor_pwm, servo_pwm, b0
33     # translate from SI units in vehicle model
34     # to pwm angle units (i.e. to send command signal to actuators)
36     # compute servo command
37     str_ang     = 180.0/pimsg.servo  # convert steering angle to degrees
38     servo_pwm   = 92.0558 + 1.8194str_ang  - 0.0104*str_ang**2
40     # compute motor command
41     FxR         =  float(msg.motor)
42     if FxR == 0:
43         motor_pwm = 90
44     elif FxR > 0:
45         motor_pwm   =  FxR/b0 + 95
46     else:
47         motor_pwm = 90
48     update_arduino()
i don't know

servo_pwm   = 92.0558 + 1.8194str_ang  - 0.0104str_ang**2

 motor_pwm   =  FxR/b0 + 95

how to calculate this equation.

hi @min-chuir-Park, this problem falls under model identification.
please check out this master's thesis from one of our former contributors, Max.
In chapter 4, "Implementation", he talks about how about model selection and fitting
The numbers in the low-level code differ from the numbers he presents in his thesis, but the approach taken is the same.

Thank you for your reply. But   I  can't  find  any  information master's  thesis  github about implement .  Could you write  address of  information??


Remove unused rev_reg_ids cache

Signed-off-by: Patrik Stas<EMAIL_ADDRESS>

Codecov Report

Merging #434 (2b1755b) into main (1f863a3) will decrease coverage by 10.38%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #434       +/-   ##
===========================================
- Coverage   60.05%   49.67%   -10.39%
===========================================
  Files         153      138       -15
  Lines       14343    11135     -3208
  Branches     3533     2306     -1227
===========================================
- Hits         8614     5531     -3083
- Misses       2381     3766     +1385
+ Partials     3348     1838     -1510

Flag
Coverage Δ

integration-aries-vcx
?

unittests-agency-client
?

unittests-aries-vcx
49.67% <ø> (+0.21%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

aries_vcx/src/libindy/utils/cache.rs
0.00% <ø> (-23.34%)
:arrow_down:

...ndlers/proof_presentation/prover/states/initial.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

...ers/issuance/credential_def/revocation_registry.rs
0.00% <0.00%> (-63.64%)
:arrow_down:

aries_vcx/src/libindy/utils/anoncreds.rs
8.78% <0.00%> (-63.42%)
:arrow_down:

aries_vcx/tests/utils/devsetup_agent.rs
0.00% <0.00%> (-60.13%)
:arrow_down:

aries_vcx/src/libindy/utils/signus.rs
33.33% <0.00%> (-55.56%)
:arrow_down:

aries_vcx/src/libindy/utils/pool.rs
9.27% <0.00%> (-52.49%)
:arrow_down:

...src/handlers/proof_presentation/prover/messages.rs
0.00% <0.00%> (-50.00%)
:arrow_down:

...x/src/handlers/proof_presentation/prover/prover.rs
18.84% <0.00%> (-49.43%)
:arrow_down:

aries_vcx/src/utils/provision.rs
0.00% <0.00%> (-46.88%)
:arrow_down:

... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f863a3...2b1755b. Read the comment docs.


Create Discord Channel

Setup Discord for project.

Here is the permanent invite link.
https://discord.gg/ZsqfMmQ


Incorrect return value in comments

The "Returns" portion says that the function returns "IReadOnlyList<T>", but that is only true for .NET and I have it set to show documentation for C++/WinRT. I'd expect it to say "IVectorView<T>" with a link to the documentation for IVectorView

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd8b7650-a2ee-b9b8-1a96-211049ddebd0
Version Independent ID: a7c365fc-063b-90a2-8eb2-19f95d9e0f59
Content: IVector<T>.GetView Method (Windows.Foundation.Collections) - Windows UWP applications
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.foundation.collections.ivector_t.yml&version=GBlive&_a=contents
Product: uwp
Technology: winrt-reference
Git Login: hickeys
Microsoft Alias: hickeys

Hello, sorry for the delayed response to your issue. The syntax blocks in our API reference pages are dynamically generated. It appears that since you opened this issue, the code generation has been fixed and so the C++/WinRT signature is now correct:
IVectorView<T> GetView();
Thank you for contributing to the quality and accuracy of our documentation!


Theme: Dark palettes for navigation menu and content page

It would be cool to have complete support dark palettes for both left and right frames.

For the left frame new Luna and Black palettes are going to be added in 18.40.

Work for the right frame is in progress and also planed to be added to 18.40.

Luna is renamed to Gunmetal, Black renamed to Noir.
The right frame color palette is called darkRider. This is about how is it going to look. It will be pushed to the repo within next 48 hours after thorough and final testing.

Please be kind to git pull and check how it works out for you.

This palette is the part of the dark/night mode that can be toggled by default using Alt+L in 18.40.


fix: use mainnet ENS for L2s

christian noticed it was not ideal that when switching to an L2 your ENS information would go away. small fix to always pull ENS from mainnet throughout RK

Is there any argument against this @nicoglennon ?

This will resolve this issue, yeah? https://github.com/rainbow-me/rainbowkit/discussions/429

This will resolve this issue, yeah?

nope that is different, although i believe it only happens in dev mode (next)


SAM Build support for .Net Runtimes

Describe your idea/feature/enhancement
sam build should support the .Net runtimes.
Proposal
Update when design is added to aws-lambda-builders. For now, this is a tracking support issue.

This has been released with v0.15.0


Prevent ArgumentError for 0 dates

If a DOS Time is 0, it raised an ArgumentError. This fixes it to behave the same as a nil time.

The way I solved this was to fix the incorrect method call that was triggered when a nil was passed to the DOSTime initializer.  Passing a zero value is considered an attempt to pass a valid structure to the initializer, but this will fail now since that structure contains elements that are out of range.


Creating custom theme

In sveltekit using preprocess I can override the theme by copying one of the .scss files from this repository adding this snippet
$carbon--theme: map-merge(
	$carbon--theme--g10,
	(
		// overrides here
		interactive-01: purple
	)
);
@include carbon--theme();

This is all in an external stylesheet which is imported into __layout.svelte like:
<style lang="scss" global>
	@import '../scss/theme.scss';
</style>

My issue is the themes take quite a long time to compile. I see that normally you would compile down to css as separate step and use those sheets! Only issue with that is I can't seem to reference the css variables after it has been compiled.
Is it possible to either:

keep the scss, but compile it efficiently?
compile the scss to css keeping the css variables

Cheers!

To compile the scss with css use the following snippet:
:root {
	@include carbon--theme($my-theme, true) {
		@include emit-component-tokens($tag-colors);
	}
}

in the place of
@include carbon--theme()

also need to have enable-css-custom-properties: true in the feature flags

@jhwz would it be possible to have a guide or similar somewhere on this?
I'm struggling to apply the custom theming logic of carbon to the svelte version if it.
(What we're trying to do is basically just customize theme colors / vars and ideally also use them for our custom components)

Have a look at the scss files @metonym has in the /css folder, they are a helpful reference.
A full example of a scss file you could use is:
$feature-flags: (
	ui-shell: true,
	grid-columns-16: true,
	enable-css-custom-properties: true
);

$css--font-face: true;
$css--helpers: true;
$css--body: true;
$css--use-layer: true;
$css--reset: true;
$css--default-type: true;
$css--plex: true;

@import 'carbon-components/scss/globals/scss/vendor/@carbon/themes/scss';
@import 'carbon-components/scss/globals/scss/component-tokens';
@import 'carbon-components/src/components/tag/tag';
@import 'carbon-components/src/components/notification/inline-notification';
@import 'carbon-components/src/components/notification/toast-notification';

# Define a color palette
$blue-01: #0a1b3c;
$blue-02: #0c2148;
$blue-03: #0d2755;
$blue-04: #0e2d62;
$blue-05: #10336f;
$blue-06: #113a7c;
$blue-07: #12408a;
$blue-08: #144798;
$blue-09: #164da6;
$blue-10: #1854b4;
$blue-11: #1a5bc3;
$blue-12: #1c62d2;
$blue-13: #1f69e1;
$blue-14: #2270f0;
$blue-15: #2677ff;

# Override any carbon variables you would like
$carbon--theme: map-merge(
	$carbon--theme--g10,
	(
		interactive-01: $blue-08,
		interactive-03: $blue-08,
		interactive-04: $blue-10,
		focus: $blue-08,
		hover-primary: $blue-14,
		hover-primary-text: $blue-06,
		hover-tertiary: $blue-08,
		active-primary: $blue-05,
		highlight: $blue-14,
		button-primary: $blue-08,
		button-tertiary: $blue-09,
		button-primary-active: $blue-07,
		button-tertiary-active: $blue-07,
		link-primary-hover: $blue-08,
		button-primary-hover: $blue-10,
		button-tertiary-hover: $blue-11,
		interactive: $blue-08,
		border-interactive: $blue-08
	)
);
@include carbon--theme();

@import 'carbon-components/scss/globals/scss/_css--reset';
@import 'carbon-components/scss/globals/scss/_css--font-face';
@import 'carbon-components/scss/globals/scss/_css--helpers';
@import 'carbon-components/scss/globals/scss/_css--body';
@import 'carbon-components/scss/globals/grid/grid';

// Import all component styles
@import 'carbon-components/scss/globals/scss/styles';

:root {
	@include carbon--theme($carbon--theme, true) {
		@include emit-component-tokens($tag-colors);
	}
}

And then you can use a script like /scripts/build-css in this repository to build the scss to css. I have a slightly modified script so if you have issues let me know.


WV-490 Implement speed testing template [TEAM-REVIEW]

imported urllib to encode the performance_process_dict.

encoded candidate_edit_process_view and was able to decode and display data to the candidate edit page.

refactored the timeDifference code to cut down on code bloat.

Remaining Tasks:

[x] - still need to add more snapshots within candidate_edit method as well as the candidate_edit_process_view.

[x] - Code cleanup and code comments.

[x] - time difference refactor.

Thank you Paolo! 👍


#6553 fixed radio button on easyfrom

Radio buttons values were indentified incorrectly by index

unit tests fail!


support "type x" with no relations

Support types with no relations, for example:
type car

type truck
   relations
      ...

References

Previous similar work but with syntax relations none: https://github.com/openfga/syntax-transformer/pull/47

Review Checklist

[ ] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

Superseded by https://github.com/openfga/syntax-transformer/pull/52


Updated nuget packages

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: azure-health-data-services-toolkit-fhir-function-quickstart
Remote: azure-samples-staging
Branch: pr/105
You can initialize this project with:
azd init -t Azure-Samples/azure-health-data-services-toolkit-fhir-function-quickstart -b pr/105

View Changes | Compare Changes


[formal] Opentitan FPV using Symbiyosys

This is a tracking bug. Comment if you have suggestions or updates
Symbiyosys  currently support limited functionalities for FPV methodology.
Yosys
Symbiyosys uses Yosys to synthesize SV. Current list of unsupported Yosys syntax is listed in the link here.

[ ] Use util/syn_yosys.sh to convert SV file to Verilog.

Symbiyosys
Symbiyosys has been adding supports for FPV related syntax.
Here are the list of supported syntax
Still exploring:

[ ] Symbolic variable
[ ] Code and COI coverages
[ ] Import a filelist in .sby file

Note that https://symbiyosys.readthedocs.io/en/latest/verific.html#supported-sva-property-syntax is talking about the Verific bindings, which are not part of the open source offering. I'm not sure what syntax is supported without Verific, the documentation is slightly confusing to me in that respect.

Hi Phillip,
Thank you for pointing this out. I did not realize that Verific is not part of the OpenSource. Here are some discussion about Symbiyosys support SV in Verific. Link
I tried locally and i do not think SymbiYosys without Verific can support bind.
This is definitely a limitation, but can potentially use it to test assertions written within the RTL file.


chore(gendocs): add npm run gendocs command

Now you can generate documentation by running npm run gendocs. Once this is merged, we can add this as a step to the contributing guidelines along the lines of:

Before committing:

Run npm test to make sure tests & linting pass
Run npm run gendocs to make sure docs are up to date

Is travis-only failing?

LGTM


ignore everything

Reasons for making this change:
Someone like me may want to control all content that indexed.
Force all indexed content meaningfully.

This is cool and all, but I'd rather focus on supporting the existing ecosystem of languages and tools.

@shiftkey, is there any way to use private .gitignore templates in GitHub.

@was4444 I don't understand the question. Could you elaborate?

@shiftkey, the question probably should not be asked here, but when create a new repo from GitHub, we can select a .gitignore, which seems must in this repo, to create as the initial commit. I just want to use my private .gitignore file as the initial commit.


UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb5 in position 1: invalid start byte

i have set up the environmet succesfully, but when i run lm_eval --model mamba_ssm --model_args pretrained=state-spaces/mamba-130m --tasks lambada_openai,hellaswag,piqa,arc_easy,arc_challenge,winogrande,openbookqa --device cuda --batch_size 256 i got error as

2024-09-26:16:41:09,923 INFO     [main.py:251] Verbosity set to INFO
2024-09-26:16:41:11,912 INFO     [main.py:335] Selected Tasks: ['arc_challenge', 'arc_easy', 'hellaswag', 'lambada_openai', 'openbookqa', 'piqa', 'winogrande']
2024-09-26:16:41:11,912 INFO     [main.py:336] Loading selected tasks...
2024-09-26:16:41:11,912 INFO     [evaluator.py:131] Setting random seed to 0 | Setting numpy seed to 1234 | Setting torch manual seed to 1234
2024-09-26:16:41:12,409 INFO     [huggingface.py:162] Using device 'cuda'
/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/mamba_ssm/ops/selective_scan_interface.py:164: FutureWarning: torch.cuda.amp.custom_fwd(args...) is deprecated. Please use torch.amp.custom_fwd(args..., device_type='cuda') instead.
def forward(ctx, xz, conv1d_weight, conv1d_bias, x_proj_weight, delta_proj_weight,
/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/mamba_ssm/ops/selective_scan_interface.py:240: FutureWarning: torch.cuda.amp.custom_bwd(args...) is deprecated. Please use torch.amp.custom_bwd(args..., device_type='cuda') instead.
def backward(ctx, dout):
/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/mamba_ssm/ops/triton/layer_norm.py:986: FutureWarning: torch.cuda.amp.custom_fwd(args...) is deprecated. Please use torch.amp.custom_fwd(args..., device_type='cuda') instead.
def forward(
/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/mamba_ssm/ops/triton/layer_norm.py:1045: FutureWarning: torch.cuda.amp.custom_bwd(args...) is deprecated. Please use torch.amp.custom_bwd(args..., device_type='cuda') instead.
def backward(ctx, dout, *args):
/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/mamba_ssm/distributed/tensor_parallel.py:26: FutureWarning: torch.cuda.amp.custom_fwd(args...) is deprecated. Please use torch.amp.custom_fwd(args..., device_type='cuda') instead.
def forward(ctx, x, weight, bias, process_group=None, sequence_parallel=True):
/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/mamba_ssm/distributed/tensor_parallel.py:62: FutureWarning: torch.cuda.amp.custom_bwd(args...) is deprecated. Please use torch.amp.custom_bwd(args..., device_type='cuda') instead.
def backward(ctx, grad_output):
/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/mamba_ssm/ops/triton/ssd_combined.py:758: FutureWarning: torch.cuda.amp.custom_fwd(args...) is deprecated. Please use torch.amp.custom_fwd(args..., device_type='cuda') instead.
def forward(ctx, zxbcdt, conv1d_weight, conv1d_bias, dt_bias, A, D, chunk_size, initial_states=None, seq_idx=None, dt_limit=(0.0, float("inf")), return_final_states=False, activation="silu",
/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/mamba_ssm/ops/triton/ssd_combined.py:836: FutureWarning: torch.cuda.amp.custom_bwd(args...) is deprecated. Please use torch.amp.custom_bwd(args..., device_type='cuda') instead.
def backward(ctx, dout, *args):
2024-09-26:16:41:12,966 INFO     [huggingface.py:414] Overrode HF model backend type, and using type 'causal'
/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/mamba_ssm/utils/hf.py:18: FutureWarning: You are using torch.load with weights_only=False (the current default value), which uses the default pickle module implicitly. It is possible to construct malicious pickle data which will execute arbitrary code during unpickling (See https://github.com/pytorch/pytorch/blob/main/SECURITY.md#untrusted-models for more details). In a future release, the default value for weights_only will be flipped to True. This limits the functions that could be executed during unpickling. Arbitrary objects will no longer be allowed to be loaded via this mode unless they are explicitly allowlisted by the user via torch.serialization.add_safe_globals. We recommend you start setting weights_only=True for any use case where you don't have full control of the loaded file. Please open an issue on GitHub for any issues related to this experimental feature.
return torch.load(resolved_archive_file, map_location=mapped_device)
/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/transformers/tokenization_utils_base.py:1601: FutureWarning: clean_up_tokenization_spaces was not set. It will be set to True by default. This behavior will be depracted in transformers v4.45, and will be then set to False by default. For more details check this issue: https://github.com/huggingface/transformers/issues/31884
warnings.warn(
Traceback (most recent call last):
File "/media/8T3/rh_xu/.conda/envs/mamba/bin/lm_eval", line 8, in
sys.exit(cli_evaluate())
File "/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/lm_eval/main.py", line 342, in cli_evaluate
results = evaluator.simple_evaluate(
File "/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/lm_eval/utils.py", line 288, in _wrapper
return fn(*args, **kwargs)
File "/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/lm_eval/evaluator.py", line 192, in simple_evaluate
task_dict = get_task_dict(tasks, task_manager)
File "/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/lm_eval/tasks/init.py", line 420, in get_task_dict
task_name_from_string_dict = task_manager.load_task_or_group(
File "/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/lm_eval/tasks/init.py", line 270, in load_task_or_group
collections.ChainMap(*map(self._load_individual_task_or_group, task_list))
File "/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/lm_eval/tasks/init.py", line 161, in _load_individual_task_or_group
return load_task(task_config, task=name_or_config, group=parent_name)
File "/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/lm_eval/tasks/init.py", line 150, in load_task
task_object = ConfigurableTask(config=config)
File "/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/lm_eval/api/task.py", line 782, in init
self.download(self.config.dataset_kwargs)
File "/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/lm_eval/api/task.py", line 871, in download
self.dataset = datasets.load_dataset(
File "/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/datasets/load.py", line 2074, in load_dataset
builder_instance = load_dataset_builder(
File "/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/datasets/load.py", line 1795, in load_dataset_builder
dataset_module = dataset_module_factory(
File "/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/datasets/load.py", line 1671, in dataset_module_factory
raise e1 from None
File "/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/site-packages/datasets/load.py", line 1617, in dataset_module_factory
can_load_config_from_parquet_export = "DEFAULT_CONFIG_NAME" not in f.read()
File "/media/8T3/rh_xu/.conda/envs/mamba/lib/python3.10/codecs.py", line 322, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb5 in position 1: invalid start byte

could you please give a solution? the version of some packages are torch==2.4.1, cuda==12.1, lm-eval==0.4.2, datasets==3.0.0

make

mark

mark


Analysis: Can we change default data format to JSON? And if so, how?

Description
Today the app data is stored as XML in Storage. To reduce the amount of data store, and to make life simpler for app developers, we need to change the default storage format to JSON.
Default to XML if config is not set, but set JSON as default in config in app template.
Considerations
Input (beyond tasks) on how the user story should be solved can be put here.
Can we handle change of data format for already deployed app?
Acceptance criteria

Data is stored in Storage as JSON as default
It is possible to change at dataElementType level to set different formats.

Development tasks

[ ] Task 1
[ ] Task 2
etc

Definition of done
Verify that this issue meets DoD (Only for project members) before closing.

[ ] Documentation (if relevant)
[ ] Manual test (if needed)
[ ] Automated test (if needed)
[ ] QA
[ ] Test
[ ] All tasks in this userstory are closed (i.e. remaining tasks are moved to other user stories or marked obsolete)

I had this in mind when doing the rewrite for multiple data models. We store the mime type on data elements, and the allowedContentTypes on the data type, so the only change would be to respect if the first allowed content type would be application/json when creating data elements.


chore: release v1.1.4

Codecov Report
Base: 83.55% // Head: 83.55% // No change to project coverage :thumbsup:

Coverage data is based on head (6321db1) compared to base (38774f5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   83.55%   83.55%
=======================================
  Files          32       32
  Lines         961      961
  Branches      210      210
=======================================
  Hits          803      803
  Misses        157      157
  Partials        1        1

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Cherry-pick PR #8247 into release-1.2: ci: pin the azcopy version used for the transaction reply job

This cherry-pick was triggerd by a request on #8247
Please review the diff to ensure there are not any unexpected changes.
cc @sausagee

Justification and breaking nature (who does it affect? validators, full nodes, tooling, operators, AOS, etc.)

This is not a breaking change in mainnet.  The chagne affects the tooling used in backup & restore.

Comprehensive test results that demonstrate the fix working and not breaking existing workflows.

Test result in #8247

Why we must have it for V1 launch.

There is an issue with SAS in Azure storage azcopy v10.10.0, which broke the backup & restore tooling (diem/tools container) and workflow.  This change will pin the azcopy to a previous known working version in subsequent diem/tools container built from the release branch.

What workarounds and alternative we have if we do not push the PR.

The alternative is to use specific version of diem/tools in deployment, which would require node operators to keep track of different versions between tools and validators.


Unpacking file size is incorrect (with reproduced repo)

And here is the reproduced repo: https://github.com/axetroy/libflate-66
git clone https://github.com/axetroy/libflate-66
cd ./libflate-66
cargo run ./

# View unpacked files ’prune‘

The origin file size is : 985,384
The unzip file size is : 965,416

unpack with Tar

size = 965,416

unpack with python3

size = 985,384
>>> import tarfile
>>> tar = tarfile.open("prune_darwin_amd64.tar")
>>> tar.getmember("prune").size
985384

unpack with build-in tar tools in macOS

size = 985,384
ref: https://github.com/sile/libflate/issues/66

Before resolving this, I decompressed executable files that have lost some information and cannot be executed.
And my temporary solution:
Priority use the TAR command in the system to decompress

I think #298 will fix this.


The Risk Assessment tool should have an informative results page

The score-based risk increase should be clearer. From @mrueschman

Yes, clarifying the message would be good. Based on the StopBang.ca summary (http://www.stopbang.ca/osa.php -- assuming refs are legit), I think the language would be something more like: “Your risk of having obstructive apnea is 600% higher than a person having a score between 0-2.”
I would distill it down to something even simpler because I don’t think reporting a 2.5 – 7x “fold” increase is going to be all that impactful. Sounds like Emily/Dan might come up with this.

@ekontos @DanMobley Thoughts on better ways to give feedback about risk? Current tool here: https://sleepepi.partners.org/edge/www.myapnea.org/sleep-apnea-risk-assessment


Fix CVE 2023 48795

Fixes the failing trivy scan on the release-1.13 branch by upgrading golang.org/x/crypto from v0.14.0 to v0.17.0.

https://testgrid.k8s.io/cert-manager-periodics-release-1.13#ci-cert-manager-release-1.13-trivy-test-controller
https://access.redhat.com/security/cve/CVE-2023-48795

You can also see these failures on ArtifactHub:

https://artifacthub.io/packages/helm/cert-manager/cert-manager?modal=security-report

I ran the following commands:
make vendor-go
export PATH="$PWD/_bin/tools:$PATH"
export GOROOT="$PWD/_bin/tools/goroot"
find . -type f -name 'go.mod' -not -path './_bin/*' -printf '%h\n' \n
  | sort \
  | while read d; do (cd $d; go get golang.org/x/crypto@v0.17.0); done
make tidy
make update-licenses

/kind cleanup
Fix CVE 2023 48795 by upgrading to<EMAIL_ADDRESS>

/retest

/approve
/lgtm


chore: finish migration to bzlmod

bump bazel to 6.4.0
bump rules_go, gazelle, platforms
enable bzlmod
clear WORKSPACE (cannot remove yet due to examples)
remove gofmt, #136
remove Go MacOS x86_64 tests, #10

superseded by #135


Offer's slug doesn't support unicode

I gotten error when I visited offers page.
I'm use Arabic language.

I fixed that by edit offer detail path from:
'python
path("slug:slug/", self.detail_view.as_view(), name="detail"),
'
To:
'python
path("str:slug/", self.detail_view.as_view(), name="detail"),
'

You can make this work by configuring the following setting:
OSCAR_SLUG_ALLOW_UNICODE = True

You can make this work by configuring the following setting:

OSCAR_SLUG_ALLOW_UNICODE = True

That fixed here: https://github.com/django-oscar/django-oscar/pull/1995
Hmm I think your issue is a bit different.

It's work only with product slug


feat: install dependencies through the generator

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x] No

Checklist

[ ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information
I added a prompt asking the user if they want to install the dependencies immediately without running a command to install them.

I found it useful to install the dependencies immediately to save time because either the generator gives it or you do it anyway someone has to do it. Anyway, I'll make the changes as soon as possible

Changes made as requested, I hope they go well

I found it useful to install the dependencies immediately to save time because either the generator gives it or you do it anyway someone has to do it. Anyway, I'll make the changes as soon as possible

I agree it is useful but I don't really want to sacrifice bootstrapping speed for it so I think we should take the community feedback before enabling it by default.

I will make the changes, unfortunately I'm not at home and can't make them in a short time. Essentially I'd rather close the pull request, because actually installing the dependencies isn't necessary to do right away


Audio and Video experiment types

Add support and documentation for different types of multimedia

Include embedding for these media types

Add audio support for other app beside poolbasedtriplets

Is this possible? Or necessary?


update token handling logic

WIP.

For related comments, please see: https://github.com/fastapi-practices/fastapi_best_architecture/discussions/44#discussioncomment-6032750

Hi, @downdawn
Now it is ready for review.

Hi, @wu-clan
Please refer to the comment above.

Hi, @wu-clan Please refer to the comment above.

The token processing logic there is controlled by the front end and should not be implemented in the back end, which is only responsible for the interface

Or did I miss your point?

Or did I miss your point?

The refresh token is not controlled by the front end, so it is not safe. unless there is a special need

As discussed here, the first login returns the token and the refresh token, and the subsequent front-end can generate a new token based on the refresh token. We only need to provide an interface for generating a new token.
#44

Yes, but it already exists in this PR.

Ok, we can merge this pr first, and make adjustments later

Now it's ready


x/pkgsite: module version in pkg.go.dev still hasn't updated almost a year after github version update

What is the URL of the page with the issue?
https://pkg.go.dev/github.com/natemcintosh/gocombinatorics
What is your user agent?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:108.0) Gecko/20100101 Firefox/108.0
Screenshot

What did you do?
On January 11, 2022, I released version 0.3.1 of a module on github. I then tried all three methods listed under adding a package to get it to update on the pkg site, but to no avail.
What did you expect to see?
That the version number and updated information for v0.3.1 on the pkg site
What did you see instead?
Still on v0.2.0 after almost a year.

My theory is pkgsite attempted to process this module while running go1.18beta2 and it failed. From the logs we know that parsing the packages failed but we can't see why, unfortunately it just says the module contained no packages. Submitted those versions for reprocessing and now they're live on the site. I haven't seen any similar reports but we could consider reprocessing additional packages if it comes up again.

Thank you so much! I really appreciate your help


[Android] makeImageFromView does not respect scroll on Android

Description
I am trying to create a screen overlay that is displayed when the user puts the app in the background. The overlay should be a blurred screenshot of the current app screen layout. While everything works fine on iOS, I am encountering a problem on Android. The issue arises when the screen contains a ScrollView and I use makeImageFromView to capture a screenshot. On Android, it always captures the top of the ScrollView, even if it is scrolled.
Expected Behavior
makeImageFromView function should capture the currently visible part of the ScrollView on Android, similar to how it works on iOS.
Current Behavior
On Android, the captured screenshot always shows the top of the ScrollView, even if it is scrolled.
Version
0.1.236
Steps to reproduce

Create an app with a ScrollView that contains a long content.
Scroll down.
Take screenshot with makeImageFromView.
Check that the captured screenshot does not represent currently visible part of the screen.

Code example:
import { ScrollView, StyleSheet, View, Button } from 'react-native';
import { Canvas, makeImageFromView, SkImage, Image } from '@shopify/react-native-skia';

export default function App() {
  // Create a ref for the view you'd like to take a snapshot of
  const ref = useRef<View>(null);
  // Create a state variable to store the snapshot
  const [image, setImage] = useState<SkImage | null>(null);
  // Create a function to take the snapshot
  const onPress = async () => {
      // Take the snapshot of the view
      const snapshot = await makeImageFromView(ref);
      setImage(snapshot);
  };

  return (
    <>
      <ScrollView style={{ flex: 1 }} ref={ref}>
          <View>
              <View
                  style={{
                      backgroundColor: 'cyan',
                      flex: 1,
                      minHeight: 200,
                      borderWidth: 5,
                  }}
              />
              <View
                  style={{
                      backgroundColor: 'red',
                      flex: 1,
                      minHeight: 500,
                      borderWidth: 5,
                  }}
              />
              <View
                  style={{
                      backgroundColor: 'green',
                      flex: 1,
                      minHeight: 1000,
                      borderWidth: 5,
                  }}
              />
          </View>
      </ScrollView>
      <Button title="Take screenshot" onPress={onPress} />
      {image && (
          <Canvas style={StyleSheet.absoluteFill}>
              <Image
                  image={image}
                  x={0}
                  y={0}
                  width={image.width() / 2 / pd}
                  height={image.height() / 2 / pd}
              />
          </Canvas>
      )}
  </>
  );
}

Demo
https://github.com/Shopify/react-native-skia/assets/26143964/ac9603ce-ce0d-4861-80ec-688bf3cedce8

this is fixed :) and will ship this week
Thanks again @Nodonisko


Improve storing of data for DataColumn and DataTable

Currently, we keep track of data in 2 places. The dataframe in the DataTable, and the series in the DataColumn.
This is certainly not ideal, we should find a better solution. Our current situation requires us to do some user hand holding, and make sure that changes on the DataTable are matched with the DataColumn (ex - remove a column from DataTable means taking it out from the dataframe, and removing it from the column dictionary (consisting of DataColumns).

Option 1

One way to resolve this is to keep the dataframe on the DataTable but remove the series being stored on the DataColumn.
The DataColumn would keep track of only the metadata (logical types, semantic tags, etc) associated with that column.
If a user requested a specific column datatable['total'], Woodwork could create a DataColumn with a series (but this DataColumn would have no knowledge of the DataTable).
Updates to the data would only happen on the dataframe on the DataTable

Option 2

Another solution was to have the DataColumn contain the DataTable that it is a part of. The data of the DataColumn would be referenced by looking at the dataframe of the DataTable.
Updates to the data would only happen on the dataframe on the DataTable

Closing. Will be addressed by #483


Ask

Does this work for 1.7.10/1.7.9
And if it does is it possible to set it to a players faction name, balance and the server IP?

Yes, it does work for 1.7 - but, you'd have to sacrifice the length of your scoreboard. There will also be no support for 1.7 issues as SpigotBoard is not meant for any version lower than 1.8.
Variables are limited by PlaceholderAPI for the time being.

So would I be able to put the faction name, their balance and the server Ip in then?

Also the scoreboard isn't showing


Integration tests of olric-cli package fails due to wrong configuration

As the title explains, the tests are constantly failing. The solution is the following:
mc := memberlist.DefaultLocalConfig()
mc.BindPort = 0
...
cfg.MemberlistConfig =  mc

Done d1b48234ed1881bca39664bd4cf0390bc9e72020


Pass query string after stripping route prefix [fusion-cli]

I was attempting to pass a query string param to a fusion app that uses a route prefix, and the app throws an exception.

Heres the stack trace
      TypeError: Cannot read property 'match' of null
      at ctx (/route/to/my-fusion-app/node_modules/fusion-core/src/plugins/ssr.js:28:20)
      at bodyAttrs (/route/to/my-fusion-app/node_modules/fusion-core/src/plugins/ssr.js:59:7)
      at err (/route/to/my-fusion-app/node_modules/fusion-core/src/compose.js:39:16)
      at Promise (/route/to/my-fusion-app/node_modules/fusion-core/src/compose.js:40:16)
      at middleware (/route/to/my-fusion-app/node_modules/fusion-core/dist/index.js:748:10)
      at err (/route/to/my-fusion-app/node_modules/fusion-core/src/compose.js:39:16)
      at Promise (/route/to/my-fusion-app/node_modules/fusion-core/src/compose.js:40:16)
      at middleware$1 (/route/to/my-fusion-app/node_modules/fusion-core/src/server-app.js:1:1)
      at err (/route/to/my-fusion-app/node_modules/fusion-core/src/compose.js:39:16)
      at Promise (/route/to/my-fusion-app/node_modules/fusion-core/src/compose.js:40:16)

To reproduce:
$ yarn create fusion-app my-fusion-app
$ cd my-fusion-app
$ ROUTE_PREFIX="/test" yarn dev

and navigate to localhost:3000/test?a=b.
When stripping out the route prefix, strip-prefix would make sure the route had a / only if the prefix was the entire req.url. This change will make sure that the / gets added back if the url has a prefix followed directly by a query string

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This change seems reasonable to me.  Want to get a second pair of eyes before I land it though.
Ping @rtsao and @micburks

!merge


testDistributesSpillOverPathsBadDisk fails when running as Root

When attempting to build Presto running as root TestFileSingleStreamSpillerFactory#testDistributesSpillOverPathsBadDisk fails. Since the process is running as root, it ignores the file permissions that the test depends on and writes to the directory that is set as read-only.

Thanks for reporting this, and with a good explanation!
Unfortunately, I don't know off hand how this can be fixed and at the same time, it seems an easy workaround exists (do not run tests as root user).
Do you have any suggestions?

No obviously solution sticks out to me either.
@shrijeet @dfinninger Looking through Github history it looks like you contributed these changes originally. I'm curious if you have any ideas?

@csunwold are you running tests in a docker container?

@findepi Yes.

@csunwold would it help if you add -u a_user to your docker run command?
(picking a_user depending on the base image you use, eg ubuntu user in ubuntu image)

@csunwold few options other than the workaround @findepi suggested

Find a more deterministic way to simulate disk failure, I looked into changing the mutability of the file object but didn't find any java api in my quick search

Use mocking, my recollection is that presto doesn't have dependency on a mock library yet. Also its not clear if its straightforward to inject a mock instance in this code path

@csunwold i think the conclusion for now would be: let's not run the test as root
I am going to close the issue, as we do not plan to change this limitation, so keeping it open doesn't help.
We can continue discussion here and -- specially if we find a good proposed solution -- we can reopen if needed.


HSEARCH-2945 Configure default mass indexing logging monitor

https://hibernate.atlassian.net/browse/HSEARCH-2945
I've tried a few approaches, and it seems that having a "dedicated" method to configure the default monitor looks better than others...
Having more options on the mass indexer itself may work for a config like "don't do counts at all" but not for the "count the entities before indexing starts.
Let me know if you have any other ideas we could try. Opening as a draft for now as some more tests are needed and the impl of the monitor should be cleaned up a bit.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

It's a shame that this will only work with the default monitor, no? :thinking:

Having more options on the mass indexer itself may work for a config like "don't do counts at all"

Ok.

but not for the "count the entities before indexing starts.

Why?

Regarding the solution... In order to make it work with the default monitor, but also custom ones, we could imagine allowing the monitor itself to influence the behavior? I.e.:
class MyMonitor1 implements MassIndexingMonitor {

    void initialize(MassIndexingMonitorContext context) {
        context.countOnStart(this::onCount); // Callback called immediately
    }

    void onCount(EntityTypeReference type, long count) {
         // ...
    }
}
class MyMonitor2 implements MassIndexingMonitor {

    void initialize(MassIndexingMonitorContext context) {
        context.countBeforeTypeStart(this::onCount); // Callback called later
    }

    void onCount(EntityTypeReference type, long count) {
         // ...
    }
}
class MyMonitor2 implements MassIndexingMonitor {

    void initialize(MassIndexingMonitorContext context) {
        context.countOnStartAndBeforeTypeStart(this::onCount, this::onCountAdjustment); // First callback called now, secont callback called later
    }

    void onCount(EntityTypeReference type, long count) {
         // ...
    }
    void onCountAdjustment(EntityTypeReference type, long initialCount, long updatedCount) {
         // ...
    }
}

I'm not suggesting this exact API -- names are bad, in particular -- but you get the idea.
Then making it work with the default monitor would be a matter of exposing that monitor -- e.g.:
massIndexer.monitor(DefaultMassIndexingMonitor.builder().countOnStart(true));
// OR
massIndexer.monitor(DefaultMassIndexingMonitor.builder().countOnBeforeType(true));
// OR ...

Ok.

but not for the "count the entities before indexing starts.

Why?

well ... the call to get the total count is currently made by mass indexer itself, and the value is passed to the monitor (no matter what the impl of that monitor is, right). So if we config this at the mass indexer level it makes sense to allow disable the count call for both the built-in one and custom ones.
Now this "new thing" to get the counts before anything even starts and have an approximation that may get adjusted later is something that would be specific to our own monitor implementation. I didn't think that we'd want to call it from the mass indxer and pass the values around to custom monitor implementations... That was the reason why I was thinking that exposing this other property (to do the count-all-before-things-start) won't work ....
what you wrote made me think ... we have this in the type group monitor now:
https://github.com/hibernate/hibernate-search/blob/684ba49771e82db07b4504da349b5bfa8a341436/mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/massindexing/MassIndexingTypeGroupMonitor.java#L43-L48
what if instead of the total count or nothing, we pass the context that exposes some access to the loading strategy ( that can do the counting) through a context class and have something like:
public interface MassIndexingTypeGroupMonitor {
	void documentsAdded(long increment);

	// gets called when we create a workspace for the type group
	// so essentially can be used by us to do the counts before the indexing starts
	void typeGroupInitialized(SomeContext context);

	// gets called when the identifier loading runnable starts:
	void indexingStarted(SomeContext context);

	// gets called when all indexing runnables for the group are completed.
	void indexingCompleted(SomeContext context);
}

then in the main mass indexing monitor we drop deprecate the addToTotalCount method with MassIndexingTypeGroupMonitor#indexingStarted being it's replacement ?

Your suggestion makes sense to me.
This is starting to get complex though, so I'd suggest:

Being careful about naming, to make things extra clear. documentsAdded => documentsIndexed would make sense I think, and typeGroupInitialized => initialize() (since it's about initializing the monitor itself, more than anything else) or indexingPlanned(), if you want to keep it event-like? IDK.
Not forgetting about providing ways to configure the default monitor -- see my suggestion above.
Making it obvious that counting may, in some cases, not return anything -- because the loading strategy may not support it. Using Optional in APIs would make sense I think.
Deprecating all methods in the main monitor that duplicate what you're doing -- documentsBuilt, documentsIndexed, etc.
Making sure that existing implementations (implementing deprecated methods) still work -- we'll need tests for that.

@yrodiere let me know if you'd want to have a look at this one 😉

Seems you still need to add something to the migration guide?


Output contains unnecessary messages triggered by already-reported problems

When font is missing a character needed for a particular language, one output message is sufficient. Subsequent tests that depend on that character needn't be run.
Example:
Font does not fully support language 'ur_Arab'
 * FAIL: Some base glyphs were missing: ٹ, چ, ڈ, ڑ, ھ, ہ
 * FAIL: Shaper produced a .notdef
 * FAIL: .fina version of ARABIC LETTER TTEH; both buffers returned .notdef=1+1033|space=0+0
 * FAIL: .medi version of ARABIC LETTER TTEH; both buffers returned space=1+0|.notdef=1+1033|space=0+0
 * FAIL: .init version of ARABIC LETTER TTEH; both buffers returned space=0+0|.notdef=0+1033
 * FAIL: .fina version of ARABIC LETTER TCHEH; both buffers returned .notdef=1+1033|space=0+0
 * FAIL: .medi version of ARABIC LETTER TCHEH; both buffers returned space=1+0|.notdef=1+1033|space=0+0
 * FAIL: .init version of ARABIC LETTER TCHEH; both buffers returned space=0+0|.notdef=0+1033
 * FAIL: .fina version of ARABIC LETTER DDAL; both buffers returned .notdef=1+1033|space=0+0
 * FAIL: .fina version of ARABIC LETTER RREH; both buffers returned .notdef=1+1033|space=0+0
 * FAIL: .fina version of ARABIC LETTER HEH GOAL; both buffers returned .notdef=1+1033|space=0+0
 * FAIL: .medi version of ARABIC LETTER HEH GOAL; both buffers returned space=1+0|.notdef=1+1033|space=0+0
 * FAIL: .init version of ARABIC LETTER HEH GOAL; both buffers returned space=0+0|.notdef=0+1033
 * FAIL: .fina version of ARABIC LETTER HEH DOACHASHMEE; both buffers returned .notdef=1+1033|space=0+0
 * FAIL: .medi version of ARABIC LETTER HEH DOACHASHMEE; both buffers returned space=1+0|.notdef=1+1033|space=0+0
 * FAIL: .init version of ARABIC LETTER HEH DOACHASHMEE; both buffers returned space=0+0|.notdef=0+1033

Only the first Fail is needed — all the rest are redundant.
Test info:
Command: shaperglot check Alkalami-Regular.ttf ur_Arab
Font download: https://software.sil.org/alkalami/download/
System info:
Python 3.10.12
shaperglot: 0.5.0
Ubuntu: 22:04
Replaces fonttools/fontbakery#4654

For fa_Arab I get other kinds of messages related to previously reported missing base chars:
Font does not fully support language 'fa_Arab'
 * FAIL: Some base glyphs were missing: چ
 * FAIL: Shaper produced a .notdef
 * FAIL: .fina version of ARABIC LETTER TCHEH; both buffers returned .notdef=1+1033|space=0+0
 * FAIL: Shaper didn't attach uni064B to None
 * FAIL: Shaper produced a .notdef
 * FAIL: Shaper didn't attach uni064D to None
 * FAIL: Shaper produced a .notdef
 * FAIL: Shaper didn't attach uni064C to None
 * FAIL: Shaper produced a .notdef
 * FAIL: Shaper didn't attach uni0651 to None
 * FAIL: Shaper produced a .notdef
 * FAIL: Shaper didn't attach uni0654 to None
 * FAIL: Shaper produced a .notdef
...

Thanks for re-filing this here; I'll work on it.