Godot Snap distribution can't export to Android

Godot version:

Godot v3.0.6
OS/device including version:

Ubuntu v18.04.01
OpenJDK 8
Issue description:

The snap store Godot version by using Godot file explorer can't access the root folder therefore you can't access the "jarsigner" file. If you enter the path by hand it still says "OpenJDK 6 jarsigner not configured in editor settings".
The quick fix is to download the Godot from official website because that version has an access to the root folder. But it has no icon and you can't add it to favourites bar :(
P.S. I was trying to solve an issue but didn't fount the solution anywhere. The closest one was with Godot v3.0.5 suggesting to solve by installing 3.0.6 version and OpenJDK 8, but I've already had proper versions.
Steps to reproduce:
Install OpenJDK 8 > Install Godot > Try to set jarsigner path> in export options check if there is  "OpenJDK 6 jarsigner not configured in editor settings" error message.
Minimal reproduction project:

Install OpenJDK 8 > Install Godot > Try to set jarsigner path> in export options check if there is  "OpenJDK 6 jarsigner not configured in editor settings" error message.

Godot needs access to /usr/bin/jarsigner if you want to use a system-installed OpenJDK, so you should report this to the Snap package maintainers. If the snap prevents you access to /usr but still exposes jarsigner in the PATH, you could try to set only jarsigner as path for the option.

I'm not sure what's the proper location to report issues with a given snap in the snapcraft ecosystem. CC @popey who did the original Godot snap: https://forum.snapcraft.io/t/godot-engine-call-for-testing/4997

@popey I guess we need your help to provide the file system access of your snaps. Can you set classic confinement for it?

The snap is just unusable right now

Thanks for the ping @michaellee8. Sorry it's not working as you'd expect, I'll take a look!

@popey it seems that there are no such permission to access /usr/lib for a snap, I tried devmode but I still didn't work, maybe you can try with classic confinement?

To provide some context on what system access Godot needs:

To export to Android, we need OpenJDK (or Oracle JDK)'s jarsigner, as well as adb (either from the SDK or standalone packaged version). So users need to be able to access /usr/bin/jarsigner and /usr/bin/adb (they provide the path themselves in EditorSettings), or any arbitrary path where they might have those installed (e.g. /home/foo/Dev/android-sdk/platform-tools/adb).
To export to Windows, users can optionally use rcedit.exe that they download themselves, and which, being a Windows application, needs Wine on Linux. So they'd need access to /usr/bin/wine and also the possibility to access a random, user-readable path (e.g. /home/foo/Dev/rcedit.exe). This is not a mandatory feature (it's used to embed the game icon and PE metadata in the .exe), but would be nice to have when using the snap too.

I'm experiencing this issue as well - I have both jarsigner and adb installed to /usr/bin/ and can access both from the command line. Unfortunately, even when I manually put the paths into the editor settings Godot doesn't see the files and therefore won't permit exporting to Android.

This should now be fixed with the newer releases. We switched to classic confinement, so you'll need to snap refresh godot --classic --stable to get the new update as the Snap Store don't allow you to go from strict to classic without explicitly specifying.

Late to the party, but had the same issue. the --classic --stable version solves the issue.

@Elyukeyey Thanks for confirming it :slightly_smiling_face:
I'll close this issue, as it's not related to an official Godot distribution. Please report Snap-related issues on https://forum.snapcraft.io/t/godot-engine-call-for-testing/4997.


Emotes didn't load

Emotes do not always load. Sometimes they work, sometimes they don’t. There may be a problem connecting to the API services. This photo shows the problems. Also, bttv emotes have broken animation.

But the logs say that the download was successful, and no errors are given
Logs:
[00:17:11] [Render thread/INFO]: Registered 14 emotes from provider net.vinrobot.mcemote.client.providers.FFZGlobalEmoteProvider
[00:17:12] [Render thread/INFO]: Registered 64 emotes from provider net.vinrobot.mcemote.client.providers.BTTVGlobalEmoteProvider
[00:17:12] [Render thread/INFO]: Registered 618 emotes from provider net.vinrobot.mcemote.client.providers.STVUserEmoteProvider
[00:17:13] [Render thread/INFO]: Registered 24 emotes from provider net.vinrobot.mcemote.client.providers.FFZRoomEmoteProvider
[00:17:13] [Render thread/INFO]: Registered 30 emotes from provider net.vinrobot.mcemote.client.providers.BTTVUserEmoteProvider

BTTV emotes animation bug:
https://skr.sh/vORw537g0Sb
I can send you the full log file if needed

This problem appeared not only today and not only for me. She's probably a few weeks old already

twitch id: 541457147
emote name: peepoChat https://betterttv.com/emotes/6086df3539b5010444d069b3

I have the same problem (emoji from the channel 99899949 are not uploaded either).


Google login not working

Issue
When logging in to Notion via Google, the application fails to continue login after it has been handled by the browser.
Details
Expected behaviour
When clicking 'Continue with Google' during login, the application opens a browser for authentication, I can select / sign in to my Google account, then Notion will redirect to a link which is handled by the app, logging me in to my Notion account in the app.
Experienced Behaviour
When clicking 'Continue with Google' during login, the application opens a browser and I am able to authenticate my account. Once authenticated, Notion redirects to an application link, which I am able to select to be opened by Notion. Opening the link with Notion does nothing, and when I switch back to the Notion window, the login page is still visible
Info

OS: Pop!_OS 20.04 LTS
Browser: Firefox 81.0.2
notion-deb-builder: Notion 2.0.7+ (tried both win & mac variants)

Requested change
As this is a wrapper (a very much appreciated one! 😁) I don't expect you to find a way to let the application support this, although it would be cool if the readme noted that Google login is not supported.

I've experienced this issue as well, though it isn't a blocker. Putting your gmail address in the email field and attempting to login that way, will generate a login key that you can use to get into your account.

@Rgrable I'm not sure what you're describing here, could you expand on it a little? Which email field are you talking about, and how does one extract the key?

Hey @ettmetal sure, when you're presented with the login page, input the gmail address that you used for the SSO

You'll receive a prompt for a login code that will be sent to that email, using that code will allow you to login to that account.

Hope that helps!

Cool, I see what you meant now - thanks for the workaround, it worked for me

Thanks for reporting this @ettmetal! I've added a section to the readme linking to your comment @Rgrable, closing this now :)

Hello, as of the latest release it's now possible to login using Google and Apple ID.

Hello, as of the latest release it's now possible to login using Google and Apple ID.


Prepend website form with https://

Details
Prepends the website form input on the VBA company step with https://
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/170004
Tests / QA Steps (Web only)

Go to /bank-account/company
Verify that the text input for the company website is pre-populated with https://
Verify that when you select the input and start typing, that https:// isn't automatically overwritten.

Tests / QA Steps (other platforms)
On other platforms, the VBA flow is not yet readily accessible.
Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots
Web

Mobile Web

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production         in version: 1.0.77-5🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


undefined method `bcrypt' for Devise:Module

Help!
I use this gem in my project. but I face the error when generate backup codes.

My devise is 3.1.0 and this gem is locking 1.0.0

I find the Device.bcrypt method is defined in module database_authenticate which is conflict with two_factor_authenticatable.
Since some reason, I cannot upgrade my devise.
_So how can I use two_factor_authenticatable and two_factor_backupable with devise 3.1.0?_

Devise.bcrypt got moved to Devise::Encryptor.digest in newer versions.


capitalization: Make it easier to ignore phrases.

This commit allows us to add the errors shown by the
tools/check-capitalization in the IGNORED_PHRASES list
without any modification.
@timabbott, please review.

Automated message from Dropbox CLA bot
@umairwaheed, it looks like you've already signed the Dropbox CLA. Thanks!

Merged, thanks @umairwaheed!


Async action on component present on hpx::find_here is executing synchronously

Created a components on each available locality and executed action on it. Future returned by the component on hpx::find_here is always ready. It appears that it is scheduled immediately where as what I expect it to to schedule it on a separate OS thread and wait_all at the end waits for all.
Using latest master branch of HPX
HPX built in release mode
More than 1 OS thread is used for locality 0
Tested using 1, 2, 3, 4 localities
Minimal code used for testing
#include <hpx/hpx_init.hpp>
#include <hpx/include/actions.hpp>
#include <hpx/include/components.hpp>
#include <hpx/lcos/wait_all.hpp>

#include <utility>
#include <vector>
#include <ctime>
#include <cstdlib>

struct bar_server : public hpx::components::component_base<bar_server>
{
    int get_foo() {
        for(int i=0; i<1000000000LL; i++); // waste some time and return
        return 42;
    }
    HPX_DEFINE_COMPONENT_DIRECT_ACTION(bar_server, get_foo, get_foo_action);
};
using bar_server_type = hpx::components::component<bar_server>;
HPX_REGISTER_COMPONENT(bar_server_type, bar_server);

HPX_REGISTER_ACTION(bar_server::get_foo_action);

struct bar : public hpx::components::client_base<bar, bar_server>
{
    public:
        using base_type = hpx::components::client_base<bar, bar_server>;

        bar() = default;

        bar(hpx::id_type id) : base_type(hpx::new_<bar_server>(id))
        {
        }

        hpx::future<int> get_foo() {
            bar_server::get_foo_action act;
            return hpx::async(act, get_id());
        }

};

int hpx_main(int, char*[])
{

    std::vector<hpx::naming::id_type> localities = hpx::find_all_localities();

    std::srand(std::time(NULL));
    std::vector<bar> bs;
    for(int i=0; i<localities.size(); i++) {
        if (localities[i] == hpx::find_here()) {
            continue; // Ignore this locality for now
        }
        bs.push_back(bar(localities[i]));
    }
    int this_loc_bs_index = (int)(std::rand()%localities.size());
    bs.insert(bs.begin() + this_loc_bs_index, hpx::find_here());
    std::cout << "find_here bs index " << this_loc_bs_index << std::endl;
    std::vector<hpx::future<int>> f;
    for(int i=0; i<bs.size(); i++) {
        f.push_back(bs[i].get_foo());
        std::cout << i <<  " Is future ready " << f.back().is_ready() << std::endl;
    }
    hpx::wait_all(f);

    return hpx::finalize();
}

int main(int argc, char* argv[])
{
    return hpx::init(argc, argv);
}

Future for component of b on hpx::find_here is always ready.

That's exactly what direct actions are for. They are executed inline if execution is local. If you need asynchronous behavior, please use
HPX_DEFINE_COMPONENT_ACTION(bar_server, get_foo, get_foo_action);

instead.

Oops!, missed that.
Thanks for a quick response.


Calls from VM to block machine whose functions share the same interface

partially closes #381
Witness generation fails for machines whose functions have different interfaces:
// given
function foo x, y -> z {
}
// then this is ok
function bar x, y -> z {
}
// but this is not
function baz z, x, -> y {
}

test failing


ASCII and Base conversion Extension

Description
This extension has some tools for binary and other base numbers and also for ASCII and Unicode characters.
Checklist

[x] Extension has a proper name and description.
[x] Extension has tags (for example: "platform, brick, breakable").
[x] All behaviors have a description.
[x] All functions (actions, conditions, expressions) have descriptions and proper sentences.
[x] I've followed the best practices listed on http://wiki.compilgames.net/doku.php/gdevelop5/extensions/best-practices
[x] I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.

Example
Ascii.zip
Extension file
ASCIII.zip
.

Your solutions seem quite hacky and limited, I wonder if an Encoding API based solution would be better, as it should support all UTF-8 characters and use native browser code which should be faster and more reliable generally. Quick mockup:
const encoder = new TextEncoder();
const bin_array = encoder.encode("😀 My UTF string!");
const str = bin_array.join(" ");
console.log(str);
const array_from_str = Uint8Array.from(str.split(" "))
const decoder = new TextDecoder();
const decoded = decoder.decode(array_from_str);
console.log(decoded)

While you are thinking about that, here are a few additional review points:

Keep in mind: The code of extensions should be readable as they are designed to be easily opened and tinkered with by anyone. Try to make your code readable and commented to let people do so easily.

Do not use the var keyword, use const where possible otherwise use let
Write your variable names in camelCase, not PascalCase
Do not define redundant functions
Use clear variable names

Here is an example of how to change your code:
Before

After

Ok, Thanks for the feedback!
I gonna clean it up a bit and add an updated version here.

While you are thinking about that, here are a few additional review points:

Ok, Thanks for the feedback!
I gonna clean it up a bit and add an updated version here.

And I am not so sure but I think it supports all of the UTF-8. Quickly changes the name and everything with the word ascii

The reverse binary thing also supports all the UTF-8 characters (If you don't want to reverse it back to what it was).


[SPARK-14371] [MLLIB] OnlineLDAOptimizer should not collect stats for each doc in mini-batch to driver

Hi,
What changes were proposed in this pull request?
as it was proposed by @jkbradley , gammat are not collected to the driver anymore.
How was this patch tested?
existing test suite.

Test build #80524 has started for PR 18924 at commit f81f1cd.

Test build #80524 has finished for PR 18924 at commit f81f1cd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80524/
Test PASSed.

@feynmanliang , @hhbyyh, @WeichenXu123, could you please review the PR?

Thanks! I will take a look later.

ping @akopich This is an very useful improvement. Can you update the code while you're at it ?

Yes, sure. Thank you for the valuable comment. Hopefully, I'll update the code this week.

Ping @jkbradley .
Thank you @WeichenXu123 one again for the comment! Please, have a look.

Test build #81885 has started for PR 18924 at commit 9ce9655.

Test build #81885 has finished for PR 18924 at commit 9ce9655.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81885/
Test FAILed.

Test build #81893 has started for PR 18924 at commit 8e9bc73.

@WeichenXu123, thank you for your prompt reply!

Test build #81893 has finished for PR 18924 at commit 8e9bc73.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81893/
Test PASSed.

Taking a look

Test build #82007 has started for PR 18924 at commit b3875e8.

@jkbradley, thank you for your comments! Please, check out the commit adding the necessary docs.
Regarding tests: I believe, OnlineLDAOptimizer alpha hyperparameter optimization from mllib/clustering/LDASuite.scala covers the piece of code being rewritten. Or should there be tests of a different kind?

Test build #82007 has finished for PR 18924 at commit b3875e8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82007/
Test PASSed.

Test build #82027 has started for PR 18924 at commit 8227b1a.

Test build #82030 has started for PR 18924 at commit d7004a1.

Test build #82027 has finished for PR 18924 at commit 8227b1a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82027/
Test PASSed.

Test build #82030 has finished for PR 18924 at commit d7004a1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82030/
Test PASSed.

Test build #82111 has started for PR 18924 at commit 1f9e650.

@jkbradley, thanks for the comments. Who is supposed to create the followup jira?

Test build #82111 has finished for PR 18924 at commit 1f9e650.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82111/
Test PASSed.

@akopich follow-up JIRA created here
https://issues.apache.org/jira/browse/SPARK-22111
Can you create follow up PR after this PR being merged ?

@WeichenXu123, thanks for creating Jira. Yes, sure I will work on it.

@WeichenXu123, @jkbradley, talking of merging. Is there anything else I should improve in this PR in order for it to be mergeable?

LGTM. Thanks! ping @jkbradley

@WeichenXu123, the PR seems to receive no attention for 10 days now... What should I do?

Oh, sorry for that, it should waiting @jkbradley to merge it. Don't worry, I will contact him!

@WeichenXu123. thank you

@hhbyyh, this change does not target performance but scalability, and I am afraid, the change is beneficial only for huge datasets and the tests would require massive computational resources.

Test build #82448 has started for PR 18924 at commit 5c9547f.

BTW. Seems like updateLambda method relies (in older version as well) on batchSize only because this is an optimization to avoid batch.count. Shouldn't we rather use nonEmptyDocsN instead since we compute it efficietly now? But that is going to change logic...

Test build #82448 has finished for PR 18924 at commit 5c9547f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82448/
Test PASSed.

@jkbradley, thank you!

Correctness: in order to test the equivalence of two versions of submitMiniBatch I have to bring both of them into the scope... One solution would be to derive a class OldOnlineLDAOptimizer from OnlineLDAOptimizer and override submitMiniBatch but the class is final. What's the preferred approach?
Sure. Sounds good. Should I add test-case reporting the CPU time or should I rather define an App? Should I add the code to the PR or just report the results here?

Yes, I think local test is enough for both correctness and performance.
For consistency with old LDA, just some manual local test would be sufficient. You may well just use the LDA example and switch the Spark jar files between Spark 2.2 and your branch. And I think the case with empty document worth special attention.
The same for the performance test. You may just post the result after your local test. I'm OK as long as there's no noticeable regression.

Thank you, @hhbyyh.
I have augmented the example a bit: explicitly set random seed a nd chosen online optimizer:
val lda = new LDA().setK(10).setMaxIter(10).setOptimizer("online").setSeed(13)
But for some reason if I run it twice, the results are not the same. Is that expected? branch-2.2 was used.

Test build #82482 has started for PR 18924 at commit 68ca837.

Test build #82482 has finished for PR 18924 at commit 68ca837.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
final class OnlineLDAOptimizer extends LDAOptimizer with Logging

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82482/
Test PASSed.

I have conducted some performance testing with random data.
The new implementation turns out to be notably faster.
OLD with hyper-parameter optimization  : 237 sec
OLD w/o  hyper-parameter optimization  : 226 sec
NEW with hyper-parameter optimization : 178 sec
NEW w/o  hyper-parameter optimization : 171 sec

Test build #82487 has started for PR 18924 at commit 2942082.

Test build #82487 has finished for PR 18924 at commit 2942082.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82487/
Test PASSed.

Test build #82505 has started for PR 18924 at commit f181496.

Test build #82506 has started for PR 18924 at commit a81dae5.

So shall we ping @jkbradley, shan't we?

Test build #82505 has finished for PR 18924 at commit f181496.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82505/
Test PASSed.

Merged build finished. Test PASSed.

Test build #82506 has finished for PR 18924 at commit a81dae5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82506/
Test PASSed.

@WeichenXu123, could you please notify @jkbradley once again?

@akopich  LGTM. and do you have time to create a PR to resolve random seed not working issue mentioned by @hhbyyh ?  Thanks!

@WeichenXu123, yes sure. But can this wait until this PR is merged?

@akopich Yes you can wait this to be merged first. I think @jkbradley will have time to check this next week. Don't worry!

@WeichenXu123, no problem! Thank you.

LGTM
Sorry for the delay!
I'll merge it after re-running tests

Test build #3951 has started for PR 18924 at commit a81dae5.

@jkbradley, no problem. The test build seems to be aborted. What's wrong?

retest this please

Test build #82880 has started for PR 18924 at commit a81dae5.

Test build #82880 has finished for PR 18924 at commit a81dae5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82880/
Test PASSed.

ping @jkbradley. Anyway, tests are passed now.

Merging with master

@akopich I'm afraid pings on Git don't work for me; I just have too many to keep up with.  Again, sorry for the delays; I have very limited bandwidth nowadays.

I'll update JIRA later; it seems like Apache JIRA is having problems right now.

@jkbradley, no problem.
@jkbradley, @WeichenXu123, @hhbyyh, thank you all guys!


flake8 all the things

I installed flake8, and ran on master, here is the output:
https://gist.github.com/karlw00t/d76013ba9bd47f11e0512d74a208367b
My proposed solution would be to give a PR that enforces flake8 on build, so new commits won't build without being flake8, and all the changes needed to make the package build.


rule shebang naming

eslint-plugin-n version
latest
What problem do you want to solve?
In the description of the es specification, it is hashbang and not shebang.
https://github.com/tc39/proposal-hashbang
What do you think is the correct solution?
renaming rule shebang => hashbang.
for compat, we could keep shebang as an alias.
Participation

[X] I am willing to submit a pull request for this change.

Additional comments
No response

I think you're right, we should follow the spec, that being said, I only really knew this as a shebang. I don't like the idea of using an alias though, I would prefer we only used either hashbang or shebang :eyes:
What do you think?

I prefer to maintain compatibility if it doesn't come with too many maintenance costs :).

That makes sense to me :)

Hey, sorry for being late on this, but maybe someone else is wondering the same thing I was "WTH is hashbang?".
I have no idea what TC39 were smoking when they let a dude with zero GitHub activity reach stage 4 but the #! thing has always been called a 'SHeBang' since 1980.
Even Google will try to correct you if you type something like "script hashbang".
So yeah, this was definitely a rushed change...

https://github.com/tc39/proposal-hashbang?tab=readme-ov-file#why-hashbang-instead-of-shebang

It may indeed be controversial, but we should still follow the terminology of tc39.

https://github.com/tc39/proposal-hashbang?tab=readme-ov-file#why-hashbang-instead-of-shebang

https://en.wikipedia.org/wiki/Shebang_(Unix)
Being approved by TC39 does not automatically make it the correct choice. People make mistakes, and this is one example of such a case.

As of now, I'm not sure what's the right next step, butshebang was not (and will not) removed, it's now an alias of hashbang, so you can keep using it. :)


Running with docker

Does anyone have a recommended Dockerfile to run this with, or at least a good image to start with?

Hey, this is on the roadmap but no ETA as unfortunately there are a lot of more pressing issues to be prioritized first.
However, I'd probably start with off with something like:
FROM node:20 # next LTS from end October

RUN apt-get update
RUN apt-get yarnpkg

# install mongo, at least for now
RUN apt-get install -yqqq mongodb-org

WORKDIR /usr/src/app
COPY package.json yarn.lock .
RUN yarn install

COPY . .
EXPOSE 3000
CMD [ "yarn", "dev" ]

This is just a starting point though and I haven't tested this... if you come up with something good, please send as a PR! :pray: :grin:

On a related note, is there somewhere with a list of the environment variables. I imagine it wouldn't be difficult to read them from the source code, but where would I look?

Heh, no, I mean, here:
$ $ grep -E 'getenv|environ.get' `find . -type f -name \*.py`
./api/utils/storage/S3Storage.py:AWS_S3_ENDPOINT_URL = os.environ.get("AWS_S3_ENDPOINT_URL", None)
./api/utils/storage/S3Storage.py:AWS_S3_DEFAULT_BUCKET = os.environ.get("AWS_S3_DEFAULT_BUCKET", None)
./api/getScheduler.py:HF_AUTH_TOKEN = os.getenv("HF_AUTH_TOKEN")
./api/getScheduler.py:DEFAULT_SCHEDULER = os.getenv("DEFAULT_SCHEDULER", SCHEDULERS[0])
./api/precision.py:MODEL_REVISION = os.getenv("MODEL_REVISION")
./api/send.py:SEND_URL = os.getenv("SEND_URL")
./api/send.py:SIGN_KEY = os.getenv("SIGN_KEY", "")
./api/send.py:container_id = os.getenv("CONTAINER_ID")
./api/download_checkpoint.py:CHECKPOINT_URL = os.environ.get("CHECKPOINT_URL", None)
./api/lib/vars.py:RUNTIME_DOWNLOADS = os.getenv("RUNTIME_DOWNLOADS") == "1"
./api/lib/vars.py:USE_DREAMBOOTH = os.getenv("USE_DREAMBOOTH") == "1"
./api/lib/vars.py:MODEL_ID = os.environ.get("MODEL_ID")
./api/lib/vars.py:PIPELINE = os.environ.get("PIPELINE")
./api/lib/vars.py:HF_AUTH_TOKEN = os.getenv("HF_AUTH_TOKEN")
./api/convert_to_diffusers.py:CHECKPOINT_CONFIG_URL = os.environ.get("CHECKPOINT_CONFIG_URL", None)
./api/convert_to_diffusers.py:CHECKPOINT_ARGS = os.environ.get("CHECKPOINT_ARGS", None)
./api/download.py:HF_AUTH_TOKEN = os.environ.get("HF_AUTH_TOKEN")
./api/download.py:RUNTIME_DOWNLOADS = os.environ.get("RUNTIME_DOWNLOADS")
./api/download.py:            model_url=os.environ.get("MODEL_URL"),
./api/download.py:            model_id=os.environ.get("MODEL_ID"),
./api/download.py:            hf_model_id=os.environ.get("HF_MODEL_ID"),
./api/download.py:            model_revision=os.environ.get("MODEL_REVISION"),
./api/download.py:            model_precision=os.environ.get("MODEL_PRECISION"),
./api/download.py:            checkpoint_url=os.environ.get("CHECKPOINT_URL"),
./api/download.py:            checkpoint_config_url=os.environ.get("CHECKPOINT_CONFIG_URL"),
./api/loadModel.py:PIPELINE = os.getenv("PIPELINE")
./api/server.py:server.config.CORS_ORIGINS = os.getenv("CORS_ORIGINS") or "*"

(with duplicates deleted) but you're right this should be more accessible.  Maybe it will be a good idea to put them all in one file with comments.  Note also the AWS code uses that bota3 library which uses some of its own environment variables too.

That's great thanks. I don't see anything about mongo. I installed mongo, but it said something about a password, and I thought there would be more things I need to set.

Hey again.

Mongo... yeah, that's just a warning... you don't need a password for local development and sd-mui will work with the default settings with no additional setup.

Env vars.  Big apologies from me!  Sorry!  I was answering issues on both repos and got confused.  The docker-diffusers-api is indeed all in python, but is already all dockerized in a nice container.  The above environment variables have nothing to do with the webui.  Sorry again.  Take two:

MONGO_URL - no need to set with default dev settings / mongo port.
NODE_ENV - set automatically to development, production, etc.
REQUIRE_REGISTRATION=0 and NEXT_PUBLIC_REQUIRE_REGISTRATION=0 - originally turned off all the mongo and credit stuff but hasn't been well looked after and doesn't guarantee that anymore - for now!
MONGODB_RELAY_PASSWORD=1 probably required for the latest commits
KIRI_API_KEY=xxxx, BANANA_API_KEY=xxx, RUNPOD_API_KEY=xxx etc depending on APIs used
BANANA_MODEL_KEY_{MODEL_ID}=xxx, for each model, if banana used.
Any client keys/secrets for auth in ./pages/api/auth/[...nextauth

I believe that's it... but let me know if you run into any thing else, and thanks for helping me consolidate these all in one place :sweat_smile:


Release 1.1.3 (patches and more tests/examples)

We are now trying to implement several major changes, PLG, premodit, Toon+89-type RT, and a common API for molecular/atomic db. Before including these major changes, we would release some patches, and validation applied to ExoJAX since v1.1.2.

including

patch to adopt the recent JAX  #249 This is the main reason of this release of this patch.

setdgm  for HITRAN/HITEMP #253

doc updates/ HITRAN, Krucz, jaxopt

@ykawashima Could you check on that for a moment (not seriously) just in case?


Traefik error with docker-compose

Thank you so much for maintaining this cookiecutter repo! I am currently trying it out to see if it will work for a project, and was hoping to get it set up in local development only. However, it seems like docker-compose wants me to have a load balancer set up on my development machine, which I really do not want to do. Any ideas how I can proceed? I'm happy to do some development work and commit it back to the community, if that's what it takes.
For reference: the error that I'm getting is
ERROR: Invalid interpolation format for "proxy" option in service "services": "${TRAEFIK_PUBLIC_NETWORK?Variable not set}"

Set the version of docker compose in docker-compose.yml and docker-compose.override.yml like this (in top of the files):
version: "3.3"


Error on start

Versions

Minecraft Version: 1.16.4
Forge Version: 1.16.4-forge-35.1.37
Mod Version: 1.16.5-7.0.15
Do you use Sponge, OptiFine or Vivecraft: No, I am not.

Describe the bug
As soon as I start the game, it's giving me the error that is shown in the attached image.
I've been reading through the comments and they said it's compatible with it.

To Reproduce
Steps to reproduce the behavior:

Open the game

Expected behavior
I can just open Minecraft and use it.
Additional context (e.g. Crash Log if it crashed)
latest.log
crash-2021-04-26_16.28.13-fml.txt

1.16.5 version requires Minecraft 1.16.5 to run


kubescape cli, azure pipelines - failed to get AKS descriptive information

Description
I'm using azure devops pipelines to run kubescape cli.
  - task: Bash@3
    inputs:
        targetType: "inline"
        script: |
          kubectl config current-context
          az account list --query "[?isDefault]" -o table
          kubescape scan framework nsa --format pdf --output results-k8s.pdf --verbose

The k8s is not IP whitelisted. At the end I get this:
│  Medium  │ Secret/etcd encryption enabled                        │        0         │       0       │ Action Required *  │
│  Medium  │ Audit logs enabled                                    │        0         │       0       │ Action Required *  │
│   Low    │ Immutable container filesystem                        │        65        │      87       │        25%         │
│   Low    │ PSP enabled                                           │        0         │       0       │ Action Required *  │
 * failed to get AKS descriptive information. Read more: https://hub.armosec.io/docs/kubescape-integration-with-cloud-providers

Since kubectl command works, what more do I need to do in relation to AKS?
Environment
OS:  Red Hat Enterprise Linux release 9.
Version:  v3.0.21
Steps To Reproduce
Steps to reproduce the behavior:

use az cli to login to your AKS
run kubescape
See error

Expected behavior
I expect not to see any AKS login related issues.
Actual Behavior
I get this message
failed to get AKS descriptive information. Read more: https://hub.armosec.io/docs/kubescape-integration-with-cloud-providers

I am not sure if this is supported, wdyt @dwertent ?
In any case, you need to follow https://hub.armosec.io/docs/azure-aks and generate some credentials...

I am not sure if this is supported, wdyt @dwertent ? In any case, you need to follow https://hub.armosec.io/docs/azure-aks and generate some credentials...

Even if I generate these credentials, where do I put them (when using kubescape cli)?

I am not sure, this is why I've asked @dwertent who did this feature

It seems we don't have detailed documentation on this. However, you can refer to this guide for running in an Azure pipeline. Please note that it might not be completely up-to-date, as I'm unsure about recent Azure updates.
Regarding setting up the credentials for the CLI, you'll need to configure the following environment variables:
AZURE_SUBSCRIPTION_ID
AZURE_RESOURCE_GROUP

You can also refer to the relevant code implementation here:
https://github.com/kubescape/k8s-interface/blob/main/cloudsupport/v1/akssupport.go#L17-L20

@dwertent, the guide doesn't really suggest anything special - it just installs and runs the cli.
I tried setting the var's - no luck.
The error comes from this line.


lgbm categorical, dataset or parameter dictionary

Description
warning from lgbm when passing categorical_features list in parameter dictionary
Reproducible example
print('Loading data...')
# load or create your dataset
df_train = pd.read_csv('../binary_classification/binary.train', header=None, sep='\t')
df_test = pd.read_csv('../binary_classification/binary.test', header=None, sep='\t')
W_train = pd.read_csv('../binary_classification/binary.train.weight', header=None)[0]
W_test = pd.read_csv('../binary_classification/binary.test.weight', header=None)[0]

y_train = df_train[0]
y_test = df_test[0]
X_train = df_train.drop(0, axis=1)
X_test = df_test.drop(0, axis=1)

num_train, num_feature = X_train.shape

# create dataset for lightgbm
# if you want to re-use data, remember to set free_raw_data=False
lgb_train = lgb.Dataset(X_train, y_train,
                        weight=W_train, free_raw_data=False)
lgb_eval = lgb.Dataset(X_test, y_test, reference=lgb_train,
                       weight=W_test, free_raw_data=False)

# specify your configurations as a dict
params = {
    'boosting_type': 'gbdt',
    'objective': 'binary',
    'metric': 'binary_logloss',
    'num_leaves': 31,
    'learning_rate': 0.05,
    'feature_fraction': 0.9,
    'bagging_fraction': 0.8,
    'bagging_freq': 5,
    'verbose': 0,
    'categorical_feature': [21,22],
    'num_boost_round':10,
    'seed':10
}

# generate feature names
feature_name = ['feature_' + str(col) for col in range(num_feature)]

print('Starting training...')
# feature_name and categorical_feature
gbm = lgb.train(params,
                lgb_train,
                 valid_sets=[lgb_train,lgb_eval],  # eval training data
                feature_name=feature_name)

print('Finished first 10 rounds...')
# check feature name
print('7th feature name is:', lgb_train.feature_name[6])

Environment info
LightGBM version or commit hash: 2.3.1
Command(s) you used to install LightGBM
conda forge

Hi, the context was that i was using pandas to parse the categorical features. However at inference time, this made it harder to work with array as lgbm will complain and i will need to convert array to pandas.
Hence, i decided to use the categorical feature index instead. notice that in the documentation, it is adviced to passed as parameter to .Dataset. However, using the example i found that parsing it via the parameter dictionary is giving the same result but got the complain here:
UserWarning: categorical_feature keyword has been found in `params` and will be ignored.
Please use categorical_feature argument of the Dataset constructor to pass this parameter.
  .format(key))

Want to check if this is correctly done. I know the results are comparable vs passing it to .Dataset. Just need a confirmation as lgbm was complaining please use .... Dataset constructor.. Thanks!

Refer to https://github.com/microsoft/LightGBM/issues/1408#issuecomment-530096617.
As you've already mentioned, the correct way is to pass categorical features via Dataset constructor. Passing them is params is wrong.


Shameless Request

I know this is kind of shameless to ask but is there any possibility that you guys will add some spice to the app?
I'm talking about the "H"

NO !


Option to create scene when importing model

When importing a model, allow the user to create a scene containing an entity with a mesh and a material component bound to the imported model and its textures (if textures were imported).
Fixes #353

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)


PS/2 mouse support?

The Agon Console8 includes both a USB-A socket as well as a PS/2 socket.
Can the PS/2 socket be used for a mouse?

added in #64


Stop our release pipeline from downloading the entire SDK. Twice.

The debugging tools folks helpfully published PdbStr and SrcTool as
NuGet packages for us to take a dependency on! Now we can end this
wasteful practice once and for all...
NOTE: This change introduces a harmless error message at the end of
symbol indexing. Instead of printing out the list of mapped sources,
srctool will complain that srcsrv.dll is missing. This is only cosmetic.

@msftbot merge this in 4 minutes


Enable GitHub Pages for awesomedjango.org

Please update settings to add GitHub Pages.
Please see #92 and let's switch the default branch to main first.

done


Improve the Travis setup

Fix the PHP 5.3 job
Add testing on PHP 7
Remove testing on Symfony 2.3 (which is EOLed)
Remove testing on HHVM (as they announced the end of support of PHP compat)

Closes #290

I did PR #296 and then realized this was here. But the Travis build has failed here.
Why not just update thhe Symfony version to 2.8 (a current LTS Symfony version)?
Why "fix" the PHP 5.3 job? Surely PHP 5.3 can just be removed as it is long dead.

Come on guys, there's already a queue of MRs waiting to be merged because of issues with Travis.
How can we help?

Why "fix" the PHP 5.3 job? Surely PHP 5.3 can just be removed as it is long dead.

As the branch still advocates support for PHP 5.3, the CI must cover it (otherwise, it opens the door to broken releases, and this happened in Behat itself).


draft - Henri 2021

Currently stuck on fetch_river_geometry due to ended support for the https://cida.usgs.gov/nwc/geoserver/nhdplus/ows endpoint

@dblodgett-usgs
I thought we had a geoserver migration or workaround for this - are you aware?
This is for Hurricane Henri

Can get past that by using nhdplusTools to pull in flowlines and waterbodies for the base map (https://github.com/USGS-VIZLAB/vizstorm-GIF/pull/238/commits/4bd309a21050592e931473800d69e8dff9a86cb2).

Now onto an error coming from process_precip_rasters() in 2_process/src/process_precip

I get the following error when running scmake('6_visualize/tmp/gif_frame_a_20210821_06.png', '6_storm_gif_tasks.yml')

The error occurs when create_animation_frame attempts to plot the precip rasters.

That error is usually related to either character data when it should be numeric or completely empty data being passed in. Let's hop on a call and troubleshoot


Reflex deployment cannot connect to server

Describe the bug
When trying to deploy the starter app (created using reflex init, tested that reflex run works properly) using reflex deploy, I'm getting this error that indicates a backend issue.

The logs don't show any obvious error, besides a warning about Node binary.

The link to the failing deployment is https://scrutineer.reflex.run
To Reproduce
Steps to reproduce the behavior:

install reflex==0.4.5
initialize blank app using reflex init
test that reflex run works properly locally
use reflex deploy to deploy app

Expected behavior
App should be deployed and behave similarly as when running locally
Screenshots
If applicable, add screenshots to help explain your problem.
Specifics (please complete the following information):

Python Version: 3.11.4
Reflex Version: 0.4.5
OS: MacOS Sonoma 14.0
Browser (Optional): Brave

Additional context
Add any other context about the problem here.

think there was something wrong with my python installation. recreated poetry environment and is working now!


Feature/edit organization profile

What does this pull request aim to achieve? 💯

created edit organization profile and edit organization account using edit user components
created and styled the mobile version
validated forms using react hook form
I didnt use any dummy data cause i felt there was no need but after the validation the form details is stored in useForm data object which can then be passed to the backend
you can only access these pages for now by editing the url because the organization profile is not ready yet to link them.

Please be concise and link any related issue(s):
🚨Before submitting this pull request🚨:
Please do NOT submit this PR if you have not done the following:

I have checked that no one else is working on similar changes.
I have read the latest README and understand the development workflow.
The name of this branch is: feature/<branch_name> (need to have cloned the repo not forked).
This branch is rebased/merged with the latest master.
There are no merge conflicts.
There are no console warnings and errors.
On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".

@Chimaobi-Johnson, I tried to test this on using your Build URL. I was able to log in as an individual user but what steps should I follow to create and edit an organization profile once I've created my individual user?

Hello @Chimaobi-Johnson! I'll take a look at this later today. I'm sorry it has taken me so long

@Chimaobi-Johnson Thanks for clarifying! Should #399 be merged before this or does order not matter?

thanks @BMariscal
@anniegiang the order doesnt matter


Memory needs to use separate *MemBuff buffers for Storage buffers

Finally tracked down the source of compute system errors to the fact that the vgpu Memory system combines all Storage Buffers into a single integrated memory object!!
this is the thing that has a 4 GiB capacity limit, and once that is exceeded, bad things happen, as observed.

Could have unique buffers for each Var or Val, stored in each.  This creates more separate buffers floating around, but makes the management much simpler.

Otherwise, can group smaller buffers into shared ones.  this requires grouping algorithm and logic.

In any case, uniforms remain in one buffer because they are generally limited anyway.
Buffer assignment code is in:
varset.go: BindDynVar
	buff := vs.Mem.Buffs[vr.BuffType()]
	wd.PBufferInfo = []vk.DescriptorBufferInfo{{
		Offset: 0, // dynamic
		Range:  vk.DeviceSize(vr.MemSize()),
		Buffer: buff.Dev,
	}}

or similar BindStatVar
			bis[i] = vk.DescriptorBufferInfo{
				Offset: vk.DeviceSize(vl.Offset),
				Range:  vk.DeviceSize(vl.AllocSize),
				Buffer: buff.Dev,
			}

Also, should just use static binding for axon -- no point in dynamic.  test in vgpu compute shader case.

axon not getting state back from network -- something broken in transfer


Fix for warnings

Eliminated a couple of warnings when building OpenWeave for the nRF5 SDK.

Codecov Report

Merging #232 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   54.16%   54.16%
=======================================
  Files         332      332
  Lines       56393    56393
=======================================
  Hits        30546    30546
  Misses      25847    25847

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d9a8a...226b436. Read the comment docs.


Manifest missing mediaType

The manifest has no top level mediaType set and I believe that because of this, it doesn't render as expected in the Docker Hub web view. It should show the OS/Arch options.
The following is an example of ubuntu: https://explore.ggcr.dev/?image=ubuntu%3Alatest
VS the current curlimages/curl: https://explore.ggcr.dev/?image=curlimages/curl@sha256:9d679ae7718688259258a3ea3862963023f32eae630052fde63aae5e9919a90d&mt=application%2Fvnd.oci.image.index.v1%2Bjson&size=1043
Example in Docker Hub, note that OS/Arch is empty:

Updating the buildah manifest push command with
--format v2s1
--format v2s2
--format oci
May possibly resolve this.

Referenced on Docker Hub - https://github.com/docker/hub-feedback/issues/2329

well --format oci does not work ... will try the others

checking https://explore.ggcr.dev/?image=curlimages%2Fcurl%3A8.1.2 ... seems to have correct media type

Thanks @xquery
Looking good!


Export Google Meet creation functionality

Change-type: minor
Signed-off-by: Josh Bowling<EMAIL_ADDRESS>

@balena-ci I self certify!


Added build query option for searching raw records

I've updated the branch, since there are loads of refactor changes related to https://github.com/openownership/register/issues/188 which affect this PR. It's probable that this will cause CI to fail, even if this PR passed before. That will have to be updated prior to merge.


Update repositories.txt

@ArduinoBot
Have updated

Have reviewed and tested the code
All working

Hi Per,
Do not understand how to do what you are requesting.
Going round in circles
Cheers
Andrew
All My Things On Line
[http://www.allmythingsonline.com/Images/Amtol/logo.gif]
All My Things On Linehttp://www.allmythingsonline.com/

From: per1234 @.>
Sent: Tuesday, 3 October 2023 3:03 PM
To: arduino/library-registry @.>
Cc: and900 @.>; Mention @.>
Subject: Re: [arduino/library-registry] Update repositories.txt (PR #3410)
@per1234 commented on this pull request.
Hello @and900https://github.com/and900. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new releasehttps://docs.github.com/en/github/administering-a-repository/releasing-projects-on-github/managing-releases-in-a-repository or taghttps://git-scm.com/docs/git-tag in the library repository.
If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:
https://github.com/and900/AMYTOL_Robot/blob/Update/library.properties#L2
version=1.0.0 All My Things On Line (AMYTOL) September 8th 2023
❗ Remember to update the version field in the library's library.properties filehttps://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format as needed before making a release/tag.
Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
—
Reply to this email directly, view it on GitHubhttps://github.com/arduino/library-registry/pull/3410#pullrequestreview-1654319471, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACKYJFLUYJGANO723EPRNE3X5OE7NAVCNFSM6AAAAAA5OTHOL6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJUGMYTSNBXGE.
You are receiving this because you were mentioned.Message ID: @.***>

@ArduinoBot
Committed

@ArduinoBot

@ArduinoBot

Hello @and900. The automated system here only operates on open pull requests. Since your submission was already accepted and the pull request merged, the bot won't pay any more attention to this pull request.
But this human is happy to provide assistance. Was there something you needed from the bot?

Hi Per,
Want to update the Library.
How do I  do that?
Regards
Andrew

From: per1234 @.>
Sent: Tuesday, 3 October 2023 5:42 PM
To: arduino/library-registry @.>
Cc: and900 @.>; Mention @.>
Subject: Re: [arduino/library-registry] Update repositories.txt (PR #3410)
Hello @and900https://github.com/and900. The automated system here only operates on open pull requests. Since your submission was already accepted and the pull request merged, the bot won't pay any more attention to this pull request.
But this human is happy to provide assistance. Was there something you needed from the bot?
—
Reply to this email directly, view it on GitHubhttps://github.com/arduino/library-registry/pull/3410#issuecomment-1744304003, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACKYJFMEWCNGS4JFBBBJU6TX5OXVDAVCNFSM6AAAAAA5OTHOL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBUGMYDIMBQGM.
You are receiving this because you were mentioned.Message ID: @.***>

@and900 you can learn how to do that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-publish-a-new-release-once-my-library-is-in-the-list
Please let me know if you have any questions or problems.


[minor] SBT complains about missing bintray credentials on startup

It's a minor thing, but SBT complains about missing bintray credentials when running tasks, that do not require those credentials, like test
[warn] Credentials file /Users/maciejb/.bintray/.artifactory does not exist

Any update on this warning?

Getting a similar error. Did you get a solution?

Should be gone now :)


Oheger bosch/analyzer/dependency representation

This PR addresses #3321 by proposing a more efficient storage format for the dependency representation in Gradle analyzer results. The basic idea is to not repeat the dependency trees for all scopes, but construct an optimized dependency graph, in which dependencies are shared. Ideally, in this graph each dependency occurs once. However, as sometimes packages are referenced from scopes with different sets of dependencies, multiple occurrences are possible.
The most important class of this PR is the new GradleDependencyGraphBuilder class that integrates the project's dependencies into a dependency graph (represented by the DependencyGraph class). The class is currently specific to Gradle, but it should be possible to make it more generic, so that other analyzer implementations can make use of this optimized format as well.
Here are some numbers to give an impression of the size reduction of the dependency representation. The numbers are based on the Mozilla Focus Android project, which was used for testing. This project uses a large number of scopes causing the dependency graph in the old representation to become really huge:
Original representation:
Analyzer execution time: 55:55
Result file size: 1,2 GB
Time to load the result:  111539ms
In-memory representation of analyzer result 1)
byte[]:     45.883.121
String:     45.880.168
Identifier: 11.462.288
PackageRef: 11.461.897

New representation:
Analyzer execution time: 44:55 2)
Result file size: 46 MB
Time to load the result:  5509ms
In-memory representation of analyzer result 1)
byte[]:         36.154
String:         33.200
DependencyRef: 376.067 3)
DependencyIdx:  10.708
Identifier:        892
PackageRef:        501  4)

Remarks:

Number of instances of the listed classes, taken from the Memory view of the IntelliJ Debugger.
Not sure about the execution time, I actually expected the new approach to take slightly longer because of the additional effort to de-duplicate the dependency graph; however, as this is all done in-memory, it probably does not have a major impact. So the differences in the times could be caused by varying load of our Azure setup.
DependencyRef is the counter-part of PackageRef in the new dependency graph representation. It references dependencies by a numeric index rather than an identifier.
From the new dependency graph representation the set of Scopes is constructed, but also in an optimized form (shared references to packages). Therefore, the number of PackageRef instances is low.

By tweaking the representation of dependency references a bit, the size of the result file could be reduced even further to 25.2 MB.
As this approach uses numeric indices to reference dependencies, the result - at least the part with the dependency tree - is now not really readable for human beings. I am not sure whether this is a criterion or not. It would be possible, based on this strongly optimized format, to come to a representation that is still free of most redundancies, but would be more readable (something like a tree of packages that replaces duplicate sub trees by references). But this format would have to be implemented, and it would increase the result size again of course.

By tweaking the representation of dependency references a bit, the size of the result file could be reduced even further to 25.2 MB.
As this approach uses numeric indices to reference dependencies, the result - at least the part with the dependency tree - is now not really readable for human beings. I am not sure whether this is a criterion or not. It would be possible, based on this strongly optimized format, to come to a representation that is still free of most redundancies, but would be more readable (something like a tree of packages that replaces duplicate sub trees by references). But this format would have to be implemented, and it would increase the result size again of course.

@sschuberth, @mnonnenmacher, @fviernau: It would be great to have a discussion regarding the format of the dependency tree in the Analyzer result. Should it be as efficient as possible (using indices as dependency references) or do you prefer a more human-readable format?
What has been implemented here for Gradle can be applied to other Analyzer implementations as well. I would like to look at Maven next. I have some hope that the de-duplication of dependencies will also improve the performance of this package manager.

@sschuberth, @mnonnenmacher, @fviernau: It would be great to have a discussion regarding the format of the dependency tree in the Analyzer result. Should it be as efficient as possible (using indices as dependency references) or do you prefer a more human-readable format?
What has been implemented here for Gradle can be applied to other Analyzer implementations as well. I would like to look at Maven next. I have some hope that the de-duplication of dependencies will also improve the performance of this package manager.

Hi @oheger-bosch, can you please rebase this PR onto latest master so the Docker image can be built for it out of the box?

@sschuberth, the PR has been rebased.

@mnonnenmacher @fviernau this is looking good to me now, and I'd like to get this merged very soon. While this is not a breaking change in the strict sense, it changes the default output format for new Gradle project analyses. Any objections that I merge this?

@mnonnenmacher @fviernau this is looking good to me now, and I'd like to get this merged very soon. While this is not a breaking change in the strict sense, it changes the default output format for new Gradle project analyses. Any objections that I merge this?

Please let me have another look before merging it, I'm currently busy with testing #3564. In the meantime I have a question, do you plan to implement this for the other package managers anytime soon? Archiving two different formats in parallel makes any analysis of the analyzer results very difficult.

do you plan to implement this for the other package managers anytime soon?

No, probably not soon. We're planning to do this on-demand, if and and when we run into memory issues with other package managers. But that's purely out of a lack of time and other priorities; otherwise I'd of course like to migrate consistently to the new format as soon as possible.

do you plan to implement this for the other package managers anytime soon?

No, probably not soon. We're planning to do this on-demand, if and and when we run into memory issues with other package managers. But that's purely out of a lack of time and other priorities; otherwise I'd of course like to migrate consistently to the new format as soon as possible.

This would also be a chance to align the implementation of the different package managers a bit if the GradleDependencyGraphBuilder is made generic.

Archiving two different formats in parallel makes any analysis of the analyzer results very difficult.

Are you referring to using UploadResultToPostgresCommand to put analyzer results into Postgres for gathering statistics? If so, I believe we could rather easily add an optional on-the-fly conversion from new to old format to UploadResultToPostgresCommand.

Yes, good idea, I have already prepared that change and will make a PR once this is merged.

This would also be a chance to align the implementation of the different package managers a bit if the GradleDependencyGraphBuilder is made generic.

Indeed, we should take that opportunity to work a bit towards a more DRY implementation of the package managers which @haikoschol was mentioning a long time ago (I thought we had an issue for that, but I cannot find it anymore).


Add Function & SQL for customer ID registration/expiration

Add a cloud function with a corresponding database for registering & expiring customer IDs.
Security will be handled thru JWT validation, issued by Auth0 (maybe supertokens).
Registrant ID should be stored alongside the customer ID for future features like billing.


[tool_crash] Invalid argument(s): Cannot find executable for C:\Users\Kwmta\AndroidStudioProjects\flutter_app_1\android\gradlew.bat.

Command
flutter --no-color run --machine --track-widget-creation --device-id=69308381 --start-paused --dart-define=flutter.inspector.structuredErrors=true lib\main.dart

Steps to Reproduce

...
...
...

Logs
ArgumentError: Invalid argument(s): Cannot find executable for C:\Users\Kwmta\AndroidStudioProjects\flutter_app_1\android\gradlew.bat.
#0      _getExecutable (package:process/src/interface/local_process_manager.dart:127:5)
#1      LocalProcessManager.start (package:process/src/interface/local_process_manager.dart:43:30)
#2      _DefaultProcessUtils.start (package:flutter_tools/src/base/process.dart:462:28)
#3      _DefaultProcessUtils.stream (package:flutter_tools/src/base/process.dart:480:35)
#4      buildGradleApp (package:flutter_tools/src/android/gradle.dart:384:35)
#5      _AndroidBuilderImpl.buildApk (package:flutter_tools/src/android/android_builder.dart:102:13)
#6      AndroidDevice.startApp (package:flutter_tools/src/android/android_device.dart:513:28)
#7      _rootRunUnary (dart:async/zone.dart:1192:38)
#8      _CustomZone.runUnary (dart:async/zone.dart:1085:19)
#9      _FutureListener.handleValue (dart:async/future_impl.dart:141:18)
#10     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:682:45)
#11     Future._propagateToListeners (dart:async/future_impl.dart:711:32)
#12     Future._completeWithValue (dart:async/future_impl.dart:526:5)
#13     Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:556:7)
#14     _rootRun (dart:async/zone.dart:1184:13)
#15     _CustomZone.run (dart:async/zone.dart:1077:19)
#16     _CustomZone.runGuarded (dart:async/zone.dart:979:7)
#17     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1019:23)
#18     _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
#19     _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)

[✓] Flutter (Channel stable, v1.17.4, on Microsoft Windows [Version 10.0.18363.900], locale en-IN)
    • Flutter version 1.17.4 at C:\src\flutter
    • Framework revision 1ad9baa8b9 (11 days ago), 2020-06-17 14:41:16 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at C:/Users/Kwmta/AppData/Local/Android/Sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = C:/Users/Kwmta/AppData/Local/Android/Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions.

[✓] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 47.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[✓] Connected device (2 available)
    • POCO X2            • 69308381      • android-arm64 • Android 10 (API 29)
    • sdk gphone x86 arm • emulator-5554 • android-x86   • Android 11 (API 30) (emulator)

! Doctor found issues in 1 category.

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: 1ad9baa8b99a2897c20f9e6e54d3b9b359ade314

Hi @kwmta
I see there's an open issue addressing the case you described.
Please follow up on that issue, I'm closing the current one as duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you

Hi @kwmta
I see there's an open issue addressing the case you described.
Please follow up on that issue, I'm closing the current one as duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you


fix(tiled): prevent panic when loading a .TSX file with custom properties

Code was expecting "special tiles" to define the "animation" field which is not the case for tiles with only custom properties defined directly in the tileset and no animation.
Extract of .TSX file that reproduce the issue:
# no problem with this one: 'animation' is defined
<tile id="400" type="Global">
  <properties>
   <property name="Collision" type="bool" value="true"/>
  </properties>
  <animation>
   <frame tileid="291" duration="100"/>
   <frame tileid="324" duration="100"/>
  </animation>
</tile>

# this one causes a panic because no 'animation' is defined
<tile id="401" type="Global">
  <properties>
   <property name="Collision" type="bool" value="true"/>
  </properties>
</tile>

Cool, thank you!


Add back cancel invoices flags

closing this PR I actually already have push this without noticing their was a PR for it.


Inaccessible PointCollection Methods??

These methods in the PointCollection Class are inaccessible due to protection level.
GetAt();
GetMany();
GetView();
InsertAt();
RemoveAtEnd();
ReplaceAll();
SetAt();
Is this a bug or a documentation issue???

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4269af9e-0119-f07c-2dca-69429d2f97c2
Version Independent ID: dcfe54ef-7b2b-c077-f344-5e7da77cf2a3
Content: PointCollection Class (Windows.UI.Xaml.Media) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.UI.Xaml.Media/PointCollection.xml
Product: uwp
Technology: winui
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

These methods are part of the Windows.Foundation.Collections.IVector COM interface which .NET hides and instead implements IList on the projected class. When using from .NET, you can call similar IList methods on PointCollection. Those methods you mentioned are only for C++. I think the C# version of the documentation is incorrect.


Gitignore

Gitignore is weird, need to find the file for intellij projects

can add gitignore, but it doesnt seem to update the repo


chore: tsc should ignore dist folder as input

Coverage remained the same at 100.0% when pulling b98a3e99ee888f6adf16044e0a35366653fa5a1f on ts-ignore-dist into 14e8668585d4f6431df3f0af66de5610b4a3d0bb on master.


ivy-completing-read in special circumstances: args out of range

I don't know how many ways there are to trigger this but on Emacs master with DOOM Emacs (not with emacs -Q)
This triggers the error:
(setq prompt (concat "[" (propertize "xxx" 'face 'font-lock-comment-face) "] abcdefghlmnopqr: "))
(ivy-completing-read prompt '(foo bar baz))

This does not:
(setq prompt (concat "[" "xxx" "] abcdefghlmnopqr: "))
(ivy-completing-read prompt '(foo bar baz))

Only noticed this because suddenly I couldn't jump to maildirs in mu4e any longer.

I downgraded Emacs and the had to delete .local/packages due to incompatible bytecode. And now that Emacs same emacs doesn't have the issue any more.
Sorry for the noise.


refactor: add more linters

refactor: error handling
refactor: move types to own package
refactor: move queries.go to persistence
test: add migration tests

I like you are adding a lot of linters, and fix the issues.
Maybe you could have split the PR in two:

one for the linters, and their fixes
one for the migration

It's OK, but it's a bit surprising to see them mixed. I mean it's uneasy to review the code related by the migration.
There are multiple commits, but here I'm afraid with so many changes, people might not review these specific changes
BTW, I'll  try to see if there are other linters you could enable

I like you are adding a lot of linters, and fix the issues.
Maybe you could have split the PR in two:

one for the linters, and their fixes
one for the migration tests

It's OK, but it's a bit surprising to see them mixed. I mean it's uneasy to review the code related to the migration tests
There are multiple commits, but here I'm afraid with so many changes, people might not review these specific changes.
You know the meme:

50 lines changed: 100 comments
5000 lines changed: LGTM 👍

BTW, I'll try to see if there are other linters you could enable

Yeah, I agree. A split could've definitely been better. A small change snowballed into a pretty major refactor.
I'll keep that in mind for the future 👍
And, yeah, the meme is definitely spot on :D

Thanks for the review, @ccoVeille!


Critical issue not mentioned in Page

There is a critical issue in the page that is not mentioned and I was not able to solve: what if the data in the SQLite is critical and should not be bound to the sandbox but must survive the App?
From all the test I did I was NOT able to create the SQLite database file in the "Documents Folder" of the user.
Reading from MS documentation UWP application should NOT address directly the files/folders but use StorageFolder and Storage FIle
(references: https://docs.microsoft.com/en-us/uwp/api/windows.storage.storagefolder
https://blogs.msdn.microsoft.com/wsdevsol/2012/12/04/skip-the-path-stick-to-the-storagefile/)
Even if I've configured correctly all the File access properties and bindings
(https://docs.microsoft.com/en-us/windows/uwp/files/file-access-permissions
https://docs.microsoft.com/en-us/uwp/schemas/appxpackage/uapmanifestschema/element-uap-capability)
In fact I'm able to enumerate and read the file in the Library I'm not able to perform the SQLiteConnection
Using db As SqliteConnection = New SqliteConnection("Filename=" ...))
No matter what I try to do there.
I've found a document "Using SQLite Databases in Any Folder in WinRT" (https://www.codeproject.com/Articles/879846/Using-SQLite-Databases-in-Any-Folder-in-WinRT) that explains it is not possible from SQLite3 but has to do with custom/not supported code.
If this si true is a critical issue as my application handles very critical data that must not be deleted in the case of an app removal.
So I must be able to have the db file in a statefull storage outside of the sandbox and I would even put it in an OneDrive folder.
A workaround that is not feasible in terms of performance would be perform a file copy from the sandbox app storage location to the documents folder.
On the other side I tried to use SQL Server LocaDB (https://blogs.msdn.microsoft.com/jerrynixon/2012/02/26/sql-express-v-localdb-v-sql-compact-edition/) but I received an error that is NOT supported for UWP. In fact this section only mentions to connect with a SQL Server.
So how I can I solve the critical issue I face?
Am I doing something wrong? is it possible to have a code sample of an UWP app opening the data from a file in the User/Documents folder?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 859b309d-ce6e-b518-75fa-54122d43f00c
Version Independent ID: 1eee31ea-4e11-02e3-a9f4-c2c352d3f8c6
Content: Data access - Windows UWP applications
Content Source: windows-apps-src/data-access/index.md
Product: uwp
Technology: data-and-files
GitHub Login: @lastnameholiu
Microsoft Alias: alholiu

Also note that several articles mention that LocalDB is for single use only and not production and that for real app SQLExpress should be used... but this raises the issue on how to distribute SQLExpress within an UWP app or automatically install it as prerequisite in the distribution via marketplace.
So again is not a feasible solution. The best is to have SQLite with the DB file in a user folder.

Thanks for taking the time to let us know about this and I sincerely apologize for the delayed response. Though the scope of our feedback channel here on GitHub covers specific documentation fixes, I can help redirect you to the right support channel to get an answer to your question. The community of experts and Microsoft Engineers over at Microsoft Q&A offer timely answers to a multitude of technical questions surrounding windows-uwp.
If you do create a thread over at Microsoft Q&A, it would be fantastic if you could share that link here so I can track the progress and potentially incorporate the technical details into our documentation. Though I'm marking this Issue as closed now, please treat this thread as an open thread for follow-ups. Thanks!


Add pagination in using GitHub API

Signed-off-by: divyansh42<EMAIL_ADDRESS>
Description

Related Issue(s)
Closes: #43

Checklist

[ ] This PR includes a documentation change
[x] This PR does not need a documentation change

[ ] This PR includes test changes
[x] This PR's changes are already tested

[x] This change is a patch change
[ ] This change is a minor change
[ ] This change is a major (breaking) change

Changes made

In the 'known versions' test, can you add at least one old version that would have be paginated back to find? Like the yq version you added to the test file.

In the 'known versions' test, can you add at least one old version that would have be paginated back to find, and put a comment explaining why this version was picked.
Like the yq version you added to the test file.

okay, that makes sense.

In the 'known versions' test, can you add at least one old version that would have be paginated back to find, and put a comment explaining why this version was picked.
Like the yq version you added to the test file.

okay, that makes sense.


Test backup and restore with marketplace apps

Apps to be covered

[x] Taiga
[x] Cryptpad
[x] Mattermost
[x] Blog
[x] Website
[x] Wiki
[x] Gitea
[x] Peertube
[x] ZeroCI
[x] ETCD
[ ] DigiByte
[x] Presearch
[ ] Matic
[ ] Discourse

Test Steps
1- Deploy VDC
2- Deploy the app from VDC marketplace
3- Take a backup from VDC settings (this will create 2 backups (config and vdc))
4- Delete the app.
5- Restore the backups (config and vdc) that have been taken.
6- Wait about 5 mins, the app should be back.

Taiga verified.

Mattermost, Website, , Gitea, Peertube, ZeroCI, ETCD and Presearch verified

We also need to test discourse

Discourse verified

Test Steps conducted for issue verification
[] 1- Deploy VDC
[] 2- Deploy the app from VDC marketplace
[] 3- Take a backup from VDC settings (this will create 2 backups (config and vdc))
[] 4- Delete the app.
[] 5- Restore the backups (config and vdc) that have been taken.
[] 6- Wait about 5 mins, the app should be back.


settings: Set min width of role column.

We set minimum width for role column in users list, deactivated users list and bots list such that role value always fits in one line.
Fixes #23218.

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Hm, this is definitely an improvement, but it doesn't quite fix it for Russian:

Also, I wonder if we can give emails a bit more space by taking some width from the name column?


Question: How do we switch on the toggles under the Experiments section of the Game Settings?

I've added some addons that require some of the Experiments toggles to be switched on (eg: https://www.curseforge.com/minecraft/mc-addons/hihiirokane-addon-ii-for-bedrock-edition requires:

Holiday Creator Features
Creation of Custom Biomes and
Additional Modding Capabilities

I can't work out how to switch these on using the environment variables. They seem to be world specific. Is there a way to get a world where they are switched on, or where we can switch them on using the console interface?

I don't believe that "Experiments" is supported in the server version directly. When searching I came across this article that recommends creating the world locally with Experiments enabled and then uploading it to the server.

I don't believe that "Experiments" is supported in the server version directly. When searching I came across this article that recommends creating the world locally with Experiments enabled and then uploading it to the server.

Yes, I've read a few like that, and worked out that it's world-specific.
Unfortunately we only have the Minecraft client on the Switch, which is effectively a closed box. There's no way to get data off of it without doing some serious hackery, which apparently Nintendo are now automatically identifying and banning your device 🙁
Can I ask a big favour? Do you think you could create a template world with the switches enabled that I could download and use?! I'd be very grateful!
Alternatively I'm going to have to analyse the world dat file in hexfiend or similar and try to work out where the switches are set, which may take a while!
Thanks for getting back to me on it, and Happy New Year!

Yes, I've read a few like that, and worked out that it's world-specific.
Unfortunately we only have the Minecraft client on the Switch, which is effectively a closed box. There's no way to get data off of it without doing some serious hackery, which apparently Nintendo are now automatically identifying and banning your device 🙁
Can I ask a big favour? Do you think you could create a template world with the switches enabled that I could download and use?! I'd be very grateful!
Alternatively I'm going to have to analyse the world dat file in hexfiend or similar and try to work out where the switches are set, which may take a while!
Thanks for getting back to me on it, and Happy New Year!

FYI I also found this: https://bugs.mojang.com/browse/BDS-3265
According to the Level format the values are bytes. I might try fiddling with a few values to see what I can do.

FYI I also found this: https://bugs.mojang.com/browse/BDS-3265
According to the Level format the values are bytes. I might try fiddling with a few values to see what I can do.

Nevermind, I got hold of a world from somewhere else. In case you want to use it, I can confirm that it comes with the experimental features all switched on:
World.zip


Revert "[4.1] Stricter enforcement of the "large space" heuristic"

Reverts apple/swift#13438
This PR caused some projects to fail the build. I will try to come up with reduced test-case and re-open the JIRA.

/cc @CodaFi

I think I know what these projects might be... all the same the source compatibility break should be discussed because this is a case where the old code demonstrably allows malformed code through to SILGen.

@CodaFi Malformed in the sense that we're not always diagnosing not-fully-covered switches, or in some other sense?

In the sense that SILGen currently inserts a pessimistic fatalError default branch that causes surprises to say the least.  It’s not a full miscompile in that sense but it’s still undefined behavior.

I'm not seeing a fatalError inserted in the original test case from https://bugs.swift.org/browse/SR-6316, but I do see a crash if the code is optimized. It's not great behavior
Let's back this out of 4.1 for the moment and then discuss in https://bugs.swift.org/browse/SR-6652 whether we should adjust the heuristic for when it bails out.


Move to Serde

Serde is the future of Rust serialization.
And it will solve our problems with Optional, making that type unnecessary!
https://github.com/serde-rs/json/issues/21
This would solve #18.

Whoa that's awesome! We should definitely move to Serde!

Do we want to use the stable or nightly version of the Serde integration? Using nightly seems simpler due to the compiler plugin.

Yeah, but then we only support Nightly Rust.
I'd go with the stable integration (code generation).

@rnestler how's your branch coming along?

@rnestler serde 0.8.0 was released.

@rnestler PING! :laughing:
There are a few things I'd like to implement, but they're blocked by the Serde branch.

@dbrgn Let's take a look at it on Monday evening at coredump :smiley:


Latest Update (3.0.0) Causing TypeError:L  Cannot read properties of undefined

Updated Plugin today to 3.0.0 and found the plug in child bridge restarting repeatedly following this error. Rolled back to previous version 2.14.3

Quick update.  rolling back to previous version doesn't resolve issue. had to disable plugin.

Just open settings and save it

Still seeing the same message after opening and saving the plugin's settings dialog.

Okay,  I had to open view all of the settings in the dialog for the plug in and then fully restart Homebridge to resolve this error.


Split-up RPCs into dedicated modules

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This makes the maintainability of the overall code easier and reduces the amount of code within one file.
Which issue(s) this PR fixes:

None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

Builds on top of #32

Ready for review, PTAL @mrunalp

/lgtm


New features

Add gradient color selection feature as alternative for pre defined colorbewers
Add bucket number limitation from 1 to 18 for gradient colors
Add bucket number limitation between min and max buckets in from set for pre defined colorbewers
X axis labels properties
Y axis labels properties
Add tolltips by tooltip services
Fix bug when left upper cell draws on axis label position if first value in the category is null
Left and top margins of grid depend from height and width values of axis labels
Add property to limit number of symbols in Y axis labels text
Add fond settings for axis labels and data labels in cells
Cells scale depends on text size
Add auto-scroll if chart doesn't fit into viewport

@zBritva,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Changes Unknown when pulling ac7232c18d9c7fc8f73a1c8ebe86a8c084afea24 on zBritva:feature_fix into ** on Microsoft:master**.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: zBritva sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Changes Unknown when pulling ef943c6c0eaac2c92f5fadf480ccad56f46e590a on zBritva:feature_fix into ** on Microsoft:master**.

Changes Unknown when pulling 0efec6b4615c4bf5b4b8403740376d1fc9e5c545 on zBritva:feature_fix into ** on Microsoft:master**.

Changes Unknown when pulling f92083b8daec222a0a64fc58aa40c0c204ba971f on zBritva:feature_fix into ** on Microsoft:master**.

Changes Unknown when pulling 940c2c1b07527b8c6b95b51b542f3d55d44bb1ab on zBritva:feature_fix into ** on Microsoft:master**.

Changes Unknown when pulling eb83ae23f78ed5e20149358f80b4b32b80ad916e on zBritva:feature_fix into ** on Microsoft:master**.

Changes Unknown when pulling ceff9825e8445c89a3b59d54c7b8d5a28702dbdf on zBritva:feature_fix into ** on Microsoft:master**.


Is it possiable to support vue2？

As an official project, we don't have enough energy to support Vue 2. But you can try the community project. https://github.com/Thy3634/vue2-repl


enhance: Array schema pushes through 'found'

Motivation

Solution

Open questions

This has no meaning as failing validation marks 'deleted', which has higher prescedence than not found. Furthermore, array infers undefined all the time therefore found will never be used here.


feat: expose root/subtask through listr and use it directly

:tada: This PR is included in version 2.0.7 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.7 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Explore reducing pyinstaller file size

Compiled binary is 300MB, how can we shrink it? See tree shaking from JS land

After some initial research, the only current tree shaking code in Python is Treeshaker. However, this tool hasn't been updated in 3 years and requires a lot of specific input.
Other options to reduce file size:

Compress the files using 7-Zip or some other compressor

Con: could corrupt the files
Note: UPX is popular, however, there are many corruption issues which is why PyInstaller only partially uses it

Use a different tool to package and distribute OpenAI instead of PyInstaller Nuitka

Con from Slant:

needs configuration tweaks to work with some third-party packages, [or] could cause app crashes, or fail to include dependencies

Blocked until https://github.com/OpenAdaptAI/OpenAdapt/issues/350 is resolved


Javascript errors under Node.js setups

"Cannot read X of undefined" and other JS errors under Node.js setups (single server node and Bob multiserver).
More info from mauloop via GoogleGroups: https://groups.google.com/forum/#!topic/tiddlywiki/ZiFBwS_hplE

Hi, Joshua.
I run into troubles running Tiddlywiki with both Tiddlymap and JsonMangler plugins. I tested three different setups:
Tiddlywiki 5.1.19 on Node.js with plugins loaded via tiddlywiki.info
Tiddlywiki 5.1.19 on Node.js with plugins addes as tid files (dragging links to plugin tiddlers from the demo web sites)
Tiddliwiki 5.1.19 as a local stand-alone html file
Both setups 1 and 2 don't work. As soon as I click on the map sidebar the following error is raised
https://groups.google.com/group/tiddlywiki/attach/18e55ee9f62ff/tmap+jsonmang-err1.JPG
After that clicking on any other tab results in an error like this one:
https://groups.google.com/group/tiddlywiki/attach/18e55ee9f62ff/tmap+jsonmang-err2.JPG
These are the messages logged in the browser console in the meantime:
 TiddlyWebAdaptor: Getting status
$:/core/modules/utils/logger.js:33  TiddlyWebAdaptor: Status: {"username":"","anonymous":true,"read_only":false,"space":{"recipe":"default"},"tiddlywiki_version":"5.1.19"}
$:/core/modules/utils/logger.js:33  syncer-browser-tiddlyweb: Retrieving skinny tiddler list
2(index):1 Failed to load resource: the server responded with a status of 404 (Not Found)
$:/core/modules/utils/logger.js:33  syncer-browser-tiddlyweb: Dispatching 'save' task: $:/StoryList
(index):11152 Uncaught TypeError: Cannot read property 'to' of undefined
$tw.utils.error @ (index):11152
$:/plugins/felixhayashi/tiddlymap/js/lib/utils/tmap:208 Uncaught TypeError: Cannot read property 'to' of undefined
    at Object.groupByProperty ($:/plugins/felixhayashi/tiddlymap/js/lib/utils/tmap:208)
    at Adapter.getAdjacencyList ($:/plugins/felixhayashi/tiddlymap/js/Adapter:215)
    at Adapter.getNeighbours ($:/plugins/felixhayashi/tiddlymap/js/Adapter:292)
    at Adapter.getGraph ($:/plugins/felixhayashi/tiddlymap/js/Adapter:428)
    at MapWidget.rebuildGraphData ($:/plugins/felixhayashi/tiddlymap/js/widget/MapWidget:812)
    at MapWidget.rebuildGraph ($:/plugins/felixhayashi/tiddlymap/js/widget/MapWidget:752)
    at MapWidget.initAndRenderGraph ($:/plugins/felixhayashi/tiddlymap/js/widget/MapWidget:980)
    at MapWidget.renderFullWidget ($:/plugins/felixhayashi/tiddlymap/js/widget/MapWidget:462)
    at MapWidget.render ($:/plugins/felixhayashi/tiddlymap/js/widget/MapWidget:393)
    at eval ($:/core/modules/widgets/widget.js:374)
$:/core/modules/utils/logger.js:33  syncer-browser-tiddlyweb: Retrieving skinny tiddler list
(index):11152 Uncaught NotFoundError: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.
$tw.utils.error @ (index):11152
$:/core/modules/widgets/reveal.js:45 Uncaught DOMException: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.
    at RevealWidget.render ($:/core/modules/widgets/reveal.js:45:9)
    at RevealWidget.Widget.refreshSelf ($:/core/modules/widgets/widget.js:436:7)
    at RevealWidget.refresh ($:/core/modules/widgets/reveal.js:193:10)
    at eval ($:/core/modules/widgets/widget.js:446:27)
    at Object.$tw.utils.each (http://localhost:8080/:11089:12)
    at ListItemWidget.Widget.refreshChildren ($:/core/modules/widgets/widget.js:445:12)
    at ListItemWidget.refresh ($:/core/modules/widgets/list.js:317:14)
    at ListWidget.handleListChanges ($:/core/modules/widgets/list.js:224:38)
    at ListWidget.refresh ($:/core/modules/widgets/list.js:145:17)
    at eval ($:/core/modules/widgets/widget.js:446:27)
$:/core/modules/utils/logger.js:33  syncer-browser-tiddlyweb: Retrieving skinny tiddler list
$:/core/modules/utils/logger.js:33  syncer-browser-tiddlyweb: Retrieving skinny tiddler list
$:/core/modules/utils/logger.js:33  syncer-browser-tiddlyweb: Retrieving skinny tiddler list

Config 3 seems to be working. Unfortunately I work with many wikis served by Node.js and config 1 is my favourite.
The wikis I used to test are fresh installation with no tiddlers other than the ones coming from the vanilla edition and the ones related to the plugins. Every test has been executed following the same steps in this order:
install Tiddlymap (with dependencies)
Reload both server and browser page
Open the map sidebar tab
Switch some times between default and live view
Install JsonMangler (with dependencies)
Repeat steps 2-4
In all of the tests, troubles came up after step 5 (actually I am a long time user of Tiddlymap on Noder.js and I have never seen a behaviour like this before).
I also tried to remove Tiddlymap end reinstall it after Jsonmangler. It did not solve, but the TM plugin raised the "first run message" popup every time I reload the browser, despite I always  clicked the OK button.
These are all of the infoes I was able to collect. I have no much JS developing experience to debug further. It is very frustrating since JsonMangler is very promising and could help me a lot. I hope @felixhayashi will be notified of this thread, since he could probably give us some useful suggestions.
Hope this feedback could help to improve the plugin. Best regards,
)+(au

This seems to have been caused by one of the helper libraries (alphanum.js) adding a prototype method to the Array object type. This is a BAD IDEA as for (var x in arr) loops will also iterate these custom properties, breaking other people's code.
Commented out the custom protoype method, and made sure that 'alphanum' is required in each js file that uses it's methods.

Closed. 2.0.4


Bug report- Role mapping problem

Is there an existing issue for this?

[X] I have searched the existing issues

Community Note

Please vote on this issue by adding a :thumbsup: reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Version of the module you are using
5.7.2
Rover Version
aztfmod/rover:1.4.6-2305.1701
Terraform Version
No response
AzureRM Provider Version
No response
Affected Resource(s)/Data Source(s)
role_mappings
Terraform Configuration Files
role_mapping = {
  built_in_role_mapping = {
    aks_clusters = {
      cluster_re1 = {
        "Azure Kubernetes Service Cluster Admin Role" = {
          managed_identities = {
            keys   = ["cicd_msi1"]
            lz_key = "identity_level2_dev"
          }
        }
      }
    }
    application_gateway_platforms = {
      agw = {
        lz_key = "network_dev"
        "Contributor" = {
          aks_ingress_application_gateway_identities = {
            keys = ["cluster_re1"]
          }
        }
        "Reader" = {
          aks_ingress_application_gateway_identities = {
            keys = ["cluster_re1"]
          }
          azuread_groups = {
            keys   = ["contribute"]
            lz_key = "identity_level2_dev"
          }
        }

      }
    }

Expected Behaviour
I have just upgraded to 5.7.2 and now , when I run the plan, it just crashs.
It seems that the role mapping doesn't work anymore
I was in version 5.6.x before this and everything was deployed correctly
Error: Invalid index

  on /home/vscode/.terraform.cache/prodinfra/rover_jobs/20230810123733184275662/modules/solution/roles.tf line 23, in resource "azurerm_role_assignment" "for":
  23:   principal_id         = each.value.object_id_resource_type == "object_ids" ? each.value.object_id_key_resource : each.value.object_id_lz_key == null ? local.services_roles[each.value.object_id_resource_type][var.current_landingzone_key][each.value.object_id_key_resource].rbac_id : local.services_roles[each.value.object_id_resource_type][each.value.object_id_lz_key][each.value.object_id_key_resource].rbac_id
    ├────────────────
    │ each.value.object_id_key_resource is "cluster_re1"
    │ each.value.object_id_resource_type is "aks_ingress_application_gateway_identities"
    │ local.services_roles is object with 60 attributes
    │ var.current_landingzone_key is "aks_dev"

Actual Behaviour
I expected the plan to work. The plan / apply worked before 5.7.2 and the tfvars didn't change
Is the resource aks_ingress_application_gateway_identities still used ?
Steps to Reproduce
No response
Important Factoids
No response
References
No response

Hello @LaurentLesle , @arnaudlh ,
Any idea why this has changed with aks_ingress_application_gateway_identities ?
Regards


support

Will this library be supported now?

This library hasn't been updated in 4 years. Consider using ExpandableFab.
It's modern, highly customizable, written in Kotlin (but useable from Java and includes full JavaDoc) and orientation aware (provides the ability to show different options between portrait and landscape orientations). Also comes with an example app to help you easily see different use cases without any coding.
Let me know if you try out ExpandableFab and have any questions.


Is it possible to use 192.168 IP address?

Hi... CF Dev seems to use <IP_ADDRESS> on my computer for app instance. Here is the problem:  I can curl the app, but my browser cannot connect to this address. It gives me network error.
After a bit network tracing, I found the root cause: The DNS lookup works fine. But In my company's network, we use PAC file for proxy setting. In the file, 10.144.* is not included as bypass. Hence browser always forwards the dev.cfdev.sh to company proxy server which of course fails.
I guess I can mess up around the PAC file, but I prefer not. Ideally if I can change the IP to 192.168.* range , it will work as most of the company's proxy setting bypass this range. ( i guess 10.* range is too wide, so it goes with specific sub range).  This also explains why I did not see this issue when using PCFdev since they use 192.168 range.
Is it possible? There might be a problem for dev.cfdev.io DNS setting.

Hey @emailtowalter thanks for reaching out. Let me look into this further. I will get back to you with a definitive answer as to whether we have a solution for you at this time.

thanks for getting back to me. Too bad. I am sure someone in the future will have the same problem.


mill

Wanted
Originally posted by @FAVE01 in https://github.com/eveem-org/panoramix/pull/60

This issue looks like it was opened in error.


undefined return value of set connection string task for mac

We are going to release vscode extension. See what IoT Workbench can do. Move issue to backlog for now.

No more change in installation script later.


RobotHelper.isWithingRangeOfTarget does not work for small targets.

The present implementation cannot be satisfied for zero (or near-zero) targets.
 public static boolean isWithinRangeOfTarget(double currentValue, double targetValue, double acceptancePercent) {
        var upperValue = targetValue + (targetValue * acceptancePercent);
        var lowerValue = targetValue - (targetValue * acceptancePercent);
        return currentValue >= lowerValue && currentValue <= upperValue;
    }
With a target value of zero, the upper and lower bounds will also be zero, resulting in a zero-width range to be satisfied.  Also, it implies that larger targets get a larger range for the same acceptance percentage.  E.g. the shoulder position for the AMP is a high value and needs a smaller acceptancePercentage, while the SPEAKER shot angle is small and therefore needs a larger acceptancePercent to get the same absolute allowed angle error.
Suggest changing acceptance criteria to an error band in the same units as the target.

We should just use the "IsNear" method from WPILib's MathUtil - https://github.wpilib.org/allwpilib/docs/release/java/edu/wpi/first/math/MathUtil.html#isNear(double,double,double)
It meets this static threshold criteria AND supports continuous inputs.

We'll need to test a few thresholds but replaced IsWithinRangeOfTarget with IsNear in relevant places - https://github.com/FRC-1250/Team-1250-Crescendo2024/commit/3ad776eedaf61e3cce18ff2a936a396a7e3e4fc2

Seemed to work for FireNote checks. Verify that this works again for ShoulderPosition after fixing #36.