Unambiguous Advertising.

Issue summary
This package does not do what it advertises, and apparently has no intention of doing so.
System informations
For the 4.0 (php5) version of the system. The main page examples fail to work.
There is no Uri\create or Uri\merge_query functions. There may be ways to get "equivalent" code to work, but it is not trivial to figure out how, given the documentation, which makes no mention that I can find of "merge_query" for instance.
For the 5.0 (php7) version of the system, the composer based installation that is advertised in the main page fails because an alpha package is required as part of installation (this already has its own ticket).
There is a bug labeled "wont fix" that involves uris that function in common browsers. The reason for not supporting this is that those urls are not RFC3986/RFC3987 compliant. However, they are commonly used in the real world.
The main page advertises "Modern API to process URI in PHP." But what you mean is "Modern API to process RFC3986/RFC3987 compliant URI in PHP, you will have to write your own layer to handle real-world URI". Your main page advertises "RFC3986 compliant" as a "feature" but it should say "RFC3986 exclusive" as a "project scope limitation".
Expected result
All of the code listed on this page: https://uri.thephpleague.com/
should work as written. Including the installation instructions.
Everyone who reads the basic "goal" of your project is going to get the wrong idea about what your relationship to the  RFC3986/RFC3987 standards are. Be upfront about this very substantial limitation. I would have looked elsewhere immediately about this information.
Actual result
Spent hours trying to get your code to work merely as advertised, logged to github to find two bugs which are both indications that your project feels no obligation to work as advertised.
I applaud the fact that you are releasing code. And I am willing to work with code that is rough around the edges, and would even be willing to contribute to projects that are in that state. But you clearly have a beta project here that you are advertising as stable and reliable. Please do not waste my time or others by pretending to be what you are not.
-FT

@ftrotter I understand your frustration but I will not tolerate your remarks

Please do not waste my time or others by pretending to be what you are not.

This is an open source project which by definition contains flaws and can be improved and I acknowledge this fact. Instead of complaining did you offer any help or support to improve the current codebase ? No
Currently you are the one wasting the maintainer time by insinuating things which are not facts. A better use of your time would have been:

creating issue for missing feature or fixing bugs.
creating PR for missing feature or fixing bugs.
engaging on a more constructive discussion with the maintainer if the two above can not be done because everyone has something better to do.

If you had done any of the following or just correctly read the documentation, you would have known that:

The origin of this library is because PHP's internal functions do not respect RFC3986.
Version 4.0 is EOL
Works in underway to replace the package responsible for the composer error shipped by version 4.0 and 5.0.

Last but not least, this is a Open Source Project with a MIT License this means that your are free to use it or not.

@ftrotter

This package does not do what it advertises, and apparently has no intention of doing so.

What do you expect people to do when they read this? Do you expect people to spend their free time and help you out with your issue? You LITERALLY don't have to use this package, nobody forces you to "waste your time". You pretend to speak on behalf of an entire group of people, you don't. If all you add to open-source are comments like these, you only reduce the value of communities.
Since this is just a rude comment I'm going to close this issue.


JaonIgnore attributes are not ignores

Describe the bug
Since upgrade to v18, properties in verified classes which are marked wit ]KspmIgnore] of NewtonSoft are not ignored anymore.
Minimal Repro
Have a property
    /// <summary>
    /// logger
    /// </summary>
    [JsonIgnore]
    public ILogger<Client> ClientLogger { get; set; }

Then the verify started to output this property in received file, while in version prior to 18 it didn't.
    "Field: (6,6)": 182,
    "Field: (6,7)": 195
  },
  "ClientLogger": {}
}

Prior to 18:
    "Field: (6,6)": 182,
    "Field: (6,7)": 195
  }
}

you need to move to Argon.JsonIgnore. or u can use https://github.com/VerifyTests/Verify/blob/main/docs/serializer-settings.md#ignoring-a-type or https://github.com/VerifyTests/Verify/blob/main/docs/serializer-settings.md#ignore-member-by-expressions


BC break

#22 has introduced a BC break, forcing people to switch to "fsi/admin-bundle": "~2.0.*@dev".

dont create issues if you have no idea what are talking about. admin-positionable-bundle master has no stable version how anything can be considered then as a BC breake?

Well it has an alias 1.1.x-dev doesn't it? So it's meant to work with admin-bundle branch 1.1? Or am I mistaken? Because right now I can't update my dependencies because this only package demands admin in 2.0.*@dev.

Alias means that you are using master and master is not stable so there is no BC Break here. Update your project to use admin 2.0.*@dev version or downgrade dependency from admin-positionable-bundle to 1.0.0.

@norzechowicz this issue is not about specific project but exists in every project that uses more that one of fsi-open's bundles. We need to leave master branch with 1.1-dev alias in order to allow smooth upgrading of subsequent packages. Your change requires to upgrade versions of all other bundles at once.

Well thats how using unstable bundles ends for projects. We can't keep 1.1-dev on master branch because it will make impossible to use admin-positionable-bundle (and other unstalbe bundles) with most up to date admin-bundle which is the purpose of master branch.
Projects that can't be updated can be locked to specific commit on this branch (one commit before #22) or updated to admin 2.0.@dev (which is not a problem because there are no BC Breakes in 2.0@dev according to 1.1@dev) or downgraded to admin-positionable and admin bundle 1.0. version

Why don't we simply copy the solution from admin bundle? Create a 1.1 branch and make the 1.1-dev point at that branch, which will make the upgrade process much more smooth. We have no idea how long upgrading other packages will take. This way there will be no need to upgrade every project with hard-coded commit hash and once all packages have been updated, you update your dependencies once.

it will also require from you to update composer.json of your project anyway. You gonna need to change admin-positionable-bundle dependency from "dev-master" to "1.1@dev" so how is that different from updating dependency of admin-bundle from "1.1.@dev" into "2.0.@dev"?

My dependency is already 1.1@dev, that's the thing. Also, I am using doctrine extensions bundle, translatable bundle, resource repository bundle etc. which all are dependant on admin bundle in version ~1.1@dev.

All other bundles should also be updated like this one, just for now you should lock to specific commint your project if you realy need to update it now.

Fine, but shouldn't you also change the alias in composer.json to 2.0-dev, like in admin-bundle?


CREATE2

I really like this a lot! It was pretty similar to some code I have that uses create2, so I combined them. What do you think about these changes?
// SPDX-License-Identifier: BSD
// https://github.com/wighawag/clones-with-immutable-args/blob/master/src/Clone.sol + CREATE2
pragma solidity 0.8.11;

contract CloneWithImmutableArgsFactory {
    error CreateFail();

    function cloneCreationCode(address implementation, bytes memory data)
        internal
        pure
        returns (uint256 ptr, uint256 creationSize)
    {
        // unchecked is safe because it is unrealistic for memory ptr or data length to exceed 256 bits
        unchecked {
            uint256 extraLength = data.length + 2; // +2 bytes for telling how much data there is appended to the call
            creationSize = 0x43 + extraLength;
            uint256 runSize = creationSize - 11;
            uint256 dataPtr;
            // solhint-disable-next-line no-inline-assembly
            assembly {
                ptr := mload(0x40)

                // -------------------------------------------------------------------------------------------------------------
                // CREATION (11 bytes)
                // -------------------------------------------------------------------------------------------------------------

                // 3d          | RETURNDATASIZE        | 0                       | –
                // 61 runtime  | PUSH2 runtime (r)     | r 0                     | –
                mstore(
                    ptr,
                    0x3d61000000000000000000000000000000000000000000000000000000000000
                )
                mstore(add(ptr, 0x02), shl(240, runSize)) // size of the contract running bytecode (16 bits)

                // creation size = 0b
                // 80          | DUP1                  | r r 0                   | –
                // 60 creation | PUSH1 creation (c)    | c r r 0                 | –
                // 3d          | RETURNDATASIZE        | 0 c r r 0               | –
                // 39          | CODECOPY              | r 0                     | [0-2d]: runtime code
                // 81          | DUP2                  | 0 c  0                  | [0-2d]: runtime code
                // f3          | RETURN                | 0                       | [0-2d]: runtime code
                mstore(
                    add(ptr, 0x04),
                    0x80600b3d3981f300000000000000000000000000000000000000000000000000
                )

                // -------------------------------------------------------------------------------------------------------------
                // RUNTIME
                // -------------------------------------------------------------------------------------------------------------

                // 36          | CALLDATASIZE          | cds                     | –
                // 3d          | RETURNDATASIZE        | 0 cds                   | –
                // 3d          | RETURNDATASIZE        | 0 0 cds                 | –
                // 37          | CALLDATACOPY          | –                       | [0, cds] = calldata
                // 61          | PUSH2 extra           | extra                   | [0, cds] = calldata
                mstore(
                    add(ptr, 0x0b),
                    0x363d3d3761000000000000000000000000000000000000000000000000000000
                )
                mstore(add(ptr, 0x10), shl(240, extraLength))

                // 60 0x38     | PUSH1 0x38            | 0x38 extra              | [0, cds] = calldata // 0x38 (56) is runtime size - data
                // 36          | CALLDATASIZE          | cds 0x38 extra          | [0, cds] = calldata
                // 39          | CODECOPY              | _                       | [0, cds] = calldata
                // 3d          | RETURNDATASIZE        | 0                       | [0, cds] = calldata
                // 3d          | RETURNDATASIZE        | 0 0                     | [0, cds] = calldata
                // 3d          | RETURNDATASIZE        | 0 0 0                   | [0, cds] = calldata
                // 36          | CALLDATASIZE          | cds 0 0 0               | [0, cds] = calldata
                // 61 extra    | PUSH2 extra           | extra cds 0 0 0         | [0, cds] = calldata
                mstore(
                    add(ptr, 0x12),
                    0x603836393d3d3d36610000000000000000000000000000000000000000000000
                )
                mstore(add(ptr, 0x1b), shl(240, extraLength))

                // 01          | ADD                   | cds+extra 0 0 0         | [0, cds] = calldata
                // 3d          | RETURNDATASIZE        | 0 cds 0 0 0             | [0, cds] = calldata
                // 73 addr     | PUSH20 0x123…         | addr 0 cds 0 0 0        | [0, cds] = calldata
                mstore(
                    add(ptr, 0x1d),
                    0x013d730000000000000000000000000000000000000000000000000000000000
                )
                mstore(add(ptr, 0x20), shl(0x60, implementation))

                // 5a          | GAS                   | gas addr 0 cds 0 0 0    | [0, cds] = calldata
                // f4          | DELEGATECALL          | success 0               | [0, cds] = calldata
                // 3d          | RETURNDATASIZE        | rds success 0           | [0, cds] = calldata
                // 82          | DUP3                  | 0 rds success 0         | [0, cds] = calldata
                // 80          | DUP1                  | 0 0 rds success 0       | [0, cds] = calldata
                // 3e          | RETURNDATACOPY        | success 0               | [0, rds] = return data (there might be some irrelevant leftovers in memory [rds, cds] when rds < cds)
                // 90          | SWAP1                 | 0 success               | [0, rds] = return data
                // 3d          | RETURNDATASIZE        | rds 0 success           | [0, rds] = return data
                // 91          | SWAP2                 | success 0 rds           | [0, rds] = return data
                // 60 0x36     | PUSH1 0x36            | 0x36 sucess 0 rds       | [0, rds] = return data
                // 57          | JUMPI                 | 0 rds                   | [0, rds] = return data
                // fd          | REVERT                | –                       | [0, rds] = return data
                // 5b          | JUMPDEST              | 0 rds                   | [0, rds] = return data
                // f3          | RETURN                | –                       | [0, rds] = return data

                mstore(
                    add(ptr, 0x34),
                    0x5af43d82803e903d91603657fd5bf30000000000000000000000000000000000
                )
            }

            // -------------------------------------------------------------------------------------------------------------
            // APPENDED DATA (Accessible from extcodecopy)
            // (but also send as appended data to the delegatecall)
            // -------------------------------------------------------------------------------------------------------------

            extraLength -= 2;
            uint256 counter = extraLength;
            uint256 copyPtr;
            assembly {
                copyPtr := add(ptr, 0x43)
            }
            // solhint-disable-next-line no-inline-assembly
            assembly {
                dataPtr := add(data, 32)
            }
            for (; counter >= 32; counter -= 32) {
                // solhint-disable-next-line no-inline-assembly
                assembly {
                    mstore(copyPtr, mload(dataPtr))
                }

                copyPtr += 32;
                dataPtr += 32;
            }
            uint256 mask = ~(256**(32 - counter) - 1);
            // solhint-disable-next-line no-inline-assembly
            assembly {
                mstore(copyPtr, and(mload(dataPtr), mask))
            }
            copyPtr += counter;
            // solhint-disable-next-line no-inline-assembly
            assembly {
                mstore(copyPtr, shl(240, extraLength))
            }
        }
    }

    /// @notice Creates a clone proxy of the implementation contract, with immutable args
    /// @dev data cannot exceed 65535 bytes, since 2 bytes are used to store the data length
    /// @param implementation The implementation contract to clone
    /// @param data Encoded immutable args
    /// @return instance The address of the created clone
    function clone(address implementation, bytes32 salt, bytes memory data)
        external
        returns (address instance)
    {
        (uint creationPtr, uint creationSize) = cloneCreationCode(implementation, data);

        // solhint-disable-next-line no-inline-assembly
        assembly {
            instance := create2(0, creationPtr, creationSize, salt)
        }

        // if the create failed, the instance address won't be set
        if (instance == address(0)) {
            revert CreateFail();
        }
    }

    /// @dev Returns the address where a clone of implementation will be deployed by this factory.
    function computeCloneAddress(address implementation, bytes32 salt, bytes memory data) external view returns (address predicted, bool exists) {
        (uint creationPtr, uint creationSize) = cloneCreationCode(implementation, data);

        bytes32 creationHash;
        // solhint-disable-next-line no-inline-assembly
        assembly {
            creationHash := keccak256(creationPtr, creationSize)
        }

        predicted = computeAddress(salt, creationHash, address(this));
        exists = predicted.code.length > 0;
    }

    /// @dev Returns the address where a contract will be stored if deployed via CREATE2 from a contract located at `deployer`.
    function computeAddress(
        bytes32 salt,
        bytes32 bytecodeHash,
        address deployer
    ) internal pure returns (address) {
        bytes32 _data = keccak256(abi.encodePacked(bytes1(0xff), deployer, salt, bytecodeHash));
        return address(uint160(uint256(_data)));
    }
}

appreciate this -- implemented it in this fork, along with simple receive() directly inside the clone that only emits the event ReceiveETH(amount) (no DELEGATECALL to avoid gas issues w solidity transfers/sends)
happy to open a PR if there's interest

I really like including deterministic address to CWIA - should we add optionality between using create and create2?

in my fork I use clone for create & cloneDeterministic for create2(+ predictDeterministicAddress) -- feel like it works pretty well

nice, makes sense. I created a PR which just toggles between create and create2 based on whether a salt hash is provided https://github.com/wighawag/clones-with-immutable-args/pull/11

done with : https://github.com/wighawag/clones-with-immutable-args/pull/19


[FEATURE REQUEST] - Multiple pages in You May Like directory.

Right now, there are 20 entries, of songs/videos in the You May Like directory, I would like if there were 2 pages with 10 entries each cause otherwise it looks very clogged on one page if you get what I mean, so there can be like a button that if the user taps it goes to the next page? This can be done with JS, I believe.
Can you please work on this @TechStudent11?... I need to get this done very urgently.

Do I have to code the HTML part of this as well, and you'll code the JS @TechStudent11, or can this be coded with only Javascript?

I have no idea how to do this, sorry.

I have no idea how to do this, sorry.

No worries!
Maybe you could use some of this logic for the pages though, if it will work? https://stackoverflow.com/questions/42416214/how-do-i-change-multiple-elements-with-same-class-name-using-javascript

Maybe... maybe you should learn how to use JavaScript. It's easy and simple, and it would help a lot.
Anyways back on topic, maybe I could use some of that logic. It might work, but it also might not.

Maybe... maybe you should learn how to use JavaScript. It's easy and simple, and it would help a lot.

Yeah, I should, I've just been postponing it and when I've tried to learn it, I've found it pretty hard.

Anyways back on topic, maybe I could use some of that logic. It might work, but it also might not.
Ok

@TechStudent11 Please refer to:
Pagination in Javascript - https://www.youtube.com/watch?v=IqYiVHrO2U8
Repo - https://github.com/TylerPottsDev/vanillajs-pagination

The thing is that in this case, I need this + hyperlinks to work

@TechStudent11 I can get the main stuff working, I just need help with linking hyperlinks to the consted items.... Can you help with this?

@TechStudent11 I can get the main stuff working, I just need help with linking hyperlinks to the consted items.... Can you help with this?

Done, I've added the pagination, all I need done now is as follows:

hyperlink the youtube url for the songs
open hyperlink of youtube url of the songs in a new tab

Hope you can do the above @TechStudent11

Deploy Preview: https://pagination--mogulchristmas.netlify.app/you-may-like/

@TechStudent11 I can get the main stuff working, I just need help with linking hyperlinks to the consted items.... Can you help with this?

Done, I've added the pagination, all I need done now is as follows:

hyperlink the youtube url for the songs
open hyperlink of youtube url of the songs in a new tab

Also, if possible I would like if the videos can be purple colour instead of red.
Hope you can do the above @TechStudent11
Please work in the branch pagination: https://github.com/KendallDoesCoding/mogul-christmas/tree/pagination

Awaiting your reply @TechStudent11

Deploy Preview: https://pagination--mogulchristmas.netlify.app/you-may-like/

That's impressive. What do you need me to do? I'm sure you can do it yourself. You can Google how to do things, not coming to me or someone else on GitHub.

I need done now is as follows:

hyperlink the youtube url for the songs
open hyperlink of youtube url of the songs in a new tab

Also, if possible I would like if the videos can be purple colour instead of red.

I've searched so many times but can't find anything on Google, ig people don't do stuff like this project.
I need done now is as follows:

hyperlink the youtube url for the songs
open hyperlink of youtube url of the songs in a new tab

Also, if possible I would like if the videos can be purple colour instead of red.
If you find tutorials and if you can link anything, I can try doing it myself.

I'll see what I can do.

I'll see what I can do.

Thanks a lot! I need it done as soon as possible.

Do you think what I need done is possible tho @TechStudent11 ?

Yeah, ofc

Yeah, ofc

Ok cool, but ig it's hard to get setup?

@TechStudent11 Can you get this done by this week, preferably by tomorrow or day-after? I need this done urgently... Thanks

This might help but I can't understand it:
https://stackoverflow.com/questions/70890297/add-href-to-const-value

Working 👍🏾

Working 👍🏾

Thanks a lot 😃 !
I'll just do a few tweaks and merge into main in a bit.

Done in release 17.4.0


Adding @ddddyyyy to all-contributors

@all-contributors please add ddddyyyy for maintenance

@all-contributors please add ddddyyyy for maintenance


[EDMTP-248] Add accordion container and widget, tabs widget

Can one of the admins verify this patch?


Describe the bug
I have followed the indexing from docs , both local search and global search are running fine with commands . but when i am running them with py scripts from the example notebooks it is saying create_final_covariates is missing  . please let me know if there is any fixes . if possible please provide any references on output file formats.
Steps to reproduce
by running .../artifacts file with localsearch example notebook from the repo
Expected Behavior
create_final_covariates file is missing after indexing in artifacts folder
GraphRAG Config Used
default
Logs and screenshots
No response
Additional Information

GraphRAG Version:
Operating System:Ubantu 22
Python Version:3.10
Related Issues:

sloved by setting GRAPHRAG_CLAIM_EXTRACTION_ENABLED to True in .env

You can also turn it on in settings.yaml
claim_extraction:
  ## llm: override the global llm settings for this task
  ## parallelization: override the global parallelization settings for this task
  ## async_mode: override the global async_mode settings for this task
  enabled: true
  prompt: "prompts/claim_extraction.txt"
  description: "Any claims or facts that could be relevant to information discovery."
  max_gleanings: 1

Thanks for updating

Thank you for your response . if possible could you please share any references on how will knowledge graph updated if we add new document . will it rebulid knowledge graph ?

Thank you for your response . if possible could you please share any references on how will knowledge graph updated if we add new document . will it rebulid knowledge graph ?

The same question.


[Documentation] Language specification is pointing to a very old version

Currently language specification points to version 0.8 which is a very old version. This has to be updated to the current released version

Language spec has been removed from the website since the 0.95.0 version


[CROSSDATA-399] Refactor connection management in native execution for MongoDB

Btw, could you, please, include this new command in the documentation: https://stratio.atlassian.net/wiki/display/CROSSDATA/Reference+Guide?

+1

LGTM

+1


Assets inline does not work version 4.3.9

Describe the bug
I create a new project with "vite create" cli, and I saw that vitejs icon weight 1.5k (located in public folder).
I build the project and expected that the icon will be inline in base64.
instead its on the dist folder.

Reproduction
npm create vite@latest
Steps to reproduce
npm create vite@latest
npm run build
System Info
System:
    OS: macOS 13.4.1
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 108.63 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  npmPackages:
    @types/react: ^18.0.37 => 18.2.14
    @types/react-dom: ^18.0.11 => 18.2.6
    @typescript-eslint/eslint-plugin: ^5.59.0 => 5.60.1
    @typescript-eslint/parser: ^5.59.0 => 5.60.1
    @vitejs/plugin-react: ^4.0.0 => 4.0.1
    eslint: ^8.38.0 => 8.43.0
    eslint-plugin-react-hooks: ^4.6.0 => 4.6.0
    eslint-plugin-react-refresh: ^0.3.4 => 0.3.5
    react: ^18.2.0 => 18.2.0
    react-dom: ^18.2.0 => 18.2.0
    typescript: ^5.0.2 => 5.1.6
    vite: ^4.3.9 => 4.3.9

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This is expected. Public directory is a feature for that.
https://vitejs.dev/guide/assets.html#the-public-directory

I moved them to src/assets and still it doesn't inline the svg files. am I missing something?

Vite currently doesn't inline SVG files, you can track the resolution of this issue here:

https://github.com/vitejs/vite/issues/1204


Add wait container for any pod with wait-for annotation

Description
#172351455
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code has security implications.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Hi! If I understand the design correctly, a pod can wait for up to one service? (That is, I can't wait for multiple services?)
Just checking for limitations so I can keep them in mind when actually using this feature.

Hi! If I understand the design correctly, a pod can wait for up to one service? (That is, I can't wait for multiple services?)
Just checking for limitations so I can keep them in mind when actually using this feature.

yes, up to now it's one service only, but maybe @viovanov can expand the story to cover multiple services too.

@mudler let's make it multiple - off the top of my head, routing-api has to wait for nats and uaa.

@viovanov adapted :+1:

@viovanov I think we can merge Concourse test passed but the linting never returned the status (?) :shrug:


Update text description for tfds data action and observation.state

The text description in bridge_dataset/1.0.0/features.json is incorrect.
"action": {
    "pythonClassName": "tensorflow_datasets.core.features.tensor_feature.Tensor",
    "tensor": {
        "shape": {
            "dimensions": [
                "7"
            ]
        },
        "dtype": "float32",
        "encoding": "none"
    },
    "description": "Robot action, consists of [7x joint velocities, 2x gripper velocities, 1x terminate episode]."
},

"state": {
    "pythonClassName": "tensorflow_datasets.core.features.tensor_feature.Tensor",
    "tensor": {
        "shape": {
            "dimensions": [
                "7"
            ]
        },
        "dtype": "float32",
        "encoding": "none"
    },
    "description": "Robot state, consists of [7x robot joint angles, 2x gripper position, 1x door opening angle]."
},

Both should be in cartesian space reference to base_link. with state: [x, y, z, roll, pitch, yaw, gripperstate] and action: [dx, dy, dz, droll, dpitch, dyaw, gripperstate]

Still not be corrected in the features.json file...


key length too short

Trying to configure the workflow, the workflow debug mode reports:
[2018-09-20 20:59:37][ERROR: input.scriptfilter] Code 1: crypt.rb:12:in `key=': key length too short
(OpenSSL::Cipher::CipherError)
from crypt.rb:12:in `encrypt'
from -e:21:in `<main>'

Sidenote: Can't put in a pull-request right now, but the documentation of how to add a custom field in MacPass is not up2date anymore:
https://github.com/MacPass/MacPass/wiki/Screenshots

Try to use the updated version https://github.com/samueldeng/alfred-keepass/issues/8


SpatialObject IsInsideInObjectSpace PERF penalty GetTypeName().find

Description
Looking at the performance of IsInsideInObjectSpace(point, depth=0,  name=""), I observed a large performance gain when I locally removed the following line, when using the default argument values (so name=""):
if( this->GetTypeName().find( name ) != std::string::npos )

https://github.com/InsightSoftwareConsortium/ITK/blob/v5.0rc02/Modules/Core/SpatialObjects/include/itkImageMaskSpatialObject.hxx#L45
Impact analysis
For ImageMaskSpatialObject it appears that IsInsideInObjectSpace(point) will be more than twice as fast, and sometimes even more than 3 X as fast, when the line of code that does the GetTypeName() check is removed.
I measured the performance of something like this:
for (unsigned i = 0; i < n; ++i)
{
  typename TImage::PointType point{};
  point[0] = i;
  spatialObject->IsInsideInObjectSpace(point);
}

Versions
ITK5 RC2
Environment
Visual C++ 2017 x64 Release
Question
Is there a common use case, calling IsInsideInObjectSpace(point, depth, name) with a non-empty name argument?

@N-Dekker Could you simply make 2 explicit separate signatures and avoid the default parameter for name removed?
IsInsideInObjectSpace(point)

IsInsideInObjectSpace(point, depth) // Perhaps have depth=0 defaulted and skip the first signature

IsInsideInObjectSpace(point, depth, name)
{
if( this->GetTypeName().find( name ) != std::string::npos )
{}

return IsInsideInObjectSpace(point, depth)
}

This would be backward compatible and have the performance gains.

@hjmjohnson Thanks for your suggestion. Surely the PERF issue could be solved by adding an overload without the name parameter. However, it isn't entirely as simple as you suggested! When depth > 0, the function returns IsInsideChildrenInObjectSpace(point, depth, name), so at that point, the name argument must still be available.

In the mean time I did figure out that the performance issue can already be fixed easily, by ensuring that GetTypeName().find(name) is only called when the name is non-empty. So by doing:
if(name.empty() || (this->GetTypeName().find( name ) != std::string::npos) )

That would really be a major performance improvement  :-)
I'm still curious about the use case, though! Do users want to specifically look into those spatial objects whose type-name has a certain name as substring?

@hjmjohnson I'm preparing a pull request now that does actually follow your suggestion (separate signatures, separate overloads for with and without name parameter). It's quite a refactoring, as it involves 12 SpatialObject classes. Please wait...  :-)


Update golang version in contributing guide

Signed-off-by: Arika Chen<EMAIL_ADDRESS>
Description
Update golang version to 1.9 while using Server.ServeTLS

Edit by @emilevauge: The initial PR that moves to Go 1.9 is https://github.com/containous/traefik/pull/2004.
The current PR updates the contributing documentation.

ok. I made a mistake.
The second path is used to fix error log when execute traefik -h.
It is always show "Error parsing command: pflag: help requested".


ReactiveCollection should be CLS compilant (partial patch attached)

Adding "[assembly: CLSCompliant(true)]" to the Reactive UI results in an number of varnings about ReactiveCollection not beeing CLS compilat. The varnings are attached below and can easily be resolved.
1; Add [assembly: CLSCompliant(true)] to the AssemblyInfo.cs for all the projects
2; Update ReactiveCollection to become CLS compatible.
A patch is provided changing the offending member variables from protected to private,
it they really should be protected then they should instead be renamed (ex _ItemsAdded can be renamed to itemsAdded)
------------------------------------------------------ Varnings ------------------------------------------------------
ReactiveUI\ReactiveUI\ReactiveCollection.cs(157,34): warning CS3008: Identifier 'ReactiveUI.ReactiveCollection._ItemsAdded' is not CLS-compliant
ReactiveUI\ReactiveUI\ReactiveCollection.cs(169,31): warning CS3008: Identifier 'ReactiveUI.ReactiveCollection._BeforeItemsAdded' is not CLS-compliant
ReactiveUI\ReactiveUI\ReactiveCollection.cs(179,34): warning CS3008: Identifier 'ReactiveUI.ReactiveCollection._ItemsRemoved' is not CLS-compliant
ReactiveUI\ReactiveUI\ReactiveCollection.cs(190,31): warning CS3008: Identifier 'ReactiveUI.ReactiveCollection._BeforeItemsRemoved' is not CLS-compliant
ReactiveUI\ReactiveUI\ReactiveCollection.cs(204,36): warning CS3008: Identifier 'ReactiveUI.ReactiveCollection._CollectionCountChanging' is not CLS-compliant
ReactiveUI\ReactiveUI\ReactiveCollection.cs(215,36): warning CS3008: Identifier 'ReactiveUI.ReactiveCollection._CollectionCountChanged' is not CLS-compliant
ReactiveUI\ReactiveUI\ReactiveCollection.cs(226,56): warning CS3008: Identifier 'ReactiveUI.ReactiveCollection._ItemChanging' is not CLS-compliant
ReactiveUI\ReactiveUI\ReactiveCollection.cs(241,56): warning CS3008: Identifier 'ReactiveUI.ReactiveCollection._ItemChanged' is not CLS-compliant
ReactiveUI\ReactiveUI\ReactiveCollection.cs(255,64): warning CS3008: Identifier 'ReactiveUI.ReactiveCollection._Changing' is not CLS-compliant
ReactiveUI\ReactiveUI\ReactiveCollection.cs(266,64): warning CS3008: Identifier 'ReactiveUI.ReactiveCollection._Changed' is not CLS-compliant
------------------------------------------------------ Patch begin ------------------------------------------------------
Index: ReactiveCollection.cs
--- ReactiveCollection.cs	(revision 378)
+++ ReactiveCollection.cs	(working copy)
@@ -154,7 +154,7 @@
}
     [IgnoreDataMember]

   protected IObservable<T> _ItemsAdded;

   private IObservable<T> _ItemsAdded;

   /// <summary>
   /// Fires when items are added to the collection, once per item added.

@@ -166,7 +166,7 @@
}
     [IgnoreDataMember]

   protected ISubject<T> _BeforeItemsAdded;

   private ISubject<T> _BeforeItemsAdded;

   /// <summary>
   /// Fires before an item is going to be added to the collection.

@@ -176,7 +176,7 @@
}
     [IgnoreDataMember]

   protected IObservable<T> _ItemsRemoved;

   private IObservable<T> _ItemsRemoved;

   /// <summary>
   /// Fires once an item has been removed from a collection, providing the

@@ -187,7 +187,7 @@
}
     [IgnoreDataMember]

   protected ISubject<T> _BeforeItemsRemoved;

   private ISubject<T> _BeforeItemsRemoved;

   /// <summary>
   /// Fires before an item will be removed from a collection, providing

@@ -198,10 +198,10 @@
}
     [IgnoreDataMember]

   protected Subject<int> aboutToClear;

   private Subject<int> aboutToClear;

   [IgnoreDataMember]

   protected IObservable<int> _CollectionCountChanging;

   private IObservable<int> _CollectionCountChanging;

   /// <summary>
   /// Fires before a collection is about to change, providing the previous

@@ -212,7 +212,7 @@
}
     [IgnoreDataMember]

   protected IObservable<int> _CollectionCountChanged;

   private IObservable<int> _CollectionCountChanged;

   /// <summary>
   /// Fires whenever the number of items in a collection has changed,

@@ -223,7 +223,7 @@
}
     [IgnoreDataMember]

   protected ISubject<IObservedChange<T, object>> _ItemChanging;

   private ISubject<IObservedChange<T, object>> _ItemChanging;

   /// <summary>
   /// Provides Item Changed notifications for any item in collection that

@@ -238,7 +238,7 @@
}
     [IgnoreDataMember]

   protected ISubject<IObservedChange<T, object>> _ItemChanged;

   private ISubject<IObservedChange<T, object>> _ItemChanged;

   /// <summary>
   /// Provides Item Changing notifications for any item in collection that

@@ -252,7 +252,7 @@
}
     [IgnoreDataMember]

   protected IObservable<IObservedChange<object, object>> _Changing;

   private IObservable<IObservedChange<object, object>> _Changing;

   /// <summary>
   /// Fires when anything in the collection or any of its items (if Change

@@ -263,7 +263,7 @@
}
     [IgnoreDataMember]

   protected IObservable<IObservedChange<object, object>> _Changed;

   private IObservable<IObservedChange<object, object>> _Changed;

   /// <summary>
   /// Fires when anything in the collection or any of its items (if Change

------------------------------------------------------ Patch end ------------------------------------------------------

What is the practical benefit to being CLSCompliant (i.e. what scenarios are currently impossible but are now enabled with this?)

If the library is CLS compilant you can be sure that it is usable by all .NET languages such as VB, F# etc  (in short being CLS compilant set some constraints on the naming externally accessible (public/protected) functions and variables).
In this specific instance protected members variables starts with underscore which is not possible all .Net compatible languages.

Which languages don't support this?


macOS does not have pthread_condattr_setclock/getclock

@bors r+

:pushpin: Commit 73d4d97492fe866aa8dcb2650de4460f548a1ffe has been approved by RalfJung

:hourglass: Testing commit 73d4d97492fe866aa8dcb2650de4460f548a1ffe with merge 6aa8e7c014a3eef6169a6b6507cd5bb9516823c2...

:broken_heart: Test failed - checks-travis

@bors r+

:pushpin: Commit 9ff77f6cb36993026626a6463a6d22bca699a528 has been approved by RalfJung

:hourglass: Testing commit 9ff77f6cb36993026626a6463a6d22bca699a528 with merge f280e7e2d7ea7cbed54deb249f1aa19e722f834f...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing f280e7e2d7ea7cbed54deb249f1aa19e722f834f to master...


Introduced in BC 17?

Hi,
could you please add

APPLIES TO: Business Central 2020 release wave 2 and later

Background: https://twitter.com/KarolakNatalie/status/1313343599241818112?s=20

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 245a6ad9-dfb0-13ed-3936-48d049967717
Version Independent ID: a26186f1-b94d-e9b0-a94d-7c91047e3136
Content: CommitBehavior Attribute - Business Central
Content Source: dev-itpro/developer/methods/devenv-commitbehavior-attribute.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Absolutely - this is now fixed and will be pushed with the next doc refresh. Thanks!


Select with GWT 2.8.0 does not work?

Hi All,
I'm trying to use the Select component in my GWTBootstrap3 webapp with GWT 2.8.0. It does not show at all. Here is the result HTML: please see the attachment:

Here is the code:

This is the exception:
SEVERE: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: (TypeError) : ((intermediate value)(intermediate value) , $wnd).jQuery(...).selectpicker is not a function com.google.gwt.user.client.ui.AttachDetachException: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: Exception caught: (TypeError) : ((intermediate value)(intermediate value) , $wnd).jQuery(...).selectpicker is not a function 	at Unknown.java_lang_Throwable_Throwable__Ljava_lang_String_2Ljava_lang_Throwable_2V(Throwable.java:74) 	at Unknown.java_lang_Exception_Exception__Ljava_lang_String_2Ljava_lang_Throwable_2V(Exception.java:33) 	at Unknown.java_lang_RuntimeException_RuntimeException__Ljava_lang_String_2Ljava_lang_Throwable_2V(RuntimeException.java:33) 	at Unknown.com_google_web_bindery_event_shared_UmbrellaException_UmbrellaException__Ljava_util_Set_2V(UmbrellaException.java:65) 	at Unknown.com_google_gwt_event_shared_UmbrellaException_UmbrellaException__Ljava_util_Set_2V(UmbrellaException.java:26) 	at Unknown.com_google_gwt_user_client_ui_AttachDetachException_AttachDetachException__Ljava_util_Set_2V(AttachDetachException.java:136) 	at Unknown.com_google_gwt_user_client_ui_AttachDetachException_tryCommand__Ljava_lang_Iterable_2Lcom_google_gwt_user_client_ui_AttachDetachException$Command_2V(AttachDetachException.java:87):

Hmm it could be the same problem as this one: https://github.com/gwtbootstrap3/gwtbootstrap3-extras/issues/223
But I don't see any double loading of JQuery...

OK, workaround works also with GWT 2.8. So I close this point and we should follow this thread: gwtbootstrap3/gwtbootstrap3-extras#308


Historical Data Entry feature redesign

Describe the task
We want to explore redesign options for when we port over the HDE feature from TFRS to the LCFS system.
Redesign elements include:

new name as 'Historical Data Entry' label doesn't accurately reflect the core purpose of the feature
new labels for the different fields that accurately reflect the naming conventions of the new Act. For example, transfers are recorded not approved; credit transfers are now just transfers; part 3 awards are now initiative agreements; no use of the 'Commit' label since this is dev jargon rather than business language.
new UI design where the fields don't stretch so much across the screen
Only show relevant fields for each transaction type, based on selection. For example, don't show 'Credits from' for non-transfer transactions; don't show dollar per credit for non-transfer transactions, etc.
Add agreement date field to credit transfers; would we also need to add a drop-down for manual selection of categorization of the transfer? Or could the system do this automatically on approval.

Other design considerations:

consider simplifying the process by getting rid of the queue
accessibility considerations?

Purpose
Modernizing an old feature to align it with its current core purpose as well as new Act requirements & naming conventions.
Acceptance Criteria

[ ] first
[ ] second
[ ] third

Additional context

Add any other context about the task here.
Or here

What role has access to this? If removing the queue, should the analyst create a transaction and now have the director complete the transaction? Or do we want the admin function to create and complete the transaction entirely?


build: Could not find module `LLVM.Analysis.IFDS'

Hi,
when trying to build llvm-slicing, I get the following error:
Building llvm-slicing-0.3.3...
Preprocessing executable 'llvm-slicing' for llvm-slicing-0.3.3...

LLVM/Slicing/Static/SDG/IFDS/SummaryEdge.hs:33:8:
    Could not find module `LLVM.Analysis.IFDS'
    Perhaps you meant
      LLVM.Analysis.CDG (from llvm-analysis-0.3.0)
      LLVM.Analysis.CFG (from llvm-analysis-0.3.0)
      LLVM.Analysis (from llvm-analysis-0.3.0)
    Use -v to see a list of the files searched for.

LLVM/Slicing/Static/SDG/IFDS/SummaryEdge.hs:34:8:
    Could not find module `LLVM.Analysis.ICFG'
    Perhaps you meant
      LLVM.Analysis.CFG (from llvm-analysis-0.3.0)
      LLVM.Analysis.CDG (from llvm-analysis-0.3.0)
      LLVM.Analysis (from llvm-analysis-0.3.0)
    Use -v to see a list of the files searched for.

LLVM/Slicing/Static/SDG/IFDS/SummaryEdge.hs:35:8:
    Could not find module `LLVM.Analysis.Internal.Worklist'
    Use -v to see a list of the files searched for.

looks like the llvm-analysis does not export these data types at all. Any clue?
Thanks,
Marek

Hi, Marek,
Thanks for your interest in this project.
For your problem, in fact I mentioned in the file SummaryEdge.hs (as comments before import IFDS module):
-- Based on the IFDS algorithm which is not directly import from LLVM.Analysis,
--    but it could be found from its github website as follows.
--    https://github.com/travitch/llvm-analysis/blob/master/src/LLVM/Analysis/IFDS.hs
So you can directly download these files about IFDS and put them together with LLVM.Analysis, then recompile LLVM.Analysis.
Alternatively, you can directly download our pre-built binary in the folder bin/.

Thanks for the answer.
Is this the only thing I am supposed to do? Because I'm getting a lot of errors when trying to compile llvm-analysis with these files. IFDS module was dropped from llvm-analysis in 2012 and since then a lot of changes took place, so making it work is not so easy -- at least I haven't managed to make it compilable again.

If you do not have to use the IFDS method to compute summary information, for your choice, this project supports another way (called SDG method in this project) for computing summary information, which also can generate dependence graphs such as IR SDG and can return final static slice result based on graph reachability. To do so, you should hide the import modules about IFDS in the file Slicing.hs, and instead use the method SDG for SDG-based slicing.


ML Kit run time error with custom TF lite model "Thread 2: EXC_BAD_ACCESS (code=1, address=0x11f7f4000)"

I re-trained a mobilnet model just like the Tensorfow for Poets  codelabs and then created a Tessorflow lite file just as it is said in the Tensorflow for poets 2 iOS. It works fine with the included Objective C++ iOS source code. But if i try to use it in the ML kit swift source i get a run time exception.

My Swift code is fairly simple just like mentioned in the Firebase ML Kit Docs , but instead of uploading the model file to firebase console i registered the model locally and used it. My Code is as below,
func initWorkingMLModel(){
        /*Initializing local TFLite model*/
        guard let modelPath = Bundle.main.path(forResource: "mobilenet_v1.0_224_quant", ofType: "tflite") else {
            return
        }

        let myLocalModel = LocalModelSource.init(name: "Inception", path: modelPath)
        if ModelManager.modelManager().register(myLocalModel)
        {
            let options = ModelOptions(cloudModelName: nil, localModelName: "Inception")
            let interpreter = ModelInterpreter.modelInterpreter(options: options)

            let ioOptions = ModelInputOutputOptions()
            do {
                try ioOptions.setInputFormat(index: 0, type: .uInt8, dimensions: [1, 224 , 224, 3])
                try ioOptions.setOutputFormat(index: 0, type: .uInt8, dimensions: [1, 1001])
                print("Setting the Input and Output formats Success")
            } catch let error as NSError {
                print("Failed to set IO \(error.debugDescription)")
            }

            let inputs = ModelInputs()
            do {
                let image = UIImage.init(named: "tennis.jpg")
                guard let imageData =
                    self.scaledImageData(from: image!,
                                         componentsCount: 3) else {
                                            return
                }
                try inputs.addInput(imageData)

            } catch let error as NSError {
                print("Cannot get audio file data \(error.debugDescription)")
                return
            }

            interpreter.run(inputs: inputs, options: ioOptions) { (outputs, error) in
                if error != nil {
                    print("Error running the model \(error.debugDescription)")
                    return
                }
                do {
                    let output = try outputs!.output(index: 0) as? [[NSNumber]]
                    let probabilities = output?[0]

                    guard let labelsPath = Bundle.main.path(forResource: "labels", ofType: "txt") else { return }
                    let fileContents = try? String.init(contentsOf: URL.init(fileURLWithPath: labelsPath))
                    guard let labels = fileContents?.components(separatedBy: "\n") else {return}

                    for i in 0 ..< labels.count {
                        if let probability = probabilities?[i] {
                            print("\(labels[i]) : \(probability)")
                        }
                    }
                }catch let error as NSError {
                    print("Error in parsing the Output \(error.debugDescription)")
                    return
                }
            }
        } else {
            print("model registration failed")
        }
    }

I am calling this function on a button press action.  The error originates from the line interpreter.run(inputs: inputs, options: ioOptions) { (outputs, error) in.
I am using Xcode 10.1 Stable
Swift 4.2
Pod install versions (All updated to latest)
Firebase 5.16.0
Firebase core 5.2.0
FirebaseMLCommon 0.14.0
FirebaseMLModelInterpeter 0.14.0
TensorflowLite 1.12.0

We actually used the same model on https://github.com/firebase/quickstart-ios/tree/master/mlmodelinterpreter Do you mind trying your model with this sample? If you register locally, it should work without needing to push your model to cloud. EXC_BAD_ACCESS is usually a memory issue, you may be creating some race condition, trying to read/write an invalid address. If it doesn't resolve feel free to drop your full stack trace here so we can look at.


[NTR]: mesothelial cell of large intestine

Note - please check that the term does not already exist (check OLS: https://www.ebi.ac.uk/ols/ontologies/cl)
Preferred term label:
mesothelial cell of large intestine
Synonyms
Definition (free text, please give PubMed ID in format PMID:XXXXXX)
Mesothelial cell that resides in the large intestine
Parent cell type term (check the hierarchy here https://www.ebi.ac.uk/ols/ontologies/cl):
mesothelial cell http://purl.obolibrary.org/obo/CL_0000077
What is the anatomical structure that the cell is a part of? Please check Uberon: https://www.ebi.ac.uk/ols/ontologies/uberon
large intestine http://purl.obolibrary.org/obo/UBERON_0000059
Your nano-attribution (ORCID)
0000-0003-4183-8865
Any additional notes or concerns

This type of generic + location term might be better in EFO (with the same logical definition).  CC @zoependlington
@ngeorgeebi - if it goes into EFO the term will still end up in the scAtlas application ontology.

Hi David and Maria ( and the cell ontology team),
I have a large number of cell terms like this. Should I request that they go directly to EFO instead of making new term requests for CL?
Please see the following:
endocrine cell of large interstine
mesothelial cell of large intestine
gastrointestinal tract (lamina propria) macrophage of large intestine
stromal cell of large intestine lamina propria
lymphocyte of large intestine lamina propria
intestinal crypt stem cell of large intestine
Mesothelial cell of small intestine
endocrine cell of small intestine
Peyer's patch T cell
Peyer's patch lymphocyte
Peyer's patch follicular dendritic cell
mesothelial cell of small intestine
lamina propria stromal cell of small intestine
gastrointestinal tract (lamina propria) macrophage of small intestine
Would you be able to let me know of any terms that you would feel fit into this criteria and therefore should be requested directly via EFO instead?
Very grateful for all your help.
Best
Nancy

On 29 Oct 2020, at 15:56, David Osumi-Sutherland<EMAIL_ADDRESS>wrote:
This type of generic + location term might be better in EFO (with the same logical definition). CC @zoependlington
@ngeorgeebi - if it goes into EFO the term will still end up in the scAtlas application ontology.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Dr. Nancy George
Bioinformatician
Functional Genomics Group
EMBL - European Bioinformatics Institute
Wellcome Trust Genome Campus, Cambridge UK

@ngeorgeebi
mesothelial cell of large intestine EFO_0010898

@paolaroncaglia and/or @zoependlington can we please change this term to 'mesothelial cell of colon' and make it a child term of colon - UBERON:0001155 colon

Note for self: create 'mesothelial cell of colon' (part_of UBERON:0001155 colon) in CL, with a tag for location_grouping subset, and obsolete mesothelial cell of large intestine EFO_0010898? Ask SCA if that would work for them (the EFO term was created before we started adding location grouping terms in CL).

I think that would work fine, we won't need 'mesothelial cell of large intestine' for the anatomograms

Hi @sfexova ,
Looking at this again, if there's definitely no need for 'mesothelial cell of large intestine' for the anatomograms, then I should

[ ] modify the existing term CL:0009025 'mesothelial cell of large intestine' to become 'mesothelial cell of colon' instead;
[ ] obsolete EFO_0010898 'mesothelial cell of large intestine' (replace with CL:0009025 'mesothelial cell of colon').

Please let me know if you have any concerns re. SCA pipelines. Thanks.
Paola

I don't see any issues with this plan - thanks!

Hi @sfexova
(cc @ngeorgeebi )
CL_0009025 is now 'mesothelial cell of colon' (instead of 'mesothelial cell of large intestine'. The change will be visible with the next CL release. I'll leave this ticket open while I take care of the other action item.


[BP-1.12][FLINK-21155][tests] Fix FileSourceTextLinesITCase

Backport of #14855 to release-1.12

@XComp approved the PR #14855. Merging this backport PR as well.

Merged via cbcb7c17459b57c614ecc81bef6b574f7611c61d


Client status description in UG

It would be good to include a short explanation as to how we intend for the user to use the various client status (fresh, negotiated etc), which affects their user experience for the dashboard analytics feature. I have included a short writeup about how the analytics work (just summing up by the different statuses), and have referred the user to the contacts section for more info about the various statuses (how to add, edit etc).

completed (in draft PR)


Fix minor typo in description of 'binpack' scheduler strategy.

Fix minor typo in description of 'binpack' scheduler strategy.
Signed-off-by: Pradipta Kr. Banerjee<EMAIL_ADDRESS>

LGTM


A problem about JSON

Here's a question about the use of JSON to make a label:
I would like to create a label with label and message accroding to the return value of API, with information like the handle, and I need to use the message with a combination of two values.
How do to it?
By the way, how about color depending on API return values(a interger)?

Hello.
The dynamic JSON badge can grab a value from a JSON endpoint using JSONPath but the label and color are static.
If you want to create a badge based on a response from custom API which varies the label and color as well based on the API response, you'll need to write your own script to query that API and transform the response. Then you can use the endpoint badge: https://shields.io/endpoint
RunKit endpoints are a popular way to host them: https://runkit.com/docs/endpoint

If you have any more questions, please let us know!


A few things:
Firstly, the files in the src directory are generated automatically. A simple rerun of the generator script would just overwrite your code as it currently is, so you'd have to make sure that the generator scripts explicitely generate the bindings by using the SDL header files. You'd have to include SDL_timer.h there.
Secondly, is there a specific reason to use the SDL time measuring functions over the ones natively provided by Crystal? Because so far I don't see the need for these methods. A similar discussion arose some years ago in another SDL repository:
https://github.com/ysbaddaden/sdl.cr/pull/17

Reasons to supply the SDL timer funcs:

Improve the experience for people following SDL tutorials and who may also be fairly new to Crystal (this happened to me).
In case there are differences in the implementations, the programmer has the option of using either to meet their needs.

Compatibility with examples or tutorials is a good point, but then again the examples to this repository could simply be ported to work with the time functions provided by Crystal.
As far as I could read from the linked pull request, the methods provided by Crystal are more stable and extensive than the ones provided by SDL anyway. I am not aware of anything that the SDL timer library is better at.
Technically it would be no problem to include the SDL timer library, but essentially it is just a library that doesn't provide any new functionality - at the cost of requiring more maintenance.

yes i forgot to remove this pr, i use crystal method also


Maximum disk size ?

What is the maximum disk size for a data disk, P80?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc12f304-5826-fb32-1728-5e43f1b05d8a
Version Independent ID: 7cc3d5a7-9b0e-dd6b-3b34-2036219f5bd6
Content: Support matrix for VMware/physical disaster recovery in Azure Site Recovery - Azure Site Recovery
Content Source: articles/site-recovery/vmware-physical-azure-support-matrix.md
Service: site-recovery
GitHub Login: @v-harisudhan
Microsoft Alias: raynew

Thanks for bringing this to our attention. We are actively investigating and will get back to you soon.

@paulfinol Our sincere apologies for delay in getting back to this thread.  I have reached out to our internal team to find an answer for your query, we will update the thread accordingly as we hear more information.

@paulfinol - the maximum disk size supported by Azure Site Recovery is P50.

@Sharmistha-Rai  Thanks much for the response.

#please-close

wait, i Opened a case with MS support and they told me the documentation is not  updated and i could use full premium disk offer , until P80. otherwise how do you support 32tb data disk¿?

aximum disk size supported

wait, i Opened a case with MS support and they told me the documentation is not updated and i could use full premium disk offer , until P80. otherwise how do you support 32tb data disk¿?


Tenant Dashboards and Menus Missing

Awesome Dashboard and Veeam O365 tool, thank you for writing it!
Maybe we've done something wrong but our Veeam O365 box is domain joined and the vbo365-rest front end is on a separate Windows 2019 STS/IIS server, connecting back on a unique port.  When logging in with an AD account, user name only - not email address, the dashboard appears and we can manage ALL tenants.  Everything works.
If we login using the same Admin account but with an email address style username  (AD account), the dashboard disappears.
If we login using a Tenant Admin email address style user name (AAD - O365 Admin account), the dashboard and menus are all blank (see pic).
We just did a fresh install yesterday, PHP 7.4, Windows 2019 STD/IIS and as long as we only use the domain admin as described above, everything works.  Should the Tenants also get a dashboard and menus to do their own restores?

Hi, tenants should not receive a dashboard (those API calls just aren't available to them). They will get only restore options for the specific services.
Logging in with an e-mail address however is handled as a basic authentication type (when u add an organization, u can select either MFA or basic authentication).
What shouldn't happen though is that you can't see the organization on the left. It should load fine if you are using the same account you used that was used to add the organization to VBO365.

If the API calls are not available to the Tenants then I won't make a "feature" request. :-)
You mention "account you used that was used to add the organization to VBO365" - So, does this mean that I would need to log in to VBO365 using the Tenant Admin and then add the Tenant organization?  I believe they were all added using a domain admin.  Apologies, I haven't explored how to use this enough and was tasked with making a "dashboard" view for Tenants...which we will now stop trying to do.

There are 3 methods you can use for adding an organization in VBO365.

Using MFA with an application
Using MFA with a secret
Using basic authentication (username/email and password)

This portal supports organizations which are added using either 1 or 3. For basic authentication, it means you log in with an email and password and this will show the restore options.
A dashboard view for Tenants is possible depending on the needs but requires running a custom database to store information and parse it yourself. I don't add this due to the database dependency which I don't want to spend time on (due to security concerns, complexity, different requests per customer,...) :-). It would become a very complex project in the end and the goal here is to provide a portal which can help service providers get started with their offerings.

Thanks for the excellent and prompt feedback Niels.  I'll give this feedback to the customer requesting it and we'll move on.
So the one thing that's broken right now is the Tenant login which is in the pic above and doesn't show the restore options/menus that it should. Can you suggest how I can fix that?

@nielsengelen I sent you an email, can we chat about "A dashboard view for Tenants is possible depending on the needs but requires running a custom database to store information and parse it yourself." ?

Hi kelvin and Niels
I have the same problem
When i used local admin account, i can see the admin dashboard and all my tenants, restore are OK
When i use tenant account via MFA login, the process is successful but i can't see the tenant name's on the left panel an i can't choose any restore point on exchange, Teams...
I use the same tenant account in VBO configuration so i 'm sure this account have the good right, impersonation...
I can restore mail with this account in VBO console via MFA authentication.
Web portal is on a linux ubuntu server.
Do you have some idea ?
Thank you !

I will have to do some testing on this. Could you tell me your VBO version?

Hi Niels
We are in last VBO version, it’s a fresh install
Web server is on a linux ubuntu 16 server
I have only one tenant, it’s actually a POC but we have some clients which are very interested.
My veeam contact is<EMAIL_ADDRESS>we are a french VCSP
So when i use the web portal with login/password method and Windows local administrator, all my tests works fine (allow admin login is activated in setup)
I can connect, use the dashboard and do some restore
We use Modern Authentication with an Office365 service account (the same  i used in VBO console to configure tenant organization and to restore mails, teams files...)
When i try to connect web portal,i use MFA and it works fine but once logged, Oragnization is empty on the left panel, and in the right panel, i just have
Exchange
Choose a restore point...
That’s all...blank page
I can make more tests, give you some screenshots...
Thank you !
Maxime GUIRAUD
Ingénieur Virtualisation Stockage | BU Services Hebergés
[Tél. :] +33 (0)4 84 90 97 74   [Mobile :]  +33 (0)7 84 22 65 66
[E-mail :]<EMAIL_ADDRESS>[E-mail :] 71, Avenue André Roussin - BP 50067
13321 Marseille Cedex 16
[Jaguar Network]http://www.jaguar-network.com/
[Cloud | Voix | Réseau | Datacenter]
Suivez-nous ›    [RSS] http://www.jaguar-network.com/rss-news/   [LINKEDIN] https://www.linkedin.com/company/jaguar-network   [TWITTER] https://twitter.com/Jaguar_Network
De : Niels Engelen @.>
Répondre à : nielsengelen/vbo365-rest @.>
Date : vendredi 26 mars 2021 à 17:24
À : nielsengelen/vbo365-rest @.>
Cc : Maxime GUIRAUD @.>, Comment @.***>
Objet : Re: [nielsengelen/vbo365-rest] Tenant Dashboards and Menus Missing (#90)
I will have to do some testing on this. Could you tell me your VBO version?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/nielsengelen/vbo365-rest/issues/90#issuecomment-808348921, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATNJBRG5N4VHGJJTHLXTWQTTFSYNBANCNFSM4ZKVDVKA.
Ce message et toutes les pièces jointes (ci-après le "message") sont établis à l'intention exclusive de ses destinataires. Ce message est strictement confidentiel et peut comporter des données à caractère personnel ; si vous recevez ce message par erreur, merci de le détruire et d'en avertir immédiatement l'expéditeur par retour d'e-mail. Toute utilisation de ce message non conforme à sa destination, toute diffusion ou toute publication, totale ou partielle, est interdite, sauf autorisation expresse de Jaguar Network. La sécurité des communications sur Internet ne peut être garantie et Jaguar Network informe en conséquence qu'elle ne peut accepter aucune responsabilité quant au contenu de ce message.
This message and all attachments (hereinafter the "message") are intended solely for the intended recipients. This message is strictly confidential and may include personal data; if you receive this message by mistake, please destroy it and notify the sender immediately by return e-mail. Any use of this message that does not comply with its intended purpose, any broadcast or any publication, total or partial, is prohibited, unless expressly authorized by Jaguar Network. Internet communications security cannot be guaranteed and Jaguar Network therefore informs that it cannot accept any responsibility for the content of this message.

Hi
We use version <IP_ADDRESS>

@maximeJN could you send me the RESTful API logs via niels dot engelen at veeam dot com?


How to add postfix for debug version?

For example, add "-d" for debug binaries, so that debug and release can be in one directory.

I'm not entirely sure I understand your question. Configure has the --debug option as documented in the INSTALL file:
  --debug
                   Build OpenSSL with debugging symbols and zero optimization
                   level.

I'd like to put debug & release binaries in one directry, like:
bin/libssl-1_1-x64-d.dll
bin/libssl-1_1-x64.dll
instead of
debug/bin/libssl-1_1-x64.dll
release/bin/libssl-1_1-x64.dll

I'd recommend looking into the "variant SONAME" feature introduced by 822b5e2645a99bea15329bd66c9723c7e7119cdb

Good way, thanks.
But I'll keep two different folds for debug & release now for simplicity.
I'm studying CMake now, I will try to support it by cmake.

I think the correct term is "suffix", not "postfix".
"perl Configure --debug VC-WIN64A" appears to properly create the debug build but I don't see how to request a suffix so that the result looks like "libssl_static-d.lib". What incantation is needed?

I think the correct term is "suffix", not "postfix".
"perl Configure --debug VC-WIN64A" appears to properly create the debug build but I don't see how to request a suffix so that the result looks like "libssl_static-d.lib". What incantation is needed?

The documentation is at https://github.com/openssl/openssl/blob/f309b3f6087db6c83126f8f227f1fc4984cf24b1/Configurations/README.md?plain=1#L129-L149 but in short you'll need to create a new configuration target other than VC-WIN64A.  But this is pretty straightforward, just dropping a new file in Configurations/ and using inherit_from to grab the VC-WIN64A defaults and just add the shlib_variant as the sole new piece of configuration.

I created such a drop-in file and the resulting makefile doesn't have the variant suffix before the .lib extension.
my %targets = (
    "VC-WIN64A-DEBUG" => {
        inherit_from     => [ "VC-WIN64A" ],
        # add -d suffix to lib names for debug builds
        shlib_variant    => "-d",
    },
);

My first attempt used the picker function to set the value to "-d" for debug and "" for release and I thought I was doing something wrong when the makefile lacked the debug sonames.
        shlib_variant     => picker(debug   => "-d",
                                    release => ""),

Ah, I see it. The "-d" is getting added for the shared libraries but not for the static ones, which are what I'm hoping to build with.

Ah, I see it. The "-d" is getting added for the shared libraries but not for the static ones, which are what I'm hoping to build with. And it only affects the names of the .pdb files, not the .lib or .dll files.

hi, did you know how to add same postfix to related .lib file?


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

AWS CodeBuild CI Report

CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
Commit ID: a2c81d91326c35389e7c544e67ce25463def2fbd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
Commit ID: e28123f7a87a9019c61ea5f5161f216448e77385
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
Commit ID: 8f23434eb6ad8d976a6fd1b7d8ca952d4c10a4df
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
Commit ID: 3ee9613004be669137468b848fdf24dc37a36221
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


fix: single dash breaks yaml highlighting

This is a very hacky fix for https://github.com/ngalaiko/tree-sitter-go-template/issues/23 that adds a new node type "yaml_no_injection_text" which will turn a single "-" between templates into a different node instead of text, so it will not be used for injections.
I would like to get some opinions @baptman21, @kmoschcau.
Effect in a large file:

I have not yet written any parsers or grammars for tree sitter, so I'm not 100% qualified to look at this, but it looks good to me.

Thanks, I just added a comment that if https://github.com/tree-sitter-grammars/tree-sitter-yaml/issues/12 should get resolved, we can revert this.
But until this happens I think this is a good enough solution.


Adding a sorted map container?

For a music editing program, I'm storing a series of timestamped events (note data) in an Immer container. I would like to use the timestamps as keys in a sorted map, but Immer lacks sorted maps. I'm trying to emulate it using a wrapper around a sorted vector of struct{time, event} (usually under 100 events so copying isn't awful), but having to reimplement all operations is extra work.
Should I just stuff an immer::box<std::map> or something in an Immer container?

Depending on how much data you have, an immer::box<std::map> may suffice. Also, depending on your usage pattern, keeping a sorted immer::flex_vector may suffice (doing a binary-search + insert at point) may work. In the future, I would like add an ordered_map and ordered_set based on persistent red-black trees (or maybe b-trees).

Ohh, I see you have <100 events. You may consider just an immer::box<std::vector> or immer::array<>. Again, it depends on usage patterns (how often you insert or remove events, and how you iterate over them)

You may also wanna take a look at this: https://en.cppreference.com/w/cpp/algorithm/make_heap

All event lists will be iterated over, in sorted order (so not a heap) every time the screen is redrawn. It's only edited in response to user input, so 1-20 times a second.
I will be inserting and deleting elements at random positions in response to user input, sometimes at the end, sometimes (>50%) in the middle.
The audio thread needs to be able to pull a document tree out of an immer::atom, and read events without taking a lock.
And if the audio thread is holding onto a document revision after the main thread deletes it, the audio thread needs to be able to delete the entire tree in bounded time. According to http://www.rossbencina.com/code/real-time-audio-programming-101-time-waits-for-nothing , both malloc and free can take unbounded time and cause audio stuttering.
Is immer (lots of hierarchy, but pool-allocated) bounded-time? Does immer::box<std::map> enable the audio thread to delete a std::map? Would that be considered bounded-time or not?
Honestly this concern is mostly moot, since it's quite unlikely that the audio thread will be holding onto the last reference to something. That would require the user to undo (pushing the current state to redo stack), then perform an action (clearing the redo stack), all within 1-50 milliseconds (depends on how audio is configured).
I'm not sure that a categorical "don't hold locks in the audio thread" is even justified, but I'm assuming that's the case and I need immer.

jimbo1qaz<EMAIL_ADDRESS>writes:

All event lists will be iterated over, in sorted order (so not a heap)
every time the screen is redrawn. It's only edited in response to user
input, so 1-20 times a second.
I will be inserting and deleting elements at random positions in
response to user input, sometimes at the end, sometimes (>50%) in the
middle.
The audio thread needs to be able to pull a document tree out of an
immer::atom, and read events without taking a lock.

The I would say, a sorted vector is the best option.  You really wanna
optimize iteration here, and red-black trees (std::map or a potential
persistent version on Immer) are gonna be slower to iterate over.  With
vectors of <100 elements you are not even gonna get that much benefit
from structural sharing anyways.  So I would say, use immer::array or
immer::boxstd::vector.  You can play with using a heap on top in
combination (with the forementioned std::make_heap), or using
immer::flex_vector.

And if the audio thread is holding onto a document revision after the
main thread deletes it, the audio thread needs to be able to delete
the entire tree in bounded time. According to
http://www.rossbencina.com/code/real-time-audio-programming-101-time-waits-for-nothing
, both malloc and free can take unbounded time and cause audio
stuttering.

Yes, I've worked a lot in the audio field and I am aware of these issues
:)

Is immer (lots of hierarchy, but pool-allocated) bounded-time? Does
immer::box<std::map> enable the audio thread to delete a std::map?
Would that be considered bounded-time or not?

It would not.

Honestly this concern is mostly moot, since it's quite unlikely that
the audio thread will be holding onto the last reference to
something. That would require the user to undo (pushing the current
state to redo stack), then perform an action (clearing the redo
stack), all within 1-50 milliseconds (depends on how audio is
configured).

You are right, it seems almost moot.  Still, if you wanna do it "right",
there are some possible solutions.
One of them is to play with custom allocators, but there is still the
problem of the potential traversal of the document itself as a result of
the refcount cycle.  I am in discussions with a potential commercial
client of Immer that would like to implement a solution to this directly
in the library.
However!  Given your nice single-atom based design (a good one!) you
have a simple solution you can implemnt itself.  Add a property
std::size_t generation to the root of your document.  Every time you
change the document, producing a new one, you increase it, and put the
document in a main-thread controlled list.  Then, you also have
std::atomic<std::size_t> last_seen_generation variable that the audio
engine, that the audio thread increases once it is done processing a
document (sets it to the generation of that document).  Periodically,
the main thread removes from its list every document older than
last_seen_generation, potentially destroying them if they are
forgotten.  Depending on the structure of your audio engine, there is
still a potential situation that the audio engine somehow holds on to
parts of the document even after being done "processing" it.  That is
still a rare case and can be easily avoided.

I'm not sure that a categorical "don't hold locks in the audio thread"
is even justified, but I'm assuming that's the case and I need immer.

Sure!  Immer is good for audio apps, I had them in mind as one my main
use-cases ;)
Cheers!
JP
PS. If this is a commercial project and you want more specific advice,
code review, etc, we could do a consulting project under NDA.
--
∿∿∿  https://sinusoid.al
∿∿∿  https://sinusoid.es

Thanks for the help! This is not a commercial project. I actually came up with the single-atom idea talking to user bowbahdoe (don't want to ping, idk?) experienced in Clojure.
It seems you're reading and replying via email, so you missed my edit where I said "I'm not sure that a categorical "don't hold locks in the audio thread" is even justified. Someone claims that it only matters if your audio thread is running with realtime scheduler priority..."

Right now I'm working on an immutable ordered map for one of my own projects that I'd be happy to contribute to immer. Inserts/removes optimally reuse subtrees instead of making deep copies, leaving inserts and removes at O(log n), and searches of course are O(log n). Like std::map, it's implemented via a red-black tree.

Thanks a lot for @voxoid0! I think that would be nice!
However, one can get better performance (due to cache utiliziation) using B-trees, that's what these libraries do:
immutable.js-sorted: https://github.com/applitopia/immutable-sorted
im-rs: https://github.com/bodil/im-rs
However, node-base trees can also be interesting in a functional language, like red-black trees, and others. If you are interested these are the ones that Data.Map on Haskell implements: http://groups.csail.mit.edu/mac/users/adams/BB/

Ah interesting. I searched for something that discusses the causes and trade-offs in B-tree performance for immutable ordered maps, but couldn't find it; do you know of something that goes into detail? Perhaps you can tell me if my guess is correct: a B-tree, by being able to use more than 2 branches per node, finds a tradeoff between the cache hits enabled by storing multiple child pointers in a contiguous array in memory, versus the additional cost O(c) of inserting or deleting on a node's child pointer list, where c is the avg number of children per node. (Both vector and list children would have O(c) bounded performance but for different reasons.) There would be an additional cost in memory, since when an ancestral line of nodes is rewritten after a write, a wider subtree is affected since each node branches more than 2. I wonder of the performance would depend on frequency of write vs read (or subtree iteration).

That is a correct general assumption. Reads are expected to be much faster because the tree is way shallower and more of the data is in contiguous blocks, less traversal and more cache efficiency. Ideally you would use block sizes similar to what we use for vectors (have you seen my talks on the topic?)
Inserting performance may be worse. I am not a 100% sure, because it depends on the amount of rebalancing you need on the red-black-tree, and on implementation details. I would in general be happy trade off a bit of write performance for faster reading.

Nice paper and talk; I looked over them the past couple of days. It will be interesting to see how your findings translate to an unordered map.
I realized last night that I need to work top-down in my project a bit more first to confirm the appropriate data structures, before moving on with the immutable ordered (multi) map impl. Will give an update afterwards. It happens to be a music project as well :) (algorithmic composition).

Oh nice! I am actually actually working in that field now with these guys: https://bronze.ai/
:)
And yeah, it sounds good to try not over-engineer with data-structures first. For now for example there is a place where I am needing one and I am simply using a immer::flex_vector + std::lower_bound on insertion and lookup to keep things sorted. Not optimal but I don't have time now to implement B-trees :p

i've been working on an immutable b+ tree that would cover this use case as well as https://github.com/arximboldi/immer/issues/158. by default the internal nodes just store pointers and there are 3 mixins that can decorate them with child counts, max keys, and/or weights which means it can implement either an indexed or an ordered interface (or both although this doesn't seem particularly useful in practice) as well as allowing the implementation of various ordered statistics datastructures and other things requiring fast prefix sum. on a dataset of 10 million 32 bit ints, the random lookup performace is around 2x slower than flex vector but the random insert performance is around 4x faster, and the design made it easy to support random insert on the transient version which is around 100x faster than random insert on a persistent flex vector. the code is still a work in progress and neither the interfaces nor the style are particularly consistent with immer right now, but if this is something you'd be interested in incorporating into immer i can share it and we can go from there.

well it's almost 3 years later, but if anyone is still interested in an immutable sorted map container, i finally finished my immutable b+ tree library https://github.com/jeffplaisance/BppTree

That is trully amazing @jeffplaisance. The API and coding style is a bit different than the Immer one, but I would love adapting it and integrating it into Immer...

Thanks! It would be awesome for this to be part of immer. I changed all the camelCase to snake_case (all the types are still PascalCase) which may make things slightly easier. Some of the API differences are probably due to the requirement to have unique names for every method across all the mixins so they don't hide each other when combined, which is not ideal, but seemed like the least bad option. There might be a way around it by putting all the API methods in the BppTreeDetail::Shared/Transient/Persistent classes and leveraging SFINAE to disable the ones that aren't applicable, but I was worried that might make IDE autocomplete even less effective than it currently is.

Yes... I think another thing to think about is how memory is managed in the two libraries. But it would be super interesting to have this in... Hopefully I find some time to go through this in the future, or someone else does ;)

Following up on this thread to say that jank (native Clojure dialect on LLVM) is currently using immer for maps/vectors/sets and I'm now finding myself in need of sorted maps and sorted sets. Having these in immer would be superb, but I'll take a look at BppTree in the meantime.
Thanks for all of the work here, folks! :heart:

@jeaye can you ping back here when you come up with a solution for sorted map/sets for Jank to see if we can backport it into Immer?

Hey @arximboldi! jank is using https://github.com/jeffplaisance/BppTree to provide sorted maps/sets (persistent and transient), which works well alongside immer. I had to make a small PR to get things fitting nicely into jank, but otherwise it was smooth.
The only other thing missing is the ability to customize the allocator or memory policy. immer makes this a breeze and jank just uses:
  using memory_policy = immer::memory_policy<immer::heap_policy<immer::gc_heap>,
                                             immer::no_refcount_policy,
                                             immer::default_lock_policy,
                                             immer::gc_transience_policy,
                                             false>;

For BppTree, sorted maps and sets aren't going to be GC-allocated for now, so they're going to leak. That means merging BppTree into immer would actually be a big win for jank, since we'd be able to address that problem. Otherwise, I'll be ultimately reaching out to @jeffplaisance to see what can be done, once memory leaks are my biggest concern. :smile:

Ah, one other thing I just found I had a TODO for. Clojure supports a sorted-set-by fn, which builds a sorted set given a runtime comparator function. This would require the comparator to be created at runtime alongside the sorted set instance. As far as I know, BppTree doesn't support that. So it boils down to two things currently missing, for full Clojure/jank support:

Custom allocator/memory policy
Runtime comparator objects

Following up after a couple more months of using BppTree to provide an updated summary with a new concern.

Compile times are slow! Using Clang's -ftime-trace, BppTree is one of the highest ranking template sets to instantiate for me, taking around 40s of my 950s build. For jank, with JIT compilation, slow compile times also mean slow startup times. Note: immer doesn't show up at all in that time tracing
Since it lacks custom allocator support, and jank is using Boehm, I'm currently leaking any sorted maps/sets
Since it lacks runtime comparators, I can't implement clojure.core/sorted-set-by

Sooo, although it was easy to add in, it's not really something I can stick with when jank goes to production in 2025. If there's no good solution, I may just strip out sorted sets/maps from jank until there is. If immer were to support these, especially while addressing the three concerns above, I'd likely be your first adopter.
I'd be able to comp a couple grand $$ for this to be addressed, one way or another, but as I'm quitting my job to focus on jank in January, that's all I can muster. :bow:


Camera2D: Fix condition on 'jump to limits' logic

Pull request #49409 (which was created for #32596) introduced a regression where if a user has smoothing_enabled = false and limit_smoothed = true on a Camera2D, and the camera is pointing outside any defined limits, the camera would simply be stuck until reset_smoothing() was called.
This change updates the logic that decides whether to smooth into bounds to be effective only if smoothing_enabled && limit_smoothing_enabled.
(For anyone needing a workaround prior to this being merged, either set limit_smoothed to false or invoke reset_smoothing() manually.)
Fixes #54856.

Thanks!

Cherry-picked for 3.5.

Cherry-picked for 3.4.1.


Select which tests to run

As our tests grow larger, while developing we do not want to run all the tests in a test suite. Use the functionality provided by tasty to select which tests to run via command line arguments. See this PR for inspiration :smiling_imp:
We should also document in the README how tests can be selected via command line options.

Closed by #603


select field is not selecting value

code is working fine but select field is not selecting value like other fields.
Here is code:

$frm = new AdamWathan\Form\FormBuilder;

$years = ['1990' => 1990, '1991' => 1991, '1992' => 1992];

$model = json_decode(json_encode(array('full_name'=>'John Doe',
										'bio'=>'',
										'color'=>'',
										'terms'=>'',
										'birth_year' => 1991 ,
<EMAIL_ADDRESS>
										'date_of_birth'=> '1985-05-06'
										)));

?>

<?= $frm->open(); ?>
<?= $frm->bind($model); ?>

<?= $frm->text('full_name'); ?>

<?= $frm->email('email')->required(); ?>

<?= $frm->text('date_of_birth'); ?>

<?= $frm->radio('color', 'red'); ?>

<?= $frm->checkbox('terms')->uncheck(); ?>

<?= $frm->select('birth_year',$years); ?>

<?= $frm->textarea('bio')->rows(5)->cols(20)->addClass('important')->value('My biography'); ?>

<?= $frm->submit('Submit'); ?>
<?= $frm->close(); ?>
```

It is rendering : 1991
rendered html should be like this: 1991
then it is showing selected.

Are you able to reproduce this in a test by any chance?
We have this test that appears to show this behavior working as expected:
https://github.com/adamwathan/form/blob/master/tests/BindingTest.php#L77
The expected output in your case should be:
<option value="1991" selected>1991</option>
...as seen at MDN:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select#Examples

Here is output and It is working fine now.
199019911992


xv: 0.1.1 -> 0.1.2, rename to xxv

Motivation for this change
https://github.com/chrisvest/xxv/releases/tag/0.1.2
The xv tool was renamed to xxv and the license was updated.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Nice, this will also fix its Repology metadata getting confused for the nixpkgs-update bumps!
https://repology.org/project/xv/versions

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/104

@GrahamcOfBorg build xxv


explorer - add epochs pages

Description
Describe the changes or additions included in this PR.
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Current dependencies on/for this PR:

main

PR #10033   👈

This comment was auto-generated by Graphite.


Access token requests optimization

The requests for a JWT token take about 3s. To improve that I tried Periodic token refreshing, but as I can see (from the application insights), during the bot activity periods, it requests a token (calls https://login.microsoftonline.com/botframework.com/oauth2/v2.0/token) almost every 10 minutes and that calls are part of the bot activity, not standalone output requests from the token refresher process.
So, I don't understand, why during the activity hours it requests a new token every 10 minutes in case the tokens expire in 3600 seconds and as a result of that the refresher that is scheduled to request token every 30min. particularly has no effect on the performance.
(the bot.builder's version is 3.16.0)

Originally posted by @mitkodi in https://github.com/Microsoft/BotBuilder/issues/4322#issuecomment-422804975

Hi @mitkodi
There have been numerous updates to the token refresh code since that blog post was written.  There is now an AutoTokenRefreshTimeSpan of 10 minutes: https://github.com/Microsoft/BotBuilder-V3/blob/master/CSharp/Library/Microsoft.Bot.Connector.Shared/MicrosoftAppCredentials.cs#L94


fix: use declare for store properties to avoid the need for as *Store

This ensures that people no longed need to write code such as const commandsStore = this.store as CommandStore but instead can keep out the typecast.
resolves #382

@sapphiredev pack


Feat integrate core

Hey @ingig, can you please look at this refactoring and determine if we need more cleanups and refactorings?

I cannot build the project, it's missing a file KycStatus.ts

@gustavosizilio
I get a warning of an unrecognized option when running npm run build and a lot of error messages

Can these error message be removed?

I think we should also set warning on the github action if it's running outside the trading times instead of failure, here is a github action generated by gpt that does it
name: Time-based Warning
on:
pull_request:
types: [opened, synchronize]
jobs:
time_check:
runs-on: ubuntu-latest
steps:
- name: Check time and create a warning comment
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
CURRENT_TIME=$(date -u +"%H:%M")
CURRENT_TIME_EST=$(date -d "$CURRENT_TIME" -u -R +'%:z' +"%H:%M")
START_TIME="09:30"
END_TIME="16:00"
      if [[ "$CURRENT_TIME_EST" < "$START_TIME" || "$CURRENT_TIME_EST" > "$END_TIME" ]]; then
        echo "Outside the time range, creating a warning comment on the pull request."
        COMMENT_BODY=":warning: This action should be run between 09:30 and 16:00 EST. Please be aware of this timing restriction."
        pr_number=$(jq --raw-output .number "$GITHUB_EVENT_PATH")
        api_url="https://api.github.com/repos/$GITHUB_REPOSITORY/pulls/$pr_number/reviews"

        curl -s -H "Authorization: token $GITHUB_TOKEN" \
             -H "Accept: application/vnd.github+json" \
             -X POST \
             -d "{\"event\": \"COMMENT\", \"body\": \"$COMMENT_BODY\"}" \
             $api_url
      else
        echo "Within the time range, no warning comment needed."
      fi

I got the panel to run on a test website, I have some issues with CORS that is my responsibility.
So only request from me to you on this PR

Clean up those error messages on build
Put warning on github action when outside the trading hours (see attachment in prev comment)


Web form for HPC Software Install

This should not be integrated into the default Hippo workflow .. yet, but we do need it to be CAS enabled.
Cluster Name:
<selection field, with options>
-Farm
-Franklin
-HPC1
-HPC2
-LSSC0
-Peloton
UC Davis or Affiliate Email:
<prepopulated with CAS email, editable>
Account Name on HPC Cluster
<prepopulated with Kerberos ID, editable>
Software Title and Version Requested:

Software License

Software Home Page:

How the software will benefit others by making it available to all users:

Any further information needed?

Hidden Fields:
CAS Login ID
Email to user after submission:
"Thank you for submitting your request. We appreciate your interest and will begin evaluating the details provided. Our team will review your submission thoroughly and respond as soon as possible.
If we need any further information, we will contact you directly.
Thank you for your patience."
Email to SNOW after submission to<EMAIL_ADDRESS>Include Web Fields, including the following in the body for consumption by SNOW:
Category: Request
Subcategory: New
Caller: [CAS Login ID]
ConfigurationItem: HPC Software

We're deprecating certain versions of installed software and need to notify folks. During that notification process, we'd ideally like to link them to HPCCF's Software installation policy, however that contains a link to the intermittently broken SiteFarm site that this feature will replace.

@cbookman Is Hippo supposed to send out three emails? Or does the email sent to<EMAIL_ADDRESS>get forwarded to SNOW?

FYI, this is the SN documentation for this:
https://servicehub.ucdavis.edu/servicehub?id=ucd_kb_article&sysparm_article=KB0010800


All map layers are not available in the configuration

Hi, I can select "Watercolor" as a map layer, in the worldmap window.
But, I can't select it from the configuration dialog box in the editor ?

Also, these layers don't show up in the worldmap page:

UK OS Opendata
Hike Bike
UK OS 1919-47
UK OS 1900

HikeBike comes from https://hikebikemap.org/ which does indeed seem to be fairly dead at the moment... no idea if this is permanent or not.
UK layers only cover the UK area but should work OK.
Hide from where ? the user view ?

UK layers work, yes, but just for UK. At first I was surprised because my default map center and zoom were in another part of the world, so there was only an empty layer. Zooming off of course showed the UK in the end. Well, one can live with them in the drop-down menu of the user view, and that would mean adding another option in the node configuration, not really needed. So it's just a detail.
I'd like to be able to select "Watercolour" in the configuration node, though :)

ok - will tidy -up and add ability to delete layers via a command so you can clean up on connect if you like

Oh, perfect ! Thanks.

example - function to clear up a lot of layers
msg.payload = {command:{
   map:{
       delete:[
           "UK OS 1919-47",
           "UK OS 1900",
           "UK OS Opendata",
           "Hike Bike",
           "Terrain",
           "Nat Geo",
           "Watercolor",
           "ship nav",
           "public transport",
           "heatmap",
           "railways",
           "roads"
       ]
   }
}};
return msg;

Great, many thanks again !


Uncaught RangeError: Maximum call stack size exceeded.     at HTMLDocument.contain (FocusTrap.js:225:1)

Sorry, my boss don't pay me to fill bug report for you
Here the error I got: Uncaught RangeError: Maximum call stack size exceeded.
at HTMLDocument.contain (FocusTrap.js:225:1)
It happens when when I choose an option in any dropdown: MenuSelectFontFamily, MenuSelectHeading or MenuSelectFontSize.
Also, proper documentation would be appreciate.
Otherwise not a bad project.
Thank you.

I don't have enough information to understand your setup, since the demo in the README works fine, as you can see for yourself. If you can provide more context, I may be able to investigate if it's a problem with mui-tiptap (and not Tiptap itself), but otherwise I will plan to close this out.

surprinsigly