Update sql-server-linux-faq.yml

Changing the answer of #2 in Administration section to provide more clarity.

Learn Build status updates of commit 62022e4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/linux/sql-server-linux-faq.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@VanMSFT
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

I'll move this to a private PR.
#please-close


Inlined modules get emitted in the output

I am inlining a splash.css and a splash.js file into the index.html using style-ext-html-webpack-plugin and script-ext-html-webpack-plugin.
The service worker goes through the assets and runs into the mentioned files trying to cache them, but fails with:

http://localhost:8080/splash.a72065b4ca5e25fbaed5.js?__uncache=3%2F20%2F2017%2C 8%3A36%3A01 PM Failed to load resource: the server responded with a status of 404 (Not Found)

http://localhost:8080/splash.css?__uncache=3%2F20%2F2017%2C 8%3A36%3A01 PM Failed to load resource: the server responded with a status of 404 (Not Found)

I'm surprised because the inlined files should be forgotten after they are inlined, no?
I wanna know how to JUST inline those files and not emit them into the output.
This might as well just be my fault since I'm not an experienced webpacker.

Hi, sorry for the delay in responding. I'll take a look this evening.

No problem at all. Let me know if you need any more details.

OK - I am unfamiliar with OfflinePlugin but I think the general issue will be the different webpack plugins not working together happily.
HtmlWebpackPlugin hooks into lifecycle events emitted by Webpack.  I imagine OfflinePlugin does the same.   Style-ext... and Script-ext... plugins then hook into events emitted by HtmlWepbackPlugin.
Whilst  Style-ext... and Script-ext...  do remove the in-lined assets from the compilation, I suspect the choreography of all these events is such that they do so after OfflinePlugin has recorded the assets.
Rather than try to untangle all of this I suggest the easiest approach (certainly for me!) is for you to use exclude asset option of OfflinePlugin.
Does this work / is it sufficient for your needs?

Unfamiliar with OfflinePlugin?? But it's the future! xD
I used exclude as you said and obviously enough, it excluded the files.
So yeah.. thanx for reading the docs for me :}


Pan doesn't reach ends of genome

When you pan in phandango it is not possible to get to base 0 or genome-length.
Can be fixed by changing lines 77-80 in genome.js store from:
if (newLeft < 0 || newRight > genomeLength) {
    showHelperMessage('can\'t drag (already at edge of genome)');
    return false;
  }

to:
if ((newLeft < 0 && visibleGenome[0] === 0 ) || (newRight > genomeLength && visibleGenome[1] === genomeLength)) {
    showHelperMessage('can\'t drag (already at edge of genome)');
    return false;
  }
else if (newLeft < 0) {
    newLeft=0;
  }
else if (newRight > genomeLength) {
    newRight=genomeLength;
  }

Or something similar.
Hope that helps
Simon

@simonrharris you need to pull a newer version, that code is OLD!

Well it still isn't working on the https://jameshadfield.github.io/JScandy/ version. It's not that it pans past start/end, it's that it doesn't pan to the start/end if you're zoomed in. Try it. Zoom in and drag to the start of the genome. The leftmost genome coordinate will not go to 0.

OK, works on http://jameshadfield.github.io/phandango/. Sorry, didn't know that page existed - just had a guess and it works there.


Idea plugin is not supported for latest version

Thanks for the heads up. I'm working on getting Ballast updated to support Kotlin 1.8, I'll get this fixed in that release too.


[ESM] Plugin Prisma errors on graphql/execution/values import

Hey, i migrated to the new prisma plugin version and it stopped working.
I see that you changed the way you bundle the esm versions, so this is the only failing case:
https://github.com/hayes/giraphql/blob/d4d4fad976b392399257b7e2cf2478fb6c4f4fb8/packages/plugin-prisma/src/util/map-includes.ts#L14
The import from graphql/execution/values is missing a .js extension or maybe there is another way to import getArgumentValues.

should be fixed now


🐛 [Bug] RuntimeError: Target aten.convolution.default does not support transposed=True when using torch_tensorrt as backend in torch.compile

Bug Description
When trying to compile a simple PyTorch module with torch.compile(model, backend="torch_tensorrt"), I get:
RuntimeError: Target aten.convolution.default does not support `transposed=True`

I don't get any errors when using torch.compile(model) or torch_tensorrt.compile(model, inputs=inputs).
To Reproduce
Steps to reproduce the behavior:
import torch
import torch_tensorrt

from torch import nn

class Up(nn.Module):
    def __init__(self, in_channels, out_channels, upsample_stride):
        super().__init__()
        self.up = nn.Sequential(
            nn.ConvTranspose2d(
                in_channels,
                out_channels,
                upsample_stride,
                stride=upsample_stride,
                bias=False,
            ),
            nn.BatchNorm2d(out_channels),
            nn.ReLU(inplace=True),
        )

    def forward(self, x):
        return self.up(x)

def main():
    device = torch.device("cuda:0")
    model = Up(64, 128, 2).to(device)
    model.eval()
    print(model)

    x = torch.rand((1, 64, 100, 100)).to(device)
    # Works.
    with torch.no_grad():
        _ = model(x)

    model_opt = torch.compile(model)
    # Works.
    with torch.no_grad():
        _ = model_opt(x)

    torch._dynamo.reset()
    model_opt = torch.compile(model, backend="torch_tensorrt")
    # RuntimeError.
    with torch.no_grad():
        _ = model_opt(x)

    torch._dynamo.reset()
    inputs = [torch_tensorrt.Input(x.shape)]
    # Works.
    trt_ts_module = torch_tensorrt.compile(model, inputs=inputs)

if __name__ == "__main__":
    main()

Expected behavior

Environment

Build information about Torch-TensorRT can be found by turning on debug messages

Torch-TensorRT Version (e.g. 1.0.0): 1.4.0
PyTorch Version (e.g. 1.0): 2.0.1+cu117
CPU Architecture: i7-12800H
OS (e.g., Linux): Linux
How you installed PyTorch (conda, pip, libtorch, source): pip
Build command you used (if compiling from source):
Are you using local sources or building from archives:
Python version: 3.10.10
CUDA version: 12.2
GPU models and configuration: GeForce RTX 3080 Ti
Any other relevant information:

Additional context

Hi @apbose - I am able to reproduce this error, but it seems to be an issue with convolution and not with the Batch Norm operator, since I can get it to pass with
"torch_executed_ops": {"torch.ops.aten.convolution.default"}

The TRT error appears for the convolution operator, and below is a minimal repro:
import torch
import torch_tensorrt

from torch import nn

class Up(nn.Module):
    def __init__(self, in_channels, out_channels, upsample_stride):
        super().__init__()
        self.up = nn.ConvTranspose2d(
                in_channels,
                out_channels,
                upsample_stride,
                stride=upsample_stride,
                bias=False,
            ),

    def forward(self, x):
        return self.up(x)

def main():
    device = torch.device("cuda:0")
    model = Up(64, 128, 2).to(device)
    model.eval()
    print(model)

    x = torch.rand((1, 64, 100, 100)).to(device)
    model_opt = torch.compile(model, backend="torch_tensorrt",
                              options={"min_block_size": 1,
                                       "debug": True,})
    with torch.no_grad():
        _ = model_opt(x)

if __name__ == "__main__":
    main()

@zewenli98 has some experience with the convolution operators - could you take a look?

Hi, I just updated to the latest environment:
torch                    2.2.0.dev20231211+cu121
torch-tensorrt           2.2.0.dev0+f0e6d2d29
torchvision              0.17.0.dev20231211+cu121

For the code below:

import torch
import torch_tensorrt

from torch import nn

class Up(nn.Module):
    def __init__(self, in_channels, out_channels, upsample_stride):
        super().__init__()
        self.up = nn.Sequential(
            nn.ConvTranspose2d(
                in_channels,
                out_channels,
                upsample_stride,
                stride=upsample_stride,
                bias=False,
            ),
            nn.BatchNorm2d(out_channels),
            nn.ReLU(inplace=True),
        )

    def forward(self, x):
        return self.up(x)

def main():
    device = torch.device("cuda:0")
    model = Up(64, 128, 2).to(device)
    model.eval()
    print(model)

    x = torch.rand((1, 64, 100, 100)).to(device)
    # Works.
    with torch.no_grad():
        _ = model(x)

    model_opt = torch.compile(model)
    # Works.
    with torch.no_grad():
        _ = model_opt(x)

    torch._dynamo.reset()
    model_opt = torch.compile(model, backend="torch_tensorrt")
    # RuntimeError.
    with torch.no_grad():
        _ = model_opt(x)

    torch._dynamo.reset()
    inputs = [torch_tensorrt.Input(x.shape)]
    # Works.
    trt_ts_module = torch_tensorrt.compile(model, inputs=inputs)

if __name__ == "__main__":
    main()

@airalcorn2 I tried this code but there seems to be no error on my side. The output is something like:
...
DEBUG: [Torch-TensorRT Plugins Context] - Registered plugin creator - SpecialSlice_TRT, Namespace:
DEBUG: [Torch-TensorRT Plugins Context] - Registered plugin creator - Split, Namespace:
DEBUG: [Torch-TensorRT Plugins Context] - Registered plugin creator - VoxelGeneratorPlugin, Namespace:
DEBUG: [Torch-TensorRT Plugins Context] - Total number of plugins registered: 69
Up(
  (up): Sequential(
    (0): ConvTranspose2d(64, 128, kernel_size=(2, 2), stride=(2, 2), bias=False)
    (1): BatchNorm2d(128, eps=1e-05, momentum=0.1, affine=True, track_running_stats=True)
    (2): ReLU(inplace=True)
  )
)
INFO:torch_tensorrt.dynamo.utils:Using Default Torch-TRT Runtime (as requested by user)
INFO:torch_tensorrt.dynamo.utils:Device not specified, using Torch default current device - cuda:0. If this is incorrect, please specify an input device, via the device keyword.
INFO:torch_tensorrt.dynamo.utils:Compilation Settings: CompilationSettings(precision=torch.float32, debug=False, workspace_size=0, min_block_size=5, torch_executed_ops=set(), pass_through_build_failures=False, max_aux_streams=None, version_compatible=False, optimization_level=None, use_python_runtime=False, truncate_long_and_double=False, use_fast_partitioner=True, enable_experimental_decompositions=False, device=Device(type=DeviceType.GPU, gpu_id=0), require_full_compilation=False, disable_tf32=False, sparse_weights=False, refit=False, engine_capability=<EngineCapability.DEFAULT: 0>, num_avg_timing_iters=1, dla_sram_size=1048576, dla_local_dram_size=1073741824, dla_global_dram_size=536870912)

WARNING:torch_tensorrt.dynamo._compiler:4 supported operations detected in subgraph containing 4 computational nodes. Skipping this subgraph, since min_block_size was detected to be 5
INFO:torch_tensorrt._compile:ir was set to default, using dynamo as ir
INFO:torch_tensorrt.dynamo._compiler:Compilation Settings: CompilationSettings(precision=torch.float32, debug=False, workspace_size=0, min_block_size=5, torch_executed_ops=[], pass_through_build_failures=False, max_aux_streams=None, version_compatible=False, optimization_level=None, use_python_runtime=False, truncate_long_and_double=False, use_fast_partitioner=True, enable_experimental_decompositions=False, device=Device(type=DeviceType.GPU, gpu_id=0), require_full_compilation=False, disable_tf32=False, sparse_weights=False, refit=False, engine_capability=<EngineCapability.DEFAULT: 0>, num_avg_timing_iters=1, dla_sram_size=1048576, dla_local_dram_size=1073741824, dla_global_dram_size=536870912)

WARNING:torch_tensorrt.dynamo._compiler:4 supported operations detected in subgraph containing 4 computational nodes. Skipping this subgraph, since min_block_size was detected to be 5

Could you try to update your environment and then take a look?

import torch
import torch_tensorrt

from torch import nn

class Up(nn.Module):
    def __init__(self, in_channels, out_channels, upsample_stride):
        super().__init__()
        self.up = nn.ConvTranspose2d(
                in_channels,
                out_channels,
                upsample_stride,
                stride=upsample_stride,
                bias=False,
            ),

    def forward(self, x):
        return self.up(x)

def main():
    device = torch.device("cuda:0")
    model = Up(64, 128, 2).to(device)
    model.eval()
    print(model)

    x = torch.rand((1, 64, 100, 100)).to(device)
    model_opt = torch.compile(model, backend="torch_tensorrt",
                              options={"min_block_size": 1,
                                       "debug": True,})
    with torch.no_grad():
        _ = model_opt(x)

if __name__ == "__main__":
    main()

After updating to the latest environment, running the code above, I got error:
DEBUG: [Torch-TensorRT Plugins Context] - Registered plugin creator - Split, Namespace:
DEBUG: [Torch-TensorRT Plugins Context] - Registered plugin creator - VoxelGeneratorPlugin, Namespace:
DEBUG: [Torch-TensorRT Plugins Context] - Total number of plugins registered: 69
Up()
Traceback (most recent call last):
  File "../lowering/tmp.py", line 126, in <module>
    main()
  File "../lowering/tmp.py", line 122, in main
    _ = model_opt(x)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/eval_frame.py", line 501, in _fn
    return fn(*args, **kwargs)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/eval_frame.py", line 667, in catch_errors
    return callback(frame, cache_entry, hooks, frame_state)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/convert_frame.py", line 730, in _convert_frame
    result = inner_convert(frame, cache_entry, hooks, frame_state)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/convert_frame.py", line 383, in _convert_frame_assert
    compiled_product = _compile(
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/convert_frame.py", line 665, in _compile
    raise InternalTorchDynamoError(str(e)).with_traceback(
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/convert_frame.py", line 646, in _compile
    guarded_code = compile_inner(code, one_graph, hooks, transform)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/utils.py", line 244, in time_wrapper
    r = func(*args, **kwargs)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/convert_frame.py", line 562, in compile_inner
    out_code = transform_code_object(code, transform)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/bytecode_transformation.py", line 1033, in transform_code_object
    transformations(instructions, code_options)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/convert_frame.py", line 151, in _fn
    return fn(*args, **kwargs)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/convert_frame.py", line 527, in transform
    tracer.run()
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/symbolic_convert.py", line 2096, in run
    super().run()
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/symbolic_convert.py", line 781, in run
    and self.step()
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/symbolic_convert.py", line 744, in step
    getattr(self, inst.opname)(inst)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/symbolic_convert.py", line 463, in wrapper
    return inner_fn(self, inst)
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/symbolic_convert.py", line 1176, in CALL_FUNCTION
    self.call_function(fn, args, {})
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/symbolic_convert.py", line 639, in call_function
    if hasattr(fn, "value"):
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/variables/lists.py", line 69, in value
    return self.as_python_constant()
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/variables/lists.py", line 72, in as_python_constant
    return self.python_type()([x.as_python_constant() for x in self.items])
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/variables/lists.py", line 72, in <listcomp>
    return self.python_type()([x.as_python_constant() for x in self.items])
  File "/home/zewenl/anaconda3/envs/env1/lib/python3.8/site-packages/torch/_dynamo/variables/base.py", line 237, in as_python_constant
    raise NotImplementedError(f"{self} is not a constant")
torch._dynamo.exc.InternalTorchDynamoError: NNModuleVariable() is not a constant

from user code:
   File "../lowering/tmp.py", line 108, in forward
    return self.up(x)

Set TORCH_LOGS="+dynamo" and TORCHDYNAMO_VERBOSE=1 for more information

You can suppress this exception and fall back to eager by setting:
    import torch._dynamo
    torch._dynamo.config.suppress_errors = True

@gs-olive Did you get the same error like this?

Hi @zewenli98 - I do see the same error when using your script, but it is due to the extra comma which appears after the self.up line. If you remove that comma, I see this error, as before:
[12/11/2023-18:07:03] [TRT] [E] 3: [DECONVOLUTION]-[aten_ops.convolution.default]-[convolution]:kernel weights has count 32768 but 16384 was expected
[12/11/2023-18:07:03] [TRT] [E] 4: [DECONVOLUTION]-[aten_ops.convolution.default]-[convolution]: count of 32768 weights in kernel, but kernel dimensions (2,2) with 64 input channels, 64 output channels and 1 groups were specified. Expected Weights count is 64 * 2*2 * 64 / 1 = 16384
[12/11/2023-18:07:03] [TRT] [E] 4: [graphShapeAnalyzer.cpp::needTypeAndDimensions::2212] Error Code 4: Internal Error ([DECONVOLUTION]-[aten_ops.convolution.default]-[convolution]: output shape can not be computed)
[12/11/2023-18:07:03] [TRT] [E] 3: [DECONVOLUTION]-[aten_ops.convolution.default]-[convolution]:kernel weights has count 32768 but 16384 was expected
[12/11/2023-18:07:03] [TRT] [E] 4: [DECONVOLUTION]-[aten_ops.convolution.default]-[convolution]: count of 32768 weights in kernel, but kernel dimensions (2,2) with 64 input channels, 64 output channels and 1 groups were specified. Expected Weights count is 64 * 2*2 * 64 / 1 = 16384
[12/11/2023-18:07:03] [TRT] [E] 4: [network.cpp::validate::3121] Error Code 4: Internal Error (Layer [DECONVOLUTION]-[aten_ops.convolution.default]-[convolution] failed validation)

Thank you guys for pointing out the bug. It should be fixed in #2537.

Confirmed fixed for me. Thanks!


{Error Improvement} Add new error types

Description

This PR

adds FileOperationError into the new error type
provides UnknownError as a fallback error type of UserFault

Testing Guide

Developer related. No changes for user experience.

@zhoxing-ms @evelyn-ys @kairu-ms @haroldrandom for awareness


France grabbing doesn't work anymore

Hello,
Since yesterday France grabbing doesn't work anymore.
Here is the error:
ERROR: got exception Cannot read properties of undefined (reading '0')
Everything is ok with other countries, log:
INFO: processing USA
INFO: processing Great Britain
INFO: processing Spain
INFO: processing Canada
INFO: processing Germany
INFO: processing France
ERROR: got exception Cannot read properties of undefined (reading '0')
INFO: processing Italy
INFO: processing Norway
INFO: processing Sweden
INFO: processing Denmark
My config for France:
"France": "<IP_ADDRESS>",
How to enable debug log instead of info ?
Thanks

This is an interesting one... it appears that there is a channel called "Pluto TV #1" that does not have a category. Playing the url just gives the "flying through space" pluto tv logo.
I've just pushed an update to filter out these channels.

No this channel has not to be filter out. It broadcasts programs, currently it's South Park. It's a "best of Pluto Tv" Channel.


OzoneConfig - Add setting for HELPDESK_ADDRESS

Testing in Master environment (Iteration 29) using testUser1 role passes in IE9, IE11, and FF24 but fails in CH36:
Accessing "Contact Help Desk" from drop down in HUD, Center, Webtop: causes email access to help desk in IE9, IE11, FF24, but not CH36 (no response).

Built Webtop, Center and HUD and they all had the HELPDESK_ADDRESS and since this was tested in develop and staging this passes for both environments.


Update chain spec with boostrap nodes

@schmir I think this is done by trustlines-protocol/blockchain#88 correct?

yes, right. Thanks for pointing it out.


Adding a screenshot feature

[x] This issue is not about OPSEC or bypassing defensive products

Feature Description
Would be great to have a screenshot feature where you can decide if you want to take 1 screenshot or a screenwatch like in CS :) How can this be implemented? Maybe I can help out some 👍

Hey @sl4cky, thanks for the suggestion! I agree that would be a good idea. I will look into a reference implementation for Nim and try to add it to the v1.1 version that is currently in the Dev branch. Will keep you updated :)

Thanks, but no need! It actually proved fairly easy to implement. Added in v1.1 which is in the Dev branch currently, hope to push it to main soon. Feel free to play with it in the meantime!


Bump multihash to 0.8.0.

This removes cross-dependency on ring library. In version 0.8.0 they used sha crates for SHA, instead of pulling rather heavy ring. All tests are passing.
After merging the other crate that depends on ring is ethcore-crypto.
BTW Sorry for bumping Cargo.lock but its version is not pinned.

I'll send another PR to fix the problem with Cargo.lock before resolving this conflict.

I've just updated the dependency, which cause Cargo.lock to update. There are unpinned crates depending on git without commits/branches pinned and for some reason I thought it caused problems.


Migrate checkbox

There's now 2 files : one for the default checkbox and one for the button style checkbox.
No more state involved but it is only possible to check and uncheck the box in the control pannel, click does not work. Do you think there's a way to make both change options work ? I could not find anything but will keep on looking :mag_right:


feat: Add Discord social in the footer

Related Issue

Information about the related issue
It would be nice if we could add Discord to the list of socials at the bottom.

Closes: #
Describe the changes you've made

Add Discord social in the footer

Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update.
[ ] This change requires a documentation update

How Has This Been Tested?

Checklist

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented on my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original
Updated

original screenshot
updated screenshot

Code of Conduct

[x] I agree to follow this project's Code of Conduct

Nice work @marpit19 ⭐

thanks 😄


[REVIEW] Joshua Nweze

GitHub Profile Link
https://github.com/Joshua-Nweze

Some suggestions from my point of view -

write 3-4 lines of description for pinned repositories
join more organizations and contribute to them
add timezone


Invalid java SDK path in Editor Settings.Missing 'bin' directory!

Tested versions

Reproducible in Godot 4.2.2 (Linux)
Not reproducible in Goodot 4.2.1 (Linux)

System information
Ubuntu 23.10
Issue description
Error "Invalid java SDK path in Editor Settings.Missing 'bin' directory!" with exporting game to Android, but all java paths a same as Godot 4.2.1 and have no problem to export.
Problem only with 4.2.2 version.
Steps to reproduce

Download Godot 4.2.2 for Linux
Try export game to Android

Minimal reproduction project (MRP)

I'll add it.
In my case, for version 4.2.2, the path should look like this:
/usr/lib/jvm/java-17-openjdk-amd64
i.e. "/bin" should be removed.
This will not be the default value in the system paths and needs to be done manually.

@trash-max Thank you very much.
I had the same issue but putting this path /usr/lib/jvm/java-17-openjdk-amd64 solved the problem.

For macOS , run this in terminal /usr/libexec/java_home

/usr/lib/jvm/java-17-openjdk-amd64
this is not working for me can someone tell the sollution ?

/usr/lib/jvm/java-17-openjdk-amd64 this is not working for me can someone tell the sollution ?

Execute this command to find the path of your JDK
readlink -f $(which java)

Confirmed that my JDK path was correct, yet this error still persists on the 4.2.2 snap version. This is almost certainly a snap problem, because I was able to get around it by installing the 4.2.2 binary from godotengine.org instead.

Hi @damian-c

Confirmed that my JDK path was correct, yet this error still persists on the 4.2.2 snap version. This is almost certainly a snap problem, because I was able to get around it by installing the 4.2.2 binary from godotengine.org instead.

I cannot confirm this since I have installed Godot by downloading the binary file directly from the website.

Hello, in my case the route in Windows 11 was C:\Program Files\Eclipse Adoptium\jdk-<IP_ADDRESS>-hotspot

This is bug !!!!!

I had the same issue with the Steam version of Godot 4.3.stable. Installing it natively 'fixes' it and everything works. Same settings/config on both versions.
Steam:

@tschwaerzl
On my MacOS: /opt/homebrew/opt/openjdk@17/
Can you run “java” in “bin” folder?
/opt/homebrew/opt/openjdk@17/bin/java --version

openjdk <IP_ADDRESS> 2023-08-24
OpenJDK Runtime Environment Homebrew (build <IP_ADDRESS>+0)
OpenJDK 64-Bit Server VM Homebrew (build <IP_ADDRESS>+0, mixed mode, sharing)

Sure and yes.
➜  game git:(main) /usr/lib/jvm/java-17-openjdk/bin/java --version
openjdk 17.0.13 2024-10-15
OpenJDK Runtime Environment (build 17.0.13+11)
OpenJDK 64-Bit Server VM (build 17.0.13+11, mixed mode, sharing)

What happens if you run chmod +777 on the 'bin' folder? (give all rights, including writing rights)
Godot just tries to open the folder:
		// Check for the bin directory.
		Ref<DirAccess> da = DirAccess::open(java_sdk_path.path_join("bin"), &errn);
		if (errn != OK) {
			err += TTR("Invalid Java SDK path in Editor Settings.");
			err += TTR("Missing 'bin' directory!");
			err += "\n";
			valid = false;
		}

Moin @Alex2782; with full access rights (777) set on the Java SDK bin folder I receive the same error. If you're on Discord we can do a live debug session if this helps.
As mentioned, it's only the Steam version (v4.3.stable.official [77dcf97d8]) which throws the error. Launching Godot from the Arch (pacman) installation (v4.3.stable.arch_linux) everything works fine.

if you really need the steam version, you can download java from the official site, unpack zip into Download folder and set path to it. It works for me


Makefile: only download go-bindata when not available

Also, remove it from the repository module configuration, since we only
need the local binary

@jharrington22 - please take a look


Tests are failing for NodeJS v6

Last success test using node v5.10.1 (npm v3.8.3)
Latest failing test using node v6.3.0 (npm v3.10.3)

Related: https://github.com/donejs/donejs/issues/705

Seems like this is working fine again after https://travis-ci.org/donejs/generator-donejs/jobs/169654313. Possibly fixed by https://github.com/donejs/generator-donejs/pull/150. @ilyavf @justinbmeyer any issue with closing this?

https://github.com/donejs/generator-donejs/pull/150 was made against a major branch. Maybe this needs to be applied to master. @Sinjhin can you take a look?

We really only care about major right now.


Update kind library to v0.12.0 release

Feature Request
A new release of kind came out. We should update and test with this library in the unmanaged-cluster command.

@stmcginnis assigning this to you. Thanks!


[WIP] Upgrade paperclip to 4.3.7

lots of AWS warnings in the console now, but that's actually good.
Something seems to have been broken with regards to interpolations
though.
paperclip 4.2, video file 4k path:
=> "/v1/main/pageflow/video_files/000/002/290/dash/4k/rendition.mpd"
paperclip 4.3, video file 4k path:
=> "/v1/main/pageflow/video_files/000/002/290/rendition.mpd"
In other words, the `dash/4k' bit is missing.
Still need to figure out why and how. ZencoderAttachment maybe?

Coverage decreased (-0.4%) to 98.809% when pulling c52de0a302834054c01554753b41adbb08f4957b on scrollytelling:paperclip-4-3-7 into 91ee591757efb7d4557a470ffe97bafef6f4ecd7 on codevise:12-1-stable.

Coverage decreased (-0.4%) to 98.809% when pulling c52de0a302834054c01554753b41adbb08f4957b on scrollytelling:paperclip-4-3-7 into 91ee591757efb7d4557a470ffe97bafef6f4ecd7 on codevise:12-1-stable.

This problem is definitely in ZencodeAttachment @tf and to tell you the truth, I am not sure why it works right now! The file_name_pattern ends up in the base_name_pattern but not in the path method as far as I can see. Mysterious.

One part of the problem is that Paperclip now calls instance.class.name where it used to call instance.class.to_s. Since we only use a pretty lame double for instance, this blows up. Not sure, maybe switching to a real model might be worth it here.

The other is, Paperclip used to allow path segments in basename since it only did some Regex magic to get rid of the extension. Now it uses File.basename which throws away path segments.

paperclip calls instance.class.name

Not true for this patch, which is paperclip 4.3.7. They did drop the .to_s but left the rest intact.

Coverage decreased (-0.4%) to 98.826% when pulling 6c2881a17821117ef3762f574258365b16ef9f3a on scrollytelling:paperclip-4-3-7 into 91ee591757efb7d4557a470ffe97bafef6f4ecd7 on codevise:12-1-stable.

Coverage decreased (-0.4%) to 98.826% when pulling 6c2881a17821117ef3762f574258365b16ef9f3a on scrollytelling:paperclip-4-3-7 into 91ee591757efb7d4557a470ffe97bafef6f4ecd7 on codevise:12-1-stable.

Now it uses File.basename which throws away path segments.

This is indeed the case in 4.3.7.
I'll see what I can do to fix.

Coverage decreased (-0.4%) to 98.809% when pulling f9955980442c921626290cb5d01d078ab2d11a80 on scrollytelling:paperclip-4-3-7 into 91ee591757efb7d4557a470ffe97bafef6f4ecd7 on codevise:12-1-stable.

Coverage decreased (-0.4%) to 98.809% when pulling 6080642d318f654d72b085c37bddf3a1ac23fa02 on scrollytelling:paperclip-4-3-7 into 91ee591757efb7d4557a470ffe97bafef6f4ecd7 on codevise:12-1-stable.

@tf I changed the spec for the url template, but I think for the better. WDYT?

Coverage decreased (-0.4%) to 98.839% when pulling 98b3ef2bc3f81e44ab48639d3f20600145c70d8a on scrollytelling:paperclip-4-3-7 into 91ee591757efb7d4557a470ffe97bafef6f4ecd7 on codevise:12-1-stable.

Hi @tf
This is as far as I can take this, I'm afraid. I just don't know where to look for the url, path and basename and everything that relates to them! Sorry. I did chuck the test doubles and replaced them with real instances. Indeed, this is required otherwise paperclip will just insert the default_url.
You will have to take this to the finish line, sorry! The good news is, we need to do this anyway for paperclip 5.

Coverage decreased (-0.3%) to 98.912% when pulling 518accab5d3d7e30e0ebe21a8fc3d80a14a21a57 on scrollytelling:paperclip-4-3-7 into 91ee591757efb7d4557a470ffe97bafef6f4ecd7 on codevise:12-1-stable.

See #983.


Fix compilation failure on Julia 1.10

Julia 1.10 requires that no I/O resources are left open during module initialization. Thus, the code:
__init__() = start()

needs to be removed, and the user must call
PlotlyKaleido.start()

manually upon initialization.
I have implemented these changes. I have also updated the package version to 2.0 so that this does not introduce breaking changes in any existing dependent projects (though they will soon break anyways).
I also fixed a bug where kill() is defined incorrectly, as it conflicts with Base.kill(). It is now kill_kaleido.
Fixes #5
@BeastyBlacksmith would you be willing to merge this relatively quickly? This is currently breaking my package AirspeedVelocity.jl on Julia 1.10.

I don't like that you have to separately call PlotlyKaleido.start() but if it's unavoidable then it's unavoidable.  LGTM

Thanks, please merge when ready. Indeed it is a hard requirement of Julia 1.10, otherwise precompilation of downstream packages will hang [source]:

If you open an I/O resource during module definition, you now (Julia 1.10+) have to close it before exiting the module. Example of a fix:

Close timers in ondestroy JuliaGizmos/GtkObservables.jl#46

followed by more thorough housecleaning during precompilation: More explicit finalization JuliaGizmos/GtkObservables.jl#47

I can't remember if the 2nd PR was needed to fix precompilation, but I don't think so. But digging turned up more evidence that we were doing a bad job of freeing resources, so responding to the changes in 1.10 made the package better.

An alternative is perhaps to only run it when precompilation is not happening?

What's tricky is that it doesn't affect precompilation of PlotlyKaleido, because during precompilation we don't call __init__. (Maybe we should, though.) Instead, __init__ only gets called by packages that use PlotlyKaleido. And they'd have to be responsible for killing it.

guess you're proposing that the __init__ checks if we're precompiling,

How could we do that?

Magic incantation: ccall(:jl_generating_output, Cint, ()) == 1

PyPlot.jl uses this trick but somehow it still runs into the I/O issue seen here:

I mean, either the code that starts the process runs or not. So are you saying it still runs even with that guard?

I haven’t debugged the details so I can’t answer. But PyPlot.jl does have the I/O issue and I couldn’t find any other I/O resources other than what’s in that __init__ and protected by that guard.

I'll tackle this (but not today), I want to write up a little guide on how you debug these things as I go.


improvement: fix print msg in code snippet

Description
Fix print statement text in removing data code snippet

@googlebot I signed it!


Separate train and validation transformations

This introduces separate training and validation transformation to be defined in the respective model configs.
If nothing is defined, it will fall back to default behaviour at any time.
If only training transformations are defined, validation transformations will be set equal to those.
An alternative for handling this is raising a user warning, that one kind of transformations is defined and the other is not?
If there's something missing or if this should be implemented completely different, let me know.

@alexriedel1 the CI has failed due to formatting. We bumped up the black version due to some dependency conflicts, causing some formatting changes. Would you be able to update your black version, and run the formatting again.
For more details, see here:
https://github.com/openvinotoolkit/anomalib/blob/development/tox.ini#L16
https://github.com/openvinotoolkit/anomalib/blob/development/.pre-commit-config.yaml#L15

@alexriedel1 the CI has failed due to formatting. We bumped up the black version due to some dependency conflicts, causing some formatting changes. Would you be able to update your black version, and run the formatting again. For more details, see here:
https://github.com/openvinotoolkit/anomalib/blob/development/tox.ini#L16 https://github.com/openvinotoolkit/anomalib/blob/development/.pre-commit-config.yaml#L15

should be fine now.
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check Yaml...............................................................Passed
Check for added large files..............................................Passed
Debug Statements (Python)................................................Passed
Detect Private Key.......................................................Passed
black....................................................................Passed
isort....................................................................Passed
prettier.................................................................Passed
flake8...................................................................Passed
pylint...................................................................Passed
mypy.....................................................................Passed
pydocstyle...............................................................Passed

I just merged the development branch


page title

rake new page="project.md"

layout: page
title: "Projects"
{% include JB/setup %}
or title: Projects ?

Think you might have the wrong repo.


kindly upgrade image for fluentd

Is your feature request related to a problem? Please describe.
Your image ghcr.io/banzaicloud/fluentd doesn't pass generic security checks because it's based on old vulnerable versions of packets.
Describe the solution you'd like
Bump alpine version and fluentd components versions to the latest.
Describe alternatives you've considered
Provide security context for critical and high CVE if they are not relevant for the image (f.e. they are not being used by any functionality etc)
Additional context
How to reproduce:
scan your image with any tool available. F.e. trivy
trivy image --scanners vuln --severity critical,high ghcr.io/banzaicloud/fluentd
you will get a detailed report with fixed versions available.

@3rgfbrgf that image is not used anymore.
The current maintained fluentd images are:

ghcr.io/kube-logging/fluentd:v1.14 used in logging-operator v4.0.0 and v4.1.0
docker pull ghcr.io/kube-logging/fluentd:v1.15 used in master and first candidate for v4.2.0
docker pull ghcr.io/kube-logging/fluentd:v1.15-staging second candidate for logging-operator v4.2.0 or the next after that (contains alpine 3.17.3 and ruby 3.1.0)

I would recommend using the last one and sending us feedback about any issues it has, being it security or functional. I ran the security checks against it and it only found one, I'm going to look at that if I can fix it.

I forgot to add, that unfortunately we cannot upgrade the first two images, because later alpine versions have ruby 3 by default, this is why I recommend using the last one.
I created a PR to fix the single vuln trivy reported in it:
https://github.com/kube-logging/fluentd-images/pull/35


verify.sh: add whitespace in passing message

Fixes #162

this can be merged as well

this can be merged as well

btw.. you might want to add an entry in the ChangeLog file .

btw.. you might want to add an entry in the ChangeLog file .


week 14 of 2021 (April 4th - April 9st)

regate

recheck

regate

regate

Thanks for merging this, I forgot about it.


Dealing with page templates

Hey,
What a fantastic starting point for building with Vue!
Could you explain a bit in detail how page templates should be managed? In normal themes we usually create a page template for a certain page and apply it. I've noticed in the index.php that you load each of the template parts as a whole.
Let's say we had around 20 page templates being loaded via the index files, would this be bad for performance? Is there a more streamlined approach to applying page templates to specific pages?
Thanks!

Page templates won't be managed in the traditional "create a page", then apply a template and publish. Instead, it will be done through code. The steps are:

Create the template (add a new file in the templates directory). The content of that new template file will look similar to below.

`  //template id="your-new-template-name"

{{post[0].title.rendered}}

                <nopost></nopost>

 `
Note that the above is simply HTML, plus vue directives, along with components that is already built in the starter theme such as "header-component", "footer-component".

Next is to include this template in index.php (you're right, this could be better)

<?php get_template_part('/templates/your-new-template-name.php'); ?>

Create the component, using the template (in main.js)

const YourComponent = Vue.component('archive', {     template: '#your-new-template-name',      props: ['posts'] })

Lastly, add it to the routes section (in main.js)

{ path: '/your-route/', name : 'your-route', component: YourComponent },
*If you want to reuse the template in another page, simply add it to another route:
{ path: '/your-other-route/', name : 'your-other-route', component: YourComponent },

I had to delete my previous comment. It turns out - custom page templates are not working. Looking into it.

its actually not supported at the moment. keeping issue open and marking it as "enhancement"


[stable/prometheus-operator] Alert rules are created for components even if scrapes are disabled

Is this a BUG REPORT or FEATURE REQUEST?* (choose one): Feature Request
Version of Helm and Kubernetes:
Helm: 2.10.0
Kubernetes: 1.10.6
Which chart:
stable/prometheus
What happened:
If scraping of a particular Kubernetes components (e.g. API server) is disabled via Helm values, corresponding alert rules are still configured in Prometheus leading to alerts that are constantly firing.
What you expected to happen:
If scraping configurations are disabled then alert rules that would rely on those metrics should also be disabled.
How to reproduce it (as minimally and precisely as possible):

Deploy the prometheus operator chart with the below values set:kubeControllerManager:
  enabled: false

The below alert rule is still configured in the  PrometheusRule resource and will immediately enter an alerting state:  - alert: KubeControllerManagerDown
    annotations:
      message: KubeControllerManager has disappeared from Prometheus target discovery.
      runbook_url: https://github.com/kubernetes-monitoring/kubernetes-mixin/tree/master/runbook.md#alert-name-kubecontrollermanagerdown
    expr: |
      absent(up{job="kube-controller-manager"} == 1)
    for: 15m
    labels:
      severity: critical

Thanks @Evesy, this is definitely something I was planning on looking at, though I'm not sure how quickly I can get to it. As a workaround, you can copy out whatever rules you want into a separate prometheusRule resource and configure prometheus.prometheusSpec.ruleSelector to pick it up: https://github.com/helm/charts/blob/master/stable/prometheus-operator/values.yaml#L669

Hey @vsliouniaev -- I'm happy to work on a PR for this if you want to agree on an implementation?
I think a simple conditional on rules that rely on metricset x depending on if they're enabled/disabled is all it would need, thoughts?

This is the way it worked on the coreos charts, I think it's a good approach in the general case, but there may be variations:
We have an etcd and node exporter scrape configuration using additionalscrapeconfigs because of how our infrastructure is set up. In this scenario the rules and the exporter aren't necessarily tied to one another. To avoid having to manage the rules using two separate charts we used to just ignore the rules that were deployed with the exporters and roll our own configuration separately.
In the old chart architecture, it would be weirder to have on off switches for rules without deploying the corresponding exporter/service/servivemonitor. It would also be hard (impossible?) to have a global off switch for rules without using global.
TL;DR Sounds good, but I'd like to keep the global off switch of this makes sense.
@gianrubio, what do you think?

One solution would be having something like defaultRules.kubeScheduler.create which looks bad if I understood you correctly. Other way could be something like prometheus.prometheusSpec.defaultRules.kubeScheduler.enable which seems much better to me. When there will be some decision on this matter, I'll be happy create/test PR (in case @Evesy will prepare it).
By the way, this repo lost all mentions on how to configure prometheus-operator on GKE, was it intentional?

How about just an option to turn off the rules entirely, like it exists now?

In general I'd prefer to be able to configure these without copying everything to localhost and losing ability to stay up-to-date with upstream. In reality I've just started configuring these and already see what there are quite a few things to be adjusted in alerting and maybe maintaining the local copy is the only sane way.
I think it's better to ask someone with bigger experience, I have no vote power here but just glad to provide an extra pair of hands for such small adjustments. If you'll see anything prometheus-related where task is clear but you don't want to do it yourself, please cast me and I'll try to help.

In this case, I think it would be better to have an option to disable all rules, would you agree?

Yes, but I thought defaultRules.create is already doing so?

Ah yes, I'm just requesting that we keep it ;-)

If I've got it correctly, one way is to do nothing and other is to create a ton of options to disable particular default alerts so the user will be able to keep up-to-date community-maintained alerting. If you'll want this to go this way, ping me and I'll do it (but then we'll need to know where such options should live).

By the way, it seems like having multiply alert files will be more consistent with multiply dashboard files. That way also we could divide them into logical parts and each will be wrapped in it's own if statement.

@paskal Having additional dashboards doesn't automatically cause alerts to trigger, so I think it's ok to leave them in for now. Since dashboards are loaded from files and certain dashboards rely on multiple exporters being available I think it's simpler to leave them enabled, rather than creating additional complexity around their configuration.
If I was to implement this I would break out alerts so that deploying an exporter would be required to enable an alert. I would also have a global on/off switch for the rules as it exists now

I'll prepare PR which will separate alerts by files by logical parts (kubelet alerts, etcd alerts, and so on) and enable them with something like {{- if and .Values.defaultRules.create .Values.kubelet.enabled }}.
As per discussion in slack, additional variables to turn these on and off make everything too complex, so in scenario when someone need to disable data scraping for some element but have it's alerting she will need to add these rules separately.

I'll prepare PR which will separate alerts by files by logical parts (kubelet alerts, etcd alerts, and so on) and enable them with something like {{- if and .Values.defaultRules.create .Values.kubelet.enabled }}.
As per discussion in slack, additional variables to turn these on and off make everything too complex, so in scenario when someone need to disable data scraping for some element but have it's alerting she will need to add these rules separately.

please read https://github.com/helm/charts/pull/8908#issuecomment-434428551

Moving question from closed merge request there:
@gianrubio, can I propose separation of upstream rules into multiply files, or introduce if statements in existing file without changing anything else?
Also there is an issue with some non-etcd resources located in it's group, I might propose a PR to fix it in upstream, if there is a chance it will be merged.

@paskal I'd like to have a script similar to this that automatically sync the rules from prometheus-operator to helm charts. After we got this automation we can split the rules in multiple files. Do you want to adapt or rewrite this script?

@gianrubio, I'm a bit overwhelmed. Everything, even etcd have libsonnet file with monitoring rules, what should we do for this chart - collect these files from monitoring-mixin and etcd and build in-place, or use already built version from coreos/prometheus-operator?
@brancz, could you please give your advice as well?

The helm charts are entirely community maintained, I sadly can’t help you. We intense use the jsonnet based stack and can answer any question you have about that, if you have anything concrete. :)

What is preferable, fetch yaml from jsonnet directly, or take yaml from coreos/prometheus-operator (which in turn fetch it from jsonnet)?

I'm not sure I understand, but I recommend you to go through this readme if you are interested in the jsonnet based stack: https://github.com/coreos/prometheus-operator/tree/master/contrib/kube-prometheus#kube-prometheus

I've decided to go on with import from coreos/prometheus-operator (instead of importing kubernetes-mixin directly), I'll proceed once I'll get a working computer, two weeks ago my laptop broke and I did not had ability to wrap my head around this issue yet.

JIC it's still not resolved, but we got decision how to fix it and will be fixed after my PR merge.


Need to enable OpenGL logging

Need to enable OpenGL logging. The code is present but currently #if'd out.

Completed with commit 0d4ca89


Getting "document is not defined" with Next.js

Hi there,
I was trying your awesome library that works seamlessly without any framework. I tried it with Next.js and no matter what I do, I am constantly getting the error as attached "document is not defined". Any idea on how to solve this issue and use it with next.js.

see first section of this https://nextjs.org/docs/advanced-features/dynamic-import, client-side work only

Thanks for the reply, document error is resolved but I couldn't figure out
the way to get data-splitting attributes working in this way. I will really
appreciate a working demo for the same.
On Fri, 31 Dec 2021 at 11:13, Jeff Zhang @.***> wrote:

see first section of this
https://nextjs.org/docs/advanced-features/dynamic-import, client-side
work only
—
Reply to this email directly, view it on GitHub
https://github.com/shshaw/Splitting/issues/80#issuecomment-1003281636,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW7WFILZJR4GKAHHFBEL5N3UTVCYRANCNFSM5K5URPBQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

I'm having this issue with Svelte. I think since everything is moving over to Vite we really need a ESM module as well as IIFE.

Yes, I am having the same issue with next.js. A working solution with dynamic imports will be really appreciated.

Hi, try:
const Splitting = null;
if (typeof document !== undefined) Splitting = require('Splitting')

Also having some difficulties to get it to work in NextJS.
I managed to bypass the document undefined using a dynamic import using
 const callSplitting = async () => {
    const Splitting = (await import("splitting")).default;
    if (splitRef) {
      let split_res = Splitting();
      setLines(split_res[0].el);
      console.log(`Split text into ${split_res[0].el} lines`);
    }
  };

And this

Content Here

But somehow, It's not just working. I would appreciate a solution regarding this @shshaw

For anyone who is still struggling to use Splitting with Next.js, I combined all the answers from previous issues and I managed to get it working in with the following code:
import "splitting/dist/splitting.css";
import "splitting/dist/splitting-cells.css";

const Component = () => {

    let target;

    setTimeout(() => {
        if ( window && document && target ) {
            const Splitting = require('Splitting');
            Splitting({ by: "chars", target: target,  });
        }
    });

    return (
        <>
             { target = el; }}>Lorem ipsum dolor sit amet
        </>
    )
}

export default Component;

For anyone who is still struggling to use Splitting with Next.js, I combined all the answers from previous issues and I managed to get it working in with the following code:
import "splitting/dist/splitting.css";
import "splitting/dist/splitting-cells.css";

const Component = () => {

    let target;

    setTimeout(() => {
        if ( window && document && target ) {
            const Splitting = require('Splitting');
            Splitting({ by: "chars", target: target,  });
        }
    });

    return (
        <>
             { target = el; }}>Lorem ipsum dolor sit amet
        </>
    )
}

export default Component;

Thank you for this @draZer0


tf.raw_ops.Dilation2DBackpropInput aborts due to lack of out_backprop rank check

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
tf 2.17
Custom code
Yes
OS platform and distribution
Linux Ubuntu 22.04 LTS
Mobile device
No response
Python version
3.11.7
Bazel version
6.5.0
GCC/compiler version
clang 16
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
tf.raw_ops.Dilation2DBackpropInput aborts due to lack of out_backprop rank check. out_backprop.tensor<T, 4>() aborts if input out_backprop is not a 4-dim tensor. Adding rank check of out_backprop in ParseSizes would works. If the rank is less than 4, it aborts here. Note that same things happen on tf.raw_ops.Dilation2DBackpropFilter.
Error Location:
    functor::DilationBackpropInput<Device, T>()(
        context->eigen_device<Device>(), input.tensor<T, 4>(),
        filter.tensor<T, 3>(), out_backprop.tensor<T, 4>(), stride_rows,
        stride_cols, rate_rows, rate_cols, pad_top, pad_left,
        in_backprop->tensor<T, 4>());

Standalone code to reproduce the issue
import tensorflow as tf

tf.raw_ops.Dilation2DBackpropInput(
    input=tf.random.normal([1,1,1,1]),
    filter=tf.random.normal([1,1,1]),
    out_backprop=tf.random.normal([1,1,1,1,1]),
    strides=[1,1,1,1],
    rates=[1,1,1,1],
    padding="VALID")

Relevant log output
2024-02-13 18:06:49.413421: F tensorflow/core/framework/tensor_shape.cc:45] Check failed: NDIMS == dims() (4 vs. 5)Asking for tensor of 4 dimensions from a tensor of 5 dimensions
Aborted (core dumped)

@sushreebarsa
Please check it.

@sachinprasadhs I was able to replicate this issue on colab, please have a look at this.
Thank you!

Hi @Sehun0819 ,
Thanks for reporting along with debug.Added a fix in the attached PR.

@Sehun0819,
The related PR which was raised for the fix has been merged. Kindly find the comment from the Developer as well.
https://github.com/tensorflow/tensorflow/pull/63077
Also I tried to execute the mentioned code on tf-nightly, and it was not aborted like before and provided the error message which was expected. Kindly find the gist of it here. Thank you!


Feature Request: Ratios

SCENARIO:
What does the ratio 9:1 of 2 billion equal to?
ANSWER:
The ratio of 9:1 of 2 billion means that the total amount is divided into 10 equal parts, where 9 parts are one value and 1 part is the other value.
To calculate the specific values:

The total amount is 2 billion.
The ratio is 9:1, which means the total is divided into 10 equal parts.
9 parts are one value, and 1 part is the other value.
To find the value of each part, we divide the total (2 billion) by 10, which is 200 million.
So the 9 parts that are one value equal 9 * 200 million = 1.8 billion.
The 1 part that is the other value equals 1 * 200 million = 200 million.

Therefore, the ratio of 9:1 of 2 billion equals 1.8 billion : 200 million.

Soulver supports this function already with a different syntax.  See the Soulver docs for more information.


Allow lists of floats as Values

Current dependencies on/for this PR:

main

PR #20

PR #21

PR #22

PR #23   👈

This comment was auto-generated by Graphite.


Introducing attrs Guru on Gurubase.io

Hello team,
I'm the maintainer of Anteon. We have created Gurubase.io with the mission of building a centralized, open-source tool-focused knowledge base. Essentially, each "guru" is equipped with custom knowledge to answer user questions based on collected data related to that tool.
I wanted to update you that I've manually added the attrs Guru to Gurubase. attrs Guru uses the data from this repo and data from the docs to answer questions by leveraging the LLM.
In this PR, I showcased the "attrs Guru", which highlights that attrs now has an AI assistant available to help users with their questions. Please let me know your thoughts on this contribution.
Additionally, if you want me to disable attrs Guru in Gurubase, just let me know that's totally fine.

I removed it.


SELECT target FROM Relations - does not work in HTML Report

Version of Archi, Operating System
4.3 on Windows 10. Tested on browsers Chrome and Edge and inside Archi (HTML Preview)
Expected Behaviour
A list of id's should appear, when executing "SELECT target FROM Relations" in the query tab of an HTML report. E.g. "SELECT source FROM Relations" or "SELECT * FROM Relations" do return a list of id's. Selecting target doesn't
Actual Behaviour
Nothing happens, the input returns to empty
Steps to Reproduce the Behaviour

Generate of preview HTML report
Go to QUERY Tab
Execute "SELECT target FROM Relations"

Hi. That's because 'target' is a reserved word in alasql engine. I'll change it to something else (maybe 'tgt') in next release.

Hi, thanx for the fast response! Do you happen to know a work-around. Because now I can't join on Relations.target = Elements.id and can't generate a cross reference.

You could edit the frame.stg file found in:
plugins/com.archimatetool.reports_<IP_ADDRESS>809101333/templates/st
Line 46:
dataRelations.push({id:"^c.Id^", type:"^c.Class.SimpleName^", name:decodeURL("^c.Name;format="url-encode"^"), description:decodeURL("^c.Description;format="url-encode"^"), source:"^c.Source.Id^", target:"^c.Target.Id^"\});

Change target to tgt.

Thanx! I will change 'target' to 'targetid' and 'source' to 'sourceid'. So the naming will be more in line with the meaning. An alternative could be 'target-id' and 'source-id'.
Could you please let me know which names you will use. Because I want to store my queries and don't want to rewrite them :-)
BTW: Storing queries in Archi or using predefined queries in HTML report. would be nice feature of version 4.4 :-)

I'd go for "sourceid" and "targetid", but I'd like to also check other columns (at least for the naming, like in properties that should refer to "conceptid")
@Phillipus I'll do it during the week-end and will check other columns

Thanx!
Will you let me now which columns you change and their names, so I can change them in my version of frame.stg an re-use my queries in the next version of Archi

Hi,
I changed target in targetid and and source in sourceid in the frame.stg file found in: plugins/com.archimatetool.reports_<IP_ADDRESS>809101333/templates/st on line 46.
And I got the following SQL statement working:
select S.name as sourcename, R.type, T.name as targetname from Relations R, Elements S, Elements T where S.id = R.sourceid and T.id = R.targetid
Which gives a cross reference between elements and the kind of relation between them.
Four snags:

Use [table].[attribute] as syntax for name
Use old fashioned where statement, I didn't get the "join"keyword working
Watch the use of uppercase and lowercase. They should match precisely
Depending on your model: wait, because it takes some time. I tested on a small model and it took me four seconds.

If you change any other columns, I please let me know.
Thanx again!

Hi,

Use [table].[attribute] as syntax for name
Depending on your model: wait, because it takes some time. I tested on a small model and it took me four seconds.

2 and 4 are linked : not relaying on "join" keywords leads to very (very!) long execution time. I once converted a query that was taking more than 2min to load... once changed it was less than 5sec.

Watch the use of uppercase and lowercase. They should match precisely

Yes, maybe it would make sens to revert to lowercase everywhere, or set the alasql.options.casesensitive flag to false.

Hi,
That makes sense, no query optimizing like SQL server does (which I'm used to :-).
After some research I found out I can save the query results into CSV with:
SELECT * INTO CSV("ArchimateRelations.csv",{headers:true}) FROM Relations;
SELECT * INTO CSV("ArchimateElements.csv",{headers:true}) FROM Elements;
SELECT * INTO CSV("ArchimateProperties.csv",{headers:true}) FROM Properties;
I think I will do that en read the results into a database/query tool in which I can store my predefined queries en views. Of cause that's not 'real-time' and takes some manual steps, but I need it to facilitate the governance of our architectural models. So I don't need 'real-time' result. But I can imagine a lot of use cases which do deed a more 'real-time' and user friendly approach. Querying the architectural model  (and storing predefined queries) is a very powerful feature, so please continue developing it.
By the way:
(1) Since Properties.id is a primary key, I think the name should stay 'id' in the frame.stg file
(2) I like the alasql.options.casesensitive flag to false option, but have no I idea of where to set it
Thanx again!

After some research I found out I can save the query results into CSV with:

Yes, but in this case you'd better simply use the CSV export from Archi.

I think I will do that en read the results into a database/query tool in which I can store my predefined queries en views. [...] Querying the architectural model (and storing predefined queries) is a very powerful feature, so please continue developing it.

The next version (full rewrite) of the HTML report will support "saving" queries in the model itself (through some model-level properties or object, yet to be defined) and will also allows you to passe the query through the URL, so bookmarking a query will be possible too.

Since Properties.id is a primary key, I think the name should stay 'id' in the frame.stg file

But Properties.id is not a primary key: this is the key of the object that has the property set.

I like the alasql.options.casesensitive flag to false option, but have no I idea of where to set it

You can set it in plugins/com.archimatetool.reports_<IP_ADDRESS>809101333/templates/st/frame.stg around line 211:
[...]
alasql.options.logtarget = 'myconsole';
alasql.options.casesensitive = false;
alasql.prompt('myprompt','useid');
[...]

Dear all,
the problem with
SELECT target FROM Relations
seems to still exist in 4.3.2.  A potentially related problem is that
SELECT value FROM Properties
does not yield results either. Or rather the recognized SQL command in this case is
SELECT COLUMN _ FROM Properties
and it outputs the whole Properties table.

Also if you run
SELECT * FROM Elements
the column 'description' is always empty, irrespective of whether the Documentation in the ArchiMate model is actually populated.

@Phillipus I'll look at this. This is partly related to another issue about Alasql reserved words which should be fixed, and some informations are still not exported. I'll provide a fix for next release ;-)

I have played around a bit with the alasql prompt. I also added a table
with the folders locally as I want to run queries for components in
specific folders.
What would be a nifty has is the following:
If you have a diagram with some graphical element (e.g. a note) on it that
can have properties it would be cool to double-click the note and have
alasql run a query stored in the properties of the element as a simple
reporting feature.
Currently I keep my queries in a text editor but having them embedded in
the html report would really be nice.
Am Do., 7. Feb. 2019, 11:26 hat Jean-Baptiste Sarrodie <
<EMAIL_ADDRESS>geschrieben:

@Phillipus https://github.com/Phillipus I'll look at this. This is
partly related to another issue about Alasql reserved words which should be
fixed, and some informations are still not exported. I'll provide a fix for
next release ;-)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/archimatetool/archi/issues/400#issuecomment-461364548,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJsqq50H11NT2kAuOimEZ1uG5GAy4VNnks5vK_9rgaJpZM4W-Vdh
.

This is fixed in the new html-query-fix branch.
Here are the changes:

Table Relations has been renamed to Relationships
Relations.target has been renamed to Relationships.targetid
Relations.source has been renamed to Relationships.sourceid
Properties.id has been renamed to Properties.conceptid
Properties.key has been renamed to Properties.propkey
Properties.value has been renamed to Properties.propvalue
View are no more exported (they were exported as elements, which they are not)

Fixed in Archi 4.3.3.


Add HelloWorld in JavaScript

What does the program do ?
The programn prints a HelloWorld in JavaScript on the console and using an alert.
In what programming language it is written?
JavaScript.

Thank you for participating  in hacktoberfest ❣ if you liked working on this repo you can share it with friends and star this project for helping others


card counter

Users should be able to determine the current amount of cards in the database inside the editor.

Introduced in 49727668fa7345dc8e2115c017ae0b6eaf9458c0


Multi kbc stack support

Application is not deployed to EU.
And it looks like it is not ready for different KBC stacks https://github.com/keboola/config-migration-tool/blob/4b5158ab27f01c97447ce563c3a5d93faa133245/src/Keboola/ConfigMigrationTool/Service/OrchestratorService.php#L19

https://keboola.zendesk.com/agent/tickets/9610

Also migration app is not deployed to EU

Tu url syrupu by to nejlépe mělo vytáhnout ze services sapi aby to nepotřebovalo image_parameters.
https://github.com/keboola/app-gooddata-writer-migrate/blob/8f67e279aec6a5be4e4e7f3c0013c4b40c1228ce/src/GoodDataWriterClientV2.php#L28


Windows Server and SQL Server supported versions

What are the specific reasons why MIM 2016 SP1 on Sharepoint 2016 is not supported on Server 2019? Server 2019 is a supported server version for Sharepoint 2016.  Would that be ok with the portal? Is there an issue with the MIM 2016 SP1 Sync service and Server 2019? What about SQL Server 2017? What makes it not a supported platform for MIM 2016 SP1? Could we run SQL Server 2016 SP2 on Windows Server 2019 which is a supported server version for that version of SQL server.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b3fbb109-0afc-6a7b-2486-0d6412501d10
Version Independent ID: 54e31b36-d865-79e6-0949-3fd9a2ce6978
Content: Supported software platforms
Content Source: MIMDocs/microsoft-identity-manager-2016-supported-platforms.md
Product: microsoft-identity-manager
GitHub Login: @billmath
Microsoft Alias: billmath

We typically introduce support for using MIM with new versions of dependencies or platform components in the next MIM service pack after that dependent software is generally available.  As customers should be upgrading to MIM 2016 SP2 we won't be retroactively adding support statements to previous MIM service packs.

#please-close


Add an explicit timer and stop it

Time.After() will create a goroutine that won't get GC'd until the timer is triggered.  Really long timeouts therefore will cause slow memory leaks.  Here we manually stop the timer if someone triggers the completion channel, thereby aiding GC.
@Workiva/dtbackend

Raven
Number of Findings: 0

+1

+1

+1

QA review can be found here: https://jira.atl.workiva.net/browse/RM-16142


Support for custom Globally Unique ID field name

According to https://relay.dev/docs/guides/graphql-server-specification/#object-identification the Node interface should have a field named id with the Globally Unique ID. However, for simpler APIs it can be beneficial to have the name of this field customized to expose the raw object id under the field id, and the global id under a different name (e.g. global_id).
This is achieved by using a metaclass for the Node abstract class which defines the field according to the value of config.RELAY_GLOBAL_ID_FIELD_NAME.

Known issues

The value of config.RELAY_GLOBAL_ID_FIELD_NAME is always passed to to_camel_case, so the strawberry's auto_camel_case configuration is ignored.
Any library relying on the id field being named id won't work (but I guess this should be fine since this is an opt-in settings clearly conflicting with relay libraries).
It uses meta-programming, which may not make IDEs super happy.
A test is not passing because somehow this changes the behavior of the printer for the Node interface.

More info about the failed test
Previously the generated schema had the description comment only at the definition of the interface, while the types implementing the interface had the field undocumented.

Previously
"""An object with a Globally Unique ID"""
interface Node {
  """The Globally Unique ID of this object"""
  id: GlobalID!
}

type ProjectType implements Node {
  id: GlobalID!

  """The name of the project"""
  name: String!
}

Now every instance of the derived id field also includes the docstring.

Now
"""An object with a Globally Unique ID"""
interface Node {
  """The Globally Unique ID of this object"""
  id: GlobalID!
}

type ProjectType implements Node {
  """The Globally Unique ID of this object"""
  id: GlobalID!

  """The name of the project"""
  name: String!
}

I'm clueless on why, and I'm not even sure if this matters (is it a good practice to not include the docstring of implemented interfaces?). If this is ok, I can update the schema used for the tests and make the last test pass.

CC: #57

Hey @edomora97 . It is being a while since you opened this PR. I didn't review it because the tests were failing, had you have the opportunity to fix those?

The relay integration was contributed to strawberry lib, so I'm closing this PR


"Unable to detect feed format" for not modified feeds!

when i use etag/last_modified, i get error Unable to detect feed format error. but only for not modified feeds!
so i was forced to leave the etag/last_modified saving and checking :|

Which feed? Everything works fine for me

for example this feed.

Works fine for me, are you on master?

i install picoFeed by Composer.

i installed picoFeed by Composer.

Well, that doesn't answer the question.
Would you please post some example code that raised the issue you're describing!


Remove ip_in_core feature

This PR removed the ip_in_core feature from defmt and re-enables nightly shapshot tests. See #803 for details.

Rust 1.77 is out! https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html
Would it be possible to get a release after this is merged?

Rust 1.77 is out! https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html
Would it be possible to get a release after this is merged?

Sure

Removing a cargo feature is a breaking change, right?

Removing a cargo feature is a breaking change, right?

Yes, but the feature can be left in (without doing anything) to avoid this.

@newAM defmt 0.3.7 was released just now


Made some minor changes to get_started_vertex_training_pytorch

In this PR, we have made some minor changes in the notebook (get_started_vertex_training_pytorch)
If you are opening a PR for Community Notebooks under the notebooks/community folder:

[x] This notebook has been added to the CODEOWNERS file under the # Community Notebooks section, pointing to the author or the author's team.
[x] Passes all the required formatting and linting checks. You can locally test with these instructions.

/gcbrun

/gcbrun


Expose current worker identity for started pending activity

Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
Expose more info from server internal pending activty info (StartedIdentity).
For long running task, it's nice to know which worker picked current task.
Describe alternatives you've considered
No.
Additional context
same cadence feature request

Thank you for the feature request! This is a great idea that would be very useful for long-running tasks.
Currently, Temporal doesn't expose the StartedIdentity for pending activities. A possible workaround would be to use a custom activity that logs the worker identity at the beginning of its execution.
We are always looking for ways to improve Temporal and your feedback is valuable. We'll consider this feature request for future releases.

Thank you for your feature request!
This is a great suggestion. Currently, Temporal does not expose this level of information directly.
For long-running tasks, it's helpful to know which worker is handling the current task. This can be achieved by:

Logging: You can customize the logging of your workflow and worker to include the worker's identity information. This would require you to manually add logging statements to your code.
Custom metadata: You could implement your own custom metadata system within your workflows. You can attach metadata to the task or the workflow itself to store the worker's information.

We appreciate your feedback and will consider adding this feature in future releases.


Clarification on cross account image for lambda

https://github.com/awsdocs/aws-lambda-developer-guide/blob/main/doc_source/lambda-images.md
Currently, creating a lambda function from the console using an image from a private ECR repository in another AWS account says the image is invalid. The host ECR repo has
  "Version": "2008-10-17",
  "Statement": [
    {
      "Sid": "AllowPull",
      "Effect": "Allow",
      "Principal": {
        "AWS": "arn:aws:iam::XXX:root"
      },
      "Action": [
        "ecr:BatchCheckLayerAvailability",
        "ecr:BatchGetImage",
        "ecr:DescribeImages",
        "ecr:DescribeRepositories",
        "ecr:GetDownloadUrlForLayer"
      ]
    }
  ]
}```
It would be good to find out if there is a documentation regarding this

Currently, the account that creates the Lambda function must be the same account that owns the private image. I will add that as a note in this permissions section.


Just trying to set it up but failed

Hi,
I know it's embarrassing to ask but at the moment I start to feel that I have to.
I came across a few segmented controls and found Segmentio. It looks great so I want to use it in my own project.
Honestly, this has been the most frustrating tool I have ever tried.. Because after reading the tutorial, set up minimal things Segmentio needed and booted it up, it didn't work. Showing two big coloured box, as I configured, without responding to clicks...
it looks like it's frozen..
So then I tried to set Segmentio up with the options, carefully taking snippets from, again the tutorial without modifying anything, still it's frozen...
I started to doubt my life...
After played around it a while, I realised that if I set the height of the Segmentio view to 150, I would see things and it responds to click. However console is giving me this printout ever time a tab is clicked:
2017-08-06 04:14:22.447 app[53497:25921392] The behavior of the UICollectionViewFlowLayout is not defined because:
2017-08-06 04:14:22.448 app[53497:25921392] the item height must be less than the height of the UICollectionView minus the section insets top and bottom values, minus the content insets top and bottom values.
2017-08-06 04:14:22.448 app[53497:25921392] The relevant UICollectionViewFlowLayout instance is <UICollectionViewFlowLayout: 0x7fd75862ee60>, and it is attached to <UICollectionView: 0x7fd75904f400; frame = (0 0; 414 150); clipsToBounds = YES; gestureRecognizers = <NSArray: 0x618000250b30>; layer = <CALayer: 0x61800022ca20>; contentOffset: {0, -64}; contentSize: {552, 37}> collection view layout: <UICollectionViewFlowLayout: 0x7fd75862ee60>.
2017-08-06 04:14:22.448 app[53497:25921392] Make a symbolic breakpoint at UICollectionViewFlowLayoutBreakForInvalidSizes to catch this in the debugger.
I started again, to doubt my life...
What I did was very basic. I set up a view in navigation controller, which is inside a tab view controller. So basically, above the Segmentio view, it's the navigation bar. Below the Segmentio view, it's a empty table view, below that, is the tab bar.
I used story board to set the class and IBOutlet. Nothing fancy..
Somebody please safe my life...
Thanks in advance.

My tab bar was frozen too until but I fixed it by specifying the SegmentioStates.
Basically I swapped this:
SegmentioStates(
    defaultState: SegmentioState(),
    selectedState: SegmentioState(),
    highlightedState: SegmentioState()
)

for the code in the README.md file:
SegmentioStates(defaultState: SegmentioState(backgroundColor: .clear, titleFont: UIFont.systemFont(ofSize: UIFont.smallSystemFontSize), titleTextColor: .black),
	selectedState: SegmentioState( backgroundColor: .orange, titleFont: UIFont.systemFont(ofSize: UIFont.smallSystemFontSize), titleTextColor: .white),
	highlightedState: SegmentioState( backgroundColor: UIColor.lightGray.withAlphaComponent(0.6), titleFont: UIFont.boldSystemFont(ofSize: UIFont.smallSystemFontSize), titleTextColor: .black)
)

And i can now click on the tab items.

@biogerm  do you need more feedback on this issue?

sorry i switched to another tab after about a week after I posted the question. I would come back later to try it out.

ok, than reopen it later if you would need it


make ToJSONFilter instances that also pass the meta when walking the pandoc tree

I'm not in favor of this, because as noted in your earlier query, you can simply use a Reader monad with the current API.


More idiomatic parse for face, gamepad, etc

In eg https://github.com/wenkokke/tree-sitter-talon/blob/fd202684c693d1b893fe34575209452424cc9909/grammar.js#L213 we get face( as a single, anonymous node.  That doesn't feel super idiomatic.  I'd be tempted to instead have a named node for face, or at least to have an anonymous node for face that is labeled by a field such as callee or something.  WDYT?
Fwiw for now we're working around this by using a regex to shrink the match we get from tree-sitter (using our own custom #shrink-to-match! query predicate operator), so we're able to work around it, but it's a little bit awkward 😅

This is essentially the same issue as #21, from the other side.
The issue remains that it is quite difficult to do consistent and reliably correct parsing and error correcting once the grammar becomes a little bit ambiguous.
As always, I am happy to take suggestions and pull requests, but I am afraid that the optimal solution would be to handle differentiating between commands and other types of declarations in the scanner... which involves messing with a hand-coded lexer in bare bones C++.

Ah right, so if you don't make face( a single token, then it's much harder to match talon's behaviour where face( and face ( parse differently. Makes sense. We can live with this setup; our workaround is fine. Feel free to close, or leave open if you might one day tackle with a more sophisticated lexer


[Update Request]:

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
RoyalApps.RoyalTS.V7
Package Version
7.02.50410
Please describe the changes you would like to see
No response

@mschtc if you could change the title of this issue to the following that would be great:
[Update Request]: RoyalTS.V7 7.02.50410

Sorry forgot it - name changed/added


Unamed Button next to filter button

**What is the use of that button which is next to filter button?
I would like to contribute on it
Screenshot of the Button

The initial purpose of the button was to sort students according to some specified category. Do you still want to work on it or should I mark it as open for contribution for others? @UnnatiBhalekar

Okay..Please mark it open for others...
On Mon, Mar 22, 2021 at 2:07 PM Tejas Morkar @.***>
wrote:

The initial purpose of the button was to sort students according to some
specified category. Do you still want to work on it or should I mark it as
open for contribution for others? @UnnatiBhalekar
https://github.com/UnnatiBhalekar
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/devscollab/skill-board/issues/93#issuecomment-803872729,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOGPTZ3ZN3KIPLBTKW5MSPTTE36TVANCNFSM4SE77DPA
.


Binance-R1

Binance-R1 -> master

Codecov Report

Merging #43 into master will decrease coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   15.30%   14.96%   -0.35%
==========================================
  Files           7        7
  Lines        1006     1069      +63
==========================================
+ Hits          154      160       +6
- Misses        844      896      +52
- Partials        8       13       +5

Impacted Files
Coverage Δ

...cation/builtin/contract/deposit/deposit.wrapper.go
0.00% <0.00%> (ø)

...et/application/builtin/contract/deposit/deposit.go
2.50% <0.00%> (+2.50%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3cb4f...de5fc75. Read the comment docs.


body  overflow:scroll issue on new Portal.js HOC Overlay

In the new HOC (react-toolbox/components/hoc/Portal.js), the unrenderOverlay method causes a horizontal scrollbar to appear unnecessarily in at least Google Chrome. Furthermore, because it appears as an inline style, it's specificy wins. In the code below, document.body.style.overflow needs to be set to null instead of 'scroll'. I am happy to submit this fix as a pull request. Am I missing something that requires the body style to be set to scroll?
 _unrenderOverlay () {
    if (this._overlayTarget) {
      if (this.props.lockBody) document.body.style.overflow = 'scroll';
      ReactDOM.unmountComponentAtNode(this._overlayTarget);
      this._overlayInstance = null;
    }
  }

I missed that, both the x-overflow and the property value. It should be at auto instead of scroll when it's re-enabled. I'll be happy to accept a PR about it and release a patch :)

have same issue. fix would be awesome )

I work with @joevbruno and have discussed this with him... along with the overflow = 'null' PR that he submitted, we think we know of a way to let users get the behavior that they need.
I checked Joe's PR and although it partially addresses our need (which is for React Toolbox to not mess with our body styles), it has some unwanted side effects such as delayed removal of the scrollbar - making the opening / closing of the Drawer not as smooth as it was (because the space for the vertical scrollbar that appears/disappears on Windows causes the Drawer to "jump" during that entry/exit because of the setTimeout - which is not synched to the Drawer opening/closing).
Therefore, along with his PR, a better option would be to let users "opt-out" of your control messing with the body style... and the great thing is that you already have most of the hooks/infrastructure in place to provide this!
Just provide a prop for Drawer for lockBody and pass that down to Portal.  Portal already checks for this prop, but we have no way to pass it in...

Thoughts?

@jasonkylefrank  idea look good. expect part that you will need to update all components that use overlay/ portal like date time picker.

Hi and thanks for your comments! I think that locking the body can be definitively optional but truth is that I don't see it as a desired behavior because in that case the Overlay would be placed there but scrollable what makes not too much sense I think. Of course it's better to provide an option anyway!
To avoid the priority of an inline style we can add a class instead or writing directly the style. I did not tried that yet but I suppose it would work in the same way. We are always free to go back to the previous implementation but this way is easier. If you want to try this change along the day and provide feedback it would be great, I plan to release it this afternoon.
Thanks! :)

Hi @javivelasco, thanks for looking into this!  So you're planning to provide the lockBody prop to Drawer then (which would get passed down to Overlay and then Portal)?
Regarding your statement:

I don't see it as a desired behavior because in that case the Overlay would be placed there but scrollable what makes not too much sense I think.

When we used the Drawer before version 16 we did not find the Overlay itself to be scrollable (even when the Drawer content itself required scrolling), or show scrollbars on the page.  So I may not understand what you mean there.  Can you enlighten me?

Of course! In previous versions we provided an App element which was wrapping the whole tree structure. This element was absolute positioned over the body and had an scroll overflow meaning that when you used a React Toolbox application the scrolled element never was the body but this app wrapper. It was needed because the Overlay was set as a fixed element taking the whole screen. As it was placed right in front of the container element the scroll was "blocked". Also, components reading position like the Ripple were easier because they didn't need to count on the scroll. Without the wrapper, even adding the fixed element, the body height would still be there and the content would be scrollable of course.
The problem with this, apart the "uglyness" of adding a container for the app was that browsers can't provide the usual animations on scrolling because they are applied over the body. The body never should be styled thought IMO.
With the latest release I wanted to get rid of the App element and still block the body for overlays. The best way I've found to do so is to set overflow hidden to the body. This way if the content was scrolled it would stay at it's position while the scrolling is not possible. Then, at hiding, it would restore the overflow making the body usable again.
I think we can provide a prop for components that use the Overlay and block the body to make it optional. It's just to pass props through as you said. Anyway I think it's not very useful because opening a drawer with a backdrop that does not block the height sounds quite weird. Maybe the best option would be just to add a class to block the body to avoid priority and not overriding body props in case you are using them.

@javivelasco It may be that we didn't experience some of the things you are describing because we did not use the React Toolbox App wrapper...

In previous versions we provided an App element which was wrapping the whole tree structure. This element was absolute positioned over the body and had an scroll overflow meaning that when you used a React Toolbox application the scrolled element never was the body but this app wrapper.

But what I think you're describing is that when the Overlay is applied, you want the scrollbars to disappear so that the user cannot scroll the content of the page that is partially visible underneath the Overlay scrim.  In that case, I understand the situation, because I actually had to specifically handle that when I was using the Drawer on the right-hand-side because I needed the body scrollbar to disappear so I could introduce a scrollbar for the right-hand-side Drawer and not have the user have "double-scrolling" (one for the body and one for the right-hand-side Drawer).
So it sounds like we want the same general thing.  Maybe the main difference is how it is implemented.  The way it is handled in v16+ via the setTimeout is probably what is causing the UX to not feel as good as how we did it internally (which removed the scrollbar immediately as the drawer was about to open).  See my earlier comments about things "jumping" for what I mean here.
I think you may be able to execute the scrollbar-handling code without a delay though...

I think you could get the scrollbar-handling code to execute immediately by utilizing a new prop called isTransitioningToActive (and you might also need a isTransitioningToInactive):

Then Portal could react to isTransitioningToActive and isTransitioningToInactive in its componentWillReceiveProps.  It might look something like:
componentWillReceiveProps (nextProps) {
  if (nextProps.isTransitioningToActive && !this.props.isTransitioningToActive)  {
    // add a css class to <body> which handles removing scrollbar
  } else if (nextProps.isTransitioningToInactive && !this.props.isTransitioningToInactive) {
    // remove the css class from <body>
  }
}

Thoughts?

I see the issue now. Portal component removes the lock when it is removed from the document. setTimeout is used in ActivableRenderer to keep a window for the animation before removing the inactive DOM elements. The issue is that this is also delaying the unlocking.
It should be easier than what you propose in my opinion because probably this is a symptom showing that the component responsible from locking the body is not the Portal but the Overlay. In my opinion we should remove the locking from Portal and add this in the Overlay:
  componentDidMount () {
    if (this.props.active) {
      this.escKeyListener = document.body.addEventListener('keydown', this.handleEscKey.bind(this));
      document.body.style.overflow = 'hidden';
    }
  }

  componentWillUpdate (nextProps) {
    if (nextProps.active && !this.props.active) document.body.style.overflow = 'hidden';
    if (!nextProps.active && this.props.active) document.body.style.overflow = null;
  }

What it's weird to me is that without using the App wrapper the overlayed components locked your scroll 😕 Maybe you had styles that allowed to do so. I've tested it and it's working. Maybe you'd want to give a try before publishing

@javivelasco Yeah, moving the scrollbar-handling to Overlay might be a good idea.  It probably would be simpler, as you say.  I'd have to try it out to see if the "jumping" gets corrected.
Regarding:

What it's weird to me is that without using the App wrapper the overlayed components locked your scroll

We were handling the body overflow css ourselves when the drawer opened/closed (i.e., becameactive).  We toggled a CSS class on the body element.
Your new proposed solution looks like its worth a try... except that it should toggle a CSS class instead of setting the style inline.  😀    And I'm still in favor of providing a prop so users can opt-out of the CSS class being applied in case they want to handle the transition in a specific way themselves.

Yeah, it's better to provide a prop to make it optional and use a class. That's sure. You might like to check #450 as well because the wrapper removed is affecting more than I initially thought. I'm feeling like it was a wrong decision :(

In the short term why aren't we just changing
document.body.style.overflow = 'scroll';
to
document.body.style.removeProperty('overflow')
Or alternatively check what the property was previously, store it then make it
originalOverflowProperty ? document.body.style.overflow =  originalOverflowProperty : document.body.style.removeProperty('overflow')
Happy to make PR for that change.

We've hit this problem as well. The latest proposal from @ro-savage makes total sense to me — I'd expect the component to cleanup after itself.
Also IMO it makes more sense to add / remove a class than an inline style — it's easier to trace where it comes from this way.

Hadn't heard anything so went ahead and made a PR. Feedback is welcome.

Fixed in dev!


Mjml API rest client Java library.

I would like to contribute to the mjml community by creating a java library to use the mjml API.  I think this is important because the Java developer community is huge.
I created this project in:
https://github.com/atrujillofalcon/mjml-rest-client

Hey @atrujillofalcon, thanks a lot for sharing!
We'll add it on https://mjml.io/community
I'm closing the issue and adding this in our todo :)


Changed semantic of Offset variable

In the latest version of Deadlus the variable Offset appears to contain the number of remaining bytes in the stream (offset from the end) and not the offset from the beginning of the stream.
This breaks the definition of the following parser that is used to align the stream to a certain number of bytes:
def PadTo n = {
    @here = Offset;
    { (here % n == 0) is true; ^ {} } <| @(Many (n - (here % n))  UInt8);
}

Is this an intended change? If so how do we get access to the offset since the beginning of the stream?

No this was a bug, sorry about that.   I fixed the issue on the current master (a3498dd919ca325a22), let me know if that soled the problem, and we can close the ticket.
Just FYI, when in doubt, you can try the --core flag to daedalus.  This uses a different interpreter that should behave exactly like the normal one.   Please let us know if you ever notice a different behavior between those two, as this is a fairly strong indication of a bug.

Ok I have verified the latest version (from master) have the fix. Thanks


Add support for Unpack in args and kwargs

Add support for Unpack in args and kwargs
add stub support

Followups:

Error for unsupported objects in Unpack (right now they just generate a signature that will never match)
Clean up the signature to split it into individual params, so the sig for def f(*args: *tuple[int, str]) would have two pos-only params instead of a single var-positional. In the process, allow nameless pos-only params, so we don't leak things like __arg0 into error messages.


Lift IFA_ -constants from linux/gnu to linux

Description
Lift IFA_ -constants from linux/gnu to linux/mod.rs
Sources
Constants are defined in linux/if_addr.h
Checklist

[x ] Relevant tests in libc-test/semver have been updated
[ x] No placeholder or unstable values like *LAST or *MAX are
included (see #3131)
[x ] Tested locally (cd libc-test && cargo test --target mytarget);
especially relevant for platforms that may not be checked in CI

Since these are uapi, could you just lift the existing gnu definitions to Linux/mod.rs?

Lifted to constants to linux/mod.rs and updated the wording of this PR to reflect that. I would also like to nominate this change to be included in stable branch. @rustbot label stable-nominated


Clean up some 2.13 warnings

Codecov Report

Merging #1120 into master will increase coverage by 0.03%.
The diff coverage is 91.66%.

@@            Coverage Diff            @@
##           master   #1120      +/-   ##
=========================================
+ Coverage   84.37%   84.4%   +0.03%
=========================================
  Files          77      77
  Lines        2503    2508       +5
  Branches      179     181       +2
=========================================
+ Hits         2112    2117       +5
  Misses        391     391

Impacted Files
Coverage Δ

...o/circe/generic/util/macros/DerivationMacros.scala
76.47% <ø> (ø)
:arrow_up:

...e/generic/extras/decoding/EnumerationDecoder.scala
100% <100%> (ø)
:arrow_up:

...hared/src/main/scala/io/circe/scodec/package.scala
93.33% <80%> (+0.47%)
:arrow_up:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
92.5% <0%> (-1.25%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/Decoder.scala
90.53% <0%> (-0.3%)
:arrow_down:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
90.36% <0%> (+0.6%)
:arrow_up:

...d/src/main/scala/io/circe/NonEmptySeqDecoder.scala
100% <0%> (+8.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 771cbce...94e80eb. Read the comment docs.