[BEAM-14337] Support **kwargs for PyTorch models

We currently only support ability to pass in a single Tensor that does not have any keys attached to it: model(input). We want to support kwargs like this: model(**inputs).
Because of the way Beam returns BatchElements(), we need to convert a list of (key to Tensor) dicts into a dict of Tensor lists.
This PR also adds support for non-batchable params that are passed in as side inputs.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

R: @AnandInguva

PTAL @AnandInguva @ryanthompson591

Updated code per feedback. PTAL @ryanthompson591 @TheNeuralBit

BTW, this is a case where schema'd rows would be very natural.

R: @tvalentyn

retest this please

PTAL @TheNeuralBit

I took a closer look today. It seems that this PR combines 3 different efforts:

Support for batched keyed examples. The key-batched values are passed to pytorch model via kwargs in model() call.
Support for non-batchable kwargs params.
Add an interpreted parameter prediction_params.

There is collusion of kwargs meaning in 1 and 2.  We could explain in the PR description that these are independent efforts (if my understanding is correct).
While I can squash all the changes into one commit before merge, for those looking up the commit history later, it may be easier to follow if efforts 1-3 were separate commits in the repo. Do you want to squash commits accordingly?

Makes sense. We can do I've squashed the commits related to 1 into a single commit. Items 2 and 3 are closely interrelated, so I squashed them into a second commit in a new PR here https://github.com/apache/beam/pull/21733. This is done in a new PR because to 1) preserve history in this PR, 2) make it a cleaner rebase

I think coverage is failing because during the coverage run we don't have pytorch installed and the test is skipped.
Merged the new PR.

Thanks a lot everyone. thanks @yeandy for cleaning up the commit history.

Thanks @tvalentyn for the feedback and merge.


Usage question

Hello,
Can littlefs-fuse be used to mount an existing file system image? For example, I'm able to get the binary from the flash chip we're using with LFS... I mount this file using the method shown in the README, but no data is shown. I can create new files and they are written to the binary file, but the existing data isn't shown by ls. When I use LFS on the target, the directories are seen and the files are able to be written to. I've verified that the data does seem to be in the binary as well. The names of the directories that I've made are in there, at least.
Thank you!

Hi @keck-in-space, sorry for such a late response.
One step that is easy to overlook is existing filesystems need to be attached as a "loop device". (This isn't technically needed, but currently littlefs-fuse uses ioctls to get the physical block size.)
losetup /dev/loop0 image
./lfs /dev/loop0 mount

Another thing to check is that the major version of littlefs-fuse matches the major version of the disk. If the disk is v1 you would need the v1 branch of littlefs-fuse:
https://github.com/ARMmbed/littlefs-fuse/tree/v1
If that is not the issue, let us know. Though I would likely need a disk image to debug what is happening. Having all files missing is a strange bug and I'm not sure how that could happen.

Thanks, @geky! I'll make sure I'm mounting it correctly, though I think I am. I am using the latest release of littlefs and of littlefs-fuse, so I think the versioning should be OK as well. Anyway, I'll take another look at my mounting procedure and if that doesn't fix it, report back.


Victor VosMottor: Watch n16645

Victor VosMottor requests the watch of the watch_keyword n16645. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

n16645 has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Overlaps with the one I just submitted but let's merge them.

Approved by tripleee in Charcoal HQ


'az functionapp list' errors out

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az functionapp list or az functionapp show --name xxx
Errors:
No module named 'decorator'
Traceback (most recent call last):
python3/dist-packages/fabric/connection.py, ln 5, in <module>
    from invoke.vendor.six import StringIO
ModuleNotFoundError: No module named 'invoke.vendor.six'

...

python3/dist-packages/fabric/connection.py, ln 10, in <module>
    from decorator import decorator
ModuleNotFoundError: No module named 'decorator'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az functionapp list

Expected Behavior
Environment Summary
Linux-4.4.0-18362-Microsoft-x86_64-with-glibc2.29
Python 3.8.2
Shell: bash

azure-cli 2.0.81

Extensions:
azure-devops 0.17.0

Additional Context

functionapp

duplicate with https://github.com/Azure/azure-cli/issues/14800.
did you install azure-cli via pip? If yes, it might caused by situation in #13343 (comment). Could you pls install decorator? Recommended way to install azure cli is there: #14011

Originally was installed by apt but looks like that this version is unsupported?
anyway I have reinstall it from https://aka.ms/InstallAzureCLIDeb and looks ok now


Collapsing evaluation Heatmap to top 10

Use case
As a user, I have an SLO config containing 10+ SLI - typically 50 or more - and would like to have a collapsed Heatmap showing just the first 10 SLIs. With a Show all SLIs button I can expand the Heatmap to see all SLIs; with an Collapse to 10 SLIs button I can collapse the Heatmap to the top 10.
Details
Mockup to explain the idea (but ignore the name of the SLIs because they are just copy-pasted).

Just show the first 10 SLIs
To display all, a user has to click the Show all SLIs button.

Is it possible to position the button as shown in the mockup? If not, move it to the top left corner.

The data is already available. The feature is implemented on the UI

After expanding the Heatmap, the Show all SLIs button is changed to Collapse to 10 SLIs allowing collapsing the Heatmap.

Acceptance criteria

By default, just the first 10 SLIs in the Heatmap are shown.
A button allows expanding the entire Heatmap

Definition of Done

[x] Feature is implemented in the Bridge
[x] Unit Tests

I added unit tests instead of integration test, e2e tests would be flaky, because it depends on the number of defined SLOs and with unit tests there is more control over this.


Parallel Implementation of Basic Filter Function

Changes:

The original 'lambda' filter now breaks the hatchet dataframe into n subframes and spawns n processes to perform apply on each of them in parallel; where n is the number of logical cpu cores available.
multiprocess has been added to the requirements.txt and dependencies.

multiprocess is a fork of the pandas standard multiprocessing that uses dill instead of the pickle library so we can pass lambda functions to our parallel_apply function

Results:
In the following figure you can see the absolute runtimes of our pre-optimized and post-optimized filter function. This chart was generated from runs on a single node on Quartz. All parallel runs were executed over 72 logical cores. With this level of parallelism we can see that our filter function now runs an order of magnitude faster for each of our tested datasets.

Speedup chart coming soon.

So I may be wrong here bc I might not have enough of a reference but this seems like an ill-advised application of parallelism. It seems to me that If any form of parallelism were to be applied here, it would be multithreading with a thread-pool so that each call to filter doesn't incur the overhead of creating/destroying new resources... but CPython of course has the GIL. Creating processes is pretty heavyweight and maybe it works well on Unix where you have copy-on-write but you are probably absolutely destroying the performance of anybody trying to use Hatchet on Windows -- creating threads are order of magnitude slower, creating processes are that + more.
Additionally, consider if someone is running hatchet within MPI or any other form of multiprocessing... which timemory theoretically allows users to do since it provides direct memory access within python -- at the very least, I believe this needs to be optional and not default to using parallelism, e.g.
def filter(self, filter_obj, squash=True, nprocs=1):

    if nprocs > 1:
        # run your parallel version
    else:
        # run serial version

Also, seems a bit unnecessary to make psutil a requirement just for logical vs. physical cpus. I don't have a Windows version but this works fine for getting the physical CPU count on Linux and macOS:
import platform

def get_physical_cpu():
    if platform.system() == "Linux":
        cpuid = lambda x: x if "core id" in x else None
        return len(set(filter(cpuid, list(open("/proc/cpuinfo", "r")))))
    elif platform.system() == "Darwin":
        import os

        return int(os.popen('sysctl hw.physicalcpu').readlines()[0].split()[-1].strip())

So I may be wrong here bc I might not have enough of a reference but this seems like an ill-advised application of parallelism. It seems to me that If any form of parallelism were to be applied here, it would be multithreading with a thread-pool so that each call to filter doesn't incur the overhead of creating/destroying new resources... but CPython of course has the GIL. Creating processes is pretty heavyweight and maybe it works well on Unix where you have copy-on-write but you are probably absolutely destroying the performance of anybody trying to use Hatchet on Windows -- creating threads are order of magnitude slower, creating processes are that + more.
Additionally, consider if someone is running hatchet within MPI or any other form of multiprocessing... which timemory theoretically allows users to do since it provides direct memory access within python -- at the very least, I believe this needs to be optional and not default to using parallelism, e.g.
def filter(self, filter_obj, squash=True, nprocs=1):

    if nprocs > 1:
        # run your parallel version
    else:
        # run serial version

Also, seems a bit unnecessary to make psutil a requirement just for logical vs. physical cpus. I don't have a Windows version but this works fine for getting the physical CPU count on Linux and macOS:
import platform

def get_physical_cpu():
    if platform.system() == "Linux":
        cpuid = lambda x: x if "core id" in x else None
        return len(set(filter(cpuid, list(open("/proc/cpuinfo", "r")))))
    elif platform.system() == "Darwin":
        import os

        return int(os.popen('sysctl hw.physicalcpu').readlines()[0].split()[-1].strip())

All excellent points. Especially concerning the overhead introduced by running multiprocessing on Windows, I was unaware of this difference and can see why that is a major problem. I look into it and see what options I may have for that. Perhaps a check to see if the user is on a Windows system and eschew parallelism all together?
Thank you also for the custom implementation for checking the available CPUs. I agree that is a much nicer solution and avoids the unpleasant dependency of psutil.
On the topic of why I chose parallelism as the solution to this particular problem. I came to it after exploring a few options with Stephanie earlier in the summer. All the runtime overhead was bound to pandas' DataFrame.apply. Since user's can pass in any lambda expression which could operate on any column in the dataframe, cythonizing this process or pushing it to C seemed overly difficult as the pandas data frame would be difficult to convert into a c-like datastruct. If I knew the column(s) being filtered  I think it would be much more realistic to implement by transferring them to numpy arrays and passing them into a C function. Getting that information would require some reflection and metaprogramming which we agreed was overly-complicated.
Failing this, I noted that this operation is embarrassingly parallel with the only overhead in a one-time transfer of subframes to-and-from each process. I am very much on the same page as you re: threading vs. spawning up new processes; however, as you said, the GIL prevented use of threads from producing real parallel speedup. In implementing this function, I noted that we used multiprocessing elsewhere in Hatchet (specifically in the HPCToolkit Reader) and presumed that if it worked there then it would be fine in filter.
I think I can definitely implement that check which makes the parallelism optional. I also wonder if we should also implement it in the HPCToolkit_reader? @slabasan @bhatele Your thoughts on this?

Changing to WIP while I remove dependency for psutil and add optional parallelism.

Thanks for making that parallelism optional. Also, w.r.t.:

Since users can pass in any lambda expression which could operate on any column in the dataframe, cythonizing this process or pushing it to C seemed overly difficult as the pandas data frame would be difficult to convert into a c-like datastruct. If I knew the column(s) being filtered I think it would be much more realistic to implement by transferring them to numpy arrays and passing them into a C function. Getting that information would require some reflection and metaprogramming which we agreed was overly-complicated.

I may take care of that for y'all at some point. It depends how much of an issue it becomes for me down the road. Which I suspect it might bc between the python function- and line-tracing-profilers and the automatic binary instrumentation, these profiles get very large -- making efficient filtering critical. It would definitely merit more discussion though bc (as you noted) there is no easy way to do this in C but I could very easily do the reflection/metaprogramming in C++ with pybind11. But doing so would of course would require some some changes to the build system and require a C++ compiler to build Hatchet which, naturally, might not be desired. Alternatively (for seamless integration), some way to "replace" what filter actually calls might be an option to consider, e.g. theoretically:
class GraphFrame:
    # class instance of some externally defined filtering function
    filter_plugin = None

    # ... etc.

    @staticmethod
    def from_timemory(input=None, select=None):
        try:
            import timemory
            Graphframe.filter_plugin = timemory.hatchet.extensions.graphframe_filter
        except ImportError:
            pass

        # ... etc.

    def filter(self, filter_obj, squash=True, num_procs=mp.cpu_count()):

        if GraphFrame.filter_plugin is not None:
             return GraphFrame.filter_plugin(self, filter_obj, squash, num_procs)

        # ... etc.


Documentation for setex is wrong

https://redis-py.readthedocs.io/en/latest/#redis.Redis.setex
Should be setex(name, time, value)
proof:
>>> s.setex('hi', 1000, 100)
True
>>> s.get('hi')
'100'
>>> s.ttl('hi')
988L
>>> s.ttl('hi')
983L
>>> s.ttl('hi')
982L

That's why the docs also suggest using the StrictRedis client class instead of the Redis client class: https://redis-py.readthedocs.io/en/latest/#redis.StrictRedis.psetex

Yeah my bad, I was using StrictRedis


[ENHANCEMENT]

Hey,
Can we modify other countries background color(not the entire map's background) apart from the one we are getting in data property. And is it possible to add name of the oceans in map.
Thanks.

Hey @code-scavenger-007,
Thanks for checking out my map and for the suggestions! For the ocean labels, that is a pretty straightforward feature. I can add a boolean called enable-ocean-labels or something for you to use.
As for changing the color of the map, I see 2 options: either 1, use the current customStylingFunction to essentially tell the map which countries you want to change color (I can help with that implementation if you want, kind of hacky) or I can make another custom function for you where you can pass a list of countries for keys and colors for values and I can make the background based off of those if you want, that might just take me a but more time.
Thanks,
Yams

Hi, I've solved part of the issue: the style function is now applied to every country, whether highlighted or not. It's now the user's responsibility to handle the two cases with different logic if they want.
For the ocean labels, I'm thinking about a more generic createMarkup API which you can pass coordinates and labels to draw your own text labels on the map.


Patch README.md - Homebrew locations

Upon setting up I've found that the gcloud command completion configs are no longer located in /usr/local/... Instead I've found that on my machine, Homebrew now sets this up in /usr/local/Caskroom/...

It looks like this isn't a change in the homebrew default it's dependent on your hardware. Ref: https://apple.stackexchange.com/questions/437618/why-is-homebrew-installed-in-opt-homebrew-on-apple-silicon-macs
Looks like this means the update should actually mention both instead of switching to the intel hardware location.

You're absolutely right on this one @chris-sanders it looks like that on my other machine so I'll make sure to remove this PR.


Page type isn't displayed within the page's editor

I'm more than happy to be corrected on this one, but it seems to me that when I have the page editor is shown for a given page nowhere in the interface is the page type displayed. Even if I had an inkling of type from location, this wouldn't be inferrable from the URL as within the editor it becomes http://content-management.systems/admin/pages/130/edit/. My only options seem to be to infer it from the page's title, or to visit the explorer.
Which raises the question: why is it shown in the explorer, but not in the page editor?
In fairness, I've only needed to find a page's type when developing (e.g. so I could know where to look for the model's class definition), and I have no experience of using the CMS as an editor, so if it were a case of adding something that only shows when settings.DEBUG == True that may suit most needs for this.

It would also be really nice to have a class name added to the form that indicates the page type. This will allow javascript and css added through wagtail hooks to easily identify the page type, and limit themselves to specific types as needed.

I think this issue can be closed now that #904 is merged.

Hi @coredumperror, you are correct.
Marking this a closed now.
@davecranwell if the solution from #904 requires further design input, it is probably best tackled with other "several pieces of meta information conspicuously absent from the page editor interface".


[SourceKit/swift-ide-test] Consolidate duplicated logics between completion like requests

(based on #28282 I'll rebase this after that PR is merged)
Consolidate duplicated logics between completion like requests: code completion, type context info, and conforming method list.

Support VFS in typecontextinfo and conformingmethods requests too.
For SourceKit, implement SwiftLangSupport::setupCompilerInstanceForCodeCompletion()
For swift-ide-test, implement doCodeCompletionImpl()

@swift-ci Please test

Superseded by https://github.com/apple/swift/pull/28727 . Closing


Basic question on forms/dialogs

I'd like to make a very basic question concerning -specific, not all- forms and particularly dialogs:
Is there a way to arrange the various elements (labels, text boxes, etc) as one wishes supposedly with the use of HTML, CSS, Bootstrap, or other code or not. Or is that Serenity won't allow for any amendments to a form/dialog automatically created arrangement of the various elements?
This is very important to me as I will or will not allow to go on with Serenity.
Thank, you!

Serenity allows a certain amount of personalization using less and/or html hacks.
Search a bit in the issues u'll find several samples.

@brunobola I have searched anywhere, all answers are vague. You say I will find several samples and there are no samples and all the other answers are the same type, no one tells me which sample exactly they are referring to. I don't know if there is a way to achieve this, answers of the type, you can do it, doesn't help me at all, I don't ask whether I can do it generally or hack my way to it, I ask how exactly I can do it. I have searched all samples and there is none solving my problem. I have made a big project with Serenity, I was going to buy the professional plan that Serenity offers in order to extend and reserve my project and It's been months searching to find a solution to my problem and I can't do anything to finish the last piece of my project. Therefore, I will not continue with Serenity as I have no time for trying to solve this and I don't get any info or help due to lack of information and the fact that Serenity is known by a small amount of people makes it even harder.

I suggest you to do this:

https://serenity.is/demo      -> and see what you expect in Professional
https://github.com/volkanceylan/Serenity/wiki     -> See the wiki
3 . https://legacy.gitbook.com/book/volkanceylan/serenity-guide/details      -> Guide
https://github.com/volkanceylan/Serenity/issues/2720      -> One Sampls

This is very important to me as I will or will not allow to go on with Serenity.

Can only say good luck.

Thanks @volkanceylan for the advice.!
That's exactly what I want,


feat(devices): provide a amt activation url for copy

Codecov Report

Merging #300 (e050df1) into master (327ea74) will increase coverage by 0.18%.
 Consider uploading reports for the commit e8f409b to get more accurate results

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   49.58%   49.77%   +0.18%
==========================================
  Files          33       34       +1
  Lines         851      888      +37
  Branches       89       92       +3
==========================================
+ Hits          422      442      +20
- Misses        395      411      +16
- Partials       34       35       +1

Impacted Files
Coverage Δ

src/app/shared/shared.module.ts
66.66% <ø> (ø)

src/app/devices/devices.component.ts
41.66% <50.00%> (-0.89%)
:arrow_down:

src/app/shared/add-device/add-device.component.ts
55.55% <55.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 327ea74...e8f409b. Read the comment docs.


Go to definition with multiple definition shows peek but doesn't explain why

execute a go to definition where the symbol has multiple definitions
the peek experience shows up with all the definitions

This is good, but since I wasn't aware that there are multiple definitions it wasn't obvious to me, why peek shows up and why I don't jump immediately to the definition, see below.
The peek zone should provide a hint in the title Multiple Definitions Found that explains why peek shows up.

will show in the title when >1


Update .travis.yml

Hang on, on re-reviewing this one (from myself), I'm actually no longer sure why I did this, or if this is a good idea... on the contrary, I think this would make testing future PRs such as #235 impossible? I just raised #289 to confirm that - I expect it will fail... if that is so, I'll Abandon this.
What may work and be a much more minor Good Idea is simply #290 though?


Numeric values are not green or right-justified in Windows 10 64-bit

In Windows 10 64-bit, numeric values are not visually distinct from character values
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
On Windows 10 64-bit, running the 64-bit or 32-bit Java Runtime Environment, create a new project, selecting Parse cell text into numbers, dates, ...
OR
From within a current project, convert a column of numerals into numeric values by "Edit Cells --> Common Transforms --> To Number"; or transform a column of numerals into numeric values with the GREL toNumber(value)
Current Results
In Windows 10, the numeric values are neither green nor right-justified. In MacOS 10.14.4, numeric values are green and right justified.
Expected behavior
Numeric values in Windows 10 should be green and right-justified (visually distinct from character values), just as they are in MacOS.
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Version: Firefox 66.0.3
JRE or JDK Version: JRE 1.8.0_211

OpenRefine (please complete the following information):

Version: OpenRefine 3.2 beta

Datasets
01-exercise.tsv

@jerrywaller thanks for reporting this issue.
I'm aware (and have submitted a fix for) this issue in OpenRefine 3.2 beta but that affected all platforms as far as I know. Can you double check that on the Mac you were definitely using 3.2 beta?

Ah! Yes, sorry. The Mac is running 3.1. I can test the beta on another Mac.

Thanks @jerrywaller - I don't think you need to - that problem definitely exists in 3.2 beta and I've no reason to think it doesn't apply no matter which platform you use

Fixed by #2008


Add daepyung elementary school

@minjunoreo I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host gwanggyohosue.goe.go.kr not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Pausing does not work with a negative playback rate

This is reproducible on the test page http://shaka-player-demo.appspot.com/
Load a video with trick play enabled.  Press the rewind button and then hit the pause button.  The video will continue to rewind.

Thanks for the report. We'll take a look.

Just to let you know this bug is still present in 1.4.2.  The test page shows the behavior as well

Thanks. I believe this should be fixed in 1.4.1. The regression is most likely from bc7b826e41e2cc96dbc2196d1924045489f35a74.


fix(tests): Use macos 13 with x86 architecture

Ref #21
Ref #19

Until github action macos using M3 processors with support to nested virtualization is available use macos-13 instead of macos-latest.
custom resources test fix
Set registry on <IP_ADDRESS> outside of kind for macos

All is left is some instability with the macos 13 runner image 20240819.2. The macos 13 runner image 20240825.1 works better with colima launch.


Some dataset don't work in the Table Chart Mode

The following two example datasets don't work when I try to apply the Table Chart Type.
I get an error message, that the data couldn't be loaded.
It works when I apply another Chart Type as for ex. Bar Charts.
  https://test.visualize.admin.ch/en/browse/dataset/https%3A%2F%2Fenvironment.ld.admin.ch%2Ffoen%2Ftobias_holz_beschaffung_institutionell_test%2F2?dataSource=Int

  https://test.visualize.admin.ch/en/browse/dataset/https%3A%2F%2Fenvironment.ld.admin.ch%2Ffoen%2Ftobias_holzernte_m3_version3%2F3?dataSource=Int

What is the context of those datasets, do you know of anything that could be peculiar about them ?

Yes these two datasets where provided to me as example datasets for the pivot table. See https://gitlab.ldbar.ch/bafu/umweltdatenkiosk-planning/-/issues/300
I wanted to see how they currently perform as tables and noticed that they don't work

It has therefore not a priority. I can work around it, but just thought we should look into it at one point

Related to #457?

In sprint 4.5 @bprusinowski will check in Cube Creator to see how large the data set is.


When setDialogFullHeight() the getPositiveButton() is not display problem, cannot make it in same time

Please provide a way to reproduce the issue in the sample app.


Update httpAdapter.js

Use encodeURI to process query strings with spaces and other such characters.
batchBody.push(request.method + ' ' + encodeURI(urlInfo.relativeUrl) + ' ' + constants.httpVersion);

@tiwariarvin great spot and thanks for the PR.  Again could you add a simple test to prove functionality.

I'll sort the test out so thanks for the PR!

This fix is now in the new release (v1.11.3).
Here is the test I added for it
https://github.com/jonsamwell/angular-http-batcher/blob/master/tests/services/adapters/httpAdapter.spec.js#L123

Thanks Jonsamwell,
Sorry that could not include test as was occupied with work for a product we are wrapping up.
Cheers
Arvin


Save cluster_counts_size_norm as it is being updated

This is candace on Hadeesha's account again. @cliu72
Is your feature request related to a problem? Please describe.
After the Pixie refactoring, the code was changed such that cluster_counts_size_norm isn't saved to a feather file until the very end of the notebook. This is a problem when users with large datasets are not able to run the entire notebook in one sitting. Because cluster_counts_size_norm isn't saved, there is no way to map cells to cell clusters without going through the entire notebook.
Describe the solution you'd like
Save cluster_counts_size_norm to the feather file after clustering and metaclustering are done (and before the end of the notebook).

@cliu72 we should add better fallback recovery for this to the cell clustering notebook as well. Here's one way we could do it:

If cluster_counts_size_norm_path already exists, load the file at the beginning instead of calling create_c2pc_data again. Same with weighted_cell_channel_path.
In cluster_cells, if cell_pysom.cell_data already has a cell_som_cluster column attached, return the data as is (and don't re-run the clustering step as we currently do). Add an explicit feather.write_dataframe command at the end of this cell.
Similar to step 2 but for cell_consensus_cluster and the cell_meta_cluster column. Add an explicit feather.write_dataframe command at the end of this cell.

Let me know if we're missing anything.


SIGSEGV during startup and chain sync (lnd 0.3 alpha)

I'm getting a segmentation fault soon after startup, failing to sync chain in neutrino mode:
2017-08-29 17:03:28.893 [INF] RPCS: RPC server listening on <IP_ADDRESS>:10009
2017-08-29 17:03:28.893 [INF] LTND: Waiting for chain backend to finish sync, start_height=1180427
2017-08-29 17:03:28.893 [INF] RPCS: gRPC proxy started at localhost:8080
2017-08-29 17:03:35.648 [INF] CMGR: DNS discovery failed on seed testnet-seed.bitcoin.schildbach.de: lookup testnet-seed.bitcoin.schildbach.de: Temporary failure in name resolution
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x86f086]

goroutine 31 [running]:
github.com/lightningnetwork/lnd/vendor/github.com/lightninglabs/neutrino.(*blockManager).current(0xc4204d4b60, 0xc4200115f4)
	/home/aantonop/gocode/src/github.com/lightningnetwork/lnd/vendor/github.com/lightninglabs/neutrino/blockmanager.go:713 +0x146
github.com/lightningnetwork/lnd/vendor/github.com/lightninglabs/neutrino.(*blockManager).handleInvMsg(0xc4204d4b60, 0xc420016ac0)
	/home/aantonop/gocode/src/github.com/lightningnetwork/lnd/vendor/github.com/lightninglabs/neutrino/blockmanager.go:762 +0x773
github.com/lightningnetwork/lnd/vendor/github.com/lightninglabs/neutrino.(*blockManager).blockHandler(0xc4204d4b60)
	/home/aantonop/gocode/src/github.com/lightningnetwork/lnd/vendor/github.com/lightninglabs/neutrino/blockmanager.go:331 +0x3ae
created by github.com/lightningnetwork/lnd/vendor/github.com/lightninglabs/neutrino.(*blockManager).Start
	/home/aantonop/gocode/src/github.com/lightningnetwork/lnd/vendor/github.com/lightninglabs/neutrino/blockmanager.go:207 +0x114

This panic should go away with the newest code; though this may not fully fix the issue. Can you please update and try again? Thanks!

Closing due to ref'd commit.

I'm getting the same error here while unlocking the wallet. The only difference is that I'm not syncing chain in neutrino mode.
2017-12-15 13:54:06.087 [INF] HSWC: HTLC manager for ChannelPoint(a26a76be46cbe3f1fbfa11aaaaa8f256eedd6cf94135b34266b52ba3364e9abb:0) started, bandwidth=996380000 mSAT
2017-12-15 13:54:06.087 [INF] HSWC: Attempting to re-resynchronize ChannelPoint(a26a76be46cbe3f1fbfa11aaaaa8f256eedd6cf94135b34266b52ba3364e9abb:0)
2017-12-15 13:54:06.096 [INF] SRVR: Established connection to: <IP_ADDRESS>:9735
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1803e66]

goroutine 328 [running]:
main.(*peer).logWireMessage(0xc4201ec840, 0x20e1a80, 0xc420a0e000, 0x20e1a01)
	/Users/cristobal/gocode/src/github.com/lightningnetwork/lnd/peer.go:930 +0x8d6
main.(*peer).readNextMessage(0xc4201ec840, 0x0, 0xc42027bce8, 0xc42027be78, 0xc42027bce8)
	/Users/cristobal/gocode/src/github.com/lightningnetwork/lnd/peer.go:457 +0x167
main.(*peer).readHandler(0xc4201ec840)
	/Users/cristobal/gocode/src/github.com/lightningnetwork/lnd/peer.go:656 +0x1b9
created by main.(*peer).Start
	/Users/cristobal/gocode/src/github.com/lightningnetwork/lnd/peer.go:286 +0x847

Hey, ensure you are running with latest update, should be fixed by https://github.com/lightningnetwork/lnd/commit/ce6dee6ee4c3d4b161db65058c8afa4f541bae1f


Bump good_job from 3.99.1 to 4.1.0

Re-opening #871

We've come to the conclusion that a race condition is occurring due to the way our infrastructure is currently set up. When creating a review app, two containers start up at the same time:

Rails app (to serve web traffic)
Good Job worker (to execute async jobs)

The Rails app checks for database migrations and runs them at startup, before starting the web server.
The Good Job worker depends upon the database, and assumes that all pending migrations have been completed before it starts. However this is not the case, because the Rails app and Good Job worker both start at the same time.
This has presumably not been a noticeable problem in the past because the Rails migrations happened 'quickly enough' that the required Good Job tables were in place before the worker started up. However since we've needed to update the schema for Good Job v4 (#840), and new databases for review apps are built by running every migration sequentially (rails db:migrate) rather than loading the schema from schema.rb (rails db:prepare), the database now takes longer to end up in the state required by the worker.
We've decided to change this to a more sensible strategy: run migrations first in a standalone container, and wait for them to finish before starting the Rails app and Good Job worker containers. This is generally recognised as the best practice pattern to follow, so it'll be an improvement upon the existing approach.
I've created a separate Trello card for that: https://trello.com/c/LcIqY4Fo/630-update-terraform-configuration-to-run-migrations-before-starting-the-app-and-worker
I'm closing this PR and will re-attempt the Good Job v3 → v4 upgrade once we've implemented the infrastructure changes. For now, this task is blocked, and is tracked on our Trello board as: https://trello.com/c/jei9Q02P/581-upgrade-to-good-job-v4


Install Package Update

Is there a newer version of the Azure Function Runtime - Installer for on-premise installations or a package that can update existing installations

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a304f1aa-ac44-7831-2f2c-f827238fc50e
Version Independent ID: 6610a9cc-2a03-5305-3378-392c4a1227ac
Content: Azure Functions Runtime Installation
Content Source: articles/azure-functions/functions-runtime-install.md
Service: functions
GitHub Login: @apwestgarth
Microsoft Alias: anwestg

Hi Grahame,
the version linked to in the document is the most recent release, which was released in November 2017. There are no updates available to that release.
Thanks
Andrew

@grahamehorner As shared by @apwestgarth in the comment above, version November 2017 is the most recent release.
We will now close this issue. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

@apwestgarth @Karishma-Tiwari-MSFT is it possible to build the package from source? if so could you please point me in the direction of source/instructions?

@grahamhorner no, it is not possible to build the package from source as we package far more than just the runtime in the installer and these elements are not available in public repositories.


Update direct-manipulation.md

Fixed spelling and changed html to .md in tables.

Please review - I made the change directly in GitHub after I reviewed in VSC. It needs 1 review. Thanks!

Docs Build status updates of commit ba6eb30:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/direct-manipulation.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 889f2d7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/direct-manipulation.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Crash for lighthouse.puppeteer.headless=false using docker sitespeed.io-plus1: Unable to open X display

I'm using docker container sitespeedio/sitespeed.io:14.4.0-plus1. When running lighthouse in headful mode (lighthouse.puppeteer.headless=false), it fails with Unable to open X display.
Config:
{
  "lighthouse": {
    "iterations": 2,
    "extends": "lighthouse:default",
    "puppeteer": {
      "headless": false,
      "args": ["--no-sandbox", "--disable-gpu", "--disable-setuid-sandbox"]
    }
  },
  "browsertime": {
    "xvfb": true,
    "headless": false,
    "visualElements": true,
    "iterations": 1,
    "browser": "chrome",
    "video": true,
    "visualMetric": true
  },
  "cpu": true,
  "plugins": {
    "remove": ["/gpsi"]
  }
}

Crash when lighthouse starts:
% docker run --rm -v "$(pwd)":/sitespeed.io sitespeedio/sitespeed.io:14.4.0-plus1 --config config.json testurls.txt                     Google Chrome 85.0.4183.83
Mozilla Firefox 80.0
[2020-09-16 08:59:57] INFO: Versions OS: linux 4.19.76-linuxkit nodejs: v12.16.2 sitespeed.io: 14.4.0 browsertime: 9.4.0 coach: 5.1.1
[2020-09-16 08:59:58] INFO: Will run Lighthouse tests after Browsertime has finished
[2020-09-16 08:59:58] INFO: Running tests using Chrome - 1 iteration(s)
[2020-09-16 08:59:58] INFO: Use Chrome trace categories: -*,disabled-by-default-lighthouse,v8,v8.execute,blink.user_timing,devtools.timeline,disabled-by-default-devtools.timeline,disabled-by-default-devtools.timeline.stack
[2020-09-16 08:59:58] INFO: Testing url https://www.example.com iteration 1
[2020-09-16 09:00:11] INFO: https://www.example.com 2 requests, TTFB: 542ms, firstPaint: 595ms, firstVisualChange: 607ms, FCP: 595ms, DOMContentLoaded: 574ms, LCP: 595ms, CLS: 0, TBT: 0ms, Load: 575ms, speedIndex: 607ms, perceptualSpeedIndex: 607ms, contentfulSpeedIndex: 607ms, visualComplete85: 607ms, lastVisualChange: 607ms
[2020-09-16 09:00:11] INFO: The server responded with a 404 status code for https://www.example.com/favicon.ico
[2020-09-16 09:00:11] INFO: Start collecting Lighthouse result for https://www.example.com iteration 1
[2020-09-16 09:00:11] ERROR: Lighthouse could not test https://www.example.com please create an upstream issue: https://github.com/GoogleChrome/lighthouse/issues/new?template=Bug_report.md Error: Failed to launch the browser process!
[649:649:0916/090011.676127:ERROR:browser_main_loop.cc(1468)] Unable to open X display.
Received signal 11 SEGV_MAPERR<PHONE_NUMBER>00
#0 0x55f751a5e399 base::debug::CollectStackTrace()
#1 0x55f7519bf2a3 base::debug::StackTrace::StackTrace()
#2 0x55f751a5df35 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7fb6189aa3c0 (/usr/lib/x86_64-linux-gnu/libpthread-2.31.so+0x153bf)
#4 0x55f754454f38 ChromeBrowserMainExtraPartsViewsLinux::~ChromeBrowserMainExtraPartsViewsLinux()
#5 0x55f751606140 ChromeBrowserMainParts::~ChromeBrowserMainParts()
#6 0x55f751605cfe ChromeBrowserMainPartsLinux::~ChromeBrowserMainPartsLinux()
#7 0x55f74fcff1bf content::BrowserMainLoop::~BrowserMainLoop()
#8 0x55f74fcff2ce content::BrowserMainLoop::~BrowserMainLoop()
#9 0x55f74fd03c2b content::BrowserMainRunnerImpl::Shutdown()
#10 0x55f74fd03738 content::BrowserMainRunnerImpl::~BrowserMainRunnerImpl()
#11 0x55f74fcfed30 content::BrowserMain()
#12 0x55f751589796 content::ContentMainRunnerImpl::RunServiceManager()
#13 0x55f7515893c7 content::ContentMainRunnerImpl::Run()
#14 0x55f7515eaad1 service_manager::Main()
#15 0x55f751587631 content::ContentMain()
#16 0x55f74efdd5ae ChromeMain
#17 0x7fb616de30b3 __libc_start_main
#18 0x55f74efdd3ea _start
  r8:<PHONE_NUMBER>000000  r9:<PHONE_NUMBER>000001 r10:<PHONE_NUMBER>000002 r11: 000008a8659c22e8
 r12: aaaaaaaaaaaaaaaa r13: 000008a865a23b40 r14: 000008a8659c2338 r15: 000008a865a4f620
  di: 000008a8659c2300  si: 000008a865aeeef0  bp: 00007ffd82d72b00  bx: 000008a8659c2300
  dx: 000008a865aeeef0  ax:<PHONE_NUMBER>000000  cx: fffffffd504587f9  sp: 00007ffd82d72af0
  ip: 000055f754454f38 efl:<PHONE_NUMBER>010206 cgf: 002b000000000033 erf:<PHONE_NUMBER>000004
 trp:<PHONE_NUMBER>00000e msk:<PHONE_NUMBER>000000 cr2:<PHONE_NUMBER>000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.

@laserval you need to start xvfb in the container for that to work. we have that built into Browsertime, but nothing for the lighthouse plugin.

@laserval you need to start xvfb in the container for that to work. we have that built into Browsertime, but nothing for the lighthouse plugin.

I see. From looking at the code in Browsertime, it can become pretty complex with all the configuration: https://github.com/sitespeedio/browsertime/blob/main/lib/support/xvfb.js

So what will you win by running Chrome not headless for Lighthouse (just so I understand)?

My understanding is that some metrics from Lighthouse are less reliable in headless mode: https://github.com/sitespeedio/plugin-lighthouse/blob/main/README.md#lighthousepuppeteer
I'm also getting odd results from Lighthouse in headless and wanted to see if this was the cause.

Aha, I've not wrote that and I think it's wrong,  let me remove it :) The thing is when you run Lighthouse by default timing metrics is washed through the  lantern.


Call to undefined function Blinq\Synth\pcntl_signal()

What happened?
HI
i just installed this package on my test project and when i run
php artisan synth
i get this error

How to reproduce the bug
i just executed
php artisan synth
Package Version
2.0
PHP Version
8.2
Laravel Version
10.10
Which operating systems does with happen with?
Windows
Notes
i just install the package put my key and env and executed php artisan synth and got that error

I think you are missing the php pcntl extension, which is not available for windows i think.


Mental Prowess does not qualify for Feat prerequisites

Expected behavior: Mental Prowess functions as the Headband of Intellect it replaces and qualifies animal companions for more feats
Actual behavior: animal companions still cannot take feats that require 3 int unless an ASI is applied

This is an unfortunate consequence of the way the game is coded. While this is technically fixable it's a difficult fix that's at high risk of introducing bugs.
I'd suggest using a mod such as ToyBox to bypass requirements if you want this.


Data error in benchmark/kernal

🐛 Bug
MUTAG - EdgePool
Val Loss: 0.5314, Test Accuracy: 0.702 ± 0.110, Duration: 1.561
Val Loss: 0.5185, Test Accuracy: 0.744 ± 0.111, Duration: 1.615
Val Loss: 0.5009, Test Accuracy: 0.750 ± 0.074, Duration: 1.777
Val Loss: 0.4920, Test Accuracy: 0.713 ± 0.069, Duration: 2.219
Val Loss: 0.5232, Test Accuracy: 0.718 ± 0.081, Duration: 2.077
Val Loss: 0.4872, Test Accuracy: 0.729 ± 0.084, Duration: 2.380
Val Loss: 0.4902, Test Accuracy: 0.729 ± 0.091, Duration: 3.162
Val Loss: 0.4817, Test Accuracy: 0.735 ± 0.064, Duration: 5.940
Traceback (most recent call last):
File "main.py", line 66, in
loss, acc, std = cross_validation_with_val_set(
File "/Users/vjleung/Desktop/exagraph/pytorch_geometric-master/benchmark/kernel/train_eval.py", line 43, in cross_validation_with_val_set
train_loss = train(model, optimizer, train_loader)
File "/Users/vjleung/Desktop/exagraph/pytorch_geometric-master/benchmark/kernel/train_eval.py", line 114, in train
out = model(data)
File "/opt/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/Users/vjleung/Desktop/exagraph/pytorch_geometric-master/benchmark/kernel/edge_pool.py", line 42, in forward
x, edge_index, _, batch, _, _ = pool(x, edge_index,
ValueError: not enough values to unpack (expected 6, got 4)
To Reproduce
Steps to reproduce the behavior:

in benchmark/kernal
run python main.py

MUTAG - EdgePool
Val Loss: 0.5314, Test Accuracy: 0.702 ± 0.110, Duration: 1.561
Val Loss: 0.5185, Test Accuracy: 0.744 ± 0.111, Duration: 1.615
Val Loss: 0.5009, Test Accuracy: 0.750 ± 0.074, Duration: 1.777
Val Loss: 0.4920, Test Accuracy: 0.713 ± 0.069, Duration: 2.219
Val Loss: 0.5232, Test Accuracy: 0.718 ± 0.081, Duration: 2.077
Val Loss: 0.4872, Test Accuracy: 0.729 ± 0.084, Duration: 2.380
Val Loss: 0.4902, Test Accuracy: 0.729 ± 0.091, Duration: 3.162
Val Loss: 0.4817, Test Accuracy: 0.735 ± 0.064, Duration: 5.940
Traceback (most recent call last):
File "main.py", line 66, in
loss, acc, std = cross_validation_with_val_set(
File "/Users/vjleung/Desktop/exagraph/pytorch_geometric-master/benchmark/kernel/train_eval.py", line 43, in cross_validation_with_val_set
train_loss = train(model, optimizer, train_loader)
File "/Users/vjleung/Desktop/exagraph/pytorch_geometric-master/benchmark/kernel/train_eval.py", line 114, in train
out = model(data)
File "/opt/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/Users/vjleung/Desktop/exagraph/pytorch_geometric-master/benchmark/kernel/edge_pool.py", line 42, in forward
x, edge_index, _, batch, _, _ = pool(x, edge_index,
ValueError: not enough values to unpack (expected 6, got 4)
Expected behavior
No error
Environment

OS: macOS High Sierra
Python version: 3.8.5
PyTorch version: latest
CUDA/cuDNN version:
GCC version: Apple version 10.0.0
Any other relevant information:

Additional context

Indded. Should be fixed in master.


Font size for the side panel cannot be changed

[Feature request]

VSCode Version: 1.4.0
OS Version: Windows 10

Steps to Reproduce:

Adjust font size of the code editor
See that in the lateral panel (files, search, ...) the code size is not the one specified above

It would be great to at least have consistency with the font size. Right now, while I am searching some variables along all my files, I have almost half of the display busy with the search results because font size is too big and I cannot make it smaller (or at least I haven't found a way to change it).
The code editor panel though is fantastic with the adjusted font size.

https://github.com/Microsoft/vscode/issues/519


Invalid admin_level breaks nested place processing

Details
PgOSM-Flex version:  0.0.6-dev
Processing place.sql fails trying to load data for nested polygon processing.  Has invalid text content, OSM Wiki indicates this should not be used.
Error:
ERROR:  invalid input syntax for type integer: "Community"

Example of way causing issue:  https://www.openstreetmap.org/way/440611849
Path forward
Currently getting value from simple grab_tag.
local admin_level = object:grab_tag('admin_level')

Should create function in helpers.lua to grab and ensure integer.  Consider setting value to -1 to make easy error report?

Resolved via #59

Resolved via #59


add KEYWORDS to schema, readme, and osmosis

closes #461

I could see this being useful IF it catches on.
I like the maxContains limit.

I think the keywords will be more useful for assets than chains, but I think this looks gtm

Makes sense for assets.
Chain keywords seems pretty weird to me, would prefer to not have it, and be able to just include a couple sentence description or something.

Makes sense for assets.
Chain keywords seems pretty weird to me, would prefer to not have it, and be able to just include a couple sentence description or something.

I agree that a description field makes sense.
I thought the assets could inherit the chain's keywords. I see it avoiding duplication. I don't see why it's necessarily a bad thing to include.

Let's also decrease the keywords for the assets too.  Made suggestions


fix: testsuite using __keyserver_name properly

Enhancement:
Reason:
Result:
Issue Tracker Tickets (Jira or BZ if any):

@richm may I ask you please for a review of this pull requests? It touches only the testsuite, fixing usage of  __keyserver_name.

@richm may I ask you please for a review of this pull requests? It touches only the testsuite, fixing usage of __keyserver_name.

The PR also adds the keyserver role to a lot of tests - what is the reason for that?

The reason is use of __keyserver_name variable in restore_services_state.yml.
__keyserver_name is defined in the keyserver role.


Test build/system directory to repo extraction

Summary of changes:

Before, the build code worked with a single manageiq repository containing the build and system directories.
Now, it works with 3 separate repositories (manageiq, manageiq-appliance (former system), and manageiq-appliance-build (former build)
CLI now accepts 3 repos via -A(--appliance_url), -B(--build_url), and -M(--manageiq_url) or defaults to the ones in the manageiq organization.  The repo is not read from the targets.yml anymore.  The --repo option in the CLI was removed as it's now unclear with 3 repos.
Note:  all 3 repos must have the --reference so you need to create branches and tags on each repo to do a build.
Destination appliance will have manage-appliance checked out in /var/www/manageiq-appliance with a symlink from /var/www/miq/system -> /var/www/manageiq-appliance (for backward compatility)

Example test build command line:
ruby /build/scripts/vmbuild.rb -A https://github.com/jrafanie/manageiq-appliance.git -B https://github.com/jrafanie/manageiq-appliance-build.git -M https://github.com/jrafanie/manageiq.git --reference test_build_system_repo_extraction

@abellotti @chessbyte Please review.
Note, the appliances build and I get the error during rake assets:precompile because of this: https://github.com/ManageIQ/manageiq/issues/3285, @kbrock is trying to solve that one.
Workers do start properly after reboot though.
Once this is merged, we can then review/merge: https://github.com/ManageIQ/manageiq/issues/3295

Can one pass appliance_url as a path?  I think it will work if you are git cloning it...it allows test builds from local code, which would be cool.

@Fryguy it would be possible with build_url since the build vm checks out that code for the kickstart/targets.yml but not for manageiq_url and appliance_url since those are cloned within the nested vm.

Ah ok, that's interesting and makes sense

@Fryguy Note, the :confused: part:  build_url is weird because it affects the kickstart/targets.yml but not vmbuild.rb itself (since it's the one doing the cloning)

This is really great stuff, @jrafanie !

@abellotti Note, I really don't like having to put the whole URL on CLI, makes we wonder if we should eventually allow for slugs like
ruby /build/scripts/vmbuild.rb -A "jrafanie/manageiq-appliance" -B "jrafanie/manageiq-appliance-build" -M "jrafanie/manageiq" --reference test_build_system_repo_extraction

Don't merge yet, I will fixup the bin shell scripts to call vmbuild.rb using the new CLI options.

@jrafanie  that would simplify things, it was different when there was only one url on the cli.  Note, optionally just the fork name since the repo names would be the same, i.e. just -A "jrafanie" -B "jrafanie" -M "jrafanie".

Yeah @abellotti agreed, fork name would be better too.  I'm sure we'll find good ideas by trying to fix the callers of vmbuild.rb to use the new -A, -B, -M options, such as: bin/centos71-devbuild.sh
@Fryguy fixed the param list to be a consistent order.


Add "Hello world" in Kartvelian language

Team: [TEAM NAME]
{
"title": [JOB TITLE],
"isLead": [true OR false],
"payPerDay": 2800,
"createdDate": "2020-07-08T02:14:59.307535Z",
"contributor": {
"contributorId": [CONTRIBUTOR ID],
"displayName": [DISPLAY NAME],
"githubUsername": [GITHUB USERNAME],
"profileImage": [PROFILE IMAGE URL (Slack or GitHub URL)],
"slackUsername": [SLACK USERNAME]
}
}

@Mikheil-A #351 exists for adding 'Hello World' in your own language. No need for a separate issue.

@Mikheil-A #351 exists for adding 'Hello World' in your own language. No need for a separate issue.


Doesn't work in new sveltekit

Followed instructions for svelte kit install. Which are also out of date because kit.vite is no longer a config option.

Same problem. Any luck?

what works is this:
  let Carousel: ConstructorOfATypedSvelteComponent; // for saving Carousel component class
  onMount(async () => {
    const module = await import('svelte-carousel');
    Carousel = module.default;
  });

and then later
  {#if browser}
  <svelte:component
    this={Carousel}
    autoplay
    autoplayDuration={4000}
    duration={500}
    dots={true}
    arrows={false}
  >
    ...
  </svelte:component>

The error for the missing type: module
svelte-carousel doesn't appear to be written in CJS, but also doesn't appear to be a valid ES module (i.e. it doesn't have "type": "module" or an .mjs extension for the entry point). Please contact the package author to fix.

I can work on this issue

what works is this:
  let Carousel: ConstructorOfATypedSvelteComponent; // for saving Carousel component class
  onMount(async () => {
    const module = await import('svelte-carousel');
    Carousel = module.default;
  });

and then later
  {#if browser}
  <svelte:component
    this={Carousel}
    autoplay
    autoplayDuration={4000}
    duration={500}
    dots={true}
    arrows={false}
  >
    ...
  </svelte:component>
  {/if}

but obviously it would be great if the component were working without tricks

it's works thank you

Should be fixed in https://github.com/vadimkorr/svelte-carousel/pull/126


Hide tab-bar-mode in writeroom-mode?

Thanks for this great package! Is it also possible to hide tab-bar-mode in writeroom-mode?

Yes, you can add the function tab-bar-mode to writeroom-global-effects, as described here (or simply use add-to-list in your init file).

Great! That works as expected! Thank you.


[MM-60308] Add a set of "Developer Mode" settings that allow the user to turn off systems or force the app to behave a certain way

Summary
This PR creates a Developer Mode, hidden behind an environment variable that when set, will unlock certain options allowing users to fiddle with the behaviour of the Desktop App. This mode is designed to aid developers in debugging performance issues with the Desktop App, where we believe certain systems with the Desktop App may be the culprit.
The settings added here are:

Browser Mode Only: Completely disables the preload script, stops web app from knowing it's in the Desktop App

Should be the best indicator of if something we're doing with the web app is causing it to slow down or retain memory
NOTE: Disables notifications, cross-tab navigation, unread/mentions badges, calls widget, breaks resizing on macOS

Disable Notification Storage: Turns off the maps that hold references to the notifications until they've been clicked

Good for debugging if we're just holding onto too many references to unused notifications

Disable User Activity Monitor: Turns off the interval that checks if the user is AFK or not

Good for debugging if that is affecting the user status negatively, or causing other strange behavior

Disable Context Menu: Turns off the context menu attached to the BrowserViews

Just a sanity check around if that library is causing anything odd

Force Legacy API: Forces the app to revert back to the old messaging API instead of the newer contextBridge API

Another sanity check to see if the new API is responsible for holding onto memory

Force New API: Forces the app to use the contextBridge API and completely disables the legacy one

Currently the application runs some listeners for the legacy API side-by-side, so this forces them off entirely.

This mode should not be turned on by anyone who isn't a developer, or was instructed by a Mattermost developer to turn this on. When the feature is on, an indicator will show up on the top bar showing that you are in Developer Mode:

Ticket Link
https://mattermost.atlassian.net/browse/MM-60308
Add `Developer Mode` settings to help debug performance issues

@abhijit-singh

Not sure how to test this, which env variable do I change and how?

The variable is MM_DESKTOP_DEVELOPER_MODE and it should be set to true. On Mac, you can run export MM_DESKTOP_DEVELOPER_MODE=true and then run the build from the command line.

But I'm also not sure if this needs any UX testing. We should just make sure it works as expected on Windows too if we haven't already checked that. Other than that, feel free to remove me as a reviewer and go ahead with this.

The reason I asked for UX was to confirm that the indicator (screenshotted above) looked alright, and that the descriptions of the menu items made sense. If that's all okay, you can approve (or remove yourself) and we'll go from there


use cached null count in filters

We can use the cached null counts to determine fast paths in filter operations.
Additional note:
I used the following hack to clone &dyn Array. I don't like it TBH. If you are ok with it I will add a boxed(&self) -> Box<dyn Array> to the Array trait.
    if false_count == 0 {
        assert_eq!(array.len(), filter.len());
        // a hack to clone
        return Ok(array.with_validity(array.validity().cloned()));
    }

Thanks!
There is a function arrow2::array::clone, but I like the idea of adding it to the trait, like you suggested


Investigate what role Tasks can play on Snowflake

Exploration
Feature description
Snowflake has recently released support for Tasks and Streams
Let's use this issue to understand how dbt can leverage tasks and streams to better transform data in the warehouse.
Some questions:

Are tasks a viable mechanism for implementing table / incremental models on Snowflake?
Are tasks sensible in dbt's environment-aware world? Should every dbt user get their own copies of tasks?
How do streams fit in here? I recall reading that tasks could be triggered by streams - is that actually the case? And is it desirable?
What would the MVP of support for tasks/streams look like in dbt? How do we define if it's "better" than the status quo?

@drewbanin  - do you have someone working working on this already? if not i would like to volunteer my time to look into this.

Hey @darthburrito - I haven't spent too much time looking at this! I'd be very grateful if you could give this some thought and report back here!

@drewbanin - sounds good!

Any progress on this? I'm planning to implement incremental models using Snowflake streams. I don't envision much use for tasks thou considering how DBT works.

@jannekeskitalopaf I'd love to hear more about how you're planning on using streams! No developments on our end here, but certainly would love to kick-start the conversation.

Basically, I'm planning to use a pre-hook to create a stream object for a source table, like "stream__<source_name>". Then I'll use my own implementation of the ref() -function to replace the source table with the stream -object if "is_incremental() == True". That's the general plan.
Of course I already hit a problem with this. We expose raw variant data only as views and streams can't be created on top of views. So, this incremental method might become usefull only in special cases where the value gained overweighs the drawbacks of exposing raw variant data to dbt models.

tasks probably aren't a great compilation target for dbt, but streams remain a compelling idea around incremental models. Closing this issue as no action is required at present


Starting Elasticsearch in Gitlab-CI fails

Describe the bug
I try to use testcontainers for Elasticsearch in Gitlab-CI, but it fails when trying to connect to Elasticsearch.
To Reproduce
test:
  image: python:3.11
  variables:
    DOCKER_HOST: "tcp://docker:2375"
    DOCKER_TLS_CERTDIR: ""
    DOCKER_DRIVER: overlay2
  services:
    - name: docker:dind
      command: ["--tls=false"]

  before_script:
    - python -V
    - pip install testcontainers
  script:
    - python test/test.py

from testcontainers.elasticsearch import ElasticSearchContainer
import logging

logging.basicConfig(level=logging.DEBUG)

with ElasticSearchContainer(f"elasticsearch:8.11.1") as es:
    print(es.get_url())

gitlab-ci logs
$ python test/test.py
DEBUG:docker.utils.config:Trying paths: ['/root/.docker/config.json', '/root/.dockercfg']
DEBUG:docker.utils.config:No config file found
DEBUG:docker.utils.config:Trying paths: ['/root/.docker/config.json', '/root/.dockercfg']
DEBUG:docker.utils.config:No config file found
DEBUG:urllib3.connectionpool:Starting new HTTP connection (1): docker:2375
DEBUG:urllib3.connectionpool:http://docker:2375/ "GET /version HTTP/1.1" 200 806
Pulling image elasticsearch:8.11.1
INFO:testcontainers.core.container:Pulling image elasticsearch:8.11.1
DEBUG:urllib3.connectionpool:http://docker:2375/ "POST /v1.43/containers/create HTTP/1.1" 404 50
DEBUG:docker.auth:Looking for auth config
DEBUG:docker.auth:No auth config in memory - loading from filesystem
DEBUG:docker.utils.config:Trying paths: ['/root/.docker/config.json', '/root/.dockercfg']
DEBUG:docker.utils.config:No config file found
DEBUG:docker.auth:Looking for auth entry for 'docker.io'
DEBUG:docker.auth:No entry found
DEBUG:docker.auth:No auth config found
DEBUG:urllib3.connectionpool:http://docker:2375/ "POST /v1.43/images/create?tag=8.11.1&fromImage=elasticsearch HTTP/1.1" 200 None
DEBUG:urllib3.connectionpool:http://docker:2375/ "GET /v1.43/images/elasticsearch:8.11.1/json HTTP/1.1" 200 None
DEBUG:urllib3.connectionpool:http://docker:2375/ "POST /v1.43/containers/create HTTP/1.1" 201 88
DEBUG:urllib3.connectionpool:http://docker:2375/ "GET /v1.43/containers/ce60f2427a2f39168b711d5383c3f4fb96bf597751256021c8e7bc8c0a7d9103/json HTTP/1.1" 200 None
DEBUG:urllib3.connectionpool:http://docker:2375/ "POST /v1.43/containers/ce60f2427a2f39168b711d5383c3f4fb96bf597751256021c8e7bc8c0a7d9103/start HTTP/1.1" 204 0
Container started: ce60f2427a2f
INFO:testcontainers.core.container:Container started: ce60f2427a2f
Waiting to be ready...
INFO:testcontainers.core.waiting_utils:Waiting to be ready...
Waiting to be ready...
INFO:testcontainers.core.waiting_utils:Waiting to be ready...
DEBUG:urllib3.connectionpool:http://docker:2375/ "GET /v1.43/containers/ce60f2427a2f39168b711d5383c3f4fb96bf597751256021c8e7bc8c0a7d9103/json HTTP/1.1" 200 None
DEBUG:urllib3.connectionpool:http://docker:2375/ "GET /v1.43/containers/json?limit=-1&all=0&size=0&trunc_cmd=0&filters=%7B%22id%22%3A+%5B%22ce60f2427a2f39168b711d5383c3f4fb96bf597751256021c8e7bc8c0a7d9103%22%5D%7D HTTP/1.1" 200 None
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/urllib/request.py", line 1348, in do_open
    h.request(req.get_method(), req.selector, req.data, headers,
  File "/usr/local/lib/python3.11/http/client.py", line 1294, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/local/lib/python3.11/http/client.py", line 1340, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/local/lib/python3.11/http/client.py", line 1289, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/local/lib/python3.11/http/client.py", line 1048, in _send_output
    self.send(msg)
  File "/usr/local/lib/python3.11/http/client.py", line 986, in send
    self.connect()
  File "/usr/local/lib/python3.11/http/client.py", line 952, in connect
    self.sock = self._create_connection(
                ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/socket.py", line 851, in create_connection
    raise exceptions[0]
  File "/usr/local/lib/python3.11/socket.py", line 836, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/builds/arian/project/test/test.py", line 6, in <module>
    with ElasticSearchContainer(f"elasticsearch:8.11.1") as es:
  File "/usr/local/lib/python3.11/site-packages/testcontainers/core/container.py", line 71, in __enter__
    return self.start()
           ^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/testcontainers/elasticsearch.py", line 101, in start
    self._connect()
  File "/usr/local/lib/python3.11/site-packages/testcontainers/core/waiting_utils.py", line 49, in wrapper
    return wrapped(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/testcontainers/elasticsearch.py", line 90, in _connect
    res = urllib.request.urlopen(self.get_url())
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/urllib/request.py", line 216, in urlopen
    return opener.open(url, data, timeout)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/urllib/request.py", line 519, in open
    response = self._open(req, data)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/urllib/request.py", line 536, in _open
    result = self._call_chain(self.handle_open, protocol, protocol +
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/urllib/request.py", line 496, in _call_chain
    result = func(*args)
             ^^^^^^^^^^^
  File "/usr/local/lib/python3.11/urllib/request.py", line 1377, in http_open
    return self.do_open(http.client.HTTPConnection, req)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/urllib/request.py", line 1351, in do_open
    raise URLError(err)
urllib.error.URLError: <urlopen error [Errno 111] Connection refused>
DEBUG:urllib3.connectionpool:Starting new HTTP connection (2): docker:2375
DEBUG:urllib3.connectionpool:http://docker:2375/ "DELETE /v1.43/containers/ce60f2427a2f39168b711d5383c3f4fb96bf597751256021c8e7bc8c0a7d9103?v=True&link=False&force=True HTTP/1.1" 204 0

Solution?
It seems to be that the _connect method throws an ConnectionRefusedError or URLError which isn't handled, which it probably should.
    @wait_container_is_ready()
    def _connect(self):
        res = urllib.request.urlopen(self.get_url())
        if res.status != 200:
            raise Exception()

A version that seems to work:
from testcontainers.elasticsearch import ElasticSearchContainer
from urllib.error import URLError
import logging
from testcontainers.core.waiting_utils import wait_container_is_ready

logging.basicConfig(level=logging.DEBUG)

class FixedElasticSearchContainer(ElasticSearchContainer):

    @wait_container_is_ready(URLError)
    def _connect(self):
        return super()._connect()

with FixedElasticSearchContainer(f"elasticsearch:8.11.1") as es:
    print(es.get_url())

hey @arian thanks for the triage for us!
Sorry for the delays, but I'm focusing on #405 for the time being and did not establish the habit of triaging so folks are getting some delayed responses.
From what you've said, it seems that you could just contribute the fix if you want. The fix seems simple enough!
Contributions welcome!

@arian since it's already fixed on main but unreleased, I'm closing this issue and would like to redirect everyone to #418 for their comments on when we can release the fixes properly!
Sorry for the delays, but still just squeezing this in our free time and operating with some restrictions (can't just change everything on the repo all at once)
For further questions, please ask on #418, thanks! :slightly_smiling_face:


Heroku deploy sample app has issue

My attempted Heroku deploy of the sample app failed with the following issue
Configure environment
   There was an issue setting up your app environment.
   could not find the source blob

I will try to pull down and run locally, just figured I would give you a heads up.  I am excited to try Storytime!

Hmm, it seemed to work when I deployed using the deploy to Heroku button in the README. May try again? It was probably an issue with pulling down one of the gems from RubyGems.

@eanlain Sorry for delayed response, I tried again and everything worked as expected.

No worries, glad to hear that it worked.


TypeScript 4.0 support

Describe the bug
I'm trying to use the new ??= syntax in TypeScript 4.0
This yields Line 53:3:  Expected an assignment or function call and instead saw an expression  @typescript-eslint/no-unused-expressions as error message.
When I'm silenting this ESLint warning I'm getting Module parse failed: Unexpected token (19:21) from Babel.
I've already tried upgrading all dependencies via yarn upgrade.
Looks like some manual work on create-react-app needs to be done to properly support these new language features.

The general upgrade seems to be tracked by #9515 already.
Will add my findings there.


GoToStep & onAction API call  response error

Hi,
I was trying to use this in my project but I am stuck on 2 things.

I am not able to go to a particular step. it always starts from the beginning. Please do let me know if any solution for that.

onAction call if any error in API response how to handle that.

FormikWizard exposes a prop called albusProps which you can use to pass props directly to the underling <Wizard /> component. Also, in the FormikWizardContext (useFormikWizard())  you also get access to the wizard object, which is the react-albus context itself.

I didn't quite get it.

@aneraghu If there are any errors in the API response, just catch and and then throw it again. If you don't throw the error the wizard goes to the next step, which in most cases is not what you want.


[feature] Chromedriver with --headless=new

Version and OS
All
Is your feature request related to a problem? Please describe.
related: #529
Using the new headless mode should improve resource usage and work exactly like the headfull mode.
Describe the solution you'd like
Use --headless=new command when launching chromedriver
Describe the use-case and give concrete real-world examples
The old Headless was a separate, alternate browser implementation that happened to be shipped as part of the same Chrome binary. It doesn’t share any of the Chrome browser code.
The new headless mode unifies Headless and headful modes. See article for details.
Additional context
https://developer.chrome.com/articles/new-headless/

Hi @leiless, I think you can try to use it by setting the parameter in the docker-compose https://github.com/dgtlmoon/changedetection.io/blob/master/docker-compose.yml#L29
- PLAYWRIGHT_DRIVER_URL=ws://playwright-chrome:3000/?--disable-web-security=true&--headless=new

The problem is that this mode has not been tested yet, so I am not sure everything will work as supposed in changedetection.


add ca cert to token controller and all service accounts

Fixes #7648
cat /var/run/secrets/kubernetes.io/serviceaccount/ca.crt
-----BEGIN CERTIFICATE-----
MIIDXzCCAkegAwIBAgIJALCZOXppvtO1MA0GCSqGSIb3DQEBCwUAMCQxIjAgBgNV
BAMUGTEzMC4yMTEuMTU1LjQzQDE0MzUwOTk3MjkwHhcNMTUwNjIzMjI0ODQ5WhcN
MjUwNjIwMjI0ODQ5WjAkMSIwIAYDVQQDFBkxMzAuMjExLjE1NS40M0AxNDM1MDk5
NzI5MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA5vwZGwINV2+qQtUJ
anaxlJ4qjQeKyThsdV/tT1VE9SroT7JiLMhIU2Wr1ETw76rPr8ao8yRkJordwqKo
ThVVc6XvLa1Y7SptL2Zw1ufvxuac3xfG96XMcIjm/x5BtNe3M5VUlyjMSkMYUrmy
hvM0/8sgzmQ6QBgL0+FSZkrGIdbAqG+EOcrn0rn/xngBhSlF1TSQmg6rG/qc9Kjw
eJBrJJ0TTowDl44a0i8n21qu4Vb0iAkGLi6OZI7mC4PzR2DR+0ciLQy/OTl8mC6s
Q4KwZwDd6ovQQxHB6n+VFJjT5zeOfbKbW83oJi+NAlJnk2O6nGz+ZLmvHHbRfxyf
htSltQIDAQABo4GTMIGQMB0GA1UdDgQWBBQ3ov6S1JYJ2ZlaZ5lAO9aAozwPxTBU
BgNVHSMETTBLgBQ3ov6S1JYJ2ZlaZ5lAO9aAozwPxaEopCYwJDEiMCAGA1UEAxQZ
MTMwLjIxMS4xNTUuNDNAMTQzNTA5OTcyOYIJALCZOXppvtO1MAwGA1UdEwQFMAMB
Af8wCwYDVR0PBAQDAgEGMA0GCSqGSIb3DQEBCwUAA4IBAQAMlSSZ2k+h+Y4RXPI2
mILYEuNf/L3Rnui8iZM4bQeDb8hszxe5KMVHCOF7z1R/iOrbk3KjTUZfcmlpcMNc
VSehj6h0m5vkdq9H4kM8iUPP3GS5W8l8wsd+FNCGNhlMR2i3bxrevRnaB4RbR0Hx
osGVL/+kiMCdO12Uak0Wm47qnGJsr48XFzbLQ2s1NckdWDTMO6ZteGa0oTW5NJ/Z
wpQ01HyT1WKm6r+7HtQC6VyecxGqhIYom1eBMNmPY8kg9aONUQBYRN3HJ8uQEE8D
bjmOH2F1Z2qD2ZAxrAOo2JJQqbFl1Xjp/3QbeN5W8Tj98PTo/R/aYtMZcmyAz4yY
DL/P
-----END CERTIFICATE-----

cc @lavalamp @erictune @thockin @roberthbailey

I will include this ca.crt as part of client.InClusterConfig() but I wasn't sure if i should put it in a follow up PR as that part is not strictly v1.0

@liggitt @derekwaynecarr

I will include this ca.crt as part of client.InClusterConfig() but I wasn't sure if i should put it in a follow up PR as that part is not strictly v1.0

I think that part (and rebuilding the containers that use it) actually is 1.0, on account of security concerns.

@lavalamp appended a commit adding it to InClusterConfig

just the one question about using CAData/CAFile from the controller manager's kubeconfig if no root CA file is provided. LGTM otherwise

@k8s-bot ok to test

I've added fallback to kubeconfig.CAData. Going to test it out.

Thanks for doing this.  I can't provide meaningful review at this time :)

@mikedanese assigning to you to find two TL reviewers. Thank you!

@lavalamp can you review this?

LGTM

Everything addressed. Assigning to @thockin for final review.

LGTM, OK to merge


blazor debug VsRegEdit command parameter confusion..

The documentation makes reference to "TIMEOUT" being a variable to replace, but..  There's a second parameter (VSInstallFolder ) that isn't mentioned and it's formatted differently.
VsRegEdit.exe set "" HKCU JSDebugger\Options\Debugging "BlazorTimeoutInMilliseconds" dword {TIMEOUT}
 should be replaced with the visual studio directory.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec2f61c7-9f51-6735-e328-3c7b495d70c3
Version Independent ID: 4d06e565-282d-6387-aa90-cb2c2986d35a
Content: Debug ASP.NET Core Blazor WebAssembly
Content Source: aspnetcore/blazor/debug.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @tony-asu ... Could you re-open this over for the product unit. Please add a cc: @guardrex to your opening comment so that I can follow the discussion ...
https://github.com/dotnet/aspnetcore/issues


PWA-660

Fixing the broken top border-radius on the product card (there was none) + disappearing badges on scroll

removed glow container, moved it to a pseudo element (to prevent border-radius)
removed weird top: 50%, left:50% and then translate3d(-50%...), changed to top: 0, left: 0 (CCP-410 non regression)

Other fixes

remove obsolete state property definition in ProductImage component
fix for 2px white artifact below the product card box shadow visible on the productSlider widget

Pull Request Test Coverage Report for Build 1078

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.006%) to 42.002%

Files with Coverage Reduction
New Missed Lines
%

components/ProductCard/style.js
1
0.0%

Totals

Change from base Build 1077:
-0.006%

Covered Lines:
1614

Relevant Lines:
3896

💛  - Coveralls


Use base_bath configuration

Right now, base_bath configuration was never used when registering routes.

Thanks @palpalani! 😄
Tagged at v1.7.1
https://github.com/ukfast/laravel-health-check/releases/tag/v1.7.1


fix #76561

Avoid having the same status bar contribution priority.

The change looks good you are no longer clashing with the priority of 50 defined here
https://github.com/Microsoft/vscode/blob/7c88e07cc69633729be10d25e8408707fce48bf4/src/vs/workbench/contrib/markers/browser/markers.contribution.ts#L280
@bpasero However what are the repro steps for this? I just want to verify all is good.

@isidorn :

install extensions from https://github.com/microsoft/vscode/issues/76561#issuecomment-508416570
multi root workspace
open a file
run build task
click on scm providers

Eventually I got the broken state because each click on a repo redraws the SCM one.

I can reproduce without your fix.
I can not reproduce with your fix. So all looks good -> approved.


Permission error when provisioning a PVC

OpenShift 4.10 SNO
CoreOS 410.84.202211140926-0 (Ootpa)
When I attempt to create a PVC with the local-path-provisioner I receive the following error:
mkdir: can't create directory '/opt/local-path-provisioner/pvc-1b8861df-d48a-4701-b8fe-2f7cf878e3fa_test': Permission denied
I have verified that the /opt/local-path-provisioner exists and the path is read-write for all users.
Any suggestions or any requests for more information I can provide is appreciated.

Is there any other information I can provide to help troubleshoot this issue?

Hi Jason:
I could successfully bypass the problem with creating the PVC by using a privileged SecurityContext on the helper-pod:
      containers:
      - name: helper-pod
        image: busybox
        imagePullPolicy: IfNotPresent
        securityContext:
          privileged: true

However, later when the actual Pods that need access to the PVC are scheduled and executed, they are not able to create files and folders inside the Node Filesystem so that was not a solution. Making the "user" Pods privileged (or grant them some of the apparently required SCCs) may not a feasible option either.
This issue may be related to https://github.com/rancher/local-path-provisioner/issues/283.
For now, I'm using a local NFS (privileged) server (image: k8s.gcr.io/volume-nfs:0.8) on the SNO install that effectively decouples FileSystem Security from clients and that combined with the standard NFS provisioner (for Dynamic Provisioning) is working well in an SNO scenario. Although this solution looked simpler and more "promising".
Thanks
Julio.

OpenShift 4.10 SNO CoreOS 410.84.202211140926-0 (Ootpa)
When I attempt to create a PVC with the local-path-provisioner I receive the following error:
mkdir: can't create directory '/opt/local-path-provisioner/pvc-1b8861df-d48a-4701-b8fe-2f7cf878e3fa_test': Permission denied
I have verified that the /opt/local-path-provisioner exists and the path is read-write for all users.
Any suggestions or any requests for more information I can provide is appreciated.

@jvenhuizen
Sorry, not familiar with OpenShift. Can you provide the information

What's the corresponding kubernete version?
What's the local-path-provision version?

I'm thinking if it is related to SELinux setting. Any clues in demsg or syslog?

@jvenhuizen
Fixed in https://github.com/rancher/local-path-provisioner/pull/295. Will release 0.0.24 soon.
Many thanks.


Fix gizmo on top material option having no effect

This fixes https://github.com/godotengine/godot/issues/44077
I found that the get_material function in EditorNode3DGizmoPlugin is changing the gizmo materials directly to add and remove the disable depth test flag to enable/disable them for the 'x-ray' visibility state before returning them. This is causing the original state of the disable depth test flag to be lost so materials that were created with the on_top parameter are never returned with the disable depth test flag enabled when in the regular 'visible' visibility state.
To fix this I have updated get_material to change the disable depth test flag on duplicate versions of the gizmo
materials when the gizmo is set to use the 'x-ray' / ON_TOP visibility state if the flag is not already set or otherwise return the stored materials without change.
(Since StandardMaterial3D is RefCounted these duplicates should be freed automatically when later unreferenced when the gizmo is redrawn.)

Thanks! And congrats for your first merged Godot contribution :tada:

Trying this in my plugin: create_material("small_cursor_shape", Color.RED, false, true)
Not sure what it's meant to do, but my expectation is to see the red (sphere) through the geometry in the way. However it's hidden.
Zylann's workaround still better:
func create_on_top_material(name: String, color := Color.WHITE,
		bmode := StandardMaterial3D.BLEND_MODE_ADD):
	var material := StandardMaterial3D.new()
	material.set_blend_mode(bmode)
	material.set_shading_mode(StandardMaterial3D.SHADING_MODE_PER_VERTEX)
	material.set_flag(StandardMaterial3D.FLAG_DISABLE_DEPTH_TEST, true)
	material.set_albedo(color)
	material.render_priority = 100
	add_material(name, material)

Godot v4.4.dev (61598c5c8) - Ubuntu 22.04.4 LTS 22.04 - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (nvidia; 535.183.01) - Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz (6 Threads)

@donn-xx in your create_material example does it work when the node using the gizmo is selected? Gizmos have different material instances created for selected and unselected states. The on top effect is only applied to the selected material instance: https://github.com/godotengine/godot/blob/61598c5c88d95b96811d386cb20d714c35f4c6d7/editor/plugins/node_3d_editor_gizmos.cpp#L928

he selected material instanc
Selected and unselected. The billboard simply changes (in some way) how it appears.

How do we setup the selected and unselected materials?
Also, imo, I need the "icon material" (at least) to be visible always, so that it's visible in the scene (in the editor). It would be great to be able to select the node by clicking on the billboard/icon too. (Otherwise, why bother with it all? May as well select the node in the tree.)


fix(touch): enhance parseOptions and fix touch's -r flag

This improves parseOptions to allow options of the form:
touch({'-r', 'path/to/file'}, 'other-file.txt');

to supply a value to an option. In this example, -r has the string value 'path/to/file'.

One small nit, otherwise looks good!

@nfischer: In the changelog, how should this be described?

@ariporad I replaced the instances of match() with suitable alternatives

@nfischer: Fantastic!

In the changelog, you can just say something like "feat: now supports valued options (see touch -r for an example)."

Will Do!

LGTM!


install

Hi, please share signed copy of the plugin with us. Thanks

Hello Boris, unfortunately we are not allowed to distribute built plugins. You have to build it yourself by executing the steps described in the README file in the Assembly section.

Hi,
OK, thanks for the info. So we will test the unsigned version.


confused let client:Client

https://github.com/manyuanrong/deno_mysql/blob/921309c3a7c23dc0cd11ac43da03e79fc0dc9f74/test.ts#L9
class client instantiated

in main() ;
It's supposed to be an entrance.


[frameit] Added font_height_factor

Added font_height_factor that allows the title and keyword heights to be a set value so that the devices line up across shots of the same device. Should fix #6116.
Checklist

[X] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[X] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[X] I've read the Contribution Guidelines
[X] I've updated the documentation if necessary.

Description
Added font_height_factor which if defined in the config uses a factor of the calculated font size as the text height instead of calculating the text height which makes the text height equal across all shots of the same device.
Motivation and Context
If a title that has a lower case g/q/y/j or some other characters is used in one shot but not in another
even when using font_scale_factor to ensure the same font sizes it results in the example below where the devices don't line up like in issue #6116.

Is there any chance this feature could find its way into frameit? I am facing the exact same problem and I think that the lack of fixed height titles is really bad. If we look at the screenshots of the best apps for iOS they all have devices positioned at exactly the same spot regardless of the text in them.


Thread and Isolate in Flutter

Topic Suggestion
Pre-submission advice
By following all our pre-submission advice and reviewing our Resources folder, you will maximise your chances of your topic being approved.
We ask that you please be patient as our team works through approving and publishing all articles/tutorials in a timely manner.
Allow 1-3 days for a topic to be reviewed and/or approved - allow 3-7 days for an articles to be reviewed and/or published.
Be sure to visit our Resources Page for tools, resources, and example articles that will help you propose and write a successful article.
Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
We tend to stray away or tend not to publish reviews/comparisons of commercial product offerings.
Proposal Submission
Thread and Isolate with Flutter
Your title should be descriptive of the article/tutorial. Be Specific.
Use keyword research to improve your article's SEO.
Proposed article introduction
An isolate is a thread that has an event loop that continuously processes events in its own memory space. In effect when the main dart function executes, it executes in an isolate that scans for available events and hangs when none are available, an opportunity for the system to decide to run the garbage collector for example.
Dart can execute multiple threads by spawning additional isolates. Creating more isolates can be useful for heavy computation processing but most Flutter apps do not need spawning additional isolates unless it becomes an issue and impacts the frame rate.
For example, if the article is based on machine learning, use the following: [Machine learning] Introduction to Machine Learning.
If the article is based on developing an Android application, use the following: [Android] Developing Apps using Android.
ONLY viable topics to pick from:

API
Artificial Intelligence
Blockchain
Containers
Edge Computing
Languages
Machine Learning
Networking
Node.js
Security

Key takeaways

Understand how to use isolate with flutter
Understand event loops in asynchronous way
code the implementation of the thread and isolate

Article quality
How is your article unique? Tell us what makes your approach different from similar articles that have published on the same topic?
Is yours more in-depth? Does it cover additional topics? Do you provide handy tips or anecdotal advice?
References
-https://flutter.dev/docs/development/packages-and-plugins/background-processes

https://medium.com/flutter-community/thread-and-isolate-with-flutter-30b9631137f3

Conclusion
Finally, remove the Pre-Submission advice section and all our blockquoted notes as you fill in the form before you submit.
We look forwarding to reviewing your topic suggestion.
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Good afternoon and thank you for submitting your topic suggestion.
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

Awaiting response from @WanjaMIKE

Hello @ahmadmardeni1 .What is the current status of this issue? I am still waiting for @WanjaMIKE to respond..

Topic approved. Let's ensure that it adds value to the community. It should be different from those published on other sites including medium. Thanks


Update windows-autopatch-support-request.md

Adding section to define support for Unified or Premier contracts this work is already in place just not documented..

Why

Closes #[Issue Number]

Changes

Learn Build status updates of commit c96fb82:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows/deployment/windows-autopatch/operate/windows-autopatch-support-request.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 1f13a1a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows/deployment/windows-autopatch/operate/windows-autopatch-support-request.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

As per discussion, closing PR as I've included the changes into a different PR.


Normals aren't updated when using blendshapes

Godot version
4.0.1
System information
Windows 10, Vulkan (Forward+), GTX 1060
Issue description
Normals remain unchanged while using blendshapes on a mesh.
issue.webm
Steps to reproduce
Import a mesh with blendshapes. Change the blend shape weight and notice how the normals remain unchanged.
Minimal reproduction project
blendshape_normals_issue.zip

Related to https://github.com/godotengine/godot/issues/43215.

I ran the MRP locally and inspected the normals from the blend shape and they appear to be normals that correspond to a box rather than a sphere. In fact, they appear to be the exact same normals as those used by the base box mesh. I printed the first 100 normals of each and confirmed that they were identical.
Taking a look at the shape keys in blender confirms that this is an issue with the model:

@clayjohn Blender is not really the software you should use to look at blendshape data as the software does not have support for custom normals data for blendshapes.


ShortcodeInterface::getBbCode() not working correctly with hash

When trying to create a ColorHandler to replace
[color=#F00]This is red[/color]

by
This is red

$shortCode->getBbCode() returns only "#" and $shortCode->getBbCode() returns :
[
    "F00" => null
]

Hi @noemi-salaun, thanks for the report. I fixed this issue in #44, I just added another test case based on your data and will merge and release v0.6.5 shortly.
This was an intended behaviour as "simple value" parameters allowed only alphanumeric strings, so [color=F00] would work correctly. To make shortcode contain "complex value" parameter you needed to wrap it inside quotes: [color="#F00"]. Only recently I found a good way to do this correctly in Regex and Regular parsers (Wordpress is unaffected and intentionally can't handle this).

@noemi-salaun All builds are green, so I just released Shortcode v0.6.5 with merged #44. Could you please close this issue if it solves your problem? Please get back to me with more details if it didn't or you need more help.

Woaw that was fast :smile:
It works fine.


Allow language selection to prevent aliases adding noise instead of helping

Perhaps

detecting the language
or giving the user the option of selecting the input language
of the provided input text could be used as a filter to help non-noun entities being classified?

In the above, when I looked at lake Q23397, I noticed the matching was actually happening because of the Danish alias "sø".

Yes! That would be a nice thing to have.

I have been addressing this issue in #32.


ReferenceError: document is not defined

I'm getting a ReferenceError: document is not defined error when loading a route with Fastboot that lazy loads Stripe.
Any pointers would be welcomed!

@adambedford Do you protect loading stripe in FastBoot?  In a node environment, there is no document.
I'm guessing you want to wait until the browser takes over to get the stripe service (can't do anything with it in node anyways)
if (this.fastboot.isFastBoot) {
  return this.get('stripe').load();
}

https://github.com/ember-fastboot/ember-cli-fastboot#fastboot-service
Let me know if you have other questions!

🙌 You were absolutely right!


CMake: Changes to files compiled when INCLFLO_DIM=2

This PR adds a condition to check the value of INCFLO_DIM. If it is not 3, the following files are no longer compiled:
      eb_spherecube.cpp
      eb_tuscan.cpp
      eb_twocylinders.cpp

Maybe the PR should be based on the current development branch, not a branch that's work-in-progress.

I did a rebase to try to fix the issue. Is this the right way to fix it? Or should I close and do a new PR?

Looks good now.  But it seems that we could do it in a different style to reduce duplicated lines.  Include common files first and then conditionally include 3d only files.

:+1: Good suggestion, I will fix it. Thanks!

It just passed compile for 2D and 3D. I will test execution tomorrow, then mark ready if it passes.

Passed.