Explore cards bugfixes

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
https://adobe-acs-group.atlassian.net/browse/WRLDBAEMS-156
https://adobe-acs-group.atlassian.net/browse/WRLDBAEMS-150
Test URLs:

Before: https://main--world-bank--aemsites.hlx.live/
After: https://explore-cards-bugfixes--world-bank--aemsites.hlx.live/en/drafts/arjun/sample2

@arjun87743 I still see small white space on mobile. Can you revert the padding and also add calc(100vw - 28px) to the width and check if that works?


Question: Collection Helpers

Hi! I just transitioned to Astronomy and it is really awesome! Thank you for building and supporting it
I am having some trouble figuring out the transform function to replace dburles:collection-helpers. I want to be able to create a virtual field with a pretty timestamp (i.e. 'Sun, 28 Feb 2016 01:16:34' instead of<PHONE_NUMBER>). Currently, I create the field based on the user's locale with collection-helpers, but I don't know how to do that with Astronomy?
For example:
BikeData.helpers
  Timestamp: ->
    DateFormats =
      shortest: 'hh:mm:ss a'
      short: 'hh:mm:ss a M-D-YY'
      long: 'dddd DD.MM.YYYY hh:mm:ss a'
    # UI.registerHelper 'formatDate', (@Positions[0].Timestamp, format) ->
    if moment
      format = 'shortest'
      # can use other formats like 'lll' too
      format = DateFormats[format] or format
      moment(@Positions[0].Timestamp).format format
    else
      @Positions[0].Timestamp

I saw the docs and looked around through issues and other guides, but couldn't find any good  examples to get started with

But what's the problem?

No problem, I just have a question about documentation and how to use the transform functions

Actually figured it all out, I was just overthinking it

Ok good :)


BREAKING BUG: Bulk action URLs broken due to shop parameter

Current Behavior
When clicking on a bulk action link, you are redirected to the login page with the error:
Oops! An error has occured: Unable to verify signature.
Example URL:
https://someapp.com/order/edit?id=786876786867&shop=vndortesting.myshopify.com
However if I pass in the follow URL, it works fine:
https://someapp.com/order/edit?id=786876786867
The problem is, Shopify creates these parameters and the shop parameter breaks everything.

Package Version: master
Laravel Version: v5.8
PHP Version: v7.3
Laravel Forge:

I'am still getting the error even if I upgrade to dev-master. Some apps are affected and some of them are not. I suspect it's a same case you described @jedimdan

@MarinX this issue has been resolved in the latest release. I recommend going back to the latest version instead of using dev-master

I am still getting this same error, my version is 17


Loss of data after merge

Here testing stuff with 1.1.0.
settings.core.json
settings.ui.json
settings.shell.json
settings.python.json
After merge I get this final json:
settings.json
emeraldwalk.runonsave is missing in the final JSON. Also space formatting is not preserved:
  "emeraldwalk.runonsave": {
    "commands": [
      {
        "match": "\\.vscode/settings\\.(.+)\\.json$",
        "cmd": "sed '/^\\s*\\/\\//d' ${workspaceFolder}/.vscode/settings.*.json | sed -z 's/,\\s*\\([]}]\\)/\\1/g' | jq -s 'reduce .[] as $item ({}; . * $item)' > /tmp/settings.json && mv /tmp/settings.json ${workspaceFolder}/.vscode/settings.json"
      }
    ]
  },

vs
  "commands": [
  {
    "match": "\\.vscode/settings\\.(.+)\\.json$",
    "cmd": "sed '/^\\s*\\/\\//d' ${workspaceFolder}/.vscode/settings.*.json | sed -z 's/,\\s*\\([]}]\\)/\\1/g' | jq -s 'reduce .[] as $item ({}; . * $item)' > /tmp/settings.json && mv /tmp/settings.json ${workspaceFolder}/.vscode/settings.json"
  }
],

Didn't get any errors whatsoever...

Final working result should be the same output that is produced by run on save with this config:
  "emeraldwalk.runonsave": {
    "commands": [
      {
        "cmd": "sed '/^\\s*\\/\\//d' ${workspaceFolder}/.vscode/settings.*.json | sed -z 's/,\\s*\\([]}]\\)/\\1/g' | jq -sS 'reduce .[] as $item ({}; . * $item)' > /tmp/settings.json && mv /tmp/settings.json ${workspaceFolder}/.vscode/settings.json",
        "match": "\\.vscode/settings\\.(.+)\\.json$"
      }
    ]
  },

Admittedly, my config is much simpler, so i didn't encounter any issues. I'll strip the values out of the files you posted and add them to the test cases.

Here are more test cases
settings.json
settings.core.json
settings.standards.json
settings.ui.json
settings.optimization.json
(settings.json is generated correctly with my script)


Pull Requests JSON objects (API, Hooks) do not contain created_at and updated_at

  {
    "id": 3,
    "number": 5,
    "user": { ... },
    "title": "adsda",
    "body": "",
    "labels": [],
    "milestone": null,
    "assignee": null,
    "state": "open",
    "comments": 0,
    "html_url": "http://localhost:3000/Howl/asdasdas/pulls/5",
    "diff_url": "http://localhost:3000/Howl/asdasdas/pulls/5.diff",
    "patch_url": "http://localhost:3000/Howl/asdasdas/pulls/5.patch",
    "mergeable": true,
    "merged": false,
    "merged_at": null,
    "merge_commit_sha": null,
    "merged_by": null,
    "base": { ... },
    "head": { ... },
    "merge_base": "6ca6254b26fc84d366e42ceedd80e742962041f5"
  }

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/41924233-pull-requests-json-objects-api-hooks-do-not-contain-created_at-and-updated_at?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github).

Mention #64 since API-related


Question: What does setTopTweets do?

What does topTweets mean? Do you mean popular tweets or the tweet at the top of a thread?

very simple
If you go to Twitter.com and search for something, then on search page look at the 3rd row that has tab options. These are like this:

The top means some of the top tweets. Which can be extracted from this URL: https://twitter.com/search?q=bitcoin&src=typd
If you want all tweets and not restrict to top ones then you must click on Latest, the URL is this: https://twitter.com/search?f=tweets&vertical=news&q=bitcoin&src=typd
Look at the parameter difference. ignore Vertical. Main difference is f=tweets. That defines what you are getting in return.
for users: f=users
for photos: f=images
for video: f=videos
for news: f=news and
for broadcast: f=broadcast


v1.13.3

Which issue(s) this PR fixes:
N/A
What this PR does / why we need it:
prepare changelogs for next release.
Docs Changes:
should post a new article to https://github.com/fluent/fluentd-website/tree/master/content/blog/
Release Note:
N/A

I'll check it.

After landed this PR, Fluentd v1.14 development cycle has begun?

I think so!

v1.13.3 has been pushed.
https://rubygems.org/gems/fluentd/versions/1.13.3

After landed this PR, Fluentd v1.14 development cycle has begun?

Although we are investigating #3425 and #3382 in higher priority, we can't reproduce them on our environment yet.
If we resolve them and need to release v1.13.4, we'll create v1.13 branch.
The master branch should go ahead to v1.14.

Sorry for blocking your pull request for a long time.

No problem. metrics extension commits was hastily made feature. Blocking merging is very helpful for use to testing metrics extension.


docs: add maintainer info to contributing.md

closes #ISSUE-NO
What does this PR do?
Adds information about how maintainers are chosen in Eddiehub
Description of the task to be completed?
How can this be manually tested?
Any background context you want to provide?
Moderator discussion
Is there any relevant issue to this PR?
Screenshots (if appropriate)
Questions

LGTM! If required, more improvements can come in other PRs


Script includes from differect scopes, but with same names

Current: Script includes with same names are being overwritten
Target: Script includes with must be prefixed with scope name  and not being overwritten

no need to implement this as "api_name" could be used as filename. like in the default config:
https://github.com/andrekosak/ikosak-sync-now/blob/9354c908a033fc0b5302a9038f694a5e52168081/src/assets/syncconfig.yaml#L33


(IDEA) Add ticket download link in the registration confirmation as soon as we start sending tickets

description
Once we start sending the tickets to the visitors we could start adding the link to the ticket download in the confirmation email.
Obviously if it's possible to add snippet [[token]] in the email.
reason
It would most likely have a positive effect on the ticket downloads in the last days before the Expo.
Also, we usually assume that people who register closer to the event are more likely to come to the event so it would be great to keep them hyped about the event once they register.
list of benefits / areas that will benefit from the change
Faster ticket download process. Bigger chance for the visitors to download the ticket and actually attend the event.
priority 1-10
8
team members (initials) who discussed the idea
PSZ, MT

standard procedure since 2018.

re https://github.com/ecommerceberlin/ecommerceberlin.com/issues/169


Temporarily disable HTTP2 when talking with now-bru's API

This seems fine. I guess we're not doing the env var then?
cc @rauchg

Yeah @pranaygp no need for env var for now 👌


Doesn't work on Node 12.x because of imports

When trying to run this with Node v12.14.1, an syntax error is thrown because cli.js uses import statements instead of require(), which is apparently supported from Node version 13 and upwards, yet the package.json specifies version 12 to be supported.

@sindresorhus @RauliL is correct, and this comment is probably the right move IMO. I'd actually go so far as to suggest 12.22.0 since that's when the official docs state that it is generally and stabily supported.
In any case, >=12 is not right - I agree.

I can upgrade but I just wanted to point out that the engine requirement in package.json was incorrect.


added sound on/off button

addressed issue #333
added a button in index.html to disable and enable sound during the session

Yay!

Thanks!


Bug in PrivacyEngine

The term self.optimizer only appears in the function detach() of PrivacyEngine.
That means it leads to AttributeError when you call privacyengine.detach().
So we cannot run the example file CIFAR_TIMM_2phase.py properly.

Fixed. Added one line at L310 https://github.com/awslabs/fast-differential-privacy/blob/main/fastDP/privacy_engine.py


Add ingress support

I tried to add support for ingresses (should close #47). I only added support for version networking.k8s.io/v1 ingresses as I believe networking.k8s.io/v1beta1 is already deprecated. It seems to work as far as I can tell, and I created some tests for it.
Let me know if there's any changes you'd like me to make

Thank you. I'll check and merge later
On Wed, 24 May 2023, 9:31 pm shadowwolf899, @.***>
wrote:

I tried to add support for ingresses (should close #47
https://github.com/kdash-rs/kdash/issues/47). I only added support for
version networking.k8s.io/v1 ingresses as I believe
networking.k8s.io/v1beta1 is already deprecated. It seems to work as far
as I can tell, and I created some tests for it.
Let me know if there's any changes you'd like me to make
You can view, comment on, or merge this pull request online at:
https://github.com/kdash-rs/kdash/pull/316
Commit Summary

ea1b17b
https://github.com/kdash-rs/kdash/pull/316/commits/ea1b17b11cbd9b024906a2c5364ddc2d1401bd13
Adding ingress support. Should address #47

File Changes
(7 files https://github.com/kdash-rs/kdash/pull/316/files)

A src/app/ingress.rs
https://github.com/kdash-rs/kdash/pull/316/files#diff-77fe7233c6343a8a257af23731f52a3ba0957a58891b577dd3bc73344ca99433
(196)
M src/app/mod.rs
https://github.com/kdash-rs/kdash/pull/316/files#diff-b2db4128ee8d3fd19ff317f148c1b2d9e8e6fe7bcd711ca80b5617c21dd5b97c
(12)
M src/handlers/mod.rs
https://github.com/kdash-rs/kdash/pull/316/files#diff-05613bb57bfb64bc5526311e4c7a2179b5fd6c1290e980949d0197b1a783bee2
(16)
M src/network/kube_api.rs
https://github.com/kdash-rs/kdash/pull/316/files#diff-341ae1551c100624a4b5727d910414f4ceca55701e64fe63a73183e554146aef
(21)
M src/network/mod.rs
https://github.com/kdash-rs/kdash/pull/316/files#diff-bc565c9df4b377f07d29b6132b181f1a239dfd8acab3700841961ed4550f8975
(4)
M src/ui/resource_tabs.rs
https://github.com/kdash-rs/kdash/pull/316/files#diff-e7d1151caef1e1f5f58c97f1608129574cfe54243f7c4ced9b97e9755df59c61
(67)
A test_data/ingress.yaml
https://github.com/kdash-rs/kdash/pull/316/files#diff-63a7f0229e5ee311b911d1264be57de24859aadef1b3e79a58695f762893ff56
(90)

Patch Links:

https://github.com/kdash-rs/kdash/pull/316.patch
https://github.com/kdash-rs/kdash/pull/316.diff

—
Reply to this email directly, view it on GitHub
https://github.com/kdash-rs/kdash/pull/316, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIOKF67E4VYYP56WQKTM6TXHZOZRANCNFSM6AAAAAAYN2TFNY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Sorry for the delay @shadowwolf899 . This is awesome. I'll cut a new release with this and some other updates


chore: disable cache in CI

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6488b76). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #77   +/-   ##
=========================================
  Coverage          ?   90.69%
=========================================
  Files             ?        3
  Lines             ?       43
  Branches          ?        9
=========================================
  Hits              ?       39
  Misses            ?        4
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6488b76...69b3220. Read the comment docs.


Convert VERIFY and RETURN to VERIFY and RETURN

To @GEOS-ESM/chemistry-gatekeepers:
This commit is simple to rename some _VERIFY and _RETURN calls to be VERIFY_ and RETURN_ *on the dev/MAPL-2.0 branch. This is being done to make the maintenance of MAPL 2.0 easier.


what will happened with app in AppStore when 14.5 ios will release? (the AppsFlayer version small then 6)

Hi, We have an Application in AppStore with react-native-appsflyer: 5.4.4
Do we have to upgrade to version 6+?
The exsist application on the AppStore will still work?

we use AppsFlyer for some data like report about actions and deep link

Hi @idanlevi1. Yes you have to upgrade and we always recommend to update to the latest version.
Please take a look on the breaking changes from 5.x.x to 6.x.x here
and the timeToWaitForATTUserAuthorization parameter fo iOS 14.5 here

Hi @idanlevi1. Yes you have to upgrade and we always recommend to update to the latest version.
Please take a look on the breaking changes from 5.x.x to 6.x.x here
and the timeToWaitForATTUserAuthorization parameter fo iOS 14.5 here

Thank you, you can tell me what will happen to existing app in AppStore?

@amit-kremer93 can you please clarify? I've got the latest version
"react-native-appsflyer": "^6.3.0"
and this packages installed - AppsFlyerFramework (6.3.0)pod for me.
I also use 'react-native-tracking-transparency'
How to inform AppsFlyer (and should we?) when the tracking permission is granted ?

@kuznetsov-from-wonderland yes. you just need to set the time to wait and the sdk will automatically know the permission is granted


Clean up move page breadcrumbs

Cleaned up move breadcrumbs as per discussion on #8739.

@lb- this one is ready for review

Code looks good - I'll run it locally over the weekend just to double check. Great work here @PaarthAgarwal

Thanks 😄


copr: vectorize AddTimeDateTimeNull

Signed-off-by: pingyu<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number: fix #9016
Problem Summary: This PR is for vectorizing functions in impl_time.rs
What is changed and how it works?
What's Changed: vectorize add_time_datetime_null()
Related changes
No.
Check List
Tests

Unit test

Side effects
No.
Release note
None

/cc @skyzh @Xuanwo


why opencv-python use libpng15 but opencv use 1.6.37

Expected behaviour
use the latest libpng 1.6.37
Actual behaviour

libpng15 in use

opencv use 1.6.37
Steps to reproduce

example code
operating system
linux x86
opencv-python version <IP_ADDRESS>

Issue submission checklist

[x] This is not a generic OpenCV usage question (looking for help for coding, other usage questions, homework etc.)

[x] I have read the README of this repository and understand that this repository provides only an automated build toolchain for OpenCV Python packages (there is no actual OpenCV code here)

[x] The issue is related to the build scripts in this repository, to the pre-built binaries or is a feature request (such as "please enable this additional dependency")

[x] I'm using the latest version of opencv-python

For libpng15 has too many vulns problems

Core OpenCV team has already patched libpng in eabbe380016b1f777edc9a0315c902e1a5da381d. The fix should be available with 4.5.3 release.

Released.

This has not changed in 4.5.3:
unzip -l opencv_python_headless-<IP_ADDRESS>-cp36-cp36m-manylinux2014_x86_64.whl 'opencv_python_headless.libs/*'
Archive:  opencv_python_headless-<IP_ADDRESS>-cp36-cp36m-manylinux2014_x86_64.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
   752584  2021-07-09 12:13   opencv_python_headless.libs/libssl-f3db6a3b.so.1.1
   566472  2021-07-09 12:13   opencv_python_headless.libs/libswscale-2d2bce5d.so.5.8.100
    70992  2021-07-09 12:13   opencv_python_headless.libs/libbz2-a273e504.so.1.0.6
  2605312  2021-07-09 12:13   opencv_python_headless.libs/libavformat-06a336f2.so.58.61.100
 13876032  2021-07-09 12:13   opencv_python_headless.libs/libavcodec-8daa01ff.so.58.109.100
  3397560  2021-07-09 12:13   opencv_python_headless.libs/libvpx-14094576.so.6.3.0
   128096  2021-07-09 12:13   opencv_python_headless.libs/libswresample-4767dc06.so.3.8.100
   193544  2021-07-09 12:13   opencv_python_headless.libs/libpng15-c2ffaf3d.so.15.13.0
   712752  2021-07-09 12:13   opencv_python_headless.libs/libavutil-01d48d95.so.56.60.100
    96272  2021-07-09 12:13   opencv_python_headless.libs/libz-d8a329de.so.1.2.7
  3565928  2021-07-09 12:13   opencv_python_headless.libs/libcrypto-098682aa.so.1.1
---------                     -------
 25965544                     11 files

Many of the other libraries bundled here are quite outdated as well. I suspect these are coming from the manylinux2014 docker image via auditwheel, rather than the vendored source code in the opencv repo.
However, as manylinux2014 is derived from centos 7, these binaries hopefully include backported fixes for many of the vulnerabilities that scanners are reporting based on the version number.

The manylinux2014 images should be updated, they are 10 months old: https://quay.io/repository/skvark/manylinux2014_x86_64?tab=tags.
They are custom images built by me before this repository was transferred to the OpenCV organization. The Dockerfiles are here: https://github.com/opencv/opencv-python/tree/master/docker
It takes quite a lot of time to build them (especially the aarch64 ones), so you'll need a very powerful CI system or they need to be built locally as I did when I was still maintaining this project.

The docker images was updated for 4.5.4 release: https://github.com/opencv/opencv-python/pull/556


Readme.md - Update Azure AD App Registration steps

Removed step 9. Implicit Access
Implicit Grant/Access configuration is not available for Mobile and Desktop Application Platforms

@jenschristianschroder I merged in some changes to the readme today that addressed this and a couple of other issues with the App Registration steps that should resolve issues that you and others found in the initial release #648. Take a look at the updates. Thanks!


Fix bug when ignoreOtherParameters() is combined with withOutputParameter()

This fixes #686.

The problem is that, when no expectation was specified, it tried to compare with the default MockNamedValue, which has name_ "" and type_ "int". So you got an error that "const void*" was expected, but it got "int" (not a mock expectation error). Which was strange indeed.