4.2 version android plugin crash with java.lang.ClassNotFoundException

Tested versions
Reproduce in 4.2.1
System information
Ubuntu 23.10, Godot_v4.2.1-stable_linux.x86_64
Issue description
App died with java.lang.ClassNotFoundException when used this template - https://github.com/m4gr3d/Godot-Android-Plugin-Template It`s crashed with any imported classes, not only GoogleApiAvailability, also task.Task and others.
It seems that the classes from dependencies are not included in the apk's classes.dex and game always crash with java.lang.ClassNotFoundException.
Steps to reproduce

Start new plug-in with - https://github.com/m4gr3d/Godot-Android-Plugin-Template
Import any library, e.g.

import com.google.android.gms.common.GoogleApiAvailability

and call it:
val googleApiAvailability = GoogleApiAvailability.getInstance()
val status: Int = googleApiAvailability.isGooglePlayServicesAvailable(activity!!)

Assemble and install plug-in
Run game with it
Watch logcat:

2-13 11:28:55.970  5464  5464 F DEBUG   : Caused by: java.lang.ClassNotFoundException: Didn't find class "com.google.android.gms.common.GoogleApiAvailability" on path: DexPathList[[zip file "/data/app/~~5i67fVLY5Ef9yC4AfWCKlw==/org.godotengine.classicsnake-ZMW6o20AcigpqLXz7bibYQ==/base.apk"],nativeLibraryDirectories=[/data/app/~~5i67fVLY5Ef9yC4AfWCKlw==/org.godotengine.classicsnake-ZMW6o20AcigpqLXz7bibYQ==/lib/x86_64, /data/app/~~5i67fVLY5Ef9yC4AfWCKlw==/org.godotengine.classicsnake-ZMW6o20AcigpqLXz7bibYQ==/base.apk!/lib/x86_64, /system/lib64, /system_ext/lib64]]

Minimal reproduction project (MRP)
Godot-Android-Plugin-Template.zip

I addressed the issue in my project
I overridden the export_plugin.gd example：
func _get_android_dependencies (platform, debug):
    if debug:
        return PackedStringArray(["com.google.android.gms:play-services-base:18.2.0"])
    else:
        return PackedStringArray(["com.google.android.gms:play-services-base:18.2.0"])

@Rrenovation how and when you call this func?

@Rrenovation Thanks my friend!!!
It works.

@Rrenovation  Thanks your for your answer. I am little confused. Suppose my android library uses implementation("androidx.biometric:biometric:1.1.0") do i still need to com.google.android.gms:play-services-base:18.2.0 in PackedStringArray
Also similar issue occurs when i try to use Kotlin's coroutines, even for that do i still need to add  com.google.android.gms:play-services-base:18.2.0 in PackedStringArray

I have tried many things with the 4.2 version of the Android plugin, and the compileOnly and implementation parameters seem more like compileOnly. implementation appears not to take effect.

@kyadalu1 I have tried many things with the 4.2 version of the Android plugin, and the compileOnly and implementation parameters seem more like compileOnly. implementation appears not to take effect.

Why did you use com.google.android.gms:play-services-base:18.2.0. I don't get it

@pritish-thub it's main class .
Needed for my case: googleApiAvailability

@trash-max Doesn't seem to work for my use case. I am trying to import androidx.biometric:biometric:1.1.0 so i refactored the above code to
```

func _get_android_dependencies (platform, debug):
if debug:
return PackedStringArray(["androidx.biometric:biometric:1.1.0"])
else:
return PackedStringArray(["androidx.biometric:biometric:1.1.0"])

It works now, i am facing different issue. Thanks @trash-max  @Rrenovation

@trash-max @Rrenovation One question which i would like to ask you guys is i face similar issue here. It is due to kotlin coroutines. Coroutines are part of kotlin lang and i am using version 1.9.10 and kotlin is not any third party dependency. If i use normal kotlin code my plugin works but as soon as i use coroutines it craashes. Any advice

@trash-max @Rrenovation One question which i would like to ask you guys is i face similar issue here. It is due to kotlin coroutines. Coroutines are part of kotlin lang and i am using version 1.9.10 and kotlin is not any third party dependency. If i use normal kotlin code my plugin works but as soon as i use coroutines it craashes. Any advice

Yup same here

@kyadalu1 Maybe the Godot android plugin might be using old kotlin version when coroutines where not part of kotlin and had to be added as a separate dependency

@kyadalu1 Godot 4.2.1 uses kotlin version 1.7.0 by default.
You can update it if need in /android/build/config.gradle
This part:
ext.versions = [
    androidGradlePlugin: '7.2.1',
    compileSdk         : 33,
    // Also update 'platform/android/export/export_plugin.cpp#OPENGL_MIN_SDK_VERSION'
    minSdk             : 21,
    // Also update 'platform/android/export/export_plugin.cpp#DEFAULT_TARGET_SDK_VERSION'
    targetSdk          : 33,
    buildTools         : '33.0.2',
    kotlinVersion      : '1.7.0',
    fragmentVersion    : '1.3.6',
    nexusPublishVersion: '1.1.0',
    javaVersion        : 17,
    // Also update 'platform/android/detect.py#get_ndk_version()' when this is updated.
    ndkVersion         : '23.2.8568313'

Thanks @trash-max for your reply, I just updated it to  kotlinVersion      : '1.9.20', but still same issue

Hey all, this is behavior as intended. The Godot Android library only includes Godot related classes and logic, and so any additional dependencies need to be specified both within build.gradle.kts and within  the _get_android_dependencies method as @Rrenovation mentioned.
@kyadalu1 Kotlin coroutines are a separate dependency to avoid inflicting the cost on Kotlin users that don't make use of coroutines capabilities.
You can find information about how to include the coroutine dependency at https://developer.android.com/kotlin/coroutines#dependency

@m4gr3d Godot relies on kotlin v1.7.0 so i think coroutines needs to be added as separate dependency. In many of my native android projects which uses kotlin v1.9.20 and even for some which uses kotlin v1.8.20, i never had to add couroutines as separate dependency.
Will Godot 4.3 update kotlin version to 1.8 or 1.9?


brightness keys are not detected

Expected behavior:
Brightness keys are detected and respond to keybinds.
Actual behavior:
Brightness keys are not detected.
To Reproduce:
set keybinds with xf86brightnessup

for this to work we need to read events on video outputs...I don't know how to do that right now.

it works fine for me.
XF86MonBrightnessUp
    xbacklight -inc 5

^Triggers as expected when pressing the brightness adjustment keys on my laptop.

Huh you're right, it does work. odd.

it works fine for me.
XF86MonBrightnessUp
    xbacklight -inc 5

^Triggers as expected when pressing the brightness adjustment keys on my laptop.

what compositor are you on?

Xf86audio keys don't work either

I tried it on bspwm and river. Both the audio keys and the brightness keys work...
In testing I found, there is a mistake for the xf86audioplay key it should be mapped to Key::KEY_PLAYPAUSE not Key::KEY_PLAY, but aside from that it works fine.

I tried it on bspwm and river. Both the audio keys and the brightness keys work...
In testing I found there is a mistake for the xf86audioplay key it should be mapped to Key::KEY_PLAYPAUSE not Key::KEY_PLAY, but aside from that it works fine.

On my device the brightness controls are emitted by the video outputs..might be hardware specific. I changed it to playpause and it still doesn't work...might also be hardware specific so we probably need to bind to the other event file descriptors too.

Oops guess I was wrong, play pause works now.

Hi,
@loiccoyle @Shinyzenith Would you mind testing again on the latest version to check if this is still an issue for you?
I would be happy to try to fix it if it is still a problem!

Hi,
@loiccoyle @Shinyzenith Would you mind testing again on the latest version to check if this is still an issue for you? I would be happy to try to fix it if it is still a problem!

Sure thing! I'll try as soon as I get access to my laptop but the last time I checked with libinput debug logs, on some machines (such as my laptop) they are emitted by video devices.

@ajanon Yep! this issue still occurs.

The events are emitted by Video Bus according to the logs which is definitely not a keyboard aka one of our grabbed devices

What happens if you forcibly grab the device with ˋ--deviceˋ?

Upon grabbing forcibly with --device it does work once again.

Should we drop the keyboard device detection now? Maybe it is not necessary anymore and we can just grab all devices.

Should we drop the keyboard device detection now? Maybe it is not necessary anymore and we can just grab all devices.

To be completely fair, the keyboard device detection has been extremely flawed to begin with! I think I agree with you, we should drop the check all-together and just parse the events we care about and re-emit the rest all through uinput.
Should we create an issue to track this? Note: Reminder to add to README/FAQ that all device configurations should henceforth be made to the uinput device instead of the specific devices due to swhkd's grab.

I created issue #191 about this.
@Shinyzenith Feel free to add your reminder there!


For people who generate the links later with Livewire, give a JavaScript method to add event to the buttons.

Since the JavaScript methods fired on Dom load, the buttons generated later will not have the functionality.
Please create a JavaScript method for people to add events to the buttons later.

Hi @ronald2wing,
Thank you for your suggestion. I need some time to think about how to implement it in a better way.
Meantime, could you please share the way how you generate the links with Livewire?

I was going to try: https://laracasts.com/discuss/channels/livewire/how-to-call-alpine-js-method-from-livewire
The default behavior is enough for me right now.

Another I will do is to use $wire.methods() to call the Livewire method in the frontend directly and call the button update method. Thank you for looking into this.

Hello @ronald2wing,
I played around with Livewire 2/3 for a couple of days and I didn't discover any issues with "DOMContentLoaded" event. Even if I render the code of the buttons through the Livewire render() method, the JavaScript code of the buttons works perfectly and the buttons have the expected functionality.
Could you please provide more information about your issue? Why do you need a separate method to add events if it works out of the box?

It could be related to using Alpine.js with Livewire. I will test it again on my local tonight. The Livewire was rerendered on the page after input changes. DOMContentLoaded is only loaded after the page is loaded, but some of my contents are loaded based on the input changes.
`@if (Route::currentRouteName() === 'music-videos.show')
@section('title', $musicVideo['title'])
@endif

Search

                @foreach ($musicVideos as $mv)

{{ $mv['title'] . ($mv['korean_title'] ? " ({$mv['korean_title']})" : '') }}
/
{{ $mv['artist'] }}

{{ $mv['release_date'] }}

                                {!! ShareButtons::page(route('music-videos.show', $mv['slug']), "{$mv['title']} by {$mv['artist']}", [
                                        'block_prefix' => '',
                                        'class' => 'mr-4',
                                        ])
                                        ->copylink()
                                        ->mailto()
                                        ->facebook()
                                        ->twitter()
                                        ->pinterest()
                                        ->render();
                                !!}

                @endforeach

            @if ($isDone)
                The End of the List
            @else
                Loading...
            @endif

/

`

Hello @ronald2wing,
Did you get a chance to test it again yesterday?

@kudashevs
If you scroll down to lazyload next page and click one of the twitter: https://popcreme.com/music-videos/shooting-star
The elements will not have the JavaScript.

Hello @ronald2wing,
Now I see the issue. Thanks for sharing the link.
I'll extract a method and let you know :)

@ronald2wing here is a new version of vanilla share-buttons.js file with an updated socialButtonClickHandler function. I've made it a little bit more flexible and from now it can be used not only directly, but also through bubbling. As an example of bubbling, it can be used like this:
document.addEventListener('click', function (e) {
    socialButtonClickHandler(e);
})

Could you please try to play around with it and let me know if it works?
If everything is OK, I'll include it in the future release with other improvements.

Hello, the new changes do not work. Now even the default DOMContentLoaded does not set the events either.

@ronald2wing I didn't take into account additional classes on links.
I changed the code in the share-buttons.js file and now it should work.
Could you please check it out?

I think the socialButtonClickHandler is only available in the JS file because, after file compression, the function will be renamed.

@ronald2wing the compressed (minified) version works well. As I see the issue is related with with app.js.

As you can see in the pictures, there is a click event listener handled by the app-b5a7b72e.js:5. If I manually remove it everything works fine. So, my guess is that this event listener handles a click event too and somehow prevents a preventDefault to happen in share-buttons.js, so the click continues to be processed.

@ronald2wing I added a prevention of other event listeners to the share-buttons.js file. Theoretically, this should do the trick.
Could you please check it out?

Sure. Thank you. I will check tonight.
On Sat, Aug 12, 2023, 11:54 AM Sergey Kudashev @.***>
wrote:

@ronald2wing https://github.com/ronald2wing I added a prevention of
other event listeners to the share-buttons.js
https://github.com/kudashevs/laravel-share-buttons/blob/master/resources/assets/js/share-buttons.js
file. Theoretically, this should do the trick.
Could you please check it out?
—
Reply to this email directly, view it on GitHub
https://github.com/kudashevs/laravel-share-buttons/issues/1#issuecomment-1675974083,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD7QPSOXIUSQP4R3KFY6GWLXU6RMLANCNFSM6AAAAAA3GDFIIM
.
You are receiving this because you were mentioned.Message ID:
@.***>

It works after applying the new changes and setting the function to the window because static file compression changed its name.

Nice. @ronald2wing I want to close the issue, but before closing it I have two questions:

this new method is what you wanted or you have other suggestions?
should I delete the images of your project of should I leave them?

That's the new method I wanted.
You can leave them.

On Sun, Aug 13, 2023, 2:16 AM Sergey Kudashev @.***>
wrote:

Nice. @ronald2wing https://github.com/ronald2wing I want to close the
issue, but before closing it I have two questions:

this new method is what you wanted or you have other suggestions?
should I delete the images of your project of should I leave them?

—
Reply to this email directly, view it on GitHub
https://github.com/kudashevs/laravel-share-buttons/issues/1#issuecomment-1676246494,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD7QPSL7FQ5QGITRC4HFN43XVBWKJANCNFSM6AAAAAA3GDFIIM
.
You are receiving this because you were mentioned.Message ID:
@.***>

The requested functionality was added in the v4.0.0 release.
@ronald2wing thank you for your contribution.

Thank you as well.
On Mon, Aug 14, 2023 at 5:39 PM Sergey Kudashev @.***>
wrote:

The requested functionality was added in the v4.0.0
https://github.com/kudashevs/laravel-share-buttons/releases/tag/v4.0.0
release.
@ronald2wing https://github.com/ronald2wing thank you for your
contribution.
—
Reply to this email directly, view it on GitHub
https://github.com/kudashevs/laravel-share-buttons/issues/1#issuecomment-1678109245,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD7QPSI336TGVVVIOQ7CE73XVKLHRANCNFSM6AAAAAA3GDFIIM
.
You are receiving this because you were mentioned.Message ID:
@.***>


Update how-to-connect-pta-faq.yml

adding new FAQ
Why is my connector still using an older version and not auto-upgraded to latest version?

@mudeeb : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@billmath - If you accept the proposed content, the commit will need to be moved to the private repo for automated checks and review. Let us know if you need help with the move.
#label:"aq-pr-triaged"

#sign-off

#label:"aq-pr-triaged"

@billmath, can you move these changes to the private repo so we get build validation and staging? We can assist, but it might take longer. Thanks.

Okay, I have pulled this in to a private pr:  https://github.com/MicrosoftDocs/azure-docs-pr/pull/193257
I will submit this one and get this doc updated.  We can close this PR.  Thanks!
Bill

Okay, I have pulled this in to a private pr: MicrosoftDocs/azure-docs-pr#193257
I will submit this one and get this doc updated. We can close this PR. Thanks!
Bill

Great. Thanks, Bill.


Slide menu

Built-in Gestures - OFF doesn't seem to work, it still has the slide gestures to see the menu
I wanted to use my own buttons

Resolved in latest release


useFetch cache Error response and never load it again

Environment

Node Version: v18.18.0
Nuxt 3.8.0
Nitro 2.7.2

Reproduction
https://stackblitz.com/edit/nuxt-starter-jgqfhc?file=pages%2Findex.vue
Describe the bug
If use useFetch and receive a response of 404 500 ... After that, change the web page. and return to the original page.
useFetch will not resend the request and will continue to use the same one it received before. But if refresh the website, useFetch will work normally.
Additional context
This is caching of useFecth? How do I handle it?
Logs
No response

This should be resolved in the edge channel via https://github.com/nuxt/nuxt/pull/23889, or in the next release.
Let me know if not and I'll reopen.


Add benchmark to measure performance

The best thing would be to operate on the same corpora the native hyperscan benchmark tool hsbench is operating on, see https://01.org/blogs/jpviiret/2017/performance-analysis-hyperscan-hsbench

I can't help to notice that hyperscan-java is an order of magnitude slower in my use case. Hence I created my test cases (not the same corpora of hyperscan benchmark though), to see if there's room for improvements. Here's how to use my benchmark.

@toddleo can you describe your use case and provide an example on how you attempt to use hyperscan-java in a new issue? It's not clear to me from your "benchmark code" what your exact use case is.
Furthermore, it's advisable to use a benchmark framework like JMH (see here for an introduction), because JVM benchmarking is hard to get right.

@gliwka you are right scalatest might not be the proper tool for benchmark. I'll see what I can do with sbt-jmh (or maybe ScalaMeter) in the following days, and update description for my use case.
Nevertheless, happy new year! :fireworks:


[GitHub Gist] ...

Extension – GitHub Gist
Author: @koinzhang

Description
Completely BUGS out Raycast rendering it completely useless.
Steps To Reproduce

Launch Raycast
Run Search Gists Command.

The current behavior
Video: https://share.cleanshot.com/2Xp6d1

Frozen Raycast window (CPU Spike), no way to quit it

The expected behavior

Show gists and details

Raycast version
Version: 1.38.3

Hi @Aayush9029. I'm sorry you encounter this kind of problem, but I can't reproduce this problem now and can't provide a solution for the time being

Apparent the extension was having trouble rendering large files!
I'm assuming it's a raycast limitation so I closed this issue!


refactoring to create dynamic request model

closes #203
I haven't made any changes to the sqlalchemy or pgstac modules. As I am not using either of them, I think it would be better for someone who is actively using them to try out the changes and make adjustments.
I have ended up with a Pydantic model for POST and an APIRequest for GET. This doesn't sit super comfortable but it seems necessary based on various threads on forums (e.g. this one) which suggest that Pydantic is not appropriate for query params.
What's new?
This PR defines GET and POST request models for the extensions as well as pulling the pagination model out of the base. This should allow much more flexibility for implementation. Declared extensions are mixed together to create a dynamic request model which is rendered in the docs as query params for GET and body for POST.

@rsmith013 what's the state of the PR? I'm curious if this is required with the recent move away from stac-pydantic, and also change in https://github.com/stac-utils/stac-fastapi/pull/271 to allow for custom search models to be used.

@lossyrob I got as far as the changes required to the pgstac and sqlalchemy backends. As I don't use them, I wouldn't have a way to check that they were working properly. I can try and make the changes and then others can verify.
I'll take a deeper look at the other PR but this PR is about providing a framework where you don't need to define custom search models. The auto-generated docs reflect the implemented extensions.
This means that without any enabled extensions /search just provides basic stac parameters then implementing sort extension automatically adds the sort parameter, adding the filters extension automatically adds the filters parameter, etc...
It was about not baking in a particular implementation of the stac API and getting it to react to the enabled extension classes.
I will see if I can find time to update with master and push it to completion.

@lossyrob This should be all done now. Let me know if you want anything changed.
This hopefully moves to a standardised way of implementing extensions where it is declarative and the search request model is dynamically generated from the enabled extensions, including updating the conformance classes and creating a single, shared set of validators.

@moradology I have added a changelog entry and merged master. I have held fire on moving the operator class for the reasons mentioned in the thread from your comment.


endpointmgr: guard against potential nil deref

There's a potential nil deref within
EndpointManager.InitHostEndpointLabels.
We never run into it due to the correct order of events in daemon_main, but if the code was to shift, it could occur.
This commit simply checks nil, logs and error, and returns.
Signed-off-by: Louis DeLosSantos<EMAIL_ADDRESS>

We never run into it due to the correct order of events in daemon_main, but if the code was to shift, it could occur.

If users can't currently hit it, then it should be release-note/misc instead of release-note/bug.

/test

/test-1.26-net-next

@pchaigno that is quite the large failure. :thinking:

@pchaigno that is quite the large failure. thinking

Yep, they are all failing because the PR is very old. You'll need to rebase.

Done.

/test


Log messages larger than 4k are being truncated by rsyslog

I've recently noticed that several of my DEA and Cloud Controller log messages are being truncated at 4K.  This is because of rsyslog:  http://www.rsyslog.com/doc/rsyslog_conf_lines.html
It says that Lines can be continued by specifying a backslash ("\") as the last character of the line. So perhaps Steno can be improved to escape lines larger than 4k?

@youngm If this is really painful right now we can look into prioritizing it but Steno is currently not a development priority for us.
As always, pull requests will be happily accepted.
Best,
@zaksoup @DanLavine

@zaksoup Thanks.  Just thought I'd bring it to light in case it was important.  If it bugs me enough I'll submit a PR.


resources page: wrap screenshot on a link so it can be zoomed in

 Response Simulator - Make the spreadsheet image clickable to zoom


Re-throw evaluation errors on deferred namespace property access

This commit changes the behavior of namespaces obtained through import defer to re-throw evaluation errors even if the module is fully evaluated:
import defer * as ns from "module-that-throws";
try { ns.foo } catch { console.log("Error!") }
try { ns.foo } catch { console.log("Error!") }

The code above is now guaranteed to print "Error!" twice, and it doesn't depend on whether other modules already evaluated "module-that-throws".
This is different from the existing behavior of namespace objects, so we have to use a different namespace object for deferred import:
import defer * as ns1 from "module-that-throws";
import * as ns2 from "module-that-throws";

Promise.resolve().then(() => {
  try { ns1.foo } catch { console.log("Error1!") }
  try { ns2.foo } catch { console.log("Error2!") }
});

Assuming that this module's body is evaluated due to a cycle (module-that-throws imports it, and module-that-throws is the entry point), the code above will print "Error1!" and not "Error2!". This means that ns1 !== ns2. Namespace objects are still cached, so if you import defer the same module twice you will get the same namespace object.
Thanks to this change, we can now also make "trying to evaluate a deferred module in a cycle" an error, rather than silently skipping its evaluation as done in #39. This ensures that a binding cannot be accessed during evaluation to then disappear as soon as the module is done evaluating with an error.
Fixes #41 cc @guybedford

@guybedford I updated the spec. It turns out the TODO I left is already handled, but I left it as a NOTE since it's not trivial to notice.

One possible optimization - in the case where a deferred module has already successfully executed, we could provide the normal namespace instead of the deferred namespace without there being any observable difference. This could possibly be a spec note or even specified.

Guy and I discussed this in the modules call last week -- this cannot be done because the identity of the two namespaces is observably different.


Dev jurgen

Added two labels Publikum and Vertrag.

This was just a test. Added most of the changes in #14


Change throwng of exceptions in FSI

@prutskov Can you please rebase and ensure that formatting passes?

@aregm This was merged already in other PR. I close this PR.


Hidden selected words

Hey! Really like what you built 🙌
I just noticed there is kind of a hidden state with words not displayed as highlighted even if they are in the output

Thanks for the feedback! I'll get right on it!

@LaRiffle Can you be more precise about how you came up with the NULL values ? I can't reproduce them.

To have the hidden state you can do the following :

Click on word Lorem
Click on word Ipsum
Click on button Add
Click on work dolor
Click on button Add
That's where you arrive:

None seem related to deleted annotations


how to convert to trt model for extended models and vgg model

I want to convert this model to trt model and use it for my case, I have vgg as a base model and age as the extended model, I only want to use the age model in my case, how to convert it to trt and model and do inferencing.

You may consider to ask this in stackoverflow


Multiple User Types

We have both admin and user types but these are stored in separate tables. We'd like both types to be able to log in using the same mechanism. It seems that knock doesn't really lend itself to having this arrangement - is there any recommended way of doing this?

Have you read the README? Knock allows you to use any user type that you want side by side, out of the box. The example is even given specifically for admin.
Let me know if I misunderstood your question or if you find the README isn't clear enough.

I have read the readme; I'm using knock in production. What I want is that current_user would return either User or Admin depending on who is logged in. I've got a workaround in place anyway.

For future readers, the owner's comments on PR https://github.com/nsarno/knock/pull/16 provide insight into this use case, including a suggested solution.


Add recovery options

This just creates the required recovery.conf file in the PostgreSQL config directory. It also updates a couple of parameters to use globally set parameters by the main postgresql class because I did not want to hardcode version numbers.

Opened prematurely after testing


[Bug]: Can't Use Action on the form with OnSubmit in the same time for validation

Describe the bug
Am using the form as the documentation but when i remove the On submit i loss the validation functionality and the server action works great when using action alone the validation not popping and when i tried to put the action inside the on Submit didn't work either
Form Snippet

Action Snippet

Affected component/components
Form
How to reproduce
Just check the images
Codesandbox/StackBlitz link
No response
Logs
No response
System Info
Firefox

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

@AmrViernes Does this help? https://www.youtube.com/watch?v=VLk45JBe8L8

@AmrViernes Does this help? https://www.youtube.com/watch?v=VLk45JBe8L8

Thanks man yes this seems the same problem exactly I'm gonna try his solution and keep you updated

@ahkhanjani thanks for providing link too! 🥳

@AmrViernes Does this help? https://www.youtube.com/watch?v=VLk45JBe8L8

This works but it won't be able to use the useFormStatus.
The problem is it doesn't trigger the action with the <form>.
<form
  ref={formRef}
  // action={formAction} // this is actually no needed, it won't call anyway
  onSubmit={(evt) => {
    evt.preventDefault();
    form.handleSubmit(() => {
      console.log(`[SurveyForm] formAction: `, formAction);

      formAction(new FormData(formRef.current!));
    })(evt);
  }}
>

As a result, when you use useFormStatus it won't be able to receive the action.
export const SubmitButton: React.FC<{
  label?: string;
}> = ({ label = 'Save' }) => {
  // THIS DOES NOT WORK
  const { pending, action } = useFormStatus();
  return (
    <>
      <Button type="submit" variant="contained" disabled={pending}>

          {pending && <CircularProgress color="inherit" size={'1em'} />}
          {label && {label}}

      </Button>
    </>
  );
};

Would love to know any workaround. Really want to keep the client side validation with useForm hook.


Update protobuf version

Fixes issue on clang_release build which calls into the onnx runtime test runner.

In requirements.txt it specifically points to protobuf 3.11.0. Could you just change it to 3.20.0 there?

Trying that now.

We should still pin the protobuf version for python.

We should still pin the protobuf version for python to match whatever version we use in requirements.txt.

Updated

Looks like there's an issue with the newer version of protobuf when building with MIGraphX, so for now I am keeping it as is. We can resolve that issue in a different PR.


Unable to compile netperf on centos 10

# git clone https://github.com/HewlettPackard/netperf.git
Cloning into 'netperf'...
remote: Enumerating objects: 5252, done.
remote: Counting objects: 100% (324/324), done.
remote: Compressing objects: 100% (94/94), done.
remote: Total 5252 (delta 234), reused 305 (delta 229), pack-reused 4928
Receiving objects: 100% (5252/5252), 16.75 MiB | 1.55 MiB/s, done.
Resolving deltas: 100% (3930/3930), done.
# cd netperf/
# ./autogen.sh
configure.ac:28: installing './compile'
configure.ac:19: warning: 'AM_CONFIG_HEADER': this macro is obsolete.
configure.ac:19: You should use the 'AC_CONFIG_HEADERS' macro instead.
./lib/autoconf/general.m4:2434: AC_DIAGNOSE is expanded from...
aclocal.m4:745: AM_CONFIG_HEADER is expanded from...
configure.ac:19: the top level
configure.ac:34: warning: The macro `AC_HAVE_LIBRARY' is obsolete.
configure.ac:34: You should run autoupdate.
./lib/autoconf/libs.m4:138: AC_HAVE_LIBRARY is expanded from...
configure.ac:34: the top level
configure.ac:37: warning: The macro `AC_HEADER_STDC' is obsolete.
configure.ac:37: You should run autoupdate.
./lib/autoconf/headers.m4:704: AC_HEADER_STDC is expanded from...
configure.ac:37: the top level
configure.ac:44: warning: The macro `AC_HAVE_LIBRARY' is obsolete.
configure.ac:44: You should run autoupdate.
./lib/autoconf/libs.m4:138: AC_HAVE_LIBRARY is expanded from...
configure.ac:44: the top level
configure.ac:46: warning: The macro `AC_HAVE_LIBRARY' is obsolete.
configure.ac:46: You should run autoupdate.
./lib/autoconf/libs.m4:138: AC_HAVE_LIBRARY is expanded from...
configure.ac:46: the top level
configure.ac:47: warning: The macro `AC_HAVE_LIBRARY' is obsolete.
configure.ac:47: You should run autoupdate.
./lib/autoconf/libs.m4:138: AC_HAVE_LIBRARY is expanded from...
configure.ac:47: the top level
configure.ac:52: warning: The macro `AC_HAVE_LIBRARY' is obsolete.
configure.ac:52: You should run autoupdate.
./lib/autoconf/libs.m4:138: AC_HAVE_LIBRARY is expanded from...
configure.ac:52: the top level
configure.ac:60: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:60: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
lib/m4sugar/m4sh.m4:692: _AS_IF_ELSE is expanded from...
lib/m4sugar/m4sh.m4:699: AS_IF is expanded from...
./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from...
acinclude.m4:45: OLD_TYPE_SOCKLEN_T is expanded from...
configure.ac:60: the top level
configure.ac:65: warning: The macro `AC_HEADER_TIME' is obsolete.
configure.ac:65: You should run autoupdate.
./lib/autoconf/headers.m4:743: AC_HEADER_TIME is expanded from...
configure.ac:65: the top level
configure.ac:67: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:67: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
src/missing/m4/salen.m4:19: AC_CHECK_SA_LEN is expanded from...
configure.ac:67: the top level
configure.ac:76: warning: The macro `AC_TYPE_SIGNAL' is obsolete.
configure.ac:76: You should run autoupdate.
./lib/autoconf/types.m4:776: AC_TYPE_SIGNAL is expanded from...
configure.ac:76: the top level
configure.ac:479: warning: The macro `AC_HAVE_LIBRARY' is obsolete.
configure.ac:479: You should run autoupdate.
./lib/autoconf/libs.m4:138: AC_HAVE_LIBRARY is expanded from...
configure.ac:479: the top level
configure.ac:638: warning: The macro `AC_HAVE_LIBRARY' is obsolete.
configure.ac:638: You should run autoupdate.
./lib/autoconf/libs.m4:138: AC_HAVE_LIBRARY is expanded from...
configure.ac:638: the top level
configure.ac:652: warning: The macro `AC_HAVE_LIBRARY' is obsolete.
configure.ac:652: You should run autoupdate.
./lib/autoconf/libs.m4:138: AC_HAVE_LIBRARY is expanded from...
configure.ac:652: the top level
configure.ac:657: warning: The macro `AC_HAVE_LIBRARY' is obsolete.
configure.ac:657: You should run autoupdate.
./lib/autoconf/libs.m4:138: AC_HAVE_LIBRARY is expanded from...
configure.ac:657: the top level
configure.ac:689: warning: The macro `AC_HAVE_LIBRARY' is obsolete.
configure.ac:689: You should run autoupdate.
./lib/autoconf/libs.m4:138: AC_HAVE_LIBRARY is expanded from...
configure.ac:689: the top level
configure.ac:696: warning: The macro `AC_HAVE_LIBRARY' is obsolete.
configure.ac:696: You should run autoupdate.
./lib/autoconf/libs.m4:138: AC_HAVE_LIBRARY is expanded from...
configure.ac:696: the top level
configure.ac:703: warning: The macro `AC_HAVE_LIBRARY' is obsolete.
configure.ac:703: You should run autoupdate.
./lib/autoconf/libs.m4:138: AC_HAVE_LIBRARY is expanded from...
configure.ac:703: the top level
# ./configure --bu# make
make  all-recursive
make[1]: Entering directory '/root/netperf-2.7.1'
Making all in src
make[2]: Entering directory '/root/netperf-2.7.1/src'
Making all in missing
make[3]: Entering directory '/root/netperf-2.7.1/src/missing'
Making all in m4
make[4]: Entering directory '/root/netperf-2.7.1/src/missing/m4'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory '/root/netperf-2.7.1/src/missing/m4'
make[4]: Entering directory '/root/netperf-2.7.1/src/missing'
make[4]: Nothing to be done for 'all-am'.
make[4]: Leaving directory '/root/netperf-2.7.1/src/missing'
make[3]: Leaving directory '/root/netperf-2.7.1/src/missing'
make[3]: Entering directory '/root/netperf-2.7.1/src'
gcc -DHAVE_CONFIG_H -I. -I..      -MT netlib.o -MD -MP -MF .deps/netlib.Tpo -c -o netlib.o netlib.c
netlib.c: In function ‘bind_to_specific_processor’:
netlib.c:2343:9: error: implicit declaration of function ‘sched_setaffinity’; did you mean ‘SYS_sched_setaffinity’? [-Wimplicit-function-declaration]
 2343 |     if (sched_setaffinity(getpid(), len, &netperf_cpu_set)) {
      |         ^~~~~~~~~~~~~~~~~
      |         SYS_sched_setaffinity
make[3]: *** [Makefile:454: netlib.o] Error 1
make[3]: Leaving directory '/root/netperf-2.7.1/src'
make[2]: *** [Makefile:474: all-recursive] Error 1
make[2]: Leaving directory '/root/netperf-2.7.1/src'
make[1]: *** [Makefile:376: all-recursive] Error 1
make[1]: Leaving directory '/root/netperf-2.7.1'
make: *** [Makefile:315: all] Error 2
ild=x86_64

Hit this same issue

See https://github.com/skitt/netperf/commit/24e22b3bf4bd4da4ad07ef9288707823bd8712df for a glibc-specific fix for this.

#74 fixes this.


Checkbenchmark

Codecov Report

Merging #88 (9683496) into master (a5a9631) will increase coverage by 0.08%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   83.69%   83.77%   +0.08%
==========================================
  Files          10       10
  Lines         920      937      +17
==========================================
+ Hits          770      785      +15
- Misses        150      152       +2

Flag
Coverage Δ

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/JET.jl
49.55% <ø> (ø)

src/abstractinterpreterinterface.jl
91.30% <ø> (ø)

src/jetcache.jl
79.06% <81.25%> (-3.08%)
:arrow_down:

src/typeinfer.jl
98.33% <100.00%> (-1.67%)
:arrow_down:

src/reports.jl
87.78% <0.00%> (+0.39%)
:arrow_up:

src/print.jl
79.79% <0.00%> (+1.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a9631...9683496. Read the comment docs.

Codecov Report

Merging #88 (9683496) into master (a5a9631) will increase coverage by 0.08%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   83.69%   83.77%   +0.08%
==========================================
  Files          10       10
  Lines         920      937      +17
==========================================
+ Hits          770      785      +15
- Misses        150      152       +2

Flag
Coverage Δ

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/JET.jl
49.55% <ø> (ø)

src/abstractinterpreterinterface.jl
91.30% <ø> (ø)

src/jetcache.jl
79.06% <81.25%> (-3.08%)
:arrow_down:

src/typeinfer.jl
98.33% <100.00%> (-1.67%)
:arrow_down:

src/reports.jl
87.78% <0.00%> (+0.39%)
:arrow_up:

src/print.jl
79.79% <0.00%> (+1.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a9631...9683496. Read the comment docs.


Don't sync query changes for source nodes

The query is always fixed and set from editor, so no need to listen to changes from analysis nodes in cartodb.js. So, with this a layer with a source node (i.e. no analysis) should allow modifying the styles w/o risking the geometry to be unknown.
@xavijam please review
cc @AbelVM

Super important fix, thanks a lot man! 💋  🚢 :it:

Frontend test passing, so merging


[fix][test] Fix flaky test AdditionalServletsTest.testEmptyStringAsExtractionDirectory

Fixes #18587
Motivation
AdditionalServletsTest.testEmptyStringAsExtractionDirectory is flaky because it depends on NarClassLoader#DEFAULT_NAR_EXTRACTION_DIR being initialized after the test is begun.
Modifications
Remove the override of the tmp directory from the test.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

This change only modifies test code

Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[X] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/andrasbeni/pulsar/pull/8

Codecov Report

Merging #18607 (6e37bda) into master (598ca5d) will decrease coverage by 10.62%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #18607       +/-   ##
=============================================
- Coverage     47.72%   37.09%   -10.63%
+ Complexity     9330     1969     -7361
=============================================
  Files           618      209      -409
  Lines         58568    14420    -44148
  Branches       6093     1573     -4520
=============================================
- Hits          27951     5349    -22602
+ Misses        27589     8485    -19104
+ Partials       3028      586     -2442

Flag
Coverage Δ

unittests
37.09% <ø> (-10.63%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../org/apache/pulsar/client/impl/ConnectionPool.java
37.43% <0.00%> (-1.03%)
:arrow_down:

...a/org/apache/pulsar/client/impl/TableViewImpl.java
0.00% <0.00%> (ø)

...pache/pulsar/client/impl/TableViewBuilderImpl.java
0.00% <0.00%> (ø)

...pache/pulsar/broker/admin/v2/PersistentTopics.java

...org/apache/pulsar/broker/service/Subscription.java

.../broker/intercept/BrokerInterceptorDefinition.java

...rg/apache/pulsar/broker/web/PulsarWebResource.java

...ava/org/apache/pulsar/broker/stats/TimeWindow.java

...g/apache/pulsar/broker/service/StreamingStats.java

...g/TopicCountEquallyDivideBundleSplitAlgorithm.java

... and 408 more


(#373) Fix pi = 4 in amd64 assembly-gen

Clean out rax before doing the comparison to sweep out the upper
bits as only the lower 16 bits get set (Thanks to abridgewater)
Fix cleaning xmm0 (Thanks to kolumbetko)

if you want to save 1 byte for each xor, you can use xor eax, eax as well :D

if you want to save 1 byte for each xor, you can use xor eax, eax as well :D

<insert rant on x86/>
but then I'd go through the entire generator and change rax to eax to make it consistent. I guess that is another issue.

it's fine to leave it like this, more consistent anyway.

@herrhotzenplotz @kolumb @abridgewater looks goode to me! :+1: Thank you for your contribution!


Support searching across catalog for glossary terms in asset name

Enabling a rough "discovery" of possible candidates for assets that need to be tagged with a glossary term.
Should be possible through the advanced search and parsing through the glossary terms.

Get all glossary terms
Possibly "massage" those terms into different shapes (abbreviations, substr)
Wildcard query against all assets
List out any possible matches for people to review
Phase two would be to assign the AtlasGlossaryTerm relationship to the asset from some intermediate file that was written out to beforehand.

Closed by #56 but the user must modify the business logic to massage the terms as Atlas / Purview search does not provide much in the ways of semantic searching.


jaeger-agent is always pending when the native pod has pod-AntiAffinity set and there is only one worker node

jaeger-agent is always pending when the native pod has pod-AntiAffinity set and there is only one worker node
To Reproduce
Steps to reproduce the behavior:
env:
K8S cluster with only one worker node;
One app pod with both pod-AntiAffinity and annotations of ' sidecar.jaegertracing.io/inject: "true"'
1. kubectl apply -f app.yaml
2.pod of app enters "Running" state,but the new pod containing the jaeger-agent container can only be in "Pending" state
3.execute cmd: kubectl get pods

4.execute cmd: kubectl describe pod app:

Expected behavior
The new pod containing the jaeger-agent container should enter Running state and replace the native pod successfully.
Version (please complete the following information):

OS: [Linux version 4.15.0-151-generic (buildd@lgw01-amd64-042) (gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04)) # 157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021]
Jaeger version: [1.18.0]
Deployment: [Kubernetes]

root@jax:/# kubectl get pod jaeger-operator-f4fdd4b7b-cw24v -n observability -o yaml
apiVersion: v1
kind: Pod
metadata:
  annotations:
    cni.projectcalico.org/podIP: <IP_ADDRESS>/32
    cni.projectcalico.org/podIPs: <IP_ADDRESS>/32
  creationTimestamp: "2021-08-02T06:27:01Z"
  generateName: jaeger-operator-f4fdd4b7b-
  labels:
    name: jaeger-operator
    pod-template-hash: f4fdd4b7b
  managedFields:
  - apiVersion: v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:generateName: {}
        f:labels:
          .: {}
          f:name: {}
          f:pod-template-hash: {}
        f:ownerReferences:
          .: {}
          k:{"uid":"93f046ff-e8a1-449b-9a5c-e160c82de891"}:
            .: {}
            f:apiVersion: {}
            f:blockOwnerDeletion: {}
            f:controller: {}
            f:kind: {}
            f:name: {}
            f:uid: {}
      f:spec:
        f:containers:
          k:{"name":"jaeger-operator"}:
            .: {}
            f:args: {}
            f:env:
              .: {}
              k:{"name":"OPERATOR_NAME"}:
                .: {}
                f:name: {}
                f:value: {}
              k:{"name":"POD_NAME"}:
                .: {}
                f:name: {}
                f:valueFrom:
                  .: {}
                  f:fieldRef:
                    .: {}
                    f:apiVersion: {}
                    f:fieldPath: {}
              k:{"name":"POD_NAMESPACE"}:
                .: {}
                f:name: {}
                f:valueFrom:
                  .: {}
                  f:fieldRef:
                    .: {}
                    f:apiVersion: {}
                    f:fieldPath: {}
              k:{"name":"WATCH_NAMESPACE"}:
                .: {}
                f:name: {}
            f:image: {}
            f:imagePullPolicy: {}
            f:name: {}
            f:ports:
              .: {}
              k:{"containerPort":8383,"protocol":"TCP"}:
                .: {}
                f:containerPort: {}
                f:name: {}
                f:protocol: {}
            f:resources: {}
            f:terminationMessagePath: {}
            f:terminationMessagePolicy: {}
        f:dnsPolicy: {}
        f:enableServiceLinks: {}
        f:restartPolicy: {}
        f:schedulerName: {}
        f:securityContext: {}
        f:serviceAccount: {}
        f:serviceAccountName: {}
        f:terminationGracePeriodSeconds: {}
    manager: kube-controller-manager
    operation: Update
    time: "2021-08-02T06:27:01Z"
  - apiVersion: v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .: {}
          f:cni.projectcalico.org/podIP: {}
          f:cni.projectcalico.org/podIPs: {}
    manager: calico
    operation: Update
    time: "2021-08-02T06:27:09Z"
  - apiVersion: v1
    fieldsType: FieldsV1
    fieldsV1:
      f:status:
        f:conditions:
          k:{"type":"ContainersReady"}:
            .: {}
            f:lastProbeTime: {}
            f:lastTransitionTime: {}
            f:status: {}
            f:type: {}
          k:{"type":"Initialized"}:
            .: {}
            f:lastProbeTime: {}
            f:lastTransitionTime: {}
            f:status: {}
            f:type: {}
          k:{"type":"Ready"}:
            .: {}
            f:lastProbeTime: {}
            f:lastTransitionTime: {}
            f:status: {}
            f:type: {}
        f:containerStatuses: {}
        f:hostIP: {}
        f:phase: {}
        f:podIP: {}
        f:podIPs:
          .: {}
          k:{"ip":"<IP_ADDRESS>"}:
            .: {}
            f:ip: {}
        f:startTime: {}
    manager: kubelet
    operation: Update
    time: "2021-08-02T06:27:19Z"
  name: jaeger-operator-f4fdd4b7b-cw24v
  namespace: observability
  ownerReferences:
  - apiVersion: apps/v1
    blockOwnerDeletion: true
    controller: true
    kind: ReplicaSet
    name: jaeger-operator-f4fdd4b7b
    uid: 93f046ff-e8a1-449b-9a5c-e160c82de891
  resourceVersion: "23708153"
  selfLink: /api/v1/namespaces/observability/pods/jaeger-operator-f4fdd4b7b-cw24v
  uid: ec2e80cf-380f-43fc-9eed-de95c2c9caee
spec:
  containers:
  - args:
    - start
    env:
    - name: WATCH_NAMESPACE
    - name: POD_NAME
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: metadata.name
    - name: POD_NAMESPACE
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: metadata.namespace
    - name: OPERATOR_NAME
      value: jaeger-operator
    image: jaegertracing/jaeger-operator:1.18.0
    imagePullPolicy: Always
    name: jaeger-operator
    ports:
    - containerPort: 8383
      name: metrics
      protocol: TCP
    resources: {}
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: jaeger-operator-token-f2xn7
      readOnly: true
  dnsPolicy: ClusterFirst
  enableServiceLinks: true
  nodeName: jax
  preemptionPolicy: PreemptLowerPriority
  priority: 0
  restartPolicy: Always
  schedulerName: default-scheduler
  securityContext: {}
  serviceAccount: jaeger-operator
  serviceAccountName: jaeger-operator
  terminationGracePeriodSeconds: 30
  tolerations:
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
    tolerationSeconds: 300
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
    tolerationSeconds: 300
  volumes:
  - name: jaeger-operator-token-f2xn7
    secret:
      defaultMode: 420
      secretName: jaeger-operator-token-f2xn7
status:
  conditions:
  - lastProbeTime: null
    lastTransitionTime: "2021-08-02T06:27:02Z"
    status: "True"
    type: Initialized
  - lastProbeTime: null
    lastTransitionTime: "2021-08-02T06:27:19Z"
    status: "True"
    type: Ready
  - lastProbeTime: null
    lastTransitionTime: "2021-08-02T06:27:19Z"
    status: "True"
    type: ContainersReady
  - lastProbeTime: null
    lastTransitionTime: "2021-08-02T06:27:01Z"
    status: "True"
    type: PodScheduled
  containerStatuses:
  - containerID: docker://14014090824bf3bd56d28afa7dbbdad2e0c5a3a44a532a9796df0fb33019ecc0
    image: **_jaegertracing/jaeger-operator:1.18.0_**
    imageID: docker-pullable://jaegertracing/jaeger-operator@sha256:c9c4556f0c1a46c1a75b7270d3fba83b70820ce516b408c4917bbf2f3b849667
    lastState: {}
    name: jaeger-operator
    ready: true
    restartCount: 0
    started: true
    state:
      running:
        startedAt: "2021-08-02T06:27:18Z"
  hostIP: <IP_ADDRESS>
  phase: Running
  podIP: <IP_ADDRESS>
  podIPs:
  - ip: <IP_ADDRESS>
  qosClass: BestEffort
  startTime: "2021-08-02T06:27:02Z"

Additional context
Can this issue be fixed by updating jaeger version,if so,pelase recommend a version, thank you！

Unfortunately, this is due to how we inject sidecars in this version of the Jaeger Operator. I cannot think of a good solution to this other than manually killing the pod that is in running state.

In time, this will be fixed by v2, once the sidecar injection happens via admission webhooks.

In time, this will be fixed by v2, once the sidecar injection happens via admission webhooks.

Okay, thanks, so when is the release of v2 version?

No ETA at the moment, we depend on many things, like OpenTelemetry Collector reaching v1 and Jaeger itself reaching v2. I hope to have an Operator v2 close to the time we release Jaeger v2, though.


Serializing Lucid Models

Hello 👋
Thank you for all the work you've invested in putting this together. I have a question that perhaps isn't ultimately specific to the Adonis+Remix combo (moreso for lucid + client-rendered framework), but certainly rears it's head prominently once you get into returning models from loaders. I hope by posting it here other folks who run into the same thing might find the discussion useful.
Lucid models aren't type-safe. In practice, what this means is that when you query for a model in lucid and return it from a loader, remix picks up the type that lucid defines as a model's toJSON() method (which is just ModelObject, aka { [key: string]: any }):
// post_service.ts
class PostService {
  // typescript infers this as `(id: number) => Promise<Post>`
  async get(id: number) {
    return Post.getOrFail(id)
  }
}

// (some remix route)
export async function loader({ context, params }: LoaderFunctionArgs) {
  const postService = await context.make('post_service')

  return json({
    post: postService.get(Number(params.id))
  })
}

export default function PostShow() {
  // typescript infers this as `JsonifyObject<{ post: Post }>` which simplifies to `{ post: ModelObject }` due to lucid's typings
  const { post } = useLoaderData<typeof loader>()

  // ..
}

It may be tempting to just type-cast the useLoaderData hook return value as { post: Post }:
const { post } = useLoaderData() as { post: Post }

But that's not a great idea for a few reasons:

typescript won't be able to catch problems if we change what gets returned from the loader, since we're overriding the type
an instance of the Post model class has methods on it that the serialized data will not have
it's cumbersome and duplicative to write these types out every time
the type may not include additional relations or extra fields we've added from the lucid query
non-serializable fields like Date/DateTime/Regex/BigInt, etc. won't have the correct type (since they will have been JSON.stringified)

It seems sensible then to have some serialization logic somewhere that turns the result of a particular lucid query into a proper plain object. In that case, where's the best place to put that logic?
We could treat the service layer as a boundary, encapsulating the concern of using the ORM and then serializing the resulting data into plain objects. However, it may be beneficial to allow adonis service methods to return proper model class instances which callers can then operate on (in other adonis code).
My current thought is to manually handle serialization at the network boundary (i.e. in the loader, before returning the data). It's tricky to do right though since a service method that returns a Post may have preloaded certain associations or have annotated the resulting rows with additional properties (i.e. $extras) - i.e. any of the things lucid allows you to do when querying (which are mostly things that knex allows you to do).
As the author of this remix-adonisjs, I'm curious to get your thoughts on the matter.
Cheers 👋

This is an interesting problem that I have encountered myself when building.
I ususally peek at the work done in the AdonisJS Inertia implementation to see how they handle these cases, and I see that they suggest casting the model to a simple object or adding DTO classes: https://docs.adonisjs.com/guides/views-and-templates/inertia#model-serialization
I personally create inlined DTOs where I extract the fields I need like this:
json({
  title: post.title,
  description: post.description,
})

A more elegant solution would be nice for this. Maybe it could be possible to augment the types for the Remix json method  to give better typing with something like this that infers the model fields:
type ExtractModelFields<T> = {
  [K in keyof T as T[K] extends Function ? never : K extends `$${string}` ? never : K]: T[K]
}

It doesn't handle relationships. but might be a start :)

Oh yeah the inertia serialization docs are informative. Between casting the model.serialize() and explicit DTO modeling I think I lean toward the more explicit pattern.
Manually serializing the objects on a per-case basis in loaders is clean and simple, but doesn't scale that well if you have many loaders and you're doing the same serialization over and over.
Depending on the use case I can see there being many different ways you might end up serializing a model so I shy away from the idea of a generalized type that extracts the model attributes. I also think it might be tricky to augment the types since json(..) makes use of Jsonify<T> under the hood and that pulls a type from an objects toJSON() method if it's present. It's certainly possible to monkey-patch something in there but it's not without some risk.
I ended up just defining presenters for each model+use case combination. What I don't like about it is that you still are in a situation where you need to know that PostWithAuthorDTO has to be used to serialize the data from PostService.getWithAuthor(..) (i.e. there's a coupling between the specific DTO and the service methods that I don't want to enforce in the service layer (again I think it's useful to just return real lucid model objects there for use in other parts of the adonis codebase).
I'll keep working with it and if I come up with something I really like I'm happy to share it back here.
Thank you for sharing your thoughts!


Mutation event not published when observing for changes to datastore

Describe the bug
i try to observe for changes using the DataStore.publisher. New items are created via appsync console but the events are not published.
To Reproduce
Steps to reproduce the behavior:

i'm using the snippet from the amplify ios docs

let postSubscription = Amplify
    .DataStore
    .publisher(for: Post.self)
    .sink(receiveCompletion: { completion in
        if case .failure(let err) = completion {
            print("Subscription received error - \(err.localizedDescription)")
        }
    }) {
        print("Subscription received mutation: \($0)")
}

i create a new Post from the appsync console.
i'm monitoring the datastore sqlite table and can see my new post in the table.
the receiveValue closure is never called

Expected behavior
receiveValue closure should be triggered for every mutation
Screenshots
If applicable, add screenshots to help explain your problem.
Environment(please complete the following information):

Amplify Framework Version: [e.g. 0.10.0]
Dependency Manager: [e.g. Cocoapods, Carthage]
Swift Version : [e.g. 5.0]

Device Information (please complete the following information):

Device: iphone 11 prox max simulator
iOS Version: ios 13.1

Thank you for reporting this and taking a look at Amplify while we are still in preview mode.  I've submitted a PR and pushed the following PR, which should address this:
https://github.com/aws-amplify/amplify-ios/pull/308
I will be closing this issue, but feel free to re-open if you have any further issues with this.

By the way, if your variable postSubscription goes out of context, the callbacks for both receiveCompletion: and receive: will not get called.  So you may want to have some code that looks something like this:
class ViewController {
    var postSubscription: AnyCancellable?
    ...
    func setupSubscription {
        postSubscription = Amplify
            .DataStore
            .publisher(for: Post.self)
            .sink(....)
        .......
    }
}


Improve serialization format of quickwit.json file

Description
Improve serialization format of quickwit.json file. Fixes #266.
{
  "index": {},
  "splits": [{}, {}],
  "version": 0
}

How was this PR tested?

Added backward-compatibility tests
Ran make test-all command

You didn't change META_FILENAME into metastore.json?

I don't think we need to support the V0 format (we have only users with the PostgreSQL metastore).

V0 is the new format.

V0 is the new format.

oh, I think I misunderstand something.
This code
impl From<Index> for IndexV0 {
    fn from(index: Index) -> Self {
        Self {
            index: index.metadata,
            splits: index
                .splits
                .into_values()
                .sorted_by_key(|split| split.update_timestamp)
                .collect(),
        }
    }
}

impl From<IndexV0> for Index {
    fn from(index: IndexV0) -> Self {
        Self {
            metadata: index.index,
            splits: index
                .splits
                .into_iter()
                .map(|split| (split.split_id().to_string(), split))
                .collect(),
            discarded: false,
        }
    }
}

made me think you needed to convert from IndexV0 to Index.
I don't really understand the discarded either. Well I will ping you tomorrow, I think I need an update on this.

Index is the in-memory format. VersionedIndex is a "serialization/deserialization" proxy. On the serialization path, we always choose the "highest" VersionedIndex variant. On the deserialization path, serde deserializes the right variant thanks to the version tag. Then, we tell serde how to perform the conversion from IndexVx to Index.

Index is the in-memory format. VersionedIndex is a "serialization/deserialization" proxy. On the serialization path, we always choose the "highest" VersionedIndex variant. On the deserialization path, serde deserializes the right variant thanks to the version tag. Then, we tell serde how to perform the conversion from IndexVx to Index.

ok, super clear, thanks.
Then this line index: index.metadata, is surprising.

@guilload  approved but had 2 comments!


Trigger manually sync/full sync

Prerequisites:

Is the functionality available in the GitHub UI? If so, please provide a link to information about the feature.

Is the functionality available through the GitHub API? If the functionality is available, please provide links to the
API documentation (https://developer.github.com/v3/) as well as the Octokit documentation (https://octokit.github.io/).

If the functionality is not yet available in the API, it would be helpful if you
contacted support (https://support.github.com/) or posted in the Community Forum (https://github.community/). Please
include a link to the forum post if you create one or a copy of the response from support.

New Feature
Imagine you have the situation where the safe-settings app did not configure a repository properly, because for whatever reason, e.g., webhook not send to the app, an application error, etc..
Wouldn't it be great if there would be at least the possibility to trigger manually a sync or full sync through a dedicated endpoint?

This was solved for lambda by exporting syncInstallation method in the index.js https://github.com/github/safe-settings/issues/313
Alternatively, we can create an HTTP endpoint in the app that would do the same.

@martinm82 I'm thinking I will try to set up a GitHub Actions workflow using cron + workflow dispatch (manual run) to call the lambda function.
I have just started using this app but find it hard to get feedback on what happened for the real run after PRs are merged to the main branch of the admin repo. It would be great to be able to re-run the changes on main and get feedback from the lambda back as a commit status. The dry run is enough for PRs but is not good enough for main IMHO.

As noted on #378, I have a prototype runner that I'm using for running safe-settings via GHA. If we like this approach of calling syncInstallation via a separate script, I can open a PR (was just delaying since I forked off my changes in #588)


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_d18mwqkk5v/clone/recipe/meta.yaml:28: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_d18mwqkk5v/clone/recipe/meta.yaml:33: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_d18mwqkk5v/clone/recipe/meta.yaml:68: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_d18mwqkk5v/clone/recipe/meta.yaml:68: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_d18mwqkk5v/clone/recipe/meta.yaml:68: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_d18mwqkk5v/clone/recipe/meta.yaml:68: missing_description: The recipe is missing a description
Errors were found


Removing Sticky removes the item

Is there a way I can remove Sticky and have it still display? It adds a display: none to my item. I want to have the animation happen in a specific area of my page.

Sounds good.
It couldn't now. but maybe I can update that feature easily.
I'm planning to update this repository soon.


Merge Protocol and ProtocolBehaviour

Merges Protocol and ProtocolBehaviour.
The Protocol struct now implements NetworkBehaviour.
The PR is ready, except for the fact that it totally breaks the network tests in an unrecoverable way.
Right now the network tests infrastructure assumes that we have a single channel of communication with the remote, and that Protocol exposes this in its API. This PR makes this an implementation detail of Protocol. Because of that, the tests, by design, can't be "just fixed".
I'm going to start working on rewriting the TestNet struct, after which we will be able to merge this PR on top. I'm opening it now, so that people are aware of upcoming changes.
Can be reviewed commit by commit.

@tomaka is this in draft? or ready for review?

It's ready for review! Just not for merging, as I want to submit another PR to merge first that rewrites the tests.

Ready to review/merge!


Language Not Switching From JavaScript to C#

The language choice is not respected for the code sample, it's stuck in JavaScript.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 12adc391-5fd6-1386-50aa-610f08acaca6
Version Independent ID: 8439f5a6-b263-eb22-b6b8-86c24ce285b6
Content: PointerDevice Class (Windows.Devices.Input) - UWP app developer
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.devices.input.pointerdevice.yml&version=GBlive&_a=contents
Service: unspecified
GitHub Login: @wdg-dev-content
Microsoft Alias: wdg-dev-content

Thanks for letting us know about this issue. I've updated the JS snippet and added C# and C++ versions.


Use thumb for dragmove

[x] use thumb for DragMove actions (makes it possible that animations not hangs)
[x] double click in thumb
[x] DragMove with UseNoneWindowStyle
[x] right click on thumb
[x] allow DragMove with open Flyouts
[x] some code cleanup after Flyout implementation
[x] test it with Avalon dock for @QuantumDeveloper
[x] hopefully not a breaking change :-D

thx @ButchersBoy for the code from Dragablz
Closes #1821 Move window when flyout is open
Closes #1635 Fylout window not draggable?
Closes #2036 Avalondock Anchorables could not be dragged inside MetroWindow
Closes #2122 Use behavior/attached property to control window dragging
Closes #1849 System menu present everywhere when fullscreen is toggled on

@thoemmi If you have some time... the Flyout stuff is implemented and testable...
/cc @hercmaroudas @QuantumDeveloper

@punker76 Here are my annotations:

I think the name windowRestoreThumb (and PART_WindowRestoreThumb) quite confusing. This isn't about restoring the window but moving it, is it?

Is the first condition in MetroWindow.DoWindowMoveThumbOnDragDelta correct? If window.IsWindowDraggable is false it should always return despite the properties of dragDeltaEventArgs.

The InvisibleThumbStyle style is declared twice, in MetroWindow.xaml and Flyout.xaml. Mabe you should move to a central place, so there's only one declaration.

@thoemmi

I think the name windowRestoreThumb (and PART_WindowRestoreThumb) quite confusing. This isn't about restoring the window but moving it, is it?

I was also rethinking about the name, maybe PART_WindowTitleThumb is better for this...

Is the first condition in MetroWindow.DoWindowMoveThumbOnDragDelta correct? If window.IsWindowDraggable is false it should always return despite the properties of dragDeltaEventArgs.

Yeah should be!

The InvisibleThumbStyle style is declared twice, in MetroWindow.xaml and Flyout.xaml. Mabe you should move to a central place, so there's only one declaration.

I'll do this.
thy @thoemmi

@thoemmi all annotations done

:+1: :shipit:

:sunglasses:

Found a bug with this on a 3 monitor setup; all of different resolutions and orientations...small PR incoming...

FYI, if ShowTitleBar="False", window dragging will not work, because window content  (MetroContentControl) overlays Title bar Thumb (PART_WindowTitleThumb). The problem is that the Grid row, where Thumb is placed, has Height=0 in this case, even if there are Minimize/Maximize/Close buttons visible. Thus, if ShowTitleBar="False", there is no way to move the window by dragging.


Improve speed of video streaming and sliding playbar

I use list to improve

I confirmed that error of playing end of the video was fixed


[MINOR] [CORE] Fixes minor variable name typo

Merged build triggered.

Merged build started.

Test build #42551 has started for   PR 8784 at commit e0b7105.

Test build #42551 has finished for   PR 8784 at commit e0b7105.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

LGTM.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42551/
Test PASSed.


If the API documentation has basic authorization

My API documentation on swagger has a basic authorization. Does Portman support it?
I know it is possible to send query parameters inside the link but I'm not sure whether its possible to send a basic authentication header.

HI @thim81
Thank you for your answer. I ended up making a node script that downloads file locally then sends to portman for processing and it works fine, thank you :)


A getting started guide with a diverse enough code example

(I just noticed there is no travis build for this PR?)

Land once green 👍


Prevent the code to fail when loading models without the "materials" property or having a mesh primitive without the material association

Fixes #3279

Couple of null checks in the model and primitive-node constructors
In space-opera, the material panel will shot "No materials" when the panel does not have any selectable materials found in the active model.

Thanks! I wonder if khronos_SimpleTriangle would work; it's a lot smaller and will load faster in the tests.

On the surface it would seems so, but khronos_SimpleTriangle generate a Default material in the correlatedSceneGraph object, which is not the case of the vase glb.

hmm, that's interesting. I thought we always generated a default material when none were specified. Can you take a look and let me know what the difference is? I'd like to make sure we're fixing this properly.

It does seems a bit fishy. I will check it out tomorrow morning no problem. Today is a bit busy on my end.

Looking at the associations in the gltf object generated from the ThreeGLTFParser, the triangle file has 2 associations (material and mesh) and the vase only has 1 (mesh). Looking at the code, the gltf.materials array and the default material is only added when there is a material in the associations.

What would you suggest we do with this?

Hmm, sounds like the bug might be in the GLTFLoader (since it's supposed to create a default material association, and apparently fails to). I think for now we should go ahead and create our default material also in the case there is no material association at all, for robustness. Separately, it'd be interesting to know why GLTFLoader has weird behavior here.

I wanted to get to this last week so it could be included in the next release, but I have been indisposed by Covid unfortunately.
Anyways, it seems like the associations entry to the DefaultMaterial is set in different places which explains the inconsistency. For the Triangle files it is done here, which is called when we load the meshes in the loader.
https://github.com/mrdoob/three.js/blob/8921bfaee413e809cb2d27f0aec917408d690a0f/examples/jsm/loaders/GLTFLoader.js#L3114
For the Vase(new file) it is done here, which is called when we load a material.
https://github.com/mrdoob/three.js/blob/8921bfaee413e809cb2d27f0aec917408d690a0f/examples/jsm/loaders/GLTFLoader.js#L3304
The problem that we have in model-viewer with this is that CorrelatedSceneGraph and PrimitiveNode objects are instantiated before loadMaterial is first called and this association is made in the Model constructor I believe.
I could probably address the issue by adding this block of code, which uses the parser's cached DefaultMaterial to setup the association.

The cache attribute is not public in the interface, so I am guessing this snippet is not exactly how we should use the library. I am not sure what direction you want to take with this? Perhaps this should be only fix/addressed three.js?

I wanted to get to this last week so it could be included in the next release, but I have been indisposed by Covid unfortunately.

No problem! Get well soon.

The cache attribute is not public in the interface, so I am guessing this snippet is not exactly how we should use the library. I am not sure what direction you want to take with this? Perhaps this should be only fix/addressed three.js?

Indeed, let's not mess with the internals of three.js. You make it sound like something is happening too soon? Might this just be a race condition of some kind on our side? Maybe we just haven't awaited the right thing.

Ping; did you ever find a deeper cause here? Would love to merge a fix for the root problem.

I haven't had much time to check this any further.
Off memory, I think it was basically that in this particular case three.js is only creating the associations for the default material once loadMaterial is being called which in model viewer happens after the constructors cited above. So the race condition assessment sounds about right, though I find it a bit weird as of why this association is done in different places in the three.js GTLFLoader's code to be honest.
I will try to make some time on Friday to try to find a good solution for this.

I'm still interested in what's going on here. Have you gotten stuck?

Sorry for the slow response (on vacation for the past few weeks).
I didn't put any time into this since March as my plate got really full, but I am interested in finding a good solution here. Let me put this back into my personal task board and come back to you with this.

It looks like this is actually a three.js bug that needs to be fixed upstream. Should we merge the rest of this PR?


Bypas Expo Orbit

Been stuck on this for a week now.

Is there an easy way to entirely disable TLS verification in the application (when possible) or to configure the application to reference a certificate chain that has the Netskope certificate included. I can't remove the Netskope security from the machine.
I tried NODE_TLS_REJECT_UNAUTHORIZED but it didn't work. So was hoping to get your advice.

It sounds like you might need to add Netskope's CA cert to Expo Orbit's trusted root certificates. But I don't know if that's possible, or if so, how.
If it was using node, you might be able to set this option:
https://nodejs.org/api/cli.html#cli_node_extra_ca_certs_file
But it looks like it uses Hermes instead of node.

Hi @ogrunebaumrbi, thanks for the report, do you know it there is a simple way to recreate this scenario (self-signed certificate in chain) in a local machine? I believe I have fix for this in #208 but I would like to confirm it before releasing a new version

@gabrieldonadel I think you'd need something that basically acts as a man-in-the-middle to intercept the connection and generate a certificate on the fly.
Or since you're not trying to actually intercept anyone's traffic, I would try this:

Generate a self-signed certificate with the appropriate CN and/or SANs and install it on any web server.
Then edit your /etc/hosts file to point the relevant names to this web server's IP address.


Feature/pagination

resolves #7

created pagination objects
created fetchPaginated method
added CakePHP Collections to Memoized Trait

Codecov Report

Merging #19 (93304c1) into main (e6c94bd) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   99.24%   99.37%   +0.12%
==========================================
  Files           9       11       +2
  Lines         133      160      +27
==========================================
+ Hits          132      159      +27
  Misses          1        1

Impacted Files
Coverage Δ

src/Core/MemoizedTrait.php
100.00% <100.00%> (ø)

src/Core/Pagination/PaginatedResult.php
100.00% <100.00%> (ø)

src/Core/Pagination/Pagination.php
100.00% <100.00%> (ø)

src/Core/Repository/RepositoryBase.php
100.00% <100.00%> (ø)


How to show different data in tableview controller of section 4

I learned how to dynamically create sections.
Now i am stuck at how to display different data in each section tableviewcontroller
For example I have 4 sections and each section contains a tableviewcontroller. Now i want to display different data in each of it.

You need to create a view for each section and attach view to section:
UIView *viewOfSection = [[UIView alloc] initWithFrame:CGRectMake(0, 0, self.view.frame.size.width, 100)];
//you can add any UI object in this view [viewOfSection addSubview:bla bla]
KMSection *section = [KMSection new];
section.view = viewOfSection;

@kelvinonik mind sharing how you dynamically create the sections??
Thank you


Join to awesome react state management team

https://github.com/olegrjumin/awesome-react-state-management
https://github.com/cs01/awesome-react-state-management-tools

Awesome React State Management (PR)

Two more resources to add:
https://github.com/brillout/awesome-react-components
https://github.com/enaqx/awesome-react


Breadcrumbs for page navigation

Hi, this an implementation of breadcrumbs. It allows to pass a custom breadcrumb for a page, or to use the already defined title.
Also added a basic README, with the steps I followed to run the project on my machine. Something basic, but it worked for me.

Thanks for the feedback! I tried to adjust the PR accordingly. Let me know what you think.

Hey @divagueame, sorry. Would you mind reopening this PR

I could not reopen, so just made it here:
https://github.com/marcoroth/hotwire.io/pull/46


CI: backport improvements to openssl-3.0 branch

This backports #18639 and #19450 to the openssl-3.0 branch.
If it's fine with you folks, I'd like to do the same to 1.1.1 too, as ultimately these compilers are being used by distros, so we want to know if something breaks.

This pull request is ready to merge

OK for 3.1 and 3.0. IMO we do not want this in 1.1.1. That branch is security-fix only and accommodating compiler changes there is outside of scope for it.

Thanks. On merge, could you handle doing 3.1 too please (as this PR is for 3.0)? I can make another PR if needed of course, but it should apply cleanly. Just let me know.

I'll attempt the merge now

It cherry-picked cleanly to 3.1

Merged
3.0:
e701d98618eb7ab08fe52621d65708d3fbaaac83 CI: add GCC 11
33da0e2b0d0be8566d939fd1a5b9d4e4455215d9 CI: Upgrade to Ubuntu 22.04 to add GCC 12, Clang 13, Clang 14
49c2c81d55dab8764c7575815e7566116d4f395a CI: add Clang 15
15d698d2f82dd7e42d412f7012a2dfeab28aa458 pem: fix -Wunused-but-set-variable
e8c8f6faeac54867793d1936a31eef7e644ed487 txt_db: fix -Wunused-but-set-variable
1b85fc806a7eeef14ee269761bf051c3abdca073 x509: fix -Wunused-but-set-variable
1cfc95b25c930df4de19c428a74d35f7a7411ab5 test: driver: fix -Wunused-but-set-variable
3.1:
259b9dd55ee6de8a9cd963a84f578734069c0b04 CI: add GCC 11
8024730835da13cb1c0fc3c5f8d650d02aa00939 CI: Upgrade to Ubuntu 22.04 to add GCC 12, Clang 13, Clang 14
1462e6f9a654e567ac24decf28d3c8bc26ae6a73 CI: add Clang 15
e556b05083f4a1d2734887c6d1add2f0256d46f3 pem: fix -Wunused-but-set-variable
6bfde830c860c21e6407d79ccbf1d39bcc268779 txt_db: fix -Wunused-but-set-variable
551aa3b6f96ff54ee5971e6e83b4e8ea59af7c81 x509: fix -Wunused-but-set-variable
49e5865692f23fddf07a7bfc6298818dbddcdbd2 test: driver: fix -Wunused-but-set-variable

Thanks!


keb runtimes endpoint

Description
Changes proposed in this pull request:

KEB runtimes endpoint returns a limited list of last non-dryrun upgrade kyma operations

Related issue(s)
Related: https://github.com/kyma-project/control-plane/issues/189

lgtm
please bump image version in values.yaml


complete rollout policy controller render

What type of PR is this?
/kind feature
What this PR does / why we need it:
Finished configuring kurator rollout for multiple clusters. Including create HPA for workload, create private testloader if needed and create canary of flagger.
Which issue(s) this PR fixes:
Fixes # #435

@LiZhenCheng9527 If you have addressed the comments or you think there are better options you can reply to them, so i can know all addressed


callback on memory store key expiration

Is there a way to run a callback function with the value of the key that is expiring from the memory store?  like an onExpired or something similar.

The dispose option might work (see https://github.com/isaacs/node-lru-cache#options).  Whatever you pass in to the memory store gets passed to the LruCache: https://github.com/BryanDonovan/node-cache-manager/blob/master/lib/stores/memory.js#L37

I don't think this can be implemented with all stores. For example, how would you do it with Redis? I don't think it's feasible.
@amit777 Can you give me an example of how to implement OnExpire in a Redis based store? If not I will have to close it.

Hi, thanks for looking into this. It's not very needed for me. But just as an FYI, Redis does seem to support key space notifications: https://medium.com/nerd-for-tech/redis-getting-notified-when-a-key-is-expired-or-changed-ca3e1f1c7f0a

But need to turn on the notifications feature in redis.
I can put an optional method in the Store. In the next version I will look at it in more detail.

The dispose option might work (see https://github.com/isaacs/node-lru-cache#options). Whatever you pass in to the memory store gets passed to the LruCache: https://github.com/BryanDonovan/node-cache-manager/blob/master/lib/stores/memory.js#L37

Hi @BryanDonovan ,
How do you suggest to pass this option?  The second link you add gives 404...
I tried:
aching({
  store: 'memory',
  max: 1000,
  ttl: 5 * 60 * 100,
  dispose: (token: Token, _key: string, _reason: string) => {
    logger.error('delete key is called');
    clearFromMem(token);
});

and it doesn't seems to work.
Thanks!

@bivas6 are you still having this issue?


build error with "bits/c++config.h" not found on "centos7 : gcc7.x(custom build)"

[my env on docker centos:7]
I was meet build issue at Centos7 (with docker)
in centos7 build with custom downloaded gcc
with cmd
RUN wget http://ftp.mirrorservice.org/sites/sourceware.org/pub/gcc/releases/gcc-7.5.0/gcc-7.5.0.tar.gz && tar -xzf  gcc-7.5.0.tar.gz
WORKDIR gcc-7.5.0
RUN ./contrib/download_prerequisites && ./configure  --prefix=/usr/local/gcc-7.5.0  --enable-checking=release  --enable-languages=c,c++ --disable-multilib && make -j12 && make install
RUN yum remove -y gcc

ENV GCC=/usr/local/gcc-7.5.0
ENV C_INCLUDE_PATH=$GCC/include/c++/7.5.0/
ENV CPLUS_INCLUDE_PATH=$GCC/include/c++/7.5.0/
ENV LD_LIBRARY_PATH=$GCC/lib64:$PPL/lib:$LD_LIBRARY_PATH
ENV PATH=$GCC/bin:$PATH
ENV CC=/usr/local/gcc-7.5.0/bin/gcc
ENV CXX=/usr/local/gcc-7.5.0/bin/g++

is just gcc c, c++ 7.x build and install
i was doing well...
after build gcc
i did built openssl 1.1.1q
wget --no-check-certificate https://www.openssl.org/source/openssl-1.1.1q.tar.gz && \
tar -xvzf ./openssl-1.1.1q.tar.gz && \
cd openssl-1.1.1q && \
./config no-shared -fPIC -O2 && \
make -j12 && sudo make install

in during build cmd
i got error
In file included from test/rsa_complex.c:17:0:
/usr/local/gcc-7.5.0/include/c++/7.5.0/complex.h:29:10: fatal error: bits/c++config.h: No such file or directory

i was tried build gcc  with --enable -multilib
ans when build conf openssl set -m64
If there is something strange, it is about uninstalling to delete the old version
I don't understand why this is happening
I want to have a completely static environment, so it is inconvenient to have to configure it myself
ext///
gcc -v output
# gcc -v test/rsa_complex.c
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/local/gcc-7.5.0/libexec/gcc/x86_64-pc-linux-gnu/7.5.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: ./configure --prefix=/usr/local/gcc-7.5.0 --enable-checking=release --enable-languages=c,c++ --disable-multilib
Thread model: posix
gcc version 7.5.0 (GCC)
COLLECT_GCC_OPTIONS='-v' '-mtune=generic' '-march=x86-64'
 /usr/local/gcc-7.5.0/libexec/gcc/x86_64-pc-linux-gnu/7.5.0/cc1 -quiet -v test/rsa_complex.c -quiet -dumpbase rsa_complex.c -mtune=generic -march=x86-64 -auxbase rsa_complex -version -o /tmp/ccloU22W.s
GNU C11 (GCC) version 7.5.0 (x86_64-pc-linux-gnu)
        compiled by GNU C version 7.5.0, GMP version 6.1.0, MPFR version 3.1.4, MPC version 1.0.3, isl version isl-0.16.1-GMP

GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072
ignoring nonexistent directory "/usr/local/gcc-7.5.0/lib/gcc/x86_64-pc-linux-gnu/7.5.0/../../../../x86_64-pc-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:
 /usr/local/gcc-7.5.0/include/c++/7.5.0/
 /usr/local/gcc-7.5.0/lib/gcc/x86_64-pc-linux-gnu/7.5.0/include
 /usr/local/include
 /usr/local/gcc-7.5.0/include
 /usr/local/gcc-7.5.0/lib/gcc/x86_64-pc-linux-gnu/7.5.0/include-fixed
 /usr/include
End of search list.
GNU C11 (GCC) version 7.5.0 (x86_64-pc-linux-gnu)
        compiled by GNU C version 7.5.0, GMP version 6.1.0, MPFR version 3.1.4, MPC version 1.0.3, isl version isl-0.16.1-GMP

GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072
Compiler executable checksum: 603929c6f011d7fc018cbe41e3a1c3b8
In file included from test/rsa_complex.c:17:0:
/usr/local/gcc-7.5.0/include/c++/7.5.0/complex.h:29:10: fatal error: bits/c++config.h: No such file or directory
 #include <bits/c++config.h>
          ^~~~~~~~~~~~~~~~~~
compilation terminated.

sorry to bother but I just encoutered the exactly same problem with my custom built gcc, no c++config.h presented. How did you solve it @whyjp


ones is not defined

Issue occurs on line https://github.com/bjbschmitt/AMFM_decompy/blob/da1751e87120b795c058b840df9e95949085c8f7/amfm_decompy/pYAAPT.py#L526
I think it needs to be np.ones ?
I got this as an error while going through an audio file.

I changed it on my local machine and then got this error.
/usr/local/lib/python2.7/dist-packages/AMFM_decompy-1.0.6-py2.7.egg/amfm_decompy/pYAAPT.pyc in spec_track(signal, pitch, parameters)
    524     else:
    525         if num_voiced_cand > 0:
--> 526             voiced_pitch = (np.ones(1, num_voiced_cand))*150.0
    527         else:
    528             voiced_pitch = [150.0]

/home/paritosh/Documents/Oratio/oratio-scripts/f0-python/numpy/core/numeric.pyc in ones(shape, dtype, order)
    190
    191     """
--> 192     a = empty(shape, dtype, order)
    193     multiarray.copyto(a, 1, casting='unsafe')
    194     return a

Hi, thanks for your report!
Yes, it has to be np.ones indeed. The second error is probably caused because the input for np.ones has to be a python tuple. Try changing line 526 to
voiced_pitch = (np.ones((1, num_voiced_cand)))*150.0
These two extra parentheses make the code uglier, but it may solve the problem.
Anyway, it seems that during my tests the if statement from line 525 was never accessed, so these two errors passed unnoticed. Could you please send me your problematic audio file, if possible? I want recreate the issue here just to check if these modifications are enough.

Ok, since that Paritosh didn't help us by sending a feedback after a week, I'll consider that this issue is fixed. The proposed alterations have been included to the code and the new version <IP_ADDRESS> has been updated here in github and in pypi.
I couldn't recreate the issue in my PC to check with 100% certain that the modifications are enough. But since that it's a simple problem, I believe that they will do the work.


Presence: Heartbeat

Draft PR to centralize presence-reporting code. Not yet suitable for merge due to, at a minimum, the reasons noted in the final commit.
This may not be the heartbeat pattern we actually want, but if not, it should be easy to replace.

Commenting to make it unambiguous that this is no longer a draft PR.
(The exact heartbeat pattern desired is still under discussion, but the structure introduced here isolates that, and should be separately reviewable.)

So I think this means that on going into the background, we should

not send any update about that; but
stop sending active updates, for as long as we're continuously in the background.

And when we come back to the foreground, if it's been over a minute, we should immediately send an active update.

I'm not entirely convinced that this is the right approach: it seems like the server could synthesize that from the more precise and accurate information stream (i.e., one with "idle" events) with very little overhead.
An implementing commit is nonetheless attached will follow nonetheless, once I have a sane test approach implemented. (And possibly once discussion settles down over on the Zulip channel, since I'm afraid I kicked it back up again.)

Not sure it simplifies things to pre-emptively take [the throttling] out of this layer as this separate commit, though.

It's one less thing in the HeartbeatComponent commit, at least. (I suppose it could be squashed into that one, but I'm not sure that would simplify things, either. ¯\_(ツ)_/¯)

it seems like the server could synthesize that from the more precise and accurate information stream (i.e., one with "idle" events) with very little overhead.

The thing is that "idle" doesn't mean "the user went away just now". Rather it means "hi, still here, but btw the user hasn't interacted with me (this client) recently."
... But really the better place for that design discussion is the chat thread; here we're in danger of overflowing what works well on a GitHub thread, as well as just getting mixed with the details of code. Want to follow up there?

Updated with new presence protocol, new tests, and a (hopefully very temporary) new dev-dependency.

BTW I also just added a link in the PR description to #3699, so that that thread gets an autolink back here. I was making a comment there, wanted to refer to this PR, and found I didn't have a reference to it :slightly_smiling_face:

The new version is rather larger, as it contains more tests than were originally thought viable... and this GitHub PR is already approaching the limit of usefulness. Closing, to be reopened with a fresh slate and a pointer.


eq 248 fix

Changes
fix for #248
How to test
Try to submit star wars and make sure the mandatory elements work correctly
Who can test
Anyone but @LJBabbage

LGTM - awaiting travis to merge 👍


[Feature] Add a colour changing loader

Description
This loader will show a new shiny colour while loading
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Hi,
I would like to be assigned to this issue. This contribution is for GSSoC'24

Hi,
I would like to work on this project. Please assign it to me. This contribution is for GSSoC'24.

Hi ,  Please assign this issue to me.

Go ahead @BagchiShreya


Sendgrid/Twilio SDK package not working in actions

Environment details:
I try to create actions with the package including of sendgrid and twilio, but it does not work.
The Response in OW Dashboard ist
Error: Cannot find module 'twilio'
Error: Cannot find module 'sendgrid'
The PR #829 and #774 are already closed and the OW Doc was updated, but it doesnt affect the package including.

@saschoff91 I think you were using the deployment on bluemix which might lag a bit behind the master branch. Try again?

This should now be addressed in bluemix as well.


changes to make 8.4 replication work using different setting names

MySQL 8.4 makes many changes:

removal of references to master/slave
this affects: command names, variables, configuration settings

This PR is intended to try to handle the changes necessary so dbdeployer will work on 8.4 in addition to previous versions.
Currently WIP.

closing this for now as superseded by https://github.com/sjmudd/dbdeployer/pull/4


Google redirect_uri seems wrong

Works locally, deployed to AWS. When I do Google OAuth, I get this error:
You can't sign in to this app because it doesn't comply with Google's OAuth 2.0 policy.

If you're the app developer, register the redirect URI in the Google Cloud Console.
Request details: redirect_uri=https://657bv2gcb7.execute-api.ap-southeast-2.amazonaws.com/auth/google flowName=GeneralOAuthFlow

Note the end ... /auth/google flowName=GeneralOAuthFlow
Any idea why this would be appended? It it somewhere in this library?

Works for me when deployed to https://draw.nuxt.dev in production 🤔

I will try some other providers and see if I can reproduce. So far, I only tried Google. I am only having this issue on AWS (lambda + s3 hosting). I will try to narrow it down.

GitHub auth seems to work fine with the correct redirect. I will continue investigating. I suspect there is no bug in the library, but some kind of environment related issue.

I ended up changing my stack, I need streaming but I cannot get the lambda_aws_streaming preset to work for Nitro. I still had some issues with the redirect behind my reverse proxy (nginx) where I get a http redirect instead of https.
I ended up just monkey-patching it https://github.com/lmiller1990/studyhq/blob/main/patches/nuxt-auth-utils%2B0.0.25.patch
What is the issue you are running into? Can you share?


Track channel state

We need to track channel state, including data from our peers, in order to enforce signing policy for Lightning channels.

Duplicate of https://github.com/NYDIG-OSS/lndsigner/issues/16


Reduce size of aes_mix_columns.sv from 25307 to 9939 lines

Part of addressing #577
The fix is simple: find places where an indexing expression would get copied, and pin it to a name with the use of localSignal, which should have identity function semantics for the proofs (in the ident monad).
@blaxill ~ please can you continue in other PRs to track down other places where duplication is occurring? I can tell from the generated SystemVerilog that we are duplicating vector literals, and in any case even though the size of generated file has been more than halved, I still feel it should be a lot shorter than 9939 lines.
CC: @jadephilipoom ~ it might be worth adding a bit of proof automation for localSignal?
I am thinking of changing indexAt and indexConst to be circuits, which would then not require localSignal (see #575 )

Since localSignal is just an identity, we could add it to the cbn list in the simpl_ident tactic, which will just inline it. Since simpl_ident is used in most proofs, I think this would end up requiring very little change to proofs.

I'm keen to fix this in the primitives as described in #575

Perhaps (un)peel should also be circuits? If localSignal is always wanted after peel/unpeel.

Yes, I wondered about that too.

Another thing I did here was to rename a few signals to prevent name reuse e.g.
Chaging:
  x <- wombat x ;;

to:
  x' <- wombat x ;;

I propose that we never "reuse" names.


../../.pub-cache/hosted/pub.dev/intl-0.17.0/lib/intl_browser.dart:12:8: Error: Dart library 'dart:html' is not available on this platform

i updated the package to 0.17.0 before it was running perfect
after updating i am not able to run app. on IOS
this is the error i am getting.
Error (Xcode): ../../.pub-cache/hosted/pub.dev/intl-0.17.0/lib/intl_browser.dart:12:8: Error: Dart library 'dart:html' is not available on this platform.
Could not build the application for the simulator.
Error launching application on iPhone 14 Pro Max.

Hi, are you trying to use dart:html in a native setting? Maybe initializeDateFormatting is the culprit here, please make sure to import from the right file (probably date_symbol_data_local.dart in your case, not date_symbol_data_http_request.dart).


chore: repoint gql queries

Description
curriculumUnits.gql v3
lessonDownloads.gql  v6
lessonDownloadsCanonical.gql v6
lessonListing.gql v15
lessonOverview.gql v10
lessonOverviewCanoncical.gql v10
Issue(s)
Fixes #
How to test

Go to https://deploy-preview-1961--oak-web-application.netlify.thenational.academy
Click on _______
You should see _______

Screenshots
How it used to look (delete if n/a):
{screenshots}
How it should now look:
{screenshots}
Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner

:tada: This PR is included in version 1.263.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: