[BUG] - conditional not working properly

Describe the bug
I set RSI, MFI, STOCHRSI
I set conditionals
I get those results for example 10 mins ago
APPC/BTC -  - [{'mfi': '84.33'}] -  -
STEEM/BTC -  - [{'mfi': '84.60'}] -  -
VIA/BTC -  - [{'mfi': '92.34'}] -  -
To Reproduce
Installation is ok. Just not getting accurate values for STOCHRSI and conditionals not working properly
Expected behavior
Conditionals to work, and stochrsi to let us give the 4 values like in TV and have accuracy
config.yml

settings:
  log_level: INFO
  update_interval: 3600
  timezone: Europe/Paris
  market_pairs:
    - THETA/BTC
    - UTK/USDT
    - VIA/BTC
    - POWR/BTC
    - NXS/BTC
    - NAV/BTC
    - STEEM/BTC
    - VIB/BTC
    - BCPT/BTC
    - DGB/BTC
    - APPC/BTC
    - SNX/USDT
    - KNC/USDT
    - ICX/USDT
    - HBAR/USDT

exchanges:
  binance:
    required:
      enabled: true

notifiers:
    telegram:
        required:
            token: xxxxx
            chat_id: yyyyyy
        optional:
            parse_mode: html
            template: "{{market}} - {{indicator_label}} - {{values}} - {{hot_cold_label}} - {{conditionals}} "

indicators:
    rsi:
        - enabled: true
          alert_enabled: true
          alert_frequency: always
          signal:
            - rsi
          hot: 40
          cold: 75
          hot_label: 'GOOD buy (below 40)'
          cold_label: 'GOOD sell (above 75)'
          indicator_label: 'RSI Daily'
          candle_period: 1d
          period_count: 14
          mute_cold: false
    mfi:
        - enabled: true
          alert_enabled: true
          alert_frequency: always
          signal:
            - mfi
          hot: 25
          cold: 75
          hot_label: 'GOOD buy (below 25)'
          cold_label: 'GOOD sell (above 75)'
          indicator_label: 'MFI Daily'
          candle_period: 1d
          period_count: 12
          mute_cold: false

    stoch_rsi:
        - enabled: true
          alert_enabled: true
          alert_frequency: once
          signal:
            - stoch_rsi
            - slow_k
            - slow_d
          hot: 25
          cold: 80
          hot_label: 'GOOD buy !'
          cold_label: 'GOOD sell !'
          indicator_label: 'STOCH Daily'
          candle_period: 1d
          period_count: 12
          mute_cold: false

    macd:
        - enabled: false
    momentum:
        - enabled: false
    obv:
        - enabled: false
    ichimoku:
        - enabled: false
    iiv:
        - enabled: false

informants:
    lrsi:
        - enabled: false
    vwap:
        - enabled: false
    sma:
        - enabled: false
    ema:
        - enabled: false
    bollinger_bands:
        - enabled: false

conditionals:
  - label: "2 CHECKMARKS for a GOOD sell (RSI/MFI)"
    cold:
      - rsi: 0
    cold:
      - mfi: 0

Desktop

OS name and version
ubuntu 16.04
crypto-signal branch
yours
Docker version
don't know

Additional context
none

You were asking what is my config, the one not working for conditionals, and you have it above ;)
It was giving me false positives ;) like PCR tests ;)
cheeers

Hello @bluetyphoon77 ,
Here is the good config.yml to receive a notification if rsi and mfi is cold:
settings:
  log_level: INFO
  update_interval: 3600
  timezone: Europe/Paris
  market_pairs:
    - THETA/BTC
    - UTK/USDT
    - VIA/BTC
    - POWR/BTC
    - NXS/BTC
    - NAV/BTC
    - STEEM/BTC
    - VIB/BTC
    - BCPT/BTC
    - DGB/BTC
    - APPC/BTC
    - SNX/USDT
    - KNC/USDT
    - ICX/USDT
    - HBAR/USDT

exchanges:
  binance:
    required:
      enabled: true

indicators:
    rsi:
        - enabled: true
          alert_enabled: true
          alert_frequency: always
          signal:
            - rsi
          hot: 40
          cold: 75
          hot_label: 'GOOD buy (below 40)'
          cold_label: 'GOOD sell (above 75)'
          indicator_label: 'RSI Daily'
          candle_period: 1d
          period_count: 14
          mute_cold: false
    mfi:
        - enabled: true
          alert_enabled: true
          alert_frequency: always
          signal:
            - mfi
          hot: 25
          cold: 75
          hot_label: 'GOOD buy (below 25)'
          cold_label: 'GOOD sell (above 75)'
          indicator_label: 'MFI Daily'
          candle_period: 1d
          period_count: 12
          mute_cold: false

    stoch_rsi:
        - enabled: true
          alert_enabled: true
          alert_frequency: once
          signal:
            - stoch_rsi
            - slow_k
            - slow_d
          hot: 25
          cold: 80
          hot_label: 'GOOD buy !'
          cold_label: 'GOOD sell !'
          indicator_label: 'STOCH Daily'
          candle_period: 1d
          period_count: 12
          mute_cold: false

    macd:
        - enabled: false
    momentum:
        - enabled: false
    obv:
        - enabled: false
    ichimoku:
        - enabled: false
    iiv:
        - enabled: false

informants:
    lrsi:
        - enabled: false
    vwap:
        - enabled: false
    sma:
        - enabled: false
    ema:
        - enabled: false
    bollinger_bands:
        - enabled: false

conditionals:
  - label: "2 CHECKMARKS for a GOOD sell (RSI/MFI)"
    cold:
      - rsi: 0
      - mfi: 0

notifiers:
    telegram:
        required:
            token: AAAA
            chat_id: AAAA
        optional:
            parse_mode: html
            template: "[{{market}}] {{indicator}} {{status}} {{values}} {{ '\n' -}}"

I've tested out and it's working. For example, I received this notification:
[DOGE/EUR] ['mfi', 'rsi'] 2 CHECKMARKS for a GOOD sell (RSI/MFI) [{'mfi': '88.57'}, {'rsi': '77.25'}]
Beginning analysis of DOGE/EUR
DOGE/EUR:

indicators:	mfi #0: 88.57359392 	rsi #0: 77.24757165 	stoch_rsi #0:<PHONE_NUMBER>0/100.00000000/100.00000000
informants:	ohlcv #0: 0.00373660
crossovers:

I've used my personal settings and exchanges for the test but with yours it should work.

ok thanks I will test it again and come back to you

Like I said it is not working.
I used these settings, like above
settings:
log_level: INFO
update_interval: 3600
start_worker_interval: 2
market_data_chunk_size: 1
timezone: Europe/Paris
market_pairs:
- THETA/BTC
- UTK/USDT
- VIA/BTC
- POWR/BTC
- NXS/BTC
- NAV/BTC
- STEEM/BTC
- VIB/BTC
- BCPT/BTC
- DGB/BTC
- APPC/BTC
- SNX/USDT
- KNC/USDT
- ICX/USDT
- HBAR/USDT
exchanges:
binance:
required:
enabled: true
bittrex:
required:
enabled: false
huobipro:
required:
enabled: false
hitbtc:
required:
enabled: false
notifiers:
telegram:
required:
token: AAA
chat_id: BBB
optional:
parse_mode: html
template: "[{{market}}] {{indicator}} {{status}} {{values}} {{ '\n' -}}"
indicators:
rsi:
- enabled: true
alert_enabled: true
alert_frequency: always
signal:
- rsi
hot: 40
cold: 75
hot_label: 'GOOD buy !'
cold_label: 'GOOD sell !'
indicator_label: 'RSI Daily'
candle_period: 1d
period_count: 14
mute_hot: true
mfi:
    - enabled: true
      alert_enabled: true
      alert_frequency: always
      signal:
        - mfi
      hot: 25
      cold: 75
      hot_label: 'GOOD buy !'
      cold_label: 'GOOD sell !'
      indicator_label: 'MFI Daily'
      candle_period: 1d
      period_count: 12
      mute_hot: true

stoch_rsi:
    - enabled: false
macd:
    - enabled: false
momentum:
    - enabled: false
obv:
    - enabled: false
ichimoku:
    - enabled: false
iiv:
    - enabled: false

informants:
ohlcv:
- enabled: false
lrsi:
- enabled: false
vwap:
- enabled: false
sma:
- enabled: false
ema:
- enabled: false
bollinger_bands:
- enabled: false
conditionals:

label: "2 CHECKMARKS for a GOOD sell (RSI/MFI)"
cold:

rsi: 0
cold:
mfi: 0

And I get for example this in telegram
[NAV/BTC] ['mfi'] 2 CHECKMARKS for a GOOD sell (RSI/MFI) [{'mfi': '81.24'}]
In command line the values are
Worker-3 sleeping for 3600 seconds
enabled notifers: ['telegram']
Starting Worker-4
Starting default analyzer...
Using the following exchange(s): ['binance']
Getting data for ['NAV/BTC']
Beginning analysis of binance
Beginning analysis of NAV/BTC
NAV/BTC:
indicators:     mfi #0: 81.23759467     rsi #0: 43.49286623
informants:
crossovers:
SO, I'm not supposed to get the notification since RSI is here 43 !!
In my settings it is set to .... as you can see
So there is a bug like I said before ....

In your config.yml set conditionals like below:
conditionals:
  - label: "2 CHECKMARKS for a GOOD sell (RSI/MFI)"
    cold:
      - rsi: 0
      - mfi: 0

Great job ! :)


[Swift 4.0] Reflect changes to the integer types

Cherry-picked: https://github.com/apple/swift-package-manager/pull/1289 to unblock CI.

@swift-ci please test

Merged to unblock CI @moiseev @aciidb0mb3r


Book Of Book Empty Crash[bug]

Mod Version (e.g. Fabric 0.3.4): 1.1.4. 1.20.4
What you expect to happen: Nothing
A brief description of what you think should happen.
What actually happens: The game crashes when using the Book Of Book scroll feature with no spells inside of it.
Step 1: Have a Book Of Book with no spells
Step 2: Shift + Scroll with BoB in hand.

Thank you for reporting. This has been fixed, the fix should be available in the next update.


Fieldtype data lost in extractText in 4.x site

Bug Description
I'm using Distill in a search transformer for a bard field within a Statamic 4 site. The field has several sets (e. g. accordions, images with description etc.) and is plugged into Distill as described in the readme:
public function handle($value, $field, $searchable)
{
      return Distill::text($searchable->augmentedValue($field));
}

Unfortunately, this always results in an error "Call to a member function handle() on null", pointing to the extractText method (link to code). In L103 all items are mapped into the augmentedValue function which leads to loosing the fieldtype data that is required in L104 ($value->fieldtype()->handle()), leading to the error.
It looks like the changes introduced in 0.6.4 cause the error. When changing the first map (L103) back to ->map->value (as it was before), the error disappears and the search transformer gets the correct data. Haven't looked into this more throughly, maybe the 0.6.4 changes are simply incompatible with v4.
I'd probably be fine with simply fixing 0.6.3 for now until the site is updated to v5. However, if it really would be an incompatibility issue, the composer.json should be adjusted, I suppose.
How to Reproduce
v4 site, bard field with sets (haven't tested if sets are relevant), search transformer as described above.
 I'll see if there's a fix that works in both.
Thanks for the detailed report!

Thanks for the detailed report!

Sure, happy to help. Thanks for the helpful chat at FlatCamp! 😉

Fixed in v0.7.1.


Idea issue2

This pull request sucks as it changes your bundled output but I can't figure out how to change the source. I hope this can at least serve as an explanation of what I was looking for with my idea in Issue #2.

Thanks for the idea. For some reason you didn't minify the code, but you actually didn't need to build anything as you're only updating the readme. Also your code in readme isn't formatted in a readable way. You can either fix these issues, or I can reject merge request and put it in my to-do list for later. Up to you.

Feel free to reject and save the idea for later. I'll see where your series goes. Thanks for all the interesting stuff so far.


[BugFix][C++] Remove arrow header from GraphAr's headers

Proposed changes
commit-49685 has include arrow header into graphar' header which we should not do that. Because we can't assume that users's system installed arrow.
Types of changes
What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

Further comments
Fixed #228

hi, @Ziy1-Tan, this pull request needs your review

hi, @Ziy1-Tan, this pull request needs your review

Let me try it.

hi, @Ziy1-Tan, this pull request needs your review

I have a little doubt. When arrow is not installed, cmake will automatically build from source code. So we can always guarantee that arrow is installed, right?

the source-build arrow is just use by graphar, it does not install to system, so when user use graphar, we should guarantee they can run with graphar without arrow.

shared_ptr requires a full definition of the type, so the forward declaration does not work

Actually, shared_ptr can work with forward declaration.
https://stackoverflow.com/questions/16588075/forward-declarations-and-shared-ptr

This PR still need some refine, like revise the Expression as a real wrapper of arrow::Expression which not expose the arrow::Expression outside.


chore: A new home for proxy

The proxy is great and it deserves its own repository. We also need to talk about project management. Currently, we don't release too often. We should do it.
References

https://github.com/rust-email

Can we fix the (trivial) TODOs before we move it?

Sure! I just filed this issue as a reminder.


Failed to ingest events

Failed to ingest events .catch() Unexpected token 'I', "Internal S"... is not valid JSON
Machine ID: 4e682ce5-ae0b-4280-a29a-11dd9c0bebb9

[!NOTE]
Book a call

key
value

id
6E6UPnca5-3dguN43YPbR

url
http://localhost:3000/

wifi
4g

cpu
8

mem
8

gpu
ANGLE (Apple, ANGLE Metal Renderer: Apple M1 Pro, Unspecified Version)

time
1722308085739

items
43

bytes
420

Hi @beforeoafterm , we've just deployed a fix for you. Can you try running the setup script npx million@latest. Once it's done, please restart your VSCode/Cursor. Let me know if that works for you!


Structure docs to be the entry point for a first-time Wash user

Its structure would look something like
<description?>
<actions>
<attributes>
<signals?>
<talk about other Wash commands that could be useful>

so e.g.
wash . ❯ docs aws
This is the AWS plugin root. The AWS plugin reads the AWS_SHARED_CREDENTIALS_FILE
environment variable or $HOME/.aws/credentials and AWS_CONFIG_FILE environment
variable or $HOME/.aws/config to find profiles and configure the SDK. The profiles
it lists can be limited by adding

aws:
  profiles: [profile_1, profile_2]

to Wash's config file.

The AWS plugin currently supports EC2 and S3. IAM roles are supported when configured
as described here. Note that currently region will also need to be specified with the
profile.

If using MFA, Wash will prompt for it on standard input. Credentials are valid for 1 hour.
They are cached under wash/aws-credentials in your user cache directory so they can be
re-used across server restarts. Wash may have to re-prompt for a new MFA token in response
to navigating the Wash environment to authorize a new session.

SUPPORTED ACTIONS:
* list
    <description, example commands>

SUPPORTED ATTRIBUTES
(introduce a bit of the attributes/metadata stuff here.)

SUPPORTED SIGNALS
<supported signals>

Type `stree aws` to see a high-level overview of this thing's hierarchy;
`meta` to see its metadata, etc. (introduce some other commands in this section)

This will require some other changes:

Add descriptions for AWS profiles, GCP projects, Kube contexts, and namespaces. Reason is b/c what those things are isn't really obvious from their path, so it can be confusing for a first-time user.

(Optional) Include schema in info endpoint, possibly removing fs/schema.

For file-like entries, docs' supported actions output should slightly be tweaked to mention editing.


Update and rename gsoc-project-proposal.md to gsoc-project-proposal.yml

moving issue to issue form field template

Do we need to update the link in the README as well here: https://github.com/ioos/gsoc/blob/main/README.md?plain=1#L12?

Thanks! @mwengren, yes! @ocefpaf recently recommended pointing folks to https://github.com/ioos/gsoc/issues/new/choose and then they can pick the template they want. I really like that approach as it reduced the url complexity and is a little more flexible.

FYI @mwengren I made the change to the readme in https://github.com/ioos/gsoc/commit/3e68e09009a01b0c06e9f175387a9d1d6e6b6c71


testbarrier: remove T argument from Wait

Release: v0.9.0

#120  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jespert and the rest of your teammates on  Graphite


Nz Tags Not working properly with ngFor trackBy with nzOnClose

Reproduction link
https://stackblitz.com/edit/angular-znfrjs
Steps to reproduce
There is a list of checkboxes and selected values are shown in tags

Select values from checkbox. It will appear as tag.
Close tag. It removes extra tags
Disable trackBy from app.component.html and it will work as expected

What is expected?
It should work seamlessly with trackBy operator. Without using trackBy, there is a lot of flickering on the screen which doesn't give good UX.
Resultset is also shown on top of tags for debugging
What is actually happening?
when trackBy is enabled, on closing tag, it is not rendering list of tags properly and is removing tags that should be shown

Environment
Info

ng-zorro-antd
8.1.2

Browser
Chrome

Hi,
Did you get a chance to take a look at this issue? Appreciate your help on this.

@vatsalpande
The Angular animation has a bug https://github.com/angular/angular/issues/24041, it caused the animation can not execute.
This is a temporary solution:
<nz-tag *ngFor="let combination of selectedCombination;"
        class="tag"
        nzMode="closeable"
        nzNoAnimation
        (nzOnClose)="selectFilter(combination)">
  {{combination.label}}
</nz-tag>

Use the nzNoAnimation directive to prevent flickering.

@hsuanxyz - The proposed temp solution works. Thank you. If possible, please update this ticket once we have a permanent fix so I can apply that,


fichier beta updates

[x] I'm done, this Pull Request is ready for review :-)

I've merged this into the fichier branch
I made two changes

I fixed up the failing test
I put a bit more detail into a couple of the commit messages so when I look at them later I'll have some idea what we were doing!


Investigate moderate risk security vulnerability for sharp

Description
Update sharp dep or mitigate the risk to resolve "Possible vulnerability in sharp at 'npm install' time if an attacker has control over build environment".

Fixed in 760e73db6cd4a22d5e6f56014d0b861bd97f31be by force bumping patch version.


swapchain unable to validate if extensions are enabled

The swapchain layer cannot validate that the extension is being called without enabling the extension.
The layer will only return function pointers if the extension is enabled but it's inside those functions that we check that the function isn't being called without enabling the layer. Need to always hook these functions to allow those checks to catch invalid use.

I cherry-picked and pushed change !156 that fixes this.


Fixed a couple typos in FalcoSidekick Kubeless blog post

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area blog
What this PR does / why we need it:
Fixes typos in falcosidekick kubeless blog
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign radhikapc after the PR has been reviewed.
You can assign the PR to them by writing /assign @radhikapc in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign radhikapc after the PR has been reviewed.
You can assign the PR to them by writing /assign @radhikapc in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @broglea! It looks like this is your first PR to falcosecurity/falco-website 🎉

Welcome @broglea! It looks like this is your first PR to falcosecurity/falco-website 🎉

LGTM label has been added.  Git tree hash: 218bdf4d8af4472ef45ba4ccbfc8dd3f3f37ef1b

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Issif
To complete the pull request process, please assign radhikapc after the PR has been reviewed.
You can assign the PR to them by writing /assign @radhikapc in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 218bdf4d8af4472ef45ba4ccbfc8dd3f3f37ef1b

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Issif
To complete the pull request process, please assign radhikapc after the PR has been reviewed.
You can assign the PR to them by writing /assign @radhikapc in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Issif
To complete the pull request process, please assign radhikapc after the PR has been reviewed.
You can assign the PR to them by writing /assign @radhikapc in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Issif
To complete the pull request process, please assign radhikapc after the PR has been reviewed.
You can assign the PR to them by writing /assign @radhikapc in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Issif
To complete the pull request process, please assign radhikapc after the PR has been reviewed.
You can assign the PR to them by writing /assign @radhikapc in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Issif
To complete the pull request process, please assign radhikapc after the PR has been reviewed.
You can assign the PR to them by writing /assign @radhikapc in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif, leodido, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif, leodido, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


HTML Editor link option doesnt show buttons

Hello! Im trying to use HTML Editor and adding new Link and the buttons doesnt show.
What can i do?

@tcssistemas Would you please try using the modern HtmlEditorExtender instead of the legacy HtmlEditor?


Dist version of jsrsasign in the library should be in es5

Not sure why the dist version of jsrsasign has ES6 syntax.  Would it be possible to have the src files use ES6 syntax and have the dist be in ES5?

I don't think this matters as the ~/dist of oidc-client is packaging jsrsasign internally, no?

Any update?


Fix compilation and runtime crash on Switch

Fixed compilation with latest Switch toolchain and runtime crash.

Thanks @rsn8887 :)


Force APT cache update before executing install

Within our Docker caching, the APT cache is being persisted as well. Due to the inconsistent use of apt update, this might lead to the Docker cache being refreshed partially while still using a stale APT cache.
By running apt update before every apt install, we ensure the repository is always in the latest state if that layer has to be refreshed.
the || true is added due to stability reasons. APT is not 100% available and we had problems because of that. By swallowing that error, we increase the tolerance. If the package is really missing during the installation stage (because it's not in the APT cache and updating the cache failed due to server errors), we will throw the error anyway. If we still have a good cache with the proper package present even though the update failed, this means that the update wasn't actually necessary and that we can still proceed. We already employed this mechanism in some places. Now we're making everything equal to harden all install scripts.

I was wondering why we do all of this updating and fetching all of the time. Why not build docker images that have the deps pre-installed with pinned and tested versions?
Most of the time I see site build failures is because some dep goes offline. This wouldn't be a problem if we used pre-built docker images. I imagine there's some major trade-off there, but what's worse?

We do use prebuilt docker images (that's what our Docker cache is for). The problem is that sometimes dependencies change (aka the install scripts get updated). In that case, the cache has to be regenerated.
This updating and fetching will only happen if somebody modifies the install script. In 99% of the cases though, we will skip the execution of all these scripts entirely.

@marcoabreu I refer to these kinds of issues where we appear to download the same dependencies every build, and then are at risk of failure when those dependencies are unreachable: http://jenkins.mxnet-ci.amazon-ml.com/job/restricted-website-build/685/console
Could not find artifact codox:codox:jar:0.10.3 in central (https://repo1.maven.org/maven2/)
Could not transfer artifact codox:codox:jar:0.10.3 from/to clojars (https://repo.clojars.org/): Read timed out
Could not find artifact codox:codox:jar:0.10.3 in staging (https://repository.apache.org/content/repositories/staging)


recurring jobs: always take backup/snapshot

No matter the volume head is empty or not, always take backup/snapshot
in recurring backup job to avoid confusion.
Longhorn#3128
Signed-off-by: Derek Su<EMAIL_ADDRESS>

LGTM


[WIP] [DUOS-342][risk=low] Update user role table for DAC requirements

WIP
Definitely not ready for review yet. Having the PR up helps me keep track of the work left to do.
Addresses
https://broadinstitute.atlassian.net/browse/DUOS-342
Changes
The primary goal of this PR is to refactor the user role table to allow for DACs. Users should be able to have roles in different Data Access Committees as well as having the roles of Researcher, Data Owner, etc. There should be zero functional changes to any existing queries - this is primarily a refactoring PR, hence the large number of small changes.
Secondarily, we're updating tests so that we can separate unit testing against Resources vs DAOs. I am hopeful that this strategy will allow for easier testing in future PRs.

Coverage increased (+0.02%) to 62.284% when pulling 00202f0b0a2431bf7ce4d26e602d6b24500f030d on DUOS-342 into c668eb2de42cbf0ced0b1e61d2970bfc5e17d05e on develop.


Questions Regarding Kernel Size and Data Type Support

Hello! Thank you so much for this helpful repo for mamba.
Questions:

Kernel Size Limitation: I noticed that the kernel size is set to a maximum of 4. Could you provide insight into why this limitation exists? Is it due to storage efficiency, or are there compatibility issues with larger kernel sizes?
Data Type Support:
a. Currently, the code supports float32, bfloat16, and float16. Is there a plan to include support for float64 in the future?
b. Given that Mamba can work with complex weights, I was wondering if there is potential for the causal convolution to support complex kernels as well.

I've updated the README.

Kernel size 2, 3, 4 are supported.  We read in 4 or 8 input elements per thread, so limiting kernel size to 4 makes it easier to implement.
Dtype fp32, fp16, bf16 are supported. There's no plan to support float64, or complex types.

The depthwise conv1d implemented here is equivalent to 1 line of Pytorch (see README), so you can always just call Pytorch for the cases not supported here. The goal of this repo is just to make it fast for some cases used in Mamba (and a few other model architectures).


adj_source

my parameters.yaml is
workflow: inversion
system: workstation
solver: specfem2d
preprocess: pyaflowa
optimize: LBFGS
data_case: synthetic
stop_after: null
export_traces: False
export_residuals: False
export_gradient: True
export_kernels: False
start: 1
end: 1
export_model: True
thrifty: False
iteration: 1
ntask: 3
nproc: 1
mpiexec: null
log_level: DEBUG
verbose: False
syn_data_format: ascii
materials: elastic
density: False
attenuation: False
smooth_h: 1500.0
smooth_v: 750.0
components: ZX
source_prefix: SOURCE
multiples: False
min_period: 10.0
max_period: 200.0
filter_corners: 4
client: null
rotate: False
pyflex_preset: null
fix_windows: False
adj_src_type: cc_traveltime
plot: True
pyatoa_log_level: DEBUG
unit_output: DISP
export_datasets: True
export_figures: True
export_log_files: True
preconditioner: null
step_count_max: 5
step_len_init: 0.05
step_len_max: 0.5
line_search_method: Backtrack
LBFGS_mem: 3
LBFGS_max: inf
LBFGS_thresh: 0.0

after type seisflows submit in terminal, the traces filename in the "adj" folder such as "AA.S0001.HXZ.adj", rather than "AA.S0001.BXZ.adj". This issue can cause the following errors in seisflows.
================================================================================
                             EXTERNAL SOLVER ERROR
                             /////////////////////
The external numerical solver has returned a nonzero exit code (failure).
Consider stopping any currently running jobs to avoid wasted computational
resources. Check 'scratch/solver/mainsolver/adj_solver.log' for the solvers
stdout log message. The failing command and error message are:

exc: bin/xspecfem2D
err: Command 'bin/xspecfem2D' returned non-zero exit status 2.
================================================================================

the following error log in adj_solver.log
adjoint sources:
   adjoint source type:           1
   reading ASCII adjoint source files
At line 226 of file src/specfem2D/compute_arrays_source.f90 (unit = 40, file = 'SEM/AA.S0001.BXX.adj')
Fortran runtime error: End of file

Error termination. Backtrace:
#0  0x7f9417623ad0 in ???
#1  0x7f9417624649 in ???
#2  0x7f941762527f in ???
#3  0x7f94178784ab in ???
#4  0x7f9417871994 in ???
#5  0x7f94178725ba in ???
#6  0x556a063f3484 in read_adj_source_
	at src/specfem2D/compute_arrays_source.f90:226
#7  0x556a06533d10 in setup_adjoint_sources_
	at src/specfem2D/setup_sources_receivers.F90:620
#8  0x556a0653774b in setup_sources_receivers_
	at src/specfem2D/setup_sources_receivers.F90:50
#9  0x556a063c8834 in specfem2d
	at src/specfem2D/specfem2D.F90:380
#10  0x556a063c8834 in main
	at src/specfem2D/specfem2D.F90:357

How should I troubleshoot the error and solve this problem so that the file name generated in file A contains ‘B’ instead of 'H'

[ ]

Hi @AFULLBOTTLE-FAN, thanks for opening this issue, I'm sorry it's taken a few weeks to get around to it!
So my understanding of the issue is that SPECFEM is expecting a different channel code ("BX?") than what is written out by SeisFlows ("HX?"). Since you are using Pyaflowa as your preprocessing class, the adjoint source writing is taken care of by Pyadjoint under the hood, which uses the channel code of the observed data to name the adjoint source file.
However, during the preprocessing, the observed data should be resampled to the sampling rate of the synthetics, so that they share the same channel code.
Can you let me know what the sampling rate of your data and synthetics are for this problem? That may help find the underlyting issue.

Closing this issue for inactivity, if this issue persists please re-open as a new issue and reference this issue number, thanks!


Add first draft of client usage docs

It looks very good to me, detailed with many examples. All good from my side but we can see what Emma thinks too before we merge.

I highly recommend checking your final version via Cannon's docs repository if you have not already done so as I found a few syntax bugs in my own that prevented the page from being rendered when I did.

One other quick comment -- it looks like each tab in the rendered index just reads the file name. Can you name the document something like serving_an_origin.mdx?


Pull ARAM item sets from LOLAlytics with LOLFlavor going down

Pull ARAM item sets from LOLAlytics with LOLFlavor going down. Updated translations for LOLAlytics. Also updated a number of packages.

Amusing, I was literally going to make this same change tonight, and thought to glance here and lo and behold, LOL

Unfortunately, I'm not sure @dustinblackman is still maintaining the app which means it may never make it in. But at least I have it working locally now.

I totally agree. I didn't really like the layout either. I could definitely do some cleanup on it - perhaps reducing the number of items returned might go a long way to improving it. That said, I'd just love to get anything at this point.

If you're willing to do some cleanup work on it for the greater good, I'll go chat with @dustinblackman. Given my background, and the fact he knows me, I'm hoping I can get him to give me access to collaborate on merging in pull requests and take over maintaining it without having to take the extra step of forking Championify to a new version of my own. (I would much rather leave it living here, since he put so much blood sweat and tears into the project).
My vision, since he no longer has the time and resources to maintain it, is to take over maintaining the general releases of it and let the community start contributing more (with adequate review and oversight, naturally!).

That sounds great @sargonas! I'll carve out some time this week (maybe over next weekend) and see if I can't improve the presentation and usability somewhat and circle back.

How do I get this pull request on my application?

How do I get this pull request on my application?

Sorry, I've had almost no time the last couple weeks and I've been meaning to get this cleaned up and finished so that it can be integrated into the master branch. If you want something quicker (and have the capability of building it locally) you could fork my repo, build it, and run it locally on your machine.

@sargonas, Sorry for the delay on getting back to this. I went ahead and cleaned up the look and feel for the LoLAlytics ARAM item sets. I also applied map filters on all LoLAlytics item sets so that the ARAM ones are only on Howling Abyss and the others apply to Summoner's Rift. As part of adding the map filter, I did have to adjust the test fixtures as they were previously set to "map" : "any".
Unless you have any other suggestions or adjustments, I think everything is ready to go. If you're able to touch base with @dustinblackman in hopes of getting the app updated I'm sure many would really appreciate it. Thanks a lot!

I spoke to him briefly back when I checked in, he's keen on the idea of opening up support to others like me to help approve and merge in community updates to keep it alive and fresh, since he no longer has the time to support it, though he says there is some work he wants to do on his side first to make it ready for that, since right now it's not. He didn't explain what exactly, but I suspect it's related to the myriad of dependency and deprecation errors I got myself when I tried to set up the repo from scratch and build my own up to date version.
In any event, I did not follow up with him a second time when I should have, so I'll go bug him again shortly. I'm committed one way or another to helping out, just be patient with me while I try. :D

Understandable. It was quite a struggle getting things working when I pulled the code down the first time (especially on Windows where you can't even run tests). Let him know if he needs any help I, and I'm sure others, would be happy to help clean things up if he just wants to give some direction. Thanks for the help.


Module not found error when installing

$ python3 setup.py install
DendroPY not supported.
Traceback (most recent call last):
  File "setup.py", line 5, in <module>
    import clusim
  File "/Users/yy/git/clusim/clusim/__init__.py", line 5, in <module>
    from clusim.clugen import *
  File "/Users/yy/git/clusim/clusim/clugen.py", line 5, in <module>
    import mpmath
ModuleNotFoundError: No module named 'mpmath'

Is this because __init__.py imports clusim package?

I think the problem was in setup.py .  Can you try it now?

I'm still getting an error from from clusim import __package__, __description__, __version__
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/xb/7k4mj0yn6fx6f67t1rv3jmvxncy8kk/T/pip-req-build-sb4768dq/setup.py", line 6, in <module>
        from clusim import __package__, __description__, __version__
      File "/private/var/folders/xb/7k4mj0yn6fx6f67t1rv3jmvxncy8kk/T/pip-req-build-sb4768dq/clusim/__init__.py", line 18, in <module>
        from clusim.clugen import *
      File "/private/var/folders/xb/7k4mj0yn6fx6f67t1rv3jmvxncy8kk/T/pip-req-build-sb4768dq/clusim/clugen.py", line 3, in <module>
        import mpmath
    ModuleNotFoundError: No module named 'mpmath'
    DendroPY not supported.

now it installs fine, but with some warnings:
warning: no files found matching '*.html' under directory 'doc'
warning: no files found matching '*.css' under directory 'doc'
warning: no previously-included files matching '*~' found anywhere in distribution
warning: no previously-included files matching '*.pyc' found anywhere in distribution
warning: no previously-included files matching '.svn' found anywhere in distribution
no previously-included directories found matching 'doc/build'
no previously-included directories found matching 'doc/auto_examples'
no previously-included directories found matching 'doc/modules'
no previously-included directories found matching 'doc/reference/generated'
no previously-included directories found matching 'doc/reference/algorithms/generated'
no previously-included directories found matching 'doc/reference/classes/generated'
no previously-included directories found matching 'doc/reference/readwrite/generated'


Basic panzoom use case, but having an issue making sense of the results

First off just wanted to thanks the contributors and author for this, it's a great tool, and I'm glad it exists! :+1:
Subject of the issue
I've setup a jsfiddle to demonstrate my issue.
I'm building a system where I have data like the following:
[
  {
    x: 200,
    y: 200,
    zoomFactor: 1.2
  },
  ...
]

Based on certain user input, I need to pan and zoom the image to the above defined points. (pretty basic) However, I'm having some weird behavior that I'm not entirely understanding.
The pan and zoom features of the library seem to affect each other in odd ways. I'll describe in detail in the "Steps to reproduce" section. This is issue makes me feel like I'm missing something big about this library, but I don't see anyone talking about the issue I'm having nor any example to account for this.
Any pointers, advice, or examples are much appreciated!
My environment

jquery == 3.1.0
jquery.panzoom == 3.2.2
chrome == 52.0.2743.116
ubuntu == 16.04

Steps to reproduce

open the above jsfiddle
open dev tools for info logged to the console
click the 'Details' button in the demo
notice that the position of the image is logged to the console. Currently it's at (0, 0).
click the 'Pan' button, then again click the 'Details' button
notice that the image was moved to (200, 200), where we want it.
now click the 'Zoom' button, and again click the details button
notice that the image has moved from (200, 200) and is now at (208, 244)
NOTE This same issue happens when zooming first, then panning, although the coordinates differ.

Expected behaviour
I naively expect that the image will be zoomed to the given zoomFactor AND the image should stay where I've panned it to, namely (200, 200).
Actual behaviour
When zooming the image pans away from the previously set coordinates

I've been playing with this for the past few days, and am going through the source to try to debug further, or at least understand the results.
I've also found that the problem is exacerbated when the zoom factor is higher. So for instance, in the above jsfiddle, when the zoom factor is 5, and you first zoom, then pan, I would expect the image to be at (200, 200) since the last operation was panning. However, the image ends up at (-1346, -1000)... wat
Has anyone else experienced this behavior, or have any advice on how to mitigate/solve this issue?

It looks like you're using focal point zooming, which uses a complicated formula to zoom in on a particular point. The resulting coordinates depend on a lot of things, including the focal point, zoom factor, parent offset, and others. Have a look at the demo page for an example of how focal point zooming can be used effectively.

By the way, you can set the pan coordinates separately from the zoom if you want to keep certain x/y coordinates: https://jsfiddle.net/timmywil/oc4xju5q/

I started using focal point zooming, because I wanted to zoom respective to a particular point. In my example, I started using the upper left corner to see if that would stay stationary.
I think I may have not explained my problem well. I've definitely taken a look at the demo page many times, but haven't seen examples there, or elsewhere, like what I'm trying to achieve. All the examples I've seen rely on human input to pan and zoom, and are not trying to get the image placed precisely. I'm looking to pan and zoom programmatically. Given an (x,y) pair and a (width, height) (which I convert to a zoom factor) of a specific section of an image, I want to move said image to make that section front and center.
Here is a very crude example:
+------------------------------------------+
|                                                    |
|                                                    |
|                                                    |
|                                                    |
|
|
|
|
|
|

I think I may have not explained my problem well. I've definitely taken a look at the demo page many times, but haven't seen examples there, or elsewhere, like what I'm trying to achieve. All the examples I've seen rely on human input to pan and zoom, and are not trying to get the image placed precisely via data. I'm looking to pan and zoom programmatically, via your API. Given a predefined set of data: an (x,y) pair and a (width, height) (which I convert to a zoom factor) of a specific section of an image, I want to move and zoom the image to the section defined in the data.
The thing I'm misunderstanding the most is the API that I'm given. For pan I'm supposed to specify an (x,y) pair in pixels. However, if I do anything other than panning, for instance a call to zoom, quickly invalidates those (x,y) coordinates. They no longer represent the correct point on the image.
I may be wrong here, but does the library not account for this change in zoom when the pan method is called? The example you wrote above demonstrates this exactly:
$('.panzoom')
    .panzoom('zoom', 2)
    .panzoom('pan', 200, 200);

I read it as: zoom with a factor of 2, then move the image to (200,200) pixels. However, what I see happen is that the image moves up and to the left, in the negative direction. Precisely, it was moved to (-186.5, -100). These coordinates do not seem to represent (200,200) respective to the parent container, nor the origin of the parent container. They don't seem the represent the coordinates when taking the zoom factor into account, which might be something like (400, 400) for a zoom factor of 2.

Ah, there we go. The first example in your above comment does the trick.
.panzoom {
  ...
  transform-origin: 0 0 !important;
}

I tried doing that, but forgot to set the !important on it, so it probably got overridden shortly thereafter.
Thanks for your help @timmywil, I really appreciate it!


For AUTO_CURSEFORGE, auto-set LEVEL from world save provided by modpack

Also:

Will help with #1927 and similar where the latest files in overrides always need to be written...but keeping world data untouched

Also discussed at https://discord.com/channels/660567679458869252/660567682751528981/1067297541525348352


User documentation

It would be nice to add a user documentation to help user how to use the plugin UI.

This might be a duplicate of #103


Updated all the themes for 385+

Along with updating, I also added some comments to one theme, added missing settings dock import to various themes, removed an import on one to fix it up, and a couple other minor things to bring them all up-to-date with current links to NFLD's website and the source repo to yours as that is where they are available from.
This took a bit to do since I had to update the name and description of all the themes manually, otherwise I would of automated it somehow, lol..

Thanks to TwinDragon Themes are updated just redownload


Error when running pnpm run build on fresh project

Please provide the environment you discovered this bug in.
Local machine
pnpm v8.15.4
Angular 17 template

Which area/package is the issue in?
create-analog
Description
When creating a new project from scratch and running the build process. There are errors in the terminal.
pnpm create analog

Please provide the exception or error you saw
Dales-MacBook-Pro-2:analog-project dalenguyen$ pnpm run build
npm run build

><EMAIL_ADDRESS>build /Users/dalenguyen/projects/github/analog-project
> ng build

vite v5.2.7 building for production...
TypeError: Cannot read properties of undefined (reading 'addWatchFile')
TypeError: Cannot read properties of undefined (reading 'addWatchFile')
✓ 338 modules transformed.
dist/client/index.html                             0.49 kB │ gzip:  0.31 kB
dist/client/assets/favicon-BYy3mmNz.ico            0.95 kB
dist/client/assets/index-CTeTXu9h.css              6.20 kB │ gzip:  1.88 kB
dist/client/assets/index.page-D1fJvSQP.js          0.96 kB │ gzip:  0.60 kB
dist/client/assets/analogjs-content-Cb2aAZAr.js  138.84 kB │ gzip: 44.94 kB
dist/client/assets/index-BE1TERfh.js             269.39 kB │ gzip: 84.98 kB
✓ built in 12.81s
Building SSR application...
vite v5.2.7 building SSR bundle for production...
TypeError: Cannot read properties of undefined (reading 'addWatchFile')
TypeError: Cannot read properties of undefined (reading 'addWatchFile')
TypeError: Cannot read properties of undefined (reading 'addWatchFile')
TypeError: Cannot read properties of undefined (reading 'addWatchFile')
✓ 31 modules transformed.
dist/ssr/assets/index.page-Di9OCjWC.js            2.13 kB
dist/ssr/assets/analogjs-content-Bd5qOT4v.js     19.03 kB
dist/ssr/assets/xhr2-CDOpgsGh.js                 36.45 kB
dist/ssr/main.server.js                       1,365.09 kB
✓ built in 10.46s
Prerendering static pages...
Building Server...
TypeError: The URL must be of scheme file
    at new NodeError (node:internal/errors:405:5)
    at fileURLToPath (node:internal/url:1436:11)
    at fileURLToPath (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/mlly@1.6.1/node_modules/mlly/dist/index.mjs:1976:25)
    at pathToFileURL (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/mlly@1.6.1/node_modules/mlly/dist/index.mjs:1979:26)
    at _resolve (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/mlly@1.6.1/node_modules/mlly/dist/index.mjs:2113:10)
    at resolveSync (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/mlly@1.6.1/node_modules/mlly/dist/index.mjs:2116:10)
    at resolvePathSync (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/mlly@1.6.1/node_modules/mlly/dist/index.mjs:2126:24)
    at resolvePath (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/mlly@1.6.1/node_modules/mlly/dist/index.mjs:2130:28)
    at _resolve (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/nitropack@2.9.5/node_modules/nitropack/dist/nitro.mjs:421:22)
    at Object.resolveId (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/nitropack@2.9.5/node_modules/nitropack/dist/nitro.mjs:457:29) {
  code: 'ERR_INVALID_URL_SCHEME'
}
TypeError: The URL must be of scheme file
    at new NodeError (node:internal/errors:405:5)
    at fileURLToPath (node:internal/url:1436:11)
    at fileURLToPath (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/mlly@1.6.1/node_modules/mlly/dist/index.mjs:1976:25)
    at pathToFileURL (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/mlly@1.6.1/node_modules/mlly/dist/index.mjs:1979:26)
    at _resolve (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/mlly@1.6.1/node_modules/mlly/dist/index.mjs:2113:10)
    at resolveSync (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/mlly@1.6.1/node_modules/mlly/dist/index.mjs:2116:10)
    at resolvePathSync (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/mlly@1.6.1/node_modules/mlly/dist/index.mjs:2126:24)
    at resolvePath (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/mlly@1.6.1/node_modules/mlly/dist/index.mjs:2130:28)
    at _resolve (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/nitropack@2.9.5/node_modules/nitropack/dist/nitro.mjs:421:22)
    at Object.resolveId (file:///Users/dalenguyen/projects/github/analog-project/node_modules/.pnpm/nitropack@2.9.5/node_modules/nitropack/dist/nitro.mjs:457:29) {
  code: 'ERR_INVALID_URL_SCHEME'
}

The '@analogjs/platform' server has been successfully built.

Other information
No response
I would be willing to submit a PR to fix this issue

[ ] Yes
[ ] No

Both issues have already been fixed
The addWatchFile issue was fixed here https://github.com/analogjs/analog/pull/979. This release will go out on Monday. As a workaround, pin Vite to ~5.0.0
URL scheme issue was fixed upstream in nitro and will go in the next release. As a workaround, you can pin nitropack to 2.9.4

Awesome. Thanks, Brandon!


remove deprecated data_loader

Fixing deprecated warning in init load
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hi, What will be the standard way to pass data loaders, now that the decorator is deprecated?

Just use your data loader...


Add json tags for o11y metrics struct

I'm not sure this type was designed for sending over the wire, I'd keep that contract internal to the system you're building, rather than the contract leaking out here

@pete-woods you're right, this looks to be the definition of a metric rather then and instance of a metric with values and tags assigned.


Question about the predictions made by M

Hi @hardmaru , thanks again for the great work in making this paper accessible and reproducible!
I have a question about the predictions made by M:
In the dreams, it seems M is able to produce quite plausible future scenarios. Would you expect that these dreams predict well what actually happens in a given scenario? In other words, if you condition M on a sequence of real images, would you expect first few images of the "dream" to be close to what actually comes next? Did you do any experiments in this direction?
If I understood correctly, one motivation for using an MDN-RNN is that it gives M some creativity and ability to make several different types of predictions. However, does that also limit its ability to predict accurately what does happen in the future?
Best,
-Kai

Hi @kaiolae
You can encode previous ground truth frames and ground truth actions into M, and have it predict future frames based on the real ground truth history, and even sample multiple futures conditional on a common past. The accuracy depends on how well the LSTM models the probability distribution of the training data it is given.
One way to visualize this is to try the sketch-rnn demo, which uses basically the same algorithm as M, but rather than predict future z's, it predicts future pen strokes given a common ground truth past:

Try it here:
https://magenta.tensorflow.org/assets/sketch_rnn_demo/multi_predict.html


Step over/into doesn't work if code editor is undocked

If the code editor pane is undocked and this window is active, pressing the key for step over / step into has no effect unless you select the main Spyder window first.

Spyder version: 5.3.3
Python version: 3.10.8 64-bit
Qt version: 5.15.2
PyQt version: 5.15.7
Operating System name/version: Windows 10

Hi @bajhuman thank you for the feedback! I think I was able to reproduce this! Could this be related to https://github.com/spyder-ide/spyder/issues/5123 basically when a pane is undocked seems like the shortcuts don't work while the undocked pane has the focus :/
As a workaround, you could instead of undocking the Editor use the New window option and then use the Close option to hide the Editor pane in the main Spyder window.
Let us know it the info above helps!

Closing as a duplicate of #5123


Cache static assets and serve them straight from memory?

A request comes in for /styles.css, so citizen reads the file and stores the raw buffer in the cache. On subsequent requests, the file buffer is served straight from memory.
Is this insane?

Possibly insane, but implemented.


Implement trtl batch iter seek

@pdeziel looks like we forgot to commit the pkg/trtl/util.go file.

Codecov Report

Merging #322 (3905f70) into main (d90c26c) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
- Coverage   45.79%   45.65%   -0.14%
==========================================
  Files          63       64       +1
  Lines        7875     7888      +13
==========================================
- Hits         3606     3601       -5
- Misses       3601     3617      +16
- Partials      668      670       +2

Impacted Files
Coverage Δ

directory/pkg/gds/store/trtl/iterator.go
44.96% <0.00%> (-3.40%)
:arrow_down:

directory/pkg/trtl/peers.go
55.81% <0.00%> (-2.33%)
:arrow_down:

directory/pkg/trtl/trtl.go
74.92% <0.00%> (-0.62%)
:arrow_down:

directory/pkg/trtl/util.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d90c26c...3905f70. Read the comment docs.


STM32MP1 : Pinmux support

depends-on: https://github.com/arnop2/zephyr_stm32mp1/pull/3

Implementation of pinmux for the stm32mp157c_dk2 board.
Some UART pin mux definition has been added (mainly for future UART console and UART Arduino shield support, and also as a template for future peripheral integration).
This can be completed with pin mux for definition for other stm32mp157c peripherals.

Close because will be add in UART and SPI PR, thank you.


⚠ Fortnite has degraded performance

In 2a727f1, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 2036 ms

Resolved: Fortnite performance has improved in c220c19.


Update index.mdx

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


readme.rs shows BSD license but LICENSE file is MIT

Ha yes , thanks for reporting

thank you for pointing me this out - https://github.com/foxmask/django-th/commit/8afb06fbd0a635d6d14c2df8239a361478d9df1a


[PROTOCOL RFC] Column Mapping Usage Tracking

Which Delta project/connector is this regarding?

[ ] Spark
[ ] Standalone
[ ] Flink
[ ] Kernel
[x] Other (fill in here)

Description
Adds the proposal for spec change Column Mapping Usage Tracking (see https://github.com/delta-io/delta/issues/2682) to the RFC folder.
How was this patch tested?
N/A
Does this PR introduce any user-facing changes?
N/A

I am going to ignore the spark test failure (probably some flakiness) as this PR does not touch code.


Typo fix in tensorflow-inception/README.md

a small typo in tensorflow-inception/README.md line 25
There are many such typos in the directory /incubator.

/assign @linki

/lgtm


Connect-PnPOnline command is not working along with Export-M365DSCConfiguration in Azure Runbook

We are running a script in Azure Runbook which performs actions-
-Connects to SharePoint site using Connect-PnPOnline
-Export M365DSC configuration
Script returns error: Could not load type 'Microsoft.Graph.Authentication.AzureIdentityAccessTokenProvider' from assembly 'Microsoft.Graph.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
After consulting with M365DSC Github community contributors, we understood it is occurring due to PnP command.
Kindly suggest on this issue.
Reporting an Issue or Missing Feature
Issue
Expected behavior
To connect SharePoint site and work with Export-M365DSCConfiguration command
Actual behavior
Could not load type 'Microsoft.Graph.Authentication.AzureIdentityAccessTokenProvider' from assembly 'Microsoft.Graph.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
Steps to reproduce behavior
Make Connect-PnPOnline command call before Export DSC command
What is the version of the Cmdlet module you are running?
1.12.0 with PS 5.1
Which operating system/environment are you running PnP PowerShell on?

[ ] Azure Cloud Shell

@Infy-Ayusi Any particular reason why you're using such an old PnP PowerShell version? Could you try this with the latest nightly build of PnP PowerShell? @gautamdsheth has recently implemented a fix for clashes between multiple PowerShell modules using different versions of the same file, which seems to be the case at hand here.

Yes, this issue has been fixed with latest nightly builds of PnP PowerShell.
Will move it to discussion.


Adding relation graph endpoint

Fixes #96.

This is conflicting due to other merged changes. @Silberschleier please resolve the conflicts, thank you :smile:


Error adding Reference TS with Czech Characters

I tried to add the reference time series of snow depth at "Labská Bouda" site. I used the REST service option with the following REST URL: http://hydrodata.info/chmi-d/cuahsi_1_1.asmx/GetValuesObject?location=CHMI-D:1&variable=CHMI-D:SNIH&startDate=2014-11-01&endDate=2015-03-27&authToken=
The preview is shown correctly, but when I try to save the resource, I get an error: 'ascii' codec can't encode character u'\xe1' in position 644: ordinal not in range(128). Please see the attached error message.

@danames can you please test this on dev and if it is working close the issue.

Is there a reason dev.hydroshare.org isn't sending confirmation emails for
new accounts? I'm not able to get in with my old account so I tried
creating a new one, but no confirmation email...
On Mon, Apr 20, 2015 at 8:16 AM David Tarboton<EMAIL_ADDRESS>wrote:

@danames https://github.com/danames can you please test this on dev and
if it is working close the issue.
--
Reply to this email directly or view it on GitHub
https://github.com/hydroshare/hydroshare/issues/267#issuecomment-94464640
.

@mjstealey please comment on the confirmation email.  There have been changes related to the "secrets" getting secured.  Also Michael will shortly (possibly in process already) be updating dev with code improvements from Calvin that better secure the email handling so some things will be changing there anyway.

Just verified this is fixed in dev.hydroshare.org.


Error in README doc

in introduction quick start you writte npm install react-loadingg instead of npm install react-loading,
Please remove the additionnal G in loading word.

npm install react-loadingg  is true ~


How to access head position coordinates?

Great work! Just getting started and was wandering; is there a way to get head position coordinates (x-y-z) from the camera's coordinate system?
Using the example in getting_started ipynb I've managed to get only angular representation of head pose.

Hey @anacej!
The head position (xyz) in the camdriver frame can be found in the 4x4 homogeneous transformation matrix you obtain by di.get_T_camdriver_head(stamp):
T_camdriver_head = di.get_T_camdriver_head(stamp)
p_head_camdriver = T_camdriver_head[0:3,3]  # first three rows, last column

See also https://en.wikipedia.org/wiki/Transformation_matrix#Affine_transformations

Thank you!


Add Interview Cake

This looks like a solid service: https://www.interviewcake.com/
Vouchers can be found online (e.g. codingforinterviews.com just had one)

I think they changed their model from interview problems to a problems/tutoring hybrid? Anyway gotta take this into account when doing the next reorg.

Already exists
https://github.com/andreis/interview/commit/8db9c60695ddfb6d5a54afe424a74ed2f7339699


Container/Column/ColumnSet/Improved visualizer

New UI Elements

added container/column/columnSet

Improved Visualizer

user can select json directly

Sample Cards Rendering

Fixed most of style issues when rendered with sample cards

@nesalang,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


fix(di): get symbol description instead of its constructor

Informations

Type
Migration

Fix
No

Description
Provider uses constructor symbol instead of its description. This results in that InjectorService creates few instances on one provider.
See following example:
import {InjectorService} from "@tsed/common";

export interface DummyService {
   noop(): void;
}

export const DummyService = Symbol("DummyService");

export class DummyServiceImp {}

registerProvider({provide: DummyService, userClass: DummyServiceImp});

export interface DummyService2 {
   noop(): void;
}

export const DummyService2 = Symbol("DummyService2");

export class DummyService2Imp {}

registerProvider({provide: DummyService2, userClass: DummyService2Imp});

Expected behavior:
If I try to call InjectorService.load() method it builds 2 instances for following class DummyService2Imp and DummyServiceImp.
Actual behavior:
It builds instances more than enough.

:tada: This PR is included in version 4.32.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

Thanks @ArtemDerevnjuk for your work ;)


fix(schemas): update schema for obs-websocket 4.8

I was getting this error over and over in the logs:
error: [moment:obs] Error updating program scene:
{
  message: 'Invalid value rejected for replicant "obs:programScene" in namespace "moment":\n' +
    '\tField "data" no (or more than one) schemas match\n',
  stack: 'Error: Invalid value rejected for replicant "obs:programScene" in namespace "moment":\n' +
    '\tField "data" no (or more than one) schemas match\n' +
    '\n' +
    '    at Replicant.validate (/Volumes/Data/Media/Developer/Side Projects/Moment/moment-nodecg/lib/replicant/shared.js:296:12)\n' +
    '    at Replicant.set value [as value] (/Volumes/Data/Media/Developer/Side Projects/Moment/moment-nodecg/lib/replicant/replicant.js:34:8)\n' +
    '    at /Volumes/Data/Media/Developer/Side Projects/Moment/moment-nodecg/bundles/moment/node_modules/nodecg-utility-obs/dist/index.js:329:52\n' +
    '    at processTicksAndRejections (internal/process/task_queues.js:93:5)\n' +
    '    at async Promise.all (index 1)'
}

Was able to determine that it was due to some new properties added to the obs-websocket spec in 4.8.0.
The spec doesn't list them as optional, but I didn't make them required so as not to break compatibility with earlier versions of obs-websocket.

Thanks!


Enable specifying experiment flags in test conditions

Right now a test can specify that it requires certain experiment flags to be enabled by using a special marker comment in the test itself. But with NNBD, we want to be able to reuse as many tests as possible as both NNBD-enabled and legacy mode. So we need to take the same test and sometimes run it with the NNBD experiment flag enabled and sometimes disabled.
This implies that a test configuration should be able to specify which experiment flags it enables. This issue tracks that support.

Filed the plumbing bugs: #38386, #38387, #38388, #38389.


Update prompt when jumping around path history

Hi everyone!
I found an annoying issue.
Here's a snippet:
initial:
ahalicki at cubiarek in ~/Praca/ci/Harvest on master [?]
❯ cd bInstall/                                                             09:01

If path is expanding is OK
ahalicki at cubiarek in ~/Praca/ci/Harvest/bInstall on master [?]
❯                                                                          09:02

But here after Alt+Left Arrow is rubbish:
ahalicki at cubiarek in ~/Praca/ci/Harvest on master [?]aster [?]
❯                                                                          09:04

Hi @halicki. Help understand the problem again. First, what is that [?]?

@jbucaran The master [?] is the current git branch name (master) and its status ([?] means modified/).

@jbucaran I think that the example that I presented is misleading. The issue happens even if user is jumping between non git paths. I will update the description.

Let's ping @sotayamashita, the author of this prompt to see if he has any feedback.
In the meantime, hang on, or try any other of the available themes would you? Run fisher ls-remote to see what you can install.

Cleaner description:
ahalicki at cubiarek in ~/test
❯ ls                                                                       14:51
baaaaar/  fooo/

ahalicki at cubiarek in ~/test
❯ cd fooo/                                                                 14:51

ahalicki at cubiarek in ~/test/fooo
❯ cd ../baaaaar/                                                           14:52

ahalicki at cubiarek in ~/test/baaaaar
❯                                                                          14:52

now press Alt+LeftArrow
ahalicki at cubiarek in ~/test/foooaar
❯                                                                          14:52

@halicki I understand the issue now, what I am confused about now is this Alt+←/→ binding that I have never heard of.
How does that work and where is the documentation for that?

@jbucaran it's on fish documentation page. It's one of the main features of fish ;-)
It's a second entry from: https://fishshell.com/docs/current/index.html#shared-binds

Alt← and Alt→ move the cursor one word left or right, or moves forward/backward in the directory history if the command line is empty. If the cursor is already at the end of the line, and an autosuggestion is available, Alt→ (or AltF) accepts the first word in the suggestion.

@halicki I thought you meant moving into directories when you said "jumping", I don't know why I thought that! I didn't know fish had this key binding, useful indeed :)
So, I installed the prompt, but I couldn't repro it, maybe I didn't try hard enough. Let's wait to hear from the author.

@jbucaran Thank you for answering the issue. I am catching up it...

@sotyayamashita no problem!

@halicki I tried same things which you did (ref) but I cannot get the kind of bug :bug:.
Here is my environment:

OSX
fisherman version 2.11.0
fish, version 2.4.0

@sotayamashita: I have the same environment, with exception to fisherman (2.10.0 - I think that the latest release, ref: fisherman/fisherman/releases).
I think that maybe I am still not understood properly. The prompt isn't displayed properly although the directory is successfully changed. I'll demonstrate it again, if you allow ;)
arek at air in ~
❯ cd foo                                                                              17:54

arek at air in ~/foo
❯                                                                                17:54

Press Alt + LeftArrow: (does not update the prompt).
arek at air in ~/foo
❯                                                                                17:55

Press Enter: (prints prompt with changed directory)
arek at air in ~/
❯                                                                                17:55

So to have clearly displayed path I need to press Enter each time I jump trough path history. This is pretty annoying when searching trough long path history.
This issue was reproduced by me on my private macOS running iTerm and at work on Ubuntu 16.04 running gnome terminal. On both machines I was testing with or without tmux.

OSX user here, I get a similar non-updating on alt+left (until you get to the 'root' and then try alt+left once more) but it works fine on alt+right.

@halicki @alexrussell
I completely understand what problem is and I am trying to fix this issue but If you have any idea, please tell me :bow:


Error:400 (BadRequest)

Follow this tutorial, use the demo APP you provided, set-up everything for the development environment. When I debug it, after I hit embed report on the home page, lead me to a error page saying Response status code does not indicate success: 400 (BadRequest). Use the troubleshooting document but unable to specific this error. Can someone find any reason why this happened?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0fdac5f7-cd43-34c5-5905-dceeb9813952
Version Independent ID: 6fd53f84-dbb2-2a9c-2745-ea1999779113
Content: Embedded analytics to embed Power BI content in your application for your customers - Power BI
Content Source: powerbi-docs/developer/embed-sample-for-customers.md
Service: powerbi
Sub-service: powerbi-developer
GitHub Login: @rkarlin
Microsoft Alias: rkarlin

Thanks for your comment, @Ccccche . This looks like a support request or product question rather than documentation feedback. You might find a solution in the Power BI Community, at https://community.powerbi.com. If not, you can get support by going to https://support.powerbi.com.

@markingmyname - just checking whether there's info we should add for this or whether @Ccccche should contact support

@Ccccche/@mgblythe,
My recommendation is to collect a fiddler trace to see where the bad request is coming from first.  Once that is collected, then contact support to see if they can help.

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion, and we will reopen the issue.


Shataranj

Author name: Nikhil kumar
Author
SatChitAnand
About your game
What is your game about?
I'm very enthusiastic for New games, but chess is a classic favorite of many. That's why I choose to create it. There was already a chess on Sprig and it motivated me and also inspired me to write those long codes. No wonder it is a silent game, but indeed all the pieces speak up when it's a checkmate. And since I got the fundamentals, I can make a chess website in future with my fellow hack clubbers. Our own chess.com 😅
How do you play your game?
Use WASD to move your cursor, J to pick up a piece, and K to place it.
You can use L(left) to drop a piece (or deselect), if some mistake happened (oops). Music will play if choose illegal move, to make you dance on your crime 😄
Code
Check off the items that are true.
[x ] The game was made using the Sprig editor.
[x ] The game is placed in the in the /games directory.
[ x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x ] The game runs without errors.
[x ] The name of the file/game contains only alphanumeric characters, -s, or _s.
[ x] The game name is not the same as the others from gallery
Image (If an image is used)
[ x] The image is in the /games/img directory.
[ x] The name of the image matches the name of your file.

Thanks for your PR!
Hope we can Play it together

Man, you know what I'm speaking. It's not the first time. Copying is not the solution, make your own game, you learn and have a console :) You can do remixes, but changing color and text are not big changes to consider your game. I'm here if you need any help:)

I developed my own code but yet struggling with graphic and public api

what sounds confusing in Sprig?

what sounds confusing in Sprig?

Can we chat somewhere else slack?

sure, are you on Hack Club Slack?

Yes

Closing due to inactivity. Please re-open if you'd like to continue forward landing this game!


⚠ Spryr has degraded performance

In 268b0a7, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4549 ms

Resolved: Spryr performance has improved in dd17edd after 7 minutes.


Cannot generate contact file

vmail-contact.txt was created, it is empty. Vmail cannot access to mailbox.
/usr/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in require': iconv will be deprecated in the future, use String#encode instead. Starting vmail 2.5.7 Checking vmail.db version... OK Setting VMAIL_BROWSER to 'gnome-open' Using config file: .vmailrc Using contacts file: vmail-contacts.txt Logging as<EMAIL_ADDRESS>#<struct Net::IMAP::TaggedResponse tag="RUBY0001", name="OK", data=#<struct Net::IMAP::ResponseText code=nil<EMAIL_ADDRESS>user authenticated (Success)">, raw_data="RUBY0001 OK<EMAIL_ADDRESS>user authenticated (Success)\r\n"> Selecting [Gmail]/Sent Mail /usr/lib/ruby/1.9.1/net/imap.rb:1141:in get_tagged_response':  Unknown Mailbox: [Gmail]/Sent Mail (Failure) (Net::IMAP::NoResponseError)
from /usr/lib/ruby/1.9.1/net/imap.rb:1195:in block in send_command' 	from /usr/lib/ruby/1.9.1/monitor.rb:211:in mon_synchronize'
from /usr/lib/ruby/1.9.1/net/imap.rb:1177:in send_command' 	from /usr/lib/ruby/1.9.1/net/imap.rb:437:in block in select'
from /usr/lib/ruby/1.9.1/monitor.rb:211:in mon_synchronize' 	from /usr/lib/ruby/1.9.1/net/imap.rb:435:in select'
from /var/lib/gems/1.9.1/gems/vmail-2.5.7/lib/vmail/contacts_extractor.rb:23:in block in extract' 	from /var/lib/gems/1.9.1/gems/vmail-2.5.7/lib/vmail/contacts_extractor.rb:13:in open'
from /var/lib/gems/1.9.1/gems/vmail-2.5.7/lib/vmail/contacts_extractor.rb:19:in extract' 	from /var/lib/gems/1.9.1/gems/vmail-2.5.7/lib/vmail/options.rb:80:in block (2 levels) in parse'
from /var/lib/gems/1.9.1/gems/vmail-2.5.7/lib/vmail/options.rb:79:in open' 	from /var/lib/gems/1.9.1/gems/vmail-2.5.7/lib/vmail/options.rb:79:in block in parse'
from /usr/lib/ruby/1.9.1/optparse.rb:882:in initialize' 	from /var/lib/gems/1.9.1/gems/vmail-2.5.7/lib/vmail/options.rb:22:in new'
from /var/lib/gems/1.9.1/gems/vmail-2.5.7/lib/vmail/options.rb:22:in parse' 	from /var/lib/gems/1.9.1/gems/vmail-2.5.7/lib/vmail/options.rb:18:in initialize'
from /var/lib/gems/1.9.1/gems/vmail-2.5.7/lib/vmail.rb:48:in new' 	from /var/lib/gems/1.9.1/gems/vmail-2.5.7/lib/vmail.rb:48:in start'
from /var/lib/gems/1.9.1/gems/vmail-2.5.7/bin/vmail:14:in <top (required)>' 	from /usr/local/bin/vmail:23:in load'
from /usr/local/bin/vmail:23:in `'
Thanks

@notalex what was the fix for this in the end? gmail is currently using sent as the default sent folder name, while [Gmail]/Sent Mail is still the default folder. is there a way to manually override this?

@stefco I have a US Gmail account with a sent folder called "Sent Mail" and I was getting this error on a -g run. I set this in .vmailrc and the -g run worked.
mailbox_aliases:
  sent: Sent Mail
username: ....

This worked, thank you!


Browse-by Subject does not allow to proceed to next pages once filtered

In demo site open "browse by Subject" page : https://demo7.dspace.org/browse/subject
Initially browsing to Next and Previous pages work.
As soon as start point is set e.g. letter "C", navigation buttons have no effect.
Expected:
At least navigation to Next pages should work.
P.S.  In Browse-by Title Previous/Next functions both work after setting start point.

Yes, I can reproduce this.  It appears that currently the letters act as a "filter" instead of jumping you to a page.  So, clicking "C" filters you to every subject starting with "C".  If there are more than 20 subjects starting with "C", you will be able to go to the next page. However, on that next page you'll just see more subjects starting with "C", and there's no way to move on to "D" or later letters.
So, this is a bug or a usability issue.  If these letters are meant to act as "filters", then it must be made more clear (e.g. "Browsing by Subject starting with 'C'") AND there must be a way to go back to the full list of subjects.  If these letters are meant to jump you to a letter within the list, then they must stop acting like filters.

This will take an estimated 6 hours to fix


[WORKAROUND] W/A for issue #1956 - address likely computations issues in Col2Im3dGPU when workspace size > 4GiB.

W/A for issue #1956.
By-products:

Logging improvements

[debug][MIOpenDriver] Quiet logging during computation of reference on GPU
[debug][tests] Always enable naive solvers and quiet logging for computation of reference on GPU
[debug] Improve logging in *GetWorkspaceSize()

[NFC] Fix build warnings in conv2d/3d_bias (unused variable)

[Attribution] @junliume @johnny-keker https://github.com/ROCmSoftwarePlatform/MIOpen/labels/bug https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_high https://github.com/ROCmSoftwarePlatform/MIOpen/labels/workaround

@junliume @johnny-keker Can you please restart CI, thanks!

@junliume There is a full-blown fix in #1966. I do not know its ETA (and didn't tested it yet).
We can merge this as is and then remove WORKAROUND_ISSUE_1956 in #1966 or, alternatively, just close this PR and wait for #1966 to be ready. Decision is up to you.

@junliume Update: Added regression test. Let's merge this as is and then remove WORKAROUND_ISSUE_1956 in #1966.
/cc @zjing14

@atamazov can we close this one since #1966 is merged?

@junliume No, as it has some useful enhancements. Let me update the PR.
[Attribution] New labels: https://github.com/ROCmSoftwarePlatform/MIOpen/labels/enhancement https://github.com/ROCmSoftwarePlatform/MIOpen/labels/debugging https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_normal

@junliume @zjing14 Ready for review & CI testing!


Introduce a gate/check GHA job

This adds a GHA job that reliably determines if all the required dependencies have succeeded or not.
It also allows to reduce the list of required branch protection CI statuses to just one — check. This reduces the maintenance burden by a lot and have been battle-tested across a small bunch of projects in its action form and in-house implementations of other people.
I was curious about the spread of use. And I've just discovered that it is now in use in aiohttp (and other aio-libs projects), CherryPy, some of the Ansible repositories, all of the jaraco's projects (like setuptools, importlib_metadata), some PyCQA, PyCA and pytest projects, a few AWS Labs projects (to my surprise). Admittedly, I maintain a few of these but it seems to address some of the pain folks have: https://github.com/jaraco/skeleton/pull/55#issuecomment-1106638475.
The story behind this is explained in more detail at https://github.com/marketplace/actions/alls-green#why.

master is now red: https://github.com/python-attrs/attrs/actions/runs/3128734322/jobs/5076983674

📝 coverage → ⬜ skipped [required to succeed]

If it is okay to be skipped, it should be in allow-skips. This param can be templated based on the event context.

Well, pls fix? 😇

Well, pls fix? :innocent:

I just looked into it closer and discovered that in previous commits, the coverage job runs. Here's the previous one: https://github.com/python-attrs/attrs/actions/runs/3080585434/jobs/4978137502.
In the last commit, it was skipped: https://github.com/python-attrs/attrs/actions/runs/3128734322/jobs/5076983456. This is because building docs in this job https://github.com/python-attrs/attrs/actions/runs/3128734322/jobs/5076948250 failed. And it most likely failed because of flaky network (there's no visual proof of this but I assume that Sphinx may have failed to fetch bits of the intersphinx objects file).
That said, the status for the branch would show up red even without this patch. It just added an explicit additional red cross icon but that's about it.
@hynek I think if you restart that failing py310 job (you can now restart a single job in GHA), the red status would clear out and become green.
Back to changing the checks settings. Do you actually want skipped/unmeasured coverage on pushes to main? If so, I can make a PR. But I was under an impression that you would prefer the jobs to be green.
Also, you may want to add if: always() to the coverage job so that it'd publish some artifact even in the case of failure. Doing so won't affect the overall workflow status unlike adding continue-on-failure: true.
So which way do you want to go? I'll make a PR if you still want it.

I assume that Sphinx may have failed to fetch bits of the intersphinx objects file

By the way, a “cure” to this would be pre-caching the intersphinx files in Git — this way Sphinx would be able to link external references even when running offline.

On phone so seeing only like 50%, but since restart failed too: could it be that some update of something broke it?

could it be that some update of something broke it?

Looks like it: https://github.com/python-attrs/attrs/pull/1030#issuecomment-1259611491.

Filed https://github.com/python-attrs/attrs/issues/1031 for more transparent tracking.

OK finally back at the keyboard and I think this needs more love and I want to run it by you first.
For me the big upside of this is to not have to click around in the UI. This is interesting when e.g. 3.12beta1 comes out and I want to allow it to break.
What would be the best way to achieve that? Just keep it out of coverage?

What would be the best way to achieve that? Just keep it out of coverage?

Depending on what you want, you could have if: always() on the coverage job. If the failing Python 3.12 job still produces coverage, this might be useful. Or you could have a continue-on-error: ${{ contains(matrix.python-version, 'beta') && true || false }} in the tests matrix definition. This is something I've been doing in Cheroot: https://github.com/cherrypy/cheroot/blob/e0dd9cb/.github/workflows/ci-cd.yml#L524-L537 (except it now uses a leading tilda syntax to achieve the same pre-release or the first final). The latter gives you more granular control. You could also add an experimental factor into the matrix and maintain an explicit list of things that are okay to fail. When a job has continue-on-error, GitHub shows a red status (just visually) for that job if it fails, but it sets success for the whole job matrix if other jobs succeed.
continue-on-error can also be applied to an individual step, in which case the job status won't be red if that step fails, but the step itself will be marked as red in logs. Other implications are about the same.
So to answer the second question — no, you don't need to maintain a separate job definition just for that case. I'd advise against it because of extra unnecessary burden bundled with such a solution.
Note that GitHub's ${{ needs }} context does not contain details of individual jobs if they are matrix definitions — just the overall outcome. This is why it's not implemented as an action input.


{AKS} add static egress gateway related cli

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create <CLUSTER_NAME> --enable-static-egress-gateway
az aks update <CLUSTER_NAME> --enable-static-egress-gateway
az aks update <CLUSTER_NAME> --disable-static-egress-gateway
az aks nodepool add <NODEPOOL_NAME> --mode Gateway --gateway-prefix-size 31

General Guidelines

[x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[x] My extension version conforms to the Extension version schema

For new extensions:

[x] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

AKS

Please fix CI issues

Please fix CI issues

fixed, it was due to not up-to-date recording file.


Invalid behavior of Component Extension SetActive

XRTK - Mixed Reality Toolkit Bug Report
Describe the bug
XRTK's component extension SetActive
public static void SetActive(this Component component, bool isActive)
        {
            if (component.gameObject.activeInHierarchy != isActive)
            {
                component.gameObject.SetActive(isActive);
            }
        }

is error prone and it differs from people would expect when setting a GameObject active / inactive. activeInHierarchy  is not the same as activeSelf. If an object is not activeInHierarchy  but activeSelf calling SetActive(false) using this extension will result in the object not being set to inactive.

It's a lot easier to set a component active/inactive using the enabled property.
This extension method was meant to be used purely to enable/disable the game object that the component is attached to.

Yes, but enabled is again a whole different story.
"This extension method was meant to be used purely to enable/disable the game object that the component is attached to."
Exactly, and that is what it is failing to do.

IF the parent game object is disabled but the game object that it is attached to is not, then SetActive(false) won't disable it.

The fix would be:
if (component.gameObject.activeSelf != isActive)
            {
                component.gameObject.SetActive(isActive);
            }

Makes sense to me. Thanks for catching this! 🙏


OCPBUGS-36587: Filter ip family in router service controller

Which issue(s) this PR addresses:

Closes #

/hold
Need to rebase to main after https://github.com/openshift/microshift/pull/3579 merges

/hold cancel

/jira refresh

/test verify

/label qe-approved
1.
% oc get node
NAME                                             STATUS   ROLES                         AGE     VERSION
i-0398ce375a93861c5.us-west-2.compute.internal   Ready    control-plane,master,worker   8m27s   v1.30.2
% oc debug node/i-0398ce375a93861c5.us-west-2.compute.internal

2.
sh-5.1# ip address | grep "inet6 " | egrep -v "::1|fe80"
    inet6 2600:1f14:d19:8c00:ec8b:c697:5f1a:1b63/128 scope global dynamic noprefixroute
sh-5.1# ip address | grep "inet " | egrep -v "127|169"
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global dynamic noprefixroute eth0
    inet <IP_ADDRESS>/32 scope global br-ex
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global ovn-k8s-mp0
sh-5.1#

3.
% oc -n openshift-ingress get svc
NAME                      TYPE           CLUSTER-IP     EXTERNAL-IP                         PORT(S)                      AGE
router-default            LoadBalancer   <IP_ADDRESS>   <IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>   80:30503/TCP,443:31130/TCP   9m19s
router-internal-default   ClusterIP      <IP_ADDRESS>   <none>                              80/TCP,443/TCP,1936/TCP      9m19s
%


Bonds not displayed

After compiling
class tikz(Scene):
    def construct(self):
        testobject = ChemObject("-[:30](=[2]O)-[:30]OH")
        self.play(Write(testobject))
        self.wait(3)

the resulting image looks like compiled by pure manim:

Works for me though:

Could you show the .tex file, please?

Of course I forgot the minus sign...
corresponding .tex-file:
\documentclass[preview]{standalone}

\usepackage[english]{babel}
\usepackage{amsmath}
\usepackage{amssymb}
\usepackage{dsfont}
\usepackage{setspace}
\usepackage{tipa}
\usepackage{relsize}
\usepackage{textcomp}
\usepackage{mathrsfs}
\usepackage{calligra}
\usepackage{wasysym}
\usepackage{ragged2e}
\usepackage{physics}
\usepackage{xcolor}
\usepackage{microtype}
\usepackage{tikz}
\usetikzlibrary{arrows}
\usetikzlibrary{shapes.geometric}
\usepackage{chemfig}
\usepackage{mhchem}
\DisableLigatures{encoding = *, family = * }
%\usepackage[UTF8]{ctex}
\linespread{1}

\begin{document}

\begin{align*}
\setchemfig{atom sep = 2em}
\chemfig{-[:30](=[2]O)-[:-30]OH}
\end{align*}

\end{document}

I don't see anything wrong with it at a short glance.

Update: After some messing around, I found out that the compilation from .dvi to .svg failed. This issue could be resolved by using \documentclass[preview,dvisvgm]{standalone} in the preamble. Now, the .svg file is generated correctly.
However, afterwards, this .svg file is not inserted into the video/image correctly, as seen here (code below):

This appears to be a general manim problem, though, which is why I opened an issue on 3b1b/manim.
As this problem does not occur in your case, I am assuming that it only happens on linux-based operating systems.
Code for image above:
from manimlib.imports import *

class TikzMobject(TextMobject):
    CONFIG = {
        "stroke_width": 3,
        "fill_opacity": 0,
        "stroke_opacity": 1,
    }

class ExampleTikz(Scene):
    def construct(self):
        circuit = TikzMobject(r"""
            \begin{tikzpicture}
                \draw (0,0) -- (1,0);
                \node at (1,0) {sometext};
            \end{tikzpicture}
            """
            )
        self.play(Write(circuit))
        self.wait()


Negative daily active cases

Describe the bug
Negative daily active counts are shown in the spread trends,
we can not have any number less than 0.
Ex:
The Active cases on 16th May is '-100883', previous day difference is '-44895'

We can not have -100883 as daily count.
To Reproduce
Steps to reproduce the behavior:

Go to https://www.covid19india.org
Click on 'Daily' tab in 'spread trends' and select 'India' from drop down
Scroll down to 'Active Chart(blue)'
See negative daily counts from May 10th to 16th

Expected behavior
Daily counts should always be a whole number [>=0]
Screenshots

Desktop (please complete the following information):

OS: OSX 11.2
Browser [safari]
Version [14]

Refer to https://github.com/covid19india/covid19india-react/issues/2038#issuecomment-641962963

Referred to that comment, from that comments, only delta will be negative but not daily reported active cases.
This issue is not related to that!


[Reference] freshness project: Profile (az account, az login)

This PR is part of the reference refresh project.  This PR focuses on src/azure-cli/azure/cli/command_modules/profile/_help.py and any related file containing summaries or examples for these same command groups.
The updates in this PR are intended to freshen the following reference areas:

short-summary
long-summary
examples

Note: The testing of all examples is out of scope for this project and is part of the Content Quality Automation crew project.
This is work item https://dev.azure.com/mseng/TechnicalContent/_workitems/edit/1998772.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Reference

@Jiasli, do I understand correctly that autogen content can only handle one line per code block?  These are separate lines in the PY.

Link to https://github.com/Azure/azure-cli/pull/24332

@dbradish-microsoft, this is because one line break is converted to space in a > context:
  text: >
    az account show --query name
    az account show --query user.name

If you want to make a line break, use
  text: >
    az account show --query name

    az account show --query user.name

Also, you may use |:
  text: |
    az account show --query name
    az account show --query user.name

I am giving the methodology for freshening azCLI autogen reference content, and consequently this PR, a necessary ending in order to make way for new beginnings.


error

i am getting phishing detcted when i try to click on my dhamil plug in

Can you provide some link, I am not familiar with dhamil plugin.


[RUS-13] Implement task slide over with adding/editing/moving task options

https://linear.app/rust-kanban-board/issue/RUS-13/add-task-slide-over-for-details


feat(testing): dialog testing helpers

This PR adds support to assert dialog views.
Controller method
public function create()
{
    return hybridly('chirps.create')->base('chirps.index');
}

Test helper
First argument would be the dialog view component that should be asserted.
assertHybridDialogView('chirps.create');

You can also pass the base url as second argument.
assertHybridDialogView('chirps.create', route('chirps.index'));

Refactored this to add a single assertHybridDialog macro that can test everything at once:
$response
        ->assertHybridView('test.page')
        ->assertHybridUrl('http://localhost/test/dialog')
        ->assertHybridDialog(
            baseUrl: 'http://localhost/test/page',
            view: 'test.dialog',
            properties: [
                'foo' => 'bar',
            ],
        );

I can't seem to make the "properties" test pass though, they're always empty. Need to investigate.

I ended up changing basically everything, but thanks for kickstarting the feature!