Add "external diff" command to SCM groups and files

Adds an "External Diff" command to launch the configured git difftool for various selections of files:

Run command directly: All modified files
"Staged Changes" or "Changes" group context menu: All modified files in that group
Source Control file context menu: The selected files

Can handle a file having both staged and unstaged changes - only the selected diff (or two diffs - one for each file if both are selected) will be shown.

I think I covered all the changes and switched the branches right. GitHub wouldn't let me change my end so its still master but the pull request should be against your develop now.

Thank you!!!


Update build config

Does this PR build break?

Codecov Report

Merging #33 into master will increase coverage by 0.56%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #33      +/-   ##
===========================================
+ Coverage     64.53%   65.1%   +0.56%
- Complexity        0     149     +149
===========================================
  Files            15      15
  Lines           736     748      +12
  Branches        116      99      -17
===========================================
+ Hits            475     487      +12
  Misses          224     224
  Partials         37      37

Impacted Files
Coverage Δ
Complexity Δ

.../plugins/pollmailboxtrigger/mail/utils/Logger.java
72.22% <0%> (-0.76%)
5% <0%> (+5%)

...ollmailboxtrigger/mail/utils/MailWrapperUtils.java
67.02% <0%> (+0.7%)
0% <0%> (ø)
:arrow_down:

...plugins/pollmailboxtrigger/PollMailboxTrigger.java
64.96% <0%> (+0.94%)
35% <0%> (+35%)
:arrow_up:

...kinsci/plugins/pollmailboxtrigger/SafeJenkins.java
60.6% <0%> (+5.43%)
12% <0%> (+12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bdc149...4c75d6a. Read the comment docs.


Composer: Uncaught Error: Class 'DBSync\DbSync' not found

Hi, I'm completely new to composer, so I do not know if this is an issue with how db-sync is configured or how I use composer. I suspect it's the latter, but anyhow it could be an idea to include the answer in the README for other composer newbies.
When I do new DBSync() I get a fatal error. Here is a quick test of what I'm doing:
<?php
require __DIR__ . '/vendor/autoload.php';

use DbSync\Hash\ShaHash;
use DBSync\DbSync;

new ShaHash();
new DBSync(); // this fails with Class 'DBSync\DbSync' not found in /.../sync/sync.php:8
?>

Note that the new ShaHash(); line seems to work just fine.

Try correcting the capitalization:
use DbSync\DbSync;
new DbSync();

Damn! I completely missed that. Thanks @nztim

For future reference:
#!/usr/bin/php

<?php

	require __DIR__ . '/vendor/autoload.php';

	use DbSync\DbSync;
	use DbSync\Transfer\Transfer;
	use DbSync\Hash\ShaHash;

  	$sync = new DBSync(new Transfer(new ShaHash()));
	$sync->dryRun();
        ....
?>

Thanks for the comments guys, I'm glad you got it working.
I've updated the readme with the use statements - hope that helps!


tryAcquire waits the entire timeout if the semaphore key is not already in redis

var semaphore = redissonClient.getSemaphore("accessTokenSemaphore");
var got = semaphore.tryAcquire(10, TimeUnit.MINUTES);

Using the above code, if the key 'accessTokenSemaphore' is not already in the redis cache, tryAcquire will wait the entire 10 minutes before returning false. After which I add some data to redis using:
RBucket<SerializableToken> tokenCacheBucket = redissonClient.getBucket("token");
var token = tokenCacheBucket.get();

if (token == null || token.getAccessToken() == null || token.getExpiryEpoch() <= System.currentTimeMillis()) {
    token = getToken();
    tokenCacheBucket.set(token);
}

The second attempt at tryAcquire adds the key to Redis and returns true immediately. Am I missing something or doing something wrong? Thank you,

I can confirm this issue with a new semaphore, might be caused by https://github.com/redisson/redisson/blob/master/redisson/src/main/java/org/redisson/RedissonSemaphore.java#L335

After more investigation you sould ensure that permits are correctly set, otherwise it blocks.
Adding RSemaphore#trySetPermits(1) fixed the issue for the semaphore creation.

in your case RSemaphore.trySetPermits() or RSemaphore.setPermits() methods should be called before attempting an acquisition.


Feature: How do I determine if it is a vendored release and where to report issues?

[x] I have read the CONTRIBUTING guidelines

Feature request
I had the following issue:
$ sdk install tomcat 8.5.73

Downloading: tomcat 8.5.73

In progress…

#### 100.0%

Installing: tomcat 8.5.73
Done installing!

Setting tomcat 8.5.73 as default.
$ find $SDKMAN_DIR/candidates/tomcat/8.5.73/bin/*.sh | xargs stat -f '%Lp %N'
644 /Users/dev/Library/sdkman/candidates/tomcat/8.5.73/bin/catalina.sh
644 /Users/dev/Library/sdkman/candidates/tomcat/8.5.73/bin/ciphers.sh
644 /Users/dev/Library/sdkman/candidates/tomcat/8.5.73/bin/configtest.sh
644 /Users/dev/Library/sdkman/candidates/tomcat/8.5.73/bin/daemon.sh
644 /Users/dev/Library/sdkman/candidates/tomcat/8.5.73/bin/digest.sh
644 /Users/dev/Library/sdkman/candidates/tomcat/8.5.73/bin/setclasspath.sh
644 /Users/dev/Library/sdkman/candidates/tomcat/8.5.73/bin/shutdown.sh
644 /Users/dev/Library/sdkman/candidates/tomcat/8.5.73/bin/startup.sh
644 /Users/dev/Library/sdkman/candidates/tomcat/8.5.73/bin/tool-wrapper.sh
644 /Users/dev/Library/sdkman/candidates/tomcat/8.5.73/bin/version.sh

Notice the permissions are wrong: 644 instead of 744 or 755 (depending on if the umask is taken into account or not). -- Note: This is not what this issue is about!
I was unsure where to report an issue:

https://github.com/sdkman/sdkman-cli
did not seem right if it was a vendored release
https://github.com/sdkman/vendor-release
does not seem right either
https://sdkman.io/vendors
does not state how to report issues with vendored releases
https://github.com/apache/tomcat
I am not sure if they have been ones doing the vendoring
$ sdk list
does not state whether it is vendored or not, neither where to report issues

This seems related to https://github.com/sdkman/sdkman-cli/issues/974
BTW, artifacts for all candidates/versions are hosted by their vendors (Apache in this particular case)

@sdavids, that's right, just as @hgeraldino says. These binaries are downloaded directly from Apache archives, and we redirect curl to their download location.
The problem has been reported numerous times before and should be reported directly to the Tomcat team. Hopefully, if enough people complain about this, they will do something about it. Feel free to mention me on the issue if you report this on Github.
I'll close this issue for now. In future, please follow the contributor guidelines and use the provided template.

Notice the permissions are wrong: 644 instead of 744 or 755 (depending on if the umask is taken into account or not). -- Note: This is not what this issue is about!
$ sdk list
does not state whether it is vendored or not, neither where to report issues

Why is this issue being closed?
This issue is about improving sdk list or having something like sdk describe.
The output would at least state that this is a vendored release.
Ideally it would state where it has been vendored from and/or a link to their homepage/GitHub/GitLab page.

@sdavids please read the contributor guidelines which will tell you all you need to know about the process we follow. This process was put in place to help us triage real issues and feature requests, which means we have to spend less time working through a stack of GH issues over weekends. Hope that makes more sense now.

I have updated the title and added the
- [ ] I have read the [CONTRIBUTING guidelines](CONTRIBUTING.md)

**Feature request**

In front of my existing text.
This is according to your template:
<!-- Thank you for suggesting a new feature. Please consider discussing your idea in our Slack channel before requesting a new feature. -->

- [ ] I have read the [CONTRIBUTING guidelines](CONTRIBUTING.md)

**Feature request**
<!-- A clear and precise description of what new or changed feature you want. Please include the reason, why you would need the feature. E.g. what problem does it solve? Or which workflow is currently frustrating and will be improved by this? -->

I hope you are happy now.
Thank you for considering my request.

@sdavids my intention is not to sound rude, and sorry if I came across abrupt in any way.
The problem here is that I see no distinct feature request, just an observation, question, and a dump about some permissions issues.
In order to formulate a proper feature request, let's discuss it on Slack (as per our guidelines) so we can help distil this into something concrete and deliverable.

I understand your sentiment but please update your template(s) if it is required:

In particular, we require a conversation to happen on our community Slack before opening GH issues here.
<!-- Thank you for suggesting a new feature. Please consider discussing your idea in our Slack channel before requesting a new feature. -->

"Please consider" ... is different from ... "we require"
But no point in arguing, sdkman is a useful tool.
Opinions differ.
Communication is hard.

Indeed, very hard :smile:
Point taken and I've updated the feature request template as per your suggestion.


Add libGDX Test

To test further issues, it would be very helpful to have a libGDX based test to simulate game movement. I have reconfigured the project as a multi-project build, added libGDX/ShapeDrawer to the Test project, and created a simple World with interactive Entities.

Absolutely agree that there should be some tests, and using libGDX makes sense. There's a .iml file in here, somehow; I'll see if I can remove it, since it's IDEA-specific.

Eek! Sorry about that.
On Thu, Jul 2, 2020, 9:04 PM Tommy Ettinger<EMAIL_ADDRESS>wrote:

Absolutely agree that there should be some tests, and using libGDX makes
sense. There's a .iml file in here, somehow; I'll see if I can remove it,
since it's IDEA-specific.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tommyettinger/jbump/pull/3#issuecomment-653332100,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADCZLPHGAKGENRHRGAGC66TRZVKDNANCNFSM4OPKUGBA
.


[Sluggable] Consider validating unique and updatable

I had my slug annotation like this:
@Gedmo\Slug(fields={"name"}, updatable="false")

(incorrectly with quotes around the value) and the library did not pick up that this was invalid and then in
<?php

if ($options['updatable']) {
    $this->generateSlug($ea, $object);
}

It always evaluates to true.
So I guess it just needs a check somewhere to check that it is indeed a boolean.

Note that Doctrine Common 2.2 (still in beta) is now able to validate such things if the annotation class provide the needed information

OK - this would be the same sort of thing that Symfony2 does then because I thought that validated such things as booleans within the annotation.
So should we provide a rudimentary implementation within the library for now that can check the types or is 2.2 close enough that we should wait and the library might be updated for 2.2?

@jonathaningram the validation is implemented in Doctrine Common, but it requires some changes to the annotation classes (to tell the Reader how to validate them). If you are using Doctrine ORM master, their annotation are indeed validated by the reader.

Thanks. Yeah I understand that the actual validation class would say "this is a boolean", etc. - similar to Symfony2.
In fact it looks like I am using masters:
[doctrine-common]
    git=http://github.com/doctrine/common.git
    version=origin/master

[doctrine-dbal]
    git=http://github.com/doctrine/dbal.git
    version=origin/master

[doctrine]
    git=http://github.com/doctrine/doctrine2.git
    version=origin/master

[gedmo-doctrine-extensions]
    git=http://github.com/l3pp4rd/DoctrineExtensions.git

[DoctrineExtensionsBundle]
    git=http://github.com/stof/StofDoctrineExtensionsBundle.git
    target=bundles/Stof/DoctrineExtensionsBundle
    version=origin/master

Maybe the gedmo-doctrine-extensions dep needs a different version - would you suggest using master?
P.S. I've had to use master for quite a lot of my deps even though I know it can be risky.

the Gedmo annotations are not yet updated to sue this validation, which is why this issue is still opened


[Doc] Fix typo in arg_utils.py

Fix typo in the help message of the "--max-cpu-loras" argument. It should be ">= than max_loras".

@DarkLight1337 Thanks for approving. The entrypoints-test failed. But I don't think it's caused by my changed. Could you please rerun the entrypoints-test and merge the PR? Thanks.


Fix MSVC compiler error when address sanitizers are enabled

The ABSL_ADDRESS_SANITIZER_REDZONE macro specifies the alignment of the name struct with a non-portable alignment attribute. When address sanitizers on MSVC are enabled, compiles will fail on this line as a result. Since alignas has been supported since C++11, I believe this should be a straightforward substitution.

Thank you. I'm just trying to verify that no one is using this from C code, which might take a day. Assuming that is the case I'll merge this as is. Otherwise we might need a small tweak.

Thanks!


Update graduation status

Added graduation status file, please update.
For process, please refer to here:
https://github.com/IBMStreams/administration/wiki/Project-Incubation-Process

Updated to reflect current state.


Need to update package.json with bluebird

I am able to use your module.  Nice work with this!  Better than socket.io by orders of magnitude!
But initially I got this error.  After I added bluebird to my own package.json it worked fine.
Error: Cannot find module 'bluebird'
at Function.Module._resolveFilename (module.js:339:15)
at Function.Module._load (module.js:290:25)
at Module.require (module.js:367:17)
at require (internal/module.js:20:19)
at Object. (C:\devel\dov\node_modules\express-longpoll\index.js:2:15)

Oh whoops,. Thanks a ton, I would have never found out about that till you mentioned it!


update changelog with latest changes (v8)

Are the changelogs always the commit messages of the intervening commits? I shall bear this in mind when writing messages if so.

 It will just inform my commit and commit message strategy knowing that. Thanks.

Are people happy that the changelog accurately describes the commits?

I know it's trivial but @joefitter @lennym @easternbloc can I get an approval please?


New package: OpenBoxLab.RaiDrive version 2023.9.32

Microsoft Reviewers: Open in CodeFlow

It's an MSI installer. The problem is that a device driver gets installed which is an undocumented dependency. I have asked the publisher now how to solve this.

I am closing this pull request because the publisher has promised a fix for the silent installation issue in a soon-to-be-released new version.
Regarding the dependency on the package Microsoft.VCRedist.2015+.arm64 which is not available in WinGet, in case everything else works by then, I will bite the bullet and submit the manifest for it.


How to get the custom data added to the action on custom feeds

Hi,
Is there any way to get the custom data (json field) added to the action on Custom Feeds ?
As far as I can get from the code one way is to alter the function "format" in AbstractActivityStream . I think one can easily detect if the user is using the field using the setting ACTSTREAM_SETTINGS['USE_JSONFIELD'] and thus including it.
Best,

what custom data are you planning to add and to which field in the feed (atom or json) are you planning to add it? adding custom named fields to the atom/json feeds would violate the specifications so im wondering what you are planning to add and whether it adheres to the spec

I mostly use django as a backend. Let´s say I need to use the custom data as described in the documentation on a Custom JSON feed. I am not sure if it complies with the standard, but its a functionality offered by the package non accessible in JSON feeds.
For my use case I decided to override the function "format" in AbstractActivityStream and just include it. I wonder if there is way to include it in feeds and comply with the standard.
Excellent package !

yea overriding format is the best approach. i dont think the base implementation will change to account for custom data as that might break the spec and it's also not a requirement of the app. having some docs on what you went through to make it happen would be helpful though. could you write up a quick guide?

Yes, sure. Ill paste it here. It is basically overriding all classes to get to AbstractActivityStream and add the extra key to the dictionary (error detection is not done). Maybe something shorter can be done but I preferred the verbose approach

Follow the instructions to add custom data
Define a package activity or your preferred name
Override AbstractActivityStream (activity/feeds.py)

import json

from django.http import HttpResponse
from django.views.generic import View
from django.utils.feedgenerator import rfc3339_date
from django.utils.six import text_type

from actstream.feeds import AbstractActivityStream,CustomStreamMixin

class MyAbstractActivityStream(AbstractActivityStream):
    def format(self, action):
        """
        Returns a formatted dictionary for the given action.
        """
        item = {
            'id': self.get_uri(action),
            'url': self.get_url(action),
            'verb': action.verb,
            'published': rfc3339_date(action.timestamp),
            'actor': self.format_actor(action),
            'title': text_type(action),
        }
        if action.description:
            item['content'] = action.description
        if action.target:
            item['target'] = self.format_target(action)
        if action.action_object:
            item['object'] = self.format_action_object(action)
        if action.data:
            item['data'] = action.data

        return item

class MyJSONActivityFeed(MyAbstractActivityStream, View):
    """
    Feed that generates feeds compatible with the v1.0 JSON Activity Stream spec
    """
    def dispatch(self, request, *args, **kwargs):
        return HttpResponse(self.serialize(request, *args, **kwargs),
                            content_type='application/json')

    def serialize(self, request, *args, **kwargs):
        items = self.items(request, *args, **kwargs)
        return json.dumps({
            'totalItems': len(items),
            'items': [self.format(action) for action in items]
        }, indent=4 if 'pretty' in request.REQUEST else None)

class MyCustomJSONActivityFeed(CustomStreamMixin, MyJSONActivityFeed):
    """
    JSON feed of Activity for a custom stream. self.name should be the name of the custom stream as defined in the Manager
    and arguments may be passed either in the url or when calling as_view(...)
    """
    pass

Optionally define a manager(activity/managers.py)

from datetime import datetime

from django.contrib.contenttypes.models import ContentType
from django.shortcuts import get_object_or_404

from actstream.managers import ActionManager, stream
from actstream.registry import check

class MyActionManager(ActionManager):

    @stream
    def mystream(self, content_type_id,object_id,**kwargs):
        obj_content = get_object_or_404(ContentType, pk=content_type_id)
        obj = obj_content.get_object_for_this_type(pk=object_id)
        return obj.target_actions.public(**kwargs)

5.Add a url
from activity.feeds import MyCustomJSONActivityFeed
url(r'^feed/history/(?P<content_type_id>\d+)/(?P<object_id>[^/]+)/json/$',
    MyCustomJSONActivityFeed.as_view(name='mystream')),

the data is in the right place but needs to be added to the xml feed using django's syndication framework. try looking into how it works in actstream/feeds.py: https://github.com/justquick/django-activity-stream/blob/master/actstream/feeds.py#L143

Thanks, I forgot to mention I only use json feeds so the former works well.


Ender IO & Ender Zoo Requesting Endercore ??

It seems that now my minecraft wont start anymore
without me installing something called 'Endercore v1.7.10-<IP_ADDRESS>_alpha'
Last night the game started fine, and played for hours.  The only mods I remember updating are whats in this picture.
http://i.imgur.com/o4igkVc.png
today its now requesting endercore .... Im a bit confused...
I went to the curse download pages & Ender-IO official website to find such file, nothing there.
I am using Ender Io v1.7.10-<IP_ADDRESS>1 - & - EnderZoo v1.7.10-<IP_ADDRESS> & Forge 448.
Also - Ender Utilities v0.4.1 - EnderTech v1.7.10-03.2.386 - Ender Compass v1.1 & EnderStorage v<IP_ADDRESS>
The reason why I posted every mod im using regarding 'Ender', is to notify you of everything I am using regarding Ender.
Picture Below.
http://i.imgur.com/r1dOhRP.png

Please don't lie to us.
If you only did what you said you did, this absolutely can not happen.
If you updated mods, you should know, which ones you updated and why.
Before you clear your head and start speaking truth, …

Actually this can happen. You updated WAILA Plugins, the changelog for which clearly states that it has moved to use EnderCore. For now the only place to get it is jenkins. Though I'd suggest you hold off on updating if you aren't using dev-channel mod versions.

If he did not do anything at all, other than playing MC and going to sleep through the night, this absolutely can not happen. Computers don't work by magic. If they do something, YOU allowed them to do it.


Why not return while err accord? Anything on purpose？

https://github.com/kelseyhightower/confd/blob/9b0ce8e6bb49eb46f27df33271e5edcc36a09746/resource/template/resource.go#L248

https://github.com/kelseyhightower/confd/blob/9b0ce8e6bb49eb46f27df33271e5edcc36a09746/resource/template/resource.go#L237-L253

Sometimes the destination file doesn't exist, so sameConfig will return an error, but we still want to create and template a destination file afterward.


🦅 Better CLI Output

Type of change

[x] New features

Changes proposed in this pull request
This commit makes the CLI output of the port scanner look better
Checklist

[x] The code is Python 3 compatible
[x] I have added relevant comments in my file to make code understandable

Fixes #2


Garbage collection does not work with certain types stored in the Engines

I've just opened up a draft PR #5813 with a new test called garbage_collection_storage that is able to reproduce this. Running the test produces the following stack trace.
running 1 test
thread 'thread 'thread '<unnamed><unnamed><unnamed>' panicked at ' panicked at ' panicked at sway-core/src/concurrent_slab.rssway-core/src/concurrent_slab.rssway-core/src/concurrent_slab.rs:90:14:
no entry found for key
:90:14:
no entry found for key
:90:14:
stack backtrace:
no entry found for key
   0: rust_begin_unwind
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/panicking.rs:647:5
   1: core::panicking::panic_fmt
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/panicking.rs:72:14
   2: core::panicking::panic_display
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/panicking.rs:196:5
   3: core::panicking::panic_str
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/panicking.rs:171:5
   4: core::option::expect_failed
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/option.rs:1988:5
   5: core::option::Option<T>::expect
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/option.rs:894:21
   6: <std::collections::hash::map::HashMap<K,V,S> as core::ops::index::Index<&Q>>::index
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/collections/hash/map.rs:1341:23
   7: sway_core::concurrent_slab::ConcurrentSlab<T>::get
             at /Users/josh/Documents/rust/fuel/sway/sway-core/src/concurrent_slab.rs:90:14
   8: <sway_core::decl_engine::parsed_engine::ParsedDeclEngine as sway_core::decl_engine::parsed_engine::ParsedDeclEngineGet<sway_core::decl_engine::parsed_id::ParsedDeclId<sway_core::language::parsed::declaration::impl_trait::ImplTrait>,sway_core::language::parsed::declaration::impl_trait::ImplTrait>>::get
             at /Users/josh/Documents/rust/fuel/sway/sway-core/src/decl_engine/parsed_engine.rs:59:17
   9: sway_core::decl_engine::parsed_engine::ParsedDeclEngine::get_impl_trait
             at /Users/josh/Documents/rust/fuel/sway/sway-core/src/decl_engine/parsed_engine.rs:220:9
  10: sway_lsp::traverse::parsed_tree::<impl sway_lsp::traverse::Parse for sway_core::decl_engine::parsed_id::ParsedDeclId<sway_core::language::parsed::declaration::impl_trait::ImplTrait>>::parse
             at ./src/traverse/parsed_tree.rs:772:26
  11: sway_lsp::traverse::parsed_tree::<impl sway_lsp::traverse::Parse for sway_core::language::parsed::declaration::Declaration>::parse
             at ./src/traverse/parsed_tree.rs:127:48
  12: sway_lsp::traverse::parsed_tree::<impl sway_lsp::traverse::Parse for sway_core::language::parsed::AstNode>::parse
             at ./src/traverse/parsed_tree.rs:108:57
  13: sway_lsp::traverse::parsed_tree::ParsedTree::traverse_node
             at ./src/traverse/parsed_tree.rs:53:9
  14: sway_lsp::core::session::traverse::{{closure}}
             at ./src/core/session.rs:424:59
  15: sway_lsp::core::session::parse_ast_to_tokens::{{closure}}
             at ./src/core/session.rs:506:35
  16: core::ops::function::impls::<impl core::ops::function::FnMut<A> for &F>::call_mut
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/ops/function.rs:272:13
  17: <core::slice::iter::Iter<T> as core::iter::traits::iterator::Iterator>::for_each
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/slice/iter/macros.rs:254:21
  18: <rayon::iter::for_each::ForEachConsumer<F> as rayon::iter::plumbing::Folder<T>>::consume_iter
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-1.10.0/src/iter/for_each.rs:55:9
  19: rayon::iter::plumbing::Producer::fold_with
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-1.10.0/src/iter/plumbing/mod.rs:109:9
  20: rayon::iter::plumbing::bridge_producer_consumer::helper
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-1.10.0/src/iter/plumbing/mod.rs:437:13
  21: rayon::iter::plumbing::bridge_producer_consumer::helper::{{closure}}
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-1.10.0/src/iter/plumbing/mod.rs:426:21
  22: rayon_core::join::join_context::call_b::{{closure}}
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-core-1.12.1/src/join/mod.rs:129:25
  23: rayon_core::job::JobResult<T>::call::{{closure}}
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-core-1.12.1/src/job.rs:218:41
  24: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/panic/unwind_safe.rs:272:9
  25: std::panicking::try::do_call
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/panicking.rs:554:40
  26: ___rust_try
  27: std::panicking::try
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/panicking.rs:518:19
  28: std::panic::catch_unwind
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/panic.rs:142:14
  29: rayon_core::unwind::halt_unwinding
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-core-1.12.1/src/unwind.rs:17:5
  30: rayon_core::job::JobResult<T>::call
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-core-1.12.1/src/job.rs:218:15
  31: <rayon_core::job::StackJob<L,F,R> as rayon_core::job::Job>::execute
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-core-1.12.1/src/job.rs:120:32
  32: rayon_core::job::JobRef::execute
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-core-1.12.1/src/job.rs:64:9
  33: rayon_core::registry::WorkerThread::execute
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-core-1.12.1/src/registry.rs:860:9
  34: rayon_core::registry::WorkerThread::wait_until_cold
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-core-1.12.1/src/registry.rs:794:21
  35: rayon_core::registry::WorkerThread::wait_until
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-core-1.12.1/src/registry.rs:769:13
  36: rayon_core::registry::WorkerThread::wait_until_out_of_work
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-core-1.12.1/src/registry.rs:818:9
  37: rayon_core::registry::main_loop
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-core-1.12.1/src/registry.rs:923:5
  38: rayon_core::registry::ThreadBuilder::run
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-core-1.12.1/src/registry.rs:53:18
  39: <rayon_core::registry::DefaultSpawn as rayon_core::registry::ThreadSpawn>::spawn::{{closure}}
             at /Users/josh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-core-1.12.1/src/registry.rs:98:20

Ok I have been able to reproduce this error with the new test consistently within 1-5 did_change events at this commit https://github.com/FuelLabs/sway/pull/5813/commits/348d0080ae314aa6c59a5b3f84b5cf7fb3ca1446
I just rebased onto master and have done 8 successful local runs
1 time it produced the same crash as above, the other 7 times it now handles 600 did_change events with GC on every keystroke without a problem.
Running this test in CI seems to fail everytime still....

Just leaving some more info. It seems that this error occurs when compilation is started and completed successfully, but the TyDecl::type_check function never inserts a TyStorageDecl for some reason.
Compiling project...
Compilation failed ❌
🗑  Garbage collecting 🗑
Compiling project...
Inserting StorageDecl into decl_engine 🤝
Traversing project...
Compilation successful ✅
version: 62
version: 63
🗑  Garbage collecting 🗑
Compiling project...
Compilation failed ❌
version: 64
🗑  Garbage collecting 🗑
Compiling project...
Inserting StorageDecl into decl_engine 🤝
Traversing project...
Compilation successful ✅
🗑  Garbage collecting 🗑
Compiling project...
Traversing project...
thread 'thread '<unnamed>' panicked at sway-core/src/concurrent_slab.rs:90:14:
no entry found for key
<unnamed>' panicked at sway-core/src/concurrent_slab.rs:90:14thread ':
no entry found for key
stack backtrace:
<unnamed>' panicked at sway-core/src/concurrent_slab.rs:90:14:
no entry found for key
   0: rust_begin_unwind
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/panicking.rs:647:5
   1: core::panicking::panic_fmt
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/panicking.rs:72:14
   2: core::panicking::panic_display
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/panicking.rs:196:5
   3: core::panicking::panic_str
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/panicking.rs:171:5
   4: core::option::expect_failed
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/option.rs:1988:5
   5: core::option::Option<T>::expect
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/option.rs:894:21
   6: <std::collections::hash::map::HashMap<K,V,S> as core::ops::index::Index<&Q>>::index
             at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/collections/hash/map.rs:1341:23
   7: sway_core::concurrent_slab::ConcurrentSlab<T>::get
             at /Users/josh/Documents/rust/fuel/sway/sway-core/src/concurrent_slab.rs:90:14
   8: <sway_core::decl_engine::parsed_engine::ParsedDeclEngine as sway_core::decl_engine::parsed_engine::ParsedDeclEngineGet<sway_core::decl_engine::parsed_id::ParsedDeclId<sway_core::language::parsed::declaration::storage::StorageDeclaration>,sway_core::language::parsed::declaration::storage::StorageDeclaration>>::get
             at /Users/josh/Documents/rust/fuel/sway/sway-core/src/decl_engine/parsed_engine.rs:59:17
   9: sway_core::decl_engine::parsed_engine::ParsedDeclEngine::get_storage

Ok I think i'm narrowing in on this. Compilation is returning an old cached AST.
let cache_up_to_date = entry.modified_time == modified_time || {
    let src = std::fs::read_to_string(path.as_path()).unwrap();

    let mut hasher = DefaultHasher::new();
    src.hash(&mut hasher);
    let hash = hasher.finish();

    hash == entry.hash
};

In this instance, we hit the || and load the file from the path into a string and compare. Now, because we actually write into this file from the LSP, the compiler may be have been trigger by a did_change event, and during this the LSP has actually saved a newer copy at this location. This would explain why I originally found this error while rapidly triggering between enter and backspace events.

Ok i've got a fix up now at #5813
turned out to be 3 things

don't load the string from file as above, instead hash the input that was used to kick off compilation
check if the compiler retuned a cached AST for the users workspace, if so, we traverse the AST's with the current LSP version of the engines as it hasn't had garbage collection applied.
Also do the above check in the compilation thread. Only mem swap the engines_clone and engines if a cached AST for the users workspace was not used.


removed elastic demo

Please change the name to a nice an expressive name because it will be in the changelog!


Add ECR Image Scanning reports make targets

This PR is to add some make targets to facilitate ECR image scanning so that reports can be scanned and output to a Pipeline. With the correct input this can also block a pipeline so that docker images with warnings aren't deployed.
This PR is in draft as it still in testing in the DI Pipelines

This has now been tested in a DI pipeline for test evidence I can provide screenshots


Fix to issue #8, UWP Checkbox Control exception

Added null control check to both OldElement and NewElement processing to ensure we don't try to access the control when invalid.

Cool, sorry for merging until now,


dart:io should expose a way to change file attributes

Like the modification time, specifically. We need this for a test in Flutter.

This is becoming a higher priority as we start porting to Windows, where we don't have a workaround currently. (On Linux and Mac we're shelling out to touch.)

/cc @a-siva

I'll take a look at this the week after next when I'm back from vacation.


Reorganize folder structure

This PR reorganizes the existing python/ folder structure for better clarify.

mlc_chat/model <- mlc_chat/compiler/model
mlc_chat/quantization <- mlc_chat/compiler/quantization
mlc_chat/loader <- mlc_chat/compiler/loader
mlc_chat/operator <- mlc_chat/compiler/*_op.py
mlc_chat/compiler_pass <- mlc_chat/compiler/compiler_pass.py
mlc_chat/interface <- mlc_chat/compiler/{compile/gen_config/convert_weight}.py
mlc_chat/runtime <- mlc_chat/chat_module.py and mlc_chat/callback.py

"Operator "is an internal python package which is used in nested imports in mlc_chat python files. "mlc_chat/operator <- mlc_chat/compiler/*_op.py" this change creates a conflict when we try to use the mlc from source by exporting mlc-llm/python to PYTHONPATH

Ah @Nick-infinity thanks for the reminder! Would you love to elaborate what the cycling files are so that i could quickly fix? Thanks a bunch!

Hello,
here is the trace for cyclic dependency
Traceback (most recent call last):
File "/Users/workspace/stacks/mlc-llm/python/mlc_chat/main.py", line 4, in
from mlc_chat.support import logging
File "/Users/workspace/stacks/mlc-llm/python/mlc_chat/init.py", line 5, in
from .chat_module import (
File "/Users/workspace/stacks/mlc-llm/python/mlc_chat/chat_module.py", line 3, in
import inspect
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/inspect.py", line 35, in
import ast
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/ast.py", line 29, in
from contextlib import contextmanager, nullcontext
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/contextlib.py", line 5, in
from collections import deque
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/collections/init.py", line 37, in
from operator import eq as _eq
File "/Users/workspace/stacks/mlc-llm/python/mlc_chat/operator/init.py", line 2, in
from .attention import attention
File "/Users/workspace/stacks/mlc-llm/python/mlc_chat/operator/attention.py", line 4, in
from tvm import tir
File "/Users/workspace/stacks/mlc-llm/3rdparty/tvm/python/tvm/init.py", line 19, in
import multiprocessing
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/multiprocessing/init.py", line 16, in
from . import context
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/multiprocessing/context.py", line 3, in
import threading
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/threading.py", line 6, in
import functools
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/functools.py", line 18, in
from collections import namedtuple
ImportError: cannot import name 'namedtuple' from partially initialized module 'collections' (most likely due to a circular import) (/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/collections/init.py)
It starts from this import
File "/Users/workspace/stacks/mlc-llm/python/mlc_chat/chat_module.py", line 3, in
import inspect
and goes to
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/collections/init.py", line 37, in
from operator import eq as _eq
Now this operator is being picked as mlc_chat operator package from pythonpath instead of system operator package

A simple renaming of mlc_chat operator package fixes it


Add a method to reconstruct the snapshots?

This came up in an email from a user in June 2014. It was only a line or two of code, but requires the user to know more than they would otherwise, both in terms of math and the data variables in the classes (like POD). We should decide if we want to add a method.

Added methods for computing projection coefficients.  So the user can now just use a lin_combine method to get the snapshots back.


Problem when the one approving students do not have the owner attribute of the org

+time="2019-02-14T15:26:17+01:00" level=error msg="POST https://api.github.com/orgs/uis-dat550-spring19/repos: 403 You need admin access to the organization before adding a repository to it. []"

Everyone promoted to teacher now gets owner status in course organization


Crash when using strace

On debian linux sid
Linux mdupont-Aspire-7750G 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux
Running the gui
dogecoin-1.10.0$ ./bin/dogecoin-qt

I downloaded the boostrap.dat using bootstrap.chain.so
and started to load it,

I want to determine if it is loading the boostrap.dat.
mdupont@mdupont-Aspire-7750G:/tmp$ ps xauf | grep doge
mdupont  28798 42.2 23.2 3759416 1869132 pts/5 Sl+  07:54   1:14          |   |   |   \_ ./bin/dogecoin-qt

lsof -p  28798 shows
dogecoin- 28798 mdupont   29r      REG               8,17<PHONE_NUMBER>       3889 /media/mdupont/disk/doge/bootstrap.dat

Now running strace to figure out where the time is going
mdupont@mdupont-Aspire-7750G:/tmp$ strace -f -c -p 28798
strace: Process 28798 attached with 22 threads

Then the process is defunct
mdupont  28798 26.1  0.0      0     0 pts/5    Zl+  07:54   1:39          |   |   |   \_ [dogecoin-qt] <defunct>

Posted on Utopian.io -  Rewarding Open Source Contributors

@patricklodder @rnicoll @michilumin I think we can close this one. Both strace and dogecoin have come a long way. This issue could be opened again if its still relevant. I would suggest closing it at this time.


Gabor/llvm 14

This is still blocked on https://github.com/NixOS/nixpkgs/pull/171942.
Successfully merged:

https://github.com/NixOS/nixpkgs/pull/171556
#3227.

See also #3269!

LLVM 14 adopts the rearchitected dylink.0 proposal: https://github.com/WebAssembly/tool-conventions/pull/170. This means moc's linker needs to be taught about it first.

Addressed by recent RTS upgrade PR.


Add chefspecs to test source.rb

Here is something we can start building upon.
It passes both rubocop and foodcritic tests.

Thanks for these specs and these look like a good start.  In the meantime I'll get this cookbook set up with houndci for syntax comments and travis for running chefspec's.

@tuahk Looks like houndci isn't respecting out rubocop settings for string quotation.  Ignore these warnings for now until we can get it sorted out.

@tuahk It's probably because your branch doesn't have the latest .hound.yml file which references our rubocop file.  Try to add that file to your PR.  It's here: https://github.com/rayrod2030/chef-prometheus/blob/master/.hound.yml

Ok, I'll do that

Looks good.  Merging and thank you!


set 1.3.0 in IntelliJ idea takes about 40 minutes to dump project

steps
sbt version: 1.3.0
problem
although I know that SBT is very slow and hard to use, but
set 1.3.0 in IntelliJ idea takes about more than 40 minutes to dump project, is it an exception or just normal case for SBT ?
expectation
notes

@yinshurman AFAIK sbt 1.3.0 uses a new dependency resolver with own cache directory, but it provides an option to use the previous one, see the following article for details: https://www.lightbend.com/blog/sbt-1.3.0-release

@plokhotnyuk  thanks , follow the doc,I add the line ThisBuild / useCoursier := false, it completed the dump task in 2min !!!!

@yinshurman please also check how much it takes to dump after renaming of cache directory of old resolver from .ivy to .ivy-backup.

I just killed the task after waiting more than 20mins dumping  with ~/.ivy2 renamed to ~/.ivy2-backup, and I checked the directory size of ~/.ivy2-backup, it is more than 2.5G!
It seems that the 2mins completion  is due to the cache, but  i just write the follow spark dependencies,`    libraryDependencies += "org.apache.spark" %% "spark-core" % "2.3.0",
libraryDependencies += "org.apache.spark" %% "spark-sql" % "2.3.0",

libraryDependencies += "org.apache.spark" %% "spark-mllib" % "2.3.0",

libraryDependencies += "com.microsoft.ml.spark" %% "mmlspark" % "0.18.1"`

Yea. so sbt 1.3.0 changed to Coursier to you might need to re-resolve your dependencies. I don't know why that takes 40 minutes unless someone is throttling your network.


Only one menu item should show selected state at a time

Describe the bug
AMPHTML / AMPHTML Ads / AMPHTML email are all selected
To Reproduce
Steps to reproduce the behavior:

Go to https://ampbyexample.com/amphtml-email/introduction/hello_world/

Expected behavior
Only AMPHTML Email should be selected
Screenshots

Desktop (please complete the following information):

OS: Mac
Browser Chrome
Version lastest

Additional context
Add any other context about the problem here.

Thanks for reporting - fixed that one yesterday (deploying right now).


Latest Pdfjs version 2.0.943 issue on load embedded in Javafx web view

Attach (recommended) or Link to PDF file here:
Configuration:
JavaFx desktop application webView with netbeans 8.1
Pdfjs version 2.0.943
I have used the latest version with my Javafx project and able to open any PDF, it's showing error on load of PDFjs.
What is the expected behavior?
It's should open my PDF, but it's showing error
I have also added compatibility.js for this issue but still it exists

Duplicate of #10198.


Prevent re-authentication on Android Platform.

Whenever any of the applications are loaded, they verify the auth_token with the server. In the Android application, this looks like a bit of overhead because every time the user switches options, the token is verified. Can we skip this step when on the android platform ?

I think the problem is that mobile has a higher latency so it is far more noticeable. I don't think it is necessarily the best option since I'd like to avoid the check on the browser extension as well, but I agree that skipping the step on Android is reasonable for the time being.

I was thinking of modifying the initPrivlyService method in network_service.js. Before the ajax request is sent we keep a check to see if the platform is android and if it has been authenticated before. If it is satisfied then we can directly invoke the loggedInCallback. I tried this out and it worked out but it does have a few kinks. Namely, the ajax request loading image is being displayed (could be removed with a simple  $('#loadingDiv').hide(); call) and there is some lag between pressing save and the url being displayed (haven't looked into it yet).
Is this an appropriate approach or should I try something else?

@mkash32 There are subtle timing issues here, since the user won't be able to create content until they have the CSRF token that is returned by this request. I am trying to figure out how to balance expediency of showing the user the content creation forms by default, and the case where the user is not logged in and should be redirected immediately. I don't think adding more case statements for Android is a great solution because it increases complexity where we should just try to mitigate slow connections somehow, maybe by presenting all the form elements by default, but disabling the "submit" buttons until the user is authenticated.

@smcgregor I like the solution you suggested, it would be better for all of the other platforms also. So basically, the user will be able to type in all the content while the authentication is being done in the background. I think the time taken to type a message of average size would be a little more than that of authentication (given a reasonable Internet connection speed). By the time the user is done typing their content, the "Save" button will be enabled (in most cases). It would probably be good to keep some kind of loading indicator next to the save button to communicate to the user that authentication is being done. We could use the same ajax loading gif and place it next to the button.
Frankly, I wasn't that satisfied with the solution I suggested because it was too obtrusive to the flow of privly-applications (therefore a possible source of more bugs), but I thought we were just trying to target the android platform for now, so I wasn't able to find a better option. I'll broaden my solution approach from next time.


feat(command): allow to dump as YAML

Signed-off-by: Raphaël Pinson<EMAIL_ADDRESS>

@tklauser I merged your suggestions and rebased.

@raphink the Travis CI failure looks related: https://app.travis-ci.com/github/cilium/cilium/jobs/567510395. You'll also need to update the cmdref using make -C Documentation update-cmdref and amend the changes.

Indeed. I made the change. The make -C Documentation update-cmdref command fails on me for some reason:
CGO_ENABLED=0 go build -mod=vendor -ldflags '-X "github.com/cilium/cilium/pkg/version.ciliumVersion=1.11.90 8ff680b25e 2022-04-19T16:29:16+02:00" -s -w -X "github.com/cilium/cilium/pkg/envoy.RequiredEnvoyVersionSHA=12e3081cc292764b1308668cab1e7e523429bedc" -X "github.com/cilium/cilium/pkg/datapath/loader.DatapathSHA256=201791d8ad7806dd288f696e44030fbbbeb87aecb2cb099a56f34249e30cdab5" ' -tags=osusergo  -o cilium
package github.com/cilium/cilium/cilium: build constraints exclude all Go files in /home/raphink/src/github.com/cilium/cilium/cilium
make[2]: *** [Makefile:14: cilium] Error 1
make[2]: Leaving directory '/home/raphink/src/github.com/cilium/cilium/cilium'
make[1]: *** [Makefile:131: cilium] Error 2
make[1]: Leaving directory '/home/raphink/src/github.com/cilium/cilium'
make: *** [Makefile:25: cilium-build] Error 2
make: Leaving directory '/home/raphink/src/github.com/cilium/cilium/Documentation'

I made the replacements in the md files manually though, so at least the tests should pass…

Might be that you're using an older Go version. We switched to Go 1.18 recently and the binaries use //go:build go1.18 to ensure we always build using that version.

That was it @tklauser. I launched the Makefile and there was still one change in the docs. It's pushed now.

Hmmmm. I just saw there's still lots of errors that read something like:
fmt.Fprintf(os.Stderr, "error getting output of map in JSON: %s\n", err)

They should probably be more generic, not sure what wording to use.

Hmmmm. I just saw there's still lots of errors that read something like:
fmt.Fprintf(os.Stderr, "error getting output of map in JSON: %s\n", err)

They should probably be more generic, not sure what wording to use.

How about adding GetOutputOpt in pkg/command as follows:
func OutputOptionString() string {
	return outputOpt
}

(or just export outputOpt)
and then us something like:
fmt.Fprintf(os.Stderr, "error getting %s output of map: %v\n", command.OutputOptionString(), err)

for the error messages?

Yes, I was thinking of something like that indeed. I'll try to look into it tomorrow!

I added command.OutputOptionString() and used it as a replacement for static JSON strings in errors.

/test

I suspect that the CI failures may be addressed by rebasing against the latest master branch. Please do so, then we can re-run the CI to make sure that there aren't any remaining tests that could be impacted by the rework of the CLI code.

@joestringer done

/test

/mlh new-flake Cilium-PR-K8s-GKE

Glancing at the output from the failures from the links on the failures and clicking on the individual jobs at the bottom, they match existing flakiness issues that we have seen which you should be able to search in the github.com/cilium/cilium/issues page. Given that this PR is about adding YAML support, and the only failures are random flakes that don't indicate a direct problem with YAML output or CLI getting the wrong formatted output, I believe the failures should be unrelated.

/mlh new-flake Cilium-PR-K8s-1.22-kernel-4.19


Implement podman-remote rm

refactor command output to use one function

Signed-off-by: Jhon Honce<EMAIL_ADDRESS>

/approve

See #2663


When the code will be released ?

inspiring work! when do you plan to upload all the code?

Thanks for you comment, we will release the inference and training code ASAP. The paper is under review.


CaseStudy/SwiftUI/Alerts & ActionSheets Exception on Increment

This occurs using the zip downloaded from this site this week -- out of the box.
On the device (iPhone XS Max iOS 13.6) and in simulator (iOS 13.6, iOS 13.7)
It also occurs using a zip downloaded at the beginning of August.
To Reproduce
Compile "Case Studies (SwiftUI)" scheme using the ComposableArchitecture.xcworkspace
run the example and select "Alert & ActionSheets"
Select Alert, click on the "Increment" button on the alert
This results in an exception.
Expected behavior
Alert to dismiss with counter incremented
This is called twice after tapping on "Increment", the exception occurs after the second .toSwiftUI(send:) call.
 WithViewStore(store, removeDuplicates: { $0?.id == $1?.id }) { viewStore in
     self.alert(item: viewStore.binding(send: dismiss)) { state in
       state.toSwiftUI(send: viewStore.send)
     }
   }

And these lines in the log stand out to me:
SwiftUI`SwiftUI.AlertBridge.preferencesDidChange(SwiftUI.PreferenceList) -> ():
; partial apply forwarder for closure #1 () -> () in SwiftUI.AlertBridge.preferencesDidChange(SwiftUI.PreferenceList) -> ()
` $defer #1 <A, B where A: SwiftUI.View, B: SwiftUI.AlertControllerConvertible, B.Key.Value == Swift.Optional>() -> () in SwiftUI.AlertBridge.preferencesDidChange(SwiftUI.PreferenceList) -> ()
`Screenshots

Environment

Xcode Version 11.7 (11E801a)

Apple Swift version 5.2.4 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)
Target: On the device (iPhone XS Max iOS 13.6) and in simulator (iPhone SE 2nd Generation, iOS 13.6, iOS 13.7)

OS: MacOS Catalina 10.15.6 (19G73)

I just applied the latest Catalina update and the problem remains.

Interesting. Xcode 11.6 and 12 do not appear to have this problem, which leads me to believe it's an Apple bug, especially with that stack trace. We'll file a feedback and think about potential workarounds.

Filed: https://gist.github.com/stephencelis/11746b8acb751d8b57f3528e0d3af603
It's easy to reproduce in vanilla SwiftUI so I don't think we can consider this a TCA bug. I think the workaround is to nil out the alert state and then fire off an effect that will later show the followup increment alert. I'm not sure we want to complicate the demo, though, just for a bug in one version of Xcode.

Thanks for the quick response. Closing.


Added link to video explaining the design

I've created this video to explain how it works on the Lightboard. I thought it would be useful to include it in the Readme file to help understand how it works. https://www.youtube.com/watch?v=TOBGA-ztINM&list=PLpbcUe4chE79sB7Jg7B4z3HytqUUEwcNE&index=1
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

[ ] Test A
[ ] Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.476%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2906

Relevant Lines:
3611

💛  - Coveralls


Add Tung to README

Could you add Tung to "Structuring applications" section?
Thank you.

Definitely :smile:


PUPPETEER_DOWNLOAD_PATH does not support relative paths

Steps to reproduce
Tell us about your environment:

Puppeteer version: 10.4.0
Platform / OS version: Ubuntu 21.04
URLs (if applicable):
Node.js version: v14.17.6

We set the Puppeteer download path in our project's .npmrc. We want to store the downloaded Chromium outside node_modules to avoid downloading it everytime we run "npm ci".
We want to use a relative path to make sure it works for all our users, on both Windows and Linux.
What steps will reproduce the problem?

Set PUPPETEER_DOWNLOAD_PATH with a relative path using an environment variable, npm config or .npmrc.
Install puppeteer

For example:
PUPPETEER_DOWNLOAD_PATH=../bar npx puppeteer

What is the expected result?
Puppeteer downloads Chromium to ../bar.
What happens instead?
The extract-zip library requires an absolute path and throws an Error.
Downloading Chromium r901912 - 140.9 Mb [====================] 99% 0.0s
ERROR: Failed to set up Chromium r901912! Set "PUPPETEER_SKIP_DOWNLOAD" env variable to skip download.
Error: Target directory is expected to be absolute
    at Object.module.exports [as default] (/home/user/.npm/_npx/34327/lib/node_modules/puppeteer/node_modules/extract-zip/index.js:167:11)
    at install (/home/user/.npm/_npx/34327/lib/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:392:37)
    at BrowserFetcher.download (/home/user/.npm/_npx/34327/lib/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:249:19)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async downloadBrowser (/home/user/.npm/_npx/34327/lib/node_modules/puppeteer/lib/cjs/puppeteer/node/install.js:51:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

@thesam Thanks for your report! Please feel free to create a pull request for this and I'm happy to get it landed :)

Getting the error:
npm ERR! command sh -c node install.js
npm ERR! ERROR: Failed to set up Chrome r114.0.5735.133! Set "PUPPETEER_SKIP_DOWNLOAD" env variable to skip download.
npm ERR! Error: Target directory is expected to be absolute
npm ERR!     at module.exports (/home/vedantroy/Desktop/llms/gensite/js/node_modules/extract-zip/index.js:167:11)
npm ERR!     at unpackArchive (/home/vedantroy/Desktop/llms/gensite/js/node_modules/@puppeteer/browsers/lib/cjs/fileUtil.js:59:41)
npm ERR!     at install (/home/vedantroy/Desktop/llms/gensite/js/node_modules/@puppeteer/browsers/lib/cjs/install.js:106:51)
npm ERR!     at async downloadBrowser (/home/vedantroy/Desktop/llms/gensite/js/node_modules/puppeteer/lib/cjs/puppeteer/node/install.js:51:24)

For puppeteer:
    "puppeteer": "^20.7.3"


Command extension runs indefinitely

VSCode Version: 1.0.0
OS Version: Windows 10

Steps to Reproduce:

Add following code to main.ts
import { window, commands, OutputChannel, Disposable, ExtensionContext} from 'vscode';

let channel: OutputChannel;

export function activate(context: ExtensionContext): void {
	registerCommands(context);
	channel = window.createOutputChannel('Compile');
	context.subscriptions.push(channel);
}

export function deactivate(context: ExtensionContext): void {
	console.log('deactivated');
}

function registerCommands(context: ExtensionContext): void {
	let c1: Disposable = commands.registerCommand('test1', () => {
		var test: number = 0;
		(function testFunc() {
			channel.appendLine(`test: ${test++}`);
			setTimeout(function(){
				testFunc();
			},2000);
		})();
	});
	context.subscriptions.push(c1);
}

Add this to package.json (remember to change main value to compiled js)
{
	"main": "<path-to-js>",
	"activationEvents": [
		"onCommand:gcc-compile"
	],
	"contributes": {
		"commands": [
			{
				"command": "test1",
				"title": "MY TEST 1"
			}
		]
	}
}

When you run the command multiple times, the previous instances don't shutdown. This will create an issue especially if a continuous command (such as watcher) is running. The only way to stop commands is to close Visual Studio Code.

Suggesions:

Function to stop one of the currently running commands.

Force single instance of an extension command.

A function similar to export function deactivate(context: ExtensionContext) that runs before every command call. One of the parameters should be an array of currently running commands with the ability to deactivate them.

The code of your command is basically an endless loop and there is no way we can stop that from the outside. You should store the handle setTimeout returns and invoke clearTimeout before proceeding with another run.
    (function testFunc() {
        channel.appendLine(`test: ${test++}`);
        setTimeout(function(){
            testFunc();
        },2000);
    })();

The issue is how can I know whether another task is invoked. You can't access or check other tasks from within a running task unless I missed something in the API.
You can change the example to invoking a child process:
tsc -w

This task runs indefinitely. If the user wants to change a setting (extension supports extra settings) or accidentally invoked the same task again, you get multiple instances of typescript watcher modifying the same files.


Cosmetics - names and strings change

Coverage increased (+0.07%) to 80.679% when pulling 7e631c0102eaa10678ff1f589717fda4b254abbb on cosmetics into 8ab28f933645c0963452470c13a9dba3da7893d8 on main.


Create a text highlight element for the Visual Story page body contents

User Story
As a neurodivergent user accessing a visual story
I want to see what other visual stories there are available
So that I can be confident planning a visit to exhibitions at Wellcome Collections
What?
Add the yellow highlight element to every Visual Story link inside another Visual Story

Why?
Currently links buried inside the guide, not very visible.
Background
Done when

[ ] links to other Visual Stories highlighted in all current Visual Story documents
[ ]  Documentation updated

We discussed it with Lauren and Kasia and we're happy doing this, but we'll need to make it very clear what the slice is to be used for. Historically, InfoBlock has been used for an array of reason and we'd like to ensure it doesn't get used for any reason. So;

Adding a description to the slice if we can for editors
@LaurenFBaily to update the Slice description here https://app.gitbook.com/o/-LumfFcEMKx4gYXKAZTQ/s/451yLOIRTl5YiAJ88yIL/custom-slices#info-block
And of course, communicate with editors once it's made available with a clear guidance on how it's to be used.

Waiting on possible name change?

Blocked by #10959

https://wellcomecollection.org/exhibitions/ZZP8BxAAALeD00jo/visual-stories change made here. The InfoBlock is now available on visual stories and only offers title and content, no more buttons.
The three places we found that used the button have been replaced by a link.
Just noticed the styles are slightly different, with the list being indented on the mockup but not in our current InfoBlock styles. I'm not super sure why, it uses .body-text which overrides the padding on the left, so it does seem intentional. Is that something we'd like me to look into?

Changes communicated to Editorial in Slack.
Name of the component will not be changed as per this ticket's conclusion.
So closing this ticket - we can create a new one if we want to address the list styles; it's a different piece of work anyway.


refactor: :sparkles: Refactored the codebase

Fixes Issue

Changes proposed
Here comes all the changes proposed through this PR

[x] Refactored the index.js to just execute the command with the name attribute in the exports instead of if else statements

[x] Also added a “Please use a valid command” and “check cm!help” if the command is not available

[x] Added a parameter Discord which should take the Discord object library so that we don’t have to require the Discord in each file

[x] Added fs to the index.js to read the commands/files from the Commands folder

[x] Added checks in client.on(“message”) function to check for bot, dms, and if the command is starting with prefix or not

[x] Changed the dsa.js,source.js, version.js, hey.js, help.js, links.js to export the name and description of the command to check that in index.js

[x] Changed the translate.js to use the latest async/await syntax instead of the old .then()/.catch() syntax, also changed checks for if the translation is is same as the input text and if the input args is empty

[x] Also changed the meme.js to use the async/await instead if .then and .catch, and made it to send a embed instead of simple text and image

Check List (Check all the boxes which are applicable)

[ ] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Add all the screenshots which support your changes

@Tan-Shadow Could you please add screenshots of working commands please

I am sorry i will add them tomorrow as soon as i boot up

@kaiwalyakoparkar screenshots addded 👍🏼


How to render static webpage in finatra2

Hi there,
I'm relatively new to finatra2 and I'm trying to render a static html page with finatra2. Looking at existing code (finatra 1.6.0) it should look somehow similar to:
get("/") { request =>
render.static("index.html").toFuture
}
However, I was unable to find the pendant of above code in finatra2. Any help would be much appreciated.
Many thanks
Sandro

Hi Sandro,
Relevant docs can be found here: https://github.com/twitter/finatra/tree/master/http#file-server
-Steve


Move 'backbone' from dependencies to peerDependency

I was tripped up by this when I assumed it would load the same backbone version as the one I specified in my package.json. Turns out layoutmanager is using it's own backbone dependency. This is a problem in packages that depend on commonjs like requires (browserify). Can we move the backbone dependency to peerDependency instead so we have control over which backbone version we want to use?

Sure thing, wanna open up a PR?

Just did. Appreciate the quick response.


No clear soldering order for LEDs for v3.0

As I read in many  build logs, it's recommended to test each led after solder each one in order to ensure there no problem because all are connected in serial. Because of that I think a picture with the sequence would be helpful.

its the same order for all versions so far.

Thanks.
It was also mentioned in https://github.com/foostan/crkbd/issues/96 so I'm closing as duplicate.


Allow users to specify preferred listen address

When listening for IPFS swarm, or peerings, we listen on <IP_ADDRESS>, which will leave us trying to listen on any/all interfaces available. In various places though we try and choose a single address to use but it isn't always the one we want.
By specifying BACALHAU_PREFERRED_ADDRESS it will pick that address over any others for the IPFS swarm and the peering information.

I don't really understand how this interacts with the --host flag you mention?

Should the flag be doing it? Should we be just using the flag instead of adding a new env var?

Should the flag be doing it? Should we be just using the flag instead of adding a new env var?

The flag would have to also work for the calculation of the peering, but we might want to have the peering to happen on an internal IP, the API and IPFS swarm on different addresses.  Using --host would only solve the case where a user wants everything on a single public address.
I added https://github.com/bacalhau-project/bacalhau/issues/2486 as the start of a discussion about having better options around the network config, and hopefully a less scattergun approach to libp2p so we're not doing all of udp, udp+quic1, udp+quic, tcp etc.. particularly given the comment referenced in that issue about concurrency issues.


Submit update modal pushed too far up

On some android phones the keyboard may push the Receiving updates modal too high. Require screenshot for user who used samsung galaxy S3 as a reference.
Acceptance Criteria

[ ]  Receive update modal should scale to what the device dimension is or should be smaller to avoid screen usage

Steps for QA:

Submit a feedback to a service
On the receive update page click on email
Take a screenshot

This is no longer a modal


added xslices.Map and xslices.Filter

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.81%. Comparing base (17331d3) to head (d9f7608).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1346      +/-   ##
==========================================
- Coverage   42.25%   41.81%   -0.45%
==========================================
  Files         329      331       +2
  Lines       34423    29120    -5303
==========================================
- Hits        14545    12176    -2369
+ Misses      19403    16468    -2935
- Partials      475      476       +1

Flag
Coverage Δ

go-1.20.x
44.07% <100.00%> (-0.55%)
:arrow_down:

go-1.21.x
44.07% <100.00%> (-0.55%)
:arrow_down:

go-1.22.x
41.75% <100.00%> (-0.45%)
:arrow_down:

macOS
41.81% <100.00%> (+0.11%)
:arrow_up:

ubuntu
44.10% <100.00%> (+2.31%)
:arrow_up:

unit
41.81% <100.00%> (-0.45%)
:arrow_down:

windows
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


K8SPS-188 - Update versions for 0.4.0

Test name
Status

auto-config
passed

init-deploy
passed

demand-backup
passed

gr-init-deploy
passed

monitoring
passed

semi-sync
passed

service-per-pod
passed

config
passed

sidecars
passed

gr-demand-backup
passed

limits
passed

version-service
passed

one-pod
passed

tls-cert-manager
passed

scaling
passed

users
passed

We run 16 out of 16

commit: https://github.com/percona/percona-server-mysql-operator/pull/235/commits/9540be3ea589a26dcde8787041a1910621c55de4
image: perconalab/percona-server-mysql-operator:PR-235-9540be3


Update WebView2 usage with new API once adopted

Once the new API is adopted, we should update our usage.  https://github.com/MicrosoftEdge/WebViewFeedback/issues/60 is their tracking issue.

It's unlikely that the API change will be accepted. They motivated their choice and I understand their position. We can make changes on our side to generate the JSON with the required format so that we won't need a second argument in the API. The change will effect all modules but it's not too impacting.


One more tuya / Saswell TRV

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.681%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6856

Relevant Lines:
8193

💛  - Coveralls

Did you (or someone else) test that this works?

Codecov Report
Base: 83.68% // Head: 83.68% // No change to project coverage :thumbsup:

Coverage data is based on head (4a66417) compared to base (20e0960).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2133   +/-   ##
=======================================
  Coverage   83.68%   83.68%
=======================================
  Files         256      256
  Lines        8193     8193
=======================================
  Hits         6856     6856
  Misses       1337     1337

Impacted Files
Coverage Δ

zhaquirks/tuya/ts0601_trv_sas.py
52.04% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

"Found" 2 more Saswell TRVs.

Thanks J !!


Replace implementations for auto. derived impl Clone, Debug (& more?)

[ ] when we see an impl for a Clone derived by core::clone::Clone, replace it with an identity impl
[ ] when we see an impl for a Debug derived by core::fmt::macros::Debug, replace it with a dummy impl (e.g. a constant string)

Such transformations should be a user setting, both in the CLI and Cargo.toml, see #248.
This setting could be a list of rules for rewriting a matching block of code with another (possibly empty) block of code.
For now, we just drop the automatically derived impl blocks.

In most cases, we only need these derived impls in interfaces, so a potential solution may be to implement https://github.com/hacspec/hax/issues/1028

This is related to https://github.com/hacspec/hax/issues/1113.


build pipeline

[ ] add rule for filtering out peaks that overlap blacklisted region
[ ] run full-scale test


add pre-design view

Hello,
How I can use pre-design view instead of create it run time?

just add a view to storyboard and in inspector change its class from UIView to ScrollPager

no not like that. I have 3 UIViews in my viewcontroller it self. I want add these views in scrollpager. if I create view at run time it is working but I am not able to use my pre-design view in scrollpager.

Simply add your views in IB, assign outlets to them, and at runtime set them as views of the scrollpager


Need to implement the unused columns on the namespace selection screen

As seen in the image, we have 3 unpopulated columns still present that still are not hooked up to anything. The first question I'd like to answer with @vconzola and @jwmatthews is, do we still think these columns are relevant and they're desired to keep around? If that's true, we need to enhance the discovery service to provide this information as part of the nameplace discovery endpoint.
I'd also point out these have been empty for a few releases as this point and I haven't heard anything about it. Do we think this columns are really necessary, or would it be useful to do some kind of a UX redesign here built around only displaying namespace names.

@eriknelson I can't really say how useful or necessary these columns are. Would like to hear @jwmatthews thoughts. If we don't need them I'll design using a different type of component for selection. This is related to the issue of handling large numbers of namespaces within a cluster, so I'll take that into consideration too.

I also wish we hadn't combined the source/target and namespace steps of the wizard. that would allow us to show more projects per page.

This is going to depend on a breaking API change in the discovery service, link to the design document describing the UI schema changes required.
@jortel is there a PR link I can add here?


Documentation teaser page

Teaser page for SLDS Documentation
#30
Possibility to check locally: http://localhost:8080/teaser-page/
After build running needs to be deployed:

docs/website/public/assets/teaser-page
docs/website/public/assets/fonts
docs/website/public/teaser-page.html (our index)
docs/website/public/css/teaser-page
docs/website/public/css/base/base.css
docs/website/public/css/base/reset.css

Do we need the .ttf files in the repo?

Please make the asset filenames (such as the favicon) lowercase, to prevent casing issues.

Please rename github_dark.svg to github-dark.svg like the other files. (just use a consistent file naming convention across all assets plz :) )


Add manual test for RWX feature

https://github.com/longhorn/longhorn/issues/1470
Signed-off-by: khushboo-rancher<EMAIL_ADDRESS>

@joshimoo Is this good to merge?


Standard Walkthrough

This page -
https://azure.github.io/secrets-store-csi-driver-provider-azure/demos/standard-walkthrough/#5-deploy-secretproviderclass
references userAssignedIdentityID: "" which isn't clear what it is. It's not the resource id (which would be my first choice just by reading the key name) but the Client ID.
You should add a comment above it to clearly state that's the CLIENT ID of the user identity, so just the GUID value.

@snobu Thank you for opening the issue.
The standard walkthrough uses the service principal auth method. For more details on the configuration parameters and values, you can see https://azure.github.io/secrets-store-csi-driver-provider-azure/getting-started/usage/#create-your-own-secretproviderclass-object which defines the expected value for each field.
Also, if you refer to https://azure.github.io/secrets-store-csi-driver-provider-azure/configurations/identity-access-modes/user-assigned-msi-mode/, we have an example for the SecretProviderClass to use with user-assigned managed identity.


X-axis labels duplicating after some swipes on graph view

Fixed in https://github.com/philackm/Scrollable-GraphView/pull/56

Amazing, thank you. I'll review and merge.


Set path data on init

I was actually surprised that path data is not set when I first open the app

AFAIK it is correctly set on page render if you call sync before router.start.


First response header gets lost

https://github.com/php-vcr/php-vcr/blob/1.3.1/src/VCR/Util/CurlHelper.php#L60-L61
            $headerList = array(HttpUtil::formatAsStatusString($response));
            $headerList += HttpUtil::formatHeadersForCurl($response->getHeaders());

First line creates an array with status code line. Second line adds headers to the array. But first header doesn't get put into the array. Since element with index 0 already exists.

I'm seeing this same issue.

Seeing the same issue. It is due to the use of += to combine the arrays.
This example shows that when using + to combine arrays with numeric indexes that the first element of the second array is lost.
>>> ['status code'] + ['location', 'length'];
=> [
     "status code",
     "length",
   ]

You can use array_merge() instead and it fixes the issue.
$headerList = array_merge($headerList, HttpUtil::formatHeadersForCurl($response->getHeaders()));


Add xhrChallengeType option to avoid Basic Auth dialog, based on http…

replace "Basic" challenge by a different name to avoid login dialog

Looks nice, thx for this


Pathlib vs OS Modules for File and Directory System Operation utilizing Comparable Scenarios

Article checklist
Attention
Our Peer Reviewer and Content Moderator teams do NOT provide any revisions services. All revisions and edits should be completed on your own forked repo (as to not take up room in the queue) in order for our team to review them all in a timely manner.
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.

As a rule of thumb - please be sure to only submit articles (pull requests) that are fully polished and ready to be published. Be sure to go through our resources documents for extra and 3rd party (vetted) resources to help improve overall technical writing.

Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[ ] Have you used the correct folder and file structure? - see Contribution Guidelines

[ ] Is your article properly formatted in Markdown? - see Github Markdown guide

[ ] Have you used our preferred heading structure? - H3 (###) and up

[ ] Does your article follow any of the suggested structure formats? - see example formats

[ ] Is your article over 750 words? - Tool: Wordcounter.net

[ ] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[ ] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[ ] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[ ] Have you included a hero image that is 600x400 pixels, under 300KB in size, and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[ ] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[ ] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[ ] Have you checked your article for readability? - Tool: Hemmingway
[ ] Have you added sources for quotes and images that aren't yours?

Technical checks

[ ] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[ ] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[ ] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #issue-number

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

Duplicate of #6145

I'll complete my tech review by tomorrow EOD.

@srishilesh
Thanks so much, I will be expecting your feeback.

@akenz1901
Also, can you link this PR to an issue? I don't find the issue number.

Good afternoon and thank you for submitting your topic suggestion. Not a problem but it seems that this PR is still quite a bit aways from being completed.
In an effort to be fair to our larger EngEd community as a rule of thumb - we can only accept content (pull requests) that are complete and fully polished articles/tutorial - meaning they are ready to be published.
All revisions and edits should be completed on your own forked repo (as to not take up room in the queue) - this allows all revisions to be done on your forked personal repo.
@akenz1901

Thanks, @hectorkambow , I so much understand your point and i appreciate your the advice.

Thanks, @hectorkambow, I so much understand your point and I appreciate your advice.


Moved resources into the public directory.

See: https://vitejs.dev/guide/assets.html#the-public-directory

Fix for: #5


Downloads with --use-sub-directories crash when processing a post with no title

PatreonDownloader.Implementation.PostSubdirectoryHelper calls Trim() on the Title property of PatreonDownloader.Implementation.PatreonCrawledUrl, resulting in a null reference if the post has no title (which is apparently possible).
This seems to happen due to PatreonPageCrawler assuming the json object has a title value, which is returned as null by the deserializer from posts with no title.

Sorry, this is a duplicate of #88. Closing.


Add null digest implementation to the default provider

This is necessary to keep compatibility with 1.1.1.
Fixes #16660
Checklist

[x] tests are added or updated

This pull request is ready to merge

Merged to master and 3.0 branches. Thank you for the review.


Not Able To Start

Hi,
I cloned the repo & also installed the requirements, but unable to start.
Can you pls tell what is the command line to start.
Thank You

@RFedz007989 did you try running the starter.ipynb first?

@RFedz007989 did you try running the starter.ipynb first?

No. Thanks I will do that & let you know if that works for me or not.

As you said I tried, but unable to open this (starter.ipynb)
Pls check folder & way I installed & Pls let me know is this correct or is there something missing.
Thank You


HSR YAAGL (Will not open) But says this

I try to open YAAGL (HSR) will not open. Instead says that something about filing a issue.

System Information (please complete the following information):

macOS: 15.1 Sequoia
Device: Macbook Pro (2023)
CPU: Apple M3 Pro
RAM: 18GB

Logs: Error: Assertation failed (gameSegmentZips.length > 1)! please file an issue.

Looks the same as this #441


return NULL if not found in gate::create_quantum_gate_from_string()

close #382
Exceptionを削除してドキュメントコメントに仕様として一言書き加えました。

Codecov Report

Merging #383 (546dc38) into dev (24e7aa0) will increase coverage by 0.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #383      +/-   ##
==========================================
+ Coverage   70.95%   71.50%   +0.55%
==========================================
  Files          84       84
  Lines        5970     5967       -3
==========================================
+ Hits         4236     4267      +31
+ Misses       1734     1700      -34

Impacted Files
Coverage Δ

src/cppsim/exception.hpp
14.28% <ø> (+0.64%)
:arrow_up:

src/cppsim/gate_factory.cpp
58.47% <ø> (+0.40%)
:arrow_up:

src/csim/update_ops_pauli_multi.cpp
65.00% <0.00%> (+0.62%)
:arrow_up:

src/csim/update_ops_pauli_single.cpp
91.66% <0.00%> (+6.25%)
:arrow_up:

...rc/csim/update_ops_control_multi_target_single.cpp
97.61% <0.00%> (+10.31%)
:arrow_up:

src/csim/stat_ops_expectation_value.cpp
96.20% <0.00%> (+17.72%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.


refactor: remove unnecessary choice &&s

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other: <!-- Please describe: -->

Issue Number: Closes #2726.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information
If I'm not mistaken, this causes 0 changes in functionality.

@ritwickdey are you open to this change?


Pull request-Angad.

Angad's new pull request:)

LGTM! Can you merge this and delete the branch after.


Fix unit offset bug

First and foremost: Amazing package - thanks for sharing this!
Please consider accepting this PR to

fix to_base_value formula: The bug only becomes apparent when dealing with units that require multiplier AND offset for conversion, for instance, when converting degree Celsius to degree Fahrenheit.
fix the multiplier and offset for unit Fahrenheit

I also extended the conversion unit tests.

Hi @dylanwal , To make the issue regarding the to_base_value formula (item 1.) a bit more clear: In version v0.0.16, the behavior is as follows when using units Fahrenheit:
import unitpy
value_fahrenheit = unitpy.Q(1, "degF")
print(value_fahrenheit) # will result in the following output:<PHONE_NUMBER>778 Fahrenheit

But obviously the result of unitpy.Q(1, "degF") should be 1 Fahrenheit.
The reason for the wrong value is that the formula in to_base_value is not the inverse of the formula found from_base_value and vice versa. The PR should fix it.
Thanks and best regards,
Georg

Thanks for catching the bug!


Docs > Treeview > Selectable example missing references

Describe the bug
In our docs site the Treeview component is missing a few references in the Selectable example
To Reproduce
Steps to reproduce the behavior:

Go to docs
Select Treeview
Open Selectable example in Codesandbox
Verify missing references when interacting with demo

Expected behavior
Should have all references included

Verified on:
https://next--upbeat-sinoussi-f675aa.netlify.app/api/tree-view/
Added references in Selectable example. ✅


Got "ICE failed" on your demo page

Hi.
I got critical error "ICE failed, see about:webrtc for more details" on your script, even on your demo page.
I have Windows 7, Firefox 39.

@psyhonut can you please post a screenshot with the console open? I do not have access to a windows machine to try and reproduce. It works fine on Linux, Firefox 39.

Do you have webrtc enabled? What is your media.peerconnection.enabled setting in about:config?

Closing due to no response for several months.


core: add MitosisComponent.props

I think the code will be a lot simpler in the generators if we provide more metadata on the props. For example in angular we want to know if it's a function and if it's being invoked. or in React if it's going used in ref binding.
I was something something like
type PropType =
  | 'function'
  | 'string'
  | 'boolean'
  | 'undefined'
  | 'null';

// metadata on how it's being used
type PropUsed =
  | 'binding'
  | 'invoked'
  | 'binding.ref' // forwardRef
  | 'function'
  | 'onMount'
  | 'onInit'
  | 'onUnMount'
  | 'onUpdate'
  | 'onUpdate.dep';

interface MitosisProp {
  type: PropType;
  used: PropUsed[];
  code: string;
}

Can you please provide a detailed example  of how we use MitosisComponent.props

@PatrickJS Debating whether we can keep this logic in generators for now, until we see enough need for it to be permanently embedded in the JSON schema. That way, we can gather more use-cases from more generators about what info we need to store, and the schema will be more accurate.
Unless doing it in the generators is a lot harder or hacky than in the babel transform of the JSX parser, in which case it makes sense to move it there earlier.
My main concern is not crowding up the component JSON and having data in there that can easily be derived from other parts of the JSON (by inspecting both the props and the lifecycle hooks code for example)


deviations' config

Hello, Currently deviations are enabled by default that causes issue for vendors whose implementation does not deviate from the OC. Ideally, the deviations should be disabled by default. This pull adds a simple function ConfigVendorDeviations that can be called at the beginning of the each test to enable/disable the deviations based on the device vendor.

Thanks @mojiiba for the contribution.
I tend to disagree with the proposal in this PR, because:

Since it's a flag to the feature profile test, we might want to keep the deviation flag management outside feature profile test.
Following the idea of this PR, we might accidentally expose a vendor's capability or limitation in the test code, which is not something we want for Feature Profile :).

But I'll let @liulk as the formal reviewer.

Thanks for the comment. I understand. In that case, can we set the flags’ default to false?
From: Xiao Wang @.>
Date: Friday, June 17, 2022 at 4:18 PM
To: openconfig/featureprofiles @.>
Cc: Moji Ba (mbagherz) @.>, Mention @.>
Subject: Re: [openconfig/featureprofiles] deviations' config (PR #251)
Thanks @mojiibahttps://github.com/mojiiba for the contribution.
I tend to disagree with the proposal in this PR, because:

Since it's a flag to the feature profile test, we might want to keep the deviation flag management outside feature profile test.
Following the idea of this PR, we might accidentally expose a vendor's capability or limitation in the test code, which is not something we want for Feature Profile :).

But I'll let @liulkhttps://github.com/liulk as the formal reviewer.
—
Reply to this email directly, view it on GitHubhttps://github.com/openconfig/featureprofiles/pull/251#issuecomment-1159200421, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AV3G4KJBNQUJ35RHLT3GSKDVPTMOPANCNFSM5ZDHXRRA.
You are receiving this because you were mentioned.Message ID: @.***>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 60.202%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
596

Relevant Lines:
990

💛  - Coveralls

I think deviation management has to be done as part of the test result collection workflow outside of the test, so we can track which deviations are required in order for tests to pass, and the intent is to gradually phase out these deviations. It is equally problematic if a device requires a deviation to be set to false. These requirements need to be eradicated over time.
For now, I am okay with setting the --deviation_interface_enabled to false, so let's remove ConfigureVendorDeviations. I've also filed an issue to specifically test the non-deviated setting of subinterface enabled in #253 so we have a way to track this non-compliant behavior.

@bstoll FYI, we'll have to set deviations explicitly for our continuous test run workflow.

/gcbrun


Run target once

In my project I have two targets A and B. Most of the time I need A, so it's set as active target which I can start with a single key stroke. In rare cases I need to start B. So I have to set it as active target, but after that I have to reset the active target to A again.
So I would really appreciate a command which runs an arbitrary target once, without affecting the active target setting.

You should use the keymap configuration


Change default branch name to "main"

I'd like for us to change our default branch name to main, the same as we did over at typeshed.
I don't think I have the necessary permissions to do so myself, unfortunately.

Me neither, although I have access to some settings. Maybe we should disable Wiki and Projects as well while we are at it? I can do the latter.

I've disabled them now. We can reenable them if someone objects.

I have sufficient powers to do this. Will do it after I have done some research to figure out exactly what I need to do. https://github.com/PyCQA/flake8-pyi/settings/branches has a button to change the default branch.

There's only two hardcoded references in our codebase to "master" that we'll need to change to "main":
https://github.com/PyCQA/flake8-pyi/blob/8222988cff76b315fae33666626eb9ddda690308/.github/workflows/check.yml#L6
https://github.com/PyCQA/flake8-pyi/blob/8222988cff76b315fae33666626eb9ddda690308/pyproject.toml#L59

@JelleZijlstra Since I did it for typeshed and a few other repos: Just use the button in GitHub and update the files pointed out by @AlexWaygood.


Fine tuned FLUX-DEV successfully

Thx to the team...i have successfully finetuned  FLUX-DEV in RTX 4090 24Gb in lora rank 32 for 2000steps..which took 2hrs apprx..

Okay? Then close this issue.

How did you change it to rank 32?

How did you change it to rank 32?

edit the config.yaml

issues are only for bugs, please close this


Firebase Realtime

Hello ... I liked the library, how could I implement it to Firebase ???

Hi @MundoRPG thanks for the comment. I have not worked with Firebase before but I will spend some time to look at adding Firebase.


aider

git-bob comment on how to integrate aider in functions such as solve_github_issue or create_or_modify_file in _ai_github_utilities.py.

I found this code example for using aideR:
from aider.coders import Coder
from aider.models import Model

# This is a list of files to add to the chat
fnames = ["greeting.py"]

model = Model("gpt-4-turbo")

# Create a coder object
coder = Coder.create(main_model=model, fnames=fnames)

# This will execute one instruction on those files and then return
coder.run("make a script that prints hello world")

# Send another instruction
coder.run("make it say goodbye")

# Print out usage / costs
coder.run("/tokens")

Could this be integrated into create_or_modify_file ?
git-bob answer


Initial / start of implementation

[x] basic structure
[x] fix issue with leading whitespace in (split) comments
[x] handle in place changes (rename original to .bak) as well as gofumpt
[x] better/smart (word) cut for comments
[x] handle /* and not just //
[ ] issue with disappearing new line before function after */ (see make test) https://github.com/golang/go/issues/66439
[x] handle comments not just at top level
[x] handle string literals (which is most of the issues in https://github.com/fortio/slack-proxy/pull/49)
[ ] handle that a literal or comment maybe below the -len yet making a line in total > len (because of right indentation)
[ ] cut more lines like function signatures

will merge this as a good enough starting point and make follow up issues


policies.SecurityRule support for 'target'

Would like to have the SecurityRule object support the 'target' parameter available when using panorama. I suppose it would be nice to link the target firewall(s) in the object if the association is available.

Thanks for opening this issue.  We'll add this feature and push to the develop branch.  Will comment here when done.


TODO List

[x] Logout is fucked
[x] Items aren't added onto Player Appearance
[x] Map Flag Tiles
[x] Changing Display modes r fucked
[x] Npc does not get removed when it's dead + exception about transforming it to -1
[ ] No npc hp bars
[x] No npc anims
[x] Projectiles are also fucked up
[ ] Bank does not work as intended
[ ] Some interface options need to be updated as before we had all (options -1)
[x] Still using old skill interface
[ ] Remove/Update Bond interface
[x] When client disconnects it does not flush the player
[ ] Create separate class for PlayerInfoUpdating

Still using old skill interface = Need to implement Advance Settings <-- There is a option to switch between new and old Skill guide interface, i added the varbit that depends on that option, and will enable the new style by default.

[x] Npc does not get removed when it's dead + exception about transforming it to -1, had to use setInaccessible(), just need to find out why it removes the npc so fast, without letting it do death animation.

pushed fixes for the xteas not getting loaded in and also reimplemented projectiles. Checked them off.

For some reason when you activate these, it will give Null Pointer due to player.getInteractingSlot() Which is bit weird as it shouldnt be doing that

We are not assigning Render Animations yet by items, need to create open class for BlockInfo and make it reusable between Npc/Player classes


How to set minimum length of an accepted barCode?

Description of the problem:
In Brazil we have a default format of barcodes used for bank slips, its an ITF barCode with 44 characters, the problem is that sometimes this library recognizes smaller barCodes, with only some digits of the original barCode, it generates a false scan to user, because the beep is reproduced and the activity is closed when a barCode is found. Is there a way to specify the min number of characters to be recognized as a valid read?
Which library version are you using?  4.1.0.
Which phone/tablet are you using, and which Android version does it run? Samsung Galaxy S7
Does the same happen on other devices or an emulator? Yes, on other devices too

hey @edu1525, have you found some workaround to read brazilian barcodes?