Remove transparent background from images

Summary
Set white background and remove alpha channel from images, to remove transparency
Fixes https://github.com/dotnet/docs/issues/6547

In some cases the ones with transparent background actually looked better:
https://review.docs.microsoft.com/en-us/dotnet/standard/microservices-architecture/architect-microservice-container-applications/scalable-available-multi-container-microservice-applications?branch=pr-en-us-10451#kubernetes
vs.
https://docs.microsoft.com/en-us/dotnet/standard/microservices-architecture/architect-microservice-container-applications/scalable-available-multi-container-microservice-applications?branch=pr-en-us-10451#kubernetes
Should we review how they look in dark mode before and after to see which images should keep the transparent background?

@mairaw, I can't get to see the first link, my MS credentials don't work anymore 😔, anyway I don't think keeping transparent background is an option, because of dark themes.
Anyway, could you add a print screen here to take a look?

Ah sorry!
Current:

With this PR:

You're right @mairaw it looks horrible 😝
Ok, but the only "solution" I see is reverting canges for images like this one, that don't have black text.
I think this applies only to logo images in this pages.
Do you think that would be enough?

Yes @mvelosop! I think that sounds great!

Done @mairaw

Weird, I'm still seeing the kubernetes one with the white background on dark mode and the same number of files changes from commit 1 to commit 2.

Yep, weird indeed, this is what I see:

The new one is on the right, investigating...

Even clicking on the "View File" button on the second commit shows this:

However, it's not shown when viewing the consolidated changes, which is right, just because the second commit reverted the change on those files.
Could that be the reason somehow?

Internal contributor guide says that conceptual art like diagrams with text should not be transparent and should have a border on the image. It says that transparency is useful for branded icons (such as the icon of an azure service or product) and other non-text artwork

Thanks @Thraka,
@mairaw, found the reason for that recommendation some days ago 😉
The problem we have now is that even though I reverted to transparent background logos, she still sees them white. Do you have and idea of what could be happening?
Cheers.

I have good instincts 😄 thanks for linking to the official guidelines @Thraka. I'll see if I can revert that image myself.

Let's try a rebuild first.

😅


[5.3] Add support to override timestamps columns

Currently the timestamps column names created_at, updated_at are kinda hard coded, there is a getter for these names but sometimes the constant is used instead of using the getter, this PR fix that by always calling the getter instead of the constant this way ppl can easilly change the name of these columns...
Refs #16720

Big question, is there a specific reason for setting the parent of the Pivot after calling the forcefill() ?
Tests seems to pass anyway, i'm just concerned about it...

Why not just overwrite the constants?

@fernandobandeira
You can override it like this:
<?php
namespace App;

class YourModeName extends Illuminate\Database\Eloquent\Model {
   const CREATED_AT = 'your_created_at_column_name';
   const UPDATED_AT = 'your_updated_at_column_name';
}


Update gradle

If you are using the last stable version of the Android Studio with Gradle 5 the project does not compile.
* What went wrong:
The Android Gradle plugin supports only Kotlin Gradle plugin version 1.3.10 and higher.
The following dependencies do not satisfy the required version:
root project 'graphql-android' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.2.71

Make sure you are using the last stable version of Android Studio

Nice, Thanks :)

Nice guys. This is why we should have build configured.


PublishTrimmed/TrimMode support?

Hey,
I am trying to use the library, which works fine untrimmed. Unfortunately we are having issues with TrimmedMode with .NET7/8, in which the app crashes at launch.
I have managed to resolve this by using TrimMode partial as suggested here https://github.com/microsoft/WindowsAppSDK/issues/2478#issuecomment-1485912900 which has the app running but none of the strings are being loaded in. Its tricky to debug as its occuring after a publish.
Does WinUI3Localizer support trimmed apps / partially trimmed apps with .NET 7/8?

Hi! I'm away from my laptop for a few days. I've never tried it with trimming. I'll take a look when I'm back. ;)

Can you create and share a reproducible project on GitHub?

Hey sorry I've not got around to this yet, I will try and get something for you this week

Here is an attached reproducible project, sorry for the delay!
LocalizerTest.zip
You should be able to run this sln, F5 to run locally which will load the nav bar content and the title bar.
Then in Developer Powershell in VisualStudio, run
dotnet publish .\LocalizerTestApp\LocalizerTestApp.csproj /p:PublishProfile=.\Properties/PublishProfiles/win-x64.pubxml

and run the exe from that directory. Result is none of the strings get loaded. You can see some trim warnings coming out of the publish step also. Turning off partial trim causes the app to crash instead of just not loading.
Let me know if I can provide anything else to assist

@AndrewKeepCoding, is there anything else I can provide to help you out with this? Is the test project OK?

Hi @Lawls91!
I'm sorry for the late response. I must have missed this notification.
I tried to reproduce the issue but as you can see, the strings are loaded as expected.

Can you make sure that the Strings folder and its Resources.resw files exist aside the EXE?

Hey @AndrewKeepCoding , no problem! I cant claim to understand the trim process fully, but I think that the assemblies in the /bin/Release folder are created before the trim?
Please after running the above dotnet publish step run the exe from the trimmed output directory. Should be:
$SOLUTION_DIRECTORY$/x64/LocalizerTestApp/LocalizerTestApp.exe
From there, when you run it, the strings dont display. The Strings directory is alongside it also
Let me know if you are able to see this behaviour also

It works. Can you add a logger from the builder?
Or add the following in the HomePage so we can see inside the localizer?
<Page
    x:Class="LocalizerTestApp.Pages.HomePage"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    mc:Ignorable="d">

    <Grid>
        <Grid.RowDefinitions>
            <RowDefinition Height="88"/>
            <RowDefinition Height="Auto"/>
        </Grid.RowDefinitions>

        <TextBlock Grid.Row="0" Text="Home" FontSize="28" />
        <StackPanel Grid.Row="1">
            <TextBlock x:Name="StringsFolderPath"/>
            <TextBlock x:Name="CurrentLanguage"/>
            <ListView x:Name="AvailableLanguages"/>
            <ListView x:Name="LanguageDictionaries"/>
        </StackPanel>
    </Grid>
</Page>

public HomePage()
{
    InitializeComponent();
    Loaded += HomePage_Loaded;
}

private void HomePage_Loaded(object sender, Microsoft.UI.Xaml.RoutedEventArgs e)
{
    StringsFolderPath.Text = Path.Combine(AppContext.BaseDirectory, "Strings");
    CurrentLanguage.Text = Localizer.Get().GetCurrentLanguage();
    AvailableLanguages.ItemsSource = Localizer.Get().GetAvailableLanguages();
    LanguageDictionaries.ItemsSource = Localizer.Get().GetLanguageDictionaries().FirstOrDefault().GetItems().Select(item => item.Value);
}

@AndrewKeepCoding accessing by code works (the "APP TITLE BAR" works for example and thats setup in the constructor of MainWindow.xaml.cs). It appears to just be strings that are setup through the XAML directly that dont work. I added that extra stuff for you, you can see it is outputting, but the strings for the nav bar still arent (when using the trimmed published exe, as mentioned the exe inside the project folder works, its the one off the solutions directory that doesnt)

I've attached a prebuilt copy, if you are launching it from SOLUTION_DIRECTORY/x64/LocalizerTestApp/LocalizerTestApp.exe already, then maybe its related to the compiler? Please can you run this and check behaviour? (Sorry, had to double compress it for github)
LocalizerTestApp.7z.gz

Hey @AndrewKeepCoding just wonderinf if you missed my latest reply?

Makes sense, no problem, thanks for the reply!
Let me know if theres anything I can provide to help. I've tested on a couple other machines with some of our other devs and get the same behaviour, whereby the output in SOLUTION_DIRECTORY/x64 doesnt work, but it does in SOLUTION_DIRECTORY/PROJECT_DIRECTORY/bin/Release (assume thats not Trimmed yet in there)

@Lawls91 I finally managed to reproduce the issue. Even though the localizer has the resources loaded as expected, it’s failing to get the properties from the controls. It seems that this is because ‘Reflection’ doesn’t work well with trimming. See here. I'm not sure if we'll have a better way to handle this in the future or not.
I'm sorry I couldn't bring better news after all.

Is it worth investigating opting the localizer modules out of trimming? Reading this, it seems like partial trimming should work with that package just set to not trim (I've not really dug into that though)
https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/trimming-options?pivots=dotnet-8-0#trimming-granularity

@AndrewKeepCoding  Is it worth investigating opting the localizer modules out of trimming? Reading this, it seems like partial trimming should work with that package just set to not trim (I've not really dug into that though)
https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/trimming-options?pivots=dotnet-8-0#trimming-granularity

I tried it but still didn't work...😵

@Lawls91 Can you try trimming with the WinUI3Localizer sample app? It seems to be working.

Hi @Lawls91 !
The WinUI3Localizer definitely has issues with trimming.


Memory leak in WorldAttached class

Describe the Bug
WorldAttached seems to have problems with removing unloaded worlds. Flywheel also has a WorldAttached class in which this bug is probably fixed, at least there are comments that suggest this.
Reproduction Steps

Build some constraptions in your world
Switch the world a few times
Notice the memory increase

Expected Result
There should be no memory leak, which eventually leads to lag spikes and crashes.
Screenshots and Videos
net.minecraft.class_638 -> ServerLevel

Crash Report or Log
No response
Operating System
Windows 11
Mod Version
0.5.0c
Minecraft Version
1.18.2
Other Mods
No response
Additional Context
No response

An issue should be made to the forge repo.


Tracking issue for adding try_state hook to all pallets.

This is the tracking issue to add the try_state hook to as many pallets as we can.
This hook was added in https://github.com/paritytech/substrate/pull/10174. The idea is as follows:
/// Execute some checks to ensure the internal state of a pallet is consistent.
///
/// Usually, these checks should check all of the invariants that are expected to be held on all of
/// the storage items of your pallet.
///
/// This hook should not alter any storage.
pub trait TryState<BlockNumber> {
	/// Execute the state checks.
	fn try_state(_: BlockNumber) -> Result<(), &'static str>;
}

So, the ideas is to focus on invariants that must always be held in a pallet. A native, yet important example of this is that in the balances pallet, iterating over all users should yield the correct total issuance.
Next, we want all pallets to call their try_state after each test. This can easily be achieved with a helper function like:
https://github.com/paritytech/substrate/blob/dd8a34775aab9b362a5cc7552d5603c2fe812f82/frame/nomination-pools/src/mock.rs#L335
pub fn build_and_execute(self, test: impl FnOnce() -> ()) {
	self.build().execute_with(|| {
		test();
		// run the try-state of all pallets after each test.
		<Runtime as TryState>::try_state(_, TryStateSelect::All).unwrap();
	})
}

Here is a list of current FRAME pallets, just for the sake of reference. Many of them won't need a try_state hook though.

[ ] alliance
[ ] assets
[ ] atomic-swap
[ ] aura
[ ] authority-discovery
[ ] authorship
[ ] babe
[x] bags-list
[ ] balances
[ ] beefy
[ ] beefy-mmr
[ ] bounties
[ ] child-bounties
[x] collective
[ ] contracts
[ ] conviction-voting
[ ] democracy
[ ] election-provider-multi-phase
[ ] election-provider-support
[ ] elections-phragmen
[ ] examples
[ ] fast-unstake
[ ] gilt
[ ] grandpa
[ ] identity
[ ] im-online
[ ] indices
[ ] lottery
[ ] membership
[ ] merkle-mountain-range
[ ] message-queue https://github.com/paritytech/substrate/issues/13115
[ ] multisig
[x] nicks
[ ] node-authorization
[x] nomination-pools
[ ] offences
[ ] preimage
[ ] proxy
[ ] randomness-collective-flip
[ ] ranked-collective
[ ] recovery
[ ] referenda
[ ] remark
[ ] root-offences
[ ] root-testing
[ ] scheduler
[ ] scored-pool
[ ] session
[ ] society
[x] staking
[ ] state-trie-migration
[ ] sudo
[ ] support
[ ] system
[x] timestamp
[ ] tips
[ ] transaction-payment
[ ] transaction-storage
[ ] treasury
[ ] uniques
[x] utility
[ ] vesting
[ ] whitelist

Implementing this hook will allow these checks to be called in try-runtime-cli, and other testing tools that compile a runtime with feature = try-runtime.
Note that for those who want to tackle a particular pallet, you must for sure deeply understand a pallet in order to correctly identify its list of invariants. Moreover, you might do your future generation a favor by documenting the invariants as good as you can.

Can I take this up ?

I want to take this up. Can you please assign this to me ?

This is a tracking issue, you can go ahead and work on any item, no need to assign 👍

The idea of the try_state hook is to reduce testing code?

There are actually two advantages that try_state has. Once for invariant assertion in unit tests, but also in try-runtime migration testing.
So the goal is to increase test coverage by always checking the invariants. So it would probably end up with more testing code, not less :laughing:
There is some more explanation here https://github.com/paritytech/substrate/issues/13115#issuecomment-1380218189

[ ]

@ggwpez could I list out pallets I think won't require try_state ? For now pallet-timestamp which uses the #[pallet::inherent] and pallet-utility which is stateless.
Hoping this might speed things up for other contributors :)

Yes sure @Doordashcon. Marked them together with the nicks pallet.

I will start working on the try-state for the referenda pallet if no one else picked that already.

This issue has been mentioned on Polkadot Forum. There might be relevant details there:
https://forum.polkadot.network/t/discussion-shaping-the-future-of-try-runtime-and-try-runtime-cli/2657/4

aura implemented here: https://github.com/paritytech/substrate/pull/14363


Required survey answers logged as "Skipped"

Relates to issues raised by @jabramowitz5. (Bug report is a bit messy, since it's been drawn from our common Google Chat and with a lot of uncertainties. Please add further findings in comments.)
Collectors in Ghana on mission on Sep 16, 2024 reported frequent crashes. It seems that when they restarted the app and picked up surveys again, some questions had been skipped. This problem occurred with both regular questions set to 'required' as well as with conditional questions set to 'required'. Partially relates to https://github.com/google/ground-platform/issues/1720.
It is already being discussed, that the survey in question (https://ground.openforis.org/survey/SB0BQw8vcz5fUTHzK2aB) might have been too large with 38 tasks, and with a lot of conditionals set to 'required'. But keep in mind that also regular questions set to 'required' were skipped.
Crashes could possibly have been triggered by phototaking (no evidence yet).
Could have something to do with crash report https://github.com/google/ground-android/issues/2726.

Copy-pasted chat history for reference:
I also noticed some of the entries do not have all of the questions answered, despite all tasks (except for one) being required. Some of the tasks say skipped because they are conditionals and the conditional did not lead to them, which makes sense, but there are several required and non-conditional tasks that show up as "skipped" in the web data viewer. I am not sure how data collectors could have skipped a required task and still have been able to submit the data collection?
For example, all the questions with answers "skipped" were required in the survey and the data collector somehow got past them and answered questions after them and submitted the data collection. I thought they would have had to have answered those questions to be able to move forward in the survey
Just spoke with the project lead in Ghana. There were 7 data collectors out of 30 that had the issues with no "add new data collection site" card popping up and were therefore unable to use Ground app in the field today. Also looking through the data some data entries have required tasks that are missing responses (as mentioned above). The project lead told me he was hearing from data collectors that the app was crashing very often in the field, so perhaps the issue was that the app crashed during the survey and then when they reopened app it has skipped questions in their current collection (just a thought, since I am not sure how they would have otherwise by-passed required questions and then answered later questions and submitted an entry)?
Could there be an issue with large conditionals? For example we have a “select one” question for regions with 6 options, each leading to its own “select one” question with 2-5 options for district, each of those leading to a “select one” question with many answers for community (I think 1 question had close to 80 options listed).
Could this be the source of crashing? Maybe you can see that in Crashlytics?
It looks like we had 124 data entries yesterday from the team. Only 59 however have all of the required questions answered so about half are somehow incomplete entries
I am thinking either this conditional question or the “take a photo” task is causing the crash? Some data collectors reported the “take a photo” task was not working for them. Perhaps certain devices cannot handle that task?

Relates to this https://github.com/google/ground-android/issues/2733

Updated the title, because lost data cannot be connected without a doubt to crashes. There is one recorded instance of the skipping issue without a crash.

Fixed by #2740. @jabramowitz5 can you please add the "verified" label to this issue if this works once users remove and reopen their surveys without clicking the survey multiple times?


Compilation failure on nightly (i686)

Compiling crossbeam v0.1.6
.cargo/registry/src/github.com-1ecc6299db9ec823/crossbeam-0.1.6/src/sync/seg_queue.rs:34:29: 34:43 error: transmute called with differently sized types: [usize; 32] (1024 bits) to [std::sync::atomic::AtomicBool; 32] (256 bits) [E0512]
.cargo/registry/src/github.com-1ecc6299db9ec823/crossbeam-0.1.6/src/sync/seg_queue.rs:34             ready: unsafe { mem::transmute([0usize; SEG_SIZE]) },
                                                                                ^~~~~~~~~~~~~~
.cargo/registry/src/github.com-1ecc6299db9ec823/crossbeam-0.1.6/src/sync/seg_queue.rs:34:29: 34:43 help: run `rustc --explain E0512` to see a detailed explanation

So what did you do to resolve this?

Used an override.
https://github.com/rust-lang/rust/issues/33724#issuecomment-220173387


[Revival Bug] The 山 does not appear in the 火 or in the 道 graphs

Check the task #98 comment https://github.com/ani-hovhannisyan/kanji-visualization/issues/98#issuecomment-1556506582 details.

[Report] Debugged that correct kanji data is not receive in the frontend, and in the backend get request processing again no correct data, that is 山 is missing.
Therefore, need to debug GraphController in the backend.

Debugged backend, also checked the json (file considered as temporary DB for getting kanji data) has no node of 山 that's why it does not appear in the final data.
This task goes deep into having dynamic DB or newly creating DataBase and fully changing Graph Controller graph making part, which is huge. So need to divide into small tasks.
Steps (tasks) need to be done to reach result are:

Find previous task of getting data from Kanji database (PR has to create tasks)
Explore again the structure of Japanese - English library
Redesign GraphController logic
Implement DB->GraphController(Server)-> part
Test with various cases
Add test cases for server GraphController
Commit, Merge, Release.

Opened #3 again to investigate properly and fix database issues once in a while. Low priority in Revival milestone, can be fixed in the next "Milestone 2 Waken" !


ServerPickerServerViewModel isChecked option

The picker rebuilds the selected list using the base isChecked property of the ServerPickerServerViewModel during view construction. This makes it impossible to set selected servers after any async calls complete. This option allows us to set the checked option explicitly when setting up the content after view initialization.

 UI - Product Edit


#83 add Dockerfile with some docu in README

Added Dockerfile (Image size uncompressed just 32.3MB) plus some guidance in README.md.
Tested with custom app-config and Docker Volume Mapping.

Ok, updated README.md. You may want to merge and edit it after as you like.

Thanks again @justb4 ! I'll happily merge now.


Deliverable Planning Meeting, Scheduled, Wednesday, October 25, 6:00 pm, Discord

Topics

[x] Review Vnv rubrics.
[x] Breakdown tasks.

Attendance

[x] @qstommyshu
[x] @yex33
[x] @marischan888
[x] @jiaoa3
[x] @KehaoHuang

4 System Test Description:
FR 1-9 @qstommyshu
FR 10-13 + NFR 1-5 @jiaoa3
FR 6-15 @marischan888
NFR 16 - 20 + HA 1-4 @KehaoHuang
Rest in HA @yex33


Documentation

Permanent issue on documentation.

Just as a starting comment, I think pyart documentation is really good, if we could do something similar would be nice

Here is a small list of orientations for developers

I like PyArt documentation as well, but more importantly keeping a similar structure is probably the right way to go given that ARTView is essentially an extension of PyArt.

I went ahead and implemented this in PR #33

@gamaanderson - looking into this now. Been super busy with our field project deployment the last few weeks.

In README::USAGE
there is no .py in the following:
python artview.py -d /some/directory/you/want/to/point/to

there is no longer a artview.py file

Oops missed one, I'll fix that with the next push (hopefully soon).

Fixed in PR#36.

I realized I hit the wrong button, we can keep this open as we move forward with Documentation.

@tjlang just a heads up!
I just realized that pep8 complained about #: and changed to # :, however I do need this to document attributes according with sphynx autodoc. There is no need to correct that now, I will make the changes in my fork and this will come back in some PR.

Just made some updates to the doc-strings throughout the package.

It would be nice to see if you can rebuild the documentation, but it may be not that easy, I had to fight a lot to get it running.
first you will need to install Sphinx
then run rebuild_docs.sh  (in folder docs/)
if you do built it successfully, use git status to check for new files in docs/build/html, you need to add those files to git.
I tested, and got 23 Warning, normally I get 3, those are the following, I understand them and they are ok.
checking consistency...
/home/gama/artview/docs/source/auto_examples/index.rst:: WARNING: document isn't included in any toctree
/home/gama/artview/docs/source/reference/generated/artview.core.core.Component.rst:: WARNING: document isn't included in any toctree
/home/gama/artview/docs/source/reference/generated/artview.core.core.Variable.rst:: WARNING: document isn't included in any toctree
done

the other 20 warning should be addressed, if you have problems with changes not taking place remove all files from folder docs/source/reference/generated/ (add rm source/reference/generated/* to rebuild_docs.sh if you want)
In any case, I'm here for help. Also remember I'm running everything in Debian, and I don't know if this will work in MacOSX

also, before all that, you may need to build/install artview to get the right version number in the documentation (one gets the version from the automatically created artview/version.py not setup.py).

I updated the version number in setup.py, if I'm not mistaken this is the only place the update needs to be applied and then the new version.py  is created by build/install.
Okay as for the documentation, I also get the 23 warnings after running rebuild_docs.sh. Now can you help me understand what needs to be changed? Do I need to modify the .rst files where the warnings were thrown?

no, you don't. All those files are automatically generated.

most of those warning is because artview.components.Display changed to artview.components.RadarDisplay. You can start going after this in the doc-strings and see how many warnings are left

the only .rst files you need to see, are the tutorials:
docs/source/script_tutorial.rst
docs/source/plugin_tutorial.rst
those also need actualization, including the code examples

Okay, I have the warnings down to 15. I pushed the update.
Many still the same as you note above (I fixed multiple instances), but I can't find any instances with a grep command.
Also, what is toctree?

toctree is how sphinx organize the links, or something like that.
/home/gama/artview/docs/source/reference/components.rst:14: WARNING: failed to import Display
/home/gama/artview/docs/source/reference/components.rst:14: WARNING: failed to import TiltButtonWindow
/home/gama/artview/docs/source/reference/components.rst:14: WARNING: toctree references unknown document u'reference/generated/Display'
/home/gama/artview/docs/source/reference/components.rst:14: WARNING: toctree references unknown document u'reference/generated/TiltButtonWindow'

in components/init.py one need to actualize the initial doc string, to remove Display and TiltButtonWindow and add RadarDisplay, GridDisplay and LevelButtonWindow

Ah, I see what you mean. Fixed and pushed. Down to 3 warnings.

nice, those 3 are the "normal" ones.

I have no real experience in it but I have made a video, for now it is unlisted, so only we can see it. It has no sound, since I do not trust my voice, but it has some sub-titles. @nguy, @tjlang, @swnesbitt it has your names in the end, so make sure you all agree with it, also please revise the English.
If someone wants to improve it or add sound, the mp4 and the subtitle srt are here. I may also provide the original recordings (12min+) if needed.

Documentation updated.
I'll take a look at the video today hopefully.

Want to note the short discussion in Issue #85 so I can close.

Version 1.3 is getting closer, so we will need to review the docs. Also new tutorial are important. I know my voice is not the best so it would be really nice if someone would do the tutorial. It is certainly a lot of work and would be perfect for some one that want to help but don't want or don't know how to get in the code. I would certainly add such a person as author in the presentation at the AMS conference.

Good idea. I'll try to do some as well. I'll try to go through the code and update docstrings, etc. before doing a doc build as a final bit before release.


ResourceController service update

Signed-off-by: apoorva9s14<EMAIL_ADDRESS>PR summary
For the resource controller service update as per this PR - https://github.ibm.com/cloud-api-docs/resource-controller/pull/244, resource-controller-v2.yaml is the updated yaml, I have regenerated the SDK files with openapi-sdkgen.
We are looking to address:
Looping - https://github.ibm.com/cloud-api-docs/resource-controller/issues/226
Credentials redaction
PR Checklist
Please make sure that your PR fulfills the following requirements:

[ Yes] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ Yes] Docs have been added / updated (for bug fixes / features)

Current vs new behavior
The examples and the SDK code snippet in the apidocs would be updated for credentials redaction
Does this PR introduce a breaking change?

[ ] Yes
[. ] No

Other information

:tada: This PR is included in version 0.27.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Use OpBuilder to create ModuleOp

Use OpBuilder to create ModuleOp instead of using ModuleOp::create since OpBuilder can bookkeeping the ops created.

Not sure this is an improvement overall if it's not required - did you say there was an issue you were hitting that required this somehow?

indeed this is not required, will close this pull request.


[1.13] Support v2 plugins in swarm mode

Backport of #29378. Also vendors swarmkit for 1.13, bringing in the following fixes:

Revert "Root rotation backwards compat" (https://github.com/docker/swarmkit/pull/1810)
Support v2 plugins; re-enable scheduler plugin filter (https://github.com/docker/swarmkit/pull/1808)
Fix IPAM options not passed to RequestPool request (https://github.com/docker/swarmkit/pull/1805)
swarm leave should clean up assignments (https://github.com/docker/swarmkit/pull/1758)

This PR vendors a swarmkit PR that adds awareness of v2 plugins to the scheduler. Services that depend on a particular volume or network plugin will only be dispatched to nodes which have that plugin installed.
It updates the agent's executor to publish a list of v2 plugins to the manager.
It also fixes a problem in volume creation when the volume driver is a plugin. Trying to create a volume with the same name and parameters as one that already exists generally returns no error, but if a plugin name without a tag is specified, this always resulted in a conflict (plugin vs plugin:latest). The fix is to resolve the volume driver and compare its canonical name instead of the name passed in by the caller.

ping @anusha-ragunathan @vieux @tonistiigi @aluzzardi @nishanttotla @cpuguy83

@aaronlehmann could you help with writing what should be included in the changelog?

@aaronlehmann : Thanks for doing this. Were you able to test this? Has this been automated as part of CI? Also, it would be very helpful for users to document the plugin constraints behaviour (potentially with examples). Creating a  https://github.com/docker/docker/tree/master/docs/extend/plugins_swarm.md would be ideal.

Were you able to test this?

I tested it using the vieux/sshfs plugin. When I created a service using a volume with that driver, the tasks do not get scheduled until I install that plugin on a node. Then the task implicitly creates the volume and starts up.

Has this been automated as part of CI? Also, it would be very helpful for users to document the plugin constraints behaviour (potentially with examples).

I think I can create a simple integration test that does more or less the above steps with a dummy plugin. It can confirm that the tasks don't get scheduled until the plugin is installed, and that then start up afterwards. I'll try to get to this today. I'm not sure this test can confirm the volume driver is functioning correctly - any ideas on that?

Also, it would be very helpful for users to document the plugin constraints behaviour (potentially with examples).  Creating a https://github.com/docker/docker/tree/master/docs/extend/plugins_swarm.md would be ideal.

I'm not sure there's much to document here. The behavior is such that if you specify a volume or network driver, service tasks will only be scheduled on nodes that have that driver available. We should probably put a few sentences about this in the swarm mode docs, in the places networks and volumes are explained. I'm not sure the plugin docs need to mention it.

I've pushed an integration test for this to this PR and also #29378 (master version). PTAL.

LGTM

@aaronlehmann the tests don't cover v2 plugin codepath, I assume it's expected?

@aaronlehmann the tests don't cover v2 plugin codepath, I assume it's expected?

Yes, I'm reusing the external volume driver test code, which uses v1 plugins.

Do swarm services support scheduling on nodes with Authz plugins? If yes, then we need to add a case to cover authzdriver.

This is not supported at present.

LGTM

LGTM


1470 - rwx

preliminary pr for review of the current share manager code

Don't merge this.
This is the one share manager for multiple volumes approach.


Netlist representation for debugging

Hello, how feasible is it to generate a netlist from a SpiceSharp Circuit? Is this already implemented? It would seem to be just a matter of iterating through all the Entities of the circuit and printing each. Thanks!

Hi @csculley ,
I don't have plans or the intention to implement exporting to a netlists in the core package. However, I think it is quite feasible to do so (perhaps as an extra package) because in its most simple form it indeed just involves listing all entities and their parameters using reflection (all parameters are tagged with their Spice-equivalent names anyway).
Some small adaptations are probably needed, like extracting a PULSE statement from a Pulse instance, or what you want to with VoltageDelay which doesn't usually exist in most Spice simulators. With v3, there is also the new Subcircuit class, and the new ParallelComponent class (for allowing parallel computations), and they also don't necessarily translate in a simple way to "standard" Spice netlists.
@marcin-golebiowski is already dealing with a lot by trying to support the syntax of as many Spice-simulators as possible in Spice#.Parser. For example, behavioral sources have different syntax styles in different simulators, so maybe he can also give information if you decide on having a go. Let us know if you have questions getting this to work.
tldr;
I have no intention on working on exporting netlists in the core package. You can always make your own package to suit your own netlist syntax.

Thanks for the response! While using the SpiceSharp library, I've made my own debug statements just to get an idea of what I'm throwing into the circuit, but found myself wondering/wishing for something more formal to debug further, and wasn't sure if it was implemented already.

Hi,
An improved debugging experience is within my current scope, so I'll reopen this issue and see what we can do from that perspective.
What I'd like to avoid is implementing a netlist exporter that is compatible with other Spice packages. Ie. I want to avoid having logic in the core package that is required to have a netlist in "LTSpice" format, or "HSpice" format.
How about this?:

Change the ToString() method of entities to include some more information (like the name, and the connections for Component).
Add functionality to list parameters and entity collections through extension methods.
The resulting extension methods may generate text similar to netlists, but I will not make promises about compatibility with existing Spice packages.

Hey, I just wanted to say a huge thank you for the advanced logging features! We've already implemented it from the v3.0.1 release and it's been super helpful for debugging. The project I'm working on is actually able to be open-sourced, so I'll try to make sure it gets linked as a dependent when it gets open-sourced soon. Thanks again!

That makes me happy and motivated to work on the project :-)

Unfortunately, since the project is hosted on an enterprise instance of Github, it isn't detected as a dependency :pensive:. If you'd like to check out the project, there's a public release available here, but it's still under active development. Releases can be found here.

That's looking pretty nice! I don't mind the dependency not being detected, it's just nice knowing that it's being used. If you find any bugs, please let me know.


Fishing Station doesn't seem to work in public version 551176 (Whatta Blast)[issue]

Using the March 27th version of the Butcher/Fishing station mod with v551176 of ONI results in dupes standing at the fishing station and whistling forever, with no fish ever coming to the hook to be wrangled.
Previously, the same fishing stations in the same locations worked fine for hundreds of cycles. Butcher stations seem to work fine.
Love your mods!

A quick test showed that the problem is observed when there are different rooms at the top and bottom of the station.
And everything works well when the same room is at the top and bottom.

Also, the problem is not observed in the previous version of the game U45.
Presumably it is associated with the change of March 28

Fixed an issue where critters would sometimes freeze if a Duplicant tried to use their previous Grooming Station when there were no other eligible critters inside that room.

I'll see what's broken there.

Ah, I see. So my dupes get to do some hopping over a hole for a while. :)
Now I get to watch one rancher try to catch about 100 fish! 👍

I uploaded a new version of the mod to steam and to github


Add TLS ServerName as CLI option for Cadence Cassandra Tool

What changed?

Add ServerName as CLI option for cadence-cassandra-tool
Pass the ServerName to the cql client TLS config

Why?
Solve #5010.

How did you test it?
I built the cadence-server Docker image then execute the following command:
docker run --rm ubercadence/server:master --tls -u <user> --pw <password> --ep <endpoint> -p 9042 --tls-server-name <endpoint> -k cadence update-schema -d /etc/cadence/schema/cassandra/cadence/versioned

The error did not appear and the command finished successfully.

Potential risks
N/A

Release notes

Documentation Changes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.spham seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey there, this just needs the lint errors fixed. The build has details

Pull Request Test Coverage Report for Build 018441c7-d772-4009-b5e8-94c8ff6c8505

0 of 6 (0.0%)  changed or added relevant lines in 2 files are covered.
128 unchanged lines in 15 files lost coverage.
Overall coverage decreased (-0.03%) to 57.273%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tools/cassandra/handler.go
0
1
0.0%

tools/cassandra/main.go
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

service/history/queue/transfer_queue_processor_base.go
1
77.62%

common/task/weightedRoundRobinTaskScheduler.go
1
89.64%

service/matching/taskListManager.go
2
76.62%

common/membership/hashring.go
2
83.54%

service/history/queue/timer_gate.go
3
95.83%

service/history/execution/mutable_state_task_refresher.go
3
65.82%

common/task/fifoTaskScheduler.go
3
84.54%

service/history/task/transfer_standby_task_executor.go
4
86.4%

service/history/queue/timer_queue_processor_base.go
4
77.48%

common/persistence/statsComputer.go
6
93.57%

Totals

Change from base Build 01843ed5-ee07-42df-ab7e-c7e4b88b829a:
-0.03%

Covered Lines:
85196

Relevant Lines:
148753

💛  - Coveralls


To Do List: Add and remove

Hello👏
I have added functionality to the To-do list App. Some of the functionalities added are:

Tasks can be deleted using a delete button.
Tasks can be edited by clicking the task description.
Tasks can be marked as complete by clicking the button with the letter 'c' and thereafter deleted at one using the button 'clear all completed'.
All changes are saved to the locale storage.

Fixed the change from the previous reviewer.

Fixed the change from the previous reviewer.


Rancher sends thousands of 404 GET requests to EKS kube-apiserver

Rancher Server Setup

Rancher version: v2.6.2
Installation option (Helm Chart): EKS 1.21

Information about the Cluster

Kubernetes version:  EKS 1.21
Cluster Type (Local/Downstream):

Imported = Running kubectl apply onto an existing EKS cluster
Hosted = EKS

Describe the bug
When using Rancher Cluster explorer (anything under /dashboard/c/${cluster_name}, there are thousands of 404 requests sent to the kube-api server. Those requests originate from the service account system:serviceaccount:cattle-system:rancher of the rancher pod inside cattle-system in that cluster. The impersonatedUser.extra.username.0 matches the user that is logged in and exploring the cluster in the UI.
It appears that the rancher app randomly picks a resource name and loops through all possible resource types, sending a GET request to the kube-api.
To Reproduce
Create a local user
Browse around the Cluster explorer
Filter audit logs for:

responseStatus.code=404
impersonatedUser.extra.username.0=${user_name}

Result
Rancher somehow randomly picks a resource name or two and loops through all possible resource types with the same name. All these requests result in 404's and each 404 triggers a retry effectively causing a denial of service on itself. Once the requests to the api server skyrocket, EKS control plane autoscales to cope with the demand but that process takes a while as instances need to be rebuilt to change the instance type and this results in failing requests to the API.
If we do nothing, we experience API server unavailability on a daily basis. Prior to Rancher v2.6, to access the cluster explorer you had to deliberately click on a button. Now, by default, you land on the cluster explorer page which makes the problem much worse.  As a workaround, we have added a redirect to move users back to the old UI as much as possible but it doesn't cover all cases and also users do prefer to use the cluster explorer.
In the example below, I created a new cluster on EKS and installed rancher. It can be reproduced for imported clusters too. I created a local user named ivan-test and browsed around the cluster explorer. The resources Rancher tries to get in this scenario is sealed-secrets-backup which is a job I install and kube-root-ca.crt is the certificate available in each namespace.
Here, the 2 requested resource names actually exist, however, it is not clear to me how Rancher decided to target them. In other clusters, I have seen GET requests sent with non existing resource names too.
Expected Result
I do not expect to see random GET requests to the kube-api server for resources that do not exist.
Screenshots

SURE-3853

Hey @Sahota1225 can you review this with your team and confirm that this will fall into Team 2's realm since it's essential an EKS issue? If so, please triage it at your earliest convenience for possibility of v2.6.5 delivery.

To provide the UI analysis in the transfer back, the UI isn't making all these requests from what was spotted by @vincent99

I can confirm I'm seeing this same issue Rancher 2.6.3-patch1 with a downstream RKE 1.20.11 cluster running in AWS but not using EKS.  So it does not appear to be EKS related. I see the same impersonation and 404 in the kubernetes audit logs.   I'm unable to reproduce the issue outside of work on my personal setup.   Are you able to share your auth setup?  My work setup is using Azure AD and my person is local users.

I'm happy to report that rancher 2.6.4 appears to have resolved the issue.

I'm happy to report that rancher 2.6.4 appears to have resolved the issue.


make __nutype_{type_name}__ compatible with clippy lint

rust analyzer in VSCode complains about generated nutype module not being proper snake case, this PR fixes that with a naive to_lower_case call as I think nobody really cares about how exactly it is named except clippy x).

Thanks.
I think we should rather ignore the lint explicitly.
My concern is having 2 different types like
struct Notebook(..)

struct NotEBook(..)

can cause undesired collision in the module names.

@vic1707 Could you please apply #[allow(non_snake_case)]  instead?

Yeah you're right, I didn't think about it 👍
I chose to #[allow(non_snake_case, reason = "we keep original structure name which is probably CamelCase")].
Since not providing a reason can also trigger a warning x)

Thank you!


🐛 [firebase_messaging] io.flutter.plugins.firebase.messaging.FlutterFirebaseMessagingBackgroundExecutor.getPluginCallbackHandle

Bug report
Describe the bug
Android Flutter app crash. Report from crashlytics in Google Play Console.
Stacktrace
Click To Expand

Exception java.lang.RuntimeException: Unable to create service io.flutter.plugins.firebase.messaging.FlutterFirebaseMessagingBackgroundService: java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.SharedPreferences android.content.Context.getSharedPreferences(java.lang.String, int)' on a null object reference
  at android.app.ActivityThread.handleCreateService (ActivityThread.java:4823)
  at android.app.ActivityThread.access$3000 (ActivityThread.java:260)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2470)
  at android.os.Handler.dispatchMessage (Handler.java:110)
  at android.os.Looper.loop (Looper.java:219)
  at android.app.ActivityThread.main (ActivityThread.java:8668)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:513)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1109)
Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.SharedPreferences android.content.Context.getSharedPreferences(java.lang.String, int)' on a null object reference
  at io.flutter.plugins.firebase.messaging.FlutterFirebaseMessagingBackgroundExecutor.getPluginCallbackHandle (FlutterFirebaseMessagingBackgroundExecutor.java:275)
  at io.flutter.plugins.firebase.messaging.FlutterFirebaseMessagingBackgroundExecutor.startBackgroundIsolate (FlutterFirebaseMessagingBackgroundExecutor.java:116)
  at io.flutter.plugins.firebase.messaging.FlutterFirebaseMessagingBackgroundService.onCreate (FlutterFirebaseMessagingBackgroundService.java:106)
  at android.app.ActivityThread.handleCreateService (ActivityThread.java:4809)

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.0.5, on macOS 12.5 21G72 darwin-arm, locale en-NL)
[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.69.2)
[✓] Connected device (3 available)
[✓] HTTP Host Availability
• No issues found!

 Is there a way for you to possibly provide steps to replicate or code sample that triggers this crash locally ?

@darshankawar This has never occurred for me unfortunately, no. This is simply taken out of the Google Play Console.

Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.SharedPreferences android.content.Context.getSharedPreferences(java.lang.String, int)' on a null object reference
at io.flutter.plugins.firebase.messaging.FlutterFirebaseMessagingBackgroundExecutor.getPluginCallbackHandle (FlutterFirebaseMessagingBackgroundExecutor.java:275)
at io.flutter.plugins.firebase.messaging.FlutterFirebaseMessagingBackgroundExecutor.startBackgroundIsolate (FlutterFirebaseMessagingBackgroundExecutor.java:116)
at io.flutter.plugins.firebase.messaging.FlutterFirebaseMessagingBackgroundService.onCreate (FlutterFirebaseMessagingBackgroundService.java:106)

Seems to be coming from
https://github.com/firebase/flutterfire/blob/a6204128edf1f54ac734385d0ed6214d50cebd1b/packages/firebase_messaging/firebase_messaging/android/src/main/java/io/flutter/plugins/firebase/messaging/FlutterFirebaseMessagingBackgroundExecutor.java#L275
https://github.com/firebase/flutterfire/blob/a6204128edf1f54ac734385d0ed6214d50cebd1b/packages/firebase_messaging/firebase_messaging/android/src/main/java/io/flutter/plugins/firebase/messaging/FlutterFirebaseMessagingBackgroundExecutor.java#L116
https://github.com/firebase/flutterfire/blob/a6204128edf1f54ac734385d0ed6214d50cebd1b/packages/firebase_messaging/firebase_messaging/android/src/main/java/io/flutter/plugins/firebase/messaging/FlutterFirebaseMessagingBackgroundService.java#L106

Keeping it open and labeling for further insights from the team, as there's no replicable steps or code sample.
/cc @russellwheatley

Hey @darshankawar replicable steps are:

Implement FCM to Flutter (code examples can be found here.
App is in background, notification arrives, user clicks on notification.

@ljmatan  Yes, I meet the problem too. But I can't recurrent. Could you add some logs for FlutterFirebaseMessagingReceiver or FlutterFirebaseMessagingInitProvider to check  'context.getApplicationContext()' whether is null ?

Revisiting this, I tried the steps mentioned here https://github.com/firebase/flutterfire/issues/9332#issuecomment-1219323804 and ran on Samsung S10 device, but I was unable to replicate this issue.

This is still happening in version 14.6.1. Same error on play console with Android 10 on Huawei devices.
In debug mode it has not given me any errors in the tests. If I find out anything else I'll report it.

Just tried this on android 10 and 12 AVDs, I was able to open app via notification from background state without issue. We're going to need a repro. We cannot fix what we can't reproduce unfortunately.

I don't have any other info since I can't reproduce it. I just reported it straight from the crashlytics in Google Play Console.


"error: constraint 'std::max_len_value' does not exist" during create-migration

EdgeDB Version: EdgeDB 1.0-beta.1+g2eee1afe4.d20210301
Changing schema from:
abstract type Event {
  required property createdAt -> datetime {
    default := datetime_current();
  }

  required link user -> User;
}

type Post extending Event {
  required property content -> str {
    constraint min_len_value(1);
    constraint max_len_value(280);
  }
}

to:
abstract type Event {
  required property createdAt -> datetime {
    default := datetime_current();
  }

  required link user -> User;
}

abstract type HasContent {
  required property content -> str {
    constraint min_len_value(1);
    constraint max_len_value(280);
  }
}

type Post extending Event, HasContent {
}

type Reply extending Event, HasContent {
  required link post -> Post;
}

Run edgedb create-migration:
did you create object type 'default::HasContent'? [y,n,l,c,b,s,q,?]
y
did you alter object type 'default::Post'? [y,n,l,c,b,s,q,?]
y
did you create object type 'default::Reply'? [y,n,l,c,b,s,q,?]
y
did you drop constraint 'std::max_len_value' of property 'content'? [y,n,l,c,b,s,q,?]
n
did you alter property 'content' of object type 'default::Post'? [y,n,l,c,b,s,q,?]
y
error: constraint 'std::max_len_value' does not exist
  ┌─ query:3:9
  │
3 │ ╭         ALTER CONSTRAINT std::max_len_value(280) ON (std::len(<std::str>__subject__)) {
4 │ │             DROP OWNED;
5 │ │         };
  │ ╰─────────^ error

Rolling back last operation...
did you alter property 'content' of object type 'default::Post'? [y,n,l,c,b,s,q,?]
n
did you alter property 'content' of object type 'default::Post'? [y,n,l,c,b,s,q,?]

If you answer yes to did you drop constraint 'std::max_len_value' of property 'content'? [y,n,l,c,b,s,q,?], there's another error:
did you create object type 'default::HasContent'? [y,n,l,c,b,s,q,?]
y
did you alter object type 'default::Post'? [y,n,l,c,b,s,q,?]
y
did you create object type 'default::Reply'? [y,n,l,c,b,s,q,?]
y
did you drop constraint 'std::max_len_value' of property 'content'? [y,n,l,c,b,s,q,?]
y
error: cannot drop inherited constraint 'std::max_len_value' of property 'content' of object type 'default::Post'
  ┌─ query:3:9
  │
3 │         DROP CONSTRAINT std::max_len_value(280);
  │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error
  │
  = constraint 'std::max_len_value' of property 'content' of object type 'default::Post' is inherited from:
    - property 'content' of object type 'default::HasContent'

Rolling back last operation...
did you drop constraint 'std::max_len_value' of property 'content'? [y,n,l,c,b,s,q,?]
n
did you alter property 'content' of object type 'default::Post'? [y,n,l,c,b,s,q,?]

Seems like it shouldn't ask that question if there's only one correct answer?

There are probably multiple issues here, but the migration should definitely not be asking about the dropped constraint, because it wasn't, in fact, dropped.


Fix/253-Suggestions-email

Describe the bug
From the backend side has been confirmed that no resctrcition is given to the email in suggestion, it can be null but if I try to do a suggestion withou email it says it is needed it.
Expected behavior
If a person does not want to give the email, they have to be also able to make the suggestion.

Story Points: 2
See the discussion in Front PPL v2
Powered by Parabol


Integrate SwiftLint

Should follow the rules laid out in https://github.com/vapor/vapor/pull/1876 and automatically apply fixes when possible.
Should also be part of CI.

We're currently using async-kit as a test bed for GH integrations. If anyone wants to PR a swift lint CI workflow there I'd be happy to accept. Closing the issue here since it's not related to routing and more of a general vapor maintainer issue.


Switch to the rules_pkg packaging rules after the Bazel 4 upgrade

Can you update the README with the required bazel version?


Cassandra container timing out on archlinux

I used Cassandra container on archlinux for testing a java application. With version 1.12 and cassandra 2.2.2 until last week, it was working fine.
Since Friday, it seems broken.
From the logs, it seems that it hangs on cassandra start. I can see in the logs
INFO  00:55:52 Starting listening for CQL clients on /<IP_ADDRESS>:9042...

INFO  00:55:52 Not starting RPC server as requested. Use JMX (StorageService->startRPCServer()) or nodetool (enablethrift) to start it

INFO  00:55:54 Created default superuser role 'cassandra'

2019-10-22 00:56:40,658 INFO  🐳 [cassandra:2.2.2]  - Creating container for image: cassandra:2.2.2
2019-10-22 00:56:40,722 INFO  🐳 [cassandra:2.2.2]  - Starting container with ID: 49e494b67c40ffc442193d9b15313990505d2f001b9ddecf3ab7e2dcaa0a81d0
2019-10-22 00:56:41,090 INFO  🐳 [cassandra:2.2.2]  - Container cassandra:2.2.2 is starting: 49e494b67c40ffc442193d9b15313990505d2f001b9ddecf3ab7e2dcaa0a81d0

and the container is successfully created and responsive, but the container wrapper seems not to detect it and new containers are created till end of retries.
I thought it was something wrong my config, but I tried the cassandra container wrapper version 1.10 and it works fine (1.11 seems not working too).

Sorry, it seems it was a conflict with another container wrapper (elastic search).
I will close this and open a proper one if I can identify the issue

It seems it was indeed a bug
https://github.com/testcontainers/testcontainers-java/issues/1978
original issue https://github.com/docker-java/docker-java/issues/1259


Update does not kick in

Somehow it seems my system does not update.
Sep 09 12:04:38 localhost update_engine[2915]: [0909/120438:INFO:libcurl_http_fetcher.cc(289)] HTTP response code: 200
Sep 09 12:04:38 localhost update_engine[2915]: [0909/120438:INFO:libcurl_http_fetcher.cc(358)] Transfer completed (200), 267 bytes downloaded
Sep 09 12:04:38 localhost update_engine[2915]: [0909/120438:INFO:omaha_request_action.cc(619)] Omaha request response: <?xml version="1.0" encoding="UTF-8"?>
Sep 09 12:04:38 localhost update_engine[2915]: <response protocol="3.0" server="update.core-os.net">
Sep 09 12:04:38 localhost update_engine[2915]: <daystart elapsed_seconds="0"></daystart>
Sep 09 12:04:38 localhost update_engine[2915]: <app appid="e96281a6-d1af-4bde-9a0a-97b76e56dc57" status="ok">
Sep 09 12:04:38 localhost update_engine[2915]: <updatecheck status="noupdate"></updatecheck>
Sep 09 12:04:38 localhost update_engine[2915]: </app>
Sep 09 12:04:38 localhost update_engine[2915]: </response>
Sep 09 12:04:38 localhost update_engine[2915]: [0909/120438:INFO:omaha_request_action.cc(433)] No update.
...
Any  ideas what might be wrong?

Is update once again paused? Getting the same response on 815.0.0. Anf if, where is this documented?

@djablonski There are always rate limits in effect for quality of service, so you may be hitting one of those, but they are fairly high. This bug is quite old, since then we've tweaked the way the update_engine works such that any manual update request will skip all rate limits.
Update in background:
$ update_engine_client -check_for_update

Update in foreground:
$ update_engine_client -update

Docs: https://coreos.com/products/coreupdate/docs/latest/configure-machines.html#viewing-machines-in-coreupdate

I'm experiencing this issue for two days now, and it doesn't matter if I check with update_engine_client, the update_engine.service or calling the same URI via REST client. ZThe result is always "noupdate"...

@djablonski what is that machine's ID? cat /etc/machine-id

8f60746f65b740b19d343abc81cbb260

@djablonski Can you give it a try one more time? If that doesn't work, let's move this over to a new issue and get it sorted out. In the logs, your machine is coming through with an unknown OEM, how are you booting this machine?

@robszumski It works now! Update on 870.3.0 is downloading... :-)
Many thx!
Btw: I'm using CoreOS bare metal installation (ISO)

Great. The update was paused briefly while we verified a new release of 870.3.0. I wasn't aware of this earlier.
As a side note, this issue corrected my understanding of update_engine. Rate limits will be skipped, but a paused channel will stop everything. I had incorrectly thought that it would still let you update.


Github Action checkout v4 fails on fetching - git error - The process '/usr/bin/git' failed with exit code 128

Description
Checkout is suddenly failing where previously is worked.
jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4

Here are the logs
2024-05-17T13:28:21.2685483Z Current runner version: '2.316.1'
2024-05-17T13:28:21.2713144Z ##[group]Operating System
2024-05-17T13:28:21.2714202Z Ubuntu
2024-05-17T13:28:21.2714839Z 22.04.4
2024-05-17T13:28:21.2715355Z LTS
2024-05-17T13:28:21.2716053Z ##[endgroup]
2024-05-17T13:28:21.2716694Z ##[group]Runner Image
2024-05-17T13:28:21.2717400Z Image: ubuntu-22.04
2024-05-17T13:28:21.2718217Z Version: 20240516.1.0
2024-05-17T13:28:21.2719927Z Included Software: https://github.com/actions/runner-images/blob/ubuntu22/20240516.1/images/ubuntu/Ubuntu2204-Readme.md
2024-05-17T13:28:21.2722267Z Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240516.1
2024-05-17T13:28:21.2723882Z ##[endgroup]
2024-05-17T13:28:21.2724604Z ##[group]Runner Image Provisioner
2024-05-17T13:28:21.2725324Z 2.0.369.1
2024-05-17T13:28:21.2726037Z ##[endgroup]
2024-05-17T13:28:21.2727440Z ##[group]GITHUB_TOKEN Permissions
2024-05-17T13:28:21.2729641Z Checks: write
2024-05-17T13:28:21.2730366Z Metadata: read
2024-05-17T13:28:21.2731160Z ##[endgroup]
2024-05-17T13:28:21.2735556Z Secret source: Actions
2024-05-17T13:28:21.2736414Z Prepare workflow directory
2024-05-17T13:28:21.3348962Z Prepare all required actions
2024-05-17T13:28:21.3505779Z Getting action download info
2024-05-17T13:28:21.5290043Z Download action repository 'actions/checkout@v4' (SHA:0ad4b8fadaa221de15dcec353f45205ec38ea70b)
2024-05-17T13:28:21.6407523Z Download action repository 'actions/setup-java@v4' (SHA:99b8673ff64fbf99d8d325f52d9a5bdedb8483e9)
2024-05-17T13:28:22.1855762Z Download action repository 'mikepenz/action-junit-report@v4' (SHA:9379f0ccddcab154835d4e2487555ee79614fe95)
2024-05-17T13:28:22.7577248Z Complete job name: build
2024-05-17T13:28:22.8554631Z ##[group]Run actions/checkout@v4
2024-05-17T13:28:22.8555009Z with:
2024-05-17T13:28:22.8555253Z   repository: KualiCo/research-pdf
2024-05-17T13:28:22.8555733Z   token: ***
2024-05-17T13:28:22.8555973Z   ssh-strict: true
2024-05-17T13:28:22.8556209Z   ssh-user: git
2024-05-17T13:28:22.8556447Z   persist-credentials: true
2024-05-17T13:28:22.8556744Z   clean: true
2024-05-17T13:28:22.8556992Z   sparse-checkout-cone-mode: true
2024-05-17T13:28:22.8557284Z   fetch-depth: 1
2024-05-17T13:28:22.8557513Z   fetch-tags: false
2024-05-17T13:28:22.8557755Z   show-progress: true
2024-05-17T13:28:22.8558006Z   lfs: false
2024-05-17T13:28:22.8558220Z   submodules: false
2024-05-17T13:28:22.8558459Z   set-safe-directory: true
2024-05-17T13:28:22.8558723Z ##[endgroup]
2024-05-17T13:28:23.0480105Z Syncing repository: KualiCo/research-pdf
2024-05-17T13:28:23.0482181Z ##[group]Getting Git version info
2024-05-17T13:28:23.0482819Z Working directory is '/home/runner/work/research-pdf/research-pdf'
2024-05-17T13:28:23.0483840Z [command]/usr/bin/git version
2024-05-17T13:28:23.0534920Z git version 2.45.1
2024-05-17T13:28:23.0536880Z ##[endgroup]
2024-05-17T13:28:23.0708928Z Temporarily overriding HOME='/home/runner/work/_temp/8389cb9b-d92a-4bbe-a2a5-b8cd8fb26553' before making global git config changes
2024-05-17T13:28:23.0710754Z Adding repository directory to the temporary git global config as a safe directory
2024-05-17T13:28:23.0713930Z [command]/usr/bin/git config --global --add safe.directory /home/runner/work/research-pdf/research-pdf
2024-05-17T13:28:23.0717683Z Deleting the contents of '/home/runner/work/research-pdf/research-pdf'
2024-05-17T13:28:23.0719050Z ##[group]Initializing the repository
2024-05-17T13:28:23.0720012Z [command]/usr/bin/git init /home/runner/work/research-pdf/research-pdf
2024-05-17T13:28:23.0801663Z hint: Using 'master' as the name for the initial branch. This default branch name
2024-05-17T13:28:23.0803054Z hint: is subject to change. To configure the initial branch name to use in all
2024-05-17T13:28:23.0804186Z hint: of your new repositories, which will suppress this warning, call:
2024-05-17T13:28:23.0805017Z hint:
2024-05-17T13:28:23.0805659Z hint: 	git config --global init.defaultBranch <name>
2024-05-17T13:28:23.0806342Z hint:
2024-05-17T13:28:23.0807177Z hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
2024-05-17T13:28:23.0808823Z hint: 'development'. The just-created branch can be renamed via this command:
2024-05-17T13:28:23.0809621Z hint:
2024-05-17T13:28:23.0810027Z hint: 	git branch -m <name>
2024-05-17T13:28:23.0810970Z Initialized empty Git repository in /home/runner/work/research-pdf/research-pdf/.git/
2024-05-17T13:28:23.0828558Z [command]/usr/bin/git remote add origin https://github.com/KualiCo/research-pdf
2024-05-17T13:28:23.0867579Z ##[endgroup]
2024-05-17T13:28:23.0868341Z ##[group]Disabling automatic garbage collection
2024-05-17T13:28:23.0869161Z [command]/usr/bin/git config --local gc.auto 0
2024-05-17T13:28:23.0898846Z ##[endgroup]
2024-05-17T13:28:23.0900008Z ##[group]Setting up auth
2024-05-17T13:28:23.0907347Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2024-05-17T13:28:23.0941601Z [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
2024-05-17T13:28:23.1278897Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2024-05-17T13:28:23.1309399Z [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
2024-05-17T13:28:23.1559398Z [command]/usr/bin/git config --local http.https://github.com/.extraheader AUTHORIZATION: basic ***
2024-05-17T13:28:23.1632721Z ##[endgroup]
2024-05-17T13:28:23.1633743Z ##[group]Fetching the repository
2024-05-17T13:28:23.1645377Z [command]/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +aa0cb53aeff917109cb3c09602e83a23458bcf3c:refs/remotes/pull/2527/merge
2024-05-17T13:28:23.3328170Z remote: Repository not found.
2024-05-17T13:28:23.3354711Z ##[error]fatal: repository 'https://github.com/KualiCo/research-pdf/' not found
2024-05-17T13:28:23.3365133Z The process '/usr/bin/git' failed with exit code 128
2024-05-17T13:28:23.3365598Z Waiting 13 seconds before trying again
2024-05-17T13:28:36.3404572Z [command]/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +aa0cb53aeff917109cb3c09602e83a23458bcf3c:refs/remotes/pull/2527/merge
2024-05-17T13:28:36.4739772Z remote: Repository not found.
2024-05-17T13:28:36.4742262Z ##[error]fatal: repository 'https://github.com/KualiCo/research-pdf/' not found
2024-05-17T13:28:36.4761827Z The process '/usr/bin/git' failed with exit code 128
2024-05-17T13:28:36.4762640Z Waiting 14 seconds before trying again
2024-05-17T13:28:50.4811801Z [command]/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +aa0cb53aeff917109cb3c09602e83a23458bcf3c:refs/remotes/pull/2527/merge
2024-05-17T13:28:50.6123709Z remote: Repository not found.
2024-05-17T13:28:50.6125935Z ##[error]fatal: repository 'https://github.com/KualiCo/research-pdf/' not found
2024-05-17T13:28:50.6204422Z ##[error]The process '/usr/bin/git' failed with exit code 128

Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[X] Ubuntu 20.04
[X] Ubuntu 22.04
[X] Ubuntu 24.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
ubuntu-22.04 https://github.com/KualiCo/research-pdf/actions/runs/9129035800
Is it regression?
yes
Expected behavior
git should not fail on checkout
Actual behavior
git fails on checkout
Repro steps
simply use checkout v4 with ubuntu 22.04 runner (or any of the available ubuntu runners) and it will fail

Hey @leoherbie!
It shouldn't be image related since it seems as an old checkout issue: https://github.com/actions/checkout/issues/417. Please use one of the workarounds from the original issue. In case it won't work please ping us.

@leoherbie
As a possible solution you may try to use next environment variable: GIT_CLONE_PROTECTION_ACTIVE=false. I'm not sure that this is your case since your task is lfs: false, but latest Git release contain a security fix which blocks LFS users.

Thank you so much for the quick reply.  Sorry about filing it under the "runner-image" repo.  I found a similar issue that gained traction and was resolved under that repo so filed this one there too.  I will try the workaround.


Possible issue Starting Points vs Starting Resource and suggestions

Based on my very limited tests so far... in a word: WOW!
I have some notes.  I'm not sure if this is also the place for suggestions? Apologies in advance if there is a separate place for suggestions.
Suggestions:

Add the ability to fold or collapse and expand code sections
Case insensitive Search option
In the Game Setting Editor screen (I changed the default max points of 3000 AND added 4000 points as an option also).
a. Change Starting Points to Starting Resources to avoid possible confusion
b. Add a button to re-set selections to the game's default values
c. Highlight or add a field to indicate current game setting values

Also, in the Game Settings Editor screen, there is a Save button.  Does the button simply save the file to the disk, or does that also update (if the core files were changed by Eugen), or does it simply generate the mod; or, does it always do both ie. update and generate?
WME's ability to simply change the Base Income and the Time of when income increments, and other settings is very convenient and very welcomed!

Hi, thanks for your suggestions! It's absolutely fine to post them here.
To reply to some of them:

Collapsible code sections are very cool, but they would be a lot of effort to implement, especially if I were to do so in a performant manner. So they are not a high priority right now.
As discussed in the other issue, I'll put that on my todo-list

a) Do you mean the text is confusing?
b) Good idea
c) I don't think I understand this. Do you mean the default settings for each game mode?
Saving in the Game Settings Editor or the Operation Editor only writes the changes to the relevant files, you will still have to generate the mod to apply them in-game. Saving will however trigger a reload on any other page editing these files. If you have a text editor on GDConstantes.ndf open and save in the Game Settings Editor, the text editor will reload the file.

Hi. With regards to item 1, collapsible code.... maybe just a simpler version?   Not automatically collapse code based on language brackets or pairs but rather the ability to perhaps MANUALLY collapse code? For example, in a file with 1000 lines, pressing Alt-x on line 10 and pressing Alt-x again on line 90, will hide lines 10 to 90. Something perhaps simpler but similar to the picture below...
For item c) what I meant was to highlight the current setting in effect that was selected by the user which might have been selected previously (before the Game Setting Editor was opened, and not necessarily the default setting).


Issue Classification Scenario Fails After Multiple Refinements

System Information (please complete the following information):

Model Builder Version: 16.0.2003.302
Visual Studio 2019 Enterprise

Describe the bug
Using the Issue Classification Scenario:
After a failed attempt to Train, I revisited the Data screen and changed some of the columns. I then attempted another Train that failed again. I changed more of the columns settings and attempted a third time to Train. This time an error was thrown as in the below image.
To Reproduce
Steps to reproduce the behaviour:

Go to 'Scenario' and select 'Issue Classification'
Select a file with multiple text columns using ';' as the delimiter.
Select a 'Label' and as many 'Feature' columns as reasonable.
Click 'Train'
Input 180 as the 'Time to train'
Click 'Start training'
If no exception is thrown, edit 'Feature' columns and repeat steps 4-6.
Exception is thrown.

Expected behaviour
I expected to be able to repeat steps 3-6 as many times as necessary to complete a successful training session.
Screenshots

Additional context
As I'm using version control, I reverted my version and tried again. I also tried restarting VS. Now every time I attempt to train, the exception is thrown. I would attach the data source file, but it contains sensitive database schema information.

More Additional Context:
The first attempt to train produced this exception:

Looks like a bug to me as issue classification should be able to accept all data type as features.
Is that possible for you to provide part of your dataset, you can clear schema information if you have concern over security matters.

Thanks for your quick response to this issue! Here is a copy of the file with all the characters scrambled. The instances of characters are the same, so it should generate the same results. When I encountered the exception, it was using the 'Purpose' column as the Label. Using a different column ('Returns') did not produce an exception, although leaving it running through the night did not result in any predictions.
Scrambled.txt

Your scrambled.txt has newline char in string, which can't be loaded in ModelBuilder because of an existing bug: https://github.com/dotnet/machinelearning/issues/4464. And since it's all text-based, ModelBuilder can't detect it's delimiter either, which should be a bug in Prose.
And after I replace the /n char with /newline and replace all ',' to ' ', filter out all the lines which # of '; ;' is not 6 (the # of ';' in header). the dataset seems to be able running in ModelBuilder without error. But it takes forever to give a result. which may be related to your Scrambled dataset, which is all text-bases and some of text is really long. Transforming text field can be really time consuming, for detailed info, you can take a look at this Issue. And after I reduce the Scrambled data from 2700+ lines to 100 lines, I can get a result within 100s.
So do you also change column type when scramble dataset, what's your system's language? This issue seems really wield, could you provides more info?

Closing this issue due to no response,  if you're still seeing a problem, feel free to reopen it, thanks for reporting!


Version 0.8.26 doesn't start

bundle exec volt server
Volt 0.8.26
Using rack adapter
/Users/ypcat/.rvm/gems/ruby-2.1.3@volt/gems/volt-0.8.26/lib/volt/server/rack/asset_files.rb:38:in `component': Unable to find component 'rspec-builder.rb', make sure the gem is included in your Gemfile (RuntimeError)

What os and version are you on?

Confirmed to run fine for me on ubuntu 14.04 with ruby 2.2.0 and volt 0.8.27beta3, so upgrading to the latest version of the gem may fix things @ypcatify , so if youre on Linux that could fix it. If OSX it still may help as well.

Sorry for late response, I'm using OSX Yosemite with Ruby ruby-2.1.3.

Tested with ruby 2.2.0 under OS X 10.10.2. Everything works fine.

Upgrading to Ruby 2.2.0 helped. Thank you.

Doesn't work for me, fresh ruby 2.2.1 with newly created gemset, OS X 10.10.2

Problem is with component_paths.rb method app_folders. It does this:
app_folders += Gem.loaded_specs.values.map(&:full_gem_path).reject { |g| g !~ /volt/ }.map { |f| f + '/app' }

This would probably be a great idea if I didn't use volt as gemset name ;) This causes, like, everything to add itself to app_folders and because opal-rspec-0.3.0.beta3/app actually exists, it adds file inside to load asset loading path and crashes.
The easiest solution I can think of is:
app_folders += Gem.loaded_specs.values.reject { |g| g.name !~ /volt/ }.map(&:full_gem_path).map { |f| f + '/app' }

# or a bit nicer
app_folders += Gem.loaded_specs.values.map { |g| File.join(g.full_gem_path, 'app') if g.name =~ /volt/ }.compact

# or even nicer (because of single pass) but slightly less readable
app_folders += Gem.loaded_specs.values.reduce([]) { |paths, gem| paths << File.join(gem.full_gem_path, 'app') if gem.name =~ /volt/; paths }

If you want me to send a pull request (maybe with additional test or two?), I'll be happy to provide one after wroclove.rb :)

@d4rky-pl awesome you figured it out.  I hadn't been able to duplicate this on my end and I don't think anyone put together that a volt gemset was the problem.  A PR would be great.  I'll be at wroclove, so see you there :-)

I ran into the same issue (OS x yosemite using rvm and ruby-2.1.5) @d4rky-pl fixe looks like a cleaner way than I did it, but the principle was the same.

@d4rky-pl  - Good call.

I believe this is fixed in 0.9, please reopen if its not.


Remember token behaviour not woking quite as it should when logging out

Laravel Version: 5.4.17
PHP Version: 5.6.29
Database Driver & Version: N/A

Description:
I think it's an bug, where when you logout via SessionGuard and you have set
the session config to 'expire_on_close' => true you would expect this to have an
impact on the logout behaviour of SessionGuard.
When looking at the code link framework/src/Illuminate/Auth/SessionGuard.php:483 where the logout implementation is:

Conclusion
As seen in the code, there are conditions for checking if the remember token should be generated.
Please let me know if this is and unthought of scenario or if it's here i need to make my own driver?

Can you please share more information? Like what do you expect in the described situation and what you get instead?

ping @askilada

My understanding on how the session.php flag expire_on_close is set to true the functionality at line 493 should not cycleRememberToken because it have been disabled in the config.
This make it so you can not disable remember token.

ping @themsaid


Fix: Issue #1936 CalcCellValue silently fails when formula is =OTHER_FORMULA

Fix: Issue #1936 CalcCellValue silently fails when formula is =OTHER_FORMULA
PR Details

Return Error if it doesn't have "#N/A"
Related Issue
CalcCellValue silently fails when formula is =OTHER_CELL and OTHER_CELL has a formula evaluation error #1936
How Has This Been Tested
I added a unit test for the changes.
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)

Checklist

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

What is missing for this to be merged?


Split FBMS into a multi-module Gradle project

Outline:

fbms-parent (no publish)

fbms-core (builds to .jar)
fbms-webapp (builds to .war)
[fbms-webcomponents (Node plugin;  maybe)]

Merged.


Scala CLI prints warning about project root directory when all sources are in the same directory

Version(s)
0.2.0
Describe the bug
Scala CLI prints warning about projet root direcotry even if all files are in the same directory.
To Reproduce
➜  scala-demo tree
.
├── demo.scala
└── demo.test.scala

0 directories, 2 files
➜  scala-demo scala-cli demo.scala demo.test.scala
Warning: setting /private/tmp/scala-demo as the project root directory for this run.
Compiling project (Scala 3.2.2, JVM)

Expected behaviour
I would expect that if all files are in the same directory, the warning will not be printed.

I can confirm this still happens with Scala 3.4.1 and Scala CLI 1.2.2.
Also, adding an empty project.scala or build.scala file in that directory doesn't better the situation.


ci: use large GHA runner

cilium/cilium has started using large GitHub Action Runners to run multi-kernel tests. Since they support nested KVM virtualization, they are much faster than the approach we are using here.
Currently, we are using aggressive job splitting to parallelize our existing workflow and work around this slowness. With a large GHA runner, we could eliminate or at least reduce the need to do this while speeding up CI jobs by about 2x.

The steps needed to do this would basically be:

Enable large GHA runners for this repo (cc @aanm)
Change ubuntu-20.04 runner to a large GHA runner
Reduce the group count to 1 in the gotests job to prevent hogging too many resources

@willfindlay this should be done now


Fixed  location in clearable_file_input.html template.

Error inside clearable_file_input.html

Could you add a test for that?

ok, will try to do that :)

@timgraham where would i put this test? Could you point me to where it makes sense to add that test. Preferably where some other template files are tested already. Just startet the test suit and saw that there are 11440 test. :) There probably is one doing what i want to for another template.
A test trying to render all input elements on one admin page would make the most sense i think.

Look at af1f986360dc6bb6e75e960dbc191707541128ac for a similar fix.

Okay, i tried to implement a test for that, but this is more broken than i thought it was
there are THREE templates for the clearable_file_input(.html)
2 of em are identical
django/forms/templates/django/forms/widgets/clearable_file_input.html
django/forms/jinja2/django/forms/widgets/clearable_file_input.html
1 of em got enhanced
django/contrib/admin/templates/admin/widgets/clearable_file_input.html
Here is the commit that changed it:
https://github.com/kakulukia/django/commit/b52c73008a9d67e9ddbb841872dc15cdd3d6ee01
Its a pretty big change and it looks like you where involved in commiting it?
Somebody should have a look at this who knows more about the Django internals than i do. I feel out of place here.
That totally is against DRY but im not able to judge if it might be neccessary here.
Anyways, i found the place where that very test should go:
tests/forms_tests/widget_tests/test_clearablefileinput.py
But adding a new test for the admin widget brought up a
django.template.exceptions.TemplateDoesNotExist: admin/widgets/clearable_file_input.html
I dont know why this is happening, because the template is there .. the test suit is running fine but something seems to not be setup the right way?
Any advice?

Oh, I didn't notice this was the admin widget template. In that case, look at tests/admin_widgets for a test.

But do you know why DRY is violated here? 2 times?

The templates in django/forms/templates are for the Django template language.
The templates in django/forms/jinja2 are for the Jinja template language.
The admin's template is customized with a <span> for styling purposes.

Is the an HTML linter ready to be indes for tests like this in the rest suit?

*used

I'm not sure what you mean. There are some tests in admin_widgets that are checking HTML. Can you follow that pattern?

the test suit already has an HTML validator/linter included that kicked in as i was trying to render the broken widget template, but there is no test validating the resulting HTML :(
Test is included now!


help: Document option to add stream to default streams when creating.

Option was introduced in #24216.

Merged, thanks @alya!


docs: Fix SignableTransaction docs to use PrimitiveSignature

Motivation
Signature is being migrated to PrimitiveSignature and all alloy code now uses the latter
from: https://github.com/alloy-rs/core/issues/788

Solution

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

needs rustfmt

thanks, fixed: https://github.com/alloy-rs/alloy/pull/1743/commits/ca722c2d1a59386c705ddbbc5cfd4cbab13bbfce


Ability to change present mode on the fly

Is it possible to change present modes on the fly, instead of just at initialization? I'm building a game framework with skulpin-renderer and it would be nice if it was.
An API like this could work. (a way to get a list of available present modes is nice too).
let mut renderer = ...;
renderer.try_set_present_mode(PresentMode::Immediate)?;

Hello, sorry I forgot to reply! I'm actually wanting to reduce the API that's exposed.. there is a preview in this branch: https://github.com/aclysma/skulpin/tree/use-rafx
This change will actually remove present mode entirely. It's certainly possible to expose it and if you're willing to destroy/recreate the swap chain, it would be possible to change the present mode. However, I think you'd need to write your own renderer that uses skulpin. (But it will take a lot less code with the changes in that branch to do it, and you'll get a lot more flexibility).
Would you mind explaining why you want to set the present mode at runtime? Generally speaking the choice is mostly about if you want to reduce latency (games) or improve battery life (a productivity application like neovide), so I'm curious what you have in mind. :)

I should add, part of the reason I want to reduce the API is so that I can add support for metal or other graphics backends. PresentMode is a concept that AFAIK only exists in Vulkan and I'd rather not expose backend-specific APIs unless there is a really good reason to do it.

I didn't actually mean to be able to pick a specific Vulkan present mode, sorry. The request was purely so I can enable/disable immediate drawing at runtime. In Vulkan, that would be switching between Immediate and Mailbox, hence the original opening of this issue.
The motivation for me to request such functionality is because I'm building a rhythm game. Such games are best with immediate drawing to reduce latency, but IMO a switch for disabling that would be convenient if one wanted to run the game on a battery-powered device.
If there is a similar "enable/disable VSync" in Metal, OpenGL or other Skia backends you want to support, then I think the request is not far-fetched.

Ah ok, that makes sense. Vsync enabled/disabled is a good level of abstraction and is broadly supported across graphics APIs. This is just a matter of passing a bool when building the swapchain so changing it at runtime will require rebuilding the swapchain.

Also, this may be a bit off-topic, but do you plan on supporting OpenGL alongside Vulkan & Metal in Rafx for compatibility with older hardware?

I’m definitely thinking about it. Likely it would be ES 2.0 to support WebGL. WebGL2 is not supported on Apple devices and webgpu is not natively supported/enabled by default in any browser AFAIK. A gl backend would not have feature parity with other backends because of API limitations. I’m not sure when I’ll get around to it. The list of things I want to do is pretty long! :)


ServiceAccount is not set to PrometheusExporter deployment

The specified SA in the PubSubPlusEventBroker spec is being set to Broker's StatefuleSet alone and not to the generated PrometheusExporter Deployment. We are using OCP 4.
Here is our spec:
apiVersion: pubsubplus.solace.com/v1beta1
kind: PubSubPlusEventBroker
metadata:
  name: dev3-eventbroker
  namespace: infra
  labels:
    app: solace-pubsubplus-eventbroker
spec:
  image:
    repository: solace/solace-pubsub-standard
    tag: "<IP_ADDRESS>"
  redundancy: true
  service:
    type: ClusterIP
  securityContext:
    fsGroup: 2000
    runAsUser: 2000
  serviceAccount:
    name: dev3-eventbroker
  monitoring:
    enabled: true
    image:
      repository: solace/pubsubplus-prometheus-exporter
      tag: 1.0.0
  storage:
    useStorageClass: gp2-ebs-csi-default
    messagingNodeStorageSize: 99Gi
    monitorNodeStorageSize: 49Gi
  tls:
    enabled: true
    certFilename: tls.crt
    certKeyFilename: tls.key

Here is the Operator generated deployment (edited for brevity):
kind: Deployment
spec:
  replicas: 1
  template:
    spec:
      containers:
        - name: exporter
          env:
            - name: SOLACE_WEB_LISTEN_ADDRESS
              value: >-
                tcp-metrics://dev3-eventbroker-pubsubplus-prometheus-metrics.solace-pubsubplus.svc.cluster.local:9628
            - name: SOLACE_SCRAPE_URI
              value: >-
                https://dev3-eventbroker-pubsubplus.solace-pubsubplus.svc.cluster.local:1943
            - name: SOLACE_LISTEN_TLS
              value: 'false'
            - name: SOLACE_USERNAME
              value: monitor
            - name: SOLACE_PASSWORD
              valueFrom:
                secretKeyRef:
                  name: dev3-eventbroker-pubsubplus-monitor-creds
                  key: username_monitor_password
            - name: SOLACE_SCRAPE_TIMEOUT
              value: 5s
            - name: SOLACE_SSL_VERIFY
              value: 'false'
            - name: SOLACE_INCLUDE_RATES
              value: 'false'
            - name: SOLACE_SERVER_CERT
              value: .
            - name: SOLACE_PRIVATE_KEY
              value: .
          securityContext:
            capabilities:
              drop:
                - ALL
            privileged: false
            runAsNonRoot: true
            allowPrivilegeEscalation: false
            seccompProfile:
              type: RuntimeDefault
          ports:
            - name: tcp-metrics
              containerPort: 9628
              protocol: TCP
          imagePullPolicy: IfNotPresent
          terminationMessagePolicy: File
          image: >-
            solace/pubsubplus-prometheus-exporter:1.0.0
      restartPolicy: Always
      terminationGracePeriodSeconds: 30
      dnsPolicy: ClusterFirst
      securityContext: {}
      schedulerName: default-scheduler

Since the SA is not set, Prometheus exporter pod is not coming up.
"dev3-eventbroker-pubsubplus-prometheus-exporter-d5ff69cff-2wfsh" is forbidden: unable to validate against any security context constraint

Hi @cedar715, the Prometheus exporter pod is supposed to use the default service account for the project because this pod requires no special rules added. Is there no default SA in your OpenShift project?

Hi @bczoma, the default SA is present. However, since there is no SCC associated with it, it's not working. Here's the full error message:
        is forbidden: unable to validate against any security context
        constraint:
        [pod.metadata.annotations.container.seccomp.security.alpha.kubernetes.io/exporter:
        Forbidden: seccomp may not be set provider "my-scc-1":
        Forbidden: not usable by user or serviceaccount provider
        "my-scc-2": Forbidden: not usable by user or
        serviceaccount provider "my-scc-3": Forbidden: not usable by user or
        serviceaccount provider "my-scc-4": Forbidden: not usable by user
        or serviceaccount]```

If I do these options, it works:
1. Edit generated deployment spec and add SA which has SCC associated (basically used Broker's SA)
2. Remove the lines
    ```  seccompProfile:
              type: RuntimeDefault```


Implement secure boost scheme phase 1 - vertical pipeline with hist sync

For implementing Vertical Federated Learning with Secure Features, as discussed in
https://github.com/dmlc/xgboost/issues/9987
The first phase is to implement an alternative vertical pipeline that sync the histograms from clients to label owner.
This PR implemented this feature as a standalone data mode.
Functional changes finished, currently adding unit testings
Note: phase 2 will be adding HE encryption features, which will be added in an independent PR

@trivialfis

I have enabled all the CI pipelines, please don't push until they finish, otherwise a new commit will interrupt the previous run. The PR looks good to me overall and will approve once all tests pass.
Please note that after having all the desired features in the feature branch and having a full picture of the code changes, we might do a few rounds of refactors before merging into the master. This way we can unblock these individual PRs while keeping the code maintainable in the future.

I have enabled all the CI pipelines, please don't push until they finish, otherwise a new commit will interrupt the previous run. The PR looks good to me overall and will approve once all tests pass.
Please note that after having all the desired features in the feature branch and having a full picture of the code changes, we might do a few rounds of refactors before merging into the master. This way we can unblock these individual PRs while keeping the code maintainable in the future.

sounds good! Thanks a lot. :)