UI Support for the Rock Paper Scissors Command

Added buttons/ui support for the rock paper scissors command.
( I haven't tested this yet because i was too lazy to make a seperate bot and grab its token to test it myself. If there are any changes that are needed. Please let me know <3 )

A minor change for using hyperlink in source code command

It looks like there a very small issue, on this line self.ai = random.choice["Rock", "Paper", "Scissors"] needs to be self.ai = random.choice(["Rock", "Paper", "Scissors"]) but other than that it seems to work great! I will merge this pull request and change that myself.

It looks like there a very small issue, on this line self.ai = random.choice["Rock", "Paper", "Scissors"] needs to be self.ai = random.choice(["Rock", "Paper", "Scissors"]) but other than that it seems to work great! I will merge this pull request and change that myself.

oh yeah these rookie syntax errors really do get me sometimes. Thanks for merging it!


Adds EXTRACT operator for extracting fields from DATETIME

This PR adds parser and resolver support for the EXTRACT operator.
Since the backend DateExtractOperation and DateExtractUncheckedOperator are already there. So the EXTRACT operator feature is complete. SQL tests are also added.

@jianqiao In the title, replace operator with function.

LTGM. Merging. I see the Travis error, but that is my bad as the line is over 120 characters and I'll fix it next in a separate PR.
Thanks @jianqiao.


infracost: 0.10.27 -> 0.10.28

Description of changes
change log: https://github.com/infracost/infracost/releases/tag/v0.10.28
diff: https://github.com/infracost/infracost/compare/v0.10.27...v0.10.28

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 248241 run on x86_64-linux 1

1 package built:

infracost


Dependencies not working in demo website

Hi,
the demo page at https://formly.dev/docs/examples/advanced/json-schema does't work for schema_dependencies.
I would expect that by selecting "Do you have any pets?" a new field "How old is your pet?" should show as per schema definition, but nothing happens.

Hi, I work with Alexandru and I took a look at the issue and I think there's an error inside FormlyJsonschema service when the "hide" expression is being created. I refer to lines 303 and 311, where a function with the following properties is defined:

An argument “m” (I suppose that is an abbreviation of "model")
In the implementation tries to retrieve the value of another field by accessing "m"

The problem is that the argument passed to the lambda is the field, not the model. So I think that the solution is to retrieve the other field value by accessing "field.model":

line 303:- hide: (m: any) => !m || getConstValue(constSchema as JSONSchema7) !== m[property],
+ hide: (f) => !f.model || getConstValue(constSchema as JSONSchema7) !== f.model[property],

line 311:- hide: (m: any) => !m || isEmpty(m[property]),
+ hide: (f) => !f.model || isEmpty(f.model[property]),

Note that "m: any" has been replaced with "f" and "m" with "f.model".
Let me know if you want me to open a pull request.

Let me know if you want me to open a pull request.

Yes,  please!

This issue has been fixed and released as part of v6.0.1 release.
Please let us know, in case you are still encountering a similar issue/problem.
Thank you!


chore: use gulp-cache in CI

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Perf comparision

Scenario
Fluent TPI
Fabric TPI
Ratio
Iterations
Ticks

Button.Fluent
1.17
0.12
9.75:1
5000
5863

Checkbox.Fluent
1.32
0.23
5.74:1
5000
6621

Icon.Fluent
0.25
0.03
8.33:1
5000
1239

Slider.Fluent
1.81
0.25
7.24:1
5000
9073

  Generated by :no_entry_sign: dangerJS

Cool change! I wonder how much gains you are expecting with this change?
@ecraig12345 is looking at helping make the /docs into a full package. This kind of optimization should be preserved

@kenotron I don't think it's really works 😭 I am going to spend more time tomorrow to make it working. I expect that it should save us around 3 mins on unit tests & Screener:
[07:24:14] Finished 'build:docs:component-menu-behaviors' after 2.32 min
[07:24:51] Finished 'build:docs:component-info' after 2.92 min
// Time spent there

Now it works 🚀


node_color and node_marker only accept Symbol

It seems not possible to use arbitrary colors such as RGB, HSL in ColorTypes, and Polygon, BezierPath to customize node shape.

just found that it needs to set in the graphplot function, using the p.node_color will not work.

This looks like some Observable type is set prematurely.  Could you post the full error?  It would help us get an idea of how this could be fixed.

using CairoMakie,GraphMakie,Graphs

g = wheel_graph(10)
f, ax, p = graphplot(g)
hidedecorations!(ax); hidespines!(ax)
ax.aspect = DataAspect()
p.node_color=RGBAf(0,0,1,1)

ERROR: MethodError: Cannot convert an object of type RGBA{Float32} to an object of type Symbol
Closest candidates are:
convert(::Type{T}, ::T) where T
@ Base Base.jl:64
convert(::Type{F}, ::F, ::BlackBoxOptim.FitnessScheme{F}) where F
@ BlackBoxOptim C:\Users\fff00.julia\packages\BlackBoxOptim\I3lfp\src\fitness.jl:26
Symbol(::Any...)
 If you don't set node_color in the graphplot command, it'll be initialized with :automatic. Later one, you cannot change an observable of type
p.node_color::Observable{Symbol}

to Observable{RGBA{Float32}}. If you want to change it later you need to prepare the observable with the correct types. For example
f,ax,p = graphplot(g; node_color=[RGBA(0,0,0,0) for _ in 1:3])
p.node_color[][1] = RGBA(1,0,0,0)

to change the color of the first node of a 3 node graph.

Feel free to ask further questions here but I'll close the issue since it is like that everywhere in Makie.


caffe2 install fail

I have install protobuf 2.6.1 in ubuntu 16. when make caffe2, it encounter the follow errors, how to solve them?
[  1%] Built target nccl_external
[  1%] Built target python_copy_files
[  2%] Built target gmock
[  3%] Built target gmock_main
[  3%] Built target gtest
[  4%] Built target gtest_main
[  7%] Built target benchmark
[  7%] Built target output_test_helper
[  8%] Built target reporter_output_test
[  9%] Built target multiple_ranges_test
[  9%] Built target cxx03_test
[  9%] Built target map_test
[ 10%] Built target benchmark_test
[ 10%] Built target basic_test
[ 10%] Built target complexity_test
[ 11%] Built target diagnostics_test
[ 12%] Built target options_test
[ 13%] Built target skip_with_error_test
[ 14%] Built target fixture_test
[ 14%] Built target donotoptimize_test
[ 15%] Built target filter_test
[ 16%] Built target register_benchmark_test
[ 20%] Built target gloo
[ 21%] Built target gloo_cuda
[ 22%] Running C++/Python protocol buffer compiler on /home/ubuntu/caffe2/caffe/proto/caffe.proto
/bin/sh: 1: PROTOBUF_PROTOC_EXECUTABLE-NOTFOUND: not found
caffe/proto/CMakeFiles/Caffe_PROTO.dir/build.make:61: recipe for target 'caffe/proto/caffe.pb.cc' failed
make[2]: *** [caffe/proto/caffe.pb.cc] Error 127
CMakeFiles/Makefile2:1281: recipe for target 'caffe/proto/CMakeFiles/Caffe_PROTO.dir/all' failed
make[1]: *** [caffe/proto/CMakeFiles/Caffe_PROTO.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2

Did you install protobuf with sudo apt-get install libprotobuf-dev? If so, you can install the corresponding compiler with sudo apt-get install protobuf-compiler.

Hi I installed both the packages still getting same Error.


Any idea of implement on MMDetection codebase?

Thx for your excellent job. I am free to provide you with 4 * 3090 gpus to reproduce the PPYoloE results. But most of my work is based on MMDetection codebase. I wish we can reproduce the network on MMDet codebase.
Look forward to hear from you.

Thx for your excellent job. I am free to provide you with 4 * 3090 gpus to reproduce the PPYoloE results. But most of my work is based on MMDetection codebase. I wish we can reproduce the network on MMDet codebase. Look forward to hear from you.

Hi! You can train COCO2017 from scratch with my codes https://github.com/miemie2013/miemiedetection
just input these commands:
wget https://paddledet.bj.bcebos.com/models/pretrained/CSPResNetb_s_pretrained.pdparams
python tools/convert_weights.py -f exps/ppyoloe/ppyoloe_crn_s_300e_coco.py -c CSPResNetb_s_pretrained.pdparams -oc CSPResNetb_s_pretrained.pth -nc 80 --only_backbone True
CUDA_VISIBLE_DEVICES=0,1,2,3,4,5,6,7
python tools/train.py -f exps/ppyoloe/ppyoloe_crn_s_300e_coco.py -d 8 -b 256 -eb 16 -c CSPResNetb_s_pretrained.pth --fp16

Please refer to https://github.com/miemie2013/miemiedetection/blob/main/docs/README_PPYOLO.md for more details.

能通过知乎私发给我你的wechat吗？
知乎链接：https://zhuanlan.zhihu.com/p/505992733

能通过知乎私发给我你的wechat吗？ 知乎链接：https://zhuanlan.zhihu.com/p/505992733

I feel sorry to be here.

能通过知乎私发给我你的wechat吗？ 知乎链接：https://zhuanlan.zhihu.com/p/505992733

I feel sorry to be here.

It doesn't matter I looked at your code, too. It's great

@cydiachen I have the idea to reproduce the network on MMDet. I hope we can reproduce it together

@cydiachen I have the idea to reproduce the network on MMDet. I hope we can reproduce it together

hello, I have contacted you on Zhihu. Feel free to contact me. I am now profreading your repo and trying on some work of deployment on your excellent work.


sql server column names: unable to disable quotes / incorrect quoting

Environment
official docker image (liquibase/liquiabse:latest)
Liquibase Integration & Version:
cli (official docker images)
Liquibase Extension(s) & Version:
none added to official docker image
Database Vendor & Version:
microsoft sql server 2019
Description
liquibase is generating invalid sql, adding extra '[' and ']' to my column definition, even with objectQuotingStrategy:  QUOTE_ONLY_RESERVED_WORDS
Steps To Reproduce
using the following yml:

changeSet:
id: broken_table_with_hash Create Table
objectQuotingStrategy:  QUOTE_ONLY_RESERVED_WORDS
author: Andrew Hill
changes:

createTable:
schemaName: dbo
tableName: brokenHash
columns:

column:
name: "[SomeTextHash]  AS (CONVERT(binary,hashbytes('SHA2_256',[SomeText]))) PERSISTED"
computed: true
type: ""
column:
constraints:
nullable: false
name: SomeText
type: varchar(50)
modifySql:

replace:
replace: "[]"
with: ""

generates the broken sql (inserts marked with :red_circle:):
CREATE TABLE dbo.brokenHash ([:red_circle:[SomeTextHash]:red_circle:]  AS (CONVERT([binary]:red_circle:](16),hashbytes('SHA2_256',[SomeText]]:red_circle:))) PERSISTED:red_circle:], SomeText varchar(50) NOT NULL)
Expected/Desired Behavior

I would like liquibase to generate valid sql :
CREATE TABLE dbo.brokenHash ([SomeTextHash]  AS (CONVERT(binary,hashbytes('SHA2_256',[SomeText]))) PERSISTED , SomeText varchar(50) NOT NULL)
I would like to be able to setup a calculated column using something like the above, and not need to worry about all the extra []'s added

Additional Context
I am attempting a somewhat supported thing here, trying to force the generation of specific text for the column definition, but there appears to be no path for this.

Hi @AartBluestoke Thanks for creating this suggestion.  Creating a column with the name that includes the function to call for the computed column is not supported in this way.
I would suggest using something like this instead
column:
name: "SomeTextHash"
computed: true
valueComputed: (CONVERT(binary,hashbytes('SHA2_256',[SomeText]))) PERSISTED
Not sure about the [] around the SomeText portion
Here are the attributes of a column in Liquibase
https://docs.liquibase.com/change-types/community/add-column.html
and scroll down the page to the information about the column tag section

after having some initial issues with this, i initially solved this with hard coded sql, just to get something working. I've revisitied this now;
changes:
    - addColumn:
        columns:
        - column:
            name: "isThing"
            computed: true
            valueComputed: "(case when things then 1 else 0 end) persisted"
            type: int
        schemaName: dbo
        tableName: SomeTable

generated
UPDATE dbo.SomeTableSET isThing= (case when things then 1 else 0 end) persisted
this was an add column statement.
type is required, however its value doesn't affect the output ; sql server derives the type from the output of the calculation.
in 3.x the changeset originally listed worked.


getPresenter() null during activity onCreate()

Is this by design?

Hi, you probably forgot to annotate the view class with @RequiresPresenter annotation.

Ahh yep.
So should Presenter.getView() be null during Presenter.onCreate() ?

Yes. It is non-null only between onResume/onPause.

I'll add an exception for such this case.


possibility to unset headers in system/Controllers/Controller.php and system/Controllers/ContentController.php

Dear Sebastian Schürmanns,
I currently set all the headers you set in these PHP-scripts in my webserver config (and a few more) so I quoted them in the PHP-scripts, how do you think about a config option making these headers removable?
Kind regards
Harald Jenny

Yes, that is possible and a good idea. I will add that configuration to the next release. As this configuration is quite on an expert-level, I will add it only to the settings.yaml-file as another option for devs. Maybe I will add an expert-section in the admin-area in future with some other settings for devs like displayErrorDetails and more...

Sounds like a good idea I guess normal users won't need this kind of deep control over Typemill.

postponed to version 1.4.2

Thanks for the information.

published with 1.4.2, please reopen if you find any problems

Will do but it seems everything works, thanks.


Left and Right Padding not working in Custom Styles

I inputted the following into the Custom Styles tab:
.simple-bar {
top: 8px;
}
.simple-bar--spaces {
left: 100px;
}
.simple-bar--process {
left: 25px;
width: calc(100% - 50px);
border-radius: 3px;
}
.simple-bar--data {
right: 100px;
}
and only the top padding seems to work, no matter what i put for the left and right data, it does not seem to work. I am using floating bar if that makes a difference.

Nevermind, I needed to disable floating bar for the left and right padding to take effect. Thanks!


[Product Category] Do not query Coveo if crawled by bots

Could we add a check so that the Coveo component will not run if the page is crawled by known bots?

I think it does not run, it is client side JS only. Unless the bots execute JS it will not run.

@mhaack / @duynguyen  - can we do something like what @davidzochowski  is asking?

@davidzochowski I think this will not be the case anway. We call Coveo only client-side by own direct API calls or Atomic. So unless the bot run the JS on the site there will be no Coveo call.

I am closing this as it is super low priority. Will re-open if needed.


Remove duplication in Report.js

Details
Pusher subscription logic in Report.js is pretty wild and lots of copy pasta is used. Cleaning this up a bit.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/201111
Tests

Not much apart from regressions around various realtime features like report comments
Verify that you are subscribed to the Pusher channels here

[x] Verify that no errors appear in the JS console

QA Steps

None apart from regressions around various realtime features like report comments

[ ] Verify that no errors appear in the JS console

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @timszot in version: 1.1.43-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.43-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


robocorp[patch]: DO NOT MERGE

Verifying if this is passing. But need to investigate what's going on with the nested tool.

handling


[FEATURE REQUEST] Add Search Screen

It's supposed to be a third option in the NavigationBar.

The NavigationBar got removed and I don't see this feature implemented anytime soon.


docs: fix typo (its -> it's)

This is correct as-is. "It's" is a contraction of "it is", which would read as "unless it is parent component re-renders". "Its" is the possessive form, which is what we want here.


User menu

Mockups

Specifications

Clicking in either username or user photo, will display a popup with the following options: My account, Sign out
Option My account will open a page with title My Account. In this page the user will be able to change his name and lastname, email and photo.  (described in #39 )
Option Sign out will log out the user and close the current user session

We are going to have Logs Submenu on Settings.
For now you can not change the password from the UI

We are going to have Logs Submenu on Settings.
For now you can not change the password from the UI

@lcc1289 Please, check this in following pages. This is also happening with Settings menu

Targets list
Target Details page
Root domain details page
Subdomain Details page
Agents list
Pipeline pages

Working as expected


feat(USA): Kia seat support

Support for heating and cooling seats in start_climate. Credit to @chasebolt

@chasebolt let me know if it tests out okay and if so I will merge this.

what's the best way to go about testing this?

 I'm the custom component folder you will find this Kia UVO folder and manifest file.  Manually make the change this pr shows and restart home assistant.  After that services should work for heated seats.

Do to conflicts going to create a new PR and merge this.  My impression is this does work so far just further improvements coming.  This will get it out to the public in the meantime.


Build flags for supporting alternate hardware configuration

When DIY EuroPi modules use different GPIO pin configurations, we want to be able to easily support those different configurations without requiring a separate fork. This can be solved using the Go feature build constraints along with separate gpio configuration files with build constraint headers.
For example, we can define two files 1) board.go for the official hardware configuration and 2) board_rmx.go for the smd remix by @luisgongod. The first line of the file will be // go:build europi and // go:build europi_rmx respectively.
With that in place, the EuroPiGo firmware can be build using the command:
tinygo build -tags europi --target pico examples/

or
tinygo build -tags europi_rmx --target pico examples/

In order to use this in VSCode, we will need to make a few adjustments to the VSCode settings.
Add "-tags europi" to tasks.json (or "-tags europi_rmx")
{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "tinygo flash",
            "type": "shell",
            "command": "tinygo flash -tags europi --target pico -opt 1 ${workspaceRoot}/examples/clockwerk",
            "group": {
                "kind": "build",
                "isDefault": true
            },
            "problemMatcher": []
        }
    ]
}

Add the build constraint flag to settings.json (either "europi" or "europi_rmx"):
{
    "go.toolsEnvVars": {
        "GOROOT": "...",
        "GOFLAGS": "-tags=europi,cortexm,baremetal,linux,arm,rp2040,rp,pico,tinygo,math_big_pure_go,gc.conservative,scheduler.tasks,serial.usb"
    }
}

Now you can build and flash the firmware for either hardware configuration!

An alternate design consideration, for the default europi configuration, we could instead add a build flag constraint that will only build that file when no other EuroPi board is specified. Say for example we had the other board configurations europi_rmx and europi_xl. We could add the following build constraint to the default europi configuration: //go:build !(europi_rmx || europi_xl). With that added, we can build the firmware without specifying any build tags when building for the default hardware configuration.


DNN 9.1.1 - Left Persona Bar pushes top menu bar over

When logged in, the persona bar pushes the top icon bar over.
When logged in, you only see the Profile Avatar, Check Messages, and Check Notifications without any scroll bar at the bottom.

Hi Jaysma,
We have seen this and its not a bug on the theme, it effects every theme and the Personabar not only pushes the top bar over to the right, its the whole site. You only see this (depending on your screen size) when the site is full width.
When I have time I'll find a solution for this.
Regards,
Geoff.


feat: pallet asset-rate

Addresses https://github.com/paritytech/substrate/issues/13602
Required for https://github.com/paritytech/substrate/issues/13604 & https://github.com/paritytech/substrate/pull/13571

Description
Adds a simple oracle asset-rate pallet which provides means of setting conversion rates for assets to native. These conversion rates are planned to be used to Treasury. Please note that these conversion rates should not be used for the actual payment but just to determine the {Small, Medium, Big} Spender status/track for users which desire to be paid in anything but the native currency. Moreover, it could also be used to softly assert a SpendingPeriods budget has not been exceeded, if that will eventually be necessary for a Multi Asset Treasury.
CUD is enabled via three (potentially) separate origins. The UpdateOrigin could  be a DEX which sends an update every N blocks.
How is this pallet supposed to be used?
This pallet provides an implementation of BalanceConversion which can be plugged into the more generic treasury pallet as an associated type. This enables mapping X amount of balance for an asset to Y amount of native balance. The creation of treasury proposals in Gov2 will always happen on the governance chain (e.g. relay for now, common good in the future). Since such chain does not need to understand multi assets, there needs to be a mechanism to map such balances to the native balance.
TODO

[x] Add unit tests
[x] Add benchmarks
[x] Add pallet docs
[x] Open separate PR (https://github.com/paritytech/substrate/pull/13610) to address inconsistent function definition of  BalanceConversion, e.g.

- /// Converts a balance value into an asset balance.
+ /// Provides conversion between two balances.
pub trait BalanceConversion<InBalance, AssetId, OutBalance> {
	type Error;
-	fn to_asset_balance(balance: InBalance, asset_id: AssetId) -> Result<OutBalance, Self::Error>;
+	fn to_balance(balance: InBalance, asset_id: AssetId) -> Result<OutBalance, Self::Error>;
}

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2530320

Do we really need create/upgrade/remove? wouldn't an update with Optional param be enough?

That could suffice. IMO though, it should be preferred to have better granularity, especially adding an asset to this pallet's storage can be considered whitelisting them as payout currencies.
Assume the UpdateOrigin will be a DEX in the future, e.g. on Statemin{e,t}. Should this DEX really have the power to add and remove assets which can be requested as payout on a Government chain? IMO it should not, especially when you consider that parachains probably want to have Multi Asset treasuries as well without necessarily having an independent chain dictate supported spend assets.
Moreover, in the current design the UpdateOrigin does not essantially have to check which assets it actually can update, e.g. the filtering happens in the TreasuryOracle pallet.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2534555

Why the treasury should rely on the oracle pallet to determine an asset is supported?
Another thing is, any reason why this needs to be treasury-oracle pallet instead of just a generic oracle pallet?

especially since adding an asset to this pallet's storage can be considered whitelisting them as payout currencies.

Why the treasury should rely on the oracle pallet to determine an asset is supported? If treasury wants a whitelist, it should implement a whitelist in the treasury. The oracle pallet could be for example used for fee payment, ED amount calculation etc. But if this is the design that this pallet will tightly coupled with treasury, that maybe fine. Is there a design of how all the pallets interact with each other?
Another thing is, any reason why this needs to be treasury-oracle pallet instead of just a generic oracle pallet?

@tonyalaribe is writing up a design of how these work together. But the main reason that this is a Treasury-Oracle is that it's really limited to some specific information related to Treasury logic. I would not be opposed to putting this directly in Treasury, in the context that the Treasury logic exists in one place but its assets exist in many. However for a single-asset, single-location Treasury, this would be pointless, so it also makes sense as an extension.

especially since adding an asset to this pallet's storage can be considered whitelisting them as payout currencies.

Why the treasury should rely on the oracle pallet to determine an asset is supported? If treasury wants a whitelist, it should implement a whitelist in the treasury. The oracle pallet could be for example used for fee payment, ED amount calculation etc. But if this is the design that this pallet will tightly coupled with treasury, that maybe fine. Is there a design of how all the pallets interact with each other?
Another thing is, any reason why this needs to be treasury-oracle pallet instead of just a generic oracle pallet?

@tonyalaribe is writing up a design of how these work together. But the main reason that this is a Treasury-Oracle is that it's really limited to some specific information related to Treasury logic. I would not be opposed to putting this directly in Treasury, in the context that the Treasury logic exists in one place but its assets exist in many. However for a single-asset, single-location Treasury, this would be pointless, so it also makes sense as an extension.

I shared a potential plan here: https://github.com/paritytech/polkadot/issues/5293#issuecomment-1476386805

@tonyalaribe Please review, thank you!

I renamed the pallet from treasury-oracle to asset-rate as a result of the most recent renaming of pallet-asset-conversion(https://github.com/paritytech/substrate/pull/12984)  as well as @muharem's and @xlc's comments.
An open discussion point is the potential splitting of whitelisting an asset to a separate pallet such that this pallet truly just serves as a convertor without whitelisting implications.
IMO such splitting would be unnecessary as I think it's feasible to assume giving an asset a conversion to native balance relates to whitelisting is as payout currency. In the end, that logic is dependent on the final design of the Multi-Asset Treasury and out of scope of this PR.

bot rebase

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2665697

bot merge


docs/upgrade: config field typo

Upgrade section mentions changing remove_on_shutdown to false but there is no remove_on_shutdown config field. Is it meant to be leave_on_shutdown?

Whichever it is meant to be, it would also be a good idea to add the recommendation to the production deployment section as if someone is running cluster in production, they will inevitably want to upgrade.


same node showing as Primary and Sync standby

What happened?
can-postgressdb1 node is acting as the leader, and in the PostgreSQL logs, it shows the same node as the sync standby.Please find the below.
When I perform a failover to another node, everything works correctly. However, I would like to understand why this behavior is occurring for these specific node.
2024-11-08 21:27:55 IST [1457128-11] LOG: received SIGHUP, reloading configuration files
2024-11-08 21:27:55 IST [1457128-12] LOG: parameter "synchronous_standby_names" changed to "can-postgressdb1"
2024-11-08 21:32:44 IST [1457137-3] LOG: checkpoint starting: time

--
+ Cluster: on-canary<PHONE_NUMBER>282575371) ---------------------------------+---------+
| Member           | Host                  | Role    | State    | TL | Lag in MB |
+------------------+-----------------------+---------+----------+----+-----------+
| can-postgressdb0 | can-postgressdb0       | Replica | streaming | 28 | 0         |
| can-postgressdb1 | can-postgressdb1       | Leader  | running   | 28 |           |
| can-postgressdb2 | can-postgressdb2       | Replica | streaming | 28 | 0         |
+------------------+-----------------------+---------+----------+----+-----------+

How can we reproduce it (as minimally and precisely as possible)?
Not sure.
What did you expect to happen?
sync standby should be another node name
Patroni/PostgreSQL/DCS version
Patroni version: 3.3.0
PostgreSQL version: 14
DCS (and its version): consul and version v1.16.2
Patroni configuration file
scope: postgresql-patroni
name: postgresql-test1
namespace: /service

log:
  level: DEBUG
  traceback_level: ERROR
  format: '%(asctime)s %(levelname)s: %(message)s'
  dateformat: ''
  max_queue_size: 1000
  dir: /var/log/patroni
  file_num: 4
  file_size: 25000000
  loggers:
    patroni.postmaster: WARNING
    urllib3: WARNING

restapi:
  listen: localhost:8008
  connect_address: localhost:8008

consul:
  host: <IP_ADDRESS>:8500
  token: 637cf05d-aad3-75b8-4851
  checks: []
  register_service: true

bootstrap:
  method: initdb
  dcs:
    ttl: 30
    loop_wait: 10
    retry_timeout: 10
    maximum_lag_on_failover: 1048576
    master_start_timeout: 300
    synchronous_mode: true
    synchronous_mode_strict: true
    synchronous_node_count: 1
    postgresql:
      use_pg_rewind: true
      use_slots: true
      parameters:
        max_connections: 100
        superuser_reserved_connections: 5
        max_locks_per_transaction: 512
        max_prepared_transactions: 0
        huge_pages: off
        shared_buffers: 1913MB
        effective_cache_size: 5739MB
        work_mem: 4MB
        maintenance_work_mem: 16MB
        checkpoint_timeout: 5min
        checkpoint_completion_target: 0.9
        min_wal_size: 80MB
        max_wal_size: 1GB
        wal_buffers: 4MB
        default_statistics_target: 100
        seq_page_cost: 1
        random_page_cost: 1.1
        effective_io_concurrency: 200
        synchronous_commit: on
        autovacuum: on
        autovacuum_max_workers: 3
        autovacuum_vacuum_threshold: 50
        autovacuum_vacuum_scale_factor: 0.2
        autovacuum_analyze_scale_factor: 0.1
        autovacuum_analyze_threshold: 50
        autovacuum_vacuum_cost_limit: -1
        autovacuum_vacuum_cost_delay: 2
        autovacuum_vacuum_insert_scale_factor: 0.2
        autovacuum_vacuum_insert_threshold: 1000
        autovacuum_naptime: 1min
        max_files_per_process: 4096
        archive_mode: on
        archive_timeout: 1800s
        archive_command: pgbackrest --stanza=pg_stanza archive-push %p
        wal_level: replica
        wal_keep_size: 2GB
        max_wal_senders: 10
        max_replication_slots: 10
        hot_standby: on
        wal_log_hints: on
        wal_compression: off
        shared_preload_libraries: pg_stat_statements
        pg_stat_statements.max: 10000
        pg_stat_statements.track: all
        pg_stat_statements.track_utility: false
        pg_stat_statements.save: true
        track_io_timing: on
        log_lock_waits: on
        log_temp_files: 0
        track_activities: on
        track_activity_query_size: 4096
        track_counts: on
        track_functions: all
        log_checkpoints: on
        logging_collector: on
        log_truncate_on_rotation: on
        log_rotation_age: 1d
        log_rotation_size: 0
        log_line_prefix: '%t [%p-%l] %r %q%u@%d '
        log_filename: postgresql-%a.log
        log_directory: /var/log/postgresql
        hot_standby_feedback: on
        max_standby_streaming_delay: 30s
        wal_receiver_status_interval: 10s
        idle_in_transaction_session_timeout: 0
        ssl: 'on'
        ssl_ca_file: /var/lib/pgsql/14/data/CA.crt
        ssl_cert_file: /var/lib/pgsql/14/data/wildcard.crt
        ssl_key_file: /var/lib/pgsql/14/data/wildcard.key
        jit: off
        max_worker_processes: 8
        max_parallel_workers: 8
        max_parallel_workers_per_gather: 2
        max_parallel_maintenance_workers: 2
    standby_cluster:
      host: <IP_ADDRESS>
      port: 5432

  initdb:  # List options to be passed on to initdb
    - encoding: UTF8
    - locale: en_US.UTF-8
    - data-checksums

  pg_hba:  # Add following lines to pg_hba.conf after running 'initdb'
    - host replication replicator <IP_ADDRESS>/32 scram-sha-256

postgresql:
  listen: <IP_ADDRESS>:5432
  connect_address: localhost:5432
  use_unix_socket: true
  data_dir: /var/lib/pgsql/14/data
  bin_dir: /usr/pgsql-14/bin
  config_dir: /var/lib/pgsql/14/data
  pgpass: /var/lib/pgsql/
  authentication:
    replication:
      username: replicator
      password:
    superuser:
      username: postgres
      password:
  parameters:
    unix_socket_directories: /var/run/postgresql
    stats_temp_directory: /var/lib/pgsql_stats_tmp

  remove_data_directory_on_rewind_failure: true
  remove_data_directory_on_diverged_timelines: true

  create_replica_methods:
    - basebackup
    - pgbackrest
  pgbackrest:
    command: /usr/bin/pgbackrest --stanza=pg_stanza --log-level-file=detail --delta restore
    keep_data: true
    no_params: true
  basebackup:
    max-rate: '100M'
    checkpoint: 'fast'

  recovery_conf:
    restore_command: pgbackrest --stanza=pg_stanza archive-get %f %p

watchdog:
  mode: automatic  # Allowed values: off, automatic, required
  device: /dev/watchdog  # Path to the watchdog device
  safety_margin: 5

tags:
  nofailover: false
  noloadbalance: false
  clonefrom: false
  nosync: false

  # specify a node to replicate from (cascading replication)
#  replicatefrom: (node name)

patronictl show-config
same as above

Patroni log files
NA

PostgreSQL log files
2024-11-08 21:27:47 IST [1457179-1] (57524) replicator@[unknown] LOG:  standby "can-postgressdb1" is now a synchronous standby with priority 1
2024-11-08 21:27:47 IST [1457179-2] (57524) replicator@[unknown] STATEMENT:  START_REPLICATION 21/CF000000 TIMELINE 27
2024-11-08 21:27:48 IST [1457184-1] (47536) replicator@[unknown] LOG:  standby "can-postgressdb2" is now a synchronous standby with priority 1
2024-11-08 21:27:48 IST [1457184-2] (47536) replicator@[unknown] STATEMENT:  START_REPLICATION SLOT "can_postgressdb2" 21/CF000000 TIMELINE 28
2024-11-08 21:27:55 IST [1457128-11]  LOG:  received SIGHUP, reloading configuration files
2024-11-08 21:27:55 IST [1457128-12]  LOG:  parameter "synchronous_standby_names" changed to ""can-postgressdb1""
2024-11-08 21:32:44 IST [1457137-3]  LOG:  checkpoint starting: time

Have you tried to use GitHub issue search?

[X] Yes

Anything else we need to know?
No response

Patroni version: 3.3.0

This is not the latest version.
To me it looks like a duplicate of https://github.com/patroni/patroni/issues/3111, which is already fixed.


Fix test failures for WFLY-12019 to add a undertow handler for created location

Issue: https://issues.redhat.com/browse/WFLY-12019
This PR tires to fix the test failures in CI that using profiles: ts.standalone.microprofile, ts.layers, ts.bootable, which do not have /subsystem=undertow/configuraiton=handler/file=welcome-content in the server configuration, that is why it failed when creating the location resource for a host.
The solution is trying to create a /subsystem=undertow/configuraiton=handler/file=welcome and remove it after test.

Thanks, @gaol. I merged this into my branch locally, and then rebased to squash this into your previous commit. I've pushed that.


Address libnode vulnerability

Description
Discovered vulnerability on libnode.so in Atom
CVE-2018-7161
CVE-2018-7167
CVE-2018-12122
CVE-2018-12121
CVE-2018-12116
CVE-2018-12115
CVE-2018-1000168
CVE-2018-7160
CVE-2017-15399
CVE-2017-5132
CVE-2017-5122
CVE-2017-5121
CVE-2017-15413
CVE-2017-15406
CVE-2017-15896
CVE-2017-14952
Atom seems to be using an older version of NodeJS. Please review and see if these vulnerabilities are valid.
Versions
1.37.0
1.38.0

I tried building the latest Atom from master branch and the libnode.so shows that it is only v10.2 even though I've compiled it using NodeJS v10.16. Is there some mistake or is this using an older node?

Thanks for the heads up!  The version of Node that Atom uses comes via Electron.  So any updates to the version of Node that we use would come specifically with us upgrading our version of Electron (e.g. https://github.com/atom/atom/pull/19373 for example).  We also keep an eye out for any releases of Electron that fix security vulnerabilities and update Atom as needed.

shows that it is only v10.2 even though I've compiled it using NodeJS v10.16. Is there some mistake or is this using an older node?

This comes from Electron, you can see by running atom -v, e.g. for the latest stable release (Atom 1.38.2), we're on Electron 2 which uses Node 8.9.3:
$ atom -v
Atom    : 1.38.2
Electron: 2.0.18
Chrome  : 61.0.3163.100
Node    : 8.9.3

master is currently on Electron 3 which uses Node v10.2 (https://github.com/electron/node).
Since these CVEs aren't something we would specifically resolve directly in Atom, we'll go ahead and close this out but thanks again for the heads up!

@rsese any reason why we are not moving to Electron v4 or v5? These versions has newer dependencies that would help in this issue.

Upgrading Electron in a massive project like Atom isn't a simple undertaking as there are many parts that it touches on, being the core runtime after all.
You can see previous efforts in the Electron 3 PRs (https://github.com/atom/atom/pull/18815, https://github.com/atom/atom/pull/18916), and @rsese already linked you to the current work on Electron 4 in https://github.com/atom/atom/pull/19373.
Feel free to subscribe to that PR if you are interested in following along as the team works on getting that stable 😉.

@Arcanemagus Thanks for the clarification. Must have missed that #19373 while I was reading.


Add hash to image tag in order to rebuild when the instructions change

Pull Request Test Coverage Report for Build 656

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 16.322%

Totals

Change from base Build 651:
0.2%

Covered Lines:
142

Relevant Lines:
870

💛  - Coveralls

@jocgir. Hash of the build folder's files modify times is now calculated (excluding build Dockerfile which is rewritten everytime)


Least connections/bandwidth load balancer?

Why traefik doesn't have Least connections/bandwidth load balancing option?  Is it slow/hard to scale so it's something that will not be in traefik  or you simple haven't done it yet? :smile:

I'd say it's rather the latter: nobody really needed it yet or has had the motivation to provide a PR. So be the first. :-)

I'll close this issue, because I think the question is answered, but feel free to continue the conversation.

I think it will be interesting a least connection algorithm for an application like MariaDB Galera Cluster.
More info can be read at:
https://severalnines.com/blog/mysql-docker-swarm-mode-limitations-galera-cluster-production-setups


implement Balance Nav

adding sUSD balance navigation for quick access to sUSD via the Uniswap widget.
Description

[x] DIsplay remaining margin as total on top of the grouped perpetual list as well as individually
[x] list each active perpetual and link to their respective page on click
[x] if connected wallet has no sUSD balance, display Get sUSD. Button opens a modal with UniSwap widget inside - defaulting to the ETH/sUSD pair
[x] allow user to get sUSD even when they have sUSD

Related issue
https://github.com/Kwenta/kwenta/issues/541
Motivation and Context
provide a quick navigation to open perpetual markets.
How Has This Been Tested?
development on mainnet, kovan optimism, and optimism. switching wallets and networks to investigate any side effects.
Screenshots (if appropriate):

Using the swap widget:

restyled the uniswap widget according to figma - could use a second pair of eyes.
addressed pr reviews and simplified balance nav

width exceeds the modal. should be removed. otherwise, can't close the model by clicking immediately outside of it.

did the widget have its own typeface? or was it using ours? it should not be that default serif

@asherism overriding font now - hows this:

not sure if the query is working correctly still

Can confirm it now does not fetch accessible margin neither on Op Kovan nor Op Mainnet.

One additional "nice to have" feature would be displaying "total margin" and "available/accessible" margin.
Total margin: sum of remainingMargin across all markets
Available margin: sum of accessibleMargin across all markets.
This way I could see my total amount, and know that some of that sUSD is "working" for me.


Position of Currency Symbol

with the following options in my typescript project:
const costCurrencyOptions = {
    unit: '€',
    delimiter: ',',
    separator: ',',
    sign_first: false
}

Regardless of the locale. I cannot get the Euro symbol to correctly be positioned at the end of rhe amount:
 I18n.toCurrency(10),costCurrencyOptions)
displays: €10,00 but should display 10,00 €

me too

I tried to use format: '%n%u' the success, I don't know sign_first what's the effect ???

same here, sign_first doesn't work

This will help https://www.youtube.com/watch?v=1JhdbLl-Kdg


AssertionError: Cannot shift (Bottle, GeventWebSocketServer)

I'm having the trouble of this Assertion, when I'm disconnecting the three individual websocket clients from my remote c++ application using websocketpp-0.7.0.
Traceback (most recent call last):
  File "C:\Users\mrzl\Documents\censored\mesh\Python\lib\site-packages\bottle.py", line 862, in _handle
    return route.call(**args)
  File "C:\Users\mrzl\Documents\censored\mesh\Python\lib\site-packages\bottle.py", line 1740, in wrapper
    rv = callback(*a, **ka)
  File "C:\Users\mrzl\Documents\censored\mesh\Python\lib\site-packages\bottle.py", line 687, in mountpoint_wrapper
    request.path_shift(-path_depth)
  File "C:\Users\mrzl\Documents\censored\mesh\Python\lib\site-packages\bottle.py", line 1297, in path_shift
    self['SCRIPT_NAME'], self['PATH_INFO'] = path_shift(script, self.path, shift)
  File "C:\Users\mrzl\Documents\censored\mesh\Python\lib\site-packages\bottle.py", line 2673, in path_shift
    raise AssertionError("Cannot shift. Nothing left from %s. path was %s" % (empty, path_info))
AssertionError: Cannot shift. Nothing left from SCRIPT_NAME. path was /ws/subscribe/one

This issue might be related: #317
Though, I am seeing in bottle that in case a monkey patch is necessary, there should be a warning: https://github.com/bottlepy/bottle/blob/master/bottle.py#L3423
My setup:
A bottle websocket server with three endpoints:
from bottle.ext.websocket import GeventWebSocketServer
from bottle.ext.websocket import websocket
import bottle

main_app = bottle.Bottle()
websockapp = bottle.Bottle()

@websockapp.route('/subscribe/one', apply=[websocket])
def func1(ws):
    pass

@websockapp.route('/subscribe/two', apply=[websocket])
def func2(ws):
    pass

@websockapp.route('/subscribe/three', apply=[websocket])
def func3(ws):
    pass

main_app.mount('/ws/', websockapp)
bottle.run(main_app, host='localhost', port='6543', server=GeventWebSocketServer, debug=True)

I'm using Python 3.5.6 with these packages
bottle==0.12.13
bottle-websocket==0.2.9
gevent==1.3.6
gevent-websocket==0.10.1
greenlet==0.4.14

Has anybody come across this issue and can point me to a different way of handling the bottleapp.mount() procedure or anything else that I am obviously doing wrong?

The warning is only implemented in master, I think, and was not back-ported to 0.12 yet. You absolutely need the monkey-patch, otherwise requests get mixed up (because gevent can handle multiple requests in the same thread, and bottle uses thread-local storage).


Updating rust-openssl

So I have the following dependencies
── ssh2 v0.3.3
│   ├── bitflags v0.7.0
│   ├── libc v0.2.45 (*)
│   └── libssh2-sys v0.2.11
│       ├── libc v0.2.45 (*)
│       ├── libz-sys v1.0.25
│       │   └── libc v0.2.45 (*)
│       │   [build-dependencies]
│       │   ├── cc v1.0.26 (*)
│       │   └── pkg-config v0.3.14 (*)
│       └── openssl-sys v0.9.40 (*)
│       [build-dependencies]
│       ├── cc v1.0.26 (*)
│       └── pkg-config v0.3.14 (*)

The trouble is openssl-sys v0.9.40 no longer seems supported. I can't seem to get it to compile on Fedora 29 at least.
Is it possible to update or has the api changed ?

Hm are you sure that openssl-sys isn't supported? That's the latest version...

Well I may be wrong . I got that info from a comment on the issues of another crate with the same problem.
"The problem is my openssl version is 1.1.1
it is not supported by
0.9.x of openssl crate :
https://github.com/sfackler/rust-openssl/blob/0.9.x/openssl/build.rs#L16
the problem is fixed in newer version of openssl crate :
https://github.com/sfackler/rust-openssl/blob/master/openssl/build.rs#L33
"
But you are right the latest release does seem to be Release v0.9.40.
Unfortunate that there is a stable crate that many others rely on that seems to be very hard to build out of the box on new Linux releases.
I guess my best option is to try and downgrade or install a different openssl on my os.
Thanks

Ah no worries! The problem is the openssl crate vs the openssl-sys crate. The latter supports OpenSSL 1.1.1, but the former doesn't (in the 0.9.x series). Note that the openssl crate is on 0.10.x now


gitpich.com/pricing is a 404

Trying to get to gitpitch.com/pricing yields a non-existing page. Kind of an important thing if you're selling a paid service

Hes Dead , Jim


Update devops-build-tools.md

It is currently unclear from the documentation that the service principal needs to be added as an admin application as well as being system admin on the environment. I suggest adding something to the documentation.
https://learn.microsoft.com/en-us/power-platform/admin/powerplatform-api-create-service-principal

I'm not sure why you want to add a link on how to use an API in this situation.  In the very next section, we provide instructions on how to create the service principal and add it to the environment.

Can you clarify why this is unclear?
Perhaps helping people understand how to also add an existing SPN?  Maybe something like this would help?
If you already created the service principal, you can check if it has been added to the environment using pac admin list-service-principal. If it hasn't been added to the environment, you can add it using pac admin assign-user
We want to encourage people to use pac and not raw API calls.

The existing documentation seems complete. Closing this PR.


Experimental switch to Google docs

I am trying to modify the Makefile so that it downloads PDF from the Google doc draft instead of building it from latex. I think the Makefile is only triggered by a PR, so I am starting this now as part of the experiment, and will report back on how it goes. When he has been added to the lsst organization I'll add Steve M as reviewer, so that he can follow along. If this works, we could think of turning our Google doc draft into a Rubin-formatted technote document and using this repo to display the PDF technote at https://rtn-033.lsst.io/ Let's see!

Success! The Google doc PDF is now visible at https://rtn-033.lsst.io/v/feature-drphilmarshall-gdocs/index.html (and will appear at rtn-033.lsst.io when we merge this pull request). Now to discuss with Steve M offline whether or not to keep the source in Google docs, or make the jump to latex. If the latter, we would not merge this PR.

OK, the Makefile now points to the new, Rubin-formatted and Rubin-owned Google doc source, and I updated the README to point to it. @SteveMargheim I think you can merge this PR when you have reviewed the changes and are happy with them - and then you can announce your initial draft via a new PR when you have filled out all the text in the new doc. (We need a new PR to make the PDF at  https://rtn-033.lsst.io be a download of the current version in Google docs.)

PS. Note that to make a new PR, you have to edit one of the files in this GitHub repo. The thing to edit is the "Status" subsection of the README.

As a general comment, if we are going down this route, it would be good to have an editable version of the document stored somewhere outside of google in case the google doc goes away and we are left with a PDF to extract text from. I assume you can pull such a file? I have no idea if an action can itself make a commit.

@timj That's a good idea. I've executed git commands from travis yaml in the past, but haven't tried anything like this with GitHub actions yet. I'll see what I can do. Downloading plain text from Google docs is straightforward.

Check it out, @timj - GitHub actions is now committing a new version of the plain text source to the repo just before it pushes the corresponding PDF, see screenshot below. (The git commit that GitHub actions makes does not, you'll be pleased to hear, itself trigger a new GitHub action - as you can see in the commit history above.) This was a good addition I think - thanks for suggesting it.

OK @SteveMargheim I think this is good to go. LMK if you see anything else that needs fixing!


Can't access split left or right in the typescript version

https://codesandbox.io/s/transport-bpm-test-3i7nw

Should I use
splitNode.connect(otherNode, 0) instead of splitNode.left.connect(otherNode)?

Yep, the solution above works.

I've updated the API to remove some of the stereo bias that the split/merge objects had since they can support more than 2 channels and it doesn't make sense to enumerate all of the outputs in that way.


Add 'About the Project' section to README

Coverage remained the same at 99.08% when pulling d8ac5da20ac84e6e130545a3922e0ea61a2d4dc9 on add-info-to-README into 7dd6359007358ea6ea412114c83cec76233f883b on master.


Export all coordinate types from the output section to CSV

Goal
The coordinate conversion output list needs to write all outputted coordinates from the list to given file type. In that file type the output coordinate section will drive the information captured in the attribute list. The formatting chosen by the user must be preserved in the output file.
Reality - Current State
The output only grabs the coordinates that are in the list not the formatted types that are in the output list
Expected Result
The CSV should have all coordinates from the output list populated to the output file type. This issue will focus on CSV

@topowright As per our conversation yesterday, all the output formats are exported as single column in the exported CSV. Instead of DD, DDLat, DDLon, the CSV would contain a single column DD (name as mentioned in the output section of the add-in).

The feature enhancement will be added to the doc. It will include exporting to feature class #492, shapefile #493 , and kmz #495 in addition to csv.


Android App

hi, is there an android version of this app? I am eager to use this software on my mobile phone

Just visit https://squoosh.app on your mobile phone.

Thanks for your reply, and I want to know how can I integrate this project into my Android project。


Python 3 incompatibility is no longer acceptable

It is May 2020 now.

Good catch, @pllim, thanks!


[WIP] Upon dropping/grabbing, return to the correct week

Pull Request Test Coverage Report for Build 1979

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 89.267%

Totals

Change from base Build 1975:
0.04%

Covered Lines:
499

Relevant Lines:
559

💛  - Coveralls

If user grabs duties across different weeks, redirects to week of 1st duty listed in Grab Duty page.


request help with a small change on the cube demo: add a vertex buffer, a crash on iPhone 13, not in simulator

./MoltenVK/MoltenVK/Commands/MVKCmdDraw.mm
the drawPrimitives looks good and the type is triangle_strip
Hi, it would be very nice if you can inspire me to know how to debug this. Thanks in advance.
The problem is interesting at an elementary level, and easy to reproduce from my branch, if you have Xcode. Even without an Iphone you can understand what I do make work in the simulator.
I did a slight modification in the cube demo MoltenVK to use a vertex buffer as input. And I get a crash on my IPhone 13 Pro.
I would like please some help to debug this. II understand there is a large array. But it is seems to me something quite basic in graphics programming to send a large array of vertices. There must be something in conflict with metal or the rules of Vulkan.
I just took the demo ready to be launched from the MoltenVk repo.
There is a folder demo that can be opened in xcode and started directly.
I could run it on an Iphone 13 Pro, and in a simulator Ipod touch 7th gen.
See the files in the browser here:
https://github.com/MagicPoulp/Vulkan-Tools/commit/cffaffb4542e9381ad137aded9c55ee2f6c0589b
I modified the code to use data from a vertex buffer.
as in my Branch metal-bug-please-help-many-vertices
in
https://github.com/MagicPoulp/Vulkan-Tools.git
git@github.com:MagicPoulp/Vulkan-Tools.git
cloning the MoltenVK and running the demo puts the Vulkan-Tools on the tag: v1.2.198. So that is what I use.
It works in the simulator iOS Ipod touch 7th.
But I get a crash on the Iphone 13 Pro.

"crash dump:
[mvk-info] Using MTLEvent for Vulkan semaphores.
[mvk-info] Created VkDevice to run on GPU Apple A15 GPU with the following 2 Vulkan extensions enabled:
                VK_KHR_portability_subset v1
                VK_KHR_swapchain v70
[mvk-info] Created 3 swapchain images with initial size (960, 1704).
2022-01-20 17:27:12.221592+0100 Cube[1503:442842] Execution of the command buffer was aborted due to an error during execution. Caused GPU Address Fault Error (0000000b:kI\
OGPUCommandBufferCallbackErrorPageFault)
[mvk-error] VK_ERROR_DEVICE_LOST: Command buffer 0x1017135a0 "vkQueueSubmit CommandBuffer on Queue 0-0" execution failed (code 3): Caused GPU Address Fault Error (0000000b\
:kIOGPUCommandBufferCallbackErrorPageFault)
Assertion failed: (!err), function demo_draw, file cube.c, line 1059. (VK_ERROR_DEVICE_LOST)

I did different experiments. The shaders do not need to use then input data. There should be no crash whether or not we use the in data in the vertex shader.
I even used the vkFlush command (just after vkMap and memcpy) by changing the get_memeory_properties to return a non Coherent memory type. Same error
I have some clues:
Fence in metal is said buggy on some forums and I could change the synchronisation.
I must have lacked understanding of the Vulkan pipeline and I do too much in the vkQueue and then it conflicts in the world of Metal.
Here is a totally different way to use a GPU buffer only that I could try.
https://vkguide.dev/docs/chapter-5/memory_transfers/
the demo_draw() function is run at each frame. Perhaps the command buffer has too much data.
A technique of draw indirect:
https://vkguide.dev/docs/gpudriven/gpu_driven_engines/
Maybe I lack some synchronisation. But I do not understand what sort of synchronisation I would need. Maybe I should split the transfer in chunks. I could also explore the MoltenVK source code in Metal and add debug information.
Practical information:
https://github.com/KhronosGroup/MoltenVK.git
this is the setup for MoltenVK
https://github.com/KhronosGroup/MoltenVK.git
./fetchDependencies --io --iossim
make --ios --iossim
after using glslc with the write output name to produce the spa files, the files must be dragged into the Xcode project so that the files are copied with the bundle.
I edited the scheme to Debug and checked debug executable to see the line that crashes
cube code lies in another folder part of another repo in External/Vulkan-Tools/cube/cube.c
https://github.com/KhronosGroup/Vulkan-Tools.git
the program glslc to compile the 2 shader files can be downloaded here:
https://github.com/google/shaderc/blob/main/downloads.md

fixed. I confused vertexCount and raw array size whilst vkCmdDraw needs vertexCount.


feat: upgrade charts to chatwoot v3.6.0

Description

Update charts to chatwoot v3.6.0
https://github.com/chatwoot/chatwoot/releases/tag/v3.6.0

Type of change

[x] Chore (Update Chatwoot version)

How Has This Been Tested?

[x]  Tested installation against a fresh k8s cluster
[x]  Tested upgrade against a k8s cluster running Chatwoot v3.5.2

Checklist:

[x] My code follows the style guidelines of this project
[x]  I have performed a self-review of my own code

Fixes https://linear.app/chatwoot/issue/CW-3096/release-charts-and-ami-for-v36


Add default PR comment

In order to help ensure good code and ensure PRs include all the expected things, it would be helpful to create a default comment for new PRs. (We can also do this for issues.) I saw this on the rsyslog cookbook, and the docs for how to do it are here.
Let's use this issue to discuss whether or not this is worth doing, and what the default should be.

I'll make a first pass:
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing

[ ] All tests pass. ($ rake test)

[ ] New functionality has been documented in the README if applicable

[ ] New functionality has been thoroughly documented in examples

[ ] Changes documented in the CHANGELOG

I liked it!!


Make code review ceckboxes clickable

Make checkboxes in code review comment clickable.
#15791 made checkboxes in regular comments clickable, this PR apply same logic to Pull Requst comments.
Some clarification:

regular comments on pull request are made by "Comment" button
code review comments are made by "Review" - "Approve"/"Requst Changes"

have you double checked and confirmed that this works for a non-admin user?

data-can-edit conditions coped from here (#15791)
https://github.com/go-gitea/gitea/blob/48f7e850e88d7574508ca981d0de7abb6281cd8a/templates/repo/issue/view_content/comments.tmpl#L614
I did a double check
repo: org1/repo1, public.
user1: created pull request
user2: made a comment with "requested changes" button
user3: logged in, but not a part of org1
anonymous: not logged in
all users are non-admin.

name
team
can use checkbox

user1
owners
yes

user2
owners
yes

user3

no

anonymous

no


Use proper columns in peripheral view

Type: Feature Request
Please display the contents of the peripherals side view in proper columns for register name, value, address, access (r/w) and description and give the user the option to sort the columns and adjust their width.

We've discussed this and have decided against it. What you propose is reasonable, but to accomplish it we would need to reimplement our current tree view as a table view. From our perspective the features a table view would provide are nice, but a tree view is more appropriate for peripheral registers. The search and pinning features hopefully provide enough capability to find the registers you need.

In IAR Embedded Workbench, which I currently use, the registers view is a combination of a tree view and a table view, which I think is optimal. However, of course I understand your decision if it is not possible to realize that in VS Code.


dwarfdump update w.r.t object 0.18.0

Updating the dwarfdump example to be consistent with the latest version of object - 0.18.0

Observed that the build failed due to these two reasons:-

error[E0599]: no method named section_data_by_name found for reference &object::read::any::File<'_> in the current scope in many examples/ (simple.rs, simple_line.rs, dwarf-validate.rs)
error[E0658]: use of unstable library feature 'ptr_cast' in object 0.18.0

It's fine to bump the rust version in .travis.yml and README.md to 1.38.0.

Updated

Coverage remained the same at 85.474% when pulling d4a8862167254ce8c1e1008fbe5a0e9271a685b4 on vaibspider:changes-for-object-0.18.0 into<PHONE_NUMBER>a7a08da15ebe029396e4343339dc02 on gimli-rs:master.


Start, end of tokens in sanitized text

This update is to keep track of original locations in the provided text, however I couldn't figure out how better to deal with sanitized (clean) text step inside Tokenize without breaking API here:
	clean, white := t.sanitizer.Replace(text), false
	length := len(clean)

Obviously clean becomes the actual source for Start and End, and not the original text.
Possible solution: Leave sanitizing up to caller so that they can have both the original string & the locations in it.

I did not understand how this change is supposed to break the API. Could you please explain better?
Your changes seems promising!

I did not understand how this change is supposed to break the API. Could you please explain better?
Your changes seems promising!

Thank you for reviewing.
See, what is expected is that Start and End would refer to the original source string. However it is being sanitized right inside Tokenize and all calculations are now based on a possibly modified source, and the expectation here is not true anymore. (That's why I commented them with a reference to sanitized text, to remind of that). The break would be to remove sanitizing and leave it up to the caller to choose. Then he will have a reference to the correct source string.
The fear though is that the library depends on this sanitizing step.

Thank you for reviewing.
See, what is expected is that Start and End would refer to the original source string. However it is being sanitized right inside Tokenize and all calculations are now based on a possibly modified source, and the expectation here is not true anymore. (That's why I commented them with a reference to sanitized text, to remind of that). The break would be to remove sanitizing and leave it up to the caller to choose. Then he will have a reference to the correct source string.
The fear though is that the library depends on this sanitizing step.


Nice to have: .select2-search input {background-image}  reflect refresh() action in progress

Nice to have indicator, that refresh() action is in progress, instead of magnifying glass, show something like loading icon in search input.
This will indicates that something is going on.
Also, you could extend that, and if refresh() action does not return anything, show another icon, like cross or something
like:
.select2-search .refresh-in-progress input {
background-image: url('loading.gif')
}
Version of Angular, UI-Select, and Bootstrap/Select2/Selectize CSS
Angular: 1.49
UI-Select: "0.17.1"
Bootstrap: 3

Closing as duplicate of #919


Add youtube playlists for videos page

I created playlists on youtube for each year of DOBC
Link to those from Archived Videos page instead of each on individually
Modify toctree so it's not a huge list of all the slides
Make donate link on front page work

Is there a reason these aren't just being added to the already existing source/videos.rst ?

Oh, uh....I forgot?

@lucywyman Okay, it's nbd. I was just curious if you were putting old videos with the archived and would put newer videos in the 'Videos' page.
It'd make more sense to put recordings on the 'Videos' page, right now they're kinda hard to find from the main page.
Everything else looks good to me :smile:

@ElijahCaine done did

lgtm :+1:


Getting Started

Hi,
I have installed all the packages necessary. When I try to run the build in PDFs, I get the correct output. How should I run my PDFs. When i run my PDF I get : ERROR:invoice2data.main:No template for invoice.pdf.
How should I specify the templete to be used for specific invoices.
Thanks

You can look at existing templates to learn about it. There are almost 100 available by now contributed by different people and companies.
If your company needs specific templates added, they should hire a developer to carry out the work. As an open source project we are mainly interested in improving the underlying library, rather than implementing specific business cases.


Updated SixLabors version, increased client timeout for stable tests,…

… improved unit test checks

@SoldatXwing at first thank you for the PR and it changes. But I have to close this PR without merging it because I worked on the develop branch which is currently 39 commits ahead of the current master branch. If you're still interestet in merging these changes you can create a PR at the develop branch with adjusted changes.

@Suiram1701 Alright, thank you for the review! I’ll take a look at the develop branch over the next few days


Cannot find module 'node-fetch' from 'server.js'

package.json should be upgraded as<EMAIL_ADDRESS>has been released few days ago and it seems that node-fetch-alpha.9 does not exist anymore

thanks for the heads up. Updated now

node-fetch is not getting installed while running npm install for fetch-mock. Is it supposed to be added in dependencies instead of devDependencies?


Failed prop type: Invalid prop children

I receive the following warning using react 15.
Warning: Failed prop type: Invalid prop `children` of type `object` supplied to `HttpsRedirect`, expected `array`. in HttpsRedirect

I believe the correct PropType would be node not array.

Hi @Geeza thank you for contributing with this issue and the PR! 👍


Propose Logo

Hi. I'm graphic disigner. I would like to know if you are interested that I make a logo for your project? If you allowed me, i"ll make logo for your project and it's free.
Best Regard

@mirzazulfan Good morning！Wonderful！Thank you so much!
Best Regard

@mirzazulfan Good night！
It's pretty good! The second or the third one is ok. Could you please separate it into  three parts?
Thank you!
Best Regard

@Decalogue Which one do you prefer?
i'll send you files and pr.

@mirzazulfan You can go to README
文档贡献
mirzazulfan 具体内容：设计 chat LOGO

Looks good @Decalogue .. You can download all files and editables file in GDrive
Good Luck. Enjoy.
Best Regard
Mirza Zulfan

@mirzazulfan You are so kindhearted.
Best Regard

if you need a logo for your other project. Please let me know. Nice to see you. Good luck.