Warning on PHP 8.1 in Polling Trait

Getting the following warning in PollingTrait on PHP 8.1:
PHP Deprecated:  Implicit conversion from float 1687.5 to int loses precision in vendor/google/gax/src/PollingTrait.php on line 93

Deprecated: Implicit conversion from float 1687.5 to int loses precision in vendor/google/gax/src/PollingTrait.php on line 93

This is because we multiply currentPollDelayMillis by pollDelayMultiplier, the latter of which can be a float. So in the case of 500 and 1.5, respectively, after four times through the result is a float instead of an integer.
The solution would be to simply cast the result of min to int.


Remove the condition to handle files size 0 separately

if the size of a file is 0, we should handle it differently. One main problem with the earlier approach was that, if there was an file with content (lets call this version of the file V1) and it was uploaded the file would be searchable and downloadable. Lets say the user removes the content of the file (lets call this version of the file V2), and the file that was accessible earlier should no longer be accessible. i.e. V1 should not be accessible and V2 should be accessible
With the old code, the problem would be that the reference to the file with content is not removed so even though the file is updated on CDF you can still access the original file (V1) and even download it. Based on the discussions on slack, we should not make any decisions as an extractor depending on the size or content of the file. So if a client/user has removed the content of the file we should look at it as an update and just upload the new empty file.
With this approach we would essentially be uploading an empty file and hence the file accessible on the UI will be V2.

This won't work. The files backend doesn't accept empty streams in all clusters.

@einarmo
So I did go through the httpx code and also printed the headers from within the Request Object within httpx.
so the headers for the file with 0 length content is as follows. The transport-encoding is not set as you can see. And I have tried it a few times and I do not see an error so far. Let me know if this is good to proceed forward :)
self.headers: Headers({'accept-encoding': 'gzip, deflate', 'connection': 'keep-alive', 'user-agent': 'python-httpx/0.27.2', 'accept': '*/*', 'content-length': '0', 'host': 'bluefield.cognitedata.com', 'x-cdp-app': 'file_extractor'})


fb_fix.smem_start is UNSIGNED LONG type

the smem_start in fb_fix_screeninfo is unsigned long type, you should use %lu instead %d in printf for unsigned long. Don't you notice the value of smem_start in your output is a negative number?  :)

Please refer http://lxr.free-electrons.com/source/include/linux/fb.h?v=2.4.37#L113

Thank you very much.It's my pleasure for pointing out my mistake.I will modify it as soon as possible.If I get it wrong in the future,I am extremely supposed to notify me.Thanks again.


helm-unittest: init at 0.3.2

Description of changes
Add helm-unittest helm plugin
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

v0.3.4 is out since. Can you update this ?


Implement versioning

Would you be able to add version numbers to the top comments of TwitterAPIExchange.php?
It will be easier to check if my current version is out of date with the current one here.

Hey Ian, yep, makes sense. I'll also put a badge at the top of README.md saying the latest stable version available.

Great, thanks for this.

:+1:

If you could check the develop branch and let me know if that's what you want guys, I'll merge into master. Thanks!

Just looked, and it's perfect. Thanks!


Add files via upload

Reviewed and merged. The Contact Us page integrates well with the existing codebase. No issues found during the review process.


Snow machine config mutation webhook for simple defaults

Issue #, if available:
#2310
Description of changes:
Setting the defaults values for InstanceType and PhysicalNetworkConnector for Snow Machine Config.
Testing (if applicable):

Create docker cluster with tilt and attach a snow machine config on the cluster without defaults values set. Check once attached if the values are set.
Unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/override codecov

/approve

/lgtm


Fix client registration

Ensure Content-type is application/json
Strategies needs to be an array
Unleash return status code 202 on success

Looks good. Many thanks for your contribution.


Add check for repeated work plan creation

Description

Currently our UI disabled a button when we don't want to allow the user to create multiple work plans. The API does not prevent this action, so you can circumvent the UI and create as many as you want 😱
Open to feedback on status codes and error messaging for this situation!
Related ticket(s)

CMDCT-3251

How to test

Using either your browser or the MFP Postman collection, attempt to create multiple Work Plans

In browser you can just try resending the network call multiple times

Ensure the first one gets created. Any after that return 400.

If you complete a WP you can then create another. Then the pattern repeats.

Author checklist

[x] I have performed a self-review of my code
[x] I have added thorough tests, if necessary

Notes
I tried adding a test file: other.test.ts and it gave many errors when I only tried to test the name formatting function. Maybe I need to mock the fetch calls even though they weren't in my test? Idk but if coverage is low I may need someone to look at that with me.

I think the most semantically-appropriate HTTP status code would be 409 CONFLICT, but 400 does the job 👍


v6

Heya, first off, thanks for all the work producing a modern kafka plugin for Adonis's, much appreciated!
We started a v6 project and ported your plugin over and made it available as a preview here:
https://github.com/neighbourhoodie/adonis-kafka-v6
I’m wondering if you are interested in having us send a v6 PR against your repo, or if we should continue going on in our separate v5 repo. We’re happy to play it either way.
Thanks again for the hard work!

@janl Oops, looks like I'm late. Your idea sounds really good, if you still need something let's go


Allow disabling Quick Info

The location of the pop up intellisense tool tips are painfully located and drastically interfere with the product.  There are numerous requests for a fix on this problem on multiple coding help sites (stack overflow etc...).... I just happend upon the repository for this product when there was a sudden error that popped up when I was using the python tools in Visual Studio.
--The quick fixes... (for those in the know on addin programming)

Move the hover offset to a better location and do a bit of usability testing on it.  I suggest it moves at least 15 pixels to the right so that it is not right under the curser... Personally it would be better to offset it 15 to the right and nearly always above the cursor because most of the time we are programming in downward motion/vision... so that means the pop up obstructs the view.
Add the option to turn off the hover pop ups... I know this is possible because I've seen the options on  other text editor add ins... This needs to be under the options-->Text Editor --> python menu item.

It'd be cool it this gets resolved.
+

Thanks for dropping in! I have a feeling I was just looking at your report on Developer Community yesterday (searching for the duplicate, actually, but got distracted...)
We've made one really helpful change here for the next release already (which you can try at https://visualstudio.com/vs/preview) by no longer showing the contents of string literals in the tooltip. That deals with the unnecessarily huge tooltips. I don't believe we have the ability to adjust the location (as a language service, we're merely extending what VS provides and it is responsible for the tooltip itself), but I agree it would be better to go above the line containing the applicable span rather than below or over it.
It would certainly be possible for us to disable tooltips completely, so I'll rename this issue to reflect that being the problem to solve here.

Thanks for the feed back and categorizing this better. Ill Check out the preview.  Glad to Know someones working on this.

Also reported at https://developercommunity.visualstudio.com/content/problem/194700/disable-pop-up.html

One more comment... You stated that " I don't believe we have the ability to adjust the location"
The tool tips in different add in's have different characteristics that look a lot like .css ... Someone made the background grey and set the font and font color... So I suspect there is a setting somewhere

We can add any arbitrary WPF control as the contents of the tooltip, so that allows for formatting, but the IDE is responsible for calculating the size and location (which I know because we had to work with one of the core teams to fix a bug a couple years back if there was too much content to fit on the screen).

I'd also like to disable the tooltips, or at least add a delay to them showing up.  I'm having the problem that they're appearing underneath my cursor (and even chase my cursor if i try to move out of its way), preventing me from clicking on identifiers that show large tooltips.


On step 14, text refers to onOpen() of the RoomDatabase.Callback, but it is really onCreate()

Yes.
Also in step 14, the code given after "Here is the code for creating the callback within the WordRoomDatabase class:", is different than the code given after "Here is what the final code should look like:".

Fixed. Thanks for reporting!


Adjust quality based on output file size

Feature request
I know this feature has been requested a lot over the years, but we are in the future now so I'd like to think there's a way to do this that's smarter than the brute force approach.
What are you trying to achieve?
Ultimately what I and I believe others are wanting to achieve is specific output size, so no matter what size file we are trying to compress, we can be sure that it's below x.
Yes we can brute force it, but that's not very performant.
I'd like to think with someone a lot smarter than me could potentially use some ML magic and come up with a better approach...
Anyone?

The performance of the "brute force" example you've linked to could be improved, or at least made more consistent, with the use of binary search.
Given most lossy image encoding is entropy-based, you may also have some luck by investigating either linear or polynomial regression ("AI" from the 19th century) of image entropy for a given image corpus that represents your scenario. For JPEG encoding, the higher the entropy value of an image, the lower the required quality value is likely to be in order to hit a target file size.

Is this something you'd consider adding to the library? I'd love to dig deeper on this but don't have the time at the mo or know where to start 😅


Fork overview, and thoughts to improve basis for chance of upstreaming

See below for an overview of this fork. Note, this writeup is a non-exhaustive work in progress.
This information may be valuable for working towards a basis that could be merged back into upstream at some point, though this is fairly hypothetical for the near term, given upstream's intents/policies relating to backwards compatibility, and our own time constraints.
Selection of improvements in this fork

Removal of bloated old string classes that scream technical debt.
Enforcement of explicit string encoding/decoding. (To be made optional in the future, see below.)
Note, the old string classes are incompatible with some python releases of the 3.7/3.8 branches.
See also https://github.com/pypdfium2-team/pypdfium2/issues/76, https://github.com/ctypesgen/ctypesgen/issues/77, https://github.com/python/cpython/pull/16799, https://github.com/ctypesgen/ctypesgen/pull/177
Bloated old library loader replaced with new lean library loader that is more explicit/controllable.
See also https://github.com/ctypesgen/ctypesgen/issues/176, and 569dc4b9f697cb47e8dd76a6db078d13a9fcc701 for some curious oversights in the old library loader.
Preventing the assignment of invalid/non-existent struct fields by correction of __slots__ declaration. This fix should be fairly easy for upstream to pick. See also https://github.com/ctypesgen/ctypesgen/issues/183
Handling of relative imports with -m / --link-modules option to properly fix https://github.com/ctypesgen/ctypesgen/issues/86
New style-related printer options that allow to disable symbol if-guards[^no_symbol_guards], macro guards and source info comments.
Started to improve control over symbol inclusion.[^symbol_inclusion]
Some internal code cleanup.

[^no_symbol_guards]: Note, this is meant for use with inherently ABI correct packaging only
[^symbol_inclusion]: Still not entirely flexible, though. There is definitely more room for improvement.
Points to be addressed

Restoring implicit UTF-8 string encoding/decoding as optional
ctypesgen originally did implicit UTF-8 encoding/decoding of in/out strings.
While that tends to be bad practice and callers had better handle strings explicitly instead, it would seem reasonable to retain an optional backward compatibility layer for existing callers.
I also imagine it might be convenient for a library that consistently uses UTF-8 for everything.
Adding the old string classes back is certainly not an option for us. However, it may be possible to create a lean replacement. See https://github.com/ctypesgen/ctypesgen/pull/177 for a suggestion (copy below), or https://github.com/ctypesgen/ctypesgen/issues/77#issuecomment-570145399 for an alternative draft by @olsonse.
Note that in/out must be handled in a single class.

Restoring the windows-specific stdcall convention
Our fork lost it for simplicity while rewriting the library loader. It should be fairly easy to add back, just wondering how to test (as this lies beyond our use case), and how to integrate it nicely.
Does the calling convention really have to be decided on function level with two library handles for cdecl/stdcall, or would it be sufficient to decide at library level, with a single handle? Is there any example of a single library actually exporting functions with different calling conventions?
Note that the ctypes API is designed around deciding at library handle level, not at function level, which suggests the expected use case is a library ABI with homogeneous calling convention.

Done

Restored test suite usability by adapting to fork changes.
Restored macro guards as opt-out

Points that may need to be accepted

Shifts in design intent: We would prefer to stick with plain ctypes as much as possible and avoid cluttering the bindings with custom wrappers.

CLI: We changed the command-line interface from action=append to action=extend and nargs=+/*. This implied switching headers from positional to flag argument to avoid confusion/interference with flags that take multiple arguments.
There may be more related changes (like singular to plural renamings) that I don't remember exactly at this time, but we could talk about reverting these if seen as unnecessary backwards compat breaker.

Uncertain

We removed support for multiple libraries in one bindings file while rewriting the loader, believing it would be cleaner to have only one library per file, and use separate files for multiple libraries, to reduce complexity, avoid code pollution around symbols and encourage individual, explicit rather than unified loader config.
However, I don't feel too sure about this change anymore. While I don't see a situation we couldn't handle otherwise, I imagine multiple libs in a single file could be more convenient sometimes, e.g. for small libraries or complicated cases of shared headers.
The initial issue with loops around symbols for a single library was of course fixable independently (https://github.com/ctypesgen/ctypesgen/pull/174), and anything else does not really affect output for pypdfium2.
Though, to keep ctypesgen code cleaner, we could consider mandating that all binaries be given if building for multiple libraries, to always avoid symbol loops, which cause some unfortunate duplication in ctypesgen's printer code.

Dumping my lean string class replacement draft below as it's not very well visible in the PR diff:
class _wraps_c_char_p:
    def __init__(self, raw, value):
        self.raw = raw
        self.value = value

    def decode(self, encoding="utf-8", errors="strict"):
        return self.value.decode(encoding, errors=errors)

    def __str__(self):
        return self.decode()

    def __getattr__(self, attr):
        return getattr(self.value, attr)

class String(ctypes.c_char_p):
    @classmethod
    def _check_retval_(cls, result):
        value = result.value
        return value if value is None else _wraps_c_char_p(result, value)

    @classmethod
    def from_param(cls, obj):
        if isinstance(obj, str):
            return obj.encode("utf-8")
        else:
            return ctypes.c_char_p.from_param(obj)

An improvement that comes to my mind for autostrings would be configurable default encoding.
pdfium mostly uses UTF16LE, so having that as default might actually be convenient for pypdfium2, though formally a default encoding remains a problem - it would still be a concern with the few APIs that use UTF-8 or ascii.

I made some progress on the calling convention matter today by taking a caller-given DLL type, and trying to auto-detect from the first function if not given. It does not support mixed calling conventions, though.
As an aside, this allows using the previously unexposed PyDLL or OleDLL. However, these are not new calling conventions, but merely other special cases.


bugfix/render-italics-and-bold-text

This PR fixes #878 by adding the metadata re bold and italics from neovim to the cell data and using that when the text is rendered.
Note: I haven't included underline in the final render as that seems to be another beast but theoretically one could use this SO answer which is a work around for not having a text-decoration style in canvas but wasn't sure whether the underline is wanted or whether it could/would be implemented using something similar to the error squiggles

Another side note: I've noticed that the syntax highlighter i.e. oni's additional one seems to add bolding to certain words overwriting vim's bolding or italics which could very well be intentional though not sure if it is expected so raising it here.

Wow, awesome  @Akin909 ! 👍  Sorry I've been slow to go through PRs this week. Can't wait to check this out! I'll be travelling the next couple days but back in action soon. Thanks for looking at this!

Note: I haven't included underline in the final render as that seems to be another beast but theoretically one could use this SO answer which is a work around for not having a text-decoration style in canvas but wasn't sure whether the underline is wanted or whether it could/would be implemented using something similar to the error squiggles

Seems reasonable - sounds like a lot of extra work since text-decoration isn't supported. (Didn't realize that, that's unfortunate). But yes, the SO answer looks promising - we could render it by drawing a line under the text. I think that'll be the better layer / more performant place to implement this.

Another side note: I've noticed that the syntax highlighter i.e. oni's additional one seems to add bolding to certain words overwriting vim's bolding or italics which could very well be intentional though not sure if it is expected so raising it here.

Interesting, this isn't expected - but we do use some built-in syntax highlight groups (like Identiifer), so if those happen to have bold/italics defined, it would pick those up. Let me know if there is a specific case you're seeing this with - we can look at the highlight group being used.

@bryphe no worries 👍 enjoy the break, just responding here for when you're free.
Re-underline - TLDR: its going to require a bit of work which I'd rather look into separately, not as part of this PR - the SO function works well just tried it locally though there's issues around when the underline highlight is triggered ?by neovim for example using spellbad with underline typing sout instead of shout the highlight is not consistently set to true once a typo occurs nor frequently updated so adding more characters or removing them doesnt reduce the size of the highlight as expected,
Re-syntax highlighting - spoke too soon as I have quite a few plugins and viml ad hoc highlighting settings in my init.vim, but to note it does set things like function definitions or methods to bold not sure what type these are as I dont get one specific highlight I can track, tbh its a pleasant unexpected effect imho and more related to highlight group that the textmate highlighting sets. As for user defined highlights these aren't actually overridden in my case it seems that I need to source my vimrc for it to pick up my adhoc highlighting but i'm not sure what that relates to or that its actually a part of this but rather a consequence of how oni loads in init.vims

Regarding underline, sounds great - IMO underline is less important than bold/italic (to me at least). Happy to track that in a separate issue!

Update: the odd syntax highlighting not corresponding to my init.vim was due to an antipattern I was using regarding applying add hoc highlights which worked (probably incorrectly) in terminal vim but not in oni which i've now resolved so don't think that issue of highlights not showing up is actually due to oni

Cool, glad you discovered the root cause! 😄
The code looks great to me. I just tested this change out on master, and I see some clipping of text with my config:

I'm using these settings:

If I use the default, everything looks fine:

I believe this may be a problem with my 'Fira Code' font - perhaps it isn't able to load the bold monospace version, and it's messing up the character widths. But we might need to add a check for this in the measureFont method in Font.ts - like validate that the bold and italic version of the string also have the same width, and pass up a isBoldAvailable and isItalicAvailable - it'd be better not to render bold/italics if the font doesn't support it (and perhaps log a warning in the console).
Thanks for all your work on this, @Akin909 ! 👍

@bryphe I think there is a slightly larger issue with font clipping in oni in general, I initially noticed that nerd font glyphs were being clipped which is an issue in macvim and in some terminal emulators which i think relates to an issue raised by @CrossR though I can't find the one (in that case it was special characters not rendering) I thought this was related to wcwidth and how it calculated character widths for unicode8-9 symbols
Although I've also noticed the font clipping using a regular font prior to this although it was minimal especially in the case of wider characters like w had slight clipping at the edge (using Fira Code Nerd Font at 17px), although for this specific case as you suggest we can check that the appropriate bold and italic fonts exists as it very well might not as you point out.

Here is a screen shot of the PR in action but if you look at the ref(0) italic the f is clipped which I believe is a separate issue as the italic font is available in this case

I've added the isBoldAvailable and isItalicAvailable check although the problem persisted despite it. Following some digging it seems that the html canvas element doesn't consistently manage non-integer font sizes. In IE the decimals are preserved, but in chrome the fonts are rounded to the nearest integer. So the error you described is actually specific to decimal font sizes.
Given that the canvas in chrome rounds decimal numbers (for font size) I've rounded the values passed from the config. Essentially there's also a peculiarity re how the canvasContext.font works which is what is responsible for the change see here.
The font used to calculate the width when using a decimal font is essentially smaller than the rounded font used by canvas causing the smooshing. Setting a font size consistent with canvas resolves this.
The slight clipping I mentioned earlier persists it's nowhere near as noticeable and it predates this PR. Tbh I'm still not clear on what the cause might be but it seems to relate to the amount of space each word is allotted as it only slightly clips the last char of a word.


Update knative.dev/pkg

This pulls forward the deps to 0.15
WIP until https://github.com/tektoncd/pipeline/pull/2712 lands.

/kind cleanup

/ok-to-test

/ok-to-test

Does this dep update introduce any ConfigMaps or Secrets that we need to account for as part of Pipeline's RBAC?

/assign @vdemeester @ImJasonH

/lgtm

ugh, I hate that git on OSX doesn't handle file renames involving case in a portable way.
I'll have to fix this manually and repush.

ok, this is RFAL.  macOS's case insensitive filesystem caused issues with shoulder.md -> SHOULDER.md 🙄

/test pull-tekton-pipeline-integration-tests

/retest

@ImJasonH This needs another LGTM 😞

@mattmoor Is it worth adding release notes?

Thanks for this @mattmoor !
If I understand this correctly, we generate the controllers now and but still not use them.
I've been looking at the new controllers from knative/pkg, I think most of it is a good fit for Tekton, but it will take a bit of work to integrate them. So I wonder if we should only generated them once we start using them?

Is it worth adding release notes?

For this alone, I don't think so.  I am looking at picking up some of the stuff we've landed (e.g. generated reconcilers), but that's going to take some doing.

So I wonder if we should only generated them once we start using them?

I could go either way on this.  I opted for this because script changes were needed for it to work and I had to dig around to find this patch from the last time I sat down to do this (thanks to @n3wscott for the help back then).
I could ofc keep the script changes and drop the // +genreconciler for now, but I wanted to make sure it worked.

I could ofc keep the script changes and drop the // +genreconciler for now, but I wanted to make sure it worked.

We may want to do that, wait for 0.13 to be done / "branched out" (later this week) and add them back :angel:

New commit with changed timestamp, starting a thread on the codegen stuff.

@vdemeester rerunning codegen now 😇

Ok, should be RFAL!

/cc @sbwsg @bobcatfish
It would be nice to have this one before 0.13 :stuck_out_tongue_closed_eyes:

Ok, should be RFAL!

RFAL?

/retest
RFAL = Ready For A Look (sorry, I love my acronyms)


bug: Element has shown in dom but not display in page

Type: bug
Platform: android 5.x webview
I use camera plugin to choice image in the local gallery, and display image in img tag. But sometimes, the element has show in the dom and image resourse has finished install, but it not display in the page.
HTML code:

JavaScript code:
var options = {
                destinationType: navigator.camera.DestinationType.FILE_URI,
                sourceType: navigator.camera.PictureSourceType.PHOTOLIBRARY,
                saveToPhotoAlbum: true,
                targetWidth: 800,
                targetHeight: 800
            };
navigator.camera.getPicture(function (imageURI) {
          $scope.imageList.push(imageURI);
                if (!$scope.$$phase) {
                    $scope.$apply();
                }
            }, function (error) {
                console.log("Error: " + error);
            }, options);

Greetings @xyxabcdiy!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

supplement: Physical back button does not work and if click other input element, image will display soon and everything goes well. But naxt choice local image will cause the problem again.

Are you witelisting file:// or blob:// ?

For example, try to include below into your project.
angular.module('starter').config(function( $compileProvider) {
    $compileProvider.imgSrcSanitizationWhitelist(/^\s*(https?|ftp|file|ms-appx|cdvfile|ms-appdata|blob|x-wmapp0):|data:image\//);
    $compileProvider.aHrefSanitizationWhitelist(/^\s*(https?|ftp|mailto|file|cdvfile|ghttps?|ms-appx|x-wmapp0):/);
});

That's for sure. Some times i can display local image in the page. If image can't display, it's innerHtml will be :

I don't known the data-ng-animate='2' in the element attribute and if it can be show, it will not have this attribute.

at the same time, the top bar also displays or hides?

@d1sa Top bar displays and the bugs has fixed in 1.2.1

The bugs has fixed in 1.2.1


closes #944: default http tag provider to return selected headers

Added stargate.metrics.http_server_requests_header_tags to select what headers you want added as tags. This is now default impl for the HttpMetricsTagProvider.

I made a huge mistake by not returning always the same amount of Tags. Fortunately caught by the INT test in #1035. Funny that I was aware of this, and then tried in a test with SimpleMeterRegistry, which is different from the Prom one. Fixed now.
See https://github.com/micrometer-metrics/micrometer/issues/877 for details.

/gcbrun dse-build


[WIP] DynamoDb client abstraction

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@4a513dc). Click here to learn what that means.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage        ?   95.92%
  Complexity      ?      164
=======================================
  Files           ?       27
  Lines           ?      662
  Branches        ?        0
=======================================
  Hits            ?      635
  Misses          ?       27
  Partials        ?        0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Dashboard breaks when no results exist

Describe the bug
When no speedtest records exist the dashboard returns "500 |  SERVER ERROR"
To Reproduce
Steps to reproduce the behavior:

Login
Click on "Results"
Delete all speedtest results
Click on "Dashboard"

Expected behavior
I expected the dashboard to open with an empty graph
Environment (please complete the following information):

Server OS: Raspbian
Server architecture: arm64
Client browser: Firefox
Version: v0.8.0

Screenshots
When opening the dashboard:

Empty results page:

Logs

Logs
I stripped the stacktrace because it was too long

[2022-12-17 14:52:06] production.ERROR: Call to a member function timezone() on null (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) {"userId":1,"exception":"[object] (Illuminate\\View\\ViewException(code: 0): Call to a member function timezone() on null (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.bla
de.php) (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) at /var/www/html/app/Filament/Widgets/StatsOverview.php:20)
[stacktrace]
#0 /var/www/html/vendor/livewire/livewire/src/ComponentConcerns/RendersLivewireComponents.php(106): Illuminate\\View\\Engines\\CompilerEngine->handleViewException()
...
[previous exception] [object] (Illuminate\\View\\ViewException(code: 0): Call to a member function timezone() on null (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) at /var/www/html/app/Filament/Widgets/StatsOverview.php:20)
[stacktrace]
#0 /var/www/html/vendor/livewire/livewire/src/ComponentConcerns/RendersLivewireComponents.php(106): Illuminate\\View\\Engines\\CompilerEngine->handleViewException()
...
[previous exception] [object] (Illuminate\\View\\ViewException(code: 0): Call to a member function timezone() on null (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) at /var/www/html/app/Filament/Widgets/StatsOverview.php:20)
[stacktrace]
#0 /var/www/html/vendor/livewire/livewire/src/ComponentConcerns/RendersLivewireComponents.php(106): Illuminate\\View\\Engines\\CompilerEngine->handleViewException()
...
[previous exception] [object] (Illuminate\\View\\ViewException(code: 0): Call to a member function timezone() on null (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) at /var/www/html/app/Filament/Widgets/StatsOverview.php:20)
[stacktrace]
#0 /var/www/html/vendor/livewire/livewire/src/ComponentConcerns/RendersLivewireComponents.php(106): Illuminate\\View\\Engines\\CompilerEngine->handleViewException()
...
[previous exception] [object] (Illuminate\\View\\ViewException(code: 0): Call to a member function timezone() on null (View: /var/www/html/vendor/filament/filament/resources/views/widgets/stats-overview-widget.blade.php) at /var/www/html/app/Filament/Widgets/StatsOverview.php:20)
[stacktrace]
#0 /var/www/html/vendor/livewire/livewire/src/ComponentConcerns/RendersLivewireComponents.php(106): Illuminate\\View\\Engines\\CompilerEngine->handleViewException()
[previous exception] [object] (Error(code: 0): Call to a member function timezone() on null at /var/www/html/app/Filament/Widgets/StatsOverview.php:20)
[stacktrace]
#0 /var/www/html/vendor/filament/filament/src/Widgets/StatsOverviewWidget.php(26): App\\Filament\\Widgets\\StatsOverview->getCards()
...
<IP_ADDRESS> - - [17/Dec/2022:14:52:06 +0000] "GET /admin HTTP/1.1" 500 6628 "http://speedtest-tracker.intra.net/admin/results" "Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Firefox/108.0"

Quick fix, go to settings and define your time zone which should address the issue. I'll update this setting to have a default in the next build

I've had this problem while I selected "Europe/Berlin" and I've tried a few other timezones but that doesn't seem to change anything.
My current workaround is to set speedtest schedule to something like "*/1 * * * *" (every minute) wait for one result to generate and then changing it back.

@alexjustesen I have set my timezone via docker-compose.
version: '3.3' services:     speedtest-tracker:         container_name: speedtest-tracker         #ports:             #- 8443:443             #- 8088:80         environment:             - TZ=Europe/Berlin             - PUID=1000             - PGID=1000             #- SSL_MODE=mixed         volumes:             - ./speedtest-tracker/config:/config          image: ghcr.io/alexjustesen/speedtest-tracker:latest         restart: unless-stopped         networks:             - npm networks:   npm:     external: true
In #235 you mentioned to go to the /results page, but thats a 404 here.

@alexjustesen I have set my timezone via docker-compose.
version: '3.3' services:     speedtest-tracker:         container_name: speedtest-tracker         #ports:             #- 8443:443             #- 8088:80         environment:             - TZ=Europe/Berlin             - PUID=1000             - PGID=1000             #- SSL_MODE=mixed         volumes:             - ./speedtest-tracker/config:/config          image: ghcr.io/alexjustesen/speedtest-tracker:latest         restart: unless-stopped         networks:             - npm networks:   npm:     external: true
In #235 you mentioned to go to the /results page, but thats a 404 here.

You'll want to do it in the UI settings not the docker config

Ok, thats /admin/results and /admin/general. The timezone seems to be set there to Europe/Berlin as well, but still the error 500 on `/admin* remains (in case you expected this to disappear with this...)

It was a hope... A hope from the brewery that I could continue to drink beer and resolve GH issues haha
I'll look more in depth tomorrow

Hello there :)
I spun up a Docker Container in Portainer and got the 500 Error after logging in. I added the TZ but still get this Error.
I´ll stay updated here.
Thanks Alex for helping us! If you need some Logs just tell me.

Ok, thats /admin/results and /admin/general. The timezone seems to be set there to Europe/Berlin as well, but still the error 500 on `/admin* remains (in case you expected this to disappear with this...)

I just wanted to contribute to this thread by saying Thank You for everyone's hard work and looking into this 500 error. I also ran into this the other night and stayed up late trying to figure out the 500 error with no luck. I was able to get to /admin/general but not the dashboard. Later, I decided what if I schedule a speed test? So I ran a scheduled speed test and then the dashboard page works now! Not sure if that helps figure out the root cause but thought I'd mention it.
Thanks Alex!


Removed unused imports in layers modules

Can one of the admins verify this patch?

@tensorflow-jenkins test this please

py3 rerun at http://ci.tensorflow.org/job/tensorflow-pull-requests-cpu-python3/6319/

gpu rerun at https://ci.tensorflow.org/job/tensorflow-pull-requests-gpu/6681/


Update README.md

Thank you for the submission @outbackStack, but this project isn't open to outside contributions at the moment even for small stuff like this. I've gone ahead and committed a similar change in the README to help sync things up 🙇


[BUG] can not open file from GUI

Nyx Text Bug Report
Description
Similar to https://github.com/parazeeknova/nyxtext/issues/14 but with errors.
Attempting to open a file from the GUI results in errors:

window appears then hidden behind main window

stack trace
(py3venv) C:\code\py\nyxtext>python  editor/scripts/main.py
Exception in Tkinter callback
Traceback (most recent call last):
File "C:\Pythons\Python312\Lib\tkinter_init_.py", line 1962, in call
return self.func(*args)
^^^^^^^^^^^^^^^^
File "C:\code\py\nyxtext\py3venv\Lib\site-packages\customtkinter\windows\widgets\ctk_button.py", line 554, in _clicked
self.command()
File "C:\code\py\nyxtext\editor\scripts\framework\welcome_Screen.py", line 55, in
welcome_open_button = customtkinter.CTkButton(self.welcome_tab,text=" Open file... ", command=lambda: open_window(self.welcome_tab),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\code\py\nyxtext\editor\scripts\framework\welcome_Screen.py", line 54, in open_window
open = openfile_window(master)
^^^^^^^^^^^^^^^^^^^^^^^
File "C:\code\py\nyxtext\editor\scripts\framework\open_file.py", line 12, in init
self.wm_attributes('-type', 'splash')
File "C:\Pythons\Python312\Lib\tkinter_init.py", line 2046, in wm_attributes
return self.tk.call(args)
^^^^^^^^^^^^^^^^^^
_tkinter.TclError: bad attribute "-type": must be -alpha, -transparentcolor, -disabled, -fullscreen, -toolwindow, or -topmost

Steps to Reproduce

start editor
Click "open file"

Expected Behavior
No crash and from code scan file chooser dialog
Actual Behavior
See above
Screenshots
[If applicable, add screenshots to help explain the problem. You can drag and drop images here.]
Environment

OS: Windows 10

Nyx Text Version: ❗ this information is not available from the GUI - 3cfb7d72730acc4a16745d6a9967a3f9ba9ef19b see https://github.com/parazeeknova/nyxtext/issues/14

Other relevant information:
Python 3.12.1 (tags/v3.12.1:2305ca5, Dec  7 2023, 22:03:25) [MSC v.1937 64 bit (AMD64)] on win32

Pillow-10.2.0
chlorophyll-0.4.1
customtkinter-5.2.2
darkdetect-0.8.0
packaging-24.0
pygments-2.17.2
pyperclip-1.8.2
tklinenums-1.7.1
toml-0.10.2

Additional Context
[Add any other context about the problem here. For example, any recent changes made to the project, or any workaround attempted.]
Possible Solution
[If you have any ideas on how to fix the bug, or where the problem might be located, please provide them here.]
Related Issues
[If there are any related issues or pull requests, please link them here.]
Your GitHub Username
[Please provide your GitHub username if you would like to be notified about updates or if further clarification is needed.]
Labels
[Choose appropriate labels to categorize the bug report, such as "bug", "needs investigation", etc.]

Modifying to:
self.wm_attributes('-topmost', 'true')

Gets past this error but then fails to load.
    (py3venv) C:\code\py\nyxtext>python  editor/scripts/main.py
    Exception in Tkinter callback
    Traceback (most recent call last):
      File "C:\Pythons\Python312\Lib\tkinter\__init__.py", line 1962, in __call__
        return self.func(*args)
               ^^^^^^^^^^^^^^^^
      File "C:\code\py\nyxtext\py3venv\Lib\site-packages\customtkinter\windows\widgets\ctk_button.py", line 554, in _clicked
        self._command()
      File "C:\code\py\nyxtext\editor\scripts\framework\open_file.py", line 56, in open_file
        self.text_Area.text_area.delete(1.0, tk.END)  # Clear the text area
        ^^^^^^^^^^^^^^
    AttributeError: 'openfile_window' object has no attribute 'text_Area'

Hmm , yeh seems like the attributes we are using for new_file.py and open_file.py on the welcome tab are linux specific. I guess @noviciusss will be fixing the same and adding a exception handling or if/else for the attributes for the window which is creating the issue, ALSO, any function to open file in the workspace and codespace do not work after the recent change in file structure so will implement the correct functionality to open file in few days...

Fixed bug as i was using Linux so it was compatible with mine but corrected it to work for both

This is not fixed for me. Still seeing the exact same problem as described in https://github.com/parazeeknova/nyxtext/issues/15#issuecomment-2002112198 which is why I did not open a PR with the fix I previously identifed.
@noviciusss If this is working for you can you explain how to open the file as maybe I'm doing something wrong?
With the current code:
commit c224811da6732189d05912312379366eaedcbbaa (HEAD -> main, origin/main, origin/HEAD)
Author: Samarth Pratap Singh<EMAIL_ADDRESS>Date:   Sun Mar 17 18:46:34 2024 +0530

    fixed bug

After clicking Open file on the main window, the pop-up window actually pops-under and is hidden, have to bring it to front.
Once at front and use the "Open ..." button get a file chooser, which then crashes with the same stack trace (only difference is the moved line numbers):
(py3venv) C:\code\py\nyxtext_clach04>python  editor/scripts/main.py
Exception in Tkinter callback
Traceback (most recent call last):
  File "C:\Pythons\Python312\Lib\tkinter\__init__.py", line 1962, in __call__
    return self.func(*args)
           ^^^^^^^^^^^^^^^^
  File "C:\code\py\nyxtext\py3venv\Lib\site-packages\customtkinter\windows\widgets\ctk_button.py", line 554, in _clicked
    self._command()
  File "C:\code\py\nyxtext_clach04\editor\scripts\framework\open_file.py", line 59, in open_file
    self.text_Area.text_area.delete(1.0, tk.END)  # Clear the text area
    ^^^^^^^^^^^^^^
AttributeError: 'openfile_window' object has no attribute 'text_Area'

None of the other clickables in the front window seem to do anything.
Anything else you need from me for this bug report?

Currently the functionality behind any buttons do not work after the rebase, we are currently in process of changing the pervious code that is why your are getting this error,
AttributeError: 'openfile_window' object has no attribute 'text_Area'

As we need to implement code such that the file opens the text into the tab in which the user is currently working, I'll be coding this today so wait for commits that fixes this.
And btw, is nyxtext running on your device and showing the welcome screen ?

Currently the functionality behind any buttons do not work after the rebase, we are currently in process of changing the pervious code that is why your are getting this error,
AttributeError: 'openfile_window' object has no attribute 'text_Area'

As we need to implement code such that the file opens the text into the tab in which the user is currently working, I'll be coding this today so wait for commits that fixes this.
And btw, is nyxtext running on your device and showing the welcome screen ?

Can't implement open file today, will see tomorrow


style(frontend): pulsating token balance when loading in list

…in list
Motivation

Changes

Tests
I slowed down the initialization to test:
https://github.com/user-attachments/assets/4bd287b3-a24d-4c0c-a3dc-410454305394

As discussed with Artem, this is not a good solution


Readonly attribute id will be ignored in CertificatePolicy

The serializer logs a warning about the generated CertificatePolicy class. Maybe there's an issue in the API spec, or our code sets an attribute it shouldn't?
For example:
import logging
import sys

from azure.keyvault.certificates import CertificateClient, CertificatePolicy
from azure.identity import DefaultAzureCredential

logging.basicConfig(
    level=logging.WARNING,
    format="[%(pathname)s] %(message)s",
    handlers=[logging.StreamHandler(stream=sys.stdout)],
)

client = CertificateClient(VAULT_URL, DefaultAzureCredential())
client.begin_create_certificate('cert', CertificatePolicy.get_default())

Output:
[...msrest\serialization.py] Readonly attribute id will be ignored in class
<class 'azure.keyvault.certificates._shared._generated.v7_0.models._models_py3.CertificatePolicy'>

This doesn't repro in 4.0.0, apparently it was fixed after 4.0.0b6.


Simplify docs

I noticed that the docs were getting a little out of date compared to how I see people actually start Android projects. I've updated them to use a simpler flow focusing on Android Studio but still calling out how to run tests and build an apk on the command line.
@robolectric/maintainers what ya think?

Looks good to me


Ensure no extraneous comments in code

setup.py RDKit check needs to be uncommented and moved elsewhere

Resolved in latest commit.


Update group_1.yml

Group Members Josue Andaluz, Anh Bui

Requesting a pull request for testing final project, group name is Josue Andaluz and Anh Bui

@josue123455 merged.


Increase limit on bookmark URL length

I tried to add a URL but got:

Ensure this value has at most 200 characters (it has 265).

This seems pretty low as clean URLs even without tracking/marketing parameters can often go beyond 200 chars. No such complaint was made for any link at the time of import so it does seem to work (or does it trim such URLs while importing?)
Would request for an increased limit on bookmark URL length.

@hirusi Good catch! The model did not specify a limit, however Django applies a default limit of 200. Increase the limit to 2048 for now. Removing the limit would also be possible but is a larger change with setting up a custom URL field including validation.


Add Von Neumann entropy dq.entropy_vn()

Replaces #367. Thanks @baptistehoyau for starting this PR back in the PyTorch days!
Closes DYN-129.

Also, I may prefer the name dq.entropy instead of dq.entropy_vn. It's a bit closer to the other function names that we already have. What do you think?

@gautierronan concerning this comment, I'm in favour of keeping smthg that refers to the Von Neumann entropy, as there are lots of different definitions.


Fix fix accumulation and transfer logic

Fix validation accumulation.
Fix apply(transfer) (next_debit_version was not updated).
Negates validation of replica keys (temporarily) during credit/sync with simulated-payouts flag
Adds support for SectionProofChain checking in safe_vault
Adds tests

Superseded by #21


fix: pre-commit auto update permissions

Enable write permissions for auto update
workflow.
Refs: #1869

closing in favour of https://github.com/sustainable-computing-io/kepler/pull/1871


Adding samples and instruction to README.md

We would like to organize a sample and how to use it before pre-release.
It is a little complicated, especially where json is involved.
We would like to illustrate some common configurations.
https://github.com/Azure/aca-deploy/blob/08f4b497c50929376c33d7b1c2d7c8ad0d8faff7/README.md?plain=1#L72-L120

will be handled at #56


[WIP] Cardano (Shelley) support

Description
Cardano current 'Shelley' version support:

Rework earlier address suport (has changed)
Add signing.

Fixes #1815 .
Mnemonic interoparability:

From AdaLite: yes, except 12-words (which are treated as legacy in AdaLite); only first (/0) address
To AdaLite: 12-words not, as AdaLite treats 12-word mnemonics as legacy (Byron)

Testing instructions

Types of changes

Checklist

[ ] TODO: Option for MaxAmount
[x] Prefix PR title with [WIP] if necessary.
[x] Add tests to cover changes as needed.
[ ] Update documentation as needed.
[x] I have read the guidelines for adding a new blockchain
[x] If there is a related Issue, mention it in the description (e.g. Fixes #<issue_number> ).

@catenocrypt

Status update: Functionality is mostly done, including transaction compilation and signing; real-world transaction milestone passed.
Some leftovers like swift/kotlin tests, support max amount, coverage.

Case with input UTXOs with token amounts: the token amounts should be carried over (to the output output, otherwise tx will result in error ValueNotConservedUTxO). This is not implemented yet, will give explicit error. To be handled later.

All current comments handled, ready for review/merge.


GATConv with edge_index=None

❓ Questions & Help
In the original GAT paper, they mentioned that it is possible to provide no edge prior to a graph while the edges will be learned entirely through the node features. I am wondering if it is possible for this implemented GATConv layer? If not, are there any variance of this provided in this repo?
My current idea is that, if we supply edge_index as a fully connected graph. Then the above feature is implemented?
Thanks in advance!

Interesting approach, and this can be indeed achieved by using a fully connected graph. The use of a sparse edge_index for fully connected graphs is, however, not recommended. In addition, this formulation basically just boils down to the initial attention formulation, so I would simply use the PyTorch Attention module to achieve this.

Thanks for the reply! So if I use GATConv with a fully-connected graph, it still works, but might be slower?

That‘s correct.


include cookiebanner

some relevant discussion on the exchange PR on cookie banners

@sandikbarr were you making more changes, or should we merge?

@kookster sounds like @pkarman has an open question about the top positioning on exchange at least, not sure that applies here, otherwise done here

I'm pretty ok with having them on top, I feel like they blending into the background, and were too easily ignored at bottom (at least on exchange), so I think I am good to go with this.


New debian patches

REF #176
Target: Include new debian patches
had arrived
http://mirrors.dcarsat.com.ar/debian/pool/main/c/chromium-browser/

http://mirrors.dcarsat.com.ar/debian/pool/main/c/chromium-browser/chromium-browser_56.0.2924.76-1.debian.tar.xz


Adding logos for 56k Cloud, AWS IoT Greengrass, NetFoundry, and Scalys

Adding logos for 56k Cloud, AWS IoT Greengrass, NetFoundry, and Scalys, as per https://cncfservicedesk.atlassian.net/browse/CNCFSD-1030

Hold for updated logo.

Unhold, logo updated.

I think this is ready for review.
/cc @celestehorgan @caniszczyk

/cc @nineinchnail (just found your github handle Marc 🙂)


v20.2 GRANT updates

Fixes https://github.com/cockroachdb/docs/issues/8337.
Fixes https://github.com/cockroachdb/docs/issues/8335.
Fixes #8302.
Related to #8817.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/ee22ea04f097eb47c3d7e69fa08c055ac7264cd1/
Edited pages:

v20.2/authorization.md
v20.2/grant.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b46011cecc15dd1dd6a28555ee64fb029f2125d7/
Edited pages:

v20.2/authorization.md
v20.2/grant.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/382b8f89a87ab8b05bf2e8c65de1415cf3736512/
Edited pages:

v20.2/authorization.md
v20.2/create-schema.md
v20.2/enum.md
v20.2/grant.md

@ajwerner Friendly ping on review.
Would like to get these docs merged by the marketing release Tuesday. LMK if I should request review from a different engineer. Thanks! :)

@ajwerner Passing this to writer review, as release is tomorrow. Any technical corrections not caught in writer review can be added post-merge.


Add JSON_FRACTIONAL_DIGITS encoding flag

The JSON_FRACTIONAL_DIGITS encoding flag, when combined with the
JSON_REAL_PRECISION flag, causes the precision to indicate the number
of digits after the decimal (fractional digits) rather than the total
number of significant digits. Specifically, it changes the printf
conversion specifier from g to f.

A feature such as this would be useful for some use cases we have, such as reducing JSON size in a large output where high precision is not needed (but for various reasons, the %f conversion is preferable to %g for this particular case).
Is there any interest in incorporating this feature into jansson? This PR is an example of the feature I want; I'd be happy to modify it to better fit naming schemes or anything else.
Thank you.

+1


fix find openmp

cmake with AppleClang currently does not find openmp (even when installed via brew). This PR adds some code that we use in networkit as well to help cmake.

merged with #18


Can we extend the timeout of 60s for cleanup

TASK [cleanup_operator_resources : Delete all processed resources in the deploy directory] ***
changed: [localhost] => (item=/tmp/operator-test/olm-operator-files/subscription.yml)
changed: [localhost] => (item=/tmp/operator-test/olm-operator-files/catalogsource.yml)
changed: [localhost] => (item=/tmp/operator-test/olm-operator-files/catalogsource-prod.yml)
failed: [localhost] (item=/tmp/operator-test/olm-operator-files/namespace.yml) => changed=true
  ansible_loop_var: cor_all_yml_item
  cmd: kubectl delete -f /tmp/operator-test/olm-operator-files/namespace.yml --ignore-not-found=true --timeout=60s
  cor_all_yml_item: /tmp/operator-test/olm-operator-files/namespace.yml
  delta: '0:01:00.073248'
  end: '2022-04-28 14:43:25.038989'
  msg: non-zero return code
  rc: 1
  start: '2022-04-28 14:42:24.965741'
  stderr: 'error: timed out waiting for the condition on namespaces/test-operators'
  stderr_lines: <omitted>
  stdout: namespace "test-operators" deleted
  stdout_lines: <omitted>
changed: [localhost] => (item=/tmp/operator-test/olm-operator-files/operatorgroup.processed.yml)

This is the issue I ran into for testing knative operator.
It happened most of the time, but after a few times of retesting, it goes away.
I suspect that 60s could be a little shorter. Can we extend the timeout for cleanup to 180s? or even 300s?

This in done and it is in production. Timeout was set to 300s


Make vote distribution bot run as a service

@wc117 I've made some changes to https://github.com/VolumeFi/vote-distribution-bot-script so that we can run it as a service instead of as a cron job. I haven't touched the main part of the scripts and they seem to be having issues..
please check the changes I made yesterday. https://github.com/VolumeFi/vote-distribution-bot-script/commits/master
Currently the error we are getting is the following
Running vote distribution bot vote...
Running vote distribution bot collect...
Traceback (most recent call last):
  File "/home/rootedbox/app/vote-distribution-bot-script/vote_distribution.py", line 30, in <module>
    asyncio.run(main())
  File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "uvloop/loop.pyx", line 1517, in uvloop.loop.Loop.run_until_complete
  File "/home/rootedbox/app/vote-distribution-bot-script/vote_distribution.py", line 20, in main
    await collect_module.run_collect()
  File "/home/rootedbox/app/vote-distribution-bot-script/vote_distribution_bot_collect.py", line 81, in run_collect
    data = json.load(f)
  File "/usr/lib/python3.10/json/__init__.py", line 293, in load
    return loads(fp.read(),
  File "/usr/lib/python3.10/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.10/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.10/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 28 column 1 (char 678)

Please check and fix the code. It's currently running on bots-server in the following directory /home/rootedbox/app/vote-distribution-bot-script

I fixed it. Please check again. @rootedbox


The "SENTRY_LARAVEL_DSN" variable is not set. Defaulting to a blank string.

Environment
PHP: 8.1
Laravel 10.x
Sentry Laravel: 3.3.2
Steps to Reproduce

install the package into project
publish the config
set SENTRY_LARAVEL_DSN to the https://xxxxx.com/ URL
clear config cache

Expected Result
I should not be getting any warnings
Actual Result
I'm getting a Sentry warning:

WARN[0000] The "SENTRY_LARAVEL_DSN" variable is not set. Defaulting to a blank string.

I think you might be doing something in your application or tooling causing the warning since that warning is not something coming from our codebase. Do you have more information from where the warning is generated from?
The warning structure is also not something I recognize from either PHP or Laravel so this might be some custom tooling or package validating your .env/config or something.

I am closing this issue because of inactivity, if there is still an issue please re-open / open a new issue so we can investigate 👍


refactor(wasm): modularize wasm crate logic

References #3431

@hdevalence looking at build_action method again, I'm realizing it doesn't need to take the transaction_plan field. It's deserializing an entire TransactionPlan just to access the memo_plan which can simply be passed in from the web-side.

Yeah, I thought the reason for that was that it would be simpler to only pass one object over FFI into wasm. Even if it's a little inefficient, that's fine if the code becomes simpler, as long as it's not the dominant performance factor.

This PR is blocked until #3429 is merged.


[0.9.0] Group by tag failing

The following query is returning an empty result:
SELECT count(value) FROM db0.rp0.cpu where time >= '2000-01-01T00:00:00Z' and time <= '2000-01-01T02:00:00Z' group by host

It should result in:
{"results":[{"series":[{"name":"cpu","tags":{"host":"server01"},"columns":["time","count"],"values":[["2000-01-01T00:00:00Z",1]]},{"name":"cpu","tags":{"host":"server02"},"columns":["time","count"],"values":[["2000-01-01T00:00:00Z",1]]},{"name":"cpu","tags":{"host":"server03"},"columns":["time","count"],"values":[["2000-01-01T00:00:00Z",1]]}]}]}

But is resulting in:
{"results":[{}]}

There is a test that can reproduce this at cmd/influxd/run/server_test.go test name: TestServer_Query_MergeMany

Works for me in 0.9.2:
> select count(value) from cpu_idle where time > '2015-08-17T00:00:00Z' and time <= '2015-08-17T22:00:00Z' group by cpu
name: cpu_idle
tags: cpu=cpu0
time				count
----				-----
2015-08-17T00:00:00.000000001Z	1707

name: cpu_idle
tags: cpu=cpu1
time				count
----				-----
2015-08-17T00:00:00.000000001Z	1707

name: cpu_idle
tags: cpu=cpu2
time				count
----				-----
2015-08-17T00:00:00.000000001Z	1707

name: cpu_idle
tags: cpu=cpu3
time				count
----				-----
2015-08-17T00:00:00.000000001Z	1707

name: cpu_idle
tags: cpu=cpu4
time				count
----				-----
2015-08-17T00:00:00.000000001Z	1707

name: cpu_idle
tags: cpu=cpu5
time				count
----				-----
2015-08-17T00:00:00.000000001Z	1707

name: cpu_idle
tags: cpu=cpu6
time				count
----				-----
2015-08-17T00:00:00.000000001Z	1707

name: cpu_idle
tags: cpu=cpu7
time				count
----				-----
2015-08-17T00:00:00.000000001Z	1707

>


Is there someone meet this problem that modsec_audit.log not show when detect 403 forbedden

have you see the modsec_audit.log not show. such as
docker run -it --rm --name=ngx  -p 8000:80  owasp/modsecurity-crs:3.3-nginx

docker exec -it  ngx  tail -f /var/log/modsec_audit.log

and then we can see if we curl  http://<IP_ADDRESS>:8080/?page=../../test_rfi , then 403 forbben but the modsec_audit log not show ....
whats the mater ?.
best with to you.

i have make modsecurity-nginx  v1.0.1 -> 1.0.0 and solve that problem. but i set detectOnly no use
{"transaction":{"client_ip":"<IP_ADDRESS>","time_stamp":"Thu Sep 17 14:58:45 2020","server_id":"729f37d2889d305a54228dc5b632fcc73da051b3","client_port":27298,"host_ip":"<IP_ADDRESS>","host_port":8080,"unique_id":"160032592533.438534","request":{"method":"GET","http_version":1.1,"uri":"/?page=../../k111","body":"","headers":{"Host":"<IP_ADDRESS>:8080","Connection":"keep-alive","Upgrade-Insecure-Requests":"1","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36","Accept":"text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9","Accept-Encoding":"gzip, deflate","Accept-Language":"zh-CN,zh;q=0.9"}},"response":{"http_code":403,"headers":{"Server":"nginx","Date":"Thu, 17 Sep 2020 06:58:45 GMT","Content-Length":"548","Content-Type":"text/html","Connection":"keep-alive"}},"producer":{"modsecurity":"ModSecurity v3.0.3 (Linux)","connector":"ModSecurity-nginx v0.1.1-beta","secrules_engine":"DetectionOnly","components":["OWASP_CRS/3.3.0\""]},"messages":[{"message":"Path Traversal Attack (/../)","details":{"match":"Matched \"Operator `Rx' with parameter `(?i)(?:\\x5c|(?:%(?:c(?:0%(?:[2aq]f|5c|9v)|1%(?:[19p]c|8s|af))|2(?:5(?:c(?:0%25af|1%259c)|2f|5c)|%46|f)|(?:(?:f(?:8%8)?0%8|e)0%80%a|bg%q)f|%3(?:2(?:%(?:%6|4)6|F)|5%%63)|u(?:221[56]|002f|EFC8|F025)|1u|5 (400 characters omitted)' against variable `ARGS:page' (Value: `../../k111' )","reference":"o9,4v4,17o2,4v11,10","ruleId":"930100","file":"/apps/nginx/conf/modsec/rules/REQUEST-930-APPLICATION-ATTACK-LFI.conf","lineNumber":"29","data":"Matched Data: /../ found within ARGS:page: ../../k111","severity":"2","ver":"OWASP_CRS/3.3.0","rev":"","tags":["application-multi","language-multi","platform-multi","attack-lfi","paranoia-level/1","OWASP_CRS","capec/1000/255/153/126"],"maturity":"0","accuracy":"0"}}]}}

Hi @xx-zhang,
What is the version of yours libModSecurity? Have you enabled the AuditLog?

@zimmerle using ur owasp docker . the docker image  owasp/modsecurity-crs:3.3-nginx ;
all the latest .  modsecurity 304  modsecurity-nginx 1.0.1  nginx 1.17.9  crs330

sorry @zimmerle  i meet the second problem is modsecurity304, nginx1.18, modsecurity-nginx1.0.0 . thank you

redirect https://github.com/SpiderLabs/ModSecurity/issues/2237


can spark-notebook support scala 2.12

Spark itself is compiled/published only with scala versions 2.10 and 2.11: https://mvnrepository.com/artifact/org.apache.spark/spark-core
seems like spark doesn't compile well with scala 2.12 so far  https://contributors.scala-lang.org/t/spark-and-scala-2-12/1576/4 (but I might be wrong, I did very short googling...)
so I'm afraid 2.12 wouldn't work yet...


Time cost when fine-tuning on COCO-irtr dataset

Hi, Thanks for your fantastic work
I've been trying to reproduce the result on fine-tuning on pre-trained model.It takes me only about 6 hours to fine-tune on VQAV2 dataset.But when I try to fine-tune on the COCO dataset,It took me about 20 hours to run only 1 epoch,I wonder if It's the corrent result.
Also,I find that when I finish one epoch fine-tuning on COCO dataset,It didn't automatically save the model.Is there a problem with my setting?
My experiement was ran on 8 V100 GPUs.

Hi @simplelifetime,
The reason why IRTR tasks take so long is that it requires every pair to be passed through the transformer when validation to get the image-text matching score.
It causes drastically longer evaluation time compared to those require simple dot product to get the score.
You can reduce the overall fine-tuning time by simply not doing evaluation for every epoch.
Pass val_check_interval >= float(epochs) argument to pl.Trainer's init function in run.py will do the job.

Thank you for your reply!That really helps solve my problem.


Implement persistent DBAL using Postgres

All storage adapters need a persistent DBAL. We want to support Postgres in the beginning, more adapters might follow at some point.

Resolved by #79


Consumer group reset offset

Consumer group reset offset
consumer group reset offset page

Dryrun page

Can we remove the delete button and make the reset offset button usable? Otherwise, both should be removed (or hidden for now).

@MikeEdgar, can we merge this PR? If there are more updates I will do them in another PR

@hemahg I'm doing another round of testing and I'll merge before EOD.


Adding code to complete Assignment 1 for the SQL session

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added SQL code to complete Assignment 1 of the SQL session.
What did you learn from the changes you have made?
I learned to use SQL commands such as SELECT, FROM, WHERE, CASE, JOIN, aggregates, grouping, and more.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
n/a
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
JOIN and GROUP were not easy to use from the start, so I tried a few options before I found one that worked.
How were these changes tested?
Went to Browse Data and calculated a few numbers to confim the my code works.
A reference to a related issue in your repository (if applicable)
n/a
Checklist

[x ] I can confirm that my changes are working as intended

I uploaded the logical data model diagram to my folder directly on
Githab as was suggested. I'm not sure why it's missing. Perhaps I uploaded
it to the main branch. What should I do now?
Best Regards,
Max Trunov
647-802-4488
On Mon, Dec 16, 2024 at 1:19 AM JzfL @.***> wrote:

@.**** approved this pull request.
sql code works well but missing section 1 logical data model diagram
—
Reply to this email directly, view it on GitHub
https://github.com/maxatrgh/sql/pull/1#pullrequestreview-2505244686, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BM3HJHW2EBQZXIUUD3L5FPT2FZWIHAVCNFSM6AAAAABTTWWQ4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBVGI2DINRYGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

ᐧ

Hi Max,No worries, for now, you can try paste a screenshot of it into the GitHub PR comments, and I can mark from there.Best regardsJames LiOn Dec 16, 2024, at 10:45 AM, maxatrgh @.***> wrote:
I uploaded the logical data model diagram to my folder directly on
Githab as was suggested. I'm not sure why it's missing. Perhaps I uploaded
it to the main branch. What should I do now?
Best Regards,
Max Trunov
647-802-4488
On Mon, Dec 16, 2024 at 1:19 AM JzfL @.***> wrote:

@.**** approved this pull request.

sql code works well but missing section 1 logical data model diagram

—

Reply to this email directly, view it on GitHub

https://github.com/maxatrgh/sql/pull/1#pullrequestreview-2505244686, or

unsubscribe

https://github.com/notifications/unsubscribe-auth/BM3HJHW2EBQZXIUUD3L5FPT2FZWIHAVCNFSM6AAAAABTTWWQ4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBVGI2DINRYGY

.

You are receiving this because you authored the thread.Message ID:

@.***>

ᐧ
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

Please let me know if it works.

Looks great! well done! 30/30


wsl.exe kills a program when it is put to background by "&"

Your Windows build number: 10.0.19013.1102]

What you're doing and what's happening:

Create a script in HOME named as test.sh

#!/bin/bash
if [ -e ~/file1 ]; then
	rm -f ~/file1
fi
~/test1.sh &

and test1.sh
#!/bin/bash

touch ~/file1

Run chmod +x *.sh
Run in bash as ./test.sh
In cmd run wsl ~/test.sh

What's wrong / what should be happening instead:

Run in bash as ./test.sh
file1 shows up
In cmd run wsl ~/test.sh
file1 don't shows up

In cmd run wsl ~/test.sh
file1 don't shows up

Can't follow this one. file1 disappears because you've removed it. Closing because not actionable.

In cmd run wsl ~/test.sh
file1 don't shows up

Can't follow this one. file1 disappears because you've removed it. Closing because not actionable.

Maybe I havn't descripte this clearly. In test.sh file1 is deleted and then call test1.sh which recreate that.
When ran inside bash, test1.sh is properly called and recreated file1.
When ran in wsl.exe test1.sh is not properly started and file1 will not be recreated.

@therealkenc Here is a easier reproducement of this problem:
#!/bin/bash
if [ -e ~/file1 ]; then
	rm -f ~/file1
fi
touch file1 &

When the script is run by bash, file1 is deleted and recreated.
When run by wsl.exe, file1 is deleted and never recreated.

You haven't specified a path to touch file1 above (missing the ~), but I see it now. Below is not intended as a work-around, but it does demonstrate the cause of the problem.
#!/bin/bash
if [ -e ~/file1 ]; then
	rm -f ~/file1
fi
touch ~file1 &
sleep 1

[Unfortunately running the script under strace(1) masks the problem also, so I can't fill out the issue template on your behalf.]
Long story short, you've got a /bin/bash instance that is about to die, and the shell job is still running with a pty open. Which is at best problematic. Consider a background job that runs longer than your typical touch.
#!/bin/bash
if [ -e ~/file1 ]; then
        rm -f ~/file1
fi
/bin/bash -c "sleep 3; echo hello; /bin/touch $HOME/file1" &

I did try the scenario with ssh and the client does hang around for the server's children to exit. This behavior is nonobvious, but it does suggest intended behavior. So yeah, let's re-open on that basis.

 The fact that ssh hung around for 3 seconds utterly negated what (must be) your intent in putting touch in the background in the first place.
If you really want touch(1) to run in the background, you'd want to dissociate the pty with [daemonize](https://software.clapper.org/daemonize/) (or do something similar).
This does take in your wsl.exe scenario
#!/bin/bash
if [ -e ~/file1 ]; then
	rm -f ~/file1
fi
daemonize touch ~file1

@therealkenc I think most time people would want wsl.exe command just act like /bin/bash -c "command" in a native linux shell. Using touch is just for simplifying the whole question. In fact, I'm trying to hack xdg-open to allow linux programs to open folders and files using Windows applications without changes in those linux programs.
But many linux programs (such as texdoc) call xdg-open by xdg-open URL &. That makes it impossible for me to use commands such as texdoc as wsl texdoc -, which is a must for a Windows side application to use wsl something to replace something

Using touch is just for simplifying the whole question

It doesn't simplify the question. You've spawned a job on a bash shell that is about to die. cmd.exe is not a bash shell. It doesn't have jobs.

You may benefit from using detach to remove the job placed into the background (&) from the parent shell’s job control. It is, otherwise, nondeterministic as to whether touch completes before the shell exits and terminates it.
touch file1 & disown

It is, otherwise, nondeterministic as to whether touch completes before the shell exits

Any idea what strategy ssh/sshd uses to keep the session alive? Only ask because I didn't look deep myself; and because before I tried it, I mostly expected the nondeterministic behavior you cite above. I was a bit surprised to see ssh wait, instead of the child taking the SIGHUP and die. [This issue probably would have ended by-design otherwise.] This doesn't imply WSL interop needs to follow the ssh precedent, natch. Just that ssh waits was curious.

Tagging needs-attention insofar as the submission needs a ruling by-design versus absence of feature. Assuming an sshd running on WSL's default distro, a tight repro is:
C:\>wsl.exe sh -c "echo 'sleep 5 &' > $HOME/sleepscript.sh"
C:\>wsl.exe chmod 755 $HOME/sleepscript.sh
C:\>echo "" | wsl.exe $HOME/sleepscript.sh
C:\>echo "" | ssh.exe ken@localhost -p 2222 $HOME/sleepscript.sh

Running sleepscript.sh via interop returns immediately. Running the script via Windows' ssh.exe will block for five seconds before returning to the command prompt. There's a strong-ish case they should behave the same.


Connection Keepalive

Hi, I'm currently using the hyper master branch. I have written a Service and want that the connection is dropped after each request. I thought that using "Http::keep_alive(false)" should close the connection? But that does not work. Is this a bug or do I use the wrong functionality?

Turns out a bug had snuck in, and test coverage wasn't making sure keep-alive turned off worked. New PR with a fix is currently going through CI, fix merged soon. Thanks for the report!

Thx for the fast support :)


feat: add detail section to code webview [HEAD-559]

Description
This PR adds the details information to the Webview panel
Checklist

[ ] Tests added and all succeed
[ ] Linted
[ ] CHANGELOG.md updated
[ ] README.md updated, if user-facing

Screenshots / GIFs

Before
After

https://github.com/snyk/vscode-extension/assets/1948377/c6adc70f-e142-458d-9213-3b76ebd100d7

Please add a changelog entry :)


APPLY: create landing page ( #80 )

Closes #80
Description

What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[x] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

NEED: code format.


Live Preview support for native (non-dataview) tables

I saw that #22 has been implemented, but I'm wondering if the same would be possible for native tables created with | to be sorted in Live Preview?
I know it might be tricky as clicking anywhere on the table currently opens it for editing.

Hi,
Please see https://github.com/alexandru-dinu/obsidian-sortable/discussions/23#discussioncomment-2457695

Ah thanks, I didn't see it in the comments. I'll close this issue then.


graphql: reworking Socket Client API to support custom header

Fixes https://github.com/zino-hofmann/graphql-flutter/issues/815

[X] Cleaning we test
[ ] Adding custom header test, this required to change a little bit the mock server

The only reason to support the custom function in the connect function is that can exist a use case where it is good to create a unique connection without recreating a new Websocket client.

We can keep it as is if you prefer, if nothing else it'll preserve backward compatibility.

We can keep it as is if you prefer, if nothing else it'll preserve backward compatibility.

I reflected on this a little bit, and from the actual API, I think it is more users have the function in the SocketClientConf. let's go in this way and after we will see if this require more work


[lib] Add volatile to launder*() to avoid miscompilations

In some cases, LLVM has shown it is able to deduplicate calls to
launder32() in a way inimical to hardening. Although this isn't
the "most correct" way to fix it, it is one that we know will work
for the time being until we need to revisit whether this volatile
is unnecessary.
The comments on the implementation have been extended with further
notes on volatile asm.
Thank you to @alphan for showing me a snippet I was able to reduce to a repro.

Closes https://github.com/lowRISC/opentitan/issues/10294


[SPARK-36539][SQL] trimNonTopLevelAlias should not change StructType inner alias

What changes were proposed in this pull request?
trimNonTopLevelAlias should not change StructType inner alias, since it may impact output schema
Why are the changes needed?
Keep schema consistence after Optimization
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existed UT

Test build #142589 has started for PR 33778 at commit 744a798.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47089/

Test build #142589 has finished for PR 33778 at commit 744a798.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47089/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47089/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142589/

Test build #142600 has started for PR 33778 at commit d143c4c.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47100/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47100/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47100/

Test build #142600 has finished for PR 33778 at commit d143c4c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142600/

Test build #142611 has started for PR 33778 at commit 6a5051c.

Test build #142611 has finished for PR 33778 at commit 6a5051c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47111/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142611/

Test build #142613 has started for PR 33778 at commit 341606c.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47111/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47113/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47111/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47113/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47113/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142613/

Test build #142641 has started for PR 33778 at commit 99aff09.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47142/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47142/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47142/

Test build #142641 has finished for PR 33778 at commit 99aff09.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142641/


Confusion Regarding gtsrb2TT100K result(paper_unseen:71.80)

Hi,I got the following result in the file best_iou.txt for gtsrb2TT100K (main_train_test.py) which doesn't seem to match the reported accuracy in the paper:
( epochs :150)
(1)
Best score epoch:  20
acc cls: 0.6933  acc all: 0.7365  rank mean: 323.6451
acc tr cls: 0.9169  acc te cls: 0.6653(paper:71.80)
top3: 0.9075  top5: 0.9424
(2)
Best score epoch:  37
acc cls: 0.7053  acc all: 0.7339  rank mean: 324.2361
acc tr cls: 0.9201  acc te cls: 0.6785
top3: 0.9254  top5: 0.9473
What should I do to get close to the results of the report. Please help me.

This problem is very important to me. I hope you can help me solve it. Thank you very much.


Add a way to view the last made request to the box (and sub box) objects.

from box import Box

class test(object):
	def __init__(self, **kwargs):
		d = Box({
		'item':'value',
		'item2': self.ok
		})
		self.d = d

	def ok(self, **kwargs):
		print "test"
		print kwargs.keys()
		for key in kwargs.keys():
			print kwargs[key]
		return

data={
	'test':'value',
	'test1':'value1'
}

t = test()
print t.d.item2(**data)

From t.d.item2 how do I get that path while in the 'ok' function.
Thanks!

Not positive what you mean by that path, but if you mean which keys are the parent of the ok function, I would guess the only way is to traverse down to it (like you would have to do for a stadard dict.)
It* might* be possible with how the upcoming box version works to add something that could have a Box object detect if it is a child of another Box. Is that the feature you are asking for?

Yes what you are describing is what I'm looking to do.  The parent child feature should work as long as I can get all the way back to the original key.
Doing so would allow me to create a dynamic endpoint that I can extend by simply changing what's in the dict as all the settings, validation and so on could be pulled in along with the call without having to inconvenience the end user/coder.
Perhaps initiate the box with a parameter to turn this feature on?  track_tree=True
Below is another example.
from box import Box

class API(object):
    def __init__(self, **kwargs):
        endpoints = Box( { 'domains' : {
                'list': {
                    'go': self.build,
                    'path': '{account_id}/domains',
                    'request_type': 'get',
                    'required_fields' : ['username', 'password', 'account_id'],
                    'input_fields': [],
                    'filters': ['name_like', 'registrant_id'],
                    'sorting': ['id', 'name', 'expires_on'],
                    'action': [],
                    'success_status': 200,
                    'success_message': 'Domains listed.',      }  }})
        self.endpoints = endpoints

    def build(self, **kwargs):
        # HERE #
        key_path = 'dotted path for the api.endpoints.domains.list.go(**data) function'.split('.')
        settings = endpoints[key_path[1]][key_path[2]][key_path[3]] #or the endpoints.domains.list key path.
        Do stuff with settings...
        # HERE #
        print kwargs['username']
        print kwargs['password']
        return

data={
    'username':'chavenor',
    'password':'secret'
}

api = API()
print api.endpoints.domains.list.go(**data)

What is your target date for your next release and what can I do to help you get there with this feature?   Money, favors, karma, testing?

I never say no to caffeine, lol, but the big thing is testing (really more just trying it out in other projects / console and see what breaks). I hope to release Tuesday, baring no big issues found from other reviews I will be getting tomorrow. Please poke it as much as you want and add new issues for anything.
To grab latest:
pip install git+https://github.com/cdgriffith/Box.git@development
Super short version of why this might be possible is there is now a semi heritage state by default for the new DefaultBox. (However won't be able to use as is.) So again might (and IMO should) be possible to do something like that.
I'm going to update title of this and propose to add a property to Box (and potentially BoxList if necessary) box_heritage.
Potential usage:
bx = Box(a={"b": {"c": "d"}))

bx.a.b.box_heritage
# "a.b"

Not sure if that use case will work for me as you still needed to add the full path to call the box_heritage to get what you already know.
I'm trying to determine the last request key path made to the box so I could call it in another function almost like a heritage history -- not even sure this is even possible.

Ouh, a last request made. I will move above info to another issue and rename again. Because that, good sir, is also a brilliant idea, and might be possible!

Thanks!   Chris  does<EMAIL_ADDRESS>have a PayPal account attached?  I'll send over that cup-of-joe right away. ;)

I don't any of that set up currently, thanks for the offer though! I'll think of ya over my next Monster 😄

Would usage like this fulfill your need? (Testing in heritage branch, names not final at all. Thinking of maybe .box_last_action)
In [1]: from box import Box

In [2]: hearth = Box.from_json(filename="test//data//hearthstone_cards.json", tracker_box=True)

In [3]: hearth.The_Jade_Lotus.name.frFR
Out[3]: 'Le Lotus de jade'

In [4]: hearth.box_track()
Out[4]: ['The Jade Lotus', 'name', 'frFR']

In [5]: hearth.Corruption.artist
Out[5]: 'Wayne Reynolds'

In [6]: hearth.box_track()
Out[6]: ['Corruption', 'artist']

Perfect!  That should work!   Awesome!

@cdgriffith just wanted to followup with on this.  Is this available in the newest release?
Thanks!

Hi @chavenor sorry for late reply.  It is not in the current 3.0 release, was planing on the next one 3.1.
Doing some testing it seems it may be best for it to be it's own subclass of Box. As the additional logic checks to even figure out if we should store history can make a noticeable difference on large samples.
So ATM I am trying to see how to either cut those times down or if it's better to just be it's own class.

It's own class prob makes the most sense.  Performance is king.   Is there  a branch or tag that this new feature would live in so I don't have to bug ya.  ;)
Thanks!
Casey

Working on it in https://github.com/cdgriffith/Box/tree/heritage branch currently.
Very much a work in progress, (like right now it doesn't work for the first time box_history is called). Please feel free to poke and prod and give feedback. (also not sold on names yet, just easier to spell Tracker than Heritage IMO)
from box import TrackerBox, Box
a = TrackerBox({'a': {'b': {'c': 'd'}}})
a.a.b.c
Out[18]: 'd'
a.box_history()
Out[19]: ['a']
a.a.b.c
Out[20]: 'd'

I'll take a look when I grab some time.  Thanks for you efforts on this.

Hi @chavenor, as an update with the new version of Box 4, it works in an entirely new method that doesn't keep the hierarchy at all anymore, so this is no longer a realistic possibility.
If anyone else is interested in making something like this, it is probably easier to start from UserDict and apply it to that than with Box.


test: add leaf_stage property tests

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#493  👈
#492
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gabriele-0201 and the rest of your teammates on  Graphite

Interesting, I developed them under some logical flaw. What I was thinking is that property testing is similar to fuzzing but with a narrower scope. Thus, I was thinking that the tester should be able to "experiment" with different inputs iteratively until a problem is found. That is also why I am initializing a proper database on which the leaf stage is tested.
It seems to me that what you are requiring as property testing is something closer to unit tests than fuzzing – just a unit test with random input with the shrinking feature.
I think I understood your point, and thank you for the suggestions. What I will try to do now, logically, is initialize just the beatree all in memory (perhaps using tmpfile or memfd) and run on top of it the same tests.
However, before even trying it, I'm skeptical about the feasibility of initializing the beatree without any import from other modules rather than the beatree module. But if that's impossible, I will find some workaround!

notes after edits:

the test focused on range extension is being removed to make tests faster
the number of initial values inside the database has been reduced
on average, 25k leaves are built during the leaf_stage test, and around 3k range request extensions are issued
ln_fd and bbn_fd are now backed by tmpfile. memfd would probably have been faster, but it would not work on macOS
now it is faster than before and does not use 100% of the CPU

io uring with iopoll doesn't work on tmpfiles so a flag has been added to build or not io_uring with iopoll


[WIP] PCM-1558 removing IP address from stats sent to NR

Forgot the changelog. 1 more commit incoming

WIP: looking through and finding any logs referring to fromJid

WIP complete. Only found one instance where we were logging the fromJid.


Set new rate limiting defaults as of April 24 2017

https://www.discogs.com/forum/thread/347984#7300322

For authenticated requests (Discogs Token, OAuth), clients may make 60 requests per minute per source IP. For unauthenticated requests, clients may make 25 requests per minute per source IP.

New rateLimit var as follow:
{ server: 'nginx',
  date: 'Wed, 26 Apr 2017 08:44:02 GMT',
  'content-type': 'application/json',
  'transfer-encoding': 'chunked',
  connection: 'close',
  vary: 'Accept-Encoding',
  'access-control-allow-headers': 'Content-Type, authorization',
  'access-control-allow-methods': 'GET,PUT,POST,DELETE,PATCH',
  'x-discogs-media-type': 'discogs.v2',
  'access-control-allow-origin': '*',
  'x-frame-options': 'SAMEORIGIN',
  'x-xss-protection': '1; mode=block',
  'x-content-type-options': 'nosniff',
  'cache-control': 'public, must-revalidate',
  'content-encoding': 'gzip',
  'strict-transport-security': 'max-age=16000000',
  'x-discogs-ratelimit': '60',
  'x-discogs-ratelimit-used': '2',
  'x-discogs-ratelimit-remaining': '58' }

Quick fix in the 1.2.0 release. Still need to implement this in the es6 branch and figure out if this is the best way to handle a potential mix of authenticated and non-authenticated client instances on the same node instance as they all share the same request queue.

Hey man I'm getting lots of rate error from Discogs when querying more than 60 per minutes, just wondering if this was fixed on the es6 branch? Or maybe there's something I don't do right here...
Please let me know thanks that would really help