Are partial results already possible with Houdini?

Hi @AlecAivazis,
I just discovered this wonderful project. Endless congratulations.
I'm currently using Urql on all projects but as you may know Urql and Svelte don't get along very well (no SSR, broken (Svelte) API and others).
I haven't used Houdini yet (I'll try in the next few hours), but one thing that keeps me from changing is the following and from a quick read it doesn't seem to me that with Houdini you can get it today: I HOPE I AM WRONG.
This is what the world calls: Partial results which Urql obtains with Schema awareness.
This is one of the biggest points in favor of solutions like urql or apollo for me. And that's one of the reasons I really enjoy working with Graphcache (normalized data) and schema awareness. Although it makes everything much heavier (in terms of development and runtime).
The UX show in the hands of the user is that the application looks native and almost offline (if the internet is fast enough). The loading spinners disappear completely and everything seems immediate.
Ultimately that's why I chose to complicate my life by choosing to develop single page apps (SPAs) instead of multi-page (server rendered) apps (MPAs).
A very simple example is the list > detail. As soon as I enter the details I can show the data that I have already shown in the list and download in the background (almost without the person noticing, especially if I do it in the prefetch) the data that did not appear in the list.
I know that you understand what I mean and I also know that it is difficult to understand well how to organize this thing.
Is it already possible today with Houdini?
If you answer me yes, I could pass out with joy... :smile:

Hey @frederikhors! Thank you for the kind words.
At the moment, Houdini can use the cache'd data from a list view to avoid that second network request if possible. Unforunately, it's an all or nothing thing so I'm not sure it fits your use case perfectly. To be concrete, the list view would have to ask for every field that is a part of the details view in order for it to use the cached data. This is described by the CacheOrNetwork policy.
Correct me if I'm wrong but it sounds like the best way to support what you want is by adding another cache policy that doesn't care if all of the data is available. As long as any of it is there we should use that and then send a network request for the rest. Is that accurate? If so, it seems like a great thing to support and wouldn't take more than a few days to get out. At the moment, I am focusing on getting the website going and debugging a recent upgrade to the cache but would gladly shift focus onto this afterwards. If you felt up for it, I would also be open to providing any guidance you need to add the new cache policy.

to avoid that second network request if possible

This is not my primary goal. The main purpose is to ensure that the user immediately has the data that he has already seen in the list a few seconds ago. If you think about it this is very powerful! Because it gives a sensation of speed to the user who does not even notice the existence of a background call for data that is not there. Obviously it depends on the app you are building but 90% of apps are like that.

the best way to support what you want is by adding another cache policy

I don't know if this is the best way. The three current caches seem sufficient to me. You reason this way because you created the caches, but maybe it can be solved differently.

As long as any of it is there we should use that and then send a network request for the rest. Is that accurate?

Yep. And of course you need to have indicators like "isStale", "isFetching", something like that. So I can (if I want to) show indicators of running query.
I think this "feature" is very powerful and could make a lot of people use Houdini.
The concept is well explained here and I am currently using it with Urql: https://formidable.com/open-source/urql/docs/graphcache/schema-awareness/#partial-results.

I think that a good way to help you understand how to solve it can be to create a more complex demo. I can do it myself so I learn Houdini too. But I need a few hours. I will be using StackBlitz with SvelteKit.
And can I ask you something? Do your apps use such a system today? Do you have this need? Imagining a navigation latency of 3 seconds for the API, when you go from a list to a detail do you have spinners spinning? How does it behave? Have you ever wondered this?

I absolutely agree it's a great feature for Houdini. All of the apps I've built with houdini have used CacheAndNetwork policies which doesn't have the support for partial responses, but it would be a very powerful improvement. It's a little unclear if the best move is to have partial results returned with the current cache policies or introduce a new one but I'm sure as the idea sits in the back of my head today I will have a more concrete opinion. I'm trying to think if there's ever a time you dont want partial responses 🤔

I'm trying to think if there's ever a time I wouldn't want partial responses 🤔

BINGO!

@frederikhors now that the cache and homepage work are done, im going to try to get this out relatively soon. Here's how I'm currently thinking each cache policy will handle partial results:

NetworkOnly doesn't need any changes
CacheOrNetwork: if the data is totally available in cache then there's no network call. If the data is partial, the partial value is used and a network request will also be sent. If none of the data is present, a network request will be sent to look up the information. In some sense, CacheOrNetwork behaves like CacheAndNetwork if there are partial results.
CacheAndNetwork: Cache value will be used first regardless of partial or not and then a network request will be sent for the rest.

Does that map well onto the way you think it should work?

and then a network request will be sent for the rest

For all the data, right?
I think it's ok.
Comparing to urql's request policy what are the differences?
Do we miss cache-only?

and then a network request will be sent for the rest

For all the data, right?
I think it's ok.
Comparing to urql's request policy what are the differences? Do we miss their cache-only?

Yea, for now it'll be all data but we can get smarter about that with time.
I'm not against having a CacheOnly policy for completeness. It's one of those things that I probably wouldn't use very often but it doesn't hurt anything to have it.

Or maybe we can use CacheOrNetwork with some "flag".

@frederikhors, I just opened #240 which adds support for partial results by extending the cache policies as I described above. There is still some more testing to do but it should be ready relatively soon.


all: switch fallthrough  bug. Variables scoped outside of switch remain unchanged when modified inside a case block.

When a case statement modifies a variable that is scoped outside a switch statement, the next fallthrough + case statement evaluates the variable as unchanged for the line where the next case is set, but is evaluates as changed within the next case code block. See example code in "What did you do?
What version of Go are you using (go version)?

$ go version
go version go1.20.4 darwin/arm64

Does this issue reproduce with the latest release?
Yes, at the time of writing 1.20.4
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOOS="darwin"
GOARCH="arm64"

What did you do?

func main() {
	F()
}

func F() error {
	var err error
	switch {
	case true:
		fmt.Println("first case statement should execute")
		err = FuncNoError()
		fallthrough
	case err == nil:
		fmt.Println("second case statement should execute")

		// FUNCTION RETURNS AN ERROR
		err = FuncHasError()
		fallthrough
	case err == nil:
		fmt.Println("third case statement SHOULD NOT execute")
		err = FuncNoError()
		fallthrough
	case err != nil:
		fmt.Printf("type of err: %T\n", err)
		return fmt.Errorf("found an error: %w", err)
	}
	return nil
}

// FuncNoError a function that returns no error
func FuncNoError() error {
	return nil
}

// FuncHasError a function that returns an error
func FuncHasError() error {
	return errors.New("FuncHasError")
}

What did you expect to see?

The third case statement case err == nil should evaluate as false skipping the code block.
The fourth case statement case err != nil even though err is nil (according to fmt.Printf("%T", err)) the fourth code block is still executed. So err is remains "nil" when evaluated at the same line as the case statement, but evaluates to not nil when in the case code block.

The output from the code above should be
first case statement should execute
second case statement should execute

What did you see instead?
first case statement should execute
second case statement should execute
third case statement SHOULD NOT execute
type of err: <nil>

working as intended.

I will withdraw. I've only ever used fallthrough with Go.

Having implicit continue not get caught on switches even tho you can continue them (but only with labels) is a way to solve the language compatibility issue but I find that very confusing.
Thx for linking the proposal.


docs: SSH options design

Adding a design for configuring ssh options for mrack's ssh connection
check and Ansible inventory output with main purpose to have the Ansible
inventory settings consumable by Ansible calls used in  pytest-ansible.
Signed-off-by: Petr Vobornik<EMAIL_ADDRESS>

The context of this design looks good to me and well written. Approving


Added support for HTML5 player on Mgtv.

Fixed support for HTML5 player on Youku(Only Chrome);
Added support for HTML5 player on Mgtv(Only Chrome).

currentTime  can not get the right current time.

Fixed in v0.6.0 with different implementation. Thanks for your contribution!


Move semantics?

I was just thinking about how it could be useful to have rvalue overloading and move semantics in this language so that unique_ptr from C++ could be implemented. I know that there's shared-ptr in this language but reference counting has some undesirable overhead at times :)

I think this is a good idea, and should be able to implement something
along the lines of what's in C++ without too much trouble.  (Roughly:
an additional rv-ref parameter type, move-copy and move-assign
operations, a way to specify that certain copy/assign operations
aren't permitted for a given type, and possible subsuming of retvals
within the rv-ref concept.)

Done, except that retvals have been left alone, since there's no compelling reason to change them.  This work helped to tidy up the internals around copying quite a bit, too, so thanks for the suggestion.

That's cool that you implemented it. I will probably give it a spin soon!


implement new feature mindreader 'dumb-mode'

This feature would have mindreader do nothing about managing snapshots or playing around with nodeos RPC or anything.  It would allow this usage:
nodeos | dfuse mindreader

Anyone using this mode would manage everything in nodeos outside of dfuse.

Interesting use case.. and that would just produce 100-blocks logs? Start the gRPC server to output logs too?

The idea is not not control nodeos. Everything else it normally does can stay.
nodeos output that is not for dfuse should be sent to stdout.
The idea is to allow someone (me) who already has infrastructure to deal with nodeos to not touch it as much as possible.

Try it with nodeos | dfuseeos start mindreader-stdin, builds from 'develop' branch starting at b7babe8.
Pretty simple, so should be pretty solid.


Fix: return packages on img list

I have no idea why the previous code stopped working, but this is better because we don't query the db multiple times, so win/win.

/lgtm


Add program record equivalent

https://github.com/bigdatagenomics/adam/issues/1257

Er, whoops! This is a dupe of #114.


support multiple activation annotation types

Revert back to the default activation annotations == the original release annotations. Also support version 2 annotations.

closes #66

Coverage increased (+0.3%) to 79.73% when pulling ae21d614d55654c441d38e20be88029c64905d0c on revert-to-original-activations into 610b3f35e89c59060ca43f7f15503e4c261798a4 on master.

Coverage increased (+0.3%) to 79.73% when pulling ae21d614d55654c441d38e20be88029c64905d0c on revert-to-original-activations into 610b3f35e89c59060ca43f7f15503e4c261798a4 on master.


feat: Add snap support

Description
This adds support for building a snap of stream-sprout. It also adds a workflow to do builds.

Closes #22

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Packaging (updates the packaging)
[ ] Documentation (updates the documentation)

Checklist:

[X] I have performed a self-review of my code
[X] I have tested my code in common scenarios and confirmed there are no regressions
[-] I have added comments to my code, particularly in hard-to-understand sections

'2024-07-23T23:34:06.7129634Z 2024-07-23 23:34:01.096 :: 2024-07-23 23:34:00.677 Cannot pack snap: error: cannot validate snap "stream-sprout": invalid snap version ".399796c": must start with an ASCII alphanumeric (and not '.')'
The build is failing because it's running in a PR with no git tags. I suspect once this is merged, when run in an actual clone of the real repo, the version will work:-
      craftctl set version=$(git describe --tags --abbrev=0).$(git rev-parse --short HEAD)


Algorithm used for consensus?

What does pathfinder use for consensus resolution/decision making?

Pathfinder has no consensus protocol. It does not, in its current form, attempt to address the case of a server suffering a Byzantine failure.
If Pathfinder were to, for example, mitigate the effects of a malicious server, I'm not sure the solution would have to involve a consensus protocol. There's no need reach global agreement, and it seemed like it could reduced to an entirely client library-local affair. I might well be missing something though.

The README mentions "state" usually in a distributed system a consensus algorithm could be used.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1399

Questions ?
Please refer to the Backport tool documentation


⚠ ClamAV has degraded performance

In f6ae5da, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 80 ms

Resolved: ClamAV performance has improved in 6f7143a after 24 minutes.


Render message by default , Could disable MessageTemplate

What issue does this PR address?
#158
#159
Does this PR introduce a breaking change?
Nop
Please check if the PR fulfills these requirements

[x] The commit follows our guidelines
[x] Unit Tests for the changes have been added (for bug fixes / features)

Other information:
Sorry I should have made 2 distinct PR

Merged, thanks for the PR!


Authentication of PeerIds in authority discovery records

This PR adds a proof that the authority controls the key behind the PeerId it advertises to be reachable at.
Closes #8833

Is this ready for review?

Now it is code complete in my view, especially if the CI passes. Where do I need to document the new command-line option?

Can we add a test that the old dht entry is still decodable?

At the moment I have added tests that do not sign the record. The wire format should be the same as the old records. Should I record an encoded record from a test on master and add try to decode it with the current proto definition?

Should I record an encoded record from a test on master and try to decode it with the current proto definition in a test?

Yes that was my idea, but if you are sure that the format is compatible. I'm also okay without any test.

bot merge


Credhub login failure related to CA certs

I am trying to connect to Credhub and seem to get an error around the CA cert being invalid.
credhub api
Error connecting to the targeted API: "Get https://<domain name>>:8844/info: x509: certificate is not valid for any names, but wanted to match <<domain name>>". Please validate your target and retry your request.

if use --skip-tls-validation, i am able to login
credhub api --skip-tls-validation
Setting the target url: https://ci.ap.innogy.com:8844/
Warning: The targeted TLS certificate has not been verified for this connection.
Warning: The --skip-tls-validation flag is deprecated. Please use --ca-cert instead.

This is after exporting all the env vars and they are there. Is there something else to do with this certificate?
While trying to setting-up the credstore values, i am getting below error.
credhub set -n /concourse/***/expo-username -v value -t ***
Get https://<<domain name>>:8844/info: x509: certificate is not valid for any names, but wanted to match <<domain name>>

Anyway to resolve it quickly.

Found similar issue is reported in https://github.com/EngineerBetter/concourse-up/issues/72#issue-372781951

Hello @sureshgoli25 ,
Thanks for reaching out to us.
Let us look into this matter and get back to you as soon as we can.
Best regards,
Eva

Hi @sureshgoli25 ,
May I ask which version of Concourse-Up you were using when encountering the issue?
Was your deployment against AWS or GCP?
Thanks,
Eva

@sureshgoli25 That error isn't the result of the CA being invalid. Instead it appears that the certificate on the credhub is missing your domain from its CN and/or SANs.
You can check what names are in your certificate with openssl s_client -connect ci.ap.innogy.com:8844. Could you post back the (redacted) output of that command?
We generate that certificate with BOSH here so provided you are passing the --domain flag when you deploy I would expect it to be generated correctly.

@crsimmons here is the output
curl https://ci.ap.innogy.com:8844
curl: (60) server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none
More details here: http://curl.haxx.se/docs/sslcerts.html

curl performs SSL certificate verification by default, using a "bundle"
 of Certificate Authority (CA) public keys (CA certs). If the default
 bundle file isn't adequate, you can specify an alternate file
 using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
 the bundle, the certificate verification probably failed due to a
 problem with the certificate (it might be expired, or the name might
 not match the domain name in the URL).
If you'd like to turn off curl's verification of the certificate, use
 the -k (or --insecure) option.
suresh $ curl https://ci.ap.innogy.com:8844 -k
{"error":"invalid_token","error_description":"Full authentication is required to access this resource"}suresh $
suresh $
suresh $ clear
suresh $ openssl s_client -connect ci.ap.innogy.com:8844
CONNECTED(00000003)
depth=0 C = USA, O = Cloud Foundry, CN = <IP_ADDRESS>
verify error:num=20:unable to get local issuer certificate
verify return:1
depth=0 C = USA, O = Cloud Foundry, CN = <IP_ADDRESS>
verify error:num=21:unable to verify the first certificate
verify return:1
---
Certificate chain
 0 s:/C=USA/O=Cloud Foundry/CN=<IP_ADDRESS>
   i:/C=USA/O=Cloud Foundry/CN=ConcourseCA
---
Server certificate
-----BEGIN CERTIFICATE-----
MIIDUjCCAjqgAwIBAgIRAKCFmxINV2S6gMOfeKVtBBgwDQYJKoZIhvcNAQELBQAw
PDEMMAoGA1UEBhMDVVNBMRYwFAYDVQQKEw1DbG91ZCBGb3VuZHJ5MRQwEgYDVQQD
EwtDb25jb3Vyc2VDQTAeFw0xOTAyMjExMjU5NTBaFw0yMDAyMjExMjU5NTBaMD8x
DDAKBgNVBAYTA1VTQTEWMBQGA1UEChMNQ2xvdWQgRm91bmRyeTEXMBUGA1UEAxMO
MTguMTg0LjExOC4xMjcwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQC/
j/QQT95H7ZS5LvFMJpqqT9mubchLc15G05x8L9YaM3/SjCOeDIMusQKeHzWSAp/l
omCtcZ0LC34QMwv2Flgwhn2gq0rmg1vcycH+0xMNIMaTVfX8rUAcNzgImDir94lw
JUVSYWWGnG7KovIIxzPgIILRkAjRZmgd0SqrGTGLtp70IfGuSMyll6JVw2+x/t10
7AR8D6t4/aVIO7+q4bNL19EuK3hq+incAplRsUV4zCID9OBVAzOk2lnekNyuhmrQ
VTT14fLYMPN2A0hQQc5hD8riueb6sxxmKBvbDXb55smlaT34aa3XBp7qZZtAFWOV
MksnPAAydIg6slIw7tglAgMBAAGjTDBKMA4GA1UdDwEB/wQEAwIFoDATBgNVHSUE
DDAKBggrBgEFBQcDATAMBgNVHRMBAf8EAjAAMBUGA1UdEQQOMAyHBBK4dn+HBH8A
AAEwDQYJKoZIhvcNAQELBQADggEBAC386Pt6yE9CAImD3CjJPXq3xhCA3g4YpdZ4
7GhehZL5B3KT5PI2gbuMdNjxboNzW8St7KKzjKKINsMt9lw48qh+0YYpfCrHwBcf
BnqgF6hiq3g2Ia1BSz1apepjCVYOEVWuq8aWMQv2QLzzuet9DZL3tj517IFNgc90
bMikoGFZkHOcxx6SYvffxJgnTXfgt5xY5WtyJJGtNwToqrpvyk+DjVpx36C9Tg/s
Ptu0fkytkUJRjNqAgQF5RRHzCIGJgSwn2vbE1QbZlWFGQHTvQ2w1ua7DwESxpwLl
3KvI4OdWGJXXozWCkjiA77WceFuVR2+d0hwbtWTpLU0zxuhtBe8=
-----END CERTIFICATE-----
subject=/C=USA/O=Cloud Foundry/CN=<IP_ADDRESS>
issuer=/C=USA/O=Cloud Foundry/CN=ConcourseCA
---
No client certificate CA names sent
Peer signing digest: SHA512
Server Temp Key: DH, 4096 bits
---
SSL handshake has read 2300 bytes and written 879 bytes
---
New, TLSv1/SSLv3, Cipher is DHE-RSA-AES128-GCM-SHA256
Server public key is 2048 bit
Secure Renegotiation IS supported
Compression: NONE
Expansion: NONE
No ALPN negotiated
SSL-Session:
    Protocol  : TLSv1.2
    Cipher    : DHE-RSA-AES128-GCM-SHA256
    Session-ID: 5C6FB68830033281139B441DC042487DA0E0F2B5A5332F0DAD0545339FE4E4F6
    Session-ID-ctx:
    Master-Key: C6D0894B2734AEA4FE9E0961D7E114353EC5169BCC3DD39C6D26F065F9F257BFA9D5DE2884B100FB2A81A46CC1350C21
    Key-Arg   : None
    PSK identity: None
    PSK identity hint: None
    SRP username: None
    Start Time:<PHONE_NUMBER>
    Timeout   : 300 (sec)
    Verify return code: 21 (unable to verify the first certificate)
---

@crsimmons @evadinckel
IAAS: AWS,
Concourse-up version: Concourse-Up version 0.20.0
I could see the SAN having only one name which ci.ap.innogy.com that could be the cause of the problem.

Also i would see that the certificate which is generated is valid for only 3 months. I would assume this certificate will be auto-renewed before expiry. Is my assumption is correct?

The certificate is using the EIP of the web vm as the common name. This suggests you didn't pass the --domain flag when you did the concourse-up deploy. What appears in your config.json in S3 for domain?

In config.json it showing "domain":"ci.ap.innogy.com"

Sorry for the delay. We had some unrelated issues on our end.
I'm not sure why the CN is showing as the EIP. We just tried curl https://ci.engineerbetter.com:8844 both with and without -k and got the same messages as you but after running the concourse-up info --env command to export env vars credhub api works as expected.
What command did you use to deploy originally? We will try to reproduce it on Monday.

After speaking with @sureshgoli25 elsewhere we have established that this problem resulted from:

Deploy without specifying a domain concourse-up deploy foo
Deploy again this time specifying a domain concourse-up deploy --domain foo.example.com foo
Observe that certificate on credhub has not been regenerated to have CN/SAN for foo.example.com so credhub login fails.

This happens because that certificate is generated by BOSH then is stored in the director-creds.yml vars store.
Using the ATC IP instead of the domain in the CREDHUB_SERVER env var may work as a temporary solution. We haven't tested this.
A manual solution is to download director-creds.yml from your config bucket, deleting internal_tls, uploading it to the bucket then running concourse-up deploy --domain foo.example.com foo again. We have tested this and it works.

Hi everyone, jumping back to this conversation:
Hello @sureshgoli25,
Thanks again for reaching out to us and for contributing to the growth of our product by sharing your input.
We have made the decision to depriotrise this stream of work of our current workflow and will not focus more engineering effort on this matter; our team will keep the question you have raised         nonetheless if we happen to look further into this in the future.
Please see Colin’s response on how to approach the fix of this issue.
Best regards,
Eva


Nav Controller

As discussed on Gitter

I'm torn...
Should I make the require: "navController" optional, and check for it, or should I assume that https://github.com/ballenjr/generator-mobileangularui/issues/1 will take care of it?
I am thinking that the navController should always be bound. But if that is not agreeable then I will make it an optional check, it shouldn't hurt anything else if it's not bound. What do you think @mcasimir ?
To be clear, I am saying that I am assuming that the tests that fail are using the template from the generator which does not yet have https://github.com/ballenjr/generator-mobileangularui/issues/1 applied.

I have no idea what happened. The I can't get make the PR for your repo. Shouldn't be a big deal though. It's just 2 changes. https://github.com/ballenjr/generator-mobileangularui/issues/1

Current coverage is 76.81% (diff: 20.68%)

Merging #378 into master will decrease coverage by 3.43%

@@             master       #378   diff @@
==========================================
  Files            14         14
  Lines           562        591    +29
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            451        454     +3
- Misses          111        137    +26
  Partials          0          0

Powered by Codecov. Last update 0a8030c...b207c09

Hi @ballenjr, ok sorry to took so long to review your code and thank you very much to share it.
Is still a good point to start but currently the way it is i'd like to reject it, cause i believe we can find together a better approach and solution.
What i'm missing is.. in response to what you want the navbar to show/hide? Depending on the page? It shows and than goes away and that's it? ..
Thanks!

Basically. But I don't limit it to that. You should be able to inject the
controller at will, I think.
On Sep 7, 2016 3:16 PM, "Maurizio Casimirri"<EMAIL_ADDRESS>wrote:

Hi @ballenjr https://github.com/ballenjr, ok sorry to took so long to
review your code and thank you very much to share it.
Is still a good point to start but currently the way it is i'd like to
reject it, cause i believe we can find together a better approach and
solution.
What i'm missing is.. in response to what you want the navbar to
show/hide? Depending on the page? It shows and than goes away and that's
it? ..
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mcasimir/mobile-angular-ui/pull/378#issuecomment-245436885,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADDzgzgKfhpH3TdhuNbJNxPhz9Kc7W1fks5qnzfDgaJpZM4Jx8nS
.

1) easily allow to hide, show the navbars (the slide part is unnecessary cause is better and easier achieved and customized via css)
I can agree with that.
Currently what you achieved with 2 directives could be done with a few css classes. Let's discuss outside the PR.
I don't think this is right though. The styles that fix the navbars are spread among classes at multiple node levels. I didn't really analyze the merit of that approach, because I assumed that there was a good reason for doing it(though I would have preferred if the height of the navbars could have been controlled by the font-size of the the nested copy). So you see in order to "eliminate" the styles at every level the controller has to know of all styles it is responsible for.
Now I did, at one time, use a hacky css override like, I am assuming, you suggest. But that, of course, made it unnecessarily cumbersome to switch between states when the view state changes.
This is much more versatile.

https://github.com/mcasimir/mobile-angular-ui/issues/359
Another example of why you would want to have an all knowing controller. Orientation changes.


Errors suppressed on react Component when imported by a lib

Here is a minimal repository with the bug: https://github.com/ckknight/flow-libs-bug
On line 6 of src/App.js, this.props.nonexistent() is called, which should be a type error.
By having the following lines in .flowconfig:
[libs]
flowlib/

and a file within that folder:
// @flow

import { Component } from 'react';

declare module 'foo' {
  declare module.exports: any;
}

Regardless of whether foo is referenced anywhere else, the import { Component } from 'react'; line causes flow to view Component as any within unrelated code.

@sibelius Sorry, I'm unclear as to whether imports outside of module declarations are supported or not?

https://github.com/flowtype/flow-typed/issues/2023
https://github.com/flowtype/flow-typed/issues/1857
https://github.com/flowtype/flow-typed/issues/1857#issuecomment-371312890

@sibelius sure it should be import type { Component } from 'react'. Instead, my errors were completely swallowed with zero indication that there was a problem. That's the real issue.

Closing in favour of the referenced issues


Revert "Update README.md"

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command
Environment to preview

/qovery  preview f26b853a-546c-42de-b9d6-cf115028aa3a
test

/qovery  preview all
For all above environments

This comment has been generated from Qovery AI :robot:.
Below, a word from its wisdom :

Write comments that add new information that doesn’t exist in the code

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
:point_right: [PR] test - Revert "Update README.md" - 2023-05-15T12:28:50Z
Another comment will be posted when deployments are terminated

/qovery preview all

/qovery preview all

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
:point_right: [PR] test - Revert "Update README.md" - 2023-05-15T12:31:01Z
Another comment will be posted when deployments are terminated

Your preview environment has been successfully deployed !
Click on the link below to open your service:
:point_right: front-end
:point_right: gitpod

/qovery preview f26b853a-546c-42de-b9d6-cf115028aa3a

Your preview environment failed to be deployed !
Click on the link below to check the deployment logs.
:point_right: [PR] test - Revert "Update README.md" - 2023-05-15T13:52:41Z


Offline Arcade v0.18.14: Importing a project with extensions locks the app in loading state

Describe the bug
When running the Arcade electron app offline and importing a project that makes use of extensions, the app will be forever stuck on the loading screen.
To Reproduce
Steps to reproduce the behavior:
0. Install the app and then go offline. Download here: https://makecode.com/api/release/arcade/v0.18.14/win64

Import a project that utilizes extensions (a candidate project is attached for convenience)
Notice you're stuck at the loading screen.

Expected behavior
I expect the import would fail gracefully (with an informative error message) and go back to the home screen.

@eanders-MS did you have the specific project you attempted to load? It was mentioned in the issue but I don't see it right away. I just tried with the game from https://forum.makecode.com/t/arcade-advanced-stream-63-haber-dash/2718 (which has several extensions / both approved and unapproved) and it gave the default oops, something went wrong message for failing to load a project

Closing for now until we have  a repro. Please reopen if you find a repro.


Associating a group or a permission on user registration

Is it possible to choose, in the registration endpoint, which group or which permission associate to the user which is being created?
(Related to https://github.com/Tivix/django-rest-auth/issues/587)

Have you looked at doing this in a signal?
All Auth Signals:
https://django-allauth.readthedocs.io/en/latest/signals.html
Django User Signal:
https://docs.djangoproject.com/en/3.0/ref/signals/

I'm going to close this for now since it's a little out of scope.

I'm gonna check, thank you.


Mouse input not being sent to applications (eg vim)

Environment
Windows build number: 10.0.19041.0
Windows Terminal version (if applicable): 1.2.2381.0

Any other software? No

Steps to reproduce

Launch "vim" in Powershell
Enter :set mouse=a
Try clicking with mouse, cursor does not respond
(Repeat with other shells in wt: Close Powershell, repeat with vim on cmd, vim on git-bash)
(Repeat with Git Bash outside wt: open Git Bash, and observe that set mouse=a DOES allow mouse interaction with vim)

Expected behavior
The blog article about v0.10 (https://devblogs.microsoft.com/commandline/windows-terminal-preview-v0-10-release/) says that mouse support was added, but I'm able to exercise that functionality. I expect to be able to move the text cursor in vim, but I'm unable to.
Actual behavior
When I click the mouse in vim, the mouse clicks are not transmitted.
Thanks for your help!

Mouse support was added for WSL applications, but unfortunately there's still a bit of work to do to enable mouse input for Win32 applications (like vim.exe)
For more info, I'd check out: /dup #376
Thanks!


mouse mech

Description
vim from /tg/ REQUIRED
Piep!
i will do this if/when done with honk

If this is a feature request/suggestion please provide a link/screenshots and description of the feature and why you want it in the game otherwise this is just ideaguys but in a gh issue


Update tests to support latest torchmetrics

Outline & Motivation
Some of our tests are failing with the latest torchmetrics version 0.11.x:
tests/tests_pytorch/core/test_metric_result_integration.py:573: in <module>
    @pytest.mark.parametrize("log_val", [torch.tensor(0.5), torchmetrics.Accuracy()])
E   TypeError: Accuracy.__new__() missing 1 required positional argument: 'task'

Pitch
Add the required "task" argument in our tests.
Additional context
pytorch-lightning==1.9.1
torch==1.13.1
torchmetrics==0.11.1

cc @justusschock @awaelchli @borda

Completed in #15904


Don't consume async when checking for async func decl

As reported in https://github.com/babel/babel/issues/5366.

Isn't this the exact same thing as the just reverted commit? This would reintroduce the problem. The problem is that babel can't handle the new AST.

Oh I see this is about arrow functions. Before we merge this we need to fix babel first to understand the AST.

If necessary we can backport to 6.x


Use unaltered Xcode in CI on macOS 13

Apparently in macOS 13.5.1, you can't alter the Xcode package, otherwise it becomes "damaged".
Update recipes to use "infra_internal" Xcode CIPD packages on macOS 13, which will fix https://github.com/flutter/flutter/issues/133458 and https://github.com/flutter/flutter/issues/133461
Issues

[x] https://github.com/flutter/flutter/issues/134740
[ ] https://github.com/flutter/flutter/issues/135620

CL is merged in: https://flutter-review.googlesource.com/c/recipes/+/51340?tab=checks


build fails when --clean=false is set

I'm not sure, if --clean=false still should be doing something. In the past it helped speeding up the builds. In any case it shouldn't make the build fail, i think.
https://github.com/PieLabs/corespring-text-entry-ng15
First you have to run it with clean=true, then with false
pie pack-question --buildExample --keepBuildAssets --clean=true
pie pack-question --buildExample --keepBuildAssets --clean=false

This isn't a pie-cli issue - it's an issue with that pie package.  There is something funky going on with those dependencies which  you'll need to sort that out first.
As soon as I remove that dependency the install works.
pie pack-question --buildExample --keepBuildAssets --clean=true
pie pack-question --buildExample --keepBuildAssets --clean=false #-> fails
cd controllers
npm install #-> also fails - this proves that it's an issue with the npm install.

I've checked the npm install  - actually it is not failing, it reports an error for an optional dependency. Not sure, if pie-cli should fail with an error here. See the error message below
npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
error: [npm-dir]   npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>error: [npm-dir]   npm ERR! code 1
error: [npm-dir]   install failed. code: 1

I think, i found the issue.
The package.json in the controllers directory has a dependency
"corespring-text-entry-ng15": "../node_modules/corespring-text-entry-ng15/controller",
I think that should be
"corespring-text-entry-ng15-controller": "../node_modules/corespring-text-entry-ng15/controller",

problem is fixed in the branch 57-controller-name


Deleting a file does not delete from fs.files

I exectuted the cURL command to delete a file,
the file got deleted,fs.chunks holds nothing now but fs.files still contains it details with length parameter now 0 but still holds some space and objectId that holds nothing.
1)The cURL command--->
curl -X DELETE
-H "X-Parse-Application-Id: myAppId"
-H "X-Parse-Master-Key: qwerty"
http://localhost:1337/parse/files/c6706c53593d442d482b780713858026_hello2.txt
2)The mongo shell output--->
db.fs.files.find()
{ "_id" : ObjectId("56c717b40acd97bd096bd832"), "filename" : "c6706c53593d442d482b780713858026_hello2.txt", "contentType" : "binary/octet-stream", "length" : 0, "chunkSize" : 261120, "uploadDate" : ISODate("2016-02-19T13:27:54.045Z"), "aliases" : null, "metadata" : null, "md5" : "d41d8cd98f00b204e9800998ecf8427e" }
{ "_id" : ObjectId("56c7177e0acd97bd096bd830"), "filename" : "a3a99e03d3bc411fb9925c1d81e96c60_hello.txt", "contentType" : "binary/octet-stream", "length" : 0, "chunkSize" : 261120, "uploadDate" : ISODate("2016-02-19T13:29:44.287Z"), "aliases" : null, "metadata" : null, "md5" : "d41d8cd98f00b204e9800998ecf8427e" }
even tough db.fs.chunks.find() returns nothing

Seems to be unrelated to Parse Server.  We use the proper GridStore method for removing a file from what I can see... There's no option for us to remove just the chunks or leave the reference in fs.files.

Then how can i remove those references?
By directly using Mongodb api? @gfosco


fix perSecond null handling, use explicit integer division

As reported in #2028 there is an issue with how null values are handled in perSecond, it doubles the step value for every null encountered instead of incrementing it by the series step.  This has been corrected and the test suite has been updated to test the scenario where multiple null values are encountered.
While debugging this issue I saw that there are many places in functions.py including in perSecond where the code is reliant on the non-intuitive Python 2.3-2.7 behavior where the division operator / performs integer/floor division if both arguments are integers and regular division if one or more are floats.
See https://www.python.org/dev/peps/pep-0238/ for a discussion of division in Python and the changes introduced in 2.3 and in 3.0.
To both make it clearer in the code which type of division is being used and to bring us closer to 3.x compatibility, I added from __future__ import division and converted all instances of integer division in functions.py to use //.

Codecov Report

Merging #2029 into master will increase coverage by <.01%.
The diff coverage is 96.42%.

@@            Coverage Diff            @@
##           master   #2029      +/-   ##
=========================================
+ Coverage    69.5%   69.5%   +<.01%
=========================================
  Files          71      71
  Lines        7011    7012       +1
  Branches     1372    1372
=========================================
+ Hits         4873    4874       +1
  Misses       1890    1890
  Partials      248     248

Impacted Files
Coverage Δ

webapp/graphite/render/functions.py
89.69% <96.42%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de60c9...9fb53b9. Read the comment docs.

👍 LGTM
Thanks!


Add support for Athena

Hi,
Is Athena in the pipeline to be added as a Supported Databases?
Regards Johan

Hi @johanjvrens ,
Athena is currently not considered a high priority, but we might implement it if the demand is high  (please vote 👍🏼 for feature requests).
However, contributions are very welcome! If you'd like to try, we'll be happy to help you in the process.

Would love to know more about how to get this going, we're possibly open to taking it on

Hi @niger-prequel , that's great to hear.
To get started, read these:

https://github.com/datafold/data-diff/blob/master/CONTRIBUTING.md

https://data-diff.readthedocs.io/en/latest/new-database-driver-guide.html

Also, ideally you would add Athena to docker-compose.yml, so that  docker-compose up athena would set it up to pass the tests.
If you have any questions, or need advice, feel free to ask!

+1

+1


Fix type errors, decrease timeout, and handle files properly

Description:
Solves #11983 while merging #11942 into existing fixes.
Fixes type errors introduced with shared state object, decreases the timeout before the state object grabs new data from the controller, and integrated file handling fixes.
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

This PR seems to gone stale. Please re-open it when you want to proceed.

@fabaff 👋 - I've just made your suggested changes, trying to figure out how to test this and get things back up and running. any pointers appreciated.
https://github.com/dfiel/greenwavereality/pull/3

@fabaff bump


Fix soft-dependency on Vault

Currently, DecoHeads will error if Vault is not available, as the Vault API is not available in the classpath. A quick adapter wrapper class should solve this.

Patched in (7eb4d11f16bc9b9e8a0f5cb015ad733b947ece75).


Node time check before start

Compare the node time with relay time, and show notification to user in case the time is different

To enhance privacy particularly when needing to share logs, would it be better to convert system clock in the node log to UTC time zone.


Multimethods for array manipulation routines

This pull request intends to expand unumpy's coverage of array manipulation routines. I'll name the multimethods covered in this first part of the PR according to the NumPy docs sectioning:
Basic operations

copyto

Changing number of dimensions

expand_dims
squeeze

Changing kind of array

asfarray
asfortranarray
asarray_chkfinite
require

Joining arrays

dstack

Splitting arrays

split
array_split
dsplit
hsplit
vsplit

Some observations:

I've excluded asscalar from these additions since it's deprecated (check the docs).
The class broadcast is also not included and maybe it needs to wait for the metaclass PR.
The argument replacer that I first used for asfarray, asfortranarray and asarray_chkfinite was _self_dtype_argreplacer but due to some failing test in the Sparse backend I changed it to _dtype_argreplacer (this fix is similar to https://github.com/Quansight-Labs/unumpy/pull/59/commits/f036706e3dee72ceb126bccc2452014bf643c284).
copyto was failing in the XND backend with a uarray.BackendNotImplementedError so I added an exception.
I'm working on a default implementation for array_split with respect to split. Here is the prototype:

def _array_split_default(ary, indices_or_sections, axis=0):
    if isinstance(indices_or_sections, int):
        dim = ary.shape[axis]
        sizes = [dim // indices_or_sections + 1 for _ in range(dim % indices_or_sections)]
        while sum(sizes) < dim:
            sizes.append(dim // indices_or_sections)
        indices_or_sections = cumsum(sizes)

    return split(ary, indices_or_sections, axis=axis)

Note: These multimethods represent the 1st part of this pull request as it should last around 2 weeks since I'll be adding more of these routines later.

asarray_chkfinite is failing locally with a segmentation fault. I tried to change the argument replacer with _self_dtype_argreplacer but it fails in a slightly similar way (segfault also).

Is this the error you're seeing?
     def __bool__(self):
        if self.size > 1:
            raise ValueError(
                "The truth value of a {0} is ambiguous. "
                "Use a.any() or a.all().".format(self.__class__.__name__)
            )
        else:
>           return bool(self.compute())
E           ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

In that case, it looks like a dask bug. How can the truth value be ambiguous because of more than one element, if we're in the self.size <= 1 branch? I will look into it a bit further and see if it should be reported to dask.
I also tried with _self_dtype_argreplacer and couldn't reproduce the segfault.

This is quite strange, it only seems to happen with unumpy.asarray:
In [29]: np.all(np.isfinite(da.asarray([1, 2, 3]))).compute()
Out[29]: True

In [30]: np.all(np.isfinite(np.asarray([1, 2, 3]))).compute()
Out[30]: array([ True,  True,  True])

Is this the error you're seeing?
     def __bool__(self):
        if self.size > 1:
            raise ValueError(
                "The truth value of a {0} is ambiguous. "
                "Use a.any() or a.all().".format(self.__class__.__name__)
            )
        else:
>           return bool(self.compute())
E           ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

Yes, that's what happens when I use _dtype_argreplacer.

I also tried with _self_dtype_argreplacer and couldn't reproduce the segfault.

Does it pass the tests then? For me it fails in the Sparse backend with the following error:
        assert isinstance(ret, types)

        if isinstance(ret, da.Array):
            ret.compute()
        if XndBackend is not None and backend == XndBackend:
            assert ret.dtype == ndt(dtype)
        else:
>           assert ret.dtype == dtype
E           AssertionError: assert dtype('int64') == 'float64'
E             +dtype('int64')
E             -'float64'

The segfault seems to happen after the tests have completed.

The sparse backend did fail for me with the same error, but I don't get any segfaults.

The CI failure is just the segfault.

The CI failure is just the segfault.

The segfaults started when the custom tests for copyto were added. I tried commenting out those tests and the segfault disappeared. I also tried just running those tests using pytest -k test_copyto which also makes it disappear which is strange.

The last commit adds the following multimethods:
Tiling arrays

tile
repeat

Adding and removing elements

delete
insert
append
resize
trim_zeros

Rearranging elements

flip
fliplr
flipud
reshape
roll
rot90

A few notes for later discussion:

I've implemented the default for tile with respect to concatenate. Not sure if this was the best choice but it seemed right. Maybe repeat could also be used.
Not sure if some multimethods like tile and repeat need to have some of their arguments marked as non-coercible (looking at reps and repeats).
In trim_zeros the input data type is preserved (check the docs) so filt should also be marked as non-coercible.
I'm pushing the multimethods before attempting to fix the failing tests so that you can also see them in the CLI.
I will attempt to add more default implementations. Some of them like flip and roll could be nice but they don't seem trivial.

@peterbell10 Thank you!

I think this PR is mostly done. Only thing left is to fix the failing tests which I need help with. Here are some notes:

Both insert and flip methods have a required argument axis in the Dask backend. This differs from NumPy where this argument is optional. Should I just pass an axis kwarg in the tests?
_tile_default fails in the Sparse backend because an int is assigned to reps which is then converted to an empty SparseArray instead of a one-element array.

In [3]: sparse.as_coo(onp.asarray(2))
Out[3]: <COO: shape=(), dtype=int64, nnz=1, fill_value=0>

It seems that Dask's repeat explicitly needs an axis for arrays with more than 1  dimension contrary to the docs.

In [3]: a = da.from_array(onp.eye(2))

In [4]: da.repeat(a, 2)
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)
<ipython-input-4-dd1538523a91> in <module>
----> 1 da.repeat(a, 2)

~/miniconda3/envs/unumpy/lib/python3.7/site-packages/dask/array/creation.py in repeat(a, repeats, axis)
    754             axis = 0
    755         else:
--> 756             raise NotImplementedError("Must supply an integer axis value")
    757
    758     if not isinstance(repeats, Integral):

NotImplementedError: Must supply an integer axis value

_delete_default and _trim_zeros_default seem to be failing because of indexing in the Dask backend.
I'm not sure on how to fix the segfaults regarding copyto.
I don't understand what mypy is but it's failing twice. 😅

Both insert and flip methods have a required argument axis in the Dask backend. This differs from NumPy where this argument is optional. Should I just pass an axis kwarg in the tests?

Yes, that seems best.

2. _tile_default fails in the Sparse backend because an int is assigned to reps which is then converted to an empty SparseArray instead of a one-element array.

Change sparse.asarray to do the following, more or less (psuedocode):
if not isinstance(a, sparse.SparseArray):
    return sparse.COO(onp.asarray(...), ...)
else:
    return x

It seems that Dask's repeat explicitly needs an axis for arrays with more than 1  dimension contrary to the docs.

Modify the tests here too.

_delete_default and _trim_zeros_default seem to be failing because of indexing in the Dask backend.

Ahh, I see. Yes, make a zeros(..., dtype="bool"), a ones, and another zeros, concatenate them, and use that as the mask.

5. I'm not sure on how to fix the segfaults regarding copyto.

Skip for now.

6. I don't understand what mypy is but it's failing twice.

It's a type checker, we'll get to it last.

There's a problem with trim_zeros in the Dask backend where the resulting array from nonzero has unknown chunk sizes indicated by its (nan,) shape. As it is stated here, this causes that operations like indexing are not possible and will result in an error. The solution could be to just remove _trim_zeros_default since using compute_chunk_sizes() might not be possible.

I would skip the test here instead of removing the default. Or adding an implementation for Dask in the Dask backend.

Do we still need to do more here? If not, please mark this as ready for review.

This should be ready to merge now!


Bug introduced with the addition of the euro sign

Try writing with caps lock on, while holding Alt Gr. The e key ignores the caps lock.

Hi, I normally never use caps lock and have it switched off but now I tested and it seems to work as expected for me: when caps lock is on and Alt Gr is pressed the "e" key produces capital "E". Together with shift it produces "€". I'm running Ubuntu 16.4.

Yes, I get a lowercase "e". I'm on Fedora 28, gnome shell. I have little experience with this, therefore I don't know if there are any logs that you may find useful.

Could you please make sure you have installed the last commit and activated it? Just git pull, run the install.sh and then setxkbmap -layout cz -variant cz_programmer. If the problem persists please create a source file of your current configuration by running xkbcomp -xkb $DISPLAY xkbmap and send me the resulting xkbmap file.

In case you wanted to hack a bit and try to find the solution yourself An Unreliable Guide to XKB Configuration is the best resource on xkb I know of.

The problem does persist (I was already at the newest commit). The kxbmap file is attached below:
xkbmap.txt

I can confirm to see the behavior you describe but the structure of your xkb file is quite different than what I'm used to in Debian and I don't know how to fix it right now. For the time being you can try to use this xkb map:
cz_programmer.txt
To set it, use xkbcomp cz_programmer.txt $DISPLAY

Maybe even better: install GNOME Tweak Tool and in section 'Typing' and 'Caps Lock key behavior' select 'Caps Lock uses internal capitalization; Shift "pauses" Caps Lock'.

Internal capitalization did the trick. I have no idea why, but thank you.


Issues and suggestions

Thanks for the recent developments, @liamhuber. I could successfully install and run ironflow on my local computer. The response time of the GUI is now fantastic. It doesn’t feel like any further performance optimization is needed.
When running ironflow I encountered a few issues. Probably you are already aware of them. Nevertheless, a list of the ones I encountered is appended below:

ironflow crashes without an error message, often related to clicking on show
the job output etc. exists only when running the job from scratch. Reloading appears to be not working. Also deleting does not remove the jobs. I had to do this manually by creating a project object in the jupyter notebook.
Extending the AtomisticOutput node to include transpose and get a specific item would be convenient and simplify the workflow construction. Based on your examples it looks like these options are very frequenly needed. This could be  easily achieved by adding to input elements in the node (a boolean one for transpose and an integer one for the index).

The response time of the GUI is now fantastic. It doesn’t feel like any further performance optimization is needed.

Super! I anticipate for graphs with many ontologically-empowered nodes, making new node connections will be slow, but certainly for the sizes of graph we're playing with now it also feels fast to me.

ironflow crashes without an error message, often related to clicking on show

I run into this ~1/day when I'm working on ironflow, but have yet to find a situation where the error is consistently and reproducible. I think it is related to my cleanup of orphaned ipywidgets widgets, but absent a way to consistently produce the error I've avoided dealing with it. Please let me know if you run into a situation which causes this bug in a reliable way! Otherwise it's on my radar but not the highest priority.

the job output etc. exists only when running the job from scratch. Reloading appears to be not working. Also deleting does not remove the jobs. I had to do this manually by creating a project object in the jupyter notebook.

I wouldn't quite describe this as a "feature not a bug", but it's pretty close... In the near-term I hope to avoid job creation entirely (e.g. with pyiron_lammps), so I have no imminent plan to fix this.
A helpful snippet instead of creating a project is just to select the project node and use gui.selected_node.outputs.values.project.remove_jobs(silently=True, recursive=True).

Extending the AtomisticOutput node to include transpose and get a specific item...

Good idea!

Thanks for your prompt reply. Concerning the issue with ironflow crashing. I somehow manage to crash it after a few clicks. I found a reproducible way to crash it. The list of steps below:

open the example notebook and open the gun
click show on project
click on jobtable in the output window
click again on jobtable to deactivate table
click on show in the project node

The last click crashes ironflow reproducibly. In my example, the jobtable shows only a single job. I hope this helps and you can reproduce the error.


[BUG] Embed the h5 page in the Android client, click the client's physical return to close the page and then open the im page. After repeating this several times, it is found that the client memory is full and the page crashes.

OpenIM Server Version
3.5.2
Operating System and CPU Architecture
Linux (AMD)
Deployment Method
Docker Deployment
Bug Description and Steps to Reproduce
1、以h5页面嵌入在android客户端。
2、点击客户端物理返回关闭页面后再打开im的页面。
3、按照1、2的步骤这么重复几次
4、发现客户端内存爆了闪退
Screenshots Link
No response

Is it possible to analyze what is taking up the memory?

因为点击物理返回键后，android的webview是直接finish的，我们没有做im的logout的操作，而每次打开webview的时候都重新执行IMSDK.login，以为是这个原因导致了内存爆了。所以我尝试了先logout，再finish webview，但是多次操作又发现提示"wasm exist already fail to run -- event: getloginstatus "

When an error occurs, you can collect detailed client logs.
The SDK core logs will be printed here.

多次登录后头这个提示，之后再登录初始化，就一直报这个错，初始化不成功

这个是打印出来的日志

以上是日志的截图

It looks like a memory leak caused the crash. Is it because your webview does not recycle memory correctly when closing?


Bug: Costs calculation is wrong if instance type is missing in AWS region

Hi,
Wasn't able to find related issue, decided to create new one.
Issue is not critical I think, but quite misleading.
Basically, when instance is not available in particular AWS region, terraform shows it anyway in the plan and based on that plan, infracost calculates costs change. In the end, since this type of instance is not available in the region, I guess infracost estimates it to 0, which causes diff output equal to removal of instances, not type change.
To reproduce it, you can try to create new state or change existing in Frankfurt (eu-central-1) region with instance type x2gd, which is not available in Frankfurt.
In case of instance change, infracost output looks like this
    ~ Instance usage (Linux/UNIX, on-demand, r6g.2xlarge → x2gd.2xlarge)
      -$355 ($355 → $0.00)

Infracost v0.10.39, terraform v1.8.5, aws provider 5.62.0

@nantiferov thanks for reporting this! Just to double check, can you please re-run your diff command with --log-level=debug and see if you see warnings about missing prices? I guess a better output would be to show a warning for that but don't classify that case as removal. Any other thoughts on what output you'd like to see?

Hi,
Yep, I see this in the very beginning: WARN 2 aws_instance prices missing across 2 resources.
But in the end I see positive news 😅 and this WARN just missed unless I scroll up.
Infracost estimate: Monthly estimate decreased by $134 ↓
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Changed project                                                  ┃ Baseline cost ┃ Usage cost* ┃ Total change ┃
┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━╋━━━━━━━━━━━━━━┫
┃ path-to-the-plan.json ┃         -$134 ┃           - ┃  -$134 (-4%) ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━┻━━━━━━━━━━━━━━┛

Any other thoughts on what output you'd like to see?

I think it would be better to show some big warning in the end that results might be incorrect/incomplete due to missing prices.
As I mentioned initially, this bug is not super critical, but might bring some false hopes that it's possible to cut ~100% of costs switching to non-existing instances)))


[xxx] Add other to gender code mapping

Context
Apply has changed one of their radio button values on the gender/sex question for E&D from intersex to other. This is not currently handled by Register's mapping when creating trainees from Apply. Old values are not being updated so there will be both intersex and other values.
Changes proposed in this pull request

Add 'other' key-value pair to mapping

Guidance to review
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

@JonF1 do we still need the intersex mapping? If we do, should we have a comment why it's still there? Will we need it forever?

@JonF1 do we still need the intersex mapping? If we do, should we have a comment why it's still there? Will we need it forever?

@edwardhorsford I can add one, you could lose the mapping when it is no longer possible to get intersex from Apply. So, next recruitment cycle? i.e 2024. It's needed because candidates could be deferred with the old intersex value and they haven't been forced to go through the E&D flow with the updated questions/values.


How to

Instructions on where to get / how to install this plugin would be helpful.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83ff08bd-922a-f9a7-3db3-d40c59072549
Version Independent ID: 32afc780-f1a7-7ff6-c5f6-2686781e0931
Content: Open entity data in Excel - PowerApps
Content Source: powerapps-docs/maker/common-data-service/data-platform-excel-addin.md
Service: powerapps
GitHub Login: @lancedMicrosoft
Microsoft Alias: lanced

I have added link to Excel add-in (https://appsource.microsoft.com/en-us/product/office/WA104380330?tab=Overview) and link to Add or remove add-ins in Excel (https://support.office.com/en-us/article/add-or-remove-add-ins-in-excel-0af570c4-5cf3-4fa9-9b88-403625a0b460). Will be published in a few days.

Closing issue.

Closing issue.


Make _nextI18Next optional for<EMAIL_ADDRESS>fixes #1944

This change is to allow compatibility for<EMAIL_ADDRESS>fixes #1944

Checklist

[x] only relevant code is changed (make a diff before you submit the PR)
[ ] run tests npm run test
[ ] tests are included
[x] commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

[ ] only relevant documentation part is changed (make a diff before you submit the PR)
[ ] motivation/reason is provided
[ ] commit message and code follows the Developer's Certification of Origin

https://github.com/i18next/next-i18next/issues/1944#issuecomment-1243686022


Add SetGwPosition and GetGwPosition to game world objects

game world objects should have the ability to set and retrieve their GameWorldPosition as a Point2D

GWObjects no longer exist


Auto feature cleanup

@karlnapf working on a cleaner API for automatic parameter initialisation with @vigsterkr. This could then be eventually exposed to the interfaces.
However this fails SGObjectAll_unittest.cc because now the refcount of this is 2, instead of 1, since it is referenced inside AutoInit.

Re the failing unit test, just remove the line that asserts the ref count

Its pretty standard to define static vars with camelcase and prefix it with k

On 20 Feb 2019, at 14:07, Heiko Strathmann<EMAIL_ADDRESS>wrote:
Re the failing unit test, just remove the line that asserts the ref count
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I never saw it in shogun, but I also don't really mind either way.

Yeah we dont really use these standard notations... but maybe it’s time to change it... especially that as you can see this is not exposed to anything.

On 20 Feb 2019, at 14:29, Heiko Strathmann<EMAIL_ADDRESS>wrote:
I never saw it in shogun, but I also don't really mind either way.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

We could use std::weak_ptr within the autoinit class for storing reference to the kernel and not increment the ref counter of kernel...

On 20 Feb 2019, at 15:29, Heiko Strathmann<EMAIL_ADDRESS>wrote:
I never saw it in shogun, but I also don't really mind either way.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

need to fix the legacy code?

What do you mean?

The python tests failed when they use the kernel constructor with features (as opposed to the factories)

Ah. Yes pls fix them, still dragging those along for coverage.... but maybe not first thing but only before merging the feature branch into develop


uploading failed while dealing with empty file

Hi,
Currently I am using smart_open library.But I am facing an issue related with empty file .while it is working well with any file but when I deal with any empty file it throws me exceptions
Like
raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (AccessDenied) when calling the PutObject operation: Access Denied
can you please Help me out how can I Deal with empty file in smart_open

Here is the snippet ,where in one file I have some data in test2 ,but in test1 we dont have any data ,so in test1 to upload it to s3 it gives me botocore.exception

From the screenshots you are posting, the operation is failing because of an "Access Denied" error.
I can confirm that writing empty files to S3 works with smart_open 3.8.2 and the below code:
(smart_open) misha@cabron:~/git/smart_open$ ipython
Python 3.6.5 (default, Apr  1 2018, 05:46:30)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.0.1 -- An enhanced Interactive Python. Type '?' for help.

In [1]: from smart_open import open

In [2]: with open('s3://bucket/test_smart_open/empty', 'w') as fout:
   ...:     pass

In [3]: with open('s3://bucket/test_smart_open/empty', 'r') as fin:
   ...:     print(repr(fin.read()))
''

What version of smart_open are you using?

How do  know smart_open version?
can you please help me out

Run pip show smart-open

Hi I am facing issue related with empty file,during uploading from hdfs to s3 .whenever I upload any non empty file its uploaded successfully on s3 ,but once I deal with any empty file it gives me exception like
raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (AccessDenied) when calling the PutObject operation: Access Denied
and also can you just help me out with smart_open version? How can I know about it using cli
an also I have used code as its snippet is
for line in smart_open(hdfs_path, encoding='utf8'):
#with open(my_file) as friendsfile:
if not line:
logging.info('Writing lines into "s3://car-test-s3-consumptionbucket/test.csv"....')
fout.write(line)
#print('friendsfile is empty !!')
else:
#print(" file is not empty!!!")
continue

I've tried to reproduce the problem on my end, unsuccessfully (see my first comment). I'd like to help you, but your recent comment provides absolutely no new information to me.
In order for me to be able to help you, I need to know more information:

The smart_open version (see my reply above for methods of getting it)
A full stack trace (copy paste). You've provided me some screenshots, but they aren't helpful (one of them is a Java stack trace completely unrelated to smart_open).
A reproducible example of the problem code. Ideally, this should be something I can simply run on my side to reproduce the problem. Make this sample as small as possible: remove all irrelevant parts. In your case, reading from HDFS is likely unrelated. For an example, see my first comment.

As a side question, does the following work for you?
from smart_open import open
with open('s3://bucket/test_smart_open/empty', 'w') as fout:
     pass  # write empty file
with open('s3://bucket/test_smart_open/empty', 'r') as fin:
     print(repr(fin.read()))  # read empty file back

(obviously, replace bucket with your actual S3 bucket name).

smart_open version i s
1.8.0
here is the code snip

Try installing the newest version of smart_open (1.8.2).
Alternatively, try from smart_open import smart_open as open instead.

Yes it works for me thanks but after running this code I got output as a
u' '
what is meaning of this output ?
and here is the code
from smart_open import smart_open as open
hdfs_path='hdfs://user/mohitm/sagar/test1.csv'
with open(hdfs_path, 'r') as fin:
print(repr(fin.read()))

From this discussion, it is obvious to me that there is no bug in this case, so I'm closing the ticket.
If you have further questions, then the more appropriate place to ask them is stackoverflow.com.


Clarify Documentation Regarding Offline Usage

This issue was extracted from a follow-up comment on #1183 by @phaser82:

Hello, I've been running in a similar bug related to switch between offline and online use of my app. Now I've understand what's behind this fix which I can confirm it actually works. Thanks.
Anyway I think I'm missing something regarding how to manage completely offline/online use.
Maybe someone could point me out on the best solution.
More specifically...I can divide my case in three situation - Scenario of "creating new object":
Always Online: using the mainQueueManagedObjectContext after a postObject everything works fine. My object get saved server side and client side (persistent store). So restkit manage on its own passing my object from mainQueueManagedObjectContext to persistentStoreManagedObjectContext and then save it in the persistent store.
create new object Offline -> go Online: with this fix now, once online, I can POST correctly my new object and also it gets saved into my client persistent store after receiving server success confirmation (before I was running into Serious Core Data Error as described).
create new object Offline -> close my app -> open my app and go online: In this case, as I am working on the mainQueueManagedObjectContext even force to call [mainQueueManagedObjectContext save] my object isn't saved in the persistent store.
Regarding point three it is clear to me from the documentation:
"mainQueueManagedObjectContext is designed to isolate the main thread from disk I/O and avoid deadlocks. Because the primary context manages its own private queue, saving the main queue context will not result in the objects being saved to the persistent store."
but so....which is the best approach on doing a "forced" persistent store save from the mainQueueManagedObjectContext (just like RestKit does in the point 1) ?
Thanks in advance

Any updates about this issue? do RestKit support offline mode now?


apiso-date-test

Overview
Uncomments date-time
Related Issue / Discussion
None
Additional Information
None
Contributions and Licensing
(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[x] I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
[ ] I have already previously agreed to the pycsw Contributions and Licensing Guidelines

Closing.  CSW AP-ISO does not have an apiso:Date queryable, supporting only temporal extent queries.


Background of Tab Group

So is there a way to configure the color of the tab bar? That light grey is an eyesore

You can change TabLine, TabLineFill, TabLineSel highlight groups. See also :h TabLine, :h TabLineFill, :h TabLineSel.


Fix a minor typo

Replaced "Nullsoft Scriptable Install System" with "Nullsoft Sciptable Install System" in the Bondat section, and also put commas in the list to make it consistent with the other lists

@FrogletApps Thank you for fixing those items! We'll get your changes merged.


Fix LTO linker warning

warning: ‘__builtin_strlen’ reading 1 or more bytes from a region of size 0 [-Wstringop-overread]

Can you explain why this gets rid of the warning? It seems to me the reason for the warning is something else and this "fix" only confuses the compiler enough that it doesn't print the warning any more. Problem is that this doesn't really save us, there are other cases where this warning shows up. So we still have to disable that warning.
There shouldn't be cases where set_user() is called with a nullptr.

It is really the only place I get this warning. It is triggered by
::osmium::memory::Buffer buffer(10000);
::osmium::builder::RelationBuilder relationBuilder(buffer);
::osmium::Relation&  r = relationBuilder.object();

relationBuilder.set_user(relation.user());`

The variable relation is the parameter of a ::osmium::handler::Handler::relation() callback. Do I have to check the user against nullptr at this point?

It is really the only place I get this warning.

That might be true in your code, but other code has similar problems in different places.

relationBuilder.set_user(relation.user());

Unless you are doing something strange relation.user() will never return a nullptr! So your check should never be necessary. The reason for the warning is different, it has something to do with the way we allocate memory and instantiate OSM objects in our buffer and then add additional information like the user name after the instantiated objects.
I believe your change merely seems to make the code sufficiently more complex that the compiler can't be sure any more and doesn't produce the warning. If you compile the libosmium tests you will see a different place showing the same problem where your fix doesn't work. We need a better way to fix this problem. :-(

Ok. Then I will withdraw my PR.


move pathPattern content into pv.md

also, move static-provisioning to top of pv.md, since it's the simplest usage

translation done @xiaogaozi


physical_storage model: added a has many relation to event_stream with cascade on delete

events related to a storage system will be deleted from EventStream db when the system is deleted.
manual test:

before fix:
1.1 storage system storwize-svc-sim is connected but has no related event:

1.2 a test event is created for that system in AutoSDE backend and appears in EventStream db:

1.3 storage test was deleted but event persists in EventStream db (though auto-deleted from backend db):

persisting event was manually deleted from EventStream db

same routine after fix:
2.1 storage and related event re-added:

2.2 storage removed:

2.3 event no longer appears in EventStream db:

this was tested also in a scenario in which the storage system is deleted directly through the backend endpoint, and the event was successfully auto-deleted from EventStream db as well.

hi,
PR is ready for your check
thanks,
Or

@OrGur1987 can you update the title and description to include nullify vs delete?


404 error when changing to a branch with / in its name

In the deliverybot UI if I change to a branch with a / in its name it throws a 404 error (ex: feat/new-amazing-feature)

Selecting a branch with /

404 error

@imella I believe this is all good now but feel free to re-open if it's still an issue.


react-unknown-prop

Warning: Unknown props lat, lng, $hover, $getDimensions, $dimensionKey, $geoService, $onMouseAllow, $prerender on  tag. Remove these props from the element. For details, see https://fb.me/react-unknown-prop.
After react 15, unknown props cannot be used

Thank you, I know, in process.

Will fix today

That's great!! Thanks

Looks like no PR will help, as the problem that in new React you should not use div or other DOM react elements as a children of a Map.
even I'll remove internal $ props on React.cloneElement you are still will have lat lng props on your div (etc) so the problem will not gone.
IMO the best way is not to use DOM elements as Map children, you should create your own Marker etc component.

OK.. Thanks.. as a suggestion I think it would much more sense if we could pass an array of markers to google-map-react component instead of having to add a separate child inside the component.
anyway.. Thanks for your response and for your wonderful work!

@BesatZardosht +1 on your suggestion -- I also wish we could do that. It would also be nice if this lib exposed the native google maps Marker support. Not sure if that's something @istarkov would want but I could submit PRs


Fix MMShareFindPboard and Cmd-E/Cmd-G

Fix MMShareFindPboard not working properly. MMShareFindPboard is supposed to prevent MacVim from updating the system find pasteboard when searching, but the previous behavior was that it would only set the Vim-specific format to the find pasteboard so you could still share search patterns across Vim windows but it has the effect of clearing the global find pasteboard. Just fix that by making MacVim not touch the system find pasteboard at all when MMShareFindPboard is set to NO to respect user's setting.
Also, make Cmd-E/Cmd-G always use the OS find pasteboard even if MMShareFindPboard is set to NO. This keeps the behavior consistent with how other macOS apps work and a way for the user to still access it even with the setting off. One can always still use n or other normal Vim search commands to search without using the system find pasteboard.
Also update docs to make this clear, and rename all "OS X" to "macOS" to keep up with the times.
Close #773

I've just built using this PR and it appears to work as advertised.  I'll keep playing with it.
As an added bonus, it appears to have fixed bug #752!

@chdiza That's good to know! I didn't realize this would fix that bug but it makes sense looking at the code, as previously it was registering the string clipboard but not providing content for it, so maybe it led to some bad interactions across the difference programs.


Add contributing steps on readme.md

Description
@yyx990803  @NataliaTepluhina what do you think to add contributing steps to new contributors on readme.md?

@Lukyhenson thanks for the proposal! I think these steps are more or less sinilar for any OSS contributions.
@phanan what do you think?

I agree. Thanks and looking forward to your next PRs though, @Lukyhenson 🙌


Consider renaming lazy_errors and re-think behavior

In implementing the class-based configuration, I am writing docstring entries for things that we currently just have a longer description in the docs for. One of these is lazyErrors. In the docs, we have this description titled Lazy Fail (even though the option is called 'lazyErrors'):

While Retries address resiliency at the level of Apps, lazy failure adds resiliency at the workflow level. When lazy failures are enabled, the workflow does not halt as soon as it encounters a failure, but continues execution of every app that is unaffected. Lazy failures is the default behavior in parsl, with the expectation that when running production workflows, individual app failures can be deferred until the end of the workflow. During the development and testing of workflows, failing immediately on any failure is often preferred and this behavior is possible by setting lazyErrors=False.

I do not favor the name lazy_fail or lazy_errors. I'm not sure the lazy part is a perfect description of what we're doing, and I think it relies on background knowledge unnecessarily. I propose halt_on_error or halt_on_failure. In that way, the name would describe what is being done without assuming prior knowledge or a mental mapping between concepts. The docstring entry could be (I'm open to help tweaking this):

Halt workflow processing and exit immediately if any apps fails.

We've been discussing batching all of the user-facing changes together, which is why I wanted to address this now.

More about the description in general rather than specifically the name:
i) better describe the trade-off between the two modes: non-lazy mode is useful in production if you can make use of the other stuff that is being run - for example, if you have sufficient checkpointing in place to usefully resume in a way that uses that later stuff, or because you have some other thing in your app which makes that useful. It's not clear to me at the moment that that is always (or even often) the case (even though we'd like it to be).
ii) The pasted text talks about "exit immediately" - is that really what happens?  or does a Python exception get thrown to the user's workflow code? and if so, where/by whom?
iii) I think my preference for name would be something along the lines of "continue as much as possible" - describing the unusual behaviour that parsl will provide despite failure.

i) better describe the trade-off between the two modes: non-lazy mode is useful in production if you can make use of the other stuff that is being run - for example, if you have sufficient checkpointing in place to usefully resume in a way that uses that later stuff, or because you have some other thing in your app which makes that useful. It's not clear to me at the moment that that is always (or even often) the case (even though we'd like it to be).

Agreed.

ii) The pasted text talks about "exit immediately" - is that really what happens? or does a Python exception get thrown to the user's workflow code? and if so, where/by whom?

Agreed. I will clarify this and post an updated proposal soon.

iii) I think my preference for name would be something along the lines of "continue as much as possible" - describing the unusual behaviour that parsl will provide despite failure.

This is interesting. I think both of our instincts about what this should be called are informed by our assumptions about what constitutes "unusual" behavior. For me, continuing as much as possible would be my default assumption, and the entire workflow exiting if one task fails would be unusual behavior. Continuing as much as possible has been the default with other workflow systems I've worked with: Lobster, CRAB, Condor DAGMan, etc. What was the default in Swift? I suppose we should favor whatever the most common default assumption is that users would make, but I'm not sure how to determine that. Thinking about this more, maybe halt_workflow_on_task_failure would be a more precise (but verbose) version of my original proposal.
@danielskatz @kylechard @yadudoc @mjwilde Do you have any preferences here?

(After other discussion elsewhere:)
My view of how non-lazy errors should appear to the library user seems different to how the present implementation tries to present them (which is also different from what is really happening).
My view is that non-lazy errors are a request that errors be presented to the user "earlier rather than later" but it shouldn't otherwise affect what parsl is doing, or otherwise affect the enclosing app.
In lazy mode, exceptions are presented to the enclosing python code at fairly well defined points: mostly, when you ask a future for its result. At that point, you might get back an exception saying that some other piece of work has failed - not directly related to that specific future (a dependency exception).
In non-lazy mode, I can imagine the same thing happening:
When a task fails, parsl stops scheduling new tasks, perhaps tries to kill any tasks that are running now...
... but leaves the DFK usable in future, executors running, and reports the error only at the point that the enclosing app asks for a result. (a variant of a dependency exception).
If the app decides that it wants to abort back to a shell prompt, then it can do that (by not catching the exception, by default!) and that is when DFK shutdown happens, and  DFK-related cleanups like shutting down managed executors should happen there.
I think this is substantially less "fail hard" than at least what @yadudoc had been aiming for.

I'm most likely repeating stuff that has been recorded above, but I want to put in information from a discussion :
lazy_errors=False is ambiguous, and it might be simpler to use halt_workflow/execution to clarify the behavior that the user is enabling. ie. by enabling (halt_workflow_on_failure=True) any task failure would trigger the shutdown of the workflow including propagation of the exceptions involved if any new tasks submission is attempted.
There is the issue of raising the exception to the user when halt_workflow_on_failure is enabled. We are working with the assumption that if this option is enabled, we do not let the user handle the error and prevent the halting of the workflow. In addition, when an exception from a task is handled by "handle_update", we trigger cleanup shutting down provisioned resources. To prevent new tasks we might need to add functionality to submit and/or launch interfaces to prevent new tasks from being accepted by the dfk.

see #645 for some code working towards this


Hue Bridge doesn't connect anymore

Describe the bug
After a succesfull setup of the brigde. Hue Magix doesn't connect. It hangs on connecting.
It started after I updated to 4.2.2.
I tryed to get an new api key. It is send back by the bridge correctly.
Also sometimes I get an timeout error if I open the bridge setup screen
If I open te Light list an error is displayed: "Something went wrong. Please retry."
If I try an configured light. The following texts is display in the debug screen:
"The light in not yet available. Please wait until HueMagic has established a connection with the bridge or check whether the resource ID in the configuration is valid."
Log:
22 Oct 22:49:31 - [info] [hue-bridge:Philips hue] Initializing the bridge (192.168.0.xxx)…
22 Oct 22:49:32 - [info] [hue-bridge:Philips hue] Connected to bridge
22 Oct 22:49:33 - [info] [hue-bridge:Philips hue] Processing bridge resources…
22 Oct 22:49:33 - [info] [hue-bridge:Philips hue] TypeError: Cannot read property 'owner' of undefined
Screenshots

Please complete the following information:

Node-RED version: 3.0.2
NodeJS version: [v14.16.0]
Device running Node-RED: Windows 10

I also have the same problem:
26 Oct 19:38:24 - [info] [hue-bridge:Philips Hue Bridge] Initializing the bridge (192.168.x.x)…
26 Oct 19:38:24 - [info] [hue-bridge:Philips Hue Bridge] Connected to bridge
26 Oct 19:38:25 - [info] [hue-bridge:Philips Hue Bridge] Processing bridge resources…
26 Oct 19:38:25 - [info] [hue-bridge:Philips Hue Bridge] TypeError: Cannot read properties of undefined (reading 'owner')

Node-RED version: v3.0.2
Node.js  version: v16.16.0
Device running Node-RED: Raspberry Pi running Home Assistant OS image, with Node-RED in a container.

For the time being I've created a fork and applied some fixes that should solve these issues. I have published it as a new node-red node contrib. You can find it as node-red-contrib-huemagic-fork.

Found a fix and implemented it. See:

Fyi, I published a pull request #409 which, in addition to fixing the problems mentioned here, also improves the way the bridge overload is handled (following +/- recent changes made to the HUE bridge at this level, aka Error 429)...
So if you want to give a try, you can using this one too (installable form FredBlo fork npm install git+https://github.com/fredblo/node-red-contrib-huemagic.git :-) )

the fork is working for me, thanks!!

@neildsb , the problems you encounter are related to what I solved in the PR #409, see my previous comment I think you should try to apply this install npm install git+https://github.com/fredblo/node-red-contrib-huemagic.git

thanks, think I will have to wait for the merge, I cannot use 'npm install' :-(

thank you @FredBlo I've switched to your fork, can't wait for this anymore. Really appreciate your work.

node-red-contrib-huemagic-fork 4.2.4
looks like its working so far....

thank you @FredBlo I've switched to your fork, can't wait for this anymore. Really appreciate your work.

What is the best way to switch to the fork without loose the used nodes?

thank you @FredBlo I've switched to your fork, can't wait for this anymore. Really appreciate your work.

What is the best way to switch to the fork without loose the used nodes?

Here below the steps you could take in order to use the fork without having to re-create all of your flows:

Create a backup of all flows that refer to the huemagic nodes
Remove all the huemagic related flows
Remove all the huemagic related configuration nodes
Deploy all changes
Remove the original huemagic nodes contrib
Install the huemagic fork nodes contrib
Import the backup created in step 1
Deploy all changes

Cheers


[NEW] RootCLI flags is not persistent but local flags.

This is to allow new subcommands use -c / -l / -k shortcut in their
subommands. The RootCLI object does not set its -c -l -k command
line option as global.
Note the behavior may change later.

Codecov Report

Merging #10 (3668196) into main (296dd0e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8         8
  Lines          574       579    +5
=========================================
+ Hits           574       579    +5

Impacted Files
Coverage Δ

cli/cli.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 296dd0e...3668196. Read the comment docs.


Composable steps to run a simulation

          I think I would rather have composable steps to run a simulation rather than having a single Simulator object, but we can discuss in our dev meeting! Makes sense to me so far!

Originally posted by @apayne97 in https://github.com/choderalab/asapdiscovery/pull/246#discussion_r1216109564

@apayne97 does this still apply?

No, I think what we've done is fine


Enable Bot.Builder.Classic (V3) dialog to run side-by-side with V4 dialogs

The classic namesape enables to run V3 dialogs wrapped in a V4 bot. To provide continuation from V3 to V4, we need to find a way to pass enough context (state) and control to a V4 dialog. For example. V3 root dialog has two child dialogs, order, and name. Once both dialog complete, the root dialog can call a V4 dialog (to collect address information).
The ask is to provide the capability to have an existing V3 dialog 'get extended' with a V4 dialog and be able to pass state and context between the two dialogs systems.

I think Skillls means we drop this?  Assigning to Vishwac to evaluate.

Closed via Skills feature.


Create CMS wish list elements

"New features in Spartacus should be data driven" - Anonymous 2019
Therefore, a new sets of CMS elements need to be created.

wishListPage the page to view the wish list. Should use "Account Page Template".
WishListComponent the component that will display the wish list in the page above.
BodyContentSlot-wishList the content slot that contains WishListComponent.
BodyContent-wishList the relation between BodyContentSlot-wishList & wishListPage. Value: Position: BodyContent, Page: wishListPage, Content Slot: BodyContentSlot-wishList
AddToWishListComponent this component is for adding and removing items from the PDP
Add this component to the last position of the ProductSummarySlot
Create nav link in the account dropdown

PR spartacussampledataaddon/pull/33

Will not be tested individually


[Bug]: fzf-lua dependency

Your minimal.lua config
.
Error messages
.
Log output
.
Health check output
.
Describe the bug
The FZF window that opens after entering :CodeCompanionActions<cr> is unreadably even with fullscreen vim.
If https://github.com/ibhagwan/fzf-lua is installed, then it becomes readable in fullscreen, but still unreadable

if, say, the columwidth is, say, below 100 as shown below
Instead, ensure that the first column is always show and rather shorten the rightmost.
So the first step would be to add https://github.com/ibhagwan/fzf-lua as a dependency (which can optionally be replaced by telescope), and then ensure that at least the leftmost columns stays readable.
Reproduce the bug
Enter :CodeCompanionActions<cr>.
Final checks

[X] I have made sure this issue exists in the latest version of the plugin
[X] I have tested with the minimal.lua file from above and have shared this
[X] I have shared the contents of the log file

Please provide the minimal.lua file so that I can test this.

call plug#begin()

Plug "nvim-lua/plenary.nvim"
Plug "nvim-treesitter/nvim-treesitter"
Plug "nvim-telescope/telescope.nvim", " Optional: For using slash commands
Plug "olimorris/codecompanion.nvim"

call plug#end()

lua << EOF
  require("codecompanion").setup()
EOF

This is with Neovim
NVIM v0.11.0-dev-684+g53af02adb
Build type: RelWithDebInfo
LuaJIT 2.1.1724512491

Please create a new issue following the minimal.lua file I've provided in the bug report.


Version 2.0 Proposal

Hey hey :) It was cool meeting you in Munich last year, hope all is well!
I've been using Redux a bit more and would like to suggest a couple of changes to this library to make it more slightly flexible yet still "as simple as possible."
Since these would be breaking changes, I'd propose it as a 2.0 release.
Overall, if this isn't your thang, honestly no worries at all. I'd be happy to publish it as a separate package, but thought it'd be cool to try to keep all the number of Redux implementations in DartLand as small as possible, and see what your thoughts are.
Now, I know you didn't want to change to typedef's in my first PR, but hear me out :) This new version would allow us to have our cake and eat it too: If users want to use functions for reducers and middleware, they can. If they want to use classes, they can!
Also, I was trying to implement Redux DevTools, but I was unsuccessful due to the typing of Action, because Store Enhancers need to be able to dispatch their own actions. Therefore, I removed it. I had this exact constraint in a Java version of Redux I'd written and and actually removed this Generic constraint in that lib due to the constraint.
Proposed changes:

Added a bunch of docs and did just a bit of code cleanup.
Remove the typing of Action - If Action is a typed parameter, it prevents any type of Store Enhancer (such as Redux Dev Tools) from dispatching their own actions. In code, this means class Store<State, Action> becomes class Store<State>.
Change Reducer to Typedef with Class fallback -- this introduces typedef State Reducer<State>(State state, dynamic action); and changes class Reducer<State, Action> to abstract class ReducerClass<State>. This would require only a small change to code, including extending the new class and renaming reduce to call.
Change Middleware to Typedef with Class fallback -- this introduces typedef void Middleware<State>(Store<State> store, dynamic action, NextDispatcher next); and changes class Middleware<State, Action> to abstract class MiddlewareClass<State>. For middleware, this should be an almost transparent change, as all they'd have to do is extend MiddlewareClass instead of Middleware.
Add teardown method, which closes the StreamController and nulls out the state. Needed in case someone wanted to stop using the store during the app lifecycle.

Lemme know whatcha think and if you have suggestions!

Hey, I've ended up making a bunch more changes to play around with some different concepts, especially around Store Enhancers for Dev Tools, so I think it might close this out for now.

Ok.  I like this a lot better now that generic function type syntax was added in 1.24
Feel free to re-open whenever and i'll merge + publish the changes


vaker.v: Remove unnecessary unasfe block

very nice and fast language

Thx for unsafe block removal :)

thanks for approval kind sir


Add defaults check

Convenience method to help us check differences between config defaults and user config.

@aneda

@chriddyp , i think this will help us sort out the email issue with feedback, which would be nice :)


Update index_updater.py

to account for padded zeros added by https://github.com/stanford-futuredata/ColBERT/pull/336

cc VThejas


add clear doc to inform customer risk to set api-version other than the latest one

duplicate with https://github.com/Azure/autorest.csharp/issues/4697