Incompatible ipset protocol version (7) will cause problems

Expected Behavior
Calico can handle different ipset protocol versions. At least 6-7.
Current Behavior
If K8s upgrades to ipset >= v7.0 outgoing connects from pods fail.
Possible Solution
Upgrade the calico image to include ipset v7.x since it's backward compatible.
Steps to Reproduce (for bugs)

Make sure K8s is upgraded to use ipset v7.x (this is non-trivial if installed with kubeadm)
Use proxy-mode=ipvs (uses ipset)
Try an outgoing connect from a pod

The kube-proxy (v1.22.2) image includes ipset v6.38. It must be changed to some v7.x version. How that is done I can't say. I start kube-proxy as a program (no container) so for me it's simply to change the ipset on the node.
Context
While this isn't a problem at the moment, it will be the day K8s upgrades to iset v7.x
Your Environment

Calico version: calico/cni:v3.19.1
Orchestrator version (e.g. kubernetes, mesos, rkt): K8s
Operating System and version: Own. But Ubuntu 20.04.3 LTS uses ipset v7.5 at the moment
Link to your project (optional):

it will be [a problem] the day K8s upgrades to iset v7.x

Kubernetes v1.23.0 kube-proxy does use v.7.x. Calico v1.22.x Pods show the OP's error and will never be Ready. So the time has come.
ipset --version
ipset v7.10, protocol version: 7

There is probably other compatibility issues since protocol version 7 seems to be used in my case.
Ubuntu host -- k8s node :
ubuntu@k8s-master-01:~$ sudo ipset version
ipset v7.10, protocol version: 7

Ubuntu host -- calico-node pod
❯ kubectl exec -it -n calico-system calico-node-zq7kg -- bash
Defaulted container "calico-node" out of: calico-node, flexvol-driver (init), install-cni (init)
[root@k8s-master-01 /]# ipset version
ipset v7.1, protocol version: 7
[root@k8s-master-01 /]# ipset list
Name: KUBE-NODE-PORT-TCP
Type: bitmap:port
Revision: 3
Header: range 0-65535
Size in memory: 8264
References: 0
Number of entries: 0
Members:
ipset v7.1: Kernel and userspace incompatible: settype hash:ip,port with revision 6 not supported by userspace.

Our distro marked Calico as not supported with Kuberntes v1.23 due to this incompatibility

On Fedora 35
2021-12-31 17:55:39.777 [INFO][47966] felix/ipsets.go 312: Retrying after an ipsets update failure... family="inet"
2021-12-31 17:55:39.779 [ERROR][47966] felix/ipsets.go 574: Bad return code from 'ipset list'. error=exit status 1 family="inet" stderr="ipset v7.1: Kernel and userspace incompatible: settype hash:ip,port,net with revision 8 not supported by userspace.\n"
2021-12-31 17:55:39.779 [WARNING][47966] felix/ipsets.go 322: Failed to resync with dataplane error=exit status 1 family="inet"

@Meroje What linux kernel version do Fedora 35 use?
I am using linux-5.15.2 and only protocol versions 6-7 is supported, not version 8.
Please see; https://github.com/torvalds/linux/blob/8008293888188c3923f5bd8a69370dae25ed14e5/include/uapi/linux/netfilter/ipset/ip_set.h#L16-L18

@Meroje What linux kernel version do Fedora 35 use?
I am using linux-5.15.2 and only protocol versions 6-7 is supported, not version 8.
Please see; https://github.com/torvalds/linux/blob/8008293888188c3923f5bd8a69370dae25ed14e5/include/uapi/linux/netfilter/ipset/ip_set.h#L16-L18

It's on 5.15.6 indeed not even the next 5.16 seem to not have that number

It's on 5.15.6 indeed not even the next 5.16 seem to not have that number

Our distro marked Calico as not supported with Kuberntes v1.23 due to this incompatibility

FWIW, our overnight runs (on ubuntu 20.04) show Calico working just fine with k8s 1.23, so this isn't a blanket incompatibility.

Our distro marked Calico as not supported with Kuberntes v1.23 due to this incompatibility

FWIW, our overnight runs (on ubuntu 20.04) show Calico working just fine with k8s 1.23, so this isn't a blanket incompatibility.

That's probably because you're using proxy-mode=iptables

I got errors when using ipvs mode for dualstack use, iptables is fine on my 1.23 cluster

Since CentOS 8 is on EOL right now, this is most likely to be fixed once calico node switches from CentOS 8 to CentOS Stream 9 since it includes ipset v7.11 & kernel 5.14.
CentOS Stream 9 got released a few weeks ago.

Yeah, reverting kube-proxy to iptables mode avoids the issue of course, but we'd like to stick to ipvs. We're using other CNIs until Calico supports this again.

I can confirm from Slack that there was some work from @song-jiang for switching the base images to CentOS Stream 9 which would provide a sufficient version of ipset. So at least we can tell that this would be fixed in a future release.
Until then ipvs proxy mode SHOULD be disabled to make Calico work on kubernetes >= 1.23.

Hmm, I wonder what I do wrong that Calico v3.21.2 works fine for me with kube-proxy in ipvs mode. Could it be that I miss some configuration, so kube-proxy is runing in ipvs mode while calico keeps using iptables?

Hmm, I wonder what I do wrong that Calico v3.21.2 works fine for me with kube-proxy v1.23.1 in ipvs mode. Could it be that I miss some configuration, so kube-proxy is runing in ipvs mode while calico keeps using iptables?

Can you check calico-node logs and ipset version on host VS on calico-node pod ?

Please note that incoming traffic works with proxy-mode=ipvs. Outgoing doesn't.

$ kex calico-node-fzgvv -c calico-node -- ipset --version
ipset v7.1, protocol version: 7
$ ssh ... sudo ipset --version
ipset v7.6, protocol version: 7
$ kex kube-proxy-99mb7 -- ipset --version
ipset v7.10, protocol version: 7
$ klo calico-node-zs9jh | grep ipvs
2022-01-12 08:53:13.568 [INFO][71] felix/driver.go 78: Kube-proxy in ipvs mode, enabling felix kube-proxy ipvs support.
2022-01-12 08:53:13.892 [INFO][71] felix/int_dataplane.go 1036: Linux interface state changed. ifIndex=6 ifaceName="kube-ipvs0" state="up"
2022-01-12 08:53:13.896 [INFO][71] felix/int_dataplane.go 1521: Received interface update msg=&intdataplane.ifaceUpdate{Name:"kube-ipvs0", State:"up", Index:6}
$ klo kube-proxy-78q2f | grep -i ipvs
I1217 00:03:42.452605       1 server_others.go:269] "Using ipvs Proxier"
I1217 00:03:42.452630       1 server_others.go:271] "Creating dualStackProxier for ipvs"

What about the kernel version ?

I'm running 5.10.84-flatcar.

Interesting, this kernel version doesn't include bucketsize in all hash types for the ipset kernel module that's why you seem to have no issues.

This isn't fixed in Calico v3.22.0

I just updated my toy installation(one node) - k8s 1.23.3, Calico 3.22.0 - seems to work fine.

Looks like this isn't fixed in v3.22.0. We have tested it as well and the issue is still present. calico-node is never getting ready and logs are spamming the following error:
2022-02-02 09:41:07.002 [ERROR][38249] felix/ipsets.go 574: Bad return code from 'ipset list'. error=exit status 1 family="inet" stderr="ipset v7.1: Kernel and userspace incompatible: settype hash:ip,port with revision 6 not supported by userspace.\n"

3.22 works for me.
Below is some info If it helps to troubleshot:
kubectl get pods -n kube-system -o jsonpath="{.items[*].spec.containers[*].image}" |tr -s '[[:space:]]' '\n' |sort |uniq -c
      1 docker.io/calico/kube-controllers:v3.22.0
      1 docker.io/calico/node:v3.22.0
      2 k8s.gcr.io/coredns/coredns:v1.8.6
      1 k8s.gcr.io/etcd:3.5.1-0
      1 k8s.gcr.io/kube-apiserver:v1.23.3
      1 k8s.gcr.io/kube-controller-manager:v1.23.3
      1 k8s.gcr.io/kube-proxy:v1.23.3
      1 k8s.gcr.io/kube-scheduler:v1.23.3

uname -a
Linux NAS 5.14.0-1020-oem #22-Ubuntu SMP Thu Jan 13 18:22:21 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

@lazystone Are you running kube-proxy in the iptables or IPVS mode? The default is iptables mode, and it works fine on 1.23. The issue is that running kube-proxy in the IPVS mode doesn't work on 1.23 with Calico at all.

@xmudrii is right v3.22.0 is missing the PR #5485
You can directly use the latest calico/node image with the tag master, it should be working.
Master history : https://github.com/projectcalico/calico/commits/master/node
v3.22.0 history : https://github.com/projectcalico/calico/commits/v3.22.0/node

@caseydavenport can you include this PR #5485 in the next release ?

FYI: The ipset changes is not part of v3.22.0 since it takes more time to get everything fully tested. It should be in v3.22.1.

Raised https://github.com/projectcalico/calico/pull/5561

@xmudrii I use metallb, so it's ipvs

Yep that's right, the fix has been merged to master but needs cherry-picking to the v3.22 branch still. Once that's done it will be in v3.22.1.
We didn't get this into v3.22.0 because the fix came in a bit later and we had already entered code freeze.

I am running 1.23.4 with Calico3.22 on Ubuntu 20.04.4 LTS in IPVS mode, and I can confirm this is still NOT fixed.

I mentioned above that it works for me in IPVS mode. But I was wrong - It starts but outgoing connections fail.

I can confirm this would be fixed in the next release.
calico/node:latest (not v3.22.0) is working with ipvs mode once you include it with a custom ImageSet
Have a look here : https://projectcalico.docs.tigera.io/maintenance/image-options/imageset
Or wait for the next release (v3.22.1)

I have just rolled out 3.22.1 and I am still seeing the same error message
kk get daemonset -n kube-system calico-node -o yaml|grep image:         image: docker.io/calico/node:v3.22.1         image: docker.io/calico/cni:v3.22.1         image: docker.io/calico/cni:v3.22.1       - image: docker.io/calico/pod2daemon-flexvol:v3.22.1
and still seeing
2022-03-06 22:51:02.647 [ERROR][72103] felix/ipsets.go 574: Bad return code from 'ipset list'. error=exit status 1 family="inet" stderr="ipset v7.1: Kernel and userspace incompatible: settype hash:ip,port,ip with revision 6 not supported by userspace.\n"

@leoweiyu Would you mind raising as a new Issue (and link to this one) please?

@lwr20 , sorry was busy for the past few days, yeah the last comment in #5717 make sense to me, i am running k8s on arm system and seems 3.22.1-arm did not get the latest fix as 3.22.1-amd


Can we change Done text and Cancel text color change

I haven't found the property for changing Done text color or Cancel text color.
var configure = TLPhotosPickerConfigure()         configure.doneTitle = "Done"         configure.cancelTitle = "Cancel"         configure.tapHereToChange = "Tap here to change"         configure.numberOfColumn = 3         configure.maxSelectedAssets = 2         configure.selectedColor = .orange

@MasamMahmood
Try this
imagePicker.cancelButton.setTitleTextAttributes([NSAttributedString.Key.foregroundColor: UIColor.black], for: .normal)

@MrFuFuFu Thank you.


i'm struggling

how to access to the localeconfig and selected date style

for the selected date style you can look for the sample code and for the locale config you need to pass prop like this ln={'fr'}


[bin-wrappers] Reduce/improve when we create bin wrappers

Summary
This removes all CreateWrappers calls except one.  It also removes the interface used to prevent a circular dependency and passed in all arguments at the callsite. It no longer needs to recompute nix env.
It helps address performance issues where CreateWrappers was causing extra calls to ComputeNixEnv.
How was it tested?
It builds and runs. This will need extensive testing.

why did we have all the additional calls?

They predate the call inside ensurePackagesAreInstalled. Previously all our code paths were not centralized through ensurePackagesAreInstalled so each command had its own bin wrapper creation. But I think tying it to ensurePackagesAreInstalled is exactly what we need. I still want to test it thoroughly.


remove logit intermediate cert workaround

This removes the logit intermediate certificate workaround, which is
no longer needed.
I also added a comment in the Dockerfile to explain how build.sh and
modules.go get consumed because i found that really confusing the
first time around.
Build on docker hub was successful: https://hub.docker.com/r/govuk/logspout-alpine/builds/buhapzmzpvh84j3yz5vttjn/

I don't think this will actually have an effect on machine which have already downloaded the image

Tested the image manually on docker-management-1 in integration. it works 🎉


Remove long-skipped test

"Fixes" https://github.com/flutter/flutter/issues/53707

The reason for deleting it is that it's just taking up cognitive space and clearly nobody is concerned enough about the test to debug it and make it pass. That said, this isn't enough to delete the test actually, so I'm going to close this and try again.


[Site support request] dbr.ee

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.09.18. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.09.18

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
A:\Projects\Melodore>youtube-dl --ffmpeg-location A:\Projects\Melodore\ffmpeg.exe -v https://dbr.ee/vAeD
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--ffmpeg-location', 'A:\\Projects\\Melodore\\ffmpeg.exe', '-v', 'https://dbr.ee/vAeD']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2018.09.18
[debug] Python version 3.6.6 - Windows-10-10.0.17760-SP0
[debug] exe versions: ffmpeg N-77380-g2dba040, ffprobe N-77380-g2dba040
[debug] Proxy map: {}
[generic] vAeD: Requesting header
WARNING: Falling back on generic information extractor.
[generic] vAeD: Downloading webpage
[generic] vAeD: Extracting information
ERROR: Unsupported URL: https://dbr.ee/vAeD
Traceback (most recent call last):
  File "c:\users\XXXXXX\appdata\local\programs\python\python36\lib\site-packages\youtube_dl\YoutubeDL.py", line 784, in extract_info
    ie_result = ie.extract(url)
  File "c:\users\XXXXXX\appdata\local\programs\python\python36\lib\site-packages\youtube_dl\extractor\common.py", line 437, in extract
    ie_result = self._real_extract(url)
  File "c:\users\XXXXXX\appdata\local\programs\python\python36\lib\site-packages\youtube_dl\extractor\generic.py", line 3088, in _real_extract
    raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: https://dbr.ee/vAeD

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single audio clip: https://dbr.ee/00as

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.

I accidentally didn't have youtube-dl to the latest version - I've updated it and the result is exactly the same. ```A:\Projects\Melodore>youtube-dl --ffmpeg-location A:\Projects\Melodore\ffmpeg.exe -v https://dbr.ee/vAeD
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--ffmpeg-location', 'A:\Projects\Melodore\ffmpeg.exe', '-v', 'https://dbr.ee/vAeD']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2018.09.18
[debug] Python version 3.6.6 (CPython) - Windows-10-10.0.17760-SP0
[debug] exe versions: ffmpeg N-77380-g2dba040, ffprobe N-77380-g2dba040
[debug] Proxy map: {}
[generic] vAeD: Requesting header
WARNING: Falling back on generic information extractor.
[generic] vAeD: Downloading webpage
[generic] vAeD: Extracting information
ERROR: Unsupported URL: https://dbr.ee/vAeD
Traceback (most recent call last):
File "c:\users\novocy\appdata\local\programs\python\python36\lib\site-packages\youtube_dl\YoutubeDL.py", line 792, in extract_info
ie_result = ie.extract(url)
File "c:\users\novocy\appdata\local\programs\python\python36\lib\site-packages\youtube_dl\extractor\common.py", line 507, in extract
ie_result = self._real_extract(url)
File "c:\users\novocy\appdata\local\programs\python\python36\lib\site-packages\youtube_dl\extractor\generic.py", line 3298, in _real_extract
raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: https://dbr.ee/vAeD


problem with popups?

mlf says:
This is very cool, but it appears you still need to log in to AGOL and manually re-Enable Popups, and re-order fields, as those modifications are wiped out when you overwrite the service. Can anyone confirm this concern, and/or show me a way around it?

need to investigate this.

This workflow only addresses the service itself, not any webmaps. Not sure can support this.


First day of week

Hi, Steven!
I like it library, but in the Europe calendar to needs set first day of week the monday.
Is it possible do in your library?

@twox @StevenPreston  i fix it by updating next lines in
`SSYearNode.m

(NSInteger)weekdayOfFirstDay {
return weekdayOfFirstDay == 0 ? 6 : weekdayOfFirstDay - 1;
}`

`SSMonthNode.m

(NSInteger)weekdayOfFirstDay {
return weekdayOfFirstDay == 0 ? 6 : weekdayOfFirstDay - 1;
}`

`SSDayNode.m

(id)initWithValue:(NSInteger)value Month:(NSInteger)month Year:(NSInteger)year Weekday:(NSInteger)weekday
{
self = [super init];
if (self)
{
self.value = value;
self.month = month;
self.year = year;
self.weekday = weekday == 0 ? 6 : weekday - 1;
}
return self;
}`

Also you need to update week header view
`SSCalendarWeekHeaderView.h

(void)layoutSubviews
{
[super layoutSubviews];
NSDateFormatter *dateFormatter = [[NSDateFormatter alloc] init];
NSMutableArray *weekdays = [[dateFormatter veryShortWeekdaySymbols] mutableCopy];
[weekdays insertObject:[weekdays firstObject] atIndex:weekdays.count];
[weekdays removeObjectAtIndex:0];
for (int i = 0; i < [weekdays count]; i++)
{
NSString *day = [weekdays objectAtIndex:i];
  CGRect frame = self.frame;
  frame.size.width = (int) frame.size.width / [weekdays count];
  frame.origin.x = i * frame.size.width;

  UILabel *label = [[UILabel alloc] initWithFrame:frame];
  label.backgroundColor = [UIColor clearColor];
  label.textAlignment = NSTextAlignmentCenter;
  label.font = MainLightFontWithSize(10);
  label.text = day;
  [label setTextColor:[UIColor whiteColor]];

  [self addSubview:label];

}
}`

Thanks @bulyghin , I'll work on adding this as a feature in the next couple of weeks


Missing 'name' property from the interface ChannelAccount in Node.js SDK

when I call connector.fetchMembers() I get a list containing users info where all of them have the property 'name', but I get a typing error when trying to use this property because it's missing from the interface of ChannelAccount.
I've checked the C# SDK and it is present there:
https://github.com/OfficeDev/BotBuilder-MicrosoftTeams/blob/master/CSharp/Library/Microsoft.Bot.Connector.Teams.Shared/TeamsAPI/Models/TeamsChannelAccount.cs

You have to cast the ChannelAccount into an TeamsChannelAccount using AsTeamsChannelAccount extension method (refer to https://github.com/OfficeDev/BotBuilder-MicrosoftTeams/blob/master/CSharp/Library/Microsoft.Bot.Connector.Teams.Shared/ConversationExtensions.cs)

@robin-liao For NodeJS

I got a similar issue


Highlighting is incorrect when using hook

In js-mode in a file with jsx, this is how the highlighting appears when manually activating tree-sitter-hl-mode:

And this is how it appears when using the hook from the usage guide:

Things are highlighted differently. For example, the comment seems to be highlighted incorrectly when using the hook.
There is no errors or stacktraces.
I am using the most recent treesitter and treesitter-langs version.
Emacs version:
GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.27, cairo version 1.16.0)

Please provide more details for debugging:

The file with the issue.
Major and minor modes used in the buffer.
Steps to trigger the behavior. For example, any navigation/editing after opening the file.
Minimal config to reproduce the issue, if possible.

Having the same problem with C code here.

File: a C file containing a single line of define#define RHR 0            // receive holding register (for input bytes)

OS: Arch Linux
A fresh installation of Emacs 28.1, default config

To reproduce the error: install tree-sitter (20220212.1632) and tree-sitter-langs (20220508.636) from MELPA.
In .emacs, only call global-tree-sitter-mode
(require 'tree-sitter)
(require 'tree-sitter-langs)
(global-tree-sitter-mode)

Then open the C file, M-x tree-sitter-hl-mode, the highlighting is correct

However, when using hook to turn on tree-sitter-hl-mode
(require 'tree-sitter)
(require 'tree-sitter-langs)
(global-tree-sitter-mode)
(add-hook 'tree-sitter-after-on-hook #'tree-sitter-hl-mode)

Open the C file, the highliting is wrong

Although register and for are in comments, they are highlighted.  Macro name RHR is in a different color.
Manually turning tree-sitter-hl-mode off and on will give the correct highlighting.

I also had that problem. Im not sure what happens exactly but setting tree-sitter-hl-use-font-lock-keywords (introduced in #46) to nil fixes this.  Can anybody else confirm that this fixes this problem for them ?
Since it probably is relevant, this is my list of enabled modes:
Abbrev Auto-Composition Auto-Compression
Auto-Encryption Auto-Revert Blink-Cursor Column-Number
Counsel-Projectile Display-Fill-Column-Indicator Display-Line-Numbers
Doom-Modeline Electric-Indent File-Name-Shadow Font-Lock Global-Eldoc
Global-Font-Lock Global-Git-Commit Global-Semantic-Idle-Scheduler
Global-Semanticdb Indent-Tabs Ivy Ivy-Rich Ligature Line-Number
Magit-Auto-Revert Mouse-Wheel Override-Global Projectile Semantic
Semantic-Idle-Scheduler Shell-Dirtrack Show-Paren Smartparens
Smartparens-Global Transient-Mark Tree-Sitter Tree-Sitter-Hl Which-Key
Winum Ws-Butler
I do not think any of them install custom highlighting except for smartparens but even without smartparens it seems to happen.

Steps to trigger the behavior. For example, any navigation/editing after opening the file.

Please provide more details for debugging:
* The file with the issue.

* Major and minor modes used in the buffer.

* Steps to trigger the behavior. For example, any navigation/editing after opening the file.

* Minimal config to reproduce the issue, if possible.

Here is something that should be pretty minimal:
init.el:
(require 'package)
(package-initialize)
(require 'tree-sitter)
(require 'tree-sitter-langs)

(add-hook 'c-mode-hook #'tree-sitter-hl-mode)

test.c
#include <stdlib.h>

int main(int, char **)
{
	return 0;
}

modes:
Abbrev Auto-Composition Auto-Compression
Auto-Encryption Blink-Cursor Electric-Indent File-Name-Shadow
Font-Lock Global-Eldoc Global-Font-Lock Indent-Tabs Line-Number
Menu-Bar Mouse-Wheel Show-Paren Tool-Bar Tooltip Transient-Mark
Tree-Sitter Tree-Sitter-Hl
version: GNU Emacs 28.1.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0)
With this setup, if you open test.c, and use describe-face on the #include it will say font-lock-preprocessor-face.
The expected font-lock, which will be shown if you instead enable tree-sitter-hl-mode manually, is tree-sitter-hl-face:function.macro


Have Travis run csvlint on demand

Adds a .travis.yml that installs the csvlint gem and validates the CSV.

The inaugural build passed.

FWIW, I think it'd be nice to have a little script that did some context-specific linting, like making sure the rows have the right number of columns, maybe validating that the bill_type is of the enumerated valid values, etc.


arrow-ord: Support sortting StructArray

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Problem, I need to sort a StructArray and it doesn't seem to currently be possible.
Describe the solution you'd like
Ideally the arrow_ord::sort::sort(...) would support StructArray. pyarrow.StructArray supports this, so I believe it should be possible.
Describe alternatives you've considered
It doesn't seem like there are alternatives, it's just a missing API. Would love to hear though if there are ways to get a sorted StructArray!
Additional context
N/a

Duplicate of https://github.com/apache/arrow-rs/issues/5426


JupyterLab 3.0 update

Hi, it seems that your extension is not compatible with version 3 of Jupyterlab.
Thx for your help.

Coming soon in https://github.com/deshaw/jupyterlab-skip-traceback/pull/8

Published https://pypi.org/project/jupyterlab-skip-traceback/. Please let us know if you have any issues.


Issue with Yosemite

I just tried to use WavTap in Yosemite after enabling the kernel mode. I can see the output device in my sound settings but I don't see the WavTap icon in the menu bar. I am not sure how I can use it without the menu bar item. Any help is appreciated.

The devs of WavTap should get somebody to get a cert for driver-signing, xbox360-controller guys did it, so why not WavTap?


CDPD-25038 Disable hive.orc.splits.include.fileid for object stores

CDPD-25038
To avoid unwanted list calls in object stores setting following config
hive.orc.splits.include.fileid=false
for 7.2.10 & 7.2.11 DE, DE-HA, DE-Spark3 templates.
Testing done:
Have created a datahub cluster using a modified DE template that includes above mentioned config change. Datahub cluster creation was successful on AWS and config change was applied.

@keyki Rajesh has approved it, can you pls merge this?


chore(main): release 0.8.3

:robot: I have created a release beep boop
0.8.3 (2023-12-12)
Bug Fixes

main and preview deployment envs are 404 (#104) (479fc22)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/constructions-incongrues/yazoo/releases/tag/v0.8.3 :sunflower:


POC: MINIFICPP-985 - Implement listvalidators

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Closing this because of inactivity.

Reopening to bring back the topic - seems we will need this more and more

Reopening to bring back the topic - seems we will need this more and more


paths alias not support

lastest swc/core supported,https://github.com/swc-project/swc/pull/1834

at mean time, I add tsconfig-paths.

Close via https://github.com/Brooooooklyn/swc-node/pull/608


Open-Shift install script does not start on CRC standalone

Consider using /var/tsi-secure

Fixed by #57


Update validation in Inline DNS table

Commit Message:
hostname can be single character when trying to resolve within the local domain. Minimum DNS ttl is set to 30s instead of 60s (30 seems to be the lowest that is allowed)
fixes #11893
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

@rshriram can you fix format?
@abaptiste does this make sense to you?

LGTM.  I don't have an issue with the change.

done

@rshriram format is still failing.

fixed it properly this time

@rshriram claims that without this, a lot of DNS stuff is broken.
/backport

/backport approve


TypeError: Invalid state: ReadableStream is locked error from fetch-mock router when combining AbortSignal.timeout and recursive retries

Hello old friend 👋 Struggling to say for sure if this a user error or if I’ve stumbled upon an edge case.
I’m writing tests in jest, mocking globally, using node 18, and node native fetch.
Scenario:

First test is for retrying after AbortSignal.timeout expires (no errors from this running on its own)
Following test makes a second fetch and an error is logged

node:internal/webstreams/readablestream:323
       new ERR_INVALID_STATE.TypeError('ReadableStream is locked'));
       ^

TypeError: Invalid state: ReadableStream is locked
   at ReadableStream.cancel (node:internal/webstreams/readablestream:323:9)
   at AbortSignal.abort (/Users/Laurie.Boyes/dev/fetch-mock/packages/core/dist/cjs/Router.js:95:47)
   at AbortSignal.[nodejs.internal.kHybridDispatch] (node:internal/event_target:816:20)
   at AbortSignal.dispatchEvent (node:internal/event_target:751:26)
   at abortSignal (node:internal/abort_controller:374:10)
   at Timeout._onTimeout (node:internal/abort_controller:128:7)
   at listOnTimeout (node:internal/timers:573:17)
   at processTimers (node:internal/timers:514:7) {
 code: 'ERR_INVALID_STATE'
}

Please see the test case in this PR: https://github.com/wheresrhys/fetch-mock/pull/844. Let me know if there’s any other info I can provide.
I've been working around this issue by explicitly creating an AbortController and setting a timeout to fire the signal and manually cancelling it after the promise resolves

Hello 👋
Just getting round to looking at this now.
Which version of jest are you on? I'm not able to get the test to fail, but I do keep getting flaky tests relating to abort in CI which have been around for ages and I'm not too sure why

Here's an example of a failed test run https://app.circleci.com/pipelines/github/wheresrhys/fetch-mock/1065/workflows/d8562eee-0ff3-4dc2-8fde-14a9df91f744/jobs/11161

Hey, thanks for taking a look! Sorry I should have said, I haven’t managed to create a minimal case for this causing an actual test failure either, I just get the error logged: https://app.circleci.com/pipelines/github/wheresrhys/fetch-mock/1061/workflows/9adf68aa-c9f8-4964-81af-94c738765f31/jobs/11125?invite=true#step-102-1871_50
In my own test suite, for reasons I haven’t yet managed to establish, this error does seem to cause a failure.
I was hoping (and it’s a reasonably confident hope) that if we can get to the bottom where this error is logged from, this will fix my failing test

Reading here https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream/locked I don't understand much more
But I have a hunch that [your `.json()](https://github.com/wheresrhys/fetch-mock/compare/main...laurieboyes:fetch-mock:main#diff-ee4acfc8f5f94532279e0cfad10e16ac93d2db84a6e9c9404510acc9b6cc452eR15) reads and locks the body stream, which then causes the error because the streanm is already being read before the abort tries to cancel the body. I suspect the thing to do is to add an extra check for `locked === true` around here, but I feel I should read up a bit more on what the specs say about the behaviour. I think probably abort shodul jsut take control of the stream and cancel it no matter what else is going on, but not sure

Could you check out this https://github.com/wheresrhys/fetch-mock/pull/847, run npm build and then manually copy the files into your node_modules to see if the fix works (I'd offer to publish a beta but my build pipeline's handling of beta releases is a bit broken at the moment)

Hm nope I get the same error, this time from the call to callLog.response.body.getReader()

Could you check out this #847, run npm build and then manually copy the files into your node_modules to see if the fix works (I'd offer to publish a beta but my build pipeline's handling of beta releases is a bit broken at the moment)

These changes actually do fix the issue for me. I'm using;
"vitest": "2.1.5",
"@fetch-mock/vitest": "0.2.4",
"@testing-library/dom": "10.4.0",
"@testing-library/jest-dom": "6.6.3",
"@testing-library/react": "16.0.1",

@RubenAWL What issue were you seeing exactly as I thought this discussion was only about cases when abort was used? Is there some other issue with readable streams that occur in a different scenario. If there is, would you mind opening another ticket with a description (and ideally a failing test or other runable example )

@RubenAWL What issue were you seeing exactly as I thought this discussion was only about cases when abort was used? Is there some other issue with readable streams that occur in a different scenario. If there is, would you mind opening another ticket with a description (and ideally a failing test or other runable example )

This case is also happening when the abort controller we use, aborts a fetch.
Without the suggested fix, I encounter the following error in a lot of our test files. This error looks quite similar to the error mentioned above, only the backtrace is a bit different.
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Unhandled Rejection ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
TypeError: Invalid state: ReadableStream is locked
 ❯ new NodeError node:internal/errors:405:5
 ❯ ReadableStream.cancel node:internal/webstreams/readablestream:331:9
 ❯ AbortSignal.abort node_modules/fetch-mock/dist/esm/Router.js:98:30
 ❯ AbortSignal.callTheUserObjectsOperation node_modules/jsdom/lib/jsdom/living/generated/EventListener.js:26:30
 ❯ innerInvokeEventListeners node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:350:25
 ❯ invokeEventListeners node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:286:3
 ❯ AbortSignalImpl._dispatch node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:233:9
 ❯ fireAnEvent node_modules/jsdom/lib/jsdom/living/helpers/events.js:18:36
 ❯ AbortSignalImpl._signalAbort node_modules/jsdom/lib/jsdom/living/aborting/AbortSignal-impl.js:65:5
 ❯ AbortControllerImpl.abort node_modules/jsdom/lib/jsdom/living/aborting/AbortController-impl.js:11:17

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 'ERR_INVALID_STATE' }
This error originated in "src/x/y/z.spec.js" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "Inserts copied values as a new .... (POST)". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.

Our project is using React components in which have an useAbortController hook . This hook always aborts when a component is unmounted, the fetch might have already finished or still be going and needing to be aborted.
We believe this issue comes up whenever the fetch succeeded already (mocked in the unit tests), a body-reader is already attached and abort is then called due to unmount in the test cleanup.
For context, we are migrating an existing application (incl tests) from "fetch-mock": "11.1.5" with jest to vitest with fetch-mock/vitest: v0.2.6 (fetch-mock 12.2.0) and did not have these issues before in the tests.


Module Apple Pay requires main queue

installed the package and shows this warning:

with code:
import * as React from 'react';
import { StyleSheet, View, Text, TouchableOpacity } from 'react-native';
import ApplePay, { MethodData, DetailsData, TransactionIdentifier } from "react-native-apple-payment";

export default function App() {
  const Method: MethodData = {
    countryCode: 'UA',
    currencyCode: 'UAH',
    merchantIdentifier: 'merchant.com.onipko',
    supportedNetworks: ['Visa', 'MasterCard', 'AmEx'],
  };

  const Options: DetailsData = {
    total: {
      label: 'Shoe-shop',
      amount: 10,
    },
  };

  const payment = new ApplePay(Method, Options);

  return (
    <View style={styles.container}>
      <TouchableOpacity
        onPress={async () => {
          const method: MethodData = {
            countryCode: 'UA',
            currencyCode: 'UAH',
            merchantIdentifier: 'merchant.ru-flat-sharing',
            supportedNetworks: ['Visa', 'MasterCard', 'AmEx'],
          };

          const details: DetailsData = {
            total: {
              label: 'Shoe-shop',
              amount: 10,
            },
          };

          const payment = new ApplePay(method, details);

          const canMakePayment: boolean = await payment.canMakePayments()

          if (canMakePayment) {
            const paymentResponse: TransactionIdentifier = await payment.initApplePay();
            console.log(paymentResponse);
          }
        }}
      >
        <Text>Apple Pay</Text>
      </TouchableOpacity>
    </View>
  );
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    alignItems: 'center',
    justifyContent: 'center',
  },
});

with code in App.tsx:
import * as React from 'react';
import { StyleSheet, View, Text, TouchableOpacity } from 'react-native';
import ApplePay, { MethodData, DetailsData, TransactionIdentifier } from "react-native-apple-payment";

export default function App() {
  return (
    <View style={styles.container}>
      <TouchableOpacity
        onPress={async () => {
          const method: MethodData = {
            countryCode: 'UA',
            currencyCode: 'UAH',
            merchantIdentifier: 'merchant.com.onipko',
            supportedNetworks: ['Visa', 'MasterCard', 'AmEx'],
          };

          const details: DetailsData = {
            total: {
              label: 'Shoe-shop',
              amount: 10,
            },
          };

          const payment = new ApplePay(method, details);

          const canMakePayment: boolean = await payment.canMakePayments()

          if (canMakePayment) {
            const paymentResponse: TransactionIdentifier = await payment.initApplePay();
            console.log(paymentResponse);
          }
        }}
      >
        <Text>Apple Pay</Text>
      </TouchableOpacity>
    </View>
  );
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    alignItems: 'center',
    justifyContent: 'center',
  },
});

also log console.log(paymentResponse); is empty on simulator, is this okay?

Hi, simulator cannot send you a paymentResponse
https://developer.apple.com/forums/thread/44972
About this warning, im not overrides method "init" in that library
(optional for examples) You can run "yarn bootstrap" in console, maybe problem in dependencies...
and can you say what a problem you have?
Did you get PaymentResponse?


GetValidator returns null for List in AspNetCore app

Hello,
I have an aspnet core web api.  In my startup.cs I am registering validation with a filters attribute as seen below:
            services.AddMvc(options =>
            {
                options.Filters.Add<ValidateModelAttribute>();
            }).AddFluentValidation();

The ValidateModelAttribute class overrides OnActionExecuting and inspects the incoming arguments.  It then attempts to use the AttributedValidatorFactory to get the fluent validator.  See the code below:
        public override void OnActionExecuting(ActionExecutingContext context)
        {
            var arguments = context.ActionArguments.Select(x => x.Value).Where(x => x != null).ToList();

            if (arguments.Count == 0 && !context.ModelState.IsValid)
            {
                GenerateErrorResponse(context);

                return;
            }

            foreach (var argument in arguments)
            {
                var argumentType = argument.GetType();
                var validator = GetValidator(argumentType);

                if (validator == null) continue;

                var validationResult = validator.Validate(argument);
                if (!validationResult.IsValid)
                {
                    GenerateErrorResponse(validationResult, context);
                }
            }
        }

        private IValidator GetValidator(Type type)
        {
            var validator = new AttributedValidatorFactory();
            return validator.GetValidator(type);
        }

I have a controller with code as follows:
        public async Task<IActionResult> Post([FromBody]List<MyRequest> request)
        {
            var result = await SomeTask();

            return ResultProcessor(result);
        }

Notice the request object is a List.  When the request is executed for this action the validator is never instantiated or hit at all.  I debugged the ValidateModelAttribute class in the OnActionExecuting method.  The line to GetValidator returns null.  I debugged further to the GetValidator method and the Type being passed in is a System.Collection.Generic.List.  The call to validator.GetValidator(type) returns null.  I have decorated the MyRequest object with the attribute [Validator(typeof(MyRequestValidator))].
Is there any way to get the List recognized for validation using the approach I have listed above?
Thanks.

First, that was the fastest response I've ever received when posting an issue; thank you.  Thanks for the info on the obsolete status of the AttributedValidatorFactory; I didn't realize that.  I switched over to using the service provider.  The validator is hit now when the request is sent.  However, if you notice in my controller above, I had no explicit if (!ModelState.IsValid) {} before.  It was all handled automatically in the ValidateModelAttribute class which was a VERY nice feature because I didn't need to clutter my controller with validation checks; they were automatically handled.  So...two questions, when using this approach is there a way to avoid having to explicitly check the model state in my controllers?  And two, I am using WithState in my rules to return a specific error object back to the client (see the code below).  Can that be used when implementing with the above approach you outlined?  I just tried it but am not getting back my custom error object.  Thank you.
                RuleFor(m => m.DateTo).NotEmpty()
                .WithState(s => new ServiceError
                {
                    Status = ((int)ErrorCodes.ValidationFailure).ToString(),
                    Code = ((int)ErrorCodes.DateToParameterMissing).ToString(),
                    Title = "Date to validation failed",
                    Detail = "Date to is required when a date from has been provided"
                });

Checking for ModelState.IsValid in the controller is the usual convention, and personally I'd recommend continuing to use it just because it makes the code clear to understand what's happening.
That being said, if you wanted to stick with the attribute approach I think you can. I might be misremembering, but I'm pretty sure that the automatic validation happens before filters run, so you can still do your check for ModelState.IsValid inside the filter as ModelState should have already been populated by this point.

Can that be used when implementing with the above approach you outlined?

No, unfortunately not. Anything in WithState is lost by the time ModelState has been populated. MVC does not provide an API for storing aribtrary/metadata in ModelState, only a message. The messy solution to this would be to encode all of the information you need in a message, and then split it out when creating your custom response, but that's definitely hacky.

Ok, unfortunately I have a requirement in my API that it need to return that specific object back to the client on validation errors.  So...I will stick with the attribute approach.  I will just add a custom check for the List request and hydrate the appropriate validator.  Thank you for your help.


Conda does not have the latest version

In the readme for installation I see it says:
mamba install -c conda-forge ipycytoscape

When I installed it I saw it was version 1.2.2 but on github I see 1.3.0 has been released.
Searching conda I found the package page:
https://anaconda.org/conda-forge/ipycytoscape
It looks like that is pointing to: https://github.com/QuantStack/ipycytoscape/
I see in the history there was a transfer of ownership to the cytoscape org.
I thought I would just point this discrepancy out since the readme shows conda-forge as a source for installation.

The link is actually ok because it redirects (or maybe because it pulls from pypi?) but the build failed due to some dependency issues. going to release one soon that should fix

sadly that did not fix it. there are other build issues :'( https://github.com/conda-forge/ipycytoscape-feedstock/pull/21

Super weird error.
Works on node 14, fails on 16, 17. I can kinda reproduce it locally but not sure what's causing it!
I asked a question in the conda-forge channel, in the meanwhile I'll try to fix it by sending another version bump... Let's see.
I'm thinking about just skipping v. 1.3.1 and 1.3.0 on conda-forge.

for future me to not click through the error logs. The relevant error is:
  npm ERR! While resolving<EMAIL_ADDRESS>  npm ERR! Found<EMAIL_ADDRESS>  npm ERR! node_modules/karma
  npm ERR!   dev<EMAIL_ADDRESS>from the root project
  npm ERR!
  npm ERR! Could not resolve dependency:
  npm ERR! peer karma@"1 || 2" from<EMAIL_ADDRESS>  npm ERR! node_modules/karma-typescript
  npm ERR!   dev<EMAIL_ADDRESS>from the root project
  npm ERR!

notably our karma-typescript (3.0.13) is pretty out of date - currently on 5.5.2
I wonder if updating that would solve the issue.

Yeah, the weird thing is that I tried locally and it worked for me.
But if I make X changes (idk which changes are) then, it doesn't work anymore.
I bumped the klarna versions and it's still working locally, just made a patch on conda-forge.

So that appraised the gods of the CI. I'm leaving it like that, because it was working on my computer regardless!
I just made a patch. I'll add a PR to change the package.json here too.
Thanks @ianhi 🌸


"Show variable and integer annotations" in [Settings]->[Rendering] does not work properly

Version and Platform (required):

Binary Ninja Version: 3.6.4600-dev Personal (d4486424)
OS: mac
OS Version: Sonoma
CPU Architecture: M1

Bug Description:
Show variable and integer annotations" in [Settings]->[Rendering] does not work properly.
Steps To Reproduce:
Please provide all steps required to reproduce the behavior:
poc.zip

Enable "Show variable and integer annotations" in [Settings]->[Rendering]
Generate binary. swiftc -Osize poc.swift
Analyze poc file
goto 0x100003eb4 in Disassembly window

Expected Behavior:
0x100003de4 should appear as add x9, x9, #0xf80 {"AAAAAAAAAAAAAAAA"}

The analysis actually tracks the value of register x9 correctly:
>>> current_function.get_reg_value_after(0x100003eb4, 'x9')
<const ptr 0x100003f80>

The reason that the result 0x100003f80 and the string are not annotated is that BN thinks the code is doing a series of arithmetic operations on the value, and it will only annotate the value at the end of it. We can see BN thinks the operations are complete at 100003ebc:
100003ebc  orr     x9, x9, #0x8000000000000000  {0x8000000100003f60}

The motivation for not including every intermediate value is we believe typically only the result of the last step is useful and we wish to avoid excessive annotations in the UI. For this case, could be add a setting to include all the result for all intermediate values?

Related to https://github.com/Vector35/binaryninja/issues/120


#60 Function abstracions

Promise next time I'll run the test first. Meanwhile can you check the concepts here @teh0xqb

Is there a way to link issues to PRs? just name them #60?

Is there a way to link issues to PRs?
@marcoslhc when you want the PR to automatically close the issue, set the last commit as "fixes #issue-number", or on the merge comment used to merge the branch (green buttton). If it has the "fixes#num" it will automatically close it. See https://help.github.com/articles/closing-issues-via-commit-messages

Not sure what you did that you ended up with +49 −56 ... only saved 7 lines! haha

Who's counting LOC's XD
There are some elements in the styling that adds for example the deconstructing of the arguments I use in some places are:
[{key1: arg1
   key2: arg2
   ...
}]

Things are running correctly right now. I'm changing the vars renamed (from camelCase to dashes). but I see that the travis build failed. (inconsistently.. not sure).

Check the travis build and tests:
https://travis-ci.org/Code-for-Miami/restaurant-inspections-api/jobs/207230027
At least the last version I checked has a lot of errors in the tests. no idea what's going on.

nvm about me fixing the camel case stuff. lets fix these tests first..

Should be good now. Recreate your copy of the branch (stash any changes first)


pifinder v2 on windows some issues on 'bootstrap' button click

@ladyada that bug was there just to test out auto updates :) if you restart the app, the update will be pulled and that should fix the issue.

cool works now!


apt::keyring doesn't validate key id

with the new method apt::keyring we can just pass an url which gets downloaded and stored to file directly without any checks.
In the old world of apt-key we could pass an id of a pub key and only if that id matches the key gets imported: https://github.com/puppetlabs/puppetlabs-apt/blob/main/lib/puppet/provider/apt_key/apt_key.rb#L182
In terms of security, it would be nice to:

check the id with the gpg command before importing it
support imports via the gpg command directly from keyserver again

How would you acquire the key ID to check against? Typically that is from the same source as the key itself, so I'm not sure this would enhance security very much. Such a check should be optional, at least.
About supporting imports from keyservers, since apt-key will last be available in Debian 12 and Ubuntu 24.04, I suppose we need to rewrite the apt_key provider in this module to manage keys as files, rather than using the apt-key command.

The optional check would be completely fine, just give the user the choice to choose if the want to check.

we need to rewrite the apt_key provider in this module to manage keys as files, rather than using the apt-key command.

:+1: makes sense, I guess its pretty hard to check the IDs with pure puppet.

How would you acquire the key ID to check against?

often the IDs are mentioned in the docs of the repo, for example elk: https://www.elastic.co/guide/en/elasticsearch/reference/current/deb.html#deb-key

How would you acquire the key ID to check against?

often the IDs are mentioned in the docs of the repo, for example elk: https://www.elastic.co/guide/en/elasticsearch/reference/current/deb.html#deb-key

Right, I'm just wondering if the extra verification would be serving a useful purpose. Since those docs and the key are from the same place, do you really gain security by providing the key ID to puppet and having puppet use GPG to check the ID? If someone can compromise the key, wouldn't they also be able to update key ID in the docs?

do you really gain security by providing the key ID to puppet and having puppet use GPG to check the ID?
if someone gained access to the reposerver/keyserver after I added the key and id to our puppet the key doesn't get updated with the infected key automatically. In my opinion a second factor is better than just blindly update the key automatically by puppet.


DateTime serialization format

There are DateTime and Date properties, but .NET doesn't have a separate Date type.
Different methods require different date/time serialization formats.
Perhaps even different DTO properties of the same API method.
Conflict: GetBranches/GetWarehouses and GetOutcomeDocuments/GetIncomeDocuments.
DateHandler.UnixTime works for GetBranches, but doesn't work for GetIncomeDocuments.
DateHandler.ISO8601DateTime works for GetIncomeDocuments, but not GetBranches.

Looks like BranchFilter and WarehouseFilter accept DateTime values formatted like this: 2020-04-24T21:01:40Z (ending Z symbol is mandatory).


Kafka Streams and Spring Cloud Stream Schema Registry

With the new header support in Kafka Streams, we can now use Spring Cloud Stream provided Schema Registry with the Kafka Streams binder (#456). However, one that is addressed, the downstream Kafka Streams topology still needs to use an Avro Serde that can talk to the Spring Cloud Stream Schema Registry. This means that we need to expose our internal schema registry based Avro converter wrapped inside a Serde.

Hi @sobychacko Will this approach allow the use of the avro SpecificRecordBase class or SpecificRecord interface to be used as the target class of the input binding and consequently allow the topology to handle different avro types from a single kafka topic (Binding Destination)?
This is probably out of scope for this PR but may be worth considering if an acceptable use case.

@maddenj-ie It should be possible to do what you are suggesting. Please try it out with the latest changes (the PR for this issue has just been merged). Closing this issue now, if you are still having problems with avro conversion, please raise another issue.


New version: Malwarebytes.Malwarebytes version <IP_ADDRESS>1

Pull request has been created with Komac v1.11.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

This package uses a vanity URL and has the same hash as the previous version. The previous version was also a duplicate of its previous version. Have the developers released the same package for 3 consecutive versions?

https://github.com/microsoft/winget-pkgs/pull/122087

This package uses a vanity URL and has the same hash as the previous version. The previous version was also a duplicate of its previous version. Have the developers released the same package for 3 consecutive versions?

New version: Malwarebytes.Malwarebytes version <IP_ADDRESS>6 #122087

Going to check what is set on my side, I might have something wrong here that is triggering a new update.

This package uses a vanity URL and has the same hash as the previous version. The previous version was also a duplicate of its previous version. Have the developers released the same package for 3 consecutive versions?

New version: Malwarebytes.Malwarebytes version <IP_ADDRESS>6 #122087

OK checked and this is actually correct. When installed it shows the new version of <IP_ADDRESS>1


[Bug] Storage reported as almost 100%

Description of the bug
I have three disks connected to my server (NUC8i3BEH): one for the system(/dev/sda, M.2 ATA SSD) and two for the data (2.5" Samsung SSD and external 3.5" Western Digital HDD). The system disks appear as full, whereas df shows only 4% usage (even when executed inside the docker container). However, information for both other disks is correct.
This sounds similar to #1032.

How to reproduce
No response
Relevant log output
Running `curl http://localhost:3001/info | jq`

{
  "os": {
    "arch": "x64",
    "distro": "Ubuntu",
    "kernel": "6.2.0-39-generic",
    "platform": "linux",
    "release": "23.04",
    "uptime": 3619225.61,
    "dash_version": "5.8.3",
    "dash_buildhash": "f7ac2728b89a6c75502c9c736c46a94ff386889b"
  },
  "cpu": {
    "brand": "Intel",
    "model": "Core™ i3-8109U",
    "cores": 2,
    "ecores": 0,
    "pcores": 2,
    "threads": 4,
    "frequency": 3.6
  },
  "ram": {
    "size":<PHONE_NUMBER>,
    "layout": [
      {
        "brand": "Crucial",
        "type": "DDR4",
        "frequency": 2667
      },
      {
        "brand": "Crucial",
        "type": "DDR4",
        "frequency": 2667
      }
    ]
  },
  "storage": [
    {
      "size":<PHONE_NUMBER>92,
      "disks": [
        {
          "device": "sda",
          "brand": "ATA",
          "type": "SSD"
        }
      ]
    },
    {
      "size":<PHONE_NUMBER>016,
      "disks": [
        {
          "device": "sdb",
          "brand": "Samsung",
          "type": "SSD"
        }
      ]
    },
    {
      "size":<PHONE_NUMBER>016,
      "disks": [
        {
          "device": "sdc",
          "brand": "External",
          "type": "HD"
        }
      ]
    }
  ],
  "network": {
    "interfaceSpeed": 1000,
    "speedDown": 0,
    "speedUp": 0,
    "lastSpeedTest": 0,
    "type": "Wired",
    "publicIp": ""
  },
  "gpu": {
    "layout": []
  }
}

# curl http://localhost:3001/load/storage
[510765391872,2986302857216,2582610644992]

### Info output of dashdot cli

```shell
INFO
=========
Yarn: 3.7.0
Node: v20.11.0
Dash: 5.8.3

Cwd: /app
Hash: f7ac2728b89a6c75502c9c736c46a94ff386889b
Platform: Linux 63117f0a668e 6.2.0-39-generic #40-Ubuntu SMP PREEMPT_DYNAMIC Tue Nov 14 14:18:00 UTC 2023 x86_64 Linux
Docker image: base
In Docker: true
In Docker (env): true
In Podman: false

### What browsers are you seeing the problem on?

Firefox

### Where is your instance running?

Linux Server

### Additional context

_No response_

I have the same error, dash run on docker on a synology NAS with 80% free space and it show 99,5%used...
this is the docker DF output from portainer:
/app # df
Filesystem           1K-blocks      Used Available Use% Mounted on
/dev/mapper/cachedev_0
74981076176<PHONE_NUMBER>6<PHONE_NUMBER>0  20% /
tmpfs                    65536         0     65536   0% /dev
tmpfs                 16320904         0  16320904   0% /sys/fs/cgroup
shm                      65536         0     65536   0% /dev/shm
/dev/md0               2385528   1634316    632428  72% /mnt/host
tmpfs                 16320904         0  16320904   0% /mnt/host/sys/fs/cgroup
devtmpfs              16283540         0  16283540   0% /mnt/host/proc/bus/usb
devtmpfs              16283540         0  16283540   0% /mnt/host/dev
tmpfs                 16320904<PHONE_NUMBER>0   0% /mnt/host/dev/shm
tmpfs<PHONE_NUMBER>         0<PHONE_NUMBER>   0% /mnt/host/dev/virtualization
tmpfs                 16320904     44324  16276580   0% /mnt/host/run
tmpfs                 16320904      2908  16317996   0% /mnt/host/tmp
/dev/mapper/cachedev_0
74981076176<PHONE_NUMBER>6<PHONE_NUMBER>0  20% /mnt/host/volume1
/dev/mapper/cachedev_0
74981076176<PHONE_NUMBER>6<PHONE_NUMBER>0  20% /mnt/host/volume1/@docker
/dev/mapper/cachedev_0
74981076176<PHONE_NUMBER>6<PHONE_NUMBER>0  20% /mnt/host/volume1/@docker/btrfs
/dev/mapper/cachedev_0
74981076176<PHONE_NUMBER>6<PHONE_NUMBER>0  20% /mnt/host/volume1/@docker/btrfs/subvolumes/6c2430a37f5792df426ae39dd5f319ac4005760a66af8c58c204c949d9044c18
tmpfs                    65536         0     65536   0% /mnt/host/volume1/@docker/btrfs/subvolumes/6c2430a37f5792df426ae39dd5f319ac4005760a66af8c58c204c949d9044c18/dev
shm                      65536         0     65536   0% /mnt/host/volume1/@docker/btrfs/subvolumes/6c2430a37f5792df426ae39dd5f319ac4005760a66af8c58c204c949d9044c18/dev/shm
tmpfs                 16320904         0  16320904   0% /mnt/host/volume1/@docker/btrfs/subvolumes/6c2430a37f5792df426ae39dd5f319ac4005760a66af8c58c204c949d9044c18/sys/fs/cgroup
none                 524288000 114259876 410028124  22% /mnt/host/volume1/ALi-Commerciale
none                 524288000  81498300 442789700  16% /mnt/host/volume1/ALi-Amministrazione
none<PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER>  60% /mnt/host/volume1/ALi-Produzione
none                 786432000<PHONE_NUMBER>23292   0% /mnt/host/volume1/PagaRent
/volume1/@ALi-Admin@<PHONE_NUMBER>6<PHONE_NUMBER>6<PHONE_NUMBER>0  20% /mnt/host/volume1/ALi-Admin
/dev/mapper/cachedev_0
74981076176<PHONE_NUMBER>6<PHONE_NUMBER>0  20% /etc/resolv.conf
/dev/mapper/cachedev_0
74981076176<PHONE_NUMBER>6<PHONE_NUMBER>0  20% /etc/hostname
/dev/mapper/cachedev_0
74981076176<PHONE_NUMBER>6<PHONE_NUMBER>0  20% /etc/hosts


Update instructions in the Convert JS to TS (in VS) article

Fixes issues: #317, #318, #319, and #320.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/convert-javascript-to-typescript.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@AlexJerabek thanks for the feedback! I've made some updates, per your feedback, so it's ready for you to take another look when you have a minute. Thanks again!

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/convert-javascript-to-typescript.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Treat expires_in 0 as not expired

Fix #1172

@jgrandja
here it is

Thanks for this fix @alatushkin. This is now in master.


Unable to create shape when snapping to a line in a locked layer.

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
Dragging in a new shape destroys the shape if snapped to a line on a locked layer.
To Reproduce

Unpack and open line_grid.zip
Select Worklayer as active layer
Drag a shape onto the page
Have the shape snap into a line
Drop the dragged shape

Expected behavior
The dropped shape is created.
Screenshots
https://www.youtube.com/watch?v=dSzb0hRh904
draw.io version:

13.0.3

Desktop (please complete the following information):

OS: Windows 10
Browser Chrome
83.0.4103.61 64-bit

Additional context
This only works for new shapes. Repositioning existing shapes does not allow to snap to lines.
Using ALT when dragging disables all snapping.
Associated feature request.

Reproduced in diagrams.net 13.10.2
A shape can be added to the editor when clicked in the sidebar or/and drag&dropped anywhere on canvas. The only problem is when it snaps to the grid line because it disappears.

Fixed in 14.8.6.


Support schema registry in DF

Need schema visualization and modification

This issue was moved to datafibers-community/df_data_service#6


Updated the documentation to include a sample where you add placeholder ...

...text to the people picker.

Hi @vverbeek, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@vverbeek, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Thanks Vincent!


SOLR-16847 Give v2 APIs access to solrconfig.xml config

https://issues.apache.org/jira/browse/SOLR-16847

Description
Please provide a short description of the changes you're making with this pull request.
Solution
Please provide a short description of the approach taken to implement your solution.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[x] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

A bit of a larger macro question: should this PR modify an existing v2 API/request-handler to implement APIConfigProvider as a way to validate (and exhibit) the approach? Or would that bloat the PR too much (because it'd involve converting a new API to JAX-RS?)

this was my original thought, but to avoid this growing too large I was thinking we can push this in and pickup some API that needs it next, so we can iterate if needed. I also made sure this works by adding a test to showcase the functionality.

I was thinking we can push this in and pickup some API that needs it next, so we can iterate if needed.

SGTM, as long as you or I remember to follow up on that 😛
This LGTM, gonna run tests this afternoon and look to merge!


Logging hypervisor instructions

Am I understanding this correctly, that this allows to also log hypervisor instructions? If so, is root access to the host or guest required?

Processor Trace supports recording root and non-root operation.  Permissions are checked by the driver that configures the PT MSRs.  You need to check with the driver you are using to record the trace.


Medtronic Direct checksum fix

Problem: In some instances, even requesting the same packets 5 times after getting a checksum mismatch, the pump still sends the exact same packets.
Solution:
It will retry 5 times, after which it will assume the data from the pump itself is corrupted. It will then just return the data it already has. Since the pump sends the newest data first, this means it will have all current data back to the date the data got corrupted, and all older (possibly corrupted) data will be ignored. This seems to be what CareLink does as well.

  Medtronic Alpha Test - Issue Resolution Card [uploader]

😂


WIP Fix canary tests

Feel free to hop on this PR and push up stuff @kitten and @mxstbr

@kitten how does this work? https://github.com/styled-components/styled-components/blob/0164a8d8122ffe5eaee7894851202231add1eac6/packages/styled-components/src/sheet/Rehydration.js#L25
I was trying to fix the SSR tests and was seeing some weird output in the style tags

@probablyup Regarding how the SSR output markers work;
`${SC_ATTR}.g${group}[id="${id}"]`

This is a group marker.
It contains the group's number (group ordering) and the component ID. It then also adds the group's names. It is inserted after a group/component's rules.
Compare this to what we had in v4:
`/* sc-component-id: ${id} */`

So in v4 we would inject a single comment before a group/component's rules. The names however were stored separately on the data-styled tag, where as now in v5 they're stored inside this group marker.
This allows us to use the CSSStyleSheet (i.e. speedy) API to rehydrate rules, which is much faster than parsing and traversing the rules manually with custom logic. We also save ourselves the need for a "stylis splitter" in this case.
Having the names non-globally also allows us to have more precise caching and being able to remove a group's names when the group is deleted, which is nice for global styles.
The group number in the new marker is also added so that we can rehydrate the ID to group number mapping.

@kitten would you mind taking a crack at those rehydration and ssr tests? Feeling lost even with that explainer TBH

@probablyup Done! :tada:

Woot! Let's get canary green 💚


DBLP import: revert change and throw abstract errors

Add the readers and writers to the edit that is posted in the process function so authors can see it
Don't catch the extract abstract errors so we are notified when the cloud function fails.

@carlosmondra @xkopenreview this PR should be ready to be merged!

We need to re-run the ProfileManagenment script, Celeste does it every time she does a new release.


[TRACKING] Falco config changes to support rules maturity framework

Feature
Summarizing outcomes discussed during the core maintainers meeting on 2023-08-03.
Support better configurability of loading and enabling rules based on tags in support of rules maturity framework.

[ ] Expose -t/-T functionality over falco.yaml
[ ] enabled: false shall override any rules loading mechanisms by tags filtering in order to be able to support loading rules from let's 3 tags for 3 maturity levels, but honoring that the adopter selectively disabled a couple of rules.
[ ] On the flip side let's discuss behavior for enabled: true when a rules does not have the respective tag? It should not be loaded hence for positive scenarios rules tags selection shall take precedence
[ ] add new / more unit tests for all of the above

Additional context

See Falco rules maturity framework implementation Phase 4 https://github.com/falcosecurity/rules/issues/126
Related to enhancements wrt to better override / merge configurability when redefining a rules YAML object https://github.com/falcosecurity/falco/pull/2671

@leogr and @LucaGuerra kindly asking to confirm all of the above. After that who would be the primary person working on it meaning the person who opens the PR?

Yep, I like the -t, -T from the config. Moreover, once we have it in the config we could just keep it and calling from command line with the -o flag so we can also deprecate the other -t, -T flags.
I think the other 2 points are related to this: https://github.com/falcosecurity/falco/issues/2631
I think that we need to find a better way than using -t, -T, -D. we have too many flags for doing the same thing: manipulate which syscalls are enabled and which are not. Probably a new fresh config could allow us to cleanup all these flag and have a more intuitive behavior.
And yes I think we need to move it to 0.37 since here we don't have a design, but is something that we really need to address in the next release

Agree with you @leogr and @Andreagit97.
Especially agree that the command line args -t, -T, -D seem less useful. I think falco.yaml is more powerful from a DevOps perspective and as @Andreagit97 pointed out, any config in falco.yaml can be passed as command line arg as well.
re the multiple rules files and maturity level tagging: For some adopters it may be easier to consolidate them in one rules file and btw what about custom rules that get a maturity level assigned? Therefore we should fully support filtering and rules loading mechanisms that do not depend on the rule file.
re the enabled: false let's discuss more in the next dev cycle. We need to check what has precedence under what scenarios. I would vote for the following: When a rule defines enabled: false nothing should override this, even if you filter for tags that includes a disabled rule it should still not be loaded and enabled.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale

I think that's been addressed by https://github.com/falcosecurity/falco/issues/3174 . @incertum if confirmed could you please close this?
/milestone 0.39.0

This has been actually addressed within :point_down:
/milestone 0.38.0

@leogr: The provided milestone is not valid for this repository. Milestones in this repository: [0.39.0, 1.0.0, TBD]
Use /milestone clear to clear the milestone.

In response to this:

This has been actually addressed within :point_down:
/milestone 0.38.0

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Package request: jdk17

Project description
openjdk 17 is General Availability now.
Metadata

homepage URL: https://openjdk.java.net/projects/jdk/17/
source URL: https://github.com/openjdk/jdk
license: gpl2
platforms: unix, linux, darwin, ...

Closing as duplicate of https://github.com/NixOS/nixpkgs/issues/137956


i18n Functions translations

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

/retest

/retest

/retest


Fix style in PixbufLoader

Resolves the changes discussed in #15.

Okay, I've reverted the changes to PixbufLoader::new(), but left the other two Result-returning functions intact.

Perfect ! Thanks !

Beside a small nit, :+1:

@gkoz: wo, you're really looking in detail ! However I agree, I find it more beautiful written like ptr::null_mut().
@jashephe: Can you update it please ? :-)

@GuillaumeGomez Sure, I'll fix it when I get home tonight.

Thanks !

@jashephe: When you update, please notify me. Unfortunately, github doesn't send notification when PR is updated... Everything's fine, I merge. Thanks !


Create A Readme ( Hangman - Java )

Location of the Document
You have to create a Readme for Hangman
What needs to be added
Create and Add details about the game.

Assign this to me.

Assign this to me


Add dynamic quotations for syntax categories

declare_syntax_cat mycat
syntax "mystx" : mycat
#check `(mycat| mystx)

Collateral change: macro "foo" : cat => `(bar) no longer defaults the rhs quotation parser to cat.  (I think that's good because the magic easily broke if you added a do e.g.)
macro "foo" : cat => return blah now enforces that blah has type TSyntax `cat.
Most of the specialized category quotation parsers (think `(attr| ...)) are gone.
I've also unified all the different parser name resolution functions.

See also https://leanprover.zulipchat.com/#narrow/stream/147302-lean4-maintainers/topic/Macro.20syntax/near/304524822
Future work:

Remove quotation parsers for command and tactic.  This is a bit tricky since the existing parsers are abused to parse multiple commands/tactics, resulting in invalid syntax (that breaks the pretty-printer).  I'd like to have a plan to handle that before doing further refactorings there.
Support parser aliases.  This is blocked by not being able to do IO in parsers at the moment.  (The aliases are stored in a global reference.)

There was an exciting stage3 failure here!  To fix it, I added another sanity check:

macro "foo" : cat => return blah now enforces that blah has type TSyntax `cat.

cc @Kha

Nice. I didn't want to do it before we had a solution for macro_rules as well, but I certainly don't mind.

Feel free to remove the changelog label if you want tow write a more detailed entry btw


Copy looking only at certain depth

Which version of the AzCopy was used?
Note: The version is visible when running AzCopy without any argument
10.22.2
Which platform are you using? (ex: Windows, Mac, Linux)
Linux
What command did you run?
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
azcopy copy "https://saalphabotsimulationbrs.blob.core.windows.net/simulation-data/production/morning/" "/dev/shm" --recursive=true --include-pattern "results.csv" --overwrite=ifSourceNewer
What problem was encountered?
results.csv is found at the root of the first folder for each folder inside the storage. Inside that folder, we have lots of folders with thousands of files. When I call this command, it takes a minimum of 10 minutes to start running as there are a lot of useless files that it is looking at.
results.csv is kinda like an aggregator for every folder inside it, putting all the necessary data into one singular file for faster processing.
How can we reproduce the problem in the simplest way?
Run a command to copy a single file in the following structure:
.
└── storage/
    ├── folder1/
    │   ├── thousands/
    │   ├── of/
    │   ├── folders/
    │   ├── .../
    │   └── results.csv
    ├── folder2/
    │   ├── lots/
    │   ├── more/
    │   ├── here/
    │   ├── .../
    │   └── results.csv
    └── folder3/
        ├── .../
        └── results.csv

See that, even though the file results.csv would be found at the root of the folders, azcopy has no way to know that, and keeps checking thousands of files in other folders.
Have you found a mitigation/solution?
A depth limitator for copy would suffice, ignoring all the folder's files and keep the command fast (in this case, --depth=2 or similar).
Other option would be to list all folders in a storage, ignoring files. With that, I could generate a command on the fly removing the folders from the check using --exclude-path and excluding every single folder (Not optimal but would work).

Unfortunately, we are not going to add this functionality.  We are focused on documentation, testing, and quality, and this feature would represent a large increase in scope for the product.


In Request.map, only map one time and store the result

def body = f(self.body) runs f() on every access to body
val body = f(self.body) runs f() only once

Thank you havoc. Merged.


Packager doesn't pick up created entry file

I'm building with webpack and so there's no index.ios.js initially, it's getting created after the first webpack build. If you run packager before index.ios.js was created, it will not pick it up.

What's the error?

Cabbot find entry file index.ios.js in any of the roots:...

@roman01la Try killing your terminal.

Is this resolved?
Please reopen if it's still a problem

+1
I started my project using CocoaPod and manually started the packager.
RobinQus-iMac:GrimmLaundryApp robin$ (JS_DIR=`pwd`/ReactComponent; cd Pods/React; npm run start -- --root $JS_DIR)

><EMAIL_ADDRESS>start /Volumes/Workspace/Projects/GrimmLaundry/pico/GrimmLaundryApp/Pods/React
> ./packager/packager.sh --root /Volumes/Workspace/Projects/GrimmLaundry/pico/GrimmLaundryApp/ReactComponent

 ===============================================================
 |  Running packager on port 8081.
 |  Keep this packager running while developing on any JS
 |  projects. Feel free to close this tab and run your own
 |  packager instance if you prefer.
 |
 |     https://github.com/facebook/react-native
 |
 ===============================================================

Looking for JS files in
   /Volumes/Workspace/Projects/GrimmLaundry/pico/GrimmLaundryApp/Pods/React
   /Volumes/Workspace/Projects/GrimmLaundry/pico/GrimmLaundryApp/ReactComponent

React packager ready.

flow: No suitable root
{ [NotFoundError: Cannot find entry file index.ios.js in any of the roots: ["/Volumes/Workspace/Projects/GrimmLaundry/pico/GrimmLaundryApp/Pods/React","/Volumes/Workspace/Projects/GrimmLaundry/pico/GrimmLaundryApp/ReactComponent"]]
  message: 'Cannot find entry file index.ios.js in any of the roots: ["/Volumes/Workspace/Projects/GrimmLaundry/pico/GrimmLaundryApp/Pods/React","/Volumes/Workspace/Projects/GrimmLaundry/pico/GrimmLaundryApp/ReactComponent"]',
  name: 'NotFoundError',
  type: 'NotFoundError',
  status: 404,
  errors:
   [ { description: undefined,
       filename: undefined,
       lineNumber: undefined } ] }
[2:44:23 PM] <START> request:/index.ios.bundle
[2:44:23 PM] <START> find dependencies
^CRobinQus-iMac:GrimmLaundryApp robin$ ls /Volumes/Workspace/Projects/GrimmLaundry/pico/GrimmLaundryApp/ReactCompont
index.io.js

However, the packager is working all right with projects created with CLI tool.

I'm having the same problem when integrating React as a CocoaPod following the instructions on the site (https://facebook.github.io/react-native/docs/embedded-app.html#content)https://facebook.github.io/react-native/docs/embedded-app.html#content

doh - My problem was my file was named index.io.js instead of index.ios.js.

+1

+1

still can't figure this out...

Restarting my terminal did this for me. Note that when it works properly, it opens up a second terminal window (React packager).


Make modal background transparent

Current
When clicked on any cell of sudoku to choose a number to fill-in, a modal opens up. Currently, it has a default white background

Expected
Need to set the background of that modal as transparent.

Hello, can you assign me to this issue ?

you can see the PR here https://github.com/Sarthak-Mittal/sudoku/pull/7 :)


Allow delegates to make transactions

Allow delegates to: SoloClose, Slash, ForceProgress (if already implemented), Snapshot (if already implemented)
~This is blocked by #755~

To implement this issue properly I need to write Delegates "role" handling. This makes the issue more complex than expected.


Preview deployment example with dependency caching

I've been following this article, but I realized that we can't simply leverage https://github.com/actions/cache because you can't write to the cache during deployment_status events.
Unsure of any workarounds.

https://github.com/actions/cache/issues/598

I suggest to close this issue. It may still be relevant, however it is not a github-action bug, more of a "how-to" question.

Since the discussions tab is unavailable... I could adjust this to be a feature request?
github actions seems entirely uninterested in adding caching to the specific lifecycle area of actions: https://github.com/actions/cache/issues/319
Without their action, is there anything the cypress github action can do to cache dependencies at any phase? Even if it's only for paying customers and it's like remote cache uploading...
As it stands, I can't justify moving any of my projects to this much more logical and easier-to-write flow because it runs so much slower.

@kylemh
I'm happy to mark this as an enhancement request. It needs investigation to check on the feasibility, as the action relies on     @actions/cache from the GitHub Actions toolkit for its dependency caching capabilities.

@kylemh
I took at look at the blog article Test the Preview Vercel Deploys that is based on a legacy version of Cypress and integrating with Vercel.
Does this issue still occur with current versions of Cypress and github-action? If yes, then logs would be helpful  in order to understand the issue better.

The blog post Test the Preview Vercel Deploys dated Aug 20, 2020 does not mention the caching restrictions in the demonstrated legacy setup although the restrictions would also have applied at the time of publication.
Unfortunately this enhancement request for Vercel deployment appears to not be compatible with the GitHub Actions caching mechanism, which assigns caches to branches (see Matching a Cache Key).
If the GitHub Actions deployment_status event is triggered by Vercel without a GITHUB_REF (see GitHub Default Environment Variable) then there is no branch reference available to work with a cache, so any cache actions fail.

https://github.com/vercel/vercel/discussions/7581 discusses this topic.

I suggest to close this request as not being feasible. If there are changes made on the Vercel side, it could be re-opened.

The changes I am seeking are irrelevant to Vercel. Vercel caching works well and automatically. I am interested in caching the dependencies related to the testing via the GitHub action.
Github seems uninterested in making the changes to allow for caching at the relevant life cycle point. I thought perhaps it could be an automatic aspect of this reusable action.

Understood


Constant Time

Hi,
The README file does not mention if the implementation is in constant-time, can you maybe shed some light on that matter?
Thanks

Ahoy hoy,
I'm assuming you are referring to the time-complexity? The AES block cipher is constant time, O(1). And each of the modes of operations run the AES block cipher O(n) times (where n is the length of data being encrypted/decrypted [in blocks]). So, the overall time complexity to encrypt or decrypt n bytes is O(n).
However, when speaking of cryptography, it is important to understand that constant-time is not protection against side-channel attacks. Specifically, since this implementation is written in JavaScript, it is important to understand timing attack. Due to garbage collection, caching, branch predicates and many other interesting optimizations, you may leak information inadvertently without careful use.
Does that make sense?

Hi @ricmoo
Yes it does, thanks for taking the time. 'Constant-time' was a bad description, I was thinking about side-channel attacks, yes. Thanks for the explanation.

No problem. :)


[BUG] Unnecessary permissions

Version of Eraser
1.3.1
Expected Behavior
The Deployment eraser-controller-manager in the charts has delete verb of the pods resource (eraser-manager-role-clusterrole.yaml). However, after reading the source code of eraser, I didn't find any Kubernetes API usages that require this permission.Therefore, for security reasons, I suggest checking this permission to determine if it is truly unnecessary. If it is, the issue should be fixed by removing the unnecessary permission or other feasible methods.
Actual Behavior
No response
Steps To Reproduce
Use helm chart with default values.
Are you willing to submit PRs to contribute to this bug fix?

[ ] Yes, I am willing to implement it.

Hi @Yseona thank you for raising this! Pod permissions were removed in #956. Since this was cherry-picked into v1.3.0 for a v1.3.1 patch release, the changes from manifest_staging/charts/.. were not reflected into charts/.... This will be fixed in the next minor release.
cc @sozercan

Suggest closing this issue if it is truly resolved.

@ashnamehrotra are you good to close this?

@sozercan yes, this can be closed now!


TypeError: init() got an unexpected keyword argument 'syntax' in http_pb2.py

From @alexandermichels on May 22, 2018 21:34
Hello, I'm trying to use Google Cloud's Text-To-Speech and I am getting this traceback when I try importing texttospeech from google.cloud. I installed the SDK using Google's Quickstart for Debian/Ubuntu and Python and the Python libraries using pip. I've tried upgrading using pip and still get this error, I've used the import in different Python scripts and get the same error, and I Googled around saw the problem might be protobuf so I uninstalled/reinstalled/upgraded and still getting the error. Any ideas?

runfile('/home/alex/Documents/GitHubRepositories/TitanRadio/WeatherWaves/WeatherReporter.py', wdir='/home/alex/Documents/GitHubRepositories/TitanRadio/WeatherWaves')
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python2.7/dist-packages/spyderlib/widgets/externalshell/sitecustomize.py", line 699, in runfile
execfile(filename, namespace)
File "/usr/lib/python2.7/dist-packages/spyderlib/widgets/externalshell/sitecustomize.py", line 81, in execfile
builtins.execfile(filename, *where)
File "/home/alex/Documents/GitHubRepositories/TitanRadio/WeatherWaves/WeatherReporter.py", line 5, in
from google.cloud import texttospeech
File "/usr/local/lib/python2.7/dist-packages/google/cloud/texttospeech.py", line 17, in
from google.cloud.texttospeech_v1beta1 import TextToSpeechClient
File "/usr/local/lib/python2.7/dist-packages/google/cloud/texttospeech_v1beta1/init.py", line 17, in
from google.cloud.texttospeech_v1beta1 import types
File "/usr/local/lib/python2.7/dist-packages/google/cloud/texttospeech_v1beta1/types.py", line 20, in
from google.api import http_pb2
File "/usr/local/lib/python2.7/dist-packages/google/api/http_pb2.py", line 22, in
serialized_pb=_b('\n\x15google/api/http.proto\x12\ngoogle.api"+\n\x04Http\x12#\n\x05rules\x18\x01 \x03(\x0b\x32\x14.google.api.HttpRule"\xea\x01\n\x08HttpRule\x12\x10\n\x08selector\x18\x01 \x01(\t\x12\r\n\x03get\x18\x02 \x01(\tH\x00\x12\r\n\x03put\x18\x03 \x01(\tH\x00\x12\x0e\n\x04post\x18\x04 \x01(\tH\x00\x12\x10\n\x06\x64\x65lete\x18\x05 \x01(\tH\x00\x12\x0f\n\x05patch\x18\x06 \x01(\tH\x00\x12/\n\x06\x63ustom\x18\x08 \x01(\x0b\x32\x1d.google.api.CustomHttpPatternH\x00\x12\x0c\n\x04\x62ody\x18\x07 \x01(\t\x12\x31\n\x13\x61\x64\x64itional_bindings\x18\x0b \x03(\x0b\x32\x14.google.api.HttpRuleB\t\n\x07pattern"/\n\x11\x43ustomHttpPattern\x12\x0c\n\x04kind\x18\x01 \x01(\t\x12\x0c\n\x04path\x18\x02 \x01(\tB'\n\x0e\x63om.google.apiB\tHttpProtoP\x01\xf8\x01\x01\xa2\x02\x04GAPIb\x06proto3')
TypeError: init() got an unexpected keyword argument 'syntax'

Copied from original issue: google/google-api-python-client#508

This doesn't appear to happen in a fresh install using a virtualenv from a checkout of the cloud api Python libraries:
$ virtualenv -p python2.7 env27
Running virtualenv with interpreter /home/chrism/bin/python2.7
Using real prefix '/home/chrism/opt/buildout.python/parts/opt'
New python executable in /home/chrism/projects/gcloud/google-cloud-python/texttospeech/env27/bin/python2.7
Also creating executable in /home/chrism/projects/gcloud/google-cloud-python/texttospeech/env27/bin/python
Installing setuptools, pip, wheel...done.
$ env27/bin/pip install .
Processing /home/chrism/projects/gcloud/google-cloud-python/texttospeech
Collecting google-api-core[grpc]<2.0.0dev,>=0.1.0 (from google-cloud-texttospeech==0.2.0)
  Downloading https://files.pythonhosted.org/packages/d2/03/a83c6d0efa63a13d085b81927fdc9e12ffb98aa0f67798a7573fc6b231e2/google_api_core-1.2.1-py2.py3-none-any.whl (50kB)
    100% |████████████████████████████████| 51kB 1.7MB/s
Collecting google-auth<2.0.0dev,>=0.4.0 (from google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/53/06/6e6d5bfa4d23ee40efd772d6b681a7afecd859a9176e564b8c329382370f/google_auth-1.5.0-py2.py3-none-any.whl
Collecting requests<3.0.0dev,>=2.18.0 (from google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/65/47/7e02164a2a3db50ed6d8a6ab1d6d60b69c4c3fdf57a284257925dfc12bda/requests-2.19.1-py2.py3-none-any.whl
Collecting pytz (from google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/dc/83/15f7833b70d3e067ca91467ca245bae0f6fe56ddc7451aa0dc5606b120f2/pytz-2018.4-py2.py3-none-any.whl
Collecting googleapis-common-protos<2.0dev,>=1.5.3 (from google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
Collecting protobuf>=3.0.0 (from google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/85/f8/d09e4bf21c4de65405ce053e90542e728c5b7cf296b9df36b0bf0488f534/protobuf-3.6.0-py2.py3-none-any.whl
Collecting futures>=3.2.0; python_version < "3.2" (from google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/2d/99/b2c4e9d5a30f6471e410a146232b4118e697fa3ffc06d6a65efde84debd0/futures-3.2.0-py2-none-any.whl
Collecting six>=1.10.0 (from google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/67/4b/141a581104b1f6397bfa78ac9d43d8ad29a7ca43ea90a2d863fe3056e86a/six-1.11.0-py2.py3-none-any.whl
Requirement already satisfied: setuptools>=34.0.0 in ./env27/lib/python2.7/site-packages (from google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0) (39.2.0)
Collecting grpcio>=1.8.2; extra == "grpc" (from google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/30/24/8e247548321e52c266a639b51a838ec19b41fb6bfd27e3bbef018496752e/grpcio-1.12.1-cp27-cp27m-manylinux1_x86_64.whl
Collecting cachetools>=2.0.0 (from google-auth<2.0.0dev,>=0.4.0->google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/0a/58/cbee863250b31d80f47401d04f34038db6766f95dea1cc909ea099c7e571/cachetools-2.1.0-py2.py3-none-any.whl
Collecting rsa>=3.1.4 (from google-auth<2.0.0dev,>=0.4.0->google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/e1/ae/baedc9cb175552e95f3395c43055a6a5e125ae4d48a1d7a924baca83e92e/rsa-3.4.2-py2.py3-none-any.whl
Collecting pyasn1-modules>=0.2.1 (from google-auth<2.0.0dev,>=0.4.0->google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Downloading https://files.pythonhosted.org/packages/19/02/fa63f7ba30a0d7b925ca29d034510fc1ffde53264b71b4155022ddf3ab5d/pyasn1_modules-0.2.2-py2.py3-none-any.whl (62kB)
    100% |████████████████████████████████| 71kB 4.9MB/s
Collecting idna<2.8,>=2.5 (from requests<3.0.0dev,>=2.18.0->google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/4b/2a/0276479a4b3caeb8a8c1af2f8e4355746a97fab05a372e4a2c6a6b876165/idna-2.7-py2.py3-none-any.whl
Collecting certifi>=2017.4.17 (from requests<3.0.0dev,>=2.18.0->google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/7c/e6/92ad559b7192d846975fc916b65f667c7b8c3a32bea7372340bfe9a15fa5/certifi-2018.4.16-py2.py3-none-any.whl
Collecting chardet<3.1.0,>=3.0.2 (from requests<3.0.0dev,>=2.18.0->google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/bc/a9/01ffebfb562e4274b6487b4bb1ddec7ca55ec7510b22e4c51f14098443b8/chardet-3.0.4-py2.py3-none-any.whl
Collecting urllib3<1.24,>=1.21.1 (from requests<3.0.0dev,>=2.18.0->google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/bd/c9/6fdd990019071a4a32a5e7cb78a1d92c53851ef4f56f62a3486e6a7d8ffb/urllib3-1.23-py2.py3-none-any.whl
Collecting enum34>=1.0.4 (from grpcio>=1.8.2; extra == "grpc"->google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/c5/db/e56e6b4bbac7c4a06de1c50de6fe1ef3810018ae11732a50f15f62c7d050/enum34-1.1.6-py2-none-any.whl
Collecting pyasn1>=0.1.3 (from rsa>=3.1.4->google-auth<2.0.0dev,>=0.4.0->google-api-core[grpc]<2.0.0dev,>=0.1.0->google-cloud-texttospeech==0.2.0)
  Using cached https://files.pythonhosted.org/packages/a0/70/2c27740f08e477499ce19eefe05dbcae6f19fdc49e9e82ce4768be0643b9/pyasn1-0.4.3-py2.py3-none-any.whl
Building wheels for collected packages: google-cloud-texttospeech
  Running setup.py bdist_wheel for google-cloud-texttospeech ... done
  Stored in directory: /tmp/pip-ephem-wheel-cache-e9R5co/wheels/83/8b/02/4d6581e531f8bc67cab81d2156564ba5158567d5da6da9e641
Successfully built google-cloud-texttospeech
Installing collected packages: cachetools, pyasn1, rsa, pyasn1-modules, six, google-auth, idna, certifi, chardet, urllib3, requests, pytz, protobuf, googleapis-common-protos, futures, enum34, grpcio, google-api-core, google-cloud-texttospeech
Successfully installed cachetools-2.1.0 certifi-2018.4.16 chardet-3.0.4 enum34-1.1.6 futures-3.2.0 google-api-core-1.2.1 google-auth-1.5.0 google-cloud-texttospeech-0.2.0 googleapis-common-protos-1.5.3 grpcio-1.12.1 idna-2.7 protobuf-3.6.0 pyasn1-0.4.3 pyasn1-modules-0.2.2 pytz-2018.4 requests-2.19.1 rsa-3.4.2 six-1.11.0 urllib3-1.23
$ env27/bin/python
Python 2.7.14 (default, Apr 17 2018, 14:00:59)
[GCC 7.3.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from google.cloud import texttospeech
>>>

This issue is slightly misfiled; I'm going to use the issue mover to move it to the google cloud platform repository issue tracker.

I had the same problem, the reason was the old version of protobuf lib. I uninstalled (via pip) and installed again to the latest version and it worked. Hope it will help.


Add return types to all functions

Right now we do not have return types for any functions, documentation could be improved if these were provided
http://www.sphinx-doc.org/en/stable/domains.html#info-field-lists

Is this done @Omkar20895 ?

Yes this is done. Thanks


Support HTTPlug 2.0 clients and PSR-18

This is a backwards compatible way of support PSR-18 and HTTPlug 2.0
FYI @gmponos

Yes.. this is how it must be done...  :)

@florianv and @Nyholm  we could apply this change even on v1, couldn't we?
I think master branch contains BC for v2. There is no branch for v1.
After this is merged the typehint from here must be removed and allow both clients @florianv are you ok with this?

Yes. This could be applied for every package consuming httplug v1. It is always safe.

Thanks @Nyholm :)
The branch for 1.x is located here https://github.com/florianv/exchanger/tree/1.x


CDC CPU usage high and initial scan is slow

What did you do?
CDC usage high and initial scan slow is seen

What did you expect to see?
initial scan should fast
What did you see instead?
CPU usage high and initial scan is slow.
Versions of the cluster
CDC version:
[release-version=v8.0.0-alpha] [git-hash=0424aba6e4861365ace73162b49e7c6d5ccda6b2]

I have tested with setting kv-client.advance-interval-in-ms = 0, but CPU usage still reaches 800%.

/severity major

Seems it's caused by small upstream min-ts-interval.


Zero value skipped

Zero valued cells should not be skipped.

Data file:
AMIS_Data.xlsx
Wikifier and property files:
amis.zip

fixed in eab5878