Update LaTeXiT to 2.8.1

Changes to a cask
Editing an existing cask

[x] Commit message includes cask’s name (and new version, if applicable).
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

You need to update the appcast
 - appcast checkpoint mismatch
Expected: b2acb7c6fa3a029c8711308da5b2bc6835fb878cfa1ec374159c4d7e2e69f3f2
Actual: 333bb3345415572bfd428d12d56afa026820c2bf13d3510160994911818962cc

Well, audit --download was working for me with the checksum.
 - appcast checkpoint mismatch
Expected: 333bb3345415572bfd428d12d56afa026820c2bf13d3510160994911818962cc
Actual: b2acb7c6fa3a029c8711308da5b2bc6835fb878cfa1ec374159c4d7e2e69f3f2

@reitermarkus I recently fixed how audit calculates the checkpoint, brew update and try again locally.

Did a rebase, didn't change anything.

Ah, it's because we're getting a 403 (Forbidden) HTTP return code:
audit for latexit: warning
 - unexpected HTTP response code retrieving appcast: 403
 - appcast checkpoint mismatch
Expected: b2acb7c6fa3a029c8711308da5b2bc6835fb878cfa1ec374159c4d7e2e69f3f2
Actual: 333bb3345415572bfd428d12d56afa026820c2bf13d3510160994911818962cc

And the actual text returned:
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">

<title>403 Forbidden</title>

Forbidden

You don't have permission to access /latexit/downloads/latexit-sparkle-en.rss
on this server.

Could this be a User-Agent issue? I'm able to view the RSS in the browser.

Stand-alone curl works for me:
$ curl -sI 'http://pierre.chachatelier.fr/latexit/downloads/latexit-sparkle-en.rss'
HTTP/1.1 200 OK
Date: Wed, 13 Jul 2016 12:26:37 GMT
Content-Type: application/rss+xml
Content-Length: 29909
Server: Apache
Last-Modified: Mon, 07 Sep 2015 21:20:41 GMT
Accept-Ranges: bytes
Age: 106043
Warning: 113 localhost (squid/3.5.12) This cache hit is still fresh and more than 1 day old
X-Cache: HIT from localhost
X-Cache-Lookup: HIT from localhost:3129
Via: 1.1 localhost (squid/3.5.12)
Connection: keep-alive

Yes, directly on my router I also get:
HTTP/1.1 403 Forbidden
Set-Cookie: mailplanBAK=R2555566638; path=/; expires=Thu, 14-Jul-2016 19:14:20 GMT
Date: Thu, 14 Jul 2016 17:56:34 GMT
Content-Type: text/html; charset=iso-8859-1
Set-Cookie: mailplan=R1919058564; path=/; expires=Thu, 14-Jul-2016 19:07:09 GMT
Server: Apache
Vary: Accept-Encoding

Yup, same for me:
$ curl -sI 'http://pierre.chachatelier.fr/latexit/downloads/latexit-sparkle-en.rss'
HTTP/1.1 403 Forbidden
Set-Cookie: mailplanBAK=R2555562282; path=/; expires=Thu, 14-Jul-2016 19:14:02 GMT
Date: Thu, 14 Jul 2016 17:55:29 GMT
Content-Type: text/html; charset=iso-8859-1
Set-Cookie: mailplan=R1919058564; path=/; expires=Thu, 14-Jul-2016 19:09:34 GMT
Server: Apache
Vary: Accept-Encoding

Not really sure what's going on there.

On a different note, please use https for the url and appcast.

We could try using this url https://pierre.chachatelier.fr/latexit/downloads/latexit-version-current, which is really nice of the developer to provide. =)

Ok, so we would need to be able to set :user_agent on an appcast stanza.

We don’t need user_agent: on appcast. That’s be useless since appcast isn’t directly interacted with, you’re supposed act on it via external means, so user_agent: would do nothing.
The only thing we need if for audit itself to fake the user agent. This porblem as surfaced before, and the correct command to calculate checkpoint does indeed include browser headers (see find_sparkle_appcast and cask-repair). Likely what happened is just that I forgot to update the documentation after fixing it in those scripts.

Verified locally as correct and passing.


swift package show-dependencies is failing after bumping to swift-syntax's prerelease

Is it reproducible with SwiftPM command-line tools: swift build, swift test, swift package etc?

[X] Confirmed reproduction steps with SwiftPM CLI. The description text must include reproduction steps with either of command-line SwiftPM commands, swift build, swift test, swift package etc.

Description
While bumping to swif-syntax's 600.0.0-prerelease-2024-06-12
with:
swift package --scratch-path <DERIVED_DATA_PATH> update 'swift-syntax'

I'm having an error while running:
swift package --scratch-path <DERIVED_DATA_PATH> show-dependencies --format json --output-path <OUTPUT_PATH>

My first hunch was if this is not due to semver tag name: 600.0.0-prerelease-2024-06-12, but I highly doubt since that looks.
I'm seeing that I have a package that targets 601.0.0-prerelease that I can't find as of today. Could that be the issue?
Thanks.
Expected behavior
I would expect that show-depencies run without an error and output a JSON file when we run:
swift package --scratch-path <DERIVED_DATA_PATH> show-dependencies --format json --output-path <OUTPUT_PATH>

Actual behavior
It's triggering an error and telling the user to open an issue in this Github repo.
I have a warning, though:
warning: 'swift-syntax': /path-to-derived-data/SourcePackages/repositories/swift-syntax-463e60c9 is not valid git repository for 'https://github.com/apple/swift-syntax', will fetch again.

And the error is:
error:
 InternalError(
    description:
    "Internal error. Please file a bug at https://github.com/apple/swift-package-manager/issues with this info. Expected root cause

    {   swift-syntax[everything] 509.0.0..<601.0.0, swift-perception[everything] 1.1.7..<2.0.0} to almost satisfy the current partial solution:
     * [Decision 0: sources[everything] 1.0.0]
     * [Derivation: xctest-dynamic-overlay[everything] 0.2.1..<10000.0.0 ← {sources[everything] 1.0.0,   xctest-dynamic-overlay[everything] 0.2.1..<10000.0.0}]
     * [Derivation: swift-snapshot-testing[everything] 1.11.1..<10000.0.0 ← {sources[everything] 1.0.0,  swift-snapshot-testing[everything] 1.11.1..<10000.0.0}]
     ...
     * [Derivation: swift-syntax[everything] 509.0.0..<601.0.0-prerelease ← {swift-snapshot-testing[everything] 1.16.2,
          swift-syntax[everything] 509.0.0..<601.0.0-prerelease}]
     ...
    ]
    ")

The omitted lines only contain other libs that don't depend on swift-syntax, but I can add them later if required.
Steps to reproduce

Bump swift-syntax to 600.0.0-prerelease-2024-06-12
Run swift package --scratch-path  show-dependencies
An error is triggered

Swift Package Manager version/commit hash
Swift Package Manager - Swift 5.10.0-dev
Swift & OS version (output of swift --version ; uname -a)
swift-driver version: <IP_ADDRESS> Apple Swift version 5.10 (swiftlang-<IP_ADDRESS> clang-15<IP_ADDRESS>)
Target: arm64-apple-macosx14.0
Darwin mac.local 23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:13:18 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T6030 arm64

Duplicate of #7643.


Fix cloud foundry deployment

Minor updates to deploy to cloud foundry

Codecov Report

Merging #133 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   79.26%   79.26%
=======================================
  Files          17       17
  Lines         979      979
=======================================
  Hits          776      776
  Misses        203      203

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 485567e...5b44ef7. Read the comment docs.

Superceded


VersionControlSystem: Limit the output of matching tags

There are projects with a lot of matching tags, so limit the output to
not spam the error report.

This change is

@haikoschol, does this scratch your itch, i.e. was this the message where you saw huge output?

Closing this as this was not the code that triggered the huge output issue, and having a huge number of matching tags is unlikely anyway.


Can you please add some new features?

I hope a double speed function can be added to the menu for saving GIFs

To be more expressive : can we have a "speed" toggle, that after a screenshot it's automatically saved in a folder and copied in the pastebin ?

@HYKQL-K Hello, can you explain your feature request? What do you mean by double speed?

Hello by double speed I mean that I can double the speed of the exported GIF, thus shortening the time of the GIF
---Original---
From: "Nicke @.>
Date: Sat, Sep 7, 2024 22:36 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [NickeManarin/ScreenToGif] Can you please add some new features?(Issue #1303)
@HYKQL-K Hello, can you explain your feature request? What do you mean by double speed?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


update link to new version of the tool

https://github.com/MicrosoftDocs/windows-itpro-docs/issues/5972#issuecomment-581356661

Hello @VLG17. Thank you for submitting this pull request. There is one little thing that must be fixed, though. GitHub doesn't support underscores in a file name. "dg_readiness_tool.md" must be renamed. "dg-readiness-tool.md" would work. I'll try to take a look at this later today, or route to someone on my team. But we can't merge this just yet.

Hmm, that is mildly surprising to me, at least when looking at the GitHub file name: https://github.com/MicrosoftDocs/windows-itpro-docs/blob/public/windows/security/identity-protection/credential-guard/dg_readiness_tool.md
Then again, I guess the docs.microsoft.com pages don't support that filename structure, as you said.

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

Hello @VLG17. Thank you for submitting this pull request. There is one little thing that must be fixed, though. GitHub doesn't support underscores in a file name. "dg_readiness_tool.md" must be renamed. "dg-readiness-tool.md" would work. We can't merge this just yet.

@denisebmsft I copied that file name from the article itself, so i don't understand why it's a problem, because it was already in the article and the reference was working fine. Should we then change all the .md references in the article containing underscores?

If so, you would need to change the GitHub repository file name as well and trusting that the file name change replicates to docs.microsoft.com, which would be less likely to be accepted (unless asked to do so by one of the MS Docs tech writers). Maybe the project manager (D. Simpson) could comment and recommend the best way to deal with that question.

Hello @VLG17. Thank you for submitting this pull request. There is one little thing that must be fixed, though. GitHub doesn't support underscores in a file name. "dg_readiness_tool.md" must be renamed. "dg-readiness-tool.md" would work. We can't merge this just yet.

@denisebmsft I copied that file name from the article itself, so i don't understand why it's a problem, because it was already in the article and the reference was working fine. Should we then change all the .md references in the article containing underscores?

@denisebmsft could you please help us with this?

@Dansimp @denisebmsft @DulceMontemayor - Would you be able to help review and address how we can get this PR merged? This is based on this https://github.com/MicrosoftDocs/windows-itpro-docs/issues/5972#issuecomment-588969536.
Thank you.
cc: @kenwith

Hello! I am working on this today. I realize that the filename was copied; however, it still won't work in GitHub. It might work in preview, but it will not work on the live site. I have cloned the working branch here and will rename the file that has the underscores, and then fix any broken links that causes. Then we will be able to merge this pull request. Stay tuned!


Wiki-links support

Links like this [[note]] or this [[some/dir/note]]
that goes to first founded markdown file with name node.md, for example ./some/dir/note.md
May be by using GitHub Actions or some Hugo hook or plugin.
Any recomendations?
This project based on Jekyll have this feature:
https://github.com/rgvr/simply-jekyll

Here is my current workaround, placed in single.html, replacing {{ .Content }}.
        {{$wikilinks := .Content | findRE "[\\[]{2}([A-Za-z0-9\\s]+)[\\]]{2}" }}
        {{$temp_content := $.Content}}
        {{range $wikilinks}}
            {{$match := "0"}}
            {{$page_title := . | strings.TrimPrefix "[[" | strings.TrimSuffix "]]" }}
            {{$human_title := humanize $page_title}}
            {{$lower_title := lower $page_title}}
            {{$title_array := (slice $page_title $human_title $lower_title)}}
            {{range first 1 (where site.Pages "Params.title" "in" $title_array)}}
                {{$temp_content = ($temp_content | replaceRE (printf "[\\[]{0,2}%s[\\]]{0,2}" $page_title) (printf "%s" .Permalink $page_title) )}}
                {{$match = "1"}}
            {{end}}
            {{if ne $match "1"}}
                {{$temp_content = ($temp_content | replaceRE (printf "[\\[]{0,2}%s[\\]]{0,2}" $page_title)  (printf "%s" $page_title ))}}
            {{end}}
        {{end}}
        {{$temp_content  | safeHTML}}

Here is my current workaround, placed in single.html, replacing {{ .Content }}.
        {{$wikilinks := .Content | findRE "[\\[]{2}([A-Za-z0-9\\s]+)[\\]]{2}" }}
        {{$temp_content := $.Content}}
        {{range $wikilinks}}
            {{$match := "0"}}
            {{$page_title := . | strings.TrimPrefix "[[" | strings.TrimSuffix "]]" }}
            {{$human_title := humanize $page_title}}
            {{$lower_title := lower $page_title}}
            {{$title_array := (slice $page_title $human_title $lower_title)}}
            {{range first 1 (where site.Pages "Params.title" "in" $title_array)}}
                {{$temp_content = ($temp_content | replaceRE (printf "[\\[]{0,2}%s[\\]]{0,2}" $page_title) (printf "%s" .Permalink $page_title) )}}
                {{$match = "1"}}
            {{end}}
            {{if ne $match "1"}}
                {{$temp_content = ($temp_content | replaceRE (printf "[\\[]{0,2}%s[\\]]{0,2}" $page_title)  (printf "%s" $page_title ))}}
            {{end}}
        {{end}}
        {{$temp_content  | safeHTML}}

Will it still require all the files to be in same folder (vault root)?
Does the project fulfil the role of Publish to an extent?

@DeemOnSecurity Any help. :)

I tried using the above method in another hugo theme and it worked fine.
If you have a folder named "posts" and another folder called "notes", and you replace {{ .Content }} by the above workaround in "layouts/posts/single.html", you can link all the posts and notes in both folders when you use wiki-links in any post in folder posts. If you also want to use wiki-links in folder notes, you should create a new single.html in "layouts/notes/" and do the same.
Since quartz is based on hugo blog it should work.

@DeemOnSecurity Any help. :)

I tried using the above method in another hugo theme and it worked fine.
If you have a folder named "posts" and another folder called "notes", and you replace {{ .Content }} by the above workaround in "layouts/posts/single.html", you can link all the posts and notes in both folders when you use wiki-links in any post in posts folder posts. If you also want to use wiki-links in notes folder, you should create a new single.html in "layouts/notes/" and do the same but I'm not sure about that.

@DeemOnSecurity Any help. :)

My layout is:
root
...
├── content
│   ├── notes
│   │   ├── ...
├── data
│   ├── ...
├── layouts
│   ├── 404.html
│   ├── _default
│   │   ├── ...
│   │   └── single.html
│   ├── ...
├── resources
│   └── ...
└── static
    ├── ...

I setup an autorun to use obsidian-export before uploading to github, which converts wiki links to relative paths. It works pretty well in my case.

I made a Python program to convert all wiki-links to markdown-relative link: https://github.com/trojblue/Obsidian-wiki-fix

@trojblue I use a similar workflow with obsidian-export.

I made a Python program to convert all wiki-links to markdown-relative link: trojblue/Obsidian-wiki-fix

I made a program that handles Wikilinks and noncompliant file names: (obsidian-quartz-sanitizer)[https://github.com/shinyben/obsidian-quartz-sanitizer]. It may be possible after more tinkering with this to ingest any Quartz-noncompliant vault and generate a Quartz-compliant one. This would potentially allow the person using Quartz to not have to change anything about their vault, which takes away a big chunk of barrier to entry, even not have to specify title: which can be generated from the filename

Finally implemented in https://github.com/jackyzha0/quartz/commit/c117e38899a7e122fb4dee87f5d091e654e0939f !!

Finally implemented in c117e38 !!

Nicely done!


chore: project addition by Mansi

Add a new project to the list
Please assign me this issue under GSSCO'23.
Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

@Mansi209aps We are not providing any labels for project additions as they are not associated with solving any issues.

This issue has been closed because it has not received any activity in the last few days


Drag and Drop - event "_options" value is always undefined

Context:

Browser: Chrome
Schedule-X version: 2.4.1

Describe the bug
When using Drag and Drop to update an event, the updated object does not include the "_options" values. It looks like when the event object is copied, the "_options" values are discarded.
Expected behavior
The entire object would be expected to be copied when dragging and dropping.
Screenshots
   callbacks: {      /**     * Is called when an event is clicked     * */     onEventClick(event) {       console.log(event);     },     /**      * Is called when an event is updated through drag and drop      * */     onEventUpdate(updatedEvent) {       console.log(updatedEvent);     },   } })
onEventClick() returned object

onEventUpdate() returned object

Things that could speed up the process

[ ] I can picture implementing at least parts of this fix
[ ] I believe I know how to do this, and am willing to implement the whole thing.
[ ] I have a Schedule-X premium license

Thanks for reporting!
Will add a new patch version


Solution Dev  - RS Schema

7/29/21 - Per LADOH, Precision will continue to work with them directly, as we are not ready to assist with reportables other than COVID at this present time.
Marking all additional tickets as "CLOSED."


[Pricing card. Add a service] User can choose negative value by using spinner in "Додати сервіс" menu

Environment: Google Chrome Версія 107.0.5304.88 (64-розрядна версія); Windows 10 Pro.
Reproducible: always.
Preconditions
The user should be logged in as a Super Admin
Go to https://www.testgreencity.ga/GreenCityClient/#/ubs-admin/tariffs
Main UBS menu - page 'Тарифи' should be opened.
Go to any existing card
Steps to reproduce

Click on "Додати послугу"
In fields "Об'єм", "Комісія", "Базова вартість" pay attention to spinner

Actual result
User have ability to choose negative value

Expected result
User have no ability to choose negative value
User story and test case links
E.g.: "User story #4428
Labels to be added
"Bug"

After  entering negative value in the  fields "Об'єм", "Комісія", "Базова вартість" error messages about the impossibility of entering a negative value doesn't appear.


route should assign correct model to controller on transition

ie, transition to agency/overview should make a request to agencies/{agency}/grants

half done for agencies, model is assigned to controller. need a selection mechanism and assignment of chosen


Do not resolve quarkus classpath if generate app model task is UP-TO-DATE

This change should improve build time a bit when quarkusGenerateAppModel tasks are UP-TO-DATE for no configuration cache case.
We try to avoid resolving quarkus classpaths by having only original classpaths as an input from which quarkus classpaths are calculated instead of quarkus classpaths themself.
In a build scan I still see that some quarkus configurations are resolved during configuration if quarkusGenerateAppModel is UP-TO-DATE, but these are pretty fast:

Compared to the version before where it was:

Hi @asodja, thank you very much!
I tested locally your changes and I got the same results, awesome job. I'm going to add a new variant in the performance experiment to include the results with the expectation of reducing the configuration time increase that we observed when comparing the proposal against main.

Results performance test with this approach(proposal 2):
Project rh-subscriptions
Clean build (100 iterations)

Incremental build (20 iterations)

Project nessie
Clean build (100 iterations)

Incremental build (20 iterations)

Notes:

With this approach we reduce the increase of the configuration time, great job
Execution time increases on incremental cacheable builds because we are invalidating the Quarkus task inputs of the serailized model.

What are the changes for incremental scenario?
I think we could improve some things, e.g. Quarkus model depends just on the resources files, so for local project dependencies we could request just LibraryElements.RESOURCES and have that as an input.
But maybe that is an idea that could be implemented by Quarkus developers or some contributor. :)


Windows Sensors Incorrect Path

Description
Windows Sensors fails to load. Introduced in #825
What Platform / OS are you running?
Windows
What version are you running?
v2.6.0-dev
Anything in the logs or a references that might be useful?
2021-09-19 22:59:37 error: GraphicsService - Error: Command failed with exit code 1: C:\snapshot\system-bridge\WindowsSensors\SystemBridgeWindowsSensors.exe {"gpu":true}
The system cannot find the path specified.

Additional information
No response

I have this while running Windows 11 insider preview build 22458, on 2.5.0. It was happening on earlier builds of W11 though.


New 1.6.0 release - reporting for duty!

Added support for mods for Winter Assault and Original.  That could be simplified in future releases
Added new Advanced Start Option - "/high /affinity 6". It sets priority to "High" and forces game to use only threads 2 and 3 for performance reasons.
A lot of code refactoring. That will help to maintain a healthy and readable code for any future contributors ;-)
DoW Mod Manager frame name now changes automatically according to Assembly Name

Oh this is nice! A merge request going down already 😀 . I also like those refactorings since nice readable code is always appreciated.
I will test this ASAP!

One thing I noticed is that when you launch the app from the wrong place you get 3 error windows. I think it would be better to have one error window that shows you all the issues that appeared when attempting to start the app.

Thanks - I'll fix that very soon!
On Sat, May 30, 2020 at 7:26 PM Dennis S<EMAIL_ADDRESS>wrote:

One thing I noticed is that when you launch the app from the wrong place
you get 3 error windows. I think it would be better to have one error
window that shows you all the issues that appeared when attempting to start
the app.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/7#issuecomment-636353723,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F3ZIDUXBGNCYVO4SL6TRUEXSJANCNFSM4NOLJIJQ
.

I see the typo. Thanks!
On Sat, May 30, 2020 at 7:43 PM Dennis S<EMAIL_ADDRESS>wrote:

@Fragjacker requested changes on this pull request.
Alright it looks pretty good so far. Spotted only a typo in the new
starting option:
[image: image]
https://user-images.githubusercontent.com/19975052/83333981-ca8f9d80-a2a3-11ea-9a47-51e65bbbe77e.png
I would change this line to Set to highest thread priority and CPU
affinity
Other then that it looks pretty solid!
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/7#pullrequestreview-421426787,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F32XNTC7L6OUUOVAVI3RUEZSJANCNFSM4NOLJIJQ
.

I found the reason for that - that happens because I don't use Form_Load()
event anymore.
I do so because Form constructor is easier to debug. But now what happens
is that all initialization methods are called - even if first one tries to
close the Application. I probably could do something about that but I
suggest to leave it as is for 1.6.0
In 1.6.1 I will make "user experience" more smooth :-)
On Sat, May 30, 2020 at 10:22 PM Igor Sandu<EMAIL_ADDRESS>wrote:

Thanks - I'll fix that very soon!
On Sat, May 30, 2020 at 7:26 PM Dennis S<EMAIL_ADDRESS>wrote:

One thing I noticed is that when you launch the app from the wrong place
you get 3 error windows. I think it would be better to have one error
window that shows you all the issues that appeared when attempting to start
the app.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/7#issuecomment-636353723,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F3ZIDUXBGNCYVO4SL6TRUEXSJANCNFSM4NOLJIJQ
.

I fixed the problem!
On Sat, May 30, 2020 at 10:55 PM Igor Sandu<EMAIL_ADDRESS>wrote:

I found the reason for that - that happens because I don't use Form_Load()
event anymore.
I do so because Form constructor is easier to debug. But now what happens
is that all initialization methods are called - even if first one tries to
close the Application. I probably could do something about that but I
suggest to leave it as is for 1.6.0
In 1.6.1 I will make "user experience" more smooth :-)
On Sat, May 30, 2020 at 10:22 PM Igor Sandu<EMAIL_ADDRESS>wrote:

Thanks - I'll fix that very soon!
On Sat, May 30, 2020 at 7:26 PM Dennis S<EMAIL_ADDRESS>wrote:

One thing I noticed is that when you launch the app from the wrong place
you get 3 error windows. I think it would be better to have one error
window that shows you all the issues that appeared when attempting to start
the app.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/7#issuecomment-636353723,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F3ZIDUXBGNCYVO4SL6TRUEXSJANCNFSM4NOLJIJQ
.

Nice! :-)
On Sun, May 31, 2020 at 1:42 PM Dennis S<EMAIL_ADDRESS>wrote:

@Fragjacker approved this pull request.
Alright all looks well now and approve-able for merging!
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/7#pullrequestreview-421482014,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F3Y3TH53AXEUMBH7B73RUIYBVANCNFSM4NOLJIJQ
.

I have a small request for you - make a new application screenshot for 1.6.0
My plans for 1.7.0:

Add a ModDownloader
Well, that's all! I think that would keep me busy for some time :-)

On Sun, May 31, 2020 at 4:34 PM Igor Sandu<EMAIL_ADDRESS>wrote:

Nice! :-)
On Sun, May 31, 2020 at 1:42 PM Dennis S<EMAIL_ADDRESS>wrote:

@Fragjacker approved this pull request.
Alright all looks well now and approve-able for merging!
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/7#pullrequestreview-421482014,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F3Y3TH53AXEUMBH7B73RUIYBVANCNFSM4NOLJIJQ
.

Uh that sounds cool, I always wanted to implement this! In fact there is still an unused coloration code that painted text orange in case it was marked as outdated so an user could easily see what needs to be updated. So how do you want to tackle the issues? As that is what has really hold me back to pursue this more. Stuff like:

Mods aren't hosted uniformly on a single page.
Pages like Moddb don't allow for direct FTP protocol downloads and Mediafire even does captchas
Version numbers in .module files may not be correct.
How will you know what is outdated and what not?
Where and how will you download the mods from?

I'd be really intrigued if you have found solutions for these problems.

Well... I know that this addition will be hard.
I will try to find some "hacky" way to handle this.
At worst scenario I will just open the Download page on ModDb. I know, that
is very cheap. But that will be the first step.
So my plan is:

Step 1 - just select the popular mod and ModDownloader will open the
Download page on ModDb. Still better than search for yourself :-)
Step 2 - select the popular mod and ModDownloader will download the mod
in some folder. Probably "Downloaded mods". User will have to unzip and
place it himself.
Step 3 - same as previous but mod will be unzipped and copied to the
right place. If mod is an executable - it will be launched.
Of course the second step will be the hardest.

On Mon, Jun 1, 2020 at 4:44 PM Dennis S<EMAIL_ADDRESS>wrote:

Uh that sounds cool, I always wanted to implement this! In fact there is
still an unused coloration code that painted text orange in case it was
marked as outdated so an user could easily see what needs to be updated. So
how do you want to tackle the issues? As that is what has really hold me
back to pursue this more. Stuff like:

Mods aren't hosted uniformly on a single page.
Pages like Moddb don't allow for direct FTP protocol downloads and
Mediafire even does captchas
Version numbers in .module files may not be correct.
How will you know what is outdated and what not?
Where and how will you download the mods from?

I'd be really intrigued if you have found solutions for these problems.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/7#issuecomment-636869080,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F3ZEELERZTXCAGCCS5DRUOWEBANCNFSM4NOLJIJQ
.

I see that you are developing 1.6.1 - that's a great news!
I will check it out when you will create a release tag. Also - you didn't
added the way for 'non-programmers' to get 1.6.0 :-)
About my progress:

There is a Top 25 mod list (added manually - no parsing for now)
You could select and download any mod (it will just create new tab in
your default browser and feed it the link)
You could also open the most popular mods on ModDB.com
Limitations:
The whole system is "dumb" - no parsing or any analysis.
It just downloads the mod itself - no additional patches.
There are only mods for Soulstorm (for now)
There are zero integration in DoW Mod Manager or Mod Merger - it just
starts and do it's thing. I will make it better.
So my plan is:
Make it download patches (using default browser)
Get "currentGameEXE" and show only mods for right DoW version (still
using default browser)
If all that would work - make system much smarter: parse popular mods
from ModDB and download it without using the browser.
As you can see, I very like the idea of "From simple solutions that just
work to more advanced".
I don't think that users would complain that "it's doing it unfair". I
think the only thing they care is that it makes downloading things easier.
And it does! Even in this prototype stage.

On Mon, Jun 1, 2020 at 8:14 PM Igor Sandu<EMAIL_ADDRESS>wrote:

Well... I know that this addition will be hard.
I will try to find some "hacky" way to handle this.
At worst scenario I will just open the Download page on ModDb. I know,
that is very cheap. But that will be the first step.
So my plan is:

Step 1 - just select the popular mod and ModDownloader will open the
Download page on ModDb. Still better than search for yourself :-)
Step 2 - select the popular mod and ModDownloader will download the mod
in some folder. Probably "Downloaded mods". User will have to unzip and
place it himself.
Step 3 - same as previous but mod will be unzipped and copied to the
right place. If mod is an executable - it will be launched.
Of course the second step will be the hardest.

On Mon, Jun 1, 2020 at 4:44 PM Dennis S<EMAIL_ADDRESS>wrote:

Uh that sounds cool, I always wanted to implement this! In fact there is
still an unused coloration code that painted text orange in case it was
marked as outdated so an user could easily see what needs to be updated. So
how do you want to tackle the issues? As that is what has really hold me
back to pursue this more. Stuff like:

Mods aren't hosted uniformly on a single page.
Pages like Moddb don't allow for direct FTP protocol downloads and
Mediafire even does captchas
Version numbers in .module files may not be correct.
How will you know what is outdated and what not?
Where and how will you download the mods from?

I'd be really intrigued if you have found solutions for these problems.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/7#issuecomment-636869080,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F3ZEELERZTXCAGCCS5DRUOWEBANCNFSM4NOLJIJQ
.

Yes, I forgot to make a release for 1.6.0 my bad, however the release for 1.6.1 should be up now 😀 .

As you can see, I very like the idea of "From simple solutions that just
work to more advanced".

I see you're a man of coding culture as well. Also I am completely fine with even the simplest Mod downloading feature because I always wanted to have this functionality in my tool anyways.
In fact the initial design was exactly what you have proposed here, to aid the user in finding the right mods they need, quickly and easy and update them if necessary.

Oh nice!
I wanted to make dropDown in ModMerger to not accept user input but didn't
make that change - I was too distracted by all improvements to Mod Manager.
I hope you are still recognizing your code after all my "improvements"? :-)
Also - I found a small bug: look inside "DoW Mod Manager.ini" after you
exit DoW Mod Manager. See?
That happens because you added a few spaces in those lines:
private void ModManagerForm_Closing(object sender, EventArgs e)
{
string str = $@"{CHOICE_INDEX}={settings[CHOICE_INDEX]}
{DEV}={settings[DEV]}
{NO_MOVIES}={settings[NO_MOVIES]}
{FORCE_HIGH_POLY}={settings[FORCE_HIGH_POLY]}
{OPTIMIZATIONS}={settings[OPTIMIZATIONS]}";
File.WriteAllText(CONFIG_FILE_NAME, str);
}
All those spaces are counted as inputs. That's because it's a combination
of Interpolated string ($) and a Verbatim string (@) -
https://stackoverflow.com/questions/33236592/multiline-c-sharp-interpolated-string-literal/33236672
the easiest fix would be:
private void ModManagerForm_Closing(object sender, EventArgs e)
{
string str = $"{CHOICE_INDEX}={settings[CHOICE_INDEX]}\n" +
$"{DEV}={settings[DEV]}\n" +
$"{NO_MOVIES}={settings[NO_MOVIES]}\n" +
$"{FORCE_HIGH_POLY}={settings[FORCE_HIGH_POLY]}\n"
+
$"{OPTIMIZATIONS}={settings[OPTIMIZATIONS]}";
File.WriteAllText(CONFIG_FILE_NAME, str);
}
Now you could indent it as much as you want to :-)
I like your changes in ModMerger! Also I have to be careful not to desync
too much from your version or we wouldn't be able to merge them.
On Tue, Jun 2, 2020 at 5:23 PM Dennis S<EMAIL_ADDRESS>wrote:

Yes, I forgot to make a release for 1.6.0 my bad, however the release for
1.6.1 should be up now 😀 .
As you can see, I very like the idea of "From simple solutions that just
work to more advanced".
I see you're a man of coding culture as well. Also I am completely fine
with even the simplest Mod downloading feature because I always wanted
to have this functionality in my tool anyways.
In fact the initial design was exactly what you have proposed here, to
aid the user in finding the right mods they need, quickly and easy and
update them if necessary.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/7#issuecomment-637575898,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F33OFBUSXDU4XQWZ4ITRUUDNVANCNFSM4NOLJIJQ
.

I have looked a bit deeper into that INI thing and was mildly shocked, that there is no native support for INI files in C#. I have found this article, which uses an existing Windows API for creating INI files:
https://www.codeproject.com/Articles/6034/INI-Class-for-NET
However overall it look like it is intended to use XML over INI files as that has native support in dotNET. For now however I will implemented your suggested fix above as a temporary fix. 😬

Thanks for the article!
There is no INI support because Microsoft don't want you to store any
settings in the same directory as your executable. The reason for that is
if you would store it in XML file in AppData\Local that would ensure that
every user will get it's own setting file.
It's a smart move... but I still like INI files :-) It's just SO much
simpler this way! For user AND for programmer!
Something tells me that you want to implement "a proper" INI support :-)
It's not a bad idea but to be honest it works already (even if you indent
it in some weird way or try to mess with it).
But I'm not against it.
About my progress... well I added a LOT of links manually (to download
mods) but those links turned to be temporary. So they all expired. Thanks,
ModDB! :-) So I'm working on a new (less lazy) solution.
And I have a small refactoring for your ModMerger! It's a little bit faster
AND cleaner!
Your old code are commented.
private void GetLoadableMods()
{
loadedModBox.Items.Clear();
        int modCount = modManager.AllValidModules.Count;
        string[] modsList = new string[modCount];

        for (int i = 0; i < modCount; i++)
        {
            modsList[i] = modManager.AllValidModules[i];
        }

        //int counter = 0;
        //foreach (string listBoxItem in modManager.AllValidModules)
        //{
        //    modsList[counter] = listBoxItem.ToString();
        //    counter++;
        //}

        loadedModBox.Items.AddRange(modsList);
    }

On Wed, Jun 3, 2020 at 2:30 PM Dennis S<EMAIL_ADDRESS>wrote:

I have looked a bit deeper into that INI thing and was mildly shocked,
that there is no native support for INI files in C#. I have found this
article, which uses an existing Windows API for creating INI files:
https://www.codeproject.com/Articles/6034/INI-Class-for-NET
However overall it look like it is intended to use XML over INI files as
that has native support in dotNET. For now however I will implemented your
suggested fix above as a temporary fix. 😬
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/7#issuecomment-638136741,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F33FUKFH63JJJATJMQ3RUYX3NANCNFSM4NOLJIJQ
.

Something tells me that you want to implement "a proper" INI support :-)
It's not a bad idea but to be honest it works already (even if you indent
it in some weird way or try to mess with it).

It's so far a mere Idea, since the way it works currently is kind of hacky and if we had the opportunity to use a proper system API, might as well use it. For now however I gonna keep it the way it is now, since I have other things to do 😛 .

About my progress... well I added a LOT of links manually (to download
mods) but those links turned to be temporary. So they all expired. Thanks,
ModDB! :-) So I'm working on a new (less lazy) solution.

Yes that is a real issue I have been running into as well. Back in the day I made an installer that was able to fetch data via the FTP protocol. It kinda worked nicely back in the day with Filefront since their links never expired and you could call it via FTW protocol so this was nice. Unfortunately Filefront shut down and moddb or mediafire don't support automated downloading 😢 .
So my idea would be to use some kind of definition file in XML format or whatever. This file contains the necessary information for the mod URL and version. At the start of the app you parse this file once. We could put this file here on the repo which would allow our app to fetch this data from this repo, to stay updated.

And I have a small refactoring for your ModMerger! It's a little bit faster
AND cleaner!
Your old code are commented.

Ah guess the foreach loop had a lot of overhead iterating over all the items 😛. Will you put this into a merge request?

I took a little break from DoW Mod Manager but I will continue it tomorrow.
And of course my small refactoring is already in the 1.7.X branch :-)
I will test a little bit of a different link (maybe it's not temporary but
I doubt it to be honest). After that I will probably try to do as you
suggested - will create some kind of file to store working links (when I
could generate or find them).
My next idea is to implement Game Settings Manager - basically a GUI to
change Local.ini file :-)
On Wed, Jun 3, 2020 at 6:50 PM Dennis S<EMAIL_ADDRESS>wrote:

Something tells me that you want to implement "a proper" INI support :-)
It's not a bad idea but to be honest it works already (even if you indent
it in some weird way or try to mess with it).
It's so far a mere Idea, since the way it works currently is kind of hacky
and if we had the opportunity to use a proper system API, might as well use
it. For now however I gonna keep it the way it is now, since I have other
things to do 😛 .
About my progress... well I added a LOT of links manually (to download
mods) but those links turned to be temporary. So they all expired. Thanks,
ModDB! :-) So I'm working on a new (less lazy) solution.
Yes that is a real issue I have been running into as well. Back in the day
I made an installer that was able to fetch data via the FTP protocol. It
kinda worked nicely back in the day with Filefront since their links never
expired and you could call it via FTW protocol so this was nice.
Unfortunately Filefront shut down and moddb or mediafire don't support
automated downloading 😢 .
So my idea would be to use some kind of definition file in XML format or
whatever. This file contains the necessary information for the mod URL and
version. At the start of the app you parse this file once. We could put
this file here on the repo which would allow our app to fetch this data
from this repo, to stay updated.
And I have a small refactoring for your ModMerger! It's a little bit faster
AND cleaner!
Your old code are commented.
Ah guess the foreach loop had a lot of overhead iterating over all the
items 😛. Will you put this into a merge request?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/7#issuecomment-638285418,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F3423R2IEYZDFFEFEUTRUZWMRANCNFSM4NOLJIJQ
.

I took a little break from DoW Mod Manager but I will continue it tomorrow.
And of course my small refactoring is already in the 1.7.X branch :-)
I will test a little bit of a different link (maybe it's not temporary but
I doubt it to be honest).

That's always a good idea to do 😁 .

After that I will probably try to do as you
suggested - will create some kind of file to store working links (when I
could generate or find them).

That is probably the only way so far, considering there's no central mod hub, that has them all. So making the app also be able to pull the latest changes from the Git repo to auto update itself would therefor really be nice.

My next idea is to implement Game Settings Manager - basically a GUI to
change Local.ini file :-)

This is also a nice idea to have indeed!

For the self auto updater using Github I found this useful article here: https://www.codeproject.com/Articles/5165015/AutoUpdate-A-GitHub-Enabled-autoupdater

Thanks for the article!

The downside is that user would see the advertisement. But ModDB needs some
money to run it so it's not THAT bad. It's on 1.7.X branch. I would release
it very soon.
1.8.X (Settings Manager) is in progress.
On Sun, Jun 7, 2020 at 4:05 PM Dennis S<EMAIL_ADDRESS>wrote:

For the self auto updater using Github I found this useful article here:
https://www.codeproject.com/Articles/5165015/AutoUpdate-A-GitHub-Enabled-autoupdater
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/7#issuecomment-640215895,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F32VQMDIGPPKOHDDIDTRVOGAZANCNFSM4NOLJIJQ
.


The Israel embassy move is in progress (?)

source:
http://www.independent.co.uk/news/world/middle-east/donald-trump-israel-embassy-jerusalem-tel-aviv-white-house-relocate-a7540661.html
not sure if applicable right now, since its still in talks and up in the air.

"We are at the very beginning stages of even discussing this subject"
Sounds in progress to me.


Improve diffing for Assoc trees

(Should perhaps wait until after #2 is resolved?)
At the moment, we have:
> log $ prettyPrintDelta $ diff (Map.fromFoldable [Tuple "a" 1]) (Map.fromFoldable [Tuple "b" 2])
<Map { -"a" +"b": -1 +2 }>

But
<Map { -("a": 1) +("b": 2) }>

would probably be better

Fixed by https://github.com/hdgarrood/purescript-debugged/commit/998c67e1148d196ff66fbf91ef7cd1c813fadb32


nixos/installer: remove nixos-option compat shim

It's been two years.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This was added in https://github.com/NixOS/nixpkgs/pull/129835, and has never been modified since.
It was introduced in order to fix this issue: https://github.com/NixOS/nixpkgs/pull/129696#issuecomment-877538207

Thank you very much for the background. I was so confused by this.


Provide user with more information when the "invalid modpack selected" message appears

This should also include the reason that it is invalid.

Decided against this. The error is exposed in the logs if needed for support and user's should be ideally selecting from the dropdown


"gvalid  length" compatible with only one parameter

Codecov Report

Merging #1268 (b2d3c7d) into master (5100e0e) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
- Coverage   69.12%   69.03%   -0.09%
==========================================
  Files         373      373
  Lines       26513    26514       +1
==========================================
- Hits        18328    18305      -23
- Misses       6649     6666      +17
- Partials     1536     1543       +7

Impacted Files
Coverage Δ

util/gvalid/gvalid_validator_rule_length.go
100.00% <100.00%> (ø)

os/gspath/gspath_cache.go
67.56% <0.00%> (-24.33%)
:arrow_down:

net/gtcp/gtcp_pool.go
34.84% <0.00%> (-4.55%)
:arrow_down:

os/gmutex/gmutex.go
94.59% <0.00%> (-2.71%)
:arrow_down:

net/gtcp/gtcp_conn.go
30.53% <0.00%> (-1.53%)
:arrow_down:

os/glog/glog_logger_rotate.go
71.85% <0.00%> (-1.49%)
:arrow_down:

container/gtree/gtree_avltree.go
92.49% <0.00%> (-1.08%)
:arrow_down:

container/gtree/gtree_redblacktree.go
87.47% <0.00%> (-0.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5100e0e...b2d3c7d. Read the comment docs.


Update dependencies

Codecov Report

Merging #35 (e91c081) into main (2bc2996) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   94.21%   94.21%
=======================================
  Files          55       55
  Lines        3146     3146
=======================================
  Hits         2964     2964
  Misses        129      129
  Partials       53       53

Impacted Files
Coverage Δ

codec/util_general_bytes.go
90.24% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


feat(toast): added mobile and responsive versions component

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

32 of 32 (100.0%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 79.722%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
8129

Relevant Lines:
9229

💛  - Coveralls


Card name subheader appearing below the field, instead of below the header

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): quality
Action Performed:
Prerequisite:
Members and company cards added in workspace , 8+ export options for card

Go to staging.new.expensify.com
Choose the workspace from settings
Click company cards >Card Details
Click on the card name

Expected Result:
Card name sub header appears below the header.
Actual Result:
Card name sub header appearing below the field, instead of below the header.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
![image - 2024-10-31T153213 662](https://github.com/user-attachments/assets/b4e16a77-ca9c-4945-8b77-8653dc4d22c1)

View all open jobs on GitHub

BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Handling this as part of the project I have worked on

Hello, Im Artem from Callstack and would like to help with this issue!

Confirming payment here. I can see a review from @DylanDylann in https://github.com/Expensify/App/pull/52005, but not from @dukenv0307.
@mountiny mind confirming the roles here for me?

@bfitzexpensify  No need payment

BugZero Checklist:

[ ] [Contributor] Classify the bug:

Bug classification

Source of bug:

[ ] 1a. Result of the original design (eg. a case wasn't considered)
[ ] 1b. Mistake during implementation
[ ] 1c. Backend bug
[ ] 1z. Other:

Where bug was reported:

[ ] 2a. Reported on production
[ ] 2b. Reported on staging (deploy blocker)
[ ] 2c. Reported on both staging and production
[ ] 2d. Reported on a PR
[ ] 2z. Other:

Who reported the bug:

[ ] 3a. Expensify user
[ ] 3b. Expensify employee
[ ] 3c. Contributor
[ ] 3d. QA
[ ] 3z. Other:

[ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:

[ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:

[ ] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:

Regression Test Proposal
Precondition:

Test:

Do we agree 👍 or 👎

Gotcha. OK, regression steps look good and I've proposed them in https://github.com/Expensify/Expensify/issues/444105, so let's close this out.


Add nullability annotations to header files

Many of use use this in Swift-based apps, and Bolts' Obj-C header files would interplay much more safely with Swift code if they included the necessary nullability annotations.
See:
https://developer.apple.com/swift/blog/?id=25

Agreed! And we have nullability annotations for everything at Parse
The tricky part here is that all of our types are implicitly unwrapped optionals, which means that when converted to actual optionals might cause a breaking change in our API, specifically in Swift.
Will look into it, and it generally just makes sense to finally do it, even if it's breaking.

:+1:


Running eslint against only changed files

Hi there,
I'm looking to integrate this into my company's workflow but we have already got quite far down the road without good linting and this is something that we would like to change over time. However when I use this, I get all the lint errors and not just the ones from the Pull request. I couldn't see any option to do this, but I believe I could write one.
Before I go ahead and write one and make a PR, I'd just like to make sure that this is something you would be happy with as it will take up quite a bit of my time.
Thanks

Hi David, thank you for your interest in working on the action. Though, this request is a duplicate of #47. Please check out the comments there and the related PR #46 which probably needs a new owner.


Simplify NavBar on Hover Effect

Reference
Use the Underline Stoke Effect

@smaranjitghose  I would like to work on this as a part of LGMSoC.

@geniusbharti yes , you can work on it.

@geniusbharti updates?

@aliya-rahmani working on it.

@geniusbharti do make a PR soon


can't filter project by name using GET /projects

harbor v1.1.2
i create a project named rule, and i use swagger and cmdline to test the api, but both way are failed .

[root@localhost harbor]# curl -u admin:Harbor12345 -X GET http://<IP_ADDRESS>/api/projects?name=rule
[
{
"project_id": 2,
"owner_id": 1,
"name": "base",
"creation_time": "2017-08-30T06:14:26Z",
"creation_time_str": "",
"deleted": 0,
"owner_name": "",
"public": 1,
"Togglable": true,
"update_time": "2017-08-30T06:14:26Z",
"current_user_role_id": 1,
"repo_count": 1
},
{
"project_id": 1,
"owner_id": 1,
"name": "library",
"creation_time": "2017-08-30T06:13:43Z",
"creation_time_str": "",
"deleted": 0,
"owner_name": "",
"public": 1,
"Togglable": true,
"update_time": "2017-08-30T06:13:43Z",
"current_user_role_id": 1,
"repo_count": 0
},
{
"project_id": 7,
"owner_id": 1,
"name": "rule",
"creation_time": "2017-08-30T08:04:47Z",
"creation_time_str": "",
"deleted": 0,
"owner_name": "",
"public": 0,
"Togglable": true,
"update_time": "2017-08-30T08:04:47Z",
"current_user_role_id": 1,
"repo_count": 0
}

The query should be "project_name" in Harbor v1.1 .

it works when i use project_name to query, is this only a bug for v1.1.2? which to use in v1.2? thanks @ywk253100
[root@localhost harbor]# curl -u admin:Harbor12345 -X GET --header 'Accept: application/json' 'http://<IP_ADDRESS>/api/projects?project_name=rule'
[
{
"project_id": 7,
"owner_id": 1,
"name": "rule",
"creation_time": "2017-08-30T08:04:47Z",
"creation_time_str": "",
"deleted": 0,
"owner_name": "",
"public": 0,
"Togglable": true,
"update_time": "2017-08-30T08:04:47Z",
"current_user_role_id": 1,
"repo_count": 0
}

@fffffreedom why you think it's a bug?

Closing the issue, feel free to reopen it.

yes @reasonerjt


deleted 2 lines mentioned during lecture

were these the two lines mentioned during lecture?

Need to be reviewed because of coverage decrease

dataclean.py not passing coverage


Question: Use Electron

Currently Gekko launches in the browser.
I'm interested to know if folk would be interested in having gekko launch as a standalone native app?
If so I should be able to set aside some time to work on making that happen :)

Hey Spen! Very interesting idea. Some thoughts from my perspective:

Gekko should be as approachable as possible, this includes a nice setup/installation flow & a nice UI. Electron provides both of these (major pain point for non technical users right now).
I'm thinking more and more about security and the electron would be a lot more secure (since it doesn't run in a browser context with shady plugins).
However some power users only run Gekko in commandline environments (rasppi's, servers), but it would make the most sense to offer a "UI version" and a barebone node app (right now the one git repo includes core node app + frontend source + compiled frontend <- we should really fix this).
Though I also have some worries regarding maintainability (as most active contributors don't have experience with electron, including me).

Note: I'm actively working on a new UI written in React, I guess that doesn't matter too much in regards of wrapping (but no idea). This time properly designed by Andrea (also at Dojo few months back).

Note: I'm actively working on a new UI written in React

Music to my ears!

Can we simply only wrap 1 and have the other things installed when the electron app is installed?

Sure thing! I've been working on my own automation experiment with a UI that launches in Electron. It essentially has a node process running all of the logic and a render process (UI) the two communicate by emitting events back and forth :)
I'll give it a try this weekend to see if I can get a rough version working and heavily comment it to give you and anyone else interested a basic intro into Electron :)

That would be insane! If you need any help figuring out what gekko needs
and such let me know. But see the installation doc should provide the
details.
Also note (not sure if this is relavant) that starting a gekko (with --ui)
starts the webserver server which is old and currently in koa1 (generators)
& a websocket server. Planning on porting that to koa2 (async/await) soon.
No idea how electron works, but the frontend files can be served by
anything while it is important the frontend can connect to the API server.
This is now managed through the UIconfig.js (see doc on "configuring gekko
on a server" under installation). In the react version I am planning on a
UI based wizard that persists API location in localStorage (should be
easier for electron as well I am guessing).
Ps. I send you an e-mail.
On 27 Jul 2018 18:34, "Spen Taylor"<EMAIL_ADDRESS>wrote:
Note: I'm actively working on a new UI written in React
Music to my ears!
Can we simply only wrap 1 and have the other things installed when the
electron app is installed?
Sure thing! I've been working on my own automation experiment with a UI
that launches in Electron. It essentially has a node process running all of
the logic and a render process (UI) the two communicate by emitting events
back and forth :)
I'll give it a try this weekend to see if I can get a rough version working
and heavily comment it to give you and anyone else interested a basic intro
into Electron :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/askmike/gekko/issues/2370#issuecomment-408380481, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA7MD_GCQtGwtyQ02gAoayOPw9G835Kfks5uKuyagaJpZM4VimfK
.

Let me know if you run into any problems.
Here is the dev build of the new UI: https://gp.mvr.me/
In the process of cleaning up the code, will push react code to github once
done.
On Fri, Jul 27, 2018 at 6:49 PM, Mike van Rossum<EMAIL_ADDRESS>wrote:

That would be insane! If you need any help figuring out what gekko needs
and such let me know. But see the installation doc should provide the
details.
Also note (not sure if this is relavant) that starting a gekko (with --ui)
starts the webserver server which is old and currently in koa1 (generators)
& a websocket server. Planning on porting that to koa2 (async/await) soon.
No idea how electron works, but the frontend files can be served by
anything while it is important the frontend can connect to the API server.
This is now managed through the UIconfig.js (see doc on "configuring gekko
on a server" under installation). In the react version I am planning on a
UI based wizard that persists API location in localStorage (should be
easier for electron as well I am guessing).
Ps. I send you an e-mail.
On 27 Jul 2018 18:34, "Spen Taylor"<EMAIL_ADDRESS>wrote:
Note: I'm actively working on a new UI written in React
Music to my ears!
Can we simply only wrap 1 and have the other things installed when the
electron app is installed?
Sure thing! I've been working on my own automation experiment with a UI
that launches in Electron. It essentially has a node process running all of
the logic and a render process (UI) the two communicate by emitting events
back and forth :)
I'll give it a try this weekend to see if I can get a rough version
working and heavily comment it to give you and anyone else interested a
basic intro into Electron :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/askmike/gekko/issues/2370#issuecomment-408380481, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA7MD_GCQtGwtyQ02gAoayOPw9G835Kfks5uKuyagaJpZM4VimfK
.

--
PGP key at keybase.io/mikevanrossum
https://keybase.io/mikevanrossum/key.asc

The main trouble I've had is with proper async messaging between the renderer and main process - Might have to put it on hold until I've figured it out some more :/


Remove namespace param from remaining manager calls

Part of FIR-12
Follow-on to #864
This removes "namespace" as a param to remaining manager methods (since each manager is already assigned to a single namespace) and adds "namespace" as a param to most database queries (since all queries should be scoped to a single namespace).

Codecov Report

Merging #875 (b7877cd) into main (2d0dbb9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%
==========================================
  Files         300      300
  Lines       19507    19483      -24
==========================================
- Hits        19501    19477      -24
  Misses          5        5
  Partials        1        1

Impacted Files
Coverage Δ

internal/apiserver/routes.go
100.00% <ø> (ø)

internal/broadcast/manager.go
100.00% <ø> (ø)

internal/orchestrator/data_query.go
100.00% <ø> (ø)

...ternal/apiserver/route_delete_contract_listener.go
100.00% <100.00%> (ø)

internal/apiserver/route_delete_subscription.go
100.00% <100.00%> (ø)

internal/apiserver/route_get_chart_histogram.go
100.00% <100.00%> (ø)

...ternal/apiserver/route_get_contract_api_by_name.go
100.00% <100.00%> (ø)

...rnal/apiserver/route_get_contract_api_interface.go
100.00% <100.00%> (ø)

...rnal/apiserver/route_get_contract_api_listeners.go
100.00% <100.00%> (ø)

internal/apiserver/route_get_contract_apis.go
100.00% <100.00%> (ø)

... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0dbb9...b7877cd. Read the comment docs.


Area of a trapezoid

Title of article
Write a Java program that to compute area of trapezoid
Area of a trapezoid = ( base 1 + base 2 ) * height / 2
Example:
Base 1 = 5, Base 2 = 10, Height = 7
Area of the trapezoid = (5+10)*7/2 = 52.5
Additional information
Base 1 : 5
Base 2 : 10
Height  : 7

Area : 52.5

Code of Conduct

[X] I have read and agree to the Codinasion project's Code of Conduct

@harshraj8843 I'll give this a shot if you'd like. Did you just need a single class or a whole package? Also, should I just branch off main?

Hey @Anzo52
Thanks for contributing to this project 😃

Did you just need a single class or a whole package?

A single class

should I just branch off main?

You can create new branch from master
👍🏻

@harshraj8843 Alrighty, I started a PR...I think I messed up somewhere in the flow though.

Just move TrapezoidArea.java to programme/area-of-trapezoid


switch from arc4random to pg_strong_random

Recent PostgreSQL versions do not have arc4random function. This patch replaces arc4random with pg_strong_random. Witout this patch; startup of PostgreSQL is failed with error  undefined symbol: arc4random.
PS: Got code/idea from https://github.com/tanglebones/pg_tuid

Thanks @derkan.


Please consider provide a step-by-step video on how to install it...

Hello,
Would you please make a step-by-step video on how to install it... I believe people are interested in trying and using this tool but stuck on installation. I can't seem to find any more information on installation other than the README. But it's not detailed enough for some new users to even get started....
Thanks,

I was also having some problems following the instruction.
Special thanks to @monajalal for sharing the following link in her #1 post.
https://youtu.be/sx6_vxOv7n8?t=77
I hope you find the video as helpful as me. At least now I am seeing the extension UI.


Create a representative example that can be used for the website and readme

The website and the README need to show code examples that are actually representative to how the library is actually used. It is not often that the test uses the HttpClient directly.
It could be a good idea to base the example on the documentation of Microsoft with regards to how the HttpClient is used.

TestableHttpClient.Sample repository was created.


Finetune taiyi 报错：subprocess.CalledProcessError: Command '['which', 'c++']' returned non-zero exit status 1.

我用下面的方式安装了模型，然后调用/Fengshenbang-LM/fengshen/examples/finetune_taiyi_stable_diffusion/finetune.py来试图训练本地模型，出现了报错，不知道是否是需要进行额外的配置？

!git clone https://github.com/IDEA-CCNL/Fengshenbang-LM.git
%cd Fengshenbang-LM
!git init
!git clone https://github.com/IDEA-CCNL/fs_datasets.git fengshen/data/fs_datasets
!pip install --editable .

报错信息：
Loading folder data from /workspace/train_data/part_0.
Done loading data. Len of images: 1031
--------warning no checkpoint found--------, remove args
/opt/conda/lib/python3.9/site-packages/pytorch_lightning/trainer/connectors/accelerator_connector.py:446: LightningDeprecationWarning: Setting Trainer(gpus=1) is deprecated in v1.7 and will be removed in v2.0. Please use Trainer(accelerator='gpu', devices=1) instead.
rank_zero_deprecation(
Loading DeepSpeed config from set PL_DEEPSPEED_CONFIG_PATH environment variable
GPU available: True (cuda), used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
HPU available: False, using: 0 HPUs
/opt/conda/lib/python3.9/site-packages/pytorch_lightning/trainer/configuration_validator.py:106: UserWarning: You passed in a val_dataloader but have no validation_step. Skipping val loop.
rank_zero_warn("You passed in a val_dataloader but have no validation_step. Skipping val loop.")
initializing deepspeed distributed: GLOBAL_RANK: 0, MEMBER: 1/1
Missing logger folder: ../../workspace/taiyi-stablediffusion-1B/lightning_logs
calculate consumed samples: 0
Total steps: 10310
LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0]
Using ../../workspace/torch_extendsions as PyTorch extensions root...
Traceback (most recent call last):
File "/workspace/Fengshenbang-LM/fengshen/examples/finetune_taiyi_stable_diffusion/finetune.py", line 166, in
trainer.fit(model, datamoule, ckpt_path=args.load_ckpt_path)
File "/opt/conda/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 582, in fit
call._call_and_handle_interrupt(
File "/opt/conda/lib/python3.9/site-packages/pytorch_lightning/trainer/call.py", line 36, in _call_and_handle_interrupt
return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs)
File "/opt/conda/lib/python3.9/site-packages/pytorch_lightning/strategies/launchers/subprocess_script.py", line 90, in launch
return function(*args, **kwargs)
File "/opt/conda/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 624, in _fit_impl
self._run(model, ckpt_path=self.ckpt_path)
File "/opt/conda/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 1042, in _run
self.strategy.setup(self)
File "/opt/conda/lib/python3.9/site-packages/pytorch_lightning/strategies/deepspeed.py", line 369, in setup
self.init_deepspeed()
File "/opt/conda/lib/python3.9/site-packages/pytorch_lightning/strategies/deepspeed.py", line 480, in init_deepspeed
self._initialize_deepspeed_train(model)
File "/opt/conda/lib/python3.9/site-packages/pytorch_lightning/strategies/deepspeed.py", line 513, in _initialize_deepspeed_train
optimizer, lr_scheduler, _ = self._init_optimizers()
File "/opt/conda/lib/python3.9/site-packages/pytorch_lightning/strategies/deepspeed.py", line 486, in _init_optimizers
optimizers, lr_schedulers, optimizer_frequencies = _init_optimizers_and_lr_schedulers(self.lightning_module)
File "/opt/conda/lib/python3.9/site-packages/pytorch_lightning/core/optimizer.py", line 180, in _init_optimizers_and_lr_schedulers
optim_conf = model.trainer._call_lightning_module_hook("configure_optimizers", pl_module=model)
File "/opt/conda/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 1305, in _call_lightning_module_hook
output = fn(*args, **kwargs)
File "/workspace/Fengshenbang-LM/fengshen/examples/finetune_taiyi_stable_diffusion/finetune.py", line 56, in configure_optimizers
return configure_optimizers(self, model_params=model_params)
File "/workspace/Fengshenbang-LM/fengshen/models/model_utils.py", line 58, in configure_optimizers
optimizer = FusedAdam(
File "/opt/conda/lib/python3.9/site-packages/deepspeed/ops/adam/fused_adam.py", line 73, in init
fused_adam_cuda = FusedAdamBuilder().load()
File "/opt/conda/lib/python3.9/site-packages/deepspeed/ops/op_builder/builder.py", line 403, in load
return self.jit_load(verbose)
File "/opt/conda/lib/python3.9/site-packages/deepspeed/ops/op_builder/builder.py", line 435, in jit_load
op_module = load(
File "/opt/conda/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1284, in load
return _jit_compile(
File "/opt/conda/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1508, in _jit_compile
_write_ninja_file_and_build_library(
File "/opt/conda/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1597, in _write_ninja_file_and_build_library
get_compiler_abi_compatibility_and_version(compiler)
File "/opt/conda/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 336, in get_compiler_abi_compatibility_and_version
if not check_compiler_ok_for_platform(compiler):
File "/opt/conda/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 290, in check_compiler_ok_for_platform
which = subprocess.check_output(['which', compiler], stderr=subprocess.STDOUT)
File "/opt/conda/lib/python3.9/subprocess.py", line 424, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
File "/opt/conda/lib/python3.9/subprocess.py", line 528, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['which', 'c++']' returned non-zero exit status 1.

看起来貌似是没有c++编译器的样子，   可以看一下g++版本吗


Feature/footer component

@aselbie @nlitwin please let me if anything can be improved here.
Please note, the component, does not support showing the other nav items into primary menu yet because of the reason described here. Repeating the comment from asana:
If we try to maintain the current behaviour for mobile, it would be tightly coupled to the primary nav because current implementation assumes that on mobile, these other navigation items would be visible at certain place(997px) from the top. In fact that is hiding 'Blog' menu item from the Community heading.

For the social icons, we should be able to use just one .svg file per social icon now (not desktop/mobile versions), since we aren't using them as background images anymore. We can inline then in the html code or include them as a React component, passing in height, width, and even fill. See for reference here: https://github.com/appirio-tech/topcoder-app-r/blob/dev/src/icons/LevelDesignatorIcon.jsx and used here: https://github.com/appirio-tech/topcoder-app-r/blob/32fb5bd7037cdf7b4a74e2596c3ec2fcfc5b9283/src/components/MemberItem/UserInfo.jsx

Hey @vikasrohit, I took the MenuBar as an example and had a number of small suggestions that seemed like they would be easier to communicate as a PR. Take a look at https://github.com/appirio-tech/react-components/pull/39.

You are already calling handleResize in componentWillMount will mount, so we don't need to set the mobile property on the state. Then if we move the bind to the the other methods we can remove the constructor entirely.
Destructuring for the props in render
Favor const over let
Using the classNames module
Breaking the list items into their own function rather than nesting them inside the <ul>
Using computed (dynamic) property names on objects to work with the orientation class name
Handled the orientation using a default prop and the PropTypes.oneOf() property to do enum values

Let me know if you have any questions or concerns about these techniques and changes.

Thanks @aselbie for the bulleted items. I have cross checked and found the footer component following all of them. Actually, it is a stateless functional component, hence, using more concise pattern as suggested by React docs.

@nlitwin Thats really good idea. However, when I tried to do the same with social icons, I found that we have different Path elements for different view. In other words, icons for the desktop and mobile are not differentiated by width,height,fill or stroke, rather they are differentiated by the Path. Does it make sense to use if-else block for handling that or adjust the icons such that they have same Path and differ only in terms of width,height,fill or stroke. @vic-appirio Need your help here.

@nlitwin I tried to extract the social icons as component, however, somehow they are not scaling well with the width/height set. Can you please check what piece i am missing here?

Current state of footer for non mobile view:

Current state of footer for mobile view:

Hmm it might be the viewbox. I think you can just leave it as the default. For the most part, I pretty much just changed this width={ width || '20px' } height={ height || '20px' } I think that's all we need

I'm also just adding the 'px' in the props, so we don't have to declare new variables <DefaultUserAvatarIcon width={'60px'} height={'60px'}/>

Ohk. I thought I need to use width and height for setting the view box. And now it makes more sense to use 'px' in the width/height attributes because we don't need them for setting up the viewBox. Thanks Nick.


How do you evaluate .el files from a github repo?

I am struggling to install htmlz-mode. The package needs to be simply evaluated. It's a single .el file. That's it.
If you could please tell me how to do it that would save me literal hours!
I'm using doom emacs, which has a wrapper macro:
(package! htmlz-mode
  :recipe (:host github :repo "0xekez/htmlz-mode"))

This doesn't work. This doesn't tell you why it doesn't work. This consumes your very essence of being... (no logs, no warnings, nothing...)
If someone could please point me how to debug this type of problems that would be probably even better, because there is NO documentation as of 2023.

Please see the explanation I gave here: https://github.com/radian-software/straight.el/issues/1091#issuecomment-1560186384
I understand you are frustrated, but please refrain from opening multiple issues and using them to voice your frustrations.


Improve Debian/Ubuntu build instructions

Issue
Debian/Ubuntu instructions didn't work and it was not clear how to get installed and used ghc 8.6.5

This does not result in breaking changes to upstream dependencies.

Checklist

[x] The work has sufficient tests and/or testing.

[x] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

Again this should just be a single commit, with a better commit title.

I pulled these changes into https://github.com/input-output-hk/cardano-node/pull/718
Closing this.


Android cross compilation

Part of solution for https://github.com/servo/servo/issues/3030

This change is

@bors-servo r+

:pushpin: Commit deba44d has been approved by mbrubeck

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

testing
Previously, bors-servo wrote…
> :pushpin: Commit deba44d has been approved by `mbrubeck`
>
>

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

:bulb: This pull request was already approved, no need to approve it again.

@jdm Do you have a special trick to get @bors-servo to test and merge PRs on this fontsan repo?

I do not. I'm not sure what's up.

:hourglass: Testing commit deba44d with merge 859c190...

:sunny: Test successful - travis


Add support for PodSecurityPolicy on Elastic Helm Charts

Describe the feature:
It'd be great if support for PodSecurityPolicies could be added in the Elastic Helm charts for those of us who need such security requirements enabled.
Describe a specific use case for the feature:
My organization uses the old public helm charts for filebeat and metricbeat. I was looking to update these references to use the ones from these repos but they appear to be lacking PodSecurityPolicy support like the old version had (example) so I am forced to use the old unmaintained versions.
I could fork the repo and add this myself but I'd rather not maintain it. I'd even be willing to add this feature myself if I could get input from the maintainers. If there's a way to do handle this PodSecurityPolicy that I have somehow overlooked in these charts please let me know.

Hi @asreich,
PodSecurityPolicies are currently supported by Elasticsearch (https://github.com/elastic/helm-charts/blob/master/elasticsearch/templates/podsecuritypolicy.yaml) and Logstash (https://github.com/elastic/helm-charts/blob/master/logstash/templates/podsecuritypolicy.yaml) but not the other charts.
A PR to add it for other charts in the same way that what is currently done for Elasticsearch and Logstash would be awesome 👍

still valid

Sorry been busy, looking into this now thanks.

still valid


Update Gradle wrapper and Android Gradle plugin

This updates Gradle wrapper to 4.2.1 and the Android Gradle plugin to 3.0.0-beta7.

Hey, thanks for your contribution. How come binary files are included in this commit?
I think this should be the diff:
$ git diff
diff --git a/.travis.yml b/.travis.yml
index 922fbe3..1c7da0a 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -8,7 +8,7 @@ android:
- tools
 # The BuildTools version used by your project

build-tools-25.0.2

build-tools-26.0.2

The SDK version used to compile your project

android-25
diff --git a/app/build.gradle b/app/build.gradle
index 60bb7c8..5ae97e2 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -18,7 +18,6 @@ project.ext {

android {
compileSdkVersion 25

buildToolsVersion "25.0.2"
defaultConfig {
applicationId "com.example.offline"
minSdkVersion 16
diff --git a/build.gradle b/build.gradle
index 39c0b9a..71f483a 100644
--- a/build.gradle
+++ b/build.gradle
@@ -3,7 +3,7 @@
buildscript {
ext {

   androidGradlePluginVersion = '3.0.0-alpha5'

   androidGradlePluginVersion = '3.0.0-beta7'
   roomVersion = '1.0.0-alpha4'

}

diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties
index 2095e49..c46adda 100644
--- a/gradle/wrapper/gradle-wrapper.properties
+++ b/gradle/wrapper/gradle-wrapper.properties
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
-distributionUrl=https://services.gradle.org/distributions/gradle-4.1-milestone-1-all.zip
+distributionUrl=https://services.gradle.org/distributions/gradle-4.2.1-all.zip

@jshvarts Hey, thanks for the comment and sorry for not checking Travis CI earlier!
To answer your questions:
The Gradle wrapper was updated by invoking the standard task
gradle wrapper --gradle-version 4.2.1 --distribution-type=all

This is why the build shell scripts were updated to the latest version as well. If you run this command locally, you will also notice that the binary .jar file will change every time you run the command (the reason is most likely that an internal timestamp keeps changing).
I amended the PR to include the update to build-tools 26.0.2 - Waiting for Travis to report back.
Thanks!!

I added one more commit that replaces compile with implementation. It is the new way of declaring compile time dependencies. It was change with the new Android Gradle plugin and does the same exact thing.
It will get rid of this warning:
Configuration 'compile' in project ':app' is deprecated. Use 'implementation' instead.

Awesome, thanks for clarifyng about gradlew.
Could you execute ./gradlew clean assembleDebug check in the branch to perform lint, checkstyle, pmd, findbugs checks after these changes? I should really integrate this custom clean task as part of travis CI build or at least document contribution guidelines :)

I did execute ./gradlew clean assembleDebug check and everything passes without any errors.
I'm not sure what you mean by "this custom clean task". Did you mean check? It is easy to make Travis run the check task as well.
By default, Travis runs ./gradlew build connectedCheck, I added another commit to make it run ./gradlew build check instead (there are no tests for connectedCheck in this project anyway). I think it makes sense to also run check on Travis as well 👍

D'oh, I just realized: check is already a dependency of build - meaning it was running on Travis all along! I removed the commit again. Sorry for the confusion ;)

I see! Sorry for the confusion--I did not know that check is already executed!!!
By custom check I meant that I bundled more steps to include in the check task in https://github.com/jshvarts/OfflineSampleApp/blob/master/config/quality.gradle:
// Add checkstyle, findbugs, pmd and lint to the check task.
check.dependsOn 'checkstyle', 'findbugs', 'pmd', 'lint'

Will merge now! Thanks :)


Add dependencies of Nuplan to setup.py

Like hydra and nuplan.
Also update README and docs on how to install these dependencies.

Should we provide different installation options for users? NuPlan has too many dependencies and requires Python3.9. I remember that you can install a lib like pip install metadrive[nuplan]. Do you know how to do this?

I know. That’s what I expectBest,ZhenghaoOn Feb 10, 2023, at 15:02, Quanyi Li @.***> wrote:
Should we provide different installation options for users? NuPlan has too many dependencies and requires Python3.9. I remember that you can install a lib like pip install metadrive[nuplan]. Do you know how to do this?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


Gulp watch and new html views

Hello, I an new to gulp and every tine I add a new folder in angular/app like:
angular/app/mymodule/index.html
angular/app/mymodule/mymodule.js
gulp watch doesn't  update the app, I have to stop it, and do again gulp && gulp watch, and it takes some tome to do gulp, so this is slowing me down, how can I add new "modules" for my app and make "gulp watch" really acknowledge them

Can you try updating your dependencies?
Run npm install and try again
Let me know if it works for you

npm install and every file I add in that folder will be updated?
On Fri, Oct 9, 2015 at 1:25 PM, Jad Joubran<EMAIL_ADDRESS>wrote:

Can you try updating your dependencies?
Run npm install and try again
Let me know if it works for you
—
Reply to this email directly or view it on GitHub
https://github.com/jadjoubran/laravel5-angular-material-starter/issues/76#issuecomment-146954494
.

npm install so we can make sure you have the latest version of Elixir & gulp.
After that, creating a new fever should be automatically picked up by the watcher
Let me know if it works for you

@jfhernandeze is the issue happening when you run artisan ng:feature test for example?

@jadjoubran I've seen this issue as well but haven't had time to investigate it yet. As far as I know everything is up to date as it can be.

@mtdavidson thanks for sharing!
So for example if you run artisan ng:feature test and then change and trigger a change in any of the generated files, gulp wouldn't recognize these changes?

I can confirm that this is not working when I have gulp watch running. If I run artisan ng:feature test the new test folder (and its components) will not be picked up by the watcher

I found the issue:
Gulp watch https://github.com/floatdrop/gulp-watch/issues/104
references an issue in Gaze
https://github.com/shama/gaze/issues/84
The only solution for now, would be to relative paths instead of absolute paths.
I wasn't able to fix that a few months ago because of the defaults of Laravel elixir (which was in version 2 at that time).
I will try to fix the elixir.json file in order to get rid of absolute paths.

I tried getting rid of absolute paths and it still doesnt' work.. I also cleared my npm cache, cleared my node modules and re-installed (using npm 3)
Maybe anyone has an idea?

Is this still an issue?

Unfortunately, yes :disappointed:

@jadjoubran I think you could use gulp-watch it does not have this problems if you want I could help implementing this.

@kujtimiihoxha oh nice.. and all the elixir tasks will keep on working as expected? 😄
Yeah it would be great, thanks!

@jadjoubran I will see what I can do ,I have not tested if  gulp-watch and elixir work together, as soon as I have something finished I will send a pull request.

👍


Fix geizhals price parsing

Description:
BREAKING CHANGE: The configuration changes from
sensor:
  - platform: geizhals
    name: qc35
    product_id: 1696985
    description: "Bose QC35"
    domain: 'geizhals.de'
    regex: '\D\s(\d*)[\,|\.](\d*)'

to:
sensor:
  - platform: geizhals
    name: qc35
    product_id: 1696985
    description: "Bose QC35"
    locale: "DE"

Possible locale values are: AT, EU, DE, UK or PL
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#6026
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: geizhals
    name: qc35
    product_id: 1696985

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

I found a bug in the geizhals Library. Please do not merge it yet!

Before we merge we should also add a paragraph in the PR description about the breaking change, since config options changed.

The Geizhals library was fixed in https://github.com/JulianKahnert/geizhals/commit/5401a94393bb136efb2b286ccb1fe7f20fe4b280 and the HA component was fixed in b949fc58d5968f88d864f115afc32cfa1d519f7e.
@MartinHjelmare, I added a description of the breaking change in the PR description.

Thanks @MartinHjelmare for your reply.  I added this in 828d55674e255bb401aa247df70ec91227d6fcd5

There seems to be a problem installing the geizhals library. The travis job failed:
https://travis-ci.org/home-assistant/home-assistant/jobs/417445670#L727
It looks like the package is imported in setup.py. That won't work since dependencies aren't installed at that time.
https://github.com/JulianKahnert/geizhals/blob/master/setup.py#L2

You still have an installation issue with your lib. You cannot import your own lib inside setup.py because it needs to read setup.py to see what your dependencies are and install them.

Hi there, I'm sorry for wasting your time! https://github.com/home-assistant/home-assistant/pull/15990/commits/06ffdd3ad4b03560db2cb9605a70f66919ddccea should fix the problem.


Overhaul fetch implementation and host API

This PR contains a substantial overhaul of the fetch implementation, along with meaningful changes to how the host API works
On the latter, the most important change is that the representation of handles is now completely opaque to consumers: instead of using a typedef visible to users of the host_api.h header, the header just forward-declares a class, which hence can't be created or interacted with from outside the host API implementation.

@guybedford while this isn't completely done, and in dire need of cleanup, it is most of the way there, I think. I'm sharing it now because the host API changes are bound to impact you quite a bit. I hope they're for the better, and I at least found them to be necessary to get back to a point where I'm able to reason through the management and lifecycles of resource handles.

@guybedford I think this is now ready for review. The resource handling is much cleaned up, and I addressed all the regressions of WPT tests that make sense to do here, relative to the state of the JS Compute Runtime I started with.
(The only things missing that that passes are around some convenience constructors such as Response.redirect(), which I'm not tackling here.)

Thank you for letting me know, @nicoburniske! Fascinating, given that I ran a whole bunch of WPT tests around fetch that seemed to say it works. I'll investigate.

@nicoburniske thank you again for the report! Turns out I had read some of the WPT outputs wrong, and there indeed was a bunch more stuff to fix 😃

One issue I did hit with this example:
const res = await fetch('https://www.google.com');
const text = await res.text();
console.log(text);

is that it throws (new TypeError("malformed UTF-8 character sequence at offset 1", ""))
Is decompression properly supported?

@guybedford ah, interesting. The fetch implementation indeed doesn't do transparent decompression. But usually that shouldn't matter either, because we're not setting the Accept-Encoding header. Are you setting that, by any chance?

@tschneidereit because we virtualize on top of Node.js's fetch implementation it might be overriding that I expect, posted https://github.com/bytecodealliance/jco/issues/447 to investigate further.

Actually I spoke too soon. Running against a test server I'm getting mangled response body data. Headers are just {"host":"localhost:8080","connection":"keep-alive"}. But the body the test server is sending back doesn't seem to reflect at all. Again, this could be ComponentizeJS / Jco toolchain specific, but I'd have to dig into it more. We did pass all the WASI HTTP tests though, so I haven't seen any mangled response issues before, unless there are gaps in the test suite.

@guybedford I fixed a whole bunch of additional issues now. Would be great if you could take a look at the additional commits I pushed since your review. Then we should land this, and move everything else into additional PRs. (Of which I'll open a few in a moment, stacked on top of this one 😄)

Thank you for the review!  While there's a bunch of code motion in that commit, it's all trivial, so I'll go ahead and land this.


CI add codecov token to the config

The codecov token we have is not actually used in PRs since it's a token on GH, and they're not exposed to pull_request triggered actions.
The recommended action seems to be adding it hard coded, which doesn't really pose any security risks: https://github.com/codecov/codecov-action/issues/837#issuecomment-1453877750

I don't think it's something GH wants to "fix".

I don't think it's something GH wants to "fix".

Yeah, at this point probably not.


false-negative: if ( !(a == b) ) is not linted

if (!(a == b)) {
}

can be written as
if (a != b) {
}

This is now covered by 8cf0b04 in RedundantNegationCheck