[Doc-Improvement] [Update-Teams-toolkit]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/create-new-project.md
100
1
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 0e5a8f0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/create-new-project.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/create-new-project.md
95
4
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 09d1d60:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/toolkit/create-new-project.md
:warning:Warning
View
Details

msteams-platform/toolkit/create-new-project.md

Line 38, Column 2: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/create123.png'.
Line 40, Column 1: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/create1234.png'.
Line 52, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/sample1.png'.
Line 52, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.
Line 55, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/sample2.png'.
Line 55, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 940c5d9:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/toolkit/create-new-project.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/extension.png
:white_check_mark:Succeeded
View

msteams-platform/toolkit/create-new-project.md

Line 42, Column 2: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/create123.png'.
Line 44, Column 2: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/create1234.png'.
Line 56, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/sample1.png'.
Line 56, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.
Line 59, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/sample2.png'.
Line 59, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/create-new-project.md
95
4
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 83ca9e2:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/toolkit/create-new-project.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/extension.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension1.PNG
:white_check_mark:Succeeded
View

msteams-platform/toolkit/create-new-project.md

Line 43, Column 2: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/create123.png'.
Line 45, Column 2: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/create1234.png'.
Line 57, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/sample1.png'.
Line 57, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.
Line 60, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/sample2.png'.
Line 60, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/create-new-project.md
92
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/create-new-project.md
92
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 74c0669:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/toolkit/create-new-project.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/create123.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/create1234.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/sample1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/samples.png
:white_check_mark:Succeeded
View

msteams-platform/toolkit/create-new-project.md

Line 57, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.
Line 60, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/sample2.png'.
Line 60, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/create-new-project.md
92
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 2ce4c38:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/toolkit/create-new-project.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/create123.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/create1234.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/sample1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/sample2.png
:white_check_mark:Succeeded
View

msteams-platform/toolkit/create-new-project.md

Line 56, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.
Line 59, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/create-new-project.md
92
5
link
:white_check_mark:

msteams-platform/toolkit/debug-local.md
93
10
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 7ba717b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/toolkit/create-new-project.md
:warning:Warning
View
Details

msteams-platform/toolkit/debug-local.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/create123.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/create1234.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/sample1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/sample2.png
:white_check_mark:Succeeded
View

msteams-platform/toolkit/create-new-project.md

Line 56, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.
Line 59, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.

msteams-platform/toolkit/debug-local.md

Line 180, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/debug/app.png'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 22c9044:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/toolkit/create-new-project.md
:warning:Warning
View
Details

msteams-platform/toolkit/debug-local.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/create123.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/create1234.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/sample1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/sample2.png
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-customization.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/create-new-project.md

Line 56, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.
Line 59, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.

msteams-platform/toolkit/debug-local.md

Line 180, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/debug/app.png'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-manifest-customization.md
88
4
link
:white_check_mark:

msteams-platform/toolkit/create-new-project.md
92
5
link
:white_check_mark:

msteams-platform/toolkit/debug-local.md
93
10
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-manifest-customization.md
88
4
link
:white_check_mark:

msteams-platform/toolkit/create-new-project.md
92
5
link
:white_check_mark:

msteams-platform/toolkit/debug-local.md
93
10
link
:white_check_mark:

msteams-platform/toolkit/deploy.md
95
1
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 50383e0:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/toolkit/create-new-project.md
:warning:Warning
View
Details

msteams-platform/toolkit/debug-local.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/create123.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/create1234.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/sample1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/sample2.png
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-customization.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/deploy.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/create-new-project.md

Line 56, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.
Line 59, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.

msteams-platform/toolkit/debug-local.md

Line 180, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/teams-toolkit-v2/debug/app.png'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-manifest-customization.md
88
4
link
:white_check_mark:

msteams-platform/toolkit/create-new-project.md
92
5
link
:white_check_mark:

msteams-platform/toolkit/debug-local.md
92
11
link
:white_check_mark:

msteams-platform/toolkit/deploy.md
95
1
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 8994a86:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/toolkit/create-new-project.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/create123.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/create1234.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/debug/app1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/sample1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/sample2.png
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-customization.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/debug-local.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/deploy.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/create-new-project.md

Line 56, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.
Line 59, Column 4: [Warning: duplicate-alt-text - See documentation] Alt text 'View samples' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-manifest-customization.md
88
4
link
:white_check_mark:

msteams-platform/toolkit/create-new-project.md
92
5
link
:white_check_mark:

msteams-platform/toolkit/debug-local.md
92
11
link
:white_check_mark:

msteams-platform/toolkit/deploy.md
95
1
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 1f14eb6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/teams-toolkit-v2/create123.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/create1234.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/debug/app1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/extension1.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/sample1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/sample2.png
:white_check_mark:Succeeded
View

msteams-platform/toolkit/TeamsFx-manifest-customization.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/create-new-project.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/debug-local.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/deploy.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Closing the PR.


Medievil 2 PAL save file corrupted on Memory card 1

Using Unirom with freepsxboot on Memory Card in slot 2, Medievil 2 won't allow you to load the save file from memory card 1, telling you that the save file is corrupted while is not.
I'm using latest 8.0.J version.
Medievil 2 is PAL version.
Game works and load save file just fine if boot with Unirom through an action replay cartridge or other methods. So I think there is something wrong with how Freepsxboot disable slot 2.

What is your BIOS version? I have an updated patch which should fix such issues, it would be great if you could try it and give feedback.

What is your BIOS version? I have an updated patch which should fix such issues, it would be great if you could try it and give feedback.

Oh I can test this on a 102 with 4.4 Bios, on a 7502, 5502 and 1002.

Ok, you can try this on the 7502: https://github.com/brad-lin/FreePSXBoot/files/8310007/freepsxboot-unirom-fastload-20220318-bios-4.1-1997-12-16-A-502224b6-slot2.zip

Ok, you can try this on the 7502: https://github.com/brad-lin/FreePSXBoot/files/8310007/freepsxboot-unirom-fastload-20220318-bios-4.1-1997-12-16-A-502224b6-slot2.zip

Yes. This works fine. So I suppose you have to update all the versions...?

Nice, thanks for testing. This new version will be released soon (in the coming days), the updated images will be uploaded first in the repo.

Nice, thanks for testing. This new version will be released soon (in the coming days), the updated images will be uploaded first in the repo.

Sorry, is there a date on when the new version will be released? Otherwise can I have a version for the SCPH 102 4.4 BIOS? Thanks.

Nice, thanks for testing. This new version will be released soon (in the coming days), the updated images will be uploaded first in the repo.

Sorry, is there a date on when the new version will be released? Otherwise can I have a version for the SCPH 102 4.4 BIOS? Thanks.

I have just pushed the new images for all BIOS versions (no release yet, but the images are available from the links in the readme). Feedback is welcome, thanks.

Thanks!


Using mouse to control camera perspective in manual_control.py client

Hello Carla team!
I am working with the python clients for manual_control.py and was wondering if there is a good way to move the perspective of the user (or camera) around with the mouse. Specifically a mechanism like the simulator's spectator view but on the client pygame instance would be ideal!
I tried something with destroying and reinitializing the camera sensor but this is very slow. Similarly flooding the server with set() requests for set_transform() is also very slow. I'm not sure of a better way to do this.
Any help is appreciated!

Hi @GustavoSilvera, you could use pygame to detect position and drag of the mouse to change the camera orientation accordingly  with the set_transform() function you mention but there is no better way to do this.

Hi @Axel1092, thanks for your suggestion. Unfortunately I already tried something similar to this and found that it does not suit my purposes well as it is very laggy with a moving vehicle and I was looking into VR support.
In this regard I've transitioned to using the UE4 game itself (simulator 'server') as the main viewpoint since UE4 has native VR support and so far this approach has been successful.


Inconsistent type-casting behaviour

TypeScript Version:  2.1.5 (also 2.1.4)
Code
interface IFilter {
	render: string;
	color: number;
}

// 1a) this will compile
var a: IFilter = <IFilter>{};
// 1b) this will compile too
var b: IFilter = <IFilter>{color: 5};
// 2) this complains about missing render property
var c: IFilter = <IFilter>{color: 5, shape:3};

Expected behavior:
I am not entirely sure whether the behaviour 1 or 2 is the correct, one, but from the description of the type system I would expect 2) to be correct. Either way, I find it strange that the code behaves inconsistently in those 2 cases.
Actual behavior:
My expectation: all 3 casts fail, because of missing render property
Motivation
Just quick explanation of our usage of this: we have a method accepting array of objects (let's say filters) representing a declaration, the typecasts are used to make sure the individual objects contain all required properties (discriminate unions don't work here because new types can be mapped by the code).

Type assertion checks that either of the two types are assignable to each other (i.e. up-cast / down-cast). in this case, IFilter has a required reader property that is missing from {color: 5, shape:3} and {color: 5, shape:3} have a required shape property that is missing from IFilter. so the two types are unrelated.
Please see https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#416-type-assertions for more details.
You can assert to a common base type, as <IFilter><{}>{color: 5, shape:3}; if you need to do the conversion.

For future references, we would recommend using StackOverFlow for similar questions.

Ok sorry, I got sidetracked by the fact that the expression on the right side is a constant. When working with general expression the 2 directions of the "assignability" test make of course perfect sense. But when applied to a constant it seems somehow dubious (at least I cannot think if an example where such typecast isn't a disaster waiting to happen). Then again different of the type assertion for direct constants and dynamic expressions probably isn't desirable?


macOS 10.15.2 boostrap fails with gcc 9.3.0 and clang

running the ./bootstrap-vcpkg.sh script fails with

-- The CXX compiler identification is GNU 9.3.0
-- Checking whether CXX compiler has -isysroot
-- Checking whether CXX compiler has -isysroot - yes
-- Checking whether CXX compiler supports OSX deployment target flag
-- Checking whether CXX compiler supports OSX deployment target flag - yes
-- Check for working CXX compiler: /usr/local/bin/g++-9
-- Check for working CXX compiler: /usr/local/bin/g++-9 - works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting the C++ standard library
-- Detecting the C++ standard library - libstdc++
-- Detecting how to use the C++ filesystem library
-- Detecting how to use the C++ filesystem library -
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Configuring done
-- Generating done
-- Build files have been written to: /Volumes/external1/git/cpprestsdk/vcpkg/toolsrc/build.rel
[0/2] Re-checking globbed directories...
[1/76] Building CXX object CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o
FAILED: CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o
/usr/local/bin/g++-9  -DVCPKG_DISABLE_METRICS=0 -DVCPKG_USE_STD_FILESYSTEM=1 -I../include -O3 -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk   -std=c++17 -MD -MT CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o -MF CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o.d -o CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o -c ../src/vcpkg.cpp
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/wchar.h:90,
from /usr/local/Cellar/gcc/9.3.0_1/include/c++/9.3.0/cwchar:44,
from /usr/local/Cellar/gcc/9.3.0_1/include/c++/9.3.0/bits/postypes.h:40,
from /usr/local/Cellar/gcc/9.3.0_1/include/c++/9.3.0/bits/char_traits.h:40,
from /usr/local/Cellar/gcc/9.3.0_1/include/c++/9.3.0/string:40,
from ../include/vcpkg/base/cstringview.h:4,
from ../include/vcpkg/base/chrono.h:3,
from ../src/vcpkg.cpp:5:
/usr/local/Cellar/gcc/9.3.0_1/lib/gcc/9/gcc/x86_64-apple-darwin19/9.3.0/include-fixed/stdio.h:219:10: fatal error: _ctermid.h: No such file or directory
219 | #include <_ctermid.h>
|          ^~~~~~~~~~~~
compilation terminated.
[2/76] Building CXX object CMakeFiles/vcpkglib.dir/src/vcpkg/base/files.cpp.o

using ./bootstrap-vcpkg.sh --allowAppleClang also fails

-- The CXX compiler identification is AppleClang <IP_ADDRESS>01145
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ - works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting the C++ standard library
-- Detecting the C++ standard library - libc++
-- Detecting how to use the C++ filesystem library
-- Detecting how to use the C++ filesystem library -
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Configuring done
-- Generating done
-- Build files have been written to: /Volumes/external1/git/cpprestsdk/vcpkg/toolsrc/build.rel
[0/2] Re-checking globbed directories...
[1/76] Building CXX object CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o
FAILED: CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++  -DVCPKG_DISABLE_METRICS=0 -DVCPKG_USE_STD_FILESYSTEM=1 -I../include -O3 -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk   -std=c++17 -MD -MT CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o -MF CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o.d -o CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o -c ../src/vcpkg.cpp
In file included from ../src/vcpkg.cpp:6:
../include/vcpkg/base/files.h:7:10: fatal error: 'filesystem' file not found
#include
^~~~~~~~~~~~
1 error generated.
[2/76] Building CXX object CMakeFiles/vcpkglib.dir/src/vcpkg/base/enums.cpp.o

Thanks for posting this issue. Due to I have no MAC machine with gcc9, could you try to make soft link link xcode/include to /usr/local/include? This may solve the error /usr/local/Cellar/gcc/9.3.0_1/lib/gcc/9/gcc/x86_64-apple-darwin19/9.3.0/include-fixed/stdio.h:219:10: fatal error: _ctermid.h: No such file or directory.
@dan-shaw @BillyONeal Could you help take a look this issue?

I'm not sure where to create the soft link. /Applications/Xcode9.1.app/Contents/Developer/Library/Xcode ?

@lkleen I just got my hands on a MacOS machine to try to investigate this but I'm new to that platform and don't know how you get gcc-9 on that platform. When I do a bootstrap it wants to use AppleClang 11 :)

Closing this due to more than 30 days with no response. Please feel free to open another issue (or reopen this one if possible) at such time you can point out how we can repro the problem. Thanks!


Please add an example of how to write the config

Would you please like to add an example configuration? I am "just using" atom, ran into this scaling issue but can not get any of the settings to do anything. It would be nice to see an original example config for this module so I can better understand if I just get the config syntax wrong, thanks!

I used to use the defaults with a retina display and a 1920x1080 monitor.  They should scale up atom 2x on the retina display and scale it back down to 1x on the 1920x1080 monitor.  The readme in this repo explains the usage/format of each configuration option.
That being said, atom recently made changes that allow it to detect the scale factor and adjust the scale automatically, which messed with the resolution detection in this package.  This issue is covered in more detail here: #8.
What are you trying to do with atom-hidpi?  Can you provide your monitor setup, how you want it to scale, and your operating system?  I have a feeling that once #8 is fixed, your problems will disappear.

Most configurable Atom packages have a "Settings" button next to them in the list of installed packages. It's not obvious how one should configure atom-hidpi since it does not have a "Settings" button.
I tried adding an "atom-hidpi" section in Atom's config.cson but the settings are not applying (even after "Hidpi: Update").

Could you just give us an example of how those settings would look in a config.json? Most other plugins expose their settings in the preferences. I just started using atom a few months ago and can't find any examples of how to add settings as you have them described. What section do they go under?

In atom 1.9 I don't see a settings icon for this package (I assume there is a new api add one), but in the "Packages" section, if I click on any part of this package's tile that isn't "uninstall", "disable", or "hidpi" I get linked to the settings page.  Let me know if that doesn't work for you.


two step login form

First of all - great integration!
I'm currently trying to scrape the processing step of a car i've ordered via "meinauto.de". Unfortunatelly, the login form, which can be found at "https://kundencenter.meinauto.de/" offers a bad UX, which has a multi-step login form.

First, you have to enter your email, then submit.
Then, you have to enter your password.

As far as i can see, this is currently not supported by ha-multiscrape, or am i wrong?

That's indeed not supported, unless there is still a single authentication call after the last step with both the username and the password. You'll need to dive into the browser's developer tools to find out.

Hi @danieldotnl,
Is there any possibility of looking into this?
Login in two steps is expanding more each day, and most of them make a call to the server first with the email and then a second with the password, and the first call is needed to set up different cookies and tokens.
Some examples:

Site
URL

Eneco
https://inloggen.eneco.nl

Booking.com
https://account.booking.com/sign-in

Disney Plus
https://www.disneyplus.com/nl-nl/login

Expedia
https://expedia.com/login

Regards


[FLINK-11068][table] Convert the API classes of *Table to interfaces

What is the purpose of the change
This pull request convert table related classes into interface.
Brief change log

Convert Table, GroupedTable, GroupWindowedTable, OverWindowedTable, WindowGroupedTable into interface.
Port TemporalTableFunction into flink-common. I add no methods in TemporalTableFunction. It seems we don't need to add methods in TemporalTableFunction for now. We can add it later if we find it necessary. It's easier and safer for adding methods than removing methods.

Verifying this change
This change is already covered by existing tests, such as tests for tableApi. And changes for temporal table has been covered by TemporalTableJoin UT/IT test cases.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@flinkbot approve-until consensus

One more thing could we also already remove the javadocs from TableImpl? We shouldn't duplicate it.

@dawidwys  Thanks a lot for your review and valuable suggestions. I have addressed all your comments and updated the PR. Would be great if you can take another look. Thank you.

Thank you a lot @hequn8128 for the work. It looks good. Last minor thing is we should add override keywords to the methods of TableImpl, but I can do that during merging. Will do that as soon as travis gives green.

@flinkbot approve all

@dawidwys I added the override methods and fix one checkstyle problem. Sorry for the trouble that brings to you.


lm.fit does not produce any output lesson2 deeplearning course 1

lm.fit(trn_features, trn_labels, nb_epoch=2, batch_size=batch_size,
validation_data=(val_features, val_labels))

It's working now. Jupyter was working slowly so I didn't see output :).


HHH-16999 Relax visibility of some methods for hibernate-reactive

Reactive support for ORM currently uses redundant code already in ORM.  Changing the visibility of a handful of methods from private to protected will simplify HR code and reduce risk of future errors.

https://hibernate.atlassian.net/browse/HHH-16999

@dreab8 Hey... I don't have privileges to set Reviewer.  Can you look this over and merge if it's OK?
Thx


Red Alert Solution in C

🚀 Feature
Codechef Problem-RED ALERT (JULY LUNCHTIME 2021)
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


When sorting IAM User's Access Key Age column, sort alphabetically, not numeric.

In the case of IAM User's Access Key Age, when column sorting is performed, alphabetical rather than numeric is sorted.
Because it is a string value of "xx days".

For sorting, modify column data be stored in integer format, and use postfix as options value.
  - key: data.access_key_age
    name: Access Key Age
    options:
      postfix: ' days'
    type: text
  - key: data.last_active_age
    name: Last Activity
    options:
      postfix: ' days'
    type: text

However, it does not complete because this postfix feature of the specification has not yet been developed in the Console.
This issue will be closed after applying the postfix feature in console.

This issue was reflected through this PR in mirinae(design system).
We'll fix it by updating the mirinae version to the console soon.


vimUtils.packdir: better merge of plugins

Fixes https://github.com/NixOS/nixpkgs/issues/193070
Basically it was hard to install both
nvim-treesitter.withPlugins (
          plugins: with plugins; [
            tree-sitter-c
            tree-sitter-lua
            tree-sitter-org-nvim
          ]
        ));

and nvim-treesitter
It also simplifies some nix code.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@oxalica ould you mind testing if it doesn't break the vim code please ? I could not find a test for it.

nix-build -A neovim.tests pass and I've rebuilt with the patch and it looks fine.

This line breaks using buildVimPlugin without a pname (i.e. specifying name instead of pname and version).
I noticed since this broke a local plugin definition. Is the change necessary/intended?

I noticed that with a test that had the issue but everything is supposed to have a pname by now ? how did you define your plugin ? just add a pname to it.

Yeah, I already fixed it by adding pname/version. Just wanted to make sure this was intended. If everything is supposed to have a pname then this change is fine :)

There is a difference between everything is supposed to have pname+version and everything has pname+version which is definitely not the case.
Also this is the second time in the last weeks that my evaluation got broken by neovim refactoring.
Also please unblock me, you are blocking cooperation and not making this joint effort better by that.

I noticed since this broke a local plugin definition. Is the change necessary/intended?

Thanks for the hint. From the trace alone this is not obvious and cannot be found. If I am encountering more occurrences of this I am thinking about reverting this PR.

#194069

This just broke me too, requiring use of the Nix debugger to figure out what plugin was broken (and subsequently finding its definition in my configuration).
Unless we actually require the version, this should use lib.getName drv instead of drv.pname. In fact, even if we do require the version, that should be done with lib.getName and lib.getVersion.


Error: eshop-secrets.json in dapr self hosted mode and kubernets

I am trying to run individual service in dapr self hosted mode but getting below error.
ATA[0005] process component eshopondapr-secretstore error: [INIT_COMPONENT_FAILURE]: initialization error occurred for eshopondapr-secretstore (secretstores.local.file/v1): open ../dapr/components/eshop-secrets.json: no such file or directory  app_id=catalogservice instance=USBLRRAHULRAI1 scope=dapr.runtime type=log ver=1.9.5
this is the command I am running
dapr run --app-id catalogservice  --app-port 6000 --dapr-http-port 3600 --dapr-grpc-port 60000  --components-path ../../../../dapr/components dotnet run
Can someone please suggest, where I am making mistake.
[update]
I tried to run the sample in local docker kubernetes clustor, there also the same problem.

I can confirm that repo works fine, I had the issue with something related to network, not sure why it was not working when I was not on my VPN, due to some reason it was giving error, but when I connected to my VPN its working fine.
Still not able to figure it out why it didn't work in local cluster.  The only change I did initially was change in resolv.conf file because **"dapr init -k"** and helm chart installation was not working, I added nameserver 8 8 8 8 instead of <IP_ADDRESS>
But when i connected to VPN and in docker deamon config I added "dns":["my dns ip"] it worked. Not sure at the moment what has worked. I will updated my findings later. but closing this ticket for now.


Register Operation

Description:
As an industry user, given that the operation has been added to my operator, I can register the operation for IRC approval.
Acceptance Criteria:
1694
Given that I am on the dashboard or the Registration dashboard,
When I click Register an operation,
Then I am brought to the new registration page
https://www.figma.com/design/LsDmLDCdnJqI8UahyqvOD8/BCIERS-Designs?node-id=7763-4664&t=5omgZedIN5xnnFFl-4
Given that I am on the operations page,
When I click Add and Register an operation button,
Then I am brought to the new registration page
https://www.figma.com/design/LsDmLDCdnJqI8UahyqvOD8/BCIERS-Designs?node-id=7763-4664&t=5omgZedIN5xnnFFl-4
Given that I am on the Operation Information page of the New Registration form,
When I click on the Operation dropdown,
Then the list of operations will only show operations that have been added but not yet registered
Given that I selected an operation,
Then the operation form of the selected operation will appear in view-only mode, so that I can review it
https://www.figma.com/design/LsDmLDCdnJqI8UahyqvOD8/BCIERS-Designs?node-id=8471-1866&t=5omgZedIN5xnnFFl-4
Given that I am on the operation information page of the New Registration form,
When I click on the Add a New Operation button
Then I can see an empty operation form in edit mode, so that I can fill it out
https://www.figma.com/design/LsDmLDCdnJqI8UahyqvOD8/BCIERS-Designs?node-id=8912-244&t=5omgZedIN5xnnFFl-4
Given that I am on the Operation Information page of the New Registration form,
When I click on the save and continue button,
Then I am brought to the Facility Information page of the form
https://www.figma.com/design/LsDmLDCdnJqI8UahyqvOD8/BCIERS-Designs?node-id=11759-156&t=5omgZedIN5xnnFFl-4
Given that I am on the Facility Information page of the New Registration form,
When I click Add Facility,
then it will display the add facility form. https://www.figma.com/design/LsDmLDCdnJqI8UahyqvOD8/BCIERS-Designs?node-id=12902-157&t=5omgZedIN5xnnFFl-4
Given that I am on the Facility Information page of the New Registration form,
When I click on the save and continue button,
Then I am brought to the Registration Information page
https://www.figma.com/design/LsDmLDCdnJqI8UahyqvOD8/BCIERS-Designs?node-id=10222-8&t=5omgZedIN5xnnFFl-4
Given that I am on the Registration information page, When I click on the save and continue button,
Then I am brought to the Operation Representative page of the form
https://www.figma.com/design/LsDmLDCdnJqI8UahyqvOD8/BCIERS-Designs?node-id=10222-77&t=5omgZedIN5xnnFFl-4
Given that I am on the Operation Representative page,
When I click on the save and continue button,
Then I am brought to the final page of the form
https://www.figma.com/design/LsDmLDCdnJqI8UahyqvOD8/BCIERS-Designs?node-id=10222-146&t=5omgZedIN5xnnFFl-4
Given that I am on the final page of the form
When I click sign and register
Then I am brought to the success page
And this operation’s status will now be Registered in my operations table.
Development Checklist:

[ ] Checklist item
[ ] Checklist item
[ ] Checklist item
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:
Dependencies

Blocked by #1854
Blocking

Potential to be broken down into multiple user stories

We'll need to figure out how to do the snapshot thing in the db

Update AC based on pending decisions from business area

Splitting into multiple stories by @zoeyli-46

Deletion Candidate Reason:
Registration purpose and operation info steps have been combined into a single step
PR: https://github.com/bcgov/cas-registration/pull/1990
Ticket: https://github.com/orgs/bcgov/projects/122/views/2?filterQuery=&pane=issue&itemId=69561695

Deletion Candidate Reason:
Registration purpose and operation info steps have been combined into a single step
PR: #1990 Ticket: https://github.com/orgs/bcgov/projects/122/views/2?filterQuery=&pane=issue&itemId=69561695

I think we still need this one. I was trying not to wildly expand the scope of the one I'm working on, so I'm only adding the 'select operation' part, not the add part.

@zoeyli-46 and @shon-button I've updated this ticket

My review notes:

I'm not sure if the list of operations I see in the dropdown are only those that have been added but not yet registered. @BCerki is there a way to confirm that this function is working correctly? I assume we want to avoid having operations that are already registered show up in this dropdown, correct?

Can you confirm that we have removed the following AC from this ticket?

Given that I am on the operation information page of the New Registration form,
When I click on the Add a New Operation button
Then I can see an empty operation form in edit mode, so that I can fill it out

I don't see a follow-up ticket this AC (for adding a new operation). Please let me know if we have this in our backlog already and I missed it. If not, I'd like to ensure we create that before I close this ticket.
Thanks!
Tagging @zoeyli-46 for visibility

My review notes:

I'm not sure if the list of operations I see in the dropdown are only those that have been added but not yet registered. @BCerki is there a way to confirm that this function is working correctly? I assume we want to avoid having operations that are already registered show up in this dropdown, correct?
Can you confirm that we have removed the following AC from this ticket?

Given that I am on the operation information page of the New Registration form, When I click on the Add a New Operation button Then I can see an empty operation form in edit mode, so that I can fill it out

I don't see a follow-up ticket this AC (for adding a new operation). Please let me know if we have this in our backlog already and I missed it. If not, I'd like to ensure we create that before I close this ticket.
Thanks!
Tagging @zoeyli-46 for visibility

Re first *: Yes, operations that have already been registered shouldn't show in the dropdown. You can test this by registering an operation and then going back into the registration workflow. The operation you just registered shouldn't be available in the dropdown.
second *: You can add a new operation right now, but not with the button (Zoey and I have been discussing this in figma and it sounds like one of us will create a new ticket). In the meantime, to add a new operation, instead of selecting an operation in the dropdown, you can fill out the blank fields below.

I created this ticket #2224

Thanks Brianna. This makes sense. I'll close this ticket now.


External account support Metamask issue #5640

We want to add external account support, which enables MEtamask not to store private keys for an external address, but upon confirm request the user will be presented with a poup modal that displays a QR code with tx data, and enables to enter a signature. Once valid signature entered, the transaction is processed by Metamask the standard way.
Since keyrings are hidden from metamask-controller, a keyring must use keyring-controller to expose data to ui, since we want to popup a modal when a transaction is initiated from a from-address of an external account.
This update creates three arrays of objects in KeyringController.
extToSign - is used to store tx data of transactions that need to be externally signed by user.
extSigned - is the storage of tx s that were successfully signed by user
extCancel - is the storage of tx s whose external signing was canceled by user.
Added some functions that enable controlled change of the three arrays above.
This pr is required in order to https://github.com/MetaMask/metamask-extension/pull/6267
work properly.

Thanks for the work on this!
not yet certain this is the best approach
lets keep discussion going over in https://github.com/MetaMask/metamask-extension/pull/6267

This request is outdated.


method Disconnect on version 2.2.0-pre2 doesn't work

To help us fix your issue, please provide the information in the below template. If something causes a crash, provide as much information as you can gather.
Just imagine: we do not know what you are doing!

Note: There is often little we can do without a minimal reproducible sample of the issue, so please provide that in a standalone git repository and link it here.

Steps to reproduce

Connect => Success
2.
Disconnect => Can not disconnect to device => DeviceState return Connected
Expected behavior
Tell us what should happen => DeviceState.Disconnected
Actual behavior
Tell us what happens instead => DeviceState.Connected after disconnect
Crashlog
If something causes an exception paste full stack trace + Exception here
Configuration
**Version of the Plugin: 2.2.0-pre2
**Platform: Windows 10 (PC using USB dongle,Laptop), Android 8.1,4.4,9.0,iOS 10
**Device: PC, Laptop, Samsung galaxy s8, LG NEXUS, Xiaomi, iphone 8

Hi @vlbhtcno1,
I'm the friendly issue checker.
It seems like (37.50 %) you haven't used our issue template :cry: I think it is very frustrating for the repository owners, if you ignore them.
If you think it's fine to make an exception, just ignore this message.
But if you think it was a mistake to delete the template, please close the issue and create a new one.
Thanks!


How to run suppress-eslint-errors with Typescript

It took me a while to track down how to use this with Typescript. Could you update the readme? Or leave this issue open
npx suppress-eslint-errors --parser=tsx --extensions=tsx,ts,jsx,js  src

@amanda-mitchell any thoughts on this?

I’d be happy to entertain a PR!


Update podspec to support iOS 7 and latest version

:+1:

Just implemented CocoaPods support myself. Used you guys as a reference.. Super helpful, thanks!
The dynamic framework CocoaPods doesn't seem to work on iOS 7, even though Argo as a collection of Swift files does.
Couple References:
https://github.com/Alamofire/Alamofire/pull/287#discussion_r22523827
CocoaPods/CocoaPods/issues/2963

Yeah, we realized this shortly after making this change. I think I'm just going to move the CP target to 8.0.


bug: Cannot disable introspection point due to an error.

Please read our contributor guide before
creating an issue.
Expected behavior
It is expected that setting the dgs.graphql.introspection.enabled=false property will disable introspection.
Actual behavior
The property dgs.graphql.introspection.enabled=false is set but the application returns the following message.
11:51:40.143 [main] WARN  o.s.b.w.s.c.AnnotationConfigServletWebServerApplicationContext - Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.support.BeanDefinitionOverrideException: Invalid bean definition with name 'disableIntrospectionContextContributor' defined in class path resource [com/netflix/graphql/dgs/autoconfig/DgsAutoConfiguration.class]: Cannot register bean definition [Root bean: class [null]; scope=; abstract=false; lazyInit=null; autowireMode=3; dependencyCheck=0; autowireCandidate=true; primary=false; factoryBeanName=com.netflix.graphql.dgs.autoconfig.DgsAutoConfiguration; factoryMethodName=disableIntrospectionContextContributor; initMethodNames=null; destroyMethodNames=[(inferred)]; defined in class path resource [com/netflix/graphql/dgs/autoconfig/DgsAutoConfiguration.class]] for bean 'disableIntrospectionContextContributor' since there is already [Root bean: class [null]; scope=; abstract=false; lazyInit=null; autowireMode=3; dependencyCheck=0; autowireCandidate=true; primary=false; factoryBeanName=com.netflix.graphql.dgs.springgraphql.autoconfig.DgsSpringGraphQLAutoConfiguration; factoryMethodName=disableIntrospectionContextContributor; initMethodNames=null; destroyMethodNames=[(inferred)]; defined in class path resource [com/netflix/graphql/dgs/springgraphql/autoconfig/DgsSpringGraphQLAutoConfiguration.class]] bound.
11:51:40.150 [main] INFO  o.s.b.a.l.ConditionEvaluationReportLogger -

Error starting ApplicationContext. To display the condition evaluation report re-run your application with 'debug' enabled.
11:51:40.166 [main] ERROR o.s.b.d.LoggingFailureAnalysisReporter -

***************************
APPLICATION FAILED TO START
***************************

Description:

The bean 'disableIntrospectionContextContributor', defined in class path resource [com/netflix/graphql/dgs/autoconfig/DgsAutoConfiguration.class], could not be registered. A bean with that name has already been defined in class path resource [com/netflix/graphql/dgs/springgraphql/autoconfig/DgsSpringGraphQLAutoConfiguration.class] and overriding is disabled.

Action:

Consider renaming one of the beans or enabling overriding by setting spring.main.allow-bean-definition-overriding=true

It works correctly if done through the spring property.
Steps to reproduce
I just added the property in my .properties file. Anyways I think could be useful specify the versions wich in working with:
DGS version 9.1.1
Springboot version 3.3.0
If you have any doubt don't hesite to ask question about it.
Note: A test case would be highly appreciated, but we understand that's not always possible

Hi @nmartin-RatedPower. Is it ok for me to ask a question here? It's my first time contributing.
My question:

Which of the two disableIntrospectionContextContributor beans do we actually want to keep?

If we intend to keep both, is renaming them an option?

Is changing prefix = "spring.graphql.schema.introspection" to match: "dgs.graphql.introspection.enabled" an option?

Thank you!
Aayush

I see same problem and can only enable introspection by setting these properties both to true
dgs:   graphql:     introspection:       enabled: true spring:   graphql:     schema:       introspection:         enabled: true
If both are false the same exception as stated above occurs. Setting one of these properties to true and the other to false does not make introspection working for me.
dgs-version: 9.1.2
spring-boot: 3.3.0

Any update?

I also have this problem, I looked into the configurations:
Setting dgs.graphql.introspection.enabled=false also automagically sets spring.graphql.schema.introspection.enabled=false resulting in this error:
The bean 'disableIntrospectionContextContributor', defined in class path resource [com/netflix/graphql/dgs/autoconfig/DgsAutoConfiguration.class], could not be registered. A bean with that name has already been defined in class path resource [com/netflix/graphql/dgs/springgraphql/autoconfig/DgsSpringGraphQLAutoConfiguration.class] and overriding is disabled.

When running with debug=true:
   DgsAutoConfiguration#disableIntrospectionContextContributor matched:
      - @ConditionalOnProperty (dgs.graphql.introspection.enabled=false) matched (OnPropertyCondition)

   DgsSpringGraphQLAutoConfiguration#disableIntrospectionContextContributor matched:
      - @ConditionalOnProperty (spring.graphql.schema.introspection.enabled=false) matched (OnPropertyCondition)

I only set dgs.graphql.introspection.enabled=false the spring.graphql.schema.introspection.enabled=false seems to be automatically set.
I guess since DgsSpringGraphQLAutoConfiguration runs before DgsAutoConfiguration
disableIntrospectionContextContributor should have the annotation @ConditionalOnMissingBean
Setting spring.graphql.schema.introspection.enabled=false instead of dgs.graphql.introspection.enabled=false is a workable solution for us.

Fixed in #2056


sometimes DomainName() returns domains with a space

It doesn't happen every time but sometimes domains will have a space character in them such as this one: "internalweb services.net"
Its invalid so it breaks test code.

Thats a great catch thanks for pointing that out. Ill add some safe guards to catch stuff like that

Fixed v3.19.1

Thanks Brian !


Update de.json

Fix Typo
Please make sure you've read the pull request section of our code contribution guidelines.
When filling in a section please remove the help text and the above text.
Summary
[A brief description of what this pull request does.]
Ticket Link
[Please link the GitHub issue or Jira ticket this PR addresses.]
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Ran make check-style to check for style errors (required for all pull requests)
[ ] Ran make test to ensure unit and component tests passed
[ ] Added or updated unit tests (required for all new features)
[ ] Needs to be implemented in mobile (link to PR or User Story)
[ ] Has server changes (please link)
[ ] Has redux changes (please link)
[ ] Has UI changes
[ ] Includes text changes and localization file (.../i18n/en.json) updates
[ ] Touches critical sections of the codebase (auth, posting, etc.)

Thanks @itsmueller for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

Thank you @itsmueller , appreciate your contribution.
Translations are actually managed in our Translation server at https://translate.mattermost.com. Would you be open to helping make the changes there?
You can search for the strings at https://translate.mattermost.com/de/mattermost/. Looks like the ones you're proposing to change are here: https://translate.mattermost.com/de/mattermost/translate/#search=Wilkommen&sfields=source,target

Did the change in the Translation Server.

Thanks @itsmueller! 🎉


[INLONG-1892][Inlong-sort-standalone] Sort-standalone support consume events from Pulsar.

Title Name: [INLONG-1892][Inlong-sort-standalone] Sort-standalone support consume events from Pulsar.
Fixes #1892
Motivation
Integrate SortSdk into SortSdkSource, and support to consume events from Pulsar cache cluster.
Modifications
Same as the motivation.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (JavaDocs)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Codecov Report

Merging #2036 (e237c29) into master (7840029) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2036      +/-   ##
============================================
- Coverage     12.28%   12.24%   -0.04%
+ Complexity     1159     1155       -4
============================================
  Files           413      413
  Lines         35225    35215      -10
  Branches       5542     5542
============================================
- Hits           4328     4313      -15
- Misses        30127    30131       +4
- Partials        770      771       +1

Impacted Files
Coverage Δ

.../client/producer/qltystats/BrokerStatsItemSet.java
67.44% <0.00%> (-4.66%)
:arrow_down:

.../java/org/apache/flume/sink/tubemq/TubemqSink.java
51.42% <0.00%> (-4.00%)
:arrow_down:

.../producer/qltystats/DefaultBrokerRcvQltyStats.java
44.14% <0.00%> (-1.18%)
:arrow_down:

.../inlong/tubemq/corebase/policies/FlowCtrlItem.java
38.88% <0.00%> (-1.12%)
:arrow_down:

.../tubemq/corebase/policies/FlowCtrlRuleHandler.java
34.07% <0.00%> (-0.45%)
:arrow_down:

.../flink/connectors/tubemq/TubemqSourceFunction.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7840029...e237c29. Read the comment docs.


Allow the specification of secrets via enviroment variables.

Implemented by modifying node-starter.js to read the secrets like this:
const env = process.env;
const id = env["id_bot_id"];
const token = env["id_bot_token"];


Make a web service for the CLI tool

User Story
As a user,
I want to use the tool as a web service,
so that I don't need to install and maintain it on my own.
Acceptance criteria
FR
(Most requirements are defined in the API specification)

[x] Job queue is required to handle multiple user job requests
[x] CLI tool result as JSON
[x] Web service should store the processing results and serve the output files to the user on request
[x] Packaged as a Docker image
[x] Deployment to production environment
[ ] Do not submit the same job twice for processing (check by event log name and content hash)
[ ] File storage should be limited in size, if the limit is reached, older job results are removed
[ ] Ability to cancel a long running job by a user, so we don't waste computing resources
[ ] Accept an event log through an API's request body
[ ] Accept an event log from URL

NFR

[ ] Public API specification

API Specification
This is the specification for the web service. To preview it, open https://editor.swagger.io and copy-paste the content below into the Swagger Editor.
openapi: 3.0.3
info:
  title: Activity Transition Tool
  description: The tool allows to identify activity transitions given an event log
    and analyze its waiting times.
  version: 1.0.0
servers:
- url: /
paths:
  /jobs:
    post:
      summary: Submit an event log for the analysis.
      requestBody:
        description: Event log's URL to analyze and a callback endpoint to send request
          to when the job is finished.
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/ApiRequest'
        required: true
      responses:
        "200":
          description: Job submitted successfully.
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/Job'
        "500":
          description: Internal server error.
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/ApiResponseError'
  /jobs/{id}:
    get:
      summary: Get a summary of the job by its ID.
      parameters:
      - name: id
        in: path
        description: Job's UUID that was provided in the POST response.
        required: true
        style: simple
        explode: false
        schema:
          type: string
      responses:
        "200":
          description: Job's information.
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/Job'
        "500":
          description: Internal server error.
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/ApiResponseError'
components:
  schemas:
    Job:
      type: object
      properties:
        id:
          type: string
        status:
          type: string
        result:
          $ref: '#/components/schemas/JobResult'
      example:
        result:
          num_transition_instances: 5
          total_contention_wt: 3
          total_batching_wt: 7
          num_transitions: 5
          total_extraneous_wt: 4
          report:
          - contention_wt: 7
            wt_by_resource:
            - contention_wt: 3
              source_resource: 5
              target_resource: 9
              extraneous_wt: 1
              total_freq: 6
              case_freq: 9
              batching_wt: 9
              prioritization_wt: 6
              unavailability_wt: 6
              total_wt: 8
            - contention_wt: 3
              source_resource: 5
              target_resource: 9
              extraneous_wt: 1
              total_freq: 6
              case_freq: 9
              batching_wt: 9
              prioritization_wt: 6
              unavailability_wt: 6
              total_wt: 8
            source_activity: source_activity
            target_activity: target_activity
            extraneous_wt: 4
            total_freq: 1
            case_freq: 7
            batching_wt: 1
            prioritization_wt: 6
            unavailability_wt: 1
            total_wt: 1
          - contention_wt: 7
            wt_by_resource:
            - contention_wt: 3
              source_resource: 5
              target_resource: 9
              extraneous_wt: 1
              total_freq: 6
              case_freq: 9
              batching_wt: 9
              prioritization_wt: 6
              unavailability_wt: 6
              total_wt: 8
            - contention_wt: 3
              source_resource: 5
              target_resource: 9
              extraneous_wt: 1
              total_freq: 6
              case_freq: 9
              batching_wt: 9
              prioritization_wt: 6
              unavailability_wt: 6
              total_wt: 8
            source_activity: source_activity
            target_activity: target_activity
            extraneous_wt: 4
            total_freq: 1
            case_freq: 7
            batching_wt: 1
            prioritization_wt: 6
            unavailability_wt: 1
            total_wt: 1
          num_activity_instances: 1
          total_prioritization_wt: 9
          total_unavailability_wt: 2
          num_activities: 6
          num_cases: 0
          total_wt: 2
        id: id
        status: status
    JobResult:
      type: object
      properties:
        num_cases:
          type: integer
        num_activities:
          type: integer
        num_activity_instances:
          type: integer
        num_transitions:
          type: integer
        num_transition_instances:
          type: integer
        total_wt:
          type: integer
        total_batching_wt:
          type: integer
        total_prioritization_wt:
          type: integer
        total_contention_wt:
          type: integer
        total_unavailability_wt:
          type: integer
        total_extraneous_wt:
          type: integer
        report:
          type: array
          items:
            $ref: '#/components/schemas/JobResultReportItem'
      example:
        num_transition_instances: 5
        total_contention_wt: 3
        total_batching_wt: 7
        num_transitions: 5
        total_extraneous_wt: 4
        report:
        - contention_wt: 7
          wt_by_resource:
          - contention_wt: 3
            source_resource: 5
            target_resource: 9
            extraneous_wt: 1
            total_freq: 6
            case_freq: 9
            batching_wt: 9
            prioritization_wt: 6
            unavailability_wt: 6
            total_wt: 8
          - contention_wt: 3
            source_resource: 5
            target_resource: 9
            extraneous_wt: 1
            total_freq: 6
            case_freq: 9
            batching_wt: 9
            prioritization_wt: 6
            unavailability_wt: 6
            total_wt: 8
          source_activity: source_activity
          target_activity: target_activity
          extraneous_wt: 4
          total_freq: 1
          case_freq: 7
          batching_wt: 1
          prioritization_wt: 6
          unavailability_wt: 1
          total_wt: 1
        - contention_wt: 7
          wt_by_resource:
          - contention_wt: 3
            source_resource: 5
            target_resource: 9
            extraneous_wt: 1
            total_freq: 6
            case_freq: 9
            batching_wt: 9
            prioritization_wt: 6
            unavailability_wt: 6
            total_wt: 8
          - contention_wt: 3
            source_resource: 5
            target_resource: 9
            extraneous_wt: 1
            total_freq: 6
            case_freq: 9
            batching_wt: 9
            prioritization_wt: 6
            unavailability_wt: 6
            total_wt: 8
          source_activity: source_activity
          target_activity: target_activity
          extraneous_wt: 4
          total_freq: 1
          case_freq: 7
          batching_wt: 1
          prioritization_wt: 6
          unavailability_wt: 1
          total_wt: 1
        num_activity_instances: 1
        total_prioritization_wt: 9
        total_unavailability_wt: 2
        num_activities: 6
        num_cases: 0
        total_wt: 2
    JobResultReportItem:
      type: object
      properties:
        source_activity:
          type: string
        target_activity:
          type: string
        case_freq:
          type: integer
        total_freq:
          type: integer
        total_wt:
          type: integer
        batching_wt:
          type: integer
        prioritization_wt:
          type: integer
        contention_wt:
          type: integer
        unavailability_wt:
          type: integer
        extraneous_wt:
          type: integer
        wt_by_resource:
          type: array
          items:
            $ref: '#/components/schemas/JobResultResourceItem'
      example:
        contention_wt: 7
        wt_by_resource:
        - contention_wt: 3
          source_resource: 5
          target_resource: 9
          extraneous_wt: 1
          total_freq: 6
          case_freq: 9
          batching_wt: 9
          prioritization_wt: 6
          unavailability_wt: 6
          total_wt: 8
        - contention_wt: 3
          source_resource: 5
          target_resource: 9
          extraneous_wt: 1
          total_freq: 6
          case_freq: 9
          batching_wt: 9
          prioritization_wt: 6
          unavailability_wt: 6
          total_wt: 8
        source_activity: source_activity
        target_activity: target_activity
        extraneous_wt: 4
        total_freq: 1
        case_freq: 7
        batching_wt: 1
        prioritization_wt: 6
        unavailability_wt: 1
        total_wt: 1
    JobResultResourceItem:
      type: object
      properties:
        source_resource:
          type: string
        target_resource:
          type: string
        case_freq:
          type: integer
        total_freq:
          type: integer
        total_wt:
          type: integer
        batching_wt:
          type: integer
        prioritization_wt:
          type: integer
        contention_wt:
          type: integer
        unavailability_wt:
          type: integer
        extraneous_wt:
          type: integer
      example:
        contention_wt: 3
        source_resource: source_resource
        target_resource: target_resource
        extraneous_wt: 1
        total_freq: 6
        case_freq: 9
        batching_wt: 9
        prioritization_wt: 6
        unavailability_wt: 6
        total_wt: 8
    ApiResponseError:
      type: object
      properties:
        error:
          type: string
    ApiRequest:
      type: object
      properties:
        event_log:
          type: string
        callback_endpoint:
          type: string

Hey, I have a quick question:
Can you provide me with an example requestbody? I'm a bit confused what you mean with event_log being the URL to the log file. Does it mean that you want me to send you a URL where the backend would download the csv and process the job or should the event_log parameter contain the .csv file in the body?
At this moment my requestbody looks something like this.
{ event_log: [{obj1}, {obj2}, ... {obj n}], callback_endpoint: "somecallbackurl" }

Hey, no problem. Here's how it's implemented at the moment:
{
  "event_log": "http://localhost:8090/assets/samples/PurchasingExample.csv",
  "callback_endpoint": "http://example.com/callback"
}

I'm serving one sample log with the server, so we can test our services. The event log can be hundred of megabytes. In theory, it's unlimited. So, I propose to just give an URL of the log, so the backend service can download it when it's time for the job.
The response on the request above is the following for now:
{
  "id": "2537363a-02a1-11ed-8748-7e18b86c7993",
  "status": "pending",
  "callback_endpoint": "http://example.com/callback",
  "event_log": "http://localhost:8090/assets/samples/PurchasingExample.csv",
  "created_at": "2022-07-13T14:44:25.571965+03:00"
}

If the error is there, the response is:
{
  "id": "2537363a-02a1-11ed-8748-7e18b86c7993",
  "status": "failed",
  "error": "reason of failure",
  "callback_endpoint": "http://example.com/callback",
  "event_log": "http://localhost:8090/assets/samples/PurchasingExample.csv",
  "created_at": "2022-07-13T14:44:25.571965+03:00",
  "finished_at": "2022-07-13T14:46:49.83176+03:00"
}

It's a bit different from the API Specification, I'll update the specification when finish the implementation.
When the job is completed, the response would just include more attributes:
{
  "id": "2537363a-02a1-11ed-8748-7e18b86c7993",
  "status": "completed",
  "report_csv": "http://localhost:8090/assets/results/2537363a-02a1-11ed-8748-7e18b86c7993/PurchasingExample_handoff.csv",
  "callback_endpoint": "http://example.com/callback",
  "event_log": "http://localhost:8090/assets/samples/PurchasingExample.csv",
  "created_at": "2022-07-13T14:44:25.571965+03:00",
  "finished_at": "2022-07-13T14:46:49.83176+03:00"
}

So far, the following endpoints are implemented:

Action
Endpoint
Description

POST
http://localhost:8090/jobs
Submit a job. A body is required.

GET
http://localhost:8090/jobs
Get all the jobs. (Not sure if we expose this to the public, because event logs might be private and sensitive)

GET
http://localhost:8090/jobs/{id}
Job's data.

Another note, I'm having issues with CORS. Any chance that could be server related?

@JonasBerx It is. But what do you use as a server at the moment? I need to allow access to backend endpoints from other domains.

Another note, I'm having issues with CORS. Any chance that could be server related?

@JonasBerx It is. But what do you use as a server at the moment? I need to allow access to backend endpoints from other domains.

I'm just executing main.go locally.

Another note, I'm having issues with CORS. Any chance that could be server related?

@JonasBerx It is. But what do you use as a server at the moment? I need to allow access to backend endpoints from other domains.

I'm just executing main.go locally.

Oh, you're already in the code. Yes, I forgot about CORS. I'll add it now and then finish with making it public.

@JonasBerx Pushed CORS changes. Does it work now?

@iharsuvorau In Postman the request passes, on react server the request is still blocked.

@JonasBerx What about now? I didn't serve the OPTIONS method of HTTP that clients usually use.

@iharsuvorau In Postman the request passes, on react server the request is still blocked.

@JonasBerx What about now? I didn't serve the OPTIONS method of HTTP that clients usually use.

Yep! Went through, thx a lot!

@JonasBerx You can now take the binary from each GitHub Actions workflow run instead of running it from source. Here's an example workflow: https://github.com/AutomatedProcessImprovement/waiting-time-backend/actions/runs/2664403179. There's the Artifacts section at the bottom of the page.

Hey,
I suppose this is an issue with my machine running windows. If i understand the error correctly it just means that it cant find the sh command in windows cmd?
{"job":{"id":"eb80a231-0342-11ed-b7d7-fc34974ac7f4",
"status":"failed",`
"error":"exec: \"sh\": executable file not found in %PATH%",
"callback_endpoint":"http://example.com/callback",
"event_log":"http://localhost:8080/assets/samples/PurchasingExample.csv",
"created_at":"2022-07-14T10:02:27.2154161+03:00",
"finished_at":"2022-07-14T10:02:29.1723593+03:00"}}

Hey,
I suppose this is an issue with my machine running windows. If i understand the error correctly it just means that it cant find the sh command in windows cmd?
{"job":{"id":"eb80a231-0342-11ed-b7d7-fc34974ac7f4",
"status":"failed",`
"error":"exec: \"sh\": executable file not found in %PATH%",
"callback_endpoint":"http://example.com/callback",
"event_log":"http://localhost:8080/assets/samples/PurchasingExample.csv",
"created_at":"2022-07-14T10:02:27.2154161+03:00",
"finished_at":"2022-07-14T10:02:29.1723593+03:00"}}

@JonasBerx Oh, yeah. I'm packaging the web server together with Python CLI into a Docker image now. Then we can forget about running binaries of the web server under different OS, everything will be from the same Docker container with Linux.

@JonasBerx Hey, few changes here:

Docker image is publicly accessible via docker pull nokal/waiting-time-backend.
Public server is up at http://<IP_ADDRESS>. You can see all the jobs at http://<IP_ADDRESS>/jobs. It has few computing resources at the moment.

So, you can try using the last option for your development as it should be the easiest, but in case you want to see backend logs, then you can try via Docker on your own.

@JonasBerx Hey, I've updated the web service which now returns all the data. I'm still verifying if the calculations are correct, but all the fields are there. You can see an example at http://<IP_ADDRESS>/jobs/9b3b010c-08e7-11ed-b405-0242ac110002

@JonasBerx Wait a sec, I'm renaming some fields, so they correspond to what David has sent to us

@JonasBerx Updated, here's it http://<IP_ADDRESS>/jobs/2d7261f0-08f4-11ed-90e9-0242ac110002

@iharsuvorau Is the server down by any chance? Connection gets refused

@JonasBerx Yes, it is. I'm switching to Docker Compose, but it's not so quick. The default version is old. Upgrading...

Oki, no worries!

@JonasBerx Alive now. I'll be restarting it today more than usual, but it should take now only seconds to restart.

@JonasBerx There're some changes in responses.

I removed the "job" key when returning a single job from GET /jobs/{id} and from POST /jobs{
    "id": "45966fdf-09d1-11ed-95fe-0242c0a85002",
    "status": "pending",
    "callback_endpoint": "http://example.com/callback",
    "event_log": "http://<IP_ADDRESS>/assets/samples/manual_log_5.csv",
    "created_at": "2022-07-22T18:16:33.86575522+03:00"
}

If there's an error, the response would be just an object with error string field.{
    "error": "job with id c00f10d1-09b2-11ed-9ed6-0242ac1d0002 not found"
}

Specification is now published at http://<IP_ADDRESS>/api/.

@JonasBerx POST /jobs can now accept an event log in the request body. Here's a curl request example:
curl --location --request POST 'http://<IP_ADDRESS>/jobs' \
--header 'Content-Type: text/csv' \
--data-binary<EMAIL_ADDRESS>
It's important to set up Content-Type: text/csv, because that's how the type of the request body is identified.

@iharsuvorau
Hey,
I'm running into an issue with posting a new job.
Not sure what is causing it..
~
{"id":"71e02868-0bf2-11ed-9592-0242c0a87002","status":"failed","error":"exit status 1","event_log":"http://<IP_ADDRESS>/assets/results/71e02868-0bf2-11ed-9592-0242c0a87002/event_log.csv","event_log_md5":"2c360084d1bc655b6ae0d7e17356b751","created_at":"2022-07-25T11:19:03.886381128+03:00","finished_at":"2022-07-25T11:19:08.999751084+03:00"}]}
~

@JonasBerx Hi, headers are correct, the body is incorrect. The content of the body should be the event log itself in binary, no JSON should be provided if you use text/csv as a content type.
When I check the event log that have been decoded from your request, I see the following:
$ cat assets/results/71e02868-0bf2-11ed-9592-0242c0a87002/event_log.csv
{"event_log":{"path":"20linetestdata.csv"},"callback_endpoint":"http://example.com/callback"}

Which means, JSON was sent as CSV, so I saved JSON as an event log and the CLI tool crashed trying to read it. I agree error messages need to be improved though :)
If you use Postman, you can encode CSV into the request body by specifying "Body" -> "binary".

With curl, you can do
curl --location --request POST 'http://<IP_ADDRESS>/jobs' \
--header 'Content-Type: text/csv' \
--data-binary<EMAIL_ADDRESS>

@iharsuvorau
I should have asked this before.
The names of the header of each column are different than the csv files I was using. This also caused parsing crashes I think.
Regardless, issues are resolved now :)

@JonasBerx Hi, there're some updates deployed.

CTE calculations updated

Global CTE impact now moved inside the report
Transition level CTE impact added
process_cte field added
total_pt field added

DELETE /jobs endpoint added. It removes all the data. It's useful for debugging, because when I need to recalculate the same log with new fields added, the server treats a job as a duplicate and does nothing. I'll hide it later under a password
API specification is updated. See "Models → JobResult" at http://<IP_ADDRESS>/api/

@JonasBerx One more update:

CTE impact per resource transition added too. See http://<IP_ADDRESS>/jobs/41aab615-0e85-11ed-bf59-0242c0a8c002 as an example

Backend should have now all the data available.

Hi @JonasBerx. A couple of updates:

Calling the callback endpoint is implemented now in case you need it. You don't if you use event log uploading via a request body though.
Jobs older than 1 month are periodically removed now.

I'm closing this mega-issue now. If you found or need something else, please, feel free to open a new issue.

@iharsuvorau
Thanks a lot! Have a nice holiday!


Add call options parameter to all Access API gRPC client functions

Fixes: #125
Description
This PR adds the ...grpc.CallOption parameter to all Access API gRPC client functions on client.Client, allowing the caller to configure the functionality of the underlying gRPC client.
cc @yndc

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Code follows the standards mentioned here.
[ ] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

I looked at the PR without any background, but it did strike me as having a lot of redundant parameters in each function.
Did you consider doing something like this?
client.WithOptions(opts...).Ping(ctx)
client.WithOptions(opts...).GetLatestBlockHeader(ctx, true)

In fact, looking at it now, I don't see a reason not to extend it to the context itself:
client.Ping()
client.WithContext(ctx).GetLatestBlockHeader(true)
client.WithOptions(opts...).GetTransactionResult(txID)
client.WithContext(ctx).WithOptions(opts...).GetEventsForHighRange(query)

@psiemens what do you think?

@awfm9 I thought about implementing it using something like WithOptions, but after looking at the grpc godoc, it looks like some of the options are only meant to be used once (e.g. grpc.Header(&h) mutates a value at a pointer). I didn't want to stray too far from the underlying gRPC implementation in case there were unintended side effects (now or in the future).


jinja2: fix dependencies

Motivation for this change
Jinja2 had a missing dependency on setuptools, uncovered while trying to use llvm-cov+gcovr with meson:
Traceback (most recent call last):
  File "/nix/store/zg111qhdg44rhahz51ixd6dfrwafsasz-python3.8-gcovr-4.2/bin/.gcovr-wrapped", line 9, in <module>
    sys.exit(main())
  File "/nix/store/zg111qhdg44rhahz51ixd6dfrwafsasz-python3.8-gcovr-4.2/lib/python3.8/site-packages/gcovr/__main__.py", line 253, in main
    print_reports(covdata, options, logger)
  File "/nix/store/zg111qhdg44rhahz51ixd6dfrwafsasz-python3.8-gcovr-4.2/lib/python3.8/site-packages/gcovr/__main__.py", line 368, in print_reports
    generator(covdata, output.value, options)
  File "/nix/store/zg111qhdg44rhahz51ixd6dfrwafsasz-python3.8-gcovr-4.2/lib/python3.8/site-packages/gcovr/html_generator.py", line 107, in print_html_report
    data['CSS'] = templates().get_template('style.css').render(
  File "/nix/store/zg111qhdg44rhahz51ixd6dfrwafsasz-python3.8-gcovr-4.2/lib/python3.8/site-packages/gcovr/html_generator.py", line 36, in __call__
    return self.get()
  File "/nix/store/zg111qhdg44rhahz51ixd6dfrwafsasz-python3.8-gcovr-4.2/lib/python3.8/site-packages/gcovr/html_generator.py", line 25, in load
    result = fn()
  File "/nix/store/zg111qhdg44rhahz51ixd6dfrwafsasz-python3.8-gcovr-4.2/lib/python3.8/site-packages/gcovr/html_generator.py", line 46, in templates
    loader=PackageLoader('gcovr'),
  File "/nix/store/2qix64mfl3mw7n76z5ii7plrmms51x2g-python3.8-Jinja2-2.11.2/lib/python3.8/site-packages/jinja2/loaders.py", line 233, in __init__
    from pkg_resources import DefaultProvider
ModuleNotFoundError: No module named 'pkg_resources'

Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Originally PR #96381, rebased it on staging in this one.

Fixed the commit name

@jonringer It is already targeting the staging branch

sorry, didn't see that