[elasticsearch] Add upgrade integration test

This test will install the latest chart release and then attempt to
upgrade to what is currently in git. This is designed to test two
things.

That any changes do not happen to the statefulset that isn't allowed
by Kubernetes. An example of this happening is #94 where the change
was not caught as part of pull request testing but was luckily caught
during manual testing before the release.
That a rolling upgrade actually works and results in a healthy
cluster at the end. The test will always override the
"terminationGracePeriod" to make sure that a rolling upgrade is always
done even if there are no changes.

Kubectl and helm have also been updated to the latest releases. Oddly
enough there was a breaking change in the mock value used for release
names where it is now lowercased for some reason.
The kubectl upgraded was needed to get the handy timeout flag for the
kubectl rollout statuscommand to make sure that jobs don't hang
forever if something does actually go wrong. This command is needed
because the helm --wait flag only works apps/v1 resources. See
https://github.com/helm/helm/issues/3173 for more information.

CI failure when downloading kubectl despite having 5 retries. jenkins test this please
curl: (7) Failed to connect to 2607:f8b0:4001:c15::80: Cannot assign requested address
The command '/bin/sh -c curl --retry 5 -O https://storage.googleapis.com/kubernetes-release/release/v${KUBECTL_VERSION}/bin/linux/amd64/kubectl &&     mv kubectl /usr/local/bin/ &&     chmod a+x /usr/local/bin/kubectl &&     kubectl version --client' returned a non-zero code: 7
make: *** [build] Error 7

Jenkins test this please


TLSProxy using random ports

For quite a while now, the test recipes that use TLSProxy were stuck with the same hard coded ports, which meant that if you wanted to run several test suites at the same time, you had to be careful so TLSProxy based tests wouldn't overlap (in practice, you simply wouldn't run several test suites at the same time).
No longer.  With this change, the ports used by TLSProxy are chosen at random.
This adds a small feature to openssl s_server, the possibility to write the accepting address and port to a file.

Another annoying chip off my shoulder.

Where does output from s_server go? Why not instead of writing to a file and attempting to synchronize on its content (with delay loop) just have s_server write which port it ended up listening on on standard output? I mean as you get the modified ACCEPT line with port number, you know it's listening already... Well, it might be inappropriate suggestion, because it seems to be fork-n-exec and not open("cmd |"). Though one can still wonder if one can play with pipe...

If we make it a pipe open, it means we may have to care about the rest of the s_server output, which adds multiplexing to the problem.

Did you consider using environment variables?

Not much. I have a vague memory telling me we'd rather avoid that, but that may be wrong. What would be the benefit of environment variables over command line options?

If the use of environment variables isn't seen as a new feature (and central thereby get into already released versions), then I'm all for it! 😉

We said making the tests faster was okay, so making it possible to run multiple tests also seems okay.  The advantage of the environment is that you don't need s_server to output anything.  Not sure if that's a big deal or not.

I thought you were thinking that we could pass the portfile name down to s_server with en envvar instead of an option. That would, of course, be possible.

I was thinking that whoever starts tlsproxy, and all the other tests, would set the env var.  Maybe that's not feasible.

No, because one of the sockets that gets a random port is the accept socket inside s_server (by ways of using -accept 0, which is already supported, although more by negligence than any actual forethought).

If we make it a pipe open, it means we may have to care about the rest of the s_server output, which adds multiplexing to the problem.

open SAVEDIN, "<&STDIN";

open STDIN,"sh -c 'while [ 1 ]; do echo foo; sleep 1; done' |";

$a=<>;                  # read 1st line
open NULL,"$^X -n |";   # sink the rest

print "cought:",$a;

open STDIN,"<&SAVEDIN";

while (<STDIN>) { print; }

@dot-asm, that "sink the rest" line is exactly the problem! Why would you want to throw away output that could be useful to figure out problems as they appear?

"sink the rest" line is exactly the problem!

It was an example that one can snatch some output and then forget about the rest without having to multiplex. If one wants to keep output from first program visible, one can do that too, just replace "sink" line for example[!] with
if (fork() == 0) { exec ("$^X -ne print"); }

Ohhhh!  The intricacies of perl that I haven't quite grasped yet...

@dot-asm, after having tried a number of variants of your example, it seems that it needs a bit of fleshing out for the sake of Windows.  From what I'm reading on perlmonks (for example), we're treading in murky waters, and I have to admit that I'm a bit lost for the moment...

Another possibility would be using a port range, say 4000..5000
and look for two free port numbers, say N, and N+1.  N is even.
Then close N+1 again and start the server.
It would have the advantage, that you could predict the ports and filter
accordingly in wireshark when only one make test process runs,
but still parallel tests would be able to use N+2, N+3, or N+4, N+5

Hmmm, so what happens between closing N+1 and the server starting to listen on it?  No chance anyone else will pick up that port by pure chance?

No chance anyone else will pick up that port by pure chance?

At least not another instance of make test.

At least not another instance of make test.

Is that good enough, do you think?

Yes, actually there are also other small chances for test failure.
For instance what I mention at #5067 at the second last comment
it could happen every time, but the chances are really low.
Also what I tried with handling the Fragmented packets #5726 works
in general, but it would not work if the fragments are too small.

From what I'm reading on perlmonks

Well, passing STD* descriptors always works and that's what we should aim for. In sense that they are sufficient and it's perfectly possible to pull it off.
As for passing file descriptors on Windows. What is file descriptor on Windows and how would you describe it to called program? By fileno()? No go. Trouble is that fileno is an index in internal user-land table (and not real Windows descriptor that is obtained with CreateFile and can be inherited by new process), and without real fork it takes dedicated effort to populate this table in newly created process, (and this is not the place to do that).


🚀 Feature: GUI Adjustment Options

🔖 Feature description
I would like the ability to adjust the layout of the page the end-user sees when landing on the share page. A big one being... a BIG download button.
🎤 Pitch
I'm migrating off other third party download services and clients are use to BIG download buttons to get the file fast. I know this sounds strange, but some clients don't know what the little download icon is.

For user specific changes like changing the size of the button, you have to fork the project and edit the code by your own. You can learn more about setting up the project in the CONTRIBUTING.md and in the issue #366.


[5.8] add Illuminate\Database\Schema\Blueprint type hint to table creating

add Illuminate\Database\Schema\Blueprint in the tests for better type hinting

I agree to use type-hint more. I don't think this pr will be merged because the framework has a lot of callbacks without type-hint. Container binding callbacks are other examples. It depends on Taylor's opinion.

So, all these callbacks without types could be eliminated step-by-step. Start from a tests is a good thing, because this change completely backward compatible.

I will merge this but I don't want any mass PRs to add type-hints everywhere in the tests.


Fix typo

a Azure -> an Azure

@changeworld : Thanks for your contribution! The author, @linda33wj, has been notified to review your proposed change.

Verified editorial corrections.


Missing scroll bar

Hello,
I noticed when using this theme there is no scroll bar on the side, it appears to be covered by the user list that floats. Is there an option to return it somewhere to view where the conversation is/had left off?

enable it in the config
--srollbars


Added alias and disable functionality

Added alias and ability to disable all event tracking or specific events (matches how the JS library does it)

Closing this stale PR.


Add doorbell.io feedback overlay

As discussed - this gives us a generic feedback form for the site.
Closes #130.
Replaces #147, but cherry-picks the selenium commit from that.

looks like we've got some unhappy selenium tests...

Must be something missing from that refactor commit. I'll have to take a look Monday, got to go shortly.

Looks good to me.


Shouldn't go to signin page once logged in.

Describe the bug
When user logs in and go back or go to the signin page url, he is allowed to go, which is not supposed to.
To Reproduce
Steps to reproduce the behavior:

Go to 'Signin page'
Login
Go back
See error

Expected behavior
It shouldn't allow user to go to signin page once logged in
Additional context
I would like to work on this issue under GSSoC21.
Please assign this to me.

@sanjay270899
Please assign this to me


Fixed #35365 -- Add RFC 3824 Auto-Submitted header to emails by default

Implemented the default behaviour of attaching Auto-Submitted : auto-generated header to emails by default. Created subclass of EmailMessage that allows users to opt-out of this default. Added unit tests for this added functionality.
Trac ticket number

ticket-35365
Branch description
RFC 3824 (https://www.rfc-editor.org/rfc/rfc3834) defines the Auto-Submitted header for emails to avoid mail loops. Based on this, the EmailMessage class now attaches a default header of "Auto-Submitted : auto-generated" to emails. The user can opt-out of this default by using the NoAutoSubmittedHeaderEmailMessage subclass. This will remove the "Auto-Submitted : auto-generated" header.
Checklist

[x] This PR targets the main branch.
[x] The commit message is written in past tense, mentions the ticket number, and ends with a period.
[x] I have checked the "Has patch" ticket flag in the Trac system.
[x] I have added or updated relevant tests.
[x] I have added or updated relevant docs, including release notes if applicable.
[ ] For UI changes, I have attached screenshots in both light and dark modes.

This is just minor syntax fixes for previous comments. I am going to implement the changes mentioned in the Trac Ticket thread in the next iteration of the PR.


Build failure with Enum under Pydantic 2.1, autodoc-pydantic 2.0.0

I am receiving doc build failures when trying to use an enum in a pydantic model.
Repo:

Copy the code fragment from https://docs.pydantic.dev/latest/usage/types/enums/:

from enum import Enum, IntEnum

from pydantic import BaseModel, ValidationError

class FruitEnum(str, Enum):
    pear = 'pear'
    banana = 'banana'

class ToolEnum(IntEnum):
    spanner = 1
    wrench = 2

class CookingModel(BaseModel):
    fruit: FruitEnum = FruitEnum.pear
    tool: ToolEnum = ToolEnum.spanner

Include .. autopydantic_model:: mymodule.CookingModel in your RST file.
Build the docs.

Exception occurred:
  File "/Users/nagledb/Library/Caches/pypoetry/virtualenvs/myproject-B9PtQW94-py3.8/lib/python3.8/site-packages/sphinxcontrib/autodoc_pydantic/inspection.py", line 195, in get_given_constraint_keys
    field_schemas = definition["schema"]["schema"]["fields"]
KeyError: 'schema'
The full traceback has been saved in /var/folders/kf/kxls27sn2_qcslc3nhgrg7j40000gq/T/sphinx-err-fv0oyxyr.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
make: *** [html] Error 2

Full log is here: sphinx-err-fv0oyxyr.log
I am running python 3.8.16. Some of my relevant package versions:
autodoc-pydantic==2.0.0
pydantic==2.1.0
pydantic-settings==2.0.2
pydantic_core==2.4.0
Sphinx==5.1.1
sphinxcontrib-applehelp==1.0.4
sphinxcontrib-devhelp==1.0.2
sphinxcontrib-htmlhelp==2.0.1
sphinxcontrib-jsmath==1.0.1
sphinxcontrib-qthelp==1.0.3
sphinxcontrib-serializinghtml==1.1.5

@nagledb Thanks for raising this issue here! I can confirm, this is definitely a bug. This part of the code adjustments for pydantic v2 is actually the most shaky part, too. Hence, it is great to spot this bug early on.
Thanks to @jerryjiahaha who already provided a PR fixing the bug :-).
Expect this bug to be fixed within the next days.

@all-contributors please add @nagledb for bug

@all-contributors please add @jerryjiahaha for code

Bug is fixed a new version v2.0.1 can be installed via pip install "autodoc_pydantic>=2.0.1,<3.0".


enable_stats -- error claiming chunk

What happened?:
Multiple users have hit:
{"pipelineName":"pachy_trait_domainscan","workerId":"pipeline-pachy-trait-domainscan-v1-njvc5","ts":"2019-05-16T18:38:50.725926205Z","message":"worker: watch closed or error running the worker process: acquire/process/merge datums for job f48a26d8f1984f2f91502590b918390c exited with err: error claiming/processing chunk: tagGetter: tag d8ba5b5f8c12b3c1b1f512a27192dff26899a9808e9f5a679c594cbe66312b8d9aac_stats not found; retrying in 954.512469ms"}

Turning off stats resolves error and job succeeds. One user hit this when turning on stats on a pipeline that didn't have it on beforehand. Another user says this was hit upon initial creation of the pipeline, not an update.
What you expected to happen?:
How to reproduce it (as minimally and precisely as possible)?:
We do not have clear repro steps.
For 2nd user above, another error they saw in the logs at the same time (not sure if related, but also went away after updating pipeline with stats off):
019-05-16T18:35:44Z ERROR pfs.BlockAPI.Obj.PutObject {"duration":1.034683815,"error":"rpc error: code = Canceled desc = context canceled","request":null} []
Anything else we need to know?:
Environment?:

Kubernetes version (use kubectl version):
Pachyderm CLI version (use pachctl version): 1.8.6
Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s):
OS (e.g. from /etc/os-release):
Others:

@brycemcanally this is fixed in 1.9rc3, correct? please reopen and clarify if not


Upload signatures to transparency log

What type of PR is this?
/kind regression
What this PR does / why we need it:
Images signed with krel are failing verification. This can be observed in build-master job: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-build/1661016905332297728
level=fatal msg="failed to run: push container images: publish container images: get manifest images: traversing path: executing tarball callback: sign container image: retrying image verification: timed out waiting for the condition"

I tried running following two commands locally:
cosign verify gcr.io/k8s-staging-ci-images/conformance-amd64:v1.28.0-alpha.0.1136_61d455ed1173cd<EMAIL_ADDRESS>--certificate-oidc-issuer=https://accounts.google.com

cosign verify gcr.io/k8s-staging-ci-images/conformance-amd64:v1.28.0-alpha.0.1136_61d455ed1173cd --certificate-identity-regexp='.*' --certificate-oidc-issuer-regexp='.*'

Both commands are returning the following error:
Error: no matching signatures:
signature not found in transparency log
main.go:69: error during command execution: no matching signatures:
signature not found in transparency log

Looking at logs for the job, the image is signed. I also verified this by checking if the signature is pushed to the registry and it is.
# crane digest gcr.io/k8s-staging-ci-images/conformance-amd64:v1.28.0-alpha.0.1136_61d455ed1173cd
sha256:41a10d692d0b329d721a09e564f26291d90fbcf9425fc4f609645cde7ce54036

# crane digest gcr.io/k8s-staging-ci-images/conformance-amd64:sha256-41a10d692d0b329d721a09e564f26291d90fbcf9425fc4f609645cde7ce54036.sig
sha256:84dc96359db3b4f558208ecaf84a121458530632e9fc73059c5bb7ba58dd7b57

Given the error shared above, I think we need to upload signatures to the transparency log which we're not doing right now. This PR proposes doing this both for images and files.
Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?
NONE

/assign @cpanato @saschagrunert
cc @kubernetes-sigs/release-engineering

maybe we can pass this as a settings


import pre-srfi about the http1.1-parser

Or maybe rely on chicken's egg.

Either is fine by me.

The branch is at https://github.com/scheme-live/live/pull/62


Updates to PointSet and Bound

Moved some tests. Corrected some pointset distance from behavious, etc.
Fixes #12, #13 and #15.  Kind of fixes #14 by just removing the geocentroid function. As that seem overkill at this time. @mlerner

LGTM


Variables does not work with pagination

Describe the bug
I have set up a query with a @paginate attribute in a +page.gql file with a +page.ts handling variables for sorting (and I will add filtering later). The initial load works just fine but the next load caused by .loadNextPage() causes the request to fail as the sorting parameter is not included in the request. Only the pagination parameters are included.
I propose this could be fixed by simply including all variables in the initial request in all subsequent requests.
Severity
serious, but I can work around it
Steps to Reproduce the Bug

Create a +page.gql file like this (I specifically use Hot Chocolate in the server but it should be similar to how other server frameworks handles sorting):

query GetElements($order: [ElementSortInput!]!) {
    ships(first: 10, order: $order) @paginate(name: "Elements") {
        edges {
            node {
                field
            }
        }
    }
}

Create a +page.ts file like this:

import type { GetElementsVariables } from "./$houdini";

export const _GetElementsVariables: GetElementsVariables = () => {
    return {
        order: [
            {
                field: "ASC",
            },
        ],
    };
};

Create a +page.svelte file like this:

<script lang="ts">
    import type { PageData } from "./$houdini";
    export let data: PageData;
    $: ({ GetElements } = data);

    async function loadNext() {
        await GetElements.loadNextPage();
    }
</script>

<!-- Irrelevant HTML implementation that calls loadNext on certain occations.
    -->

.loadNextPage() make requests that fail.

Reproduction
No response

I figured out why this happened. I used a network plugin in the client to make my requests like how it was done before the current iteration of HoudiniClient was implemented. This made it so data (or possibly error) were the only fields in the result value, which means variables was missing. This caused the pagination logic to not include any extra variables in the following requests. Could you possibly add some kind of warning about this?

Ahhh makes total sense! I'm surprised there wasn't a type error. Do you have any ideas for how we could detect this situation?

I used to have a plugin that looked like this (but very simplified):
const plugin: ClientPlugin = () => {
    return {
        async network(context, { resolve }) {
            const result = await context.fetch!("/graphql", {
                method: "POST",
                body: JSON.stringify({
                    query: context.text,
                    variables: context.variables,
                }),
            });
            const responseContent = await result.text();
            const response = JSON.parse(responseContent);
            resolve(context, response);
        },
    };
};

export default new HoudiniClient({
    url: "/graphql",
    plugins: [
        plugin,
    ],
});

The result of JSON.parse should be a QueryResult but it clearly is not since the server only responds with an object with a data or error field. This is a problem inherent to Typescript because of the any type being cast to a QueryResult.
Is there any particular reason why it's the client's responsibility to pass back variables along with fetching, partial, stale and source? To me, a client would simply make requests and pass the responses back to a framework that would take care of these values internally.
Where are these fields added to the result? As it stands right now, I don't see how network plugins could be used at all since these fields would have to be added manually. For instance, how would one currently use a custom fetch function?

I have just encountered such a case. I need to inject some logic that depends on the returned status code (specifically to reload the page on 401 responses to re-authenticate the user). I have managed to solve it through monkey-patching like this:
if (browser) {
    const realFetch = fetch;
    window.fetch = async (
        input: RequestInfo | URL,
        init?: RequestInit | undefined,
    ): Promise<Response> =>
        new Promise((resolve, reject) =>
            realFetch(input, init)
                .then((response) => {
                    if (response.status === 401) {
                        location.reload();
                    } else {
                        resolve(response);
                    }
                })
                .catch(reject),
        );
}

However, it's not a very elegant solution. Could this logic be injected some other way without causing any other problems?

Yea, I agree the plugin API could be cleaned up a bit in that respect. Those values are there because its easy to do and it keeps things simple. I think eventually some of these fields would be marked optional and the values from ctx could be inferred instead of making you pass it manually like i do in the default fetch plugin.
I'm going to close this issue since the original bug is no longer a problem but we can keep the conversation going 👍


Support ObservedBy on parent model classes

When an Eloquent model extends another Eloquent model, the check for the ObservedBy attribute only considers the class itself. Any observers registered in the parent model are ignored.
This change adds support for the ObservedBy attribute in parent classes and traverses the hierarchy until the top Model class is reached.

Hey there! Could we get a test for this? Also should it keep going back up the tree in case there are multiple extensions?

@taylorotwell You're too fast! :) I added another couple of commits after the initial draft pull request. These address the tree traversal issue you're asking about.
Will add a test ASAP.

@taylorotwell Added a test. (Sorry about the sloppy commit history.)

Thanks!

This is a breaking change for me as I have a parent observer that creates polymorphic relationships, the grandchild model can't have these and doesn't have a morph map value.
Here is another example:
class MessageObserver
{
    public function created(Message $message)
    {
        // send to all users
    }
}

#[ObservedBy(MessageObserver)]
class Message extends Model {}

class AdminMessage extends Message {}

Previously, creating an AdminMessage wouldn't send a notification to all users, now it is.
This PR takes away the granularity of adding the ObservedBy attribute where it's needed and assumes it can run for all child models.
Should we check for instanceOf in the observer methods?

@patrickomeara hmm, tough call. I would say that the change we made is in line with the way other things work in the framework in general. For example, putting ShouldQueue on a parent class and dispatching the child class to the Bus will in fact queue it. Same with mail, notifications, etc.

@taylorotwell OK, that makes sense. Staying in line across the framework is the correct approach. In my case I will remove the inheritance and use the same table name. It's a hangover from a long time ago and feels like an anti-pattern now.


php7{2,3}: fix darwin build

Motivation for this change

Backported patches from php-7.4 which fixes the env for all
gettext and zlib tests.
Setting --with-libxml-dir is still needed for versions 7.2 and 7.3.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ofborg build php72 php73

@etu can we merge?

@Ma27 Yep! I was just afk from that the build went through until recently :)


Issue with useLocalMdxForm hook

Description and Steps to reproduce
I am trying to add some article whose source is using mdx to the Tina CMS. I have a query like so narrowed down to a particular article
const pageQuery = graphql`
query MyQuery {
    allSite {
      edges {
        node {
          siteMetadata {
            name
          }
        }
      }
    }

    mdx(id: { eq: "4000b1cf-fced-50f5-9984-c8a0b8141e6c" }) {
      id
      excerpt(pruneLength: 160)
      rawMdxBody
      frontmatter {
        title
      }
      ...TinaMdx
    }
}
`;

Then in the template that renders article
...
  const data = useStaticQuery(pageQuery);
  const [mdx] = useLocalMdxForm(data.mdx);
<h1>{mdx.frontmatter.title}</h1>
...

When I visit the page for that article,
In my terminal I see this error
 ERROR

fatal: Path 'www/content/posts/2019-04-30-why-we-built-a-company-before-a-product/index.mdx' exists, but not 'content/posts/2019
-04-30-why-we-built-a-company-before-a-product/index.mdx'.
Did you mean 'HEAD:www/content/posts/2019-04-30-why-we-built-a-company-before-a-product/index.mdx' aka 'HEAD:./content/posts/2019-04-30-why-we-built-a-company-before-a-product/index.mdx'?

In the browser console I see this error
react-beautiful-dnd
An error has occurred while a drag is occurring.Any existing drag will be cancelled.> Uncaught Error: Token type `s_open` not supported by Markdown parser

The errors are the same even when I use the mdxForm HOC
Expected result
Tina CMS form where I can edit content in the article
Actual result
Article page crashes with the errors described above
Environment
Chrome browser
Gatsby
gatsby-novela-theme
Tinacms Package Versions

├─┬<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   ├─┬<EMAIL_ADDRESS>│   ├─┬<EMAIL_ADDRESS>│   ├─┬<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   ├─┬<EMAIL_ADDRESS>│   ├─┬<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   ├─┬<EMAIL_ADDRESS>│   ├─┬<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   └─┬<EMAIL_ADDRESS>│     ├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>

Tools

Tool
Version

browser
Google Chrome

os
MacOS High Sierra

node
v10.20.1

npm
6.14.4

react-beautiful-dnd
An error has occurred while a drag is occurring.Any existing drag will be cancelled.

This part about react-beautiful-dnd is red herring. It just happens to be the component that caught the error.

Uncaught Error: Token type s_open not supported by Markdown parser

It looks like your content has a strikethrough in it, which is currently not supported by the markdown editor. I assume that's something like:
~test~

I know @jpuri is doing some refactoring at the moment in the hopes of making the wysiwyg more configurable. Perhaps strikethroughs can be made available after that?

@ncphillips I cannot thank you enough for this comment. Everything works well now. I can't believe something that small was the issue. The only good thing from this is I read a lot of the lower level tina cms code. Thanks a lot 🎉

@ncphillips one more issue, I hope you still have some time.
When I type in the form, I get this error. For context I am now using the HOC mdxForm
react-dom.development.js:12213 Uncaught useMdxForm(mdx) 'mdx' was not found on the top node of the graphql query

1. Check if the 'mdx' attribute is included in the GraphQL query. For example:

export const pageQuery = graphql`
  query BlogPostBySlug($slug: String!) {
    mdx(fields: { slug: { eq: $slug } }) {
      ...TinaMdx
      // etc...
    }
 }

2. If you are using an alias, For example:

   export const pageQuery = graphql`
     query BlogPostBySlug($slug: String!) {
       mdx: mdx(fields: { slug: { eq: $slug } }) {
          ...TinaMdx
       // etc...
       }
    }

  then you can optionally use the 'queryName' option to specify a new property in place of 'mdx':

    export const mdxForm(BlogPostTemplate, { queryName: mdx })

The mdxForm HOC expects the data to be on an attribute named mdx. Could you post what youre graphql query looks like?

Yep sure we can works to add strike-though support to editor soon. It is actually not part of common marks spec, though ~~text~~ is popular markdown representation for it.

My query is the same as the one in the issue description.

The mdxForm HOC expects the data to be on an attribute named mdx. Could you post what youre graphql query looks like?

export const pageQuery = graphql`
query ArticleBySlug($slug: String!) {
    allSite {
      edges {
        node {
          siteMetadata {
            name
          }
        }
      }
    }

    mdx(fields: {slug: { eq: $slug } }) {
      id
      excerpt(pruneLength: 160)
      rawMdxBody
      body
      frontmatter {
        title
      }
      ...TinaMdx
    }
}
`;

The mdxForm HOC expects the data to be on an attribute named mdx. Could you post what youre graphql query looks like?

Error happens as I type in the form and ultimately the page crashes


Chunking WiFi client writes in the HTTP client to handle large file sizes

This code changes the way data is written to the WiFIClient. Instead of sending the data in one block, it is sent in chunks of 1024 bytes.
This fixes #19.

Thanks!


boards: stm32: Move STM32 boards SPI pin configuration to device tree

Move SPI pin configuration to device tree for all STM32 based boards.
This should not bring any change in pin configuration.
Though, some adjuments have been made on following boards for coherency:

b_l4s5i_iot01a1: Removed "very-high-speed" on SPI3 MOSI pin.
Tested with no impact.
black_f407zg_pro: SPI1 pins configured but not SPI1 node.
Removed pin config as not documented neither.
sensortile_box: SPI2 pins configured but not SPI2 node.
Removed pin config as not documented neither.
nucleo_g431rb/nucleo_g474re/nucleo_l476rg/nucleo_l4r5zi:
SPI2 and SPI3 pins were configured but missing.
Added since they were documented.

Based on https://github.com/zephyrproject-rtos/zephyr/pull/29231

Removed BK commit and merged.


libcpr: 1.10.5 -> 1.11.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/libcpr/cpr/releases.
meta.description for libcpr is: C++ wrapper around libcurl
meta.homepage for libcpr is: https://docs.libcpr.org/
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.11.0 in filename of file in /nix/store/zlyv6x4mkz1wwrn6rv0z6pcgd990ig5i-libcpr-1.11.0

Rebuild report (if merged into master) (click to expand)

7 total rebuild path(s)

7 package rebuild(s)

First fifty rebuilds by attrpath

influxdb-cxx
kazv
libcpr
libkazv
maa-assistant-arknights
maa-cli

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zlyv6x4mkz1wwrn6rv0z6pcgd990ig5i-libcpr-1.11.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libcpr https://github.com/r-ryantm/nixpkgs/archive/a2e314ee3111895046b6e1a2cff3ef5b6265a186.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/a2e314ee3111895046b6e1a2cff3ef5b6265a186#libcpr

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zlyv6x4mkz1wwrn6rv0z6pcgd990ig5i-libcpr-1.11.0
ls -la /nix/store/zlyv6x4mkz1wwrn6rv0z6pcgd990ig5i-libcpr-1.11.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:x: 3 packages failed to build:

influxdb-cxx
maa-assistant-arknights
maa-cli

:white_check_mark: 2 packages built:

libcpr
libcpr.dev

Maintainer pings
cc @rycee for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

The dependency failures seem to be due to https://github.com/libcpr/cpr/pull/1104. Will update the package to build shared or static based on stdenv.hostPlatform.isStatic.

Will do this version update in the above PR. Closing this.


[WIP] Register ECS Task

What is this PR trying to achieve?
We need to know when a requested task has been completed, this PR will provide a dynamo table from which that event stream can emanate.
Who is this change for?
💻
Have the following been considered/are they needed?

[ ] Deployed new versions
[ ] Run terraform apply.

For https://github.com/wellcometrust/platform/issues/1005

Closing as not needed.


Reimplement Spread/Antiaffinity to not use kubernetes.io/hostname label

Tell us about your request
The current implementation injects a hostname label to force pod separation. However, the hostname is not known until the node is created. This means we need to then strip the label to avoid creating the node with an opinionated hostname. All this mutation results in tricky race conditions with parallel code that assumes immutability (https://github.com/aws/karpenter/issues/1200).
It may be an efficient use of time to rewrite at the same time as fixing https://github.com/aws/karpenter/issues/975

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Completed with pod affinity/anti-affinity PR https://github.com/aws/karpenter/pull/1626


fix(material/tabs): tab header is clickable if its disable

Prior this commit disabled tab header content is clickable and causing event when it shouldn't
Fixes #27071

@crisbeto thoughts on this? I'm not sure if I can rerun the tests without pushing a change.


Krasna Lipa

Dear colleagues,
today I tried to make a map of correspondence. However, the location Krasna Lipa/Krásná Lípa (50.913103, 14.510107) in Czech Republic was not found by Palladio.
The map was not created. Could you please prove what the problem with Krasna Lipa is.
Many thanks,
Zdenek

I have te same problema with Tenerife, Las Islas Canarias: (28.46048042417951, -16.25336765990604).
Help!
Great project.
Luis Mezeta.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_7de0yzs93t/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_7de0yzs93t/clone/recipe/meta.yaml:34: missing_pip_check: For pypi packages, pip check should be present in the test commands
WARNING: /tmp/abs_7de0yzs93t/clone/recipe/meta.yaml:43: missing_description: The recipe is missing a description
Errors were found


MediaManip Upload Box UI Update

Reference

I would like to work on this issue.

Assigned for 3 days


Joining classes should allow user to pin in channel

I think it's good for every student in the class to have pinning permissions.

issue closed literally impossible thank you :) TCBA

probably not impossible

@c650 you have to give class users manage message perms since pins aren't a separate perm. So a random class user can delete someone elses message if you give pin perms

then have a bot command to wrap it

users can either pin via typing a message and then doing !pin which will pin their most recent message, or give their message a designated reaction which will be the pin reaction.
Both do a common discord action that users are familiar with in a hidden, unique to our server way, in an attempt to get around something that discord doesn't support, for something that isn't super needed.
It's not worth breaking the default Discord experience/behavior for this feature imo

fair


--list-of-files cannot open txt file

Which version of the AzCopy was used?
10.17.0
Note: The version is visible when running AzCopy without any argument
Which platform are you using? (ex: Windows, Mac, Linux)
Windows
What command did you run?
azcopy copy --dry-run --recursive https://source.blob.core.windows.net/ https://target.blob.core.windows.net/ --list-of-files https://source.blob.core.windows.net/dir1/copy.txt
ALSO
azcopy set-properties --list-of-files https://source.blob.core.windows.net/ https://source.blob.core.windows.net/dir1/copy.txt
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
What problem was encountered?
failed to parse user input due to error: cannot open source.blob.core.windows.net/dir1/copy.txt file passed with the list-of-file flag
How can we reproduce the problem in the simplest way?
run the commands above logged in with an SP via aad (azcopy -login --service-principal --application-id --tenant-id)
Have you found a mitigation/solution?
NOPE and also not properly described in the documentation
The text file (copy.txt) on the storage account container contains 1 line
https://source.blob.core.windows.net/test/bigddlakes/RAW/DB

Hi @mwarqee,
I believe you are using the list of files parameter incorrectly. Please take a look at this page in our Wiki to learn more about the parameter.

Hi @mwarqee,
I believe you are using the list of files parameter incorrectly. Please take a look at this page in our Wiki to learn more about the parameter.

@gapra-msft - apologies but could you please give an example of how this flag can be used properly? The link you have pointed at contains no examples, and is rather ambiguous. As stated in the page (from 2020) this flag remains undocumented (except for this wiki page).
Questions:

Is the flag applicable only for local to cloud uploads or does it also work from cloud to cloud storage?
Do you have to point to a specific file, or is it enough to point to paths which azcopy copy will then pick up recursively?
If it is only valid for individual files is there another option to use it in the following way:

A txt file stored in a container on Azure Storage (storageaccount.container.blob.core.windows.net/container1/) which contains a list of paths:
storageaccount.container.blob.core.windows.net/container2/dir2/ - copies everything in path dir2
storageaccount.container.blob.core.windows.net/container2/dir3/dir4 - copies everything in path dir4
If the --list-of-files flag is not suitable for this functionality, can you please specify what should be used? If this feature does not exist yet will it be made available in the future?
Thanks!

Closing as I believe the questions have been addressed. Please feel free to reopen in case something else comes up.


Flash: Lightning Network in-memory representation

This commit adds a graph representation of the lightning network and additional
book keeping needed to be done by the FlashNode.
It is missing removal of closed channels, does not take channel fees and balances
in to account.
Fixes #1583

Please self-merge when ready as I'm heading out now.


squid:S1854 - Dead stores should be removed.

This pull request is focused on resolving occurrence of Sonar rule
squid:S1854 - Dead stores should be removed.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1854
Please let me know if you have any questions.
George Kankava

Automated message from Dropbox CLA bot
@georgekankava, it looks like you've already signed the Dropbox CLA. Thanks!

lgtm.


Fixes Android minSdkVersion override

This removes the minSDK from being automatically added to the AndroidManifest.xml file and instead checks that a sufficient minSdkVersion only sets a minSdkVersion when necessary.
Fixes issue: https://github.com/google/cordova-plugin-browsertab/issues/7

I have attempted several times to sign the CLA, but it keeps giving me a A server error occurred, please try your request again. error.

Hey,
Thanks for this contribution! I don't know why you're having trouble with the CLA; if that's still happening I'll try and find someone to help. Unfortunately I can't merge the change until we have confirmation it is signed :(

@iainmcgin, I have tried from multiple computers, using Stable and Canary, incognito mode, even tried from Edge.  Same error with all of them.  No errors in the console and the actual POST request returns 200, so I'm not certain what to do.

I have contacted support with regards to the CLA, I'll let you know what they find out.

I signed it!


add release worklflow artiact fix

bump the commit hash for our release workflow to include fixes to the release process including patching .gitignore to include missing lib directory on release branches

https://github.com/Azure/k8s-deploy/issues/300


feat: add configureBuild hook

This is another approach to the proposed configureBuild hook. (See #870 for the first approach)
In this PR, the configureBuild hooks are called before anything is done by the build function (except initializing the build config). When initializing the build config, it gets deep-cloned and filled with default values, so that configureBuild hooks can more easily inspect & mutate it (without checking for undefined everywhere).
Whereas #870 only exposes the Rollup input options to configureBuild, this PR exposes the entire Vite build config, which allows Vite plugins to better manipulate the build process as needed. This means more powerful Vite plugins will be possible.

I rebased this on top of the latest master - can you apply the changes in #878 to this branch instead?

Done 👍


Provide easy way to shell into the finch vm

What is the problem you're trying to solve?.
Currently, it is not user friendly and a big hassle to shell into the finch vm. I would like to be able to easily shell into the finch vm for debugging and customization instead of having to run LIMA_HOME=/Applications/Finch/lima/data /Applications/Finch/lima/bin/limactl shell finch
Describe the feature you'd like
It would be good to have something like finch shell or finch vm shell to access the underlying finch vm.

Thanks for initializing this issue. There were some discussions about this in different places before and the issue is a good place to close on it.
I prefer not to enable Finch command to log into shell by default. Here is my thought process. The viewpoints below are just my personal recommendation and are not the official statements of Finch yet. Looking forward to gettting community input and hopefully we can settle down some of these principles at some point.
What should the scope of default Finch command (or even any external interfaces) be?
The default Finch commands is ideally a set that is specifically for Finch users to learn and use. It is targetted to accurately meet the scope of what users are expected to use (the scope is defined by user stories). Being smaller than the expected scope will not satisfy user's need. Being larger than the expected scope could increase the unnecessary learning cost of users to learn the things they should not use, and even mislead the approach of using Finch.
Is finch shell part of user stories?
For Finch or other similar container development tools, the user stories are always across the container development operations, such as build, run, push, pull. MacOS doesn't have the container primitive such as namespace and cgroup which causes the user stories can't be directly satisfied in macOS, so Finch macOS integrates the virtualization layer to make the user stories work in macOS. The virtualization layer is the technique behind the scene to support the user stories instead of part of user stories.finch shell will be a command only serving virtualization layer so it is not part of user stories.
Should users use finch shell in normal cases?
No. What users are expected to learn and use are just user stories and they don't have to invest time on learning any technique behind the scene. Additionally, logging into VM exposes to users the risk of corrupting Finch by manual operations. If users use Finch in a strict development environment where Finch should be always healthy to support their development, this risk can be significant.
Should users use finch shell when running into issues?
It depends. Today users sometimes need to log into VM to collect logs and send to support. However running into issues should be treated as rare cases, and may be assumed less and less as the project becomes mature. In addition, there is an ongoing PR to add support bundle, which may give the ability of collecting logs without logging into VM.
Should developers use finch shell?
Yes. Developers are different with users. Developers may be interested in any technologies behind the scene, and have to use them when they develop Finch. LIMA_HOME=/Applications/Finch/lima/data /Applications/Finch/lima/bin/limactl shell finch is not user friendly but is more acceptable to developers.
Instead of default, can we introduce finch shell in the non-default developer mode?
It may be a good idea at some point. However, adding developer mode for single command finch shell only may not be deserved now. Switching to developer mode and running finch shell may not be easier than LIMA_HOME=/Applications/Finch/lima/data /Applications/Finch/lima/bin/limactl shell finch. When we have multiple use cases to support developer mode, it could deserve the effort.

Been thinking about this a bit with https://github.com/runfinch/finch/issues/369, and wanted to add some of my thoughts here:

Is finch shell part of user stories?
For Finch or other similar container development tools, the user stories are always across the container development operations, such as build, run, push, pull. MacOS doesn't have the container primitive such as namespace and cgroup which causes the user stories can't be directly satisfied in macOS, so Finch macOS integrates the virtualization layer to make the user stories work in macOS.

There is already some precedent for Finch breaking this rule -- all of the finch vm subcommands deal with the virtualization layer, not with the container development layer. I agree with you that these are sort of a "necessary evil" in the CLI design, but adding finch vm shell doesn't break the scope of the finch command any more than those commands, imo.
Another option that would allow us to keep the scope of the finch command small while making it easier to shell to the VM would be to package another binary with Finch that manages this scenario, e.g. finch-shell.

Should users use finch shell in normal cases?
No. What users are expected to learn and use are just user stories and they don't have to invest time on learning any technique behind the scene.

I think this is a good argument that finch shell or similar shouldn't be required in the normal use case, but I don't think it's a good argument that we shouldn't make it easier. Making something easier to do doesn't guarantee that people will do it all the time, it simply removes some of the legwork required when a user needs to shell to the VM.
One example of a scenario that currently requires shelling to the VM is increasing vm.max_map_count for Elasticsearch. It's possible to build a different way to change this configuration, but we can't anticipate every use case a user might have. Making shelling to the VM more accessible seems like a good way to help unblock users that need unique setups while we work on a more native solution.

Developers are different with users.

I see your point with the distinction between Finch users and developers, but I think it's also important to keep in mind that Finch users are all developers as well. Obviously not in the sense that you intended -- that they develop actively on Finch -- but in the sense that they are working on solving hard technical problems. We can do our best to provide an opinionated set of tools, but users will run into scenarios that require tools that we haven't anticipated. Making access to the VM easier empowers users to solve these problems with Finch.


benchmarks

I decided on benchmarking the running time of the interpreter and skipping the startup time of rustc + parsing, typeck, MIR generation. There's a commented out benchmark that uses the miri executable instead of directly calling the interpreter. It's really slow, who would've thought ;)
results on fibonacci:
test fib           ... bench:         117 ns/iter (+/- 2)
test fib_iter      ... bench:           1 ns/iter (+/- 0)
test fib_iter_miri ... bench:   8,444,820 ns/iter (+/- 470,079)
test fib_miri      ... bench:   5,431,379 ns/iter (+/- 320,989)

The iterative fibonacci is probably slower because MIR is not optimized. So the for-loop is calling loads of functions, which is bad for miri-performance.
results on running an empty function:
test noop                  ... bench:           0 ns/iter (+/- 0)
test noop_miri_interpreter ... bench:       4,715 ns/iter (+/- 1,077)

@oli-obk Have you tried benchmarking Miri against unoptimized compiled Rust? I'm curious what the average slowdown is from that.

I'm not sure how to do that... but I'll see what I can do.


PubSub: sending failing message to deadletter topic without retries

Hi,
I have a service that processes many (potentially millions) of pubsub messages via a pull subscription. I have configured a deadletter topic for the subscription with retry policy having 5 retries. Suppose I receive an unprocessable message. This can happen due to various reasons, e.g. validation (i do use schemas, but not all complex field validation can be handled by a schema) or some further missing configuration required for the message to be processed or anything that i know is not transient.
Hence, ideally i would like to

do a "terminalNack()" which would send the message to deadletters immediately
On a related performance note, set number of max_attempts to < 5

Otherwise i needlessly do x5 work.
I could manually publish the message to deadletters, but:

i need to do ack() for the message to not be redelivered, which messes pubsub metrics creating a false impression that the message was processed correctly
is harder to use, e.g. need to create publishing client
when message is republished can lose original message properties (like CloudPubSubDeadLetterSourceDeliveryCount and alike)

Strangely i cannot find much info on this. What's the suggested approach? Is this use case so original / am i doing something unexpected?

do a "terminalNack()" which would send the message to deadletters immediately

The behavior you're describing isn't currently supported by Cloud Pub/Sub. If you would like to suggest this as an improvement, please file a ticket here: https://issuetracker.google.com/issues/new?component=187173&template=1162763 We do not have guarantees on when we will implement issues, but issues that have higher number of requests will generally be prioritized.
In the meantime, your workaround seems like the best bet. Re: original message properties, you can copy this over to the message attributes map, though if you aren't retrying the message, then DeliveryCount will likely be 1 anyway.


Added utility cell to ensure Colab usability

Added a utility cell so that Colab works with rpy2 objects, along with a comment.
Otherwise, the ntoebook does not work with Colab.

See slack comments. Sorry not sure how to suggest changes here with the actual file.

With %%capture you can suppress all the output from the first cell.

2 I added the variable ur to the definition of predictors . This variable is included in the stata code but it looks like it got dropped in the R code. In any case, it doesn't visibly change the output. Flag to @Ali Sajid if we need to get the R code changed too.

I added
plt.axvline(1993, linestyle = 'dashed', color = 'black')
plt.show()
to the charts. The first line to match the book and the second line to be pedantic and suppress where some text is printed.


[SPARK-46151][PYTHON][DOCS] Hide the More" drop-down button in the PySpark docs navigation bar

What changes were proposed in this pull request?
The pr aims to hide the More drop-down button in the PySpark docs navigation bar.
Why are the changes needed?
Because there is only one item under the More drop-down button, as following:

Obviously, in our scenario, eliminating More drop-down button and directly displaying Migration Guides menu in the navigation bar is more intuitive and convenient.
After:

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually test.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @HyukjinKwon

Btw, seems like the code-block style is not applied properly in the PR title?

Could you address it?

Btw, seems like the code-block style is not applied properly in the PR title?

Could you address it?

Done, is it OK now?

I guess maybe you wanted to make it looks like:
Hide the "More" drop-down button in the PySpark docs navigation bar ?
or
Hide the "More" drop-down button in the PySpark docs navigation bar ?
But it's not a big deal, so the PR looks still good to me :-)

Merged to master.


could you please let me know where to get config and samples.json for local train

could you please let me know where to get config and samples.json for local train

Hi,
the aesthetic config and samples files for training are
https://github.com/idealo/image-quality-assessment/blob/master/models/MobileNet/config_aesthetic_cpu.json
https://github.com/idealo/image-quality-assessment/blob/master/data/AVA/ava_labels_train.json
The technical files are
https://github.com/idealo/image-quality-assessment/blob/master/models/MobileNet/config_technical_cpu.json
https://github.com/idealo/image-quality-assessment/blob/master/data/TID2013/tid_labels_train.json


make sure minified output is .min.css or .min.js

Suggested by @coolaj86

The reason I haven't done this before is because I don't want to have to add anything to my layouts that determines whether style.css or style.min.css should be used. The min.css extension is just a convention and it's one I don't care to use.
Would .ignore static/**.css work for you?

But wouldn't I want to put my own styles in static/? Isn't that where all static content that's copied to the root of public/ go?

Maybe that could be done as part of how dist-hash replaces the files?

I'm closing because I don't see a change I plan to make, but I'm happy to re-open if it needs more discussion.


(PDB-1482) allow ordering on non-extracted fields

Previously you couldn't order on a field that you weren't extracting.
This changes our paged sql function to do
select paged_results.* from (select blah from facts order by baz)
instead of select paged_results.* from (select blah from facts) order by baz,
and also ensures that we never order on column aliases -- always on the column
name or function application itself.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1216/

:+1: mod the unused namespace

@ajroetker fixed

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1225/

Tested and works great for me


Use proper notion error instance

Description

We were using the wrong Notion's error for the 504s in https://github.com/dust-tt/dust/pull/5134.
This PR uses the right instance type. Tested on prodbox.
Risk

Deploy Plan

PMRR.

Not needed anymore.


Fix document

https://github.com/samber/do in README.md is jumping to https://github.com/samber/go-type-to-string/blob/main/github.com/samber/do.
Fixed based on https://github.com/samber/do/blob/ca6ecee121da0e66a8bbca4b9392844ab7520cf7/README.md.

thanks!


Feature Request: Integrate with GCP Cloud Asset Inventory ListAssets to filter images currently being used

TL;DR
GCP Cloud Asset Inventory allows you to list all container image urls currently being used by Pods in GKE and potentially other services (Cloud Run and App Engine?) in a GCP organization or individual GCP project. Much like the ability to filter out images in gcr-cleaner by allowlisted tags, this integration would allow for the option of filtering out images currently being used in GKE, Cloud Run, etc.
Expected behavior
No response
Observed behavior
No response
Debug log output
No response
Additional information
Here’s a simple gcloud command to demonstrate listing all currently used container image urls for all GKE Pods in your organization. Take this data, put it in a simple hash set, and filter out the container images from gcr-cleaner that should be preserved.
gcloud beta asset list --organization=$ORGANIZATION_ID --asset-types='k8s.io/Pod' --content-type='resource' --format="value(resource.data.spec.containers.image)"

Useful Cloud Asset Inventory API links to get started
https://cloud.google.com/asset-inventory/docs/libraries#client-libraries-usage-go
https://pkg.go.dev/cloud.google.com/go/asset/apiv1#Client.ListAssets
https://cloud.google.com/asset-inventory/docs/supported-asset-types

Hi @somethingnew2-0
Thank you for opening an issue. This sounds like a really cool feature, but it's beyond the scope of what I'd like to support in gcr-cleaner. gcr-cleaner is intentionally scoped to only use the "Docker" APIs so that it works with other registries like DockerHub and Artifactory to support a broad set of customer use cases. Tightly coupling to CAIS would go against that vision.
I think it's a cool feature, but I would suggest that it should be a completely different tool. It's also worth noting that there's some careful edge cases around CAIS' consistency and delay, which could cause a container image to be marked as "unused" when it just hasn't appeared in the set yet.

In that case, I’ll probably fork and add this functionality myself eventually as this is useful for my purposes. Writing an entirely new tool for this single GCP CAIS option is probably significantly more effort. Ideally it’s opt-in and doesn’t require any additional GCP IAM permissions unless you enable the functionality explicitly.
I can kinda understand not wanting to include GCP API library dependencies in this tool and only using vanilla Docker APIs even it’s in the GoogleCloudPlatform GitHub org and named gcr-cleaner 😉
Good call out on CAIS consistency issues though, I’d imagine that can be mostly avoided with the keep count and grace period options as a best effort.

Added the functionality in our fork
https://github.com/GoogleCloudPlatform/gcr-cleaner/compare/main...discord:gcr-cleaner:main

Looks awesome!


Youtube demo no-longer loads on chrome

Expected behaviour
When you download the code and try the demo on Google chrome the youtube player should work as expected and load the video
Actual behaviour
The Video loads partially and the controls do not show up
Steps to reproduce
Fork Plyr, and create a new branch in your fork, based on the develop branch
To test locally, you can use the demo. First make sure you have installed the dependencies with npm install or yarn. Run gulp to build while you are working, and run a local server from the repository root directory. If you have Python installed, this command should work: python -m SimpleHTTPServer 8080. Then go to http://localhost:8080/demo/
Click on the youtube link, while using google chrome
Video does not load completely stops at  event: canplaythrough
event: ready never fires
Environment

Browser: Google Chrome
Version: Version 79.0.3945.79 (Official Build) (64-bit)
Operating System: Mac OSx Catalina
Version: 10.15.2

Console errors (if any)
Link to where the bug is happening
https://plyr.io/#youtube

Hey, found the problem, an ad blocker was blocking the ads SDK and this prevented the player from working.
Everything is fine

Maybe not the same thing, but I find the supplied codepen Youtube demo does not work in Chrome. Works in Firefox. In Chrome, the player loads and initial frame, but it won't play.
https://codepen.io/pen?template=GGqbbJ


”Băla”, ”Ercea” are listed in the drop-down menu

Description:
When user writes ”Băla”, ”Ercea” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Ercea"

Expected results
The location appears in the drop-down menu as "Sat Ercea, MUREȘ (Băla)".


querier show deflection in real time values when compared to prometheus

Thanos, Prometheus and Golang version used:
Thanos version: 0.24.0
Prometheus Version: 2.32.1

Object Storage Provider:
azure storage container
What happened:
When comparing 2 graphs from 2 different data sources (thanos-querier and prometheus), qurier graph is always declining for real time values where as promethues graph show correct values for the same query.
for example:
sum(increase(http_server_requests_seconds_count{app="sample",kubernetes_namespace="sample",uri="/api/v1/samples",status="200"}[1m]))

upon checking real time values for above query at 14.50.06
querier value: 81.51
prometheus value: 115.23
after some interval of time , both values will be identical. But for real time wrong values are plotted on grafana dashboard and because of that alerts are getting triggered for production.
Iniitially I thought tunning queueing config from prometheus might resolve this issue but still same behavior.
Could you please help me why this is happening.
What you expected to happen:
In idal use case there should not be a declining grafana from grafana dashboard that means value deflection must not be there.
How to reproduce it (as minimally and precisely as possible):
Full logs to relevant components:

Querier config:
    Args:                                                                                │
│       query                                                                                │
│       --log.level=info                                                                                │
│       --log.format=json                                                                                │
│       --grpc-address=<IP_ADDRESS>:10904                                                                                │
│       --http-address=<IP_ADDRESS>:10905                                                                                │
│       --web.route-prefix=thanos/querier                                                                                │
│       --web.external-prefix=thanos/querier                                                                                │
│       --query.replica-label=replica                                                                                │
│       --query.timeout=15m                                                                                │
│       --query.partial-response                                                                                │
│       --store.sd-dns-interval=1m                                                                                │
│       --store.sd-interval=1m
|
|       --store.unhealthy-timeout=5m
|
|       --store=dns+thanos-receive-0.thanos-receive-svc.monitor.svc.cluster.local:10901                                                                                │
│       --store=dns+thanos-receive-1.thanos-receive-svc.monitor.svc.cluster.local:10901                                                                                │
│       --store=dns+thanos-receive-2.thanos-receive-svc.monitor.svc.cluster.local:10901                                                                                │
│       --store=dns+thanos-receive-3.thanos-receive-svc.monitor.svc.cluster.local:10901                                                                                │
│       --store=dns+thanos-receive-4.thanos-receive-svc.monitor.svc.cluster.local:10901

thanos_receiver config:
    Args:                                                                                │
│       receive                                                                                │
│       --log.level=info                                                                                │
│       --log.format=json                                                                                │
│       --grpc-address=<IP_ADDRESS>:10901                                                                                │
│       --http-address=<IP_ADDRESS>:10902                                                                                │
│       --remote-write.address=<IP_ADDRESS>:10903                                                                                │
│       --grpc-grace-period=2m                                                                                │
│       --tsdb.path=./thanos/receive/objstorage                                                                                │
│       --tsdb.no-lockfile                                                                                │
│       --tsdb.wal-compression                                                                                │
│       --tsdb.allow-overlapping-blocks                                                                                │
│       --objstore.config=$(OBJSTORE_CONFIG)                                                                                │
│       --receive.local-endpoint=$(INSTANCE).thanos-receive-svc.monitor.svc.cluster.local:10901                                                                                │
│       --receive.hashrings-file=/var/thanos/receive/hashring/thanos-receive-hashring.json                                                                                │
│       --receive.hashrings-file-refresh-interval=5m                                                                                │
│       --tsdb.retention=2h                                                                                │
│       --receive.replication-factor=1                                                                                │
│       --label=receive="true"                                                                                │
│       --label=replica="$(INSTANCE)"                                                                                │
│       --label=receive_cluster="platform-prod-scus"                                                                                │
│       --label=receive_env="prod"                                                                                │
│       --receive.tenant-header=THANOS-TENANT                                                                                │
│       --receive.default-tenant-id=default-tenant

Update:
Today I tried to fetch metrics from query front end.  Since there is no UI for query front end so I port forwarded query front end pod. Eventually it opened querier UI only. then I used same query front end to visualize same query result which is not making any change at all. Same result I am getting whatever provided by querier. but I noticed one bahviour, after some time interval values are identical, please ref attachmen

t

astra db - prod querier-data-as-seriestocolumns-2022-02-23 23_12_15.csv
this is excel sheet where I see some similarity

Hey, can you please also post your remote_write config parameters and a screenshot of your source Prometheus' remote write metrics?

remote_write configs:
remote_write:

url: https://domain.url/api/v1/receive
remote_timeout: 30s
headers:
THANOS-TENANT: tenant_id
follow_redirects: true
queue_config:
capacity: 900000
max_shards: 500
min_shards: 4
max_samples_per_send: 300000
batch_send_deadline: 5s
min_backoff: 30ms
max_backoff: 100ms
metadata_config:
send: true
send_interval: 1m
max_samples_per_send: 500

Sorry, I was not clear, I was referring to the metrics with values/graphs. You can use this for example: https://github.com/prometheus/prometheus/blob/main/documentation/prometheus-mixin/dashboards.libsonnet#L108

@fktkrt  Ohk
Please find values below
prometheus_remote_storage_highest_timestamp_in_seconds:<PHONE_NUMBER>
prometheus_remote_storage_queue_highest_sent_timestamp_seconds:<PHONE_NUMBER>
rate(prometheus_remote_storage_queue_highest_sent_timestamp_seconds[5m]): 0.9655172413793105

rate(prometheus_remote_storage_samples_total[5m]): 36419.60344827586
rate(prometheus_remote_storage_samples_dropped_total[5m]): 0
prometheus_remote_storage_shards: 4
prometheus_remote_storage_shards_max: 500
prometheus_remote_storage_shards_min: 4
prometheus_remote_storage_shards_desired: 1.82
prometheus_remote_storage_shard_capacity: 900000
prometheus_remote_storage_samples_pending: 111980
prometheus_tsdb_wal_segment_current: 72411
prometheus_wal_watcher_current_segment: 72411
rate(prometheus_remote_storage_samples_dropped_total[5m]): 0
rate(prometheus_remote_storage_samples_failed_total[5m]): 7132.793103448276
rate(prometheus_remote_storage_samples_retried_total[5m]): 18795.337931034483
rate(prometheus_remote_storage_enqueue_retries_total[5m]): 0

You have many retries and failures (and pending samples), but it should not cause an issue like this. I'd imagine more different values if this would be the root cause. I have different characteristics when comparing a high traffic source to data from Receive/Query, may I ask for a screenshot of your source Prometheus' Overview dashboard to see your scale? Also, how many source Prometheis are we talking about?

I observed few things

When no function is applied on a query result is almost same compared to result from prometheus.
Sometimes number of results varying. for example. for http_server_requests_seconds_count this query prometheus give 18 results and querier gives 17 sometimes, sometime correct 18.
When function increase() is applied values are getting changed altogether.
If one entry is missing that means one of the receiver pod is not responding for the query.
I am suspecting something is wrong while replicating data on receiver. Does receiver require high IOPS ?

Coming back to your question
We are having almost 11 running prometheus. including all Prometheus instances total number of targets are ~ 1980 pods
this is one of the prometheus

@fktkrt
could suggest here please ?


What implicits are needed for (Gen.oneOf("a", "b") |@| Gen.oneOf("a", "b"))(+)?

I do have an error stating that |@| is not a member of Arbitrary.   Thanks for any direction or hint as to what to import.  Appreciate your help.

@wpoosanguansit I don't know what |@| is. It is not part of ScalaCheck.

Seems like this is not relevant.  It's from applicative in cats.  Thanks.


Add a finally() method

I would be so much nicer if I could write something like this:
      this.trigger("start")
      co(this.client[key].bind(this))
        .then((val) => {
          this.trigger("ok", val)
        })
        .catch((err) => {
          this.trigger("err")
        })
        .finally(()=> {
          this.trigger("end")
        })

I could do the following, but...

      this.trigger("start")
      co(this.client[key].bind(this))
        .then((val) => {
          this.trigger("ok", val)
          this.trigger("end")
        })
        .catch((err) => {
          this.trigger("err")
          this.trigger("end")
        })

you're going to have to bring this up with TC39. we're just returning promises, and we're not gonna implement our own or anything.

@jonathanong :+1: Makes sense.

i think @domenic said that he tried to get this into the promise spec, but getting .catch() in was hard enough already

I thought this could be useful (I still think so), but in my particular use case I (just) realized that triggering an end event does not make much sense as the error means whatever was happening didn't properly end , so it should be handled separately.

This should work as well:
      this.trigger("start")
      co(this.client[key].bind(this))
        .then((val) => {
          this.trigger("ok", val)
        }, (err) => {
          this.trigger("err")
        })
        .then(()=> {
          this.trigger("end")
        })

@targos Thanks!


Cannot find module xxx from yyyy

Issue :
I`m trying to use module-alias with ts-jest but it does not work at all. Tried all the configuration from the manual and also some links, but could not have it working.
Expected behavior :
Running tests and locating the given module mapped under moduleMapper.
I got it working both on tsc/ts-node-dev, but not with jest.
I've created a minimum setup to just reproduce the error.

Did you get my repo to work with this change? I just added you as collaborator there, if you can commit the working version I'd thank you a lot, cause it is giving me lots headaches to not being able to run tests.
Thanks!

I will have a look and see if I can make it work :)

@dtiziani I've got it working, unfortunately I couldn't manage with your config as there was too much going on, and your src files had several typescript definitions failing, so I've substitute them with a simpler example.
Something to note is that I've added tsconfig.build.json for the build so that tests are not compiled in the dist folder when you need to deploy your work. Hope you can use it as a starting point for making it work in your app.
Good luck!

hi @dtiziani , note that if you change jest config either in package.json or in jest.config.js, you need to clear jest cache by npm run jest --clearCache or yarn jest --clearCache.

Lesson learned: json is very error prone without validators. :)
thanks anyway!

thanks! you saved me a couple of hours


Base PCB support with through-hole and sunken screw head?

I am working on a box for a heavy power supply that must be mounted with machine screws from the bottom.  Maybe I'm missing something, but no matter what I do I cannot get OpenSCAD to generate a complete through hole.  It's creating a "pin" hole, but with a blind bottom.  Tried increasing pin length in the hopes it would project through, but that's not working.  Any suggestions or workarounds?  A countersunk area for the screw head would be icing on the cake, but I could always mount feet as a workaround.

You can just make a round cutout on the places you want the screw holen.
With ‘baseHookOutside’ and/or ‘baseHookInside’ you can re-enforce the screw holes.

Yes, but unfortunately I do not understand the syntax for the hook routines.  Although the YAPP template itself is clear I'm far from an expert with OpenSCAD coding.  I think I may have come up with a workaround involving bottom holes that are concentric with the support holes.
Thanks for getting back so quickly!

Are you using pcbSupports or connectors.  I think connectors might be more
of what you are needing.
On Tue, Oct 1, 2024, 1:10 PM Willem Aandewiel @.***>
wrote:

You can just make a round cutout on the places you want the screw holen.
With ‘baseHookOutside’ and/or ‘baseHookInside’ you can re-enforce the
screw holes.
—
Reply to this email directly, view it on GitHub
https://github.com/mrWheel/YAPP_Box/issues/110#issuecomment-2386655982,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIBTUKBX3SKUZJYIUJ4YIFLZZLQRRAVCNFSM6AAAAABPGDJWWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBWGY2TKOJYGI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

The connectors seem to always exist in top + bottom pairs.  I would need them strictly on the bottom and located relative to PCB origin.  My approach of "drilling holes" in larger generated PCB supports seems to have worked out well.  Will need to take a close look in the slicer, but I think this will be fine.  Thanks for coding such a marvelous template!


ListItem Switch Component

It would be nice to have a Switch component available for the ListItem component for menus. Creating a PR to add this.

@Joshuabaker2 You are THE definition of an ideal open-source contributor. Find something missing from a library, create an issue and also submit a PR that fixes that issue.
Gj! I'll review the PR in a bit. Let's get it merged it today if possible.

@Monte9 or @binoy14, mind taking a look at this one too? Luckily doesn't look like there's any merge conflicts with my other PRs which is nice.

not working

<ListItem
                      //badge={{ value: 3, badgeTextStyle: { color: 'red' }, badgeContainerStyle: { paddingLeft:0, marginTop: 10, color:'orange' } }}
                      roundAvatar
                      title={`${item.name.first} ${item.name.last}`}
                      titleStyle={{ paddingLeft:50 }}
                      switchButton={true}
                      subtitle={item.email}
                      subtitleStyle={{ paddingLeft:50 }}
                      leftIcon={
                        <TouchableOpacity onPress ={ () => this._showModal()  }>
                        <Avatar
                        large
                       // onPress ={ () => this._showModal()  }
                        rounded
                        source={{ uri: item.picture.thumbnail }}
                       containerStyle={{ flex:4, marginLeft:0 }}
                         />
                         </TouchableOpacity>
                             }

                      containerStyle={{borderBottomWidth: 0, padding:0, paddingLeft:0 }}
                    />

Thanks for reporting @yash2code. It would be most useful if you can create a Snack demo with the issue you create.
Here's a good place to start: https://snack.expo.io/rJu6gJfBZ

@yash2code I had the same problem and found out that you have to set hideChevron with switchButton to actually display the switch. Checkout this Snack https://snack.expo.io/SJPQNScUZ

@diegobfernandez Gj putting together the snack demo.  Would be good to add this into the readme file.

@alifa20 agreed. I have added it to the docs here and it will be updated in the next release v0.17.


Feat(queue): add ping function for redis

Closes #859

I believe we ping the queue on start up when creating a new Redis connection. I imagine any logic based on the success/failure of pinging the queue could be branched off of whether or not the New(...) method was successful?

I believe we ping the queue on start up when creating a new Redis connection. I imagine any logic based on the success/failure of pinging the queue could be branched off of whether or not the New(...) method was successful?

The issue with New(...) method is that it only gets pinged once during setup and never pinged again unless New(...) method is called again. We could also entirely with the New(...) method logic by creating new queue client everytime the worker checks in with server.


The problem of Loss equal to nan

We can obtain normal results when reproducing the "LSTM+ATT" setting, but when setting PACKET2FLOW in config.py to other values, nan occurs.
We guess it is a learning rate problem, but the paper does not give the learning rate for each PACKET2FLOW setting.
Can you provide specific hyperparameter settings when PACKET2FLOW and FLOW2TRACE take different values?

Well, In our experiments, the LEARNING_RATE ranged approximately from 2e-4 to 1e-3. However, as far as I remember, it seems that the loss never encountered a situation where it became 'nan', so I'm not sure what the specific reason might be.


[stdlib] Make test for Sequence.map actually test a sequence

AnySequence just forwards the call to map to its underlying storage which currently is an Array (and thus a collection). stride(from:through:by:) creates a proper Sequence, so we should this to test Sequence.map.

@swift-ci Please smoke test

stride might, at some point, become a collection. There are dedicated types in the std lib test suite for when you explicitly want to test a particular protocol – have a look for uses of MinimalSequence.

Updated to use MinimalSequence.
@swift-ci Please smoke test

@ahoppen StdlibCollectionUnittest is only built for validation tests, so this will fail for anyone who runs the plain test suite locally.


Write multi-measure records to Timestream

Is your idea related to a problem? Please describe.
Can't write multi-measure records?
Describe the solution you'd like
Multi-measure records were added in boto3 1.20.13 (see https://github.com/boto/boto3/blob/develop/CHANGELOG.rst#12013).
Few suggestions on how to solve this:

replace measure_col with measure_cols (breaks backwards compatibility, so probably no go)
letting measure_col optionally take list (a bit weird)
adding a measure_cols parameter to timestream.write() which overrides measure_col
adding a new method timestream.write_multi()

Thanks for flagging this @mateogianolio, it seems that the API call lists both MeasureValue and MeasureValues so I would be in favour of accepting both

I just tried it out in a Jupyter notebook; and it failed on the test_multimeasure_scenario function.


fix: addComputed with array.pop() use case

This PR fixes a weird behavior reported in #124.
Because addComputed runs in sync, it can run get function with incomplete snapshot.
We give up running it sync, and delay one tick. This is not ideal, but until we found a better solution, this should be a safer solution.
Please note again that addComputed and proxyWithComputed are often not recommended with useSnapshot in react. Consider deriving state in render function as a primary mean.

@opticode Would you make sure if this PR fixes your use case? You can locally install the build created by codesandbox ci.

@dai-shi Checked and can confirm it works as expected now! Much appreciated 👏

Merging this. I will wait for some other bug reports for a while and then make a new patch release.


Not able to connect through secure tunnel

Please help me out I am getting the below issue.
2021-06-01T22:25:17.750Z [DEBUG] {Config.cpp}: Did not find a runtime configuration file, assuming Fleet Provisioning has not run for this device
2021-06-01T22:25:17.750Z [INFO]  {Main.cpp}: Now running AWS IoT Device Client version v1.2.0
2021-06-01T22:25:17.751Z [INFO]  {SharedCrtResourceManager.cpp}: SDK logging is disabled. Enable it with --enable-sdk-logging on the command line or logging::enable-sdk-logging in your configuration file
2021-06-01T22:25:17.751Z [DEBUG] {Retry.cpp}: Retryable function will retry until success
2021-06-01T22:25:17.755Z [INFO]  {SharedCrtResourceManager.cpp}: Establishing MQTT connection with client id HarishMachine...
2021-06-01T22:25:19.960Z [INFO]  {SharedCrtResourceManager.cpp}: MQTT connection established with return code: 0
2021-06-01T22:25:19.960Z [INFO]  {SharedCrtResourceManager.cpp}: Shared MQTT connection is ready!
2021-06-01T22:25:19.960Z [INFO]  {Main.cpp}: Jobs is disabled
2021-06-01T22:25:19.961Z [INFO]  {Main.cpp}: Secure Tunneling is enabled
2021-06-01T22:25:19.961Z [INFO]  {Main.cpp}: Device Defender is disabled
2021-06-01T22:25:19.961Z [INFO]  {Main.cpp}: Pub Sub is disabled
2021-06-01T22:25:19.961Z [INFO]  {SecureTunneling.cpp}: Running Secure Tunneling!
2021-06-01T22:25:19.961Z [INFO]  {Main.cpp}: Client base has been notified that Secure Tunneling has started
2021-06-01T22:25:20.290Z [DEBUG] {SecureTunneling.cpp}: Received MQTT Tunnel Notification
2021-06-01T22:25:20.290Z [ERROR] {SecureTunneling.cpp}: OnSubscribeToTunnelsNotifyResponse received error. ioErr=5138
2021-06-01T22:25:20.290Z [DEBUG] {SecureTunneling.cpp}: Subscribed to tunnel notification topic
2021-06-01T22:25:20.290Z [ERROR] {SecureTunneling.cpp}: Couldn't subscribe to tunnel notification topic. ioErr=5138

Hello @harishm18 , sorry to hear that you are facing difficulty connecting through Secure Tunneling using Device Client. In order to help you to resolve this issue, can you share few more details about your Device Client setting? Can you paste the copy of your Config file used to start Device Client, copy of Policy attached to your certificate and give us more details about your device starting with the platform on which you are running Device Client on.

Harsh Gandhi

Hello @harishm18 ,
Since we haven't heard back from you in a while, I assume that you have resolved your issue. I am closing this issue now. If you are still facing any problem, please feel free to reopen this issue or create a new one and I'll be happy to assist you. Thank you.
-Harsh Gandhi


⚠ Bofrost.es has degraded performance

In d4137d6, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1606 ms

Resolved: Bofrost.es performance has improved in f07583f after 7 minutes.


Request - Windows 10 App via Desktop Bridge with support for native Notifications and "My People"-Feature

It would be amazing to have Franz as a Windows 10 App. This would provide support for native Windows 10 features like native notifications in Action Center, and support for the new "My People" feature that was just released with RS3.
In the Windows Store there are many Apps trying to do what Franz does, but all fail miserably in terms of UI, stability, and being clattered with ads.
There is a huge demand for a well coded, FOSS app like Franz, especially since there is no official Whatsapp-App on the Store.
With the "Desktop Bridge" it would be possible to convert the current Win32 App to Store App, like many devs have done by now: Evernote, IrfanView, Inkscape, GPMDP, Paint.NET, just to name a few.
This would not only provide the benefits i outlined above, but also provide Win 10S users with a useable App for Whatsapp, as they only can use Store Apps, and no Win32 Apps.
Plus, Updates are secure and easy also for non-technical persons; Donations for dev. support would be possible in App, and a clean installation of windows would be faster when one can just download it from the store in 1 click instead of manually.
Anyway, kudos for the V5, nice UI, responsive and fluid, and a big update IMHO. OFC would look even greater when the dark theme request comes to fruition. ;)
As i am no dev, i cant provide more detailed info on the technical backgrounds of the Desktop Bridge/Win32 to Store converter, but AFAIK there must be good documentations available now, and there are quite a few devs who had their Win32 Apps ported without problems.
Kind regards,
Steven

Do you know any electron app that has been converted to a Windows 10 app?

I have never tried to convert any electron app, but the process seems to be possible and quite straightforward:
https://blogs.msdn.microsoft.com/appconsult/2017/03/14/convert-your-electron-app-using-the-desktop-bridge/
https://github.com/felixrieseberg/electron-windows-store
I really would love to see this feature as well. I only would be willing to pay for a well done native UWP app like this.

Converting the app to an UWP app does not change anything about how the app is written and of all, it doesn't make it "more native". It might give users more trust but managing store builds is an overhead that can't be managed right now.
However, AppStore as well as Windows Store builds are planned in a more distant future.


Fix for #1469

I'm not sure whether this is the best way to fix the issue. Have a look

Thanks for taking a stab at this! Looks good to me (modulo trivial test fix, which I've done).


Landing page/new layout

Description
Changed the layout of Landing page component
Type of change
Please delete options that are not relevant.

[X] New feature (non-breaking change which adds functionality)

Change Status

[X] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[X] Viewed new layout with npm start

Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[X] There are no merge conflicts

 Marketing Page


Appstudio update test-component-pac-gsip

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-gsip-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
30 seconds
build-container

✅ Succeeded
20 seconds
deprecated-base-image-check

✅ Succeeded
18 seconds
inspect-image

✅ Succeeded
11 seconds
clair-scan

✅ Succeeded
37 seconds
clamav-scan

✅ Succeeded
10 seconds
sbom-json-check

✅ Succeeded
19 seconds
optional-label-check

✅ Succeeded
17 seconds
label-check

✅ Succeeded
8 seconds
show-sbom

✅ Succeeded
8 seconds
show-summary


Create ping.10s.sh

This is a plugin of Bitbar.
It shows current ping to some servers at the top Menubar.
This helps me to know my current connection speed.

Love that - great usage. Nice work.

Please add your name and a link to the Contributors list on https://github.com/matryer/bitbar/blob/master/Plugins/README.md.


fix(examples/multiple-accounts): remove dependencies on rest of monorepo 🏎

The dependencies in this example used to point to the rest of the repository:
  "dependencies": {
    "@latticexyz/common": "link:../../../../packages/common",
    .
    .
    .
  }

However, this causes a problem when users don't need to build the whole repository (see https://discord.com/channels/865335009915961364/1239515132917186600).
Using latest instead solves this problem.

can you fill in the PR description with a bit of an explanation of why we're making this change?

can you fill in the PR description with a bit of an explanation of why we're making this change?

Sorry I haven't done it last night. Updated.


Allows containment to be restricted to a single axis

My use case a gantt chart where I'd like the ability to drag outside the container on the x-axis but to be contained on the y-axis.
Maybe an edge case but this PR allows containment restriction to be applied to a single axis.
Example usage:
var draggie = new Draggabilly(document.querySelector('.draggable-element'), {
   containment: document.querySelector('.wrapper-element'),
   containmentAxis: 'y'
});

Thank you for this contribution! This is a nice little addition. Like you said, it may be an edge case. I'll keep the PR open for a while in case others are interested
+1 or add a :+1: reaction to this issue if you'd like to see this PR merged.

I've decided to pass on this request. Thanks again for your contribution!


Upgrade bazel toolchain

Try upgrading bazel toolchain and perhaps also the current bazel version.

(doesn't upgrade the bazel version we use - it's still 1.0.0 - only uses the latest toolchain).

Just curious, what is the difference?

(doesn't upgrade the bazel version we use - it's still 1.0.0 - only uses the latest toolchain).

Just curious, what is the difference?

If we upgraded bazel version, users might need to upgrade the bazel version too to be able to build.
Updating the toolchain is transparent to the users.
The newer toolchain allows us to use some new definitions - e.g. rbe pool labels https://github.com/grpc/grpc/pull/23087/files#diff-773cbb9cf4d193d10a1d82bed23b4d72L40

Also just curious - might it be possible that an older version of the bazel binary (especially an older major version) won't work with the newer toolchain, in theory?

Also just curious - might it be possible that an older version of the bazel binary (especially an older major version) won't work with the newer toolchain, in theory?

Yes, I'm checking that with the RBE team. So far I got bad news and the new toolchain officially only supports bazel 3.x+. Not sure what that means in terms of bazel versions we can support. (curently we support bazel 1.0.0 and newer, even though we don't test for that explicitly).

The asan/msan/ubsan errors
https://source.cloud.google.com/results/invocations/52280610-a81c-48cc-bbe0-0a54db5d5cc3/targets/%2F%2Ftest%2Fcore%2Fbad_connection:close_fd_test/log
ERROR: /tmpfs/tmp/bazel/external/io_opencensus_cpp/opencensus/trace/BUILD:25:1: Couldn't build file external/io_opencensus_cpp/opencensus/trace/_objs/trace/local_span_store.pic.o: undeclared inclusion(s) in rule '@io_opencensus_cpp//opencensus/trace:trace':
this rule is missing dependency declarations for the following files included by 'external/io_opencensus_cpp/opencensus/trace/internal/local_span_store.cc':
  '/usr/local/lib/clang/11.0.0/share/asan_blacklist.txt'

seem to be the same as
https://github.com/google/oss-fuzz/issues/3093

CC @gnossen  it seems that both bazel toolchain 2.2.0 and 3.4.2 has its issues  (see comment thread for the 2.2.0 problem and the latest test results for 3.4.2 issues)
We might need to upgrade everything to the latest bazel and toolchain (after fixing our builds), but we will also need bazel distribtests to ensure (at least some) compatibility with bazel 1.x and 2.x - suddenly the bazel distribtests seem more of a priority.

Superseded by https://github.com/grpc/grpc/pull/25001


Windows 7 fetching entire file on selection

Whenever I right-clicked a file from a webdav share on windows 7, Explorer would freeze for minutes.
I set up charles proxy to see what's happening - and to my surprise - it is fetching the entire file when you click on it !
Is this a known issue ? what causes this?

I can't say for certain if it would have been possible for Windows in this case to do a partial fetch using range requests. I imagine that right-clicking triggers something in the operating system that causes it to want access to the contents of the file. The only option the client then has (given that it doesn't do range, request, which I'll assume ... ) is to download the entire file.
I don't know if there's a workaround for this. You might want to try a more optimized client instead.


Rev0.95 - Folders organization changes

This is the first part of the folders organization changes to create individual files for each component specifications and create multiple folders part-spec.

As discussed, to avoid merge conflicts, I'll close this PR and complete the changes before we run the scripts to fix some of the issues we've identified.


refactor: Use new RDF handling in more methods of project repo

Pull Request Checklist
Task Description/Number

Issue Number: DEV-
PR Type

[ ] build/chore: maintenance tasks (no production code change)
[ ] docs: documentation changes (no production code change)
[ ] feat: represents new features
[ ] fix: represents bug fixes
[ ] perf: performance improvements
[ ] refactor: represents production code refactoring
[ ] test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

[ ] Tests for the changes have been added
[ ] Docs have been added / updated

Does this PR introduce a breaking change?

[ ] Yes

Does this PR change client-test-data?

[ ] Yes

tests fail, will need some more work - sorry for premature review request


Fix diff calculations when straddling DST

When a diff is done between two dates, when one is observing DST and the other is not, we need to properly account for the timezone offset differences.
Also updates duration just a bit to do lower level precision comparisons in a more predictible way.

JIRA Test: https://jira.mitre.org/browse/BONNIE-866

Regression test passed.


[release 1.1] Cherry pick scripts from the master branch

Coverage remained the same at 76.528% when pulling 1a698c0b6ec6d0596dc13c51ecb6de295c9f8cfb on rastislavszabo:release-1.1 into e0eb872a1862a3b716e7ea11b72edb82418cb1be on contiv:release-1.1.


Favorites

@jonnywray - Integrate Plex favorites into Roku UI if possible

Plex favorites have been removed from the client, in advance of doing something "smarter" with them :-)

Ok, then let's close this for now and open a new issue once the server has the new feature implemented.