x/tools/go/packages: gotypesalias=1 does not seem to get used correctly for deps on Go 1.23

$ go version
go version go1.23.3 linux/amd64
$ go env
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/mvdan/.cache/go-build'
GOENV='/home/mvdan/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/mvdan/go/pkg/mod'
GONOPROXY='github.com/cue-unity'
GONOSUMDB='github.com/cue-unity'
GOOS='linux'
GOPATH='/home/mvdan/go'
GOPRIVATE='github.com/cue-unity'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/lib/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/lib/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.23.3'
GODEBUG=''
GOTELEMETRY='on'
GOTELEMETRYDIR='/home/mvdan/.config/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build977617588=/tmp/go-build -gno-record-gcc-switches'

Take the testscript below:
go run .

go run . -godebug

go run . -godebug -needsyntax

go run . -needsyntax
-- go.mod --
module test

go 1.23

require golang.org/x/tools v0.27.0

require (
	golang.org/x/mod v0.22.0 // indirect
	golang.org/x/sync v0.9.0 // indirect
)
-- go.sum --
golang.org/x/mod v0.22.0 h1:D4nJWe9zXqHOmWqj4VMOJhvzj7bEZg4wEYa759z1pH4=
golang.org/x/mod v0.22.0/go.mod h1:6SkKJ3Xj0I0BrPOZoBy3bdMptDDU9oJrpohJ3eWZ1fY=
golang.org/x/sync v0.9.0 h1:fEo0HyrW1GIgZdpbhCRO0PkJajUS5H9IFUztCgEo2jQ=
golang.org/x/sync v0.9.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
golang.org/x/tools v0.27.0 h1:qEKojBykQkQ4EynWy4S8Weg69NumxKdn40Fce3uc/8o=
golang.org/x/tools v0.27.0/go.mod h1:sUi0ZgbwW9ZPAq26Ekut+weQPR5eIM6GQLQ1Yjm1H0Q=
-- main.go --
package main

import (
	"flag"
	"fmt"
	"os"

	"golang.org/x/tools/go/packages"
)

var (
	godebug    = flag.Bool("godebug", false, "")
	needsyntax = flag.Bool("needsyntax", false, "")
)

func main() {
	flag.Parse()
	if *godebug {
		os.Setenv("GODEBUG", "gotypesalias=1")
	}
	mode := packages.NeedTypes
	if *needsyntax {
		mode |= packages.NeedSyntax
	}
	cfg := &packages.Config{Mode: mode}
	pkgs, err := packages.Load(cfg, "./pkg1")
	if err != nil {
		panic(err)
	}
	if packages.PrintErrors(pkgs) > 0 {
		os.Exit(1)
	}

	pkg := pkgs[0]
	scope := pkg.Types.Scope()
	fmt.Println(scope.Lookup("Var1"))
	fmt.Println(scope.Lookup("Var2"))
}
-- pkg1/pkg1.go --
package pkg1

import "test/pkg2"

type Alias1 = int32

var Var1 Alias1

var Var2 pkg2.Alias2

-- pkg2/pkg2.go --
package pkg2

type Alias2 = int64

With https://pkg.go.dev/github.com/rogpeppe/go-internal/cmd/testscript, I see:
> go run .
[stdout]
var test/pkg1.Var1 test/pkg1.Alias1
var test/pkg1.Var2 int64

> go run . -godebug
[stdout]
var test/pkg1.Var1 test/pkg1.Alias1
var test/pkg1.Var2 int64

> go run . -godebug -needsyntax
[stdout]
var test/pkg1.Var1 test/pkg1.Alias1
var test/pkg1.Var2 test/pkg2.Alias2

> go run . -needsyntax
[stdout]
var test/pkg1.Var1 test/pkg1.Alias1
var test/pkg1.Var2 test/pkg2.Alias2

The first two results seem wrong; alias tracking is lost for the transitive dependency, given that we see the alias target int64 rather than the alias declared in the transitive dependency, pkg2.Alias2. This happens whether or not I set the GODEBUG flag, which should already be on by default in Go 1.23.
The issue only goes away once I set NeedSyntax, which presumably forces the current process to parse and typecheck all packages directly, rather than relying on the Go toolchain to typecheck transitive dependencies and store the results in GOCACHE, for the current process to load from a warm cache.
This bug seems to go away as of go version devel go1.24-493edb2973 2024-11-16 15:10:05 +0000 linux/amd64:
> go run .
[stdout]
var test/pkg1.Var1 test/pkg1.Alias1
var test/pkg1.Var2 test/pkg2.Alias2

> go run . -godebug
[stdout]
var test/pkg1.Var1 test/pkg1.Alias1
var test/pkg1.Var2 test/pkg2.Alias2

> go run . -godebug -needsyntax
[stdout]
var test/pkg1.Var1 test/pkg1.Alias1
var test/pkg1.Var2 test/pkg2.Alias2

> go run . -needsyntax
[stdout]
var test/pkg1.Var1 test/pkg1.Alias1
var test/pkg1.Var2 test/pkg2.Alias2

Related Issues

cmd/cgo: generated code uses aliases even in modules using Go older than 1.9 #67738
cmd/compile: crash while exporting aliases (with GODEBUG=gotypesalias=1) #66550 (closed)
x/tools/gopls: type alias rename changes aliased type #61625 (closed)
cmd/go: `go env` does not show GODEBUG #65777 (closed)
types2, go/types: "cannot convert to type" regression with alias to pointer types #67540 (closed)
cmd/go2go: A type alias that references a parameterized type in another package causes a panic #39792 (closed)
cmd/go: in 1.23rc2, TestScript fails on Windows when GOEXPERIMENT is set: "go was invoked but no counters were incremented" #68579
cmd/compile: importing generic alias types is not supported in 1.23 #68526 (closed)

Related Code Changes

go/types, types2: implement Alias proposal (export API)
go/types: remove GOEXPERIMENT=aliastypeparams

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

 I suppose it could be because alias tracking is always on at this point, or perhaps due to other changes in how export data is generated or loaded.

The issue locates inside the cmd/compile. packages.Load triggers go list with -compile and -export, and it relies on cmd/compile to generate the exported data.
Tool compile will be triggered twice in this scenario for pkg2 and pkg1 and the export data for pkg2 is generated first. However, when compile tries to read exportdata pkg2 for pkg1, the enableAlias is set false. As a result, compile won't respect the alias inside  pkg2 and it generates pkg1's exportdata without alias.
https://github.com/golang/go/blob/777f43ab27bde4c662cd0a663f807f74f3fbab0f/src/cmd/compile/internal/importer/ureader.go#L34-L36
Then the result is read by tools/go/packages and assign type int64 to Ver2 instead of Alias2, which is what we expected.
I'm still new to the cmd/compile part and don't know a lot of things, so it's possible I've missed something important. I would appreciate any corrections or guidance. Thanks a lot!
Regarding on the CL629997, I don't know the following things but I will try to check them tomorrow.

whether it breaks the other cases we wanted to prevent before
where and how to put a test case.

Great find. I suspected it was something like this, but narrowing it down is super helpful. I will follow up on this.

That would also explain why 1.24 (master) did not have this bug, as I recall some rather large import/export changes in the compiler.

@mvdan This issue can indeed be marked as closed since it's resolved in Go 1.24, but the Go1.24 milestone is right. There are child backport issues that need to refer to this one. We need a parent issue for tracking, even if the problem happened to be fixed before the issue was filed.
See https://go.dev/wiki/MinorReleases, which includes "As soon as an interested party thinks an issue should be considered for backport, they open one or two “child” issues titled like package: title [1.17 backport]. The issue should include a link to the original issue and a short rationale about why the backport might be needed." and more details.

For a 1.22 backport, we would need to backport most of https://go.dev/cl/579935, https://go.dev/cl/585399, and possibly other subsequent CLs that build on top of these and fix bugs. These would not be "100% clean" backports either as public APIs are involved and differ between releases.
Given the relatively low volume of user complaint, the complexity/risk of the backport, and hopefully soon availability of a 1.23 fix, I am not sure a 1.22 backport makes sense at this time.

All I need is a backport to 1.23, personally.


[API draft] Per key quota

This is the draft for the feature fixes https://github.com/line/decaton/issues/167
I would like to discuss the API first, then proceed to actual implementation after that
example/PerKeyQuotaMain.java describes the complete usage of this feature

roughly checked API design and it looks good.

Thanks. Then I'll close now for recording, and proceed as another PR


add getOperation syscall and fix tests

Brief description
Content of this PR:

adds getOperation system call (tests are written, but MockVM package needs to be updated in order to handle the new system call properly)
makes the defaultValue optional in the Storage helper
fixes the tests for the Storage helper (and add coverage tests)

Checklist

[x] I have built this pull request locally
[x] I have ran the unit tests locally
[x] I have manually tested this pull request
[x] I have reviewed my pull request
[x] I have added any relevant tests

Thanks for your review @sgerbino!
I made the needed changes and also updated the MockVM package and enabled the unit tests for the new getOperation syscall.


Using custom string.

I've tried using custom containers with nlohmann::json. ObjectType and ArrayType can be swapped, but changing StringType breaks creating json from most types.
Here's a minimal, non-functional string implementation, that builds as long as you don't try to create a json from other types than string literals: https://godbolt.org/z/GTvn8T
If I read correctly nlohmann::detail::detector fails to find a matching to_json function, but I don't understand how changing StringType has anything to do with it. Should StringType be replaceable? Does it then need a custom serializer or what's the trick?

I can reproduce your findings, but not yet understood the error.

I could create a minimal wrapper around std::string with which I could compile your example:
class my_string {
  public:
    using value_type = std::string::value_type;
    using size_type = std::string::size_type;

    my_string() {}
    my_string(const value_type* s) : _s(s) {}
    my_string(std::initializer_list<value_type> ilist) : _s(ilist) {}
    ~my_string() {}

    const value_type* data() const noexcept {
        return _s.data();
    }

    size_type size() const noexcept {
        return _s.size();
    }

    void clear() noexcept {
        _s.clear();
    }

    void push_back(size_type ch) {
        _s.push_back(ch);
    }

    friend bool operator<(const my_string& lhs, const my_string& rhs)
    {
        return lhs._s < rhs._s;
    }

  private:
    std::string _s;
};

I am not sure whether it is complete, but it helped me find a problem in your code. After removing the constructor
my_string(char){}

your code compiles.

Sorry for not updating the issue sooner. Yes, thanks, removing that constructor does help. Additional gripe was with nlohmann::detail::int_to_string which was solved by defining an overload of the function with the custom string_type.
Looks like int_to_string was reported also in https://github.com/nlohmann/json/issues/2059 and commit https://github.com/nlohmann/json/commit/aeef50709e6a49f5807cdf787473ca8adecbe23c linked as a fix, but not sure how that is supposed to work: https://godbolt.org/z/aEWbM6joo

@armatti you're right that the referenced commit does not do what it was intended to do.  ADL is for the "arguments" of the function, not the return type.  However, looks like you can use ADL to replace this function instead, which is what it sounds like you did.
void int_to_string(my_string& str, std::size_t value)
{
    str = {};
}

FYI @dota17

As problems could be solved without modifying nlohmann::json, I'm happy to close this issue.


error "Resulting quadratic form does not have appropriate dimensions" when multiprocessing is used

One of the cvxpy examples gets an error about wrong dimensions for the resulting quadratic form, but only if it is run with multiprocessing.
The attached .py file has been renamed to .py.txt to allow attaching it.
cvxpy-bug-lasso-multiprocessing.py.txt
This is a modified copy of examples/admm_lasso.py from the cvxpy repo, repaired to run in Python 3 and with a conditional added to show the bug.
If the file is changed so that show_bug=False, the output is
ADMM best 30.196966517374065
ECOS best 30.027898655129338

and there is no error.
If the file is run as submitted, so that show_bug=True, then it dies with a runtime error:
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "/home/ubuntu/anaconda3/envs/edcvxenv1a/lib/python3.6/multiprocessing/pool.py", line 119, i worker
    result = (True, func(*args, **kwds))
  File "/home/ubuntu/anaconda3/envs/edcvxenv1a/lib/python3.6/multiprocessing/pool.py", line 44, inmapstar
    return list(map(*args))
  File "cvxpy-bug-lasso-multiprocessing.py", line 22, in prox
    Problem(Minimize(f)).solve()
  File "/home/ubuntu/anaconda3/envs/edcvxenv1a/lib/python3.6/site-packages/cvxpy/problems/problem.y", line 289, in solve
    return solve_func(self, *args, **kwargs)
  File "/home/ubuntu/anaconda3/envs/edcvxenv1a/lib/python3.6/site-packages/cvxpy/problems/problem.y", line 569, in _solve
    self._intermediate_problem)
  File "/home/ubuntu/anaconda3/envs/edcvxenv1a/lib/python3.6/site-packages/cvxpy/reductions/chain.y", line 65, in apply
    problem, inv = r.apply(problem)
  File "/home/ubuntu/anaconda3/envs/edcvxenv1a/lib/python3.6/site-packages/cvxpy/reductions/matrixstuffing.py", line 84, in apply
    new_obj, new_var, r = self.stuffed_objective(problem, extractor)
  File "/home/ubuntu/anaconda3/envs/edcvxenv1a/lib/python3.6/site-packages/cvxpy/reductions/qp2qua_form/qp_matrix_stuffing.py", line 49, in stuffed_objective
    P, q, r = extractor.quad_form(expr)
  File "/home/ubuntu/anaconda3/envs/edcvxenv1a/lib/python3.6/site-packages/cvxpy/utilities/coeff_etractor.py", line 168, in quad_form
    raise RuntimeError("Resulting quadratic form does not have "
RuntimeError: Resulting quadratic form does not have appropriate dimensions
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "cvxpy-bug-lasso-multiprocessing.py", line 41, in <module>
    xi = pool.map(prox, zip(funcs, prox_args))
  File "/home/ubuntu/anaconda3/envs/edcvxenv1a/lib/python3.6/multiprocessing/pool.py", line 288, i map
    return self._map_async(func, iterable, mapstar, chunksize).get()
  File "/home/ubuntu/anaconda3/envs/edcvxenv1a/lib/python3.6/multiprocessing/pool.py", line 670, i get
    raise self._value
RuntimeError: Resulting quadratic form does not have appropriate dimensions

I am running Python 3.6.7 :: Anaconda, Inc. and cvxpy==1.0.25 on  Ubuntu 19.04.
EDIT (akshayka): I've copied your linked-to source below
# examples/admm_lasso.py example from github repo, slightly repaired
# and run in Python 3

# license notice removed

from cvxpy import *
import numpy as np
from multiprocessing import Pool

show_bug = True

# Problem data.
m = 100
n = 75
np.random.seed(1)
A = np.random.randn(m, n)
b = np.random.randn(m)

def prox(args):
    f, v = args
    f += (rho/2)*sum_squares(x - v)
    Problem(Minimize(f)).solve()
    return x.value

# Setup problem.
gamma = Parameter(nonneg=True)
gamma.value = 1
rho = 1.0
x = Variable(n)
funcs = [sum_squares(A*x - b),
         gamma*norm(x, 1)]
ui = [np.zeros(n) for func in funcs]
xbar = np.zeros(n)

NUM_PROCS = 2
pool = Pool(NUM_PROCS)
# ADMM loop.
for i in range(50):
    prox_args = [xbar - u for u in ui]
    if show_bug:
        xi = pool.map(prox, zip(funcs, prox_args))
    else:
        xi = [prox(tup) for tup in zip(funcs, prox_args)]
    xbar = sum(xi)/len(xi)
    ui = [u + x_ - xbar for x_, u in zip(xi, ui)]

# Compare ADMM with standard solver.
prob = Problem(Minimize(sum(funcs)))
result = prob.solve()
print("ADMM best", (sum_squares(np.dot(A, xbar) - b) + gamma*norm(xbar, 1)).value)
print("ECOS best", result)

Thanks for reporting. One way to work around this issue would be to change
    Problem(Minimize(f)).solve()

to
    Problem(Minimize(f)).solve(ECOS)

The default code path (ie, the QP code path) appears to interact poorly with multiprocessing, as you've found.


dumped player map views use same orientation as the map itself

ground truth:

player's view without the fix:

player's view with the fix:

I've also invited you to the new organisation for next year's game ;-)

I've also invited you to the new organisation for next year's game ;-)

Thanks! Looks like I don't have the right to commit though. Or maybe you have another idea for more efficient communication? I've left some messages over discord.


question about target protocol

Hello, thanks for your awesome work.
As I know, IPP is a printer protocol, which means that we need a emulator environment to run the printer firmware and the firmware should be closed source. So, aflnet should be not easily to test IPP protocol.
May I ask you that what target(software) do you choose for IPP protocol fuzz? Is there any printer emulator software which can run directly on Linux?

We have not tested IPP protocol yet so I cannot suggest any emulators. However, you might be able to use AFLNet to test the real printer directly following the instruction in this un-merged PR for remote-only-mode: https://github.com/aflnet/aflnet/pull/67

thanks for your answer, I got it.


XML Config file schemas are not available at time of load.

Some projects, including ones based on Spring Integration Framework and Spring Batch require XML Files for configuration.  Custom encryption beans are sometimes also required which may need to be defined in XML.  While various XSD Namespaces can be used during loading, the jasypt encryption xsds can not be used by Spring Boot with the Starter plugin.  A Demo project illustrating this has been setup at https://github.com/gorky/jasyptDemo.
This can be run either from command line using ./gradlew run, or in an IDE.

let me take a quick look at this

For the namespace to work you just gotta add:
compile 'org.jasypt:jasypt-spring3:1.9.2'
to your dependencies. But in any case, you shouldn't mix jasypt-spring-boot and jasypt. Jasypt-spring-boot alone will give you encryptable properties across the entire Spring Environment, regardless of whether or not you have XML configuration, it'll just work. So you don't need to be setting custom encryptors or jasypt config in the XML, just use the properties directly.

In DemoMain you can remove this lines:
@ImportResource({"/jasypt-context.xml"})
@PropertySource("classpath:/application.properties")

And add @SpringBootApplication.
In DemoBeanyou gotta change:
@Value("demo.jasypt.value") for this @Value("${demo.jasypt.value}") and after that your app should work. Assuming that you setup the String Encryptor properly, which I couldn't figure out what you were using, but when I replaced demo.jasypt.value in your properties for an encrypted value I generated it all worked.


Add-PnPListItem failing with "property or field 'Id' has not been initialized"

Discussed in https://github.com/pnp/powershell/discussions/2140

Originally posted by sravanthiGITHUB July 13, 2022
We have written a PnP-PowerShell script that creates and updates list items. Intermittently, the script fails with an error at the Add-PnPListItem cmdlet: "The property or field 'Id' has not been initialized. It has not been requested or the request has not been executed. It may need to be explicitly requested."

@sravanthiGITHUB - Please open an issue by filling the template so we can the maximum information to try help you. Thanks.


Create fixed variant of Side-nav

This task is to implemented the fixed variant of Side-nav seen in:

Latest sketch file: https://ibm.box.com/s/4e4zrz6mlo0jpr8lw4vimwlxn4vc59cy (internal)

Working on this.


Abort compilation if the generator is not ninja

What problem does this PR solve?
Abort compilation if the generator is not ninja
Fix #464
Issue link:
What is changed and how it works?
Code changes

[ ] Has Code change
[ ] Has CI related scripts change

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (knn performance test)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Note for reviewer

@mergify queue


Group won't work

Hi. Thank you for good plugin, I like it.
As I understand grouping prevents the same notifications, but if I enable group notifications it won't work.
Vue.http.interceptors.push(function(request, next) {

   next(function(response) {

       switch (response.status) {
           case 401:
               console.error('You are unauthorized');
               this.$notify({
                   group: 'unauthorized', // notifications will work if commented
                   title: 'You are not authorized',
                   type: 'error',
                   text: 'Log out ...',
                   duration: 99999999
               });
               break;
           case 404:
               this.$notify({
                   title: 'Page not found',
                   type: 'error'
               });
               break;
           default:
               this.$notify({
                   title: 'Unknown error'
               });
       }

   });
});

Hey, it does not work exactly like that, the readme I've wrote is a bit confusing 😢 .
The way groups work is:
If you have 2 notification holders, like that:
<notifications position="top right" name="system" />
<notifications position="top left" name="auth" />

You can use group parameter to specify which notification holder you want to use.
//Will print it in the notifications holder "auth" which will be in top left corner
this.$notify({ group: 'auth', text: 'Fooooo!' })

The reason I've done that is that in my project there were 2 different types of notifications:

Auth-based, eg. "you are not authorized", "license is out of data", etc
System-based, eg. "File was deleted", etc

And they required different styling.
Hope that helped, I am currently doing update to make it a bit less confusing, and I did not expect someone to start using it so soon 👍 🔥 😄
Thanks :)

Thank you for explanation. Now I see.
But what do you think about preventing the same notifications?
When my page loads it makes 3-4 requests and each returns 401 error. So I need prevent the same notifications manually(

I am afraid I am not planning to do it. What you've described sounds pretty custom to your app. There are number of simple ways to implement this type of functionality (for example put debounce period if your error code is 401) 👍


Docs: Updated docs to include steps to resolve the vlc ios incompatibility issue

@pratikbaid3 Thanks for Initiating! I hope you will be pointing out some more issues/bugs with the ios version in the future.


How to pop back to the native viewcontroller in iOS ?

I want to push a FlutterViewController in my exsiting iOS project , and add a back button on the top of the flutterViewController ,when I click the back button ,I want to pop back to the iOS navtive viewcontroller , how?

cc @mravn-google

@xster, can you help?

Calling SystemNavigator.pop() from you Dart code ends up invoking the following iOS code:
UIViewController* viewController = [UIApplication sharedApplication].keyWindow.rootViewController;
  if ([viewController isKindOfClass:[UINavigationController class]]) {
    [((UINavigationController*)viewController) popViewControllerAnimated:NO];
  }

If that doesn't do what you want, you can create your own platform channel to invoke arbitrary iOS code.

This is covered in the cookbook, and in a couple tutorials/codelabs.  For example:
https://flutter.io/cookbook/navigation/navigation-basics/
Closing.

I read it again and I was wrong. I'm going to add this to Flutter for iOS devs.

Is there a way to do this in iOS? Found a solution for Android but not for iOS :(


IOS 13 issue - Player is closing and Audio is playing

Since IOS 13 I have the following issue: If I start a HLS Video, the player starts and closes immediately afterwards. the audio continues to run but you can't see the player. Apparently the video is running in the background.
Warning: Attempt to present <LandscapeAVPlayerViewController: XXX> on <MainViewController: XXX> while a presentation is in progress!
I don't know if this warning has anything to do with it.
Cordova-ios: 4.5.5 on Iphone X

Could you solve the problem?

+1

@Durzan666
yes, but i dont know why.

@Durzan666 did you do something with the plugin itself or did the bug just disappear?
I mean have you readied the platform or something, that might caused the plugin to work again?

In my case the CDVViewController had a NavigationController so the NavigationController had to present the player.
So I changed
[self.viewController presentViewController:moviePlayer animated:YES completion:^(void){
        [moviePlayer.player play];
}];

to
if (self.viewController.navigationController != nil) {
        [self.viewController.navigationController presentViewController:moviePlayer animated:YES completion:^(void){
            [self->moviePlayer.player play];
        }];
} else {
        [self.viewController presentViewController:moviePlayer animated:YES completion:^(void){
            [self->moviePlayer.player play];
        }];
}

You can find my code changes here.

@attex I worked with a framework and updated to the last version. then it worked. I think it was a bug in the javascript.

I could fix it myself. Thanks anyway guys.
In my case the Eventlistener was thrown twice, so the function window.plugin.streamingMedia.streamVideo() was also called twice and caused the player to close immediately.


Add naver-site-verification to SEO

I Added a new search engine Naver to SEO.
Working example is my github pages.

Thanks for the PR.


Fix Backbutton is not displayed when there is a endDrawer

Previously the appbar infer backbutton from navigator.canpop, and Scaffold end drawer. It is hard to maintain. The internal use case is that they also want to backbutton to show up if there is a nested navigator in the route, so we have to provide a API to add appbar on route level as well.
This pr makes it so the ModalRoute.impliesAppBarDismissal is the single source of truth to add back button. There are two ways people can add backbutton.

overrides the ModalRoute.impliesAppBarDismissal directly
add a localhistory entry with impliesAppBarDismissal=true.

fixes https://github.com/flutter/flutter/issues/80256
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This change will require a internal fix, since some of the internal test still relies on willHandlePopInternally to bring up the backbutton

a friendly bump


Publish 3.1.2 release on GitHub and PyPI #419

What is the current status? :)

same here, when do you think the publish could be possible? thanks

Is it possible to install this package over pip?
I tried this:
pip3 install<EMAIL_ADDRESS>Collecting wagtailmenus
  Cloning https://github.com/jazzband/wagtailmenus (to revision releases/tag/v3.1.2) to /tmp/pip-install-3c8e55qq/wagtailmenus_072bc634173b434f994c3fe2e71ef2c7
  Running command git clone --filter=blob:none -q https://github.com/jazzband/wagtailmenus /tmp/pip-install-3c8e55qq/wagtailmenus_072bc634173b434f994c3fe2e71ef2c7
  WARNING: Did not find branch or tag 'releases/tag/v3.1.2', assuming revision or ref.
  Running command git checkout -q releases/tag/v3.1.2
  error: pathspec 'releases/tag/v3.1.2' did not match any file(s) known to git
WARNING: Discarding<EMAIL_ADDRESS>Command errored out with exit status 1: git checkout -q releases/tag/v3.1.2 Check the logs for full command output.
ERROR: Could not find a version that satisfies the requirement wagtailmenus (unavailable) (from versions: 0.2.1, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.0.6, 1.0.7, 1.0.8, 1.1.0, 1.1.1, 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.3.0, 1.3.1, 1.4.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 2.0.0, 2.0.1, 2.0.2, 2.0.3, 2.1.0, 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.2.0, 2.2.1, 2.2.2, 2.2.3, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.4.2, 2.4.3, 2.5rc1, 2.5, 2.5.1, 2.5.2, 2.6, 2.7, 2.7.1, 2.8, 2.9, 2.10, 2.10.1, 2.11, 2.11.1, 2.12, 2.12.1, 2.13, 2.13.1, 3.0, 3.0.1, 3.0.2)
ERROR: No matching distribution found for wagtailmenus (unavailable)
WARNING: You are using pip version 21.3.1; however, version 22.1.2 is available.
You should consider upgrading via the '/home/myhome/git/myvenv/bin/python3 -m pip install --upgrade pip' command.

Is it possible to install this package over pip?
I tried this:
pip3 install<EMAIL_ADDRESS>Collecting wagtailmenus
  Cloning https://github.com/jazzband/wagtailmenus (to revision releases/tag/v3.1.2) to /tmp/pip-install-3c8e55qq/wagtailmenus_072bc634173b434f994c3fe2e71ef2c7
  Running command git clone --filter=blob:none -q https://github.com/jazzband/wagtailmenus /tmp/pip-install-3c8e55qq/wagtailmenus_072bc634173b434f994c3fe2e71ef2c7
  WARNING: Did not find branch or tag 'releases/tag/v3.1.2', assuming revision or ref.
  Running command git checkout -q releases/tag/v3.1.2
  error: pathspec 'releases/tag/v3.1.2' did not match any file(s) known to git
WARNING: Discarding<EMAIL_ADDRESS>Command errored out with exit status 1: git checkout -q releases/tag/v3.1.2 Check the logs for full command output.
ERROR: Could not find a version that satisfies the requirement wagtailmenus (unavailable) (from versions: 0.2.1, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.0.6, 1.0.7, 1.0.8, 1.1.0, 1.1.1, 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.3.0, 1.3.1, 1.4.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 2.0.0, 2.0.1, 2.0.2, 2.0.3, 2.1.0, 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.2.0, 2.2.1, 2.2.2, 2.2.3, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.4.2, 2.4.3, 2.5rc1, 2.5, 2.5.1, 2.5.2, 2.6, 2.7, 2.7.1, 2.8, 2.9, 2.10, 2.10.1, 2.11, 2.11.1, 2.12, 2.12.1, 2.13, 2.13.1, 3.0, 3.0.1, 3.0.2)
ERROR: No matching distribution found for wagtailmenus (unavailable)
WARNING: You are using pip version 21.3.1; however, version 22.1.2 is available.
You should consider upgrading via the '/home/myhome/git/myvenv/bin/python3 -m pip install --upgrade pip' command.

Yes, you can install with the zip file:
pip install https://github.com/jazzband/wagtailmenus/archive/refs/tags/v3.1.2.zip

You can put something like this in the requirements.txt or similar file:
wagtailmenus @ https://github.com/jazzband/wagtailmenus/archive/refs/tags/v3.1.2.tar.gz

I'm sick of waiting for #409 to close in order to have a proper release.
I tried contacting @jezdez via GitHub issues and email, with no responses.
The only time I got a reply out of him was  complained on Twitter (and even then he got defensive).
I feel super guilty for convincing the original maintainer to move to Jazzband. I just have asked them to transfer it to me directly instead.
With the launch of Django 4.1, my projects are collecting tech debt to a point I can no longer afford. So I'm considering just forking this project and publishing it on PyPi on my own. Would that be too bad?

Please do this. Jazzband seems to be dead.

I'm sick of waiting for #409 to close in order to have a proper release.

Please be so kind and reflect on what you're saying here, you're "sick" about waiting on volunteers to do something for you. That's really not an appropriate way to communicate here. I get your frustration, of course, but you must realize that nobody here works for you.
Plus, the timeline in https://github.com/jazzband/wagtailmenus/issues/409 doesn't support your impatience, the transfer to Jazzband hadn't even been finished yet (the project lead question was still open). I only get to responding to the request now, not really complicated.

I tried contacting @jezdez via GitHub issues and email, with no responses.

True, I'm sorry for having not responded so far, life just keeps happening and my spare time is limited. Circling back to the transfer request in https://github.com/jazzband/wagtailmenus/issues/409 is on my TODO list and your words here made it jump to the top.

The only time I got a reply out of him was when I complained about Jazzband on Twitter (and even then he got defensive).

No need to talk about me in the 3rd person, I get defensive when unreasonable expectations are voiced publicly.
The latest state of the world was that I asked you to decide who would be the project lead for the project, to finalize the transfer to Jazzband, and you responded on June 1 (4 months after initial transfer): https://github.com/jazzband/wagtailmenus/issues/409#issuecomment-1143857204.
FWIW I have to say that I'm on the fence of making you project lead now given the lack of conduct you've shown here though. When contributing to Jazzband projects you're agreeing to follow its Code of Conduct, I encourage you to review it again.

I feel super guilty for convincing the original maintainer to move to Jazzband. I should have asked them to transfer it to me directly instead.

Sure, transfer is still an option to be clear, Jazzband isn't a prison, assuming the original author @ababic agrees.

With the launch of Django 4.1, my projects are collecting tech debt to a point I can no longer afford. So I'm considering just forking this project and publishing it on PyPi on my own. Would that be too bad?

I'm sorry, but that's not realistic, the transfer of the project to Jazzband happened on February 1 2022, with the final decision who project lead is happening on June 1, hardly a long time on a larger scope to call this to be an issue of tech debt.

Please do this. Jazzband seems to be dead.

Come on, that's way out of line @sowinski.

Now with #409 closed (@MrCordeiro and @schlich have volunteered as project leads) this ticket can be handled by the project leads.
@MrCordeiro @schlich I've resent the release notifications to you about the pending releases as shown (for you) on https://jazzband.co/projects/wagtailmenus. Please follow the instructions in them.

Thank you @jezdez for following up on this.  I will be merging tonight after review.

Go forth and prosper, friends.  Will go over existing PRs asap.


Erroneous PhanUndeclaredClassMethod when a namespace and class share a name.

This represents terrible code, but technically Phan is unable to resolve a class that PHP7 resolves just fine at runtime.
How to reproduce:
<?php // Filename: Foo/Api/Api.php
namespace Foo\Api;
class Api
{
    public function getName()
    {
        return get_class($this);
    }
}

<?php //Filename: main.php
use \Foo\Api;
require 'Foo/Api/Api.php';
$api = new Api\Api();
printf("%s\n", $api->getName());

What phan Reports
[
  {
    "type": "issue",
    "check_name": "PhanUndeclaredClassMethod",
    "description": "UndefError PhanUndeclaredClassMethod Call to method __construct from undeclared class \\Foo\\Api",
    "severity": 10,
    "location": {
      "path": "./main.php",
      "lines": {
        "begin": 7,
        "end": 7
      }
    }
  },
  {
    "type": "issue",
    "check_name": "PhanUndeclaredClassMethod",
    "description": "UndefError PhanUndeclaredClassMethod Call to method getName from undeclared class \\Foo\\Api",
    "severity": 10,
    "location": {
      "path": "./main.php",
      "lines": {
        "begin": 8,
        "end": 8
      }
    }
  }
]

PHP7 Runtime Output
Foo\Api\Api

Cant't reproduce this too, is this still actual? Another issues works.

Thanks @Sentoki.
@kellegous Any chance you could re-test this? It looks like it got fixed somewhere between now and when you reported it via magic.

👍 Can't reproduce this any longer. Thanks! 👏


Fix haplotype rendering

Differentiate "view in new tab" and "download" functionality with force_download util function.

Thank you for the suggestions!  I've revised the interface:
<a href="..." onclick="force_download(event)" download="filename.png"> ... </a>

I wasn't able to get rid of the event argument to force_download, but I think this is much better.
I also made the function safer:

Creates a temporary a element for the initial click, so the function doesn't recursively trigger itself.  If anything goes wrong, it won't be able to create an endless loop.
Checks for empty href attribute and throws an error instead of proceeding.

I'm not sure yet how to handle errors... I don't think any of the links in the download page have good error handling.  Might be worth looking to in its own branch.  I'll add a card to Basecamp.


Non-racing lock for driver pool

The mutex guarding the driver's pool attribute does not need to be held while doing IO. Therefore, we can use a standard (non-cancelable) mutex to guard it. This comes at the benefit of not needing a context for session creation. Session creation doesn't perform any I/O, so it shouldn't take long anyway. There's little to no gain in it accepting a context.

lock updates make sense to me 👍


Error message when git remote URL throws exception if no origin remote

Fails to give the error message when run any task involving git if the URL doesn't contain the origin remote.
This is because in the project config URL is set to None due to thisurl = self.git_config_remote_origin_url()
and when the below function is called. Parse_repo_url is called with None as argument.
def get_github_api_for_repo(keychain, repo_url, session=None) -> GitHub:     owner, repo_name, host = parse_repo_url(repo_url)
Work item: link

Hi @jkasturi-sf
I have added the clear error for the parse_url when the url passed doesn't have remote set as origin
please review the code
Thank you

Hi @jstvz
Requested changes are made. Please go through the changes.
Thank you


RFC-0005: Optional starting offset for processor inputs.

Implementation at:
system: https://github.com/projectriff/system/pull/231
cli: https://github.com/projectriff/cli/pull/164
streaming-processor: https://github.com/projectriff/streaming-processor/pull/38

How long is this open for comments?

Hopefully end of day dec 3rd EST should be enough?

Merged as cf6efd1087a89d7337b5a9f4d608241db0b43f64


Error in request while trying to search movie

Hi,
I get this error while trying to search a movie. I got my API key OMDb Api key in place. (v. 1.1.13)

Also, not sure, but the example template seems to be messed up.

This happens if the plugin can not reach the Omdb API. this can happen because of network problems/ connectivity issues. maybe try if you can access https://www.omdbapi.com/ in your browser and try running the search again.

This happens if the plugin can not reach the Omdb API. this can happen because of network problems/ connectivity issues. maybe try if you can access https://www.omdbapi.com/ in your browser and try running the search again.

Yes, I can access it via browser. I even tried searching with VPN on to no avail.

I found out what the problem was. I should've entered API key only, not the link with the api key. Now it works.

I found out what the problem was. I should've entered API key only, not the link with the api key. Now it works.

Ah i see. Maybe i will add a validation warning, so this does not happen again.


Update through2.js

this syntax doesn't break on older node versions

"older", what version are you using?

Node 4.9.1
On Wed, 1 Jul 2020 at 12:41 Rod Vagg<EMAIL_ADDRESS>wrote:

"older", what version are you using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rvagg/through2/pull/106#issuecomment-652312420, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUFHOZM65J2HGHB7GPPYDDRZMAFTANCNFSM4ONCARWQ
.

OK, so that's quite old now, the minimum supported version of Node.js is 10. Unfortunately we can't tie ourselves to support ancient versions, although there's still through2@3 that you can pin to and it'll work just fine. I know this sucks, but we have to draw lines and "minimum supported" versions of Node.js is a pretty good line to adopt, even for popular packages.


If not on Swift 5+, use old datatypeValue implementation

This fixes compiler errors when using the latest release of SQLite with Swift 4.2/Xcode 10.1 (as discussed in this issue: https://github.com/stephencelis/SQLite.swift/issues/920)
I notice the test suite is set up to only build and run with SWIFT_VERSION=5.0 To verify this fix, I manually changed the version to 4.2 and ran it in Xcode 10.1. However it might be desirable to also duplicate all test targets and have them also run on 4.2 if continued support of the previous version is desirable.

@jberkel Is it planned to keep the support for Swift 4.2 and lower?

I would prefer to move on to Swift 5.x.

We dropped the support of Swift 4.2 in 0.13.0.


Best practice for representing build plans

This proposes to import the SEP055 proposal as a best practice for representing build plans.

[ ] Examples need to be added.

Approved. But let's wait for the previous BP PRs to be approved and merged.

@PrashantVaidyanathan This is still not named BP011 and moved to that directory.   Are you going to fix this?

11 and moved to that directory. Are you going

@cjmyers This has now been fixed. The files have also been restructured to only include core rules of the best practice.


Add IContextIndex

It'd make sense for IRenderingContext to also have and implement IContextIndex, which will resolve the index for the datasource or context item, similarly to IContextDatabase. This should improve testability of indexing code.

https://github.com/kamsar/Synthesis/commit/577986363f97d45708ecbab9280b6deb0cd82da2

Fixed in 8.2.6


Fix arc mod for x86_64

reference: https://stackoverflow.com/a/74067363
with this change, cidre should now compile on x86_64-apple-darwin

Thank you


George export disable

@devoncarew
Export button no longer visible. Should be ready to be pushed onto dev before live.

lgtm!

#577


Deprecate healthchecks with are not pushed the Mesos Agent

JIRA Key: MARATHON-839
Reporter: Sargun Dhillon
Priority: High
Description:
We should deprecate healtchecks that are not done by Mesos on the slave. Currently, this includes the HTTP, and TCP healthcheck. The current pattern of healthchecking from the framework is counter-productive in that it's Marathon specific, and it's hard to extract information from. In addition, as the network team is implementing filtering, we have to take into account remote healthchecking from a framework instance which may change.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-1714. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-1714. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


build(app): fix bash CI/CD pipeline script

Error with port allocation is fixed, next time we need to separate this to a different branch.


SpatialNavigationScrollView have the option to only scroll when next element is not in view/fully visible.

Is your feature request related to a problem? Please describe.
Currently when using a spatialNavigationScrollView, it always scrolls the view when going to the next focused node. While not a problem, it would be nice to have the option to only scroll when the newly focused element is not in view.
Describe the solution you'd like
Some sort of flag, or even a more detailed option to control how the scroll view behaves while the user is navigating between nodes. I am open to any type of api implementation.
The screenshot below shows the behaviour we would like to create.

Hello, I am not 100% sure I understood you problem but do you mean to change the scroll behaviour?
We have one called jump-on-scroll, which might solve your issue?
It's not present in the example (which is probably a mistake for discoverability)!

Hey @pierpo, sorry about the confusion earlier. I've seen that option with the virtualized lists, but it doesn't seem to be available with the SpatialNavigationScrollView. Looking at the type definition of SpatialNavigationScrollView Props, here are the options I found:
horizontal, style, offsetFromStart, children, ascendingArrow, ascendingArrowContainerStyle, descendingArrow, descendingArrowContainerStyle, pointerScrollSpeed
We're attempting to make the SpatialNavigationScrollView scroll only when it's necessary. using the screenshot from my original post as an example:
As the user navigates among the first 7 items, the scroll view won't actually scroll because the focus keeps shifting between items that are fully visible on screen. But, when the user moves to the 8th item, which isn't fully visible, The scroll view should scroll to put the newly focused item is fully visible on the screen.
Another good example would be the carousels in plex. In plex, the carousels don't scroll until focus is in the centre and continues to scroll and keeping the next item in the centre.
Here's a video showing the behavior we're trying to recreate, which we've already achieved in React.
https://github.com/bamlab/react-tv-space-navigation/assets/107000750/9a52f4b3-9f6b-4458-926d-8a1350b574b6
Thanks again for your assistance. This library has been awesome! 👌

Hey @connor-iversoft!
So, one way to achieve this in a similar way is behaviour stick-to-end on a virtualized list.
But unfortunately we don't support the fact that when we come back, the behaviour becomes stick-to-start. The behaviour is completely symmetrical: scrolling of the window depends exclusively on the focused element, so it will be the same while scrolling left or scrolling right 🤷
(I don't know if what I'm saying is clear, as I use the lib's nomenclature)
About the fact that it scrolls when the element is half visible, I think this is achievable with the virtualized list using the proper parameters 🤔
Play around with the items visible on screen etc. and it should look similar 😁

Thanks for the detailed reply! I'll play around with what you mentioned. Thanks!


Error in Usage with new version of react native

Tried to register two views with the same name BVLinearGradient
How can i solve this please

I got the same error with RN 0.50.3

I had the same problem. In my case I returned all android files to state before calling "react-native link" and manually add native files to project like it`s described in README.

related to https://github.com/entria/gol-app/pull/1877

this is happening on RN51 as well

maybe the cause is the same of react-native-svg
check this commit: https://github.com/facebook/react-native/commit/e9780bdc0f00364359f39e5a76a3e43eadb93a4b
and this solution: https://github.com/react-native-community/react-native-svg/pull/486#issuecomment-340111157

is this still a problem in master?
can somebody create a PR for this? based on react-native-svg work?

not an error with this package
this could happen when some package defines this package as a dep
like this one https://github.com/tomzaku/react-native-shimmer-placeholder

I got the same error with RN 0.53.0

we merged this one instead https://github.com/react-native-community/react-native-linear-gradient/commit/9df5291d574b15c569da80b7cc535060ec8d0ac9
can u try using latest master?

That seems to be working well for me!
On Thu, Apr 26, 2018 at 12:09 PM Sibelius Seraphini <
<EMAIL_ADDRESS>wrote:

we merged this one instead 9df5291
https://github.com/react-native-community/react-native-linear-gradient/commit/9df5291d574b15c569da80b7cc535060ec8d0ac9
can u try using latest master?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/react-native-community/react-native-linear-gradient/issues/230#issuecomment-384757112,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABE4MZKnXAW1PjHxhB1IHBl5ahlLKbrks5tshtXgaJpZM4QJ35B
.

it's fixed in master, can we get a new version in NPM?

nothing seems to be working

whats the point of closing issue when it hasn't been fixed??

@shohailahm open another issue with more information and then we can try to help

I'm having the same exact issue when I had an existing react-native-linear-gradient package before I installed @shoutem/ui

since shoutem is also using the react-native-linear-gradient, metro bundler will go into ambiguity and causes this error.
you can use shoutems package or remove its dependency as follows.
rm -rf node_modules/@shoutem/ui/node_modules/react-native-linear-gradient
solved my issue
Hope it helps :)

@GaneshKonathala007 I used your solution but now I get the following error.
undefined is not an object (evaluating 'Object.keys(_reactNativeLinearGradient.default.propTypes)')
Although what really bugs me is why Shoutem is recreating the linear gradient component and forcing it on the user of the library, I use LinearGradient but I didn't use it through Shoutem, they don't even have it in their docs, but it's forced on the user within the library, strange. Just putting it out there though.

@GaneshKonathala007 never mind found a fix, so for anyone coming here, I assume you've installed Shoutem UI in your project, simply use the LinearGradient from Shoutem UI instead, it imports react-native-linear-gradient and tries to modify it by adding styles to it, so instead of using.
import LinearGradient from 'react-native-linear-gradient'
use
import {LinearGradient} from '@shoutem/ui';
hope this helps someone out.

I solved this by just running yarn add react-native-linear-gradient in my repo. I already had that dependency, but I used earlier version, specified with exact version number in my package.json. Another lib was also using react-native-linear-gradient, but newer version, that's why it all ended up having 2 versions of the same lib.


Deploy with Deploy.sh

Could you please explain how to run the deploy.sh

What remote configurations to be modified
Verbose example would be useful to those who don't work on Ruby platform

You should just be able to run ./deploy.sh in the directory and it should work automatically!

It worked after I appended -install and the remote path. Thanks though


Ux vote loading

Added a loading wheel for when the user clicks on a vote until the server responds.
If the server doesn't respond than display error message (see image below)

Fixes: #73

Screenshots and screen captures:

Self-review checklist

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review:

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes (what you are trying to accomplish? e.g. don't let user's age less than 0).

Completed manual review and testing of the following (please attach screenshots/gifs for UI changes and commit your test cases for functionality changes):

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Also request another project owner to take a look, because I'm not sure if they want to add another library (Material UI)

I cannot request anyone to review, only maintainers can. It was not my idea to add MUI, @huonggiangbui requested it in #73

LOL you can use any library you want, MUI just a suggestion

MUI is fine imo, but I want to see what Shubh or Chris think about this

LOL you can use any library you want, MUI is just a suggestion

Oh, sorry for the misunderstanding.

It's okay, I should make it more clear!

Personally, I wouldn't add in MUI. We already have Tailwind CSS and personally, I don't want to be adding in another dependency for this

Personally, I wouldn't add in MUI. We already have Tailwind CSS and personally, I don't want to be adding in another dependency for this. For example: https://flowbite.com/docs/components/spinner/ - Just found this after a quick google search for a spinner using Tailwind

The spinner wasn't what we added MUI for, we wanted a cleaner error message. But I'll come up with something.

Used alert() because this message shouldn't pop up often and to avoid adding another library/component. Please review and let me know of any changes you want me to make.

If tailwind is already a dependency a better solution might be to use one of their modal components https://tailwindui.com/components/application-ui/overlays/modals

If tailwind is already a dependency a better solution might look nicer to use one of their modal components https://tailwindui.com/components/application-ui/overlays/modals

I will look into it, thanks!

@logonoff Sorry for this taking a while, I had midterms and was busy with other school stuff.
Anyhow this should now use tailwind's alert box instead of the ugly javascript one.
Here is a gif preview:

I know this is incredibly picky, but I'm not liking that the spinner isn't centered around the C. :laughing: Is it easy to fix that?

Well the spinner is centered, I think anything else would look odd. A possible fix can be to mess around with the size of the spinner.

Are any of these any better @embeddedt?

The issue is less obvious now but it's still not centered compared to the center of the C. I'm not sure why.

Also, I like the first design in https://github.com/utmgdsc/PollVotingSystem/pull/74#issuecomment-1288165720 the best (the one with no background), as it looks cleaner IMO and should also be easier to port to a future dark mode.

Hey is this still open?


Theme keys customization not working properly in WinUI ComboBox and ListView control

Describe the bug
I am placing a ListView control inside the Popup and showing the popup based on toggle button checked state. Theme keys customization works properly in ListView only while opening popup for first time. On subsequent popup open, it was not working.
Similarly, the same issue happens with MS ComboBox control.
Note: Suppose, if we update ListView ItemsSource every time while opening popup, then customization works fine.
Steps to reproduce the bug

Run the sample.
Click toggle button, the popup will open. Note theme key customization works properly in ListView.
Now, again click toggle button to close popup.
Repeat step 2, note theme key customization not working properly in ListView.

Please find the video and sample for the same:
Sample:
ThemeKey-Customization-issue.zip
Video:
https://github.com/microsoft/microsoft-ui-xaml/assets/92976485/2a5d5164-e3bc-4f8c-9794-c534437ab09b
Expected behavior
Theme keys customization should works properly in WinUI ComboBox and ListView control
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.3.2: 1.3.230602002
Windows version
Windows 11 (22H2): Build 22621
Additional context
No response

@SubashiniMahendran I'm not sure why this would be inconsistent. The popup tree is different from where the Page resources are, so I can imaging the resources in the page not getting picked up with the popup opens. Adding those resources to App.Resources should help.


Tests and indexes in packfile decoder

Add tests to 64 bit offset index creation and FindHash
Add index generation to packfile.Decoder
Remove duplicate filesystem.IndexStorage

Should tests be failing?

They also fail in my computer so yes, there are still tests failing. I still haven't look why they fail.


Where is the generated image stored?

Where is the generated image stored?
I'm learning cifar10, can not I create images while learning?

python trainer.py --dataset CIFAR10 --dump_result True

is not working...

python trainer.py --datset CIFAR10 --dump_result

is working
but, after i do it,
python visualize training.py --h 32 --w 32 --c 3 --n 8 --output_file visualize_sample --train_dir train_dir/defaut-CIFAR10 ~~~

then -> ***'KeysView' onject does not support indexing...***
my environment python 3.5

If --dump_result is specified, the generated images would be stored in the training directory in the hdf5 file format (.hy).

Can you provide all the commands you tried to visualize the training? Also, please provide the detailed information including how many iterations you ran, etc.

python visualize_training.py --output_file visualized_sample --train_dir train_dir/default-MNIST_lr_0.0001_update_G5_D1-20180707-162149 --h 28 --w 28 --c 1 --n 8
is not working
File "visualize_training.py", line 26, in
I[args.hi:args.h(i+1), args.wj:args.w(j+1), :] = f[f.keys()[0]][i*args.n+j,:,:,:]
TypeError: 'KeysView' object does not support indexing

python visualize_training.py --output_file visualized_sample --train_dir train_dir/default-MNIST_lr_0.0001_update_G5_D1-20180707-195643 --h 28 --w 28 --c 1
Traceback (most recent call last):
File "visualize_training.py", line 31, in
imageio.mimsave(args.output_file, II, fps=5)
File "/usr/local/lib/python2.7/dist-packages/imageio/core/functions.py", line 320, in mimwrite
writer = get_writer(uri, format, 'I', **kwargs)
File "/usr/local/lib/python2.7/dist-packages/imageio/core/functions.py", line 170, in get_writer
'in mode %r' % mode)
ValueError: Could not find a format to write the specified file in mode 'I'


Future of plugins repository

I had been discussing with @louwers also re. https://github.com/maplibre/maplibre-native/issues/1151#issuecomment-1551501601 how to structure the Android-specific code.
I notice that there is currently some deprecated annotations code in maplibre native, and a non-deprecated (but highly confusingly essentially duplicate) implementation here in the plugins. Most of the maplibre plugins are currently also unmaintained.
It can also be confusing for developers that there's two separate sample apps (one for maplibre-plugins-android and one for maplibre-native android).
For these reasons we think that the current situation is rather messy and should be cleaned up. One possibility would be to move the plugins into maplibre-native.
Possible benefits (if done correctly):

remove deprecated code and replace it with working one
less confusing structure
tighter integration has benefits regarding APIs for users (more sensical structure)

Let me elaborate what I mean with a "tighter integration": currently a user of the annotations plugin has to maintain one instance of AnnotationManager per type of annotation – see https://github.com/microg/GmsCore/blob/80780737726416d7924ba28a5c26acfa17fb1520/play-services-maps-core-mapbox/src/main/kotlin/org/microg/gms/maps/mapbox/GoogleMap.kt#L116-L131 for a real-world example. This is not something that users should be bothered with, it just adds to their boilerplate code. If there was a manager for each annotation managed inside the map object (e.g. a lazy kotlin object), this would reduce the amount of work that would need to be done to add a marker to the map. The other way seems very tedious.

Just to be clear - is it suggested here to move the annotations plugin or all the plugins into Native?

@birkskyum I think it is up for discussion for which plugins this makes sense. For instance we would also want to integrate the marker view plugin (again¹).
¹ MapLibre has an InfoWindow implementation, made to imitate Google's info windows, that works similarly but not exactly the same.

Okay - I get this impression that whatever we don't bring over now will be left in a dusty archive without the important annotations plugin to keep it just a bit alive. Probably best to bring over anything that could hold value, even it it might seem as "too much", so that this repo won't need to be resurrected down the line.

Just to be clear - is it suggested here to move the annotations plugin (the ticket maplibre/maplibre-native#1154) or all the plugins (the mention above of "move the plugins") into Native?

We will move Annotations first, which is arguably the most important, and then we look at the others.
My suggestion
Move to Core

Probably best to bring over anything that could hold value

MarkerView: Add map markers that are Android views.
Probably good to move over.
Scale bar: Provide a visual map scale bar for your users to determine distance.
Probably good to move over.
Maybe, but only if someone asks
Building: Add extruded "3D" buildings in your map style.
Probably we can get rid of this.
Offline: Download maps tiles and manage downloaded regions for situations when a user's device doesn't have an internet connection.
Already part of the core, but maybe this plugin offers some convenience?
Get rid of
Traffic: Adds a real-time traffic layer to any Mapbox base map.
Tied to proprietary API.
Location layer: [Deprecated] Add a location marker on your map indicating the user's location.
Already part of the Core SDK.
Places: Add location search to your app with beautiful UI.
Tied to Mapbox.
Localization: Have your map's text automatically match the device's default language setting.
Tied to Mapbox.

As a general question, do you have a clear outline of which things are confusing / duplicate / wrong with the other plugins? You have a very clear outline for annotations, but which of the other ones are actually troublesome? Which changes are needed and how would integrating benefit the plugins?
Now a little more specific: As you might have already seen I'm working on a fork of the download plugin to breathe some new life into it, I personally (without ever having had the big picture view or any trouble with the issues you describe above) think it stands quite well as an external plugin. It's quite clearly optional and easily distinguished from the core code. Also this made my getting into maintaining it super easy.
You write that the offline plugin is already part of the core? Well kinda, yes, it calls the OfflineRegion and OfflineManager classes, but it functions as a wrapper. How do you see the roadmap here?

@avalanchas Right now we only have a roadmap / plan for Annotations thanks to Fynn.
When it comes to the Offline plugin, we'd be happy to link to your fork from the Android README at maplibre/maplibre-native. Feel free to submit a PR.

Hello,
I am using MapLibre's MarkerOptions, PolylineOptions. Both of which are marked as "Deprecated". My question is:

What is the recommended API presently (with latest version)?
What will be the recommended API (with upcoming version(s))?

https://maplibre.org/maplibre-native/docs/book/android/annotation-guide.html
What's the recommended approach to be future proof.
Thankyou.

@alexmercerind This Annotations plugin is not going anywhere and various users showed interest to keep it up to date. We're also not going to remove the Annotations functionality from the core in the upcoming release even though they are  deprecated. So don't worry choosing either option.
The future is the to-be-implemented Kotlin API that @fynngodau is working on. Likely the internals of MapLibre Native will be overhauled at some point to support more flexible and performant annotations.


Seems to not be working after upgrading container

I don't have Watchtower auto update but just send notifications. Today I updated a few containers, STT being one of them. It seems now that when I run a test it gets stalled in STARTING. I also don't have any graphs of previous tests that had been completed.

I have TZ: America/New_York which at the time of writing is 9:25 pm Sept 30, 2024 but the last log time says Oct 1 at 1:14 am
error.log

If you came from a prev0.20.0 make sure to read the release notes from that series. A lot has changed.

I haven't had it installed that long. I started with 0.21.1 Which I nitice after updating mine still says 0.21.1, not 0.21.2

I'd turn on debug mode and see what the logs tell you, directions can be found here: https://docs.speedtest-tracker.dev/help/faqs#im-getting-a-500-or-server-error-error

If you could share your docker compose as well, that might be helpfull to :)


Cannot read property 'parentNode' of undefined

When I try to test my loading function using Jest, I get this error.
TypeError: Cannot read property 'parentNode' of undefined

      at _addScript (node_modules/little-loader/lib/little-loader.js:43:17)
      at _lload (node_modules/little-loader/lib/little-loader.js:209:7)

I found this error in an old issue too #37 .
What is your recommandation to test your lib using a test runner like Jest ?
Thank you

Since Jest uses JSDOM instead of a real browser environment, it won't have an actual <script> in the document like you'd find in a real scenario (there will only be an empty placeholder document created by JSDOM).
I can think of a couple options:

Normally you can configure the document to use with JSDOM and you'd be able to fix this there, but I think Jest hides that setup from us. So use JDOM to append an empty <script> tag to the document in the setup/before method of your test. That way the document will reflect what a real browser's would look like.
Mock out little-loader since you're sort of testing too much by actually calling it – if it's a unit test you really only want to test your own code. It's also often considered bad practice for your test suite to actually hit the network (for this reason, I might recommend mocking out little-loader even if your tests were running in a real browser environment and working). In Jest you can use mock.fn() to do this.

Thank you very much, the first solution works for me


How to deploy incrementally

I want to request a feature.
When I deploy a subgraph, I will traverse all blocks.
How to deploy incrementally

hi @XdpCS , not sure what you mean how to deploy incrementally - you only want to index a limited block range?

Hi @azf20.When I deploy a new contract, I don't want to deploy a new subgraph because the old contract information in the graphql will disappear within a certain period.


Optimisation problem in gpflux

Hi,
I'm using a two-layer deep GP with Poisson likelihood. With the default zero mean function, there is no problem  for step:
history = model.fit({"inputs": x_train, "targets": y_train}, batch_size=batch_size1,  epochs= 100, callbacks=callbacks, verbose=0) where we have 100 epochs.
However, when I add a constant mean such as -10, when epochs are greater than 10, it will always result in matrix inversion problem.
Traceback (most recent call last):
File "xx.py", line 464, in
history = model.fit({"inputs": x_train, "targets": y_train}, batch_size=batch_size1,  epochs= args.nIter, callbacks=callbacks, verbose=0)
File "xx/anaconda3/lib/python3.7/site-packages/tensorflow/python/keras/engine/training.py", line 1100, in fit
tmp_logs = self.train_function(iterator)
File "xx/anaconda3/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py", line 828, in call
result = self._call(*args, **kwds)
File "xx/anaconda3/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py", line 855, in _call
return self._stateless_fn(*args, **kwds)  # pylint: disable=not-callable
File "xxxx/python3.7/site-packages/tensorflow/python/eager/function.py", line 2943, in call
filtered_flat_args, captured_inputs=graph_function.captured_inputs)  # pylint: disable=protected-access
File "xx/anaconda3/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 1919, in _call_flat
ctx, args, cancellation_manager=cancellation_manager))
File "xxx/anaconda3/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 560, in call
ctx=ctx)
File "xxx/anaconda3/lib/python3.7/site-packages/tensorflow/python/eager/execute.py", line 60, in quick_execute
inputs, attrs, num_outputs)
tensorflow.python.framework.errors_impl.InvalidArgumentError:  Input matrix is not invertible.
[[node gradient_tape/model/gp_layer_1/triangular_solve/MatrixTriangularSolve (defined at xx.py:464) ]] [Op:__inference_train_function_6603]
Errors may have originated from an input operation.
Input Source operations connected to node gradient_tape/model/gp_layer_1/triangular_solve/MatrixTriangularSolve:
model/gp_layer_1/Cholesky (defined at /gpfs/ts0/home/xx249/anaconda3/lib/python3.7/site-packages/gpflow/conditionals/util.py:56)
Function call stack:
train_function
However, optimisers if they can compute the objective at the start should not fail and crash when they try parameters that fail the objective (they should just keep the current objective and sample somewhere else, as what the Scipy optimiser does.
Just wondered if there is any solution for this?
Many thanks.

Hi @XiaoyuHy, thanks for your issue. Can you please post a minimal failing example and your development environment (Python, GPflow, GPflux and Tensorflow versions) so we can replicate the bug?


Translation: nl-NL updates

Report a problem with a translation
@CMTriX
When you have time, would you mind updating the nl-NL language file for Windows Update Viewer?
Since your last update I've had to change the procedure. Please refer to the updated article in the wiki.
There are just a few strings that need to be updated.
<!-- Begin changes on 2023/11/13 @ 20:45 UTC -->
<!-- * | Value for About_Contribute needs to be updated to "Contribute a Translation" -->
<!-- * | The OperationType_* group needs to be translated -->
<!-- * | The ResultCode_* group needs to be translated -->
<!-- * | MenuItem_SaveJSON needs to be translated -->
<!-- * | SettingsItem_EnableLanguageTesting needs to be translated -->
<!-- A | About_GitHub needs to be added -->
<!-- A | Button_Close needs to be added -->
<!-- End of changes on 2023/11/13 -->

Thanks for your continued support! ❤
Also, if you know anyone that could help with getting de-DE, fr-FR, or ca-ES, updated, or adding a language that is missing, ask them to join the fun. 😉
Tim
Contribute a translation
No response
If this is a contribution, enter the language name and code
No response
If you wish to have your contribution acknowledged
No response

ok,

read
download tool
searching for the language file to update

I think the translation update is done, please validate if you have time.

I deleted my comment. I was logged in old account. Sorry


Dependency upgrades

Notes:

Holding back node-fetch for CJS support
Holding back Prettier and plugins, because there still isn't full support for Prettier 3
Using @medplum/esling-config in more of the example packages

coverage: 94.283%. remained the same when pulling ab0284801556be7f027d623ed429931877280952 on cody-dep-ugprades-2023-07-26 into ae3d918e65e5d841f22be27785d0ac7cf3f15fbd on main.


ARTEMIS-1951 Fix NPE on updateQueue with NULL user

The previous commits of ARTEMIS-1951 were using SimpleString::new that were
throwing NPE when the String parameter is null.
This fix is just using SimpleString::toSimpleString that won't throw NPE.

I wonder if its worth making the constuctor of simplestring deprecated, to avoid such issues

@michaelandrepearce, that constructor is used over 2,000 times in the code-base so deprecating it probably isn't the best option.  I think we'd probably rather want to just move the null check from the toSimpleString method to the constructor itself.

toSimpleString returns null object, if given a null input, Construcor will always give you and object. This is why that method exists to encapsulate that

@michaelandrepearce, I'm not sure I'm following.  Are you saying that by moving the null check from toSimpleString to the constructor then toSimpleString becomes essentially useless (since it would just be a facade over the constructor)?

No im saying quite the opposite. To get the effect of having a null object returned when a null string is passed in. You cant do with constructor as you will have a SimpleString object. E.g. if we wanted to make it so if null  string what is returned is null the only way is via a static such as the toSimpleString method.

Just to be clear im very +1 this change this was more just sparking a discussion about how to avoid in future. I guess this should goto a discuss thread to contiue if we want. And leave Franz's PR to close in peace

@michaelandrepearce @jbertram i'm pleased to host your discussions guys but "close in peace" is nice eheh


PostgreSQL Slony Create Cluster and Upgrade Cluster Support

As a followup to https://github.com/nkiraly/DBSteward/issues/89
Add slony replication create and upgrade support to ensure slonik scripts work going forward
Add maven plugin contrived tests to support this

This is working as of  1900aaa1613715d0a0755931da8b297c6342ad1b
tested with DBSteward https://github.com/nkiraly/DBSteward/commit/dde6d5b0ca82e6721634e5e2f649b84ddcaf0f5b

See example3 and example4 for slony install and upgrade pom configuration


SwipeItem icons disappear

First, thank you so much for addressing this multi-year long bug in MAUI's codebase. The tickets are ignored.
Your package works like a charm except for the following. When using it in a ListView, the SwipeItem content disappears.
The built-in SwipeView
var swipeView = new SwipeView
{
	Content		= row,
	Threshold	= 100,
};

Your CustomSwipeView
var swipeView = new ActivableSwipeView.Views.CustomSwipeView
{
	Content				= row,
	Threshold			= 100,
	ActivationThreshold = 50,
};

Any ideas would be most appreciated.
Thanks again.

I fixed the issue and uploaded a new version of the NuGet package (1.0.5).

That's great. It works as expected.
Thank you for the quick reply and fix.
You rock.


Fixed bug where boto3 resource are ignored for object upload

Title
Fixed bug where boto3 resource are ignored for object upload
Motivation

Fixes #575

Thanks for picking this up! Can you please add some tests?

Thanks for picking this up! Can you please add some tests?

@mpenkov Would extending test_minio.py under the test directory to handle write request in addition to read request be okay or a separate test file is needed?

@mpenkov Would extending test_minio.py under the test directory to handle write request in addition to read request be okay or a separate test file is needed?

I think the best way to test this would be a few new test cases in test_s3.py. You could wrap the resource in a Mock object and then check that the resource was correctly re-used by smart_open. Does that make sense?

I think the best way to test this would be a few new test cases in test_s3.py. You could wrap the resource in a Mock object and then check that the resource was correctly re-used by smart_open. Does that make sense?

I added the tests myself. Thank you for your contribution @jackluo923 !

I added the tests myself. Thank you for your contribution @jackluo923 !


Add Channel Specific Success Reactions

why hello there? this fixes #111

You're truly the best. I'll let Matthew take a look this week!


add table designer menu to Azure view

This PR fixes #18298

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.239%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
14797

Relevant Lines:
29107

💛  - Coveralls

@alanrenmsft Do we want to enable it for all kinds of servers right now? If yes, then looks good

@abist what do you mean by "all kinds of servers"? I am only enabling it for MSSQL provider.

@alanrenmsft azure sql db + on prem vs on-prem only

And MI too (engine edition 11)
https://github.com/microsoft/azuredatastudio/blob/8e1e9a95c30daa906b865b4e8fff45ecf2d8ce22/extensions/import/package.json#L55


Bower.io register

Hi, thanks for this project initiative, looks very nice!
I see the bower.json file but the package is not found on bower.io: http://bower.io/search/?q=select2-bootstrap-theme
Can you please register it? Thanks.

:+1:

+1

http://bower.io/docs/creating-packages/#register

Done!

:+1:


Remove and update stale configurations

Changes Made
This adds a section to the documentation listing several related projects. Additionally, this makes some minor fixes that I didn't particularly feel like adding issues for/splitting into new PRs, including:

Updating the .vscode configurations to use rolling instead of iron
Fixing the documentation issue template
Removing a stale branch from the documentation CI pipeline
Updated the npm dependencies

Associated Issues

Fixes #232

Testing
Tested locally

@amarburg do you have/know of any projects that might be worth listing here? I was considering adding raven.

This isn't a high-priority PR. Going to wait until the other PRs have been merged before adding this.

I'm going to split off the configuration changes into their own PR


[Bug] Wait time countdown doesn't seem to handle >1hr times

We have wait time set to 1200 minutes (20 hours); but in game it starts countdown at 1hr:
https://cdn.discordapp.com/attachments/744022608554492034/836268714591518820/2021-04-26_16_27_18-Space_Engineers.jpg
With the 1hr resetting each time you relog; until you get into the final hour

I blame @lumbyjack  and his time commit

(But i did fix it in latest commit)


Bpd featured image resizing

Issue Link 🔗:
Issue: #[Issue_Number]
#538
Type of Change

[ ] Bug fix 🐞
[x ] New feature/page
[ ] Documentation update
[ ] Other

Description 📋
Resized featured images
I modified the featured image class and set the max height and max width with to be the same as bpd_featured_image that Tim suggested
Checklist ✅

[ x] Followed the Code of Conduct and Contribution Guide
[x ] Ran pre-commit run --all
[x ] All tests pass locally
[x ] Added tests (if applicable)
[ ] Documentation updated (if applicable)

Additional Notes & Screenshots
Add any additional notes or comments that might be helpful for the reviewers.

@JohananOppongAmoateng if you can expand on your description to have a little more information as to what you chose to do in order to resolve this issue.

@kjaymiller is it better now

Yes it is, however I'm looking at the changed files and I'm not seeing any differences in the files? Did you somehow overwrite your changes when you merged gh-pages?


Work towards updating Kuma to Python 3

User story
As an MDN developer, I want Kuma to run under Python 3, so it's on a current Python release and ready for Django 2.2.
Acceptance criteria
Time-box the work towards this goal to 5 ideal days.
Tasks
Continue working on the tasks outlined in this issue's epic.

It's important to note that the reason for doing this is not that just 2.7 is dying, but that 2.7 will no longer be supported as of Jan 1. 2020. This means bugs will no longer be fixed, and dependent libs may/will drop support, and most importantly security vulnerabilities will no longer be tended to.
For more info:
https://pythonclock.org/
https://www.anaconda.com/end-of-life-eol-for-python-2-7-is-coming-are-you-ready/


Client Runs Filter Status

:nut_and_bolt: Description
Adding status filters to Client Runs the search bar. Now multiple statuses can be selected at the same time. Multiple statuses can only be selected by using the search bar. Only one of the status can be selected using the status buttons above the node list.
:athletic_shoe: Demo Script / Repro Steps

build components/ingest-service && build components/config-mgmt-service && build components/automate-ui
start_all_services
chef_load_nodes 10
Open https://a2-dev.test/client-runs?status=success&status=failure

:chains: Related Resources
https://github.com/chef/automate/issues/398
:white_check_mark: Checklist

[x] Necessary tests added/updated?
[ ] Necessary docs added/updated?
[x] Code actually executed?
[x] Vetting performed (unit tests, lint, etc.)?

thank you for doing this work!
i haven't reviewed yet, will shortly, but it sounds like we should chat with ux first to make sure this is in line with what they're thinking.
for background, this came from a customer request, and we will also need status filtering in compliance reporting.
let's chat with ux sometime over the next couple days, i'll see if i can get a mtg on the calendar

I jumped the gun on this PR. The UI has not been decided yet.


Image and content overlapped

In the group feed section, Image and content got sometimes overlapped! check image attahced

Oh yeah, thank you @aboullaite. I'll fix that soon.

PR to fix this issue, wait until it has been merged and deployed https://github.com/hellowin/kanca/pull/150

It's already deployed @aboullaite. I'll close this issue. Feel free to re-open it if you still found related bug.


Add Japanese translations

I'd like to think about the best way to provide translations for the users on this PR.

index.md (Original English document)
index.ja.md (Japanese translation)

Is this make sense? index.ja-JP.md is better? (it's the way in react.js)
Any feedback is welcome.

I don't know if this makes sense in the official riot repo because you are the only one at moment who could maintain this file, and on any possible router API change this could be a problem. But I would like also to know what @tipiirai thinks about it

I also do!
I will support the Japanese translation.

Nice！ I want to support the Javapanese  translation！

I think translations should reside on a dedicated folder. So ja/index.md would be the home page and so on. This would make cuter URLs and linking between the pages.
Great to see interest on (Japanese) translations!

OH.... hold on. Just realized that we aren't talking about the website repository :)
But anyway – I think a separate folder makes more sense here as well.

@narikei @srockstyle I'm happy to hear that :)
@tipiirai Thanks for your feedback. Like this?
riot/riot.github.io
- index.md
- guide/
  - router.md <---- riot/router/doc/index.md
- api/
  - router.md <---- riot/router/doc/api.md
- ja/
  - index.md
  - guide/
    - router.md <---- riot/router/doc/ja/index.md
  - api/
    - router.md <---- riot/router/doc/ja/api.md

riot/router
- doc/
  - index.md
  - api.md
  - ja/
    - index.md
    - api.md

Yes. That makes sense to me.

OK, done. Could you pls merge it? :-)

Sure. Thanks!


Use an off-screen bitmap for drawing

This will help retain drawings on resize, also allows us to update texts when they change, without losing drawings.

[X] Use an off-screen bitmap as target for drawing operations
[x] Rename _render_target to _canvas
[ ] No need to call InvalidateRect on resize: if size is smaller we really don't need to repaint, if size is larger, WM_PAINT is called automatically.
[ ] Only update the portion of screen that needs re-paint

I think InvalidateRect is needed after resize, because the buffer of screen render target is lost after calling resize method, which means we have to copy the whole buffer into it.


Create Exercism.gitignore

Used to ignoring sensitive data for Exercism users,
Reasons for making this change:
Add .gitignore support for Exercism
Links to documentation supporting these rule changes:
Exercism
If this is a new template:

Link to application or project’s homepage: Exercism

@fybwid apologies for the delay in replying to this.
I had a lot of these templates requested, but I couldn't quite figure out the right place for them. I ended up settling on #2857, and the Exercism template now lives at community/Exercism.gitignore.
Feel free to add any further changes there, and thanks again for the contribution!


utils: add SPDX module

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew tests with your changes locally?

Adds two new functions:

SPDX.spdx_data - returns the parsed JSON of Library/Homebrew/data/spdx.json
SPDX.update_license_data - updates Library/Homebrew/data/spdx.json to latest

Replaces the two uses of HOMEBREW_LIBRARY_PATH/"data/spdx.json" with SPDX.SPDX_PATH
Allows for use of SPDX data in external scripts, for example in brew irb:

irb(main):001:0> require "utils/spdx"
=> true
irb(main):002:0> SPDX.spdx_data["licenses"][0]["licenseId"]
=> "0BSD"

Thoughts on adding a few unit tests?

I'm not quite sure what to test; I guess we could validate the contents of SPDX.spdx_data

Just some very basic functionality would be useful. Even a single unit test per method would be nice.

Should download_latest_license_data! have a test? I'm not sure how to test a method that downloads a file (Is downloading files okay for tests?)
I need to get around to reading all of the docs

Should download_latest_license_data! have a test? I'm not sure how to test a method that downloads a file (Is downloading files okay for tests?)

You could modify download_latest_license_data! to pass an optional download location parameter, that the test spec passes so that it gets downloaded to the right place. Then you can do additional checks on the downloaded file to ensure it matches our assumptions.

have a test? I'm not sure how to test a method that downloads a file (Is downloading files okay for tests?)

It's ok for --online tests. See the :needs_network test tag.

Nice cleanup, thanks @SeekingMeaning!

Looks like this is broken in the recent Actions runs:
==> Updating SPDX license data...
==> git add
Error: undefined local variable or method `latest_tag' for Homebrew:Module
Please report this issue:
==> git commit
  https://docs.brew.sh/Troubleshooting
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/update-license-data.rb:38:in `update_license_data'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:112:in `<main>'


Report on missing data[type] as such

Passing in a payload with data: %{attributes: %{}} would result in an error message stating that attributes was missing from data, when in fact what was missing was type. This corrects that.

@kbaird nice catch. Keep 'em comin'!


Cannot verify contracts with blacksmith and forge script

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (e9f274d 2022-12-11T00:04:59.790449Z)
What command(s) is the bug in?
script
Operating System
macOS (Apple Silicon)
Describe the bug
Trying out blacksmith, the tutorial suggests using forge create, which works. But verification with forge script fails silently.
To reproduce:

Run a blacksmith and an anvil server
forge init test_verify_fail && cd test_verify_fail
Modify CounterScript to deploy the Counter contract
forge script CounterScript --verify --unlocked --sender 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 --rpc-url http://localhost:8545 --verifier-url http://localhost:3000/api/verify --etherscan-api-key blacksmith --broadcast
The tx is broadcast but no verification occurs.

Note that the following does verify correctly: forge create src/Counter.sol:Counter --verify --unlocked --from 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 --rpc-url http://localhost:8545 --verifier-url http://localhost:3000/api/verify --etherscan-api-key blacksmith

To provide some additional context here–blacksmith relies on the --verifier-url flag of forge create in order to provide a custom route (e.g. http://localhost:3000/api/verify) that accepts the contract source code, compiles it, and stores the ABI (which is used to render contract inputs in the application).
At a cursory glance of the forge script code, it seems that clap accepts all of the VerifierArgs defined in cli/src/cmd/forge/verify/mod.rs, but the verifier_url doesn't seem to be used by forge script like it is when verifying with forge create.
I suspect that this isn't just an issue with Blacksmith, but that forge script doesn't fully support custom verifier urls.
Also, I believe the label here should be updated to Cmd-forge-script, and Cmd-forge-create should be removed.

I believe I may have found a workaround for this. While trying to write some custom logic to get this to work with foundry scripting I found that if you run anvil and fork mainnet and then run your script command on that forked network it seems to verify successfully. As a reference here is the command with flags.
anvil --fork-url $MAINNET_RPC
forge script script/Test.s.sol:TestScript --fork-url http://localhost:8545 --verifier-url http://localhost:3000/api/verify --etherscan-api-key blacksmith --broadcast --verify -vvvv
The UI does seem to work as well but havent done a lot of testing.

cli/src/cmd/forge/verify/mod.rs, but the verifier_url doesn't seem to be used by forge script

thanks for this.
I'll start with fixing this asap and then see what else needs fixing.
sorry for the delay everyone.


Update Liberica to 22

https://github.com/bell-sw/Liberica/releases/tag/22.0.2%2B11
Thanks.

At this time, we are only maintaining the LTS versions. If we start doing every version, it'll get extremely cumbersome.
It is in the roadmap to standardize all versions and perhaps soon after, we can have one come out for every version. Until then, just the LTS.


Pass the path route argument to the handler

My actions before raising this issue

[x] Followed the troubleshooting guide
[x] Read/searched the docs
[x] Searched past issues

I'd like to suggest passing the path argument to the handler as a second argument, as it would prove quite valuable to my application
I'm not really familiar with Flask however and I might be able to access the argument already via a property on the request object. If that's the case, please let me know!
Context

The function I'm developing returns a list of attributes for a username. I think the natural implementation would be to make a GET request to /username. It would be great if I could reuse it

The path should already be on the request object, request.path
https://flask.palletsprojects.com/en/1.1.x/api/#incoming-request-data
For example:
➜  test-flask-tmpl-32 curl localhost:8080/here/i/am
/here/i/am

and my handler looks like
from flask import request

def handle(req):
    """handle a request to the function
    Args:
        req (str): request body
    """

    return request.path

Yes, but it isn't parsed.

What do you mean by parsed?

Well, if the route is /username, then the value of path (the function argument, not the property on request) will only be username and not /username

Perhaps you could share anymore concrete example of what you want to do? Even if we passed the path as a second value, it would just be the same value as request.path.
What additional parsing should it do? Perhaps there is an alternative template for your use case or you can simply fork the template to add your additions? You can specify a fork or a template pretty easily in the stack yaml https://docs.openfaas.com/reference/yaml/#templates

@NicolaiSchmid i think parsing the path is outside the scope of this template. The path is easily accessible, as shown above.
I would recommend possibly forking and adding the required parsing into a custom template


suppress more warnings in browser_only ppx

Some warnings are currently suppressed, but in some usages, they still fire, due to either a extra missing warning, the incorrect type for the expression, or not a wide enough location (such as taking the full function definition into account including unused arguments). This prevents enabling strict warnings or requires annotating code to suppress them.
I put up a pr to fix some of them: https://github.com/ml-in-barcelona/server-reason-react/pull/55.
There is another case that could perhaps be improved, where a hook is defined, but only read from the js side. Perhaps in this case, let%browser_only could leave the expression as is and simply add an unused warning suppression instead of failing with browser only works on expressions or function definitions.

Can you give an example of the hook example?

Sure: Define a useState hook. Provide its state as the value of an input (which will be used by native on first render). Only use the setter in a browser_only callback like onClick, causing native to warn of the setter being unused.
let (username, setUsername) = React.useSstate(() => "");
...
<input
  value={username}
  onClick=[%browser_only { e => setUsername(...)}] />

Right, in your example onClick won't be called on the server, so no need to add browser_only.
Allow browser_only to not fail is an interesting idea to supress warnings but unsure how it will look like (maybe adding a warning on the compilation might make more sense than failing at runtime?)

Another case I've hit a bit is input params in hooks that use browser_only behavior internally, but provide an immediate result on first render. I modified the ppx to do what I suggested to try it. Here's another example that change works, but I still have to use underscores for parameters to avoid unused warnings:
let useScrollToEnd = _inputs => {
  let domRef = React.useRef(Js.Nullable.null);
  let%browser_only () =
    React.useEffect1(
      () => {
        ref.current
        |> Js.Nullable.toOption
        |> Option.iter(
             Webapi.Dom.Element.scrollIntoViewWithOptions({
               "behavior": "smooth",
               "block": "end",
             }),
           );
        None;
      },
      _inputs,
    );
  domRef;
};

Right... browser_only for effects doesn't feel right. Probably making [%effect] better might make more sense here.
I'm open to discover how it would work and let the user know that there's something broken if you run it on the server (in this case effects won't but other code might)


[FR] Add Alternative Checkboxes toggle in Style Settings

This request comes as part of the initiative I am involved in for Obsidian October 2024. Additional information and progress on this project can be found here: https://github.com/damiankorcz/Alternative-Checkboxes-Reference-Set
The current goal is to make it easier for users to implement their own CSS Snippets with Alternative Checkboxes, regardless of the theme they use. At the moment, any theme that doesn't present an option to disable their Alternative Checkboxes implementation, requires the snippet to overwrite the existing theme's code. This can become complicated and hard to maintain as currently 44 themes implement Alternative Checkboxes. Ideally, if all themes have the option to disable their implementation, the snippets can be simpler, and work universally across all themes.
If this is something you are interested in implementing, it would require the following code to be added to your theme:
body.enable-alternative-checkboxes {

/* Encapsulate all code relevant to Alternative Checkboxes here */

}

Add a toggle in the Style Settings code:
-
    id: enable-alternative-checkboxes
    title: Enable Alternative Checkboxes
    description: Disable this if you are using your own implementation via a CSS Snippet.
    default: true
    type: class-toggle
-

Since your theme already implements the feature, the code above enables it by default, in order to not change the existing functionality for users.
When the theme implementation is disabled, all additional checkboxes should be styled the same as the default - [x] checked checkbox; removing any changes to color, icons, fonts, backgrounds, etc.
If you need any help implementing this, let me know! I can also look into making a Pull Request if you would prefer.

Hey! Of course I'm interested in implementing it, I think it's an amazing initiative.
I'll test it and let you know when it's already implemented over here, probably in version 1.0.2.
Thanks for the request!