Store social media links for Safe Apps

Is your feature request related to a problem? Please describe.
As a part of improving the discoverability of Safe Apps, we want to have links to app's websites and social media platofrms.
Provide references to the feature you are implementing that requires this change

Problem statement
Figma

Describe the solution you'd like
The safe apps model would have an array of social links with an URL and link type
Describe alternatives you've considered
Fetching them from coingecko/coinmarketcap/etc
Additional context
I'm willing to work on this problem myself :)

Please wait for prioritization meeting results before committing to the implementation.

The safe apps model would have an array of social links with an URL and link type

Do we want to target specific social links or do we want to have a generic collection of social media links? Do they have an icon? (I can't open the Figma link)

The safe apps model would have an array of features similar to features on chain model

Can you give an example of what these features represent?

I would consider splitting this ticket into two. I don't think they are related to each other right? One for media links and the other for features.

Do we want to target specific social links or do we want to have a generic collection of social media links? Do they have an icon? (I can't open the Figma link)

This is how it looks. We want to link application's social media platform such as twitter, github, discord, landing page, etc

Can you give an example of what these features represent?

Right now the only feature the app can enable is batched transactions. Perhaps it can be a simple boolean field on the apps model, but i think an array with features is a more long-term solution

I would consider splitting this ticket into two. I don't think they are related to each other right? One for media links and the other for features.

Correct, they're unrelated but since they both seemed small and straightforward I included both here. I can create a separate ticket for features if you say it's better

Do we want to target specific social links or do we want to have a generic collection of social media links? Do they have an icon? (I can't open the Figma link)

This is how it looks. We want to link application's social media platform such as twitter, github, discord, landing page, etc

Given the image here it seems like the following:

Each app only has one website. I would just add a single field for this one on the SafeApp level
Each app can have multiple social media links

Here we can either have the resource of the each social media on the Safe Config Service OR
Have a type of social media eg.: DISCORD | TWITTER | GITHUB etc..
A new table with all the social media links (I think having this tied to the SafeApp table can be more confusing but we can also consider this option).

This new "social links" table would be something like SAFE APP ID | SOCIAL MEDIA TYPE | SOCIAL MEDIA URL

Can you give an example of what these features represent?

Right now the only feature an app can enable is batched transactions. Perhaps it can be a simple boolean field on the apps model, but i think an array with features is a more long-term solution

I think we can work on the long-term solution now because it seems easy enough to accomplish this and we don't need to migrate this data to a new format later on. The feature itself looks like it's going to be used for different types so I'd assume that from the get go.

I would consider splitting this ticket into two. I don't think they are related to each other right? One for media links and the other for features.

Correct, they're unrelated but since they both seemed small and straightforward I included both here. I can create a separate ticket for features if you say it's better

I think it makes it easier to track the development of each one (since one can happen without the other technically) 😉

Can you give an example of what these features represent?

Right now the only feature an app can enable is batched transactions. Perhaps it can be a simple boolean field on the apps model, but i think an array with features is a more long-term solution

I think we can work on the long-term solution now because it seems easy enough to accomplish this and we don't need to migrate this data to a new format later on. The feature itself looks like it's going to be used for different types so I'd assume that from the get go.

I would consider splitting this ticket into two. I don't think they are related to each other right? One for media links and the other for features.

Correct, they're unrelated but since they both seemed small and straightforward I included both here. I can create a separate ticket for features if you say it's better

I think it makes it easier to track the development of each one (since one can happen without the other technically) 😉

Features are now tracked here https://github.com/safe-global/safe-config-service/issues/755

Do we want to target specific social links or do we want to have a generic collection of social media links? Do they have an icon? (I can't open the Figma link)

This is how it looks. We want to link application's social media platform such as twitter, github, discord, landing page, etc

Given the image here it seems like the following:

Each app only has one website. I would just add a single field for this one on the SafeApp level

Each app can have multiple social media links

Here we can either have the resource of the each social media on the Safe Config Service OR

Have a type of social media eg.: DISCORD | TWITTER | GITHUB etc..

A new table with all the social media links (I think having this tied to the SafeApp table can be more confusing but we can also consider this option).

This new "social links" table would be something like SAFE APP ID | SOCIAL MEDIA TYPE | SOCIAL MEDIA URL

Wdyt?

Sounds good to me. This is a similar approach to what I've been envisioning: https://stackoverflow.com/questions/48755827/how-to-store-social-usernames-links-in-django

@mikhailxyz This can be closed right (as the feature was merged)?

yes, thanks for the reminder @fmrsabino


Adding support for PMA 5.1 and up

Changes in this PR:

configurable support for old and new URL format
removed check for PMA cookies existance as it's no longer needed (plugin should be activated only on vhosts where PMA is running, not globally)
renumbering IDs (as a consequnce of changes above)

Any reviewers / testers?

@williamdes Currently no, have you encountered any problems with that endpoints while using CRS? False positives or so.

Any reviewers / testers?

I have not heavy-tested it, however, the basic usage of PMA 7 does not give false positives anymore.
Thank you!

@azurit PMA 5.2.0

@azurit I was testing some configs and decided to try PMA setup feature. I found some false positives on the setup "export" page with URL /setup/index.php?page=form&formset=Export. The same for  "import" and "Main Panel" pages.
Just clicking the "Apply" button in these pages gives the false positive.

@WaleedMortaja Can you, please, upload logs from ModSecurity?

@WaleedMortaja Can you try current version? Thank you.

@williamdes As you wished, now we have few rules also for /setup/ folder. :)

@WaleedMortaja Can you try current version? Thank you.

@azurit It still has false postivies. I tried the setup's "export" page only, and got this log.
Note: some of the log is truncated or replaced with placeholders indicated by ##
Please inform me if there is a better way to provide the log.
For now, here is the log for "export":
--##PLACEHOLDER##-C--
##truncated##&Export-csv_separator=%2C&Export-csv_separator-userprefs-allow=on&Export-csv_enclosed=%22&Export-csv_enclosed-userprefs-allow=on&Export-csv_escaped=%22&Export-csv_escaped-userprefs-allow=on&Export-csv_terminated=AUTO&Export-csv_terminated-userprefs-allow=on&Export-csv_null=NULL&Export-csv_null-userprefs-allow=on&Export-csv_removeCRLF-userprefs-allow=on&Export-csv_columns-userprefs-allow=on&##truncated##
--##PLACEHOLDER##-F--
HTTP/1.1 403 Forbidden
Content-Length: 199
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Content-Type: text/html; charset=iso-8859-1

--##PLACEHOLDER##-E--

--##PLACEHOLDER##-H--
Message: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_separator. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_separator: export-csv_separator"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_separator-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_separator-userprefs-allow: export-csv_separator-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_enclosed. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_enclosed: export-csv_enclosed"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_enclosed-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_enclosed-userprefs-allow: export-csv_enclosed-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_escaped. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_escaped: export-csv_escaped"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_escaped-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_escaped-userprefs-allow: export-csv_escaped-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_terminated. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_terminated: export-csv_terminated"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_terminated-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_terminated-userprefs-allow: export-csv_terminated-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_null. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_null: export-csv_null"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_null-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_null-userprefs-allow: export-csv_null-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_removeCRLF-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_removeCRLF-userprefs-allow: export-csv_removecrlf-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_columns-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_columns-userprefs-allow: export-csv_columns-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Access denied with code 403 (phase 2). Operator GE matched 5 at TX:anomaly_score. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-949-BLOCKING-EVALUATION.conf"] [line "93"] [id "949110"] [msg "Inbound Anomaly Score Exceeded (Total Score: 63)"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-generic"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client ##SRC_IP_PALACEHOLDER##] ModSecurity: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_separator. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_separator: export-csv_separator"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "##SERVER_IP_PALACEHOLDER##"] [uri "/##PMA_LOCATION_PLACEHOLDER##/setup/index.php"] [unique_id "##UNIQUE_ID_PALCEHOLDER##"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client ##SRC_IP_PALACEHOLDER##] ModSecurity: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_separator-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_separator-userprefs-allow: export-csv_separator-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "##SERVER_IP_PALACEHOLDER##"] [uri "/##PMA_LOCATION_PLACEHOLDER##/setup/index.php"] [unique_id "##UNIQUE_ID_PALCEHOLDER##"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client ##SRC_IP_PALACEHOLDER##] ModSecurity: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_enclosed. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_enclosed: export-csv_enclosed"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "##SERVER_IP_PALACEHOLDER##"] [uri "/##PMA_LOCATION_PLACEHOLDER##/setup/index.php"] [unique_id "##UNIQUE_ID_PALCEHOLDER##"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client ##SRC_IP_PALACEHOLDER##] ModSecurity: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_enclosed-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_enclosed-userprefs-allow: export-csv_enclosed-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "##SERVER_IP_PALACEHOLDER##"] [uri "/##PMA_LOCATION_PLACEHOLDER##/setup/index.php"] [unique_id "##UNIQUE_ID_PALCEHOLDER##"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client ##SRC_IP_PALACEHOLDER##] ModSecurity: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_escaped. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_escaped: export-csv_escaped"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "##SERVER_IP_PALACEHOLDER##"] [uri "/##PMA_LOCATION_PLACEHOLDER##/setup/index.php"] [unique_id "##UNIQUE_ID_PALCEHOLDER##"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client ##SRC_IP_PALACEHOLDER##] ModSecurity: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_escaped-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_escaped-userprefs-allow: export-csv_escaped-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "##SERVER_IP_PALACEHOLDER##"] [uri "/##PMA_LOCATION_PLACEHOLDER##/setup/index.php"] [unique_id "##UNIQUE_ID_PALCEHOLDER##"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client ##SRC_IP_PALACEHOLDER##] ModSecurity: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_terminated. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_terminated: export-csv_terminated"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "##SERVER_IP_PALACEHOLDER##"] [uri "/##PMA_LOCATION_PLACEHOLDER##/setup/index.php"] [unique_id "##UNIQUE_ID_PALCEHOLDER##"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client ##SRC_IP_PALACEHOLDER##] ModSecurity: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_terminated-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_terminated-userprefs-allow: export-csv_terminated-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "##SERVER_IP_PALACEHOLDER##"] [uri "/##PMA_LOCATION_PLACEHOLDER##/setup/index.php"] [unique_id "##UNIQUE_ID_PALCEHOLDER##"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client ##SRC_IP_PALACEHOLDER##] ModSecurity: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_null. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_null: export-csv_null"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "##SERVER_IP_PALACEHOLDER##"] [uri "/##PMA_LOCATION_PLACEHOLDER##/setup/index.php"] [unique_id "##UNIQUE_ID_PALCEHOLDER##"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client ##SRC_IP_PALACEHOLDER##] ModSecurity: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_null-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_null-userprefs-allow: export-csv_null-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "##SERVER_IP_PALACEHOLDER##"] [uri "/##PMA_LOCATION_PLACEHOLDER##/setup/index.php"] [unique_id "##UNIQUE_ID_PALCEHOLDER##"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client ##SRC_IP_PALACEHOLDER##] ModSecurity: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_removeCRLF-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_removeCRLF-userprefs-allow: export-csv_removecrlf-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "##SERVER_IP_PALACEHOLDER##"] [uri "/##PMA_LOCATION_PLACEHOLDER##/setup/index.php"] [unique_id "##UNIQUE_ID_PALCEHOLDER##"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client ##SRC_IP_PALACEHOLDER##] ModSecurity: Warning. Matched phrase "Export-CSV" at ARGS_NAMES:Export-csv_columns-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Export-CSV found within ARGS_NAMES:Export-csv_columns-userprefs-allow: export-csv_columns-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "##SERVER_IP_PALACEHOLDER##"] [uri "/##PMA_LOCATION_PLACEHOLDER##/setup/index.php"] [unique_id "##UNIQUE_ID_PALCEHOLDER##"]

@WaleedMortaja Thanks! Can you try it with current version?

@azurit the setup/export is working now!
The other pages still has problems.
Here is the log for setup/import (URL: /setup/index.php?page=form&formset=Import)
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_replace-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_replace-userprefs-allow: import-csv_replace-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_ignore-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_ignore-userprefs-allow: import-csv_ignore-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_terminated. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_terminated: import-csv_terminated"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_terminated-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_terminated-userprefs-allow: import-csv_terminated-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_enclosed. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_enclosed: import-csv_enclosed"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_enclosed-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_enclosed-userprefs-allow: import-csv_enclosed-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_escaped. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_escaped: import-csv_escaped"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_escaped-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_escaped-userprefs-allow: import-csv_escaped-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_col_names-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_col_names-userprefs-allow: import-csv_col_names-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]

Here is the log for setup/Main Panel (URL: phpmyadmin/setup/index.php?page=form&formset=Main)
Message: Warning. Matched phrase "dev/null" at ARGS:DefaultTransformations-External. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "500"] [id "932160"] [msg "Remote Command Execution: Unix Shell Code Found"] [data "Matched Data: dev/null found within ARGS:DefaultTransformations-External: 0 -f/dev/null -i -wrap -q 1 1"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "platform-unix"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]

@azurit the setup/export is working now!
The other pages still has problems.
Here is the log for setup/import (URL: /setup/index.php?page=form&formset=Import)
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_replace-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_replace-userprefs-allow: import-csv_replace-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_ignore-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_ignore-userprefs-allow: import-csv_ignore-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_terminated. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_terminated: import-csv_terminated"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_terminated-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_terminated-userprefs-allow: import-csv_terminated-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_enclosed. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_enclosed: import-csv_enclosed"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_enclosed-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_enclosed-userprefs-allow: import-csv_enclosed-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_escaped. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_escaped: import-csv_escaped"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_escaped-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_escaped-userprefs-allow: import-csv_escaped-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]
Message: Warning. Matched phrase "Import-CSV" at ARGS_NAMES:Import-csv_col_names-userprefs-allow. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "329"] [id "932120"] [msg "Remote Command Execution: Windows PowerShell Command Found"] [data "Matched Data: Import-CSV found within ARGS_NAMES:Import-csv_col_names-userprefs-allow: import-csv_col_names-userprefs-allow"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "language-powershell"] [tag "platform-windows"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]

Here is the log for setup/Main Panel (URL: /setup/index.php?page=form&formset=Main)
Message: Warning. Matched phrase "dev/null" at ARGS:DefaultTransformations-External. [file "/etc/httpd/modsecurity.d/activated_rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "500"] [id "932160"] [msg "Remote Command Execution: Unix Shell Code Found"] [data "Matched Data: dev/null found within ARGS:DefaultTransformations-External: 0 -f/dev/null -i -wrap -q 1 1"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.0"] [tag "application-multi"] [tag "language-shell"] [tag "platform-unix"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"]

@azurit All the setup pages are working now.
I am not aware of any more FP currently.
Thank you for your efforts 😄

@WaleedMortaja Thank you very much for testing!

@williamdes pls what's difference between routes /database/export and /export?

@williamdes pls what's difference between routes /database/export and /export?

https://github.com/phpmyadmin/phpmyadmin/blob/f6a03d405d5c4d4ad6e356ed654917a79418207c/libraries/routes.php#L63
https://github.com/phpmyadmin/phpmyadmin/blob/f6a03d405d5c4d4ad6e356ed654917a79418207c/libraries/routes.php#L216
It seems that one is more for tables and the other for databases
I am not sure there is much different code between them
Do you need some deeper information on those routes?

It seems that one is more for tables and the other for databases

For tables, there seems to be /table/export route.

Do you need some deeper information on those routes?

No, i just need to know if i should:

add this route for database export rule
add this route for table export rule
create completely new rule

It's more or less a philosophical question. :)

It seems that one is more for tables and the other for databases

For tables, there seems to be a /table/export route.

Do you need some deeper information on those routes?

No, i just need to know if i should:
* add this route for database export rule

* add this route for table export rule

* create completely new rule

It's more or less a philosophical question. :)

@MauricioFauth you created the controllers, maybe you could better answer this question?
But I would say that since it is not prefixed it could be used in different ways, so maybe a new rule?

@williamdes pls what's difference between routes /database/export and /export?

Initially the routes were a direct map with the files. For example:

db_export.php => /database/export

db_export.php => /database/export

@MauricioFauth Thanks, that helped a lot!
@MauricioFauth @williamdes What about this? What action it was?
POST /index.php?route=/

=== POST ARGUMENTS ===
ajax_request: true
server: 3
db: information_schema
guid: <censored>
access_time: 414
check_timeout: 1
_nocache: <censored>
token: <censored>

@MauricioFauth Thanks, that helped a lot!
@MauricioFauth @williamdes What about this? What action it was?
POST /index.php?route=/

=== POST ARGUMENTS ===
ajax_request: true
server: 3
db: information_schema
guid: <censored>
access_time: 414
check_timeout: 1
_nocache: <censored>
token: <censored>

I guess it's the ping pong to check if the session expired?

Hi @azurit
We started development of 6.0 instead of 5.3. One breaking change is that we will have everything from 5.2 rules in a public directory

@williamdes Thanks for the info!
To all: New URL format can be considered as tested.

Awesome, could you provide me a docker-compose.yml so I can test it ?

Awesome, could you provide me a docker-compose.yml so I can test it ?

@williamdes Unfortunately i'm not able to do so. @fzipi Can you, maybe, help?

Just in case, please use Squash and merge here.

@azurit To the best of my knowledge, I think I've fixed the conflict. Let me know if this is ready before merging.

@fzipi Thank you! Should be ready to merge.


Test results list card container overlays "User" sub-menu

Description
#3661 updated the main card container for the test results list to have a sticky position and a positive z-index. As a result, the "User" sub-menu disappears behind the container when clicked:
https://images.zenhubusercontent.com/302387839/215f3690-3d6a-4850-9760-5a89c0bf5eec/screen_recording_2022_08_10_at_4_57_44_pm.mov
Expected behavior
The sub-menu should be fully visible and overlay the card container
Additional context
Please familiarize yourself with the #3661 ticket that introduced this issue - presumably these changes happened for a reason, so any fix should respect the aims of the original ticket

Fixed by @zdeveloper


Add Exalted to the preset configs

Adds the world from White Wolf's "Exalted" to the preset configs

Codecov Report
Patch and project coverage have no change.

Comparison is base (b052f8a) 100.00% compared to head (d6e8f1b) 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##              main      #477   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           75        75
  Lines         7252      7252
  Branches      2110      2110
=========================================
  Hits          7252      7252

Flag
Coverage Δ

unittests
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Return client from ReinvokeRequestOnMultipleServersAsync

Summary of the changes

In order to know which client to ReInvoke against results must return the client that they came from along with it. The part you'll need is just t.LanguageClient.Name.

Fixes: https://github.com/dotnet/aspnetcore/issues/34237
CC @ToddGrun who requested this change. Good eye, this scenario definitely needed some work.
@allisonchou  and @TanayParikh, what do you think of the CodeActions parts? Should we start returning the ClientName somehow so we can only make requests against the correct server? I wasn't sure how to accomplish that so I punted a little bit,  but if  y'all have advice I'm open.

    public abstract Task<TOut> ReinvokeRequestOnServerAsync<TIn, TOut>(

Just making sure we don't want to reutrn the languageclient here for consistency sake. We shouldn't need it now, but it might be nice to have it.

Refers to: src/Razor/src/Microsoft.VisualStudio.LanguageServer.ContainedLanguage/LSPRequestInvoker.cs:22 in d587c0e. [](commit_id = d587c0e642b2aeb0eff8ac354c045ca1619dd5cd, deletion_comment = False)

        string contentType,

Not part of this PR, but why do we need to pass this in if we're already sending you the language server name? Seems like vslanguageserverclient should be able to find the appropriate client just by it's name, no?

Refers to: src/Razor/src/Microsoft.VisualStudio.LanguageServer.ContainedLanguage/LSPRequestInvoker.cs:25 in d587c0e. [](commit_id = d587c0e642b2aeb0eff8ac354c045ca1619dd5cd, deletion_comment = False)

        string contentType,

Not part of this PR, but why do we need to pass this in if we're already sending you the language server name? Seems like vslanguageserverclient should be able to find the appropriate client just by it's name, no?

I considered removing contentType, but my thought was that we wanted to leave the contentType there as an additional guard in case someone specifies a ClientName that doesn't match their expectations. I could remove it if people think that's excessively defensive, but I would argue to keep the capabilitiesFilter it also takes because even the client you specified might not have registered all its capabilities yet.

I think it would be more clear if the contenttype wasn't passed in, as then I at least understand what you are using to find the client. As for the capabilitiesFilter, I think it makes sense to keep it.

In reply to: 877453781

Just making sure we don't want to reutrn the languageclient here for consistency sake. We shouldn't need it now, but it might be nice to have it.

Good point, I was trying to minimize the changes, but if it's wrong for this case it's likely wrong in the other case too, and it doesn't hurt anything for them to not use the client.

what do you think of the CodeActions parts? Should we start returning the ClientName somehow so we can only make requests against the correct server? I wasn't sure how to accomplish that so I punted a little bit, but if y'all have advice I'm open.

Looks good to me.
You could do it by augmenting the VSCodeAction.Data payload with the name of the language server (in the code action provider). Then when resolving the code action, inspect and extract that server name/type and dispatch accordingly.
Whether or not you should do it is another question. Aside from the additional complexity introduced, I'm not sure the amount of perf benefits it would give us. Perhaps VS LSP already does some caching of code actions to route resolution efficiently?

:up::date:


Adding GPU support

Description
Can we add a support of GPU? Or has this already been implemented?
Additional Info
No response

This question has been asked millions times, please check existing issues.


po.vim integration

po.vim is a vim ftplugin that eases the work for translators when working with po files (and it's awesome). One of the features is that <LocalLeader>s triggers a call to msgfmt to show stats. Unfortunately 1) you have to call it manually and 2) it puts vim in the background while it displays the output of the command.
It would be super awesome if the stats could be directly displayed in the status line.

is that an expansive call?

I don't know how to measure it, but if you give me pointers I can try.

looks like we would have to call msgfmt --statiscics from a system() function. That will potentially be evaluated a lot, so I'd like to avoid that if possible.

To be fair the stats don't change that often (only when you updated a string status), so it would be ok to update the stats only once in a while. Maybe only on file save?

Please check chrisbra/vim-airline branch po.vim

Excellent, that works great! Thank you so much.

Okay, I'll make a PR for this.


Protocol not specificed

Under 'Configure the edge firewall' -> "... you must open your firewall rules to allow ports 500 and 4500"
TCP, UDP? Please specify.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bbeab4b7-f8d6-59ee-49df-fc4646fcbaea
Version Independent ID: 1fceb417-3029-7b89-f583-560c05a68ad2
Content: Configure DNS and Firewall Settings
Content Source: WindowsServerDocs/remote/remote-access/vpn/always-on-vpn/deploy/vpn-deploy-dns-firewall.md
Product: windows-server-threshold
GitHub Login: @shortpatti
Microsoft Alias: pashort

My bad - upon further inspection, UDP is specified earlier in the section. Please disregard.

Closing.


bash: paddle2onnx: command not found => How to fix it?

Please fill in the information below so that we can solve the problem quickly, Thanks !
Describe the bug
A clear and concise description of what the bug is.
First, install paddle2onnx.

After that, I try to use paddle2onnx, then command not found error occur.
How can I fix it?

Informations (please complete the following information):

Inference engine for deployment:
Why convert to onnx：Need to convert TensorRT.
Paddle2ONNX Version: 1.1.0
Email/Wechat/Phone:

Screenshots
Additional context

Hi @PeterKim1, please check if paddle2onnx is in your environment variables, it is recommended to use paddle2onnx in a virtual environment.

I can reproduce this on my mac with paddle2onnx==1.1.0 installed.
as a workaround, please try: python -mpaddle2onnx.command, paddle2onnx command is kind of shortcut for this module.
BTW: I am confused by the versioning of this package, we have package with version greater than 1.0.7 on pip, see: https://pypi.org/project/paddle2onnx/#history, but the latest tag in the code repository is 1.0.7, anyone knows the reason?


ubuntu12.04， i found it can not be installed on ubuntu12.04

i found it can not be installed on ubuntu12.04

Er... Can you display exhaustive information?

下列软件包有未满足的依赖关系：
mutate : 依赖: fcitx-libs-qt5 但无法安装它
依赖: qt5-qmake 但无法安装它
依赖: qtbase5-dev 但无法安装它
依赖: libqt5x11extras5-dev 但无法安装它
依赖: libboost-regex1.55-dev 但无法安装它
E: 无法修正错误，因为您要求某些软件包保持现状，就是它们破坏了软件包间的依赖关系。

用sudo aptitude install fcitx-libs-qt5试试

ubuntu 12.04 LTS 下安装不了。有些依赖没有可用的源。
$ sudo aptitude install mutate
The following NEW packages will be installed:
  mutate{b}
0 packages upgraded, 1 newly installed, 0 to remove and 430 not upgraded.
Need to get 718 kB of archives. After unpacking 936 kB will be used.
The following packages have unmet dependencies:
 mutate : Depends: fcitx-libs-qt5 which is a virtual package.
          Depends: qt5-qmake but it is not going to be installed.
          Depends: qtbase5-dev but it is not going to be installed.
          Depends: libqt5x11extras5-dev which is a virtual package.
          Depends: libboost-regex1.55-dev which is a virtual package.

I can't install it too.
How to resolve it ?

Now I use ubuntu 14.04 ....


Bug in script UploadSignedReleaseArtifacts.ps1

When github is not logged in it fails silently whereas it should just fail

Fix was merged via an internal PR.


Rust-analyzer unable to open compiled template file

My VSCode's rust-analyzer is reporting an error while attempting to load the output file specified by the derive macro:

I think it's likely that I'm seeing this due to some improper configuration, but I'm not sure where to look. I've verified that the file exists, and this error isn't shown when running cargo clippy.

This happens maybe because rust-analyzer cannot open non .rs files. If you close that file from the editor it stops showing.

I have the same issue, and It seems to be caused by a include! macro in sailfish-compiler, I would've debugged it but unfortunately I don't have time

I am facing this same problem. Is there a way to fix this?
@panda-dev24 what do you mean by "if you close that file from the editor"? And why would that stop showing it?

I am facing this same problem. Is there a way to fix this?
@panda-dev24 what do you mean by "if you close that file from the editor"? And why would that stop showing it?

It seems like it is an issue with rust-analyzer not being able to include non rs files. So if you close the file from the editor, rust analyzer stops complaining.

I posted this on Stack Overflow and the answer was that:

Since sailfish compiles the templates into files without any extension, it is not found by rust-analyzer.

This can be resolved when either sailfish creates and uses .rs files

https://stackoverflow.com/a/78886929/1634905
Can Sailfish create files with .rs extension?

This line
output_file.push(filename_hash(&input_file, &config));

If it is changed to add the .rs extension after the file_hash function call, it will be resolved. But I am not sure the file produced is valid rust.

I am also experiencing this same issue. It would be nice to not have this be a glaring error in my editor (neovim) even if it compiles fine.


Integrate LLVM at llvm/llvm-project@3a8316216807

There are few expected test failures with the latest commit,  updating PR...


[Bug]: Numbers 1--5 on my keyboard don't work TaxonWorks fields

Steps to reproduce the bug
Weirdly, numbers 1 to 5 on my keyboard don't work in TaxonWorks. They work well in other circumstances (including typing in this field now---123456789), but they don't add anything to the various fields in TaxonWorks.

1. Navigate to any field in TaxonWorks (e.g. tasks/nomenclature/new_taxon_name)
2. Put cursor in a field (e.g. "Name")
3. Type "123456789" using the main number keys
...

Screenshot

Expected behavior
I would expect the number "123456789" to appear in the text box
Additional Screenshots
No response
Environment

[X] Development (native)
[ ] Development (docker)
[X] Sandbox
[ ] Production

Sandbox Used
sandfly
Version
build f594ad1d2 / v 0.22.3
Browser Used
firefox

could not replicate. But in the past some people also reported issues with numeric values. Not sure if this a browser issue. Did you try another browser?

Me neither, did you try using other browser @sdjbrown ?

I think I also had this problem with the DwC importer when I was in a Zoom breakroom with @debpaul. Had to refresh the page to be able to type digits in cells.

Replicated

Confirming that this bug has been fixed. Great job, thanks.


TimeoutCommand(int) is not applicable

Hi Paulo, I hope that you are fine.
I'm developing an app in Android Studio 1.4 and I'm using your library (obd-java-api). I have an issue when I created "new TimeoutCommand().run(socket.getInputStream(),socket.getOutputStream());"
Error:(134, 21) error: no suitable constructor found for TimeoutCommand()
constructor TimeoutCommand.TimeoutCommand(TimeoutCommand) is not applicable
(actual and formal argument lists differ in length)
constructor TimeoutCommand.TimeoutCommand(int) is not applicable
(actual and formal argument lists differ in length)
Other configuration was created fine Ej.
new LineFeedOffCommand().run(socket.getInputStream(),socket.getOutputStream());
Please, could you help me with this issue?

The example was not as it should be. It's now fixed.

Hi Paulo,
Many thanks for your quick response.
I have other question.
This is my code in Android Studio.

UUID uuid = UUID.fromString("00001101-0000-1000-8000-00805F9B34FB");
BluetoothSocket socket = null;
BluetoothSocket tempsocket = null;
                                             try {
                                                 socket = device.createInsecureRfcommSocketToServiceRecord(uuid);
                                                 socket.connect();
                                                 Toast.makeText(getApplicationContext(), "Bluetooth conected", Toast.LENGTH_SHORT).show();
                                                 try {
                                                     new EchoOffCommand().run(socket.getInputStream(), socket.getOutputStream());
                                                     new LineFeedOffCommand().run(socket.getInputStream(),socket.getOutputStream());
                                                     new TimeoutCommand(125).run(socket.getInputStream(),socket.getOutputStream());
                                                     new SelectProtocolCommand(ObdProtocols.AUTO).run(socket.getInputStream(),socket.getOutputStream());
                                                     new AmbientAirTemperatureCommand().run(socket.getInputStream(),socket.getOutputStream());
                                                     Toast.makeText(getApplicationContext(),"Finalizó opcion try luego de comando OBD" ,Toast.LENGTH_SHORT).show();

                                                 }catch (Exception ex){
                                                     Toast.makeText(getApplicationContext(),"Message after OBD command" ,Toast.LENGTH_SHORT).show();

                                                 }

                                             } catch (Exception e) {
                                                 // TODO Auto-generated catch block
                                                 e.printStackTrace();
                                                 Toast.makeText(getApplicationContext(), "Bluetooth error", Toast.LENGTH_SHORT).show();

                                             }

I tested in a car and socket connection is fine because I received the messages "Bluetooth conected" and "Message after OBD commands".
but i dont know how to capture for Ex. AmbientAirTemperatureCommand() in order to do math operation,
Any suggestion?
Thanks in advanced.


Support creating intermediate certs

Previously the signing cert was presumed to be itself if the purpose was
creating a CA keypair; this is not true in the case of an intermediate
CA.
The new test fails with the old code and now passes.

+1


Desk.com gem ignores client config?

Hi.
I've experienced something weird, but not necessarily a bug. Perhaps I've misunderstood something...
Anyway, after creating a case and returning the case object into a var I then tried to access the "message" property through the "raw" response like this:
new_case_object = desk.create_case(ticket_hash)
mes = new_case_object.raw.message
where "desk" is my initialized Desk.com client.
The case DOES get created, but the code croaks with this error message:
GET https://example.desk.com/api/v2/cases/3600/message: 401
It seems that when the request goes out for the "message" property somehow the subdomain gets reset or even that my initialized client doesn't get used in the request.
Has anybody else observed this behavior?
Best regards,
Thomas Balsløv.

I haven't seen this happen before, and haven't been able to recreate it. What version of the gem are you using? Are you still seeing the issue?

Hi Chris,
thank you for replying.
I'm using version 1.0.5 of the gem.
I removed this part of the code as it was used to catch 422 errors before the desk.com changed strategy to croak on this error, but before the change I saw this on many occasions if not all (of the 422 incidents).
If you can't replicate this and nobody else get this, then do not bother with it for my sake.
I was just curious if this was something others have run into...
Best regards,
Thomas.


feat: ttid

:scroll: Description

Implement TTID
:bulb: Motivation and Context

Split pr of #1882
:green_heart: How did you test it?
CI, manual test with spotlight
:pencil: Checklist

[x] I reviewed submitted code
[x] I added tests to verify changes
[x] No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
[x] I updated the docs if needed
[ ] All tests passing
[x] No breaking changes

:crystal_ball: Next steps

don't review yet, still need to fix the start timestamps

what about merging SentryDisplayWidget into SentryWidget?
So that if SentryWidget is used in a screen (it shouldn't matter where in the hierarchy) we can collect the TTID on "manual" mode.
This is just a question to open a discussion, we would do it in another PR


[gn] Rename xwalk_installer_package_deb to xwalk_installer_linux_debian

Use the same target name for the gyp and the GN versions, otherwise this
needlessly complicates the release build process and confuses everyone
trying to build Debian packages.
While here, add Chromium's missing copyright to tools/installer/BUILD.gn.
BUG=XWALK-7180

@heke123 fyi

rs=me


add user doc: Change users name

Automated message from Dropbox CLA bot
@anirudhjain75, it looks like you've already signed the Dropbox CLA. Thanks!

merged, thanks @anirudhjain75 and @synicalsyntax


Adding a ButtonType=Literal to HamburgerButtonInfo breaks theme changing

T10 1.1.12. When I add HamburgerButtonInfo to HamburgerMenu, set Literal type to it and add some children elements for example StackPanel with TextBlock and trying to change theme there is exception in AppTheme property's setter of SettingsService - in RefreshStyles method. (An exception of type 'System.InvalidOperationException' occurred in Template10Library.dll but was not handled in user code Additional information: Sequence contains no matching element). Bug?

Not sure, can you set it manually in the element?

Same problem for me. This happens in even in a new created Hamburger template when any buttons ButtonType is set to Literal (right at the button in XAML).

Just encountered the same problem. V 1.1.12
As described above, can repo with a fresh template.


code open source

Hi, Congratulations on this paper being accepted by ICCV2023.
Would it be convenient for you to provide the code so we can follow your work?
Thanks.

+1

+1,too

+1
too

+1
too

May I ask why your ICCV paper, which I read says it has a code link, is not open source?


Webview does not work in built version of VS Code

Because vs/workbench/parts/html/browser/webview.html is missing from the build.

@jrieken fyi

@bpasero I though this is enough

now, I get it. Thanks for fixing

Hm true, weird. Webview works for me after my change.


removing many dynamic schedules at once is not performant

I have a situation where ~80K dynamic jobs were created before we realized that this approach was not going to work (we're using a static schedule now that is much saner). To clean up all of the persisted schedules using the public interface is straightforward:
(Resque.schedule.keys - YAML.load_file("path", "to", "schedule", "file").keys).each do |to_remove|
  Resque.remove_schedule(to_remove)
end

However, this will not only make one hdel call to redis for each key, but will also re-load the entire schedule each time!
I can imagine a simple change to the remove_schedule method that would allow a variable number of schedules to be removed at once:
def remove_schedule(*schedules)
  schedules.each { |schedule| non_persistent_schedules.delete(schedule) }
  redis.hdel(:persistent_schedules, *schedules)
  redis.sadd(:schedules_changed, schedules.first)
  reload_schedule!
end

What do you guys think about that? Happy to make a PR if that makes sense.

actually - it appears that we'd only have to update the schedules_changed set with one entry here. updated my proposal above.

Perhaps a different suggestion. It seems like the root issue here is that there is no story to migrate from dynamic schedules back to a static schedule, if you make the same mistake we did. Instead of the above idea where you can remove many schedules at once, what about purging the entire dynamic schedule:
def purge_dynamic_schedule!
  if !dynamic
    redis.del(:persistent_schedules)
    redis.del(:schedules_changed)
    reload_schedule!
  end
end

this way it's "opt-in": users may wish to drain their dynamic schedules naturally after moving off. but they could optionally just kill the entire

@ledhed2222 Bulk removal is welcome! Purging as well. Good call.

howdy. i'm working on this PR but I'm having trouble passing the test suite. could you provide some insight?
Error: test_concurrent_shutdowns_and_startups_do_not_corrupt_the_schedule(Multi_Process): RuntimeError: forked process failed with pid 43772 SIGABRT (signal 6)
/Users/gregweisbrod/Documents/Dev/resque-scheduler/test/multi_process_test.rb:111:in `block in get_results_from_children'
/Users/gregweisbrod/Documents/Dev/resque-scheduler/test/multi_process_test.rb:108:in `each'
/Users/gregweisbrod/Documents/Dev/resque-scheduler/test/multi_process_test.rb:108:in `get_results_from_children'
/Users/gregweisbrod/Documents/Dev/resque-scheduler/test/multi_process_test.rb:76:in `block (2 levels) in <top (required)>'

there isn't any documentation on your test suite, so even just a few pointers will probably help me here :)
thank you! would love to help get these features in

Bump 😊

https://github.com/resque/resque-scheduler/pull/686

bump ^


chore: update sidecar version to 0.115.0

chore: update sidecar version to 0.115.0

Setting to draft until https://github.com/confluentinc/vscode/pull/778 is merged


Fixed issue with predict in integration with web service

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Please provide enough information so that others can review your pull request:

Fixed loading model issue for web service;
Fixed changes from last PR.

Explain the details for making this change. What existing problem does the pull request solve?
This version work in integration with web service. All found issues were fixed.

This pull request is now managed with CodeReviewHub. Refresh.


npm install fails with io.js

https://github.com/iojs/io.js/issues/456

No problems for me with io.js v1.6.1

:+1:


Add Sonarqube integration endpoints to APIv2

Add the ability to attach sonarqube tool configs to a product, manage issues, and issue transitions.

[x] Your code is flake8 compliant.
[x] Your code is python 3.5 compliant (specific python >=3.6 syntax is currently not accepted).
[ ] If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
[ ] Model changes must include the necessary migrations in the dojo/db_migrations folder.
[x] Add applicable tests to the unit tests.
[x] Add the proper label to categorize your PR.

For API changes it might be good to check if the swagger / openapi thing still generated OK or if some annotations are needed?

It's generated each time the endpoint is called. Appears to be fine to me. What do you think?
swagger.log
Had to convert to a log file to make GitHub happy.


R1.15 BERT optimizations

This includes the GELU op and FMA. Dropout will be added once I get a clean 2.x CI

Can one of the admins verify this patch?

Thanks @ekuznetsov139 , I've kicked off a CI run for this PR:
http://ml-ci.amd.com:21096/job/tf-develop-upstream-releases/job/tensorflow-upstream-rel1.15-nightly/298/

@ekuznetsov139 there's only one unit test problem for this PR:
//tensorflow/python/kernel_tests:cwise_ops_test_gpu                     TIMEOUT in 3 out of 3 in 915.0s


[SPARK-19002][BUILD][PYTHON] Check pep8 against all Python scripts

What changes were proposed in this pull request?
This PR proposes to check pep8 against all other Python scripts and fix the errors as below:
./dev/create-release/generate-contributors.py
./dev/create-release/releaseutils.py
./dev/create-release/translate-contributors.py
./dev/lint-python
./python/docs/epytext.py
./examples/src/main/python/mllib/decision_tree_classification_example.py
./examples/src/main/python/mllib/decision_tree_regression_example.py
./examples/src/main/python/mllib/gradient_boosting_classification_example.py
./examples/src/main/python/mllib/gradient_boosting_regression_example.py
./examples/src/main/python/mllib/linear_regression_with_sgd_example.py
./examples/src/main/python/mllib/logistic_regression_with_lbfgs_example.py
./examples/src/main/python/mllib/naive_bayes_example.py
./examples/src/main/python/mllib/random_forest_classification_example.py
./examples/src/main/python/mllib/random_forest_regression_example.py
./examples/src/main/python/mllib/svm_with_sgd_example.py
./examples/src/main/python/streaming/network_wordjoinsentiments.py
./sql/hive/src/test/resources/data/scripts/cat.py
./sql/hive/src/test/resources/data/scripts/cat_error.py
./sql/hive/src/test/resources/data/scripts/doubleescapedtab.py
./sql/hive/src/test/resources/data/scripts/dumpdata_script.py
./sql/hive/src/test/resources/data/scripts/escapedcarriagereturn.py
./sql/hive/src/test/resources/data/scripts/escapednewline.py
./sql/hive/src/test/resources/data/scripts/escapedtab.py
./sql/hive/src/test/resources/data/scripts/input20_script.py
./sql/hive/src/test/resources/data/scripts/newline.py

How was this patch tested?

./python/docs/epytext.py
cd ./python/docs $$ make html

pep8 check (Python 2.7 / Python 3.3.6)
./dev/lint-python

./dev/merge_spark_pr.py (Python 2.7 only / Python 3.3.6 not working)
python -m doctest -v ./dev/merge_spark_pr.py

./dev/create-release/releaseutils.py ./dev/create-release/generate-contributors.py ./dev/create-release/translate-contributors.py (Python 2.7 only / Python 3.3.6 not working)
python generate-contributors.py
python translate-contributors.py

Examples (Python 2.7 / Python 3.3.6)
./bin/spark-submit examples/src/main/python/mllib/decision_tree_classification_example.py
./bin/spark-submit examples/src/main/python/mllib/decision_tree_regression_example.py
./bin/spark-submit examples/src/main/python/mllib/gradient_boosting_classification_example.py
./bin/spark-submit examples/src/main/python/mllib/gradient_boosting_regression_example.p
./bin/spark-submit examples/src/main/python/mllib/random_forest_classification_example.py
./bin/spark-submit examples/src/main/python/mllib/random_forest_regression_example.py

Examples (Python 2.7 only / Python 3.3.6 not working)
./bin/spark-submit examples/src/main/python/mllib/linear_regression_with_sgd_example.py
./bin/spark-submit examples/src/main/python/mllib/logistic_regression_with_lbfgs_example.py
./bin/spark-submit examples/src/main/python/mllib/naive_bayes_example.py
./bin/spark-submit examples/src/main/python/mllib/svm_with_sgd_example.py

sql/hive/src/test/resources/data/scripts/*.py (Python 2.7 / Python 3.3.6 within suggested changes)
Manually tested only changed ones.

./dev/github_jira_sync.py (Python 2.7 only / Python 3.3.6 not working)
Manually tested this after disabling actually adding comments and links.

And also via Jenkins tests.

Hi @srowen and @holdenk, this is a small PR to run pep8 against merge_spark_pr.py. Could I ask if it makes sense please?

Test build #70601 has started for PR 16405 at commit 8af1edb.

Test build #70601 has finished for PR 16405 at commit 8af1edb.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70601/
Test FAILed.

Hm, this was passed on my local.

Test build #70602 has started for PR 16405 at commit 4c3e496.

Hi @srowen and @holden, this is a small minor PR to check pep8 against ./dev/merge_spark_pr.py. Could you check if it makes sense please?

Test build #70602 has finished for PR 16405 at commit 4c3e496.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70602/
Test PASSed.

I'll try and take a more detailed look later on tonight.

Test build #70616 has started for PR 16405 at commit f756e09.

Test build #70616 has finished for PR 16405 at commit f756e09.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70616/
Test FAILed.

Ah, this seems complaining in Python 3.

Test build #70618 has started for PR 16405 at commit 6230678.

Test build #70620 has started for PR 16405 at commit 330b4fe.

Test build #70618 has finished for PR 16405 at commit 6230678.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70618/
Test FAILed.

Test build #70620 has finished for PR 16405 at commit 330b4fe.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70620/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #70622 has started for PR 16405 at commit 330b4fe.

Test build #70622 has finished for PR 16405 at commit 330b4fe.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70622/
Test FAILed.

retest this please

Test build #70624 has started for PR 16405 at commit 330b4fe.

Test build #70624 has finished for PR 16405 at commit 330b4fe.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70624/
Test PASSed.

Test build #70666 has started for PR 16405 at commit e4aa0af.

Test build #70666 has finished for PR 16405 at commit e4aa0af.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70666/
Test FAILed.

Test build #70667 has started for PR 16405 at commit aa6f427.

It seems some existing examples such as random_rdd_generation.py do not work with Python 3.3.6 too although it complies fine so that pep8 check can be passed. I fixed only the errors from pep8 here.

BTW, anyone tried Python 3.6.0 with PySpark? I could not even run ./bin/pyspark appeartly with an error.

Ah, thank you for approving @srowen.

Test build #70667 has finished for PR 16405 at commit aa6f427.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70667/
Test PASSed.

I just manually ran ./dev/create-release/translate-contributors.py which had a conflict for sure.

Test build #70734 has started for PR 16405 at commit 5ffa382.

Test build #70734 has finished for PR 16405 at commit 5ffa382.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70734/
Test FAILed.

Merged build finished. Test FAILed.

retest yhis please

Test build #70737 has started for PR 16405 at commit 5ffa382.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70737/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #70738 has started for PR 16405 at commit 5ffa382.

Test build #70738 has finished for PR 16405 at commit 5ffa382.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70738/
Test PASSed.

Merged build finished. Test PASSed.

Test build #70766 has started for PR 16405 at commit 3da7aec.

Test build #70766 has finished for PR 16405 at commit 3da7aec.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70766/
Test PASSed.

Merged to master


UI Issue for PowerToys Settings app

ℹ Computer information

PowerToys version: v0.27.1
PowerToy Utility: Power Toys Settings
Running PowerToys as Admin: Yes
Windows build number: 21277

📝 Provide detailed reproduction steps (if any)

Navigate to Image Resizer setting
Reduce the settings window size
At one point the side bar of the setting app will overlap with the main frame.

✔ Expected result
Side bar should not overlap the main frame
❌ Actual result
Side bar is overlapping the main frame
📷 Screenshots

Duplicate of https://github.com/microsoft/PowerToys/issues/8344


feat(docs) : provide docs for jest-haste-map package

Summary

When I was trying to use jest-haste-map for my project, it was hard for me to find any resource which can help me
get started easily.so, I think providing a proper readme will help most of people using this package to get started easily.

Can you run prettier over the file?

Thanks!


Slow evaluation with inner provider loop

Evaluation on multiple local Ollama models is very slow as currently in the code the outer loop is over prompts and inner loop over providers. I believe this leads Ollama to load up a local model (transfers gigabytes into memory) to just generate for a single prompt, and then discard the model and proceed to load up a next one. I'd assume it would be faster to loop over providers on outer loop and execute all (inner loop) prompts on the loaded model.
That is, in code here https://github.com/promptfoo/promptfoo/blob/main/src/evaluator.ts#L652
      for (const prompt of testSuite.prompts) {
        for (const provider of testSuite.providers) {

have instead
      for (const provider of testSuite.providers) {
        for (const prompt of testSuite.prompts) {

Maybe the same trivial change is needed also at https://github.com/promptfoo/promptfoo/blob/main/src/evaluator.ts#L524
Unfortunately I was not able to execute promptfoo from a locally altered repo (could not find instructions for that, only for self hosted dockerized instance), thus I'm afraid I cannot provide a PR.
If the change makes sense I suggest to keep both loops, and provide a command line option to allow user choose which looping to use. And of course update the docs accordingly.
Also, it would be fabulous to also expand docs how to contribute, develop, test and propose changes for promptfoo.

Great suggestion, I think it makes sense to flip the loop nesting.
The local dev instructions are tucked away at the end of the repo README.
I'll make sure they are added to the website docs as well, along with
contribution guidelines.
On Wed, Jul 10, 2024, 1:06 AM ErrorEradicator @.***>
wrote:

Evaluation on multiple local Ollama models is very slow as currently in
the code the outer loop is over prompts and inner loop over providers. I
believe this leads Ollama to load up a local model (transfers gigabytes
into memory) to just generate for a single prompt, and then discard the
model and proceed to load up a next one. I'd assume it would be faster to
loop over providers on outer loop and execute all (inner loop) prompts on
the loaded model.
That is, in code here
https://github.com/promptfoo/promptfoo/blob/main/src/evaluator.ts#L652
  for (const prompt of testSuite.prompts) {
    for (const provider of testSuite.providers) {

have instead
  for (const provider of testSuite.providers) {
    for (const prompt of testSuite.prompts) {

Maybe the same trivial change is needed also at
https://github.com/promptfoo/promptfoo/blob/main/src/evaluator.ts#L524
Unfortunately I was not able to execute promptfoo from a locally altered
repo (could not find instructions for that, only for self hosted dockerized
instance), thus I'm afraid I cannot provide a PR.
If the change makes sense I suggest to keep both loops, and provide a
command line option to allow user choose which looping to use. And of
course update the docs accordingly.
Also, it would be fabulous to also expand docs how to contribute, develop,
test and propose changes for promptfoo.
—
Reply to this email directly, view it on GitHub
https://github.com/promptfoo/promptfoo/issues/1125, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACLYJQPUNX3EPPMCIOPARTZLTTRPAVCNFSM6AAAAABKULIR6SVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYDAMBVGEZTCMA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Landed in #1132

Hi @ErrorEradicator, the fix has been merged and deployed in our latest release: 0.70.1.
We also plan to expand our documentation to include local development and contribution guidelines soon.
Thanks again for your valuable feedback!

In my first test I can confirm I got 25% speed increase in wall clock time.


Typo corrections for Dockerfiles for chrome stable and chrome beta

It made it easier to read, it is a minor change.

thanks


Significant changes to on-save syntax checking.

This is an experiment I was messing around with to improve the on-save error checking.

Crates with multiple targets are automatically detected.
Highlight/outline the regions where the message is.
Include a link for Exxxx errors to a web page.
Include a way to close/hide messages.
Support non-ascii output on certain platforms.
Display more messages (notes, macro expansions, etc.)
If there is a message for a file not currently open, print it to the console.

I can break some of these changes into separate PRs if you'd like, though they all touch the same code so that might be a little tricky.

@ehuss could i ask you update the readme with the changes you have made, so we keep it up to date with what this package can do.
Whats the error_tests folder?

Sure, I can update it.  I just wanted to get some feedback to see if you are interested in the changes before putting in more work.
The error_tests includes some samples that exercise some of the more esoteric messages (like macro expansion, refactoring tips, etc.).  Currently I just manually go through the files and hit save on each one and check what it looks like.  I thought about creating some automated tests, but that would be some work to mock the sublime API.

Tried this out and it's pretty sweet :)!

@ehuss looks good, ive played around with it, happy to merge something like this, but will let you carry on if there's more work to do

been trying this some more.
one of my projects can be compiled as --bin or --lib and i find it duplicates some warnings such as below

I also have a build script and am seeing this in the log
Failed to run: cargo rustc --custom-build build-script-build -- -Zno-trans -Zunstable-options --error-format=json

The automatic target detection needs some work.
If you want some background, see flycheck/flycheck-rust/pull/43 and rust-lang/cargo/issues/3211.  I looked at rustc --emit dep-info a little, but it is finicky.  I think I will do something similar to what that PR for flycheck-rust does.

might be nice if it were optional also.
personally my bin target just calls the lib with some args and so it's 99.9% lib. building all targets makes the checks take 6+ seconds instead of about 3, and sometimes building the bin goes crazy and takes 10s of seconds.

@ehuss any update on this? You mentioned needing more time to make changes

I've been using the latest version for a while, and it seems to be working well for me.  I was updating the README and was wondering how you prefer to host images.  The options I've seen:

Place file directly in repo, with a relative link (raw=true).  Downside it slightly bloats the repo.
Put it in a separate "images" branch.
Place image in an Issue and use the link generated from that.

This is the image I was thinking of using (not sure if you would prefer an animated one or not).

@ehuss good question, up to this point i've been using images hosted from the issue (like what you have done there).
I don't know for sure how long they stay hosted (maybe it's something i should find out).
I'm not too bothered about whether they are animated or not

Done some testing my side and it seems to be working ok


Training speed too slow with multiple-gpus

Hi,
Has anyone tried to train with multiple-gpus?
I am using the same settings as in the README for BertAbs(with 4 gpus and batch size 140). However, right now for 200k steps to finish, it is estimated to take around 10 days.
(I am using pytorch==1.1)

As said in the paper, the model is trained on 4 gpus, and it took about 4 days.

@ShirleyHan6 I have double-checked, it took about 2 day to reach best performace on valid set

have you meet the problem that training procedure just "stop" with no log information and no error message at iteration of 83850?


Typing issue: 制度が低い

Category of the typing issue
3. "精度が低い" is not converted as expected.
Issues

input [e.g.ゆうひ]
expected [e.g. 夕日]
actual [e.g. ユウヒ]

せいど
精度
制度

Version or commit-id
Mozc-2.28.5065.102+24.11.oss
Additional context
せいどがたかい =>
制度が高い (NG)
精度が高い (OK)

Hi utuhiro78,
d23536b updated test cases based on this issue.
ca75f3d updated the collocation data based on this issue.
Thank you for your feedback.

Thank you.


STAR-1864 changed default readMultiplier from 0.5 to 1.0

Force merged because changing a single multiplier value shouldn't cause tests to fail.


Runtime Error - multi-camera recording - Ubuntu 18.04 - SDK 1.1

The following is after applying the libusb memory fix at: https://github.com/microsoft/Azure-Kinect-Sensor-SDK/issues/485
Both cameras work with individual recordings.
subordinate:
$ k4arecorder --device 1 --external-sync subordinate output-2.mkv
Device serial number:<PHONE_NUMBER>12
Device version: Rel; C: 1.6.98; D: 1.6.70[6109.7]; A: 1.6.14
Device started
[subordinate mode] Waiting for signal from master

master:
$ k4arecorder --device 0 --external-sync master output-1.mkv
Device serial number:<PHONE_NUMBER>12
Device version: Rel; C: 1.6.98; D: 1.6.70[6109.7]; A: 1.6.14
[2019-07-15 11:28:31.205] [error] [t=4097] /home/vsts/work/1/s/extern/Azure-Kinect-Sensor-SDK/src/color/uvc_camerareader.cpp (153): Start(). Failed to start streaming: Unknown error
[2019-07-15 11:28:31.205] [error] [t=4097] /home/vsts/work/1/s/extern/Azure-Kinect-Sensor-SDK/src/color/color.cpp (194): color->m_spCameraReader->Start(width, height, fps, config->color_format, &color_capture_available, color) returned failure in color_start()
[2019-07-15 11:28:31.205] [error] [t=4097] /home/vsts/work/1/s/extern/Azure-Kinect-Sensor-SDK/src/sdk/k4a.c (725): color_start(device->color, config) returned failure in k4a_device_start_cameras()
Runtime error: k4a_device_start_cameras(device, device_config) returned 1

System: NUC8i7HVK w/ 32 GB RAM
OS: Ubuntu 18.04, Fully Updated
SDK: 1.1.0

Unfortunately that log is not too helpful. Can you rebuild the SDK in debug mode and retry? Use the CMake option -DCMAKE_BUILD_TYPE=Debug.

Sure! Not much in those original logs you're right. See attached for equivalent debug logs.
master.txt
subordinate.txt

Possibly a library is missing for handling the image type?

I don't think so and we have not seen this error before. Would you mind updating uvc_strerror function in your extern libuvc project to convert all the known error codes to strings so we can figure out what error code is comming back?

@somacoder any update on this? Any chance you got it working?

Hey @wes-b ! I apologize for the delayed followup here. I was deep into Kinect programming and configuration in Windows.
After reinstalling a clean 18.04, this problem appears to have went away completely! Excelsior!


developer and contributing docs

@derivation could you combine contributing to qiskit, development strategy and community extensions into a single file called contributing to qiskit or something.
I want this to be the default that one that all Qiskit-terra, Qiskit-aqua, qiskit-ignis qiskit-ibmq-provider, and Qiskit-aer link to with their CONTRIBUTING. It should be the default place.

in #436 and #435 and #434 I did this. So I will close this issue.


Log source IP in operations logs

We currently do not log the source IP of an operation.  It would really have helped me understand Spark behaviour if we did :-)  This should support load balancers placed in front of the server,  by respecting X-Forward headers or something.
For reference, here's a log from a DeleteObject operation that I just performed:
{
  "file": "usr/local/go/src/net/http/server.go:2047",
  "func": "net/http.HandlerFunc.ServeHTTP",
  "host": "econigma.us-east-1.lakefscloud.ninja",
  "level": "info",
  "log_audit": "API",
  "method": "DELETE",
  "msg": "HTTP call ended",
  "operation_id": "DeleteObject",
  "path": "/api/v1/repositories/test-1/branches/test-overwrite2/objects?path=amazon-reviews-repartition-sample%2F_temporary%2F0%2Ftask_202209280827329171407584636600739_0002_m_000055%2Fpart-00055-bfb9a212-2d0e-4aa5-b485-e0f4fd2f07b4-c000.snappy.parquet",
  "request_id": "86ce10cf-d4f0-48fc-aaf8-0c64fb9343d6",
  "sent_bytes": 0,
  "service_name": "rest_api",
  "status_code": 204,
  "time": "2022-09-28T08:31:09Z",
  "took": 13416254
}

The same of S3 gateway operations too, please (which include the name of the invoking user, at least):
{
  "file": "usr/local/go/src/net/http/server.go:2047",
  "func": "net/http.HandlerFunc.ServeHTTP",
  "host": "econigma.us-east-1.lakefscloud.ninja",
  "level": "info",
  "log_audit": "API",
  "matched_host": false,
  "method": "HEAD",
  "msg": "HTTP call ended",
  "path": "amazon-reviews-repartition/_temporary/0/task_202209250821368514549904317969258_0004_m_002914",
  "ref": "test-overwrite2",
  "repository": "test-1",
  "request_id": "577f6a5c-0ce0-4142-9aef-6fb437603bba",
  "sent_bytes": 423,
  "service_name": "s3_gateway",
  "status_code": 404,
  "time": "2022-09-25T10:09:29Z",
  "took": 53151590,
  "user": "xxxxx"
}

please assign me for this issue and guide me what to do . Sir.

Hi @a-Cash-dixit !
Thanks for taking this!
There are these 2 log messages emitted for every API operation (the first one) and for every S3 gateway operation (the second one).  You can make lakeFS emit the first one by running any lakectl operation, and the second by running any aws s3 operation with the lakeFS S3 gateway as its endpoint (see the AWS CLI integration guide for how to configure this!).  And each log message just points you t the line in the code that emits it.
Now the goal is to add to these 2 log messages the IP of the user.  The Golang http.Server page should have at least one option for getting the source IP of a connection -- please find a good one (the more standard and simple the better!) and add that to the log.
Please do let me know how you get along -- we're here to help.

can you add Hacktoberfest tag to your repo. Sir.

can you add Hacktoberfest tag to your repo. Sir.

Hi @a-Cash-dixit ,
Unfortunately this year we shall not participate in Hacktoberfest.    I know that this will disappoint you as much (or even more) as it does me.  So I want to explain why we made this difficult decision.
Previously we did participate in Hacktoberfest.  This year we have elected not to do so.  There are unfortunately two types of contributors attracted by Hacktoberfest: genuine ones like yourself, and (unfortunately!) bad-faith people who send spam PRs.  It's easy to tell the spam PRs of course, and I can already see that you are not a spammer.  Our worry is that as soon as I put the "hacktoberfest" tag on the repo, we will get just too many of them!
While the PRs like those you intend to send are great, in practice there are far more PRs sent by the second group of people.  And as a small open-source project, the price paid to deal with all of those PRs is tremendous.  Using this search you can  find just a few of the PRs sent by people.  They include many changes such as adding and removing a single comma from the docs.  We were reviewing and closing more than 10 spam PRs per day on that Hacktoberfest.
So we regretfully decided not to participate in Hacktoberfest this year.

hi @arielshaqed! Can you assign this to me? I think I can give it a shot based on your comment from October 2 (also first contribution to lakeFS :) )