[Refactor] Fix refresh bugs with nested mvs

Why I'm doing:

MV is auto event triggered by base table's change, but mv still cannot be refreshed because it can not detect base table's partition changes.

2024-05-23 10:39:59.110+08:00 INFO (PUBLISH_VERSION|43) [PublishVersionDaemon.refreshMvIfNecessary():877] Trigger auto materialized view refresh because of base table test_mv2 has changed, db:db_9e76b705db50455782d0b6abf11a9f35, mv:test_mv3
2024-05-23 10:39:59.110+08:00 INFO (PUBLISH_VERSION|43) [LocalMetastore.executeRefreshMvTask():3593] Start to execute refresh materialized view task, mv: test_mv3, refreshType: ASYNC, executionOption:{"priority":50,"taskRunProperties":{"FORCE":"false"},"isMergeRedundant":true,"isManual":false,"isSync":false,"isReplay":false}
2024-05-23 10:39:59.793+08:00 INFO (starrocks-taskrun-pool-1|222) [PartitionBasedMvRefreshProcessor.syncPartitionsForExpr():963] The process of synchronizing materialized view [test_mv3] delete partitions range [{}]
2024-05-23 10:39:59.796+08:00 INFO (starrocks-taskrun-pool-1|222) [PartitionBasedMvRefreshProcessor.syncPartitionsForExpr():975] The process of synchronizing materialized view [test_mv3] add partitions range [{}]
2024-05-23 10:39:59.796+08:00 INFO (starrocks-taskrun-pool-1|222) [PartitionBasedMvRefreshProcessor.syncAndCheckPartitions():239] materialized view test_mv3 after checking partitions change 1 times: true
2024-05-23 10:39:59.796+08:00 INFO (starrocks-taskrun-pool-1|222) [PartitionBasedMvRefreshProcessor.checkMvToRefreshedPartitions():255] no partitions to refresh for materialized view test_mv3

What I'm doing:
Cause1 : Check base table(or mv)'s change by using version and modified time rather than version only because partition is overwritten for nested mv scenes and version may be the same even if it has been dropped and created again.

Make partition version volatile to make sure its visible for multi threads.

    /**
     * Check whether the base table's partition has changed or not.
     * NOTE: If the base table is materialized view, partition is overwritten each time, so we need to compare
     * version and modified time.
     */
    private static boolean isBaseTableChanged(Partition partition,
                                              MaterializedView.BasePartitionInfo mvRefreshedPartitionInfo) {
        return partition.getVisibleVersion() != mvRefreshedPartitionInfo.getVersion()
                || partition.getVisibleVersionTime() > mvRefreshedPartitionInfo.getLastRefreshTime();
    }

Cause2: collectBaseTableSnapshotInfos should use snapshot of the base table instead of visiting mv directly if the base table is a mv:
      } else if (table.isOlapMaterializedView()) {
                    MaterializedView copied = DeepCopy.copyWithGson(table, MaterializedView.class);

Otherwise the final version is not the snapshot but the newest version of mv.

BTW, fix the gsonPostProcess bugs for MaterializedView class.

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@mergify backport branch-3.3

@mergify backport branch-3.2

@mergify backport branch-3.1


[Bug] Can't run cargo test

Component
nodes
What version of Alloy are you on?
Branch e4fb6691
Operating System
Linux
Describe the bug
After cloning alloy, when I try to run:

cargo test
cargo test --all-features
cargo test --no-default-features

I am getting the following failed tests:
     Running unittests src/lib.rs (target/debug/deps/alloy_node_bindings-ff44a1c004dfb71e)

running 12 tests
test geth::tests::dev_mode ... FAILED
error: invalid value '0.5' for '--block-time <SECONDS>': invalid digit found in string

For more information, try '--help'.
test geth::tests::explicit_p2p_port ... FAILED
test geth::tests::clique_correctly_configured ... FAILED
test geth::tests::p2p_port ... FAILED
test geth::tests::test_extract_address ... ok
test geth::tests::port_0 ... FAILED
test anvil::tests::can_launch_anvil_with_more_accounts ... ok
test anvil::tests::assert_chain_id_without_rpc ... ok
test anvil::tests::assert_block_time_is_natural_number ... ok
test anvil::tests::can_launch_anvil ... ok
test anvil::tests::assert_chain_id ... ok
test anvil::tests::can_launch_anvil_with_sub_seconds_block_time ... FAILED

failures:

---- geth::tests::dev_mode stdout ----
thread 'geth::tests::dev_mode' panicked at crates/node-bindings/src/geth.rs:722:60:
called `Result::unwrap()` on an `Err` value: SpawnError(Os { code: 2, kind: NotFound, message: "No such file or directory" })
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- geth::tests::explicit_p2p_port stdout ----
thread 'geth::tests::explicit_p2p_port' panicked at crates/node-bindings/src/geth.rs:712:75:
called `Result::unwrap()` on an `Err` value: SpawnError(Os { code: 2, kind: NotFound, message: "No such file or directory" })

---- geth::tests::clique_correctly_configured stdout ----
thread 'geth::tests::clique_correctly_configured' panicked at crates/node-bindings/src/geth.rs:736:18:
called `Result::unwrap()` on an `Err` value: SpawnError(Os { code: 2, kind: NotFound, message: "No such file or directory" })

---- geth::tests::p2p_port stdout ----
thread 'geth::tests::p2p_port' panicked at crates/node-bindings/src/geth.rs:702:80:
called `Result::unwrap()` on an `Err` value: SpawnError(Os { code: 2, kind: NotFound, message: "No such file or directory" })

---- geth::tests::port_0 stdout ----
thread 'geth::tests::port_0' panicked at crates/node-bindings/src/geth.rs:681:68:
called `Result::unwrap()` on an `Err` value: SpawnError(Os { code: 2, kind: NotFound, message: "No such file or directory" })

---- anvil::tests::can_launch_anvil_with_sub_seconds_block_time stdout ----
thread 'anvil::tests::can_launch_anvil_with_sub_seconds_block_time' panicked at crates/node-bindings/src/anvil.rs:404:50:
called `Result::unwrap()` on an `Err` value: Timeout

failures:
    anvil::tests::can_launch_anvil_with_sub_seconds_block_time
    geth::tests::clique_correctly_configured
    geth::tests::dev_mode
    geth::tests::explicit_p2p_port
    geth::tests::p2p_port
    geth::tests::port_0

test result: FAILED. 6 passed; 6 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.00s

error: test failed, to rerun pass `-p alloy-node-bindings --lib`

Which makes all of the testsuite crash for me, so when I do modifications to alloy I can't test all of alloy and have to test the crate separately from others.
Steps to reproduce
➜ git clone https://github.com/alloy-rs/alloy.git
➜ cd alloy
➜ cargo test

Os version
Ubuntu 22.04.4 LTS

Unfortunately running all of the tests requires having geth and anvil installed which is why these tests are failing for you 😓


Intro to inheritance

Related Issue
-issue number #378
Proposed Changes

I-Inheritance folder has been created inside the OOPs folder.
README file has been added which consists of an overview and explanation about the concept of inheritance.
A CPP file for Single Inheritance has been created which explains the concept of single inheritance, working of derived and base class along with its code.

Additional Info

No additional info

Checklist

[x] ✅ My code follows the code style of this project.
[x] 📝 My change requires a change to the README.
[x] 🎀 I have updated the README accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[x] ✨ I have added tests to cover my changes.
[x] 🚩 All new and existing tests passed.
[x] 🌟 ed the repo

I have added the Inheritance concept in OOPs. So, far I have added the description about Inheritance and explanation about Single Inheritance in this Branch. The detailed files will be added after.
Inheritance is an important aspect in understanding Object Oriented Programming. This was missing from this project. Understanding inheritance, helps solve many issues for a coder.
What types of changes does your code introduce?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Screenshots:
Code:

Output:

Any Updates ?

Any Updates ?

I am working on it

@all-contributor please add @SanyaGera code ,

@all-contributors please add @SanyaGera code ,


Respect timeoutInMinutes on cfnUpdate

The pipeline only waits for 10 minutes when a cfnUpdate is run. This is regardless of a higher been set in the timeoutInMinutes parameter. Like this:
    cfnUpdate stack: stackName,
            file: "${CLOUDFORMATION_DIR_PATH}/application.json",
            params: cfnParameters,
            timeoutInMinutes: 30,
            pollInterval: 20000

... and then you get

Setting up a polling strategy to poll every 30 seconds for a maximum of 10 minutes

Turns out that 10 minutes is hardcoded. I fixed that in the attached patch. This causes us a bit of flakyness (our instances takes 7 minutes to start).
I tried to do a PR, but when I try to push the branch I get a 403.
respect-timeout.patch.tar.gz
I was able to drop some really nasty bash scripts by using this plugin, and for that I'm very greatful. Keep up the good work!

Thanks. Great catch. I applied your changes in https://github.com/jenkinsci/pipeline-aws-plugin/commit/bb937e88a2b4de6a6eff8329e23c6d24b90a5f6d with some modifications.
Can you please try this version? You can fetch it from https://ci.jenkins.io/job/Plugins/job/pipeline-aws-plugin/job/master/ once the build finished

I am having the same issue.
I have a stack that takes more than 10 minutes to create. The pipeline always times out after 10 minutes of waiting for AWS CloudFormation to create the stack.
I tried changing the value of timeoutInMinutes to 25, but it still times out after 10 minutes.

Thanks for the feedback. I will release a fixed version today.


Added Square Grid Loader

Fixes Issue🛠
Closes #376
Description👨💻
Added a square grid animated loader
Type of change📄

[x] New feature (non-breaking change which adds functionality)

How this has been tested✅
Tested locally
Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF📷
https://github.com/Rakesh9100/Beautiify/assets/56386613/4a36e99c-6902-49f1-aed0-0b41bc9f20da

Merged 🥳 @Nemesis-AS


Identify UTxOs suitable for use as collateral

Issue Number
ADP-1053
Overview

Added a function asCollateral to identify UTxOs suitable as collateral inputs.
Clarified the meaning of a "VK input".
Thoroughly tested the collateral functions.
Added a property test to test the behaviour of TokenBundle.toCoin.

Comments

I've clarified with the ledger team that a UTxO is to be considered suitable for collateral iff the payment credential associated with the output address of the UTxO is of type "key hash".
See the "Binary Address Format" heading of this spec: https://hydra.iohk.io/build/6752483/download/1/ledger-spec.pdf

Given that:

You've already written a very nice and expressive AddressType type.
We know which address types are suitable for collateral.

I wonder if might be easier to write asCollateral as a composition of the following functions:
addressType :: Address -> Maybe AddressType
-- looks at the bit pattern, reuses `getHeader`

addressTypeSuitableForCollateral :: AddressType -> Bool
-- a simple mapping

Then we could write something like this:
asCollateral txOut = do
    coin <- TokenBundle.toCoin $ tokens txOut
    addrType <- addressType (address txOut)
    if addressTypeSuitableForCollateral addrType
    then Just coin
    else Nothing

bors r+


Fix #469, Addresses invalid CodeQL language option

Fixes #469
Checklist (Please check before submitting)

[x] I reviewed the Contributing Guide.
[x] I signed and emailed the appropriate Contributor License Agreement to<EMAIL_ADDRESS>and copied<EMAIL_ADDRESS>
Describe the contribution
Fixes #469. CodeQL will no longer throw an error regarding valid language input options.
Testing performed
None.
Expected behavior changes
CodeQL will no longer throw an error regarding valid language input options.
System(s) tested on
n/a
Contributor Info - All information REQUIRED for consideration of pull request
@thnkslprpt

Closed - will resubmit with correct commit message format.


Code does not clone selection

This code clones the Active layout, not the layout selected.

Thanks Jeff.  I assumed you a referring to the Duplicate Layout sample.  If so then this issue has been fixed.   The layout duplicate add-in is now using the Catalog pane selection instead of the active layout.


Unit Testing Godot Classes

With the hello world example, I added a public method:
export fn foo(&mut self) -> String {
    String::from("foo works!")
}

I'm struggling with writing a unit test for this. Here's what I have so far.
#[test]
fn it_makes_foo_work() {
    let hello_world = HelloWorld { header: godot::NativeInstanceHeader { this: godot::init::InitHandle { handle: ... } } };
    assert_eq!(hello_world.foo(), "foo works!");
}

I cannot figure out what to put for the handle for godot::init::InitHandle.
Is there an easier way to test public methods for Godot classes?
Thanks!

Hi, answering from a phone so perron the brievety and formatting. Godot classes need to be initialized by the engine, that's where the init handle comes from. So classes (as well as other things that use the engine) can't be tested with a simple #[test] annotation.
What you can do is create a Godot project which sole purpose is to run tests. That's what we do in the test directory and can be automated by running Godot in headless mode from the command line (we haven't set that up yet ourselves though).

@nical Thanks for the clarification and recommendation!


Custom LUT

Hello, dear colleagues. Thanks for OCIO! It is great. In this webinar, I saw a «shotlut» on the display. Please tell me how I can do the same in my studio? We use ACES 1.2.
https://youtu.be/d_LZsd_F_0g?t=726

Hello, i'm not very familiar with this workflow but you best get started by having a look at the documentation :

https://opencolorio.readthedocs.io/en/latest/guides/authoring/authoring.html#contexts-example

Hello @dalinagraphics i'm not very familiar with this workflow but you best get started by having a look at the documentation :

https://opencolorio.readthedocs.io/en/latest/guides/authoring/authoring.html#contexts-example

Thanks, I did it!

Glad to hear ! You can close this issue if you consider it resolved.


fix: missing name attribute for multiple answer items

Related issue
Closes #215
Scope of work

Pass name attribute based on name prop or inputAttrs of items prop element.
Add unit test

Screenshots

why you can't add
inputAttrs: { name: 'input' },

to item?

we can pass name to input
why you can't add
inputAttrs: { name: 'input' },

to item?

@pspaczek We can't really set a fixed input value. What if we wanted to display this component many times on one screen? Then, there will be a conflict of name attributes. Not sure if this is the answer to your question :D

nope; how you pass name to input. You want to add new props for UiMultpleAnswerItem to pass input-attrs but you can use input-attrs without your changes because it will be  bonded with $attrs


Multi-line function call

Hi guys,
after phpcs updated to 2.4.0 (specifically after this commit https://github.com/squizlabs/PHP_CodeSniffer/commit/7ae3c57f6083a09d089d6e3dc710874946369598) multi-line function calls in VIP return a phpcs error "Multi-line function call not indented correctly"
Example of test.php
print_r( array(
[tab]'parent' => array(
[tab][tab]'key' => 'value',
[tab]),
) );

then run
$ phpcs --standard="WordPress-VIP" test.php

FILE: test.php
FOUND 1 ERROR AFFECTING 1 LINE

 4 | ERROR | [x] Multi-line function call not indented correctly;  |       |     expected 4 spaces but found 8

The same code works fine agains PEAR standards, so I guess some of WordPress-VIP phpcs code clash with the recent changes.

@evgenykireev hi :)
The PHP_CodeSniffer maintainer responded the commit comments:

This commit is over 2.5 years old and the code was in every 2.x version, not just 2.4.0. Are you sure this is the right commit? If so, what error are you actually reporting?

Maybe it is related to https://github.com/squizlabs/PHP_CodeSniffer/issues/721?

@westonruter It might relate to some other changes, but I noticed that the code above do not return any errors when run on phpcs 2.3 and return PEAR.Functions.FunctionCallSignature error with phpcs 2.4.
@JDGrimes yes, it looks like a similar issue, but I only have errors when using WordPress-VIP standards and we do not put commas  in front in function calls.

@evgenykireev Considering there have been a lot of changes to WPCS (and PHPCS) over the last year, I've run some test on how this snippet is now handled.
The error you mention is no longer thrown and auto-fixing the snippet would result in:
print_r(
	array(
		'parent' => array(
			'key' => 'value',
		),
	)
);

Is this ok for you ? Can we close this issue ?

Closing for lack of response.
If this is still an issue, please provide the additional information requested and we can reopen the issue.


Read blocks forever

Occasionally, with ffmpeg or youtube-dl via proxychains4, a read can block forever. Don't know how to reliably reproduce or debug yet.

Seems fixed in 4119c13


Models

@chritkhalil I made this PR from feature to main directly. Maybe we can make rid of the dev branch from now on. What do you think?


v4l2: fix pthread linkage

Don't use -lpthread since it is less portable then -pthread.
Use -pthread instead with GCC.
On Ubuntu 14.04, attempting to link a program with two libraries,
where one was linked with -lpthread and one that linked with
-pthread, can cause the link phase to fail with undefined
references to various pthread functions.
Signed-off-by: U. Artie Eoff<EMAIL_ADDRESS>

+1

merged as 8c2795c29593034fc01d0f27703288ad7f441eb6.
thanks uartie


Wezterm cannot be opened

Hyprland Version
Tag: v0.31.0-36-g6650e4ba
Bug or Regression?
Bug
Description
Wezterm cannot be opened
How to reproduce
Wezterm cannot be opened
Crash reports, logs, images, videos
Wezterm cannot be opened

能分享一你的终端模糊的配置的吗 我设置了不生效

Can you share a fuzzy configuration of your terminal? I set it not to work
主页有配置文件，

wezterm issue https://github.com/wez/wezterm/issues/4483

The issue got introduced with 59f27e7, according to this comment.
It could be a Hyprland issue. It also happened to me on 92cf1c23. Running an AMD 6750 (not Nvidiarse).

yeah, that commit improves hyprland's accordance to the wayland spec. :)


Add support to YAML/YML files.

This pull request adds support YAML and YML files and resolves #30.
When reading files it checks that if the file ends .yaml or .yml and reads that into object. That object is passed to generateApi that takes 2nd argument called swagger as in object instead of string.

Looks great! Can you add a test for it?

Can you add a test for it?

It seems that this project does not have any tests so far. Should I use any particular testing framework?


Add feature and remove bugs

Description
##Features Added
Adding the missing elements
Adding each element name like H - Hydrogen ....
Adding Hover effect to each element
Make UI eye catching
adding Smooth hover effect
Fixes:  #482

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@connectnitesh make heading in center in mobile view
change its title to periodic table
increase font size of number in small screen

Why this PR is not merged?


Added --classes argument and fixed a few issues in README

As stated, added --classes argument so that when using a retrained model, you can specify the text file containing your new classes to get the correct classification. Note that without the flag, it defaults to the normal classes.
I also made a couple of changes in the README to reflect the new flag and changed occurrences of res/file.jpg to res/image_file.jpg as this appears to be a typo.

thanks, nice solution


TAXII Miner should supported Observable Composition

Starting with support for operator OR.

This has been added with pull request #56


Environment: Specify python version as <3.13

There are compatibility issues of python 3.13 and torch.save
see this issue

Closed with #68


A simple question about how you are using matplotlib?

Hi, and i realize that this may be trivial.
In your "figures" you are using python functions that are defined in the "plots" directory.
In the jupyter notebook you use
figure1(x_train, y_train, x_val, y_val
This calls the function
`def figure1(x_train, y_train, x_val, y_val):
fig, ax = plt.subplots(1, 2, figsize=(12, 6))
ax[0].scatter(x_train, y_train)
ax[0].set_xlabel('x')
ax[0].set_ylabel('y')
ax[0].set_ylim([0, 3.1])
ax[0].set_title('Generated Data - Train')

ax[1].scatter(x_val, y_val, c='r')
ax[1].set_xlabel('x')
ax[1].set_ylabel('y')
ax[1].set_ylim([0, 3.1])
ax[1].set_title('Generated Data - Validation')
fig.tight_layout()

return fig, ax

`
I notice that there is no plt.show() statement that is needed, either in the function or in the jupyter notebook.
However, if I am at the command line (not using the jupyter notebook) and I enter the python code line by line and make the "figure" call, I don't get a plot unless I use "plt.show()" as the next line after the figure call.
Can you tell me why plt.show() is not necessary for the jupyter notebook but it is necessary when calling the function from the command line?
Thank You
Tom

Hi Tom,
I am assuming you figured this out by now since you already closed the issue :-)
But, answering your question, the key is in Jupyter notebook's "magic" command: %matplotlib inline, which captures the figures generated by matplotlib and displays them inside the notebook.
Anyway, if you want to learn a bit more about matplotlib's display options, this material from Jake VanderPlas is really good:
https://jakevdp.github.io/PythonDataScienceHandbook/04.00-introduction-to-matplotlib.html
Best,
Daniel

Hi and I do appreciate your help.
I closed the issue because I found that matplotlib can be used in
interactive mode, non interactive mode and with "backends", of which,
jupyter, is one of them. There is a "block" involved, which just says that
if one is returning from a python function, like you do in figure1,
figure2...etc, there is no block and plt.show() is not required.
From the matlab documentation:
https://www.google.com/search?channel=fs&client=ubuntu&q=matplotlib+when+is+plt.show()+needed
Also, I checked in chapter0, you never did use "%matplotlib inline " but at
least now, I am closer to understanding what it does.
Thank You
Tom
On Mon, Nov 23, 2020 at 1:00 PM Daniel Voigt Godoy<EMAIL_ADDRESS>wrote:

Hi Tom,
I am assuming you figured this out by now since you already closed the
issue :-)
But, answering your question, the key is in Jupyter notebook's "magic"
command: %matplotlib inline, which captures the figures generated by
matplotlib and displays them inside the notebook.
Anyway, if you want to learn a bit more about matplotlib's display
options, this material from Jake VanderPlas is really good:
https://jakevdp.github.io/PythonDataScienceHandbook/04.00-introduction-to-matplotlib.html
Best,
Daniel
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/dvgodoy/PyTorchStepByStep/issues/9#issuecomment-732423150,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADHGGHFESQARO6DLCZYFIODSRLEPTANCNFSM4T7AJ46Q
.


Decentraleyes is currently broken in FF63beta + 64nightly [1489882]

Issue: https://git.synz.io/Synzvato/decentraleyes/issues/313
Testpage: https://decentraleyes.org/test/
edit: bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1489882
ps

Microsoft is acquiring GitHub. Decentraleyes is leaving GitHub. Welcome to its new home!

new home: https://git.synz.io/Synzvato/decentraleyes

@gorhill, redirecting in uBO is probably also affected

It's working fine on my Nightly as far as I can tell -- the redirection to neutered scripts are working fine.

thanks re new home: updated wiki links

Thanks @gorhill for checking. Interesting that it works in uBO and not in Decentraleyes. I suspect the problem is that he uses .js.dec file extensions

https://bugzilla.mozilla.org/show_bug.cgi?id=1489882 was WONTFIX ... IDK where that leaves DC

:-1: for Gijs on the bugzilla, his replies confirm the cold war on the webextenison devs by Mozilla. He's gijsk on GH.

:-1: for Gijs on the bugzilla, his replies confirm the cold war on the webext-devs by Mozilla. He's gijsk on GH.

There's no such cold war. It's a regression that affects one extension (or only one extension that we care about). Everyone has different views, reasons and desired outcomes. We don't always have to like Mozilla's decisions - but you should at least respect them, IMO.

Ok, comment deleted and I'll refrain to comment about bugzilla in the future.

You guys should read the bug before commenting here. Mozilla decided that FF would now validate files injected into web pages using their filename/extension. If you ask me this is pointless since file extensions mean nothing, but what do I know, maybe it helps. In any case, Decentraleyes has been forced, since a long time, to use a custom file extension for the files it injects BECAUSE of the LINTER. That is to say, the problem is not with Firefox at all, it is with the script that runs and validates addOns when they are uploaded to AMO. THAT is where a bug report needs to be opened (couldn't they just assign the current bug to the AMO team instead of closing it as wontfix?) Anyway, it's not a FF bug, it's an AMO bug...

Maybe a bug needs to be opened on Linter GitHub if it takes too long to validate Decentraleyes...

I'm happy to say that a fix has been deployed. Upgrading to v2.0.8 should restore all functionality


Unexpected maxNativeZoom: 0 behavior.

Hi everyone,
So I just got started with Leaflet today, I'm gonna explain the work I have to do so you understand my case.
Basically I have to locate goods on a interior map, placing pins on it. That's easy.
For now, my interior map is a 360pixels by 300pixels image. And here is my code :
var imageUrl = "myimgurl";
var mymap = L.map('mapid').setView([0,0],0)

L.tileLayer(imageUrl, {
     attribution: 'MyCompany',
     minZoom: 0,
     maxZoom: 2,
     maxNativeZoom: 0,
     // continuousWorld: true,
     noWrap: true,
}).addTo(mymap);

var marker = L.marker([150, 180]).addTo(mymap);
marker.bindPopup("Hello World !").openPopup();

I want the users to be able to zoom twice on the base Image, but what it does is that, at each zoom, the background for the previous zoom state gets bigger (intended) then it divides itself in 4 images.
So I've been playing with maxNativeZoom to see what's the problem.
And from the previous example I changed nothing but the maxNativeZoom, putting it at 1 : maxNativeZoom: 1, and then it does kind of what's expected : from 0 to 1 it still zooms in, splitting the base image in 4. Then from 1 to 2 it only scales up the image, what I am looking for.
So end of my story, I think that the behavior of maxNativeZoom when it equals 0, is broken.
I hope you understood what I want to do : go from zoom level 0 to 2 only scaling up the base image.
Thanks in advance,

You're using a L.TileLayer when you really want to use a L.ImageOverlay (or maybe a L.ImageOverlay.Rotated`, check the plugins list). Do check the tutorial on non-geographic maps also.
Please be aware that this issue tracker is for bug reports (and sane feature requests) only. For this kind of questions on how to use Leaflet, please use gis.stackexchange.com or stackoverflow in the future.

Alright, my bad, I thought of posting here because after searching on this repo, I've found that there were some previous unwanted behaviors involving this var.
Anyways, thanks for your help.


Add USDA CDL license link

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
It's an update to a static file.
Checklist:

[x] I have performed a self-review

Good news, this failed over in https://github.com/microsoft/planetary-computer-tasks/actions/runs/4294990455/jobs/7484783839#step:7:62, where I'm adding the validator.
I'll merge this and get it deployed. Thanks!


tempdir has been deprecated

The tempdir crate has been deprecated in favor of the tempfile crate.
Ref. https://github.com/rust-lang-deprecated/tempdir#deprecation-note

Thanks!


Add a workspace file

Currently, someone cloning the repository will be confused as to how to make it work with their editor. Gopls requires the use of Go Workspaces when multiple modules are present. For example, in VSCode, people will see the following error:

I propose to add a go.work file to solve that problem.
It was generated with:
go work init
go work use -r cmd test

Notice how the root go.mod isn't listed as part of the modules. I had to add . as the part of the modules. Otherwise, it is not possible to run go test ./...
I didn't commit go.work.sum because I don't know how that file could help us. I noticed that go work sync seems very useful to keep the various deps at the same version.
go work sync was showing the following error:
$ go work sync
go: version constraints conflict:
<EMAIL_ADDRESS>requires<EMAIL_ADDRESS>but<EMAIL_ADDRESS>is requested
<EMAIL_ADDRESS>requires<EMAIL_ADDRESS>but<EMAIL_ADDRESS>is requested
<EMAIL_ADDRESS>requires<EMAIL_ADDRESS>but<EMAIL_ADDRESS>is requested
<EMAIL_ADDRESS>requires<EMAIL_ADDRESS>but<EMAIL_ADDRESS>is requested
<EMAIL_ADDRESS>requires<EMAIL_ADDRESS>but<EMAIL_ADDRESS>is requested
<EMAIL_ADDRESS>requires<EMAIL_ADDRESS>but<EMAIL_ADDRESS>is requested
<EMAIL_ADDRESS>requires<EMAIL_ADDRESS>but<EMAIL_ADDRESS>is requested

I thus updated github.com/google/pprof to the latest version and the problem is gone. I was able to run go work sync successfully (which is useless since we don't use go.work.sum...)
/kind cleanup
NONE

/retest

/retest

I had to fix a tiny problem with Pebble. When building Pebble, Go was mistakenly thinking that the go.work is the Go Workspace in which the Pebble module resides:
main module (github.com/cert-manager/cert-manager) does not contain package github.com/cert-manager/cert-manager/_bin/downloaded/containers/amd64/pebble/pebble-ba5f81dd80fa870cbc19326f2d5a46f45f0b5ee3/cmd/pebble
At first, I thought that directories prefixed with _ would be ignored (like what "go build" does), but it doesn't seem to work that way since the go.work file is looked up recursively "upwards", not downwards.
The only workaround I could think of is to build Pebble outside of the tree in which go.work resides.

/retest

/retest

/test pull-cert-manager-master-license

/retest

/retest

/test pull-cert-manager-master-license

/test pull-cert-manager-master-license

/retest

/test pull-cert-manager-master-chart

/test pull-cert-manager-master-license
/test pull-cert-manager-master-chart

/test pull-cert-manager-master-make-test

/retest

/lgtm


lockfile: command not found

RE line 12 in process sample local:
lockfile -r 0 ${LOCKFILE} || exit 1
I am sure that my environment is loading correctly, and I can see that ./lib/python3.6/site-packages/lockfile was installed in the appropriate place in my environment.
This is how I created the environment I'm using:
mamba create -c conda-forge -c bioconda -n pb-human-wgs-debug2 snakemake=6.15.5 lockfile=0.12.2 pysam=<IP_ADDRESS> python=3
However, this line is failing with the error: line 12: lockfile: command not found
A sample command that I used to run step 2 is: ./workflow/process_sample.local.sh sample_ID
How can I find the command and/or make the python software work in the bash context (if this is the right package)?
Thank you!

Yeah, lockfile isn't working as expected here.  I'll look into it more after Thanksgiving, but the good news is that in the meantime, you can comment line 12 out (and the similar line in process_cohort.local.sh).  This is meant to prevent the user from running the same command twice on the same sample at the same time.  If you're careful in the meantime, it shouldn't be a problem.

Got it - yeah I submit with loops so that's not an issue. Will do!
(Happy Thanksgiving)


'module' object has no attribute 'TOKEN_VAR'

it seems related to "verbatim" tag
django version is 1.9.1
When I

use {% include "user_media/partials/image_upload.html" with object=request.user.get_profile field='logo' mode="single" show_main_thumb="True" %}

@Mark-Shine Please install django-libs==1.66.13 and try again

@Tyrdall  yeah I have upgrade to 1.66.13 but still get this error

@Mark-Shine Can you send me the output of pip freeze?


Fix podman-remote to user default username

Currently, you have to specify the username every time, rather than default like SSH does.
Signed-off-by: Ashley Cui<EMAIL_ADDRESS>

@baude  @jwhonce  PTAL

/approve

LGTM

/lgtm


Loosen Bunny dependency to minor version

Sneakers is currently locking us into a version of Bunny we don't want to be using because the version dependency is tied to the patch-level. Is there a reason for that?
Currently we're locking people into patch versions of Bunny when the project clearly seems to be using SemVer and shouldn't have API breaking changes in minor versions. So this change should make sense.
See: https://github.com/ruby-amqp/bunny/blob/master/ChangeLog.md

@michaelklishin could you review and/or merge this? Merging it would allow people to benefit from the queue declaration timeout fix in Bunny 2.12.
See:

https://github.com/ruby-amqp/bunny/pull/566
https://github.com/ruby-amqp/bunny/issues/558

Thanks 🤗

Any update on this? It would be really good to be able to use the most recent version of Bunny

@gabrieljoelc Any way I can help you cut a release for this?

I would also be happy to help, if anything is blocking the creation of a new release including this change.

@olivierlacan @lucaong thanks for the offer! i started going through the commits that are different between the last release and master but didn't have time to finish and build a changelog entry.
If you are able to help with this, that'd be great. Can you go through those commits and create a PR for the changelog for the new release? If you are able to, can you add any necessary updates to the readme as well please?
Looks like we are behind on release tags/"releases" and published gem versions for 2.8.0 and 2.10.0. If you guys can focus on the changelog and start discussion about the semver number the next release can be, I can try to backfill the other two versions this weekend.
Thanks again for your generous offers!

@gabrieljoelc and @olivierlacan, I just compiled a list of changes for the changelog and sent a PR: https://github.com/jondot/sneakers/pull/378
Feel free to comment on it and let me know if anything is missing


Typo in repo name

Currently shows as wg-digitial-identity-attestation  rather than wg-digital-identity-attestation - an extra "i" in digital

Whoops! Fixed.


WIP / RFC - ZHA component rewrite (DO NOT MERGE)

The intent of this PR is to split Zigbee from HA stuff in the ZHA component and to make the zha component easier to test so that we can cover it with a true test suite. Doing this should allow us to have a better internal model in the ZHA component and it should prevent us from running into (read: implementing / causing) things that violate the HA architecture. There is no added functionality in this PR.
Points of interest:

core/listeners contains most of the zigbee interaction
listeners don't directly touch entities... all data is pushed via dispatchers
entities can reach into a listener to retrieve state as they see fit
the HA component modules have been streamlined and simplified and only deal with HA stuff
the api has been updated to work with the new internal model but it is not in it's final state. It hasn't been cleaned up the way the rest of ZHA has. It will be the next thing tackled if these changes are welcomed
there is a clear and consistent life cycle for zigbee device joining/restoring and entity creation. I'll document it and attach it to the PR

EDIT
I know this PR is humongous and I am sorry for that... If the changes are accepted I'll do my best to find a way to find a way to fracture this into smaller PR's. Given how things are fundamentally different I am not sure how easy this will be to do.

I suggest the next move is to write tests for each platform, also in separate PRs.
If we write them correctly, using the core and depending on the entity state for assertion, they should not be impacted by the refactor. See the recent PRs for homekit_controller for examples, where we could refactor while keeping tests untouched.
When we have tests for all platforms merged, we can be much more confident when looking at the refactor diff.

@MartinHjelmare done and this has been rebased. Next steps?

There are some changes now in the platform tests. Can we isolate those changes to separate PRs?

@MartinHjelmare no, the refactored core implements the HA available property on entity which causes the default state to be unavailable. That is the only difference in 4 / 5 of the tests. There is a difference in expected state for lights on a few operations that I am still unsure as to what the “expected” functionality is. It is specifically related to level handling and I have to refer to the ZCL specs to identify what the expected outcome is. You can ignore that for now.
I guess I could technically remove the available property and implement that later but in my opinion it is a fairly innocuous change and i’m not really sure it adds any risk here... thoughts?

Please avoid all not needed changes. So break out the availability to a later PR.

@MartinHjelmare done

I'll start looking at this now. If I found anything more I think we can break out, I'll let you know.

@MartinHjelmare agreed completely... I have a plan for the API. THat is the only thing accessing entities and is only for backwards compatibility on the rewrite. I will have another PR fixing that once this is merged that will make everything work off of IEEE and device instead of entities. It requires compensating front end changes as well so I wanted to keep it separate for now.

@MartinHjelmare I had an idea... Entities are gone from the gateway (and all zha code that isn't a platform) LMK what you think.

shoot... wasn't paying attention

Are we done? 🚀 :smile:

@MartinHjelmare I have to run a round of testing at home... All the changes from today were done remotely. I would like to test removing and joining devices and the config UI to make sure the last set of changes were good. If everything pans out we may be..

@MartinHjelmare I think we're good here. I'll have a quick followup after this is merged for the availability change and another shortly after for the cleanup of the API. Thanks for everything!!!

What are the breaking changes? Please highlight those in a paragraph in the PR description for the release notes. Then we can merge.

@MartinHjelmare It's the availability stuff... Can I just document that in the next PR. I'll have it opened shortly after this merges. Otherwise, it will get documented one way here now and then a different way in the next PR and that will be confusing...

Ok. But then maybe we should remove the breaking change label? If we don't document it here, there's no point in adding the label, I think.

That's fine

battery now on device entity instead of separate sensor entity
device entity now using HA available property so instead of 'offline' and 'online' states are 'unavailable' and 'online'

I was wondering why my smart plugs are showing only 4 or 5 Watt whereas it should be 40 or 50 Watt. In homeassistant/components/zha/sensor.py if found the following:
def active_power_formatter(value):
    """Return the state of the entity."""
    if value is None:
        return None
    return round(float(value) / 10, 1)

Why is the power divided by 10?

@martin3000 please don’t comment on closed pull requests. There is an issue open already to address this. It should be in one of me next few releases.


Crafting Station dupe bug with TFC

The crafting station seems to duplicate some items like Terrafirmacraft food.
If you insert for example a piece of cheese of 160oz (full stack) with its native tags of:
terrafirmacraft:item.Cheese.withTag({foodWeight: 160.0 as float, foodDecay: -3.39 as float, decayTimer: 10456})
The Crafting Station return back to you a piece of cheese with these tags;
terrafirmacraft:item.Cheese.withTag({foodWeight: 999.0 as float, foodDecay: -21.2254 as float, decayTimer: 10455})
that's bad because that piece of food can be inserted in the crafting grid and give an infinite ammount of other pieces of cheese that have weight equal to 160oz
Could this be fixed by prohibit/disable the insertion of food in the crafting station?
I've tryed to make this through MineTweaker, but
even with
mods.betterstorage.CraftingStation.remove
and
mods.betterstorage.CraftingStation.removeShapeless
and so on..
minetweaker still says that are not valid functions (so it's not a correct syntax)
isn't still possible at all?
minetweaker wiki says that "Each of these handlers can have recipes added or removed"

That's unfortunate. I'm a big fan of TerraFirmaCraft but I dropped BetterStorage development / support a long time ago. I liked the Crafting Station and the way I made it work, though it's difficult to impossible to support every kind of crafting. Especially crafting hooks, which I guess is what breaks things in this case. One of my guesses is that the food stacks are being added up and modified in the crafting grid directly or so.
The MineTweaker wiki probably means that you can add and remove specific recipes, but I don't think you can blacklist regular crafting recipes that also work through the Crafting Station.

Mhm, this is  sad :<
Well, I could suggest to look into the code of another mod called Avaritia eventually (if you have the wish and the time, naturally), because the avaritia crafting table for example doesn't allow other crafting to be made inside of it fo example, not sure btw if what I said have a sense at all.. meh
It would have been awesome if there was a config option to disable all the other crafting in the crafting station (except for the better storage one).. that would be a good solution.. unluckly I'm too poor on java skill to merge a new commit :l

Since just adding a config setting for disabling Vanilla crafting in the crafting station is pretty easy, I compiled a new version just for you~ ❤ Here is the new build.
Ideally of course, I'd fix the actual bug, which would require lots of debugging work and there's not even a guarantee that it can be fixed sensibly. The next better alternative is having a blacklist that disables certain Vanilla recipes, but even that is a bit more work than I'm currently willing to put into this technically abandoned mod.

Yay! Thank you so much!!
This seems to work even with other recipes, they are disabled as well :D
So, I guess that I could just add through minetweaker the recipes that I truly want allow in the crafting station, right?
Btw sorry for the late in this reply, I've got and actually still have some trouble with the internet provider :/

Yes, you can manually add those recipes again as crafting station specific recipes.
It's a bit sad, since you basically lose the autocrafting ability (if you were using that) for all Vanilla recipes unless you painfully add every one you want to use it for. But from the sounds of it you weren't so that's cool!

Yeah don't worry ^^
I was using the crafting station as a custom crafting table to justify more advanced recipes (those that realistically talking could not be done without a proper support), and that support is the crafting station (with a new custom texture) :D
it's great to make a "progression" in technology :)

it's great to make a "progression" in technology :)

I love that part! Used it way back in my more difficult (early game) progression focused pack, myself.
Are you going to use the crafting time / experience cost requirement for your crafting recipes?

Not really, at least, I would never do it upon vanilla exp since you lose it on death.. even if you gave me some idea.
Actually the system is just based on "common sense", with terrafirmacraft as the base, then you need the crafting station to begin to craft the mechanical components for flaxbear steampower, then you can do the rest on the rolling machine to unlock immersive, then you'll unlock the avaritia crafting table 9x9 where you can create tungsten components  for the more advanced mod (you know, tungsten it's an hard metal) :P

Sounds like it might be right up my alley. Is it already available? Or can you let me know when it's out?

Sure thing! :D I would be glad to hear your opinion about it!
It still has not an official release actually, I'm still working on it, but it has an alpha release, you can beta-test that anyway if you like :)
if you don't mind to add me on Discord it would be easier, I would prefer to not publicize the download yet link if possible
You can find me as Mohandar #3956


style: separate shell command arguments

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

This pr makes changes to audit to detect issues revolving around Utils.popen_read. These changes were discussed in more detail in https://github.com/Homebrew/homebrew-core/pull/55682 (mostly after the pr was closed).
Change:

Use Utils.popen_read "foo", "bar" instead of `Utils.popen_read "foo bar"

This already exists for system. All that needs to be done is to extend this to Utils.popen_read and Utils.safe_popen_read. This ensures that the command is executed directly and a subshell isn't spawned (see this comment)

Question:

For number 2 above, audit only catches system "foo bar" not system("foo bar"). Should this apply for system("foo bar") as well? As far as I can tell the parenthesis are optional so I would think that audit should catch this as well.

good_system should be named good_args; bad_system should be named bad_args.

Thanks for the catch. Will do.

Looking good! I'd suggest opening a separate PR for each of the 1.2.3. items that you've enumerated above, in which case, we merge this PR as is!

Looking good! I'd suggest opening a separate PR for each of the 1.2.3. items that you've enumerated above, in which case, we merge this PR as is!

Sounds good to me. Do I need to write tests for any of these changes?

Also, before this is completed, I see that there are other "popen" methods that this doesn't cover. These include popen_write, safe_popen_write, and popen. Should these also be added to this audit?

Improved tests are always good! The tests live here: https://github.com/Homebrew/brew/tree/master/Library/Homebrew/test

Also, before this is completed, I see that there are other "popen" methods that this doesn't cover. These include popen_write, safe_popen_write, and popen. Should these also be added to this audit?

Makes sense to me!

Sorry, another question for this one: Should the regex check for Utils.popen_read or just popen_read? I'm thinking that adding Utils prevents anything weird where someone might define their own function called popen_read that could conflict. This might be too much of an edge case.
I'm going to remark this as a draft until I finish these changes

Concerns as of now:

I'm not sure how this will handle things like Utils.popen_read({ "SHELL" => "bash" }, "foo bar")
The rubocop message seems to not work quite right with strings that have "#{foo}" in them.

Example: Utils.popen_read("#{bin}/mmctl completion zsh")
brew style output: C: 43: 34: Use Utils.popen_read "/mmctl", "completion", "zsh" instead of Utils.popen_read "/mmctl completion zsh"
Running rubocop -a, however, fixes to Utils.popen_read("#{bin}/mmctl", "completion", "zsh") which is correct.

This works for both system "foo bar" and system("foo bar"), but the suggested change never uses parenthesis (because I hardcoded it not to). Is there a way to have it match the existing style (i.e. system "foo bar" => system "foo", "bar" and system("foo bar") => system("foo", "bar"))?

I think not using parens is actually desirable here.

Only the first argument is affected right now. This means that system "foo", "bar baz" won't be detected. This has to do with using parameters(method).first for the regex.

This is fine (and actually needed in some cases if you want to pass a parameter with spaces).

I'm not sure how this will handle things like Utils.popen_read({ "SHELL" => "bash" }, "foo bar")

I would look at the second parameter in that case if the first is a Hash.

I'm marking this as ready for review.
A PR is needed in homebrew-core to update the (113) formulae that need to have their styles updated. That might take some time...

As I'm starting the PR for homebrew-core, I've come across the issue of redirection. Currently, system "echo hello > test.txt" works successfully. system "echo", "hello", ">", "test.txt", however, doesn't work correctly. It interprets > as an argument to echo rather than a redirection symbol.
Is there an appropriate way to deal with this while still separating the arguments?
My plan is to have RuboCop only require separate arguments if there are no redirection symbols (|, >, <). How does that sound?

As I'm starting the PR for homebrew-core, I've come across the issue of redirection. Currently, system "echo hello > test.txt" works successfully. system "echo", "hello", ">", "test.txt", however, doesn't work correctly. It interprets > as an argument to echo rather than a redirection symbol.
Is there an appropriate way to deal with this while still separating the arguments?

No, unfortunately. system "echo hello > test.txt" actually does essentially bash -c "echo hello > test.txt" i.e. starts a dedicate shell whereas system "echo", "hello" actually executes the echo binary directly.

My plan is to have RuboCop only require separate arguments if there are no redirection symbols (|, >, >>, <). How does that sound?

Sounds fine to me (at least as a first step)! I would say that pretty much all redirects could be done in Ruby instead (and that might be preferable). The main one I've seen that can't be particularly is redirecting stderr to stdout and matching that output (which is something we use relatively often).

Edit: this issue also applies to other shell symbols such as &&, ||, ;, *...

Again: could be better done in Ruby but fine to punt on at first.

The question becomes: is it worth having the style check if there are so many exceptions?

I think so, personally, particularly if there's an autocorrect for people. For each cop if it ends up fixing a few formulae: that seems like progress to me.

Sounds fine to me (at least as a first step)! I would say that pretty much all redirects could be done in Ruby instead (and that might be preferable).

I agree. Should I aim to add this here or in a future PR?

The main one I've seen that can't be particularly is redirecting stderr to stdout and matching that output (which is something we use relatively often).

I believe you can do Utils.safe_popen_read("foo", "bar", { :err => :out }) which I think will do what you're saying here.

I agree. Should I aim to add this here or in a future PR?

Future PR is fine 👍

I believe you can do Utils.safe_popen_read("foo", "bar", { :err => :out }) which I think will do what you're saying here.

Yup, that'd be nice to use more often!

@MikeMcQuaid I think this is just about ready. It seems to have passed the main CI checks (although, I'm a little surprised it passed the ubuntu-latest test as I don't think the changes have been merged into linuxbrew/core yet...)
Is there anything I can do to pass the codecov/patch check?

Is there anything I can do to pass the codecov/patch check?

Add more tests 😂. It's fine as-is, though!

Thanks again @Rylan12!

although, I'm a little surprised it passed the ubuntu-latest test

Because FormulaAuditStrict is skipped in all CI runs we do.


Dependency updates

This in preparation for releasing datasketches-memory v2.
Updates some plugin versions and cleans up the pom.xml in the datasketches-memory assembly module to better align it with the parent root pom.
For review, it might be easier to disable whitespace changes using the Github review options.

@leerho here is a screenshot of the whitespace option if you are not familiar with it.


cyvcf2 and peddy: Specifications found to be in conflict

I had a working installation of vcf2db before using:
git clone https://github.com/quinlan-lab/vcf2db
cd vcf2db
gemini_conda install -y gcc snappy
gemini_conda install -c nlesc python-snappy=0.5
gemini_pip install -r requirements.txt

but I removed it and cloned the repo again. I noticed you have updated the specification now with peddy and cyvcf2. I am facing a conflict when downloading cyvcf2 and peddy packages.
$ conda install -c bioconda cyvcf2 peddy
Fetching package metadata .............
Solving package specifications: ....

The following specifications were found to be in conflict:
  - cyvcf2
  - python 3.5*
Use "conda info <package>" to see the dependencies for each package.

$ conda --version
conda 4.1.11

$ python --version
Python 3.5.2 :: Continuum Analytics, Inc.

Isn't cyvcf2 python2 dependent and peddy is python3?

I just tried this and it works for me:
Fetching package metadata ...........
Solving package specifications: ..........

Package plan for installation in environment /anaconda:

The following NEW packages will be INSTALLED:

    cyvcf2: 0.5.3-py27_0 bioconda
    peddy:  0.2.5-py27_0 bioconda

Proceed ([y]/n)?

Linking packages ...
[      COMPLETE      ]|######################

it looks like the conda you are using is using python3 by default. Can you show the output of conda list | head to verify?

It is using python 3.5 by default.
 packages in environment at /home/rathik/tools/miniconda3/envs/grinenv:
#
cloog                     0.18.0                        0    asmeurer
gcc                       4.8.5                         3    asmeurer
glib                      2.43.0                        2    asmeurer
gmp                       5.1.2                         2    asmeurer
gsl                       1.16                          1    asmeurer
isl                       0.12.2                        0    asmeurer
mpc                       1.0.1                         0    asmeurer
mpfr                      3.1.2                         0    asmeurer

Using gemini_conda instead of conda switched the env to python2 and it worked. Thanks!

ok. if you find yourself with a python3 conda, you can always use:
conda create --name py2 python=2

to create another environment with python2.


Connection state

By example, some rpc service with persistent connections, typical work is

Connect
Auth
Quering...

At step two we created auth token and bound to socket (all socket's have bounded HashMap, where state saves), how to  impl that via Service?

The rule of thumb is that anything that is socket specific should not be at the Service layer (there are, of course, exceptions). It can be done at the transport layer, which is per socket: https://tokio.rs/docs/going-deeper-tokio/transports/.
That said, it can also be possible to do at the Service layer once NewService returns a future:
impl NewService for MyService {
    fn new_service(&self) -> Self::Future {
        let token = self.token.clone();
        self.proto.new_service()
            .and_then(|s| s.call(Auth(token))
            .and_then(|resp| {
                validate_resp(resp)?
                // return authenticated service
            })
    }
}

So, where are save state between requests?

If you want to save state between requests, you should use an Rc or Arc somewhere. The "somewhere" depends on the details of what you want the state to be shared across.

How to get connection token (e.g. socket handle) within Service? (for creating state hashmap)


Java code that calls/loads DLL in the project

Hallo Jonas,
I am struggling call functions from a dll file from REST api created in Spring Boot. Then I found your project but as I checked the Java code, I could not find the piece of code where the dll lib is loaded or called.
Could you please have a detailed guide on how to do it?
Thank you in advance Jonas!

Hello Jonas, Can you please add piece of code (JAVA) where the dll lib is loaded or called.


Update Timber to 4.1.1

CHANGELOG https://github.com/JakeWharton/timber/blob/master/CHANGELOG.md#version-411-2016-02-19

:+1:


improve docs about most common errors

Is Expected to be running in 'ProxyZone', but it was not found. a common error? I am upgrading to angular 13 and upgrading ng-mocks from 12.5.0 to 13.4.0. This seems to come from importing 'zone.js/testing', which is not a requirement from angular 13 but from ng-mocks 13, so that is why I ask. I am having a difficult time finding any documentation about this error other than it's supposedly related to FakeAsync, which I am not using in any of my tests.

Hi. That's definitely a bug. Thanks for the reporting. I'll fix it in the next release.

v13.4.1 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.


[BUG] Unhandled exception. Npgsql.NpgsqlException (0x80004005): Exception while connecting

What I did to try and fix this:
Edited app_release's settings to be like this
docker_out.log
    ports:
     - "8080:8080"
    environment:
      ASPNETCORE_URLS: "http://*:8080"
      HTTPS_PORT: 4430

docker compose down && docker compose up --build app_release
I checked via sudo lsof -i -P -n | grep :5432,  sudo lsof -i -P -n | grep :8080  and sudo lsof -i -P -n | grep :4430 that the ports are not already in use.
The full log is attached.
FYI: I'm running this on an Quasi-Ubuntu VM (Pop OS Virtualbox), docker by itself seems to work, tested by successful run of docker run hello-world.
The same exact issue also occurs when trying to run app_debug instead of app_release.

Looking into this, yep, definitely an issue.

@rogerfan03 must be fixed now :)

@alexyakunin It's definitely improved a good bit, I am indeed now able to startup the application.
However I'm still unable to actually do much with it because there's a new error.
I've attached the log from docker-compose up --build app_debug below.
dout_log.txt
I'm not sure if there's any more information printed out in the browser page compared to the docker log, if you want/need any more output please simply write me a reply.

Looks like it's a weird issue: https://stackoverflow.com/questions/50843706/data-protection-in-asp-net-core-2-1-only-works-on-one-machine
Interestingly, the certificate is simply hard-coded in this case, but topic starter wrote it saw the same error even when he was loading the cert. from file manually.
Could you try to remove .DisableAutomaticKeyGeneration(); call on  https://github.com/alexyakunin/BoardGames/blob/main/src/Host/Startup.cs#L139 , rebuild the docker containers & run it?

Interestingly, this issue doesn't happen on K8S and my local WSL2-based Docker...

@rogerfan03 ^

Let me know which of these options work - I'll make it default than... A custom cert. is used to make sure every machine in the cluster is able to encrypt/decrypt auth cookies, so nothing bad will happen if you don't do this while running the service on the same machine.

@alexyakunin I commented out line 139 and moved up the ; as you've asked and after that I ran docker-compose up --build app_release and it seems to have worked, I was now able to open it and login with my github in http, not https, https leads to an error Error code: SSL_ERROR_RX_RECORD_TOO_LONG.
But all in all I think it seems good. Thanks for the help and thanks for making this.


Update TEMPLATE.md

fixed typo

@mme can u check this

Thank you, @kushal34712, for the contribution!


Error when setting up plex_assistant

I just switched to v1.0.0 and I've followed the guide on how to migrate removing any old configuration.
I'm using IFTTT to trigger plex_assistant. I double-checked that the new guide hasn't changed anything from the old configuration regarding setting up the action in IFTTT (not in HA, which was already taken care of by following the migration guide).
HA's Plex integration is working. I can see when somebody is watching on HA.
The issue is not command-specific, rather starting the component itself.
Follow the error shown on HA (I don't have the conversation integration installed):
021-02-11 14:03:07 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry None for plex_assistant
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 239, in async_setup
result = await component.async_setup_entry(hass, self) # type: ignore
File "/config/custom_components/plex_assistant/__init__.py", line 96, in async_setup_entry
ifttt_listener = await listeners(hass)
File "/config/custom_components/plex_assistant/helpers.py", line 59, in listeners
await hass.services.async_call("conversation", "process", {"text": "tell plex to initialize_plex_intent"})
File "/usr/src/homeassistant/homeassistant/core.py", line 1405, in async_call
raise ServiceNotFound(domain, service) from None
homeassistant.exceptions.ServiceNotFound: Unable to find service conversation.process

The section conversation setup in the README seems to imply that it's optional and not required for plex assistant to work. Especially since the old version didn't need this integration.

"seems to imply that it's optional and not required"
It should be, I'll get a fix in soon

Should be good in 1.0.1

Thanks! By any chance, do you know how long it takes since published to show in HACS?

For an installed item:

At startup
Every 30 mins after startup
When you manually reload the item

https://hacs.xyz/docs/basic/updates


Vikunja update wont save data

Please verify that you have read and understood the guidelines.
yes
A clear and concise description of the issue.
After using the Vikunja update script the data is deleted.
It seems the folder /opt/vikunja is completed removed and the data is not saved somewhere else during the update.
What settings are you currently utilizing?

[ ] Default Settings
[ ] Advanced Settings

Which Linux distribution are you employing?
Debian 12
If relevant, including screenshots or a code block can be helpful in clarifying the issue.
No response
Please provide detailed steps to reproduce the issue.
Just run the update script and check for the already existing data.

I can confirm as someone who runs Vikunja but without the script. The default configuration is to store the database and the uploaded files in the /opt/vikunja folder. Perhaps the config should be modified upon install to have the db and files in /etc/vikunja where the config is located.


DAT-17463  DevOps :: update test-harness CICD workflow in BigQuery extensio

chore(test-harness.yml): add action-workflow-queue step to manage workflow execution order

@jandroav will it also work if we add Foundational to the matrix? Line 81
  strategy:
      matrix:
        liquibase-support-level: [Foundational, Contributed ] # Define the different test levels to run
        ```

@KushnirykOleh what I added is to prevent infra issues which was the original issue here. What you say can be fixed by adding:
    strategy:
      max-parallel: 1
      matrix:

as seen here https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#defining-the-maximum-number-of-concurrent-jobs right?

@KushnirykOleh are you ok if I add the following?
   strategy:
      max-parallel: 1
      matrix:


Fixed spring form encoder for multiple MultipartFile

If I need to send several files with the same name, only one of them will be sent now. This request resolves this problem in the encoder by grouping files with the same name.

@xxlabaza you can suggest whether it is planned to up the Java version from 6 to 8? My solution for Java 8 is 1 line, but for 6 version much more


fix(cmd/run): secret/configmap as property file

Documentation
Example
E2E test

Closes #1838

Release Note
NONE

The failing check has no relation with this PR changes


Requested: Simple way to change the back-end nitter feeds (to allow self hosted installations)

Hello,
I have stumbled across this as a bit of a feed control for nitter.
I run a local instance of nitter (Which still doesn't have feed control system) and wish for it to be utilised as the backend for this feed system.
I was wondering if you could implement a method of easily adding a self hosted instance into the program?
I think the easiest method would be to add an environment variable to override this part of the default setup in docker.
I have checked your files and this seems to be handled within;
https://github.com/pluja/Feetter/blob/fdf20af78c53377ec8146756536d37901055f0ee/feetter.py#L36
I could edit it myself but then I need to fork/maintain it which would seem silly as well as it would allow other privacy conscious persons to use their own instance, further increasing user uptake.
Cheers.

Right now I'm on vacation. I will add this when I return.

Cheers


[BUG] AzureMonitorExporter marks 404 response as errors, even if explicitly marked as successful in OpenTelemetry

Library name and version
Azure.Monitor.OpenTelemetry.Exporter
Describe the bug
My webapi yields a 404 response when the requested data cannot be found. In my case, this is not supposed to be marked as an error when exporting the OpenTelemetry data to ApplicationInsights.
As suggested in various other places, I have added an EnrichWithHttpResponse to the AddAspNetCoreInstrumentation to manually change the activity's status to ActivityStatusCode.Ok.
builder
    .AddAspNetCoreInstrumentation(options =>
    {
        options.EnrichWithHttpResponse = (activity, response) =>
        {
            if (response.StatusCode == 404)
            {
                activity.SetStatus(ActivityStatusCode.Ok);
            }
        };
    })
    .AddConsoleExporter()
    .AddAzureMonitorTraceExporter(options =>
    {
        options.ConnectionString = "<my connection string>";
    });

However, I'm still getting my 404 responses marked as errors in ApplicationInsights, even though the console exporter clearly shows the status of the activity to be marked as successful.
Expected behavior
I would expect the manually set activity.Status to be respected here, rather than it being overridden by interpreting the response code. It would still make sense to look at the response code when the value of activity.Status is ActivityStatusCode.Unset, but not when the activity.Status is set to AcitivityStatusCode.Ok.
Actual behavior
In the ApplicationInsights exporter, the Activity containing the 404 response is transformed into a RequestData, where the Success property is determined by the IsSuccess function.
https://github.com/Azure/azure-sdk-for-net/blob/a18e7016ca4692a9657b996b3f9090d7a8587119/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Customizations/Models/RequestData.cs#L54-L67
Since the operationType is an http call and the response code is set to 404, the if-branch applies, evaluating the value for isSuccessStatusCode to false and making the function return false, even though activity.Status != ActivityStatusCode.Error evaluates to true.
In this IsSuccess function is where I would expect the predetermined activity.Status to be respected. Perhaps the function should be something like
internal static bool IsSuccess(Activity activity, string? responseCode, OperationType operationType)
{
    if (activity.Status == ActivityStatusCode.Unset
        && operationType.HasFlag(OperationType.Http)
        && responseCode != null
        && int.TryParse(responseCode, out int statusCode))
    {
        return statusCode != 0 && statusCode < 400;
    }
    else
    {
        return activity.Status != ActivityStatusCode.Error;
    }
}

Reproduction Steps
See bug description
Environment
No response

Any updates on this? Not sure what the process/next step is. Do you want me to create a PR for this with my proposed solution?

@rvanheest - Apologies for the delay. I think the change you have suggested is reasonable. Would you be able to create the PR for this?

@vishweshbankwar sure, here you go - #43594


Techdocs - Don't Copy docs/README.md -> index.md if it is provided

MkDocs allows you to use a README.md in place of an index.md:

Many repository hosting sites provide special treatment for README files by displaying the contents of the README file when browsing the contents of a directory. Therefore, MkDocs will allow you to name your index pages as README.md instead of index.md. In that way, when users are browsing your source code, the repository host can display the index page of that directory as it is a README file. However, when MkDocs renders your site, the file will be renamed to index.html so that the server will serve it as a proper index file.

If both an index.md file and a README.md file are found in the same directory, then the index.md file is used and the README.md file is ignored.

https://www.mkdocs.org/user-guide/writing-your-docs/

As the above mentions, if an index.md is detected, the README.md is ignored. https://github.com/mkdocs/mkdocs/pull/1582
If a docs/README.md is provided, TechDocs should not copy this file over to an index.md file, as this breaks rendering of the docs. (Using README.md as a reference in mkdocs.yaml)
Since all of the fallbacks are variants of README.md(docs/readme.md, README.md, readme.md), I was considering copying this file over to docs/README.md instead of docs/index.md. However, this would further break the implementations of user's who are referencing index.md in their mkdocs.yaml files, and relying on the patch/copy. To be clear, this will break any implementations that supply a docs/README.md, expect the patch/copy to happen, and use a reference to index.md in their mkdocs.yaml file. For example:
ls docs/ -> README.md (No index.md file provided)
mkdocs.yaml
site_name: Hello
site_description: Hello World
nav:
  - Home: index.md
  - User Guide': user-guide.md
plugins:
  - techdocs-core

^ That would break with this change. But I think it makes sense to enforce the reference of README.md for these cases, as that is what is expected in the MkDocs documentation.
mkdocs.yaml
site_name: Hello
site_description: Hello World
nav:
  - Home: README.md
  - User Guide': user-guide.md
plugins:
  - techdocs-core

^ Works
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

To try and further illustrate this issue:
Here is the example mkdocs.yaml file running locally:
site_name: Random
site_description: Random Documentation
nav:
  - 'Home': 'README.md'
  - 'User Guide': 'user-guide.md'
plugins:
  - techdocs-core

/docs contains -> README.md user-guide.md
When viewing the Docs page for the related component:

^ As you can see, the README.md contents load in fine, because they were copied over into an index.md. But you can also see that the nav-link is referencing 'README.md', which MkDocs has now discarded (because an index.md was found alongside README.md in the docs/ directory).
Clicking on that link:

If you load the Docs initially, and click the 'Pencil' to edit them, it will direct you to https://github.com/{ORG}/{REPO}/edit/{BRANCH}/docs/index.md, which won't exist because an explicit index.md was not provided, and thus lead to a 404.

Leaving this to @backstage/techdocs-core to review, but noting that you're missing a changeset for this.

Changeset has been added

@iamEAP Your understanding of the problem is spot-on.

If all of that checks out! I wonder if there's a path forward that doesn't involve a breaking change.

Let me see what I can come up with. Thanks for the review!

@iamEAP Your understanding of the problem is spot-on.

If all of that checks out! I wonder if there's a path forward that doesn't involve a breaking change.

Let me see what I can come up with. Thanks for the review!

Hi guys, did you come up with any other ideas? I'd like to follow along, please let us know when you're ready for review again 🙂


Feature Request: Modify Schedule to fetch feeds

Hi,
for selfhosted newsblur instances it would be nice to adjust the schedule how often the feeds are being fetched.
Thank you!

You are free to adjust the settings for when feeds are fetched as part of https://github.com/samuelclay/NewsBlur/blob/master/apps/rss_feeds/models.py#L2119-L2215. You can simply as a 2 * minutes to extend the schedule, or vice-versa.


Add support for Adobe Brackets editor

Any plan to add support for Brackets ?

Brackets uses a fork of CodeMirror. I'm not sure whether that fork breaks compatibility, but when I responded with this to similar requests, users seemed contempt with the answer. If you give it a try, let us now if it worked!

Update: I downloaded the Mac version of Brackets and took a look at the package. Looks like all the default CodeMirror themes are included:


Event names no longer support dashes

Description:
Inside templates, events handlers that are bound to an event name with dashes no longer trigger.
Versions affected:
0.8.x
Reproduction:
I expect to see both "COMPONENT" and "VIEW" logged to console.  This only happens for 0.7.3.  For 0.8.2, it only logs "COMPONENT".
0.7.3: https://jsfiddle.net/6zx12ufu/
0.8.2: https://jsfiddle.net/Le3fhgo8/1/
Code:
HTML

JS
var Component = Ractive.extend({
  oninit: function() {
    this.on("event-with-dash", function() {
      console.log("COMPONENT");
    })
  },
  template: "#component"
});

new Ractive({
  components: {
    Component: Component
  },
  el: "main",
  oninit: function() {
    this.on("event-with-dash", function() {
      console.log("VIEW");
    });
  },
  template: "#template"
});

This is odd. According to the docs, on-event-with-dash should subscribe to three events: event, with, and dash - see http://docs.ractivejs.org/0.6/event-directives.
Is the issue that only DOM events should allow - separators for multiple events? So component events should not split on - when listening to events? If that's the case, it's an easy fix.

This does look like it goes in the category of "things that worked but really shouldn't have".  Can we have better error messaging around this?  If event names shouldn't contain dashes, it would be nice to get an error when attempting to bind to an event like that.

I agree that having different meanings in different contexts that look the same is not a good idea. That's probably why I assumed that component events should behave like DOM events and accidentally introduced the breakage in the first place :disappointed:
I'm not sure that there's a good way to warn in this particular scenario, unless we warn when you ractive.fire('some-dashy-event'). That seems like a legitimate use of the API, though.

Multiple events with a dash looks strange. I still prefer regular HTML style events, one each even when pointing to the same handler. Less magic to think about. Break for 0.9?

I have no particularly strong feelings one way or the other, but I will say that
 is quite a bit more convenient than the long form. I have used that a time or two.

I'm not sure that there's a good way to warn in this particular scenario, unless we warn when you ractive.fire('some-dashy-event').

Yes, I think the framework should.  If this won't work:
<button on-some-dashy-event="@this.doThings()">Click</button>

then it would be helpful if this.on("some-dashy-event", this.doThings) and this.trigger("some-dashy-event") also did not work.  That enforces the same naming conventions for all events, regardless of individual usage.


how to  use  custom  sticky header ?

how to  use  custom  sticky header ?

What do you mean? Just a different view than the ones used by other items in your RecyclerView? However your would normally setup headers should work, just make the items in your data set that you want to be sticky implement the marker interface StickyHeader.

Going to close this for now. If you are having a specific issue let me know.


Can't see device information for Wahoo Fitness Bluetooth LE Balance Scale

I'm running the code here on Chrome 42 on Mac OS X 10.10:
https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/bluetooth-samples/device-info-demo
but after starting discovery, I never see any connected devices. I have a Wahoo Fitness Balance Scale that's BTLE but I'm not sure if there's something else I need to do to get it to talk.
The device is functional over BTLE as I can see it on the light blue bluetooth debugging app on my iphone. I've tried to figure out if it responds to the 180a device information block, but I'm not sure.
Thanks!

Bluetooth Low Energy only works on Chrome OS for now.
You might want to follow https://code.google.com/p/chromium/issues/detail?id=449682 to keep track of the work the chromium team is doing on Mac OS.


Use culture-dependent string for decimals in RuntimeMetadataTests

GetRuntimeMetadata returns strings containing decimals in the format of the current culture, so 2.1 would become "2.1" in an English culture but "2,1" in a German culture, for example. However, the tests use a hard-coded string "2.1", causing the tests to fail when the current culture uses a comma for decimals. While the tests pass on the build servers because they use an English culture, they can fail when run locally during development.
This PR might not be the best solution - maybe GetRuntimeMetadata should return a culture-invariant string, or all the unit tests should automatically run in the invariant culture regardless of local settings - but it does work around the immediate issue for me.

Oh that's interesting, I didn't know decimals are represented differently based on locale. This LGTM, thanks Sarah!


envoy: set so_reuseport

Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>In preparation for new defaults, set SO_REUSEPORT on virtual listener sockets. This enables kernel load balancing for TCP accepts instead of in-process implementation. The high risk area is hot-restart which is not used in istio.
Ref: https://github.com/envoyproxy/envoy/pull/17259

@kyessenov: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
bff26c573cbdb4e503b2d50c35fee75bd798b1d1
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@kyessenov is this to start testing istio with this change before the change lands upstream?
I think we will need to provide a way to use old behaviour if there are any gremlins later.

@kyessenov: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
bff26c573cbdb4e503b2d50c35fee75bd798b1d1
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I think it's a safe change on Linux. This is only affecting sidecars with a few workers and isolated network namespaces. It's less restrictive so it's unlikely to break someone. The only issue might be kernel interaction but it's been long enough that widely popular kernels are up to date.

/retest

Putting hold so more people provide feedback.

@kyessenov: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
bff26c573cbdb4e503b2d50c35fee75bd798b1d1
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest
@howardjohn What other listeners do you have in mind? Ingress might be interesting but given that it's usually high concurrency, there will be significant behavior changes. Sidecars are usually not using all cores. Health endpoints should not be shared I think between multiple envoys since that defeats their purpose.

I was thinking of gateway specifically. My understanding is once the envoy
PR merged those will start using reuseport?
So it seems like that's either a good thing and we can explicitly enable it
not to get some early testing, or it's not a good thing and we should
explicitly disable it?
I am fine with not doing it in this PR, I was mostly just curious if it was
intentional not set
On Thu, Jul 8, 2021, 8:25 PM Kuat @.***> wrote:

/retest
@howardjohn https://github.com/howardjohn What other listeners do you
have in mind? Ingress might be interesting but given that it's usually high
concurrency, there will be significant behavior changes. Sidecars are
usually not using all cores. Health endpoints should not be shared I think
between multiple envoys since that defeats their purpose.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/33921#issuecomment-876885006, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXNN476H4JA4TWER7E3TWZT2ZANCNFSM5ABUHBUQ
.

@howardjohn There are more unknowns unknowns with gateways so we need to keep it separate. We should probably do it, but I'm not as confident that it won't break someone as this change.

@kyessenov: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
bff26c573cbdb4e503b2d50c35fee75bd798b1d1
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@kyessenov: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
bff26c573cbdb4e503b2d50c35fee75bd798b1d1
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

multi-cluster tests are very flakey.
/retest

@kyessenov: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
bff26c573cbdb4e503b2d50c35fee75bd798b1d1
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

6 times and counting
/retest

Given https://github.com/envoyproxy/envoy/pull/17259 merged, do we still need this?


chunkwm can't tile alacritty when decorations: false

Which operating system does the issue occur on? macOS 10.13.6
When using chunkwm and windows/decorations: false, alacritty appears as a small window that chunkwm is unable to move or resize.
This was reported for iTerm2 with no title bar in koekeishiya/chunkwm#92, and was resolved by upgrading iTerm. I assume therefore that this is not a chunkwm bug per se, but that there's something alacritty can do to not break it.
I've asked for more information in the above issue, as I don't know what the cause would be or how iTerm fixed it.

Summary from that issue:
With decorations:
subrole: AXStandardWindow
resizeable: 1

Without:
subrole: AXUnknown
resizeable: 0

chunkwm author says:

These properties are queried from the macOS accessibility API.
Regarding the subrole, I'm not completely sure how that is set by the applications, but this can be worked around using the rules-system implemented in chunkwm, and is not a big deal.
The real problem here is that the window is not marked resizable. The reason for this is that the windowing toolkit that Alacritty uses does not set the NSWindowResizableMask to the NSWindow's styleMask.
Most frameworks that I've seen have this behaviour (god knows why..) when the window titlebar is disabled. GLFW used by the Kitty terminal had the same issue, however the Kitty developer made the hide_titlebar option re-add the missing NSWindowResizableMask manually. as the GLFW API exposes the underlaying NSWindow if desired.
The author of Alacritty could probably fix this the same way.

This sounds like rather than fixing it in Alacritty, this should be fixed in winit.
Would you mind testing if this also happens with winit using one of their examples (they can be run using cargo run --example <NAME>)? If these have the same problem then opening an issue with winit is probably going to be the most beneficial.

i fixed this in https://github.com/jwilm/alacritty/pull/1241, but i stopped maintaining the branch after https://github.com/jwilm/alacritty/pull/1241#issuecomment-395887745
Once that merges, I'll probably also wait for https://github.com/jwilm/alacritty/pull/1403 to merge and rebase from there.


refactor(Radio): Decouple the radio from the radio-group component.

For #626, #609

Going to close this since it would be rebase hell now. We will revisit this someday!


Generate bower.json file from based on the assets component config file

The assets component has the hability to store bower dependencies and map them to a proper static handler so it can be accessed on the web.
It would be good to have the hability of generate a bower.json file from those dependencies mapped on the assets component config file istead of managing dependencies in 2 files.

This is way out of the scope of this project.
We don't control and don't plan to control any javascript framework. Bower is obsolete and we're moving everything to yarn but this must be handled by other projects and by firenado.

This is way out of the scope of this project.
We don't control and don't plan to control any javascript framework. Bower is obsolete and we're moving everything to yarn but this must be handled by other projects and by firenado.


Known Vendors Panos - pan:decryption

We have a sourcetype showing up.  SC4S seems to recognize it, but there is not a key to direct the data to an index
The sourcetype is pan:decryption
Requesting a key to match pan:decryption sourcetype
1,2023/02/24 18:36:16,012501002896,DECRYPTION,0,2561,2023/02/24 18:36:01,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,Whitelist-AppId,,,incomplete,vsys1,Corp.Trust,Internet,ae8.1851,ae7.2851,Panorama,2023/02/24 18:36:01,34757090,1,64779,443,9386,443,0x1400000,tcp,allow,N/A,,,,,11d42847-c7bd-4432-95e4-de345c0683c8,Unknown,Client_Hello,TLS1.2,,,,decrytpme-3rd-categories,,Protocol,uninspected,Uninspected,Forward,,,,,V1,0,0,0,0,0,:::::NONE,,,,,General TLS protocol error,,,,,,,,2023-02-24T18:36:01.834+00:00,,,,,,,,,,,,,,,,,7107092619227871007,0x8000000000000000,1634,2261,1619,0,vsys1,AT1FW01,1,unknown,unknown,unknown,1,,,incomplete,no,no

@Jaxjohnny,
Please help us with latest raw messages to check and validate.
Also, as per pan docs, below would be the values:
Key: pan_panos_decryption
Sourcetype: pan:decryption
Default Index: netops
Please confirm the above values

@Jaxjohnny,
We have not heard anything from you. Hence we are closing this issue for now.
Please let me know in case of any further queries.
Thank you.

@bparmar-splunk I believe this is still a persistent issue. The parser for the DECRYPTION is missing a number of key value pairs. I'm also running into this issue and get the following error when referencing the key (as you mentioned earlier):
A filter referenced by the database is not found in the filters file; filter='“pan_panos_decryption
Thanks you.


normalize AQL filter conditions, so that attribute accesses are normally placed on the left hand side of the condition

Scope & Purpose
Normalize filter conditions so that attribute accesses are normally on the left hand side of the condition. This will turn 3 == doc.value into doc.value == 3. This allows for future optimizations and easier handling of conditions.
Note that there will still be condition with attribute accesses on the right hand side, such as doc.value1 == doc.value2.

[x] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[x] The behaviour change can only be verified via automatic tests

Testing & Verification
This change is already covered by existing tests, such as all AQL tests.
https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/4789/

Tests seem to be ok.


Hermes relaying modes: push versus pull relaying

Summary of problem
Some Hermes users are running the relayer with clear_interval = 1. This effectively means that the relayer does not use the WS and scans each chain every block, relaying packets based on the periodic packet clearing functionality.
In general, it's not good to allow users to use Hermes in ways in which is not properly documented and tested, and in environments for which we didn't design it.
I learned about this use-case from a user that was transferring NFTs across networks. They could not rely on the websocket functionality because sending NFTs was done from a WASM contract, which does not emit events tagged with module = ibc attribute, hence Hermes does not catch those events. Similar problem was reported by this other user (https://github.com/informalsystems/hermes/issues/2809), who is also using WASM contracts for triggering transfers.
Proposal
I think we should consider introducing a native feature that allows Hermes to bypass the Websocket and run in a "periodic packet clearing mode" only. For the moment, let's distinguish push relaying from pull relaying (TODO: figure out more appropriate names).

push: the current start functionality
pull: a more basic packet relaying mode that skips the WS connection

one way to think of pull relaying is that it's like batch processing (versus online/push processing)

It's unclear what the pull mode would look like, eg:

new CLI?
keep the start CLI but add an option --periodic or something like that?
investigate also if anything important (client refresh, misbehaviour detection, channel workers) is not functioning correctly in the absence of the websocket, and clarify that pull mode has limited functionality

Next steps
Note the milestone for this is v1.4, so not an immediate priority.
This is just a meta issue to trace some next steps and feasiblity:

[ ] @adizere to gather more feedback from operators on the production use-case for pull-based mode

is this mode could be potentially useful beyond just relaying of packets from WASM contracts?
is is problematic if the pull mode does not accomplish misbhevarior detection, channel or conn. handshakes?
is there any utility in keeping the current push-mode behavior? Likely there is utility in allowing relayers to quickly catch events and relay (i.e., optimize for latency). In the context of relayer fees & MEV, latency is critical.
pull mode is clearly useful for relayers that act as backups (on channels that have a lot of redundancy)

[ ] @soareschen & @ljoss17 and @seanchen1991 to consider the implications and feasibility of a pull-based design in the context of new architecture

is the pull mode possible with v1.5 / v2 ?

[ ] @romac and @ancazamfir to consider the implications of a pull mode in the context of IBC node design
[ ] @ljoss17 to consider the implication in the integration testing framework: the framework would need to support testing of the pull-based mode

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

It sounds like what you want is to have poll-based relaying compared to the current push-based or event-based relaying. For the new relayer design, this should be just a matter of switching from a poll-based event source to a push-based event source. Otherwise, we could implement multiple event source implementations and allow relaying based on contract-specific events.
For the current v1 relayer, we could refactor the init_subscriptions function such that it can switch to spawning background tasks that periodically polls the chain state and send the collected events to the MPSC channel. Alternatively, we could spawn a different task that don't take any event source and periodically only call handle_clear_packet to clear the packets.

Two examples of CW IBC that users provided where the Websocket functionality doesn't work:

https://github.com/public-awesome/ics721/tree/main
https://github.com/0xekez/cw-ibc-example/

@kaisbaccour Thanks for sharing your experience with us! This all makes sense! We are  tracking the issue with wasm events in https://github.com/informalsystems/hermes/issues/3190 and https://github.com/informalsystems/hermes/issues/2809. I am actually working on switching to a poll-based model which eschews the WebSocket stream, which should solve the problem you are seeing: https://github.com/informalsystems/hermes/pull/3209


feat(tests): Upgrade tests to new ceramic packages

This looks related to your recent changes to the filecoin integration @ukstv. Can you take a took and see about fixing jest so it can resolve whatever it needs to?

NVM, I think I was able to get it working by just copying what you did in https://github.com/ceramicnetwork/js-ceramic/pull/1298/files.  Fighting some other issues now


Prune mode in osx

I am trying to switch the prune mode on.
I edited the file ~/Library/Application\ Support/DashCore/dash.conf to:
prune=945
txindex=0

This error pops up when I start DashCore:

Enabling Masternode support requires turning on transaction indexing.Please add txindex=1 to your configuration and start with -reindex

However, when I set txindex to 0, this message appears:

Prune mode is incompatible with -txindex.

I don't know how to -reindex using the GUI or terminal. How do I solve this issue?

Hi, thanks for this! Setting the prune option and enabling the txindex aren't mutually compatible. If you need the full transaction index, you can't also enable pruning.
https://github.com/dashpay/dash/blob/20bacfab9b02e89df7b04c5270c7c7159349f6d3/src/init.cpp#L1005-L1014
But from the first message you posted, it looks like you also have masternode set, which requires the full transaction index:
https://github.com/dashpay/dash/blob/20bacfab9b02e89df7b04c5270c7c7159349f6d3/src/init.cpp#L1868-L1873
... so you can either run as a masternode (requires txindex=1 also), or allow pruning, but not both.
I'm curious as to why you'd want to run a masternode on OSX (as this is 99% of the time a Macbook laptop and not OSX server, meaning it's not in a data center somewhere and has no uptime guarantees).

So, just to clarify/update, apparently we don't fully support pruning, related: #1466, #1817

Maybe can be closed (as long as #1466 is kept open)?

Closing as this is a duplicate of #1466, please track issue status there. This should be fixed once #2014 is merged in.


support for openSUSE

thanks for the cloudwatch plugin, but the setup.py does not work with openSUSE
/home/ec2-user/collectd-cloudwatch/src # ./setup.py
Traceback (most recent call last):
File "./setup.py", line 586, in
main()
File "./setup.py", line 579, in main
install_plugin()
File "./setup.py", line 497, in install_plugin
install_packages(SYSTEM_DEPENDENCIES)
File "./setup.py", line 253, in install_packages
command = DISTRIBUTION_TO_INSTALLER[detect_linux_distribution()] + " ".join(packages)
KeyError: 'openSUSE\nVERSION'
Can we add support?

After https://github.com/turbonomic/collectd-cloudwatch/commit/b871b993ef61f9dcc9ab0df94425dab15dfeffcc, it runs fine on openSUSE, too
home/ec2-user/collectd-cloudwatch/src # ./setup.py
Installing dependencies ... OK
Installing python dependencies ... OK
Downloading plugin ... OK
Extracting plugin ... OK
Moving to collectd plugins directory ... OK
Copying CloudWatch plugin include file ... OK
Choose AWS region for published metrics:

Automatic [us-east-1]
Custom
Enter choice [1]:

Choose hostname for published metrics:

EC2 instance id [i-f552a16d]
Custom
Enter choice [1]:

IAM Role could not be automatically detected.
Enter absolute path to AWS credentials file [/root/.aws/credentials]:
Enter access key: XXX
Enter secret key: YYY
Choose how to install CloudWatch plugin in collectd:

Do not modify existing collectd configuration
Add plugin to the existing configuration
Enter choice [2]:
Plugin configuration written successfully.
Credentials configuration written successfully.
Stopping collectd process ... NOT OK
Starting collectd process … OK