Generates nullable columns incorrectly for HasMany relation

PHP version: 8.0
Package version: v1.0.10
How to reproduce:

User entity:

<?php

declare(strict_types=1);

namespace App\Database;

use App\Database\Typecast\Uuid;
use App\Exception;
use App\Repository;
use App\Database\Column;
use Cycle\Annotated\Annotation as Cycle;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;

#[Cycle\Entity(
    repository: Repository\User::class
)]
class User
{
    use Column\Id;

    #[Cycle\Column(type: 'string(64)')]
    public string $username;

    #[Cycle\Relation\HasMany(target: Comment::class)]
    private Collection $comments;

    public function __construct(Uuid $id, string $username, string $password)
    {
        $this->id = $id;
        $this->username = $username;
        $this->comments = new ArrayCollection();
    }

    public function getComments(): Collection
    {
        return $this->comments;
    }
}

Comment entity

<?php

declare(strict_types=1);

namespace App\Database;

use App\Repository;
use App\Database\Column;
use Cycle\Annotated\Annotation as Cycle;

#[Cycle\Entity(
    repository: Repository\Comment::class
)]
class AuthCode
{
    use Column\Id;

    #[Cycle\Relation\BelongsTo(target: User::class, nullable: true)]
    private ?User $user = null;

    #[Cycle\Column(type: 'string')]
    private string $text;

    public function setUser(?User $user): void
    {
        $this->user = $user;
    }

    public function setText(string $value): void
    {
        $this->text = $value;
    }

    public function getText(): string
    {
        return $this->text;
    }

    public function getUser(): ?User
    {
        return $this->user;
    }
}

php app.php cycle:migrate -r

Results:

P.S. Column Id Trait:
<?php
declare(strict_types=1);

namespace App\Database\Column;

use Cycle\Annotated\Annotation as Cycle;
use App\Database\Typecast\Uuid;

trait Id
{
    #[Cycle\Column(type: 'uuid', typecast: Uuid::class, primary: true)]
    private ?Uuid $id = null;

    public function getId(): ?Uuid
    {
        return $this->id;
    }
}

Results expected as nullable: true.

probably this is the same problem as I faced in this issue https://github.com/cycle/orm/issues/120

Try to add nullable to comments relation
#[Cycle\Relation\HasMany(target: Comment::class, nullable: true)]
private Collection $comments;


chore: remove CHAIN_ID

What it solves
Resolves #3315
How this PR fixes it
Replaces them with string literals. No bueno, but it's mostly tests.
How to test it
Everything should work like before when switching networks.

@iamacook, yes, I'm having second thoughts now.
My initial reasoning was that we should rely on the remote config for anything that deals with chain ids, short names etc.
But on the other hand, chain ids are not likely to change.
The only problem with this enum is it might seem to be exhaustive but it actually isn't. So maybe we should keep only 1 and 4 there, as these are the only networks we're supposed to reference in edge case conditionals.
And now, you're not supposed to memorize them. You're supposed to use the ones that come from the remote config.

The only problem with this enum is it might seem to be exhaustive but it actually isn't. So maybe we should keep only 1 and 4 there, as these are the only networks we're actually referencing in edge case conditionals. And maybe 0 as a non-value.

I originally converted the legacy enum over to an object in order to remain strictly typed. I don't think you can type enums?
I suggest we revert the changes here but also remove all ids in the CHAIN_ID 'enum' that aren't used. We can add to it when necessary.
(I like the DEFAULT_SHORT_NAME change!)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 6 (66.67%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 32.018%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/logic/wallets/getWeb3.ts
0
1
0.0%

src/logic/wallets/store/selectors/index.ts
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
3112

Relevant Lines:
8663

💛  - Coveralls

I've tested all the networks, works like before ✅


Wk1 Hackathon Submission

Team Members' GitHub usernames:
gillybops
girijakumar
MirandaBlair
priyaka-xo
tltyogg
TWHou

Well done on forming a team and working together on the week 1 hackathon!
It’s great that you’ve not only implemented the random world generator but you also ask the user what size world they’d like to create. If the user chooses to generate a very small world then there’s a chance that they could end up with a world with no land tiles on it so, to level up this section of your solution, you could implement a check for if the generated world contains no land tiles and a way to solve this issue.
If you consider the context of this challenge further you’ll see that the goal is to find the 2 largest continents for people to play on so you could level up your solution by searching for more continents after counting the first one. You could then tell the user which continents are the largest for them to play on.
Your function using recursion to implement the boundary fill algorithm is very clearly written and you’ve used comments to great effect which will make your code much easier to maintain in the future.
It’s obvious how much hard work you’ve all put in from how well you’ve written your code. Congratulations on doing such a great job working as a team!


Revert "add BQ datasets blog post"

Reverts m-lab/website#475

This change is

Reverted in order to address reviewer comments.


feat(resource): support s3

iss #475

@saitofun pls add a github/clickup issue to the PR description.

@saitofun pls add a github/clickup issue to the PR description.

added


Static version of EasyHook DLL

In a project I had the requirement to link EasyHook statically.
The pull request contains alll changes to build EsayHook as a static link library instead of a DLL.
I know using the static version of EasyHook with .NET this makes no sense, but using it a native project with C or C++ it's very valuable for not having to deliver the correct EasyHook.DLL with created program.
To use the static version calll the following methods in the main() function (normally this handled by the DllMain method, when the EasyHook DLL is loaded or unloaded into a process).
EasyHookAttach();
<...>
EasyHookDetach();

My work is based on the excellent article of Jerry Wang at Codeproject

Additionally it should be added, that this makes remote injection impossible with current implementation, since it injects the .exe instead of the EasyHook32/64 dll and probably more complicated things I can't talk about

@tmeckel i compiled your static branch successfully, however in my inject app when I try to call EasyHookAttach();, it throws this error:

Error	LNK2001	unresolved external symbol AuxUlibIsDLLSynchronizationHeld   EasyHook64S.lib(barrier.obj)	1
Any idea?

Try to replace the #if with #ifdef
https://docs.microsoft.com/en-us/cpp/preprocessor/hash-ifdef-and-hash-ifndef-directives-c-cpp?view=msvc-160
And ensure that EASYHOOK_STATIC is defined when you compile your program.

@tmeckel I was re-reading the article you linked in Codeproject, and the guy mentioned something about Aux_ulib.lib
I added
#pragma comment( lib, "EasyHook64S.lib")
#pragma comment( lib, "Aux_ulib.lib")
#pragma comment( lib, "psapi.lib")

Now it compiled, however, I did not understand how do you attach the dll to the target process, when I call:
	NTSTATUS nt = RhInjectLibrary(
		_ttoi(processID),                   // The process to inject into
		0,                                         // ThreadId to wake up upon injection
		EASYHOOK_INJECT_DEFAULT,
		NULL,                                 // 32-bit
		dllToInject,		         // 64-bit
		&data,                             // data to send to injected DLL entry point
		sizeof(DWORD)              // size of data to send
	);

RhInjectLibrary failed with error code = -1073741595

@pepeu93 I don't know your exact solution setup, but as I described in the initial Pull Request description you have to add the two following statements to you main method (C++ or C program obviously)
EasyHookAttach();
<...>
EasyHookDetach();

After EasyHookAttach you can initialize your hooks with LhInstallHook.  Ensure that the PreProcessor symbol EASYHOOK_STATIC is set and that you have the following statements somewhere at the top in your .cpp or .c files:
#ifndef _M_X64
#ifdef _DEBUG
#pragma comment(lib, "EasyHook32SD.lib")
#else
#pragma comment(lib, "EasyHook32S.lib")
#endif
#else
#ifdef _DEBUG
#pragma comment(lib, "EasyHook64SD.lib")
#else
#pragma comment(lib, "EasyHook64S.lib")
#endif
#endif

The EasyHook.lib files are the static link libraries for EasyHook.

@tmeckel  Sorry for tagging you, I don't know anyone else who uses EasyHook, I have asked on StackOverflow but got no reply, searched in all issues opened/closed for something similar in which could help me to understand it, and also couldn't find anything,
Would like to ask if you understand this question: https://github.com/EasyHook/EasyHook/issues/390
(Sorry don't speak English well)


Typescript is still not working on fresh install

What version of Remix are you using?
2.0.1 (latest)
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce
I am using node v20.8.0 + npm v10.1.0.

ran npx create-remix@latest

responded NO to create new repo
responded YES to install via npm

ran npm run typecheck

Expected Behavior
no errors
Actual Behavior

I moved everything to another folder and everything worked after that. Not sure why this was happening.


Add a pop up dialog box for Polls/Survey done ! #1765 🌟🌟🌟

Hello, PR
Add new feature - #1765
Add a pop up dialog box for Polls/Survey done properly -
https://github.com/user-attachments/assets/34064329-7c69-401e-a4cc-64f07b3a4d1e

Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Checklist:

[x] I have made this change from my own.
[x] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal please merge my PR with level 3
I have added this new feature correctly (if you vote once, you won't see it again after reload..)..
🟠Adding Polls/Survey related to your website, content or products can offer several benefits:
⚪Polls/Survey encourage user interaction, making visitors feel more involved with your site.
⚪They provide direct feedback on user preferences, helping you understand your audience better.
⚪Polls/Survey results can guide future content creation or product development based on what your audience cares about.
Thank You

@Subhajit-2023-44 One popup was enough .... Anybody would get irritated on getting two pop-up ... You can add it in side like the cookie policy

@Subhajit-2023-44 One popup was enough .... Anybody would get irritated on getting two pop-up ... You can add it in side like the cookie policy

@PriyaGhosal Users will not have any problem for this, because if you vote once, you won't see it again after reload.. its a nice feature..
And it's better to have it as a popup, then no one will ignore it which will make it easier for you to collect votes from all users..
I have done this before on some website they also suggested this and add level 3..

@PriyaGhosal please merge my PR with level 3
Thank You

@PriyaGhosal please merge my PR with level 3
Thank You

@Subhajit-2023-44 BuddyTrail has one popup already... Two pop is something not desirable

@Subhajit-2023-44 BuddyTrail has one popup already... Two pop is something not desirable

@PriyaGhosal I have done this same thing on some other website they also have two popup one newsletter and one for survey... that's why i add this as a popup.. And it's better to have it as a popup, then no one will ignore it which will make it easier for you to collect votes from all users..
you said "Two pop is something not desirable" but i don't think because its survey, it's better to have it as a popup, then no one will ignore it which will make it easier for you to collect votes from all users... if you vote once, you won't see it again after reload..
@PriyaGhosal please understand and merge my PR with label

@PriyaGhosal & something is wrong with your newsletter popup because it shows up again after subscribing.. which doesn't good

@PriyaGhosal

@PriyaGhosal ?

@Subhajit-2023-44 Please see the conflicts .

@Subhajit-2023-44 Please see the conflicts .

@PriyaGhosal done

@PriyaGhosal please merge my PR otherwise i can't able to do another task

@PriyaGhosal

@PriyaGhosal

@PriyaGhosal please merge my PR with Level 3,otherwise i can't able to do another task

@PriyaGhosal

@Subhajit-2023-44 Please see the conflicts .

???

@PriyaGhosal & something is wrong in your newsletter popup because it shows up again after sign up.. which doesn't good
That's why you maybe think Two pop is something not desirable

@PriyaGhosal ??

@Subhajit-2023-44 Please see the conflicts .

@PriyaGhosal You said solve conflicts, i solve conflicts and wait 5 days, and now why you closed my pr ? 😭😭

Please merge my PR


Fixes #3725

Description (required)
OKHTTP does not support API 19 versions since the recent releases, Downgraded OKHTTP version to support Api 19 devices
Fixes #3725
What changes did you make and why?
Downgraded OKHTTP version to support Api 19 devices
Tests performed (required)
Tested prodDebug on Samsung Api- 27 and Nexus S, Api 19

Codecov Report

Merging #3795 into 2.13-release will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             2.13-release   #3795   +/-   ##
==============================================
  Coverage            6.94%   6.94%
  Complexity            289     289
==============================================
  Files                 256     256
  Lines               11721   11721
  Branches              954     954
==============================================
  Hits                  814     814
  Misses              10836   10836
  Partials               71      71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d02b959...8b4b6f7. Read the comment docs.


Peek Definition and Intellisense Not working

SQL Operations Studio Version: 0.32.8
OS Version: Windows 10 Enterprise 1803

Steps to Reproduce:

While connected to a SQL Server using windows authentication. I receive no intellisense assistance while writing T-SQL Code. Additionally, when I right-click the table name and choose peek definition then I get "no definition found". I toggled developer tools and the console shows login failed for user 'NT AUTHORITY\ANONYMOUS LOGON'.

Does this issue occur when all extensions are disabled?: Yes

Upon more troubleshooting on this issue, I discovered that it was one particular server that was having the issue. However, I have yet to determine the cause. There is no difference between this server and several others that I tried it on other than the fact that they work and this one server doesn't.

I'll close as a duplicate of https://github.com/Microsoft/azuredatastudio/issues/2767 to consolidate related issues.  Please add any additional comments to that issue.  Thanks!


[INTEL MKL] [2.5 cherry pick]  Log warning message for int8 in case of native format

This PR logs a warning message to the Tensorflow customers in the following cases when OneDNN optimization does not
support INT8 inference/training:
(1) stock Tensorflow, with OneDNN optimizations enabled (in this case, INT8 is not supported at all.
(2) Intel Optimized Tensorflow (aka, build with --config=mkl): in this case, the warning message reminds the user
to set a proper environment variable before running INT8 inference/training.
Please help to cherry pick this small PR into RC2 branch.

@penpornk Thanks for review suggestions. Code change has been committed.

@penpornk We would like to have this PR cherry-picked into TF 2.5-rc2. Thanks!

@gzmkl Please track the cherry-pick progress here: https://github.com/tensorflow/tensorflow/pull/48651 :)

@penpornk  thank you for let me know the cherry pick process. I will keep an eye on the specified item.


fix(deps): update gomod

This PR contains the following updates:

Package
Type
Update
Change

github.com/IBM/platform-services-go-sdk
require
patch
v0.62.6 -> v0.62.10

github.com/IBM/project-go-sdk
require
minor
v0.2.9 -> v0.3.0

github.com/gruntwork-io/terratest
require
patch
v0.46.13 -> v0.46.14

Release Notes

IBM/platform-services-go-sdk (github.com/IBM/platform-services-go-sdk)
v0.62.10
Compare Source
Bug Fixes

Usage Reports: re-add offset to SnapshotListNext (#324) (7323d29)

v0.62.9
Compare Source
Bug Fixes

Enterprise Management: re-gen service with latest API definition (#323) (5d05ebe)

v0.62.8
Compare Source
Bug Fixes

Enterprise Management: update create_account response payload (#322) (1594f31)

v0.62.7
Compare Source
Bug Fixes

IAM Policy Management: re-gen service after fixing the assignment response (#321) (2e4a365)

IBM/project-go-sdk (github.com/IBM/project-go-sdk)
v0.3.0
Compare Source
regenerate terraform provider

gruntwork-io/terratest (github.com/gruntwork-io/terratest)
v0.46.14
Compare Source
Modules affected

opa

Description

Updated go-getter to 1.7.4

Related links

https://github.com/gruntwork-io/terratest/pull/1404

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.31.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Feature Request] "Create" and "edit" views should have current action as main title

When creating or editing an item, the current behaviour is that the page title is the model plural, and the name of the action we are currently taking is a subheading:

This is arguably redundant and goes a bit against the minimalist beauty of Backpack. Also it makes it a tiny bit more difficult to quickly grasp what is going on on the page. Could be an issue especially for screen reader users and such.
How about making the current action the heading, with no subheading set by default:

PR incoming

PR: https://github.com/Laravel-Backpack/CRUD/pull/4902
(is there something I can do to automatically connect a PR to the feature request?)

Thank you @pekka
I've just replied you in the PR thread.
I will be closing this so that we keep the conversation regarding this issue in only one place.
Cheers


[#206] Make parent element for modal overlay customizable

Resolves #206.

@jbandura were the tests working for you locally? Travis is failing because find only takes one argument.

I'm going to merge this and fix the tests. Thanks for the PR!

Thank you 🎉 sorry for not answering but had a pretty crazy time recently - I'm pretty sure the tests were passing on my machine 🤔 (I know it's the most lame dev excuse ever 😅)

No worries! I think it was just an issue with the global find versus the imported one perhaps. Got them passing after the fact.


Support tables, links etc

see https://www.reddit.com/r/orgmode/comments/d6v0mc/orgparse_is_back_python_library_for_reading/f0wxo14/

Perhaps it makes most sense to implement a supplementary method for that (e.g. content_rich/heading_rich or something, that would return a list of objects)


WindowClient.navigate() sample

R: @addyosmani @gauntface @jakearchibald @beaufortfrancois etc.
This is a sample for WindowClient.navigate(), shipping in Chrome 49.
You can view a live version of this sample at https://jeffy.info/samples/service-worker/windowclient-navigate/

LGTM with nits.


Decouple Staking and Election - Part 2 Unsigned Phase

Attempt to break down #7319.  Part 2
Part1: https://github.com/paritytech/substrate/pull/7908
Part 3: https://github.com/paritytech/substrate/pull/7910
Priori to merge:

[ ] re-run all staking solution fuzzer.
[ ] re-weigh staking.
[ ] get a feeling of how many nominators we can support with this PR, in unsigned, and no further optimizations.

Pallet with just unsigned phase. There is a small notion of signed phase, but except for defining the range and switching a Phase storage, no logic is in the signed phase.
Also the docs of the module are the full docs. That would have been too much to decouple.

@kianenigma somehow i fucked the build

once above comments are addressed it is good to me

@shawntabrizi @thiolliere based on the test case: number_of_voters_allowed_2sec_block, I get:
can support 152258 voters to yield a weight of<PHONE_NUMBER>000

so... that might be too good to be true. I will focus on benchmarks a bit and making sure they are sane, could use the same from your end as well.

Did you try adding the encode to the benchmarks?

Without decode of snapshot:
Time ~=        0
    + v     2.89
    + t    0.315
    + a    13.35
    + d    4.747
              µs

Reads = 6 + (0 * v) + (0 * t) + (0 * a) + (0 * d)
Writes = 1 + (0 * v) + (0 * t) + (0 * a) + (0 * d)

With decoding of snapshot:
Model:
Time ~=        0
    + v     4.35
    + t    0.367
    + a    13.45
    + d    4.579
              µs

Reads = 6 + (0 * v) + (0 * t) + (0 * a) + (0 * d)
Writes = 1 + (0 * v) + (0 * t) + (0 * a) + (0 * d)

Executed twice to make sure it is not noise.
Seems like a small overhead, but let's incorporate it. Will trigger to bot one last time soon.

/benchmark runtime pallet pallet_election_provider_multi_phase

So... we could audit this work also later once the follow-up PR that actually alters the runtime comes.. so I will mark this already to ping the audit team, but I might merge it before the audit result.

/benchmark runtime pallet pallet_election_provider_multi_phase

/benchmark runtime pallet pallet_staking

/benchmark runtime pallet pallet_staking

These CI errors seem unrelated to me.

but the companion should be green.
it fails with:
error: There are multiple `sp-io` packages in your project, and the specification `sp-io` is ambiguous.
Please re-run this command with `-p <spec>` where `<spec>` is one of the following:

I don't know why though


ugrep: 7.0.0 -> 7.0.1

Changes: https://github.com/Genivia/ugrep/releases/tag/v7.0.1
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

It has already been upgraded again (:
https://github.com/Genivia/ugrep/releases/tag/v7.0.2


Be added to gometalinter

https://github.com/alecthomas/gometalinter already groups a ton of static check tools and go-staticcheck could be a interesting addition to it.

Agreed. That's why it was added back in April: https://github.com/alecthomas/gometalinter/commit/31653ad9ac0769bf9f6cf0c2e142c77d59e89316 ;-)
Going to close this issue. Let me know if they dropped me from gometalinter without me knowing!

Great I'm using it already then :). So maybe instead of adding it to metalinter, why not add to the readme that it is already on gometalinter?

Isn't it already there?
https://github.com/alecthomas/gometalinter#supported-linters

In case the suggestion was to add a note to our README: I'd rather not. It's not our job to track all the possible tools and "meta linters" that make use of staticcheck; at this point, this tool is popular enough that it's the responsibilities of others to support us, not the other way around.


Seed assets and transactions on the network

Recommended:
4 unit-of-measure asset votes/3 accepted for on-chain data
4 resource asset votes/3 accepted for on-chain data
1 ask/tell pair
1 ask


added ethergraphs.com to the dropdown of blockchain visualisers

Hey,
Just added the ethergraphs.com domain to the dropdown list of blockchain readers.
Ben

👍


Can we Translate move-patterns book to Chinese

hi,
Thank you for writing such a great book, can we translate it into chinese？
We have translated the Move book into Chinese and merged it into the move repository。
Kind regards,
lshoo@MoveDAO
https://github.com/move-dao

@lshoo 好啊！ 谢谢你 😊 I have been learning Chinese since 2020 and I am keen to learn how some of these concepts are translated 🤓


HOUSNAV-39: Glossary Terms DT + Modal refactor

HOUSNAV-39
Overview & Purpose

Add glossary term data transformation enabling correct tooltips and adds real data to modal popout.
Summary of Changes

Update references to open building code model

Updated/added new building code data to match potential format

Added new cases for parseStringToComponents
Added terms.json to house all glossary terms

Moved to json directory instead of just walkthroughs

Refactored Modal so that the building code and glossary terms data is formatted separately. (Easier to debug this way)

Side Effects

Tooltips had to be modified to account for the major occupancy terms and groups. So, tooltip content needed an override. If there is a defined term that has the incorrect tooltip then:

Check the terms.json and it's "clean definition"
If that is correct then check what question/answer is using the defined term and ensure there isn't a override-tooltip set. If there is, ensure it's correct.

Testing

Test by opening glossary modal. Ensure tooltips and clicking on terms are correct.
UI walkthroughs should contain terms

If walkthrough is missing a term then note the questions number and what the term is
I updated some of the defined terms in 9.9.9. If a term is a variation (ie. occupancy/occupancies) and the term does not have the correct tooltip or open the modal and scroll to it then this can easily be fixed by adding "override-term" to the attribute in the 9.9.9 json

This was done so that we can quickly specify and override terms and it ensures the application is fast because it doesn't have to "loop" variations to see if one is correct.

Note: Groups should display the definition or word for that group. However, when clicking on a group as a defined term it should open the glossary modal at the major occupancy section.

Notes & Resources

Checklist

[x] I have written or updated vitests for this work
[ ] I have reviewed the accessibility guidelines relevant to this work

N/A due to no new functionality

[ ] I have reviewed this work with at least one screen reader (when applicable)

Screen reader enhacements (https://hous-bssb.atlassian.net/jira/software/c/projects/HOUSNAV/boards/3/backlog?selectedIssue=HOUSNAV-89)

[x] I have added/updated any related documentation

I think this looks good! Is it possible to implement a smooth scroll when clicking different definitions?


How to send the debug text to CommandLine？

I try to program a android program, but there are some Memory error, even the program didn't run, I can't use the graphic debug text by rendering.
On windows, I also want to create a cmd window to print the necessary debug info to make sure the program initialize successful.
Did bgfx have the feature to debug cmd info?

You can get it with Visual Studio or DebugView. You may also be able to build debug.cpp without BX_PLATFORM_WINDOWS (in which case the message will go to stdout instead), but I haven't tried this.

bx::debugOutput

Those suggestions above will do it. Also you have 3rd way, and that's to override CallbackI interface: https://bkaradzic.github.io/bgfx/bgfx.html#_CPPv2N4bgfx9CallbackI10traceVargsEPKc8uint16_tPKc7va_list


[unit-test] add localdiskclaim worker test

What this PR does / why we need it:
add localdiskclaim worker test
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a1ef97d) 36.58% compared to head (9e637f4) 30.77%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
- Coverage   36.58%   30.77%   -5.82%
==========================================
  Files          28       32       +4
  Lines        2222     2674     +452
==========================================
+ Hits          813      823      +10
- Misses       1306     1744     +438
- Partials      103      107       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lgtm


No chance to edit the config if you use 20 issue fields

I just thought it would be a good idea to choose 20 issues in the config "issueControls displayed". Then I had a windows larger then my screen, so I thought, nice I just scroll down, but this is not possible. So I tryed to change the config file in the install folder, did not work.. I changed my screen to portrait, no chance to see the config at the ground of the window. Uninstall does not remove the config so I had finaly to remove the regestry entries I found and then I was able with a different install dir to change the config...
Please change it:(

Have you tried to press ALT-SPACE to open the standard window menu, then select "Move" and use arrow-keys to move the window up, until you can see the settings icon. Now you can click on it and change the number of issues.

Final release of 1.7.0 now available: https://github.com/carstengehling/jirastopwatch/releases
It addresses this issue


tracking issue for Dart 2 work

[ ] ignore the strongMode flag, and run all analysis in strong mode

[ ] remove the strongMode param from the restful API

[ ] upgrade the sdk used for the dartpad backend to a 2.0.0-dev version
[ ] add a dart2 param to the restful API
[ ] use dart2 to indicate --preview-dart-2 analysis and --preview-dart-2 compiles #334

@jakobr-google, I jotted down some todos for incremental migration to --preview-dart-2; feel free to re-do this or track elsewhere as you see fit :)

Progress on the front-end here: https://github.com/dart-lang/dart-pad/pull/801

@devoncarew do we have a dart2js that supports dart2 yet?

@sigmundch; not to my knowledge, but that's not necessary to start on this. Changing to the very latest version of dart2js (w/ full 2.0 support) could be the last 5%.

We are getting close on the dart2js side. To enable it: pass --preview-dart-2 to dart2js.
Note: code will be larger and possibly slower given all the additional tracking of type variabels and runtime checks. You can regain some of that regression by turning off implicit runtime checks from strong mode (flag --omit-implicit-checks).

We got some other urgent work, so we were hoping to wait until this is actually supported. Let's shoot for beta 4.

/cc @jcollins-g

I mentioned this elsewhere, but just to update here: dart2js support for --preview-dart-2 is now ready.

I mentioned this elsewhere, but just to update here: dart2js support for --preview-dart-2 is ready.

Dart 2 support is deployed.  There are still some cleanup tasks to do to remove the old support, but closing the main issue as we've reached the milestone of Dart 2 by default.


/broadcasting/auth route does not work to respond to channel authorization requests

I am using Pusher to Make real-time laravel notifications.
Laravel by default registered /broadcasting/auth route to handle authorization requests via Broadcast::routes(); included in BroadcastServiceProvider.
And in initialization of Pusher, there is a authEndpoint option that can use for Setting the Channel Authentication endpoint like this:
var pusher  = new Pusher("xxxxxxxxxxxxxxxxxxx", {
                authEndpoint: '/broadcasting/auth',
                auth: {
                    headers: {
                        'X-CSRF-Token': '{{ csrf_token() }}'
                    }
                }
            });

As you can see I set it to/broadcasting/auth that is declared by laravel.
But when Pusher send a POST request to it , laravel throws a 403 error and redirect to a 403 error page that I created before.
what is Problem and How can I solve that ?

Hello Ahmad,
Please ask questions on the forums, this repository is for bug reporting only. Anyway the 403 response means that it's a private channel while there's no logged in user or laravel is unable to authenticate the request with pusher.


spike: add support for when methods on union types

exploring what it would take to add freezed-style when methods to union types for easier switching over types re #273
This POC generates code that looks like this
  _T when<_T>({
    required _T Function(Query$Q$u$$TA) tA,
    required _T Function(Query$Q$u$$TB) tB,
  }) {
    switch (json["__typename"] as String) {
      case "TA":
        return tA(this as Query$Q$u$$TA);

      case "TB":
        return tB(this as Query$Q$u$$TB);

      default:
        throw Exception("Unknown typename '${json["__typename"]}'");
    }
  }

A few things to note

I have no idea what i'm doing 😄 -- I based this off the code in the project already and the implementation in the gql-dart/gql repo.
I opted not to include an orElse because I couldn't make sense of why it would be useful for when - similar to what freezed does. It would make sense for maybeWhen where the cases are optional.
I didn't add maybeWhen yet because I definitely want to get feedback on this before spending too much time running in the wrong direction
I added this as a regular method instead of an extension method. I don't have strong feelings about that choice, it was just easier for me to figure out
The tests are failing (because I haven't figured out how to update them and add new ones yet)
I'm perfectly happy to stop working on this and let you (read: the codegen experts) drive the rest of the way 😅

I figured some stuff out.

I know how to update the tests
I need to use extension methods to avoid having to implement the interface on all the subtypes

okay!

I switched to extension methods
I implemented maybeWhen as well

I think this is actually good to go now? I'm just not sure if there should be any more tests.

Hi!
Chipping in to elaborate on my design decisions.
I pretty much needed to ask myself the same questions when implementing this feature.

forwards compatibility:
IMO an API like this should be designed to encourage good practices like ensuring the client does not break when new types are added. This means that either the orElse parameter needs to be required, or the return type must be nullable.
I think both approaches are valid, but I prefer the first one since the latter would need the programmer to deal with nulls even if they know that the return type cannot be null, because they return a non-null value in every branch and added an orElse callback that also returns a non-null value. IMO a better design for nullable return types would be additional whenOrNull() methods or similar.

checking __typename vs runtime dart type checking:
I agree that checking dart types is cleaner, however, a chain of type checks in chains of if/else is surprisingly slow and would require N type checks in the worst case, where N is the number of type conditions. If we leverage the existing __typename field, we can get away with one single runtime type check (in the cast) even if there are many inline fragment spreads with type conditions.
Following the idea of economics of generated code, I went for the __typename check approach.

There is a third option which would be even more performant since it could leverage polymorphic dispatch and is also what freezed uses:

abstract class TABWhen {

 _T when<_T>({
    required _T Function(Query$Q$u$$TA) tA,
    required _T Function(Query$Q$u$$TB) tB,
    required _T Function() orElse
  });

}

// TA type
class Query$Q$u$$TA implements TABWhen {

    _T when<_T>({
    required _T Function(Query$Q$u$$TA) tA,
    required _T Function(Query$Q$u$$TB) tB,
    required _T Function() orElse
  }) => tA(this);

}

//TB type
class Query$Q$u$$TB implements TABWhen {

    _T when<_T>({
    required _T Function(Query$Q$u$$TA) tA,
    required _T Function(Query$Q$u$$TB) tB,
    required _T Function() orElse
  }) => tB(this);

}

// base class where no type matches, not sure if this is how gql_codegen implements this case
class Query$Q$u implements TABWhen {

    _T when<_T>({
    required _T Function(Query$Q$u$$TA) tA,
    required _T Function(Query$Q$u$$TB) tB,
    required _T Function() orElse
  }) => orElse();

}

This would be my preferred approach, but I did not implement it since it would be very hard to leverage this using the existing architecture of gql_code_builder, because the classes can implement multiple abstract classes when the user combines multiple fragments, which could implement their own when() methods, and since Dart does not have method overloading, this would be a compile-time error. A solution for this would be to use different generated names for the when() methods (like when$FragmentName), but this would make the API ugly (and be more challenging to implement).
For clarification, this is an example of what was challenging for gql_code_builder:
suppose this schema
interface Shape {
  area: Float
}

type Square implements Shape {
  area: Float

  sideLength: Float
}

type Rectangle implements Shape {
  area: Float

  sideLengthA: Float
  sideLengthB: Float
}

And this query:

query ComplexShape {
    shape {
        ...OnBoth
    }

}

fragment OnBoth on Shape {
    ...OnRectangle
    ...OnSquare
}

fragment OnRectangle on Shape {
    ... on Rectangle {
        sideLengthA
        sideLengthB
    }
}

fragment OnSquare on Shape {
    ... on Square {
        area
    }
}

gql_code_builder would generate these classes:

abstract class GOnRectangle {...}
abstract class GOnSquare{...}

abstract class GOnBoth implements GOnRectangle, GOnSquare {...}

So, if the when() methods were implemented directly on the abstract fragment classes, this would lead to compile time errors because it's not possible to implement two classes that define a method with the same name but different parameters.
This is why

I didn't implement the type resolution via polymorphism, but over a switch case over the __typename
I implemented the when() methods as extension methods, not directly into the generated classes; Extensions don't suffer from the same name overloading problem. You can extend a class many time with the same method name, it's will still compile. It will be more cumbersome to call the extension method in case of naming conflicts though. Example:

extension A on C{

  void when(int b){
    print(b);
  }

}

extension B on C{

  void when(String b){
    print(b);
  }
}

class C  {

}

void main() {

  final c = C();

  A(c).when(1); /// you have to specify which extension you mean, but at least it compiles
  B(c).when("hi");

}

Or, in the Shape example:
extension GOnRectangleWhenExtension on GOnRectangle {
  _T when<_T>({
    required _T Function(GOnRectangle__asRectangle) rectangle,
    required _T Function() orElse,
  }) {
    switch (G__typename) {
      case 'Rectangle':
        return rectangle((this as GOnRectangle__asRectangle));
      default:
        return orElse();
    }
  }

So, these are the challenges that I faced when implementing this feature and the decisions and compromises that I took.
I'm not familiar which the implementation details of grapqhl_codegen. If it does not use fragments as interfaces which subtypes implement as gql_code_builder does, it might be feasible to implement this feature even with polymorphism.
I hope this helps you!

Thanks for sharing @knaeckeKami. I think it makes sense to continue with:

The typename check as already implemented
Adding a required orElse.
Extension methods as already implemented.

Yes, I think that's a sound choice.
FWIW I intend to move the __typename check code to the new pattern-matching syntax when Dart 3 comes out (if it has similar / better performance).

Hi everyone! thanks for all the engagement and thoughtful feedback.
I will work on implementing the suggestions.
One thing I'd love to talk more about though:

forwards compatibility:
IMO an API like this should be designed to encourage good practices like ensuring the client does not break when new types are added. This means that either the orElse parameter needs to be required, or the return type must be nullable.
I think both approaches are valid, but I prefer the first one since the latter would need the programmer to deal with nulls even if they know that the return type cannot be null, because they return a non-null value in every branch and added an orElse callback that also returns a non-null value. IMO a better design for nullable return types would be additional whenOrNull() methods or similar.

I definitely agree that we don't want the client to break when new types are added. Question about this though: can you provide an example of what change would cause this to break? My assumption is that you're referring to new types being added to the schema on the server and then new types being able to be returned in the responses even though the consumer is unaware of those new types? So the expected behavior there is that we silently fall through into the orElse path because the server response is deserialized into the base type for the union type hierarchy?

I definitely agree that we don't want the client to break when new types are added. Question about this though: can you provide an example of what change would cause this to break? My assumption is that you're referring to new types being added to the schema on the server and then new types being able to be returned in the responses even though the consumer is unaware of those new types because it has an out of date schema? So the expected behavior there is that we silently fall through into the orElse path because the server response is deserialized into the base type for the union type hierarchy?

Your assumption is correct. The issue arises when a new type is added to a union or an interface is implemented by a new type.

Also, don't stress about the verify_commits check.

Also, don't stress about the verify_commits check.

whoops, i missed this and "fixed" things, i think heh


OC project can not use pod install iOSDFULibrary

hi,when I update iOSDFULibrary in my oc project,xcode has a few error.The pod can not find the ‘iOSDFULibrary’ lib.i test many times use different project,can you help me? if I had a mistake.thank you

hi，this is a supplement picture

still having the issue ? if we don' there back within next week we'll assume it's resolved and close the issue :)


[DNM] Test PR for Swift-DocC #304

Test PR for https://github.com/apple/swift-docc/pull/304 + https://github.com/apple/swift-docc-symbolkit/pull/28

https://github.com/apple/swift-docc/pull/304
https://github.com/apple/swift-docc-symbolkit/pull/28
@swift-ci please test


Feature request: Redirect any arbitrary domains

This project looks great! I was wondering if it was feasible to add support to redirect arbitrary domains (other than www) to ness's main domain.
For example, I have a situation where I want the domain to be www.mydomain.com and would like to redirect all of the other domains shown below to www.mydomain.com. Here's an example of how I might want to run ness:
npx ness deploy \
  --dir mysite --domain www.mydomain.com \
  --redirect mydomain.com,somethingelse.com,www.somethingelse.com

In this situation:

www.mydomain.com serves the website
mydomain.com, somethingelse.com, and www.somethingelse.com all redirect to www.mydomain.com

Thanks!

Sorry, my GH notifications are a mess! I think this should be doable! Stay tuned.

Sorry, my GH notifications are a mess! I think this should be doable! Stay tuned.

Mine are too. Lol. Thanks! :)


Add per-channel darkness option

Add an option for setting the black level per channel (libraw: user_cblack).
I've made this a separate issue from the normal options issue because we need to experiment with it and decide on an API. My first thought was that if you set darkness to a 3 or 4 tuple it knows to do it per channel, otherwise do it globally. However, the options may stack (addative?) and if so we might want to support both (or we could just leave that up to the user and do it the original way... if they want extra black per channel they can just add some ammount per channel, it's not that hard).
Thoughts? /cc @campaul
TL;DR —
raw.options.darkness = (1, 2, 3)
# or raw.options.darkness = 1, but we can't do both together

or
raw.options.darkness = 1
raw.options.channel_darkness = (1, 2, 3) # Why didn't we just do (2, 3, 4) (if that's actually how this works)?

Possibly blocking on #51 depending on what we decide to do.

I double checked this today: user_cblack is a per-channel adjustment to the normal black level (it's relative, not absolute, so it will stack ontop of the default value). We can still do this either way.


Setting dependsOn for dev builds does not build Next.js in apps

What version of Turborepo are you using?
1.3.x
What package manager are you using / does the bug impact?
Yarn v1
What operating system are you using?
Mac
Describe the Bug
Hello!
My team is encountering an issue with the dev build process for our monorepo. At the moment we have a pretty simple project as follows:

The apps for docs and web host a Storybook app and Next.js app, respectively. The web app depends on the majority of the packages that we have which are a React UI library (react) and a TailwindCSS plugin (theme).
The theme package has a bit of an extensive build process. It has a TS Node script responsible for building CSS and CSS-in-JS with the PostCSS cli and PreJSS cli. These are needed because the plugin needs to read our styles in css-in-js. The web app, when running the default commands turbo run dev --no-cache --continue --parallel, breaks because the plugin doesn't finish building out before the web app runs.
Our solution is to set a topological order for dev by using the dependsOn in the Turborepo configuration.
{
  "pipeline": {
    "build": {
      "dependsOn": ["^build"],
      "outputs": ["dist/**"]
    },
    "test": {
      "outputs": ["coverage/**"],
      "dependsOn": []
    },
    "lint": {
      "outputs": []
    },
    "dev": {
      "dependsOn": ["^dev"],
      "cache": false
    },
    "clean": {
      "cache": false
    },
  },
  "baseBranch": "origin/dev",
  "globalDependencies": ["$GITHUB_TOKEN"]
}

This builds the docs app and web app in parallel, but web will build the package dependencies first before it builds the web app. That is expected. However, what occurs is the docs app finishes building, and the dependencies for web app finish building, but the web app itself does not build.
We've done several things to check that this wasn't an isolated issue related to the theme package:

Remove all the flags for turbo run dev
Set the dependsOn property for dev to only work in web#dev

{
  "pipeline": {
    "web#dev": {
      "dependsOn": ["^dev"]
    }
  }
}

Isolate the builds for the docs app and web app

{
  "pipeline": {
    "docs#dev": {
      "dependsOn": ["web#dev"],
      "outputs": ["storybook-static/**"]
    },
    "web#dev": {
      "dependsOn": ["^dev"],
      "outputs": [".next/**"]
    }
  }
}

https://user-images.githubusercontent.com/27118807/181622103-d83e9ab0-856d-4df4-8578-f71a26d03342.mov

Remove the theme package as a dependency for the web app and all inferences of the plugin in the code

All of this has lead to our conclusion, this is a Turborepo bug.
https://user-images.githubusercontent.com/27118807/181624855-408d7e0e-b50f-44a3-a7cd-37c9e4ce41d9.mov

Please forgive me on the very short videos. I had to make edits because GitHub only allowed <10mb, but this is the outcome when running yarn clean && yarn && yarn dev.

Expected Behavior
We expect out of the box that running dev will build all the dependencies from packages and run the apps specifically the Next.js app.
To Reproduce
Here's the reproducible repo
https://github.com/AGS1130/turborepo-1594

Thank you for the detailed write up!
Unfortunately, depending on long running tasks is not supported. Since you are already using the --parallel flag, you con remove the dependsOn in your dev task config. I am working on a configuration in #2258 that will allow you to tell Turbo which tasks are long running, so we can error early for you, but it will not fundamentally change the behavior.
"dev": {
-      "dependsOn": ["^dev"],
      "cache": false
    },


introduce beforeScenario hook

at the very least for mocks, to complement the already existing configure afterScenario option: https://github.com/karatelabs/karate/tree/master/karate-netty#configure-afterscenario
this is needed because the Background in mocks is only "one time": https://github.com/karatelabs/karate/tree/master/karate-netty#background
teams will be able to do advanced request validation with mocks
note that the new JS mocks gives you this flexibility: https://github.com/karatelabs/karate/wiki/Karate-JavaScript-Mocks
but some teams prefer the simpler karate-style mocks

You read my mind! Was just about to open this issue.
This would allow me to use a global coinfig to log scenario names before execution.
Especially useful for when scenarios are timing out.

@ericdriggs cool. do note that this should be already possible via the ExecutionHook: https://github.com/karatelabs/karate/wiki/1.0-upgrade-guide#hooks


How to get a specific post (using an url or an id)

Form

[x] I've searched the Issues
[x] I've read the basic concepts
[x] I'm using the latest version

Question
Hello! I just started with the API and my goal with it is to get a specific post, get its comments and then being able to select a random one to do a give away to this specific person.
Is it possible to get a specific post using either a url or directly the post id (in the url)?
With this post, is it possible to get the full list of comments?
With those comments, can we have basic info like the user name?
Thank you and sorry if this question is not at the right place!

Is it possible to get a specific post using either a url or directly the post id (in the url)?

You can use the ig.media.info(mediaId) method. You can get the mediaId using e.g. instagram-id-to-url-segment.

With this post, is it possible to get the full list of comments?

Use the comments-feed (ig.feed.mediaComments(mediaId)).

With those comments, can we have basic info like the user name?

This should be included in the comments feed.
Remember: You will get rate-limited on large posts.

Hi @Nerixyz is it possible to get the users that liked a specific post? Thanks!


Upsert target is not an upsert

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
Kong 3.6.1
Current Behavior
Calling PUT /upstreams/{upstreamName}/targets/{target} returns 404 even though documentation says it is an upsert operation.
Expected Behavior
Calling the PUT endpoint should create the target if it does not exist.
(Creating a target with a POST request and then updating it with PUT works.)
Steps To Reproduce

Create an upstream.
Use the PUT API to upsert a target to it.

Anything else?
No response

Looks to be same as update:
https://github.com/Kong/kong/blob/master/kong/api/routes/upstreams.lua#L216-L221
Not sure, but this may be because of historical purposes. But doc seems be then wrong. One of them is wrong.

I discussed this with @locao, and it looks like it is a bug.

@bungle , do we have a ticket to track it?

--> KAG-4475

@samugi , do we have any updates?

@samugi , do we have any updates?

Already pinged our PM to review this issue


JIRA 502: Remove hashtag from URL

Removes hashtag from URL and introduces a viewManager that sets up infrastructure for defining/managing FluxNotes urls and views.

Will rebase when Torch's branch is merged, of course.

Nice! Looks good on my end. I can hit slim mode by going to http://localhost:3000/ and full mode by going to http://localhost:3000/patient

Also, it looks like you already rebased, so I can merge this in now.


Merge v0.10.x to master

Add v0.10.x latest csv to master so that it can be refereed in future releases

@hrishin

Wondering about deploy/resources/v0.10.1/addons/pipelines/buildah/buildah-build-deploy.yaml, otherwise looks good

you are right i have pushed a fix.
@pradeepitm12 could you validate the buildah pipeline

/lgmt
/hold
have we tetsed it @nikhil-thomas @pradeepitm12

/lgtm
/hold
have we tetsed it @nikhil-thomas @pradeepitm12 ?

@hrishin Test it, works fine.

/lgtm
/hold cancel


Use wildcard instead of specific version for TraceEvent exclusions

/backport to release/6.x

/backport to release/6.2


Failed to execute 'postMessage' on 'Worker': An object could not be cloned.

Encounter this error when I tried to pass a full XMLHttpRequest to the webworker.
Line: 230 from ng-webworker.js throw this error.
 this.oWorker.postMessage(messageData , transferable(messageData , this));

I also met this problem,and have you resolved it

I ended up create my own library just for this purpose. https://github.com/joelchu/nb-blob-worker

Same problem with creating ws connection inside worker.

I got the same issue here

I'm hoping to get a chance to look into this soon. I don't recommend using the transferable feature unless you have a ton of data. Transferable isn't very easy to use, and most browsers don't support many transferable objects. If you aren't trying to use transferable objects, can you post a fiddle or something?

I believe the best approach is to try and solve the what you're trying to accomplish at the most simplistic level and treat the service worker as its own 'app'.
I've had to do something similar when offloading lzstring compression and decompression whilst still handling $http inside the core angular app.

That works for angular2 really well, and it can work for complicated angular1 apps. Can you post an example of what you are trying to do?

guys any update on this?
I'm trying to pass lodash and moment instance to the function i want to execute in worker but getting same issue.
I'm trying to avoid importScript just by passing the lodash and moment instances.
Is there any way around apart from importScript?
 I can load mixins also using importScript but if just passing the instance could do....


[sentry-vite-debug-id-upload-plugin] Client network socket disconnected before TLS connection was established

Environment
node 16.13.1
What version are you running? Etc.
"@sentry/react": "7.75.1",
"@sentry/vite-plugin": "2.9.0",
"vite": "^4.4.5",
npm
Steps to Reproduce

upload sentry sourcemap after build
this is how my sentryVitePlugin specified in vite.config.ts

export default defineConfig(({ mode }) => {

return {
  // ...
plugins: [
react(),
sentryVitePlugin({
      org: "my-sentry",
       project: "my-sentry-web-project",
       authToken: process.env.SENTRY_AUTH_TOKEN,
       errorHandler: function(err) {
       console.log("sentryVitePlugn err during upload: ", err),
})
],
 // ...
}
...

it worked a week ago, but broken recently.
Expected Result
should be build successfully
Actual Result

What actually happened. Maybe a screenshot/recording? Maybe some logs?

Hi, thanks for reporting this!

Are you on SaaS or self hosted Sentry?
Is this consistently happening?
Can you try setting telemetry: false in the options and see if it is still happening? Thanks!

It's not happening with telemetry: false, however, I'm assume this should be work without set false to telemetry.

Yeah correct. We changed something a few days ago, lemme release that an we'll try again!

@dante01yoon We just released version 2.10.3. Can you try that one out? Thanks!

It works with telemetry flag. Thanks for quick catching up!

Resolved  via 2.10.3 update


Staging bundle trigger for patch v0.17.3

Issue #, if available:
Description of changes:
Staging bundle trigger for patch v0.17.3 #6731
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Refs were broken between alpha.4 and alpha.5

Version
3.0.0-alpha.6
Reproduction link
https://codesandbox.io/s/v-model-decomposed-camel-case-s05q5
Steps to reproduce
Just open the repro, nothing to do.
What is expected?
Ref should be set to DOM element (-> Page says Ref works).
What is actually happening?
Ref stays null (-> Page says Ref doesn't work).

This a regression that happened between alpha.4 and alpha.5, as can be seen by changing the script source in repro.

Do note in alpha.4 it leads to an infinite loop warning. This is because the ref was referenced as a dependency for the render and mutated (from null to the element) in the same render cycle.
The fact that a template ref is null during the first render is the expected and correct behavior. To ensure access to the ref you need to do it in onMounted, and it is never recommended to access a template ref in the same template. There's no way for a template ref to be available before it is even rendered.

@yyx990803 The problem is... it just doesn't work.
This was a simple repro, but my intent is to access the DOM element in a watch to do stuff with the elements. As watch is run after mounting, it's supposed to work, doesn't it?
This examples paints a canvas:
https://codesandbox.io/s/pedantic-ives-3iyqk
It worked in alpha.4 but fails after.
How am I supposed to do this?
I'm tyring to manipulate a DOM element in my component and I can't get anything to reasonably work past alpha.4, it's really frustrating if that's the intended design.

watch behavior has also changed! (See the last item here)
Eager watchers now fire synchronously (this is necessary to make them work inside Suspense trees and for server rendering). To make the initial run be able to access template refs, wrap them in onMounted:
onMounted(() => {
  watchEffect(() => {
    // can access DOM now
  })
})

OK, will try.
I assume a watch started in onMounted is cleaned up automatically when the component is unmounted, just like it would be if created in setup?
Which makes me wonder: what is the precise rule? When can I start a computed/watch/watchEffect and have it disposed automatically? When can I not?

@jods4 setup() + all lifecycle hooks.

@yyx990803 seems to work in simple cases.
My refs still don't work in a slot, is that expected? Repro here:
https://codesandbox.io/s/v-model-decomposed-camel-case-gp8c5

I think it never worked inside slots - that's a separate issue though. For now you can use a function ref to get around that:
<v-comp>
  <div :ref="el => (y = el)"></div>
</v-comp>

Shall I open an issue for that?
I'm learning new things (functions ref!) but it's ridiculous that I can achieve it with this obscure syntax yet the intuitive way doesn't work.

It's been fixed in 3eab143


LFS-650: Improve subject navigation and reassignment on form pages

Demographic data form is not showing the subject at the top. There is only pencil button.

@sashaandjic Ready for re-test

Reassignment on form pages is now completely gone.
No links on patient and tumor charts and no pencil button on tumor and tumor region charts.

In  this screen shot you cannot tell who is having Chemotherapy.
For tumor the link with full hierarchy is displayed (correct).

Once I reassigned the form to the patient John I got this:

The link to patient John should be displayed before the pencil button.
All patient forms are having this problem.


Feature : Add a button "New message" in the title bar of the Inbox instance.

Appanrently, you can not write a new email directly from OotD.
It would be nice to do this enhancement : a button in the title bar of the emails window to quickly writes new email.
And add the shortcut Ctrl+N for new message when the focus is on the email instance.
What do you think about that?
Thank you for you software,
Regards

Yeah I had thought of doing that before, but I risk cluttering up the UI too much if I start adding buttons for everything.  I was already hesitant to add the current bar you see at the top of each instance.  Adding a single new button might not be too bad though, I'll see how it works out.
Thanks for the suggestion.

I agree, the goal is not to clutter the window. And the others button can bo reach when right-click on an email. Only New Message have no way to access from OotD.
Maybe a button with a envelope style, with the size of the buttons in Calendar view task bar ?
Or if you don't want/can't to add the button, maybe just adding at least the shortcut Ctrl+N when the focus is on the Inbox instance?
Thank you for your great work!

Maybe just add working shorcuts for New Message and Delete?
Best regards,

I did not implement a delete button, because it's much easier to right click on the item you want to delete and do it that way.


[HOTFIX][sql] Fix compilation for scala 2.11.

Test build #30821 has started for   PR 5652 at commit 819ff06.

Test build #30821 has finished for   PR 5652 at commit 819ff06.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30821/
Test PASSed.


Feature: Configmap as scriptstore

Use case: Keep generic brigade.js scripts in a common store when you wish to avoid duplicate defaultScript entries in multiple project configurations as well as in each repo.
Solution: Add optional property defaultScriptName that refers to the name of a config map containing the brigade.js.
Order of precedence: repo > configmap > defaultscript
Scripts can then be stored by executing the following command:
kubectl create cm mycommonscript --from-file=./brigade.js

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: FrodeHus sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Sounds like a much better and generic approach :) I will look it and update my PR.

I haven’t gone in-depth, but it seems gateways bail out if they can’t find brigade.js.
The controller takes over when the build is created so my thoughts right now is that the gateways could check if the controller can handle it (s.store.IsDefaultScriptPresent or the likes)
Would it be acceptable if the gateways are rewritten to do this check?
As an example - Github GW checks if there is a script in the repo and then if one exists in the project definition. If none are there; it doesnt create the build and the controller isn’t involved at all.
Or:
How about allowing anyone to create a build, but if the controller deems it invalid (no script added by the gateway and none found by the controller the build is tagged as invalid)?

Opted for a much simpler variant: As it seems the gateways use project.DefaultScript directly I changed the implementation so that if DefaultScriptName exists, it will load the script from configmap and place it in DefaultScript. If it fails, it will merely use whatever DefaultScript already had.

Thank you again for all the work you put in on this. And I especially appreciate the fact that you've refactored this a few times already. I'm sorry we ended up in the situation where we had two alternative implementations. I marked #467 as okay to merge, largely because I felt more comfortable with pushing the config map loading down to Kubernetes, and because it didn't change the storage interface. But I wanted to make it clear that this just ends up being one of those uncomfortable situations where two people have both done outstanding work. Thanks for submitting this, and I hope you will continue to submit PRs for improvements.


why Keymap setting doesn't contain review function?

why Keymap setting doesn't contain review function?

The review actions are dynamically "generated" according the your permissions. Available and permitted review-labels are specific to the Gerrit server.
But you are right, it would be nice to have these actions available in keymap configuration.


ID for colorChooserDialog to use multiple dialogs in one activity

Currently it is only possible to determinate if the colorChooseDialog is the accent color or it is not, it would be helpful if you can define an id for any dialog to distinguish between the dialogs.

@MDXDave I added this in the latest commit.
The ColorChooserDialog will automatically use 1 of 3 tags based on if it's a primary, accent, or custom dialog. I also added a utility method to make it easier:
ColorChooserDialog primary = ColorChooserDialog.findVisible(this, ColorChooserDialog.TAG_PRIMARY);

ColorChooserDialog accent = ColorChooserDialog.findVisible(this, ColorChooserDialog.TAG_ACCENT);

ColorChooserDialog custom = ColorChooserDialog.findVisible(this, ColorChooserDialog.TAG_CUSTOM);

If you don't want to wait, you can reference the latest commit through Gradle for core and commons like this:
repositories {
    maven { url "https://jitpack.io" }
}

dependencies {
    compile('com.afollestad.material-dialogs:core:f423baf7cc@aar') {
        transitive = true
    }
}

dependencies {
    compile('com.afollestad.material-dialogs:commons:f423baf7cc@aar') {
        transitive = true
    }
}

@MDXDave I added this in the latest commit.
The ColorChooserDialog will automatically use 1 of 3 tags based on if it's a primary, accent, or custom dialog. I also added a utility method to make it easier:
ColorChooserDialog primary = ColorChooserDialog.findVisible(this, ColorChooserDialog.TAG_PRIMARY);

ColorChooserDialog accent = ColorChooserDialog.findVisible(this, ColorChooserDialog.TAG_ACCENT);

ColorChooserDialog custom = ColorChooserDialog.findVisible(this, ColorChooserDialog.TAG_CUSTOM);

If you don't want to wait, you can reference the latest commit through Gradle for core and commons like this:
repositories {
    maven { url "https://jitpack.io" }
}

dependencies {
    compile('com.afollestad.material-dialogs:core:f423baf7cc@aar') {
        transitive = true
    }
    compile('com.afollestad.material-dialogs:commons:f423baf7cc@aar') {
        transitive = true
    }
}


Fix circular dependency error

This appears to fix the circular dependency error when utilizing Node.js v14.

Hi, thanks for the PR!
I've just run this on v14 and it does not fix the issue.


Add toomanyrequests (timeout) error

TL;DR
Please replace this text with a description of what this PR accomplishes.
Type

[ ] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/

Codecov Report

Merging #107 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   50.12%   50.12%
=======================================
  Files         129      129
  Lines        8008     8008
=======================================
  Hits         4014     4014
  Misses       3602     3602
  Partials      392      392

Impacted Files
Coverage Δ

pkg/controller/nodes/task/backoff/handler.go
73.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89406fb...ddf29b4. Read the comment docs.


Asks from other WGs

Being a list of features/requirements from different groups within Protocol Labs required to support the Package Managers usecase.
What is the Package Managers use case?
Our goal is to encourage package manager maintainers to adopt IPFS as a first-class transport mechanism alongside http, and to produce tools and apps that expose interested users to our tech stack and make happens within the network more transparent.
This will have the effect of massively driving adoption of IPFS and greatly increasing it's visbility to developers who are our early adopters.
Further discussion on this can be found in The Package Managers Use Case
Requirements
Items in this section should represent how we'd use IPFS and supporting technologies to solve problems presented in Problems with Package Managers
Speed

Adding package manager meta data & binaries to IPFS and/or otherwise calculating CIDs for packages needs to be faster.  Similar in speed to rsync.
Retrieving packages via IPFS needs to be much faster

Within an order of magnitude of HTTP if there are no other copies on the local network
Comparable to HTTP with 1-10 copies on the local network
Faster than HTTP with 10+ copies on the local network

For sample datasets & observed performance, see the Experiments @andrew has been conducting.
Documentation

Primer for registry maintainers that makes the case for IPFS simply & effectively
Example use cases relevant to package managers
Onboarding for new uers
Howtos on handling massive data sets (e.g. repo types, optimisation flags, etc)
Common gotchas

Support

More effective and engaged help for users who are not experts in IPFS (e.g. pretty much all package manager maintainers)

Data longevity

IPNS names need to live beyond the publishing node going offline

Graphs-with-friends - nominate PeerIDs as 'trusted', replicate their CIDs & IPNS names?

UI support

Add UI to npm-on-ipfs and other package manager experiments that we wish to keep around & for people to use as learning tools
A system tray type UI to give you stats on local use of npm-on-ipfs/gx/other IPFS based package managers

Features

Permissions in UnixFS - obviously users/groups don't make much sense but knowing which files should be executable when mounting MFS on FUSE would be a big win
"Polite" profiles so you can keep a daemon running without torching your battery

I started searching about "nominate PeerIDs as 'trusted', replicate their CIDs & IPNS names?" and found related discussion. Will this also enable file pinning services to pin names?  That's useful for web dev, as it enables using ipns with dnslink in a serverless way. I ran into issues like those described at the end of https://www.ctrl.blog/entry/dnslink-ipns-top1m-websites and discussed in https://github.com/ipfs/go-ipfs/issues/1467 and I'm guessing it's a common hurdle.

@jchris - are you thinking of something like delegated IPNS record republishing (https://github.com/ipfs/go-ipfs/issues/1958)? AFAIK from https://github.com/ipfs/go-ipfs/issues/1467 you can already pin names...

Those are similar issues, I don't think the use case I'm thinking of works seamlessly yet:

You ask a pinning service to host a directory on IPFS.
You create a ipns record for that directory
You publish that ipns record via dnslink
You close your laptop and eventually the ipns record expires, rendering your content inaccessible.

These steps are advocated in posts like https://medium.com/textileio/the-definitive-guide-to-publishing-content-on-ipfs-ipns-dfe751f1e8d0 so I bet a lot of first time users have dead ipns dns links floating around.
Fixing 4 seems like it would take https://github.com/ipfs/go-ipfs/issues/1958 but also something to handle republishing after the record expires. Delegated authority could allow a pinning service to do this. I think this same mechanism will be useful for package authors to point to latest versions of posts, in a way that package hosts can serve robustly.


I need to be able to get more info about each meme like upvotes

Thanks for the great package, I'm definitely using it. but I was asking if you can extend the response to include the upvotes as it crucial in deciding which meme to send to the user

Yes, that can be added. Anymore important info suggestion?

Yes, that can be added. Anymore important info suggestion?

Yes it'd be great if there is an options array which I can decide which attributes from the original reddit response( if you are using the reddit api)
but for now I guess the upvotes is the most important now and thanks for your fast reply

Keeping the option array suggestion for future. Upvote info has been added.


Feature Request: Add custom databags in GDScript

It is currently not possible to create databags in gdscript. Ideally, it would be as simple as extending Databag and declaring any vars/funcs below.

Moving the proposal to discussions to keep the issue just for things to fix.


pnpm complains of unmet peer dependency.

I get the following warning for this package:
WARN  Issues with peer dependencies found
.
└─┬ eslint-plugin-vitest 0.5.4
  └─┬ @typescript-eslint/utils 7.14.1
    └── ✕ unmet peer<EMAIL_ADDRESS>found 9.5.0

Maybe consider placing @typescript-eslint/utils an optionalDependencies, so we don't even bother with that when not using TS.

Unfortunately, the PR does not solve this issue. @typescript-eslint projects suggest moving to utils v8-alpha. See the issue I created here:
https://github.com/typescript-eslint/typescript-eslint/issues/9488

Ok! Thanks for reopening and keeping track...

Same problem
 WARN  Issues with peer dependencies found

.
└─┬ eslint-plugin-vitest 0.5.4
  └─┬ @typescript-eslint/utils 7.16.0
    └── ✕ unmet peer<EMAIL_ADDRESS>found 9.7.0

this will be fixed once #479 is merged

this will be fixed in the next release


feat: add nutanix csi

I pushed some of the changes specifically around schema validation and updates to https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/10 - let me know what you think. Note that this requires the updated test utility in #9.

It looks like delivering the storage classes via cluster resource set is working.
01:52 PM  faiqus @ archlinux  ~/go/src/github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix  faiq/add-nutanix-csi⚡?
$ kubectl get cm aws-storageclass-cm -o yaml
apiVersion: v1
data:
  custom-resources.yaml: |-
    apiVersion: storage.k8s.io/v1
    kind: StorageClass
    metadata:
      annotations:
        storageclass.kubernetes.io/is-default-class: "true"
      creationTimestamp: null
      name: aws-ebs
      namespace: default
    parameters:
      csi.storage.k8s.io/fstype: ext4
      encrypted: "true"
      type: gp3
    provisioner: aws-ebs
    reclaimPolicy: Delete
    volumeBindingMode: WaitForFirstConsumer
kind: ConfigMap
metadata:
  creationTimestamp: "2024-03-28T19:50:27Z"
  name: aws-storageclass-cm
  namespace: default
  ownerReferences:
  - apiVersion: addons.cluster.x-k8s.io/v1beta1
    kind: ClusterResourceSet
    name: aws-storageclass-crs
    uid: 5b37ccaf-7674-461e-aa01-a007c630500b
  resourceVersion: "3373"
  uid: b400598a-877e-4e84-97fa-d032dc91a287

01:53 PM  faiqus @ archlinux  ~/go/src/github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix  ⏎ 130  faiq/add-nutanix-csi⚡?
$ clusterctl get kubeconfig dawginme7 >> dawg7.conf
Using configuration File="/home/faiqus/.cluster-api/clusterctl.yaml"
Using configuration File="/home/faiqus/.cluster-api/clusterctl.yaml"

01:53 PM  faiqus @ archlinux  ~/go/src/github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix  faiq/add-nutanix-csi⚡?
$ kubectl --kubeconfig=dawg7.conf get sc
NAME                PROVISIONER   RECLAIMPOLICY   VOLUMEBINDINGMODE      ALLOWVOLUMEEXPANSION   AGE
aws-ebs (default)   aws-ebs       Delete          WaitForFirstConsumer   false                  3m30s

01:53 PM  faiqus @ archlinux  ~/go/src/github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix  faiq/add-nutanix-csi⚡?
$ kubectl --kubeconfig=dawg7.conf get po -n kube-system | grep csi
ebs-csi-controller-74fcb959f9-pdk62                                 6/6     Running   0          4m
ebs-csi-controller-74fcb959f9-rgt4m                                 6/6     Running   0          4m
ebs-csi-node-dq65g                                                  3/3     Running   0          3m10s
ebs-csi-node-q8tpn                                                  3/3     Running   0          3m59s

We can see that the storage class and the driver are configured on the workload cluster


Delegated Permission should also be 'AdvancedQuery.Read.All' ("All" s…

…cope)
Scope should be 'All' because authorized user can see all the event tables/data (subject to RBAC limitations)
There are no 'event tables related to the signed-in user (true for all our APIs)

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@mjcaparas Please merge this PR. Thanks


Added endpoint to calculate acrrued interest

Description
Added an endpoint to calculate accrued interest for a security that pays periodic interest. The function contains an example code that describes the usage of the function
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[x] Does not break backward compatibility
[x] Does not produce any errors or warnings

Test Configuration:

Python Version : Python 3.8
Selenium 4.9.1
PyCharm 2022.2.2 (Community Edition)

Runtime version: 17.0.4+7-b469.53 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 10 10.0
GC: G1 Young Generation, G1 Old Generation
Memory: 1010M
Cores: 4

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] Any dependent changes have been merged and published in downstream modules

@ighoshsubho please check this PR for issue #295

Hey @THEGAMECHANGER416 quite few points I wanna mention:

Raise an issue before making a PR
If you are adding an endpoint make changes in ENDPOINTS.md, main.py and functions.py in helpers file
The .idea file you did commit will make the API resource heavy, we don't need files that takes unnecessary space

So, please try to make such changes and create a fresh PR. You can check CONTRIBUTING.md. Thanks.


[test_locality]: Fails to run correctly on PVC GPU.

The end-to-end core test test_locality fails to run correctly on a PVC GPU. We need to investigate the cause of the functional problem(s).

Closing because PR #247 is merged in.


chore(catalog): replace internal uses of deprecated types

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

It seems like the change from
"@testing-library/jest-dom@npm:^6.0.0":
  version: 6.3.0
  resolution: "@testing-library/jest-dom@npm:6.3.0"

to
"@testing-library/jest-dom@npm:^6.0.0":
  version: 6.4.0
  resolution: "@testing-library/jest-dom@npm:6.4.0"

caused the issue with the E2E tests.
yarn tsc:full
node_modules/@testing-library/jest-dom/types/matchers.d.ts:713:1 - error TS2309: An export assignment cannot be used in a module with other exported elements.

713 export = matchers
    ~~~~~~~~~~~~~~~~~

Found 1 error in node_modules/@testing-library/jest-dom/types/matchers.d.ts:713

I was able to reproduce it within the repo, too.


[Idea] Rating with half star rating for each star

I think the title is self-explanatory. I think this feature is good add on for star rating because not always do we wish to expand a rating to 10 stars instead of giving it a 5 star with 2 sub levels to each of the star! :D

Duplicate : #4321


Strange error involving universe variables

Hi,
I am confused by an error I get when using universe variables. When I run the following code:
import logic.cast

set_option pp.universes true
set_option pp.implicit true

constants (A : Type) (B : A → Type)
constants (a1 a2 : A)
constants (a1_eq_a2 : a1 = a2)

constants (b1 : B a1)
constants (f : ∀ (a : A), B a → Type)

definition pf := @dcongr_arg2 _ _ _ _ _ b1 _ f a1_eq_a2 rfl
example : f a1 b1 = f a2 (@eq.rec_on A a1 (λ (a : A), B a) a2 a1_eq_a2 b1) := pf

I get the error:
error: type mismatch at definition 'example', has type
  f.{l_3 l_4 l_5} a1.{l_4} b1.{l_4 l_5} = f.{l_3 l_4 l_5} a2.{l_4}
    (@eq.rec_on.{l_5 l_4} A.{l_4} a1.{l_4} (λ (a : A.{l_4}), B.{l_5 l_4} a) a2.{l_4} a1_eq_a2.{l_4} b1.{l_4 l_5})
but is expected to have type
  f.{l_3 l_4 l_5} a1.{l_4} b1.{l_4 l_5} = f.{l_3 l_1 l_2} a2.{l_1}
    (@eq.rec_on.{l_2 l_1} A.{l_1} a1.{l_1} (λ (a : A.{l_1}), B.{l_2 l_1} a) a2.{l_1} a1_eq_a2.{l_1} b1.{l_1 l_2})

I am not sure where the two extra universe variables come from, or why they cannot be unified by equating l_1 = l_4 and l_2 = l_5. When I change the implicit universe variables for A and B to both be constants, it works as expected. Any clarification would be appreciated.
Thanks,
Daniel
[Note: the definition of pf and the additional implicit arguments seem to be required to make the error message this detailed.]

Lean elaborates the types of theorem, lemma and example independently of their values.
The idea is that the proof should not influence the statement of the theorem.
For example, It is debatable whether we should do this or not, but this is what lean is currently doing.
Note that f has three universe parameters: one for A, one for B and another for the resulting Type. In the example, the equation f ... = f ... is only forcing the third universe to be the same.
That is, if we only take into the account the type of the example, there are 5 universes. We have 3 for the first f, 3 for the second f, but the third universe of each f should be the same.
That being said, the example works if we use a definition
definition my_example : f a1 b1 = f a2 (@eq.rec_on A a1 (λ (a : A), B a) a2 a1_eq_a2 b1) := pf

Now, the value pf and the type of my_example are elaborated simultaneously. So, the universe constraints you pointed are solved, and everything works.

BTW, the subst tactic is quite useful for handling examples that need casts/transports.
Given a hypothesis of the form h : t = a (or h : a = t), where a is variable, it will automatically revert any other hypothesis that depends on a or h; eliminate a, reintroduce all reverted hypothesis, and delete h and a. It also automatically uses dependent elimination if needed. substvars tries to eliminate as many variables as possible using subst. Here is an example:
import data.list

section

parameters (A : Type) (B : A → Type)
parameters (a1 a2 : A)
parameters (b1 : B a1)
parameters (b2 : B a2)
parameters (f : ∀ (a : A), B a → Type)

definition foo₁ : ∀ h : a1 = a2, eq.rec_on h b1 = b2 → list (f a1 b1) = list (f a2 b2) :=
begin
  intro e1 e2, subst e1, subst e2
end

definition foo₂ : ∀ h : a1 = a2, eq.rec_on h b1 = b2 → list (f a1 b1) = list (f a2 b2) :=
by intros; substvars

end

Thank you. I realize now that I misunderstood how universe variables work in constants. The tutorial says:
When we declare a constant A : Type, Lean implicitly creates a variable
l, and declares A : Type.{l}. In other words, A is a type in some unspecified universe.

which makes it sound as if A is in a single (though unknown) universe. But it seems that A is actually universe polymorphic, i.e. a function that takes a universe level l and returns an element that has type Type.{l}. The reason there are five universe variables and not three is because a1 and a2 are also functions, that each take a universe level l and return an element of type A l (my notation to stress the function perspective). I understood that defined functions that take elements of type Type as arguments were universe polymorphic, but I didn't realize that constants were too. The behavior I was expecting for constants can be obtained by declaring a universe constant explicitly using universe l.

By default, constants and axioms are universe polymorphic. I will fix the tutorial.
The behavior described in the tutorial is for parameters and variables (which cannot be universe polymorphic).
To define a constant that is not universe polymorphic, we should write
universe u
constant A : Type.{u}
constant B : Type.{u} -- we can use the same universe for different constants.


Expose choice when there are multiple adjustment sets

Currently when multiple viable minimal_adjustment_sets are found, the smallest one is chosen programmatically.
There are reasons however for the user to consider another minimal_adjustment_set more suitable and may wish to have a choice between the different adjustment sets. One reason for example is there could be much better data for nodes of one adjustment set over another.
After a discussion with @jmafoster1 and @AndrewC19 on 25/10/22, it may be most appropriate to add two new parameters to the identification function or to the execute_test_suites function (to be decided).
The first parameter would be a flag to indicate that the code should be halted when multiple adjustment sets are found and displaying the multiple minimal_adjustment_sets. This would give the user chance to explore and decide which adjustment set is most appropriate.
The second parameter would be a mechanism for pre-selecting an adjustment set if the user already knew from previous executions which set was most appropriate.

also look at #58


[EVENT-HUBS] Update environment variable names for tests

The current env names are very generic and we should update the names so that they are clearly specific to eventhubs livetests and don't have any future collisions with other env variables.
Eg: ENDPOINT => EVENT_HUBS_TEST_ENDPOINT
or IOTHUB_CONNECTION_STRING => EVENT_HUBS_TEST_IOTHUB_CONNECTION_STRING
Please notify after this issue is completed, so that I will update the same in the yaml file to reflect the appropriate env name

cc: @ramya-rao-a

The variable ENDPOINT is not needed. What we need here can be extracted out of the Event Hubs connection string
I wouldnt suggest to add the "TEST" word in the env variables. What benefit would that add? In the pipeline, everything is test related

With regards to the benefit that this would add, we basically want to avoid potential problems when we add more env variables in the future. For more details about such scenarios, I'll cc @weshaggard for discussion.
Also I'm not completely sure about the best way for standardizing the names, I'll cc @weshaggard  for the same

@danieljurek might have written up some naming guidance for these env variables.

@chradek, @ShivangiReja Please update the test code to infer the endpoint from the connection string using regex and remove the need for the env variable ENDPOINT.

If we can eliminate some of the env variables that is even better, please also remove them from KeyVault if you remove them here. However for the ones we have @danieljurek has added some guidelines for naming them to help ensure we don't have clashes, see https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki?pagePath=%2FData Plane Quality Program%2FAzure DevOps Pipeline Guidance&wikiVersion=GBwikiMaster&pageId=2&anchor=environment-variables.

@weshaggard @KarishmaGhiya @ramya-rao-a
What about variables - AZURE_CLIENT_ID and other authentication related ones?
These are AAD_CLIENT_ID etc. in Service Bus. Do these need standardization as well?

@ramya0820 Yes we should update those to reflect the naming guidance to avoid collisions and ensure we know which variables are used for which tests.

Oh, okay based on convention, I'm looking to use EVENTHUB_AAD_TENANT_ID EVENTHUB_AAD_CLIENT_ID EVENTHUB_AAD_CLIENT_SECRET

Closed with https://github.com/Azure/azure-sdk-for-js/pull/4391


Wrong package name in pyproject.toml

Should this be lunarlander =?
https://github.com/nvaytet/lunarlander/blob/8394ccb5420a77bc90671666bc51db5560125c91/pyproject.toml#L33

Fixed in #2


Feat: ical rfc 5545

…nguist

Description

Checklist:

[ ] I am adding a new extension to a language.

[ ] The new extension is used in hundreds of repositories on GitHub.com

Search results for each extension:

https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.FOOBAR+KEYWORDS

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am adding a new language.

[ ] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.FOOBAR+KEYWORDS

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a syntax highlighting grammar: [URL to grammar repo]

[ ] I have added a color

Hex value: #RRGGBB
Rationale:

[ ] I have updated the heuristics to distinguish my language from others using the same extension.

[ ] I am fixing a misclassified language

[ ] I have included a new sample for the misclassified language:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am changing the source of a syntax highlighting grammar

Old: [URL to grammar repo]
New: [URL to grammar repo]

[ ] I am updating a grammar submodule

[ ] I am adding new or changing current functionality

[ ] I have added or updated the tests for the new or changed functionality.

[ ] I am changing the color associated with a language

[ ] I have obtained agreement from the wider language community on this color change.

[URL to public discussion]
[Optional: URL to official branding guidelines for the language]

icalendar support is coming in https://github.com/github-linguist/linguist/pull/6940.

icalendar support is coming in #6940.

That grammar is incorrect and also isn't compliant with RFC 5545, it is only iCAL compliant which is a subset of the actual RFC 5545.

icalendar support is coming in #6940.

That grammar is incorrect and also isn't compliant with RFC 5545, it is only iCAL compliant which is a subset of the actual RFC 5545.

If iCal is a subset of 5545, can we reasonably expect syntax compatibility and thus use the same grammar for both and thus have only a single icalendar language?
/cc @DecimalTurn as the author of https://github.com/github-linguist/linguist/pull/6940

If iCal is a subset of 5545, can we reasonably expect syntax compatibility and thus use the same grammar for both and thus have only a single icalendar language?

From what I've read, iCal is a synonym of iCaldendar, so I don't see how RFC 5545 defines anything other than iCal.
Regarding the incompleteness of the grammar in https://github.com/github-linguist/linguist/pull/6940, I'm willing to change the grammar if we can establish that this is true, but I haven't seen that yet. @kimsey0's grammar just seems to have a different approach.
For instance, here is a comparison of the 2 grammars in action using this sample:

Personally, I see pros and cons of each grammar.
Note that I was using this grammar testing tool and had to convert the XML grammar to JSON.

JSON version of @kimsey0's grammar
{
  "uuid": "2DBC95CE-20EC-4DBF-B555-BD2C44177FA4",
  "patterns": [
    {
      "name": "keyword.command.icalObject",
      "match": "^(BEGIN|END)"
    },
    {
      "name": "constant.language.icalObjectType",
      "match": ":(VCALENDAR|VEVENT|VTODO|VJOURNAL|VFREEBUSY|VTIMEZONE|VALARM)$"
    },
    {
      "name": "constant.language.icalObjectType",
      "match": ":(DAYLIGHT|STANDARD)$"
    },
    {
      "name": "keyword.other.icalProperty",
      "match": "^(DTSTART|PRODID|VERSION|CALSCALE|METHOD)"
    },
    {
      "name": "keyword.other.icalProperty",
      "match": "^(DTEND|DTSTAMP|ORGANIZER|UID|CLASS|CREATED)"
    },
    {
      "name": "keyword.other.icalProperty",
      "match": "^(LOCATION|SEQUENCE|STATUS|SUMMARY|COMMENT)"
    },
    {
      "name": "keyword.other.icalProperty",
      "match": "^(TRANSP|ATTENDEE|ATTACH|FREEBUSY|METHOD|CONTACT)"
    },
    {
      "name": "keyword.other.icalProperty",
      "match": "^(DURATION|RRULE|EXDATE|EXRULE|URL|DESCRIPTION|ACTION)"
    },
    {
      "name": "keyword.other.icalProperty",
      "match": "^(LAST-MODIFIED|RECURRENCE-ID|TRIGGER|RELATED-TO|RDATE)"
    },
    {
      "name": "keyword.other.icalProperty",
      "match": "^(TZID|TZOFFSETFROM|TZOFFSETTO|TZNAME|TZURL)"
    },
    {
      "name": "keyword.other.icalProperty",
      "match": "^(PRIORITY|DUE|COMPLETED|PERCENT-COMPLETE|CATEGORIES)"
    },
    {
      "name": "keyword.other.icalProperty",
      "match": "^(RESOURCES|REPEAT|REQUEST-STATUS)"
    },
    {
      "name": "keyword.other.icalCustom",
      "match": "^X-[A-Z-]+"
    },
    {
      "name": "string.interpolated.icalDate",
      "match": "[0-9]{8}T[0-9]{6}Z?"
    },
    {
      "name": "variable.parameter.icalParameter",
      "match": "[A-Z0-9-]+=[^;:]+"
    },
    {
      "name": "constant.other.icalSetValue",
      "match": "(CONFIRMED|TENTATIVE|CANCELLED|DELEGATED|OPAQUE)"
    },
    {
      "name": "constant.other.icalSetValue",
      "match": "(NEEDS-ACTION|ACCEPTED|DECLINED|IN-PROGRESS)"
    },
    {
      "name": "constant.other.icalSetValue",
      "match": "(PRIVATE|PUBLIC|PUBLISH|GREGORIAN|DISPLAY)"
    },
    {
      "name": "constant.other.icalSetValue",
      "match": ":COMPLETED$"
    }
  ],
  "name": "iCalendar",
  "scopeName": "source.iCalendar",
  "fileTypes": [
    "ical",
    "ics",
    "ifb",
    "icalendar"
  ]
}

Note that the grammar in my repository was directly adapted from https://www.vim.org/scripts/script.php?script_id=1519 (@horsepunchkid), created in 2006, before RFC 5545.

Just to be transparent, I've raised 3 issues in the newly suggested grammar. If these are addressed, the newly suggested grammar would be unequivocally better and I would support the replacement of the grammar in https://github.com/github-linguist/linguist/pull/6940 by this new grammar.
In the meantime, I would argue that the grammar in #6940 is a good starting point to be included in the next Linguist release.


Write up MD explaining Access Control List (ACL) for PASS

https://github.com/codeforpdx/PASS/blob/TechnicalDocs/ACL.md


docs: refresh site style (WIP)

Test url: https://media-chrome-docs-git-fork-luwes-refresh-style-logo-mux.vercel.app/en/components/media-play-button
did a very quick style pass to make the docs similar to Mux docs.
still lots of work to do but I kinda like the direction, it's less washed out.
The logo should fit nicely too.

Looks like a good direction! Dark mode needs updating too.


chore(fuselage): improve Avatar border-radius

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@dougfabris committing the changes we made on our call, perfect


Python: added embedding dimensions support

Motivation and Context

Description

added embedding dimensions support (issue: https://github.com/microsoft/semantic-kernel/issues/5882)
Contribution Checklist

[] The code builds clean without any errors or warnings
[] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[] All unit tests pass, and I have added new tests where possible
[] I didn't break anyone :smile:

Python 3.10 Test Coverage Report • FileStmtsMissCoverMissingTOTAL5864106182% report-only-changed-files is enabled. No files were changed during this commit :)
Python 3.10 Unit Test Overview

Tests
Skipped
Failures
Errors
Time

1257
1 :zzz:
0 :x:
0 :fire:
14.810s :stopwatch:

Also some ruff and black errors, have a look! @sinyubonnie-ho


How to flatten awkward arrays (e.g. for plotting)

The page https://awkward-array.org/how-to-restructure-flatten.html looks like it should explain exactly what I need, but it is empty so far. Hence this issue.

Noted. In the meantime (while I compile for Python 2.7), the short story is to use ak.flatten if you want to remove a level of structure. If you have more than one level of nested arrays, either call ak.flatten multiple times, or pass axis=None to completely flatten. This actually flattens all structures, including records, so be sure this is what you want.
>>> ak.flatten(ak.Array([{"x": 1, "y": 1.1}, {"x": 2, "y": 2.2}]), axis=None)
<Array [1, 2, 1.1, 2.2] type='4 * float64'>

Note that flatten also removes missing values (None), so it's meaningful to flatten at axis=0 if you're trying to get rid of them.
Depending on what your intentions are, you might not want to flatten—you might actually want to do something like
>>> array[:, 0]

or
>>> ak.sum(array, axis=1)

which also remove dimensions, but in ways that might correspond to what you actually want. (That's what I imagined most of the text on that page to be about, when I can write it.)
Also also, some libraries don't call np.asarray on their arguments, so they wouldn't recognize a NumPy-compatible array (e.g. one-dimensional, after flattening). If it's complaining about not recognizing type awkward.highlevel.Array, then try wrapping the Awkward Array with np.asarray. As a side-benefit, it will raise an exception if your array is not actually compatible with NumPy, alerting you to the fact that you need to make a decision about how you want to flatten it.
Compilation's done!

Thanks! ak.flatten seems to do what I need.

Done in #943.