Jinja no longer supports Escape

As of version 3.1.0 of Jinja released March 24, 2022, Markup and Escape have been removed. The devs suggest importing them from MarkupSafe instead. See: https://jinja.palletsprojects.com/en/3.1.x/changes/#version-3-1-0
Flask 1.1.2 tries to import Escape from Jinja:
Traceback (most recent call last):
  File /usr/local/bin/nxbt, line 8, in <module>
    sys.exit(main())
  File /usr/local/lib/python3.8/dist-packages/nxbt/cli.py, line 321, in main
    from .web import start_web_app
  File /usr/local/lib/python3.8/dist-packages/nxbt/web/__init__.py, line 1, in <module>
    from .app import start_web_app
  File /usr/local/lib/python3.8/dist-packages/nxbt/web/app.py, line 9, in <module>
    from flask import Flask, render_template, request
  File /usr/local/lib/python3.8/dist-packages/flask/__init__.py, line 14, in <module>
    from jinja2 import escape
ImportError: cannot import name 'escape' from 'jinja2' (/usr/local/lib/python3.8/dist-packages/jinja2/__init__.py)

If you install Jinja2==3.0.3 you no longer have that specific error but then run into ImportError: cannot import name ‘json’ from itsdangerous which is also a Flask related issue requiring you to downgrade itsdangerous from 2.1.2 (at time of writing) to 2.0.1 and downgrade werkzeug from 2.1.1 to 2.0.2 before the webserver runs without issue.

related to #61. (updating the dependencies to more recent flask versions works)


Show function context for diff hunks.

This fixes a difftastic shortcoming relative to “git diff” (or GNU diff's -p, --show-c-function); it shows the context for a given hunk (which function it is in, assuming it actually starts in one). Based on practical testing, it seems to work well with at least Rust, C, C++, Kotlin, Python and Swift, but probably also for more languages.
Unlike git diff and GNU diff, it does not get confused by the function definition being split over multiple lines, since it uses the tree-sitter grammar to find out what is a function definition, which should be much more robust than the textual heuristics diff uses.
There are a number of shortcomings:

Context is currently only available in side-by-side mode, not inline.
The source code is re-parsed using tree-sitter at display time; we could probably reuse the tree from before it was converted into Difftastic's syntax tree, at the expense of holding onto more RAM during the diffing.
If the context is not the same on both sides, difftastic won't try to show both, but instead show the language name as before. The typical failure case for this is if the function changed name or function arguments between the two versions.
Certain language grammars, such as Julia and elisp, don't have a clear node that delineates the function body from the name and arguments, which will cause the entire function definition to be treated as the context (which thus usually means it won't be shown at all; see the previous point).
The joining of tokens across newlines can cause somewhat unidiomatic whitespace to be added, such as fn foo( arg) instead of fn foo(arg) if “arg” is on a separate line.

Despite all of this, it seems to work very well in practice, from practical experience during real development over a couple of days.
Fixes #304.

Example output:

I modified this a bit to be faster, avoiding the re-parse. (It took more CPU time than I had expected, from a profiling run, so it's better to keep the tree and send it through to the display function.)

Over six weeks with no response; I'm giving up these PRs.

Hi @sesse! I really appreciate your PRs. Just so you know, I have a 7 week old baby so difftastic is a much lower priority right now.
#409 seems totally reasonable, #402 is definitely something I want (preferably without an extra parse), and #420 is an incredible achievement. I tinkered with bidirectional dijkstra myself at one point but getting the reverse edges set up and the termination condition correct is hard. I'm really excited to look at your visualisations more closely too.
I want to balance this with #395, another PR with a ton of perf benefits that I haven't had much time to look at yet. That's lots of smaller optimisations, and I'm trying to merge as many as possible whilst still making the graph algorithm easy to hack on for e.g. A* or bidirectional changes.
If you'd like to reopen the PRs you're very welcome to, but if not I understand too. I just want to thank you for contributions regardless :)

Hi Wilfred,
First of all, congratulations on your baby. I understand that this moves a lot of things around in one's life and requires a ton of attention and energy, and that it makes it really hard to tend to mundane issues such as volunteer OSS work.
No OSS maintainer has an obligation towards their users. I've been on the other end of this bargain a number of times (the open-source one, not the baby one), and I know how much work it is to deal with the constant stream of more-or-less good-intentioned demands and patches that come in. If one sends in a patch and has it refused, or a bug that the maintainer won't prioritize, the reasonable thing to do is just to part ways and leave the maintainer alone. But this cuts both ways; there's no obligation to fight for one's patch. Both sides are largely devoid of glory when it comes to day-to-day work; the only thing we really get is a feeling of recognition and perhaps slightly better software for everyone. So when you send something and it just gets the silence game while you see there's other activity in the repo, the fun disappears :-) All I'd want is something like “hi, I'm really busy and I don't want to merge this right away, please wait a couple of months”.
As for the patches, #402 already has no extra parse (the first version had, but I fixed that fairly early on), and I believe a well-tuned A* heuristic would trounce the approach in #420 (looking at the visualizations, the search explores a bunch of nodes one would hope it could not; I believe the basic idea of changing from pointers to node IDs make a lot of sense, though, and I think QuarticCat has a similar idea somewhere in his patch chain). The PRs are closed, not deleted—if you want to take a look at some future point, fix whatever beginner-Rust mistakes I've made and cherry-pick in the parts you want, you are of course welcome to do that. But I've cut my losses, in a sense, so I'm just running my own private fork with the parts that I want. Which isn't a declaration of war, it's just how things have to be sometimes when real life interferes.
All the best :-)

I want to balance this with https://github.com/Wilfred/difftastic/pull/395, another PR with a ton of perf benefits that I haven't had much time to look at yet.

This PR doesn't seem to conflict with #395 and #401 and LGTM.

Maybe it's time to find a collaborator :)


Change element type

Hello,
This is a Pull Request, as discussed in Issue #694 ([Feature Request] Change element type).
This issue has been closed a being covered by #663, but it is not, as this last one is about relationship, whereas the #694 is about element type.
I may not reopen it.
In this PR:

A "Refactor" menu is added into the diagram context menu, and in the Tree View menu. They have been developped based on the other existing actions/commands. In particular, based on the Delete action of the Tree View menu.
This "Refactor" menu contains submenu, one per element type (Business, Application...). Each of these submenus contain the items of this type.
The Undo and Redo works for both
There is no control on the existing relationship for this element. As a consequence, and to be fully operationnal, the #663 issue should be also implemented. This would allow to change relationship's type, when a relationship becomes "illegal" based on the new element type.

I can work on the #663 implementation. But I'll start that only if you think you'll accept these two PR.

The job is done by creating an ArchimateElement of the good type, copying into it the id, name, description and properties from the source one. The replacing the element in all DiagramModelArchimateObject that contain the old one. The new element is created in the same folder (if the element is of the same type), or in the root of the folder's type otherwise

A JUnit test checks that the old instance doesn't exist any more in the model

A tricky and sensitive part is the ability to create an instance of an element type, based on its name, by using Java reflection. It's not very difficult, but it will fail if a name is changed. So a JUnit test checks that instance creation works for every element type.
It's of course possible to change the type for several elements in the same operation (multiple selections)
JUnit tests have been added and integrated in the existing test suites. They check the execute, undo and redo actions. And I confirm the good integration in the whole maven build, as I checked that with a failing test.
The last commit from the archi master has been merged

NB:

Thanks to your documentation (very clear), I was able to implement and execute JUnit tests, and embed them in the whole build. I check this, as a change in my code has made the JUnit test to fail. And I was happy to double-check it, before raising an issue on them, as this issue was mine ;)
I also was able to build a Product, and I use it now for my own Archimate work.

Etienne

This is along the right track for an implementation, congratulations! :-)
But I'm not going to merge this one because it's not a draft PR (draft PR allows for discussion and changed) and the commits should really be squashed into one commit, or two or three at most. And I think that if you could make it even better.
You have clearly put a lot of work into this and show an understanding of the structure of the code, my only quibbles are in the implementation of the Command and Actions.

I like that you've used the same folder if the new type is in the same layer
No need to use reflection to create a new element, simply use IArchimateFactory.eINSTANCE.create(eclass)
I don't want your .gitignore file :-)
Not sure about storing colours for a diagram object. If the colour is default it will change to the default color, if it's been set by the user they might want to keep the same color
"Features" also need to be copied from elements and diagram objects - I didn't do this either in the jArchi code but it would be easier to do here

You've done a great job here, but as the code could be improved even more my suggestions are:

Close this PR
Squash the commits in the branch
Re-submit as a draft PR (easier to make changes and discuss)
I can review and make suggestions for improvements
We can consider merging the final result when we are both happy

Also, it makes it easier if use a branch rather than master

Draft PRs - https://github.blog/2019-02-14-introducing-draft-pull-requests/

Another thing - we are about to start work on adding icons to ArchiMate objects together with stereotypes (see https://github.com/archimatetool/archi/projects/6). This will likely affect changing the element type. So this may in fact take longer to implement in the long run.

Hello,
Thanks for your quick comment.
I'll publish a draft PR, with your comments taken into account .
What about the icon stuff : do you already have an idea on the impact?
Or we will see when this happen?
Étienne

What about the icon stuff: do you already have an idea on the impact?

A DMO (Diagram Model Object) will also have a path to an image and image position information. But it will be best to use ECoreUtil#copy methods to clone objects. I will discuss more in the draft PR.

Closing as requested. I'll create a Daft PR instead

Apparently, I can't create a "Draft PR".
AFAI, from the https://github.blog/2019-02-14-introducing-draft-pull-requests/ page (and others github docs), I should have this menu in the "Create Pull Request" green button.
But I don't have it.
From the https://github.community/t/draft-pull-requests-are-not-available-on-our-private-repositories-in-last-few-days/2466 page, understand that Draft PR was widely available, but is now less available. Only for repositories that respect this:
Draft pull requests are available in public repositories with GitHub Free for organizations and legacy per-repository billing plans, and in public and private repositories with GitHub Team, GitHub Enterprise Server 2.17+, and GitHub Enterprise Cloud
Etienne

That's strange. We used to be able to create draft PRs. It seems that I can't create draft PRs for the archimatetool organisation nor on my own personal Phillipus public repositories. So I'm not really clear who can create draft PRs.

"Draft pull requests are available in public repositories with GitHub Free for organizations"
As far as I can see the archimatetool organization is a "GitHub Free" one. @jbsarrodie What do you think? Draft PRs were available before now.

@etienne-sf You can create draft PRs. It's in the drop down after you press the first button:

This is in Archi 5.1 beta.


importccl: support sequences in IMPORT PGDUMP

PR: https://github.com/cockroachdb/cockroach/pull/27739
From release notes:

IMPORT ... PGDUMP now supports sequences. [#27739][#27739] {% comment %}doc{% endcomment %}

Fixed by  #3766


nixos-option --help doesn't seem to work

Describe the bug
Right now if you run nixos-option --help all you get is:
No manual entry for nixos-option

... but man nixos-option does work!  I'm not sure what the problem is.
To Reproduce
Steps to reproduce the behavior:

nixos-option --help

Expected behavior
It shows the manpage for nixos-option, OR it prints typical gnu-style --help output.
Additional context

link to the manpage source
link to where the cmdline args are defined

Notify maintainers
@chkno
Metadata

system: "x86_64-linux"
host os: Linux 5.4.100, NixOS, 21.05pre274021.d496205cf22 (Okapi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.7
channels(bstaffin): ""
channels(root): "home-manager, nixos-21.05pre274021.d496205cf22, nixpkgs-20.09.3346.4d0ee90c6e2"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

Additionally:
$ nixos-option -h
terminate called after throwing an instance of 'nix::UsageError'
  what():  unrecognised flag '-h'
Aborted (core dumped)

Dumping core when run with -h isn't a great user experience either

not stale


google_book_data_formatting_line_segmentation

formatting_line_segmentation

@jim-gyas please don't include all the data in the PR

Ok sure .
On Mon, 10 Jun 2024 at 5:08 PM, Tashi Tsering @.***>
wrote:

@jim-gyas https://github.com/jim-gyas please don't include all the data
in the PR
—
Reply to this email directly, view it on GitHub
https://github.com/OpenPecha/Formatting_line_segmentation/pull/2#issuecomment-2158108113,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUBURZAX25N45IX3ISUOC7DZGWF2JAVCNFSM6AAAAABJB5DCMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJYGEYDQMJRGM
.
You are receiving this because you were mentioned.Message ID:
@.***>


unexpected path prefix

http://localhost:8080/monitoring/
http://localhost:8080/
unexpected path prefix

What does he mean by launching directly as HTTP

Brother, have you solved it? I have encountered similar problems

I'm currently having this problem.

I guess you've tried to run it on Windows?
I've faced the same issue. It comes from exploiting filepath.Abs() here. On Windows filepath.Abs(r.URL.Path) transforms "/monitoring" to "c:\monitoring" which is correct absolute path in terms of filesystem, but in this place is invalid. The next check (is the path starting with asynqmon root?) fails.
filepath.Abs(r.URL.Path) should be replaced with filepath.ToSlash(filepath.Clean(r.URL.Path)). I'll try to prepare pull request for it.


DataSet

Hello! During training, I saw that the files of the s3dis dataset were copied to the dev/shm folder, and then the data training was read from this path. This operation is easy to cause memory explosion. Why do you want to do this?
你好！训练时我看s3dis数据集的文件都拷贝到 dev/shm 文件夹中，随后再从该路径读入数据训练。这样的操作很容易导致内存爆炸，请问为何要这样操作呢？感谢回答

Hi,
It's from the original Point-Transformer implementation. /dev/shm stands for shared memory in Linux. I suppose it is for faster data loading such that it avoids reading data from the hard disk in creating each input point cloud.
Best,
Liyao


using .env file

How to use env file instead of toml for sensitive information like credentials?

You can use creates like dotenvy (or dotenv) to load a .env file at startup, for example:
#[tokio::main]
async fn main() {
    dotenvy::dotenv().unwrap()
    /* ... */
}

Currently, rwf only supports the following env-sourced settings:

RWF_DATABASE_URL which will configure the connection pool to use that database, e.g. postgres://localhost:5432/postgres
RWF_DATABASE_USER if you only want to configure which user to connect with, everything else defaults to localhost
RWF_DATABASE_NAME same as USER except it overrides the database name, again only localhost connections; for anything else, use RWF_DATABASE_URL
RWF_LOG_QUERIES set this to any value to enable the ORM to log what queries it's executing

I'll add a todo on our roadmap to support configuring everything via environment variables, so you wouldn't have to use the TOML file if you didn't want to.


php-fpm cannot get the latest stable version e.g 7.3.14

Description:
php-fpm container now can only be get 7.3.13 but I net to get the latest stable one.
it already out for a few days, but still cannot get the latest.
now version shown is
PHP 7.3.13 (cli) (built: Dec 28 2019 21:22:54) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.13, Copyright (c) 1998-2018 Zend Technologies
with Zend OPcache v7.3.13, Copyright (c) 1999-2018, by Zend Technologies
with Xdebug v2.9.2, Copyright (c) 2002-2020, by Derick Rethans
Expected Behavior:
as soon as pull the image should get the latest version of php version, like worksapce container do.
In workspace container php version now is
PHP 7.3.14-6+ubuntu16.04.1+deb.sury.org+1 (cli) (built: Feb  5 2020 16:51:13) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.14, Copyright (c) 1998-2018 Zend Technologies
with Zend OPcache v7.3.14-6+ubuntu16.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies
Context information:
Output of git rev-parse HEAD
c8c63e6a78d492e54311c36a8ea3abaa09da42bc

Output of docker version
Docker version 19.03.5, build 633a0ea

Output of docker-compose version
docker-compose version 1.24.1, build 4667896b

System info: Mac, Windows or Linux. Include which disto/version
Microsoft Windows [Version 10.0.18363.628]

Steps to reproduce the issue:
as soon as pulled the image every time easy to reproduce.

Change this line
https://github.com/laradock/laradock/blob/master/php-fpm/Dockerfile#L16
To say php-fpm:latest on your local Dockerfile


Docs: Azure - Add note around token usage

Hey, I just made a Pull Request!

So the change here is related to this issue https://github.com/backstage/backstage/issues/13500
It's around the fact the the top Note in the change file says follow that doc - but following that it can become misconstrude that you need to do some base64 encoding etc on that token in order to get it to work.
In fact, the underlying library that supports this integration does all that for you. so all you need to provide is the :{raw_token} string, and the docs above are how to obtain that particular string (which is the only part you should focus on).
I've tried to make it more clear what is expected, rather than leaving it up to interpretation.
:heavy_check_mark: Checklist

[x] Added or updated documentation

[x] All your commits have a Signed-off-by line in the message. (more info)

@awanlin does this make sense?


Schema design/Filterable paper list tutorial

Add schema design/filter paper list tutorial.
Add tutorial section to navigation pane
Add links to conference tutorial overview and schema design tutorial

Docs Build status updates of commit e6e3b46:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

academic-services/knowledge-exploration-service/TOC.yml
:x:Error

Details

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/TOC.yml

Line 34, Column 3: [Error-yaml-syntax-error] While parsing a block mapping, did not find expected key.

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md

Line 0, Column 0: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 1, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'. NOTE: This Suggestion will become a Warning in late October, 2020.

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md

Line 1, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 19, Column 47: [Warning-link-out-of-scope] File 'knowledge-exploration-service/TutorialResources.zip' referenced by link './TutorialResources.zip' will not be built because it is not included in build scope.
Line 225, Column 0: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/storage/blobs/storage-quickstart-blobs-portal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 234, Column 204: [Warning-file-not-found] Invalid file link: 'reference-makes-command-line-tool'.
Line 1, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'. NOTE: This Suggestion will become a Warning in late October, 2020.
Line 215, Column 1: [Suggestion-alt-text-bad-value] Alt text 'snap-shot-describe-index-cmd-output' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text. NOTE: This Suggestion will become a Warning in late October, 2020.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 89a4194:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

academic-services/knowledge-exploration-service/TOC.yml
:x:Error

Details

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/TOC.yml

Line 34, Column 13: [Error-yaml-syntax-error] While scanning a plain scalar value, found invalid mapping.

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md

Line 0, Column 0: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 1, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'. NOTE: This Suggestion will become a Warning in late October, 2020.

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md

Line 1, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 19, Column 47: [Warning-link-out-of-scope] File 'knowledge-exploration-service/TutorialResources.zip' referenced by link './TutorialResources.zip' will not be built because it is not included in build scope.
Line 225, Column 0: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/storage/blobs/storage-quickstart-blobs-portal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 234, Column 204: [Warning-file-not-found] Invalid file link: 'reference-makes-command-line-tool'.
Line 1, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'. NOTE: This Suggestion will become a Warning in late October, 2020.
Line 215, Column 1: [Suggestion-alt-text-bad-value] Alt text 'snap-shot-describe-index-cmd-output' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text. NOTE: This Suggestion will become a Warning in late October, 2020.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 27697a2:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

academic-services/knowledge-exploration-service/TOC.yml
:x:Error

Details

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/TOC.yml

Line 34, Column 13: [Error-yaml-syntax-error] While scanning a plain scalar value, found invalid mapping.

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md

Line 0, Column 0: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 1, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'. NOTE: This Suggestion will become a Warning in late October, 2020.

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md

Line 1, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 19, Column 47: [Warning-link-out-of-scope] File 'knowledge-exploration-service/TutorialResources.zip' referenced by link './TutorialResources.zip' will not be built because it is not included in build scope.
Line 225, Column 0: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/storage/blobs/storage-quickstart-blobs-portal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 234, Column 204: [Warning-file-not-found] Invalid file link: 'reference-makes-command-line-tool'.
Line 1, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'. NOTE: This Suggestion will become a Warning in late October, 2020.
Line 215, Column 1: [Suggestion-alt-text-bad-value] Alt text 'snap-shot-describe-index-cmd-output' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text. NOTE: This Suggestion will become a Warning in late October, 2020.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 99f6268:
:warning: Validation status: warnings

File
Status
Preview URL
Details

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/TOC.yml
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/media/snap-shot-describe-index-cmd-output.png
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md

Line 0, Column 0: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 1, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'. NOTE: This Suggestion will become a Warning in late October, 2020.

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md

Line 1, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 19, Column 47: [Warning-link-out-of-scope] File 'knowledge-exploration-service/TutorialResources.zip' referenced by link './TutorialResources.zip' will not be built because it is not included in build scope.
Line 225, Column 0: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/storage/blobs/storage-quickstart-blobs-portal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 234, Column 204: [Warning-file-not-found] Invalid file link: 'reference-makes-command-line-tool'.
Line 1, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'. NOTE: This Suggestion will become a Warning in late October, 2020.
Line 215, Column 1: [Suggestion-alt-text-bad-value] Alt text 'snap-shot-describe-index-cmd-output' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text. NOTE: This Suggestion will become a Warning in late October, 2020.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit bc53a49:
:warning: Validation status: warnings

File
Status
Preview URL
Details

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/TOC.yml
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/media/snap-shot-describe-index-cmd-output.png
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md

Line 5, Column 10: [Warning-ms-date-invalid] Invalid date format for 'ms.date': '2020-09-14'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md

Line 5, Column 10: [Warning-ms-date-invalid] Invalid date format for 'ms.date': '2020-09-14'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.
Line 26, Column 47: [Warning-link-out-of-scope] File 'knowledge-exploration-service/TutorialResources.zip' referenced by link 'TutorialResources.zip' will not be built because it is not included in build scope.
Line 241, Column 204: [Warning-file-not-found] Invalid file link: 'reference-makes-command-line-tool'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d1ba65a:
:warning: Validation status: warnings

File
Status
Preview URL
Details

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/TOC.yml
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/media/conference-app-filterable-paperlist.png
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/media/snap-shot-describe-index-cmd-output.png
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md

Line 5, Column 10: [Warning-ms-date-invalid] Invalid date format for 'ms.date': '2020-09-14'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.
Line 19, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```). NOTE: This Suggestion will become a Warning in late September, 2020.
Line 30, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```). NOTE: This Suggestion will become a Warning in late September, 2020.
Line 35, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```). NOTE: This Suggestion will become a Warning in late September, 2020.
Line 39, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```). NOTE: This Suggestion will become a Warning in late September, 2020.

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md

Line 5, Column 10: [Warning-ms-date-invalid] Invalid date format for 'ms.date': '2020-09-14'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.
Line 26, Column 47: [Warning-link-out-of-scope] File 'knowledge-exploration-service/TutorialResources.zip' referenced by link 'TutorialResources.zip' will not be built because it is not included in build scope.
Line 241, Column 204: [Warning-file-not-found] Invalid file link: 'reference-makes-command-line-tool'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit e52d6f6:
:warning: Validation status: warnings

File
Status
Preview URL
Details

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/TOC.yml
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/media/conference-app-filterable-paperlist.png
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/media/snap-shot-describe-index-cmd-output.png
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md

Line 5, Column 10: [Warning-ms-date-invalid] Invalid date format for 'ms.date': '2020-09-14'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md

Line 5, Column 10: [Warning-ms-date-invalid] Invalid date format for 'ms.date': '2020-09-14'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.
Line 26, Column 47: [Warning-link-out-of-scope] File 'knowledge-exploration-service/TutorialResources.zip' referenced by link 'TutorialResources.zip' will not be built because it is not included in build scope.
Line 241, Column 204: [Warning-file-not-found] Invalid file link: 'reference-makes-command-line-tool'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 4f7acfd:
:warning: Validation status: warnings

File
Status
Preview URL
Details

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/TOC.yml
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/media/conference-app-filterable-paperlist.png
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/media/snap-shot-describe-index-cmd-output.png
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md

Line 26, Column 47: [Warning-link-out-of-scope] File 'knowledge-exploration-service/TutorialResources.zip' referenced by link 'TutorialResources.zip' will not be built because it is not included in build scope.
Line 241, Column 204: [Warning-bookmark-not-found] Cannot find bookmark '#common-authentication-parameters' in 'knowledge-exploration-service/reference-makes-command-line-tool.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 4a63a99:
:warning: Validation status: warnings

File
Status
Preview URL
Details

academic-services/knowledge-exploration-service/concepts-query-expressions.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/reference-get-histogram.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/reference-post-histogram.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/TOC.yml
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/media/conference-app-filterable-paperlist.png
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/media/snap-shot-describe-index-cmd-output.png
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/concepts-query-expressions.md

Line 5, Column 10: [Warning-ms-date-invalid] Invalid date format for 'ms.date': '2020-02-10'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.
Line 3, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Learn how to use structured query expressions' is duplicated in 'knowledge-exploration-service/concepts-query-expressions.md(3,14)', 'project-academic-knowledge/reference-query-expression-syntax.md(3,14)'. NOTE: This Suggestion will become a Warning in late October, 2020.

academic-services/knowledge-exploration-service/reference-get-histogram.md

Line 5, Column 10: [Warning-ms-date-invalid] Invalid date format for 'ms.date': '2020-02-10'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.
Line 3, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Computes attribute value distribution for a structured query expression' is duplicated in 'knowledge-exploration-service/reference-get-histogram.md(3,14)', 'knowledge-exploration-service/reference-post-histogram.md(3,14)', 'project-academic-knowledge/reference-calchistogram-method.md(3,14)'. NOTE: This Suggestion will become a Warning in late October, 2020.
Line 8, Column 1: [Suggestion-duplicate-h1s] H1 'Histogram REST API' is duplicated with other articles: 'knowledge-exploration-service/reference-get-histogram.md(8,1), knowledge-exploration-service/reference-post-histogram.md(8,1)'. First level headings must be unique within a docset. NOTE: This Suggestion will become a Warning in late September, 2020.
Line 44, Column 0: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text. NOTE: This Suggestion will become a Warning in late September, 2020.

academic-services/knowledge-exploration-service/reference-post-histogram.md

Line 5, Column 10: [Warning-ms-date-invalid] Invalid date format for 'ms.date': '2020-02-10'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.
Line 3, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Computes attribute value distribution for a structured query expression' is duplicated in 'knowledge-exploration-service/reference-get-histogram.md(3,14)', 'knowledge-exploration-service/reference-post-histogram.md(3,14)', 'project-academic-knowledge/reference-calchistogram-method.md(3,14)'. NOTE: This Suggestion will become a Warning in late October, 2020.
Line 8, Column 1: [Suggestion-duplicate-h1s] H1 'Histogram REST API' is duplicated with other articles: 'knowledge-exploration-service/reference-get-histogram.md(8,1), knowledge-exploration-service/reference-post-histogram.md(8,1)'. First level headings must be unique within a docset. NOTE: This Suggestion will become a Warning in late September, 2020.
Line 38, Column 0: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text. NOTE: This Suggestion will become a Warning in late September, 2020.

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md

Line 26, Column 47: [Warning-link-out-of-scope] File 'knowledge-exploration-service/TutorialResources.zip' referenced by link 'TutorialResources.zip' will not be built because it is not included in build scope.
Line 241, Column 204: [Warning-bookmark-not-found] Cannot find bookmark '#common-authentication-parameters' in 'knowledge-exploration-service/reference-makes-command-line-tool.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 17a4fde:
:warning: Validation status: warnings

File
Status
Preview URL
Details

academic-services/knowledge-exploration-service/concepts-query-expressions.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/reference-get-histogram.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/reference-post-histogram.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/TOC.yml
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/media/conference-app-filterable-paperlist.png
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/media/snap-shot-describe-index-cmd-output.png
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/concepts-query-expressions.md

Line 5, Column 10: [Warning-ms-date-invalid] Invalid date format for 'ms.date': '2020-02-10'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.
Line 3, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Learn how to use structured query expressions' is duplicated in 'knowledge-exploration-service/concepts-query-expressions.md(3,14)', 'project-academic-knowledge/reference-query-expression-syntax.md(3,14)'. NOTE: This Suggestion will become a Warning in late October, 2020.

academic-services/knowledge-exploration-service/reference-get-histogram.md

Line 5, Column 10: [Warning-ms-date-invalid] Invalid date format for 'ms.date': '2020-02-10'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.
Line 3, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Computes attribute value distribution for a structured query expression' is duplicated in 'knowledge-exploration-service/reference-get-histogram.md(3,14)', 'knowledge-exploration-service/reference-post-histogram.md(3,14)', 'project-academic-knowledge/reference-calchistogram-method.md(3,14)'. NOTE: This Suggestion will become a Warning in late October, 2020.
Line 8, Column 1: [Suggestion-duplicate-h1s] H1 'Histogram REST API' is duplicated with other articles: 'knowledge-exploration-service/reference-get-histogram.md(8,1), knowledge-exploration-service/reference-post-histogram.md(8,1)'. First level headings must be unique within a docset. NOTE: This Suggestion will become a Warning in late September, 2020.
Line 44, Column 0: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text. NOTE: This Suggestion will become a Warning in late September, 2020.

academic-services/knowledge-exploration-service/reference-post-histogram.md

Line 5, Column 10: [Warning-ms-date-invalid] Invalid date format for 'ms.date': '2020-02-10'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.
Line 3, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Computes attribute value distribution for a structured query expression' is duplicated in 'knowledge-exploration-service/reference-get-histogram.md(3,14)', 'knowledge-exploration-service/reference-post-histogram.md(3,14)', 'project-academic-knowledge/reference-calchistogram-method.md(3,14)'. NOTE: This Suggestion will become a Warning in late October, 2020.
Line 8, Column 1: [Suggestion-duplicate-h1s] H1 'Histogram REST API' is duplicated with other articles: 'knowledge-exploration-service/reference-get-histogram.md(8,1), knowledge-exploration-service/reference-post-histogram.md(8,1)'. First level headings must be unique within a docset. NOTE: This Suggestion will become a Warning in late September, 2020.
Line 38, Column 0: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text. NOTE: This Suggestion will become a Warning in late September, 2020.

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md

Line 26, Column 47: [Warning-link-out-of-scope] File 'knowledge-exploration-service/TutorialResources.zip' referenced by link 'TutorialResources.zip' will not be built because it is not included in build scope.
Line 27, Column 47: [Warning-file-not-found] Invalid file link: 'media.zip'.
Line 242, Column 204: [Warning-bookmark-not-found] Cannot find bookmark '#common-authentication-parameters' in 'knowledge-exploration-service/reference-makes-command-line-tool.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1b6d24b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md
:warning:Warning

Details

academic-services/knowledge-exploration-service/reference-get-histogram.md
:bulb:Suggestion

Details

academic-services/knowledge-exploration-service/reference-post-histogram.md
:bulb:Suggestion

Details

academic-services/knowledge-exploration-service/TOC.yml
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/concepts-query-expressions.md
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/media/conference-app-filterable-paperlist.png
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/media/snap-shot-describe-index-cmd-output.png
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/tutorial-conference-app-overview.md
:white_check_mark:Succeeded

academic-services/knowledge-exploration-service/tutorial-conference-filterable-paperlist.md

Line 26, Column 47: [Warning-link-out-of-scope] File 'knowledge-exploration-service/TutorialResources.zip' referenced by link 'TutorialResources.zip' will not be built because it is not included in build scope.

academic-services/knowledge-exploration-service/reference-get-histogram.md

Line 3, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Computes attribute value distribution for a structured query expression' is duplicated in 'knowledge-exploration-service/reference-get-histogram.md(3,14)', 'knowledge-exploration-service/reference-post-histogram.md(3,14)', 'project-academic-knowledge/reference-calchistogram-method.md(3,14)'. NOTE: This Suggestion will become a Warning in late October, 2020.
Line 8, Column 1: [Suggestion-duplicate-h1s] H1 'Histogram REST API' is duplicated with other articles: 'knowledge-exploration-service/reference-get-histogram.md(8,1), knowledge-exploration-service/reference-post-histogram.md(8,1)'. First level headings must be unique within a docset. NOTE: This Suggestion will become a Warning in late September, 2020.

academic-services/knowledge-exploration-service/reference-post-histogram.md

Line 3, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Computes attribute value distribution for a structured query expression' is duplicated in 'knowledge-exploration-service/reference-get-histogram.md(3,14)', 'knowledge-exploration-service/reference-post-histogram.md(3,14)', 'project-academic-knowledge/reference-calchistogram-method.md(3,14)'. NOTE: This Suggestion will become a Warning in late October, 2020.
Line 8, Column 1: [Suggestion-duplicate-h1s] H1 'Histogram REST API' is duplicated with other articles: 'knowledge-exploration-service/reference-get-histogram.md(8,1), knowledge-exploration-service/reference-post-histogram.md(8,1)'. First level headings must be unique within a docset. NOTE: This Suggestion will become a Warning in late September, 2020.
Line 38, Column 0: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text. NOTE: This Suggestion will become a Warning in late September, 2020.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


m.request exceptions are suppressed if you throw.

Description:
Exceptions are silenced during .then of m.request. Similar to https://github.com/lhorie/mithril.js/issues/968 but this is specifically when you throw an exception.
Steps to Reproduce:
a = function() {
  // Exception which doesn't raise
  console.log('before throw');
  throw 'Thrown!';
  console.log('after throw');
}

m.request({
  method: "GET",
  url: "https://api.github.com/users?since=10000"
}).then(a);

Demo at https://jsfiddle.net/tc5t2s30/8/
Expected:
See exception raised in console.
Actual:
No exception raised in console.

Hello, @robinchew!
Promise handlers return new promises. Throwing an exception from a promise handler, most of the time means you are rejecting the promise it will return. In this case, you would have to add a .catch handler after the promise to intercept the thrown error on the next step of the promise chain.
m.request({ method: "GET", url: "https://api.github.com/users?since=10000" })
  .then(a)
  .catch(console.log); //'Thrown!'

But what if I really want throw an exception instead of console.log. I can't seem to make that work.
m.request({ method: "GET", url: "https://api.github.com/users?since=10000" })
  .then(a)
  .catch(function(e){throw e}); // silence

Skimming through http://www.2ality.com/2016/03/promise-rejections-vs-exceptions.html, I came across Promise.reject(e). So:
m.request({ method: "GET", url: "https://api.github.com/users?since=10000" })
  .then(a)
  .catch(function(e){Promise.reject(e)});

Would this be the recommendation?

But this means I have to always remember to chain .catch(function(e){Promise.reject(e)}); after every .then(). I attempted saving myself from writing the catch by writing my own request function like:
function myRequest(){
    return m.request().catch(function(e){Promise.reject(e)});
}
myRequest().then(function(){});

But that won't work because .catch must always come after .then.

Unless I do:
export function then(promise, ...args) {
    return promise.then(...args).catch(e => Promise.reject(e));
}
then(m.request(), function(){});

Promise.reject(x) will not throw, but return a rejected promise:
Promise.reject(5).catch(x => console.log(x)) => 5
m.request({
  ///...
}).then(
  ()=>Promise.reject(5)
).catch(
  e => console.log(e) // => 5
)

Without the last catch bock, nothing will happen.
In general, promises won't allow you to rethrow, you have to use the catch() handler...
Mithril promises have an escape hatch in the form of native errors (any native Error type that isn't literally Error). This should throw:
m.request({...}).then(...).catch((e)=>{throw new TypeError(e)})

This is one of the things that makes Mithril promises non-A+ spec compliant. Promise.reslove() and Promise.reject() are part of the ES6 Promise spec that Mithril doesn't follow either (Mithril was released before promises were standardized and some quirks persist).

This sounds like an expected behaviour and not a bug, so I'll close it. Thanks for the help.


CMakeList 中Boost大小写问题

 include_directories(${BOOST_INCLUDE_DIRS})
中Boost是全大写，但是
find_package(Boost COMPONENTS         system         python REQUIRED)
中Boost是区分大小写，导致osx下无法寻找到正确的路径

So you mean it should be include_directories(${Boost_INCLUDE_DIRS})?

${BOOST_INCLUDE_DIRS} is empty in my OSX ,
when i change it to Boost_INCLUDE_DIRS, ${Boost_INCLUDE_DIRS}'s value is right.

Thanks for letting me know. I guess I fixed this problem in previous commits. Please pull and reconfigure. I think it will work. It's interesting that on my Mac both identifiers work. I changed it to Boost_INCLUDE_DIRS last night anyway.


Release pre-built binaries

Like v0.4.0 Release, please upload and distribute pre-built binaries in v0.4.1.

Done, I haven't been very active with zig lately and I have no clue why the binary size ballooned up to 610kb but oh well

Try: zig build-exe src/main.zig -O ReleaseSmall --strip
It made a 17kb binary.


Update tutorial-kubernetes-workload-identity.md

Required set-up for msal-go image to successfully use federated identity credentials to access Azure resource.

@microsoft-github-policy-service agree company="Microsoft"

@mgoedtel
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

I unfortunately missed the --enable-workload-identity parameter in cluster create as it wasn't mentioned in the text, and I was re-purposing one of my previous clusters for this tutorial using the az aks update command. Once this flag is enabled, it works without the proposed changes in this PR. All good!


Skip prereleases from "Releases" in PR descriptions

While having the releases listed in Dependabot PR descriptions is great, prereleases do "pollute" that section with information that is not helpful.
Hence, it would be great if they could be filtered out.
Here's an example of a Dependabot PR with lots of prereleases (that we create for testing off feature branches):

And for reference, one of those prereleases in the library "Releases" section:

Thanks for the feature request! Do you have a suggestion on how we could implement this in a sufficiently generic way (e.g. allow arbitrary filtering of release notes based on a regex) so that this isn't a one-off for you but a benefit for the entire user community?

Hi there, I'd also like to see this feature.
My suggestion would be to only show releases that are not tagged as "Pre-release"s. Usually the changelog for the next release contains the combined entries of all previous pre-releases.
One could also omit all lines from pre-releases that are already mentioned in the following real release but that seems wrong to me.
Alternatively it would be possible to check if the releases follow a semver format and show only those that have no pre-release suffix (e.g. -alpha etc.) but only the three numbers x.y.z prefixed by an optional v. I believe dependabot is already using the semver spec to only return releases between the previous and new versions and no releases from another major version. The same spec could be used to determine pre-releases.

👋 Sorry for the slow response.
The problem with this is that many open source projects will include their breaking changes in the notes for the alpha release of the breaking change, and then not mention them in the stable release, because they assume everyone can read the pre-release notes as the next bullet point in the changelog. TBH, I've done this myself on open source projects that were less popular when I've been short on time but want to keep the project moving forward.
This happens frequently enough across various popular open source projects that I just don't see us changing the Dependabot behavior.
It sounds like the problem is the Dependabot PR includes multiple of these pre-releases and is full of noise, so one possible workaround if these are just test builds is to add a CI action that deletes the previous release when it creates a new release. That way there's only a handful of pre-releases in the history between stable releases at any given time. So when Dependabot goes to create the new PR, it should be significantly less noisy with only 1-2 build-releases and the rest stable. May not work for your situation, just an idea.

Another workaround is if you have two repos, the normal one for dev, and then a placeholder one that you use for stable releases and just pull the latest updates from dev and tag a stable release when you need. Clunky, but it'd probably work fine.

Thank you for the clarification. Although I'm not really happy with your solutions, I do understand why you can't change the behaviour globally.
Would it be possible to make that configurable though in dependabot.yml though @jeffwidman?

Another workaround is if you have two repos, the normal one for dev, and then a placeholder one that you use for stable releases and just pull the latest updates from dev and tag a stable release when you need. Clunky, but it'd probably work fine.

This would indeed work, but as you said it's kind of clunky. Splitting (beta-)releases from the codebase does not seem right to me. Also the tooling I use to create releases (semantic-release) does not support this and I don't see a good way to implement it there. I'd still need the "version bump commits" in the main repository or they'd get out of sync really fast.

It sounds like the problem is the Dependabot PR includes multiple of these pre-releases and is full of noise, so one possible workaround if these are just test builds is to add a CI action that deletes the previous release when it creates a new release.

Similar situation here, this is not supported by the "standard" tools I use. Also I believe that changelogs should not be altered or deleted afterwards (except for typos etc.) but that might be my personal opinion only.
The "solution" for me will probably be to release less beta-versions. Currrently I release a beta-version for every change that benefit the end user (fixes, features, upstream dependency updates). Releasing beta-versions only once in a while should at least reduce the amount of headings. On the downside that means that beta users would receive less frequent updates and might need to build from source if they need a fix ASAP.

We aren't going to add it as a config option in Dependabot run natively on GitHub.
You can also run dependabot-core yourself using an entry point like dependabot-script... Easy to wire up to run in the context of a GitHub Action. Since they're both open source you can fork and hack the code to meet your particular use case... That should also be a relatively straightforward solution.


Replace std::unordered_map with F14FastMap in velox/type/tz/TimeZoneMap.cpp

CC: @funrollloops

Hi Maria @mbasmanova,
I'd like to work on this bug.

@odilov Welcome, Akbar. Please, go ahead.

@mbasmanova, done :) it's my first pull request in open source project, any feedback is welcome

Thank you, @odilov . Let me take a look.

@odilov Can you make it into a pull request and provide a link or a number?


[Question] How to use with Node Client

I am creating elasticsearch cluster using NodeBuilder module. Is there a way to use this plugin in my setup?

Hi Pratyush,
I'm afraid I don't have any experience of using NodeBuilder beyond the very basics.
Chris

@jurgc11: Thank you for your response. You may close this if you feel like.


Updating the templates based off change requests

Lots of back and fourth over in #107, decided to open a new PR to add the requested changes.

Let's keep the change to one PR, to keep things clear.


use with android

Hi,how connect with android, i use passport jwt for authentication from android device but socket.request.session.passport is null

I don't have any idea on how to do so. If someone cal help that would be awesome.

yooooooooooooooooooooooooooooooo

i am taking a look at this application. id like to help if people are still waiting for a fix


Status of Databases

On the Main.vb, we can show up/down status of the services like api.warframe.com

Should be shown as an status update.

Since we switched away from these apis in v9, its no longer needed. The data is supplied by
https://github.com/WFCD/warframe-items
which is more structured, full, and easier to work with.


busybox: 1.29.3 -> 1.30.1

Motivation for this change
For changes see https://busybox.net
(most of which are part of 1.30.0).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Need to test bootstrap as comment indicates, at least :).

Fixes a security problem, probably: https://github.com/NixOS/nixpkgs/issues/54798

@GrahamcOfBorg eval

I did run the bootstrap test, BTW.


Buildstream should provide a buildsystem repo with common buildsystems

See original issue on GitLab
In GitLab by [Gitlab user @tcanabrava] on Jul 8, 2020, 11:30
When creating a small project for a flatpak or snap, what we need is to get the sources of our application, configure a small script for buildstream that tells bst: this target depend on the following list of platforms, and use this buildtool but currently we need to specify inside of the kind: cmake that we have cmake:
kind: cmake
description: dolphin

depends:
- filename: bootstrap-import.bst
  junction: freedesktop-sdk.bst
- filename: public-stacks/buildsystem-cmake.bst
  junction: freedesktop-sdk.bst

Even tough I'm talking about cmake here, this extends to meson and other buildsystems.

In GitLab by [Gitlab user @tristanvb] on Jul 8, 2020, 12:43
marked this issue as related to #1061

In GitLab by [Gitlab user @tristanvb] on Jul 8, 2020, 12:45
I don't think this makes sense for BuildStream to provide, as BuildStream is not related or tied to any specific platform or distro, although, it could make sense as a feature of freedesktop-sdk.
One thing that is high up on our wishlist is specifying default dependencies for plugin kinds within the scope of a given project; linked issue #1061 describes this.

In GitLab by [Gitlab user @coldtom] on Jul 8, 2020, 12:49
FWIW from the freedesktop-sdk side, this was the explicit purpose of creating public-stacks/buildsystem-*, in order to allow projects junctioning freedesktop-sdk to grab a buildsystem.

In GitLab by [Gitlab user @tristanvb] on Nov 6, 2020, 09:42
While we agree it's important to have these, BuildStream itself should not be providing them, as BuildStream itself is just the build tool and not the payload.
Closing this.


Shall we open a new branch for toolkit globalization

Starting from master we plan to implement localization support for the internet toolkit.
Shall we open a new branch for this work?
Proposal:
keep on using master branch
bump version number from 1.0.0 to 1.1.0

The globalization is done in master branch.
Branch v1.0.x_m is provided for maintenance in older releases


Support strings for key_mgmt

As mentioned in #17, nerves_network does not currently allow for
strings as the key_mgmt method, this PR fixes this by converting
them to atoms as required by nerves_wpa_supplicant.

See also #29 for discussion of a similar flavor.

@electricshaman Yes, I read that issue, but it seemed to me to be caused by leaving the network interface as is at first, causing it to be seen as a new one.  The question we need to ask here is, what interface do we want to offer? And what interface do we have to adhere to?

Thanks!
Sorry for the long delay in merging this. I rebased it since there was a conflict with another PR I merged right before this, but it's in master now.


[Completed] Automated tutorial for how to create a project in MSS using all the views.

This involves the demonstration of how to create a project with all the views, that are, top view, side view, table view and linear view.
I have tested in both windows and linux and it works smoothly.
(The previous PR opened had the random tests failing. Hence, created this new PR and closed the previous #1096 PR)

Your tests will probably pass when next merged with develop

Your tests will probably pass when next merged with develop

Okay. Thanks.

I would like to see a bit modularisation in some utils functions for the different platform parts.
This could also be done in a refactoring PR. What is your opinion about this?

Yeah, it would be helpful if I do all those utils' part in another refactoring PR. Moreover, I am thinking to complete the rest tutorials first and then do this refactoring around utils part? Because, I guess I should complete the tutorials first. What say?

I would like to see a bit modularisation in some utils functions for the different platform parts.
This could also be done in a refactoring PR. What is your opinion about this?

Yeah, it would be helpful if I do all those utils' part in another refactoring PR. Moreover, I am thinking to complete the rest tutorials first and then do this refactoring around utils part? Because, I guess I should complete the tutorials first. What say?

Agreed

I would like to see a bit modularisation in some utils functions for the different platform parts.
This could also be done in a refactoring PR. What is your opinion about this?

Yeah, it would be helpful if I do all those utils' part in another refactoring PR. Moreover, I am thinking to complete the rest tutorials first and then do this refactoring around utils part? Because, I guess I should complete the tutorials first. What say?

Agreed

Okay then. I am starting my work on mscolab tutorial as of now.


Add a data type for storing durations

I read in #327 that you are planning to introduce a new knora-base:DateTimeValue. I think it could be a good thing (in fact, some researchers have already expressed this need).
But how are we supposed to express a duration (without any interest in the date) to express the duration of a movie, audio recording, etc.? I don't think this value exists yet (and we need it)?

The duration of a movie or audio recording is stored in AudioFileValue and MovingImageFileValue, in the property duration.
If you want to express a point or range in time relative to the beginning of an audio or video file, you can use IntervalValue.

Yes, but in this case, there will be no AudioFileValue or MovingImageFileValue.
The resource is a knora-base:Resource, called "Sequence" but with no file attached. The team needs to express the duration of a program's sequence in HH:MM:SS in absolute values, amongst other properties, such as the journalists involved, the topics discussed, etc.
Is there currently a way to handle this within Knora and Salsah?

We could add a DurationValue type, storing an xsd:duration:
https://www.w3.org/TR/xmlschema11-2/#duration

That would be great.
By the way, if you look at knora-base:duration, the objectDatatypeConstraint is on xsd:decimal. Is this right?

Yes, I believe it's a value in seconds, which can be fractional.

Maybe knora-base:duration should store an xsd:duration, though.

Just to let you... We will probably need this to be implemeted for the very first project we will launch on Knora. They are planning to begin data input around the 15th of january. Do you with at that time a  DurationValue type could be implemented in Knora + in the GUI?

We might be able to do it by then. Let me check with Lukas and get back to you.

This issue has been inactive for a significant time, so we’re closing it for now. If it’s still relevant, feel free to reopen.


Ensure that the package client configuration is persisted when we install a package

This is necessary to ensure that when we install amber from a nugget, we'll be able to install additional packages afterwards.

Tested and verified.


Use the select component in the reactiveForm,  change the value via patchValue in asynchronously execution environment but keep the old value

Version
0.5.1
Environment
win7  chrome latest,  zorro0.5.1
Reproduction link
https://stackblitz.com/edit/zorro55-basic
Steps to reproduce
see links
steps:
initial value: 1
new value :0
What is expected?
option  '0'  has been selected
What is actually happening?
option  '1'  has been selected
Other?
the initial positioning, the problem  is caused by function "addOption",  the condition  judgment of  fourth line has some problem, when the value is number zero , can't be passed
addOption = (option) => {
 this._options.push(option);
 if (!this._isTags) {
   if (option.nzValue) {
     this.updateSelectedOption(this._value);
   } else {
     this.forceUpdateSelectedOption(this._value);
   }
 }

}

0.5.1 is not under maintain any longer, please update to the latest version, thanks.

My project is at 0.6.3 now. Still have the same problem

Excuse me, what is the cause of this problem, and I have the same problem?

@flyaway0624 see the problem description . you can modify the source code to solve ,  or avoid the dropdown option value is zero


Should provide buttons to select/unselect all changes when preview a workspace edit

Use Case:
When the user renames a Java file from file explorer, the Java extension would watch on workspace.onDidRenameFiles event, then calculate and generate a workspace edit to update its class name and references. Since it takes some time to calculate the edit, the user may perceive the file contents to be updated after a while. There is a lag between file rename and file content update. In order to improve the UX, we would show progress notification at the status bar during the calculation, and also want to try the preview API to preview the workspace edit instead of automatically applying the edit.
Problem:
Currently workspace.applyEdit interface doesn't provide an option to allow the extension to force preview the workspace edit. A workaround is to add WorkspaceEditEntryMetadata property to the workspace edit. Since in java language, we don't distinguish which changes need to be confirmed, in order to trigger the preview pane, i just set the needsConfirmation to true for all changes. This will make all changes unchecked in the preview tree, and the users have to check one by one if they want to apply all. This is especially not convenient for large projects, as the possible modifications include many positions.

Expected:
At least, provide an easy way to bulk select the changes. Further, it would be nice to expose a client API to force preview a workspace edit and keep all changes checked by default, like what rename did (shift + enter).

As a workaround how about setting needs Confirmation on only one of your results?

that looks weird to leave a random change unchecked.

Sure, but as a workaround isn't it better than leaving them all unchecked and requiring the user to do a lot of clicking?

Since in java language, we don't distinguish which changes need to be confirmed, in order to trigger the preview pane, i just set the needsConfirmation to true for all changes.

If you have confidence in your edits, e.g they have been computed by your "compiler" and not by text-search or similar (weaker) strategies then never set the needsConfirmation-flag.

needsConfirmation is just a workaround. The effect i need is to preview all edits and preselect them all, just like what rename (shift + enter) did.
I need to clarify that in my user cases, the Java extension generates workspace edit and then manually calls workspace.applyEdit API to preview and apply the edit. If VS Code could add a new parameter like forcePreview?: boolean to the current applyEdit API (e.g. workspace.applyEdit(edit: WorkspaceEdit, forcePreview?: boolean)), and let the extension itself to use this API to control whether to preview all edits forcedly, this will also satisfy my needs!

I need to clarify that in my user cases, the Java extension generates workspace edit and then manually calls workspace.applyEdit API to preview and apply the edit.

TBH I am very confused. Is this for rename or generic code actions? Note that for generic code action we haven't done anything yet and still wonder how the affordance (similar to Ctrl+Enter with rename) would look like

If VS Code could add a new parameter like forcePreview?: boolean to the current applyEdit API (e.g. workspace.applyEdit(edit: WorkspaceEdit, forcePreview?: boolean)), and let the extension itself to use this API to control whether to preview all edits forcedly, this will also satisfy my needs!

That's exactly not what we want. For us, showing a preview or not is a user-choice not an extension author choice. That's why for rename we have added editor.rename.enablePreview. For rename there is two ways to show a preview

Users sets editor.rename.enablePreview: true because it's their personal preference to see a preview of changes
Extension sets the needsConfirmation flag on some edits because it did guess work to come up with the edits

It seems like you using option 2 to enforce a certain behaviour that you desire. This is bad because it undersells your language service and it doesn't respect user choice. We have no plans to bless such behaviour. If you firmly believe that previewing changes should be the default for java-developers then your extension can ship a language-specific default value for said setting

Is this for rename or generic code actions?

No, this is not part of any code actions.
The scenario we want to try is for some implicit refactoring from file explorer. For example, when the user did some file operation through file explorer, such as rename or move, this will cause the file name or package name inconsistent with the class or package declaration in his code. The builder tool will report lots of build errors. And many users complain they need manually update many code.
So the Java extension wants to watch on these file events, auto computes a workspace edit and then pop up the preview panel and let the user to determine whether to apply it.

For us, showing a preview or not is a user-choice not an extension author choice.

I only partially agree with you on that. If it's an explicit refactor code action, the user would expect there are code changes to happen. Apply it directly would be OK. I definitely agree to give the user to choose whether to preview.
But my case is not an explicit code action. It's just a normal file operation through file explorer, such as rename file name or drag and drop, the user didn't know the extension will update their code. IMO, previewing it makes more sense than quietly apply edit. Also the computation job may take a few seconds to complete. For some big projects, it could be more than 5 seconds. Automatically update the user's code many seconds after the file operation is complete, which is also very unfriendly.

Ok, understood. Thanks for clarifying and 'yes' this outside of what we have thought this feature being used for and I am unsure if it's the right place. TypeScript has a similar challenge and ships a feature which simply asks you what to do when a file has been renamed. This is how it looks:

So, they listen for file rename event (vscode.workspace.onDidRenameFiles) and show then shows that prompt which IMO is pretty informative and allows me to make a choice. Once it is actually going (e.g after pressing OK or when having this "always on") you see a progress message that changes are being computed and that's it. I think Java should do something similar.
Now comes the refactor preview and user choice into play and that's the part where I said that we don't have anything yet. Again, we don't want to enable extensions to force this into your face (instead prompt before computing changes) but we want user to be able to express a preference and then play nice with that preference. It will likely be an additional parameter for applyEdits - just as you have proposed. However, it won't enable forcing but it should enable extensions to "describe/classify" their code action which we then use to decide if a preview can be shown or not.

UX discussions are always a tough thing to do. Personally i'm not a fan of dialog notification. Since the API is right there, we thought why not to have a try on the PREVIEW FEATURE. It already looks great now, just a little more improvement would make it more perfect!

UX discussions are always a tough thing to do. Personally i'm not a fan of dialog notification.

That proves my point about personal preferences 🤓 Tho, in all fairness: If you don't like dialogs that you would select "never" or "always" in the screenshot above and you would never see it again (this updates a setting)
I also agree that this can be a use-case for the preview feature but only for uses that like the preview feature. I can think of the following flow

users have a setting like editor.codeaction.enablePreview: true | false
Java (or any other extension) calls appyEdit with some extra info that classifies the edit as "preview-able code action" (for instance has a label and so)
VS Code checks the edit info and the user setting to decide if the preview should show or not

Now, users that don't like to see a preview will not observe the Java-rename-smarts because they use enablePreview: false. Now,  you can enforce the preview by using the needsConfirmation-trick which doesn't make those users happy and, in return, they might ask us to add something like enablePreview: 'never'.
Don't get me wrong. What you are doing is cool but I think the TypeScript-flow works pretty well for this use-case because it informs users right after rename, not after a N seconds compute-pause. Then, after the compute and once we have implemented this, VS Code can show a preview for those users that like previews

yes, adding a user setting does help for different user preferences. In addition, Java implementation is slightly different from TypeScript, some scenarios (e.g. rename package, move file to another package) are done at onWillRenameFiles listener, so displaying a dialog there may not be appropriate.


[docs] update docs script, readmes

Building on top of @Flaque's work in https://github.com/hshoff/vx/pull/32
More work to be done writing docs, but this gets us up and going.

Coverage remained the same at 26.758% when pulling ce7d3076105aef8d1809481f2d0258dd58aa5b43 on harry-docs into a7654c45fcbdec4ea24e7eb423a71883dce66a47 on master.

Coverage remained the same at 26.758% when pulling ce7d3076105aef8d1809481f2d0258dd58aa5b43 on harry-docs into a7654c45fcbdec4ea24e7eb423a71883dce66a47 on master.


Add random-functions with range

Fixes #1834

Thanks for adding these functions. Can you also update the documentation in presto-docs/src/main/sphinx/functions/math.rst? Please squash the commit (and force push) when updating the PR.

Thank you, @electrum! I'm on it!

@cla-bot check

Please add tests. They should go in io.prestosql.operator.scalar.TestMathFunctions#testRandom.

@findepi thanks for the observations! I'll work on this!

Could you add some tests to TestMathFunctions.testRandom as @findepi suggestion?
Also, please squash commits. I think - isn't necessary in the commit title, how about Add random function with range?

Of course, @ebyhr! I'm working on the tests and as soon as I'm done I'll squash the commits.

Hello guys! I've made some adjustments. I included checkCondition for negative start and stop values. Also I've added more test cases.

LGTM except for minor comments.
Please use rebase (≠merge commit) and squash commits into one.

@ebyhr I have a question here about rebase/squash. Should I have to squash only commits and let merge commit aside, or I have to squash commits including the merge commit?

@victormazevedo "squash only commits and let merge commit aside" is the expected behavior.

@victormazevedo "squash only commits and let merge commit aside" is the expected behavior.

Ok! I'll study some way to do this. I fixed the test cases and improve them.

Merged, thanks!


4.7 regression: Array.flat(infinity) leads to "Type instantiation is excessively deep and possibly infinite." error

Bug Report

🔎 Search Terms

Array.flat
Type instantiation is excessively deep and possibly infinite.
Nested arrays

🕗 Version & Regression Information

This changed between versions 4.6 and 4.7

⏯ Playground Link

TypeScript Workbench with relevant code
💻 Code

interface Config {
  prop?: string;
}

interface ExtendedConfig extends Config {}

type NestedConfigs = Array<ExtendedConfig | NestedConfigs>;

const configs: NestedConfigs[] = [];

const flattened = configs.flat(Infinity);

🙁 Actual behavior
TypeScript raises the following error for the configs.flat(Infinity) call:
Type instantiation is excessively deep and possibly infinite. ts(2589)
🙂 Expected behavior
No error should be raised.

Ran into this today as well. 4.6 typed the output as any[]. (playground)

also ran into this in an upgrade from 4.6.4 to 4.7.2

I'm not sure what I think the correct type of the output is, but it does seem to me that the TypeScript compiler should allow .flat(Infinity) (without type assertion) without straight-up failing the compile since it is valid and common (e.g. example on MDN) JavaScript.
Maybe it would make sense to special-case Infinity to wind up with unknown[] or any[]?

This could be addressed if a literal type for Infinity was added: playground link using 1e309


add create modal optional section

It is depended on #212 (merged)

This PR adds the logic for the optional section and also introduces the fields for that section to the modal.

Reviewer: @jfurrow

This commit does contain all the commits of #212 please wait with reviewing until #212 is merged.

Could you also remove the extra lines at those places? Thx.
https://github.com/dcos/dcos-ui/pull/267/files#diff-a44f44c46bf6bdbc44737179ffb8970dL2
https://github.com/dcos/dcos-ui/pull/267/files#diff-a44f44c46bf6bdbc44737179ffb8970dR64

What do you think if we pull each section from the schema to its own file and import it separately? This would give us the advantage of not having one huge file.

Renamed the files

Nice with ice!

As discussed I'd like to move the schema into a different location (e.g. config) as it's definitely not a constant (any more). Besides that I suggest to make use of the newly introduced title attribute. But none of this is in the scope of this PR. Let's just keep it in mind while advancing the modal.

Looks good to me. Great job! Let's 🚢  🇮🇹