Clippy Errors

You might find this useful
   Compiling flac v0.4.0 (file:///home/mmstick/Programming/flac)
src/subframe/types.rs:71:1: 76:2 warning: All variants have the same prefix: `Partitioned`, #[warn(enum_variant_names)] on by default
src/subframe/types.rs:71 pub enum CodingMethod {
                         ^
src/subframe/types.rs:71:1: 76:2 help: remove the prefixes and use full paths to the variants instead of glob imports
src/subframe/types.rs:71:1: 76:2 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#enum_variant_names
<nom macros>:19:8: 19:41 warning: operator precedence can trip the unwary. Consider parenthesizing your expression:`val << (remaining - ( 8 - offset ))`, #[warn(precedence)] on by default
<nom macros>:19 acc += val << remaining - ( 8 - offset ) ; remaining -= 8 - offset ; offset =
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/subframe/parser.rs:124:38: 91:32 note: in this expansion of take_bits! (defined in <nom macros>)
src/subframe/parser.rs:124:5: 124:69 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
src/subframe/parser.rs:123:19: 125:4 note: in this expansion of try_parser! (defined in src/utility/macros.rs)
<nom macros>:19:8: 19:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
<nom macros>:19:8: 19:41 warning: operator precedence can trip the unwary. Consider parenthesizing your expression:`val << (remaining - ( 8 - offset ))`, #[warn(precedence)] on by default
<nom macros>:19 acc += val << remaining - ( 8 - offset ) ; remaining -= 8 - offset ; offset =
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<nom macros>:2:29: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/utility/macros.rs:78:5: 80:7 note: in this expansion of map! (defined in <nom macros>)
src/utility/macros.rs:83:5: 83:43 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
<nom macros>:2:29: 5:42 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/subframe/parser.rs:163:8: 91:32 note: in this expansion of map! (defined in <nom macros>)
src/subframe/parser.rs:162:3: 164:20 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
<nom macros>:19:8: 19:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
<nom macros>:19:8: 19:41 warning: operator precedence can trip the unwary. Consider parenthesizing your expression:`val << (remaining - ( 8 - offset ))`, #[warn(precedence)] on by default
<nom macros>:19 acc += val << remaining - ( 8 - offset ) ; remaining -= 8 - offset ; offset =
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<nom macros>:2:29: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/utility/macros.rs:78:5: 80:7 note: in this expansion of map! (defined in <nom macros>)
src/utility/macros.rs:83:5: 83:43 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:178:36: 43:41 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:178:18: 7:42 note: in this expansion of count_slice! (defined in src/utility/macros.rs)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:177:10: 91:32 note: in this expansion of chain! (defined in <nom macros>)
src/subframe/parser.rs:176:3: 190:17 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
<nom macros>:19:8: 19:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
<nom macros>:19:8: 19:41 warning: operator precedence can trip the unwary. Consider parenthesizing your expression:`val << (remaining - ( 8 - offset ))`, #[warn(precedence)] on by default
<nom macros>:19 acc += val << remaining - ( 8 - offset ) ; remaining -= 8 - offset ; offset =
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/subframe/parser.rs:197:51: 2:42 note: in this expansion of take_bits! (defined in <nom macros>)
src/subframe/parser.rs:197:24: 197:60 note: in this expansion of try_parse! (defined in <nom macros>)
<nom macros>:19:8: 19:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
<nom macros>:19:8: 19:41 warning: operator precedence can trip the unwary. Consider parenthesizing your expression:`val << (remaining - ( 8 - offset ))`, #[warn(precedence)] on by default
<nom macros>:19 acc += val << remaining - ( 8 - offset ) ; remaining -= 8 - offset ; offset =
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<nom macros>:2:29: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/utility/macros.rs:78:5: 80:7 note: in this expansion of map! (defined in <nom macros>)
src/utility/macros.rs:83:5: 83:43 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:218:36: 43:41 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:218:18: 7:42 note: in this expansion of count_slice! (defined in src/utility/macros.rs)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:217:10: 91:32 note: in this expansion of chain! (defined in <nom macros>)
src/subframe/parser.rs:216:3: 239:15 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
<nom macros>:19:8: 19:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
<nom macros>:19:8: 19:41 warning: operator precedence can trip the unwary. Consider parenthesizing your expression:`val << (remaining - ( 8 - offset ))`, #[warn(precedence)] on by default
<nom macros>:19 acc += val << remaining - ( 8 - offset ) ; remaining -= 8 - offset ; offset =
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<nom macros>:2:29: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/utility/macros.rs:78:5: 80:7 note: in this expansion of map! (defined in <nom macros>)
src/subframe/parser.rs:221:43: 43:42 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
<nom macros>:50:19: 53:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:38:1: 39:63 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:14:1: 17:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:217:10: 91:32 note: in this expansion of chain! (defined in <nom macros>)
src/subframe/parser.rs:216:3: 239:15 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
<nom macros>:19:8: 19:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
<nom macros>:19:8: 19:41 warning: operator precedence can trip the unwary. Consider parenthesizing your expression:`val << (remaining - ( 8 - offset ))`, #[warn(precedence)] on by default
<nom macros>:19 acc += val << remaining - ( 8 - offset ) ; remaining -= 8 - offset ; offset =
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<nom macros>:2:29: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/utility/macros.rs:78:5: 80:7 note: in this expansion of map! (defined in <nom macros>)
src/utility/macros.rs:83:5: 83:43 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:223:25: 43:41 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:222:18: 7:42 note: in this expansion of count_slice! (defined in src/utility/macros.rs)
<nom macros>:50:19: 53:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:50:19: 53:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:38:1: 39:63 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:14:1: 17:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:217:10: 91:32 note: in this expansion of chain! (defined in <nom macros>)
src/subframe/parser.rs:216:3: 239:15 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
<nom macros>:19:8: 19:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
<nom macros>:19:8: 19:41 warning: operator precedence can trip the unwary. Consider parenthesizing your expression:`val << (remaining - ( 8 - offset ))`, #[warn(precedence)] on by default
<nom macros>:19 acc += val << remaining - ( 8 - offset ) ; remaining -= 8 - offset ; offset =
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<nom macros>:2:29: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/utility/macros.rs:78:5: 80:7 note: in this expansion of map! (defined in <nom macros>)
src/utility/macros.rs:83:5: 83:43 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:246:38: 8:27 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
<nom macros>:2:29: 5:42 note: in this expansion of count! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/subframe/parser.rs:246:3: 247:33 note: in this expansion of map! (defined in <nom macros>)
<nom macros>:19:8: 19:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
<nom macros>:19:8: 19:41 warning: operator precedence can trip the unwary. Consider parenthesizing your expression:`val << (remaining - ( 8 - offset ))`, #[warn(precedence)] on by default
<nom macros>:19 acc += val << remaining - ( 8 - offset ) ; remaining -= 8 - offset ; offset =
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/subframe/parser.rs:254:48: 2:42 note: in this expansion of take_bits! (defined in <nom macros>)
src/subframe/parser.rs:254:21: 254:57 note: in this expansion of try_parse! (defined in <nom macros>)
<nom macros>:19:8: 19:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
<nom macros>:19:8: 19:41 warning: operator precedence can trip the unwary. Consider parenthesizing your expression:`val << (remaining - ( 8 - offset ))`, #[warn(precedence)] on by default
<nom macros>:19 acc += val << remaining - ( 8 - offset ) ; remaining -= 8 - offset ; offset =
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<nom macros>:6:49: 53:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:17:1: 20:47 note: in this expansion of tuple_parser! (defined in <nom macros>)
<nom macros>:2:3: 2:58 note: in this expansion of tuple_parser! (defined in <nom macros>)
<nom macros>:5:1: 6:72 note: in this expansion of tuple! (defined in <nom macros>)
<nom macros>:10:1: 10:64 note: in this expansion of pair! (defined in <nom macros>)
src/subframe/parser.rs:271:25: 2:42 note: in this expansion of pair! (defined in <nom macros>)
src/subframe/parser.rs:270:19: 271:62 note: in this expansion of try_parse! (defined in <nom macros>)
<nom macros>:19:8: 19:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
<nom macros>:19:8: 19:41 warning: operator precedence can trip the unwary. Consider parenthesizing your expression:`val << (remaining - ( 8 - offset ))`, #[warn(precedence)] on by default
<nom macros>:19 acc += val << remaining - ( 8 - offset ) ; remaining -= 8 - offset ; offset =
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/subframe/parser.rs:312:32: 43:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:311:18: 320:6 note: in this expansion of chain! (defined in <nom macros>)
<nom macros>:19:8: 19:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
<nom macros>:19:8: 19:41 warning: operator precedence can trip the unwary. Consider parenthesizing your expression:`val << (remaining - ( 8 - offset ))`, #[warn(precedence)] on by default
<nom macros>:19 acc += val << remaining - ( 8 - offset ) ; remaining -= 8 - offset ; offset =
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/subframe/parser.rs:313:59: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
src/subframe/parser.rs:313:17: 43:42 note: in this expansion of cond! (defined in <nom macros>)
<nom macros>:50:19: 53:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:311:18: 320:6 note: in this expansion of chain! (defined in <nom macros>)
<nom macros>:19:8: 19:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
<nom macros>:19:8: 19:41 warning: operator precedence can trip the unwary. Consider parenthesizing your expression:`val << (remaining - ( 8 - offset ))`, #[warn(precedence)] on by default
<nom macros>:19 acc += val << remaining - ( 8 - offset ) ; remaining -= 8 - offset ; offset =
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<nom macros>:2:29: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/utility/macros.rs:78:5: 80:7 note: in this expansion of map! (defined in <nom macros>)
src/utility/macros.rs:83:5: 83:43 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:374:11: 374:56 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
<nom macros>:19:8: 19:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
<nom macros>:19:8: 19:41 warning: operator precedence can trip the unwary. Consider parenthesizing your expression:`val << (remaining - ( 8 - offset ))`, #[warn(precedence)] on by default
<nom macros>:19 acc += val << remaining - ( 8 - offset ) ; remaining -= 8 - offset ; offset =
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/subframe/parser.rs:418:27: 141:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:50:19: 53:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:38:1: 39:63 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:415:18: 423:9 note: in this expansion of chain! (defined in <nom macros>)
<nom macros>:19:8: 19:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
src/metadata/types.rs:660:39: 660:44 warning: you should put `ID3v2` between ticks in the documentation, #[warn(doc_markdown)] on by default
src/metadata/types.rs:660 /// The picture type according to the ID3v2 attached picture frame.
                                                                ^~~~~
src/metadata/types.rs:660:39: 660:44 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#doc_markdown
src/utility/types.rs:373:20: 373:27 warning: this expression borrows a reference that is immediately dereferenced by the compiler, #[warn(needless_borrow)] on by default
src/utility/types.rs:373       from_iresult(&buffer, iresult)
                                            ^~~~~~~
src/utility/types.rs:373:20: 373:27 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_borrow
src/frame/parser.rs:44:9: 44:60 warning: The function/method "len" doesn't need a mutable reference, #[warn(unnecessary_mut_passed)] on by default
src/frame/parser.rs:44         &mut subframes[0..(frame_header.channels as usize)]
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<nom macros>:2:30: 3:75 note: in this expansion of count_slice! (defined in src/utility/macros.rs)
<nom macros>:2:1: 2:52 note: in this expansion of bits_impl! (defined in <nom macros>)
src/frame/parser.rs:41:9: 7:42 note: in this expansion of bits! (defined in <nom macros>)
<nom macros>:50:19: 53:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/frame/parser.rs:39:16: 55:4 note: in this expansion of chain! (defined in <nom macros>)
src/frame/parser.rs:44:9: 44:60 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unnecessary_mut_passed
src/frame/parser.rs:190:3: 199:4 warning: the loop variable `i` is only used to index `bytes`. Consider using `for item in bytes.iter().take(size)` or similar iterators, #[warn(needless_range_loop)] on by default
src/frame/parser.rs:190   for i in 0..size {
                          ^
src/frame/parser.rs:190:3: 199:4 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/frame/decoder.rs:11:3: 17:4 warning: the loop variable `i` is used to index `buffer`. Consider using `for (i, item) in buffer.iter().enumerate().take(block_size)` or similar iterators, #[warn(needless_range_loop)] on by default
src/frame/decoder.rs:11   for i in 0..block_size {
                          ^
src/frame/decoder.rs:11:3: 17:4 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/frame/decoder.rs:27:3: 33:4 warning: the loop variable `i` is used to index `buffer`. Consider using `for (i, item) in buffer.iter().enumerate().take(block_size)` or similar iterators, #[warn(needless_range_loop)] on by default
src/frame/decoder.rs:27   for i in 0..block_size {
                          ^
src/frame/decoder.rs:27:3: 33:4 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/frame/decoder.rs:43:3: 52:4 warning: the loop variable `i` is used to index `buffer`. Consider using `for (i, item) in buffer.iter().enumerate().take(block_size)` or similar iterators, #[warn(needless_range_loop)] on by default
src/frame/decoder.rs:43   for i in 0..block_size {
                          ^
src/frame/decoder.rs:43:3: 52:4 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/subframe/parser.rs:19:3: 41:4 warning: the loop variable `i` is used to index `bytes`. Consider using `for (i, item) in bytes.iter().enumerate().take(bytes_len)` or similar iterators, #[warn(needless_range_loop)] on by default
src/subframe/parser.rs:19   for i in 0..bytes_len {
                            ^
src/subframe/parser.rs:19:3: 41:4 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
<nom macros>:11:64: 20:8 warning: the loop variable `it` is only used to index `input`. Consider using `for item in input.iter().take(cnt + 1)` or similar iterators, #[warn(needless_range_loop)] on by default
<nom macros>:11 remaining : usize = $ count ; let mut end_offset : usize = 0 ; for it in 0 ..
                                                                               ^
src/subframe/parser.rs:124:38: 91:32 note: in this expansion of take_bits! (defined in <nom macros>)
src/subframe/parser.rs:124:5: 124:69 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
src/subframe/parser.rs:123:19: 125:4 note: in this expansion of try_parser! (defined in src/utility/macros.rs)
<nom macros>:11:64: 20:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
<nom macros>:11:64: 20:8 warning: the loop variable `it` is only used to index `input`. Consider using `for item in input.iter().take(cnt + 1)` or similar iterators, #[warn(needless_range_loop)] on by default
<nom macros>:11 remaining : usize = $ count ; let mut end_offset : usize = 0 ; for it in 0 ..
                                                                               ^
<nom macros>:2:29: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/utility/macros.rs:78:5: 80:7 note: in this expansion of map! (defined in <nom macros>)
src/utility/macros.rs:83:5: 83:43 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
<nom macros>:2:29: 5:42 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/subframe/parser.rs:163:8: 91:32 note: in this expansion of map! (defined in <nom macros>)
src/subframe/parser.rs:162:3: 164:20 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
<nom macros>:11:64: 20:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
<nom macros>:11:64: 20:8 warning: the loop variable `it` is only used to index `input`. Consider using `for item in input.iter().take(cnt + 1)` or similar iterators, #[warn(needless_range_loop)] on by default
<nom macros>:11 remaining : usize = $ count ; let mut end_offset : usize = 0 ; for it in 0 ..
                                                                               ^
<nom macros>:2:29: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/utility/macros.rs:78:5: 80:7 note: in this expansion of map! (defined in <nom macros>)
src/utility/macros.rs:83:5: 83:43 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:178:36: 43:41 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:178:18: 7:42 note: in this expansion of count_slice! (defined in src/utility/macros.rs)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:177:10: 91:32 note: in this expansion of chain! (defined in <nom macros>)
src/subframe/parser.rs:176:3: 190:17 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
<nom macros>:11:64: 20:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/subframe/parser.rs:179:20: 179:41 warning: The function/method "len" doesn't need a mutable reference, #[warn(unnecessary_mut_passed)] on by default
src/subframe/parser.rs:179                    &mut warmup[0..order]) ~
                                              ^~~~~~~~~~~~~~~~~~~~~
src/subframe/parser.rs:178:18: 7:42 note: in this expansion of count_slice! (defined in src/utility/macros.rs)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:177:10: 91:32 note: in this expansion of chain! (defined in <nom macros>)
src/subframe/parser.rs:176:3: 190:17 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
src/subframe/parser.rs:179:20: 179:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unnecessary_mut_passed
<nom macros>:11:64: 20:8 warning: the loop variable `it` is only used to index `input`. Consider using `for item in input.iter().take(cnt + 1)` or similar iterators, #[warn(needless_range_loop)] on by default
<nom macros>:11 remaining : usize = $ count ; let mut end_offset : usize = 0 ; for it in 0 ..
                                                                               ^
src/subframe/parser.rs:197:51: 2:42 note: in this expansion of take_bits! (defined in <nom macros>)
src/subframe/parser.rs:197:24: 197:60 note: in this expansion of try_parse! (defined in <nom macros>)
<nom macros>:11:64: 20:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/subframe/parser.rs:206:1: 240:2 warning: the function has a cyclomatic complexity of 35, #[warn(cyclomatic_complexity)] on by default
src/subframe/parser.rs:206 pub fn lpc<'a, S>(input: (&'a [u8], usize),
                           ^
src/subframe/parser.rs:206:1: 240:2 help: you could split it up into multiple smaller functions
src/subframe/parser.rs:206:1: 240:2 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#cyclomatic_complexity
<nom macros>:11:64: 20:8 warning: the loop variable `it` is only used to index `input`. Consider using `for item in input.iter().take(cnt + 1)` or similar iterators, #[warn(needless_range_loop)] on by default
<nom macros>:11 remaining : usize = $ count ; let mut end_offset : usize = 0 ; for it in 0 ..
                                                                               ^
<nom macros>:2:29: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/utility/macros.rs:78:5: 80:7 note: in this expansion of map! (defined in <nom macros>)
src/utility/macros.rs:83:5: 83:43 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:218:36: 43:41 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:218:18: 7:42 note: in this expansion of count_slice! (defined in src/utility/macros.rs)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:217:10: 91:32 note: in this expansion of chain! (defined in <nom macros>)
src/subframe/parser.rs:216:3: 239:15 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
<nom macros>:11:64: 20:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/subframe/parser.rs:219:20: 219:41 warning: The function/method "len" doesn't need a mutable reference, #[warn(unnecessary_mut_passed)] on by default
src/subframe/parser.rs:219                    &mut warmup[0..order]) ~
                                              ^~~~~~~~~~~~~~~~~~~~~
src/subframe/parser.rs:218:18: 7:42 note: in this expansion of count_slice! (defined in src/utility/macros.rs)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:217:10: 91:32 note: in this expansion of chain! (defined in <nom macros>)
src/subframe/parser.rs:216:3: 239:15 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
src/subframe/parser.rs:219:20: 219:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unnecessary_mut_passed
<nom macros>:11:64: 20:8 warning: the loop variable `it` is only used to index `input`. Consider using `for item in input.iter().take(cnt + 1)` or similar iterators, #[warn(needless_range_loop)] on by default
<nom macros>:11 remaining : usize = $ count ; let mut end_offset : usize = 0 ; for it in 0 ..
                                                                               ^
<nom macros>:2:29: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/utility/macros.rs:78:5: 80:7 note: in this expansion of map! (defined in <nom macros>)
src/subframe/parser.rs:221:43: 43:42 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
<nom macros>:50:19: 53:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:38:1: 39:63 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:14:1: 17:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:217:10: 91:32 note: in this expansion of chain! (defined in <nom macros>)
src/subframe/parser.rs:216:3: 239:15 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
<nom macros>:11:64: 20:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
<nom macros>:11:64: 20:8 warning: the loop variable `it` is only used to index `input`. Consider using `for item in input.iter().take(cnt + 1)` or similar iterators, #[warn(needless_range_loop)] on by default
<nom macros>:11 remaining : usize = $ count ; let mut end_offset : usize = 0 ; for it in 0 ..
                                                                               ^
<nom macros>:2:29: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/utility/macros.rs:78:5: 80:7 note: in this expansion of map! (defined in <nom macros>)
src/utility/macros.rs:83:5: 83:43 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:223:25: 43:41 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:222:18: 7:42 note: in this expansion of count_slice! (defined in src/utility/macros.rs)
<nom macros>:50:19: 53:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:50:19: 53:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:38:1: 39:63 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:14:1: 17:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:217:10: 91:32 note: in this expansion of chain! (defined in <nom macros>)
src/subframe/parser.rs:216:3: 239:15 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
<nom macros>:11:64: 20:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/subframe/parser.rs:224:9: 224:40 warning: The function/method "len" doesn't need a mutable reference, #[warn(unnecessary_mut_passed)] on by default
src/subframe/parser.rs:224         &mut qlp_coefficients[0..order]
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/subframe/parser.rs:222:18: 7:42 note: in this expansion of count_slice! (defined in src/utility/macros.rs)
<nom macros>:50:19: 53:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:50:19: 53:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:38:1: 39:63 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:14:1: 17:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:217:10: 91:32 note: in this expansion of chain! (defined in <nom macros>)
src/subframe/parser.rs:216:3: 239:15 note: in this expansion of to_custom_error! (defined in src/utility/macros.rs)
src/subframe/parser.rs:224:9: 224:40 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unnecessary_mut_passed
<nom macros>:11:64: 20:8 warning: the loop variable `it` is only used to index `input`. Consider using `for item in input.iter().take(cnt + 1)` or similar iterators, #[warn(needless_range_loop)] on by default
<nom macros>:11 remaining : usize = $ count ; let mut end_offset : usize = 0 ; for it in 0 ..
                                                                               ^
<nom macros>:2:29: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/utility/macros.rs:78:5: 80:7 note: in this expansion of map! (defined in <nom macros>)
src/utility/macros.rs:83:5: 83:43 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:246:38: 8:27 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
<nom macros>:2:29: 5:42 note: in this expansion of count! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/subframe/parser.rs:246:3: 247:33 note: in this expansion of map! (defined in <nom macros>)
<nom macros>:11:64: 20:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
<nom macros>:11:64: 20:8 warning: the loop variable `it` is only used to index `input`. Consider using `for item in input.iter().take(cnt + 1)` or similar iterators, #[warn(needless_range_loop)] on by default
<nom macros>:11 remaining : usize = $ count ; let mut end_offset : usize = 0 ; for it in 0 ..
                                                                               ^
src/subframe/parser.rs:254:48: 2:42 note: in this expansion of take_bits! (defined in <nom macros>)
src/subframe/parser.rs:254:21: 254:57 note: in this expansion of try_parse! (defined in <nom macros>)
<nom macros>:11:64: 20:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
<nom macros>:11:64: 20:8 warning: the loop variable `it` is only used to index `input`. Consider using `for item in input.iter().take(cnt + 1)` or similar iterators, #[warn(needless_range_loop)] on by default
<nom macros>:11 remaining : usize = $ count ; let mut end_offset : usize = 0 ; for it in 0 ..
                                                                               ^
<nom macros>:6:49: 53:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:17:1: 20:47 note: in this expansion of tuple_parser! (defined in <nom macros>)
<nom macros>:2:3: 2:58 note: in this expansion of tuple_parser! (defined in <nom macros>)
<nom macros>:5:1: 6:72 note: in this expansion of tuple! (defined in <nom macros>)
<nom macros>:10:1: 10:64 note: in this expansion of pair! (defined in <nom macros>)
src/subframe/parser.rs:271:25: 2:42 note: in this expansion of pair! (defined in <nom macros>)
src/subframe/parser.rs:270:19: 271:62 note: in this expansion of try_parse! (defined in <nom macros>)
<nom macros>:11:64: 20:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
<nom macros>:11:64: 20:8 warning: the loop variable `it` is only used to index `input`. Consider using `for item in input.iter().take(cnt + 1)` or similar iterators, #[warn(needless_range_loop)] on by default
<nom macros>:11 remaining : usize = $ count ; let mut end_offset : usize = 0 ; for it in 0 ..
                                                                               ^
src/subframe/parser.rs:312:32: 43:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:311:18: 320:6 note: in this expansion of chain! (defined in <nom macros>)
<nom macros>:11:64: 20:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
<nom macros>:11:64: 20:8 warning: the loop variable `it` is only used to index `input`. Consider using `for item in input.iter().take(cnt + 1)` or similar iterators, #[warn(needless_range_loop)] on by default
<nom macros>:11 remaining : usize = $ count ; let mut end_offset : usize = 0 ; for it in 0 ..
                                                                               ^
src/subframe/parser.rs:313:59: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
src/subframe/parser.rs:313:17: 43:42 note: in this expansion of cond! (defined in <nom macros>)
<nom macros>:50:19: 53:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:311:18: 320:6 note: in this expansion of chain! (defined in <nom macros>)
<nom macros>:11:64: 20:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
<nom macros>:11:64: 20:8 warning: the loop variable `it` is only used to index `input`. Consider using `for item in input.iter().take(cnt + 1)` or similar iterators, #[warn(needless_range_loop)] on by default
<nom macros>:11 remaining : usize = $ count ; let mut end_offset : usize = 0 ; for it in 0 ..
                                                                               ^
<nom macros>:2:29: 5:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:2:1: 2:68 note: in this expansion of map_impl! (defined in <nom macros>)
src/utility/macros.rs:78:5: 80:7 note: in this expansion of map! (defined in <nom macros>)
src/utility/macros.rs:83:5: 83:43 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
src/subframe/parser.rs:374:11: 374:56 note: in this expansion of take_signed_bits! (defined in src/utility/macros.rs)
<nom macros>:11:64: 20:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
<nom macros>:11:64: 20:8 warning: the loop variable `it` is only used to index `input`. Consider using `for item in input.iter().take(cnt + 1)` or similar iterators, #[warn(needless_range_loop)] on by default
<nom macros>:11 remaining : usize = $ count ; let mut end_offset : usize = 0 ; for it in 0 ..
                                                                               ^
src/subframe/parser.rs:418:27: 141:42 note: in this expansion of take_bits! (defined in <nom macros>)
<nom macros>:50:19: 53:39 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:38:1: 39:63 note: in this expansion of chaining_parser! (defined in <nom macros>)
<nom macros>:2:3: 2:54 note: in this expansion of chaining_parser! (defined in <nom macros>)
src/subframe/parser.rs:415:18: 423:9 note: in this expansion of chain! (defined in <nom macros>)
<nom macros>:11:64: 20:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/subframe/decoder.rs:93:7: 95:8 warning: the loop variable `i` is only used to index `output`. Consider using `for item in &output` or similar iterators, #[warn(needless_range_loop)] on by default
src/subframe/decoder.rs:93       for i in 0..output.len() {
                                 ^
src/subframe/decoder.rs:93:7: 95:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/subframe/decoder.rs:105:7: 109:8 warning: the loop variable `i` is used to index `output`. Consider using `for (i, item) in output.iter().enumerate().take(order)` or similar iterators, #[warn(needless_range_loop)] on by default
src/subframe/decoder.rs:105       for i in 0..order {
                                  ^
src/subframe/decoder.rs:105:7: 109:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/subframe/decoder.rs:117:7: 121:8 warning: the loop variable `i` is used to index `output`. Consider using `for (i, item) in output.iter().enumerate().take(order)` or similar iterators, #[warn(needless_range_loop)] on by default
src/subframe/decoder.rs:117       for i in 0..order {
                                  ^
src/subframe/decoder.rs:117:7: 121:8 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/metadata/types.rs:141:13: 141:27 warning: unused import, #[warn(unused_imports)] on by default
src/metadata/types.rs:141         use std::io::Write;
                                      ^~~~~~~~~~~~~~
src/metadata/types.rs:212:13: 212:27 warning: unused import, #[warn(unused_imports)] on by default
src/metadata/types.rs:212         use std::io::Write;
                                      ^~~~~~~~~~~~~~
src/metadata/types.rs:277:3: 289:4 warning: you should consider deriving a `Default` implementation for `metadata::types::StreamInfo`, #[warn(new_without_default_derive)] on by default
src/metadata/types.rs:277   pub fn new() -> StreamInfo {
                            ^
src/metadata/types.rs:277:3: 289:4 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#new_without_default_derive
src/metadata/types.rs:277:3: 289:4 help: try this
src/metadata/types.rs:      #[derive(Default)]
src/metadata/metadata.rs:264:1: 307:2 warning: this function has too many arguments (8/7), #[warn(too_many_arguments)] on by default
src/metadata/metadata.rs:264 pub fn get_picture(filename: &str,
                             ^
src/metadata/metadata.rs:264:1: 307:2 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#too_many_arguments
src/stream.rs:159:39: 159:50 warning: this `match` has identical arm bodies, #[warn(match_same_arms)] on by default
src/stream.rs:159         Err(_)                     => return None,
                                                        ^~~~~~~~~~~
src/stream.rs:157:39: 157:50 note: same as this
src/stream.rs:157         Err(ErrorKind::EndOfInput) => return None,
                                                        ^~~~~~~~~~~
src/stream.rs:159:39: 159:50 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#match_same_arms
src/stream.rs:143:11: 151:12 warning: the variable `channel` is used as a loop counter. Consider using `for (channel, item) in &frame.subframes[0..channels].enumerate()` or similar iterators, #[warn(explicit_counter_loop)] on by default
src/stream.rs:143           for subframe in &frame.subframes[0..channels] {
                            ^
src/stream.rs:143:11: 151:12 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_counter_loop
src/stream.rs:148:30: 148:39 warning: this expression borrows a reference that is immediately dereferenced by the compiler, #[warn(needless_borrow)] on by default
src/stream.rs:148             subframe::decode(&subframe, block_size, output);
                                               ^~~~~~~~~
src/stream.rs:148:30: 148:39 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_borrow

A majority of these errors are from nom marco but I fixed the ones that were appropriate. Thanks for reporting this issue.

If you would like, I can also fix many of the other errors, such as the needless_borrow errors, explicit_counter_loop, unnecessary_mut_passed, and the needless_range_loop

Go for it. I've look into the needless_borrow  and unnecessary_mut_passed and they seem necessary. For example, the borrow being immediately dereferenced was because I'm also doing a mutable borrow later in the function. And the macros that take mutable borrow are being mutated in the macro.


update grpc to 1.45.1

Thanks @n-oden. I was waiting for Okhttp 3/4 support, so that we can add another implementation in clickhouse-http-client without outdated dependencies :) Could you also update third-party-libraries since grpc-java still does not support JPMS(even 1.46)?
By the way, is your work depending on the new version? FYI, it's probably not worthy of using gRPC with ClickHouse at this point due to the performance issue mentioned at here.

I see. But why not use shaded jar instead?
Anyway, protobuf should be updated as well or the code generated by protoc won't work. I don't have privilege to update your branch so I'll fix that in a separate PR.


tests: Added ZulipTestCase.example_user() function.

The example_user() function is specifically designed for
AARON, hamlet, cordelia, and friends, and it allows a concise
way of using their built-in user profiles. Eventually, the
widespread use of example_user() should help us with refactorings
such as moving the tests users out of the "zulip.com" realm
and deprecating get_user_profile_by_email.

Automated message from Dropbox CLA bot
@showell, it looks like you've already signed the Dropbox CLA. Thanks!

This looks great, merged, thanks @showell!  I posted one comment that I think is important for future work on this area.


The purpose of the Picker component [Android]

Hi there - the dropdown Picker component seems very confusing to me, especially in the Android context. It doesn't at all behave the way I need it to, which means that either I should seek out another component, or figure out how to use it correctly. There are two cases I see for it, but right now it only satisfies one.
In the first case, the picker toggles something - at any given time, a value must be selected. Opening the picker and tapping the currently selected value should do nothing. This is the case that the current Picker satisfies.
In the second case, the picker is simple a menu of options, and any one can be selected, repeatedly if need be. Basically, the behavior of the overflow action menu in Android. Right now, I have been totally unable to get the picker to work like this.
So my question is, if I want overflow-menu-like behavior, what should I do (do I need to write my own native component for this)? I need custom toolbar layouts, so using the built in ToolbarAndroid isn't an option.
I have only found one issue that discussed this briefly but I'm interested to hear what others think of this.
Thanks!

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/the-purpose-of-the-picker-component-android
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.


Nodes Created When Querying Edges from Graph Editor

OrientDB Version: 2.2.21
Java Version: openjdk version "1.8.0_131"
OS: Ubuntu 17.04
Expected behavior
SELECT should not mutate graph
Actual behavior
After creating two nodes (A, B), and two edges (A->B, B->B), and performing two SELECT commands inside the studio graph editor, on the second (and subsequent) SELECTs three new vertices are created, duplicating B.
Steps to reproduce
Create a new database, and set up the following schema:
CREATE CLASS foo EXTENDS V
CREATE CLASS bar EXTENDS V
CREATE CLASS barfoo EXTENDS E
CREATE CLASS barbar EXTENDS E

Run the following batch:
BEGIN
LET foo = CREATE VERTEX foo
LET bar = CREATE VERTEX bar
CREATE EDGE barfoo FROM $bar TO $foo
CREATE EDGE barbar FROM $bar TO $bar
LET result = SELECT $first AS tail,$last AS head FROM $foo LET first = in('barfoo')[0],last = $first.out('barbar')
COMMIT
RETURN $result

Then, in the graph editor (this error only occurs from the graph editor):
SELECT FROM V
The two vertices created in the batch appear.
SELECT FROM E
Three new vertices (of class 'bar') are added. From now on, this can be repeated, with three new vertices being added with each SELECT FROM E command.
Also, notably, no edges appear in the editor.

Hi @TropicalPenguin
I'm working to a fix, I'll let you know soon
Thanks
Luigi

Hi @TropicalPenguin
I just pushed a fix for this problem, you can find it in branch 2.2.x.
The fix will be released with 2.2.22
Please consider that edges created with the script you posted are broken, so you have to drop and re-create them to have a consistent db
Thanks
Luigi


MisconfigurationError: No TPU devices were found even when TPU is connected

Have been frustrated over the past few hours over a problem, though It's likely its a problem I started myself hah.
I'm trying to connect to the TPU in Colab. I'm pretty sure I've gotten all the import stuff down. My code is here. I'm not completely set on everything, so the entire document isn't functional, but you should be able to see my attempts at TPU connection.
I'm running Pytorch in version 1.5.0 and torchvision in 0.6.0 because I was finding I couldn't install XLA with anything later than 1.5.0. I'm running XLA in version 20200325.
This is the image that seems so confusing: It states that we have a connection with xla: 1 yet when trying to flag it in the trainer I get an error saying no TPUs can be found.

If anyone could help me, that would be amazing.
Thanks,
A

the notebook is a bit long to find the issue. Mind reproduce it with https://colab.research.google.com/drive/1HvWVVTK8j2Nj52qU4Q4YCyzOm0_aLQF3?usp=sharing??

@rohitgr7 here is a repro using TheBoringModel: https://colab.sandbox.google.com/drive/1VPjiQj6VitN-losLO5J5IEuepcFa6Meu#scrollTo=AAtq1hwSmjKe
I added a cell at the beginning as described in https://pytorch-lightning.readthedocs.io/en/latest/tpu.html#colab-tpus

@zcain117 not able to open it. Mind update the permissions??

Here is a version using the cell from latest documentation: https://colab.research.google.com/drive/1tBExbwIy9NoP-YdWcnLBLRZtmsTIsV5g#scrollTo=DEi2_1B4Krf3
Here is a version using torch-xla-1.7: https://colab.research.google.com/drive/1BdRiZeX-S9RlFONyvlR-VexELrcAhYaX#scrollTo=DEi2_1B4Krf3

both are working fine for me. I just enabled TPU env in colab and set Trainer(..., tpu_cores=8).

Thanks for checking. I changed nothing at all and now these are working for me too :)
What did you mean by restart the notebook first after installing xla_wheel? Is this the same as restarting the runtime?
I think I did some version of this too, the 1.7 version crashed a few times and I went through a few iterations of restarting the runtime and/or refreshing the colab page and now the notebook runs.
Maybe there is some intermittent problem TPU initialization behind the scenes in Colab. Sorry for the false alarm

What did you mean by restart the notebook first after installing xla_wheel? Is this the same as restarting the runtime?`

yes.


smartcast cancel

At the moment, there is no way to cancel a smartcast action, which makes the feature quite useless.

There is, however it is not necessarily intuitive, as you have to press one of the modifier keys while still holding the ability key, OR you could bind a smartcast cancel onto a key

How would that smartcast-cancelling key work? In general I mean, since this config can take any form the user wants.

so the key is bound to:
"dota_ability_execute 1; bind key smartcast_1"
where -smartcast_1 is aliased to quick-cast on release. Then the cancel button executes:
alias "smartcast_1" "smartcast_reset_1"
where smartcast_reset_1 is:
alias smartcast_1 dota_ablitity_quick_cast 1

basic logic, but can be implemented a lot nicer

Yeah, sounds like it would work. Need to see when I find time to do that fix.


Support the access address of CDN

can you be more specific?

For example, my entoint is s3.xxx.com, and the access address through the CDN is cdn.xxx.com, so I hope to automatically rewrite the access link to https://cdn.xxx.com instead of https://s3.xxxx .com/

The plug -in work is very good, there is no error. What I mentioned is a feature. I want to be able to add a configuration general, rewrite the actual access address of the picture, the CDN access speed will be faster

Yes, ￼Hope to add this option, thank you

I'm leaning towards not implementing this for now.  It's probably not a lot of work, however, it seems like a bit of an overkill.  Obsidian is a personal knowledge management program.  The links that are created here are for personal use.  A CDN is designed to give a worldwide audience fast access to the resources.  Using cloudfront vs. regular s3, for example, might shave a few milliseconds off the page load time but the single user is the only one who might notice.  I don't see the benefit.
On the other hand, if you feel like implementing it, I'm happy to consider PR's.
If you have a specific use case or performance issue you are trying to address that would justify the additional expense and trouble of CDN hosting, please let me know.

Obidian can not only manage personal knowledge base, but also use it to write blogs. If you can put cdn's picture links, I can make it more convenient for everyone to visit after publishing the article.

I'm using typecho, and there are no relevant plug-ins now, so I can only copy it manually. I saw that there is a wordpress plug-in that can be released directly.

playing devils advocate here, it sounds like it could be accomplished using find/replace, no?


Implement methods and write unit tests

Project Requirements

[ ] Create a Game class in a separate .rb file.

[ ] Create an Author class with an association to the Item class (in a separate .rb file).

[ ] All Game class properties visible in the diagram should be defined and set up in the constructor method.

[ ] All Author class properties visible in the diagram should be defined and set up in the constructor method.

[ ] Implement methods:

add_item method in the Author class
should take an instance of the Item class as an input
should add the input item to the collection of items
should add self as a property of the item object (by using the correct setter from the item object)

can_be_archived?() in the Game class
should override the method from the parent class
should return true if parent's method returns true AND if last_played_at is older than 2 years
otherwise, it should return false

[ ] Add unit tests for all implemented methods.

Thanks @arabiu033 😅


Fix HTTP Foxx API Json parsing (devel)

lgtm.
I'm a bit confused. I'm extremely certain I've made this change before but it's neither in devel nor 3.2. It also doesn't seem to be in the PR that introduced the new behaviour: https://github.com/arangodb/arangodb/pull/2688
I'm guessing I remember wrong and the PR simply didn't consider JSON.


feat: allow logout with the default SS4 handler

This addresses #23 - the solution seems to be very simple - just return the default LogoutHandler which is still pretty much available even after disabling the default authenticator.

Thank you!


OLS-105: Add ability to filter terms in user query

Description
Adds ability to specify list of Regex and redact string in olsconfig yaml. This will be used to redact questions/queries from user to avoid sensitive information from queries.
Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] PR has passed all pre-merge test jobs.
[x] If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

/test e2e-ols-bam-granite13b-chat-v2

/assign @syedriko
/assign @tisnik

@xrajesh What I'm wondering, is the user going to see the redacted bits in the replies from the LLM or are we looking to redact things between the OLS and the LLM and unredact them between the user and the OLS.

@syedriko The real user will not be able to see the actual questions sent to LLM. But the admins will use this to configure their filter words . They will be able to see the actual questions, ONLY in the logs :)

@syedriko The real user will not be able to see the actual questions sent to LLM. But the admins will use this to configure their filter words . They will be able to see the actual questions, ONLY in the logs :)

Let's say a user asks (a contrived example) "How can I schedule a pod on a node with IP <IP_ADDRESS>?" and the OLS is configured to replace IPs with redacted_ip, isn't the user going to get a reply with redacted_ip in it, like
"First apply a label to the node:
$ oc label nodes  mynodeip=redacted_ip
"
?

@syedriko The user can even replace his/her real ip with ""(empty str) or give a fake ip like <IP_ADDRESS> - Goal is to mask the users identity.

Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (7a442ce) 96.08% compared to head (2a23bcb) 95.15%.
Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   96.08%   95.15%   -0.94%
==========================================
  Files          32       33       +1
  Lines        1073     1156      +83
==========================================
+ Hits         1031     1100      +69
- Misses         42       56      +14

Files
Coverage Δ

ols/app/endpoints/ols.py
95.83% <75.00%> (-4.17%)
:arrow_down:

ols/utils/question_filter.py
90.32% <90.32%> (ø)

ols/app/models/config.py
96.16% <82.92%> (-1.56%)
:arrow_down:

... and 3 files with indirect coverage changes

/approve
one last nit that i see, but will let the other reviewers take another pass also to ensure their comments are satisfactorily addressed

/lgtm

/lgtm

/lgtm


glTF import-export

I did not play with the js code for years now so it will be hard for me to dig back to it. But I do believe but, I might be mistaken..... that it won't be hard to include export to this format since it already has a lot of API's that allows to do it to different file formats as for an example:
https://github.com/KhronosGroup/glTF#converters-importers-and-exporters
Or export to JSON format would that be possible?

It's possible but I'm not maintaining sculptgl anymore.


Sparse.Matrix.fromAssocList computes incorrect matrix size

Finding the dimensions of a matrix requires finding the maximum row and col index in the association list. This code block finds the maximum of a tuple:
-- | Converts associative list to sparse matrix,
--   using maximal index as matrix size
fromAssocList :: (Num α, Eq α) => [ ((Index,Index), α) ] -> SparseMatrix α
fromAssocList l = fromAssocListWithSize (L.maximum $ fmap fst l) l

(in file sparse-lin-alg/Math/LinearAlgebra/Sparse/Matrix.hs)
which is wrong since (99999, 0) > (10000, 10000) == True. I'll submit a pull request for this issue in the afternoon.


Fix tests on older rubies

Don't try to bring in new activesupport on versions of Ruby that don't
support it

@seejohnrun thanks for taking a crack at this. I agree with your use of Gem::Version. After I submitted my PR here, I fixed another 2.4 issue on another gem here using that api.
Here is how Rails handled supporting 2.4 in rails 4.2: https://github.com/rails/rails/pull/27473

my pleasure
I'm merging this for now, can you rebase your branch on top of this?


          -L ../lib -lfeqparse
!
! References:
!
!   https://en.wikipedia.org/wiki/Van_der_Pol_oscillator#Hamiltonian_for_Van_der_Pol_oscillator
!
!   https://en.wikipedia.org/wiki/Van_der_Pol_oscillator#Forced_Van_der_Pol_oscillator
!

program feqparse_demo

  use feqparse

  implicit none

  integer, parameter :: DP = selected_real_kind(12,60)
  integer, parameter :: WP = DP

  type(equationparser) :: f
  character(len=128) :: fun_buf
  real(WP) :: t, x, y, u, v

  fun_buf = '-8.53*(1-x*x)*v-y'
  f = equationparser('f = '//fun_buf, ['t','x','y','u','v'])

  t = 0
  x = 1
  y = 3
  u = 12
  v = 0

  ! (A)
  print *, f%evaluate([ t,x,y,u,v ])

  print *

  ! (B)
  print *, -8.53_WP*(1-x*x)*v-y

end program feqparse_demo

the print in (A) prints 3 instead of -3 as one can easily to compute manually or with the print in (B).
As workaround one has to write the function enclosing the constant in (), i.e.:
fun_buf = '(-8.53)*(1-x*x)*v-y'

Thanks for sharing. Something must be up with the monad token priority. I'll get this example added to the tests and work towards a solution as soon as possible.

Taking a look at this now . We'll be adding this example to the test suite as  well - thanks for reporting.

@angelog0 - This issue has been resolved in PR #34 . When you have a moment, check out the latest version on the master branch and let us know if all looks good on your end. Feel free to re-open this issue if you're still having the same problem.

Yes, it is fixed. Thanks.
I want just to flag that building the modules with GFortran 14.1.0 there are some warnings which, maybe, you want to eliminate:
gfortran -Wall -std=f2018 -fmax-errors=1 -O3 -fPIC -c FEQParse_TokenStack.f90 FEQParse_Functions.f90  FEQParse_FloatStacks.f90 FEQParse.f90
FEQParse_Functions.f90:540:35:

   96 |     pure real(real32) function randomize_r32()
      |                                            2
......
  540 | real(real32) function randomize_r32()
      |                                   1
Warning: Mismatch in PURE attribute between (1) and (2)
FEQParse_Functions.f90:548:35:

  102 |     pure real(real64) function randomize_r64()
      |                                            2
......
  548 | real(real64) function randomize_r64()
      |                                   1
Warning: Mismatch in PURE attribute between (1) and (2)
FEQParse_Functions.f90:511:18:

  511 |     integer :: i,j
      |                  1
Warning: Unused variable 'j' declared at (1) [-Wunused-variable]
FEQParse_Functions.f90:502:21:

  502 |     real(real64) :: r
      |                     1
Warning: Unused variable 'r' declared at (1) [-Wunused-variable]
FEQParse_Functions.f90:493:21:

  493 |     real(real32) :: r
      |                     1
Warning: Unused variable 'r' declared at (1) [-Wunused-variable]
FEQParse_Functions.f90:523:2:

  523 |   pure function ToLowerCase(str) result(res)
      |  ^
Warning: 'tolowercase' defined but not used [-Wunused-function]
FEQParse.f90:1682:34:

 1682 |   integer function Priority(parser,toke)
      |                                  1
Warning: Unused dummy argument 'parser' at (1) [-Wunused-dummy-argument]
FEQParse.f90:1667:2:

 1667 |   function ToLowerCase(str) result(res)
      |  ^
Warning: 'tolowercase' defined but not used [-Wunused-function]

Thanks for sharing. We're currently working through trimming out code that's not tested (by this point we assume it means its not useful) and ToLowerCase is on our list. I've got a local branch at the moment with unused variables cleaned out.
I need to see what is meant by the issue with the randomize routines.
Keep an eye on the repo. More documentation is coming soon and we're knocking out a few more feature requests in the coming weeks!
If you haven't already, give feqparse a star on GitHub 🙂


Improve mean_squared_error

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (395d58c) to head (a8e6e4c).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #277   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           97        97
  Lines         2358      2358
  Branches       214       214
=========================================
  Hits          2358      2358

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: home screen mvp

SUMMARY
This PR introduces the new homescreen that the user will first interact with on login. The pr also decouples the card components from chartlist and dashboardlist components so that they both can be used more readily throughout homescreen.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN
Test Plan includes unit test and end to end test which are in development and will be updated during this review.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[x] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[x ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #11206 into master will decrease coverage by 4.63%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #11206      +/-   ##
==========================================
- Coverage   65.43%   60.79%   -4.64%
==========================================
  Files         829      392     -437
  Lines       39200    24555   -14645
  Branches     3693        0    -3693
==========================================
- Hits        25649    14928   -10721
+ Misses      13444     9627    -3817
+ Partials      107        0     -107

Flag
Coverage Δ

#cypress
?

#javascript
?

#python
60.79% <100.00%> (+0.18%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/charts/api.py
74.56% <ø> (ø)

superset/dashboards/api.py
80.86% <ø> (ø)

superset/queries/api.py
100.00% <ø> (ø)

superset/config.py
90.07% <100.00%> (ø)

superset/queries/saved_queries/api.py
96.29% <100.00%> (ø)

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/db_engine_specs/presto.py
73.65% <0.00%> (-8.43%)
:arrow_down:

superset/utils/celery.py
82.14% <0.00%> (-3.58%)
:arrow_down:

superset/examples/world_bank.py
97.10% <0.00%> (-2.90%)
:arrow_down:

superset/examples/birth_names.py
97.36% <0.00%> (-2.64%)
:arrow_down:

... and 439 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9785667...f190768. Read the comment docs.

A few other little things that we discussed in person. They should not be blockers here, and could be followed up on other PRs, but I wanted to put them "on paper":

It would be great to share/reuse the media queries with cards (keeping it DRY), so they benefit other card views.
Maybe instead of living in superset-frontend/src/views/CRUD/welcome it should live in superset-frontend/src/views/welcome as its own thing.
If _may be of benefit to decouple all the card variants (Recent/Chart/Dashboard/SavedQuery/(eventually...)SearchResult). If doing so, then they should all probably continue to use the common ListVIewCard under the hood, which could be renamed as BaseCard or similar. All of these could live in the main components directory, perhaps hierarchically nested.

FYI, @riahk also created an empty list state in https://github.com/apache/incubator-superset/pull/11432

something looks a little off here .... 4k changes and 119 files changed 🤔

something looks a little off here .... 4k changes and 119 files changed 🤔

Looks like commits from master got merged in here rather than a rebase.

I'm confused why github is including them here, they have the same hash as the ones on master, it shouldn't be picking them up as a new commits in this branch

I think it's because of package-lock.json

Couldn't continue with reviewing because this PR really needs a rebase. The diff is too large.
After rebasing, you should have only 35 changes files instead of 119.
https://github.com/apache/incubator-superset/compare/master...ktmud:home-screen-mvp

Couldn't continue with reviewing because this PR really needs a rebase. The diff is too large.
After rebasing, you should have only 35 changed files instead of 119.
master...ktmud:home-screen-mvp

All cleared up now, back to 34 files. Thanks for your input so far. Good to have fresh eyes on this.

A huge milestone! Thanks for all the great work @pkdotson and bearing with the back and forth. Looking forward to more exciting improvements to come!

🥺 thank you @pkdotson so proud of you!!


Overlay missing on older youtube verdion (16.45.4)

On older youtube versio, overlay appears only when you drag the video progress bar.
After you draggee video to the  required moment, and when the video player interface is automatically hidden - the overlay buttons disappear again.
To make them reappear, it is needed to drag video progress bar again. Only like that.
On latest version everryghing works fine

Can't seem to reproduce this issue on my iPad.

Fixed in v1.1.6


long_description broken when uploading wheel

Describe the bug
I'm seeing broken descriptions when releasing new wheels made with the latest version of wheel. I had been using twine to upload, but using python setup.py bdist_wheel upload produces the same problem. I can get the long description to render when I upload the raw source only (python setup.py sdist upload), but when I switch to uploading the wheel, the long description breaks. I've confirmed this issue with two separate projects so it seems easily reproducible.
Expected behavior
python setup.py bdist_wheel upload should upload the wheel and result in the long description being rendered on PyPi.org.
To Reproduce

create a new project with a setup.py:

from setuptools import setup
setup(
    ...
    long_description='# Top Level Header',
    long_description_content_type='text/markdown',
    ...
)

try to release using python setup.py bdist_wheel upload or python setup.py bdist_wheel && twine upload dist/*
observe that the project's page on PyPi is not rendering the markdown long_description

My Platform

package
version

wheel
0.31.1

setuptools
39.0.1

twine
1.11.0

@Kautenja Can you link to the projects with broken descriptions?
Twine should be working, but distutils (python setup.py upload) doesn't support Metadata 2.1, so if you want to use a Markdown description, you must use twine to upload.

Yes the projects are https://pypi.org/project/gym-tetris/ and https://pypi.org/project/gym-super-mario-bros/
Oddly, after revisiting the projects, it appears that the offending line is actually trying to upload both source and wheel, causing the failure to render long_description:
python setup.py sdist bdist_wheel && twine upload dist/*

uploading just the source or just the wheel using either of the below commands works as expected with the long_description being rendered.
python setup.py bdist_wheel && twine upload dist/*

python setup.py sdist && twine upload dist/*

Perhaps uploading both the source and the wheel is simply not a supported feature?

After publishing a new release just now (python setup.py bdist_wheel && twine upload dist/*) for https://pypi.org/project/gym-tetris/, it appears rendering of long_description has randomly stopped working again.

@Kautenja The .whl distribution for gym-tetris==1.2.0 was built with wheel==0.30.0.
$ unzip -c gym_tetris-1.2.0-py3-none-any.whl gym_tetris-1.2.0.dist-info/WHEEL | grep Generator
Generator: bdist_wheel (0.30.0)

You need to use wheel>=0.31.0 here, versions before that do not support Metadata 2.1.

It seems that the issue has resolved itself. I can now upload both source and wheel without a hitch reliably. Perhaps the version of wheel was to blame all along. Closing this issue.


Allow allowUnmocked to hit base path

I know the intent of return this._key.indexOf(matchKey) === 0; was to find potential matches before the body gets passed to the request, but inadvertently it disallowed requests to '/' because every URL for a given host always contains the base.
I made the potential match slightly more strict and added a test for it.
Also, upgraded Tap (which gives us a lot of nice CLI options to work with).

Yup, true, thanks for the contribution!
v0.9.1 is out.


[flutter_tools] move update-packages to repo tools

Description
Move the actual implementation of update_packages to dev/tools and forward flutter update packages to it. This will allow us to gradually fix testing/documentation that directs to flutter update-packages, before a warning/deprecation is added.
Part of https://github.com/flutter/flutter/issues/50646

Thinking about this more, should we move these development scripts into a package à la plugin_tools? Does this need to live in the repo?

Seems like a natural next step, but its not the immediate problem I'm trying to solve - which is preventing end users from borking their flutter checkouts

Seems like a natural next step, but its not the immediate problem I'm trying to solve - which is preventing end users from borking their flutter checkouts

Your Flutter Tool Command Clean-up 2020 doc update-packages deprecation plan:

Move this functionality in dev/bots/tools or similar location. Do not introduce warning since it is useless outside of flutter repo.

It's gotta move somewhere, and the fewer times we move it the fewer scripts to update and migrate.  But obviously that's a lot more work, we can discuss in that doc.  Might be worth setting up that infrastructure before the next command gets moved into dev/tools.


can not click dom element in iOS11.3

can not click dom element when app resume from background, but run normal when disable fastclick

I got the same and cannot scroll as well, do you?

Maybe linked to this note in 11.3 release note ?
https://stackoverflow.com/questions/49500339/cant-prevent-touchmove-from-scrolling-window-on-ios
(document touch event listeners are now passive by default in Safari 11.1, which is bundled with iOS 11.3. This change is documented in the Safari 11.1 release notes:)
Web APIs
[…]
Updated root document touch event listeners to use passive mode improving scrolling performance and reducing crashes.

Seems to fixed now. Issue was due to iOS bug reporting touch event timestamp as negative value

Big like to you @nolimits4web you did a great job, will there be any emergency release?

@robinyip today will be a regular release with this fix included

Great and thanks for your efforts

@nolimits4web ,  i saw it was fixed in v2.x, may i know it will be fixed in v1.x also? due to we are using v1.x version, thanks.

thanks for fixing, may i know this fixing is for both 1.x and 2.x ?

@zdnet look like in 1.7.1 the fix is there. You can check here https://github.com/framework7io/framework7/commit/08d98477e3cff0cfb2b88666338077b7a58f6730

thanks for fixing


Refined variable can't be returned

I was wondering why the example code in Why do we need static analysis (Playground)
function deserializeUser(stringifiedUserJson) {
  const maybeUser = JSON.parse(stringifiedUserJson);
  if (
    typeof maybeUser === "object" &&
    maybeUser !== null &&
    "name" in maybeUser &&
    typeof maybeUser.name === "string"
  ) {
    return maybeUser;
  }
  throw new TypeError("Provided serialized user is invalid!");
}

The inferred type for deserializeUser was (string) => unknown throws SyntaxError | TypeError. I was expecting it to be (string) => { name: string, ... } throws SyntaxError | TypeError.
So I changed it to have a User type and found this bug...

It says the type of maybeUser is { 'name': string, ... } and below the error:
Type UNKNOWN is incompatible with "{ 'name': string, ... }"

I mean the affirmation is right but maybeUser is not unknown here.
Playground

Fixed and will be available in the next Hegel version.


Title collides with the label on the right.

When I have a long title on a chord chart it runs over the label. Try this visualization to reproduce.
data('https://dwotrends.mybluemix.net/projectcommits?projectid=39892981') chord x(month) y(commits) color(commits) tooltip(#all) title('developerWorks Open: Commits for hyperledger-archives/fabric over the last six months')

Brunel does not support multi-line titles; titles are a convenience for simple charts, and for most applications it would be better to create a HTML title of some form outside of the chart itself.
Having said that we should probably clip the title rather than have it overflow. I'll note this as a defect, but it's a low priority one.


Count Instances of a Character in a String

Before jumping into Pr first comment for assign.
Problem statement : Count Instances of a Character in a String
Probelm Link : https://edabit.com/challenge/kbFhwaDyrd79JrgeB
Choose one Cateorgy - Very Easy, Easy, Medium, Hard, Very Hard, Expert
question category : Easy

Before submitting a PR please Check some details.

[ ] fileName formet should be in camelcase
example- returnTheNextNumber.py
[ ]  Choose label for Problem , example- "good first issue", "easy"
[ ]  In file there should be problem statement and link to problem

/* Problem-Task : This program will add two numbers
 * Problem Link : https://edabit.com/challenge/SFzHtm63XT6EYNHWY
*/
int main() {
    int bla;
    return 0;
}

This repository is vaild for HacktoberFest2020
Read before making PR - How to contribute on Github
Good Luck,

I would like to work on this problem

Hey! Can you assign me this problem?

I am a competitive programmer with 2 years of experience. But I am new to open source and looking for issues involving problem solving in C++. Kindly, assign me this task.

I would like to share the c++ approach for this question.

I would like to work on this.

I would like to solve the problem in the C++ language for this question. please assign this task to me


⚠ Turnos 24x7 has degraded performance

In 0ddc1e3, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 3748 ms

Resolved: Turnos 24x7 performance has improved in ece9aac.


WinDbg Preview opens only by system

Hi!
I installed WinDbg Preview from the Microsoft Store, but it doesn't work, unless I run it as system from an admin cmd, using: psexec -s -d -i "C:\Program Files\WindowsApps\Microsoft.WinDbg_1.2007.6001.0_neutral__8wekyb3d8bbwe\DbgX.Shell.exe"
Running Windows 10 x64 2004, build 19041.685. Tried to install WinDbg Preview from microsoft store. It installs, but won't run. OS and Windows store both fully updated. Restart OS didn't solve it, neither did repairing, resetting or reinstalling WinDbg Preview. Tried running it normally (from start menu) - didn't start, no symptoms. Tried running it as admin (from start menu) - got 2 UAC prompts which I approved and then an error chime, no other symptoms. Tried running it from microsoft store (launch button) - got a message box with this title: C:\Program Files\WindowsApps\Microsoft.WinDbg_1.2007.6001.0_neutral__8wekyb3d8bbwe\DbgX.Shell.exe, and this content: Windows cannot access the specified device, path, or file. You may not have the appropriate permissions to access the item.. Tried running it from admin cmd (windbgx) - got Access is denied.. Tried running dbgx.shell.exe from admin cmd - same error. From system cmd (using psexec and then windbgx) - got 'windbgx' is not recognized as an internal or external command, operable program or batch file..
Recording with procmon, I saw the process (DbgX.Shell.exe) starts, and the only failure is for finding C:\Program Files\WindowsApps\Microsoft.WinDbg_1.2007.6001.0_neutral__8wekyb3d8bbwe\AUTORUN.INF. I tried creating an empty AUTORUN.INF in that folder - but got access denied however I tried (even with system cmd, and even when icacls shows I should have access, as far as I understand its output).
Couldn't find a solution on google.
I finally managed to run it, but only from a system cmd (admin cmd not enough), using dbgx.shell.exe from the installation folder. Surely there is a simpler way?
Thanks!!

try installing a copy of the app while logged in as the admin. After this, you should be able to run the user-installed copy as admin

Getting the same error. Weirdly, after installing Windbg Preview from the MS Store, I can run it exactly once. Any attempts to run it after this result in the error.


publish<EMAIL_ADDRESS>

Requested by: @keeakita
Merge target: (default)
Quick links:

View changes
View check runs

Assign the accepted label to this issue to approve the release.
Leave a comment containing #retract under this issue to retract the release (original issuer only).
Targets

[ ] pypi
[ ] sentry-pypi

Targets marked with a checkbox have already been executed.  Administrators can manually tick a checkbox to force craft to skip it.

wtf is going on
    STDOUT: twine: Uploading distributions to https://upload.pypi.org/legacy/
  twine: Uploading sentry_infra_event_notifier-0.0.9-py3-none-any.whl
  twine: 25l
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/20.3 kB • --:-- • ?
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 20.3/20.3 kB • 00:00 • 32.3 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 20.3/20.3 kB • 00:00 • 32.3 MB/s
  twine: 25hWARNING  Error during upload. Retry with the --verbose option for more details.
  twine: ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
  twine:          File already exists
  twine:          ('sentry_infra_event_notifier-0.0.9-py3-none-any.whl', with blake2_256
  twine:          hash
  twine:          '0a138d0b6b88db06f8f61d4bd83e0b4d12f8bdd56d474189c65d76bfa71414b8').
  twine:          See https://pypi.org/help/#file-name-reuse for more information.
  twine:

how did we publish a 0.0.9 when all the previous push jobs failed???
I'm going to #retract and try again with 0.0.10. Sigh

#retract


How to specify vpc-connector when deploying to cloud run.

TL;DR
Hi There,
I was trying to deploy an image to GCP cloud run, using  this workflow.
My question is :
How can I specify the vpc-connector to be used by my cloud run instance to connect to other services in a VPC shared with my project.
When I deploy using the GCP Console / UI, I specify it under connections tab.
Please refer to the attached screenshot below.

Detailed design
No response
Additional information
No response

There isn't an input specific to VPC Connectors but, you can use the flags input to specify options that can be used for gcloud run deploy.
gcloud run deploy has an option for VPC Connectors so you could probably do something like,
    - id: 'deploy'
      uses: 'google-github-actions/deploy-cloudrun@v0'
      with:
        service: 'hello-cloud-run'
        image: 'gcr.io/cloudrun/hello'
        flags: --vpc-connector=YOUR_VPC_CONNECTOR


The columns name (options) are not reactive

I would like the columns name be reactive as the rows behavior. how I can do that???

Hi, sorry about the late response, github seems to notify me for everything except messages about my own repos!
In its current state I would suggest using the datatables api for this:
Tracker.autorun(function () {
  var heading = MyReactiveColumnVar.get();
  // see https://datatables.net/reference/api/column().header()
  $("#datatable").dataTable().api().therestofthecallsyouneed
})

I'm closing this issue. Did it fix the problem?

:+1:


Feature/libvirt options

Those patches enable one to specify:
vagrant_cpus: 2

libvirt:
uri: qemu+ssh://root@blah/system
management_network_name: my_vagrant

Can one of the admins verify this patch?

@sathlan is there a BKR ticket for this change? If not, then a (MAINT) prefix should be added to all of the commits in the PR history.
Before this change can be merged, there'll need to be tests and docs added for it. Let us know if you have any questions about adding these.

Can one of the admins verify this patch?

last comment still current

last comment still current

Made a proper feature request and pull request there https://github.com/puppetlabs/beaker/pull/1222

OK, I'll close this issue, and we'll discuss your changes there then


can't see brokers or topics that inside of docker compose

II see that there are topics if I run the kafka commands within the kafka container.
[kafka@67c2d01edbab ~]$ bin/kafka-topics.sh --bootstrap-server kafka:9092 --list
__consumer_offsets
my_connect_configs
my_connect_offsets
my_source_connect_statuses
postgres.public.customer

However if I change to localhost
[kafka@67c2d01edbab ~]$ bin/kafka-topics.sh --bootstrap-server localhost:9092 --list
[2024-04-25 22:30:06,334] WARN [AdminClient clientId=adminclient-1] Connection to node -1 (localhost/<IP_ADDRESS>:9092) could not be established. Node may not be available. (org.apache.kafka.clients.NetworkClient)
[2024-04-25 22:30:06,439] WARN [AdminClient clientId=adminclient-1] Connection to node -1 (localhost/<IP_ADDRESS>:9092) could not be established. Node may not be available. (org.apache.kafka.clients.NetworkClient)
[2024-04-25 22:30:06,646] WARN [AdminClient clientId=adminclient-1] Connection to node -1 (localhost/<IP_ADDRESS>:9092) could not be established. Node may not be available. (org.apache.kafka.clients.NetworkClient)
[2024-04-25 22:30:06,851] WARN [AdminClient clientId=adminclient-1] Connection to node -1 (localhost/<IP_ADDRESS>:9092) could not be established. Node may not be available. (org.apache.kafka.clients.NetworkClient)
[2024-04-25 22:30:07,363] WARN [AdminClient clientId=adminclient-1] Connection to node -1 (localhost/<IP_ADDRESS>:9092) could not be established. Node may not be available. (org.apache.kafka.clients.NetworkClient)

did you publish the internal ports to localhost? see https://docs.docker.com/network/#published-ports

yes I think the problem has to due with how kafka advertises itself.
  kafka:
    image: quay.io/debezium/kafka:2.6
    ports:
      - 9092:9092
    depends_on:
      zookeeper:
        condition: service_healthy
    environment:
      ZOOKEEPER_CONNECT: zookeeper:2181
    healthcheck:
      test: /kafka/bin/kafka-cluster.sh cluster-id --bootstrap-server kafka:9092 || exit 1
      interval: 1s
      timeout: 60s
      retries: 60

so much monkey business.   I got the answer from https://www.confluent.io/blog/kafka-listeners-explained/
  connect:
    image: quay.io/debezium/connect:2.6
    ports:
      - 8083:8083
      - 2888:2888
      - 3888:3888
    healthcheck:
      test: bash -c "exec 6<> /dev/tcp/localhost/2181"

  kafka:
    image: quay.io/debezium/kafka:2.6
    ports:
      - 9092:9092
      - 29094:29094
    depends_on:
      zookeeper:
        condition: service_healthy
    environment:
      ZOOKEEPER_CONNECT: zookeeper:2181
      KAFKA_LISTENERS: LISTENER_BOB://kafka:29092,LISTENER_FRED://kafka:9092,LISTENER_ALICE://kafka:29094
      KAFKA_ADVERTISED_LISTENERS: LISTENER_BOB://kafka:29092,LISTENER_FRED://localhost:9092,LISTENER_ALICE://never-gonna-give-you-up:29094
      KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: LISTENER_BOB:PLAINTEXT,LISTENER_FRED:PLAINTEXT,LISTENER_ALICE:PLAINTEXT
      KAFKA_INTER_BROKER_LISTENER_NAME: LISTENER_BOB
    healthcheck:
      test: /kafka/bin/kafka-cluster.sh cluster-id --bootstrap-server kafka:29092 || exit 1
      interval: 1s
      timeout: 60s
      retries: 60

  connect:
    image: quay.io/debezium/connect:2.6
    ports:
      - 8083:8083
      - 5005:5005
    environment:
      - BOOTSTRAP_SERVERS=kafka:29092
      - GROUP_ID=1
      - CONFIG_STORAGE_TOPIC=my_connect_configs
      - OFFSET_STORAGE_TOPIC=my_connect_offsets
      - STATUS_STORAGE_TOPIC=my_source_connect_statuses
      - CONNECT_PLUGIN_PATH=/kafka/connect,/opt/connectors
      - JAVA_TOOL_OPTIONS="-agentlib:jdwp=transport=dt_socket,address=*:5005,server=y,suspend=n"
#      - KAFKA_DEBUG=y
#      - DEBUG_SUSPEND_FLAG=y
    depends_on:
      kafka:
        condition: service_healthy
    volumes:
      - ./kafka-connect-connectors-jar:/opt/connectors


PodDisruptionBudgets

PDBs were added but I see no way of controlling them.  We always run a single instance and the existence of the PDB means that we cannot bring down a node without --disable-eviction=true.  We would like to be able to eliminate the generation of the PDBs.
Is there a way we can do this with the jsonnet file or some other means?  If not, can we get this ability added as a feature?

You can override the podDisruptionBudget object
For example:

Create a new disable-podDisruptionBudget.libsonnet file

{
  prometheusAdapter+: {
    podDisruptionBudget:: {},
  },

  alertmanager+: {
    podDisruptionBudget:: {},
  },

  prometheus+: {
    podDisruptionBudget:: {},
  },
}

Import the file in the kp object of example.jsonnet

local kp =
  (import 'kube-prometheus/main.libsonnet') +
  // Here we use a relative path to import
  (import 'disable-podDisruptionBudget.libsonnet') +
  ...

Rebuild manifests

bash build.sh

You will find that the following files no longer appear in the manifests directory
alertmanager-podDisruptionBudget.yaml
prometheus-adapter-podDisruptionBudget.yaml
prometheus-podDisruptionBudget.yaml


Update README.md

Changed the link the the secrets plugin to the currently maintained one. Old one was deprecated.

Oh! It's a duplicate: #1696


Formatted cell Copy-Past blocks Onlyoffice spreadsheet

On;

Onlyoffice Spreadsheet editor version 5.1.0 CE
and;
Firefox Quantum 60.0.1 (64-bit) @ Updated Windows 10
Google Chrome Version 66.0.3359.181 (64-bit  @ Updated Windows 10
(and more...)

The use case:
The user Copy-Past a cell (with non plain text content) in an Onlyoffice Spreadsheet.
Issue:
after this Copy-Past, no more editing is allowed (on this particular Spreadsheet).
formatted cell Copy-Past crashes the spreadsheet, only a browser refresh can restore the edit capability.
Onlyoffice auto-save also stops to work and the trigger Copy-Past change is lost.
Exception:
The problem does not appear when the  Onlyoffice Spreadsheet is opened in more than one browser (shared??)

Hello, @stafula.
Can you attach the file to which the problem is reproduced?

In my Owncloud/Onlyoffice deploy, one can reproduce this with a blank spreadsheet.
I just need to open a clean spreadsheet, type something in a cell, change the font to bold, select it, copy it and then past it on another cell.
After that, the Autosave stops and we cant edit anything else until a page refresh.
Anyway, here is one of my test spreadsheets;
test.xlsx

Can you send steps to reproduce? How do you perform copy and paste actions: using the context menu or hotkeys? If you use toolbar buttons or menu items it initiates a pop-up window. Try to turn off any addons or plugins that may prevent that. Make a result screenshot with browser console so we able to know what script exactly is stops.

yes, of course.
all the above-described copy and paste actions are (system wide) Ctr+c and Ctr+v.
There is no difference if I use Ctr+v or Shift+Ins as Past action.
Note that I'm not reporting a context menu Copy-Past issue.
If you can describe me how to do it, namely what part of the code should be relevant, I can try to extract (and attach here) a JavaScript stack trace...

Here are some lines from the chrome java script console;
app.js:21 Uncaught TypeError: n.asc_getX is not a function
    at U.i.onShowSpecialPasteOptions (app.js:21)
    at M (app.js:8)
    at n.<anonymous> (app.js:8)
    at n.<anonymous> (app.js:8)
    at n.trigger (sdk-all-min.js:598)
    at n.showSpecialPasteOptions (sdk-all.js:7896)
    at n.trigger (sdk-all-min.js:598)
    at z.Qff (sdk-all.js:8157)
    at n.e$ (sdk-all.js:7929)
    at Ia.Zad (sdk-all-min.js:721)

This is a duplicate of https://github.com/ONLYOFFICE/DocumentServer/issues/270 and was fixed in 5.1.2

thank you.
We will update


Viewi pages support

Hi @kenjis , please review my draft work. My knowledge of CI4 is limited, so I left you comments related to the framework. I hope this will help to you to finish the integration.
If there is any questions or my help is needed, I will be glad to provide such.
Looking forward to test the final result :)

@ivanvoitovych Thank you!
I will consider this PR.
This PR (and Viewi) helps me a lot.

Please run composer cs-fix to fix coding style.

done

Thank you!

@ivanvoitovych If I navigate tohttp://localhost:8080/not-found-page,
the response status code is 200. How can I change it to 404?

@ivanvoitovych If I navigate tohttp://localhost:8080/not-found-page, the response status code is 200. How can I change it to 404?

@kenjis Viewi does not support status code, it should be responsibility of the framework, let me think of something.

@ivanvoitovych If I navigate tohttp://localhost:8080/not-found-page, the response status code is 200. How can I change it to 404?

@kenjis
please check this workaround:
https://github.com/ivanvoitovych/ci4-viewi-demo/commit/02cf81b549c3677e187cd6495f4fa5a2347ebe64

@ivanvoitovych Thank you!
Added https://github.com/kenjis/ci4-viewi-demo/commit/71d1c87b1bb38e012cd0c0ede190d555cbb26aa6

@kenjis  I will work on adding more elegant way of supporting status codes, perhaps as an optional parameter in Viewi route.

@ivanvoitovych Looks better!
Can  you send a PR?

@ivanvoitovych Looks better!


Enable to use tilde ~ in paths

Fixes #11

We should add something about that in README.md to make it clear... Some people might assume ~ to be root directory.

Awesome ! Merging it @TheAwiteb


Book methods team1

In this milestone 👍
-Implement methods:

add_item method in the Label class
should take an instance of the Item class as an input
should add the input item to the collection of items
should add self as a property of the item object (by using the correct setter from the item object)
can_be_archived?() in the Book class
should override the method from the parent class
should return true if the parent's method returns true OR if cover_state equals "bad"
otherwise, it should return false

Thank you for the Review.


UI - improve lists bullet points markup

Hi @SebastienBoissiere ,
Can you replace the image-based bullet points for a CSS only as per https://www.w3schools.com/howto/howto_css_bullet_color.asp?

Figure: Bad example - using bg images for bullet points
--
ul {
  list-style: none;
}

ul li::before {
  content: "\25A0";
  color: #cc4141;
  display: inline-block;
  width: 1em;
  margin-left: -1em;
}

Figure: Good example - using CSS only

Hi @tiagov8
CC: @adamcogan
Done, the bullet points are now using css.

Figure: bullet images has been replaced by CSS bullets


Add more solutions to comparison table

Keeping it to primarily "serverless" tech for now.

[ ] Surge
[ ] Firebase
[ ] GAE
?

Netlify

Netlify is on there. I think Azure would make sense if GAE is added.

GAE might not make sense I guess since you're still working with clusters


Correctly parse jest config

Parsing of jest configurations is very limited to the point that it is not usable in most projects i work in. This is mainly due to two issues.
Current implementation:
https://github.com/kavod-io/vscode-jest-test-adapter/blob/a470a2c6772e48aa3b28cd75e3a47ab1ea03f5a4/src/repo/repoHelpers.ts#L31-L46

It expects a json parsable object in jest.config.js. This can (and in most cases is) actually a module, i.e.

const fs = require('fs');
const { rootDir, ...filteredConfig } = require('./setup/jestConfig');

const projects = fs
  .readdirSync('packages')
  .filter((folder) => folder[0] !== '.')
  .map((folderName) => {
    try {
      fs.accessSync(`packages/${folderName}/jest.config.js`);
      return `<rootDir>/packages/${folderName}`;
    } catch (e) {
      return {
        ...filteredConfig,
        displayName: folderName,
        testRegex: `packages/${folderName}.*(Test|.test)\\.(t|j)sx?$`,
      };
    }
  });

module.exports = {
  ...filteredConfig,
  roots: ['<rootDir>'],
  projects,
};

It only takes the first setup file, when most larger jest configs have multiple, i.e.

module.exports = {
  testRunner: 'jest-circus/runner',
  clearMocks: true,
  roots: ['<rootDir>'],
  snapshotSerializers: ['jest-date-serializer', 'enzyme-to-json/serializer'],
  moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'json', 'node'],
  testEnvironment: 'jest-environment-jsdom-sixteen',
  setupFilesAfterEnv: [
    'jest-canvas-mock',
    'jest-localstorage-mock',
    '<rootDir>/setup/index.ts',
  ],
  rootDir: '<rootDir>/../../../',
};

Hey thanks for pointing out the faulty implementation. Probably the easiest way to deal with it is to remove the code. I'm pretty sure that the setup files are not used.

thanks for the hint. i'll try to find some time this week to try that

Sorry, I want meaning for you to change anything. I just need to remove the need for the setup files since they're not used.

just as confirmation: everything is now working as expected :heart_eyes:
thanks for the quick fix


ugrade ?

What's the issue?
Helo
I love your plungin.
But it doesn't work anymore because it doesn't have to date.
Do you intend to update it?
Have a nice day
José
FFXIV Update

[X] I have confirmed that I have the latest version of XIVLauncher and RepairMe.

Will be updated.


[Issue-3759] Extension - Retest unified account on Firefox browser

Related issue(s)

#3759

Is your feature request related to a problem(s)? Please describe.

Fix cannot run on firefox

Describe the solution you'd like

Fix cannot run on firefox

Describe alternatives you've considered

No

Additional context

No

🚀 Deployed on https://pr-3796--sw-web-runner.netlify.app


pull request for e2e test at 12/06/2016 07:45:03

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


When backspacing caret is ahead by one index

Issue
When tying, pressing backspaces causes the caret to remain one letter ahead of where it should be leaving an empty character between the last typed character and the caret.
Where to start
Backspace logic within handleKeyDown

Resolved in commit f377b058306c85c5f31277231fafa0e56399eec7


feat: refactor match_order_internal

Opening an initial PR to tackle #74.
Reasoning:
To do this, fees need to be debited from open orders in match_order_internal not in open_order_internal, however, the first step should be to clean up the match_order_internal function.
Changes Made:
Currently the match_order_internal is not composable, and has several if / else nested loops which makes it hard to read and audit.
In this PR, I refactor the match_order_internal function to:

Remove nested if/else code blocks
Create update_order_storage_and_reward to handle order updates and matcher rewards
Create emit_match_events to improve readability of the match_order_internal function.

Fixed #74.
Added tests to withdraw protocol fees requested by @dcpp
Overall, improved the readability of match_order_internal and removed the fee debiting from user's positions.


Add dashboard to amazon msk quickstart

Summary
@ganeshmuralidhar submitted a wonderful MSK quickstart which included this dashboard. This just moves that content into our existing amazon msk quickstart.

hey @ganeshmuralidhar! This is your dashboard moved over to the existing MSK quickstart. Could I get your sign off before we merge?

@aswanson-nr Please go ahead :)