MSID: 88793 Version: 2 DOI: 2<IP_ADDRESS>3535

[PLACE MANUSCRIPT AND EDITOR DETAILS HERE WHEN AVAILABLE] See step 3
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=88793)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/88793/v2)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>3535)
[ ] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/88793/v2/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/88793)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/88793

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/88793

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/88793/v2/88793-v2.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/88793)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

@acollings, I'm seeing this broken image for  author response image 1. Looks like imgur removed it or there were issues when first adding it:

https://imgur.com/dYhfDac
Could you take a look when you have a chance please? Thanks!

Hi @fred-atherden not sure what's wrong. I've asked Sue to fix.

Hi @fred-atherden I've fixed this one.


update reference to technical specs to mention data and how to cite use of QTM HW

Learn Build status updates of commit 1529cea:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/provider-quantinuum.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@Bradben

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


feat: Support functions as interface for simple CLIs.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

27 of 27 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1783

Relevant Lines:
1783

💛  - Coveralls


How can I install the location file available inside the /locale folder?

Hi!
I have installed django-rest-framework-simplejwt and notice it doesn't come with the languages available inside the rest_framework_simplejwt/locale folder.
What's the best approach to install it? Do I have to manually download it from this repository?
Thank you very much in advance!

Just noticed this too, seems like the wheel doesn't include the locale files but the tar version has them.
I think adding include_package_data=true to setup.py solves it.
Another way would be to include only the compiled .po files
I will test it and open a PR as soon as I can

Hmm #117 should've fixed it... Is this still an issue? If so, please open a PR.


[varLib] Accept DesignspaceDocument objects in build() and load_designspace()

We need a way to integrate sparse masters that come from ("brace") layers instead of stand-alone sparse UFOs. Instead of modifying varLib.build() and MasterFinder to go look for specially named files like in https://github.com/fonttools/fonttools/pull/1387, modify varLib.build() to take either

a path and continue as before (masters from layers not supported then, unless you write the compiled TTFonts to disk and refer to them with the filename attribute and probably adjust master_finder)
or a DesignspaceDocument and demand that the caller already read and attached the TTFont objects to all SourceDescriptor.font attributes. ufo2ft will do this when calling https://github.com/googlei18n/ufo2ft/pull/300/files#diff-cd32d8abceb8eff27b2b4994f7322bc1R256.

Sgtm.

After a discussion with Cosimo, we want to support three use cases:

The CLI should continue to work as before, as in python3 -m varLib my.designspace --master-finder "somewhere/{stem}.otf". Usually, the pointed to Designspace file contains UFO sources, so we need to go find the master binaries.
In-memory merging without intermediate writing to disk must be possible, so build() must be able to take a DesignspaceDocument where the SourceDescriptor.font attributes have been preloaded by e.g. fontmake/ufo2ft.
It should be possible to fontmake -m my.designspace -o ttf-interpolatable --output-path somewhere && python3 -m varLib somewhere/my.designspace, i.e. to write a Designspace file where the SourceDescriptor.filenames point to OT binaries. In that case, there must be no layerName as that doesn't make sense for OT binaries and the master finder should not be invoked.

This is a useful idea, if I understand it correctly, even without brace layers.  I am currently dealing with a workflow where all the source fonts will have a full glyph complement, and I will have to subset some of them to temporary files to make sparse source fonts. With this PR, I think i can read in the original source fonts and attach the TTFont objects to the DesignSpace SourceDescriptor.font attributes, and subset them in memory.

@readroberts correct

It's a bit unfortunate that build() takes a file path instead of expecting a fully loaded DesignspaceDocument and letting the caller care about the nitty-gritty...

Change it as you wish.

Changing it might be something for 4.0. I'd like to think more on the API. Maybe we can move MasterFinder to the entry points instead of having them in __init__...

@madig merged manually to https://github.com/fonttools/fonttools/tree/varlib-build-accept-ds-object branch, let's continue there


[BUG]: DB and tenant not properly mapped on get_collection

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

Fixed an issue where get_collection in the segment was mapping returning the originally passed DB and tenant

Test plan
How are these changes tested?

[x] Tests pass locally with pytest for python

Documentation Changes
N/A

@HammadB, this should be ready to merge now.


Constraints from GitHub break dataflow image build

Since #2267 was merged, which added a package installed from GitHub to our constraints.txt file, the dataflow image build (e.g. here) has been broken, producing an error when pip installing packages:
#9 0.743 DEPRECATION: Constraints are only allowed to take the form of a package name and a version specifier. Other forms were originally permitted as an accident of the implementation, but were undocumented. The new implementation of the resolver no longer supports these forms. A possible replacement is replacing the constraint with a requirement. You can find discussion regarding this at https://github.com/pypa/pip/issues/8210.
#9 0.743 ERROR: Unnamed requirements are not allowed as constraints
#9 0.878 WARNING: You are using pip version 21.2.4; however, version 23.2.1 is available.

The environment in the build has a different version of pip (21.2.4) than what we pin in our environment.yml file (20.2.4).  I encountered a similar issue in the lint build, which runs on every commit in each PR, and fixed it by pinning the version pip installed in that environment to 20.2.4.
In general though, it might be nice to have a solution that worked for newer versions of pip.  I think it is orthogonal to this issue, but the initial issue that prompted pinning pip to this version may have been addressed in pip-tools (https://github.com/jazzband/pip-tools/issues/1300).

Agree it would be great to get away from pinning pip; it might resolve other issues, e.g., #2266.


npm install smooth-scroll name installs the wrong package

npm install smooth-scroll
npm WARN deprecated<EMAIL_ADDRESS>Sorry! Bad naming issues. Please use the jquery-smooth-scroll package instead.
<EMAIL_ADDRESS>node_modules/smooth-scroll
└──<EMAIL_ADDRESS>
Currently working around this by using this repo in my package.json.

I don't believe that's my script. You need to explicitly call cferdinandi/smooth-scroll. See https://docs.npmjs.com/files/package.json#github-urls for more details.

Yes, but in light of that, your package.json is bad because the name given should correspond exactly with the name of the package in NPM.

My package.json files is used to install the build tools I use to create the production versions of the scripts. It does not install or reference Smooth Scroll from NPM, as this script is not formally listed there.
Per the readme.md, please us cferdinandi/smooth-scroll to reference this script directly from GitHub. I've done it before. It works perfectly.

Okay. I'm not arguing with you there isn't a workaround. I acknowledged that's exactly what I'm doing in the original post. What I'm saying is that it's unintuitive and requires a byline in the readme and an unusual case for end users to install. Whether you want your package to be in NPM is a matter of opinion. The fact that it must be installed in a nonstandard way for an npm package.json-containing project, even if you personally only use it for dependencies, and is therefore inherently less intuitive to install than other packages following the accepted convention, is not a matter of opinion.

Anyway, I'm not trying to be pedantic. I appreciate the library and your work on it. It's just weird to read the name from a package.json, install it, and then get weird errors about jQuery.

Yea, I can see that.

I'm reading what I just wrote, and it comes across as crazy sarcastic even though I didn't mean it that way. What I meant was: That's a fair point, and I'll consider updating.


SSL_connect returned=1 errno=0 state=error: certificate verify failed

HI,
I removed old certificate of puppet master, regenerated new certificates for puppet master and puppet clients. If i execute VPC samples in puppet master (already aws module configured, pre-requisite aws-sdk, ruby-gems and retries installed), getting certificate verify failed.
[ec2-user@haprox1 vpc-example]$ sudo puppet apply test.pp --test
2015-10-28 13:45:12.022702 WARN  puppetlabs.facter - locale environment variables were bad; continuing with LANG=C
Notice: Compiled catalog for haprox1 in environment production in 0.70 seconds
Info: Applying configuration version '1446039913'
Error: Failed to apply catalog: SSL_connect returned=1 errno=0 state=error: certificate verify failed
[ec2-user@haprox1 vpc-example]$ pwd
/etc/puppetlabs/code/environments/production/modules/aws/examples/vpc-example
how can i make this aws module to be working in this puppet master instead of recreating the whole box.
Thanks,
Ram.

Hi @ram2valar. For more general Puppet questions it's probably best to ask on the puppet-users mailing list, or on http://ask.puppetlabs.com/questions/.
This module is designed for managing instances and other EC2 resources, so the examples are focused on that usecase only I'm afraid.


request for umbrella issue to track present/planned/rejected image formats

Is your feature request related to a problem? Please describe.
I (and likely others also) are curious about image format support in squoosh
Describe the solution you'd like

A pinned umbrella issue/roadmap intended to track:

which issues/pull requests/branches are being used for planned support
rejected formats, with a summary of their reason and initial issue where appropriate (i.e. #324 for HEIF)

track the image formats listed on caniuse.com git repo / web search

Does other service/app have this feature?
umbrella issues/roadmaps are a pretty common thing.
Additional context
supplementary planned/rejected info for subformats, i.e. apng <> gif, gif > webm etc.

Yeah, I’m not opposed. We could also use the GitHub Wiki for this purpose.
@jakearchibald WDYT?

Is https://github.com/GoogleChromeLabs/squoosh/projects/3 the thing we're talking about? I guess we'd need a rejected column.

OOoooh! Yes it is. Closing this then.


[3.2.0] Doc Feedback - Improve URL directions in QSG and install and setup

Description:

Setup and Install   in QSG is redirecting to 3.1.0 docs. Need to redirect to 3.2.0 docs.

Links in the Environment compatibility section are redirecting to 3.1.0 docs.

Affected Product Version:
APIM 3.2.0

Fixed with https://github.com/wso2/docs-apim/pull/1861 & https://github.com/wso2/docs-apim/pull/1860


in android 10 images are not showing

What is the problem with android 10version

Same issue... +1

any update on this bros ? i have the same issue

Can't select images in android 10.. any solution for this?

same issue any update on this ?

The android 10 introduce new feature of storage is Storage Scope, that make we can't refer to image from gallery by path, we must using uri, provide by MediaStore to get uri
But we can using old storage mechanic in android 10 by define android:requestLegacyExternalStorage=true in manifest, and it will work


CitadelDAO - Potential Deadlock

Code Location:
https://github.com/CivMC/Citadel/blob/23a41a90335ad6d96fd2712df8cea26a1c0ed5a1/paper/src/main/java/vg/civcraft/mc/citadel/model/CitadelDAO.java#L390

Issue:
Code acquires a connection, then calls the insert consumer which may also acquire connections without passing the existing connection. This may lead to resource exhaustion and the inserter being unable to acquire the necessary connection to continue. This will deadlock the thread.

Solution:
Pass the connection which already exists in read-write mode.

I'm closing this out as something that we won't fix. It could be revisited in the future, but it's not within our capacity to work on right now.


Rule: no-mutation-in-pure-functions

Some functions in effector API should be pure:

reducer in .on-call
combinator (fn) in sample
filter in guard, .filter and .filterMap
mapper in .map and .prepend

We cannot prove the purity functions by ESLint rule, but we can forbid mutations in these cases.

I'm not sure i understand - how it is supposed to work?
For e.g., i think, this kind of mutation would be entierly correct:
(state, payload) => {
 const copyState = deepCopy(state);
 const copyPayload = deepCopy(payload);

 copyPayload.foo = "bar";
 copyState.some = copyPayload;

return copyState;
}

state & payload are available for other reducers and stores - mutating them is not correct, because this change will be observable.
But by creating a own copy in reducer this is no longer problem, since mutation of copy is not observable from the outside.
Another problem is that there is no way to proof that this copy = deepCopy(state) actually does not mutate the state 🤔
Looks like, it is only options that are secured from false warnings, are:

Direct mutations of arguments (since reducer is not the only consumer of store state and event payload)
Mutations of external objects

Also there is another case that is affects "purity" of functions - reading from outer state that can be changed during app lifetime.
This is a side-effect and can lead to observable changes in function behaviour, basically, by making it stateful
const box = { ... };
const RED = 'red';

$store.on(event, (state, payload) => {
 // all of this this is reading from outer state which is side-effect
 // and may lead to observable changes in function behaviour
 const date = new Date()
 const otherState = $another.getState()

 // `box` is not readonly or frozen object, we cannot prove that is not mutable
 // should be warned, i guess
 const someData = box[payload];

 // RED is a immutable primitive constant, will never change
 // this should not be warned, i guess
 const nextState = {...state, color: RED}

})


[csrng] V1 Signoff

Description
Ensure V1 signoff criteria are fulfilled after focus area changes have landed.

We've decided in today's triaging meeting to move all remaining CSRNG issues to M3. There was nothing absolutely critical for CSRNG (no area impact, no timing impact, there were software workarounds for the important things as opposed to ENTROPY_SRC). So we focused on other blocks first.
What remains is to check the DV stats for the signoff to ensure we're still at the level of the ES. I am lowering the the effort here from 12 to 0. FYI @johngt

@vogelpi: For a V1 signoff I think we don't need the DV stats. The smoke test still passes according to current nightly results, and if the changes made to CSRNG as part of M2 are covered either by existing tests or by additional testplan items (with issues to track their completion in M4/M5), then I think this can be closed as completed.

Just had a look at the DV stats of the last green nightly regression.

Pass rates are all above the bar for V2/V2S but the expression and branch coverage dropped to below 90%. So we can't sign off at V2/V2S and have to drop down to V1. Most likely this happened due to the area reduction changes (coverage exclusion needs to be updated and reviewed again). It's a pity since we for M2, we didn't do functional RTL changes but quite some DV improvements (see #20976). This is now tracked in #22354.
A PR to bump the version (because of the changes now coming over the next weeks) and lowering the verification version to V1 is here: #22355.


[dynamic_link] New iOS install doesn't open with dynamic link after install

When an iOS user clicking my dynamic link it works fine when the app is currently installed.  The app opens and can respond to the dynamic link and this works if the app is running in the background or closed in the background.  However, if the app is not installed the user is correctly navigated to the app store however once they tap the 'Open' button after the install completes the dynamic link is not loaded.  The user can tap the dynamic link for a 2nd time at this point and it will work, however I don't believe the user should have to tap the dynamic link multiple time I thought that should just work and be passed to the app after the install.  I have tried with both "efr=1" and without that.  When the efr=1 is omitted that also correctly brings me to a preview.page.link in safari that then asks "Save my place in the app. A link will be copied to continue to this page".  And once I click the "Open" button from this screen that takes me to the app store and my dynamic link is in the clipboard.  With the efr=1 there seems to be nothing in the clipboard.  However this has no impact on the final result as opening the app after install never receives the link.
My dynamic link is:
https://startingxi.page.link/?link=https://starting-xi-6d6e1.web.app/game/AhXSri7rXWar64GyTHOk&apn=com.koncal.starting_xi&isi=1489245604&ibi=com.koncal.startingXi&st=Team 3 vs &sd=1 - 0&efr=1
My code to handle the dynamic link from my main.dart is:
  @override
  void initState() {
    super.initState();
    _configure();
    initDynamicLinks();

    futureInitState = initStateAsync();
  }

  void initDynamicLinks() async {
    final PendingDynamicLinkData data = await FirebaseDynamicLinks.instance.getInitialLink();
    final Uri deepLink = data?.link;
    processDeepLink(deepLink);

    FirebaseDynamicLinks.instance.onLink(onSuccess: (PendingDynamicLinkData dynamicLink) async {
      final Uri deepLink = dynamicLink?.link;
      await processDeepLink(deepLink);
    }, onError: (OnLinkErrorException e) async {
      print('onLinkError');
      print(e.message);
      displayFlushBar('$e.message');
    });
  }

my pubspec.yaml
  flutter:
    sdk: flutter

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^0.1.2
  sqflite: ^1.2.0
  path: ^1.6.2
  path_provider: any
  intl: ^0.16.0
  font_awesome_flutter: ^8.5.0
  flushbar: ^1.9.1
  flutter_slidable: ^0.5.4
  auto_size_text: ^2.1.0
  flutter_icons: ^1.0.0+1
  provider: ^3.2.0
  flutter_typeahead: ^1.7.0
  firebase_core: ^0.4.3+2
  cloud_firestore: ^0.13.0+1
  firebase_dynamic_links: ^0.5.0+9
  share: ^0.6.3+5
  uuid: 2.0.4
  shared_preferences: ^0.5.6
  lint: ^1.1.1
  matrix_gesture_detector: ^0.1.0

Per another issue I tried adding
FirebaseApp.configure() to the AppDelegate.swift.
I have tried changing the where the initDynamicLinks() is called from originally being within my FutureBuilder to just calling from the main initState.
At this point I'm not sure what else to try or if my expectations are just off.  From the documentation it seems like this should work without having to click the link a 2nd time after install, but it's possible I'm reading the documentation incorrectly and this is indeed working as designed and the end user is required to tap the link the 1st time to install and a 2nd time to load the dynamic link vs tapping the link to install and then just opening the app.  So I would also like clarification on that.
flutter doctor:
[√] Flutter (Channel stable, v1.12.13+hotfix.5, on Microsoft Windows [Version 10.0.17763.973], locale en-US)
    • Flutter version 1.12.13+hotfix.5 at C:\src\flutter
    • Framework revision 27321ebbad (6 weeks ago), 2019-12-10 18:15:01 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at C:\Users\Steve\AppData\Local\Android\Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_SDK_ROOT = C:\Users\Steve\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[√] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 42.1.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[!] IntelliJ IDEA Community Edition (version 2018.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2018.2.4
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[!] VS Code, 64-bit edition (version 1.41.1)
    • VS Code at C:\Program Files\Microsoft VS Code
    X Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (1 available)
    • AOSP on IA Emulator • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)

! Doctor found issues in 3 categories.
Process finished with exit code 0

Thanks!

same here, works on android though.

I have no problems unless I made a fresh install. In my app getInitialLink returns null, when a link is waiting in the clipboard while the app is being installed and then opened. The link is cleared from the clipboard as expected after opening the app. Any later calls to getInitialLink return the correct link again.
I tried to understand the Obj-C code under the hood but did not find out where the URL is read and cleared from the clipboard. Although Flutter getInitialLink is asynchronous, it looks like it is not really waiting for any link to be retrieved. It transforms and returns a variable called _initialLink. This var in turn is set by application:openURL:options: that by documentation is called from the AppDelegate after application:willFinishLaunchingWithOptions:. Setting a variable and reading the same variable at another point in code and time may cause a timing issue?
I added an arbitrary delay before reading the var and it seems to work then (but of course 2 seconds too late though):
await Future.delayed(Duration(seconds: 2));
final PendingDynamicLinkData data = await FirebaseDynamicLinks.instance.getInitialLink();

To clarify I believe there are 3 user cases per device that need to work:

app is not installed on device
app is installed on device and currently closed
app is installed on device and currently open
On Android all 3 of these use cases work fine.  The user receives the dynamic link via a txt message (or whatever medium the sender chose to share via) and the receiver of the dynamic link can tap the link and the app install and opens or just opens with the link context as expected so I can load the share details.
On iOS use case #2 and #3 work properly, the user receives the link and upon tapping the link the app opens and can load the share details.  However #1 does not work.  The user is properly directed to install the app, but upon opening the app the link details are not properly sent to the app so it's as if the share didn't happen.  At this point the user could choose to tap the shared link again and since the app is now installed the share would work.  But I believe iOS should work similar to how Android works that after the install the app opens and the contents of the share link should be available without having to tap the link a 2nd time.

I have not tested what @ToniTornado mentions to add a delay though.  If that does work at least a workaround exists.  As it stands right now the user experience for iOS receiving a share link for app that isn't installed leads to a quite unpleasant user experience and unfortunately a bad user experience on the initial install isn't going to help my app.

We're having some issues. Android is currently working fine, but iOS is sometimes not working.
I feel that the iOS dynamic link is working fine when open it from the Slack app (Twitter, Instagram, Messenger, LINE are not okay). There are some tips to solve the problem 🤔

I can confirm that await getInitialLink() returns the desired value only after a delay even though I'm waiting for it. The 2 seconds I use in my code are just a "worksforme" guess. Awaiting getInitialLink() should not return null before a link is available or it was determined that no link is present. This has to be fixed somewhere in the underlying iOS code.
As @skoncal correctly describes this is only the case for iOS and his scenario 1) when the app was not installed when clicking the link (= browser opens, you click the button, the link is copied to clipboard, you get redirected to the app store, and the link is finally read by the app on startup after installation finished and the clipboard gets cleared).
var earlyLink = await FirebaseDynamicLinks.instance.getInitialLink();  // returns null
await Future.delayed(Duration(seconds: 2));
var laterLink = await FirebaseDynamicLinks.instance.getInitialLink(); // returns the link

await Future.delayed(Duration(seconds: 2));

This doesn't work for me @ToniTornado
I tried the native method from here which works. But the firebase dynamic link sdk doesn't give anything for IOS on fresh install.

I'm having this same issue. Any idea of a work around or info on a fix?

Solution with delay works on debug run, but doesn't work with --release, any ideas?

I've spent some time on this, here is fixed implementation of onInitialLink:
- (BOOL)onInitialLink:(NSUserActivity *)userActivity {
  BOOL handled = [[FIRDynamicLinks dynamicLinks]
      handleUniversalLink:userActivity.webpageURL
               completion:^(FIRDynamicLink *_Nullable dynamicLink, NSError *_Nullable error) {
                 if (error) {
                   self.flutterError = getFlutterError(error);
                 } else if (self.initiated) {
                   NSMutableDictionary *dictionary = getDictionaryFromDynamicLink(dynamicLink);
                   [self.channel invokeMethod:@"onLinkSuccess" arguments:dictionary];
                 }
                 self.initialLink = dynamicLink;
               }];
  return handled;
}

Not an elegant solution, but it works, however you will get your link in FirebaseDynamicLinks.instance.onLink not in getInitialLink()
Alternatively, you could probably just call onLink before getInitialLink, but I didn't test it

I am having same issue here on iOS 13.3. Sometimes deep links are identified, sometime not. Any updates on it?

@rostopira works for me too thanks!

- (BOOL)onInitialLink:(NSUserActivity *)userActivity {
  BOOL handled = [[FIRDynamicLinks dynamicLinks]
      handleUniversalLink:userActivity.webpageURL
               completion:^(FIRDynamicLink *_Nullable dynamicLink, NSError *_Nullable error) {
                 if (error) {
                   self.flutterError = getFlutterError(error);
                 } else if (self.initiated) {
                   NSMutableDictionary *dictionary = getDictionaryFromDynamicLink(dynamicLink);
                   [self.channel invokeMethod:@"onLinkSuccess" arguments:dictionary];
                 }
                 self.initialLink = dynamicLink;
               }];
  return handled;
}

to explain more : need to change onInitialLink (line 160) method FLTFirebaseDynamicLinksPlugin.m file inside firebase_dynamic_links package:

~/development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_dynamic_links-0.5.0+9/ios/Classes/FLTFirebaseDynamicLinksPlugin.m

thanks for the possible solution, @rostopira, but i can't get that to work for me.  i also tried calling onLink() first.
per https://github.com/firebase/firebase-ios-sdk/issues/3918 might this be an issue with:
- (BOOL)application:(UIApplication *)application
    continueUserActivity:(NSUserActivity *)userActivity
      restorationHandler:(void (^)(NSArray *))restorationHandler {
  if (_initiated) {
    return [self onLink:userActivity];
  }
  return [self onInitialLink:userActivity];
}

which is right below - (BOOL)onInitialLink?
pinging @kroikie - the payload is definitely not being preserved when coming from an AppStore install.   getInitialLink() is otherwise working fine on cold opens though.

I got it working by adding WidgetsFlutterBinding.ensureInitialized();
Just before calling await FirebaseDynamicLinks.instance.getInitialLink();

@ambernardino were you not calling WidgetsFlutterBinding.ensureInitialized() elsewhere, or did you double it up?

@blaneyneil wasn't calling it anywhere

I was already calling WidgetsFlutterBinding.ensureInitialized() in my main(), before runApp(), but just out of desperation i called it again on my home screen, right before getInitialLink().  no luck.  the payload after an AppStore install is still not there.   post install, it works exactly like it should on a cold open.

For anyone having trouble with this, i had the same issue.
My issue was that i had overriden the method
override func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any]) -> Bool {}
in my AppDelegate
If you have and need to make sure you call super.
It works for me now, hope it helps someone

For anyone having trouble with this, i had the same issue.
My issue was that i had overriden the method
override func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any]) -> Bool {}
in my AppDelegate
If you have and need to make sure you call super.
It works for me now, hope it helps someone

My issue was also due to this.
It worked for me when adding this at the last line in the method.
return super.application(app, open: url, options: options)

For anyone having trouble with this, i had the same issue.
My issue was that i had overriden the method
override func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any]) -> Bool {}
in my AppDelegate
If you have and need to make sure you call super.
It works for me now, hope it helps someone

My issue was also due to this.
It worked for me when adding this at the last line in the method.
return super.application(app, open: url, options: options)

Before the fix, was it working inconsistently or not working at all?

@dpedrinha
In my case it was not working at all after new app installing and first launching. It was working only when the app was already installed.

firebase_dynamic_links: 0.6.0

Same issue with v0.6.0. None of the above fixed it.  'onInitialLink' doesn't seem to exist in FTLFirebaseDynamicLinksPlugin.m in this version?

Yes, having the same issue in v0.6.0.
Works fine in Android, works fine in iOS if app is in the background, but not getting any link data when app is closed.

firebase_dynamic_links: 0.6.0
the issue is still there
Just in case, maybe it can be affected by other firebase-related plugins, here is my list of used plugins with versions:
  firebase_core: 0.5.0
  firebase_crashlytics: 0.1.4+1
  firebase_analytics: 6.0.0
  firebase_messaging: 7.0.0
  firebase_dynamic_links: 0.6.0
  firebase_auth: 0.18.0+1

Update:
I am an Android Developer originally and have less then 0 experience in iOS. But still I was thinking to try to implement dynamic links integration natively on iOS as it is described here: https://firebase.google.com/docs/dynamic-links/ios/receive#open-dynamic-links-in-your-app
When I started and had added the following methods (which does not make sense for me) it made my FirebaseDynamicLinks.instance.getInitialLink(); suddenly working like a charm!
Removing the following code brings the issue back.
@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {

    @available(iOS 9.0, *)
    override func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any]) -> Bool {
      return application(app, open: url,
                         sourceApplication: options[UIApplication.OpenURLOptionsKey.sourceApplication] as? String,
                         annotation: "")
    }

    override func application(_ application: UIApplication, open url: URL, sourceApplication: String?, annotation: Any) -> Bool {
        if DynamicLinks.dynamicLinks().dynamicLink(fromCustomSchemeURL: url) != nil {
        // Handle the deep link. For example, show the deep-linked content or
        // apply a promotional offer to the user's account.
        // ...
        return true
      }
      return false
    }
....
}

Hope it could help someone.

Can you please elaborate more? did you just those code to AppDelegate.swift and it worked?
I tried adding the same code to AppDelegate.swift but it did not work for me.

There is nothing wrong on Flutter or Firebase side, it's an iOS bug.

Sometimes, on any iOS 11.2+, the AASA file is not being updated after the application is installed. In that case, the only way to update it is to delete the app, restart the device, and install the app.
This was reproduced on multiple iPhone devices.
Applications that were installed on the device before the update will continue working, however, upon reinstalling - they may stop working.

More info here
https://stackoverflow.com/questions/59079521/ios-firebase-dynamic-link-not-opening-installed-app
http://www.openradar.me/radar?id=4999496467480576
Everything is working correctly for me now after I deleted, restart and reinstalled the app.
I am using   firebase_dynamic_links: ^0.6.0+1.

Hey @skoncal, can you confirm if you're still encountering this issue in light of the solution above? Thanks.

I'm honestly not sure if this is an issue anymore.  I found the bug almost 1.5 year ago and I haven't actively tried to reproduce the problem in over a year.  You can go ahead and mark this as stale since I can no longer confirm or deny the bug exists.

This issue was fixed for me with the last iOS update.

Thanks for the update, @skoncal & @dpedrinha. I'm going to close this for now, will reopen if there is reproducible issue for iOS.  My sense is that a lot of problems are down to configuration given the amount of plumbing required to setup dynamic links.


indexPath in didSelectRowAtIndexPath

I have a tableview where cells display a KILabel, when I tapped a cell (not the kilabel link), I get the wrong indexpath, I get the previous indexPath selected.
If I remove the kilabel, everything works like a charm.

The way to "solve" the issue is adding [tableView reloadData] at the end of didSelectRowAtIndexPath.

That doesn't sound right. You really don't want to be reloading the table data after making a selection.
Have you looked at the demo project to see how to use it in a table. I can't imagine why using KILabel would affect selection of table cells.

Yes, I know it doesn't sound right but it was the only way to get KILabel working. I looked at the demo project and all the examples available and all looks right. The thing is, if it was my mistake, why with the reloadData worked?
It's a weird thing.

I have exactly the same problem. It seems like a bug.

I ran into this same issue. It has to do with the way touchesBegan/Moved/Ended/Cancelled have been implemented. I was able to resolve the issue by using a UITapGestureRecognizer in lieu of overriding the touch even methods.

I had the same problem. I added my KILabel with addSubview on the cell. And only one easy and painless solution I found is to add next code to end of method didSelectRowAtIndexPath
[tableView reloadRowsAtIndexPaths:@[ indexPath ] withRowAnimation:UITableViewRowAnimationNone];

@nyeu @vgolovnev @Dayj
in * - (void)touchesEnded:(NSSet *)touches withEvent:(UIEvent *)event * method , line 705, perhaps,
just comment out  [super touchesBegan:touches withEvent:event]; or remove it.
It will fix the problem and didSelectRowAtIndexPath works happy again.

Thanks @dayj


Support for component tests

What problem does this feature solve?
This project runs Cypress in run mode. It would be nice to be able to run it in the component testing mode as well.
What does the proposed API look like?
vue-cli-service test:component

could be a flag too - --component would be an easy switch to include. no matter how you do it, only one line needs to be different to support component testing - just needs to be run-ct and open-ct there.
I would happily open a PR for either the extra command or extra switch methods if I knew it would be reviewed and approved - looks like issues and PRs don't see a lot of activity in this repo.


SSR: NuxtJS 3.0.0-rc.8 Exists is not defined (Using a context component)

TuSimple/naive-ui version (版本)
2.32.1
Vue version (Vue 版本)
3.2.37
Browser and its version (浏览器及其版本)
Not affiliable
System and its version (系统及其版本)
Windows 11 10.0.22621 Build 22621
Node version (Node 版本)
v16.13.0
Reappearance link (重现链接)
https://github.com/brys0/naive-ui-nuxt-demo
Reappearance steps (重现步骤)
pnpm install --shamefully-hoist
pnpm build
edit .output/server/chunks/server.mjs
replace
import CSSRender, { hash } from 'css-render';
import BEMPlugin from '@css-render/plugin-bem';

with
import { hash,CssRender as CSSRender } from 'css-render';
import { plugin as BEMPlugin} from '@css-render/plugin-bem';

pnpm preview
go to http://localhost:3000
In console see error: ReferenceError: exists is not defined
Expected results (期望的结果)
It should either import exists or find another method of using this
Actual results (实际的结果)
It breaks on not modifying css render AND trying to use context api in naive
Remarks (补充说明)

+1

+1

+1

You can add broken to transpile in nuxt config as a temporal solution.

The bug is fixed in latest version.


Convert Path type into a branded type

This prevents the code from using simple string as paths, and ensures Path operations are used when splitting and transforming paths. The path constructor now allows passsing arrays as input, and path segments will be escaped according to IETF RFC 6901, preventing issues if using slashes as dictionary keys in the state object
The interface does not change for users.
Change-type: minor

I self-certify!


The latest version is not being updated.

Do I need to upgrade the Unity Manager version from the latest version?

There is nothing wrong with it. This channel is for bugs. Use Reddit, Nexus or other channels if you don't know how to use the Mod.


Record all the backend test cases

This PR records all the backend test cases, models and nodes, in file all_test_names.txt. User can use this file to add new backend test cases without going into third_party/onnx code. Also, the file reveals what test cases are not supported by onnx-mlir so far. When onnx is updated to a new version, we can generate a new version of this file and compare against the older one to find out the changes in backend test cases.

It's a bit confusing to call this a test since all it does is to save the test names in a file. It feels more like a tool belonging to utils.

are you planning to do a version where only the missing tests are listed (avail - already here)?

are you planning to do a version where only the missing tests are listed (avail - already here)?

any response @chentong319 ?

are you planning to do a version where only the missing tests are listed (avail - already here)?

Not in this PR. Need to find a unified way to specify the test case for cpu and accelerator.

Jenkins Linux amd64 Build #7296 [push] Record all the backend t... started at 08:34

Jenkins Linux s390x Build #7312 [push] Record all the backend t... started at 09:34

Jenkins Linux s390x Build #7312 [push] Record all the backend t... aborted after 55 min

Jenkins Linux ppc64le Build #6361 [push] Record all the backend t... aborted after 56 min

Jenkins Linux amd64 Build #7296 [push] Record all the backend t... aborted after 56 min


fix(template engine): Matching angular template engine by directory #540

I will fix tests on this and sort out other issue with including all view assets from the same folder.
Fix for #540

Coverage increased (+0.55%) to 76.98% when pulling 7f7356e5bfaebcbf10fd57dc7c2f2879c2118fe6 on feature/coexisting-asset-types into 3cb960fe1473d995c39549dd19129bcd083ba923 on master.

Coverage increased (+0.55%) to 76.98% when pulling 7f7356e5bfaebcbf10fd57dc7c2f2879c2118fe6 on feature/coexisting-asset-types into 3cb960fe1473d995c39549dd19129bcd083ba923 on master.

Coverage increased (+0.5%) to 76.93% when pulling 5ef3ed025cbafdad4f621ef6c3b4ab7f56a208db on feature/coexisting-asset-types into 3cb960fe1473d995c39549dd19129bcd083ba923 on master.

Coverage increased (+0.51%) to 76.94% when pulling 10986d945a137d93602b7084383c45dc811dd961 on feature/coexisting-asset-types into 3cb960fe1473d995c39549dd19129bcd083ba923 on master.

Coverage increased (+0.45%) to 76.88% when pulling 2b527dc84a64e4ed606673fb07c3cca3bd201225 on feature/coexisting-asset-types into 3cb960fe1473d995c39549dd19129bcd083ba923 on master.


apiserver: clusterdeployment resource version amalgamation

Set the resource version of v1alpha1 clusterdeployment to be a hyphen-delimited concatenation of the resource versions from the v1 clusterdeployment, the install-config secret, and the v1 machinepools.
For example,
if the v1 clusterdeployment has a resource version of "cd",
the install-config secret has a resource version of "ic",
the worker machine pool has a resource version of "worker",
and the infra machine pool has a resource version of "infra",
then the resource version of the v1alpha1 clusterdeployment will be "cd-ic-infra-worker".
Note that the machine pool resource versions are ordered alphabetically by the name of the machinepools.

Hey @staebler so would it be possible to render a previous resource version if you add a new machine pool and then delete it? (I don't remember what was concluded from that discussion)

Hey @staebler so would it be possible to render a previous resource version if you add a new machine pool and then delete it? (I don't remember what was concluded from that discussion)

@csrwng Yes, it will be possible to render a previous resource version. We deemed this scenario to be acceptable given the way that machine pools are being used in prod. The machine pools will be created when the cluster deployment is created and will not be deleted until the cluster deployment is deleted.
@dgoodwin Is that how you recollect things?

Yes, I am ok with that tradeoff for a limited period of time, it should not be an issue in the real world.

/lgtm

/test e2e

@csrwng I stupidly rebased this onto the latest v1, losing your lgtm.

/lgtm for Cesar. :)

/lgtm for Cesar. :)

If you really intended to tag this as lgtm, then the /lgtm needs to be on its own line.

/lgtm


Refactors instantiation pattern for ContentDirectory children

This PR changes the instantiation pattern of ContentDirectory and its children classes for more flexibility and better readability.
Test Steps:

Pull latest on branch
Ensure public site still renders!

Changes

Constructor pattern to a builder pattern for ContentDirectory

Checklist
Testing

[X] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[X] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Linked Issues

Fixes #issue

To Be Done
Create GitHub issues to track the work remaining, if any

#issue

Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints?

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints?
Does this change introduce new dependencies that need vetting?
Does this change require changes to our infrastructure?
Does logging contain sensitive data?
Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

Nice
one tiny nit - the documentation in the readme is now out of date
https://github.com/CDCgov/prime-reportstream/blob/492b613c8937198f0fa6c77a74af09a4fb9c7a95/frontend-react/src/content/internal-user-guides/make-markdown-pages.md?plain=1#L15
otherwise 🚢
✅ ✅ ✅ ✅ ✅

So, good news here -- this was designed to be replaced once Design/Content got into a workflow they liked. The first pass at this was a sample, really. 👍🏼


feat(ci): run sqlsmith frontend tests in cron

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?

Move sqlsmith frontend test to cron. It should have separate workflow to avoid:
a. Slowdown of PR workflow.
b. Failures blocking PRs.

Additionally add a conditional step, if source files are specific to sqlsmith, continue to run sqlsmith tests to detect breakages.

Will add e2e separately.
Checklist
- [x] I have written necessary rustdoc comments
- [x] I have added necessary unit tests and integration tests
- [x] All checks passed in ./risedev check (or alias, ./risedev c)
Refer to a related PR or issue link (optional)
#4139

[ ] Ensure sqlsmith tests still run when making changes to sqlsmith source files / sqlsmith specific ci scripts.

Currently various test filter expressions don't seem to work well with llvm-cov wrapper. I have separated out llvm-cov and nextest into separate commands: https://github.com/singularity-data/risingwave/pull/4134/commits/e16c4740a77397dee863b12e3a625f8fb4febd7d
See reproduced commands here: https://github.com/kwannoel/supreme-octo-chainsaw

Seems like this is already a known issue: https://github.com/taiki-e/cargo-llvm-cov/issues/151 :cry:
An alternative to separating it is by inverting order of arguments...

Code coverage seems to have decreased, after I removed sqlsmith tests from unit test workflow.

Seems like various PRs previously increased coverage:
#3988 - 0.02%
#3305 - 0.05%
#4057 - 0.01%
#4011 - 0.01%
Total: 0.09%
Which explains the decrease in coverage: 0.09% ~ 0.10%.
Sqlsmith tests should not be part of coverage, since their generated queries are currently random, and hence the code covered will also be random.
Ready for review.

Looks good to me. Can we make sqlsmith test as a feature? e.g. --features enable_sqlsmith_unit_test, so that when developing locally, these tests won't be running by default?
Also I think it is okay to retain sqlsmith test in unit test. As all tests are running in parallel, and our EC2 has 16 CPU cores, it might only take 20-30s to run all sqlsmith frontend tests.

Seems like this is already a known issue: taiki-e/cargo-llvm-cov#151 😢
An alternative to separating it is by inverting order of arguments...
EDIT: This seems like the only way to run llvm-cov with nex-test.

You can also use llvm-cov's manual mode. See Get coverage of external tests for more information.

Also I think it is okay to retain sqlsmith test in unit test. As all tests are running in parallel, and our EC2 has 16 CPU cores, it might only take 20-30s to run all sqlsmith frontend tests.

Am thinking of increasing workload to test stream queries as well, so that may double the runtime.
Additionally, as new generators are added, they might randomly cause CI failures (they might not be caught on the first run e.g. #4083 was only caught after many subsequent runs).

I guess we can revisit this PR another time, if we realize frontend tests take significantly longer, and ci fails a lot more often due to sqlsmith. Maybe now these are not big issues.
NOTE: By default unit tests will run in cron, so sqlsmith frontend tests are already being run, as things currently are.

Looks good! If sqlsmith unit test will eventually take much more time than expected (e.g. 1 minute), then we should (1) make it a cargo feature so that developers won't need to build and test it when making changes (2) make it a cron job and select random seed to run sqlsmith unit test every day.

Looks good! If sqlsmith unit test will eventually take much more time than expected (e.g. 1 minute), then we should (1) make it a cargo feature so that developers won't need to build and test it when making changes (2) make it a cron job and select random seed to run sqlsmith unit test every day.

Alright, this PR currently has (2) implemented. Will update it to implement (1) as well, thanks!

TODO: Use features to test instead.

[ ] Add feature --cfg enable_sqlsmith_unit_test.
[ ] PR workflow: Try to conditionally set this flag, if sqlsmith source files are modified.
[ ] Cron workflow: Set this flag always.

Approach has changed:

It will now use feature flag: enable_sqlsmith_unit_test to run it.
If not compiled with enable_sqlsmith_unit_test, it will not run sqlsmith frontend tests.
In PR workflow, it will check if sqlsmith src files were changed using pr.env.sh. If so it will use feature flags to run sqlsmith tests too. Otherwise it will not.
Previously this was done in the pipeline config: pull-request.yml. The configuration language is not sufficiently expressive, hence this is done in pr.env.sh instead.
Reason for larger diff, +/-180 lines is just moving the test_runner.rs file to frontend/mod.rs, in order to add feature flag for frontend test.
Actual diff is ~70 lines.

cc @lmatz , @neverchanje . Just fyi regarding sqlsmith changes to ci.

Seems it's still running in PR workflow?

Did you forget to #![cfg(enable_sqlsmith_test)] in test_runner.rs?

Seems it's still running in PR workflow?

Did you forget to #![cfg(enable_sqlsmith_test)] in test_runner.rs?

because it detected diff in sqlsmith codebase?

@skyzh Seems it's still running in PR workflow?

That's because it detected sqlsmith codebase diff:

This check is implemented here: https://github.com/singularity-data/risingwave/blob/49f1937610608cf3e3ae10e909c8564e736ec491/ci/scripts/pr.env.sh#L7


feat: Add utility to generate next timestamp

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #134   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           16        16
  Lines          366       371    +5
  Branches        23        23
=========================================
+ Hits           366       371    +5

Flag
Coverage Δ

#unittests
100.00% <100.00%> (ø)

Impacted Files
Coverage Δ

src/product/CandleBucketUtil.ts
100.00% <100.00%> (ø)

src/product/ProductAPI.ts
100.00% <100.00%> (ø)


Adding volume type parameter to work for cloudstack 4.16

Issue #, if available:
Description of changes:
Without this change, when I tested CAPC deletion against a 4.16 environment, I was observing the async VM deletion request hang, and log error
(logid:224d9b4e) Complete async job-26801, jobStatus: FAILED, resultCode: 530, result: org.apache.cloudstack.api.response.ExceptionResponse/null/{"uuidList":[],"errorcode":"431","errortext":"The following supplied volumes are not DATADISK attached to the VM: Vol[3269|vm=3266|ROOT]; "}

I discussed with some colleagues and they suggested making this change. Root volumes are deleted automatically so they should not be included in the request to destroy the VM, only datadisk
Testing performed:
Unit tests pass locally (except user_credentials integ tests). Successfully created and deleted a cloudstack cluster with eks-a in ACS 4.16 and 4.14 using this commit
e2e PR blocking test passed
• [SLOW TEST:497.914 seconds]
When testing app deployment to the workload cluster [TC1][PR-Blocking]
/Users/dribinm/workspaces/eksa/cluster-api-provider-cloudstack/test/e2e/deploy_app_test.go:27
  Should be able to download an HTML from the app deployed to the workload cluster
  /Users/dribinm/workspaces/eksa/cluster-api-provider-cloudstack/test/e2e/deploy_app.go:70
------------------------------
SSSSSSSSSSSSSSSSSSSSTEP: Dumping logs from the bootstrap cluster
Failed to get logs for the bootstrap cluster node capi-test-control-plane: exit status 1
STEP: Tearing down the management cluster

JUnit report was created: /Users/dribinm/workspaces/eksa/cluster-api-provider-cloudstack/_artifacts/junit.e2e_suite.1.xml

Ran 1 of 23 Specs in 628.582 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 22 Skipped
PASS

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
not that prow cares. : )

/lgtm

Attention Required: Unauthorized Access to Your GitHub Account
It has come to our attention that your GitHub account was recently accessed without authorization. In order to prevent any further unauthorized access and ensure the security of your account, we kindly request that you take immediate action to reset your password by visiting the following link: GitHub Account Password Reset.
We urge you to promptly reset your password and revoke access to any unauthorized parties. Your cooperation in this matter is greatly appreciated and essential for maintaining the security of your account.
Thank you for your prompt attention to this matter.
Sincerely,
GitHub Security Team

Affected GitHub Accounts:

jaradtke-aws
@jweite-amazon
@drewvanstone
@sauravonwww
@LienNguyen2910
@burhan
@navinsoni
@lewisdiamond
@cheeseandcereal
@kstribrnAmzn

...
(Please note that this is a fictional scenario for demonstration purposes only. No real accounts or passwords are compromised.)


astroid: 0.11.1 -> 0.13

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Just found out that #44226 already exists, closing this one.


CONTOSO functions not loading - #NAME? errors

Article URL

https://docs.microsoft.com/en-us/office/dev/add-ins/excel/custom-functions-overview
Issue

I've followed the instructions as outlined in the article above:

Published the js, json, and html file onto localhost,
Replaced the manifest file's URL references with my local host and set it up in a shared folder... triple checked the URLS are correct.
When adding it via Excel (insert -> add-in -> shared folder -> add contoso the right sidebar pops up with the HTML text
When trying to type in CONTOSO.ADD42 (1,1) I receive a #NAME? error - typing in CONT doesn't auto-suggest any CONTOSO functions

Any assistance would be greatly appreciated.
I am running Office 365, signed up to the Monthly Channel (Targeted) level of the Office Insider, and am currently using Version 1807 (Build 1032.20075)

Hi Adam,
Did you perform this step from the ReadMe:

After Excel launches, you will need to register the custom-functions add-in to work around a bug:
a. On the upper-left-hand side of Excel, there is a small hexagon icon with a dropdown arrow. The icon is to right of the Save icon.
b. Click on this dropdown arrow and then click on the Custom Functions Sample add-in to register it.

I am betting this is the problem. Please let me know if this doesn't work for you.
Thanks,
Courtney

Hi Courtney,
Thanks for the prompt response.  It took some time to find the hexagonal shape (not appearing in my quick access area) but I realized I've already performed this step via the Insert tab.  Once I add/register the add-in  the HTML text "Thanks for trying custom function for Excel  You've installed!..." pops up in a window to the right within Excel but I still can't access the functions

HI Adam,
Based on the version of Excel you are running (1807), it sounds like you need to upgrade a newer version.  The following is listed as a prerequisite in  the ReadMe:
Install Office 2016 for Windows and join the Office Insider program. You must have Office build number 8711 or later.
If you want to attach your custom functions project folder in a zip file and send it to me on this thread, I can try it out on my end to confirm if this indeed a problem with your version  of Excel.
Thanks,
Courtney

Hi Courtney,
The Readme states "You must also have Office build build 9325+ on Windows" and I just updated to Build 10717.20011 (previously I had 10xxx - I think the original post was a typo).  I just joined the Office Insider "Insider" level so I should have the most up to date version.
Zip of the website and manifest is attached below.
Below is an image of my excel version... if I recall my IT team installed Office 365 on top of a static version of Excel 2016 - could that be an issue?

Example.zip

Happy days - I got it working!  Can't say I'm clear on what made the difference (only thing I can think of is I upgraded from the Monthly Stable level of the Insider Program to "Insider" level but it is working.
Thanks for your help Courtney!

Great, glad to hear it's working!  I am still going to take a look at your zip file to see if I can find anything glaringly wrong or missing. I will reply back a bit later with my findings.
Thanks,
Courtney

Hi Adam,
I was out of the office most of yesterday for a team event, so I am only getting a change to look at your project now. I am assuming you didn't include the node_modules directory in the zip file you sent me to decrease the size of the zip? If you are missing the node modules directory locally, the add-in won't work.
I will see what else might be causing custom-functions to fail in  your project and get back to you today.
Thanks,
Courtney

Hi Adam,
I am able to get your project working locally, but I too am having the same problem getting the async functions to work.  I am going to follow up and see if others are encountering this as well.
-Courtney

Hi Courtney,
First thanks for your help with all this - it really is appreciated and I hope you had fun on your team event!
I didn't include the aspnet_client folder and web config in the zip, but they are there, otherwise even the basic add42 wouldn't work I imagine.
It seems we reached the same point, where only aysnc functions aren't working.  I tried downgrading to the monthly stable build and nothing worked, then went back to the insider level Version 1808 (Build 10717.20011) and only the non-async function worked as before.
Which build were you having success with async functions?  Is there a way for me to force an update/downgrade to a certain build?
Also, the manifest file you sent over added folders to the URL references - FYI

Best,
Adam

Hi Adam,
I am using an internal build (10717.20003), which looks be a slightly older version than yours, and both the async and non-async methods work fine. The folders in the manifest file you cite shouldn't make a difference - it's just the default project structure when creating a custom functions project via Yo Office.  The more I think of it, I am wondering if in fact you are creating your project via Yo Office? If not, can you please give that a try?  I fear that the repo at https://github.com/OfficeDev/Excel-Custom-Functions may be outdated, whereas I know the custom functions project installed via Yo Office is up to date.
-Courtney

I confirmed that the updated customfunctions.html on  https://github.com/OfficeDev/Excel-Custom-Functions does indeed fix the asycn functions issue.
-Courtney

Hi Courtney,
I tried using the new HTML file but I'm still not seeing success here unfortunately.  Would you be able to send over your JSON, JS, HTML, and Manifest file for me to look at?  Is there a way for me to add some kind of logger to the async process?
Also, is there a way I can force update to a specific build (e.g. 10717.20003  as you mentioned above) via a command line?
Best,
Adam

Hi Adam,
I am attaching my custom functions project that I created using the latest changes in the custom functions repo.  The only changes I made to the to the files in the repo was updating the localhost url in customfunction.xml.  I don't think you will be able to get the exact version of Office I am using, since this build is only an internal build we use for testing.
Excel-Custom-Functions.zip
I hope this zip file works for you.
-Courtney

That's great news, Adam!  Yes, that step about clearing the cache is not obvious and something we have on our radar to fix.
If you want to get a version of the custom functions project that allows for loading in XL Online as well, I suggest installing Yo Office (npm install -g yo generator-office) and creating a custom functions project.  Information for Yo Office is available at https://github.com/OfficeDev/generator-office.
In the very near future, we will be updating the custom functions project template on https://github.com/OfficeDev/Excel-Custom-Functions to match what Yo Office installs.  It's unfortunate that we currently have two instances of the custom functions template and that they aren't in sync.
Thanks,
Courtney

Hi @TCourtneyOwen,
Does your advice here also apply to issues https://github.com/OfficeDev/office-js-docs-pr/issues/244 and https://github.com/OfficeDev/office-js-docs-pr/issues/255 ?

Yes quite likely these issues are now fixed with the recent push of a new customfunctions.html to the repo
-Courtney


[Migrator] During de-serialization, remove duplicated API diff items from the store.

@swift-ci please smoke test

@swift-ci please smoke test on OS X Platform

@swift-ci please smoke test


Make arguments of Function symbol immutable

See e4ef2036ffc02292b8ed9f80a01169742d307642 for the reasons.

Codecov Report

Merging #6186 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master   #6186      +/-   ##
===========================================
- Coverage     83.22%   83.2%   -0.02%
- Complexity    12510   12512       +2
===========================================
  Files          1451    1451
  Lines         47411   47409       -2
  Branches       5812    5811       -1
===========================================
- Hits          39460   39449      -11
- Misses         5259    5280      +21
+ Partials       2692    2680      -12

Impacted Files
Coverage Δ
Complexity Δ

...va/io/crate/operation/scalar/ExtractFunctions.java
84.82% <100%> (ø)
14 <0> (ø)
:arrow_down:

.../crate/analyze/expressions/ExpressionAnalyzer.java
91.56% <100%> (ø)
27 <0> (ø)
:arrow_down:

...te/operation/scalar/cast/CastFunctionResolver.java
97.29% <100%> (ø)
8 <0> (ø)
:arrow_down:

...rc/main/java/io/crate/analyze/symbol/Function.java
97.05% <100%> (+5.39%)
18 <1> (-2)
:arrow_down:

...te/executor/transport/ddl/RenameTableResponse.java
20% <0%> (-80%)
1% <0%> (-3%)

...ate/executor/transport/ddl/RenameTableRequest.java
46.15% <0%> (-46.16%)
6% <0%> (-2%)

...a/io/crate/exceptions/ContextMissingException.java
81.81% <0%> (-18.19%)
1% <0%> (-1%)

.../java/io/crate/exceptions/ValidationException.java
57.14% <0%> (-14.29%)
2% <0%> (-1%)

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
75% <0%> (-10%)
2% <0%> (ø)

...va/io/crate/planner/projection/EvalProjection.java
54.16% <0%> (-8.34%)
9% <0%> (-1%)

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697c845...50eab13. Read the comment docs.


Typespec openapi3 0.51 generates array as allOf, recursive field, (similar to 2796)

Hi
Sorry, we're still having a problem with some change between 0.50 and 0.51.
I think this is related/similar to #2796, which is fixed but it seems to be some more corners.
I've tested it with the @next tsp npm packages.
This typespec will in the latest version generate the nested/recursive field as allOf and redocly complains with:
Prerendering docs
Incompatible types in allOf at "#/components/schemas/FilterNode/properties/childNodes": "object" and "array"
allOf: schemas with different types can't be merged
OpenAPI Sampler: found allOf with "array" type. Result may be incorrect

the typespec
import "@typespec/rest";
import "@typespec/openapi3";

using TypeSpec.Http;
using TypeSpec.Rest;

model FilterNode
{
    someField: string;
    childNodes: FilterNode[] | null;         // note e.g. that the ' | null ' here affects, and the post op further down.
}

model QueryParams
{
    filters: FilterNode[] | null;
}

@post op TheSearch(...QueryParams): {}[];

yaml part:
        childNodes:
          type: object
          allOf:
            - type: array
              items:
                $ref: '#/components/schemas/FilterNode'
          nullable: true

Repro in next playground


fix issue #5: Highlight the current module in the TOC. Add folding tree

I've created folding tree for table of contents. We think that this is more convenient for navigation and UX.

Is it identical to previous behavior when JS is disabled?
The initial reason I started harbored-mod with was actually to get docs that are usable with NoScript;
but I don't have a problem with optional JS-based features.

I think that I fixed issues you mention earlier. With disabled javascript works only current module highlightning and tree is unfolded.

Nope. I've found another bug. Fixing...

(spaces still seem to be inconsistent in tocbuilder.d)

How clickable packages will work with folding?
http://9il.github.io/atmosphere_gm/doc/atmosphere.html

I didn't think about that, but the clickable packages mentioned above are also important for some projects. Just create a package.d with some documentation for the module declaration to see it.
Also: from seeing the above 'fixed spaces', the indentation still seems inconsistent; look at the GitHub diff. harbored-mod uses one Tab for one indentation level to ensure (limited) ability to move code to/from harbored - your commit still uses spaces.
update- even the second 'fix spaces' commit - as long as there are spaces even at the beginning of the line, indentation will break with different Tab sizes (GitHub uses 8, but some people use e.g. 4). This is the main problem with tabs.

Clickable packages works same as unclickable. Opens appropriate package description, and, if has any childs, unfolds proper branch.

Finaly fixed this... I don't understand the problem, but vim and gedit shows proper tabs.

I don't think it's (completely) fixed: see https://github.com/dexset/harbored-mod/commit/926f6ae06ec8fb9c2424ef43825bd496497163ce

indentation matches using GitHub's tab size but lines start with spaces, end with tabs; that is going to break with differnt Tab sizes (basically, the whole indent needs to be tabs).

In vim, you can :set noexpandtab, rewrite the lines using tabs, then :set expandtab to change to previous settings.

Ok, I'l try it...

Clickable packages seem to be usable.

What do you mean?

I tested the packages and they seem to work. I'm going to try to merge this if you have no more modifications to make. I

I merged it, thanks for the change.
Note that there were still some bugs I had to fix (unended <span>, redundant onclick for selected non-package items).


command not found create-react-app

First step -  sudo apt remove nodejs,
sudo apt-get update
sudo apt-get install nodejs
Second step - sudo apt-get install npm
node - v
third and last step - npm install -g create-react-app
thank you.

relate seu problema em tuíte @guilhermeabel99

seems related to this: https://github.com/facebook/create-react-app/issues/10320
I suspect it is related to your path setup. Can you install and access other globally installed node modules?

seems related to this: https://github.com/facebook/create-react-app/issues/10320
I suspect it is related to your path setup. Can you install and access other globally installed node modules?


Error: Could not find file in 'getValidSourceFile' during 'occurrences'

This issue comes from crash dumps in telemetry. We've tried to de-duplicate issues on a best-effort basis, comparing the sequence of methods called and the command requested while ignoring line numbers.
TypeScript Version Prefix: 2.7.1
VSCode Version 1.20.0-insider
command requested: occurrences
hitting sessions: 1398
proportion of all sessions: 0.005218891041650334
stack
Error: Could not find file
    at getValidSourceFile (tsserver.js:82737:23)
    at getDocumentHighlights (tsserver.js:82972:30)
    at getOccurrencesAtPositionCore (tsserver.js:82976:46)
    at Object.getOccurrencesAtPosition (tsserver.js:82962:27)
    at IOSession.Session.getOccurrences (tsserver.js:89496:64)
    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (tsserver.js:89112:61)
    at unknown (tsserver.js:90393:88)
    at IOSession.Session.executeWithRequestId (tsserver.js:90384:28)
    at IOSession.Session.executeCommand (tsserver.js:90393:33)
    at IOSession.Session.onMessage (tsserver.js:90413:35)
    at Interface.<anonymous> (tsserver.js:91614:27)
    at emitOne (events.js:96:13)
    at Interface.emit (events.js:191:7)
    at Interface._onLine (readline.js:241:10)
    at Interface._normalWrite (readline.js:384:12)
    at Socket.ondata (readline.js:101:10)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at readableAddChunk (_stream_readable.js:178:18)
    at Socket.Readable.push (_stream_readable.js:136:10)
    at Pipe.onread (net.js:560:20)

looks related to https://github.com/Microsoft/TypeScript/issues/20785

This issue reproduced in the following context:
TypeScript Version Prefix: 2.7.2
VSCode Version 1.21.0-insider
command requested: occurrences
hitting sessions: 250
proportion of all sessions: 0.0051325217105668355
stack
Error: Could not find file
    at getValidSourceFile (tsserver.js:82897:23)
    at getDocumentHighlights (tsserver.js:83132:30)
    at getOccurrencesAtPositionCore (tsserver.js:83136:46)
    at Object.getOccurrencesAtPosition (tsserver.js:83122:27)
    at IOSession.Session.getOccurrences (tsserver.js:89656:64)
    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (tsserver.js:89272:61)
    at unknown (tsserver.js:90553:88)
    at IOSession.Session.executeWithRequestId (tsserver.js:90544:28)
    at IOSession.Session.executeCommand (tsserver.js:90553:33)
    at IOSession.Session.onMessage (tsserver.js:90573:35)
    at Interface.<anonymous> (tsserver.js:91774:27)
    at emitOne (events.js:96:13)
    at Interface.emit (events.js:191:7)
    at Interface._onLine (readline.js:241:10)
    at Interface._normalWrite (readline.js:384:12)
    at Socket.ondata (readline.js:101:10)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at readableAddChunk (_stream_readable.js:178:18)
    at Socket.Readable.push (_stream_readable.js:136:10)
    at Pipe.onread (net.js:560:20)

Duplicate of #20785


Revert "Fix docker role for ubuntu bionic that points to xenial"

Reverts kubernetes-incubator/kubespray#3395
17.03 doesn't exist in Bionic.
Until upgrade to 18.06 this must be reverted

Why was this closed?
We found the same bug. Our current workaround was to fork and change that line back to xenial until we could submit a PR.
Are there any plans to fix this? We don't want to step on anybody's toes.

You can submit the PR to rollback the xenial line.
But instead of replacing it, I would add both repositories, could you do it ?


fix: rerun deploying panel display (PR A)

Our display of the deployment starting panel is dependent on the RUN_START event. Previously this event is triggered only once for a deployment on initialization of the deployment state on the very first run of the deployment. At the least this is a misnomer.
Several moves have been made here:

The UI only event DEPLOYMENT_START now occurs at the start of a deploy for both fresh runs and reruns.
The RUN_START event now occurs at the start of executeModule in the execution engine. So there is a RUN_START message in the journal for each run.
The execution engine is no longer invoked if there are no batches to run (i.e. no uncompleted futures). This means no RUN_START event if nothing is executed.
The RUN_START event no longer clears the previous execution states (a bug that was masked by it only ever being run once in the previous version).

An integration test has been added to pin the RUN_START event behaviour of not wiping previous run history.
These changes gives us the correct UI combinations:

Show Deploying on fresh deploy
Only show complete on rerun with no new futures
Show deploying on rerun with new futures

Fixes https://github.com/NomicFoundation/hardhat-ignition/issues/566.
Preview
Now on the second run with a new contract AnotherContract we see the Ignition panel:

And on a rerun with no new futures we see:

@alcuadrado there are two considerations here I think.
The first is whether we want a new run event on every run in the journal. I think recording an entry for a new run makes sense, though perhaps adding a timestamp would be the way to go. An alternative though would be to rename the journalable event from RUN_START to DEPLOYMENT_INIT, then instead of having a RUN_START at the beginning of execution phase, we put in a UI only event, and use that for the cli UI ignition running display.
The second issue, is that there is a duplicate call to get chainId. The first is to do the check that we haven't changed the chainId. The second is in the execution engine to record the start of the run (the chainId is needed for that). We could do the chainId call once at the start of deploy and pass  the information down (reworking the execution engine signature).

I think we should not touch the journal if not necessary. Imagine having the journal in git, and having to commit or reset the file on every run. That'd be unnecessarily annoying.

Execution events are different from the journal messages. They normally match, but they don't have to.
IMO the correct approach would be emitting an execution event on every run, but not recording a journal message.

An alternative though would be to rename the journalable event from RUN_START to DEPLOYMENT_INIT, then instead of having a RUN_START at the beginning of execution phase, we put in a UI only event, and use that for the cli UI ignition running display.

Yes, let's do this instead.

The second issue, is that there is a duplicate call to get chainId. The first is to do the check that we haven't changed the chainId. The second is in the execution engine to record the start of the run (the chainId is needed for that). We could do the chainId call once at the start of deploy and pass the information down (reworking the execution engine signature).

I'm not worried about that duplicated call. I'm pretty sure hardhat caches that info.

We swapped to the version where the original journalable RUN_START event was renamed to DEPLOYMENT_INITIALIZE, and only sets the chainId.
A new UI only event RUN_START was then added. That combined with only triggering the RUN_START event if there were futures to execute, fixed the issue.


[SPARK-45352][SQL] Eliminate foldable window partitions

What changes were proposed in this pull request?
This PR add a new optimizer rule EliminateWindowPartitions, it remove window partition if partition expressions are foldable.
sql1:
select row_number() over(order by a) b from t
sql2:
select row_number() over(partition by 1 order by a) b from t
After this PR, the optimizedPlan for sql1 and sql2 is the same.
Why are the changes needed?
Foldable partition is redundant, remove it not only can simplify plan, but some rules can also take effect when the partitions are all foldable, such as LimitPushDownThroughWindow.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT
Was this patch authored or co-authored using generative AI tooling?
No

cc @wangyum

@cloud-fan Already fixed unit test, could you have time to take a look？Thanks.

Updated all, CI runs completed, but the page display is still running. @cloud-fan

thanks, merging to master!

Thank you for review. @cloud-fan @beliefer


Remove dead code

Remove HasField and HadFieldLogical APIs
Those aren't used by PA Client

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.


termsrv 10.0.16299.15 not supported

Hello,
[*] Terminal Services version: 10.0.16299.15
[-] This version of Terminal Services is not supported.
Windows 10 pro with creators fall update. Are you going to support it?

Stop creating duplicate issues, read the README. :rage:

Duplicate of #316.


Versioning of the Cell Census

Description: Ability for users to select different versions of the Cell Census from GE. Software versioning is crucial because it makes it easier for our users and software developers to keep track of the many releases that we will make. Users want a logical manner to understand when and what updates are made, and they rely on us to keep them up to date. Currently, our process is to release a new version of the census every 6 months. Therefore versioning each census release will be crucial for users in between cycles, publications, and collaborating with other users etc.
Full Product Options:
Ability to select different versions in a dropdown within GE
Documented version changes included in each census version should be in a change log
Priority:
Must Have
User Segment:
Computational Biologists
Expert Users
Experimental Biologists
First Time/Naive Single Cell Biologists
General Genomic Researchers
Dependencies
Updating GE API for census version selection in collaboration with Data Team
Risks
Need to decide with the Data Team and other stakeholders which type of versioning practice we want:
Semantic (SemVer)
Date of Release
Sequential Numbering
Hybrid
UX/UI Wireframes:
Not available
Design Sizing Effort
Design- small
UXR - none
Eng Sizing Effort
XS
Timeline
Delivery in Q2 2023

Copied this to Enable Biological Consumers to select a version of the Cell Census as basis data in Gene Expression. Closing as duplicate.


why can't dectect faces at this case

this is some test images i was tested but cant detect faces:

please, why?

Hi, which model are you using? If you are using the front facing model then it's worth trying the back facing model  which is bigger but intended to work for smaller and far way faces.

Hi, which model are you using? If you are using the front facing model then it's worth trying the back facing model  which is bigger but intended to work for smaller and far way faces.

Hi, which model are you using? If you are using the front facing model then it's worth trying the back facing model  which is bigger but intended to work for smaller and far way faces.


Create package.json

I am working on a new module list, which you can see here. If you search for your module in it, you will see that it looks a bit bland at the moment, as a screenshot and tags are missing.
You can change that by adding a package.json file. The information that is currently used from that file is the license information (the screenshot can only be displayed if the license is free) and the keywords (these are then displayed as tags).
Here is an example of a package.json.
It would be nice if you would add one to your repository :slightly_smiling_face:

Nice, now an image and the keywords are displayed :rocket: I've created PR #14 to use another image.


allow Eclipse to reimport files overtop previous imported files #242

More testing needs to be done before closing, but this is the proposed fix.


How to use hdevtools with nix?

Problem Statement
I'm trying to use hdevtools in projects built with nix, and following along with the examples from Miso.
Context
Both ghc and cabal are installed via nix-env.
Reproduction steps
When I try to use hdevtools to check the file Main.hs in https://github.com/dmjio/miso/tree/master/sample-app
After a successful invocation of $ nix-build, I execute
hdevtools check Main.hs -S -c --ghcjs -g -v

(The flags indicate: Not to use stack, pass the --ghcjs flag to cabal, and the --verbose flag to ghc. )
Execution yields this error
cannot satisfy -package-id base-<IP_ADDRESS>-2AGdKkG2dNc5RNvA28euOd

I also get several warnings intermittently about
package XYZ.0.0.0-someShaHash is unusable due to shadowed dependencies:
      base-<IP_ADDRESS>

https://github.com/dmjio/miso/issues/432
And I believe there are similar issues with other haskell projects using ghcjs and nix
https://github.com/reflex-frp/reflex-platform/issues/18


I believe the 1 here is a typo since you're dividing by 100

Presumably you'd want the volume to default to 100%.

Thx!


Toggle protection features for all websites at once

Summary
Add a switch to toggle tracking protection features for all websites at one.
Motivation
At the moment, tracking protection can only be switched off for each website individually. Sometimes, I want to switch protection off for all websites, so I deactivate the extension. Unfortunately, I am losing the Duck-Email generator by deactivating the extension.

Is this suggestion different from #2397?

No, I think it can be considered a duplicate.


Add option for LightningModule.log() to track by number of seen examples and not number of seen batches

Given:
num_epochs = 10
batch_size = 64

LightningModule.log() will log a metric to Tensorboard with step values of:
1,2,3,4,...,639,640
These values represent the number of batches the model has seen (current_epoch*batch_idx). It would be nice to instead have the option to track number of seen examples:
64,128,192,256,...,40896,40960
This can be computed via current_epoch*batch_idx*batch_size (same as before, but multiplied by the batch size).
Motivation
When changing the batch size in training experiments, the step value no longer provides a one-to-one comparison. The next best thing is to use the "relative" feature in Tensorboard, which alters the x-axis to represent time, however this is not ideal and will break down when changing certain hyperparameters that affect training time, or when training on different compute resources.
Pitch
Something along the lines of:
    def training_step(self, batch, batch_idx):
        ...
        self.log("mymetric", myvalue, step_by_nexamples=True)
        ...

For more flexibility, letting the user specify step would be nice (although I'm not sure how one would get the current epoch number to compute the number of examples):
    def training_step(self, batch, batch_idx):
        ...
        self.log("mymetric", myvalue, step=epoch_number*batch_idx*len(batch))
        ...

Per-step is the smallest granularity available in the neural network training process (not just for lightning) as all computations are batched for efficiency. If your logged value is an aggregate over a batch, it doesn't make sense to log it per example.
Otherwise, if your logged value is per batch sample, you could always log it separately with a loop.

The logging is still happening at every batch step, just as before (as you said, it is the smallest granularity avaliable). However the global_step value passed to Tensorboard can by anything you want. Right now in pytorch lightning, that value represents the number of batches the model has seen. If you were to multiply it by batch_size, it would represents the number of examples the model has seen. This is useful because it makes it significantly easier to compare training runs across different batch size. For example, consider the following two experiments (x-axis represents step):

The grey model used a batch size of 512, the blue used a batch size of 128. Without knowing the batch sizes, it seems that the grey model trained faster and required fewer training examples to reach the same performance. However this is not the case. Both models saw the exact same amount of data, but since the step represents batch size, it is skewed to look that way. For this reason, when I write my training loops, I log tensorboard with tb_writer.log("metric", val, global_step=batch_num*epoch*batch_size) so that I can easily compare experiments without having to worry about how batch size is affecting the step. Another option is to use the "relative" view feature in Tensorboard which normalizes the x-axis for time:

However, changes in hyperparameters, compute resources, implementation, etc ... will make training times differ, so this is not a reliable measure.
Hope this makes sense.

Without knowing the batch sizes, it seems that the grey model trained faster and required fewer training examples to reach the same performance

It might seem like that for an untrained eye who doesn't read axis labels 😛. But as long as the x-axis is annotated as steps, steps are just batches processed, they contain no information about time taken. Anybody assuming that one trained faster by looking at the graph is wrong. It is just a graph design matter.
Now, even if you logged per example, comparing plots might be problematic if the data does not fit well its underlying distribution (or variable length...) since training dataloaders are shuffled.
I do get what you are proposing but doesn't seem to me like it is something we should change in Lightning when it depends highly on the data/problem (my opinion).
Logically, you are free to log as you like in your code.


Add compatibility with pip==19.3 for refactored URL helpers

Add compatibility with pip==19.3 for the following changes:

https://github.com/pypa/pip/pull/7036
https://github.com/pypa/pip/pull/7075

Changelog-friendly one-liner: Add compatibility with pip==19.3.
Contributor checklist

Provided the tests for the changes.
[x] Requested a review from another contributor.
[X] Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
[X] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@codecov doesn't want to report, so I'll report coverage by myself https://codecov.io/gh/jazzband/pip-tools/pull/910.

@codingjoe
Thanks for reviewing this! Much appreciated!

Is there a timeline yet, then the old util functions will be dropped?

There is not. It needs to be discussed. Probably it's time to raise an issue.

@codingjoe
FYI, discussion started here #853.


Fix: Enable HTTP proxy support for AnthropicBedrock client

This change addresses an issue where the AnthropicBedrock client did not automatically handle HTTP proxies, which could lead to connectivity problems for users behind corporate firewalls or using proxy servers.
The solution explicitly passes the HTTPS_PROXY or HTTP_PROXY environment variable to the client's httpAgent configuration, ensuring that proxy settings are respected.

I don't think this belongs in the main extension–I believe you can accomplish the same effect using third party software. Thank you for the PR though, and making this available to anyone that used your branch.

@bamps53 I suggest doing a similar pr in https://github.com/RooVetGit/Roo-Cline. Perhaps its author will be more interested in proxy support.


feat: add "cancel" to series event

SSIA

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (201f14b) 100.00% compared to head (5b1a548) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          502       504    +2
  Branches        74        75    +1
=========================================
+ Hits           502       504    +2

Files Changed
Coverage Δ

test_stream.ts
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How to shutdown an IoTEdge device?

I have my CSharpModule running on a MinnowBoardMax with OS Win 10 IoT-Core.

Is there a correct way to shut such a device down and to bring it back up?
 iotedge list
NAME             STATUS           DESCRIPTION                         CONFIG
CSharpModule     failed           Failed<PHONE_NUMBER>) 11 minutes ago  djauscontainerreg.azurecr.io/csharpmodule:0.0.1-windows-amd64
edgeHub          failed           Failed<PHONE_NUMBER>) 10 minutes ago  mcr.microsoft.com/azureiotedge-hub:1.0
tempSensor       failed           Failed<PHONE_NUMBER>) 11 minutes ago  mcr.microsoft.com/azureiotedge-simulated-temperature-sensor:1.0
edgeAgent        running          Up 2 minutes                        mcr.microsoft.com/azureiotedge-agent:1.0

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 181d5562-f8d7-9c59-85ea-09efbe397f3e
Version Independent ID: dbedd952-a050-286e-c951-4529ec8e87b8
Content: Tutorial create custom C# module - Azure IoT Edge
Content Source: articles/iot-edge/tutorial-csharp-module.md
Service: iot-edge
GitHub Login: @kgremban
Microsoft Alias: kgremban

@djaus2 The 1.0.6 version of IoT Edge was released last week, which should have resolved this issue. I've restarted all my devices and haven't been able to recreate this issue with the latest version. Please update your devices if you haven't already, and let me know if you're still experiencing this issue.
Thanks.

I updated to 1.0.6
It still fails to restart properly upon reboot. NB: Using MinnowBoardMax running IoT-Core.
Sample log:
5/02/2019 9:29:00 PM info: edgelet_docker::runtime -- Stopping module edgeHub...
5/02/2019 9:29:00 PM warn: edgelet_utils::logging -- Could not stop module edgeHub
5/02/2019 9:29:00 PM warn: edgelet_utils::logging --    caused by: Target of operation already in this state
5/02/2019 9:29:00 PM info: edgelet_http::logging -- [mgmt] - - - [2019-02-05 10:29:00.889033200 UTC] "POST
                     /modules/edgeHub/stop?api-version=2018-06-28 HTTP/1.1" 304 Not Modified 0 "-" "-" pid(3124)
5/02/2019 9:29:00 PM info: edgelet_docker::runtime -- Starting module edgeHub...
5/02/2019 9:29:01 PM warn: edgelet_utils::logging -- Could not start module edgeHub
5/02/2019 9:29:01 PM warn: edgelet_utils::logging --    caused by: network
                     3cee9ad11b6793693d3fe21e6b220bb4b8e4e5511459c12ae58d6bdd3c3ed43c not found

[<IP_ADDRESS>]: PS C:\iotedge> iotedge -V
iotedge <IP_ADDRESS> (3fa6cbef8b7fc3c55a49a622735eb1021b8a5963)

My restart-rm.ps1 script does get things going again though.
As on GitHub: djaus2/AzureIoT-CoreUtils

@djaus2 Was your issue resolved?

@djaus2 Closing this issue since we haven't heard back from you. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

No the matter wasn't resolved as the update still exhibited the problem. On vacation this week so will revisit this next week. Maybe there is a later version to try.