docs(config): :memo: add missing keys in package.json

add missing keys, author, license, in package.json
Ref: wrappid/wrappid-module #22

@Swrnv-qc Please update package-lock.json

Since the license was already MIT, hence running npm i didn't result in any change


Documentation Chaos: Can add countributors github profiles in read me file.

Describe the Documentation Update
showcase all contributors github profiles that have contributed up till now.
Add References or Examples
No response
Confirm

[X] I understand that my update will add to the chaos and I'm okay with it
[X] I agree to follow this project's Code of Conduct
[X] I want to work on this documentation update
[X] I'm GSSOC'24 Extd registered Contributor
[X] I'm Hacktoberfest registered Contributor

Create a new file CONTRIBUTORS.md and add it there
add a chaotic design

Completed 👍


fix(redis): import redis pipeline using full path

Currently  Sentry uses redis-py-cluster==2.1.0 which does not expose the ClusterPipeline as a top level object. The fix was introduced in version 2.1.1 and another fix in 2.1.2 see https://github.com/Grokzen/redis-py-cluster/blob/master/docs/release-notes.rst
And getting following error
09:05:04 [INFO] sentry.plugins.github: apps-not-configured
Traceback (most recent call last):
  File "/Users/olksdr/dev/sentry/.venv/lib/python3.8/site-packages/sentry_sdk/integrations/redis.py", line 123, in setup_once
    _patch_rediscluster()
  File "/Users/olksdr/dev/sentry/.venv/lib/python3.8/site-packages/sentry_sdk/integrations/redis.py", line 88, in _patch_rediscluster
    pipeline_cls = rediscluster.ClusterPipeline
AttributeError: module 'rediscluster' has no attribute 'ClusterPipeline'

This PR makes sure to use the full path to import rediscluster.pipeline.ClusterPipeline which always available in any version now.
See errors in integration tests on https://github.com/getsentry/relay/pull/1413 and https://github.com/getsentry/relay/pull/1414 where the sentry master branch is used to run those tests with newly updated python sentry-sdk dependency.
Related changes which "broke" the sdk for redis-py-cluster==2.1.0 were introduced in https://github.com/getsentry/sentry-python/pull/1543

thx @olksdr I'm adding a test matrix entry from #1562 that captures this.


Update AzureMLKubernetes install parameters on inferenceRouterServiceType and internalLoadBalancerProvider

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

/azp run

/azp run

/azp run

/azp run


NullReference exception while publishing test results

Steps to reproduce
This doesn't happen all the time, it's on and off, although recently it seems to be happening more often than before. Our CI pipeline in DevOps fails at the test stage. The test run is successful and when test results are published the vstest app crashes with a null reference exception.
Captured diagnostics and full debug log from the Azure DevOps console and attached to this email alongside the output trx.
Considering the fact that is not always failing i'm just wondering if it's a timing issue whereby the trx is not yet flushed to the disk before it tries to read it?
Error stack trace

Error occurred while publishing test results : System.AggregateException: One or more errors occurred. ---> System.NullReferenceException: Object reference not set to an instance of an object.
    at Microsoft.TeamFoundation.TestClient.PublishTestResults.TrxResultParser.<>c__DisplayClass16_0.<ReadActualResults>b__1(String xunitParentNodeKey)
    at System.Threading.Tasks.Parallel.<>c__DisplayClass17_0`1.<ForWorker>b__1()
    at System.Threading.Tasks.Task.InnerInvokeWithArg(Task childTask)
    at System.Threading.Tasks.Task.<>c__DisplayClass176_0.<ExecuteSelfReplicating>b__0(Object )
    --- End of inner exception stack trace ---
    at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
    at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
    at System.Threading.Tasks.Parallel.ForWorker[TLocal](Int32 fromInclusive, Int32 toExclusive, ParallelOptions parallelOptions, Action`1 body, Action`2 bodyWithState, Func`4 bodyWithLocal, Func`1 localInit, Action`1 localFinally)
    at System.Threading.Tasks.Parallel.ForEachWorker[TSource,TLocal](IEnumerable`1 source, ParallelOptions parallelOptions, Action`1 body, Action`2 bodyWithState, Action`3 bodyWithStateAndIndex, Func`4 bodyWithStateAndLocal, Func`5 bodyWithEverything, Func`1 localInit, Action`1 localFinally)
    at System.Threading.Tasks.Parallel.ForEach[TSource](IEnumerable`1 source, ParallelOptions parallelOptions, Action`1 body)
    at Microsoft.TeamFoundation.TestClient.PublishTestResults.TrxResultParser.ReadActualResults(XmlNodeList resultsNodes, TestType testType, Dictionary`2 xUnitTestCaseCounts)
    at Microsoft.TeamFoundation.TestClient.PublishTestResults.TrxResultParser.ParseTestResultFile(TestRunContext runContext, String filePath)
    at System.Linq.Enumerable.WhereSelectArrayIterator`2.MoveNext()
    at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext()
    at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
    at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
    at Microsoft.TeamFoundation.TestClient.PublishTestResults.TrxResultParser.ParseTestResultFiles(TestRunContext runContext, IList`1 resultFilePaths)
    at Microsoft.VisualStudio.TestService.TcmTestResultPublisher.TrxTestResultPublisher.ParseTrx(TestRunContext testRunContext, IList`1 trxFilePaths)
    at Microsoft.VisualStudio.TestService.TcmTestResultPublisher.TrxTestResultPublisher.PublishTestRunResults(TestRunModel testRunModel)
    at MS.VS.TestService.VstestConsoleAdapter.PublishTestResult.CreateOrUpdateTestRun(TestRunModel testRunModel)
    at MS.VS.TestService.VstestConsoleAdapter.PublishTestResult.Publish(VstestConsoleRunContext testRunContext)
    ---> (Inner Exception #0) System.NullReferenceException: Object reference not set to an instance of an object.
    at Microsoft.TeamFoundation.TestClient.PublishTestResults.TrxResultParser.<>c__DisplayClass16_0.<ReadActualResults>b__1(String xunitParentNodeKey)
    at System.Threading.Tasks.Parallel.<>c__DisplayClass17_0`1.<ForWorker>b__1()
    at System.Threading.Tasks.Task.InnerInvokeWithArg(Task childTask)
    at System.Threading.Tasks.Task.<>c__DisplayClass176_0.<ExecuteSelfReplicating>b__0(Object )<---

Attachments
github-issue.zip
logs.txt

Operating system, Build version of vstest.console
OS: Windows (Windows Server 2016 Datacenter)
VSTest: 16.5.0

@uandrei can you confirm if you are still facing this issue with the vstestv2 task? This was patched a couple of weeks ago.
In the publish test results task it will be patched in a couple of days

hi @ShreyasRmsft , haven't upgraded vstest v2 task for some time, will do that and keep an eye on it.  do we need to update the vstest version too? at the moment that is pinned to 16.4.0

You cannot pin VSTest@2 task version as it is controlled by the server. Let me know if you are still running into this issue with the vstestv2 task and please provide full zip of logs with system.debug = true.

@ShreyasRmsft should we also upgrade to latest version of  VSTest?

@uandrei it's generally a good practice to stay on the latest stable unless your run into some issues, so yeah go ahead.

@uandrei please update to latest version of publish test results task and do let me know of you are still facing issue in that task.

@uandrei can you please confirm if the issue is resolved or not?

@Arwinder4 really sorry but not in a position to test this, so i'd just close the issue at the moment


feat: add ability to specify nginx_proxy.conf file

If there's an nginx_proxy.conf file in the user's $HOME/.docker/ directory.
This will allow for custom nginx configs like setting headers or mutual TLS using x.509 certificates in local setups.

Closed. Duplicated by #39

:tada: This PR is included in version 1.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat: upgrade Flow to 0.85.0

Summary
Been a while since the last update.
Test plan
Flow should pass

rebase? :D

Codecov Report

Merging #7303 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7303      +/-   ##
==========================================
- Coverage   66.63%   66.63%   -0.01%
==========================================
  Files         241      241
  Lines        9334     9333       -1
  Branches        5        5
==========================================
- Hits         6220     6219       -1
  Misses       3111     3111
  Partials        3        3

Impacted Files
Coverage Δ

...ackages/jest-cli/src/reporters/verbose_reporter.js
20.37% <ø> (ø)
:arrow_up:

...est-watcher/src/lib/format_test_name_by_pattern.js
89.47% <ø> (ø)
:arrow_up:

packages/expect/src/jasmineUtils.js
83.62% <100%> (ø)
:arrow_up:

packages/jest-config/src/normalize.js
85.53% <100%> (-0.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f32100...f22f65f. Read the comment docs.


Do OPENDAL_B2_* environment variables work?

There are several B2 variables listed in this .env example:
OPENDAL_B2_ROOT=/path/to/dir
OPENDAL_B2_BUCKET=<bucket>
OPENDAL_B2_BUCKET_ID=<bucket_id>
OPENDAL_B2_APPLICATION_KEY_ID=<key_id>
OPENDAL_B2_APPLICATION_KEY=<application_key>

I can't find these anywhere else in the codebase.  Do these actually work?

I can't find these anywhere else in the codebase. Do these actually work?

Yes. We actually have them tested in CI: https://github.com/apache/opendal/blob/main/.github/services/b2/b2/action.yml

The test logic happens here:
https://github.com/apache/opendal/blob/39e0a69c8eadc44391ba0420fdc7de2a42962ecf/core/src/raw/tests/utils.rs#L39-L86
We will load the service credentials specified by OPENDAL_TEST, initialize this service, and use it for testing.

Are you encountering errors when testing against b2? I might be able to help.

Thanks @Xuanwo.
I linked to this issue from:
rustic: OPENDAL_B2_* variables don't work #1073
https://github.com/rustic-rs/rustic/issues/1073

Sure, let's continue the discussion at https://github.com/rustic-rs/rustic/issues/1073 instead. I believe this isn't an issue for opendal. Feel free to reopen this if you need further discussion.


Discussion: Squashing vs. Rebasing

Let's have a common place to agree on commits to the master across all extensions.

@refs Squashing :)

Squashing would make sense if the commit history was our content source for the changelog. But since we made the decision to have user/admin targeted changelogs that are handcrafted in changelog items, there is no need to have a "1 commit = 1 feature" style of commit history in master. Just as an example, bisecting would become more useful if we had a fine grained commit history instead of bigger, squashed commits.

https://dhwthompson.com/2019/my-favourite-git-commit


Is setting environment variables allowed in WinUI3 Desktop app? (Error: Requested registry access is not allowed)

Is setting environment variables allowed in WinUI3 Desktop app?
I am seeing 'Requested registry access is not allowed' error with Stack Trace :
at Internal.Win32.RegistryKey.OpenSubKey(String name, Boolean writable)
at System.Environment.OpenEnvironmentKeyIfExists(Boolean fromMachine, Boolean writable)
at System.Environment.SetEnvironmentVariableFromRegistry(String variable, String value, Boolean fromMachine)
at System.Environment.SetEnvironmentVariable(String variable, String value, EnvironmentVariableTarget target)

Administrator access is not currently supported so if your environment variable accesses a part of the registry that requires it you wont be able to. Otherwise it should work.

I am trying to add a simple environment variable which is resulting in error.

If it doesn't work, do we have any alternative?

@stevenbrix @Austin-Lamb or @JesseCol fyi?

@abhi-msft - This is unrelated to WinUI - which is just a UI framework, so most likely the security restriction you're experiencing is due to the security container that Desktop Bridge apps (aka MSIX) are put in.  See here for more details: https://docs.microsoft.com/en-us/windows/msix/desktop/desktop-to-uwp-behind-the-scenes
I'm going to close this issue since it's not something that the UI framework can address.


Getting error related to s3 access for lambda

While trying to create a project using the custom template, I get the error
Resource handler returned message: "Your access has been denied by S3, please make sure your request credentials have permission to GetObject for my-bucket/lambda-github-workflow-trigger.zip. S3 Error Code: AccessDenied. S3 Error Message: Access Denied (Service: Lambda, Status Code: 403, Request ID: ##)" (RequestToken: ###, HandlerErrorCode: AccessDenied)
I am unable to figure out which role should I add the S3 GetObject policy to?

Hi @moumitaTora,
The execution role by default is this AmazonSageMakerServiceCatalogProductsLaunchRole

solved


Dear ImGui integration

Integrating Dear ImGui will allow me to create little GUI's for each module so that they can be actively controlled.

Integrating ImGui will require integrating GLFW 3.4 and GLAD for OpenGL3 bindings.

Added in #16


Tab being deleted when pressing backspace during label editing

Package name(s)
Lab (@salt-ds/lab)
Package version(s)
1.0.0-alpha.31
Description
When enableRenameTab is enabled, and onCloseTab is provided, and editing a tab, pressing backspace to edit the label deletes the tab.
In Tab.tsx, it should consider editing when pressing backspace/delete
Steps to reproduce
Example component:
import { Tab, Tabstrip } from "@salt-ds/lab";

const TabTest = () => {
  const [activePage, updateActivePage] = useState(0);
  const [pages, updatePages] = useState(pageList);

  const removePage = (pageIdx: number) => {
    const newConfig = [...pages];
    newConfig.splice(pageIdx, 1);
    updatePages(newConfig);
  };

  return (
      <Tabstrip
        enableAddTab
        enableRenameTab
        activeTabIndex={activePage}
        onActiveChange={updateActivePage}
        onCloseTab={removePage}
      >
        {pages.map((page, i) => (
          <Tab
            key={page.id}
            label={page.pageName}
            data-testid={`page-link-${i + 1}`}
            closeable={i !== 0}
          />
        ))}
      </Tabstrip>
  );
};

Expected behavior
Tab doesn't close/delete when pressing backspace
Operating system

[ ] macOS
[X] Windows
[ ] Linux
[ ] iOS
[ ] Android

Browser

[X] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

Are you a JPMorgan Chase & Co. employee?

[X] I am an employee of JPMorgan Chase & Co.

@stevenmckinnon, If you know the fix already, feel free to file a PR to change.

I'm not able to push a branch (403 error), does it need to be from an internal JPM github account?

@origami-z I'm not able to push a branch (403 error), does it need to be from an internal JPM github account?

Contribution will come through a fork from your account.


[UI] Update Application origin git provider strings to match new values

See https://github.com/epinio/epinio/pull/2298 (specifically https://github.com/epinio/epinio/pull/2298/files#diff-1ce4bd480f02d0d89d05c5733bbdadacc601e586fe8593e4e70ea34e56a9b469R39)
We should do this once https://github.com/rancher/dashboard/pull/8797 has merged and we can update our instance

@torchiaf or @richard-cox , mind pls write a few lines on what is the expected behavior / how to test this one?
Pushing an app with the new  --git-provider flag as in here and then checking everything is ok in UI?
If so, would I understand that at the moment only git, github, gitlab should work at the moment?

This one falls under the test everything flag.
It will affect creating applications, editing app source, download app manifest, supply manifest in create/edit app screens, etc.
This PR shouldn't affect the other source types (folder, archive), they should still work as normal.

ok, being that case not an issue.
Checked that uploads of apps with different source types (archive, folders, giturl, GitHub, and GitLab) as well as manifest, etc, and works. We noticed some sluggishness in the UI like when selecting combos from Gitlab but that does not seem related to this since the functionality is ok.


fix: double undo in context menu #152

Fixes #152
Describe the changes you have made in this PR -
Fixed the double undo bug in the context menu. Now only the undo operation is performed only once instead of twice when we click the undo in the Context Menu.
Screenshots of the changes (If any) -
https://user-images.githubusercontent.com/86093112/228747808-a793d146-cf3f-487b-ae14-424cc4afd916.mp4
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@tachyons @devartstar @vedant-jain03 can anyone please review my PR?


Installation problem (Lazy loading failed for 'package' voxhunt)

Hi,
Having bit of a problem installing voxhunt (Rstudio v1.2.5033, OsX). Here is the error below. Solution offered in issue #1 (reinstalling 'hhoeflin/hdf5r') did not help in this case. Would appreciate any help!

devtools::install_github('immunogenomics/presto')
Skipping install of 'presto' from a github remote, the SHA1 (7f63f960) has not changed since last install.
Use force = TRUE to force installation
devtools::install_github('quadbiolab/voxhunt')
Downloading GitHub repo quadbiolab/voxhunt@master
✓  checking for file ‘/private/var/folders/5n/wwyb571x5mz5ktkl0qyt4lwc0000gn/T/Rtmp8zNpfK/remotesd5684a9cd2d6/quadbiolab-VoxHunt-be3ee72/DESCRIPTION’ ...
─  preparing ‘voxhunt’:
✓  checking DESCRIPTION meta-information ...
─  checking for LF line-endings in source and make files and shell scripts
─  checking for empty or unneeded directories
─  looking to see if a ‘data/datalist’ file should be added
─  building ‘voxhunt_0.6.0.tar.gz’ (5.1s)

installing source package ‘voxhunt’ ...
** using staged installation
** R
** data
*** moving datasets to lazyload DB
** byte-compile and prepare package for lazy loading
Error: (converted from warning) package ‘tibble’ was built under R version 3.6.2
Execution halted
ERROR: lazy loading failed for package ‘voxhunt’
removing ‘/Library/Frameworks/R.framework/Versions/3.6/Resources/library/voxhunt’
Error: Failed to install 'voxhunt' from GitHub:
(converted from warning) installation of package ‘/var/folders/5n/wwyb571x5mz5ktkl0qyt4lwc0000gn/T//Rtmp8zNpfK/filed5687dd605de/voxhunt_0.6.0.tar.gz’ had non-zero exit status

Hi fkrbry,
thanks for reporting the problem. It seems like your issue is related to your tibble installation and/or you version of R. If your R version is not the most recent, maybe try updating it and reinstalling tibble. If that does not help, please provide me with the output of sessionInfo().
Best,
Jonas

Reinstalling tibble didn't help unfortunately, still getting the same error. Here is the session info:

sessionInfo()
R version 3.6.1 (2019-07-05)
Platform: x86_64-apple-darwin15.6.0 (64-bit)
Running under: macOS Mojave 10.14.6

Matrix products: default
BLAS:   /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
LAPACK: /Library/Frameworks/R.framework/Versions/3.6/Resources/lib/libRlapack.dylib
locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8
attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base
loaded via a namespace (and not attached):
[1] rstudioapi_0.11   magrittr_1.5      usethis_1.6.0     devtools_2.3.0    pkgload_1.0.2     R6_2.4.1
[7] rlang_0.4.5       fansi_0.4.1       tools_3.6.1       pkgbuild_1.0.6    sessioninfo_1.1.1 cli_2.0.2
[13] withr_2.1.2       ellipsis_0.3.0    remotes_2.1.1     assertthat_0.2.1  digest_0.6.25     rprojroot_1.3-2
[19] crayon_1.3.4      processx_3.4.2    callr_3.4.3       fs_1.4.1          ps_1.3.2          curl_4.3
[25] testthat_2.3.2    memoise_1.1.0     glue_1.4.0        compiler_3.6.1    desc_1.2.0        backports_1.1.6
[31] prettyunits_1.1.1

Thanks for the info. It seems like there is a mismatch between your R version (3.6.1) and the one tibble was build under (3.6.2). Installing a more recent version of R such as 3.6.3 might resolve the issue.

that did it, thank you!


Frozendict to immutabledict

fixes deprecation for frozendict, an abandoned project forked to immutabledict

broken, branched from a branch instead of master


clingraph is super slow on some graphs

Here is an example (example.zip) for an animated graph that has about 200 nodes and 50 time steps. Producing the facts takes about 5 seconds (due to a somewhat inefficient encoding) but producing the dot file takes half an hour.
➜ cat viz.json | time clingraph --prefix=viz_ --viz-encoding ./viz.lp --out=facts > /dev/null
4.96s user 0.09s system 99% cpu 5.047 total
➜ cat viz.json | time clingraph --prefix=viz_ --viz-encoding ./viz.lp --out=dot > /dev/null
1950.94s user 0.26s system 99% cpu 32:31.36 total

Maybe this is also linked to #79. Please help. It would be some much more fun to have a faster clingraph.

The patched version is definetly faster on my system.
clingraph --prefix=viz_ --viz-encoding ./viz.lp --out=dot >  177,40s user 0,26s system 99% cpu 2:57,83 total

The patched version is definetly faster on my system.
clingraph --prefix=viz_ --viz-encoding ./viz.lp --out=dot >  177,40s user 0,26s system 99% cpu 2:57,83 total

Still not exactly fast but at least in the realm of usable. Given the amount of data involved it should be possible to compute this within seconds. Something inefficient is happening somewhere...

One can speed this up drastically using the FactBase with an index:
➜ cat viz.json | time clingraph --prefix=viz_ --viz-encoding ./viz.lp --out=dot > /dev/null
18.50s user 0.08s system 94% cpu 19.623 total

For this, the FactBase in orm.py has to be created with
self.fb = ClormFactBase(indexes=[Attr.element_id])

See also https://clorm.readthedocs.io/en/docs/clorm/factbase.html#factbases-with-indexes.


Cleanup wc

This is actually a bug fix and a cleanup. I can break it into two PRs if you want. wc could still use some functional style love but this helps a little.

No need to make multiple PRs for such a minor thing.


Adds src and srcset to media entity

fixes https://github.com/frontity/wp-org-connection/issues/27, fixes https://github.com/frontity/wp-org-connection/issues/26

:tada: This PR is included in version 0.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Move add/edit user needs page to the GOV.UK Design System

Trello ticket link
What
This PR moves the add/edit user needs page over to the GOV.UK Design System.
Why
This is part of a Whitehall transition work to move from bootstrap to GOV.UK Design System.
Screenshots
Before

After

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

Hi @jyoung-gds, I notice there's a slight difference with the design on the edit page (which has checkboxes) but if that's gone through the design review I guess that's fine. Also using the autocomplete component makes more sense here than the design, which doesn't really make sense at all to me.
I made one small comment about those elements at the top of the page (back link etc.) but looks good to me otherwise.

@DilwoarH @davidtrussler thanks for the reviews. I've just pushed up some changes which I think address both of your requested changes. @davidtrussler the design in Figma is slightly different to the Trello card and looks like it uses the autocomplete, I think the screenshot in the Trello card was just outdated.

Quick question: were there any additional analytics other than page view ?


Seeds in examples and tutorials

Hello!
I was trying to use the toolkit for the first time, but I am not able to reproduce the results presented in the documentation. Is there any way you could provide the various seeds you used to obtain those outputs?
Thank you!
Luca

Seeds have now been added with https://github.com/GAMES-UChile/mogptk/commit/60aea73510361cb7d2651924e80c4dcbbd6b8a96, let me know if you're still unable to reproduce results


Witness should provide the evidence of value.type =:= T

Suppose we are creating a XML processing library, we want to ensure all the methods in a XML document only applies to elements that belong to the document.
We can define the document type like this:
trait Element[Owner <: Document with Singleton]

trait Document {
    def createElement(): Element[this.type]
    def appendChild(element: Element[this.type]): Unit
}

However, this approach is problematic when we summon the document for an element:
import shapeless._

def appendToDocument[Owner <: Document with Singleton](
    element: Element[Owner])(
    implicit witnessOwner: Witness.Aux[Owner]) = {
  witnessOwner.value.appendChild(element)
}

cmd2.sc:11: type mismatch;
 found   : Helper.this.Element[Owner]
 required: Helper.this.Element[shapeless.Witness.<refinement>.type]
Note: Owner >: shapeless.Witness.<refinement>.type, but trait Element is invariant in type Owner.
You may wish to define Owner as -Owner instead. (SLS 4.5)
    witnessOwner.value.appendChild(element)
                                   ^

The problem is that Scala compiler does not know Element[witnessOwner.value.type] and Element[Owner] are the same type.
This problem can be resolved if we add a value.type =:= T evidence in Witness, along with the ability of substitution in Scala 2.13.

Or we can define Witness as following:
trait Witness {
    type T = value.type
    val value: Any
}
object Witness {
    type Aux[T0] = Witness {
        type T = T0
        val value: T
    }
}

Then the evidence can be created as following:
def ev(w: Witness): w.value.type =:= w.T = {
    implicitly
}

@Atry have you tried that alternative definition of Witness?

As an aside, a more idiomatic approach to the motivating problem would be something along the lines of,
trait Document {
  trait Element
  def createElement(): Element
  def appendChild(element: Element): Unit
}

ie. use path dependent types to encode family polymorphism.

@milessabin At least the approach works for Dotty 😄
https://scastie.scala-lang.org/Atry/H5ltvYE9T9iD8IwRSdDESg
object Main {
  def main(arguments: Array[String]) = {}

  trait Witness {
      type T = value.type
      val value: Any
  }
  object Witness {
      type Lt[+T0] = Witness {
          val value: T0
      }
      type Aux[T0] = Witness.Lt[T0] {
          type T = T0
      }
  }

  trait Element[Owner <: Document with Singleton]

  trait Document {
      def createElement(): Element[this.type]
      def appendChild(element: Element[this.type]): Unit
  }

  def proveSameOwner(w: Witness.Lt[Document with Singleton]) = {
      implicitly[Element[w.T] =:= Element[w.value.type]]
  }

  def appendToDocument[Owner <: Document with Singleton](
      element: Element[Owner])(
      implicit witnessOwner: Witness.Aux[Owner]) = {
    val ev = proveSameOwner(witnessOwner)
    witnessOwner.value.appendChild(ev(element))
  }
}

Could you try modifying the shapeless definition as you suggest and see what (if anything) breaks?

The new Witness encoding need some workaround for Scala 2:
https://scalafiddle.io/sf/c6YMHlX/0
trait Witness {
  type T = value.type
  val value: AnyRef
}

object Witness {
  type Aux[T0] = Witness {
    type T = T0
  	val value: T0
  }
}

trait Element[+Owner]

trait Document {
    def createElement(): Element[this.type]
    def appendChild(element: Element[this.type]): Unit
}

trait Prover {
  val w: {
    type T
    val value: AnyRef
  }
  def proveSameOwner: Element[w.T] =:= Element[w.value.type]
}

trait WitnessProver extends Prover {
  val w: Witness
  def proveSameOwner = implicitly[Element[w.T] =:= Element[w.value.type]]
}

def appendToDocument[Owner <: Document with Singleton](
    element: Element[Owner])(
    implicit w0: Witness.Aux[Owner]) = {
  val prover: Prover { val w: Witness.Aux[Owner] } = new WitnessProver { val w = w0 }
  import prover._

  w.value.appendChild(prover.proveSameOwner(element))
}

The current Witness.Aux[Succ[P]] does not make sense, As Succ[P] is not a singleton, it should be Witness.Lt[Succ[P]]


Should work with german umlauts

In my resulting console or json file output all umlauts like öäüß are destroyed.
The site is encoded with charset=iso-8859-1

This seems to be a problem with node.js as it does not support that charset by default.

A nice solution to this problem was provided by falkenlabs here: https://github.com/lapwinglabs/x-ray/issues/9#issuecomment-140108470


Auto-update Support

Add infrastructure to allow for auto-update.

Respond to their data request.


Replace uniqid dependency with own module

uniqid tries to require node-specific modules to allow better random
strings in environments that allow access to hardware information.
These includes require additional mocking/configuration for consumers of
react-gears without any benefit, because react-gears runs on the client.

Mind converting to something like this https://github.com/appfolio/react-gears/blob/74882a4339c68580694835481a837f400c3877e2/src/components/TruncatedText/TruncatedText.tsx#L16. This is found more throughout the code, so I'd rather it just follow current patterns for now.

Changed to a simple counter as requested


foobar2000: partial revert of recent "improvements"

tl; dr; It's not enough to persist configuration, index-data and library
folders. This persistence creates more problems than it solves.
foobar2000 config shouldn't be persisted that way. Entire config folder should
be included in persisted folders, because plugins use that folder to store
their files as well.
But this isn't possible, because "portable mode" for foobar2000 means moving
$APPDATA/Roaming/foobar2000/* to location where foobar2000 installed, and this
in return means you can't persist contents of every folder because you
don't know beforehand what to persist.

I don't know much about plugins. Maybe a foobar200-portable is a good idea. But please extract file to avoid privilege instead of run installer.

But please extract file to avoid privilege instead of run installer.

I have reverted changes. It is now, how it was before. It worked before without privileges.
Installer writes to registry, I can't remove this step. What it writes -- I don't really know, it's not open source and can be easily changed in next version. I don't want to maintain those changes.

Perhaps it should be moved to nonportable bucket.

It worked before without privileges.

Oh, yes, you are right, it doesn't need privilege.

Installer writes to registry, I can't remove this step. What it writes -- I don't really know, it's not open source and can easily change in next version. I don't want to maintain those changes.

I don't think you need to worry about that... It's how scoop works.

@linsui Actually found a way to install without running installer.

@r15ch13 Can we merge it?

This change will break updates for people that have foobar installed right now. Please add notes or a script to transition to the new portable version.


MSID: 101080 Version: 1 DOI: 10.1101/2<IP_ADDRESS>2185

MSID: 101080
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>2185
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=101080
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>2185

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/101080v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>2185
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/101080/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

remove author notes, not needed
correcting typo in eLife assessment, valuable
https://sciety.org/evaluations/hypothesis:cAzUion-Ee-Qkm86P4_fOg/content


[NEW ICON] Skill Name

Skill Name
handlebarjs  for template
Why?
https://handlebarsjs.com/
handlebarjs
Reference Image
handlebarjs


Save Button??

where is the save button when i change a file with FFexplorer? I can see only close buttons to close the pop up window from explorer.

where is the save button when i change a file with FFexplorer? I can see only close buttons to close the pop up window from explorer.

Hi,
TO SAVE FILE: hit Ctrl + S (or Cmd + S on Mac)


Automatically add embedded app during app creation

add new property to EmbeddedApp (list of app_type integers) to know which embedded apps to automatically add

implemented on master


Support alternative normalization methods

@MuhammedHasan  Please fix the conflicts and docstrings, looks good otherwise.

@MuhammedHasan please update the docstrings for affected functions; then, we can merge this :)

@avantikalal I think we can merge this branch now with docstrings.


Test Coverage

It is explicitly explained in the book that test coverage will be kept to a minimum. For the purposes of demonstration, what are the creators thoughts on adding more test coverage with Jest as the book goes on? I would be very happy to look in to this, although it is a much more significant project.
By 8-end, there could be tests for all the major features of the app. It would also help with future package upgrades; as I have been testing Next.js v7, manually deleting mongoDB documents each time gets quite old... ;)

Here is a good example of how to use in-memory MongoDB with jest
I wrote my version of slugify.test.js which test whole User model, not only 'slugify' methods
and it works as expected with in-memory mongo testing environment refrenced above.

The facility for tests like YuriGor mentions seems very cool, I have to admit.

@whitefire0 @YuriGor Thank you both again for suggestions. So you guys probably talk about book and some app in general?

For book apps, I think we would keep tests to minimum. But we should add a blurb with examples and links about testing MongoDB operations as well. Thanks @YuriGor Let me think about blurb and simple example. I will close issue when I make change to the book's content.

Some app in general. This is my personal opinion and it's not popular. In many cases manual testing trumps a bunch of automated tests. This is especially true when you build entire app by yourself. When you add or modify code, you have pretty good idea about what's affected by change and what requires testing as a result of this change.

Practically I have to agree:

At initial phase of app development changes happen often and usually has a big impact, so creating and updating tests costs a lot of time.
At initial phase of development there are usually no users, except testers/developers/employer, so if something will go wrong, it will not be a tragedy.
Unit tests has limited application in UI oriented software like builderbook. E2E tests with selenium for example will make more sense, but again, not at initial phase, when design is subject of frequent changes.

From other side, when initial phase will be done and project will go to real production, who and how will write all that tests?
This task, writing tests for ready to use big app, becomes nearly impossible.
But without tests, any changes in the app, even bugfixes, become dangerous and expensive.
From third side, it's a big question, will this project finish at production stage or investors will get tired or money will be spent much earlier.
Anyway employers often want us to be able write that damn tests, so if not 100% coverage, but atleast some more realistic exercises will by useful for readers imho.

These are interesting thoughts, and ones that make a lot of sense. I was introduced to the test-first approach primary in a book called Build Your Own Angular which, by the end, implements well over 900 tests, but it is very complex code indeed.
As I read this, I also felt that some examples - perhaps with partially guided challenges to the readers - might still be useful, as the book aims to demonstrate app development as a whole. As it stands, testing is barely touched upon and whilst this reflects the views of the authors it may or may not reflect the views of the employers/teams that the readers may go on to work in. I know it would be to me, as I still have a to learn about the ways in which applications can be tested and at what stages these tests are best implemented.
Perhaps the book could even have a subsection before Jest is introduced that outlines some of the advantages/disadvantages of testing outlined by @tima101 and @YuriGor. Writing in English is one of my strengths and I would be happy to draft some markup if this is something you would be interested in considering.

@whitefire0 Thanks for the offer. I think it would be too much work for you. I will add a snippet that tests a few DB operations.
Thanks for sharing opinion. Yes, we aim to introduce reader to many topics but book is constrained by size.


Automated cherry pick of #4374

Cherry pick of #4374 on release-5.18.

#4374: Excludes negative filters from the search

/cc  @mgdelacroix

Will try to auto merge this PR

Pull Request successfully merged
SHA: 2672d5c86d1763ee148c9a43927aa30e55408e4e


Which version for protoc?

I encounter the problem "avod/protos/kitti_utils.proto:24:5: Expected "required", "optional", or "repeated" when I execute "sh avod/protos/run_protoc.sh". I'm not familiar with protoc. Is there something wrong with the version of my protoc? (version is 2.5.0)

I have solved it by replacing the version of protoc with protoc 3.5


stock cooldown

Coverage remained the same at 100.0% when pulling 8644e658f4b8f510b8b50b9e10b8621a2be456a6 on stock-cooldown into f900024df7d55de5c231f337836f3d9f7f1ec189 on master.


controller/up: properly handle nested ignore files

Previously, we'd only consider top level ignore files (.gitignore,
.railwayignore), which led to some problems when doing railway up
in a monorepo environment.
For example,
mg@mbp operand % railway up
🚄 Laying tracks in the clouds... open web/node_modules/core-js-pure/actual/typed-array/reverse.js: too many open files

To fix this, we do a pre-scan to find all the relevant ignore
files in the project first, then apply them as necessary.
Some additional cleanup / fixes as well (e.g., closing files, etc).

99% sure this shouldn't break anything, but does change behaviour of node_modules and .git slightly.
Prev:
rwIgnore, err := gitignore.CompileIgnoreFile(".railwayignore")

	if err != nil {
		rwIgnore, err = gitignore.CompileIgnoreLines(".git/", "node_modules/")
		if err != nil {
			return err
		}
	}

e.g., would only ignore these files (at the top level) if .railwayignore file not present.


sqlcoder-7b.Q5_K_M.gguf is missing

hii , Yonitjio
kindly , can you provide a source for sqlcoder-7b.Q5_K_M.gguf ?

hii , Yonitjio
kindly , can you provide a source for sqlcoder-7b.Q5_K_M.gguf ?

Hi, you can get it from  TheBloke at huggingface: https://huggingface.co/TheBloke/sqlcoder-7B-GGUF


An unexpected error has been raised. Looks like there's something wrong at our end.

Hi,
We had a few clients report a payment failure at checkout, where they saw the following notice displayed on the website:

An unexpected error has been raised.  Looks like there's something wrong at our end.

Can you please let me know what might have caused this?
Regards,
Alex

Hey @alexanderkladov, Apologies for the delay in this one. We are working on some translation issues around special characters and hope to have a solution out soon. It's likely that this is the cause of this issue.

Hey @alexanderkladov we have released a new version of the plugin. Please check if it solves your issue.
If your issue persists, could you please raise this through the bank's support team - we'll be able to track your request better. We are going to be closing the issues tab here as we can't track these questions & queries as well as through the regular support route.


bump version to v0.1.5

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
bump version to v0.1.5
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
The documentation has been modified accordingly, like docstring or example tutorials.

Codecov Report

Merging #83 (9865db9) into main (4f2b8ec) will not change coverage.
The diff coverage is 0.00%.

:exclamation: Current head 9865db9 differs from pull request most recent head eb167dd. Consider uploading reports for the commit eb167dd to get more accurate results

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   63.59%   63.59%
=======================================
  Files          21       21
  Lines        1593     1593
  Branches      358      358
=======================================
  Hits         1013     1013
  Misses        443      443
  Partials      137      137

Flag
Coverage Δ

unittests
63.59% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mim/version.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f2b8ec...eb167dd. Read the comment docs.


Fixing a bug after Jasmine update.

Fixing the Jasmine bug after an update that moved the 'it()' function to another place in their internal code.
Issue #
Angular tests were not being found.
Bug
Jasmine made some internal changes and moved some logic related to the 'it()' function that we use to describe and run the tests. Internally, NTVS needs to replace Jasmine's 'it()' function and after their changes on update, this replacement was failing.
Fix
We found out on their code that there's an 'it_()' that seems to be the old 'it()'. After making this change, our tests were being found again.
Testing
The Angular test are now being found, tested locally.

@joj @armanio123 I also made this change on TestAdapter.tests, it was needed for the project to build locally, but I was unsure if it was just on my machine or if I should push as well. Should I?

Build works locally and on CI, so we're ok :)


[ListItem]  require to forwardRef

Prior to upgrading to the 5.x alpha, the following code from the docs worked:
const link = (p: unknown) => <Link to={route} {...p} />;
<ListItem button key={route} component={link}>

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

I also looked at the release notes and the specs provided in the source code, but can't seem to find anything.
Current Behavior 😯
Throws a runtime error:
Warning: Failed prop type: Invalid prop `component` supplied to `ForwardRef(ButtonBase)`. Expected an element type that can hold a ref. Did you accidentally provide a plain function component instead?

And:
Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

The component does render correctly, though.
Expected Behavior 🤔
No runtime errors ;)
Your Environment 🌎

Tech
Version

Material-UI
v5.0.0-alpha16

React
17.0.0

Browser
Chrome

TypeScript
Yes (4x)

etc.

Why is the new warning wrong?

@oliviertassinari if this is an intended behavior, I am looking for documentation on the migration solution. As I said in the OP, I have examined the release notes and the specs (in the source code) and do not see an obvious migration path.

FWIW, I've also tried using const link = React.ForwardRef<>() syntax, but the resulting object was not accepted by the ListItem's component validation.

FWIW, I've also tried using const link = React.ForwardRef<>() syntax, but the resulting object was not accepted by the ListItem's component validation.

Could you share that particular code? It should work.

Sure thing. I relied on the IDE to complete the HTMLAnchorElement bits, so perhaps there's an alternate way to declare the link I'm not aware of.
function renderItem(route: string, text: string, icon: React.ReactNode, t2?: string) {
    const link = React.forwardRef<HTMLAnchorElement, Props>((p: Props, ref) =>
      <Link to={route} {...p} ref={ref} />
    );
    return (
      <ListItem selected={isRouteActive(route)} button key={route} component={link}>
        <ListItemIcon>{icon}</ListItemIcon>
        <ListItemText primary={<Typography variant='h6'>{text}</Typography>} />
      </ListItem>
    );
  }

Exact error is:
No overload matches this call.
  The last overload gave the following error.
    Type '{ children: Element[]; selected: boolean; button: true; key: string; component: ForwardRefExoticComponent<OwnProps & RefAttributes<HTMLAnchorElement>>; }' is not assignable to type 'IntrinsicAttributes & { button: true; } & { alignItems?: "center" | "flex-start" | undefined; autoFocus?: boolean | undefined; children?: ReactNode; ... 7 more ...; selected?: boolean | undefined; } & Pick<...> & CommonProps & Pick<...>'.
      Property 'component' does not exist on type 'IntrinsicAttributes & { button: true; } & { alignItems?: "center" | "flex-start" | undefined; autoFocus?: boolean | undefined; children?: ReactNode; ... 7 more ...; selected?: boolean | undefined; } & Pick<...> & CommonProps & Pick<...>'.  TS2769

    61 |     );
    62 |     return (
  > 63 |       <ListItem selected={isRouteActive(route)} button key={route} component={link}>
       |                                                                    ^
    64 |         <ListItemIcon>{icon}</ListItemIcon>
    65 |         <ListItemText primary={<Typography variant='h6'>{text}</Typography>} secondary={s} />
    66 |       </ListItem>

Thanks. I'll take a look later what's wrong with the types. In the meantime, don't create components during render.

@eps1lon copying the code exactly from the example in the link, I first get:
'to' is specified more than once, so this usage will be overwritten.  TS2783

    21 |     () =>
    22 |       React.forwardRef<HTMLAnchorElement, Props>((linkProps, ref) => (
  > 23 |         <Link ref={ref} to={to} {...linkProps} />
       |                         ^
    24 |       )),
    25 |     [to],
    26 |   );

Removing the {...linkProps} so I can keep moving, I then get:
No overload matches this call.
  The last overload gave the following error.
    Type '{ children: Element[]; selected: boolean; button: true; component: ForwardRefExoticComponent<OwnProps & RefAttributes<HTMLAnchorElement>>; }' is not assignable to type 'IntrinsicAttributes & { button: true; } & { alignItems?: "center" | "flex-start" | undefined; autoFocus?: boolean | undefined; children?: ReactNode; ... 7 more ...; selected?: boolean | undefined; } & Pick<...> & CommonProps & Pick<...>'.
      Property 'component' does not exist on type 'IntrinsicAttributes & { button: true; } & { alignItems?: "center" | "flex-start" | undefined; autoFocus?: boolean | undefined; children?: ReactNode; ... 7 more ...; selected?: boolean | undefined; } & Pick<...> & CommonProps & Pick<...>'.  TS2769

    27 |
    28 |   return (
  > 29 |     <ListItem selected={selected} button component={CustomLink}>
       |                                          ^
    30 |       <ListItemIcon>{icon}</ListItemIcon>
    31 |       <ListItemText primary={<Typography variant='h6'>{title}</Typography>} secondary={s} />
    32 |     </ListItem>

@zaneclaes So If I summarize, 1. the forward ref warnings in your demo are expected. The button needs to access the ref. 2. we miss a reproduction that demonstrates there is an issue with TypeScript. I can't reproduce your error: https://codesandbox.io/s/listrouter-material-demo-forked-kodox?file=/demo.tsx.

the forward ref warnings in your demo are expected. The button needs to access the ref.

As I said to you last time, I did not claim otherwise. Why are you bringing this up again? Perhaps this is cultural, but you're coming off as quite rude in this conversation.

I can't reproduce your error:

Well, you changed the code. I explicitly said:

so perhaps there's an alternate way to declare the link I'm not aware of.

And, indeed, there is. The use of Omit<OwnProps, 'to'> fixes both problems.
Obviously, I know this is an alpha. But this would be a very good addition to the docs :)
To be clear, this syntax: React.forwardRef<HTMLAnchorElement, LinkProps> causes both errors:

Excluding the {...props}, like I did in my prior post, makes the first error go away:

But the use of Omit is required to fix the original issue:

@zaneclaes Great! Happy to hear the issue is resolved. It also doesn't seem there is any room for us to improve the documentation or the implementation.

Again, I did not claim otherwise.

The objective was to bring clarity. It seemed that the conversion switched from JavaScript error to TypeScript at some point. It would have probably been confusing for an external reader.

It also doesn't seem there is any room for us to improve the documentation

I searched the docs for Omit, and it is never referenced. I strongly feel that there should be a working Typescript example in the docs. I would have never figured this out on my own. The second error (pasted above) is far too obscure to debug, and did not obviously point at a solution.

@zaneclaes Did you find this demo? https://next.material-ui.com/guides/composition/#list, it matches your use case.

Huh, I stand corrected! I don't know how I missed that. Thanks for pointing it out. Here are the places I read during the course of this investigation:

The release notes (migration guide)
The specs in the source code
The link from above
The 5.0.0 "Typescript" docs
The search bar at the top of the "5.0.0" docs (searched for: "Omit")

I'm convinced you're right, though since this is a breaking change, I still think the migration path should be more obvious ;) Hopefully just before the public release, a list of all the breaking changes can be compiled to aid in migration.

@eps1lon Should we migrate the code snippets in https://next--material-ui.netlify.app/guides/composition/#caveat-with-inlining to TypeScript?

FWIW, I really like how so many of the examples have both JS and Typescript. It'd be great if that were universal, though again, I know this isn't a priority 🙂

@zaneclaes I would propose the following diff, in case you want to work on a pull request :)
diff --git a/docs/src/pages/guides/composition/composition.md b/docs/src/pages/guides/composition/composition.md
index 94d087025b..0c0aeebe07 100644
--- a/docs/src/pages/guides/composition/composition.md
+++ b/docs/src/pages/guides/composition/composition.md
@@ -85,15 +85,15 @@ function ListItemLink(props) {
 The solution is simple: **avoid inline functions and pass a static component to the `component` prop** instead.
 Let's change the `ListItemLink` component so `CustomLink` always reference the same component:

-```jsx
-import { Link } from 'react-router-dom';
+```tsx
+import { Link, LinkProps } from 'react-router-dom';

 function ListItemLink(props) {
   const { icon, primary, to } = props;

   const CustomLink = React.useMemo(
     () =>
-      React.forwardRef((linkProps, ref) => (
+      React.forwardRef<any, Omit<LinkProps, 'to'>>((linkProps, ref) => (
         <Link ref={ref} to={to} {...linkProps} />
       )),
     [to],

Hi @oliviertassinari
I have similar problem and my component is defined as follows:
return (
    <React.Fragment>
        ...
        ...
                {
                    routes.map((rt, index) => (
                        <ListItem
                            divider
                            key={index}
                            button
                            component={Link}
                            to={rt.path}
                            selected={index === currentRouteIndex}
                            onClick={handleOnClickItem(index)}
                        >
                            <ListItemText primary={rt.name}/>
                        </ListItem>
                    ))
                }
            </List>

        </SwipeableDrawer>
    </React.Fragment>
)

the routes is defined as:
const routes: RoutesTable = [
      {name: "HOME", path: "/"},
      {name: "HOW IT WORKS", path: "/howitworks"},
      {name: "ABOUT US", path: "/aboutus"}
  ]

My question is, how to solve it?
Thanks in advance

Hi @oliviertassinari
A question, why my question is marked as off-topic? Do I miss something?
Best regards

Can I take this if nobody is working on this?

I saw that this was stopped, so I dared to make the change. 🚀

I saw that this was stopped, so I dared to make the change. 🚀


Tracking daily tasks

Thanks a lot for checking my PR! Hope your week is going well, 1 or 2 more days to go!

Hi Wataru! Thanks always!


Implement clusterloader2 to run autoscale test

Implement ClusterLoader2 to run autoscale test

what is the difference btw failures and errors, should we include as part of results for debugging purpose?

If you're talking about docker error and test suite failure, they're the same. When the test suit has failure, docker process will exit with error code 1, so I have to handle it gracefully to not fail the pipeline. Test suite failure means either node is not ready or pod is not running in our autoscale case. I already logged everything to the terminal and include raw data in the result so I don't think there's more to logs.


link_bandwidth_test.go script update

Update link_bandwidth_test.go as per recent readme changes.

Removed deprecated sub test cases
Added workaround for match community

Pull Request Functional Test Report for #3248 / cca6c59be84aaba96a6c6e57db0515c25b6f8784
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Cisco 8000E

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Cisco XRd

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Juniper ncPTX

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Nokia SR Linux

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Openconfig Lemming

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Cisco 8808

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Juniper PTX10008

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Nokia 7250 IXR-10e

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls


Added integer to roman solution(C++)

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Added solution in math folder.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)

@HarshCasper please review


Messaging unlock

This code will allow you to message without having to constantly enter your password.
All of the commits before 5cb11fd are already in #60

closes #62


✅ Add test coverage for sidebar accordion

add to snapshot, add a few tests to cover functionality/behaviour

Resolved by #2867


Improvement for admin : A tool for admin to change a password of a user.

In admin/accounts/ we have list of account. If a user lost their password and ask the admin to change it. It would be nice for the admin to have an option : change the password.
Additionaly option for creation of a new user (Like friendica)
An option to send a message to one user or many users (Important information)

The first feature request is already working in the dev branch. Just visit /admin/accounts and select any of the accounts.
FYI, it's a good practice to create a seperate issue for each feature request.


Create Makefile.oadp for CI

Describe the problem/challenge you have

Describe the solution you'd like

Anything else you would like to add:

Environment:

Velero version (use velero version):
Kubernetes version (use kubectl version):
Kubernetes installer & version:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):

Vote on this issue!
This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

:+1: for "The project would be better with this feature added"
:-1: for "This feature will not enhance the project in a meaningful way"

oadp-1.0, oadp-1.1, and maybe main

we intend to run in prow
make -f Makefile.oadp ci

Resolved


Cannot find module '#components' or its corresponding type declarations.

Environment

Operating System: Linux
Node Version:     v16.14.2
Nuxt Version:     3.0.0-rc.8
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-mgw8bo?file=getComponent.ts
Describe the bug
After upgrading from rc-6 to rc-8, I get a type error, even though there is actually no error in the runtime
// Cannot find module '#components' or its corresponding type declarations.
import { HelloWorld } from '#components';

Additional context
No response
Logs
No response

Importing from '#build/components' results in Cannot find module '#build/components' or its corresponding type declarations too. @nuxt/types v2.16.3. @nuxt/typescript-build v3.0.1. nuxt v3.5.0

You should import from #components not #build/components.

Oh, apparently you need this in tsconfig.json for #components import to work:
{
  "compilerOptions": {
    "paths": {
      "#components": [
        ".nuxt/components"
      ]
    },

No, you don't. You should instead extend the generated Nuxt tsconfig, like this: https://github.com/nuxt/starter/blob/v3/tsconfig.json.
More info: https://nuxt.com/docs/guide/concepts/typescript#nuxttsconfigjson


Fix mouse confined and set_borderless_window

Fix #19033.

Fix a bug when mouse is confined don't update the cursor shape.
Don't let the mouse leave the window when resizing to a smaller resolution when MOUSE_MODE_CONFINED.
Fix set_borderless_window to preserve the actual video_mode.widht/height (client rect).

Now that Godot 3.1 has been released, we only plan to cherry-pick critical bug fixes to the 3.0 branch, unless there is very strong support in favor of a specific non-critical issue. Removing cherrypick label for 3.0.


Update JupyterHub helm chart version

The new version of the chart brings in a new culler that is better at
handling users that are slow to stop. See
https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/531

There's a bug in our build.py when building multiple images. It's reusing the last commit from the first image as the tag for subsequent images. This is fixed in the new standalone chartpress, which is picked up in https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/533 . If we merge that PR, then the next build of the jupyterhub chart should have the right images.


Integrate with IntelliJ

I am using eslint-graphql plugin inside another NodeJS module. Could you please let me know the steps to integrate it within IntelliJ? Will it be same as #359?

In my experience, it’s better to have toplevel eslint config even for monorepo

Could you please let me know the steps to integrate with IntelliJ?


Front: add comments on posts

On the post page, an authenticated user with a verified email address should be able to write a comment.
All visitors should be able to see approved comments.
An authenticated user should be able to delete their own comments.

Fixes by #32


Help: uncover on ios 12.1.2  Errno 17 unable to rename system snapshot

Hey guys
My phone is x   64gb
When i try to jailbreak wit uncover
It is freez on 2   And   End up with :
Error (Fatal)
Errno:17
Test:fs_snapshot,origfs, 0)==ERR_SUCCESS
Filename:jailbreakViewController.m
Line:1191
Function:jailbreak
Description:Unable to rename system snapshot.Delet OTA file from Setting -storage if present and reboot

I did every thing on your maind guys and it did not work .. i download the ios ubdate again and delet it  i run uncover with airplan mode   I  reset rootfs but it give me always sam error 17 and freez

Try factory restoring your device?
Then make sure the OTA isn't there. Then install the OTA, switch to airplane mode once it installs, then delete the OTA, and then try clicking 'Jailbreak' again.
I really don't know at this point :/

have you solve this problem? i have the exact problem on my iphone x 64gb too

i have not solve this problem i end up with yupdate my ios to 12.2 and now i am waiting for another jailbreak ☺

bruh

have you tried restoring it?

Why restoring it ..i update  my iphone so now i can not downgrade it again ...but before that i tryed every thing  you can imaging and still same problem

There is no fixing this so  finaly you have to update your phone and no jailbreak for us

Hey still need help?


CI improvements

CI is in a "better" state now and everything is moved to GHA self hosted runners. However some things remain:

the release build matrix should only build for those runs which passed the test suite which requires keeping some state between jobs
we only have 1 box each so there will be some contention for the next stretch on CI
we don't have any mechanic to "not run CI" on certain commits
windows is still on the GH runners and slow
I'm not a 100% convinced the right rust versions are being picked up

Windows builds handled in https://github.com/n0-computer/iroh/pull/521

We added all the boxes, introduced code coverage, extended checks, confirmed rust versions.


Update README: Move Neo4J Storage Section for Better Visibility

The Using Neo4J for Storage section was originally nested inside the Ollama details block, making it less visible to users looking for KG storage options.
Moved this section to appear just before Insert Custom KG, grouping it with other Knowledge Graph-related content.
This change improves visibility and helps users discover Neo4J configuration details more easily.

Should we update the LightRAG init parameters table with a consistent parameter name for KG storage?

kg: parameter name used in neo4j code examples
graph_storage:  parameter name shown in the table

Yes, the parameter name has already been unified in the source code, but the demo was mistakenly not updated. I will fix it ASAP.


connect ETIMEDOUT error is not caught in error event listener

Describe the bug
Whenever connect ETIMEDOUT is thrown out of SteamUser client, it is not caught in error event listener. It is causing server to shut down. I am using httpProxy and whenever 1 proxy is faulty it breaks whole server.
    this.steamUser = new SteamUser({
      httpProxy,
      promptSteamGuardCode: false,
    });

Expected solution: connect ETIMEDOUT can be caught on 'error' listener.
    this.steamUser.on('error', (error: any) => {
      return this.emit('error', { code: 'LOGIN', error });
    });

Versions
4.24.3
Screenshots and Error Logs

@DoctorMcKay here are more details about error that is causing uncaughtException
"Error: connect ETIMEDOUT $IP_ADDR
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1595:16)"

address: "$IP_ADDR"
code: "ETIMEDOUT"
errno: -110
port: PORT
syscall: "connect"

@aligatorr89 you are using outdated lib version.
It may be fixed in 5.1.0. Try to update.

@aligatorr89 you are using outdated lib version.
It may be fixed in 5.1.0. Try to update.

@Sadzurami I will try it and close this bug report asap!

connect ETIMEDOUT

Since version update to 5.1.0 there are no more uncaught errors. Tyvm!


Xerox Driver custom processor requires update

Xerox has changed the format of its website such that the XeroxPrintDriverProcessor.py processor now returns "Error: Unable to build a download url based on the parameters provided."

@jazzace Thanks for the FYI on this.  👍
Should be resolved.


Embedding Navigation View

after building route with _controller.buildRoute(wayPoints: wayPoints);
when i calling  _controller.startNavigation();
this is the problem iam  facing
I/nav-native(14514): Waypoints were not passed to setRoute. Trying to restore it from route itself.
W/nav-native(14514): Cannot find via_waypoints in passed route. On-board waypoints matching will be used.

This issue is resolved


remove global variable

Please, change semicolon to comma at the end of the line 22. When I wrote it, I didn't notice, that there is another variable two lines below.

Nope, take a look, the htmlstripre variable is defined on 22, then assigned on 24.

Nope, take a look, the htmlstripre variable is defined on 22, then assigned on 24.

Oh, my mistake. I used to define and set variables at the same time, if it's possible, and probably I followed my rules without taking closer look.


Fix changelog

Follow-up to cd72fe4c70e41f7a66af20041cc918bc4448d18f
Checklist

[x] Markdown preview looks good
[x] RTD preview looks good
[x] Checks pass

Ah, geez, sorry about making extra work! In the future, please feel free to tell me to fix my own mess!

No worries this was a small and quick fix! Will do in the future though.


Re-add RangeSet/DiscontiguousSlice to the standard library

This reverts commit c35b567001f2055acdf09a627e58629065c91931.

@swift-ci Please smoke test

Closing this for now.


Response card improvements

MOB-1566
Jira issue:
https://glia.atlassian.net/browse/MOB-1566
Additional info:
Response cards' behavior on mobile will be unified with the behavior on the web as follows:

Upon clicking on the card, the card disappears and is replaced with the visitor's response as a text
Response cards are not shown in the chat history

I also fixed the issue - when the chat history's last item is the response card, input is not disabled and improved isNewMessage(newMessage: ChatMessage) method.

!merge


Upstream yum issue

yum-chef recently did a big update change and this is effecting how this works. This dependency is coming from chef-ingredient. May need to lock that dependency in place until it can be addressed or a version can be bumped.

@rossedman What's the issue you're running into with yum-chef?

5.0 depends on the latest chef-ingredient now, which should resolve any issue you might have been seeing in the 4.X releases.


Handling large payloads

Supports s3-url event from feeder.
Handle large payloads returned from post-batch and publish lambdas

I hate the name of get_payload(), it seems misleading and inaccurate. But whatever, let's ignore that for now.
So first thing, see #157. process has been completely refactored and supports payloads with URLs now. So I'd remove the changes to process here.
For the other tasks, we are likely moving to stac-task class-based tasks for these. The timeline on that change is uncertain, however, so I'm okay with these changes as an intermediate solution. Hence why I am ignore the name of get_payload(), because I am hoping its use will be short-lived. This said, I am not sure how we are solving this in stac-task, as this is something AWS-specific. @matthewhanson?
More generally, I'm still not sure what the best solution here is long-term. This whole message length limitation is a total pain and AWS should solve it for us, but obviously we can't rely on that and we need to do something...
I have some long-term ideas for cirrus that are coming out of a discussion with @matthewhanson about this new concept of a "stac-workflow" (which is made up of...stac-tasks, obviously). If that pans out, we'd have enough abstraction in the cirrus workflow (yes, I mean "the", not "a", as I envision a single dynamic workflow that can process anything) that I think switching to S3 for everything all the time might make the most sense. But the actual mechanics there are quite hand-wavy, so I don't want to commit to that trajectory.
tl;dr: I'm good with these changes if we pull out the process ones as an interim solution while we figure out what we really want to do.


Use $(MAKE) variable for recursive invocations

This ensures that docs Makefile is processed using the same binary as main one. See https://www.gnu.org/software/make/manual/html_node/Recursion.html#Recursion

Good catch!
Thanks for the PR submission, and I much appreciate that you included a documentation reference about the idiom and alternate construction via the flag/option.
Is there a reason you chose $(MAKE) -C subdir ... over cd subdir && $(MAKE) ...?
I think the second version might be more clear to future readers.
If there's some reason that the first version is better, than I'd at least like to use the long version of the option, eg $(MAKE) --directory=subdir ..., for easier future interpretation of function. And, since you are touching the lines, I'd also defensively use quotes around the subdirectory, eg "$(DOCSTR)".

Is there a reason you chose $(MAKE) -C subdir ... over cd subdir && $(MAKE) ...?

I assumed it is faster since make does everything internally, but that is really a premature optimization so if you like it more the way it was I'll revert it. Regardless, you are right, --directory is less cryptic 👍

I'd also defensively use quotes around the subdirectory, eg "$(DOCSTR)", or even '$(DOCSTR)', if possible.

Shellcheck learned me the same (harder way) but I haven't seen it elsewhere and didn't want to introduce new stuff. I'll gladly bring us to the safe side though 😄

Taking this change now as it won't hurt and we can always follow PR for the other items.


Altinn-kaffe presentations October 2021

Sorry for the irrelevant commit history 😊

Sorry for the irrelevant commit history

@lvbachmann No problem, we squash merge, so the history is clean


⚠ Bofrost.lu has degraded performance

In dd123b3, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1120 ms

Resolved: Bofrost.lu performance has improved in 334bbd4.


update documentation generator

When working on https://github.com/finale-lua/lua-scripts/pull/151, I noticed that several library functions' documentation was out of date. Specifically, I noticed the arguments included in the call signature did not always match up with the arguments defined with the @ argName (type) description structure. For instance:
--[[
% copy(source_layer, destination_layer)

Duplicates the notes from the source layer to the destination. The source layer remains untouched.

@ region (FCMusicRegion) the region to be copied
@ source_layer number the number (1-4) of the layer to duplicate
@ destination_layer number the number (1-4) of the layer to be copied to
]]

Now it's understandable why this discrepancy happens—the args are defined in two places, but a developer things their job is done after updating the args in one spot.
To fix this, I updated the documentation generator. Check out the release notes:
https://github.com/finale-lua/lua-docs-generator/releases/tag/1.1.0
Essentially, this PR will now let you write this:
--[[
% copy
]]

And all args will be automatically added to the call signature for you. This should help us keep the docs more up to date.

Oh, and I rewrote the entire docs generator from scratch to support this. And one consequence of that rewrite is that it's a lot more forgiving to developers. So the syntax does not need to be as perfect and it will still understand everything. Though this part is minor enough that we may not see its effects at all in this codebase.

This seems like quite a good idea. There is one of the functions in the mixin library that is misnamed in the comments, leading to the docs showing two identical functions. I have been meaning to fix this but was waiting for that code to settle down.


Fix full week span event being truncated on last day of the week.

This should fix issue #36 (the week view issue).
Note:  I'm not sure of the potential collateral this fix could bring up. I manually tested that it works for my use cases (month and week views) so there may not be any. Should we start adding functional tests?
Second Note: I needed to update some unrelated code because the npm test command was failing. There was a lint error.

Hi, thanks for the PR. I am a bit afraid to just remove the startOf logic on the util method as that may have far reachin effects and should actually be the issue here. I haven't checked but I think the problem is that I missed a spot when normalizing how ranges are calculated in: https://github.com/intljusticemission/react-big-calendar/commit/a2a49c88a404ca97ea95274bde7249546badc016 I would think that a fix along those lines may be better

Hi,
Thanks for the quick feedback on this pull request :)
For my understanding of the issue, this is the diff function which is faulty. When I debugged my use case, the input parameters sent to the function were correct.
dateA was sunday at 00:00 and dateB was saturday at 23:59:59.
As it was, the function computation was returning 6 days span for these two dates. This is because of the startOf applied to dateB. This effectively removed 23 hour and 59 minutes from the full span. From my understanding, that is the source of the issue causing the function returning 6 instead of the expected 7 days span.
I would understand keeping the startOf on the dateA but I'm not sure about dateB. Maybe endOf could be applied to dateB? In the end, offsetting both dates by either startOf or endof seems inappropriate for this API (IMHO).
Is there other post-process that is applied after this function that could do a +1 on the span?
Is applying startOf on dates make senses for other unit but day?
Thanks again!

glad to try and help, @okcompute if those are the dates the diff function is correct, ranges are exclusive so if you want a full week the it's Sunday to Sunday, and not Sunday to Saturday 23:59:59. Which is why I don't think the problem is in the diff method, but further up. since this is working for Month weeks, and the AllDay views essentially use the same code it probably a min/max that is not being passed correctly.

my guess is that start and end are wrong here: https://github.com/intljusticemission/react-big-calendar/blob/master/src/TimeGrid.jsx#L96

This is not I'm witnessing. Both dates are correct at that point.
This is where I started seeing 6 days span instead of 7 days span:
https://github.com/intljusticemission/react-big-calendar/blob/master/src/utils/eventLevels.js#L17
and why I started targeting the diff function.

Oh, I did not notice your first answer about the diff function. So indeed, if for the span to be 7 the datess need to be sunday to sunday, the function is correct. Ok, i'll do another debug pass to isolate where the end date is computed and set to saturday @ 23:59:59 (instead of sunday @ 00:00:00)

I thought you said above the start/end dates were Sunday to Saturday? if they are, those are incorrect.

Yes, sorry.  Whereever the problem is, you can see how Month uses endOfRange which is the place that adds 1 to the end to get the correct range.

I think the fix is now correct!

🎉

Hehe! Thanks a lot :smile:

No rush but I'm curious. When a new release is planned?

when I get a free moment!

Hehe. Cool.  no problem. I understand :smile:


Vote oxd

Codecov Report

Merging #220 (229d13b) into develop (7ea2654) will increase coverage by 0.88%.
The diff coverage is 58.46%.

@@             Coverage Diff             @@
##           develop     #220      +/-   ##
===========================================
+ Coverage    36.99%   37.88%   +0.88%
===========================================
  Files           19       19
  Lines         1411     1465      +54
===========================================
+ Hits           522      555      +33
- Misses         889      910      +21

Impacted Files
Coverage Δ

src/earner.py
0.00% <0.00%> (ø)

config/constants.py
100.00% <100.00%> (ø)

src/tx_utils.py
61.53% <100.00%> (+24.03%)
:arrow_up:

src/utils.py
97.14% <100.00%> (+0.08%)
:arrow_up:

src/web3_utils.py
59.55% <100.00%> (ø)


Possibility to hide the arguments which had already assigned default value in autocomplete line

Description
As a user, I want to hide those arguments that had already assigned default value if possible so that the autocomplete won't print out lots of arguments that I don't really need to assign in normal scenario.
Example:

Thanks for your hard work to make robot test better and better :)

Hmm yeah I think this is something that could be configurable


Lack of Support for Brother DCP-T520W Printer

Subject: Lack of Support for Brother DCP-T520W Printer
Dear pakage Owners,
I would like to inform you that our application is encountering issues with supporting the Brother DCP-T520W printer model. Current applications attempt to utilize printer libraries that support specific printer models, but our model does not align with them completely.
We urgently need to address support for this widely used printer model. Please provide technical support or guidance on how to resolve this issue at your earliest convenience.
Thank you very much for your understanding and cooperation.
Best regards,
Osama Ayesh
<EMAIL_ADDRESS>00970567450057

Hi @OsamaAyesh ,
Thanks for reaching out about this. Unfortunately the printer you mention does not seem to be currently supported by the Brother mobile SDK (refer here for supported models https://support.brother.com/g/s/es/dev/en/mobilesdk/model/index.html?c=eu_ot&lang=en&navi=offall&comple=on&redirect=on)
My recommendation is to submit an official request to Brother for the inclusion of that printer. Once a version version of the SDK is released we can go ahead and include the support in another_brother.
Thanks again,


scan + limit query hangs forever

Hi, thanks for the library!
I faced the following issue:
I do full scan. The query matches one entry in the table.
Then I add limit(2) restriction and it hangs forever.
case class Row(id: String, field: String)

object ScanBug extends App {
  val cl: DynamoDbAsyncClient = ???

  val zioCl = ScanamoZio(cl)
  val table = Table[Row]("table")

  //this query matches 1 entry
  val q = table.filter(("field" === "some-value")).limit(2).scan()
  val res = zio.Runtime.default.unsafeRunTask( zioCl.exec(q))
  println(res)
}

It is 100% reproducible in production, haven't yet reproduced it with local Dynamo.
If I remove limit, change limit(2) to limit(1000) or change scan() to scan0 - everything is OK.
I suspect that the problem has something to do with span response pagination:
table.filter(("field" === "some-value")).limit(2).scan0 successfully returns 0 results with a continuation token.

(This is the first day I'm working with DynamoDb, so might be talking stupid things)
I don't understand this logic:
https://github.com/scanamo/scanamo/blob/master/scanamo/src/main/scala/org/scanamo/DynamoResultStream.scala#L44
def stream[T: DynamoFormat](req: Req): ScanamoOps[(List[Either[DynamoReadError, T]], Option[DynamoObject])] = {
    def streamMore(req: Req): ScanamoOps[(List[Either[DynamoReadError, T]], Option[DynamoObject])] =
      for {
        res <- exec(req)
        results = items(res).map(ScanamoFree.read[T])
        newLimit = limit(req).map(_ - results.length)
        lastKey = lastEvaluatedKey(res).filterNot(_.isEmpty)
        result <-
          lastKey
            .filterNot(_ => newLimit.exists(_ <= 0))
            .foldLeft(

limit in AWS api corresponds to the number of source entries to scan rather than the number of target entries to return.
newLimit = limit(req).map(_ - results.length)  - this looks like an attempt to collect up to limit result entries.
Now I understand why my query 'hangs': if a table contains ~10k entries, it takes 5k queries to traverse it.
I tested it from outside of AWS network so it seemed like hanging.
This also explains why increasing limit helps and why I can't reproduce it with local Dynamo instance.

Oh wow, and that code has been there like forever, I can't believe it was not caught before.
Thanks a lot for reporting @simpadjo and also for investigating the source. It seems like an easy one to fix, @davidfurey is there someone at the guardian who would want to take this?

Great spot and investigation, thank you @simpadjo!  The code does note that this is the behaviour of the limit parameter:
Query or scan an index, limiting the number of items evaluated by Dynamo,
but perhaps this could be made clearer and/or added to the documentation as well. PRs are always welcome!
I've opened #996 to fix the bug you've discovered with the limit(req).map(_ - results.length) logic.

@regiskuckaertz @davidfurey Hey, yes, I generally try to fix issues the libraries that I use. Unfortunately, I had to switch from Scanamo at work.
Here are the issues I faced when tried (no offense or entitlement, just a data point).
My usecase was simple: scan a table (with filtering), get result as zio Stream.

This issue with limit
I haven't managed to make macro-based filter dsl to work with optional fields
Then I tried to get the result as ZStream instead of ZIO. I found out that I need to use scanM, but didn't find relevant Monad and MonoidK instances for ZStream. At some point they were deleted from the code.

Combination of these things made me to just write 30 LOC using ZStream.unfoldM + java API.
Again, thank you for the library! If you are interested, I can share some more concerns on UX, just feel that it's a bit off-topic :)

@simpadjo

Here are the issues I faced when tried (no offense or entitlement, just a data point).

None taken, thanks again this is very useful information.

At some point they were deleted from the code.

Yes, I moved them to interop-cats: https://github.com/zio/interop-cats/pull/67

@regiskuckaertz

None taken
I like this typo :rofl:

Yes, I moved them to interop-cats: zio/interop-cats#67
Then shouldn't they be reexported by scanamo-zio module?
Or, even better: an explicit method that interprets Scan into ZStream, without any high-kinded stuff.

Let me continue my rant :)
I found an 1+ year old ticket about ditching free monads. This would be great.
I explored the code base a little, and my feeling that free-monad dsl doesn't actually do many interesting things: it mostly does 1-1 mapping between Scanamo objects and Aws-sdk objects.
No surprise, aws-sdk is meant to be a high-level library to be directly used by the devs. Not a low-level set of building blocks.

Hi, sorry for going back to this but I think the fix applied in #996 only applies to the scan version and not the scanM or scanPaginatedM which suffer from a similar problem: if the result set is empty due to a filter then no extra page is scanned


LCM (Least Common Multiple) Calculator

Develop a calculator that finds the least common multiple of two or more integers, a useful tool for tasks involving periodic events.

I want to work on this issue. Please assign me under SWOC S4.

Proceed @Govind516


Support findings in AppMap webview editor

Closes https://github.com/getappmap/appmap-intellij-plugin/issues/143
This can be tested by opening an AppMap with findings attached. The AppMap webview should display the findings on the main page.
Double-clicking a node under Problems View > AppMap Scann Findings > Unknown files.

Passes findings data to the AppMap webview editor to support showing findings details
Open the AppMap if a finding node without know source location is executed in the problems view

@ahtrotta Thanks for spotting these issues!
I've fixed the first with https://github.com/getappmap/appmap-intellij-plugin/pull/196/commits/2a48aab6dafb13a2e8fcc12ece32b3dc7d614b7a. The ranges property wasn't passed as an array.
But I'm unsure what's wrong with the 2nd item...
The JSON has property findings[].finding.ruleId and I don't see what's wrong here. I inspected the JS webview with the DevTools and found that the href attribute was missing on the link. Do you know what might be wrong with the JSON?
The JSON sent to the JS webview is this:
{
  "findings": [
    {
      "finding": {
        "hash": "199f03f3a64271bb9c4942dd34e79e9c72fdd09460a88085195717632c3968d3",
        "hash_v2": "8b71e54cee6a5220c9a7bb1f95a8c6941ec0b7041d6be1c0fd519e364014f872",
        "ruleId": "n-plus-one-query",
        "ruleTitle": "N plus 1 SQL query",
        "stack": [
          "org/springframework/samples/petclinic/service/ClinicServiceTests.java:187"
        ],
        "message": "org/springframework/samples/petclinic/service/ClinicServiceTests#shouldFindVets[1] contains 6 occurrences of SQL: select s1_0.vet_id,s1_1.id,s1_1.name from vet_specialties s1_0 join specialties s1_1 on s1_1.id=s1_0.specialty_id where s1_0.vet_id=?",
        "groupMessage": "select s1_0.vet_id,s1_1.id,s1_1.name from vet_specialties s1_0 join specialties s1_1 on s1_1.id=s1_0.specialty_id where s1_0.vet_id=?",
        "impactDomain": "Performance",
        "event": {
          "id": 4
        },
        "relatedEvents": [
          {
            "id": 4
          },
          {
            "id": 6
          },
          {
            "id": 8
          },
          {
            "id": 10
          },
          {
            "id": 12
          },
          {
            "id": 14
          },
          {
            "id": 1
          }
        ]
      },
      "appMapUri": {
        "path": "/sources/spring-petclinic/target/appmap/junit/org_springframework_samples_petclinic_service_ClinicServiceTests_shouldFindVets.appmap.json",
        "fragment": "{\"currentView\":\"viewFlow\",\"selectedObject\":\"event:4\",\"traceFilter\":\"id:4 id:6 id:8 id:10 id:12 id:14 id:1\"}"
      },
      "problemLocation": {
        "range": {
          "line": 187
        },
        "uri": {
          "path": "org/springframework/samples/petclinic/service/ClinicServiceTests.java"
        }
      },
      "stackLocations": [
        {
          "truncatedPath": ".../samples/petclinic/service/ClinicServiceTests.java:187",
          "uri": {
            "path": "/sources/spring-petclinic/src/test/java/org/springframework/samples/petclinic/service/ClinicServiceTests.java"
          },
          "range": [
            {
              "line": 186,
              "character": 0
            }
          ]
        }
      ],
      "ruleInfo": {
        "id": "n-plus-one-query",
        "description": "Finds occurrences of a query being repeated within a loop.",
        "title": "N plus 1 SQL query",
        "references": {
          "CWE-1073": "https://cwe.mitre.org/data/definitions/1073.html"
        },
        "impactDomain": "Performance",
        "scope": "command"
      },
      "rule": {
        "id": "n-plus-one-query",
        "description": "Finds occurrences of a query being repeated within a loop.",
        "title": "N plus 1 SQL query",
        "references": {
          "CWE-1073": "https://cwe.mitre.org/data/definitions/1073.html"
        },
        "impactDomain": "Performance",
        "scope": "command"
      },
      "appMapName": "org_springframework_samples_petclinic_service_ClinicServiceTests_shouldFindVets"
    }
  ]
}

But I'm unsure what's wrong with the 2nd item... The JSON has property findings[].finding.ruleId and I don't see what's wrong here. I inspected the JS webview with the DevTools and found that the href attribute was missing on the link. Do you know what might be wrong with the JSON?

Ah, okay, I figured it out. There needs to be a url property in the rule field (findings[].finding.rule.url). This is the value that the href attribute should receive (see here).

:tada: This PR is included in version 0.28.0 :tada:
The release is available on:

v0.28.0
GitHub release

Your semantic-release bot :package::rocket:


mint-lock contract allows minters to bypass their epoch limit.

What version are you using?
Related to: https://github.com/stellar/soroban-examples/pull/294 (mint-lock)
What did you do?
The mint-lock contract example code contains a vulnerability that allows minters to bypass their epoch limit.
amount is a signed i128 value so a minter may use a mint contract, accepting negative values, to decrease their consumed_limit.
consumed_limit: minter_stats.consumed_limit + amount

Provide a recipe for reproducing the error.

Deploy a contract with mint function conforming to the MintInterface signature. The function can be a no-op, essentially enabling a successful invocation of the mint function with a negative amount value on the mint-lock contract.

Invoke the mint function on the mint-lock contract with any negative amount. This decreases the consumed_limit for the minter.

The epoch limit for the minter is now increased by the absolute value of the negative amount used.

Reproduced on Testnet:
set minter limit (100) 0b6adff4136337518af75943641d98c4fc6f854328e41f4ec4f7b6d7b97ee6e7
mint with negative amount (-10000000) 906d356f6e4559b7281a8e86e0bfb5cfe01ffd17b2fa8e89440e99a5c2fd60b2
mint with positive amount (10000000)  5b92f29860678da49fa230f6a46b5e6feb9491de4dc557f151ee8e732a79d61d
What did you expect?
Negative amounts should not be allowed. Could either assert amount > 0 or key the contract with the config so minter cannot use any minting contract.

Nice catch. I like the suggestion to disallow negative values. It's a broad way to limit impact from unintentional misuse. An exploit like this relies on a token that accepts negative mint values, which I think would be unlikely. But in any case this mint-lock contract could just deny it as well to ensure no internal misbehavior due to limits behavior with negative behaviors being not well defined.

Fix in:

https://github.com/stellar/soroban-examples/pull/296

Ah yes, there's two issue and this second issue still exists. The admin of the mint lock contract doesn't control what the limit applies to.

Fix in:

https://github.com/stellar/soroban-examples/pull/297

Nice. On a separate topic, I see that you used multiple-value tuple variants for the enum in the contract so they seem allowed for contract types #[contracttype], but the Soroban documentation is saying that only unit and single-value variants are supported. Docs may need an update on this line.

Thanks! Fix in:

https://github.com/stellar/soroban-docs/pull/703


Typo in Request Flow

an 'r' is missing in word 'remove' in the sentence:
Optionally, the reverse proxy can modify the request; for example, to add or emove headers, based on filter rules of the HTTPRoute.

@daniel-jantrambun what file is it from ?

Hey @daniel-jantrambun, I think You should more elaborate on this issue here, or add some references here. otherwise, close it.
/triage needs-information

To find the text, try:
https://kubernetes.io/search/?q=the reverse proxy can modify the request; for example, to add or
@daniel-jantrambun would you be willing to mention https://kubernetes.io/docs/concepts/services-networking/gateway/ in the description for this PR?
/kind bug
/remove-triage needs-information
/priority backlog

@daniel-jantrambun Can I work on this small issue, if u may? : )

@daniel-jantrambun can you assign it to me? its my first contribution and i found the path where things need to be fixed.

/assign

Fixed by #43819
/close


when redis was running bgrewriteaof cmd. it say  'Error trying to rename the existing AOF to old tempfile'

What I'm seeing in the logs is:
[16248] 27 Aug 17:54:36.424 * Background append only file rewriting started by pid 21980
[16248] 27 Aug 17:54:37.893 # Short write while writing to the AOF file: (nwritten=0, expected=53)
[16248] 27 Aug 17:54:38.112 # fork operation complete
[16248] 27 Aug 17:54:38.159 * Background AOF rewrite terminated with success
[16248] 27 Aug 17:54:38.159 * Parent diff successfully flushed to the rewritten AOF (83 bytes)
[16248] 27 Aug 17:54:38.159 # Error trying to rename the existing AOF to old tempfile: Broken pipe
please help me.

i built it in tag win-2.8.2102

Hi @zqzjz0911
thank you for reporting the issue.
What version of Redis are you running? What version of Windows?
Is there already an existing AOF file? If yes, how big is it?
Is the error persisting?
Thank you.

i built it in tag win-2.8.2102,  windows 8.1, the aof file has 9GB, it's persisting..

@zqzjz0911
how much free disk space is available?

there's 13GB

the program leave a temp file called temp-rewriteaof-bg-16248.aof (77MB)

@zqzjz0911
the temp file has always the same 77MB size or everytime there is an attempt to rewrite the AOF the file of the temp file is different?

always the same 77MB. but the log has changed something...
[16248] 27 Aug 18:22:11.759 * Background append only file rewriting started by pid 14824
[16248] 27 Aug 18:22:13.493 # fork operation complete
[16248] 27 Aug 18:22:13.539 * Background AOF rewrite terminated with success
[16248] 27 Aug 18:22:13.539 * Parent diff successfully flushed to the rewritten AOF (0 bytes)
[16248] 27 Aug 18:22:13.539 # Error trying to rename the existing AOF to old tempfile: Broken pipe

@zqzjz0911
can you delete the temp file?

the temp file can be deleted.

@zqzjz0911
when you started Redis, the 9BG AOF file was already there right?
After Redis started, did the error occur at the first AOF rewrite attempt or does the log show at least one successful AOF rewrite? I mean a rewrite not followed by the "Error trying to rename the existing AOF to old tempfile".

yes.
the 9GB file was still 9GB, after writing these log.

and after running bgrewriteaof cmd, the redis process has still hold the cpu resource (2-3%)

my cpu is i7  4core 8 thread

i run it in two machine, there is the problem in all machine.
one is win 8.1, another is win2008 r2

can i send the aof file to you ?

@zqzjz0911
sure, can you zip it and upload it to a cloud service?
The Win 8.1 is a development machine? If yes, can you quit Redis, rename the AOF file, restart Redis, fill it with some data and verify if the AOF rewrite still fail?
One more question, you said you compiled Redis, did you make any change to the code? I'm wondering why you compiled it and not just downloaded the binaries.
Thank you.

i found that the aof file is truncated..maybe that is the reason cause this problem...

i have not made any change to the code..

please use the link to download the aof file: http://pan.baidu.com/s/1pJN2Tzt

@zqzjz0911
the site asks to use the Baidu downloader but unfortunately it fails to download it.

but how can i send file to you now?

@zqzjz0911
do you have an hotmail account? I can created a shared folder where you can upload the file but you will need to log in with an hotmail account.

<EMAIL_ADDRESS>

I've sent you an email, feel free to remove the email address from you previous comment.
Thank you.

uploadding has finished

OK!

@zqzjz0911
using the AOF you sent me, I can repro the problem, I'll let you now as soon as I have a fix for it.
Thank you.

thx

Hi @zqzjz0911,
as you already noticed, the problem was occurring because the AOF was truncated.
The fix is ready and it will be included in the next release.
For now you can workaround the problem fixing the AOF file with the redis-check-aof.exe utility:
c:\program files\redis\redis-check-aof --fix appenonly.aof

Thank you for your contribution to improve Redis on Windows!

but config file of redis can pass the file by using aof-load-truncated...and in that case the problem will be caused.

how are you fix it ? can you tell me the detail ?

@zqzjz0911
when an incomplete AOF is detected, the file is truncated at the last valid value so it won't be incomplete anymore.
The code that truncates the file wasn't releasing the file handle (that is a bug because the file remains in use).
When an AOF rewrite is executed the AOF has to be renamed but renaming was failing because the file was still in use.
There was also another bug since the temp file was not deleted after failing to rename it.

i see。thx。

@zqzjz0911,
the new release 2.8.2103 contains the fix for this issue.
Thank you.

thx.let me build it.