TypeScript overrides are not working with v4.0.0-alpha.8

Environment

Tech
Version

@material-ui/pickers
v4.0.0-alpha.8

material-ui
4.10.0

TypeScript
3.9.3

React
16.13.1

Browser
All

Peer library
date-fns

Steps to reproduce
Following the TypeScript example for overriding CSS causes a type error in @material-ui/core.
I have the following in my TypeScript declaration file:
import { MuiPickersComponentsToClassName } from '@material-ui/pickers/typings/overrides';

declare module '@material-ui/core/styles/overrides' {
  export interface ComponentNameToClassKey extends MuiPickersComponentsToClassName {}
}

Side note: The example also references the src path, which is also doesn't work.   Removing src seems to make that import work.

Expected behavior
tsc should pass.
Actual behavior
When I run tsc on my project, I get the following error:
$ tsc -p tsconfig.json
../../../node_modules/@material-ui/core/styles/overrides.d.ts:100:64 - error TS2344: Type 'ComponentNameToClassKey[Name]' does not satisfy the constraint 'string'.
  Type '"fixed" | "required" | "default" | "square" | "active" | "disabled" | "track" | "error" | "progress" | "message" | "middle" | "media" | "hidden" | "body" | "button" | "caption" | ... 486 more ... | undefined' is not assignable to type 'string'.
    Type 'undefined' is not assignable to type 'string'.

100   [Name in keyof ComponentNameToClassKey]?: Partial<StyleRules<ComponentNameToClassKey[Name]>>;
                                                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

If I remove the picker overrides, tsc passes.

@bopfer Do you have a reproduction for the TypeScript fail? It seems to work fine: https://codesandbox.io/s/festive-golick-ej7q7?file=/src/theme.ts?
However, thanks for reporting thee other issues.

MuiPickersComponentsToClassName is likely not the correct name for the object. Following the convention in the core, I think that PickersComponentsToClassKey will be less confusing. We might handle the props at the same time:

diff --git a/lib/src/typings/overrides.ts b/lib/src/typings/overrides.ts
index df2d2058..aefae067 100644
--- a/lib/src/typings/overrides.ts
+++ b/lib/src/typings/overrides.ts
@@ -33,7 +33,7 @@ type Classes<T> = T extends string
   ? D
   : never;

-export interface MuiPickersComponentsToClassName {
+export interface PickersComponentsToClassKey {
   MuiPickersDay?: Classes<typeof DayStyles>;
   MuiPickerDTHeader?: Classes<typeof DTHeaderStyles>;
   MuiPickerDTTabs?: Classes<typeof DTTabsStyles>;
diff --git a/lib/src/typings/props.ts b/lib/src/typings/props.ts
index 993497e2..7b6cfadf 100644
--- a/lib/src/typings/props.ts
+++ b/lib/src/typings/props.ts
@@ -27,7 +27,7 @@ import {
   StaticDateRangePickerProps,
 } from '..';

-export interface MuiPickersComponentsPropsList {
+export interface PickersComponentsPropsList {
   MuiPickersDay: DayProps;
   MuiPickersCalendarView: CalendarViewProps;
   MuiPickersDatePicker: DatePickerProps;

The import path is wrong in the documentation:

diff --git a/docs/pages/guides/css-overrides.mdx b/docs/pages/guides/css-overrides.mdx
index e7ab9fd9..b8fdb20a 100644
--- a/docs/pages/guides/css-overrides.mdx
+++ b/docs/pages/guides/css-overrides.mdx
@@ -46,7 +46,7 @@ Add the following to a TypeScript declaration file in your project, such as `ove
 <!-- should be in sync with lib/src/__tests__/typings.d.ts -->

 ```typescript
-import { MuiPickersComponentsToClassName } from '@material-ui/pickers/src/typings/overrides';
+import { PickersComponentsToClassKey } from '@material-ui/pickers/typings/overrides';

 declare module '@material-ui/core/styles/overrides' {
   export interface ComponentNameToClassKey extends MuiPickersComponentsToClassName {}

Depending on how https://github.com/mui-org/material-ui/pull/21279 go, we might want to change the approach here too.

Sorry, should have added that the overrides do work in the sense that I don't get any errors in my theme.ts file itself.  The error only shows up when I run tsc.  I will create a small repo to reproduce and to verify that it is an isolated issue and not something with my project setup.

Here is a reproduction: https://github.com/bopfer/mui-picker-overrides.  The README in there has notes about the setup and how to reproduce the error.

@bopfer Any idea what could be wrong?

I am not sure it will work for you. Are you sure that types folder included? I am always explicitly adding it with includes

@bopfer I had a closer look at the problem. It seems to be coming from a divergence with the core's approach: https://github.com/mui-org/material-ui/blob/51b6ea9626a1be8304e495b39cd9ed6ca1ce5c0d/packages/material-ui/src/styles/overrides.d.ts#L110.
Could you confirm that this diff solves the issue?
diff --git a/lib/src/typings/overrides.ts b/lib/src/typings/overrides.ts
index df2d2058..78e53d5c 100644
--- a/lib/src/typings/overrides.ts
+++ b/lib/src/typings/overrides.ts
@@ -34,35 +34,35 @@ type Classes<T> = T extends string
   : never;

 export interface MuiPickersComponentsToClassName {
-  MuiPickersDay?: Classes<typeof DayStyles>;
-  MuiPickerDTHeader?: Classes<typeof DTHeaderStyles>;
-  MuiPickerDTTabs?: Classes<typeof DTTabsStyles>;
-  MuiPickersCalendar?: Classes<typeof CalendarStyles>;
-  MuiPickersCalendarView?: Classes<typeof CalendarViewStyles>;
-  MuiPickersCalendarHeader?: Classes<typeof CalendarHeaderStyles>;
-  MuiPickersSlideTransition?: Classes<typeof SlideTransitionStyles>;
-  MuiPickersYearSelection?: Classes<typeof MuiPickersYearSelectionStyles>;
-  MuiPickersYear?: Classes<typeof MuiPickersYearStyles>;
-  MuiPickersMonthSelection?: Classes<typeof MuiPickersMonthSelectionStyles>;
-  MuiPickersMonth?: Classes<typeof MuiPickersMonthStyles>;
-  MuiPickersTimePickerToolbar?: Classes<typeof TimePickerToolbarStyles>;
-  MuiPickersClock?: Classes<typeof ClockStyles>;
-  MuiPickersClockNumber?: Classes<typeof ClockNumberStyles>;
-  MuiPickersClockPointer?: Classes<typeof ClockPointerStyles>;
-  MuiPickersToolbar?: Classes<typeof PickerToolbarStyles>;
-  MuiPickersToolbarButton?: Classes<typeof ToolbarButtonStyles>;
-  MuiPickersToolbarText?: Classes<typeof MuiPickersToolbarTextStyles>;
-  MuiPickersDatePickerRoot?: Classes<typeof DatePickerRootStyles>;
-  MuiPickerDTToolbar?: Classes<typeof MuiPickerDTToolbarStyles>;
-  MuiBasePickerStyles?: Classes<typeof MuiBasePickerStyles>;
+  MuiPickersDay: Classes<typeof DayStyles>;
+  MuiPickerDTHeader: Classes<typeof DTHeaderStyles>;
+  MuiPickerDTTabs: Classes<typeof DTTabsStyles>;
+  MuiPickersCalendar: Classes<typeof CalendarStyles>;
+  MuiPickersCalendarView: Classes<typeof CalendarViewStyles>;
+  MuiPickersCalendarHeader: Classes<typeof CalendarHeaderStyles>;
+  MuiPickersSlideTransition: Classes<typeof SlideTransitionStyles>;
+  MuiPickersYearSelection: Classes<typeof MuiPickersYearSelectionStyles>;
+  MuiPickersYear: Classes<typeof MuiPickersYearStyles>;
+  MuiPickersMonthSelection: Classes<typeof MuiPickersMonthSelectionStyles>;
+  MuiPickersMonth: Classes<typeof MuiPickersMonthStyles>;
+  MuiPickersTimePickerToolbar: Classes<typeof TimePickerToolbarStyles>;
+  MuiPickersClock: Classes<typeof ClockStyles>;
+  MuiPickersClockNumber: Classes<typeof ClockNumberStyles>;
+  MuiPickersClockPointer: Classes<typeof ClockPointerStyles>;
+  MuiPickersToolbar: Classes<typeof PickerToolbarStyles>;
+  MuiPickersToolbarButton: Classes<typeof ToolbarButtonStyles>;
+  MuiPickersToolbarText: Classes<typeof MuiPickersToolbarTextStyles>;
+  MuiPickersDatePickerRoot: Classes<typeof DatePickerRootStyles>;
+  MuiPickerDTToolbar: Classes<typeof MuiPickerDTToolbarStyles>;
+  MuiBasePickerStyles: Classes<typeof MuiBasePickerStyles>;
   // consider using inline import type notation
-  MuiPickersDesktopDateRangeCalendar?: Classes<
+  MuiPickersDesktopDateRangeCalendar: Classes<
     typeof import('../DateRangePicker/DateRangePickerViewDesktop').useStyles
   >;
-  MuiPickersArrowSwitcher?: Classes<typeof import('../_shared/ArrowSwitcher').useStyles>;
-  MuiPickersDateRangePickerInput?: Classes<
+  MuiPickersArrowSwitcher: Classes<typeof import('../_shared/ArrowSwitcher').useStyles>;
+  MuiPickersDateRangePickerInput: Classes<
     typeof import('../DateRangePicker/DateRangePickerInput').useStyles
   >;
-  MuiPickersModalDialog?: Classes<typeof import('../_shared/PickerModalDialog').useStyles>;
-  MuiPickersCalendarSkeleton?: Classes<typeof import('../CalendarSkeleton').useStyles>;
+  MuiPickersModalDialog: Classes<typeof import('../_shared/PickerModalDialog').useStyles>;
+  MuiPickersCalendarSkeleton: Classes<typeof import('../CalendarSkeleton').useStyles>;
 }

@oliviertassinari Confirmed.  The type check passes with that diff.

Great, if you want to do the changes, feel free to. Otherwise, I think that we should wait for the resolution of https://github.com/mui-org/material-ui/pull/21279 to apply the approach here in order to close the issue.


Implement substr function

Resolve https://github.com/gluesql/gluesql/issues/293
substr ( string text, start integer [, count integer ] ) → text
Extracts the substring of string starting at the start'th character, and extending for count characters if that is specified. (Same as substring(string from start for count).

I think this PR is ready for re-review :rofl: Please take a look. Thanks !


[Event Request] codeunit 1002 "Job Create-Invoice" -OnBeforeTestBilltoCustomerNo

I need this event to handle the testfield in my code.
Below is Object and image is for reference :
Object : codeunit 1002 "Job Create-Invoice"
Function: CreateSalesHeader
Parameters SalesHeader & IsHandled with VAR

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Change documentation build setup.

Coverage remained the same at 0.0% when pulling f673e297cc7072276d1a2ed3bc999008740c57c8 on www into da7c3ebca3d95153055cf4279e81f72c33ae66a6 on master.


Adding print_lines_not_matched option & layering of config

Please review my changes, described below.
The option print_lines_not_matched can be added into the config file; by default it is set to 0, keeping the original behaviour.
Also added a few more locations from which the config file is loaded. The default behaviour is kept; this change only adds more locations.
This allows for layering of config patterns; Useful for projects, where they can have their own config (for example); not the global one
I have also tweaked the awk + tail invocation line to be more easily extendible; what ever the function awk_script prints is passed into awk as script.

Similar to codemedic, I forked yesterday to make it print non-matching lines (TRACE, stacktrace, etc), but implemented slightly differently.  Also re-ordered the priorities so that (e.g.) a debug line with ERROR in the text is printed only once and in green.

Also re-ordered the priorities so that (e.g.) a debug line with ERROR in the text is printed only once and in green.

Isn't this just a configuration preference or am I missing something?
I'll look over @codemedic's proposal in a few minutes and probably merge it - the changes make sense, I just want to check that the script performs the same.

@codemedic, thank you for your contribution! :+1:


cert-manager controller increasing memory usage

Describe the bug:
I am using cert-manager to generate/maintain more than 4000 certificates and I have allocated up to 4 GB of memory to cert-manager controller. After two weeks of monitoring, I can see that the memory usage of controller is increasing constantly (sometimes up to the limit) and then drops down afterwards or the pod gets restarted. you can see the pattern of memory usage in last 7 days.

I don't know if this information is helpful or not, but I also checked out the number of sync calls on each controller in the last week and the ones that were higher than 10000 were:

I would like to know if this is counted as an expected behavior or not. Based on the pattern, I assume there is some kind of memory leak or maybe because we have many certificates!
Expected behaviour:
There should be a consistent memory usage pattern.
Steps to reproduce the bug:
I don't actually know how to reproduce this. But I assume generating and maintaining high number of certificates should lead to the same results.
Anything else we need to know?:
Environment details::

Kubernetes version: 1.18.14
Cloud-provider/provisioner: AWS
cert-manager version: 1.3.1
Install method: static manifests

/kind bug

Would you be able to give us read of the heap using the pprof endpoint? Since 1.2, the cert-manager controller can be configured with the flag
--enable-profiling

The pprof endpoints use the same port as the metrics endpoint (9402 by default). After adding the flag, you should be able to do:
kubectl port-forward -n cert-manager cert-manager-58985bd9bd-z9mwf 9402:9402
curl http://localhost:9402/debug/pprof/heap -O

You can visualize the heap file:
# Generate an SVG graph:
go tool pprof -svg heap

# Vizualize using a web UI:
go tool pprof -http=: heap

The heap file is the one we need to investigate the memory leak. I am curious as to how big it will be (note that this is not a core dump, so it shouldn't be that big). If it is not too big, please compress it and share it somewhere on the Internet.


add Dockerfile.tools

Description

Adding Dockerfile.tools for openshift-ci setup requirements

Relevant issues/tickets

N/A
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] This change requires a documentation update
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added a test case that will be used to verify my changes
[ ] Verified independently on a cluster by reviewer

Verification steps

N/A

I would add a test file like this https://github.com/integr8ly/integreatly-operator/blob/master/openshift-ci/test/run
This makes it handy for testing your image locally see https://github.com/integr8ly/integreatly-operator/tree/master/openshift-ci
You might want to just copy that directory structure, README and OWNERS file etc.., and update as appropriate.

@mikenairn mind having another look when you get the time?


[RFC]: Adopt mergify for auto-labeling PRs

Motivation.
vLLM is a very active project with a large and busy queue of PRs. Additional usage of github labels would assist with narrowing down which PRs to look at given a person's interests, as well as the state of the PR.
Proposed Change.
Adopt mergify to perform automated labeling of PRs. https://docs.mergify.com/
While github also provides an action for PR labeling, it only supports labeling based on the branch and the files changed. Mergify supports labeling based on more criteria, such as whether a branch has conflicts with main.
Configuration would go into .github/mergify.yml. An example entry to auto-label PRs that touch files in the docs/ directory:
- name: label-documentation
  description: Automatically apply documentation label
  conditions:
    - or:
      - files~=^[^/]+\.md$
      - files~=^CONTRIBUTING/
      - files~=^docs/
  actions:
    label:
      add:
        - documentation

Here is an example that is a bit more unique to Mergify's capabilities. This sample configuration will label a PR and comment tagging the PR author if the PR goes into conflict with the target branch (main). It will also automatically remove the label once conflicts are resolved.
- name: ping author on conflicts and add 'needs-rebase' label
  conditions:
      - conflict
      - -closed
  actions:
    label:
      add:
        - needs-rebase
    comment:
      message: |
       This pull request has merge conflicts that must be resolved before it can be
       merged. @{{author}} please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

- name: remove 'needs-rebase' label when conflict is resolved
  conditions:
      - -conflict
      - -closed
  actions:
    label:
      remove:
        - needs-rebase

Feedback Period.
No response
CC List.
No response
Any Other Things.
No response
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

Thank you for looking into this. There are few use cases I had in mind, not sure whether this solves it

a lightweight codeowners so we can ask relevant folks to review. this definite help address this
a way to label pr by components, using flexible rules on files changed and label. i believe this can be addressed as well.
figure out a way to label PRs that are stale, without reviewers, late on review. not sure whether this tool helps.

btw, is this a paid tool?

Thank you for looking into this. There are few use cases I had in mind, not sure whether this solves it

a lightweight codeowners so we can ask relevant folks to review. this definite help address this

Yes, there is an action for requesting reviews.  https://docs.mergify.com/workflow/actions/request_reviews/
The criteria can be based on files changed or other things.

a way to label pr by components, using flexible rules on files changed and label. i believe this can be addressed as well.

Yes, absolutely. The criteria can include files changed using a list of custom regex. The criteria can also include a number of other things, like other labels present on the PR, or any of the conditions listed on this page: https://docs.mergify.com/configuration/conditions/

figure out a way to label PRs that are stale, without reviewers, late on review. not sure whether this tool helps.

I'm not sure about these. For this, I've used the official stale action from github: https://github.com/actions/stale

btw, is this a paid tool?

It's free for open-source repositories. It is paid for private repos only.

Great! Please feel free to set one up, and let me know how can I help!

thanks!  next steps are here: https://github.com/vllm-project/vllm/pull/9259


Fixed returned native string values not handling unicode text correctly

For example, when Vehicle.FriendlyName is called if the UI language is set to Chinese, Korean, or Japanese, this issue will cause.
Before

After

Im going to presume the after picture is what its meant to be :)

the before picture means the returned native string values are transformed to the wrong values, whereas the after one means the returned native string values are transformed to the correct values.


Rename module for repo move

Fixing up the module name now that the repo has been moved to crossplane-contrib.

Hello! Is this still being worked on?

Who needs to review it ? Any updates ?
Renaming looks good from my perspective.

Hey, any update on this one? Can this be merged?

Hey, any update on this one? Can this be merged? @benagricola BTW, are there any maintainers for this repo?

Only a year and a bit late but I think all of the PR's in here that I made can be merged. I never had review / write access to this repo so I can't merge them myself and am no longer in a position to test the PR's or contribute further to this provider.


Encode tab_cwd in bas64 and add it to tabs buffer entry as field 2

With tab_cwd in entry, one can do something like:
fzf.tabs({
  fzf_opts = {
    ["--preview"] = [['echo "Tab #"{1}": $(echo {2} | base64 -d -)"']],
    ["--preview-window"] = "down,1",
  }
})

And get:

Looks great @lbrayner!
I’m wondering, is the base64 encoding needed? I’m currently working on adding windows support and would rather avoid extra dependencies (base64 binary to decode).
What are we really missing if we add the cwd to the entry as is (without base64)?

Looks great @lbrayner!
I’m wondering, is the base64 encoding needed? I’m currently working on adding windows support and would rather avoid extra dependencies (base64 binary to decode).
What are we really missing if we add the cwd to the entry as is (without base64)?

@ibhagwan Hey! base64 is just to avoid the hassle of escaping characters. So to avoid the bas64 dependency, you could either try to escape characters (on Unix, I think everything is allowed except /, right), or use Neovim RPC invocations, like you do with the reload functions. What do you think?

Entries are passed into the fzf pipe directly I don’t think we need to escape it here, try it without and let me know?

Just tested this without shell escaping, works great without the base64 decode, just with:
  fzf_opts    = {
    ["--preview"] = [['echo "Tab #"{1}": "{2}""']],
    ["--preview-window"] = "nohidden:up,1",
  },

Manually merged (without base64) at https://github.com/ibhagwan/fzf-lua/commit/2fca0f2ae6064aa106feef6b527a7dbefb825724

@ibhagwan  This is what I meant:

It breaks if CWD constains a colon. In this case the folder name is ~/code/my-app-typescript: a (copy).

That because I used a colon delimiter, we can choose a different one.

@ibhagwan ditch base64 dependency

How does this command solve your issue if the directory isn’t encoded in base64?

That because I used a colon delimiter, we can choose a different one.

Any character is allowed in a UNIX file name, that is the point. No matter what separator you choose, it can be broken, it's not a robust solution.

How does this command solve your issue if the directory isn’t encoded in base64?

If the directory name is encoded in base64, it can be decoded without extra dependencies.

If the directory name is encoded in base64, it can be decoded without extra dependencies.

I see what you meant now, I was confused given the current directory isn’t encoded in base 64.

Any character is allowed in a UNIX file name, that is the point. No matter what separator you choose, it can be broken, it's not a robust solution.

Alright, I’ll make the change later when I’m next to the computer, if you wish to have that earlier and wish to submit another PR you’re welcome to :)

Alright, I’ll make the change later when I’m next to the computer, if you wish to have that earlier and wish to submit another PR you’re welcome to :)

Done!

Alright, I’ll make the change later when I’m next to the computer, if you wish to have that earlier and wish to submit another PR you’re welcome to :)

Done!

Merged :)


Improve the UI of the Blogs Section

Feature description

👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

hey i would like to work on the issue please assign ...


addChain should return if a chain is already supported

https://github.com/cosmology-tech/cosmos-kit/blob/d5f38a315a29b5672f83504038ee083467c5ba3e/wallets/keplr-extension/src/extension/client.ts#L123-L140
for now, only do keplr mobile and keplr extension, you can leverage JSON from
https://github.com/cosmos/wallet-registry/blob/8a644ef3d1cadbb8ab240b969d381d07b79897e0/wallets/keplrextension/wallet.json#L8C3-L35C5
https://github.com/cosmos/wallet-registry/blob/8a644ef3d1cadbb8ab240b969d381d07b79897e0/wallets/keplrmobile/wallet.json#L8C2-L46C20

modify this to have supportedChains? property that stores an array of chain names
https://github.com/cosmology-tech/cosmos-kit/blob/d5f38a315a29b5672f83504038ee083467c5ba3e/packages/core/src/types/wallet.ts#L77


set up additional hangout meetings

 Issue by Erkan-Yilmaz
Sunday Feb 12, 2017 at 08:20 GMT
Originally opened as https://github.com/Erkan-Yilmaz/Gridcoin-tasks/issues/86

e.g.

for people who can not attend on Saturdays

see forum which has a poll

for the German community members (we are discussing that now)

general info: German thread

 Comment by grctest
Saturday Feb 18, 2017 at 12:42 GMT

No interest/feedback on this idea thus far? Last sat it sounded like there was interest in setting up a german hangouts, no?

 Comment by grctest
Friday Apr 21, 2017 at 19:20 GMT

There's been zero development on this topic thus far, unfortunately.


Compiler doesn't complain when assigning an iso reference to a field of some other object without consuming

The following piece of code compiles:
use "debug"

actor Foo
  be foo(arg: String iso) =>
    arg.append("foo")
    Debug.out("in Foo: " + arg.string())

class Bar
  var data: String ref = String

  fun ref bar() =>
    data.append("bar")
    Debug.out("in Bar: " + data)

actor Main
  new create(env: Env) =>
    let s = recover String end
    let bar = Bar
    bar.data = s

    Foo.foo(consume s)
    bar.bar()

However, before s was consumed and sent to Foo, it was assigned to a field of Bar instance (without consuming) and compiler didn't complain. Now, we have a reference to the same string in both Main and Foo and both of them modify its content.

Can confirm.

This has existed for months. At least as far back as dcf430a93e2d523dd7e829d6466d2192fdd8637f. Testing much earlier than that involves changing the LLVM version I have installed so I stopped looking at that point.

Fixed in #1471.

Thanks for the report @mlajszczak!

Thanks for addressing it quickly.

This has been merged. Release in progress. Will be part of 0.10.0


[CONTENT] Document GCP Pubsub refactoring

What content needs to be created or modified?
With https://github.com/dapr/components-contrib/pull/760 there are some changes to metadata field names, and most fields are now optional (if using implicit auth).
Describe the solution you'd like
Updated "Spec metadata fields" table
Where should the new material be placed?
operations/components/setup-pubsub/supported-pubsub/setup-gcp-pubsub/
Additional context

@trondhindenes - Are you going to issue a PR to the docs for this code re-organization change?

I am, and I'm sorry I haven't been able to do it yet. I'll set aside some time tonight and get it done.


chore(4.5): release 1.8.9

:robot: I have created a release beep boop
1.8.9 (2023-03-09)
Bug Fixes

release 1.8.10 (54a5762)
release 1.8.9 (5ae27c6)
release 1.8.9 with memory leak fix (e246191)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/GluuFederation/cloud-native-edition/releases/tag/v1.8.9 :sunflower:


Missing settings

Hi! I'm trying to test your app but there's some settings file missing (sails.config.settings is undefined)
Any help?

same here but just comment line 2 under services/mail.js  this line //var server = email.server.connect(sails.config.settings.email); and the app runs.

juanmiret,
You can create a 'settings.js' file in the folder config that contains this:
module.exports.settings = {
email<EMAIL_ADDRESS>}

that worked for me


Add Ultimate Control.app

Signed-off-by: Mario Kozjak<EMAIL_ADDRESS>

Thank you for the contribution. It was merged directly as 0ad1bee85dfd6ccc2f942c1e7681b0395447342f to keep commit history cleaner. Your contribution is still credited to you.


chore: Minor Fixes for release

Description

Changed solution file location in .releaserc.json
Removed unnecessary README.md csproj element that would cause dotnet pack to fail

Testing required outside of automated testing?

[ ] Not Applicable

Screenshots (if appropriate):

[ ] Not Applicable

Rollback / Rollforward Procedure

[ ] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 2.5.0 :tada:
The release is available on:

v2.5.0
GitHub release

Your semantic-release bot :package::rocket:


Use NonZeroU32 in the construction of outputs

This change removes LENGTH_INVALID and uses NonZeroU32 instead.

@kampersanda btw, LENGTH_MAX is no longer necessary, isn't it?

@vbkaisetsu Yes exactly. With https://github.com/daac-tools/daachorse/pull/30, the limit of 2^31 has been resolved.
Could you fix it together in this PR?

@kampersanda @kg86 fixed


Fix code example

@Nagarian Thank you for fixing that, I am merging this PR and it should be live soon.

Thanks you, this issue cost me a few hour to be found :)


Typescript definition file

Could you add a Typescript definition file in typings for your lib ?
Someone add it but just for 1.0.7 version.

Hi @vogloblinsky,
Probably needs and update, mind submitting a PR?


Caso de uso 6

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (99790ec) 100.00% compared to head (614126c) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##              master        #2   +/-   ##
===========================================
  Coverage     100.00%   100.00%
- Complexity         5        13    +8
===========================================
  Files              2         6    +4
  Lines             10        23   +13
===========================================
+ Hits              10        23   +13

Impacted Files
Coverage Δ

src/main/java/edu/fiuba/algo3/Arania.java
100.00% <100.00%> (ø)

src/main/java/edu/fiuba/algo3/Enemigo.java
100.00% <100.00%> (ø)

src/main/java/edu/fiuba/algo3/EnemigoMuerto.java
100.00% <100.00%> (ø)

src/main/java/edu/fiuba/algo3/Hormiga.java
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add --group and --only-group to uv run

Similar to #8110
Part of #8090

Annoyingly, we keep including the dev group by default even when it's not explicitly requested which messes with the warnings.


Porting grpcwebproxy to native Node.js

Nice library, we have been building our own abstractions on top of gRPC as well, but it looks like you've figured out most of the complicated details.
One thing though is the grpcwebproxy. It's still running in go. What are your thoughts on porting https://github.com/improbable-eng/grpc-web/tree/master/go/grpcwebproxy this directly to JS/Node.js so that way it can run natively in a single NodeJS application? I was considering doing this early on especially with respect to the WS transport so I could have browsers directly call the GRPC server.

It would be nice to have a pure JS port of grpcwebproxy, especially because it is not actively maintained and I had to do some patching to it in my fork to make it work right in all of the edge cases.
There's one concern though: grpcwebproxy serves both gRPC and gRPC-Web protocols on a single endpoint, so you can expose it and target from both the Browser and non-browser clients. It would be harder to do with NodeJS because I don't think that grpc-js allows you to control the http2 server and attach custom handlers to it. I'm not even sure that NodeJS allows you to have an http1 + http2 server, as Go does.
That said, there's still an option to make the port act as a proxy server, that forwards traffic to the gRPC server running in the same process.
Also, I'd like to note that we recommend using Envoy proxy (if you're fine with not having client streaming) because it seems to work much better than grpcwebproxy. See packages/nice-grpc-web#preparing-the-server

We actually monkey patched the grpc-js to have access to the http2 instance in order to manipulate it. So in TS the http2 is not part of the same interface, but runtime JS still has the property.
I wonder if both http and http2 are on the same port, a demuxer would be needed to split the protocols.
On 19 October 2021 2:43:52 pm AEDT, Daniel Lytkin @.***> wrote:

It would be nice to have a pure JS port of grpcwebproxy, especially because it is not actively maintained and I had to do some patching to it in my fork to make it work right in all of the edge cases.
There's one concern though: grpcwebproxy serves both gRPC and gRPC-Web protocols on a single endpoint, so you can expose it and target from both the Browser and non-browser clients. It would be harder to do with NodeJS because I don't think that grpc-js allows you to control the http2 server and attach custom handlers to it. I'm not even sure that NodeJS allows you to have an http1 + http2 server, as Go does.
That said, there's still an option to make the port act as a proxy server, that forwards traffic to the gRPC server running in the same process.
Also, I'd like to note that we recommend using Envoy proxy (if you're fine with not having client streaming) because it seems to work much better than grpcwebproxy. See packages/nice-grpc-web#preparing-the-server
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/deeplay-io/nice-grpc/issues/25#issuecomment-946342097
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

This seems to be possible with Node's TLS:

ALPNProtocols: <string[]> | <Buffer[]> | <TypedArray[]> | <DataView[]> |  |  |  An array of strings, Buffers or TypedArrays or DataViews, or a single Buffer or TypedArray or DataView containing the supported ALPN protocols. Buffers should have the format [len][name][len][name]... e.g. '\x08http/1.1\x08http/1.0', where the len byte is the length of the next protocol name. Passing an array is usually much simpler, e.g. ['http/1.1', 'http/1.0']. Protocols earlier in the list have higher preference than those later.

https://nodejs.org/api/tls.html#tlsconnectoptions-callback
So the expectation is that connecting clients will have this property and we would use this to select whether HTTP 1.1 for browsers or HTTP2 for non-browsers? Assuming they are using grpc web, would that mean they are always using HTTP 1.1, or are there possibilities that browsers will eventually use HTTP2? And if that's the case, then at some point grpcwebproxy shouldn't be needed right?

Browsers are actually able to use HTTP2, but there's no control over it from the JS code. So I guess that browsers already use HTTP2 when the server supports it, but the gRPC protocol implementation requires access to low-level API of HTTP2 framing, which the web standards currently lack.
See https://grpc.io/blog/state-of-grpc-web/

Cool thanks, we stopped using GRPC due to various issues like this and moved to our own transport agnostic RPC system.


Logout feature

Please add an explanation on how is it possible to make a logout feature with this auth method. Or if it's not possible now, maybe it will be a good idea to make it?
Thanks.

Basic Auth standard was not designed to allow an logout method. Also most browsers cache the credentials until you close the browser or enter wrong credentials. That said there are several workarounds but they do not work consistently on all browsers.
http://stackoverflow.com/questions/233507/how-to-log-out-user-from-web-site-using-basic-authentication
http://stackoverflow.com/questions/4163122/http-basic-authentication-log-out
Check the following link for workaround which combines many workarounds. Implementing this however is outside of the scope of this plugin.
http://www.berenddeboer.net/rest/authentication.html#permanent-logout
You could probably use dynamic realmparameter. Save a random string to session. Use that as part of realm name. Then implement a /logout route which will change the value of the string in session. When realm changes this should force browser to reauthenticate. Not tested though.


Get theme variables in to component styles

Hello.
Thank you for your work. I also want to change the styles of the components in my project, but I want it to be with variables from the based on theme. How can I achieve this. Any ideas?
Thank you.

Hi, if I'm understanding correctly, you want to change the styles of specific components based on the selected theme? You could define a CSS class for your component, then define different styles for that class in each theme. Then, when the user selects a new theme, the styles from that theme will be applied to the component.
E.g. in your component.html

...

In your theme files, e.g. theme1.scss:
.my-class {
    /* your styles here */
}

Putting those rules in your global theme Stylesheets means they won't be component-scoped, so I'd recommend defining new classes for each component to prevent conflicts.
Hope that helps!

You re saying putting that class/css inside just one theme css.(i.e. dark.scss) It's easy solution. But I don't want to use single css. My project will be getting bigger. So there is no way to use component base css with variables. At least in multiple themes.
Thank you.

I guess as an alternative you could use CSS variables in your component Stylesheet, and set a different value for the CSS variables in each theme Stylesheet. E.g. in dark.css:
* {
  --bg-color: black;
}

And in light.css:
* {
  --bg-color: white;
}

Then in your component Stylesheet, you would use those CSS variables:
.some-class {
  background-color: var(--bg-color);
}

Very good idea. I thought I should import for plain css variables to component css as well. But since there is no need to import the components, the variables of whatever theme comes and works fine. Thank you so much.
Also, I call mixin, functions, variables from bootstrap into components.
@import "~/node_modules/bootstrap/scss/functions";
@import "~/node_modules/bootstrap/scss/variables";
@import "~/node_modules/bootstrap/scss/mixins";

I can also use variables other than color (for example: @include media-breakpoint-down(lg) {..}) in component scss. When I need to add color, I use the variables I assigned as --primary.
To summarize for those who have a similar problem, it is necessary to assign extra css variables and use them in order to use colors in different themes in the component. At least for Bootstrap 5.


Update from deprecated criterion::Benchmark to BenchmarkGroup

This gets rid of the warnings generated by the benchmark code.  This
does not completely replecate the old behavior, which created three
benchmarks, all with their own throughput, but given the same name.  I
don't think that same thing is possible anymore with the non-deprecated
APIs.

Looks great, thanks @dfreese. Will merge shortly.


CTK API Documentation hyperlink on commontk.org

Hi,
The hyperlink to the CTK "API Documentation" from the bottom of the commontk.org web page does not point to a valid location (see below).
Is there somewhere else the API Documentation is available?
Thanks,
-Paul

This issue has been open for a good while now - see https://github.com/commontk/CTK/issues/937
I see you have already commented there, which will bump the issue. I'm closing this issue now to reduce clutter.


Finding waypoints in the same lane

version. 0.9.5.
I wish to find waypoints in the same lane as the currently occupied one. By calling waypoint.next(), it return a list of waypoints that are not guaranteed to be in the same lane. Is there a way to filter the returned list for a waypoint that is in the current lane?
I tried using lane_id, but they can change as the vehicle drives to a new road section as explained here:
https://github.com/carla-simulator/carla/issues/1469
I tested this out, and in what I've seen so far, the lane_id will only flip signs as the client drives down the road. For example, if I'm printing the current lane_id to terminal, it can look like:
3
3
3
-3
-3
Therefore, is using the absolute value of lane_id a safe way of filtering for waypoints in the same lane?
Thanks for the help
Edit: My previous observation was wrong. Sometimes it will go to a different number. Still searching for a way to find in lane waypoints

I do:
waypoint_separation = 4 next_w = list(current_w.next(waypoint_separation))[0]
similar to https://github.com/carla-simulator/carla/blob/master/PythonAPI/util/lane_explorer.py and I always get the next point in the same lane.


Setting ciphers can be surprisingly expensive

We've discovered that when setting ciphers for TLS 1.2 on a per SSL basis (as we need to see the client hello first) that this takes up time comparable to the ECDH derivation. It seems that at least part of the issue is on every call reordering the compiled in cipher suites to the default order regardless of what the string actually says to do, although the flamegraphs haven't shed all that much light on the exact problem.
This seems to be a long-standing issue, but fixing it might get back some of the performance lost other places.

Can you post the flame graph?  Or alternatively a perf data sample would be helpful.
Also, what version of openssl are you testing with?
Thanks!

I'll try to work on a reproducer. This is on 3.1.4.

ping, any update here @wbl

We rewrote the offending code privately, but with less features that are adequate to our case and got a tremendous improvement. In this case we only support full names of cipher suites, and so can do a simple lookup in the strings.
Sorry, I reported this issue while in the midst of some very urgent performance work, and then after it was done forgot entirely about it.

Understood, thank you.  Given that you've rewritten your code, and realized significant improvement in performance, I'm working under the assumption that this is not something that can be further investigated and can be closed?  Do you agree?  Or is there more to do here?

To be clear, we replaced SSL_set_ciphers with a custom SSL_set_ciphers_akamai, which was written to use a much simpler lookup operation. I believe this pinpoints the root cause of the issue, namely the cipher setting is a very slow process even when none of the harder to implement features are used.

@wbl would you mind providing an example implementation?

The one we use doesn't support anything beyond just using ciphersuite names exactly as IANA has them. If it is of interest I can provide it.

Actually SSL_set_ciphersuites() behaves in such way almost. I am thinking if we could generalize it.


chore: Run linter after tests

I'm not too sure I like this. Then you're all set and everything went through, only to see there's a semicolon missing somewhere and then the whole cycle starts again? 🤔


Fallback policy if the response selector has a lower confidence

What problem are you trying to solve?
When we use a Response Selector for FAQ, sometimes Rasa gets the FAQ intent with a confidence of 1.0, but when, we check the internal confidence of the intents on the Response Selector, the confidences scores are very low (0.2, 0.3), which makes the bot answer incorrectly.
https://forum.rasa.com/t/how-can-set-a-fallback-policy-if-the-response-selector-has-a-lower-confidence-level/40420
What's your suggested solution?
Add a configuration setting on the Response Selector to set the confidence threshold for the responses and if none of the FAQs go over that threshold, go to the fallback policy (if available)
Examples (if relevant)
No response
Is anything blocking this from being implemented? (if relevant)
No response
Definition of Done
No response

Thanks for submitting this feature request 🚀 @desmarchris will get back to you about it soon! ✨


[SPARK-30835][CORE][YARN] Add support for YARN decommissioning & pre-emption

What changes were proposed in this pull request?
This PR tries to make spark leverage the knowledge of the node loss in future, and tries to adjust the scheduling of tasks to minimise the impact on the application.
This PR Adds support for YARN decommissioning & pre-emption
Prevent new tasks from starting on any executors on decommissioning Nodes and offload shuffle blocks and cached RDD blocks.
Why are the changes needed?
Add the support to handle the Node Decommissioning for Yarn cluster manger in Spark
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Added the Unit Test and run the manual test.

Can one of the admins verify this patch?

+CC @attilapiros, @otterc, @zhouyejoe

cc @Ngone51 too FYI

ping @attilapiros, @otterc, @zhouyejoe, @Ngone51

Have you got chance to test this solution on a real cluster?

yes

@attilapiros I have handled all your comments. Can you please review again?

+CC @otterc push based shuffle would also be impacted by node decomissioning. Please take a look.

Not quite sure about what RM will respond to the AM's allocateResource call. Will the response include resources on nodes that are being decommissioned?IIUC, RM should not allocate new containers on those nodes after they get commissioned. Or RM will actually return to AM, that some of the nodes are getting decommissioned, where RM did allocate resources on those nodes for earlier allocateResource calls? If so, please add a comment in handleNodesInDecommissioningState. Thanks.
Indeed we should also better handling the node decommission for push based shuffle, it won't trigger retry though as it will fall back. But this case also applies to ESS cases where they have the unmerged shuffle files, but it will trigger stage retry to regenerate the unmerged shuffle data in other nodes.
We did get bothered, during some NM updates that couldn't go with work preserving restart. We issued the decommission to a few nodes in batches, and waited until the shuffle data under tmp got cleaned up, to make sure the whole cluster NM updates didn't trigger retries. This does increase the ops overhead.

What happens to nodes which are getting decomissioned, which have shuffle data on them (but no active executors) ?

@mridulm
If decommissioning is enabled, shuffle blocks are already migrated to another node before the executor exits. However, this is best effort. So shuffle data might be left if shuffle blocks migration is left incomplete or the executor doesn't exit cleanly. Can you please clarify what are the expectations for shuffle data when a node is put in decommissioning state?

Not quite sure about what RM will respond to the AM's allocateResource call. Will the response include resources on nodes that are being decommissioned?IIUC, RM should not allocate new containers on those nodes after they get commissioned. Or RM will actually return to AM, that some of the nodes are getting decommissioned, where RM did allocate resources on those nodes for earlier allocateResource calls? If so, please add a comment in handleNodesInDecommissioningState. Thanks. Indeed we should also better handling the node decommission for push based shuffle, it won't trigger retry though as it will fall back. But this case also applies to ESS cases where they have the unmerged shuffle files, but it will trigger stage retry to regenerate the unmerged shuffle data in other nodes. We did get bothered, during some NM updates that couldn't go with work preserving restart. We issued the decommission to a few nodes in batches, and waited until the shuffle data under tmp got cleaned up, to make sure the whole cluster NM updates didn't trigger retries. This does increase the ops overhead.

@zhouyejoe
I have added the comment, Can you clarify the expectations for ESS and push-based shuffle?

To clarify, I can see a need for supporting node decomissioning in yarn - for both on-prem clusters and for cloud deployments - but the solution will need to take into account what the cluster manager supports.
As I detailed above, yarn supports shuffle services and executors come and go on different nodes.
Decomissioning will need to account for it, which is a different model compared to k8s support.
@tgravescs might have insights into how Tez/MR handles decomissioning w.r.t shuffle.

To clarify, I can see a need for supporting node decomissioning in yarn - for both on-prem clusters and for cloud deployments - but the solution will need to take into account what the cluster manager supports. As I detailed above, yarn supports shuffle services and executors come and go on different nodes.
Decomissioning will need to account for it, which is a different model compared to k8s support.

@mridulm I get your point. That's why I wanted to ask what are the expectations from this PR for changes in External Shuffle Service.  I noticed Part 8 (Optional): When there is a node-local external shuffle service of the design DOC talks to some extent about this and can work according to it. But Do I need to include changes pertaining to External Shuffle Service in this PR itself or mark this PR as a sub-task of the SPARK-30835 feature and pursue ShuffleService side changes in a separate PR?

Can you clarify the expectations for ESS and push-based shuffle?

The push based shuffle on the decommissioned nodes will need to be covered in another ticket, such as not using the ESS on decommissioned nodes as potential mergers for later stages, and whether to update the merge status in MapOutputTracker as those nodes may potentially not be available which will later lead to merged shuffle fetch failure, and many more to make the process smooth.
This PR only covers the case for Executors. I think it should be only a sub task for SPARK-30835. And we can continue to add more sub tasks into it.

I don't remember off the top of my head how tez/MR handle that.  I don't think MR does, but TEZ likely does.

@mridulm @tgravescs
Do you agree with @zhouyejoe that we can mark this PR as a subtask of Yarn Decommissioning feature and complete it's review? I can create a new subtask and separate PR for Shuffle Service side changes.

@abhishekd0907 While it is possible to configure spark applications running on yarn not to use external shuffle service, it is much more common to have it enabled.
Given the comment above

If decommissioning is enabled, shuffle blocks are already migrated to another node before the executor exits. However, this is best effort. So shuffle data might be left if shuffle blocks migration is left incomplete or the executor doesn't exit cleanly.

we do not want to move shuffle blocks around if decomissioning is enabled when external shuffle service is in use.
You could explicitly scope this PR to the case when ESS use is not enabled - namely, add the additional check for SHUFFLE_SERVICE_ENABLED being disabled.
Thoughts ?

You could explicitly scope this PR to the case when ESS use is not enabled - namely, add the additional check for SHUFFLE_SERVICE_ENABLED being disabled. Thoughts ?

@mridulm Migration is enabled only when spark.storage.decommission.enabled, spark.storage.decommission.rddBlocks.enabled and spark.storage.decommission.shuffleBlocks.enabled are enabled based on the following code in CoaraseGrainedExecutorBackend and these flags are false by default.
val migrationEnabled = env.conf.get(STORAGE_DECOMMISSION_ENABLED) &&
        (env.conf.get(STORAGE_DECOMMISSION_RDD_BLOCKS_ENABLED) ||
          env.conf.get(STORAGE_DECOMMISSION_SHUFFLE_BLOCKS_ENABLED))

So even if external shuffle service is enabled and this yarn decommissioning flow is invoked, bock migration won't be triggered unless these flags are turned on.  Executors will just wait for tasks to complete gracefully and then exit. I think this should be okay but I can add a check for SHUFFLE_SERVICE_ENABLED if you think that is needed?

ping @mridulm

Let us add shuffle service enabled == false as well, until this is supported in this context.

@mridulm
I have updated the PR as discussed. I have also created a new subtask for support of Yarn Decommissioning when ESS is enabled. SPARK-39024. I'll create a PR for this shortly.
Can you please review this PR again?

+CC @attilapiros - any thoughts ?

@attilapiros Can you please review this PR again?

Let us add shuffle service enabled == false as well for STORAGE_DECOMMISSION_SHUFFLE_BLOCKS_ENABLED, until this is supported in the context of shuffle blocks.

We've started looking into handling decommissioning in our cluster, so just seeing this and catching up. It looks like currently decommissioning in yarn is completely disabled in this PR if the shuffle service is used, but based on this comment did you mean/would it make more sense to disable storage migration if the shuffle service is enabled, irrespective of the cluster manager, so you'd still get some clean decommissioning of executors in yarn even if the shuffle service is enabled? I'm guessing migrating shuffle blocks from the shuffle service won't be as simple of a task.

@mridulm @attilapiros I have handled all your comments. Can you please review the PR again?

ping @mridulm @attilapiros

Thanks for @abhishekd0907 to submit this PR. I think this is a good improvement for the Spark jobs' stability, especially in the scenario where we implement elastic Yarn NMs on K8s.

we do not want to move shuffle blocks around if decomissioning is enabled when external shuffle service is in use.

@mridulm
But in our internal cluster, we deployed the ess on Yarn nodemangers, and sometimes nm will  be gracefully decommissioned, it means that the ess will be invalid on these nms.
So why not allow trigger decommission event to executors when ess is in use?

@mridulm @attilapiros can you please approve and merge if changes look good to you?

Thanks for @abhishekd0907 to submit this PR. I think this is a good improvement for the Spark jobs' stability, especially in the scenario where we implement elastic Yarn NMs on K8s.

we do not want to move shuffle blocks around if decomissioning is enabled when external shuffle service is in use.

@mridulm But in our internal cluster, we deployed the ess on Yarn nodemangers, and sometimes nm will be gracefully decommissioned, it means that the ess will be invalid on these nms.
So why not allow trigger decommission event to executors when ess is in use?

@zuston I will raise a separate PR for this scenario shortly after this one is merged so it should cover things exhaustively. This is the associated sub-task: SPARK-39024

Can you update the description to reflect the changes made to the PR  @abhishekd0907 ?
Specifically - this is only related to decomissioning and we do not handle shuffle ?
The changes look good to me, will merge once we update.

Can you update the description to reflect the changes made to the PR @abhishekd0907 ? Specifically - this is only related to decomissioning and we do not handle shuffle ?
The changes look good to me, will merge once we update.

@mridulm done.

Merged to master.
Thanks for working on this @abhishekd0907 !
Thanks for the review @attilapiros :-)

Catching up on PR's ... this should have been caught by GA hooks, right ?
Should have double checked, thanks for flagging this @tgravescs !


Implement an unmodifiable List for array

What changes are proposed in this pull request?
This PR adds an unmodifiable List interface over an underlying array, so we no longer need to use Collections.unmodifiableList(Arrays.asList())
Why are the changes needed?
In some JDKs. Arrays.asList() is internally new ArrayList<>(array), which incurs a copy. And getting that array back from the List will create another copy with list.toArray(new T[]). We add this class to simplify interface conversion and reduce unnecessary copies created just merely for that conversion.
Does this PR introduce any user facing changes?
NA

Closed in favor of https://github.com/Alluxio/alluxio/pull/15197


add Wi-Fi agreement at VSB

By accessing and using WiFi network tuonet-guest, you confirm, that you are familiar and agree with the "University computer network use policy" described in document named "Pravidla užívání počítačové sítě VŠB-TU Ostrava (TUO_SME_99_002)" (czech language only) and with all related documents. The University may monitor and report all incidents caused by using this network and forward them to appropriate subjects (university CSIRT team, police etc.).

added


Any way to suppress 'mocha div missing' error?

I've got a pretty run of the mill karma/mocha setup to run tests using the latest version of each module. The tests themselves run flawlessly but in the chrome window that pops up there's a 'mocha div missing' error that is displayed. I tried to do some research about it but could not find any documentation about it. The normal mocha div is in the test html, so the error itself makes no sense to me either.
This error would show up in debug as well, so I tried setting client.mocha.reporter: html and that does indeed fix it on the debug page, but we're still left with the unsightly error on the context page.
Is there perhaps a way to set debug as the default context page? If not then simply suppressing the error would be good enough.

I also want this too :confounded:


Usage of id type of Null

Following the readme, I wanted to work with a table that has not id. Therefore, I tried to instantiate a Repo[MyTableCreator, MyTable, Null], but I got two compile errors:
First, missing an implicit ClassTag[Null]:
[error]    |    /* missing */summon[scala.reflect.ClassTag[Null]])
[error]    |
[error]    |But no implicit values were found that match type scala.reflect.ClassTag[Null]
[error]    |
[error]    |where:    derived$DbCodec  is a given instance in object Creator
[error]    |          derived$DbCodec² is a given instance in object Foo
[error]    |          magnum           is a package in package com.augustnagro
[error]    |          magnum²          is a package in package kicks.db

Then a missing DbCodec[Null] (we can maybe improve the error message in the future):
[error]    |java.util.NoSuchElementException: None.get
[error]    |	at scala.None$.get(Option.scala:627)
[error]    |	at scala.None$.get(Option.scala:626)
[error]    |	at com.augustnagro.magnum.RepoDefaults$.genImpl(RepoDefaults.scala:47)
[error]    |	at com.augustnagro.magnum.RepoDefaults$.inline$genImpl(RepoDefaults.scala:39)

My current workaround:
given scala.reflect.ClassTag[Null] = new scala.reflect.ClassTag[Null] { def runtimeClass = classOf[Null] }
given DbCodec[Null] with {
  val cols = IArray(java.sql.Types.NULL)
  def readSingle(rs: java.sql.ResultSet, pos: Int) = null
  def writeSingle(a: Null, ps: java.sql.PreparedStatement, pos: Int) = ()
  def queryRepr = "NULL"
}

Is this expected or am I missing something in the setup?
Using scala 3.4.1 and magnum 1.1.1.

Thanks for the report; that's a bug. Please review the linked MR and I can cut a new release.

Thank you this quick fix and for the great work!
I really like the simplicity of magnum 👍


Fails to create and read the .txt file required

Hi,
I've been trying to execute your project for several hours now, but I did face an issue.
After patching the code by doing
# import tensorflow as tf
import tensorflow_hub as hub
import tensorflow.compat.v1 as tf
tf.disable_v2_behavior()

I'm unable to execute it to the end.
Here is the output I have:
% python3 mainGUI1.py
WARNING:tensorflow:From /Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/tensorflow/python/compat/v2_compat.py:107: disable_resource_variables (from tensorflow.python.ops.variable_scope) is deprecated and will be removed in a future version.
Instructions for updating:
non-resource variables are not supported in the long term
2022-02-28 01:49:18.669703: W tensorflow/core/common_runtime/graph_constructor.cc:1511] Importing a graph with a lower producer version 27 into an existing graph with producer version 987. Shape inference will have run different parts of the graph with different producer versions.
2022-02-28 01:49:39.186874: I tensorflow/core/platform/cpu_feature_guard.cc:151] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
Traceback (most recent call last):
  File "/Users/xxxxxx/Documents/MichelAI/mainGUI1.py", line 408, in mainlogic
    file = open('output/' + FILENAME + '/' + str(iteration) + '/' + FILENAME + '.txt', "w")
FileNotFoundError: [Errno 2] No such file or directory: 'output/DownUnder/0/DownUnder.txt'
zsh: abort      python3 mainGUI1.py

☑Python 3.9.10 as default
☑pip3 install -r requirements
☑Windows 10 with RTX 2070S Cuda (with Nvidia sdk)
☑macOS 12 with AMD Vega
☑.mp3 and .wav
☑777 permissions on MichelAI directory
freeze:
% pip3 freeze -r requirements.txt
opencv-python==<IP_ADDRESS>
moviepy==1.0.3
numpy==1.22.2
tensorflow==2.8.0
tensorflow-hub==0.12.0
PyQt5==5.15.6
Wave==0.0.2

Patched it on Mac with this command mkdir -p output/DownUnder/0/

The issue seems resolved with your patch


Social — Auto-Stop GeoLocation on Coordinate Capture

At the moment the navigator.geolocation.watchPosition function runs continuously when activated in order to update the geolocation field on the compose modal. This should be stopped with the .clearWatch() function all.
Something like:
geoLoc = navigator.geolocation;
watchID = geoLoc.watchPosition(showLocation, errorHandler, options);
geoLoc.clearWatch(watchID);

Done and done. This has been deployed as part of the 20E090 update and is live now.
Closing ticket.


Fix conda install instructions

Moved icoscp to pip section of environment.yaml and corrected msgpack package name to msgpack-python.
Need to do some additional checks to make sure this works correctly so a draft for now.

Codecov Report

Merging #495 (50c1bd5) into devel (3d249ed) will increase coverage by 0.79%.
The diff coverage is 89.38%.

@@            Coverage Diff             @@
##            devel     #495      +/-   ##
==========================================
+ Coverage   77.49%   78.28%   +0.79%
==========================================
  Files         168      170       +2
  Lines       12049    12494     +445
==========================================
+ Hits         9337     9781     +444
- Misses       2712     2713       +1

Impacted Files
Coverage Δ

openghg/analyse/_scenario.py
76.79% <ø> (ø)

openghg/objectstore/__init__.py
71.42% <ø> (ø)

openghg/retrieve/__init__.py
100.00% <ø> (ø)

openghg/standardise/_standardise.py
57.30% <ø> (ø)

openghg/transform/emissions/_edgar.py
78.79% <ø> (ø)

openghg/tutorial/__init__.py
100.00% <ø> (ø)

tests/conftest.py
71.87% <ø> (+2.43%)
:arrow_up:

tests/db_integrity/test_data_updates.py
97.15% <ø> (ø)

tests/helpers/__init__.py
100.00% <ø> (ø)

openghg/tutorial/_tutorial.py
33.57% <24.32%> (+0.24%)
:arrow_up:

... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Integrate Mindera's cosigner plugin into fastlane

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

Following a suggestion by @hjanuschka, the Mindera cosigner plugin's ✍
(https://github.com/Mindera/fastlane-plugin-cosigner) functionality was
integrated into the existing automatic_code_signing action, so that
it can be available to all fastlane users out of the box 💪.
It adds functionality to set:

CODE_SIGN_IDENTITY if :code_sign_identity set
PROVISIONING_PROFILE_SPECIFIER if :profile_name set
PROVISIONING_PROFILE if :profile_uuid set
PRODUCT_BUNDLE_IDENTIFIER if :bundle_identifier set

It (finally 😅) closes the following issue on Mindera's cosigner plugin: https://github.com/Mindera/fastlane-plugin-cosigner/issues/8

Regarding testing, new unit tests were added to check if the new project settings are properly updated, following the existing tests structure.
Description

The changes on this PR consist of enabling fastlane users more control over their code signing setup, besides simply switching between manual or automatic code signing.
In practice, additional target build configurations are defined with the new set of optional parameters, when defined. The new action parameters are:

Parameter
Description
Environment Variable

code_sign_identity
Code signing identity type ("iPhone Development", "iPhone Distribution")
FL_CODE_SIGN_IDENTITY

profile_name
Provisioning profile name to use for code signing (Xcode 8+)
FL_PROVISIONING_PROFILE_SPECIFIER

profile_uuid
Provisioning profile UUID to use for code signing (Xcode 7 and earlier)
FL_PROVISIONING_PROFILE

bundle_identifier
Application Product Bundle Identifier
FL_APP_IDENTIFIER

Thanks to @portellaa and @aeons for helping create and contributing to
cosigner, and to @hjanuschka for making the invitation to integrate into fastlane 🙇

@p4checo ✋  🎉
this is a great PR. i like it that you finally did it. the changes are great. looking solid to me.
i’d like to approve it and merge it however out of my long absence, i'd like to have atleast one other pair of :eyes:  on it.

Thanks @hjanuschka 🙌 🎊
It took (quite) a while, but it finally landed! 😆 Sorry for taking so long 😅

@p4checo thx for that great PR ❤


Update README

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind documentation
What this PR does / why we need it:
Reference to gocsi should be removed from README as gocsi is no longer maintained.
Which issue(s) this PR fixes:

Fixes #
#17
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

None

Looks good to me. Thanks. :)
/lgtm

/approved

Looks good to me. Thanks. :)
/lgtm

My pleasure. : )


Windows10 Alert Notification for matured coins

In Windows 10, when we receive a transaction we receive a notification in Action Center. It would be nice to see it for matured coins.

Hi, I try to avoid having to write platform specific code in the wallet , i will check it out and see if this is something simple.

The notifications of ROIcoin-QT appear on OSX as native notification, so that should be not platform specific code to achieve this, rather QT provides it for every platform.

@ghobson2013 @TheTDD Yes! The little I know it's just a messagebox that is handled differently in each OS. It would very useful to remember us to move our coins. Cheers!

https://github.com/ROIcoin/ROIcoin/releases/tag/v<IP_ADDRESS> has been released, closing this bug.

@TheTDD @ghobson2013 Very nice, thanks!


Conflict with Provider package

Hi. The Provider package is one of the most popular state management solutions available for Flutter, but we can't use it along with your package because there is a conflict, since you define the same name 'Provider'. In most cases it is not possible to stop using Provider, so we end up unistalling your package. Maybe change it so there are no conflicts in future versions?
Error below:
error: The name 'Provider' is defined in the libraries 'package:provider/src/provider.dart' and 'package:random_string/random_string.dart'. (ambiguous_import at [my_surgery] lib/screens/import_view.dart:124)
Thanks.

@lalo-vergel Thank you for letting me know and apologies for the trouble.  I'll see what I can do and will look into this tonight (PST time).

@lalo-vergel Please let me know if anything else is needed. Thank you again for letting me know of this need.


Ast errors: return an iterator

Follow up to this comment we might want ast.errors() to return an Iterator.
@lrlna Since the current errors() method takes self by reference, I'll probably go with an Iterator and not an IntoIterator, what do you think ? :)

yea definitely an Iterator so we can have a return type of Iter<'_> of sorts would be good!


Update Sample using Redisson and JCache

Purpose
The old sample use Redisson client directly, since the Redisson is an implementation of JCache API (JSR-107), update the sample to show how to use JCache and Redisson.
Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Other Information

Link https://github.com/MicrosoftDocs/azure-docs-pr/pull/260292

Thanks for your contribution, @backwind1233. Your code using Redisson+JCache would make a good new sample, but we probably want to keep this one using Redisson directly as-is. People use Redis/Redisson for other scenarios aide from caching, so we need to provide general samples not tied to caching.

Thank you for your feedback and for considering my contribution. I understand the importance of providing general samples that cover various scenarios with Redis/Redisson beyond caching. @philon-msft

I still think your sample code is very valuable - would you be willing to update this PR so it adds a new sample project called "java-redisson-jcache", as a sibling to the "java-redisson" directory?

Also make sure to add a git lightweight tag and direct the reader to check it out from the guide.

Hello @backwind1233 , I want to make the requested changes, but I am not a contributor to your fork of azure-cache-redis-samples. Can you please invite me so I can push commits to your fork?
edburns@Edwards-MBP azure-cache-redis-samples % git push backwind1233
git push backwind1233
ERROR: Permission to backwind1233/azure-cache-redis-samples.git denied to edburns.
fatal: Could not read from remote repository.

Thanks,
Ed

Close this pr, redirect to https://github.com/Azure-Samples/azure-cache-redis-samples/pull/44.


Inconsistent visiting of tree for Interpreter

Description
In some cases I wasn't able to pinpoint, some visitor function are weirdly ignored. Their children are visited, but neither the __default__ method nor the my_rule_overload method are called. The behavior is always the same between runs, even on different machines.
To Reproduce
My pet compiler project here: https://gitlab.com/aviallon/alang-compiler/-/tree/lark-bug consistently reproduces the behavior. Pay attention to Visiting: decorated_function, and then check the code in alang_compiler/ir/__init__.py :
    def decorated_function(self, tree: lark.Tree):
        debug(tree, "Called decorated_function")
        if tree.meta.decorator == "entrypoint":
            entrypoint_label = IRLabel("entrypoint")
            exit_status = self._new_var("exit_status", scope=[])
            function_identifier = scoped_identifier(tree.meta.decorated_function.meta.scope,
                                                    tree.meta.decorated_function.meta.name)
            argument_number = 2
            self.IRLabels += [entrypoint_label]
            self.IR = [QLabel(entrypoint_label),
                       QCall(exit_status, function_identifier, argument_number)] + self.IR

        # self.visit_children(tree)

You can see that I even commented out the self.visit_children(tree), yet its children are still visited, and the there is no Called decorated_function in the debug messages. Adding a breakpoint in the function does nothing... which clearly tells me that it is never actually called !

If the children are visited, but shouldn't be, put a breakpoint in one of them an check the stacktrace.

Yup, found out what happened. For some reason I was blind and didn't see that my visitor was defined twice...

@erezsh  perhaps showing a warning for dumb people like me if a visitor is redefined? (if that is actually possible to detect at all)

Happy to help either way.
i
Unfortunately I don't think there is a way to detect redefinition in Python. I wish there was.


requirements.txt doesn't include pandas

required for endpoint_checker.ipynb

Also needs shapely for new geoanalysis notebooks


Trace logging for tests

When investigating test failures, it can be helpful for there to be a record of some of the intermediate values that an endpoint encounters when executing. This is especially true for values that we send to and receive from interface boundaries such as PackageCache and PackageRunner.
The deliverable for this issue is a mechanism for weaving trace logging into our interface boundaries when running tests.
This comes from the following discussion on #106:

Regarding discouraging logging, I introduced the mixin trait because I wanted to generate this log when fixing test failures. It shows the status code and body content of the app creation request to Marathon. I needed this information because not all of it is provided in our response from the package install endpoint. What are some alternatives to logging that I could have used? Of course, a simple println works for one instance of local debugging, but that's not feasible in all cases.

@BenWhitehead and I discussed this some more offline. For my particular use case of needing more information when running tests during development, we arrived at a solution of development-mode logging. We'd still have log statements in the code, but they would only be enabled for local implementation and testing.

No activity in a while. Closing. I am sure this is going to come up again. We can create an epic at that time.


Added support for Starling Bank

Description:
Added support for Starling Bank.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#6236
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: starlingbank
    accounts:
      - name: "Spending Money"
        access_token: YOUR_PERSONAL_ACCESS_TOKEN
        balance_types:
          - 'cleared_balance'
          - 'effective_balance'

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @Dullage,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Hello @Dullage,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:

232b0fa113bdb58a9aa02fd48a19b501a0a5b8d9 - This commit has something that looks like an email address (adam@dullage.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

If you only made a single commit you should be able to rungit commit --amend --author="Author Name<EMAIL_ADDRESS>
(substituting Author Name and<EMAIL_ADDRESS>for your actual information) to set the authorship information.
If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:

You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.

Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! :heart:


Edit Text in Tabs Fragments

Hi!
I have 3 tabs with 3 fragments. First two are empty and the third have an edit text material. When i'm back to first and then i'm back to third but he give me forced close. In log say EditText$SaveState is not allowed 2 same id in hierarchy. It's wrong with save state on edit text?
Can you help me?
All the best!

I forgot the et_inputId to restore date ^_^


End-to-end test runnable on windows ci

A few updates and some scripts to run end to end tests on ci (windows only so far).

test this

Worked for me. Would be good to have info about how to run it in readme.

Readme updated and corrected a little

Thanks @jrichter1!


Add support for Rise slideshows in VSCode

Feature: Notebook Editor, Interactive Window, Python Editor cells
Description
Rise slideshows are really cool ways to show off and share a notebook with others. Native support for them in Vscode would be really cool! They're the only reason I still see a need to use Jupyters interface.
Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

There is a vscode plugin called vscode-reveal, this plugin however only works on markdown files.
In the vscode insiders edition it (vscode-reveal) also recognises the markdown in jupyter notebooks, however this is very buggy and nowhere near the quality of RISE.
If this buggy behaviour is fixed such that vscode-reveal has the same capabilities of RISE, it allows one to make presentations from jupyter notebooks and preview them inside of vscode. It does not have to be built into vscode.

There is a vscode plugin called vscode-reveal, this plugin however only works on markdown files.
In the vscode insiders edition it (vscode-reveal) also recognises the markdown in jupyter notebooks, however this is very buggy and nowhere near the quality of RISE.
If this buggy behaviour is fixed such that vscode-reveal has the same capabilities of RISE, it allows one to make presentations from jupyter notebooks and preview them inside of vscode. It does not have to be built into vscode.


Protocol to automatically set param.required based on constraints applied?

I'm working on a CLI with multiple, dynamic sources of defaults and pretty complicated rules for what parameters are required when, so I was pretty excited to discover Cloup's constraints. However, I was disappointed to realise that it only errors out when parameters are not provided, but doesn't participate at all in determining whether parameters are required from Click's perspective. This is unfortunate, since I also use the prompt mechanism to show the user the computed default and get missing required parameters for a better UI if running in the interactive mode, as there are a lot of parameters to study otherwise. With constraints as they currently exist, I still have to write all the custom logic to make sure things know when they are required and when to prompt, essentially duplicating it all.
I'm not 100% sure this is on the right track, but I think it should be possible to repurpose most of the existing constraints so that they can answer the question of "is this parameter required, according to my rules?", by basing them around a new method, is_required():
class Constraint:
    def is_required(self, param: click.Parameter, ctx: click.Context) -> bool:
        "Return whether param is required, based on the current state of ctx and this constraints logic"
        ...

    def check_values(self, params, ctx):
        return all(param_value_is_set(p, ctx.params[p.name])
                   for p in params if self.is_required(p, ctx))

As an example, for require_all, the result would always be True for parameters it applies to. For If, the result would depend on whether the condition is currently satisfied, and would then forward to the corrent branch's constraint.
A somewhat trickier part is making Option.required  use the appropriate constraint's is_required(), so the determination can be made using this new protocol. I'm not currently familiar enough with the internals of Cloup and Click to have a proper sense of how hard that would be. The overarching goal though is to make constraints augment the otherwise static boolean value, so that other mechanisms which look at it could work transparently from the single source of truth and not require me to encode the requirements in multiple places.
Obviously, there are still constraint that can't be fully expressed using this protocol, such as require_none, and those would just return False always and continue to use their existing implementation of check_values().

Alright, so I've been staring at this problem for a while now and clearly managed to confuse myself along the way. There is not really any built-in interaction between prompt and required in Click, so apologies for the confusion there. I do think, however, that it would still be useful to have a protocol that with is_required() and possibly also is_allowed(), so that intelligent decisions about things like prompting could be built with it.

I'm closing this. If you have a more concrete proposal, feel free to open another issue.


Updates to .bashrc even when other shell is used

Just tried it for Linux - very cool!
After installing, it updates my PATH in .bashrc - but I use nushell. Now, it's completely fair not to support all shells out there, but

MacOS uses zsh by default. I haven't tried Juliaup on MacOS, but please check that it updates .zshrc instead of .bashrc
The message after installation is "Run . ~/.bashrc to reload $PATH variable." - it should probably mention that it assumes you are running from Bash

Yep, completely forgot about that :) Next on my list. One question: for zhs, can we just add the same shell script fragment to .zshrc that we are adding to .bashrc, or is that not "valid" zhs?
Also, I think it would be fine to support as many shells as we can, so as long as we can figure out how to handle nushell, lets support it as well.

Valid bash code usually works in zsh as well. I'm happy to give it a try as a zsh user.

Ok, it now also supports zsh, and the printed messages are also no longer bash specific.


9.4.1-24 on 32 bit rasperrypOS Bookworm

Journal:
audit[749]: SECCOMP auid=4294967295 uid=106 gid=65534 ses=4294967295 pid=749 comm="dhcpcd" exe="/usr/sbin/dhcpcd" sig=31 arch=40000028 syscall=384 compat=1 ip=0xf7df6330 code=0x0
dhcpcd.service: Main process exited, code=killed, status=31/SYS
From what I can tell it appears systemd is killing the process because getrandom was called.
dhcpcd is started as a service.  I tried updating the systemd unit file to allow this syscall but it still gets killed.
Any hints appreciated.

This is fixed in the latest 9.5.1 and 10.0.6 releases already.
https://github.com/NetworkConfiguration/dhcpcd/commit/645c32dd1a511527b7eb88443a28dfe7704d5f52


Can I port it to SmartGaga?

I tried porting the chinese version of simple ESP to SmartGaga with success but it is CPU heavy. I am basically trying to develop ESP with Radar for SGaGa. I have also did a great bypass with 160+ matches played.

I tried porting the chinese version of simple ESP to SmartGaga with success but it is CPU heavy. I am basically trying to develop ESP with Radar for SGaGa. I have also did a great bypass with 160+ matches played.

hello sir , can you please share how did you port it to smartgaga i mean i been trying but it always refuses to let me draw on smartgaga i think it needs driver to read the process a small help would be much appreciated amte ^^

it works on smartgaga.


Post release with latest code changes

There were some code changes since your last release was posted several years ago, which I have been using from building it myself.  Mind posting a release for me to share a download link with non-developers?

Well, that took me longer than I'd like to admit. Done now.


Repo sync for protected CLA branch

The pull request is created from main637880801358301057 to main to fix git push error for protected CLA branch

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change. @evanwindom


Add emoji when bot reacted to text

Cool additional feature would be to add emoji automatically to the text that triggered Vacation Bot DM to author. That way we can see he is working in the shadows but is working :)

This is a tricky one. We can of course add custom emoji to our team and then use it for adding reactions. But there is no way of doing that automatically. We would have to ask people to add our emoji icon and name it the way we want it for this feature to work.


Modify DRAFT wording after LWG meeting

LWG did not review polymorphic wording yet but I've applied edits in keeping with what they wanted for indirect.

Numbering should be fixed but I'd be grateful for a double-check.


close only on clicking close

It would be nice to have this functionality so that user must click close to close the notification. I thought closeOnClick is for this purpose but no!
related to #82

Which "close" should user click?

I'd love to see an option for an 'X' in the top right corner of a notification that is used to close it.  With this option enabled, the only way to close the notification would be to click that 'X'.

i just did X in custom template


chore: simplify re-export

secret key is required for config
re-export makes it easier tot consume the crate without adding a verbose secp256k1 dependency

Codecov Report

Merging #2299 (75c07b1) into main (0761bb4) will decrease coverage by 0.06%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #2299      +/-   ##
==========================================
- Coverage   72.19%   72.14%   -0.06%
==========================================
  Files         472      472
  Lines       57083    57083
==========================================
- Hits        41209    41180      -29
- Misses      15874    15903      +29

Flag
Coverage Δ

integration-tests
19.16% <ø> (-0.01%)
:arrow_down:

unit-tests
66.82% <ø> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/net/network/src/config.rs
69.45% <ø> (ø)

... and 6 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


please help : Can Alpaca-Lora run on mac m1\m2 machines? Why does it require CUDA and report an error?

Can Alpaca-Lora run on mac m1\m2 machines? Why does it require CUDA and report an error?
error msg：
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/torch/cuda/init.py", line 371, in get_device_properties
_lazy_init()  # will define _get_device_properties
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/torch/cuda/init.py", line 221, in _lazy_init
raise AssertionError("Torch not compiled with CUDA enabled")
AssertionError: Torch not compiled with CUDA enabled

MPS support atm for PyTorch is pretty bad. CUDA is essentially a standard requirement if you're doing anything beyond basic ML.

On my M2
Python 3.10.10
OSX: 13.2
python finetune.py \                                                                                ─╯
    --base_model 'decapoda-research/llama-7b-hf' \
    --data_path 'yahma/alpaca-cleaned' \
    --output_dir './lora-alpaca'

I can train the model, but it make use on CPU which is very slow.

also the inference is extremely slow and will eventually go OOM


AVRO-3674: [Rust] Pass the correct enclosing namespace when validating and resolving

AVRO-3674
What is the purpose of the change

Fix a bug in schema resolution and validation when processing an inner schema with and without its own namespace

Verifying this change

New unit tests are added

Documentation

Does this pull request introduce a new feature? yes

New public methods are added. Documented with Rustdoc

Thank you for the report and the contributions, @RikHeijdens !


UATs (Inluding accessibility)

Accessibility testing should include WAVE and screen reader.

The only major issue WAVE found was the contrast in the top right navigation bar when it's highlighted:

The "home" text has low contrast
What would be nice to have and might warrant further discussion is making having links open on a new tab

There are a couple of things I noticed with keyboard controls:

The order of buildings when tabbing through them if not very sensible. It would be good if it went left to right or something like that
It's difficult to reach the "read more" link when you are viewing a building. This one would be tricky to solve.

Also, the "More Tweets" link on the following page is broken: http://<IP_ADDRESS>/location/r97/207

fixed the broken page. basically it had no SM account tag on it - probably best practice to have the STFC tag set by default


Change "Dataverse" to "Harvard Dataverse" on front end

This was a request from folks working on the Harvard Dataverse:
"On the Generalist Repositories list at https://data.niaid.nih.gov/ (https://data.niaid.nih.gov/), could the text Dataverse be changed to 'Harvard Dataverse'? There are multiple Dataverse repositories, and it looks like the Discovery Portal contains only datasets from Harvard's repository."

@DylanWelzel  can you change it in the metadata?

Change is live on https://data.niaid.nih.gov/


Pipe: introduce pipe_max_allowed_pinned_memtable_count param for realtime hybrid mode

As title.

Codecov Report

Merging #11505 (eb5743d) into master (1f51874) will increase coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 90.90%.

@@             Coverage Diff              @@
##             master   #11505      +/-   ##
============================================
+ Coverage     48.95%   48.98%   +0.03%
- Complexity    24592    24616      +24
============================================
  Files          2774     2774
  Lines        173346   173364      +18
  Branches      20780    20783       +3
============================================
+ Hits          84855    84922      +67
+ Misses        88491    88442      -49

Files
Coverage Δ

...r/realtime/PipeRealtimeDataRegionLogExtractor.java
41.79% <ø> (ø)

...va/org/apache/iotdb/commons/conf/CommonConfig.java
89.17% <100.00%> (+0.13%)
:arrow_up:

...rg/apache/iotdb/commons/conf/CommonDescriptor.java
96.14% <100.00%> (+0.05%)
:arrow_up:

...ealtime/PipeRealtimeDataRegionHybridExtractor.java
49.68% <91.66%> (+2.03%)
:arrow_up:

...g/apache/iotdb/commons/pipe/config/PipeConfig.java
26.43% <50.00%> (+0.55%)
:arrow_up:

... and 25 files with indirect coverage changes
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!


No requirements.txt file for pip installation.

An established way of managing dependencies is to have a requirements.txt file created with pip freeze > requirements.txt.  Users can then install all dependencies in one command from a terminal with pip install -r requirements.txt. This works well with a virualenv, #17.

Thanks for the suggestion, I'll add that in.

A requirements.txt file has been added and installation instruction for windows have been updated.


add prop to specify index

I need to be able to dynamically select which card to show

hello!  did you fine how to perform that ? I really need that feature too  😄

I did, I made some changes to the lib to support this... unfortunately I made the changes directly in my project's node_modules directory.  When I reset my modules I lost the changes :,(

@stantoncbradley could you paste it here?


Can VEX report have duplicate ids

According to the spec, vulnerabilities.id is:

The identifier that uniquely identifies the vulnerability.

Does this mean that vulnerabilities.id should be unique per VEX report?
If it doesn't need to be, in which use case would it make sense to list the same vulnerability multiple times?

The vulnerabilities.id is to be globally unique – not only in the universe of one CycloneDX document, but in general.
It could be a CVE identifier or a similar value.
see use cases: https://cyclonedx.org/use-cases/#vulnerability-exploitability
see examples: https://github.com/CycloneDX/bom-examples/tree/master/VEX

I think the question is: can the vulnerabilities field include more that one element with the same id.
The use cases for this are to enable to express that a specific CVE is relevant to more than one component, and to express the different analysis (and scores) relevant to that component.
For example, suppose both components A,B are binaries that include component C. The SBOM may include A and B, but not C (It may not have been visible to the SCA), but NVD data points that both A and B are vulnerable (due to their inclusion of C) to the same CVE.
The current CycloneDX structures enables (as far as I understand) to connect each vulnerability object to one bom-ref, so the way to point to A and B is by creating two vulnerabilitie objects. but the above answer suggests it is not legit.
I think it should be supported.
Hope I was clear.

I think the question is: can the vulnerabilities field include more that one element with the same id.

That is how I read it as well... the current schema has for vulnerabilities:
        "id": {
          "type": "string",
          "title": "ID",
          "description": "The identifier that uniquely identifies the vulnerability.",
          "examples": [
            "CVE-2021-39182",
            "GHSA-35m5-8cvj-8783",
            "SNYK-PYTHON-ENROCRYPT-1912876"
          ]
        },

and the "vulnerabilites" array has:
"uniqueItems": true,"
However, this is interpreted in diff. ways in code (and not based strictly in the ID). Often, the entire object has to me 100% duplicated (i.e., a deep clone)


Running Social network on a k8s cluster (without openshift)

Is there a way to deploy the social network benchmark on a k8s cluster without using openshift?
In order for the deployments to work the configmaps are needed but I can't use the scripts without using the OpenShift CLI.

Have you tried using helm chart for k8s deployment ?  https://github.com/delimitrou/DeathStarBench/tree/master/socialNetwork/helm-chart
That, i found, is the most convenient way.

Thank I haven't seen that there are helm charts for the project. I will try it out

Have you tried

Hi labros, i am trying to deploy social network on k8s too, and i using helm cmd as follow:
helm install social ./socailnetwork
And i make svc nginx-thrift a nodeprt, but i can not create any post, did i miss something？
Thx for ur help.


Space between label and the chart when position is 'Outside'

Hello, I tried adding outsidePadding which I assumed was to add space between label and the chart, but what it adds padding on the canvas instead.
Here's what I got initially.

Upon adding outsidePadding

Looks like the was working with PR #46 (before pieceLabel.padding was renamed to pieceLabel.outsidePadding in @emn178's 45d406be908855c26f9ff643332dee424dbc685e.
It looks like this issue was introduced in the above commit when in line 100,
var rangeFromCentre, offset = this.fontSize + this.padding

was replaced with
var rangeFromCentre, offset = this.fontSize + 2

I believe the correct version of this line should be:
var rangeFromCentre, offset = this.fontSize + this.outsidePadding

@emn178, can you confirm? Thanks for a fantastic plugin!

v0.11.0 add a new option textMargin for this. please try it.

Looks like this new prop solves the issue, thanks @emn178!


I found a broken link

This link is broken:
https://docs.docker.com/network/iptables.md
-- Doug

That url seems to work fine. Can you point me to the page where you found the broken link?

The link is broken, here is screenshot.

Looks like it should be without the .md extension; https://docs.docker.com/network/iptables/
Where did you find a link to that page?


rename zone on the ui

This isn't really an issue, i have set it all up and its working great on a 3 zone system.  I am very new to "go" as this being my first time using it at all. I was hoping you can help me rename the zones in the ui. Thank you

I am very sorry to have missed this over the last few months, but glad it's working for you and that it works on a 3-zone system, too.  to your question: the zone names come from the Infinity Control system itself, so you should see the same names as are displayed in your controller.  my fork of Infinitive doesn't allow changing those names, but you can do it from your main controller.  on mine it is done from the ADVANCED setup button, then select the ZONE NAMES option, and use the controller's buttons to edit the names.  instructions are on p. 35 of the little Homeowners Guide booklet or you can probably find it online or just figure it out from there.
please reply with more details if the names you are seeing in Infinitive are different from what shows on the thermostat (controller), and I can try to help.