borderStyle is ignored on Android unless set on all sides with non-zero borderRadius

[X] Review the documentation: https://facebook.github.io/react-native
[X] Search for existing issues: https://github.com/facebook/react-native/issues
[X] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
 React Native Environment Info:
    System:
      OS: macOS 10.14
      CPU: x64 Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz
      Memory: 523.12 MB / 16.00 GB
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 10.11.0 - /usr/local/bin/node
      Yarn: 1.9.4 - /usr/local/bin/yarn
      npm: 6.4.1 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
    IDEs:
      Android Studio: 3.1 AI-173.4907809
      Xcode: 10.1/10B61 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.5.0 => 16.5.0
      react-native: 0.57.4 => 0.57.4
    npmGlobalPackages:
      create-react-native-app: 1.0.0
      react-native-cli: 2.0.1
      react-native-git-upgrade: 0.2.7

Description
When the borderStyle property is set to dashed or dotted, Android will always render a solid border unless the borderWidth is set all around the element and a borderRadius greater than 0 is added. This means you cannot have a styled border on one, two or three sides.
Here's what it looks like in iOS and Android:

Seems like this is a regression which was mentioned in closed issues. The most recent is https://github.com/facebook/react-native/issues/18285
Reproducible Demo
Expo Snack: https://snack.expo.io/SkE6cNfT7
Repo: https://github.com/irasantiago/rn-android-border-style

Run in Expo application
System:
  OS: Android 8.0.0

With Expo 30.0.0 (RN 0.55.4) the issue is even worse, there is just no way to make dashed or dotted on a view border - not even with borderRadius.


Explain the concept of composalizable

The problem
While checking the (not-so) new behavior of does I found the concept of composalizable, which are classes that, even if they cannot be composed, behave as if they were.
Suggestions
Apparently just enums behave that way. But we'll have to research it a bit further.

Composalizable is mentioned in perl6/roast#402 as not specced yet.

Generally, archetypes are a mechanism that describe the way a certain kind of type behaves, and so answer questions like "does it make sense to inherit from this", "does it make sense to compose this", "can this thing turn into something I can inherit" (for example, you an is SomeRule, which results in inheriting from the pun), or "can this thing turn into something I can compose" (the role case that you asked about). The point was to avoid hardcoding things like "role", "grammar", and "class" into the compiler as special cases when deciding the contexts in which a type may be used, thus allowing for a more extensible meta-space.

Apparently just enums behave that way.

This matches my recollection. Here's the implementation of what it means to composalize an enum.

Ah, and to add: the archetypes were considered as something to eventually spec provided the design held up, so no objections to documenting.

El dom., 22 dic. 2019 a las 20:07, Jonathan Worthington (<
<EMAIL_ADDRESS>escribió:

Ah, and to add: the archetypes were considered as something to eventually
spec provided the design held up, so no objections to documenting.

Thanks!


Additional features

I added the additional features i needed from other forks along with one more feature that i needed into this fork

Ability to pass target path instead of chdir to the path first
Ability to access full endpoint information from within the templates
Ability to override and control the location of each endpoint independantly of the tag
Ability to raise exception for failed responses - failed responses by default are in the range [200, 300) - and can be explicitly set to be success or failure using the x-response-type property (can be one of: auto, success, failure)
Supports optional x-focus-path to create sync_focused/asincio_focused functions that target directly a specific path inside the parsed response
Supports additional optional template per endpoint for utility functions that wil be added to the generated module
Path to this optional template can be controlled independantly, and template can be linked per endpoint using x-utility-functions-template attribute

This PR will have to be split up into one-per-significant-change so that our changelog generation & versioning can function properly—that will also make it easier to figure out if some of these fixes/features are duplicates of other PRs. That's not to say that anyone involved so far needs to do this, just that it will have to happen before the changes merge. I need to update the contributing guidelines to make that more clear, right now it just vaguely mentions conventional commits 😞

@dbanty i will create separate PR for the features i worked on - but not for the features i pulled from other forks


Mapbox React Components migration gotchas doc

Studio has encountered some gotchas in migrating from Mapbox React Components to Mr-UI. It might be a nice thing to have a migration guide from MRC to Mr-UI. I'm not sure of how many teams are using MRC though, so if this guide would only really help the studio team, and we'd be writing it as we move through the migration, it might not really be worth the effort. What do y'all think?

I think there might not be big project like studio, migrating to Mr-UI. But it those are just some gotchas, it might be great to have a paper doc just documenting those gotchas. I believe the efforts put in to create this doc would be less in comparison to a formal guide, right? And we can always revisit the paper doc in future if need arises.

@kepta great point. I'm gonna try to get started on that this week.

@elifitch any update on this?

@kepta I have something started, that covers the components that we have migrated thusfar. I'll get that polished up and link it here.


assignment_3 done.

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

A3: Incomplete
Did not specify which model is the best model.

You must Select model based on optimal metric (RMSE or R^2?).
Generally uses GridSearchCV and obtains the best params or best pipeline directly (This was not complete)

Thank you for your feedback on my Assignment A3.
Could you please confirm if I should proceed with completing these missing parts and resubmit the assignment?

Yes please you can resubmit with the mentioned changes


how can i remove the edgeware from my pc

hello there, i have been trying to delete the edgeware folder from my pc, but it says that the programme is still running in the background. can anyone guide my please. (:

If this is still an issue, try looking for any Python or Edgeware processes in the task manager and closing them, you should be able to delete the folder then.


changes based on DOI infrastructure

Template of changes necessary in each Cookbook repo now.

Zenodo badges will fail link checker before relase


Fix delayed SSL server trace cleanup

I found one more bug related to the cleanup of server traces for SSL black-box propagation. Since we now delay requests generation for SSL too, so that we can produce accurate response times, we were cleaning up at the time of request generation, which with HTTP keep-alive might be on the next SSL request. This new SSL request might have different *ssl pointer and we won't cleanup the correct server ID, causing context propagation to fail.
With this PR I clean-up the SSL trace info immediately as the request is captured, not waiting for the delayed generation.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.25%. Comparing base (6162c54) to head (d723a67).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #942       +/-   ##
===========================================
- Coverage   75.74%   47.25%   -28.50%
===========================================
  Files         131      131
  Lines       10154    10154
===========================================
- Hits         7691     4798     -2893
- Misses       1939     5010     +3071
+ Partials      524      346      -178

Flag
Coverage Δ

k8s-integration-test
?

oats-test
?

unittests
47.25% <ø> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Select bugs out if the menu options are longer than the terminal width

It won't position the cursor correctly every time it re-renders.

This should have been fixed by #14.


New Feature 🔥

Is your feature request related to a problem? Please describe. 🤔
I've noticed that some of my code operating on the children of a TagRef' is now broken. Basically this seems to be because the children now appear as seq[Node] instead of seq[TagRef] when passed around as data.
Describe the solution you'd like 💡
Since making a TagRef through buildHtml only to take out a seq of children TagRefs is a bit convoluted, I thought it might would be a good time to implement some templates for creating seqs of to-be-rendered DSL data. I'd use something like this myself in my own development system if it wasn't integrated into happyx. Note that currently the TagRef based approach of buildHtmls fails and only the thunk based approach works in a straightforward way.

template thunkHtml(body: untyped): proc(): TagRef =
  proc(): TagRef = buildHtml:
    body

template thunkHtmls(body: untyped): seq[proc(): TagRef] =
  block:
    var res: seq[proc(): TagRef]
    template html(b: untyped) =
      res.add:
        proc(): TagRef = buildHtml:
          b
    body
    res

template buildHtmls(body: untyped): seq[TagRef] =
  block:
    var res: seq[TagRef]
    template html(b: untyped) =
      res.add:
        buildHtml:
          b
    body
    res

let htmlProcs = thunkHtmls:
  html:
    tSpan: "front"
  html:
    tSpan: "back"

let htmlTags = buildHtmls:
  html:
    tSpan: "right"
  html:
    tSpan: "left"

component FormatProcHtml:
  p: (proc (): TagRef) # parentheses needed in avoid "nested statements" error
  html:
    em(style="color:blue"): {self.p()}

component FormatTagHtml:
  t: TagRef
  html:
    em(style="color:blue"):
      {self.t.val}

appRoutes("ROOT"):
  "/":
    for i in 1..5:
      tDiv:{$htmlProcs[0]()}
      FormatProcHtml(htmlProcs[1])
    for i in 1..5:
      tDiv:{$htmlTags[0]}
      FormatTagHtml(htmlTags[1])

Solved in the next commit, thx


{ros2} Add required ROS2 SDK environment variables

This PR adds the following environment variable when the SDK is setup:
PYTHON_SOABI required to avoid setup failures with python packages
PYTHON3_NUMPY_INCLUDE_DIR required to using python opencv binding
PYTHONWARNINGS to suppress setuptool warmings
AMENT_SKIP_SHELL_PATH to prevent ament from prepending $OECORE_TARGET_SYSROOT/opt/ros/$ROS_DISTRO/bin to glocal PATH variable

If the Yocto enviroment variable ROS_SDK_UNIFY is not empty, $OECORE_TARGET_SYSROOT/opt/ros/$ROS_DISTRO/setup.bash or friends is source during SDK setup.

Still verifying this on master-next and styhead-next

@robwoolley I verify this by building examples, demos and example-interfaces with master-next and styhead-next.  We still have the issue of PYTHON_SOABI verses _PYTHON_SYSCONFIGDATA_NAME.  I have be unable to make the later work.

I have made a mess out of this, fixing now.


I0324 14:38:06     1 master.go:165] Start Seaweed Master 30GB 2.90 497ebbbd grpc server at <IP_ADDRESS>:19333

locally not reproduced:

make cluster
Get  Leader

curl -s http://<IP_ADDRESS>:9333/cluster/status | jq .
{
 "IsLeader": true,
 "Leader": "master0:9333",
 "Peers": [
   "master1:9334",
   "master2:9335"
 ]
}

restart not leader

docker restart seaweedfs_master2_1

seaweedfs_master2_1 exited with code 0
master2_1  | I0325 06:28:13     1 config.go:46] Reading : Config File "security" Not Found in "[/data /root/.seaweedfs /usr/local/etc/seaweedfs /etc/seaweedfs]"
master2_1  | I0325 06:28:13     1 config.go:46] Reading : Config File "master" Not Found in "[/data /root/.seaweedfs /usr/local/etc/seaweedfs /etc/seaweedfs]"
master2_1  | I0325 06:28:13     1 file_util.go:23] Folder /tmp Permission: -rwxrwxrwx
master2_1  | I0325 06:28:13     1 master.go:227] current: master2:9335 peers:master0:9333,master1:9334,master2:9335
master2_1  | I0325 06:28:13     1 master_server.go:289] [master.sequencer.type] : []
master2_1  | I0325 06:28:13     1 master_server.go:122] Volume Size Limit is 100 MB
master2_1  | I0325 06:28:13     1 master.go:138] Start Seaweed Master 30GB 2.95  at master2:9335
master2_1  | I0325 06:28:13     1 raft_server.go:82] Starting RaftServer with master2:9335
master2_1  | I0325 06:28:13     1 raft_server.go:143] current cluster leader:
master2_1  | I0325 06:28:31     1 tls.go:35] load cert:  / key:  error: open : no such file or directory
master2_1  | I0325 06:28:31     1 master.go:171] Start Seaweed Master 30GB 2.95  grpc server at master2:19335
master2_1  | I0325 06:28:31     1 masterclient.go:51] master masterClient bootstraps with masters [master0:9333 master1:9334 master2:9335]
master2_1  | I0325 06:28:31     1 masterclient.go:99] master masterClient Connecting to master master0:9333
master2_1  | I0325 06:28:31     1 masterclient.go:122] master masterClient Connected to master0:9333
master0_1  | I0325 06:28:31     1 master_grpc_server.go:278] + client master@master2:9335
master2_1  | I0325 06:28:35     1 master_server.go:165] leader change event:  => master0:9333
master2_1  | I0325 06:28:35     1 master_server.go:168] [ master2:9335 ] master0:9333 becomes leader.

Check Leader

curl -s http://<IP_ADDRESS>:9333/cluster/status | jq .
{
  "IsLeader": true,
  "Leader": "master0:9333",
  "Peers": [
    "master2:9335",
    "master1:9334"
  ]
}

but if enable -resumeState=true
the bug is reproduced
3.
seaweedfs_master2_1 exited with code 0
master2_1  | I0325 06:37:55     1 config.go:46] Reading : Config File "security" Not Found in "[/data /root/.seaweedfs /usr/local/etc/seaweedfs /etc/seaweedfs]"
master2_1  | I0325 06:37:55     1 config.go:46] Reading : Config File "master" Not Found in "[/data /root/.seaweedfs /usr/local/etc/seaweedfs /etc/seaweedfs]"
master2_1  | I0325 06:37:55     1 file_util.go:23] Folder /tmp Permission: -rwxrwxrwx
master2_1  | I0325 06:37:55     1 master.go:227] current: master2:9335 peers:master0:9333,master1:9334,master2:9335
master2_1  | I0325 06:37:55     1 master_server.go:289] [master.sequencer.type] : []
master2_1  | I0325 06:37:55     1 master_server.go:122] Volume Size Limit is 100 MB
master2_1  | I0325 06:37:55     1 master.go:138] Start Seaweed Master 30GB 2.95  at master2:9335
master2_1  | I0325 06:37:55     1 raft_server.go:82] Starting RaftServer with master2:9335
master2_1  | I0325 06:37:55     1 raft_server.go:143] current cluster leader:
master1_1  | I0325 06:38:13     1 master_server.go:165] leader change event: master0:9333 =>
master2_1  | I0325 06:38:13     1 master_server.go:165] leader change event:  => master2:9335
master2_1  | I0325 06:38:13     1 master_server.go:168] [ master2:9335 ] master2:9335 becomes leader.
master1_1  | I0325 06:38:13     1 master_server.go:165] leader change event:  => master2:9335
master1_1  | I0325 06:38:13     1 master_server.go:168] [ master1:9334 ] master2:9335 becomes leader.
master2_1  | I0325 06:38:13     1 master_server.go:175] [ master2:9335 ] master2:9335 is the leader.
master2_1  | I0325 06:38:13     1 tls.go:35] load cert:  / key:  error: open : no such file or directory
master2_1  | I0325 06:38:13     1 master.go:171] Start Seaweed Master 30GB 2.95  grpc server at master2:19335
master2_1  | I0325 06:38:13     1 masterclient.go:51] master masterClient bootstraps with masters [master0:9333 master1:9334 master2:9335]
master2_1  | I0325 06:38:13     1 masterclient.go:99] master masterClient Connecting to master master0:9333
master2_1  | I0325 06:38:13     1 masterclient.go:122] master masterClient Connected to master0:9333
master0_1  | I0325 06:38:13     1 master_grpc_server.go:278] + client master@master2:9335
master0_1  | I0325 06:38:14     1 master_server.go:165] leader change event: master0:9333 =>
master0_1  | I0325 06:38:14     1 master_server.go:165] leader change event:  => master2:9335
master0_1  | I0325 06:38:14     1 master_server.go:168] [ master0:9333 ] master2:9335 becomes leader.
filer_1    | I0325 06:38:16     1 masterclient.go:136] redirected to leader master2:9335
master0_1  | I0325 06:38:16     1 master_grpc_server.go:294] - client filer@<IP_ADDRESS>:8888
master2_1  | I0325 06:38:16     1 master_grpc_server.go:278] + client filer@<IP_ADDRESS>:8888
filer_1    | I0325 06:38:16     1 masterclient.go:163] + filer <IP_ADDRESS>:8888 leader:true
master0_1  | I0325 06:38:16     1 master_grpc_server.go:294] - client master@master1:9334
master1_1  | I0325 06:38:16     1 masterclient.go:136] redirected to leader master2:9335
master1_1  | I0325 06:38:16     1 masterclient.go:99] master masterClient Connecting to master master2:9335
master1_1  | I0325 06:38:16     1 masterclient.go:122] master masterClient Connected to master2:9335
master2_1  | I0325 06:38:16     1 master_grpc_server.go:278] + client master@master1:9334
master0_1  | I0325 06:38:16     1 master_grpc_server.go:294] - client master@master0:9333
master0_1  | I0325 06:38:16     1 masterclient.go:136] redirected to leader master2:9335
master0_1  | I0325 06:38:16     1 masterclient.go:99] master masterClient Connecting to master master2:9335
master0_1  | I0325 06:38:16     1 masterclient.go:122] master masterClient Connected to master2:9335

Check Leader

curl -s http://<IP_ADDRESS>:9333/cluster/status | jq .
{
  "Leader": "master2:9335",
  "Peers": [
    "master1:9334",
    "master2:9335"
  ]
}

master2_1  | [raft]07:40:42.336101 open.log.append log index  1
master2_1  | [raft]07:40:42.336187 open.log.append log index  2
master2_1  | [raft]07:40:42.336229 open.log.append: finish
master2_1  | [raft]07:40:42.336246 open.log.recovery number of log  2
master2_1  | [raft]07:40:42.336270 [master2:9335 Term:0] start from previous saved state
master2_1  | [raft]07:40:42.336291 Name: master2:9335, State: follower, Term: 0, CommitedIndex: 0
master2_1  | [raft]07:40:42.336933 [master2:9335 Term:0] server.peer.add:  master0:9333 0
master2_1  | [raft]07:40:42.336983 [master2:9335 Term:0] server.loop.run  follower
master2_1  | [raft]07:40:42.341252 [master2:9335 Term:0] server.peer.add:  master1:9334 1
master2_1  | [raft]07:40:42.343367 [master2:9335 Term:0] server.peer.add:  master2:9335 2
master2_1  | [raft]07:40:46.543780 [master2:9335 Term:0] server.loop.run  candidate
master2_1  | [raft]07:40:46.544269 peer.vote:  master2:9335 -> master1:9334
master2_1  | [raft]07:40:46.544298 peer.vote:  master2:9335 -> master0:9333
master1_1  | I0325 07:40:46     1 master_server.go:165] leader change event: master0:9333 =>
master1_1  | [raft]07:40:46.552000 [master1:9334 Term:1] server.rv.vote:  master1:9334  votes for master2:9335 at term 1
master2_1  | [raft]07:40:46.552644 peer.vote.recv:  master2:9335 <- master1:9334
master2_1  | [raft]07:40:46.553898 [master2:9335 Term:1] server.candidate.vote.granted:  1
master2_1  | [raft]07:40:46.554015 [master2:9335 Term:1] server.candidate.recv.enough.votes
master2_1  | [raft]07:40:46.554339 [master2:9335 Term:1] server.loop.run  leader
master2_1  | I0325 07:40:46     1 master_server.go:165] leader change event:  => master2:9335
master2_1  | I0325 07:40:46     1 master_server.go:168] [ master2:9335 ] master2:9335 becomes leader.
master2_1  | [raft]07:40:46.554424 [master2:9335 Term:1] leaderLoop.set.PrevIndex to  2
master2_1  | [raft]07:40:46.554626 peer.heartbeat:  master0:9333 113.98417ms
master2_1  | [raft]07:40:46.554884 peer.heartbeat:  master1:9334 113.98417ms
master2_1  | [raft]07:40:46.555051 [master2:9335 Term:1] server.command.process
master2_1  | [raft]07:40:46.555165 peer.heartbeat.flush:  master1:9334
master2_1  | [raft]07:40:46.555199 peer.heartbeat.flush:  master0:9333
master2_1  | [raft]07:40:46.555545 log.entriesAfter.partial:  2   0x1a837e0
master2_1  | [raft]07:40:46.555211 log.entriesAfter.partial:  2   0x1a837e0
master2_1  | [raft]07:40:46.555997 log.entriesAfter: startIndex: 0  length 3
master2_1  | [raft]07:40:46.556411 peer.append.send: master2:9335->master1:9334 [prevLog:2 length: 1]
master2_1  | [raft]07:40:46.555601 log.entriesAfter: startIndex: 0  length 3
master2_1  | [raft]07:40:46.557024 peer.append.send: master2:9335->master0:9333 [prevLog:2 length: 1]

i add debug
			glog.V(0).Infof("check existsPeerName server %s: raft: %s", existsPeerName, peer.ToGrpcAddress())
			if peer.ToGrpcAddress() == existsPeerName {

https://github.com/chrislusf/seaweedfs/blob/master/weed/server/raft_server.go#L120
master2_1  | I0325 09:55:58     1 raft_server.go:122] check existsPeerName server master0:9333: raft: master0:19333

Remove deleted peers
it doesn't work

Fixing the work of snapshots led tohttps://github.com/chrislusf/seaweedfs/issues/2833

@chrislusf The presence of snapshots on several master servers at startup causes conflicts when choosing a leader.
Also, if there is a snapshot, the log index will be non-zero, which makes the candidate master and leads to re-elections, where the candidate always becomes the master.
It worked while the raft was created without logs and snapshots.

@chrislusf  I did not see the point in repairing the current raft. Since I plan to store the full topology also in the raft.
This will allow you to have standby masters with a complete topology, which will significantly reduce the service unavailability time when changing the master
https://github.com/chrislusf/seaweedfs/pull/2868

with raftBootstrap=false max volume restored from raft logs
master2_1  | 2022-04-04T13:40:55.937Z [INFO]  raft: pipelining replication: peer="{Voter master1:9334 master1:19334}"
master2_1  | I0404 13:40:55     1 raft_server.go:82] max volume id 0 ==> 1
master2_1  | I0404 13:40:55     1 raft_server.go:82] max volume id 1 ==> 2
master2_1  | I0404 13:40:55     1 raft_server.go:82] max volume id 2 ==> 3
master2_1  | I0404 13:40:55     1 raft_server.go:82] max volume id 3 ==> 4
master2_1  | I0404 13:40:55     1 raft_server.go:82] max volume id 4 ==> 5
master2_1  | I0404 13:40:55     1 raft_server.go:82] max volume id 5 ==> 6
master2_1  | I0404 13:40:55     1 raft_server.go:82] max volume id 6 ==> 7
master2_1  | I0404 13:40:55     1 raft_server.go:82] max volume id 7 ==> 8
master2_1  | I0404 13:40:55     1 raft_server.go:82] max volume id 8 ==> 9
master2_1  | I0404 13:40:55     1 raft_server.go:82] max volume id 9 ==> 10
master2_1  | I0404 13:40:55     1 raft_server.go:82] max volume id 10 ==> 11
master2_1  | I0404 13:40:55     1 raft_server.go:82] max volume id 11 ==> 12

sw moved to hashicorp raft https://github.com/chrislusf/seaweedfs/pull/2868


externally synchronize our use of the static SimpleDateFormat

When running testng multi-threaded, multiple TimeBombSkipExceptions in different tests will occasionally die with a parsing exception. Given the choice of making SDF not static or adding the synchronized, I just added the synchronized - but I don't have a preference either way.

:+1:


Fix broken assumption about transaction order in TRANS_DELETE_02.

The listTransactions endpoint makes no promises about the ordering of transactions.
Therefore, our integration test suite should not rely on any assumptions about ordering.
In particular, we shouldn't assume that the transaction we've just created is at the head of the list.

Actually, there are many other tests like this. I'll create a Jira ticket to capture this work.

@jonathanknowles , can we close this ?

Outdated, closing.


Update insert() to return a one or multiple docs based upon incoming data

On insert(), if the incoming 'newDoc' is an array of documents, then the callback should return the final array of documents. Otherwise, return just the first.
This is a fix for #20 and #33

Thanks, appreciated!


Support for env vars in commands.

FOO=bar ls
FOO="bar baz" ls

This sort of thing is really handy at times. It is probably not difficult to support, we can consider deprecating in-env if this is implemented.

Potential problems/things to think about:

Janet symbol rules can't distinguish some cases, probably workable with the parser:

(= '(Foo="bar ") '(Foo= "bar ")  )

How do you run a command with an = in the binary name? how does sh deal with this?

Implemented.


Allow extension user to include logging-manager on management interface into openApi *swagger)

it is a follow-up issue of the https://github.com/quarkiverse/quarkus-logging-manager/issues/200
logging-manager works ok on management port and path.
however, there is a condition in the processor that prevents logging-manager endpoints to be added into the openapi/swagger.
https://github.com/quarkiverse/quarkus-logging-manager/blob/961f1d8ee63b388bde68eb5e774629cb177e4239/deployment/src/main/java/io/quarkiverse/loggingmanager/deployment/LoggingManagerProcessor.java#L101
having the special config property to include/exclude logging-manager from the openApi it seems ok to remove the condition !managementConfig.enabled mentioned in the above line. thus, extension user can decide whether to include it in openApi or not independent on management interface configuration.

@all-contributors add @alex-kovalenko1982 for idea

Deployed 3.3.1


Update copyright headers

Some new files were added recently, this will need to be updated.

Applied to main (=2.1) and branch 2.0.


Write sample in azure-spring-boot-samples about AAD B2C + spring-security + web-flux

Please refer to parent issue for more information: #25817

Closing this issue because there is not customer ask for this feature. Reopen this feature if customer ask for this feature.


Exclusion criteria missing for some fMRIPrep visual report sections

Currently, explanation or exclusion criteria are missing for the following sections of the fMRIPrep report:

[ ] Summary
[ ] Anatomical conformation
[ ] T2* map
[ ] T2* GM values
[ ] Variance explained by Compcor components

These were not covered with #386.

I'm closing this issue in favor of breaking each bullet point into a separate issue


@apply with !important not working.

UnoCSS version
0.55.0
Describe the bug
css code below
.test {
  @apply text-blue !important;
}

not transform to
.test {
  --un-border-opacity: 1 !important;
  border-color: rgba(96,165,250,var(--un-border-opacity)) !important;
}

not same behavious as TailwindCSS @apply
Reproduction
see the demo of codesandbox.
System Info
No response
Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[x] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

.test {
-  @apply text-blue !important;
+  @apply !text-blue;
or
+ @apply important-text-blue;
}

.test {
-  @apply text-blue !important;
+  @apply !text-blue;
or
+ @apply important-text-blue;
}

It's a good solution, but someone often use tailwindcss may not know that.
Does it necessary to add @apply text-blue !important; or not.

I think we should focus on writing the atomic utility(with some variants), try to avoid mixing with traditional css.


Versioning Feature

Currently blocked by - https://github.com/onflow/developer-portal/projects/2#card-85921921

Closing this issue as this work has been broken down into smaller tickets to complete this task:
https://github.com/onflow/developer-portal/issues/705
https://github.com/onflow/developer-portal/issues/706
https://github.com/onflow/developer-portal/issues/707
https://github.com/onflow/developer-portal/issues/708
https://github.com/onflow/developer-portal/issues/709


Some codes may be conflict with paper

Hi,
https://github.com/ymcui/Cross-Lingual-MRC/blob/fea66c0859af8b13089a9af88ac54fc9f9f96691/src/layers.py#L374
I think here, input_tensor instead of source_input_tensor

Hello,
Thank you for pointing out this issue.
There is a typo in the equation 7, where LayerNorm(B_T + R) should be replaced with LayerNorm(B_S + R), as B_T will be concatenated afterwards (as in line https://github.com/ymcui/Cross-Lingual-MRC/blob/fea66c0859af8b13089a9af88ac54fc9f9f96691/src/layers.py#L376).

Thanks for your reply.


Rename .travlis.yml to .travis.yml

Incorrect filename for TravisCI.
Feel free to disregard this PR if the file is named .travlis.yml for any specific reason.

Thanks for the PR! We don't actually use travis for this project (must be a hold over). I will open a PR to delete it.

@kevgliss No worries! Thank you!


Binding between picker view text and textfield

Hi,
I want to bind the text of a picker view to the text of a textField.
my data source and other stuff:
var activityPickOptions = ObservableArray(["Programming", "Resting", "Walking", "Eating", "Working"])
var pickerView = UIPickerView()
let actTextField: UITextField = UITextField(frame: CGRectMake(40, 10, 120, 25))
and inside below function I want to bind the selected row's text to textfield:
func pickerView(pickerView: UIPickerView, didSelectRow row: Int, inComponent component: Int) {
}
Thanks in advance for your help!
Regards,
Manish

Thanks I found the workaround:
func pickerView(pickerView: UIPickerView, didSelectRow row: Int, inComponent component: Int) {
let name  = Observable(activityObservableArray[row])
name.map{ "($0)" }.bindTo(actTextField.bnd_text)
}


Looking for maintainers

This project could use some ❤  from you guys!
I'm looking for one or two people to help move this project forward. First step would be going through the PRs and issues. Then we'll take it from there!
Any takers? 😄

@dannycork offered his help! let me know if anyone else would like to help out. Thanks!

I am an extreme newbie. And this would be my first effort to contribute. So if desperate ... I'm happy to help. (Or at least learn how to help.)

@janicewilson Hey thanks for the offer to help! We're all newbies at some time.
Finding solutions to other people's issues is always helpful. Also using the library yourself and finding your own issues and then fixing them is very much appreciated.

I can probably help with the maintenance, I think.

Hey @matthewmueller I first used x-ray to make some scrapers for a local company a few years ago and fell in love with its simplicity. I'm currently working on a scraper for a side project and noticed some selectors (a@href for example) weren't working the same as they used to. Consequently, I had to start creating parsers with cheerio. I assumed that this project was no longer being maintained and considered emailing you to ask if you needed assistance. Today I saw the #304 and realized that this project is still active. I'd like for other people to enjoy the same experience I did when I first used x-ray so I'm willing to help.

I’m also willing to help. Especially going through and cleaning up issues. (I’m not yet comfortable enough with the codebase to approve PRs.)

Awesome, just added you to the repo @lathropd. Thanks!

Hey @janicewilson did you still want to help out with the project?

I am interested in assisting with the project. Are there any CLAs or other formal requirements to contribute?

Sorry for the late reply here, no CLAs. Just your interest and time ☺

Hi,
are you still looking for some maintainers?
Cheers Tobias


Site down

Hey you probably know this but I don't see an active issue for it.

Been happening for a few days now and some other friends of mine (We're in New Zealand) have it down too
Can't download and run it either, just says it can't connect to the site

down on my end too, in canada - seems like the domain expired

Heyl yeah! It's open again and looks dope, glad it got up again I just got two flags for a CTF I'm currently doing within the span of 10 minutes with it, such a useful tool


Terminate in case of ext host IPC timeout

This fixes a potential ext. host leak
The scenario is the following:

ext host starts
some listener, say timer, is started during the startup process
in 60s we don't receive IPC socket, and reject
rejection goes up to the main function
we have a timer, and it keeps the process alive
as a result we have a process leak

cc @alexdima

Thank you!


[Content]:

What article on segment.com/docs is affected?
https://segment.com/docs/connections/destinations/catalog/exponea/
What part(s) of the article would you like to see updated?
All references to Exponea should be changed to "Bloomreach Engagement".
Exponea was acquired by Bloomreach in 2021 and product was renamed after.
( proof - click on any links on current page for redirects to bloomreach.com page ).
Links to www.exponea.com should be changed to https://www.bloomreach.com/en/products/engagement
Lins to API groups ( https://docs.exponea.com/reference#setting-up-access-keys )  should be changed to https://documentation.bloomreach.com/engagement/reference/authentication
group permissions to https://documentation.bloomreach.com/engagement/reference/authentication#using-the-api-groups
Links for automatic session tracking changed to https://documentation.bloomreach.com/engagement/docs/system-events#section-first-session-session-start-session-end
Thank you for understanding and this branding change. Functionality is identical, everything else is the same.
Additional information
No response

Hi @nabucho, is the support email that's currently on the page still correct (support@exponea.com), or is there a new email I should include?

As confusing as it sounds, yes the email remains the same....
Also, can we remove the Beta designation as well while on it?
And redirect the URL from https://segment.com/docs/connections/destinations/catalog/exponea to https://segment.com/docs/connections/destinations/catalog/bloomreach ?

Hey @nabucho - I'll be updating the name for the integration. Do you have a mark and default logo for the integration we could use? These will need to be in SVG format

Look if these work

Archive.zip

thanks @nabucho - I've update Exponea to Bloomreach Engagement in our internal catalog. @forstisabella you can go ahead with the doc changes now

Perfect - thank you so much @tcgilbert!!


Add authorization to every endpoint

I'm waiting for some pull requests to be approved and merged so I can start on this. I reviewed any that were related that I was listed on.

splitting this up into separate issues


Command Select Project fails with extension manifest validation error

Issue Description
Steps to Reproduce

Ctrl-Shift-P: "OmniSharp: Select project"
Error is shown

Expected Behavior
Opens up the project picker.
Actual Behavior

Command 'OmniSharp: Select Project' resulted in an error (Extension 'ms-dotnettools.csharp' CANNOT use API proposal: quickPickSeparators. Its package.json#enabledApiProposals-property declares: [] but NOT quickPickSeparators. The missing proposal must be added...

Logs
OmniSharp log
Post the output from Output-->OmniSharp log here
C# log
Post the output from Output-->C# here
Environment information
VSCode version: 1.63.0
C# Extension: 1.23.17
Mono Information
        OmniSharp using built-in mono
Dotnet Information
.NET SDK (reflecting any global.json):
 Version:   6.0.100
 Commit:    9e8b04bbff
Runtime Environment:
OS Name:     ubuntu
OS Version:  20.04
OS Platform: Linux
RID:         ubuntu.20.04-x64
Base Path:   /usr/share/dotnet/sdk/6.0.100/
Host (useful for support):
Version: 6.0.0
Commit:  4822e3c3aa
.NET SDKs installed:
2.1.818 [/usr/share/dotnet/sdk]
3.1.415 [/usr/share/dotnet/sdk]
5.0.403 [/usr/share/dotnet/sdk]
6.0.100-rc.1.21458.32 [/usr/share/dotnet/sdk]
6.0.100 [/usr/share/dotnet/sdk]
.NET runtimes installed:
Microsoft.AspNetCore.All 2.1.30 [/usr/share/dotnet/shared/Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.30 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.21 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.12 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.0-rc.1.21452.15 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.0 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.30 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.21 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.12 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.0-rc.1.21451.13 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.0 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

azure-account
ms-vscode
0.9.11

azure-pipelines
ms-azure-devops
1.195.0

cmake
twxs
0.0.17

cmake-tools
ms-vscode
1.9.2

cpptools
ms-vscode
1.8.0-insiders2

csharp
ms-dotnettools
1.23.17

dotnet-test-explorer
formulahendry
0.7.7

EditorConfig
EditorConfig
0.16.4

jupyter
ms-toolsai
2021.11.1001550889

jupyter-renderers
ms-toolsai
1.0.4

live-server
ms-vscode
0.2.11

LiveServer
ritwickdey
5.6.1

prettier-vscode
esbenp
9.0.0

python
ms-python
2021.12.1559732655

sass-indented
syler
1.8.18

test-adapter-converter
ms-vscode
0.1.4

vetur
octref
0.35.0

vscode-azureappservice
ms-azuretools
0.23.0

vscode-azurefunctions
ms-azuretools
1.6.0

vscode-azureresourcegroups
ms-azuretools
0.4.0

vscode-azurestaticwebapps
ms-azuretools
0.9.0

vscode-bicep
ms-azuretools
0.4.1008

vscode-docker
ms-azuretools
1.18.0

vscode-dotnet-runtime
ms-dotnettools
1.5.0

vscode-eslint
dbaeumer
2.2.2

vscode-kubernetes-tools
ms-kubernetes-tools
1.3.4

vscode-pylance
ms-python
2021.12.1

vscode-test-explorer
hbenl
2.21.1

vscode-yaml
redhat
1.2.2

vsliveshare
ms-vsliveshare
1.0.5196

xml
DotJoshJohnson
2.5.1

Getting the same error:
Command 'OmniSharp: Select Project' resulted in an error (Extension 'ms-dotnettools.csharp' CANNOT use API proposal: quickPickSeparators.
Its package.json#enabledApiProposals-property declares: [] but NOT quickPickSeparators.
The missing proposal MUST be added and you must start in extension development mode or use the following command line switch: --enable-proposed-api ms-dotnettools.csharp)

Issue was fixed in https://github.com/OmniSharp/omnisharp-vscode/pull/4914. Until a new release is ready you can install this prerelease that includes the fix https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.23.18-beta2

Does anyone know how to install an old working version until a fix is released? My VS Code is basically bricked now. (Installing a prerelease sounds a bit scary)

Does anyone know how to install an old working version until a fix is released? My VS Code is basically bricked now. (Installing a prerelease sounds a bit scary)

Old version of omnisharp won't work, I believe it was broken by vscode 1.63, so you either move back to 1.62 or install the pre-release of omnisharp.

Does anyone know how to install an old working version until a fix is released? My VS Code is basically bricked now. (Installing a prerelease sounds a bit scary)

Omnisharp can't be downgrade, but downgrading vscode you resolve this problem. https://code.visualstudio.com/updates/v1_62

Even after installing the latest prerelease this issue still occurs.

Is there prerelease versions which don't include the fix and I need to download exactly 1.23.18?

I found that the solution was to completely uninstall the old version and then choose the extension vsix file for my platform from the beta release page and install that:
https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.23.18-beta2

There have been lots of improvements since this issue was opened. Please open a new issue with logs if you are still running into this.


[Task] Implement the IOTA DIDComm Connection protocol

Description
Implement the IOTA DIDComm Connection protocol using the actor.
Motivation
Add DIDComm support for the actor in a specified way.
Resources
https://wiki.iota.org/identity.rs/specs/didcomm/protocols/connection
To-do list
Create a task-specific to-do list. Please link PRs that match the To-do list item behind the item after it has been submitted.

[ ] Implement #841.
[ ] Implement the IOTA DIDComm protocol in the actor.

Change checklist
Add an x to the boxes that are relevant to your changes, and delete any items that are not.

[ ] The feature or fix is implemented in Rust and across all bindings whereas possible.
[ ] The feature or fix has sufficient testing coverage
[ ] All tests and examples build and run locally as expected
[ ] Every piece of code has been document according to the documentation guidelines.
[ ] If conceptual documentation (mdbook) and examples highlighting the feature exist, they are properly updated.
[ ] If the feature is not currently documented, a documentation task Issue has been opened to address this.

We have no plans to add DIDComm support


Directions

Can you please  provide instructions  for inputting commands and not just pictures.

any command you can do from the terminal


Update past teams, to have every member of the team

Add the remaining members.
Update the page structure to look similar to the latest team page.

claim


Add a way to bootstrap the build config

Running go run /path/to/build.go is not ideal since it relies on the host's go version. Provide a way to build the "build.go" using a stable go version.

Provide built-in bootstrap target to build itself and have the user only use that. However, it requires the user to have knowledge of said bootstrap target and remembering to run the binary
Release a yabs binary to facilitate the building of the go file and caching the built binary. You can use yabs to call the resulting binary and pass cmd args to that

Configuring the build like a https://magefile.org/ would be ideal, as we would still be writing Go but with less boilerplate, we'd also not have to keep it in a separate package just to have the singular main function. Magefile gets the AST of the build, but it has to keep in mind numerous imports and it seems like edge-case hell.
Another alternative would be to do similar way like lunarway/shuttle where they generate a separate main.go file and build that.
For instance:
// build.go

import "github.com/jakegut/yabs"

bs := yabs.New()

func Build(ctx yabs.BuildCtx) {
    ctx.Run("...").Exec()
}

bs.Register("build", Build)

func Release(ctx yabs.BuildCtx) {
   // depends on Build
}

bs.Register("release", "build", Release)

And take that and: hoist the imports, move the body into a main func:
import "github.com/jakegut/yabs"

func main() {
    bs := yabs.New()

    func Build(ctx yabs.BuildCtx) {
        ctx.Run("...").Exec()
    }

    bs.Register("build", Build)

    func Release(ctx yabs.BuildCtx) {
        // depends on Build
    }

    bs.Register("release", "build", Release)
}

Another way to maybe utilize the init function, define targets in there, and just have a main.go just import the necessary import.

A different approach would be to use an interpreted language to config the build.
One option is https://github.com/risor-io/risor, it's new so it's API may leave much to be desired in terms of custom builtins, types, and go interop. Starlark is another option with a brief example of a custom type with methods in this repo.
However, with an interpreted language comes with the difficulty of importing code outside of the repo. We would have to figure out a way to import and/or package code.

Thinking risor is the way to go since this issue isn't relevant anymore


kernel: Fix a typo in README

Fix a typo in README.
Fixes: #720
Signed-off-by: Nitesh Konkar<EMAIL_ADDRESS>

/test

/AzurePipelines run


The requested module is a CommonJS module, which may not support all module.exports as named exports.

I have trouble using rxfire with SvelteKit using adapter-static. When running in dev mode I don't have any issue but when building my app I go troubles...
First, I import the auth package like that : import { authState } from "rxfire/auth";.
Which gaves me:
import { authState } from "rxfire/auth";
         ^^^^^^^^^
SyntaxError: Named export 'authState' not found. The requested module 'rxfire/auth' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'rxfire/auth';
const { authState } = pkg;

So, I did import * as rxfireauth from "rxfire/auth"; const { authState } = rxfireauth; and...
I got this now:
(node:88773) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
/Users/scorsi/projects/calicut/front/node_modules/rxfire/auth/index.esm.js:1
import { onAuthStateChanged, onIdTokenChanged, getIdToken } from 'firebase/auth';
^^^^^^

SyntaxError: Cannot use import statement outside a module...

The version installed :

firebase: 9.6.6
rxfire: 6.0.3

This may be related to #48 but I don't technically use SSR at all :)
Temporary workaround: disabling page prerendering in svelte.config.js (but I lose all interests of using SvelteKit lol):
kit: {
  adapter: adapter({fallback: "index.html"}),
  prerender: {
    enabled: false
  },
},

I can create a repro project next week if needed.

Hey @scorsi! If you could create a small MVCE (minimal, complete and verifiable example) that would be super helpful for debugging purposes. I'm a big SvelteKit fan, so I'm happy to make sure it's a smooth ride.

I have the same issue @scorsi
this was fixed (issues #17), (PR #23), but there has been no new release since then
you can set "type":"module" in rxfire's package.json files during builds or try to disable sveltekit ssr globally
I think that would be done using hooks

@davideast to replicate:
npm init svelte@next my-app # Sveltekit Skeleton project w/ typescript, no eslint or prettier
cd my-app
yarn
yarn add @sveltejs/adapter-static@next
yarn add rxfire firebase rxjs
sed -i 's/adapter-auto/adapter-static/g' svelte.config.js
echo "<script> import { authState } from 'rxfire/auth'; authState(); </script>" > ./src/routes/index.svelte
yarn build

I've got the exact same issue (rxfire being cjs) trying to use adapter-node with current sveltekit in order to prepare an app I'd like to host on firebase.

@fishsticks89 thanks for the repro steps !!

Any updates around this?  I was converting to a sveltkit project and am currently running into this problem as well

Me too :(

This is quite a bummer and I have no idea what causes this :(

Quick fix: Modify node_modules/rxfire/auth/package.json to look like this
{
  "name": "rxfire/auth",
  "browser": "index.esm.js",
  "main": "index.cjs.js",
  "module": "index.esm.js",
  "typings": "index.d.ts",
  "sideEffects": false,
  "type": "module",
  "exports": {
    "import": "./index.esm.js",
    "require": "./index.cjs.js"
  }
}

Added content
"type": "module",
  "exports": {
    "import": "./index.esm.js",
    "require": "./index.cjs.js"
  }

This obviously gets overwritten when changing dependencies. Similar issue discussed by SvelteKit maintainers


Deploy www web app to AWS

Resources
Deploying fastboot app wth ember-cli-deploy
https://www.effective-ember.com/blog/deploying-fastboot-apps-with-ember-cli-deploy/
AWS official blog
https://aws.amazon.com/blogs/developer/creating-and-deploying-a-serverless-web-application-with-cloudformation-and-ember-js/
ember-cli-deploy links
https://github.com/ember-cli-deploy/ember-cli-deploy-fastboot-app-server-aws
http://ember-cli-deploy.com/docs/v1.0.x/s3-walkthrough/
Fastboot deployment guide
https://ember-fastboot.com/docs/deploying

Deployment with Docker resources

https://discuss.emberjs.com/t/build-ember-cli-application-for-docker/9483
https://github.com/madnificent/docker-ember
https://github.com/NullVoxPopuli/dockerized-ember-cli
https://blog.back4app.com/how-to-deploy-an-ember-js-application/#:~:text=Once you've created the,to give your Docker image. (some of this we can use for reference)
https://medium.com/@fro_g/ember-nginx-in-docker-with-multi-stage-builds-5ae3b0930318

Steps to run docker on local

Run docker build . to build image.
After image gets created run docker images to see the images, copy the id of latest image(which got build just now)
Run the image with command docker run -p 5000:5000 <IMAGE_ID>
Go to http://localhost:5000/ and we will see our app running.


Where should we update interactions in the simulation process when a contact collision algorithm is in the loop?

This issue is a follow-up of the PR #241.
The question is when we should call
updateWorldFromDS();
updateInteractions();
updateContactsFromChangeLog();

Several options:

per each time step
per each Newton loop

It is a bit tricky because if we update only at the beginning of the time-step, the local frame at contact (related to the Jacobian matrices of constraints) is constant over the time--step and the number of interactions is fixed.
In the Newton loop, we would like to update the local frames at contact (and/or Jacobian matrices of the constraints), to  be more accurate especially if there are some large finite rotations. The problem that we face for the moment, is the fact that some interactions may appear or disappear at each Newton iterations. This can cause some instability in the Newton method.
We would need to have only an update of the existing local frames without creating or deleting interactions. I do not know if it possible with the current API of bullet and our coupling.

One idea that I had on this was to call it in the loop, but only ever add contacts and never remove them.  (Per time step, of course, not over the whole sim.)  This would maintain numerical stability (I think), while still allowing them to be created when necessary.  It is tricky, I agree.

We would need to have only an update of the existing local frames without creating or deleting interactions.

I did however modify the contacts to be maintained in the local frame by recalculating _pc1/_pc2 from members _relPc1 and _relPc2 back in 01a06f2cfa5db43cf

closed. see #365


Updated Campaign Maps

Ahriman' Gift campaign will now only use DARIUS_JAVIDAN, MISTRESS_VASHTI, and SAR_LASHKAR, and not their various other versions which can now be safely overwritten. Updated AIs to not reawake KING_ULRIC, KARG, and DHAVRUM_BELRAAG so they can be used in MP

So quick comment on this:
You've given me an idea to get more organised later. The multiplayer/skirmish version of Sar Lashkar is actually Sar_Lashkar2, not the first one. First one is the campaign version. However, since Sar Lashkar, Amon Koth and Shohn Maht were heroes ported over from the special edition and included in 1.3.10, they are actually custom files and not in the .tgw. So what we're going to do is delete the custom versions, copy all of their stats to the campaign versions, and remove the boss tags from them so they become the multiplayer versions instead. This'll allow us to use our own filenames for new heroes instead of having both Sar_Lashkar and Sar_Lashkar2 for completely different heroes.
Mistress_Javidan and Mistress_Vashti are the campaign only versions, we need to use Vashti for everything. Look for the boss = 1 tag in their ini files, it'll tell you whether or not they are used in multiplayer.


nz-table column width doesn't decrease on resize

Reproduction link
https://angular-hquq8a-r8smqv.stackblitz.io
Steps to reproduce

Add nz-table with 1 fixed width (nzWidth="100px") column and another fluid column (without nzWidth)
Increase window size
Decrease windows size

What is expected?
Second column (without nzWidth) width is decreased back to fit available space, no horizontal scroll appears.
What is actually happening?
Second column (without nzWidth) width stays increased, horizontal scroll appears.

Environment
Info

ng-zorro-antd
13.0.1

Browser
Firefox

Related to https://github.com/NG-ZORRO/ng-zorro-antd/issues/5227
@vthinkxie commented that "without nzWidth, ng-zorro-antd will auto calc the nzWidth every time".
But actually it calcs only on windows size increase, not when you decrease it back.

Same issue: https://ng-zorro-antd-ivy-fqgt7f.stackblitz.io
When nzTableLayout="fixed" & [nzScroll]="{ x: '100%' }". After updating view (bootstrap column in example) – width of table is not updating.

Still a problem in the latest version.

The problem in version 17.4.0 is reproducible.
If you delete th in thead - tr, then the size changes, perhaps this will somehow help the developers in the solution.


Adds support for multi containers pod for seccomp-profile.

Hi.
With this PR, I enabled seccomp-profile to work on pods with several containers inside.
The idea is to generate a seccomp profile which contains the union of all syscalls used by containers within this pod.
The union works like this:
Container X: [syscallA] = 0, [syscallB] = 1, [syscallC] = 0, [syscallD] = 0
Container Y: [syscallA] = 1, [syscallB] = 0, [syscallC] = 1, [syscallD] = 0
Union:          [syscallA] = 1, [syscallB] = 1, [syscallC] = 1, [syscallD] = 0
I check the above behavior running a pod with two containers (nginx and mariadb) and running them separately in dedicated pods:
# test contains two containers
francis@pwmachine:~/Codes/kinvolk/inspektor-gadget$ ./kubectl-gadget advise seccomp-profile start -p test
YgbVs4UQgmpUk0ar
francis@pwmachine:~/Codes/kinvolk/inspektor-gadget$ ./kubectl-gadget advise seccomp-profile stop YgbVs4UQgmpUk0ar
{
  "defaultAction": "SCMP_ACT_ERRNO",
  "architectures": [
    "SCMP_ARCH_X86_64",
    "SCMP_ARCH_X86",
    "SCMP_ARCH_X32"
  ],
  "syscalls": [
    {
      "names": [
        "futex"
      ],
      "action": "SCMP_ACT_ALLOW"
    }
  ]
}
francis@pwmachine:~/Codes/kinvolk/inspektor-gadget$ ./kubectl-gadget advise seccomp-profile start -p nginx
aSoqfaTyjoCF3XX1
francis@pwmachine:~/Codes/kinvolk/inspektor-gadget$ ./kubectl-gadget advise seccomp-profile stop aSoqfaTyjoCF3XX1
{
  "defaultAction": "SCMP_ACT_ERRNO",
  "architectures": [
    "SCMP_ARCH_X86_64",
    "SCMP_ARCH_X86",
    "SCMP_ARCH_X32"
  ],
  "syscalls": [
    {
      "names": [],
      "action": "SCMP_ACT_ALLOW"
    }
  ]
}
francis@pwmachine:~/Codes/kinvolk/inspektor-gadget$ ./kubectl-gadget advise seccomp-profile start -p mariadb
4IYtOXK53ROoZCrv
francis@pwmachine:~/Codes/kinvolk/inspektor-gadget$ ./kubectl-gadget advise seccomp-profile stop 4IYtOXK53ROoZCrv
{
  "defaultAction": "SCMP_ACT_ERRNO",
  "architectures": [
    "SCMP_ARCH_X86_64",
    "SCMP_ARCH_X86",
    "SCMP_ARCH_X32"
  ],
  "syscalls": [
    {
      "names": [
        "futex"
      ],
      "action": "SCMP_ACT_ALLOW"
    }
  ]
}

It fixes #215.
Best regards.

With pods containing several containers, it's possible to add a different seccomp profile for each container of the pod. Shouldn't we recommend that instead?
X-Ref: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.24/#seccompprofile-v1-core
There is a SeccompProfile field both in:

PodSecurityContext (seccomp profile at the pod level)
SecurityContext (seccomp profile at the container level)

With pods containing several containers, it's possible to add a different seccomp profile for each container of the pod. Shouldn't we recommend that instead?

This seems to be a good idea! So, instead, trace output would contain as many JSON as containers, right?

Yeah, I think it is a good idea. The problem is how to distinguish which container the seccomp profile belongs to. Maybe we could retry a map where the key is the name of the container and the value is the seccomp profile? I don't see any other field in the struct where we can specify the container name.

What's the status of this PR? Is there anything we should do to move this forward or should we close it?

Right, I also agree we can close this. Let's ask @alban since he has more context on this.

Closing this as we don't want this behavior as stated in https://github.com/inspektor-gadget/inspektor-gadget/issues/215.


UP-4893: Avoid NullPointerException in uPortal-api-rest module

Checklist

[X] the individual contributor license agreement is signed
[X] commit message follows commit guidelines
[X] tests are included
[ ] documentation is changed or added
[ ] message properties have been updated with new phrases
[ ] view conforms with WCAG 2.0 AA

Description of change

While writting unit tests for the module, found the code where it was throwing NullPointerException(NPE), fixed NPE problems in the code. Make changes in the unit tests cases too.
Jira link: https://issues.jasig.org/browse/UP-4893

Awesome.
I plan to look at this PR this morning as well.  I'll be happy to merge it.

@drewwills have you had a chance to take a look at this?

@drewwills @bjagg any other changes needed before this can be merged?


Pandas support

Can we make a tablib[pandas] optional install? with 0.12.0 there is now a pandas dependency that is a huge dependency to add for everyone by default.

what makes it a huge dependency? they ship wheels.

Wrong term, sorry, but pandas ships with a wheel and it relies on numpy, so for me at least it adds two minutes of time to build the wheels which makes CI tests slower whenever the cache gets busted.

For us the wheels don't get used, maybe because we are running in docker with alpine. Our build times increased by several minutes because of numpy and pandas:
Collecting pandas (from tablib->django-import-export==0.5.1->-r requirements.txt (line 10))
  Downloading pandas-0.20.3.tar.gz (10.4MB)
...
  Downloading numpy-1.13.1.zip (5.0MB)
...

Making it optional would be very helpful in our case.

I'll accept a pr which makes it optional.

@audiolion let me know if you need me to make the PR


Bump UXP to 1.14.5

Description of your changes
Bump UXP to 1.14.5I have:

[x] Read and followed Upbound's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[x] Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update the Vale configuration

This patch series should not get too big. And I want to attempt to only update the Vale configuration and leave the documentation alone. When it comes to updating documentation. I will open individual PRs for just that single document so that folks aren't having to review a large PR.
So this PR is just the beginning of a lot of little PRs.

After some more thoughts on this, this PR is going to be more about splitting up the files found the vale/Vocab directory so that it's easier to maintain going forward.

Created about 43 branches which have been validated as I make my way through the documentation running Vale on each file. I have about 85 files left that still trigger warnings or suggestions given the current configuration for Vale.

The error in this PR is because we're not using the HEAD version of Vale. We can either way for a release, or supply our own installation of Vale in a GitHub Action to fix this. The author mentioned that it would be released soon in the source repository.
Error: {
"Code": "E100",
"Text": "E100 [vocab] Runtime error\n\nVocab 'Software, Truss, Transcom' does not exist\n\nExecution stopped with code 1."
}

=> Error about multiple Vocabs
=> Author stating that a new release would be coming this week


Add a row for Plan size quota

In the Quotas table, it would be helpful to add a row for Plan size.
The total quota across all Apps in a Free plan is 0.50 GB.
The total quota across all Apps in a Standard plan is 2.00 GB.
The Plan size quotas are cited in the SWA pricing doc, but it would be helpful to mention them in the Quotas doc for consolidation and to avoid confusion about these two quota types.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 51bfa022-2797-8b08-7e15-332229df9a92
Version Independent ID: a1645d12-f261-d303-0191-c8e0b668bcad
Content: Quotas in Azure Static Web Apps
Content Source: articles/static-web-apps/quotas.md
Service: static-web-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@gabesmsft Thank you for your query . We will investigate and update the thread.

Thanks, @gabesmsft! This change is is being addressed in an upcoming PR. I will call to #please-close this issue for now.


helm: 0.6.1 -> 0.8.6

Motivation for this change
update helm. it turns out that the standalone version has been broken for a while, so we only build the lv2 for now.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@NeQuissimus thanks!


Add workaround for compiler assertion failure in Promise.flatten_next

This fixes #3856 with only a workaround and explicitly without actually solving the underlying issue, but hey, it's something.
Somehow the replaced lambda, or to be exact, the hygienic type created for it, wasn't properly reified and remained as a generic type. The hygienic type generates was:
promises_$2$7_String_val_String_val

which seems correct, but this is the type that failed the reachability, namely the part where the methods from the interface Fulfill have been applied to the type:
type: {(A): Promise[B #share] tag}[String val, String val] ref

I'm not a big fan of this workaround. I'd rather find the root cause of this. Who knows what weirdness might come from this workaround. Will existing working flatten code of which there is a lot in the not yet published GitHub Rest API stop working? No idea. The workaround worries me on the correctness front. It works for this case, but does it break others? To accept the workaround, I would want us to have more working test cases, how to do that and have it model the real world code we came up with this feature to address, I'm not sure.

@mfelsche can you rebase this against main so we don't have the spurious windows network failures?

The workaround applied here is doing the exact same thing as it did before this PR. It is just that the compiler doesn't need to create a hygienic type for the lambda and thus the reification works as it should and we avoid the error case.
I do agree that this workaround shouldn't be the last action to take solving this bug. But it is definitely an improvement over the current situation imho

How is it the exact same thing it did before this PR? It's a change. That sounds different to me.

Could you please look at what the lambda is returning and what the apply method of _PendingFulfill is returning?
It is the same thing. Lambdas get desugared to a type like _PendingFulfill during compilation. All I did is avoided that step that introduced the compiler assertion reported in #3856 . It was caused by that generic lambda implementing Fulfill and defined inside an object literal. I removed that generic lambda and exchanged it for a type that is reified correctly.

So we agree the error in question shouldn't be happening. If this is exactly equivalent then this would fix nothing. It does however fix something and there's no evidence at this time that it doesn't break anything in an odd fashion. I have a bunch of code that used flatten and there's no way from purely this PR to know it doesn't break that code.
If this was exactly equivalent, it wouldn't fix the bug. I'm not comfortable with this change without verifying that the existing usage doesn't break.
Can you build ponyc with this and run all the github_rest_api examples and verify they work?

@mfelsche can you take your build of this on your machine and use it to do make test for the github_rest_api and make sure it all works?

The github_rest_api tests all worked. Also checked the examples on main.

@mfelsche that's good to hear. can you open a new issue for the reification problem with how to reproduce (changes to stdlib etc) so we can have that for something that we can look into in the future then this can be merged and we can close the original issue.

Hi @mfelsche,
The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.
Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3991.md to match the number of this pull request.
The basic format of the release notes (using markdown) should be:
## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

Issue #4014 has been created. This can be merged once release notes are added.


juniper_warp::make_graphql_filter improperly returns 4xx on some context_extractor 5xx errors

Describe the bug
with juniper_warp = "0.7.0", this sequence can happen:

request comes in with valid application/json body.
post_json_filter runs; context_extractor fails for some transient reason (database error in my case), returns some Rejection that should produce a 5xx error.
then post_graphql_filter runs. context_extractor happens to succeed this time. post_graphql_filter returns a 4xx rejection about a parse error because the body's actually in json format.

To Reproduce
Steps to reproduce the behavior:
(code example preferred)

failing unit test diff
diff --git a/juniper_warp/src/lib.rs b/juniper_warp/src/lib.rs
index 7b524d2a..7567062f 100644
--- a/juniper_warp/src/lib.rs
+++ b/juniper_warp/src/lib.rs
@@ -449,7 +449,7 @@ pub mod subscriptions {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use warp::{http, test::request};
+    use warp::{http, test::request, reject::Reject};

     #[test]
     fn graphiql_response_does_not_panic() {
@@ -642,6 +642,52 @@ mod tests {

         assert!(result.is_err());
     }
+
+    #[tokio::test]
+    async fn context_extractor_failure() {
+        use juniper::{
+            tests::fixtures::starwars::schema::{Database, Query},
+            EmptyMutation, EmptySubscription, RootNode,
+        };
+
+        type Schema =
+            juniper::RootNode<'static, Query, EmptyMutation<Database>, EmptySubscription<Database>>;
+
+        let schema: Schema = RootNode::new(
+            Query,
+            EmptyMutation::<Database>::new(),
+            EmptySubscription::<Database>::new(),
+        );
+
+        let called = Arc::new(std::sync::atomic::AtomicBool::new(false));
+        #[derive(Debug)]
+        struct MyRejection;
+        impl Reject for MyRejection {}
+        let context_extractor: warp::filters::BoxedFilter<(Database,)> = warp::any().and_then(move || {
+            std::future::ready(if called.swap(true, std::sync::atomic::Ordering::Relaxed) {
+                println!("second call");
+                Ok(Database::new())
+            } else {
+                println!("first call");
+                Err(warp::reject::custom(MyRejection))
+            })
+        }).boxed();
+        let filter = warp::path("graphql").and(make_graphql_filter(schema, context_extractor));
+        let response = request()
+            .method("POST")
+            .path("/graphql")
+            .header("accept", "application/json")
+            .header("content-type", "application/json")
+            .body(
+                r##"[
+                     { "variables": null, "query": "{ hero(episode: NEW_HOPE) { name } }" },
+                     { "variables": null, "query": "{ hero(episode: EMPIRE) { id name } }" }
+                 ]"##,
+            )
+            .reply(&filter)
+            .await;
+        assert_eq!(response.status(), http::StatusCode::INTERNAL_SERVER_ERROR);
+    }
 }

 #[cfg(test)]

Expected behavior
It should run my context_extractor only once per request. Any Rejections returned from the context_extractor should be returned faithfully from the combined filter returned from make_graphql_filter, rather than effectively turning a 5xx error into a 4xx error.
Additional context
Add any other context about the problem here.

I'm having trouble understanding warp's filter model; possibly my context_extractor is supposed to do something special to say that its error is terminal? but make_graphql_filter's behavior seems suboptimal at least:

it's not great to call context_extractor twice at least from a efficiency/load perspective, and
it's not great to try parsing an application/json body as graphql, and then to report that error instead of the one from the first context_extractor call

I personally haven't used warp so I will let other maintainers or community members chime in on this.

@scottlamb sorry for responding late on this.

but make_graphql_filter's behavior seems suboptimal at least:
* it's not great to call `context_extractor` twice at least from a efficiency/load perspective, and

* it's not great to try parsing an `application/json` body as graphql, and then to report that error instead of the one from the first `context_extractor` call

This behavior is definitely wrong. Especially, considering possible non-idempotent mutation semantics.
It seems that we're missing reject in out .or() filter chains, so failing one branch switches to another one without rejection as desired.

@scottlamb upon further investigation, it seems that everything is relatively fine in juniper_warp, but a big misunderstanding of warp filters has place. See https://github.com/seanmonstar/warp/issues/388#issuecomment-576453485 for the main insight:

Rejections are meant to say a Filter couldn't fulfill its preconditions, but maybe another Filter can. If a filter is otherwise fully matched, and an error occurs in your business logic, it's probably not correct to reject with the error. In that case, you'd want to construct a Reply that describes your error.
In the todos example, once the request has gotten through the filters and arrived to the handler function, it chooses to return responses with the correct status codes instead of rejecting.
It may be worth adding some pattern to ease that?

So, every time we return Err(warp::reject::something()), we don't actually say "abort this request completely", we do say "reject this branch of filters and try another one, if any", and thus, we do trigger, another .or() branch.
This exactly what happens in your example:
let context_extractor: warp::filters::BoxedFilter<(Database,)> = warp::any().and_then(move || {
    std::future::ready(if called.swap(true, std::sync::atomic::Ordering::Relaxed) {
        println!("second call");
        Ok(Database::new())
    } else {
        println!("first call");
        Err(warp::reject::custom(MyRejection))
    })
}).boxed();

Here, the post_graphql_filter runs after trying the branch with post_json_filter exactly because the context_extractor filter rejects this branch and switches to another one. Nothing in juniper_warp triggers it.
To avoid switching to another .or() branch, we should use the .recover() filter, where do the inspection whether the Rejection contains our cause, and if so, return a Reply immediately, or reject into other branches.
However, we cannot write such .recover() filter inside juniper_warp, because we cannot know the exact user-defined error being used. That's why, it should be specified from the user-side, along with context_extractor (something like this):
let context_extractor: warp::filters::BoxedFilter<(Database,)> = warp::any()
.and_then(move || {
    std::future::ready(if called.swap(true, std::sync::atomic::Ordering::Relaxed) {
        println!("second call");
        Ok(Database::new())
    } else {
        println!("first call");
        Err(warp::reject::custom(MyRejection))
    })
})
.recover(|rejection| {
    // `MyRejection` should impl `warp::Reply`
    // and `Clone`, because `find` returns `Option<&T>` only =(
    rejection.find::<MyRejection>().cloned().ok_or(rejection)
})
.boxed();

In #1122 I'll describe this clearly in the docs and will provide an example.
Also, regarding rejects inside make_graphql_filter, it seems that some other cases should be handled too (like failing body() or query() filters).

@scottlamb so, in the end, I've ended up rewriting juniper_warp a bit in the way that make_graphql_filter() executes context_extractor only once. However, Rejections, returned by context_extractor, still should be handled outside, to avoid branching into other Filters. I've added an example demonstrating this.


Regexp separated by ':' or by ',' ??

In the Phishlet Format Guide for v3.0.0 there are examples of the regexp modifier being separated by both a colon and a comma. I included the examples below. Will both work or is only one correct?
COLON EXAMPLE:
'frog-[0-9]{3}:regexp'
COMMA EXAMPLE:
auth_tokens:

domain: '.company.com'
keys: ['.*,regexp']
type: 'cookie'

telegram @itsdayztar


GEODE-6443: Log all requests to REST ManagementService

Requests are logged simply with a prefix of 'Management request'. This
could easily be customized in the future.
Request logging can be disabled by setting the system property
geode.management.request.logging=false

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@onichols-pivotal @Petahhh For your review

@jdeppe-pivotal Looks good!


Number of persons without any clinical events

As a measure of 'healthy population' in the dataset.

Or distribution of number of events per person (min,p10,p25,median,p75,p90,max)


remotes: add distribution labels to blob data

We can use cross repository push feature to reuse the existing blobs in
the same registry. Before make push fast, we know where the blob comes
from.
Use the containerd.io/distribution.source. = [,] as label format. For
example, the blob is downloaded by the docker.io/library/busybox:latest
and the label will be
containerd.io/distribution.source.docker.io = library/busybox

If the blob is shared by different repos in the same registry, the repo
name will be appended, like:
containerd.io/distribution.source.docker.io = library/busybox,x/y

NOTE:

no need to apply for legacy docker image schema1.
the concurrent fetch actions might miss some repo names in label, but
it is ok.

Signed-off-by: Wei Fu<EMAIL_ADDRESS>
part 1 (step 1) in https://github.com/containerd/containerd/issues/2964

Codecov Report

Merging #3067 into master will decrease coverage by 0.2%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3067      +/-   ##
==========================================
- Coverage   43.46%   43.25%   -0.21%
==========================================
  Files         103      104       +1
  Lines       11033    11085      +52
==========================================
  Hits         4795     4795
- Misses       5503     5555      +52
  Partials      735      735

Flag
Coverage Δ

#linux
47.26% <0%> (-0.23%)
:arrow_down:

#windows
40.07% <0%> (-0.22%)
:arrow_down:

Impacted Files
Coverage Δ

remotes/docker/handler.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b6f46...7991776. Read the comment docs.

Codecov Report

Merging #3067 into master will decrease coverage by 0.2%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3067      +/-   ##
==========================================
- Coverage   43.46%   43.25%   -0.21%
==========================================
  Files         103      104       +1
  Lines       11033    11085      +52
==========================================
  Hits         4795     4795
- Misses       5503     5555      +52
  Partials      735      735

Flag
Coverage Δ

#linux
47.26% <0%> (-0.23%)
:arrow_down:

#windows
40.07% <0%> (-0.22%)
:arrow_down:

Impacted Files
Coverage Δ

remotes/docker/handler.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b6f46...7991776. Read the comment docs.

ping @dmcgowan
updated.

ping @dmcgowan
updated and PTAL. Thanks

@fuweid Could you help answer my questions in my last comment? Thanks!

This change is in the context of being able to push "shallow" pulled images by storing enough information in the content store to complete a push. The main requirement is to get the labels so we can know where the content was pulled from, but in order to complete a push to a new repository using a feature we call "cross repository push", we will also need the manifests. Storing the configs is just useful metadata and doesn't make sense to throw away, what we really want to avoid is storing unnecessary layer data.

Would it be worth configuring whether or not to fetch all manifests in the Client (and a flag for ctr)? Even though the files are small, there would be whole HTTP handshakes to get each of those files. Those milliseconds can come into account when there's a need for fast scaling.

Thanks a lot for providing context @dmcgowan and it makes more sense!
I have the same question just as @alculquicondor mentioned.

We always support configurability and I understand that not all pulls are made with the intent to push back the content. In some of these cases, the result of the push may make more sense to tag the image directly on the image config and get rid of the tars as well. We prefer the client library to be as unopionated as possible. If you want to make an issue for this feel free, or can find someone to implement that.

Thanks Derek! I created https://github.com/containerd/containerd/issues/3126, also I will create a PR for it.


Cabal 1.22 version support

Support changes in Cabal 1.22 modules by CPP style guards.

Thanks! This compiles successfully.


Updated Cloudflare documentation, resolves #2

Signed-off-by: Dmitri Fedorov<EMAIL_ADDRESS>

This is great @dfedorov-ciena and is far more thorough RE: Packet and CF! LGTM!


XML queries give nil result

Including XML queries gives Scan errors in Rows like "column value is nil, and cannot be converted to *string". My guess, this is because of lack of escaping.
SELECT t.Id, t.Xml.value('(/root/item/custom_id)[1]', 'varchar(50)') AS CustomId FROM MyTable t

My bad, the column contained absolutely unexpected null, so the error was just about using String instead of db.NullString in the struct,


ng generate component mymodule/mycomp fails when project root set deep

Versions
Angular CLI: 1.5.2
Node: 8.2.1
OS: linux x64
Angular: 4.4.6
... animations, common, compiler, compiler-cli, core, forms
... http, platform-browser, platform-browser-dynamic
... platform-server, router, tsc-wrapped
@angular/cdk: 2.0.0-beta.12
@angular/cli: 1.5.2
@angular/flex-layout: 2.0.0-beta.9
@angular/material: 2.0.0-beta.12
@angular-devkit/build-optimizer: 0.0.33
@angular-devkit/core: 0.0.21
@angular-devkit/schematics: 0.0.37
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.8.2
@schematics/angular: 0.1.7
typescript: 2.3.4
webpack: 3.8.1

Repro steps
The root of the @angular project in .angular-cli.json is src/main/webapp

Step 1 - Navigate to root folder of project
Step 2 - ng generate component mymodule/mycomp
Step 3 - ng generate component mymodule/mycomp --skip-import

Observed behavior
Step 2
Error: Could not find an NgModule for the new component. Use the skip-import option to skip importing components in NgModule.
Could not find an NgModule for the new component. Use the skip-import option to skip importing components in NgModule.

Step 3
Component is created in wrong directory. Full path of component is created in root/app, not at root/app (i.e. path is doubled - see below)
src/main/webapp/src/main/webapp/app/mymodule/mycomp.component.scss

Desired behavior
Component created in the correct location and imported into the project module.
Mention any other details that might be useful (optional)

I created a new component a couple of weeks ago, but since then I have upgraded several components, including @angular/core, @angular/material and @angular/flex-layout
(Project was originally created with JHipster - Java/SpringBoot backend.)
To troubleshoot, I created a new project with ng new myproj --source-dir src/main/webapp and it created the component OK. But this project is too complex to create afresh and port code over.
BTW - --source-dir option is not documented

FAO: @hansl

I had a similar issue in a jHipster generated project but I upgraded Angular CLI from 1.6.0 version to 1.6.1 and it seems to be working fine now.
Version 1.6.0
$ ng generate component mymodule/mycomp --skip-import -d
Your global Angular CLI version (1.6.1) is greater than your local
version (1.6.0). The local Angular CLI version is used.

To disable this warning use "ng set --global warnings.versionMismatch=false".
  create src/main/webapp/src/main/webapp/app/mymodule/mycomp/mycomp.component.html (25 bytes)
  create src/main/webapp/src/main/webapp/app/mymodule/mycomp/mycomp.component.ts (242 bytes)

NOTE: Run with "dry run" no changes were made.

Version 1.6.1
$ ng generate component mymodule/mycomp --skip-import -d
  create src/main/webapp/app/mymodule/mycomp/mycomp.component.html (25 bytes)
  create src/main/webapp/app/mymodule/mycomp/mycomp.component.ts (242 bytes)

NOTE: Run with "dry run" no changes were made.

Can you take a look too, @Red-3 ?

if You are using Angular 6 then change your current directory to /app/src/ then use ng g c new-component.  I think the problem will be resolved, It works for me.

if  "ng" is serving the project ..you can probably get this error also....i canceled ng serve in terminal . and  it worked


Add get_version.py to excluded package data

Did not occur to me that get_version.py would be included in global namespace since it is in src/get_version.py.
PR excludes the file from being packaged.

Thanks, LGTM


force:package:version:create returns error "Missing Organization Feature: ContactsToMultipleAccounts" intermittently

Summary
Package:version:create with the reference to definition file, which has feature "ContactsToMultipleAccounts" on it intermittently returns the error:
ERROR running force:package:version:create:  An error occurred while trying to install a package dependency, ID 04########: Missing Organization Feature: ContactsToMultipleAccounts
Steps To Reproduce:

Create the scratch org definition file config\project-scratch-def.json

{
    "orgName": "Test Org",
    "description": "Test",
    "country": "US",
    "edition": "Enterprise",
    "hasSampleData": false,
    "language": "en_US",
    "features": [
        "FinancialServicesUser:10",
        "ContactsToMultipleAccounts",
        "PersonAccounts",
        "IndustriesActionPlan",
        "DocumentChecklist",
        "RecordTypes",
        "SharedActivities",
        "PlatformEncryption"
    ],
    "settings": {
        "chatterSettings": {
          "enableChatter": true
        },
        "knowledgeSettings": {
          "enableKnowledge": true,
          "enableLightningKnowledge": true
          },
        "lightningExperienceSettings": {
          "enableS1DesktopEnabled": true
        },
        "languageSettings": {
          "enableTranslationWorkbench": true
        },
        "nameSettings":{
          "enableMiddleName": true,
          "enableNameSuffix": true
        },
        "enhancedNotesSettings": {
          "enableEnhancedNotes": true
        }
      },
      "objectSettings": {
            "opportunity": {
                "sharingModel": "private"
            },
            "contact": {
              "sharingModel": "private"
            },
            "case": {
                "sharingModel": "private"
            }
        }
}

Define the package on sfdx-project.json as dependent on FSC managed package

"packageDirectories": [
        {
            "path": "src\\package-test",
            "package": PackageTest",
            "versionName": "ver 0.1",
            "versionNumber": "0.1.0.NEXT",
            "default": false,
            "dependencies": [
                {
                    "package"<EMAIL_ADDRESS>                }
            ]
        }
],
    "namespace": "",
    "sfdcLoginUrl": "https://login.salesforce.com",
    "sourceApiVersion": "54.0",
    "packageAliases": {
<EMAIL_ADDRESS>"04t1E000001IrDtQAK",
        "PackageTest": "0H############",
    },
    "plugins": {}
}

Create Package:

sfdx force:package:create --name "PackageTest" --packagetype Unlocked --path "src/package-test" --targetdevhubusername DevHubUsername --errornotificationusername DevHubUsername

Run Package Create Version Create:

sfdx force:package:version:create --package "PackageTest" --installationkeybypass --wait 90 --targetdevhubusername DevHubUsername --definitionfile "config/project-scratch-def.json"
Expected result
force:package:version:create request must verify dependencies successfully and propagate to the next stage, i.e.:
Request in progress. Sleeping 30 seconds. Will wait a total of 3960 more seconds before timing out. Current Status='Verifying metadata'
Actual result
Sometimes but not always, the error generated during 'Verifying dependencies' that ContactsToMultipleAccounts feature is missed
Request in progress. Sleeping 30 seconds. Will wait a total of 4890 more seconds before timing out. Current Status='Verifying dependencies'
ERROR running force:package:version:create:  An error occurred while trying to install a package dependency, ID 04t1E000001IrDt: Missing Organization Feature: ContactsToMultipleAccounts

System Information
{
        "cliVersion": "sfdx-cli/7.149.1",
        "architecture": "win32-x64",
        "nodeVersion": "node-v16.15.0",
        "pluginVersions": [
                "@dxatscale/sfpowerscripts 13.0.15",
                "@oclif/plugin-autocomplete 0.3.0 (core)",
                "@oclif/plugin-commands 1.3.0 (core)",
                "@oclif/plugin-help 3.3.1 (core)",
                "@oclif/plugin-not-found 1.2.6 (core)",
                "@oclif/plugin-plugins 1.10.11 (core)",
                "@oclif/plugin-update 1.5.0 (core)",
                "@oclif/plugin-warn-if-update-available 1.7.3 (core)",
                "@oclif/plugin-which 1.0.4 (core)",
                "@salesforce/sfdx-plugin-lwc-test 0.1.7 (core)",
                "alias 2.0.0 (core)",
                "apex 0.11.0 (core)",
                "auth 2.0.2 (core)",
                "community 1.1.4 (core)",
                "config 1.3.30 (core)",
                "custom-metadata 1.1.0 (core)",
                "data 0.6.15 (core)",
                "generator 1.2.2 (core)",
                "info 2.0.0 (core)",
                "limits 2.0.0 (core)",
                "org 1.12.1 (core)",
                "salesforce-alm 54.2.1 (core)",
                "schema 2.1.0 (core)",
                "sfdmu 4.14.1",
                "sfdx-cli 7.149.1 (core)",
                "sfpowerkit 4.2.5",
                "signups 1.0.0 (core)",
                "source 1.9.6 (core)",
                "telemetry 1.4.0 (core)",
                "templates 54.5.0 (core)",
                "trust 1.1.0 (core)",
                "user 1.7.1 (core)"
        ],
        "osVersion": "Windows_NT 10.0.19043"
}

Its an issue with scratch org used for validation. Scratch Orgs are flaky with ACR

@AndreyShestakovACN from packaging support:

Can you confirm if you have the org pref ContactsToMultipleAccounts enabled in setup.
Try this configuration: Setup -> Account Settings -> check the Allow users to relate a contact to multiple accounts

As Azlam said, there was an issue on sandbox/scratch infra, that should be solved by now: https://status.salesforce.com/generalmessages/964

@cristiand391 , the issue I described is realted to a scratch org created based on the scratch org definition file. Sometimes a scratch org is created with the feature "ContactsToMultipleAccounts" enabled and sometime without.
To clarify, the issue happens no only when trying to create a package version, but also when creating a scratch org manually.
I will be testing the scratch orgs creation for the next few days to see if the issue still exists or not.

Ah gotcha, yeah we saw a few scratch org errors last week.
I will be testing the scratch orgs creation for the next few days to see if the issue still exists or not.
Sure, thanks! I'll keep this issue open for at least 1 week.

I tried to create scratch orgs on different days this week, and did not get the issue on Tuesday, but had the 2 times occurence of Missing Organization Feature: ContactsToMultipleAccounts on Thursday: first 2 attempts I've got the error, but with the 3rd attempt the scratch org has been properly created.

This is a known serverside issue and the appropriate team is tracking internally with W-9529783 and W-9604466.  Since this is not an issue with the CLI I'm closing this issue.  Feel free to contact support for anything addtional.

Why is this closed? This is a multi-month outage that's still happening. "Open a support ticket" = "throw the issue into a canyon."

More examples:
https://trailblazer.salesforce.com/issues_view?id=a1p3A000001PYYlQAO
https://trailblazer.salesforce.com/issues_view?id=a1p4V000001s8OlQAI
https://salesforce.stackexchange.com/questions/388111/error-installing-package-in-scratch-org-missing-organization-feature-contacts
There is a very painful workaround for CI systems: https://salesforce.stackexchange.com/a/360103/68098

The more I try to use scratch orgs, the more confused I get. Do people actually use these for CI? They seem really unstable. You can't even log in to a scratch org safely: https://github.com/forcedotcom/cli/issues/1640


OOP school library: decorate a class

In this PR, I achieved the following;

Created a class Corrector with a method correct_name.
Set an instance of Corrector in Person on initialization.
In Person, added a method validate_name that uses the Corrector instance to validate and save the corrected name(after trimming the name).

Required Changes ♻
Hi @blase147, This is @sja-thedude your code reviewer.
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights
✔ All linters passing ✔ Professional Readme ✔ Correct Giflow
Required

[ ]  Good job in trimming the name however, you have to follow all the requirements stated in the project requirements. Make sure you have followed all the requirements.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me [@sja-thedude] in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Please can you be more precise as to the requirements. Because I feel I followed all requirements

Thanks for the feedback. Please @sja-thedude  can you be more precise as to the requirements? Because I feel I followed all requirements

Thanks for the feedback. Please @sja-thedude  can you be more precise as to the requirements? Because I feel I followed all requirements

As per the requirements you should have a class Nameable.
Which should have implement a method correct_name.
Make sure that you have a class person which inherits nameable.
And have correct_name implemented.
Next you should have decorator class which inherits from nameable.
Also you should have class for capitalize decorator and trimmer decorator.
So make sure you follow all the guidelines with this.


List as a PSM root

It should be possible to create a schema representing a list of entities (JSON array as a root for example), not just the entity itself.

Solved by configuration


leave blockpc off by default, but remove the warning about

unsoundness, since we have fixed this.

LGTM.


Questions on Using Viser in Jupyter Environment

Hi,
I have a few questions regarding the use of Viser within Jupyter notebooks:
1.	Persistent Server Without Blocking Other Cells:

In the provided examples, the following code snippet is used at the end to keep the server running:
while True:
    time.sleep(0.1)

However, in Jupyter notebooks, this approach blocks the execution of other cells, which is inconvenient and not aligned with typical Jupyter workflows. Is there a way to run the Viser server in the background so that it doesn’t interfere with executing other notebook cells?
2.	Independent Interactions Within a Single Canvas:

Is it possible to allocate independent interactions or separate cameras for different objects on the same canvas? This would enable scenarios where a single browser view could be split into separate sections, each allowing independent zooming, rotating, and panning actions without affecting other sections. This feature would be quite helpful for displaying and interacting with multiple results side by side in one canvas.
Any guidance or advice on these questions would be greatly appreciated!
Thank you!

Hi @JintaoLee-Roger!
For (1), you can just omit the while True/time.sleep() logic. If you create a ViserServer object from a notebook cell it'll automatically stay running in the background.
One pattern I use sometimes is:
import viser

try:
    server.scene.reset()
except NameError:
    server = viser.ViserServer()

so if I re-run the cell it will just reset the current scene instead of creating a new server object.
For (2), this is unfortunately not possible.

We used to have something similar but it was removed in #44.
If you're frontend-savvy you could modify the viser client to tile the multiple <ViewerRoot /> elements into a grid, each of which would connect as a separate client: https://github.com/nerfstudio-project/viser/blob/9ef686f04361db4051df19f9a20f571ee9c1ad72/src/viser/client/src/App.tsx#L710-L724

Thanks for clearing that up, I think being able to solve the first problem should be enough for my current needs


Expose global settings

Need to expose following variables in global settings:
host
apiUrl
aclToken
connectionTimeout
responseTimeout

Refactored and added global settings, that can used or ignored.