Obtaining at compile/runtime the ESP Zigbee Library version? (TZ-1137)

Question
Can we obtain the version number/details of the ESP Zigbee library version at compile time and/or at runtime?
For ZBoss, there is the zb_get_version() function.
Additional context.
No response

@monty68 ,

Can we obtain the version number/details of the ESP Zigbee library version at compile time and/or at runtime?

The esp-zigbee-sdk v1.5.1 has already supported this feature, please refer to https://github.com/espressif/esp-zigbee-sdk/blob/main/components/esp-zigbee-lib/include/esp_zigbee_core.h#L961.

Hi @monty68 ,
Does this feature https://github.com/espressif/esp-zigbee-sdk/issues/429#issuecomment-2419191799 meet your requirement? If yes, please consider closing this issue.

Could we not have a simple #define in the header as well?

Could we not have a simple #define in the header as well?

I cannot clearly understand your request; could you please provide more details about this requirement?


Build failure with GHC 7.10

Unpacking to webdriver-0.6.1/
Resolving dependencies...
Configuring webdriver-0.6.1...
Building webdriver-0.6.1...
Preprocessing library webdriver-0.6.1...
[ 1 of 17] Compiling Test.WebDriver.Chrome.Extension ( src/Test/WebDriver/Chrome/Extension.hs, dist/build/Test/WebDriver/Chrome/Extension.o )

src/Test/WebDriver/Chrome/Extension.hs:13:1: Warning:
    The import of ‘Control.Applicative’ is redundant
      except perhaps to import instances from ‘Control.Applicative’
    To import instances alone, use: import Control.Applicative()
[ 2 of 17] Compiling Test.WebDriver.Common.Profile ( src/Test/WebDriver/Common/Profile.hs, dist/build/Test/WebDriver/Common/Profile.o )

src/Test/WebDriver/Common/Profile.hs:54:1: Warning:
    The import of ‘Control.Applicative’ is redundant
      except perhaps to import instances from ‘Control.Applicative’
    To import instances alone, use: import Control.Applicative()
[ 3 of 17] Compiling Test.WebDriver.Firefox.Profile ( src/Test/WebDriver/Firefox/Profile.hs, dist/build/Test/WebDriver/Firefox/Profile.o )

src/Test/WebDriver/Firefox/Profile.hs:32:1: Warning:
    Module ‘Data.Attoparsec.Char8’ is deprecated:
      This module will be removed in the next major release.
[ 4 of 17] Compiling Test.WebDriver.Utils ( src/Test/WebDriver/Utils.hs, dist/build/Test/WebDriver/Utils.o )
[ 5 of 17] Compiling Test.WebDriver.JSON ( src/Test/WebDriver/JSON.hs, dist/build/Test/WebDriver/JSON.o )

src/Test/WebDriver/JSON.hs:41:1: Warning:
    The import of ‘Control.Applicative’ is redundant
      except perhaps to import instances from ‘Control.Applicative’
    To import instances alone, use: import Control.Applicative()
[ 6 of 17] Compiling Test.WebDriver.Capabilities ( src/Test/WebDriver/Capabilities.hs, dist/build/Test/WebDriver/Capabilities.o )

src/Test/WebDriver/Capabilities.hs:19:1: Warning:
    The import of ‘Control.Applicative’ is redundant
      except perhaps to import instances from ‘Control.Applicative’
    To import instances alone, use: import Control.Applicative()
[ 7 of 17] Compiling Test.WebDriver.Session ( src/Test/WebDriver/Session.hs, dist/build/Test/WebDriver/Session.o )

src/Test/WebDriver/Session.hs:21:1: Warning:
    Module ‘Control.Monad.Error’ is deprecated:
      Use Control.Monad.Except instead

src/Test/WebDriver/Session.hs:23:1: Warning:
    The import of ‘Control.Monad.Writer.Strict’ is redundant
      except perhaps to import instances from ‘Control.Monad.Writer.Strict’
    To import instances alone, use: import Control.Monad.Writer.Strict()

src/Test/WebDriver/Session.hs:104:11: Warning:
    In the use of type constructor or class ‘Error’
    (imported from Control.Monad.Error, but defined in Control.Monad.Trans.Error):
    Deprecated: "Use Control.Monad.Trans.Except instead"

src/Test/WebDriver/Session.hs:104:57: Warning:
    In the use of type constructor or class ‘ErrorT’
    (imported from Control.Monad.Error, but defined in Control.Monad.Trans.Error):
    Deprecated: "Use Control.Monad.Trans.Except instead"
[ 8 of 17] Compiling Test.WebDriver.Config ( src/Test/WebDriver/Config.hs, dist/build/Test/WebDriver/Config.o )
[ 9 of 17] Compiling Test.WebDriver.Class ( src/Test/WebDriver/Class.hs, dist/build/Test/WebDriver/Class.o )

src/Test/WebDriver/Class.hs:19:1: Warning:
    Module ‘Control.Monad.Error’ is deprecated:
      Use Control.Monad.Except instead

src/Test/WebDriver/Class.hs:21:1: Warning:
    The import of ‘Control.Monad.Writer.Strict’ is redundant
      except perhaps to import instances from ‘Control.Monad.Writer.Strict’
    To import instances alone, use: import Control.Monad.Writer.Strict()

src/Test/WebDriver/Class.hs:68:11: Warning:
    In the use of type constructor or class ‘Error’
    (imported from Control.Monad.Error, but defined in Control.Monad.Trans.Error):
    Deprecated: "Use Control.Monad.Trans.Except instead"

src/Test/WebDriver/Class.hs:68:48: Warning:
    In the use of type constructor or class ‘ErrorT’
    (imported from Control.Monad.Error, but defined in Control.Monad.Trans.Error):
    Deprecated: "Use Control.Monad.Trans.Except instead"
[10 of 17] Compiling Test.WebDriver.Internal ( src/Test/WebDriver/Internal.hs, dist/build/Test/WebDriver/Internal.o )

src/Test/WebDriver/Internal.hs:39:1: Warning:
    The import of ‘Control.Applicative’ is redundant
      except perhaps to import instances from ‘Control.Applicative’
    To import instances alone, use: import Control.Applicative()

src/Test/WebDriver/Internal.hs:46:1: Warning:
    The import of ‘Word’ from module ‘Data.Word’ is redundant
[11 of 17] Compiling Test.WebDriver.Commands.Internal ( src/Test/WebDriver/Commands/Internal.hs, dist/build/Test/WebDriver/Commands/Internal.o )

src/Test/WebDriver/Commands/Internal.hs:30:1: Warning:
    The import of ‘Control.Applicative’ is redundant
      except perhaps to import instances from ‘Control.Applicative’
    To import instances alone, use: import Control.Applicative()
[12 of 17] Compiling Test.WebDriver.Exceptions ( src/Test/WebDriver/Exceptions.hs, dist/build/Test/WebDriver/Exceptions.o )
[13 of 17] Compiling Test.WebDriver.Commands.Wait ( src/Test/WebDriver/Commands/Wait.hs, dist/build/Test/WebDriver/Commands/Wait.o )
[14 of 17] Compiling Test.WebDriver.Commands ( src/Test/WebDriver/Commands.hs, dist/build/Test/WebDriver/Commands.o )

src/Test/WebDriver/Commands.hs:221:15:
    Could not deduce (L.Exception e0) arising from a use of ‘handle’
    from the context (WebDriver wd, FromJSON a)
      bound by the type signature for
                 asyncJS :: (WebDriver wd, FromJSON a) =>
                            [JSArg] -> Text -> wd (Maybe a)
      at src/Test/WebDriver/Commands.hs:220:12-72
    The type variable ‘e0’ is ambiguous
    Note: there are several potential instances:
      instance L.Exception L.NestedAtomically
        -- Defined in ‘Control.Exception.Base’
      instance L.Exception L.NoMethodError
        -- Defined in ‘Control.Exception.Base’
      instance L.Exception L.NonTermination
        -- Defined in ‘Control.Exception.Base’
      ...plus 31 others
    In the expression: handle timeout
    In the expression:
      handle timeout $ Just <$> (fromJSON' =<< getResult)
    In an equation for ‘asyncJS’:
        asyncJS a s
          = handle timeout $ Just <$> (fromJSON' =<< getResult)
          where
              getResult
                = doSessCommand methodPost "/execute_async"
                  . pair ("args", "script")
                  $ (a, s)
              timeout (FailedCommand Timeout _) = return Nothing
              timeout (FailedCommand ScriptTimeout _) = return Nothing
              timeout err = throwIO err

src/Test/WebDriver/Commands.hs:225:5:
    Non type-variable argument in the constraint: MonadBase IO m
    (Use FlexibleContexts to permit this)
    When checking that ‘timeout’ has the inferred type
      timeout :: forall (m :: * -> *) a.
                 MonadBase IO m =>
                 FailedCommand -> m (Maybe a)
    In an equation for ‘asyncJS’:
        asyncJS a s
          = handle timeout $ Just <$> (fromJSON' =<< getResult)
          where
              getResult
                = doSessCommand methodPost "/execute_async"
                  . pair ("args", "script")
                  $ (a, s)
              timeout (FailedCommand Timeout _) = return Nothing
              timeout (FailedCommand ScriptTimeout _) = return Nothing
              timeout err = throwIO err

I encountered the same error. It seems to be solved already on master branch (by commit 7e3d49237241b0eb7441cf162b5f22fa9701ab1f).
@kallisti-dev I'm waiting the next release.

Same here, we use this for darcsden tests.

Hi!
When can you upload the new version to hackage?
Tks

Yes, I'm waiting on the new version to be uploaded to Hackage also.


Manifest can't be generated for RHEL 8.4 tar image type on s390x (panic)

rhel84 on s390x supports tar image type: https://github.com/osbuild/osbuild-composer/blob/2cae456094be7d0b3c2d23748eb680bb919b37c6/internal/distro/rhel84/distro.go#L1212
tar image type doesn't specify a partition table generator: https://github.com/osbuild/osbuild-composer/blob/2cae456094be7d0b3c2d23748eb680bb919b37c6/internal/distro/rhel84/distro.go#L1028
Manifest/pipeline generator panics if s390x doesn't have a partition table: https://github.com/osbuild/osbuild-composer/blob/2cae456094be7d0b3c2d23748eb680bb919b37c6/internal/distro/rhel84/distro.go#L250

The important question here is whether pipelines for tar@s390x should have the kernel cmdline stage. I think it's pointless because this image type doesn't contain the kernel. @teg thoughts?

People may still add a kernel and install this on bare metal, so might make sense. That's how we would like to use it with the installer.


[FEA] Create a benchmark runner script for SQL only e2e runs

In the interest of easing integration testing, we should have another benchmark_runner_sql.py script that manages:

Standing up a Dask cluster setup for running only BlazingSQL query implementations
Runs all 30 queries and supports the same "repeat count" configuration

Closed by #33


Module not found: Error: Can't resolve 'fs'

I've updated my docusaurus project to 2.0.0-beta.0 and redocusaurus is not working anymore due to this error
Module not found: Error: Can't resolve 'fs'
Module not found: Error: Can't resolve 'fs' in '/home/romain/Projets/help/node_modules/redoc/bundles'
Module not found: Error: Can't resolve 'process/browser' in '/home/romain/Projets/help/node_modules/yaml/browser/dist'
Did you mean 'browser.js'?
BREAKING CHANGE: The request 'process/browser' failed to resolve only because it was resolved as fully specified
(probably because the origin is a '*.mjs' file or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.

Can you also update redocusaurus to v0.4.2? In the beta webpack was upgraded to v5 that caused build issues.
Related to #25

The last available version on npm is 0.4.1

Hi, thanks for developing this package! Is there a way to make it work? I'm a novice with npm and I'm not sure how to install a specific version of your package from github.
I tried
npm install https://github.com/rohit-gohri/redocusaurus#4d415d68d3f07cbbd9757f39ba68f915586379e4 --save redocusaurus
(4d415d68d3f07cbbd9757f39ba68f915586379e4 is your v0.4.2 commit)
but I still have the same issue

Yeah, sorry. 0.4.1 is the latest. 0.4.2 was for the internal package. I'm not sure what the problem is here because I have it running with 2.0.0-beta in the examples: https://github.com/rohit-gohri/redocusaurus/tree/main/example
Could one of you share a minimal repo where this is happening?

I've tried making the example working and it doesn't.
Le lun. 14 juin 2021 à 13:42, Rohit Gohri @.***> a
écrit :

Yeah, sorry. 0.4.1 is the latest. 0.4.2 was for the internal package. I'm
not sure what the problem is here because I have it running with 2.0.0-beta
in the examples:
https://github.com/rohit-gohri/redocusaurus/tree/main/example
Could one of you share a minimal repo where this is happening?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rohit-gohri/redocusaurus/issues/57#issuecomment-860618660,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEQ6LFSVD7ZO2SNGF3ZBY3TSXTLVANCNFSM46RPLOSA
.

+1 - Cloning your repo and doing an npm install + npm run start in the example folder brings up the issue for me.

I was encountering the same issue (see my comment in #14). I was able to workaround it by downgrading the installed version of Redoc to v2.0.0-rc.53.

I think I would have to pin redoc dependency to a specific version instead of using ^

Same issue using GitHub Actions to compile and publish the docs to GitHub Pages:
Module not found: Error: Can't resolve 'fs' in '/home/runner/work/docs/docs/node_modules/redoc/bundles'

create a sitePlugin.js file, so you can customize docusuarus webpack
module.exports = function (context, options) {
  return {
    name: 'custom-docusaurus-plugin',
    // eslint-disable-next-line
    configureWebpack(config, isServer, utils) {
      return {
        resolve: {
          alias: {
            path: require.resolve('path-browserify'),
          },
          fallback: {
            fs: false,
            http: require.resolve('stream-http'),
            https: require.resolve('https-browserify'),
            os: require.resolve('os-browserify/browser'),
          },
        },
      };
    },
  };
};

import on docusuarus.config.js
module.exports = {
plugins: [require.resolve('./sitePlugin')],
}

@sibelius That looks promising, could you open a PR adding them here: https://github.com/rohit-gohri/redocusaurus/blob/main/packages/docusaurus-theme-redoc/src/index.ts#L18-L27

Should be fixed in 0.4.4


Attachments - Retain Original Upload Date

As a user
I want the original upload date to be retained when I edit a files name or tag
so that it preserves more accurately when things were added

Assumptions & Scope
This is based on user feedback we've received regarding the attachment log. When a user renames a file, the upload date changes. The users would like the original upload date to remain static when they make changes to filenames in the attachment log.
What is IN scope?
Renaming a file, reclassifying file tag (#3398)
What is OUT of Scope?
Replacing a file - this should always update the upload date
Acceptance Criteria
Scenario 1: Rename File

GIVEN a user is on the attachment log
WHEN they rename a file
THEN the upload date will remain the same as the original upload

Scenario 2: Re-Classify File

GIVEN a user is on the attachment log
WHEN they reclassify a tag on the file
THEN the upload date will remain the same as the original upload

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Reclassifying file tag (#3398) may need to be done before, or in tandem, with this ticket (as this ticket references this feature)
Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

Hi @milosdes - it might be that we should have had an AC for this, but under the assumptions for this 'Replacing' a file should update the upload date. Users only really have this option if a Ministry user uploads a file as part of a state change (you handled something similar with the re-classify story). Do you think you could fix this quick?

Per discussion - moving this one back to review, let me know when its been resolved and I'll finish the QA on this one. Thanks!

Chatted with @m-prodan  -
We currently aren't storing any kind of replaced_at date explicitly, we might want to consider doing that for audit log purposes at some point in the future.
For now, we just want to display the date when the document was replaced on the frontend.

The issue with the date changing when using the "Replace" function for an attachment has been fixed

Working as expected now - thank you for the fix @milosdes


Abandonware: No Updates In Over A Year

Is this Abandonware, there doesn't appear to be any updates in over a year. Wanting to check is this Abandonware?

I hope not, but it seems that way?


fix minor problems in tests

What this PR does / why we need it:
Find minor problems in tests during debuging the presummit timeout problem, since the PR #353 is closed, create new one to enhance that, thanks.
The main problem: in the test_job_pvc_mounting_without_path summits a serving and in the pass_test_serving_pvc_mounting simmits a job, should be a typo. And updated the serving type to ClusterIP since no need to loadblance for this cases. Thanks.

This change is

/assign @abhi-g

@abhi-g I'm pretty sure that's still needed. Thanks.


Disable sending email for activation

I don't want to use Djoser's URL Activation scheme, I much prefer the OTP Activation. Since Djoser doesn't offer an OTP alternative, I created my own OTP activation system. Is there a way I can prevent Djoser from sending the URL activation emails, Or is it something that needs to be worked on

Did you try
DJOSER = {
    'SEND_ACTIVATION_EMAIL': False,
}

?
Feel free to reopen if it doesn't work.


Fixed overlapping in feature editor

Fixes possible overlapping when multiple tag references are expanded.
New max-height 190 px = button 80 px + content 110 px
Closes #4023

I tried this out locally and it works great, thanks @jleh 👍


Consider: allow $select in params query when get

Consider if something should be done re https://github.com/feathersjs/feathers/issues/450#issuecomment-258151978

Leaving this with feathersjs/feathers#450 (comment) where it belongs.


[DOCS] Incomplete command to start docker for mongo

Description
In automated test documentation the command to start docker for mongo only is incomplete
It can cause problem for people who are not familiar with docker and they might avoid running tests
Screenshots

Additional information
No response

@md-abid-hussain so that maintainers can properly triage this issue can you please update the description to explain what is missing

It has to be changed to docker compose -f mongo-compose.yml up as they updated the message

Thanks @krishstwt 👍

Can you assign me this issue

@md-abid-hussain assigned you!


Prevent adding ServerName to TLSConfig (Issue #2027)

Quick fix for #2027
Signed-off-by: Eugene Chupriyanov<EMAIL_ADDRESS>

@echupriyanov we vendor the engine-api code.
Can you please open your PR upstream in https://github.com/docker/engine-api

Will do. Frankly, I opened it here mostly to illustrate the cause of the problem. Maybe there is a better place to handle it? Another way is to clear TLSConfig.ServerName after each engine.Connect() call. That way we don;t depend on engine-api

This should be fine. IIRC, hostname will be taken from the server's address if none is given in the tls.Config.
The only place where I know playing with ServerName might be an issue is when creating a tls.Client directly, in which case not passing a ServerName might mean we're simply verifying the validity of the certificate chain.

(Confirming that cherrypicking this solves #2027 for me)

@echupriyanov did you open the PR on engine-api ?

Sorry, was busy at primary job. Will do now.

Added PR (https://github.com/docker/engine-api/pull/173)

Looks like my PR in docker/engine-api is not accepted. Another option I see is to modify validatePendingEngine() call to create a copy of c.TLSConfig and pass it to engine.Connect().
I will try it tomorrow.

@vieux I’m not sure my PR https://github.com/docker/engine-api/pull/173 will be accepted.
So here is another way to resolve certificate/ServerName problem.

This PR is obsoleted by https://github.com/docker/engine-api/pull/179

Thank @echupriyanov for reporting the problem and helping with the fix.


Support-v4:25.0.0

Hello :)
I updated my Android Studio and now my compileSdkVersion is 25.
I have a warning with your lib, can you build a version with support-v4:25.0.0 please ?
Because now I can't have a different version of support (I can't mix version, for examples include com.android.support:animated-vector-drawable:25.1.0 and com.android.support:cardview-v7:23.4.0)
Thanks for you help :D
Math

+1

+1


fix: migrate subset of spread reward accums

Closes: #XXX
What is the purpose of the change
This feature is essentially identical to the work that was done on the incentive accumulators. There exists conditions in which dividing the spread factor by the liquidity amount results in truncation to zero, resulting in the proper amount of spread factor to be deposited into the spread factor module account, but not be distributed to LPs.
This will be fixed in two stages just like incentives:

Migrate over only the most at risk pools of truncation, as well as any future pool created after upgrade to the new scaled accumulator logic
Migrate over all remaining pools

Testing and Verifying
TBD

Summary by CodeRabbit

New Features

Introduced scaling factors for spread rewards in liquidity pools.
Added functionality for managing pool ID migration thresholds based on chain IDs.

Enhancements

Improved calculation of default spread reward accumulators.
Updated upgrade processes to handle new constants and pool migrations more efficiently.

Bug Fixes

Corrected the handling of spread reward accumulations and scaling during swaps and liquidity operations.

Documentation

Clarified function purposes and updated method descriptions related to spread rewards and pool migrations.

Expanded a test https://github.com/osmosis-labs/osmosis/pull/7876/commits/e9e7c20537e34307f6dba1380ac2a57821b115d2
^ This would have caught the following bug https://github.com/osmosis-labs/osmosis/pull/7876/commits/352c954473170dd28a7dae22ba213461336ea749
Thanks @PaddyMc for running in place testnet to highlight this


Add more instructions for automated builds

Hi @jmyersmsft, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Jonathan Myers). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Looks good to me; awaiting @emanuelquintero's signoff as well.

(shipit)


Micrometer Metrics

Ported the default MetricsCollector and LastActivityMetricsCollector to Micrometer for those on Spring Boot 2.
Moved MultiplexingMetricsCollector to the core module as it is independent of the metrics technology.
Switched travis to openjdk8 as oraclejdk8 is not supported anymore

* Ported the default `MetricsCollector` and `LastActivityMetricsCollector` to Dropwizard for those on Spring Boot 2.

Meant to say Micrometer?

@jhorstmann Do you need anything else to get this merged?


Many icons missing

All of the icons that are slate-specific are gone. This includes:

The BBD settings icons (The discord settings icons are all just gears
The connection button icon
The home button icon
The discord logo icon
The attachment icon
The gif, sticker and emoji icons

This should be fixed.

User icons take forever to load..

Please. Provide. Screenshots.

oop the settings icons are missing and rearranged now (the rest is fixed)

Fixed.


Updating submodules

Issue #, if available: Fixes #34
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tlindsay42 I understand @vsnyc is presently not able to do a complete e2e due to expired licenses.  I can do it.  Can you point me to some docs or anything describing what you need to see to merge this?

 Would you post a screenshot of a successful deployment in the AWS CloudFormation console, please? I recommend redacting the account number at a minimum. Here's a recent example: https://github.com/aws-quickstart/quickstart-amazon-eks/pull/471#issuecomment-1338343387.

@tlindsay42 @vsnyc I love it when work evaporates like that.  Thanks friends.


Merge pull request #1 from cmaron/master

Updates from master

More updates.

Sorry. Wrong way round.


GC: wasmparser: Add user defined array types

This adds basic support for user defined array types, for example:
  (type $a (array i32))
  (type $b (array (mut i32)))
  (type $c (array (mut (ref null $b))))

@fitzgen Can you take a look?

Weird, CI/Rustfmt check is complaining but locally cargo fmt doesn't produce a diff 🤷♂

I'm a bit strapped for time this week so I'm going to hand this over to @fitzgen from here.

@imikushin: I went ahead and resolved all the comment threads that are, well, resolved. Anything that is still open should correspond to either something that needs to change in this PR or a follow up issue that needs to be filed.

@imikushin: I went ahead and resolved all the comment threads that are, well, resolved. Anything that is still open should correspond to either something that needs to change in this PR or a follow up issue that needs to be filed.

@fitzgen Thanks. Addressed the feedback, PTAL.

@alxgrk Not yet. I'm working on it though, so in about a month it will.


January 19 Meeting Minutes

January 19 - Meeting Minutes
Today we discussed that we will need users to specify which column they would like considered as a categorical variable.
There is no way to decipher what is text and what is categorical data otherwise.
We will add a new argument for all our functions and the columns that do not fit into boolean data, numerical data, categorical data (user specified) will not be considered into our kNN model used for imputation.
Tasks
Lisa:

[x] update readme with necessary arguments
[x] update docstrings in our script file

Thank you,

Both tasks completed. @kenuiuc  needs to complete and update the README for his Date imputer, but all others are done.

I updated the readme since we are using median point of dates. Completed


Chat command - killcount not working

When using the !kc chat command, a lot of the options will not show the kill count, the bosses I have tried is jad, armadyl, zamorak, vorkath, zul'rah, king black dragon and barrows. Each of these didn't work when I tried to use the kill count chat command. However "!kc bandos" and "!kc general graardor" did work and showed my bandos killcount. The price chat command works fine but just not the kill count command, and because it shows my bandos kc it proves it is toggled on.
To Reproduce
Enter into the chat "!kc [boss]"
Expected behavior
When entered into the chat a lot of bosses will not show the players kill count for the bosses and just show the command
Screenshots

Environment (please complete the following information):

OS: Windows 10 - 64 bit
RuneLite version: [e.g 1.4.14]

Have you killed these bosses or viewed your boss log in your ring of wealth on Runelite? If not, it has no way to know what your boss kill count is.

You nee to either get the kill or check ring of wealth


Add exceptions to exponential

Add a test in exponential that tests if the base is negative. In that case the exponent has to be an integer or we will get imaginary numbers. I.e add an if which throws an imaginarynumbersexception if the base is negative and the exponent is not a whole number.

Fixed d958d713ae04bdf4c66e5a49056a652584414580


[SPARK-19750][UI][branch-2.1] Fix redirect issue from http to https

What changes were proposed in this pull request?
If spark ui port (4040) is not set, it will choose port number 0, this will make https port to also choose 0. And in Spark 2.1 code, it will use this https port (0) to do redirect, so when redirect triggered, it will point to a wrong url:
like:
/tmp/temp$ wget http://<IP_ADDRESS>:55015
--2017-02-23 12:13:54--  http://<IP_ADDRESS>:55015/
Connecting to <IP_ADDRESS>:55015... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://<IP_ADDRESS>:0/ [following]
--2017-02-23 12:13:54--  https://<IP_ADDRESS>:0/
Connecting to <IP_ADDRESS>:0... failed: Can't assign requested address.
Retrying.

--2017-02-23 12:13:55--  (try: 2)  https://<IP_ADDRESS>:0/
Connecting to <IP_ADDRESS>:0... failed: Can't assign requested address.
Retrying.

--2017-02-23 12:13:57--  (try: 3)  https://<IP_ADDRESS>:0/
Connecting to <IP_ADDRESS>:0... failed: Can't assign requested address.
Retrying.

--2017-02-23 12:14:00--  (try: 4)  https://<IP_ADDRESS>:0/
Connecting to <IP_ADDRESS>:0... failed: Can't assign requested address.
Retrying.

So instead of using 0 to do redirect, we should pick a bound port instead.
This issue only exists in Spark 2.1-, and can be reproduced in yarn cluster mode.
How was this patch tested?
Current redirect UT doesn't verify this issue, so extend current UT to do correct verification.

Was this fixed otherwise in master, or did some other change make it obsolete? just trying to link this to whatever reason it's only a problem in 2.1, for the record.

Due to the change of (https://github.com/apache/spark/pull/16625), the issue is obsolete. So it effects spark 2.1 and 2.0.

Not sure why Jenkins test cannot be started automatically.

Test build #73498 has started for PR 17083 at commit 5408005.

Test build #73498 has finished for PR 17083 at commit 5408005.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73498/
Test PASSed.

Test build #73551 has started for PR 17083 at commit 9ee6a09.

Test build #73551 has finished for PR 17083 at commit 9ee6a09.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73551/
Test PASSed.

Ping @vanzin , do you have any further comments? Thanks a lot.

Merging to 2.1 / 2.0.

@jerryshao I think you'll need to manually close the PR.

OK, Thanks @vanzin .


Rendering test cases to cover 64bits shaders

@ibgreen Actually compared with 32bit images,  overall have 2% differences, primarily happens on the AA (alpha blending) pixels, if excluding the AA pixels,  the percentage can be less than 0.1%. Anyway it is impossible to be detected by human eyes.


fix: ValidateCodeActionModal is not dismissed on backdrop press

Explanation of Change

Issue: Pressing backdrop in validate code page does not dismiss the RHP, only navigates back.
Fixed Issues

$ https://github.com/Expensify/App/issues/51272
PROPOSAL: https://github.com/Expensify/App/issues/51272#issuecomment-2429842900
Tests

Go to Settings > Security > Add copilot
Proceed to add a copilot
In validate code page, click outside the RHP
Verify the RHP is dismissed

Verify step 4 with similar flows: Add new contact method, Add bank account in a new account, Report card fraud, Reveal card details

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Go to Settings > Security > Add copilot
Proceed to add a copilot
In validate code page, click outside the RHP
Verify the RHP is dismissed

Verify step 4 with similar flows: Add new contact method, Add bank account in a new account, Report card fraud, Reveal card details

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/9d0b9ebf-a45b-4afc-8d17-8f67161ec309
https://github.com/user-attachments/assets/096c0705-c699-4701-9ac1-9643ef60587c
https://github.com/user-attachments/assets/2c02e89e-85f0-4173-9d62-681feb738c10
https://github.com/user-attachments/assets/556d3700-34eb-4550-bd11-adc593f1d47f
https://github.com/user-attachments/assets/ec657d90-c7c5-46a5-9417-072895fd03d7

MacOS: Desktop

https://github.com/user-attachments/assets/f4051a04-8fab-40f5-b16a-d43640f468d9

Bump @sobitneupane.

@mkzie2

Verify step 4 with similar flows: Add new contact method, Add bank account in a new account, Report card fraud, Reveal card details

Can you please add this step in QA as well.

@mkzie2 The animation looks bit off. Can you please check it.
Expected(slide animation):
https://github.com/user-attachments/assets/c43bb645-97a9-4bf1-9855-9ae819853654
Actual Result:
https://github.com/user-attachments/assets/fdf622c3-3af9-4862-b03f-28045ed2f03e

@sobitneupane Seems like same as https://github.com/Expensify/App/issues/51254. I have requested reopening the issue and let SWM work on it.

@mkzie2 It looks like a different issue to me.

@mkzie2 The animation looks bit off. Can you please check it.

@sobitneupane The reason is the validate code is modal in the ConfirmDelegatePage. So if we call Navigation.dismissModal() when the validate code modal is shown, the animation in ConfirmDelegatePage is hidden by DelegateMagicCodeModal. I checked other places where we do the same with a modal on the page, you can see the video here and the animation is the same.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Install issues -Conda 4.13.0

Hi Saskia, sorry I know there have been qs along these lines already, but I've tried the solutions posted (moving the bin files?) - and it isn't working :(
So decona seemed to download and install fine
~/anaconda3$ conda env create -f /home/sarah/anaconda3/decona/install/decona.yml
and then /anaconda3/envs/decona/bin$ ls
gives a list of all the files as expected?
but I'm getting the same message as others when in the decona env,
eg conda -h ... and i get a list of commands
decona -h ... and i get  decona: command not found.
Sorry, am a little rusty with linux, its probably something really simple, but have no idea how to solve this one...
thanks in advance
sarah

eg of trying to run example data
(decona) sarah@BIO-147768:/mnt/c/data/trout_decona/example_data$ decona -q 10 -c 0.80 -n 100 -M
decona: command not found


change plugin folder name to opensearch-sql-plugin

Signed-off-by: Kavitha Conjeevaram Mohan<EMAIL_ADDRESS>Description
Providing alias for plugin folder name and changing the plugin name in respective files too.
this PR ports #662 to main
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #670 (5f00b9f) into main (7cbb121) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #670   +/-   ##
=========================================
  Coverage     94.67%   94.67%
  Complexity     2801     2801
=========================================
  Files           280      280
  Lines          7570     7570
  Branches        558      558
=========================================
  Hits           7167     7167
  Misses          349      349
  Partials         54       54

Flag
Coverage Δ

query-workbench
62.76% <ø> (ø)

sql-engine
97.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cbb121...5f00b9f. Read the comment docs.


Build fails for Android on the latest expo SDK

Thank you for supporting expo, makes using statsig really easy!
When using the lastest Expo SDK (v48) and installing statsig-react-native-expo building the app fails with the following error:
The Android Gradle plugin supports only Kotlin Gradle plugin version 1.5.20 and higher.
[stderr]
The following dependencies do not satisfy the required version:
[stderr]
project ':expo-device' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.4.21

after a bit of digging the issue is down to the expo-device package, updating it to version ~5.2.1 fixes the build, there are also other dependencies that are outdated, and would be great to release a new version with this package with all the updated dep
I'd create a PR myself but I'm not sure about the workflow and if is as simple as bumping the dependency up and merging it
If anybody else is facing this same problem, installing   "expo-device": "~5.2.1", as a dependency of the react native project mostly fixes the problem, it builds as the direct dependencies are favoured in the dependency tree resolution but could lead to subtle bugs hard to track down

Thanks for the detailed report - we would welcome a PR if you have one, but we would still run tests before bumping the package and publishing a new version.  If not we can take a pass at updating dependency versions tomorrow

We've updated dependencies in https://github.com/statsig-io/react-native-expo/releases/tag/v4.7.0 - it is unclear if this still applies.  Closing, please reopen if you are still blocked


404 not found in chrome

Hello,
Please help me,
I am getting error 404 not found in chrome browser when integration with ckeditor, but in local work properly and another browser fine. Thank you very much

Please upgrade to v1.7.2.

Tested and worked just fine. Maybe you should clear the cache of you Chrome.

thanks a lot


Group Buy Plans

Heyo,
Wondering if you have any plans to run a group buy for this any time soon. Also, the build log is awesome - do you have something similar for ideas/planned changes/what still needs to be done (even if just for personal satisfaction)?
Awesome work; hoping to have these driving my first crkbd and/or ergodash boards.

None. No plans. Regarding ideas, see midmount and devel branches, PCBs are yet untested (still waiting for them, turnarounds are like 2 months considering sourcing all the components and sometimes it gets lost in transit). I got rid of voltage regulator, there's an internal one, added power mosfet and a better battery divider (800K/2M) to minimize leaks but it costed a physical switch and reversability in favor of ultra low profile (~2.5mm if you remove shielding).


Address wrongly normalized to highway contract: starr to hc

The address 10135 starr st sw is converted to 10135 hc st sw

@kapitanluffy  Thank-you for your contribution! The packages affected by this PR have been updated/deployed with a patch version bump.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/56330

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/56361

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/73239

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/73245

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/73251

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/73283

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/76116


Fix FutureWarning resulting from CFTimeIndex.date_type

With the latest version of pandas, checking the date_type of a CFTimeIndex produces a FutureWarning:
In [1]: import xarray as xr

In [2]: times = xr.cftime_range('2000', periods=5)

In [3]: times.date_type
/Users/spencerclark/xarray-dev/xarray/xarray/coding/cftimeindex.py:161: FutureWarning: CFTimeIndex.data is deprecated and will be removed in a future version
  if self.data:
Out[3]: cftime._cftime.DatetimeProlepticGregorian

I think it was a typo to begin with to use self.data in cftimeindex.get_date_type (my mistake).  Here I switch to using self._data, which is used elsewhere when internally referencing values of the index.

thanks


Mouse events not detected after x co-ordinate crosses 127

On the extreme right of wider terminals the mouse events are not detected. This is because of the decoding/encoding technique used on data regarding mouse events. While decoding the x co-ordinate:
https://github.com/chjj/blessed/blob/master/lib/program.js#L388
65533 will be returned if actual x in data was > 127
To fix the issue I would recommend directly passing the buffer data and handling it within _bindMouse

@mgliewe looks like 1005 is already being set: https://github.com/chjj/blessed/blob/master/lib/program.js#L2830-L2835

@mgliewe looks like 1005 is already being set: https://github.com/chjj/blessed/blob/master/lib/program.js#L2830-L2835

seems this issue is client-specific.
did some testing, works fine on xterm and gnome-terminal. Fails on lxterminal and xfce4-terminal. rxvt is a mess, no coords>127 and no mouse motion events there.
Both xfce4-terminal and lxterminal use libvte, whereas gnome-terminal uses libvte2. I guess libvte has a problem with proper encoding for mouse events, looks like a classic signed/unsigned char mismatch.

@mgliewe I can confirm your findings, with one exception: on GNOME Terminal 3.6.2 I am not getting mouse events past 127.

I would blame libvte as well. VTE is well-known in the terminal world to be a mess, unfortunately. I've never had issues with xterm, which is what I test with (and xterm pretty much is the standard for this).
On a separate note, rxvt uses a separate protocol \x1b[{d;d}M instead of \x1b[M{unicode}. It's a bit easier to parse (but arguably flawed). I've never had issues with rxvt-unicode. I'll look into that, @mgliewe.
Ideally, we should be posting on the libvte issue tracker. Otherwise, we can try to decipher vte's nonsense.

@secrettriangle: thats strange, I have 3.6.2 as well.
could you do a gnome-terminal --version and a ```ldd `which gnome-terminal```` to confirm its libvte to blame?

@mgliewe
$ gnome-terminal --version
GNOME Terminal 3.6.2

ldd $(which gnome-terminal)

@secrettriangle funny, i have the same. whats your locale? I have LANG=de_DE.UTF-8..

@mgliewe LANG=en_US.UTF-8

Just tested gnome-terminal and urxvt. gnome-terminal is indeed bugged. The VTE folks need to get around to fixing this. In the meantime I guess we have to pay for their mistakes. URXVT seems fine. I had no issues with mouse support (I never did before either).

I messed around with gnome-terminal a bit. The mouse events are just bizarre. I've added a few workarounds, but gnome-terminal still can't go beyond cell 255 on the X axis.

https://github.com/GNOME/vte/blob/master/src/vte.c#L5493
It looks like VTE supports URXVT's mouse protocol. We can just use that if we detect VTE's env variable. I just tested it and it works great.

Its working with mc though.. I was thinking about looking at strace dumps whats going thru the line but didnt got the time yet.

Marking this as fixed by https://github.com/chjj/blessed/commit/127ae12c1b021c503cc5afad05bb4576fc01ec06. URXVT's protocol works fine with VTE.

v0.0.40 published in npm. It would be nice if everyone gave it a try with gnome-terminal or another VTE terminal. Also, what's the deal with iTerm and Terminal.app? Are there mouse issues with those too?

just tried on ubuntu with xfce4-terminal, alas, still aint work.
config:
http://paste.ubuntu.com/9983080/

mouse doesn't work at all anymore on rxvt,
config:
http://paste.ubuntu.com/9983255/

@mgliewe, I'm not even sure which mouse protocols the old rxvt even supports. I'll try the xfce term, but gnome term works fine now.

It looks like XFCE term is using an older VTE which doesn't set the VTE_VERSION environment var, so it's not using the urxvt protocol. It does set an env of its own though. We can account for that.

Ugh, it doesn't look like this older version of VTE supports the urxvt protocol. Back to the drawing board for this one.

@chjj: i did a strace dump on mc@xfce4-term (which works just fine)..
interesting part: it opens an extra fd on /dev/tty and gets its input from there..
unsure what exactly the impact of that is..
strace -e trace=open,close,write,read -e write=1 -e read=4 -o dump mc produces (somewhat cleaned up):
http://paste.ubuntu.com/9985354/
i guess the interesting parts are:

lines 4-27: term init
lines 1703-1726: some text input
lines 3448-3471: mouse move&click lower-right

i'm not so  famillar with the  escape codes and would have to look them up. maybe you can tell by look what protocol is running there?

Interestingly enough MC seems to ask for: SGR mouse protocol (1006), vt200 hilite (1001), and cell motion (1002). A very odd combination. However, VTE just ends up spitting out the X10 protocol incorrectly still. If your version of XFCE term is using the latest VTE, this should work fine though. VTE works great with the SGR and URXVT mouse protocol.

VTE will never be able to get above cell 232 with it's current X10 mouse code:
	} else if (cx <= 231 && cy <= 231) {
		/* legacy mode */
		len = g_snprintf(buf, sizeof(buf), _VTE_CAP_CSI "M%c%c%c", 32 + cb, 32 + (guchar)cx, 32 + (guchar)cy);

However, since 0x00 - 0x20 are not normally allowed bytes, we can add them and up the limit to 255. @mgliewe, it looks like you're using a different version of VTE with xfce term which allows SGR mouse events, not the x10 ones. It is flat out impossible to get beyond cell 255 with VTE using the x10 protocol. MC is using SGR mouse events there. You must have a later version of VTE linked to MC which allows it to go beyond that. We just have to hope people using VTE terms are using the later versions.

If you look at the C excerpt there, you see it's even limited at 232 (231 zero based), and uses snprintf for %c, casting the coords to unsigned chars (limited at 255 of course).

This is just unfixable with VTE the way it is in older versions. I'm keeping this closed. There's no way to fix it. We just have to wait for people to upgrade their VTE versions so we can use URXVT or SGR mouse events.
All that being said, which mouse protocols does the original rxvt support? We can work on that next.

Just played around with rxvt. Just like the old VTE version, it does not support the X10 UTF8 extension. It's permanently limited to ascii byte range. We're lucky the later versions of VTE do support SGR and URXVT protocols. @mgliewe, that's the reason MC was working in XFCE for you. If you were using an older version of VTE, it would not have worked at all (the strace clearly shows MC using the SGR extension).

I also want to make it clear because my last post left the wrong implication, the current VTE still does not support the UTF8 extension, the only reason it's possible to go beyond the ascii cell limit is because it now supports SGR and URXVT protocols.

i'm sorry, still have to get back on this one (i know i'm a bit insistent, but my config is pretty wide spread, i guess lots of people will run into this).
there must be some other things going on there. even when i force blessed to use exactly the same modes as mc does, i have the same effect.
There must be something in mc init enabling bigger coords.  might that has anything to do with opening a new fd for /dev/tty?
(btw: we're talking about 127 cell boundary, not 232 or 255).

(btw: we're talking about 127 cell boundary, not 232 or 255).

@mgliewe, I've already explained this by posting the VTE code.
  } else if (cx <= 231 && cy <= 231) {
        /* legacy mode */
        len = g_snprintf(buf, sizeof(buf), _VTE_CAP_CSI "M%c%c%c", 32 + cb, 32 + (guchar)cx, 32 + (guchar)cy);

Notice the limit (231, really 232 when 1-indexed). In old versions of VTE it seems to overflow (since it's just an unsigned char, once it goes above 255, it loops around to 0). Since the x10 mouse protocol doesn't normally allow chars 0x00-0x20, we can safely assume chars from that are an overflow, giving us another few cells. With that workaround I managed to support up to 232+ cells even though VTE only uses ASCII, not unicode.
@mgliewe, the VTE code is plain as day. It does not support UTF8. It looks like the vte folks were comfortable limiting their terminal to the issue we're running into here.
The fact that you can have MC use SGR mouse and it works, and blessed doesn't is odd. SGR mouse works for me in blessed with version (3) 0.38.3, but does not with (290) 0.36.3. Based on your stack trace, MC is very clearly using SGR, not the x10 mouse protocol. It's just logically impossible that anyone be able to decipher high coords from x10 in a vte terminal.
I'm really not sure how MC gets SGR working in older versions of VTE, but that's definitely what we should be focusing on here: getting SGR working by sending VTE the escape sequences it wants to see to enable it.

@mgliewe, after looking into it more I've discovered how MC does it: it uses the exact same workaround I do to get up to 255. I'll just be implementing that. That's the best we can do really.

I've sort of perfected my VTE x10 workaround. VTE terminals can now access coords up to [287,287]. This is exactly how MC deals with this problem as well. I'm considering this issue closed for good now.

Also, if anyone else discovers more env variables for VTE terminals, that would be useful. Maybe I'll just check for absurdly high utf coords and detect the buggy VTE that way.

The commit above goes about detecting the bugged VTE in a trickier way.  This way, we don't have to check for env variables. Even lxterminal works now.

confirmed.
nicely done.

Feels good to get this out of the way. Now we can say we support pretty much every mouse protocol. I'm going to open and reclose this issue to make me feel better. :)


home-assistant: 0.83.3 -> 0.84.1

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Will check it out this weekend.

@GrahamcOfBorg eval


Opening a notebook in a codespace

open a ipynb file in a codespace
->

Issues:

python extension activation shows the welcome page stealing the focus from the notebook that I opened //cc @brettcannon
I get immediately asked for a survey
the kernel port gets forwarded (this is a missing API adoption, @alexr00 has the details)

@alexr00, some of the ports opened here don't need to be forwarded, please let us know how we can hide such ports. Thanks

The popup should not appear the first time in code space, this should only appear if user opens 5 notebooks or executes 100 times/cells (in total).
TODO: Test & confirm this popup, we've got a few similar issues (possible its not working as expected)

This is the link for the port forwarding issue: https://github.com/microsoft/vscode-remote-release/issues/4727

I'll get this into our next request (tomorrow)
https://github.com/microsoft/vscode/issues/115616

@DonJayamanne please do comment in https://github.com/microsoft/vscode/issues/115616 if you have any questions or feedback on the API! I was going to wait another week for the API to become a bit more stable before asking if microsoft/vscode-jupyter to try it out, so please be aware that it may change without warning. If you make a PR for adopting the API, I'd love to be @ mentioned or included on the review so I can understand how extensions use the API!

@alexr00 I'm assuming I'd need to use PortAutoForwardAction.ignore to ensure these ports are not forwarded, please could you confirm this? Thanks

As this is CodeSpaces with Insiders, I'm not going to rush this for the Release,

@DonJayamanne Yes, for ports that the extension knows about and are internal to the working of the extension, use PortAutoForwardAction.ignore. For ports that the extension doesn't know about, simple exclude them from your returned array of attributes. If there are any ports that the extension knows about but are external to the working of the extension, i.e. user facing, you can return PortAutoForwardAction.notify if you want to make sure that the user is notified, or you can simply leave them out of your returned array and let the user's settings handle whether they get notified.

The port notification we should suppress. However, the survey notification shouldn't show at all. No survey notifications should show on codespace.

@DonJayamanne I see that you have adopted the port attribute API 👏 Do you have any feedback on the API? Was it easy to understand how to use it?

Validated.


addon for prometheus in openshift 3.7

the current addon works for 3.6 - but for 3.7 we also need the node exporter and alert manager

@durandom @jorgemoralespou Is there no way we can make the existing add-on to work for both 3.6 and 3.7?

I cant think of a way how. 3.6 needs a different application template. Unless there is a way to conditionally run oc commands, I dont see how

Unless there is a way to conditionally run oc commands

No such way as of now in add-on. Two options

Keep separate addon folder for both version
One addon folder

We need one prometheus.addon and another prometheus.3.7.addon.example
Document how to use 3.6 version with prometheus.


update DiscordInteractionData interface

Closes: #2157
Upstream: https://github.com/discord/discord-api-docs/commit/4bcaa7d5de8a24e2903356d1d50a93b1a7e5453a
add guildId to DiscordInteractionData
also update interaction transformers
fix: it looks like someone forgot to update DiscordInteractionData (reading discord docs it has the type field/property) so I added type field/property to DiscordInteractionData. Tell me if I should separate this single change into another PR
Note: I did reorder some properties accordingly to Discord docs.

reverted re-order changes


Add GravityTurn mod

Looking forward to having this added.

https://github.com/KSP-CKAN/NetKAN/pull/2924 suggests they tried and the pull request failed due to checks that did not pass

#2924 is not my pull request.  I wasn't aware Kerbalstuff did that.  These checks passed, just like they did for my previous mod SlingShotter.


Do we need to enable the custom metrics for the controller monitoring

Right now, we already enable the metric here:
https://github.com/redhat-developer/build/blob/master/cmd/manager/main.go#L38-L40
And we can see the basic controller reconciliation and queue metrics in the monitoring system.
But are they enough for us? the metrics above are just the high level controller metrics.
Do we need some custom metrics to help us more?
Such as adding the metrics:

How many builds
How many buildruns
How long a build is ready
How long a buildrun is ready
etc...

I think those metrics can help us to monitor the controller and debug the problem more easily.

I also think adding custom metrics to provide observability on the operator features/actions quite interesting path to explore.
As you mention, @zhangtbj, those metrics are employed to monitor the functional status of the operator, letting you know about issues. Following the same path, those metrics can also be employed to create dashboards with interesting information for final users of the operator.
Thinking out loud, by providing customized metrics we would be able to create dashboards to show information like:

How many builds happen in a day
What's the average duration of a build
What are the "top 10" slow builds;
How many images are pushed into container registries;
How many container registries are in use;

And many other interesting insights for a team/company that decide to use our operator to automate the container images build.

Sounds good! Curious, how would we report this metrics ?

Sounds good! Curious, how would we report this metrics ?

It's fairly easy to enable it with operator-sdk, please consider.

Yes, but the operator-sdk just provide some basic controller level metrics, which we already get in our sysdig:

The advanced case, such as how many build/buildrun, how long a build/build take. they are the special case, not a general case for all controllers, so we need to develop/define in our controller logic by ourselves.
May based on this:
https://godoc.org/github.com/prometheus/client_golang/prometheus

Hi @sbose78 , @otaviof and @qu1queee ,
I added and verified 6 basic custom metrics:

controller up status
build count
buildrun count
buildrun establish time
buildrun execution time
buildrun execution time histogram

And this is the PR:
https://github.com/redhat-developer/build/pull/235
It works correctly in our Sysdig system and helpful for our operation.
Pls review.

How many builds happen in a day
What's the average duration of a build
What are the "top 10" slow builds;
How many images are pushed into container registries;
How many container registries are in use;

@zhangtbj I see that in your PR #235 You have not added metric for What's the average duration of a build.
Is it intentional?

Hi @DhritiShikhar ,
I just added the basic metrics which we verified and required immediately.
We can continue adding more metrics if we want.
About What's the average duration of a build, I don't understand it clearly:

Is it about a build or about a buildrun execution duration?

We already have each buildrun execution time and the summary of the buildrun execution time.
So you can use the monitoring to show the histogram of the buildruns or summarize the average of the buildrun establish or execution time as an average in sum or in a period of time.

I just added the basic metrics which we verified and required immediately.

Sounds good!

Is it about a build or about a buildrun execution duration?

Build execution duration

Yep, we have some basic metrics.
We can use them as the original data and show what you like,
Such as average, sum, top, etc... in the monitoring system :)

Refined the custom metrics by build labels, so that we can know how many builds/buildruns or how long it takes by different build label:

Compared with tekton custom metrics:
https://github.ibm.com/coligo/tekton-pipeline/blob/ibm-master/docs/metrics.md
We are still sample and can be improved in future continually.

For release 0.1,
We just provide some basic custom metrics.
Jordan will provide another new issue to document what is the limitation or not good in current logic, so we can think about how to refine the logic and add more metrics, such as:

How many total build/buildrun?

How many success or fail build/buildrun

how many running build/buildrun

how to record the execution time detail, do we want to do like tekton side to record each buildrun details

but for example, we don't have IsDone for build/buildrun

and doesn't like tekton, if the build or buildrun fail to get something, it will keep reconciling that also make us hard to record something easily

we also need to think about the case when the controller pod is killed or during the buildrun is executing but the pod is killed, how to have the current metrics during some special cases...

The basic metric enablement is done by using this PR:
https://github.com/redhat-developer/build/pull/235
Let me close this issue and use another issue to track the metric enhancement later.
Thanks all!


Extend with base template as well

Still trying to wrap my head around the whole concept, so bare with me if these are silly questions :)
I have my (mentioned earlier) Viewstack setup working in BC (Blaze-Components) now. And apart from an untrackable "must be attached" exception from somewhere deep within Blaze itself, everything is going fine.
So when I wanted to go the next step, I started thinking about "extend" in BC. It means the class itself, I get that. But what are the current thoughts about the template in the parent? E.g., Let's say I have a BC called ParentComponent, which has a template associated with it. In that template I could render all "chrome" for that component. Then if I want to create ChildComponent, I only want to add specific content for that Child without having to copy all the html from the ParentComponent.
In classic Blaze, I did something similar with:
<template name="Child">
  {{#wrapper}}
    My child content
  {{/wrapper}}
</template>

So one thing you might want to use is components as block helpers. It goes also a bit into making more custom components which can be dynamically controlled what to render.
But if you would like to do something more like you are approaching it above, you could do something like:
<template name="Parent">

    {{> childTemplate}}

</template>

<template name="Child">

Child

</template>

class Parent extends BlazeComponent
  template: ->
    'Parent'

  childTemplate: ->
    null

class Child extends Parent
  childTemplate: ->
    Template.Child

So in general, if you want to insert content inside a parent component, then parent component have to provide some placeholder where you want to do that. Wrapping parent component with more stuff is easier.
<template name="Parent">

Parent

</template>

<template name="Child">

    {{> parentTemplate}}

</template>

class Parent extends BlazeComponent
  template: ->
    'Parent'

class Child extends Parent
  template: ->
    'Child'

  parentTemplate: ->
    Child.__super__.template.apply @


css: Use SCSS nesting in reactions.scss. (2)

In this refactor most of the testing was done by three methods (or in the following three steps):

This is probably the most important one and the first thing I tried -- counting the number of elements. This had to be done with a mix of manual testing. Say for example I had to test for .emoji-popover-emoji, I simply opened the browser console and checked if $('.emoji-popover-emoji').length and say $('.emoji-popover .emoji-popover-emoji').length are equal. Here, there were two cases -- one where I search for the emoji and one where I don't. For both the cases I could easily verify where in the nesting hierarchy does this element belong.

Visually (manually testing if there's any change in the components) -- once it passes the above test. Especially when reordering elements, looking at the diff in console, which rules were applied before and which are applied now (because sometimes you do mess up the CSS priority order so manually checking is a must!)

Scrutinizing the template code (seeing if the components exist out of the parent I'm going to nest) -- git grep or using text editor search :)

CZO helped a lot for diffing styles simultaneously!

@vrongmeal can you comment on what testing you did for this PR?  Generally when doing a refactor like this for a particular CSS subsystem, it's worth doing manual testing of setting up a bunch of that content in the UI and then toggling back and forth between the branch and master to confirm that you didn't change behavior.  So you should include those details in the PR description for future refactors.

Also, for css: Seperate height of emoji map from results container., you make a functional change in terms of removing CSS from an element; the commit message should explain why that change is correct.
(In general, commit messages should explain anything non-obvious about the purpose of the commit, etc.)

Other than those comments, this looks great; reactions.scss now feels like much less of a hodge-podge of random changes.

(I merged the first ~3 commits).

@timabbott I updated the PR description and also changed the commit message.

Awesome, merged, thanks @vrongmeal!  This was a nice cleanup.


App categories

Are you considering adding categories to the app section the same way you can create them in bookmarks? It could be useful to organize things easier.

No. It was discussed many times before: #7, #32, #54 and #85.


Add read-only mode to tileset editor

Makes it so that the TileSet editor is opened in read-only mode when its respective tileset is embedded inside of a foreign resource. Introduces behaviour consistent with previous PRs covering similar things: #63249 #63245

I think the PR looks fine. It is hard to say if some areas might be missing a check, but this PR seems to cover the most important parts, which is better than nothing.

Will need a rebase.

Thanks!


Final UI

In this PR, I did the following

[ ] Finalize the UI
[ ] Updated the README.me

Approved 🥳
Hi @KanzaTahreem
Great work nailing the project 💪
Your project is COMPLETE! There is nothing else to say other than... it's time to merge it! 🚀 Congratulations!

Highlights
There are some excellent points that you have made perfectly. Keep up the great work! 👏

Great work using the right Git Flow  👍
Commits are descriptive, good work.
Linters are working properly, great job! ✅
testing is working

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
N/A
Cheers and Happy coding!👏👨💻💻


Jvb add deploy filter

related to https://github.com/srl-labs/containerlab/issues/1295
Note that the '--filter' option applies to several (most) commands, and could/should be generalized (just like --topology)
Note also that the link filtering logic may need updating; corner cases like a node connected to a bridge are not handled

thanks @jbemmel, this is a very good start.
@steiler and can take it from here, I suppose.

I am merging this to node-filtering branch so that all can create subsequent PRs to this base branch


Design mobile interface

We will evaluate the model's own confidence in its ability by simply asking it multiple times what is the next appropriate action. If it disagrees with itself, we will ask the user what to do next.
We would like to get human feedback on what to do next in the simplest and easiest way possible.
Interface:

SMS/Whatsapp
Swipe right/left

User is presented with list of options for what to do next. Then they can select:

<task_description>
<task_description>
...

"let me show you!" (desktop demonstration)

@abrichr I'm going to pick this one up. I'll start by putting together some prototype designs then will review them with you (and any others on the team) then will move on to building a prototype in Swift.


feat(schedules): fix translation not displayed when assigning spiritual gems

:tada: This PR is included in version 2.43.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


CI: xip.io error with hostname

Seen this a few times in the past. Not sure what is going on. Maybe an issue with xip? Full log here.

Use kube.gd going forward to save the pain of that service going down http://dns.kube.gd/


Not upgrading kernel version on Ubuntu mate

Latest raspbian converted to devuan using http://packages.devuan.org/devuan/pool/main/d/devuan-baseconf/.
After reboot kernel not changes.

Sorry, rpi-update is designed for raspbian.
Other distributions are not supported (and in fact rpi-update may break distributions that don't have use the raspbian kernel and file system layout).
If it doesn't work it suggests boot partition of sdcard is not mapped to /boot, but that is a question for the Ubuntu Mate maintainers.


Add a separate directory for integration tests in Java projects

The advantage of this folder structure because it keep the automatically generated folder test as it is for unit testing.

Added to Sprint 22.08

[ ] Rename the folder integration-test to test-integration because most developers are probably used to the first folder in src to be main.
[ ] Add the folder test-integration/resources to the integration phase.


How to transform a promise's value to something else without triggering it?

If you're familiar with ReactiveCocoa, what I want it's something like RACSignal's map: method, transform the promise's value to something else only when the promise's value is delivered. One overload of PromiseKit's then method  can transform the promise's value but will also trigger the promise. Maybe I should roll my own map:  method?

I don't understand what you mean by: trigger.

then has no side-effects to the Promise. It is the answer you are asking for I believe.
If trigger means “start” then then does not start a promise. The promise is started by whoever created it. Typically promises are started as soon as they are created. Though that is up to the creator.

You're right, then is all I need. By the way, according to your last answer, there's a way to defer a Promise's execution? That would be quite handy, because I want to past a Promise between objects as data source, and I don't want to start that Promise until it's actually needed.

The only way to defer a promises’ execution is to not create it until you need it.
Technically if you wrote the promise you could defer its execution eg:
func foo() -> (Promise, NSURLSessionTask) {
    var task: NSURLSessionTask
    return Promise { fulfill, reject
        task = NSURLSession.dataTaskWithRequest(rq) { data, _, error in
            fulfill(data)
        }
    }
}

let (promise, task) = foo()

task.resume()

Thanks, now I'm crystal clear.


Can you share the code to generate PQF_Labels and ApprQP_labels?

It seems you have some numpy arrays pre-saved in the directory for those specific videos. How can I generate PQF_Labels for new videos (in case I don't have the raw version)?

Hi zabir-nabil.
We use 38 features (36 of which are generated by a no-reference quality assessment method, and the other 2 features are QP and bitrate) and Bi-LSTM to detect PQF.
During our experiments, we find that QP is the key feature. You can detect PQF simply according to the QP of each frame.
The 36 features generated by the NR QA method (subjective quality score) are not consistent with the PSNR results (objective quality score), so they are not that important. For details and code about this QA method, please refer to Study of subjective and objective quality assessment of video. Finally, the training of Bi-LSTM is very fast.

Thank you for your answer, so if I understand you - I can find the PSNR curve from QP values of each frame only. Then why do I need the Bi-LSTM detector if QP can give me the frames with highest and lowest PSNR (I'm assuming PSNR is directly related with QP)?
Can you give me a link to any resource which has implementation details (python code) for calculating QP for each frame?

Thank you for your answer, so if I understand you - I can find the PSNR curve from QP values of each frame only. Then why do I need the Bi-LSTM detector if QP can give me the frames with highest and lowest PSNR (I'm assuming PSNR is directly related with QP)?
Can you give me a link to any resource which has implementation details (python code) for calculating QP for each frame?

QP (quantization parameter) is one of the basic informations generated by video codec and can be directly extracted from bit flow. Therefore, our MFQE approach targets mainly on compressed video (so the bit flow is available).
We recently find that QP is the key factor when detecting PQF. Without QP information, the detection accuracy may drop to 60~70%.
If you have no QP information, we suggest that you can search for some objective quality assessment approaches especially for compression artifacts, e.g. No-reference quality assessment of deblocked images, 2016 Neurocomputing. You can also consider other sota approaches based on Conv-LSTM etc that are with no need for quality assessment.

Okay, I'm looking into the paper for more details. In the meantime, kindly share the feature extraction and label generation code or any reference if possible [Could you kindly email me if that's an option<EMAIL_ADDRESS>Thanks


merge pull request

request to merge with the updates from this year from aldelaro5, if compatible

meeo is this gonna be updated lmao


Add sorting by date

Add sorting by date, as specified in the DG. https://ay2223s1-cs2103t-t10-3.github.io/tp/DeveloperGuide.html
Would appreciate extensive limit testing to try and break this.
Also, my implementation changed as I tested the feature and tweaked it to how I felt it should be used. So do test it and leave comments if you think the flow is bad.
Some example flows:
List -> Sort -> List
List -> Sort -> Edit (should stay in Sort view) -> List
List -> Add a bunch of applications with same company name but diff role and date -> Find by that company -> Sort -> Edit etc
and whatever you else you can think of :)
In terms of design, overview is given in the Commits themselves, but basically Sorting is implemented as a state that and the UI draws from two base InternshipLists. Most of this logic is in UniqueInternshipList.java

Codecov Report

Merging #82 (454085b) into master (5d378ba) will decrease coverage by 0.15%.
The diff coverage is 72.72%.

@@             Coverage Diff              @@
##             master      #82      +/-   ##
============================================
- Coverage     72.23%   72.08%   -0.16%
- Complexity      435      451      +16
============================================
  Files            74       76       +2
  Lines          1365     1422      +57
  Branches        143      149       +6
============================================
+ Hits            986     1025      +39
- Misses          328      344      +16
- Partials         51       53       +2

Impacted Files
Coverage Δ

...ava/seedu/workbook/logic/commands/EditCommand.java
93.24% <ø> (-0.10%)
:arrow_down:

...ava/seedu/workbook/logic/commands/SortCommand.java
0.00% <0.00%> (ø)

...va/seedu/workbook/logic/parser/WorkBookParser.java
80.00% <0.00%> (-4.22%)
:arrow_down:

src/main/java/seedu/workbook/model/Model.java
100.00% <ø> (ø)

...c/main/java/seedu/workbook/model/ModelManager.java
96.61% <60.00%> (-3.39%)
:arrow_down:

src/main/java/seedu/workbook/model/WorkBook.java
86.66% <75.00%> (-5.34%)
:arrow_down:

...orkbook/model/internship/InternshipComparator.java
75.00% <75.00%> (ø)

...orkbook/model/internship/UniqueInternshipList.java
87.09% <80.00%> (-5.59%)
:arrow_down:

...ava/seedu/workbook/logic/commands/ListCommand.java
100.00% <100.00%> (ø)

...java/seedu/workbook/model/internship/DateTime.java
93.54% <100.00%> (+5.08%)
:arrow_up:

... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Convert between Fixed and Rational?

Converting from Fixed into Rational should always be possible. That would allow you to get to other fractional types like Double. It would also let you get the integral amount out with round and friends.
>>> toRational (1 :: Deci)
1 % 1

>>> toRational (1.2 :: Deci)
6 % 5

-- no warnings or errors :(
>>> 1.21 :: Deci
1.2
>>> 1.29 :: Deci
1.2

Converting from Rational into Fixed might fail depending on the precision of the Fixed target and the number of digits in the Rational's decimal representation.
>>> fromRational 1 :: Deci
1.0

>>> fromRational 1.2 :: Deci
1.2

-- truncates :(
>>> fromRational 1.29 :: Deci
1.2
>>> fromRational 1.21 :: Deci
1.2

Related GHC issue for the 1.29 :: Centi == 1.2 problem: https://gitlab.haskell.org/ghc/ghc/-/issues/13232


[FEATURE] Introduce external storage API for Delta Log based on FoundationDB

There is a very good concept about storing Delta Log in DynamoDB, introduced in this PR.
However, DynamoDB might not be the tool of choice for users who are using other clouds or having an on-premise setup. Distributed KV storages with transaction support,  such as FoundationDB could be a nice extension for Delta Log storage.
Another benefit is that using such an external system it becomes possible to introduce multi-table transactions with explicit API, for example (just a concept, indeed the final API shall be revised):

val transaction = DeltaTransactionManager.beginTransaction()

df1.write.format("delta").withTransaction(transaction).saveAsTable("some_db.some_table_1")
df2.write.format("delta").withTransaction(transaction).saveAsTable("some_db.some_table_2")

transaction.commit()

Just to clarify, the linked PR doesn't really "store the Delta Log in DynamoDB". DynamoDB is only used to provide mutual exclusion, a feature that S3 is lacking by not having a "put-if-absent API". Mutual exclusion is one of the three properties on which Delta Lake ACID guarantees are predicated.
Are you interested in storing the entire DeltaLog in DynamoDB / FoundationDB? If so, are there specific use cases as to why you prefer to do so?
Thanks for making this issue and prompting this discussion!

Hi @scottsand-db ,

Are you interested in storing the entire DeltaLog in DynamoDB / FoundationDB? If so, are there specific use cases as to why you prefer to do so?

Yes, I think this is at least an interesting technical idea worth trying out, and here are some of the potential UCs and benefits of this approach.
Potential UCs:

low latency streaming (for instance, setting triggerTime to 1 second/continious blows out the ListFiles API costs)
HDFS-based use-cases - since in HDFS the listing operation always hits the HDFS master node, users with multi-million file tables might suffer from a heavy load on listing the file names. I understand that it's 2021 and HDFS is heavily outdated, but there are still some people doing it like this.

More opportunities:
Usage of fast, transactional & distributed KV-like stores with decent key listing performance as a metadata layer opens a door for further optimizations, such as:

File metadata can be stored inside such a structure with file location in S3. For example, counts/indexes, etc.
Potential unlock for OLTP use-cases, where part of data can be additionally written to/read from SSD-based cache, and such a metadata layer can keep a pointer towards SSD cache and S3 file
Potential support for re-partitioning on the fly by keeping a map between partition and set of files inside such a metadata storage

Some of these designs are already applied in other systems, for example, Firebolt and Iceberg.

Following up on this. Having a logstore that writes to FoundationDB won't work, as our LogStore APIs don't encapsulate all file system (log store) interactions, despite the name. e.g. checkpoints don't go through the LogStore.


Add send_message() function to the stdlib to expose the SMO opcode

The current work on the bridge project requires passing of MessageOutputs via the SMO opcode.
This functionality needs to be exposed in the stdlib.
reference:
https://github.com/FuelLabs/fuel-specs/blob/pixelcircuits-refactor-depositwithdraw-to-flat-messaging/specs/protocol/tx_format.md#outputmessage
https://github.com/FuelLabs/fuel-specs/blob/pixelcircuits-refactor-depositwithdraw-to-flat-messaging/specs/vm/instruction_set.md#smo-send-message-to-output

Blocked by: Opcode not yet implemented in FuelVM

@nfurfaro  these links generate 404's. Can you update them?

For future reference, you should also link with permalinks @nfurfaro. You can press "y" when you have a page open on GitHub to convert to a permalink.

closed by #2796


Mongdb support for raspberry pi?

mongodb The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

You are likely running this on an arm architecture such as araspberry pie, you'll need to find an image that compatible.

@jffluis
version: "3.9"

networks:
  mongodb-access:
    name: mongodb-access
    external: true

services:
  mongodb:
    container_name: mongodb
    image: mongo:6.0
    networks:
      - mongodb-access
    # ports:
    #   - "27017:27017"
    restart: always
    security_opt:
      - no-new-privileges:true
    volumes:
      - ./mnt/mongodb:/data/db

Just use the 'official' mongo image


cast args.port into string in cli flower

Coverage remained the same at 67.019% when pulling bacdd6a5fbac509e81998a7776f2783c111bf5ce on SivaPandeti:cli_flower_port_issue into 154dec0f747d899d8fa8c25c27e104cdaee9d137 on airbnb:master.

@SivaPandeti This has been fixed in master. We should consider closing this.


No datasets were found

Module: 06
Lab/Demo: 04
Task: Load data into the table's storage path
Step: 4
There is no returned data.
Warning: No datasets were found that match the expression 'RetailDB.dbo.Customer'.
Statement ID: {6D97EB15-84E0-4C75-BDD6-151350430D34} | Query hash: 0xC74B9B855CD85610 | Distributed request ID: {E9E904AE-6014-4F0B-A94F-8E622319E868}. Total size of data scanned is 0 megabytes, total size of data moved is 0 megabytes, total size of data written is 0 megabytes.
(0 record affected)
Total execution time: 00:00:11.455
Repro steps:

In the main pane, switch back to the files tab, which contains the file system with the RetailDB folder. Then open the RetailDB folder and create a new folder named Customer in it. This is where the Customer table will get its data.

Open the new Customer folder, which should be empty.

Download the customer.csv data file from https://raw.githubusercontent.com/MicrosoftLearning/dp-203-azure-data-engineer/master/Allfiles/labs/04/data/customer.csv and save it in a folder on your local computer (it doesn't matter where). Then in the Customer folder in Synapse Explorer, use the ⤒ Upload button to upload the customer.csv file to the RetailDB/Customer folder in your data lake.

In the Data pane on the left, on the Workspace tab, in the ... menu for the Customer table, select New SQL script > Select TOP 100 rows. Then, in the new SQL script 1 pane that has opened, ensure that the Built-in SQL pool is connected, and use the ▷ Run button to run the SQL code. The results should include first 100 rows from the Customer table, based on the data stored in the underlying folder in the data lake.

@TheJamesHerring - Can you investigate and try to repro?

Taking a look now, will post findings.

Issue resolved - please let me know if you have any other issues.

Hi, thanks!
I can't get any data, even changing the authentication method.
I tried with Pyspark and got the same results.
%%pyspark
df = spark.sql("SELECT * FROM RetailDB.Customer")
df.show(10)
+-----------+----------+----------+--------------+------+
|CustomerId|FirstName|LastName|EmailAddress|Phone|
+-----------+----------+----------+--------------+------+
+-----------+----------+----------+--------------+------+

Meet the same issue.
"External table 'RetailDB.dbo.Customer' is not accessible because content of directory cannot be listed."


[Medium]: Chrome+Jaws : Missing list markup for controls.

Action Performed:

Using Chrome+JAWS, open URL: staging.new.expensify.com
Navigate to Settings > Create new Workspace > Search for the created workspace > Details.
Navigate to "Members", "Settings", "Invite" and "Leave room" controls using the screen reader.
Observe the screen reader announce list markup.

Expected Result:
When list mark-up is provided for the mentioned content, screen reader users will identify a number of list items.
Actual Result:
The list mark-up is not used to present related information on the screen. For instance, the related information such as "Members", "Settings", "Invite" and "Leave room" controls are not marked as list items that visually look like a list. As a result, screen reader users might find it difficult to navigate to the lists and different list items quickly.
Workaround:
Yes
Area issue was found in:
Details
Failed WCAG checkpoints
1.3.1
User impact:
When lists do not use list markup, screen reader users will lose the semantic information the structure of the list provides visual users.
Suggested resolution:
Use appropriate list mark-up, such as 'li' and 'ul' to identify related information. In addition, if required apply styles to maintain the visual presentation of the web page.
Platform:

Web
Desktop App
Mobile Web

Version Number: 1.1.49-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Reference link: https://www.w3.org/WAI/tutorials/page-structure/content/
Issue reported by: Sumit

Same issues will reproduce in PR #8065.


Restricted resources can be retrieved even with unauthenticated requests

I'm able to surpass a restricted operation, by including the restricted resource if the restricted resource is referenced by another resource.
For example, in the dummy app:
With a custom User Processor, which restricts the get operation:
@Authorize(IfUserDoesNotHaveRole("foo"))   public async get(op: Operation) {     return super.get(op);   }
I'm able to get a user like this:

@spersico It's correct for you to get the resource, since the user does not have the "foo" role. However, the bug is confirmed, since changing the settings for @Authorize reproduced it.

The problem is the way we include resources right now does not make use of the get method for their bound processors, so the @Authorize decorator never gets to do its job.


add left/right icon on the card when swipe & add append method to add more cards

add left/right icon on the card when swipe & add append method to add more cards

LGTM👍


[FLINK-13558][examples][table] Added table examples to dist

What is the purpose of the change
Include test examples in the shipped distribution.
Brief change log

Stripped the produced artifacts to minimum
Included table examples in flink-dist

Verifying this change
Run examples from build-target/examples
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Could you have a look @twalthr ?


Return errdef.ErrUnsupported on Push() if remote repository does not support push

According to Docker Registry HTTP API V2, manifest push or blob push may fail with 405 Method Not Allowed error because the registry is configured as a pull-through cache or for some other reason.
Related #317

@yuehaoliang-microsoft Could you also help resolving this issue?


high dimensional features rasterization

Hi! Thanks for your great contribution! I'm currently trying to splat high-dimensional features (like 512) following  your https://github.com/Chrixtar/latent-gaussian-rasterization, however the PCA visual result is far from desirable.Could you plz provide more details concerning your high-dimensional splatting? Does it support dimension like 512 or more? Thanks in advance.
Desirable:

Result:

Hi Zhirui86,
thank you very much for your interest in our work.
I have not tried that large feature dimensionalities, but the latent gaussian rasterizer should work, as long as it fits into memory.
From the given information it is hard to tell the problem.
How exactly were these two renderings obtained?
I could help you the most, if you could provide code/data (references) such that I would be able to reproduce your results.
If that is not possible, then we can also try a detailed description of your approach :)
Best
Chris

@Chrixtar Thanks for your attention, Chris! Let me explain my approach in a more detailed way:

In order to render high-dimensional features, I firstly modified #define NUM_FEATURE_CHANNELS 4 // 64 into #define NUM_FEATURE_CHANNELS 512  in latent-gaussian-rasterization/cuda_rasterizer/config.h and ran pip install latent-gaussian-rasterization to rebuild and reinstall.
To test the effectiveness of rendered high-dimensional features, I followed steps shown as follows:
Use pre-trained ViT-L to generate pixel-wise 512-dimension features from source views which contain semantic information and visualize one of them via PCA which has been displayed as desirable in my last comment.
Then I concatenated features of different views and unprojected them into gaussians like:

gaussians = Gaussians(rearrange(
                means,
                "b v r srf spp xyz -> b (v r srf spp) xyz",
            ),
            rearrange(
                covariances,
                "b v r srf spp i j -> b (v r srf spp) i j",
            ),
            rearrange(
                harmonics,
                "b v r srf spp c d_sh -> b (v r srf spp) c d_sh",
            ),
            rearrange(
                opacities,
                "b v r srf spp -> b (v r srf spp)",
            ),
            rearrange(
                lang_features,
                "b v r srf spp d -> b (v r srf spp) d",
            ),
        )

4.Finally, I rendered feature map following latent-gaussian-rasterization:
image, feature , _, _, radii = rasterizer(
            means3D=gaussian_means[i],
            means2D=mean_gradients,
            shs=shs[i] if use_sh else None,
            colors_precomp=None if use_sh else shs[i, :, 0, :],
            features=gaussian_lang_features[i],
            opacities=gaussian_opacities[i, ..., None],
            cov3D_precomp=gaussian_covariances[i, :, row, col],
        )

However, the visual result of rendered high dimensional features is far from which has been obtained by ViT-L directly. That is, the gap between desirable and result. It's reasonable that source features and rendered features share much the same information which confuses me with the actual result. It would be greatly appreciated if you could offer me some suggestions on unprojecting and rendering features or potential causes. Many Thanks!