Webreg: Implement Solution for Dynamic Mock Data

Goals:

JSON values returned are based on the parameters passed in
JSON values conform to the structure of the API

E.g. CoursePlan returns one JSON value for term SP19, and an different JSON value for term FA20

This issue is being closed due to platform migration and may be revisited at a later date.


Can't implement search and paginator in one table

Bug, feature request, or proposal:
What is the expected behavior?
What is the current behavior?
What are the steps to reproduce?
Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: https://goo.gl/DlHd6U
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?

Can you show us your code?

Heres an example showing http search, sort, and pagination
https://github.com/angular/material2/tree/master/src/material-examples/table-http
It should show up on the docs soon

the issue is now fixed


[WIP] KafkaChannel run e2e tests with auth

Fixes #

Proposed Changes

Release Note

Docs

What I do in this PR is:

Fix the secret creation (irrelevant to the point I would like to discuss)
Introduce a CHANNEL_AUTH_SCENARIO env var.
That env var has 4 different values and each value configures the KafkaChannel config in a special way.
I added the 4 values in GH action test matrix. So, we now have 4 runs for every other scenario in the matrix.
I am planning to create 3 additional Prow jobs for each of the e2e tests (integration-tests and reconciler-tests) that test TLS, SASL_SSL, SASL_PLAINTEXT.

Issues:

I didn't limit the additional runs to KafkaChannel only. So, currently all the other tests are run as well.
More jobs - more resources

As I wrote in a separate thread, auth is set globally until https://github.com/knative-sandbox/eventing-kafka/issues/1005 is done.
So, in order to test auth scenarios, we would need to make sure these tests are run at the end in a sequential order. Also required is to modify the configmap...
Until that issue is done, I think it is less problematic to have separate Prow jobs. I will go that route.
Now, back to issue 1 above... I think I can somehow hack the Go build tags to only run the KafkaChannel tests in the additional jobs. The question is, is it worth it...
Or, while we're at it, would we want to run the entire suites for broker, sink and source with auth? Currently only some smoke tests are done.

can we use a different directory for channel tests?

That actually makes sense. Instead of playing with the buildtags.
I created this PR: https://github.com/knative-sandbox/eventing-kafka-broker/pull/1813
Once that's merged, I can then create the additional Prow jobs and GH actions for auth options, but only for KafkaChannel.

/close
Closing in favor of https://github.com/knative-sandbox/eventing-kafka-broker/pull/1816


Remove the partner FAQ

Summary
Remove the partner FAQ.  replace it with showing the bank's contact information
Why
We don't have any partner FAQ that reasonably go across the banks -- especially now that the banks have the partners use different ways of requesting things.
On consultation with the banks (2024/03/06)  we have decided to remove the FAQ
Details
1/  Currently the 'Need help"  goes to partners/help, which is an empty FAQ.   Instead, partners/help should show the  bank's contact information  so.. something like:
For help,  please contact:
Name of bank's primary contact  at Bank Name
email of bank's primary contact
telephone of bank
Note:  we recently did something similar to replace the error form -- maybe that can be repurposed.
These pieces of information can be found on partner.organization
2/  Remove "Questions for Partners"  from Superuser FAQ (which is reached by signining as<EMAIL_ADDRESS>and clicking FAQ)
3/  Remove questions for partners from seed
4/  Remove for partners / for banks checkboxes from New FAQ Entry.   Default all to "For banks" instead.
Criteria for completion

[ ] functionality changed as described above
[ ] additional tests re showing the bank's info
[ ] removal of tests re partner FAQ
[ ] bank FAQ tests still work

Bonus round

strip out the bank/partner differentiation in the FAQ modelling, (and, of course, make sure the bank FAQ still works)

@cielf  Can you please assign this issue to me?

Sure!

You have it!

WIP


Remove the ability of receiving keys from the environment

It's fiddly and it comes with a bunch of undocumented assumption. Let's have a --keys argument and let the user deal with it.

Closed by 5ce3fc0


Create Kadane's Algorithm.cpp

Added Kadane's Algorithm

@bhaveshlohana Please merge it

@bhaveshlohana Please make this Hacktoberfest accepted. This pull request was not accepted in hacktoberfest platform.

check #1429, please


how can I pass parameters to go build when exec ko publish

In my Go project, I use go build -tags 'dev' to build dev version, and use go build -tags 'prod' to build production version. When I called ko publish ., it told me that failed to publish images: importpath "git.xxx.com/my-project" is not supported
I know that ko will call go build, but how can I pass -tags 'dev' to go build when exec ko publish?

We don't do a great job of passing through flags to the underlying go build invocation.
Somewhat related: https://github.com/google/ko/issues/54 and https://github.com/google/ko/issues/52
I dug around for a bit looking for the go build -tags parsing and ran across https://github.com/golang/go/commit/80e7832733fd245181af3394077f2df21303a4aa, which taught me two things:

This tags flag is changing from space-separated to comma-separated in 1.13.
GOFLAGS exists, which should let you work around this (for now).

Now, this isn't that great:
$ GOFLAGS="-tags=dev" ko publish .

Ideally you could just do this:
$ ko publish -tags=dev .

But that is going to be tough... we currently have another flag (--tags, -t) that allows you to specify how the image is tagged in your registry, so the way the above command is getting parsed right now is equivalent to:
$ ko publish -t "ags=dev" .

This fails because ags=dev isn't a valid image tag. If we want to support that, we'll need to change how we handle flag parsing a bit. It might be possible to maintain a go build FlagSet, and do a first pass over argv before handing off flag parsing to cobra, but I haven't looked into it much.
I'm a little worried that the intersection of our flags, go's flags, and kubectl's flags is going to be a maintenance nightmare, but I'm sure we can figure something out.

What about an all encompassing flag for build args?
ie. -build-args "-tag 'dev'"

The above being a catch-all while more common options could should promoted to first level flags.

That doesn't seem like a big improvement over GOFLAGS.

I definitely missed the second point :(
Yeah I agree - GOFLAGS accomplishes that
On Wed, Aug 14, 2019 at 12:57 PM jonjohnsonjr<EMAIL_ADDRESS>wrote:

That doesn't seem like a big improvement over GOFLAGS.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/ko/issues/69?email_source=notifications&email_token=AAAERASIIA35ZZ2QQHTPKTTQEQ2RPA5CNFSM4ILGX7V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4JN2MI#issuecomment-521329969,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAERAT2LESIOXB6L4S2GNDQEQ2RPANCNFSM4ILGX7VQ
.

I think GOFLAGS is sufficient for this for now, going to close this. Feel free to reopen if that doesn't work (or you have a better idea).

GOFLAGS isnt sufficient for : GOFLAGS="-ldflags=-Xmain.version=1.2.3"
I get flag provided but not defined: -Xmain.version

GOFLAGS isnt sufficient for : GOFLAGS="-ldflags=-Xmain.version=1.2.3"

Does this work?
GOFLAGS="-ldflags=-X=main.version=1.2.3

Yep, thanks heaps
/cmd/server/main.go
package main
import (
	"fmt"
)
var Version = "dev"
func main() {
	fmt.Println("version " + Version)
}

go build ./cmd/server; ./server

prints version dev
go build -ldflags="-X=main.Version=1.2.3" ./cmd/server; ./server

printsversion 1.2.3
x=`KO_DOCKER_REPO=ko.local GOFLAGS="-ldflags=-X=main.Version=1.2.3" ko publish ./cmd/server; docker run --rm -it $x

prints
version 1.2.3


Path down decision tree

Is there a way to get the path down the tree for a prediction from the decision tree? I can import the implementation, copy/paste the predict method and add nodes to a list, but that's not ideal.

@elioBen Hi!
Thank you for creating the issue.
There is no such a path right now, but it can be useful, I will consider adding this feature to the DecisionTreeClassifier.


Can we customize the flow and create an add button ("add shareholder")

Hi,
First of all thank you for this bundle, it's really great. I started using it, yet I'm stuck : i need an "add" button with a new sub-form opening up and again and again, each time the user clicks on "add shareholder" (s/h #1, #2...). Can i use CraueFormFlowBundle for that and customize it ?
Thank you in advance for any help that would come

You could add an empty step, render a custom (not flow-based) form within it, and redirect to the same step after processing the form. The bundle itself doesn't offer such feature, which would be covered by #67.


replace (?) triangle_area2d with polygon_area

function polygon_area(vertices) =
     0.5*sum([for(i=[0:len(vertices)-1]) det2(select(vertices,i,i+1))]);

Note if polygon self intersects then some areas have positive area, some have negative, and they are summed.
This function is slower than triangle_area2d, so maybe it's worth keeping both?  (This takes about twice as long.)  I'm not sure how much of a difference it makes in the run time of hull() for example.  It took 9s to do 100k computations with polygon_area and 4s with triangle_area2d.   I don't know how many times hull() calls triangle_area2d().
I do think that triangle_area2d should be renamed triangle_area if it is retained, unless you plan to add triangle_area3d.
function triangle_area3d(x1,x2,x3) = 0.5*norm(cross(x3-x1,x3-x2));

I would prefer to have one triangle_area function that checks the dimension.  The 3d version is not signed.

Since triangle_are2d() doesn't work for 3D triangles, it seemed a good idea to keep the 2d to emphasize that.  Adding a triangle_area3d() seems like a good idea, even if it cannot be used for clockwise checks. I'd like to keep triangle_area2d() for speed reasons when we know we are dealing with a simple triangle, and add a polygon_area() for the general case.

You could consider merging the two triangle commands into a single triangle_area that checks the point dimension and does the 2d or 3d computation as appropriate.  This doesn't incur a speed penalty.
In the 3d case we are computing a normal to the triangle, but there's no point of reference with which to define clockwise.

Implemented in 9f0d55f5b38685bdcaf4e292c34ca6ff9bc02bc6


Feature/stash indicator

I couldn't find an option to reopen the pull request #66, did you disable this option somewhere?

I don't think I've disabled anything but I'll have a look.
:+1: Merging.


python311Packages.globus-sdk: 3.39.0 -> 3.41.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.globus-sdk is: Interface to Globus REST APIs, including the Transfer API and the Globus Auth API
meta.homepage for python311Packages.globus-sdk is: https://github.com/globus/globus-sdk-python
meta.changelog for python311Packages.globus-sdk is: https://github.com/globus/globus-sdk-python/releases/tag/3.41.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.41.0 with grep in /nix/store/9c98bq3q1gsl87blhpiyfr5l4zldsbap-python3.11-globus-sdk-3.41.0
found 3.41.0 in filename of file in /nix/store/9c98bq3q1gsl87blhpiyfr5l4zldsbap-python3.11-globus-sdk-3.41.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.globus-sdk
python312Packages.globus-sdk

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/9c98bq3q1gsl87blhpiyfr5l4zldsbap-python3.11-globus-sdk-3.41.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.globus-sdk https://github.com/r-ryantm/nixpkgs/archive/1f7e33d7095202c917860c26db664f97016f3b63.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1f7e33d7095202c917860c26db664f97016f3b63#python311Packages.globus-sdk

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/9c98bq3q1gsl87blhpiyfr5l4zldsbap-python3.11-globus-sdk-3.41.0
ls -la /nix/store/9c98bq3q1gsl87blhpiyfr5l4zldsbap-python3.11-globus-sdk-3.41.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

4 packages built:

python311Packages.globus-sdk
python311Packages.globus-sdk.dist
python312Packages.globus-sdk
python312Packages.globus-sdk.dist

Maintainer pings

Result of nixpkgs-review pr 311287 run on x86_64-linux 1

4 packages built:

python311Packages.globus-sdk
python311Packages.globus-sdk.dist
python312Packages.globus-sdk
python312Packages.globus-sdk.dist


intermittend 3D rendering issues

I continue to run into a bug when switching into the 3D mode of napari viewer.
It's not yet fully reproducible; I will continue testing but might need help as to what I should test.
Workflow:
I used iPython and the following code to load the data
In [1]: %gui qt5
In [2]: import numpy as np
In [3]: import matplotlib.pyplot as plt
In [4]: from dask_image.imread import imread
In [5]: import napari
In [6]: stack = imread("path/to/data")
In [7]: viewer = napari.view_image(stack, contrast_limits=[0,5000],scale=[5,1,1], is_pyramid=False, colormap='magma')

The bug seems to occur mostly when I go to the center of the stack and then enter 3D view relatively quickly after opening napari.
I read through #576 but this one seems to be different.
vispy version 0.6.4
napari version 0.2.6
Here's the error message:
WARNING: Error drawing visual <Volume at 0x126ff5a2608>
Traceback (most recent call last):
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\OpenGL\latebind.py", line 41, in __call__
    return self._finalCall( *args, **named )
TypeError: 'NoneType' object is not callable

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\app\backends\_qt.py", line 825, in paintGL
    self._vispy_canvas.events.draw(region=None)
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\util\event.py", line 455, in __call__
    self._invoke_callback(cb, event)
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\util\event.py", line 475, in _invoke_callback
    self, cb_event=(cb, event))
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\util\event.py", line 471, in _invoke_callback
    cb(event)
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\scene\canvas.py", line 217, in on_draw
    self._draw_scene()
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\scene\canvas.py", line 266, in _draw_scene
    self.draw_visual(self.scene)
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\scene\canvas.py", line 304, in draw_visual
    node.draw()
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\scene\visuals.py", line 99, in draw
    self._visual_superclass.draw(self)
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\visuals\visual.py", line 443, in draw
    self._vshare.index_buffer)
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\visuals\shaders\program.py", line 101, in draw
    Program.draw(self, *args, **kwargs)
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\program.py", line 533, in draw
    canvas.context.flush_commands()
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\context.py", line 176, in flush_commands
    self.glir.flush(self.shared.parser)
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\glir.py", line 572, in flush
    self._shared.flush(parser)
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\glir.py", line 494, in flush
    parser.parse(self._filter(self.clear(), parser))
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\glir.py", line 819, in parse
    self._parse(command)
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\glir.py", line 787, in _parse
    ob.set_data(*args)
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\glir.py", line 1639, in set_data
    glTexSubImage3D(self._target, 0, x, y, z, format, gtype, data)
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\glir.py", line 1607, in glTexSubImage3D
    width, height, depth, format, type, pixels)
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\OpenGL\latebind.py", line 45, in __call__
    return self._finalCall( *args, **named )
  File "Z:\Python\envs\wjahr\playground\lib\site-packages\OpenGL\wrapper.py", line 882, in wrapperCall
    result = wrappedOperation( *cArguments )
OSError: exception: access violation reading 0x00000126D1C70000

If you suspect this is an IPython bug, please report it at:
    https://github.com/ipython/ipython/issues
or send an email to the mailing list at<EMAIL_ADDRESS>
You can print a more detailed traceback right now with "%tb", or use "%debug"
to interactively debug it.

And here the detailed traceback:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Z:\Python\envs\wjahr\playground\lib\site-packages\OpenGL\latebind.py in __call__(self, *args, **named)
     40             try:
---> 41                 return self._finalCall( *args, **named )
     42             except (TypeError,AttributeError) as err:

TypeError: 'NoneType' object is not callable

During handling of the above exception, another exception occurred:

OSError                                   Traceback (most recent call last)
Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\util\event.py in __call__(self, *args, **kwargs)
    453                     continue
    454
--> 455                 self._invoke_callback(cb, event)
    456                 if event.blocked:
    457                     break

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\util\event.py in _invoke_callback(self, cb, event)
    473             _handle_exception(self.ignore_callback_errors,
    474                               self.print_callback_errors,
--> 475                               self, cb_event=(cb, event))
    476
    477     def _prepare_event(self, *args, **kwargs):

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\util\event.py in _invoke_callback(self, cb, event)
    469     def _invoke_callback(self, cb, event):
    470         try:
--> 471             cb(event)
    472         except Exception:
    473             _handle_exception(self.ignore_callback_errors,

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\scene\canvas.py in on_draw(self, event)
    215         # scheduling of further updates
    216         self._update_pending = False
--> 217         self._draw_scene()
    218
    219     def render(self, region=None, size=None, bgcolor=None, crop=None):

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\scene\canvas.py in _draw_scene(self, bgcolor)
    264             bgcolor = self._bgcolor
    265         self.context.clear(color=bgcolor, depth=True)
--> 266         self.draw_visual(self.scene)
    267
    268     def draw_visual(self, visual, event=None):

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\scene\canvas.py in draw_visual(self, visual, event)
    302                         else:
    303                             if hasattr(node, 'draw'):
--> 304                                 node.draw()
    305                                 prof.mark(str(node))
    306                 else:

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\scene\visuals.py in draw(self)
     97         if self.picking and not self.interactive:
     98             return
---> 99         self._visual_superclass.draw(self)
    100
    101

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\visuals\visual.py in draw(self)
    441         try:
    442             self._program.draw(self._vshare.draw_mode,
--> 443                                self._vshare.index_buffer)
    444         except Exception:
    445             logger.warning("Error drawing visual %r" % self)

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\visuals\shaders\program.py in draw(self, *args, **kwargs)
     99         self.build_if_needed()
    100         self.update_variables()
--> 101         Program.draw(self, *args, **kwargs)
    102
    103     def build_if_needed(self):

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\program.py in draw(self, mode, indices, check_error)
    531
    532         # Process GLIR commands
--> 533         canvas.context.flush_commands()

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\context.py in flush_commands(self, event)
    174                 fbo = 0
    175             self.shared.parser.parse([('CURRENT', 0, fbo)])
--> 176         self.glir.flush(self.shared.parser)
    177
    178     def set_viewport(self, *args):

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\glir.py in flush(self, parser)
    570         """ Flush all current commands to the GLIR interpreter.
    571         """
--> 572         self._shared.flush(parser)
    573
    574

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\glir.py in flush(self, parser)
    492             show = self._verbose if isinstance(self._verbose, str) else None
    493             self.show(show)
--> 494         parser.parse(self._filter(self.clear(), parser))
    495
    496     def _filter(self, commands, parser):

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\glir.py in parse(self, commands)
    817
    818         for command in commands:
--> 819             self._parse(command)
    820
    821     def get_object(self, id_):

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\glir.py in _parse(self, command)
    785                 ob.set_attribute(*args)
    786             elif cmd == 'DATA':  # VertexBuffer, IndexBuffer, Texture, Shader
--> 787                 ob.set_data(*args)
    788             elif cmd == 'SIZE':  # VertexBuffer, IndexBuffer,
    789                 ob.set_size(*args)  # Texture[1D, 2D, 3D], RenderBuffer

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\glir.py in set_data(self, offset, data)
   1637             gl.glPixelStorei(gl.GL_UNPACK_ALIGNMENT, alignment)
   1638         # Upload
-> 1639         glTexSubImage3D(self._target, 0, x, y, z, format, gtype, data)
   1640         # Set alignment back
   1641         if alignment != 4:

Z:\Python\envs\wjahr\playground\lib\site-packages\vispy\gloo\glir.py in glTexSubImage3D(target, level, xoffset, yoffset, zoffset, format, type, pixels)
   1605     depth, height, width = pixels.shape[:3]
   1606     _gl.glTexSubImage3D(target, level, xoffset, yoffset, zoffset,
-> 1607                         width, height, depth, format, type, pixels)
   1608
   1609

Z:\Python\envs\wjahr\playground\lib\site-packages\OpenGL\latebind.py in __call__(self, *args, **named)
     43                 if self._finalCall is None:
     44                     self._finalCall = self.finalise()
---> 45                 return self._finalCall( *args, **named )
     46 if Curry is None:
     47     class Curry(object):

Z:\Python\envs\wjahr\playground\lib\site-packages\OpenGL\wrapper.py in wrapperCall(*args)
    880                                 cArguments = pyArgs
    881                                 try:
--> 882                                     result = wrappedOperation( *cArguments )
    883                                 except ctypes.ArgumentError as err:
    884                                     err.args = err.args + (cArguments,)

OSError: exception: access violation reading 0x00000126D1C70000

dataset can be found here:
https://seafile.ist.ac.at/f/e173a2b7c65f4127bd10/

Hi @wiebkejahr sorry you're having this problem. You might want to upgrade to 0.2.7, we just released it yesterday, and there's no immediate reason for me to think that will fix anything here, but you might as well be working off the latest.
Can you tell me the shape and dtype of your data. I also noticed you're using dask_image to do the reading, which is fine, but I'm curious if that means your dataset is very large and you want lazy loading, or if there was another reason you went with dask_image there.
The ideal case would be that we could reproduce this error with data that is of the form np.random.random(shape) or similar using the dask random array

Thanks, totally missed the update, I love the volume rendering functionality already :)
I'll continue testing.
shape: 140x2048x2048
uint16
Why dask_image? At the moment, my data is small enough to load as is (order of 1 GB, but only 1 timepoint). I'm in the process of developing the whole workflow (including different hardware structure available), so trying to stay future proof, and that's why I'm also testing with dask_image.

Hmm, 2048 may be the max texture size per axis that your graphics card can handle and this PR #788 introduced code to fix prevent larger textures from being sent over to the graphics card. The limit in the PR is  > 2048 so the code to do the downsampling won't get triggered in this case.
My two questions are, can you reproduce the problem with np.random.randint((140, 2048, 2048).astype(np.uint8) (or similar) and then what happens if you try np.random.randint((140, 2040, 2040).astype(np.uint8), where you just back away slightly from that 2048 number

Hi, not sure if this belongs here. When I switch to 3D view and start rotating the mesh in the center I get the error below 100% of the time (but only if I've switched to a different slide before or switched to a different one and then switched back to first one).
I'm on windows 8.1 64 bit with NVIDIA geforce gtx 960. Updated my GPU driver today (in an attempt to stop getting the crash) so that's not the issue. When I run the same code on my old lenovo x230 tablet running ubuntu 18.04 64 bit it all works fine.
Would be cool to see this fixed. Learned about napari today and would be exactly what I need ... if it ran :/
Code:
import numpy as np
from skimage import data, filters

if __name__ == '__main__':
    blobs_raw = np.stack([
        data.binary_blobs(length=256, n_dim=3, volume_fraction=f)
        for f in np.linspace(0.05, 0.5, 10)
    ])
    blobs = filters.gaussian(blobs_raw, sigma=(0, 2, 2, 2))
    with napari.gui_qt():
        # create a Viewer and add an image here
        viewer = napari.view_image(blobs)

Error:

WARNING: Error drawing visual <vispy.visuals.mesh.MeshVisual object at 0x000000DA3C0331C8>
WARNING: Traceback (most recent call last):
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\app\backends_qt.py", line 447, in mousePressEvent
modifiers=self._modifiers(ev),
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\app\base.py", line 181, in _vispy_mouse_press
ev = self._vispy_canvas.events.mouse_press(**kwargs)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\util\event.py", line 455, in call
self._invoke_callback(cb, event)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\util\event.py", line 475, in _invoke_callback
self, cb_event=(cb, event))
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\util\event.py", line 471, in _invoke_callback
cb(event)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\scene\canvas.py", line 344, in process_mouse_event
picked = self.visual_at(event.pos)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\scene\canvas.py", line 397, in visual_at
id = self._render_picking((fbpos[0], fbpos[1], 1, 1))
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\scene\canvas.py", line 483, in _render_picking
img = self.render(bgcolor=(0, 0, 0, 0), crop=crop)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\scene\canvas.py", line 257, in render
self._draw_scene(bgcolor=bgcolor)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\scene\canvas.py", line 266, in _draw_scene
self.draw_visual(self.scene)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\scene\canvas.py", line 304, in draw_visual
node.draw()
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\scene\visuals.py", line 99, in draw
self._visual_superclass.draw(self)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\visuals\visual.py", line 595, in draw
v.draw()
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\visuals\mesh.py", line 519, in draw
Visual.draw(self, *args, **kwds)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\visuals\visual.py", line 443, in draw
self._vshare.index_buffer)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\visuals\shaders\program.py", line 101, in draw
Program.draw(self, *args, **kwargs)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\gloo\program.py", line 533, in draw
canvas.context.flush_commands()
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\gloo\context.py", line 176, in flush_commands
self.glir.flush(self.shared.parser)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\gloo\glir.py", line 572, in flush
self._shared.flush(parser)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\gloo\glir.py", line 494, in flush
parser.parse(self._filter(self.clear(), parser))
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\gloo\glir.py", line 819, in parse
self._parse(command)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\gloo\glir.py", line 779, in _parse
ob.draw(*args)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\gloo\glir.py", line 1339, in draw
gl.glDrawArrays(mode, first, count)
File "C:\Users\lennart\Anaconda3\envs\malaria_seqmentation\lib\site-packages\vispy\gloo\gl_gl2.py", line 415, in glDrawArrays
nativefunc(mode, first, count)
OSError: exception: access violation reading 0x0000000000000000

Code is from https://ilovesymposia.com/2019/10/24/introducing-napari-a-fast-n-dimensional-image-viewer-in-python/ so I'm pretty sure it's supposed to work

Yeah, unfortunately it works for me on my mac too (I just tried it again) - we've had some issues with windows - but we can try chasing this down. Sorry about that!!
There are some other threads on the napari repo which talk about windows issues more explicitly and you might find something in one of those in the meantime. Maybe @tlambert03 knows which ones I have in mind or we can ping some more of our windows users. It comes up so frequently now we should really have a "known windows issues section". Need to work on that ...

@lennart-g and @wiebkejahr we made some good progress with our windows specific 3D volume crashes - see a similar issue in #1347 a fix by #1445.
Can both of you try upgrading to napari 0.3.6 and see if the issue still persists? We do still have a couple of lingering ones like #1224 so would be good to know where this one lands. I hope it is now solved!!

Given progress on our 3D rendering described above and the lack of activity on this issue I am going to close. If people encounter new 3D rendering issues feel free to reopen or create a new issue


Code review contributions in Github

This is a basic question, but... what counts as "code review" in the contribution graph in Github? Is it making comments on code or committing to code? I don't really understand the concept.

Hi @Gahamelas,
It seems you confuse this repo (GitHub API client written in JavaScript) with the GitHub support but I try to answer your question.
Code review is when you go to a PR (pull request), go to the "Files changed" tab of it and provide feedback (approve, comment, request changes).

As this has nothing to do with this client library I'm closing this issue.

Thanks so much. At the cost of abusing your help...  Even if you don't comment, just approve a PR, will that be counting as code review?

Yes, approving a PR counts as code review.

Thank you!


Nesting dropzone in existing form?

I have a form for posting blog entries. I want to be able to submit multiple fields at once. Instead of designating the class of the form as 'dropzone' is it possible to be able to have a dropzone div nested in my current form so one button will submit all my fields, including multiple image upload, at once?
Something like this stackoverflow question, but with flask-dropzone. Thanx in advance for any assistance!
My form:
<!DOCTYPE HTML>
<form action="{{ url_for('add_post') }}" method="post" class="add-post" enctype="multipart/form-data">

Post title:

<input type="text" size="30" name="title" spellcheck="true" required>

Post date:

<input type="date" name="post_date" required>

Post description(one sentence):

<textarea name="description" rows="3" cols="40" spellcheck="true" required></textarea>

Post html file:

<input type="file" name="html_file" required>

Post image(s) file:

         {{ dropzone.create(action=url_for('show_posts')) }}

<input type="submit" value="Submit">

</form>

It seems that there isn't a perfect way to handle this problem. As far as I know, the following thing is easy:

Insert dorpzone div inside a form
Use submit button to upload all dropped files
But the problem is, Dropzone.js use AJAX to send files, so we can't merge the files with the normal POST request that created when you click the submit button. The most of the methods in the SO question you posted is append the form data into the AJAX request that created by Dropzone.js, but then it will be hard to get the error messages from server-side when validation fails.

An alternative method is to send uploads and other form data to different view functions, for example:

Upload files --> /upload
Other fields --> /new

However, I can't make the form submit after file upload complete:
    document.getElementById("submit").addEventListener("click", function(e) {
         // Make sure that the form isn't actually being sent.
        e.preventDefault();
        e.stopPropagation();
        myDropzone.processQueue();  // upload files first
        document.getElementById("submit").click();  // submit other fields --> not work
    });

Any idea?

I finally make the alternative method worked, you can try the demo application in here.

Trying the demo. Get errors
BuildError: Could not build url for endpoint ''. Did you mean 'handle_upload' instead?
It seems the url_for command is not getting the config setting for DROPZONE_UPLOAD_ACTION

@gyrcom Thanks for the feedback! It should be work with the code on master branch, you can install it on local with:
$ git clone https://github.com/greyli/flask-dropzone.git
$ cd flask-dropzone
$ pip install -e .

then run the demo with:
$ python examples/in-form/app.py

Thank You

i tried the code and received this output
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/flask/app.py", line 1997, in call
return self.wsgi_app(environ, start_response)
File "/usr/local/lib/python3.5/dist-packages/flask/app.py", line 1985, in wsgi_app
response = self.handle_exception(e)
File "/usr/local/lib/python3.5/dist-packages/flask/app.py", line 1540, in handle_exception
reraise(exc_type, exc_value, tb)
File "/usr/local/lib/python3.5/dist-packages/flask/_compat.py", line 33, in reraise
raise value
File "/usr/local/lib/python3.5/dist-packages/flask/app.py", line 1982, in wsgi_app
response = self.full_dispatch_request()
File "/usr/local/lib/python3.5/dist-packages/flask/app.py", line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/local/lib/python3.5/dist-packages/flask/app.py", line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/usr/local/lib/python3.5/dist-packages/flask/_compat.py", line 33, in reraise
raise value
File "/usr/local/lib/python3.5/dist-packages/flask/app.py", line 1612, in full_dispatch_request
rv = self.dispatch_request()
File "/usr/local/lib/python3.5/dist-packages/flask/app.py", line 1598, in dispatch_request
return self.view_functionsrule.endpoint
File "/home/deeplearning/gabriel/front/front/test/flask-dropzone/examples/in-form/app.py", line 33, in handle_upload
for key, f in request.files.iteritems():
AttributeError: 'ImmutableMultiDict' object has no attribute 'iteritems'
wasnt able to upload files

@gabrielggg Yes, you are right, I forgot to add a comment to address this.

Both python 2 and 3 have a dict.items.  There's really no memory or performance benefit to not just using items in both python 2 and 3.

Hmm, sticky.  Assuming we need the files and form data in one function in order to create a database record or something, I can think of three options:

Don't use AJAX for the dropzone component when it is part of a larger form, and lose the nice dropzone validation feedback.  Instead embed the file upload validation feedback in the template like the rest of the form elements.

Merge the form data into the AJAX, and allow the user to specify a callback function which get the response (after dropzone has used it) and can update the form elements.

Do two requests as you are currently doing and include a common uuid in both requests.  The file handling function can use the key to put the files somewhere where the form data handling function can retrieve them.

#1 clears the dropzone ui so server side per file validation messages can't be shown the way dropzone usually does. (is this a big deal?) .  #2 could be fine but would compel users to figure out how to display field and form validation messages through javascript rather than through the templates like WTForms.  This might even merit a library of it's own, since adding other filed types is probably out of scope for flask-dropzone.  #3 is trivial after the work that has already been done.  It is limited in that form validation cannot influence file validation but I can't really think of a solid example of this being an issue (clearing the dropzone files in the UI on form level validation failure seems fine in all situations I can think of).

Both python 2 and 3 have a dict.items. There's really no memory or performance benefit to not just using items in both python 2 and 3.

Technically, use dict.iteritems() did can improve performance since it did not create a new list. However, use dict.items() in an example application is enough and it will be more friendly for users use different Python version. I will update the example application and README later this day (You can also make a PR if you want).
As for nesting form issue, thanks for your thoughful analysis. I actually trid to implement #1 and #2, but both are diffcult to implement or hard to use. #3 looks good, I'm happy to review the PR if you can implement it.

items() issue fixed in https://github.com/greyli/flask-dropzone/commit/f30a61d1913a92abeec0485f4012072d5ee35569.

I've created a pull request addressing #3 and partially #2.  #3 really just needed the example updated, using the csrf token, though if you are fine with using a real CSRF token in that example then I'd add hashing the token rather than using the token to make the path directly.  Completing #2 would require an example of updating the init function with a callback.  I might do that if we end up needing that functionality for our project.
ps. not sure how link the the PR.  haven't done this on github before
pps. iteritems doesn't make a list but it does make a generator object, so it's still constructing a new python object.  It's not free.  items builds the list in C code which is really fast.  Especially for dictionaries with only dozens of elements, it's not clear to me which would be faster, and both would be so fast that doing anything with each element would dwarf the time it takes to make the list or generator.  And network io would be orders of magnitude more.  So, I disagree that iteritems improves performance here.

#2 is not a good idea since user will need a normal POST request to handle form validation then render the page with error messages.
You can just type # with the number to link an issue or PR.
I agree, it is almost no different for small dict.

My take was similiar to @Permafacture
I was considering generating a random UUID.
The images would upload instantly to a '/temp/string:UUID' folder using handle_images_uploads().
The form would submit with UUID to handle_form() and check if there were any images added to the folder.
If my understanding's correct though - I don't seem to be able to send the CSRF token twice. So it adds vulnerability to the app.

I'm also not sure if anyone's seen this
link

@harry-wright The current implementation was just inspired by the link you posted.

Well I've spent some more time on this. The problem stems from not being able to use the csrf token more than once. My work around has been to start a javascript popup window to implement the dropzone, and when finished, use queuecomplete to then close the popup. I do not think there is any easy answer to integrating dropzone, forms, and csrf.

Hello Greyli I too spent a lot of time researching this
I have not researched it but the answer seemed to lie in a multi-part form.
I.e. can we use FormData.append() in Flask-wtf? It may be possible to
submit it with the multi-part form (containings strings and images) and
submit it all using ONE csrf token.
Sorry I can't be of more help.
Kind regards
On Mon, 10 Jun 2019 at 01:39, gyrcom<EMAIL_ADDRESS>wrote:

Well I've spent some more time on this. The problem stems from not being
able to use the csrf token more than once. My work around has been to start
a javascript popup window to implement the dropzone, and when finished, use
queuecomplete to then close the popup. I do not think there is any easy
answer to integrating dropzone, forms, and csrf.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/greyli/flask-dropzone/issues/14?email_source=notifications&email_token=AEH6CQZN432XJOQ4DQ535FLPZWPEPA5CNFSM4FHCIXO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXIVQIQ#issuecomment-500258850,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEH6CQ3IDMNCAIASZB5IOH3PZWPEPANCNFSM4FHCIXOQ
.

@harry-wright Thanks for the tip, I'll have a look at this when I have free time.

Hi @greyli I've been looking for the answer for this issue but i can not find any thing that would be of any help.
Besides that, your commit from 7 day ago does seem to provide an alternative solution
However it would be great conveniences if this issue get resolves...
Thanks.


Set version 4.3.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 88.119%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
5711

Relevant Lines:
6481

💛  - Coveralls


fix to support fetching objects that are published via BCO id and opt…

closes 37
Allows the BCO API to properly be able to report published BCOs by object id and optionally version without a token.

Tested directly w/ the BCO API; looks to be working.


added Polyline#setVertices(float[])

no idea why this method was missing, someone probably just forgot it

Sad trombone. This broke the build.


Bug: Editor not always loading!

This has happened to me twice recently, although I'm switching branches a lot and it could be that something isn't built correctly in the process.
I've seen it on both a new editor and opening an existing post:

I believe that the xregexp dependency was dropped in favour of our own regular expression, and this is probably related to that.

Interesting, definitely seems to be related to the regexp that we pulled out of XRegExp, although quite why it only fails occasionally. I've not seen it yet but will keep an eye out for it.

Yeah I need to keep an eye on when it is happening - E.g. if I've properly built all the things. I just wanted to get it raised to flag it up for now.

Going to close this in favour of the user reports in #6914


NfcManager.start return result 'undefined' always

Hello,
I installed the latest version you just published and I get result 'undefined' in any case I checked.
with undefined, I can't really check if the phone support in nfc or not, I don't have any indication to know..

Hi, thanks for trying this library!
The start call returns a promise, and the promise is rejected when the device doesn't support NFC. So in your case (promise resolved with undefined) means NFC is supported by your device.

thanks for quick response.
in iphone 4 it's returned me undefined and Iphone 4 not support nfc.
so maybe the Start function not works good?

Sounds like an issue, I will look into it and feedback later. Thanks for reporting!

same issue. phone without support to nfc show me undefined and undefined as u explained above is resolve. not the good logic for me.


sqlite_schema_entry.hpp:23:36: error: ‘duckdb::optional_ptrduckdb::CatalogEntry duckdb::SQLiteSchemaEntry::CreateIndex(duckdb::ClientContext&, duckdb::CreateIndexInfo&, duckdb::TableCatalogEntry&)’ marked ‘override’, but does not override

What happens?
[ 72%] Built target sqlite_lib
[ 72%] Building CXX object extension/sqlite_scanner/src/storage/CMakeFiles/sqlite_ext_storage.dir/sqlite_catalog.cpp.o
In file included from /…/src/storage/sqlite_catalog.cpp:5:
/…/src/include/storage/sqlite_schema_entry.hpp:23:36: error: ‘duckdb::optional_ptr<duckdb::CatalogEntry> duckdb::SQLiteSchemaEntry::CreateIndex(duckdb::ClientContext&, duckdb::CreateIndexInfo&, duckdb::TableCatalogEntry&)’ marked ‘override’, but does not override
   23 |         optional_ptr<CatalogEntry> CreateIndex(ClientContext &context, CreateIndexInfo &info,
      |                                    ^~~~~~~~~~~
/…/src/include/storage/sqlite_schema_entry.hpp:35:14: error: ‘void duckdb::SQLiteSchemaEntry::Alter(duckdb::ClientContext&, duckdb::AlterInfo&)’ marked ‘override’, but does not override
   35 |         void Alter(ClientContext &context, AlterInfo &info) override;
      |              ^~~~~
In file included from /…/duckdb/src/include/duckdb/common/common.hpp:12,
                 from /…/duckdb/src/include/duckdb/catalog/catalog_entry.hpp:11,
                 from /…/duckdb/src/include/duckdb/catalog/catalog.hpp:11,
                 from /…/src/include/storage/sqlite_catalog.hpp:11,
                 from /…/src/storage/sqlite_catalog.cpp:1:
/…/duckdb/src/include/duckdb/common/helper.hpp: In instantiation of ‘typename duckdb::TemplatedUniqueIf<DATA_TYPE, true>::templated_unique_single_t duckdb::make_uniq(ARGS&& ...) [with DATA_TYPE = SQLiteSchemaEntry; ARGS = {SQLiteCatalog&, CreateSchemaInfo&}; typename TemplatedUniqueIf<DATA_TYPE, true>::templated_unique_single_t = unique_ptr<SQLiteSchemaEntry>]’:
/…/src/storage/sqlite_catalog.cpp:23:44:   required from here
   23 |         main_schema = make_uniq<SQLiteSchemaEntry>(*this, info);
      |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
/…/duckdb/src/include/duckdb/common/helper.hpp:65:72: error: invalid new-expression of abstract class type ‘duckdb::SQLiteSchemaEntry’
   65 |     return unique_ptr<DATA_TYPE, std::default_delete<DATA_TYPE>, true>(new DATA_TYPE(std::forward<ARGS>(args)...));
      |                                                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/…/src/include/storage/sqlite_schema_entry.hpp:16:7: note:   because the following virtual functions are pure within ‘duckdb::SQLiteSchemaEntry’:
   16 | class SQLiteSchemaEntry : public SchemaCatalogEntry {
      |       ^~~~~~~~~~~~~~~~~
In file included from /…/duckdb/src/include/duckdb/main/client_context.hpp:11,
                 from /…/duckdb/src/include/duckdb/main/relation.hpp:19,
                 from /…/duckdb/src/include/duckdb/main/connection.hpp:19,
                 from /…/duckdb/src/include/duckdb.hpp:11,
                 from /…/src/include/sqlite_utils.hpp:11,
                 from /…/src/include/sqlite_db.hpp:11,
                 from /…/src/include/storage/sqlite_catalog.hpp:13:
/…/duckdb/src/include/duckdb/catalog/catalog_entry/schema_catalog_entry.hpp:61:44: note:     ‘virtual duckdb::optional_ptr<duckdb::CatalogEntry> duckdb::SchemaCatalogEntry::CreateIndex(duckdb::CatalogTransaction, duckdb::CreateIndexInfo&, duckdb::TableCatalogEntry&)’
   61 |         virtual optional_ptr<CatalogEntry> CreateIndex(CatalogTransaction transaction, CreateIndexInfo &info,
      |                                            ^~~~~~~~~~~
/…/duckdb/src/include/duckdb/catalog/catalog_entry/schema_catalog_entry.hpp:95:22: note:     ‘virtual void duckdb::SchemaCatalogEntry::Alter(duckdb::CatalogTransaction, duckdb::AlterInfo&)’
   95 |         virtual void Alter(CatalogTransaction transaction, AlterInfo &info) = 0;
      |                      ^~~~~
gmake[3]: *** [extension/sqlite_scanner/src/storage/CMakeFiles/sqlite_ext_storage.dir/build.make:76: extension/sqlite_scanner/src/storage/CMakeFiles/sqlite_ext_storage.dir/sqlite_catalog.cpp.o] Error 1
gmake[2]: *** [CMakeFiles/Makefile2:7955: extension/sqlite_scanner/src/storage/CMakeFiles/sqlite_ext_storage.dir/all] Error 2
gmake[1]: *** [Makefile:136: all] Error 2
gmake[1]: Leaving directory '/…/build/release'
make: *** [Makefile:73: release] Error 2

To Reproduce
Compile duckdb version 7ca1d378437718e86d9f2788e5b165bac532e63c with:
env BUILD_PYTHON=1 BUILD_ODBC=1 BUILD_HTTPFS=1 BUILD_AUTOCOMPLETE=1 BUILD_ICU=1 BUILD_FTS=1 BUILD_JSON=1 GEN=ninja make -j8

Clone sqlite_scanner version d355dd0b072653590e1d8c0d83501f4b20358694, symlink to the previous duckdb repository then compile with:
env BUILD_PYTHON=1 BUILD_ODBC=1 BUILD_HTTPFS=1 BUILD_AUTOCOMPLETE=1 BUILD_ICU=1 BUILD_FTS=1 BUILD_JSON=1 make

I'm using gcc-c++-14.1.1-1.fc40.x86_64
OS:
Linux x64 (Fedora 40)
SQLite Version:
3.45.1-2.fc40.x86_64
DuckDB Version:
7ca1d378437718e86d9f2788e5b165bac532e63c
DuckDB Client:
7ca1d378437718e86d9f2788e5b165bac532e63c
Full Name:

Affiliation:

Have you tried this on the latest main branch?

[X] I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

[X] I agree

It seems to be fixed in duckdb version 1419336e2bc6a71860fb05220927f339375ea8f8
and sqlite_scanner version 50b7870be099186f195bc72bac5e9e11247ee2f9

I'd say this is the same as https://github.com/duckdb/duckdb/issues/12212, basically not all pair DuckDB and sqlite are valid.
Two pairing that are guaranteed to work at a given moment in git history are:

a given duckdb + what's specified in .github/config/out_of_tree_extensions.cmake
a given sqlite_scanner + the duckdb specified as submodule.

Thanks for raising, documentation / wording can be improved


Wineprefix not created when clicking install dxvk

When using wine staging and selecting dxvk it doesnt install complaining about wrong ELF class
Logfile attached
gameimage.log

Hi @Blad3forc3 , thank you for reporting this issue! I'll investigate.


upgrade to svelte-kit 2

vite error for importing maplibre-gl which is commonJS
11:50:58 AM [vite] Error when evaluating SSR module /src/lib/components/Popup.ts: failed to import "maplibre-gl"
|- SyntaxError: [vite] Named export 'Popup' not found. The requested module 'maplibre-gl' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'maplibre-gl';
const {Popup} = pkg;


versioningStrategy 2 seems to not use 24h format

when running a build in the morning and in the after noon the second build fails because the version no is lower that the one in the morning:
this revision no should be 132032

Also, the format should always be HHMMSS. I think that in this example the leading zero is cut off

Update:
When you change the hh to capital, it should work
[Int32]([DateTime]::UtcNow.ToString('HHmmss'))
https://github.com/microsoft/AL-Go/blob/413bd8697728dffb9ebd13f61ecc5f54fdf3388c/Actions/ReadSettings/ReadSettings.ps1#L69
capital HH is for 24h format and lowercase for 12h format.
If I think about it, the leading zero is proably not needed, since the parts of the version are more like integer than text.

Will fix this to HHmmss as Stefan suggests.
The leading zero is not needed as the version numbers are sorted numerically and not alfabetically.
Will be in a preview release today or during the weekend.

This is fixed in preview

Shipped in v2.0


Move local_datetime, local_date, local_time to cal:: namespace

Looks like this is it. Tests for code snippets and doc links were very helpful!

@vpetrovykh please also take a quick look

Looks OK.

@tailhook Please bump EDGEDB_CATALOG_VERSION


Allow specifying that an Optional field should have a value when building the Factory

In all cases except a few, the feature to alternate between None and a value for Optional fields is very useful. However, in some cases I need there to always be a value. Now, one could import Faker and create a random value manually; however, something like the following would be super helpful:
MyModelFactory.build(x="some value", optional_y=Require())

In fact, I tried this on the offchance that it would work, but alas no!
If you have any thoughts on this feature, I could take a stab at implementing, but some guidance on how you would do it would be grand. Cheers!

Hiya @cazgp,
So you want granular control on which fields will get a value and which will not through build args?
It would be cool if you try to implement it and add a PR - simply because I want contributors and eventually more maintainers :)
Anyhow, if you look  at the factory you will see there is a method should_set_none. You could follow your idea with that I think.
I wouldn't reuse "Require" for this purpose - require is meant to significant that a field needs to receive a build arg.
You could instead create another class, like Require, but called "NonOptional" or something along these lines, and then use it like you suggested.
Another option would be to go for a somewhat less granular control - simply allow overriding the factory level setting of of none optionals or non-optional nones as a kwarg to build (and hence batch etc.)

@cazgp ?

please reopen if still relevant.


Use with_bindgen feature with p256k1

This PR depends on this PR against p256k1.  With this PR, wsts will continue to use bindgen to generate libsecp256k1 bindings for p256k1 by default.

Replaced by https://github.com/Trust-Machines/wsts/pull/31

The merge from upstream ended up causing this PR to have a large diff, so I took the Cargo.toml changes and made a new PR.


What is the role of P as an argument?

Its referring to the probability that the respective augmentation is executed.

The question was answered, so I suggest to close this issue.


SCTP: Notifier & Initialization

SCTP can now initiate a connection.
SCTP can now notify the upper layers of its connection state.

Relates to #159

Pull Request Test Coverage Report for Build 946

26 of 214 (12.15%)  changed or added relevant lines in 17 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-1.3%) to 51.157%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/sctp/param_state_cookie.go
0
3
0.0%

internal/sctp/param_header.go
0
3
0.0%

internal/sctp/chunk.go
0
3
0.0%

internal/sctp/error_cause_unrecognized_chunk_type.go
0
3
0.0%

internal/sctp/chunk_cookie_ack.go
0
3
0.0%

internal/sctp/chunk_init.go
0
3
0.0%

internal/sctp/chunk_init_ack.go
0
3
0.0%

internal/sctp/error_cause_protocol_violation.go
0
3
0.0%

internal/sctp/error_cause_header.go
0
3
0.0%

internal/sctp/error_cause_invalid_mandatory_parameter.go
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

internal/dtls/dtls.go
1
18.38%

Totals

Change from base Build 944:
-1.3%

Covered Lines:
3360

Relevant Lines:
6568

💛  - Coveralls

@backkem This LGTM! Thanks for chipping away at this :)
I would maybe also get a review from @kc5nra I think he had some ideas around this, he might not have time so if you don't hear from him in 24 feel free to merge!


[Question/Help required] Testing driver support?

Hi! Thanks for the cq package!
I'm trying to test some query-centric code. I want to stub query results in order to test some behaviours.
I've been using erikstmartin/go-testdb for most of our simple queries and statements.
But I noticed that driver will not work for a few cases, (for example when you want to perform a neo query with a []int)
I'm interested on creating a neo4j-test driver. But I'm a bit lost on where should I start.
The final goal is to do the same as the go-testdb does but with support for cypher values.
This issue is to request a bit of support. Since I think the Converter is where the problem is. Maybe is as simple as defining a Converter that uses cypher converter. But I'm pretty sure I'm missing some points.
Thanks!

Hi again.
Just wanted to inform that I was able to do what I needed only adding the cypher conversor.
https://github.com/naxhh/cq-test
I just didn't checked all the stuff the library supports but for now does what I need.


[Question] Why is the User table named "users" and not "user"?

Is there any reason why the User table is named users and not user?
The Role table is named role, so I would expect user not users...

or roles and not role :D

I'd indeed ask why role and not roles :)
Normal inconsistencies, btw: can't change due to BC policies.

I'm a "fan" of singular table names, so "role" is IMO :+1:
http://stackoverflow.com/questions/338156/table-naming-dilemma-singular-vs-plural-names
http://stackoverflow.com/questions/808992/singular-or-plural-database-table-names

I agree with @Ocramius I use plural for table name

@websafe a table represents a collection in the domain of SQL: don't make it singular, as it does not reflect the domain concept, and also exposes loads of issues with singularization/pluralization as well.

"user" is a reserved word in most RDBMS.

@unkind Ok, but that's not a problem:
MySQL [mysql]> show tables;
+---------------------------+
| Tables_in_mysql           |
+---------------------------+
| columns_priv              |
| db                        |
| event                     |
| func                      |
| general_log               |
| help_category             |
| help_keyword              |
| help_relation             |
| help_topic                |
| host                      |
| ndb_binlog_index          |
| plugin                    |
| proc                      |
| procs_priv                |
| proxies_priv              |
| servers                   |
| slow_log                  |
| tables_priv               |
| time_zone                 |
| time_zone_leap_second     |
| time_zone_name            |
| time_zone_transition      |
| time_zone_transition_type |
| user                      |
+---------------------------+
24 rows in set (0.00 sec)

and on the other hand using plural will force to use @ORM\Table(name="users") in entities.
I don't want to start a discussion about singular/plural ;-) I just wanted to know what's the cause of the current inconsistency and @Ocramius pointed this out. And I'm fine with it. I guess I will be able to use singular in my projects without any problems (BC, etc.).

and on the other hand using plural will force to use @ORM\Table(name="users") in entities.

Doctrine doesn't have autoescaping of reserved words, so you'd have to write @ORM\Table(name="user"). Anyway, that was just guess.

And what happens when we omit @ORM\Table(name="user") because the entity is already named User?
https://github.com/ZF-Commons/ZfcUserDoctrineORM/blob/master/src/ZfcUserDoctrineORM/Entity/User.php
I guess Doctrine will handle this, or am I wrong?

@websafe it will likely lead to crashes

Auto-quoting is not done for identifiers due to the fact that it is not portable.

Auto-quoting is not done for identifiers due to the fact that it is not portable.

What do you mean, there is RDBMS without quoting of identifiers? If so, it is possible to handle this case somehow for that drivers (add prefixes, suffixes, etc.)? Manual quoting doesn't solve portability issue at all, does it?

Auto-quoting won't work due to:

MySQL behaves differently depending on the OS it runs on
MySQL behaves differently depending on config settings in my.ini
PostgreSQL behaves in a strict case-sensitive mode when quoting is used

Additionally, manual quoting has cut it so far, and there are no security implications anyway.

MySQL behaves differently depending on ...

Not sure what do you mean again. Backtick works always, no?

PostgreSQL behaves in a strict case-sensitive mode when quoting is used

I mean auto-quoting for reserved words, it is better than syntax error anyway :)

I'm trying now the following
php vendor/bin/doctrine-module orm:schema-tool:create --dump-sql

on the default ZfcUserDoctrineORMs  User entity:
<?php

namespace ZfcUserDoctrineORM\Entity;

use ZfcUser\Entity\User as ZfcUserEntity;

class User extends ZfcUserEntity
{}

which extends:
<?php

namespace ZfcUser\Entity;

class User implements UserInterface
{
    /**
     * @var int
     */
    protected $id;

    /**
     * @var string
     */
    protected $username;

    /**
     * @var string
     */
    protected $email;

    /**
     * @var string
     */
    protected $displayName;

    /**
     * @var string
     */
    protected $password;

    /**
     * @var int
     */
    protected $state;

    /**
     * Get id.
     *
     * @return int
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * Set id.
     *
     * @param int $id
     * @return UserInterface
     */
    public function setId($id)
    {
        $this->id = (int) $id;
        return $this;
    }

    /**
     * Get username.
     *
     * @return string
     */
    public function getUsername()
    {
        return $this->username;
    }

    /**
     * Set username.
     *
     * @param string $username
     * @return UserInterface
     */
    public function setUsername($username)
    {
        $this->username = $username;
        return $this;
    }

    /**
     * Get email.
     *
     * @return string
     */
    public function getEmail()
    {
        return $this->email;
    }

    /**
     * Set email.
     *
     * @param string $email
     * @return UserInterface
     */
    public function setEmail($email)
    {
        $this->email = $email;
        return $this;
    }

    /**
     * Get displayName.
     *
     * @return string
     */
    public function getDisplayName()
    {
        return $this->displayName;
    }

    /**
     * Set displayName.
     *
     * @param string $displayName
     * @return UserInterface
     */
    public function setDisplayName($displayName)
    {
        $this->displayName = $displayName;
        return $this;
    }

    /**
     * Get password.
     *
     * @return string
     */
    public function getPassword()
    {
        return $this->password;
    }

    /**
     * Set password.
     *
     * @param string $password
     * @return UserInterface
     */
    public function setPassword($password)
    {
        $this->password = $password;
        return $this;
    }

    /**
     * Get state.
     *
     * @return int
     */
    public function getState()
    {
        return $this->state;
    }

    /**
     * Set state.
     *
     * @param int $state
     * @return UserInterface
     */
    public function setState($state)
    {
        $this->state = $state;
        return $this;
    }
}

and the result is:
CREATE TABLE user (
    user_id INT AUTO_INCREMENT NOT NULL,
    username VARCHAR(255) DEFAULT NULL,
    email VARCHAR(255) DEFAULT NULL,
    display_name VARCHAR(50) DEFAULT NULL,
    password VARCHAR(128) NOT NULL,
    state SMALLINT DEFAULT NULL,
    UNIQUE INDEX UNIQ_8D93D649F85E0677 (username),
    UNIQUE INDEX UNIQ_8D93D649E7927C74 (email),
    PRIMARY KEY(user_id)
)
DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB;

and after running:
php vendor/bin/doctrine-module orm:schema-tool:create

the result:
ATTENTION: This operation should not be executed in a production environment.

Creating database schema...
Database schema created successfully!

and a user table is created.
I've found this:

Sometimes it is necessary to quote a column or table name because of reserved word conflicts. Doctrine does not quote identifiers automatically, because it leads to more problems than it would solve. Quoting tables and column names needs to be done explicitly using ticks in the definition.

here: http://doctrine-orm.readthedocs.org/en/latest/reference/basic-mapping.html
so this is generally what @Ocramius mentioned, but maybe some kind of auto quoting is done, when the entity has no @Table defined?
And continuing, ZfcUserDoctrineORM without BjyAuthorize is using user not users, but again, I don't want to force anything here, just wanted to report the inconsistency I've found :-)
That's all. I guess we can close this?

You just had luck there: user is recognized as a special token only in some contexts. In DDL it should work.

Try group for example, then a simple ->find() :P

OK @Ocramius I trust you :-) So in this case should we expect that https://github.com/ZF-Commons/ZfcUserDoctrineORM @EvanDotPro @spiffyjr will migrate the user table to users by adding a corresponding Doctrine annotation in https://github.com/ZF-Commons/ZfcUserDoctrineORM/blob/master/src/ZfcUserDoctrineORM/Entity/User.php?

Pretty sure that it "automatically" (don't think it does) use "user" instead "users" due to it's config.
In ZfcUserDoctrineOrm vendor, file: module.config.php
        'zfcuser_entity' => array(
            'class' => 'Doctrine\ORM\Mapping\Driver\XmlDriver',
            'paths' => __DIR__ . '/xml/zfcuser'
        ),

In /config/xml/zfcuser a file: ZfcUser.Entity.User.dcm.xml, below:

<mapped-superclass name="ZfcUser\Entity\User" table="user">

    <id name="id" type="integer" column="user_id">
        <generator strategy="AUTO" />
    </id>

    <field name="username" type="string" length="255" unique="true" nullable="true" />
    <field name="email" type="string" unique="true" length="255" nullable="true"/>
    <field name="displayName" column="display_name" type="string" length="50" nullable="true" />
    <field name="password" type="string" length="128" />
    <field name="state" type="smallint" nullable="true" />

</mapped-superclass>

First line of the Xml states; table="user", pretty sure that's a typo.

Not a typo, just different conventions. I've met many DBAs that prefer using plural, and many that prefer using singular.


Conversation.java:35-36: Hello was added, to handle hello...

The puzzle 222-903f585c (from #222) in src/main/java/com/amihaiemil/charles/github/Conversation.java (lines 35-36) has to be resolved: "Hello was added, to handle hello commands. Continue with further Knowledges for the other commands (index site, index page etc)."
The puzzle was created by Mihai Andronache on 15-Aug-17.
Estimate: 30 minutes, role: IMP.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 222-903f585c has disappeared from the source code, that's why I closed this issue.


Service 'menu.component.menu' has already been added.

Hi,
I have installed the latest version 2.0.
I created a configuration like in the example:
menu:
  front:
    items:
      Home:
        action: :Front:Home:default
      Books:
        link: '#'
        items:
          All:
            action: :Front:Books:all
          Featured:
            action: :Front:Books:featured
  admin:
    items:
      Users:
        action: :Admin:Users:default
      Books:
        action: :Admin:Books:default

And I receive error: Service 'menu.component.menu' has already been added.
----> Tracy report <----
The problem is probably resolved by commit: 2324df0a506748585b55c76c4656f0289a5a2953
Do you plan release a new stable version that fixes the bug?
I went according to the example and it would not work.
If I only started with Nette, I would probably have tried some other extension right away.
It would help to add some tests of DI extension
to prevent such bugs (I can prepare PR if you are interested).
I've been using your extension for a long time, and it's a very good thing!

Hello, first thanks for using this library and reporting this problem 😺
You are correct that your issue was already solved, I only didn't tag a new version... Until now 😉 , so you can try to install version 2.1.0.
If you're wiling to send some more tests I'll be more than thankfull. If you want, you can look at the tests we had in version 1 and maybe take some inspiration there: https://github.com/Carrooi/Nette-Menu/blob/1.1.1/tests/DKTests/Menu/Extension.phpt

Great. It works. Thanks for the quick answer. I'm going to look at those tests.


Incompatible Composer Docker Image Version

The Dockerfile uses a generic syntax to always choose the latest version of composer:2 … composer 2.4.2 has a breaking change that causes the Apigee Kickstart to throw a 500 error.
Workaround: pin the base composer image to 2.4.1.

Thank you for reporting this @mhottinger1 ,
We have fixed the issue : https://github.com/apigee/docker-apigee-drupal-kickstart/commit/0b80869bda17a7e5bfc11f66beeab58cad6fa742
Please feel free to re-open if it still a problem.

Thanks! I believe your fix has addressed the issue!


Remove optional comment from port

As it is using the general connection factory builder it doesn't default to 5432

@chbatey Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@chbatey Thank you for signing the Contributor License Agreement!

While the documentation is wrong given the existing implementation, the problem is really that the implementation doesn't handle the port as optional.  I've opened #100 to solve this problem.


Errors on grunt build using google-api-nodejs-client with webpack

I'm using https://www.npmjs.com/package/googleapis in a ReactJS Webpack app. npm install googleapis --save installed it ok, added "googleapis": "^2.0.2" to my package.json, but when I run grunt build I get the following warnings (followed by lots of errors which I'll post upon request, as it is a lot of text):
WARNING in ./~/googleapis/apis/index.js
Critical dependencies:
41:23-44 the request of a dependency is an expression
@ ./~/googleapis/apis/index.js 41:23-44

WARNING in ./~/googleapis/~/request/~/hawk/~/hoek/lib/index.js
Critical dependencies:
403:34-60 the request of a dependency is an expression
@ ./~/googleapis/~/request/~/hawk/~/hoek/lib/index.js 403:34-60

Code that requires googleapis in my React component:
var gapi = require('googleapis');

Note: Any other code from the component can be provided on request, but I don't believe it's relevant to this issue.
My package.json dependencies:
"dependencies": {
"aws-sdk": "^2.0.21",
"chalk": "^0.5.0",
"crypto-js": "^3.1.2-5",
"cryptojs": "^2.5.3",
"envify": "^1.2.1",
"fluxxor": "1.5.1",
"googleapis": "^2.0.2",
"imports-loader": "^0.6.3",
"jquery": "~2.1.1",
"moment": "^2.8.3",
"react": "0.11.1",
"react-bootstrap": "0.12.0",
"react-router": "0.5.2",
"react-router-bootstrap": "0.5.0"
},
"devDependencies": {
"connect-livereload": "^0.4.0",
"css-loader": "^0.7.0",
"es6-promise": "^1.0.0",
"esrever": "^0.1.0",
"grunt": "^0.4.5",
"grunt-contrib-copy": "^0.5.0",
"grunt-contrib-less": "~0.11.4",
"grunt-contrib-uglify": "^0.7.0",
"grunt-contrib-watch": "^0.6.1",
"grunt-git": "^0.2.14",
"grunt-gitinfo": "^0.1.6",
"grunt-karma": "^0.8.3",
"grunt-lesslint": "^1.1.13",
"grunt-rsync": "^0.6.1",
"grunt-ssh": "^0.11.2",
"grunt-webpack": "^1.0.8",
"jssha": "^1.5.0",
"jsx-loader": "^0.10.2",
"karma": "^0.12.17",
"karma-chrome-launcher": "^0.1.7",
"karma-coverage": "^0.2.7",
"karma-jasmine": "^0.1.5",
"karma-js-coverage": "^0.4.0",
"karma-osx-reporter": "^0.1.0",
"karma-phantomjs-launcher": "^0.1.4",
"karma-sourcemap-loader": "^0.3.2",
"karma-webpack": "^1.2.1",
"load-grunt-tasks": "^0.6.0",
"style-loader": "^0.6.4",
"time-grunt": "^1.0.0",
"webpack": "^1.4.15"
}

npm version 2.5.1
node version v0.12.1
Thanks in advance for any help!

The offending line is:
var Endpoint = require(endpointPath);

I think it complains about not stating our dependency explicitly (as a string), but rather as a variable that needs to be evaluated first (an expression).
From architectural perspective, this is beneficial to keep the codebase flexible and will likely not be modified to avoid the warning you are getting. I think you will need to figure a way how to make your Grunt task ignore this warning or otherwise make it work...

Thanks @Alaneor. One of the errors I'm getting, any thoughts on that? It seems to be missing the fs module, which seems to be a native nodeJS module and should be available.
ERROR in ./~/googleapis/~/request/~/hawk/~/hoek/lib/index.js
Module not found: Error: Cannot resolve module 'fs' in /Users/dev/wwb-web-   app/node_modules/googleapis/node_modules/request/node_modules/hawk/node_modules/hoek/lib
@ ./~/googleapis/~/request/~/hawk/~/hoek/lib/index.js 3:9-22

Can't tell without knowing what Grunt plugin is causing it... But I have a terrible suspicion it's Browserify.
I cannot imagine how you could possibly package the fs module for browser.

@dmk12 Any chance you found a solution?

@FriesFlorian No, sorry. I attributed it to the fact that the npm script is alpha, so things just don't work... :/ Ended up adding a link to googleapi to my index.html the old fashioned way.

hi,
It seems that this error is still present.
Does someone found a workaround in order to googleapi working with node ?
I'd like to implement some test but I block on that issue for now ...

My team and I are using webpack (which is also using babel) as part of a combined setup of React+Meteor, and also getting this error.  Kind of a bummer, this is the only package which is throwing this sort of error on us.  We're getting both the the request of a dependency is an expression error and the Cannot resolve module 'fs' one.
@dmk12 , did loading googleapi from a script tag ever cause any issues?  Are you able to perform any operations from the server using the APIs?  We want our server-side code to interact with them, but this error is stopping us dead in our tracks.

@john-osullivan No, I had no issues using a script tag whatsoever, our server API (Django/Python) is interacting with Google API just fine, mostly used for registering/login in users, so I'd say you're safe using a script tag :)

Any update on this error? Still persisting over here in my Electron app with web pack :/

Just noting that I also encountered this issue. Ended up using a script tag instead.

google-api-nodejs-client is not meant to be used in a browser—it won't work. googleapis (google-api-nodejs-client) will work in Node.js. Excluding googleapis from any server-side bundle (just let Node's module system load it for you) is the best option.
To access Google APIs from a browser, please use the Google API Client Library for JavaScript (gapi).

+1 @jmdobry
case closed.
by the way, in case of fs you can ignore it by add this codes (though not related with this issue)
node: {
    console: 'empty',
    fs: 'empty',
    net: 'empty',
    tls: 'empty'
  }


Orders Imported from Channable have cart rules applied

We have a cart price rule set up in Magento that doesn't have a code and so it auto-applies if the items match with the Actions rules when a customer puts them in their cart.
However, when orders are imported through Channable into our Magento shop, they seem to also be running through that logic and so the order prices in Magento don't match what was actually paid on the marketplace (Amazon, in this case).
Is there a setting or a way to have the imported orders bypass any cart pricing rules so that the prices paid on the marketplace are the ones that are also in the Magento order?

HI @batmike, thank you for opening the issue. I've just pushed a fixed that unsets the discount amount on Channable orders. Can you try if this branch fixes your issue?
https://github.com/magmodules/magento2-channable/tree/bugfix/unset-discount

HI @batmike, any update on this issue?

@Marvin-Magmodules - there have not been any more issues so the fix appears to be working properly. We also haven't seen any new issues pop up so we're in good working order. I'll close this but if anything new comes up, I'll certainly follow up again. Thanks!


Fix jsx-wrap-multiline rule for closing parenthesis

There was a bug in this rule: having the opening parenthesis on a new line before the opening tag, but the closing parenthesis on the same line as the closing tag, would not trigger this rule.
This was caused by the fact that the index variable (as calculated by siblings.indexOf) was equal to -1 in some cases.
The index is now calculated by checking just the pos and end fields of a node, instead of the default object equality that indexOf uses.
With this change, the check that tested whether the node started with a newline is no longer needed (and with it, also the prevTokenKind variable is no longer needed).
Also, two tests have been added:

A multiline JSX component with the closing parenthesis on a new line, but the opening parenthisis on the same line
A multiline JSX component with the opening parenthesis on a new line, but the closing parenthisis on the same line

Hello.
Is it expected behavior ?
const Test: React.FC = () => {
    return ReactDOM.createPortal(

            test

                Lorem ipsum dolor sit amet consectetur adipisicing elit. Fugiat numquam aliquid et cum quis consequatur
                commodi aliquam iure optio, ipsam voluptatum iste libero quaerat quia. Quos cupiditate eaque neque odio!

        ,
        document.querySelector("#test"),
    );
};

ERROR: src/test.tsx:3:9 - Multiline JSX elements must be wrapped in parentheses

@magic-akari I'd say yes, this is expected. The ... element is not wrapped in parentheses. The  tag is followed by a comma and a call to querySelector.

Thank you for your reply.
The parentheses I added will be erased by the prettier. And I think the parentheses are unnecessary in this case. I prefer the rule of prettier.
Since this is the expected behavior, I have no choice but to disable this rule.

Ah, you did not yet say that there is a conflict between the pretty-printer and the linter.
That does sound like a problem, maybe you can open a new issue describing your situation?

prettier will often conflict with tslint & tslint-react's formatting rules. no need to open a new issue -- my recommendation is to stop using tslint & tslint-react's formatting rules and use prettier instead. the former will not be maintained in the future. see #210


[Snyk] Security upgrade dnsjava:dnsjava from 3.5.2 to 3.6.0

Snyk has created this PR to fix 1 vulnerabilities in the maven dependencies of this project.
Snyk changed the following file(s):

pom.xml

Vulnerabilities that will be fixed with an upgrade:

Issue
Score
Upgrade

Allocation of Resources Without Limits or Throttling SNYK-JAVA-DNSJAVA-7547405
  756
dnsjava:dnsjava:  3.5.2 -> 3.6.0  Proof of Concept

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling

:tada: Snyk checks have passed. No issues have been found so far.
:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)


Error during Cordova build Android

Hi,
keep on getting this error. Does it sound familiar?
Error: /Users/user/Sites/app/platforms/android/gradlew: Command failed with exit code 1 Error output:

Note: Some input files use or override a deprecated API.

Note: Recompile with -Xlint:deprecation for details.

/Users/user/Sites/app/platforms/android/src/org/apache/cordova/firebase/FirebasePluginMessagingService.java:129: error: constructor Builder in class Builder cannot be applied to given types;
            NotificationCompat.Builder notificationBuilder = new NotificationCompat.Builder(this, channelId);
                                                             ^
  required: Context
  found: FirebasePluginMessagingService,String
  reason: actual and formal argument lists differ in length
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error

FAILURE: Build failed with an exception.

cordova CLI: v7.1.0
cordova-android: v6.4.0
OS: macOS v10.13.4
I'm trying to make use of this plugin along with the following:
      "cordova-android-firebase-gradle-release": {
        "FIREBASE_VERSION": "12.+"
      },
      "cordova-android-play-services-gradle-release": {
        "PLAY_SERVICES_VERSION": "12.+"
      },

This is what I'm targeting in the config.xml:
<preference name="android-minSdkVersion" value="17" />
<preference name="android-targetSdkVersion" value="23" />

I am having the same issue

I have the same issue too, please help

@asifmehmood91 @zahersi I sorted this out doing the following:
  <plugin name="cordova-android-firebase-gradle-release" spec="^1.0.2">
    <variable name="FIREBASE_VERSION" value="11.0.+" />
  </plugin>
  <plugin name="cordova-android-play-services-gradle-release" spec="^1.4.3">
    <variable name="PLAY_SERVICES_VERSION" value="11.0.+" />
  </plugin>

As you can see I'm being more specific by using 11.0.+, it might be ok with 12.0.+ but I haven't tried yet.
I've also bumped the android-minSdkVersion up, from 17 to 18
I'm now using cordova-android 7.0.0 whereas before, I was using 6.4.0.

p.s. Make sure to delete the generated iOS and android folders within the platforms directory and build everything from scratch with cordova prepare or cordova platform add ...
Hope this helps.

thanks @fabrz but unfortunately I'm still getting the same error message when trying to build or run on android.
my installed plugins are:
cordova-android-firebase-gradle-release 1.0.2 "cordova-android-firebase-gradle-release" cordova-android-play-services-gradle-release 1.4.3 "cordova-android-play-services-gradle-release" cordova-plugin-dialogs 2.0.1 "Notification" cordova-plugin-firebase 1.0.5 "Google Firebase Plugin" cordova-plugin-network-information 2.0.1 "Network Information" cordova-plugin-splashscreen 5.0.2 "Splashscreen" cordova-plugin-statusbar 2.4.2 "StatusBar" cordova-plugin-vibration 3.1.0 "Vibration" cordova-plugin-whitelist 1.3.3 "Whitelist"
my config.xml contains:
<plugin name="cordova-android-firebase-gradle-release" spec="^1.0.2">         <variable name="FIREBASE_VERSION" value="11.0.+" />     </plugin>     <plugin name="cordova-android-play-services-gradle-release" spec="^1.4.3">         <variable name="PLAY_SERVICES_VERSION" value="11.0.+" />     </plugin>     <plugin name="cordova-plugin-firebase" spec="cordova-plugin-firebase">         <variable name="ANDROID_SUPPORT_VERSION" value="26.+" />     </plugin>     <engine name="android" spec="^7.0.0" />
can you help plaese

thanks @fabrz it worked using cordova-android-support-gradle-release
I upgraded my cordova-android-support-gradle-release's ANDROID_SUPPORT_VERSION variable from 25.+ to 26.+ and it worked
original issue link:
https://github.com/arnesson/cordova-plugin-firebase/issues/676

I have this error when using with facebook ads plugins from https://github.com/floatinghotpot/cordova-plugin-facebookads
(Actually it's this one:
cordova plugin add https://github.com/ElieSauveterre/cordova-plugin-facebookads#d540140816f93ee37ebef8cf5b05e438db17588a
)
When I remove the FB ads plugin it works good.
Does anyone using both of these plugins together, successfully?
Thanks.

closing as resolved since the original creator has found a fix

@soumak77 it would be great if you posted what the fix is .... I looked at the change log and didnt find anything that mentioned this error.


Scale Text with Icon in fa_icon helper

Its a bit of a visual bug to add 2x to an icon via the fa_icon helper and not have the text inherit the fa-2x class too.

Wouldn't it be more proper to scale the text to the same size as the icon as this is the most likely desired behavior

This could be done via moving the fa-2x to a wrapper span.

  Some text here

Hmm. Interesting edge case, but I don't think we should do anything about this.

fa-2x isn't meant to be used outside an individual icon. i.e. It is intended to always be combined with another fa class.
Related, wrapping any kind of readable text with a fa prefixed class is not how Font-Awesome was designed to be used.
Our :text option on the fa_icon is just a quick ease-of-use facilitating option. The text is not given any kind of wrapper, and we don't currently intend to give it a wrapper. If you want the text to have other behavior, don't use the :text option, or wrap the entire fa_icon call with something else. Reasons were covered in #114 and #135.

For example, even though it violates what I believe to be Font-Awesome's intent, you can achieve your desired behavior with this:
HAML
%span.fa-2x= fa_icon "file-pdf-o", text: file.name

ERB
<%= fa_icon "file-pdf-o", text: file.name %>

Your choice to not do it though as I can (and do) fall back to just rolling my own or use your solution. I was just suggesting this as fa_icon kind of falls into a decorator pattern so you could roll this up into it. Your call though.  Overall I can't complain about the awesomeness of your gem. Well documented and kept up-to-date swimmingly well. Keep up the good work.

Thanks for understanding. With 4M total downloads of this gem (which probably equates to thousands of active projects using it), making a change like the one proposed here becomes quite a bit of a backwards compatibility nightmare. I just don't think the cost outweighs the reward.


Updated JobLaunchingTasklet to support restarts of child jobs

If you could pull this off master onto a branch that would be great.

Closed for a new one on a feature branch


Translations update from Weblate

Translations update from Weblate for GitTouch/GitTouch.
Current translation status:

Arb file for a fallback, nb, does not exist, even though
the following locale(s) exist: [nb_NO].
When locales specify a script code or country code, a
base locale (without the script code or country code) should
exist as the fallback. Please create a {fileName}_nb.arb
file.
Generating synthetic localizations package has failed.

Get an error after merged. It seems nb should exist as nb_NO's fallback, but there is no such option in the WebLate  😕


Improve CI workflows in AsyncAPI repositories

Context
GitHub finally fixed the issue with lack of support for workflows running on forks (tl;dr forks had access to read-only token for security reasons).
Description

first change workflows running on pull_request event to pull_request_target to make sure PRs created from fork have access to write token (it is mostly the welcome workflow like https://github.com/asyncapi/asyncapi/blob/master/.github/workflows/welcome-first-time-contrib.yml (DONE 🟢 thanks to Hacktoberfest)
run tests in workflows not only on linux but windows too
validate titles of PRs with https://github.com/amannn/action-semantic-pull-request to make sure conventional commits are used
Start triggering pull request merge with a specific label. It is a great step to improve the security of your GitHub organization. To be 100% sure we are secure from vulnerabilities (someone left the organization and we forgot to change their access right) and also our own mistakes (accidentally created branch in upstream), no one should have write access to repositories except of admins. Write access should belong only to a bot that can merge pull requests. Rest of the org members can have triage level rights so they can assign issues or add labels. Aside from security improvement it is also good for all org members to easily decide on when to merge a PR by just adding a label
Add twitter workflow (like in html-template and parser) to all repos where we have releases workflows

during SIG meeting @damaru-inc and @jonaslagoni didn't share any concerns with doing automated pull request merge. The best approach seems to be automated merge if we have all approvals and checks and have it "blockable" with a label like do-not-merge.
Important to follow up on who can "Approve a PR". Do you need to be a member of organization or not, cause if not, then we will have to introduce CODEOWNERS first and have the protection that requires approval from a Codeowner

Would be great if we can start integrating our coverage reports to ensure it does not diminish from PR to PR but stays the same or improve. As @derberg suggested coveralls.io is free for open source projects which can be used to solve this issue.
Based on discussion on Slack
Jonas Lagoni
Am I the only one who thinks its time we add test coverage as GitHub badge on the repos :face_with_monocle:?

Lukasz Gornicki
depends what you want to achieve really.
I never look at those. I’m more concerned as maintainer, that tests are added once and then they are not added with new PRs. I liked in one project I contribute to that on PR level there was a check that was making sure my PR is not making coverage worse

Jonas Lagoni
And that, but as a user I like to see the testing coverage of the library, since it tells you something about the state of it. And since we have it I think we should integrate it :slightly_smiling_face: also we should adapt GitHub workflows to fail if coverage declines. Don't think that's added to any library is it :thinking_face: ? (edited)

Lukasz Gornicki
like I said, I never look at this, test coverage is not important for me when I do assessment of an open source project. But I’m not against of course.
and yeap, we do not have any workflow that would asses test coverage and its level on a PR.
the library I referred to in my previous comment was openapi-sampler https://github.com/Redocly/openapi-sampler/pull/117
it uses Coveralls https://coveralls.io/builds/34213343
it is free for open source https://coveralls.io/pricing (edited)

Jonas Lagoni
Would be awesome IMO :blobblewobble:

Lukasz Gornicki
I’m wondering where to add it :thinking_face:
maybe just put a comment with all details here https://github.com/asyncapi/asyncapi/issues/423 so we do not forget? (edited)

Jonas Lagoni
Think it's a great place to put it yea :slightly_smiling_face:

Another one to discuss/decide: What slack integration do we use:

github action like here https://github.com/asyncapi/generator/blob/master/.github/workflows/sentiment-analysis.yml#L35  where we have full control over the message
semantic release plugin that we already use in the generator  https://github.com/asyncapi/generator/blob/master/package.json#L109

problem with semantic release is that it passes release notes to slack rendered and when we have @asyncapi there then a random user on slack is pinged. We could add asyncapi user to slack as a workaround though

we need to switch to latest action for pull request creation as it is failing from time to time, like here https://github.com/asyncapi/markdown-template/runs/1564435740?check_suite_focus=true and causes issues like https://github.com/asyncapi/markdown-template/issues/49. fun fact, action shows error but PR is actually created. We need to switch to 3.0

PR https://github.com/asyncapi/.github/pull/18 addresses => https://github.com/asyncapi/asyncapi/issues/423#issuecomment-742523996 and Add twitter workflow (like in html-template and parser) to all repos where we have releases workflows
PR https://github.com/asyncapi/.github/pull/21 addresses => is just about making release workflow easier to manage and more decoupled

PR https://github.com/asyncapi/.github/pull/18 addresses => https://github.com/asyncapi/asyncapi/issues/423#issuecomment-742523996 and Add twitter workflow (like in html-template and parser) to all repos where we have releases workflows
PR https://github.com/asyncapi/.github/pull/21 addresses => is just about making release workflow easier to manage and more decoupled

for linting of PRs titles I suggest we use https://github.com/amannn/action-semantic-pull-request. It had only one missing feature but I just contributed it last week and it works great now

for linting of PRs titles I suggest we use https://github.com/amannn/action-semantic-pull-request. It had only one missing feature but I just contributed it last week and it works great now

I'm closing this issue as it grew big with lots of discussions. 2 things in CI from this issue are not done yet. Follow-up issues created:

https://github.com/asyncapi/.github/issues/30
https://github.com/asyncapi/.github/issues/31

I'm closing this issue as it grew big with lots of discussions. 2 things in CI from this issue are not done yet. Follow-up issues created:

https://github.com/asyncapi/.github/issues/30
https://github.com/asyncapi/.github/issues/31


Pass -cclib flags when building cma archives

This is needed for building custom bytecode executables. For instance, the following command fails with the released version of ocb-stubblr but succeeds after this patch:
$ ocamlfind ocamlc -custom -linkpkg -linkall -package nocrypto
/tmp/ccaMFOfv.o:(.data+0x2540): undefined reference to `caml_nc_xor_into'
/tmp/ccaMFOfv.o:(.data+0x2548): undefined reference to `caml_nc_sha512_init'
[...]
collect2: error: ld returned 1 exit status
File "_none_", line 1:
Error: Error while building custom runtime system

I just noticed that this is a duplicate of #11


Migrate to typescript

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Fixed in #17 !! great job @yannbf !! 👏


yfdfi attmpt 2

If you want to create a space follow this guide
https://docs.snapshot.page/guides/create-a-space
Clean PR with requested changes.

only logo.png is 56kb the other are less
what square?

Square for this 2 images.

Please could you also remove your readme.md file?


Does match works without ssh ?

Can I setup match with username and password of git repo ?

Yes, I don't use Match with ssh at all (It's blocked in our corporate setting). If your connecting to a git repo with a username and password, you'll have to set your git global config to save your credentials.


testBrokerReplicator(enmasse.broker.forwarder.ForwarderControllerTest) failed

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.836 s <<< FAILURE! - in enmasse.broker.forwarder.ForwarderControllerTest
[ERROR] testBrokerReplicator(enmasse.broker.forwarder.ForwarderControllerTest)  Time elapsed: 5.43 s  <<< ERROR!
java.util.ConcurrentModificationException
at enmasse.broker.forwarder.ForwarderControllerTest.testBrokerReplicator(ForwarderControllerTest.java:83)
[ERROR] Errors:
[ERROR]   ForwarderControllerTest.testBrokerReplicator:83 » ConcurrentModification
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0

Test seems stable. I was running them in progress of refactoring to junit5 many times without fail.


Add support for Debian 12 in onesysprep

Description
Brief testing found failures when using onesysprep tool in Debian 12
Use case
Extending range of supported OSes.
Interface Changes
None
Additional Context
None

Progress Status

[ ] Code commited
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

This issue found by tests was a side-effect of the following: https://github.com/OpenNebula/addon-context-linux/issues/269