Reference the in-house Ansible tutorial, from the Ansible-Galaxy tutorial

Not paramount, but why not mention it since the effort was put into writing it?

Maybe also do the mirror version: refer to this tutorial from the Ansible tutorial https://github.com/galaxyproject/training-material/blob/main/topics/admin/tutorials/ansible/tutorial.md?plain=1
I see there is an "Ansible-Galaxy" section there, but no link to this tutorial.
I don't want to spam pull requests, so let me know if this is a good idea.

Thank you for the feedback.
I'm following the tutorial at the same time and will update the PR at the same time.
I'll post a new comment when it's ready for a new review.

I'm following the tutorial and will update the PR at the same time.

when you're done, please add yourself to the testing section of the tutorial header (under contributions)

Thank you for the "testing" suggestion.
I have not followed the "install Galaxy with Ansible" tutorial yet, but should be enough progress for now.

The "contributors.yaml/organisation.yaml" additions are redundant with my other PR (https://github.com/galaxyproject/training-material/pull/4972) , but will not cause any merge conflict (same change in same location in the files)
Feedback on the display of requirements:

Thanks, I had not seen it
"Hands on: Hands on: " seems like a mistake? Should be 0 "Hands on" since there is a "Hands on" link to the right?
I feel like "Galaxy server administration" should not be a hyperlink
I feel like "Ansible" should be in bold
This seems to be in the website's engine, as opposed to something I can change in the tutorial.md directly

There are alot of links that point to version 2.9 of the Ansible doc website, in both tutorials

I understand not pointing to /latest/, for stability's sake
But I think it would be good to update it to /9/ (Ansible changed version naming conventions, 9==2.17) since 2.9 is 5 years old
I tried to it, but it was too time-consuming so I did not have the time

It is time-consuming because there are tens of links and about half are invalid if you just replace /2.9/ with /9/
I spent some time searching for the corresponding links in the new documentation, but I'm not good enough at Ansible for the moment to do that

I think there is a bug in the "details" tag, when the text is longer than one line, causing bugs such as the following:

you can see that the "4. Create the roles directory (...)" is to the right instead of on a new line
this is in the "live" version
As a patch (not the cleanest solution but it works), I changed the content of the detail-title, to make it smaller than one line, and so the bug does not  happen, and there is a new line

And thanks for writing the tutorial, it helped me understand the basics of Ansible!

Forgot to mention why I added a lot of "repository (unrelated to the Galaxy Project)", because as a novice, this was very confusing me
Especially since I started by looking at https://github.com/galaxyproject/ansible-galaxy , it took me a while to realise "ansible-galaxy" didn't refer to that, but actually to the CLI tool that comes packaged with Ansible.

"Hands on: Hands on: " seems like a mistake? Should be 0 "Hands on" since there is a "Hands on" link to the right?
I feel like "Galaxy server administration" should not be a hyperlink
I feel like "Ansible" should be in bold
This seems to be in the website's engine, as opposed to something I can change in the tutorial.md directly

yes these seem like reasonable suggestions (the duplicate hands-on is a known issue I hadn't fixed yet.)
We'll take care of them

But I think it would be good to update it to /9/ (Ansible changed version naming conventions, 9==2.17) since 2.9 is 5 years old

Yes, it would be good. We'll see about doing that during the next GAT, whenever that is. Outside of the GAT events the materials do not get updated very often because the update process is quite laborious and we want to be sure that all tutorials in the GAT series work together correctly.
You intended this to be a small change, I think that's good :) Please don't feel the need to take on big tasks like that, that can be a task for the team.
I'll file it as a separate issue and add to our GAT roadmap.

I think there is a bug in the "details" tag, when the text is longer than one line, causing bugs such as the following:

I will move it into a separate bug, I've suggested reverting that change because it would cause other issues. We will investigate it more thoroughly.

And thanks for writing the tutorial, it helped me understand the basics of Ansible!

I'm glad it was helpful! I don't think it is a great tutorial, it's not my best work, I think it could be improved a lot but I have not had time for it lately. but good that it is still useful in this state.

Thanks! And welcome to the GTN @vladvisan !

@hexylena Thank you for the feedback and for creating the related issues.


Any plans for Backblaze B2 storage with caching locally?

@geekpete there are currently no plans for this.  New storage drivers are generally contributed by the community on a as-needed basis.


Fix up the packaging

Needs more setup.py

I was just looking for a decent photo. Wasnt one in their. Delete it then
right
On Mar 9, 2016 11:07 AM, "Adam Wentz"<EMAIL_ADDRESS>wrote:

Needs more setup.py
—
Reply to this email directly or view it on GitHub
https://github.com/awentzonline/image-analogies/issues/12.

:+1:


Replace caja sanitization with iframe sandboxing.

@shunter I'd appreciate a look at this if you have the time.
@emackey There is still an odd sizing issue going on with some content (not all).  Can you take a look?
As discussed offline, the sandbox attribute on iframe is now widely supported and can replace our caja sanitization. Details on sandboxing.  This allows for much more content to be used (and in a secure manner).
I added an InfoBox.frame property which is the instance of the iframe that is used to host description content. To control sanitization, you can simply modify the InfoBox.frame.sandbox attribute directly.  The default options I turned on are allow-same-origin allow-popups allow-pointer-lock allow-forms That's everything except allow-scripts and allow-top-navigation.  (details in the above link) We also set allowfullscreen to true as well.
I started out just having a sandbox knockout binding on the view model, but exposing the frame also allows users to inject their own CSS into the head section as well as control other attributes.  Anyone have any objections here or thoughts as to why that might be a bad idea?
I also separated out InfoBox description content code into a new css file, InfoBoxDescription.css.  This file is only loaded by the InfoBox iframe and no-one else.
Because I know of at least one case where someone was using the existing sanitize function as a "preprocessor" I deprecated InfoBoxViewModel.defaultSanitizer and InfoBoxViewModel.sanitizer but renamed them to InfoBoxViewModel.defaultPreprocessor and InfoBoxViewModel.preprocessor rather than deleting the capability.
I also renamed InfoBoxViewModel.descriptionRawHtml to InfoBoxViewModel.description. and InfoBoxViewModel.descriptionSanitizedHtml to InfoBoxViewModel.processedDescription.  The values will be identical unless manipulated by a preprocessor.
Finally, I tweaked the GeoJSON description generation to return an empty string if there are no properties, rather than an empty table.
This is important for 1.7 because so many KML balloons are hindered by the overzealous sanitization in master.

@emackey I don't think the infoBodyElement needs to exist any more.  Any reason why I should keep it around.  It seems like an unnecessary div wrapper around the iframe now.

So, you're right to remove that div, and I think I fixed the scrollbar issue.  Unfortunately we may be stuck with that bit of extra space at the bottom.  What's happening is that the word-wrap in the snippet is more aggressive when the scrollbar is there, so the text is longer.  Even if the scrollbar goes away, Chrome is trying to avoid a circular dependency, so setting any height less than the aggressively-wrapped text will cause the scrollbar to appear and the text to be more aggressively word-wrapped.  Long story short we have to leave the space at the bottom, but I don't think that's bad.

Awesome, thanks @emackey!

Okay, I think all outstanding issues have been addressed.  If there's anything else, let me know.

Were you going to add a "light background" class for KML descriptions?

Were you going to add a "light background" class for KML descriptions?

I plan on doing that in the KML branch, just to make sure I get everything correct instead of guessing in this branch and then changing it again after finding a problem.

Oops, just realized CHANGES needs to be updated again.  I'm on it.

Okay, I think we're good.  Anything else?

Looks good.


52 network error handling

Added error handling for a missing network connection and implemented a test.

I don't think it's that much of a problem, since it allows for more interchangebility anyway. Otherwise we temporarily would have to overwrite the methods of WebClient which Squeak won't let me do.

Regarding the test... I think that is out of scope for the MWApiWrapper test specifically. A failure in this test could indicate that something is wrong somewhere in the chain of calls and returned objects, but via the test, you can't easily determine where the error occurred. As long as we test the components individually I'd say we're fine


feat(engine/dolphin): support CALL statement

close #2612
Added CREATE PROCEDURE support for CALL Statement.
And I have updated tidb/parser to support CREATE PROCEDURE.

Thanks! The example from this MySQL docs page may be good enough?

I feel there is no need to support CALL since pingcap/parser does not support CREATE FUNCTION and CREATE PROCEDURE.

I added e2e test

@orisano could you rebase on main? I merged some other dependency updates which conflicts with your changes. Sorry about that.

rebased!


Composer.phar should not be under versionizing

Remove composer.phar from version control

Removed Composer.phar from all Repos.


License

Hello Aizistral,
Are the the other project's licenses(WTFPL) the same as this one?
Kind regards,
Ensamisten

What do you mean, exactly? If you want functionally similar license without swearing, you can use CC0: https://creativecommons.org/share-your-work/public-domain/cc0/


[Addition]: 9 Hotspots hosted in one house

Hotspot b58 Addresses
112hRNpbtvqwgXgYKPDvGRqLWTSk7XKTscXmLZjkiSaH6ou2V9A
112iRQitoAMpGfVbpxtwV3maVPV7n2HzzyFwmtdhFNs7b9v3j2oc
11zHFx4bcHAYgUARsMtrWSfQDRSq4gPs9cRreMHVaFPttKftgBL
11dSdmQbq8krJjiYdyrT6B8kvqak4MBYrJLhzAVJrBXCUP7LFTF
116g6CMcBDugE3wVJqKofQaEDghug9t2j5qdLwJXdEkSpBH9fFd
112S8BLr56ZyvpExMkqhrQdyb2pWy2qdAouYpqj7GExjVHvrvMa1
112LfcK5TKxt5x89U8Mw2s2LRmqi7j9ky7Dp4Qaoz152zj46rRz9
112PaqFv2bEAzwb8MbbuGutc743HCB5ARTtoo9TJ6QmktLmRu9VY
11wyGaUtwiTdmnxMWLX8tnMZxbqdL1Xh82xQynMG7ZfQGcQEha9
Discord Handle
No response
Reason(s)
These Hotspots belong to the same person with 3 Wallets:
14sPMDDUNmpR2mXEH2KHNUu5nmSA3DV7kw2WsuW5GorgfjonHtc
146CZDRvm7dTyoFPrAkQwZNSKPrfJZ77XgBfzfXhH2pJPGbipzn
14PsqnvBqZVgHzjNw9KLgc4FYYR4gCQVxZrfgasBLzkHm1t6qkJ
All 9 Hotspots are hosted in the same small House on that hill.
There exists only 1 House on the entire hill and it is packed full with antennas.

Since when does this game limit the number of hot spots?

There is no limit amount unless they are only witnessing each other or gaming some other way. Just having 9 in one house is more or less dumb. Not really cheating.


Stop Validation on Failure

I have the following constraints:
const constraints = {
  key: {
    presence: {
      allowEmpty: false
    },
    numericality: {
        strict: true
    },
    length: {
      is: 11
    }
  }
};

When "presence" trigger an error I've got an array of errors:
[
"Key can't be blank",
"key must be a valid number",
"Key is the wrong length (should be 11 characters)"
]

I want to get the correct error or only one message for the correct wrong constraint.
Thanks

why not always use the first item of error array?

@349989153 Wow, thanks, didn't see that


feat(ingest): check for private import path usages

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

CI failures are unrelated


Implement ICloneable in CachingCommand

EntityFramework expects a DbCommand implementation to implement ICloneable. I expect CachingCommand works in its current state because the database call is cancelled and the result is retrieved from the cache instead. Not implementing ICloneable gives problems however if EFCache is used in combination with other interceptors.
See OdbcCommand, OleDbCOmmand and SqlCOmmand. All of which implement ICloneable.
For example, I tried to use MiniProfiler together with EFCache. MiniProfiler's ProfiledDbCommand implements (and has to implement) ICloneable, which throws because it tries to called CachingCommand Clone() method, which doesn't exist.
I also created an issue at MiniProfiler. See https://github.com/MiniProfiler/dotnet/issues/175#issuecomment-298312062 and later
Do you see any problems with implementing ICloneable in EFCache?

I will look into this in the coming days.

Thanks for the quick implementation.
Are you planning to release this any time soon? Or would I be better of compiling the latest version myself and releasing it to my private package feed?

@nphmuller - I am planning to release within 2 weeks (I want to add one more thing in the next version).

Great. Thanks!

@nphmuller - I pushed 1.1.1 to NuGet.


2bit llama70b with quip-sharp

https://github.com/Cornell-RelaxML/quip-sharp

Requires CUDA12.
Attempting to use nvcr.io/nvidia/pytorch:23.06-py3 as the base, but something is wrong with transformers-engine inside that image and it crashes on load
pip installing git+https://github.com/NVIDIA/TransformerEngine.git@main fixes the crash
the model loads, but generate call never returns

Closing out all old 2-bit quants.


Some Time PDFViewer Not Loaded

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version: safari 16.2
Operating system and its version: ios webview
PDF.js version: 3.4.120
Is a browser extension: no

Steps to reproduce the problem:

pdf document not loaded
i am using the code
document.getElementById("pdfFrame").contentWindow.PDFViewerApplication.open(
pdfData(base64 string),
password: (password string)
)
problem : sometime PDFViewer Document not loaded error
error text :  2594: firstPagePromise not initailize

What is the expected behavior? (add screenshot)
PDF Viewer normal output
What went wrong? (add screenshot)
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

PDF.js version: 3.4.120

That version is no longer supported, please find the latest releases at https://mozilla.github.io/pdf.js/getting_started/#download

Steps to reproduce the problem:

Please see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.


SpecASFIS-SpecWoRMs mistake in relation

I noticed I made a mistake when linking an ASFIS code to the corresponding AphiaID.
The code is SQU, description: Loliginidae, Ommastrephidae.
Right now the code is linked to the aphiaID for Loliginidae only.
There are separate ASFIS codes for the two families respectively, so we should remove this link.

Maria to remove the wrong link and ask for resubmissions if it has been used in RDBES


Bump mdbook-i18n-helpers version to 0.3.4

Hotfix release to include changes from https://github.com/google/mdbook-i18n-helpers/pull/203

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.51%. Comparing base (035c4a1) to head (b5a52b6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   89.51%   89.51%
=======================================
  Files          13       13
  Lines        3138     3138
  Branches     3138     3138
=======================================
  Hits         2809     2809
  Misses        236      236
  Partials       93       93

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Visualization

Add visualization
Fixed bug of compute_recip_vector

Codecov Report

Merging #41 (00ab195) into dev (d655426) will increase coverage by 24.67%.
The diff coverage is 64.92%.

@@             Coverage Diff             @@
##              dev      #41       +/-   ##
===========================================
+ Coverage   43.32%   68.00%   +24.67%
===========================================
  Files          20       13        -7
  Lines        1198     1075      -123
===========================================
+ Hits          519      731      +212
+ Misses        679      344      -335

Impacted Files
Coverage Δ

src/symmetry/symmetry.jl
7.46% <ø> (+0.51%)
:arrow_up:

src/utilities/coordinatesystems.jl
13.90% <13.90%> (ø)

src/BaseMesh.jl
85.53% <84.84%> (+0.45%)
:arrow_up:

src/Model.jl
90.90% <86.95%> (+43.18%)
:arrow_up:

src/MeshMaps.jl
76.19% <88.23%> (+4.45%)
:arrow_up:

src/PolarMeshes.jl
94.82% <94.82%> (+94.82%)
:arrow_up:

src/BZMeshes.jl
95.06% <96.10%> (+25.06%)
:arrow_up:

src/AbstractMeshes.jl
61.53% <100.00%> (+11.53%)
:arrow_up:

src/symmetry/PointSymmetry.jl
93.75% <100.00%> (+93.75%)
:arrow_up:

src/symmetry/spglib.jl
74.07% <0.00%> (-2.47%)
:arrow_down:

... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


URLs in ReadTheDocs are case-sensitive

If case-sensitivity is not observed when entering the URL during the setup of your RTD project, then the project will appear to work correctly, however automatic updates on GitHub changes will not work correctly.

The issue above wasn't addressed, it should be patched.

I fixed it post-merge

Thanks @jbrinkman :)


'JsonNumberHandlingAttribute' is only valid on a number or a collection of numbers when applied to a property or field.

Describe the bug
'JsonNumberHandlingAttribute' is only valid on a number or a collection of numbers when applied to a property or field.
To Reproduce
Steps to reproduce the behavior:
1.QdrantVectorDbClient.cs Line-132
public async Task<QdrantVectorRecord?> GetVectorByPayloadIdAsync(...)
{
       ...
       // Line-132
       var data = JsonSerializer.Deserialize<SearchVectorsResponse>(responseContent);
       ...
}

Expected behavior
'JsonNumberHandlingAttribute' is only valid on a number or a collection of numbers when applied to a property or field. See member 'Id' on type 'Microsoft.SemanticKernel.Connectors.Memory.Qdrant.Http.ApiSchema.SearchVectorsResponse+ScoredPoint'.
Screenshots
If applicable, add screenshots to help explain your problem.

Sorry about this, we brought in a PR last week that was supposed to allow both numbers and strings for that property (Qdrant allows this) and it appears to have caused a regression.
To unblock yourself, you can remove the JsonNumberHandling attribute from ScoredPoint:

We will take another pass at fixing this!

@futugyou Are you writing a GUID for your Scored Point ID?
Qdrant only allows a valid GUID or an int.

@tawalke putting a Guid as id, the error doesn't occurs:
var id1 = Guid.NewGuid().ToString();
var key1 = await kernel.Memory.SaveInformationAsync(MemoryCollectionName, id: id1, text: "british short hair");

@futugyou Are you writing a GUID for your Scored Point ID?
Qdrant only allows a valid GUID as string or an int. Would you mind sharing an example of your Vector record?
Cc. @craigomatic

If Qdrant only allows a valid GUID or an int isn't there a problem with saving references?
in MemoryRecord.ReferenceRecord(...):
new MemoryRecordMetadata             (                 isReference: true,                 externalSourceName: sourceName,                 id: externalId,                 description: description ?? string.Empty,                 text: string.Empty,                 additionalMetadata: additionalMetadata ?? string.Empty             ),
"id: externalId"

PR #1313 was merged and should have resolved this, if you have a moment to verify that would be appreciated

This issue seems to still be occurring in "0.15.230531.5-preview". I've just updated to the latest release & with no other code changes, have just run into this issue.
Id was previously set using strings in our vector db.
IE:
We're looping though a JSON list of QnA items and saving them into a collection.
The filename in our case, is named to represent the team / process the QnA list targets.
await _memory.SaveInformationAsync("QnACollection", qnaItem, $"{file.Name}-q{i}");
Not sure if we need to change anything here, but my understanding of QDrant is that a string value or an int should be accepted.

You may need to use a guid for the id see https://github.com/microsoft/semantic-kernel/issues/794#issuecomment-1533797386
The next step in improving qdrant support is to add guid validation when a string is used as the id

The id in "SaveInformationAsync" is not used as the id in Qdrant. See in QdrantMemoryStore:
var existingRecord = await this._qdrantClient.GetVectorByPayloadIdAsync(
                    collectionName,
                    record.Metadata.Id,
                    cancellationToken: cancellationToken)
                .ConfigureAwait(false);

if (existingRecord != null)
{
    pointId = existingRecord.PointId;
}

where "record.Metadata.Id" is the id from SaveInformationAsync if i did not miss something.

You may need to use a guid for the id see #794 (comment)
The next step in improving qdrant support is to add guid validation when a string is used as the id

Ok, so fortunately I'm in a position I can clear the vector DB and rebuild the data stored.
However, the following code is still throwing this error in the latest nuget package.
var id = Guid.NewGuid().ToString();
await _memory.SaveInformationAsync("QnACollection", qnaItem, id, description: $"{file.Name}-q{i}");

Looks like the

ed and should have resolved this, if you have a moment to verify that would be appre

@craigomatic, The copilot chat app sample  is giving the same error. The project is using SK version 0.15.230531.5-preview. Please share if there is a work around for the copilot chat app sample to make with work with Qdrant.
Stack trace:

     at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
     at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
     at System.Text.Json.JsonSerializer.ReadFromSpan[TValue](ReadOnlySpan`1 utf8Json, JsonTypeInfo jsonTypeInfo, Nullable`1 actualByteCount)
     at System.Text.Json.JsonSerializer.ReadFromSpan[TValue](ReadOnlySpan`1 json, JsonTypeInfo jsonTypeInfo)
     at Microsoft.SemanticKernel.Connectors.Memory.Qdrant.QdrantVectorDbClient.GetVectorByPayloadIdAsync(String collectionName, String metadataId, Boolean withVector, CancellationToken cancellationToken)
     at Microsoft.SemanticKernel.Connectors.Memory.Qdrant.QdrantMemoryStore.ConvertFromMemoryRecordAsync(String collectionName, MemoryRecord record, CancellationToken cancellationToken)
     at Microsoft.SemanticKernel.Connectors.Memory.Qdrant.QdrantMemoryStore.UpsertAsync(String collectionName, MemoryRecord record, CancellationToken cancellationToken)
     at Microsoft.SemanticKernel.Memory.SemanticTextMemory.SaveInformationAsync(String collection, String text, String id, String description, String additionalMetadata, CancellationToken cancellationToken)
     at SemanticKernel.Service.CopilotChat.Controllers.DocumentImportController.ParseDocumentContentToMemoryAsync(IKernel kernel, String content, DocumentImportForm documentImportForm, String memorySourceId) in /workspaces/semantic-kernel/samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/DocumentImportController.cs:line 213
     at SemanticKernel.Service.CopilotChat.Controllers.DocumentImportController.ImportDocumentAsync(IKernel kernel, DocumentImportForm documentImportForm) in /workspaces/semantic-kernel/samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/DocumentImportController.cs:line 128
     at SemanticKernel.Service.CopilotChat.Controllers.DocumentImportController.ImportDocumentAsync(IKernel kernel, DocumentImportForm documentImportForm) in /workspaces/semantic-kernel/samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/DocumentImportController.cs:line 133

Try updating to the latest nuget that was just released: https://www.nuget.org/packages/Microsoft.SemanticKernel/0.15.230609.2-preview

Try updating to the latest nuget that was just released: https://www.nuget.org/packages/Microsoft.SemanticKernel/0.15.230609.2-preview

Worked! Thank you.


Errors in running SelectiveSearchCode

Thanks for your excellent work.
I want to test the model on a new image and I encounter an error when running the demo in SelectiveSearchCode.

Hi, I'm sorry, but I haven't run this code or MATLAB in general for ages, so can't really help you


Harden connector code

use common logger
error checking and recovery

Add informational AMA thread statistics.

Delivered in https://github.com/ibm-cds-labs/simple-data-pipe-connector-reddit-all-messages. This connector is no longer enhanced.


Bug: Oauth sessions need to be cleared

Many of us are having issues with OAuth. The login screen returns various errors.
These errors can temporarily be fixed by removing your row in the user and session tables and deleting your cookies in the browser.
We believe this is due to next auth failing to renew old sessions.

Issue Caused by Next-Auth version bump. Older versions used this in the Account database

Next-Auth does not allow 2 providers of the same email address. Next-Auth updated provider from google.com to google. The image above breaks oAuth.

This is the current version of the Google Auth in next-auth: https://github.com/nextauthjs/next-auth/blob/e67a1eb961f232eb55a8ef7cf6be783b97bd4187/packages/next-auth/src/providers/google.ts
Seed data should be updated to match


Changed README.md word: build.js outputs to build dir, not dist

I'm proposing this change based off of my experience of following these steps.
$ node build.js
Starting builds...

Building Twine 1.x version:
 -> assembling libraries...
 -> compiling JavaScript...
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme
 -> compiling CSS...
 -> building: "build\twine1\sugarcube-2\header.html"
 -> copying : "build\twine1\sugarcube-2\sugarcube-2.py"
 -> copying : "build\twine1\sugarcube-2\LICENSE"

Building Twine 2.x version:
 -> assembling libraries...
 -> compiling JavaScript...
 -> compiling CSS...
 -> building: "build\twine2\sugarcube-2\format.js"
 -> copying : "build\twine2\sugarcube-2\icon.svg"
 -> copying : "build\twine2\sugarcube-2\LICENSE"

Builds complete!  (check the "build" directory)

Running the script ends with this output:

(check the "build" directory)

I feel like there might be a step to output into the dist dir, but it's not node build.js.

PRs should be to the devel branch only, never to master.


Test key removal in key store v2

There were a couple of tests left out in #361. Those tests verified that Acra works as expected for unknown keys which was simulated by removing keys from the key store. Key store v1 has it easy as key files can be directly removed from the filesystem. Key store v2 is (way) more complex so you cannot just remove a key ring file. (Well, actually, you can right now because the key directory integrity is not verified, but this will not be the case in the future.) However, key store v2 also has a concept of a destroyed key – a 'zombie' key with only metadata remaining, but with no actual key material retained. We make use of it.
This patch set starts by updating the tests to decouple them from direct key store access. Instead, new utility function destroy_key() should be used to destroy keys. For key store v1 it will remove key files as before, but for key store v2 it will use new API for key removal.
acra-read-key tool is renamed into more generic acra-key-tool so that it can handle both reading key data and destroying keys, as well as exporting and importing them in the future. We may consider teaching it to generate keys as well.
There's some new key store API that handles key destruction. Note that it's different from removal: it is possible to see that a key had existed but has been destroyed, with no way to access its data anymore. However, key store v1 does not differentiate between destruction and removal as many places are unable to properly handle existing but empty key files.
Finally, we compose all of this together to support key removal for both v1 and v2. Then we are able to reenable the removal tests for v2.

Shouldn't we also add this utility to acra-tools, to include it into rpm/deb packages?

It's highly likely, given that it does not seem to remain a test-only tool. Acra CE does not have acra-tools packaging at the moment (until #372 is merged), but this is something that we need to keep in mind. I'll take care of it after the next sync with master.

There are some unresolved naming issues with the key tool, but I'm going to merge this PR as is to unblock the tests. There will be a separate PR that updates the name and the interface of the tool, makes it available in packages, etc.


Browser / cache issues resulting in links not working for a period of time

We seem to have an ongoing problem with the links and admin area not being available, usually after some activity in admin area (e.g. adding new links) or sometimes after testing our own short links.
After a period of time (usually an hour+), the admin area and links work again.  However, the admin area and links always work when we test from another PC.  So its not a server down issue - it appears to be browser / cache related.  I'm concerned that users of the links will have similar user experiences,
Has anyone experienced similar &/or is there something we're missing or doing wrong?
Thank you.

Never heard about something similar. It must be indeed related to your caching policy, that superseeds YOURLS admin pages cache. Maybe a plugin with more aggressive non caching header directives would help? Although, to be honest, I don't know how to be more explicit about not caching than we are at the moment...

Hi Ozh,
Thanks for your reply.
Do you consider an htaccess that keeps no cache on the server enough or will the YOURLS bypass it? What plugin/modification to the server setting do you recommend?

Not sure which will have precedence between .htaccess directive and PHP header... Anyway YOURLS will not bypass a .htaccess that prevents cache, since YOURLS itself is supposed to prevent cache, see my comment above
No idea on the server setting you should modify though... sorry. Feel free to comment on when you fix the problem!

Update:  Thanks Ozh.  The issue was solved by changing the service provider that runs the DNS.


Test whether jinja v2.11-generated templates run on jinja v2.10

This may be a problem with wheels since the precompiled templates may be generated with a different version of jinja as the end user.

Apparently not.  So treat pre-compiled templates as version-specific to jinja.
Also, pip install appears to build wheels in a separate environment, so the jinja used to build them may also differ from the jinja version used at runtime--even when building from the sdist.
Verdict: Don't distribute wheels.

Also, pip install appears to build wheels in a separate environment, so the jinja used to build them may also differ from the jinja version used at runtime--even when building from the sdist.

The --no-build-isolation flag should work.  I think this method should only really be for more advanced installation requirements.  When building from scratch, the builder and installing-python should install the same version of jinja2.  Virtual environments should make this painless since it will all be built from scratch anyway.
This needs to be documented somewhere.

Verdict: Don't distribute wheels.

Yep.  Just the sdist, but allow wheels to be built locally in order for faster runtime execution.  I believe installing from an sdist or an editable-install, results in a pkg_resources import, which is slow.

Documented in 06fdcdbbe8be2c2d0c6bd80bf767a1d8f702b67e.


Travis broken with OpenBLAS

It seems that OpenBLAS is not available on conda-forge, resulting in travis failure.

We should require blas * openblas instead.


Fix kubeone setup on Hetzner

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes Control-Plane setup issue.
Sometimes the following issue ocure:
[<IP_ADDRESS>] Reading package lists...
[<IP_ADDRESS>] E: Could not get lock /var/lib/apt/lists/lock. It is held by process 1125 (apt-get)
[<IP_ADDRESS>] E: Unable to lock directory /var/lib/apt/lists/
time="11:16:15 UTC" level=error msg="ssh: installing kubeadm\nssh: popen\nProcess exited with status 100"

This happen because any apt-get update process is still running in the background and the process is frozen. Even during a retry the apt-get update process is on hold.
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

Hey @ThWoywod, thank you for your submission. I'll let others voice their opinion on this but I find this change a bit scary - how can we make sure this is a "frozen" apt process we're killing and not a legitimate one? What does "frozen" even mean in the first place? apt puts these locks in place because messing with packages while apt is working can be highly destructive.
I think it would be more suited to figure out why apt processes freeze for you instead of this workaround, but again, that's a personal opinion and not necessarily that of other KubeOne folks.

Sometimes unattended-upgrades gets too fast & furious, and run in your way. I'm also against killing apt in general. That problem should not be solved at kubeone level.

Hey @embik,
thank you for your feedback. I totaly agree with you that this is quite a hacky way around.
I invest some time to figure out why this only sometime happen but did not really get it.
For me it is not really clear why there should be an update process running in the background. But the fact is that it does. My guess is that this happens when an installation error occurs and the retry is executed. The retry does not make sure that the processes are really terminated before it will start.
Maybe there is also the right point to make sure that the update process has been terminated.
I am open for any feedback and would like to adjust the code to fit better to the kubeoen way.

@kron4eg you mean this is an issue with the default Hetzner unattended-upgrades configuration?
I mean the only unattended-upgrades stuff that is configured during the kubeone installation process is the Kubernetes DeamonSet and the setup of this Kubernetes Ressources should be done after the setup of the controle-plane nodes.

Yeah, hetzner integrated unattended-upgrades in the base ubuntu image and sometimes it kicks in right after the VM boot (and before kubeone).

@kron4eg How about we stop the process of unattended-upgrades before the kubernetes installation steps are executed?

@ThWoywod well, this can be done in a custom OSP. See more at https://docs.kubermatic.com/operatingsystemmanager/guides/customize-operating-system-profile/

@ThWoywod Is it an option for you to provide cloud-init script to disable or reconfigure unattended-upgrades? You can do that using Terraform as well.

Yeah i gess the OSP are not really the way to go because its an issue with the controle plane nodes not the machine deployment nodes.
Well yes @xmudrii this is a good suggestion. I will experiment with it a bit but at the end the kubeone code need to have an change. Disableing unattended-upgrades in generall does not sound practicable for me.
I will get back as soon as I have found a solution to the problem.


SequentialExecutor

Is it deliberate that the entrypoint.sh doesn't start the scheduler for SequentialExecutor?

Looks like the config/airflow.cfg references the CeleryExecutor instead of the SequentialExecutor like the README describes.
executor = CeleryExecutor

Any ideas on how to fix this?

Fixed in 1.9.0-3


⚠ PrivateHD has degraded performance

In cdfffdc, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2158 ms

Resolved: PrivateHD performance has improved in db4da85.


Changes to network stack to facilitate iface-agnostic application code

Introduction / Request For Comments
This proposal/issue proposes a set of changes to the Zephyr networking stack that would enable developers to write application code that is maximally iface/L2-agnostic. These changes could significantly reduce boilerplate overhead for Zephyr end-users writing connected applications even when only a single iface is used.
I plan to present and discuss this proposal at the upcoming Zephyr Networking Summit on December 6th. It is my hope that this issue serves as a place to discuss and adjust the proposal both leading up to that event and following it. Feedback and comments from the Zephyr network maintainers would be deeply appreciated!
Contributors:

@maxd-nordic
@wbober
@rlubos
@mgolu

Problem description
Currently, applications that require multiple ifaces or L2-stacks must be aware of and manage each iface individually. Furthermore, Zephyr offers no standardized interface to configure or initiate a second association stage on ifaces that require it (for instance, Wi-Fi). Instead, applications must call iface-specific net_mgmt APIs to initiate and configure association.
Many applications only need direct knowledge of or control over whether L4 connectivity is established. Direct management of L2-stacks and ifaces is beyond the scope of such applications, and yet, is currently required by Zephyr's network APIs. Zephyr does currently provide conn_mgr, which alerts applications to changes in L4 connectivity across all ifaces simultaneously, but no similarly high-level mechanism exists to control connectivity.
All of this introduces a significant amount of connection-related overhead to applications that might otherwise be avoided if higher-level control APIs were provided. Even applications that require only a single iface might benefit from not needing to deal with the internal specifics of that iface's connection process.
Proposed solution

Expand the already-existing conn_mgr module to serve as a simple multi-casting controller for all ifaces
Introduce a number of new functions to the net_if API struct to facilitate generic association/connection on ifaces that need it (such as Wi-Fi). Namely:

net_if_connect

Including standardized timeout and persistence options

net_if_disconnect
net_if_set_opt
net_if_get_opt

The addition of active association/connection as a necessary condition for entering the operational-up state on ifaces that require association/connection.
The introduction of a new network interface flag to control whether net_if_connect is called automatically when entering the admin-up state: NET_IF_NO_AUTO_CONNECT

Background
This issue/proposal is heavily based on some recent changes to the Zephyr networking stack, namely the introduction of the operational/admin state separation. See the following resources if you are not already familiar with this change.

net: if: Improve interface status reporting
net: if: Introduce carrier and dormant management on a network iface
net: if: extend list of admin/operational states of network interface
Kernel subsystem documentation » Networking » Operational States
RFC2863

Scope / Requirements
Applications require iface-agnostic tools to perform the following tasks:

L2 connectivity establishment (with timeout)

Allow for establishing persistent connectivity mostly without application involvement, and in a manner that is L2-stack-agnostic from the application's perspective.
Include the capacity to specify a timeout for connection attempts.

Control over L2 connectivity persistence

L2 stacks that support persistent(fault-tolerant and self-reconnecting) connectivity should offer the option to disable this persistence

L4 readiness monitoring by application

Allow for monitoring the status of IP connectivity as a whole.

L2 irrecoverable error notification

Applications should be informed if an unrecoverable error is preventing one or more L2 stacks from connecting.

Anything beyond these needs or their implementation is considered beyond the scope of this proposal.
Proposed Changes (Detailed)
Changes to conn_mgr:
Added net_mgmt requests:

NET_REQUEST_ALL_IF_UP:

Calls net_if_up() on all available network interfaces

NET_REQUEST_ALL_IF_DOWN:

Calls net_if_down() on all available network interfaces

NET_REQUEST_ALL_IF_CONNECT:

Calls NET_REQUEST_ALL_IF_UP, then calls (the herein proposed) net_if_connect() on all available network interfaces

NET_REQUEST_ALL_IF_DISCONNECT:

Calls (the herein proposed) net_if_disconnect() on all available network interfaces

Cleanup of disconnected ifaces
conn_mgr should listen for the (herein proposed) NET_EVENT_IF_CONNECTIVITY_TIMEOUT, and call net_if_down() on the timed-out iface. This should also be called on ifaces that become dormant (no longer operational-up) and that do not have persistence enabled.
This behavior should be optional, controlled by the KConfig option CONFIG_CONN_MGR_AUTO_IF_DOWN
Changes to net_if:
We propose the addition of two new generic API functions to the net_if API: net_if_connect() and net_if_disconnect(), as well as the addition of a new network interface flag, NET_IF_NO_AUTO_CONNECT, and two new options customization API functions, net_if_set_opt and net_if_get_opt()
int net_if_connect(struct net_if *iface):

Causes the iface to attempt to connect/associate its L2 stack using the parameters configured with the (herein-proposed) net_if_set_opt function if provided.

Connection parameters (such as chosen network and connection credentials) are deliberately configured this way, rather than provided directly to net_if_connect, since providing them directly would prevent multi-casted calls to it via conn_mgr

If NET_IF_OPT_CONNECTIVITY_TIMEOUT is set using the net_if_set_opt  function, a connection timeout will be set for the specified amount of time.

After this time elapses, the iface L2 should give up, even if persistence (NET_IF_OPT_CONNECTIVITY_PERSISTENT) is enabled.
This value also applies for subsequent automatic re-connections when in persistent mode.
If a connection attempt times out, the (herein-proposed) NET_EVENT_IF_CONNECTIVITY_TIMEOUT event should be fired.

The connection established will be persistent depending on whether NET_IF_OPT_CONNECTIVITY_PERSISTENT was set using net_if_set_opt()

If persistent, the iface will try to re-establish connection if connectivity is lost after the first net_if_connect() call, assuming this is supported by the iface.

Integrations for L2-stacks that are inherently (always) persistent must be able to simulate non-persistence by cancelling connectivity on first connection loss or timeout.
Need not be implemented on ifaces that do not have an association/connect phase
Returns 0 on success, otherwise negative error code indicating failure reason

int net_if_disconnect(struct net_if *iface):

Causes the L2 stack to disconnect / stop seeking L4 connectivity, without taking the network interface down.
This will result in the iface entering the dormant state indicated by net_if_is_dormant() == true
Need not be implemented on ifaces that do not have an association/connect phase
Returns 0 on success, otherwise negative error code indicating failure reason

int net_if_set_opt(struct net_if *iface, int optname, const void *optval, size_t optlen) and
int net_if_get_opt(struct net_if *iface, int optname, const void *optval, size_t *optlen):

These are a generic options-setting API identical in structure to the BSD socket setsockopt / getsockopt API functions.
They allow the pre-configuring of both generic and L2-specific connection parameters before a call to net_if_connect()

Generic options:

NET_IF_OPT_CONNECTIVITY_PERSISTENT  - controls whether the iface should connect persistently
NET_IF_OPT_CONNECTIVITY_TIMEOUT  - used to specify a timeout when attempting to connect

Examples of L2-specific connection parameters include chosen network and connection credentials.

Self-configuring or non-configurable interfaces may not need L2-specific connection parameters

Provided to offer applications and libraries a means to handle connection configuration without interfering with conn_mgr.
Both return 0 on success, otherwise negative error code indicating failure reason

NET_IF_NO_AUTO_CONNECT

Defaults to disabled
If disabled, when an iface enters the admin-up state (in other words, net_if_up() is called), the iface will automatically try to establish connectivity.
If enabled, net_if_connect() must be explicitly called on the iface for it to begin connecting/associating.

Added net_mgmt events:

NET_EVENT_IF_CONNECTIVITY_FATAL_ERROR

Should be raised by L2-stack integrations when a non-recoverable error preventing connectivity occurs.
Info value should be an integer, the meaning of which is up to the specific L2-integration.

NET_EVENT_IF_CONNECTIVITY_TIMEOUT

Should be raised (with no info) by L2-stack integrations if the timeout specified by NET_EVENT_IF_CONNECTIVITY_TIMEOUT expires during a connection attempt.

Usage
NET_IF_NO_AUTO_START and NET_IF_NO_AUTO_CONNECT disabled:
In other words, auto-start + auto-connect.

NET_IF_NO_AUTO_START disabled and NET_IF_NO_AUTO_CONNECT enabled:
In other words, auto-start without auto-connect.

NET_IF_NO_AUTO_START and NET_IF_NO_AUTO_CONNECT enabled:
In other words, neither auto-start nor auto-connect.

NET_IF_NO_AUTO_START enabled and NET_IF_NO_AUTO_CONNECT disabled:
In other words, auto-connect without auto-start.
In this configuration the Application can either call NET_REQUEST_ALL_IF_CONNECT, or NET_REQUEST_ALL_IF_UP, and the result will be the same, but the sequence diagrams will be different.
The behavior if NET_REQUEST_ALL_IF_CONNECT is called is already demonstrated in the previous sequence diagrams, so we will only show the NET_REQUEST_ALL_IF_UP case.

Alternatives / Existing Solutions
To our knowledge, there are not any existing solutions in Zephyr that solve this problem.
Alternative potential solutions include:

Implementing agnostic connectivity as a disjoint library rather than as a direct feature of the Zephyr network stack. Without additions to the net_if API, such a library would require specific knowledge of each iface it supports, and therefore could not support all ifaces generically.
(downstream-only / for Nordic use only): Provide wrappers for network interfaces that map their events and controls into the Common Application Framework, and use this as an iface-agnostic control layer. Once again, generic control of ifaces would be impossible, and such a solution would be limited to only a small set of supported ifaces.

LGTM

int net_if_connect(struct net_if *iface):
* Need not be implemented on ifaces that do not have an association/connect phase

So I suppose for example for Ethernet, this function would return 0 (success) immediately if the cable is connected. What would be returned if cable is not connected, -ENETDOWN perhaps?
Or do you mean that this function could return -ENOTSUPP or similar for some L2 technologies?

Changes to conn_mgr:
Added net_mgmt requests:
* `NET_REQUEST_ALL_IF_UP`:

  * Calls `net_if_up()` on all available network interfaces

* `NET_REQUEST_ALL_IF_DOWN`:

  * Calls `net_if_down()` on all available network interfaces

* `NET_REQUEST_ALL_IF_CONNECT`:

  * Calls `NET_REQUEST_ALL_IF_UP`, then calls (the herein proposed) `net_if_connect()` on all available network interfaces

* `NET_REQUEST_ALL_IF_DISCONNECT`:

  * Calls (the herein proposed) `net_if_disconnect()` on all available network interfaces

Hmm, just pondering here what will the API look like because there is the iface parameter in the net_mgmt API  but these _ALL_ variant flags indicate that the operation is for all the interfaces.
Anyway, looking forward to review the PR.

Maybe it would make sense for these to not be NET_MGMT requests at all, and just direct API calls?

I was actually pondering the same thing. A separate API call could go through all the network interfaces and call net_mgmt() with suitable parameters. So instead of ALL variant of the net_mgmt request, you could have a request that is set to just one interface.

Oh... every single force push is creating a reference 🤦

As discussed at the aforementioned Zephyr Networking Forum (workgroup?) meeting, I've written an implementation of this proposal here:
https://github.com/zephyrproject-rtos/zephyr/pull/53118
This should hopefully make discussing this proposal much less abstract!
Note that this implementation differs in some ways from the PR! I will write some form of update soon with the details of what is different.


Helm upgrade failed: yaml: unmarshal errors:   line 24: mapping key "app" already defined at line 23                                 48m

Describe the bug
Most of my helmrelease are failing to upgrade after i moved to flux v2
To Reproduce
Steps to reproduce the behaviour:

Install flux v2 using terraform 0.15.3 version
Getting below error with kustomize
Helm upgrade failed: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:
line 24: mapping key "app" already defined at line 23

Kubernetes version: 1.20

Below please provide the output of the following commands:
flux version 0.15.2
flux check

► checking prerequisites
✗ flux 0.15.2 <0.15.3 (new version is available, please upgrade)
✗ kubectl version v1.16.2 < >=1.18.0-0
✔ Kubernetes 1.20.4-eks-6b7464 >=1.16.0-0
► checking controllers
✔ helm-controller: deployment ready
► ghcr.io/fluxcd/helm-controller:v0.11.1
✔ kustomize-controller: deployment ready
► ghcr.io/fluxcd/kustomize-controller:v0.13.0
✔ notification-controller: deployment ready
► ghcr.io/fluxcd/notification-controller:v0.15.0
✔ source-controller: deployment ready
► ghcr.io/fluxcd/source-controller:v0.15.2

example helmrelease file:

---
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: my-app
  namespace: services
  annotations:
    fluxcd.io/automated: "false"
spec:
  interval: 5m
  releaseName: my-app
  chart:
    spec:
      chart: charts/my-app
      sourceRef:
        kind: GitRepository
        name: app-deployments
  rollback:
    timeout: 10m
    disableWait: false
  upgrade:
    timeout: 10m
    disableWait: false
  values:
    global:
      app: 'my-app'
    labels:
      app: 'my-app'
      environment: 'platform'
      tier: 'frontend'
      version: 'v1'

Duplicate of: fluxcd/flux2#1522

Do we have a estimate when this will be fixed or some kind of cleaner workaround

@rajivchirania the only fix it to remove duplicate keys from your chart.


Search food, but download many menu images

I attempted to download pizza images and used codes:
downloader.download("pizza", limit=100, output_dir="photos", adult_filter_off=True, force_replace=False, timeout=5)
However, the downloader gave me many menu images from zmenu.com.

This library works by finding the first 'limit' results on bing image search, then downloading them from their source. When you search for 'pizza', the results will contain menu's so it is only normal for the downloader to download them.

This may not be a long term solution but rollback to older version fixes this issue https://github.com/gurugaurav/bing_image_downloader/issues/19#issuecomment-952963064


Render lilypond03d

This PR renders 03d-Rhythm-DottedDurations-Factors.xml. It also adds a special case for rendering <multiple-rest> with a value of 1 by rendering a semibreve (whole) rest symbol.
Divergences

I speculate that GuitarPro 7 is inferring the rest representation from the note duration and divisions (more likely) OR using the multiple rest in combination with the time signature (less likely). It seems like there's a bug since it doesn't get the durations exactly to fill up the entire measure.
vexml ignores the duration specifications and just shows a semibreve rest symbol for simplicity. I'm not sure what the exact implications of this are, since each would be 1 symbol. This might be an issue when creating an editor.
osmd doesn't fork a special case when <multiple-rest> is 1.
lilypond and MuseScore 4 both seem to render a breve rest symbol for measure 16. This is due to a conflict in the MusicXML. For measure 16, the <multiple-rest> value is 1, meaning it's just one measure being indicated as a rest. But the <duration> value 62 is equal to two full measures of silence in the given time signature. I decided that the <multiple-rest> takes precedence in vexml.

vexml

lilypond

osmd

MuseScore 4

GuitarPro 7

I forgot to push my changes.


Upgrade aws provider version to latest

Contact Details (optional)
No response
Summary
Please consider updating the aws provider version.
Motivation
To use latest aws provider version
Alternatives
No response
Additional Context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

👍 - I believe this module cannot be used in with terraform that manages EKS clusters on Kubernetes 1.23 and above.  Specifically, terraform-aws-eks requires hashicorp/aws >= 4.0.0 and this module requires hashicorp/aws < 4.0.0

@Looks like an Pull Request exists for removing the < 4.0.0 restriction.  https://github.com/DNXLabs/terraform-aws-eks-external-secrets/pull/11
@adenot @mvsnogueira-dnx Is there a reason that can't be merged?

Hey @mkochco, no locks to have it approved! I have done it. Thanks for pointing that out.
Approved:
https://github.com/DNXLabs/terraform-aws-eks-external-secrets/pull/11
New version:
https://github.com/DNXLabs/terraform-aws-eks-external-secrets/releases/tag/2.1.0
I will then close the issue.


Dosage/data splits

Hi, your work is so great and thanks for your sharing!
I have a question about the Dosage/datas_simulation/get_split_indices fucntion (Line 107~117). The rest_indices should be split into train_indices and val_indices, but the values in train_indices and val_indices are limited to the range of [0, len(rest_indices)], other than the values in rest_indices. In that case, the train_indices and val_indices don't overlap, but they are overlapped with test_indices.
If there is anything wrong with my understanding, please point out. Thanks!

Does it mean the val_indices are overlapped with test_indices and the train_indices are overlapped with test_indices ?

I have also found this issue. I agree that val_indices are overlapped with test_indices and the train_indices are overlapped with test_indices.


Some fix on spanish language and a try to fix default language for all locales on a language

The first translation for spanish had a lot of mistakes i fixed and i tried to fix the locale on all variants of a language, also add a translation for manga statuses, if you dont want  it only take the spanish fixes please

I noticed you moved the Spanish translation from es-rES to es, I originally moved to es-rES package to follow the i18n standard as stated in #230 so I wanted to know if there was a particular reason to that move (I'm not very expert in localization problems)

the problem it's that in some languages (like spanish) the localization is almost the same for al cultural and regional variants and the diferences are in the speaking i noticed that android manages the localization with two parameters: the first is the language (es) and the second is the region (what originally was ES what means spain, so when you put the "system default language" in app it only will change to es_ES when the device language is on it too, discarding all other variants of the language even if it's perfectly readable. so i changed to a more international locale "es" without region to cover all the devices in differents spanish spoken countries (i don't know a lot about the standards but android generates the international string automatically as "es" and it makes sense for me : )


The ability to modify default args used by makers without redefinition.

Is there a way to append (or replace) custom args to the makers without needing to completely redefine it?
For example with syntastic it could be accomplished with let g:syntastic_cpp_compiler_options = '-std=c++14'.

I've had some luck with
let g:neomake_python_pylint_args = neomake#makers#ft#python#pylint()['args'] + ["-d", "missing-docstring,invalid-name"]

Where the array is the arguments you're adding.

Appending to the end of the array is a possible solution, I'm not sure if that's the best interface but we'll see sooner or later I suppose.
Thanks for the suggestion

Actually you aren't appending to the end of the array. You are creating a new array with neomake#makers#ft#python#pylint()['args'] as a starting point. You could also do:
" Create a list with your custom args at the beginning
let g:neomake_python_pylint_args = ["-d", "missing-docstring,invalid-name"] + neomake#makers#ft#python#pylint()['args']
" Totally override the default args with a list of your own
let g:neomake_python_pylint_args = ["-d", "missing-docstring,invalid-name"]

neomake#makers#ft#python#pylint()['args'] no longer works for me... Unknown function... Got an alternate approach?

Sorry, I was wrong, I was using an old version of neomake apparently


Spotify user authorization step 1

This is the first PR to enable artist imports from Spotify. It contains roughly:

Authorization button on profile page
Redirection to a Spotify authorization page
A controller to accept the parameters send by Spotfiy

That's it, although it look quite much. Most of the changes come from moving the Endpoints class to the support module. One of the open issues is that currently on every click a new entity with state is created. This will be changed in a later PR when the parameters are really used and Spotify's tokens are present. Also some tests concerning the state are a bit weird as we cannot mock static methods at the moment. That will change when we manage to update Mockito to - at least - 3.4 (there's a card for that somewhere).

 Spotify Artist Import

@hedgehog1833
There are failing tests


Fix cron task skipping builds

Previously, it was possible for the cron task to skip all builds given the changed-file condition would always evaluate True.  Fix this by also requiring the matrix element's skip to also require running in a PR context.  Also add a comment warning future maintainers about the re-use of the skip's via the pbs_images YAML anchor/alias.
Fixes https://github.com/containers/podman/issues/22861
Also ref. https://github.com/containers/image/issues/2203#issuecomment-2142072150

Thanks!


Sample showing WLS running on AKS

Original work done by https://github.com/galiacheng based on other samples.
On branch edburns-msft-1801-wls-aks Fixes #1801
copied:     kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/README.md -> docs-source/content/samples/simple/azure-kubernetes-service/_index.md

- Move content over from samples area.

modified:   kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/README.md

- Point to document in docs.

renamed:    kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/screenshot-deploy-test-app.png -> docs-source/content/samples/simple/azure-kubernetes-service/screenshot-deploy-test-app.png
renamed:    kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/screenshot-logs.png -> docs-source/content/samples/simple/azure-kubernetes-service/screenshot-logs.png

- Move images over.

Thanks, @rosemarymarano .  We will address these in the scope of this PR.

Hello @galiacheng , while reviewing this with @m-reza-rahman , Reza requested the following change.
Reza found the use of heredoc to grant the cluster-admin role was inconsistent.  I realize this is handled automatically in the function installWebLogicOperator { and that's fine, but for the reader manually executing the steps in _index.md he felt it was jarring.  He wants the rbac grant YAML generated as one of the files output when the user runs this command.
./create-domain-on-aks.sh -i my-create-domain-on-aks-inputs.yaml -o ~/azure

Modify the script to output this yaml file.

Modify the _index.md in the following ways.

The output would look like
The following files were generated:
  /home/username/azure/weblogic-on-aks/pv.yaml
  /home/username/azure/weblogic-on-aks/pvc.yaml
  /home/username/azure/weblogic-on-aks/admin-lb.yaml
  /home/username/azure/weblogic-on-aks/cluster-lb.yaml
  /home/username/azure/weblogic-on-aks/domain1.yaml
  /home/username/azure/weblogic-on-aks/cluster-admin-role.yaml

Completed

Then, add a new paragraph at the very beginning of the Apply generated configuration files section directing the reader to apply that file.
Consider this text as a suggestion.

Kubernetes Operators use Helm to manage Kubernetes applications. You have to grant the Helm service account with the cluster-admin role with the following command.
kubectl apply -f ~/weblogic-on-aks/cluster-admin-role.yaml

You should see this output:
clusterrolebinding.rbac.authorization.k8s.io/helm-user-cluster-admin-role created

Then, you must delete the corresponding text in the Install WebLogic Operator section, starting with "Kubernetes Operators use" and ending with removing the output section.
Also delete the sentence "Install the WebLogic Server Operator." because it is now unnecessary.

Hello @m-reza-rahman, I changed the [operator documentation](/) to [operator documentation]({{< relref "/userguide/_index.md" >}}), I got the url from docs-source\content_index.md.

Closing this pull request to rework it.  Will open a new one.


Use ssl:connect/4 to open TLS connections

Change the TLS connect procedure to use ssl:connect/4 directly instead
of first connecting a TCP socket and then upgrading it to TLS.
Since we previously opened a TLS connection by first connecting a TCP socket
users needed to configure both tcp_connect_timeout and tls_connect_timeout
to get a timeout when using TLS, which was a bit confusing.
Therefor this commit adds the general connection option:

{connect_timeout, timeout()}

which replaces and deprecates the following options:

{tcp_connect_timeout, timeout()}
{tls_connect_timeout, timeout()}

Is there a reason to use ssl:connect/4 rather than first gen_tcp and then upgrade to ssl, other than simpler code?

I have seen the change https://github.com/Ericsson/ered/commit/99ab8a4defc1b21201a34888768dc89a7881b795 which indicates it was changed when the timeout was added, and using separate timeouts.


[#45] [Integrate] As a user, I can see the coin’s statistics on the Detail screen

Close #45

What happened 👀

Passing data from viewModel.coinDetail to CoinStatisticsSection.
Configure Equatable function of MockCoinDetail and MockMarketData.
Add new initializers for MockMarketData.

Insight 📝

We tested the correct value for coinDetail, and market cap, all time high, all time low values are coinDetail's properties, so we don't need to write tests for checking market cap, all time high, all time low.

                    it("gets the correct value for coinDetail") {
                        await expect { await myCoinViewModel.coinDetail }
                            .to(equal(expectedCoins))
                    }

Proof Of Work 📹
https://user-images.githubusercontent.com/25881847/211710974-0ef8d62b-4fd7-40b9-bcb3-4ac93284b622.mp4

@nkhanh44 Please help rebase on the latest develop so we can quickly look at what changes 🙏


Slow github actions due to Conda

Every time a new commit is made, the GitHub action runs the unit test with a brand new miniconda installation. This turns a series of tests that should take ~1 min into a several minute ordeal. We should cache miniconda and only re-install every N days (or if setup.py or requirements.txt is updated).
The caching is currently broken in the github action.

Caching has finally been set up. Setup-time will be further reduced once we no longer have to pip install ASE from the master branch.


[MWPW 133779] Project X GNav Update

Updated the feds experience for GA launch. When comparing the two links you will notice the differences between the two nav bars.
Resolves: MWPW-133779
Test URLs:

Before: https://stage--express--adobecom.hlx.page/express/create/banner
After: https://mwpw-133779--express--adobecom.hlx.page/express/create/banner?lighthouse=on

Codecov Report

:exclamation: No coverage uploaded for pull request base (stage@0c16c26). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             stage     #103   +/-   ##
========================================
  Coverage         ?   39.29%
========================================
  Files            ?        9
  Lines            ?     4986
  Branches         ?        0
========================================
  Hits             ?     1959
  Misses           ?     3027
  Partials         ?        0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[QUESTION] Does go2rtc support audio from AWS Kinesis streams?

I have an AWS Kinesis stream that I have access to, which I am pretty sure has audio, but I am not hearing any, and I want to make sure that I should be hearing audio from go2rtc when streaming an AWS Kinesis stream before I dig into it too much.

I don't have this streams for test. But I think it should support audio. You can check stream info for active stream for additional information.

Ok. Thank you. I'll check into this and see what I can find out.

OK. This is what I see there:
{
  "producers": [
    {
      "id": 4,
      "format_name": "webrtc/kinesis",
      "protocol": "ws+udp",
      "remote_addr": "<IP_ADDRESS>:51948 host",
      "url": "wss://REDACTED.kinesisvideo.us-west-2.amazonaws.com/REDACTED",
      "medias": [
        "video, recvonly, H264",
        "audio, recvonly, PCMU/8000"
      ],
      "receivers": [
        {
          "id": 5,
          "codec": {
            "codec_name": "h264",
            "codec_type": "video"
          },
          "childs": [6],
          "bytes": 2606011,
          "packets": 2328
        },
        {
          "id": 8,
          "codec": {
            "codec_name": "pcm_mulaw",
            "codec_type": "audio",
            "sample_rate": 8000
          },
          "childs": [9],
          "bytes": 84480,
          "packets": 176
        }
      ],
      "bytes_recv": 2740571
    }
  ],
  "consumers": [
    {
      "id": 2,
      "format_name": "webrtc",
      "protocol": "ws+udp+udp+udp+udp",
      "remote_addr": "REDACTED-IPV6-ADDRESS",
      "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36",
      "medias": [
        "video, sendonly, VP8, VP9, H264, AV1",
        "audio, sendonly, OPUS/48000/2, G722/8000, PCMU/8000, PCMA/8000, L16, PCML"
      ],
      "senders": [
        {
          "id": 6,
          "codec": {
            "codec_name": "h264",
            "codec_type": "video"
          },
          "parent": 5,
          "bytes": 2606011,
          "packets": 2328
        },
        {
          "id": 9,
          "codec": {
            "codec_name": "pcm_mulaw",
            "codec_type": "audio",
            "sample_rate": 8000
          },
          "parent": 8,
          "bytes": 84480,
          "packets": 176
        }
      ],
      "bytes_send": 2719009
    }
  ]
}

Audio codec exist in producer and consumer. Bytes not zero. I don't know why you don't hear sound.

It is working today, so it must have been a transient issue. Thank you for explaining things a bit.


Debugging Bookviewer

What tool(s) should we use to be able to debug bookviewer/Classes C++ files?

Android Studio has the capability to do it.

Android Studio can do it.

Closing this issue.
@pbehghader Were you able to debug the files?


Add exceptRevert cheatcode

Based on: https://github.com/software-mansion/protostar/pull/65

added exceptRevert cheatcode

injected testRunner to hints
exceptRevert is a test runner method

Marked this PR as draft again because exceptRevert doesn't work on the CI.


support coverage variable

Description
i think coverageVariable can make instanbul have more useful feature. so  i want can add coverageVariable to options
Suggested solution
add coverageVariable to options
Alternative
No response
Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

You can add a custom prefix via envPrefix. For example you can set envPrefix: 'CUSTOM_' to set the coverage variable to CUSTOM_COVERAGE whether coverage should be enabled or disabled.


Add support for std::fmt::Debug inside html macro expressions

Hello, first i really love this project, great work! I'm new to yew and i haven't come across a solution to this yet but if one already exists please let me know
Describe the feature you'd like
I would like to be able to choose whether to use use std::fmt::Display or std::fmt::Debug when rendering expressions in the html! macro.  For example take this code:
    html! {
{some_variable}
 }

Provided some_variable implements fmt::Display is will render as expected, i would like to be able to do something like this as well:
    html! {
{:? some_variable}
 }

Where it will be rendered using the debug trait instead.
Is your feature request related to a problem? Please describe. (Optional)
Not really a problem, my current solution is easy enough
    html!{
{ format!("{:?}", some_variable) }
 }

This just feels more verbose than it has to be, i would imagine this is a very common thing to use when developing components. If you would accept such a feature i would love to create a PR. Although I'm very new to the code base and could probably use some guidance/help implementing it.
Questionnaire

[x] I'm interested in implementing this myself but don't know where to start
[ ] I would like to add this feature
[ ] I don't have time to add this right now, but maybe later

I'm not sure about this one... This only sounds useful for debugging and personally, I've never felt the need for something like this (The console already covers most of my debugging needs).
Using format! doesn't feel that verbose to me and it has the benefit of being more explicit and obvious.
The new syntax also loses any potential advantage as soon as we're dealing with more than one variable:
html! {

{ "var a: " } {:? my_b }

{ "var b: " } {:? my_b }

}

Instead of just:

{ format!("var a: {:?}, var b: {:?}", my_a, my_b) }

These two examples obviously aren't equivalent but they achieve the same purpose when debugging. I'm only talking about using it for debugging here because I don't think the Debug trait should be used for anything else.
Maybe there's another use case I'm not aware of where this syntax would be useful?

Understood, I dont have much of a use for this aside from debugging so i think your right. thanks for your time!


twister: Improve recording at Harness

The Console Harness is able to parse its log with patterns to compose extracted fields into records in 'recording.csv' file in the test's build directory. This feature allows to extract custom test results like performance counters.
Now with this change the extracted records are also written into 'twister.json' as a part of each test case object. This makes easier to store all the data collected by the test for its further processing.
Other improvements:

compile parsing pattern only once instead of at each input line;
quote fields in '.csv' to avoid unexpected field separators;
make 'regex' a required schema field of 'harness_config';
Twister documentation update.

At the moment the recording feature is used by tests/benchmarks/latency_measure.
With this change the resulting twister.json has testcases with recording like:
    "testsuites":[
        {
            "name":"tests/benchmarks/latency_measure/benchmark.kernel.latency",
            ...
            "testcases":[
                {
                    "identifier":"benchmark.kernel.latency",
                    "execution_time":"2.44",
                    "status":"passed",
                    "recording":[
                        {
                            "metric":"Preemptive threads ctx switch via k_yield (K -> K)",
                            "cycles":"22207",
                            "nanoseconds":"22207"
                        },
                        {
                            "metric":"Cooperative threads ctx switch via k_yield (K -> K)",
                            "cycles":"22111",
                            "nanoseconds":"22111"
                        },
                        {
                            "metric":"Switch from ISR back to interrupted thread",
                            "cycles":"895",
                            "nanoseconds":"895"
                        },
...

its corresponding recordings.csv:
"metric","cycles","nanoseconds"
"Preemptive threads ctx switch via k_yield (K -> K)","22207","22207"
"Cooperative threads ctx switch via k_yield (K -> K)","22111","22111"
"Switch from ISR back to interrupted thread","895","895"
...

wondering why you choose to put the data in the testcase and not in the testsuite, since the recording applies to the whole testsuite and not to a specific testcase, so it might be misleading. The testcase section for such tests are automatically created for completeness.


[WIP]: Added Request queue, processor for comp integration  and EM-FSM

Added functionalities,

Request queue for autotune
Processors for integration with different component with Request Queue
Experiment manager classes hierarchy
finite state machine for experiment manager states

This is now obsolete


Mailer

I think that there may be an issue with a merge conflict with the trash options. I am a bit confused on why it is there now and didn't make it in last night. but I also have the fix for the redirect to the project page after you send a message to the owner

updated trash stuff


IPv4Address/IPv6Address is not serializable when part of untyped dict

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
Hi!
Great job on Pydantic V2 and the amount of work that has been poured into fixing minor issues here after release.
In the process of migrating from V1 to V2 I stumbled upon an issue which I am not sure is a bug or intended behaviour. When serializing a model to json with an untyped dict containing a value of ipaddress.IPv4Address or ipaddress.IPv4Address pydantic throws an pydantic_core._pydantic_core.PydanticSerializationError: Unable to serialize unknown type: IPv4Address('<IP_ADDRESS>').
This does not happen when serializing an untyped dict with a datetime.datetime() value as can be seen in the example code.
It is possible for us to explicitly convert the ipaddress.IPv4Address or ipaddress.IPv4Address to strings before using them in a model, so there is no urgency, but it would be nice to know whether this issue is a bug or not.
Example Code
import datetime
import ipaddress

from pydantic import BaseModel

class Test(BaseModel):
    d: dict

test_with_datetime = Test(d={"datetime": datetime.datetime(2023, 7, 14, 6, 44, 24, 223091)})
print(test_with_datetime.model_dump_json())

# returns: {"d":{"datetime":"2023-07-14T06:44:24.223091"}}

test_with_ip_v4_address = Test(d={"ip": ipaddress.IPv4Address('<IP_ADDRESS>')})
print(test_with_ip_v4_address.model_dump_json())

# fails with pydantic_core._pydantic_core.PydanticSerializationError: Unable to serialize unknown type: IPv4Address('<IP_ADDRESS>')

test_with_ip_v6_address = Test(d={"ip": ipaddress.IPv6Address('2001:218::')})
print(test_with_ip_v6_address.model_dump_json())

# fails with pydantic_core._pydantic_core.PydanticSerializationError: Unable to serialize unknown type: IPv6Address('2001:218::')

Python, Pydantic & OS Version
pydantic version: 2.0.3
        pydantic-core version: 2.3.0 release build profile
                 install path: /home/nss/.cache/pypoetry/virtualenvs/ifd-_AXDVEVR-py3.11/lib/python3.11/site-packages/pydantic
               python version: 3.11.0 (main, Feb 23 2023, 13:05:14) [GCC 11.3.0]
                     platform: Linux-5.19.0-46-generic-x86_64-with-glibc2.35
     optional deps. installed: ['email-validator', 'typing-extensions']

Selected Assignee: @lig

Hi @nss-csis ,
Thanks for this issue 🙏
I think it is intended behavior and we've already mentioned it in the migration doc.
With the dict, we don't have key type and the value type would be Any. So, Pydantic doesn't validate the values.

For me its just not clear why it works with datetime.datetime and not ipaddress.IPv4Address. Is this some weird quirk of how the two different classes are implemented?

@nss-csis I believe that the json serializer being used by Pydantic just be able to serialize datetime.datetime without any additional machinery inside Pydantic.
So, with Pydantic json serializer datetime.datetime isn't a custom class, it could be serialized wherever int or str could.


crash on using mutator to instantiate from a VF

Hi. I am using a script @chrissimpkins wrote to instantiate statics from a VF. It looks like mutator/ttLib is crashing on the gvar table.
Traceback (most recent call last):
  File "/Users/stupakm/Documents/freelance/code_apps_etc/vf2s.py", line 170, in <module>
    main()
  File "/Users/stupakm/Documents/freelance/code_apps_etc/vf2s.py", line 118, in main
    instantiateVariableFont(font, instance_location, inplace=True)
  File "/Users/stupakm/venvs/type-tools-py3/lib/python3.7/site-packages/fontTools/varLib/mutator.py", line 178, in instantiateVariableFont
    gvar = varfont['gvar']
  File "/Users/stupakm/venvs/type-tools-py3/lib/python3.7/site-packages/fontTools/ttLib/ttFont.py", line 392, in __getitem__
    table.decompile(data, self)
  File "/Users/stupakm/venvs/type-tools-py3/lib/python3.7/site-packages/fontTools/ttLib/tables/_g_v_a_r.py", line 111, in decompile
    numPointsInGlyph, sharedCoords, axisTags, gvarData)
  File "/Users/stupakm/venvs/type-tools-py3/lib/python3.7/site-packages/fontTools/ttLib/tables/_g_v_a_r.py", line 227, in decompileGlyph_
    sharedTuples, data, 4, offsetToData)
  File "/Users/stupakm/venvs/type-tools-py3/lib/python3.7/site-packages/fontTools/ttLib/tables/TupleVariation.py", line 553, in decompileTupleVariationStore
    tableTag, axisTags, tupleData, pointDeltaData))
  File "/Users/stupakm/venvs/type-tools-py3/lib/python3.7/site-packages/fontTools/ttLib/tables/TupleVariation.py", line 596, in decompileTupleVariation_
    len(points), tupleData, pos)
  File "/Users/stupakm/venvs/type-tools-py3/lib/python3.7/site-packages/fontTools/ttLib/tables/TupleVariation.py", line 414, in decompileDeltas_
    runHeader = byteord(data[pos])
IndexError: index out of range

The file I'm using here is the Italic in my Open Sans repo. (The Roman works fine.)

by looking at the error it appears that the gvar table is corrupt. how was it generated in the first place?

fontmake, but it used the complex build process I described briefly when we last spoke. (Scripts here, documentation here
I haven't seen any issues with using the font, nor does fontbakery complain. (It doesn't pass ots-sanitize but that's in STAT and GDEF.)

ok I see that mutator fails do decompile the gvar table for this font:
https://github.com/laerm0/opensans/blob/master/variable_ttf/OpenSans-Italic-VF.ttf
I'm afraid I don't have time to debug your custom build scripts, but I you provide a reproducer by using only vanilla fontmake that would be great.
E.g. very concise command lines that I can run to compile that font from source and trigger the possibly faulty gvar table

Sure thing. I'll take a look. Thanks @anthrotype .

The "Open Sans Italic V.glyphs" file in your repo contains some bracket layers with multiple axes, which glyphsLib rejects as invalid (https://github.com/googlei18n/glyphsLib/issues/468).
If I delete them and then try to build with fontmake, the generated variable font does not have the faulty gvar table and can be decompiled and run through mutator just fine.

That makes sense, but the Roman has the same bracket layers with multiple axes, so I didn't think that was the issue.

it turns out this error was the result of using VTT autohinter which sometimes modifies the glyf coordinates (unless you "disable outline modification" option in setttings).

Eh, no, I have VTT always set not to modify the outlines. I'm still trying to figure out what happened. Please keep this issue open.

oh I misunderstood.
In any case, whatever tool you're using to post-process OpenSans as fontTools varLib originally built it, that may be modifying the glyph point indexes in the glyf table, will inevitably break gvar.

Yep, I wanted to figure out which part of the process broke it, so I was going to go through step-by-step and see where it collapses. I'll update this issue at a later date. Thanks @anthrotype .

@laerm0 FWIW, that setting doesn't stick, you have to turn it on each time you open a font in VTT (yes, this drives me crazy)

@benkiel Huh, I don't have that problem. It used to be the case, though: are you on the newest VTT? It's at v6.31.

On the other hand, I have gone at the VTT registry entries with a baseball bat and machete to get it to work properly, so maybe I've really done a thing to it.

@laerm0 Oh man, if it stopped doing that I'd be so happy. I doubt I'm on the latest, I pick VTT up every couple months, so I'm not frequently using it. Thank you for the tip!

So, non-issue then?


Check licensing

Taken from LICENSE-TODO.txt:
ASM bytecode package in under a 3-clause BSD license (OK).
BSF - check these, probably public domain.
peter jodeleit: http://commons.apache.org/proper/commons-bsf/
engine - the jsr223 engine, some files need to be removed (sun javax stuff)
peter jodeleit: these files are obsolete if java 1.5 support is dropped, the file are part of the jdk since 1.6
JUnit
Common Public License - v 1.0
Deal with docs and build files, READMEs?


Having different groups of tasks for the same work item type

A user story can follow complex steps with several tasks on it (I have one project going from 9 to 12 tasks for the standard process).
There are groups of tasks. A first set for requirements and their customer's validation. A second set for the design and their customer's validation. A third for development and tests. A fourth for UAT (core product and localizations).
For requirement and design phasis, without the validation, the user story is removed. Then, if we had created the overall tasks, tasks for phasis 3 and 4, and maybe phasis 2 are not relevant. It would be better if those were not created.
So being able to create different sets of tasks for the same type of WI can avoid creating a lot of tasks which may not yet be relevant in the backlog or which may potentially never be addressed.

I need it too.
Is it in roadmap?
Tnx

I have implemented this on my own fork. It uses a specific keyword in the title (e.g [Incubator] This is a Incubator story), and changes the Work Item filter to use curly braces {}. You just need to add the keyword to the description (e.g {User Stor} or [Incubator])

Hi,
Do you know when you plan to update the extension with these changes.
This is exactly what I was looking for.
Thanks

I can do a pull request. I was concerned about the change from the [] to the {} to support my own needs.

Hi @omireault, could you explain the reason for changing from [] to {} as a Work Item Type identifier.
I would be happy to accept a pull request but I'm concerned about backwards compatibility.
If we keep [] for Work Item Types we can use {} for fieldnames.

Honestly, it was just because of my company's use case. We are used to
tagging spikes and incubators with []. I can make the change and submit a
pull request.
On Fri, Dec 8, 2017 at 2:16 PM Rui Figueiredo<EMAIL_ADDRESS>wrote:

Hi @omireault https://github.com/omireault, could you explain the
reason for changing from [] to {} as a Work Item Type identifier.
I would be happy to accept a pull request but I'm concerned about
backwards compatibility.
If we keep [] for Work Item Types we can use {} for fieldnames.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/figueiredorui/1-click-child-links/issues/12#issuecomment-350373966,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD0Ese270S4TshK9ZFldAl76PVTHlyIkks5s-acngaJpZM4Obizg
.

Wiki - Group templates with identifier


HPA complaning about webhook payload with workflowJob.labels: ["ubuntu-latest"]

Checks

[X] I've already read https://github.com/actions-runner-controller/actions-runner-controller/blob/master/TROUBLESHOOTING.md and I'm sure my issue is not covered in the troubleshooting guide.
[X] I'm not using a custom entrypoint in my runner image

Controller Version
0.26.0
Helm Chart Version
0.21.1
CertManager Version
1.10.1
Deployment Method
Helm
cert-manager installation
cert-manager installation all ok
Checks

[X] This isn't a question or user support case (For Q&A and community support, go to Discussions. It might also be a good idea to contract with any of contributors and maintainers if your business is so critical and therefore you need priority support
[X] I've read releasenotes before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes
[X] My actions-runner-controller version (v0.x.y) does support the feature
[X] I've already upgraded ARC (including the CRDs, see charts/actions-runner-controller/docs/UPGRADING.md for details) to the latest and it didn't fix the issue
[X] I've migrated to the workflow job webhook event (if you using webhook driven scaling)

Resource Definitions
---
apiVersion: actions.summerwind.dev/v1alpha1
kind: HorizontalRunnerAutoscaler
metadata:
  name: autoscaler-arc-autoscaler
  namespace: actions-runner-system
spec:
  minReplicas: 2
  maxReplicas: 10
  scaleTargetRef:
    kind: RunnerSet
    name: autoscaler-arc-runnerset
  scaleUpTriggers:
    - githubEvent:
        workflowJob: {}
        duration: "30m"
---
apiVersion: actions.summerwind.dev/v1alpha1
kind: RunnerSet
metadata:
  name: autoscaler-arc-runnerset
  namespace: actions-runner-system
spec:
  repository: cloudfoundry/app-autoscaler-release
  selector:
   matchLabels:
     app: autoscaler-arc-workers
  serviceName: autoscaler-arc-service
  template:
    metadata:
      labels:
        app: autoscaler-arc-workers
    spec:
      tolerations:
      - effect: NoSchedule
        key: github-arc-workers
        operator: Equal
        value: "true"
      containers:
      - name: docker
        volumeMounts:
        - name: var-lib-docker
          mountPath: /var/lib/docker
  volumeClaimTemplates:
  - metadata:
      name: var-lib-docker
    spec:
      accessModes:
      - ReadWriteOnce
      resources:
        requests:
          storage: 20Gi
      storageClassName: premium-rwo

To Reproduce
Run your workflow with `runs-on: ubuntu-latest`

Describe the bug
I have setup as per instructions, however receiving Found 0 HRA for webhook payloads received with  "workflowJob.labels": ["ubuntu-latest"].
Autoscaling seems to work for the ones which are sending "workflowJob.labels": ["self-hosted"] but it makes logs in webhook server noisy. Is there any way to somehow silence/ingore these?
Many thanks.
2022-12-01T14:12:21Z    DEBUG   controllers.webhookbasedautoscaler      Found 0 HRAs by key     {"key": "cloudfoundry"}
2022-12-01T14:12:21Z    DEBUG   controllers.webhookbasedautoscaler      no repository/organizational/enterprise runner found    {"event": "workflow_job", "hookID": "390696287", "delivery": "2b97a8c0-7182-11ed-9dba-de56d1a4e4f6", "workflowJob.status": "completed", "workflowJob.labels": ["ubuntu-latest"], "repository.name": "app-autoscaler-release", "repository.owner.login": "cloudfoundry", "repository.owner.type": "Organization", "enterprise.slug": "", "action": "completed", "repository": "cloudfoundry/app-autoscaler-release", "organization": "cloudfoundry", "enterprise": ""}
2022-12-01T14:12:21Z    DEBUG   controllers.webhookbasedautoscaler      Scale target not found. If this is unexpected, ensure that there is exactly one repository-wide or organizational runner deployment that matches this webhook event     {"event": "workflow_job", "hookID": "390696287", "delivery": "2b97a8c0-7182-11ed-9dba-de56d1a4e4f6", "workflowJob.status": "completed", "workflowJob.labels": ["ubuntu-latest"], "repository.name": "app-autoscaler-release", "repository.owner.login": "cloudfoundry", "repository.owner.type": "Organization", "enterprise.slug": "", "action": "completed"}
2022-12-01T14:13:35Z    DEBUG   controllers.webhookbasedautoscaler      Found 1 HRAs by key     {"key": "cloudfoundry/app-autoscaler-release"}
2022-12-01T14:13:35Z    INFO    controllers.webhookbasedautoscaler      job scale up target is repository-wide runners  {"event": "workflow_job", "hookID": "390696287", "delivery": "5767a1d0-7182-11ed-9da5-90b99a0d08b1", "workflowJob.status": "queued", "workflowJob.labels": ["self-hosted"], "repository.name": "app-autoscaler-release", "repository.owner.login": "cloudfoundry", "repository.owner.type": "Organization", "enterprise.slug": "", "action": "queued", "repository": "app-autoscaler-release"}
2022-12-01T14:13:35Z    INFO    controllers.webhookbasedautoscaler      scaled autoscaler-arc-autoscaler by 1
2022-12-01T14:13:35Z    DEBUG   controllers.webhookbasedautoscaler      Found 1 HRAs by key     {"key": "cloudfoundry/app-autoscaler-release"}
2022-12-01T14:13:35Z    INFO    controllers.webhookbasedautoscaler      job scale up target is repository-wide runners  {"event": "workflow_job", "hookID": "390696287", "delivery": "57c88680-7182-11ed-91c0-23b46baad3ab", "workflowJob.status": "queued", "workflowJob.labels": ["self-hosted"], "repository.name": "app-autoscaler-release", "repository.owner.login": "cloudfoundry", "repository.owner.type": "Organization", "enterprise.slug": "", "action": "queued", "repository": "app-autoscaler-release"}
2022-12-01T14:13:35Z    INFO    controllers.webhookbasedautoscaler      scaled autoscaler-arc-autoscaler by 1
2022-12-01T14:13:36Z    DEBUG   controllers.webhookbasedautoscaler      Updating hra autoscaler-arc-autoscaler for capacityReservations update  {"before": 0, "expired": -2, "added": 2, "completed": 0, "after": 2}
2022-12-01T14:13:36Z    DEBUG   controllers.webhookbasedautoscaler      Found 1 HRAs by key     {"key": "cloudfoundry/app-autoscaler-release"}
2022-12-01T14:13:36Z    INFO    controllers.webhookbasedautoscaler      job scale up target is repository-wide runners  {"event": "workflow_job", "hookID": "390696287", "delivery": "581483a0-7182-11ed-9c03-ce83ce4393e8", "workflowJob.status": "queued", "workflowJob.labels": ["self-hosted"], "repository.name": "app-autoscaler-release", "repository.owner.login": "cloudfoundry", "repository.owner.type": "Organization", "enterprise.slug": "", "action": "queued", "repository": "app-autoscaler-release"}
2022-12-01T14:13:36Z    INFO    controllers.webhookbasedautoscaler      scaled autoscaler-arc-autoscaler by 1
2022-12-01T14:13:37Z    DEBUG   controllers.webhookbasedautoscaler      Found 1 HRAs by key     {"key": "cloudfoundry/app-autoscaler-release"}
2022-12-01T14:13:37Z    DEBUG   controllers.webhookbasedautoscaler      Found some runner groups are managed by ARC     {"event": "workflow_job", "hookID": "390696287", "delivery": "58de1530-7182-11ed-965d-7436272bb3ad", "workflowJob.status": "completed", "workflowJob.labels": ["ubuntu-latest"], "repository.name": "app-autoscaler-release", "repository.owner.login": "cloudfoundry", "repository.owner.type": "Organization", "enterprise.slug": "", "action": "completed", "groups": "RunnerGroup{Scope:Organization, Kind:Default, Name:}"}

Describe the expected behavior
HPA to ignore "ubuntu-hosted" label
Whole Controller Logs
https://gist.github.com/marcinkubica/9f40e6c49fca3fe54243441c9584045c

Whole Runner Pod Logs
https://gist.github.com/marcinkubica/9f40e6c49fca3fe54243441c9584045c

Additional Context
No response

@marcinkubica Hey! You seem to be missing ubuntu-latest under your RunnerSet's spec.labels.

Thanks for the fast reply @mumoshu !
ubuntu-latest are the ones triggered by workflows using github's internally hosted runners. Would it still be the case to add them to runnerSet spec.labels?
Cheers

@marcinkubica Hey! I might be confused, but what's your goal?
Do you want GitHub-managed runners, not self-hosted runners, to handle jobs with ubuntu-latest? There's no need to add the runner label to the RunnerSet/RunnerDeployment's spec.labels then. Just set a less verbose log level to ARC's github webhook server to prevent it from spamming the DBEUG logs.
https://github.com/actions-runner-controller/actions-runner-controller/blob/fe05987eea33140abc11f70e49a8486b0dcd8cdd/charts/actions-runner-controller/templates/githubwebhook.deployment.yaml#L43


Fix Tile Excluder bug

Fixes #1283

Thanks for the pull request @joseph-kaile!

:x: Missing CLA.

Please send in a Contributor License Agreement (CLA) and comment back here to let us know to check this!
Maintainers, here's how to check for a submitted CLA.

Reviewers, don't forget to make sure that:

[ ] Cesium for Unreal Samples works.


Two types of graphs are displayed.

Description:
There are two types of graphs as shown in the image. It is better to have a grid for all graphs.

Suggested Labels:
Type: Bug, Severity: Minor
Suggested Assignees:
@CharukaK
Affected Product Version:
productSP: wso2sp-4.0.0-beta3
OS, DB, other environment details and versions:
OS: 16.04.1-Ubuntu.
web browswer: firefox - 57.0.1, chrome - 58.0.3029.110

This issue occurs due to there is one value in the chart's Y-axis when there is more than one value it will show a grid with horizontal lines. Another work around for this issue is defining the yDomain prop in the chart component


fixed cassandra chart's persistence bug

@KongZ this fixes #1176

@touchdown Thanks for submitting PR. If you don't have CLA, Will you allow me create another PR with this bug fix?

i just signed up with CLA, but it doesn't look like anything changed? but sure go ahead.

oh i guess i just needed to comment to trigger the hook

any idea when this is going to be merged?

@k8s-bot ok to test

Sorry for the delay folks!


Can Revert back to previous Version?

Hello,
Is there anyway to revert back to a previous sync version. If not that would be a great feature request.
Thank you.

Should probably be a feature request for the vscode team instead. Being able to install a specific version of a vscode plugin. Being used to npm, i kinda expected this to work (it didn't):
code --install-extension<EMAIL_ADDRESS>--force

@UTexas80 report in code repo to allow extensions to install previous extensions.
But if you set autoupdate to false and then upload the gist, Settings Sync will take care and download the version specific extensions.

Btw, it is possible. Download the *.vsix from here. Open up code and select "Install from VSIX" (in the action panel). Answer yes to replace the new with the old.

How do you revert to a previous version of your settings? I accidentally uploaded blank settings.

I accidentally uploaded blank settings.

We can revert to previous version of extension. But if you want to revert your settings to older version. You need to check the revisions from the Gist Page inside github.
To Support Settings Sync to revert to older revision , there is already issue opened. #413