Build Wails app for macOS, Linux, Windows

The macos application works well, super cool.
We need to update the name to albyhub for now and set an app icon (cc @stackingsaunter any idea what we should use here?)
@im-adithya can you look into the code signing for mac and potentially windows: https://wails.io/docs/guides/signing/

@bumi the name is changed now 👍

Well, bummer. It did not work for macOS because of this little pesky bug in Wails: https://github.com/wailsapp/wails/issues/2290
Should we change the "name" field in wails.json from nostr-wallet-connect to albyhub? That would fix the issue.

yes, we should change the name. albyhub might get changed also but it is for sure not nostr-wallet-connect. so we should change this.

@bumi seems to be fixed now!

We can use this icon for now


[flagd] e2e tests should use test-harness version.txt as test-image version

With the release of flagd-testbed v0.5.18, we now have a version.txt containing the version for the correlating docker images to be used within the e2e tests.
We should upgrade our git test-harness submodule and use this file to determine the version.

resolved with #1111


[Bug]: DwC-A Checklist importer: Subsequent combinations fail to import if the originalNameUsageID is unknown

Steps to reproduce the bug

When importing a DwC-A Checklist
If the originalNameUsageID is unknown, subsequent combinations fail to import with the error, "Could not determine if name is protonym or combination"

Screenshot

Expected behavior
It would be preferable to still import subsequent combination records in which the originalNameUsageID is unknown, and use the verbatim author field to set the bracket on the authorship like (Walsh), because after the import is completed it will be easier to filter for incomplete combination relationships with the Filter Nomenclature Task and fill in the missing original combination data with the taxon name editing tools instead of trying to correct it in the import task in which you'd have to fill in a large number of IDs. Often the names missing the originalNameUsageID are really old names in which it's hard to find/access the original genus because the literature has been long out of print, so importing the currently used subsequent combination seems more important than having the original combination data.
Additional Screenshots
No response
Environment
Sandbox
Sandbox Used
sandbox
Version
4a941a139
Browser Used
Firefox

@LordFlashmeow, could you please address this issue, we are trying to import taxonomy, and about 1/3 of the name fail, because originalNameUsageID is blank in the dataset.


feat: copy Caller to new entry if reportCaller is not set

Copy Caller to new entry if ReportCaller is not set when log.
There are some scenarios where users want to pass the caller by themself, for example, many libraries accept a logger interface and use it to output internal log(such as SQL exec log for Gorm), many users wrap logrus to the needed interface, but the caller got by logrus is inaccuracy in this case, and need to get the caller and pass it into Entry, just throwing caller away will  break wrapped loggers for these libraries.
Passing caller in Entry works util #1229 imported Dup to fix race condition issue.

@dgsb Could I ask you for code review? Do you think this is valuable for users?(This does value for me) Thanks!

It seems that #1215 has done this, but it may be completed without importing a new method to Entry.


better demonstrate middleware flow

The way this example is written makes it seem like middleware can't act on the context changes of other middleware.  This updates the logger middleware to use the calculated response time value from the response time middleware instead of calculating it itself.

I'm +/-0 on this.

I get where you're headed on this, and I dig it, but wouldn't this make the X-Response-Time ever so slightly too short?


Trickle down of Agency Address info

In SW record, when agency is selected, the address of agency does not populate.

duplicate.


[docs-only] fix env var description showing emails in results

The env var description for ShowUserEmailInResults suggested that emails will be omitted from the result if set to true. The opposite is the case.

The descriptions of some other env vars mention what the default is if the env var is not set at all. Maybe that should also be added (I would be guessing or have to look at the code to know if this is enabled or disabled by default).

Good catch, thanks. I added something. Also snuck in another bit of information I learned today (admins always see email addresses).

There is also PR #9668 with different words. You guys sort it out.
Personally, I prefer the "positive" approach - say what it does, and say that the default is false

Note: #9668 found other places where this is also documentation for this.
Maybe some of that gets auto-generated?
Maybe this change needs to be made in multiple places?

I'd like to add something about SamAccountName...
I believe, the logic was, that when we set OCIS_SHOW_USER_EMAIL_IN_RESULTS=true, but there is no email address available, the the web UI shows the SamAccountName instead?
Are the other two places I found in #9668 auto-generated?

No, not samaccountname. That is not windows.
Please let us not creep some scope here. That would take too long.

Are the other two places I found in https://github.com/owncloud/ocis/pull/9668 auto-generated?

one is, yes

Updated the PR again. @micbar please decide which wording you like best (the one in this PR or https://github.com/owncloud/ocis/pull/9668 ).


ASP.NET MVC Core support

Independent of FluentBootstrap targeting .NET Core, we need a library that works with ASP.NET MVC Core and wraps it's IHtmlHelper interface. Now that Wyam is also using the MVC Core Razor host, this package should also work for it (and the existing FluentBootstrap.Wyam package is no longer needed).

Hows this going? .. Now VS2017 is out so core should be fully in the open now :).

@LordMike This is one of those "I may get it it...eventually" issues. This project is fairly low on my priority list right now and I'm considering it in maintenance mode at the moment.
That said, I'd be happy to accept a PR that adds a new MVC Core adapter library if someone ends up putting one together.

Sure. (I have projects like that too).. :)
As I understand this, it's a series of extension methods that emit bootstrap-py HTML, right?
So in a sense, most of the code should be in place, it just needs the wiring for the new MVC?

That's exactly right, all the core code is framework-agnostic. There's currently libraries for old ASP.NET MVC as well as ASP.NET WebPages - a library for ASP.NET MVC Core would look very similar (form binding stuff might be a bit different, but that's not strictly required).


AddNecessaryNotes

#sign-off

@ruixinxu
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

@JeneZhang - we'll need approval from the current 'author' before we can merge metadata (and other) changes. thanks.

#sign-off

#sign-off


ISPN-14323 Get command blocks in text/plain caches

https://issues.redhat.com/browse/ISPN-14323
The problem was that the current implementation assumed the cache media types, so some methods failed with type casting. I've changed to handle different media types. I guess that another approach would be to not accept custom configurations.
Also, the random bytes prefix seems to affect when the value was transformed, so I changed it to be a readable value (resp|).

Coming to think of it, it looks more like there is a limitation with encoded cache + listeners. After setting the media type, the listeners still fail with the cast. Internally it tries to call the listener with the configured media types instead of the converted. What do you think?

Integrated into main, thanks @jabolina !

We should backport this to 14.0.x as well.


[BUG] Get ClientJSONDecodeError when try login with 2fa

I'm trying to login without 2fa code:
cl.login(login, password, relogin=True)
And when get 2fa required exception trying to login with 2fa code:
cl.login(login, password, relogin=True, verification_code=str(code))
And so get in console html code (1) and after this get traceback (2):
(1) I place in file:
temp.txt
And (2) in:
I have not any idea for solving this

temp2.txt
I don't know why, but github can not upload two files in 1 comment


Failed to attach, connection refused

For some reason when I run the debug, I got the messsage: "Failed to attach (connect ECONNREFUSED <IP_ADDRESS>:5678)". I'm using a VM in Azure to simulate the device

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 750a365e-4776-230f-5517-ec2437af0c8c
Version Independent ID: 0a6b96e9-47b6-ce32-0fef-f3ba3b49847d
Content: Debug Python modules for Azure IoT Edge
Content Source: articles/iot-edge/how-to-develop-python-module.md
Service: iot-edge
GitHub Login: @shizn
Microsoft Alias: xshi

@zambottivinicius thank you for your feedback! Are you under a proxy? Please check the following article: [Configure an IoT Edge device to communicate through a proxy server](Configure an IoT Edge device to communicate through a proxy server)
Thank you!

Hello @zambottivinicius what OS are you running on? If using Windows with Linux Containers, did you completed this doc successfully?: Install the Azure IoT Edge runtime on Windows to use with Linux containers. Also as a first step you should complete the following quickstart:  Deploy your first IoT Edge module from the Azure portal to a Windows device.
Thank you!

Hello @sergaz-msft My edge devices are running perfectly. I'm using Linux and deploying my devices in containers in a Linux VM at azure.

Thanks for confirming @zambottivinicius . @shizn can you confirm if we support the scenario described to develop and debug Python modules for Azure IoT Edge ?

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Update KLI to support Doist scriptability

Update all commands in kli command package to return a list of Doers and have kli.py main method read that list of Doers and execute directing.runController() with that list of doers to execute the command.
This will allow any testing harness to call the handle method registered for any command and execute it by passing to a top level Doist which will make scripting multiple commands together easier for tests.

Closed with PR #148


What happened?
Last 5 runs are failing
https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/
Issue Failure
Failure: Test is continually failing
Issue Priority
Priority: 2 (backlog / disabled test but we think the product is healthy)
Issue Components

[X] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

@damccorm

Comparing the last successful run and the first failing run, there aren't many differences. The dependencies installed are the same, and there are no code changes.
The only meaningful changes I can find in the output is that this line appears in the logs in the failing run:
	WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://googleapis.dev/python/datastore/latest/objects.inv' not readable due to ValueError: unknown or unsupported inventory version: ValueError('invalid inventory header: <!doctype html>')

In the past this has been caused by docs moving - https://issues.apache.org/jira/browse/BEAM-13848?jql=project %3D BEAM AND text ~ "unknown or unsupported inventory version" ORDER BY priority DESC%2C updated DESC - at a glance, that doesn't seem to be the case:
https://github.com/apache/beam/blob/5cc5b196a40d91a2b878ea30da6f3af1410c3c85/sdks/python/scripts/generate_pydoc.sh#L145
leads to https://googleapis.dev/python/datastore/latest/ which at least redirects to https://cloud.google.com/python/docs/reference/datastore/latest/index.html


Add option to crop video (for example, remove Navigation bar)

The navigation bar is often unnecessary to include in the recording - indeed, some devices don't have an on screen nav bar, so you wouldn't see it anyway.
It would be really good if this could be auto-cropped from the final video (with an appropriate setting to control this).  I had a quick play with various height parameters in the code, but that only made the whole size smaller.  So, I'm not sure how this can be done, or whether it can be done at all.
The alternative is to crop the video post-production which is obviously cumbersome. Indeed, I'm yet to find a decent tool on OS X, to do this well.

This is a great idea. Going to copy what you said over to #42 and close this issue since they're about the same thing.


R CMD Check windows vignette issue

create pull request to test actions

Had to turn off building the vignette on windows and skip some of the tests as they cause an error

Fixes https://github.com/poissonconsulting/bboutools/issues/6


Common Crawl URLs issue

Current Common Crawl URLs don't work for downloading (give 403 Forbidden).
According to the Common Crawl Website you should use:

https://data.commoncrawl.org/crawl-data/CC-MAIN-2019-47/cc-index.paths.gz
https://data.commoncrawl.org/crawl-data/CC-MAIN-2019-47/wet.paths.gz

And for index URLs follow this:

By simply adding either s3://commoncrawl/ or https://data.commoncrawl.org/ to each line, you end up with the S3 and HTTP paths respectively.

Hi @akaysh, thank you so much for creating the issue! The links have been updated with https://github.com/apple/ml-qrecc/commit/cf44d03cb6676f7414471cec509d4a6c6858b0d3.


[Feature request] multiple module directories

At work we are migrating from bower to npm, where some dependencies will be in bower_components and others in node_modules.
Would you mind if we make modulesDir an array of component directories to search in? The polymer tools also allowed this.
I can work on a PR for this.

modulesDir isn't actually the local node_modules directory, it's the HTTP URL path.  So for example in my own builds I use modulesDir: '/assets' and node_modules itself isn't available to the web server (./assets has a copy of the stuff the web server is allowed to share).
Currently this plugin doesn't have an option for setting the local node_modules (or bower_components) directory used to resolve the path of the module to be loaded.  I'm not clear how this would work or if https://github.com/browserify/resolve#readme can even resolve paths in bower_components.  It has an options moduleDirectory but I don't know how well it'll work if that contains non-node modules.
For options on this plugin maybe modulesDir could accept a String or Object.  So:
function normalizeModulesDir(modulesDir) {
  if (typeof modulesDir === 'string') {
    return { 'node_modules': modulesDir };
  }
  return modulesDir;
}

This way you could set modulesDir as:
{
  "node_modules": "/node_modules",
  "bower_components": "/bower_components"
}

Where each key would be the local directory to search and the value would be the URL associated with that local directory.

I think that should work. For the polymer tools I made the same PR (https://github.com/Polymer/tools/blob/master/packages/analyzer/src/javascript/resolve-specifier-node.ts#L51) I think they use browserify resolve too.


Support social login

Hi,
Would it be possible to login with social networks such as Twitter, Facebook, Google, Yahoo and more in the next release ?
Thx,

Yes, but it would be better to have an "official" support of sociale login in the rainlab user plugin. Why to not use socialite : https://github.com/laravel/socialite ?

This should be handled as a separate plugin, social login is outside the scope of standard account management


add dns enabled= true/false option

follow-up from https://github.com/dmacvicar/terraform-provider-libvirt/pull/376
https://github.com/dmacvicar/terraform-provider-libvirt/pull/376#issuecomment-418134394

Symptom:
13:19] <ebischoff> ebischoff@tegan:~/SCM/github/Bischoff/spacewalk> ps aux | grep dnsmas
[13:19] <ebischoff> dnsmasq  24228  0.0  0.0  73168  2240 ?        S    11:29   0:00 /usr/sbin/dnsmasq --conf-file=/var/lib/libvirt/dnsmasq/ebi3-private.conf --leasefile-ro --dhcp-script=/usr/lib64/libvirt/libvirt_leaseshelper

There should be no result when enabled = false.

As per newer version of libvirt dns can be disabled using <dns enable='no'/> and then that specific network interface will not be bind with the dnsmasq which help in case you want to bind that interface with different dns server.

More info https://www.redhat.com/archives/libvir-list/2016-August/msg00641.html

ok, you're suggesting a way to implement this, @praveenkumar , if I understand well?
In my use case, I did not want to use different DNS server. I just wanted no DNS server :smile_cat: .

@Bischoff I am going to spend some time and look into the code around how to implement it but even for my usecase I don't want to run any DNS server which is maintained by dnsmasq.

Cool, thanks Praveen for jumping into this issue.

thx

This one seems to be missing out on the docs: https://github.com/dmacvicar/terraform-provider-libvirt/issues/580


[MM-17603] Added null check to label generator on suggestion list (#3443)

Summary
Cherry-pick of #3443 to v5.14
Ticket Link
https://mattermost.atlassian.net/browse/MM-18143

@devinbinnie looks like you need the same fix in search_suggestion_list.jsx it has the same exact problem there

@devinbinnie oops, just realized that's exactly where you made the fix, I was looking at suggestion_list.jsx which has the same exact code with the same exact problem, I was just trying to say that it seems that you need to fix it both when i was testing this

Thanks @dmitrysamuylovpharo, I'm going to create a separate PR with that fix and a test around this issue.


feat(atomic): add functionality arrow button scroll

Based off this PR
Still need to adjust pixelsScrolled according to window width (fixed)

Demo:
https://user-images.githubusercontent.com/97299176/174823882-f64d5631-d6e2-415b-94ae-24e758e74103.mov

I'll look this up, but before please make sure you have everything merged up and no conflicts with your previous changes 🙏

I'll make sure to properly merge !

It should always be properly merged when asking for reviewers to look at it otherwise it's hard for us to keep track of what's happening
If you want: master <- KIT-1722-Segmented-Scrollable <- KIT-1756-Add-functionality-arrow-scroll
You can just point this PR to the KIT-1722-Segmented-Scrollable branch

sounds like a good solution to me

I'd suggest that, instead of scrolling the full width, you snap to the closest 'full facet'. For example, look at group 15 here:   you never get to see its full value.
this is the behaviour I'd suggest:
when in the first page, show the full leftmost facet, like so
when navigating with the arrows, show the full facet on the left
not sure if I'd change the behaviour depending on the side (when navigating right, snap to the leftmost facet; when navigating left, snap to the rightmost facet); depends what it looks like, but essentially you want to make sure you can read the full thing at some point!

or maybe I could scroll only 75% of the container's width. I could do this but I feel like it would be a bit more tricky/messy

yeah, the airbnb one seems to scroll less... I find it annoying, but if that's what we're doing 🤷♀

yeah, the airbnb one seems to scroll less... I find it annoying, but if that's what we're doing 🤷♀

I could ask Johnny/ wait for more reviews.


Please Mind

If use butterKnife in a library project,please tell me must add
apt 'com.jakewharton:butterknife-compiler:8.4.0'
in my app gradle

Yes. Please see the readme for instructions.


Revist the creation of submodules in geom_mgr

Types of change(s)

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist

[ ] Tested this change with a run of GEOSgcm
[x] Ran the Unit Tests (make tests)

Description
Revist the creation of submodules in geom_mgr. We particularly focus on the submodules associated with GeomManager.F90 and do the following:

Include the function find_factory in its own submodule.
Remove all the use statements from all the submodules

Related Issue

Just changed the base.


Decision: Config API structure and design

As part of discussing #103, #105, and #106, we also discussed how we should design the configuration API.
Given that we think that everything will be subcommands in a single binary (#105), and that deployment models may be very different between platforms (#106), we believe that the best structure will be a structure with:

a common core struct config, plus a platform union field. This common core will hold configuration like logging levels, debug, and other things that every deployment type will need.
individual platform config structs, selected using the platform union field.

The union field pattern is described in the Kubernetes API Conventions, but the design principle is useful anywhere.
That is, the config for any particular piece of Envoy Gateway (for example, the provisioner), should end up looking something like this (in YAML format, but will be written as Go types):
loggingLevel: <something, depends on logging library>
debug: true|false
platform: kubernetes|local
kubernetes:
  # Kubernetes-specific config goes here
local:
  # local-specific config goes here

This allows flexibility to add platforms later, and allows us to design the platform config separately for each platform.
On a code level, this allows these structs to be embedded into various places (eg the spec of a Kubernetes CRD that can be used as a GatewayClass paramsRef), and have changes flow everywhere they're used automatically.
This decision is not final until this issue has received maintainer votes in the form of comments or reacts, and community feedback one way or the other.

I'm in favor of the the high level decision of using a common Bootstrap/Config API for the kube and local subcommands and split up
I would like us to broadly agree on the config hierarchy principles and how other common nouns would be placed.
We can tackle this here or in https://github.com/envoyproxy/gateway/issues/29 i.e.

Is the platform union a top level field or an inner field within a top level common noun such as configSource

xref https://github.com/envoyproxy/gateway/issues/106#issuecomment-1152619680 for capturing decisions in the design doc.

Is the platform union a top level field or an inner field within a top level common noun such as configSource.

IMHO platform is the top-level field that replaces configSource. However, let's not debate the field name in this issue. Let's move the discussion to https://github.com/envoyproxy/gateway/issues/29.

a common core struct config, plus a platform union field. This common core will hold configuration like logging levels, debug, and other things that every deployment type will need.

+1 with the caveat of not defining the name of the union discriminator, e.g. platform here. As @arkodg mentions, let's resolve this detail in https://github.com/envoyproxy/gateway/issues/29.

individual platform config structs, selected using the platform union field.

+1 with the caveat of not defining the name of the union discriminator, e.g. platform here. As @arkodg mentions, let's resolve this detail in https://github.com/envoyproxy/gateway/issues/29.
Simply replace platform with a TBD and you have my +1 on both bullet points.

The issue with a union type is that only one field can be set, whereas EG may get its runtime config from multiple sources, e.g. file and HTTP server (non-k8s environments). To continue with the above example, I suggest pluralizing platform and validating the list to ensure only supported combinations are allowed. For example:
Run EG on Kube:
loggingLevel: <something, depends on logging library>
debug: true|false
platforms:
  - kubernetes:
     # Kubernetes-specific config goes here.

Run EG on Docker:
loggingLevel: <something, depends on logging library>
debug: true|false
platforms:
  - docker:
     # Docker-specific config goes here.

Run EG on Linux:
loggingLevel: <something, depends on logging library>
debug: true|false
platforms:
  - linux:
     # Linux-specific config goes here.

I think that we need to keep in mind that there are really three things that we need to configure:

How does Envoy (proxy) get provisioned and managed by Envoy Gateway? In Kubernetes, the provisioner will create Kubernetes objects etc. In non-Kubernetes deployments, I can think of a lot of things that could be done, but they all share the idea that they're going to do something on the machine where provisioner is running.
Where does Envoy Gateway get the Gateway API resource representations from? In Kubernetes, this is the apiserver. I think it's in non-Kubernetes that the greater complexity is involved.
Where does the xds server get service discovery info (Services and Endpoints in Kubernetes terms) from? In Kubernetes, that's the apiserver again, and in non-kubernetes, this could be one of a variety of options (as discussed in https://github.com/envoyproxy/gateway/issues/105#issuecomment-1152783573).

I think this comes down to what we consider the "platform" field to be doing. In my mind, I had it handling mainly the first item - and in the Kubernetes case, that implies the Kubernetes variants of the second and third items.
Let's talk more about this in our June 14th meeting, and update after.

How does Envoy (proxy) get provisioned and managed by Envoy Gateway?

The data plane (Envoy proxy) provisioning is based on EG's runtime provider configuration. If runtimeconfig.spec.provider.kubernetes is set (can be the default), the kube provider is used. The kube provider is implemented as a controller-runtime manager/controller that is responsible for provisioning/managing/operating the data plane infra using the kube API and kube resources, e.g. Deployment, Service, etc. The above link provides add'l detail on this topic for other provider types, e.g. File provider.

Where does Envoy Gateway get the Gateway API resource representations from?

Where the dynamic config is fetched, is based on EG's runtime provider configuration. If runtimeconfig.spec.provider.kubernetes is set, EG will use the controller-runtime client to fetch these resources from the kube API. The above link provides add'l detail on this topic for other provider types, e.g. File provider.

Where does the xds server get service discovery info (Services and Endpoints in Kubernetes terms) from?

The service discovery mechanism used is based on EG's runtime provider configuration. If runtimeconfig.spec.provider.kubernetes is set, EG will use kube's native service discovery. EG will lookup Endpoints of the Service to populate EDS. When running EG with a provider that does not natively support service discovery (File provider), proxied clients/backends must be reachable by DNS, and users must annotate the backend Service with a FQDN. EG will use the FQDN for SDS and query DNS for the A records needed to form the EDS. In the future, EG could support ExternalDNS, Consul, etc. providers to provide a more comprehensive service discovery solution for non-kube use cases.
Note: Service discovery is only provided for the Kubernetes provider when the HTTPRoute backendRefs references a Service.


[Explorer] Adds Amount to the Recent Transactions Table

This adds the amount of Sui Transferred to the Recent Transactions Table

For the empty case, we should render a - as seen on the design: https://www.figma.com/file/kSD0qXCIDZA4KQVNepA5hR/02-Explorer?node-id=67%3A18955

yes, except for the empty space, this seems fine.

I've replaced the empty space with the -- placeholder:


describe how to mock/spy class specific method

Summary
I believe it would be useful for other users to know how to mock/spy just some method of a class.
Following these examples here:
https://stackoverflow.com/a/56565849/1538604
Test plan
no test required, this is just documentation

thanks @Biki-das!!
Please could you explain that a bit more? I dont know what you mean with the main docs folder...
This is just an edit of this file  website/versioned_docs/version-27.4/Es6ClassMocks.md
Thanks very much

thanks @Biki-das!! Please could you explain that a bit more? I dont know what you mean with the main docs folder... This is just an edit of this file  website/versioned_docs/version-27.4/Es6ClassMocks.md
Thanks very much

@Biki-das got it ;)

Codecov Report

Merging #12257 (f2ea1ac) into main (5d483ce) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #12257   +/-   ##
=======================================
  Coverage   67.51%   67.51%
=======================================
  Files         328      328
  Lines       17246    17246
  Branches     5071     5071
=======================================
+ Hits        11643    11644    +1
+ Misses       5570     5569    -1
  Partials       33       33

Impacted Files
Coverage Δ

packages/expect/src/utils.ts
96.53% <0.00%> (+0.49%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d483ce...f2ea1ac. Read the comment docs.

@Biki-das
Great! could you approve then ? thanks

@Biki-das
Great! could you approve then ? thanks

I am not a official maintainer of this repo, i just contribute and help out to contribute, @SimenB  approves it

hey @SimenB , sorry for the late update.
I have updated the rest of the versioned docs, and also run prettier aganist the changes, to ensure the correct format :)


Cannot read property 'apply' of undefined

Hi I am hoping to use this plugin but I have encountered a problem right off the start.
I get the error that i put for a title when trying to initialize the plugin.
I get this when console logging out the code I use to call "chosen" on
here is my code:
console.log(jQuery(".select-with-image"));
jQuery(".select-with-image").chosen({ width:"100%", });
Here is the result of console.log():
[select#Suits_Upper_Breast_Pocket.select-with-image, select#Suits_Elbow_Patches.select-with-image, select#Suits_Jacket_Vents.select-with-image, select#Suits_Double_Breasted_Lapel.select-with-image, select#Suits_Single_Breasted_Lapel.select-with-image, select#Suits_Lower_Pocket.select-with-image, select#Suits_Monogram_Options.select-with-image, select#Suits_Jacket_Pick_Stitching.select-with-image, select#Suits_Sleeve_Button_Holes.select-with-image, select#Trousers_Pockets.select-with-image, select#Trousers_Belt_Loop.select-with-image, select#Trousers_Pleat_Style.select-with-image, select#Trousers_Cuff_Style.select-with-image, select#Vests_Collar_Style.select-with-image, select#Vests_Top_collar_use_fabric.select-with-image, select#Vests_Lapel_ingredient_style.select-with-image, select#Vests_Button_style.select-with-image, select#Vests_Lower_pocket_style.select-with-image, select#Vests_Ticket_pocket_style.select-with-image, select#Vests_Back_style.select-with-image, select#Vests_Back_use_fabric_style.select-with-image, select#Vests_Back_lining_using_fabric_style.select-with-image, select#Vests_Back_belt_use_fabric_style.select-with-image, select#Vests_Outside_top_stitch.select-with-image, select#Vests_Button_hole_style.select-with-image, select#Vests_Outside_Pick_stitching_color.select-with-image, select#Shirts_Collar_Styles.select-with-image, select#Shirts_Cuff_Styles.select-with-image, select#Shirts_Pocket_Styles.select-with-image, select#Shirts_Back_style.select-with-image, select#Shirts_Monogram_Options.select-with-image, selector: ".select-with-image", prevObject: n.fn.init[1], context: document]
So not sure why it would say undefined, maybe this is not a problem with the plugin.

I wasn't able to re-create the issue,
Can you please provide a working example, try using https://jsfiddle.net/

It is probably something to do with the way I am appending the elements to
the DOM.
My application is very complicated I do not know how to recreate the
problem.
Anyway I have moved on to making my own solution using bootstrap dropdowns.
Thanks for your help.
On Wed, Sep 7, 2016 at 10:58 PM, Adnan M.Sagar, PhD <
<EMAIL_ADDRESS>wrote:

I wasn't able to re-create the issue,
Can you please provide a working example, try using https://jsfiddle.net/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/websemantics/Image-Select/issues/31#issuecomment-245480334,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQhRDZNjVY_b1Crxo3fGuTQxU1UpRCSyks5qn3njgaJpZM4J2Fkc
.

You should not have to append the elements to the DOM dynamically. If you had to, this plugin doesn't support that and that's probably why your could get it to work!,
Good luck wit the bootstrap solution,


Hotfix contributing.md

@benbp reached out with

Hey I was walking your contributing and...

Need to fix this!

/check-enforcer override


Remove remaining notions of the clear password field

Apparently, in #14 not all notions of the clear field were removed. This may have lead us to #35 and #36, where patches have been proposed which were supposed "fix" non-handling of that field in the code (basically by undoing #14).
We should get rid of these remnants.
@Udera, would you perhaps like to do this?

The files that seem to be still affected are under docs and setup:

docs/configure
docs/database-spec.txt
docs/clients/mysql-popper.conf
setup/create_db.pl
setup/mysql.sql
setup/pgsql.sql

I can have a look into it, removing it shouldn't be a problem.
I was wondering what happens with users who want to update their setup? This requires more migration steps (some might want to change the hashing algorithm as md5 is probably not state of the art).

AFAIK, Exim4U has written some migration scripts, we should see if we could reuse that.
But frankly speaking, I'm not sure the current Vexim codebase is worth improving. Coding standards and practices have improved a lot since it was written, so it might be (and I think it is) better to just rewrite it from scratch, using a contemporary approach (modern PHP5 framework, separation of php code from templates etc.). Ideally, the framework would have built-in support for migrations (and migration generations), so we could concentrate on writing and improving business logic instead of dealing with a constantly increasing amount of database versions we have to migrate from.
In #33, @Z3po suggested something similar: his idea is that we should ship this release and start working on a new one. I think, this could be our chance to start from the ground up. Would you be interested in that?

You are probably right with a new start and your ideas sound good. I would be happy to help out but I have to say that I'm not a software developer.

I'd vote for that, too.
Let's build up a "clean" stable release (probably with the clear-field back in.
I'm no web developer either but would be happy to add some lines of code when having time for it...

I don't think we really want the clear field back. Unless I misunderstood what you meant. :)

So we have 2 issues here:

nobody likes to have the clear field. I agree with that, but:
we've introduced the clear field and don't have any migration scripts ready for removing it within the already existing mysql tables...

So I see the following approaches:

freeze with the clear removed and have "broken" database setups
freeze with the clear fiels being supported/used and clean it up in database upgrade scripts

I have no Problems with keeping it removed but I know how to alter the tables....
we could also just remove it and check for existance in later migration scripts to finally clean it up succesfully...should work, too.
I'm not sure about the "best" way here.

If you set up the current state of Vexim now, I think the clear field would exist in the database, but it would never be filled in by anything. So basically, it would be non-functional.
I guess we could remove it completely by writing migration scripts, release Vexim v. 2.2 (or whatever) and be done with this old codebase.Would that be a good way?

agree.

To make it work for everybody, we could copy the content of the clear-fild (clear-text password) into the crypt field. Then we can delete the clear field and set the cryptscheme to clear https://github.com/avleen/vexim2/blob/master/vexim/config/variables.php#L35.
Advantage: this approach works for everybody, in a further step the clear-password can then be converted to any hash-method (md5, sha1, sha2, ...).

Ok, I prepared a pull request https://github.com/Udera/vexim2/commit/cbc2f19482980acf99e5e36ba8f2eb94332c94b0
But I still have to put a switch in the installer-script, if the password is clear or hashed.

Re installer script, are you talking about create_db.pl? If so, yeah, you can probably add a switch.
BTW, I've downloaded all versions of Vexim I could find to a VM. I'm thinking about probably attempting to write a universal migration script for Vexim4, if that ever happens. I haven't yet looked at how often the DB schema changed, perhaps there isn't much to write really...
Regarding Exim not supporting some hash algos: I think this should be mentioned, yes, but I don't think we absolutely MUST ship example configs for all other means of authentication. If there are some bits we don't know, we can simply say that we don't know. It's up to our user to choose a right algorithm wisely.
Regarding Courier: incidently, that's what I'm using at the moment. Here are working authenticators against courier-authdaemon (I'm not really sure where I have them from, could be Debian; also bear in mind that some of these uppercase macros are probably defined elsewhere in Debian files):
# Authenticate against courier authdaemon

# This is now the (working!) example from
# http://www.exim.org/eximwiki/FAQ/Policy_controls/Q0730
# Possible pitfall: access rights on /var/run/courier/authdaemon/socket.
 plain_courier_authdaemon:
   driver = plaintext
   public_name = PLAIN
   server_condition = \
     ${extract {ADDRESS} \
               {${readsocket{/var/run/courier/authdaemon/socket} \
               {AUTH ${strlen:exim\nlogin\n$auth2\n$auth3\n}\nexim\nlogin\n$auth2\n$auth3\n} }} \
               {yes} \
               fail}
   server_set_id = $auth2
   .ifndef AUTH_SERVER_ALLOW_NOTLS_PASSWORDS
#  server_advertise_condition = ${if or {{eq{$tls_in_cipher}{}}{eq{$host_address}{$received_ip_address}}}{}{*}}
#  server_advertise_condition = ${if eq{$tls_in_cipher}{}{}{*}}
   server_advertise_condition = ${if or{\
       {!eq{$tls_cipher}{}}\
       {match_ip {$sender_host_address}{@[]}}\
        }\
        {*}{}}
   .endif

 login_courier_authdaemon:
   driver = plaintext
   public_name = LOGIN
   server_prompts = Username:: : Password::
   server_condition = \
     ${extract {ADDRESS} \
               {${readsocket{/var/run/courier/authdaemon/socket} \
               {AUTH ${strlen:exim\nlogin\n$auth1\n$auth2\n}\nexim\nlogin\n$auth1\n$auth2\n} }} \
               {yes} \
               fail}
   server_set_id = $auth1
   .ifndef AUTH_SERVER_ALLOW_NOTLS_PASSWORDS
#  server_advertise_condition = ${if or {{eq{$tls_in_cipher}{}}{eq{$host_address}{$received_ip_address}}}{}{*}}
#  server_advertise_condition = ${if eq{$tls_in_cipher}{}{}{*}}
   server_advertise_condition = ${if or{\
       {!eq{$tls_cipher}{}}\
       {match_ip {$sender_host_address}{@[]}}\
        }\
        {*}{}}
   .endif

By the way, regarding the clear field: from my understanding, it should work even without data conversion, no?

It depends, if someone used the clear-field in the exim-authenticator and the imap-authenticator.

You convert the database and create/recreate the salted hashes, but you always need to modifier the authenticator-section of exim and imap manually, and the variables of vexim.

I made a pull request: https://github.com/avleen/vexim2/pull/53
I will have a look into the perl script and the switch (I'd like to add SHA512). Then we need to check exim, dovecot, and courier configuration.

Fixed in #53. Thanks @Udera !


Consider Docker to Reduce CI Overhead

In https://github.com/KhronosGroup/OpenCL-Headers/issues/142 @oddhack says

N.b. you might consider building a Docker image containing all the right components for this. Even just updating the apt database and installing components from cmake 96 times (# of jobs in the Linux job matrix) takes considerable time.

Sound sensible, I imagine that the test matrix spends far more time on apt that actually building/testing the headers themselves.

BTW we have a repo for Khronos Dockerfiles in https://github.com/KhronosGroup/DockerContainers - can just add yours and use Ryan's build-and-push script to get the image into dockerhub.


Pong Crash - Panic

Tinkering around with this one, I found that the pong game crashes after about a minute of playing.
Let me know if you need any more information!
OS: macOS 14.2.1
godot --version: 4.2.2.stable.official.15073afe3
go version: go version go1.22.4 darwin/amd64
Version: 825f292
Godot Engine v4.2.2.stable.official.15073afe3 - https://godotengine.org
Vulkan API 1.2.231 - Forward+ - Using Vulkan Device #0: AMD - AMD Radeon Pro 5500M

2024-08-14 16:00:10.909 godot[67047:77532129] WARNING: AVCaptureDeviceTypeExternal is deprecated for Continuity Cameras. Please use AVCaptureDeviceTypeContinuityCamera and add NSCameraUseContinuityCameraDeviceType to your Info.plist.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x11990475a]

goroutine 17 [running, locked to thread]:
main.(*PongPaddle).OnAreaEntered(0xc0000c80e0, {{0x0?, 0xc0004cef90?}, 0x11acabc00?}, {{}, {{}, {0x0, 0xc0003c65c0}}})
        /Users/$USER/Projects/grow-grpahics-eg/2d/pong/pong.go:79 +0xda
reflect.Value.call({0x119db7000?, 0xc0000c80e0?, 0xc000200698?}, {0x119917c1d, 0x4}, {0xc0003001b0, 0x2, 0x118f4224c?})
        /usr/local/go/src/reflect/value.go:596 +0xca6
reflect.Value.Call({0x119db7000?, 0xc0000c80e0?, 0xc0004cef90?}, {0xc0003001b0?, 0xc00006a008?, 0xc0003c6580?})
        /usr/local/go/src/reflect/value.go:380 +0xb9
grow.graphics/gd.registerMethods.func1({{0x1695, 0xc0004cef90}, 0x11acabc00}, {0x119dd9ea0, 0xc000196450}, {0xc000610250, 0x1, 0x118f4e04d?})
        /Users/$USER/go/pkg/mod/grow.graphics/gd@v0.0.0-20240710064531-edc03e71dbe9/register_methods.go:77 +0x48b
grow.graphics/gd/gdextension.method_call(0x11?, 0x15, 0x7ff7bcce1610, 0x1, 0x7ff7bcce13d8, 0x7ff7bcce1380)
        /Users/$USER/go/pkg/mod/grow.graphics/gd@v0.0.0-20240710064531-edc03e71dbe9/gdextension/gdextension_interface.go:2599 +0x318
signal: abort trap```

**Replication steps:**
1. clone repo
2. change directory t o2d/pong
3. execute `gd` and it opens the project in godot
4. close project
5. execute `gd run`

**Expected results:**
The game runs

**What happens instead:**
The game crashes with the above error

Thanks for reporting, this looks like it could be the same issue as https://github.com/grow-graphics/gd/issues/44
I've pushed a possible mitigation for this, I haven't been able to reproduce this issue on any of my machines so please do let me know if the issue still occurs with the latest commit.

Nice one! I'll see if I can replicate it shortly.

I can no longer replicate this one, nice!


Added consumer - Syncfusion JS UI Components

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: bharathm03 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


XDebug dissapear after click on Step Over (F10) button after updating to Version 1.2.0

From @slaveofcode on June 7, 2016 4:44

VSCode Version: 1.2.0
OS Version: Ubuntu 14.04

Steps to Reproduce:

Start debugging F5 (xdebug)
Go to browser and refresh url related to the breakpoint
Debug catched on breakpoint
Click on Step Over F10
Step Over button disabled, looks like not active / not available
List Variables on the left side was gone, but Call Stack values still exist

Copied from original issue: Microsoft/vscode#7294

@slaveofcode xdebug is php?

Duplicate of #39


remove unused variables with deadnix

Description of changes
Things done

[ ] Tested the changes in your own NixOS Configuration
[ ] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input

@mergify queue


assertion failed: self.historic_layers.remove(&LayerRTreeObject::new(layer)).is_some()

Steps to reproduce
Investigating.
Expected result
No panics
Actual result
One task panicked. Additionally this caused problems for other tenants. Other tenants became unavailable.
Part of the log containing stacktrace:
2023-01-19T16:15:20.672271Z  INFO download complete: /storage/pageserver/data/tenants/X/timelines/Y/000000067F00004002000004EB0000000007-030000000000000000000000000000000002__0000>
2023-01-19T16:15:20.576264Z  INFO synthetic_size_worker:calculate_synthetic_size{tenant_id=X}:gather_size_inputs{tenant_id=X}: on-demand downloading remote layer remote 73e1f731e8>
thread 'background op worker' panicked at 'assertion failed: self.historic_layers.remove(&LayerRTreeObject::new(layer)).is_some()', /home/nonroot/pageserver/src/tenant/layer_map.rs:397:9
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:575:5
   1: core::panicking::panic_fmt
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/panicking.rs:65:14
   2: core::panicking::panic
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/panicking.rs:115:5
   3: pageserver::tenant::layer_map::LayerMap<L>::remove_historic
             at /home/nonroot/pageserver/src/tenant/layer_map.rs:397:9
   4: pageserver::tenant::timeline::Timeline::download_remote_layer::{{closure}}::{{closure}}::{{closure}}
             at /home/nonroot/pageserver/src/tenant/timeline.rs:3086:25
   5: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/future/mod.rs:91:19
   6: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::future::future::Future>::poll
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/panic/unwind_safe.rs:296:9
   7: <futures_util::future::future::catch_unwind::CatchUnwind<Fut> as core::future::future::Future>::poll::{{closure}}
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-util-0.3.25/src/future/future/catch_unwind.rs:36:42
   8: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/panic/unwind_safe.rs:271:9
   9: std::panicking::try::do_call
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:483:40
  10: std::panicking::try
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:447:19
  11: std::panic::catch_unwind
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panic.rs:137:14
  12: <futures_util::future::future::catch_unwind::CatchUnwind<Fut> as core::future::future::Future>::poll
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-util-0.3.25/src/future/future/catch_unwind.rs:36:9
  13: <tokio::task::task_local::TaskLocalFuture<T,F> as core::future::future::Future>::poll::{{closure}}
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.24.1/src/task/task_local.rs:348:35
  14: tokio::task::task_local::LocalKey<T>::scope_inner
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.24.1/src/task/task_local.rs:233:19
  15: <tokio::task::task_local::TaskLocalFuture<T,F> as core::future::future::Future>::poll
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.24.1/src/task/task_local.rs:345:13
  16: <tokio::task::task_local::TaskLocalFuture<T,F> as core::future::future::Future>::poll::{{closure}}
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.24.1/src/task/task_local.rs:348:35
  17: tokio::task::task_local::LocalKey<T>::scope_inner
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.24.1/src/task/task_local.rs:233:19
  18: <tokio::task::task_local::TaskLocalFuture<T,F> as core::future::future::Future>::poll
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.24.1/src/task/task_local.rs:345:13
  19: pageserver::task_mgr::task_wrapper::{{closure}}
             at /home/nonroot/pageserver/src/task_mgr.rs:326:9
  20: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/future/mod.rs:91:19
  21: tokio::runtime::task::core::Core<T,S>::poll::{{closure}}
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.24.1/src/runtime/task/core.rs:223:17
  22: tokio::loom::std::unsafe_cell::UnsafeCell<T>::with_mut
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.24.1/src/loom/std/unsafe_cell.rs:14:9
  23: tokio::runtime::task::core::Core<T,S>::poll
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.24.1/src/runtime/task/core.rs:212:13
  24: tokio::runtime::task::harness::poll_future::{{closure}}
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.24.1/src/runtime/task/harness.rs:476:19
  25: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/core/src/panic/unwind_safe.rs:271:9
  26: std::panicking::try::do_call
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:483:40
  27: std::panicking::try
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:447:19
  28: std::panic::catch_unwind
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panic.rs:137:14
  29: tokio::runtime::task::harness::poll_future
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.24.1/src/runtime/task/harness.rs:464:18
  30: tokio::runtime::task::harness::Harness<T,S>::poll_inner
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.24.1/src/runtime/task/harness.rs:198:27
  31: tokio::runtime::task::harness::Harness<T,S>::poll
             at /home/nonroot/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.24.1/src/runtime/task/harness.rs:152:15
  32: tokio::runtime::scheduler::multi_thread::worker::Context::run_task
  33: tokio::runtime::scheduler::multi_thread::worker::Context::run
  34: tokio::macros::scoped_tls::ScopedKey<T>::set
  35: tokio::runtime::scheduler::multi_thread::worker::run
  36: tokio::loom::std::unsafe_cell::UnsafeCell<T>::with_mut
  37: tokio::runtime::task::core::Core<T,S>::poll
  38: tokio::runtime::task::harness::Harness<T,S>::poll
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
2023-01-19T16:15:20.873463Z ERROR Task 'download layer 000000067F00004002000004EB0000000007-030000000000000000000000000000000002__000000001E6DE619-000000001E7B0B41' tenant_id: Some(X),  timeline_id: Some(Y) panicked: Any { .. }
2023-01-19T16:15:20.873542Z ERROR synthetic_size_worker: failed to calculate synthetic size for tenant 1acf99ebac0

Environment
prod
Logs, links

https://sentry.io/organizations/neondatabase/issues/3882302422/?environment=production&project=4504220031582208&query=is%3Aunresolved&referrer=issue-stream

Most probably this assertion doesnt play well with on-demand download

But it seems to me that even with on-demand download layer map at page server should contain all layers, shouldn't it?

It should. The error happens when we've downloaded a layer and trying to remove existing remote layer and replace it with downloaded one. Looking further

This is the sequence:
2023-01-19T13:11:06.337285Z  INFO attach{tenant_id=X}:load_remote_timeline{timeline_id=Y}:reconcile_with_remote: remote layer does not exist locally, creating remote layer: 000000067F00004002000004EB0000000007-030000000000000000000000000000000002__000000001E6DE619-000000001E7B0B41
2023-01-19T16:15:20.576264Z  INFO synthetic_size_worker:calculate_synthetic_size{tenant_id=X}:gather_size_inputs{tenant_id=X}: on-demand downloading remote layer remote Y/000000067F00004002000004EB0000000007-030000000000000000000000000000000002__000000001E6DE619-000000001E7B0B41
2023-01-19T16:15:20.576240Z  INFO synthetic_size_worker:calculate_synthetic_size{tenant_id=X}:gather_size_inputs{tenant_id=X}: need remote layer remote Y/000000067F00004002000004EB0000000007-030000000000000000000000000000000002__000000001E6DE619-000000001E7B0B41
2023-01-19T16:15:20.672271Z  INFO download complete: /storage/pageserver/data/tenants/X/timelines/Y/000000067F00004002000004EB0000000007-030000000000000000000000000000000002__000000001E6DE619-000000001E7B0B41
thread 'background op worker' panicked at 'assertion failed: self.historic_layers.remove(&LayerRTreeObject::new(layer)).is_some()', /home/nonroot/pageserver/src/tenant/layer_map.rs:397:9
stack backtrace:

2023-01-19 13:11:06 | 2023-01-19T13:11:06.337285Z  INFO attach{tenant_id=1acf99ebac07d01ea7abf3bd104e8e55}:load_remote_timeline{timeline_id=73e1f731e8bfd33e54f239d8e20c8a2d}:reconcile_with_remote: remote layer does not exist locally, creating remote layer: 000000067F00004002000004EB0000000007-030000000000000000000000000000000002__000000001E6DE619-000000001E7B0B41 |
-- | -- | --
  |   | 2023-01-19 16:15:20 | 2023-01-19T16:15:20.576264Z  INFO synthetic_size_worker:calculate_synthetic_size{tenant_id=1acf99ebac07d01ea7abf3bd104e8e55}:gather_size_inputs{tenant_id=1acf99ebac07d01ea7abf3bd104e8e55}: on-demand downloading remote layer remote 73e1f731e8bfd33e54f239d8e20c8a2d/000000067F00004002000004EB0000000007-030000000000000000000000000000000002__000000001E6DE619-000000001E7B0B41 |
  |   | 2023-01-19 16:15:20 | 2023-01-19T16:15:20.576240Z  INFO synthetic_size_worker:calculate_synthetic_size{tenant_id=1acf99ebac07d01ea7abf3bd104e8e55}:gather_size_inputs{tenant_id=1acf99ebac07d01ea7abf3bd104e8e55}: need remote layer remote 73e1f731e8bfd33e54f239d8e20c8a2d/000000067F00004002000004EB0000000007-030000000000000000000000000000000002__000000001E6DE619-000000001E7B0B41 |
  |   | 2023-01-19 16:15:20 | 2023-01-19T16:15:20.672271Z  INFO download complete: /storage/pageserver/data/tenants/1acf99ebac07d01ea7abf3bd104e8e55/timelines/73e1f731e8bfd33e54f239d8e20c8a2d/000000067F00004002000004EB0000000007-030000000000000000000000000000000002__000000001E6DE619-000000001E7B0B41 thread 'background op worker' panicked at 'assertion failed: self.historic_layers.remove(&LayerRTreeObject::new(layer)).is_some()', /home/nonroot/pageserver/src/tenant/layer_map.rs:397:9 stack backtrace:

I have a hypothesis. In get_reconstruct_data here the comment says that download happens without holding the lock for layermap, which makes sense from one side, but on the other side while we're downloading the layer some other task (e g compaction) can remove that layer from the map, and when download finishes it will fail to replace old layer with a new one. This explanation makes sense to me, but I do not have the proof that this is the case

Update:
Per sync with @shanyp and @problame
The reason why this lead to unavailability is the incorrectly set shutdown_on_error flag for synthetic size calculation and shutdown_on_error not working (https://github.com/neondatabase/neon/issues/3402).
The above hypothesis still looks valid to me. @hlinnaka, wdyt? Do you think there can be other reasons for this behavior?
We need to decide what would be the proper fix. Available options:

Treat this as a normal scenario, insert the layer even if there is no layer exists to replace it

We need to verify that this will work correctly since it may resurrect layers after the deletion (most probably in compaction, less probably with gc).
Theoretically it can cause some perf degradation in case this resurrected layer participates in lookups (it shouldnt)
It will occupy space on disk, who and when will clean it up? Eviction? Gc? Tempfile + restart?

Come up with something like buffer pinning in postgres page cache. So we wont remove layers that have in-progress download

Can cause contention if we will wait until things get downloaded
Will be probably easier to reason about

We can do pinning, but cancel the download task in case we delete the layer

Need to be careful with cancellation, not leaving temp files behind, etc

The idea is to not rush the fix and do it properly. In the meantime I'll use a workaround for migration (download all layers script by @problame)

Correct me if I misremember, but we discussed we should first try to figure out how to reproduce this, then move on to ignoring/fixing it. Triple checked the logs, there's nothing to support the above hypothesis there for the today's case (assuming there was nothing for the earlier).
Doesn't reproduce locally with:

attach, background compaction, tenant_size
attach, tenant_size
attach, running compute, tenant_size
attach, running compute, compact, tenant_size

Did manage to reproduce the compute refuses to start with sent tarball but didn't record it. This was on a local dev build with incremental compilation.

Too much filtering with reading the logs hid the fact that we have a gather_size inputs happening throughout gc's:
2023-01-24T04:49:32.479138Z  INFO Calculating logical size for timeline Y at 0/1F3A1FA8
2023-01-24T04:49:57.065908Z <gc>
2023-01-24T04:49:57.065937Z </gc>
2023-01-24T04:49:57.097184Z <periodic layer flush>
2023-01-24T04:49:57.098433Z </periodic layer flush>
2023-01-24T04:51:37.114227Z <multiple gcs>
2023-01-24T04:58:17.319972Z </multiple gcs>
2023-01-24T04:59:32.437036Z <layer download>
2023-01-24T04:59:32.529892Z </layer download>
panic

As this pattern without panic repeats throughout logs I think it's quite safe to assume the hypothesis is accurate.
TODO (I'll edit):

was the cpu usage at the time high enough to warrant 10s time to list_rel's or what could this had been?

@problame suggested I use failpoint to grow the logical_size_calculation length to cover gc but I don't think that should be enough, even if layers were removed because we didn't see the affected layer being removed anywhere.
I am thinking of following solutions:

fix Arc::ptr_eq to be Arc::as_ptr(...) as *const () == Arc::as_ptr(...) as *const () instead

for me this seems most suspicious right now
compare only data, ignoring vtable
rust issue of a possible upcoming change: https://github.com/rust-lang/rust/issues/103763
still in use of the latest main: https://github.com/neondatabase/neon/blob/572332ab50b2d87fa15b11b2c8c1f9e1313c915b/pageserver/src/tenant/layer_map.rs#L297

ignoring, no panic, no logging

I understand LayerKey to be the closest analog: https://github.com/neondatabase/neon/blob/572332ab50b2d87fa15b11b2c8c1f9e1313c915b/pageserver/src/tenant/layer_map.rs#L282-L286
no changes required

Don't want to edit https://github.com/neondatabase/neon/issues/3387#issuecomment-1402279794 completly, so adding fixes here:
Looking now, it seems that Calculate logical size for timeline Y at LSN happened every 10min. On the logs it appears that the last gc completed around 15s before the next tenant_size calculation, for which we observe:

need to on-demand download
on-demand download completion
panic while trying to replace on layer map
finally we have a log message describing that it was the Tenant::refresh_gc_info which failed:2023-01-24T04:59:32.805866Z ERROR synthetic_size_worker: failed to calculate synthetic size for tenant 1acf99ebac07d01ea7abf3bd104e8e55: Failed to refresh gc_info before gathering inputs

Tenant::gather_size_inputs calls Tenant::refresh_gc_info first, only later it starts to calculate logical sizes, which explains why there is no Calculating logical size for Y at LSN message.
So to clarify, logical size calculation was no running throughout the gc's. Marking my previous comment outdated. Will now inspect the pitr calculation to see if there's anything obviously wrong there.

After a bit of detour with #3446 my latest idea for reproduction: https://github.com/neondatabase/neon/commit/91b6ac2043bc8535f28dd7088e4409074e19fca2 (in commit message). Still not there.

Going back and forwards on the Timeline::find_lsn_for_timestamp(pitr_timestamp) with timestamps, it always finds Present(0/1F3B4E80) and no other value. Unsure what this means.

Reproduced the layer download itself with the release-2722 binary (sha256: dbbde2386583ba8f138ab813a116c84e499d53e73d229233b313daf0f8657e22) by just the refresh_gc_info, no panic. This required a highly hacky time-specific tenant configuration:
[tenant_config]
pitr_interval = "713007s"
gc_horizon = 87772040

Where pitr horizon is near select extract (epoch from ('7 days' + (('now'::timestamptz) - ('2023-01-25 06:34:32.436+00:00'::timestamp))));.

As later found out in #3589 we always fail with "cannot iterate a remote layer" for RemoteLayer's so it cannot be compaction related (should compaction had touched a RemoteLayer, it would had failed).

Let's close this issue because the code is gone?

Related problematic/missed log line is now changed after #3664 as https://github.com/neondatabase/neon/pull/3431#issuecomment-1440328364.
I think this could be closed, unless we want to still try reproduce it with the old binary. To recap, since then or inspired by this issue we've:

(switched away from rtree to different impl)
#3513
#3573

lets close this one


fix git related issue #905

Description
Fix git issue with unsafe directory
Fixes #905
Type of Change

Minor bug fix (non-breaking small changes)

How Has This Been Tested?
Automated Testing
Run workflow
Manual Scenario
Was tested using workflow [M] UTBot Java: build and run tests
Checklist (remove irrelevant options):

[ ] Check workflow finishing successfully

Also Docker image fixed (git added). See related PR


openapi-2.38-update

Problem
Update to the OpenAPI spec
Solution
Updated the OpenAPI spec from 2.37 to 2.38

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Unable to launch debugger worker process

Issue Type: Bug
Create a console app in .net core 2.2 in Fedora 30 with KDE desktop.
Set "console" to "externalTerminal" in launch.json and try to start the debugger.
A dialog appears with this message:
"Unable to launch debugger worker process (vsdebug) through the terminal. can't find terminal application 'dumb'".
I have Konsole and gnome terminal installed. It works fine in gnome desktop but not KDE.
Thanks. :)
VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:55:08.091Z)
OS version: Linux x64 5.1.16-300.fc30.x86_64

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz (8 x 3589)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: unavailable_offviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
15.55GB (9.17GB free)

Process Argv
--unity-launch

Screen Reader
no

VM
0%

Extensions (16)

Extension
Author (truncated)
Version

ng-template
Ang
0.800.0

npm-intellisense
chr
1.3.0

path-intellisense
chr
1.4.2

gitlens
eam
9.8.5

vscode-html-css
ecm
0.2.0

beautify
Hoo
1.5.0

csharpextensions
jch
1.3.0

docomment
k--
0.1.8

cpptools
ms-
0.24.0

csharp
ms-
1.20.0

vs-keybindings
ms-
0.2.0

vsliveshare
ms-
1.0.509

vsliveshare-audio
ms-
0.1.59

debugger-for-chrome
msj
4.11.6

vscode-icons
vsc
8.8.0

html-css-class-completion
Zig
1.19.0

Please see attached the screenshot of the message.

Please see below my launch.json file:
{    // Use IntelliSense to find out which attributes exist for C# debugging    // Use hover for the description of the existing attributes    // For further information visit https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md    "version": "0.2.0",    "configurations": [         {             "name": ".NET Core Launch (console)",             "type": "coreclr",             "request": "launch",             "preLaunchTask": "build",             // If you have changed target frameworks, make sure to update the program path.             "program": "${workspaceFolder}/VM.UI/bin/Debug/netcoreapp2.2/VM.UI.dll",             "args": [],             "cwd": "${workspaceFolder}/VM.UI",             // For more information about the 'console' field, see https://aka.ms/VSCode-CS-LaunchJson-Console             "console": "externalTerminal",             "stopAtEntry": false         },         {             "name": ".NET Core Attach",             "type": "coreclr",             "request": "attach",             "processId": "${command:pickProcess}"         }     ] }
Many many thanks.


Simplify wix files for SwiftFormat.

Use autogenerated GUIDs.
Merge the two wxs files into one.

Curious, is there anything that prevents someone on amd64 from installing the arm64 SwiftFormat msi?

@tristanlabelle I think that WI does flag that as incompatible.  If not, we should aid it in that.

Congratulations! 🎉 You just became the new WiX expert on the team! Now @compnerd is going to assume you can fix any and all WiX issues 😉.

Seems like a completely reasonable assumption to me!  It is how it works isn't it? 😆


KDE contains emoji picker app, but no emojis

Describe the bug

To Reproduce
Steps to reproduce the behavior:

boot graphical plasma iso
open emoji app

Expected behavior
have emojis to pick
Additional context
we need full support for emojis to be a serious desktop distro in 2020
in browsers, text editors and terminal!
Notify maintainers

Metadata
nixos-plasma5-20.09beta538.0cfe5377e89-x86_64-linux.iso
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

reproed

Still an issue.

can't repro on master


Dynamically add the loaded packages

As highlighted by @himmitta the packages that are loaded are static. An idea is to make this dynamic based on the called classes.

Extract package
Add to a set of loaded packages
Loaded set of packages

This is no in 2.11.11


How to download blob url like blob://https://xyz.com/56477621239-90898721-9878954

Bug description:
I need to download a pdf file which is blob url. I have implemented normal method but finds nothing into it. It is downloading a blank file.
To Reproduce:
const { dirs } = RNFetchBlob.fs;
RNFetchBlob.config({
fileCache: true,
addAndroidDownloads: {
useDownloadManager: true,
notification: true,
mediaScannable: true,
title: test.png,
path: ${dirs.DownloadDir}/test.png,
},
})
.fetch('GET', nativeEvent.url.slice(5), {})
.then((res) => {
console.log('The file saved to ', res.path());
})
.catch((e) => {
console.log(e)
});
Expected behavior:
It should download the file png or pdf, which is coming in blob.
Screenshots/Videos:

Environment:

OS:Mac
OS version:Big Sur
react-native version:64
react-native-webview version:11>

I think you post your issue on the wrong project. See https://github.com/joltup/rn-fetch-blob/issues

@iranu ?


[internal] Remove digital river

Issue
https://maxioevolution.atlassian.net/browse/IN-387
Description
Remove digital river from code base


Add missing 'the' in Portal 2 quit message

Fixes a missing word in Cave Johnson's legendary quote

Haha, nice. Thanks!


Clarification on triggering events after release

The readme has the following line:

This will create a Release, as well as a release event, which could be handled by a third party service, or by GitHub Actions for additional uses, for example the @actions/upload-release-asset GitHub Action.

I think there should be some clarification that a release event created with the default github.token (or secrets.GITHUB_TOKEN), will not trigger another workflow. The user will have to use a personal access token for this to work.

@smac89 do I get it right that release event won't trigger at all?
After using create-release on the previous step ${{ github.event.release.tag_name }} is empty when using on the following one.
name: Test event.release.tag_name

on:
  push:
    tags:
      - "[0-9]+.[0-9]+"

jobs:
  release:
    name: Create Release
    runs-on: ubuntu-latest
    steps:
      - name: Create Release
        id: create_release
        uses: actions/create-release@v1
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          tag_name: ${{ github.ref }}
          release_name: ${{ github.ref }}

      - name: check tag
        if: ${{ github.event.release.tag_name }} == ''
        run: |
          echo Epic fail
          exit 1

@smac89 do I get it right that release event won't trigger at all?

@murlakatamenka I'm not too sure I understand your question. Using this create-release action will run the action, which will create a release.
My point in posting that issue comment is to point out that after this action runs, it will not trigger another workflow, if you used the default GITHUB_TOKEN secret for authentication (which you are using). You can see the link I referenced to read it for yourself.
Moreover, in your current setup, this workflow will not be able to get the payload from the release event. Why?
For two reasons:

*Since the event was triggered inside this workflow, it is not possible that you will see it within the same workflow that triggered the event.
Your workflow is not setup to be triggered when a release event occurs, i.e. your on section does not include release, only push.

*Actually I'm not too sure about the first reason, but I doubt workflows are able to see new events which occur after the workflow started. Don't quote me on that one, but you can test and see if it works.

I see, I understand it better now:

My point in posting that issue comment is to point out that after this action runs, the release event it creates will not trigger another workflow, if you used the default GITHUB_TOKEN secret for authentication (which you are using).

Thank you very much!

Is there a specific way to listen for release events? I have two workflows (one listening for release.published event, and one for tag)
The tag one creates a release using this action and the other one was supposed to start after, but it's not triggering.
Any suggestions on why that is happening?

Damn, I've spend a day trying to figure out why this
on:
  release:
    types:
      - published
      - created

is not triggered by releases created with this action, but successfully triggered by "manual" releases!
The docs definitely must note this…

Damn, I've spend a day trying to figure out why this
on:
  release:
    types:
      - published
      - created

is not triggered by releases created with this action, but successfully triggered by "manual" releases!
The docs definitely must note this…


handleInteractivePopGestureRecognizer handle wrong in some situations

General information
Bug report
I notice the method
- (void)jsq_handleInteractivePopGestureRecognizer:(UIGestureRecognizer *)gestureRecognizer
in JSQMessagesViewController.m
UIGestureRecognizerStateEnded state handler is equal to UIGestureRecognizerStateFailed or UIGestureRecognizerStateCancelled
[self.keyboardController beginListeningForKeyboard];             if (self.textViewWasFirstResponderDuringInteractivePop) {                 [self.inputToolbar.contentView.textView becomeFirstResponder];             }             if ([UIDevice jsq_isCurrentDeviceBeforeiOS8]) {                 [self.snapshotView removeFromSuperview];             }
Expected behavior
when InteractivePopGestureRecognizer finished  should endListeningForKeyboard and resignFirstResponder
Actual behavior
some times inputToolBar.textView becomeFirstResponder
my situation is JSQMessagesViewController is a childViewController and not easy to control life cycle

Fixed by 752fd38aa8b899cbe2e21b6595de58920977bfc2


How to add ytsearch: to tracks

Whenever i play youtube by doing ytsearch: i only get one audio to play. When i try to play multiple youtube audios, it just doesnt go the queue. After the first track gets played, the second one just doesn't play. I have the minimal code that's in the demo btw

https://github.com/sedmelluq/lavaplayer/blob/f1850fd725ecb25b0f98a520ae874863b405b9af/demo-jda/src/main/java/com/sedmelluq/discord/lavaplayer/demo/jda/Main.java#L80-L91
ytsearch loads a playlist of search results, so playlistLoaded is called. The example takes the easy route of queueing only the first track of that playlist (L85). If you want something different, you need to change this code.
Note that you can use AudioPlaylist#isSearchResult to tell regular playlists from search results.
If you need further support, please join the JDA Discord and ask in #lavaplayer.

It's all good now I thought that the queue was automatically adding my tracks from your code above and it wasn't. I had to explicitly call queue.add(track)


Timeout with satellite internet

On newer versions I'm unable to connect to RDP servers using high latency internet connection (ie satellite).
It worked fine at least with freerdp1 and remmina 1.3.x. and stopped working. I've tried with two different computers, using Linux Mint 19.3 and Ubuntu 20.04. When I use another internet connection, they work fine.
Running freerdp2 via bash, only get error "Timeout waiting for activation".
I couldn't find any config to increase timeout period, nor instructions how to compile it myself.
Please consider someone that eventually uses satellite internet, when he/she needs to access a server in a hurry, but before need to compile freerdp and remmina.
Please verify if there are any benefits reducing this timeout time. If possible, go back to the previous limit, or analyze if another error occurs. At least leave this limit configurable. I am available for more information and to test whatever is necessary.

@TupaNegreiros well, the timeout is already 15 seconds, so this is quite long. the /timeout:<time in ms> might be what you´re looking for (just run xfreerdp without arguments, then you get that one.

@akallabeth Thanks for your reply.
Could you confirm that default timeout value is 15000? Using any value >= 11000 ms I could connect (Although my internet delay isn't so big).

I have the same problem.  Pressed go on Update Mgr and spent the next 2 days trying to get Remmina to connect to a Windows box.  It turns out it's just my slow satellite internet  (HughesNet) - unbelieveable...    Is there a workaround?

@robertw1686 try on bash:
xfreerdp /u:username /v:servername /timeout:20000
Or else I use another computer with Windows, a Windows virtual machine or even a Raspberry with Remmina. 🤷♂


force_sort_within_sections with multi-line file docstring causes comments to be duplicated?

In https://github.com/RobotLocomotion/drake/pull/13709#pullrequestreview-451092149, I noticed that a comment was getting duplicated.
Managed to get a min repro here, using isort==5.1.2:
https://github.com/EricCousineau-TRI/repro/blob/e73591778217dff2937db6eae5155e5574d184c0/bug/isort_bug/code.py
Basically, the following source code:
"""
Multi-line docstring
"""
# Comment for A.
import a
# Comment for B - not A!
import b

gets transformed into this:
"""
Multi-line docstring
"""
# Comment for B - not A!
import a
# Comment for B - not A!
import b

(see the linked code.py for comparison)

Thanks for reporting! This is fixed in the 5.1.3 patch release

Sweet! Thanks for the speedy response!
(Just an xref: bf47b311f854d25a9161e9ae6cda709002bf3f77)

BTW I'm guessin' ya may already know, but here're GitHub's "magic words" for auto-closing issues via PRs or commits:
https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
I think this would've been auto-closed if you removed the intermediate "issue", e.g. "Fixed #1328: ..."


Added support for using chrome.storage.local and chrome.storage.sync in Converse

Converse uses the localForage for offline localstorage which offers drivers for localStorage, IndexedDB and WebSQL. Converse only offers localStorage, IndexedDB are configurable drivers for offline storage.
The localStorage driver is the fastest, but has a hard limit of 4MB. IndexedDB overcomes this limit, but is much slower. WebSQL is not supported on all browser platforms and may soon be deprecated.
Browser extensions have access to chrome.storage which offers local and sync drivers that offer more features. chrome.storage.local performs as fast as localStorage with no memory limits, while chrome.storage.sync has more limitations and restrictions, but offers storage that is synchronized across multiple platforms.
use the localforage browser extension storage driver to provide additional Converse storage drivers for Pade.

Done. Now available in version 1.6.11


Licensing?

Hi Nate,
I wasn't able to identify any licensing for this project. Do you have plans to license it for others to use?

Hey @hyandell! Thanks for opening an issue—I have always considered this code to be MIT licensed, but I had forgotten to add a LICENSE to make this explicit. I just did!

Thank you!


Reset numbering in IRB

IRB consent goes from 1.1, 1.12, 1.2, 1.3, need to reset the numbering.

fixed in 1ce7481ba3d02c18669f7df51160010f31ff1f9e


TH06 crashes if I tab out of fullscreen, then tab back in, while paused in practice mode

I'm on Windows 10.

Start th06 in fullscreen.
Tab out, and attach thprac to th06.
Tab in, and begin practice mode.
Pause.
Tab out, then tab back in. The game will crash, and an "Unhandled exception" error dialog will appear.

This issue does not occur during runs, or during practice mode unless the game is paused.
I have seen this in <IP_ADDRESS> and <IP_ADDRESS>, but not <IP_ADDRESS>.
thprac-20220922-192128-0486.zip

lol
thanks!


The channel descriptions in the discovery page is only shown when the app is launched

Test package: https://github.com/endlessm/endless-key-flatpak/actions/runs/6153210584 & Manatee 6.44-397
Each time you launch the app, you can see the channel description is there under the title in each card. (except for the feature channels)
However, if you reload the app, swtich to different tab and return to the discovery page or get into any channel then exit back to the discovery page, the desciption will be disappeared.
Screen recording 2023-09-12 5.01.59 PM.webm

Notice that it's replaced the subtitle (e.g., "Scuba Jack presents China.") with the channel icon (e.g., "Virtual Field Trips"). I don't know what's supposed to be the right thing, but this looks like a similar issue to #780.
I'm pretty sure it's supposed to show the channel icon since it tries to add the channel to the node. The card decides whether to show the channel icon or the subtitle based on whether the node.channel property is truthy. However, rootNodes is not necessarily populated when the page first loads, so addChannelToNode returns undefined.
Someone with a better understanding of the data model needs to figure out how to make this work synchronously with rootNodes.

@jprvita could you have a look at this? I believe the fix is one of:

Make this synchronized with rootNodes being populated somehow.
Do something like 424de8730eb3a7e72c961c0e838f927de2be4e71 where you get the channel data from ChannelResource and manually set it as node.channel rather than looking it up in rootNodes.

Just reproduced the issue that this can come and go in the current version of the Flatpak. I started the app and the description was there in the cards on the Discovery page. Then I opened a channel and closed it - description is gone. Closed the app and started again - description is there - opening closing a channel - description is gone.

After some digging: the cards in the page should always look the same:

Without a description
With the channel icon and title above the content title

But something regressed and when the app loads from the root URL (first launch) it is wrongly displayed (with description, without channel information).

As described above, it's because it expects to get the data from rootNodes, but there's no synchronization to ensure rootNodes is populated. Normally rootNodes wins that race, but it's less likely when the app is first launched and lots of models are being populated for the first time.
If you know how to make it synchronous, that would be great. Otherwise I would just have that code gather the channel data on its own and duplicate whatever mutations are supposed to happen.

If you know how to make it synchronous, that would be great. Otherwise I would just have that code gather the channel data on its own and duplicate whatever mutations are supposed to happen.

No need to be synchronous. The page is reactive to the core.loading state, and does the fetch after loading the rootNodes https://github.com/endlessm/kolibri-explore-plugin/blob/910e8b3e108ba8f7a3ed9e4a12cda557615ed1d2/kolibri_explore_plugin/assets/src/views/DiscoveryPageContenPacks.vue#L112-L123 . I am revisiting the handlers logic (whch set the loading state) to see why it regressed.

Found it! I introduced this while rewiring the Welcome. Fix: https://github.com/endlessm/kolibri-explore-plugin/pull/852

The expected behavior here is that we would never see a description on the cards in the Discovery page, correct?

Verified with the latest flatpack v0.7 plugin v7.3.0
This issue can be seen only when the user completes the download and enter to the Discovery page for the first time.
It will no longer be reproduced after that.

Nearly there - as Vanessa is saying. The very first time right after the content pack download, the cards have a description in the Discovery page. All the times afterwards - they do not.

Great spotting @vanessa-chang and @erikos! Ready for review. Unfortunately all this routing is very fragile.

https://github.com/endlessm/kolibri-explore-plugin/pull/860 has been merged.

Verified passed in flatpak v0.7 with plugin v.7.5.0


copy/paste/cut not working

Issue Type: Bug
i downloaded some extensions and copy/paste/cut are not working. I don't know which other shortcuts may not work too
VS Code version: Code 1.28.1 (3368db6750222d319c851f6d90eb619d886e08f5, 2018-10-11T18:09:20.566Z)
OS version: Linux x64 4.15.0-36-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz (4 x 2928)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: unavailable_softwarevideo_encode: unavailable_softwarewebgl: enabledwebgl2: enabled

Load (avg)
7, 6, 6

Memory (System)
7.66GB (2.11GB free)

Process Argv
code.py

Screen Reader
no

VM
0%

Extensions (36)

Extension
Author (truncated)
Version

html-snippets
abu
0.2.1

code-gnu-global
aus
0.2.2

bracket-pair-colorizer
Coe
1.0.60

vscode-eslint
dba
1.6.0

githistory
don
0.4.3

xml
Dot
2.3.2

gitlens
eam
8.5.6

vscode-html-css
ecm
0.2.0

EditorConfig
Edi
0.12.5

tslint
eg2
1.0.40

vscode-npm-script
eg2
0.3.5

vscode-great-icons
emm
2.1.44

vsc-material-theme
Equ
2.4.2

prettier-vscode
esb
1.6.1

php-debug
fel
1.12.6

php-intellisense
fel
2.3.5

latex-workshop
Jam
5.12.2

vscode-clang
mit
0.2.3

mssql
ms-
1.4.0

python
ms-
2018.9.0

cpptools
ms-
0.19.0

csharp
ms-
1.16.2

PowerShell
ms-
1.9.0

vsliveshare
ms-
0.3.790

material-icon-theme
PKi
3.6.0

java
red
0.32.0

vscode-yaml
red
0.0.17

vscode-icons
rob
7.27.0

python
tht
0.2.3

vscode-java-debug
vsc
0.14.0

vscode-java-test
vsc
0.10.0

vscode-maven
vsc
0.11.1

vim
vsc
0.16.9

vscode-react-native
vsm
0.6.18

JavaScriptSnippets
xab
1.7.1

html-css-class-completion
Zig
1.17.1

/needsMoreInfo

These are the extensions i downloaded. I don't know what is wrong with
them. Ctrl+C/P/X are not working.
I am new to VSC. So please help me.
On Sun, Oct 14, 2018 at 10:50 PM Erich Gamma<EMAIL_ADDRESS>wrote:

/needsMoreInfo
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/60889#issuecomment-429644360,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfosIjO4ZcnxfkMjzvFNxt-6zkEMiRG9ks5uk3JkgaJpZM4XbHmV
.

Can you reproduce this when all the extensions are disabled? See our issue reporting guidelines for how to do this https://github.com/Microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions.

Yes it is working after disabling all the extensions.
On Mon, Oct 15, 2018 at 10:43 AM Erich Gamma<EMAIL_ADDRESS>wrote:

Can you reproduce this when all the extensions are disabled? See our issue
reporting guidelines for how to do this
https://github.com/Microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/60889#issuecomment-429710842,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfosIkA896E1PFREP1bW-boi2G-0r1Lyks5ulBl2gaJpZM4XbHmV
.

Then you need to narrow down which extension is causing the problem and file the issue against this extension. There is nothing we can do from the VS Code side, sorry.


Master to branch

Docs Build status updates of commit 534fd23:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/comfort.md
:white_check_mark:Succeeded
View

mixed-reality-docs/gaze-and-dwell.md
:white_check_mark:Succeeded
View

mixed-reality-docs/hololens-emulator-archive.md
:white_check_mark:Succeeded
View

mixed-reality-docs/index.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch1.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch2.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch3.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch4.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch5.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch6.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.