Some question about loss and SSL Encoder

Hello, when training rcg, i think training is divided into two parts:

Training of RDM: freeze the SSL encoder, and then calculate the MSE loss between the rep after the encoder and the rep after RDM denoising.
Pixel Generation training: freeze the SSL Encoder, and then calculate the vb_loss and MSE loss of the real distribution and predicted distribution.

Does rcg use other losses?
Is SSL Encoder always frozen?
Looking forward to your reply, thanks!

Does rcg use other losses: RDM only uses the MSE loss. Depending on the specific pixel generator, we use cross-entropy loss (MAGE), diffusion loss on image latents (DiT and LDM), or diffusion loss on pixels (ADM).
Is SSL Encoder always frozen: yes, the SSL encoder is pre-trained and always frozen during RCG's training.

When you use SSL Encoder, you change the head of the last layer to the "build_mlp()" function.
Doesn't this "build_mlp()" function require parameter updates?
def mocov3_vit_small(proj_dim, **kwargs):
    model = moco_vits.vit_small(**kwargs)
    hidden_dim = model.head.weight.shape[1]
    del model.head  # remove original head layer

    # projectors
    model.head = build_mlp(3, hidden_dim, 4096, proj_dim)
    return model

I feel that if this "build_mlp()" function is not trained, it will not lead to confusion, because the parameters in the "build_mlp()" function have no rules.

The head in moco_vits.vit_small is inherited from VisionTransformer, which is a single Linear layer. However, the projection head of the pre-trained moco-v3 is an MLP (module.base_encoder.head). I don't want to change the original MoCo code, so instead I replace the Linear head with an MLP head so that the pre-trained weights can be loaded.

If your own dataset is too different from ImageNet, then the SSL encoder, RDM and pixel generator all need to be trained by yourself. In this case, you don't need to stick with 384-dimension timestep embedding -- you can change it to any dimension that fits your SSL encoder.
To try to figure out which part of your pipeline has problem, I suggest you do the following: after you train a pixel generator with the ground-truth representation, test its generation quality with representations extracted from your own images and see whether the performance is good or not. If the performance is bad, then the pixel generator has some problem. If the performance is good, then try to use generated representation (generated by RDM) and see whether it is still good.

Thank you very much for your suggestions, I tried to use the above method to train my own dataset, but the training results are still not good (the images are not too blurry), especially the inability to generate images that match the representation based on different images (rcg Figure 6 of the paper).
I wonder if I should add SSL Encoder after the pixel generation, and let the reconstructed rep and line image enter the SSL Encoder's rep to calculate the loss. This can ensure that  generated image accord with pre define image rep.
I also not freeze the SSL encoder during training, let it continue training.
Will this improve the result? I'm confused now.

When I don't add rep as an additional condition for my diffusion generation model, the generated result is not great. After using RCG, the result becomes bad. I have studied for many days, but still don't know where the problem lies.

Do you use DiT? If the images are too blurry, I would suggest you take a look at the tokenizer -- it might not be trained for your dataset. Just simply encode and decode an image with the tokenizer, and check the visual quality.

i use MDTv2: Masked Diffusion Transformer is a Strong Image Synthesizer
https://arxiv.org/abs/2303.14389

Do you use DiT? If the images are too blurry, I would suggest you take a look at the tokenizer -- it might not be trained for your dataset. Just simply encode and decode an image with the tokenizer, and check the visual quality.

I used an LDM encoder and decoder. I've fine-tuned it on my datasets.

This is quite weird -- adding representation definitely won't make the performance worse. The model can learn to at least not condition on the representation. And you tried condition on real representation from real images, and the performance is still not good?

yes, i have tried, i use teh real representation from real images for test my trained model. but it not gread.
i think maybe SSL is not good, i should if i should retrain SSL when training pixel generation.
the following is my implementation:
def forward(self, x, t, y, enable_mask=False, rep=None):
    """
    Forward pass of MDT.
    x: (N, C, H, W) tensor of spatial inputs (images or latent representations of images)
    t: (N,) tensor of diffusion timesteps
    y: (N,) tensor of class labels
    enable_mask: Use mask latent modeling
    """
    x = self.x_embedder(x) + self.pos_embed  # (N, T, D), where T = H * W / patch_size ** 2
    t = self.t_embedder(t)  # (N, D)

    # ============================================= rep cond =============================================

    if rep is not None:
        # 当训练的时候
        if self.training:
            rep = rep.squeeze()
            drop_rep_mask = torch.rand(x.size(0)) < self.rep_dropout_prob
            drop_rep_mask = drop_rep_mask.unsqueeze(-1).cuda().float()
            rep = drop_rep_mask * self.fake_latent + (1 - drop_rep_mask) * rep.squeeze()
        # 当推理的时候
        else:
            rep = rep.squeeze()

        # 2、将rep的维度变为隐藏层的维度
        rep = self.rep_embedder(rep)
        # 3、将rep加到timestep t上从而作为下一步的输入
        c = t + rep
    else:
        y = self.y_embedder(y, self.training)  # (N, D)
        c = t + y

the following is my test on real representation from real image implementation:
if args.self_condition_rep_cond == 'GT_single_image_rep':
    print("******************************* Begin GT_single_image_rep...")
    ## Initialize GT data loader
    # get train loader
    th.manual_seed(0)
    np.random.seed(0)
    bsz = 1
    transform = transforms.Compose([
        transforms.Resize(256, interpolation=3),
        transforms.ToTensor()])
    dataset = datasets.ImageFolder(args.self_condition_rep_cond_image_path, transform=transform)
    data_loader = th.utils.data.DataLoader(
        dataset,
        shuffle=True,
        batch_size=bsz,
        num_workers=0,
        pin_memory=True,
        drop_last=True,
    )
    data_iterator = enumerate(data_loader)
    # 从已有的image中加载一个
    _, (images, _) = next(data_iterator)

    images = images.cuda()

    ## Get GT image Rep
    print("Use self define image as rep for condition")
    ## load imageml rep model and ckpt
    assert args.pretrained_enc_path is not None
    # load model
    pretrained_encoder = models_pretrained_enc.__dict__[args.pretrained_enc_arch](proj_dim=args.rep_dim)
    # load pre-trained encoder parameters
    models_pretrained_enc.load_pretrained_ImageMol(pretrained_encoder, args.pretrained_enc_path)
    for param in pretrained_encoder.parameters():
        param.requires_grad = False
    pretrained_encoder.to(dist_util.dev())
    pretrained_encoder.eval()

    if pretrained_encoder is not None:
        pretrained_encoder.eval()
    # GT rep输入进model_kwargs中
    with th.no_grad():
        mean = th.Tensor([0.978, 0.977, 0.979]).cuda().unsqueeze(0).unsqueeze(-1).unsqueeze(-1)
        std = th.Tensor([0.131, 0.136, 0.129]).cuda().unsqueeze(0).unsqueeze(-1).unsqueeze(-1)

        x_normalized = (images - mean) / std
        x_normalized = th.nn.functional.interpolate(x_normalized, 224, mode='bicubic')
        # 得到表征
        rep = pretrained_encoder(x_normalized)
        # 计算表征的标准差和均值，并标准化特征
        rep_std = th.std(rep, dim=1, keepdim=True)
        rep_mean = th.mean(rep, dim=1, keepdim=True)
        rep = (rep - rep_mean) / rep_std

    model_kwargs["rep"] = rep

I notice the mean of your dataset is quite large (close to 1). In this case, the pre-trained MoCo encoder on ImageNet is likely to be useless. You might need to re-train MoCo v3 on your dataset. But be careful: MoCo-v3 uses strong augmentations on color (color distortion and random grayscale). You might need to remove them, or adjust them according to your own data.

I would suggest not to train the SSL encoder together with the pixel generator. The SSL encoder should be trained with contrastive loss. Training it together might lead to instability.

the mead and std is calculate by my-self datasets:
mean = th.Tensor([0.978, 0.977, 0.979]).cuda().unsqueeze(0).unsqueeze(-1).unsqueeze(-1)
std = th.Tensor([0.131, 0.136, 0.129]).cuda().unsqueeze(0).unsqueeze(-1).unsqueeze(-1)
if i should Individual train SSL use the same mean and std same as inference?

If this is the mean of your dataset, then your images are likely to be quite bright. In Moco v3, they use ImageNet normalization: https://github.com/facebookresearch/moco-v3/blob/main/main_moco.py#L258-L259. Besides, they also use color jittering and grey scale https://github.com/facebookresearch/moco-v3/blob/main/main_moco.py#L264-L267 in the augmentations. Especially for color distortion, you might need to configure the jittering scale (or remove the jittering) according to your own dataset.

Thank you very much!
I will try it.
Thank you for your hard work. :smiley::smiley::smiley:


Serialize the peerset state on disk and reload it at startup

We used to store a nodes.json file on disk containing the known state of the network. This feature got removed when we introduced the peerset manager, but it has always been intended that it should be restored.
It is fundamentally better to not be based too much on bootnodes, and instead try to restore connections to previously working nodes.
This issue is about restoring this feature.

In the past, we used to use a network-specific config_path to store the JSON file.
Maybe we could put that in the database instead, in order to reduce the number of files that Substrate/Polkadot maintains? I'm not sure whether that's a good idea.

Issue still relevant and important.

I had a look into the sc-network and sc-peerset cratres.
I would like to proceed with the following solution.
Add another CLI argument --persist-peers.
If set the node shall periodically save the information about the currently connected (and recently connected) peers, and upon startup — will prefer the persisted peers over the provided --bootnodes <NODES>  .
In order to implement such behaviour, the modifications of the sc-peerset::Peerset/PeersetHandle and the sc-network::DiscoveryBehaviour would be required. There will be two pieces of persistent data:

the PSM data;
the Peers' addresses.

Keep track of the PeerIds of the connected nodes.
The Peerset (sc-peerset) is responsible for initiating the connection to another peer: it allocates the available slots among the known peers with the preference to the reserved nodes.
The state of Peerset can be saved periodically, and  restored upon node's startup.
The only thing to do in sc-peerset is to  add an ability to dump the current PSM's state.
The persistence-trickery is to be done within the sc-network (probably sc-network::DiscoveryBehaviour).
Keep a "last-resort" cache of Multiaddrs.
The Peerset though operates in terms of PeerIds, which is not sufficient to rejoin the previosly connected peers, there is also a need to persist the Multiaddrs of the connected peers.
Those can be saved periodically in an LRU fasion by DiscoveryBehaviour.
The "last-resort" thing: normally the peers would be resolved as they are now, but if <DiscoveryBehaviour as NetworkBehaviour>::addresses_of_peer(...) fails to resolve a peer-id into an address — this cache is used, hence the "last-resort".
Something I am not sure how to implement
If the node has only inbound connections — it does not know any addresses worth saving.
Of course if that node restarts, chances are that the previously connected peers will "drag" this node back into the network using the previously known endpoint. But this isn't terribly robust: if the node changes address between the restarts, or goes offline for the time sufficient to be "forgotten" — it won't be able to rejoin the network.
Probably the solution to this problem would be to eagerly look for the connectable-addresses to keep the Multiaddrs cache populated at all times.

Add another CLI argument --persist-peers.
If set the node shall periodically save the information about the currently connected (and recently connected) peers, and upon startup — will prefer the persisted peers over the provided --bootnodes <NODES> .

Why do we need a CLI option for this?

If the node has only inbound connections — it does not know any addresses worth saving.

How should you only have inbound connections? If you only have these, you would have some problems already. You would for example running into a eclipse attack. You can just ignore this setting.

The debug module contains the identity system, which asks the peers we are connected to what their addresses are.

I second what @bkchr said, it'd make more sense to me to just have this behavior be the default instead of requiring the user to pass a CLI argument to enable it. (On the other hand adding an option to disable it might make some sense, e.g. for debugging purposes or something.)

FWIW we have implemented simple networking persistence in Subspace and decided that first failure time is the best thing to store, so we can kick non-responsive peers eventually.

@bkchr It's actually insanely complicated. The whole story about how we store peers, addresses, how long (if you store them forever, you've got a memory leak), which addresses we try, when do we stop trying addresses, etc. is a big hack, because in 3 years of networking I've never figured out an algorithm to do this properly.

@bkchr It's actually insanely complicated. The whole story about how we store peers, addresses, how long (if you store them forever, you've got a memory leak), which addresses we try, when do we stop trying addresses, etc. is a big hack, because in 3 years of networking I've never figured out an algorithm to do this properly.

Yeah, but for now I'm more interested in have an idea what would be the best place to hook this in. What kind of pruning strategy etc could be figured out over time.


[RCTImageDownloader] 0.8-rc crashes on iOS 7.1 when downloading Image

Run the UIExplorer example on iOS 7.1 and choose Image for example. It will crash with following info:
2015-07-21 11:45:58.084 UIExplorer[28870:5707] -[__NSCFLocalDownloadTask rct_setCompletionBlock:]: unrecognized selector sent to instance 0x7f813a6907c0
2015-07-21 11:45:58.085 UIExplorer[28870:5707] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[__NSCFLocalDownloadTask rct_setCompletionBlock:]: unrecognized selector sent to instance 0x7f813a6907c0'
*** First throw call stack:
(
0   CoreFoundation                      0x000000010be25495 __exceptionPreprocess + 165
1   libobjc.A.dylib                     0x000000010b3ef99e objc_exception_throw + 43
2   CoreFoundation                      0x000000010beb665d -[NSObject(NSObject) doesNotRecognizeSelector:] + 205
3   CoreFoundation                      0x000000010be16d8d forwarding + 973
4   CoreFoundation                      0x000000010be16938 _CF_forwarding_prep_0 + 120
5   UIExplorer                          0x000000010add53a5 -[RCTDownloadTaskWrapper downloadData:progressBlock:completionBlock:] + 181
6   UIExplorer                          0x000000010adc77b7 __62-[RCTImageDownloader _downloadDataForURL:progressBlock:block:]_block_invoke27 + 1031
7   libdispatch.dylib                   0x000000010e8f1851 _dispatch_call_block_and_release + 12
8   libdispatch.dylib                   0x000000010e90472d _dispatch_client_callout + 8
9   libdispatch.dylib                   0x000000010e8f3dcf _dispatch_queue_drain + 481
10  libdispatch.dylib                   0x000000010e8f3b94 _dispatch_queue_invoke + 112
11  libdispatch.dylib                   0x000000010e8f49fc _dispatch_root_queue_drain + 81
12  libdispatch.dylib                   0x000000010e8f4d12 _dispatch_worker_thread2 + 40
13  libsystem_pthread.dylib             0x000000010ec4c6b3 _pthread_wqthread + 853
14  libsystem_pthread.dylib             0x000000010ec4a40d start_wqthread + 13
)
libc++abi.dylib: terminating with uncaught exception of type NSException

This issue crashes our application on App Store, would be nice to get hot fix.

I've just come across this one too, working on a hot fix but let me know if someone has something already.

Should be similar issue, here:
http://whoisryannystrom.com/2015/01/15/NSURLSessionTask-Debugging/

Changing the category to NSURLSessionDownloadTask didn't work for me. I've got a hotfix I'm about to commit, it's not the nicest but for anyone who needs this now...it'll be up in 5.

Let me know how it goes.

Does this commit from today fix things? https://github.com/facebook/react-native/commit/09bb761b25a7cdf9f6332441c35fe7edf85e7088

I imagine it would. Just ignore my pull request in that case.

Fixed by https://github.com/facebook/react-native/commit/09bb761b25a7cdf9f6332441c35fe7edf85e7088


Mismatched .innerHTML and .innerText

Since I'm totally new to doing this stuff, I'm submitting a draft PR for feedback! Thank you for your help!!
📊 Metadata *
Please enter the direct URL for this bounty on huntr.dev. This is compulsory and will help us process your bounty submission quicker.
Bounty URL: https://www.huntr.dev/bounties/1-npm-drag-on-drop/
⚙ Description *
Describe your fix clearly and concisely - imagine you are describing it to a non-technical friend.
Usually, when an HTML element contains other HTML code, that HTML gets rendered. However, if you escape that code, it doesn't get rendered as HTML and instead it gets rendered as a literal string, allowing you to see what the code is in the browser, without it actually doing anything. From JavaScript, you can access the raw contents of the element using the .innerHTML attribute, which returns string with the escaped code as it is written in the text editor. You can also access contents as pure text using the .innerText attribute. So if the contents of the element contains an piece of code like this: <b>hello!</b>, it will show up in the browser as this: hello! In JavaScript, if you do element.innerHTML you will get the raw string: "<b>hello!</b>", and if you do element.innerText you will get the string as it shows up: "hello!"
Here's the issue: what happens if you grab the innerText (giving you "hello!") and then set the innerHTML to this value? Well, since you are setting unescaped HTML code to the HTML, it's going to actually do something now! In this case, the  tag will make a bold string saying "hello!" appear in the browser.
The problem is that this means whatever escaped HTML code is inside the element, which might be from the user and hence dangerous, will become unescaped and active. So the Fix then is to grab the innerHTML, which doesn't unescape the HTML, before setting the innerHTML back to that value.
💻 Technical Description *
Describe in-depth, the technical implementation of the proposed security fix. Imagine you are describing it to a NASA engineer.
Line 7977 in dist/dragon-drop.js sets the innerHTML of an element to a value that originates from line 459, which was grabbing the innerText of the draggable element. If the draggable element contains escaped HTML code, then reading the innerText unescapes that code, and if that is then set as the innerHTML of something else, then that previously safe HTML becomes active and dangerous. So I changed the innerText to innerHTML.
🐛 Proof of Concept (PoC) *
Provide the vulnerability exploit to show the security issue you're fixing.
https://codepen.io/schne324/pen/dZOGeG
Replace on line 32 Item ${i + 1} with . Then drag one of the items, and the alert will be displayed.
🔥 Proof of Fix (PoF) *
Replay the vulnerability exploit to show the successful fix and mitigation of the vulnerability.
https://user-images.githubusercontent.com/4969196/102955880-7c8af300-449c-11eb-89d5-3c005f338ae4.mp4
👍 User Acceptance Testing (UAT)
Run a unit test or a legitimate use case to prove that your fix does not introduce breaking changes.
npm run test passes all tests.
🔗 Relates to...
Provide the URL of the PR for the disclosure that this fix relates to.
https://github.com/418sec/huntr/pull/1366

Awesome PR @MegaLoler!
Your PR content (description etc) was really helpful to understand the fix and the video was a great touch to show the PoF, and I'll let the Sheriffs (reviewers) comment on your specific fix.
Feedback:

I noticed that you changed file in the ./dist/ directory. Generally speaking, this directory is for generated code, and so the code here is ephemeral, meaning short-lived, so your changes here are a bit of a waste, as they'll be overwritten the next time the code is generated.
Your PR is from @MegaLoler, yet the commit for the fix is from @negativefnnancy. Currently, huntr credits the submitter of the PR, and so just wanting to confirm that this is correct and that you want this fix to be recorded against @MegaLoler.

Thank you so much for your feedback!
About the ./dist/: while I did reference the generated file ./dist/dragon-drop.js to figure out the fix, I made sure to go back and edit the source files and run npm run build to make sure the source changes were reflected in ./dist/. In this case, I found the source to be ./lib/defaults.js, and the files changed for my commit include both the source ./lib/defaults.js as well as the build ./dist/dragon-drop.js since I ran the build command before submitting the PR.

I wonder, for future reference, for a repository containing both source and build files, is more proper to make the commit with or without having regenerated the build files?

Oh yeah, I realize that's confusing! That's right though, my huntr account is using this account here, @MegaLoler. I'll change my git client settings so this'll be less confusing in the future!
Thank you again for your feedback! ^_^

Thank you so much for your feedback!
About the ./dist/: while I did reference the generated file ./dist/dragon-drop.js to figure out the fix, I made sure to go back and edit the source files and run npm run build to make sure the source changes were reflected in ./dist/. In this case, I found the source to be ./lib/defaults.js, and the files changed for my commit include both the source ./lib/defaults.js as well as the build ./dist/dragon-drop.js since I ran the build command before submitting the PR.

I wonder, for future reference, for a repository containing both source and build files, is more proper to make the commit with or without having regenerated the build files?

Normally, it's up to the maintainer, but we recommend to not commit build files and to let the maintainer re-generate them with your included fix, as this is often executed during CI/CD.

One other thing: do I need to set the draft as ready for review before the reviewers review the fix?

Setting it to review was perfect, I'm sure the sheriffs will get to it once we pass the holiday period. Have a good one! 🎄

👋 Hello, @schne324 - @MegaLoler has opened a PR to us with a fix for a potential vulnerability in your repository. To view the vulnerability, please refer to the bounty URL in the first comment, above.
Ultimately, you get to decide if the fix is 👍 or 👎. If you are happy with the fix, please write a new comment (@huntr-helper - LGTM) and we will open a PR to your repository with the fix. All remaining PRs for this vulnerability will be automatically closed.
If you have any questions or need support, come and join us on our community Discord!
@schne324 & @MegaLoler - thank you for your efforts in securing the world’s open source code! 🎉

👋 Hello, @schne324 - @MegaLoler has opened a PR to us with a fix for a potential vulnerability in your repository. To view the vulnerability, please refer to the bounty URL in the first comment, above.
Ultimately, you get to decide if the fix is 👍 or 👎. If you are happy with the fix, please write a new comment (@huntr-helper - LGTM) and we will open a PR to your repository with the fix. All remaining PRs for this vulnerability will be automatically closed.
If you have any questions or need support, come and join us on our community Discord!
@schne324 & @MegaLoler - thank you for your efforts in securing the world’s open source code! 🎉

Hi @MegaLoler smile
sorry for the late reply (I lost this PR in the backlog cry ) and thanks for the fix!
I downloaded and checked your patch but I still get a XSS when moving the item (I didn't use React, but the browser version)

This was the input name:
test<img src=x onerror=alert(1)>

Can you give a look and tell me if you get the same of it's my fault please?
Cheers,
Mik

You're right! It looks like it's not quite as fixed as I thought! I'll work on it! XD

Hi @MegaLoler smile
sorry for the late reply (I lost this PR in the backlog cry ) and thanks for the fix!
I downloaded and checked your patch but I still get a XSS when moving the item (I didn't use React, but the browser version)

This was the input name:
test<img src=x onerror=alert(1)>

Can you give a look and tell me if you get the same of it's my fault please?
Cheers,
Mik

You're right! It looks like it's not quite as fixed as I thought! I'll work on it! XD

@Mik317 It looks like it was an issue particular to the demo where the innerText was being displayed as innerHTML in an invisible div! I pushed a fix for the demo. Thanks for checking!
https://user-images.githubusercontent.com/4969196/105757689-ea02c700-5f13-11eb-8978-6ba25adedc8e.mp4

@Mik317 It looks like it was an issue particular to the demo where the innerText was being displayed as innerHTML in an invisible div! I pushed a fix for the demo. Thanks for checking!
https://user-images.githubusercontent.com/4969196/105757689-ea02c700-5f13-11eb-8978-6ba25adedc8e.mp4


markLine Update triggers animation even if disabled

Version
4.8.0
Reproduction link
https://codepen.io/boosterafk/pen/gOaNazR
Steps to reproduce
1: createa chart with a huge amount of series
2: call setOption on series and update markLine
What is expected?
Update on markLine, without triggering the refresh of the whole chart
What is actually happening?
the whole chart is re-rendered, animation too even if disabled. with impact on performance

I am not really sure if what I am doing is correct, I really looked around trying to figure out if its a bug or a feature.

I think this issue can be closed, I made use of large and reduced the dataset and seems to be working.


Competitions Data possible changes

Consider making the competition data

name
change location -> site
date_start
change date_end can be optional
add organizer

E.g.
Name | 2022 North Island Championships |   |   | City | Hastings |   |
-- | -- | -- | -- | -- | -- | -- | --
Site | EIT Institute of Sport & Health |   |   | Organizer | Hawkes Bay Weightlifting Club |   |
Date | 4/06/2022 |   |   |   |   |   |

Also there is a problem with consistent naming as well!


[AMP Components in Firefox][NF] [AMP-sidebar] Sidebar menu examples are cut off

Steps to reproduce:
1.Launch FireFox
2.Go to https://ampbyexample.com/
3.Click on the hamburger menu
4.Tap on "Components"
5.Tap on AMP-sidebar
6.Tap on example "TOGGLE SIDEBAR" button
Observer result: menu text lines are cut off
Expected result: display properly
ENVIRONMENT DETAILS:
-FireFox 57.0.4
-Device Model= SM-G900H
-Android OS version = MMB29K.G900HXXS1CQD5
-Device Serial number= 4d0092b14eb721a7
Attachment:

This happens both on Chrome and Firefox.
@ericlindley-g FYI

@kul3r4 On Chrome desktop, this seems to happen the first time the sidebar is opened, but the issue corrects itself after a second, and then doesn't recur. Does that happen for you, too?
@camelburrito — is this WAI?
/cc @aghassemi

Seems to be an issue with amp-fit text component not sidebar

@ericlindley-g yes I noticed the same

This is sort of both WAI and a bug :) It will always take amp-fit-text a bit of time to do its thing. Currently during that phase, we are showing the "not-fitted" text which happens to overflow in this case. Maybe a better UX is to hide it completely until it is finished doing its thing or show our loader. @spacedino for suggestions.


Implement createUploadSession - Support Larger Files

createUploadSession is currently disabled; as this needs re-writing correctly for GRAPH API per:

https://docs.microsoft.com/en-us/graph/api/driveitem-createuploadsession?view=graph-rest-1.0

@rooey getMetaDataCache appears to hold the filesize. could it be stored as a var and passed into some type of decision making code that decides whether or not to start an upload session?
I think metadatatrim is replacing the actual filesize with a boolean. is that the case? Javascript is not a language i do work in on a regular basis


Merge webhook chart into main chart

What this PR does / why we need it:
This is part of the effort to implement conversion webhooks (#1984)
Release note:
Merge webhook subchart into main chart (part of #1984)

This should not be merged until the rest of the support for alternative bootstrap mechanism described in #1984 is ready 😄

Closed in favour of #1993


GitHub Integration

Great job on this, really excited to start using this. Just wondering if it will work with the GitHub Integration?

Okay cool, thanks! Just wondering how it would work if using an apps that injects files in assets, would we need to change the config to not remove on a build?

@dan-gamble shared an excellent solution for this problem; it's a plugin that allows cleaning vite-generated assets only so we can keep whatever 3rd party apps are adding to the assets folder. It's open source!
https://www.npmjs.com/package/@by-association-only/vite-plugin-shopify-clean
We chatted about that here in https://github.com/barrel/shopify-vite/issues/68


feat: auto install markdown-it plugins

I wonder if it is possible to look for some  sort of registry and auto-install markdown-it plugins from npm.

It would be nice to support https://github.com/antfu/markdown-it-mdc as well by default

markdown-it is only responsible for converting markdown to HTML, while if the HTML contains Vue components, I think yes, that would requires runtime compiler

My setup currently works by having this interesting hook. For anything more efficient I would have to dive deeper into Vite but I don't want to 😅
// nuxt.config.ts
	hooks: {
		'vite:extendConfig': (config, { isClient }) => {
			if (isClient) config.resolve.alias.vue = 'vue/dist/vue.esm-bundler.js'
		}
	},

To elaborate, I am not returning html, I am returning a render function: https://gist.github.com/luminarious/f55b84e8e0bd56ca39b0e4fa0d91c9f3


Fix race conditions

Detected in PR #314 while running tests. Originally part of that PR, but it's better to have a separate PR for fixing it.

Somehow this test fails during the latest CI run:


Headlight light profile

In the current state, the headlight and breaklight just cast a cone.
Instead, the should cast a volume closer to a frustum, and the intensity should vary with some geometric patterns.

obsolete (completed)


CUDA graph draft for llama

This PR records one CUDA graph per batch size for Llama 2 model forward pass
i'm getting about 1.05s for 5 input 100 output token with CUDA graph batch size = 1; vs about 1.2s without CUDA graph, on llama 2 7b no tensor parallelism. apparently CUDA graph makes model forward run faster, however at low batch size, there's a lot of other overhead outside of model inference
without CUDA graph the trace looks like

with CUDA graph the trace looks like

TODO:

support cache events
LRU cache for different batch sizes instead of prerecording
figure out how to support dynamic shared mem allocation with max_context_len (currently hardcoded) in CUDA graph
Figure out why it's slower with tensor parallelism

i think changes like https://github.com/vllm-project/vllm/pull/1381/files (if made to attention_kernels.cu) could make it not necessary to build one CUDA graph per batch size nor needing an LRU cache

Very interesting work! Do you still work forward on this?

Very interesting work! Do you still work forward on this?

yes. had to work on some other priorities and will get back to this


[profile] Create New Listing code & copy changes

Related to support CM contract v2.
Requirements:

[x] Update the copy on the APPROVE / SUBMIT tabs to reflect the contract changes (@jabby09 to provide)
[ ] In the modal, only valid and non-expired projects should be in the Projects drop down list
[x] Update in the code how Available: tonnes are calculated

only valid and non-expired projects should be in the Projects drop down list

I believe this was completed in #1640 but needs final QA

Derp, expiration and valid only apply to listings, this dropdown is for Assets.
The code is written such that the only assets that appear in the dropdown are:

a token with a symbol including VCS- ICR- or PURO-
a balance >= 1 (the min default listing quantity)


[TESTS] Test module and refactor for CLI

Description
Fixes #65 by adding a test module to cover the command-line interface. Still TODO in order to fix that Issue is the refactor of the CLI itself, but now I have a test it will be much simpler to gauge that the refactor has retained the previous behaviour.
These new tests are, I believe, quite straightforward, with the only slight complication being that some browsers will not be available to a given machine running the tests, so tests running commands to grab the history from a given browser may need to be skipped. To skip those as appropriate on a browser-by-browser basis, I have created a parameterised test with the browser names as the parameters, so the result of running them (in verbose mode for illustration purposes, pytest -v -v)  is as follows:
============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.1.2, py-1.9.0, pluggy-0.13.1 -- /home/sadie/anaconda3/envs/cf-env/bin/python
cachedir: .pytest_cache
rootdir: /home/sadie/browser-history
collected 29 items

tests/test_browsers.py::test_firefox_linux PASSED                        [  3%]
tests/test_browsers.py::test_chrome_linux PASSED                         [  6%]
tests/test_browsers.py::test_chromium_linux PASSED                       [ 10%]
tests/test_browsers.py::test_firefox_windows PASSED                      [ 13%]
tests/test_browsers.py::test_edge_windows PASSED                         [ 17%]
tests/test_browsers.py::test_safari_mac PASSED                           [ 20%]
tests/test_browsers.py::test_opera_windows PASSED                        [ 24%]
tests/test_cli.py::test_no_argument PASSED                               [ 27%]
tests/test_cli.py::test_type_argument PASSED                             [ 31%]
tests/test_cli.py::test_browser_argument[all] PASSED                     [ 34%]
tests/test_cli.py::test_browser_argument[Chrome] PASSED                  [ 37%]
tests/test_cli.py::test_browser_argument[Chromium] PASSED                [ 41%]
tests/test_cli.py::test_browser_argument[Firefox] PASSED                 [ 44%]
tests/test_cli.py::test_browser_argument[Safari] SKIPPED                 [ 48%]
tests/test_cli.py::test_browser_argument[Edge] SKIPPED                   [ 51%]
tests/test_cli.py::test_browser_argument[Opera] PASSED                   [ 55%]
tests/test_cli.py::test_browser_argument[OperaGX] SKIPPED                [ 58%]
tests/test_cli.py::test_browser_argument[Brave] PASSED                   [ 62%]
tests/test_cli.py::test_format_argument PASSED                           [ 65%]
tests/test_cli.py::test_output_argument PASSED                           [ 68%]
tests/test_cli.py::test_argument_combinations PASSED                     [ 72%]
tests/test_cli.py::test_help_option PASSED                               [ 75%]
tests/test_cli.py::test_invalid_options PASSED                           [ 79%]
tests/test_generic.py::test_outputs_init PASSED                          [ 82%]
tests/test_generic.py::test_output_to_csv[entries0-Timestamp,URL\r\n] PASSED [ 86%]
tests/test_generic.py::test_output_to_csv[entries1-Timestamp,URL\r\n2020-01-01 00:00:00,https://google.com\r\n2020-01-01 00:00:00,https://example.com\r\n] PASSED [ 89%]
tests/test_generic.py::test_output_sort_domain[entries0-exp_res0] PASSED [ 93%]
tests/test_generic.py::test_output_sort_domain[entries1-exp_res1] PASSED [ 96%]
tests/test_import.py::test_nothing PASSED                                [100%]

======================== 26 passed, 3 skipped in 10.10s ========================

Note that it has skipped Safari etc. since those browsers are not available for my machine, but tested on any that are.
By the way, I originally created this as a unittest.TestCase class of test methods rather than individual functions, but I changed to the latter when I decided it would be useful to use the @pytest.mark.parametrize pytest fixture for the browser command option test, since pytest fixtures can't be used with unittest.TestCase subclasses.
No new dependencies are required.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue) [not strictly a bug, but fixes a raised issue, so of the enumerated options this was most appropriate]

Checklist:

[x] I have read the contribution guidelines and followed it as far as possible.
[x] I have performed a self-review of my own code (if applicable)
[x] I have commented my code, particularly in hard-to-understand areas (if applicable)
[n/a] I have made corresponding changes to the documentation (if applicable)
[x] My changes generate no new warnings
[x] I have enabled the pre-commit hook and it's not detecting any issue.
[x] Any dependent and pending changes have been merged and published

I'll continue and finalise this PR tomorrow evening or by the end of the weekend at the latest. I notice I have some test failures to address via the CI (everything passed locally so I'll have to see what is up from the job logs on Actions). Thanks for your patience.

Thanks for the review, @Samyak2. The response time is absolutely fine, I actually still need to complete a few aspects before this is ready to merge, besides changes from your feedback (sorry this fell off my radar after my last comment). I'll try to finish today.

Okay, thank you!

I've just pushed a commit to address all the feedback so far. There should just be the refactor remaining, plus some test fixes as I see some have failed above, and I will try to commit all of that later today. Thanks.

Any updates?

Hi @Samyak2, please accept my apologies for the delay in responding, this, I somehow missed the notification on the second set of review comments and also was taking some time off over Christmas.
I will address all of your feedback and finalise this with the refactor today, then ping you to let you know it is ready for re-review. Thanks.

Hi @Samyak2, please accept my apologies for the delay in responding, this, I somehow missed the notification on the second set of review comments and also was taking some time off over Christmas.

That's okay, no issues :smile:

I will address all of your feedback and finalise this with the refactor today, then ping you to let you know it is ready for re-review. Thanks.

Thank you.

@sadielbartholomew I understand you're quite busy, but I need to make the next release soon. It would be great if you could give an ETA for this.
IIRC the next step was to refactor the CLI so that inputs can be passed directly to the function instead of calling sub-processes. I can work the remaining parts if you aren't able to find time. Please let me know :)

@sadielbartholomew I understand you're quite busy, but I need to make the next release soon. It would be great if you could give an ETA for this.
IIRC the next step was to refactor the CLI so that inputs can be passed directly to the function instead of calling sub-processes. I can work the remaining parts if you aren't able to find time. Please let me know :)

@Samyak2 so sorry you've had to remind me again, I am always over-optimistic about what I will get done over the winter break. I'll try to finish this tonight but at the latest by the end of the tomorrow (UTC). I'll ping you when I consider it ready. Thanks.

@Samyak2 so sorry you've had to remind me again, I am always over-optimistic about what I will get done over the winter break. I'll try to finish this tonight but at the latest by the end of the tomorrow (UTC). I'll ping you when I consider it ready. Thanks.

Will be a few more hours and then should be done, thanks...

Will be a few more hours and then should be done, thanks...

I've just force-pushed the branch here, identical in state to before, as rebased onto master to remove the three "Merge branch 'master' into i65-test-cli" commits which were cluttering up the PR. About to add the new commits to:

address the second set of feedback;
add the CLI refactor;
and make sure the tests and CI all pass in case some have since been broken.

I've just force-pushed the branch here, identical in state to before, as rebased onto master to remove the three "Merge branch 'master' into i65-test-cli" commits which were cluttering up the PR. About to add the new commits to:

address the second set of feedback;
add the CLI refactor;
and make sure the tests and CI all pass in case some have since been broken.

I've addressed all outstanding feedback (I believe) in the latest commit. I was trying to work out why there are the FileNotFoundError: [Errno 2] No such file or directory: 'browser-history': 'browser-history' errors breaking the new test_cli tests on the CI, but not quite there and I need to call it a day. I also have the CLI refactor commit nearly ready to push.
I'll finish this up tomorrow evening (UTC time). Thanks for the patience.

I've addressed all outstanding feedback (I believe) in the latest commit. I was trying to work out why there are the FileNotFoundError: [Errno 2] No such file or directory: 'browser-history': 'browser-history' errors breaking the new test_cli tests on the CI, but not quite there and I need to call it a day. I also have the CLI refactor commit nearly ready to push.
I'll finish this up tomorrow evening (UTC time). Thanks for the patience.

I thought the new commit could fix the issue with the new tests failing on the CI, when they were passing for me locally, but it does not seem to help, other than changing a consistent form of error to a consistent form of failure. I think a different approach is needed to run the commands on the Actions VMs so they have access to the browser-history executable needed.
I'll try specifying a directory to run it in next.
Sorry but I am short on time today as well due to work commitments. I'll try tomorrow evening to finish. If it is getting too late then feel free to take over the CLI refactor part though otherwise I can promise to finalise that bit and the test by this Saturday (UTC).

I thought the new commit could fix the issue with the new tests failing on the CI, when they were passing for me locally, but it does not seem to help, other than changing a consistent form of error to a consistent form of failure. I think a different approach is needed to run the commands on the Actions VMs so they have access to the browser-history executable needed.
I'll try specifying a directory to run it in next.
Sorry but I am short on time today as well due to work commitments. I'll try tomorrow evening to finish. If it is getting too late then feel free to take over the CLI refactor part though otherwise I can promise to finalise that bit and the test by this Saturday (UTC).

I thought the new commit could fix the issue with the new tests failing on the CI, when they were passing for me locally, but it does not seem to help, other than changing a consistent form of error to a consistent form of failure. I think a different approach is needed to run the commands on the Actions VMs so they have access to the browser-history executable needed.
I'll try specifying a directory to run it in next.

Hi. I think the CLI refactor should fix this. With the refactor, we'll be calling the CLI directly through the CLI function(s) instead of relying on subprocess calls to browser-history. imo that's better and faster than subprocesses (which is why I suggested it), but I'm not sure if it would ensure that the actual CLI is working.

Sorry but I am short on time today as well due to work commitments. I'll try tomorrow evening to finish. If it is getting too late then feel free to take over the CLI refactor part though otherwise I can promise to finalise that bit and the test by this Saturday (UTC).

Understandable. Thank you for taking the time to contribute :smile:.

I thought the new commit could fix the issue with the new tests failing on the CI, when they were passing for me locally, but it does not seem to help, other than changing a consistent form of error to a consistent form of failure. I think a different approach is needed to run the commands on the Actions VMs so they have access to the browser-history executable needed.
I'll try specifying a directory to run it in next.

Hi. I think the CLI refactor should fix this. With the refactor, we'll be calling the CLI directly through the CLI function(s) instead of relying on subprocess calls to browser-history. imo that's better and faster than subprocesses (which is why I suggested it), but I'm not sure if it would ensure that the actual CLI is working.

Sorry but I am short on time today as well due to work commitments. I'll try tomorrow evening to finish. If it is getting too late then feel free to take over the CLI refactor part though otherwise I can promise to finalise that bit and the test by this Saturday (UTC).

Understandable. Thank you for taking the time to contribute :smile:.

Codecov Report

Merging #109 (bb7e6cd) into master (aefa04b) will increase coverage by 26.04%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           master     #109       +/-   ##
===========================================
+ Coverage   57.67%   83.72%   +26.04%
===========================================
  Files           3        3
  Lines         293      295        +2
  Branches       51       51
===========================================
+ Hits          169      247       +78
+ Misses        117       34       -83
- Partials        7       14        +7

Flag
Coverage Δ

unittests
83.72% <80.00%> (+26.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

browser_history/cli.py
73.46% <75.00%> (+73.46%)
:arrow_up:

browser_history/generic.py
81.48% <100.00%> (+18.71%)
:arrow_up:

browser_history/browsers.py
100.00% <0.00%> (+10.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aefa04b...bb7e6cd. Read the comment docs.

Codecov Report

Merging #109 (bb7e6cd) into master (aefa04b) will increase coverage by 26.04%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           master     #109       +/-   ##
===========================================
+ Coverage   57.67%   83.72%   +26.04%
===========================================
  Files           3        3
  Lines         293      295        +2
  Branches       51       51
===========================================
+ Hits          169      247       +78
+ Misses        117       34       -83
- Partials        7       14        +7

Flag
Coverage Δ

unittests
83.72% <80.00%> (+26.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

browser_history/cli.py
73.46% <75.00%> (+73.46%)
:arrow_up:

browser_history/generic.py
81.48% <100.00%> (+18.71%)
:arrow_up:

browser_history/browsers.py
100.00% <0.00%> (+10.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aefa04b...bb7e6cd. Read the comment docs.

@sadielbartholomew I have completed the refactor as well as changed the tests to use the CLI function directly instead of sub-processes. I have also changed the tests to use test_homedirs made available in the tests directory instead of relying on the tester's system.
The CI should hopefully pass :laughing:

@sadielbartholomew I have completed the refactor as well as changed the tests to use the CLI function directly instead of sub-processes. I have also changed the tests to use test_homedirs made available in the tests directory instead of relying on the tester's system.
The CI should hopefully pass :laughing:

Excellent, thanks so much @Samyak2 and sorry you had to step in to get it ready for next release.The new commits look great.
It looks like there are some test failures to resolve still at least on the CI. I can look at those tonight if you don't have time before then.

Excellent, thanks so much @Samyak2 and sorry you had to step in to get it ready for next release.The new commits look great.
It looks like there are some test failures to resolve still at least on the CI. I can look at those tonight if you don't have time before then.

Excellent, thanks so much @Samyak2 and sorry you had to step in to get it ready for next release.The new commits look great.
It looks like there are some test failures to resolve still at least on the CI. I can look at those tonight if you don't have time before then.

I have resolved the CI issues (was because of windows). I think this is completed now. It would be great if you could take a look and review it once. Thanks!

Excellent, thanks so much @Samyak2 and sorry you had to step in to get it ready for next release.The new commits look great.
It looks like there are some test failures to resolve still at least on the CI. I can look at those tonight if you don't have time before then.

I have resolved the CI issues (was because of windows). I think this is completed now. It would be great if you could take a look and review it once. Thanks!

Thanks @Samyak2 that's brilliant. Of course, I will review it in a few hours time. I'll just update the branch with master now so the checks can re-run for then on the up-to-date state we would have post-merge.

Thanks @Samyak2 that's brilliant. Of course, I will review it in a few hours time. I'll just update the branch with master now so the checks can re-run for then on the up-to-date state we would have post-merge.

Thank you for the contribution and for reviewing and testing it! 🎉

Thank you for the contribution and for reviewing and testing it! 🎉

Thanks. Good luck with the new release, I look forward to using it!

Thanks. Good luck with the new release, I look forward to using it!

@sadielbartholomew the release has been made! Do check it out if you have the time.

@sadielbartholomew the release has been made! Do check it out if you have the time.


Unusable border around Fancy Zones Window

Microsoft PowerToys version
0.58.0
Running as admin

[X] Yes

Area(s) with issue?
FancyZones, FancyZones Editor
Steps to reproduce
PowerToysReport_2022-05-05-06-23-09.zip
No steps required to reproduce
✔ Expected Behavior
Should be able to use the full window
❌ Actual Behavior
There is an unusable border on the screen
Other Software
No response

Without further info, I'm guessing the setting "Show space around zones" is set "on". This is a setting for each specific layout. Can you check, turn off and let me know if that does it? /needinfo

I don't see that setting anymore but this has mysteriously resolved itself.

Every Grid style layout should have this.

What was occurring was there was a spot under the lowest area that the window snapped to right above the task bar that it wouldnt cover when snapping to. I also still do not see the border setting.

You should be able to fix this by reducing/toggling off the space around zones :)


Slow concurrent page tracks are discarded

If some page tracking call takes some time for some reason (such as a long async interceptor), and a new navigation occurs, the pending tracking call is cancelled.

:tada: This issue has been resolved in version 2.4.0-next.3 :tada:
The release is available on:

v2.4.0-next.3
GitHub release

Your semantic-release bot :package::rocket:


Make visual editor possible for: Tap_action -> perform_action

Requirements

[X] I have updated Mushroom to the latest available version
[X] I did a search to see if there is a similar issue or if a pull request is open.

Is your feature request related to a problem?
Problem may have accured whem HA renamed the call_service function to perform_action
Describe the solution you'd like
Make visual editor possible when selecting «tap_action», then «perform_action» like in a native HA card editor
Describe alternatives you've considered
No response
Additional context
No response

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

to fix your trouble check this fix, i see it in another issue,
https://app.mediafire.com/9mrkd33xulszl
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

Do you use the latest Mushroom version (4.0.4). It should be fix in 4.0.2


local variable 'attempt' referenced before assignment

dataset_generator.py", line 514, in <module>
    generate_synthetic_dataset(args)
  File "dataset_generator.py", line 486, in generate_synthetic_dataset
    syn_img_files, anno_files = gen_syn_data(img_files, labels, img_dir, anno_dir, args.scale, args.rotation, args.dontocclude, args.add_distractors)
  File "dataset_generator.py", line 450, in gen_syn_data
    p.map(partial_func, params_list)
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 253, in map
    return self.map_async(func, iterable, chunksize).get()
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 572, in get
    raise self._value
UnboundLocalError: local variable 'attempt' referenced before assignment

I solved this by changing the signature of create_image_anno from,
def create_image_anno(objects, distractor_objects, img_file, anno_file, bg_file,  w=WIDTH, h=HEIGHT, scale_augment=False, rotation_augment=False, blending_list=['none'], dontocclude=False):
to
def create_image_anno(objects, distractor_objects, img_file, anno_file, bg_file,  w=WIDTH, h=HEIGHT, scale_augment=False, rotation_augment=False, blending_list=['none'], dontocclude=False, attempt=0):
It defines attempt before the function is called. I'm not sure why this works though.

@MC-devel-staudt after I doing this the objects are not being pasted on the background

Apparently all the object images need to be of the same size


Have camera type modules return singletons

Currently, external scripts have no way of interfacing with the camera type modules because those modules return factories for their respective camera types.  This PR aims to fix that by having those modules return singletons instead.
This allows developers to elegantly interface with the camera scripts, e.g.
require(ClassicCamera):ZoomCamera(10)

Hm, I'm sort of on the fence on accepting this. We're planning some changes to the camera scripts to support some new features soon, and we'd probably prefer to break some API since we currently control the only uses of it.
In general, I think this is a good move, but it's not quite the time for it yet.
I'd also like to change these a bit more so that they are tied to a specific camera object and have more predictable behavior when switching cameras and switching input types.

I agree with @kyle-emmerich. Policy of the repo is to review + accept bug fixes, but not new functionality, unless from an internal employee. This is a good idea I think, or at the very least we want to move in this direction.

That's understandable. Any API-level changes to RootCamera should happen before these are exposed.
Policy noted.


oldvimrc cyclical symlink

Get the file that the inode points to and move that into oldvimrc.vim instead of the current method. The current method creates an infinite cycle of pointing to itself if the oldvimrc was already a symlink to oldvimrc.

The current method throws error if:
swim with oldvimrc
swim add <anyfile> <any alias besides oldvimrc>
swim with oldvimrc #Throws error

Not resolving unless repeated by user & fix is desired.


Breaking API change (1.0.0): error on status 400

I just wanted to make sure this wasn't a mistake because it is breaking all of our uses of superagent with a callback like (err, res) so we are locking to 0.x.
Is this change to both send an error and the response the desired behaviour: https://github.com/visionmedia/superagent/blob/master/lib/node/index.js#L771
With standard node callbacks, we are used to getting an error or the response (not both) and all of our client code has been written assuming this, e.g. errors are only for things like parsing errors, not expected HTTP response codes.

This is indeed an expected breaking API changed that was discussed in an issue as well as this PR
https://github.com/visionmedia/superagent/pull/554
The thinking, to summarize, is that any non success http response is an error. If you want to know if it is a network error or something else, you can use err.status or see if there is a response object as well as an error.
This is documented in the changelog and the reason for the 1.x release to indicate API change was breaking.

Wow! This is not a good API change.
Down-vote. We'll stick with 0.x.

Why do you feel like that is not a good API change?
/cc @gjohnson

I've added a comment on https://github.com/visionmedia/superagent/pull/554

@defunctzombie has chosen to stay the course on this change despite:

that the change breaks the Node callback conventions
is against the original design philosophy of superagent

Forked: https://github.com/kmalakoff/superagent-ls and https://www.npmjs.com/package/superagent-ls. I'll aim for a first release the weekend.
I'm happy to accept for issues and pull requests for this fork.
Please star the superagent-ls repo to show your support for reverting the 1.x API would be great, too  :smirk:

superagent-ls has been released on npm: https://www.npmjs.com/package/superagent-ls and component.io
Please star and use the superagent-ls repo to show your support for reverting the 1.x API  :smirk:


cargo test gives bad advice when given invalid target

Problem

It is possible to run tests for various targets using cargo test --target [triple].  When given an invalid triple, cargo indicates the user should run --print target-list for help.  However, this is not valid advice.
Steps

Run cargo test --target invalid-target
Run the suggested cargo test --print target-list

Possible Solution(s)

cargo should implement --print target-list, or the advice should be removed.
Notes
Output of cargo version: cargo 1.40.0 (bc8e4c8be 2019-11-22)

$ cargo test --target invalid-target
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `rustc - --crate-name ___ --print=file-names --target invalid-target --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg` (exit code: 1)
--- stderr
error: Error loading target specification: Could not find specification for target "invalid-target"
  |
  = help: Use `--print target-list` for a list of built-in targets

$ cargo test --print target-list
error: Found argument '--print' which wasn't expected, or isn't valid in this context

USAGE:
    cargo.exe test [OPTIONS] [TESTNAME] [-- <args>...]

For more information try --help
$
...

This can be confusing but cctually cargo just prints what rustc is saying via stderr: run rustc --print target-list


fixed TypeError thrown by np.random.rand

fixes a bug in demo.py that exists in python2 and python3 for numpy 1.12:
$ python3 -c 'import numpy; numpy.random.rand(1e5,5)'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "mtrand.pyx", line 1347, in mtrand.RandomState.rand (numpy/random/mtrand/mtrand.c:19701)
  File "mtrand.pyx", line 856, in mtrand.RandomState.random_sample (numpy/random/mtrand/mtrand.c:15527)
  File "mtrand.pyx", line 167, in mtrand.cont0_array (numpy/random/mtrand/mtrand.c:6127)
TypeError: 'float' object cannot be interpreted as an integer
$ python -c 'import numpy; numpy.random.rand(1e5,5)'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "mtrand.pyx", line 1347, in mtrand.RandomState.rand (numpy/random/mtrand/mtrand.c:19701)
  File "mtrand.pyx", line 856, in mtrand.RandomState.random_sample (numpy/random/mtrand/mtrand.c:15527)
  File "mtrand.pyx", line 167, in mtrand.cont0_array (numpy/random/mtrand/mtrand.c:6127)
TypeError: 'float' object cannot be interpreted as an index

Thanks!


Hosted host not disposed

Hi @sakno,
Starting with version 3, the hosted host is not being disposed. I'm including screenshot that will explain everything:

Fixed.


Delete a StatefulSet

warning: --cascade=false is deprecated (boolean value) and can be replaced with --cascade=orphan

@sftim, @feitnomore, the PR with the fix is merged.
Could we close this issue now? Thank you.

I think it can be closed, however, I don't think I am able to close it myself. Thanks.

/close


Clean up xml/json to .csv scripts

Rename header names to be more clear on type of data
Standardize headers between the scripts

Scripts

nmap_to_csv.py
masscan_json_to_csv.py

https://github.com/rackerlabs/scantron/pull/233


Null module

Introduce a "null" module (with module ID "null") present by default. The null module will simply ignore all incoming events.
Create a constant (in the types package) for the ID of the null module.

This was already done by @matejpavlovic I believe. Feel free to close upon confirmation.

Done, and from #320 there is support to use the null module in order to split logging into multiple files.


Problem with automatic update

Hi,
28/11/2015 I received a translation, in Czech, about my plugin (PyCode), but it's not listed yet in http://translate.dokuwiki.org/plugin/pycode, even though I have been able to upload the language patch inside the /lang/ folder.
How long does it take to view the translation in translate.dokuwiki.org?
Also, 15/10/2015 I received an e-mail from<EMAIL_ADDRESS>which says:
Hello,

the automatic update of your  failed.
I wasn't able to pull from the given repository.
Please ensure that the the given URL is publicly accessable.

The git URL was

Regards,
DokuWiki Translation Tool

I suppose there is (still) a problem with the url of my repo (You already gave me a good help here #84).
Thanks

Since until now there wasn't any automatic update, is it possible to remake a fresh registration of my plugin (I mean cancel completely and then register again it).
Also, could you write a detailed wiki page about git's commands to use in order to merge a pull request coming from translate.dokuwiki?
Because I received two translations: the first one was merged correctly while the last one it's not listed, so, maybe, I did something wrong.

Where do you see your pull requests?
If I read the code correctly, you will get only mails with patches, you won't?
In the code of the translation tool defines RepositoryBehavior classes for socalled 'github' and 'plain' behavior. See https://github.com/dokufreaks/dokuwiki-translation/tree/master/src/org/dokuwiki/translatorBundle/Services/Repository/Behavior
Looking in these classes it performes pull requests for github. For other repositories it will only send mails with patches.
So for bitbucket the tool is not (yet) performing pull requests.

If I read the code correctly, you will get only mails with patches, you won't?
Right.

So for bitbucket the tool is not (yet) performing pull requests.
Got it. So, do you think that this problem is the cause of the non-update of the translations of my plugin?
Is it possible to force (manually) the translation tool to "scan" my bitbucket repository?

Updates applied to your repository should be found by the translation tool. I will ask our server admins if they could check the logs for us.
At https://bitbucket.org/Torpedo/pycode/commits/all?page=2 is saw indeed the applied patches.
Maybe the error count of your plugin in the translation tool is (still) too high/not reset or maybe errors are created by something unknown. Only well-known error are mailed, the other errors are only (partly) stored in translation tool.

Last week I've uploaded two translations and both them have been immediately applied.
So, for me, the problem is no longer persistent.

I see still some strange errors and messages on the server, but I got the impression as well that the translation process is working sufficient. Nice!


Revert pinning Pythreejs, upstream issue resolved

Codecov Report

Merging #11192 (e952bff) into main (1dcfca7) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #11192   +/-   ##
======================================
- Coverage     63%      63%   -1%
======================================
  Files        485      485
  Lines      34121    34121
  Branches    5564     5564
======================================
- Hits       21663    21648   -15
- Misses     10399    10409   +10
- Partials    2059     2064    +5

Impacted Files
Coverage Δ

.../standalone/survey/dataScienceSurveyBanner.node.ts
66% <0%> (-6%)
:arrow_down:

src/kernels/jupyter/jupyterKernelService.node.ts
74% <0%> (-2%)
:arrow_down:

src/kernels/kernelDependencyService.node.ts
83% <0%> (-2%)
:arrow_down:

src/kernels/jupyter/finder/remoteKernelFinder.ts
87% <0%> (-2%)
:arrow_down:

src/kernels/raw/session/rawSocket.node.ts
74% <0%> (-2%)
:arrow_down:

src/standalone/api/kernelApi.ts
72% <0%> (-2%)
:arrow_down:

src/kernels/raw/launcher/kernelProcess.node.ts
71% <0%> (-1%)
:arrow_down:

src/kernels/installer/productInstaller.node.ts
80% <0%> (+1%)
:arrow_up:

src/platform/common/cancellation.ts
68% <0%> (+1%)
:arrow_up:


categories | Blacker's Blog

https://blacker1230.github.io/categories/
something to eat, something to read and someone to love

test


Can't disable csrf per form

Just tried something like this:
class MyForm(Form):
    class Meta:
        csrf = False

And a csrf not present error was thrown. I need to disable csrf so that my GET form can be accessed from outside with query parameters directly.

@italomaia MyForm(csrf_enabled=False)

I'll try that but, shouldn't the example above do the same?

I'm having this issue myself, though I'm not sure if it's a different manifestation. It seems to be because wtforms.csrf.from.SecureForm always adds a csrf token field which will then be validated when validate_on_submit() is called. Not sure how to fix this.

Maybe it is because the version of WTForms.

Using CSRF is already documented.  Flask-WTF uses the (soon to be deprecated) SecureForm from WTForms, not the new Meta implementation.  See #216.


Split openapi definition into components + requests for easier type generation to python

I'm trying to use https://github.com/koxudaxi/datamodel-code-generator to generate python types but the openapi.json file generated by this library doesn't output OpenAPI models that are used in each request (every request just has the inline schema defined) which is required by this other lib.
Would be awesome to split things out into proper models so we can have a TRPC <> openAPI <> python types/ client bridge :).
Thanks for making this library!

Hi @aaronvg, thanks for opening this issue! It is already being tracked here 👉 https://github.com/jlalmes/trpc-openapi/issues/157#issuecomment-1239368358


Add details about required scopes for Self-Hosted Runner

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@martindevnow
Thanks for opening a PR :+1: Please fill out "why" and "what's being changed" in the pull request template in the top comment in this pull request, so I can get this up for review!

@martindevnow
Thanks so much for filling out the PR template! I'll get this triaged for review :zap:


No outcome

I put in all the turnip prices from Monday and Tuesday, when I put in the one from today in the morning, I didn’t get an outcome. No time travelling.

Same. I think I broke turnip prophet.
;-;


Streaming stops after approximately 60 minutes, when streaming a file from time index 00:00:00.

I've found a bug which I have noticed several times now when streaming different mp4 files.
Streaming stops after approximately 60 minutes, when streaming a file from time index 00:00:00, and there is no error message.
When I re-stream the same file, and I skip to time index 00:60:00, then the entire video will play.
It would be nice to see if other people have experienced the same problem.
I've noticed that there is'nt a debug option to airplayer, so it's difficult to provide detailed technical information regarding what the problem really is but i'm happy to provide more information upon request and to try out any bug fixes or suggestions.
Airplayer 1.1.0, OS 10.11.2. Apple TV Software 6.2.1. 2nd Gen (MC572B/A)

I believe I'm also affected by a similar issue. Playback stops after approximately 1 hour when I am playing HLS streams served from a webserver on my local network. I have not tested this issue with a long-playing mp4 file at this time.
This is an example of how I send the command to the apple TV:
$ airplayer play http://<IP_ADDRESS>:8080/hls/index.m3u8

It plays fine for about 1 hour, then it just stops. Please let me know what further information I can bring to help debugging.
Airplayer: 1.1.0
Apple TV 3rd Gen: A1469


How to use AngularCompilerPlugin to bundle stand-alone modules?

Bug Report or Feature Request (mark with an x)
- [x] bug report
- [ ] feature request

Area
- [x] devkit
- [ ] schematics

Versions
node: v6.11.0
npm: 3.10.10
webpack: 3.11.0
angular: 5.2.10
ngtools/webpack: 1.10.2
Windows 10
Repro steps
Take any simple angular module with some components and use it as additional entry point in webpack like this:
const example = {
    context: __dirname,
    resolve: { extensions: ['.js', '.ts'] },
    output: { filename: '[name].js', publicPath: '/dist/' },
    module: {
        rules: [{
            test: /(?:\.ngfactory\.js|\.ngstyle\.js|\.ts)$/,
            include: /ClientApp/,
            loader: '@ngtools/webpack'
        }]
    },
    entry: { 'schemes-module-client': './ClientApp/schemes/schemes.client-module.ts' },
    output: {
        path: path.join(__dirname, clientBundleOutputDir),
        libraryTarget: 'commonjs'
    },
    plugins: [
        new webpack.DllReferencePlugin({
            context: __dirname,
            manifest: require('./wwwroot/dist/vendor-manifest.json')
        })
    ].concat([
        new AngularCompilerPlugin({
            mainPath: path.join(__dirname, 'ClientApp/schemes/schemes.client-module.ts'),
            tsConfigPath: './tsconfig.json',
            entryModule: path.join(__dirname, 'ClientApp/schemes/schemes.client-module#SchemesClientModule'),
            exclude: ['./**/*.server.ts']
        })])
}

The log given by the failure
The following code is produced by the AngularCompilerPlugin but it includes only a declaration of SchemesClientModule:
!function(e,t){for(var n in t)e[n]=t[n]}(exports,function(e){function t(r){if(n[r])return n[r].exports;var o=n[r]={i:r,l:!1,exports:{}};return e[r].call(o.exports,o,o.exports,t),o.l=!0,o.exports}var n={};return t.m=e,t.c=n,t.d=function(e,n,r){t.o(e,n)||Object.defineProperty(e,n,{configurable:!1,enumerable:!0,get:r})},t.n=function(e){var n=e&&e.__esModule?function(){return e.default}:function(){return e};return t.d(n,"a",n),n},t.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},t.p="/dist/",t(t.s=0)}([function(e,t,n){"use strict";Object.defineProperty(t,"__esModule",{value:!0}),n.d(t,"SchemesClientModule",function(){return r});var r=function(){function e(){}return e}();t.default=r}]));

Desired functionality
Correct bundle should be produced
Mention any other details that might be useful
It is used to work for all module types with old version of AotPlugin.
It works with a new version of AngularCompilerPlugin for root modules (for which platformBrowserDynamic().bootstrapModule was called).
It stopped working with stand-alone modules after update to AngularCompilerPlugin - produced bundle includes only code from file that was specified as entryModule and does not include any components or services from the module.
Similar issue has been mentioned on stackoverflow but with no luck.

This issue was moved to angular/angular-cli#12089


PLANNING.md - general discussion and suggestions thread

I have written up my own thoughts on the protocol in PLANNING.md, and I would say a great deal (if not all) of my thoughts in that file are open to discussion.  This is the preferred thread for that discussion.  So assuming you've read that file, what are your thoughts?

core elements
I believe that you captured most of the core elements, combat would of course be in there too but as you said, it is low priority at this moment. An auction house or some abstract form of it was going to be something else I was going to mention, but if we offload it as an optional standard, then there's no reason the protocol needs to know or care.
actors
In MUDs, the in-world representation of a NPC or PC is called a mobile(mob for short) and players are an abstraction that controlled the mobile. Conceptually, I'd define them in this same way: players and mobiles. It's like having a token(mobile) on the game board(world) and then a character sheet/score card(player). heroes could work too instead of players but that's just semantics, the main point is the separation.
communication
I added a section to outline some of the basics of the communication structure. It's all very fluid right now, but it's a good place to start. I borrowed the options construct from the telnet protocol. It's flexible enough to allow clients and servers to extend the capabilities of the protocol. We might want to define a "standard" set of options expected to be common to all clients.
world movement
I'd go even simpler and have the client tell the server where it's moving as it was moving, and the server responds with something like 201 "move ok" or 401 "illegal move". The client telling the server doesn't preclude a move check call, both could be useful and the different implementations might use it in different ways. Maybe an option?
server> DO pre_move_chk
client> WILL pre_move_chk

core elements
Yeah, my opinion is definitely leaning towards the auction house being an optional standard.  I mean maybe since items will probably be built in it might take a bit of precedence.  I'm thinking we should treat it the way we're treating combat, and make it of lower priority.
actors
That's a very good point.  Perhaps continuing the MUD tradition of referring to the tokens in the world as mobs would be a good way to do it.  And then decoupling the concept of a "player" altogether is definitely a good thought.  I will update my notes about actors in PLANNING.md accordingly.
world movement
I just want to double-check, you're suggesting that we keep a move check call like I initially suggested, but then have the actual move call also take the new location as a parameter returning a ok or illegal move value?  Assuming that's what you mean, I would agree with that.
communication
Again, I am in agreement.  I haven't done much protocol design before and what you wrote in PLANNING.md helped me understand it better and answered several questions I had floating around in my brain about how to go about various things.  This is a good start.

world movement
Sorry, it was very late when I was writing that. Basically, yes. Some servers may want to use it, others may want to opt for the continuous stream of location updates and only kick back when there's been an illegal move. I can see this being true of open world 3D rpg's. Could even have an option to only respond to location updates when there's been an illegal move; basically silence is good. This would lower the wire load for both clients and servers.


More spectrum work

This actually moves the Spectrum class into the working part of the code. OGIPLike has been moved to a subclass of SpectrumLike. There was a lot of code cleanup to make things smooth and a lot of duplicated code was centralized.

Codecov Report

Merging #163 into master will increase coverage by 0.38%.
The diff coverage is 86.16%.

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   75.34%   75.72%   +0.38%
==========================================
  Files          98      105       +7
  Lines       10804    11081     +277
==========================================
+ Hits         8140     8391     +251
- Misses       2664     2690      +26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db6ba62...379a99a. Read the comment docs.

@giacomov a couple of changes that may alter your current code:
display_ogip_model_counts -> display_spectrum_model_counts
OGIPLike(pha_file, bak_file) -> OGIPLike(observation, background)


fix: author not show fullname in contribution stats

In contribution stats menu, if author name has more than 2 words, it just show the 1st and the 2nd word.
Sometimes it don't show the email address of a contributor.
This pull request fix that issue.

Thanks for your contribution @thangdc94


Unable configure managed identity while using powershell script to automate pool creation through Azure Pipeline

Problem Description
Prerequisite:
Batch Account
Key Vault
User Assigned managed identity to provide Key vault access to Batch account
Once above resources are created, then:
I am trying to automate the pool creation through Azure Pipeline with the help of powershell script. How am I going to assign the above created managed identity to the pool. So that the application running on the pool can access their data from AKV.

@dpwatrous Is this a case where PowerShell uses an API that doesn't support managed identity?

@dpwatrous Is this a case where PowerShell uses an API that doesn't support managed identity?

How am I going to authenticate to the Batch Management APIs form azure pipeline. Is below powershell context going to work. Or Can you please send me some pointer how can I Authorization header for this from powershell script.
Get-AzBatchAccountKeys -AccountName <account_name>


Subscription generator

As a developer, I would like to have an easy way to generate subscriptions for the CRUDSS scaffolds. This way I can control the subscriptions through the UI, and ensure that all of my CRUDSS templates have the necessary data.

The difficulty managing subscriptions is demonstrated in the CRUDSS example video.

woah this will need big update. Please wait, I'll merging @martinhbramwell code

Great :-) Please keep me updated as to how I can help. Lets break this feature into sub-tasks, so that we can collaborate.

hello @brylie , nice to know that you wanna contribute. Simply just give me PR and I'll check n merge with @martinhbramwell.


Add date() Presto function

Presto has a function date() which is an alias for CAST(x AS date), which needs
to be made available in Velox as well.

FYI, I have an open issue and also a PR that is awaiting review (for a couple of days): https://github.com/facebookincubator/velox/pull/4545
Your implementation is slightly different but achieves the same.


Test debug breakpoint not hit

Fix requires js-debug nightly https://github.com/microsoft/vscode-js-debug#nightly-extension


Replacing template alias that does not use its template parameter with one that does is broken

// bindgen-flags: -- --std=c++14

namespace JS {
namespace detail {

// Notice how this doesn't use T.
template <typename T>
using MaybeWrapped = int;

}

template <typename T>
class Rooted {
    detail::MaybeWrapped<T> ptr;
};

}

/// But the replacement type does use T!
///
/// <div rustbindgen replaces="MaybeWrapped" />
template <typename T>
using replaces_MaybeWrapped = T;

Oh man this took a while to track down. I'm hitting this in the SM bindings because we don't understand mozilla::Conditional and therefore don't understand that it is using T and we shouldn't filter the type parameter out for being unused, but we aren't smart enough to understand that.
I "fixed" this with this diff:
             TypeKind::Alias(_, inner) => {
                 let parent_args = ctx.resolve_item(self.parent_id())
                    .applicable_template_args(ctx);
                 let inner = ctx.resolve_type(inner);
                 // Avoid unused type parameters, sigh.
                 parent_args.iter().cloned().filter(|arg| {
-                    let arg = ctx.resolve_type(*arg);
-                    arg.is_named() && inner.signature_contains_named_type(ctx, arg)
+                    // let arg = ctx.resolve_type(*arg);
+                    // arg.is_named() && inner.signature_contains_named_type(ctx, arg)
+
+                    true
                 }).collect()
             }

however that breaks perfectly reasonable things like tests/headers/template_typedefs.h.
Clearly we need to be smarter about type parameters, but I'm not 100% sure how to do that yet, and I'm still fumbling around this code base.

I think it's not about being smarter about type parameters, but about being replacement-aware. That's partially why the replaces annotation sucks quite a bit (and it'd come a bit more handy to have a replaced_by annotation or something, but that's way more annoying.
Right now the amount of code that is replacement-aware is minimal. Probably we should make Context::resolve_item replacement-aware by default (it's not hard, just slightly annoying), and then have another function to bypass this in the appropriate places.

After digging in more, this is not what we thought this was. Code generation, which is when we get the named types we need to emit, happens after we have already processed replacements, so the issue is not that we are failing to be replacement aware.
In fact, it looks like we end up replacing the wrong items, and then end up ignoring the replacements or something.
I'm digging in further...

First, we parse the replaces_MaybeWrapped template alias, which has the use_instead_of (né replaces) annotation, and it ends up with an id of ItemId(13):
DEBUG:bindgen::ir::context: BindgenContext::add_item(Item { id: ItemId(13), local_id: Cell { value: None }, next_child_local_id: Cell { value: 1 }, canonical_name_cache: RefCell { value: None }, comment: Some("/// But the replacement type does use T!\n///\n/// <div rustbindgen replaces=\"MaybeWrapped\" />"), annotations: Annotations { opaque: false, hide: false, use_instead_of: Some("MaybeWrapped"), disallow_copy: false, private_fields: None, accessor_kind: None }, parent_id: ItemId(0), kind: Type(Type { name: None, layout: None, kind: TemplateAlias(ItemId(16), [ItemId(15)]), is_const: false }) }, declaration: Some(Cursor( kind: NoDeclFound, loc: builtin definitions, usr: None)), loc: Some(Cursor(replaces_MaybeWrapped kind: TypeAliasTemplateDecl, loc: tests/headers/replace_template_alias.hpp:23:1, usr: Some("c:@replaces_MaybeWrapped")))

Then, we define the replacement for MaybeWrapped (ie a call to BindgenContext::replace) as ItemId(18)(!!) and not the template alias above which is ItemId(13):
DEBUG:bindgen::ir::context: Defining replacement for MaybeWrapped as ItemId(18)

Finally, we add the item with id itemId(18), which is the named template type argument T:
DEBUG:bindgen::ir::context: BindgenContext::add_item(Item { id: ItemId(18), local_id: Cell { value: None }, next_child_local_id: Cell { value: 1 }, canonical_name_cache: RefCell { value: None }, comment: None, annotations: Annotations { opaque: false, hide: false, use_instead_of: None, disallow_copy: false, private_fields: None, accessor_kind: None }, parent_id: ItemId(13), kind: Type(Type { name: Some("T"), layout: None, kind: Named("T", None), is_const: false }) }, declaration: None, loc: None

So that seems to be the bug: we should be defining the replacement as ItemId(13) not ItemId(18).
Still figuring out why this is happening in the first place.

I bet we're inserting it twice in the hashmap?

I bet we're inserting it twice in the hashmap?

Great guess! ;)
DEBUG:bindgen::ir::context: Defining replacement for MaybeWrapped as ItemId(13)
DEBUG:bindgen::ir::context: Defining replacement for MaybeWrapped as ItemId(16)
DEBUG:bindgen::ir::context: Defining replacement for MaybeWrapped as ItemId(18)

I guess we can assume the first is the correct replacement and then warn for duplicate replacement definition attempts.
Fix incoming.


Use debugger-friendly compile settings if DEBUG is set

Proposed Changes
In order to use a debugger such as Delve, binaries have to be compiled with debugging symbols and disabling some optimizations.
This PR makes it possible to build binaries in such a way.
I have a companion project to run Delve as an ephemeral container to make attaching a debugger as easy in containerized environments such as k3d (instructions).
Types of Changes
Build script changes, activated with the DEBUG environment variable set. Nothing should change without adding it.
Verification

make should continue to work as before
DEBUG=true make should build as well
bin/k3s should not be stripped after building with DEBUG=true. Eg. (on Linux, amd64):

silvio@lenovo:~/repos/k3s> file bin/k3s
bin/k3s: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, not stripped

to verify that it is actually possible to attach ad debugger, see instructions

Testing
This is only interesting for developers and build scripts are not covered with tests anyway, so I do not believe it needs automated testing.
Linked Issues
Addresses https://github.com/k3s-io/k3s/issues/6146
User-Facing Change
NONE

Codecov Report
Base: 9.72% // Head: 9.72% // No change to project coverage :thumbsup:

Coverage data is based on head (5eea70d) compared to base (26e9405).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6147   +/-   ##
======================================
  Coverage    9.72%   9.72%
======================================
  Files         138     138
  Lines       10057   10057
======================================
  Hits          978     978
  Misses       8880    8880
  Partials      199     199

Flag
Coverage Δ

unittests
9.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

LGTM; please sign your commits for DCO

LGTM; please sign your commits for DCO

Fixed, thanks for the quick review @brandond

Thanks for the reviews! Is there anything that I should do to have this merged?

We're currently in code freeze for the upstream releases. Once we have our releases out we will begin merging PRs again.


Uncaught Error: Error from Instagram: invalid media id

Hello, I'm getting this error with the code below.
Couldn't find the reason why this happening and I wanted get help.
Client id and accessToken are just created and cannot be wrong. I tried this several time and couldn't get this work.
<!DOCTYPE html>

    <meta charset="UTF-8">
    <title>Test</title>

Click!

Are you in sandbox mode? If so, you won't be able to get media or users who aren't also sandboxed.
https://www.instagram.com/developer/sandbox/

Yes, sandbox clients only ever have basic access permissions, which means that endpoints like /popular don't work. Sorry to be the bearer of bad news!


[Improvement][service]fix method name error

Tips

Thanks very much for contributing to Apache DolphinScheduler.
Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds checkstyle plugin.)
Brief change log
(for example:)

Add maven-checkstyle-plugin to root pom.xml

Verify this pull request
(Please pick either of the following options)
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added dolphinscheduler-dao tests for end-to-end.
Added CronUtilsTest to verify the change.
Manually verified the change by testing locally.

thanks for your first contribution, looking forward to your deep participation


Extract error messages into diagnostic.c and use canonical message IDs

The parser now passes around yp_diagnostic_id_t for diagnostic messages instead of character strings, and we rely on the function diagnostic_message() to resolve that to a string.
In addition, many messages were edited so that the parser expresses coordinate ideas in similar form [1] using consistent voice and typographic conventions.
Closes #1379, and makes progress on #941.
[1]: Strunk & White rule 19

I think we should prefix it with YP_DIAG instead of YP_ERR since it encompasses warnings as well

I had used YP_ERR for errors and YP_WARN for warnings ... happy to change it to YP_DIAG but wanted to make the convention this PR adopted clear first.
Will look at the rust failures, I hadn't run those locally before pushing.

@flavorjones OH! Sorry I didn't see the warnings at the bottom. I think that's fine as it is.

@kddnewton rebased, fixed the rust tests.
Also pushed a commit with a test:rust rake task and updated CONTRIBUTING.md.


Update go lib to integrate with addon-framework

Signed-off-by: Jian Qiu<EMAIL_ADDRESS>

/hold

/unhold


Feature/Implementing new UI for Goals

Is your feature request related to a problem? Please describe.
Yes, this request is related to a problem. Users had no viable way to view their goals in a clear and concise format, whilst also being able to edit details of said goals. The interface itself was not very user-friendly as well.
Describe the solution you'd like
I want to create an interface where it is clear to the user what to input and what is required to make a goal. I also want them to be able to see their goals directly and edit them if need be.
Describe alternatives you've considered
This is the core functionality of a Goals section so there aren't any viable alternatives to this issue.
Additional context

Approved

Approved


Solve #229

Before setting CPX_PARAM_SCRIND, check whether the user did not specify either CPX_PARAM_SCRIND or CPXPARAM_ScreenOutput (two different names, one parameter).

A test like this, on the dictionary after calling the constructor?

I've rebased this PR onto master. Could it be merged?


Fix a typo in the pack install alias

Teeny tiny typo :) Or maybe not even a typo, the PR might’ve been opened when we still had # as a tentative version separator.

LGTM :+1:

Current coverage is 77.06% (diff: 100%)

Merging #3061 into master will increase coverage by 0.08%

@@             master      #3061   diff @@
==========================================
  Files           430        430
  Lines         22017      22017
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          16949      16967    +18
+ Misses         5068       5050    -18
  Partials          0          0

Powered by Codecov. Last update 669e303...009ebf0