{ "brace_style": "preserve-inline" } not working as expected with multiline function parameters

Description
Hi, first a big thanks to you guys for such a great library !
I have a problem when I use multiline function arguments that contains objects:
// This is working OK for me and it is very readable
myFunc('myString',
    myFunc2(),
    andSoOn());

Expected Output
But when I try:
// This is working OK for me and it is very readable
myFunc('myString',
    { myProp: true }, // I have just insterted this object
    andSoOn());

Actual Output
All is reformatted in one line...
myFunc('myString', { myProp: true }, andSoOn());

I am pretty sure it has to do with { "brace_style": "preserve-inline" } rule.
Environment
OS: Linux Mint
code Editor: VSCode
Settings
Example:
{
    "editor": {
        "formatOnSave": true
    },
    "brace_style": "collapse,preserve-inline"
}

Thank you again ;)

It is the collapse setting that is pulling the open-curly brace back to the previous line.

Ok, I have tried with config:
{
    "brace_style": "none,preserve-inline"
}

And the result is the same...also I think this happen only in function params context, all others cases are ok,  hope I have some time to check it out.

Hi, for those looking for a solution, here is a workaround:
myFunc( //
    { myProp: true }, //
    { myProp: true }, //
    { myProp: true });

When I put empty comment it wont reformat to one line. At least on VScode. It doesn't render less lisible and is easily removable projectwide with a search and replace (//\n)
Hope it can help...


Chore: bump @solana/web3.js in anchor-ts

Bumping in order to align with the @solana/web3.js in the Anchor tests package. I needed to add a ts-ignore to fix a type error. This feels unrelated to the tests and more to TS though, since the tests still passed before it threw a type error.

Will this update be deployed with the next release of the project-serum./anchor package? The @solana/web3.js version bump is also required to do anything with address look up tables or versioned transactions with Anchor.


problems in vim built-in terminal when vim is opened in tmux

When I use the plugin in vim built-in termimal in tmux, every character I typed was followed by an extra "6 ", and there is an extra "q" at end.
To produce:

create and enter a new tmux session by tmux
open vim by vim -u NONE
open terminal by :term
enter zsh shell by zsh
type any character

Hi @ZhiyuanLck
Thanks for the reporting. I will pay attention to this issue and welcome to star this project for further update in the future.
Thanks and regards

Hi @ZhiyuanLck
Thanks for the reporting and this issue has been addressed and fixed. Please update your plugin to the latest version.
Thanks and regards

Cool!


[Event Request] Need add event to Codeunit "Purch.-Post" function GetAmountRoundingPrecisionInLCY

Add please event OnAfterGetAmountRoundingPrecisionInLCY to function GetAmountRoundingPrecisionInLCY
local procedure GetAmountRoundingPrecisionInLCY(DocType: Enum "Purchase Document Type"; DocNo: Code[20]; CurrencyCode: Code[10]) AmountRoundingPrecision: Decimal
var
    PurchHeader: Record "Purchase Header";
begin
    if CurrencyCode = '' then
        exit(GLSetup."Amount Rounding Precision");
    PurchHeader.Get(DocType, DocNo);
    AmountRoundingPrecision := Currency."Amount Rounding Precision" / PurchHeader."Currency Factor";
    if AmountRoundingPrecision < GLSetup."Amount Rounding Precision" then
        exit(GLSetup."Amount Rounding Precision");
    exit(AmountRoundingPrecision);

    OnAfterGetAmountRoundingPrecisionInLCY(DocType, DocNo, CurrencyCode, AmountRoundingPrecision);
end;

Event:
 [IntegrationEvent(false, false)]
local procedure OnAfterGetAmountRoundingPrecisionInLCY(DocType: Enum "Purchase Document Type"; DocNo: Code[20]; CurrencyCode: Code[10]; AmountRoundingPrecision: Decimal)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


[BUG] - Bypass app blocking

You can bypass the app lock by long pressing the app widget in the Android top menu.

Device: Pixel 3a
Android Version: Android 12
App version: 3.4.8

Steps to reproduce the behavior

Lock the app
Add the app widget to the top menu in Android
Long press on this widget to open the app without lock screen

Expected behavior: The app should display the lock screen without providing access to the app itself.

Hello! This is fixed in the latest nightly version here and will be part of the next release.


ImportanceTransferTransaction

org.nem.core.model.ImportanceTransferTransaction cannot be cast to org.nem.core.model.MultisigAggregateModificationTransaction
See description in forum topic about 0.6.75
garp

exception visible in logs or on the console was not affecting importance transfer.
will be fixed in 0.6.76


Bump to 0.8.1

@pdfkit/rb Releasing 0.8.1 tomorrow with the following changes:

Fix shell escaping issues for Windows (thanks muness)
Fix shell escaping issues for URLs, introduced in 0.5.3 release

:shipit:


Refactor serialization generation

Description
Previously the serialization code was built inside the SerializationWriter class.
Since the model with the serialization actually owns those methods, this PR changes the code so that the SerializableObjectType now produces a list of methods to contain those interface implementation methods and the SerializationWriter could just dumbly write whatever methods it gets, which is our expectation for a writer to do.
This PR introduces a new type ObjectTypeSerialization to collect all possible serializations, in order to make it "open to expand", by making all possible serializations as properties of the new type.
For instance, before change, if we would like to add a new format bicep, a ton of method signature needs to be changed, and now we just need to add a new property in ObjectTypeSerialization, build a proper value for it, and then write a new builder to build the specific part of that (new switch-cases should be added).
This PR also introduces a clean-up for those interface implementation methods. Previously the JsonSerializationMethodsBuilder builds the methods for IJsonModel<T>, which makes sense, but it also builds the methods for IPersistableModel<T>, which does not make much sense because this method is not only meant for Json, for example, xml serialization also must be considered as part of its implementation.
The clean up is that this PR creates a new class SerialzationMethodsBuilder which will collect the methods created by other serialization method builds (Json and Xml), and it handles the creation for IPersistableModel<T>.
Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

LGTM, just one suggestion about the MethodsBuilder classes hierarchy.


[staging-next] ocamlPackages.ca-certs: disable test suite expecting nss db

nss-cacert has updated a few certificates, including Google's which
breaks the test suite of ca-certs expecting the old version.

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build ocamlPackages.comby

@ofborg build comby


Expose all production configuration options via the helm chart

Currently the only explicitly expose configuration option is logLevel. There are many others which should be correctly exposed in the helm chart (e.g. https://github.com/weaveworks/weave-gitops/blob/f1c4bb312fdac77828fcae7db85e5ec0bf9cba02/cmd/gitops-server/cmd/cmd.go#L70-L91)
These weren't exposed as part of #1779 as I was unsure exactly what these all do, which are needed and how they should be configured.
Acceptance Criteria

All flags and environment-variables that it is reasonable (cc @sympatheticmoose/@JamWils for what qualifies as 'reasonable')  to expect an end-user to set are exposed via values.yaml
They are exposed with reasonable defaults
values.yaml documents what the various flags mean & do.
Where possible values are validated to ensure correct configuration (this can be done via a values.schema.json file  and/or flow control)

@SamLR and @ozamosi should we do this or close it?

@JamWils I'm honestly not sure because I'm not sure which of the flags should be exposed (e.g. devMode shouldn't, but should mtls?)
I think the main things that users will likely want to change are exposed and new ones should be picked up and checked as part of PRs so I think we can mark this as closed.


View/screen/widget to display licenses

Once we have https://github.com/flutter/flutter/issues/109 we can display that info somewhere in the app.

This exists now. It doesn't actually show any licenses yet, but that's next.


Fix accordion ssr

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.05%) to 83.314%

Files with Coverage Reduction
New Missed Lines
%

packages/accordion/src/hooks/useMeasureHeight.ts
1
85.71%

Totals

Change from base Build<PHONE_NUMBER>7:
0.05%

Covered Lines:
10181

Relevant Lines:
11226

💛  - Coveralls


[network-path] Add protocol

What does this PR do?
[network-path] Add protocol

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge

/merge -c

/merge


Raise if Beacon.LiveAdmin.Plug is missing in the router pipeline

See https://github.com/BeaconCMS/beacon_live_admin/issues/70#issuecomment-1719523534

PR #75 was submitted to try to close this issue.


Replace text "[CHANGEME] This app collets location data for FEATURE X and FEATURE Y"

Your Environment

Plugin version: latest version, 4.4.6
Platform: iOS and Android
Device OS version: Android 11
Device manufacturer / model: OnePlus 5T
XCode version: latest version, 13.2.1
Capacitor info

Capacitor Doctor

Latest Dependencies:

  @capacitor/cli: 3.4.1
  @capacitor/core: 3.4.1
  @capacitor/android: 3.4.1
  @capacitor/ios: 3.4.1

Installed Dependencies:

  @capacitor/core: 3.4.1
  @capacitor/android: 3.4.1
  @capacitor/ios: 3.4.1
  @capacitor/cli: 3.4.1

Plugin config provided to #ready:

const optionsGeofence: Config =
{
        url: WebService.URL + "geofencing/event",
        params:
        {
	        'global': this.GlobalService.Get(),
	        'device': pushRegistrationData,
        },
        headers:
        {
	        'Content-Type': 'application/json',
	        'Authorization': `Bearer ${ session?.Token?.AccessToken }`
        },
        autoSync: true,
        persistMode: BackgroundGeolocation.PERSIST_MODE_ALL,
        desiredAccuracy: BackgroundGeolocation.DESIRED_ACCURACY_HIGH,
        geofenceModeHighAccuracy: true,
        geofenceProximityRadius: 2000,
        locationUpdateInterval: environment.production ? 10000 : 2000,
        distanceFilter: environment.production ? 5 : 2,
        stopTimeout: 5,
        logLevel: environment.production ? BackgroundGeolocation.LOG_LEVEL_OFF : BackgroundGeolocation.LOG_LEVEL_WARNING,
        debug: environment.production ? false :  true,
        stopOnTerminate: false,
        startOnBoot: true,
        locationAuthorizationRequest: 'Always',
        backgroundPermissionRationale:
        {
	        title: 			this.TranslateService.instant("BACKGROUND_GEOLOCATION_PERMISSION_QUESTION"),
	        message: 		this.TranslateService.instant("BACKGROUND_GEOLOCATION_PERMISSION_DESCRIPTION"),
	        positiveAction:        this.TranslateService.instant("BACKGROUND_GEOLOCATION_PERMISSION_ACCEPT"),
	        negativeAction:       this.TranslateService.instant("BACKGROUND_GEOLOCATION_PERMISSION_REJECT"),
        },
        locationAuthorizationAlert:
        {
	        titleWhenNotEnabled: this.TranslateService.instant("BACKGROUND_GEOLOCATION_PERMISSION_LOCATION_WHEN_NOT_ENABLED_QUESTION"),
	        titleWhenOff: 		 this.TranslateService.instant("BACKGROUND_GEOLOCATION_PERMISSION_LOCATION_WHEN_OFF_QUESTION"),
	        instructions: 		 this.TranslateService.instant("BACKGROUND_GEOLOCATION_PERMISSION_LOCATION_INSTRUCTIONS"),
	        cancelButton: 		 this.TranslateService.instant("BACKGROUND_GEOLOCATION_PERMISSION_LOCATION_CANCEL_BUTTON"),
	        settingsButton: 	 this.TranslateService.instant("BACKGROUND_GEOLOCATION_PERMISSION_LOCATION_SETTINGS")
        },
        notification:
        {
	        title: this.TranslateService.instant("BACKGROUND_GEOLOCATION_NOTIFICATION_GEOFENCING_WHILE_IN_USE_TITLE"),
	        text: this.TranslateService.instant("BACKGROUND_GEOLOCATION_NOTIFICATION_GEOFENCING_WHILE_IN_USE_TEXT")
        }
}

Expected Behavior
Show the permissions alerts with the correct texts.
Actual Behavior
A default text is presented: [CHANGEME] This app collets location data for FEATURE X and FEATURE Y.

Steps to Reproduce
Setup a config object with translations and try to run the app on an Android device.
Context
I'm using the Capacitor Background Geolocation plugin on a Capacitor/Ionic/Angular app.
In my app I use a Translation service to translate resources keys. The keys are correctly translated, but when they are set to the plugin one of the texts are not presented showing a default text value.

See api docs Config.backgroundPermissionRationale

And do not call any method that requests location until .ready() resolves (Eg .start())
The method .ready() is so-named for a reason (the plugin is not "ready" until .ready resolves.)

also consider using reset() instead of ready()

also consider using .reset() instead of .ready() to immediately reflect any changes (once set with some values, ready() will not update those values anymore):
await BackgroundGeolocation.ready({});
await BackgroundGeolocation.reset(optionsGeofence);

It's  because you are copy/pasting code from the example (reset: false).  Almost nobody but me needs reset: false.
The only reason reset: false exists is so that the Settings screen in the example app can control the config and not be reset to the Config provided to .ready() each time.  This is not a typical use-case for end-users.
Remove reset: false from your config and get rid of your call to .reset().

oh well that's a bummer :( in my case I had a typo in url prop on first call, and even though it was fixed right away, it took a fair amount of time to figure out what was going on and why no calls were coming through


"-convert_videos true" windows support? HandBrakeCLI.exe location?

I am trying both the 386 and amd64 version of scraper.exe with the '-convert_videos true' switch to recompress videos for raspberry pi use. The videos remain in their original 640x480 sizes and do not get converted. HandBrakeCLI.exe is in the same folder as the roms and scraper.exe. Am I doing something wrong or does this function only work in the RPi version of the scraper?

Thanks for testing. I wasn't sure if this would work in windows. Do you see any errors? or does everything appear to work but doesn't actually transcode? Are these files already downloaded from a previous run? Looking at the code it only converts videos it downloads.

videos not previously downloaded. Tested with both a fresh rom folder with no images or videos yet as well as with images already downloaded with a previous scraper.exe release. No errors on the command line either. No prompt to point to the HandBrakeCli.exe (which can I be so humble as to recommend a switch to provide HB.exe path?) I am exclusively using screenscraper.fr as the source. Their videos are 640x480 .mp4 files if that makes any difference. -- LOVE this application, BTW! Used to use UXS but it always crashes and it's way too slow when compaired to yours. Just wish you had the "Arcade (moon)" option they do for MAME/FBA/NeoGeo where the screenshot and marquee get combined to make a isometric view of an arcade cabinet. (hint, hint)

I'll pull out my copy of windows XP and do some testing tonight.
It should look for the program in the path so will check to see where it is normally installed by default and make sure to update the windows path like I have to do for 7zip. I think it would also look in the current working directory but I can test. I think it should just error out and complain if the flag is set and it can't find the program or the parameters are wrong, etc. But this was submitted by someone else so I haven't actually used it. If it is appropriate, I can see about adding a flag for the path but hopefully that is somewhat automatic and the user doesn't have to deal with all that.
Thanks for the kind words! It is hard to compete with the speed and reliability of a compiled language, but screech is awesome and makes a great app. I did rearchitect my image processing then blatantly steal his mix3 and mix4 image templates. I haven't found a way to natively transform images in to a non-square shape or however you actually word that. Basically transforming it to have the perspective of being on the arcade screen. I can look again or since we have been recently adding the ability to use third party apps, using a standard third party binary.

I did some tests and it seems to work with the .exe in the C:\Program Files\Handbrake (after my latest change) or the working directory. This is on an old version that works on windows XP in a VM. Maybe @ainmosni can shed some light.

I'll check on my end too. The help file said handbrake CLI so I downloaded handbrake CLI.exe not the normal app with GUI. It was available as a free standing exe only so I only tried it in the local directory. I'll download the full installer and try again. Thank you.

Even though I haven't tested it, it should work as long as HandBrakeCLI is in the PATH. (Sorry for the slow response btw)

@ainmosni NP. I did end up testing on windows XP with version 0.99 I think. Whatever is the last version that worked on XP. It worked but there is a much newer version so can't do much testing. I did notice if the exe wasn't in the path there was an error like HandbrakeCLI not in %PATH% or something like that. I tested with it in the Program Files/Handbrake/ folder and with the scraper and it in the same directory and it worked. If the parameters were different then it would probably complain with an error.

Having HandBrakeCLI.exe next to the scraper works on Windows 10 without the need of any installation.

Thanks @paradadf for testing this on a modern version of windows. I'll go ahead and close this out for now. If there are other issues we can reopen or start a new issue.

I still can't get it to work or give an error on Windows 10. I have both handbrake installed and the HandBrakeCLI.exe in both the program path AND right next to the scraper.exe. I have tried both the 32bit and 64bit versions (of version 1.4.2 and 1.4.1). Here is the exact command I am running. The images and videos download but the videos do not get converted from 640x480 to 320x240. If anyone has any suggestions I'm open to trying them. Thanks in advance...
scraper.exe -console_img mix4 -console_src ss,gdb,ovgdb -missing _missing_roms.txt -region us,wor,eu,jp -video_dir videos -video_path videos -download_videos true -convert_videos true -ss_user {my_usr} -ss_password {my_pass}

Oops closed to quickly. To check, the videos directory is empty before you start? I'll try this exact command next time I get a moment.

@esmith13 you could try this:
https://github.com/paradadf/recaltools/tree/master/fastscraper
Don't forget to open the file and using -download_videos="true"
You might also want to change -video_path.

@paradadf - just tried your bat file and this was the output running it with and without admin rights:
'chcp' is not recognized as an internal or external command,
operable program or batch file.
'reg' is not recognized as an internal or external command,
operable program or batch file.
Can't get OS's language. English will be used.
'ping' is not recognized as an internal or external command,
operable program or batch file.
ERROR: No internet connection available. Exiting...

@esmith13 it seems that you have a special (dismembered) windows installation, as some basic commands are missing.
What kind of setup do you have?

Dell XPS 8700 that shipped with Windows 7 Ultimate and was updated to Windows 10 via Microsoft's free upgrade path. It is my work PC. I'm the head of our IT department. I'm no programmer nor a great script writer by far but I know my way around a PC.

Another thing that would be interesting to check is while the scraper is running, if you open the videos folder do you see it creating files that look like rom_name-video-converting.mp4. The process downloads the video to rom_name-video.mp4 then will call handbrake to convert the video to rom_name-video-converting.mp4 then rename the file back to rom_name-video.mp4.
Might help narrow down the issue, if no errors are being thrown, I would suspect maybe something odd is happening with the rename, like it is slightly failing and not actually overwriting the original file.

it does not convert at all. I watch the videos folder during the process and as each game is listed in the command shell a mp4 file appears with the naming convention {game_name}-video.mp4. There are no temp files or increases and then decreases in file count. It simply adds one file for each game listed.

I tried this today with HandBrakeCLI.exe in the same directory as scraper.exe and also separately with Handbrake installed in the default location.  I get ffmepg not found in PATH error.


Remove strategies, use Login modules directly

Remove strategies in favor of making being the actual plugs
Turn Doorman.Login into a useable module that provides some
boilerplate code for implementing the Plug behaviour.
Remove all functionality of Doorman module in favor of using it to
store helpers written in a future PR.
Make Doorman.Auth.Bcrypt less configurable and more conventional by
assuming a virtual field named password and persisted field called
hashed_password.

:shipit:


python polylint: upstream package and repository has been removed

@offlinehacker
https://github.com/bendavis78/polylint has disappeared. Any idea where it went?

polylint was removed in 97a40f6de67ea64d93c8a1b30daede3c22026f88


add function of writing test case to verify code when removing the patch

Features
add function of writing test case to verify code when removing the patch

Codecov Report
Attention: Patch coverage is 41.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 81.39%. Comparing base (916185d) to head (eb2ccae).
Report is 20 commits behind head on swebench_di.

Files
Patch %
Lines

metagpt/roles/di/data_interpreter.py
41.66%
7 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff               @@
##           swebench_di    #1051      +/-   ##
===============================================
- Coverage        81.85%   81.39%   -0.46%
===============================================
  Files              246      246
  Lines            13724    13736      +12
===============================================
- Hits             11234    11181      -53
- Misses            2490     2555      +65

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[LocalGitRepo] Fixing repo slug when it contains .git

Fixes #119

1 Error

:no_entry_sign:
Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.

1 Warning

:warning:
Author @marcelofabri is not a contributor

  Generated by :no_entry_sign: danger

Ace, makes sense


ES6 Destructuring / default arguments

The following code:
function add({a=1, b=2} = {}) {
  return a + b;
}
add({a: 2}); // 4

Results in JSHint complaining:

Expected ',' and instead saw '='.
Expected an identifier and instead saw '1'.
Expected ',' and instead saw '='.
Expected an identifier and instead saw '2'.

The code is valid and gets transpiled successfully by Babel.
Apologies if this is already reported, I couldn't find anything in a search of the issues

Duplicate of #1941 and fixed on master.

Thanks and sorry for the noise...


[Performance] skip degemm for "simple" symmetries

In pos_slice_to_ifft and related, there is a matrix matrix multiplication of the form
scipy.linalg.cython_blas.dgemm(transn, transn, &ndcom, &n_inter, &geodim, &dfac, params_basis_r, &ndcom, pos_slice, &geodim, &zero_double, dtmp, &ndcom)

Can this be replaced by a sequence of daxpys if params_basis_r has only ones and zeros (knowing it is essentially a rotation matrix) ?

after tests, in cases where 3/4 elements of params_basis_r are zero, there is no time advantage asymptotically, and up to a 3x advantage for small n.

Other idea : when possible, circumvent the whole sparse process, and do ifft on param buf pos directly

Detecting identity loop+dimension-wise instead of simply loop-wise might allow me to use fancier fft as well (dct, dst of various types)

Done in efb47bf .
Gain in CPU time is approx a factor 2, as expected


Add isResourceTypeValid tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.82%. Comparing base (fd44773) to head (434ea5e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3802      +/-   ##
==========================================
+ Coverage   65.53%   65.82%   +0.29%
==========================================
  Files         514      514
  Lines        9934     9934
  Branches     2170     2328     +158
==========================================
+ Hits         6510     6539      +29
+ Misses       3421     3392      -29
  Partials        3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Broadcom 4354 chip doesn't work

Currently the Bluetooth / Wi-Fi chip doesn't seem to power on, my assumption is that there is a GPIO control somewhere

Have you tried rfkill?

The wifi chip doesn't show up in the dmesg, looks like it doesn't get activated (enable pin set to LOW?) nor in ˋip linkˋ / ˋifconfigˋ.
I may have found the source of the problem though: we're missing some consumers, that are in Google's tegra210-smaug-sysedp.dtsi

The first problem was that the module Kconfig file had a different name, therefore it didn't get compiled. Now we have to port the brcmdhd driver to 4.11.
These are the errors, as of today:
drivers/net/wireless/bcmdhd/dhd_linux.c: In function 'dhd_watchdog_thread':
drivers/net/wireless/bcmdhd/dhd_linux.c:3211:22: error: storage size of 'param' isn't known
   struct sched_param param;
                      ^
drivers/net/wireless/bcmdhd/dhd_linux.c:3211:22: warning: unused variable 'param' [-Wunused-variable]
drivers/net/wireless/bcmdhd/dhd_linux.c: In function 'dhd_dpc_thread':
drivers/net/wireless/bcmdhd/dhd_linux.c:3328:22: error: storage size of 'param' isn't known
   struct sched_param param;
                      ^
drivers/net/wireless/bcmdhd/dhd_linux.c:3328:22: warning: unused variable 'param' [-Wunused-variable]
drivers/net/wireless/bcmdhd/dhd_linux.c: In function 'dhd_rxf_thread':
drivers/net/wireless/bcmdhd/dhd_linux.c:3389:22: error: storage size of 'param' isn't known
   struct sched_param param;
                      ^
drivers/net/wireless/bcmdhd/dhd_linux.c:3389:22: warning: unused variable 'param' [-Wunused-variable]
drivers/net/wireless/bcmdhd/dhd_linux.c: In function 'dhd_allocate_if':
drivers/net/wireless/bcmdhd/dhd_linux.c:4436:11: error: 'struct net_device' has no member named 'destructor'
   ifp->net->destructor = free_netdev;
           ^
drivers/net/wireless/bcmdhd/dhd_linux.c:4438:11: error: 'struct net_device' has no member named 'destructor'
   ifp->net->destructor = dhd_netdev_free;
           ^
  CC      drivers/net/wireless/bcmdhd/hndpmu.o
drivers/net/wireless/bcmdhd/dhd_linux.c: In function 'dhd_os_get_image_block':
drivers/net/wireless/bcmdhd/dhd_linux.c:7302:26: warning: passing argument 2 of 'kernel_read' makes pointer from integer without a cast
  rdlen = kernel_read(fp, fp->f_pos, buf, len);
                          ^
In file included from ./include/linux/huge_mm.h:6:0,
                 from ./include/linux/mm.h:451,
                 from drivers/net/wireless/bcmdhd/include/linuxver.h:72,
                 from drivers/net/wireless/bcmdhd/dhd_linux.c:29:
./include/linux/fs.h:2822:16: note: expected 'void *' but argument is of type 'loff_t'
 extern ssize_t kernel_read(struct file *, void *, size_t, loff_t *);
                ^
drivers/net/wireless/bcmdhd/dhd_linux.c:7302:37: warning: passing argument 3 of 'kernel_read' makes integer from pointer without a cast
  rdlen = kernel_read(fp, fp->f_pos, buf, len);
                                     ^
In file included from ./include/linux/huge_mm.h:6:0,
                 from ./include/linux/mm.h:451,
                 from drivers/net/wireless/bcmdhd/include/linuxver.h:72,
                 from drivers/net/wireless/bcmdhd/dhd_linux.c:29:
./include/linux/fs.h:2822:16: note: expected 'size_t' but argument is of type 'char *'
 extern ssize_t kernel_read(struct file *, void *, size_t, loff_t *);
                ^
drivers/net/wireless/bcmdhd/dhd_linux.c:7302:42: warning: passing argument 4 of 'kernel_read' makes pointer from integer without a cast
  rdlen = kernel_read(fp, fp->f_pos, buf, len);
                                          ^
In file included from ./include/linux/huge_mm.h:6:0,
                 from ./include/linux/mm.h:451,
                 from drivers/net/wireless/bcmdhd/include/linuxver.h:72,
                 from drivers/net/wireless/bcmdhd/dhd_linux.c:29:
./include/linux/fs.h:2822:16: note: expected 'loff_t *' but argument is of type 'int'
 extern ssize_t kernel_read(struct file *, void *, size_t, loff_t *);
                ^
drivers/net/wireless/bcmdhd/dhd_linux.c: In function 'dhd_set_version_info':
drivers/net/wireless/bcmdhd/dhd_linux.c:9148:3: error: implicit declaration of function 'dhd_bus_chip_id' [-Werror=implicit-function-declaration]
   "\n  Chip: %x Rev %x Pkg %x", dhd_bus_chip_id(dhdp),
   ^
drivers/net/wireless/bcmdhd/dhd_linux.c:9149:3: error: implicit declaration of function 'dhd_bus_chiprev_id' [-Werror=implicit-function-declaration]
   dhd_bus_chiprev_id(dhdp), dhd_bus_chippkg_id(dhdp));
   ^
drivers/net/wireless/bcmdhd/dhd_linux.c:9149:3: error: implicit declaration of function 'dhd_bus_chippkg_id' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
scripts/Makefile.build:313: recipe for target 'drivers/net/wireless/bcmdhd/dhd_linux.o' failed
make[4]: *** [drivers/net/wireless/bcmdhd/dhd_linux.o] Error 1
make[4]: *** Waiting for unfinished jobs....
drivers/net/wireless/bcmdhd/bcmwifi_channels.c: In function 'wf_chspec_aton':
drivers/net/wireless/bcmdhd/bcmwifi_channels.c:353:2: error: implicit declaration of function 'tolower' [-Werror=implicit-function-declaration]
  c = tolower((int)a[0]);
  ^
cc1: some warnings being treated as errors
scripts/Makefile.build:313: recipe for target 'drivers/net/wireless/bcmdhd/bcmwifi_channels.o' failed
make[4]: *** [drivers/net/wireless/bcmdhd/bcmwifi_channels.o] Error 1
scripts/Makefile.build:572: recipe for target 'drivers/net/wireless/bcmdhd' failed
make[3]: *** [drivers/net/wireless/bcmdhd] Error 2
scripts/Makefile.build:572: recipe for target 'drivers/net/wireless' failed
make[2]: *** [drivers/net/wireless] Error 2
make[2]: *** Waiting for unfinished jobs....
scripts/Makefile.build:572: recipe for target 'drivers/net' failed
make[1]: *** [drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
Makefile:1023: recipe for target 'drivers' failed
make: *** [drivers] Error 2

@denysvitali bcmdhd shouldn't be needed, the brcmfmac driver should work fine

Actually, the problem may be this.

It still doesn't work. Apparently the WiFi chip needs to be enabled via a GPIO, but I still haven't figured out how to do it.
cc/ @samt43 @vartom

Enabled WiFi, In the kernel logs it now asks for firmware. I did not manage to find the working firmware yet. ps Firmware from rootfs, he does not see.
https://github.com/vartom/linux-smaug/commit/becac257eb89e443c5e9fa9a1eadf926987566cf

Is the chip enabled? The problem w/ the Broadcom drivers for the Pixel C is that they manually enable some GPIOs in order to activate / reset the chip.
The mainline broadcom driver doesn't seem to work and porting Google's 3.18 brcmdhd driver to mainline seems an intensive task.
https://android.googlesource.com/kernel/tegra/+/android-8.1.0_r0.23/drivers/net/wireless/bcmdhd/
CC/ @sam43

I do not think that adding a driver from 3.18 is a good idea. If the built-in driver does not work, it's best to try the driver from 4.4 from NVIDIA

Indeed. We need to find a solution to integrate the chip power on feature in the broadcom mainline drivers.
By the way, you can download the needed firmware files by using my ./getvendor.sh script from the 4.15 branch

WiFi works. In your Linux build through the interface is not defined. In the assembly @Samt43 WiFi connects and works.
Nothing new was added to the DT. Only added firmware.

Can you provide some instructions / make a PR to the tegra-nouveau-rootfs repo to enable it?

@Vartom I never tried to make it work until now... But you mean it's
working with my courrent rootfs on GitHub ? Did you use 4.8 kernel ?
That's great !
Le jeu. 15 févr. 2018 17:00, Denys Vitali<EMAIL_ADDRESS>a
écrit :

Can you provide some instructions / make a PR to the tegra-nouveau-rootfs
repo to enable it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/denysvitali/linux-on-pixel-c/issues/3#issuecomment-365972465,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABOvFwP4aULHJFrQYLD7THE_pno8Vsztks5tVFSNgaJpZM4OyFHn
.

I mean the system from the first message of the topic
Kernel 4.15.2 from my repo.

That's great !
I suppose the only thing to do then is to fix the current built rootfs by installing networkmanager (if i remember that was the one i installed some time ago). When creating rootfs, please use my generaterootfs script to fix suid correctly.
On kernel side, everything this to be there too ! :)

I'll take a look at this and fix the rootfs script accordingly :)
@vartoom where are the firnware files for the BCM4354 module, and where did you placed them? Did you include them on the kernel or you've added them to the rootfs?

Completed the necessary patches in the repo.

Can you make a PR?

I began to notice problems in Android. This began after the inclusion of the WiFI in the kernel and the entry into Arch Linux(Samt43). To fix the problem, I cleaned Dalvik Cash. Something bad is happening to the file system.

Hi @vartom ,
I compiled your 4.15 kernel and run my pixel C on it, compilation with tegra210 config was fine.
I couldn't have wlan node created unfortunatly due to this :
[    1.194287] brcmfmac mmc1:0001:1: Direct firmware load for brcm/brcmfmac4354-sdio.clm_blob failed with error -2
It seems that firmware couldn't be loaded, so i checked CONFIG_FIRMWARE_IN_KERNEL=y and CONFIG_EXTRA_FIRMWARE and it seems that everything in correct to have firmware built in kernel.
As it works for you, im wondering if you put your firmware in initrd too.
Any idea ?!
Thanks !

Sorry for this, it seems that brcmfmac4354-sdio.clm_blob is optional according to kernel code.
I will recheck tonight why i couldn't find any wlan reference in dmesg. Maybe everything was working !

All right brcmfmac4354-sdio.clm_blob is optional.

It works.
I'll fix my initramfs accordingly and the rootfs.

@denysvitali  Which version of rootfs you use?

I'm using a custom one I built - which is very similar to the latest build available, I'll push the changes in a few minutes

Unfortunately Bluetooth doesn't work yet, even though it appears in the rfkill list and in /sys/class/bluetooth/hci0
[root@alarm hci0]# ls -la
total 0
drwxr-xr-x 4 root root    0 Feb 19 14:44 .
drwxr-xr-x 3 root root    0 Feb 19 14:44 ..
lrwxrwxrwx 1 root root    0 Feb 19 14:59 device -> ../../../mmc1:0001:3
drwxr-xr-x 2 root root    0 Feb 19 14:59 power
drwxr-xr-x 3 root root    0 Feb 19 14:44 rfkill0
lrwxrwxrwx 1 root root    0 Feb 19 14:44 subsystem -> ../../../../../../../../../class/bluetooth
-rw-r--r-- 1 root root 4096 Feb 19 14:44 uevent

[root@alarm ~]# rfkill
ID TYPE      DEVICE      SOFT      HARD
 0 bluetooth hci0   unblocked unblocked
 1 wlan      phy0   unblocked unblocked

Feb 19 14:44:34 alarm systemd-udevd[224]: created db file '/run/udev/data/+bluetooth:hci0' for '/devices/platform/700b0200.sdhci/mmc_host/mmc1/mmc1:0001/mmc1:0001:3/bluetooth/hci0'
Feb 19 14:44:34 alarm systemd-udevd[224]: created db file '/run/udev/data/+rfkill:rfkill0' for '/devices/platform/700b0200.sdhci/mmc_host/mmc1/mmc1:0001/mmc1:0001:3/bluetooth/hci0/rfkill0'
Feb 19 14:44:34 alarm systemd[1]: sys-subsystem-bluetooth-devices-hci0.device: Changed dead -> plugged
Feb 19 14:44:34 alarm systemd[1]: sys-devices-platform-700b0200.sdhci-mmc_host-mmc1-mmc1:0001-mmc1:0001:3-bluetooth-hci0.device: Changed dead -> plugged
Feb 19 14:44:34 alarm systemd[1]: bluetooth.target: Trying to enqueue job bluetooth.target/start/fail
Feb 19 14:44:34 alarm systemd[1]: bluetooth.target: Installed new job bluetooth.target/start as 106
Feb 19 14:44:34 alarm systemd[1]: bluetooth.service: Installed new job bluetooth.service/start as 107
Feb 19 14:44:34 alarm systemd[1]: bluetooth.target: Enqueued job bluetooth.target/start as 106
Feb 19 14:44:35 alarm systemd-rfkill[250]: A new rfkill device has been added with index 0 and type bluetooth.
Feb 19 14:44:35 alarm systemd-rfkill[250]: Loaded state '0' from /var/lib/systemd/rfkill/platform-700b0200.sdhci:bluetooth.
Feb 19 14:44:37 alarm systemd[1]: bluetooth.service: ConditionPathIsDirectory=/sys/class/bluetooth succeeded.
Feb 19 14:44:37 alarm systemd[1]: bluetooth.service: Passing 0 fds to service
Feb 19 14:44:37 alarm systemd[1]: bluetooth.service: About to execute: /usr/lib/bluetooth/bluetoothd
Feb 19 14:44:37 alarm systemd[1]: bluetooth.service: Forked /usr/lib/bluetooth/bluetoothd as 260
Feb 19 14:44:37 alarm systemd[1]: bluetooth.service: Changed dead -> start
Feb 19 14:44:37 alarm systemd[260]: bluetooth.service: Executing: /usr/lib/bluetooth/bluetoothd
Feb 19 14:44:37 alarm bluetoothd[260]: Bluetooth daemon 5.48
Feb 19 14:44:37 alarm bluetoothd[260]: Starting SDP server
Feb 19 14:44:37 alarm bluetoothd[260]: kernel lacks bnep-protocol support
Feb 19 14:44:37 alarm bluetoothd[260]: System does not support network plugin
Feb 19 14:44:37 alarm bluetoothd[260]: Bluetooth management interface 1.14 initialized
Feb 19 14:44:37 alarm dbus-daemon[263]: [system] Activating via systemd: service name='org.freedesktop.hostname1' unit='dbus-org.freedesktop.hostname1.service' requested by ':1.4' (uid=0 pid=260 comm="/usr/lib/bluetooth/bluetoothd ")
Feb 19 14:44:37 alarm systemd[1]: bluetooth.service: Got notification message from PID 260 (STATUS=Starting up)
Feb 19 14:44:37 alarm systemd[1]: bluetooth.service: Got notification message from PID 260 (STATUS=Running)
Feb 19 14:44:37 alarm systemd[1]: bluetooth.service: Got notification message from PID 260 (READY=1)
Feb 19 14:44:37 alarm systemd[1]: bluetooth.service: D-Bus name org.bluez now registered by :1.4
Feb 19 14:44:37 alarm systemd[1]: bluetooth.service: Changed start -> running
Feb 19 14:44:37 alarm systemd[1]: bluetooth.service: Job bluetooth.service/start finished, result=done
Feb 19 14:44:37 alarm systemd[1]: Sent message type=signal sender=n/a destination=n/a path=/org/freedesktop/systemd1/unit/bluetooth_2eservice interface=org.freedesktop.DBus.Properties member=PropertiesChanged cookie=13 reply_cookie=0 signature=sa{sv}as error-name=n/a error-message=n/a
Feb 19 14:44:37 alarm systemd[1]: Sent message type=signal sender=n/a destination=n/a path=/org/freedesktop/systemd1/unit/bluetooth_2eservice interface=org.freedesktop.DBus.Properties member=PropertiesChanged cookie=14 reply_cookie=0 signature=sa{sv}as error-name=n/a error-message=n/a
Feb 19 14:44:37 alarm systemd-logind[256]: Got message type=signal sender=:1.3 destination=n/a path=/org/freedesktop/systemd1/unit/bluetooth_2eservice interface=org.freedesktop.DBus.Properties member=PropertiesChanged cookie=13 reply_cookie=0 signature=sa{sv}as error-name=n/a error-message=n/a
Feb 19 14:44:37 alarm systemd-logind[256]: Got message type=signal sender=:1.3 destination=n/a path=/org/freedesktop/systemd1/unit/bluetooth_2eservice interface=org.freedesktop.DBus.Properties member=PropertiesChanged cookie=14 reply_cookie=0 signature=sa{sv}as error-name=n/a error-message=n/a
Feb 19 14:44:37 alarm systemd[1]: bluetooth.target changed dead -> active
Feb 19 14:44:37 alarm systemd[1]: bluetooth.target: Job bluetooth.target/start finished, result=done
Feb 19 14:44:37 alarm systemd[1]: Sent message type=signal sender=n/a destination=n/a path=/org/freedesktop/systemd1/unit/bluetooth_2etarget interface=org.freedesktop.DBus.Properties member=PropertiesChanged cookie=23 reply_cookie=0 signature=sa{sv}as error-name=n/a error-message=n/a
Feb 19 14:44:37 alarm systemd-logind[256]: Got message type=signal sender=:1.3 destination=n/a path=/org/freedesktop/systemd1/unit/bluetooth_2etarget interface=org.freedesktop.DBus.Properties member=PropertiesChanged cookie=23 reply_cookie=0 signature=sa{sv}as error-name=n/a error-message=n/a
Feb 19 14:44:38 alarm NetworkManager[281]: <info>  [1519051478.1463] Loaded device plugin: NMBluezManager (/usr/lib/NetworkManager/libnm-device-plugin-bluetooth.so)
Feb 19 14:44:40 alarm systemd[343]: sys-subsystem-bluetooth-devices-hci0.device: Changed dead -> plugged
Feb 19 14:44:40 alarm systemd[343]: sys-devices-platform-700b0200.sdhci-mmc_host-mmc1-mmc1:0001-mmc1:0001:3-bluetooth-hci0.device: Changed dead -> plugged
Feb 19 14:45:07 alarm systemd[404]: sys-subsystem-bluetooth-devices-hci0.device: Changed dead -> plugged
Feb 19 14:45:07 alarm systemd[404]: sys-devices-platform-700b0200.sdhci-mmc_host-mmc1-mmc1:0001-mmc1:0001:3-bluetooth-hci0.device: Changed dead -> plugged
Feb 19 14:45:15 alarm systemd[404]: obex.service: About to execute: /usr/lib/bluetooth/obexd
Feb 19 14:45:15 alarm systemd[404]: obex.service: Forked /usr/lib/bluetooth/obexd as 500
Feb 19 14:45:15 alarm systemd[500]: obex.service: Executing: /usr/lib/bluetooth/obexd

To work the bluetooth you need to connect the firmware( bcm4350c0.hcd) to it.

Thanks. I'll try to implement it :+1:

The Wi-Fi chip does work. The patches were upstreamed and are now available in the latest kernel release images (linux-smaug).

I'll open another issue for the Bluetooth problem

The bluetooth issue is now open at #10


[Bug]: Minor - Unpushed Commits in Status Bar

Describe the bug
It shows committed pushes pending in the status bar if you hover.
Corrects itself on Obsidian restart.
Relevant errors (if available) from notifications or console (CTRL+SHIFT+I)
No response
Steps to reproduce
Open Obsidian.
Make an edit.
Let it Commit. (timed) - Git committed 1 file | Last Commit XXXX
Let it Push. (timed) - Git pushed 1 file | Last Push XXXX (1 unpushed commits)
Status bar shows 0 as it updates.
Hover over the 0.
Shows X unpushed commits on the tooltip.
Expected Behavior
No response
Addition context
No response
Operating system
macOS
Installation Method
Other
Plugin version
2.20.6

I don't quite get what the issue is. You mean that after you pushed, it says you have unpushed commits? Which is of course wrong then.

Yep, exactly that.


feat/ Loading Screen

resolves #9
Let me know if anything needs to be changed.

Does this show the keys like the current loading screen, I think that would be nice. Basically just giving it a background image and some styles?

Does this show the keys like the current loading screen, I think that would be nice. Basically just giving it a background image and some styles?
I would build on the current one that has all the poimandres info. Maybe even just use progress + image

No, this is currently a separate loading page that will display between the keys and the scene.
Looks like this

maybe we should do something more stylized. we have a blender file that could be rendered out in a really fancy way. we can play around with some variants before committing.

ive added useprogress to the black loading screen. we could leave this open and collect ideas for some replacement.


Investigate AppSignal's free tier for APM

Supposedly free for open source, but you have to contact them: https://www.appsignal.com/open-source
(Error tracking and would also give us insight into queue times)
https://docs.appsignal.com/ruby/instrumentation/request-queue-time.html

using solid_errors instead.


Draft of refactoring tutorial + wistia embed component

Description & motivation

Adding a tutorial for refactoring a long SQL query into dbt SQL, based on Christine's Rapid Onboarding lesson (doc) about migrating an existing query to dbt.
This tutorial points to the upcoming on-demand course on query refactoring, which includes further examples and practice queries.
To-do before merge

Pre-release docs
Is this change related to an unreleased version of dbt?

[ ] Yes: please

update the base branch to next
add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
add links to the "New and changed documentation" section of the latest Migration Guide

[x] No: please ensure the base branch is current
[ ] Unsure: we'll let you know!

Checklist
If you added new pages (delete if not applicable):

[x] The page has been added to website/sidebars.js
[x] The new page has a unique filename

So this is super super close and have pretty much everything setup correct. Turns out each component has to be initialized in a file at website/src/theme/MDXComponents/index.js

Thanks for the heads up @JKarlavige, added those in and working well now


Making requests to the REST API

Ok, so this is not so much an issue as a request for help.
I've set up the Papermerge containers using the YAML file with docker-compose provided in the documentation, and the application itself works flawlessly—great job on that!
However, I’m having trouble testing the API endpoints using Postman. Here’s what I’ve done so far:
I generated a token for the pre-defined user "john" with the password "hohoho". The token was generated successfully.
I’m running Papermerge on localhost:12000.
When I make requests to /users (and similar endpoints) from Postman, I include the token as a Bearer token in the Authorization header.
The container logs show status 200 when I send requests, but in Postman, the response is an HTML page prompting for JavaScript to be enabled. This HTML response occurs for other endpoints as well, even if the container logs show status codes like 200 or 403.
I’m trying to confirm the API functionality and test the endpoints in Postman before integrating them into another application. I suspect it may be related to headers or token scopes, but I’m not certain what might be causing the HTML responses instead of JSON.
Any insights on how to successfully get JSON responses or what might be causing this behavior would be greatly appreciated!
Thank you in advance!

What papermerge version do you use ?
How does your http request look like ?
Did you include "Content-Type" header ? i.e. "Content-Type: application/json" ?

Closing the ticket because of inactivity.


[Wishlist] Seamless conversion of arrays into multiple columns

Original author<EMAIL_ADDRESS>(May 14, 2010 14:53:52)
Unless I'm very much mistaken, there's no direct way to turn an array value into multiple columns.
Using join() requires finding a suitable separator character to split on later which requires knowledge
of the full content of the column.
Perhaps returning an array from a transform should create new columns representing the array
values? I'm not fussy about the specifics, but at the moment arrays seem to be 2nd class data types.
Original issue: http://code.google.com/p/google-refine/issues/detail?id=36

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@jackyq2015 @wetneb @ostephens @ettorerizza Read through this issue... I think David Huynh has a good point, and this would be a very useful new GREL function.
Imagine a value...
Yang,David,John ,Charlie
and doing GREL
value.split(',')
produces
[ "Yang", "David", "John", "Charlie" ]
and by adding a new command
value.split(',').toColumns()
the preview window will instead show
Creating Columns:  [ "Yang", "David", "John", "Charlie" ]
and then clicking OK on Transform window it executes the existing core/column-split command for those rows that have valid Arrays (non-error rows).
Additionally, the new toColumns() can also take parameters just like it does on the Edit columns -> Split into several columns
Thoughts ?

This could be very neatly solved by a new "by expression" option to the "Split into several columns..." dialogue.

@simonwiles Not any expression, right?  Can you give an example of how you are thinking this might work?

Sorry if I was unclear.  I simply meant an expression which returns multiple values -- an array (GREL) or list (Jython).

Would it be better to show the option where the user puts in their expression... and we tell the user if the provided expression produces an array or list that we can split on into columns?  "You need to supply an expression which will produce an array or list for this option to work correctly"
Something like that is what you are thinking?  What or how would it work in your perfect world, colors and all :)

That's a good idea @simonwiles, and yes Thad we would need to find a way to make this understandable easily for the user.

value.split(',').toColumns()
the preview window will instead show
Creating Columns: [ "Yang", "David", "John", "Charlie" ]

@thadguidry: I think we CANNOT go into the direction of a function toColumns(), because they can be called a few times in a single expression. We can't control that (i.e. and([ "Yang", "David"].toColums, [ "Antonin", "Antoine"].toColums) could be written).
BUT, what I would REALLY consider, is, adding to ALL places with a « expression preview », the ability to choose WHERE the result is going to be stored. Right now, we can store in 2 places : the value of the cell, or the cell object in itself. I think we should change that, and make it explicit, and add other columns also (i.e., you transform from the « Name » column, so the first element of an array could be stored there, and that element could be an array, but if you choose also to affect column « Given name » and column « Surname », then item 2 of the resulting array would go in « Given name » and item 3 of the resulting array could go in « Surname ».
I think the user should have more control over where the result is going to go, and adding extra columns as a destination would be great.
Regards, Antoine


drop example extra-requirements

It's exactly the same as the dataflow one so let's keep it simple and only provide a "dataflow" one.

At this point it does seem redundant, but when/if we have more examples (that use e.g., pytorch, scipy, etc), it would be nice to be able to install all example deps with xee[examples] (if I understand correctly). Why not leave this here as a structure to add to?

I see you point, maybe let's leave this one on stale for now and see what can be done elswhere (I don't fully understand the different level of dependencies yet)

Sounds good. Will leave open for now as a reminder to keep dep organization in mind.


Update of Home Delivery element

give @kavya020805  5 points

@sagnik3788 This points did not got updated in the leaderboard.

give @kavya020805  5 points


Add default type formatters for Enum

@singingwolfboy is there a way to make this work in python 2 also?

@pawl: sure, just install the enum backport package! https://pypi.python.org/pypi/enum34

I've responded to review comments -- thanks, @pawl! Can you give it another look?

Actually, doing a little bit more testing, I discovered another interesting, unexpected thing about Python enums:
% python3
Python 3.5.1 (default, Dec  7 2015, 21:59:10)
[GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-700.1.76)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import enum
>>> class Test(enum.Enum):
...   a = 1
...
>>> type(Test)
<class 'enum.EnumMeta'>
>>> isinstance(Test, enum.Enum)
False
>>> type(enum.Enum)
<class 'enum.EnumMeta'>

Based on this, should I be setting BASE_FORMATTERS[type(Enum)] instead of BASE_FORMATTERS[Enum]?

Seems to work fine as-is.
Before:

After:

It's also worth noting that only SQLAlchemy >=1.1 returns python Enum types so far: http://docs.sqlalchemy.org/en/latest/core/type_basics.html#sqlalchemy.types.Enum


Admin media has moved

Since Django r16487, the admin media has moved directory, breaking admin media serving in runserver_plus. You can trivially fix this with:
https://gist.github.com/1063216
.. but this won't work for people using <= r16487.

Please check commit:
https://github.com/django-extensions/django-extensions/commit/90ad79bb9239e574f701e6edc1057256a4caa67b
re-open ticket if this does not work.


Default route must be visible in the url

The router does not write the "Welcome" into the URL.
The angularjs router has the same "design flaw".
Can this be fixed?
My expectation is to get a correct URL for default routes. Also for the initial root route.

I'm not sure what you mean.
Do you want the router's nav links to use 'welcome' instead of ''? It uses the first pattern in the route array, so you can specify route: [ 'welcome', '' ] to accomplish that.
Do you want the default route '' to redirect to 'welcome'? You can do that by adding a redirect route instead of making '' an alias for 'welcome': { route: '', redirect: 'welcome' }. It does look like we might have a problem with redirects in child routers. I will create a separate case for that bug & try to look into it soon.

I believe the redirect setup is the correct way to resolve this. However I'm having issues with redirects in child routers as @bryanrsmith mentions, good to hear that's already been picked up on though.

@bryanrsmith  I can confirm what @BlueHayes said:
The redirect does not work in child router see here:
http://plnkr.co/edit/XOBJn3?p=preview
check the browser for error in console
TypeError: Illegal module name ""
at x.$__Object$defineProperty.value (https://jspm.io/es6-module-loader@0.16.5.js:1:29223)
at x.$__global.upgradeSystemLoader.e.normalize (https://jspm.io/system@0.16.7.js:5:16986)
at x.$__global.upgradeSystemLoader.e.normalize (https://jspm.io/system@0.16.7.js:5:17338)
at x.$__global.upgradeSystemLoader.e.normalize (https://jspm.io/system@0.16.7.js:5:21688)
at n.execute.n.loadModule (https://cdn.rawgit.com/distros/aurelia/0.13.0/aurelia.js:5:1115)
at execute.e.importViewModelResource (https://cdn.rawgit.com/distros/aurelia/0.13.0/aurelia.js:9:2763)
at execute.e.createViewModel (https://cdn.rawgit.com/distros/aurelia/0.13.0/aurelia.js:8:2850)
at r.execute.c.loadRoute (https://cdn.rawgit.com/distros/aurelia/0.13.0/aurelia.js:11:782)
at i (https://cdn.rawgit.com/distros/aurelia/0.13.0/aurelia.js:9:31513)
at r (https://cdn.rawgit.com/distros/aurelia/0.13.0/aurelia.js:9:30990)(anonymous function) @ aurelia.js:10r @ aurelia.js:4(anonymous function) @ aurelia.js:4t.exports @ aurelia.js:1j.(anonymous function) @ aurelia.js:4n @ aurelia.js:4r @ aurelia.js:4

and I correct my harsh comment. The root redirect works, but I couldnt make it work in angular :P


Disable hints according to user preference

Disable hints on the basis of exported hint preferences settings
NOTE: merge after NB is upgraded to NB-21
For more info: #9

Merged alongwith NB-21 PR, so can be closed


Release Google.Cloud.SecurityCenterManagement.V1 version 1.0.0-beta01

Changes in this release:
Initial release.

Created release for Google.Cloud.SecurityCenterManagement.V1-1.0.0-beta01


[BUG] Some spells work, others don't when put into a magic item

Module Version: v1.7.2
Describe the bug
I put a bunch of spells on a magic item. Most of them work, but some don't, they don't even appear in chat. and I get a console error.
To Reproduce
Steps to reproduce the behavior:
Not sure if it can be easily reproduced. I can't find out why some spells work and some doesn't. If it helps for me the not working spells are Bigby's hands and Telekinesys
Expected behavior
All spells should work
Screenshots

Browser:
Chrome
Foundry Version:
v11.315
Game System:
D&D5e v3.0.4

Have you done the 1.7.0 command execution?
Could you please try and use the spell with monks-combat-details ?

Tried with Monks Combat Details disabled and ran the macro... still not working

I hadn't come upon the issue with the new release: https://github.com/PwQt/magic-items-2/pull/92


fix the git tagging and don't print version message twice

closes https://github.com/tellor-io/telliot/issues/445

Pull Request Test Coverage Report for Build 927633495

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 4.933%

Totals

Change from base Build 926422201:
0.0%

Covered Lines:
95

Relevant Lines:
1926

💛  - Coveralls


v2.8.1 Preview

Move to Network.framework for reachability
Expose shouldUseExtendedBackgroundIdleMode
Improve perf with NSData subranges
Improve perf with copying lowercase string headers
Fix up things for MACCATALYST support

Also:

Disable connectivityOptions support on iOS 13+

a.k.a. waitForConnectivity on NSURLSessionConfiguration

This regressed on iOS 13 betas and breaks the feature
This patch is provided as a preview update of TNL for
working around this iOS 13 bug.

If this bug is fixed before the GM of iOS 13, we will do a
different update without disabling this feature.
If this bug is not fixed before the GM of iOS 13, we will
merge this update to TNL, disabling the feature for iOS 13.
If this bug is not fixed before iOS 13.1, we will deprecate
support for waitForConnectivity altogether

#12 has the canonical change, closing


Collections-699 PairingIterator

Hello again,
like in https://github.com/apache/commons-collections/pull/73 here is the second try to implement COLLECTIONS-699
Now i use a standalone lightweight dto inside the PairingIterator to return the result.
Is the implementation ok?

Coverage decreased (-0.0009%) to 87.858% when pulling 5b342e43722b3f686485f3242de90a5c8900f5ad on Fival85:COLLECTIONS-699 into 252170f2de460f6d40b62cd4d024458d200865bd on apache:master.

Thank you. I will check it, when i have time for it. at the moment im on vacation :)


What is the difference between EPUAP and Wezel krajowy?

What is the difference between EPUAP/Profil zaufany SSO and Wezel krajowy?
Is it the same?

Two completely separate and independent Web SSO providers.
Historically, EPUAP is the first. It allows you to login with the username/password or delegate the authentication to one of supported banking systems.
Then, Węzeł Krajowy has been developed and it doesn't offer its own user accounts. Instead, it delegates authentication to one of providers and the list of the providers is supposed to be modified in future. At the moment you can authenticate using EPUAP and the Digital Personal ID card (e-dowód).
At technical level both are implemented as SAML2 Identity Providers, however:

EPUAP uses RSA-based certificates, WK forces ECDA-based certificates
the SAML2 token returned from EPUAP's ArtifactResolve call contains an atrofic token that must be then used in the getTpUserInfo call to obtain name, surname and personal ID; the SAML2 token returned from WK's Artifact Resolve call contains the name, surname and personal ID claims, however the token is encrypted
systems that are registered to use EPUAP don't automatically support WK and the other way around - a separate registration procedure is required
all systems that are used in a public sector are obliged to support WK starting from 2020. EPUAP authentication will no longer be supported for new systems starting from 2021
EPUAP supports authentication, signing and digital exchanges. WK supports authentication only
WK is supposed to be integrated with european identity providers in future (so that you could possibly be a foreigner and still use a website integrated with WK)

Hope this helps.

Please drop a note if this can be closed.

Thank you so much, for the good explanation. It dispelled my doubts. 👍


Display proper error message when no logs to send to bluemix

Coverage decreased (-0.2%) to 82.568% when pulling 87c7949b9471e86cb97536adb7ec03b727738198 on mohlogan-errormsg into 9416ad5dc29f3e73f613e24319125642109ddd94 on development.


Update 2020-11-20-meetup.md

Updated evidence abstract

@c-martinez I couldn't assign you, so an mention will have to do.

Thanks @meiertgrootes -- I've merged it now and will merge into master, so it will go live soon.


What's the reference name of the emotion?

There's no "question" section, so i decided to write this question here.
In your mod i found "Error" emotion that looks like old youtube video where anime/real girl jumps in the air.
If anyone knows what the name of the video (or song that used in this video), please, tell me.

Sorry for the super late reply, but this emote has been renamed to "Get down", which I believe is the name of the song that the character dances to in beatsaber. Hopefully this helps!

Yes, it's this song. Thanks a lot!


Restructure monorepo to be simpler

The way the monorepo works now is rather complex. Part of this is the multistage splitting process, and the way releases work. I tried keeping a changelog manually but find it hard to make the propagated releases relevant. I like the feature GitHub has to automatically generate release notes from pull requests, so I'm going to try out requiring pull requests for development instead of pushing directly to the master branch. This would then allow us to go back to handling patch releases in the readonly repositories. Since during the beta stage minor releases function partly as major ones, those should always be synced. Meaning that if Hyde get's a minor release, so must Framework, and vice versa.

[x] Require pull requests to contribute to the develop repo
[ ] Remove intermediate jobs in the monorepo splitter to push directly to the readonly repos
[ ] Remove the mirror branches
[ ] Remove or decouple the keep a change changelog parser

Okay so small internal changes, like updating workflows, styles, and things like that should not be in changelog and could be pushed to master, and since I'm the only one who normally can push to master I'll just make a note to not push changes directly.

Remove or decouple the keep a change changelog parser

Not sure what do to about that so closing this issue for now and I'll handle the changelog later


Update default.html

I'm so sorry that what I pulled before is just a mis-operation. Forgive a newbie please...


Solve conditional blocks in Cabal files

Fixes #35

@philderbeast I've merged the PR to main. There's a bug report I'd like to investigate before releasing another version of doctest-parallel. I hope to get to that soon :).

Cool. I'm not blocked as I'm working with doctest-parallel as a submodule in the interim.


fix(notification): the SSRFChecker wouldn't check when url whitelist is empty

What type of PR is this?
type-bug

What this PR does / why we need it:
In ChannelConfigValidator, we use SSRFChecker to validate the url.
But if the whitelist is empty, the checker will always thinks that this URL is legal.
So I fixed this, when the whitelist is empty , always return false.

if the whitelist is empty, the checker will always thinks that this URL is legal

seems make sense

if the whitelist is empty, the checker will always thinks that this URL is legal

seems make sense

Removed this.


[dotnetstatus github gratipay hexpm wordpress] General test improvements

This is a follow up pull request, related to some discussions in #1175.
It covers the following aspects:

extended the usage of the isMetric and isMetricOverTimePeriod validators where possible.
removed calls to Joi.equal for bare string literals. The service-test documentation was also updated accordingly.
fixed some Wordpress tests. A couple of tests for plugins were actually using a theme project instead. The mistake became apparent when switching from a catch all Joi.string to a more specific metric validator.

Cheers,
Pyves

Github service tests passing locally with patch from #1118, except for this one which timed out:
  1) Github Commits since by latest release
	[ GET http://localhost:1111/github/commits-since/microsoft/typescript/latest.json ]:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

Indeed, it seems to time out for me as well, even when run all alone. I haven't modified it though, so I'm wondering whether something has changed on the tested repository.

Probably there are more commits since the last release, and the request is taking longer to run. MarkHerhold/IcedFrisby#71 should help with this. It'll make it easy to set longer timeouts for the slower tests.


Mac: Create way to add Oni to $PATH

I'm not sure what the best practice on Mac is, but similar to #344 on Windows, there should be an option to add Oni to the $PATH variable so that it is accessible from the terminal.
VSCode has an interesting way of handling this:
https://code.visualstudio.com/docs/setup/mac

By exposing a command in the command palette to install/uninstall the command.

After npm install, nom run build, and nom link, I discovered by accident that I could run Oni from anywhere in terminal, and even on Spotlight. Is this not the case for other installation methods?

It is the npm link command which is adding oni to your $PATH.  The current installer is not performing an equivalent operation.

For what it's worth, all that command does in vscode is creates a symlink to /usr/local/bin/code.  And it only enables that "Shell Command" if (process.platform === 'darwin') {.  I guess we could put a similar command in our Command Palette since users don't get to answer any questions during install on a Mac.
Or, on first launch (on Mac) we could pop-up a prompt to the user asking "would you like to install 'oni' in your $PATH?" and set a flag in config.js so the question is never asked again on future launches regardless of the answer.  I'm not sure which behavior Mac people would prefer; maybe we should do both, prompt at first launch and add command to palette so they can change it later.

I was going to work on this issue since it seemed pretty straightforward, especially since we can use vscode's implementation as a starting point.  Unfortunately, after looking a bit closer, I found this:
https://github.com/Microsoft/vscode/blob/92ee0d1e067ae70706cddaa6feca9a7659aa4d90/src/vs/workbench/parts/cli/electron-browser/cli.contribution.ts#L101
vscode is running osascript to prompt the user for administrator privileges to write to /usr/local/bin.  I thought I could just create a symlink, I didn't think about the fact that it would be to a restricted directory.  So I guess someone who actually owns a Mac would need to implement this to make sure they get that osascript right.
If anyone cares, this is what I was going to add after the commands[] declaration (line 67) in Commands.ts:
    if (Platform.isMac()) {
        if (fs.existsSync("/usr/local/bin/oni")) {
            commands.push(new CallbackCommand("oni.config.removeFromPath", "Remove from $PATH", "Disable executing 'oni' from terminal or Spotlight", () => {
                fs.unlink("/usr/local/bin/oni")
            }))
        } else {
            commands.push( new CallbackCommand("oni.config.addToPath", "Add to $PATH", "Enable executing 'oni' from terminal or Spotlight", () => {
                # TODO: prompt for admin privileges (osascript?)
                fs.symlink("/Applications/Oni.app/Contents/MacOS/Oni", "/usr/local/bin/oni")
            }))
        }
    }

Also, there's probably a more clever way to determine the name of the currently running executable rather than hardcoding /Applications/Oni.app.  I hope this might help someone else take the feature to completion; I can't take it any further since I don't own a Mac.

You can have a separate dedicated npm package whose only job is to create two global binaries oni and oni-dev which will open the installed /Applications/Oni.
I would heavily discourage those binaries being written in JS as that adds a considerable amount of startup time (100+ms). I would use a small shell script that uses some node features to work on either windows (cmd) or bash(*nix).

@keforbes , I'm really impressed with how you take on these issues from a Linux machine (both this and the Windows installer issue!). Good find, it does seem like we'd need to leverage osascript to bump the privileges. I like the symlink strategy a lot. Thanks for looking into this, it doesn't seem like we're too far away from a solution.
@jordwalke  - The separate package approach is interesting, thanks for the suggestion! I'd like to invest more heavily in this in general. There are lots of parts of Oni that could be split and modularized (sort of like how Atom is structured). Reasoning about the architecture this way is excellent for extensibility and helps in reducing couple / increasing cohesion. I've also been thinking about something similiar for the javascript-plugin extensibility story - being able to reuse NPM for that makes a lot of sense.
There are some things we'll have to think about in terms of leveraging NPM completely (at least on OSX I think you need to use sudo npm install -g .... which is super annoying... I didn't know there was a better way until you posted this on twitter: https://github.com/sindresorhus/guides/blob/master/npm-global-without-sudo.md 👍 ). So we might still need to go the osascript route to run the NPM command as admin, and do some checks to make sure this is there. And it's not a given that npm would be available, so we'd need to handle that case as well.
Another possibility would be to generalize this even further - like an npm package add-to-path that would have an API like:
import { addToPath, removeFromPath } from "add-to-path"
..
const pathToAdd = "/Applications/Oni.app/Contents/MacOS/Oni"
addToPath("oni", pathToAdd)
..

It'd be a helpful abstraction to hide the platform differences (ie, on Windows, maybe it runs some powershell script as admin, and on OSX, it uses osascript to create the symlinks), and would be useful even outside of Oni.
I actually just checked and it turns out there is already an add-to-path, but it looks like it only updates the PATH locally, and only for Windows - bummer!

This was added by @justjoeyuk in #646 . Thanks @justjoeyuk ! Nice find on sudo-prompt, that helped... and since we are adding a direct symlink to the binary, it should be fast.


No video Grabbing?

hello,
I have installed Hyperion on RasPi and got the iOS and android apps... app work fine.
However the Amiblight video grabber is not.
lsusb
Bus 001 Device 002: ID 0424:9512 Standard Microsystems Corp.
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 003: ID 0424:ec00 Standard Microsystems Corp.
Bus 001 Device 004: ID 05e1:0408 Syntek Semiconductor Co., Ltd STK1160 Video Capture Device
Bus 001 Device 005: ID 0bda:8176 Realtek Semiconductor Corp. RTL8188CUS 802.11n WLAN Adapter
I have tried many different hyperion.config.json variations with no results.
I have done all the updates
what am I missing?  any help would be great!

Witch image are you you using?

I am having a very similar problem. Running Raspbmc on a RasPi B+. When I run ls /dev/video* I get an output of "ls: cannot access /dev/video*: No such file or directory".
Any ideas?

i think the grabber driver is not available in your image

That's what I'm thinking. Are there any grabbers compatible with RasPi B+ and raspbmc? Or should I just switch to xbian or openelec?

easycap stk1160 but not every image is compatible. you'll find images on http://lightberry.eu/#download

Right I have easycap stk1160, but what do you mean by image? Are you referring to the OS, the kernel, all combinations?
The lightberry site doesn't have an image for raspbmc + stk1160. It has one for openelec, which I don't mind installing, but seeing as I already have raspbmc setup, I'd prefer to go that route if it's possible.

OK have installed openelec using the lightberry images, but now when trying to get a screenshot I get this error: VIDIOC_S_FMT error 16, Device or resource busy
any thoughts?

Did you adjust your hyperion config setting?

Yes. I've found someone else who is having a similar problem in issue #216 . The device or resource busy error was from hyperion already running, so I do killall hyperiond and then try to take the screenshot, but it hangs and never returns anything.

I am in the same boat as you, I am running OSMC and get the same error. #482

@energysumo can be closed now? or didnt fixed the issue?

Device or resource busy
Stop the Hyperion process before you do screenshots
Closed due to age. Please open a new one, if problems still exists.
Thank you


Expose info() api

Add a function that exposes the info value. This is needed since description() is deprecated.

If I understand this correctly this always gives you the same message as ScanError::to_string(). Is it really necessary to have it then?

Not exactly the same:
"mapping values are not allowed in this context at line 4 column 4" (to_string())
"mapping values are not allowed in this context" (info())
Personally, it would help me because I use yaml-rust to parse a section of a larger file so the column/line info is wrong from the perspective of the end user. Right now, I trim the message I receive from to_string but that's not very elegant.

@hoodie are you a maintainer of yaml-rust? I was under the impression it was unmaintained.

I am not, just reading along, because I contributed a little in the past. I don't think it's unmaintained, but the maintainer seldomly checks the PRs.

Ok well, the last commit was a year ago... That's pretty seldom indeed.

FWIW I've merged this into my fork: https://github.com/davvid/yaml-rust


Netty hangs when header too long

Related to #2179
When a header is sent that is too big (such as 120 kb), the request hangs forever.
This is fixed in 2.0., but does not work in 1.4 (tested on latest 1.4.6-SNAPSHOT).
Also the first request with long header gets through and returns a response, the second one hangs.
Expected behaviour:

We should get a 400 response and appropriate message (header too big)
We should have a way to configure a bigger header (see #2179) for cases where this is required.

This is a customer issue where the header is required to be bigger than 8Kb.
Reproducer:
class TestLongHeaders {
    @Test
    void testTooBigHeader() throws InterruptedException, ExecutionException, TimeoutException {
        WebServer ws = WebServer.builder(Routing.builder()
                                                 .get("/", (req, res) -> res.send("Hi"))
                                                 .register("/static", StaticContentSupport.create("/static"))
                                                 .build())
                .build()
                .start()
                .toCompletableFuture()
                .get(10, TimeUnit.SECONDS);

        Client client = ClientBuilder.newClient();
        String target = "http://localhost:" + ws.port();

        String headerValue = header(8000);
        String result = client.target(target)
                .request()
                .header("X_SHORT", headerValue)
                .get(String.class);

        assertThat(result, is("Hi"));

        headerValue = header(10000);
        result = client.target(target)
                .request()
                .header("X_LONG", headerValue)
                .get(String.class);
        assertThat(result, is("Hi"));

        result = client.target(target)
                .request()
                .header("X_LONG", headerValue)
                .get(String.class);
        assertThat(result, is("Hi"));
    }

    private String header(int size) {
        StringBuilder sb = new StringBuilder();
        for (int i = 0; i < size; i++) {
            sb.append("a");
        }
        return sb.toString();
    }
}

Problem is now fixed in 1.x branch and new configuration options were added for server:

Configuration key
Default value
Java type
Description

max-header-size
8192
int
Maximal number of bytes of all header values combined. Returns 400 if headers are bigger

max-initial-line-length
4096
int
Maximal number of characters in the initial HTTP line. Returns 400 if line is longer

timeout-millis
no timeout
long
Server socket timeout.

receive-buffer-size
implementation default
int
Proposed value of the TCP receive window that is advertised to the remote peer on the server socket.

max-chunk-size
8192
int
Maximal size of a chunk to read from incoming requests

validate-headers
true
boolean
Whether to validate header names, if they contain illegal characters.

initial-buffer-size
128
int
Initial size of buffer used to parse HTTP line and headers


Any solution to separe gnd from D1mini

Hi.
i have powered the d1mini from thebateri with a DC DC converter. 24v to 5v.but there is a problem.
ground from rs485 connector provide power to the esp even if i turnoff discharge from bms.
Is possible to use some optocupler to separate the ground?
Or other solution to separate data gnd from power gnd.
thnks

We depend on the community's experience here. I'm a software developer and cannot provide an informed/qualified answer here.

We depend on the community's experience here. I'm a software developer and cannot provide an informed/qualified answer here.

my mistake , i post in wrong section, is not a issue. can you move it on discussion.
regards


RuntimeError: istft input and window must be on the same device but got self on cuda:0 and window on cpu

My command to run:
python3 train.py --config config_v1.json --input_wavs_dir /home/yehor/iSTFTNet-pytorch/lada_wavs --input_training_file /home/yehor/iSTFTNet-pytorch/training_list.txt --input_validation_file /home/yehor/iSTFTNet-pytorch/validation_list.txt

Error:
...        (2): Conv1d(128, 128, kernel_size=(11,), stride=(1,), padding=(5,))
      )
    )
  )
  (conv_post): Conv1d(128, 18, kernel_size=(7,), stride=(1,), padding=(3,))
  (reflection_pad): ReflectionPad1d((1, 0))
)
checkpoints directory :  cp_hifigan
Epoch: 1
/home/yehor/.local/lib/python3.8/site-packages/torch/functional.py:632: UserWarning: stft will soon require the return_complex parameter be given for real inputs, and will further require that return_complex=True in a future PyTorch release. (Triggered internally at ../aten/src/ATen/native/SpectralOps.cpp:801.)
  return _VF.stft(input, n_fft, hop_length, win_length, window,  # type: ignore[attr-defined]
/home/yehor/.local/lib/python3.8/site-packages/torch/functional.py:632: UserWarning: stft will soon require the return_complex parameter be given for real inputs, and will further require that return_complex=True in a future PyTorch release. (Triggered internally at ../aten/src/ATen/native/SpectralOps.cpp:801.)
  return _VF.stft(input, n_fft, hop_length, win_length, window,  # type: ignore[attr-defined]
/home/yehor/.local/lib/python3.8/site-packages/torch/functional.py:632: UserWarning: stft will soon require the return_complex parameter be given for real inputs, and will further require that return_complex=True in a future PyTorch release. (Triggered internally at ../aten/src/ATen/native/SpectralOps.cpp:801.)
  return _VF.stft(input, n_fft, hop_length, win_length, window,  # type: ignore[attr-defined]
/home/yehor/.local/lib/python3.8/site-packages/torch/functional.py:632: UserWarning: stft will soon require the return_complex parameter be given for real inputs, and will further require that return_complex=True in a future PyTorch release. (Triggered internally at ../aten/src/ATen/native/SpectralOps.cpp:801.)
  return _VF.stft(input, n_fft, hop_length, win_length, window,  # type: ignore[attr-defined]
Traceback (most recent call last):
  File "train.py", line 280, in <module>
    main()
  File "train.py", line 276, in main
    train(0, a, h)
  File "train.py", line 126, in train
    y_g_hat = stft.inverse(spec, phase)
  File "/home/yehor/iSTFTNet-pytorch/stft.py", line 198, in inverse
    inverse_transform = torch.istft(
RuntimeError: istft input and window must be on the same device but got self on cuda:0 and window on cpu

It seems that @johnpaulbin fixed this issue in own fork https://github.com/johnpaulbin/iSTFTNet-pytorch

The same problem is in inference.py too

It seems that @johnpaulbin fixed this issue in own fork https://github.com/johnpaulbin/iSTFTNet-pytorch

https://github.com/johnpaulbin/iSTFTNet-pytorch/blob/2ae293919b8544989e93d3cc4a58e2f5a07e9388/stft.py#L201
add"self.device()"
But how does the blogger run the program?

In train.py add this line :  stft.window = stft.window.to(spec.device)
y_g_hat = stft.inverse(spec, phase)


Can we remove unused modules from zetta.js file ?

Just noticed below modules are unused in zetta.js file. Can we remove them ?
var uuid = require('node-uuid');
var Device = require('zetta-device');
var HttpDevice = require('zetta-http-device');
var Scout = require('zetta-scout');

Good catch @anil614sagar can you submit a PR for this?

Thank you @mdobson . Created pull request for same https://github.com/zettajs/zetta/pull/150


Add backward compat. section to Channel Database extension doc

Add a section to the channel database extension doc explaining how backward compatibility of database extensions is relevant regarding the deployment process.

@AamirAllaq @mugunthanm - could you help me review this?

Updated text (Fixed the typo), please use this:
The Channel Database is expected to be backward compatible. This means that updating only the Channel Database without updating Retail Server or POS must not prevent existing Retail Server or POS operations from functioning correctly. During deployment flows, the different components of your Retail Cloud Scale Unit, Retail Store Scale Unit and Modern POS are updated in the inverse other of dependency. This means that the Channel Database is the first component to be updated, and Retail Server or POS are updated next. In case that Retail Server or POS fails to update successfully, those components are rolled back to restore them to their previous working state. However, in such situations, the Channel Database is not rolled back to prevent data loss. If your extensions are not backward compatible, they may fail to work properly until a successful deployment is performed.


[DH-218] Move contact API to v3 and add ability to filter by company

This:

Adds/converts contact endpoints to v3
Removes the trailing slash from the endpoints v3
Changes APPEND_SLASH to False
Restructures the contact view tests
Add the ability to filter contacts by company id

Before
{
    "id": "8d4c80b1-2399-4b45-9d41-192648d3233a",
    "title": "c2d9b924-6095-e211-a939-e4115bead28a",
    "first_name": "Oratio",
    "last_name": "Nelson",
    "job_title": "Owner",
    "company": "99adbfbe-38bf-4cd9-bc43-a4955dc1df27",
    "advisor": "b0c8d226-12ed-4d75-a3cd-6ec315a08b75",
    "primary": true,
    "telephone_countrycode": "+44",
    "telephone_number": "123456789",
    "email"<EMAIL_ADDRESS>    "address_same_as_company": false,
    "address_1": "Foo st.",
    "address_2": null,
    "address_3": null,
    "address_4": null,
    "address_town": "London",
    "address_county": null,
    "address_country": "80756b9a-5d95-e211-a939-e4115bead28a",
    "address_postcode": null,
    "telephone_alternative": null,
    "email_alternative": null,
    "notes": null,
    "contactable_by_dit": false,
    "contactable_by_dit_partners": false,
    "contactable_by_email": true,
    "contactable_by_phone": false,
    "archived": false,
    "archived_on": null,
    "archived_reason": null,
    "archived_by": null,
    "created_on": "2017-05-22T15:06:18.555495",
    "modified_on": "2017-05-22T15:06:18.555495",
}

After:
{
    "id": "479766dc-855a-4131-be8f-e404063a8ddc",
    "title": {
        "name": "Admiral of the Fleet",
        "id": "c2d9b924-6095-e211-a939-e4115bead28a"
    },
    "first_name": "Oratio",
    "last_name": "Nelson",
    "job_title": "Owner",
    "company": {
        "name": "name6",
        "id": "d15e46f1-89d7-4edb-9f31-e758ae2f9d54"
    },
    "advisor": {
        "first_name": "Testo",
        "last_name": "Useri",
        "id": "cd7d51fc-a24a-42b8-86cc-a5712146198c"
    },
    "primary": true,
    "telephone_countrycode": "+44",
    "telephone_number": "123456789",
    "email"<EMAIL_ADDRESS>    "address_same_as_company": false,
    "address_1": "Foo st.",
    "address_2": "adr 2",
    "address_3": "adr 3",
    "address_4": "adr 4",
    "address_town": "London",
    "address_county": "London",
    "address_country": {
        "name": "United Kingdom",
        "id": "80756b9a-5d95-e211-a939-e4115bead28a"
    },
    "address_postcode": "SW1A1AA",
    "telephone_alternative": "987654321",
    "email_alternative"<EMAIL_ADDRESS>    "notes": "lorem ipsum",
    "contactable_by_dit": false,
    "contactable_by_dit_partners": false,
    "contactable_by_email": true,
    "contactable_by_phone": true,
    "archived": false,
    "archived_on": null,
    "archived_reason": null,
    "archived_by": null
}

Codecov Report

Merging #210 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #210      +/-   ##
===========================================
+ Coverage    91.61%   91.65%   +0.04%
===========================================
  Files           47       48       +1
  Lines         1669     1677       +8
  Branches       146      146
===========================================
+ Hits          1529     1537       +8
  Misses         119      119
  Partials        21       21

Impacted Files
Coverage Δ

datahub/investment/urls.py
100% <ø> (ø)
:arrow_up:

datahub/company/urls.py
100% <100%> (ø)

datahub/company/views.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dad15...56f9a13. Read the comment docs.

It's not really clear what the rules for v3 are but I'll try to list of the issues to fix here:

All the response bodies need to be only one nested level deep
All the response bodies should be consistent, meaning they should return the same fields in the same format
All nested objects in the response body should have only id and a name or similar. It should not include other fields
The request bodies should be consistent

If there's anything else I'm missing please add let me know and I'll add it to the list.
I will try and see if I can make the changes so that we can move it to v3 as it would be good to tidy things up a bit.

@reupen @canni finished writing Contact v3 endpoints, please have a look


Use XML entities in attributes

This makes the XML well formed

These were rendering properly in github's markdown, is this an issue with our own document md->html conversion?

The previous version was passing online xml validation tools.
I worry that if we change the docs to be 'proper', developers will use this syntax verbatim and our own code in cordova-lib will not handle it properly. Do you know if we handle this > and > equally?

It's really an issue with some XML parsers that conform to the spec on "well-formed" XML. In particular, .NET XML parsers used by Visual Studio fail if you do not use entities within attributes.
Our own node code uses element tree which works well with entities in attributes.


README describes tutorial but source is TodoMVC

This is really confusing. @DanielRosenwasser

This is @bowdenk7's fault for picking up the wrong repo: https://github.com/DanielRosenwasser/typescript-vue-tutorial

Oh no! Really sorry about the confusion. I'll get this fixed ASAP

Should be fixed now. Thanks @octref!