Optional fields always generated as None when used with hypothesis

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
All optional fields are set to None when generating instances with hypothesis.
The strategy for optional fields should be the same as for mandatory, in addition with adding (prepending?) None as a possible value to the stream.
Example Code
from typing import Optional, Union, Literal

from hypothesis import given, strategies as st

from pydantic import BaseModel
from pydantic import PositiveInt

class MySchema(BaseModel):
    val: PositiveInt
    val2: Literal[1, 2]
    val3: Union[Literal["a"], Literal["b"]]
    val4: Union[None, Literal["value"]]
    val5: Optional[PositiveInt]

@given(st.builds(MySchema))
def test_schema(instance):
    print(instance.json(indent=2))

test_schema()  # notice that val4/val5 (both semantically "optional") are always None/null

Python, Pydantic & OS Version
            pydantic version: 1.10.2
            pydantic compiled: True
                 install path: /local/home/a.pirogov/.cache/pypoetry/virtualenvs/metador-core-AXME58BY-py3.8/lib/python3.8/site-packages/pydantic
               python version: 3.8.15 (default, Dec  7 2022, 10:08:58)  [GCC 9.4.0]
                     platform: Linux-5.15.0-46-generic-x86_64-with-glibc2.29
     optional deps. installed: ['typing-extensions']

Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[X] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

I accidentally created a dupe of this in https://github.com/pydantic/pydantic/issues/4946 but that issue (now closed) does have a nice minimally failing example.

We’re no longer actively developing Pydantic V1 (although it will continue to receive security fixes for the next year or so), so we’re closing issues solely related to V1. If you really think this shouldn’t be closed, please comment or create a new issue 🚀.


Adding Microsoft.Azure.WebJobs.Extensions.WebPubSub dependency to my Azure Function project caused JSON serialization to become camelCased

My Azure Function project uses the default NewtonSoft JSON serialization which follows the casing of the properties. In C# the convention is to use PascalCased properties. After adding the Microsoft.Azure.WebJobs.Extensions.WebPubSub NuGet package my Azure Function started serializing everything using camelCase.

It's a known issue that the CamelCasePropertyNamesContractResolver is now added to the JsonConvert.DefaultSettings. For a workaround, you can modify the default settings in your function project. And we'll fix this in next release.

Issue has been fixed with PR https://github.com/Azure/azure-sdk-for-net/pull/33130. Please update to latest SDK.


Added Visual Studio icon assets for plain and plain-wordmark

@ODCSilva thanks for the pull request, I added the icons to the font files and merged in the changes, because I squashed the merge commits this hasn't registered as merged here but you can see your changes in this commit - 54543b9259


How to play link to navbar

add link on navbar to the instructions page closes #369
move footer to the bottom

From issue #369 , how to play should also be taken off the home page and off while playing page

same comment as Tracey

Solved the comments


Create MCQA for advanced array search methods: Array.find(), Array.findIndex(), Array.filter()

Please create an MCQA to be added as question number 25.
The multiple choice question should be on the topic advanced array search methods: .find(), .findIndex() and .filter() method of an array. The difficulty level should be "Medium/Hard"
Tasks:

[ ] add your code to 025 folder under code
[ ] add your question to 25 in README.md file
[ ] create a video explanation (optional)

I have added some explanation for these methods below in case you don't remebmer

find(): returns item which matches the callback condition. It only returns first match
filter(): returns array of items that matches the condition

Sample Questions for inspiration

What is the difference between find() and filter() method ?

find returns item while filter returns array of all items

If there is no value to return, what will findIndex() return ?

undefined

How will you search multiple values in an array?

filter

These questions are easy, feel free to make it bit more challenging. Except the second one. Because most developers reply -1 as the answer to it

Hi, could you please assign me to this issue?

Hi, could you please assign me to this issue?

Awesome! Thanks for showing your interest @jwernethUMD. I have now assigned the task to you.
If you need any help, you can comment here or reach me on discord at:
https://discord.gg/62VR3MMCVm

Thanks for your contribution @jwernethUMD!
Much appreciated :)


[Internal] Client Telemetry: Adds condition to make sure metrics is always there

Description
Client Telemetry Service do not accept partial metric information except SystemPool_IsThreadStarving_True metrics because service knows this particular metrics doesn't have percentile calculated.
As part of this PR, making sure metrics is added in payload only if there is metrics information available. It means if corresponding histogram has any value then only do any calculations otherwise just skip that metrics.

Closing this as this is stale


Index.html page links are not correct.

The links in the index.html file are not linking to the correct file path.

Issue resolved with merge commit.


MEC011 Data Structure Refactoring

CHANGES:

Sandbox Controller Applications API:

Removed unused API parameters (e.g. version, state)
Added Persist parameter to indicate if application should be flushed on scenario termination
Regenerated code

New meep-applications package:

Used by Sandbox Controller to create/update/delete application instances
Used by MEC011 & MEC021 to obtain list of application instances

ETSI MEC Services:

Fixed app termination code

App Enablement:

Modifications to follow new data structure
Integration with meep-applications package
Integration with meep-subscriptions package
Code cleanup

Sandbox Controller:

Integration with meep-applications package

TESTING:

UT & system tests pass

OK, can merge


Do not show a load completion message if all steps failed

Description

The load completion reporting slack message will currently fire off in any case where the pull_data_task errored out. The intention behind this was to report partial loads, e.g. the provider script wrote 500 records to disk which were loaded but errored out after that. We've recently encountered a case where the pull_data_task immediately fails before writing any records to disk. In this case, both duration and <media type> count were None.
When the reporting step is reached, we should check to ensure that at least one XCom value is not None. If all values are None, that means that an upstream failure occurred (so we should have already received an alert) and no rows were loaded (so we don't need the load completion message).
Screenshots

Additional context

Resolution

[ ] 🙋 I would be interested in resolving this bug.

Hi - I would love to work on this ticket! thank you.

I've assigned you @rsubra13! 😄


Large-v3 model hallucinates, large-v2 doesn't

I have two scripts, where the large-v3 model hallucinates, for instance by making up things, that weren't said or by spamming a word like 50 times. When I replace large-v3 in the script with large-v2, the transcription works fine.
Script 1:
import subprocess
from faster_whisper import WhisperModel

audio_file = "/tmp/audio_recording.wav"
recording_state_file = "/tmp/recording_state"

def start_recording():
    subprocess.Popen(["arecord", "-f", "cd", audio_file])
    open(recording_state_file, 'w').close()

def stop_recording():
    subprocess.call(["pkill", "arecord"])
    if os.path.exists(recording_state_file):
        os.remove(recording_state_file)
    transcribe_audio()
    os.remove(audio_file)

def is_recording():
    return os.path.exists(recording_state_file)

def transcribe_audio():
    model = WhisperModel("large-v3", device="cpu", compute_type="int8")
    segments, info = model.transcribe(audio_file)
    transcription = " ".join([segment.text for segment in segments]).strip()
    subprocess.Popen(["xclip", "-selection", "c"], stdin=subprocess.PIPE).communicate(input=transcription.encode())
    # Notify the user that transcription is complete and copied to clipboard
    subprocess.call(["notify-send", "Transcription Complete", "The transcription has been copied to the clipboard."])

def main():
    if is_recording():
        stop_recording()
    else:
        start_recording()

if __name__ == "__main__":
    main()

Script 2:
from faster_whisper import WhisperModel

model_size = "large-v3"
model = WhisperModel(model_size, device="cpu", compute_type="int8")

def transcribe_audio(file_path):
    segments, info = model.transcribe(file_path)
    transcript = " ".join(segment.text.strip() for segment in segments)
    print(transcript)

if __name__ == "__main__":
    if len(sys.argv) > 1:
        audio_file = sys.argv[1]
        transcribe_audio(audio_file)
    else:
        print("Please provide an audio file path as an argument.")

Does anyone know of a fix? Is something wrong with my scripts or with the faster-whisper large-v3 model?

@Arche151 , could you try again with compute_type="default" (or remove this command when initializing whisper model) ?

@Arche151 , could you try again with compute_type="default" (or remove this command when initializing whisper model) ?

Thanks for the quick reply and suggestion!
I'll try that and report back.

Large-v3 model hallucinates, large-v2 doesn't

It's known that large-v3 hallucinates much more that large-v2, read there:
Whisper-v3 Hallucinations on Real World Data

Large-v3 model hallucinates, large-v2 doesn't

It's known that large-v3 hallucinates much more that large-v2, read there: Whisper-v3 Hallucinations on Real World Data

Damn, that sucks hard. In that case, there's ofc nothing that faster-whisper can change about that. Then I guess I'll stay with large-v3.
Thanks for linking the article!

Then I guess I'll stay with large-v3.

You meant "large-v2"?
On my Standalone Faster-Whisper I've added auto-offsets to whisper's pseudo-vad thresholds when "v3" is in use, you can try these parameters when using large-v3:
compression_ratio_threshold=2.2
log_prob_threshold=-0.7

Then I guess I'll stay with large-v3.

Did you meant "large-v2"?
On my Standalone Faster-Whisper I've added auto-offsets to whisper's pseudo-vad thresholds when "v3" is in use, you can try these parameters when using large-v3:
compression_ratio_threshold=2.2 log_prob_threshold=-0.7

does it yield better result than large-v2 using your parameters with large-v3?

Then I guess I'll stay with large-v3.

Did you meant "large-v2"?
On my Standalone Faster-Whisper I've added auto-offsets to whisper's pseudo-vad thresholds when "v3" is in use, you can try these parameters when using large-v3:
compression_ratio_threshold=2.2 log_prob_threshold=-0.7

does it yield better result than large-v2 using your parameters with large-v3?

I didn't try for long enough to be able to say. Just went back to large-v2 after reading the deepgram article.

does it yield better result than large-v2 using your parameters with large-v3?

You tell me, as I don't use large-v3. IMO large-v2 is better.


generate duplicates sub-directories when given an argument with slashes

Using Ubuntu Linux. nodejs 4.2.1, angular-cli 0.0.10
I want to nest a component in another directory for organization.
(This issue affects all generate commands)
ng generate component my-category/my-component

version: 1.13.8
installing component
create src/app/components/my-category/my-component/my-category/my-component.css
create src/app/components/my-category/my-component/my-category/my-component.html
create src/app/components/my-category/my-component/my-category/my-component.ts
installing component-test
create src/app/components/my-category/my-component/my-category/my-component.spec.ts

For some reason, this puts an extra my-category directory in the path; this shouldn't happen.
With more subdirectories, it's clear that the argument is doubled when generating the path.
ng generate pipe 1/2/3/4

version: 1.13.8
installing pipe
create src/app/pipes/1/2/3/4/1/2/3/4.spec.ts
create src/app/pipes/1/2/3/4/1/2/3/4.ts

This isn't happening anymore. Closing this as deprecated.


Cannot launch web tests with vm + frontend

Unable to use the vm running with the front end to launch web tests. Errors out with dart:html not found message.
Using 2.0.0-dev.23.0

I think this is a front end issue.
We had made special changes in the VM to embed the html sources in the VM and enabled it in the dart_bootstrap version. I am assuming if you have a way for the front end to find dart:html it should all work.

Not sure I understand what is dart_bootstrap. Is that the striped down vm binary?

@keertip - is the import to dart:html guarded on a conditional import? (I assume that the VM before didn't support importing dart:html either).

Its not a conditional import. Saw this a couple of days ago, but unable to reproduce it. Running the hello web test,no tests are run, but no messages either. Will investigate further and update issue.

Cannot reproduce this with the latest sources, so closing the issue. Sorry for the spam.


[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-06-01-preview

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

/azp run unifiedPipeline

Hi @jikuma, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.

WI to fix the suppression Task 24264387: Use ARM common error response instead of ACR Error Response.

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

@raych1 please review the GO breaking change
@qiaozha please review the JS breaking change

Approving the suppression and the PR based on our discussion and https://github.com/Azure/azure-rest-api-specs/pull/22777

@jikuma The PR is good to go, if can you remove the suppression and we can approve the PR without the suppression, so that this can be tracked via S360

Thanks you @zizw123, I have started the deployment with the new api version, once the ARM manifest is applied, we can merge the swagger.

@rkmanda RP deployment with this change is complete. Can we merge this PR now. Please le me know if you need more info.

@tadelesh We are planning to use this directive to fix the AutoGenerated issue avoid breaking  https://github.com/Azure/azure-rest-api-specs/pull/24905/files#diff-ffa8a1b9f0b1e7035317d1a86e8aef6a504ca280349c5ff8c85ce5971d2f7f43R21-R45

/azp run

/azp run

/azp run

@tadelesh We are planning to use this directive to fix the AutoGenerated issue avoid breaking https://github.com/Azure/azure-rest-api-specs/pull/24905/files#diff-ffa8a1b9f0b1e7035317d1a86e8aef6a504ca280349c5ff8c85ce5971d2f7f43R21-R45

add directive to reademe.go.md: https://github.com/Azure/azure-rest-api-specs/pull/24929

Breaking changes for go sdk and javascript sdk has been handled. Please let me know if I need to any more changes to merge the PR.

Approving as previous reviewers had only concern about Suppression Approval, which is handled now.


SyncBot: Message formatting

There are a couple of places where message formatting could use improvement, at least:
Front replies don't footer off properly.

Also, from Sonya, minimise the visibility of metadata, especially to the public


Improve middleware customization compiler errors

Today, we construct our Tower Service by using ServiceBuilder, for example:
        let mut svc = ServiceBuilder::new()
            // Create a new request-scoped policy
            .retry(self.retry_policy.new_request_policy())
            .layer(ParseResponseLayer::<O, Retry>::new())
            // These layers can be considered as occuring in order. That is, first invoke the
            // customer-provided middleware, then dispatch dispatch over the wire.
            .layer(&self.middleware)
            .layer(DispatchLayer::new())
            .service(connector);

Problems arise when making changes to existing layers or creating new layers. If the trait bounds on the impl Service aren't 100% correct, the compiler error will always be that the Service call function doesn't exist on the final service since it doesn't actually impl Service, and this is difficult to diagnose and solve.
We should experiment with using manual service construction to see if we can get better compiler errors. For example, something like this:
let svc = RetryService::new(
    ParseResponseService::new(
        custom_middleware(
            DispatchService::new(connector))));

We may need to have the same trait bounds on new in this case, but perhaps we can write a macro that makes the impl Service bounds consistent with new to make this less error prone.

We should determine tower's future plans around layers before making a decision on this.

Closing this since we've decided to remove tower


Fix tests that load ontology data

In packages/jbrowse-plugin-apollo/cypress/e2e/editFeature.cy.ts, these three tests were disabled due to timeouts:

"Can add gene ontology attribute"
"Suggest only valid SO terms from dropdown"
"Can add child feature via table editor"

We need to figure out how to re-enable those.

I think the tests are picking up real issues...

"Can add gene ontology attribute"

There seem to be a problem with the Feature Attributes form. The test passes in tag v0.1.17 and the form looks like:

while in main (6fbe4a) we have no input box:

"Suggest only valid SO terms from dropdown"

In main the drop down menu only show the blinking cursor, no list of suggestions even outside cypress:

In v0.1.17:

"Can add child feature via table editor"

Same as for SO terms. The dropdown menu for "type" is not populated:


[PyTorch] flash-attn: deactivate causal mask for incremental decoding

Problem description
When inferencing models with a fork of Megatron-LM we see that incremental decoding keeps returning the same token if transfomer-engine is active and the flash attention backend is in use. This issue does not occur if NVTE_FLASH_ATTN=0 is set.
Details
Looking closer into transformer-engine, we figured that the problem is how flash attention's argument causal ist set. In Megatron-LM there causal will be deactivated after the first (fused) step in inference, see here. This is necessary because flash attention uses the following causal mask if seqlen_q = 1 and seqlen_k = 5:
1 0 0 0 0
In this PR I tried to adapt the Megatron-LM fix, but it is not perfect as it assumes to generate one token at a time. Actually the causal mask was modified in flash attention 2.1 (see here). With current releases of flash attention, the mask in the example above it is 1 1 1 1 1 which fixes the issue. Maybe this is the prefered solution. What are the blockers to bump flash attention above 2.0.4?

Hmm, I believe this issue was the reason to have the attn_mask_type in forward of DotProductAttention as well, so that one could control it in a finer way: https://github.com/NVIDIA/TransformerEngine/blob/main/transformer_engine/pytorch/attention.py#L1950. @ksivaman do you have any additional comments on this?

@ptrendx Thank your for the quick reply! I see, I was not aware that the attn_maks_type is actually passed through in the forward methods. So this is something that should be taken care of in Megatron-LM?
All in all, I still find this behaviour curious, because it depends on the selection of the backend for the dot product attention. We did not notice this bug for a long time because in most cases the fused attention implementation was chosen automatically based on our hardware we use for inference.


Remove the unicode_utils gem dependency

Given that Ruby 2.3 EOL is scheduled for 2019-03-31, I propose that we should remove the unicode_utils gem dependency since it's just used only for UnicodeUtils.downcase method. Instead, String#downcase should be able to replace it.

The String#downcase supports non-ASCII from Ruby 2.4.0
unicode_utils gem is no longer maintained, we should rely on more on Ruby core

The failure in Ruby 1.9 is caused by system error.
The failed test is expected in Ruby 2.3. It should fail in Ruby 1.9 as well even without a system error.

@torumori @rposborne shouldn't Ruby 2.3 be moved to the allowed failures section now that it's past EOL? Or even drop support for Ruby 1.9 and 2.3. I'd like to get rid of this dependency on an app, and this gem is the only blocker left. Thanks!

I support dropping 2.3.  Lets make the required adjustments to get this to pass. @torumori


UKIRT References

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

17 of 68 (25.0%)  changed or added relevant lines in 8 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 77.351%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

mirar/pipelines/winter/generator.py
3
13
23.08%

mirar/references/ukirt.py
1
17
5.88%

mirar/pipelines/winter/ingest_references.py
0
25
0.0%

Files with Coverage Reduction
New Missed Lines
%

mirar/references/ukirt.py
4
15.63%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
8019

Relevant Lines:
10367

💛  - Coveralls


[Removal]:

Hotspot Name
Daring Carob Peacock
Hotspot b58 Address
11MdZfVa1eF9SzHdPjP5gb7KASkiy6X93S1JsHVFCMTHuMvtKzD
Discord Handle
No response
Hotspot Manufacturer
sensecap
Removal Reason
I did not do anything. I don't know why I'm on dennylist
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
No response

Help Me Pls.


[Feature][Connector-V2] Support orc file format in file connector

Purpose of this pull request
#2130

Check list

[x] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

Hi @Hisoka-X, could you please help me to restart CI progress, it seems that have some problems about build docker image...


Heap documentation

Again, this data structure should probably be built using more fundamental components than an internal vec, but that's a consideration for a later revision.


Add support for extra inputs

Introduces format and output as extra workflow inputs and adds more tests to validate that the action works.

@micalevisk can you do a review on that one?


ibuf-ext.el not loaded

on my system i've been having trouble getting perspective to work with ibuffer. i have added the following ibuffer hook:
 (add-hook 'ibuffer-hook
		(lambda ()
		  (persp-ibuffer-set-filter-groups)
		  (unless (eq ibuffer-sorting-mode 'alphabetic)
		    (ibuffer-do-sort-by-alphabetic))))

on opening ibuffer the following error occurs:
persp-ibuffer-generate-filter-groups: Symbol’s function definition is void: ibuffer-remove-duplicates

this seems to be because ibuf-ext.el is not loaded (locate-library confirms this).
to fix this problem i've added a (require 'ibuf-ext) to my init.el. maybe this would be better added somewhere in the perspective code?

I tried fixing this in 460311b, but since I don't use ibuffer regularly, I'm not sure how to test the fix correctly. It should be in MELPA now. Could you please check if that works?

perfect! it works on my system :)
my use-package for perspective was this
  (use-package perspective
      :ensure t
      :bind (("C-x k" . persp-kill-buffer*)
	   ("s-[" . persp-prev)
	   ("s-]" . persp-next))

      :init
      (persp-mode)
      (setq persp-state-default-file (expand-file-name ".persp" user-emacs-directory))
      (add-hook 'ibuffer-hook
		(lambda ()
		  (require 'ibuf-ext)
		  (persp-ibuffer-set-filter-groups)
		  (unless (eq ibuffer-sorting-mode 'alphabetic)
		    (ibuffer-do-sort-by-alphabetic))))
      (add-hook 'kill-emacs-hook #'persp-state-save)
      (persp-state-load persp-state-default-file)
      (persp-switch "main")
      :custom
      (persp-mode-prefix-key (kbd "C-x x")))

i commented out (require 'ibuf-ext), ran org-babel-tangle and restarted. ibuffer works!!!
thank-you!


Make all navigation elements Next links

There are some accessibility issues with some navigation elements, like story links and the close icon in the story page. Currently, they call a function which imperatively routes the user to a new page. The issue with this approach though is that the browser doesn't recognise these navigation elements as anchor tags.
It should be a fairly straight-forward fix, I'll work on it today.

Nice :)


How to get term of use via Powershell?

Hi,
We can get Conditional Access policies via Get-AzureADMSConditionalAccessPolicy. If a term of use is required via conditional access the cmdlet returns an id for it. But how do we get the term of use information like name, display name from the id via Powershell?
Regards Peter
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 618ca851-56c8-5ba1-35de-a7b8e7af8aa2
Version Independent ID: 5facc663-2e29-65ad-f208-982150351b22
Content: Terms of use - Azure Active Directory
Content Source: articles/active-directory/conditional-access/terms-of-use.md
Service: active-directory
Sub-service: compliance
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@theheatDK
Thanks for your feedback! We will investigate and update as appropriate.

Hi @theheatDK, we are awaiting a response from the product group.
Best,
James

Hi @theheatDK , so sorry for the delay in response. The product group said this should work for you:

Get-MgAgreement on this module: PowerShell Gallery | Microsoft.Graph.Identity.Governance 1.4.2
Here is the rest API agreement resource type - Microsoft Graph beta | Microsoft Docs

Please let me know if you still need help with this item. I will close it for now.
Best,
James


Chain use cases.

Hi guys,
Thanks for your project, it is great).
I was wondering whether I can execute one use case with the results of the previous without callback hell?

Escaping callback hell is one of the great benefits of rxjava/reactive programming.
Although it sounds like in this case rather than combining 2 UseCases in the presentation layer, you want one new UseCase that encompasses everything you need for this different use case.

Escaping callback hell is one of the great benefits of rxjava/reactive programming.

That why I like ractive and Android-CleanArchitecture pattern.

Although it sounds like in this case rather than combining 2 UseCases in the presentation layer

For example: when I receive results from one use case I need to pass them to the another use case. That approach leads to such code:
 firstUseCase.execute(new DefaultSubscriber<String>() {
        @Override
        public void onNext(String s) {
          secondUseCase.execute(new DefaultSubscriber<String>() {
            @Override
            public void onNext(String s2) {
              // Grab the results.
            }
          });
        }
      });

Do you suggest to create separate use case that encapsulates previous use cases?

I also think that using composition here is better, if you create a new use case you will have the ability to reuse it at a later time.

@alexandru-calinoiu yes, that sounds a nice solution.
Additionally I faced a situation when base use case returns all entities, but in one of the presenters where I want to use that use case I want to perform for example filtering or sorting.
My question is: what is the right way to implement this filtering(encapsulate this filtering in the use case, perform it after I'll receive results from use case)?

I see 2 options in this case:

if your source has the ability to do the sorting and filtering on the server side you should add that in the repo (for example an restfull api that has the ability to call page, sort and filter stuff)
you can filter the data on the presenter side, if you find yourself manipulating the same data all over again maybe you can extract the common logic in a new use case.

Use RxJava! You have many operators to compose observables:
https://github.com/ReactiveX/RxJava/wiki/Alphabetical-List-of-Observable-Operators

@android10 yep, but UseCase class doesn't provide access to the Observable directly.

@amatkivskiy it all depends from case to case but I see filtering of certain content as a domain or even data layer concern. Filtering is a data manipulation and If the filtering is only going to be perform in a really specific scenario, you could :

Pass the filter selected to the domain layer as an init param to the use case and, as @android10 stated, use operators to perform the filtering of the data before passing it along the presentation layer.

Other consideration would be if this filtering has to be done in a global scale for the entire application scope. Then I would filter all content in the data layer (in the repositories), in order to make sure we are always manipulating the already filtered collection of items.

@jatago in my case I have a situation when one use case client wants all content as is, but another client want it to be sorted or filtered.

@android10 as the guy said, UseCase#execute() does not return Observable, do you mean calling UseCase#buildObservable() directly from outside?


Support for certificate renewal?

Is there any?
Cheers

I haven't tested it yet but per the acme4j docs  you should be able to just re-run the command to generate a new, updated cert.

Any update on this?
About re-running the command, you mean to restart the SpringBoot app?

Hi! afaik you rerun the certbot command that generated your initial set of certificates with the option -renew or alike.  the certbot-project has recommendations for setting up a cron job.


ros_gz: 0.244.12-1 in 'humble/distribution.yaml' [bloom]

Increasing version of package(s) in repository ros_gz to 0.244.12-1:

upstream repository: https://github.com/gazebosim/ros_gz
release repository: https://github.com/ros2-gbp/ros_ign-release.git
distro file: humble/distribution.yaml
bloom version: 0.11.2
previous version for package: 0.244.11-1

ros_gz

No changes

ros_gz_bridge
* Backport: Add conversion for geometry_msgs/msg/TwistStamped <-> gz.msgs.Twist (#468 <https://github.com/gazebosim/ros_gz/issues/468>) (#470 <https://github.com/gazebosim/ros_gz/issues/470>)
* Add support for Harmonic/Humble pairing (#462 <https://github.com/gazebosim/ros_gz/issues/462>)
* Added messages for 2D Bounding Boxes to ros_gz_bridge (#458 <https://github.com/gazebosim/ros_gz/issues/458>)
* Fix double wait in ros_gz_bridge (#347 <https://github.com/gazebosim/ros_gz/issues/347>) (#450 <https://github.com/gazebosim/ros_gz/issues/450>)
* [backport humble] SensorNoise msg bridging (#417 <https://github.com/gazebosim/ros_gz/issues/417>)
* [backport humble] Added Altimeter msg bridging (#413 <https://github.com/gazebosim/ros_gz/issues/413>) (#414 <https://github.com/gazebosim/ros_gz/issues/414>) (#426 <https://github.com/gazebosim/ros_gz/issues/426>)
* [backport humble] Update README.md (#411 <https://github.com/gazebosim/ros_gz/issues/411>)
  The ROS type for gz.msgs.NavSat messages should be **sensor_msgs/msg/NavSatFix** instead of **sensor_msgs/msg/NavSatFixed**
* Contributors: Addisu Z. Taddese, Alejandro Hernández Cordero, Arjun K Haridas, wittenator

ros_gz_image
* Add support for Harmonic/Humble pairing (#462 <https://github.com/gazebosim/ros_gz/issues/462>)
* Fix double wait in ros_gz_bridge (#347 <https://github.com/gazebosim/ros_gz/issues/347>) (#450 <https://github.com/gazebosim/ros_gz/issues/450>)
* Contributors: Addisu Z. Taddese, Alejandro Hernández Cordero

ros_gz_interfaces
* [backport humble] SensorNoise msg bridging (#417 <https://github.com/gazebosim/ros_gz/issues/417>)
* [backport humble] Added Altimeter msg bridging (#413 <https://github.com/gazebosim/ros_gz/issues/413>) (#414 <https://github.com/gazebosim/ros_gz/issues/414>) (#426 <https://github.com/gazebosim/ros_gz/issues/426>)
* Contributors: Alejandro Hernández Cordero

ros_gz_sim
* Add support for Harmonic/Humble pairing (#462 <https://github.com/gazebosim/ros_gz/issues/462>)
* Set on_exit_shutdown argument for gz-sim ExecuteProcess (#355 <https://github.com/gazebosim/ros_gz/issues/355>) (#451 <https://github.com/gazebosim/ros_gz/issues/451>)
* Contributors: Addisu Z. Taddese, Michael Carroll

ros_gz_sim_demos
* [backport Humble] Added more topic to the bridge (#422 <https://github.com/gazebosim/ros_gz/issues/422>)
* Added more topic to the bridge (#422 <https://github.com/gazebosim/ros_gz/issues/422>)
* Fix incorrect subscription on demo (#405 <https://github.com/gazebosim/ros_gz/issues/405>)
* Contributors: Alejandro Hernández Cordero, Arjo Chakravarty

ros_ign

No changes

ros_ign_bridge

No changes

ros_ign_gazebo
* Add support for Harmonic/Humble pairing (#462 <https://github.com/gazebosim/ros_gz/issues/462>)
* Contributors: Addisu Z. Taddese

ros_ign_gazebo_demos

No changes

ros_ign_image

No changes

ros_ign_interfaces

No changes

Holding for an upcoming Humble sync.


跟组件中引用体积过大

2m的体积，能否像material 那样分模块，在官方文档中好像没找到？能否告知一下 ，多谢

Could you make sure you're using @angular/cli that higher than 1.3.0 with:
ng build --prod --build-optimizer

If this problem still exists, can you help to provide a screenshot for the executing result of that specific command?

That should be fine, for webpack you can still easily integrate with build optimizer, but it won't provide support for non-webpack as suggested in https://github.com/angular/devkit/issues/102#issuecomment-322428726.

Wait a minute, are you using JIT for production?

yes , so it is normal do ?

i am still not using aot  now.

JIT is already known for bad performance and shouldn't be used for production at all, nevertheless, in v5 Angular team would made AOT available and default for all conditions (dev, test or even online demo) as suggested in https://docs.google.com/document/d/1rC5dz7AkCZP813daT_bccbS-20OLmXgBVi50CSKx148/pub.

ok,i will try, thank u .

You can just import sub module like
import { NzButtonModule } from 'nz-zorro-antd';

but this is not recommended since without nz-root module and forRoot method, module may run with unpredictable problem, and have not been tested yet.
Support sub module import is our plan, before that you can use build-optimizer to reduce output size. thanks

should use npm install ng-zorro-antd. with build script from own project. no need to use builds from ng-zorro-antd

By using build-optimizer, the size could would reduce from 1.71MB down to 791KB even if you include the full lib, but that's true there're still ways to improve that.

优化空间还蛮大的，至少下列两点能起蛮大作用：

依赖 moment，但在打包时会把所有语言包一并导入。
less 可以考虑在打包前先压缩。

ERROR in Error encountered resolving symbol values statically. Calling function 'ɵmakeDecorator', function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol Injectable in<EMAIL_ADDRESS>resolving symbol ɵe in<EMAIL_ADDRESS>resolving symbol ɵe in<EMAIL_ADDRESS>when using AOT with webpack plugin ? how to fix it?

That's an error of dependencies setting, being tracked at https://github.com/NG-ZORRO/ng-zorro-antd/issues/23.

@trotyl  按照你说的aot打包 居然还是2.7m+ 这次我用的是angular cli。这是为什么

As I said in first reply, please try --prod --build-optimizer. If you have really tried that, you'll encounter the same error as #50 .

According to the result of webpack-bundle-analyzer, moment locale is the problem.
here is my solution:
create a script named rm-moment-locale.js in your project root
copy and paste following content
var globby = require('globby');
var rimraf = require('rimraf');
const path = require('path');

globby([path.resolve(__dirname, '../node_modules/moment/locale/*'), `!${path.resolve(__dirname, '../node_modules/moment/locale/zh-cn.js')}`])
  .then(function then(paths) {
    paths.map(function map(item) {
      rimraf.sync(item);
    });
    console.log('remove redundent moment locales');
  });

add postinstall to your package.json
 "scripts": {
    .....
    "postinstall": "node task/rm-moment-locale.js"
  },

that's it.


typo in README file

Properly merging this one makes more of a hassle than updating it myself.
Thanks for the PR and the correction. Sorry for the long delay.


Is there a way to call a method in the component of the scene currently activated?

How can I call an initialization method when a scene component gets activated?, for example to init an animation

It's same as a any React app, set a ref on the component in renderScene and call a method on the ref.


Add links to logs

Users and assets mentioned in txn logs and asset history should be links.

Done in https://github.com/macterra/artx-market/commit/7bec03638527d03e331c6c35bd8d6b5ce4009f14


Who's using Frisbee?

:white_circle: Add yourself or someone you know!

This looks cool.  You may want to make a note somewhere in your docs about this project is unrelated to frisby.js, especially since supertest is mentioned quite a bit.  It took me a few moments to figure out that these are different projects.

Ah I didn't even know that existed, I'll think about what to do here. Thanks for heads up @michaelerobertsjr

We're using it for the new Syngency mobile app!
syngency.com

So awesome @schmoove !!!

We're evaluating it at @iHeartRadio (one of the largest React app in term of traffic and complexity), however issue #11 is a blocker at the moment.

https://bluewallet.io/

I'm going to start as soon as the cross-fetch PR gets released on NPM. Testing is painful right now.

Releasing it now, one sec

@akmjenkins thanks! version 2.0.6 of frisbee has been released, see https://github.com/niftylettuce/frisbee/releases/tag/v2.0.6 for release notes.  I've also updated the README at https://github.com/niftylettuce/frisbee and provided clearer examples and usage.

v2.10.0 is released with abort support!


Include Azure SDK in Visual Studio Build Tools 2017 installer

Azure SDK cannot be installed from the Visual Studio Build Tools 2017 installer, https://www.visualstudio.com/thank-you-downloading-visual-studio/?sku=BuildTools&rel=15#
This in effect means that you need to install VS 2017 to use Azure SDK on a build server.
Please get Azure SDK included in the Visual Studio Build Tools 2017 installer.
The MSBuild team has asked that this issue is reported to the SDK team
see https://github.com/Microsoft/msbuild/issues/1888

Any comments / any plan to get the problem

+1 for this.

+1

Any news on this?  Visual Studio Build Tools 2017 works for nicely  , but I'm missing out on the Azure Tools / SDK part..

@HenrikR-Reviso this repo is for reporting issues related .NET SDK for azure services/resource providers.
I will find out the right location where this issue needs to be reported.
Thanks for your patience.

@shahabhijeet Any news on where this issues should be reported?

+1

@rainersigwald Reporting to the SDK teams does not result in any progress. There ust be someone at Microsoft responsible for coordinating this kind of cross team issues....

@rainersigwald Reporting to the SDK teams does not result in any progress.
Surely there must be someone at Microsoft responsible for coordinating this kind of cross team issues?

Created a Uservoice issue for this
https://visualstudio.uservoice.com/forums/121579-visual-studio-ide/suggestions/32217496-add-azure-sdk-component-to-vs-build-tools-2017

@shahabhijeet Please remove me as assigned as I have no way of fixing the issue or in any way moving this along

@HenrikR-Reviso I see you have created an entry in the uservoice, so closing this.


Fix correct path to recover the usual behaviour of Lime during Windows Build

In Linux, 'lime build linux' automatically lets you see the compiled project by running it after build, in build windows this is not the case.
Although WindowsPlatform.hx is programmed to do so, it does not happen due to typo.

This depends on the command processor. The default Windows "cmd.exe" processor would not handle "./PiratePig.exe" properly, though "PiratePig.exe" would run the program.

Closing this now since cmd behavior is different from linux-terminal.


Multi-account is not able to proceed with taps and updates since "next_hamster_click" is never set

start_hamster_client is trying to obtain next_hamster_click value from the cache and just returns if it is None or less then the current time.
The thing is - it is never set to an actual value.
I believe that
if next_hamster_click == None or time.time() < next_hamster_click:
        return

should be changed to
if next_hamster_click is not None and time.time() < next_hamster_click:
        return

Hello Thank you. You are right, the code has been updated.


wrongly 'uncovered' lines

Hi, we noticed a few inconsistencies with what lines are considered covered and which are not.
Some things we found:

macros in function bodies are not considered covered even if they get executed: https://codecov.io/gh/simd-lite/simdjson-rs/src/master/src/stage2.rs#L133
branch heads are sometimes not considered covered even if their bodies are: https://codecov.io/gh/simd-lite/simdjson-rs/src/master/src/stage2.rs#L227
inline  function headers are not always considered covered: https://codecov.io/gh/simd-lite/simdjson-rs/src/master/src/lib.rs#L177
unsafe blocks are not considered covered: https://codecov.io/gh/simd-lite/simdjson-rs/src/master/src/lib.rs#L196
initalisation to 0 is sometimes not considered covered: https://codecov.io/gh/simd-lite/simdjson-rs/src/master/src/lib.rs#L227
refferences as function parameters (to inlined functions) are not considered covered: https://codecov.io/gh/simd-lite/simdjson-rs/src/master/src/avx2/stage1.rs#L413
precompiler directives in function bodies are not considered covered: https://codecov.io/gh/simd-lite/simdjson-rs/src/master/src/avx2/generator.rs#L21
break is not considered covered: https://codecov.io/gh/simd-lite/simdjson-rs/src/master/src/avx2/deser.rs#L87
some let assignments are not considered covered: https://codecov.io/gh/simd-lite/simdjson-rs/src/master/src/avx2/deser.rs#L124
some match statements are not considered covered: https://codecov.io/gh/simd-lite/simdjson-rs/src/master/src/value/borrowed.rs#L87

Running into the "inline function headers" bit myself. I think this specific case could be solvable by automatically marking the header as covered if any part of the body is.

Closing in favour of https://github.com/xd009642/tarpaulin/issues/351 might be worth testing the latest develop there are a number of improvements in coverage accuracy that could help some of these issues


Support customize namespace install

It seems we can't install hnc in our customize namespace. Wish there was this feature.
https://github.com/kubernetes-sigs/hierarchical-namespaces/blob/e9d8bb80e54ecfe735235ce608905e6dfbf757ca/internal/setup/webhooks.go#L26-L55

/assign @adrianludwin

This is nontrivial because you'd have to find all the places where
"hnc-system" is hardcoded, both in the configs and in the code, and replace
the former with kustomization and the latter with command-line args. I
suppose you could get away with just the command-line args if you didn't
mind modifying all the configs yourself.
I'm not going to make a PR for this myself but I'd be happy to accept one
if you wanted to submit it!
On Wed, Oct 12, 2022 at 11:42 PM Kubernetes Prow Robot <
@.***> wrote:

Assigned #231
https://github.com/kubernetes-sigs/hierarchical-namespaces/issues/231
to @adrianludwin https://github.com/adrianludwin.
—
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/hierarchical-namespaces/issues/231#event-7577027866,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE43PZA352IFVVP4KXA4I4LWC6ALFANCNFSM6AAAAAARD3LYKI
.
You are receiving this because you were assigned.Message ID:
<kubernetes-sigs/hierarchical-namespaces/issue/231/issue_event/7577027866
@.***>

Can I have a try?

/assign @xgp01 Thanks for trying. I'm looking forward to the implementation of this feature :)

Thanks for the PR and sorry for all the delays, hopefully we can get this in soon :)


Put npaw analytics for shorts behind feature flag

Able to turn off npaw analytics for shorts to prevent from avoid exceeding the limit

5.3.1


BuildConfiguration is now a static property.

BuildConfiguration is now a static property of IntegrationTestEnvironment.

The changes are already in the master branch.


A test to ensure @abc.abstractproperty return value is analyzed correctly

This adds a test for the analysis of return values of abstract properties (properties, marked with @abc.abstractproperty).
This also adds a partial fix for it not being analyzed properly. (related to #115)
Unfortunately, due to some regression (?) between PTVS/master and python-language-server/master, this does not seem to be enough: test variable b analysis results in two possible return values, int (correct) and A.virt (which is incorrect, and eventually resolves to be Unknown). The later seems to be happening because on the first pass<EMAIL_ADDRESS>results in empty set.

Speaking of the later: what is the reasoning behind module's members being analyzed before overall module is? I'd expect import statements in a module to be analyzed before any class definitions in it.


Issue in build gradle

The build gradle in both code had errors due to firebase integration

Assign me this issue

This issue is assigned to you


Index chattiness

Currently, every instance of the word gets hyperlinked (xref) and becomes an instance in the index (iref).  In the section which defines and explains the term, that understandably means the term appears a lot, but the link isn't useful since it's a link back to the current text.
It appears that placing the iref as the child of a <section> causes the entire section to be placed in the index, rather than the specific paragraph -- it might be good to skip generating iref/xref tags that point to the section in which they're placed, instead placing the iref directly as a child of the target section.

(This issue would also benefit from an example document.)

Example is likewise HTTP/3 (built from https://github.com/quicwg/base-drafts/blob/h3qp_auth48/rfc9114.md) where five instances of "malformed" occur across four paragraphs in the section which defines the term.  It would probably make more sense to replace those four paragraphs' appearance in the index with a reference to the section as a whole.
Other terms have similar behavior -- I'd expect it's a common pattern in sections that define and describe a term worth indexing.

So what we need is a way for the target of an auto-link to control auto-links within the element carrying that target.
That sounds like a rather doable piece of post-processing, which should not be too hard to prototype.

Please try https://github.com/cabo/kramdown-rfc/blob/master/bin/kramdown-rfc-autolink-iref-cleanup.rb
Usage:
ruby kramdown-rfc-autolink-iref-cleanup.rb rfc9114.xml >rfc9114-cleaned.xml
kdrfc -h rfc9114-cleaned.xml

If you like what you see, I might insert this into kramdown-rfc itself (so you can use it with kdwatch etc).
Unfortunately, xml2rfc doesn't appear to act on <iref primary=true, so the cleaning effect is a bit limited.
Maybe we'll need to open an issue on that next.

I also opened https://github.com/ietf-tools/xml2rfc/issues/756 as the auto-generated index is still nearly useless when the primary attribute is being ignored.
And yes, https://github.com/ietf-tools/xml2rfc/issues/689...

I left this as a separate command kramdown-rfc-autolink-iref-cleanup.rb for 1.6.6.
After more feedback on how useful this is, I'll look for ways to integrate this into kramdown-rfc, probably via an option in the YAML header.
Not sure we can make much progress without xml2rfc leaving Dornröschenschlaf.

You may want to submit an issue to the xml2rfc repo...

Oh, I already did...  But maybe you could comment on https://github.com/ietf-tools/xml2rfc/issues/756

Good.  I need to decide whether this should be an external tool, invoked by a flag on the command line of kramdown-rfc, or both.  I'm leaning to put this into kramdown-rfc, triggered by a YAML variable in the input instead of a command-line option (I could throw in an environment variable as well).

That seems reasonable.  I personally can't envision a situation in which I don't want this behavior when I'm automatically indexing a term, but others might disagree.  (And if you're explicitly indexing particular instances, that should be respected.)

Closed by f72472a
1.6.10:
Just set this option in the YAML header:
autolink-iref-cleanup: true

Or keep using kramdown-rfc-autolink-iref-cleanup as a separate tool — this is now properly installed with the rest of kramdown-rfc (and has lost its .rb suffix).
Note that I had to keep this an option — the cleanup process canonicalizes the XML, so the output is completely different from the output without the option.  (Maybe I should offer a "cleanup: canonicalize only" option as well.)

Yeah, I noticed that part when I tried to diff against the generated XML.


Revert "allocator: fix out-of-valid-range identities being allocated"

This reverts pull request https://github.com/cilium/cilium/pull/18151.
This commit consistently broke the Multicluster workflow on master. We probably merged a bit quickly because the Multicluster workflow wasn't marked as Required and was very flaky until recently.
cc @ArthurChiao

/test

/test-1.23-net-next

Hi @pchaigno sorry for the broken, will the Multicluster workflow be marked as required in the next? Or are there other ways that I can find multi-cluster related breakages more timely.

@ArthurChiao We've marked the workflow required.

/test-1.21-5.4

Tests are passing, we have several reviews, and this is fixing CI on master. So I marked ready to merge.


Libsnappy.dll missing

[ ] Using latest version as provided on the master branch
[ ] Searched for similar issues including closed ones

What is the purpose of your issue?

[x ] Script won't run
[ ] Encountered bug
[ ] Feature request
[ ] Question
[ ] Other

System information

Your python version: python 3
Your operating system: Win 7

Description

When I try the script it stops at "Libsnappy.dll missing". What can I do?

I've never encountered or heard about such a problem. My guess is that your python 3 installation is faulty. Can you try re-installing it? If that doesn't work, you should try with python 2.
I'm afraid, I can't think of any other solution at the moment.


$destroy() not called at removing marker popup with directive (fixed, code inside)

Hi there !
If you use an angularjs directive as a marker popup, when the marker is remove from path the $destroy() method is not call. It's a big problem when you deal with popups that  use two way binding or watchers, because they continue to live after the marker death ! This is a conceptual bug, who can potentially inflate memory and/or CPU.
I've done a jsfiddle with a corrected version of ui-leaflet.js who send a $destroy() on the $scope of popup directive. The directive finally receive the $destroy event and can do garbage stuff.
Sorry if the fiddle is a little bit crowded, but I had to past all the ui-leaflet code in the javascript section. Just look at the very last lines, they describe a little angular app.
The way it works => jsFiddle :

First ADD a marker with button. This will create marker with directive popup and a $new() scope.
Then launch the popup by clicking on the marker. This will start a timer, have a look to the console.
At least REMOVE the marker with button. This will remove it from path and trigger the $destroy event and let a chance to the directive to stop the timer and also, deeper inside Angular, kill the watchers for two way binding.

What I've done to correct it :
At the end of  _deleteMarker  :  markerData.getMessageScope().$destroy();

Can we rapidly mastering this evolution ? Pull request ?
Vincent

Hi Vincent,
I just found your issue while looking at random issues and I should have seen it sooner.
Indeed, I've submit a PR that fix a similar issue with DOM-markers: https://github.com/angular-ui/ui-leaflet/pull/273 which was merged. While I was fixing it, I was also thinking about popup with directives but since I don't use them, I didn't touch this part of the code...

Nice Valentin !
It should fix this problem. I still use a custom fork of this project otherwise official version crash on my app.

Thanks for reporting.


How to get_all_notes for ICML23?

accepted_notes = client.get_all_notes(content={ 'venueid': 'ICML.cc/2023/Conference'})
Getting V1 Notes: 0it [00:00, ?it/s]
This code works for ICLR but not for ICML.
accepted_notes = client.get_all_notes(content={ 'venueid': 'ICLR.cc/2023/Conference'})

ICML is using the API V2 of OpenReview. That means that the way you instantiate the client should be different:
https://docs.openreview.net/getting-started/using-the-api/installing-and-instantiating-the-python-client

Please carefully look at the way in which an API V2 client is instantiated from the link I shared with you.
Also, notice that the schema of the invitations and the notes changes for the new API so your code will not work the way you shared it. The docs also contains what the new schema looks like, so that you can update the code accordingly.

But this is an original example in the tutorial. The function signature doesn't have a regex key.
May you please directly tell me how to solve this? I believe it only needs one line of code if the function exists.
I have read through the document. And this code also doesn't work for a V2 invitation like ICML.
invitations = client.get_invitations(
        regex='ICML.cc/2023/Conference/.*',
        limit=10,
        offset=0)

From the docs:
https://docs.openreview.net/getting-started/using-the-api/installing-and-instantiating-the-python-client
Instantiate the client
import openreview

# API V2
client = openreview.api.OpenReviewClient(
    baseurl='https://api2.openreview.net',
    username=<your username>,
    password=<your password>
)

https://docs.openreview.net/getting-started/using-the-api/notes/getting-all-submissions
Get all submissions.
submissions = client.get_all_notes(invitation="ICML.cc/2023/Conference/-/Submission")

Not sure what tutorial you were following. Can you please share the link to see if it needs to be updated or if it has an error?

Good. Thanks.
https://docs.openreview.net/getting-started/using-the-api/notes
This page is a little bit confusing.
regex='ICLR.cc/2019/Conference/.*

what can be .*

Thanks for sharing the link. We will update the docs to make it clearer.


[5pt] User Authentication and Landing pages

[x] Implement Site Landing Page
[x] implement simple authentication for user login.
[x] Give style to the user login page.

N.B
Since we comprise 3 members on this team, we will implement simple username authentication

Completed by @gisachris, cheers and happy coding 🥇 👏


create_or_open should always set writable flag

We should also add a test for it
Now if the region already exists, it is returned in readonly mode. However, we expect the region to be writable.

https://github.com/GreptimeTeam/greptimedb/blob/0fbde48655f4732fa9ad512c57b6a0dcb05a8934/src/mito2/src/region/opener.rs#L111-L123
We should set the writable flag to true.

It's not a good way to handle the region's state. After the Datanode restarts, it also involves the create_or_open. However, in this situation, we must set the writable via heartbeat.
In the future, we will introduce a Readonly flag to the TableRouteValue, to indicate the Leader Peer might be dead or unavailable. We should allow create_or_open to open a read-only region, and setting writable via heartbeat.

After the Datanode restarts, it also involves the create_or_open

In this case, the datanode invokes open(), not create_or_open(). create_or_open() is only called when we want to create a region.


Incorrect error type on auth cancellation (No authentication provider 'microsoft' is currently registered.)

Version: 1.54.0-insider (user setup)
Commit: e590188f17162393f50feec19263398e6fe02d13
Date: 2021-02-26T20:39:10.253Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042
Steps to Reproduce

Sing in to Sync Settings
Select Microsoft provider
Press "Allow" and go to the browser
Cancel auth in the browser by pressing "Back"

Actual
VSCode throws:
No authentication provider 'microsoft' is currently registered.

The provider, however, is registered.
Previously, auth API threw "access_denied" error for this particular scenario.

Not sure if this is related... We got the same error in our test using insiders without any sign in actions.

@xisui-MSFT, I'm not sure what your scenario was but I believe that this error is still there:
https://github.com/microsoft/vscode/blame/main/src/vs/workbench/services/authentication/browser/authenticationService.ts#L713
From the consumer's perspective, it doesn't hurt to know what actually caused the authentication failure. So, maybe we can slightly change that try/catch block to be more transperent.

@olegoid Again I'm not sure if this is the same issue. For me looks like that error causes all extension tests fail without running anything. Sample output:
Warning: 'sandbox' is not in the list of known options, but still passed to Electron/Chromium.

[main 2021-03-18T10:08:53.916Z] update#setState idle

(node:17236) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information

(node:17236) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information

No authentication provider 'microsoft' is currently registered.

Settings Sync: Accounts are not initialized

native-keymap: Could not create ITfThreadMgr.

Exit code:   1
Done

Assertion failed: Failed to run tests

You should be able to repro this easily by creating an extension + a test for the extension, and run the test on latest insider build.

@olegoid @RMacfarlane Have you checked whether the test error the same as this issue? It's an important issue as it causes ALL extension tests to fail.

Hey @xisui-MSFT, that sounds like a different issue. I'm having trouble reproducing it with a sample extension, but I think the tests should continue to run even if settings sync doesn't initialize. The native-keymap: Could not create ITfThreadMgr. error sounds more suspicious to me. It would be great if you could open a new issue including details about what version of VS Code insider's you are using and what your test set up looks like. Thanks!

@RMacfarlane Thanks for the info. I think I found the problems, and I'll open some bugs. (BTW, the native-keymap line isn't the problem, basically all the failures have that...)


add mdel

Method to delete multiple files with one request.

4.1.0

and thanks!

Thank you! 😊
Love your work
On Tue, Nov 12, 2019, 12:51 Mathias Buus<EMAIL_ADDRESS>wrote:

and thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mafintosh/s3-storage/pull/3?email_source=notifications&email_token=AAI3CEQVN5RQGUJIFXBFA5DQTKKFVA5CNFSM4JMA5VHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED2AAGQ#issuecomment-552861722,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI3CETFXQJNUMRUZNANRDDQTKKFVANCNFSM4JMA5VHA
.


Elaborate please

How is it useful? How do I go from ClassDeclarationSyntax, for instance, and identify its Namespace?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 63110b74-3e57-a4c7-9ded-7f94c724cd75
Version Independent ID: 5a2800f4-4790-5fb5-8034-06749ee171d3
Content: NamespaceDeclarationSyntax Class (Microsoft.CodeAnalysis.CSharp.Syntax)
Content Source: dotnet/xml/Microsoft.CodeAnalysis.CSharp.Syntax/NamespaceDeclarationSyntax.xml
Service: unspecified
GitHub Login: @dotnet-bot

The Microsoft.CodeAnalysis.CSharp.Syntax types form a syntax tree. If you have ClassDeclarationSyntax for a class that's in a namespace, its Parent will be a NamespaceDeclarationSyntax.
For example:
string code = @"
namespace Foo.Bar
{
    class C {}
}";

var unit = SyntaxFactory.ParseCompilationUnit(code);

var classDeclaration = unit.DescendantNodes().OfType<ClassDeclarationSyntax>().Single();

var namespaceDeclaration = (NamespaceDeclarationSyntax)classDeclaration.Parent;

Console.WriteLine(namespaceDeclaration.Name); // prints Foo.Bar

Though these types will only give you syntactic information. If you don't control the code you're processing, you're probably better off using SemanticModel to find the namespace of a class:
string code = @"
namespace Foo
{
    namespace Bar
    {
        class C {}
    }
}";

var tree = SyntaxFactory.ParseSyntaxTree(code);

var classDeclaration =
    tree.GetRoot().DescendantNodes().OfType<ClassDeclarationSyntax>().Single();

var namespaceDeclaration = (NamespaceDeclarationSyntax)classDeclaration.Parent;

Console.WriteLine(namespaceDeclaration.Name); // prints Bar

var compilation = CSharpCompilation.Create(null).AddSyntaxTrees(tree);

var semanticModel = compilation.GetSemanticModel(tree);

Console.WriteLine(
    semanticModel.GetDeclaredSymbol(classDeclaration).ContainingNamespace); // prints Foo.Bar

Though I'm not sure how much of this information belongs to the API reference.

The whole point of the docs is to make is clear, or at least clearer, as to what's what. I'm providing this feedback, not looking for direct feedback here, per se, but rather to flesh out the docs themselves.

Closing as this work item is being tracked at https://github.com/dotnet/roslyn/issues/27645


ci(accessibility): update action @v1.11.1

updates compatibility with containers required for action

-- Notes
If CI fails to run the action the UPGRADE flag is required to update the system dependencies for the system. After toggling UPGRADE=true and a successful action run it can be removed.
Currently the action is set to only run on the root page of the domain set. If we want a full site run we can use the SITE_WIDE: true flag.

@LauraLangdon @hola-soy-milk the A11yWatch action is now stable and running. New builds have cache and will finish quicker 🙂.
SS below:

Thanks so much, @j-mendez! I'm conferring with the team about the build test error (since the URL it's flagging hasn't changed and also hasn't been flagged on previous builds), and then we can get this merged. Cheers!

@j-mendez thank you for the PR! Could you please try rebasing on the latest main, that should fix the failing build issue?

@j-mendez thank you for the PR! Could you please try rebasing on the latest main? That should fix the failing build issue.

Thank you for the help, done.


Bug while converting from LAB to sRGBColor.get_rgb_hex() and AdobeRGBColor.get_rgb_hex()

Trying to convert from two LAB colors to hex sRGB and AdobeRGB
to sRGB:
lab=LabColor(62.26, 87.83, 94.26)
>>> print(lab)
LabColor (lab_l:62.2600 lab_a:87.8300 lab_b:94.2600)
>>> sRGB = convert_color(lab, sRGBColor)
>>> print(sRGB)
sRGBColor (rgb_r:1.1435 rgb_g:0.0891 rgb_b:0.0000)
>>> sRGB.get_rgb_hex()
'#1241700'

But what is HEX "#1241700" ?
The documentation tells : Converts the RGB value to a hex value in the form of: #RRGGBB
to AdobeRGB:
>>> AdobeRGB = convert_color(lab, AdobeRGBColor)
>>> print(AdobeRGB)
AdobeRGBColor (rgb_r:0.9879 rgb_g:0.1139 rgb_b:0.0000)
>>> AdobeRGB.get_rgb_hex()
'#fc1d00'

and "#fc1d00"
Interestingly with L:56.89 a:50.34 b:49.81 everything works as expected.
Is this a bug or am I doing anything wrong?

Uuups, sorry, my fault. Should have read the docs to the end.
I need to use the clamped_rgb_* values instead of rgb_*.
Just as the documentation describes.
http://python-colormath.readthedocs.io/en/master/conversions.html#rgb-conversions-and-out-of-gamut-coordinates


koordlet: fix flaky tests

Ⅰ. Describe what this PR does

koordlet: fix flaky tests which sometimes fail/panic on data race.
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/hold for more cases


Parser bug in source maps

From issue #14746:
Although I haven't tested it, from looking at the source, I believe there is a similar issue when parsing a sourcemap. Sourcemap entries can have 1, 4, or 5 fields and the 1-field entries (representing an unmapped range) aren't handled correctly; the sourceUrlId, sourceLine, sourceColumn, and fields in a TargetEntry should be set to null but instead they will be set to whatever the values were in the previous TargetEntry.

This issue has been moved to dart-lang/source_maps#8.


Prevent Time::Span overflow

While fixing multiply and divide by numbers, I noticed that there are a lot of possible overflows.
The biggest problem is that a lot of .to_i64 etc. are used and the general type restriction Int or Number for methods.
eg. This makes it possible to pass in a BigInt, which could overflow if .to_i64 is invoked on it.
Related to #5272 and possibly others.
This is a work-in-progress PR.

This is more related to #3103 that other issue. If implicit safe / explicit unsafe if chosen, then there would nothing to be done here. And if the oposite (explicit safe / implicit unsafe), then a safe { } could be used to avoid handmade overflow guard conditions.

@bcardiff Actually there are two things that overflow/wraparound here.

the arithmetic operations like adding Time::Span together
and calling .to_i32 or .to_i64 on a variable with possible wider range.

I would like to avoid handmade overflow guard conditions as much as possible. I see crystal currently does not have a built-in overflow detection, so I would leave Time::Span as is to overflow on arithmetic operations.
But I would like to fix the second issue. So trying to create an invalid Time::Span should raise or be at least harder to do. (eg. as @straight-shoota said to enforce value range through type safety)
Allowing Int and Number is nice, but  mercilessly cutting it down to Int32 or Int64 is not.
For example, doing BigInt#nanoseconds is possible, which is ok as long as it is within Int64 range, because on Line 448 it does self.to_i64.
Anyway, I will fix Time::Span#* and Time::Span#/ for Float and see whether I can eliminate point two without having to use to many conditions (maybe instead using type safety).

@petoem thanks for the interest of the safeness in the numbers realm. It think the second item.

and calling .to_i32 or .to_i64 on a variable with possible wider range.

Is just another case of implicit overflow. Don't you think? Otherwise whatever fix you accomplish for Time::Span would be required to be applied in other places.
I use to_* methods to 1) increase beforehand the precision of the arithmetic to be done, and to 2) ensure the final type to store in var/ivar. I agree that for this second case a safer thing to do is to raise if the receiver is wider than the final range.

Perhaps, something to think about is to make to_i32 raise if the number will overflow, and provide a to_i32! which does overflow.

I have removed the overflow detection I added on arithmetic operations, because I think that llvm provided ones are better and faster.
Following changes/improvement are still in this PR:

initialize only checks types with a wider range than Int64 to avoid overflow it raises
there are separate multiply and divide methods for Int and Float (Int is using the old method)
Float#nanoseconds and Float#seconds now check whether the resulting seconds fit into a Time::Span
Float#nanoseconds and Float#seconds use .trunc instead of .to_i64 to avoid overflow
its now possible to do Time::Span.new and Time::Span.new seconds: 2
Added some more documentation

@RX14 This is a great idea! Maybe the other way around is better (easier to understand), to make .to_i32! raise and .to_i32 overflow.

I'd rather have the "default" be safer.

Can't this PR just be adding multiply and divide for timespan?

Let's give this PR a bit more :heart:

@sdogruyol the initial issue #5272 was fixed, now only the overflow part remains.
overflow is an issue that affects other parts of crystal too, not just Time::Span.
I have played with the thought of adding support for Int overflow checking myself, because the gist in #3103 is pretty much usable.
But the problem is there seems to be no consensus on how to add overflow checking to crystal.

bcardiff commented on Nov 18, 2017
If implicit safe / explicit unsafe if chosen, then there would nothing to be done here. And if the oposite (explicit safe / implicit unsafe), then a safe { } could be used to avoid handmade overflow guard conditions.

Whether it should be implicit or explicit safe and how it should look, needs more discussion.
Anyway, we should definitely get Int overflow checking, in some form, into crystal.

@petoem I am just looking through some PRs.  Are you still working on this?

I am closing this, because #5272 is fixed and int overflow is out of this PRs scope.


Release with Rails 6 support

Hi,
Given that #231 has been merged, would it make sense to do a release of this gem so that people who are upgrading to Rails 6 can benefit from the fix?
Cheers!

I released 4.1.0.
This gem needs new/more maintainers, see #196 please.


[ibm_mq] support host override

Add a parameter that lets the user override the hostname with the provided host. In that case the mq_host tag is not emitted.

Added more unit tests, improved wording and ensured port tag is still emitted if host is set


Update README

@fedorpashin thank you for reporting this. I'll assign someone to take care of it soon.


Demo doesn't work

I get the error:
"Timeout! Please wait a few minutes and retry."

Our system has been affected by a cyber attack. We will resolve this issue as soon as possible during our next working day.

Our system has been affected by a cyber attack. We will resolve this issue as soon as possible during our next working day.

周一恢复后今天又出现这个问题了

我试了一下没问题，是不是你本地网络配置有问题

我试了一下没问题，是不是你本地网络配置有问题

可能是gradio的问题？我刷新了一下网页又正常了，而前一秒在之前的对话中就是一直回复Timeout


[SCM] Allow providers to supply their own Viewlet SVG

VSCode Version: 1.11.1
OS Version: Win10

Instead of the default 'SCM' SVG:

It'd be great if the TFVC provider could provide its own SVG similar to the TFVC logo:

Hi Jeff, this has been heavily discussed in #18675 #21192 and others.
We're not going with that approach for the same reason a Go debugger can't set the Go logo for the Debug view.

Understood.  Thanks @joaomoreno


Update faostat ingest and index

The walden ingest code for faostat was failing. It seems they may have changed the format of their date of update field in the metadata. After fixing that, the code worked well and we have stored all new data in the walden bucket.
@larsyencken I have noticed that we are storing zip files in the walden bucket under folders named after the publication date. But in some cases, the publication date is still the same, while the data may have changed. This means that we are overwriting snapshots of the data. Shouldn't we try to avoid this?

@larsyencken I have noticed that we are storing zip files in the walden bucket under folders named after the publication date. But in some cases, the publication date is still the same, while the data may have changed. This means that we are overwriting snapshots of the data. Shouldn't we try to avoid this?

Ah, you're describing the situation where, say, the FAO retroactively changes their data for the 2021 release, for example. Then we would be overwriting the old snapshot with our script, and we wouldn't know.
It's up to us to decide how to navigate this ourselves. Ultimately, the safest thing would be content-based. In this case, you'd be welcome to use an md5 hash in the path, like:<namespace>/<version>/<md5>/<filename>

Another totally valid option is to simply version it against the date we accessed it, if we can't trust them to provide a reliable dateUpdated field.

Thanks @larsyencken I guess (and hope) that it's not a likely scenario that they change data and not change publication date. I think that, instead of throwing an exception when trying to overwrite a file with a different hash, the logic should be to not overwrite anything (there is no point in overwriting a file that is exactly identical) and to raise a warning if the file for the same publication date has changed. If that ever happens, then we will have to make our paths a bit more complicated.

I think just refusing to overwrite is a good solution 👍
On Fri, 22 Apr 2022 at 11:19, Pablo Rosado @.***> wrote:

Thanks @larsyencken https://github.com/larsyencken I guess (and hope)
that it's not a likely scenario that they change data and not change
publication date. I think that, instead of throwing an exception when
trying to overwrite a file with a different hash, the logic should be to
not overwrite anything (there is no point in overwriting a file that is
exactly identical) and to raise a warning if the file for the same
publication date has changed. If that ever happens, then we will have to
make our paths a bit more complicated.
—
Reply to this email directly, view it on GitHub
https://github.com/owid/walden/pull/27#issuecomment-1106230999, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAIZLD6H4NZCWMLGUOQCZ3VGJVLTANCNFSM5UBPGPSA
.
You are receiving this because you were mentioned.Message ID:
@.***>

This PR should not be merged before this other PR, where modification_date is introduced as a new field in the metadata.


[WIP] add pulsar-io-sqs connectors

add pulsar-io-sqs connector docs

Hi @freeznet many thanks for your inputs.
Based on the discussion in last month, we do not contribute connector docs to Hub directly, instead, we contribute docs to the Pulsar website or the connector repo (if it belongs to SN, like ActiveMQ), then @tuteng will do the sync work to sync contents from the Pulsar website or the connector repo to the SN Hub website.
I'm working on the SQS connector docs and will ping you if I have any questions, thanks in advance.

@Anonymitaet i see, thanks for your brief description. I ll close this pr, should I move the docs in this pr into connector repo?

@freeznet No, I need to make some modifications and I will handle it.


console.log inside test makes output after test ending

🐛 Bug Report
console.log inside test makes output after test ending.
test('test timer', () => {
    console.log(1);
    return new Promise((resolve) => {
        setTimeout(() => {
            console.log(2);
            resolve();
        }, 1000);
    });
});

the actual result:
$ npx jest
  console.log test/test.js:2
    1

 PASS  test/test.js
  ✓ test timer (1018ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        2.056s
Ran all test suites.
  console.log test/test.js:5
    2

To Reproduce

install jest with every config default.
just run the code above.

Link to repl or repo (highly encouraged)
https://repl.it/repls/LightblueSelfreliantApplicationprogram
Run npx envinfo --preset jest
  System:
    OS: Linux 4.15 Ubuntu 18.04.2 LTS (Bionic Beaver)
    CPU: (4) x64 Intel(R) Core(TM) i7-5600U CPU @ 2.60GHz
  Binaries:
    Node: 10.16.0 - /usr/local/bin/node
    npm: 6.10.0 - /usr/local/bin/npm
  npmPackages:
    jest: ^24.8.0 => 24.8.0

This seems to be a duplicate of https://github.com/facebook/jest/issues/4977.
Essentially, the problem description seems the same to me:

console.log inside test makes output after test ending.

This happens because, as per described in https://github.com/facebook/jest/issues/4977:

The last process.stdout.write invocation in an async test is not flushed before Jest's test result summary is written.

This seems to be a duplicate of #4977.
Essentially, the problem description seems the same to me:

console.log inside test makes output after test ending.

This happens because, as per described in #4977:

The last process.stdout.write invocation in an async test is not flushed before Jest's test result summary is written.

thank you


"来園者" needs to be replaced with "ゲスト"

Strongly recommend to replace "来園者" with "ゲスト" , I can see "来園者" is used as a localized Japanese word of "guest" in English, however, it should be "ゲスト" which stands for guest user of OneDrive for Business.
https://docs.microsoft.com/ja-jp/onedrive/b2b-sync

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 69433cdb-79fb-e59d-e208-0c1201b74bfa
Version Independent ID: e69001d7-2292-9f1a-e3d8-cf0afb9b18df
Content: B2B Sync
Content Source: OneDrive/b2b-sync.md
Service: one-drive
GitHub Login: @kaarins
Microsoft Alias: kaarins

@kaarins Thanks.
https://docs.microsoft.com/ja-jp/onedrive/b2b-sync


Feature/end game tablebases

Adding end game tablebases (the end game version of the opening book)

Add SyzygyTablebase class (https://en.wikipedia.org/wiki/Endgame_tablebase), which essentially are databases solving all positions given there are only a certain number of pieces left. The structure should be fairly similar the OpeningBook class, see opening_book.py.
Integrated into engine.py, similar to what is done with OpeningBook.
Added tests
Added 1 example tablebase file for testing only.

-> If you want it to work for all endgame tablebases known: Download here - https://tablebase.lichess.ovh/tables/

Oh also just remembered - suggesting updating the license:
Copyright (c) 2023 Kelvin Chiu, Jeremy Lo, Claudia Yip, Richard Hung

Oh also just remembered - suggesting updating the license:
Copyright (c) 2023 Kelvin Chiu, Jeremy Lo, Claudia Yip, Richard Hung

Was just about to say this, beat me to the chase

Sorry, could you add to the readme section on Features as well please?


Changes to obfuscate the references present in the embedded resourceFields

Changes to obfuscate the references present in the nested resourceFields of a resource where the resoureField is an object itself containing db references.
Tested the API UI manually as shown below.
Example: http://localhost:8080/v1/projects/1a5/services/1s2
Here in API response, the "service" object has resourceField "launchConfig" which is an object containing key "dataVolumesFrom" whose value is of type array[reference[container]]
So value of "dataVolumesFrom" should be obfuscated db container id's
"id": "1s2",
"type": "service",
"links": { … },
"actions": { … },
"name": "random-957277-1458161855",
"state": "inactive",
"accountId": "1a5",
"assignServiceIpAddress": false,
"createIndex": null,
"created": "2016-03-16T20:57:36Z",
"createdTS":<PHONE_NUMBER>000,
"description": null,
"environmentId": "1e1",
"externalId": null,
"fqdn": null,
"healthState": null,
"kind": "service",
"launchConfig": {
"capAdd": [
"SYS_MODULE",
],
"capDrop": [
"SYS_MODULE",
],
"command": [ 2 items
"sleep",
"42",
],
"cpuSet": "2",
"cpuShares": 400,
"dataVolumes": [
"/foo",
],
"dataVolumesFrom": [
"1i1",
],
"dns": [ 2 items
"<IP_ADDRESS>",
"<IP_ADDRESS>",
],
"dnsSearch": [ 2 items
"foo",
"bar",
],
"domainName": "rancher.io",
"entryPoint": [ 2 items
"/bin/sh",
"-c",
],
"environment": {
"TEST_FILE": "/etc/testpath.conf",
},
"healthCheck": {
"healthyThreshold": 5,
"interval": 4,
"name": "check1",
"port": 200,
"requestLine": "index.html",
"responseTimeout": 3,
"unhealthyThreshold": 6,
"strategy": "recreate",
},
"hostname": "test",
"imageUuid": "sim:random-333122-1458161843",
"instanceLinks": {
"container2_link": "1i3",
},
"kind": "container",
"labels": {
"foo": "bar",
},
"memory": 8000000,
"networkMode": "managed",
"ports": [ 2 items
"64122:8681/tcp",
"58021:8082/tcp",
],
"privileged": true,
"publishAllPorts": false,
"readOnly": false,
"requestedHostId": "1h1",
"startOnCreate": true,
"stdinOpen": true,
"tty": true,
"user": "test",
"version": "0",
"workingDir": "/",
"vcpu": 1,
},
https://github.com/rancher/rancher/issues/594

@ibuildthecloud @alena1108 please review the fix.
How do you add tests for API UI? In Integration tests, the ids in reponses are already obfuscated.

@prachidamle could you add an integration test for it? you can extend existing test_svc_discovery/test_activate_single_service test case. Validating that would be enough as the ids are expected to be obfuscated by the test.

@alena1108 changed the PR with integration tests additions

@ibuildthecloud please review - took care of comments and checkstyle

@prachidamle There are quite a few test failures that seen related.

@ibuildthecloud reverted the changes made to add "type" field to embedded objects. This is the reason for most test failures. We should add this change separate.

@ibuildthecloud I have resolved all the prior test failures. The recent failure is not seen on my local setup, that tests passes for me.

@ibuildthecloud woohoo passed passed passed


macOS Catalina: unable to retrieve the right shell

Operating system and version:
macOS Catalina.
nvm debug output:
as no nvm command becomes available, it's hard to answer this one.
nvm ls output:
as no nvm command becomes available, it's hard to answer this one.
How did you install nvm?
install script in readme
What steps did you perform?
just executed the script in the readme
What happened?
it couldn't find any file to put nvm environment variables, because no ~/.zshrc file was there after a clean Catalina installation.
What did you expect to happen?
I was expecting nvm to check, as last resort, for if [ "$SHELL" = "/bin/zsh" ]; then ... and eventually create by itself the $HOME/.zshrc file with those entries.
Is there anything in any of your profile files that modifies the PATH?
Nope.

The installer worked correctly for me by just replacing "bash" with "zsh" after the pipe. So possible easy fix is to just list an install command for each shell in the readme.

The install script is written to be bash-specific.

The installer worked correctly for me by just replacing "bash" with "zsh" after the pipe. So possible easy fix is to just list an install command for each shell in the readme.

That worked for me too, but:

it still adds a bash completion line to .zshrc, is this appropriate?
I had to find by trial-and-error, and there's nothing about this in the readme so not clear whether it's recommended

The install script is written to be bash-specific.

What does "bash-specific" mean - it only runs in bash, or it only updates your bash configuration?
The reason I piped it into zsh is because the readme says the installer "attempts to add the source lines from the snippet below to the correct profile file (~/.bash_profile, ~/.zshrc, ~/.profile, or ~/.bashrc)."
...but it only updated .zshrc when I tried piping the installer into zsh.

It only runs in bash. It should work based on whatever your default shell is.

OK got it.
My default shell is zsh, but when I pipe the script it into bash (as specified in the readme), it updates .bash_profile and ignores .zshrc.
I'd just like to make it clear that the bug occurs even if .zshrc already exists, since the original bug report only talks about the scenario where .zshrc doesn't exist yet.

Profile file detection is very tricky; I'm always open to PRs to improve the install script here.

The installer worked correctly for me by just replacing "bash" with "zsh" after the pipe. So possible easy fix is to just list an install command for each shell in the readme.

Yes, this worked for me, thanks!
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh | zsh
I agree, a simple solution would be to include some extra installation examples.

@marklanhamhc please do not pipe the install script to anything but bash; it's explicitly and only designed to run in bash.


Allow quick fixes to be shown in aux window

fixes: https://github.com/microsoft/vscode/issues/200922
changed from domFocus to getFocus. domFocus was being incorrectly called early, which gets the main window because it had not been attached yet.
initially tried attaching earlier by using container.ownerDocument to create the div, but it threw at https://github.com/microsoft/vscode/blob/9621add46007f7a1ab37d1fce9bcdcecca62aeb0/src/vs/workbench/services/auxiliaryWindow/browser/auxiliaryWindowService.ts#L281C12-L281C12

cc. @bpasero

good point - we don't even need that line there if we call it again.


bug(Error): Error: RayGun extension is unavailable

Issue:
After typing in a PIN on account creation this error appears in console Uncaught (in promise) Error: RayGun extension is unavailable
Steps to reproduce:

Simply follow through the account creation flow and after you create a pin and proceed to the next page the error will appear

Screenshot:

is this consistent or just at random?

Then its likely that a raygun functions are being called instantly before awaiting for the account to initialized or be created.

#272 is working on that problem too


Specify custom domain

Currently the domain h8r.site is hardcoded. We should let user specify it. If it is specified, we don't need to change /etc/hosts in that case.

Also, there're some other preference settings need be set, such as replica size, TLS enabled, use js or ts. Shall we make a Advanced Options mechanism for stack?

Advanced Options is another important thing we should do, but we need to define every option for their behavior, We can open a new issue to discuss.

Agree to handle the domain issue first.

done


Unable to Install

Expected Behavior
npm install iohook --save works without issue

Current Behavior
npm install iohook --save gives an error, building from source also gives an error when executing "npm install"

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

IOHook Version: 0.9.3
Environment name and version (e.g. Chrome 39, node.js 5.4, electron 11.2): nodejs v17.6.0
Operating System and version (desktop or mobile): Arch Linux 64 bit

Errors
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm ERR! code 1
npm ERR! path /home/ox_admin/Documents/Projects/AutoTap/node_modules/iohook
npm ERR! command failed
npm ERR! command sh -c node install.js
npm ERR! Downloading prebuild for platform: iohook-v0.9.1-node-v102-linux-x64
Downloading prebuild.tar.gz
npm ERR! Error: GET https://github.com/wilix-team/iohook/releases/download/v0.9.1/iohook-v0.9.1-node-v102-linux-x64.tar.gz returned 404
npm ERR! Prebuild for current platform (iohook-v0.9.1-node-v102-linux-x64) not found!
npm ERR! Try to build for your platform manually:
npm ERR! # cd node_modules/iohook;
npm ERR! # npm run build
npm ERR!
npm ERR! /home/ox_admin/Documents/Projects/AutoTap/node_modules/iohook/install.js:16
npm ERR!   throw err;
npm ERR!   ^
npm ERR!
npm ERR! [Error: ENOENT: no such file or directory, open '/tmp/prebuild.tar.gz'] {
npm ERR!   errno: -2,
npm ERR!   code: 'ENOENT',
npm ERR!   syscall: 'open',
npm ERR!   path: '/tmp/prebuild.tar.gz'
npm ERR! }
npm ERR!
npm ERR! Node.js v17.6.0
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/ox_admin/.npm/_logs/2022-03-11T06_11_49_405Z-debug-0.log

current version of iohook binary only support for node version 10 - 15 (I forget about electron), there is some PR #363 that not merged yet.
or you can build binary manually: https://wilix-team.github.io/iohook/manual-build.html#building-for-specific-versions-of-node
since you use arch, you can use nvm https://aur.archlinux.org/packages/nvm for manage node version, easy to upgrade and downgrade.

@0xff01WasTaken you can try this temporary solution https://github.com/anasrar/node-iohook-binary


TypeScript faker plugin

Hi 👋, Thank you for merge last PR.
I need auto generated mock object without launch extra server.
for example:
schema
type User {
  id: ID!
  "@faker name.findName"
  name: String!
  "@faker internet.email"
  email: String!
  age: Int
}

query
query User($id: ID!) {
   user(id: $id) {
      name
      email
      age
   }
}

will generate
import { UserQuery } from './generated-type';
import faker from 'faker';

export function userQueryMock(): UserQuery {
  return {
    user: {
      name: faker.name.findName(),
      email: faker.internet.email(),
      age: faker.datatype.number()
    }
  }
}

There will be a lot of customization for this plugin, but for now I want to start with a simple initial implementation.

Codegen doesn't deal with custom directives, mainly because it endless...
Also, moving to Discussions :)


[Bug] isObject() throws a TypeError when an object is created via Object.create(null) #69

Codecov Report

Merging #70 (3be9c32) into main (d250f13) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head 3be9c32 differs from pull request most recent head 88721c5. Consider uploading reports for the commit 88721c5 to get more accurate results

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   98.02%   98.03%
=======================================
  Files          41       42    +1
  Lines         608      611    +3
  Branches      129      130    +1
=======================================
+ Hits          596      599    +3
  Misses         12       12

Impacted Files
Coverage Δ

lib/src/helpers/value.ts
100.00% <ø> (ø)

lib/src/helpers/base.ts
100.00% <100.00%> (ø)

lib/src/helpers/environment.ts
92.59% <100.00%> (-0.52%)
:arrow_down:

lib/src/internal/safe_check.ts
100.00% <100.00%> (ø)

lib/src/symbol/symbol.ts
95.65% <100.00%> (+0.19%)
:arrow_up:


Support multiple notation certificates within the Ratify Helm chart

The current Ratify Helm chart uses a Ratify test certificate to validate images by default. We should ensure that the Helm chart can handle more than one certificate at a time.

/cc @susanshi

Depends on completing this first: https://github.com/deislabs/ratify/issues/282

@dtzar , the helm chart supports specifying a path which Ratify will load all certs from the given path on notation initialization.
I validated notation was able validate the signature successfully, are you happy for me to close this issue?

We need to have this documented somewhere on how to accomplish it.  I have to clean up the documents overall based on Eric's feedback.  How about updating the steps in this article to reflect how you install multiple certificates?  You don't need to provide multiple certificates per-se but install the single one in the same way you would do multiple and put a note there.

Discussed this item during community meeting today. This item was to explore if helm chart had a way to define an array of certs instead specifying one at a time for both Secret and KeyVaultCert. Since we will be working on the verifier CRD with the certificates property, we are closing this item for now.


nsncd: Unclear why still being built from a fork

Describe the bug
pkgs/os-specific/linux/nsncd/default.nix claims
  # https://github.com/twosigma/nsncd/pull/71 has not been upstreamed
  # to twosigma/nsncd yet. Using the nix-community fork in the
  # meantime.

The specified pull request was actually merged two-and-a-half months ago.
https://github.com/nix-community/nsncd also hasn't been synced against the upstream for three months, and is now 42 commits behind upstream.
Expected behavior
Either:

nsncd is being built from the upstream again and the fork is marked as deprecated in some way, or
the comment in default.nix is updated to give a different condition that is being waited for, or
the comment in default.nix is removed and the fork is officially considered the upstream

Notify maintainers
@flokli  @picnoir

Add a :+1: reaction to issues you find important.

Thanks for the heads up.
All our downstream patches have been merged. We can indeed switch to the upstream repository. Opening a PR in a bit. I'm running locally some VM tests to make sure we did not break anything.


ArgumentError (Invalid argument(s): Function expects different amount of type arguments. Provided 1, but expected 2.)

I'm using the following MappingHook to handle cases where I add a field to a model after that model has already been introduced to the Firestore schema.
@MappableClass()
class Entry with EntryMappable {
  const Entry({
    required this.id,
    required this.createdAt,
    required this.title,
    required this.roaster,
    required this.origin,
    required this.overallRating,
    required this.labels,
  });

  final String id;
  final int createdAt;
  final String title;
  final String roaster;
  final Origin origin;
  final int overallRating;
  @MappableField(hook: BackwardsCompatibleHook<List<String>>([]))
  final List<String> labels;
}

class BackwardsCompatibleHook<T> extends MappingHook {
  const BackwardsCompatibleHook(this.defaultValue);

  final T defaultValue;

  @override
  Object? beforeDecode(Object? value) {
    if (value == null) {
      return defaultValue;
    }
    return value;
  }
}

This "works" fine and is functioning at runtime but after enabling the All exceptions breakpoint in VSCode I noticed that the following error was being thrown in type_switcher:
ArgumentError (Invalid argument(s): Function expects different amount of type arguments. Provided 1, but expected 2.)

I can't exactly figure out what the issue is and my playing around with the types involved here hasn't helped. Notably, I removed the hook and just pretended like that field had always been there and it still threw the Exception so the hook itself may be a red herring.

Looking closer at this, I'm wagering that this is "expected" since isForType catches any Exceptions thrown, so I'm gonna close this since AFAICT it's working as intended.