App crashes on pressing the "My Location" icon in the upload wizard

Summary
The app crashes on pressing the "My Location" button in the upload wizard. The same icon shows a dialog requesting for location access in the Nearby section and in the Map fragment of the Explore section.
Steps to reproduce

Open the Contribution tab
Click on the upload from gallery icon (either regular or the custom selector)
Choose an image and click on the map icon
Click on the "My Location" icon present just above the green coloured floating icon

Expected behaviour
A dialog must appear requesting for location access.
Actual behaviour
The app crashes on clicking the icon.
Device name
Redmi 5A
Android version
8.1.0
Commons app version
master and prodDebug
Device logs
java.lang.NullPointerException: Attempt to invoke virtual method 'double android.location.Location.getLatitude()' on a null object reference
        at fr.free.nrw.commons.LocationPicker.LocationPickerActivity.getCenter(LocationPickerActivity.java:457)
        at fr.free.nrw.commons.LocationPicker.LocationPickerActivity.lambda$addCenterOnGPSButton$4$LocationPickerActivity(LocationPickerActivity.java:451)
        at fr.free.nrw.commons.LocationPicker.-$$Lambda$LocationPickerActivity$adF53ASiF4sbH3p2XVSpYljRmC0.onClick(Unknown Source:2)
        at android.view.View.performClick(View.java:6304)
        at android.view.View$PerformClick.run(View.java:24803)
        at android.os.Handler.handleCallback(Handler.java:794)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:176)
        at android.app.ActivityThread.main(ActivityThread.java:6651)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:547)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:824)
E/ACRA: ACRA caught a NullPointerException for fr.free.nrw.commons
    java.lang.NullPointerException: Attempt to invoke virtual method 'double android.location.Location.getLatitude()' on a null object reference
        at fr.free.nrw.commons.LocationPicker.LocationPickerActivity.getCenter(LocationPickerActivity.java:457)
        at fr.free.nrw.commons.LocationPicker.LocationPickerActivity.lambda$addCenterOnGPSButton$4$LocationPickerActivity(LocationPickerActivity.java:451)
        at fr.free.nrw.commons.LocationPicker.-$$Lambda$LocationPickerActivity$adF53ASiF4sbH3p2XVSpYljRmC0.onClick(Unknown Source:2)
        at android.view.View.performClick(View.java:6304)
        at android.view.View$PerformClick.run(View.java:24803)
        at android.os.Handler.handleCallback(Handler.java:794)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:176)
        at android.app.ActivityThread.main(ActivityThread.java:6651)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:547)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:824)

Screen-shots
No response
Would you like to work on the issue?
Yes

Interestingly, it does not crash for me on Android 13. Thanks for finding the issue!

Now I am getting the crash, with the same steps.

Thank you for pointing this out. I may have overlooked it since most of the images I tested did not have an EXIF location and I was getting consistent results for all of them.

@nicolas-raoul, the location icon is used in a different sense in the upload wizard. Since the aim of using the location icon is to retrieve the location from the EXIF data, we may have to explain this behaviour to the user in case it is not available. Should we set it as the current location of the user and explain this behaviour as a pop-up or simply display a toast and ask him/her to set it manually?

It seems to me that the button has the same meaning in all activities... if not would you mind detailing what activity has what button meaning? Thanks!

I am sorry, I may not have interpreted this correctly but for Nearby and Explore, it says:

Permission required to display a list of nearby places

This would display the places nearest to the user. However, in case of uploads, the location in the EXIF data may be different from the current location of the user. Are we not focusing on the place where the picture was taken in the upload wizard?

I tried adding an image with EXIF data from the drive you had shared in the comments section of one of the issues and clicking the "My Location" icon successfully points to Japan, whereas the user's current location is not Japan:

So, clicking the icon has a different meaning here as it is not pointing to my current location (India)

Hi @nicolas-raoul, I just wanted to confirm the expected behaviour once. Should tapping the icon centre the map on the user's current location even when the image has EXIF location?

The "target" shaped icon, when tapped, should center the map on the user's current location; at least in all of the app's map activities with this icon that I can think of: Nearby, the Upload Wizard, the media details location editor, the Explore map. Thanks! :-)

Unfortunately, I'm still observing this in some cases (at the least). So, re-opening the issue.
The following is the log for the crash I observe:
Crash log

java.lang.RuntimeException: Failure delivering result ResultInfo{who=@android:requestPermissions:, request=42, result=-1, data=Intent { act=android.content.pm.action.REQUEST_PERMISSIONS (has extras) }} to activity {fr.free.nrw.commons/com.karumi.dexter.DexterActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'double fr.free.nrw.commons.location.LatLng.getLatitude()' on a null object reference
        at android.app.ActivityThread.deliverResults(ActivityThread.java:5516)
        at android.app.ActivityThread.handleSendResult(ActivityThread.java:5555)
        at android.app.servertransaction.ActivityResultItem.execute(ActivityResultItem.java:54)
        at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:45)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2345)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loopOnce(Looper.java:233)
        at android.os.Looper.loop(Looper.java:344)
        at android.app.ActivityThread.main(ActivityThread.java:8212)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:584)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1034)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'double fr.free.nrw.commons.location.LatLng.getLatitude()' on a null object reference
        at fr.free.nrw.commons.LocationPicker.LocationPickerActivity$2.onLocationPermissionGranted(LocationPickerActivity.java:488)
        at fr.free.nrw.commons.location.LocationPermissionsHelper.lambda$requestForLocationAccess$0$LocationPermissionsHelper(LocationPermissionsHelper.java:65)
        at fr.free.nrw.commons.location.-$$Lambda$LocationPermissionsHelper$d2wvPL4xiASUOzfwrYH5KkU9-aM.run(Unknown Source:4)
        at fr.free.nrw.commons.utils.PermissionUtils$1.onPermissionsChecked(PermissionUtils.java:137)
        at com.karumi.dexter.MultiplePermissionListenerThreadDecorator$1.run(Unknown Source:8)
        at com.karumi.dexter.MainThread.execute(Unknown Source:6)
        at com.karumi.dexter.MultiplePermissionListenerThreadDecorator.onPermissionsChecked(Unknown Source:7)
        at com.karumi.dexter.DexterInstance.onPermissionsChecked(Unknown Source:57)
        at com.karumi.dexter.DexterInstance.updatePermissionsAsGranted(Unknown Source:26)
        at com.karumi.dexter.DexterInstance.onPermissionRequestGranted(Unknown Source:0)
        at com.karumi.dexter.Dexter.onPermissionsRequested(Unknown Source:4)
        at com.karumi.dexter.DexterActivity.onRequestPermissionsResult(Unknown Source:51)
        at android.app.Activity.dispatchRequestPermissionsResult(Activity.java:8618)
        at android.app.Activity.dispatchActivityResult(Activity.java:8475)
        at android.app.ActivityThread.deliverResults(ActivityThread.java:5509)
        ... 13 more

I think this happens when we try to get to the location immediately after we got the permission. I suppose we at the least handle this gracefully rather than letting the app crash? Like skipping the getLatitude() call when the object is null?

Oops! Seems like I missed some part while copy-pasting and merging with main. Thank you for the logs, I'll fix it today.


Trimorphic number in DART

💥 Proposal
The dart script will determine if given number is trimorphic or not.
Have you read the Contributing Guidelines on Pull Requests?
Yes.

/assign


What is the specific difference between controlnet_inpainting and sd_inpainting?

According to the effect of sd_inpaint, mask_image is used to control the area that needs to be regenerated, so the difficulty is actually the generation of mask image. From the input of controlnet_inpainting and the final effect, it requires an additional seg_map, and the seg_map image does not show its role in the final effect.
The top image is the effect of stable diffusion inpainting and the bottom image is the effect of controlnet_inpainting.

For this simple example, yes, they are almost the same, as the segmentation map doesn't provide strong guidance. But if you try to mask a person, and wanna generate a new person with specific pose, a control hint is needed. @cb614611757


Implement RobotFramework variants

Resolves #157
Description
Demonstrates how to:

enable a variant mechanism to use the same RobotFramework test (as requested by QE) for variants: { REST flow using Go proxy in /cmd, Python flow using client in clients/python}
demonstrate can be used for User Stories
demonstrate can be used to prove logical schema and logical mapping

Highlight semantic difference in data model used in REST (defined in OpenAPI) Vs Python client
for example in python client there is a required ModelArtifact and a required author:
https://github.com/opendatahub-io/model-registry/blob/9f3f9a219ded31470d674bacc4250f2f1e5a4923/clients/python/src/model_registry/types/contexts.py#L50-L52
(here we see 3 required properties)
which is not the case for OpenAPI generated model:
https://github.com/opendatahub-io/model-registry/blob/9f3f9a219ded31470d674bacc4250f2f1e5a4923/pkg/openapi/model_model_version.go#L21-L35
(here we see none required properties)
As coming from the OpenAPI contract:
https://github.com/opendatahub-io/model-registry/blob/9f3f9a219ded31470d674bacc4250f2f1e5a4923/api/openapi/model-registry.yaml#L1041-L1054
How Has This Been Tested?
# start MLMD
docker run -p 9090:8080 --env METADATA_STORE_SERVER_CONFIG_FILE=/tmp/shared/conn_config.pb --volume ./test/bdd:/tmp/shared gcr.io/tfx-oss-public/ml_metadata_store_server:1.14.0

# start ModelRegistry
./model-registry proxy

TEST_MR_HOST=host.docker.internal robot test/robot/UserStory.robot
TEST_MR_HOST=host.docker.internal robot test/robot/MRandLogicalModel.robot
TEST_MR_HOST=host.docker.internal TEST_MODE=Python robot test/robot/MRandLogicalModel.robot

You can omit TEST_MR_HOST=host.docker.internal if not used in emulated/DevContainer environment
Merge criteria:

[x] The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7deb5a3) 74.60% compared to head (3c137cb) 86.85%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #158       +/-   ##
===========================================
+ Coverage   74.60%   86.85%   +12.24%
===========================================
  Files          15       11        -4
  Lines        2099      540     -1559
  Branches       67       68        +1
===========================================
- Hits         1566      469     -1097
+ Misses        387       53      -334
+ Partials      146       18      -128

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lgtm!
But as I actively participated in the implementation, I would let final approval/review from another maintainer.

lgtm from QE perspective


Spyder GUI crashes after upgrade to Ubuntu 18.10

Issue Report Checklist

[x] Searched the issues page for similar reports
[x] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[x] Could not reproduce inside jupyter qtconsole (if console-related)
[x] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[x] Reset preferences with spyder --reset
[x] Reinstalled the latest version of Anaconda
[x] Tried the other applicable steps from the Troubleshooting Guide

[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
When I open spyder, the GUI crashes after a while. I have to do ctrl+c in the terminal to completely stop the spyder process.
What steps reproduce the problem?

Opening and using Spyder GUI.

What is the expected output? What do you see instead?
The GUI crashes. This problem started after I upgraded to Ubuntu 18.10. After the upgrade I wasn't able to boot up. I read on forums that this issue could be related to my Graphics drivers. Hence I removed NVIDIA drivers and then I was able to boot up. But then Spyder started giving me this issue.
Paste Traceback/Error Below (if applicable)

I see the following things on my terminal while using Spyder GUI.

nouveau: kernel rejected pushbuf: No such file or directory
nouveau: ch5: krec 0 pushes 0 bufs 1 relocs 0
nouveau: ch5: buf 00000000 00000002 00000004 00000004 00000000
nouveau: kernel rejected pushbuf: No such file or directory
nouveau: ch5: krec 0 pushes 0 bufs 2 relocs 0
nouveau: ch5: buf 00000000 00000002 00000004 00000004 00000000
nouveau: ch5: buf 00000001 00000006 00000004 00000000 00000004
nouveau: kernel rejected pushbuf: No such file or directory
nouveau: ch5: krec 0 pushes 0 bufs 1 relocs 0
nouveau: ch5: buf 00000000 00000003 00000004 00000004 00000000
nouveau: kernel rejected pushbuf: No such file or directory
nouveau: ch5: krec 0 pushes 0 bufs 1 relocs 0
nouveau: ch5: buf 00000000 00000003 00000004 00000004 00000000
python: ../nouveau/pushbuf.c:723: nouveau_pushbuf_data: Assertion `kref' failed.

Versions

Spyder version: Spyder 3.3.1
Python version:  3.6.6
Qt version: 5.9.6
PyQt version: 5.9.2
Operating System name/version: Linux

This is a problem with your graphics card drivers. For now, please use your Intel card by default instead of the Nvidia one.
This could be solved in our next release (3.3.2, to be released next week), which will use software rendering instead of accessing the graphics card. But in case it doesn't, there's nothing we can do about it, sorry.

I downgraded PyQt to 5.6 and now spyder is working.


upgrade gradle to 8.1.1

Description
upgrade gradle to 8.1.1
refer: https://github.com/opensearch-project/OpenSearch/pull/7270
Issues Resolved
Check List

[ ] New functionality includes testing.

[X] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #418 (877f682) into main (81ddb4b) will increase coverage by 0.12%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main     #418      +/-   ##
============================================
+ Coverage     72.69%   72.82%   +0.12%
  Complexity      701      701
============================================
  Files           112      112
  Lines          4670     4670
  Branches        611      602       -9
============================================
+ Hits           3395     3401       +6
  Misses         1019     1019
+ Partials        256      250       -6

see 5 files with indirect coverage changes

@getsaurabh02  @lezzago  @sbcd90  Can this be backported to 2.x? Believe causing same failure: https://build.ci.opensearch.org/job/distribution-build-opensearch/7765/consoleFull


Fix crash in presentLocalNotification

Crash was caused by passing an invalid type to [RCTConvert UNNotificationRequest:id] which is expecting a dictionary but UNNotificationRequest object was provided

this is deprecated. The fix has been applied


Readability typographical / grammatical error

There is a message with a potential readability issue. This message is shown in a warning reminder tooltip on https://github.com/MicrosoftDocs/azure-docs/edit/master/articles/active-directory/develop/v2-protocols-oidc.md (at the bottom of the "Successful token response" section).
Current Sentence

Tokens for Microsoft services can use a special format that will not validate as a JWT, and may also encrypted for consumer (Microsoft account) users.

Proposed Change to Sentence
From:

.. and may also encrypted ...
To:
... and may also be encrypted ...

Updated Sentence

Tokens for Microsoft services can use a special format that will not validate as a JWT, and may also be encrypted for consumer (Microsoft account) users.

Scope
Improve readability with minimal modification. No major structural changes made (in order to preserve the original intent).

@trentapple : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; thanks @trentapple.


ocean.js: Only allow code merges if unit test code coverage ratchets up

Is your feature request related to a problem? Please describe.
We constantly have bug "fixes" where it's just a change to the code, but there are no unit tests. Over time the quality of the sw deteriorates. The excuse is "not enough time" but this is simply untrue because we do pay back in spades. Quality comes for free, and then some. So we need to do more tactics to enhance quality. And helping to ratchet up code coverage ratchets up is a good one.
Towards code quality, if we have a constraint where % code coverage must go upwards, it not only prevents code quality from degrading due to missing tests, over time it ratchets the % coverage upwards and therefore quality upwards.
Describe the solution you'd like
Only allow a PR to be merged (or a direct commit) if % code coverage doesn't go down.
This is pretty common SW engineering practice. We did it on the bigchaindb code base with good success. Let's do it here.

This is setup in this repo as required checks:


getchar() in a loop can only get one character

Steps to reproduce

suppose "abc" is in the clipboard.
:while 1 | echom getchar() | endw
press Ctrl+Shift+V
only the ascii of the first character a is printed.

Expected behaviour
97
98
99

is printed.
By the way, Gvim on windows works as expected.
Version of Vim
9.0.213
Environment
OS: Linux
terminal: GNOME Terminal 3.14.3
Logs and stack traces
No response

Close as the issue is fixed along with #11172.

Steps to reproduce

suppose "abc" is in the clipboard.
:while 1 | echom getchar() | endw
press Ctrl+Shift+V
only the ascii of the first character a is printed.

What does Ctrl-Shift-V do?  Is that a Gnome terminal thing?
If so, then perhaps bracketed paste is interfering.
--
A meeting is an event at which the minutes are kept and the hours are lost.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Thanks, the issue has been fixed by patch 9.0.0575


404 Not Found: @ember-decorators/argument@latest

Hi,
Failed to install on<EMAIL_ADDRESS>Command failed: npm install --save-dev --loglevel error @ember-decorators/argument
npm ERR! code E404
npm ERR! 404 Not Found: @ember-decorators/argument@latest

We just changed the name and haven't yet published the package, sorry about that! I'm pushing it out today along with a fix for that other problem we discovered with validations, will update when it's out

Package has been published under the new name! 😄


Bug report when enable Nginx after update 24.7

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x ] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[x ] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[x ] The title contains the plugin to which this issue belongs

Describe the bug
After upgrading to 24.7 a bug report appeared, nginx and waf naxsi logs are missing. When restarting the service, the bug report appears. Nginx itself proxies, but no more.
The nginx and waf configurations have not been changed since the upgrade.
To Reproduce
Steps to reproduce the behavior:

Go to opnsense
Click on update
After update go in Loby -> Dashboard
Add Widget "Services"
Save widget
Click on reload service "Reverse Proxy and Web Server"
Go Services -> Nginx -> Logs / HTTP Access or HTTP Error

Expected behavior
Service reload, there are logs in Nginx
Screenshots

Relevant log files
In bug report
PHP Error:
[25-Jul-2024 18:08:57 Europe/Moscow] Exception: Response Already Sent in /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Response.php:97
Stack trace:
#0 /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php(356): OPNsense\Mvc\Response->send()
#1 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php(167): OPNsense\Base\ApiControllerBase->afterExecuteRoute(Object(OPNsense\Mvc\Dispatcher))
#2 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(156): OPNsense\Mvc\Dispatcher->dispatch(Object(OPNsense\Mvc\Request), Object(OPNsense\Mvc\Response), Object(OPNsense\Mvc\Session))
#3 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(139): OPNsense\Mvc\Router->performRequest(Object(OPNsense\Mvc\Dispatcher))
#4 /usr/local/opnsense/www/api.php(36): OPNsense\Mvc\Router->routeRequest('/api/nginx/logs...', Array)
#5 {main}
[25-Jul-2024 18:08:58 Europe/Moscow] Exception: Response Already Sent in /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Response.php:97
Stack trace:
#0 /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php(356): OPNsense\Mvc\Response->send()
#1 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php(167): OPNsense\Base\ApiControllerBase->afterExecuteRoute(Object(OPNsense\Mvc\Dispatcher))
#2 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(156): OPNsense\Mvc\Dispatcher->dispatch(Object(OPNsense\Mvc\Request), Object(OPNsense\Mvc\Response), Object(OPNsense\Mvc\Session))
#3 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(139): OPNsense\Mvc\Router->performRequest(Object(OPNsense\Mvc\Dispatcher))
#4 /usr/local/opnsense/www/api.php(36): OPNsense\Mvc\Router->routeRequest('/api/nginx/logs...', Array)
#5 {main}
[25-Jul-2024 18:09:04 Europe/Moscow] Exception: Response Already Sent in /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Response.php:97
Stack trace:
#0 /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php(356): OPNsense\Mvc\Response->send()
#1 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php(167): OPNsense\Base\ApiControllerBase->afterExecuteRoute(Object(OPNsense\Mvc\Dispatcher))
#2 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(156): OPNsense\Mvc\Dispatcher->dispatch(Object(OPNsense\Mvc\Request), Object(OPNsense\Mvc\Response), Object(OPNsense\Mvc\Session))
#3 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(139): OPNsense\Mvc\Router->performRequest(Object(OPNsense\Mvc\Dispatcher))
#4 /usr/local/opnsense/www/api.php(36): OPNsense\Mvc\Router->routeRequest('/api/nginx/logs...', Array)
#5 {main}
[25-Jul-2024 18:09:06 Europe/Moscow] Exception: Response Already Sent in /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Response.php:97
Stack trace:
#0 /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php(356): OPNsense\Mvc\Response->send()
#1 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php(167): OPNsense\Base\ApiControllerBase->afterExecuteRoute(Object(OPNsense\Mvc\Dispatcher))
#2 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(156): OPNsense\Mvc\Dispatcher->dispatch(Object(OPNsense\Mvc\Request), Object(OPNsense\Mvc\Response), Object(OPNsense\Mvc\Session))
#3 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(139): OPNsense\Mvc\Router->performRequest(Object(OPNsense\Mvc\Dispatcher))
#4 /usr/local/opnsense/www/api.php(36): OPNsense\Mvc\Router->routeRequest('/api/nginx/logs...', Array)
#5 {main}
[25-Jul-2024 18:09:06 Europe/Moscow] Exception: Response Already Sent in /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Response.php:97
Stack trace:
#0 /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php(356): OPNsense\Mvc\Response->send()
#1 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php(167): OPNsense\Base\ApiControllerBase->afterExecuteRoute(Object(OPNsense\Mvc\Dispatcher))
#2 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(156): OPNsense\Mvc\Dispatcher->dispatch(Object(OPNsense\Mvc\Request), Object(OPNsense\Mvc\Response), Object(OPNsense\Mvc\Session))
#3 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(139): OPNsense\Mvc\Router->performRequest(Object(OPNsense\Mvc\Dispatcher))
#4 /usr/local/opnsense/www/api.php(36): OPNsense\Mvc\Router->routeRequest('/api/nginx/logs...', Array)
#5 {main}

Additional context
Add any other context about the problem here.
Environment
Software version used and hardware type if relevant.
e.g.:
OPNsense 24.7-amd64
Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz
Network VMXNET 3

Same issue here after upgrade. No access/error logs and got same issue report. os-nginx version is 1.34.

can you test with
opnsense-patch -c plugins -a kulikov-a a7ef2d9 (https://github.com/opnsense/plugins/commit/a7ef2d9a29e858d6700a81aab22417df9a1adb0c)
please?

can you test with opnsense-patch -c plugins -a kulikov-a a7ef2d9 (a7ef2d9) please?

Hi. i've applied this patch. Access/Error logs are available again and no any bug reports. Looks like patch solved this issue.

@ivulit great! thanks, i'll clean it up and make a pr a little later

can you test with opnsense-patch -c plugins -a kulikov-a a7ef2d9 (a7ef2d9) please?

Thanks! It's work!!!!!!!!!

@kulikov-a Thanks a lot for quick response!

Can also confirm the update command fixes it. Hopefully it gets through into the next update so everyone can have it forced through :P

quick and easy fix! thanks!

It has been merged now but I missed this for 24.7.1. Sorry.


Igor stop changing thing that we make

grrrr

Idk what you don't like me changing. Like version number I get but like, what do you mean by this?


Migrating from handsontable-meteor to npm meteor

I am updating a table made with javascript, react<EMAIL_ADDRESS>to use<EMAIL_ADDRESS>After updating, without making changes to the container or table, cells are no longer rendering and interactions such as scrolling and the context menu have been lost. Is this a known issue?

Closed, simply needed to import 'react-handsontable' as well.


Add extra context to messages that are added to channels, allowing the logging controller to take more responsibility in what messages to log

I have removed the DoNotLog flags from UserInfoPopup on purpose since all messages added from it are "reposts", i.e. messages that wouldn't be logged anyway
Currently it's the logger that checks whether or not to log reposts - this should just be moved to Channel's addMessage function instead
Fixes #5470


Update ci.yml

Description
CI is failing right now, try to fix it.

@ydcjeff can you check and fix what happens with netlify deployment please ?


default redis cluster (bp cherry pick  #14838)

Signed-off-by: Rama Chavali<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ramaraochavali
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ostromart
If they are not already assigned, you can assign the PR to them by writing /assign @ostromart in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @ramaraochavali. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hzxuzhonghu @rshriram @howardjohn @fpesce This is the manual back port for #14838 . Can you PTAL?

/ok-to-test

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
b703cc8d0ab3f656195ca15845991d8e8140c696
link
/test e2e-simpleTests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
b703cc8d0ab3f656195ca15845991d8e8140c696
link
/test e2e-simpleTests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-release-1.2

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ramaraochavali, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Approvals feedback

Updates the feedback from the approvals task to be more clear on the number of approvals required and how the current approvals are processed.
Fixes #17

👍

@fokusferit - for your review - added tests for improving the approval feedback, available here:
https://github.com/zalando-incubator/Zincr/blob/approvals-feedback/test/approvals.test.ts


Fix windows warning

Resolves warning introduced by #25.
Warning in CI.
Signed-off-by: Anas Abou Allaban<EMAIL_ADDRESS>

@Karsten1987 this should resolve the warning. Could you run CI please?

awesome. Thanks for the patch.
CI:

Linux
Linux-aarch64
macOS
Windows

@piraka9011 it looks like as if not all windows warnings are addressed in this patch.

Interesting... There is one in realtime_tools that I won't address in this PR ofc.
But I can probably fix the other one in the joint_state_controller.

Windows

appreciated!

@Karsten1987 I thought we wanted to take a step away from rcutils and employ more of rcpputils. This PR does the opposite.

agreed, but in this case it's the absolute correct solution, IMO.


Remove unused connection from Repository

Let's remove this - it's not used, but marked as public API and we're thinking about removing Adapter#connection.

Yep. Makes sense.


Version 0.6.0

<!-- Make sure you have read http://napalm.readthedocs.io/en/latest/contributing/index.html --!>

💯

Coverage increased (+0.4%) to 86.207% when pulling f6ae5f1d396ef9c0d1bc0f659cde173a521f4e75 on develop into e764388e8951d5a403009a07072dfb65244ba51a on master.

Coverage increased (+0.4%) to 86.207% when pulling c1f502eeae2ca64c140a34b02a26a8a1519d63dc on develop into e764388e8951d5a403009a07072dfb65244ba51a on master.


Neural network support?

I wonder does modAL supports to pick data for neural net such as object detection model? Thanks a lot.

Hi! Neural networks are supported, currently you can use Keras with its scikit-learn wrapper or PyTorch with the Skorch library.

Hi! Neural networks are supported, currently you can use Keras with its scikit-learn wrapper or PyTorch with the Skorch library.


Examples has reference to wrong plugin

Page is for mysql_request but the examples has sql_request referred.
evaluate sql_request(
'Server=contoso.mysql.database.azure.com; Port = 3306;'
'Database=Fabrikam;'
h'UID=USERNAME;'
h'Pwd=PASSWORD;',
'select * from [dbo].[Table]')
| where Id > 0
| project Name
evaluate sql_request(
'Server=contoso.mysql.database.azure.com; Port = 3306;'
'Database=Fabrikam;'
h'UID=USERNAME;'
h'Pwd=PASSWORD;',
'select * from [dbo].[Table]')
| where Id > 0

project Name

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 29012c32-2298-5f5a-aa99-92bc8526a2ed
Version Independent ID: a3cd1b63-eba2-fd0b-f434-5df88d9c074b
Content: mysql_request plugin - Azure Data Explorer
Content Source: data-explorer/kusto/query/mysqlrequest-plugin.md
Service: data-explorer
GitHub Login: @orspod
Microsoft Alias: orspodek

@SudheeshGH Thanks for reaching out. We will investigate and update the thread accordingly.

@SudheeshGH Thanks for your feedback. We've submitted a documentation change based on your suggestion, and the updated article should be live by tomorrow. Please let us know if there's anything more we can do for you. To follow up on this issue, leave us a comment with an @mention.
#please-close

@shsagir  Thank you. There were also few other reference of SQLDB instead of  MySQLDB in few places on same page , Hope that also will be addressed.
"The following example sends a SQL query to an Azure SQL DB database retrieving all records from "
"SQL authentication with username and password" : I think it is Passport Authentication.


fix for AlleleListUtilsUnitTest

fixes #607
@lbergelson please review

:+1:  Thanks for fixing this.  Just the comment on the comment.  Feel free to merge when that is updated.
I do think this test class is still very confusing in general though.
I don't understand why it's testing on a random combinatorial set of inputs instead of choosing a few explicitly.  Surely showing that a method throws on null input once is just as good as showing it 10 time.


Add react-hook-form / mantine use-form for the filters panel

Is your feature request related to a problem? Please describe.
Currently this repository doesn't use react-hook-form or Mantine use-form  and each value grab from the state.
Describe the solution you'd like
Need to add one of above form handling solution
Additional context
See the contributing guide.

Hey @dipiash, I would like to work on this issue, Please assign it to me...

Hi, @Malay-dev!
Done it. You are welcome.

Thank you @dipiash... It was a great experience working with you... Thank you for your guidance... :innocent:

@Malay-dev you are welcome?


[sbt 0.13] Consider backporting withXXX methods for ModuleID and Artifact

steps

Cross build plugins.

problem
Using sbt 0.13.16-M1, plugins can now be cross built between 0.13 and 1.0.
One pattern that comes up is the lack of .copy(..) methods.
ModuleID came up a few times. https://github.com/sbt/sbt-pgp/pull/100/commits/d1bfc03931a873c27bea79f4b1b43f044210e688
expectation
For ModuleID and Artifact it might make sense to "backport" the withXXX methods so we can keep source compat. It would require change to plugin code, but it's still better than rolling out shim yourself.
notes
The shim looks this btw:
// for sbt 0.13
def subExplicitArtifacts(m: ModuleID, artifacts: Vector[Artifact]): ModuleID =
  m.copy(explicitArtifacts = artifacts)

// for sbt 1.0.0-M5
def subExplicitArtifacts(m: ModuleID, artifacts: Vector[Artifact]): ModuleID =
  m.withExplicitArtifacts(artifacts)

I agree this is a good idea. It's great ROI and low risk.


[BugFix] Fix broker load start time

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

LoadStartTime is set after pending task finished now,in actual execution
Before load, the task will also be blocked in the waiting queue, so a more reasonable LoadStartTime should be the moment when the actual execution starts
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

[FE PR Coverage Check]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/load/loadv2/LoadJob.java
1
1
100.00%
[]

run starrocks_admit_test

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/load/loadv2/LoadJob.java
1
1
100.00%
[]

@mergify backport branch-2.4 branch-2.3


Support for Cloud Tasks?

Do you have any plans of adding support for the Cloud Tasks service? In that case, when could that be expected?

@johkin Can you please provide more details on what kind of support for Cloud Tasks you have in mind? Are you using Spring Batch, Spring Cloud Stream, or Spring Cloud Task?

Sorry, didn't think of the ambiguity. I'm interested in using GCP Cloud Tasks (https://cloud.google.com/tasks/).
I guess the implementation could be somewhat similar to PubSub?

We also have several integrations for Pub/Sub. I guess the more basic one would be CloudTasksTemplate and the Spring Integration channel adapter built on top of that.


Revise test expectations

Issue Number
#1238
Overview

0a19dd650666ba3ca53b3e76da7d92a117fa0802
Remove expectations:

expectFieldEqual
expectFieldNotEqual
expectListItemFieldEqual
expectFieldBetween
expectListItemFieldBetween

074544e3b09d27bb51dd1917e626146988951e3c
Add expectations:

expectCliFieldSatisfy
expectCliListItemFieldSatisfy

and remove:

expectCliFieldBetween
expectCliFieldEqual
expectCliFieldNotEqual
expectCliListItemFieldBetween
expectCliListItemFieldEqual

7cf0c88575b8367c78ac0f9709dba9625544fb57
Use eventually_ to remove:

expectEventually
expectEventually'
expectEventuallyL

2b2c51dc3a4775d88033c6e97d2c4c73f90bf332
Rename expect.. methods to make them more concise

Comments

bors try

bors r+


Add SequentialRunner

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (bff56e2) 100.00% compared to head (8f8e796) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #349   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          310       311    +1
  Lines         9895      9913   +18
  Branches       955       957    +2
=========================================
+ Hits          9895      9913   +18

Files Changed
Coverage Δ

src/gravitorch/runners/__init__.py
100.00% <100.00%> (ø)

src/gravitorch/runners/sequential.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add inline structure definitions for MEM_EXTENDED_PARAMETER2

This is useful when adding mimalloc with add_subdirectory in another project that targets an older SDK version.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mrexodia sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks so much! I am hesitant to include such large definitions though.. what I did instead is make the MEM_EXTENDED_PARAMETER* a void* in the API definition; the actual call is behind an #ifdef so this should make it compile on older SDK's as well (just never called, but that's ok :-)).
It is commit #8ca79b5  -- let me know if that works for you. Best, Daan

Hi, thanks for the quick reply! Unfortunately this would mean that the VirtualAlloc optimization is not used when running under Windows 10. I’m just targeting Windows 8.1 because the build server is for Visual Studio 2015, the final executable is still run under Windows 10 most of the times...

Ah, I see! Yes, that is true ... and the new API is actually measurably faster...  feeling quite hesitant though about adding all those definitions. I need to think about it more. Perhaps it is best to skip that call alltogether and use the same optimization that I now use on Linux using allocation in the 4TiB+ address space for large aligned allocations.

Maybe add some asserts if the Windows original struct is present that the
sizeof() and enum values are the same... Also I checked the commit and saw
that you didn’t change the usage of the new API. Perhaps I didn’t see it
right though.
On Mon, 12 Aug 2019 at 18:14, Daan<EMAIL_ADDRESS>wrote:

Ah, I see! Yes, that is true ... and the new API is actually measurably
faster... feeling quite hesitant though about adding all those definitions.
I need to think about it more. Perhaps it is best to skip that call
alltogether and use the same optimization that I now use on Linux using
allocation in the 4TiB+ address space for large aligned allocations.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/mimalloc/pull/127?email_source=notifications&email_token=AASYFGOF4RQNZ4HMPKGJBALQEGD6NA5CNFSM4ILBZ5EKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4DBHSI#issuecomment-520491977,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASYFGKKWYNUYG6K4SMZVZTQEGD6NANCNFSM4ILBZ5EA
.

I didn't change the usage but since it is behind an #ifdef it will not be used when compiled with an older SDK.
Another option would be to simplify the struct definition to be just enough for the VirtualAlloc2 call to reduce the clutter...

I mean, it's what, 50 lines of struct definition? You could probably remove some of the enum cases, but it's not that big of an overhead to be honest.


Skeleton compilation

Compilation needs to:

Assign monotonically increasing integer identifiers to bones in a deterministic manner. A bone ID changing is a breaking change for any meshes that have been preprocessed for that skeleton.
Check that the tree of bones is acyclic and that all bones except the root have exactly one parent.

Compiled skeleton definitions need to either be stored, or they need to be generated completely deterministically (which implies that the input definitions also need to be generated deterministically). Mesh preprocessing depends on them (#3).

Specifically, mesh preprocessing depends on the integer IDs.


Friendly user feedback of indicator results

e.g. "This indicator is positive for over x% of contracting processes. These likely include false positives. Please review the configuration of the indicator."

Restoring priority (meant to prioritize #26) – though it can perhaps be closed easily once #26 is done.


Enables -Xlint:rawtypes

Except for Spark and Flink runners and the microbenchmarks module.

R: @dhalperi

I'm sure you've seen this does not pass yet :)

Yeah. I give up because the generated Avro code contains warnings (until they release https://github.com/apache/avro/pull/124 and we update avro plugin) and I couldn't find a way to suppress them, nor to tell javac to omit this warning for that file, nor even to make javac use different parameters to compile tests than to compile the main code.
I'd rather resume after Avro gets fixed.

OK, I decided to change this PR to simply reduce the number of these warnings, but not upgrade them to errors, in order to reduce future work when we find a way to cleanly make this an error.

LGTM


[Fix #7029] Make Style/Attr not flag offense for custom attr method

Closes #7029

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

I'm OK with the proposed fix, although I really think it's generally a bad idea to define methods with such names (at they might confuse people). I guess most of the time it happens as people simply don't know they exist.

Ping :-)

The JRuby failures look unrelated to this change.

@tejasbubane For some reason I can't rebase this from the GitHub UI. Can you rebase it again and ping me to merge it?

@bbatsov Rebased.

Thanks!


fixed

Hi,
I have solved this issue given below!
#9141
#9132
#8982
#7902
#9045

Why:
Closes #9142 #9143 #9045 #8982 #9141

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[x] I have added the 'writer impact' label
[x] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@dhivyadharshin This seems to be opened accidentally, I am going to close it now :yellow_heart: Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you have any questions :sparkles:

Thanks!
On Thu, 19 Aug 2021, 5:17 pm Ramya Parimi, @.***> wrote:

Closed #9142 https://github.com/github/docs/pull/9142.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/9142#event-5180168443, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ARSLAGSG4KQRYZ5PIDNHBO3T5TVLPANCNFSM5CNIDRHQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


What is the difference between docker/scripts/dev_start.sh and docker/scripts/release_start.sh in Apollo r3.0

It is strongly recommended that you switch to the new version, version 3.0 will no longer be maintained.


Stop Service Instances

Hi @jbonnet
We need to include a STOP instance method in the Gatekeeper API. For test purposes, I'm using:
POST /records/services/a4711437-10ce-3e06-845f-3710909184df
where a4711437-10ce-3e06-845f-3710909184df is the service instance uuid
DELETE is not valid because we won't delete the instance, only will change the status when the service is unprovisioned.
PUT may be possible but, as this method is used for update the instances, we should include a new data field showing the action required (update/stop/...)

Thanks, @srodriguezOPT
Actually, STOPping a service instance is updating its status to STOPPED, right?
So I suggest using PATCH /records/services/:service_instance_uuid/stop.
What do you think?
p.s.: of course we could have also a command such as .../instantiate, but that was not what we've implemented...

Yes,
PATCH /records/services/:service_instance_uuid/stop
seems the best option

Great! 👍
@tsoenen we've got our external API defined for stopping a service... now, what should be called next?

Hi guys
The gatekeeper shoud send a message on the service.instance.terminate topic. The payload of this message should be a yaml encoded dictionary with one key value pair. The key is 'instance_id' and the value is the uuid of the service that you want to terminate.
If the termination was succesfull, the GK will receive a response. The payload of the response is also a yaml encoded dictionary, with 'status' as one of the keys. If the value is 'READY', then the termination was succesfull. If the value is 'ERROR', then the termination failed, and their will be an 'error' key in the dictionary. The value of the 'error' key will contain a string with a description of the error.

Perfect, @tsoenen, we've got this designed...
Any expected timeline for having this ready?

From the SLM side, it should be ready (except for some standard integration hiccups).
Just ping me whenever you have questions/need assistance

@tsoenen
So the GK will pass the SLM the NSD/VNFDs of the service that is supposed to be stopped

@jbonnet
Correct, as wel as the instance_id.
So the payload is identical as the one in the instantiation call, with the added 'instance_id' key.

@jbonnet : example of the payload
---
instance_id: 63595426-356c-4e4a-a61d-1573430fa8ee
nsd:
  uuid: 1c860791-68b1-422e-bfb0-5c1d21cae489
  descriptor_version: "2.0"
  vendor: "eu.sonata-nfv.service-descriptor"
  name: "sonata-demo-1"
  version: "0.1"
  author: "Felipe Vicens, Atos IT Solutions and Services Iberia"
  description: >
    "The network service descriptor for the SONATA demo,
     comprising a Virtual Traffic Classifier"
  network_functions:
    - vnf_id: "vnf_vtc"
      vnf_vendor: "eu.sonata-nfv"
      vnf_name: "vtc-vnf"
      vnf_version: "0.1"
    - vnf_id: "vnf_firewall"
      vnf_vendor: "eu.sonata-nfv"
      vnf_name: "fw-vnf"
      vnf_version: "0.1"
  connection_points:
    - id: "ns:mgmt"
      interface: "ipv4"
      type: "management"
    - id: "ns:input"
      interface: "ipv4"
      type: "external"
    - id: "ns:output"
      interface: "ipv4"
      type: "external"
  virtual_links:
    - id: "mgmt"
      connectivity_type: "E-LAN"
      connection_points_reference:
        - "vnf_vtc:mgmt"
        - "vnf_firewall:mgmt"
        - "ns:mgmt"
    - id: "input-2-fw"
      connectivity_type: "E-Line"
      connection_points_reference:
        - "ns:input"
        - "vnf_firewall:input"
    - id: "fw-2-vtc"
      connectivity_type: "E-Line"
      connection_points_reference:
        - "vnf_firewall:output"
        - "vnf_vtc:input"
    - id: "vtc-2-output"
      connectivity_type: "E-Line"
      connection_points_reference:
        - "vnf_vtc:output"
        - "ns:output"
  forwarding_graphs:
    - fg_id: "ns:fg01"
      number_of_endpoints: 2
      number_of_virtual_links: 3
      constituent_vnfs:
        - "vnf_vtc"
      network_forwarding_paths:
        - fp_id: "ns:fg01:fp01"
          policy: "none"
          connection_points:
            - connection_point_ref: "ns:input"
              position: 1
            - connection_point_ref: "vnf_firewall:input"
              position: 2
            - connection_point_ref: "vnf_firewall:output"
              position: 3
            - connection_point_ref: "vnf_vtc:input"
              position: 4
            - connection_point_ref: "vnf_vtc:output"
              position: 5
            - connection_point_ref: "ns:output"
              position: 6
vnfds:
  - descriptor_version: "vnfd-schema-01"
    uuid: 68ccb839-0d24-4026-8978-923f759bb40e
    vendor: "eu.sonata-nfv"
    name: "vtc-vnf"
    version: "0.1"
    author: "George Xilouris, NCSRD"
    description: >
      "Virtual traffic classifier (vTC) descriptor file. vTC uses ndpi library for the implementation of the vTC"
    virtual_deployment_units:
      - id: "vdu01"
        description: "VNFC for the dashboard and the time-series database"
        vm_image: "sonata-vtc"
        vm_image_format: "qcow2"
        resource_requirements:
          cpu:
            vcpus: 1
          memory:
            size: 2
            size_unit: "GB"
          storage:
            size: 20
            size_unit: "GB"
        monitoring_parameters:
          - name: "vm_cpu_perc"
            unit: "Percentage"
          - name: "vm_mem_pers"
            unit: "Percentage"
          - name: "vm_net_rx_MB"
            unit: "MB"
          - name: "vm_net_tx_MB"
            unit: "Mbps"
        connection_points:
          - id: "vdu01:eth0"
            interface: "ipv4"
            type: "management"
          - id: "vdu01:eth1"
            interface: "ipv4"
            type: "internal"
          - id: "vdu01:eth2"
            interface: "ipv4"
            type: "external"

    virtual_links:
      - id: "mgmt"
        connectivity_type: "E-LAN"
        connection_points_reference:
          - "vdu01:eth0"
          - "vnf:mgmt"
        dhcp: True
      - id: "input"
        connectivity_type: "E-Line"
        connection_points_reference:
          - "vdu01:eth1"
          - "vnf:input"
        dhcp: True
      - id: "output"
        connectivity_type: "E-Line"
        connection_points_reference:
          - "vdu01:eth2"
          - "vnf:output"
        dhcp: True

    connection_points:
    - id: "vnf:mgmt"
      interface: "ipv4"
      type: "management"
    - id: "vnf:input"
      interface: "ipv4"
      type: internal
    - id: "vnf:output"
      interface: "ipv4"
      type: external

    monitoring_rules:
      - name: "mon:rule:vm_cpu_perc"
        description: "Trigger events if CPU load is above 10 percent."
        duration: 10
        duration_unit: "s"
        condition: "vdu01:vm_cpu_perc > 10"
        notification:
          - name: "notification01"
            type: "rabbitmq_message"
      - name: "mon:rule:vm_mem_perc"
        description: "Trigger events if memory consumption is above 10 percent."
        duration: 10
        duration_unit: "s"
        condition: "vdu01:vm_mem_perc > 10"
        notification:
          - name: "notification02"
            type: "rabbitmq_message"
      - name: "mon:rule:rx"
        duration: 10
        duration_unit: "s"
        condition: "vdu01:vm_net_rx_MB > 10"
        notification:
          - name: "notification03"
            type: "rabbitmq_message"
      - name: "mon:rule:tx"
        duration: 10
        duration_unit: "s"
        condition: "vdu01:vm_net_tx_MB > 10"
        notification:
          - name: "notification04"
            type: "rabbitmq_message"
  - descriptor_version: "vnfd-schema-02"
    uuid: c45a87c8-ebbb-45ca-bf3a-821f64bb0426
    vendor: "eu.sonata-nfv"
    name: "fw-vnf"
    version: "0.1"
    author: "Steven Van Rossem, Ghent University<EMAIL_ADDRESS>    description: "A firewall based on Ryu Openflow controller + openvswitch (2 ports: input+output) in a single VNF"
    virtual_deployment_units:
      - id: "1"
        vm_image: "sonata-vfw"
        vm_image_format: "qcow2"
        resource_requirements:
          cpu:
            vcpus: 2
          memory:
            size: 4
            size_unit: "GB"
          storage:
            size: 40
            size_unit: "GB"
        connection_points:
          - id: "vdu01:eth0"
            interface: "ipv4"
            type: "management"
          - id: "vdu01:eth1"
            interface: "ipv4"
            type: "internal"
          - id: "vdu01:eth2"
            interface: "ipv4"
            type: "internal"
    virtual_links:
      - id: "mgmt"
        connectivity_type: "E-LAN"
        connection_points_reference:
          - "vdu01:eth0"
          - "mgmt"
      - id: "input"
        connectivity_type: "E-Line"
        connection_points_reference:
          - "vdu01:eth1"
          - "vnf:input"
      - id: "output"
        connectivity_type: "E-Line"
        connection_points_reference:
          - "vdu01:eth2"
          - "vnf:output"
    connection_points:
      - id: "vnf:mgmt"
        interface: "ipv4"
        type: "management"
      - id: "vnf:input"
        interface: "ipv4"
        type: "internal"
      - id: "vnf:output"
        interface: "ipv4"
        type: "internal"

Hi, @srodriguezOPT, @tsoenen
I've noticed only now that we have been mentioning and endpoint like .../records/services/:uuid/stop, while this is more like an instantiation request, that is, .../requests/:uuid/stop.
Is it (mainly to @srodriguezOPT) hard to change that endpoint call?

Hi @jbonnet. For my understanding we have a resource (the record that
store the information related with the managed object(a service in this
case)) and a request (a type of order that perform some task over the
managed object). I agree that we are not performing only a change
status, so we need to create a request.  In the request we should
include a concept of item and action to define the type of operation
that we need to perform. So the invocation would be a new
../requests/item(:uuid and action=stop), where uuid would be the service
uuid and stop a defined action over the item.
We need to evaluate the impact of the change.
Regards
El 18/07/2017 a las 11:44, José Bonnet escribió:

Hi, @srodriguezOPT https://github.com/srodriguezopt, @tsoenen
https://github.com/tsoenen
I've noticed only now that we have been mentioning and endpoint like
|.../records/services/:uuid/stop|, while this is more like an
instantiation request, that is, |.../requests/:uuid/stop|.
Is it (mainly to @srodriguezOPT https://github.com/srodriguezopt)
hard to change that endpoint call?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sonata-nfv/son-gkeeper/issues/743#issuecomment-316013349,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AP6dsPIjt7vktKNi96uB6k8MleWfxsrGks5sPH6QgaJpZM4OJNcC.

--
Xosé Ramón Sousa Vázquez | OSS/BSS Principal Architect
R&D Manager
T/ + 34 986 410 091 (ext) 206 | M/ +34 675 550 029
www.optaresolutions.com
http://www.optaresolutions.com
Optare Solutions http://optaresolutions.com

Of course, @xrsousa-optaresolutions
Please note that there is already a request_type field, which in this case could be TERMINATION ...

The impact is not very high. We need the definition of the data that we
need to include and the URL where I will send the post.
Maybe:
URL: /requests
Post data:
{"request_type":"TERMINATION","service_uuid":serviceId}
It could be interesting also the returning type to evaluate the
availability of the request.
Regards
El 18/07/2017 a las 14:22, José Bonnet escribió:

Of course, @xrsousa-optaresolutions
https://github.com/xrsousa-optaresolutions
Please note that there is already a |request_type| field, which in
this case could be |TERMINATION| ...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sonata-nfv/son-gkeeper/issues/743#issuecomment-316047194,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AP6dsNSYsaV-i50MDkNEB4jzoDNHD5uUks5sPKN6gaJpZM4OJNcC.

--
Xosé Ramón Sousa Vázquez | OSS/BSS Principal Architect
R&D Manager
T/ + 34 986 410 091 (ext) 206 | M/ +34 675 550 029
www.optaresolutions.com
http://www.optaresolutions.com
Optare Solutions http://optaresolutions.com

First iteration with PR #775

Hi, please I need a clarification on the way that we need to invoke the GK for stop a instance.
From the code I have seen that the stop proces will be launched with this URL:
PATCH /requests/:service_instance_uuid/stop
We can accomplish that, but in this URL the resource used is not a request, it is an id for other object(service_instance). We can work on that but maybe would be better if we put the service_instance_uuid, the request_type of action requested (TERMINATION) and other information (like requesting timestamp or resource_type to be used with services or VNF or other staff) in a JSON structure that could be sent in a POST call for create a new request resource for stopping purposes.
POST /requests data{resource_type:service instance_id:service_instance_uuid,request_type:TERMINATION,timestamp:....}
Please let me know which is the final option.
Regards

Hi, @xrsousa-optaresolutions (cc @srodriguezOPT ),
Sorry for not having answered before...
Can we have this standardised? I mean, the BSS would always POST to the /requests endpoint, with the body of the request having

request_type, with possible values being CREATE (default, if not present) or TERMINATE;
service_uuid,  for the CREATE request_type or the empty for the TERMINATE
service_instance_uuid,  for the TERMINATE request_type or the empty for the CREATE

So, the current request would continue to work, without request_type (defaults to CREATE) and service_uuid in the body of the request, with POST to the /requests endpoint. The TERMINATE request would also be a POST to the /requests endpoint, but with a body with request_type=TERMINATE and service_instance_uuid with the instance of the service to be stopped.
What do you think?

Hi, @xrsousa-optaresolutions (cc @srodriguezOPT )
Are you ok with this proposed interface?

Thank you for your response. This could be enough for a first aproximation.
Thinking on a more open interface we could define the request
only as a business
interaction(state,requestDate,priority,cancellationDate, containingRequests
links, dependantRequests links, dueDate,completionDate) with one ore more
items where each item contains a service or an instance, a desired
action(Create,delete,stop,healing....) and a SLA for that action.
We can work on the first option now and take a time for analyze the
extended option.
Regards
El 24 jul. 2017 11:30 a. m., "José Bonnet"<EMAIL_ADDRESS>escribió:
Hi, @xrsousa-optaresolutions https://github.com/xrsousa-optaresolutions
(cc @srodriguezOPT https://github.com/srodriguezopt ),
Sorry for not having answered before...
Can we have this standardised? I mean, the BSS would always POST to the
/requests endpoint, with the body of the request having

request_type, with possible values being CREATE (default, if not
present) or TERMINATE;
service_uuid, for the CREATE request_type or the empty for the
TERMINATE
service_instance_uuid, for the TERMINATE request_type or the empty for
the CREATE

So, the current request would continue to work, without request_type
(defaults to CREATE) and service_uuid in the body of the request, with POST
to the /requests endpoint. The TERMINATE request would also be a POST to
the /requests endpoint, but with a body with request_type=TERMINATE and
service_instance_uuid with the instance of the service to be stopped.
What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sonata-nfv/son-gkeeper/issues/743#issuecomment-317369048,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AP6dsLR5BLxWfkHpWC6cmedaiRS3trhWks5sRGQsgaJpZM4OJNcC
.

@xrsousa-optaresolutions POST .../requests with request_type=TERMINATE (and service_instance_uuid passed) seems to be working...
Closed by PR #811


own vioplot function with beta kernel

added, in commit 26c450db but needs to apply range of values to kernel before plotting.


option to add 'expires' on either fields

handy for TTL http://mongoosejs.com/docs/api.html#schematype_SchemaType-expires

This seems it would be a useful addition.


[doc] Use related path for img

Use related path in our docs for imgs, previous
can not use because website need the absolute path
from root directory, and after we merged
apache/dolphinscheduler-website#789 we have covert
function to do that
close: #9426

Codecov Report

Merging #10325 (7ea8fc0) into dev (3f2a212) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev   #10325   +/-   ##
=========================================
  Coverage     40.46%   40.46%
  Complexity     4781     4781
=========================================
  Files           868      868
  Lines         35298    35298
  Branches       3930     3930
=========================================
  Hits          14284    14284
  Misses        19587    19587
  Partials       1427     1427

Impacted Files
Coverage Δ

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
83.60% <0.00%> (+1.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2a212...7ea8fc0. Read the comment docs.

PTAL @QuakeWang

I add milestones to 3.0.0-alpha which will be directly release from dev branch


add auth to api

https://geekflare.com/securing-flask-api-with-jwt/

auth useless since the API is plain javascript client-side and the key will be eposed.

try maybe asking the user for the password before accessing the page


SW-2751 Use 4px width on all scrollbars in web-app

as per Hannah's request
test in vercel
also pick up scroll bar changes mentioned here https://terraformation.atlassian.net/browse/SW-2504 towards the end

@hannah-cai it's a little harder now to scroll, but not sure if this is a problem since I always use pad or mouse to scroll:
Before:

Now:

@hannah-cai it's a little harder for me to scroll now, but not sure if this is a problem since I always use pad or mouse to scroll:
Before:
Now:

hmm that's a good point, I always use a trackpad so I didn't think about that. maybe we push it for now and then see if we get any user feedback about it

@hannah-cai it's a little harder for me to scroll now, but not sure if this is a problem since I always use pad or mouse to scroll:
Before:
    [

        ![before](https://user-images.githubusercontent.com/5919083/213557365-f4b4e57f-b9bc-4f33-984b-7a7c2d1f0494.gif)

    ](https://user-images.githubusercontent.com/5919083/213557365-f4b4e57f-b9bc-4f33-984b-7a7c2d1f0494.gif)

      [

      ](https://user-images.githubusercontent.com/5919083/213557365-f4b4e57f-b9bc-4f33-984b-7a7c2d1f0494.gif)

   [ ![before](https://user-images.githubusercontent.com/5919083/213557365-f4b4e57f-b9bc-4f33-984b-7a7c2d1f0494.gif) ](https://user-images.githubusercontent.com/5919083/213557365-f4b4e57f-b9bc-4f33-984b-7a7c2d1f0494.gif)

    [

        ![before](https://user-images.githubusercontent.com/5919083/213557365-f4b4e57f-b9bc-4f33-984b-7a7c2d1f0494.gif)

    ](https://user-images.githubusercontent.com/5919083/213557365-f4b4e57f-b9bc-4f33-984b-7a7c2d1f0494.gif)

      [

      ](https://user-images.githubusercontent.com/5919083/213557365-f4b4e57f-b9bc-4f33-984b-7a7c2d1f0494.gif)

   [ ](https://user-images.githubusercontent.com/5919083/213557365-f4b4e57f-b9bc-4f33-984b-7a7c2d1f0494.gif)

Now:
    [

        ![now](https://user-images.githubusercontent.com/5919083/213557395-db0eae02-8d4b-47b7-b7f1-5868d51e1ade.gif)

    ](https://user-images.githubusercontent.com/5919083/213557395-db0eae02-8d4b-47b7-b7f1-5868d51e1ade.gif)

      [

      ](https://user-images.githubusercontent.com/5919083/213557395-db0eae02-8d4b-47b7-b7f1-5868d51e1ade.gif)

   [ ![now](https://user-images.githubusercontent.com/5919083/213557395-db0eae02-8d4b-47b7-b7f1-5868d51e1ade.gif) ](https://user-images.githubusercontent.com/5919083/213557395-db0eae02-8d4b-47b7-b7f1-5868d51e1ade.gif)

    [

        ![now](https://user-images.githubusercontent.com/5919083/213557395-db0eae02-8d4b-47b7-b7f1-5868d51e1ade.gif)

    ](https://user-images.githubusercontent.com/5919083/213557395-db0eae02-8d4b-47b7-b7f1-5868d51e1ade.gif)

      [

      ](https://user-images.githubusercontent.com/5919083/213557395-db0eae02-8d4b-47b7-b7f1-5868d51e1ade.gif)

   [ ](https://user-images.githubusercontent.com/5919083/213557395-db0eae02-8d4b-47b7-b7f1-5868d51e1ade.gif)

hmm that's a good point, I always use a trackpad so I didn't think about that. maybe we push it for now and then see if we get any user feedback about it

sounds good 👍

@hannah-cai did you check the left nav scroll bar cut-off fix as well?

@karthikbtf the size change looks good! is the color change in a separate branch? (I'd made a jira task here, maybe I should've tagged you since it seems like you missed it)

@hannah-cai did you check the left nav scroll bar cut-off fix as well?

it looks good as well! :)

@karthikbtf the size change looks good! is the color change in a separate branch? (I'd made a jira task here, maybe I should've tagged you since it seems like you missed it)

ugh, yes i wasn't aware of that jira.. let me see if i can get that in here, it's a change in web-components.

@karthikbtf the size change looks good! is the color change in a separate branch? (I'd made a jira task here, maybe I should've tagged you since it seems like you missed it)

ugh, yes i wasn't aware of that jira.. let me see if i can get that in here, it's a change in web-components.

can you approve this one? https://github.com/terraware/web-components/pull/260
once that lands, i will update the current PR with the updated web-components version

@karthikbtf the size change looks good! is the color change in a separate branch? (I'd made a jira task here, maybe I should've tagged you since it seems like you missed it)

ugh, yes i wasn't aware of that jira.. let me see if i can get that in here, it's a change in web-components.

can you approve this one? terraware/web-components#260 once that lands, i will update the current PR with the updated web-components version

Ok, the color fix has been applied. Will get this in for now, if anything need further updates - will do that separate from this PR.


Sort literature descending/ascending

Several users have been asking for a way to sort the literature results with the least recent papers at the top. This ordering is sometimes required when producing lists of papers. Additionally, the sort should be stable, so the results shouldn't change ordering based on the shard receiving the request or on the index order when remapping (so _doc shouldn't be used). We need to

add a new option to the sort order dropdown named Least recent which performs the same ordering as Most recent but in the opposite order
make sure the search is always stable for the records-hep index (for all sort orders), easiest solution is probably adding _id (not sure it's possible) or control_number as a tie-breaker.

@michamos we don't understand the reason of the tie-breaker, they will not be any issue in records-hep index to sort by  earliest_date

Tech notes
In records config add option:

leastrecent - sort by earliest date

@michamos we don't understand the reason of the tie-breaker, they will not be any issue in records-hep index to sort by earliest_date

There can be issues if two different records share the same earliest_date, then the ordering is "random" (depends on which shard the search is performed on, which is controlled by the preference value set to some hash of user IP and user agent by invenio), so it's not stable.

Least recent should be the second option, right after Most recent.

@michamos Here's the PR for it https://github.com/inspirehep/inspirehep/pull/2338


Building bindings to bootloader_support component

Adds the includes from the bootloader_support component and builds them by default. My main interest is access to the bootloader_random.h methods detailed in the Random Number Generation system API's. I thought it could be useful to add the rest of the bootloader support component while I was there.
I've tried to keep this inline with similar changes but it is my first contribution here, sorry if I've missed any conventions.

Hm, something is NOK with the includes of this PR. Check the CI build output.

Rebasing on the new release. I've taken a look at the CI workflows and am not getting the same Clippy errors locally while building on Windows. I will try to replicate the environment as closely as possible in a Linux container to see if I can get the same errors as we encountered on CI.

The conflicting generated definition only appears in the pio build:
#[repr(C)]
#[derive(Debug, Copy, Clone)]
pub struct ets_secure_boot_signature_t {
    _unused: [u8; 0],
}

Both the pio and native builds contain:
pub type ets_secure_boot_signature_t = ets_secure_boot_signature;

Which I believe is generated from the corresponding target-specific rom/secure_boot.h, e.g esp32c3/rom/secure_boot.h:
typedef struct ets_secure_boot_signature ets_secure_boot_signature_t;

The CI job for both native and pio use --target riscv32imc-esp-espidf, so I'm not sure where the difference is coming from. The only target I see that does not define ets_secure_boot_signature_t as a typedef is esp32:
/* Multiple key block support */
typedef struct {
    ets_secure_boot_sig_block_t block[SECURE_BOOT_MAX_APPENDED_SIGN_BLOCKS_TO_IMAGE];
    uint8_t _padding[4096 - (sizeof(ets_secure_boot_sig_block_t) * SECURE_BOOT_MAX_APPENDED_SIGN_BLOCKS_TO_IMAGE)];
} ets_secure_boot_signature_t;

This should only be getting included if CONFIG_IDF_TARGET_ESP32 is set.

I've now included bootloader_common.h in the build. Do you need something else included?

I've now included bootloader_common.h in the build. Do you need something else included?

Could we include #include "bootloader_random.h"?


Is it possible to get types for .coffee files without adding .d.ts files adjacent to them?

First off, thank you for this extension! It is of great use to me overall.
In my simpler projects that have only one or two .coffee files I can easily access all the TypeScript types from imports and other shared locations. On my larger projects that have many .coffee files, some of which require others, they lose the types after the first layer.
Very basic example:
# src/jadelet.coffee
Jadelet = require "jadelet"

module.exports = Jadelet

This file works, all the types are available because the jadelet package exports the types.
Here is the problem...
# src/observable.coffee
{ Observable } = require "./jadelet"

module.exports = Observable

Cannot find module './jadelet' or its corresponding type declarations.CoffeeSense [TS](2307)

The module ./jadelet exists but TypeScript doesn't know about it. A work around is to create jadelet.d.ts files by manually compiling .coffee -> .js -> .d.ts but that seems excessive since all the data is "almost" there. Is it possible to tell TypeScript more directly that the types in these files exist?
With the JSDoc support .coffee files can pretty much export fully annotated types (especially after importing from ./typings/ etc.). Is there anything that can be done to let tsserver know that non-ts files could contain types?

I think all you need is to specify the file extension:
{ Observable } = require "./jadelet.coffee"

Autocompletion should even suggest this to you as it scans the available file paths.
Does this solve it for you?
Not sure if missing extensions can be achieved, I remotely remember that only jsx,tsx,js and ts can be implicitly imported and everything else needs explicit file extensions, maybe I am wrong though. CoffeeSense could probably also fix this

yeah custom file extensions are not allowed by typescript: https://github.com/microsoft/TypeScript/issues/10939 but the extension should fix this imo. I'll fix it some other day so that your code also works nicely.

Thanks for the fast response!
Adding the extension works though I would like the flexibility of not needing to specify it. That way I could have .ts or .coffee modules and not care about migrating from one to the other. It does seem that Node is general is moving towards explicit extensions but I prefer the 2014 aesthetics as I'm sure many other CoffeeScript hold outs do as well :)

This is now possible with version 1.9.0 (you need to check that VSCode updated the extension, it usually takes two reloads for that). Can you test this out and tell me if it now works as desired?

@phil294 It works!


fix: Adjust dependencies to fix unit tests

Needed to roll back @ngtools/webpack even further to 1.1.7 in order to fix the error:
TypeError: Cannot read property 'newLine' of undefined

Also needed to pin karma-remap-coverage to 0.1.2 as 0.1.3 in order to fix the error:
TypeError: remap is not a function

@bennett000

LGTM :shipit:


create heapster-controller failed

monitoring-heapster-controller-1g681         0/1       API error (404): Cannot start container 401801b72ef28b28f01bda500784d080b5dacfa6077c660e7b978b8ae7a5279a: [8] System error: exec: "/heapster": stat /heapster: no such file or directory
what's wrong??

What version of heapster are you using and what setup?
On Fri, Jul 31, 2015 at 2:39 AM, fzu-huang<EMAIL_ADDRESS>wrote:

monitoring-heapster-controller-1g681 0/1 API error (404): Cannot start
container 401801b72ef28b28f01bda500784d080b5dacfa6077c660e7b978b8ae7a5279a:
[8] System error: exec: "/heapster": stat /heapster: no such file or
directory
what's wrong??
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/heapster/issues/443.

version  0.17
i switch the version to 0.16 ，then when i create a  rc,  it is wrong  and log is :
I0803 08:35:28.200069       1 heapster.go:52] /heapster --source=kubernetes:https://kubernetes --sink=influxdb:http://monitoring-influxdb:80
I0803 08:35:28.200157       1 heapster.go:53] Heapster version 0.16.0
E0803 08:35:28.200587       1 heapster.go:59] open /var/run/secrets/kubernetes.io/serviceaccount/token: no such file or directory
should i  do something in kubernetes???

You need to setup service accounts while setting up the cluster. Refer to
kubernetes admin guides.
On Mon, Aug 3, 2015 at 1:42 AM, fzu-huang<EMAIL_ADDRESS>wrote:

version 0.17
i switch the version to 0.16 ，then when i create a rc, it is wrong and log
is :
I0803 08:35:28.200069 1 heapster.go:52] /heapster --source=kubernetes:
https://kubernetes --sink=influxdb:http://monitoring-influxdb:80
I0803 08:35:28.200157 1 heapster.go:53] Heapster version 0.16.0
E0803 08:35:28.200587 1 heapster.go:59] open /var/run/secrets/
kubernetes.io/serviceaccount/token: no such file or directory
should i do something in kubernetes???
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/heapster/issues/443#issuecomment-127165064
.

That should be referenced somewhere in the heapster config guide as service accounts are not a requirement for kubernetes.

@bh016088: https://github.com/kubernetes/heapster/blob/master/docs/source-configuration.md#kubernetes

Closing as obsolete. Try to use a new stable version of Heapster.


getPolyHeight(long ref, float[] pos)

I found that when using a large crowd that moves along the edge of the navigation mesh, that a spatial can be pushed off the mesh when it enters a triangle that is very small or where there are two triangles that share a single vertex and the angle between them forms a "V" where the space inside the "V" is off mesh.
It looks like this happens because the velocity of the spatial along with the distance left inside the navigation mesh triangle to travel is to small for a course correction to occur because the spatials following it are blocking its path. This eventually leads to it being left no place to go except off mesh which causes it to throw the exception in getPolyHeight(long ref, float[] pos).
This may never happen in game because unless you are moving an army of spatials there would not be enough spatials following to cause a problem.
Is it possible that when this exception happens, rather than throwing an exception, try to warp the spatial back onto the mesh at the nearest valid position and replan the path?
After the crowd passes it would have an open path.
I hope the explanation is clear.

If you spot a problem in the underlying algorithms that potentially affects the original library in C I really encourage you to post your findings here: https://groups.google.com/forum/#!forum/recastnavigation.  You can usually get help and learn about the known limitations or bugs in recast and detour quickly there. I try to keep the library as close to the original implementation as possible, so even if it were a bug I would rather wait for the upstream fix than try to come up with a recast4j-specific solution.
On the other hand, if this issue can only be reproduced with recast4j then definitely something was ported incorrectly and needs to be fixed here :)
Would you be able to test your scenario using detour-crowd in C ?

There is a JNI port of recast made for the engine I use but it was from 2014 and did not include anything other than mesh generation.
I don't know C++ or JNI enough to pull it off.
I can work around the problem by tweaking the mesh but hadn't thought about this being something in recast itself which is probably 100% correct.
Ill dig around and see what I find.
I can give you some parameters on how I implement this to let you duplicate the problem if you want.

Ok, I found this problem is caused by the Y position and wrote a fix for it.
https://groups.google.com/forum/#!msg/recastnavigation/idkwKdgChlA/l-7tT22UydYJ;context-place=forum/recastnavigation
When I examined movePosition in DetourPathCorridor.cpp it looks like to me he never expects dtStatusSucceed(status)) to return false or doesn't care if it does and if getPolyHeight()  returns DT_FAILURE | DT_INVALID_PARAM I don't see how that gets handled.
In you implementation you choose to throw a exception. I don't know why its expected to shutdown the game for this so this is my work around.
NavMeshQuery.java
I added a new m_posY[] array and in the getPolyHeight(long ref, float[] pos) method changed from a exception to warping the Y point back into the mesh.
 //		throw new IllegalArgumentException("Invalid ref " + ref + " pos " + Arrays.toString(pos));
                ClosesPointOnPolyResult closestPointOnPoly = closestPointOnPoly(ref, pos);
                vCopy(m_posY, closestPointOnPoly.getClosest());
                System.out.println(closestPointOnPoly.isPosOverPoly());
                return m_posY[1];

It works and so far I am not seeing anything adverse from it. If you see something that may lead to a problem or there is a cleaner or preferred way to handle this please let me know.

You do not need to shut down the application on the exception, simply catch it and perform some fallback action.
The original implementation (https://github.com/recastnavigation/recastnavigation/blob/master/Detour/Source/DetourNavMeshQuery.cpp#L654) currently does not return any value in case of DT_INVALID_PARAM. If your fix gets merged into the C++ lib I will happily merge it to recast4j as well, otherwise I prefer to remain consistent with what is in C++ code.
I am wondering why the status is not checked in DetourPathCorridor.cpp while it is checked in a few places in DetourNavMeshQuery.cpp. It might be a bug or an intentional omission. I guess we can change the movePosition method to catch and disregard the exception as long as there is no check in C++.

I prefer to remain consistent with what is in C++ code.

I agree completely with that approach and was only showing what I did to fix it.

why the status is not checked in DetourPathCorridor.cpp

I think the reason is no action needs to be taken.
I tested by catching the exception and applying my fix vs catching the exception and doing nothing and there is no adverse action either way. Calling closestPointOnPoly is just a waste of processing power IMO. In more than half to 3/4 the time it doesn't even change the results. When it does return something different, 99% of the time its not even above the mesh and the difference in position is so miniscule that's its not worth changing.
Heres a sample of the output to show how small a difference it made,
Invalid ref [-147.32025, 35.05475, -562.08984]
Above Poly false
Corrected ref [-147.32025, 35.05473, -562.08984] pos changed for: org.recast4j.detour.crowd.PathCorridor@79aaf718 5/5

This object had 5 failures in the end and returned a different position 5 times but look a Y pos and its to small to worry about.

I  guess we can change the movePosition method to catch and disregard the exception as long as there is no check in C++.

I think this is the best soloution,

Forgot to say, maybe notate in the exception to keep an eye on it for changes in c++ version?


Move comments from browser storage to app

Why:

Simplify eventual support for non-js clients (more work required)
Allow eventual comment recovery across devices (more work required)

Steps:

Use anonymous sessions to track users
Drop browser storage in favor of app storage
Model per-section comments in ORM
Add CRUD endpoint for comments

For the comment data model, I'm thinking about something like:
Comment (user, section, label, text)
Attachment (name, size, key, commentid)
Although we could also store the attachment list as a blob, since we may not need to query it directly.
Questions:

Is this in scope for the pilot?
Is it important to support non-js clients?
Any security issues?

Note: this would replace the proposal to store comment text on s3 that was discussed yesterday.
@vrajmohan @tadhg-ohiggins @xtine @cmc333333

IIANM, the comment is currently stored as Markdown in localStorage. Why does moving it to the app necessitating more structured storage? Can't we get away with:
user, markdown_comment, attachment_list_blob.

Quick notes on implementation:

Django has a easy-to-use session system that stores to the database (or memcached, etc.)
I'd punt on using explicit ORM models; we can pull from the session store (which acts like a dict) when it's needed
-site currently assumes no database is present. There'd be some (minor) config changes to make that work. As a bonus, test configuration wouldn't be so confusing

Re importance/scope: I think this is a high second priority. We required LocalStorage + JS initially due to records management concerns. Had they not been an issue, we would have built with a progressive enhancement bent (starting with the assumption of hard reloads, building up the relevant AJAX). Unfortunately, that's not our situation -- though we're less concerned about records management now, we have additional work to support non-JS.
I'd argue that, our priority should remain building a full app with our initial platform (modern, JS browsers with LocalStorage). However, we know that we want to support non-JS at some point in the future, hopefully before the end of this pilot, so when we write code to satisfy our primary goal (the JS app), we should be engineering them towards the secondary goal (the non-JS app). From my perspective, we shouldn't work on this unless we have finished critical-path tasks.

we know that we want to support non-JS at some point in the future

Just curious--how do we know? Is this a regulatory requirement? Do many current users have js disabled?

we shouldn't work on this unless we have finished critical-path tasks

Agreed! What are those?
@cmc333333: are you saying that we want to continue using browser storage? Now I'm thinking I misunderstood our conversation on slack earlier today.

Just curious--how do we know? Is this a regulatory requirement? Do many current users have js disabled?

Few webapps need JavaScript and there's nothing inherent to notice-and-comment that would appear to require it. Following the principles of progressive enhancement, webapps should provide a useable experience down to the point where the app is not longer useful. To give examples, if the webapp needs a slippy map, we need JS. If the webapp is just presenting content markup, there's zero reason to require JS.

What are those?

We chat about outstanding issues every few days, right? I'll post again in slack do prevent cluttering this issue.


Calc's automatic ":quiet" mode inside functions doesn't stack the previous value

So that ":quiet off" .. ":quiet pop" inside a function doesn't work (the "pop" does not restore quiet operation).

Took a bunch of refactoring to get this to work.


[Feature Request]: check the proposal state and do deposit or burn

Feature Request
Describe the Feature Request
https://github.com/starcoinorg/starcoin-framework/blob/08928d4db8c2603f6433476697d0fddd0aa759bd/sources/daospace/DAOSpace.move#L1674-L1677
if the proposal state is no_with_veto, we should burn the deposit Token.
Ensure the no_with_veto work as expected.
Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
Yes / No (Help can be provided if you need assistance submitting a PR)

https://github.com/starcoinorg/starcoin-framework/blob/08928d4db8c2603f6433476697d0fddd0aa759bd/sources/daospace/DAOSpace.move#L1639
在这里确定了只有 EXECUTABLE 的提案才能被执行提案，但当 no_with_veto 后，应添加状态为 DEFEATED 提案处理，并增加 状态为 DEFEATED 的提案 Burn Token
需要的改动：

增加 DEFEATED 提案处理
修改 take_proposal_action函数，增加 burn Token


Remove AppLink in favor of nonce+state

Updates Android auth to remove AppLink authentication in favor of the custom URI -based scheme defined in #2823

Adding @roop and @ReactorScram for example implementation
Adding @bmanifold for another set of eyes
Draft because we need associated changes in the portal and Apple clients to be shipped at the same time.

This is basically ready for review and merge since #2696 is done


generate same output as in yup generator

Problem
Hi, I have switched from yup to this generator, as I want universal validation, and prisma-graphql only supports class-validator. However, this generator only generates the base models.
Now it is not possible use any of the models in mutations as the validator checks every property, even though I am in partial update mode.
Example: With the yup generator I was simply able to pick the UserUpdateInput version to support partial updates.
Suggested solution
Generate all possible models from every resolver that prisma-graphql generates.

closing in favor of #9


Macro annotations

is it possible to expand an annotation macro (see http://docs.scala-lang.org/overviews/macros/annotations.html) currently with scalameta ?

Might be easier than it looks, because our syntactic APIs are already of really decent quality at the moment.

There's a prototype implementation published in https://github.com/scalameta/paradise. Let's continue the discussion there.


Constant name "tag_hash" doesn't conform to UPPER_CASE naming style

https://github.com/lbonanomi/gRist/blob/0bb7eceee04bd597966217117892ae3e98250892/grist.py#L27

Issues for naming style are now ignored.


Option to set default target branch of a new pull request

Feature Description
Good day!
Is there an option to set default target branch of a new pull request? I see BaseBranch variable in Merge Message templates but not a global option.
Feature request: to add it.
Thanks!
Screenshots
No response

What's the different between the default target branch and repository default branch?

Default target branch is a branch you're proposed to compare to, on New Pull Request page.
Repository default branch is a branch you've seen on the repository page.

I'm also looking for this. I think this could nicely be handled through pull request templates.
Particular use-case:
Would like to keep the default repository branch to be the most recent release branch, but all PRs should by default go into a development branch.


add kotlin support

I'm failed to send the report to Coveralls
got following log:
:coveralls
service name: travis-ci
service job id: 246121223
repo token: present (not shown for security)
No source file found on the project: "ForeverNight"
With coverage file: /home/travis/build/gogo81745/ForeverNightEngine/build/reports/jacoco/test/jacocoTestReport.xml

Finally, I know the reason is that my project use kotlin only
refer to this
project.plugins.withType(GroovyPlugin) {
	targetSrcDirs += project.sourceSets.main.groovy.srcDirs
}

project.plugins.withType(ScalaPlugin) {
	targetSrcDirs += project.sourceSets.main.scala.srcDirs
}

But there is no kotlin here. That's why the plugin find no source file
So I add an additional configuration
coveralls {
    project.extensions.coveralls.sourceDirs += project.sourceSets.main.kotlin.srcDirs
}

It's like this
coveralls {
    sourceDirs += ['src/main/kotlin']
}

It is working now.
I hope to add support for Kotlin.

PRs are welcome!

Sorry , I am not familiar with gradle and groovy
In fact , I just started using gradle
I don't know how to fix it 😅

This was duplicate of #63


[RFC][PASS][RUNTIME] Enable Slice on LHS during concat

This was mentioned in https://github.com/dmlc/tvm/issues/2122#issuecomment-439581161; I also asked about it here a while back.
Basically I'd like to implement a compiler pass that replaces concat operations with simple slicing operations, where:
out[0:1] = concat(f1(), f2())

is replaced with
out[0] = f1()
out[1] = f2()

This can provide large improvements in some cases, e.g. DenseNet, which goes from having O(n^2) memory copies to having O(n) memory copies. It also reduces memory requirements in low-memory deployment scenarios. It can be implemented by partially specializing compute kernels over data size.
I'd like to implement this pass (partly just to get more used to working inside TVM), but I'm not exactly sure where in the stack this should go. It's somewhat backend-dependent, and AFAICT Relay can't really represent slicing in this way (although I might be wrong). Maybe a pass can be added that annotates data-movement operations, and backends can consume those annotations?
A place to start might be just implementing this in the graph runtime. If someone could provide some guidance that would be helpful ( @tqchen ?)
cc @areusch

@kazimuth Probably you could write a Relay pass. Should be easy if it is intraprocedural.

AFAICT Relay can't really represent slicing in this way (although I might be wrong).

It's true.

Does it help to add a pass to analyze “buffers that should be allocated continuously”, and then hint the runtime to do this?

Does it help to add a pass to analyze “buffers that should be allocated continuously”, and then hint the runtime to do this?

I think this makes sense. How do I hint the runtime though? Should I just add a new Relay node / a field to one of the node types, or is there a more principled way to annotate a Relay AST?

The main obstacle is that relay is functional, which makes it hard to represent such kind of Rhs assignment.
What possibly need to happen is to have a special annotation in the relay IR and do special codegen in the runtime. It also requires us to enhance the runtime semantics, to allow specification of slice.

@tqchen Didn't get it why we need runtime codegen. In the case of intraprocedural opt, it would be fine to just hint the runtime to alloc contiguous memory and then skip concat operator

What I mean is that runtime need to be aware of the memory layout and provide out[slice] = f(inputs). Another possible "obstacle" is that TVM's compute kernel requires the buffer to be somewhat aligned, and we need to generate a special kernel for out[slice] = f(inputs), with a known offset(so we still benefit from good alignment). This is necessary for OpenCL

Shouldn't title be "Slice on LHS"?
Also @tqchen what's a good way to add that annotation?

I have not yet put very deep thoughts how can we generate annotation, this is something that worth some thoughts and discussion

Once you have liveness analysis, you could detect when some vars die on an instruction, while another var is created. Let call it substitution. To optimize concat, we could detect substitution on concat instruction, and extend the liveness of vars who previously die on this instruction.

I'm going to close this issue since there hasn't been any change in a couple years. Feel free to reopen if needed. The Discourse forum is a good place for questions like this too.


Remove button on cart has a grey background when in mobile view

Unable to reproduce or no longer an issue.
If still an issue please provide more detail: server, browser, device, orientation.

It's actually visible on mac/safari and I also saw it on windows/firefox (https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/3043)
Add a product to cart, then Go to cart page, for eg: http://dev-com-17.accdemo.b2c.ydev.hybris.com:4200/electronics-spa/en/USD/cart

This is getting fixed in GH-3598 as a test case

Tested with calydon enabled, on safari, chrome and firefox, desktop and mobile viewports.
Remove button no longer has a grey background.