[HOLD for payment 2023-10-09] [$500]  [Distance] - The toggle attribution options disappear when they are hovered

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open request money
Change the tab to distance
Click on toggle attribution on bottom right side of map
Hover over the toggle attribution options

Expected Result:
The toggle attribution options should not hide when they are hovered
Actual Result:
The toggle attribution options gets hidden when hovered on web and also hidden when clicked on mweb
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/5c051b8e-8107-4566-af53-857944045a9d
https://github.com/Expensify/App/assets/93399543/1974c22e-fe2f-483c-a992-2c37ae5e679d
https://github.com/Expensify/App/assets/93399543/e1e550b3-baca-4f81-b345-42b4cfa89185
Expensify/Expensify Issue URL:
Issue reported by: @jo-ui
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693917802357489
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ead96ebe1b100d51
Upwork Job ID:<PHONE_NUMBER>512796672
Last Price Increase: 2023-09-20
Automatic offers:

bernhardoj | Contributor | 26797717
jo-ui | Reporter | 26797720

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~014c9f9349470cd9cb

Hi @bojangabric @bernhardoj! Thank you both for your proposals and insights on this issue. In my opinion, the solution presented by @bernhardoj is the better one. I believe it's better to utilize existing styles rather than directly referencing the component classes if possible.
Selected Proposal: https://github.com/Expensify/App/issues/27863#issuecomment-1727900933
contributor: @bernhardoj
🎀 👀 🎀 C+ reviewed

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[X]  [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: It's not covered on original PR with implementation, so no particular PR introduce this behaviour
[X]  [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[X]  [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[X]  [@robertKozik] Determine if we should create a regression test for this bug. I don't think we need regression test for this as it's purely visual, one time, bug
[X]  [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

tldr; I don't think we need the regression tests for this issue - it's rather one-time change, and bug won't come back anymore

PAYMENT SUMMARY
The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉
@bernhardoj requires payment offer (Contributor) - PAID $500 + $250 URGENCY BONUS
@robertKozik does not require payment (Contractor) - OWED $500 + $250 URGENCY BONUS
@jo-ui requires payment offer (Reporter) PAID $50

@robertKozik please seek your payment from ND. This is now all complete from Upwork/GH.

@zanyrenney as a contractor (Software Mansion) I'm not eligible for payment


In Lookup, if user click on search button without select any keyword, then all data should be appeared at List section

It's done


SailingGameApplication Dependencies Invalid

SalingGameApplication is dependent on multiple concrete implementations of AStandardPanel. This breaks the dependency inversion principle and is harmful to the codebase. Currently the AStandardPanel class contains no methods and only two font attributes. I also see that two classes GameOverPanel and MainMenuPanel use buttons to some capacity. Maybe this functionality can be defined in an interface InteractablePanel? Nevertheless, I think it would benefit the code to find some common functionality or settings and define them in the AStandardPanel, at the very least as abstract methods. Therefore, AStandardPanel would have a reason to exist and SailingGameApplication can depend on it instead of the concrete classes.

Yes i kind of agree👍
AStandardPanel exists because the inheriting classes all share this code. Classes dont need methods to have a purpose.
'''Java
Dimension size = new Dimension(width, height);
this.setPreferredSize(size);
this.setMaximumSize(size);
this.setBackground(Color.GRAY);
this.bigFont = new Font("Arial", Font.PLAIN, 50);
this.smallFont = new Font("Arial", Font.PLAIN, 20);
'''
I dont think we need more abstraction here. The major problem is high coupling, this can be fixed by adding  the Standardpanels directly to the AppFrame and not add them through the application. The SailingGameApplication can then use the methods which are now in AApplication to interact with key components of the view. SailingGameApplication can depend on AppFrame since both are high level components.
Will probably be able to fix this tomorrow.

Fair, what I meant was that it was worth looking into if there is any common functionality that can be refactored into the AStandardPanel. However, I think that your plan sounds like a good idea.

I Turned this issue post into a user story


Add sample_weight and sample_weight_eval_set

Is this on the path towards compatibility with xgboost 1.0?

No, just some extra kwargs that need to be passed down. This is needed to support versions xgboost < 1.0 that need to scale.

This looks fine at a glance. I'm tempted to just ignore the CI failures unless @gforsyth is actively working on them and somewhat close to fixing it? At least the new tests aren't failing.

Thanks @TomAugspurger I believe he is, but I'm gonna poke at some CI stuff here as well.

Just need to add sample_weight to the regressor and double check the docs strings then this will be ready for another look.

Ready for another look.

Thanks @mmccarty


Adding numerical jacobian for the AUTOBK process

@newville
Current xraylarch has a bottleneck on the AUTOBK process and the main reason is because of the very slow calculation of the Jacobian in the FITPACK. It is not an elegant solution, but I succeeded in implementing an analytical gradient in the xraytsubaki which gave x3-4 times performant code.
I attached the profiling of the numerical and analytical gradient done in the xraytsubaki below.
https://github.com/Ameyanagi/xraytsubaki/blob/main/doc/profiling.md
I can implement the same logic to xraylarch, but I have one problem that scipy leastsq doesn't accept custom Jacobian. we need to switch to least-square which is a newer interface. is there any problem with switching the fitpack wrapper?
and should i try implementing the analytical Jacobian to xraylarch?
The two main codes are the following.
https://github.com/Ameyanagi/xraytsubaki/blob/main/src/xafs/background.rs#L689
https://github.com/Ameyanagi/xraytsubaki/blob/main/src/xafs/mathutils.rs#L386

@Ameyanagi That's all really interesting and worth pursuing.
I probably would have done a couple of things. First, I might try switching from using lmfit to plain scipy.optimize.leastsq. That could have some impact, but probably not a factor of 2.  But, for autobk, we are not using any of the lmfit features.  Second, I might play with the tolerances and epsfcn values to see if the number of iterations can be reduced.
scipy.optimize.leastsq can take an analytic Jacobian - its Dfun argument.   And, sure, if derivatives can be done analytically, it is worth pursuing.
FWIW, I would not expect least-squares to be faster than leastsq.  But I think that switching between the two would not be a big effort compared to implementing the Jacobian in the first place.

@newville
I just realized that I misunderstood the arguments for leastsq. It has a Dfun argument that can pass in the Jacobian.
I will first try this argument and implement the analytical Jacobian.

@Ameyanagi I just pushed some changes for autobk that give a speedup of close to 2x.
Switching to plain scipy.optimize.leastsq gives maybe a 50% increase, which seemed worth doing.
I also changed to have calc_uncertainties=False to not calculate the arrays for delta_chi(k) and delta_bkg(E) for every run of autobk.  This process is sort of slow, so was moved to a separate function (autobk_delta_chi) that can now be called for that for a group that has had autobk run.    Initializing a Feffit Dataset will call that function if needed.
There was also a small improvement to be made in checking for duplicate energies in remove_dups().
For me, these give almost a factor of 2.  That should put running autobk at around 10 milliseconds on many modern-ish laptops.  I am not aware of anyone collecting 1,000 spectra in a minute at any sustained rate.  If someone is looking to collect data at that rate, they are going to have to consider processing and storage.   A 10-node machine could process 1000 spectra per second.    I kind of think we're optimized enough for a generation ;).

@newville
Thank you for the nice changes. I was working on implementing analytical Jacobian, but so far, I am not getting a significant speed up. It is probably because I need to rewrite the core functions of the FITPACK in Python, which has so many for loops, that the slow down we get with the for loops is larger than the increase we get from the analytical Jacobian.
I can technically write the Jacobian with a compiled language and expose an API, but I think it would be a bad idea in terms of maintaining.
I think we cannot optimize furthermore at this point.
BTW, python will remove the GIL, which prevents us from running multithread codes, maybe we could make the autobk_par to speed up the heavy loading of the AUTOBK process.

@Ameyanagi Yes, I sort of think that analytic derivatives here would be hard to maintain, even if it was shown to be a significant speed-up.
I think removing the GIL will be good in general, but probably not for Autobk (at least in the short term). Basically, non-thread-safe Fortran code is repeatedly calling a Python code to get a residual array and using that for the minimization.  Most of the numerical work is in Fortran, even if the runtime is dominated by calling that one Python objective function (that is also computationally bound by fitpack, and so not I/O bound).  The GIL won't help in that situation.
What could help would be to re-do the LM solver (say, using C) to be thread-safe and to then call the Python objective function in parallel (Nvary times, each in its own C thread and CPU core) when calculating numerical derivatives.   A main process would launch Nvary threads, wait for them to finish, create the Jacobian, use that to predict the next step, and repeat until stable.  That could dramatically speed up all fits with more than 2 or 3 parameters.
I think that the thread-safe solver in C does exist (https://github.com/devernay/cminpack), but having a main C loop that calls the user-supplied Python objective function in parallel threads and then assembles the results would be real work. ;)
But also, I really believe that 0.01 s for Autobk is fast enough for the next decade.   Splitting jobs across 10 cores gives you 1000 spectra processed per second.  When that is too slow, going to 50 faster CPUs could get you another order of magnitude.
FWIW, I'm in the process of adding "autobk-style background" to Feffit.

@newville
I agree that it might not be good in terms of thread safety for autobk. I think it is better to keep the current code.
One of the reasons I was working on Rust was because there is a concept of "fearless concurrency," which makes it very easy to write a thread-safe code and parallelize it.
I will close this issue.

@Ameyanagi  Just to be clear, I don't mean that using analytic Jacobians causes thread safety.  It's sort of worse than that:  MINPACK / lmdif / scipy.optimize.leastsq are not thread-safe.  They are single-thread.
One could imagine building the finite-difference Jacobian by doing Nvarys simultaneous calculations.  In C (not Fortran), and with thread safety in mind (and this does exist now!).  That could distribute most of the function calls to up to Nvarys threads/CPU cores, which could easily give 5 to 10x speedups.
For that to be able to call objective functions in Python is another problem. You either have to work hard for picklability (that's unlikely for lmfit with constraints, but might work for autobk), or you have to go multi-interpreter -  or maybe the new sub-interpreters could work.
This would be real work - but also might be possible (which I might have been less optimistic about in the past).  And it has the potential of really speeding up all Python fits by 5 to 10x.


[DPE-4573] Update MySQL to v8.0.39

Issue
We have a new multiarch rock for charmed-mysql v8.0.39
Solution
Update version

@dragomirp how does your renovate updates dependency.json on PostgreSQL?

It doesn't.


running "npm install" in home directory produces error

I get the following output when trying to run "npm install" in the react-slick directory:
><EMAIL_ADDRESS>install /Users/paulme/Google Drive/Development/Awfbeat/MVM/dev_website/react/node/mvm-react-radium/node_modules/react-slick/node_modules/sass-loader/node_modules/node-sass
> node scripts/install.js

Binary downloaded and installed at /Users/paulme/Google Drive/Development/Awfbeat/MVM/dev_website/react/node/mvm-react-radium/node_modules/react-slick/node_modules/sass-loader/node_modules/node-sass/vendor/darwin-x64/binding.node

><EMAIL_ADDRESS>postinstall /Users/paulme/Google Drive/Development/Awfbeat/MVM/dev_website/react/node/mvm-react-radium/node_modules/react-slick/node_modules/sass-loader/node_modules/node-sass
> node scripts/build.js

`darwin-x64` exists; testing
module.js:355
  Module._extensions[extension](this, filename);
                               ^
Error: Module did not self-register.
    at Error (native)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/paulme/Google Drive/Development/Awfbeat/MVM/dev_website/react/node/mvm-react-radium/node_modules/react-slick/node_modules/sass-loader/node_modules/node-sass/lib/index.js:181:15)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
npm ERR! Darwin 14.3.0
npm ERR! argv "node" "/usr/local/bin/npm" "install"
npm ERR! node v0.12.1
npm ERR! npm  v2.7.5
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>postinstall: `node scripts/build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'node scripts/build.js'.
npm ERR! This is most likely a problem with the node-sass package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node scripts/build.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls node-sass
npm ERR! There is likely additional logging output above.

I clonned this repo freshly, and ran npm install
It worked fine for me.  Can you check if there is anything wrong with your setup

I tried it again. I directly cloned the project as well as downloaded the zip. Both times when I run "npm install" from the root folder I get the following output:
Pauls-MacBook-Pro:react-slick paulme$ npm install
npm WARN package.json Dependency 'object-assign' exists in both dependencies and devDependencies, using<EMAIL_ADDRESS>from dependencies
npm WARN peerDependencies The peer dependency react included from react-slick will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN deprecated<EMAIL_ADDRESS>Use npmjs.org/del instead, see https://github.com/gulpjs/gulp/blob/master/docs/recipes/delete-files-folder.md
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":"~0.8 || ~0.10"} (current: {"node":"0.12.1","npm":"2.7.5"})
npm WARN peerDependencies The peer dependency babel-core@* included from babel-loader will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency<EMAIL_ADDRESS>included from react-router will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
/
><EMAIL_ADDRESS>install /Users/paulme/Google Drive/Development/Awfbeat/react-slick/node_modules/karma/node_modules/chokidar/node_modules/fsevents
> node-gyp rebuild

  SOLINK_MODULE(target) Release/.node
  SOLINK_MODULE(target) Release/.node: Finished
  CXX(target) Release/obj.target/fse/fsevents.o
  SOLINK_MODULE(target) Release/fse.node
  SOLINK_MODULE(target) Release/fse.node: Finished

><EMAIL_ADDRESS>install /Users/paulme/Google Drive/Development/Awfbeat/react-slick/node_modules/webpack-dev-server/node_modules/socket.io/node_modules/engine.io/node_modules/ws
> (node-gyp rebuild 2> builderror.log) || (exit 0)

  CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
  SOLINK_MODULE(target) Release/bufferutil.node
  SOLINK_MODULE(target) Release/bufferutil.node: Finished
  CXX(target) Release/obj.target/validation/src/validation.o
  SOLINK_MODULE(target) Release/validation.node
  SOLINK_MODULE(target) Release/validation.node: Finished

><EMAIL_ADDRESS>install /Users/paulme/Google Drive/Development/Awfbeat/react-slick/node_modules/webpack/node_modules/watchpack/node_modules/chokidar/node_modules/fsevents
> node-gyp rebuild

  SOLINK_MODULE(target) Release/.node
  SOLINK_MODULE(target) Release/.node: Finished
  CXX(target) Release/obj.target/fse/fsevents.o
  SOLINK_MODULE(target) Release/fse.node
  SOLINK_MODULE(target) Release/fse.node: Finished

><EMAIL_ADDRESS>install /Users/paulme/Google Drive/Development/Awfbeat/react-slick/node_modules/webpack-dev-server/node_modules/socket.io-client/node_modules/engine.io-client/node_modules/ws
> (node-gyp rebuild 2> builderror.log) || (exit 0)

  CXX(target) Release/obj.target/bufferutil/src/bufferutil.o

><EMAIL_ADDRESS>install /Users/paulme/Google Drive/Development/Awfbeat/react-slick/node_modules/karma/node_modules/socket.io/node_modules/socket.io-client/node_modules/ws
> (node-gyp rebuild 2> builderror.log) || (exit 0)

  CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
  SOLINK_MODULE(target) Release/bufferutil.node
  SOLINK_MODULE(target) Release/bufferutil.node: Finished
  CXX(target) Release/obj.target/validation/src/validation.o
  SOLINK_MODULE(target) Release/validation.node
  SOLINK_MODULE(target) Release/validation.node: Finished
-
><EMAIL_ADDRESS>install /Users/paulme/Google Drive/Development/Awfbeat/react-slick/node_modules/sass-loader/node_modules/node-sass
> node scripts/install.js

Binary downloaded and installed at /Users/paulme/Google Drive/Development/Awfbeat/react-slick/node_modules/sass-loader/node_modules/node-sass/vendor/darwin-x64/binding.node

><EMAIL_ADDRESS>postinstall /Users/paulme/Google Drive/Development/Awfbeat/react-slick/node_modules/sass-loader/node_modules/node-sass
> node scripts/build.js

`darwin-x64` exists; testing
module.js:355
  Module._extensions[extension](this, filename);
                               ^
Error: Module did not self-register.
    at Error (native)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/paulme/Google Drive/Development/Awfbeat/react-slick/node_modules/sass-loader/node_modules/node-sass/lib/index.js:181:15)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
npm ERR! Darwin 14.3.0
npm ERR! argv "node" "/usr/local/bin/npm" "install"
npm ERR! node v0.12.1
npm ERR! npm  v2.7.5
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>postinstall: `node scripts/build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'node scripts/build.js'.
npm ERR! This is most likely a problem with the node-sass package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node scripts/build.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls node-sass
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/paulme/Google Drive/Development/Awfbeat/react-slick/npm-debug.log

@paulwehner This is the problem with node-sass
Updating its version fixed the problem


Refactor DB generics

Simplify code by moving the creating of query
directly in the db repositories and use generics
only to execute the queries

@alegacy, I believe this will simplify a lot the code. By moving the build of the query in the db repositories, we can easily construct more complex queries with many records. It looks cleaner. Please have a look

@alegacy, I believe this will simplify a lot the code. By moving the build of the query in the db repositories, we can easily construct more complex queries with many records. It looks cleaner. Please have a look

Let's discuss next week.  I must be missing something because this seems to have moved what was a relatively manageable set of generic functions back out to the repository and duplicates the logical in dozens of places.
If any particular use cases needed a more complex query there was nothing stopping us from doing that on a case-by-case basis.  Having the typical Find/Create/Delete cases handled generically seemed like a better approach short of using a proper ORM to do the heavy lifting.

@alegacy, I believe this will simplify a lot the code. By moving the build of the query in the db repositories, we can easily construct more complex queries with many records. It looks cleaner. Please have a look

Let's discuss next week. I must be missing something because this seems to have moved what was a relatively manageable set of generic functions back out to the repository and duplicates the logical in dozens of places.
If any particular use cases needed a more complex query there was nothing stopping us from doing that on a case-by-case basis. Having the typical Find/Create/Delete cases handled generically seemed like a better approach short of using a proper ORM to do the heavy lifting.

As we discussed internally, my main concerned was that it seemed we were maintaining a library here. There was no clear convention of what was a basic generic operation. I didn't want us in the future to continue adding arguments to fulfill all needs. For instance, if someone needed more flexibility with the upsert operations (which might be very complex itself) or add support for bulk operations with Insert or Update.
I do understand your point about repeating code. Although, I believe it was ok in this case.
So, as discussed, I left the basic crud operations and emphasized that Insert and Update are for a single record. I cleaned up a bit. I removed the generic functions for upsert. The queries for upsert are now built in the repo file. I also introduced 2 generic functions to execute queries which are used by the existing crud operations and can be used outside to run more complex queries.
Please have a look again, @alegacy


Adding homepage

Addressing issue #14:
Successfully developed home page, fitted with images of each member that links to their respective profiles

Looks great to me! If Noah is is good then I'd say we can merge


Raise exception if MTLCommandBuffer fails

Sometimes MTLCommandBuffer fails silently and just doesn't update output Buffer, which is quite bad. There's multiple issues that lead to metal flakiness, this is one of them.
Fixes https://discord.com/channels/1068976834382925865/1069001075828469790/1189831398975094804

Good find!
Exception is a generic class, RuntimeError is probably a better choice.
Is there any way to test that this exception triggers.

Good find!

I'm sure there is a lot more places where error checks are missing, so pls don't merge yet - will add them tomorrow
At least one exists for sure in GPU backend.

Exception is a generic class, RuntimeError is probably a better choice.

I'm new to python, fixed.

Is there any way to test that this exception triggers.

# https://discord.com/channels/1068976834382925865/1069001075828469790/1189831398975094804
from tinygrad import Tensor

# force a long loop in subsequent kernels. seems to start failing at ~1e6 for me but gets consistent as we increase
N = int(1e8) + 1
ones = Tensor.ones((N,)).contiguous()

a = ones.mean().item()
print(f"{a=}") # ends up being 0.0 on gpu backends... possible silent metal fail?

intermediate = Tensor(3.14159).item() # eval any tensor with same shape
print(f"{intermediate=}")

b = ones.mean().item()
print(f"{b=}") # gets same val as intermediate when LRUAllocator is enabled

assert a == b

Sometimes (+- 1 in 10) fails on my 32gb m1 max, i guess it's running out of ram or something:
(.venv) [user@macbook ~/src/tinygrad]% python fun2.py
a=0.16777215898036957
intermediate=3.141590118408203
Traceback (most recent call last):
  File "/Users/user/src/tinygrad/fun2.py", line 13, in <module>
    b = ones.mean().item()
        ^^^^^^^^^^^^^^^^^^
  File "/Users/user/src/tinygrad/tinygrad/tensor.py", line 168, in item
    return self._data().cast(self.dtype.fmt)[0]
           ^^^^^^^^^^^^
  File "/Users/user/src/tinygrad/tinygrad/tensor.py", line 159, in _data
    return cast(Buffer, t.cast(t.dtype.scalar()).contiguous().realize().lazydata.base.realized).as_buffer()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/user/src/tinygrad/tinygrad/device.py", line 95, in as_buffer
    return self.copyout(memoryview(bytearray(self.size*self.dtype.itemsize)))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/user/src/tinygrad/tinygrad/device.py", line 104, in copyout
    self.allocator.copyout(mv, self._buf)
  File "/Users/user/src/tinygrad/tinygrad/runtime/ops_metal.py", line 81, in copyout
    def copyout(self, dest:memoryview, src:Any): dest[:] = self.as_buffer(src)
                                                           ^^^^^^^^^^^^^^^^^^^
  File "/Users/user/src/tinygrad/tinygrad/runtime/ops_metal.py", line 78, in as_buffer
    self.device.synchronize()
  File "/Users/user/src/tinygrad/tinygrad/runtime/ops_metal.py", line 96, in synchronize
    raise RuntimeError(error)
RuntimeError: Error Domain=MTLCommandBufferErrorDomain Code=1 "Internal Error (0000000e:Internal Error)" UserInfo={NSLocalizedDescription=Internal Error (0000000e:Internal Error), NSUnderlyingError=0x116e22690 {Error Domain=IOGPUCommandQueueErrorDomain Code=14 "(null)"}}

Ready to merge, will make separate PR for GPU backend

Maybe add this check to metal graph as well?

Maybe add this check to metal graph as well?

Added, thanks


x509write_csr: Reduce stack usage of mbedtls_x509write_csr_pem()

Using 4096 bytes of stack for the temporary buffer used for holding a
DER-formatted CSR limits the portability of generating certificate
signing requests to only devices with lots of stack space. Use the heap
to provide the temporary buffer instead, to increase portability. PEM
format is desirable to use even on stack-constrained devices as the
format is easy to work with (for example, copy-pasting from a tiny
device's serial console output, for CSRs generated on tiny devices
without the private key leaving said tiny device).
Status
IN DEVELOPMENT
Requires Backporting
NO
Migrations
NO
Additional comments
Any additional information that could be of interest
Todos

[X] Tests
~[ ] Documentation~
~[ ] Changelog updated~
~[ ] Backported~

The new version of the patch makes use of the in-place feature I didn't know existed, based on assumptions from reading the previous implementation (which created a temporary buffer to avoid in-place operation).


Cursor jumps to top of tree after deletion

VSCode Version:

Version: 1.45.0-insider
Commit: a250df703de955a38aed427a917bce8278ab3331
Date: 2020-04-24T20:46:59.782Z
Electron: 7.2.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0

OS Version:

Steps to Reproduce:

Create a tree of directories
Delete the last directory

After deletion, I expected the cursor to move to the item above the deleted item but it actually jumps to the top of the tree.
The other cut, paste, open, rename, and navigation features work wonderfully. It's just this one that can hamper using the UI move files around using the keyboard and not the mouse.
https://youtu.be/53vfAH_6bsk

Does this issue occur when all extensions are disabled?: Yes

Dup of https://github.com/microsoft/vscode/issues/71315


[Exposure Request] [DE] report 11003 "Customer Total-Balance" - protected variables

Reference to the old issues marked as complete:
https://github.com/microsoft/ALAppExtensions/issues/20628
Not included in the Build ID 51464 (Update 3 for BC 2022 Wave 2)
Please set variables PeriodEndBalance and EndBalanceType to protected in report 11003 "Customer Total-Balance" - german localization.
protected var
    PeriodEndBalance: Decimal;
    EndBalanceType: Option " ",Debit,Credit;

This is fixed in v.22


devs_quick_start documentation needs update

Description
The devs_quick_start documentation needs an update as to the commands. Also, the structure of the document currently does not give a best overview as to the environment they have to set this up in.
Known issues

Commands for running move tests dont work. They need to be corrected.
Commands for giving permission to diem-node fails.
Commands for running e2e smoke tests fail.

Solution
Re-structure this document first by introducing the tools needed for a developer to work on this project. Second, basic installation setup. Update to any commands that do not work as expected.

@sasuke0787 Could you resend these changes in a PR rebased from main?


Implement issue (and possibly) PR templates

Github has supported Issue and PR templates since over 2 years. It is quite nice to be able to create a new issue and already have a template pre-filled for other open-source projects.
It would be nice to implement one for lagoon, here's a few examples: awesome-github-templates

Creating an issue template for your repository
Creating a pull request template for your repository

https://github.com/amazeeio/lagoon/pull/455

Approved @dasrecht


Android debug app crashes silently

Definition
Silent crash: the app crashes without a dialog box or this dialog box disapears as soon as it appears
Problem
After a small change to the JS code related to React Native Navigation, the Android app began crashing "silently" as soon as I opened it. The problem is not related to RNN since the code I changed couldn't have been executed when the app just started.
Because the error didn't make sense when it started appearing, I thought of some kind of corrupted cache and:

Restarted Metro
Cleared the app data
Re-built and re-installed the app
Uninstalled the app, rebooted android, rebuilt and reinstalled it
...nothing worked

As a last resort, I installed the app on another phone that never had the app installed on it before and everything magically worked. My own phone is still unable to run my app.
After a little adb logcat | grep my.package.name, here's what I got when the app crashes:
07-07 17:15:38.076 21958 21958 D SoLoader: Preparing SO source: com.facebook.soloader.ApkSoSource[root = /data/data/my.package.name/lib-main flags = 1]
07-07 17:15:38.079 21958 21958 V fb-UnpackingSoSource: locked dso store /data/user/0/my.package.name/lib-main
07-07 17:15:38.082 21958 21958 I fb-UnpackingSoSource: dso store is up-to-date: /data/user/0/my.package.name/lib-main
07-07 17:15:38.082 21958 21958 V fb-UnpackingSoSource: releasing dso store lock for /data/user/0/my.package.name/lib-main
07-07 17:15:38.147 21958 21982 I FA      :   adb shell setprop debug.firebase.analytics.app my.package.name
07-07 17:15:38.181 21958 21997 E AndroidRuntime: Process: my.package.name, PID: 21958
07-07 17:15:38.182 21958 21996 E AndroidRuntime: Process: my.package.name, PID: 21958
07-07 17:15:38.195  3855  5223 I ActivityManager: Process my.package.name (pid 21958) has died: fore TOP
07-07 17:15:38.209  3855  5223 I ActivityManager: Start proc 22002:my.package.name/u0a367 for activity my.package.name/.MainActivity
07-07 17:15:38.408 22002 22002 D SoLoader: adding application source: com.facebook.soloader.DirectorySoSource[root = /data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/lib/arm64 flags = 0]
07-07 17:15:38.408 22002 22002 D SoLoader: adding backup source from : com.facebook.soloader.ApkSoSource[root = /data/data/my.package.name/lib-main flags = 1]
07-07 17:15:38.409 22002 22002 D SoLoader: Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/lib/arm64 flags = 0]
07-07 17:15:38.409 22002 22002 D SoLoader: Preparing SO source: com.facebook.soloader.ApkSoSource[root = /data/data/my.package.name/lib-main flags = 1]
07-07 17:15:38.410 22002 22002 V fb-UnpackingSoSource: locked dso store /data/user/0/my.package.name/lib-main
07-07 17:15:38.414 22002 22002 I fb-UnpackingSoSource: dso store is up-to-date: /data/user/0/my.package.name/lib-main
07-07 17:15:38.414 22002 22002 V fb-UnpackingSoSource: releasing dso store lock for /data/user/0/my.package.name/lib-main
07-07 17:15:38.484 22002 22027 I FA      :   adb shell setprop debug.firebase.analytics.app my.package.name
07-07 17:15:38.504 22002 22039 E AndroidRuntime: Process: my.package.name, PID: 22002
07-07 17:15:38.509 22002 22041 E AndroidRuntime: Process: my.package.name, PID: 22002
07-07 17:15:38.524  3855  5223 I ActivityManager: Process my.package.name (pid 22002) has died: fore TOP
07-07 17:15:38.536  3855  5223 I ActivityManager: Start proc 22044:my.package.name/u0a367 for activity my.package.name/.MainActivity
07-07 17:15:38.730 22044 22044 D SoLoader: adding application source: com.facebook.soloader.DirectorySoSource[root = /data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/lib/arm64 flags = 0]
07-07 17:15:38.730 22044 22044 D SoLoader: adding backup source from : com.facebook.soloader.ApkSoSource[root = /data/data/my.package.name/lib-main flags = 1]
07-07 17:15:38.731 22044 22044 D SoLoader: Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/lib/arm64 flags = 0]
07-07 17:15:38.731 22044 22044 D SoLoader: Preparing SO source: com.facebook.soloader.ApkSoSource[root = /data/data/my.package.name/lib-main flags = 1]
07-07 17:15:38.733 22044 22044 V fb-UnpackingSoSource: locked dso store /data/user/0/my.package.name/lib-main
07-07 17:15:38.736 22044 22044 I fb-UnpackingSoSource: dso store is up-to-date: /data/user/0/my.package.name/lib-main
07-07 17:15:38.736 22044 22044 V fb-UnpackingSoSource: releasing dso store lock for /data/user/0/my.package.name/lib-main
07-07 17:15:38.793 22044 22069 I FA      :   adb shell setprop debug.firebase.analytics.app my.package.name
07-07 17:15:38.835 22044 22083 E AndroidRuntime: Process: my.package.name, PID: 22044
07-07 17:15:38.836 22044 22082 E AndroidRuntime: Process: my.package.name, PID: 22044
07-07 17:15:38.848  3855  5223 I ActivityManager: Process my.package.name (pid 22044) has died: fore TOP
07-07 17:15:38.860  3855  5223 I ActivityManager: Start proc 22088:my.package.name/u0a367 for activity my.package.name/.MainActivity
07-07 17:15:39.074 22088 22088 D SoLoader: adding application source: com.facebook.soloader.DirectorySoSource[root = /data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/lib/arm64 flags = 0]
07-07 17:15:39.075 22088 22088 D SoLoader: adding backup source from : com.facebook.soloader.ApkSoSource[root = /data/data/my.package.name/lib-main flags = 1]
07-07 17:15:39.076 22088 22088 D SoLoader: Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/lib/arm64 flags = 0]
07-07 17:15:39.076 22088 22088 D SoLoader: Preparing SO source: com.facebook.soloader.ApkSoSource[root = /data/data/my.package.name/lib-main flags = 1]
07-07 17:15:39.077 22088 22088 V fb-UnpackingSoSource: locked dso store /data/user/0/my.package.name/lib-main
07-07 17:15:39.083 22088 22088 I fb-UnpackingSoSource: dso store is up-to-date: /data/user/0/my.package.name/lib-main
07-07 17:15:39.083 22088 22088 V fb-UnpackingSoSource: releasing dso store lock for /data/user/0/my.package.name/lib-main
07-07 17:15:39.175 22088 22125 E AndroidRuntime: Process: my.package.name, PID: 22088
07-07 17:15:39.175 22088 22126 E AndroidRuntime: Process: my.package.name, PID: 22088
07-07 17:15:39.179 22088 22112 I FA      :   adb shell setprop debug.firebase.analytics.app my.package.name
07-07 17:15:39.187  3855  5223 W ActivityManager:   Force finishing activity my.package.name/.MainActivity
07-07 17:15:39.198  3855  3870 I ActivityManager: Showing crash dialog for package my.package.name u0
07-07 17:15:39.211  3855  4675 W ActivityManager: Process my.package.name has crashed too many times: killing!
07-07 17:15:39.218  3855  4675 E ActivityManager: Found activity ActivityRecord{b3116d u0 my.package.name/.MainActivity t-1 f} in proc activity list using null instead of expected ProcessRecord{be5514d 22088:my.package.name/u0a367}
07-07 17:15:39.223 22088 22088 I zygote64: Caused by: java.lang.ClassNotFoundException: Didn't find class "android.view.View$OnUnhandledKeyEventListener" on path: DexPathList[[zip file "/data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/base.apk"],nativeLibraryDirectories=[/data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/lib/arm64, /data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/base.apk!/lib/arm64-v8a, /system/lib64, /system/vendor/lib64]]
07-07 17:15:39.225 22088 22088 I zygote64: Caused by: java.lang.ClassNotFoundException: Didn't find class "android.view.View$OnUnhandledKeyEventListener" on path: DexPathList[[zip file "/data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/base.apk"],nativeLibraryDirectories=[/data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/lib/arm64, /data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/base.apk!/lib/arm64-v8a, /system/lib64, /system/vendor/lib64]]
07-07 17:15:39.226 22088 22088 I zygote64: Caused by: java.lang.ClassNotFoundException: Didn't find class "android.view.View$OnUnhandledKeyEventListener" on path: DexPathList[[zip file "/data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/base.apk"],nativeLibraryDirectories=[/data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/lib/arm64, /data/app/my.package.name-FkwuY8sK8vetr99xNOCwZw==/base.apk!/lib/arm64-v8a, /system/lib64, /system/vendor/lib64]]
07-07 17:15:39.266  3855  4675 I ActivityManager: Killing 22088:my.package.name/u0a367 (adj 199): crash
07-07 17:15:39.279  3855  5223 W ActivityManager: Ignoring remove of inactive process: ProcessRecord{be5514d 0:my.package.name/u0a367}

Basically, the app crashes a few times (I've stripped the beggining) and android kills it.
I have quite a bit of native android development knowledge, but this seems to be too much in React Native's territory for me.
Summary
The debug build of my app crashes only on my phone after no real change in the code. The logcat isn't really meaningful and I didn't find any workaround.
I'm also not 100% percent sure that the problem only comes from React Native.
Edit: I completeley removed RNFirebase as well as the Google Play Services gradle plugin and the native Firebase dependency, and I still had the crash.  I'll continue removing dependencies, but RNN has so much setup involved that I'll probably start a new project.
Versions

Native module
Version

React Native
0.59.8

react-native-firebase
^5.3.1

react-native-navigation
^2.21.0

react-native-vector-icons
^6.4.2

@react-native-community/async-storage
^1.4.2

info Fetching system and libraries information...
  System:
    OS: Linux 4.15 Linux Mint 19 (Tara)
    CPU: (4) x64 Intel(R) Core(TM) i5-4200M CPU @ 2.50GHz
    Memory: 133.50 MB / 7.71 GB
    Shell: 2.7.1 - /usr/bin/fish
  Binaries:
    Node: 8.10.0 - /usr/bin/node
    npm: 6.9.2 - /usr/local/bin/npm
  npmPackages:
    react: 16.8.6 => 16.8.6
    react-native: 0.60.0 => 0.60.0
  npmGlobalPackages:
    react-native-cli: 2.0.1

Steps To Reproduce
Unfortunately, the problem doesn't look reproductible as my experiments have shown. If the logcat isn't sufficient, you might not be able to help me, which is understandable. If you need more data however, I'll be happy to provide it.
:warning: Important update
I created a completely new development environment after a failed upgrade (requested by the bot).
I reinstalled the librairies slowly, testing every time I added a few of them. When all the librairies where installed (and automatically linked, thanks to v0.60) and I hadn't copied all my JS code yet, I started the metro server (with still the react-native init template's JS).
I started the app, my phone being unplugged and entered my local IP address and port in the dev settings of the app, as I always did. I pressed OK on the dialog box, pressed the back button of the dev settings Activity and it crashed instantly.
Now, I am back at the start, even though I'm in another environment. The only things that are the same are the librairies & the package name. I'll try to remove librairies one by one to see if something works again, but the whole problem is probably not related to react-native as I initially thought. I'll edit as soon as I have more info.

I don't know what I did wrong in the first experiment, but the problem definitely comes from RNFirebase, and removing it solves everything.
It is not available for v0.60 however, so I'll have to forget about notifications for now... I probably shouldn't have updated my project in the first place, but it's too late.
I'll post any updates here in case I'm not the only one having this issue.

any update @edgarogh ? I'm having same issue after init the project and just link with RNFirebase

Well, I updated RN to 0.60 and AFAIK RNFirebase is still not available for this version due to the changes in the linking system, so I can't even try. The commit related to that has been merged but I don't think it was published. I started patching it with patch-package but went in vacation before I finished.
Regarding the older version of RN, where I had this problem, I haven't found a fix and will probably not go back anyways. If you haven't done it, you could open an issue on RNFirebase's Github project, maybe linking to this one (and I'll do it myself), this might be more useful.
From my research, the bug is not really common and it doesn't look like it happens on the official Firebase lib in native Android development, so it must be linked with RNFirebase. Ideally we should try to isolate the part of the library that causes the crash by slowly adding and removing compilation steps from the complex setup, but I can't do that right now.
Hope you'll find your answers, and I hope everything will work for me in React Native 0.60

I had the same situation, the crash came out of nowhere and I couldn't get rid of it. What finally helped was this:
(cd android && ./gradlew clean)
Maybe it will save someone's time in the future

two easy steps solved my problem...

open android studio and remove offline bundle from src/main/assest..(** if any)
open MainApplication.java and remove the following import..
import com.facebook.react.BuildConfig

@GIRIRAJNAGAR768 thanks, you save my life

two easy steps solved my problem...

open android studio and remove offline bundle from src/main/assest..(** if any)
open MainApplication.java and remove the following import..
import com.facebook.react.BuildConfig

Thank you soooooooooooo much

@GIRIRAJNAGAR768 Thank you really helpfull bro

@GIRIRAJNAGAR768 thank you man, i love you ❤

@GIRIRAJNAGAR768 Thank you man, you save my time!! 🔥


Minor update style

@superyyrrzz,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@superyyrrzz : Thanks for your contribution to the Azure documentation! The author, @harelbr, has been notified to review your proposed change.

@harelbr Can you help merge this PR?


Paged Content doesn't display Openseadragon on remote installs

There's a hard coded reference to localhost:8000 in the Openseadragon block configuration: https://github.com/Islandora/islandora_defaults/blob/8.x-1.x/config/install/context.context.openseadragon_block.yml#L30
Because of this, the openseadragon block can't request the manifest in order to render, so it's being skipped :(  localhost:80 would probabaly work, but we need that 8000 for vagrant.  So we need to find a way to set that properly when provisioning a remote system.

@mjordan No, we were able to fix it with a simple config update unrelated to CORS.

Bumping into this again with ISLE and https://github.com/Islandora-Devops/isle-buildkit/issues/20
We really should make this accept relative paths as well.  If it doesn't get a full url, then attempt to construct one with the provided path.  That way you can pass this config around between sites without worrying about changing the host name all the time.

....and fixed.    If that gets merged, I'll update islandora_defaults appropriately.


QueryBuilder exists() does not respect query scope

Laravel Version: 5.8.36
PHP Version: 7.3.10
Database Driver & Version:
mysql 5.7.28

Description:
query builder exists() method does not respect global scope
Steps To Reproduce:
We have a Spark integration with a global scope on all major entities that limits their access by team_id
So that querying User::all() would only return those with a role on the current team.
However when I query User::exists($id) the result is true, but when I call User::find($id) the result is null because of scope.

exists() doesn't accept any parameters.
Use one of these queries:
User::where('id', $id)->exists();
User::whereKey($id)->exists();

Thank you!

I can explicitly call applyScopes() on the query, before exists(), but that's silly:
Level::query()->where([
  'country_id' => 234,
])->applyScopes()->exists()


Farlight 84 sig scan offsets broken

Farlight 84 ObjObjects offset signature is broken with latest game update v15.1.2
These two signatures both work from v15 to the latest patch of the game  v15.1.2 if anyone else is having problem u can update the signature using one of these:
Ida Sig ObjectsPtr = "2A 7D ? 13 ? ? ? 12 08 01 09 4B 29 ? ? ? 1F 20 03 D5 29 ? ? ? 29 ? ? F8";
ObjectsPtr += 0xC;

Ida Sig ObjectsPtr = "29 3D 10 12 08 01 09 4B ? ? ? ? 29 D9 6A F8 08 25 3A 9B 08 ? ? 39 88 ? ? 37";
ObjectsPtr += 0x8;

Thanks, I have uploaded new release with this fix.


Why 0.0.1, not 1.0.0?

Is the API intended to change?

nope just published it before the whole publish a v 1 first was cleared up

published 1.0.0 =) thanks!

Thanks @soldair !


Fix Readme

min: Boolean — preserving aspect ratio, resize the image to be as small as possible while ensuring its dimensions are greater than or equal to the width and height specified.
This part of the readme is missing a default value for the min option.
Cheers!
Edit: also, what happens if both min and max are defined?
Edit 2: I noticed there are links to the sharp documentation, but they are broken 😟 there is a pull request with the fixes! Please accept it 😄

Hello!
First off, thanks a lot for making this package in the first place.
As for the ask above, I would remove the following:
If you are using Mac OS then before installing `gulp-responsive` you should install the libvips library

sharp will install its own version of libvips in your system, at leason on macOS.
By manually installing libvips ourselves, we pulled version 8.9.0. If that is present, sharp's installation process breaks because it is expecting version 8.8.1.
Furthermore, to install the latest version of sharp, you need to be on node 12.*.
Please let me know if you have any questions.


Error creating Virtual Python environment while creating Azure Functions Project in Visual Studio Code

Repro steps:
<Enter steps to reproduce issue>
Action: azureFunctions.createFunction
Error type: Error
Error Message: Failed to run "func_env\Scripts\activate && pip install ptvsd" command. Check output window for more details.
Version: 0.11.0
OS: win32
Running command: "func_env\Scripts\activate && pip install ptvsd "...
Collecting ptvsd
Using cached https://files.pythonhosted.org/packages/5e/15/78a8be571d6a450c6ad36a675e4384bb4f33f9e920cfcc74b6e3a9683520/ptvsd-4.1.3-py3-none-win_amd64.whl
Installing collected packages: ptvsd
Could not install packages due to an EnvironmentError: [Errno 2] No such file or directory: '......\func_env\Lib\site-packages\ptvsd\_vendored\pydevd\pydevd_attach_to_process\winappdbg\win32\pycache\context_amd64.cpython-37.pyc'
You are using pip version 10.0.1, however version 18.0 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.
Error: Failed to run "func_env\Scripts\activate && pip install ptvsd" command. Check output window for more details.

Sorry for the delayed response. Does this still repro for you? Can you try running func_env\Scripts\activate && pip install ptvsd manually from the command line? That issue is coming from 'pip' so I'm not sure if our extension can fix it directly

Closing due to lack of response. Feel free to re-open with more info
Also related to https://github.com/Microsoft/vscode-azurefunctions/issues/821


PPM Payment Request: Payment Review Layout

Description
Styles the PPM Review Page, specifically the document upload summary.
Setup

Login as a user that is ready to request payment (e.g<EMAIL_ADDRESS>Navigate through the closeout flow until the payment review screen (/ppm-payment-review)
Verify review layout is styled.

make e2e_test
make client_test

Code Review Verification Steps

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story

Screenshots

IDK if it's just me but once I reach the storage expenses I can't get past it to the review page.

@ralren Just updated it with master, should be good to go now and the flow should now be unblocked


Correct style and make phrases easier to read

Merged via https://gitlab.com/gitlab-org/gitter/gitter-translations/merge_requests/57
Thanks @mkpankov


[Feature] mysql cdc ingestion: Scan Newly Added Tables

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
# mysql cdc 2.3
Scan Newly Added Tables feature enables you add new tables to monitor for existing running pipeline, the newly added tables will read theirs snapshot data firstly and then read their changelog automatically.
Imaging this scenario: At the beginning, a Flink job monitor tables [product, user, address], but after some days we would like the job can also monitor tables [order, custom] which contains history data, and we need the job can still reuse existing state of the job, this feature can resolve this case gracefully.
by testing,i found mysql cdc ingestion don't back the feature.

No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

This is a high priority task

Sounds like a legit scenario where user stops the sync job and restarts using new configuration to sync more tables.


Gallery upload size fix

Corrects an error causing image uploads to fail, due to django using different file handler classes based on file size.

I renamed the context from teamcity from teamcity -> teamcity-pytest which makes it look like it's not done. Both of the "details" links links to the same page.


feat(webpack): support merging loader options

This simplifies and removes the redundancy in the production webpack config.

tests seemed to have flaked.

Looks like the new webpack-merge feature was temporarily removed in latest update.  Will re-open when feature is back in and stable.


merge master to m_dbg

Build failed. It must be other reasons since this PR is simply a merge from master.  m_dbg is still a working branch, I am merging this PR to unblock myself to submit new PR.   I'll try to resolve the build error in a separate effort.


[hal] rename present_nosemaphores

Fixes #issue
PR checklist:

[x] make succeeds (on *nix)
[ ] make reftests succeeds
[x] tested examples with the following backends:

[x] metal

[x] rustfmt run on changed code

Okay. Let me rename it.


Functionality fails after refreshing the page

When I first entered a document with a picture, this function works. But when I refresh the page, the function fails

Hello,
@ataft it happens in conjunction with @docusaurus/plugin-ideal-image. I guess that's the issue with setTimeout(/*...*/, 100) in zoom.js (after increasing it to 1000 it works - but this is not a proper solution).
Basically @docusaurus/plugin-ideal-image renders svg with blurred image until real image is loading and later on replaces svg with proper img.

Thanks @xgarrett , this seems to work. As you say, maybe not the proper solution, but ok for now. Fixed in version 1.1 of this plugin.


Keep ureq::Agent for native clients

I love the simple API of this crate! It can be useful if ehttp supports saving cookies, such as login function. Currently, the "agent" (ureq::Agent type) is not continuous between each request.
A cross-platform and object-oriented example might look like this:
pub struct Agent {
    #[cfg(not(target_arch = "wasm32"))]
    agent: ureq::Agent,
}

// save the session if we need (compatible syntax)
let session = Agent::new();
session.fetch(req, |r| match r {
    Ok(r) if r.ok => alert("Login successfully!"),
    _ => alert("Login failed!"),
});

// original "fetch" function
fetch(req, |r| match r {
    Ok(r) if r.ok => alert("Login successfully!"),
    _ => alert("Login failed!"),
});

Good point. We should probably make an API like that, wrapping ureq::Agent.


Libsystem: remove libsystem_kernel symbols for compatibility with macOS 10.13

Motivation for this change
Don't remember if I finished testing this.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Merged in #32317


Add link to ASP.NET API Versioning project

@commonsensesoftware please let us know if the wording I propose here works for you

Looks fine to me. @Eilon is familiar with my work. This should be an easy approval. Thanks.


⚠ Bofrost.at has degraded performance

In 2037632, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1897 ms

Resolved: Bofrost.at performance has improved in 8000b3f after 54 minutes.


Add Symbolic by Death

Song Name
Symbolic
Artist Name
Death
Source
Youtube
Youtube Link
eaL7zGvJtpFHSx
Direct File Link
No response
Song ID
726252
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 38306937

reject
invalid YouTube link


security/acme-client: gcloud not working anymore

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
[X] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[X] I have searched the existing issues and I'm convinced that mine is new.
[X] The title contains the plugin to which this issue belongs
Describe the bug
The integration of the gcloud sdk with the current version of os-acme-client does not work anymore. The gcloud sdk had breaking changes.
Example:
On line 77 in the DnsGcloud.php file, os-acme-client executes a gcloud config command with dots in the config name. But gcloud does not allow dots:
configuration names start with a lower case letter and contain only lower case letters a-z, digits 0-9, and hyphens '-'.
To Reproduce
Steps to reproduce the behavior:

Setup the acme client with an Google Cloud DNS Challenge
Try to issue the certificate
You will get an error message:
/usr/local/opnsense/scripts/OPNsense/AcmeClient/lecert.php: AcmeClient: The shell command '/usr/local/bin/gcloud config configurations create returned exit code '120'

Expected behavior
The gcloud SDK should be able to log in with the service account and edit the DNS entries.
Environment
OPNsense 21.7.7 (amd64, OpenSSL).
os-acme-client 3.6
os-google-cloud-sdk 1.0_1

configuration names start with a lower case letter and contain only lower case letters a-z, digits 0-9, and hyphens '-'.

:facepalm:
I'll try to find a workaround in one of the next releases.

OK, let's test a simple fix. Please try the following patch:
opnsense-patch -c plugins 80f0c0b8

...and report back if it fixes the issue.

Okay I just installed the patch. I proceeded in the same way as with the initial bugreport.
The same error message still appears in the ACME client log file:
2021-12-21T22:43:49 | opnsense[5562] | /usr/local/opnsense/scripts/OPNsense/AcmeClient/lecert.php: AcmeClient: The shell command '/usr/local/bin/gcloud --quiet config set project prod-XXXXX' returned exit code '120'
2021-12-21T22:43:48 | opnsense[5562] | /usr/local/opnsense/scripts/OPNsense/AcmeClient/lecert.php: AcmeClient: The shell command '/usr/local/bin/gcloud --quiet config set account<EMAIL_ADDRESS>returned exit code '120'
2021-12-21T22:43:47 | opnsense[5562] | /usr/local/opnsense/scripts/OPNsense/AcmeClient/lecert.php: AcmeClient: The shell command '/usr/local/bin/gcloud --quiet auth activate-service-account --key-file=/tmp/acme_dns_gcloud_61c24955db6458-61118180.json' returned exit code '120'
2021-12-21T22:43:46 | opnsense[5562] | /usr/local/opnsense/scripts/OPNsense/AcmeClient/lecert.php: AcmeClient: The shell command '/usr/local/bin/gcloud --quiet config configurations activate acme-61c24955db6458-61118180' returned exit code '120'
2021-12-21T22:43:45 | opnsense[5562] | /usr/local/opnsense/scripts/OPNsense/AcmeClient/lecert.php: AcmeClient: The shell command '/usr/local/bin/gcloud --quiet config configurations create acme-61c24955db6458-61118180' returned exit code '120'

But here's what's interesting:
When I execute the shell commands which fail in the upper logfile via SSH as root, I get no exit code 120.
Here is the Bash history:
root@router:~ # /usr/local/bin/gcloud --quiet config configurations create acme-61c24955db6458-61118180
ERROR: (gcloud.config.configurations.create) Cannot create configuration [acme-61c24955db6458-61118180], it already exists.
root@router:~ # /usr/local/bin/gcloud --quiet config configurations activate acme-61c24955db6458-61118180
Activated [acme-61c24955db6458-61118180].
root@router:~ # /usr/local/bin/gcloud --quiet auth activate-service-account --key-file=/tmp/acme_dns_gcloud_61c24955db6458-61118180.json
Activated service account credentials for<EMAIL_ADDRESS>root@router:~ # /usr/local/bin/gcloud --quiet config set account<EMAIL_ADDRESS>Updated property [core/account].
root@router:~ # /usr/local/bin/gcloud --quiet config set project prod-335120
Updated property [core/project].

I hope this information helps you. Thank you!

In my own testing I've also noticed the exit code 120, but the gcloud configuration was properly set up. It doesn't seem to be a problem. Afterwards acme.sh was started as usual and was able to use the specified gcloud configuration without issues.
@thomasglauser, can you check the ACME Log in Services: ACME Client: Log Files please? I'd assume that it was able to use the generated gcloud config without any issues. (I cannot test it properly, because I don't use gcloud.)

You are right @fraenki. The exit code is not a problem. The commands are executed correctly.
The error in the ACME log is now the following:
2021-12-22T00:23:30 acme.sh[97449] _dns_gcloud_start_tr: failed to execute transaction

This error is in the acmesh-official codebase on Line 62:
https://github.com/acmesh-official/acme.sh/blob/master/dnsapi/dns_gcloud.sh
if ! gcloud dns record-sets transaction start \
    --transaction-file="$tr" \
    --zone="$managedZone"; then
    rm -r "$trd"
    _err "_dns_gcloud_start_tr: failed to execute transaction".
    return 1
  fi
}

As I understand it, there is something wrong with the transaction file $tr that the script creates. When I run this gcloud sdk command with a custom transaction file via SSH I get no error.
I think we can close this ticket since the transaction file is not generated by your code, right?
I hope your fix will be merged soon. Thank you very much.

I think we can close this ticket since the transaction file is not generated by your code, right?

Yes, indeed. :)
Maybe it's worth to report the "failed to execute transaction" error with the latest gcloud SDK to the acme.sh project.

@fraenki & @thomasglauser I saw your post here, and wanted to give a follow-up. I ran into the same issue described here, and can report it's still not-fixed. I tried both the patch & running  gcloud components update to update the SDK from 331 to 368. DNS-TLS-01 challenge did work.

@unquietwiki The issue is resolved, as confirmed by the author. You are likely facing a different problem. Please open a new issue and provide more data, i.e. your os-acme-client config and logs.


Lint Error Android Build

Summary
when running :react-native-device-info:lint I get an error. Originally it was complaining about RNDeviceModule.java overriding or implementing a deprecated API, but I can't reproduce that error. I have attached the lint results print out.

Version
0.15.2

Affected OS
?

OS Version
?

Current behavior

Expected behavior

Lint Report.pdf

Hi @adunn511 and thank you for reporting this.
I think that the deprecated methods are the one I introduced in this commit as a quickfix for #318

okay, I think there's another issue with gradle versions as attached in the lint report.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-device-info:lint'.
> Lint found errors in the project; aborting build.

  Fix the issues identified by lint, or add the following to your build script to proceed with errors:
  ...
  android {
      lintOptions {
          abortOnError false
      }
  }
  ...

  Errors found:

  /home/stanimir/structmedia/triplogapp/TripApp/node_modules/react-native-device-info/android/src/main/java/com/learnium/RNDeviceInfo/RNDeviceModule.java:64: Error: Missing permissions required by WifiManager.getConnectionInfo: android.permission.ACCESS_WIFI_STATE [MissingPermission]
        this.wifiInfo = manager.getConnectionInfo();
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/stanimir/structmedia/triplogapp/TripApp/node_modules/react-native-device-info/android/src/main/java/com/learnium/RNDeviceInfo/RNDeviceModule.java:295: Error: Missing permissions required by TelephonyManager.getLine1Number: android.permission.READ_PHONE_STATE or android.permission.READ_SMS or android.permission.READ_PHONE_NUMBERS [MissingPermission]
        constants.put("phoneNumber", telMgr.getLine1Number());
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/stanimir/structmedia/triplogapp/TripApp/node_modules/react-native-device-info/android/build.gradle: Error: All com.android.support libraries must use the exact same version specification (mixing versions can lead to runtime crashes). Found versions 25.2.0, 23.0.1. Examples include com.android.support:support-compat:25.2.0 and com.android.support:appcompat-v7:23.0.1 [GradleCompatible]

Getting same error as mentioned by @sytolk. Any suggestions?

in the AndroidManifest.xml those permissions need to be added above the  tag. I did it locally and it resolved those issues, but I kept getting a mismatch with gradle versions, so I made my own stuff to use since I only needed a few things. Hope this helps

@adunn511 you not need to add those permissions (if you not use READ_PHONE_NUMBERS in you App) I think the true fix for this is to suppress Lint warnings in react-native-device-info build.gradle something like this:
android {
      lintOptions {
          abortOnError false
      }
  }

@sytolk that’s not true the linter for the package picks that up since there are functions that need those permissions to execute, thus causing builds to fail. I use an automated pipeline and it runs the linter for this package, I’m not using those but it still fails. Adding that to the build.gradle will just suppress all lint errors. If the owners of this are okay with that I wouldn’t be opposed to that being added so I could use this :)

I meant add those to permissions in the manifest for this package not at the app level

@adunn511 if READ_PHONE_NUMBERS permission is added in Manifest for this lib. Manifest merger will set this permission in your app too. And the PlayStore users that install the App need to accept READ_PHONE_NUMBERS permission from your fake App :) I thing this is the worst thing that suppress Lint warnings ;)

Hi, I'm getting similar problem with build warning:
Configure project :react-native-device-info
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html
WARNING: The specified Android SDK Build Tools version (25.0.2) is ignored, as it is below the minimum supported version (27.0.3) for Android Gradle Plugin 3.1.3.
Android SDK Build Tools 27.0.3 will be used.
To suppress this warning, remove "buildToolsVersion '25.0.2'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.

> Task :react-native-device-info:compileDebugJavaWithJavac
Note: C:\Users\Admin-ESS\Absent\node_modules\react-native-device-info\android\src\main\java\com\learnium\RNDeviceInfo\RNDeviceModule.java uses or overrides a
deprecated API.
Note: Recompile with -Xlint:deprecation for details.

the first warning: not sure why it is still recognized as v25.0.2 though although there is already this bit on app level gradle:
android {
    compileSdkVersion 27
    buildToolsVersion "27.0.3"

    defaultConfig {
        applicationId "com.absent"
        minSdkVersion 16
        targetSdkVersion 27
        versionCode 1
        versionName "1.0"
        ndk {
            abiFilters "armeabi-v7a", "x86"
        }
    }

I thought RN Device Info's gradle already checked if project has specified the buildtoolversions?
also, I'm complete noob when it comes to config like these, so just wanna make sure, if I change the compile syntax into implement on RN Device Info's gradle, would that solve the second warning?

any update on this one?

I'm also experiencing issues with aborting on a lint error for missing permissions. For the app I am building I do not want to request those permissions without needing them. The patch I have added to android/build.gradle is
    lintOptions {
       warning 'InvalidPackage', 'MissingPermission'
    }

Any update on this?

@lorenc-tomasz nope, hints: the issue is still open, and labeled with "help wanted".
Feel free to make a PR.

@lorenc-tomasz sometimes it takes less time to make a PR than to comment even...

sometimes... ;) The depracations I saw is about GCM and formatter.formatipaddress. Nothing big at the moment.

@lorenc-tomasz  ha - in the "test first, then post frisky comments" department, it appears that build.gradle needed some minor library version specifications before lint was truly happy anyway. I updated my PR after verifying that ./gradlew :react-native-device-info:lint actually passes in the example app from this repo, with the changes that fed into the PR. Should work

react-native-device-info 0.29.1 published 🎉

Version 1.0.0:

Task :react-native-device-info:compileReleaseJavaWithJavac
Note: /xyz/node_modules/react-native-device-info/android/src/main/java/com/learnium/RNDeviceInfo/RNDeviceModule.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

Did you try - Xlint deprecated? I can't tell from your comment if this is a report of success or requests for help

afterEvaluate {project ->
        if (project.hasProperty("android")) {
            android {
                lintOptions {
                    abortOnError false
                }
            }
        }
    }

This allows you to modify the configuration of all projects


Container rescheduling on leader node failure

Overview
I've been going deep in to testing in what network scenarios Docker Swarm will declare a host dead and start rescheduling containers. I've discovered that containers don't reschedule if the leader is the one to fail.
Systems

5 systems, all on the same network.
Each system is a swarm manager.
Each system has other containers running along side it (web applications, redis, ect)
One of these is of course the swarm manager leader

Issue
If you were to shutdown the swarm manager leader system (easiest way to reproduce), leader reelection happens, but the containers that were on that machine are not rescheduled, even though they were configured to. If you were to shutdown a swarm manager follower, it works as expected where containers are moved to another appropriate system.
From what I understand, the swarms state is saved in the discovery service (in my case Consul), shouldn't Swarm verify what containers were lost on the swarm manager leader after reelection?
Is the system scenario I've laid out the wrong way to accomplish Swarm with rescheduling? The idea is running a Swarm with the least amount of systems/money spent.

Thanks for providing detail information. I think this is a case that currently Swarm doesn't handle.

the swarms state is saved in the discovery service (in my case Consul), shouldn't Swarm verify what containers were lost on the swarm manager leader after reelection?

Swarm uses Consul for node discovery only. It doesn't store container information.
Swarm master has a cache of current running containers in every node. When a node fails, it reschedules containers from that cache. When master fails, the newly elected master doesn't have that cache so it cannot reschedule those containers.

Thanks for the reply, @dongluochen! Would this be something that would be supported in the future storing the cache elsewhere then the swarm master?

@dustinblackman It'd come down to a distributed data storage to keep running configuration. This and related functionalities are implemented in Swarmkit and integrated into Docker 1.12. You may want to take a look.

Brilliant. If it's done there, I suppose it won't be completed here. I'll close this, thanks a lot!


standardscaler and minmaxscar transformition in python

Proposed title of article
standardscaler and minmaxscar transformition in python
Proposed article introduction
MinMaxscaler and StandardScaler are two scaling methods used in machine learning for continuous data. Minimum and maximum values are set to 0 and 1, respectively, via a MinMaxscaler. To put it another way: The StandardScaler only scales the values between min and max so that they all fall within that range.
We will learn about the principles of MinMaxScaler & StandardScaler using Python code in this article.
Key takeaways

Reason why  we need Feature Scaling
Normalization and standardization
MinMaxScaler for Normalization
StandardScaler for Standardization

Article quality

There will be a Pandas data frame involved.
This post will explain the concepts and distinctions between MinMaxScaler and StandardScaler through Python code examples.

References
N/A
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Based on this search, this topic seems a bit over-saturated. We focus more on unique projects. Feel free to suggest another topic. Thanks


Implemented Snapshot.export

For @thlorenz review.

Looks nice after quick review and should solve the problem I was trying to tackle in #55.
I'll review this in more detail and give you better feedback by Monday.

@thlorenz , Ok, thanks.
@bajtos , any thoughts?

I'd say the solution is overcomplicated, it should be enough to support the flavour export().pipe(). Everything else can be achieved by stream composition, there is no need to repeat it in v8-profiler.

@bajtos , are you propose to return Writable stream if there are no arguments passed to function, or you also propose to completely remove callback strategy for this method?

are you propose to return Writable stream if there are no arguments passed to function, or you also propose to completely remove callback strategy for this method?

Yes and yes.
See concat-stream for an example of converting a stream-based interface to a callback-based one.

Code sample:
var callback = function(err, data) { /*...*/ };
var concatStream = require('concat-stream')(function(data) { callback(null, data); });
profiler.takeSnapshot().export()
  .on('error', callback)
  .pipe(concatStream)
  .on('error', callback);

Also toStream() may be a better method name than export.

Also toStream() may be a better method name than export.

I take export name, because I want to implement also import.snapshot method.
Completed API will look like:
var fs = require('fs') ;

profiler.gc().takeSnapshot().export() // We don't need to keep snapshot in memory
  .pipe(fs.createWriteStream('snapshot1'))
  .on('finish', profiler.gc)
  .on('finish', function test() {
    // Do something here.
    //...
    compareHeapState();
  });

function compareHeapState() {
  var currentHeap = profiler.takeSnapshot(),
    startHeap = profiler.import.snapshot('snapshot1');

  return currentHeap.compare(startHeap);
}

Exactly we don't have gc method now =)

@3y3 are you moving forwards with this?

Landed.
I prefer to keep callback api, because not a good idea to install external dependencie only to have ability to save snapshot.


enh: improve remote tables prompt

Description
Clarify the remote tables prompt to use fully qualified table names
Risk

Deploy Plan

LGTM.


Portable metadata queries.

This PR is an interface extension for portable metadata queries.
Assuming 'sql' is a session object, this is possible:
// get all table names in user's schema
std::string name;
soci::statement st = (sql.prepare_table_names(), into(name));
// st.execute/while-fetch/etc.

// get column descriptions for the given table name:
soci::column_info ci;
soci::statement st = (sql.prepare_column_descriptions(table_name), into(ci))
// st.execute/while-fetch/etc.

(bulk versions for vector are also supported, see the diff)
where column_info is defined as:
struct column_info
{
std::string name;
data_type type;
std::size_t length; // meaningful for text columns only
std::size_t precision;
std::size_t scale;
bool nullable;
};
The implementation assumes standard SQL information schema and PostgreSQL is used as a reference. Other backends do not need to do anything if they follow the standard. Oracle has a separate implementation since it is not standard-compliant in this regard - it is enough for the backend to override a set of backend functions that compose schema queries to redefine the standard behaviour.
This PR introduces one new header file. It might be necessary to fix build scripts appropriately.

Thanks, I'm sure this is going to be useful, but as I'm not sure how/what for exactly, I can't really comment on the API.
Of course, as always, it would be nice (indispensable?) to have the tests and documentation for this feature. TIA!

Apologies for late comment, but this is related and important since some of our CI builds are failing now:
https://travis-ci.org/SOCI/soci/builds/137353265
standard-use-type.cpp:(.text+0x0):
  multiple definition of `soci::get_numeric_value(soci::values const&,
    std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'

Shouldn't get_numeric_value be inline?

Fixed in https://github.com/SOCI/soci/commit/a0917b7c81c4e0d33b7fc78609d5637a8aacd5ff
The get_numeric_value is a helper function that was accidentally put at the namespace scope, while it belongs to the type_conversion instantiation, where it is uniquely used.

I'm aware this is 8 years ago, but as this code hasn't been changed since and on the odd chance that someone remembers I'd like to ask about the decision to have a hardcoded filter on table_schema = 'public'.
This decision means if you use a schema for your tables... you lose. I understand that sqlite3 doesn't support schemas and mysql/mariadb is the odd one out with its concept of database. I also understand why is it necessary to make sure that the table is unique per table. However, I'm struggling to see why you can't have a dynamic schema, possibly just as default argument to the prepare methods taking the value of 'public'.
Am I missing anything or was it just enough at the time?


x86: fix memory domain issue with adding partitions

Adding a partition to a domain, unlike the other APIs, has no call into arch code to let the arch code know that the domain had a partition added.
If the CPU switched to another thread in the same domain, or dropped privileges to user mode, the MMU page tables would not have the new partition policy in it.
A new arch API has been added which gets called when a partition is added.
ARM and ARC are unaffected, so their API implementations are no-ops.
Added test cases to prove that this and similar scenarios work as expected.
Fixes: #13918

Codecov Report

Merging #14004 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #14004   +/-   ##
=======================================
  Coverage   52.23%   52.23%
=======================================
  Files         307      307
  Lines       45448    45448
  Branches    10515    10515
=======================================
  Hits        23742    23742
  Misses      16912    16912
  Partials     4794     4794

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8825f...ddfd556. Read the comment docs.


Added JWT

readme.md Added badges
main.py: added pylint ignore warning, import security module, improved check_current_user. Added token to login page. Added test function to check JWT
security.py module created

Need to recheck JWT vs cookie


fix the row count refresh issue

Will NOT change the auto  save strategy for project. instead will refresh the meta data

@ostephens This should fix the issue in #1335 .


Local media breadcrumb trail items aren't clickable links

Hi,
First, just in case: https://en.wikipedia.org/wiki/Breadcrumb_(navigation)
If one goes into local media, artists, an artist, an album, the path is displayed at the top, for instance:

Local media/Artists/13 & God/13 & God

Surprisingly however, none of the items are clickable links. One would expect to be able to easily go back up to any of the previous levels by clicking on the word ("Artists", "13 & God" in my example, etc.)
Thanks!

Good idea. Anyone interested in contributing?


Asset Lineage OMAS -  Vertical Lineage for Glossary Terms

publish the glossary context: this event contains glossary term details and the full context of the schema elements involved in a semantic assignment. Lineage classifications are included in the glossary context
event renamed
no need to publish the New Entity Event for GT and schema elements
AL OMAS endpoint used for initial load returns the entity guid only if the entity has a context and it is published on the AL OMAS out topic

Signed-off-by: Daniela Otelea<EMAIL_ADDRESS>

Please add java doc to the new public methods


OTBR not working with OTBR_OPTIONS="-DOT_THREAD_VERSION=1.1"

I have built the OTBR version 1.1 thanks to the commands indicated in another ticket:
cd ot-br-posix
./script/bootstrap
INFRA_IF_NAME=wlan0 BACKBONE_ROUTER=0 OTBR_OPTIONS="-DOT_THREAD_VERSION=1.1" ./script/setup

My RCP is connected and I have rebooted the boards.
The OTBR agent status indicates a problem:
pi@raspberrypi:~ $  sudo service otbr-agent status
● otbr-agent.service - Border Router Agent
     Loaded: loaded (/lib/systemd/system/otbr-agent.service; enabled; vendor preset: enabled)
     Active: activating (auto-restart) (Result: exit-code) since Fri 2021-11-19 14:05:13 CET; 890ms ago
    Process: 1182 ExecStart=/usr/sbin/otbr-agent $OTBR_AGENT_OPTS (code=exited, status=2)
   Main PID: 1182 (code=exited, status=2)
        CPU: 26ms

I see something strange in syslog. It contains "Thread version: 1.2.0" whereas I have built for Thread 1.1. Do you know what I could have done wrong?
pi@raspberrypi:~ $ cat /var/log/syslog | grep otbr-agent
Nov 18 09:03:00 raspberrypi otbr-agent[431]: [INFO]-UTILS---: Running 0.3.0-4555d899e
Nov 18 09:03:00 raspberrypi otbr-agent[431]: [INFO]-UTILS---: Thread version: 1.2.0
Nov 18 09:03:00 raspberrypi otbr-agent[431]: [INFO]-UTILS---: Thread interface: wpan0
Nov 18 09:03:00 raspberrypi otbr-agent[431]: [INFO]-UTILS---: Backbone interface: wlan0
Nov 18 09:03:00 raspberrypi otbr-agent[431]: [INFO]-UTILS---: Radio URL: spinel+hdlc+uart:///dev/ttyACM0
Nov 18 09:03:00 raspberrypi otbr-agent[431]: [INFO]-UTILS---: Radio URL: trel://wlan0
Nov 18 09:03:00 raspberrypi otbr-agent[431]: 49d.17:02:55.059 [CRIT]-PLAT----: Init() at ../../third_party/openthread/repo/src/posix/platform/hdlc_interface.cpp:151: InvalidArgument
Nov 18 09:03:00 raspberrypi systemd[1]: otbr-agent.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Nov 18 09:03:00 raspberrypi systemd[1]: otbr-agent.service: Failed with result 'exit-code'.
Nov 18 09:03:05 raspberrypi systemd[1]: otbr-agent.service: Scheduled restart job, restart counter is at 1.

Yesterday I have had a log which was showing the version 1.1.1:
Nov 18 15:58:27 raspberrypi otbr-agent[2592]: [INFO]-UTILS---: Running 0.3.0-e623f2a5e
Nov 18 15:58:27 raspberrypi otbr-agent[2592]: [INFO]-UTILS---: Thread version: 1.1.1
Nov 18 15:58:27 raspberrypi otbr-agent[2592]: [INFO]-UTILS---: Thread interface: wpan0

By the way, what is the clean way to fully uninstall the OTBR agent? I want to rebuild and reinstall it.
Thank you for your help

Thank you, that was indeed the cause of the problem. I had /dev/ttyACM0 which doesn't exist.
I have retrieved the configuration file that we were using so far (we had an otbr version from January 2021 and an RCP using Thread 1.1):
pi@raspberrypi:~ $ cat /etc/default/otbr-agent
# Default settings for otbr-agent. This file is sourced by systemd

# Options to pass to otbr-agent
OTBR_AGENT_OPTS="-I wpan0 spinel+hdlc+uart:///dev/ttyUSB0"

I'm now getting another error which is pretty clear:
Nov 19 17:09:30 raspberrypi otbr-agent[1206]: 49d.17:04:29.489 [INFO]-PLAT----: RCP reset: RESET_POWER_ON
Nov 19 17:09:30 raspberrypi otbr-agent[1206]: 49d.17:04:29.561 [NOTE]-PLAT----: RCP API Version: 1
Nov 19 17:09:30 raspberrypi otbr-agent[1206]: 49d.17:04:29.561 [CRIT]-PLAT----: RCP API Version 1 is not in the supported range [4-5]
Nov 19 17:09:30 raspberrypi otbr-agent[1206]: 49d.17:04:29.561 [CRIT]-PLAT----: CheckRcpApiVersion() at ../../third_party/openthread/repo/src/lib/spinel/radio_spinel_impl.hpp:413: RadioSpinelIncompatible

So the RCP has to be updated but this is not under my control and it will take a long long time :o(
I can check what changed in the API and see if I can update the RCP but this is completely new to me.

In your opinion, how complex it is to move from RCP API Version 1 to Version 4?

In your opinion, how complex it is to move from RCP API Version 1 to Version 4?

If you not planning to leverage Thread 1.2 low power enhancements, then updating the RCP should be fairly straightforward.

Thank you


how to change ZipEntry Name?

how to change ZipEntry Name?
ZipArchive za=ZipArchive.Open("test.zip");
string oldName="zt/test_old.txt";
string newName="zt2/test.txt";
SharpCompress.Archive.Zip.ZipArchiveEntry findfile=null;
foreach (var ze in za.Entries) {
if (ze.IsDirectory) continue;
if (string.Compare(ze.Key, oldName) == 0) {
findfile = ze;
break;
}
}
if (findfile != null) {
MemoryStream ms=GetUnCompressStream(findfile);
za.AddEntry(newName, ms,true,ms.Length,findfile.LastModifiedTime);
za.RemoveEntry(findfile);
findfile.Close();
}
this method is Unfriendly.
And consumes a lot of performance.

and how to change dir name in Zip? there has fast way?

You can't change names without rebuilding the entire zip file.
I could probably change something to get around recompressing but that's a lot of work for a minor use-case.  You're welcome to try with a PR.


storybook and testing for plugins

Allows using storybook and testing with plugins

[x] Compiles the source from headlamp into /lib rather than just using types.
[x] Can make .stories.tsx files inside plugins, and have them run with npm run storybook
[x] Documentation on how to write stories, with an example.
[x] npm run update-dependencies script to update the headlamp-plugin/package.json dependencies to match frontend/package.json
[x] npm run check-dependencies script to ensure dependencies are synced between headlamp-plugin/ and frontend/
[x] storyshot snapshot testing works with npm run test inside the plugin
[x] have an example github workflow for running tests

[x] use this for our testing our plugins

[x] will have to support running a directory of multiple plugins

[x] maybe can reuse some code from our test scripts, and move that into headlamp-plugin.
[x] have an example for folders of plugins, not just for one plugin

[x] Add a npm run storybook-build to build storybook to static html.

[x] this provides some test coverage in a way, and is useful to check the separation of concerns. Because it's static html/js/css files it should work without other dependencies.
[x] It also can be useful to publish to a static website on PRs, for review.

[x] make all the testing commands work on folders of packages (test, lint, format, storybook-build, tsc)
[x] fix tsc command, so there's a headlamp-plugin tsc also so it works on folders of packages.
[x] add a headlamp-plugin format --check to be used in the github workflow

This is also used to add github workflow to the plugins repo here: https://github.com/headlamp-k8s/plugins/pull/5

Task list for npm run test.

[x] Separate PR for PluginLib.Cr change. Because that's required, and they use headlamp main. So that they can keep using latest main headlamp, and also use the pre-release @kinvolk/headlamp-plugin package.
[x] npm run test

[x] encapsulate npm run test in headlamp-plugin
[x] upgrade should handle requirements for test.

[x] add a scripts "test": "headlamp-plugin test"

[x] copy in storyshot tests to pod-counter (storybook.test.tsx, setupTests.ts)
[x] see if we can incapsulate (storybook.test.tsx, setupTests.ts) inside headlamp-plugin

[x] Get import CRD, { KubeCRD, makeCustomResourceClass } from '@kinvolk/headlamp-plugin/lib/k8s/crd'; working. Use upgrade command to update import paths to new import path.
[x] put frontend lib/index.ts back into headlamp plugin src/index.ts? I think it's better in src/index.ts because it's related to headlamp-plugin only. After the other restructuring, it now seems to make more sense in src/index... but would require retesting.
[x] try removing Utils.ts CommonComponents.ts etc

[x] No, keep it there. Because it shows which ones are available in lib/.
[x] maybe move them into frontend/src/lib/ ?

[x] have a --check command for update-dependencies.js and to CI. To make sure package dependencies are up to date. So it tells someone when frontend/package.json dependencies are changed that they need to also sync with headlamp-plugins (by using the update-dependencies script).

[x] Add yargs command line

[x] include jest transformIgnorePatterns (maybe with a command line script inside headlamp-plugin). See pod-counter.

It completes these issues:

setup testing https://github.com/kinvolk/headlamp/issues/569
ships source in headlamp-plugin for testing #778

How to use
You can try the alpha.0 release in an existing plugin because it's been published to npm.
cd theplugin
npm install<EMAIL_ADDRESS>npx<EMAIL_ADDRESS>upgrade --skip-package-updates
npm run storybook

To try out an example with a story see plugins/examples/pod-counter
git clone git@github.com:kinvolk/headlamp.git
cd headlamp
git fetch --all
git checkout plugin-source
cd plugins/examples/pod-counter
npm install<EMAIL_ADDRESS>npx<EMAIL_ADDRESS>upgrade --skip-package-updates
ls src/
npm run storybook

See plugins/examples/pod-counter/src/Message.stories.tsx and src/Message.tsx for story examples.
cd plugins/headlamp-plugin
npm run build
npm pack
cd ../examples/pod-counter
npm i ../../headlamp-plugin/*.tgz
npm run storybook

Testing done

[x] Used in the plugins repo https://github.com/headlamp-k8s/plugins/pull/5 inside a github workflow.
[x] Can run the storybooks. cd plugins/examples/pod-counter && npm install && npm run storybook
[x] Can run the tests (with jest and storyshot). cd plugins/examples/pod-counter && npm install && npm run test
[x] The existing plugin commands still work (build, tsc, and lint).
[x] for npm run update-dependencies, add frontend/package.json dependencies, goes into headlamp-plugin/package.json
[x] for npm run check-dependencies, add frontend/package.json dependencies and it fails. Add to headlamp-plugin/package.json and it fails with return code 1. Which is what you want, because packages are not synced in these cases.
[ ] version changes of deps are handled npm run update-dependencies, add frontend/package.json dependencies, goes into headlamp-plugin/package.json
[ ] version changes of deps are handled npm run check-dependencies, add frontend/package.json dependencies and it fails. Add to headlamp-plugin/package.json and it fails with return code 1. Which is what you want, because packages are not synced in these cases.
[x] npm run check-dependencies is run in CI to check dependencies are synced with frontend.
[x] npx @kinvolk/headlamp-plugin upgrade works with existing plugin/examples plugins
[x] importing CRD inside a component works in the plugin and in stories. (console.log(CRD) shows the object)

Hey hey. This could use another review.
All the commands used in testing now work on folders of plugins as well. A github workflow for plugins is in the docs and also used in the plugins repo https://github.com/headlamp-k8s/plugins/pull/5
🧹🧽 I've removed all the intermediate alpha release commits, and squashed a few of the commits too.

Since we change how import CRD, { KubeCRD, makeCustomResourceClass } from '@kinvolk/headlamp-plugin/lib/k8s/crd'; working. works, This makes it a breaking change for plugins that use such an import style for CRD, one way we could fix this would be to update all such imports in users src directory when they update there plugin to this version

An example of using react testing library in the plugin should be done in a separate PR (make issue).

TODO: Bug: when updating frontend/package.json dependency to a new version npm run update-dependencies and npm run check-dependencies do not work.

The version changes in frontend/package.json are synced to headlamp-plugin/package.json now too.


Book form using classes and more styling

Steps that were taken to complete this project.
Add Linters for HTML/CSS.
Use best practices for HTML & CSS.
Update the README file.
Add Mark up to the .html file.
Used Bootstrap for styling
Add Form to save books.
Use Local storage to save user data.
User can add books and can remove it from the list.
Using multiple classes

I had fixed most of the linter issues in JS, however, one error that it was displaying stated that I could not use more than one class. To fix this may lead to a change in the outcome of my code as I used a total of 3 classes and will be very time consuming to change. So I then added a " /* eslint-disable */ " to the top of the script.js file so that it could pass the linter tests and avoid the 1 error that it was displaying. My code works and fulfills all the requirements of the project.


Update MoT Mariner 2.0 and Centos stream8 OS definitions

The os definitions for Mariner 2.0 and Centos stream8 are not correct, thus they're not appearing in the MoT outputs. We should fix them to match what's getting parsed by the docker parser

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[x] Internal Infrastructure Improvements

Release Note Description
Update MoT Mariner 2.0 and Centos stream8 OS definitions

PR: https://dev.azure.com/dnceng/internal/_git/dotnet-helix-machines/pullrequest/38832

The PR has been merged and the information has been updated


Things to get ready for production

For beginners, it would be awesome to have doc pointers or examples on how to actually set up a production system. E.g other issues have repeatedly mentioned that compression and caching etc (throttling,...?) should not be done by next.js but on top of it (with cloudflare? Nginx?).
All I know so far is how to make a next.js webapp and deploy it on Now, but I need to make it ready for production:
https://github.com/relatenow/relate

I think for beginer, setting up nginx is over complicated (from installing to config). I suggest using caddy as a web server in front of next.js.
It should be quick and super easy:

Download binary for operating system
Write a Caddyfile like this

localhost:3000
gzip
log ../access.log

It even packs with Let's Encrypt for SSL out of the box. See here

I think that's fine.
But the point is, there's nothing specific related to Next here.
It's just a typical app which can set behind a proxy or a service like cloudflare.
We are tracking the compression stuff here: https://github.com/zeit/next.js/issues/984

Thanks. I hope I don't need to do anything about SSL as Now provides that? Anyway I'll try my luck by asking on Now's side 😉
https://github.com/zeit/now-cli/issues/285

@arunoda Did you try this with cloudflare?
I just tried using it with next.js and get some awkward common.js errors and the app doesn't work any more as soon as i enable cloudflare... nor entirely sure where it comes from, yet.

@sakulstra my site is running next.js with coudflare, no problem at all. Did you enable cloudflare optimization? Like concat js, html, css. Try to disable that

@thangngoc89 intrestingly you're totally right - i had html minification turned on.
This is kind of off topic, but just out of curiosity - does someone know why it fails with html minification turned on, but succeeds with minified js and css? This doesn't make sense to me.

@sakulstra I never enable those thing with a SPA because it always leads to weird behaviors. I suggest to disable css and js minification too. Webpack build is optimized.

Have you had any load/performance testing? Trying to scale and load an AWS ELB application and having issues getting bpast 20 requests per second.

Why is this issue closed? I propose it should remain open until more of a solution is drawn out to add explanations such as https, websocket connection between nextjs and azure or aws api's. This could be added in the exampes folder or in the wikipedia for ops related tasks.
I would propose there are ops related tasks to actually interfacing nextjs with other cloud api's and that should be covered at least in the wiki.

@jancel did you ever figure out how to solve your issue?

@pruhstal enabling sticky session on AWS solved my issues when scaling, you can do this directly with elastic beanstalk.


run_driver_tests.psm1 falsely marks tests as passed when they fail

See as an example:
https://github.com/microsoft/ebpf-for-windows/runs/6134826890?check_suite_focus=true#step:9:118

This has been fixed in parts by multiple PRs:
https://github.com/microsoft/ebpf-for-windows/pull/1251/
https://github.com/microsoft/ebpf-for-windows/pull/1215
https://github.com/microsoft/ebpf-for-windows/pull/1213
https://github.com/microsoft/ebpf-for-windows/pull/1239
https://github.com/microsoft/ebpf-for-windows/pull/1242
Closing this issue.


Replace deprecated 'compile' gradle configuration with 'implementation'

See http://d.android.com/r/tools/update-dependency-configurations.html for more details

I believe this is already the case for RN 0.57?
https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md#057

@mars-lan Oh. I've missed that thank you. I will merge this!


Bug：“Refactor -> Move” UI display abnormal

The following is the built-in theme, there are no issues.

The oceanic-dark-theme has issues.

Thank you for your feedback! I have corrected the display of the table in the pop-up window, version 1.1.9 is currently being checked by Jetbrains. Alternatively, you can download the jar file from the release page https://github.com/varrcan/oceanic-dark-theme/releases/tag/1.1.9


Titan Embedding Connector Blueprint content referenced by users of OpenSearch 2.11 version

Description
Users using OpenSearch version 2.11 can also connect the connector.
Issues Resolved
issues link
Check List

[x] New functionality includes testing.

[ ] All tests pass

[o] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I applied with the wrong commit, so I'll cancel it and re-promote it.