Arm64 whl install issue

When installing from pip on a Mac with an Apple M1 Intel chip (arm64) in python 3.9.12 the standard pip install seems to install the incorrect shared object file (.so)
Steps to reproduce and current output in a virtual environment called venv.

pip install spiceypy
Output:

Collecting spiceypy
Using cached spiceypy-5.1.0-py3-none-macosx_11_0_arm64.whl (1.5 MB)
Requirement already satisfied: numpy>=1.17.0 in ./venv/lib/python3.9/site-packages (from spiceypy) (1.23.1)
Installing collected packages: spiceypy
Successfully installed spiceypy-5.1.0

Test in python

Python 3.9.12 (main, Apr  5 2022, 01:52:34)
[Clang 12.0.0 ] :: Anaconda, Inc. on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import spiceypy
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<local path>/venv/lib/python3.9/site-packages/spiceypy/__init__.py", line 27, in <module>
    from .spiceypy import *
  File "<local path>/venv/lib/python3.9/site-packages/spiceypy/spiceypy.py", line 36, in <module>
    from .utils.libspicehelper import libspice
  File "/<local path>venv/lib/python3.9/site-packages/spiceypy/utils/libspicehelper.py", line 57, in <module>
    libspice = CDLL(libspice_path)
  File "/opt/miniconda3/lib/python3.9/ctypes/__init__.py", line 382, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: dlopen(/<local path>/venv/lib/python3.9/site-packages/spiceypy/utils/libcspice.so, 0x0006): tried: '<local path>/venv/lib/python3.9/site-packages/spiceypy/utils/libcspice.so' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e'))

To test the contents of the listed file I run file <local path>/venv/lib/python3.9/site-packages/spiceypy/utils/libcspice.so
Output:

: Mach-O 64-bit dynamically linked shared library x86_64

The wheel file it grabs seems to be correct name, but it doesn't end up with the correct shared object.
My current work around that is successful is to install with the --no-binary flag
pip install spiceypy --no-binary :all:

from looking at worker logs, this appears to be an issue with both get_spice.py and the cibuildwheels project, either an actual bug in that project or an error with usage within this repo.

I think this is fixed in #453, where cibuildwheel does not attempt to update the ARCHFLAGS early enough, and I added some bits to make it more explicit what arch to build for arm64 on macos only.
Actions failing oddly due to a pandas installation issue on the linux side, no clear cause yet...

fixed by #453


*: release v0.11.0

Description of the change:
Update release and dependency versions to v0.11.0
Motivation for the change:
Retrying the release after #2043

/test e2e-aws-helm

/test e2e-aws-helm

/test e2e-aws-helm


f README

Hello.
I fixed the README.md not follow with 4.0.0 breaking changes.
Thanks for working on this plugin!

Perfect ! Thanks !


Using openldap_password in openldap::server::database triggers a resource change on every run

It appears, possibly rightly, that when using the openldap_password function as part of a openldap::server::database resource, a resource change is triggered on every Puppet run due to the function generating a different hash each time.
Is there any way of making this idempotent?

I have the same issue. What's going on here?

This is a complication of slappasswd generating a different hash every run. The problem with trying to make it idempotent is that there's no good way to test if a password is valid on the agent, as functions execute on the master.

And presumably you don't want to send the password to the client in order to generate it there iff the password doesn't work?

The generation happens on the master. The password is never sent in plaintext to the client.


feat(editor-export): quote block

Codecov Report

Merging #292 (2c281df) into dev (31a6911) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #292   +/-   ##
=======================================
  Coverage   87.12%   87.12%
=======================================
  Files         112      112
  Lines        1359     1359
=======================================
  Hits         1184     1184
  Misses        175      175

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a6911...2c281df. Read the comment docs.


Missing some icons in Neoactive theme

[WARN] [XMB] Asset missing: assets\xmb\neoactive\png\input_LB.png
[WARN] [XMB] Asset missing: assets\xmb\neoactive\png\input_RB.png
[WARN] [XMB] Asset missing: assets\xmb\neoactive\png\input_LT.png
[WARN] [XMB] Asset missing: assets\xmb\neoactive\png\input_RT.png
[WARN] [XMB] Asset missing: assets\xmb\neoactive\png\menu_add.png

Since we're using #262 for this issue comprehensively, I'm going to go ahead and close this issue.


In ocassions i can't see friend stream

In ocassions I only see my local video, i put several logs thinking that the problem was that I not get friend remote video, but the stream has data, why can't I see friend video?

@jlameiro87 have you tried a demo ?

@jlameito87 I have this bug too, don't know how to fix it

you might want to try to deploy STUN/TURN first to see if it works.

@zxcpoiu can you provide a link for some free STUN/TURN if there are any?

@CandyOgre
I don't advocate for services that I haven't tried.
But for open source project, coturn seems awesome


Modal covers status bar but leaves gap at bottom on some devices

On some devices, the modal backdrop will not cover the full screen. The status bar is covered, but a gap the height of the status bar is left at the bottom of the modal backdrop.

Just faced the same at Android emulator (AVD) API 23

What is the name of the AVD you use? I can't reproduce this bug on Nexus 5X

I have released the latest version(1.1.2). Can you verify if the problem has disappeared?

@listenzz The issue has been resolved. Great work.

This bug is reproducible once again on OnePlus 6. Probably because it has a curvy status bar (just a guess). Is it resolvable?

Solved by unlinking, removing completely and then reinstalling and linking again. Guess the issue could be closed again


Add command history to Terminal

Describe the enhancement
It'd be nice if I would be able to use my up/down arrow keys to navigate between commands I previously entered in the Terminal component. This is a very natural thing to be doing if you're a terminal user, and can prevent some frustration if you make a typo and have to type the command from the start.
Suggested solution
I don't suggest we persist these across sessions. We should just keep track of any commands users input in the Terminal component itself via its state.

@afterburn, After looking into the issue you mentioned, it appears that the react-terminal-ui library being used for the terminal-like experience has limited flexibility when it comes to handling the input text area. Specifically, the library only offers an onInput prop which is triggered only when the user hits the enter key. Unfortunately, there are no onKeyDown or onKeyUp events available for us to use in this scenario.

Good suggestion @vinayaksh42, as mentioned in the call I think we'll put this in backlog for now, but yeah I'm also leaning towards implementing a custom solution because of the following reasons:

We can support terminal-like behavior (such as command history) that our react-terminal-ui doesn't provide.
We can implement a fully functioning custom styled caret if @GBKS thinks we should indeed have one.
We can create other types of custom functionality, (syntax highlighting, autocompletion/hints, etc).

I would echo @vinayaksh42's saying and emphasize forking. We could fork from react-terminal-ui and publish it under our own repository, which would make the implementation of the caret and the history much easier.

I would echo @vinayaksh42's saying and emphasize forking. We could fork from react-terminal-ui and publish it under our own repository, which would make the implementation of the caret and the history much easier.


automatic tracing of ws

Is it applicable for Node or Browser or both
Node
Do you expect this plugin to be commonly used
Weekly Downloads: 10M (https://www.npmjs.com/package/ws)
What version of plugin are you interested in using
Versions: 5 - 7 (cover last 2 years of releases)
Additional context

Is there a reference you could point for the well-defined lifecycle methods

I believe only elastic implemented an intrumentation for this module (https://github.com/elastic/apm-agent-nodejs/blob/master/lib/instrumentation/modules/ws.js)

I for one would love this on both the node and browser side. I'd happily modify my payload with trace/span info to get tracing. Has anyone started to work on a solution for this? @vmarchaud

@dajulia3 I think nobody is currently working on it. @nstawski started working on it a while ago but she's not been involved in the project recently

No sign from @nstawski, i'll assign it to you @dajulia3 then

@dajulia3 can you please confirm you are working on that ?

@vmarchaud @obecny I'm not actively working on instrumenting that library per se... I'm about to implement a bit of custom instrumentation for socket stream rpc calls which an older node app is using. If there are any relevant learnings from that I'll be happy to share them.

I'd really like to make this a thing -- does anyone have any insight into if this is harder than it seems or half baked work we could adapt into a PR?

we just released a socket.io plugin check it out

we just released a socket.io plugin check it out

Will this work with ws  package?

we just released a socket.io plugin check it out

Will this work with ws package?

no, only with the socket.io package

I put together this instrumentation for the ws library here: https://www.npmjs.com/package/opentelemetry-instrumentation-ws , it traces the client side connection initiation and the server side, including the upgrade event and WebSocket initiation.
We've been running it in production for a few weeks now and it has helped us understand our websocket woes a lot better. We'd would love any feedback from some early adopters, especially around what should constitute a new trace vs a span within a long lived connection like a websocket. I think we'll love to upstream it to this contrib repo after building a bit more confidence it is the right shape! Source here: https://github.com/gadget-inc/opentelemetry-instrumentations/tree/main/packages/opentelemetry-instrumentation-ws

Are there any plans to migrate the ws instrumentation to this repository?


player names

but why it only shows IP, why the names of the players are not visible.
maybe I missed something?

Currently the app does not show player names.


Task: Connect with users on OSG

Teach data users how to use our data? Maybe working with and empowering 3rd party tools on  access user feedback/ user research.

closing in error


Share a final Presentation link on the README

https://docs.google.com/presentation/d/1mpfY3Bmu7nKKs3hsE7gQqjQxMAWsZ8AWS16ghgJVVuQ/edit#slide=id.p


[ENH] Add distributed segment metadata with active/flush states

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

Adds distributed segments to HNSW - a segment type with parents and children. Children use metadata to point to their parents. They bookkeep their flush offset, their storage location and their state - Active, Historical, Root.
The rust worker now finds and writes to the active segment.

New functionality

None.

Test plan
How are these changes tested?

[x] Tests pass locally with cargo test and pytest

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Current dependencies on/for this PR:

main

PR #1656   👈

This stack of pull requests is managed by Graphite.

closing as stale


Test on KinD 1.17-1.19

Problem
Run e2e tests on Github Actions with KinD to get coverage of supported version range: 1.17 - 1.19
Persona:
Which persona is this feature for?

Developer

Exit Criteria
e2e tests run on KinD
Time Estimate (optional):
How many developer-days do you think this may take to resolve?
1
Additional context (optional)
We should be able to enable just by copy-pasting the action from eventing and change installation steps:

Action: https://github.com/knative/eventing/blob/master/.github/workflows/kind-e2e.yaml
PR: https://github.com/knative/eventing/pull/4273/files

/help

/assign


Allow TLS configuration for githubwebhookserver

Is your feature request related to a problem? Please describe.
I would like to configure end to end TLS for the githubwebhookserver.
Describe the solution you'd like
I would like to have the githubwebhookserver listen for tls connections when configured with a host and certificate bundle secret name.
Describe alternatives you've considered
The only alternative I'm aware of is to terminate TLS at ingress.
There isn't much documentation around the githubwebhookserver so it's difficult to know what a typical configuration is or should look like. Browsing the code it doesn't appear that this feature is supported though.

Hello 👋
This a feature I am interested in as well and I was wondering if there is any estimation and plans for its addition?
Thanks,
Dimitar

@sethamclean @DimitarHristov111 Hey! Just curious, why don't you terminate TLS at ingress?

@sethamclean @DimitarHristov111 Hey! Just curious, why don't you terminate TLS at ingress?

We do now because it's our only option. End to end TLS would be more secure since secrets are being transmitted in clear text from the point of termination to the web hook container.

Hey 👋  Our setup is slightly different, but we again do something similar. And we still hope to have it as an end-to-end encryption which is why we are interested in the feature.

Thanks! Interesting. So you tend to do/request the same for every application that exposes an HTTP server on its own? Or is ARC special?
Can it be an option for you to use a service mesh or sorts or a CNI plugin like Cilium that can provide you end-to-end between pods?

Hello @mumoshu
I work with @DimitarHristov111  so I can give you a little more context. We have some clusters where only ARC is running, so:

we didn't want to add the service mesh as we feel it's an overkill
we don't use Cilium as CNI and our CNI can't do TLS termination
we're "just" using the AWS Load Balancer controller to configure the LB in front of the service. This works well for other services where we can mount TLS certificates generate for example by cert-manager

The options I see here are:

Contribute to the project to allow TLS connections
Add a sidecar in front of the githubwebhookserver so we do the TLS termination there. This maybe need just a change to the chart to allow us to inject sidecar container and then it will be up to us decide how to do the TLS termination.

What do you think?

@maruina Thanks for clarifying! That makes sense. Either 1 or 2 sounds good.
I'd guess the option 2 is easier to contribute/review (Probably adding sidecarContainers and volumes under githubWebhookServer would work:
https://github.com/actions-runner-controller/actions-runner-controller/blob/667764e02734938e0d0745a3098e66d3e086f7b7/charts/actions-runner-controller/values.yaml#L175)
The option 1 might be more useable though. In case you could contribute the option 1, I would add --cert-file and --key-file to the githubwebhookserver and enhance a template in the chart to enable specifying those flags (along with additional volumes if the key and the cert is being provided via a k8s secret
githubwebhookserver's command: https://github.com/actions-runner-controller/actions-runner-controller/blob/667764e02734938e0d0745a3098e66d3e086f7b7/cmd/githubwebhookserver/main.go#L88-L104
The relevant part of the chart template: https://github.com/actions-runner-controller/actions-runner-controller/blob/667764e02734938e0d0745a3098e66d3e086f7b7/charts/actions-runner-controller/templates/githubwebhook.deployment.yaml#L38-L51

Thanks @mumoshu for your input.
I will have a chat with @DimitarHristov111 and then we will come back to you :)

Hello, we think we will go with the second option. It might be a bit more difficult, but it seems like the better solution. :)
I found the following guide https://github.com/actions-runner-controller/actions-runner-controller/blob/master/CONTRIBUTING.md for contributing to the project. Do you think there is anything else we should consider as well before doing the contribution?

@DimitarHristov111 Hey! I might not have covered how to contribute to the chart but hopefully, there are not many variables there.
Probably, all you need before finally submitting a pull request would be to (1) clone the repo (2) install the chart locally by running helm upgrade --install -f values.yaml $RELEASE_NAME ./charts/actions-runner-controller (3) modify the chart locally (4) rerun the helm upgrade --install.
Note that you don't need to bump the chart version as we use a workflow to automate publishing the chart and bumping the chart version triggers that, although we want to control when to publish the version(so that end users won't receive too many notifications about new chart versions


Fix impact for a consequence (e109)

The impact of 'regulatory_region_ablation' should be MODIFIER instead if MODERATE.
http://wp-np2-11.ebi.ac.uk:7070/info/genome/variation/prediction/predicted_data.html

Hello @jgtate , this is the PR I was talking about in todays meeting, Can you merge it?


QRCODE Implementation

Hey Guys
I have implemented Qr-code printing functionality. I'm a beginner in programming so I'm not sure how to submit the code here. Is there a way way I could submit my code here for you guys to review.
Cheers!!

I have created pull request for review of the code.
Cheers!!

Hey @netgg93 , thank you for contributing! The code looks good, although I haven't reviewed it in depth.  The only issue with proceeding on the PRs is that your changes are in separate branches, so it's difficult to review and comment on them like this.  We're using GitFlow for this project, so it would be more appropriate for you to create a PR for merging your remote develop branch into the project's develop branch.
So next steps for you would be to close all 4 of your PRs, then merge your different branches into your develop branch, and then create a single PR for netgg93/develop to lukevp/develop that includes all your changes.  I'll then review and comment on it and once we resolve any issues it will get merged.
Thank you again for your work!

hey @netgg93 please see above. I'm closing this as a duplicate of #4 and I am closing the PRs, but if you follow the directions above and tie your PR to issue #4 we can review it there. Thanks again!


Restructure codejail to allow more flexible jailing

TNL-4843: Update CodeJail to handle Python 3

Introduce new Jail type that has its own jail_code and safe_exec methods.
Add ability to get Jail object by name.
Begin decoupling Jail name from language implementation.  (Still some legacy coupling to "python" name).
Introduce python3 safe_exec wrapper.

Note:

not_safe_exec does not work with python3 because that runs code in the existing python process.  It's already a broken abstraction, because it runs the code in a different virtualenv than it would run in if it were sandboxed, so requirements may not match.

To manually explore:
$ virtualenv --python=/usr/bin/python2 /tmp/venv1
$ virtualenv --python=/usr/bin/python2 /tmp/venv-sandbox2
$ virtualenv --python=/usr/bin/python3 /tmp/venv-sandbox3
$ . /tmp/venv1/bin/activate
$ pip install -e git+https://github.com/edx/codejail@cdyer/multijail#egg=codejail
$ python

Then:
>>> import codejail
>>> python2_jail = codejail.configure('python', '/tmp/venv-sandbox2/bin/python', lang=codejail.python2)
>>> python3_jail = codejail.configure('python', '/tmp/venv-sandbox3/bin/python3', lang=codejail.python3)
>>> result2 = python2_jail.jail_code('print "hi reviewer"')
>>> print result2.stdout
hi reviewer
>>> result3 = python3_jail.jail_code('print "hi reviewer"')
>>> print result3.stderr
  File "jailed_code", line 1
    print "hi reviewer"
                      ^
SyntaxError: Missing parentheses in call to 'print'
>>> globals_dict = {'before': 8}
>>> python3_jail.safe_exec('after = "{}-)".format(before)', globals_dict)
>>> globals_dict
{'before': 8, 'after': '8-)'}

Sandbox

[ ] Build a sandbox for your branch and add a link here

Testing

[ ] Unit, integration, acceptance tests as appropriate

Reviewers
If you've been tagged for review, please check your corresponding box once you've given the :+1:.

[ ] Code review: @efischer19
[ ] Code review: @nedbat
[ ] DevOps review: @edx/devops

FYI: @muzaffaryousaf
Post-review

[ ] Squash commits

This seems like a big enough change that the version in the setup.py file should be updated.  Any chance we can push this to PyPI as well when this work is complete?

@feanil: I will version bump it.
There's a bit more work to get it to a decent state for making it publicly available, though.  It has hidden dependencies that edx-platform takes care of, and the tests expect a fair amount of context that edx-platform provides (extra virtualenvs, apparmor configuration, installed test dependencies, etc.)  I'll look into cleaning things up, and see how it goes.

Just a few small issues. Biggest one is the error delineation during safe_exec that we discussed in-person.
I think getting the dependencies in place is definitely needed before this gets put out on PyPI - apparmor in particular is something that is vital to reduce security holes that would otherwise be wide open.

@jcdyer ping me when you are ready for review.

Pass complete.

I moved the new Jail object & associated configuration code to jail.py, so jail_code and safe_exec just contain their wrapper functions & backcompat imports.
Autoconfiguration at import time has been removed
"python" jail configuration has been added to tests to make up for the previous point.
setup.py has been expanded to make the app more pip-friendly

Ready for another round of review

Note that tests are not getting automatically run. I've been able to run the codejail tests on devstack with the following steps.

Log in as edxapp
Checkout out the appropriate branch (at ~edxapp/venvs/edxapp/src/codejail),
Log back out to the vagrant user
$ source ~edxapp/venvs/edxapp/bin/activate
$ cd ~edxapp/venvs/edxapp/src/codejail
$ make test

FYI @edx/testeng

👍  from me, looks great!

@jcdyer How much work would it be to get this repo's tests running on travis? Could you absorb that in TNL-4843?

I'm done with my review.  Only a few things that I think need tweaking.

@nedbat: I've responded to your review, and made necessary changes.  Please take another look.

@jcdyer the changes look good, as I knew they would. The requirements are the only thing left I think. Once resolved, I am good for merging. :+1:

@feanil I've finished responding to code reviews.  Is there anything else you want done before I merge it?  Version is bumped to 1.0 (should it be 1.0.0?), and after merge, I'll tag the master branch (as v1.0.0 or v1.0).  Once all that's done we can talk about PyPI and updating edx-platform.

Result of test run at latest commit:
(edxapp)vagrant@precise64:/edx/app/edxapp/venvs/edxapp/src/codejail$ make test
Running all tests with no proxy process
CODEJAIL_PROXY=0 nosetests
........................S........SS..............................
----------------------------------------------------------------------
Ran 65 tests in 7.617s

OK (SKIP=3)
Running all tests with proxy process
CODEJAIL_PROXY=1 nosetests
........................S........................................
----------------------------------------------------------------------
Ran 65 tests in 17.956s

OK (SKIP=1)

@jcdyer I've done a pass, generally favorable with a few questions/nits.

@e0d: I think I've responded to everything at this point, either with updates, explanations, or a jira ticket.
Is version='1.0' good for the version bump, or should it be 1.0.0?  Should the github tag be v{version} or just {version}?

Squashed, ran tests, merged, then tagged as 1.0.


Make number of nodes configurable

This relates to #2
In order to have my dev/test environment closer to production, it would be super helpful to have a similar number of masters and replicas.
In order to keep it totally compatible with previous versions, it should assume default values as the ones that are currently hardcoded
Thanks for the great work on this lean docker image for bootstrapping quick clusters :)

Relevant PR has been merged, closing this issue. Thank you again @viniciusd for providing this addition to this repo.


Bind EditorExportPlugin::_get_export_features

The function was added in #70377 and setup for implementation by scripts, but the bind was missed.
(There also seems to be an issue where the added features do not show up in the features tab, but the fix appears to not be very easy and quickly run into circular requirements of what function needs to be called first)

Thanks!


installation doesn't work

i am following https://github.com/kubecost/cost-model/blob/master/deploying-as-a-pod.md set prometheus svc as per the instructions but got below error, my prometheus service runs on 9090 but the pod seems looking for 80
F0223 12:48:57.621590       1 router.go:839] No valid prometheus config file at prometheus.monitoring.svc.cluster.local. Error: Get prometheus.monitoring.svc.cluster.local/api/v1/status/config: unsupported protocol scheme "" . Troubleshooting help available at: http://docs.kubecost.com/custom-prom#troubleshoot

then changed the service url as prometheus.monitoring.svc.cluster.local:9090, then got different error:
F0223 12:49:34.223550       1 router.go:839] No valid prometheus config file at prometheus.monitoring.svc.cluster.local:9090. Error: Get prometheus.monitoring.svc.cluster.local:9090: unsupported protocol scheme "prometheus.monitoring.svc.cluster.local" . Troubleshooting help available at: http://docs.kubecost.com/custom-prom#troubleshoot

finally i made prometheus service listen on port 80, and used the url as prometheus.monitoring.svc.cluster.local, still similar error:
F0224 03:10:23.660366       1 router.go:839] No valid prometheus config file at prometheus.monitoring.svc.cluster.local. Error: Get prometheus.monitoring.svc.cluster.local/api/v1/status/config: unsupported protocol scheme "" . Troubleshooting help available at: http://docs.kubecost.com/custom-prom#troubleshoot

these instructions suggest to provide existing prometheus url but on the other hand your doc http://docs.kubecost.com/custom-prom#troubleshoot says
Note: integrating with an existing Prometheus is only supported under Kubecost paid plans.

so there is an issue while deploying the app also confusion about the github doc says different and the troubleshooting says different

It looks like you may be missing the protocol (e.g. http://) on your address?
You can verify you have right address by curling <your_prometheus_url>/api/v1/status/config and making sure you get a Prometheus config file.
The free Kubecost commercial product has all of this bundled together for you: http://kubecost.com/install.
I0224 04:12:40.989023       1 awsprovider.go:534] Finished downloading "https://pricing.us-east-1.amazonaws.com/offers/v1.0/aws/AmazonEC2/current/index.json"

Glad we got that resolved... none of these logs look concerning to me. Most of these are related to optional functionality, e.g. accessing any reserved instance pricing.

looks like it didnt start until https://pricing.us-east-1.amazonaws.com/offers/v1.0/aws/AmazonEC2/current/index.json 1.2G file got downloaded
Also you need to remove the hardcoded namespace from kubernetes/cluster-role-binding.yaml


NUM_WORDS 10000 => 1000 due to memory limit

Thanks @chris-chris. :)
It really exceed colab memory limit, because this notebook doesn't catch up en version. :(
LGTM!


failOnCVSS doesn't fail

When adding the flag to fail when certain severity issues are found, the npm job doesn't fail. An error is thrown, but the npm job exit code is still a success (0).
My set up is as follows in order to reproduce:
package.json
{
  ...
  "scripts": {
    "owasp": "owasp-dependency-check --scan package-lock.json -f HTML JSON --failOnCVSS 8"
    ...
  },
  ...
  "dependencies": {
    ...
    "owasp-dependency-check": "0.0.21",
  }
  ...
}

When I run the below command, the get the following:
npm run owasp
Error: Command failed: /path/to/project/dependency-check-bin/dependency-check/bin/dependency-check.sh --out=./dependency-check-reports --scan package-lock.json -f HTML JSON --failOnCVSS 8 --project="project" --data=/tmp/dependency-check-data

    at ChildProcess.exithandler (child_process.js:308:12)
    at ChildProcess.emit (events.js:315:20)
    at maybeClose (internal/child_process.js:1048:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5) {
  killed: false,
  code: 1,
  signal: null,
  cmd: '/path/to/project/dependency-check-bin/dependency-check/bin/dependency-check.sh --out=./dependency-check-reports --scan package-lock.json -f HTML JSON --failOnCVSS 8 --project="project" --data=/tmp/dependency-check-data'
}

And when I check the exit code with echo $?, I get:
% echo $?
0

As a note, when I run the same command with the failOnCVSS parameter, it all runs cleanly. And the report that generates does show critical vulnerabilities that SHOULD be causing the execution to fail

I cannot reproduce this. Could you provide more information?

the package-lock.json for which this fails
what version of Node/NPM are you using?
what version of java are you using?

Hi,
I have the same error and it is so simple reproduce the case.
Run
npm install ng @angular-architects/module-federation owasp-dependency-check
npx owasp-dependency-check --nodePackageSkipDevDependencies --log file1.log --failOnCVSS 7
echo $?

The owasp-dependency-check fails with error 15 (you can see in console) but the echo $? returns 0.
I have node16 and java 8 but I can reproduce it with node18 and java17.
I suppose that the problem (in current implementation) is in the "exec" command, it is asynchronous  and it does not propagate the error


Inheriting from AutonomousBase5459 doesn't work

As reported by @clydeBruckman...

I think recently we nixed Base though. Didn't play well if you defined methods in Base and called them elsewhere (even with an import).

This sounds like an issue with Android Studio (or possibly a file naming issue). Java should just handle this.
I plan on investigating this tomorrow (2016-01-28).

WIP (see commits 3f20964 and bd94bf1) - seems to inherit okay in Android Studio. Will test when hardware is ready.

Seems to work okay now. Closing the issue.


Activating Open Collective

Hi, I'm making updates for Open Collective. Either you or another core contributor signed this repository up for Open Collective. This pull request adds financial contributors from your Open Collective https://opencollective.com/hyperglass ❤
What it does:

adds a badge to show the latest number of financial contributors
adds a banner displaying contributors to the project on GitHub
adds a banner displaying all individuals contributing financially on Open Collective
adds a section displaying all organizations contributing financially on Open Collective, with their logo and a link to their website

P.S: As with any pull request, feel free to comment or suggest changes.
Thank you for your great contribution to the Open Source community. You are awesome! 🙌
And welcome to the Open Collective community! 😊
Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other Open Source sustainers!

Thanks, but I prefer to stick with the GitHub sponsor button for now.


freesweep: use fetchFromGitHub instead of fetchurl as per #32997

Motivation for this change
#32997
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)

no change

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build freesweep

Success on x86_64-linux (full log)
Attempted: freesweep
Partial log (click to expand)
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dd2albgk0glfj5cr9023x1zgmr29nk2d-freesweep-1.0.1
shrinking /nix/store/dd2albgk0glfj5cr9023x1zgmr29nk2d-freesweep-1.0.1/bin/freesweep
gzipping man pages under /nix/store/dd2albgk0glfj5cr9023x1zgmr29nk2d-freesweep-1.0.1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dd2albgk0glfj5cr9023x1zgmr29nk2d-freesweep-1.0.1/bin
patching script interpreter paths in /nix/store/dd2albgk0glfj5cr9023x1zgmr29nk2d-freesweep-1.0.1
checking for references to /build in /nix/store/dd2albgk0glfj5cr9023x1zgmr29nk2d-freesweep-1.0.1...
/nix/store/dd2albgk0glfj5cr9023x1zgmr29nk2d-freesweep-1.0.1

Success on aarch64-linux (full log)
Attempted: freesweep
Partial log (click to expand)
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7xn3416danyrhjckqxxqc7rknrgibhkg-freesweep-1.0.1
shrinking /nix/store/7xn3416danyrhjckqxxqc7rknrgibhkg-freesweep-1.0.1/bin/freesweep
gzipping man pages under /nix/store/7xn3416danyrhjckqxxqc7rknrgibhkg-freesweep-1.0.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7xn3416danyrhjckqxxqc7rknrgibhkg-freesweep-1.0.1/bin
patching script interpreter paths in /nix/store/7xn3416danyrhjckqxxqc7rknrgibhkg-freesweep-1.0.1
checking for references to /build in /nix/store/7xn3416danyrhjckqxxqc7rknrgibhkg-freesweep-1.0.1...
/nix/store/7xn3416danyrhjckqxxqc7rknrgibhkg-freesweep-1.0.1

Thanks :+1:


memento-mori-string not displaying in frame title

I have set the following customizations:
memento-mori-display-in-modeline to nil and
memento-mori-display-in-frame-title to t
I assumed the string would be appended or prepended to the existing frame title but instead it clobbers the existing title and nothing is shown though a tooltip suggests the frame title is "Untitled window".

Hmm.  I tried it on my Mac and it worked there.  You do have to turn it on before turning on memento-mori-mode (or try toggling memento-mode).  I wonder if I can change that at least when set via customize...
What's the value of frame-title-format?

or try toggling memento-mode

No, that did not work for me though memento-mori-string is a non empty string.

What's the value of frame-title-format?

After toggling the mode:
(memento-mori--frame-title-construct :eval
                                     (if
                                         (buffer-file-name)
                                         (abbreviate-file-name
                                          (buffer-file-name))
                                       "%b"))

Hopefully this should be fixed, but feel free to reopen if not.  I'm a little worried that format-spec has changed in newer versions or something.  I build Emacs from master periodically.

Still not working for me. Now frame-title-format is:
(:eval
 (if
     (buffer-file-name)
     (abbreviate-file-name
      (buffer-file-name))
   "%b")
 memento-mori--frame-title-construct)

I presume for you, you had not already configured frame-title-format?

You're right.  I had a string for frame-title-format.  The problem is that you have a list, but it's really a single construct.  I wonder if it's always safe to just wrap it in another layer of list (seems to be in my very limited experimentation).  Or maybe it's best to just tell users how to add it manually?

If I manually set this variable as follows it displays as expected.
((:eval
  (if
      (buffer-file-name)
      (abbreviate-file-name
       (buffer-file-name))
    "%b"))
 memento-mori--frame-title-construct)

Notice, I've wrapped the :eval sexp in parentheses.
(Aside, if I view this variable using describe-variable I see something like the above. However, if I look into my custom file it appears as follows:
 '(frame-title-format
   '(:eval
     (if
         (buffer-file-name)
         (abbreviate-file-name
          (buffer-file-name))
       "%b")) t)

Not sure where the t symbol at the end comes from.)

The extra t is for custom-set-variables.  It's the NOW portion though to be honest, I'm not entirely sure it does.


Update russian verbs

@neauoire I wrote to you on Twitter from my account. I would be grateful if you read!

Ah! Thank you for the fixes.
I don't check my twitter a lot, I mostly check Mastodon and my emails, would you like to send me your message by email<EMAIL_ADDRESS>


Two Pointer Method in C ++

🚀 Feature
(A clear and concise description of what the feature is.)
Have you read the [Contributing Guidelines on Pull Requests]
(https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTING.md#reporting-new-issues)?
Yes
Motivation
(Please outline the motivation for the proposal.)
Two pointers is really an easy and effective technique which is typically used for searching pairs in a sorted array.
Pitch
(Please explain why this feature should be implemented and how it would be used.)
Given a sorted array A, size of N ( N elements) and a target value X, find if there exists any pair of elements in the array such that their total sum is equal to X.
We can solve this by using Two pointers Method.
Two pointers Method is a method where one pointer starts from beginning and other from the end and they proceed towards each other simultaneously.

/assign


Fixing equinox and epoch in database

The implementation of equinox and epoch in the database were backwards. I had equinox as the decimal year and epoch as the string designation of the equinox (ie, B1950, J2000). This swaps and also sets epoch in the Photometry table to have the same Float type as in the Sources table.
Fortunately, we have no data yet for either of these so no updates needed for the individual JSON output.

We should document our standard for this (see #83 ), but merging this in the meantime.


ControlType.multiselect doesn't seem to work

Problems setting ControlType.multiselect
just changed type = ControlType.multiselect in the code from Upload files in nodes #13
`
def file_selector(infile):
return infile
file_selector_control = Control(
type= ControlType.multiselect,
name="file_selector",
label="Select a File",
options=[
# List your files in here. Create this dictionary from the uploaded files.
{"value": "file1.txt", "label": "this is file 1"},
{"value": "file2.txt", "label": "this is file 2"},
],
)
file_selector_port = Port(
type="file_selector",
name="infile",
label="Select File",
controls=[file_selector_control],
)
file_selector_node = Node(
type="file_selector",
label="File Selector",
method=file_selector,
inputs=[file_selector_port],
outputs=[file_selector_port],
)
fconfig = Config.from_function_list(
all_functions,
extra_nodes=[file_selector_node],
extra_ports=[file_selector_port]
)
`
Generates error in browser: Cannot read properties of undefined (reading 'length')

There was a bug which is fixed now. Give it a try.


[feature request] generate migrations from scheme

I know that some DB alterations can be complex and need manual work, but most of the time its small things. So why can't we do this other way around - change scheme, cli check for alterations and generates and migration?

This feature has been requested in the past, and isn't something we're interested in adding to Diesel. We prefer the workflow of writing your migrations, and generating your schema from that.


Problem with repository injection

Hi,
I'm trying out your package. It seems that for @Transactional to work all database access should be done using repositories (and not via EntityManager, correct me if I'm wrong).

So I replaced those with repositories injection (each repository gets injected with any other repository it needs).
But this didn't work. Looking at the value of the injected repository in a debugger it is not of the repository type at all, but rather of type EntityManager. I guess I'm doing something wrong here but I don't know what.
Thanks

Hi,
Did you try patching repository with base repository?
https://github.com/odavid/typeorm-transactional-cls-hooked#patching-typeorm-repository-with-baserepository

Yes, I'm calling it

Maybe this will help:

https://github.com/odavid/typeorm-transactional-cls-hooked/issues/29
Or this one
https://github.com/odavid/typeorm-transactional-cls-hooked/issues/30

Other than that, it will be hard for me to understand what is wrong

Hi, It's not an issue with your package, it's an issue with nestjs/typeorm. It is not possible to inject repositories into other repositories :(

Thanks for letting me know. Can we close the issue?

yes


Add outbound notifier

just like completed trade notifier but for outbounds

Personally, I oppose this just because since trade bots go so fast, it’d get very spammy.

Personally, I oppose this just because since trade bots go so fast, it’d get very spammy.

There was no real reason to close this. Just because one person doesn't like a toggleable feature, doesn't mean it shouldn't be implemented.
Thanks to the way Horizon is programmed, I can implement this in about 5 extra lines, and 3 other line slight alterations. This will be implemented.


feat: Base64

Feature Request
Describe the Feature Request
Base64 encode and decode function

I can finish writing the base64 library


Add utility to parse duration string into ms

Resolves # .
Description

What is the purpose of this pull request?

This pull request:

adds a utility function to parse duration string into milliseconds

Related Issues

Does this pull request have any related issues?

This pull request:

resolves #
fixes #

Questions

Any questions for reviewers of this pull request?

Requesting review of README.md before rolling out implementation.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.
Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

This package is now ready for review.

The only other thing I'd recommend is changing the description to
Convert a duration string to milliseconds.

The language about "parsing a duration string" is not necessary and can be more succinctly subsumed as part of conversion.

All changed!


sandbox: only allow local network operations

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

This PR is an attempt to restrict network operations in the sandbox (for build, postinstall and test) to just local network operations. The sandbox rules were inspired from: https://github.com/bazelbuild/bazel/blob/4d62c8f7557a4673ffe5600f963fdfddd7b99d3b/src/main/java/com/google/devtools/build/lib/sandbox/DarwinSandboxedSpawnRunner.java#L300-L302
This might have to be modified a bit and may cause problems with a bunch of formulae too, so further testing will be required. CC @woodruffw.

This will definitely break a lot, including all formulae that uses a language package manager (npm, cargo, etc.) as we don't use resources for those with sufficient lockfiles.

Based on a short discussion with Mike, we thought it might be good have a separate fetch block/phase which does have network access but restricted write permissions. This would just download all these dependencies to the cache and then the install phase would be able to use these. I'm going to spend some time to try and implement that if it makes sense.


Re-up TTL when opening an existing session

When reading the description of expirationTime, it says "The duration without access after which a session expires." To me, this means if you continue to "access" the session, it resets the duration. However, in the implementation, it only sets the TTL once, when the session is created. This means that accessing it does not re-up the timeout.
This fixes that, so now every time you open the session, it also resets the timeout. This is what I would expect session expiration to mean.

Definitely the right behavior!


Binding events with jQuery

Is there a way to bind events with jQuery .on()?
It would be helpful to have an example on http://mediaelementjs.com/ beside the Javascript way.

@szepeviktor you can bind events in the success function:
$('#player1').mediaelement({
   ...
   success: function(media, player) {
      media.on('play', function() {
           // Your code here
      });
  }
})

Thank you.
Could it be added to http://mediaelementjs.com/ ?

@johndyer Is this something we can add to http://mediaelementjs.com/ ?


AVRO-3254: Automatically scale up or down decimal values when serializing

Make sure you have checked all steps below.
Jira

[X] My PR addresses the following Avro Jira issues and references them in the PR title.

https://issues.apache.org/jira/browse/AVRO-3254

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:

TestDecimalScalesDown
TestDecimalScalesDownToZero
TestDecimalScalesUp
TestAvroDecimalReScaling (65 test cases)

Commits

[X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[X] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain ~Javadoc~ xml doc that explain what it does

Hello!  I have a quick concern about this PR -- modifying the scale of an AvroDecimal makes it no longer equal to its old value, so the serialize/deserialize would make the datum, or any record containing the datum (for example), no longer equal to its original value.
I would be worried that this would have some unexpected side effects.  Any thoughts?
We should take a look at what the other SDKs are doing.


Wrong screengrab in 'Find the Disk' section on 'Use the portal to attach a data disk to a Linux VM'

It looks like the wrong screengrab has been used in the 'Find the Disk' section. Immediately after the text 'For a more complex example, here is what multiple data disks looks like in the portal:'. The text says that the image shows a configuration with 3 data disks with different LUNs, but the image shows just one - the same image as is used further up the page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6fde1939-787d-2aa5-4b29-d303f8ed49cb
Version Independent ID: c2838cb5-c34c-e0ff-b280-b86f29453cad
Content: Attach a data disk to a Linux VM - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/attach-disk-portal.md
Service: virtual-machines
Sub-service: disks
GitHub Login: @cynthn
Microsoft Alias: cynthn

@dtopham75
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@cynthn
Can you please check and add your comments on this doc update request as applicable.

@dtopham75 Good catch! The correct graphic was in the repo, but the wrong link was used. Doc has been updated and the fix should be live after 3:00 PM PST today. Thanks again!


Build of Python binding movetk_geometry.cpp fails on Ubuntu 18.04

make fails with the following error
[ 98%] Building CXX object py/CMakeFiles/movetk_geometry.dir/movetk_geometry.cpp.o
/home/runner/work/movetk/movetk/py/movetk_geometry.cpp:44:16: error: expected constructor, destructor, or type conversion before ‘(’ token
 PYBIND11_MODULE(movetk_geometry, m) {

Pybind11 is of an older version as available from the package manager of  Ubuntu 18.04
Possible option is to add Pybind11 as a submodule with MoveTK.
As an alternative, we changed the GitHub workflow runner to ubuntu-20.04  where it builds without problems


Upgrade katex

katex v0.8.3 has been released and includes some features which I would like to have, such as old-style font commands (like \rm).
I haven't done any testing of the new version of katex in zulip.

@PentaHiggs FYI, this may be a relatively quick project for you since you're in that code.

@timabbott Sure, I wouldn't mind taking care of it!  Is there anything I should look out for in particular?

@zulipbot claim

Not that I'm aware of.

I guess the one thing that may help is zulip.readthedocs.io/en/latest/dependencies.html, and in particular that you will probably want to run yarn install to update yarn.lock.


Remove redundant description of finalizers

Remove redundant information about finalizers on the finalizers page within the "working with objects" section.
The same description of finalizers is imported directly from the glossary, so previous to this commit a nearly identical paragraph is repeated.
For reference, the text imported from the glossasry is

You can use finalizers to control garbage collection of resources.
For example, you can define a finalizer to clean up related resources
or infrastructure before the controller deletes the target resource.

while the text being removed in this commit is:

You can use finalizers to control garbage collection of resources
by alerting controllers to perform specific cleanup tasks before
deleting the target resource.

Note that this PR updates both the english and chinese versions.

Ok, I've split this up into #40196 (English) and #40197 (Chinese), and I'll close this PR. Sorry about that!


not working on Debian Stretch

Hi, how is the progress of ev3dev-lang-python for Debian Stretch?
I'm using images that descend from the ev3dev-stretch-ev3-generic docker builds on ev3 bricks.
When starting robertlab I get a File not found error since it tries to use /dev/input/by-path/platform-gpio-keys.0-event, which apperently got replaced by /dev/input/by-path/platform-gpio_keys-event.
Since both linked to /dev/input/event0 I can simply add that file, but then I get another error:
INFO:roberta:--- starting ---
INFO:roberta.lab:python path: /usr/bin:/usr/lib/python35.zip:/usr/lib/python3.5:/usr/lib/python3.5/plat-arm-linux-gnueabi:/usr/lib/python3.5/lib-dynload:/usr/local/lib/python3.5/dist-packages:/usr/lib/python3/dist-packages

INFO:roberta.lab:status changed: disconnected
Traceback (most recent call last):
  File "/usr/bin/openrobertalab", line 41, in <module>
    main()
  File "/usr/bin/openrobertalab", line 36, in main
    service = Service('/org/openroberta/Lab1')
  File "/usr/lib/python3/dist-packages/roberta/lab.py", line 88, in __init__
    self.hal.clearDisplay()
  File "/usr/lib/python3/dist-packages/roberta/ev3.py", line 179, in clearDisplay
    self.lcd.update()
  File "/usr/lib/python3/dist-packages/ev3dev/core.py", line 3135, in update
    self.mmap[:] = self._img.tobytes("raw", "1;IR")
IndexError: mmap slice assignment is wrong size
INFO:roberta:--- done ---

I opened an issue on the robertalab repo, but @ensonic told me this needs to be updated first before he can do anything.

Related to #381

Ah, sorry. Completly missed that one

Yeah, we're currently working on an initial Stretch release. I'm hoping to get that out for testing within a week or two at most. Until then, you'll either have to download a work-in-progress version of the library for use temporarily or use ev3dev-jessie.

See PR #400 (assigning to Denis)

Any objections to closing this one? We have pretty good stretch support now.

Yeah, I think we're good to close this.


Revert "DNN-3000: add enable/disable cache expiration api."

this needs to be reverted as the fix should have been done in the 8.0.0 branch

Can this item be made public? I can't see any details on DNN-3000 in jira


Documentation suggests data is sent over the open Internet decrypted

The section titled "Data-link Layer encryption in Azure" contains the following sentence.

The packets are encrypted and decrypted on the devices before being sent, preventing physical “man-in-the-middle” or snooping/wiretapping attacks.

This could be misunderstood as data is being sent decrypted over the open Internet. A possible fix is removing "and decrypted."

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 16c7901b-497c-38bd-3615-defab17b572b
Version Independent ID: 9855d796-3469-8be5-c9a7-75516d9b8856
Content: Azure encryption overview
Content Source: articles/security/fundamentals/encryption-overview.md
Service: security
Sub-service: security-fundamentals
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@StarfieldExplorer
Thanks for your feedback! We will investigate and update as appropriate.


Potential O(n) lookup of dynamic effects?

When a dynamic effect is interpreted, the Env is forked (which is O(1)). This means with every extra handler, previous handlers are one layer deeper in the Forks structure. Therefore time of access to these handlers increase linearly, hence O(n) lookup. Of course, this does not apply to static dispatch.
Considering the number of effects on an effect stack typically won't be large, I'm not sure if this is a serious problem in practice. Maybe I'll construct an edge case benchmark later. But at least, Env is not amortized O(1) in worst cases.

But at least, Env is not amortized O(1) in worst cases.

The complexities are here.

This means with every extra handler, previous handlers are one layer deeper in the Forks structure.

Yes, but that only affects the environment inside the handler. As an example let's consider the environment portrayed here:
e00 - e01 - e05 - e07 (*)
       |     |     |
       |    e06   e08 - e09
       |
      e02 - e03
             |
            e04

the environment seen by (each bracket is a fork):

the handler of e03 is [e00][e02][e04]
the handler of e01 is [e00][e02, e03]
the mainline is [e00, e01, e05, e07] (the mainline never has forks).

So in two most common cases (sending an operation from the mainline or sending an operation of the reinterpreted effects from the effect handler) the dispatch is O(1).


chore(migration): migrate from older project - part 1

[x] init rollup
[x] create test
[x] setup coverage
[x] setup doc generation
[x] finalize TravisCI

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Java checking is not run asynchronously

Checking java files is really slow sometimes
Expected behavior
Checking Java files should be async.
Steps to reproduce

Use this .vimrc (install vim-plug if not installed):

call plug#begin('~/.vim/plugged')
Plug 'benekastah/neomake'
call plug#end()

syntax enable

Clone a large java project (ex. https://github.com/spring-projects/spring-framework)
Open a Java file
Run :Neomake
Get a cup of coffee
Come back to a linted java file

Profile.log:
https://gist.github.com/marcusbuffett/fdcb92bde17f5117827fe26c55c89464
Output of the ":verb NeomakeInfo" command
Neomake debug information
Async support: 1
Current filetype:
Enabled makers
For the current filetype (with :Neomake): None.
NOTE: the current buffer does not have a filetype.
For the project (with :Neomake!): None.
NOTE: you can define g:neomake_enabled_makers to configure it.
Default maker settings:

remove_invalid_entries: 0
buffer_output: 1

Settings
g:neomake_place_signs = 1

shell: /usr/local/bin/zsh
shellcmdflag: -c
Windows: 0

:version

NVIM 0.1.7
Build type: RelWithDebInfo
Compilation: /usr/local/Homebrew/Library/Homebrew/shims/super/clang -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -g -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -I/tmp/neovim-20170123-76107-bty46t/neovim-0.1.7/build/config -I/tmp/neovim-20170123-76107-bty46t/neovim-0.1.7/src -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/opt/gettext/include -I/usr/include -I/usr/include -I/tmp/neovim-20170123-76107-bty46t/neovim-0.1.7/build/src/nvim/auto -I/tmp/neovim-20170123-76107-bty46t/neovim-0.1.7/build/include
Compiled by<EMAIL_ADDRESS>
Optional features included (+) or not (-): +acl   +iconv    +jemalloc +tui
For differences from Vim, see :help vim-differences

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/0.1.7/share/nvim"

:messages
"profile.log" 2715L, 154881C

Col 1 of 14; Line 1102 of 2715; Word 4164 of 10836; Char 64816 of 154879; Byte 64816 of 154881
search hit BOTTOM, continuing at TOP
2715 lines yanked
NVIM 0.1.7
Build type: RelWithDebInfo
Compilation: /usr/local/Homebrew/Library/Homebrew/shims/super/clang -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -g -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -I/tmp/neovim-20170123-76107-bty46t/neovim-0.1.7/build/config -I/tmp/neovim-20170123-76107-bty46t/neovim-0.1.7/src -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/opt/gettext/include -I/usr/include -I/usr/include -I/tmp/neovim-20170123-76107-bty46t/neovim-0.1.7/build/src/nvim/auto -I/tmp/neovim-20170123-76107-bty46t/neovim-0.1.7/build/include

Only skimmed it, but https://github.com/neomake/neomake/issues/875?

Oops, sorry, should have searched more before submitting a new issue, closing.


Merge from vscode f4c95d5b9cfb2265f1730d564df1709533eff55e

[10:23 PM] ads-merger
https://www.github.com/Microsoft/vscode/commit/f4c95d5b9cfb2265f1730d564df1709533eff55e Rneder search editor label as soon as possible.
https://www.github.com/Microsoft/vscode/commit/36f56c64484647123e49ed517583315f82186efd Remove unused
https://www.github.com/Microsoft/vscode/commit/7396b1b82b38d0af6964de3abd7b8faf3a0b5b60 Persist match highlights on modify->reload
https://www.github.com/Microsoft/vscode/commit/49816c05a6782a67bca97094d154543c0dfc856f Fix scroll state restore
https://www.github.com/Microsoft/vscode/commit/a1e96279c0043b62fc82c2d242b728ecb61342bc Remove 'only' whoops.
https://www.github.com/Microsoft/vscode/commit/10a44bde1071da718d5afde1e0adc09bac92e19b Fix https://www.github.com/microsoft/vscode/issues/90432.
https://www.github.com/Microsoft/vscode/commit/87924f69b28be03507338da14e91ef0c7a3fcf07 Dont offset matchRanges by header. Fix https://www.github.com/microsoft/vscode/issues/90471.
https://www.github.com/Microsoft/vscode/commit/10f09c7e246d5aa245d27543f6781cf29a35a397 Better state resetting on new search. Fixes https://www.github.com/microsoft/vscode/issues/90490.
https://www.github.com/Microsoft/vscode/commit/d5aaab5603a20b4faaf8a5fe711b478314ec241b Move things around to maybe not have distro merge conflict
https://www.github.com/Microsoft/vscode/commit/ebb00abdac8195ea193c3a01740f533553c15c40 Skip hokeyapp stage. https://www.github.com/microsoft/vscode/issues/90491.
https://www.github.com/Microsoft/vscode/commit/dbe5572789d2241f536b4b2801dff5cd8ef46a0c Fixing another strict function error
https://www.github.com/Microsoft/vscode/commit/760cb13de8205deb4131581b399f5d71830f9dce Fixing doc comment for new api
https://www.github.com/Microsoft/vscode/commit/fb622a8b83c3f9fb661f7a86ffb89ccb6a2b0581 Move code action documentation contribution point to come from metadata
https://www.github.com/Microsoft/vscode/commit/7a1ab294272924494ecf6d714955963e9c209917 More strict function fixes
https://www.github.com/Microsoft/vscode/commit/efb781e5becac763a91e7a7434aaef671b38d9a9 Marking that documents/workspaces arrays cannot be mutated
https://www.github.com/Microsoft/vscode/commit/498deeb4bc327bdc8f48753521823c9e826931fd Skip flakey debugging test
https://www.github.com/Microsoft/vscode/commit/8d8b1b5074ab9c8ae303b18c85275b29da5cbcf5 update default setting
https://www.github.com/Microsoft/vscode/commit/4978f52ec8d56ae52809b6a3683b80e4144bdf50 Flaky test: active editor not always correct... (https://www.github.com/microsoft/vscode/issues/90470)
https://www.github.com/Microsoft/vscode/commit/47813a3e400a91ea6f9bcb2279cf5a2afc7128f6 run and debug views can move refs https://www.github.com/microsoft/vscode/issues/90468
https://www.github.com/Microsoft/vscode/commit/543b36d97ec3b8a02225497788edf31a23762cad debug: update js-debug-nightly to "2020.2.517" @ 2020-02-11T01:06:42.083Z
https://www.github.com/Microsoft/vscode/commit/dfee3a04c6aa626de51811e3736a9205ecd1b642 do not touch path if sourceReference > 0
https://www.github.com/Microsoft/vscode/commit/35379aba75fb592560f56eaca38f43e13336c611 smoke - headless option is troublesome
https://www.github.com/Microsoft/vscode/commit/06b06ca10a3131efaa70890c52333c82bfc713c5 smoke - move quick open tests into search
https://www.github.com/Microsoft/vscode/commit/b7a29c77ef4e350c1e03eece4351ffc57eea1d5f tests - document and enable debug mode for integration tests
https://www.github.com/Microsoft/vscode/commit/e399df944e931f103fc0174a8396b647b3e1d6c2 Merge branch 'master' of https://github.com/microsoft/vscode
https://www.github.com/Microsoft/vscode/commit/bd57fb1119211c16f7478ad7a60e687883112b3d refs https://www.github.com/microsoft/vscode/issues/81574
https://www.github.com/Microsoft/vscode/commit/c4303d1a5bb42f74f653598e707098069c74a07e build - remove smoke tests from product builds
https://www.github.com/Microsoft/vscode/commit/a42d26dc71e233e27776f9812b2b72ea6740cea8 Merge branch 'joao/empty-views'
https://www.github.com/Microsoft/vscode/commit/357f4332204b93ac779bed4ae832455451cc1068 Open Editors: "Close All Editors" does not close all editors (fix https://www.github.com/microsoft/vscode/issues/90456)
https://www.github.com/Microsoft/vscode/commit/a1de4faf43b7014a08dc7993b32cbabcfe550834 Merge branch 'joao/grid-boundary-sashes'
https://www.github.com/Microsoft/vscode/commit/8a1632a5dcf26577f081993a68590e98f15800c0 Merge pull request https://www.github.com/microsoft/vscode/issues/90101 from microsoft/tyriar/75793
https://www.github.com/Microsoft/vscode/commit/39370d9c988c584fa2e834728d8ffa56259ff1ad tests - skip another flaky one for web
https://www.github.com/Microsoft/vscode/commit/e187656025c24ebf83bc2d4fa7940f9aeea3cbd3 untitled - some cleanup and polish
https://www.github.com/Microsoft/vscode/commit/44b029124f24badccc8cf39af90eda4541ea5046 untitled - do not update model with initial value if existing
https://www.github.com/Microsoft/vscode/commit/26510e7c158fa41170f170d45cc8642fa1741402 Make Terminal.exitStatus stable API
https://www.github.com/Microsoft/vscode/commit/997e4eaf740bb4310fea160f06de2c6256f12f7d Fix strict function types in ext term
https://www.github.com/Microsoft/vscode/commit/a8247add3b234817da1c3d71120c79e9ad99ea7e update-distro
https://www.github.com/Microsoft/vscode/commit/5608bb8185c3fced4da80daff42abf0d932b8186 Fix https://www.github.com/microsoft/vscode/issues/90440
https://www.github.com/Microsoft/vscode/commit/031bb8e6c3ed2958ccc0160fc9778a18c2c52033 ux tweaks: only have show more / less when there is a good chance of details, https://www.github.com/microsoft/vscode/issues/39441
https://www.github.com/Microsoft/vscode/commit/97cc40b92206fd5f9a6418f68146e5bcae4c6914<EMAIL_ADDRESS>https://www.github.com/Microsoft/vscode/commit/08adc69601fec9eaa70b6a296586181f63628a72 Revert "scm: comment out suggest contribution"
https://www.github.com/Microsoft/vscode/commit/1f6d983291c6279c83b29354a8be93ba0a414acc skip flaky test (https://www.github.com/microsoft/vscode/issues/90440)
https://www.github.com/Microsoft/vscode/commit/24b0894ce0a5fe45f51e1f3f7b9dbc4a566e2d34 untitled - rewrite to work on models and not inputs
https://www.github.com/Microsoft/vscode/commit/4d3d0036f838dc8d252de66e154ba1d67e7c3e6a add asExtensionUri to Extension as well, https://www.github.com/microsoft/vscode/issues/90208
https://www.github.com/Microsoft/vscode/commit/4d0e36d17f43cb6bf73d2e2d434498c8fe0a6c93 skip webview tests (https://www.github.com/microsoft/vscode/issues/88415)
https://www.github.com/Microsoft/vscode/commit/ae78db041438e1f7a80d16e09fec4228a614dfed skip terminal test (https://www.github.com/microsoft/vscode/issues/90437)
https://www.github.com/Microsoft/vscode/commit/2270536e85d0d90038912de75ce984e8a764caaf debug: reanable integration tests (use new node debugger)
https://www.github.com/Microsoft/vscode/commit/a937a1447d301864ce0aebcb0f5787a2f60bff49 Introduce and adopt EditorTheme
https://www.github.com/Microsoft/vscode/commit/d37c59a281a36618494e7613cbb45206867e40f8 Merge pull request https://www.github.com/microsoft/vscode/issues/90419 from jeanp413/fix-90040
https://www.github.com/Microsoft/vscode/commit/926fc23f139e4d1250dba494c6e825e4816e62f6 more strict functions https://www.github.com/microsoft/vscode/issues/81574
https://www.github.com/Microsoft/vscode/commit/1c4f0dd6727626d1fe6bbdfa96a7593f9685c0df use weaker-event definition for cancellation token, https://www.github.com/microsoft/vscode/issues/81574
https://www.github.com/Microsoft/vscode/commit/f4a868fb0dbcf397579cb58fab168049a0448e6c update distro
https://www.github.com/Microsoft/vscode/commit/d60616daa697ee53731be20d24cedab7958e945e fix windows build
https://www.github.com/Microsoft/vscode/commit/7f8efdf5b0aba72ca19a9f67e749e7d8c5b73a1a :lipstick:
https://www.github.com/Microsoft/vscode/commit/02aa3e75e657dc3169609725a362f7fb7aec462a remove smoke test from windows
https://www.github.com/Microsoft/vscode/commit/45bbe4075937895c8122975b672f8cb9225fa82c Merge pull request https://www.github.com/microsoft/vscode/issues/90190 from microsoft/roblou/resolveConflicts
https://www.github.com/Microsoft/vscode/commit/3b2fde6477af4456afec60687dd03578472f9ef2 more strictFunctions https://www.github.com/microsoft/vscode/issues/81574
https://www.github.com/Microsoft/vscode/commit/402a1cb949d305436f8e0b0d35248a2760d45392 some strict function fixes, https://www.github.com/microsoft/vscode/issues/81574
https://www.github.com/Microsoft/vscode/commit/571ad3499b4ca43ab0dcf0c654843524bc7d619e Inherit from BaseTextEditor. Closes https://www.github.com/microsoft/vscode/issues/90326 Closes https://www.github.com/microsoft/vscode/issues/90325
https://www.github.com/Microsoft/vscode/commit/6f1de79b02c15574c5508f2df7afe979f142622f Use editor mementos for view state saving
https://www.github.com/Microsoft/vscode/commit/ff0de753f44db226152535a1c06029aee58017f8 fix $90348
https://www.github.com/Microsoft/vscode/commit/cfa6daa6b9f1396237cc0b2b81cb993715848d62 migrate sync conf only when sync is configured
https://www.github.com/Microsoft/vscode/commit/33855166ef02428ff913e6647a1130db8db4fadb unblock build

Theres a lot of issues with this merge, cause by the changes to untitlededitor stuff. I'll need to investigate before doing a merge.


[Bug] :empty/:not_empty filters not working for SQLite

Summary
:empty and :not_empty filters doesn't seem to be working for SQLite DB
Steps to reproduce
Setup flop for a project with SQLite DB and try to filter a column using :empty op.
Expected behaviour
Columns is filtered normally
Actual behaviour
Query always returns empty list
Elixir/Erlang version
Elixir 1.15.7 (compiled with Erlang/OTP 26)
Elixir 1.16.0 (compiled with Erlang/OTP 26)
Flop and Ecto versions
* ecto 3.11.1 (Hex package) (mix)
* ecto_sql 3.11.1 (Hex package) (mix)
  locked at 3.11.1 (ecto_sql) ce14063a
* ecto_sqlite3 0.14.0 (Hex package) (mix)
  locked at 0.14.0 (ecto_sqlite3) 4f69e5df
* flop 0.24.1 (Hex package) (mix)
  locked at 0.24.1 (flop) aecbacdf
* flop_phoenix 0.22.5 (Hex package) (mix)
  locked at 0.22.5 (flop_phoenix) 6dec7e21

The test is written for main's head
Additional context
I was able to dig it to this point. Consider this test:
    test "applies empty filter" do
      require Flop.Adapter.Ecto.Operators

      field = :species

      d1 = dynamic([r], is_nil(field(r, ^field)) == ^true); d2 = dynamic([r], Flop.Adapter.Ecto.Operators.empty(:other) == ^true)

      assert where(Pet, ^d1) == where(Pet, ^d2)
    end

It would be reasonable to expect those queries to be equal, but they are different:
     left:  %Ecto.Query{
              ...
              wheres: [
                %Ecto.Query.BooleanExpr{
                  ...
                  params: [true: :boolean]
                }
              ]
            }
     right: %Ecto.Query{
              ...
              wheres: [
                  ...
                  params: [true: :any]
                }
              ]
            }

I suspect SQLite adapter might have a different behaviour for true: :any param then postgres, hence the issue.

Thank you for the report. We should probably add more test repos for other adapters than postgrex and automatically run the existing tests on all of those repos. I don't know when I'll get to setting this up, though. Contributions are welcome.


Getting exception on creating cart rule with same name that already exist.

Framework Version: 0.1.6

Framework Version: 0.1.6

Fixed


Added Go starter-kit in README.md

Pull Request Template for New Couchbase Starter Kit Projects

Related Issue:
Please link to the issue your new project addresses:

Issue: Golang Couchbase Starter Kit

Checklist:
Before submitting your pull request, ensure the following items have been completed:

[x] Project Setup: The new starter kit includes a basic setup for the framework.
[x] Connection to Couchbase: The starter kit can establish a connection to either Couchbase Server and Couchbase Capella.
[x] Environment Variables: The .env.sample file has been added with the necessary environment variables, following the template provided in the samples directory.
[x] Deployment Configurations: Gitpod and GitHub Codespaces configurations are provided for easy setup.
[x] Testing: A GitHub Action workflow is included to test the connection to Couchbase.
[x] Documentation: A README.md file is included with setup instructions.
[x] Community Starter Kit Table: A link to the new starter kit has been added to the "Community Starter Kits" section of the Contributing Guide README.

New Project Link:
Please provide the link to your new starter kit in the "Community Starter Kits" section of the contributing guide.
Add the details of your new starter kit to the table below in the following format:
| Framework Name     | [Framework Starter Kit](URL_TO_YOUR_PROJECT) |

Additional Notes:

Please review the Contributing Guide README to ensure your project meets all the required criteria.
Once your pull request is approved, your project will be officially added to the Couchbase community starter kits!

@hummusonrails This PR is ready for your review!
Thanks
Dhairya

Thanks, @Dhairya3124! I'm tagging in my colleagues @ldoguin and @shivaylamba to help with the PR review.


Option 'statusLevels' in errorLogger

For the Error Logging an option 'statusLevels' is described as

different HTTP status codes caused log messages to be logged at different levels (info/warn/error), the default is false

The Option is not working for me and I didn't see an implementation in the code of the errorLogger. Is there a plan to implement this? This would be a very nice feature to have and I'm looking forward to use it when implemented.
Many thanks.

It isn't implemented for errorLogger, it's implemented for the regular logger.
It's sort of implied, I think, that anything that makes it to the errorLogger is in fact an error, so I can't imagine why you'd want to label a log event occurring in the error handler as anything other than an error.

Our usecase for this feature is, to log 4XX as warnings in a logfile and database. All 5XX errors will additionaly sent to our developers with an sms transport. So in case of a 401 NotAuthorised, cause of wrong password or something else the current developer in duty will not interruped in sleeping.

Sure, fair enough.  The 4xx's though won't get through to the error handler unless you're passing them along via next() and then doing your 4xx responses in there.
If you're handling 4xx responses in the router handler itself, the logger should pick them up and mark them as warn as per the statusLevels (and pick up the 5xxs as errors, and do same).  As I understand it, you can set a Transport to essentially 'bind' to a level.
If you're handling them by passing something through next(error) to the error handler - which is something that I'd never considered doing - I'd personally say that's outside the scope of our errorLogger, and you might want to consider implementing a regular Winston logger to log the warnings and dispatch the SMS.
@bithavoc, any thoughts?

Thanks for the hints. I will think about an other solution to solve our requirements.
Maybe the way we are dealing errors is not the best way. We have to consider a better solution for that. In the node environment we're just a little bit half-baked.


Just a couple of small issues

This is on Version 1.1.0.

For the career stats on the player's page, it looks like OPS+ is just an average of the regular season and postseason numbers. It looks like all of the rest of the advanced stats are averaged correctly.

For both career pitching and batting, the advanced stats can't be sorted, like ERA-, OPS+. You can sort on the season stats pages.

Regarding your first point, this is true - I will look into what it'll take to make that a more accurate indicator of the career OPS+. It'll likely just take weighing that number in the average according to the #PA the player had with that OPS+ (which should fix the issue with the few #PA during the postseason being weighed the same)
And regarding your second point, this is something I plan to fix with the next release: #50 . I had some concerns with how to sort by those numbers for the career screen, since it's easier to do so on the season screen when we can just omit the unqualified players from that sort order. I'll need to think on the best way to do this for the career

Based on the way that the career data is being pulled, it should correct the career OPS+ value on the player page, as well as the career batting grids. I'll make sure this is corrected for ERA- (which I need to rename to ERA+) as well

Closing this for now as the OPS+/ERA+/FIP+ career average will have been fixed in v1.1.2, releasing shortly


[Question] Suggestion of an alternative to tablesorter

Hi there!
First of all, awesome work with this fork of bootstrap! Works like a charm :D
I'd like to know if you could recommend an ender-compatible alternative to the jquery tablesorter plugin (which is incompatible with this fork given the absence of jquery.)
The plugin is referred to here: http://twitter.github.com/bootstrap/#tables in the bootstrap documentation.
Thanks! And keep up the good work :D

Sorry but I'm not aware of one. However, it would make a great Ender plugin if you felt like either creating a simple one from scratch or wrapping the current jQuery plugin to get it working in Ender. From the look of the source there isn't a whole lot of complex jQuery dependent code there. If you wanted to have a go at making an Ender compatible version then I'd be happy to lend a hand.
A wrapper work something like that I've done for Bootstrap. Probably the most complicated bit is supporting the use of $.extend and $.fn.extend but you could just pass it a faux-jQuery object with these properties available, like what I've done with feeding bootstrap with a faux-Ender object which has been extended where it needs to be and also has the necessary Ender bits attached to it.

Alrighty, got you :)
I'll give it a shot when my schedule clears up a bit, that would most likely be a good addition! I'll keep you in the loop when I start working on it.
Thanks for the quick answer :D.

This was just put on the Ender wiki: https://github.com/tristen/tablesort with demo here: http://tristen.ca/tablesort/demo/
Would love feedback if you give it a try.

Good find! I'll probably have a bit of time in about 1-1.5 week to test it, I'll be sure to post my review here :).

@rvagg @tristen
Writing this micro-review for anyone who might read it, not specifically targeted at ender-boostrap.
I just took the lib for a spin tonight, took about 1.5 minutes to get up and working. Works like a charm with ender and jquery, very good work overall I must say.
The only "downside" of the plugin is that it completely replaces the classes that are already set on the  fields from the table head, so it can mess up with the styles you might have already put there.
The plugin is also a bit low on feature, it doesn't sort all types of data (dates aren't supported yet for example). I guess it's mostly due to the fact that the lib is new, shouldn't stop someone from using it.
Concerning boostrap 1.4:
As for boostrap 1.4, the name of the classes used by tablesort (.sort-up .sort-down) is different than the ones used by tablesorter (the plugin endorsed by boostrap 1.4 for table sorting), so tablesort won't work with bootstrap 1.4's styles right out of the box.
Concerning bootstrap 2:
Given that tablesorter and table sorting styles were dropped in boostrap 2, there's no real "out of the box" styles that will be applied for sorted columns with tablesort. It's quite easy to add the styles yourself though, took me about 5 minutes.
I'd definitely recommend the lib, one to add in your toolbox if you're an ender-ecosystem person.
That's it!

thanks for that @ovaillancourt, I'll mention some of this in the next Ender Roundup on DailyJS see https://github.com/ender-js/Ender/issues/108

Hey! Awesome :)
@ovaillancourt Thanks for the review!

The only "downside" of the plugin is that it completely replaces the classes that are already set on the
fields from the table head, so it can mess up with the styles you might have already put there.

Will definitely fix this. Its a little intrusive already that it adds classes to the markup but I wanted a sensible way to include sort down/up theming when the click handler is hit. But it should not blow away classes you have already set.
And yeah, I will release a new version to include dates soon. But I do want the features to remain pretty minimal. I've outlined some feature scope in the readme section.

I 100% agree with the "keeping the feature set small", table sort is very well focused right now and it's one of it's greatest strength.  (Especially when compared to tablesorter which is becoming somewhat bloated.)
Good job! :D


Fix bugs after upgrade to EF 7.0

please do not merge this code until the following PR will be accepted
https://github.com/dotMorten/Microsoft.SqlServer.Types/pull/81

This library should use the official Microsoft.SqlServer.Types package.

Also EF Core 7 targets .NET 6

This library should use the official Microsoft.SqlServer.Types package.

but https://www.nuget.org/packages/Microsoft.SqlServer.Types/ only support dot net 4.x

No, the latest version supports .NET Standard 2.1 https://www.nuget.org/packages/Microsoft.SqlServer.Types/160.900.6-rc0#supportedframeworks-body-tab

No, the latest version supports .NET Standard 2.1 https://www.nuget.org/packages/Microsoft.SqlServer.Types/160.900.6-rc0#supportedframeworks-body-tab

Thank you so much

@bricelam
can you publish a new version of this package
we have problem to use rc version with EF 7.0.0

Suggest you update the title and initial comment on this PR - dotMorten lib is not needed, and this is not a bug fix.

New versions have been uploaded to NuGet.org. See #113 for switching to the official SqlServer.Types package


Create Mihir-Raj-Singh.json

Created my profile and added links.

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Thank you for pointing out. I really did miss that one.😄


[T4A7][W11-B4] Charlton Lim

Ready for review

@cadmusthefounder in general you seem to have got the idea of TDD. good!
Some comments added. Please ack & close the PR after reading comments.


Landing Page + Navbar Restyle

Resolves most of #2127

Add lite and classic to Nav dropdown

Adds Classic to current site, Lite will be hardcoded once it's ready (as deployment is already manual for new HELMlets

Model instead of "model/adapter" in leaderboards

replaced everywhere

Mobile, Tablet support

Full tablet (med screen) support
Mobile not working entirely due to an issue with Tailwind's margins; mobile was already not working before and this is an improvement over what was there previously, will need to fix this in a follow-up PR
Demo here: https://github.com/stanford-crfm/helm/assets/39839866/df568aec-f69a-4d09-89ac-c6e9ac4f2869

Move release to top

Done, but not done as we discussed (putting it by Classic/Lite), which would look like this

This approach is weird because it makes the user think clicking the dropdown might affect Release (which it doesn't) and this is bad in terms of UI best practices
This also makes the HELMlet dropdown too messy visually

Instead I separated Version into a separate dropdown (I believe this is useful and works best visually). Alternatively we can add version at the top right where it was previously but again this would contradict our UI's coherence as the rest of the navbar includes clickable links, even if we delineated this visually as separate it would 1) look weird and 2) still not be clickable like the rest of the nav bar.
Open to feedback and other suggestions on this as I only tried a few things as an alternative here, so there may be a better way to do this

"Explore Predictions" -> Predictions in Navbar

Live at https://farzaank.github.io/helm/

Thanks, this is nicer!  The 'Classic' text looks a bit small next to the HELM logo, because it's really "HELM classic' that's toggling, which is not visually clear...perhaps, 'Classic' could be bold / larger?
Also, makes sense about not having the version coupled with 'classic'.  What do you think about having the release number next to classic?  Semantically it makes more sense, but visually, I'm not sure if it will be too cluttered.  Maybe it's okay if it's smaller font?

If we want the version in the navbar, I'd suggest having that be in a lighter grey rather than a smaller font. Though I'd prefer leaving the version out of the navbar entirely.

Thinking a bit more about copy: if we have "HELM Classic: Holistic evaluation of language models", what should be the caption of HELM lite? Will it also be "HELM Lite: Holistic evaluation of language models"?


Add to Readme thelimitation that Controllers that inherit from APIController wont have validation trigger automatically

Validators are not triggered automatically for NET Projects that make use of ApiController attribute and conventions as described here.
This mean that if your controller does not inherit ControllerBase or other controller based classes that are provided out of the box, validators won't get triggered automatically
Issue here: https://github.com/SharpGrip/FluentValidation.AutoValidation/issues/35#issue-2254683309
Code culprit here: https://github.com/SharpGrip/FluentValidation.AutoValidation/blob/master/FluentValidation.AutoValidation.Mvc/src/Filters/FluentValidationAutoValidationActionFilter.cs

Hi @francis04j, could you check out https://github.com/SharpGrip/FluentValidation.AutoValidation/pull/40? I think that solves your problem.


Deploy of gridsome fails with images in LFS

Hi, I'm trying to deploy a Gridsome site and I'm getting this error in the Github Action:
$ gridsome build
Gridsome v0.7.19

Initializing plugins...
Load sources - 0.1s
Create GraphQL schema - 0.14s
Create pages and templates - 0.06s
Error: Failed to process image src/images/TouchIcon.png. Input buffer contains unsupported image format
    at ImageProcessQueue.preProcess (/bin/staticsites/ss-oryx/app-int/node_modules/gridsome/lib/app/queue/ImageProcessQueue.js:81:13)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@CHH Why did you closed the issue, I'm running into the same error and would kindly ask you: How did you fixed this issue?
Greets, Andrej :)

@h2xd Hi Andrej, I closed this because it was an error on my part and no bug with Azure Static Web Apps. I fixed this simply by adding lfs: true to the checkout Action in the GitHub Workflow file.
Hope this helps, Christoph :)

@CHH Thanks Christoph! Same issue in my side, just found it. :D
Cheers, Andrej


SimpleMemoryAllocatorJUnitTest.testClose - Disabled it until it is fixed

Disabled it until it is fixed, so that sonar coverage succeeds.
GEODE-701 tracks this test case failure and will be enabled once it is fixed.

Is there are reason why this test should be disabled? I thought our practice is to not disable failing tests?
If you do need to disable the test, please use the @Ignore annotation and provide it a comment explaining why the test is ignored. This lets us easily see a list of ignored tests in jenkins.

@upthewaterspout Thanks Dan for suggesting @Ignore.
This test currently failed only once on Geode_develop_UnitTests job but consistently failing on GemFire_develop_Sonar.
So disabling it until it is fixed so that code coverage analysis is not impacted.

+1
On Fri, Dec 18, 2015 at 2:38 PM, Sai Boorlagadda<EMAIL_ADDRESS>wrote:

@upthewaterspout https://github.com/upthewaterspout Thanks Dan for
suggesting @Ignore https://github.com/Ignore.
This test currently failed only once on Geode_develop_UnitTests job but
consistently failing on GemFire_develop_Sonar.
So disabling it until it is fixed so that code coverage analysis is not
impacted.
—
Reply to this email directly or view it on GitHub
https://github.com/apache/incubator-geode/pull/62#issuecomment-165912911
.


adding an extension for a game shape shifter

Is your feature request related to a problem? Please describe.
i want to add an extension for a game named as shape shifter
Describe the solution you'd like
In this game, the player has to click on falling shapes to change them to the target shape within a limited time. The game will have different levels, with shapes falling faster as the levels progress.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
What problem is this feature trying to solve?
i want to make it for fun purpose
How do we know when the feature is complete?
i will raise a pr
pls assign me under GSSOC24

Closing this as exists #2219


Value Function Clipping for PPO

The new PPO implementations in the OpenAI baselines repository also perform Value Function clipping (https://github.com/openai/baselines/blob/master/baselines/ppo2/ppo2.py).
It would be cool to have this implemented!

https://github.com/ikostrikov/pytorch-a2c-ppo-acktr/blob/master/algo/ppo.py#L67
It's already in the repo. But I've disabled it by default since I'm getting worse results with it.

Oh, thanks! I should have pulled from the master again before raising the issue.
Yeah, I imagine the value loss clipping would help only when the critic training is high variance. I actually have such a case rn, will report back the results!
Related point: I see that the value loss is scaled by 0.5 by default right now, in addition to having the value_coef. Won't this be confusing?

Yes, I probably should just put everything into value_coef.


Add AWS JDBC Wrapper Driver Support for Aurora Postgres/MSSQL with Hibernate ORM

This issue is a request to provide wrapper to Mysql & Postgres data sources to use the AWS JDBC Wrapper Driver.
Why?
The JDBC Wrapper driver provides additional support for connectivity to AWS Aurora hosted databases with features like:

Cluster Failover
AWS Secrets Manager Credential Management for database
IAM Authentication Token authentication for database
Failover Monitoring

Approach
I imagine this would be a case of adding an additional wrapper around the existing Postgres and MySQL.
We might then consume the uplifted driver like:
Postgres
~implementation("io.quarkus", "quarkus-jdbc-postgresql")~
implementation("io.quarkiverse.amazonservices", "quarkus-jdbc-postgresql-aurora")
MySQL
~implementation("io.quarkus", "quarkus-jdbc-mysql")~
implementation("io.quarkiverse.amazonservices", "quarkus-jdbc-mysql-aurora")
Plugin Parameters
A number of options are exposed using AWS JDBCDriver Parameters (normally injected into the data source on creation).
These could be exposed as properties to be configurable by the end consumer to enable/disable specific features and plugins
Other
The Hibernate ORM documentation warns against defining a custom ORM datasource as it is likely to fail the GraalVM build.
I am not super confident in my graalvm knowledge, but do believe this would be useful for the community.

I believe this falls somewhat outside the scope of this project, which primarily focuses on providing support for the AWS SDK. I guess the JDBC driver deserves a new Quarkiverse project by its own.
Thought, it appears to leverage the AWS SDK internally (at least for RDS, STS, and AUTH). STS, is already supported with GraalVM substitution. We do have an open call for contributions regarding RDS. And AUTH could be added as necessary.

I wasn't too sure whether it constituted its own extension or not, as I imagine it will end up being quite a small plugin.
If I manage to get a version of this working (Assuming RDS and Auth are also covered), would you be open to a pull request for this feature?
Otherwise I'll close the Issue, and if I get it working, investigate opening an extension.


Bump coursier to v2.0.0-RC6-24

My builds are intermittently failing due to https://github.com/sbt/sbt/issues/5238.
I see that:

https://github.com/coursier/coursier/commit/48fd23ab657718528eba28a8bf0ae5eed572606b is meant to fix/workaround the issue.
That commit is available in coursier v2.0.0-RC6-24 … v2.0.0-RC6-22.
https://github.com/coursier/coursier/releases/tag/v2.0.0-RC6-24 is included in https://github.com/coursier/sbt-coursier/commit/bbbcad02c56b808183da3fa63bdf2bda3e6b3846 lm-coursier-shaded v2.0.0-RC6-8 (confusing).
lm-coursier-shaded was updated in sbt at https://github.com/sbt/sbt/commit/2bebee4dfe94b23d58b2ee7a7bc6bc879ea591cf does not appear to be present in any sbt release.

I guess we just need a release of #5575 now.