Support for search parameters that target CodeableReference elements

Is your feature request related to a problem? Please describe.
In R4B, ClinicalUseDefinition includes a number of search parameters that reference an element of type CodeableReference:

contraindication
contraindication-reference
effect
effect-reference
indication
indication-reference

Because of this, we skip extraction for these search parameters.  With FINE logging you can see messages like this:
[08/08/2022, 12:17:19:640 UTC] 00000036 FHIRPersisten 1   Processing SearchParameter resource: ClinicalUseDefinition, code: indication-reference, type: reference, expression: ClinicalUseDefinition.indication.diseaseSymptomProcedure
[08/08/2022, 12:17:19:640 UTC] 00000036 JDBCParameter 1   The processing of com.ibm.fhir.model.type.CodeableReference is unsupported

Describe the solution you'd like
This data type allows for either a reference or a concept, or both. If both are present, they are expected to be consistent with each other.
When the concept is present, we should extract that like a normal CodeableConcept (e.g. for the 'token' search parameters).
When the reference is present, we should extract that like a normal Reference (e.g. for 'reference' search parameters).
Describe alternatives you've considered
we briefly considered using a composite for it, but because the two parts are expected to be consistent, this would be redundant
Acceptance Criteria

GIVEN a ClinicalUseDefinition with a contraindication
AND that contraindication has a concept but no reference
WHEN you search using contraindication
THEN the resource is returned

GIVEN a ClinicalUseDefinition with a contraindication
AND that contraindication has a concept but no reference
WHEN you search using contraindication-reference
THEN the resource is not returned

GIVEN a ClinicalUseDefinition with an effect
AND that effect has a reference but no concept
WHEN you search using effect
THEN the resource is not returned

GIVEN a ClinicalUseDefinition with an effect
AND that effect has a reference but no concept
WHEN you search using effect-reference
THEN the resource is returned

GIVEN a ClinicalUseDefinition with an indication
AND that indication has both a concept and a reference
WHEN you search using indication
THEN the resource is returned

GIVEN a ClinicalUseDefinition with an indication
AND that indication has both a concept and a reference
WHEN you search using indication-reference
THEN the resource is returned

Additional context
Unfortunately, the spec was never updated with how to index this element type either.  I've opened the following spec issue for that part of it:  https://jira.hl7.org/browse/FHIR-37867

Created 3 ClinicalUseDefinition resources as described in the acceptance criteria and confirmed that each of the searches perform as described.
For acceptance criteria 1 and 2 we use:
{
    "resourceType": "ClinicalUseDefinition",
    "id": "ac1",
    "meta": {
      "profile": ["http://hl7.org/fhir/StructureDefinition/ClinicalUseDefinition"],
      "tag": [ { "code": "ibm/minimal" } ]
    },
    "_type": {
        "extension": [
            {
                "url": "http://hl7.org/fhir/StructureDefinition/data-absent-reason",
                "valueCode": "unknown"
            }
        ]
    },
    "contraindication": {
        "diseaseSymptomProcedure": {
            "concept": {
                "coding": [
                    {
                        "system": "5_LWDVgDqB",
                        "version": "1PVfRRv1RF",
                        "code": "R1XFhBJtCs",
                        "display": "o1v5cs83R2",
                        "userSelected": true
                    }
                ],
                "text": "snktGlhzJM"
            }
        }
    }
}

For acceptance criteria 3 and 4 we use:
{
    "resourceType": "ClinicalUseDefinition",
    "id": "ac3",
    "meta": {
      "profile": ["http://hl7.org/fhir/StructureDefinition/ClinicalUseDefinition"],
      "tag": [ { "code": "ibm/minimal" } ]
    },
    "_type": {
        "extension": [
            {
                "url": "http://hl7.org/fhir/StructureDefinition/data-absent-reason",
                "valueCode": "unknown"
            }
        ]
    },
    "undesirableEffect": {
        "symptomConditionEffect": {
            "reference": {
                "reference": "Basic/dtT-yJagZU",
                "type": "Basic",
                "identifier": {
                    "use": "temp",
                    "type": {
                        "coding": [
                            {
                                "system": "oiITZLiXAm",
                                "version": "yVVTohyF81",
                                "code": "h0cnJfhBJV",
                                "display": "95i0vqA4AD",
                                "userSelected": true
                            }
                        ],
                        "text": "XLo_qIqOQc"
                    },
                    "system": "2JHtZyNt9B",
                    "value": "Q0VK_yt2yn",
                    "period": {
                        "extension": [
                            {
                                "url": "http://hl7.org/fhir/StructureDefinition/data-absent-reason",
                                "valueCode": "unknown"
                            }
                        ]
                    }
                },
                "display": "njvPnQ1C23"
            }

        }
    }
}

For acceptance criteria 5 and 6 we use:
{
    "resourceType": "ClinicalUseDefinition",
    "id": "ac5",
    "meta": {
      "profile": ["http://hl7.org/fhir/StructureDefinition/ClinicalUseDefinition"],
      "tag": [ { "code": "ibm/minimal" } ]
    },
    "_type": {
        "extension": [
            {
                "url": "http://hl7.org/fhir/StructureDefinition/data-absent-reason",
                "valueCode": "unknown"
            }
        ]
    },
    "indication": {
        "diseaseSymptomProcedure": {
            "concept": {
                "coding": [
                    {
                        "system": "5_LWDVgDqB",
                        "version": "1PVfRRv1RF",
                        "code": "R1XFhBJtCs",
                        "display": "o1v5cs83R2",
                        "userSelected": true
                    }
                ],
                "text": "snktGlhzJM"
            },
            "reference": {
                "reference": "Basic/Q93RHILNQZ",
                "type": "Basic",
                "identifier": {
                    "use": "old",
                    "type": {
                        "coding": [
                            {
                                "system": "FqsSHCwob6",
                                "version": "qP0bKApiBo",
                                "code": "_hrOfNI6QM",
                                "display": "LMwqDJsHU7",
                                "userSelected": true
                            }
                        ],
                        "text": "5WBuzNHroO"
                    },
                    "system": "sHhF1ju0EN",
                    "value": "RBBqf8QZll",
                    "period": {
                        "extension": [
                            {
                                "url": "http://hl7.org/fhir/StructureDefinition/data-absent-reason",
                                "valueCode": "unknown"
                            }
                        ]
                    }
                },
                "display": "L8_EV8IOKs"
            }
        }
    }
}


Question: Is there a way of reloading certs without restart of server

I wanted to know if there is a way of reloading certificate used for HTTPs without restarting Kestrel. For example i have next configuration:
webBuilder.UseKestrel(options =>
                {
                    options.Listen(IPAddress.Any, 80);
                    options.Listen(IPAddress.Any, 443, listenOptions =>
                    {
                        listenOptions.UseHttps("localhost.pfx");
                    });
            });

And the localhost.pfx file is changed after the Kestrel is loaded. Can we somehow automatically reload certificate without restart of Kestrel?

2.1 added a call back designed for use with SNI, but it could also be used to reload a certificate. You'd have to build the change detection part.

Yeah, I couldn't find it on my phone earlier. See the docs and look under Kestrel support for SNI.

webBuilder.UseKestrel(options =>
{
   options.Listen(IPAddress.Any, 80);
   options.Listen(IPAddress.Any, 443, listenOptions =>
   {
      listenOptions.UseHttps(httpsOptions =>
      {
         httpsOptions.ServerCertificateSelector = (context, dnsName) =>
         {
            // here you can return your cert dynamically
            return X509Certificate2.CreateFromCertFile(" ... your cert filepath ... ");
         };
      });
   });
});

@samsosa careful there, you don't want to reload the cert on every new connection, you want to cache it and only reload when needed.

@Tratcher  @samsosa  Thanks this solves my question

@Tratcher yes you're right. I changed the example slightly.


CameraStarterKit: DEP0001: Unexpected Error: SmartDeviceException - The system cannot find the file specified. [0x80131500]

Unable to run it an a mobile emulator.
Steps to reproduce it:

Open CameraStarterKit solution with VS2017 (15.3.5).
Update NuGet package Microsoft.NETCore.UniversalWindowsPlatform.
Select Debug, x86 and Mobile Emulator 10.0.15063.0
Run the app.
Results:

2>------ Deploy started: Project: CameraStarterKit, Configuration: Debug x86 ------
2>DEP0001: Unexpected Error: SmartDeviceException - The system cannot find the file specified. [0x80131500]
========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========
========== Deploy: 0 succeeded, 1 failed, 0 skipped ==========

This appears to be a VS/emulator issue.


filter_already_downloaded doesn't work

Hi,
Thanks for the code release. I noticed that the filter_already downloaded function seems to have 2 issues:

it doesn't current operate as expected since the files seem to be missing a version which gets triggered as a mismatch. As a result, all files are redownloaded as noted by #48
Even if we comment out the version checks in cli/download.py (L207-212, L219-225). The check for number of downloads is incorrect since to_download at that point refers to an array of booleans which will always have the same length and is only used to filter the statements in the return statement using list(compress(downloads, to_download)).  This only affects the log as the function returns the correctly filtered set.

I can submit a PR to remove the version checks and fix the to_download, however, I wasn't sure if there were plans to use version checking.
Thanks,
Mohamed

@mbanani Hi Mohamed, and welcome to Ego4D!  Thanks for the detailed question.  It's on the list for improvement, but right now the version info is only written once at the end.  So if it fails/is killed, it will indeed attempt to redownload and agreed that's not optimal given the size!  (Would certainly take a PR if you have the cycles.)
On the second half though, I'm not sure I follow.  Agreed that array is fixed size, it's just a selector array for the download array (and would need to be the same size).  Certainly could be more elegant, but I'm missing the issue?
Did you download fully complete before you ran it again?  And you still saw it redownloading?  (I'm not seeing the same behavior, but could certainly believe there are bugs there, especially if the download connection is different - we have had reports that boto seems to be timing out on some of the downloads, and perhaps it's related behavior.  Were there any errors on your first download attempt?
Appreciate the report, and would certainly appreciate and PR's for improvement!

Hi Gene!
Thank you for the quick response.
As for the first half, I am not sure how to fix it other than a hack of turning off the version checks for now since it's still version 1 and there are other checks (size @ L227.
For the second half, I downloaded the version with the missing files that were noted by #48 which had 1515 missing videos. After the fix was done, I attempted to rerun the script, but it was going to redownload the full dataset. It was recognizing the files had be redownloaded already, but it was failing the version check at L207 as version_entry was None. After commenting out that check and the other check at L220 for s3_version, the correct set of files is returned by filter_already_downloaded but the check at L247 doesn't do anything since the lengths will always be the same, so it just prints out something incorrect ("No existing videos to filter") even if it filtered videos.
I'll submit a PR to fix the printout issue, but I am not sure what to do about the versioning.

Ah, so the version_id there is actually an S3 property (to uniquely identify the file instance if it is replaced) and not related to our version.  So I wouldn't expect that to have changed - are you certain that's what's failing?
So after the 1515 videos, it was trying to redownload all 9k+ videos?  Was it given a message for each that the version didn't match?  (I'm assuming based on what you're saying.)  Do you happen to have the output of the original run?  (In particular I would imagine there was an error at the end - if all of the pooled connections failed I could see it failing even though it downloaded all the other files.)
Would you mind checking & upload the version file: ~/ego4d_data/v1/full_scale/manifest.ver (Or whatever base directory you used.)
Apologies on the poor first experience here! Appreciate ya debugging it with us.  (I'll bump the incremental versions up our Eng list this week since it's clearly a pain point for a couple folks.)

And noted on the print statement, we'll fix that on our side.  Should just be a sum rather than a len, but won't affect the outcome.

No worries at all and thanks for the quick responses.
Regarding the print statement, I submitted a PR. Having it as a sum makes sense though.
As for the error, yes. Here are the last few lines before I get prompted to accept the download. The shows up for all downloads I have had before. If I turn off this, the files left are the ones that I haven't downloaded yet.
already_downloaded: no version entry for existing file: /nfs/shared_datasets/ego4d_data/v1/full_scale/8cf4fef4-e544-4311-aba0-463a95b53d84.mp4
already_downloaded: no version entry for existing file: /nfs/shared_datasets/ego4d_data/v1/full_scale/ad4f61f0-4c0f-4ce1-bdaa-e57b79250527.mp4
already_downloaded: no version entry for existing file: /nfs/shared_datasets/ego4d_data/v1/full_scale/7fdd82ac-ef37-4481-976b-04a550e62697.mp4
100%█████████████████████████████| 9650/9650 [01:41<00:00, 94.62file/s]
No existing videos to filter.
Downloading 9650/9650..
Expected size of downloaded files is 7172.5 GB. Do you want to start the download? ([y]/n)

I haven't tried redownloading the files, I deactivated the version check and started downloading the remaining files instead.
As for manifest.ver, I can't seem to find one. There's only the videos and manifest.csv in that directory. Could that be the issue?

Yes, that's the issue.  Your download didn't finish the first time (irrespective of the failed downloads), and the version file wasn't written, that's why it's unable to bypass those files.  I'll make that more fault tolerant this week, and I'm adding an option to bypass the version checks now.  (Though it sounds like you're already sorted there.)
Thanks for the PR btw!  I'll close it since we already updated internally (will be out probably tomorrow), but love to see it.
Let us know how your initial work with the dataset proceeds!
-Gene


Invites are currently paused for this server

Discord server's invites are paused

this is not an issue. yes this is indeed true.

but why? people who want to join cant, was the server raided or something? its been like this for a couple weeks now @yellowsink

I am not in a position to disclose why the server is closed, but if you can take my word for it, there is a good reason. it will remain so indefinitely.

indefinitely??? damn, well at least is there somewhere else i can communicate with other shelter users/developers?

nowhere comes to mind, but if you ever need help with developing or anything my DMs are open

alrighty, thank you!


Enhanced String Length Handling

This PR introduces improvements to the way string length is handled. The existing String.length() method has limitations, and this proposal suggests alternative models for more accurate results. By considering Unicode codepoints and multilingual text, developers can achieve greater flexibility and precision.

Generally no concerns about adding such a functionality. However, this change breaks existing behavior. It would be fine to add it as a new function.

Thanks for your quick reply! I totally see your point about not breaking current behavior. I just wanted to mention that the Java and Go CEL implementations handle string lengths differently, causing potential confusion.
Happy to add this as a new function. Could you give me some pointers on that?

So Go's string-length works differently? Interesting.
I found this issue, which updates the CEL spec to talk about string-length vs. code-points, so I suspect your current change makes CEL-Java's string-length conformant to the CEL spec. I think, that classifies this PR as a legit bug fix, which then justifies the change in behavior.
Could you add some test-cases to validate the behavior?

sure can, thanks for your thoughtful consideration.


[firestore-shorten-urls-dynamic-links] Note that created links won't show up in Firebase console

We should add a note to POSTINSTALL.md to explain that dynamic links created by this extension won't show up in the console.
Expected Behavior
Dynamic links created by the extension would show up in the FDL console
Actual Behavior
They don't, but it turns out this is expected per the Firebase docs

Short Dynamic Links created with the API and client (Android/iOS) SDK do not show up in the Firebase console.

FYI @kevinthecheung

FYI @kevinthecheung

Note: with dynamic links now deprecated, need to discuss this extension with the team


css: Fix edit icon bug in user profile modal.

CZO
Setting <a> tag's height equal to 0 removes any space around the edit button. This restricts opening of the profile settings upon clicking space surrounding the edit button.
This also restrics the edit button from being highlighted if the cursor is very close to the button, yet outside.
Screenshots:
Before -

After -

screen captures:
Before -

After -

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@SameepAher Could you please show what the hover box is for the "edit" button? I think we want it bigger than in this PR; the button feels a bit hard to hit.

@SameepAher Could you please show what the hover box is for the "edit" button? I think we want it bigger than in this PR; the button feels a bit hard to hit.

The highlighted portion (in light blue color) is the hover box for the edit button in this PR -

Previously, it was this -

Yeah, let's make it centered around the button, but larger than it currently is. Can you please post an updated screenshot when it's been updated?

Feels reasonable to me in manual testing now.

Merged, thanks @SameepAher!


Visualize evaluation results

Hi Alon,
I am running evaluate_segmentation on some pretrained models and would like to view the segmented 3D objects (colored).
I noticed there is a color class in the utils but no use for it.
Could you help me figure out what is the best way to get an quick visualization?
Thanks in advance,
Hadas

Hi,
I am sorry, but do not have the time to help you.
Best,
Alon.


Allow certain roles to ping more than 20 people at once

Currently the bot has a mechanic against potential spammers that removes messages with more than 20 pings and times out the author of such a message. This has caused several issues in the past with well established members using more than the limit in the trends channel for example.
This restriction should now be changed to only apply for members without both Yes Theory and Seek Discomfort roles.
Implementation
Here is the relevant code that handles the cases described above. You can add a whitelisted roles array above the condition and add a new check that looks whether the message author (this.message.author) has at least one of the roles in the whitelisted array (using find, filter, some or something like that). That whitelist should contain the Support role, Yes Theory and Seek Discomfort`.

The fix worked well on the test-server and crashed the bot on the actual server.

Closed in https://github.com/Yes-Theory-Fam/yesbot-ts/commit/0d6cd14e87aec5f493eca7976c9503e1197e2cc4


Tree View Stuck on opening project folder

as you can see the project folder shows this 'refresh' icon. but it just stays there forever. it doesn't open at all.  But i can open project files using Command + P shortcut.

Thanks for reaching out!
That doesn't appear to be Atom's Tree View, which looks like this:

Atom also doesn't have a "refresh" icon in the Tree View. I'm not sure what package that is. I couldn't find it with some quick searches. You should probably contact the maintainers of that package to see if they can help with what is going wrong. The Atom FAQ has information on how to contact the maintainers of any Atom community package or theme.

Looks like you have Nuclide installed, which ships a custom file tree. You probably want to file an issue over at https://github.com/facebook/nuclide/issues instead. Please also provide version & package info when you do so. Thanks!

okay i found out the problem by opening the developer tools. it seems that yesterday, i was trying to create a new file. and in the file name i included slashes to create this in a subdirectory. like app/index.js instead of index.js. so what happened is that atom automatically renamed it to app:index.js. now its showing this error
Uncaught (in promise)
message: Nuclide URIs must contain paths, null' found while parsing 'app:index.js'

okay. thanks for the help.


Extension didn't found TFS repository

Every command I run in the extension returns "Unable to determine the source control server."
When i run tf status . in the workspace directory it woks fine

Hi @felipecaputo,
Maybe I did something with the last version. Did you use this extension before ? And if yes, did it work ?

Hi @ivangabriele, I've already tried it before, and the error occurred also in the old version. But I wasn't using TFS too much in the past, so I didn't check if it was my environment.
Now I'm using it a lot. I'll try to debug it and see if the error is in my environment or in the extension and let you know.


extra jenkins plugin is needed by default

GitHub Plugin
https://wiki.jenkins.io/display/JENKINS/GitHub+Plugin

already incorporated


Reasonableness of resource estimates

When the func of estimatedUsedByResource estimates the resource usage of the Pod, if the pod's request is less than the limit, then use the limit as the estimated value. If the request is equal to the limit, then use the limit * scalingFactor (scalingFactor is a preset value, the default In this case, the scalingFactor of the CPU is 85%) as an estimate. According to the QoS category and corresponding operation quality requirements, shouldn't the larger the estimate in the Guaranteed case, and the buffer estimate in the Burstable case, the higher the stability of the final scheduling result? But looking at the implementation, it seems to be exactly the opposite. I haven’t seen any design and implementation documentation for this in the community.

link：https://github.com/koordinator-sh/koordinator/issues/2232


Split the Gateway Client into it's own package

Related heavily to #6 but this will track progress towards just extracting the gateway client it's own package instead of how it is right now, heavily integrated. One thing on my mind is the fact it can throw CLIError, which is related to the cli.

I started work on this, no commits yet but most of the package is done, just no testing.


meta data, custom headers or client strings

Hi,
I would like to be able to communicate meta data or custom headers on the messages. This to allow side channel information without inspecting or enforcing specific storage conventions on the message payloads itself.
A way to communicate a trace Id or such to the message (or event) that I can use for trace logging in the application code that processes the message.
I have not found a way to do this besides encoding it in the message payload itself. This is obviously not optimal for a generic service that acts as a sidecar as it limits its usability.
Being able to send meta headers or client app Id or other would solve this problem. I am enqueing the message in Azure Function App and consuming on-prem in a sidecar service (using the Python SDK).
Kind regards,
Henrik Holst

hey @hholst80 , thanks for reaching out.
May I ask which Python SDK you're referring to? is it a blob storage service or service bus?

hey @hholst80 , thanks for reaching out.
Could you give some more details on which Python SDK you're referring to? is it service bus or storage?

The Storage Queue messages.

thanks for sharing me with the package information, I have tagged the issue, @tasherif-msft would you be able to help with this issue?

Hi @hholst80 Henrik, would the PopReceipt not work for your needs? The PopReceipt is returned by the service on a PutMessage call (doc) and inside the QueueMessage object that comes back in Python when you call receive_message/s.

Unfortunately no, that would not be something we could use end to end. It needs to be something we can set on the message send and pick up on receive.

Hi @hholst80 Henrik, Unfortunately the Storage Queue service does not support any other form custom properties on messages. My one other suggestion would be to use some form of schema (e.g. JSON) in your Queue message where you can specify the metadata separate from the message body but I realize this still relies on reading the message.
We can take this as a service feature request but it is not likely this will get prioritized for some time if I'm honest.
Have you looked into Azure ServiceBus Queues (Python sample). ServiceBus Queues are a more robust form of Queues that Azure offers (with more support). I'm not too familiar with their API surface but it does look like ServiceBus Queue messages support application_properties ("user-defined properties on a message") that may help in your scenario (doc). I realize switching services may not be possible but I thought I'd offer it as an alternative

To provide an update on this issue, unfortunately, this is not something the Storage service team is likely to prioritize unless there is more demand. Hopefully one of the provided work arounds, (encoding the metadata in the message, or moving to ServiceBus) can work for you in the meantime. If/when the service team does add a feature like this, SDK support will be promptly added. Apologies that this isn't great news.
I'm going to move forward with closing this issue for now but please feel free to reach out with any further questions. Thanks!


added filtered query

part of #97

Filtered query is deprecated https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-filtered-query.html


Enable/Fix test_select_partitioned_column for pyarrow 0.9.0

[x] Tests added / passed
[x] Passes flake8 dask
[ ] Fully documented, including docs/source/changelog.rst for all changes
and one of the docs/source/*-api.rst files for new API

Depends on https://github.com/apache/arrow/pull/1656

+1 for the code, but the test appears to be skipped (as does the fastparquet variant?).

@martindurant The skip for pyarrow is expected, 0.9.0 is not released. Once https://github.com/apache/arrow/pull/1656 is merged, I could see if we could change the pyarrow version check so that the nightlies are already included.
Fastparquet is skipped because it cannot be installed in the CI job (this should already be a failure?):
    gcc -pthread -B /home/travis/miniconda/envs/test-environment/compiler_compat -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/home/travis/miniconda/envs/test-environment/include/python3.5m -I/home/travis/miniconda/envs/test-environment/lib/python3.5/site-packages/numpy/core/include -c fastparquet/speedups.c -o build/temp.linux-x86_64-3.5/fastparquet/speedups.o
    gcc: error: fastparquet/speedups.c: No such file or directory
    gcc: fatal error: no input files
    compilation terminated.
    error: command 'gcc' failed with exit status 4

Thanks for continuing to track this @xhochy .  Merging.


Job Aids for Windows Server 2003 Deployment Kit

Description:
As noted in PR #4167 (Selecting the Forest Root Domain: updated links), I have been informed as follows: "We typically are trying to replace the fwlinks with direct URLs as we go through files. If you happen to see them and feel like it, you can just replace the whole fwlink with the direct URL."
This PR aims to correct all occurrences of the specific link to the download page for "Job Aids for Windows Server 2003 Deployment Kit".
Thanks to @eross-msft (Elizabeth Ross) for the valuable feedback.
I have noticed that many other links are either outdated or broken, but I have not yet had time to extend my research to those other links yet. If you know the correct new link address for any of the outdated links in any file in this Pull Request, feel free to tell me about it, so I may add that/those link correction(s) as well.
Changes proposed:

Replace https://go.microsoft.com/fwlink/?LinkID=102558 with https://www.microsoft.com/download/details.aspx?id=9608 anywhere
Change the page name reference text to link text for existing links, instead of the link being used both as link text and the link itself.
Remove any redundant end-of-line (EOL) whitespace
Add MarkDown indent marker compatibility spacing (1 space) anywhere
Standardize bullet point list internal indent spacing from 3 to 1

Ticket closure and reference:
Closes #3592, #3760, #3964
Ref.: #4147, #4167

Looks like I didn't manage to write the closing command correctly in my commit message. I might try to improve it, but in case I can't resolve how the command to close multiple tickets with 1 Close command, we may just need to close the tickets #3760 and #3964 manually.

@JohanFreelancer9 : I keep forgetting whether or not this repository belongs to your workspace, but if you would be so kind to perform a copy review to look for anything simple typos or naming conventions I may have missed out on, I would be grateful for your contribution. If you are aware of any link improvements to be included as well, that would be a nice bonus.

Additional change, not mentioned in my [Changes proposed] list: in row 34 of the PR file identity/ad-ds/plan/Finding-Additional-Resources-for-Logical-Structure-Design.md, I chose to split that row into 2 separate lines, to keep the page format consistent by having only 1 topic and 1 linked text for each bullet point in the list:

https://github.com/MicrosoftDocs/windowsserverdocs/pull/4181/files?diff=unified&w=1#diff-078ade3b36a48e88964afbbf2fe0f024

[ ... ] However, "www" has been consistently included throughout the topic in the link to "Job Aids for Windows Server 2003 Deployment Kit", and I would suggest removing it in all the links.

Thanks, I forgot to check that almost all ://microsoft.com/ URLs are compatible with www.microsoft.com -- good point.

I will be right back with some updates -- stay safe and well in the meantime.

Very well, I think there are just a few more fwlinks which I can easily convert to their actual target page links. Please hold for more updates quite soon™. 😉

Also: Thank you @JohanFreelancer9 for your kind assistance so far. Appreciated. 👍

There you go. 30 new files, new amount of files: 38. Sorry for all the added trouble of reviewing my changes. In addition to correcting as many links as possible, there are also lots of whitespace consistency adjustments. I can only recommend using the Hide whitespace changes feature (https://github.com/MicrosoftDocs/windowsserverdocs/pull/4181/files?diff=unified&w=1) to maintain a modicum of sanity while scrolling through the effective changes, before looking over the whitespace changes I have worked quite a lot on.

#sign-off

Technical detail correction: I started off with 17 files, so my last commit with 30 files must have contained only 21 new files and 9 old ones.

Additional details regarding the files in this PR:

37 files from the folder WindowsServerDocs/identity/ad-ds/plan/ ((https://github.com/illfated/windowsserverdocs/tree/job-aids-for-ws2k3-deploy-kit/WindowsServerDocs/identity/ad-ds/plan/))
1 file from the folder WindowsServerDocs/identity/ad-ds/plan/security-best-practices/ (last file by alphabetical sorting)

@illfated @JohanFreelancer9  Thank you both for all of your efforts on this content.

Very good, thank you as well. I was not expecting to see this PR merged this soon, but then again, it is rather old material and not super consequential.


Return JSON error messages?

Thinking about the sitch with the Network Number form where we'd return an error code, a message, and then the existing network number. Perhaps we should standardize on { Error: xyz } plus additional fields.

This is done via #146


Add FAQ entry to discuss executor task concurrency configuration [skip ci]

Based on a conversation in #4617, this adds a section in the FAQ about configuration settings that impact the executor task concurrency and point the user to detailed information in the tuning guide.

build

build


Set merge=union git attribute for CHANGELOG.md

Thank you for helping out with embedded-graphics development! Please:

[ ] Check that you've added passing tests and documentation
[ ] Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public API
[ ] Run rustfmt on the project
[ ] Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description
Set merge=union git attribute for CHANGELOG.md
Closes #634

Sweet, thanks for the quick fix :). I can't see any issues with adding this attribute but I've asked for a quick review from @rfuest in case I've missed anything.

Good point, although a minor one I agree. We could add a line to the release guide to check/apply ordering to the changelog entries, but it's not a huge deal if something slips through unordered.

Not sure why the build isn't being picked up. CircleCI is configured to build PRs. I'll merge this change anyway as it's probably not going to break CI.


Improve sort_custom() description

The method description mentions that it should return true or false, but it doesn't clarify what either of them means. This PR fixes it.

Thanks!

Cherry-picked for 3.4.

Cherry-picked for 3.3.3.


conditional withCredentials

I'm sending data to different backends and found I need to be able to set withCredentials. My alternative is to duplicate the entire call to superagent. Fingers crossed.

Yes, that was much needed. Thanks!


Hygiene test clarification inquiry - missing domain or range in properties

Could we clarify the meaning of the requirement specified in https://github.com/edmcouncil/fibo/blob/master/ONTOLOGY_GUIDE.md#t8-missing-domain-or-range-in-properties?
Does this outline some automated hygiene test, like a SPARQL query, or just describe a general modelling principle for domains and ranges of properties?

I think it's a general principle - and in many cases we don't want a domain or range, which makes properties less reusable.

I agree with @ElisaKendall we don't want a hygiene test for this. I don't even know why it's in the candidates except to explicitly reject it as a speciously attractive rule for those coming from a data modeling background.
Reminder: we have a policy against explicitly using Thing and Resource as domain/range.

Shall I then modify the ontology guide so that this test be no longer recommended as a hygiene test candidate?

We could try to check

if  "more specific" relations have a domain and/or range.
if data properties have a defined datatype in their range.

"More specific" relations could be defined as the ones that are sub-properties of some relations (top property does not count).

@trypuz then this should do the trick for object properties:
prefix rdfs:  <http://www.w3.org/2000/01/rdf-schema#>

SELECT ?warning ?property ?parentProperty
WHERE
{
?property rdfs:subPropertyOf ?parentProperty .
FILTER (CONTAINS(str(?property), "edmcouncil"))
FILTER NOT EXISTS {?property rdfs:domain ?domain}
FILTER NOT EXISTS {?property rdfs:range ?range}
BIND (concat ("WARN: object property ", str(?property), " has no domain or range specified although it has a parent property.") AS ?warning)
}

and this for datatype properties:
prefix rdfs:  <http://www.w3.org/2000/01/rdf-schema#>
prefix owl:   <http://www.w3.org/2002/07/owl#>

SELECT ?warning ?property
WHERE
{
?property rdf:type owl:DatatypeProperty.
FILTER (CONTAINS(str(?property), "edmcouncil"))
FILTER NOT EXISTS {?property rdfs:range ?range}
BIND (concat ("WARN: datatype property ", str(?property), " has no range specified.") AS ?warning)
}

@mereolog, thank you. IMO, the warnings they give us is substantial. @ElisaKendall, does the first query (that Pawel presented above) express your intuition concerning "more specific" relations?

@trypuz I think it's 'closer' - we already have a test for crossing domains and ranges.  I think for subproperties we will still need to ignore property chains, and subproperties of property chains, among others.  I have a lot of work to do to reallign some properties with the latest patterns related to situations, which I will do as time permits.  But, I think we need to see what the results are from these queries before making a decision.  Would you please run them for me and send me the output so that I can review and see if there are other refinements we can make to eliminate false positives?

I don't see the rationale for warning about sub properties with no domain or range. Is it even based on the ontology guide? What's the justification or anti-pattern you're trying to guard against?

@rivettp - I don't think we need this unless there are FIBO users complaining.  In fact, I think NOT constraining properties with a domain or range makes them far more reusable, though I also don't see the need for subproperties unless they are further constrained than their superproperties.  So it would be interesting to see the results of the query, which might help us eliminate more unnecessary properties :).

Shall I then modify the ontology guide so that this test be no longer recommended as a hygiene test candidate?

I think that's a good idea.  This was a naive test in the Oops! tool, and we took our original guidance from them when I wrote the early version of the guide, and the same test was in Stanford's Chimaera tool.  It may provide guidance to modelers, but I am not convinced that we need it, aside from identifying (maybe) properties we don't really need.  The challenge there is that there are lots of properties that are not subproperties of something that are also redundant still ... so I don't know whether or not this is worth bothering with.

Elisa knows this but wanted to clarify for others that she was using "constraining properties" generally (2 comments ago) and that declaring a property p to have a range of C is not a constraint in terms of limiting the values. If I assert triple "X p D" and D is not a member of C, that is not an error - instead it will infer that D is after all a member of C.


pubsub has faulty types for retry_policy backoffs

https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/master/modules/pubsub/variables.tf#L116-L117
[
│   {
│     "@type": "type.googleapis.com/google.rpc.BadRequest",
│     "fieldViolations": [
│       {
│         "description": "Invalid value at 'subscription.retry_policy.maximum_backoff' (type.googleapis.com/google.protobuf.Duration), Field 'maximumBackoff', Illegal duration format; duration must end with 's'",
│         "field": "subscription.retry_policy.maximum_backoff"
│       },
│       {
│         "description": "Invalid value at 'subscription.retry_policy.minimum_backoff' (type.googleapis.com/google.protobuf.Duration), Field 'minimumBackoff', Illegal duration format; duration must end with 's'",
│         "field": "subscription.retry_policy.minimum_backoff"
│       }
│     ]
│   }
│ ]

We do already append an s, can you share your actual code?

I must have confused master with latest tag v27 which doesn't have that. It's all good, sorry for misreport :)


Include stdout when knapsack_pro:rspec_test_example_detector fails

I'm trying to enable KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES, but every node in CI fails with the error here. The "actionable error message" above the error suggests running a command on the CI machine to reproduce the problem, e.g.
To reproduce the error triggered by the RSpec, please try to run below command (this way,
you can find out what is causing the error):
bundle exec rspec --format json --dry-run --out \
.knapsack_pro/test_case_detectors/rspec/rspec_dry_run_json_report_node_0.json \
--default-path spec foo.rb bar.rb

When I do, the command completes successfully, every time, so I can't tell why it's failing during automated runs. It's really frustrating to not be able to reproduce the issue. Why not capture the output of the command in knapsack and include it with the error message if that command fails?

What's the content of the .knapsack_pro/test_case_detectors/rspec/rspec_dry_run_json_report_node_0.json file?
Was it generated on the disk when you run the command in the CI environment?
Was the .knapsack_pro directory generated on the CI? Maybe it's a permissions error.
What CI provider do you use?

Why not capture the output of the command in knapsack and include it with the error message if that command fails?

This is something to investigate. I was wondering about printing the error a long time ago, but it was more complex.
There were a few approaches to this and how to make it secure. https://stackoverflow.com/questions/690151/getting-output-of-system-calls-in-ruby
The bundle exec rspec --format json --dry-run --out ... command writes a file on the disk, and most of the time, it does not produce any output, so there was no reason to capture the output.
Please share the full output of the error that you see. You can also email our support at https://knapsackpro.com/contact if the error contains private data (not to share it publicly here).

The files do get generated when I run the command manually. I will send a few samples of them to you by e-mail along with the build log since they might be considered sensitive.
We're using the latest version of Jenkins LTS.

I took a look at a couple of nodes and saw the file being generated, even though it was reported as having failed.
I also see that they look like they have the same content on different nodes, even though I'd expect them to list different tests. For example, on the same run, both slow_test_files_node_21.json and slow_test_files_node_26.json have the same content:
[{"path":"spec/features/spaces/account_creation/onboarding_visit_public_network_course_spec.rb","time_execution":2227.537136728004},{"path":"spec/features/onboarding_visit_public_network_course_spec.rb","time_execution":2157.940042964002}]

Aha! Saving the artifact gets me this:
{
	"version": "3.8.2",
	"messages": ["\nAn error occurred while loading ./spec/features/spaces/account_creation/onboarding_visit_public_network_course_spec.rb.\nFailure/Error: require_dependency('premailer') # premailer must be manually invoked for batch renders. premailer inlines the email css\n\nLoadError:\n  No such file to load -- premailer\n# ./app/mailers/batch_mailer.rb:2:in `\u003ctop (required)\u003e'\n# ./app/mailers/batch_invite_mailer.rb:1:in `\u003ctop (required)\u003e'\n# ./config/environment.rb:9:in `\u003ctop (required)\u003e'\n# ./spec/spec_helper.rb:2:in `\u003ctop (required)\u003e'\n# ./spec/features/spaces/account_creation/onboarding_visit_public_network_course_spec.rb:1:in `\u003ctop (required)\u003e'\n", "\nAn error occurred while loading ./spec/features/onboarding_visit_public_network_course_spec.rb.\nFailure/Error: require File.expand_path('../../config/environment', __FILE__)\n\nRuntimeError:\n  can't modify frozen Array\n# ./config/environment.rb:9:in `\u003ctop (required)\u003e'\n# ./spec/spec_helper.rb:2:in `\u003ctop (required)\u003e'\n# ./spec/features/onboarding_visit_public_network_course_spec.rb:1:in `\u003ctop (required)\u003e'\n", "No examples found."],
	"examples": [],
	"summary": {
		"duration": 4.3535e-05,
		"example_count": 0,
		"failure_count": 0,
		"pending_count": 0,
		"errors_outside_of_examples_count": 2
	},
	"summary_line": "0 examples, 0 failures, 2 errors occurred outside of examples"
}

I still think it would be helpful to print those messages out along with the top level error message, rather than encouraging users to repro and then go digging through internal knapsack files.

I've prepared the improvement to show the content of the JSON report so that it's easier to debug an error when the error message is printed only inside of the JSON report.
https://github.com/KnapsackPro/knapsack_pro-ruby/pull/172

@cccCody I've released the knapsack_pro gem 3.3.0 version.


[posix] enable expect tests on macOS

This PR depends on #5392

There are still some unstable issues on macOS. I will get back to this PR later.


[Bug]: PDF not loading using Chrome on iOS

Attach (recommended) or Link to PDF file
When using an iOS device with version 17.3 (and under) and Chrome, the PDF viewer is blank and the file is not being displayed.

Web browser and its version
Goggle chrome 92.0.45
Operating system and its version
iOS v17.3
PDF.js version
4.2.67 (Modern browsers, Stable)
Is the bug present in the latest PDF.js version?
Yes
Is a browser extension
No
Steps to reproduce the problem

In iOS devices with v17.4 and below, open Chrome
Go to the pdfjs online demo
Click the link for modern browsers: https://mozilla.github.io/pdf.js/web/viewer.html

But if you click the link for older browsers, its working

What is the expected behavior?
The pdf file should be loaded in the viewer. This is using iOS 17.5 + Chrome.

What went wrong?
The pdf viewer is empty and the file is not being loaded.

Link to a viewer
No response
Additional context
No response

Web browser and its version
Goggle chrome 92.0.45

That's not a supported browser, as outlined in the FAQ (which the issue template asks you to please check  reporting a bug):
https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support

PDF.js version
4.2.67 (Modern browsers, Stable)

That version is no longer supported, please find the latest releases at https://mozilla.github.io/pdf.js/getting_started/#download

4. But if you click the link for older browsers, its working

Well, then you'll need to use the legacy version since it's intended for older browser (as outlined in the FAQ).

@Snuffleupagus thank you for your reply.


Kubewarden defaults rc version changed 1.9.5 -> 2.0.0

Version 1.9.5-rc does not exist, it was changed to 2.0.0-rc because of breaking change.
Tested manually, PR e2e tests are broken until we merge https://github.com/rancher/kubewarden-ui/pull/697.

@jordojordo this is actually a fix for 1.4.2 we just released...
Small one, but - should we release 1.4.3?


When starting a round of the game, the game should fetch a image from the API to all users screens.

duplicate


Dev container

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[*] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[*] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information
Incluye Dev Containers

Thank you for the contribution. I'll accept parts of it. I'm not sure all of it is a match for this repo.

Included in #42 so closing here.


Update window.js DOM text reinterpreted as HTML

By using innerText, it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML. Always be cautious when dealing with user input or dynamic content to prevent security risks.

Hi @sirdarckcat  Could You Please Review this PR
Thanks

Hi @sirdarckcat Could You Please Review this PR
Thanks

This PR would cause raw HTML tags to be printed on the user's screen.


Type sdk.chat.core.BuildConfig is defined multiple times

When I am going to release the full app it says this error:
Type sdk.chat.core.BuildConfig is defined multiple times: F:\works\New Folder\Ramfolinee\chat-sdk-core\build.transforms\01ae4b258926b7a18889d4cd8c45b46a\classes\classes.dex, F:\works\New Folder\Ramfolinee\app\build\intermediates\external_libs_dex\developmentRelease\out\classes5.dex

I want to release app with your chatsdk features.

@RahatSaqib which Chat SDK version are you using?

version 5.0.0rc21

Can you update to 5.0.4?

yes.but It will take time which cost do it from start. Is this a version issue? I don't think so

but currently in github it shows 5.0.2 no 5.0.4

@RahatSaqib it's possible that there was a problem was caused by the android manifest in two of the modules sharing a package name. This is resolved in the newest version. You can see the latest version here:
https://hackmd.io/@dyR2Vn0UTFaO8tZjyiJyHw/B1S2tXdqL#App-level-buildgradle

But I can not get the 5.0,4 . Where should i download?

You can get it using Gradle. https://hackmd.io/@dyR2Vn0UTFaO8tZjyiJyHw/B1S2tXdqL#Add-Chat-SDK-to-your-project


fix(kotlin): fix termination of """ string literals

Properly handles cases: like """ends in a "quoted string""""
Closes #2280.

I have had a look into Kotlin grammar (https://kotlinlang.org/docs/reference/grammar.html). The relevant parts are:
multiLineStringLiteral
  : '"""' (multiLineStringContent | multiLineStringExpression | '"')*
    TRIPLE_QUOTE_CLOSE
  ;

TRIPLE_QUOTE_CLOSE
  : ('"'? '"""')
  ;

It seems that end: '"""(?=[^"])' is basically the same as end: '"?"""', but the latter is a bit simpler and closer to the grammar. Thoughts?

I don' think those are the same... Is this not a problem?

Yeah, I played around a bit and looks like you're right. We need the rightmost match.


Enhancement/ethers support

This PR adds support for projects using ethers.js. Devs can now pass in ethers.js in the config instead of web3.js and also decorate ethers.js instantiated contracts with our Contract function.
This needs some thorough testing as there are some pretty major changes that can affect existing projects that are using web3.ethers contracts require that the whole contract object (not just the method be passed down in to our preflight checks, which required some architectural changes.
I am intermittently getting an issue with MetaMask where the txPromise doesn't resolve until the transaction has been mined as opposed to when a transaction hash is available upon user approval, which causes problems with out notification system. This is issue is referenced here: https://github.com/ethers-io/ethers.js/issues/372
I am not sure that there is anything that we can do about this. But would like to see if @cmeisl and @liamaharon experience the same issue.
Also something to consider would be to find an open source dapp frontend that is currently using ethers.js and invest some time integrating this version of assist to see if there is anything that this PR is missing.

This is issue is referenced here: ethers-io/ethers.js#372
I am not sure that there is anything that we can do about this. But would like to see if @cmeisl and @liamaharon experience the same issue.

I can confirm I have the same issue when using the signer injected by MM.

In your blocknative-demo branch if I decorate the contract with an internal signer instead of the MM signer like this:

  const provider = ethers.getDefaultProvider('rinkeby')
  const wallet = new ethers.Wallet(<priv-key>, provider)

  let highFiveContract = new ethers.Contract(
    caddr,
    abi,
    wallet
  )

calling decoratedContract.highFive results with 'Transaction waiting for you to confirm' popping up for ~0.25s then being replaced by 'Sending high five'. Maybe we could detect when the signer isn't MM, and in that case not show the 'Tx waiting for you to confirm' popup?

Update readme?

Closing this for the moment, can revisit once ethers v5 is out


Fix #873

it looks like the linter is replacing :%VIRTUAL_ENV%/ in ci/wsgi.conf with a real value.

also, we should only run this test if DB == sqlite

It was actually the existing apache CI stuff that was modifying wsgi.conf; I changed that so it shouldn't modify the one in the source tree anymore. Fixed the SQLite thing too.


Fix support for CUDA 12.6 and finding CUDA tools

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Unfortunately, my testing of #26 was insufficient, and more complex testing with PyTorch revealed more issues. This pull request:

Backports an upstream patch enabling support for CUDA 12.6.
Fixes tool path lookup to use PATH, to find tools installed in CONDA_PREFIX.
Adds a minimal pytest invocation that would have caught the two aforementioned bugs.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.


Implement validateEncryptionKey method for importWallet

Closed with [PR](https://github.com/getsafle/safle-vault/pull/186)


Implement open channel endpoint + extend decode error handling

Related to: #1646
Short description
This PR consists of two changes that go hand in hand.
First the decode error handling by the SDK has been extended. This has been
already taking advantage of for the openChannel method.
Second has the PUT /api/v1/channels endpoint become implemented with
a first version of the error validation
Checkout the according commit messages to get more insights.
Definition of Done

[ ] Steps to manually test the change have been documented
[ ] Acceptance criteria are met
[ ] Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)
Example curl request:
curl -i -X PUT http://localhost:5001/api/v1/channels -H 'Content-Type: application/json' --data-raw '{"token_address": "0x0f84DB873066d53379eC99048609d51b6239c409", "partner_address": "0x1F916ab5cf1B30B22f24Ebf435f53Ee665344Acf", "total_deposit": "1"}'

@kelsos how can we fix the issue with codeclimate of too complex/long functions? Due to our functional like approach we need to make each module export itself as a function explicitly. So this is indented to fail I would say. Splitting each route entry to its own function would become horribly readable, wouldn't it? :thinking:

The workflow is failing for the moment, because I introduced an incompatible
decoding type that is not expected. So the issue is that the spec defines
integers can be send as strings as well. But io-ts can't decode a string to
a number. So we eventually need to brand the t.number. I thought that UInt
would be suitable, but I think this is too much of a change, since this affects
a mass of code.

@kelsos how can we fix the issue with codeclimate of too complex/long functions? Due to our functional like approach we need to make each module export itself as a function explicitly. So this is indented to fail I would say. Splitting each route entry to its own function would become horribly readable, wouldn't it?

I am not sure how hard to read it would be. To be honest, I would probably go through the "a function" for each route approach. I don't know how easy it would be to have exceptions for codeclimate, but the 50 was a sensible reasonable length we decided after much thought.

I addressed all review comments. I'm about to rebase the fixup commits. If CI doesn't complain I'll merge afterwards.


Ability to ignore manual data

As FitData already contains userEntered flag I feel ignoring manual data should be handled on application side. If you have other reasons for this feel free to reopen this pull request and explain them.

I don’t think you are right.
Let me explain why.
Looking at a normal system with SQL database
Will you query the entire table and than filter in the code?
Or will you query the database with a filter?
Databases are made to be queried because they do it faster than average code. And it’s less data going tho the system.
Your opinion?

I completely understand your point of view, if similar functionality would be supported by GoogleFit I would definitely accept this pull request, but currently this breaks the limit functionality on Android side.
In case the last FitData would be manual entry but the previous one non-manual.

iOS would return the previous one.
Android would return nil.

As I'm trying to keep package usage experience as much as I can the same on both platforms, I don't want to add this.


Fountain notes incorrectly rendered as links

Describe the bug
Within actions and Dialogue in fountain one can write inline notes using the same syntax that obsidian uses for links (see https://fountain.io/syntax/#notes).  I use this a lot in my fountain files.  I just tried renaming one of them to .md adding the property and opening it in obsidian.  This mostly works great but all notes become links, which is undesirable imho.
What's the expected result?
I would expect notes to be rendered in a different font than normal but more indicative of a comment/note than of a link and of course to not create a note when clicked (indeed it should not be a click target).
Ideally the same syntax within a synopsis should indeed produce a link as usual.
Steps to reproduce the behavior

Fountain Editor - Plugin Version
1.1.4
Obsidian Version
1.5.12
What environment are you seeing the problem on?

[X] MacOS
[ ] Windows
[ ] Linux
[ ] Android
[X] iOS

Participation

[ ] I am willing to submit a pull request for this issue.

Hi! Thanks for using this plugin!
Yeah this is an expected behavior. It's one of the compromises I have evaluated necessary in the design to ensure interoperability between Fountain and Markdown.
Markdown wikilink is a crucial token especially in Obsidian, in fact, linking is the reason why most people use Obsidian to write their Fountain screenplays.
If acceptable, you can use Fountain's synopsis token (starting a line with '=') in place of Fountain's '[[]]' notes. It's not ideal, but it's not caused too much problems so far!
Let me know if this is alright?


Feature/paginator

resolve issue: #1695
Purpose
solve the problem that there is no pagination for add link search result

Changes
add paginator to add link serach result

@sloria this PR itself is rdy, but need the evaluation on ES6 before review and merge.

@chennan47 or @samchrisinger Can you please update this PR to use the oop module in place of ES6 classes?

@sloria already updated PR to use oop module

Pass finished. :v:

Also, tests should be added for Paginator. This can be a follow-up PR

@sloria rdy for another pass


Added endpoint for sending confirm attendance emails

Fixed by https://github.com/CoderDojo/coolest-platform/pull/82


[Storage] Tests - make blob tests parallelizable everywhere

In this PR:

got rid of StepVerifier.withVirtualTime calls - these were totally unnecessary.
enabled parallelization of tests in blobs.

/check-enforcer override


api: revert to old pens

changed the pens from private to public so they become visible

Coverage increased (+0.3%) to 69.782% when pulling bdf81060821a02fd8a1380f52c987266483fa86b on Sandstedt:dev into 756db557df2aef70b189bc1b370a9e223b2cca97 on legomushroom:dev.


[foundation] figure out why generated fragments ignore trace

In this scenario, both the column and fullSidebar should print trace messages. For some reason, only column does.
The trace is actually present between the instructions of fullSidebar.
            fullSidebar(items, state) .. traceAll

@Adaptive
fun fullSidebar(
    items: Collection<SidebarItem>,
    navStateOrigin: NavStateOrigin,
    theme: FullSidebarTheme = fullSidebarTheme,
    vararg instructions: AdaptiveInstruction
): AdaptiveFragment {

    println("${fragment()} ${fragment().instructions.contentDeepToString()}")

    val navState = autoItem(navStateOrigin)

    column(*instructions, *theme.container) {
        // ....
    }

    return fragment()
}

The trace is not shown because the generated fragments do not apply their instructions automatically, therefore the trace field is not updated.
This is actually not a bug, but more like a missing feature. I will put the whole trace thing onto #92 .


User Defined Type support.

First commit is minor:

Moved Try-Catch out of the main() function and replaced echo/die messages with thrown exceptions.
Minor refactor on the else-if block for the "check config file" section.

Second commit fixes crashing on User Defined Types.  I believe we could also cut out all the formatter definitions like:
const USERDATATYPE_BOOLEAN         = 'com.mysql.rdbms.mysql.userdatatype.boolean';
for Doctrine, Propel, etc.  These are just aliases for the actual type and I haven't seen an mwb file yet that didn't have them defined.

White space fixed.
Any thoughts about whether having the user defined types declared in the formatters are really needed anymore?  More directly; deleting all the static::USERDATATYPE_* in files like MwbExporter/Formatter/Doctrine2/DatatypeConverter.php.
I wanted to delete them in these commits but didn't know if there was a reason to keep them that I didn't understand.


perf: lazy load big dependencies to reduce min memory usage

Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:

[x] Target branch: Please verify that the pull request targets the dev branch.
[x] Description: Provide a concise description of the changes made in this pull request.
[ ] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
[ ] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
[ ] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
[x] Testing: Have you written and run sufficient tests for validating the changes?
[x] Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
[x] Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:

BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry
Description

Lazy load ColBERT if local re-ranking is not enabled
Lazy load Chroma or Milvus depending on which vector DB is enabled

This reduces the minimum memory usage of Open WebUI with external models back down to ~200MB.

LGTM, Thanks!


API for Refresh messages in ALMessagesViewController

Hi
Goals

I need to have refresh (or reload) all the chats when I pull the table view down in ALMessagesViewController screen. Whats the API for this.
Below is the code:
func launchChatList() {
        let alChatLauncher: ALChatLauncher = ALChatLauncher(applicationId: getApplicationKey() as String)
        alChatLauncher.chatLauncherDelegate = self
        let storyboard = UIStoryboard(name: "Applozic", bundle: Bundle(for: ALChatViewController.self))
        appLozicTabBar = storyboard.instantiateInitialViewController() as? UITabBarController
        let navBAR = appLozicTabBar?.viewControllers?.first as? UINavigationController
        let msgVC = navBAR?.viewControllers.first as? ALMessagesViewController
        msgVC?.messagesViewDelegate = alChatLauncher as! ALMessagesViewDelegate
        appLozicTabBar?.navigationItem.leftBarButtonItem = nil
        self.view.addSubview((appLozicTabBar?.view)!)
        appLozicTabBar?.didMove(toParentViewController: self)
    }

Expected Results

For ex: if someone sent a message to me at very first time (assume Im online), it needs to have a new entry in the chat list.

Actual Results
Its not refreshing (or reloading) when I get a new message from someone.
Applozic SDK version: 3.8.6
Xcode version:  8.3.3
iOS version:  iOS10

You can use refreshMessageList method in ALMessagesViewController to refresh.


Set the mobile viewport width to 1024px

Currently, the Cloud UI is a broken experience on mobile because we haven't designed a fully responsive app. To make the dashboards responsive would require a big effort and constant maintanence.
This PR is a stop-gap solution for mobile users.
Contributes to #2109.

I don't really know what the right trade-off is here :)

I think 1024px is a good pick. Just updated the PR.
Currently, depending on the width of the leaderboards, neither 1024px nor 1150px looks good 100% of the time. 1024px is more conventional than an arbitrary number that matches the state of the UI, which will be a moving target as it evolves over time.


When space is deleted before the wrong word it becomes unmarked

Hi.
In the case when we have two spaces before the wrong word, and delete one of those spaces the word becomes unmarked (as if it became correct). Clicking on it triggers highlighting again.

Is this a problem with the node-spellchecker npm module? Or is this a problem with Atom's spell-check package? According to the API in the README, the only thing this module does is check individual words.

I confirm that the problem is with the spellchecker npm module.

What is being sent to the spellchecker npm module that is causing this issue? Can you post an example snippet of code that reproduces the issue?

@lee-dohm, sorry can't share the code right now.
Spellchecker initialized with this:
webFrame.setSpellCheckProvider('en-US', true, {
        spellCheck: function(text) {
            return !(spellchecker.isMisspelled(text));
        }
    });

Nothing else regarding it.
Just try typing double space before the word with a mistake and then delete one of them.

Sorry, cannot provide live example for it now.
Will reopen as soon as have an opportunity for that.


ggplot parse error in notebook UI

Does this issue occur when all extensions are disabled?: N/A

VS Code Version:
OS Version:

Version: 1.58.2 (user setup)
Commit: c3f126316369cd610563c75b1b1725e0679adfb3
Date: 2021-07-14T22:10:15.214Z
Electron: 12.0.13
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19043

Steps to Reproduce:
Run the following code in Notebook UI by selecting R kernel
ggplot(mpg, aes(displ, hwy, colour = class)) +
    geom_point()

returns
ERROR: Error in parse(text = x, srcfile = src): <text>:1:48: unexpected input
1: ggplot(mpg, aes(displ, hwy, colour = class)) +
^
Error in parse(text = x, srcfile = src): <text>:1:48: unexpected input
1: ggplot(mpg, aes(displ, hwy, colour = class)) +
                                                   ^
Traceback:

However, the following code works
ggplot(mpg, aes(displ, hwy, colour = class)) + geom_point()

This issue is not observed in Jupyter Lab, and it seems like Notebook UI can't understand this "ggplot-style" syntax

@StevenLi-DS Sorry for not getting back to you. Somehow this got lost in a different repo.
We fixed issues with multi-line code in R kernels, see here https://github.com/Microsoft/vscode-jupyter/issues/4576
As usual, if this hasn't fixed it, please create a new issue or feel free to re-open this


Save/Loading PackedScene creates orphans

Tested versions
v4.2.stable.official [46dc27791]
System information
Godot v4.2.stable - Windows 10.0.22631 - GLES3 (Compatibility) - Intel(R) Iris(R) Plus Graphics (Intel Corporation; <IP_ADDRESS>64) - Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 Threads)
Issue description
When saving and loading using PackedScene, stray nodes are consistently created even with very simple setups.
Steps to reproduce

open and run project
click "make pond"
click "spawn duck" at least once
click "save"
click "load"
click "print orphan", you should see that all child nodes of duck.tscn are printed as orphans despite also appearing in game

Minimal reproduction project (MRP)
PackedScene save test.zip

Your _set_owner_recursive() messed up instantiated scene.
Changing node != new_owner to node != new_owner and not node.owner fixes the problem.


Add babel-runtime as a dependency

babel-runtime should be automatically installed by npm if it's required to run trine correctly. Not doing so breaks all of the current conventions of node packaging and makes it more difficult for people to use or understand your package

+1 to this, as I stated on HN. It's the responsibility of the packaging tool and NPM to dedupe dependencies, this should not be done by omitting dependencies and hoping for the best.

This can lead to really hard to debug cases where you have two instances of babel-runtime and each have a different key for Symbol.iterator.
Aside from that, LGTM, thanks for taking the time to contribute! :heart: Could you rebase the PR against the master so that the unnecessary merge commit disappears? Thanks!

Also, just noticed that babel-runtime is duplicated in devDependencies.

@sebmck just answered my question on the Babel slack channel saying that Trine should indeed have babel-runtime as its own dependency.
Could you remove the duplicate babel-runtime from devDependencies so I can merge this? Thank you! :heart:

Merged as #26. Thank you @callmeStriking! :tada:


Add deployment method by using Docker Image.

I think it would be easier for people to deploy with Docker.

It's a good idea, I'll give this task to you :)


After single side withdraw, it says i have -0.0077$ worth to stake

After withdrawing my 2$, it now says if have a minus value to withdraw
Pool: https://opv2.beets.fi/pool/0x39965c9dab5448482cf7e002f583c812ceb53046000100000000000000000003
Address: 0xfd5a3ec3e69ff2b44b6f1fbc168ba2147e241d24

on the my investments list view it shows it as plus value 0.0077 (so its just the dust issue), but somehow in the detail page its a minus value

ok ignore that, its not a minus, but a tilde ~ ... sorry closing :D


Publish package to Open VSX Registry

Open VSX Registry: https://open-vsx.org/
Packages should be uploaded directly from workflows.

This was tried with 284008ce8bb29e91d184824ce2f66e755d1c705c.
Unfortunately, OpenVSX doesn't support multi-target extensions, which is required by Gitignore Ultimate.


OmegaT

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

OmegaT Cask Installer

In the future, please submit separate pull requests for each cask, as more often than not this type of pull request brings problems with one or more of them, and it halts the inclusion of the other ones.


Adds support for restricted wallets and description for logs and improve overall type annotations.

See Issue #8

This pull request attempts to address two distinct areas: enhancing type annotations and introducing a new feature. These concerns are sufficiently separate to warrant individual pull requests. Therefore, it is required you create two distinct pull requests.
Regarding the feature-related pull request, it's imperative to adhere to two crucial requirements. Firstly, provide a comprehensive explanation of the feature's functionality and its applicable use cases. Secondly, ensure that tests are written to cover all conceivable new scenarios thoroughly.
Your contribution is greatly valued, and these steps will enhance the clarity and effectiveness of the project.
Thank you for contributing.

I opened a new pull request that contains a few more changes and tests, #10

@3m1n3nc3
There are some PHPDocs you have previously add/corrected/modifed in this closed PR
https://github.com/HPWebdeveloper/laravel-pay-pocket/pull/9/files
You can now bring them as a separate PR.

@3m1n3nc3
There are some PHPDocs you have previously add/corrected/modifed in this closed PR
https://github.com/HPWebdeveloper/laravel-pay-pocket/pull/9/files
You can now bring them as a separate PR.

Can we start with the restricted wallet feature?

@3m1n3nc3
have you checked my questions mentioned here?
Please explain and let me know the use case you have experienced.
https://github.com/HPWebdeveloper/laravel-pay-pocket/issues/8
Thanks

@3m1n3nc3
can you bring all types correction you previously did and PHPDoc blocks like these as a separate PR?

interface WalletOperations
{
    /**
     * Get User's Wallet Balance
     *
     * @return int|float
     */
    public function getWalletBalanceAttribute(): int|float;

    /**
     * Get the balance of a specific wallet type.
     *
     *
     * @param string $walletType
     *
     * @return float|int
     */
    public function getWalletBalanceByType(string $walletType): float|int;

    /**
     *  Check if User's wallet balance is more than given value
     *
     * @param int|float $value
     *
     * @return bool
     */
    public function hasSufficientBalance(int|float $value): bool;

    ```

@3m1n3nc3
can you bring all types correction you previously did and PHPDoc blocks like these as a separate PR?
these are examples, I saw you have corrected also some type hints. please bring them as well in a single PR.
interface WalletOperations
{
    /**
     * Get User's Wallet Balance
     *
     * @return int|float
     */
    public function getWalletBalanceAttribute(): int|float;

    /**
     * Get the balance of a specific wallet type.
     *
     *
     * @param string $walletType
     *
     * @return float|int
     */
    public function getWalletBalanceByType(string $walletType): float|int;

    /**
     *  Check if User's wallet balance is more than given value
     *
     * @param int|float $value
     *
     * @return bool
     */
    public function hasSufficientBalance(int|float $value): bool;

    ```

Should the PR contain any code reference to #12 or should be based off the current state of the main branch?

The new PR (let's say PR-types) should be pure and independent of any other features.
Make a new branch from the current Main branch.
Please don't add any new code. Just bring those types and phpdocs that you have already coded in this closed PR and not add more.
Regarding the new feature (allowed wallets) we will discuss in another open issues/PR.

The new PR (let's say PR-types) should be pure and independent of any other features.
Make a new branch from the current Main branch.
Please don't add any new code. Just bring those types and phpdocs that you have already coded in this closed PR and not add more.
Regarding the new feature (allowed wallets) we will discuss in another open issues/PR.

@HPWebdeveloper see #13


Add ABFS support for Azure service principal auth

Description
Current ADLS connections are supported through an account-key-based authentication mechanism.
Per the Azure doc, the secured/preferred way of accessing ADLS is using the service principle authentication.
https://learn.microsoft.com/en-us/azure/databricks/connect/storage/azure-storage#azureserviceprincipal

@zhli1142015 Do you have any thoughts on this?

We have Oauth and sas key support internally, if they are needed, we can contribute related code to the community.

Sure.


chore: release 1.2.55

:robot: I have created a release *beep* *boop*
1.2.55 (2021-12-29)
Features

Added login and logout cli commands for container registry (0b7e147)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/werf/werf/releases/tag/v1.2.55 :sunflower:


Separate child node for full text in the back of the Highlight

I hope that each paragraph of the full text can be placed in a separate child node instead of all in the title block and cannot be collapsed. And I would like to see Highlight first and full-text behind.
I would like:

title

Highlight
full-text

paragraph1
paragraph2
……

Btw now the full text is not in the title block but in a child block directly. It's just not (yet?) split into paragraph which is what I'm suggesting in #113


Static directories give 404s without adding a trailing slash

Actual behavior (the bug)
I'm using Javalin to serve APIs and some static pages.
The pages have been registered in the config via:
config.staticFiles.add(staticFile -> {
       staticFile.hostedPath = "/display";
       staticFile.directory = "/frontend/display";
       staticFile.location = Location.CLASSPATH;
});

I'm able to access the page via /display/ and /display/index.html, but using /display it errors out with "404 Not Found".
I've already added config.routing.ignoreTrailingSlashes = true; but it didn't seem to help.
Expected behavior
It should ignore the trailing slash and work as intended
Additional context
I'm using Java 11 and Javalin 5.6.1

Are you trying to serve display.html on /display/?

yes, but from what I have seen it should be possible just by flagging that config option to true

It's a bit tricky, since /display/ is already a shortcut for /display/index.html, it's what called a "welcome file". This only works for the index file of a directory and /display is not a directory. I'm not sure if this would be acceptable behavior.

I made some research and I've found that other users had this issue in the past, in fact some pull requests were made and merged to fix the issue:
https://github.com/javalin/javalin/commit/516d4cc19a9fd91ff379752ea004e3b8395df3af
https://github.com/javalin/javalin/pull/1014/commits/68eb4949a9f92d543c8ecc0a8f0131c9181357b4
https://github.com/javalin/javalin/issues/1459

It was also noted in a changelog of a previous version

Sounds like this is how we want it to work then, I've added a bug label!

Added a test that shows that this does work. Maybe there's something else wrong @UknownGino ?

I've created a simple application with just a simple page logic but the same thing happens.
public static void main(String[] args) {

        Javalin javalin = Javalin.create();
        javalin.updateConfig(config -> {

            config.staticFiles.add(staticFile -> {
                staticFile.directory = "/frontend/test";
                staticFile.location = Location.CLASSPATH;
                staticFile.hostedPath = "/test";
            });

        });

        javalin.start(30);

}

On <IP_ADDRESS>:30/test/ and ~/test/index.html it just works but on ~/test it still says Not Found
The logic is the exact same as the Test

Strange - are you able to create a failing test for it in a PR?

Sorry, I'm not very familiar with Kotlin but I've cloned the repo and the test passes fine on my machine. Even tho, my application still doesn't work with the same config as the test.
Comparison:

Even tho, my application still doesn't work with the same config as the test.

Can you create a minimal github repo?

Here you are: https://github.com/UknownGino/JavalinTrailingTest

Thanks @UknownGino, seeing the same issue here.

I will try to look into this, if no one else already.

@UknownGino the PR above shoud fix this problem.

@UknownGino the PR above shoud fix this problem.

Thanks to both of you


0.3.0

What is this PR for?

[ ] Just updating content and/or documentation
[ ] This fixes issue #_____
[ ] Spot fix (no issue #)
[ ] Merging WIP feature #_____
[ ] Merging done feature #_____
[x] This is a merge from a version branch
[ ] Adding/Updating tests
[x] This is a conflict resolution
[ ] This is a branch cleanup
[ ] Other: ________________

I verify that...

[ ] I have logged my time in the commits
[ ] I have logged my time in this PR
[x] I have tagged all the relevant issues
[x] I am using VS Code for type checks and linting, or
[x] I have ran npm run test with no errors
[x] I have manually checked that this bug or feature is working

👋 @cblanquera
Thank you for raising your pull request. Please make sure you have followed our contributing guidelines. If you haven't done so in your commits, please reference the issue numbers as well as the time you spent on this in the comments below so we can track time. example fixed button #1001 3h


Add Rust-native implementation matching available dav1d assembly

For x86_64 builds of rav1e at the time of opening this issue, there are 212 functions included in assembly that are not referenced by rav1e Rust code. These mostly correspond to features that are yet unimplemented. Some are for existing features with assembly integration friction.

rav1e_blend_16bpc_avx2
rav1e_blend_16bpc_ssse3
rav1e_blend_8bpc_avx2
rav1e_blend_8bpc_avx512icl
rav1e_blend_8bpc_ssse3
rav1e_blend_h_16bpc_avx2
rav1e_blend_h_16bpc_ssse3
rav1e_blend_h_8bpc_avx2
rav1e_blend_h_8bpc_avx512icl
rav1e_blend_h_8bpc_ssse3
rav1e_blend_v_16bpc_avx2
rav1e_blend_v_16bpc_ssse3
rav1e_blend_v_8bpc_avx2
rav1e_blend_v_8bpc_avx512icl
rav1e_blend_v_8bpc_ssse3
rav1e_cdef_dir_16bpc_sse4
rav1e_cdef_dir_16bpc_ssse3
rav1e_cdef_dir_8bpc_sse4
rav1e_cdef_dir_8bpc_ssse3
rav1e_cdef_filter_4x4_16bpc_avx2
rav1e_cdef_filter_4x4_16bpc_ssse3
rav1e_cdef_filter_4x4_8bpc_sse2
rav1e_cdef_filter_4x4_8bpc_sse4
rav1e_cdef_filter_4x4_8bpc_ssse3
rav1e_cdef_filter_4x8_16bpc_avx2
rav1e_cdef_filter_4x8_16bpc_ssse3
rav1e_cdef_filter_4x8_8bpc_sse2
rav1e_cdef_filter_4x8_8bpc_sse4
rav1e_cdef_filter_4x8_8bpc_ssse3
rav1e_cdef_filter_8x8_16bpc_avx2
rav1e_cdef_filter_8x8_16bpc_ssse3
rav1e_cdef_filter_8x8_8bpc_sse2
rav1e_cdef_filter_8x8_8bpc_sse4
rav1e_cdef_filter_8x8_8bpc_ssse3
rav1e_emu_edge_16bpc_avx2
rav1e_emu_edge_16bpc_ssse3
rav1e_emu_edge_8bpc_avx2
rav1e_emu_edge_8bpc_ssse3
rav1e_inv_txfm_add_wht_wht_4x4_16bpc_avx2
rav1e_inv_txfm_add_wht_wht_4x4_16bpc_sse2
rav1e_inv_txfm_add_wht_wht_4x4_8bpc_avx2
rav1e_inv_txfm_add_wht_wht_4x4_8bpc_sse2
rav1e_ipred_cfl_ac_420_16bpc_avx2
rav1e_ipred_cfl_ac_420_8bpc_avx2
rav1e_ipred_cfl_ac_420_8bpc_ssse3
rav1e_ipred_cfl_ac_422_16bpc_avx2
rav1e_ipred_cfl_ac_422_8bpc_avx2
rav1e_ipred_cfl_ac_422_8bpc_ssse3
rav1e_ipred_cfl_ac_444_16bpc_avx2
rav1e_ipred_cfl_ac_444_8bpc_avx2
rav1e_ipred_cfl_ac_444_8bpc_ssse3
rav1e_ipred_filter_16bpc_avx2
rav1e_ipred_filter_8bpc_avx2
rav1e_ipred_filter_8bpc_ssse3
rav1e_mask_16bpc_avx2
rav1e_mask_16bpc_ssse3
rav1e_mask_8bpc_avx2
rav1e_mask_8bpc_avx512icl
rav1e_mask_8bpc_ssse3
rav1e_obmc_masks_avx2
rav1e_pal_pred_16bpc_avx2
rav1e_pal_pred_8bpc_avx2
rav1e_pal_pred_8bpc_ssse3
rav1e_prep_8tap_16bpc_avx2
rav1e_prep_8tap_16bpc_ssse3
rav1e_prep_8tap_8bpc_avx2
rav1e_prep_8tap_8bpc_avx512icl
rav1e_prep_8tap_8bpc_sse2
rav1e_prep_8tap_8bpc_ssse3
rav1e_prep_8tap_scaled_16bpc_avx2
rav1e_prep_8tap_scaled_16bpc_ssse3
rav1e_prep_8tap_scaled_8bpc_avx2
rav1e_prep_8tap_scaled_8bpc_ssse3
rav1e_prep_8tap_scaled_regular_16bpc_avx2
rav1e_prep_8tap_scaled_regular_16bpc_ssse3
rav1e_prep_8tap_scaled_regular_8bpc_avx2
rav1e_prep_8tap_scaled_regular_8bpc_ssse3
rav1e_prep_8tap_scaled_regular_sharp_16bpc_avx2
rav1e_prep_8tap_scaled_regular_sharp_16bpc_ssse3
rav1e_prep_8tap_scaled_regular_sharp_8bpc_avx2
rav1e_prep_8tap_scaled_regular_sharp_8bpc_ssse3
rav1e_prep_8tap_scaled_regular_smooth_16bpc_avx2
rav1e_prep_8tap_scaled_regular_smooth_16bpc_ssse3
rav1e_prep_8tap_scaled_regular_smooth_8bpc_avx2
rav1e_prep_8tap_scaled_regular_smooth_8bpc_ssse3
rav1e_prep_8tap_scaled_sharp_16bpc_avx2
rav1e_prep_8tap_scaled_sharp_16bpc_ssse3
rav1e_prep_8tap_scaled_sharp_8bpc_avx2
rav1e_prep_8tap_scaled_sharp_8bpc_ssse3
rav1e_prep_8tap_scaled_sharp_regular_16bpc_avx2
rav1e_prep_8tap_scaled_sharp_regular_16bpc_ssse3
rav1e_prep_8tap_scaled_sharp_regular_8bpc_avx2
rav1e_prep_8tap_scaled_sharp_regular_8bpc_ssse3
rav1e_prep_8tap_scaled_sharp_smooth_16bpc_avx2
rav1e_prep_8tap_scaled_sharp_smooth_16bpc_ssse3
rav1e_prep_8tap_scaled_sharp_smooth_8bpc_avx2
rav1e_prep_8tap_scaled_sharp_smooth_8bpc_ssse3
rav1e_prep_8tap_scaled_smooth_16bpc_avx2
rav1e_prep_8tap_scaled_smooth_16bpc_ssse3
rav1e_prep_8tap_scaled_smooth_8bpc_avx2
rav1e_prep_8tap_scaled_smooth_8bpc_ssse3
rav1e_prep_8tap_scaled_smooth_regular_16bpc_avx2
rav1e_prep_8tap_scaled_smooth_regular_16bpc_ssse3
rav1e_prep_8tap_scaled_smooth_regular_8bpc_avx2
rav1e_prep_8tap_scaled_smooth_regular_8bpc_ssse3
rav1e_prep_8tap_scaled_smooth_sharp_16bpc_avx2
rav1e_prep_8tap_scaled_smooth_sharp_16bpc_ssse3
rav1e_prep_8tap_scaled_smooth_sharp_8bpc_avx2
rav1e_prep_8tap_scaled_smooth_sharp_8bpc_ssse3
rav1e_prep_bilin_scaled_16bpc_avx2
rav1e_prep_bilin_scaled_16bpc_ssse3
rav1e_prep_bilin_scaled_8bpc_avx2
rav1e_prep_bilin_scaled_8bpc_ssse3
rav1e_put_8tap_16bpc_avx2
rav1e_put_8tap_16bpc_ssse3
rav1e_put_8tap_8bpc_avx2
rav1e_put_8tap_8bpc_avx512icl
rav1e_put_8tap_8bpc_ssse3
rav1e_put_8tap_scaled_16bpc_avx2
rav1e_put_8tap_scaled_16bpc_ssse3
rav1e_put_8tap_scaled_8bpc_avx2
rav1e_put_8tap_scaled_8bpc_ssse3
rav1e_put_8tap_scaled_regular_16bpc_avx2
rav1e_put_8tap_scaled_regular_16bpc_ssse3
rav1e_put_8tap_scaled_regular_8bpc_avx2
rav1e_put_8tap_scaled_regular_8bpc_ssse3
rav1e_put_8tap_scaled_regular_sharp_16bpc_avx2
rav1e_put_8tap_scaled_regular_sharp_16bpc_ssse3
rav1e_put_8tap_scaled_regular_sharp_8bpc_avx2
rav1e_put_8tap_scaled_regular_sharp_8bpc_ssse3
rav1e_put_8tap_scaled_regular_smooth_16bpc_avx2
rav1e_put_8tap_scaled_regular_smooth_16bpc_ssse3
rav1e_put_8tap_scaled_regular_smooth_8bpc_avx2
rav1e_put_8tap_scaled_regular_smooth_8bpc_ssse3
rav1e_put_8tap_scaled_sharp_16bpc_avx2
rav1e_put_8tap_scaled_sharp_16bpc_ssse3
rav1e_put_8tap_scaled_sharp_8bpc_avx2
rav1e_put_8tap_scaled_sharp_8bpc_ssse3
rav1e_put_8tap_scaled_sharp_regular_16bpc_avx2
rav1e_put_8tap_scaled_sharp_regular_16bpc_ssse3
rav1e_put_8tap_scaled_sharp_regular_8bpc_avx2
rav1e_put_8tap_scaled_sharp_regular_8bpc_ssse3
rav1e_put_8tap_scaled_sharp_smooth_16bpc_avx2
rav1e_put_8tap_scaled_sharp_smooth_16bpc_ssse3
rav1e_put_8tap_scaled_sharp_smooth_8bpc_avx2
rav1e_put_8tap_scaled_sharp_smooth_8bpc_ssse3
rav1e_put_8tap_scaled_smooth_16bpc_avx2
rav1e_put_8tap_scaled_smooth_16bpc_ssse3
rav1e_put_8tap_scaled_smooth_8bpc_avx2
rav1e_put_8tap_scaled_smooth_8bpc_ssse3
rav1e_put_8tap_scaled_smooth_regular_16bpc_avx2
rav1e_put_8tap_scaled_smooth_regular_16bpc_ssse3
rav1e_put_8tap_scaled_smooth_regular_8bpc_avx2
rav1e_put_8tap_scaled_smooth_regular_8bpc_ssse3
rav1e_put_8tap_scaled_smooth_sharp_16bpc_avx2
rav1e_put_8tap_scaled_smooth_sharp_16bpc_ssse3
rav1e_put_8tap_scaled_smooth_sharp_8bpc_avx2
rav1e_put_8tap_scaled_smooth_sharp_8bpc_ssse3
rav1e_put_bilin_scaled_16bpc_avx2
rav1e_put_bilin_scaled_16bpc_ssse3
rav1e_put_bilin_scaled_8bpc_avx2
rav1e_put_bilin_scaled_8bpc_ssse3
rav1e_resize_16bpc_avx2
rav1e_resize_16bpc_ssse3
rav1e_resize_8bpc_avx2
rav1e_resize_8bpc_avx512icl
rav1e_resize_8bpc_ssse3
rav1e_sgr_filter_3x3_16bpc_avx2
rav1e_sgr_filter_3x3_8bpc_avx2
rav1e_sgr_filter_5x5_16bpc_avx2
rav1e_sgr_filter_5x5_8bpc_avx2
rav1e_sgr_filter_mix_16bpc_avx2
rav1e_sgr_filter_mix_8bpc_avx2
rav1e_sgr_x_by_x_avx2
rav1e_warp_affine_8x8_16bpc_avx2
rav1e_warp_affine_8x8_16bpc_ssse3
rav1e_warp_affine_8x8_8bpc_avx2
rav1e_warp_affine_8x8_8bpc_avx512icl
rav1e_warp_affine_8x8_8bpc_sse2
rav1e_warp_affine_8x8_8bpc_sse4
rav1e_warp_affine_8x8_8bpc_ssse3
rav1e_warp_affine_8x8t_16bpc_avx2
rav1e_warp_affine_8x8t_16bpc_ssse3
rav1e_warp_affine_8x8t_8bpc_avx2
rav1e_warp_affine_8x8t_8bpc_avx512icl
rav1e_warp_affine_8x8t_8bpc_sse2
rav1e_warp_affine_8x8t_8bpc_sse4
rav1e_warp_affine_8x8t_8bpc_ssse3
rav1e_w_avg_16bpc_avx2
rav1e_w_avg_16bpc_ssse3
rav1e_w_avg_8bpc_avx2
rav1e_w_avg_8bpc_avx512icl
rav1e_w_avg_8bpc_ssse3
rav1e_wiener_filter5_16bpc_avx2
rav1e_wiener_filter5_8bpc_avx2
rav1e_wiener_filter7_16bpc_avx2
rav1e_wiener_filter7_8bpc_avx2
rav1e_w_mask_420_16bpc_avx2
rav1e_w_mask_420_16bpc_ssse3
rav1e_w_mask_420_8bpc_avx2
rav1e_w_mask_420_8bpc_avx512icl
rav1e_w_mask_420_8bpc_ssse3
rav1e_w_mask_422_16bpc_avx2
rav1e_w_mask_422_16bpc_ssse3
rav1e_w_mask_422_8bpc_avx2
rav1e_w_mask_422_8bpc_avx512icl
rav1e_w_mask_422_8bpc_ssse3
rav1e_w_mask_444_16bpc_avx2
rav1e_w_mask_444_16bpc_ssse3
rav1e_w_mask_444_8bpc_avx2
rav1e_w_mask_444_8bpc_avx512icl
rav1e_w_mask_444_8bpc_ssse3

There is a new project related to this issue: https://github.com/memorysafety/rav1d
When it reaches initial release, we might attempt integration.


Allow rating select to be a number when not interactive

I want to display a rating composed of 2 votes : 2/5 and 5/5, that is the result is 3.5/5.
We should display half a star for the 4th one, and only if not interactive.
I created such a component some time ago, maybe it can help: https://gist.github.com/tanguilp/d32a89fe1e3f5b96a1397fa1434c1f94

Hi @tanguilp
Thank you so much for your suggestion! We truly appreciate your input.
This feature requires a few adjustments, and we're currently in the process of releasing a new version. However, we’re excited to let you know that we plan to include this feature in one of the next two versions.
Thanks again for your valuable feedback.


ListBoxItem - Adding onFocusChange

Provide a general summary of the feature here
We are rendering a Tooltip for ListBoxItem if it is truncated. And we want to show it when it is either hovered or focused. But it seems like the ListBoxItem is currently missing a onFocusChange event to know whether or not it is in focus.
🤔 Expected Behavior?
API example:
<ListBoxItem onFocusChange={(isFocused) => doSomething(isFocused)} />

😯 Current Behavior
Currently no event do detect a focus change is exported.
💁 Possible Solution
No response
🔦 Context
<AriaListBoxItem
  onHoverChange={() => evaluateTruncation()}
>
  {item => (
      <Tooltip_Default
        triggerRef={objectRef}
        isOpen={isTruncate && (item.isHovered || item.isFocused)}
      >
         <Text_Block slot="label" isTruncated ref={textRef}>
            {typeof children === 'function' ? children(item) : children}
          </Text_Block>

      </Tooltip_Default>
  )}
</AriaListBoxItem>

This is a rough draft of what are working with today. We'd like to be able to do:
<AriaListBoxItem
  onHoverChange={() => evaluateTruncation()}
  onFocusChange={() => evaluateTruncation()}
>
  {item => (
      <Tooltip_Default
        triggerRef={objectRef}
        isOpen={isTruncate && (item.isHovered || item.isFocused)}
      >
         <Text_Block slot="label" isTruncated ref={textRef}>
            {typeof children === 'function' ? children(item) : children}
          </Text_Block>

      </Tooltip_Default>
  )}
</AriaListBoxItem>

💻 Examples
No response
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

Just adding onFocusChange wouldn't handle this.
Work to support Tooltips in Collections is under discussion here https://github.com/adobe/react-spectrum/pull/7289.
For now, you can display the truncated name by instead wrapping, or using a gridlist layout with a button that shows the full name in a popover, or using selection/actions to open a panel displaying the name/metadata

@snowystinger thanks I have a solution in place where I evaluate if the SelectorItem is truncated in a custom hook. Just wanted to highlight that I think this should be a feature in the Item. Eventhough Tooltips might work out of the box in the Item in the future I still think some sort of event for focus would be great.


Chore/ruby upgrade

Staging is already running on 3.2.2 :tada:

Yeah, probably, never tried that in Ruby.


TypeError: Cannot read properties of undefined (reading 'array')

Hello, I'm using the example https://codesandbox.io/s/mlgzsc, and I just changed the loaded glb file from the rabbit to my own model. However, the program is reporting an error as shown in the title. What should I do?

@KIC-Crack Faced the same error last week when I loaded a model that didn't have attributes.uv, which the underlying library is explicitly looking for.
A workaround for me was to populate attributes.uv with an empty array after load:
geometry.setAttribute('uv', new BufferAttribute(new Float32Array([]), 1))


Plugin for autodetection of psake tasks in VS-Code

Hi,
It was nice to see the integration of grunt in VS-Code by means of auto-detection.
Is there any plan for a psake-vscode-plugin for integration of psake tasks into VS-code?
Refer: https://code.visualstudio.com/docs/editor/tasks#_autodetecting-gulp-grunt-and-jake-tasks

There is already a VS Code plugin for psake here https://github.com/psake/psake-vscode. It currently only provides snippets.

@eweilnau yes, it is a very basic addin, but it could certainly be expanded.

@devblackops I have recently went through this process for Cake (finding Tasks based on the presence of a build.cake file).  Now that we are standardising on a specific name for the psake file, the VSCode extension could easily be updated to look for the presence of this file, and if it finds it, list out all of the available tasks, and then execute the specified one.

Which VSCode extension?  AFAIK psake has no VSCode ext other than one for snippets.  Or are you talking about the PowerShell extension for VSCode?  Or are you talking about creating a psake extension?  Maybe spin up a psake\VSCode project?

OK, just saw the reference to the snippets code extension.  Yes, that could be extended to add task auto-detection and a built-in $psake problem matcher.

@gep13 That would be awesome!

@devblackops @rkeithhill let me see if I can carve out some time to do this 😄

I am going to go ahead and close this issue, as it will now be tracked over here: https://github.com/psake/psake-vscode/issues/3


python312Packages.aiohomeconnect: init at 0.6.0

An asyncio client for the Home Connect API
https://github.com/MartinHjelmare/aiohomeconnect

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 360584

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.aiohomeconnect
python311Packages.aiohomeconnect.dist
python312Packages.aiohomeconnect
python312Packages.aiohomeconnect.dist