Remove docs dependency on test-reg branch of ksonnet/parts

This was always supposed to be a dev branch so we didn't churn master. Now everything is merged into master and we'd like to center development on it.
(This probably involves cleaning up the ELK templates)

This is an issue in the ksonnet/parts repo. Migrating: #50 .
Also don't think this is a blocker for release; more of a p1. We are using master as opposed to test-reg as of #151 . On a quick search of the CLI repo, I could not identify any other test-reg references.


Make all 1kg, esp, exac aaf columns default to -1 if unknown.

In the interest of homogeneity with the new max_aaf_all column.

 In the interest of homogeneity with the new max_aaf_all column.


HMS-3155 test: update domain (user)

This smoke test add an update operation by a user for an existing domain.
It depends on #60

Content cherry-picker on #42 ; closing.


There is a build error.

I upgrade to latest version and try to build my doc, i got an error.
look's like your @mr-hope/vuepress-plugin-comment is dependencies on "leancloud-storage": "^4.6.1".

sorry, i found why this error occured. i using the https://registry.npm.taobao.org for yarn registry. the "leancloud-storage": "^4.6.1" is not exits.

A tip here:
You can always use https://npm.taobao.org/sync/<package-name> to sync a package, for example https://npm.taobao.org/sync/leancloud-storage


opt-out

Related to https://github.com/rust-lang-nursery/thanks/issues/42, an explicit opt out is a good call.
This information is public, as in, it's in the github history for anyone to see, but if someone doesn't want their name on this page for some reason, we should respect that.
I am happy to do this manually for now, but it's gonna need to be automated in some fashion.

Blocked on infrastructure work that's part of https://github.com/rust-lang-nursery/thanks/issues/8

I could work on that (cannot commit to work on higher priority issues right now like fixing support for multiple projects due to a lack of time).
I think we should do the following:

finally normalize the database and pull the authors out of commits to their own table;
add a new binary (e.g. opt-out) that will mark the author as opted-out (or create a new one marked as opted-out from the start -- if someone wants to opt-out before their project is added to thanks);
fix front-end to respect that.

Going with this approach we would still have the names/emails in the database (just not show them in the front-end), but I think it is acceptable as this data is publicly available in the repos on GitHub. If not, then we should investigate some other solution.

finally normalize the database and pull the authors out of commits to their own table;

💯

add a new binary (e.g. opt-out) that will mark the author as opted-out

💯

fix front-end to respect that.

👍 , luckily this shouldn't need any real front-end work, just modifying queries, which you'll have to do anyway for 1.

I think it is acceptable as this data is publicly available in the repos on GitHub

Yes, this is about ease of getting the information; in my experience, this would be fine. Nobody has straight-up wanted to opt out yet, so I can't consult anyone directly.

https://github.com/rust-lang-nursery/thanks/pull/72 closes this!


Sharding support

Due new dart sdk feature send-and-exit, sharding could be implemented successfully without big memory and cpu overhead.
It need more investigation and testing before implementing.
Related:
https://github.com/dart-lang/sdk/issues/37835

Sharding draft implemented in 51b132209483fb79c8244602fe0534a75287e9e8, 51b132209483fb79c8244602fe0534a75287e9e8 and 9a2d39091a7d09520b7bea43df280717c71fcb33


Accept ServerRequestInterface and InputInterface as source

I'd like to dicuss the possibility of creating additional sources for Psr\Http\Message\ServerRequestInterface and Symfony\Console\Command\Command.
Do you think this will give the library more value?
The specific use case I was thinking about is using the Mapper to create strongly-typed DTOs automatically inside the Command or at the Controller level.
For example, the following could be a rough draft for an InputSource:
<?php

declare(strict_types=1);

namespace CuyZ\Valinor\Mapper\Source;

use ArrayObject;
use IteratorAggregate;
use Symfony\Component\Console\Input\InputInterface as Input;
use Traversable;

use function array_merge;

final class InputSource implements IteratorAggregate
{
    public function __construct(
        private Input $input,
    ) {
    }

    public function getInput(): Input
    {
        return $this->input;
    }

    public function getIterator(): Traversable
    {
        $input = $this->getInput();

        $array = array_merge($input->getOptions(), $input->getArguments());

        return new ArrayObject($array);
    }
}

And for a ServerRequestSource:
<?php

declare(strict_types=1);

namespace CuyZ\Valinor\Mapper\Source;

use ArrayObject;
use IteratorAggregate;
use Psr\Http\Message\ServerRequestInterface as Request;
use Traversable;

use function array_merge;
use function is_array;

final class ServerRequestSource implements IteratorAggregate
{
    public function __construct(
        private Request $request,
    ) {
    }

    public function getIterator(): Traversable
    {
        $method = $request->getMethod();

        $queryParams = $this->getRequest()->getQueryParams();

        $parsedBody = $this->getRequest()->getParsedBody();

        if (! is_array($parsedBody)) {
            return $queryParams;
        }

        $array = array_merge($parsedBody, $queryParams);

        return new ArrayObject($array);
    }

    public function getRequest(): Request
    {
        return $this->request;
    }
}

Thoughts?

Hi @delolmo, this is an excellent example of how iterators can be used with the library.
For the future of the project I plan to create bundles/plugins for frameworks, so something similar to what you posted will probably land in these packages, but wont be imported in the core of the library.
Thank you for the suggestion, I close the issue but keep it in my mind for future reference. 😉

I just published two packages, delolmo/valinor-http-message and delolmo/valinor-console, in case anyone ones to use this implementation. Will be happy to transition to the bundles/plugins approach @romm when you are ready. Good job with the library!


Avoid Iterator allocations in AggregateCollector

Codecov Report

Merging #5155 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master    #5155     +/-   ##
===========================================
- Coverage     82.55%   82.45%   -0.1%
+ Complexity    11031    11014     -17
===========================================
  Files          1331     1331
  Lines         45079    45079
  Branches       5667     5667
===========================================
- Hits          37214    37170     -44
- Misses         5226     5264     +38
- Partials       2639     2645      +6

Impacted Files
Coverage Δ
Complexity Δ

...io/crate/operation/projectors/AggregationPipe.java
100% <ø> (ø)
5 <0> (ø)
:arrow_down:

...crate/operation/projectors/AggregateCollector.java
100% <100%> (ø)
12 <3> (ø)
:arrow_down:

...n/java/io/crate/exceptions/JobKilledException.java
0% <0%> (-66.67%)
0% <0%> (-1%)

...o/crate/analyze/SafeExpressionToStringVisitor.java
83.33% <0%> (-16.67%)
7% <0%> (-1%)

...ration/collect/collectors/OrderedDocCollector.java
90% <0%> (-10%)
5% <0%> (-1%)

.../java/io/crate/analyze/symbol/ParameterSymbol.java
87.5% <0%> (-6.25%)
6% <0%> (-1%)

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
75% <0%> (-5%)
2% <0%> (ø)

...or/transport/distributed/DistributingConsumer.java
79.16% <0%> (-4.17%)
20% <0%> (ø)

.../collect/collectors/LuceneOrderedDocCollector.java
90.12% <0%> (-3.71%)
25% <0%> (-1%)

...nce/sys/check/node/DiskWatermarkNodesSysCheck.java
66.66% <0%> (-3.71%)
7% <0%> (-1%)

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4f7e4...e28d197. Read the comment docs.


Issues and PR Page

Separate Page Needed, In that page all the opened PRs and issues need to displayed
Tips: Use GitHub REST API or GraphQL API to fetch all opened PRs and Issues on SLIIT FOSS GitHub org

hey @Shehanka could you please elaborate on this?

hey @Shehanka could you please elaborate on this?

I have added above


Scalar Upload generated type from graphql-binding as a string

is it suppose to be like this below?
export type Upload = {
      stream: NodeJS.ReadableStream
      filename: string
      mimtype: string
      encoding: string
}

I'm not sure exactly what that library and the type is about, but the Upload scalar represents a Promise, that resolves an object like you noted (for the current version, it's about to change a little). It can't be serialized.

@jaydenseric Thanks for short notice on the upcoming version!, as for the library it's an auto-generated type for schema but put that aside I still don't know what cause it to be like that

Well, here is the source for the GraphQLUpload scalar: https://github.com/jaydenseric/apollo-upload-server/blob/v6.0.0-alpha.1/src/types.mjs#L3
Is there a way it can somehow be improved so auto-generated types are more useful? Does a type make sense in this context? Perhaps this is really an issue to be solved in the auto-type-generation library.

Hey @thanatchakromsang what generator are you using for that type system? Using apollo-cli you can use --passthroughCustomScalars and --customScalarsPrefix for both Flow and TypeScript generators, which allows you to define types for custom scalars.
For example, I use:
// @flow
declare type $GraphQLUpload = File | Blob;

(Didn't mean to close; hit the wrong button.)

OK, I see in your title that you're using graphql-binding. It looks like this is a limitation of their generator, so I am going to close this here. They will likely need to implement better support for custom scalars on their end to get correct typing.

@mike-marcacci Thanks for clearing that up for me :)


approx_grad is untested

I think it might have problems, but I'm not sure.  Maybe someone who knows exactly what it's supposed to do could add a couple tests?

indeed is tested, no relevant content left here - closing


Add autoescaping to Jinja2 Report Environment

By default Jinja doesn't escape input provided to the Environment object, which is used to render data onto a template. While for text output this might not be too critical, many Markdown viewers allow embedding HTML, which leaves a potential attacker the option to embed JavaScript and do funny things.
While it's not super likely that an attacker will submit a well-crafted function name that's valid Solidity code or someone blindly piping their Mythril text output into an html/md file, we might want to be on the safe side here until the Jinja2 team enabled escaping by default.

 I take it all back :laughing:


Behind corporate proxy - Draft/DrawIO 419 Expired

Experiencing this issue when I attempt to save a DrawIO drawing, or when drafts are saved in the background.

I am sitting behind a corporate proxy.
If I set windows to not use the proxy for the Bookstack domain, then it works all fine.

Is there anyway to set this up on the application side?
The response is:
The page has expired due to inactivity.
Please refresh and try again.

DrawIO Save (POST) or Draft Save (PUT)
Request URL:http://mydocs.domain.co.uk/images/drawio
Request method:POST
Remote address:<IP_ADDRESS>:3128
Status code:
419
Version:HTTP/1.1
Referrer Policy:no-referrer-when-downgrade

Response headers (630 B)
Raw headers
Cache-Control
no-cache, private
Connection
keep-alive
Content-Type
text/html; charset=UTF-8
Date
Tue, 03 Dec 2019 11:48:27 GMT
Server
nginx
Set-Cookie
bookstack_session=eyJpdiI6Ilhk…ax-Age=7200; path=/; HttpOnly
Transfer-Encoding
chunked
X-Cache
MISS from proxynode03
X-Cache-Lookup
MISS from proxynode03:3128

Request headers (1.525 kB)
Raw headers
Accept
*/*
Accept-Encoding
gzip, deflate
Accept-Language
en-GB,en;q=0.5
baseURL
http://mydocs.domain.co.uk/
Cache-Control
no-cache
Connection
keep-alive
Content-Length
2770
Content-Type
application/json
Cookie
_pk_id.3.c199=1041443ad1326db1…Tg2MWZjMjQ5YmZhMGJmNGQzIn0%3D
Host
mydocs.domain.co.uk
Origin
http://mydocs.domain.co.uk
Pragma
no-cache
Referer
http://mydocs.domain.co.uk/books…test/page/first-test-page/edit
User-Agent
Mozilla/5.0 (Windows NT 10.0; …) Gecko/20100101 Firefox/70.0
X-CSRF-TOKEN
aymLSRktZslsXfEdoFlT3BfiK4uMMInYOyOrpwIA

Hi @qerim,
Sorry to hear you're having issues with this. Might be hard for me to help on this one since it'll be hard for me to replicate the exact proxy setup.
This could happen if cookies were not properly being sent on these requests, but it's hard to tell from the above since the cookie values are truncated.
Are you able to access the BookStack demo (https://demo.bookstackapp.com) site via the proxy? Would be interesting to see if that same happens there.

@ssddanbrown The demo Bookstack site seems to work well, no issues. I think it's to do with my setup and permissions. I took a look at this: https://github.com/laravel/framework/issues/26106#issuecomment-444723768 . Will try to go over it later and get it working.
I'm closing this as it's clearly not a Bookstack issue. Thanks.


Merge GA bug fix (8161273) to PowerShell repo: Device Guard Bypass - Powershell does not verify if wldp.dll failed to load correctly

SD change list number: 728430

This issue is addressed with PR #3434.


Poppler v23.10.0

Package for poppler v23.10.0
Supercedes #55
Checklist:

[x] I have confirmed that poppler-feedstock has been updated.
[x] I have bumped package.sh POPPLER_VERSION to the current build.

Sorry for the delay. I'll tackle this tomorrow!

Looks like we are missing pixman-1-0.dll


View on Bitbucket 404s

The plugin opens a new window to the bitbucket path that uses /commit/ in the URL path, but it should use /commits/ instead. Quick fix, just add an s.

You are looking for the gitblame.isWebPathPlural setting.


setProps and setData error in beta.30 version

Version
1.0.0-beta.29
Reproduction link
https://github.com/coreui/coreui-vue/tree/bc1cf959325aee78d692e000184825c43294e158
Steps to reproduce

clone repo: https://github.com/coreui/coreui-vue/tree/bc1cf959325aee78d692e000184825c43294e158
npm i
npm run test (then all test passes)
update @vue-test-utils to beta.30
npm run test

What is expected?
beta.30 version doesn't break existing tests
What is actually happening?
beta.30 version breaks existing tests

In beta.29 all my tests are passing, after update to beta.30 many tests that are using "setProps" and "setData" methods are failing.
P.S. there is no possibility to chose beta.30 from versions in issue generator.

I'm having the same problem with you. You can try using nextTick as a workaround.

@woothu this is expected behaviour, as beta29 still had synchronous updates as the default behaviour, whereas beta30 removes the option entirely and only allows asynchronous updates. This requires waiting for Vue.nextTick() or wrapper.vm.$nextTick() after triggering DOM changes.
Because this project is still in beta, there are no guarantees of backwards-compatibility between versions.

@vvanpo Moving from synchronous to asynchronous updates is a huge change, especially when users will not know why all their tests are now breaking. In my case it broke 56 of my 70 tests, so updating each test with Vue.nextTick() was not a good option. beta.30 also seems to be handling Vue transitions differently, causing further breaking tests. I have now learnt my lesson and limited my package.json to beta.29.

Yep, it's an unfortunate outcome of a core Vue project being kept in beta for so long while the rest of the Vue ecosystem has stable releases. Everyone is in the same boat, most will have to pin their version to beta.29 until they can find the time to update all of their tests.

Is there a reason to completely remove the synchronous option? Is it just down to Vue itself? For tests it would be nice if there was an option I could force the state without having to wait for the next tick

@woothu this is expected behaviour, as beta.29 still had synchronous updates as the default behaviour, whereas beta.30 removes the option entirely and only allows asynchronous updates. This requires waiting for Vue.nextTick() or wrapper.vm.$nextTick() after triggering DOM changes.
Because this project is still in beta, there are no guarantees of backwards-compatibility between versions.

It would be nice if you mention breaking changes on release notes, especially as your tool is widely used on user's production environments.

@woothu Actually they did. https://github.com/vuejs/vue-test-utils/blob/dev/CHANGELOG.md#breaking-changes

I meant release notes https://github.com/vuejs/vue-test-utils/releases

Oh I see. Maybe something wrong with the release process because the script looks fine https://github.com/vuejs/vue-test-utils/blob/dev/package.json#L21

Maybe it was set by setData method  😂

Is there a reason to completely remove the synchronous option? Is it just down to Vue itself? For tests it would be nice if there was an option I could force the state without having to wait for the next tick

There is some background here: https://github.com/vuejs/vue-test-utils/issues/1137
I agree that synchronous updates were very convenient, but it seems that maintaining a synchronous capability within Vue.js purely for testing was troublesome.

We've encountered issues (after adding a nextTick wait after all set data/props and event triggers), but now the transition  hooks afterLeave and afterEnter no longer fire, no matter how many nextTicks or sleeps we do (this is without the transition stubs)

@tmorehouse For me, the output changes from

 to

<transition
  tag="div" name="slide-down"
  mode="out-in"
>

</transition>

@tmorehouse You can try to stub the transition component. It works for me.
stubs: {
	transition: {
	  render: function (h) {
	    return this.$options._renderChildren
	  }
	}
}

Note: You still need to await wrapper.vm.$nextTick() though.

Hi @hiendv and @tmorehouse! Would it be possible for either of you to provide me with a reproduction repo that demonstrates issues with afterLeave/afterEnter for transition components? I would love to investigate and then put @hiendv's workaround into the docs.

@JessicaSachs
Sorry for my mistake, my workaround solves rendering issue when it won't flush the final output, not the hooks issue.
See: Component Foo and its tests. - 1st test fails.
It also has an interesting outcome here:
When I write the rest of the template with v-else, I don't need to stub anymore !? :D
See: Component Fooo and its tests. - None fails.

For @tmorehouse issue, I can't reproduce it.
See: Component Bar and its tests. - None fails.

Thank you so much for those reproductions. I see. Yeah, we should provide more documentation on the removal of transition stub and workarounds. I'm going to close this issue after writing some docs up for both the transitions stub and async/sync test conversions.

@JessicaSachs I totally agree with you. But do mind one thing that my workaround is much simplified from the removed TransitionStub. It only helps the rendering. Hooks may not work correctly. ITMT, I will try to take a close look at the difference between using v-else and not to see if we can test transition without any workaround ;)

Was able to get the one failing test to pass in @hiendv 's repro with this:
  it.only('should not render qux', (done) => {
    const wrapper = mount(Foo)
    wrapper.setData({
      show: false
    })

    setTimeout(() => {
      console.log(wrapper.html())
      expect(wrapper.find('.v-leave').exists()).toBeFalsy()
      expect(wrapper.text()).not.toMatch(/qux/)
      done()
    }, 1000)
  })

So it is definitely a timing issue... although as pointed out, no amount of await nextTick solves this. I guess we need to investigate into how <transition> is implemented in core to look for a wait to solve this for testing.

@lmiller1990 Agree. A dive deep into  implementation is also needed to solve the interesting issue with v-else.

@hiendv We are using v-if to trigger transitions, and we are also using functional re-usable transition components.

@tmorehouse It would be easier if you can set up a quick reproduction.

Deployed the latest docs with instructions on async tests and mocking transitions
Closing this issue


⚠ Empornium has degraded performance

In f627189, Empornium ($EMP) experienced degraded performance:

HTTP code: 500
Response time: 1077 ms

Resolved: Empornium performance has improved in 193e0ee after 8 minutes.


test_combine_kp_inst_time locally fails

In test_sw.py, test_combine_kp_inst_time fails when run locally (note this test is skipped on Travis CI due to requiring downloads).
======================================================================
ERROR: Test combine_kp when times are provided through the instruments
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jklenzing/anaconda3/lib/python3.6/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/Users/jklenzing/code/pysat/pysat/tests/test_sw.py", line 215, in test_combine_kp_inst_time
    fill_val = combo_in['standard_inst'].meta['Kp'][kp_inst.meta.fill_label]
  File "/Users/jklenzing/code/pysat/pysat/_meta.py", line 593, in __getitem__
    raise KeyError('Key not found in MetaData')
KeyError: 'Key not found in MetaData'

Line references above for pull #192.  In develop, this is Line 198.

Closing since root problem is documenting in #198.


Fix warning about deprecated babel #112

@Energizz could you please review this PR. It is removing the warning about @babel/polyfill being deprecated.
https://babeljs.io/docs/en/babel-polyfill
https://github.com/babel/babel-polyfills/blob/main/docs/migration.md

Outdated


Buddylist update is a little noisy

My FB Bot hasn't been up to any spammy activities. Ever since I added the presence to the set options, I recieve alot of console log about it showing all the people every couple of mins. Before It didnt do this it would only display when someone goes on of off. Never in a bulk. I am not sure whats happened. Since i updated it seems to do all this spammy console log stuff and It gets irritating. Is this due to your code or by a change by facebook.

I am going to wait for the temp ban to be lifted and stop the presence calling for now. But for some reason ever since updating. I received a lot of spammy console log messages from presence.

I think there are 2 separate issues here.  The "presence spam" is as a result of https://github.com/Schmavery/facebook-chat-api/pull/413.  It's possible that we could add an option to turn this off or change the log priority, but remember that you can adjust the global logging level whenever you want.
Being temporarily banned is definitely not fun and we'd like to do all we can to avoid that happening.  Unfortunately it's also very hard to diagnose.  Please let us know if there's some idea you have of things people should avoid doing to avoid triggering this.

I have a hard time thinking that the new presence notifications are the cause of this, because I'm pretty sure we were already receiving this information before and throwing it away, and there's no extra calls that we being made.  @GAMELASTER can confirm.
@bobland1 what other api functionalities were you using?

Aight thank you very much :) And, ill send you my code privately so you can see :) I have commented some stuff out so i dont get temp banned again.

Is why i got banned. I use this

But due to the spam at the start, i feel that is what caused the ban. Is there a way i am able to turn that off, so i dont receive the spam at the start?

Heya,
That spam is because at start and some intervals you getting all of your friends presences.
Actually, I have this integrated in one of my bots and it's working okay (the bot running a long time).
So it's all right

UPDATE:
Already checked my bot, I saw some HTML (error) maybe , but I still get presences and that bot account is not blocked.

Uh, this doesn't look okay.... Can anyone test getUserInfo?

I feel it is because I check who actually is online, by using the get user info to convert. And by the large amount of requests its getting. I am counted as spamming

@bobland1 if you're calling getUserInfo in a loop for every presence update, I'm not surprised you're getting rate-limited.  If you can confirm that that's what your code was doing, I think we can consider this issue figured out.
@GAMELASTER if you suspect there's a getUserInfo problem, please open an issue for it :)

@GAMELASTER do we get any information from buddylist that we didn't already get?  We might want an option for this.

If there is a way of being able to stop the spam at the start... or na. If not ill turn off that code initially

@Schmavery I saw only presences and one or two unknown property
@bobland1 you must disable whole presences listening

Are you able to add a feature like @Schmavery said about changing how it logs?

@bobland1 I doubt that the logging is the problem here.
@GAMELASTER I'm saying I feel like we might want to have an option to turn off buddylist, since people are already getting login/logout notifications.  This is a bit of a design decision and I'm not totally sure what the best solution is.

@Schmavery getting login/logout notifications? huh?

Oh okay :)

Also I looked into the feature I was curious about, I have sent my foundings.

#444

is it really noisy? or it was just error in @bobland1's code?

this condition will be always true

It is quite noisy as, it tends to spam every 2 mins. Me and my friend have both tried it to see if it's just me and it's not. It's due to the buddy list thing. As well as checking when people log out and in, it also will show the buddy list as well every 2 mins

@ravkr you're right that this is the real fix.  I was just wondering if maybe most people don't need the added buddylist events and perhaps would want the option of turning them off.

but what about this if?
there should be === instead of =
now it is just ignoring it

Have presence on and check how frequently it outputs. I mean I have it turned of at the moment as I don't wish to carry on what I was doing till it is toned down to where the spamming every 2 mins is well less frequent or something

@ravkr, the buddy list is part of presence so changing that shouldn't change anything... check the screenshots above. In the morning I'll change my code to what you have said I'll see if that fixes the issue if it does then 😂 Wow. Be sure to check back with you asap

I'm not saying that it will fix everything...
but code from your screenshot runs everytime there is any event... not only on presence updates

@bobland1: @ravkr is right that you have a typo in if (message.type = 'presence').  This is assignment not comparison, which would be == or ===.
That said, I wouldn't be surprised if presence updates are the most frequent update and that the code will still call getUserInfo too frequently.  Specifically, buddylist presence updates call the callback many times in a row without any delay, which would trigger rate limiting if you made a call to facebook every time.

I'll message you asap, also I have found a bypass to this by logging the messageID and checking it before sending messages but sometimes when a message takes longer to send due to bad connection. It receives two results and will hence result in two answers back. But this isn't really an issue any more as I have found a work around to it. But yeah thought I should let you know as well as others may be experiencing it.

I using this feature nonstop, all works okay. It's useful for me, because I can get older presences what doesn't arrived etc. It's true, it's sending all and the same presences (if user hasn't been active), so I just created the array where checking the last time, so I just skip it if it's an old presence which I registered. (resp. already it's handled by MySQL)

I have changed the if = to if ==, Thank you about that btw

Good idea!

I would have a nack at trying this new feature. But looking at the code within the listen about presence. I have no clue what to do. If anyone else is willing to do this, that would be great but in the mean time. I'm gonna have a look into it a bit more :)

@bobland1 I can maybe help you with this.  Basically you should add another case here to exit early if an option is set.
setOptions code lives here.  Just add another case for  this (not sure what to call it).
The options defaults live here.  Not sure what the default should be in this case.
Let us know if you have any other questions.

Awh thanks alot! I'll be sure to put this into the works 😊. Message you once I've done some testing. Thanks again

Maybe have presence and friendListPresence. As it updates the friend list Presence. Or buddyPresence

Started work on it, tell me what if I make any mistakes. I am prone to typos.


slideToLoop should loop

Clear and concise description of the problem
I wasn't sure if this is a bug or a feature depending on the expected behavior of slideToLoop.

Check out my codesandbox.io example..
Note that loop is true.
Click on the next button until you're on the last slide, Slide 4.
Now click on the next button again.
slideToLoop with index 0 is called and the swiper scrolls back to the first slide, passing all slides in between (Slide 2 and _Slide 3).

Suggested solution
Since loop is true and you're on the last slide, calling slideToLoop(0) should behave like calling slideNext().
If you're not on the last slide, maybe slideToLoop should scroll left or right depending on the shortest path.
However, since slides could load content asynchronously, maybe the shortest path isn't the best solution…
Note that in my example slidesPerView is 1.
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Would you like to open a PR for this feature?

[X] I'm willing to open a PR

This is how this method is designed to work

I see.
Since it's a feature request :wink:, I guess there are no plans to add that behavior? (It doesn't need to be the slideToLoop method)
I'm currently having two swipers that are connected. One swiper is for images and the other one is for the caption of the images. So if the user slides to another image slide, the caption slider should also automatically slide to the new index. If the user loops in the image swiper, the caption swiper should also loop the same way. Otherwise it looks… meh :smile:
I hope you get my case. That's also why I initially thought the slideToLoop method would loop. Maybe the documentation should be improved here? Maybe it was just me who misunderstood that :smile:
My current solution that kinda works in most cases but only if slidesPerView is 1 (maybe it's helpful to others or others have a better solution):
if ( Math.abs( imageSwiper.realIndex - captionSwiper.realIndex ) > 1 ) {
  if ( imageSwiper.realIndex === 0 && captionSwiper.realIndex === imageSwiper.slides.length - 1 ) {
    captionSwiper.slideNext();
  } else if ( captionSwiper.realIndex === 0 && imageSwiper.realIndex === imageSwiper.slides.length - 1 ) {
    captionSwiper.slidePrev();
  } else {
    captionSwiper.slideToLoop( imageSwiper.realIndex );
  }
} else if ( imageSwiper.realIndex < captionSwiper.realIndex ) {
  captionSwiper.slidePrev();
} else if ( imageSwiper.realIndex > captionSwiper.realIndex ) {
  captionSwiper.slideNext();
} else {
  captionSwiper.slideToLoop( imageSwiper.realIndex )
}

+1 on this


Support for google cloud storage blobs.

can we extend support for google cloud storage as well??
It would be very nice to have this api generalised for any cloud storage provider and provide a simple api for common use cases like fetch, get, e.t.c
It's really a great tool with some understanding use-case(PS: data-engg)
Tyvm for putting effort though.

Thank you very much for the quick impl.
It's working.


Fix grammar error for WebPA project

This commit fixes a grammar mistake in the WebPA project where we were
using provide rather than provides.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Open BLE options for Demo-Program

Set the BLE options to be open and pairable (especially when selecting program 5).
@Amerlander

Update: change BLE to "easy" mode

reflected in calliope branch and calliope-demo branch rebased on that.


Allow "Device Key" to be specified as a secret

Hi,
I added some tuja nodes to my flows, but I noticed that the tuya nodes store the "Device Key" within the flow.json file.
This has the negative side effect that I can no longer publish this file into a Git repository as I would store secrets into the repository.
Is it possible that the tuya nodes store the secret into the flows_cred.json file?
See https://nodered.org/docs/creating-nodes/credentials for details.

Hi,
I added some tuja nodes to my flows, but I noticed that the tuya nodes store the "Device Key" within the flow.json file.
This has the negative side effect that I can no longer publish this file into a Git repository as I would store secrets into the repository.
Is it possible that the tuya nodes store the secret into the flows_cred.json file?
See https://nodered.org/docs/creating-nodes/credentials for details.

Thanks for the feedback. Let me check the feasibility of this. I don't want to break the current working model as well.

Hi, this feature would still be helpful!

As previously said. I would still love to see this feature.  :-)

@foxylion
After checking the compatibility , i am planning to introduce a check box "Store as credentials" which will store the deviceId and deviceKey in the credentials file.
This will give flexibility as some users still want to store the id in the flows file so that they can easily import export.
Hope this will serve your request.
I had started the development of this.

@vinodsr that would be awesome! Really appreciate it :)

Released Version 5.0.0 Please check and let me  know .

@vinodsr I just checked it. Works perfectly, thank you!


Add role switching to the Saas Procurement App

Add role switching to the application.

This has been done.


Small adjustements to the publish bundle script

In particular, do not force push to the fork and make curl fail when it receives an HTTP response code that indicates a failure (eg 404)

/override ci/prow/push-images ci/prow/e2e-kind ci/prow/e2e-ocp-4-15-arm


Output source maps for CSS and JavaScript

http://blog.teamtreehouse.com/introduction-source-maps

Handled by dependency


Add browserstack logo to readme

Browserstack has generously offered to provide a free account to BoxArt for testing under their "Free for Open Source" plan! This adds their logo to our readme, and to the documentation site about page.
Closes #84

👍


DPI setting works only for png files

Remove it or implement for other image types, too
https://github.com/hnesk/browse-ocrd/blob/d482ac96195842db78321501f72ec7c780dd3d29/ocrd_browser/model/document.py#L230

IIUC the PNGs created by ocrd_browser are only for ad-hoc viewing. So how can we utilise or show the (original) image DPI?


Highlight social media icons in footer using hover effect

Issue Summary
I seen hovering effect on all the buttons and icons in footer like sponsor wagtail, contribute code buttons and sign up button. but I couldn't see the hovering effect while moving and clicking social media icons.

Steps to Reproduce
to fix bug: add hovering effect on social media icons while moving and clicking on the icons.
Technical details

Python version: Run python --version.
Django version: Look in your requirements.txt, or run pip show django | grep Version.
Wagtail version: Look at the bottom of the Settings menu in the Wagtail admin, or run pip show wagtail | grep Version:.
Browser version: You can use https://www.whatsmybrowser.org/ to find this out.

https://github.com/wagtail/wagtail/assets/94059890/a39d4a3c-10fb-42a1-8b2e-8a24550c3452

I have found this bug in Wagtail. I want to contribute to this bug . @SebCorbin Can you please review it and assign me the task. Thankyou.

@HarshithaPerumalla this issue is best discussed on the Wagtail.org repo, the one that manages the code for the actual website. I'll move it there.


kebab-case for the CSS property names not working

The documentation claims that

You can use either camelCase or kebab-case for the CSS property names

This is not the case. As of VueJS 2.0.5 only camelCase is properly handled, kebab-case silently fails (and nothing is rendered).

Since I assume you don'T want to change the documentation, but have Vue fixed, please post your bug report in the right repository (github.com/vuejs/vue) - with a reproduction.

@LinusBorg I actually forked the documentation to suggest a chnage but then though that it might be better to have this raised as a bug since the handling of both cases was, I believe, intended intended (as opposed to a documentation bug). I will open the bug where you suggested to.

@wsw70 have you seen that it works in my demo? Sure this is a bug?

@LinusBorg : yes, you are right - I realized that yesterday night when doing a JSFifddle to report the bug. I did not know about the hyphens (I come from the python world where the hyphen is compulsory in any case). I need to learn more about this (it is not the first case where I fall for that trap, also with the dot notation). Thank you.
I was about to suggest that it could be worthwhile to mention this in the docs but OTOH it looks like this is  is something obvious in JS. I found in the meantime a SO comment to an answer with the same problem and a comment mentions the "bug" I thought I found too.


Language code provider

Suggestion
I'd like to have a provider that gives me a random 2-letter ISO 639 language code based upon Java ISO language codes.
Will submit a PR for this... soon.


[feature] Allow nested notes

I use "notes to self" in a text chat app as my current slipbox, but it requires manual importing.
The advantage this has over logseq-slipbox is that I can "reply" to my notes to replicate the outliner structure in logseq.
We can replicate this by allowing markdown input. Each line that begins with "-" is a separate note (will become a new block), and indentation causes nesting.
It'll be some work to iterate over these and create the blocks with the correct parent/child relationships, but well worth it IMO.

I'll have to think about. You think it would be worth it, but if you're adding indented notes all the time, you probably want to be using the Logseq mobile app anyway to get proper formatting.
Proper indenting in the input form would be awkward (or does the UI now have a fancy text editor?), and processing it correctly in the plugin would be flaky (splitting on characters, removing indent spaces but retaining correct indentation, multiple simultaneous insertions are historically wonky).
FWIW personally, when I'm writing a big note, I'll write it like this:
this is the main topic

- here's a sidenote
- and another one

and this is related but in logseq it'll be a sibling block

When I import that note, I just use Logseq's robust tooling to break it up into the right blocks. It's 100% annoying to have to process them, but I LOVE that the slipbox interface is a text box and a button. No thinking about formatting, no being able to link blocks. If I want to write "[[page name]]" I can, but I may still have to fix that later lest that page name isn't right.

I'll have to think about. You think it would be worth it, but if you're adding indented notes all the time, you probably want to be using the Logseq mobile app anyway to get proper formatting.

It's pretty slow on mobile for a large graph, and getting syncing working reliably is a real challenge. Lots of folks have lots data trying, and I don't want to use the official sync feature because I prefer to self-manage my privacy. That's my motivation, anyway.

Proper indenting in the input form would be awkward (or does the UI now have a fancy text editor?), and processing it correctly in the plugin would be flaky

Not necessarily: we could use a markdown parsing library to handle it. We wouldn't have to support much: we could start with nested lists and nothing else.

When I import that note, I just use Logseq's robust tooling to break it up into the right blocks. It's 100% annoying to have to process them, but I LOVE that the slipbox interface is a text box and a button.

A challenge with this for me is that I don't necessarily have my entire nested note to put in the slipbox on the first try. I go for a walk, have a thought, have another thought - etc. There's currently no way for me to indicate that these thoughts are related to each other, and it's hard to do that at the import stage if its been awhile.

No thinking about formatting, no being able to link blocks. If I want to write "[[page name]]" I can, but I may still have to fix that later lest that page name isn't right.

I don't want to worry about formatting either - I'd just want a way to input notes with as little friction as possible. Maybe nested lists isn't a great approach to what I want.

How about optionally supporting note history in the slipbox interface? Below the input box, we could show the last N notes in order from last input to first input. If the user clicks on one of these notes, then the note input box will record that the currently input note is a child of that note. It would be relatively easy to make it a child block.


Added MIT License to distribution

LICENSE.txt - A copy of the MIT License applied to this project

Updates BlacksInTechnologyOrg/bit-slack-greeting-bot#10
Furthermore, this license was selected because it's a simple license that allows people to use the code as they wish without worry about reprisal from Blacks In Technology. It also doesn't make the users pick a particular license, like the GPL.
Here's another developer's take on why he chooses the MIT License in greater detail.

Fixes #10


Use pep8speaks to review python code

pep8speaks is a very good github integration to automatically review the python code style on PRs, so that the code base always remains pep8 compliant.

pep8speaks has been added now. Closing this. Thanks @nikhilkumarsingh !


Add passport document type to Picoleto

Closes #2

Pull Request Test Coverage Report for Build 10

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.2%) to 100.0%

Totals

Change from base Build 9:
2.2%

Covered Lines:
57

Relevant Lines:
57

💛  - Coveralls

Changes done @EsteveAguilera

Gerat job @alorma! Thank you! :clap:  :+1:


Make corpus contents dynamic (when based on search)

When a corpus is defined by a search and new data are added that are captured by the search, the corpus should automatically come to contain those data points (forms). Currently corpora do not do this.

Maybe make this a corpus-specific setting: "dynamic" or "static".


Idea for extension

What about an extension that allows to upload images from a file. Like a "load image from url" (ShovelUtils), but "load image from file"

You can already do this with the files extension

Thanks, I didn't guess


Flag --assert_compiler_success lets pa.sh get stuck

Without the flag, everything is fine. Sure the compilation fails but it executes the sequential version.
With the flag, pa.sh gets stuck and never returns:

The log-file indicates that an Exception was caught but I guess pa.sh shall still return at some point.

Which branch are you running on? On future this doesn't get stuck for me. Could you let me know of the branch, and also copy the logfile (log.txt) here?


Update automated updates workflow

Proposed Changes

Prefer PR generation action defaults and recommendations

@jamesrweb Do we really need to run it daily since it can make a lot of noise if it creates minor PRs often? Is it for testing?

@jamesrweb Do we really need to run it daily since it can make a lot of noise if it creates minor PRs often? Is it for testing?

Exactly, for testing until we get it "right".

@jamesrweb Do we really need to run it daily since it can make a lot of noise if it creates minor PRs often? Is it for testing?

Exactly, for testing until we get it "right".

This makes sense. I also added labels and team-reviewers. Do we need to have a custom title since the default one "Changes by create-pull-request action" is not relevant to us?

@jamesrweb Do we really need to run it daily since it can make a lot of noise if it creates minor PRs often? Is it for testing?

Exactly, for testing until we get it "right".

This makes sense. I also added labels and team-reviewers. Do we need to have a custom title since the default one "Changes by create-pull-request action" is not relevant to us?

Sure, feel free to add a custom one to the review then.
For the team reviewers the only issue might be that the default GITHUB_TOKEN might not have the right permissions but only one way to find out!

@jamesrweb Do we really need to run it daily since it can make a lot of noise if it creates minor PRs often? Is it for testing?

Exactly, for testing until we get it "right".

This makes sense. I also added labels and team-reviewers. Do we need to have a custom title since the default one "Changes by create-pull-request action" is not relevant to us?

Sure, feel free to add a custom one to the review then.
For the team reviewers the only issue might be that the default GITHUB_TOKEN might not have the right permissions but only one way to find out!

Yes, we can check the reviewers tomorrow morning after the script runs, otherwise we will set our account names explicitly


test Zhang-Shu and Löhner in 1D and 2D

I've created 1D and 2D elixirs based on the Sedov blast wave setup for the Euler equations. The 2D results look okay in Paraview.

Do you know why one kin still fails? I was hoping to get rid of the notoriously failing tests due to coverage testing...

Do you know why one kin still fails? I was hoping to get rid of the notoriously failing tests due to coverage testing...

No idea; "coverage decreased -0.0%" doesn't really sound convincing...


Python's interoperability tests should run against generated code

Currently they make direct use of the grpc.early_adopter.implementations module. Were they to be written against generated code we'd have a code path that tests secure connections through generated code.

This is a duplicate of #1038.


take fees Direct swap

Hi, nice dapp. btw, how add some take fee on router direct swap? let say total swap is 0.21 then add some take fee = 0.05 so total bnb will deducted = 0.26 bnb on wallet user

hey there, thanks for the interest but currently there are no plans to add fees to EcoSwap


Support for ajv --all-errors option

ajv allows you to collect all validation errors before returning a validation failure result by including the "--all-errors" option on the cli. Any chance this option could be incorporated into v8r?

Tbh I'd be inclined to just make this the non-configurable default. Its pretty much a pre-requisite for #148 to be useful.
In general, ajv has a lot of config options https://ajv.js.org/options.html
I don't really have the appetite to expose even a subset of that as CLI flags.

No response on this but I've gone ahead with it - allErrors is the con-configurable default as of  version 0.11.0: https://www.npmjs.com/package/v8r/v/0.11.0


Remove unused motion sensor driver

the FXOS driver is not used, so we can remove it and the auto-detection with the heap allocation can be removed as well.

@JohnVidler The autodetect functions can be found in this repo:

https://github.com/lancaster-university/codal-microbit-v2/blob/v0.2.38/source/MicroBitAccelerometer.cpp#L54
https://github.com/lancaster-university/codal-microbit-v2/blob/v0.2.38/source/MicroBitCompass.cpp#L56

And the drivers itself is in the codal-core repo:

https://github.com/lancaster-university/codal-core/blob/master/source/drivers/FXOS8700.cpp

@microbit-carlos Just checking that these are all OK to just outright remove, and that they have no dependencies?
Would it be prudent to include stubs with __attribute__ ((deprecated)) tagged on to indicate why this will not work going forwards?

So, I've had time to look at this now, and do we still need to have a fallback software Accelerometer class to handle cases where the LSM303 fails? if so, this boils down to simply removing this block of code ( https://github.com/lancaster-university/codal-microbit-v2/blob/v0.2.38/source/MicroBitAccelerometer.cpp#L77 ):
        // All known accelerometer/magnetometer peripherals have the same alignment
        if (FXOS8700::isDetected(i2c, 0x3E))
        {
            FXOS8700 *fxos = new FXOS8700(i2c, irq1, coordinateSpaceFXOS8700, 0x3E);
            MicroBitAccelerometer::detectedAccelerometer = fxos;
            MicroBitCompass::detectedCompass = fxos;
        }

With no further changes needed. Essentially we then just probe for an LM303, if one responds, use it, else fall back to the software one to prevent hard crashes and/or lockups in cases where it may have failed.
Thoughts?

Ok, so I've done more than the above, and greatly minimised the interface internals, removed the old driver, and added in some failure cases for if we can't configure the accelerometer and/or compass on startup.
Ultimately this will be squashed down further for v0.2.40 or future releases, but this is acceptably squashed for now.


SECURITY: add a security disclosure policy

Heads-up @Theelx  ~ Tidelift notified us asking that we add a security policy. They recommend letting them handle notification and disclosure so I've linked to their process here.


Update Receiver monitor class identity and gain setPoint

Changes dictated by MS-05-02 update:

Update ReceiverMonitor class identity to 1.2.3 due to new worker
rename setPoint to gainValue

Reviewed on the call on the 24th of January 2023


Which model class(es) are being saved in the different model checkpoints?

Hi.
I am trying to load the en-indic model into PyTorch.
After unzipping the folder, I am doing
checkpoint = torch.load("/content/en-indic/en-indic/model/checkpoint_best.pt")

Now, to load the model and optimizer for later use, I am following this.
To follow along with this tutorial, what is the TheModelClass and TheOptimizerClass?

We do not use custom model classes or custom optimizers for training with fairseq, so you could try using the fairseq's transformer model or optimizer classes directly.
Our translation model just uses a different config (embedding dimension, attention heads etc).
For loading the model with the python interface for inference (note this cannot be used for training as python wrapper class is written for inference only), you can follow the tutorial here.


Interpreter replays actions when multiple batches of events are being sent

Description
When calling an interpreter with batches of events more than once, interpreter accumulates all the actions and executes them every time, replaying the previous actions. On every transition, all the actions from previous batches get executed as well.
My use case:

developing a simple platformer game
there's a game loop running on requestAnimationFrame
in every step of the loop we create events based on user input and execute them in a batch using an interpreter

My workaround was accumulating events in every step of game loop in an array, and then calling interpreter.send event by event, looping over that array. I'd prefer to be able to use batching there.
Reading the docs, I didn't get an impression that this was by design. If that is true, I can open a PR with a change to interpreter so that it clears historic actions between running batches.
Expected Result
Calling an interpreter with an array of events more than once should have the same effect as if sending those events one by one.
Actual Result
Every time interpreter.send is called with an array of events, all the previously executed actions are executed again, with the latest actions being called last. Transition listener shows all the historic actions in state.actions, where I would expect only the actions from the current batch to be there.
Reproduction

CodeSandbox

Additional context
xstate version: 4.6.7

This no longer occurs in 4.7.3

Thank you!


use prepared request to format payload before converting

Use requests.PreparedRequest object to convert requests.Request into a formatted payload before converting into an OpenAPI request.
Fixes bug where one of the many requests.Request convenience methods (ex json) are used and payload is not stored in Request.data. Should also handle scenarios where persistent sessions have expected headers not applied to the request object until it is prepared and sent

I ran into this same problem with 'json'. I have to prepare the request either way to send it, so it makes sense for the OpenAPI Request object to be created from that.

I ran into this same problem with 'json'. I have to prepare the request either way to send it, so it makes sense for the OpenAPI Request object to be created from that.

I ran into problems trying to support requests with multipart/form-data. Nothing else worked, so I tried using this version. It does not solve the problem:

openapi_core.schema.media_types.exceptions.InvalidContentType: Content for following mimetype not found: multipart/form-data; boundary=6c20c84fd95c1d9ac73bcc7ed47fa1c0

I ran into problems trying to support requests with multipart/form-data. Nothing else worked, so I tried using this version. It does not solve the problem:

openapi_core.schema.media_types.exceptions.InvalidContentType: Content for following mimetype not found: multipart/form-data; boundary=6c20c84fd95c1d9ac73bcc7ed47fa1c0

I was using this code successfully, but it stopped working after updated openapi-core 0.13.6 to 0.13.7 with urlencoded bodies. It seems the urlencoded string gets validated rather than the decoded dictionary of values. I suspect it never worked but didn't signal an error because of abfd0c67.

@eyadgaran thank you for the contribution.


Reverse proxy seems down

The reverse proxy servers worked great, but as of just now both of the two reverse proxy servers are down now, which seems inevitable given how many requests they would handle.
This happened when using cli, 2 hours ago it was working fine.
TypeError: fetch failed
    at Object.fetch (node:internal/deps/undici/undici:14152:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async create (file:///root/node-chatgpt-api/node_modules/@waylaidwanderer/fetch-event-source/lib/esm/fetch.js:52:34) {
  cause: Error: connect EHOSTUNREACH 2a09:8280:1::3:e03e:443
      at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1494:16) {
    errno: -113,
    code: 'EHOSTUNREACH',
    syscall: 'connect',
    address: '2a09:8280:1::3:e03e',
    port: 443
  }

We've taken down our reverse proxy servers because it seems like OpenAI patched the method we were using. We're going to investigate if there's any way to get it working again, but for now it doesn't look good :(

Unfortunately, the method we used to access the ChatGPT raw models has been patched. Your options right now are to either use the official OpenAI API with the text-davinci-003 model (which costs money) or use a browser-based solution to interface with ChatGPT's backend (which is less powerful, more rate-limited, and is not supported by this library at this time).


Response card fields are not presented in a logical order

Expected Behavior
Response card fields should be presented in a logical order -

Title
Subtitle (optional)
URL

Actual Behavior
Subtitle comes first, title comes last.. confusing

Steps to Reproduce the Problem

Specifications

Version:
Platform:

duplicate of #116


Runtime Overlap Baking Issue

Hi To Whom It May Concern,
I've been attempting to figure out how to update a specific instantiated prefab location that becomes available in the world with a previous baked terrain area..
Basically, the nav mesh agents cannot do it's pathfinding on multiple layers of a baked area.
I could rebuild the terrain nav mesh; however, in a game designed for building instantiated prefabs I don't want to have each player spend a minute watching a load screen every time they implement a floor on the ground.
My theory of a workaround:
Break the terrain into 100's of pieces, and check distance where a new instantiated prefab is located and remove navmesh instance's, & rebuild at those specific locations.
Ideally: I'm not sure of a way to remove the located area and to stitch to the previous terrain nav mesh to combine them together.
I appreciate any help anyone can provide!
My Unity Version:
2019.2.1f1
I'm using the 2019.1 package version
Script changes
I made it so LocalNavMeshBuilder doesn't build constantly in the while statement, but only in Awake function when game launches (To only do it once).
I also update NavMeshSourceTag in the Collect function where s.area = int value; instead of, 0. To make sure I can use multiple layers of nav mesh areas.
1 LocalNavMeshBuilder is for terrain area, and 2nd LocalNavMeshBuilder is for the instantiated prefab.

Ok,
I think I found the solution to combine them together, and it was already there for async but I just didn't know what it meant at that moment.
What I did was create a function that doesn't create a new navmeshdata in the localnavmesh builder script.
public void Runner()
{
    //Instead of letting it recreate the navmeshdata
    if (m_NavMesh == null)
    {
        m_NavMesh = new NavMeshData();
    }

    m_Instance = NavMesh.AddNavMeshData(m_NavMesh);
    if (m_Tracked == null)
        m_Tracked = transform;

    //Re-apply
    UpdateNavMesh(false);
}

Once I pushed this after the prefab is instantiated it updated it's own navmesh to the terrain. I haven't quite put this in a world with 30k objects in it as of yet, but this was a small test and I'll be happy if it only takes a few seconds to add this new piece in.

From:

To (Notice it updated the navmesh under the instantiated prefabs and this allowed the cube AI to complete it's destination:

If there is a potential problem with what I did. Please let me know!


IPR034586 mitotic spindle orientation checkpoint

This checkpoint is not present in fission yeast. It is required in budding yeast because the spindle has to be orientated to get though the bud neck. I'm not sure if it is present in any medially dividing cells?

wrong tracker

never in Schizosaccharomyces for starters.
An "only in" might be better, but I'm not sure  which organisms have this particular checkpoint.
https://github.com/geneontology/go-annotation/issues/1569

Hi Val,
For reference here are a couple review that confirm that these checkpoints are not known outside cerevisiae
http://www.sciencedirect.com/science/article/pii/S001448271200167X
https://celldiv.biomedcentral.com/articles/10.1186/1747-1028-5-28
I added 'only in taxon' some saccharomyceta for now. All EXP are to cerevisiae genes; we'll see if anything breaks ;)
Thanks, Pascale


Fix sidebar and 404

ref #1225
We need to keep sidebar clean and neat.
What's missing here is more tutorials, I will expect they will come from oam-dev/samples repo.

I will refactor the kubevela site in multiple versions #1155 , like https://crossplane.io. So I need to keep the directory structure simple, easy to maintain and automate, so I need only two levels of directories like https://docs.fluxcd.io/projects/helm-operator/en/stable/ or https://crossplane.io/docs/v1.1/concepts/ so that there are only two levels of sidebars.

@sunny0826 OK, I will update the PR, thank you for heads up!

PR updated sidebar to 2 layer.


Display room capacity and how much empty seats left

Follow this figma UI

Now the status bar is using the same color rather than a different color for each state.

Both have been fixed @petertheprocess

Fix the size of avatar box c4026c9df7cdc9c39a713c3a203c0e043000ff66
before

after


Add instructions for Rosetta support on Apple Silicon

Avoids the following error when a program running in Rosetta invokes sudo:
sudo: unable to initialize PAM: No such file or directory

Hi Michael,
Thank you for your contribution!
I can't test this change myself given that I don't have access to an Apple Silicon device, but I assume it works for you on Apple Silicon.


Convert matching expressions to use Arel

This converts the matching expressions (LIKE, NOT LIKE, etc..) to use Arel.  Couple of things to note:

Introducing a bit more duplication here, but I plan to deal with this later
Arel gives us ILIKE out of the box

While the ILIKE support is great, I'm not sure this is the right time to bring this out (especially as the #to_ruby stuff doesn't support case insensitive matching, and should be done together). @kbrock do you know if there's a way to fall back on using LIKE for now so there's no behavioral change in this PR?
/cc @gtanzillo @yrudman
@miq-bot add-label refactoring, core

@imtayadeway There is a lot of duplicate code between virtual_columns, sorting, miq_expression and others.
Moving this logic into Field sounds like a great start but with the goal of throwing away Field in (6mos?) since arel will handle what we want.
Looking forward to seeing this transform.

hmm - have you run this?
should matches use % or .*?

@gtanzillo please review

@imtayadeway sorry, just saw your comment to me now: for case sensitivity, you can change https://github.com/rails/arel/blob/master/lib/arel/predications.rb#L121

@miq-bot rm-label wip


CommonJS-fix: Store registration template payload as JS object on contextVars

Purpose
Fixes issue where data was not unserializing in the template for OSF Standard Pre-Data Collection Registration.
Changes
Make `window.contextVars.regPayload` a JSON object instead of leaving it as a string so that `MetaData.ViewModel.unserialize` does not throw an error.

Just fixed it @sloria :snowman:


URL of FAB Free Content changes every time a new set of items is available

The URL of FAB Free Content changes every time a new set of items is available. The new link is https://www.fab.com/blade/0691ff19-b259-44e0-ad3b-093a53010f46?context=homepage

Originally posted by @goodmario1 in 1a6756e

Yeah, I'm familiar with this problem. I'm busy for the next month. If I have time, I'll try to fix it.

Everything works correctly


Error on project-config/apply with 1.0.0-beta.18

I have installed the 1.0.0-beta.18 and now the command project-config/apply returns this error:
Your project config files were created for different versions of Craft and/or plugins than what’s currently installed.

Sprig is installed with schema version of 1.0.0-beta.18 while 1.0.0 was expected.

Try running `composer install` from your terminal to resolve.

I have already tried to rebuild the config file but the problem is still there.
Versions

Plugin version: 1.0.0-beta.18
Craft version:  <IP_ADDRESS>

Did you update from a previous beta version of Sprig?

Yes, from 1.0.0-beta.17

Can you test with the fix in https://github.com/putyourlightson/craft-sprig/commit/7f1bbcc023df0f6b18f6cdef3533300c6e1b86d6?
composer require putyourlightson/craft-sprig:dev-develop

Ok, now it works 👍

Great, released in 1.0.0-beta.18.1.


Bug: Offer credentials array required to be array of objects

This check here https://github.com/digitalbazaar/oid4-client/blob/main/lib/OID4Client.js#L221 seems to only allow array of objects, but it could also be a string of IDs.
Spec is still changing, but existing impls already exist where it uses array of strings not objects

+1 that we need to address this somehow. Since it wasn't (and still isn't) clear if/how this might change, we implemented the mechanism that was in greatest demand at the time. The spec has since changed here by renaming credentials to credential_configuration_ids and requiring them to be strings that are expressed in the credential issuer metadata (see: https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#section-4.1.1).
If loosening this to allow strings can be done easily (without some problematic side effects) we could do that in the short term and then adjust to the new spec, depending on its apparent level of stability on this particular point.

In v3.6 we take a lax approach to maximize interop by supporting both credentials (with objects or string IDs) and credential_configuration_ids. Once this appears to be stable in the spec we may do a major version release that only allows what is stable.


"Export not found" errors?

👋 Hey there! I was wondering if you could say anything about the circumstances under which you'd expect an "Export not found" error to be thrown when using this package in conjunction with react-universal-component.
All I can tell after about a day of troubleshooting is that the module it's being passed seems to be empty---it's just an object that looks like { __esModule: true }---even though the module I'm importing exports a React component and the file in which it's output appears in the correct order in the DOM. (I.e., the bootstrap chunk shows up first, then this module's chunk, then the main chunk.) I also know that visiting the page works fine if I load another page first and then navigate to it using React Router and the HTM5 history API, but fails when I try to load the page directly from an isomorphic rendering.
I'm sorry to ask such a vague question, but I'm at my wits' end---the whole shebang was working beautifully till just this morning, and I'm not sure what-all I did to break it. There might be a git bisect in my future.

can you paste me some culprit code real quick. and if i cant see the problem, we'll move to a quick throwaway repo. I probably can though.

also feel free to post early. These things are getting a great response, but it's still new that I don't have that many issues to deal with. I rather be able to resolve things quickly and be able to keep everyone happy :)

😃 Thanks, I appreciate that! It turned out (thanks, git bisect!) to be an issue with Webpack's CommonsChunkPlugin. Changing an async/all-children commons chunk's minChunks from 6 to 3 somehow caused it to choke:
diff --git a/config/lib/build-webpack-config.js b/config/lib/build-webpack-config.js
index c629eab..84bfe15 100644
--- a/config/lib/build-webpack-config.js
+++ b/config/lib/build-webpack-config.js
@@ -100,7 +100,7 @@ export default function buildWebpackConfig(args) {
             new webpack.optimize.CommonsChunkPlugin({
                 async: true,
                 children: true,
-                minChunks: 6,
+                minChunks: 3,
             }),
         ]
     }

Disabling the async option seems to have solved the problem, even with the smaller minChunks:
diff --git a/config/lib/build-webpack-config.js b/config/lib/build-webpack-config.js
index f2e9134..f41b344 100644
--- a/config/lib/build-webpack-config.js
+++ b/config/lib/build-webpack-config.js
@@ -99,7 +99,6 @@ export default function buildWebpackConfig(args) {
         browserPlugins = [
             ...browserPlugins,
             new webpack.optimize.CommonsChunkPlugin({
-                async: true,
                 children: true,
                 minChunks: 3,
             }),

I suspect the underlying issue may have been with the Extract Text plugin, as I've seen it choke on commons chunks before, but it's hard to know for sure and I can't find the GitHub issues about its async woes. Happy to send you an invitation to the repo if you'd like to poke around in it and investigate further.

i've never used it and i struggle to figure out its use-case, but the async option seems to create another chunk that u simply didnt have embedded on the page.
If that's the case and if ur using webpack-flush-chunks and know it's name (which can in fact control by doing async: 'async-common-chunk', u can just add it to the end of the before array--if u still want to use the async option.
I've never used this option, but I assume the idea is that your dynamic async chunks may have common code that your named entry bundles don't have, and you want to provide this additional common chunk only under the circumstances that ur loading a dynamic chunk. lol
it's all good on the repo. but let me know if u try a named async chunk, let me know so i'm aware for future users.

check the latest docs if u havent already:
https://webpack.js.org/plugins/commons-chunk-plugin/

...also it seems the reason it did not work before with minChunks: 3, where it worked with minChunks: 6 is that ur module wasn't moved to the async chunk (which was never included). so once u brought the config down to a minimum of 3 chunks (u must have had at least 3 dynamic chunks importing it), the plugin moved it to a an async-commons chunk.

That all makes sense. Giving the commons chunk a name and forcibly flushing it is clever, but I suspect it defeats the purpose of making it async. My lay understanding, based on the docs and a little experimentation, is that an async chunk is meant to cut down on the page's initial loading and parsing time by being pulled in after Webpack boots and while other dependencies are loading. Not super clear on it myself---which means who gives a heck, no harm no foul. 😉
Thanks again for giving this some thought! Glad to have it all working again.


Email with Latex Equation in org-msg (mu4e) does not convert and send

What did you expect to happen?
Using mu4e with org-msg, I include a LaTeX equation in the email body and expect it to be included as a png image.
What actually happened?
When attempting to send the message (C-c C-c), the message is not sent if it includes a LaTeX eqyuation (tex:dvipng)
Error (message-send-hook): Error running hook "org-msg-prepare-to-send" because: (void-variable source)
Describe your attempts to resolve the issue
Email does get sent with

images attached, or created using babel source blocks (e.g. Python or Julia blocks)
other rich text formatting using org-mode (headers, tables, lists, etc.)

only LaTeX equations trigger the error above.
Using tex:dvisvgm works, and attaches the LaTeX equation, but email clients don't handle svg files well.
Steps to reproduce

Open Emacs
Start Mu4E
"C" to compose message, enter recipient
In message body, enter equation: $\sin(\alpha)$
"C-c C-c"
error message:
Error (message-send-hook): Error running hook "org-msg-prepare-to-send" because: (void-variable source)

System Information
https://pastebin.com/tPcqXb2Y

I experienced the same issue.
It seems like the problem comes from the function +org-html-latex-fragment-scaled-a in the file advice.el.
There's a mention of the variable source in the definition of attributes (here, but those variables are defined in the same let statement.
A possible fix is :
         (let ((source (org-export-file-uri (match-string 1 formula-link))))
              (let ((attributes (append (list :alt latex-frag
                                            :class
                                            (concat "latex-fragment-"
                                                    (if (equal "\\(" (substring latex-frag 0 2))
                                                        "inline" "block")))
                                      (when (memq processing-type '(dvipng convert))
                                        (+org-msg-img-scale-css source)))))
              (org-html--format-image source attributes info))))))

There's another error because of a typo I guess : in the same file, in function +org-msg-img-scale-css, the variable there's a d missing in the declaration of variable width-call here
Once those two things corrected, I managed to send latex code without error hitting C-c C-c
Hope it helps, maybe @tecosaur can quickly fix that ?
I'm not familiar with the Github way of solving issues. Sorry for the inconvenience if it's not how it should be done. (Should I really fork the entire repo and make a pull request just to propose those two small fixes !?)
Cheers,

Thanks for the ping. I can create a PR just fixing those two small things. If you might happen to have a patch file you could chare on hand that would be handy though @Samickey.

Sure ! Here is a zip file advice.el-fix.zip with fixed advice.el and the git diff if it's useful. Hope that's what you expected.
I'm not a lisp developer, so I don't know if there's a cleaner way to fix the code for the definition of  attributes.
Also, thanks for all the work you do !

Thanks, I've just made a PR to fix this.

This issue should now be resolved. Let me know if that isn't the case and I'll reopen it. Thanks for bringing it to my attention!


Attachments not scrollable when overflowing the container

We have a couple of pages that have a long list of attachments and when you view the attachments list in edit mode it prevents the whole page from scrolling. This effects Chromium, FireFox and Opera on a Windows PC, however works intermittently on Safari on both Mac and iPadOS
You can fix this by manually editing the raw HTML within the browsers “inspector” mode and adding the following style to the DIV which is component=“sortable list”
style="overflow-y:scroll;height:100vh"
A simple fix for this would seem to be to add this CSS to the customer header option within the GUI however we cannot seem to find a way to select that component in CSS.
Has anyone else encountered this and know of a suitable permanent fix please?

this can be edited at /var/www/bookstack/resources/views/attachments/manager-list.blade.php open a text editor for it (nano or vi) then add style="overflow-y:scroll;height:850vh;" to the component="sortable-list"
the div will look like this:

Cheers @JamesTimmins-ops
Could this be pushed out to live repo please guys?

Note: You can use the visual theme system to implement the @JamesTimmins-ops solution without editing core files.
Alternatively, Something like below should work in custom HTML head:
<style>
.floating-toolbox .files div[component="sortable-list"] {
   overflow-y:scroll
   height:100vh;
}
</style>

Otherwise, Have assigned to the next feature release.
Note: The implementation solution will ideally need to be flexible instead of using fixed #vh units.

Hi @thescottyq,
Just coming to look at this one, but I have not been able to find an issue. Have tested on Firefox and Chrome on Fedora, In addition to Safari on iPad. In each, the I'm able to scroll the attachments sidebar while still being able to scroll page content as expected.
In regards to your comment:

when you view the attachments list in edit mode it prevents the whole page from scrolling

What do you mean by page? As in the page content within the editor? If so, which editor are you using? This view has a full-height flexible layout where the webpage itself does not usually scroll.

Hi Dan, thanks for looking at this further. To confirm your suggestion of adding the following to our customer header resolved the issue.

The issue only seems to be on Windows Machines and is specifically when you are editing a page. If you have a long list of attachments the list just does not scroll

Tested this again across Firefox and Chrome/Edge across Fedora Linux and Windows 10, cannot reproduce, so will therefore close this off as I can only assume something else is at play.
Happy to address if a specific issue can be found but I'd need to be able to reproduce the scenario as to not be blindly applying fixes.

I have the same problem.

Tested on Edge 107.0.1418.62 and Chrome 108.0.5359.72
Bookstack v22.11

Steps taken:
Open the Book from the Shelve and then navigate to the page holding the attachments. There Click on edit. Then Click on any item to open de side bar where you can enter tags, add attachments etc.

Reopening. @PvandenBerg77 Can you confirm your operating system type/version used for these tests?

Can now confirm reproduction on Firefox on Ubuntu and Chrome on Windows 10. Quite strange, maybe something was rolling out, had further recent confirmations in  #3913. Have assigned to be addressed as part of next patch release.

Alrighty, found I had broken overflow due to changes in v22.11.
Patched in a521f418382aaec18ed6fce997a2b204a9a7eb56, will be part of the next patch release.

@ssddanbrown Thank you for the quick fix!


libmodplug: Fix build on darwin

Motivation for this change
The libmodplug builds on darwin are broken for quite some time. See #105573
Removing the -mmacosx-min-version clang flag makes it work again.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

libmodplug now builds on darwin.

and also on linux.


historical retrieve performance enhancement

removed the semaphore to allow parallel requests

Looks good.

@dshe Thanks for it, i will check it later 😄


Missing addForFacetValue in the SearchClient makes im not compatible for typescript users

Description
see #48
Thanks a lot to @haoyun for raising this
When using typescript a searchClient has to response to the search client interface
export type SearchClient = {
  search: DefaultSearchClient['search'];
  searchForFacetValues: DefaultSearchClient['searchForFacetValues'];
  addAlgoliaAgent?: DefaultSearchClient['addAlgoliaAgent'];
  initIndex?: (
    indexName: string
  ) => SearchIndex extends { findAnswers: any }
    ? Partial<Pick<SearchIndex, 'findAnswers'>>
    : SearchIndex;
};

Accessible here: https://github.com/algolia/instantsearch.js/blob/16cc34155d8af25893db3e521b4a1da26ce591e4/src/types/algoliasearch.ts#L33-L42
Until recently it was an optional method.
Expected behavior
The method should be present to make instantMeiliSearch usable with typescript
Current behavior
As the method is missing it does not work on typescript projects
Environment (please complete the following information):

instantsearch.js version: [e.g. v4.23.0]

I am using "instantsearch.js": "4.25.1-experimental-typescript.0", . Currently I forcibly cast instantMeiliSearch as SearchClient
const searchClient = instantMeiliSearch(hostUrl, apiKey, options) as any as SearchClient

Typescript support in instantsearch.js is still an experimental feature. But their recent releases are all about the TS support.

That is very good to know @haoyun, thanks for checking this out so quickly :) Let me make a fix


Required OAuth credentials not provided. Make sure your API invocation call has a header: "Authorization: Bearer ACCESS_TOKEN"

Out of the box installed the API, and have it running on port 8080 following the instructions, and entered the APIKEY, APISECRET, username and password.
First error in the console after I click login is:
 api.toonapi.com/toon/api/v1/temperature/states:1 GET      https://api.toonapi.com/toon/api/v1/temperature/states 500 (Internal Server Error)

And I get the responseText:  "{"code":500,"type":"Internal server error.","message":"Unable to find virtual display. Try to register the display first.","description":"Unable to find virtual display. Try to register the display first."}"
And then continually: GET https://api.toonapi.com/toon/api/v1/status 500 (Internal Server Error) will show in console, it will try over and over.
And when I go to: https://api.toonapi.com/toon/api/v1/status, this error is shown: Required OAuth credentials not provided. Make sure your API invocation call has a header: "Authorization: Bearer ACCESS_TOKEN" or:
 <ams:fault xmlns:ams="http://wso2.org/apimanager/security">
  <script id="tinyhippos-injected"/>
   <ams:code>900902</ams:code>
   <ams:message>Missing Credentials</ams:message>
   <ams:description>
   Required OAuth credentials not provided. Make sure your API invocation call has a header:        "Authorization: Bearer ACCESS_TOKEN"
   </ams:description>
   </ams:fault>

While on the other side, in my nodejs console it says: Received a request for a new token! and get a refresh_token and access_token back...
So, I don't understand why this is not working, while the client side errors clearly state I don't have the right credentials, the server side does. Unless I have to login seperately on the client side, but this is not possible, since the login button goes on right away and doesn't ask for credentials.
I'm pretty sure this is an issue on the server side, not being able to verify my APIKEY or some other server problem. I've also requested and tested a second APIKEY, but same problem.

Hi, thanks for describing the issues you ran into, the problem can be found with the agreements. It is possible for a user to have more than one display and you have to select one before getting data. In the example-application i (wrongly) assumed this to working out of the box.
I will add a selection-screen for the agreements, with the exception of just one agreement, it will automatically select that and continue on.

@trakkiesDev I have created the branch issue/2/selectAgreement with a possible fix, can you check if this works for you?

@trakkiesDev We have updated the master-branch with this update, can you check if this works for you?

Thanks, that fixed it!

Closing after fix and confirmation.


Continue if the current file already exists

I wonder if it doesn't make sense to continue with the remaining files if one of them has already been fully processed.
This way the script can continue to run and you don't have to manually check which file is not finished yet?

No I think that helps with the script. Thanks for you contribution.


Fonts other than material don't work for Icons.

Hi, thanks for your hard work on this library! it's a great lib.
Ran into an issue with fonts and icons.
I downloaded your example app, and was able to get your icons working using by copying your material.tff file and putting into my project.
example:
<IconWidget size={20} font="material" icon="snowing" />

Works great.

I downloaded MaterialCommunityIcons.ttf, (from here: https://github.com/oblador/react-native-vector-icons/blob/master/Fonts/MaterialCommunityIcons.ttf) and put it in the same directory that the material.ttf is in, and it doesn't work.
        <IconWidget
          size={20}
          font="MaterialCommunityIcons"
          icon="weather-snowy"
        />

just returns

I've tried other fonts too, I can't seem to get any to work beside your material.tff file.

Are you using expo or bare react native?
If not using expo, you need to rebuild the app so that the ttf file will be in the apk.
If using expo, you need to use the config plugin to copy the font file.
BTW, in the example app there are material, material_outlined, and Ndot-55 fonts.

Hi
Sorry for the super late reply!
I'm using expo, using expo prebuild to compile the .ttf files into the android folder. The compiling works fine, everything seems good.
The config plugin:

the Icon code:

the widget:

material works just fine though.
material example:

I tried it now, and yes, I could not use the MaterialCommunityIcons font.
I tried rebuilding the app, renaming the existing material font to something else to make sure it is compiling correctly.
I still don't know why the font is not loaded properly, but will investigate more...

Hi,
I tried again, and looks like that the MaterialCommunityIcons font cannot be used the same way as the material font.
The font does not map from the text to the icon.
I looked at how react-native-vector-icons works, and I saw that they are using a code for the icon. See https://github.com/oblador/react-native-vector-icons/blob/master/glyphmaps/MaterialCommunityIcons.json#L6451
This works:
<IconWidget
  style={{ color: isActive ? '#5CC6E2' : '#254B58' }}
  font="MaterialCommunityIcons"
  size={32}
  icon="󰖘"
/>

You can find other code points for the same font from there.
I'll close this since it is not an issue with the library, just the font needs to be used in a different way.

Thank you!!


Combine Number AND Enum

Package version
1.8.0
Describe the bug
Hello :grin:  !
Sorry, Github won't let me use the Feature Request issue type, forced to submit it as Bug Report :-/
TLDR
[✨ New feature] : Requesting Number (to autoconvert HTML form string to number) and Enum (to ensure the number is from a predefined list) types combination, like this :
vine.number().enum([1, 3, 4, 8])

A bit of the request context
If I want to let my user choice between some objects (already in database, to use as relation) I could use an HTML select, and (dynamicly, using a template) pass every object id as value  :
<select name="objectId" id="objectId">
    <option value="1">A Choice</option>
    <option value="3">B Choice</option>
    <option value="4">C Choice</option>
    <option value="8">D Choice</option>
</select>

Because in HTML forms, the values are always strings. My form will send "1", "2" or "3" (or whatever if the user alter the form).
If I want to save in DB a correct objectId for the relation, I need to convert the objectId from string to Number, and then check if there is actually an object with this id in my database.
Using  number().range instead of enum isn't possible because some object's id are unavailables.
It give me (using AdonisJS) a controller store method like that :
async store({ request }: HttpContext) {
    const data = request.all()

    //converting string to number
    if (data.objectId) {
      data.objectId = parseInt(data.objectId)
    }

    //getting all corrects objects id from DB
    const availableObjectIds = (await Object.all())
      .map((obj) => obj.serialize().id)
    //should be equal to [1, 3, 4, 8]
    data.availableObjectIds = availableObjectIds

    const payload = await Validator.validate(data)

    return Objet.create(payload)
}

With a Validator like that :
export const Validator = vine.compile(
  vine.object({
    objectId: vine.enum((field) => {
      //taking our ids picked from DB
      //should be equal to [1, 3, 4, 8]
      return field.parent.availableObjectIds
    }),
  })
)

With number and enum combined
I could drop theses lines from the controller :
//converting string to number
if (data.objectId) {
    data.objectId = parseInt(data.objectId)
}

async store({ request }: HttpContext) {
    const data = request.all()

    //getting all corrects objects id from DB
    const availableObjectIds = (await Object.all())
      .map((obj) => obj.serialize().id)
    //should be equal to [1, 3, 4, 8]
    data.availableObjectIds = availableObjectIds

    const payload = await Validator.validate(data)

    return Objet.create(payload)
}

And my validator will simply look like that :
export const Validator = vine.compile(
 vine.object({
   //converting string to number
   objectId: vine.number().enum((field) => {
     //taking our ids picked from DB
     //should be equal to [1, 3, 4, 8]
     return field.parent.availableObjectIds
   }),
 })
)

I'm asking this feature because I think it's better to keep data type validation inside models definitions
Thanks for all your work on the Adonis environnement !
Reproduction repo
No response

How about using the number schema with the in validation rule. Something like this
vine.number().in([1, 3, 4, 8])

It could do the job very well :grin: !


New command: add text to modern page

Add text to modern page

command: spo page text add -n|--pageName <pageName> -u|--webUrl <webUrl> -t|--text <text> --section [section] --column [column] --order [order]
pageName: name of the page to add the section to
webURL: URL of the site where the page to edit is located
text: text to add to the page
section: number of section to which the text should be added (1 or higher)
column: number of column in which the text should be added (1 or higher)
order: order of the section

For more information see the Add-PnPClientSideText cmdlet.

@waldekmastykarz  I can take this one if you're happy with #366

Please do! 👏

Ok, I will pretty soon.
Quick question, since most of the code would be copy of the clientsidewebpart add command, do you prefer to refactor, or to copy/paste the code ?
if refactoring, should I go for an base class or a helper class to consume ?

Let's go with a helper. That gives us more flexibility in case we need to refactor in the future

Hi @waldekmastykarz , just to keep you up to date, I am a bit delayed on that, but I started refactoring and had to refactor the specs as well. But still on going, don't worry :)
By the way, what do you think of closing the #366 PR and process the upcoming one with the WebPart and the Text commands ?

Thanks for the update @ypcode. I'm processing open PRs typically once a week. I try not to add new commands just before a release to avoid last-minute issues, which is why I haven't processed your PR yet. Still, it's on my to-do list for the coming weekend, and if all is well, will be included in the next beta.

Don't worry, that is totally fine, no rush here :)
I was just thinking, since all the common code will be moved in a helper class. I think that might be not worthy to spend time on that one, since there will big "changes" in this one here...

You can include the same file in the next PR and when I'll merge them, it will become one and the same.

Hi,
Just a quick update on this, I implemented the new command, but I found a quite significant bug when playing with sections (the layout of the page is being screwed up) at this is probably also present in the clientsidewebpart command.
I found out there was some issues in the code copied from pnp js at the time.
All are now fixed so I recopied the latest implementation.
However, some tests are now failing in other commands, I have to figure out all these before submitting the PR :)
Hopefully this will be done this week
Regards,
Yannick

Thanks for the update @ypcode! Have you checked if the bug is fixed in PnPjs from which we borrowed the code? If so, it would be great if you let the guys know and share your findings.

Yes, it is fixed on their side since I actually ported back the latest implementation of the clientsidepage file with some changes to remove the pnpjs dependencies, that is what actually causes some tests to fail...
I am digging into it to find out what exactly has changed.
BTW, I also added one method to properly handle the --order argument. I realized the specs say it is the order of the section, but actually it should be "the order of the control", I will make the changes accordingly

Cool! Glad that we have tests that verify how things work ☺

Hey @waldekmastykarz, actually, As I recopied manually all my changes to a new branch from the updated dev trunk, I forgot to recopy the updated PnPJS class that has fix many issues.
What I don't understand is how it can work on your side Oo ??
Will make this work ASAP

Perhaps we're looking at different scenarios. If the issue is with PnPjs, rather than just fixing it in our copy, it would be better, to log it in the PnPjs repo. Patrick and the crew spent significantly more time dealing with modern page HTML than us so they can be a better judge of whether it's really an issue and how it should be fixed, or we're just using it in an odd way.

Hi @waldekmastykarz , I resynced the clientsidepage class from pnpjs.
Everything works fine except that many tests are now failing mainly because the expected HTML was erroneous (there was a single closing div tag in the html returned by the pnpJS code.
The branch is available on my own repo : https://github.com/ypcode/office365-cli/tree/dev-spo-page-text-add
It takes a lot of time to correct the failing tests even if the commands still work, and unfortunately I will lack some... As I understood you were waiting on it, do you want me to submit it as PR with the tests failing ?
I will also need later to refactor the thing with WebPart to properly handle inserting them with a specific order

I can grab the code from your fork and work on that. You will of course get the credit for your work 😊
With regards to properly handling web part order, I'd expect to be handled correctly by PnPjs. If it's not, then we should raise an issue there and sync the updated version which will help a broader audience benefit of the fix.
Once again thanks for your help and I appreciate your time 👏

Sounds good 😃
I would definitely prefer to work much more on it and on the CLI in general but these days, it's become complicated, so much work and different projects and occupation, I just can't scale 😀
I will also make sure, if not handled in the meantime, the WebParts command works fine with order + need some refactoring also...
Thanks for this wonderful and very addictive project, you're leading and Thank YOU very much for your acknowledgement! It's always good to receive from a star like you 😄

It's not always easy to prioritize hobby side-project with everything else in life, so when we do get a contribution, we appreciate it, no matter how small it is.

FWIW: I had a look at the order option and it turns out that it never worked. Like you mentioned, it isn't there and the order option specified while adding web part is ignored. We'll be able to make a good use of your code so far! 👏

Hi waldek, will definitely need to refactor the webpart command as well then ;) if it can wait a few days I’d like to do it :)

De : Waldek Mastykarz<EMAIL_ADDRESS>Envoyé : samedi, décembre 15, 2018 9:34 PM
À : pnp/office365-cli
Cc : Yannick Plenevaux; Assign
Objet : Re: [pnp/office365-cli] New command: add text to modern page (#365)
FWIW: I had a look at the order option and it turns out that it never worked. Like you mentioned, it isn't there and the order option specified while adding web part is ignored. We'll be able to make a good use of your code so far! 👏
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/pnp/office365-cli/issues/365#issuecomment-447596081, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH9X1Oaz2m8MVaL_Hh6Po7od_8Ciz24Qks5u5VzigaJpZM4SpPrQ.

And I will also PR it to pnpjs ;)

De : yannick Plenevaux<EMAIL_ADDRESS>Envoyé : dimanche, décembre 16, 2018 3:33 PM
À : pnp/office365-cli; pnp/office365-cli
Cc : Assign
Objet : Re: [pnp/office365-cli] New command: add text to modern page (#365)
Hi waldek, will definitely need to refactor the webpart command as well then ;) if it can wait a few days I’d like to do it :)

De : Waldek Mastykarz<EMAIL_ADDRESS>Envoyé : samedi, décembre 15, 2018 9:34 PM
À : pnp/office365-cli
Cc : Yannick Plenevaux; Assign
Objet : Re: [pnp/office365-cli] New command: add text to modern page (#365)
FWIW: I had a look at the order option and it turns out that it never worked. Like you mentioned, it isn't there and the order option specified while adding web part is ignored. We'll be able to make a good use of your code so far! 👏
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/pnp/office365-cli/issues/365#issuecomment-447596081, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH9X1Oaz2m8MVaL_Hh6Po7od_8Ciz24Qks5u5VzigaJpZM4SpPrQ.

There is no rush for it as so far no one spotted it. I can log an issue for it and assign it to you. Thanks again for bringing it up.


Add ability to add capsule loading to client

Drag and drop capsule file onto client
Upload file button as alternative
Trash icon next to loaded capsules

With prompt dialog instead of Apply button

API already supports

Upload
Set (load)
Unload (storage may not be cleaned up afterward)

Where can things wrong

What happens when we upload a capsule with a duplicate name
Should we be able to upgrade capsules without removing old one first?

Ooh, can the "upload file button" use the same material design hover button that the "add stream" currently does, but just put in the Capsule Config window?


Local set up Binary data store enable

Comments : Due to the fact that direct binary upload is a configuration, whether or not this library can be used on a given AEM instance will vary.
We are using saas jar to enable the asset uploading in local env but not able to enable binary store.
Error : error: unhandled exception attempting to upload files direct binary access not supported
Logs:
2020-09-14T12:46:45.114Z [] info: AEM target folder '/content/dam/testcli' is created
2020-09-14T12:46:45.117Z [] info: Local files for uploading: [
{
"fileName": "ab.png",
"filePath": "/Users/haiali/Documents/AEMSAAS/samplecode/aio-cli-plugin-aem-master/ab.png",
"fileSize": 149018
}
]
2020-09-14T12:46:45.132Z [] info: Finished initialize uploading, response code: '200', time elapsed: '10' ms
2020-09-14T12:46:45.132Z [] info: Init upload result: {
"folderPath": "/content/dam/testcli",
"files": [
{
"fileName": "ab.png"
}
]
}
2020-09-14T12:46:45.140Z [] error: unhandled exception attempting to upload files direct binary access not supported

This is expected behavior. The library will only work when direct binary upload is enabled, as explained in the background. In cases where direct binary upload is not enabled the library will throw the exception indicated in the description.


latest release not aviable in maven repo

Hi,
https://mvnrepository.com/artifact/com.jayway.restassured/rest-assured
Does not reflect latest version, when it will be aviable?
Thanks.

It is available. The group id has changed, see release notes.


Make users aware that they should use a new prefix

Describe the solution you'd like
Make users aware that they should use a new prefix for their Data Landing Zone and not the same one as the one they have selected for the Data Management Zone.

This will be fixed by name availability checks.