Maintenance release testing for iPadOS 13 resizing

For https://github.com/phetsims/phet-core/issues/64. I'd like the normal "very brief, nothing is horribly wrong" testing per sim, and also ideally that we could test:

Sims behave normally in Chrome (or some desktop browser) when resized
Sims resize properly on iPadOS 13 (when loaded as portrait, switched to landscape, then switched to portrait again).
Sims size properly in full-screen on iPadOS 13.

Ideally I'd like this done fairly soon, I believe the release planned for the 19th.
acid-base-solutions 1.2 (https://github.com/phetsims/phet-core/issues/64)

[x] acid-base-solutions 1.2.22-rc.3

area-builder 1.1 (https://github.com/phetsims/phet-core/issues/64)

[x] area-builder 1.1.17-rc.2

area-model-algebra 1.0 (https://github.com/phetsims/phet-core/issues/64)

[x] area-model-algebra 1.0.10-rc.2

area-model-decimals 1.0 (https://github.com/phetsims/phet-core/issues/64)

[x] area-model-decimals 1.0.10-rc.2

area-model-introduction 1.0 (https://github.com/phetsims/phet-core/issues/64)

[x] area-model-introduction 1.0.10-rc.2

area-model-multiplication 1.0 (https://github.com/phetsims/phet-core/issues/64)

[x] area-model-multiplication 1.0.10-rc.2

arithmetic 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] arithmetic 1.0.21-rc.2

atomic-interactions 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] atomic-interactions 1.0.15-rc.2

balancing-act 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] balancing-act 1.1.21-rc.2

balancing-chemical-equations 1.2 (https://github.com/phetsims/phet-core/issues/64)

[ ] balancing-chemical-equations 1.2.7-rc.2

balloons-and-static-electricity 1.3-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] balloons-and-static-electricity 1.3.14-rc.2 phet-io
[ ] balloons-and-static-electricity 1.3.14-rc.2 phet-io Instance Proxies

balloons-and-static-electricity 1.4 (https://github.com/phetsims/phet-core/issues/64)

[ ] balloons-and-static-electricity 1.4.12-rc.2

beers-law-lab 1.4 (https://github.com/phetsims/phet-core/issues/64)

[ ] beers-law-lab 1.4.16-rc.2

beers-law-lab 1.5-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] beers-law-lab 1.5.14-rc.2 phet-io
[ ] beers-law-lab 1.5.14-rc.2 phet-io Instance Proxies

beers-law-lab 1.6-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] beers-law-lab 1.6.13-rc.2 phet-io
[ ] beers-law-lab 1.6.13-rc.2 phet-io Instance Proxies

bending-light 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] bending-light 1.1.18-rc.2

blackbody-spectrum 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] blackbody-spectrum 1.0.5-rc.2

build-a-fraction 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] build-a-fraction 1.0.8-rc.2

build-an-atom 1.4-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] build-an-atom 1.4.11-rc.2 phet-io
[ ] build-an-atom 1.4.11-rc.2 phet-io Instance Proxies

build-an-atom 1.5-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] build-an-atom 1.5.16-rc.2 phet-io
[ ] build-an-atom 1.5.16-rc.2 phet-io Instance Proxies

build-an-atom 1.6 (https://github.com/phetsims/phet-core/issues/64)

[ ] build-an-atom 1.6.11-rc.2

capacitor-lab-basics 1.3-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] capacitor-lab-basics 1.3.13-rc.2 phet-io
[ ] capacitor-lab-basics 1.3.13-rc.2 phet-io Instance Proxies

capacitor-lab-basics 1.6 (https://github.com/phetsims/phet-core/issues/64)

[ ] capacitor-lab-basics 1.6.17-rc.2
[ ] capacitor-lab-basics 1.6.17-rc.2 phet-io
[ ] capacitor-lab-basics 1.6.17-rc.2 phet-io Instance Proxies

charges-and-fields 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] charges-and-fields 1.0.45-rc.2

charges-and-fields 1.0-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] charges-and-fields 1.0.17-rc.2 phet-io
[ ] charges-and-fields 1.0.17-rc.2 phet-io Instance Proxies

circuit-construction-kit-black-box-study 1.1-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] circuit-construction-kit-black-box-study 1.1.14-rc.2 phet-io
[ ] circuit-construction-kit-black-box-study 1.1.14-rc.2 phet-io Instance Proxies

circuit-construction-kit-dc 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] circuit-construction-kit-dc 1.1.3-rc.2

circuit-construction-kit-dc-virtual-lab 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] circuit-construction-kit-dc-virtual-lab 1.1.3-rc.2

color-vision 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] color-vision 1.1.21-rc.2

color-vision 1.2-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] color-vision 1.2.13-rc.2 phet-io
[ ] color-vision 1.2.13-rc.2 phet-io Instance Proxies

concentration 1.3 (https://github.com/phetsims/phet-core/issues/64)

[ ] concentration 1.3.18-rc.2

concentration 1.5-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] concentration 1.5.12-rc.2 phet-io
[ ] concentration 1.5.12-rc.2 phet-io Instance Proxies

coulombs-law 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] coulombs-law 1.0.7-rc.2

diffusion 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] diffusion 1.0.2-rc.3

energy-forms-and-changes 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] energy-forms-and-changes 1.0.9-rc.2

energy-skate-park-basics 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] energy-skate-park-basics 1.1.17-rc.2

energy-skate-park-basics 1.3-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] energy-skate-park-basics 1.3.12-rc.2 phet-io
[ ] energy-skate-park-basics 1.3.12-rc.2 phet-io Instance Proxies

equality-explorer 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] equality-explorer 1.0.10-rc.2

equality-explorer-basics 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] equality-explorer-basics 1.0.10-rc.2

equality-explorer-two-variables 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] equality-explorer-two-variables 1.0.10-rc.2

expression-exchange 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] expression-exchange 1.1.11-rc.2

faradays-law 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] faradays-law 1.1.21-rc.2

faradays-law 1.3-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] faradays-law 1.3.15-rc.2 phet-io
[ ] faradays-law 1.3.15-rc.2 phet-io Instance Proxies

forces-and-motion-basics 2.1-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] forces-and-motion-basics 2.1.104-rc.2 phet-io
[ ] forces-and-motion-basics 2.1.104-rc.2 phet-io Instance Proxies

forces-and-motion-basics 2.3 (https://github.com/phetsims/phet-core/issues/64)

[ ] forces-and-motion-basics 2.3.14-rc.2

fraction-matcher 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] fraction-matcher 1.1.19-rc.2

fractions-equality 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] fractions-equality 1.0.8-rc.2

fractions-intro 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] fractions-intro 1.0.8-rc.2

fractions-mixed-numbers 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] fractions-mixed-numbers 1.0.8-rc.2

friction 1.5 (https://github.com/phetsims/phet-core/issues/64)

[ ] friction 1.5.8-rc.2

function-builder 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] function-builder 1.0.21-rc.2

function-builder-basics 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] function-builder-basics 1.0.12-rc.2

gas-properties 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] gas-properties 1.0.1-rc.3

gases-intro 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] gases-intro 1.0.2-rc.3

gene-expression-essentials 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] gene-expression-essentials 1.0.12-rc.2

graphing-lines 1.3 (https://github.com/phetsims/phet-core/issues/64)

[ ] graphing-lines 1.3.7-rc.2

graphing-quadratics 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] graphing-quadratics 1.1.3-rc.2
[ ] graphing-quadratics 1.1.3-rc.2 phet-io
[ ] [graphing-quadratics 1.1.3-rc.2 phet-io Studio](https://phet-dev.colorado.edu/html/graphing-quadratics/1.1.3-rc.2/phet-io/wrappers/studio

graphing-slope-intercept 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] graphing-slope-intercept 1.1.7-rc.2

gravity-and-orbits 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] gravity-and-orbits 1.1.13-rc.2

gravity-force-lab 2.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] gravity-force-lab 2.1.13-rc.2

hookes-law 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] hookes-law 1.0.21-rc.2

isotopes-and-atomic-mass 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] isotopes-and-atomic-mass 1.1.6-rc.2

john-travoltage 1.4-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] john-travoltage 1.4.14-rc.2 phet-io
[ ] john-travoltage 1.4.14-rc.2 phet-io Instance Proxies

john-travoltage 1.5 (https://github.com/phetsims/phet-core/issues/64)

[ ] john-travoltage 1.5.10-rc.2

least-squares-regression 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] least-squares-regression 1.1.18-rc.2

make-a-ten 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] make-a-ten 1.0.14-rc.2

masses-and-springs 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] masses-and-springs 1.0.8-rc.2

masses-and-springs-basics 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] masses-and-springs-basics 1.0.7-rc.2

molarity 1.4 (https://github.com/phetsims/phet-core/issues/64)

[ ] molarity 1.4.10-rc.2
[ ] molarity 1.4.10-rc.2 phet-io
[ ] molarity 1.4.10-rc.2 phet-io Studio

molecule-polarity 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] molecule-polarity 1.0.13-rc.2

molecule-shapes 1.2 (https://github.com/phetsims/phet-core/issues/64)

[ ] molecule-shapes 1.2.6-rc.2

molecule-shapes-basics 1.2 (https://github.com/phetsims/phet-core/issues/64)

[ ] molecule-shapes-basics 1.2.6-rc.2

molecules-and-light 1.3-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] molecules-and-light 1.3.11-rc.2 phet-io
[ ] molecules-and-light 1.3.11-rc.2 phet-io Instance Proxies

molecules-and-light 1.4 (https://github.com/phetsims/phet-core/issues/64)

[ ] molecules-and-light 1.4.12-rc.2

neuron 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] neuron 1.1.16-rc.2

ohms-law 1.4 (https://github.com/phetsims/phet-core/issues/64)

[ ] ohms-law 1.4.5-rc.2

pendulum-lab 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] pendulum-lab 1.0.13-rc.2

ph-scale 1.3 (https://github.com/phetsims/phet-core/issues/64)

[ ] ph-scale 1.3.2-rc.2

ph-scale-basics 1.3 (https://github.com/phetsims/phet-core/issues/64)

[ ] ph-scale-basics 1.3.2-rc.2

phet-io-test-sim 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] phet-io-test-sim 1.0.4-rc.2 phet-io
[ ] [phet-io-test-sim 1.0.4-rc.2 phet-io Studio](https://phet-dev.colorado.edu/html/phet-io-test-sim/1.0.4-rc.2/phet-io/wrappers/studio

phet-io-test-sim 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] phet-io-test-sim 1.1.7-rc.2 phet-io
[ ] [phet-io-test-sim 1.1.7-rc.2 phet-io Studio](https://phet-dev.colorado.edu/html/phet-io-test-sim/1.1.7-rc.2/phet-io/wrappers/studio

phet-io-test-sim 1.2 (https://github.com/phetsims/phet-core/issues/64)

[ ] phet-io-test-sim 1.2.3-rc.2 phet-io
[ ] [phet-io-test-sim 1.2.3-rc.2 phet-io Studio](https://phet-dev.colorado.edu/html/phet-io-test-sim/1.2.3-rc.2/phet-io/wrappers/studio

plinko-probability 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] plinko-probability 1.1.16-rc.2

projectile-motion 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] projectile-motion 1.0.13-rc.2

proportion-playground 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] proportion-playground 1.0.13-rc.2

reactants-products-and-leftovers 1.2 (https://github.com/phetsims/phet-core/issues/64)

[ ] reactants-products-and-leftovers 1.2.8-rc.2

resistance-in-a-wire 1.3-phetio (https://github.com/phetsims/phet-core/issues/64)

[ ] resistance-in-a-wire 1.3.11-rc.2 phet-io
[ ] resistance-in-a-wire 1.3.11-rc.2 phet-io Instance Proxies

resistance-in-a-wire 1.6 (https://github.com/phetsims/phet-core/issues/64)

[ ] resistance-in-a-wire 1.6.7-rc.2

rutherford-scattering 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] rutherford-scattering 1.1.7-rc.2

states-of-matter 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] states-of-matter 1.1.8-rc.2

states-of-matter-basics 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] states-of-matter-basics 1.1.6-rc.2

trig-tour 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] trig-tour 1.0.20-rc.2

under-pressure 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] under-pressure 1.1.16-rc.2

unit-rates 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] unit-rates 1.0.15-rc.2

wave-interference 1.0 (https://github.com/phetsims/phet-core/issues/64)

[ ] wave-interference 1.0.8-rc.2

wave-on-a-string 1.1 (https://github.com/phetsims/phet-core/issues/64)

[ ] wave-on-a-string 1.1.20-rc.2

Not really a bug, but something to be aware of.  The X in the full screen mode of iOS 13 can obscure parts of the sim.

https://github.com/phetsims/tambo/issues/78 occurs

https://phet-dev.colorado.edu/html/john-travoltage/1.4.14-rc.2/john-travoltage_en-phetio.html?phetioStandalone seems to be having trouble with sound, even though it isn't tambo.

QA is done.  Not sure what to do about https://github.com/phetsims/QA/issues/427#issuecomment-532835219

I believe the john-travoltage issue will be improved by patching of vibe (in a similar way to tambo) which would be accomplished during the same maintenance release.
Pushed out production deploys, @ariel-phet is there anything we need to handle for the large X blocking part of the sim? I'll be continuing to look into the related issues.

@jonathanolson it is seeming to me more and more that on iOS devices full screen is just highly problematic. Let's you and I plan to discuss in person today after buoyancy meeting.

Will deal with full screen issues in https://github.com/phetsims/phet-core/issues/64, closing


Sending Email memory issues

I can use the example program without any issue but when I try to integrate this to send Email notifications, it often fails. I tried the debug option and shows an error near the end of the process.
…
[DEBUG] - INFO: send STARTTLS protocol command
[DEBUG] - 220 2.0.0 SMTP server ready
[DEBUG] - INFO: seeding the random number generator
[DEBUG] - INFO: setting up the SSL/TLS structure...
[DEBUG] - INFO: setting hostname for TLS session...
[DEBUG] - INFO: performing the SSL/TLS handshake...
[DEBUG] - ERROR: X509 - Allocation of memory failed
[DEBUG] - INFO: cleaning SSL connection
Error, could not connect to server
[DEBUG] - ERROR: could not connect to server
Error sending Email, could not connect to server
Send email test failed
I guess I am wondering how much memory it needs and how to work around the problem.
Thank you

The core library, mbedTLS requires memory approx.. 100k for SSL data encryption/decryption.
If device has not enough free heap more than it required then server connection with SSL/TLS will be failed.
Check your free heap (ESP.getFreeHeap) before send/read Email.
Try reduce ram usage, reuse the memory, free your dynamic allocation variable.


Pathfinder Old/Legacy small syntax fixes

PF old/Legacy;
a couple small fixes for syntax errors

removed backslash on input
changed inline css from align:left to text-align:left

Thanks


Per progress sorting looks weird

This is how Progress sorting looks for one of my courses:

I think it should sort by (not sure which criteria should go first):

number of exercises tried
rate of success

@fedescarpa ?

Rate of success...
exercises_success_count / exercises_made_count

I think it's not good enough. Consider this example:

Pablo: 1/1 - rate 100%
Karen: 7/10 - rate 70%

Sorting by progress should show that Pablo is doing better than Karen, and
clearly that's not the case: her rate is worse, but at least she TRIED more
than him. Also, she's solved more exercises correctly than him.
To sum up, we have 3 numbers that matter:

rate of success,

of exercises tried,

of exercises solved.

We should agree on how to consider them and sort accordingly.
El lun., 11 de abr. de 2016 14:05, Federico Scarpa<EMAIL_ADDRESS>escribió:

Rate of success...
exercises_success_count / exercises_made_count
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/mumuki/mumuki-teacher-tools/issues/42#issuecomment-208451293

@faloi ok, but what about the following scenario:

Jose: 1/15
Maria: 9/10

María has a better rate and solved more exercises, but she tried less. So sorting by number of exercises solved isn't enough, neither.

@fedescarpa @aguspina @faloi Why not just sorting by number of exercises solved?
Considering that, at a given point, each student in the course is able to do the same amount of exercises, so the real rate is always number_of_exercises_solved/number_of_unlocked_exercises

I'd like to offer the possibility to have a lot of choices and let the user
choice one of its, including ascending and descending order.
On Mon, Apr 11, 2016 at 5:23 PM, Franco Leonardo Bulgarelli <
<EMAIL_ADDRESS>wrote:

@fedescarpa https://github.com/fedescarpa @aguspina
https://github.com/aguspina @faloi https://github.com/faloi Why not
just sorting by number of exercises solved?
Considering that, at a given point, each student in the course is able to
do the same amount of exercises, so the real rate is always
number_of_exercises_solved/number_of_unlocked_exercises
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/mumuki/mumuki-teacher-tools/issues/42#issuecomment-208543222

I'd like to offer the possibility to have a lot of choices and let the user choice one of its, including ascending and descending order.

Me too, BUT that's a different discussion. I do want to give our teachers the freedom to sort but without making them feel overwhelmed with too many options.
So, the decision of how the progress sorting works should be ours; obviously thinking of which is the most intuitive definition we can achieve.


Added Minimum Path Sum.java

Hey there thanks for the contribution. Would be great if you could star the repo so that it will be helpful for future contributors also. Thanks!


为什么手机上完全看不到

Expected behavior (预期行为)
电脑浏览器正常，手机浏览器不正常
Actual behavior (实际行为)
Steps to reproduce the behavior (重现步骤)
NexT Informations
Add the  ✔  sign before an item which is affected by this behavior.
NexT Version:
✔ Master
✔  Latest Release
✔  Old version -
NexT Scheme:

All schemes
Muse
✔  Mist
✔  Pisces

Other Informations (Like Browser, System, Screenshots)

@fastzhong dont understand u, write in English if not solved. If solved, close it please. Thank's!

我修改了一些源代码，还原后OK啦，应该还是有bug。


Editing Rejected Pirep ERROR - Facade\Ignition\Exceptions\View Exception

Editing a REJECTED pirep result in a error
7.0 b4
Steps to reproduce the behavior:

Go to 'pireps`
Click on 'Edit any rejected pirep'

https://flareapp.io/share/KPg9VW5a
https://imgur.com/a/jo0ZuNL (video capture)

Was the aircraft used removed?

well,  yes the aircraft was deleted or modified


rename youtube video files

Rather than publishing the file as the unique id inserted into YouTube, can we instead have a smarter algorithm that trims/compresses the video title?
Something like following replaces coupled with a 25-30 char limit would probably get most of the way:
/[^\p{L}]//
/\s+/-
A smarter version could split on spaces/dashes and try to ensure it only uses a whole number of words.

I suggest we use the same naming convention we have for claim names: https://github.com/lbryio/lbry.go/blob/master/ytsync/sources/youtubeVideo.go#L61
we could improve this function too and thus limit high fees based on long claim names

feature added and working fine :)


[296422 - Newsroom][Content Migration] Incomplete year selection in dropdown

DESCRIPTION: Year dropdown has limited selections.
STEPS TO REPLICATE:
Open page in a browser
Click Year dropdown and compare selections with the legacy page
MIGRATED PAGE:
https://tempnewsroom.accenture.de/de/industries/konsumgter-handel
LEGACY PAGE:
https://newsroom.accenture.de/de/industries/konsumgter-handel/
ER:

AR:

Azdo link : https://dev.azure.com/accenturecio26/WebContentDigAssetMgmt_PR1093/_workitems/edit/296422
cc @ravkiran @amol-anand @raymond-h-dev

original site has years in dropdown that have no content from what I have seen across some other pages.

Same as #396
@veejayricana we'll only show those years in which articles exist. In this particular case, there're articles from 2022 only, so the year 2022 is only shown.
In https://newsroom.accenture.de/de/industries/konsumgter-handel/, the articles are only from 2020 and 2022, so only those are shown in https://tempnewsroom.accenture.de/de/industries/konsumgter-handel
Please check with the business, if showing the only those years in which the articles are present, is ok.


Idea: useId hook

Hello 👋
So our team runs a number of snapshot tests and we kept getting unexpected results because of incrementer:

It's declared in the global scope
It's shared by all instances of the component
It incremented for every render of every instance of the component

This gave snapshot tests problems because if we skipped a test, the snapshots would run in a different order and the component IDs would be different. We also wondered if there would be performance problems: IDs use incrementer and incrementer was updated every render. We thought that might result in needless DOM updates.
The solution we're proposing is a useId hook that can keep a map of components-to-counters (in IdContext). The benefits:

Keeps data within React
Number for ID stays consistent during rerenders

If you're interested in this PR at all, I'm open to refactoring. Added some dependencies in order to add tests; can remove those if you'd prefer.

Ugh, sorry about the pnpm-lock.yaml. had a merge conflict and ran pnpm install.


Vicuna-13b model consistently outputs repeatedly in tensor parallelism

I have two 3090 GPUs on one host, so I tried using a tensor parallel loading model, which ran successfully, but the output kept repeating.

I'm having the same problem.
I also have 2 NVIDIA GeForce RTX 3090
When running vicuna-13b-v1.5-16k
Running vicuna-13b-v1.3 seemed to be okay.

@wenpengwu  I found out this due to rope embedding not supported yet, see #674

thanks， Using Vicuna-13b-1.5 ,not  Vicuna-13b-1.5-16k  eliminates the issue of duplicate output


edge disappears on selection, using SVG renderer

Describe the bug
When using the SVG renderer, selecting an edge causes it to disappear.
Your Example Website or App
https://stackblitz.com/edit/react-btcnz7-eevgj8?file=index.js,index.html
Steps to Reproduce the Bug or Issue

open the stackblitz link
click the "select edge" button
the edge disappears

Expected behavior
The behaviour should be the same as with the canvas renderer; the edge should remain visible and be displayed with the default selection styles.
Screenshots or Videos

Platform

OS: macOS
Browser: tested on chrome and firefox - the issue is present on both
Version: chrome 104.0.5112.101, @antv/g6 4.7.0

Additional context
No response

Yes, there are some problems still remain in SVG renderer. But I'm afraid they could not be solved recently. we suggest to use canvas renderer instead.

@Yanyan-Wang should we upgrade the version of g-svg that G6 is using? Is there any reason why we shouldn't do that?

Yes, there are some problems still remain in SVG renderer. But I'm afraid they could not be solved recently. we suggest to use canvas renderer instead.

Nowadays, svg rendering looks a lot more inconsistent than canvas, and it's harder to debug.
Are there any optimisations planned for this area?

@songhn233 apparently the plan is to upgrade the SVG renderer some time soon https://github.com/antvis/G6/issues/2859#issuecomment-1364958051 🤞

@songhn233 apparently the plan is to upgrade the renderer some time soon #2859 (comment) 🤞

@ensconced Thanks for the reply, but it will be a while before the 5.0 plan is actually implemented, and the debugging costs for compatibility with 4.x and migration are likely to be greater.
I will prioritise other ways to support the need for custom HTML/React nodes.

In the latest G6 5.0, this issue has been fixed. (By ClickElement behavior)


How to save the fingerprints

I am using other antidetect browser like adspower, How can I save those fingerprints and use them in BAS

Fingerprints from other anti-detection solutions cannot be used.


Broken Documentation link in README.md

The Documentation link leads to https://aldantanneo.github.io/minecraft_server_query. This results in a 404.
It should probably be replaced with https://aldantanneo.github.io/minecraft-server-query (replace the underscores with hypens).

Fixed, thanks


proposal: Optional command parameter rework

There is currently a limitation to how optional commands are done: you cant be sure whether a parameter was provided or that the user just gave the null value as an argument.
This is not unfixable, and I believe something similar to rust's Option<> type might be a way to solve this.
I have already implemented something like this in a library of my own: https://github.com/AndreasHGK/go-interactions and, while not the cleanest implementation, it does seem to work.
A command with an optional parameter would look like this:
type MyCommand struct {
    RequiredParam string
    OptionalParam cmd.Optional[string]
}

func (m MyCommand) Run(...) {
    optionalString, ok := m.OptionalParam.Read()
    alsoOptionalString := m.OptionalParam.ReadOrDefault("this is a default string")
}

Even if this is implemented, the old way of doing commands could technically still be supported but I am not sure if that is such a good idea, and DF is in alpha anyway.

Closed in 92477ebb1dc8c355c08eef1421ae80670bd6295d.


Fix vm and vmss custom script timestamp

This PR will fix the custom script timestamp in vm and vmss custom scripts
1231
PR Checklist

[X] I have added example(s) inside the [./examples/] folder
[] I have added the example(s) to the integration test list for normal (~30 minutes) or long runner >30 minutes
[X] I have checked the coding conventions as per the wiki
[X] I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

[ ] YES
[X] NO

Testing

thanks for your contribution @wasfree!


ItemTag.map_to_image

Additions

ItemHelper#renderMap - renders a MapView for a specific player.
ItemTag.map_to_image[<player>] - returns an ImageTag of a filled map item's contents.

Notes

Currently ItemHelper#renderMap just returns the byte[] array of internal image color data, and ItemTag.map_to_image has logic to draw that into an image.
The format of the array seems to be consistent across versions, but it's still an implmentation detail, so let me know if having the code to draw it onto an image in the NMS impl is preferrable (didn't do it since it's technically duplicate code, but would also make sense to avoid depending on something that's technically an implementation detail).

The format of the array seems to be consistent across versions, but it's still an implmentation detail, so let me know if having the code to draw it onto an image in the NMS impl is preferrable (didn't do it since it's technically duplicate code, but would also make sense to avoid depending on something that's technically an implementation detail) can split it to modules if/when it's actually different between versions, don't need to do it if it's the same in all supported versions


NPE during creation of new items referencing each other

While testing #2810 I tried creating multiple items which reference each other :  countries.openrefine.tar.gz
I got this stack trace:
08:51:15.001 [..mWikibaseEditsOperation] Performing edits (28ms)
08:51:15.003 [..ting.EditBatchProcessor] Requesting documents (2ms)
08:51:15.004 [..ting.EditBatchProcessor] Retrying in 10000 ms (1ms)
08:51:25.004 [..ting.EditBatchProcessor] Retrying in 20000 ms (10000ms)
08:51:44.443 [           ProjectManager] Saving some modified projects ... (19439ms)
08:51:44.453 [        project_utilities] Saved project '2563820830151' (10ms)
08:51:45.004 [..ting.EditBatchProcessor] Retrying in 40000 ms (551ms)
08:52:25.004 [..ting.EditBatchProcessor] Retrying in 80000 ms (40000ms)
08:53:46.427 [..kibaseapi.ApiConnection] API warning [main]: Unrecognized parameter: tags. (81423ms)
08:53:47.978 [..kibaseapi.ApiConnection] API warning [main]: Unrecognized parameter: tags. (1551ms)
08:53:48.822 [..kibaseapi.ApiConnection] API warning [main]: Unrecognized parameter: tags. (844ms)
08:53:49.326 [..kibaseapi.ApiConnection] API warning [main]: Unrecognized parameter: tags. (504ms)
08:53:49.825 [..kibaseapi.ApiConnection] API warning [main]: Unrecognized parameter: tags. (499ms)
Exception in thread "Thread-7" java.lang.NullPointerException
	at org.wikidata.wdtk.wikibaseapi.StatementUpdate.markStatementsForInsertion(StatementUpdate.java:381)
	at org.wikidata.wdtk.wikibaseapi.StatementUpdate.markStatementsForUpdate(StatementUpdate.java:307)
	at org.wikidata.wdtk.wikibaseapi.StatementUpdate.<init>(StatementUpdate.java:180)
	at org.wikidata.wdtk.wikibaseapi.TermStatementUpdate.<init>(TermStatementUpdate.java:127)
	at org.wikidata.wdtk.wikibaseapi.WikibaseDataEditor.updateTermsStatements(WikibaseDataEditor.java:732)
	at org.openrefine.wikidata.editing.EditBatchProcessor.performEdit(EditBatchProcessor.java:170)
	at org.openrefine.wikidata.operations.PerformWikibaseEditsOperation$PerformEditsProcess.run(PerformWikibaseEditsOperation.java:221)
	at java.base/java.lang.Thread.run(Thread.java:834)

There are a few problems here:

We try requesting documents in the beginning of the batch whereas all items are new, so there should not be any items to fetch. The API action is likely failing because we are requesting an empty list of documents. In any case, we should only retry fetching documents when the API error we get is a temporary one - in this case it is likely to be a persistent error;
If we fail with an exception after having created items (or if the user cancels the operation), we should still perform the operation (skipping further edits) such that the newly created items are updated in the project grid;
The NPE is worth solving on its own obviously.

To Reproduce
Steps to reproduce the behavior:

Import the project supplied above
Make sure the corresponding items have been deleted on OR Wikibase test first https://or-wikibase-test.wiki.opencura.com/wiki/Main_Page
Upload the edits to OR Wikibase test

Versions

testing from #2810 but I believe the bug is independent from @afkbrb 's refactoring

The structure of this code has changed a lot since that time (both in WDTK and in OpenRefine), so this is surely not reproducible in this form.


Failed to decrypt RSA encryption

hi, i do RSA encryption with pointy castle and always failed to decrypted back.
btw, decrypt process is in different environment  using PHP
here's my code :
BigInt modulus =  BigInt.parse(key,radix: 16);
    BigInt exponent = BigInt.from(65537);
    RSAPublicKey pubKey = new RSAPublicKey(modulus, exponent);
    AsymmetricKeyParameter<RSAPublicKey>  params = PublicKeyParameter(pubKey);
     //RSAEngine engine = new RSAEngine()..init(true, params);
    AsymmetricBlockCipher cipher = new AsymmetricBlockCipher("RSA/PKCS1")..init(true, params);
    Uint8List  plainText = Uint8List.fromList(plain.codeUnits);
    Uint8List encryptText =  cipher.process(plainText);
    List<String> hexes = "0123456789ABCDEF".split("");
    StringBuffer buffer = new StringBuffer(2*encryptText.length);
    for(int b in encryptText){
      buffer.write(hexes[(b & 0xF0) >> 4]);
      buffer.write(hexes[(b &0x0F)]);
    }
    return buffer.toString();

here's my flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v0.9.4, on Mac OS X 10.14 18A391, locale en-ID)
[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[!] iOS toolchain - develop for iOS devices (Xcode 10.0)
    ! CocoaPods out of date (1.5.0 is recommended).
        CocoaPods is used to retrieve the iOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without resolving iOS dependencies with CocoaPods, plugins will not work on iOS.
        For more info, see https://flutter.io/platform-plugins
      To upgrade:
        brew upgrade cocoapods
        pod setup
[✓] Android Studio (version 3.2)
[!] VS Code (version 1.28.2)
[✓] Connected devices (1 available)

is there something wrong  in my encryption process ?

@rickyazhari This is what i use for my pkcs1 encrypt, i'm using a C# based server implementation and all is good. I'm passing in the modulus and exponent in as strings.
var text = "Your message here"
var pubKey = RSAPublicKey(BigInt.parse(modulus), BigInt.parse(exponent))
var cipher = PKCS1Encoding(RSAEngine());
cipher.init(true, PublicKeyParameter<RSAPublicKey>(pubKey));
Uint8List output = cipher.process(utf8.encode(text));
var base64EncodedText = base64Encode(output);

Give that a go and see if you get the same results.

hai @duncanhoggan  thanks for advice. i already follow your code for encryption. unfortunately it's cannot  decrypted as well. here's my code
RSAPublicKey pubkey = new RSAPublicKey(BigInt.parse(key,radix: 16), BigInt.parse("65537"));
    var cipher = PKCS1Encoding(new RSAEngine());
    cipher.init(true, PublicKeyParameter<RSAPublicKey>(pubkey));
    var encryptText = cipher.process(Uint8List.fromList(plain.codeUnits));
    List<String> hexes = "0123456789ABCDEF".split("");
    StringBuffer buffer = new StringBuffer(2*encryptText.length);
    for(int b in encryptText){
      buffer.write(hexes[(b & 0xF0) >> 4]);
      buffer.write(hexes[(b &0x0F)]);
    }
    return buffer.toString();

Really thanks, i still figure out where i miss

Hey, not sure what you plan is but you need the private and public pieces of the key to decrypt if you are using RSA.
Generally...
message ---> encrypted using public key ---> transport ---> decrypted using private key ---> message

Can you share function for decrypting using private key ?

@lets-swapcode rather open a new issue as opposed to clouding this issue.

ar text = "Your message here"
var pubKey = RSAPublicKey(BigInt.parse(modulus), BigInt.parse(exponent))
var cipher = PKCS1Encoding(RSAEngine());
cipher.init(true, PublicKeyParameter(pubKey));
Uint8List output = cipher.process(utf8.encode(text));
var base64EncodedText = base64Encode(output);

I'd been battling this for weeks. Your solution worked like charm

hi
C# Server :
public static string RsaEncrypt(string data, string pubkey)
{
RSAParameters ApublicKey;
var pub = GetPublicKeyFromPemFile(pubkey);
ApublicKey = pub.ExportParameters(false);
RSAParameters result = new RSAParameters();
result.Modulus = ApublicKey.Modulus;
result.Exponent = ApublicKey.Exponent;
System.Text.UTF8Encoding encoding = new System.Text.UTF8Encoding();
byte[] DataToEncrypt = encoding.GetBytes(data);
byte[] encryptedData;
        using (RSACryptoServiceProvider RSA = new RSACryptoServiceProvider(2048))
        {
            RSA.ImportParameters(result);
            encryptedData = RSA.Encrypt(DataToEncrypt, true);
        }
        return Convert.ToBase64String(encryptedData);
    }

Dart Client :
AsymmetricKeyPair rsaGenerateKeyPair({int bitStrength = 2048}) {
var keyParams =
new RSAKeyGeneratorParameters(BigInt.parse('65537'), bitStrength, 12);
var secureRandom = new FortunaRandom();
var random = new Random.secure();
List seeds = [];
for (int i = 0; i < 32; i++) {
seeds.add(random.nextInt(255));
}
secureRandom.seed(new KeyParameter(new Uint8List.fromList(seeds)));
var rngParams = new ParametersWithRandom(keyParams, secureRandom);
var k = new RSAKeyGenerator();
k.init(rngParams);
return k.generateKeyPair();
}
encodePublicKeyToPem(RSAPublicKey publicKey) {
var algorithmSeq = new ASN1Sequence();
var algorithmAsn1Obj = new ASN1Object.fromBytes(Uint8List.fromList([0x6, 0x9, 0x2a, 0x86, 0x48, 0x86, 0xf7, 0xd, 0x1, 0x1, 0x1]));
var paramsAsn1Obj = new ASN1Object.fromBytes(Uint8List.fromList([0x5, 0x0]));
algorithmSeq.add(algorithmAsn1Obj);
algorithmSeq.add(paramsAsn1Obj);
var publicKeySeq = new ASN1Sequence();
publicKeySeq.add(ASN1Integer(publicKey.modulus));
publicKeySeq.add(ASN1Integer(publicKey.exponent));
var publicKeySeqBitString = new ASN1BitString(Uint8List.fromList(publicKeySeq.encodedBytes));
var dataBase641 = base64.encode(publicKeySeq.encodedBytes);
var dataBase642 = base64.encode(publicKeySeq.elements[1].encodedBytes);
var topLevelSeq = new ASN1Sequence();
topLevelSeq.add(algorithmSeq);
topLevelSeq.add(publicKeySeqBitString);
var dataBase64 = base64.encode(topLevelSeq.encodedBytes);
return """-----BEGIN PUBLIC KEY-----\r\n$dataBase64\r\n-----END PUBLIC KEY-----""";
}
this code not work true on dart, please help me


Add documentation to the code affected from v0.28 changes

This PR adds documentation to the classes, properties, and methods changed/added in the new release v0.28

bors merge

bors merge

bors merge


Support for Pipeline Templates

Now that Pipeline Templates have been released for Enterprise accounts, it would be extremely helpful in our adoption of this new feature if we could manage these templates through Terraform.

Great suggestion thanks @WBrettDavis 👍
There is no API support for templates just yet but we'll see about getting an API and then into terraform

This would be invaluable for our use case at Square. We have custom yaml tooling for translating yaml pipeline configs to Terraform.
If we can have template support via a tf resource. I know a lot of our teams would be appreciative.

Hey @jmandel1027 🙂 (also @WBrettDavis!)
Been working on the implementation of templates here with the API support for the respective queries/mutations - hope to get this through into main, and then subsequently available for the next release!

Amazing!! Thanks gang! Looking forward to it

Hey @jmandel1027 - doing a loop over issues at present: as above with the work on that branch, all was moved through and  said resource is available from v1.1.0 of the provider! (note the absolute latest is v1.1.1)
If you've got any more ideas/feature requests, please don't hesitate to whip them here  in GitHub as per this 🙂


rocky8.9 startup report, IPtables error message

rocky8.9 startup report, IPtables error message
windows11  | ❯ Extracting Windows 11 bootdisk... windows11  | ❯ Extracting Windows 11 environment... windows11  | ❯ Extracting Windows 11 setup... windows11  | ❯ Extracting Windows 11 image... windows11  | ❯ Adding XML file for automatic installation... windows11  | ❯ Building Windows 11 image... windows11  | ❯ Creating a 64G growable disk image in raw format... windows11  | iptables v1.8.10 (legacy): can't initialize iptables tablenat': Table does not exist (do you need to insmod?)
windows11  | Perhaps iptables or your kernel needs to be upgraded.
windows11  | ❯ ERROR: Status 3 while: iptables -t nat -A POSTROUTING -o "$VM_NET_DEV" -j MASQUERADE (line 185/311)
windows11  | ❯ Starting Windows for Docker v2.08...
windows11  | ❯ For support visit https://github.com/dockur/windows
windows11  |
windows11  | iptables v1.8.10 (legacy): can't initialize iptables table `nat': Table does not exist (do you need to insmod?)
windows11  | Perhaps iptables or your kernel needs to be upgraded.
windows11  | ❯ ERROR: Status 3 while: iptables -t nat -A POSTROUTING -o "$VM_NET_DEV" -j MASQUERADE (line 185/311)
windows11  | ❯ Starting Windows for Docker v2.08...
windows11  | ❯ For support visit https://github.com/dockur/windows
`

modprobe insmod
modprobe: FATAL: Module insmod not found in directory /lib/modules/4.18.0-513.5.1.el8_9.x86_64

sudo modprobe ip_tables
sudo modprobe iptable_nat
this is ok.


From Hugo 0.24 this must be provided in the archetype file itself

$ hugo new post/blah.md WARNING: date and/or title missing from archetype file "/home/user/site/themes/hugo-theme- cactus-plus/archetypes/default.md". From Hugo 0.24 this must be provided in the archetype file itself, if needed. Example: +++ title = "{{ replace .TranslationBaseName "-" " " | title }}" date = {{ .Date }} draft = true +++

Thank you very much，I have fixed this: https://github.com/nodejh/hugo-theme-cactus-plus/commit/960e71e89942006dd005eec737da868bfed7ce18


requestPurchaseWithOffer cause app crash

Please use Discussion board if you want get some help out of it. Please report issue if there is a bug.

Version of react-native-iap
v8.5.1
Version of react-native
v0.66.3
Platforms you faced the error (IOS or Android or both?)
IOS
Expected behavior
requestPurchaseWithOffer work
Actual behavior
requestPurchaseWithOffer cause app crash
Tested environment (Emulator? Real Device?)
real device - iphone 12 mini
Steps to reproduce the behavior

get subscription info having a promotional offer to use getSubscription(sku)
generate signature like this

const combinedString = bundleId + '\u2063' + keyIdentifier + '\u2063' + subscriptionId + '\u2063' + offerId + '\u2063' + userId(applicationUserName) + '\u2063' + nonce + '\u2063' + timeStamp;

signed the combinedString with our private key
convert signed combinedString to base64 string
When I used requestPurchaseWithOfferIOS(subscriptionId, userId, withOffer) function, app crash occured.
This is an error log. This is all the thing.

Could not cast value of type '__NSCFNumber' (0x131dfe8c0) to 'NSString' (0x131df5dd8).
dyld4 config: DYLD_LIBRARY_PATH=/usr/lib/system/introspection DYLD_INSERT_LIBRARIES=/Developer/usr/lib/libBacktraceRecording.dylib:/Developer/usr/lib/libMainThreadChecker.dylib:/Developer/Library/PrivateFrameworks/DTDDISupport.framework/libViewDebuggerSupport.dylib
(lldb)

Is there any problem with what I did?
Let me know if anything else can help.
Thank you.

+1
same here

@khj3132 the method respects withOffer to be an object please take a look at the documentation

@andresesfm The issue is more:
The change wasn't documented in the Changelog.

...


Use array of binary for literals size >4GB to get around msgpack limit

Fixes #2057
Tested on DLRM model and it works.
For binary blobs larger than 4GB, this could slower speed of deserialization.
Another problem is that literal doesn't have a constructor that can accept std::move(). Here I need to create a temporary vector of huge size and pass it to a literal constructor which in turn allocates huge buffer size and just copies data to the internal buffer from the temporary vector.
having a value::binary_array type would solve this in a better way.

closing this, superseded by #2068


epm-error on some smac-data

happens in fanova, ablation and sometimes in cost_over_time.
There are 26 parameters and 138 instance features in the example below.
ValueError                                Traceback (most recent call last)
<ipython-input-11-cb41bb471f19> in <module>
----> 1 cave.cave_ablation()

(...)

~/virtual_environments/ve_release/lib/python3.6/site-packages/pimp/evaluator/ablation.py in run(self)
    287
    288         # Predict source and target performance to later use it to predict the %improvement a parameter causes
--> 289         source_mean, source_var = self._predict_over_instance_set(impute_inactive_values(self.source))
    290         prev_performance = source_mean
    291         target_mean, target_var = self._predict_over_instance_set(impute_inactive_values(self.target))

~/virtual_environments/ve_release/lib/python3.6/site-packages/pimp/evaluator/ablation.py in _predict_over_instance_set(self, config)
    387             the variance over the instance set. If logged values are used, the variance might not be able to be used
    388         """
--> 389         mean, var = self.model.predict_marginalized_over_instances(np.array([config.get_array()]))
    390         return mean, var
    391

~/virtual_environments/ve_release/lib/python3.6/site-packages/smac/epm/base_epm.py in predict_marginalized_over_instances(self, X)
    240             raise ValueError('Expected 2d array, got %dd array!' % len(X.shape))
    241         if X.shape[1] != len(self.types):
--> 242             raise ValueError('Rows in X should have %d entries but have %d!' % (len(self.types), X.shape[1]))
    243
    244         if self.instance_features is None or \

ValueError: Rows in X should have 164 entries but have 26!

@AndreBiedenkapp I think this is something that affects all kinds of calls to  predict_marginalized_over_instances, because the new checks enforce that we specify the actual features over which to marginalize... while everywhere in pimp, we just throw in the configs... is this a design issue I'm not aware of? Or did we just use the epm in way that was not intended (maybe @mfeurer)?

This should be solved with CAVE 1.1.8 and PIMP 1.0.6


PUPIL-249 feat(oak-layout): add oak layout to quiz

Add quiz layout to quiz view
How to test

Go to https://deploy-preview-2207--oak-web-application.netlify.thenational.academy/pupils/programmes/english-secondary-ks4-aqa/units/macbeth-and-masculinity-the-struggle-for-power/lessons/duncan-as-a-father-figure
Click on quizzes
You should see quiz layout

Screenshots
How it used to look (delete if n/a):
{screenshots}
How it should now look:
{screenshots}
Checklist

[x]  Use oakLessonLayout
[x]  MCQs display ‘select x answers’
[x]  Question count
[x]  Back button and header
[x]  Feedback in bottom nav
[x]  Different colour backgrounds based on starter or exit quiz
[x]  mobile, tablet browser views
[x]  final button is ‘continue lesson’ instead of ‘next question’

Design feedback:

The bottom nav bar isn't currently fixed to the bottom of the browser window. Background & container should always take up the height of the window, with the nav bar fixed to the bottom. May need additional space applied so it always appears that way. E.g:

The height of the bottom nav looks a little too large for the desktop, tablet & mobile breakpoints when there is no feedback present. Checked the designs, and the height should be 80px (currently 100px).
The button in the bottom nav should be centre-aligned vertically across all breakpoints.
For mobile, the button in the bottom nav should be aligned on the right, and the gleap button should be positioned to not obstruct anything in the bottom nav if that is possible to do? Here I have added 60px bottom margin to the gleap:

The question stem heading colour token looks incorrect, should use text-primary
For MCQ questions in the starter and exit quizzes, the question stem and radio buttons middle area on mobile (max width) look to have more space on the left and right (margins) when compared to the designs. In the designs, the margins for mobile are set to 16px.
The middle area (question stem and radio buttons/checkboxes/text input etc) on desktop across all questions in the starter and exit quiz sections (max width) should be set to 8cols for desktop (848px in the designs), currently at 738.359px. E.g:
 There looks to be different widths across the quiz questions for both sections applied currently.
For the 2nd question of the starter quiz, and the 1st question of the exit quiz the space between the question stem heading and the 'Type your answer here' text should be using 'space-between-xl' for desktop, 'space-between-l' for tablet, and 'space-between-m' for mobile (same should be applied across the quizzes)
For the 2nd question of the starter quiz, and the 1st question of the exit quiz there is some shift in the size of the text input when submitting the question on desktop, and when the icon appears when in a valid or invalid state. The text input width shouldn't increase in width ideally across states. I think the width should be increased to something like 500px as a default for desktop. The text input should span the full width for tablet and mobile. E.g:

For the 3rd & 4th questions of the exit quiz, there is some shift in the size of the radio buttons when submitting the question on desktop & tablet, and when the icon appears when in a valid or invalid state.
For the 5th question of the exit quiz, there is some shift in the size of the checkboxes when submitting the question on desktop & tablet, and when the icon appears when in a valid or invalid state.
Checking if part of the scope of this ticket - the feedback is missing from the bottom nav when a quiz answer is correct or incorrect. E.g:

Can we check which FontTokens the question stem is using? It should useheading-4 for desktop & tablet, and heading-6 for mobile.
Checking if part of the scope of this ticket - will the 'Select one answer' text be a part of another ticket for MCQ questions? E.g:

Checking if part of the scope of this ticket - will the counter on the top right be a part of another ticket? E.g:

Just to note that the text in the top header and the button text label will be updated as part of the suggestions from Alex that she shared with me on Friday. I'll create a separate ticket for those text updates for the next sprint once they are finalised and reflected in the designs.

That's all the feedback I'll add for now as it is difficult to review further until those updates are made. I'll have another review once updated. Thanks

Bugs/design differences spotted so far:

In the feedback area, correct questions should have a Well done! feedback text below the Correct feedback heading. Figma link
Also, incorrect answers should have the correct answer(s) displayed below the Incorrect feedback heading in the format Correct answer: [correct answer(s)]. Figma link
Checkbox questions where the user should give feedback of Almost correct when the user has selected not enough right answers or a mixture of right and wrong answers, as well as displaying the full list of correct answers in the format Correct answer: [correct answer(s)]. Figma link
Also for checkbox questions, when a user selects all of the correct answers and one or more incorrect answers, the feedback is incorrectly given as 'Correct' and the user's score increases by 1 on the overview page!
Once again on the checkbox questions, the help text says Select 2 answer instead of Select 2 answers - I'll leave it up to you if you want to do some clever auto-pluralisation logic here, or just make it so that checkbox questions are always Select X answers (because a checkbox question with only 1 answer should be a radio button question). Figma link

Screenshots:

Thanks @benprotheroe. Besides what @rightsaidjames added above, here is the design feedback:

For short answer questions, the 'Type your answer' text label looks like it is a different styling to the designs. Should be 'heading-light-6' for desktop/tablet and 'heading-light-7' for mobile (should be the same for the 'Select one answer' or the 'Select 2 answers' text for MCQ questions.

For all starter quiz MCQ questions, the space between the 'Select one answer' and the 'Select 2 answers' text and the radio buttons/checkboxes group needs to decrease to use 'space-between-m' across all breakpoints. This should also be the same for short answer questions with the 'Type your answer' text label. E.g:

The top nav on mobile should display the question counter when in the starter/exit quiz sections. E.g:

All of the fixes I raised look good for me, except that the Feedback for partially correct checkbox answers is still 'Incorrect' rather than 'Almost correct':

Here's the rest of my screenshots showing the fixes:

:tada: This PR is included in version 1.336.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


array must not contain infs or NaNs

Hi Guys
I am getting this numpy error
Computing principal components 0% [######] 100% | ETA: 00:00:00 Total time elapsed: 00:00:01 Traceback (most recent call last):   File "run.py", line 71, in <module>     run_experiment(model_name, dataset_dir, embedding_dir)   File "run.py", line 16, in run_experiment     datasets = dm.data.process(path=dataset_dir,   File "/root/anaconda3/lib/python3.8/site-packages/deepmatcher/data/process.py", line 208, in process     datasets = MatchingDataset.splits(   File "/root/anaconda3/lib/python3.8/site-packages/deepmatcher/data/dataset.py", line 581, in splits     datasets[0].compute_metadata(train_pca)   File "/root/anaconda3/lib/python3.8/site-packages/deepmatcher/data/dataset.py", line 291, in compute_metadata     svd.fit(concatenated.numpy())   File "/root/anaconda3/lib/python3.8/site-packages/sklearn/decomposition/_truncated_svd.py", line 143, in fit     self.fit_transform(X)   File "/root/anaconda3/lib/python3.8/site-packages/sklearn/decomposition/_truncated_svd.py", line 178, in fit_transform     U, Sigma, VT = randomized_svd(X, self.n_components,   File "/root/anaconda3/lib/python3.8/site-packages/sklearn/utils/extmath.py", line 354, in randomized_svd     Uhat, s, V = linalg.svd(B, full_matrices=False)   File "/root/anaconda3/lib/python3.8/site-packages/scipy/linalg/decomp_svd.py", line 106, in svd     a1 = _asarray_validated(a, check_finite=check_finite)   File "/root/anaconda3/lib/python3.8/site-packages/scipy/_lib/_util.py", line 263, in _asarray_validated     a = toarray(a)   File "/root/anaconda3/lib/python3.8/site-packages/numpy/lib/function_base.py", line 485, in asarray_chkfinite     raise ValueError( ValueError: array must not contain infs or NaNs
Any suggestions please ?
Thanks
Sreeni

Is it possible to convert your code into a Colab notebook and share so I can take a look?

Hi Guys
Did you solve this numpy error?
I have the same


ng build --prod not displaying angular material UI

🐞 Bug report
Command (mark with an x)

ng build --prod

[ ] new
[X ] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
Don't know

Description
 A clear and concise description of the problem...
🔬 Minimal Reproduction
install angular material and run command ng build --prod. So you can see that dist is generated but on localhost: 4200, the angular material UI getting disturbs
🔥 Exception or Error

ERROR TypeError: ctor is not a constructor
    at createClass (main.720046d….js:37458)
    at createDirectiveInstance (main.720046d….js:37341)
    at createViewNodes (main.720046d….js:38558)
    at Object.createEmbeddedView (main.720046d….js:38466)
    at<EMAIL_ADDRESS>(main.720046d….js:37051)
    at<EMAIL_ADDRESS>(main.720046d….js:36917)
    at<EMAIL_ADDRESS>(main.720046d….js:23677)
    at NgIf.set [as ngIf] (main.720046d….js:23645)
    at updateProp (main.720046d….js:37613)

🌍 Your Environment

 Angular CLI: 6.2.9
Node: 8.5.0
OS: linux x64
Angular: 6.1.10
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.8.9
@angular-devkit/build-angular      0.8.9
@angular-devkit/build-optimizer    0.8.9
@angular-devkit/build-webpack      0.8.9
@angular-devkit/core               0.8.9
@angular-devkit/schematics         0.8.9
@angular/cdk                       6.4.7
@angular/cli                       6.2.9
@angular/fire                      5.2.3
@angular/material                  6.4.7
@angular/material-moment-adapter   8.2.3
@ngtools/webpack                   6.2.9
@schematics/angular                0.8.9
@schematics/update                 0.8.9
rxjs                               6.2.2
typescript                         2.9.2
webpack                            4.16.4

Anything else relevant?

Hi @Maulik009, you seem to be using an older version of the CLI since than a lot of bug have been fixed. Can you please update to version 8 and try again?

@alan-agius4 my entire project is built on angular 6 and related dependencies. Is it going to impact on dependencies if I update my angular cli version ?

@Maulik009, yeah you’d need to update other dependencies as well

For now I managed by using following command :
ng build --prod --aot=false --build-optimizer=false
But anyhow angular team needs to be resolve this for version 6

While Angular 6 can still be used, it is no longer a supported version.  For further information, please see: https://angular.io/guide/releases
Information regarding the update process can be found here: https://update.angular.io/

Closing as per above


Remove default component for Setup.tsx

We should ideally never been in the state where they're rendered so should remove the default basics. At a minimum, we should remove the button that advances.
Originally posted by @garyray-k in https://github.com/fedimint/fedimint/pull/2360#discussion_r1186962984

This issue is old and we're trying to reduce the amount of old issues given the design refresh, so closing for now


Make tiles all have the same height

Fixes
Issue Number:

What is the current behavior?
Tile height can be different

What is the new behavior?
All tiles will be the same height

The title section will expand to fill in any unused space.
Thought about making the ad size the same height as claim thumbnails, but did not change that because the ads weren't rendering for me and I didn't know if it would look weird.
that would look something like this:

Other information

PR Checklist

Toggle...
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[ ] I added a line describing my change to CHANGELOG.md
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

Haven't tried, but I think it every tile will then also stretch if there are reposts in the list?  The empty space in the tile doesn't feel good, also the tiny ad is just as bad.
Or maybe we should just limit this fix to the ads, or perhaps use min-height

@infinite-persistence ah good point.
I just came across that

@infinite-persistence
What if we displayed the repost above the channel name and made it one line?
It would still increase the tiles of the row, but not by much.

Those still look a bit strange to me, very elongated. I think i'd rather suffer from them not being the same height. Once you join our guests channel on slack, you can check out the redesign, I think it was solved in a different way (or maybe the same, haven't looked closely yet).

@tzarebczan The redesign looks really nice. Hopefully it also solves this issue. I think I'll wait it to be merged in before continuing with this. I agree there are problems with this approach that are probably not worth solving at this moment. Appreciate the feedback.


081416_15 start/end times are incorrect?

Cropping 081416_15 track makes it look weird. Here's the timeline of events from the metadata, and here are the tracks. Worth a closer look—do you have the ability to look into this @amcinturff ?
Start: 06:10
Harvest: 06:32
End: 07:50
I think that the start and/or end times may have to be adjusted based on the movement paths.
RAW TRACK:

CROPPED TRACK (between 06:10 and 07:50):

I looked at the raw track. It looks like they started moving before
official sunrise (about 5:25), so that explains why some of the path from
HQ to the harvest site is missing. However, they didn't actually end at
7:50, but rather about 8:00am. So, we could either change both boundaries
of the clip (Start: 5:25; End:8:00) to reflect their actual behavior, or we
could keep the start time consistent with other hunters and the law and
just change the end time. My instinct is the first, since I suspect they
were searching for deer before 6:10 even if htey knew they couldn't fire
yet (and if they saw a prize buck I bet they would have shot anyway)
On Tue, Dec 14, 2021 at 9:37 AM Kaitlyn Gaynor @.***>
wrote:

Cropping 081416_15 track makes it look weird. Here's the timeline of
events from the metadata, and here are the tracks. Worth a closer look—do
you have the ability to look into this @amcinturff
https://github.com/amcinturff ?
Start: 06:10
Harvest: 06:32
End: 07:50
I think that the start and/or end times may have to be adjusted based on
the movement paths.
RAW TRACK:
[image: Screen Shot 2021-12-14 at 9 36 53 AM]
https://user-images.githubusercontent.com/29489999/146050475-02cfa9b6-eb74-464c-a4de-b763ee7056e0.png
CROPPED TRACK (between 06:10 and 07:50):
[image: Screen Shot 2021-12-14 at 9 36 45 AM]
https://user-images.githubusercontent.com/29489999/146050453-09e2a58a-bf1f-43a5-9f98-4acb77242c13.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kaitlyngaynor/hopland-hunting/issues/23, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APHK2II63C3EKXNLLOVQHSDUQ56EZANCNFSM5KBP7AHQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Ok sounds good. I changed the start and end time as suggested in the new version of the doc igotu_metadata_times_cleaned_17Dec2021.csv.
FYI the start times should be the time that we handed them the logger, NOT the time of sunrise. Many of them are around 5am. So in this case, I think it was just an error in data recording.


Build 2 series of eBPF objects(kernel ver. <5.13 & >=5.13) and load eBPF dynamically when Kmesh starts up

What type of PR is this?

/kind enhancement
What this PR does / why we need it:
Problem: Kernel version lower than 5.13 does not support bpf_snprintf(), thus eBPF log can not be redirected to Kmesh daemon. There is no good solution for now.
Solution: Build 2 series of eBPF objects, one of them with -DKERNEL_VERSION_HIGHER_5_13_0=0, another with -DKERNEL_VERSION_HIGHER_5_13_0=1. When Kmesh starts up, detect the kernel version then load one of them.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

TODOs:

Use interface to reduce code lines

@hzxuzhonghu

Mostly lgtm
@tacslon Did you test it on os < 5.13

Mostly lgtm @tacslon Did you test it on os < 5.13

Mostly lgtm @tacslon Did you test it on os < 5.13

I'm working on the testing, include build on os >= 5.13 then run on os < 5.13

Tests:

=5.13
BPF log is printed in kmesh-daemon, and no BPF log in bpftool prog tracelog:

< 5.13
BPF log is printed in bpftool prog tracelog, and no BPF log in kmesh-daemon:


Apparently the newest version of Discord.py has many changes to async functions and cogs loading thus the current code isnt compatible with the newest version.

The issue is fixed and now the bot is working.
Set your bots Privileged Gateway Intents.


Rakkas should not error if hash element not found during scroll resolution

I'm using Clerk, and their auth component stores state in the URL hash. Rakkas' scroll restoration logic causes this error:

Reproduction with a fresh Rakkas project (0.7.0-next.10):

Should be fixed 0.7.0-next.11.


python312Packages.correctionlib: 2.6.1 -> 2.6.4

Description of changes
Changelog: https://github.com/cms-nanoAOD/correctionlib/releases/tag/v2.6.4
cc @veprbl

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


Type mismatch: inferred type is ScalingUtils.ScaleType? but ScalingUtils.ScaleType was expected

Description
Hey,
Trying to build my android project into an APK but getting this error: Type mismatch: inferred type is ScalingUtils.ScaleType? but ScalingUtils.ScaleType was expected
Version
18.0.0
Output of npx react-native info
System:
  OS: macOS 12.3.1
  CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
  Memory: 37.08 MB / 8.00 GB
  Shell: 5.8 - /bin/zsh
 Binaries:
  Node: 17.9.0 - /usr/local/bin/node
  Yarn: 1.22.18 - /usr/local/bin/yarn
  npm: 8.5.5 - /usr/local/bin/npm
  Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
 Managers:
  CocoaPods: 1.11.3 - /usr/local/bin/pod
 SDKs:
  iOS SDK:
   Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5
  Android SDK: Not Found
 IDEs:
  Android Studio: 2021.1 AI-211.7628.21.2111.8309675
  Xcode: 13.3/13E113 - /usr/bin/xcodebuild
 Languages:
  Java: 11.0.14 - /usr/bin/javac
 npmPackages:
  @react-native-community/cli: Not Found
  react: Not Found
  react-native: Not Found
  react-native-macos: Not Found
 npmGlobalPackages:
  *react-native*: Not Found

Steps to reproduce
None so far.
Snack, code example, screenshot, or link to a repository
override fun create(options: SharedElementTransitionOptions): Animator {
        with(to as ReactImageView) {
            hierarchy.actualImageScaleType = InterpolatingScaleType(
                    getScaleType(from),
                    getScaleType(to),
                    calculateBounds(from),
                    calculateBounds(to)
            )
            return ObjectAnimator.ofObject(TypeEvaluator<Float> { fraction: Float, _: Any, _: Any ->
                hierarchy.actualImageScaleType?.let {
                    (hierarchy.actualImageScaleType as InterpolatingScaleType?)!!.value = fraction
                    to.invalidate()
                }
                null
            }, 0, 1).setDuration(options.getDuration())
        }
    }

18.0.0

This is not a react-native version. Please update your issue description

I also have the same problem
Please help me!!

error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup.
Error: Command failed: gradlew.bat app:installDebug -PreactNativeDevServerPort=8081
e: D:\dev\ReactNative\app_mobile_eu-source_new_110522\node_modules\react-native-navigation\lib\android\app\src\main\java\com\reactnativenavigation\views\element\animators\MatrixAnimator.kt: (21, 21): Type mismatch: inferred type is ScalingUtils.ScaleType? but ScalingUtils.ScaleType was expected
e: D:\dev\ReactNative\app_mobile_eu-source_new_110522\node_modules\react-native-navigation\lib\android\app\src\main\java\com\reactnativenavigation\views\element\animators\MatrixAnimator.kt: (22, 21): Type mismatch: inferred type is ScalingUtils.ScaleType? but ScalingUtils.ScaleType was expected

react-native info

System:
OS: Windows 10 10.0.19043
CPU: (12) x64 11th Gen Intel(R) Core(TM) i5-11400 @ 2.60GHz
Memory: 2.60 GB / 15.81 GB
Binaries:
Node: 17.9.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.4 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 8.5.5 - C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK: Not Found
Windows SDK: Not Found
IDEs:
Android Studio: Version     2<IP_ADDRESS> AI-211.7628.21.2111.8309675
Visual Studio: Not Found
Languages:
Java: 1.8.0_211 - C:\Program Files\Java\jdk1.8.0_211\bin\javac.EXE
npmPackages:
@react-native-community/cli: Not Found
react: 16.11.0 => 16.11.0
react-native: ^0.68.2 => 0.68.2
react-native-windows: Not Found
npmGlobalPackages:
react-native: Not Found

Thanks!!!

As a temporary workaround, you can delete the question mark at line 53 and 57 of the "node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/views/element/animators/ReactImageMatrixAnimator.kt"

Any body fix it?

I am facing the same issue here.

same issue on react 0.63.3

same issue on 0.64.1


Loading indicator while navigating in webview

Add some kind of indicator of loading when we move from one page to another in a webview.
Example: When one logs in (especially through third party auth) or logs out, add an indication that the request for logging in or logging out has taken place and that the next webpage is loading.
This can be added just like a browser like Chrome shows loading indicator by changing the reload button when a page is loading.
Discussion can be found here.

@zulipbot label "Type: Enhancement"

@zulipbot claim

While it's easy to handle the logout case, I'm not sure of how to take care of all requests that should prompt a spinner to come up. As indicated here, we could either just check for GitHub/Google logins by keeping an eye on all network requests being made, or we could define a list of certain operations that do not require a spinner in the webview (or a loading icon in the sidebar, as suggested by @abhigyank) and then display an indicator for everything else.
I think this needs a little more discussion for a good implementation.

I'd also like to add that I'm not sure if a spinner is the best way to show progress here. I think GitHub's approach is one we could borrow here: display some non-invasive progress line at the top of the webview. This would make our work (as listed above) easier as well because we won't have to maintain a list of operations that do not require a progress list (even if it's a message being sent, which requires a network request, the indicator is pretty standard in apps like iMessage).
The only network request I can think of where a progress line would be unnecessary is the downloading of profile images. I believe we can disqualify those easily.
Since this is a design-related issue, I'd like some suggestions here. @rishig what would you suggest?

I think we do want an infinite loading indicator, rather than a progress bar, since progress bars are often a lot of work to get right.
Just tried this out, and even on pretty good internet I can see that e.g. clicking on "Log in with Google" is slow enough that you're tempted to click again. For buttons like that I think the right solution is to add the loading indicator in the button itself.
On screens where there isn't a button we control, I think either using our loading screen indicator (the green dots) or putting a loading indicator on the realm icon could both make sense.

(And agreed putting the loading indicator on the google button sounds like a webapp project.)

For buttons like that I think the right solution can be to add a loading indicator in the button itself.

Yeah, that'd solve the problem.

On screens where there isn't a button we control, I think either using our loading screen indicator (the green dots) or putting a loading indicator on the realm icon could both make sense.

Hasn't that already been addressed though? I think @abhigyank's main concern was the login flow, and if this needs to be taken up on the webapp side, then there's not much else for us to do here.

@rishig @abhigyank please let me know how to go ahead with solving this problem - it is a pretty disconcerting bug. If you think that there's nothing else to be done on the desktop app, should I abandon the issue here and raise it in the webapp repo?

yeah, that sounds like a good plan. Seems like it shouldn't be a hard fix. Thanks for keeping track of this!

I think the putting a loading indicator on the google and other auth buttons could be on the webapp. But I guess the the indication would be limited to the buttons then. What happens when you click on login in the Google Auth page (It feels stuck/hang after entering credentials on Google/Github) ? We can't control that and other pages. Plus there is the logout too (that is not much of a use-case I guess). So I suppose, a desktop centric minimal "loading" indication would be good.

We can't control that and other pages.

Hmm, I think you're right. I ignored the login flow after the buttons on our webapp.
Okay, I'll read about how browsers identify when to show the loading icon (they don't show one when I send a message here, for example, even though it's a network request), and I'll write that into our sidebar icon.
Thanks for the help!

Opened a PR that should fix this issue.


UNSIGNED-PAYLOAD sent for Signature Version 4 PUT

What happened:
Attempting to write a file the following header is being set which results in an error from our s3 service
x-amz-content-sha256:UNSIGNED-PAYLOAD
botocore.exceptions.ClientError: An error occurred (InvalidDigest) when calling the PutObject operation: StorageFabric: UNSIGNED-PAYLOAD PUT is not allowed
What you expected to happen:
The body to be signed. I have set  "payload_signing_enabled"
Minimal Complete Verifiable Example:
   client_kwargs = dict(endpoint_url='https://object-uat-na.s3:8443',
                                    verify='ROOTCA.cer',
                                    region_name='na')

     s3_additional_kwargs =   {'addressing_style': 'path',
                                               "payload_signing_enabled": True,
                                               'signature_version':'s3v4'}

     s3 = s3fs.S3FileSystem(anon=False,
                                          key=access_id,
                                          secret=secret_key,
                                          client_kwargs=client_kwargs,
                                          s3_additional_kwargs=s3_additional_kwargs)

     file_path = '{}/xxx'.format(bucket)
     with s3.open(file_path, 'wb') as f:
         f.write(b'aaaaa')

Anything else we need to know?:
log output
2020-10-08 16:19:36,777 DEBUG s3fs CALL: put_object - ({'addressing_style': 'path', 'payload_signing_enabled': True, 'signature_version': 's3v4', 'cache_options': None},) - {'Key': 'xxx',
'Bucket': 'g0h2iz9h-mercurytest'}
2020-10-08 16:19:36,777 DEBUG botocore.hooks Event before-parameter-build.s3.PutObject: calling handler <function validate_ascii_metadata at 0x0390D930>
2020-10-08 16:19:36,778 DEBUG botocore.hooks Event before-parameter-build.s3.PutObject: calling handler <function sse_md5 at 0x0390D348>
2020-10-08 16:19:36,778 DEBUG botocore.hooks Event before-parameter-build.s3.PutObject: calling handler <function convert_body_to_file_like_object at 0x0390DDB0>
2020-10-08 16:19:36,778 DEBUG botocore.hooks Event before-parameter-build.s3.PutObject: calling handler <function validate_bucket_name at 0x0390D300>
2020-10-08 16:19:36,778 DEBUG botocore.hooks Event before-parameter-build.s3.PutObject: calling handler <bound method S3RegionRedirector.redirect_from_cache of <botocore.utils.S3RegionRedi
rector object at 0x049EA150>>
2020-10-08 16:19:36,778 DEBUG botocore.hooks Event before-parameter-build.s3.PutObject: calling handler <bound method S3ArnParamHandler.handle_arn of <botocore.utils.S3ArnParamHandler obje
ct at 0x04B642D0>>
2020-10-08 16:19:36,779 DEBUG botocore.hooks Event before-parameter-build.s3.PutObject: calling handler <function generate_idempotent_uuid at 0x0390D228>
2020-10-08 16:19:36,779 DEBUG botocore.hooks Event before-call.s3.PutObject: calling handler <function conditionally_calculate_md5 at 0x037B09C0>
2020-10-08 16:19:36,780 DEBUG botocore.hooks Event before-call.s3.PutObject: calling handler <function add_expect_header at 0x0390D4B0>
2020-10-08 16:19:36,780 DEBUG botocore.handlers Adding expect 100 continue header to request.
2020-10-08 16:19:36,780 DEBUG botocore.hooks Event before-call.s3.PutObject: calling handler <bound method S3RegionRedirector.set_request_url of <botocore.utils.S3RegionRedirector object a
t 0x049EA150>>
2020-10-08 16:19:36,780 DEBUG botocore.hooks Event before-call.s3.PutObject: calling handler <function inject_api_version_header_if_needed at 0x0390DE40>
2020-10-08 16:19:36,780 DEBUG botocore.endpoint Making request for OperationModel(name=PutObject) with params: {'url_path': '/g0h2iz9h-mercurytest/xxx', 'query_string': {}, 'method': 'PUT'
, 'headers': {'User-Agent': 'Botocore/1.18.8 Python/3.6.4 Windows/7', 'Content-MD5': 'WU+AOzgKQTlu1j3KOVA1Qg==', 'Expect': '100-continue'}, 'body': <_io.BytesIO object at 0x04B6EC30>, 'url
': 'https://object-uat-na.s3.net:8443/g0h2iz9h-mercurytest/xxx', 'context': {'client_region': 'na', 'client_config': <botocore.config.Config object at 0x049CCEF0>, 'has_streaming_inp
ut': True, 'auth_type': None, 'signing': {'bucket': 'g0h2iz9h-mercurytest'}}}
2020-10-08 16:19:36,781 DEBUG botocore.hooks Event request-created.s3.PutObject: calling handler <bound method RequestSigner.handler of <botocore.signers.RequestSigner object at 0x049CCE70
>>
2020-10-08 16:19:36,781 DEBUG botocore.hooks Event choose-signer.s3.PutObject: calling handler <function set_operation_specific_signer at 0x0390D198>
2020-10-08 16:19:36,782 DEBUG botocore.hooks Event before-sign.s3.PutObject: calling handler <bound method S3EndpointSetter.set_endpoint of <botocore.utils.S3EndpointSetter object at 0x04B
64310>>
2020-10-08 16:19:36,782 DEBUG botocore.utils Using S3 path style addressing.
2020-10-08 16:19:36,782 DEBUG botocore.auth Calculating signature using v4 auth.
2020-10-08 16:19:36,782 DEBUG botocore.auth CanonicalRequest:
PUT
/g0h2iz9h-mercurytest/xxx

content-md5:WU+AOzgKQTlu1j3KOVA1Qg==
host:object-uat-na.s3.net:8443
x-amz-content-sha256:UNSIGNED-PAYLOAD
x-amz-date:20201008T151936Z

content-md5;host;x-amz-content-sha256;x-amz-date
UNSIGNED-PAYLOAD
2020-10-08 16:19:36,784 DEBUG botocore.auth StringToSign:
AWS4-HMAC-SHA256
20201008T151936Z
20201008/na/s3/aws4_request
b9d0e532e9c239be67c69192d185159e5a4ca95680422f78997de7c234b9e6e1
2020-10-08 16:19:36,785 DEBUG botocore.auth Signature:
8b4f1024b553a2b35e9c2761e98ceee8b8cbb3a80923cca884064b3ab6101c5e
2020-10-08 16:19:36,785 DEBUG botocore.endpoint Sending http request: <AWSPreparedRequest stream_output=False, method=PUT, url=https://object-uat-na.s3.net:8443/g0h2iz9h-mercurytest/xxx, headers={'User-Agent': b'Botocore/1.18.8 Python/3.6.4 Windows/7', 'Content-MD5': b'WU+AOzgKQTlu1j3KOVA1Qg==', 'Expect': b'100-continue', 'X-Amz-Date': b'20201008T151936Z', 'X-Amz-Content-SHA256': b'UNSIGNED-PAYLOAD', 'Authorization': b'AWS4-HMAC-SHA256 Credential=8841faa493c48a31868c/20201008/na/s3/aws4_request, SignedHeaders=content-md5;host;x-amz-content-sha256;x-amz-date, Signature=8b4f1024b553a2b35e9c2761e98ceee8b8cbb3a80923cca884064b3ab6101c5e', 'Content-Length': '5'}>
2020-10-08 16:19:36,787 DEBUG urllib3.connectionpool Starting new HTTPS connection (1): object-uat-na.s3.net:8443
2020-10-08 16:19:37,035 DEBUG botocore.awsrequest Waiting for 100 Continue response.
2020-10-08 16:19:37,114 DEBUG botocore.awsrequest 100 Continue response seen, now sending request body.
2020-10-08 16:19:37,192 DEBUG urllib3.connectionpool https://object-uat-na.s3.net:8443 "PUT /g0h2iz9h-mercurytest/xxx HTTP/1.1" 400 248
2020-10-08 16:19:37,193 DEBUG botocore.parsers Response headers: {'Server': 'storagefabric/3.3.0', 'Date': 'Thu, 08 Oct 2020 15:19:36 GMT', 'Content-Type': 'application/xml', 'Content-Length': '248', 'Connection': 'close'}
2020-10-08 16:19:37,193 DEBUG botocore.parsers Response body:
b'<?xml version="1.0" encoding="UTF-8"?><Error>InvalidDigest<Message>StorageFabric: UNSIGNED-PAYLOAD PUT is not allowed</Message><Resource></Resource><RequestId>9057d9cf0fa84024f1e87d50f260704c</RequestId><HostId>unknown</HostId></Error>'
2020-10-08 16:19:37,197 DEBUG botocore.hooks Event needs-retry.s3.PutObject: calling handler <botocore.retryhandler.RetryHandler object at 0x049EA130>
2020-10-08 16:19:37,197 DEBUG botocore.retryhandler No retry needed.
2020-10-08 16:19:37,197 DEBUG botocore.hooks Event needs-retry.s3.PutObject: calling handler <bound method S3RegionRedirector.redirect_from_error of <botocore.utils.S3RegionRedirector object at 0x049EA150>>
Traceback (most recent call last):
  File "mercury.py", line 55, in <module>
    write_file('g0h2iz9h-mercurytest', creds['access_key'], creds['secret_key'])
  File "mercury.py", line 44, in write_file
    f.write(b'aaaaa')
  File "C:\FAST\Python\3.6.4\lib\site-packages\fsspec\spec.py", line 1504, in __exit__
    self.close()
  File "C:\FAST\Python\3.6.4\lib\site-packages\fsspec\spec.py", line 1472, in close
    self.flush(force=True)
  File "C:\FAST\Python\3.6.4\lib\site-packages\fsspec\spec.py", line 1345, in flush
    if self._upload_chunk(final=force) is not False:
  File "C:\FAST\Python\3.6.4\lib\site-packages\s3fs\core.py", line 1252, in _upload_chunk
    self.commit()
  File "C:\FAST\Python\3.6.4\lib\site-packages\s3fs\core.py", line 1269, in commit
    Key=self.key, Bucket=self.bucket, Body=data, **self.kwargs
  File "C:\FAST\Python\3.6.4\lib\site-packages\s3fs\core.py", line 1131, in _call_s3
    **kwargs)
  File "C:\FAST\Python\3.6.4\lib\site-packages\s3fs\core.py", line 200, in _call_s3
    return method(**additional_kwargs)
  File "C:\FAST\Python\3.6.4\lib\site-packages\botocore\client.py", line 337, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "C:\FAST\Python\3.6.4\lib\site-packages\botocore\client.py", line 656, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (InvalidDigest) when calling the PutObject operation: StorageFabric: UNSIGNED-PAYLOAD PUT is not allowed

Environment:

Dask version:
s3fs (0.4.2)
boto3 (1.15.8)
botocore (1.18.8)
fsspec (0.8.3)
Python version: 3.6.4
Operating System: win
Install method (conda, pip, source): pip

Wow, that is quite a log. It certainly mentions the addressing and signing, so I don't really know what might be going on. Do you have examples of this kind of call with base botocore?

Here's a similar one with just boto
2020-10-07 16:58:42,023 DEBUG botocore.client Registering retry handlers for service: s3
2020-10-07 16:58:42,024 DEBUG botocore.hooks Event before-parameter-build.s3.PutObject: calling handler <function validate_ascii_metadata at 0x037ED8E8>
2020-10-07 16:58:42,024 DEBUG botocore.hooks Event before-parameter-build.s3.PutObject: calling handler <function sse_md5 at 0x037ED300>
2020-10-07 16:58:42,025 DEBUG botocore.hooks Event before-parameter-build.s3.PutObject: calling handler <function convert_body_to_file_like_object at 0x037EDD68>
2020-10-07 16:58:42,025 DEBUG botocore.hooks Event before-parameter-build.s3.PutObject: calling handler <function validate_bucket_name at 0x037ED2B8>
2020-10-07 16:58:42,025 DEBUG botocore.hooks Event before-parameter-build.s3.PutObject: calling handler <bound method S3RegionRedirector.redirect_from_cache of <botocore.utils.S3RegionRedirector object at 0x044D56B0>>
2020-10-07 16:58:42,025 DEBUG botocore.hooks Event before-parameter-build.s3.PutObject: calling handler <bound method S3ArnParamHandler.handle_arn of <botocore.utils.S3ArnParamHandler object at 0x044FB770>>
2020-10-07 16:58:42,026 DEBUG botocore.hooks Event before-parameter-build.s3.PutObject: calling handler <function generate_idempotent_uuid at 0x037ED1E0>
2020-10-07 16:58:42,027 DEBUG botocore.hooks Event before-call.s3.PutObject: calling handler <function conditionally_calculate_md5 at 0x03661978>
2020-10-07 16:58:42,027 DEBUG botocore.hooks Event before-call.s3.PutObject: calling handler <function add_expect_header at 0x037ED468>
2020-10-07 16:58:42,027 DEBUG botocore.handlers Adding expect 100 continue header to request.
2020-10-07 16:58:42,027 DEBUG botocore.hooks Event before-call.s3.PutObject: calling handler <bound method S3RegionRedirector.set_request_url of <botocore.utils.S3RegionRedirector object at 0x044D56B0>>
2020-10-07 16:58:42,028 DEBUG botocore.hooks Event before-call.s3.PutObject: calling handler <function inject_api_version_header_if_needed at 0x037EDDF8>
2020-10-07 16:58:42,028 DEBUG botocore.endpoint Making request for OperationModel(name=PutObject) with params: {'url_path': '/g0h2iz9h-mercurytest/hello.txt', 'query_string': {}, 'method': 'PUT', 'headers': {'User-Agent': 'Boto3/1.15.8 Python/3.6.4 Windows/7 Botocore/1.18.8', 'Content-MD5': '7Qdih1MuhjZehB6Sv8UNjA==', 'Expect': '100-continue'}, 'body': <_io.BytesIO object at 0x04506B10>, 'url': 'https://object-uat-na.s3.net:8443/g0h2iz9h-mercurytest/hello.txt', 'context': {'client_region': 'na', 'client_config': <botocore.config.Config object at 0x043F0670>, 'has_streaming_input': True, 'auth_type': None, 'signing': {'bucket': 'g0h2iz9h-mercurytest'}}}
2020-10-07 16:58:42,029 DEBUG botocore.hooks Event request-created.s3.PutObject: calling handler <bound method RequestSigner.handler of <botocore.signers.RequestSigner object at 0x043F0AD0>>
2020-10-07 16:58:42,029 DEBUG botocore.hooks Event choose-signer.s3.PutObject: calling handler <function set_operation_specific_signer at 0x037ED150>
2020-10-07 16:58:42,030 DEBUG botocore.hooks Event before-sign.s3.PutObject: calling handler <bound method S3EndpointSetter.set_endpoint of <botocore.utils.S3EndpointSetter object at 0x044FB7B0>>
2020-10-07 16:58:42,030 DEBUG botocore.utils Using S3 path style addressing.
2020-10-07 16:58:42,030 DEBUG botocore.auth Calculating signature using v4 auth.
2020-10-07 16:58:42,031 DEBUG botocore.auth CanonicalRequest:
PUT
/g0h2iz9h-mercurytest/hello.txt

content-md5:7Qdih1MuhjZehB6Sv8UNjA==
host:object-uat-na.s3.net:8443
x-amz-content-sha256:7f83b1657ff1fc53b92dc18148a1d65dfc2d4b1fa3d677284addd200126d9069
x-amz-date:20201007T155842Z

content-md5;host;x-amz-content-sha256;x-amz-date
7f83b1657ff1fc53b92dc18148a1d65dfc2d4b1fa3d677284addd200126d9069
2020-10-07 16:58:42,032 DEBUG botocore.auth StringToSign:
AWS4-HMAC-SHA256
20201007T155842Z
20201007/na/s3/aws4_request
9ef8f534e892af68609f17b3ba471e62d74c045f0e674c80dcb3d2fb0fca7213
2020-10-07 16:58:42,033 DEBUG botocore.auth Signature:
ee73d7245dae24cbcd90533b385eb6150f4b1b7823fa8bd6137a02cced5f5e35
2020-10-07 16:58:42,033 DEBUG botocore.endpoint Sending http request: <AWSPreparedRequest stream_output=False, method=PUT, url=https://object-uat-na.s3.net:8443/g0h2iz9h-mercurytest/hello.txt, headers={'User-Agent': b'Boto3/1.15.8 Python/3.6.4 Windows/7 Botocore/1.18.8', 'Content-MD5': b'7Qdih1MuhjZehB6Sv8UNjA==', 'Expect': b'100-continue', 'X-Amz-Date': b'20201007T155842Z', 'X-Amz-Content-SHA256': b'7f83b1657ff1fc53b92dc18148a1d65dfc2d4b1fa3d677284addd200126d9069', 'Authorization': b'AWS4-HMAC-SHA256 Credential=8d9eae9ebadeec44101d/20201007/na/s3/aws4_request, SignedHeaders=content-md5;host;x-amz-content-sha256;x-amz-date, Signature=ee73d7245dae24cbcd90533b385eb6150f4b1b7823fa8bd6137a02cced5f5e35', 'Content-Length': '12'}>
2020-10-07 16:58:42,035 DEBUG urllib3.connectionpool Starting new HTTPS connection (1): object-uat-na.s3.net:8443
2020-10-07 16:58:42,293 DEBUG botocore.awsrequest Waiting for 100 Continue response.
2020-10-07 16:58:42,372 DEBUG botocore.awsrequest 100 Continue response seen, now sending request body.
2020-10-07 16:58:42,458 DEBUG urllib3.connectionpool https://object-uat-na.s3.net:8443 "PUT /g0h2iz9h-mercurytest/hello.txt HTTP/1.1" 200 0
2020-10-07 16:58:42,458 DEBUG botocore.parsers Response headers: {'Server': 'storagefabric/3.3.0', 'Date': 'Wed, 07 Oct 2020 15:58:42 GMT', 'Content-Length': '0', 'Connection': 'keep-alive', 'x-amz-request-id': '1602086322392159', 'x-amz-id-2': '12099823', 'ETag': '"ed076287532e86365e841e92bfc50d8c"'}
2020-10-07 16:58:42,458 DEBUG botocore.parsers Response body:
b''
2020-10-07 16:58:42,459 DEBUG botocore.hooks Event needs-retry.s3.PutObject: calling handler <botocore.retryhandler.RetryHandler object at 0x044D55D0>
2020-10-07 16:58:42,459 DEBUG botocore.retryhandler No retry needed.
2020-10-07 16:58:42,460 DEBUG botocore.hooks Event needs-retry.s3.PutObject: calling handler <bound method S3RegionRedirector.redirect_from_error of <botocore.utils.S3RegionRedirector object at 0x044D56B0>>

What parameters did you pass to boto(core?) for the working version?

clientconfig = Config(s3={'addressing_style': 'path', "payload_signing_enabled": True},
                                          signature_version='s3v4',
                                          region_name='na')
s3client = boto3.client('s3', endpoint_url='https://object-uat-na.s3.net:8443',
                                     verify='ROOTCA.cer', aws_access_key_id=access_id,
                                     aws_secret_access_key=secret_key, config=clientconfig)
key_name = 'hello.txt'
s3client.put_object(Body=b"Hello World!", Bucket=bucket, Key=key_name)

I think "payload_signing_enabled" should go into config_kwargs under "s3", maybe some of the others, just like you have with the boto3 example?

Thanks that worked. Your a star.

Hurray!

Hey
Could any one give me java example to set the payload_signing_enabled = true
I'm using latest java aws sdk v2 2.20.90
while uploading the object using putobject() method getting below error
software.amazon.awssdk.services.s3.model.S3Exception: StorageFabric : UNSIGNED-PAYLOAD PUT is not allowed (Service: S3 , Status Code: 400, Request ID: )

@n1kiran , this is a python library - perhaps you have come to the wrong place?


Update CONTRIBUTING.md

⚛👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.

Copy the correct template for your contribution

🐛 Are you fixing a bug? Copy the template from https://bit.ly/atom-bugfix
📈 Are you improving performance? Copy the template from https://bit.ly/atom-perf
📝 Are you updating documentation? Copy the template from https://bit.ly/atom-docs
💻 Are you changing functionality? Copy the template from https://bit.ly/atom-behavior

Replace this text with the contents of the template
Fill in all sections of the template
Click "Create pull request"

Thank you for contributing!
We require the issue template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests. Please open a new issue and fill out the template for us.
Thanks for understanding and meeting us half way :grinning:


add version 2.4.7

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.
Here's what I've got...
For recipe/meta.yaml:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [26, 32, 33]
noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

For recipe/meta.yaml:

No valid build backend found for Python recipe for package pymilvus using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.


Test without typing_extensions

Could you explain the purpose of this change?

We have conditional imports on typing_extensions, and it clarifies that the project will in fact run without it installed. I wasrunning into a problem where something inside of a lambda is importing typing_extensions and hasn't declared it as a dependency, and wanted to make sure it wasn't this.
It typically shows up as a dev dependency so it's hard to verify without explicitly uninstalling it.


Update README.md

Fix boilerplate title
Add a tiny description
Remove GitHub actions badges (there are no actions configured)
Fix the composer badges with correct package namespace

Hahaha thanks @stayallive 🙌


Satellite map

This branch adds functionality for creating a "Satellite map" of the generated world. This is currently an option, default false, toggled on with the --sat command when running.
Additional work may need to be done in selecting more appropriate biome colors and tuning the algorithm to display elevation / shading, to get a more realistic result.
Some sample outputs are attached here:

Looks pretty nice. It probably needs to be able to identify ocean that is cold enough to freeze and color that as well but beyond that it is probably just a matter of tweaking values.

Thank you so much for sending this patch: it looks great! Now shadows are very beatiful and contribute a lot to make the map look real.
I just think there were a few changes in the master branch since you created yours so now I see some changes which I think are unrelated to you patch. Probably you need to rebase your branch on master. If you are not very familiar with git I would glad to do that for you.
Thanks a lot!

This is my first pull request. I'd be delighted to have you rebase with master; I'd also love it if you can point me to how I should be doing this! I tried rebasing it myself but it still says I'm up to date.

Yeah, I tried to rebase it but it seems to be already up to date. Looking at the commits is like the first one ("Add 'satellite map' - a way to visualize the world as it may...") is the one containing all these differences.
Git is very mysterious from time to time...
Normally I would expect a rebase to fix this, but in this case I would fix it manually. Let me see what I can do.

I think I know the issue then. I was originally working on a cloned branch direct from your repo, but I had to manually copy my changed files after I officially forked this repo -- those changes from master must have happened then since I didn't try to pull from master before I copied.
I can probably sort it out myself and make another pull request if you can't manually fix it easily.

Ok, I updated the first commit and it is now in the branch pangal-satellite_map on this repository. If you want you can take it in your branch and push it on your fork. This would automatically update the pull-request. If you need help with that let me know.
My role as one of the maintainer is helping taking the more bits out of the way so that contributors like you can focus on providing great features like this one :)

Just tried to do this - it's still showing some things I didn't change in the diff.

perhaps you have merged my branch while you should reset your branch to mine. This is because I "rewrote the history", so I changed the commits that were already part of your branch.
To do so you could for example to this:
# now the name "upstream" refer to this repository
git remote add upstream https://github.com/Mindwerks/worldengine.git
# copy the data from this repository on your computer
git fetch upstream
# move to the branch
git checkout satellite_map
# throw away all your stuff in the branch and make it exactly the same as the branch with
# the same name on this repository. Note that this change only data on your computer not on your
# forked repository
git reset --hard upstream/satellite_map
# now sends the data to your forked repository: the pull request is updated automatically
git push origin satellite_map -f

My first contribution was only a couple of weeks ago. I followed the guides on git to get started:
https://help.github.com/articles/fork-a-repo/
And it seems that worked out ok.
I guess I am still going to look over your code, even though things might be a bit messy right now?

I only breezed through the code, I don't have the time for a full check right now. And the regressions make it a bit hard to read anyway.
But: I love your results and your code.^^ Lots of comments, the code just looks tidy - this is a great point to start work for whoever might decide to do so.
(Of course that doesn't mean that I wouldn't want to see a couple small changes. Some I already mentioned. ;) )

Thanks for the feedback all!
I started from scratch and created an entirely new pull request - https://github.com/Mindwerks/worldengine/pull/181
I think it would be easier if we forget this one ever existed :)


Trains don't come out of depot when it says they will and PIDS time keeps going up. (Example: 45secs, 44secs, 43secs, 45secs...) (bug)

First Issue:
On the depot edit screen in the railway dashboard, when it hits 00:00:00, trains don't come out of the depot.
Second Issue:
PIDS time keeps going up. (example: 45secs, 44secs, 43secs, 45secs, etc, etc)

I fixed it by resizing the depot and turning 'Drivable Vehicle' off


RevEng: Allow customers to override the default templates

At the moment the SqlServer RevEng provider uses templates that are stored as resources within the assemblies of the EntityFramework.SqlServer.Design package.
We should have some mechanism by which a customer can override the default template and use a different one instead.
See also related issue #2415.

Fixed by #2598. See also #2415.