Add git-clang-format hook for

This would be a useful addition, allowing large projects to bring their codebase into compliance without large diffs.

this file is generated

@asottile would a similar change be accepted against the GH action workflow? Minimal overhead to add in the same repo since clang-format-wheel already ships with git-clang-format and clang-format-diff
On the subject, do hooks get the files as they exists in --to-ref when specified? Or do they get the files as they exist in the directory. Looks like it may be the latter based on source but I'm likely missing something.

it wouldn't work as written anyway. there's no shell involved to interpolate that value
plus I recommend always doing it in one go rather than potentially polluting every change with unrelated changes https://github.com/readme/guides/code-review

I realized it wouldn’t, which I intended to discuss in the draft PR here. Regarding pollution, I would have assumed squash & merge is acceptable, otherwise I would have offered to rebase before merge.
Ok, back to the main issue. Guess this would need need a helper script. clang-format-wheel doesn’t have anything to do with hooks so doesn’t seem like it belongs there. My own fork seems like a waste for a small 80-line interface wrapper. Where does it belong? Alternatively, where is a better place to discuss this?

no not this PR, doing incremental formatting is problematic in general
you also don't need it to be an external script, you could entry: bash -c '...' -- or if it's in just one repo you could keep your own ./scripts/whatever and override entry with that

Ah, thank you for the clarification. Normally I agree but the main use case is numpy, large unformatted codebase and the team thought running autoformat on the whole thing would be too disruptive to open PRs, and disliked the huge diff it would create in the middle of everything. So, incremental it is, I know numpy/scipy can’t be the only big codebase with that problem.
Will look into what you suggested, thanks. If I get it working I’ll just submit a docs pr against the original wheels repo.

I've tried this against 5MLOC+ codebases, incremental is kinda a disaster -- but if you believe you know better then by all means.  it's usually best to pull off the bandaid once, mark the commit as an ignored revision, and continue on into the future

I certainly don’t know better, but also not up to me. I plan to get something working now so I can at least contribute with my mind at ease, then bring up the total reformat in a year or so.
Thanks for all the help!


Token Number only allow numeric values

Thanks for the PR -- But, I think this will split text like 0x00g into two tokens: (i.e. 0x00: Number, g: Ident). It would probably be better to report an error instead.


Extraction not Perfect

Extraction of the captured image is not perfect, hardly any output is generated.
Any PR fixing this issue will be appreciated.

@Joe-Sin7h  can I take the PR, I have quite understood your problem.

@Prajwalprakash3722  yes, please feel free to make a PR fixing this bug.


Conflicts with YSF(0.3DL)

This happened everytime if I don't use YSF's static plugin,it is unavailable for 0.3DL.

----------
Loaded log file: "server_log.txt".
----------

SA-MP Dedicated Server
----------------------
v0.3.DL-R1, (C)2005-2018 SA-MP Team

[07:25:59] filterscripts = ""  (string)
[07:25:59]
[07:25:59] Server Plugins
[07:25:59] --------------
[07:25:59]  Loading plugin: crashdetect.so
[07:25:59]   CrashDetect plugin 4.19
[07:25:59]   Loaded.
[07:25:59]  Loading plugin: YSF.so
[07:25:59]
[07:25:59]  ===============================
[07:25:59]         YSF - kurta999's version R19-2 loaded
[07:25:59]    (c) 2008 Alex "Y_Less" Cole - (c) 2010 - 2016 kurta999
[07:25:59]     Server version: 0.3.DL R1
[07:25:59]     Operating System: Linux
[07:25:59]     Built on: Mar  9 2018 at 12:13:03
[07:25:59]  ===============================
[07:25:59]
[07:25:59]   Loaded.
[07:25:59]  Loading plugin: SKY.so
[07:25:59]   Loaded.
[07:25:59]  Loading plugin: mysql.so
[07:25:59]  >> plugin.mysql: R41-4 successfully loaded.
[07:25:59]   Loaded.
[07:25:59]  Loading plugin: sscanf.so
[07:25:59]

[07:25:59]  ===============================

[07:25:59]       sscanf plugin loaded.

[07:25:59]          Version:  2.8.2

[07:25:59]    (c) 2012 Alex "Y_Less" Cole

[07:25:59]  ===============================

[07:25:59]   Loaded.
[07:25:59]  Loading plugin: streamer.so
[07:25:59]

*** Streamer Plugin v2.9.3 by Incognito loaded ***

[07:25:59]   Loaded.
[07:25:59]  Loading plugin: irc.so
[07:25:59]

*** IRC Plugin v1.4.8 by Incognito loaded ***

[07:25:59]   Loaded.
[07:25:59]  Loading plugin: ctime.so
[07:25:59]   Loaded.
[07:25:59]  Loading plugin: DriftPointsCounter.so
[07:25:59]   Loaded.
[07:25:59]  Loading plugin: ColAndreas_static.so
[07:25:59] *********************
[07:25:59] ** Created By:     **
[07:25:59] ** [uL]Chris42O    **
[07:25:59] ** [uL]Slice       **
[07:25:59] ** [uL]Pottus      **
[07:25:59] *********************
[07:26:05] Loaded collision data.
[07:26:05] *********************
[07:26:05]   ColAndreas Loaded
[07:26:05]    v1.4.0
[07:26:05] *********************
[07:26:05]   Loaded.
[07:26:05]  Loading plugin: FCNPC.so
[07:26:05]
[07:26:05] -------------------------------------------------
[07:26:05]      FCNPC - Fully Controllable NPC v1.8.2
[07:26:05]          GNU/Linux SA-MP Unknown
[07:26:05]           Jan  8 2018 at 01:15:11
[07:26:05]
[07:26:05]   Author:       OrMisicL (2013 - 2015)
[07:26:05]   Continued by: ziggi (2016 - present)
[07:26:05]   Contributors: kurta999, Neutralneu
[07:26:05] -------------------------------------------------
[07:26:05]
[07:26:05] Loading...
[07:26:05]   Loaded.
[07:26:05]  Loading plugin: log-plugin.so
[07:26:05]  >> plugin.log: v0.4 successfully loaded.
[07:26:05]   Loaded.
[07:26:05]  Loading plugin: pawn-memory.so
[07:26:05] ========================
[07:26:05] = Memory access plugin =
[07:26:05] =       Made by BigETI =
[07:26:05] = Loaded!              =
[07:26:05] ========================
[07:26:05]   Loaded.
[07:26:05]  Loading plugin: pawnraknet.so
[07:26:05] Pawn.RakNet plugin v1.1.0 by urShadow loaded
[07:26:05]   Loaded.
[07:26:05]  Loaded 14 plugins.

[07:26:05]
[07:26:05] Filterscripts
[07:26:05] ---------------
[07:26:05]   Loaded 0 filterscripts.

[07:26:05]   Filterscript '../scriptfiles/callbackfix.amx' loaded.
[07:26:05]
[07:26:05]
[07:26:05]
[07:26:05]  =======================================
[07:26:05]  |                                     |
[07:26:05]  |        YSI version 4.00.0001        |
[07:26:05]  |        By Alex "Y_Less" Cole        |
[07:26:05]  |                                     |
[07:26:05]  =======================================
[07:26:05]
[07:26:18]
[07:26:18] --------------------------------------
[07:26:18]  Anticheat Nex-AC loaded!
[07:26:18]  Anticheat version: 1.9.20
[07:26:18]  Author: Nexius
[07:26:18] --------------------------------------

[07:26:18] [Nex-AC] The anticheat version is not compatible with the current SA-MP Server
[07:26:18] Setting server password to: "133773316996"
[07:26:18] Loading Map.
[07:26:18] Loaded Map.
[07:26:18] *** >>> Garages loaded: 0 (successful: 0, failed: 0)
[07:26:18] (null)
[07:26:18] [ADM] Info: Load 3DTryg v4.6.1 for SA:MP 0.3.7 by Abyss Morgan

----------
Loaded log file: "server_log.txt".
----------

SA-MP Dedicated Server
----------------------
v0.3.DL-R1, (C)2005-2018 SA-MP Team

[07:32:01] filterscripts = ""  (string)
[07:32:01]
[07:32:01] Server Plugins
[07:32:01] --------------
[07:32:01]  Loading plugin: crashdetect.so
[07:32:01]   CrashDetect plugin 4.19
[07:32:01]   Loaded.
[07:32:01]  Loading plugin: YSF.so
[07:32:01]
[07:32:01]  ===============================
[07:32:01]         YSF - kurta999's version R19-2 loaded
[07:32:01]    (c) 2008 Alex "Y_Less" Cole - (c) 2010 - 2016 kurta999
[07:32:01]     Server version: 0.3.DL R1
[07:32:01]     Operating System: Linux
[07:32:01]     Built on: Mar  9 2018 at 12:13:03
[07:32:01]  ===============================
[07:32:01]
[07:32:01]   Loaded.
[07:32:01]  Loading plugin: SKY.so
[07:32:01]   Loaded.
[07:32:01]  Loading plugin: mysql.so
[07:32:01]  >> plugin.mysql: R41-4 successfully loaded.
[07:32:01]   Loaded.
[07:32:01]  Loading plugin: sscanf.so
[07:32:01]

[07:32:01]  ===============================

[07:32:01]       sscanf plugin loaded.

[07:32:01]          Version:  2.8.2

[07:32:01]    (c) 2012 Alex "Y_Less" Cole

[07:32:01]  ===============================

[07:32:01]   Loaded.
[07:32:01]  Loading plugin: streamer.so
[07:32:01]

*** Streamer Plugin v2.9.3 by Incognito loaded ***

[07:32:01]   Loaded.
[07:32:01]  Loading plugin: irc.so
[07:32:01]

*** IRC Plugin v1.4.8 by Incognito loaded ***

[07:32:01]   Loaded.
[07:32:01]  Loading plugin: ctime.so
[07:32:01]   Loaded.
[07:32:01]  Loading plugin: DriftPointsCounter.so
[07:32:01]   Loaded.
[07:32:01]  Loading plugin: ColAndreas_static.so
[07:32:01] *********************
[07:32:01] ** Created By:     **
[07:32:01] ** [uL]Chris42O    **
[07:32:01] ** [uL]Slice       **
[07:32:01] ** [uL]Pottus      **
[07:32:01] *********************
[07:32:06] Loaded collision data.
[07:32:06] *********************
[07:32:06]   ColAndreas Loaded
[07:32:06]    v1.4.0
[07:32:06] *********************
[07:32:06]   Loaded.
[07:32:06]  Loading plugin: FCNPC.so
[07:32:06]
[07:32:06] -------------------------------------------------
[07:32:06]      FCNPC - Fully Controllable NPC v1.8.2
[07:32:06]          GNU/Linux SA-MP 0.3.DL R1
[07:32:06]           Jan 30 2018 at 20:05:20
[07:32:06]
[07:32:06]   Author:       OrMisicL (2013 - 2015)
[07:32:06]   Continued by: ziggi (2016 - present)
[07:32:06]   Contributors: kurta999, Neutralneu
[07:32:06] -------------------------------------------------
[07:32:06]
[07:32:06] Loading...
[07:32:06]   Loaded.
[07:32:06]  Loading plugin: log-plugin.so
[07:32:06]  >> plugin.log: v0.4 successfully loaded.
[07:32:06]   Loaded.
[07:32:06]  Loading plugin: pawn-memory.so
[07:32:06] ========================
[07:32:06] = Memory access plugin =
[07:32:06] =       Made by BigETI =
[07:32:06] = Loaded!              =
[07:32:06] ========================
[07:32:06]   Loaded.
[07:32:06]  Loading plugin: pawnraknet.so
[07:32:06] Pawn.RakNet plugin v1.1.0 by urShadow loaded
[07:32:06]   Loaded.
[07:32:06]  Loaded 14 plugins.

[07:32:06]
[07:32:06] Filterscripts
[07:32:06] ---------------
[07:32:06]   Loaded 0 filterscripts.

[07:32:06]
Functions:
[07:32:06]   FUNC_CPlayerPool__DeletePlayer: 0x80dc0b0
[07:32:06]   FUNC_CPlayer__Kill: 0x80d5ac0
[07:32:06]   FUNC_CPlayer__EnterVehicle: 0x80d6a70
[07:32:06]   FUNC_CPlayer__ExitVehicle: 0x80d6bf0
[07:32:06]   FUNC_CPlayer__SpawnForWorld: 0x80d7870
[07:32:06]   FUNC_GetVehicleModelInfo: 0x80e14f0
[07:32:06]   FUNC_CConsole__GetIntVariable: 0x80a87d0
[07:32:06]   FUNC_ClientJoin_RPC: 0x80ba350
[07:32:06]
Pointers:
[07:32:06]   VAR_ServerAuthentication: 0x81b7d2c
[07:32:06]   VAR_NetVersion: 0xfde
[07:32:06]
Offsets:
[07:32:06]   OFFSET_RemoteSystemManager: 0x334
[07:32:06]   OFFSET_RemoteSystemSize: 0xc69
[07:32:06]   OFFSET_RemoteSystem__ConnectMode: 0xc62
[07:32:06]   OFFSET_RemoteSystem__Unknown: 0xc67
[07:32:06]   Filterscript '../scriptfiles/callbackfix.amx' loaded.
[07:32:06]
[07:32:06]
[07:32:06]
[07:32:06]  =======================================
[07:32:06]  |                                     |
[07:32:06]  |        YSI version 4.00.0001        |
[07:32:06]  |        By Alex "Y_Less" Cole        |
[07:32:06]  |                                     |
[07:32:06]  =======================================
[07:32:06]
[07:32:19]
[07:32:19] --------------------------------------
[07:32:19]  Anticheat Nex-AC loaded!
[07:32:19]  Anticheat version: 1.9.20
[07:32:19]  Author: Nexius
[07:32:19] --------------------------------------

[07:32:19] [Nex-AC] The anticheat version is not compatible with the current SA-MP Server
[07:32:19] Setting server password to: "133773316996"
[07:32:19] Loading Map.
[07:32:19] Loaded Map.
[07:32:19] *** >>> Garages loaded: 0 (successful: 0, failed: 0)
[07:32:19] (null)
[07:32:19] [ADM] Info: Load 3DTryg v4.6.1 for SA:MP 0.3.7 by Abyss Morgan

my server.cfg
plugins crashdetect.so YSF.so SKY.so mysql.so sscanf.so streamer.so irc.so ctime.so DriftPointsCounter.so ColAndreas_static.so FCNPC.so log-plugin.so pawn-memory.so pawnraknet.so

Can you check again with latest YSF and FCNPC?


Add username and password to URL on Basic Authentication

Is it possible to login using username and password on the URL ?

Please do not ask questions here.
For that refer to https://groups.google.com/forum/#!forum/search-guard
Github is a place only for reporting bugs or feature requests.
If you report a bug please include always the following informations:

Search Guard and Elasticsearch version
JVM version and operating system version
Number of nodes in your cluster
Description of the bug

These informations are optional but are very valueable and
typically would lead to get bugs fixed faster:

Steps to reproduce
Logfiles on DEBUG level
A failing unittest


Adding PowerBI Gateway Infra

https://github.com/ministryofjustice/data-platform/issues/2452
Builds out PowerBi Gateway Infrastructure in analytical-platform-data-production

Temporarily overriding static code analysis while PR is in draft.


Fix estimated delivery missing

Heyy, so this was a task to add estimated delivery to the main reward pledge page when shipping is not applicable. And then I got carried away hiding stack views that were creating extra spacing and ended up working with @maggieKSR to tidy that up.
The actual task:

Spacing updated between items and fulfillment area:

Just added updated shots - ended up just updating spacing on the fulfillment stack view when items are shown or hidden.


why compute fake_img two times?

lin 88 in train.py, why compute fake_img and fake_out again after g_loss.backward( )?

@njuhang  you need be familiar to GAN.


VersionBot: status event not surpressed by procbots/versionbot/no-checks label

Witnessed here in the logs:
https://github.com/resin-io/resin-image-maker/pull/52
22.02.17 16:30:11 [+0000] 2017-02-22T16:30:11.043Z: DEBUG - StatusChangeState: checking version for resin-io/resin-image-maker#52
22.02.17 16:30:11 [+0000] 2017-02-22T16:30:11.499Z: DEBUG - StatusChangeState: No valid 'Change-Type' tag found, failing last commit fo
r resin-io/resin-image-maker#52
22.02.17 16:30:23 [+0000] 2017-02-22T16:30:23.075Z: DEBUG - StatusChangeState: checking version for resin-io/resin-image-maker#52
22.02.17 16:30:23 [+0000] 2017-02-22T16:30:23.433Z: DEBUG - StatusChangeState: No valid 'Change-Type' tag found, failing last commit fo
r resin-io/resin-image-maker#52
22.02.17 16:31:26 [+0000] 2017-02-22T16:31:26.081Z: INFO - Dropping 'CheckForReadyMergeState' as not all trigger labels are present
22.02.17 16:31:33 [+0000] 2017-02-22T16:31:33.420Z: INFO - Dropping 'CheckForReadyMergeState' as not all trigger labels are present
22.02.17 16:31:43 [+0000] 2017-02-22T16:31:43.013Z: INFO - Dropping 'CheckForReadyMergeState' as not all trigger labels are present
22.02.17 16:31:43 [+0000] 2017-02-22T16:31:43.110Z: DEBUG - CheckVersionistCommitStatus: checking version for resin-io/resin-ui#456
22.02.17 16:33:52 [+0000] 2017-02-22T16:33:52.056Z: DEBUG - StatusChangeState: checking version for resin-io/resin-image-maker#52
22.02.17 16:33:52 [+0000] 2017-02-22T16:33:52.208Z: DEBUG - StatusChangeState: No valid 'Change-Type' tag found, failing last commit fo
r resin-io/resin-image-maker#52

Not sure this is true any longer, need to look.

This is actually still happening. @CameronDiver has a seen the issue (see this flowdock thread).


Resolve PT011 error code

Fixes #1342
Addsmatch checks to all the pytest.raises checks, so that error messages are checked.

close/reopen for RTD


Ability to configure find/search to be like gedit

Gedit 3 has the most convenient find feature I've ever used.

Ctrl-f brings up a very tiny input box in the top right which doesn't obscure any code.
Results are shown to you as you start typing, without having to hit enter.
Down/up arrows select the next/previous results.
Enter exits the search, leaving the current result selected.
Esc exits the search but puts you back where you started before searching.

I've managed to get down/up arrows working, but there doesn't seem to be a way to exit find and replace with anything other than hitting esc. Furthermore, recording the state before the search begins is beyond simple keymapping.
'.find-and-replace, .project-find, .project-find .results-view':
  'up': 'find-and-replace:show-previous'
  'down': 'find-and-replace:confirm'

Are these enter/esc actions something that could make it into the core find-and-replace?

This seems to be a duplicate of https://github.com/atom/find-and-replace/issues/367 and at least the "jump to first match on type" was implemented as an option in https://github.com/atom/find-and-replace/pull/427. If there is more that you are looking for, can you open a new issue on the find-and-replace package?


Removed adding the api server to the maap-py instantiation

Before the default code from the import MAAP libraries button in the upper left of the notebooks was

from maap.maap import MAAP
maap = MAAP(maap_host='api.dit.maap-project.org')

Now it is
from maap.maap import MAAP
maap = MAAP()

@marjo-luc Yes, sorry I should have mentioned that the new way that maap-py gets the API server is from the MAAP_API_HOST environment variable https://github.com/MAAP-Project/maap-py/commit/1887545b4faa03f4e3a6ffcf25e3b170894d3a75#diff-c1a2c82a724182ce2128aae8ec70568ece9d0d94009d2e4b7e6ceda7dfbcc877R30
It uses api.maap-project.org if that environment variable is not set


Correction for raw affiliation Universität Greifswald

Correction needed for raw affiliation Universität Greifswald
raw_affiliation_name: Universität Greifswald
new_rors: 00r1edq15
previous_rors:
works_examples: W4362430240;W4393672922;W4393706568;W4381187713;W4390945910;W4389194861
contact: 5e5dd07a8c1c9e30907ea3c2bdd68313:0168aa0621b46bbb2ce28c2dbfbff83f14b6c6bc4268 @ uni-greifswald.de

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


[docs] Make examples interactive

I can work on It. I would like to reuse this component
https://github.com/react-bootstrap/react-bootstrap/blob/master/docs/src/ReactPlayground.js

@skv-headless Any update on this? I don't think that it worse the effort.

Edit, there is https://github.com/FormidableLabs/component-playground that we could use. Still, what is the use case?

I think this isn't critical but it would be nice to have. Sometime's when you're new to a project it's fun to tinker a bit beyond the examples. Also, it might be useful in terms of reproducing issues. For example, if someone has an issue with how a component is working, we could ask them if they could reproduce it in component-playground on the doc site.

Codepen and JSFiddle both have a post API, which would let you push each example, but they would need a compiled version of each component (or the entire lib) hosted somewhere so that they (or it) could be included.

Mm, I think I like that route. I think supporting codepen / jsdfiddle could go a long way interms of better supporting this project here and on StackOverflow. Getting reproducible examples helps so much when pinpointing root cause of something.
I guess first step is making creating a webpack build of material-ui part of our build process. Maybe after we have that we can se if cdnjs would be willing to host it for us?

Could it not live be served from github pages?

Mm...yeah I don't see why that wouldn't work. That idea just reminded me on this option too: https://rawgit.com/

Interesting. And the compiled lib could still live in its own branch if it was desirable not to pollute main.


Blocking xplat node solution due to regedit package

Hello team,
We build an xplat solution in which we are using regedit as package. At runtime we are using regedit only for windows platform but it is since during build time on linux platform, regedit pacakge is throwing error as Not compatible with your operating system or architecture<EMAIL_ADDRESS>Because in node-regedit package.json
"os": [
"win32"
],
This is stopping us using regedit on a cross plat solution.

@Ajay-MS is this still relevant? if so let me know.


insertAfter how to?

Hello, I know this is not a bug or something it's just I don't know where to place the insertAfter and how to do it.
Actually, I have a problem that my uploader loads before an element that has some dynamic values, and my uploader is having empty values.
So I think inserAfter should solve this problem right?
Or there's any "action" to "refresh" the Ffilepond and re-read again the properties?
If insertAfter should solve this how I can use it?
I want to load it after a div that has id = monsid
Where should I create the insertAfter?
Can you bring me please an example using my following code:
My code looks like this:
FilePond.registerPlugin(
  		FilePondPluginFileEncode,
  		FilePondPluginFileValidateType,
  		FilePondPluginFileValidateSize,
  		FilePondPluginImageExifOrientation,
      	FilePondPluginImageCrop,
  		FilePondPluginImagePreview,
      	FilePondPluginImageResize,
  		FilePondPluginImageValidateSize,
      	FilePondPluginImageTransform
	);

	const inputElement = document.querySelector('input[type="file"]');
	const pond = FilePond.create( inputElement, {
      	allowFileSizeValidation: dynamic.allowfilesizevalidation,
      	maxFileSize: ''+dynamic.maxfilesize+'',
      	maxTotalFileSize: ''+dynamic.maxtotalfilesize+'',
      	labelMaxFileSizeExceeded: ''+dynamic.labelmaxfilesizeexceeded+'',
      	labelMaxFileSize: ''+dynamic.labelmaxfilesize+'',
      	labelTotalFileSizeExceeded: ''+dynamic.labeltotalfilesizeexceeded+'',
      	labelMaxTotalFileSize: ''+dynamic.labelmaxtotalfilesize+''
  });
FilePond.setOptions({
    server: {
        process: (fieldName, file, metadata, load, error, progress, abort) => {

            const upload = uploadcare.fileFrom('object', file);

            upload.progress((uploadInfo) => {
                // State of your upload gets updated.
                // The callback is invoked at least once with a current state,
                // right after assignment.
                // https://uploadcare.com/docs/api_reference/javascript/files_uploads/#upload-info
                progress(true, uploadInfo.uploadProgress, 1);

            });

            upload.done((fileInfo) => {
                // Upload has successfully completed and a file is ready.
                // https://uploadcare.com/docs/api_reference/javascript/files_uploads/#file-info
                load(fileInfo.uuid);

            })
            .fail((err, fileInfo) => {
                // Upload failed, or something else went wrong, a file is not ready.
                error(err);

            });

            return {
                abort: () => {

                    // https://uploadcare.com/docs/api_reference/javascript/files_uploads/#file-cancel-uploading
                    upload.cancel();

                    // Let FilePond know the request has been cancelled
                    abort();
                }
            };
        }
    }
});

Hello, I've noticed also when any dynamic value changes I.e: file size, it keeps stuck on the old value. How I can force a refresh?
Thanks.

I’m not sure what you mean with both comments can you try to provide a test case or improve the example code?

My question is quite simple, sorry if you didn't understand.
I have everything working pretty well, I'm using dynamic fields to maxsize. When the filepond uploader loads on the page gets the value of that input only when loading first time. When the value of the input changes it stills using the old value.
So my question is, how I can force filepond to update after x input is modified?
Thanks.

I’d youre writing this in vanilla JavaScript without using any frameworks you’ll have to listen for changes on your dynamic fields and re-assign the value to filepond properties.

So filepond does not have a refresh action to be called to do that?
Something like Filepond.refresh

No, and to be honest I'm not sure what you're looking for, this is basically how JavaScript functions, parameters are passed by value, see below:
var foo = 1;

// imagine bar is the FilePond options object
var bar = foo;

console.log(bar); // logs 1

// now you change your variable vlue
foo = 2;

console.log(bar); // still logs 1


[Inline class] Error in CFE when calling constant constructor of an inline-class

The following code produces an error in CFE
inline class  V<T> {
  final T id;
  const V(this.id);
}

const c = const V<int>(0); // Error: Static invocation is not a constant expression.

There should be no such error
Tested on Dart SDK version: 3.1.0-155.0.dev (dev) (Fri May 26 19:56:47 2023 -0700) on "windows_x64"

@johnniwinther, it looks like this compile-time error is reported after the inline constructor invocation has been lowered to a function call. Does this have any serious implications concerning inline classes with constant constructors?

It is non-trivial to support but I plan to use the code from the const-functions experiment to support this, though.

Great! I expect the ability to have constant expressions whose type is an inline type to be used in practice, and to be desired if it isn't supported.


kwm version 3.0.0

Updated formula to version 3.0.0

Got it.
Merged as 7f41cb94ab614161d5bb4ca1aa415202809001d0, thanks again!


fix: move validation status to the selected answer

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

The QuizQuestion validation status is currently displayed next to the question text, but it is currently having an alignment issue. #339 was created to address the issue, but we wanted to take this opportunity to revisit how the status should be communicated (because displaying the icon alone is too subtle).
This PR is an alternative, in which the validation status is moved into the selected answer, and the background of the selected answer is changed based on the validation status.
Screenshot

Before

After

Light
Dark

Correct

Incorrect

The only thing that jumps out at me is that the height will change when you validate, which will make the page move around. Would it be better to communicate via colour and mouse-over/SR-only text instead?

I made this for now to render all the questions on the client: github.com/freeCodeCamp/freeCodeCamp/pull/56582
It should just be an intermediate step before moving to use this component. I think the UI I came up with is pretty decent (see images in PR description). One issue I had with changing the whole background is that if an option has a codeblock (triple backticks), then the codeblock still had the regular background and it didn't look great. Adding the background to only the feedback looks good enough - but still didn't seem right. Wondering if we should go with something like that PR does. I do think it aligns pretty good with some similar feedback we use on other challenges. The editor challenges for instance:

And the fill in the blank challenges:


Obey "silence audio in background" cvar

Hate that it's silenced when alt-tabbed out.

Just to be clear, have you tried toggling the mediaplayer_mute_unfocused convar?

I didn't know it existed.


Enhancement: Sketch value aggregator performance

This addresses excessive resource consumption and performance problems with the following Apache Datasketches value aggregators:

Theta
CPC
Tuple (Integer)

When merging sketches via union, it is often a costly operation that creates intermediate book-keeping structures.  In addition, the operation performs better when the cost is amortized over many sketch inputs instead of pairwise merges on two sketches at a time.
When tested in a production environment, I measured a median reduction of 10x in the time spent creating StarTrees.
Related to issue:
https://github.com/apache/pinot/issues/13019
release-notes

Signature changes to Theta, Tuple and CPC value aggregators; now use Object as the aggregated value type

Codecov Report
Attention: Patch coverage is 0% with 129 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (59551e4) to head (5c0cf24).
Report is 375 commits behind head on master.

Files
Patch %
Lines

...gator/DistinctCountThetaSketchValueAggregator.java
0.00%
52 Missing :warning:

...regator/DistinctCountCPCSketchValueAggregator.java
0.00%
40 Missing :warning:

.../aggregator/IntegerTupleSketchValueAggregator.java
0.00%
37 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13020       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2427        -9
  Lines        133233   133087      -146
  Branches      20636    20631        -5
=============================================
- Hits          82274        0    -82274
- Misses        44911   133087    +88176
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <0.00%> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <0.00%> (ø)

java-11
?

java-21
0.00% <0.00%> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <0.00%> (-61.75%)
:arrow_down:

skip-bytebuffers-true
?

temurin
0.00% <0.00%> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

The PR looks fine to me, but it is a bit strange to approve a performance wise PR without an actual benchmark we can reproduce. Could you include a JMH benchmark as part of the PR?

The PR looks fine to me, but it is a bit strange to approve a performance wise PR without an actual benchmark we can reproduce. Could you include a JMH benchmark as part of the PR?

Sure, that is a fare request.  I would propose running the StarTree test under a JMH benchmark under previous and current configuration and including the results in this PR.  How does that sound?  Or, are you looking for a JMH test as part of the repo please could you point me to an existing test that would serve as a good example.

@gortiz as a starting point, here are some empirical measurements that I took from a run in our production environment.  The build time refers to the StarTree build time for a segment and the number of records refers to the number of records to aggregate.

The median differs by a factor of 10.


Issue #350

fix #350
put background position x and y together for compatibility

Nice! Thanks a lot for fixing this.
Just a small comment : it would be nice if the first line of the commit message contained a bit of explanation. eg. "Fix #350 : fix CSS for framelist overflow images" or something like that.
Thanks for the many contributions anyway, that's great!


Split county boundary data by state

Applies to whichever county boundary data we decide to view by state - could be nominally the high-res data (current) or low-res data (proposed in #189).
Goal would be faster load times, plus maybe an opportunity to customize the simplification and quantization by state according to the expected zoom level.

A challenge with simplifying at state level: the state boundaries need to get simplified along with the county boundaries if they are going to match, so we'd need to prepare and transfer state boundaries at least for the focal state and all states visible around that state in the zoomed-in view. This eats into file size, though maybe it'd still be worth it.


Enforced global query filters

Hi Kris,
Sorry if I’m making too much questions in a “issue” list. I have the feeling that I’m abusing… 😊
I have a scenario with an entity, say “tasks” should be tenanted. I mean, only the owner tenant should make CRUD operations on those.
But, I also have an API (different controller) where I want to retrieve a single task for anonymous users. And, for that, I have a different authorization mechanism and will make a query without tenant context and provide only the task id.
How can I make that specific query to not filter by tenant id? Is there a mechanism to disable/enable the enforced global query filters? Any other way?
One note: I don’t know the tenant of that task, just the task id. Otherwise I guess that I could just change the context tenant to that and remove-it right after.
Thank you,

"Filters may be disabled for individual LINQ queries by using the IgnoreQueryFilters() operator." :)
https://docs.microsoft.com/en-us/ef/core/querying/filters

@filipecarneiro
Other options:
You could create a 'system' tenant to hold your system level tasks.
You could use NullTenantReferenceHandling.NullableEntityAccess where a null tenant refers to the 'system' tenant.
You could use NullTenantReferenceHandling.NotNullGlobalAccess where a null tenant queries across all tenants.
public enum NullTenantReferenceHandling
{
    // Summary:
    //     A null tenant reference is NOT allowed for the entity, where possible a NOT NULL
    //     or REQUIRED constraint should be set on the tenant reference, querying for entities
    //     with a null tenant reference will match NO entities.
    //     This is the default option.
    NotNullDenyAccess = 0,

    // Summary:
    //     A null tenant reference is allowed for the entity, where possible an NULLABLE
    //     or OPTIONAL constraint should be set on the tenant reference, querying for entities
    //     with a null tenant reference will match those expected results.
    //     This may be useful where globally defined system entities are set with a null
    //     tenant reference.
    NullableEntityAccess = 1,

    // Summary:
    //     A null tenant reference is NOT allowed for the entity, where possible a NOT NULL
    //     or REQUIRED constraint should be set on the tenant reference, querying for entities
    //     with a null tenant reference will match ALL entities across all tenants.
    //     For obvious security reasons, this is typically not recommended; however, this
    //     can be useful for admin reporting across all tenants.
    NotNullGlobalAccess = 2
}


Allow for passing influx passwords as secrets

I have a large chart that includes some custom containers and influx and telegraf.  We let influx create a random password and all the other charts just read the secret to get the password.  It would be helpful if telegraf could read this out of the secret rather than me passing it in raw.

can you set it as an env var?

...k8s secret?
Please would you be more specific or provide steps to reproduce?

Yes, a k8s secret.   For example, when influx is deployed, the default secret name is namespace-influxdb-auth.  My chart deploys both Influx and Telegraf, it would be great if we could have telegraf reference the namespace-influxdb-auth secret rather than having me pass it in as a string (since I won't know what it is because influx hasn't set it yet)

can you set it as an env var?

Yes, it is possible to make the config file to read values from env vars. But it's not possible to pass these vars to the pod - https://github.com/influxdata/tick-charts/blob/dc5e913d9f789a10e337606d8047c3da54052d8e/telegraf-ds/templates/daemonset.yaml#L25-L41 - current implementation doesn't allow this. Check #56 asking for this.


Helm chart issue for upgrading karpenter by terraform

Version
I want to upgrade my karpenter from 0.16.3 to 0.27.2. The blow lines are my configuration in terraform.
resource "helm_release" "karpenter" {
  namespace        = "karpenter"
  name             = "karpenter"
  repository       = "public.ecr.aws/karpenter"
  chart            = "karpenter"
  version          = "v0.27.2"

Ive searched  alot, but non of solutions such as docker logout, or using ecrpublic_token helped me .
I have no idea what kind of solution can help me.
Version of helm provider on terraform:
provider "registry.terraform.io/hashicorp/helm" = "2.4.1"
Expected Behavior
upgrading karpenter from 0.16.3 to v0.27.2
Actual Behavior
Gives an error related to failure in downloading karpenter image
Steps to Reproduce the Problem
Having a helm_release resource to install karpenter
Resource Specs and Logs
│ Error: failed to download "public.ecr.aws/karpenter/karpenter" at version "v0.27.2"

ERRO[0412] 1 error occurred:
        * exit status 1

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

The helm terraform provider 2.4.1 does not support OCI repositories.  You'll need to upgrade to a newer version.

I'll close this as it appears to be due to using an old version, but feel free to re-open if you still run into issues.

I have upgraded my helm provider to latest . registry.terraform.io/hashicorp/helm = 2.9.0
But is gives me the error.
Error: repo public.ecr.aws not found

It's solved. After upgrading helm provider, I forgot to add v in version.
version          = "v0.27.3"

I am facing the same issue. Helm provider version is v2.9.0.

The helm_release config is
resource "helm_release" "karpenter" {
  namespace        = "karpenter"
  create_namespace = true
  name             = "karpenter"
  repository       = "public.ecr.aws/karpenter"
  chart            = "karpenter"
  version          = "v0.27.3"

But I am getting this error

@behnm Can you please share your updated helm_release config.

It worked with this config
resource "helm_release" "karpenter" {
  namespace        = "karpenter"
  create_namespace = true
  name             = "karpenter"
  repository       = "oci://public.ecr.aws/karpenter"
  chart            = "karpenter"
  version          = "v0.27.3"

Assuming we have the needed terraform and helm versions, does this mean that by just changing the version number and applying the terraform change, karpenter gets upgraded ?

Recent versions seem to have dropped the "v" prefix, so this is working for me with a recent release:
resource "helm_release" "karpenter" {
  name             = "karpenter"
  namespace        = "karpenter"
  create_namespace = true
  repository       = "oci://public.ecr.aws/karpenter"
  chart            = "karpenter"
  version          = "0.36.0"
}


Add external dependency not working

Steps to reproduce:
Follow instructions at https://github.com/mgechev/angular-seed/wiki/Add-external-dependency. Then run build.prod from the gulp file.
In the latest version of seed you'll now have to chase all the dependencies of the external dependency and add package configuration for all dependencies otherwise you'll receive the error below in the build.bundles.app step. In prior versions just adding package information for angular2-jwt would work. Now you'll have to add package info for js-base64, then buffer (which should be global for node?), etc.
[07:42:38] Starting 'build.bundles.app'...
[07:42:41] 'build.bundles.app' errored after 2.64 s
[07:42:41] Error on fetch for js-base64.js at file:///D:/Work/Projects/angular2seed/node_modules/js-base64.js
Loading angular2-jwt/angular2-jwt.js
Loading dist\tmp\app\home/home.module.js
Loading dist\tmp\app\app.module.js
Loading dist\tmp\app\main.js
Error: ENOENT: no such file or directory, open 'D:\Work\Projects\angular2seed\node_modules\js-base64.js'
at Error (native)
[07:42:41] 'build.prod' errored after 15 s
[07:42:41] Error in plugin 'run-sequence(build.bundles.app)'
Message:
Error on fetch for js-base64.js at file:///D:/Work/Projects/angular2seed/node_modules/js-base64.js
Loading angular2-jwt/angular2-jwt.js
Loading dist\tmp\app\home/home.module.js
Loading dist\tmp\app\app.module.js
Loading dist\tmp\app\main.js
ENOENT: no such file or directory, open 'D:\Work\Projects\angular2seed\node_modules\js-base64.js'
Details:
originalErr: Error: ENOENT: no such file or directory, open 'D:\Work\Projects\angular2seed\node_modules\js-base64.js'
Stack:
Error on fetch for js-base64.js at file:///D:/Work/Projects/angular2seed/node_modules/js-base64.js
Loading angular2-jwt/angular2-jwt.js
Loading dist\tmp\app\home/home.module.js
Loading dist\tmp\app\app.module.js
Loading dist\tmp\app\main.js
Error: ENOENT: no such file or directory, open 'D:\Work\Projects\angular2seed\node_modules\js-base64.js'
at Error (native)
Process terminated with code 1.

This actually appears to be a problem with the package angular2-jwt itself.

Hi @CuriousLayman,
do you absolutely need to use the package angular2-jwt? The implementation amount is not that much, have a look here: https://github.com/TheDonDope/crudular/commit/cb720805b182865ba7d0accb949206e77a80aacd


logrus.SetFormatter should be a member of instance logrus.New()

logrus.SetFormatter should not be a package-level setting.  A logrus instance can be passed all over an application, and should be carry with it the desired configuration of the application.

Why don't you just write a declaration function where you set the format then return a instance?
func ConfigureLogging(someconfigdata) (*logrus.Logger) {
    logrus.SetFormatter(&log.JSONFormatter{})

    return log.StandardLogger()
}

Actually now I'm realizing that logrus.SetFormatter has no effect whatsoever.

What?  The package level SetFormatter call sets the formatter for the package global StandardLogger instance.  This is the same instance that is used by package-level logging functions.  Example, logrus.Errorf() will use the standard logger, and therefore use the formatter that you provided to SetFormatter.  SetFormatter is ineffective if you're using a custom logger handle returned by logrus.New, but that's kinda by design, and certainly doesn't make SetFormatter useless.  Setting the standard logger settings and simply calling the logrus package functions (better yet, by aliasing logrus as log in the import lines) is a very common and solid usage.

Why would a new logrus instance not support a custom formatter? It seems that assumes the only valid use case for logging is to use the package level logger, which seems unfortunately short-sighted.

Why would a new logrus instance (from logrus.New) not support a custom formatter? It seems that assumes the only valid use case for logging is to use the package level logger, which seems unfortunately short-sighted.

It...does?  logrus.New() returns a *logrus.Logger.  The logrus.Logger struct has an exported field Formatter.  Just set that to whatever formatter you want.  That logger handle will use that formatter, and the standard logger won't.  The package level function only alters the standard logger, not loggers created via logrus.New().
Or is your complaint that you have to set the Logger.Formatter field directly, instead of the Logger type having a SetFormatter method?  Seems like a pretty superfluous complaint if so, given that the field (and many others) are intentionally exported to avoid the need for that type of method bloat.

@Yugloocamai indeed SetFormatter changes the logger formatter to the one given as parameter with appropriate locking.
You can do that on the global formatter directly with a call to logrus.SetFormatter or through the method of the same name applied to the instance you want to change the formatter.
But as you've seen in the documentation, the New function is here by convention as it is expected by most of go packages. You can also directly declare a Logger object and set the formatter to the value you want.

no activity since 2018, closing.


Remove numbers from sidebar

Remove numbers from sidebar and the polling as well (for speed)

@Loicavenel does showing the number of services, orders etc in the vertical nav bar is useful? it seems like we have a background API call that keeps updating those numbers, but I would assume 10+ icon or similar would probably be enough, as users don't usually care if its a large number anyway?

It would cut down on polling a yuge amount <3

I think it is useful, you know how many service you have.. Do you want to show it only in the Dashboard? and not in Nav Bar? When you load the Dashboard you have to get it anyway???
@serenamarie125 your thought?

@Loicavenel So, just some background:

Those are two different calls
We load the nav bar and make 3 calls (one for each "section").

I can see the benefit of polling for the # of services, but does it matter how many orders you have placed (that you need to see it on the side bar)?  Same thing with the # of catalog items?
That said, regarding the Dashboard.  I haven't seen any mocks, but I know that is something that is going to get redone at some point, so even though we are calling the same data for it and the sidebar now, we might not be in the future.

@ohadlevy When we designed the SUI initially, it was an intentional decision to have the "badges" included in the vertical navigation.
@Loicavenel I definitely see value to this ... the user is able to see the My Services number increment or decrement when services are approved/provisioned and/or retired, regardless of where they are in the UI
Why do you have to continue to poll?  Can you just updated the badge when a service is provisioned or retired?
@chriskacerguis what kind of dashboard mocks are you looking for?  Have you requested something new?  The last request was fulfilled with this documentation (note these are low fidelity mocks): https://manageiq.github.io/manageiq-design/UX/ui-service/Dashboard/design

@serenamarie125

Can you just updated the badge when a service is provisioned or retired?
That's why we have to poll, so we can update the count.  We don't have a push mechanism that would do that (backend team would need to add it)

what kind of dashboard mocks are you looking for?
I'm not looking for anything, and I haven't requested anything new.  I though at some point the dashboards were getting overhauled (I remember talking about that at the start of the release, but priorities changed?)

All that said, the polling API calls are minimal, so removing this won't do anything for performance.

@chriskacerguis as far as the dashboards, the editable dashboard effort is a phased effort.  I haven't heard of it affecting SUI in 4.6, but @Loicavenel can correct me here.

@serenamarie125 it was VERY briefly talked about that we would "share" the component.  That's all I heard...and haven't heard anything else.  Might have just been early planning.  /shrug no big deal


Constructed final bridge levels and overworld

PR IS UNFINISHED, UNFINISHED PARTS INDICATED BELOW
WHEN TESTING: DELETE YOUR OLD SAVE FILE (SEE WIKI) OR THE FOX WILL LAND IN THE WATER
Motivation
closes #281
closes #258
closes #257
The final game as shown in Wiki/Story had to be implemented.
I apologize for the gigantic PR :(
What was changed/added
Bridges

added the three levels: 0_Tutorial, 1_FrogHazard, 2_Final
changed fox jump height because for some reason, fox did not jump over 3 blocks -> i thought we had said 3 blocks so a fox can clear a deer with a jump, which might be necessary when you dont have many animals to build stairs with. If this should be changed, say so, but we then need to add more animals, and it might be a bit annoying for players if they cant just jump over.
changed fox hitbox so platforming with hazards is more satisfying -> the hitbox doesnt extend past the fox anymore, so you only die when you think you should
pause menu location adjusted -> now always in the middle

unfinished: tutorial screens
problems/bugs: aspect ratio of level 1, 2 fucked; bramble in level 1 overlaps with new inventory
Overworld

added the final overworld with four islands, one main one and three smaller ones (as seen in Story)
added items drawn by @Kabooni ; added function that automatically assigns item sprite to the right item & updated items in backend to be the new items
added all npcs that were planned, as well as functionality for the quests, which items to bring them etc
added all bridges and connected them via bridge edges
added the theme to the dialogue box -> UI needs to be further adjusted
UI for inventory updated: shows sprites of animals and items next to amount you have
UI for dialogue boxes now fits with the theme, increased font size

unfinished: Dialogue text, items disappear when picked up, Dialogue box displays NPC names
problems/bugs: last level doesnt update to solved upon return to overworld
will be done in separate issues: Starting Cutscene pictures, npc portraits
probably no time (if someone has time, feel free to do this): bridge interaction appears only when quest done
Testing
I'll include some screenshots when I've eaten lunch lol
Additional Information
if anything else was forgotten, needs to be added, pls say so. First take a look in the 'unfinished' section

#290 should be merged before, as it provides some adjustments for this branch.

The upper left bramble hazard in the frog level is currently overlapped by the Inventory Interface, maybe it should be moved slightly to the right and down.

Looks very good, the levels seem to be exactly like we wanted, and the quest seem to work from what I've seen. I've initially struggled to even play the game, for some reason my player spawned in the water, and couldn't get back on the islands, if someone else runs into that problem, just edit the save file (-> wiki).
However, I found one issue that persisted, at least on my end. When playing Level 1 or 2, the aspect ratio was a bit off, everything was stretched, at least I think so? Level 0 seems fine. I don't know if thats solely a problem on my end, so it would be nice if someone could verify that.

Also, after finishing the final level, I couldn't walk on the bridge, and restarting the game resets all bridges. I'm not sure which of those are tracked, or even intended, but I thought it useful to mention them here.

The upper left bramble hazard in the frog level is currently overlapped by the Inventory Interface, maybe it should be moved slightly to the right and down.

@aylinfi maybe you could adjust the brambles? sorry for placing them there in the first place x.x

Looks very good, the levels seem to be exactly like we wanted, and the quest seem to work from what I've seen. I've initially struggled to even play the game, for some reason my player spawned in the water, and couldn't get back on the islands, if someone else runs into that problem, just edit the save file (-> wiki).

-> yeah fair point, I could have said you need to do this.. the old island location was somewhere else because I changed the shape of the island. I will edit the pr with a warning to delete save files first.

However, I found one issue that persisted, at least on my end. When playing Level 1 or 2, the aspect ratio was a bit off, everything was stretched, at least I think so? Level 0 seems fine. I don't know if thats solely a problem on my end, so it would be nice if someone could verify that.

I did notice that as well, and initially thought it was the camera zoom but I had already adjusted that. If anyone has an idea what happened, feel free to change it. I will look into it tomorrow.
Interestingly enough though, earlier in the week, on my linux laptop, the aspect ratio had no problems; maybe its OS specific OR the aspect ratio got fucked along the way somewhere. maybe @aylinfi could investigate this as well since it is the bridge levels.

Also, after finishing the final level, I couldn't walk on the bridge, and restarting the game resets all bridges. I'm not sure which of those are tracked, or even intended, but I thought it useful to mention them here.

OH that is not good, i tested it with the other two levels and thought the last one was fine lol, sorry. I will check the connections tomorrow. The game should reset all bridges upon restarting, as they are not tracked at the moment (@ScatteredDrifter might change that, but its not a must) - but the bridge def should be built when finishing the level. I had a similar problem with the frog hazard level earlier because aylin changed the names of the files, so I will check tomorrow if that is the case, that's an easy fix.
(@aylinfi maybe tell me in future when you change file names, as the file paths to levels are hard coded)

Just to clarify, when finishing the final level, the bridge is built, but I'm seemingly unable to actually walk over it, see video below. I'm guessing this is some sort of hitbox issue, all horizontal bridges work just fine.
https://github.com/mango-gremlin/arch-enemies/assets/104799849/c4c53b11-fd7e-4120-9c41-67063e330e35

Just to clarify, when finishing the final level, the bridge is built, but I'm seemingly unable to actually walk over it, see video below. I'm guessing this is some sort of hitbox issue, all horizontal bridges work just fine.

yes, that is what i expected you meant. i ran into the same issue earlier. The bridge is built when you solve the level, but the hitbox that usually prevents you from walking into the water (the island edge has no collision at bridge points) only gets removed once the singleton confirms this level fits this bridge edge. Last time, this didnt work because the file path i specified for the bridge edge was the wrong path. If there is a different issue, it might have to do with the different template for the vertical bridge
I will check really quick whether it's just the file name, one sec

I did notice that as well, and initially thought it was the camera zoom (because the other levels are longer) but I had already adjusted that. If anyone has an idea what happened, feel free to change it. I will look into it tomorrow.
Interestingly enough though, earlier in the week, on my linux laptop, the aspect ratio had no problems; maybe its OS specific OR the aspect ratio got fucked along the way somewhere. maybe @aylinfi could investigate this as well since it is the bridge levels.

The cameras are still zoomed in uneven, e.g. like this in the frog level

I did notice that as well, and initially thought it was the camera zoom (because the other levels are longer) but I had already adjusted that. If anyone has an idea what happened, feel free to change it. I will look into it tomorrow.
Interestingly enough though, earlier in the week, on my linux laptop, the aspect ratio had no problems; maybe its OS specific OR the aspect ratio got fucked along the way somewhere. maybe @aylinfi could investigate this as well since it is the bridge levels.

The cameras are still zoomed in unevenly, e.g. like this in the frog level

OH okay fair, I misunderstood. I will test this later, thank you!!


[Bug] Candlesticks display incorrectly when zooming out versus zooming in with a certain amount of data

Version
5.4.3
Link to Minimal Reproduction
https://echarts.apache.org/examples/en/editor.html?code=MYewdgzgLgBMCGsC8MDaBdAUAMxAJxgAoAbAU1gEsYUBGAbhioB4UBWABnYYoGoeBKGAG9MMMXEQA6AA4BXCAAtCAcnjL-mAL6ZQkWABNE8amiy4CJcoxP1rLGDU7c-gkeJiGo8GfKWoARDQA7ABskgDMABz-ADSBQQCckgBM4bHxYck06cFJACxp6DEBuZI00XHlNJKRyTlBkZIJQTm1knl5_kUlbeGsrck1Ca3VrMOVkeHt_d2BbQkhA-3ZE9WRK3N5ZXWz5VPNrWF57K1TrGkTYawt6BraINJQFOAmbjAAHgCC7xQQAFzCUTiTzwAEIKBAzQxIEAT2-vwBQihQLEIIAWiAQABbREomBQGHSUgA5QUSAUfSkZTQ9zQeB4KAA9g08SkMD6AGOdiQlkQUh4Cikf5oPFvdwEokkhDssjQCjAADW1LxqKMAJBeO0YiwmjomEwfKgAEkwFB-QA3eDEQjYWRgYBPF6EVxAkE-RSEHr7FqVBbtE4TM7hDblK5BbK3IHg91KfwAI38GjEWJhAGEFPSoJJDQB5R7PMCEMUfeHC4sgsGIHl4vkCoUA1AqwHudwVjxGJvI9xYMSafh6qEwZKcdj9oA
Steps to Reproduce
Open the minimal reproduction link and wait for few candlesticks to show up.
Then zoom in and out, you will see that the new candles display correctly or incorrectly depending on the zoom level.
The issue occurs also when changing the right panel width with the mouse
(From my experience, the issue occurs only when updating the chart with setOption)
Current Behavior
New candles added with setOption display incorrectly when zooming out with a certain amount of data.
Correct display:

Incorrect display after zoom out:

Expected Behavior
The new candles should display with the right yAxis values for any zoom level as long as the candles are in the display area.
Environment
- OS: MacOS Ventura 13.0
- Browser: Chrome, Safari
- Framework<EMAIL_ADDRESS>
Any additional comments?
No response

duplicate of #18983, #18503.  On large zoom-out candlesticks become 1 pixel wide, which is the minimum by design.

If you examine the zoom-out screenshot closely, you'll notice that the new candles are cut in half, with the upper portion not being displayed. The upper part has the same width as the visible section. If the lower part is visible, the upper part should also be visible and not cut off.

ok, so the issue is about the height, not the width.
Notice that candlestick.data should be in format [open, close, lowest, highest], which is not the case in your data:
present = data.push(["183.97","196.40","183.531","186.571"])
correct = data.push([183.97,186.571,183.531,196.40])

You are totally right! Thanks for your responses!


Implement GET CONFIGURATION for MMC (Multi-Media) devices

Having GET CONFIGURATION is in particular relevant for devices that support different media types, e.g. optical devices like DVD-RAM drives with support for DVD-RAM, CD-ROMs, DVDs, ... There are device drivers and tools (at least for the Atari) that use this SCSI command to find out which type of media is inserted, in order to offer functionality related to the current media type. Essentially GET CONFIGURATION provides a more fine-grained device type and medium description than INQUIRY.
This can most likely be a backwards compatible extension to the existing CD-ROM emulation. Initially GET CONFIGURATION would just return the data for CD-ROM devices.

After starting with a POC it turned out that the effort to correctly implement this feature is high, and IMO not jusitified considering that this command is just a nice-to-have.
Thus closing this ticket.


How to create Procfile.dev?

./bin/dev warring:
Using foreman
ERROR:
Please ensure `Procfile.dev` exist in your project!

Ok, I got, there is a Procfile.dev-static exist. just rename it
But it shoule appears in document

If you have followed the documentation, after installed react_on_rails it creates this file for you. You don't need to create it manually. And the content of Procfile.dev is different from Procfile.dev-static.
Your issue is with ./bin/dev which will be fixed in the coming release. Meanwhile, you can copy the content of the file from master branch.


Additions to GDSC Map for DSC Lead- Vasundhara Shukla

Fixes #
Proposed Changes

😂 @aravindvnair99 @Vasundharashukla
I made that change, I added the suggestion as a commit to the PR changes :))

Face palm @abhinavsri360 @aravindvnair99

🤦🏻♂

😂 @aravindvnair99 @Vasundharashukla
I made that change, I added the suggestion as a commit to the PR changes :))

@abhinavsri360 Yeah I was just clarifying so that @Vasundharashukla understands how the suggestion feature works. 😅


3D scene Import problems

Windows 8.1 Godot v2.0.1.stable.official
So this is my problem with godot importer.
It fails to:

Remember the last cips of animation.
Overwrite the scene when it's opened in editor.
When reimporting it shows some other clips from past.

The video tells more than any words

I think this was fixed by the new importer's addition on master, can someone confirm?

Hard to tell what the issue was about, as the video is dead. Second problem was reported again in #14338. As for the other too, if someone had this issue, there's probably some less vague report out there (if not already closed). Closing this one, because it's from even before 2.1, so there's no reason to keep it in the current state :I


Use rustfmt

This pr adds a rustfmt.toml and formats all existing code.

Hey, thanks for your pr. However, we do not want to use rustfmt as it does not support our style guidelines.