Disable claiming in specific servers.

I think this should be a feature, maybe the channels you choose can be made the only places you want to claim.

change if message.author.id == mudae: >>> if message.author.id == mudae and message.channel.id in [111111,22222]:

`

change if user.id == mudae: >>> if user.id == mudae and reaction.message.channel.id in [111111,222222]:
or change [11111,22222] to in multiids and use that variable
those changes should get you what you want. Personally I don't see the need to add this as it just limits the bot function and adds more checks the more it scales.

Fair enough. Thanks for the quick support btw, I gladly appreciate that.

2 (and a few extra)more questions.

Is it possible for the bot to always react with the same reaction as mudae? (Making it look less fishy)

My server has the togglesnipe feature on, so i put the timer for claim to 4.5 (0.5 secs after the protect snipe wears off). Does that work?
2.a Is it possible for the bot to know when togglesnipe is not affecting the roll and setup another timer for when there is no togglesnipe involved? (In my case, you wouldn't care about togglesnipe when it is a character you have on your wishlist or is in nobody's wishlist.)

It is possible but since mudae doesnt always have reaction to claim ? (This is a Mudae premium feature) it is hard to account for and I can't assume that every1 plays on a premium server

Note about emoji's or emoji usage

this here will allow you to use a custom emoji if u uncomment out the line and comment out the ❤  but keep in mind back to the note of mudae bot reacting the same as mudae that normal emojis like 🕯 , 💞 , 💖 , ❤ etc etc. do NOT have a reaction.emoji.name and to use them you actually have to copy and paste the actually emoji into the code  as shown in both examples making it kinda of frustrating to deal with

I had a user use #.5 so to my knowledge it will work if it doesn't work it would throw an error
2a. so that would have to implement something with message history which I don't wanna get into really since it would have to know who rolled it and who has priority so my work around is similar to what I do with free kakeraP sniping.

this way the 1st snipe gets applied which either works or doesn't them it removes the reaction , waits for the remaining delay and attempt the second snipe
I can add that to Wishlist'd characters atleast if you would like that option basically adding

await asyncio.sleep(1)
await message.add_reaction(emoji)
await asyncio.sleep(1)
await message.remove_reaction(emoji,self.user)

how or where would I implement your answer to 2.a?

About 1...
I'm pretty sure it isn't, we don't have premium mudae yet it is adding the hearts and other reactions to the rolls.
How would I implement it?

hmm i can implement it with a push atleast for the wished characters since they are immune to snipe protection in some servers
give me a few and ill push the code
and with 1:

example of mudae not adding a reaction by default it based on time so it changes on the time played

I mean, i could personally add the "way the 1st snipe gets applied which either works or doesn't them it removes the reaction , waits for the remaining delay and attempt the second snipe" if you give me the where to put it and what to put.
I'm pretty sure you can in fact allow it without premium, with the downside of reducing the amount of rolls you can make. In the server I'm in it works anytime.

I added the code already so it should be good
with the emoji thing since it only your server and not in mine I can't really implement that function without having to probably fix it for others or if someone misses their wishlist because mudae didnt add a emoji on their server. I will look into it tho and see if its possible if i do need to implement it in the future tho

Ok, do i have to do something for the "way the 1st snipe gets applied which either works or doesn't them it removes the reaction , waits for the remaining delay and attempt the second snipe"?
I will check about the reactions, but i'm pretty sure it's not premium, I'll inform.

I just checked. "$togglereact 2" makes it so that every roll has a reaction by mudae at the cost of removing some rolls.

yeah but again that very "Specific" to your server what if someone else's server doesn't use togglereact 2 because they dont like less rolls ?
but anyway I've made change to the code and pushed it

this update should allow the bot to 1st see if emoji is available after the delay and if not it defaults back to the use_emoji setting

I'll try the update and see if there's any problem. Again, I'm very grateful towards you for being so open to comments.

I tried the update. I can't check the wished characters thing, but the code to match mudae's reaction works.
Has the update that you mentioned about making a similar bypass to then one with KakeraP bypass, which was basically adding a "snipe gets applied which either works or doesn't them it removes the reaction , waits for the remaining delay and attempt the second snipe"? If it is implemented then it isn't working. If I am the one that has to implement it then tell me what to do.

right now its only added to wished list characters and kakeraP other than that the others just make 1 attempt.
if you want it on ever other check you can just copy the code from the ones that have the method to the ones without

How would I do that?

by "wished list characters" you mean the ones in json file?

No those are just characters you need
"wished" is what I classify as if mudae says
"Wished by str({self.user.id})"

yeah, then I want the snipe thing for the characters in json

you can copy the code from await and move it on the  other checks which are
the series list check , name check and the kak value check
currently just testing out if the method stated cause any issues so I personally didnt push that until i feel like its stable but if you want that method then copy and pasting would be the fix

            await asyncio.sleep(1)
            print(f"Free Kakera was detected in {reaction.message.guild.name} : {reaction.message.channel.name} @ {reaction.message.created_at}")
            await reaction.message.add_reaction(reaction.emoji)
            await asyncio.sleep(1)
            await reaction.message.remove_reaction(reaction.emoji,self.user)
            await asyncio.sleep(kak_delay - 2)
            await reaction.message.add_reaction(reaction.emoji)

where do I copy that?

the series list check , name check and the kak value check
so basically every check that isnt the wish check

Could you add me on discord DaMagicFox#0001 so that I can send you the file and you tell me if it's good?

just take screencaps for now and show me if we need to do more then we can proceed

sure

That's what I did, and it's not working as intended. What did I do wrong? I'm looking to learn python btw, so any tips or reasons for why it broke can help.

doesn't seem wrong did u get an error ? and i think i see the problem

so since you are learning why do u think this is not working correctly here ???

The error I get is in the (emoji) section for line 130

I tried changing it to ❤ (copy pasting the emoji) but it just started doing it on every roll

yeah but there an issue with your logic there look at what different from this vs the others

is it that?

Yes that looks correct lol but do you understand what happened ? and why u had to do that

what I got is that the other ones were "if" and then, in the next line "print" and below that the rest of the code. The series list starts with a "for" and then "if", i just followed the if sequence the others had.

basically your old code attempted to add a emoji that was never set X( count of things in your series list) number of times so it will do for example 5 times , remove emoji that was never added , and try to add another emoji that was never set
the new code change does
for X in List do
if X1 in "X1" then do
stuff
if stuff = something then do
other stuff
if X2 in "X1" then do
stuff (False never runs)

I'm kinda understanding, but not much tbh

So old one adds reaction 5 times
The new one add 1 reaction if it meets the requirements of being in the list
Sent from my iPhone

On Apr 27, 2021, at 10:34 PM, DaMagicFox @.***> wrote:

I'm kinda understanding, but not much tbh
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Now the only other thing I don't fully understand is how the delay works for the snipe check thing

Which ones ? the kakera one is a little bit more complex while the character sniping is more simple in terms of explaining

closing issue for now

No, i mean, how do i customize the delay for the snipe thing I just added, like, which number does what

anytime you see
asyncio.sleep(x) imagine telling the bot to wait x amount of secs
so u can set the delay there in the code if you want  and have it make more sense

asyncio.sleep(claim_delay - 3)

how does that one work?

is it the claim delay in json file - 3?

Big props for the quick support, I really appreciate it. For now, I don't see any issues with the bot, and will inform if anything. Again, I appreciate the hard work you're putting into this, and for being so tolerant.

no problem at all

change if message.author.id == mudae: >>> if message.author.id == mudae and message.channel.id in [111111,22222]:

`

change if user.id == mudae: >>> if user.id == mudae and reaction.message.channel.id in [111111,222222]:
or change [11111,22222] to in multiids and use that variable
those changes should get you what you want. Personally I don't see the need to add this as it just limits the bot function and adds more checks the more it scales.

sorry for the dumb question but I'm new to this, does this mean that if I want to allow the bot to claim ONLY in a specific channel, I need to substitute the "111111" with the channel ID?

change if message.author.id == mudae: >>> if message.author.id == mudae and message.channel.id in [111111,22222]:

`

change if user.id == mudae: >>> if user.id == mudae and reaction.message.channel.id in [111111,222222]:
or change [11111,22222] to in multiids and use that variable
those changes should get you what you want. Personally I don't see the need to add this as it just limits the bot function and adds more checks the more it scales.

sorry for the dumb question but I'm new to this, does this mean that if I want to allow the bot to claim ONLY in a specific channel, I need to substitute the "111111" with the channel ID?

Yes, you change the "111111" to the channel ID (To get channel ID activate developer mode in advanced settings and then right click a channel) the number is just a reference number. if you want to add more just put another comma and no space and insert the other one.

@Regi49 make a seperate issue next time and i can provide faster and better assistance
and I guess since i see that more people are wanting limited scope i will just add the same code but with the limited scope changes and have 2 versions for future pushes

alright, thanks for the replies

It might be a fault with mudae more than likely if it was originally working and been failing recently

It might be a fault with mudae more than likely if it was originally working and been failing recently

Any ways I could fix it?

Since it’s a problem with mudae and discord itself it’s falls outside of being able to fix
Basically discord already thinks of mudae as a spam bot and has been blocking mudae from operating
Someone else reported an issue with a failed snipe
After 4 successes there was 1 fail (reason unknown) and after was a success so currently not sure
If you are able to isolate a reason I could implement a fix

Since it’s a problem with mudae and discord itself it’s falls outside of being able to fix Basically discord already thinks of mudae as a spam bot and has been blocking mudae from operating Someone else reported an issue with a failed snipe After 4 successes there was 1 fail (reason unknown) and after was a success so currently not sure If you are able to isolate a reason I could implement a fix

Yeah I know, they had recently banned mudae's api, but I don't know why it would make sniping not work.

Ultimately discord py is a wrapper of discord api so maybe changes from discord side mgiht have temporary caused message content not to be parsed correctly hence failing the check
basically if discord is not giving the program input then there will be no output
but again unsure if the problem persist tho let me know what you think the probably cause is as this hasn't happened to me personally yet so I cant fix a possible "bug" that I have not found

Ultimately discord py is a wrapper of discord api so maybe changes from discord side mgiht have temporary caused message content not to be parsed correctly hence failing the check
basically if discord is not giving the program input then there will be no output
but again unsure if the problem persist tho let me know what you think the probably cause is as this hasn't happened to me personally yet so I cant fix a possible "bug" that I have not found

Yeah it's probably a discord problem, it's weird that it hasn't happened to you, but I tried isolating the problem, (By using default settings, not using the snipe thing, not using the specific channels, and even having the default characters in json!) but I couldn't find anything. Although kakera seems to be working i think.


Fixing broken link

Fixed the broken link for 'kubectl autoscale' in the statement - Now that the server is running, we will create the autoscaler using kubectl autoscaling.
This issue is referenced in #13683

/lgtm

/lgtm

/approve


user permissions

What ADO user permissions are required?
Add this information to the Marketplace page.

ADO basic, thanks for your suggestion.


Add the details of wallets on dashboard available on connect wallet.

Is your feature request related to a problem? Please describe.
Yes, providing the prerequisite information is necessary.
Describe the solution you'd like
I want to add the details to be written on the dashboard so that people know the information about the wallet before opening a particular type of wallet.
Describe alternatives you've considered
No response
Additional context
No response

Hey @garimapahwa, can you elaborate on what all information you plan on showing on the dashboard?

I would like to work on this issue. Please assign it to me under GSSoC'23.


Frequent crashes when opening / right clicking a file or folder

Description
Hi,
Files sometimes crashes when I want to open file or right click on it. It happens very often and it's really annoying and it's getting unusable for me.
In this picture I can't click anything and it's just a static window. It happens on other files and not only this one. Sometimes when I click a folder it also freezes.

Maybe it's because of the right pane. I'll try to use Files without it and I'll update if it crashes again or not.
Steps To Reproduce

Click or right click on a file
Application freezes

Requirements

Right click menu should appear.

Files Version
<IP_ADDRESS>
Windows Version
10.0.22631.2048
Log File
debug.log

It still appears in <IP_ADDRESS>

I'm not seeing anything in the log file, @hishitetsu any ideas?

It appears when I open a tab / folder and quickly right click the file.

I now use Files without the right pane but it still crashes.

I found a way to reproduce it. If I right-click immediately after the application starts with some folder that is not the home page, it will definitely freeze.

Yep, that's it


[feature request] add 'export now' button or menu item

[x] I have verified in the Zotero addons screen that I have the latest release of BBT (https://github.com/retorquere/zotero-better-bibtex/releases/latest) and Zotero installed
[x] I am posting a single question, bug or feature request
[x] I have included a descriptive subject of the problem
[x] I am available for follow-up questions and testing
[x] If I am posting an export or key-generation related bug report, I have included an error-report by right-clicking the problematic reference and submitting an BBT error report

Bug classification
My database is fairly big, and thus exporting it always stales my zotero (sometimes my whole computer) for a few seconds. Thus, the 'on change' export option is not really suitable for me as it used to export after every change. The 'on idle' I find too unpredictable, because I never know when that would be, and would often like to check the results in the bibtex/compiled document as soon as possible.
So at the moment I need to open the Zotero Preferences, open the BBT tab, and then manually export from there. Would there be a chance to add a menu entry or a button to zotero to 'export now'?
Many thanks!

I'm not sure how to go about it; one collection can be exported to multiple locations, so it couldn't be a button that just exported the current collection.
I'm more concerned about the stalling though. BBT caches fairly heavily; I'm not sure what counts as fairly big (how many references are we talking about here?) but a few thousand shouldn't noticably stall Zotero.

Could one maybe add a button for each entry in the export-list? Or a submenu in the Tools-menu?
I don't know what would be common, but I only have one entry so that I always export my whole collection (my folder structure is pretty bad).
Just checked: 1840 references. So not that much.
zotero.sqlite has 160MB (maybe from many full text indices?)
and the bibtex.bib 1MB without notes or abstracts.

I had a similar problem when importing my bibtex into autocomplete-bibtex for atom, and the maintainer kindly added webworkers that work in the background to overcome this issue. Maybe that could be a solution?

I'd rather not add an extra button there. It also saves very little. I can look at making that list multi-select.
Zotero.sqlite doesn't affect BBT, the BBT data lives in its own DB. I'll look at the performance issue, 1840 refs really isn't much. The cache must not be used for some reason; with a filled cache that should be about 4 seconds.

I can look into web workers, but they won't help as much as the caching, and they add extra complexity.

webworkers can't share state with the main process, so I'd have to keep a fully separate DB up to date with the main DB. I'll have a look when I have time (not in a few weeks), but first I need to make sure the cache works.

@retorquere I checked exporting again without changing anything, and the cache page then revealed it: I was faffing with the post-script settings. It's still at around 3-5 seconds. But during that time it nonetheless stales, which does not allow me to export 'on change' when I'm adding more changes, as then every single change is exported.

Oh yeah any change in the settings drops the cache.

But the cache should not stale so fast; cache expiry is currently set at 30 days, and every export resets the timer for exported entries. So as long as you export a particular collection at least once a month, the cache should remain populated. If like to look into the cache expiry thing - the cache not working would be a real problem.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>00 ("cache logging").

I found some problems in the cache fetches so the cache was probably not always used when it should be; please try 2621.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>32 ("adjust test cases for #1038").

Can you try 2632?

Thanks so much for looking into this @retorquere !
It stalls already on startup with 2632:
[JavaScript Error: "TypeError: BBT.ready.isPending is not a function" {file: "chrome://zotero-better-bibtex/content/BetterBibTeX.js" line: 10024}]
Zotero.BetterBibTeX<[87]/</<@chrome://zotero-better-bibtex/content/BetterBibTeX.js:10024:9

[JavaScript Error: "TypeError: BBT.ready.isPending is not a function" {file: "chrome://zotero-better-
version => 5.0.55, platform => Linux x86_64, oscpu => Linux x86_64, locale => en-US, appName => Zotero, appVersion => 5.0.55, extensions => Zutilo Utility for Zotero (2.0.4, extension), ZotFile (5.0.8, extension), Zotero LibreOffice Integration (5.0.14.SA.5.0.55, extension), Zotero Better Bib(La)Tex (<IP_ADDRESS>32, extension), Shockwave Flash (<IP_ADDRESS>, plugin), Zotero automatic export (1.2.4, extension, disabled)

With quite a few repeats of the error message!

Debug ID D848185013 was my first try, and D838627974 the second one.
Here's the second one, in case you can't access the debugs: https://pastebin.com/H3sYhryS
In both cases it stalled and did not pass the Loading citation keys stage.
Thanks a lot!

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>36 ("transactional DB upgrade").

Try 2636 -- thanks for the report!

I can't see the D reports BTW, those go to the Zotero crew, I don't have access.

First change after changing setting_export on change_ expectedly took ages, with many messages from my OS that zotero wasn't responding anymore.
-> obvious because cache was cleared. -> killed zotero after 3 minutes.
-> tried again and it stalled for quite a while (don't know how long) but it finally worked
Log is from adding two fields in a dummy entry (citekey testname2018test). During typing in the second one, it stalled for a bit, but it eventually worked. The log is here: https://we.tl/t-xOL9Ete21J

As far as I can tell, everything comes from the cache except those two changes. What kind of cache rates are you seeing in the auto-export prefs?
AFAICT I can't prevent the not-responding messages; for me to do so I'd have to do the export asynchronously, but I don't think this is possible without a change to Zotero.

It looks like it's 100%.
Thanks a lot for your support!
I do have an SSD, but I could imagine a lot of the time required comes from I/O. After all it's a 2MB .bib file... maybe there's a way to log times, if that's a thing you would want to pursue further?
As mentioned before, for my case, I would be perfectly happy with a menu entry to trigger my previously defined export.

I'll have a look, but there's really no infrastructure for these kind of things in Zotero. I'm patching the program as it runs to get a lot of these things done, and it's always a little fragile. Async export would be the best solution.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>50 ("fixes #1038").

Give 2650 a go.

Thanks a lot, this worked perfectly well!
It took me a while to find the menu item though, but this solves it for me, thanks a lot!!

It only comes up in "My library" because that's the only auto-export you have set up. The auto-export menu shows up for collections/libraries that you've configured for auto-export. Some people (like me) have several auto-exports configured for multiple collections; neither the File menu nor the Tools menu allow for context of what to export.

(it also won't show up if you have auto-export set to "On Change")

Thanks, that's good to know.
Actually the earlier question was pointing at whether when I define an export for a collection it would show up in the context menu for that collection or only the "My Library" item. But both code and trial answered my question: no matter what collection is exported it's attached to the My Library item.

(only repo contribs can close issues here, it's to make sure that I do the required wrap-up like releasing a new version)

Actually the earlier question was pointing at whether when I define an export for a collection it would show up in the context menu for that collection or only the "My Library" item. But both code and trial answered my question: no matter what collection is exported it's attached to the My Library item.

I don't fully understand what you mean by "attached" here, sorry. You set up auto-exports either on libraries or collections by right-clicking them, choosing export, and checking "Keep updated". The "Automatic export" menu option becomes available on the library/collection you originally used to set up the auto-export, nowhere else. Changes to underlying collections will trigger an auto-export for parent collections/libraries, but the "Automatic export" menu is only available at the level where the auto-export was set up.
Perhaps you overwrote an auto-export by choosing the same file; there can be no two auto-exports set up to point to the same export file, so if you pick the same file for another auto-export, the earlier one gets replaced by the new one.

(whether this is the case can be seen in the prefs, where you have an overview of all auto-exports)

Okay, my fault again. I thought I had exported a collection but did so via the File->Export (which exported the whole library), instead of via right click export.
Now it shows up where it should do, thanks!

File->Export exclusively exports "My Library"; it doesn't matter what you have selected at the time.


feat: Add support for OpenApi Specification as input

Investigation
Add support for OpenApi Specification using APicurito models and OpenApi-To-GraphQL lib
How this works

It picks open API file and transforms it to GraphQL Schema.
It picks up all the methods and let people to edit them
It will rename OpenApi file so it will no longer be processed. (source)

Tasks

[x] oapi command line
[x] Rest gateway support (requires) extra
[x] Directives support
[x] Automatic filtering for custom fields
[x] json and yaml support
[x] Investigate having backend in REST along with GraphQL resolvers utilizing the same db/rest layer.
[x] Wrap integration into graphql module
[x] Config enhancements
[x] Docs

Demo video:
https://www.youtube.com/watch?v=mRZ585xjFf4&feature=youtu.be
Verification
graphback init openapi
cd openapi/model
wget https://gist.github.com/wtrocki/2ece5c69bc585d36d601b0ce701103f7\
cd ..
graphback generate
graphback db

Status update
Working with openapi team to see if we can get this into our workflow and make sure that is performant. Current approach is simply generating separate graphql schema file that will also have custom resolvers. This can be later edited by users that can integrate schema.
Second phase was to check if we can rely on the openapi for the resolvers generation.
Additionally there is a lot of challenges if we still want to process things by relying on the OpenAPi definition. I believe that we can have separate resolvers layer on our own.
https://github.com/IBM/openapi-to-graphql/issues/240
Discussion
From my point we can integrate tooling inside our cli, but we might also simply leave this command as it is here with some additional tooling for wrapping stuff.
Considering current limitations:

No support for directive mapping
Very limited schema
Duplication of the CRUD methods comming from our GraphQL API generator

I think it is reasonable for us to let people manually review generated graphql schema from OpenAPi Schema and no longer use OpenAPi schema as input.
Additionally, we could have OpenApi Schema that will be used to contact backend - We can use OpenAPi to generate client that will be available in resolvers and mount it into context.
However, developers will need to manually call the API inside the resolvers.
Generating fully functional GraphQL Api from just OpenAPI is risky business - it will be useful only for demo use cases and it can have serious impact on production use cases - having black box api/db layer is basically why so many graphql libraries fail to grow.
Investigations
OpenAPI to GraphQL
Very good and proven library that generates GraphQL schema and resolvers.
Schema supports various and complex api definitions - library is very roboust in this sense.
Resolver layer is kinda complex but there is option to provide a custom one.
Currently, we are using this library to output actual schema files that can be edited by users.
The reason for that is custom methods can overlap with CRUD ones.
Directives support
I have done quick spike to attach directives to the OpenAPi definition and it works like dream however it will be an custom format that people will need to know.
If we settle with manual edits of the schema then users can get a better experience by supplying directives on generated schema rather than file
Multiple api support
Currently command can process single api but we can move towards multiple api that is mapped to multiple graphql files. Opinions?
New Architecture
I think we need to come up with new architecture that maps all the moving parts of the system

Input sources (GraphQL Schema, OpenAPI, JSONSchema etc.)
Modules (GraphQL module per each model file for separation of concerns)
https://graphql-modules.com/
Abstraction for data access logic. (DataServices type that can be DB(many subtypes) and REST
Middleware type that can be REST, GraphQL (also with different subtypes)
Tooling - Code Generation, validation, custom logic orchestration
Transform templates to reference implementation (instead of many templates we can have single reference/opiniated server that is performant and production-ready - however community
should be able to build more
Configuration - actual stack should be question-based (using new graphback config and graphback init command)
People should be able to continue and tweet things using configurations

Targets

Have clear responsibility for every layer of the subsystem
Reuse a lot of proven open source technologies and standards as possible
Decouple from template creation

Challenges

Source code promotion (dev/prod) on runtime
Database migrations (depending on the db spike)

@craicoverflow Awesome review!  Thank you

Ready for another look.

We need to find a way to map ID.

Ready for review.

I have decided to add docs only. Validation phase will require a lots of refactoring so going to add it in separate PR.

@ankitjena Can I have a review on this. This one is blocking the release.


Warning: componentWillReceiveProps is deprecated and will be removed in the next major version.

Warning: Failed child context type: Invalid child context virtualizedCell.cellKey of type number supplied to CellRenderer, expected string.

Warning: componentWillReceiveProps is deprecated and will be removed in the next major version. Use static getDerivedStateFromProps instead. Please update the following components: DayView

Have you found a solution for this problem ? i am getting this error on loading


Feat: add regex "$query" filter

Add MongoDB $regex query filter
TODO

[x] implement $regex

[x] Add DbOp::Regex
[x] Implement $regex match in codegen.rs
[x] Implement $regex match in vm.rs
[x] Implement Error::RegexError
[x] Implement $regex match in subprogram.rs

[x] implement unit tests

closes #107

@vincentdchan Hey! I think every is done to implement the regex query filter. I've tested manually with one of my project, works like a charm ^^.
I'm taking any advice to improve 😄!

Good job! I need some time to review~

Merged. This will be released at 4.4.0 next week.

Would you like to add the related docs here?

I can do it this weekend or ok Monday 👍.

4.4.0 published!


Feature/fix fw issue

This branch fixed issue described in #26.

Coverage decreased (-0.02%) to 94.205% when pulling ec404aa2163c5d58e4f56bb09b6e29330ab5b5c2 on yuhei159:feature/fix_fw_issue into 41765bea972438283b8edafeb31aa5eb8e8907cf on NIFTYCloud:master.

Coverage increased (+0.04%) to 94.266% when pulling c25dc0a26236bfd1205b04fef6af84623098f4b4 on yuhei159:feature/fix_fw_issue into 41765bea972438283b8edafeb31aa5eb8e8907cf on NIFTYCloud:master.

Coverage increased (+0.04%) to 94.266% when pulling 3a96b755be88970d76ca29bfb410fe1f03f09955 on yuhei159:feature/fix_fw_issue into 41765bea972438283b8edafeb31aa5eb8e8907cf on NIFTYCloud:master.

Coverage increased (+0.04%) to 94.266% when pulling b761dc255b59285df2364c8cc0d149ea9143703b on yuhei159:feature/fix_fw_issue into 41765bea972438283b8edafeb31aa5eb8e8907cf on NIFTYCloud:master.

Coverage increased (+0.04%) to 94.266% when pulling 33d4399ba7755f2371904d0c37d0a89dbad82d07 on yuhei159:feature/fix_fw_issue into 41765bea972438283b8edafeb31aa5eb8e8907cf on NIFTYCloud:master.

You should fix ansible-role-niftycloud/library/documents/niftycloud_lb.md about purge_ip_permissions.

Coverage increased (+0.04%) to 94.266% when pulling c8f74540b2087b93ddbb2afa382a18b08578ffa9 on yuhei159:feature/fix_fw_issue into 41765bea972438283b8edafeb31aa5eb8e8907cf on NIFTYCloud:master.

LGTM!


loaderUtils.parseQuery() received a non-string value which can be problematic

loaderUtils.parseQuery() will be deprecated in favor of getOptions() in the next major version of loader-utils. The call should probably be replaced.
See: https://github.com/webpack/loader-utils/issues/56

Thanks for the heads up. We have a pull request open for this:
https://github.com/ethul/purs-loader/pull/86
I will merge it in once I test things out in weback2.
On Fri, Apr 14, 2017 at 05:12 Louis Chan<EMAIL_ADDRESS>wrote:

loaderUtils.parseQuery() will be deprecated in favor of getOptions() in
the next major version of loader-utils. The call should probably be
replaced.
See: webpack/loader-utils#56
https://github.com/webpack/loader-utils/issues/56
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ethul/purs-loader/issues/92, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVYy0YAQMOyAA8jBQBdhcR6YPmQuz7nks5rvzhggaJpZM4M9l3B
.

Closed by #86


How to make the next button (without disabling it) not allow to go to the next step until the form inside a step is valid?

Hi! I am sorry to bother...
I am using react-dynamic-stepper and in step 2 in the content I have a form in a different component with React-Boostrap like that:
    const [ form, setForm ] = useState<any>();
    const [ valuesForm, setValuesForm ] = useState<any>();
    const [ isSubmit, setIsSubmit ] = useState(false);

  const steps = [
    (...)
      {
        header: {
          label: TitleStep2,
        },
        content: <MyForm
                    isSubmit={isSubmit}
                    values={ valuesForm }
                    handleValues={(values: any, form: any) => handleValues(values, form)}
                  />,
        isComplete: true,
        isError: isSubmit && !form?.checkValidity(),
        onClickHandler: () => { handleSubmit() }
      },
  (...)
}];

How can I make the next button (without disabling it) does not let us go to the next step until the form is valid?
I try with this function in stepper component but I dont know if I can avoid that the stepper goes to next page when the form is not valid:
 function handleSubmit(){
      setIsSubmit(true);
      if( !form?.checkValidity() )
      {
        //TODO: how avoid the stepper goes to next step?
        return;
      }
    }

Thank you so much and I am sorry to bother again.

I wouldn't recommend using JS to solve issues in react, we can do it the react way by following the next steps:
Parent component

Create a new state to update form validity:

const [isFormValid, setIsFormValid] = useState(false);

Create a function which accepts a Boolean argument to update the new state:

const updateFormValidity = (isValid: boolean) => {
    setIsFormValid(isValid);
  };

Update isComplete of the required step and pass the created function as a prop to the child component:

const steps = [
    (...)
      {
        header: {
          label: TitleStep2,
        },
        content: <MyForm
                    isSubmit={isSubmit}
                    values={ valuesForm }
                    handleValues={(values: any, form: any) => handleValues(values, form)}
                    updateFormValidity={updateFormValidity}
                  />,
        isComplete: isFormValid,
        isError: isSubmit && !form?.checkValidity(),
        onClickHandler: () => { handleSubmit() }
      },
  (...)
}];

Child component

Update the props interface to accept a function:

const MyForm = ({
  updateFormValidity,
  ...,
}: {
  updateFormValidity: (isValid: boolean) => void;
  ...,
}) => {

Add new useEffect to update form validity:

useEffect(() => {
    updateFormValidity(form.?.checkValidity());
  }, [form.?.checkValidity]);

I added a new flag step.footer.isPreventNextClick which will do that for you


On mobile version CrocDoc items won't display

Should be fixed by showing a download link when document returns with errors.

Show them as regular file links.


Remove gradient fill in Classic theme

In the Classic theme, the default disassembly view (PE Graph) has a gradient fill in each of the boxes. I find this gradient fill very distracting and unhelpful. Is there a way to remove it?
The Dark theme does not appear to have a gradient fill and it looks a lot better, but I have trouble using dark themes. The Classic theme has the best overall usability for me.

Unfortunately colors are impossible to get right for everyone. We plan to address this in version 1.2  #207 Please follow this ticket if you're interested.


Exeption thrown by glCreateVertexArrays

Exception thrown at 0x0000000000000000 in Sandbox.exe: 0xC0000005: Access violation executing location 0x0000000000000000.
At line: 31, at: OpenGLVertexArray.cpp.
This error throws on Debug and Release Windows runs.

check if your Card supports OpenGL 4.5 (I think) this is the minimum for this command. Had to adapt to lower OpenGL version for my Mac adaptation.

Yes, my card supports OpenGL 3.3. I need to change it.

But I change glCreateBuffers to glGenBuffers and glCreateVertexArrays to glGenVertexArrays. And all works fine. What gives to us using of new commands?

This error will be fixed in a future PR. Had this error earlier today as glfw is mismatched by openGL.
These hints will make sure that error won't be thrown in the future.


Docs: add warning about mismatching versions

Description
This PR extends the documentation adding the warnings concerning mismatching versions, both between liqo and liqoctl, and for the peering process.

Merging without running the code checks, as involving documentation only.


Save location by GPS #6

https://github.com/5calls/ios/issues/6
The primary logic that I have employed regarding whether to fetch with zip or latLong is that when a user sets zip or latLong, the other is deleted. So when a fetch is requested, the only non-nil value is passed along to the query. Additionally if both are nil, then the non-query url is passed along. This felt natural to do and less complicated than setting an order of preference or setting another key to indicate which to use. But definitely open to a different approach. I have confirmed that switching between location/zip as a user correctly returns the correct results based on last selected location/zip.

added CLLocationManager to EditLocationViewController
added "when in use" authorization to info.plist
IssuesContainerViewController

lookup the returned location
refactored setTitle
refactored updateWith for zipCode and for lat/long

updated IssuesManager to handle zip or latLong
updated `FetchIssuesOperation to handle zip or latLong

updated execute to append zip or lat long -- confirmed both work

Lastly, there are a few dinky cleanup commits. I would recommend the "squash and merge" option, or I can squash locally and push it up fresh, but i added the commits after I noticed small things sequentially after making the PR.

Just a point of feedback on commit messages, I don't think it's valuable to reference the branch name as the subject of each commit.  Here's a good article on why:  http://chris.beams.io/posts/git-commit/


Add yq version in docs

Adding yq version 3.3.0 that worked while following the installation steps as opposed to 4.x which had made a lot of changes which were incompatible

Below is outdated
KF_DIR refers to the Kubeflow directory, which is also confirmed in the docs a few paragraphs after this, and is different from the "management cluster directory" which the current wording on the doc says it is.

Good point @8bitmp3 I will make the wording clearer! Now that I read it side by side I think your suggestion makes sense.

Also, by "following the repository instructions", do you mean "follow the official installation steps" (https://github.com/mikefarah/yq#install)?

/approve
/hold
Please unhold when you feel ready to merge
/cc @joeliedtke

/approve
/hold
Please unhold when you feel ready to merge
/cc @joeliedtke

/lgtm

/lgtm

/assign

/assign

Preview:
https://deploy-preview-2440--competent-brattain-de2d6d.netlify.app/docs/gke/deploy/deploy-cli/
https://deploy-preview-2440--competent-brattain-de2d6d.netlify.app/docs/gke/deploy/management-setup/

Preview:
https://deploy-preview-2440--competent-brattain-de2d6d.netlify.app/docs/gke/deploy/deploy-cli/
https://deploy-preview-2440--competent-brattain-de2d6d.netlify.app/docs/gke/deploy/management-setup/

/lgtm

/lgtm

/ok-to-test

/ok-to-test

/unhold

/unhold


[BUG 🐞] Warnings in console

Description

Upon updating the deps of this project to migrate from react 17 to latest react 18 along with Vite
App has been generating this warning message given below.
Please take necessary actions to remove this warning.

Screenshots

Additional information

This warning is visible only when we run the app locally using npm run dev.
Only push updates to deps-update not main branch.
Preview the latest deploy here.

Make sure to read the CONTRIBUTING and SETUP docs before proceeding
Happy contributing. 💐
Star my other Repositories here

Hi, i would like to contribute to this issue as a part of Hacktoberfest.

Assigning you, please work on it

Please fork the deps-update branch

@Priyankaa2503 Have you been able to progress in this?

Hi, i have raised a PR for this issue. Please do let me know if any further changes are required.


Windows episode

Also don't forget the DCO -- that is just putting a comment in the commit description: https://github.com/vmware-tanzu/tgik/blob/master/CONTRIBUTING.md

ok i added comments and did the signoff thingy !!!


Password required when updating user

Laravel Version: 5.4
Voyager Version: 1.0.1
PHP Version: 7
Database Driver & Version: MySQL 5.6

Description:
"Please fill out this field" pops up when editing a user on the password field.
Steps To Reproduce:
Go to users, click edit, modify name field, click save, forces you to type in the password to save changes instead of keeping current password

Are you add custom validation for that field?

You need other validation logic for require password field or create your own controller.
If you dont want to create custom controller then you need validation like this
First check to show user id in edit bread with disabled atribute if you want.
Second validation for password field will be
{
    "validation": {
        "rule": "required_without:id"
    }
}

ie. If you create user there is no user id and password filed will be required , if you edit user password field is not required(already have a password in the database)

I'm using the stock User model. It should work out of the box

Hmmm in stock user databse there is no required password field.
I see that in databse/seeds/DataRowsTableSeeder.php
$dataRow = $this->dataRow($userDataType, 'password');
        if (!$dataRow->exists) {
            $dataRow->fill([
                'type'         => 'password',
                'display_name' => 'password',
                'required'     => 0, //PASSWORD NOT REUIRED
                'browse'       => 0,
                'read'         => 0,
                'edit'         => 1,
                'add'          => 1,
                'delete'       => 0,
                'details'      => '',
                'order'        => 4,
            ])->save();
        }

It should be required when adding a new user but not when updating the user

As @davodavodavo3 said, the BREAD configuration will apply to ALL pages/forms within Voyager.
At this point, I'm comfortable saying this is an issue with validation in your app, not one with Voyager.  If you need further assistance, please consider joining the Voyager or LaraChat Slack groups.


zh-trans: add content/zh/docs/concepts/workloads/controllers/replicationcontroller.md

add content/zh/docs/concepts/workloads/controllers/replicationcontroller.md

@xichengliudui 格式已调整～

@tengqm I have fixed it and thanks for your review.

@tengqm Thanks for your review, I have fixed it.

/lgtm
/approve


Race-Condition with certain EKS Addons

Description
If you choose to deploy an EKS addon that is of kind Deployment (e.g. coredns), it can lead to a race-condition where the node-group is not yet created and the Addon is waiting indefinitely to be deployed, ultimately leading to a TF timeout.
With kind DaemonSet Addons like-kube-proxy, this doesnt happen.
Versions

Module: 18.2.1

Reproduction
  cluster_addons = {
    coredns = {
      resolve_conflicts = "OVERWRITE"
      addon_version     = var.addon_coredns_version
    }
  }

|Error: unexpected EKS Add-On (tst-eks:coredns) state returned during creation: timeout while waiting for state to become 'ACTIVE' (last state: 'DEGRADED', timeout: 20m0s)
│ [WARNING] Running terraform apply again will remove the kubernetes add-on and attempt to create it again effectively purging previous add-on configuration
│
│ with module.eks.module.eks.aws_eks_addon.this["coredns"],
│ on .terraform/modules/eks.eks/main.tf line 221, in resource "aws_eks_addon" "this":
│ 221: resource "aws_eks_addon" "this" {

Additional context

https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/main.tf#L221-L238 doesnt have a dependency on the node-group creation, which can lead to this race-condition

duplicate #1801


Just a question

Maybe I'm missing something but...
The dataSource declaration seems to be a straight forward mapping from enum value to cell type which always have the same structure. I think it's possible to move that mapping to the CellsDeclarator (and CellDeclaration) like the code shown below. You just have to make sure the makeBinder function is called when you call the cell function. This would make the code cleaner and even more compact.
    enum CellDeclaration: Equatable {
        case outline(BindableCell.Type, Venue)
        case sectionHeader(BindableCell.Type, String)
        case review(BindableCell.Type, Review)
        case relatedVenue(BindableCell.Type, Venue)
    }

    struct Data: CellsDeclarator {
        var venue: Venue
        var reviews: [Review]
        var relatedVenues: [Venue]

        func declareCells(_ cell: (CellDeclaration) -> Void) {
            cell(.outline(VenueOutlineCell.self, venue))

            if !reviews.isEmpty {
                cell(.sectionHeader(SectionHeaderCell.self, "Reviews"))
                for review in reviews {
                    cell(.review(ReviewCell.self, review))
                }
            }

            if !relatedVenues.isEmpty {
                cell(.sectionHeader(SectionHeaderCell.self, "Related Venues"))
                for relatedVenue in relatedVenues {
                    cell(.relatedVenue(RelatedVenueCell.self, relatedVenue))
                }
            }
        }
    }

Yes! Code you suggested is apparently more compact, but it does 2 things at a time.

Transform Data into form suitable for collection.
Associates the elements with UICollectionViewCell subclasses.

IMO, these steps should be separated so that artifact of the first step is isolated from UIKit. As a result of the separation, we can test that CellsDeclarator creates [CellDeclaration] correctly like below.
// https://github.com/ishkawa/DataSourceKit/blob/b2d1dcc71c3ae1e4599291690c7e15f2b0733909/DemoTests/VenuDetailViewControllerTests.swift#L13-L32
func testEmptyRelatedVenues() {
    let venue = Venue(photo: nil, name: "Kaminarimon")
    let review1 = Review(authorImage: nil, authorName: "Yosuke Ishikawa", body: "Foo")
    let review2 = Review(authorImage: nil, authorName: "Masatake Yamoto", body: "Bar")

    let data = VenueDetailViewController.Data(
        venue: venue,
        reviews: [
            review1,
            review2,
        ],
        relatedVenues: [])

    XCTAssertEqual(data.cellDeclarations, [
        .outline(venue),
        .sectionHeader("Reviews"),
        .review(review1),
        .review(review2),
    ])
}

It's easy to write tests because [CellDeclaration] is just an alternative form of Data. If they have also things from UIKit, the test gets more complicated. I think ease of testing is more important than ease of writing view code.
The separation may seem to be weird if the 2 steps are written in the same place (like VenueDetailViewController in demo app). On the other hand, if view controller is separated into state and layout like MVVM, the separation is straightforward.

Ah, true, you are right.  Maybe support both? 🙂If the first item of the associated value is a BindableCell.Type then... I think you can get the associated value directly in Swift 4.2. If you do want to support older version, then you could use: https://github.com/evermeer/Stuff#enum

After some consideration, I found that it's possible to support both with following extension.
extension CollectionViewDataSource where CellDeclaration == CellBinder {
    // Add meaningless parameter to avoid error `Members of constrained extensions
    // cannot be declared @objc`, which is caused by collision to init() of NSObject.
    public convenience init(binderFromBinder: @escaping (CellBinder) -> CellBinder = { $0 }) {
        self.init(binderFromDeclaration: binderFromBinder)
    }
}

When we use CellBinder for CellDeclaration, enum CellDeclaration and binderFromDeclaration  can be omitted. In this case, The only thing to create data source is declareCells(_:) like below.
func declareCells(_ cell: (CellBinder) -> Void) {
    cell(VenueOutlineCell.makeBinder(value: venue))

    if !reviews.isEmpty {
        cell(SectionHeaderCell.makeBinder(value: "Reviews"))
        for review in reviews {
            cell(ReviewCell.makeBinder(value: review))
        }
    }

    if !relatedVenues.isEmpty {
        cell(SectionHeaderCell.makeBinder(value: "Related Venues"))
        for relatedVenue in relatedVenues {
            cell(RelatedVenueCell.makeBinder(value: relatedVenue))
        }
    }
}

Here's full difference between current demo and the new demo.
Existing style is still available, but I came to think that the new version is better for more people who don't need the separation. So I revised README in #7 to encourage people to use the new style for the first time.

Extremely awesome! I will play with it later today!

Just merged #7 and released it in 0.2.0!


Mistral Nemo 12B Checkpoints

According to some first reports, this new model works great. In case we have the time, it would be a nice model to add as it would fill the "multilingual" niche. (Some people have been asking about models for various non-English languages.) Not sure if Gemma-2 already fulfills that too though.

There is no modeling_*.py file in the repo.
And the config.json file looks pretty standard.
It can be just a matter of adding a config.
Update: there is a custom tokenizer - tekken.
So, yeah, might not be so easy 🙃.

In case we want to pursue this, some findings from Daniel Han:
My findings for Mistral NeMo 12b:

 EOS token is untrained in base - a bug?
EOS token is auto appended
3, 4096, not 5120 for Wq
Not Llama Tokenizer
Tools, FIM
Pad_token=10
1M max RoPE pos: new dynamic RoPE in🦥
@UnslothAI
saves 20GB VRAM

Longer notes:

 EOS token is untrained in the base model but trained in instruct - confirming with
@MistralAI
if this is a feature or a bug - could make finetunes break with NaNs and infinities. Mistral 7b does not have this issue. Only the embed_tokens, not the lm_head has this issue.

EOS token is auto appended. This can break finetuning and inference - collabed with
@xenovacom
to fix this quickly :)

3, Not 5120 for Wq but 4096 - HF transformers main branch already has a fix for this - please update transformers! Unsloth auto patches, so no need to update!

Not a Llama Tokenizer - was GPT2 Tokenizer, now generic PreTrainedTokenizer? Very interesting! Tokenizer compresses other languages more efficiently.

Support for tools & FIM (Fill in the middle tasks). Function calling, code completion etc.

Pad_token=10 . A dedicated pad token - yay! Finetuning can break less with fewer infinite outputs :)

1 million possible position embeddings - had to support dynamic sizing of Cos & Sin cached matrices to not go OOM (used 20GB!)

More details in our blog: https://unsloth.ai/blog/mistral-nemo
Our free Colab notebook can finetune 12b in a free 16GB Tesla T4 GPU exactly, and can do it 2x faster and use 60% less VRAM than HF+FA2! https://colab.research.google.com/drive/17d3U-CAIwzmbDRqbZ9NnpHxCkmXB6LZ0?usp=sharing
We also have a Kaggle notebook making finetuning 2x faster: https://kaggle.com/code/danielhanchen/kaggle-mistral-nemo-12b-unsloth-notebook


Configuration documentation is inaccurate

Thanks for @TrevorBramble for raising https://github.com/errorstudio/contentful_model/issues/13 - actually this is a README bug on this project.

@edtjones :+1: Thanks!


Update code base to new package structure

The new package moves main.go to cmd/commento/main.go, this in turn changes a bit of functionality of the application and has brought about several issues.
I'll just group some of the things I think we need to fix here instead of opening multiple issues. Feel free to append to this list.

[ ] Broken build; the application no longer compiles

[ ] Fix compile & any runtime errors

[ ] Crufty/bulky main.go: the main.go file in cmd should essentially be a light wrap for the cli app

[ ] remove /lib: the go code should be at package level ( atdac/commento)
[ ] remove the dot import and import actual package ("github.com/adtac/commento")
[ ] move the server logic from main.go to the package essentially http.go and use an exported function eg Serve from main

[ ] Misplaced assets / dbfile from binary launch location

[ ] handle changing into working directory from cmd, run os.Chdir("../..") in main before starting (e.g func init

Please:  Don't push/merge if the application does not at least go build

Closing as the project structure reverted


Desktop version

Noto will have a desktop version after it supports storing notes in the cloud.
If you have any thoughts or ideas about this, please let me in the comments.

Hi @alialbaali
I think when it comes to cloud support, Noto will introduce a paid version which could be "Noto Cloud". Before we go there, I believe Noto could follow what Joplin does

You can implement a desktop version and offer support for LAN sync (Syncthing). In addition, you could also support other third party cloud providers too. Basically, the first step could be to provide a desktop version which could increase your user base and then support cloud services one by one.
This is just a suggestion and my personal opinion. I really like this app. I would really appreciate if you could provide a desktop version.
Thanks for your efforts 🙏

This is definitely something I've thought about, but for now, I'll leave it until cloud support is done.

Any updates on the Desktop version ?
Even an offline-only port of Noto on Windows (and other systems) would be amazing. Adding sync feature and cloud services could be gradual and come later when sync implementation is mature enough.


Sample Issue by Non maintainer

Sample description non maintainer

@issue-assigner claim

@issue-assigner claim

@issue-assigner abandon

@issue-assigner claim

@issue-assigner abandon

@issue-assigner claim


Add support for shooting a laser when Stroheim is in laser eye mode

Laser and eyes introduced in #21

The laser entity will also need to be created but the assets are in #21


[refactor prompt] Add support for config group pt1

What current issue(s) does this address, or what feature is it adding?

Supports https://github.com/CityOfZion/neo-python/issues/623

Adds support for the first five commands in the config group including, output, sc-events, sc-debug-notify, vm-log, and node-requests.

How did you solve this problem?
Trial and Error
How did you make sure your solution works?
Personal Testing and make test
Are there any special changes in the code that we should be aware of?
No
Please check the following, if applicable:

[x] Did you add any tests?
[x] Did you run make lint?
[x] Did you run make test?
[x] Are you making a PR to a feature branch or development rather than master?
[ ] Did you add an entry to CHANGELOG.rst? (if not, please do)

Coverage increased (+0.3%) to 85.208% when pulling dcfdffbc4ac0abadf9695e2fb3ec27ab60476e6d on jseagrave21:config-group-pt1 into 9f9b1fe176df821a8a22c68e33ab23b28d05135a on CityOfZion:refactor-prompt.

See the comments for most things. One small remark regarding config.py. In the future please use git mv to rename a file instead of deleting and recreating. That way it will preserve the history. It's not a big deal now, but would be better in the future

Thank you for the feedback. I figured there was a better way but I didn't know 😊

Awesome! We're going fast like this :)


report pytest coverage to codecov

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@c833f0b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   93.93%
=======================================
  Files           ?       15
  Lines           ?      989
  Branches        ?        0
=======================================
  Hits            ?      929
  Misses          ?       60
  Partials        ?        0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Simple avro handle key only debug

What problem does this PR solve?

Issue Number: close #xxx
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

/test cdc-integration-kafka-test


Integrating coveralls.io.

Changes Unknown when pulling f098c7dfcddab4535d13c908326a3c16ac4a7652 on coveralls into ** on master**.

Changes Unknown when pulling 4789c81413e3deecfae252e1fa5ffca633cfc3f9 on coveralls into ** on master**.

Needs a review

@bd82 Great work!!


New hooks api suggestion / discussion -- inspectHook() and setHookState()

With current enzyme api, usually we have to get / set hook state from rendered output (e.g. print state in rendered div / setCount on button).  it's hard to check and change current hook state value through enzyme API (like .state() and .setState() for class component.). Though some (or lots of ?) people may think it's testing implementation detail, I think it's still valuable to have an api to get / set the result of hook state.
There are two new apis I'd like to suggest. Hope to get some more feedbacks :-)
inspectHook()
The first is inspectHook() -- an api to get the whole hook stack tree in current function component node. In fact inspectHookWithFiber() is an api name from the react-debug-tool in React's internal packages for hook testing, and I'd like to port this module into enzyme.
With inspectHookWithFiber() then we can get the whole hook stack tree in a render function and write test like this. The tree currently has the following structure
// from source code of above link
type HooksNode = {
  id: number | null,
  isStateEditable: boolean,
  name: string,
  value: mixed,
  subHooks: Array<HooksNode>,
};

we can get the state from value, hook function name from name, and subHooks (sub hooks called in this hook) in subHooks.
In fact in react-devtool they also get current hook state value with it after some tweaks.
use cases
Basically the use cases would be similar to the tests in react-debug-tools. The following use case is an example of inspectHook() in enzyme; For such simple test case the better way to test the counter may be just find() the
 and assert the count, though. :

function Counter() {
  const [count, setCount] = React.useState(0);
  const increment = () => setCount(prevCount => prevCount + 1);;
  return (

      <button onClick={increment} />

{count}

  );
}

const wrapper = mount(<Counter />);
const tree = wrapper.inspectHook();
expect(tree[0].value).toEqual(0);
ReactTestUtils.act(() => wrapper.find('button').prop('onClick')());
const nextTree = wrapper.inspectHook();
expect(nextTree[0].value).toEqual(1);

Note that not only useState() will be in the tree returned from inspectHook(); All hooks called in the function component will be logged, if it's a hook with state the value will be the state, or it would depends on what the hook is.
limitation
With this way we can get the state of hook, but we cannot get the returned value of hook calls. So it's still not possible to get the seState returned from useState(), or dispatch() from useReducer(), or returned value from custom hook in this way.
Also I'm not sure if it's doable in shallow() since shallow renderer is not based on fiber.
implementation

given a wrapper of single functional component node, find its relative fiber node.
pass it into inspectHookOfFiber() which we bring into enzyme and return the result.

As for porting inspectHookOfFiber(), we have to get the hook dispatcher in react secret shared internals in enzyme. In react-devtool they have their own way to communicate with React (React in fact inject the secret internal into the react-devtool to make it work). I'm sure we can get the secret internal through React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.
Though it works to use it directly, It's not a good idea to couple with that private internal. The alternative way may be add devtool hook in enzyme side and let the React inject the internal into enzyme. I'll try to look into this further more.
setHookState()
The second is setHookState() -- an api to set the state of hook and trigger the rerender. Like inspectHook() there's also an internal function in React called overrideHookState, which is injected into react-devtools here so you can edit the state value of hook in react-devtool. I'd also like to port this functionality into enzyme, too.
use case
The usage of overrideHookState in React is like this
    function Counter() {
      const [count, setCount] = React.useState(0);
      const increment = () => setCount(prevCount => prevCount + 1);;
      return (

          <button onClick={increment} />

{count}

      );
    }

    const renderer = ReactTestRenderer.create(<MyComponent />);
    expect(renderer.toJSON()).toEqual({
      type: 'div',
      props: {},
      children: ['count:', '0'],
    });

    const fiber = renderer.root.findByType(MyComponent)._currentFiber();
    const tree = ReactDebugTools.inspectHooksOfFiber(fiber);
    const stateHook = tree[0];
    expect(stateHook.isStateEditable).toBe(true);

    overrideHookState(fiber, stateHook.id, [], 10);
    expect(renderer.toJSON()).toEqual({
      type: 'div',
      props: {},
      children: ['count:', '10'],
    });

In enzyme we could find the fiber and handle the state update path (the 3rd arg) by ourselves. So the api only need to receive 2 arguments: id for the hook id, which is included in the tree node returned from inspectHook, and value for the changed value:

    function Counter() {
      const [count, setCount] = React.useState(0);
      const increment = () => setCount(prevCount => prevCount + 1);;
      return (

          <button onClick={increment} />

{count}

      );
    }

    const wrapper = mount(<Counter />);
    const tree = wrapper.inspectHook();
    const stateHook = tree[0];
    expect(stateHook.value).toBe(0);

    wrapper.setHookState(stateHook.id, 10);

    expect(wrapper.find('p').text()).toEqual('10');

implementation
To port the overrideHookState it looks like the only way is to let React inject devtool internal into it. I think we could build a same global hook as react-devtool before import React, but I haven't tried it yet nor known if we can always ensure React injects internal after we install the hook.
If it's doable then the remaining work is as same as inspectHook -- find the fiber node and call overrideHookState to get the result.
Planning
If these sound good, I'd like to work on this with following steps:

Port inspectHookOfFiber into enzyme, with hard-coding secret internal (i.e. directly use React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED), and prove that we are able to add .inspectHook() in enzyme.
Try to add a devtool hook in enzyme so we don't need the hard coding internal.
if (2) works then building setHookState() should be relatively easy.

Also note that https://github.com/facebook/react/pull/14906#issue-254828738  said that react-debug-tools should be released soon. Once it's released we can just use inspectHookOfFiber() without porting (But might still need to build a devtool hook for overrideHookState). I'll also open an issue to request the releasing if new apis are desirable. It also might be good to start work after React releasing this.
And I'm not sure if it's what enzyme maintainers / users want. So feedback are welcome :-)
Related old discussion / PR in React / react-devtool: https://github.com/facebook/react-devtools/pull/1272 https://github.com/facebook/react/pull/14906

(related to #2011)
Thanks for filing this; this is as good a place as any to discuss it.
I think that before any hook-specific APIs are added to enzyme, we'd need to finish shipping full hooks support in existing APIs - ie, wrapping components with hooks should work as you'd expect them to work.

Thanks for reply @ljharb . I agree that hooks supports for existing API is important :-) I'd also be back to finish remaining tests in #2011 recently.
And I saw people (e.g. #2012 ) try to set state of hooks with enzyme. I guess some people (include me) test hooks with enzyme even though enzyme doesn't officially support hooks and expect some ways to get / set hooks more directly. So maybe it's still worth to discuss this even when we haven't finished all the hooks tests / bugfix for existing apis. I'd like to get some feedback around the proposal and just curious to know if you have any opinion on that :-)

If it is actually possible to get at the hook information equally in both shallow and mount, at any level in the tree, that seems interesting. However, I'd want to get the opinion of the react core team before adding such an API - since if react 17 is going to make it impossible to get this info, it's not worth adding now.

Looks like there are 2 things we could do:

File an issue in React to track the release of react-denug-tools -- If they'll publish this, then we can make sure we can leverage inspectHook safely. Also we can try to ask for including overrideHookState in react-debug-tools, or at least make sure we can safely use it through devtool hook.

Look into if we could also get / set hook state in shallow renderer in other way.

I'll open an issue in React today or tomorrow :-)

According to [react core team's reply(https://github.com/facebook/react/issues/15624#issuecomment-491649500) it looks like that:

They're planning to release react-debug-tools, but it's still possible to be private.
There's no plan to provide any way to set hook state. Devtool hook is for devtool only.

So maybe in the future it is possible to have inspectHook; There should be no safe way to build setHookState since we could not leverage overrideHookState.


add rbx-2.71828182

scraped via ruby-build-update-defs plugin

:+1: Thanks!

Uhhh what version of rbx is that? Is it smaller or larger than rbx 2.8?

It's larger than rbx 2.8

According to this post
http://rubinius.com/2015/09/22/major-minor-maximize-delivering-features-minimize-trouble/
it was supposed to be the last 2.x release. I don't know if that ended up
being true or not.
On Feb 1, 2016 8:34 PM, "SHIBATA Hiroshi"<EMAIL_ADDRESS>wrote:

It's larger than rbx 2.8
—
Reply to this email directly or view it on GitHub
https://github.com/rbenv/ruby-build/pull/901#issuecomment-178298014.


Implemented expiration for cw1-subkeys contract

There is one edge case which is not clean - what to do, when previous allowance is expired, but no new allowance is set. There are two reasonable solutions:

treat previous expired allowance as no allowance, so missing allowance in IncreaseAllowance in such case would just set expiration to Expire::Never {} as it is default expiration for new allowances. This feels natural, but might cause dangerous usecase: if transaction was scheduled before previous allowance expired, then probably he expected it not to change, but it would change, if transaction would be validated to late (and it would be never expiring)
behave, as it would be setting allowance which is already expired - return an error - this seems to be way more reasonable

This obviously doesn't impact decreasing allowance, as decreasing non existing allowance is always an error (nothing to decrease).

I just somehow missed is_expired method - I have no idea how, I would replace all occurrences.


drawThumbsApart

Hi
I am having two thumbs with the property set to drawThumbsApart as true and they don't overlap which is correct behaviour.
Why do I get the same value for the both thumbs at the point where they can't overlap? I don't want to use the the stepsThumbsApart property. Can't I get the correct values just by setting the drawThumbsApart to true only?
Best regards

I am not sure I understand what you want to achieve exactly. Can you explain please.
Anyway what you have with 'drawThumbsApart' property is the expected behavior, i.e. the thumbs will never be on to of each other, but they may have the same values. This is done so that you can set value X to thumb1 and thumb2 and still be able to see the two of them.
However if you want to keep thumb1 and thumb2 apart and they can never have the same value then you should use 'stepsThumbsApart' property.
Simply 'drawThumbsApart' is for visual appearance, while 'stepsThumbsApart' is for the thumb values


ImportError: No module named binstar_client.scripts.cli

>>binstar
Traceback (most recent call last):
  File "/usr/bin/binstar", line 4, in <module>
    from binstar_client.scripts.cli import main
ImportError: No module named binstar_client.scripts.cli

binstar                   0.4.4                    py27_1

I had the same error. Since, binstar is changed into anaconda-client, removing and re-installing anaconda-client, fixed the error for me.


don't log debug messages on client

should probably avoid console.log on client side

Agree. Do you have any suggestion on logging packages so that it will get rid of the logs when we build the production package?


Feature/settings page

Description text cuts off on 1024px viewport width.

@pajter I removed the max height of the settings description. It shouldn't cut off now

@ChristiaanScheermeijer the user-icon has been removed

Breakpoint of buttons not working on mobile

Breakpoint of buttons fixed. A css class was not written correct

Vertical alignment of the slider navigation is a bit off.

@pajter The same shelf components are used all over the site and I didn't change anything. I will discuss with the designer if this was intended. I guess not but I'll ask to be certain.

@brniamut Looks good now, thanks! 👍


Create STACK programs in Python

Made necessary changes.
i couldn't find any indentation bugs, if it still exists could you please specify where you found it. 👍

thank you for your contribution 👍

@ashwek  the indentation is perfect , cause if it was not the compiler will give errors. So i didnt see any problem in it. keep on contributing and encourage your friends too. Thank you 💯 🥇


Undocumented django.raven_compat.middleware.SentryLogMiddleware

It's not in the Django docs but it seems useful for finding the request in every call to raven rather than just those in the top level django exception handler.
Should it be documented, or is it an unsupported/experimental/custom feature?

FWIW, @dcramer mentioned SentryLogMiddleware last year as a way to "magically" send request data "without having to manually bind the request."
It looks like it was introduced way back in Sentry 1.6.2.
(It looks really useful; I'd also be interested in seeing it documented if it's not problematic.)


cursorWordLeftSelect not working on macOS

Type: Bug
Hello,
Using a fresh VS Code install on my 13" 2020 Intel MacBook Pro running Monterey 12.5, pressing shift+alt+left or right arrow to select a full word does not work.
Looking at the keyboard shortcuts of VSCode, it should trigger the cursorWordLeftSelect function. It doesn't work anywhere in VSCode, neither in the editor nor in any other text field.
No other software is intercepting the shortcut, which works in all other applications on my MacBook.
VS Code version: Code 1.70.1 (Universal) (6d9b74a70ca9c7733b29f0456fd8195364076dda, 2022-08-10T06:09:06.916Z)
OS version: Darwin x64 21.6.0
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz (8 x 2000)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
4, 4, 3

Memory (System)
16.00GB (0.26GB free)

Process Argv
--crash-reporter-id 5a0dbdc2-34a4-40b0-a5fa-5b2f4c791601

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

volar
Vue
0.40.1

vscode-typescript-vue-plugin
Vue
0.40.1

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
wslgetstarted:30449410
cppdebug:30492333
pylanb8912:30545647
vsclangdc:30486549
c4g48928:30535728
hb751961:30543456
dsvsc012cf:30540253
azure-dev_surveyone:30548225

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Let's first try to find out what command executes on your machine, with your settings and your keybindings when pressing shift+alt+left. Could you please try the following:

Run the command Developer: Toggle Keyboard Shortcuts Troubleshooting
This will activate logging of dispatched keyboard shortcuts and will open an output panel with the corresponding log file.
Press exactly the keybinding you desire.
check what VS Code detects and what command is invoked.

If you are having trouble understanding the output, please feel free to paste here and I can try to help.

Hi,
Thanks for the tip. Here's the result:
[2022-08-20 00:58:40.403] [renderer1] [info] [KeybindingService]: / Received  keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift
[2022-08-20 00:58:40.404] [renderer1] [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift')
[2022-08-20 00:58:40.405] [renderer1] [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
[2022-08-20 00:58:40.414] [renderer1] [info] [KeybindingService]: / Received  keydown event - modifiers: [shift,alt], code: AltLeft, keyCode: 18, key: Alt
[2022-08-20 00:58:40.414] [renderer1] [info] [KeybindingService]: | Converted keydown event - modifiers: [shift,alt], code: AltLeft, keyCode: 6 ('Alt')
[2022-08-20 00:58:40.415] [renderer1] [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
[2022-08-20 00:58:41.667] [renderer1] [info] [KeybindingService]: + Ignoring single modifier alt due to it being pressed together with other keys.

Not sure if it is of any help though 😕

Thank you for the extra information. It looks like shift+alt+left is not reaching VS Code, therefore it cannot be dispatched by us to execute cursorWordLeftSelect. Usually this happens when the OS is configured to do something on that particular keybinding or when there is some other software installed on the machine which listens globally on that keybinding. Unfortunately, there is nothing we can do on our side.

Hi Alex,
It's not the case, please reopen: on a mac, shift+alt+left (or right) is a native feature which selects the whole word whatever the software (just like pressing left moves the focus by one letter).
It works on all the softwares of all the macs I've used, and it does not work in VSCode whatever the mac. I have double checked my shortcuts, I have no override (and if I had such, shift+alt+left would never work, whatever the software).


Add Support for policyController to manage alert Condition types

WIP: This PR adds support to create alert conditions from the policy controller

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: thande:x: monkeyherderYou have signed the CLA already but the status is still pending? Let us recheck it.


Performance improvements

Description
This should go a good way to fixing https://github.com/FHIR/GoFSH/issues/133. There are always more improvements to make, so I'm not sure we want to call that issue closed, but this PR addresses that issue.
It seems that the bottleneck was the getFSHValue function, which would be called and do some expensive operations for every path on an instance. This PR improves the performance by doing a few things:

Add a cache so that a certain path on a given resourceType only has to be looked up once, and after that we just use the cached value for the type of the element at that path.
Process the flattened instances as an array of key, value pairs instead of as an object. This lets us take advantage of the fact that we know all keys representing a nested (contained or on a Bundle) instance are going to be in sequence in the array. So now we can processed nested instances faster, which is helpful since large Bundles are the main cause of performance issues.
Move the fishForFHIR and findElementByPath functions so they are only called if necessary.

Testing
The best way to test this is to use a very large IG. I used the one referenced in the original issue: https://github.com/HL7/UTG/commit/208a5ab7c79a12373fcbd46f7c50b480d4070b46. My results were that on this branch processing this IG took about 9 minutes, where on master it took about 55 minutes. Hopefully a similar improvement is seen across different machines. Then it is also important to test that the resulting FSH is not changed by this PR compared to master. I did that by testing a few IGs, such as UTG, US Core, and mCODE.
Note
I've noticed that some of the optimizers now seem to be bottlenecks. Specifically the combine_coding_and_quantity_values optimizer took a while for me, so that is another area to look if we continue with performance improvements.

https://github.com/FHIR/GoFSH/pull/148/commits/8d117f20b0e165efa957e8b928771c7bc49f3340 should also improve performance a bit more in one of the slower optimizers, the combine_coding_and_quantity_values optimizer. For me it cuts the UTG runtime about in half, but results will obviously vary. But at the least you should be able to observe a significant performance improvement, and no results should change, but let me know if that is not the case.

Thanks for the comments @mint-thompson, https://github.com/FHIR/GoFSH/pull/148/commits/8d7d6c00be71d6e9efcf4b510f55e95b30d41f94 should address them!


How to replace storage / memory Nebra Outdoor Miner

Hi it appears Nebra is not able to assist with the plethora of issues I and others are having. Currently I have an internal server error showing on the diagnostics page and my miner is dead, I emailed Nebra 10 days ago and I have had no response.
I'd like to DIY and fix the issues I am facing myself. I'd like to know how I can change the storage and memory parts please.
Any guidance would be appreciated.

Apologies for the delay, Customer agent will get back to you soon. Please don't open new issue here.


Soundcloud download results in 401 error

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2019.11.22
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

youtube-dl https://soundcloud.com/irmiu/sync24-dance-of-the-droids --verbose                                                1 ✘ | miniconda3 Py | 15:13:39
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://soundcloud.com/irmiu/sync24-dance-of-the-droids', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.11.22
[debug] Python version 3.7.3 (CPython) - Linux-4.20.5-200.fc29.x86_64-x86_64-with-fedora-29-Twenty_Nine
[debug] exe versions: ffmpeg 4.0.4, ffprobe 4.0.4
[debug] Proxy map: {}
[soundcloud] irmiu/sync24-dance-of-the-droids: Downloading info JSON
WARNING: Unable to download JSON metadata: HTTP Error 401: Unauthorized
[soundcloud] irmiu/sync24-dance-of-the-droids: Downloading info JSON
ERROR: Unable to download JSON metadata: HTTP Error 401: Unauthorized (caused by <HTTPError 401: 'Unauthorized'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 627, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2237, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/home/bcardoen/miniconda3/lib/python3.7/urllib/request.py", line 531, in open
    response = meth(req, response)
  File "/home/bcardoen/miniconda3/lib/python3.7/urllib/request.py", line 641, in http_response
    'http', request, response, code, msg, hdrs)
  File "/home/bcardoen/miniconda3/lib/python3.7/urllib/request.py", line 569, in error
    return self._call_chain(*args)
  File "/home/bcardoen/miniconda3/lib/python3.7/urllib/request.py", line 503, in _call_chain
    result = func(*args)
  File "/home/bcardoen/miniconda3/lib/python3.7/urllib/request.py", line 649, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)

Description

Soundcloud extraction fails with latest version, see above test url.
I tested a randomly chosen url with same results.
Both play in firefox both logged in and in incognito.
Thanks for looking into this! (and amazing project btw)

2019-11-28 and 2019-12-25 versions result both on a 401 error still. Anyone experiencing this? @bencardoen

It's still not working for me either (2019.12.25), same error


False-positive body diff's

When asserting JSON responses, the output is useless:
expected { data: { objects: { pageInfo: [Object], edges: [Array] } } } response body, got { data: { objects: { pageInfo: [Object], edges: [Array] } } }

The issue is that one of the nested fields is missing in the response but it's impossible to understand it from the output.
Code to reproduce:
request(app.getHttpServer())
            .post('/graphql')
            .send({ query, variables })
            .expect(200)
            .expect({
                data: {
                    objects: {
                        pageInfo: {
                            endCursor: dateToBase64(obj.createdAt),
                            hasNextPage: false,
                        },
                        edges: [
                            {
                                cursor: dateToBase64(obj.createdAt),
                                node: omit(obj, ['createdAt', 'updatedAt']),
                            },
                        ],
                    },
                },
            });

Perhaps this could be improved by increasing the default depth used to diff those values.


bug:  when there are no symbols navigation window gives error

Neovim version (nvim -v)
Latest Master
Operating system/version
Arch Linux
Output of :AerialInfo

Describe the bug
If I run :AerialNavToggle on a buffer that doesn't have symbols I get:
Error executing Lua callback: ...ocal/share/nvim/lazy/aerial.nvim/lua/aerial/nav_view.lua:227: attempt to index local 'symbol' (a nil value)
stack traceback:
        ...ocal/share/nvim/lazy/aerial.nvim/lua/aerial/nav_view.lua:227: in function 'focus_symbol'
        ...ocal/share/nvim/lazy/aerial.nvim/lua/aerial/nav_view.lua:338: in function 'open'
        ...ocal/share/nvim/lazy/aerial.nvim/lua/aerial/nav_view.lua:346: in function 'toggle'
        ...local/share/nvim/lazy/aerial.nvim/lua/aerial/command.lua:124: in function <...local/share/nvim/lazy/aerial.nvim/lua/aerial/command.lua:123>

On the other hand :AerialToggle opens without an error (and simply reports that there are no symbols).
Steps To Reproduce
See above
Expected Behavior
Exit/ continue gracefully
Minimal example file

Minimal init.lua
-

Additional context
No response

Fixed. Thanks for the report!

Thank you!


Add link to layout standard / reference implementation.

It would be nice to document the link to keyboard standard / reference used in this implementation for each layout, which will serve as both attribution as well as will help check / fix bugs if any in both the places.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/3611941-add-link-to-layout-standard-reference-implementation?utm_campaign=plugin&utm_content=tracker%2F493413&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F493413&utm_medium=issues&utm_source=github).

issue moved to gitlab: https://gitlab.com/smc/indic-keyboard/issues/33


kernel: Predicate _cpus_active on CONFIG_PM

This value isn't used outside of the PM subsystem, so don't build it.
More important than the four bytes of .bss was the use of an atomic_inc().  Some platforms are forced to use
CONFIG_ATOMIC_OPERATIONS_C (but in almost all cases are single-core devices that won't use atomics at runtime).  There, this turns into a function call that pulls in the whole atomics implementation.

Tiny patch.  Systems that lack atomics can use the "_C" variant based on masked interrupts, but in practice they don't actually want to and would prefer that nothing use the atomics layer at all.  But it turned out that this spot in the kernel was (usually needlessly) pulling the whole library in.   Do it only when we need it.
Note that this could also be predicated on SMP, but obviously all SMP platforms will pull in atomics anyway (e.g. for spinlocks), so there's no win there.

Sneak Flavio in as assignee since it's a PM thing


Need more clarification about the Necessity of <virtual-machine-region-name>.handler.control.monitor.azure.com in the scenario of using PE and DCE

Hi PG,
When AMA uses PE and DCE, does AMA needs to access <virtual-machine-region-name>.handler.control.monitor.azure.com?
This doc mentions:

If you use private links on the agent, you must also add the data collection endpoints (DCEs). The Azure Monitor Metrics (custom metrics) preview isn't available in Azure Government and Azure China clouds.

So this sentence means that the following URLs are requirement in the scenario of using PE.

global.handler.control.monitor.azure.com
<virtual-machine-region-name>.handler.control.monitor.azure.com
<log-analytics-workspace-id>.ods.opinsights.azure.com
<unique-dce-identifier>.<regionname>-1.handler.control.monitor.azure.com
<unique-dce-identifier>.<regionname>-1.ingest.monitor.azure.com

But in my understanding, AMA accesses only <unique-dce-identifier>.<regionname>-1.handler.control.monitor.azure.com and doesn't access <virtual-machine-region-name>.handler.control.monitor.azure.com in the scenario of using PE.
If my understanding is correct, I would appreciate if you update this doc to not confuse customers?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 14a66a45-7f5b-b9c4-c675-bd2cc963b44d
Version Independent ID: 253cc884-5a70-c313-67c7-68f42b6e44c3
Content: Define Azure Monitor Agent network settings - Azure Monitor
Content Source: articles/azure-monitor/agents/azure-monitor-agent-data-collection-endpoint.md
Service: azure-monitor
Sub-service: agents
GitHub Login: @guywi-ms
Microsoft Alias: guywild

@kongou-ae
Thanks for your feedback! We will investigate and update as appropriate.

@shayoniseth, can you please have a look at the raised by @kongou-ae and advise? Thanks!

This is somewhat captured by the line at the bottom of the generic table, saying user must add DCE endpoints, but I agree that it could be confusing.
When using DCE and PE, AMA only uses the DCE endpoints and not the generic ones. We will clarify this further in our docs

Here's a PR further clarifying this: https://github.com/MicrosoftDocs/azure-docs-pr/pull/236442

@shayoniseth
Thank you for your reply and quick fix.

Thanks again for your feedback, @kongou-ae, and for your quick response, @shayoniseth 🥇
#please-close


MvcReportViewer control ID is missing

Running the code below I get an error: MvcReportViewer control ID is missing
return this.Report(ReportFormat.PDF, "/Naviva/Acceptatie/Reports/Sjablonen/Factuur", new { factuurnummer = nummer });
It's a remote report

Version MvcReportViewer 0.5.2, which hasn't the localreport option, works with the code above.

Thank you for the report. I have already fixed the issue in the repository. You can download the code and use your custom build. I am going to release NuGet package in a day or two.

I have released v.0.6.2. You can test the fix now.

Hi IIya,
I want to say thanks for the quick response and fix. I'll test the fix tomorrow.
Best regards,
Wouter

Op 31 mrt. 2015 om 18:41 heeft Ilya Verbitskiy<EMAIL_ADDRESS>het volgende geschreven:
I have released v.0.6.2. You can test the fix now.
—
Reply to this email directly or view it on GitHub.


[meson] remove meson

This PR contains three commits that remove meson from the src tree, making Bazel the only supported build system for OpenTitan.
Commit 1: removes all meson.build files in favor of using Bazel as the OpenTitan build system.
Commit 2: removes meson.build templates used by various code autogen tools
Commit 3: removes various references to meson from several tools and code comments throughout the repository
This fixes #12449.
Note: a follow on PR updates the website documentation to reflect this change.

If you grep (case-insensitively) for "meson" you still find various places where Meson should be removed. AFAIK, GitHub doesn't allow you to comment on unchanged files so it's not very convenient to reference all of those places here but grepping will find them easily. Things like this:
.bazelignore
5:# TODO: once Meson is no longer used, remove the line below.

If you grep (case-insensitively) for "meson" you can still find various places where Meson should be removed. AFAIK, GitHub doesn't allow you to comment on unchanged files so it's not very convenient to reference all of those places here but grepping will find them easily. Things like this:
.bazelignore
5:# TODO: once Meson is no longer used, remove the line below.

That was the plan all along hehe but looks like I missed some, thanks!
(Additionally some are addressed in the follow PR #13157, and other stragglers have issues tracking them, i.e., #12504 and #11743, and will be cleaned up in follow on PRs if thats alright?)

(Additionally some are addressed in the follow PR #13157, and other stragglers have issues tracking them, i.e., #12504 and #11743, and will be cleaned up in follow on PRs if thats alright?)

Is it within the scope of this PR to remove util/get-toolchain.py? My understanding is that it's not needed with Bazel, I don't know if people have other uses for it.
This one also looks like it might have been overlooked:
util/lowrisc_misc-linters/licence-checker/licence-checker.py
152:    (["meson.build", "toolchain.txt", "meson_options.txt"], HASH),  # Meson

Is it within the scope of this PR to remove util/get-toolchain.py? My understanding is that it's not needed with Bazel, I don't know if people have other uses for it.

So I think this is still nice to have (and the updated SW docs still reference using some of the tools for things like disassembling and using GDB) as we don't have Bazel flows for things like launching a GDB debug session with the Bazel managed toolchain yet so I get kept this for the time being.

This one also looks like it might have been overlooked:
util/lowrisc_misc-linters/licence-checker/licence-checker.py
152:    (["meson.build", "toolchain.txt", "meson_options.txt"], HASH),  # Meson

Ah, I originally had removed these lines, but then CI failed as it looks like this script is vendored in. So I will need to have a follow on PR in the other repo that stores this tool and one in this repo that re-vendors in the updated script. Tracking this in #13169.


update note about root certificate

#5656

Dear @mapalko ,
could you please review this PR?
Thank you

( Just in case you want ask the doc PM for a review, see doc reference below. )
---
title: Configure Hybrid key trust Windows Hello for Business
[ ... ]
author: mapalko
ms.author: mapalko
manager: dansimp
ms.reviewer:

I've asked one of our devs to review this for accuracy.

@MaratMussabekov Can you please follow up with the recent revision suggestions from the document author? Thank you.

#sign-off

@Dansimp The PR is ready to merge. Thank you.

@denisebmsft This PR had been approved by the document owner. Could you merge this PR as the time permits? Thank you.


Invalid top-level expression

I'm not sure if this is an issue created by newer versions of lib-sass or Ember CLI 0.2.1+ but I have been running into an issue where when trying to compile materialize I get a hangup error:
invalid top-level expression
Error: invalid top-level expression
    at options.error (/tmp/mat-test/node_modules/ember-cli-sass/node_modules/broccoli-sass-source-maps/node_modules/node-sass/lib/index.js:261:32)

After tracking this down it has to do with the comment on line 291 in components/_normalize that interrupts the selectors and have made a PR on materialize itself to hopefully fix this by moving the comment before the selector list.
However, I would like to bring up the question of why this new error is occurring?

Is it valid to have a comment in between selector declaration?
Are we correctly matching the spec

Basically for the betterment of SASS and Ember SASS I want to figure out if this is a fluke or if there needs to be clarification in a higher level project?
Pinging in @chriseppstein to talk SASS spec

Aside:
If you would like to compile materialize before the PR is hopefully closed you can replace your bower dependency with "materialize": "git@github.com:rtablada/materialize.git#bugfix/invalid-top-level-expression"

I just started hitting this one today as well.

For discussion, this is the code that throws the error:
button,
html input[type="button"], /* 1 */
input[type="reset"],
input[type="submit"] {
  -webkit-appearance: button; /* 2 */
  cursor: pointer; /* 3 */
}

Looks like the problem selector is valid even in regular CSS on the W3C validator so should this be addressed in the SASS spec or is this an error with the compiler?

I just tried this with "ember-cli-sass": "3.1.0" and things seem to work again.
I had 3.2.2 when i experienced this.  I think we should start locking down our dependencies to avoid things like this.

While I think locking down deps is definitely something to consider, we should also be aware of the cause of a regression (especially on a minor version release) and report things up to the proper repos.
I brought things here because it is a reproducible breaking bug and wasn't sure of the best course of action in terms of is this a libsass error, an ember-cli-sass error, or should materialize just move the comment.

Just an update, my PR to remove the conflicting comment has been merged on materialize.
I'm not sure when the next bower update will be pushed.

:thumbsup:

Good news.
@rynam0 it's hard to locking down when emberjs ember-cli it's moving so fast...
I think the latest ember-cli-sass works "better" with the latest ember-cli, then the latest ember-cli with an old ember-cli-sass.
But maybe I'm wrong...

I would agree with that.
We can lock to major versions but I think general consensus says addons should aim to be thin wrappers around existing libs just like ember-cli-sass aims to be a thin wrapper around broccoli-sass (btw it's turtles all the way down).
In this case I find that addons are a great way to find breaking changes for existing libs as well as new improvements in tooling like lib-sass.

Cool.

fwiw, removing the /* 1 */ comment fixes the issue.

We should close this issue now, as I included @rtablada's fix as part of #33. Once they tag a new release, I'll open a PR to get us back on numbered versions, but it works well in the mean time.
See: https://github.com/sgasser/ember-cli-materialize/blob/master/bower.json#L15


Enable static type checks for all modules

enable static type checks for all modules with mypy
add runtime type checks during tests with typeguard

:tada: This PR is included in version 4.2.2 :tada:
The release is available on:

v4.2.2
GitHub release

Your semantic-release bot :package::rocket:


Deflake dex tests

Install dex on the TestFaster k8s clusters when we're running an auth test bucket.

Btw as long as you are reasonably confident changes aren't making Travis work, I don't mind if you merge deflaking changes with failing Travis builds. Insisting on Travis being green for every single change will slow us down.