Fix structure of conf for LWFS methods

Includes:

clarification of parameters in SFS_config
add modal windowing for LWFS-SBL of a plane wave
remove dependency of LWFS-SBL on the parameters given conf.localsfs.wfs. This is done to be more consistent in the framework: conf.localsfs.wfs is used to specify the parametrisation of WFS as the driving function for the virtual secondary source distribution in LWFS-VSS. However, to synthesise each individual virtual secondary source (focused source) via WFS, the parameters in conf.wfs are used. If the plane wave decomposition created in LWFS-SBL is interpreted as a virtual secondary source distribution (of plane waves), then conf.wfs would also have to be responsible synthesis of each plane wave.

Maybe we should move conf.localsfs.wfs to conf.localsfs.vss.wfs to make this even more clearer? Same may hold for conf.localsfs.usetapwin and conf.localsfs.tapwinlen.

Your changes look good so far.
How to write this config section in a way that it is easy to understand seems to be challenging. I'm also not sure if I understand everything at the moment. Maybe I start with a few questions/remarks.

I guess conf.localsfs.vss.driving_functions defines the driving functions that will be used to drive the virtual sources (belonging to conf.localsfs.wfs) not to generate them. Then it would be indeed better to rename conf.localsfs.wfs to conf.localsfs.vss.wfs and so on.
On the other hand conf.localsfs.vss.wfs has again entries and would become very long. Maybe we could rename conf.localsfs.vss.driving_functions to conf.localsfs.driving_functions?
I think in general we should add a description at the beginning of this config section explaining, which setting is for the generation of the virtual sources and which setting is for the driving of the virtual sources.
At the moment conf.localsfs.method can be 'wfs' or 'nfchoa', but we have only conf.localsfs.wfs not conf.localsfs.nfchoa. Might it be possible to solve this by allowing for conf.localsfs.method = conf.wfs?

I guess conf.localsfs.vss.driving_functions defines the driving functions that will be used to drive the virtual sources (belonging to conf.localsfs.wfs) not to generate them.

Yes, that's correct.

On the other hand conf.localsfs.vss.wfs has again entries and would become very long. Maybe we could rename conf.localsfs.vss.driving_functions to conf.localsfs.driving_functions?

Maybe it would be a good idea to rename the localsfs to something else, because it does not match the actual name of the LSFS methods in the function call, e.g. driving_function_imp_lwfs-sbl or driving_function_imp_lwfs-vss . Off course, this would require to different entries for lwfs-vss and lwfs-sbl, but the two methods do not have very much in common in terms of configuration.

I think in general we should add a description at the beginning of this config section explaining, which setting is for the generation of the virtual sources and which setting is for the driving of the virtual sources.

Yes, agree.

At the moment conf.localsfs.method can be 'wfs' or 'nfchoa', but we have only conf.localsfs.wfs not conf.localsfs.nfchoa. Might it be possible to solve this by allowing for conf.localsfs.method = conf.wfs?

Yes, this one is still missing and is supposed be covered by this pull request.
A suggestion covering most of the issues could be:
% === LSFS using Virtual Secondary Sources (LSFS-VSS) ===
conf.lwfs-vss.size = 0.4;
conf.lwfs-vss.center = [0, 0, 0];
conf.lwfs-vss.geometry = 'circular';
conf.lwfs-vss.number = 56;
conf.lwfs-vss.grid = 'equally_spaced_points';
conf.lwfs-vss.method = 'wfs';
conf.lwfs-vss.wfs = conf.wfs;
conf.lwfs-vss.usetapwin = false;
conf.lwfs-vss.tapwinlen = 0.5;
conf.lwfs-vss.nfchoa = conf.nfchoa;
conf.lwfs-vss.driving_functions = 'default';

% === LSFS using Spatial Bandwidth Limitation (LSFS-SBL) ===
conf.lwfs-sbl.order = [];
conf.lwfs-sbl.fc = [];
conf.lwfs-sbl.Npw = [];

As both methods have indeed not much shared configuration it makes sense to rename localsfs. You are not allowed to use - inside a variable name. Also considering the method discussion from above it would then result in:
% === LSFS using Virtual Secondary Sources (LSFS-VSS) ===
conf.lwfs_vss.size = 0.4; % \ m
conf.lwfs_vss.center = [0, 0, 0]; % \ m
conf.lwfs_vss.geometry = 'circular'; % string
conf.lwfs_vss.number = 56; % integer
conf.lwfs_vss.grid = 'equally_spaced_points'; % string
conf.lwfs_vss.method = conf.wfs; % struct
conf.lwfs_vss.usetapwin = false; % boolean
conf.lwfs_vss.tapwinlen = 0.5; % 0..1
conf.lwfs_vss.driving_functions = 'default'; % string

% === LSFS using Spatial Bandwidth Limitation (LSFS-SBL) ===
conf.lwfs_sbl.order = []; % integer
conf.lwfs_sbl.fc = []; % integer
conf.lwfs_sbl.Npw = []; % integer

What still looks a little bit confusing is that we have the LSFS as title, but only lwfs in the configuration. Should we change the title to LWFS as well?

Yes, that was just copy&paste from the current SFS_config.m. We can adjust that. If you are okay with the structure, I will try to incorporate its into all functions etc.

I'm fine with the structure.

Cool, from my site that's it. I would do a clean up of the commits by some squashing and then merge this.
Or do you want to add more changes?

No


fix: fork app button not opening the fork modal for non-signed in users

Description
When the fork button was clicked on by a non signed in user, after redirecting to the same page after sign up the fork modal wasn't being displayed. This was because the component did not exist in the header as in there is no route defined for the fork app url. The fix is to just add the route for the same.
Fixes #11745
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Cypress test
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/fork-button

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
55.72 (0)
37.16 (0)
35.46 (0.02)
55.98 (0)

:green_circle:
app/client/src/actions/applicationActions.ts
74.55 (1.82)
100 (0)
22.22 (5.55)
67.65 (2.94)

:green_circle:
app/client/src/constants/routes.ts
96.15 (0.15)
100 (0)
75 (8.33)
95.95 (0.12)

:green_circle:
app/client/src/pages/Applications/ForkApplicationModal.tsx
84.78 (1.45)
33.33 (1.51)
44.44 (6.94)
84.09 (1.59)

:red_circle:
app/client/src/utils/WorkerUtil.ts
89.76 (0)
70.59 (-1.96)
100 (0)
93.33 (0)

forkNonSignedInUser.json is over 6000 lines.
Can we use a smaller import file here ?

forkNonSignedInUser.json is over 6000 lines. Can we use a smaller import file here ?

Exported a forkable app and used it here. Will check if I can just update a flag in the json of a simple app to make it forkable.

/ok-to-test sha=c41bab1

/ok-to-test sha=330b638

/ok-to-test sha=c17c196


chore: refactor flag parsing

What this PR solves / how to test
Fixes #[insert GH or internal issue number(s)].
Author has addressed the following

Tests

[ ] TODO (before merge)
[ ] Tests included
[ ] Tests not necessary because:

E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)

[ ] I don't know
[ ] Required
[ ] Not required because:

Changeset (Changeset guidelines)

[ ] TODO (before merge)
[ ] Changeset included
[ ] Changeset not necessary because:

Public documentation

[ ] TODO (before merge)
[ ] Cloudflare docs PR(s):
[ ] Documentation not necessary because:

@petebacondarwin I have been experimenting with this idea because I think parsing the flags in the same way workerd does could help.
The validation will not work after this because, i.e. because
	if (hasNodejsCompatFlag && hasNodejsCompatV2Flag) {
		throw new UserError(
			"The `nodejs_compat` and `nodejs_compat_v2` compatibility flags cannot be used in together. Please select just one."
		);
	}

and hasNodejsCompatV2Flag could be implied
But
	if (noBundle && hasNodejsCompatV2Flag) {
		logger.warn(
			"`nodejs_compat_v2` compatibility flag and `--no-bundle` can't be used together. If you want to polyfill Node.js built-ins and disable Wrangler's bundling, please polyfill as part of your own bundling process."
		);
	}

is wrong because hasNodejsCompatFalg  should also error at least after 09-23
Probably all of the logic for mode, parsing flags and validating should live in a single file?

I feel this is over thinking the problem. The only reason we are doing any parsing of flags here is to decide whether to run build-time polyfilling (and which set of polyfills to run). If we didn't do that then we would not need to parse these flags at all.
The validation is only there to help the user avoid any footguns of colliding certain build-time polyfilling that is not really compatible with certain runtime modes.


Align SEO naming

Naming through the package should be same for SEO. Probably best to go with SEO as that is basically what everyone on the internet is using (https://developers.google.com/search/docs/beginner/seo-starter-guide) and it shows that it is an abbreviation for Search Engine Optimization.

Went through the project and I think I got the last few ones with this commit: https://github.com/patrickdemooij9/uSeoToolkit.Umbraco/commit/abcff17a05e8397c6e4d070d48de7916dab9fb84


Strip extra query parameters from Fastmail URLs

Here’s an example of the sort of URL I get for an individual message from Fastmail:
https://www.fastmail.com/mail/Inbox/1234699c12566789-f12345779u33488?u=12349bcd&domain=fastmail.fm
The message opens fine without the query string – if it’s not doing anything useful, let‘s get rid of it.

Closing due to inactivity.


Add debugger package root api.

For #11236

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[x] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #11464 into master will decrease coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #11464      +/-   ##
==========================================
- Coverage   61.03%   60.62%   -0.42%
==========================================
  Files         613      613
  Lines       33630    33510     -120
  Branches     4751     4727      -24
==========================================
- Hits        20527    20315     -212
+ Misses      12657    12187     -470
- Partials      446     1008     +562

Impacted Files
Coverage Δ

...ient/debugger/extension/adapter/remoteLaunchers.ts
100.00% <100.00%> (ø)

src/client/datascience/raw-kernel/rawKernel.ts
7.07% <0.00%> (-48.43%)
:arrow_down:

src/datascience-ui/react-common/arePathsSame.ts
75.00% <0.00%> (-12.50%)
:arrow_down:

src/client/common/utils/platform.ts
64.70% <0.00%> (-11.77%)
:arrow_down:

src/client/common/utils/async.ts
88.37% <0.00%> (-6.98%)
:arrow_down:

...ient/datascience/jupyter/kernels/kernelSwitcher.ts
85.52% <0.00%> (-4.62%)
:arrow_down:

...lient/datascience/jupyter/kernels/kernelService.ts
52.35% <0.00%> (-2.84%)
:arrow_down:

src/client/datascience/common.ts
97.22% <0.00%> (-2.78%)
:arrow_down:

...cience/ipywidgets/cdnWidgetScriptSourceProvider.ts
84.48% <0.00%> (-2.59%)
:arrow_down:

src/client/activation/node/languageServerProxy.ts
27.94% <0.00%> (-2.22%)
:arrow_down:

... and 155 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebfc9e7...75fd913. Read the comment docs.


Add has documentation check

This PR has a few commits:

ran go fmt and there were a few deltas, so wanted to start with a good baseline
it seems as though there were some manual changes added to enum.go, as well as being behind in the types. So, added lots of types + also fixed older types.
Added a section to the CONTRIBUTING.md just to point out that gen.go exists and how we should use it
*** Let me know if you want a separate PR for the above commits
Added the HasDocumentation Check

Relatively small change, but required updating a lot of fixtures. the graphql commands could probably be handled differently to alleviate the need to update all of the fixtures. I want to look into making a fragment to store all of the conditional fragments for each check, such that adding new checks only means updating the single fragment.

Went through the comments and:

fixed contributing.md: go run generate.go -> go generate
fixed the grapqhl types, the fragments now properly use the Enum types instead of string, and the enums us the json tag so that they are marshalled correctly.
removed the majority of the enum diff. I propsed to leave the CheckServiceDependency -> CheckTypeServiceDependency as I believe it is still correct (and it is only a simple small scope rename).

I believe go generate should be fixed such that we can idempotently call it to help us generate the types, but that may be a decent amount of work. I may take a quick crack at reworking the Check tests to not need to do the find + replace, but in a future PR.


WIP - Refactor Task usage to Instance

This change is

Review status: 0 of 131 files reviewed at latest revision, 25 unresolved discussions, some commit checks failed.

src/main/scala/mesosphere/marathon/api/v2/json/Formats.scala, line 120 [r1] (raw file):

    enumFormat(mesos.TaskState.valueOf, str => s"$str is not a valid TaskState type")

  implicit lazy val TaskWrites: Writes[Instance] = Writes {

s/TaskWrites/InstanceWrites/

src/main/scala/mesosphere/marathon/core/health/HealthResult.scala, line 7 [r1] (raw file):

sealed trait HealthResult {
  def taskId: Instance.Id

s/taskId/instanceId/

src/main/scala/mesosphere/marathon/core/health/HealthResult.scala, line 13 [r1] (raw file):

case class Healthy(
  taskId: Instance.Id,

ditto

src/main/scala/mesosphere/marathon/core/health/HealthResult.scala, line 18 [r1] (raw file):

case class Unhealthy(
  taskId: Instance.Id,

ditto

src/main/scala/mesosphere/marathon/core/health/impl/HealthCheckActor.scala, line 26 [r1] (raw file):

  var nextScheduledCheck: Option[Cancellable] = None
  var taskHealth = Map[Instance.Id, Health]()

s/taskHealth/instanceHealth/

src/main/scala/mesosphere/marathon/core/health/impl/HealthCheckActor.scala, line 94 [r1] (raw file):

            log.debug("Dispatching health check job for {}", task.id)
            val worker: ActorRef = context.actorOf(workerProps)
            worker ! HealthCheckJob(app, task.asInstanceOf[Task], launched, healthCheck)

?asInstanceOf needed?

src/main/scala/mesosphere/marathon/core/launcher/TaskOpFactory.scala, line 10 [r1] (raw file):

/** Infers which TaskOps to create for given run spec and offers. */
trait TaskOpFactory {

InstanceOpFactory? that "Infers which InstanceOp's..." ?

src/main/scala/mesosphere/marathon/core/launcher/TaskOpFactory.scala, line 25 [r1] (raw file):

    * @param additionalLaunches the number of additional launches that has been requested
    */
  case class Request(runSpec: RunSpec, offer: Mesos.Offer, taskMap: Map[Instance.Id, Instance],

instanceMap?

src/main/scala/mesosphere/marathon/core/launcher/TaskOpFactory.scala, line 28 [r1] (raw file):

      additionalLaunches: Int) {
    def frameworkId: FrameworkId = FrameworkId("").mergeFromProto(offer.getFrameworkId)
    def tasks: Iterable[Instance] = taskMap.values

instances?

src/main/scala/mesosphere/marathon/core/launcher/TaskOpFactory.scala, line 36 [r1] (raw file):

  object Request {
    def apply(runSpec: RunSpec, offer: Mesos.Offer, tasks: Iterable[Instance], additionalLaunches: Int): Request = {

instances?

src/main/scala/mesosphere/marathon/core/launcher/impl/OfferProcessorImpl.scala, line 5 [r1] (raw file):

import akka.pattern.AskTimeoutException
import mesosphere.marathon.core.base.Clock
import mesosphere.marathon.core.launcher.{ OfferProcessor, OfferProcessorConfig, TaskLauncher, TaskOp }

InstanceOp?

src/main/scala/mesosphere/marathon/core/launcher/impl/TaskLabels.scala, line 8 [r1] (raw file):

import org.apache.mesos.{ Protos => MesosProtos }

object TaskLabels {

InstanceLabels?

src/main/scala/mesosphere/marathon/core/launcher/impl/TaskLabels.scala, line 25 [r1] (raw file):

  }

  def labelsForTask(frameworkId: FrameworkId, task: Task): ReservationLabels =

instance: Instance ?

src/main/scala/mesosphere/marathon/core/launchqueue/impl/TaskLauncherActor.scala, line 89 [r1] (raw file):

  // scalastyle:on parameter.number

  private[this] var inFlightTaskOperations = Map.empty[Instance.Id, Cancellable]

inFlightInstanceOperations?

src/main/scala/mesosphere/marathon/core/launchqueue/impl/TaskLauncherActor.scala, line 95 [r1] (raw file):

  /** tasks that are in flight and those in the tracker */
  private[this] var tasksMap: Map[Instance.Id, Instance] = _

instancesMap?

src/main/scala/mesosphere/marathon/core/matcher/base/util/OfferOperationFactory.scala, line 39 [r1] (raw file):

  }

  def reserve(frameworkId: FrameworkId, taskId: Instance.Id, resources: Iterable[Mesos.Resource]): //

instanceId?

src/main/scala/mesosphere/marathon/core/matcher/base/util/OfferOperationFactory.scala, line 66 [r1] (raw file):

  def createVolumes(
    frameworkId: FrameworkId,
    taskId: Instance.Id,

instanceId?

src/main/scala/mesosphere/marathon/core/matcher/reconcile/impl/OfferMatcherReconciler.scala, line 42 [r1] (raw file):

    val frameworkId = FrameworkId("").mergeFromProto(offer.getFrameworkId)

    val resourcesByTaskId: Map[Instance.Id, Iterable[Resource]] = {

resourcesByInstanceId?

src/main/scala/mesosphere/marathon/core/matcher/reconcile/impl/OfferMatcherReconciler.scala, line 52 [r1] (raw file):

  }

  private[this] def processResourcesByTaskId(

processResourcesByInstanceId? with a TODO for pods support?

src/main/scala/mesosphere/marathon/core/task/Task.scala, line 350 [r1] (raw file):

  def tasksById(tasks: Iterable[Instance]): Map[Instance.Id, Instance] =
    tasks.iterator.map(task => task.id -> task).toMap

should this filter by type Task? or is this deep enough that only Task's will appear in the Iterable anyway?

src/main/scala/mesosphere/marathon/core/task/tracker/TaskTracker.scala, line 26 [r1] (raw file):

  def appTasks(appId: PathId)(implicit ec: ExecutionContext): Future[Iterable[Instance]]

  def task(taskId: Instance.Id): Future[Option[Instance]]

the impl expects this to possibly return Pod things as well. Should TaskTracker be refactored into InstanceTracker and live elsewhere?

Comments from Reviewable

Review status: 0 of 131 files reviewed at latest revision, 25 unresolved discussions, some commit checks failed.

src/main/scala/mesosphere/marathon/api/v2/json/Formats.scala, line 120 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> s/TaskWrites/InstanceWrites/

Done.

src/main/scala/mesosphere/marathon/core/health/HealthResult.scala, line 7 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> s/taskId/instanceId/

Done.

src/main/scala/mesosphere/marathon/core/health/HealthResult.scala, line 13 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> ditto

Done.

src/main/scala/mesosphere/marathon/core/health/HealthResult.scala, line 18 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> ditto

Done.

src/main/scala/mesosphere/marathon/core/health/impl/HealthCheckActor.scala, line 26 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> s/taskHealth/instanceHealth/

Done.

src/main/scala/mesosphere/marathon/core/health/impl/HealthCheckActor.scala, line 94 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> ?asInstanceOf needed?

Done.

src/main/scala/mesosphere/marathon/core/launcher/TaskOpFactory.scala, line 10 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> InstanceOpFactory? that "Infers which InstanceOp's..." ?

Done.

src/main/scala/mesosphere/marathon/core/launcher/TaskOpFactory.scala, line 25 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> instanceMap?

Done.

src/main/scala/mesosphere/marathon/core/launcher/TaskOpFactory.scala, line 28 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> instances?

Done.

src/main/scala/mesosphere/marathon/core/launcher/TaskOpFactory.scala, line 36 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> instances?

Done.

src/main/scala/mesosphere/marathon/core/launcher/impl/OfferProcessorImpl.scala, line 5 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> InstanceOp?

Done.

src/main/scala/mesosphere/marathon/core/launchqueue/impl/TaskLauncherActor.scala, line 89 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> inFlightInstanceOperations?

Done.

src/main/scala/mesosphere/marathon/core/launchqueue/impl/TaskLauncherActor.scala, line 95 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> instancesMap?

Done.

src/main/scala/mesosphere/marathon/core/matcher/base/util/OfferOperationFactory.scala, line 39 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> instanceId?

Done.

src/main/scala/mesosphere/marathon/core/matcher/base/util/OfferOperationFactory.scala, line 66 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> instanceId?

Done.

src/main/scala/mesosphere/marathon/core/matcher/reconcile/impl/OfferMatcherReconciler.scala, line 42 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> resourcesByInstanceId?

Done.

src/main/scala/mesosphere/marathon/core/matcher/reconcile/impl/OfferMatcherReconciler.scala, line 52 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> processResourcesByInstanceId? with a TODO for pods support?

Done.

src/main/scala/mesosphere/marathon/core/task/Task.scala, line 350 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> should this filter by type Task? or is this deep enough that only Task's will appear in the Iterable anyway?

Should be moved to Instance IMO. What do you think? It`s a helper to transform a list of Instances to a Map(id->Instance)

src/main/scala/mesosphere/marathon/core/task/tracker/TaskTracker.scala, line 26 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> the impl expects this to possibly return Pod things as well. Should TaskTracker be refactored into InstanceTracker and live elsewhere?

Renamed to InstanceTracker -> wow, was a huge change!

Comments from Reviewable

Reviewed 131 of 148 files at r1, 1 of 1 files at r2.
Review status: 65 of 164 files reviewed at latest revision, 28 unresolved discussions, some commit checks failed.

src/main/scala/mesosphere/marathon/core/launcher/impl/TaskOpFactoryHelper.scala, line 10 [r3] (raw file):

import org.apache.mesos.{ Protos => Mesos }

class TaskOpFactoryHelper(

InstanceOpFactoryHelper?

src/main/scala/mesosphere/marathon/core/matcher/base/util/TaskOpSourceDelegate.scala, line 8 [r3] (raw file):

import mesosphere.marathon.core.matcher.base.util.TaskOpSourceDelegate.{ TaskOpAccepted, TaskOpRejected }

private class TaskOpSourceDelegate(actorRef: ActorRef) extends TaskOpSource {

s/TaskOp/InstanceOp/ everywhere in here?

src/main/scala/mesosphere/marathon/core/matcher/reconcile/impl/OfferMatcherReconciler.scala, line 71 [r3] (raw file):

                  resources = spuriousResources.to[Seq]
                )
              log.warn("removing spurious resources and volumes of {} because the app does no longer exist", instanceId)

s/app/instance/

src/main/scala/mesosphere/marathon/core/task/Task.scala, line 350 [r1] (raw file):
Previously, unterstein (Johannes Unterstein) wrote…
> Should be moved to Instance IMO. What do you think? It`s a helper to transform a list of Instances to a Map(id->Instance)

moving to Instance sounds good

Comments from Reviewable

yep, tons of changes!

Review status: 65 of 164 files reviewed at latest revision, 28 unresolved discussions, some commit checks failed.

src/main/scala/mesosphere/marathon/core/launcher/impl/TaskOpFactoryHelper.scala, line 10 [r3] (raw file):
Previously, jdef (James DeFelice) wrote…
> InstanceOpFactoryHelper?

Done.

src/main/scala/mesosphere/marathon/core/matcher/base/util/TaskOpSourceDelegate.scala, line 8 [r3] (raw file):
Previously, jdef (James DeFelice) wrote…
> s/TaskOp/InstanceOp/ everywhere in here?

Done.

src/main/scala/mesosphere/marathon/core/task/Task.scala, line 350 [r1] (raw file):
Previously, jdef (James DeFelice) wrote…
> moving to Instance sounds good

Done.

Comments from Reviewable

Reviewed 33 of 35 files at r3, 100 of 100 files at r4.
Review status: 148 of 164 files reviewed at latest revision, 32 unresolved discussions, some commit checks failed.

src/main/scala/mesosphere/marathon/core/matcher/base/util/InstanceOpSourceDelegate.scala, line 14 [r5] (raw file):

object InstanceOpSourceDelegate {
  def apply(actorRef: ActorRef): TaskOpSource = new InstanceOpSourceDelegate(actorRef)

InstanceOpSource?

src/main/scala/mesosphere/marathon/core/matcher/base/util/InstanceOpSourceDelegate.scala, line 16 [r5] (raw file):

  def apply(actorRef: ActorRef): TaskOpSource = new InstanceOpSourceDelegate(actorRef)

  sealed trait TaskOpNotification {

InstanceOpNotification?

src/main/scala/mesosphere/marathon/core/matcher/base/util/InstanceOpSourceDelegate.scala, line 22 [r5] (raw file):

    def unapply(notification: TaskOpNotification): Option[InstanceOp] = Some(notification.taskOp)
  }
  case class TaskOpAccepted(taskOp: InstanceOp) extends TaskOpNotification

InstanceOpAccepted?

src/main/scala/mesosphere/marathon/core/matcher/base/util/InstanceOpSourceDelegate.scala, line 23 [r5] (raw file):

  }
  case class TaskOpAccepted(taskOp: InstanceOp) extends TaskOpNotification
  case class TaskOpRejected(taskOp: InstanceOp, reason: String) extends TaskOpNotification

InstanceOpRejected?

Comments from Reviewable

Review status: 148 of 164 files reviewed at latest revision, 32 unresolved discussions, some commit checks failed.

src/main/scala/mesosphere/marathon/core/matcher/reconcile/impl/OfferMatcherReconciler.scala, line 71 [r3] (raw file):
Previously, jdef (James DeFelice) wrote…
> s/app/instance/

Done.

Comments from Reviewable

Review status: 147 of 164 files reviewed at latest revision, 32 unresolved discussions, some commit checks failed.

src/main/scala/mesosphere/marathon/core/matcher/base/util/InstanceOpSourceDelegate.scala, line 14 [r5] (raw file):
Previously, jdef (James DeFelice) wrote…
> InstanceOpSource?

Done.

src/main/scala/mesosphere/marathon/core/matcher/base/util/InstanceOpSourceDelegate.scala, line 16 [r5] (raw file):
Previously, jdef (James DeFelice) wrote…
> InstanceOpNotification?

Done.

src/main/scala/mesosphere/marathon/core/matcher/base/util/InstanceOpSourceDelegate.scala, line 22 [r5] (raw file):
Previously, jdef (James DeFelice) wrote…
> InstanceOpAccepted?

Done.

src/main/scala/mesosphere/marathon/core/matcher/base/util/InstanceOpSourceDelegate.scala, line 23 [r5] (raw file):
Previously, jdef (James DeFelice) wrote…
> InstanceOpRejected?

Done.

Comments from Reviewable

Reviewed 3 of 35 files at r3, 18 of 18 files at r5.
Review status: 157 of 164 files reviewed at latest revision, 32 unresolved discussions, some commit checks failed.

src/main/scala/mesosphere/marathon/core/matcher/base/util/InstanceOpSourceDelegate.scala, line 16 [r5] (raw file):
Previously, unterstein (Johannes Unterstein) wrote…
> Done.

Any particular reason why  Op was dropped from the name?

src/main/scala/mesosphere/marathon/core/matcher/base/util/InstanceOpSourceDelegate.scala, line 22 [r5] (raw file):
Previously, unterstein (Johannes Unterstein) wrote…
> Done.

Any particular reason why  Op was dropped from the name?

src/main/scala/mesosphere/marathon/core/matcher/base/util/InstanceOpSourceDelegate.scala, line 23 [r5] (raw file):
Previously, unterstein (Johannes Unterstein) wrote…
> Done.

Any particular reason why  Op was dropped from the name?

Comments from Reviewable

Review status: 146 of 164 files reviewed at latest revision, 32 unresolved discussions, some commit checks failed.

src/main/scala/mesosphere/marathon/core/matcher/base/util/InstanceOpSourceDelegate.scala, line 16 [r5] (raw file):

InstanceOpNotification
Oooops! No, thanks!

src/main/scala/mesosphere/marathon/core/matcher/base/util/InstanceOpSourceDelegate.scala, line 22 [r5] (raw file):
Previously, jdef (James DeFelice) wrote…
> Any particular reason why  Op was dropped from the name?

Oooops, reverted!

src/main/scala/mesosphere/marathon/core/matcher/base/util/InstanceOpSourceDelegate.scala, line 23 [r5] (raw file):
Previously, jdef (James DeFelice) wrote…
> Any particular reason why  Op was dropped from the name?

Oooops, reverted!

Comments from Reviewable

lgtm once build passes

:clap:


Classes 'error' and 'success' co-exist for 'em' label

<em class="error success"...>. Thus:
when user types a valid answer, the 'checked.gif' icon will appear, but it won't switch back to 'unchecked.gif' in case user invalidates the field. The error message works, but the icons won't toggle.
This can be verified at: http://jquery.bassistance.de/validate/demo/custom-methods-demo.html

I'm sorry for the lack of activity on this issue. Instead of leaving it open any longer, I decided to close old issues without trying to address them, to longer give the false impression that it will get addressed eventually, especially after several years with no activity. It doesn't mean I'm abandoning the project, just that I'm unable to work through 200+ open issues with the little time I can afford to spend on this project.
To the reporter (or anyone else interested in this issue): If you're still affected by the same issue, please consider opening a new issue, with a testpage that demonstrates the issue with a current version of the plugin. Even better, make an attempt to fix the issue yourself, and improve the project by sending a pull request. This may seem daunting at first, but you'll likely learn some useful skills that you can apply elsewhere as well. And you can help keep this project alive. We've documented how to do these things, too. A patch is worth a thousand issues!


Pool::pooled_transactions_max is as slow as Pool::pooled_transactions

Describe the bug
Currently, pooled_transactions_max calls self.pooled_transactions(). As a result, the running time is the same, regardless how big the argument max is.
https://github.com/paradigmxyz/reth/blob/f211aacf551afbf707b7fb6a40d17c8d2264110e/crates/transaction-pool/src/lib.rs#L408-L413
The same issue happens for pooled_transaction_hashes_max.

Suggestion
Define a fn to PoolInner:
pub(crate) fn pooled_transactions_max(&self, max: usize) -> Vec<Arc<ValidPoolTransaction<T::Transaction>>> {
    self.get_pool_data().all().transactions_iter().filter(|tx| tx.propagate).take(max).collect()
}

Steps to reproduce
N/A
Node logs

Platform(s)
Mac (Apple Silicon)
What version/commit are you on?
v1.1.0
What database version are you on?
N/A
Which chain / network are you on?
N/A
What type of node are you running?
Archive (default)
What prune config do you use, if any?
N/A
If you've built Reth from source, provide the full command you used
No response
Code of Conduct

[x] I agree to follow the Code of Conduct

Shall I create a PR?
In our use case, we want to add pending_transactions_max also. May I add this fn in the same PR?

This is critical for performance chains as best_transactions is basically unusable for small block time: https://github.com/paradigmxyz/reth/issues/12412#issuecomment-2492909196.

I see, yeah please open a pr that impl this natively on poolinner

I see, yeah please open a pr that impl this natively on poolinner

I just opened a PR: https://github.com/paradigmxyz/reth/pull/12856


Create EDPM vm when deploy_edpm is set to true

deploy-edpm.yml is used in edpm, baremetal and podified deployment job. In podified deployment job, we do not do the EDPM deployment but vms were getting created.
It eats the space and lets the unwanted failure.
This patch disables the EDPM vm creation task and create it only when required.
As a pull request owner and reviewers, I checked that:

[ ] Appropriate testing is done and actually running

/approve
sounds legit - thanks for that one!

/lgtm

/lgtm


group by not working, permission crash

https://github.com/prest/controllers/pull/2/commits/c6aff786b8ffc8b72424ac014b672d44c2d8988f#diff-fdc56cdc36b3d184da98526631325213R92

https://github.com/prest/adapters/pull/4


how to disable right click or not allow to save the pdf file ??

I don't think that this is possible.. and it's not part of the pdfjs_viewer-rails engine. I suggest you ask on the PDF.js repo (https://github.com/mozilla/pdf.js/issues) for help


II Login Button

Moves login button over from agent-js

Should / can we delete the existing ic-badge-default.svg and ic-badge-light.svg or should we preserve these assets for a while?

Overall this looks good to me, @peterpeterparker has covered a lot of good points 👍


Minor: Fixed capital H

@gbellmann : Thanks for your contribution! The author, @VanMSFT, has been notified to review your proposed change.

Thanks for catching this, @gbellmann!
#sign-off


Update release notes for OHIF

Update release notes for OHIF up to 4.12.45 (final version before v3)

Per discussion today, let's implement a basic procedure to mark versions of IDC fork, label clearly that those versions do not correspond to the OHIF v2 upstream and is an IDC "branch" of v2. And let's not label it as "deprecated" in the IDC release notes, because for IDC it is definitely not deprecated.

procedure to mark versions of IDC fork, label clearly that those versions do not correspond to the OHIF v2 upstream and is an IDC "branch" of v2. And let's not label it as "deprecated" in the IDC release notes, because for IDC it is definitely not deprecated.

PR updated. Ticket created: https://github.com/ImagingDataCommons/Viewers/issues/207

Thank you @igoroctaviano! I will keep this open for now, until we do the release, and then merge.

unfortunately, there is some issue between github and gitbook right now, and I cannot sync, so not merging yet...


[ci skip] adding user @thewchan

Hi! This is the friendly automated conda-forge-webservice.
I've added user @thewchan as instructed in #7.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #7

@ocefpaf  @conda-forge/core  so I was the original contributor for this package there's a consistent bug on my local machine when using gray skull it populates the wrong user name for the maintainer field. Can we add the correct user name instead?


[stdlib] Fix Unexpected Behavior of Sequence.split

Resolves #74655

Hi @WindowsMEMZ – thanks for taking a look at this! The observed behavior of the split method is in fact correct, as those two parameters have a bit of subtle interaction.


[FLINK-19414][file connector] Revert "Extract FileSourceTextLinesITCase to AbstractFileSourceITCase"

What is the purpose of the change
From @StephanEwen
We should not have a test-jar for the flink-connector-files project, because the module it is not scala-versioned. Thus we cannot release an artifact with a dependency on a specific scala version (like the test jar).
We need to have the connector test utils in a different project, or add a scala version to the module (I would like to avoid a scala version if possible).
We should use AdapterTestBase to test formats, it is a scala free class, we can create a module flink-connector-files-test-utils, and move the abstract class to it. And formats should depend on it.
Brief change log
Revert 8084bdd9a16d8524c33a5a7b588232d8995bca23
Remove FileSourceParquetColumnarITCase
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no

Since it is a revert commit, I'll merge it.


Typo in path for System.DefaultWorkingDirectory

Page says System.DefaultWorkingDirectory - c:\agent\_work\1\s
Pretty sure its supposed to be System.DefaultWorkingDirectory - c:\agent_work\1\s

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 11d3469c-83c2-c2f6-41d0-08f82c330bbc
Version Independent ID: a373c48d-6395-3002-d2d8-bbc1fea2e48e
Content: Predefined variables - Azure Pipelines
Content Source: docs/pipelines/build/variables.md
Product: devops
Technology: devops-cicd
GitHub Login: @juliakm
Microsoft Alias: jukullam

@ausfestivus Thank you for the feedback.
The documentation has been updated and in pending review.


Ability to disable auto-formatting in the input mask

Is your feature request related to a problem? Please describe.
Having the rifm mask is very useful, as it communicates the expected date format to the user. However, the auto-formatting in the input mask is a bit intrusive and not always correct. I am referring to the auto-calculating behavior of the date picker, when you enter an invalid date.
For instance (and here's a playground to try it out),

user mistypes 12-32-2020 and it gets auto-formatted to 01-01-2021
if you enter 99-99-9999, it gets auto-formatted to 06-07-10007 (if you type any character, it changes to 06-07-1000)

Looking at KeyboardDateInput, there doesn't seem to be a way to customize the format prop on Rifm, nor opt out of the formatting entirely.
Describe the solution you'd like
It would be great to expose a boolean prop, e.g. maskFormatting or maskAutoCorrect defaulting to true (for backwards compat). When false, simply don't auto-format or auto-correct the input date. Ideally, I'd like to make it behave just as the "Date format with mask" example under "Date format" section in rifm docs.
Describe alternatives you've considered
Alternatively, expose the rifm API through props, but this would involve more complexity.
Thank you.

Yeah, I see your point. We cannot disable autoformatting, because it is coming from the date library, which actually parsing the date.
So we will add ability to change rifm's formatter


Test: Preserve folded ranges

Refs: https://github.com/microsoft/vscode/issues/137890

[x] anyOS @alexdima
[x] anyOS @justschen

Complexity: 3
Create Issue

We now persists folded ranges, even if the folding range is no longer part of the ranges computed by a folding provider. An typical example is when the user comments out the file, starts a string literal, or creates a syntax error that makes it impossible to create all the ranges. Such folded ranges are becoming 'recovered' ranges and get a special folding marker (...). They are removed once the folding provider comes back with ranges at the same location.

open a file with folding provider such as TypeScript or Python
fold some ranges
add an open comment token above the folded ranges: /*
verify that ranges go way, except the folded ranges that are now getting a special folding marker (...)
verify that can be opened and expanded like normal folding ranges
verify that when the open comment is removed, the folding range is replaced by a regular range. If the range is collapsed it stays collapsed
the manual folding range is persisted across editor close and reopen
if needed, the manual range can be removed with the command Remove Manual Folding Ranges

👏 Very nice!

Looks really great 🔥


SDP fixes

Fix correct setting of source_ip in a Receiver's transport_params when parsing an SDP file which doesn't contain a source-filter. Previously it set it from the origin <unicast-address> but that's wrong - as shown by the example in the IS-05 spec for Behaviour - RTP Transport Type - Unicast.

Following on from that, generate source-filters from unicast Senders' transport_params by default.

To enable creation of the effective SDP files at a Receiver when rtp_enabled is explicitly overridden, support creation of SDP files from Receivers' transport_params. Previously only worked from Senders' transport_params, which have a slightly different set of parameters, e.g. destination_ip vs. multicast_ip/interface_ip.

New test cases are added for most of the above improvements.

Also support "session-level" ts-refclk and mediaclk which will resolve #125. The source-filter attribute is still not handled at  "session-level", but I've added more comments to explain some of the ways the source-filter handling could be improved (e.g. checking <dest-address> actually matches the connection address being considered).

Fix generation of a=mediaclk:sender (which would previously have been rendered with a trailing =).

The nmos::get_session_description_transport_params function which is used when parsing SDP files for IS-05 includes this comment:
        // For now, this function should handle the following cases identified in the documentation:
        // * Unicast
        // * Source Specific Multicast
        // * Any Source Multicast
        // * Operation with SMPTE 2022-7 - Separate Source Addresses
        // * Operation with SMPTE 2022-7 - Separate Destination Addresses

        // The following cases are not yet handled:
        // * Operation with SMPTE 2022-5
        // * Operation with SMPTE 2022-7 - Temporal Redundancy
        // * Operation with RTCP

I think this is basically true, however it's worth pointing out that not all of the other relevant information is extracted from the SDP file.
For example, when parsing an SDP file for ST 2022-7 with "Separate Destination Addresses", the <payload type> is only extracted into the sdp_parameters from the m=/a=rtpmap: lines of the first media description. Similarly, the ssrc attributes are not extracted when parsing an SDP File for ST 2022-7 with "Separate Source Addresses". This would prevent accurate roundtrip - creation of a new SDP file from the parsed transport_params and sdp_parameters.
On the creation side, nmos::make_session_description does not distinguish the different ST 2022-7 cases, so I'm pretty certain the "Separate Source Addresses" case does not generate the correct SDP file.

Note that ST 2110-10 has this to say about representation of ST 2022-7 in SDP:

8.3 SDP for Duplicate RTP Streams
Duplicate RTP streams meeting the requirements of SMPTE ST 2022-7 may be used for redundant transmission to achieve higher system availability. Senders which transmit these duplicated RTP streams, using the mechanisms of separate source addresses (IETF RFC 7104, Section 4.1) or separate destination addresses (IETF RFC 7104, section 4.2) shall signal the RTP duplication using the session level group attribute of IETF RFC 5888 and the duplication grouping DUP semantics of IETF RFC 7104.

The example for "Separate Source Addresses" in IS-05 is taken from RFC 7104 Section 4.1 and it uses ssrc and ssrc-groupattributes for synchronization source (SSRC) multiplexed RTP streams. That mechanism, which is defined by RFC 5576, isn't mentioned in ST 2110-10, which may explain why I've never seen it in the wild...
The ST 2110-10 Annex B SDP Example (Informative) is of the "Separate Destination Addresses" case, and uses the same RTP Payload ID for both streams, which may explain why I've never seen different ones outside of the example in RFC 7104 Section 4.2 which is reproduced in IS-05.

Following on from that, generate source-filters from unicast Senders' transport_params by default.

The default behaviour at the Sender side is now that source-filter is written for both unicast (new) and multicast (as before).
I wonder whether this should be tightened up to only include the source-filter for multicast if the address is in the source-specific multicast block, 232/8 (<IP_ADDRESS>-<IP_ADDRESS>) defined by RFC 5771 and registered in the IANA IPv4 Multicast Address Space Registry. The new source_filters optional flag could be used to force it off in that range or on in other ranges.


Installation under node 9.8.0 "Failed at the<EMAIL_ADDRESS>start script."

> babel-node app.js

/metricio/app.js:1
(function (exports, require, module, __filename, __dirname) { import { createServer } from 'http';
                                                              ^^^^^^
SyntaxError: Unexpected token import

@quistuipater
Sorry to hear you were having problems. I've been AFK for a few weeks.
I've had a look and the only way I can get the same output is to remove es2015 presents from the .babelrc file or just delete the file. I am using Ubuntu 18.04 though, so maybe this is a Windows file path problem?
Could you try running the following (from inside the metrico folder): npx babel-node --presets es2015,react -- app.js
I've tried the installation steps with node v9.8.0, v10.0.0 and v8.10.0. All were successfull. Always from a clean checkout of the latest metricio release.

Could you give me a little more information about your environment, please? Nothing big, just OS name, version etc. Maybe even what steps you took beforehand.
Thanks!

Closing due to lack of feedback.
If the none of the above helped then maybe try that latest release :+1:


remove debounce logic from secret watcher

Because of this debounce logic we are seeing some events are missed (probably a race condition in debouncer) . I think debouncer is strictly not needed here because inotify will trigger write event after write is actually complete and we are checking for write events already.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4aa7f5d73ff2299417f7c050ba50944822a150ec
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
4aa7f5d73ff2299417f7c050ba50944822a150ec
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster-tests_istio

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
4aa7f5d73ff2299417f7c050ba50944822a150ec
link
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
4aa7f5d73ff2299417f7c050ba50944822a150ec
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

In response to a cherrypick label: new pull request created: #33321


[Google.Cloud.Dialogflow.V2] When returning a WebhookResponse, the field FulfillmentText is marked as optional, but Actions on Google returns error.

I am trying to send back a response like:
            return new WebhookResponse
            {
                FulfillmentMessages =
                {
                    new Message
                    {
                        SimpleResponses = new SimpleResponses
                        {
                            SimpleResponses_ =
                            {
                                new SimpleResponse
                               {
                                  DisplayText = "Phrase"
                                  TextToSpeech = "Phrase"
                                }
                            }
                        }
                    }
                }
            };

But on Actions on Google I get:
MalformedResponse
'final_response' must be set.
If I send the same response with the field FulfillmentText set as "Phrase", then everything works.

My guess is that you're letting Json.NET serialize the response. Don't do that - it won't work. Follow the example on https://googlecloudplatform.github.io/google-cloud-dotnet/docs/Google.Cloud.Dialogflow.V2/index.html so that you serialize the response properly.
If that isn't it, please provide some more context for the code.

I am using the ToString method from the Google Protobuf.
The thing is that It seems like the documentation of the field FulFillmentText from the WebhookResponse is wrong. I mean, Dialogflow parses correctly the response, but then when Dialogflow pases the response to Actions on Google, then Actions on Google throws the error specified before.
If I respond with this, then all works fine, Actions on Google understand everything.
{
    "fulfillmentText": "This is a response for Actions on Google",
    "fulfillmentMessages": [
        {
            "simpleResponses": {
                "simpleResponses": [
                    {
                        "text_to_speech": "This is a response for Actions on Google"
                    }
                ]
            }
        }
    ]
}

But If I respond with this, then Actions on Google throws an error:
{
    "fulfillmentMessages": [
        {
            "simpleResponses": {
                "simpleResponses": [
                    {
                        "text_to_speech": "This is a response for Actions on Google"
                    }
                ]
            }
        }
    ]
}

Wait a Second. Am I supposed to use the Payload field for the responses for Actions on Google and not use the FulfillmentMessages field?

I'm afraid at this point we're way beyond my knowledge - the contributors here have to work with a lot of APIs; we don't know the APIs well, but we're good at finding out if there's a problem with the .NET-specific parts.
It sounds like you're able to produce the JSON you expect, at which point I don't think we can help you any further, so I'm going to close this issue. I'd suggest looking through the Dialogflow support options as well as double-checking the Actions on Google fulfillment documentation. I'm sorry we can't help you further :(

I was my fault. I was misunderstanding the documentation.
What I needed to do is to mark the message with the appropriate platform. And if you want to send a card back to Actions on Google, you need to provide a simple response too.
            var webhookResponse = new WebhookResponse
            {
                FulfillmentMessages =
                {
                    new Message
                    {
                        Platform = Platform.ActionsOnGoogle,
                        SimpleResponses = new SimpleResponses
                        {
                            SimpleResponses_ =
                            {
                                new SimpleResponse
                                {
                                    TextToSpeech = "Text to speech.",
                                    DisplayText = "Something different."
                                }
                            }
                        }
                    },
                    new Message
                    {
                        Platform = Platform.ActionsOnGoogle,
                        BasicCard = new BasicCard
                        {

                        }
                    }
                }
            };


Open level of active only?

Is it possible to leave the selected menu open after click? It is possible to change the script on the end page to leave the selected menu open after click?
Closed menu (at start)
Country 1
Country 2
Country 3

Opened menu after click on Country 2
Country 1
Country 2
--Region 1 > Click on this item
--Region 2
--Region 3
Country 3

Country 1
Country 2   This level should be opened
--Region 1 > This item should be active
--Region 2
--Region 3
Country 3

Sorry, it is in the documentation. Did not read carefully.


Neumorphic must clip its clild

add a CipRRect (if box rect)
add a ClipPath (with round) if box is .cicle

done


V2.9.0 causes CLIENT_ERROR disconnect from AWS shadow, but v2.7.0 does not

Any attempt to interact with a device shadow (/get or /update) on AWS using 2.9.0 causes AWS failure then disconnect. CloudWatch events on 2.7.0 are:
{
    "timestamp": "2023-11-01 17:23:10.204",
    "logLevel": "ERROR",
    "traceId": "cf60a0d1-ead7-f46d-f59b-04697613200a",
    "accountId": "278277519326",
    "status": "Failure",
    "eventType": "Publish-In",
    "protocol": "MQTT",
    "topicName": "$aws/things/garage/shadow/get",
    "clientId": "428193CD-1C8E-4816-B54F-32961E24FEEA",
    "principalId": "39cbc03c728823970a5337a3b44f33c5199db91312e5f1eb977a4dcc5c0edcac",
    "sourceIp": "<IP_ADDRESS>",
    "sourcePort": 40538
}

{
    "timestamp": "2023-11-01 17:23:10.218",
    "logLevel": "INFO",
    "traceId": "75ab78e9-ee42-f044-2187-8d9a97dfaae2",
    "accountId": "278277519326",
    "status": "Success",
    "eventType": "Disconnect",
    "protocol": "MQTT",
    "clientId": "428193CD-1C8E-4816-B54F-32961E24FEEA",
    "principalId": "39cbc03c728823970a5337a3b44f33c5199db91312e5f1eb977a4dcc5c0edcac",
    "sourceIp": "<IP_ADDRESS>",
    "sourcePort": 40538,
    "disconnectReason": "CLIENT_ERROR"
}

No issues with connection, just update. Reverting to 2.7.0 with otherwise completely identical code (so no policy issues) is successful:
{
    "timestamp": "2023-11-01 17:45:54.750",
    "logLevel": "INFO",
    "traceId": "893ab84d-79fa-9acf-fd66-d4beb1d18c09",
    "accountId": "278277519326",
    "status": "Success",
    "eventType": "Publish-In",
    "protocol": "MQTT",
    "topicName": "$aws/things/garage/shadow/get",
    "clientId": "03E7BABE-66C0-4F05-91AE-83649D608256",
    "principalId": "39cbc03c728823970a5337a3b44f33c5199db91312e5f1eb977a4dcc5c0edcac",
    "sourceIp": "<IP_ADDRESS>",
    "sourcePort": 58412
}

Code is Swift Swift version 5.9 (swift-5.9-RELEASE) on Ubuntu 22.04.3 LTS (GNU/Linux 5.15.0-1041-raspi aarch64)

Are you able to narrow the version a little more. Does it work with v2.8.0?
How are you connecting to your MQTT server? WebSocket or a X.509 certificate
Is this disconnecting on a publish event? Are you able to show the code that is causing the disconnect?
Does it disconnect on all messages?
Could you enable trace logging on the client and attach a log here?

Thanks for the quick response! Answers are...
I've checked and it fails on 2.8.0 as well
I'm connecting using X.509 (certificate generated by AWS)
It's failing on all the publish calls that I have tried, my code is:
    func publish(message: IoTMessage) async throws {

        if debug { print("AWSIoTInterface: publish: \(message)") }

        if !client.isActive() {
            if debug { print("AWSIoTInterface: reconnecting") }

            _ = try await connect()

            if debug { print("AWSIoTInterface: reconnected") }

        }

        do {
            try await client.publish(to: message.topic.value,
                                      payload: ByteBufferAllocator().buffer(string: message.payload ?? ""),
                                      qos: .atLeastOnce,
                                      retain: true)
        } catch {
            print("Publish failed with error: \(error)")
            throw error
        }

        if debug { print("AWSIoTInterface: published") }

    }

resulting in:
AWSIoTInterface: publish: IoTMessage(topic: AWSIoT.Topic(value: "$aws/things/garage/shadow/get"), payload: Optional(""))
Publish failed with error: serverClosedConnection

As well as the CloudWatch events above
My code fails on /get and /update messages, I've not tried any others.
By trace logging do you mean the  parameter in the  initialiser?   If so I don't think I can use that as I'm not running on an Apple platform, and I don't thing Logger is supported? Happy to run additional tracing if that is possible

The only change I can see that might affect you is I fixed a bug where the retain flag was not passed on. Does your code work if you set this to false?

Another question. Could it be the combination of publishing an empty message with the retain flag set that is causing the disconnect.

By trace logging do you mean the parameter in the initialiser? If so I don't think I can use that as I'm not running on an Apple platform, and I don't thing Logger is supported? Happy to run additional tracing if that is possible

MQTTNIO uses swift-log for its logging. This can be given any backend to output it's logs. By default swift-log outputs to stdout. You just need to supply a Logger to the client at initialization.
var logger = Logger(label: "MQTT")
logger.logLevel = .trace
let mqttClient = MQTTClient(...
    logger: logger
)

It's not related to the empty payload as the disconnect also happens on a shadow update with a payload. I saw that the only relevant change from 2.7 to 2.8 was the retain flag on publish so I'll try changing that...

Thanks for your help! Changing the retain flag to false fixes it. Tested on 2.8.0 and 2.9.0 with and without payload...


Feature/cldn-688: Add build information to Superset

Add the build id to the version.

I was planning to make all changes in one commit at merge time.


throttle not happen when cpu-usage exceed nodeqos threshhold

What type of PR is this?
throttle not happend when reaching nodeqos throttle threshhold
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Thanks YongGe! Can you fix according to my comments and we can merge it.


unable to install on ubuntu 16.04

pip install cartoview
Requirement already satisfied: cartoview in ./geonode/lib/python2.7/site-packages (1.8.1)
Requirement already satisfied: six==1.10.0 in ./geonode/lib/python2.7/site-packages (from cartoview) (1.10.0)
Requirement already satisfied: future in ./geonode/lib/python2.7/site-packages (from cartoview) (0.16.0)
django-polymorphic 2.0.2 has requirement Django>=1.11, but you'll have django 1.8.19 which is incompatible.
pyelasticsearch 1.4.1 has requirement elasticsearch<2.0.0,>=1.3.0, but you'll have elasticsearch 6.2.0 which is incompatible.
pycsw 2.2.0 has requirement lxml==3.6.2, but you'll have lxml 4.2.1 which is incompatible.
django-haystack 2.8.1 has requirement Django>=1.11, but you'll have django 1.8.19 which is incompatible.
pinax-theme-bootstrap-account 1.0b2 has requirement django-appconf==0.5, but you'll have django-appconf 1.0.2 which is incompatible.

Running pip install cartoview i get that error

It seems you have already geonode installed , so make sure that geonode is working fine as all these conflicts related to geonode.
to solve this conflicts install geonode requirements using
pip install -r <geonode_requirements>.txt

I got the same problem during  pip install cartoview

pinax-theme-bootstrap-account 1.0b2 has requirement django-appconf==0.5, but you'll have django-appconf 1.0.2 which is incompatible.
pyelasticsearch 1.4 has requirement elasticsearch<2.0.0,>=1.3.0, but you'll have elasticsearch 5.4.0 which is incompatible.
pycsw 2.0.3 has requirement lxml==3.6.2, but you'll have lxml 3.8.0 which is incompatible.
pycsw 2.0.3 has requirement OWSLib==0.10.3, but you'll have owslib 0.14.0 which is incompatible.
pycsw 2.0.3 has requirement pyproj==1.9.3, but you'll have pyproj <IP_ADDRESS> which is incompatible.
pycsw 2.0.3 has requirement Shapely==1.3.1, but you'll have shapely 1.5.17.post1 which is incompatible.

Probably just warning. Then I proceed until python manage.py makemigrations app_manager for first time. Now the error;

`/home/az/.virtualenvs/newenv/lib/python2.7/site-packages/geonode/catalogue/init.py:27: RemovedInDjango19Warning: django.utils.importlib will be removed in Django 1.9.
from django.utils.importlib import import_module
/home/az/.virtualenvs/newenv/lib/python2.7/site-packages/dialogos/models.py:6: RemovedInDjango19Warning: django.contrib.contenttypes.generic is deprecated and will be removed in Django 1.9. Its contents have been moved to the fields, forms, and admin submodules of django.contrib.contenttypes.
from django.contrib.contenttypes.generic import GenericForeignKey
Traceback (most recent call last):
File "manage.py", line 10, in
execute_from_command_line(sys.argv)
File "/home/az/.virtualenvs/newenv/lib/python2.7/site-packages/django/core/management/init.py", line 354, in execute_from_command_line
utility.execute()
File "/home/az/.virtualenvs/newenv/lib/python2.7/site-packages/django/core/management/init.py", line 328, in execute
django.setup()
File "/home/az/.virtualenvs/newenv/lib/python2.7/site-packages/django/init.py", line 18, in setup
apps.populate(settings.INSTALLED_APPS)
File "/home/az/.virtualenvs/newenv/lib/python2.7/site-packages/django/apps/registry.py", line 108, in populate
app_config.import_models(all_models)
File "/home/az/.virtualenvs/newenv/lib/python2.7/site-packages/django/apps/config.py", line 198, in import_models
self.models_module = import_module(models_module_name)
File "/usr/local/lib/python2.7/importlib/init.py", line 37, in import_module
import(name)
File "/home/az/.virtualenvs/newenv/lib/python2.7/site-packages/geonode/base/models.py", line 56, in
from geonode.utils import bbox_to_wkt
File "/home/az/.virtualenvs/newenv/lib/python2.7/site-packages/geonode/utils.py", line 30, in
from osgeo import ogr
File "/home/az/.virtualenvs/newenv/lib/python2.7/site-packages/osgeo/init.py", line 21, in
_gdal = swig_import_helper()
File "/home/az/.virtualenvs/newenv/lib/python2.7/site-packages/osgeo/init.py", line 13, in swig_import_helper
import _gdal
ImportError: No module named _gdal

Can someone share requirements.txt that is working.

To install gdal in virtualenv do the following steps:
$ sudo apt-add-repository ppa:ubuntugis/ubuntugis-unstable
$ sudo apt-get update
$ sudo apt-get install libgdal-dev

activate the virtualenv source newenv/bin/activate
pip install GDAL==$(gdal-config --version) --global-option=build_ext --global-option="-I/usr/include/gdal"

Thanks. The above gdal is okay now. But a new one now;

(sabahenv) az@ubuntusab:~/proj_sab$ python manage.py makemigrations app_manager
Traceback (most recent call last):
File "manage.py", line 10, in
execute_from_command_line(sys.argv)
File "/home/az/.virtualenvs/sabenv/lib/python2.7/site-packages/django/core/management/init.py", line 354, in execute_from_command_line
utility.execute()
File "/home/az/.virtualenvs/sabenv/lib/python2.7/site-packages/django/core/management/init.py", line 328, in execute
django.setup()
File "/home/az/.virtualenvs/sabenv/lib/python2.7/site-packages/django/init.py", line 18, in setup
apps.populate(settings.INSTALLED_APPS)
File "/home/az/.virtualenvs/sabenv/lib/python2.7/site-packages/django/apps/registry.py", line 85, in populate
app_config = AppConfig.create(entry)
File "/home/az/.virtualenvs/sabenv/lib/python2.7/site-packages/django/apps/config.py", line 86, in create
module = import_module(entry)
File "/usr/local/lib/python2.7/importlib/init.py", line 37, in import_module
import(name)
File "/home/az/.virtualenvs/sabenv/lib/python2.7/site-packages/autocomplete_light/init.py", line 7, in
from .shortcuts import *  # noqa
File "/home/az/.virtualenvs/sabenv/lib/python2.7/site-packages/autocomplete_light/shortcuts.py", line 1, in
from .autocomplete.shortcuts import *
File "/home/az/.virtualenvs/sabenv/lib/python2.7/site-packages/autocomplete_light/autocomplete/shortcuts.py", line 1, in
from .base import AutocompleteBase
File "/home/az/.virtualenvs/sabenv/lib/python2.7/site-packages/autocomplete_light/autocomplete/base.py", line 4, in
from django.urls import reverse, NoReverseMatch
ImportError: No module named urls

May I ask,
Are these the correct combination? Geonode 2.8rc11 , Cartoview 1.8.1, Django 1.8.19

Hi,
Again no luck here.

(envsabah) az@ubuntusa:~/sabrs$ python manage.py makemigrations app_manager
Traceback (most recent call last):
File "manage.py", line 10, in
execute_from_command_line(sys.argv)
File "/home/az/.virtualenvs/envsab/lib/python2.7/site-packages/django/core/management/init.py", line 354, in execute_from_command_line
utility.execute()
File "/home/az/.virtualenvs/envsab/lib/python2.7/site-packages/django/core/management/init.py", line 328, in execute
django.setup()
File "/home/az/.virtualenvs/envsab/lib/python2.7/site-packages/django/init.py", line 18, in setup
apps.populate(settings.INSTALLED_APPS)
File "/home/az/.virtualenvs/envsab/lib/python2.7/site-packages/django/apps/registry.py", line 85, in populate
app_config = AppConfig.create(entry)
File "/home/az/.virtualenvs/envsab/lib/python2.7/site-packages/django/apps/config.py", line 86, in create
module = import_module(entry)
File "/usr/local/lib/python2.7/importlib/init.py", line 37, in import_module
import(name)
File "/home/az/.virtualenvs/envsab/lib/python2.7/site-packages/polymorphic/init.py", line 13, in
version = pkg_resources.require("django-polymorphic")[0].version
File "/home/az/.virtualenvs/envsab/lib/python2.7/site-packages/pkg_resources/init.py", line 891, in require
needed = self.resolve(parse_requirements(requirements))
File "/home/az/.virtualenvs/envsab/lib/python2.7/site-packages/pkg_resources/init.py", line 782, in resolve
raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (Django 1.8.19 (/home/az/.virtualenvs/envsab/lib/python2.7/site-packages), Requirement.parse('Django>=1.11'), set(['django-polymorphic']))

Below is the list of in my requirements.txt
amqp==1.4.9
anyjson==0.3.3
awesome-slugify==1.6.5
beautifulsoup4==4.6.0
billiard==<IP_ADDRESS>
boto==2.49.0
cartoview==1.8.1
celery==3.1.26.post2
certifi==2018.4.16
chardet==3.0.4
configparser==3.5.0
dj-database-url==0.5.0
Django==1.8.19
django-activity-stream==0.6.5
django-appconf==1.0.2
django-autocomplete-light==2.3.3
django-bootstrap-form==3.4
django-bootstrap3-datetimepicker==2.2.3
django-braces==1.13.0
django-braces==1.13.0
django-celery==3.2.2
django-downloadview==1.9
django-extensions==2.1.0
django-forms-bootstrap==3.1.0
django-friendly-tag-loader==1.3
django-geoexplorer==4.0.40
django-guardian==1.4.9
django-haystack==2.8.1
django-js-asset==1.1.0
django-jsonfield==1.0.1
django-jsonfield-compat==0.4.4
django-leaflet==0.24.0
django-modeltranslation==0.12.2
django-mptt==0.9.0
django-nose==1.4.5
django-oauth-toolkit==0.12.0
django-pagination==1.0.7
django-polymorphic==2.0.2
django-storages==1.6.6
django-taggit==0.22.2
django-tastypie==0.13.1
django-treebeard==4.3
elasticsearch==6.3.0
enum34==1.1.6
flake8==3.5.0
future==0.16.0
GDAL==2.2.2
geolinks==0.2.0
GeoNode==2.6.3
geonode-agon-ratings==0.3.8
geonode-announcements==1.0.13
geonode-arcrest==10.2
geonode-avatar==2.1.8
geonode-dialogos==1.2
geonode-notification==1.1.3
geonode-user-accounts==1.0.15
geonode-user-messages==0.1.14
gisdata==0.5.4
gsconfig==1.0.10
gsimporter==1.0.0
httplib2==0.11.3
idna==2.7
kombu==3.0.37
lxml==4.2.3
mccabe==0.6.1
MultipartPostHandler==0.1.0
nose==1.3.7
oauthlib==2.0.1
OWSLib==0.16.0
Paver==1.3.4
pep8==1.7.1
Pillow==5.2.0
pinax-theme-bootstrap==8.0.1
pinax-theme-bootstrap-account==1.0b2
psycopg2==2.7.5
pycodestyle==2.3.1
pycsw==2.2.0
pyelasticsearch==1.4.1
pyflakes==1.6.0
pyproj==<IP_ADDRESS>
python-dateutil==2.7.3
python-mimeparse==1.6.0
python-slugify==1.2.5
pytz==2018.5
PyYAML==3.13
regex==2018.7.11
requests==2.19.1
Shapely==1.5.17
simplejson==3.16.0
six==1.10.0
transifex-client==0.13.4
typing==3.6.4
Unidecode==0.4.21
urllib3==1.23
xmltodict==0.10.2

Please advise. Thanks.

I see that GeoNode==2.6.3 in requirement.txt , which branch did you install ??

Actually I'm trying to get the latest Cartoview==1.8.1 get to work but failed. My combination is Cartoview==1.8.1 , GeoNode==2.6.3, Django==1.8.19, Python==2.7.12
At the moment, I use the older version of Cartoview==1.2.55. And I want to test the latest.
If I want to use the latest version of Cartoview, what is the requirements to install and run.
Could you share your own pip freeze > requirements.txt . I would like to compare with mine.

here your are requirements.txt.
N.B.  cartoview 1.8.1 is note compatible with geonode 2.6.x .

Many thanks.
I made comparison and use some of the list based on your 'requirement.txt'. It wasn't smooth but manages to install. However I got some of the following during pip install:
pycsw 2.0.3 has requirement lxml==3.6.2, but you'll have lxml 3.8.0 which is incompatible.
pycsw 2.0.3 has requirement OWSLib==0.10.3, but you'll have owslib 0.15.0 which is incompatible.
pycsw 2.0.3 has requirement pyproj==1.9.3, but you'll have pyproj <IP_ADDRESS> which is incompatible.
pycsw 2.0.3 has requirement Shapely==1.3.1, but you'll have shapely 1.5.17 which is incompatible.
pinax-theme-bootstrap-account 1.0b2 has requirement django-appconf==0.5, but you'll have django-appconf 1.0.2 which is incompatible.
geonode 2.6.3 has requirement celery<4.0a0,>=3.1.18, but you'll have celery 4.1.0 which is incompatible.
geonode 2.6.3 has requirement django-tastypie<=0.13.1,>=0.12.2, but you'll have django-tastypie 0.14.0 which is incompatible.
django-haystack 2.8.0 has requirement Django>=1.11, but you'll have django 1.8.19 which is incompatible.
django-celery 3.2.2 has requirement celery<4.0,>=3.1.15, but you'll have celery 4.1.0 which is incompatible.
docker 3.1.1 has requirement requests!=2.18.0,>=2.14.2, but you'll have requests 2.11.1 which is incompatible.
flake8 2.5.4 has requirement pyflakes<1.1,>=0.8.1, but you'll have pyflakes 1.6.0 which is incompatible.

Like I said before, probably warning. I proceed until python manage.py migrate account and I got this:

django.db.utils.OperationalError: no such table: django_site

I just re-run again couple times and it's gone. Then I proceed until python manage.py runserver <IP_ADDRESS>:8000 and I got this:

File "/home/az/.virtualenvs/sabenv4/lib/python2.7/site-packages/cartoview/cartoview_api/rest.py", line 13, in
from geonode.api.authorization import (
ImportError: cannot import name GeonodeApiKeyAuthentication

I have know idea what to do next. Should I just comment out the code in the file or I think just wait from your advise.

@killertonez which version of geonode you are using?

@killertonez closed due to lack of response , feel free to reopen this issue again


Fix volsize for cephfs and rbd

once the PVC is required and backend is created kubernetes sidecar will round off the values to a human-readable format, we have to create images with the same size to avoid volume size mismatch between PVC response and backend image size.
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>

@Madhu-1 please check the review comments.

@ShyamsundarR @poornimag PTAL.

@ShyamsundarR @poornimag can you review this in priority?


Keyboard shortcuts does not work properly on different keyboard layouts

Description
I'm using Debian LXDE with a german keyboard layout.
The navigation itself works fine. But the shortcuts CmdOrCtrl+[ and CmdOrCtrl+] won't. I assume the reason is that the MAC shortcut is with Cmd+Alt+5 or Cmd+Alt+6 while in Linux and Windows it's Ctrl+AltGr+8 and Ctrl+AltGr+9. These shortcuts aren't working then. I tried several combinations to produce the needed shortcut but I failed.
I edited the main.js in /usr/lib/node_modules/nativefier/app/lib/main.js, but it may be overwritten by an update. At least it's not the best solution.
There are several configured shortcuts including a special character. I'd avoid them due mentioned issues with keyboard layouts.

@codekandis thanks for the feedback 🙂. To you or passersby, might be a good idea to see how other Electron apps (e.g. Atom & VSCode) properly handle keyboard shortcuts on non-US/qwerty keyboards. Patches/help welcome.

Sorry, I'm not familiar with Electron. So I have to pass if it's necessary to get into it.
But I assume it's a more general problem of 3rd key assignments with across several OS. MAC handles them not the same way like Linux or Windows. And I assume you won't catch every layout possible by finding the one and only shortcuts using special chars and working properly.
I think it's a better solution to use standard key assignments of CmdOrCtrl+EasyToPressKey. In my case for the back- and forwards navigation I used the more browser standard Backslash and Shift+Backslash assignment.

Just logging another shortcut issue: I tend to use Alt + <left/right arrow> to jump to the beginning/end of words. It does not seem to work in nativefied apps (in this case: Google Drive/Docs).

Just logging another shortcut issue: I tend to use Alt + <left/right arrow> to jump to the beginning/end of words. It does not seem to work in nativefied apps (in this case: Google Drive/Docs).

@JustinTBrown this was fixed in 8.0.6, please upgrade and re-generate your apps.

This worked. Thanks!
On Mon, Apr 13, 2020 at 3:32 PM Ronan Jouchet<EMAIL_ADDRESS>wrote:

Just logging another shortcut issue: I tend to use Alt + <left/right
arrow> to jump to the beginning/end of words. It does not seem to work in
nativefied apps (in this case: Google Drive/Docs).
@JustinTBrown https://github.com/JustinTBrown this was fixed in 8.0.6,
please upgrade and re-generate your apps.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jiahaog/nativefier/issues/559#issuecomment-613108540,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMLUJ7XX5XEQLE46CDKZ53RMOAHLANCNFSM4EWGMP2Q
.


svg elements do not render

Bug reports:
<svg> elements do not seem to render at all. Not on my website, not on the html2canvas website either.
Specifications:

html2canvas version tested with:
Browser: Chrome, Firefox
Operating system: Windows 10

Hello !
it could be work if you substitute the svg width % for px
var widthv = ($(svg).width()); // return value in px
var heightv = ($(svg).height()); // return value in px
$(svg).attr('width', widthv).attr('height', heightv);
But I don't find any solution for svg charged as img. not inline.
If you have any solution ? or found alternative ???
Chris

#2583 fixes this issue


Fix permission issues with API 29 related to scope-storage

Task/Issue URL: https://app.asana.com/0/0/1202574319510580/f
Description
Android 10 introduced scope-storage that require the requestLegacyExternalStorage set to true and request the WRITE_EXTERNAL_STORAGE permission to be able to directly create files in the Downloads folder.
Steps to test this PR
Bug repro and fix

[ ] install from develop in device with API 29
[ ] download any file
[ ] expect the download to fail with Permission denied error
[ ] install from this branch in device with API 29
[ ] download any file
[ ] verify download succeeds
[ ] verify downloads in device with API 28 and API 30

Current dependencies on/for this PR:

develop

PR #2121   👈

This comment was auto-generated by Graphite.


Non-relative paths are not allowed when 'baseUrl' is not set. Typescript v5.2.2

Environment

Operating System: Windows_NT
Node Version:     v18.15.0
Nuxt Version:     3.7.1
CLI Version:      3.8.3
Nitro Version:    2.6.3
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      ssr, modules, ionic, vite
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
Upgrade nuxt project to use<EMAIL_ADDRESS>Describe the bug
Since upgrading to<EMAIL_ADDRESS>I get the following error in the self-generated tsconfig.json

{
  "extends": "./.nuxt/tsconfig.json"
}

Additional context
The root cause of the issue is actually due to the "#pwa" types path in the auto-generated ts-config.json

Logs
No response

have the same issue

Same issue here. Happened after upgrading from 3.6.5 to 3.7.3.

The baseUrl option is not set in .nuxt/tsconfig.json
https://stackblitz.com/github/nuxt/starter/tree/v3-stackblitz?file=.nuxt%2Ftsconfig.json

Okay in this this PR , it removed for dev env support. I am guessing some dependencies still need baseUrl?

I found my issue, I defined an alias node_modules/.pnpm/@prisma+client<EMAIL_ADDRESS>before upgrading to nuxt3.7. Just have to add ../ before it as  node_modules/.pnpm/@prisma+client<EMAIL_ADDRESS>is a none relative path.
Hope this helps

Seems my issues bubbles down to the "#pwa" path in the auto-generated ts-config.json file. Manually changing it a "./.nuxt/types/pwa" fixes it. However this will just be overwritten on build.

Seems my issues bubbles down to the "#pwa" path in the auto-generated ts-config.json file. Manually changing it a "./.nuxt/types/pwa" fixes it. However this will just be overwritten on build.

See this https://github.com/kevinmarrec/nuxt-pwa-module/pull/109

To override this temporarily, in your tsconfig.json override compilerOptions
{
  // https://nuxt.com/docs/guide/concepts/typescript
  "extends": "./.nuxt/tsconfig.json",
  "compilerOptions": {
    "paths": {
      "#pwa": [
        "./.nuxt/types/pwa"
      ],
    }
  }
}

Just sharing thoughts, I might be wrong again too.
I stand corrected, applying the above solution caused some weird behavior in typescript in my project, leading to some variables being set as type unknown
The proper method to override the paths in ./.nuxt/tsconfig.json as per https://nuxt.com/docs/guide/concepts/typescript#nuxttsconfigjson is to use nuxt.config.ts alias property as below:
alias:{
    "#pwa": "./.nuxt/types/pwa"
},

Just sharing thoughts, I might be wrong again too.
I stand corrected, applying the above solution caused some weird behavior in typescript in my project, leading to some variables being set as type unknown
The proper method to override the paths in ./.nuxt/tsconfig.json as per https://nuxt.com/docs/guide/concepts/typescript#nuxttsconfigjson is to use nuxt.config.ts alias property as below:
alias:{
    "#pwa": "./.nuxt/types/pwa"
},

This didn't work for me after adding the alias to nuxt.config.ts. The value generated in ./.nuxt/tsconfig.json is unchanged 😔

Here is working workaround in nuxt.config.ts
modules: [
    '@kevinmarrec/nuxt-pwa',
    // Workaround for broken types in nuxt-pwa
    defineNuxtModule({
      setup(_, nuxt) {
        nuxt.hook('prepare:types', ({ tsConfig }) => {
          // @ts-ignore
          tsConfig.compilerOptions.paths['#pwa'] = ['./.nuxt/types/pwa'];
        });
      },
    }),
  ],

Cannot find name 'defineNuxtModule'.

Cannot find name 'defineNuxtModule'.

js import { defineNuxtModule } from '@nuxt/kit';

Hi there! This problem is actual for me as well.
Environment:

Operating System: Windows_NT
Node Version: v20.9.0
Nuxt Version: 3.8.1
TypeScript version: 5.2.2
Package Manager<EMAIL_ADDRESS>User Config: ssr, vite
Additional Modules: vuetify

[like]  Alexander Barker reacted to your message:

From: Yauheni Vasiukevich @.>
Sent: Monday, December 25, 2023 10:28:37 AM
To: nuxt/nuxt @.>
Cc: Alexander Barker @.>; Author @.>
Subject: Re: [nuxt/nuxt] Non-relative paths are not allowed when 'baseUrl' is not set. Typescript v5.2.2 (Issue #23157)
Hi there! This problem is actual for me as well.
Environment:

Operating System: Windows_NT
Node Version: v20.9.0
Nuxt Version: 3.8.1
TypeScript version: 5.2.2
Package Manager: @.***
User Config: ssr, vite
Additional Modules: vuetify
image.png (view on web)https://github.com/nuxt/nuxt/assets/94754964/544ae824-fdf1-4598-9cfa-59c1cd20c887

—
Reply to this email directly, view it on GitHubhttps://github.com/nuxt/nuxt/issues/23157#issuecomment-1868915120, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AII3PFJ3FMK34EIFBXOLIETYLFINLAVCNFSM6AAAAAA4VBZIPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYHEYTKMJSGA.
You are receiving this because you authored the thread.Message ID: @.***>

To anyone experiencing the bug: To make sure we can have a look it is necessary to add a reproduction as described in https://github.com/nuxt/nuxt/issues/23157#issuecomment-1715985890

I also experienced the bug (with unchanged code from a working version so I could not create a reproduction) and found that deleting the node_modules folder by executing rm -rf node_modules fixed it.

Hi,
I reproduce on 'npx nuxi init nuxt-app' with the nuxt.config.ts as follows :
export default defineNuxtConfig({   devtools: { enabled: true },   srcDir: 'src/',   alias: {     '@': 'src/',   }, })
then
npm run generate

Hi, I reproduce on 'npx nuxi init nuxt-app' with the nuxt.config.ts as follows :
export default defineNuxtConfig({
  devtools: { enabled: true },
  srcDir: 'src/',
  alias: {
    '@': 'src/',
  },
})

then npm run generate
To correct the problem I added baseUrl as follows :
export default defineNuxtConfig({
  devtools: { enabled: true },
  typescript: {
    tsConfig: {
      compilerOptions: {
        baseUrl: './',
      },
    },
  },
  srcDir: 'src/',
  alias: {
    '@': 'src/',
  },
})

This fixed the issue for me. Just it disabled the loading of pages directory. I just commented line
srcDir: 'src/',
and now it's working as before. Thank you


[question] how to disable reset announcements?

Hello, I've set:
announceTimes: []
And I'm still getting reset announcements.
How can I disable them?
Thank you

You can disable reset for specific mines with /mine silent name
Or you can Change the config option to not announce resets

Thank you


Fixed #29461 -- Fixed ogrinspect test_time_field failure on SpatiaLite.

https://code.djangoproject.com/ticket/29461

buildbot, test on on bionic.

buildbot, test on bionic.

buildbot, test on bionic.


Add option to point gallery examples to deployed endpoints

Going to merge this so I can test it in practice.


Asynchronous health checks

To give clients an idea of the stability of a given services, an (optional) daemon could be implemented in this service that periodically sends heartbeat requests to individual services (e.g., to their /GET service-info endpoints). In order to provide this information to clients effectively, the ExternalService schema could be extended with an object property that provides some or all of the following (and possibly more) information:

Status code of last heartbeat
Time of last heartbeat
Time of last non-success status
Time of last success status

The frequency of heartbeats (and timeout!) is probably something that the admin of the cloud registry should set up in the app configuration.

Eventually this is probably something that should be discussed with the GA4GH to be implemented globally in the specs. However, for now I think this can be implemented in a relatively simple way:

Provide status code and time of last heartbeat, and time of last (un)successful heartbeat request via a dedicated endpoint, e.g., GET services/{service_id}/health
Add parameter to set heartbeat frequency to app configuration in cloud_registry/config.yaml

Implementation of uptime stats would be nice, but I think I will move this to a separate issue that can be implemented once the above is done.
For the last suggestion on adding usage stats, I will also open a separate issue but will leave it blocked until a concrete use case for such functionality comes up.

FYI, related discussion at GA4GH, but nothing concrete, so would go ahead as outlined

cwl-WES has an implementation of a daemon that runs tasks asynchronously in the background, although for a very different purpose. Perhaps there is a Python API for running something like cron jobs... In any case, it's important that these background checks are scalable over hundreds or even thousands (but certainly not millions) of services, so heartbeat frequency should probably have a reasonable minimum value of once every 30 minutes or so, with a max timeout of 3 seconds.

Related issue #20, could be implemented in coordination with this issue


Update highlight.js (bug in Java highlighting)

The version 8.0 of highlight.js using in the current version of remark has a bug with the Java highlighting. A leading class keyword is not highlighted correctly, only if a modifier like public is used in front of it.
There may be other issues that have been resolved upstream. The current version of highlight.js is 8.5. Remark currently works without modification with version 8.3 (just change the version number in line 20 in the make.js file). I also tried to switch to version 8.5 but with less success (Error: Parsing file remark/src/remark/highlighter.js: Line 744: Unexpected token ; while building remark with make).

Version 0.11 which fixed this has now been released.


Conflict in the configuration file when using confd

Hello to all,
I am using CoreOS as my distributed operating system. It is build on a docker container landscape. I want to use kong 0.4.1 as my api gateway and update the configuration file with confd when cassandra nodes raise. Confd parses a template kong.yml file and replaces Go template expressions. These expressions work with double curly braces. This  results in a conflict with some kong variables in the kong.yml like:
worker_rlimit_nofile {{auto_worker_rlimit_nofile}};

The Go template package tries to interpret this line as a go expressions and fails.
There are no possibilities to change the double curly braces syntax to something else in the Go language, so I need to know what the kong variables are and whether there are some possibilities to change the double curly braces syntax of the kong variables
Thank you

I don't have any objections in changing the placeholder format from {{placeholder}} to {placeholder}, especially because it's not being used by third parties and it's just used internally. @thibaultCha any thoughts on this?

{{ is a standard for other applications as well and I don't see why we should change it. It can surely be worked around when using Kong with confd.

I agree, @CConnection can you please check if confd allows some sort of escaping that will make it work?
Since I quickly hacked around it and decided to open a PR instead of reverting the local changes, just in case we want it to be merged. We can close both the issue and the PR if we decide otherwise.

A workaround that will work for sure is to replace those with hard coded values (wich are just YAML properties in kong.yml.
Since this is an edge-case (which again, can surely be worked around) I would still consider this a more valid solution than impacting the syntax of those placeholders.
Hard-coding them is also perfectly valid, those exist only to make people aware of them by linking them to more visible YAML properties.
Finally, they shall disappear anyways on the long term as I have plans to make the whole nginx property disappear (but still tweakable for advanced usage).

Thank you for your responses and efforts. I found a possibility to escape the characters with {{"{{"}} and {{"}}"}}. Isn't the nicest way but it works.

Perfect then!


WIP: Tying in systems to grid.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 53.01205% with 156 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

src/hex/coordinate.rs
29.13%
107 Missing :warning:

src/hex/shape.rs
43.18%
25 Missing :warning:

src/hex/grid.rs
82.96%
23 Missing :warning:

src/core/tile.rs
50.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines
Coverage Δ

src/core/tile.rs
33.33% <50.00%> (ø)

src/hex/grid.rs
88.83% <82.96%> (ø)

src/hex/shape.rs
65.15% <43.18%> (ø)

src/hex/coordinate.rs
78.29% <29.13%> (ø)


Discord Profile picture caching for too long

Hello!
I'm not sure if this is an issue, or intended behavior, but, I've changed the profile picture for my linked Discord account, and my profile picture on the rando's client UI is still my old one, it's been at least a month since I changed my profile picture, so I'm not sure if this is moreso a bug, or if the initial Discord login was just to setup an account and associate it with my Discord account, rather than my account on the rando client being by Discord account, which would need to be updated from time to time.
for further clarification, if the client uses my initial Discord login to create a new account for me, that's separate to my Discord account, then this is probably not an issue.
but if the client uses my Discord login as my account, then this seems to be a caching issue?
I haven't tried it in multiple devices to see if a different, newer install would result in my new profile picture being loaded or not, but a friend is facing the same thing after changing their profile picture, so I'm leaning into thinking this is an intended feature, than a caching issue, if not for the fact that, using the developer tools, the link for my profile picture in the rando client seems to be pointing to a link that's erroring out whenever I try to follow it using my browser.
I'd try to help or debug this myself, but I have no experience in JS or Electron, so I probably best not mess with this repository's code with low-quality code.
Apologies if this was intended behavior and I just got confused, I thought it'd be nice to bring up, at least.

Current behavior is that the profile picture ID is fetched on login and then stored on the rando server. So if you log out and log in, it should update your profile picture. Since we don't store any authentication tokens, there is currently no way to keep profile pictures up to date automatically. Might change that at some point... I'll leave this issue open as a reminder.

Why not store the auth token locally on the user's client, and upon boot up (or every week or so), evaluate if the photo changed or not (checksum maybe?), and if so, have the client upload the new one to the server?
A hurdle you might have is handling the client's input safely, which shouldn't be too hard since it's a .png, .jpe?g, .webp (or even a .gif file?
I'm assuming there's some form of authentication between the rando server, and the rando client, which is how the league times are handled and all, right?

It's not that simple unfortunately. The current authentication mechanism works like this:

The rando server starts an OAuth2 flow against Discord with its own secret
The user is redirected to the Discord OAuth2 login page.
Upon successful authentication, Discord redirects back to the backend of the randomizer with a token.
The backend uses that token to fetch the user ID, user name and profile picture from Discord and stores it into the rando profile. (If no profile with that user ID exists, one is created)
The rando backend generates a JWT (authentication token) that is passed to the rando frontend, which it will use to authenticate against the rando server.

As you can see, the Discord token never reaches the frontend, nor is it stored on the server. Storing OAuth2 tokens unfortunately isn't as simple as saving them into the database and be done with it. These tokens expire after a rather short amount of time, hence you always get an additional token, called refresh token, which allows the server to refresh the access token. This is also the reason we cannot store it locally in the launcher, because then the access token and refresh token would expire if you don't open the application for some days.
In general, keeping the OAuth2 sessions alive for all users just to update profile pictures seems a bit overkill. I'll have to have a look at whether there exist other means to fetch basic user profile data from Discord.

Oh yeah, that's fair
That's a great idea though, you could most probably try handing the frontend the user's Discord User ID, and having it query the Discord API for basic user details, and update them on the server every boot through the client?
I didn't know OAuth2 tokens lasted for so short, apologies!

No worries!
The frontend already has the user ID, but you also need an authentication token to query the Discord API so that won't work.

I think I heard that all you need is a bot to query the Discord API for a user's data
So, this might be a bit janky, but you can:

Front-end boots up
Front-end sends a request to the back-end with its own Discord user ID
Back-end sends a request to the Discord API using its own Discord Bot token, and updates the user's PFP and general data
Back-end sends a request back to the front-end to either prompt it to update its cache again, or just including the user's new data

This is probably a bit over-engineered and un-scalable, but I'm just giving my own ideas, for whatever they're worth
This endeavor is most probably achievable though, since there are plenty of websites (like this) that take in a User ID, and return general info of the associated user (Username, PFP, Badges, and account creation date)

Yeah something like that could work, but I'll probably skip the detour through the frontend and just let the backend update profile pictures periodically.

Fair, fair
I'm just concerned about unnecessary load, especially since there'll always be some amount of dead accounts, ya know?
but now that I think about it, there'll be some amount of people who'll boot up the client much more often than the periodic check, and they might hammer the back-end more if the check was done every time the client boots, so that's a fair solution, yeah.
Thanks for your time with this, means a lot!


[5.9][Dependency Scanning] Do not track source module dependencies separately in SwiftDependencyScanningService

Cherry-pick of https://github.com/apple/swift/pull/64778
Instead, treat them like any other module that is specific to the scanning context hash of the scan it originates from. Otherwise we may actually have simultaneous scans happening for the same source module but with different context hashes, and the current scheme leads to collisions.

@swift-ci test