Filtered, depth_first_search

Fixes #37

@WaDelma The Filtered adaptor should be a replacement for subtopo. It just doesn't have the IntoExternals required for Topo yet. Note that Filtered got some improvements after this PR.

Nice! I ended up implementing a messy kind of filtered Dfs in in conrod for sorting the widget graph in order of depth, only traversing the Z axis edges, ignoring X and Y. Looks like I might be able to replace it with something much simpler using Filtered :+1: Will have a closer look soon

Filtered is just a node filter. Another kind of filter (for edges) could be added.


update date kwarg in GetUserSnapshot

Summary

Type of change

[ x] Bug fix (non-breaking change which fixes an issue)

looks good, just needs a JIRA and to merge in latest from the main branch :)


To prevent sublime autocompleter popup after semicolon(;) at the end of line

After ;, i.e at the end of each line when I press enter , I get word 'prototype' is added() by the auto completer.I i press shift+enter then acts as normal enter without any autocomplete. added. How can I stop auto-completion after a semi-colon?
and this is the list of packages I have installed..If any of these packages causing problem plz help me out

Have you disabled SublimeCodeIntel for JavaScript?
I'm running just JavaScript Completions, and I have not experienced this issue yet.

I have not disabled JavaScript completions.Its still enabled. and fortunately i solved my issue by myself. A package called 'Auto Complete JavaScript With Method Signature ' was creating this problem. I disabled this package and my issue was solved.


Input Component: autocomplete attribute added to container div, not the input html

Expected Behaviour
<Input autocomplete="off" placeholder='Search...' /> should result in the following HTML:
<input type="text" autocomplete="off" placeholder='Search...' />
Actual Behaviour
autocomplete="off" is added to the container div element, not the input
Repo Link
https://codesandbox.io/s/f3jzm?module=/example.js
This is the example from the official docs

Capital "C" autoComplete. This is mentioned in the React documentation:
https://facebook.github.io/react/docs/tags-and-attributes.html

ah, thanks @layershifter. Is there any way I can update the codesandbox to fix this? There is a typo in 'search' too - placeholder='Seach...'

@mattgreenfield You can just perform your update and then save:

Or this typo/autocomplete issue is present in our docs?

I've got to be honest, I can't find where I found the link in the docs. But that codesandbox example is yours, not a fork created by me, Using 'save' as per your screenshot creates a fork.
Unless I'm just confused!
Thanks again,


mod is not authenticating

1.18.2
when i try to login with my password it says wrong password and kicks me off the server. when i use /register to enter a new password it says that i am authenticated but still continues to send "you are not authenticated" messages and my new password does not work at all. when i use /auth to update my password it says that i am not registered. i use /auth register to register myself (i am op) and updates my playerdata. however when i use auth list i do not show up in it and although /auth update is now working on console when i try to login on client it still says wrong password. i am unable to find the config file for easyauth in my server files.

Config is in mods/EasyAuth.
Can you send list of your mods just in case?

how do i fix this issue

I think you updated password for wrong uuid. It's a bit confusing right now and will be changed in future.
In command as auth update <uuid> <password> you should use uuid for lower-case version of your name. You can get it with command auth uuid <nickname> or with this site.
Also I would recommend to update to newer release

i have tried the auth update command, it just returns a blank behind the player name. as for why i haven't updated to the newer release, it is because my server is currently running on 1.18.2.

3.0.0-14 supports 1.18.2 too.
Can you send what exactly command do you type and your nickname? You can do it in Discord dm if you want.

/auth uuid Proxtos returns a blank

Can you try auth update 6d35102e-f09b-38f4-835c-1af4d065dc3d <new_password>?

thank you, it works! how do i get the uuid?

With site that I posted before.

thanks. i will let you know if there are any other problems


Add shortcut for closing last pager pane or current tab

Mac: Cmd+w
Windows: Ctrl+w/Alt+f4
Linux: Ctrl+w

When in a Pager, the shortcut should close the last pane. When there is only one pane, it should close the tab.
When outside of a Pager, it should close the tab.

Works now with Primary+W.


c220 - ignore absent dimm

Added an if statement to ignore if DIMM is not installed in slot. Example of Redfish API response below for reference.
	"Status":	{
		"State":	"Absent"
	}

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Bump upjet to the commit 2e361ad3b6e6

Description of your changes
Bump upjet to the commit 2e361ad3b6e6
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] ~Added backport release-x.y labels to auto-backport this PR if necessary.~

How has this code been tested
Uptest below:

/test-examples="examples/network/v1beta1/bastionhost.yaml"

/test-examples="examples/network/v1beta1/subnet.yaml"

/test-examples="examples/cdn/v1beta2/endpoint.yaml"


Cache getConfig()

Currently it requires the config file from disk every time the function is called, it should be cached.

node caches require() calls, so I don't know if there will be any benefit apart from one less function call.

Well that entirely works not how I would expect it to. But it's still a bit odd to be calling getConfig everywhere, which then calls require. having an object we can use would be better, probably.

If we do this, we will also be able to correctly set all the default variables in one place instead of spreading cfg || false everywhere in the code.
Probably by loading the defaults config and merging user config into it.


Should certain stdout messages go to stderr?

I noticed this issue while experimenting with strict mode.  When writing small unix-style utilities, it's nice if only expected output ends up on stdout, and other output ends up on stderr.
An example:
// find-recent-project-files
#!/usr/bin/env node
require('sywac')
    .strict()
    .option('--client <string>', 'specify which client the project was for')
    .then(argv => {
        /* list the project files */
    });

# touch recent project files for acme client
$ find-recent-project-files --clent acme | xargs -t touch

I think what I'd want in this situation is for find-recent-project-files to immediately write its usage information and error message to stderr, where I can see it, and then write nothing ("") to stdout, which will be read and ignored by xargs.
Instead what happens is that I don't see the error message, except in little bits as spam from xargs attempting to "touch" a bunch of random words and punctuation.
(This is probably a breaking change, but overall might make sywac's behavior more predictable.)

This is a good point.
I think the best practice is to output to stdout if and only if help text is requested (so I could pipe help content to grep or less); otherwise sywac should output (help content and error messages) to stderr when errors are encountered.
I agree that this would be a breaking change, but I'm all for it. Do you want to take a stab at this?
FYI, at some point I was also planning to replace all the .then() code with async/await, which I was going to reserve as another breaking change (since it would require Node versions 8+). I realize this would be a fairly significant refactor, but perhaps we could tackle both of these in preparation for a v2 release.

BTW I assume you're using .parseAndExit() since that's the only place sywac uses console; otherwise, when using .parse(), sywac doesn't output anything but leaves it up to the consumer to handle the result.output string as it chooses.
Regardless, it should be relatively easy to change the logic here to conditionally use console.error vs console.log: https://github.com/sywac/sywac/blob/14f5ef6d007d02caee25859e9ff3bcb83635aeed/api.js#L596-L599

@elliot-nelson I published the first v2 release candidate to npm as<EMAIL_ADDRESS>It should fix this problem. Give it a shot and let me know what you think.
See #54 for implementation details.


Restore strip_www functionality

The strip_www feature got bumped to ssl-only then out of existence. This proposes to bring it back. This draws on the strip_www: true default still in roles/nginx/defaults/main.yml. I can't say I've been around the server block yet, so please critique the  implementation.

Thanks!


Bumped the library version

Summary / Approach
Bumps the library version number for cache clearing as this is shipping with this PR: https://github.com/State-of-Rhode-Island-eCMS/ecms_patternlab/pull/186/files

Self approving.


Unexpected server response (426) when using WebSocket

When trying to use the provided code for accessing the order book:
const WebSocket = require('ws')
const uuidv4 = require('uuid/v4')

const ws = new WebSocket('wss://api-dax.btcc.com/ws/pub')

ws.on('open', () => {
  ws.send(JSON.stringify({
    MsgType: "QuoteRequest",
    CRID: uuidv4(),
    Symbol: "ETC_BTC",
    QuoteType: 2,
  }))
})

ws.on('message', (data) => {
  // Do something with GlobalTicker, OrderBook and ExecTradeBase
  console.log(data)
  ws.close() // Or remove this line to listen increment trade
})

I get the following error:
events.js:163
      throw er; // Unhandled 'error' event
      ^

Error: unexpected server response (426)
    at ClientRequest._req.on (~/workspace/btcc-node/node_modules/ws/lib/WebSocket.js:656:26)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:191:7)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:522:21)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)
    at Socket.socketOnData (_http_client.js:411:20)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at readableAddChunk (_stream_readable.js:178:18)
    at Socket.Readable.push (_stream_readable.js:136:10)

Note that this worked flawlessly the previous week and I haven't changed anything. Have you changed something on the server side?

ws url changed to wss://ws-dax.btcc.com/ws/pub

@jbargu Hello, Grabnar sorry we changed the address of the websocket.
Please use: wss://ws-dax.btcc.com/ws/pub
If it works fine with you, we can close this issue.
Cheers !

Thank you very much for your swift answers. I opened MR #2  that updates the URL for anyone else that may encounter the issue.


More variety in the changeset description

Current behaviour: Changeset descriptions always say: "Changed tag ... of node/way/relation XXXXX."
Suggestion: Split the description into "Added tag ... to / Changed tag ... of / Removed tag ... from node/way/relation XXXXX."
This should make it a lot clearer how certain tags were changed.

Or even better, we can have input field where we can change the text and add/remove/rearrange parameters. Possibly with a tick box "Remember for future edits".


Issuer agent, wallet build configuration tweaks.

Some issue profiles (idim, lsbc) depend on files hosted in the issuer-kit repository for their builds - see this and this. These are just configuration files, and this is preventing us from being able to archive the issuer-kit repository.
Builds for production issuers should be tweaked to remove this external dependency and be self-contained to this repository.

Opened #231 to address this - changes still need to be applied to OCP.
Since we are going to want to move issuers to Traction sooner rather than later, I opted for the minimal set of changes to make the builds self-contained to this repository. Once we move to Traction neither build will be required anymore.
I am also wondering if we should deploy the agents directly referencing the image tag, rather than a build with an image tag that is overwritten by the build parameters, potentially... The ACA-Py standalone chart would be very helpful in this scenario even if we decide to keep independent deployments.
c.c.: @WadeBarnes @i5okie

Also relates to https://github.com/bcgov/DITP-DevOps/issues/18


Retrieve properties description through Spring Config API

I would like to include description of some properties directly in the configuration file (.properties / .yaml), as comment or similar, and be able to retrieve it through Config Server API (.properties/.yaml/JSON/plain text).
Is this possible?

I don't think so, comments are ignored when processing the files.

Spring Boot has facilities for getting descriptions of properties from @ConfigurationProperties when metadata is generated. You could always have another meta property that lists descriptions.


Terminal:Clear shortcut keys clearing bug

I binded a shortcut key [Ctrl] + [Shift] + [K] + [C] to "Terminal:Clear" command. When I press the shortcut key combination, the terminal does clear. However, in the next command, after typing two characters, the third character jumps on to the bottom line. Upon executing the command, the history is visible again.
This does not happen if I run the "Terminal:Clear" in the command palette.
To reproduce
Based on the GIF below that is running Windows Powershell;

I type "dir" to list the directories.
I press [Ctrl] + [Shift] + [K] + [C]
I type "cd src" to navigate into the src directory. Note how on the third character, it jumps to the bottom of the terminal.
I press [Enter] to execute the command. Now the history of the previous directory listing is showing again.

/duplicate https://github.com/microsoft/vscode/issues/75141


git issue 2053

duplicate key value violates unique constraint" error with Postgres SQL when trying to add a user who is already there in one user store domain to a different user store domain
public jira : https://wso2.org/jira/browse/IDENTITY-7297

Fixed with IS 5.4.1


serializers: citeproc serializer

Adds a citation formatting serializer.

Signed-off-by: Alexander Ioannidis<EMAIL_ADDRESS>

Coverage decreased (-0.5%) to 98.039% when pulling 8c7a94a919924ecd68c46ee64361231361fc7a24 on slint:citationformatter into dbae2a29c718440c8e8d50ffc61b65c871013141 on inveniosoftware:master.


fix: fix fromSurface:false screenshoting

What kind of change does this PR introduce?
Fix.
Did you add tests for your changes?
Yes.
If relevant, did you update the documentation?
Yes.
Summary
An easy fix to https://github.com/puppeteer/puppeteer/pull/8496 that I just found.
Does this PR introduce a breaking change?
No.
Other information
Hope it will go in 15.2.0! :-)

Will test on Linux and Mac why screenshot differs there...


Add me to the OWNERS file

/assign zacharysarah

/lgtm
/approve

Doh, that was brainless of me. Fixing now.


Documentation needs to flag that this is not compatible with class-transformer

Is there an existing issue that is already proposing this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe it
I spend a frustrating few hours wondering why my Expose() decorator was not being honoured. I was using the @nestjs/class-transformer package which felt appropriate. However the ClassSerializerInterceptor class from @nestjs/common does not read this meta data store by default.
This is incongrous and has caused many members of my team to hit the same problem.
Describe the solution you'd like
The README needs to be clear why this package exists, and why is it better then class-transformer, but most importantly, how should it be enabled, and how to handle libraries that might use class-transformer decorators.
Teachability, documentation, adoption, migration strategy
No response
What is the motivation / use case for changing the behavior?
The motivation is simply to improve the developer experience.

The README needs to be clear why this package exists

Why does this forked package exist?


Create Blog “test-blog”

Automatically generated by Netlify CMS

👷 Deploy Preview for symphonious-toffee-f79c99 processing.

Name
Link

🔨 Latest commit
74feb8047bd777654793235cc716d2b9a66fa317

🔍 Latest deploy log
https://app.netlify.com/sites/symphonious-toffee-f79c99/deploys/6578233fe008e1000873ac9b


Limit how many rows show in the related table

Description: Add an option for app authors to limit how many rows of characters appear in the related table title.
Location: Reporter > Panel Option > Add a header in the list for Comments
label: Show full comment title' ON by default Tooltip: When toggle off, only the first line of the comment will show`
limit how many rows show in the related table

@skrishn @jmhauck
Approach

We will add a property showFullCommentTitle in the reporter component
This will be true by default to support backward compatibility
Based on the property value we will add the CSS to show the comment title in one line or multiple lines

When showFullCommentTitle toggle on
When showFullCommentTitle toggle is off

Please let us know if any changes required in this


Tabs inside a Page component is broken

Using the Tabs component inside of a Page causes the browser to hang.
Expected Behavior
Tabs appear as shown in the storybook (https://backstage.io/storybook/?path=/story/tabs--default)
Current Behavior
The browser hangs and throws an out of memory error.

Possible Solution
The problem occurs in this useEffect block: https://github.com/spotify/backstage/blob/bbd75a0981a5b7418ecf1afa2124738d7b18f494/packages/core/src/components/Tabs/Tabs.tsx#L91-L108
By debugging I can see that during the first render the wrapperWidth is -30. This causes newChunkedElementSize to be -1 and ultimately the chunkArray method runs forever.
It may have something to do with the grid layout, which causes the width of the wrapper to be 0 during the initial render. I'm not too familiar with this, otherwise I would try to fix the problem.
Steps to Reproduce
export default function ServicePage() {
  return (
    <Page theme={pageTheme.service}>

        <HeaderLabel label="Owner" value="me"/>

      <Tabs
        tabs={[...Array(4)].map((_, index) => ({
          label: `ANOTHER TAB`,
          content:
Content {index}
,
        }))}
      />
    </Page>
  );
}

Hi! So I've been looking at this a bit. Firstly yeah, chunkArray definitely is buggy and I am making a pull request to address that.
But even fixing that, there's another issue. In your example code, the wrapping div around the tabs has nothing to keep it wide enough, so it collapses and gets narrowed into nothing if you touch the width of the window. That triggers a second bug. That's of course unexpected, and I will look into that too, BUT ...
Thirdly, the actual fix for you, is to use the HeaderTabs component instead of Tabs :) It is made for this exact purpose, and is connected in the CSS to the proper slot of the grid model that it happens to be part of. Therefore its placement and size automatically becomes correct. It is explicitly made for second-level navigation within a page.
So would you mind trying out your solution with the HeaderTabs component and report back whether that works better? Its props interface is a bit different but I am sure you'll be able to make it work pretty easily.

Yeah, makes sense. I think with your fixes this can be closed now. Thanks again!


Display instance uptime and/or launch time

Launch time appears to be available directly in the DescribeInstances response.
Uptime would require subtracting that from current time, but I also think it would be more useful.

Updated


Update the applying security to proxy services guide

Purpose

$title

This PR adds a way to set the security/encryption properties via the source view by editing the Xml file directly. But this should be achievable via the diagram view. Created an issue to make the changes accordingly to the doc once the mi-vscode feature is available.


Unify builtin build options

Since commit deabd4a5466321fa07fffb253426a94d0a8555ea, psl2c has been replaced by psl-make-dafsa.
Thus the builtin PSL data is always generated the same way, and the value of the --enable-builtin configure option does not matter anymore.
The libidn/libidn2/libicu choice for the builtin data configure option should be replaced by a boolean choice, to indicate whether PSL builtin data should be generated or not, and whether suffixes_dafsa.h should be used by default in src/psl.c.

I am not into Meson, so what about the use of enable_builtin in meson.build.in ?
Also, even if tests/Makefile.am can be cleaned up, in the future we might add/ remove tests dependent of BUILTIN_....
Last but not least, when we remove --enable-builtin, are any external build scripts that could possibly break ? Just thinking.. (./configure just warns about unknown options).

To be clear, these are just light-weight concerns. If we can assure that meson builds are not breaking, I would be fine with such a cleanup.
Thanks for bringing this up.

We can have --enable-builtin=yes/no/auto.
I can test the Meson and autotools build, but not the Windows build.
Also, if --enable-builtin is no, suffixes_dafsa.h should not be generated.

I can test the Meson and autotools build, but not the Windows build.

Me neither. We leave that to the Windows devs. They will come up with a fix sooner or later (likely after the next release).

Also, if --enable-builtin is no, suffixes_dafsa.h should not be generated.

Sounds reasonable. Just keep it simple and keep in mind that we also have to generate tarballs with everything in it. So a make dist then needs the right configure flags, else the tarball might be incomplete (make distcheck should fetch it). Also VPATH builds should work (for Linux package maintainers).
Today I got access to Github Actions beta, which gives us free access to their CI platform. I might find some time in ~2 weeks to look into it. We should be able to test all the above cases with that. Travis-CI is so tedious to change/configure and it's very slow.

We can have --enable-builtin=yes/no/auto.

Sure, would be cool if you work on it.


Add check if no new data in a cube

Add check 'if no new data in a cube' after refresh of data source.
Typical checks: data for yesterday, data for today.
Can be dummy data source, that query one date without details.
E.g. after refresh of DS - run macro, that will make a check (macro as can be any logic). Result of macro - true / false. If false - postpone refresh.
Keep process alive or tell external 'refresh' about required postpone?
If handle locally -concern about sustainability of BOA, enable/disable, logon/logoff - test.
add parameters to ControlTable - "Delay", "Delay try (min)". After run of 'after DS macro' main sub Refresh will check indicator of delay (true/false), if yes - saplogoff, disable BOA, Sleep for specified minutes, start Refresh from the beginning.
If external Reports Controller (independent) - ?

Added opportunity to make several attempts to get the data from data source.


0 use variables (linearity bug)

The following should not type check, but does:
const : Int -> Int -> Int
const a b = a

The type checker should only accept the following (which is currently accepted):
const : Int -> |Int| 0 -> Int
const a b = a

Fixed by 8bf5df7


Bug: back button

Open the pop-up. Click on a button in the pop-up that is used for navigating to another page. Now go back to the previous page. Sometimes the pop-up automatically opens. Sometimes the buttons to open a popup don't work anymore.
This is due to the fact that the back button in subviews or the back button in mushroom card call the history back function m. This will open the url with the #xyz and therefore conflicts with that back. As a user I don't won't to see the pop-up when I go back, but I want to see the parent screen.

Hi and thanks for your feedback! You can now change this behavior in the new v1.0.1:
https://github.com/Clooos/Bubble-Card/releases/tag/v1.0.1


[oneDNN] Add fusion for dilated Conv2D and DepthwiseConv2dNative

Fuse Conv2D or DepthwiseConv2dNative wrapped by SpaceToBatchND and BatchToSpaceND to respective Conv2D or DepthwiseConv2dNative with dilation attribute.

Hi @ezhulenev, Can you please review this PR ? Thank you!

Hi @ezhulenev, Can you please review this PR ? Thank you!

Hi @yimeisun123 Can you please rebase your branch and resolve the conflicts? Thank you!

Hi @ezhulenev, Can you please review this PR ? Thank you!

Hi @ezhulenev, Can you please review this PR ? Thank you!

Hi @ezhulenev, Can you please review this PR ? Thank you!

Hi @ezhulenev, Can you please review this PR ? Thank you!

Hi @ezhulenev, Can you please review this PR ? Thank you!

Hi @ezhulenev, Can you please review this PR ? Thank you!

Hi @ezhulenev, Can you please review this PR ? Thank you!


OIDC Discovery Error: cURL error 28: Resolving timed out after 3000 milliseconds

Describe the Bug
Getting this Error only with Bookstack Container (https://hub.docker.com/r/linuxserver/bookstack)
OIDC Discovery Error: HTTP request failed during discovery with error: cURL error 28: Resolving timed out after 3000 milliseconds (see https://curl.haxx.se/libcurl/c/libcurl-errors.html) for https://auth.xxxx.com/realms/xxxx/.well-known/openid-configuration
Steps to Reproduce
Works fine with other Apps linke "keycloak traefik forward auth" ...
Expected Behaviour
Is there a way to increase the curl timeout ...
Screenshots or Additional Context

Browser Details
Chrome
Exact BookStack Version
[BookStack v22.03]
PHP Version
image:  lscr.io/linuxserver/bookstack
Hosting Environment
Debian 11 VPS

Hi @itxworks,

Is there a way to increase the curl timeout ...

No, not without editing app files at least. I'm not sure editing the timeout is the answer here, three seconds is quite a long time for a request resolve to occur. It indicates there's an issue elsewhere.

Is that https://auth.xxxx.com/realms/xxxx/.well-known/openid-configuration URL accessible from the BookStack host when manually sending a curl request?

If so, how long does it take to resolve?
Does this still work when accessing the container?

curl https://auth.xxxx.com/realms/xxxx/.well-known/openid-configuration

OK ... thx


Hawkular charts timeline

Change default color of hawkular events, timestamps are used in whole timeline directive rather than Date objects.

LGTM

Merged #161


pluginInit.js Object prototype change breaks other code that enumerate objects in Android (5.0.1)

I'm submitting a ...  (check one with "x")

[ ] question
[x] any problem or bug report
[ ] feature request

If you choose 'problem or bug report', please select OS:  (check one with "x")

[x] Android
[ ] iOS

cordova information:  (run $> cordova plugin list)
com.googlemaps.ios 2.6.0 "Google Maps SDK for iOS"
cordova-custom-config 2.0.3 "cordova-custom-config"
cordova-plugin-actionsheet 2.3.3 "ActionSheet"
cordova-plugin-admobpro-firebase 2.31.4 "AdMob Plugin Pro"
cordova-plugin-extension 1.5.4 "Cordova Plugin Extension"
cordova-plugin-file 4.1.1 "File"
cordova-plugin-file-transfer 1.5.1 "File Transfer"
cordova-plugin-firebase 0.1.25 "Google Firebase Plugin"
cordova-plugin-geolocation 2.1.0 "Geolocation"
cordova-plugin-googlemaps 2.3.0-beta-20180406-1845 "cordova-plugin-googlemaps"
cordova-plugin-inappbrowser 2.0.2 "InAppBrowser"
cordova-plugin-splashscreen 3.2.2 "Splashscreen"
cordova-plugin-whitelist 1.2.2 "Whitelist"
cordova-plugin-x-socialsharing 5.1.7 "SocialSharing"
cordova-sqlite-ext 2.2.0 "Cordova sqlite storage plugin with extra features"
uk.co.workingedge.phonegap.plugin.launchnavigator 3.2.1 "Launch Navigator"

If you use @ionic-native/google-maps, please tell the package.json (only @ionic-native/core and @ionic-native/google-maps are fine mostly)
Current behavior:
When enumerating/iterating objects, it seems the Object.prototype.assign = function() { declaration in pluginInit.js is causing issues whereby the function being called on the object does not exist.  For example, I have the InAppBrowser plugin installed.  In Android, whenever a link is clicked in my app, the following code gets run:
addEventListener: function (eventname, f) {
            if (eventname in this.channels) {
                this.channels[eventname].subscribe(f);
            }
        }

...where this.channels are defined as follows:
this.channels = {
            'loadstart': channel.create('loadstart'),
            'loadstop': channel.create('loadstop'),
            'loaderror': channel.create('loaderror'),
            'exit': channel.create('exit')
        };

The error received is Uncaught TypeError: this.channels[eventname].subscribe is not a function where eventname is "assign".
This particular example can be workedaround by changing the if statement to if ( (eventname in this.channels) && ( typeof this.channels[eventname].subscribe == 'function' ) ) { but I have also come across a related issue in the jQuery library (error Uncaught TypeError: (gb.tweeners[b] || []).concat is not a function where b is "assign".
Expected behavior:
Iterating/evaluating objects without issue.
Screen capture or video record:

Related code, data or error log (please format your code or data):
The person who share your project files on Github (or other git repository) is in faster lane than other people.
Please share your project files on Github or others(Bitbucket, Gitlabs...etc).
If you don't want to share your project files, please create a demo project, then share it.

Screen captures, and/or native logs(such as Logcat, xcode logs) are appreciate.

Giving much information, you are waiting time is less.
Thank you for your cooperation.

Android 5.0.1 has original Object.assign().
Thus, this code does not run.
if (typeof Object.prototype.assign !== "function") {

If you still doubt, please share the reproduce project files on GitHub.

I commented your code out and the problem was solved so I'm pretty certain it's causing an issue. I have worked around it though so I will close this if you don't think it's a problem.

I said If you still doubt, please share the reproduce project files on GitHub.


Broken link in docs

Is there an existing issue for this?

[X] I have searched the existing issues

Issue summary
The InneryEye WSL docs link in https://github.com/microsoft/InnerEye-DeepLearning/blob/main/docs/environment.md#operating-system is broken.
What documentation should be provided?
I guess the path should be /docs/WSL.md, not /docs/docs/WSL.md. I haven't checked other links.
AB#6699

Closes in https://github.com/microsoft/InnerEye-DeepLearning/pull/768


Feat: Close account and settle funds.

Close the account for the open order and settle / reclaim all funds.

close open order account added here: https://github.com/Dodecahedr0x/meta-dao-frontend/commit/db8bb8e9ebc3ee9f7f43da183120372d1e22d6ed. settle added earlier by you


Fix: OnlyDirectDependencies and DevDependencies Option

When the Options onlyDirectDependencies was provided, the script always took the dependencies, even if the flag devDependencies was provided. This Change gives you only the direct development dependencies if the flags onlyDirectDependencies & devDependencies ist provided. When onlyDirectDependencies is the provided without the devDependencies Options, it will return the normal dependencies.
fixes #11

Good spot! Thanks for PR


fix(map_based_prediction): fix prediction logic for crosswalk user

Description

fix prediction policy for crosswalk user (PEDESTRIAN, BICYCLE)

If the object is within crosswalk, the module outputs prediction path toward both side of the crosswalk at all time.
If the object is within road, the module outputs prediction path toward both side of the nearest crosswalk at all time.

befor(the module does NOT output prediction path toward exit side)
https://user-images.githubusercontent.com/44889564/179123309-31ed0a0b-086b-4a59-b644-a5aa042a1f7d.mp4
afterr(the module outputs prediction path toward exit side)
https://user-images.githubusercontent.com/44889564/179123402-233885dc-f79f-4f71-90c3-525fe3d80684.mp4
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3
I don't think so. In this situation, there is possiblity that the pedestrian actually have intent to cross the road, so ego should stop at crosswalk and confirm whethter the pedestrian want to cross or not.


Error when merging file

Having error, when trying to merge pdf files into 1
dereferenceObject: problem dereferencing object 7: parse: duplicate key
  _, err = pdfcpu.Process(pdfcpu.MergeCommand(filePaths, baseDir+".pdf", pdfcputypes.NewDefaultConfiguration()))

UPD: Pdf files were generated by electron

Please run pdfcpu with -v and post the stacktrace.
Thank you so much for reporting this!

Duplicate key is a parsing error.
Please check with pdfcpu if your source files are valid:
pdfcpu validate a.pdf
If they are not there is no point in trying to merge them.
I am closing this for now.


fix(jsx): fix handling of SVG elements in JSX.

94d8471ba1ed1fab8ee852869348497d888726ad : fix #3179
2729019036b09aa6da600810fd72285771f0b766 : Replace camelCase with kebab-case, as in https://github.com/honojs/hono/commit/a036181677a1e6d3611f6d10323e9c4c57d2bb9b in dom

The author should do the following, if applicable

[x] Add tests
[x] Run tests
[x] bun run format:fix && bun run lint:fix to format the code
Add TSDoc/JSDoc to document the code

@usualoma
Thanks! Looks good. Merging now.


PartialEq on exporter error

So assert_eq!(..., Err(...)); works with Specta errors. This really annoying but io::Error doesn't impl PartialEq so will need to work around that by converting it into a custom Specta type.

Already done


Method CheckCollideWith

I want to check if two rigidbodys colide with each other,
RigidBody br;
RigidBody br2;
....
...
br.CheckCollideWith(br2 as CollisionObject); // always true!
Also Softbody.CheckCollideWith doesnt seem to work right.

CheckCollideWith returns whether Bullet should check for collisions between two bodies, not whether collisions have occured.
This page shows how you can check for collisions:
https://github.com/AndresTraks/BulletSharp/wiki/Collision-Callbacks-and-Triggers


feat: pretending to add a feature

To test the changelog generator

Context: https://github.com/nestoca/actions/pull/35#discussion_r1320238387


Make patches toggleable by default

In the configuration panel, when selecting your patches default left click behavior is to select one patch and clear the other selected patches. You have to hold down control and click to toggle your patches and select multiple. I'd like default left click behavior to act like a control click and just toggle the patches you have selected.

@ashtongraves Unfortunately this behavior is defined by Runelite for any config of type Set<String>. I could potentially change this to a set of 9 different checkboxes, but that's an ugly solution. Could you file an issue with Runelite for this? They could hopefully change this pretty easily.


Keyboard scroll won't work

Submit an Issue
Expected behavior:
Using keyboard arrows should scroll.
##actual behavior
Using keyboard arrows should scroll.
Steps to reproduce the problem:
Start searching in the search field.
Use keyboard arrows to scroll down
If the result list is has a scroll, using the keyboard arrows won't scroll
Environment (component version number, Browser (including version), operating system, hardware, etc):
Component Version: 2.0.10
Chrome: 62
Windows 10
Screenshots (optional, but very helpful):

Fixed in v2.1.1. Ideally we should probably switch to iron-a11y instead of the custom handlers that were written. 🤷♂

Thanks Randy! will take a look at iron-a11y.


Test proxy & storage tests improvements

In this PR, we:

Removed unused definitions in sdk/core/azure-core-test/inc/azure/core/test/network_models.hpp.
Removed unused functions TestBase::ValidateSkippingTest() and TestBase::IsValidTime().
Added an overload of function TestBase::InitClientOptions().
Removed unused functions TestProxyManager::SetStopRecordMode(), TestProxyManager::SetStopPlaybackMode().
Rewrote proxy matcher setting logic.

Use json object rather than hard-coded json string, for better readability and maintenance.
Exclude Expect and Connection headers so that recording made by libcurl can be used by WinHTTP and also the other way around
Removed some unnecessary ignored headers
Added some ignored query parameters

Fixed an issue in libcurl transport layer. Closes https://github.com/Azure/azure-sdk-for-cpp/issues/4213
Fixed an issue where libcurl transport layer adds Content-Length header for HEAD/GET/DELETE requests, which caused a behavior misalignment between libcurl and WinHTTP, making the requests recorded by one of the transport layer unusable by the other.
Fixed a bug where test proxy sometimes discarded request body.
Fixed a bug where requests were not properly redirected if Host was set in the original request
Enabled some storage test cases that were disabled in https://github.com/Azure/azure-sdk-for-cpp/pull/4118. Closes https://github.com/Azure/azure-sdk-for-cpp/issues/4147

Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[x] C++ Guidelines
[x] Doxygen docs
[x] Unit tests
[x] No unwanted commits/changes
[x] Descriptive title/description

[x] PR is single purpose
[x] Related issue listed

[x] Comments in source
[x] No typos
[x] Update changelog
[x] Not work-in-progress
[x] External references or docs updated
[x] Self review of PR done
[x] Any breaking changes?

Thanks @antkmsft !
@gearama Can you please help review this PR?

/azp run cpp - keyvault - ci

/azp run cpp - attestation - ci

need to make sure all the other piplines run , make a change in the read me in the folder of the services to kick in the test runs

need to make sure all the other piplines run , make a change in the read me in the folder of the services to kick in the test runs

@gearama  What change do I need to make to enable the tests?

@Jinming-Hu, I think @gearama meant that you can touch some files in each of the library, so the CI would trigger a run of cpp - (library) - ci. The other way to do this is probably by manually kicking off these pipelines.

@Jinming-Hu, you can trigger CI pipelines manually, as I just did for identity pipeline, but the runs won't be visible here.

Maybe it is better to just add a space into each library's inc/library.hpp header (undoing it after the PR is done).
I wonder if running non-CI pipelines would give us the same level of verification (although taking longer). These ones you can run via /azp run cpp - (library).
Next week I'll bring this up, I think we should allow the /azp command to trigger runs for CI pipelines, even if none of the files from that library was modified in the PR. Because 1. a responsible human triggers the command knowing best what he wants; 2. This PR demonstrates it could be useful/needed sometimes.

@antkmsft Really? There's no way to trigger the pipeline without actually making changes? Is that how pipeline works? It's kind of inconvenient.
So we'll need to add an extra empty line or something in the README.md to trigger the pipeline. If all the tests pass, we revert the changes. It that correct?

@antkmsft thanks for the tips. There are  other issues to be resolved before this PR can be merged. I'll trigger other pipelines when I think it's ready for merging.

@Jinming-Hu, apparently, you can trigger the non-CI pipelines, which are heavier, and do also run Live tests, but not the CI pipelines, for some reason. Maybe as a slight side effect of some config, but almost no one noticed until now (I've noticed before, but I didn't have that much to run so I worked around it. In your case, it shows that it is better we have that ability).
I would also ask for "run multiple pipelines via single comment" support. Every time I need to run 5 pipelines, I need to leave 5 commants, receiving 5 bot replies back. This at least clutters the comment space in a PR.

FWIW, your current changes did succeed in the identity CI pipeline: https://dev.azure.com/azure-sdk/public/_build/results?buildId=2114159&view=results

FWIW, your current changes did succeed in the identity CI pipeline: https://dev.azure.com/azure-sdk/public/_build/results?buildId=2114159&view=results

I noticed WinHTTP transport layer is not covered in the CI. Is this a known issue? Why isn't it tested in CI?

Hmm, is it not? Can you open an issue and bring more details?

Could it be just naming? The pipelines that build on Windows + libcurl, have it in their name, while the ones using WinHTTP don't have _winhttp in their name?

Hmm, is it not? Can you open an issue and bring more details?

Opened an issue https://github.com/Azure/azure-sdk-for-cpp/issues/4245

@Jinming-Hu, apparently, you can trigger the non-CI pipelines, which are heavier, and do also run Live tests, but not the CI pipelines, for some reason. Maybe as a slight side effect of some config, but almost no one noticed until now (I've noticed before, but I didn't have that much to run so I worked around it. In your case, it shows that it is better we have that ability).
I would also ask for "run multiple pipelines via single comment" support. Every time I need to run 5 pipelines, I need to leave 5 commants, receiving 5 bot replies back. This at least clutters the comment space in a PR.

cc @danieljurek any suggestions? Is there an azp run command we could use to run difference service pipelines on a PR?

/azp help

@Jinming-Hu, apparently, you can trigger the non-CI pipelines, which are heavier, and do also run Live tests, but not the CI pipelines, for some reason. Maybe as a slight side effect of some config, but almost no one noticed until now (I've noticed before, but I didn't have that much to run so I worked around it. In your case, it shows that it is better we have that ability).
I would also ask for "run multiple pipelines via single comment" support. Every time I need to run 5 pipelines, I need to leave 5 commants, receiving 5 bot replies back. This at least clutters the comment space in a PR.

cc @danieljurek any suggestions? Is there an azp run command we could use to run difference service pipelines on a PR?
@antkmsft and @Jinming-Hu did you try something like /azp run cpp - attestation - ci? I assumed that would work to trigger a CI run of any pipeline (using its name), without having to manually make file changes.

run:
Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"

You can trigger builds against PRs but not using /azp commands in the GitHub PR. This is because the /azp command only works on builds whose trigger conditions include the PR against which you're testing. We've requested that this feature be changed to support the scenario described.
To do this go to the project (public) where you want to trigger the pipeline and select the pipeline you want to trigger.
Click on the blue Run Pipeline button:

In the Branch/tag field enter refs/pull/<PR-Number>/merge (in this case refs/pull/4241/merge):

FWIW, I think I may have a short-term fix for the attestation tests; I'll include a better fix, but it's going to collide with the changes that Jinming has made (the ignored headers list appears to be highly storage specific, we need to include a bunch of headers to the ignored headers list).
I think we also need to reengineer the list a bit to allow individual SDKs to add service specific ignored headers. that would allow the core list be the set of headers that apply to all SDKs and allow individual SDKs to add service specific headers.

Test  pipeline:
Storage: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2178053&view=results
Identity: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2178050&view=results
Keyvault: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2178052&view=results
Attestation: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2178047&view=results

@LarryOsterman @antkmsft @gearama
I think this PR is now ready for merging. I rebased on top of the latest main branch. CI pipelines all passed. Can you review the PR again?

ping @LarryOsterman @gearama @antkmsft


MRG: If _check_fname() cannot find a file, display the path in quotation marks to help spot accidental trailing spaces

We had a user on the forum who got an error message about a missing file that didn't actually seem to be missing. Turns out a trailing space was present in the search path, which was hard to spot.
https://mne.discourse.group/t/the-source-estimate-is-not-displayed-i-think-it-may-be-a-bug/6993/4
Here, I'm changing the FileNotFoundError message to put the path in quotation marks to help identify such issues quicker in the future.

Failing tests are unrelated


Production Checklist

[x] cargo audit
[x] cargo geiger
[x] clippy
[x] all public interfaces documented w/ examples
[x] more tests
[ ] ...?

I am currently happy with the state of the repository, so I'll be closing this one.


Up down left right gestures

It would be amazing if you could add gestures that would move u in games (ex: put hands toghether and point where you want to go) Also, this driver is great, keep up the good work!

I also wanted to ask if you can map a gesture to reaching over the shoulder (for example, to get a shield in space purate trainer)


How to get saved media?

In this package, there is the save({mediaId}) and unsave({mediaId}). Is there any way to fetch the saved media?
In the Network Monitor in the browser console, when accessing the Saved items, the https://i.instagram.com/api/v1/collections/list/?collection_types=["ALL_MEDIA_AUTO_COLLECTION","MEDIA"]&include_public_only=0&get_cover_media_lists=true&max_id= request is made, but I ain't sure it will only fetch the saved media.

You can fetch saved medias with this package for the moment. I will maybe try to implement it.


wngc comparison takes name, taints into proper account

Issue #, if available:
Description of changes:
Simplify and correct worker node group configuration slice comparisons:

take name into account when comparing worker node groups
ignore order of taints when comparing worker node group configuration taints
use existing, correct method for taint slice comparison

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


Update 231

IDEA-231 Java 17 Kotlin 1.8.20

the commit is dirty, but as an example of what I did, I think it will come in handy
Then you can remove


fix: original attempt used Map, but accidentally used expando properties instead of .set/.has

I looked at this project because I was curious after seeing the excellent original video and followup! I was surprised that the _Slow Map/Set attempt performed so badly compared to the _Fast linked list implementation...
It turns out, this was mostly due to two issues:

the linked list version has high level optimizations: don't update unless the object has changed cell positions, and track duplicates when querying by tracking queryId (this avoids needing a new Set). These have at least an order of magnitude impact on the overall performance that it overshadows the impact from changing underlying data structures (Map/Set vs LinkedList).
the _Slow version used the Map instances incorrectly: const a = new Map(), but then rather than a.set(key, val), the original attempt used a[key] = val and key in a (for testing). This was treating the Map as a plain object (same with the Set). V8 especially has specific thresholds when a plain object's underlying c++ implementation becomes deoptimized due to a large number of hash keys. So that was happening here!

This PR does three things:

fixes the SpatialHash_Slow (now called SpatialHash_SlowFixed) implementation to use the correct Map/Set APIs. This made the FindNearby benchmark faster than the LinkedList attempt (!)
Adds a new SpatialHash_SlowFixedOptimized that includes the Map/Set fixes, but also applies the optimizations the _Fast version received: abort updating the grid if the position hasn't changed, and track queryId when calling FindNear so that a plain array can be returned instead of a Set. This implementation is equivalent in speed to the _Fast linked list version.
Adds a new SpatialHash_FlatArray implementation that avoids Map/Set entirely in favor of plain arrays. This implementation is about ~2x faster during Query than the _Fast version (I did this because I was curious if the array would have an effect on perf, this probably has bugs and no one should use it!).

I doubt you'll ever look at this, but if you do, thanks for making these videos! They're impressive and easy to follow. And your principles of optimization were spot on! Really great for new programmers to see this. Hopefully this PR helps those new programmers, too!
SpatialHash_Fast vs SpatialHash_SlowFixed

SpatialHash_Fast vs SpatialHash_SlowFixedOptimized

SpatialHash_Fast vs SpatialHash_FlatArray

First: thanks again for the great YouTube videos, and thanks to @kirbysayshi for the follow up pulls.
I did a little more spelunking on this change (because... why not?):

Added a Sparse Array - similar to FlatArray, but using a map for outer cells.
Added a Test_Record() to record all of the search results (basically identical to Test_FindNearby() with an array)
Added Test_Verify(first, second) that sorts and verifies records (by position only right now) and returns true if they are the same.

Notes:

gridSlowFix can switch back to Set.
There's duplication of indices and _cells max/min; so I just deleted it in SparseArray
Multiple runs show FlatArray / SparseArray exchanging places. for fastest. At this point, it's probably noise or the fact that Performance.now() can be coarsened depending on site isolation(?)
⚠none of them returned the same search results after Update  - sanity check: the _client arrays are identical
For me, I'll probably use SparseArray, once I figure out why Update is having a swell time.

Spatial Grid SlowFixOpt - FindNearby: 12.399999976158142ms
Spatial Grid Flat - FindNearby: 10.199999988079071ms
Spatial Grid Sparse Array- FindNearby: 9.5ms

function Test_Verify(first, second) {
  if (first.length !== second.length) {
    return false;
  }
  for (let i = 0; i < first.length; i++) {
    let firstSet = first[i]
    let secondSet = second[i]
    if (firstSet.length !== secondSet.length) {
      return false;
    }
    function sortPos(a, b) {
      const first = a.position[0] - b.position[0]
      if (first !== 0) return first
      return a.position[1] - b.position[1]
    }
    firstSet.sort(sortPos)
    secondSet.sort(sortPos)

    for (let x = 0; x < firstSet.length; x++) {
      if (
        firstSet[x].position[0] !== secondSet[x].position[0] ||
        firstSet[x].position[1] !== secondSet[x].position[1]
      ) {
        return false
      }
    }
  }
  return true
}


[NOT AN ISSUE] how to disconnect from the device when the app is killed

To help us fix your issue, please provide the information in the below template. If something causes a crash, provide as much information as you can gather.
Just imagine: we do not know what you are doing!

Note: There is often little we can do without a minimal reproducible sample of the issue, so please provide that in a standalone git repository and link it here.

Hi,
There is a specific where the user kills the app and the connection sometimes linger with the device. On android i managed to close the connection on OnDestroy, on iOS i'm trying to use WillTerminate to do this, but the method DisconnectDeviceAsync does not return and the SO kill the app within 5 seconds. Is this the place to do this or is there a trick on iOS for it? Or does the library already handles this scenario?
Steps to reproduce

App connects to device

go to multi tasking and swipe to kill app

close the connection to the device

Expected behavior
N/A
Actual behavior
N/A
Crashlog
N/A
Configuration
Version of the Plugin: 2.1.3
Platform: iOS
Device: iPhone 8

There is a specific where the user kills the app and the connection sometimes linger with the device. On android i managed to close the connection on OnDestroy, on iOS i'm trying to use WillTerminate to do this, but the method DisconnectDeviceAsync does not return and the SO kill the app within 5 seconds. Is this the place to do this or is there a trick on iOS for it? Or does the library already handles this scenario?

I think in principle those are the right places for disconnecting. I'm not sure why it doesn't work on iOS. Does the disconnection work if you trigger it earlier in the app?
Btw, at some point I had the problem that I could never see OnDestroy being called on Android, but I forgot the details.

I think in principle those are the right places for disconnecting. I'm not sure why it doesn't work on iOS. Does the disconnection work if you trigger it earlier in the app?

Yeah, the disconnect works when triggered from a view model or view controlller, but it doesn't from the app delegate (this happens only on iOS)

Btw, at some point I had the problem that I could never see OnDestroy being called on Android, but I forgot the details.

OnDestroy may or may not be called, the best way (that i could find to have it working consistently) to ensure it is called is to have a Foreground service running.


WARNING: Import named "scipy" not found locally. Trying to resolve it at the PyPI server.

All the packages are installed locally. But there are warnings! The resolved packages' versions are not the same as my locally installed. Need help! Thank you!
INFO: Not scanning for jupyter notebooks.
WARNING: Import named "lief" not found locally. Trying to resolve it at the PyPI server.
WARNING: Import named "lief" was resolved to "lief:0.15.1" package (https://pypi.org/project/lief/).
Please, verify manually the final list of requirements.txt to avoid possible dependency confusions.
WARNING: Import named "lightgbm" not found locally. Trying to resolve it at the PyPI server.
WARNING: Import named "lightgbm" was resolved to "lightgbm:4.5.0" package (https://pypi.org/project/lightgbm/).
Please, verify manually the final list of requirements.txt to avoid possible dependency confusions.
WARNING: Import named "matplotlib" not found locally. Trying to resolve it at the PyPI server.
WARNING: Import named "matplotlib" was resolved to "matplotlib:3.9.2" package (https://pypi.org/project/matplotlib/).
Please, verify manually the final list of requirements.txt to avoid possible dependency confusions.
WARNING: Import named "numpy" not found locally. Trying to resolve it at the PyPI server.
WARNING: Import named "numpy" was resolved to "numpy:2.1.2" package (https://pypi.org/project/numpy/).
Please, verify manually the final list of requirements.txt to avoid possible dependency confusions.
WARNING: Import named "pandas" not found locally. Trying to resolve it at the PyPI server.
WARNING: Import named "pandas" was resolved to "pandas:2.2.3" package (https://pypi.org/project/pandas/).
Please, verify manually the final list of requirements.txt to avoid possible dependency confusions.
WARNING: Import named "scikit_learn" not found locally. Trying to resolve it at the PyPI server.
WARNING: Import named "scikit_learn" was resolved to "scikit-learn:1.5.2" package (https://pypi.org/project/scikit-learn/).
Please, verify manually the final list of requirements.txt to avoid possible dependency confusions.
WARNING: Import named "scipy" not found locally. Trying to resolve it at the PyPI server.
WARNING: Import named "scipy" was resolved to "scipy:1.14.1" package (https://pypi.org/project/scipy/).
Please, verify manually the final list of requirements.txt to avoid possible dependency confusions.
WARNING: Import named "seaborn" not found locally. Trying to resolve it at the PyPI server.
WARNING: Import named "seaborn" was resolved to "seaborn:0.13.2" package (https://pypi.org/project/seaborn/).
Please, verify manually the final list of requirements.txt to avoid possible dependency confusions.
WARNING: Import named "xgboost" not found locally. Trying to resolve it at the PyPI server.
WARNING: Import named "xgboost" was resolved to "xgboost:2.1.2" package (https://pypi.org/project/xgboost/).
Please, verify manually the final list of requirements.txt to avoid possible dependency confusions.
INFO: Successfully saved requirements file in .\requirements.txt

这应该是因为pipreqs使用了映射名来找环境内的版本信息, 可以试试看我基于pipreqs的map新发布的库showmereqs, 修复了这个问题, 看看能不能帮到你.
https://github.com/SunandRiver/showmereqs


Is there a way to access the folder meta recursively?

Consider, var options = { recursive : true}. Then vfs.readdir('/', options) should return array of objects with if an object is a folder, it should have a child object which has the meta of the files/folders inside it.

There is no way to do this, since even on moderate sized folders computing this will be too slow, and the resulting object will be too large.
How do you want to use this? in some cases data from filelist can help.

On click of a folder, fetching from the file system could end up as a bad UX. No?

On click of a folder, fetching from the array of objects could end up as a bad UX. No?

I am not sure what you mean. Currently in cloud9, when opening a folder, loading animation is displayed until the list of files is fetched, and it seems to work ok.

That makes sense. I just ended up doing the same.
Initially, I was thinking, loading on demand (even file/folder listing) would make the user to wait for a moment and thought of loading the folder meta recursively with a service worker. :-\


CMake option to enable/disable legacy units

NEURON is changing units values (CODATA 2018 constants), see : https://github.com/BlueBrain/mod2c/pull/47
As discussed in https://github.com/BlueBrain/mod2c/pull/47#issuecomment-711156915, we need to add -DCORENEURON_ENABLE_LEGACY_UNIT=ON option to CMake to enable/disable use of legacy units.
What needs to be done:

add CMake switch CORENEURON_ENABLE_LEGACY_UNIT
share/nrnunits.lib in MOD2C should become template file share/nrnunits.lib.in
Depending on value of CORENEURON_ENABLE_LEGACY_UNIT option and using CMake's configure_file functionality, share/nrnunits.lib.in should be converted to share/nrnunits.lib at build time with old or new values of different constants.

The same mechanism was used in earlier NEURON versions  (see usage of NRN_ENABLE_LEGACY_FR in cmake/ConfigFileSetting.cmake).
@iomaganaris  can provide additional context.

Why is this ticket in CoreNeuron and not in mod2c?
What about nmodl?

mod2c has its nrnunits.lib in https://github.com/BlueBrain/mod2c/blob/master/share/nrnunits.lib and NMODL in https://github.com/BlueBrain/nmodl/blob/master/share/nrnunits.lib. They should both be edited to be able to select the legacy or new units.

the coreneuron eion.c file also uses this option.

Should I copy the file from neuronsimulator/nrn? They differ about available values sometimes.

You need to copy nrn/share/lib/nrnunits.lib.in . That uses @LegacyY@ and @LegacyN@ that get configured into
# and <empty> or vice versa depending on CORENRN_ENABLE_LEGACY_UNITS to create the nrnunits.lib file.

Waiting for BlueBrain/nmodl#411 and BlueBrain/mod2c#52

It may help to see how I changed mod2c parse1.y, nmodlfunc.h and units.c with regard to nrnunit_dynamic_str (which should probably be called nrnunit_format_str). Modern units have full double precision, legacy were %g.


What should gKey contain?

Could you please mention what gKey in the environment file is for?

you can safely ignore it. it was just used for an old config.
https://github.com/hamedbaatour/minimus/commit/7b5c6f5a11fcfdaecc998f47ee9ce4b5fa1c6a04 removed it to avoid confusion.


Tabbing across widgets not working for newly added components

Add a Date.new component using the CB
Click into the year widget
Enter 2024
Press tab

Expected behaviour:
Focus moves to the year widget
Actual behaviour:
Component is deselected
Interestingly if I click back into the same year widget on my already created component and change the year to 2023 and press tab it now works as expected.

From my observation, this happens because once the year is entered, a placeholder widget is replaced with a non-placeholder version, so in effect it appears to stop being the currently active element.


importModuleSpecifierEnding: 'js' not honored when path aliases are used

Bug Report

🔎 Search Terms

importModuleSpecifierEnding
paths
js es modules

🕗 Version & Regression Information
reproduced with TypeScript 4.4.4 as well as 4.6.0-dev.20211108 (i.e. npm install typescript@next at the time of writing).

~This is a crash~
~This changed between versions ______ and _______~
This is the behavior in every version I tried, and I reviewed the FAQ for entries about __ Modules __
~I was unable to test this on prior versions because _______~

⏯ Playground Link

I could not figure out how to configure the Bug Workbench to contain multiple files, so I created an example git repository instead:
https://github.com/orzechowskid/ts-example-repo
💻 Code

// ./tsconfig.json

{
  "compilerOptions": {
    "allowJs": true,
    "baseUrl": ".",
    "checkJs": true,
    "paths": {
      "~/*": [ "./src/*" ]
    },
    "strict": true
  },
  "include": [
    "./src/**/*"
  ]
}

// ./src/utils/foo/bar/baz.js

export const baz = (a, b) => a + b;

// ./src/components/foo/Bar.js

import * from '~/utils/foo/bar/b
                                ^- wait for auto-suggest

🙁 Actual behavior

baz suggested as autocomplete text
🙂 Expected behavior

baz.js suggested as autocomplete text, since it's referring to a module import and I've set importModuleSpecifierEnding: 'js' in my preferences.  (FWIW the file extension is appended if I write a relative path, e.g. 'import * from '../../utils/foo/bar/baz.js).

I think ModuleSpecifierEnding should always default to JsExtension.
it never hurts to be more explicit even in commonjs.
Having a explicit path helps migrating code to esm later even if you are using commonjs. commonjs don't mind that you use extensions. in its early days extension was also required before extensionless become a feature that is now seen as a anti patern today.
https://github.com/microsoft/TypeScript/blob/d53630fac3adb88eca068a32fd1f65fbbe16507b/src/compiler/moduleSpecifiers.ts#L23-L31
You should rather have to opt out of it instead, that should be the "correct" way
My suggestion:
function getEnding(): Ending {
    switch (importModuleSpecifierEnding) {
        case "minimal": return Ending.Minimal;
        case "index": return Ending.Index;
        default: return Ending.JsExtension;
    }
}

Were you ever able to get resolution on this?  I'm having the same issue... stuck between ridiculous relative paths or autocompletes that suggest filenames which don't compile properly.


Issue-initial-app

Automated Review Comments
Issues in main.py:

(6, 'Line exceeds 80 characters')
(18, 'Line exceeds 80 characters')
(21, 'Line exceeds 80 characters')
(34, 'Line exceeds 80 characters')
(34, 'Hardcoded string found')
(35, 'Line exceeds 80 characters')
(48, 'Line exceeds 80 characters')
(48, 'Hardcoded string found')
(57, 'Line exceeds 80 characters')
(59, 'Hardcoded string found')
(63, 'Hardcoded string found')
(64, 'Hardcoded string found')
(65, 'Hardcoded string found')
(66, 'Hardcoded string found')
(67, 'Line exceeds 80 characters')
(69, 'Hardcoded string found')
(71, 'Hardcoded string found')
(72, 'Line exceeds 80 characters')
(78, 'Hardcoded string found')
(81, 'Line exceeds 80 characters')
(84, 'Line exceeds 80 characters')
(86, 'Hardcoded string found')
Issues in modules/ai_models.py:
(17, 'Line exceeds 80 characters')
(27, 'Line exceeds 80 characters')
(39, 'Line exceeds 80 characters')
(41, 'Line exceeds 80 characters')
(42, 'Line exceeds 80 characters')
Issues in modules/database.py:
(22, 'Line exceeds 80 characters')
(25, 'Line exceeds 80 characters')
(27, 'Line exceeds 80 characters')
(32, 'Line exceeds 80 characters')
Issues in modules/resume.py:
(19, 'Hardcoded string found')
(26, 'Line exceeds 80 characters')
Issues in modules/tempfile_util.py:
(9, 'Line exceeds 80 characters')

I got it.


Add example for scipy stats.trim1 under docstring

DOC
Add example for scipy.stats.trim1 under function docstring.
Short description:
Add section "Example" and demo run of following code:
Initialize a as np.arange(20)
Apply trim1 on a, 50%, to the left
Assign result to b
Print b
Examples
    --------
    >>> from scipy import stats
    >>> a = np.arange(20)
    >>> b = stats.trim1(a, 0.5, 'left')
    >>> b
    array([10, 11, 12, 13, 14, 16, 15, 17, 18, 19])

Reference issue
 Contributes to Issue #7168
What does this implement/fix?
 Completed example section under docstring
Additional information

Test failures are unrelated, and looks good to me, so I'll go ahead and merge this!
A suggestion for another example would be one in which len(a) * proportiontocut is not an integer (e.g. a = [0, 1, 2] and proportiontocut=0.5) with some commentary about the direction of rounding. Examples of how to use the axis` argument would be great, too. But this is a big improvement as-is!
Thanks @lgfunderburk @WarrenWeckesser!


[Code health] Photos uploaded again on config change

lastPhotoResult in EditObservationViewModel replays the last value on subscribe, which will cause the PhotoFieldViewModel to upload the photo again. @shobhitagarwal1612 FYI.

@shobhitagarwal1612 Do you know if this was ever fixed?

@shobhitagarwal1612 Gentle ping

While testing this, I found that localMutationSyncWorker isn't getting invoked for syncing the data with firestore.

I attempted to test the photo upload flow end-to-end and it is broken at the moment. The worker isn't able to upload the file as it can't find the locally saved file.

Marking this as resolved. The photo is uploaded at the end of the submission, so config change doesn't re-upload the image. Will fix the bug regarding failure to upload separately


Any plans to make it compatible with Jupyter v4?

Hi there! I really like this theme and would love to see it available also for jupyter v4 if possible :)

Hi @ccruizm, thanks for your interest in this theme! I have switched to Jupyter Notebooks in VS Code and haven't been using Jupypterlab for a while which is also why this theme hasn't been updated. Please feel free to fork this project or submit a PR if you would like to upgrade it to v4, I'll review your PR.


Clean up resolver

Started out as a PR to add linear IR, but I realized that generation IR while type checking, constant folding, and doing name resolution is not smart. Will just merge clean up to the resolver.


Where is the GT in Virtual Object Relighting (VOR) dataset for Qualitative Evaluation？

Hi!
I notice that you may use Virtual Object Relighting (VOR) dataset to evaluation qualitatively because i found you ask some question about this in the issue of EMLight, and there are some crops in the './StyleLight/assets/wild2/' folders.
I am trying to make Qualitative Evaluation, too. But i could not found the ground truth panaroma picture in their Virtual Object Relighting (VOR) dataset. So i want to ask you that have you found GT panaroma in VOR dataset? If you GT panaroma were not included in VOR, can you share this GT panaromas with me?
Thanks for sharing you excelent work！

Hi!
I notice that you may use Virtual Object Relighting (VOR) dataset to evaluation qualitatively because i found you ask some question about this in the issue of EMLight, and there are some crops in the './StyleLight/assets/wild2/' folders.
I am trying to make Qualitative Evaluation, too. But i could not found the ground truth panaroma picture in their Virtual Object Relighting (VOR) dataset. So i want to ask you that have you found GT panaroma in VOR dataset? If you GT panaroma were not included in VOR, can you share this GT panaromas with me?
Thanks for sharing you excelent work！

Hi @jxl0131, Thanks for your attention for our work.
Thare are no GT panorama in VOR dataset Virtual Object Relighting (VOR) dataset , as described in their Google Drive. You may double-check these folders.
Since this dataset focuses on Virtual Object Relighting, you can insert some objects into it using estimated environmental maps and conduct user study to compare other methods. I hope this may help you.

Thank you for the question. I closed this issue since there is no further question. You might re-open it or open a new issue if any.


QUESTION: the response body is completed?

just like this
var request = require('request');
request('http://www.google.com', function (error, response, body) {
  if (!error && response.statusCode == 200) {
    console.log(body) // Show the HTML for the Google homepage.
  }
})

the body in callback function is complete?
I got some unbelievable questions, when I print body to console, I found it is completed, but when I search in body via regexp object, I can't get what I expected, but sometimes, it can be found in body, so the body is not completed right?

UPDATE
It's my fault, I use global regexp object to search response body, and I haven't reset lastIndex, so the second search will start at last searched index!


Revert "Make logHandler print to stdout instead of stderr"

This reverts commit 6fbddd486707f683735e24d92183624b1120aa1e.
I’ve found the underlying issue of the issue the above commit worked around and am fixing it in https://github.com/swiftlang/swift-package-manager/pull/8047.

@swift-ci Please test


Improve installation supports with external builds

Context: The CMake build system, and associated targets, do not fully conform to a CMake installation step. As such, to allow better reproducibility across builds, and integration with platforms such as spack, we need to make some adjustments to best support this.
Description of the Change: Change benchmark and test target names, macro variable usage and header visibility. Running cmake --install ./build following a compilation step will now install the headers and compiled binaries into a predefined target location with bin include and lib directories.
Benefits: Enables better support for installation of lightning targets, headers, and spack integration.
Possible Drawbacks:
Related GitHub Issues:

Hi @mlxd, looks good to me. I'm wondering, why did the benchmarks and tests got renamed with the pennylane_lightning_ prefix?

Hi @mlxd, looks good to me. I'm wondering, why did the benchmarks and tests got renamed with the pennylane_lightning_ prefix?

Thanks @vincentmr. With this update, we have the option to install the built binaries into a given prefix path from CMake, and for our updates to support spack. If we installed our test runner (previously named runner) into a /usr/local/bin directory, it would be very ambiguous what it is doing (the same with the benchmarking binary). The naming update was to avoid conflicting with any other packages that have similiarly named binaries, by prepending our package name to the binary names.

Hey @mlxd, black just released its new version. Before merging, please update black locally and run:
black -l 100 ./pennylane_lightning/ ./tests

black -l 100 ./pennylane_lightning/ ./tests

Done. Will merge after the CI passes

black -l 100 ./pennylane_lightning/ ./tests

Done. Will merge after the CI passes

black -l 100 ./pennylane_lightning/ ./tests

Done. Will merge after the CI passes


Update konflux pipeline to have bundled tasks

Konflux uses bundled resolver, so we need to include the tasks with the bundle

/hold

/cc @creydr

/unhold

@creydr I pushed a temporary fix


Support for authorization via oauth2

Checklist

[X] I have used the search function to see if someone else has already submitted the same feature request.
[X] I will describe the problem with as much detail as possible.
[X] This issue only contains a request for one single feature, not multiple (related) features.

App version
5.807
Problem you are trying to solve
Hello. The topic about authorization via the oauth2 token was raised at the forum. When will it be implemented?
Suggested solution
If you add it, then simplify the authorization procedure.
Screenshots / Drawings / Technical details
No response

Duplicate of #655


Can the model size be cut？

We need to integrate lyra in sdk，but the model size occupies about 3M, It's too big

Hi @liuxunfei currently we only support one model size. Do you have a target model size?


≤ or ≥ in markdown is rendered as # in pdf

Expected Behavior
Using ≤ or ≥ in markdown documents should work
Actual Behavior
The characters are rendered as #
Steps to Reproduce
Create the following two files
_map.ditamap_
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE map PUBLIC "-//OASIS//DTD DITA Map//EN" "map.dtd">
<map>
  <title>Testdoc</title>
  <topicref href="topic.md" format="markdown"/>
</map>

topic.md
# Topic

a ≥ b

a ≤ b

run:
dita -f pdf -i map.ditamap  -o .
and examine map.pdf
Environment

DITA-OT version:
DITA-OT version 3.7.3 downloaded from the homepage

Operating system and version:
Rocky Linux 8

How did you run DITA-OT?
using the dita command above

Transformation type:
PDF

How about if in the DITA map you refer to a DITA topic instead? Because I do not think this is a problem related in particular to markdown files referenced in a DITA Map, I assume the problem is that the PDF contains certain fonts which do not know how to handle that specific character.
https://www.oxygenxml.com/doc/versions/24.1/ug-editor/topics/DITA-map-set-font-Apache-FOP.html

Thank you for hints, new to this so nomenclature is hard :-)
But I changed the title tag to contain ≤ and it rendered as a # It seems your assumption is correct.
Can I understand this as that my DITA-OT installation interacts with the fonts installed in my Linux and renders errors?
How should I proceed to be able to use the character? Render under Windows? Change the pdf-font we use (something that we want to do anyway)?

The DITA OT uses by default the open source Apache FOP processor to build the PDF. You can also configure it to use a commercial engine like Antenna House which may have better font support.
But coming back to the default publishing, if you run the DITA OT with the "-v" flag at some point at the end of the transformation it should show warnings issued by the FOP processor, for example complaining that it cannot render that character with a specific font and that it will substitute the character with "#". Maybe these warnings will help you debug the problem further.
The Apache FOP processor by default when used from the DITA Open Toolkit will try to auto-detect and load all fonts specified in the operating system, for example on Windows it loads the "c:\Windows\Fonts". I have no idea on Linux from where it attempts to load the fonts, it does not seem to explicitly state this in its documentation.
From what I tried on Windows with a stock DITA OT 3.7.3 with no changes made to it, the PDF output properly rendered that specific "≤" character.

Also I think this issue should be closed as it is not a bug in the publishing engine.

I confirmed that with a DITA topic:
<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="urn:oasis:names:tc:dita:rng:topic.rng" schematypens="http://relaxng.org/ns/structure/1.0"?>
<topic id="topic">
    <title>My Topic</title>

(a ≥ b), (a ≤ b)

(a ≥ b), (a ≤ b)

</topic>

published using DITA-OT 3.7.3, the characters publish correctly in Windows but incorrectly in Linux (Ubuntu 20.04).
This seems suspicious to me because generally Linux has good support for Unicode characters.


Obtain 'root' previleges on my ssh.username

I am using vagrant-google provider to create a new Google Cloud Compute instance. It is working well. However I wanted my vagrant user account to obtain 'root' permissions because the puppet files I got using have loads of commands in them that can run only with root permissions.
Here is my Vagrantfile code
# -*- mode: ruby -*-
# vi: set ft=ruby :

VAGRANTFILE_API_VERSION = "2"

Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
  config.vm.box = "centos-7-v20160301"

  config.vm.provider :google do |google, override|
    google.google_project_id = "foo"
    google.google_client_email =<EMAIL_ADDRESS>    google.google_json_key_location = "Google_Cloud_API_Key.json"

    override.ssh.username = "myuser"
    override.ssh.private_key_path = "~/.ssh/google_compute_engine"
  end

  config.vm.provision :puppet do |puppet|
    puppet.manifests_path = "puppet/manifests"
    puppet.module_path    = "puppet/modules"
    puppet.manifest_file  = "init.pp"
  end

end

Note the 'myuser' line above. How do I make 'myuser' to obtain root permissions? It would also be fine if vagrant can log into directly into 'root' user - but I dont know how. I tried typing 'root' directly but that obviously didn't worked (maybe) because the Google_Cloud_API_Key.json I downloaded from Google Cloud console was for 'myuser'

I don't have a definitive answer for you, but I suspect you'll need to use the shell provisioner to tweak a few things so that your myuser can use puppet w/o 'root'.  This will likely entail changing file permissions on puppet files / executables, maybe sudoers changes, or something like Puppet without root.
Alternatively, you could setup an ssh keypair for root (assuming the guest allows root ssh login).  Take a look at the GCE instructions for ssh key management and create a keypair for root.

override.ssh.pty = true


JOSS review: Tortuosity factor should always be greater than 1?

In of of the unit tests, tortuosity factor is less than 1. I was under the impression that tortuosity should always be greater than 1. Could you please explain?
https://github.com/tldr-group/taufactor/blob/abd2877ba205badcb24a68b89e76927d8e4e5a14/tests/test_taufactor.py#L318-L328

taue, electrode tortuosity, is not always greater than 1, please see https://www.nature.com/articles/s41524-020-00386-4. Thanks!


Scraper for Elektrotehniški vestnik

Here is the scrapper for data from the elektrotehniški vestnik.
Data are already uploaded to http://file.biolab.si/text-semantics/data/elektrotehniski-vestnik-clanki/
If anything is wrong I will replace the data.

Please add tika to the requirements. Otherwise it is good.

Please add tika to the requirements. Otherwise it is good.

Done. :)

Done. :)


getTfootTdProps does not include rowInfo or column

I am using react-table 6.7.12.   When I use getTfootTdProps, it is not providing the rowInfo or column props.  This is making it impossible for me to style the cell.   I believe the root of the issue is line 731 in index.js:
      const tFootTdProps = _.splitProps(getTfootTdProps(finalState, undefined, undefined, this))

Should the second param be the rowInfo and the 3rd the column?

This feature/issue has been tagged as one that will likely be fixed or improved in the next major release of React-Table. This release is expected to be completed in the next 6 - 8 months. Please see #1143 for more detail. If you believe this feature can be easily fixed, we invite you to fork the project, attempt the fix, and use it until the latest version is available. If the fix is simple enough, we will also consider it as a PR to the current version.


Search bar  FUNCTIONALITY REQUIREMENTS

The search bar will have drop down functionality with checkboxes...  We need to set hard requirements on this .

Not necessary,  but would be a nice addition.


useStore should be finalised or retired

There is a pattern at https://github.com/cefn/lauf/blob/207850f1d04f97c1b2e0550caed5fb02045588a9/modules/lauf-store-react/src/index.ts#L5-L18 which suggests a mature useStore behaviour. However, that is a feature which was drafted but never really used.
Currently it would force a component to re-render on EVERY change, which is rarely a good idea and demands smart memoization from the user. This behaviour should be made explicit (e.g. with a change to useStoreState()) but this is probably not worthwhile as const state = useSelected(store, state => state) is a simple and explicit alternative
The expected and useful role that this hook might have - hiding the details of the correct signature for BasicStore useState is not fulfilled because it has this promiscuous refresh behaviour. So probably useStore should just return the store as a reliable state maintained within the component and have no refresh behaviour.

The useStore behaviour is now purely a canonical way of initialising a store, and the former behaviour to trigger parent component refresh on state change is retired, making the hook usable in the ancestor of a lazy-updating component tree.


refactor MrkvNow into model state variable in ConsAggShockModel

In ConsAggShockModel, the model variable MrkvNow is currently stored as an object attribute.
Is it a state? A shock?
Either way, it should be changed into a namespaced variable for consistency with the new style.

Ah. So one reason this has not been refactored before is that it looks like the MrkvNow property in ConsAggShockModel is an aggregate level variable.
See the discussion here:
https://github.com/econ-ark/HARK/issues/761#issuecomment-692314436
It also looks like this is handled slightly differentling in the ConsMarkovAggShockModel and the KrusselSmithModel

Ah. So one reason this has not been refactored before is that it looks like the MrkvNow property in ConsAggShockModel is an aggregate level variable.
See the discussion here:
https://github.com/econ-ark/HARK/issues/761#issuecomment-692314436
It also looks like this is handled slightly differentling in the ConsMarkovAggShockModel and the KrusselSmithModel


Fixed #25840 -- Added a 'default' argument to self.get signature on BaseCache.get_or_set()

Refactored Django's built-in BaseCache.get_or_set() to
work well with DummyCache.
get_or_set implementation tries to fetch the key first.
If it doesn't exists, it adds the default value
(passed as 'default' parameter) to the cache and gets it.
Since DummyCache backend doesn't actually add something
but returns True on add operation, get_or_cache() thinks
that it's successfully added to the cache and do a GET
operation to the related key which returns None. This way
instead of returning default, returns None.
This also fixes possible data eviction problems
between setting and getting a key. Another thread possibly
remove the key before get_and_set access it again.
Also added the get_or_set related unit tests for DummyCache backend.

updated the commit with the related unit tests.

@timgraham any updates?

buildbot, add to whitelist.

Looks good. Since BaseCache.get_or_set() is new in 1.9, this qualifies for a backport. Could you add a note to docs/releases/1.9.1.txt?

@timgraham,
squashed the commit w/ a bugfix note on docs/releases/1.9.1.txt. is it okey?

merged in 8e838d9c869083597dc9e161ae2fe37acaa90de9, thanks!


fixed issues with libraries navigation, refactors (#1213)

There's a good amount of refactoring in this, so this is going to look like a much bigger change than it is. In reality it makes the dispatch code simpler.
Fixes:

Resolved the issue with the libraries pages not redirecting correctly
Resolved an issue around categories not being preserved moving from page to page.

The issue with the redirects was there was a tug of war on arriving on /library between the various ways of determining where the user should end up.
I added a /libraries/grid/ url and now /libraries/ determines which list page the user should end up on based on 1) url 2) cookie, 3) the default, same for version preference.  We can probably get rid of dispatch() later. This has the added bonus of allowing reliable linking to a specific list view (e.g. for users to bookmark one type)
Refactors:

Separated the navigation on the three library pages into a standalone template.
Moved some constants to constants.py
Moved a lot of the views methods which were only used by the dispatch() call to utils.py .
At that stage there were circular imports so I moved the docs generation functions which were only used in constants.py to constants_utils.py. utils.py is more general.

If the methods like get_prioritized_library_view are only going to be used in the LibraryList View then it makes sense to me to keep them there as methods on the view.  But I don't feel too strongly about it. Maybe they will be used elsewhere?

If the methods like get_prioritized_library_view are only going to be used in the LibraryList View then it makes sense to me to keep them there as methods on the view. But I don't feel too strongly about it. Maybe they will be used elsewhere?

Thanks Brian. Yeah, I was thinking they're likely not to be used in classes that extend LibraryList but may be more likely to get used if they're available as util methods, if ever needed.

While working on #1084 I found a bug with it not deleting the cookie when it should. Switching to draft to block merge.

Changes made


How to reproduce the complete Uni-Fold model at full scale?

The training configuration file unifold/train/train_config.py allows to specify the features and labels directories for training and evaluation:
"data": {
  "train": {
    "features_dir": "where/training/protein/features/are/stored/",
    "mmcif_dir": "where/training/mmcif/files/are/stored/",
    "sample_weights": "which/specifies/proteins/for/training.json"
  },
  "eval": {
    "features_dir": "where/validation/protein/features/are/stored/",
    "mmcif_dir": "where/validation/mmcif/files/are/stored/",
    "sample_weights": "which/specifies/proteins/for/training.json"
  }
}

Q1:
For training, what are the complete PDB IDs used to reproduce the exact AlphaFold2 model or the Uni-Fold model at full scale?
The example_data directory provides only one PDB ID (i.e. 1ak0) for demonstration purpose: features/1ak0_1_A/features.pkl and mmcif/1ak0.cif. I'm aware that the complete list of CIF files for labels can be obtained from data_dir/pdb_mmcif/mmcif_files, which contains 181295 CIF files. But how to obtain the same complete list of fasta files for generating features (e.g. those fasta/1ak0_1_A.fasta files)?
Q2:
For evaluation, what are the PDB IDs that are used for evaluation? I know they are from CASP14 but can you give the exact list in the repository?
Q3:
Is it necessary to remove the PDB IDs for evaluation from training? So that the two datasets do not intersect.

Q1:

We use the same data selection process as that was claimed in the supplemetary materials of AlphaFold2. Specifically, we used all PDB entries before 2020-4-30 to train Uni-Fold.
We do not provide entries to extract FASTA files from CIF files, yet it can be easily implemented by the function cif_to_fasta() at https://github.com/dptech-corp/Uni-Fold/blob/8cc7bcedc23efd53a2f0b11de6657c61ac9204f5/unifold/train/utils.py#:~:text=def-,cif_to_fasta,-(mmcif_object%3A%20MmcifObject%2C .

Q2:
We used all CASP14 entries that was available to us (68 sequences) to evaluate Uni-Fold. The details of Uni-Fold evaluation will be publicated soon.
Q3:
Sure. Using PDB data before 2020-4-30 is specifically proposed for this concern.


feat: add schema map in protoload

Context
This pr allow loading from protobuf with a field mapping.
what this pr do
from docarray import BaseDocument
from docarray.typing import AnyUrl, TorchTensor

import torch

class A(BaseDocument):
    url: AnyUrl
    tensor: TorchTensor

class B(BaseDocument):
    link: AnyUrl
    array: TorchTensor

a = A(url='hello', tensor=torch.zeros(3))

b = B.from_protobuf_with_schema_map(
    a.to_protobuf(), field_map={'url': 'link', 'tensor': 'array'}
)

assert b.link == a.url
assert (b.array == a.tensor).all()

Is there a fundamental reason this only works from protobuf? I imagine it would be equally as useful to be able to do this from dict/json, or just from another non-serialized Document.

Is there a fundamental reason this only works from protobuf? I imagine it would be equally as useful to be able to do this from dict/json, or just from another non-serialized Document.

Good question. I hesitated to do it at the dict level. The things is it is more efficient to do it at each serialization level (you can drop data that you don't want to load). Though I have to say I am not sure it is a common practice to do this in the json/rest wold :thinking:
I would say we can merge this one and see for the other serialization later.

Though I have to say I am not sure it is a common practice to do this in the json/rest wold thinking

Maybe not, but I think we should not favour the protobuf/grpc world over the json/http world if we don't have to. We aspire to be a library for sending multi-modal data, so I would say features that help in that should not be restricted to one tech stack.

Then I will do the same for JSON in this pr @JohannesMessner

on hold for now


Twitter Link

Wondering if it is possible to change the Twitter to an icon, just like Facebook and YouTube.

The Twitter feed is a sidebar item, like newsroom and learning center.  Facebook and YouTube are just icons because they don't have sidebar items; they're just links.

Thanks for the explanation. Is there a way to change the name 'Twitter' should we need to / want to? I'm wondering if there is better name for it since the Twitter icon is already there.
Peter
Peter Fiala
Technology & Events Coordinator
Wisconsin Coalition Against Sexual Assault (WCASA)
2801 W. Beltline Hwy., Ste 202, Madison, WI 53713
Telephone:<PHONE_NUMBER>; Direct:<PHONE_NUMBER>
Fax:<PHONE_NUMBER>
Website: www.wcasa.orghttp://www.wcasa.org/
[link to wcasa's Facebook page]http://www.facebook.com/wcasa [link to wcasa's Twitter feed] http://twitter.com/wcasa_vpcc  [https://encrypted-tbn1.gstatic.com/images?q=tbn:ANd9GcS8fWOIOHiKkDuBEon9eoc4_Rkp-EW-KLKXvst0VMmewXeOO9ZF] http://www.youtube.com/user/wcasavpcc

From: Micah Henning<EMAIL_ADDRESS>Sent: Saturday, October 29, 2016 12:50:14 PM
To: enove/Thriver
Cc: Peter Fiala; Author
Subject: Re: [enove/Thriver] Twitter Link (#151)
The Twitter feed is a sidebar item, like newsroom and learning center. Facebook and YouTube are just icons because they don't have sidebar items; they're just links.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/enove/Thriver/issues/151#issuecomment-257105672, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVMppf53kotziRyfG-JqmQA9TzhdLRBxks5q44dWgaJpZM4Kj3cO.


Bot is not counting reactji

when calling triagebot, the bot responds with a message, but always returns 0 for requests pending and requests being looked at.  Have confirmed the token and scopes in the setup.

I experienced exactly the same symptom with a wrong token that had no permission to channels.history. Please try my PR (#11).


ENH: Bump Dockerfile

This PR bumps up the Docker image base to Ubuntu Focal LTS (20.04).
As a result, a number of packages were updated, including:

AFNI
FSL
Connectome Workbench
Graphviz
Pandoc

Furthermore, Python was bumped to 3.8.x, and many of its packages were "modernized" accordingly.
This builds the foundation for #2392 , as it depends on updated scipy. Also closes #2382

Should we just use neurodocker for FSL?

Good point, whatever we can do to get up to 20.04

Unclear what's up with the validator... Should we roll back for now?

perhaps, but an assertion within the wrapper is also failing

log
Python version: Python 2.7.18
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
Collecting pip<21
  Downloading https://files.pythonhosted.org/packages/27/79/8a850fe3496446ff0d584327ae44e7500daf6764ca1a382d2d02789accf7/pip-20.3.4-py2.py3-none-any.whl (1.5MB)
     |████████████████████████████████| 1.5MB 6.9MB/s eta 0:00:01
Collecting setuptools<45
  Downloading https://files.pythonhosted.org/packages/e1/b7/182161210a13158cd3ccc41ee19aadef54496b74f2817cc147006ec932b4/setuptools-44.1.1-py2.py3-none-any.whl (583kB)
     |████████████████████████████████| 583kB 39.4MB/s eta 0:00:01
Installing collected packages: pip, setuptools
  Found existing installation: pip 19.2.3
    Uninstalling pip-19.2.3:
      Successfully uninstalled pip-19.2.3
  Found existing installation: setuptools 41.2.0
    Uninstalling setuptools-41.2.0:
      Successfully uninstalled setuptools-41.2.0
Successfully installed pip-20.3.4 setuptools-44.1.1
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.
Processing ./wrapper
Requirement already satisfied, skipping upgrade: setuptools<45 in /opt/circleci/.pyenv/versions/2.7.18/lib/python2.7/site-packages (from fmriprep-docker==20.2.1+37.g485abc06) (44.1.1)
Using legacy 'setup.py install' for fmriprep-docker, since package 'wheel' is not installed.
Installing collected packages: fmriprep-docker
    Running setup.py install for fmriprep-docker ... - done
Successfully installed fmriprep-docker-20.2.1+37.g485abc06
/opt/circleci/.pyenv/shims/fmriprep-docker
Traceback (most recent call last):
  File "/opt/circleci/.pyenv/versions/2.7.18/bin/fmriprep-docker", line 11, in <module>
    load_entry_point('fmriprep-docker==20.2.1+37.g485abc06', 'console_scripts', 'fmriprep-docker')()
  File "/opt/circleci/.pyenv/versions/2.7.18/lib/python2.7/site-packages/fmriprep_docker.py", line 509, in main
    print(merge_help(parser.format_help(), targethelp))
  File "/opt/circleci/.pyenv/versions/2.7.18/lib/python2.7/site-packages/fmriprep_docker.py", line 163, in merge_help
    assert w_posargs.replace(']', '').replace('[', '') == t_posargs
AssertionError

Yeah, I saw that. I can try to look at it at some point before a release...

I think the problem was the help formatting changed between python versions.
Haven't looked into the bids-validator error yet, pinging @rwblair in case he's already come across this.

log
BIDSValidator https://github.com/nipreps/fmriprep/blob/674124ee80b3e2a8affddf005e910e4ca1c97cc0/fmriprep/utils/bids.py#L73

Unhandled rejection (
  reason: TypeError: Cannot read property 'split' of undefined
    at Minimatch.match (/usr/lib/node_modules/bids-validator/node_modules/minimatch/minimatch.js:717:9)
    at minimatch (/usr/lib/node_modules/bids-validator/node_modules/minimatch/minimatch.js:107:42)
    at Object.ignoredFile (/usr/lib/node_modules/bids-validator/utils/config.js:11:13)
    at Function.format (/usr/lib/node_modules/bids-validator/utils/issues/index.js:65:16)
    at Function.exceptionHandler (/usr/lib/node_modules/bids-validator/utils/issues/index.js:191:25)
    at /usr/lib/node_modules/bids-validator/validators/bids/fullTest.js:217:35
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
).

Restarted build to pull in validator 1.7.2, released on Friday.

I have to investigate a bit futher to see why ds210 is not producing the HTML citation.
I'm a bit worried of the segfault ds054 seems to consistently hit...

ds054
...
210514-23:40:24,248 nipype.workflow IMPORTANT:
	 fMRIPrep finished successfully!
210514-23:40:24,258 nipype.workflow IMPORTANT:
	 Works derived from this fMRIPrep execution should include the boilerplate text found in <OUTPUT_PATH>/fmriprep/logs/CITATION.md.
Fatal Python error: Segmentation fault

Thread 0x00007f9f0be67700 (most recent call first):
  File "/usr/local/miniconda/lib/python3.8/threading.py", line 302 in wait
  File "/usr/local/miniconda/lib/python3.8/site-packages/sentry_sdk/_queue.py", line 180 in get
  File "/usr/local/miniconda/lib/python3.8/site-packages/sentry_sdk/worker.py", line 126 in _target
  File "/usr/local/miniconda/lib/python3.8/threading.py", line 870 in run
  File "/usr/local/miniconda/lib/python3.8/site-packages/sentry_sdk/integrations/threading.py", line 67 in run
  File "/usr/local/miniconda/lib/python3.8/threading.py", line 932 in _bootstrap_inner
  File "/usr/local/miniconda/lib/python3.8/threading.py", line 890 in _bootstrap

Current thread 0x00007f9f31cd4740 (most recent call first):
<no Python frame>
fMRIPrep: Please report errors to https://github.com/nipreps/fmriprep/issues

The ds005 failure may be related to a schema mismatch. I can't upload an updated tarball to OSF because apparently we've hit a file limit. Just to have something quick, I opened #2415. If that fixes ds005, feel free to cherry-pick.

Nope, doesn't seem to be a problem with the dataset being invalid...

Couple notes from playing around in circle, doing a fresh npm install of the validator allows ds005 legacy multiproc it to valdiate, as does removing --no-network from the call. Have not figured out why those two things would fix it, or why anat-only works with no-network.

doing a fresh npm install of the validator allows ds005 legacy multiproc it to valdiate, as does removing --no-network from the call

Interesting... if the validator itself does not require an internet connection to run, I wonder whether one of its dependencies does since the last version we've been using (1.5.4)

Have not figured out why those two things would fix it, or why anat-only works with no-network.

The test is being skipped, I bet it would also fail if we weren't fast tracking the anatomicals.

@mgxd FWIW: https://github.com/getsentry/sentry-python/issues/1131

Upping the circle machine images (and thus the docker version within them) seemed to fix the ds054 segfault - although I'm not sure why 🤷 .
However, I think the game of dependency whack a mole is complete.

JFC. Thank you for finally fixing this. crossing fingers that ds054 doesn't segfault again


Update porting-ndis-miniport-drivers-to-netadaptercx.md

Add a note mentioning iSCSI boot is not supported in Netadaptercx

Thanks @amrutha-chandramohan! (I just changed the alert to a text note to align with our style guide. Readers tend to miss notes when they are in alert blocks.)