Unable to remove tags from private apps

Hi @ns-sbrown!
Thank you for pointing about that tags are available in terraform. We have now added them to our private apps; however, we have noticed that when we remove the tags in terraform, the state file gets updated, but the tags aren't actually removed from the private apps.
Here is what we are experiencing:
Plan showing that tags will be deleted:

Apply runs successfully:

However, tags still exist:

And running the plan again shows no changes:

Cheers,
Dexter

@ns-sbrown hey, we are seeing a issue with the tags. when we run terraform some apps are getting tags and some are not. Not sure but terraform is not picking up any changes and our deployment is getting a lot of inconsistencies

Looking into this as well

Any update on this?

@ns-sbrown Good day, Any progress on this issue?

I published v0.2.6 of the provider this morning which resolves this issue.


Add Movielens dataset to xDeepFM

After @Leavingseason finishes the PR of xDeepFM, we should do a notebook that showcase xDeepFM with Movielens. Maybe @yexing99 could help on this?

Finished coding. it is under branch ye /reco_utils/recommender/xdeepfm_movielens.

Has the Movielens xDeepFM code been moved somewhere else?

Closing old issue, feel free to reopen if needed.


Add our own definition of the PORT environment variable.

In case the base image removes it. We will define it ourselves to 8080, the value required by App Engine flexible environment.

Fixed by #76


Misplaced globalStorageHome

A globalStorageHome directory is created in the project root when I use the VSCodeVim extension.
> tree globalStorageHome/
globalStorageHome/
└── vscodevim.vim

The VSCodeVim extension uses context.globalStoragePath to determine storage location. Did code-server misconfigure this location to be in the project root?

Ah yeah I think I see the problem. vim runs in the browser and VS Code's worker extension host isn't capable of using the globalStorageHome value provided by the environment service yet, so we'll just have to patch that support in.

This bug still exists when I deploy Code-Server on Linux and access it on Windows

I spun up a 3.5.0 Docker image and when I use the vim extension and do something like :w it creates the global storage directory.
It doesn't seem to create it on startup though which is odd; I think it's supposed to do that so we might want to look into that.
Are there any specific errors you're running into?

If I access it on windows, the value of 'context.globalStoragePath' will be:
\home\admin\.local\share\code-server\globalStorage\vscodevim.vim
If I access it on linux, the value of 'context.globalStoragePath' will be:
/home/admin/.local/share/code-server/globalStorage/vscodevim.vim
The code-server always runs on linux, so when I access it with a windows browser, the path separator of 'context.globalStoragePath' is wrong

Ahh I see! I opened a new issue for this: https://github.com/cdr/code-server/issues/2093


freetype: include/freetype2 symlink

Issue description
The freetype2 include directory is a symbolic link to itself.
$ ls -ld $(nix-build --no-out-link '<nixpkgs>' -A freetype.dev)/include/freetype2
lrwxr-xr-x  1 acowley  wheel  1 Dec 31  1969 /nix/store/h2rsdjnskxvn1yljpmlgzab10vlkgp85-freetype-2.6.5-dev/include/freetype2 -> .

A program I am using (rospack) tries to crawl the directory, and ends up emitting warnings including the message, boost::filesystem::status: Too many levels of symbolic links.
The program works properly, but I am not sure if this is the intended arrangement of the freetype2 directory.

System: darwin
Nix version: nix-env (Nix) 1.11.4
Nixpkgs version: "17.03pre-git"

Yes, it was intended. There's a function for that glib.flattenInclude. It was just a hack to easily support packages that get the include levels incorrectly; there used to be several, I don't know why. Maybe there aren't any anymore...

flattenInclude is only used in freetype, pixman, and cairo, but I don't think I understand what the thinking is behind it as it seems really extreme to me. I'm wary of changing include paths, though, as just building those three packages probably isn't enough to gauge the impact on user code, and I don't want to break everyone's stuff.

It adds another possible include path-set, and the original one remains intact (only goes through one symlink). It was done to fix builds of other packages; I don't remember any breakage because of it.
It helped in packages that don't add -I paths correctly (e.g. as given by pkg-config invocation) and still include without the <freetype2/...> prefix. Our hooks only add -I${package}/include and not one level lower... Some our expressions just solve it by directly extending the CFLAGS explicitly, but that can be tedious.
Maybe it isn't much useful anyway, which would be seen by starting a Hydra jobset without flattenInclude to see how many builds break. (But currently my personal motivation to explore that isn't very high, given lack of knowledge of any real problem caused by it.)

Well, you now have one example of a problem caused by it 😜
I don't have the build capacity to see if downstream things break with the removal, so there's not much that can be done. Thanks for taking a look!

I could setup a Hydra jobset for you, if you're interested in looking into the failures etc. (with low priority so it shouldn't be a problem for others).


Footer > Copyright alignment

Description
On large screens, the copyright in the bottom is far from the footer content, so I aligned it in the center.
Before:

After:

Before submitting the PR, please make sure you do the following:

[x] Read the Contributing Guidelines
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
[x] Update docs in this repository according to your change
[x] Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

@mynameisadamf Tagging you here. My gut says this was supposed to be anchored to the left "wrapper" edge (e.g. aligned with the Discord logo on the left) at larger screen sizes.
Can you confirm?

@jplhomer The build looks correct, as it matches the design file. "© 2022 Snowdevil, is meant to vertically align with navigation elements.


Merge recent changes in master branch

Should merge recent changes in master branch.

#26 added .gitignore to project
#27 Lucene 5x support
#28 Added LUKE_PATH env variable to luke.sh

Cool, thanks!


ArcGIS Pro v 3.3.0 - breaks SLRM (and possibly some others?)

Hi there,
I'm a frequent user of RVT and have recently started using the Arc raster functions version, which is so useful! It's brilliant to be able to apply your visualisations to large mosaic Lidar datasets :-).
I've just updated Arc to version 3.3.0 and that sadly seems to have broken the SLRM visualisation. I've not tried all the other visualisations, but SVF and the multi direction hillshade seem to still work ok.
The release notes for v 3.3.0 say they've upgraded the version of Python used in Arc (https://pro.arcgis.com/en/pro-app/latest/get-started/release-notes.htm) I wonder if that might have caused the problem?
Best wishes
Richard

Thank you for raising up the issue. We'll look into it.

That's appreciated, many thanks :-)

Hi! Please download and test the latest version.

MSTP still has to be fixed


[PERF] Mark ProjectionOperator as a regular operator

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

...

New functionality

...

Test plan
How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

#3083  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Sicheng-Pan and the rest of your teammates on  Graphite


When expanding, the child elements pass through the groups below them

If the TreeView does not fill the full screen, then when you expand, you can see how the children go through the groups below them.

Any ideas how to fix this?

try remove the RecyclerView animator?

I set a DefaultItemAnimator for the TreeView. I think it's better than completely removing the animation.
TreeView treeView;
...
treeView.setItemAnimator(new DefaultItemAnimator());


Add manifold solo template

For easy install on unraid without messing with additional containers.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'm no unraid expert, but I don't think changing the main template will affect existing installations, right? In which case we should just change that over to use solo instead of adding a second variant? I imagine it's what most unraid users would want...

@Floppy Agreed, thanks for the feedback.


Better formatting for MSSQL when using National Characters

formatting queries with N'value here'.

Coverage remained the same at 100.0% when pulling b267da5af95ff101061f03f7791b86effbd9d281 on mtxr:master into 74d0459e2e32ad81c818763c1d7a9de37de523d6 on zeroturnaround:master.

So, this handles the N'string', though when you format a query like:
SELECT N'some string';

You'd expect a formatting like:
SELECT
  N'some string';

But instead the formatter now produces:
SELECT N'some string';

Also, when given a query like:
SELECT N, M FROM MY_TABLE;

You'd expect a result like:
SELECT
  N,
  M
FROM
  MY_TABLE;

But instead we get:
SELECT N,
  M
FROM
  MY_TABLE;

I think it would be better to handle this special string syntax inside Tokenizer, where all other strings are detected. Also, all other string syntaxes are configurable, so should be this. So we could configure strings like:
stringTypes: ["''", "N''"]

Coverage decreased (-0.5%) to 99.51% when pulling baa962f18ede81faf2964e16a055435d2906f638 on mtxr:master into 74d0459e2e32ad81c818763c1d7a9de37de523d6 on zeroturnaround:master.

Coverage remained the same at 100.0% when pulling 5694b826d5214c8e1044e4efc4c9831f0ec93200 on mtxr:master into 74d0459e2e32ad81c818763c1d7a9de37de523d6 on zeroturnaround:master.

@mtxr – waiting for your changes.

Sorry. I missed this notification, I'll do this by the end of the day

Coverage remained the same at 100.0% when pulling d6a294dc8b1c5e2a3c1b2e5f93488b265e9de78e on mtxr:master into 74d0459e2e32ad81c818763c1d7a9de37de523d6 on zeroturnaround:master.

Coverage remained the same at 100.0% when pulling 076761ab2af5039c7f8636219d57c4055012b871 on mtxr:master into 74d0459e2e32ad81c818763c1d7a9de37de523d6 on zeroturnaround:master.

@mtxr – here you go https://github.com/zeroturnaround/sql-formatter/releases/tag/v1.2.2


PLAT-100498 Fix thumb does not hide after scrolling in VL, Scroller native

Checklist

[x] I have read and understand the contribution guide

[ ] A CHANGELOG entry is included

[ ] At least one test case is included for this feature or bug fix

[ ] Documentation was added or is not needed

[ ] This is an API breaking change

Issue Resolved / Feature Added
The thumb does not hide after scrolling in VirtualList and scroller native type.
Resolution
While migration with hooks, we made to create scrollStopJob once, while scrollStopOnScroll which is the actual "job" for scrollStopJob can be created multiple times.
So when scrollStopJob started, it started with "old" scrollStopJob that holds faulty isVerticalScrollbarVisible state.
To scrollStopOnScroll have the right state, I made to create scrollStopJob multiple times just like scrollStopOnScroll did.
Additional Considerations
Links
PLAT-100498
Comments

LGTM


compile libaktualizr-demo fail

https://source.codeaurora.org/external/qoriq/qoriq-components/yocto-sdk/about/
Yocto with LSDK Components
The target : add libaktualizr-demo support the board of ls1046afrwy
1.download yocto layers
$: mkdir yocto-sdk
$: cd yocto-sdk
$: repo init -u https://source.codeaurora.org/external/qoriq/qoriq-components/yocto-sdk -b warrior
$: repo sync --force-sync
2.cd sources
git clone https://github.com/advancedtelematic/meta-libaktualizr-demo.git

IMAGE_INSTALL_append = libaktualizr-demo
4.bitbake fsl-image-networking
compile error:
ERROR: libaktualizr-demo-1.0+gitAUTOINC+7fbd28ec5d-9 do_install: Execution of '/home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/temp/run.do_install.10348' failed with exit code 1:
[1/13] cd /home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/build/aktualizr/src/libaktualizr/storage && /home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/git/aktualizr/src/libaktualizr/storage/embed_schemas.py /home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/git/aktualizr/config/sql/ /home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/build/aktualizr/src/libaktualizr/storage/sql_schemas.cc libaktualizr
[1/2] cd /home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/build && /home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/recipe-sysroot-native/usr/bin/cmake -P cmake_install.cmake
-- Install configuration: ""
-- Installing: /home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/image/usr/lib/sota/conf.d
-- Installing: /home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/image/usr/lib/libaktualizr.so
CMake Error at aktualizr/src/libaktualizr/cmake_install.cmake:60 (file):
file INSTALL cannot find
"/home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/git/include/libaktualizr":
No such file or directory.
Call Stack (most recent call first):
aktualizr/src/cmake_install.cmake:42 (include)
aktualizr/cmake_install.cmake:43 (include)
cmake_install.cmake:42 (include)
FAILED: CMakeFiles/install.util
cd /home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/build && /home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/recipe-sysroot-native/usr/bin/cmake -P cmake_install.cmake
ninja: build stopped: subcommand failed.
WARNING: /home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/temp/run.do_install.10348:1 exit 1 from 'eval ${DESTDIR:+DESTDIR=${DESTDIR} }VERBOSE=1 cmake --build '/home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/build' "$@" -- ${EXTRA_OECMAKE_BUILD}'
ERROR: Logfile of failure stored in: /home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/temp/log.do_install.10348
error
"/home/autocore/pcu-ewaol/dunfell/build_ls1046afrwy/tmp/work/aarch64-fsl-linux/libaktualizr-demo/1.0+gitAUTOINC+7fbd28ec5d-9/git/include/libaktualizr"
No such file or directory.

It looks like you've initialized your repo with warrior, but you also have references to dunfell. That could be a problem. I would recommend using dunfell, as warrior is no longer maintained by Yocto.
That said, I don't think this repo has been tested or used by anyone in a couple years. I see it claims to only be compatible with warrior. That's probably not true; it should work with newer branches as well. However, I don't have the capacity to diagnose your specific problem.
Did you update your bblayers.conf to include this layer? I don't see that listed in your steps. It looks like something is missing at a fairly high level; it could be as simple as that.
You can try asking Here Technologies for support if they're still interested in supporting this project.

Thank you for your reply.
I had added meta-libaktualizr-demo to conf/bblayers.conf.
Yes, the branch of yocto sdk was dunfell.
I changed meta-libaktualizr-demo/conf/layer.conf .


try-runtime: dynamic storage query sizes

Closes https://github.com/paritytech/substrate/issues/13246
Changes

[x] Created get_storage_data_dynamic_batch_size, allowing users to efficiently process a large amount of jsonrpc payloads without knowing the node max payload size configuration. The function calls itself recursively, increasing batch_size when the node responds successfully and reducing it when the node returns an error.async fn get_storage_data_dynamic_batch_size(
	client: &Arc<HttpClient>,
	payloads: Vec<(String, ArrayParams)>,
	batch_size: usize,
) -> Result<Vec<Option<StorageData>>, String>

[x] Implemented get_storage_data_dynamic_batch_size for fetching storage keys.
[x] Switched to using a Http provider for these huge requests. Using a WsClient I continuously encountered unhandleable errors from within the jsonrpsee library such as "961d622f: accumulated message length exceeds maximum" and the node would also randomly refuse to continue servicing WsClient, returning incorrectly formatted errors (missing request IDs) that were also causing more internal errors inside the jsonrpsee library. I'm not sure whether this issue is in the jsonrpsee library or the way the Substrate RPC is configured or worth this is worth opening an issue to investigate, let me know if I should.
[x] Removed parallelisation from rpc_child_get_keys. It runs extremely fast on just one thread (2 seconds on a Macbook Pro), and the logic to run it across multiple threads was quite complex and causing some difficult to debug issues. I've benchmarked this to confirm negligible performance impact, I do not think parallelising this piece of code is worth it at this time.

Notes

I compared the speed of loading storage from a local node against master. Performance is identical (+/- <2% between runs)
I tested this works fetching live state from wss://rpc.polkadot.io:443. it took 76min on my home internet, upload speed was be far the biggest bottleneck.

Switching this back to wip and going to implement a dynamic batch size as described here https://github.com/paritytech/substrate/issues/13246

"961d622f: accumulated message length exceeds maximum"

That error comes from soketto (the underlying ws library), do you have any logs/instructions how to reproduce it? It would be good if you could open an issue in jsonrpsee so we could fix it if it's a jsonrpsee bug. Smells like that something isn't really cancel-safe but who knows :P

Sure, I've described the problem in more detail and written up steps to replicate here: https://github.com/paritytech/jsonrpsee/issues/1086

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2706206

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2706221

Looks good on the whole. Could you please also test the difference with the parity nodes? https://gist.github.com/ggwpez/81db110fe4390ed9a7622f5857dfc4ff I dont expect there to be any - besides it being more fault tolerant.

Confirmed these are working

Hey @niklasad1, the polkadot staking-miner rpc expects that remote-externalities uses a WsClient: https://github.com/paritytech/polkadot/blob/5fd2bf8c9a0665b361eb26823030a5e0e65459b4/utils/staking-miner/src/rpc.rs#L108
Do you suggest that I refactor the staking-miner and open a companion PR, or try to modify this PR so that remote-externalities supports either a WsClient or HttpClient?

bot merge

bot merge force


[LOGINSECURITY] This player Is Already Online

This bug always Happens in Server To Almost Everyone
For 1-2 mins it logout player and The players is online in server but cant join

Sorry I dont think I fully understand. How do I reproduce this issue?


add a loading indicator to data upload form

as an administrator loading a list of locations I want to see a indication that the system has received the list and is busy loading

we can show the "progress" of data per row


strings: QEncodeWord benchmark regression due to strings.Builder

Compared with go1.10.2, tip shows performance regression in mime:
QEncodeWord-4   638ns ± 2%      787ns ± 1%    +23.28%  (p=0.008 n=5+5)

Change that affected it: CL102479/encodedword.go
sync.Pool+bytes.Buffer are replaced with strings.Builder.
I've changed strings.Builder to bytes.Buffer again, without using pool (and by the way, it was on different machine, so this issue is reproducible on both server and desktop hardware):
name           old time/op    new time/op    delta
QEncodeWord-8     481ns ±14%     599ns ±11%   +24.64%  (p=0.008 n=5+5)

name           old alloc/op   new alloc/op   delta
QEncodeWord-8      160B ± 0%      152B ± 0%    -5.00%  (p=0.008 n=5+5)

name           old allocs/op  new allocs/op  delta
QEncodeWord-8      2.00 ± 0%      5.00 ± 0%  +150.00%  (p=0.008 n=5+5)

The results are more noisy on my laptop, but the delta still stands.
cpuprofiles:
with bytes.Buffer

      flat  flat%   sum%        cum   cum%
    2090ms 21.05% 21.05%     2090ms 21.05%  bytes.(*Buffer).WriteByte
    1250ms 12.59% 33.64%     5080ms 51.16%  mime.WordEncoder.qEncode
    1230ms 12.39% 46.02%     3040ms 30.61%  mime.writeQString
    1130ms 11.38% 57.40%     2290ms 23.06%  runtime.mallocgc
     510ms  5.14% 62.54%      510ms  5.14%  runtime.memmove
     420ms  4.23% 66.77%      450ms  4.53%  strings.EqualFold
     410ms  4.13% 70.90%      950ms  9.57%  bytes.(*Buffer).WriteString
     400ms  4.03% 74.92%      400ms  4.03%  runtime.heapBitsSetType
     270ms  2.72% 77.64%      270ms  2.72%  unicode/utf8.DecodeRuneInString
     220ms  2.22% 79.86%      230ms  2.32%  runtime.scanobject

with strings.Builder

      flat  flat%   sum%        cum   cum%
    1560ms 13.03% 13.03%     5090ms 42.52%  strings.(*Builder).WriteByte
    1490ms 12.45% 25.48%     3460ms 28.91%  runtime.mallocgc
    1380ms 11.53% 37.01%     7070ms 59.06%  mime.WordEncoder.qEncode
     920ms  7.69% 44.70%     4880ms 40.77%  mime.writeQString
     880ms  7.35% 52.05%      880ms  7.35%  strings.(*Builder).copyCheck
     720ms  6.02% 58.06%     3530ms 29.49%  runtime.growslice
     550ms  4.59% 62.66%      550ms  4.59%  runtime.nextFreeFast (inline)
     450ms  3.76% 66.42%     1510ms 12.61%  strings.(*Builder).WriteString
     440ms  3.68% 70.09%      440ms  3.68%  strings.EqualFold
     380ms  3.17% 73.27%      380ms  3.17%  runtime.memmove

memprofiles:
with bytes.Buffer

ROUTINE ======================== mime.WordEncoder.encodeWord in $GOROOT/src/bytes/buffer.go
    1.15GB     1.15GB (flat, cum) 29.81% of Total
         .          .     61:func (b *Buffer) String() string {
         .          .     62:	if b == nil {
         .          .     63:		// Special case, useful in debugging.
         .          .     64:		return "<nil>"
         .          .     65:	}
    1.15GB     1.15GB     66:	return string(b.buf[b.off:])
         .          .     67:}
         .          .     68:
         .          .     69:// empty returns whether the unread portion of the buffer is empty.
         .          .     70:func (b *Buffer) empty() bool { return len(b.buf) <= b.off }
         .          .     71:
ROUTINE ======================== mime.WordEncoder.encodeWord in $GOROOT/src/mime/encodedword.go
    2.71GB     2.71GB (flat, cum) 70.19% of Total
         .          .     48:	return false
         .          .     49:}
         .          .     50:
         .          .     51:// encodeWord encodes a string into an encoded-word.
         .          .     52:func (e WordEncoder) encodeWord(charset, s string) string {
    2.71GB     2.71GB     53:	var buf bytes.Buffer
         .          .     54:
         .          .     55:	e.openWord(&buf, charset)
         .          .     56:	if e == BEncoding {
         .          .     57:		e.bEncode(&buf, charset, s)
         .          .     58:	} else {

with strings.Builder

      flat  flat%   sum%        cum   cum%
 2138.10MB 73.98% 73.98%  2138.10MB 73.98%  strings.(*Builder).WriteByte
  591.52MB 20.47% 94.45%  2890.12MB   100%  mime.WordEncoder.encodeWord
  160.50MB  5.55%   100%   160.50MB  5.55%  strings.(*Builder).WriteString

ROUTINE ======================== strings.(*Builder).WriteByte in $GOROOT/src/strings/builder.go
    2.09GB     2.09GB (flat, cum) 73.98% of Total
         .          .     87:
         .          .     88:// WriteByte appends the byte c to b's buffer.
         .          .     89:// The returned error is always nil.
         .          .     90:func (b *Builder) WriteByte(c byte) error {
         .          .     91:	b.copyCheck()
    2.09GB     2.09GB     92:	b.buf = append(b.buf, c)
         .          .     93:	return nil
         .          .     94:}
ROUTINE ======================== mime.WordEncoder.encodeWord in $GOROOT/src/mime/encodedword.go
  591.52MB     2.82GB (flat, cum)   100% of Total
         .          .     48:	return false
         .          .     49:}
         .          .     50:
         .          .     51:// encodeWord encodes a string into an encoded-word.
         .          .     52:func (e WordEncoder) encodeWord(charset, s string) string {
  591.52MB   591.52MB     53:	var buf strings.Builder
         .          .     54:
         .   457.51MB     55:	e.openWord(&buf, charset)
         .          .     56:	if e == BEncoding {
         .          .     57:		e.bEncode(&buf, charset, s)
         .          .     58:	} else {
         .     1.80GB     59:		e.qEncode(&buf, charset, s)
         .          .     60:	}
         .          .     61:	closeWord(&buf)
         .          .     62:
         .          .     63:	return buf.String()
         .          .     64:}
ROUTINE ======================== strings.(*Builder).WriteString in $GOROOT/src/strings/builder.go
  160.50MB   160.50MB (flat, cum)  5.55% of Total
         .          .    112:
         .          .    113:// WriteString appends the contents of s to b's buffer.
         .          .    114:// It returns the length of s and a nil error.
         .          .    115:func (b *Builder) WriteString(s string) (int, error) {
         .          .    116:	b.copyCheck()
  160.50MB   160.50MB    117:	b.buf = append(b.buf, s...)
         .          .    118:	return len(s), nil
         .          .    119:}

I haven't found any open strings.Builder performance issues.
My understanding is that strings.Builder is intended to be at least on par with bytes.Buffer, preferably even faster.
If this slowdown is expected and acceptable, this issue can be closed right away.

I have a fix; will send CL today.


Unable to view phonebook

Viewing the phonebook.json file shows a number stored. When reading the phonebook with catfacts p read it is empty.
v0.2.2

Fixed in v0.2.3


A javaScript error occured in the main process

Hello , I use IPTV NATOR with MPV PLAYER, This works well but I have an error, I leave you the message so you can see what's wrong with my setup.

Thank your for your feedback

Same here, exactly the same issue. It's working nonetheless but the error keeps popping up and makes watching a stream in fullscreen mode impossible. Context: using mpvplayer, installed it via scoop.

fixed in v0.14.0 - https://github.com/4gray/iptvnator/releases/tag/v0.14.0


Header not found when adding new messages (e.g. visualization_msgs)

We were attempting to add visualization_msgs to be generated for C#, but noticed that the generated C# code is expecting Header to be a message within visualization_msgs and not the std_msgs/Header. When visual studio tries to compile the generated C# code, it will fail because no visualization_msgs/Header exsits.
We have found out that this appears to depend on the alphabetical order of the package that the messages are in. If we rename visualization_msgs to avisualization_msgs (or have it start with any letter before s) everything will generate and compile correctly, and if it comes after std_msgs it will experience the error described above.
It looks like we can get everything to build correctly if we modify the messages themselves to have std_msgs/Header instead of Header in the .msg definition. But this is not ideal since it requires us to maintain a different & parallel message definition, and I believe will also cause the md5 of the messages to not match.

Issue confirmed. If you use std_msgs/Header, the md5 sum will definitely match correctly (as in https://github.com/uml-robotics/ROS.NET/blob/master/common_msgs/trajectory_msgs/msg/JointTrajectory.msg).
If you're curious, non-literal fields' types' md5 sums are inserted in place of their type names during md5 calculation, allowing explicit or implicit package determination to work).
I hadn't noticed the alphabetical component, but that would definitely explain why sensor_msgs/Images can simply use "Header" with no package name, but trajectory_msgs cannot! Thanks!


Weaver normal BAMs

I've spent the last two weeks trying to get Weaver to run on COLO829 and I'm still failing. How exactly is a matched normal used by Weaver?
I have encountered the following issues in my attempts to run weaver:

Some paths are hard-coded to $BIN/../data/ and ignore the command-line argument. This is not apparent until 16+ hours into the execution of that stage when an error occurs
The documentation is incorrect regarding which files should have a _num/_number suffix for which stage. Following the documentation results in a 0 byte output file. I needed to reverse engineer the source code to work this out.
SNP_LINK_1000G is an empty file but it appears that this file isn't actually used by the ploidy or weaver lite steps
No mention of the run_weaver.sh script in the documentation. Is this supposed to be how Weaver is run?
Tile sizes of 200 or less result in an empty TARGET file. I spent quite a bit of time debugging the Weaver source code to work this out.

Hi
Let us clarify the run case of Weaver; Weaver does not directly use a matched normal. The primary use case has been for data with only the tumor genome sequenced. This is because Weaver also expects high coverage, which is rare for normal samples.
In order to use a matched normal, the user could simulate it by running the first 3 steps in the Weaver pipeline (Calling SVs, Calling SNVs, Creating WIG file) separately run for the tumor and normal samples,
filtering the SNVs and SVs from these calls, and then running Weaver LITE and Weaver PLOIDY on the filtered SNV and SV files.
As to the other points:

I am assuming you are referring to failures happening in Weaver_pipeline.pl, on line 72. This is a known issue with older versions of Perl; the actual command is $GAP|| ..., which should default to the
user-defined value of $GAP if provided, and fallback to the internal specification otherwise.

Following the main instructions, the "_num/_number" suffixed files are only relevant if the BAM file, and subsequent files generated have purely numeric chromosome names. I would also point out that both the GAP and mapping quality files are only useful for the main chromosomes of the human genome, as of GRCh37; for other builds, we would need to get the gap and mappability files from the source.

This file has no specific use anymore, but is created as in the legacy code.

run_weaver.sh is a utility script written for running Weaver on TCGA samples with no matched normal. It was written mostly as to help with running Weaver on the cloud. As a result, it has been sufficiently stress-tested on TCGA samples.

TILESIZE is a parameter which must be set high enough that a non-zero number of reads ends up in each consecutive bin of the genome of size TILESIZE. If the BAM file used is from a low coverage sample,
then there may be bins with no reads in them, which throws an error. My guess would be that this is the case you are facing. I would suggest starting with a TILESIZE of ~1000-5000.

Let us clarify the run case of Weaver; Weaver does not directly use a matched normal.

So to clarify: when the weaver paper states  If there is matched normal sample available, it can also be used (see Supplemental Experimental Procedures)., this is to be taken more as a theoretical capability of the algorithm, and not a supported usage mode that has been tested to be working by the authors, correct?

The primary use case has been for data with only the tumor genome sequenced. This is because Weaver also expects high coverage, which is rare for normal samples.

What do you consider high coverage? My cohort has 30x normal and 90-100x tumour WGS coverage.

TILESIZE is a parameter which must be set high enough that a non-zero number of reads ends up in each consecutive bin of the genome of size TILESIZE. If the BAM file used is from a low coverage sample,
then there may be bins with no reads in them, which throws an error. My guess would be that this is the case you are facing. I would suggest starting with a TILESIZE of ~1000-5000.

With 90-100x coverage, small bin sizes will give non-zero results. My issue was that CONSERTING recommends 100bp bin sizes, but when I use these in Weaver I get no results and no error message because Weaver is hard-coded to ignore all bins <= 200bp regardless of coverage (see https://github.com/ma-compbio/Weaver/blob/f5fae8d8be1e7aec2edb5692366bf89f125ae6a5/src/partition.cpp#L313 )
Thanks for the response.

Would running Weaver PLOIDY on the tumour and normal separately then running Weaver LITE on a merged bam and passing it coverage estimates equal to the sum of the T and N work, or is that likely to just confound the MRF and give worse results?


Feedback appointments

Description
Added toast for various things
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Local deployment
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

i pair programmed this with henry


[Formatter] Casing of methods, operators, constants etc should be consistent and automatically corrected by formatter

The formatter should match the Intellisense styling so that code is consistent.
i.e. function names such as CALCFIELDS aren't case-corrected to CalcFields based on the Intellisense suggestions.

Another example, is BEGIN END. The intellisense and snippets will always suggest lowercase or title case.
Incidentally, C/SIDE used to do this for you when saving an object. Similar standards would help make public and partner code more consistent and readable.

Formatter is currently only dealing with whitespace, i.e. it will never make character edits, only add or remove whitespace characters.
We are looking at ways of fixing the txt2al converted instead such that the output already matches the formatter and best practices.

Txt2Al does use the capitals, I guess that's a separate issue.
As developers onboard to AL I imagine old habits (such as capitals for constants) will be tricky and time consuming to manually correct.
I guess ultimately the habit should be broken, but having a quick way to cleanup would be nice. As mentioned, C/SIDE did this, and in turn made code more visually consistent. Never thought I'd miss a C/Side feature 😜

Yes, precisely, txt2al currently converts using the old casing but we are looking at improving this.
For newly typed code IntelliSense already proposes correct casing so this is mostly a matter of handling converted legacy code correctly.

There will be a TON of code that has already been through an earlier version of Txt2AL that will be in UPPERCASE and I hate to think of the number of hours that it will take to go through this and 'correct it'.
Please add this to the AL language extension for VS Code asap rather than adding to Txt2Al which will only fix new code conversions..

We have it in our backlog to add it to VSCode, but until then, you can find other VSCode extensions built by the community which can fix the casing.

Thanks for originally logging this suggestion, but I am going to close it as won't fix. We have no plans on adding case conversion at this point, community solutions can be used instead. As an alternative, open a new idea on https://aka.ms/bcideas, and we might reconsider if high demand.


Add new test flow and go-test job

This PR aims to bring in the necessary logic in order to run go test ./... against the codebase.

@josegonzalez WDYT? 🙂


Fix 'add code comment' button being invisible all the time

As title; need to set opacity to non-zero value if we want it shown.

Codecov Report

Merging #13389 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13389      +/-   ##
==========================================
- Coverage   42.14%   42.12%   -0.03%
==========================================
  Files         691      691
  Lines       75966    75966
==========================================
- Hits        32019    32000      -19
- Misses      38703    38722      +19
  Partials     5244     5244

Impacted Files
Coverage Δ

modules/charset/charset.go
68.53% <0.00%> (-4.50%)
:arrow_down:

modules/git/utils.go
73.77% <0.00%> (-3.28%)
:arrow_down:

services/pull/temp_repo.go
26.59% <0.00%> (-3.20%)
:arrow_down:

services/pull/check.go
48.90% <0.00%> (-2.92%)
:arrow_down:

models/unit.go
46.57% <0.00%> (-2.74%)
:arrow_down:

services/pull/patch.go
53.97% <0.00%> (-1.71%)
:arrow_down:

modules/queue/workerpool.go
58.77% <0.00%> (-1.23%)
:arrow_down:

models/gpg_key.go
53.33% <0.00%> (-0.58%)
:arrow_down:

services/pull/pull.go
40.78% <0.00%> (-0.50%)
:arrow_down:

modules/git/repo.go
47.20% <0.00%> (+0.50%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 543697e...9f7bef7. Read the comment docs.

Wonder when that broke. We may need to backport to 1.13.
Also, icon seems a bit off-center:

It looks like these rules are meant to show that button:
https://github.com/go-gitea/gitea/blob/8176ba65731d9223cca984fbf2ea7dfbdc4855ce/web_src/less/_review.less#L43-L46
Those focus classes are only added by JS:
https://github.com/go-gitea/gitea/blob/8176ba65731d9223cca984fbf2ea7dfbdc4855ce/web_src/js/index.js#L1241-L1250
I think the reason why they don't trigger is the parent classes .code-view .lines-code,.code-view .lines-num are absent, probably since quite a long time.
I think it's quite bad that this is done in JS, this can be a pure CSS hover effect.

Made it work on full-line hover like GitHub and removed remnants of JS solution.

Needs 1.13 backport.

🚀

@CirnoT please send backport :)


Improved reliability and some initial ci configuration (closes: #10, #17, #20, #25, #27, #28, #30)

Overview of changes:

bail feature
glob pattern
fix xvfb race conditions with staggered start
replace logbased communication with filebased communication as a workaround for intermittent missing test results
add check to make sure no results are missing
removed reporting feature of orchestrator, now just pipes output to process
utilize cypress-multi-reporter so that results orchestration is always on
added some rudimentary CI

related issues:

#30 was already solved, now reporter can also be passed in while still summing up results
#28 intermittent missing results should be fixed and fails run on missing results
#25 also already solved, just pass in the wanted reporter and now it should still be summing results and exit correctly
#20 was already working, but now also has the glob feature mentioned
#17 orchestrator reporter was skipped when custom reporter was passed in, now it's always included
#10 glob pattern added, supply better pattern to solve issue

#27 might also be related, the issue I saw with intermittent missing results was that the event fired correctly in the reporter, but was never picked up when reading the logs, switch to filebased communication should hopefully make it a bit more robust

Hi! I'm trying out this library facing issue #17. Would it be possible to merge this? I'd love to try it out and see if it fixes my issue.
Thanks!

Would love to see this merged. issue https://github.com/tnicola/cypress-parallel/issues/28 is a pretty big blocker for use of this package for our CI pipeline

@kristofferlind Thanks a lot for all the cleanup, feature implementation, CI and bug fixes 👏


Does not work

I was following video example precisely. Even with your default values it does not work.

I replaced a playlist with my playlist, the link is correct and has the same format. There is an error while building the index. It cannot crawl youtube video. The playlist is public.
I used your playlist and once it deployed the web app link does not work. It says "Your app will appear here once you complete your first deployment.". Even though all steps were successful and it says it is deployed.

Great concept, but poor implementation. Is there a way to fix it?

Hi, So sorry you're having problems. Let's see if we can get them resolved.
On (1) the problem seems somehow related to the playlist url, since you mentioned in (2) that the demo playlist got past the index creation step.

please post the exact text of the error, and)/or screenshots, so we can diagnose it?
if possible please post the playlist that fails for you.. then we can try to reproduce the problem to see the reason why it failed.

On (2) this message just means to wait a bit.. did you seein the blog post..

If the application isn’t ready when you first open the page, don’t worry! The initial application build and deployment (using AWS Amplify) takes about 10 minutes, so it will work when you try again a little later. If for any reason the application still doesn’t open, refer to the README in the GitHub repo for troubleshooting steps.

Can you check again and see if it works? If not please post exact messages/ screenshots.
Sent from Workspace ONE Boxer
On Jul 4, 2023 1:34 AM, aejuice-github @.***> wrote:
I was following video example precisely. Even with your default values it does not work.

I replaced a playlist with my playlist, the link is correct and has the same format. There is an error while building the index. It cannot crawl youtube video. The playlist is public.
I used your playlist and once it deployed the web app link does not work. It says "Your app will appear here once you complete your first deployment.". Even though all steps were successful and it says it is deployed.

Great concept, but poor implementation. Is there a way to fix it?
—
Reply to this email directly, view it on GitHubhttps://github.com/aws-samples/aws-kendra-transcribe-media-search/issues/29, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACTSFHXQW2ROIQTWXRRK3TLXOOTOLANCNFSM6AAAAAAZ5G6QQU.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

@rstrahan 1. Incorrect. Your playlist works because results are cached. According to your documentation, you do not parse videos twice. It does not work with any other playlist, I've tried plenty. In fact, we've debugged why it does not work. Your app uses a package pytube which is outdated. YouTube has changed the link structure and it cannot get a video. You can find more info and error message at https://stackoverflow.com/questions/68945080/pytube-exceptions-regexmatcherror-get-throttling-function-name-could-not-find
Here is a link to the playlist https://www.youtube.com/playlist?list=PLr7J3R1sT1C5pcB_xuhH1cTV9W19z1iDk
I hope you'll be able to resolve it. We would be very interested in using the service.

You're correct. The issue is resolved.

@aejuice-github
OK, we'll look into (1) and post back.. Thanks for letting us know.

Confirming that I can easily repro the problem using public playlist: https://www.youtube.com/playlist?list=PLDtc_uppNe1rjev7rLFVKN0Qe1lzLeFmp

Referring to colleague who implemented this feature.  Tx.

Regarding issue #1.
The solution "does not" cache a playlist. When the playlist is changed the solution will index the videos per the new playlist (if they have not been indexed prior).
The issue that is currently causing the stack to fail is with pytube  version 15.0.0. Issue - > (https://github.com/pytube/pytube/issues/1707).
We are working to fix this in the interim while a permanent fix is made to the pytube main branch.

Tested v0.3.1 which contains the pytube 15.0.0. fix.
I am now able to index youtube videos on the YT playlist provided as default value of the CFN template parameter. Also able to change the playlist to the playlist quoted in the issue above https://www.youtube.com/playlist?list=PLr7J3R1sT1C5pcB_xuhH1cTV9W19z1iDk. And the indexer picks up the new videos as well.
This issue is fixed and can be closed.

Release v0.3.1 based on your PR @roshansthomas addresses this issue. Updated artifacts published to the public S3 bucket.
(The fix is temporary, and applies only to the current version of pytube, 5.0.0. We expect that the next release of pytube will address the issue officially)
@aejuice-github please deploy again and report back if you encounter any remaining issues. Thanks again for letting us know about the problem.

Closing issue as the the solution now uses yt_dlp package


[Discussion] SessionID vs Authentication per User

The current way a user authenticates themselves is via the SessionID which is not generated per user, but per browser session. This is not ideal for evaluation scenarios where not every user has direct access to the full system they are using.
I would propose a scheme to authenticate submissions where there is a user-based authentication, so that the system can be set up in advance by an admin and not every participant has to manually check their sessionid and then somehow enter that in the system.

The authentication based on a session id is deliberate, since it enables to distinguish between actions taken by different devices which might be using the same user account. Especially in a distributed setting, it is desirable to not only know which account but rather which session was the origin of a particular action.

The sessionId could be something like a hash of the username+password, so it would become invalid as e.g. the password changes. As Silvan said, that way I could have set up all instances before the evaluation. But this way, we first have to wait until all users have connected to DRES, submitted me their session ids, so I can redeploy all vitrivr-ng instances with the changed config etc. So we'll need at least 20min in that evalution to become DRES ready.
Perhaps there should be a config option in future, so we can choose between multi device or a kind of static id. Because in my case I really don't need the ability to distinguish between actions taken by different devices, but to set up like 10 instances before and not during the meeting would be nice for all. For the admin as a lot of work can be done beforehand, it can even be tested, so no copy paste error has been made etc and all participants don't have to wait until all instances have been edited and redeployed.

While I see your point, hashing some user data is certainly not the way to go here. What I could see as an option would be to have user-specific API keys which can be generated and revoked by an individual user for their account and for an admin for all accounts. This would solve the problem with ahead-of-time deployment but still not enable the distinction of individual devices. Supporting any more sophisticated authentication management would be a larger change and certainly not something that would happen any time soon. A substantially easier solution to this issue would be to add a configuration option to the UI of the systems wanting to interact with DRES, such that the session id can be set by an end-user (for example by just pasting it into an appropriate field in a settings panel), rather than having to edit configuration files. vitrivr-ng even used to support local versions of the configuration exactly for such cases, this functionality was however removed at some point, as far as I know.


python3PackagesWithNumpy2: init

Description of changes
We want a version of the Python package set using numpy_2 to be available in the cache. Recursing into the attribute set makes Hydra build it.
This should make a non-solution like https://github.com/NixOS/nixpkgs/pull/338334 unnecessary.
closes https://github.com/NixOS/nixpkgs/pull/338334

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Can't say I'm a fan of another python package set. I'd much rather keep numpy_1 for 24.11 and evaluate moving to numpy_2 after.

I am not really excited about it.
I don't have the time or computing resources to maintain a numpy2 tree, and it would push a huge cost on all the maintainers associated with python ecosystem.

Doing some quick checks, I'm getting that 3660 additional derivations would be built by Hydra, that's about 39.4% of python3Packages, definitely not insignificant.
Code
let
  pkgs = import ./. {};
  inherit (pkgs) lib;
  all = lib.attrNames pkgs.python3Packages;
  grouped = lib.partition (name:
    builtins.tryEval (pkgs.python3Packages.${name}.outPath or null)
    == builtins.tryEval (pkgs.python3PackagesWithNumpy2.${name}.outPath or null)
  ) all;

  additional = lib.length grouped.wrong;
  total = lib.length all;
in
"${toString additional} additional derivations would be built by Hydra, about ${toString (100.0 / total * additional)}% of the python3Packages"

Are there a lot of expected breakages from the Numpy 2 upgrade? In that case this package set might also be a great to have so that breakages can be seen on Hydra. People depending  on Numpy 2 would be incentivised to use it and submit fixes for breakages.

This solution is still a bit weird, but a bit more acceptable, and definitely better then some other proposals that were raised. I wonder if @mweinelt can share with us how severe were the breakages in the last python updates cycle? Since these changes have to go through staging anyway, why not make numpy = numpy_2 and see how many new failures we see Hydra in the upcoming staging-next cycle?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/several-comments-about-priorities-and-new-policies-in-the-python-ecosystem/51790/3

I assume removing python311Packages is not an option because ML stuff depends on it, in particular tensorflow? I think if we could remove it and add python3PackagesWithNumpy2 instead this might not be the worst idea.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/several-comments-about-priorities-and-new-policies-in-the-python-ecosystem/51790/7

There’s quite a few packages pinning 3.11 right now. I think we always carry one version back?

I took the first 4 commits to an external PR which can be merged a bit quicker, because it seems we agree upon them: https://github.com/NixOS/nixpkgs/pull/340832

Numpy was updated to v2 in https://github.com/NixOS/nixpkgs/pull/354627.


Allow configuring OIDC ID token ttl using TokenSettings

Closes gh-1689

@jgrandja

Closing due to https://github.com/spring-projects/spring-authorization-server/issues/790


Expected to decode Array but found a dictionary instead.

Hi, I'm currently trying to send a transaction to a contract and I'm getting the following error:
▿ DecodingError
  ▿ typeMismatch : 2 elements
    - .0 : Swift.Array<Any>
    ▿ .1 : Context
      - codingPath : 0 elements
      - debugDescription : "Expected to decode Array<Any> but found a dictionary instead."
      - underlyingError : nil

The way I'm sending the transaction is:
 public func send (method name: String, // <---- "AddCandidate"
                                    taking arguments: [AnyObject], // <--- ["This is a string"] as [AnyObject]
                                    extra data:Data = Data(),
                                    from sender: EthereumAddress,
                                    unlocksWith passphrase: String,
                                    completion handler: ((EthereumTransaction?, Bool, Error?)->())? ) {
        var txOptions = TransactionOptions()

        txOptions.gasLimit = TransactionOptions.GasLimitPolicy.automatic
        txOptions.gasPrice = TransactionOptions.GasPricePolicy.automatic

        txOptions.from = sender

        guard let writeTx = self.web3Contract.write(name, parameters: arguments, transactionOptions: txOptions) else {
            handler? (nil, false, nil)
            return
        }
        let promise = writeTx.sendPromise(password: passphrase, transactionOptions: txOptions)

        _ = promise.done(on: DispatchQueue.main, { (results) in
            handler? (writeTx.transaction, true, nil)
        }).catch(on: DispatchQueue.main, { (error) in
            handler? (writeTx.transaction, false, error)
        })

    }

and this is the ABI of that method:
{"constant":false,"inputs":[{"name":"candidate","type":"string"}],"name":"AddCandidate","outputs":[],"payable":false,"stateMutability":"nonpayable","type":"function"}

After following a bit around the lib I found that the place where it gets the error is on Promise+Batching.swift --> Batch class --> trigger func --> Line 82, when it calls sendAsync the JSONRPCRequest batch, more specifically the error message comes on Promise+HTTPProvider.swift --> post func --> Line 92,  this is the request that is being sent:
(lldb) po request
▿ JSONRPCrequestBatch
  ▿ requests : 1 element
    ▿ 0 : JSONRPCrequest
      - jsonrpc : "2.0"
      ▿ method : Optional<JSONRPCmethod>
        - some : Web3swift.JSONRPCmethod.sendTransaction
      ▿ params : Optional<JSONRPCparams>
        ▿ some : JSONRPCparams
          ▿ params : 1 element
            ▿ 0 : TransactionParameters
              ▿ data : Optional<String>
                - some : "0x7e54b8e20000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000001054686973206973206120737472696e6700000000000000000000000000000000"
              ▿ from : Optional<String>
                - some : "0xf92901dbdfec2a0599ee5108808c5ec85244eaf9"
              ▿ gas : Optional<String>
                - some : "0x15b5f"
              ▿ gasPrice : Optional<String>
                - some : "0x3b9aca00"
              ▿ to : Optional<String>
                - some : "0x11e8e870d72b5fbc46f886f865aa98470d01e249"
              ▿ value : Optional<String>
                - some : "0x0"
      - id : 32

Edit: after inspecting a little more I found that the actual data we get back is:
(lldb) po JSONSerialization.jsonObject(with: data, options: [])
▿ 2 elements
  ▿ 0 : 2 elements
    - key : jsonrpc
    - value : 2.0
  ▿ 1 : 2 elements
    - key : error
    ▿ value : 2 elements
      ▿ 0 : 2 elements
        - key : message
        - value : The method eth_sendTransaction does not exist/is not available
      ▿ 1 : 2 elements
        - key : code
        - value : -32601

and indeed eth_sendTransaction doesn't exist in infura API, we have eth_sendRawTransaction.
Edit2: Found the issue, it was that I forgot to provide the keystoreManager to the client so it could locally sign the transactions, errors were quite misleading.

@baquedano It's great that you were able to solve the problem. I'll close this issue.
If you have more questions - open it again

I am having same problem while sending token
{
    error =     {
        code = "-32601";
        message = "The method eth_sendTransaction does not exist/is not available";
    };
    id = 7;
    jsonrpc = "2.0";
}


Add a initial_best parameter in ModelCheckpoint Callback

Add a initial_best parameter in ModelCheckpoint that is stored as self.best. If a session is stopped and rerun or kernel dies, then the best value of metric is taken as np.inf or -np.inf and the model is saved after the first epoch without taking into consideration the initial performance of model. So modelweights are overwritten even if the previous model performance was better than the current model.
Unit testing notebook can be found here .
Cc: @qlzh727 can you give it a look please?

Please send this PR to keras-team/keras and make the code change there. Thanks.


Problem in kubectl outputs

HI,
first of all: thanks for this extesion, it helps a lot.
But there seems to be an issue if the output comes too fast or something. It might be the debouncing?
The output is only printed after I terminate the line or a new pod is created.
%%livebash
kubectl get pods -w

It works if I use the following code:
import subprocess
import shlex
def run_command(command):
    process = subprocess.Popen(shlex.split(command), stdout=subprocess.PIPE)
    while True:
        output = process.stdout.readline()
        if output == '' and process.poll() is not None:
            break
        if output:
            print(output.strip().decode("utf-8") )
    rc = process.poll()
    return rc

run_command("kubectl get pods -w")

Hi @smerschjohann ,
Thank you for reporting the issue. The bug is indeed related to the debouncer. I have just modified the debouncer and run the script in a thread. The fix is available in the main branch.  I will test it for a few days. If no other problem is found, I will make a new release.

@benlau Thank you, with the new version it works now :)


upstart detection doesn't play well with busybox

Busybox, as found on my routers, has its own version of /sbin/init. That doesn't read any command-line argument. So, if you run /sbin/init --version this restarts the whole system, which eventually ends up in a loop.

Yeah, even if it's not end up in a loop it hangs the process. This was very weird issue to debug since detection is happening in the init() in the included package.

I'm going to try and look at this with my copy of dd-wrt tonight. /sbin/initctl version is an alternative method to grab the version of upstart, and i'm going to see if that reboots the server

/sbin/initctl --version seems to provide the detail we need for upstart, and doesn't cause busybox to die.


Metadata regarding type of ensemble

E.g. is it a

history matching iteration ensemble (iter-0, ... iter-3...)
prediction ensemble
sensitivity ensemble

The "ensemble type" (better terminology might/probably exist) will be used by clients in order to filter out ensembles not relevant in a given analysis dashboard/pattern.

A bit more complex perhaps, but it would also be very useful to have metadata answering e.g. which history matching ensemble is a given prediction ensemble based on.

Some user stories on parent-child-linking of ensembles:

You have a prediction run (which is a RESTART from an AHM run), and want to know the quality of the AHM-ensemble it was based on. With parent-child-linking metadata clients downstream can use this information to give the user this insight.
You have a prediction run (which is a RESTART from an AHM run), and a user you want the time series and/or 3D grid to extend the whole time axis (history + prediction) and not just prediction.  With parent-child-linking metadata clients downstream can fetch data from both ensembles (history and prediction) and combine them in the presentation.
You could have a "base prediction run" (e.g. going to 2030), and from there you have multiple different prediction scenarios reflecting different decisions to be made by the asset. If clients could e.g. query "which ensembles uses this ensemble as parent" that could be used to present a list of ensembles (future scenarios) based on the same base ensemble.
*[...]

This links to #291 perhaps

I have tried to run drogon_pred_ref.ert and found that the results for pred_ref ensemble are uploaded to iter-0. From discussion with @perolavsvendsen apparently, dataio assumed iter-0 as default ensemble name and used them to generate ID.
See case 01_drogon_ahm_sumo in sumo prod

Yes, we currently don't get any information on type of ensembles within a case, and as far as I know no such definition exists either.
This obviously maps to ERT quite fast. If not, we would have to do something rule-based based on iteration names.
Is there a standard (convention) on iteration names?

No strict/official rules for iteration names to my knowledge (AHM runs typically go iter-0, iter-1, ..., iter-x and prediction cases often has pred in the name, but no guarantee iter and pred are used as substrings).
I agree this information/metadata should come from ERT. Knowing the workflow method used by ERT for generating the ensemble would probably be a good start (https://ert.readthedocs.io/en/latest/reference/running_ert.html - ensemble_smoother, es_mda, iterative_ensemble_smoother, ensemble_experiment). Can/is this information exposed in some way @sondreso?
Within an assisted history matching run it would also be useful for clients of the data sets to know which ensembles are part of the same assisted history matching run (i.e. iter-0 = prior, iter-{max} = posterior, and also the order of ensembles inbetween representing gradual updates from prior to posterior...).
Pinging @asnyv in case there are details / use cases you want to mention I haven't.

Think @anders-kiaer has covered most of it, but for predictions I think we (at least me) often skip the term "pred" and use some more or less descriptive name dependent on whatever we are simulating. From a technical perspective: completely arbitrary.
Also: for a while I think it was fairly common to have a structure like:
History matching:
some_ahm_case/realization-x/iter-y
Predictions:
some_prediction_scenario/realization-x
some_other_prediction_scenario/realization-x

Now it seems like more are going towards a structure where the prediction case is placed on the "iteration level" like you mention, so:
some_ahm_case/realization-x/iter-y
some_ahm_case/realization-x/some_prediction_scenario
some_ahm_case/realization-x/some_other_prediction_scenario

The advantage with the latter is that it is clearer what the basis for the prediction is, whilst the advantage of the first one is that it is easier to see all cases in a folder structure + it is a more natural structure for models without any history. But many of the models without history have now ended with the structure: some_prediction_scenario/realization-x/iter-0 as a more or less de facto standard, but I can't really say why 😅 My guess is that someone found it convenient as they could then reuse something they had hard-coded for AHM.

Suggest we first try to accurately reflect the name in the outgoing metadata, not default to iter-0 if it looks strange. The more challenging bit is probably the iteration id, which in turn maps to the iteration uuid.
I assume that ERT internally has an iteration ID which we cannot know if the iteration is called something other than e.g. iter-0. Every single instance of fmu-dataio will (currently) look at the file structure to determine what iteration we are in. The code has been structured in such a way that it should be possible to get this from ERT when it is available, but so far it is not.
An alternative is to take away all logic placed on the iteration id and only use the iteration name.

Drafting a possible PR, quick and dirty 👆. This needs discussions, as I am a bit unsure of the consequences. But possibly, the iteration name is a better option (outside the ERT context) than iteration id. E.g. the name is used as an identifier, not the ID. (This is similar to the current practice for the case.name, where no ID exists.
For the third similar object, realization, we are more dependent on the ID I guess.

This is also a feature request from SSDL, ref discussions with @bous251

Thanks for the update @mferrera. Looks good - this metadata enables some of the use cases, and partially solves this issue. The remaining part is then relationships between ensembles. E.g.:

Ensembles belonging to the same AHM run (iter-0, iter-1, iter-2, ..., iter-N).
Ensembles which continue simulating ("restarts") from another ensemble (typical scenario is prediction runs which uses an AHM ensemble as starting point).

Ensembles belonging to the same AHM run (iter-0, iter-1, iter-2, ..., iter-N).
This should be covered either via fmu.case, or probably better via fmu.ert.experiment.

Ensembles which continue simulating ("restarts") from another ensemble (typical scenario is prediction runs which uses an AHM ensemble as starting point).

This is much larger probably, and involves more than just metadata. Supporting restart should probably be a separate, larger issue/epic. Need to store the required files (not really scope for Sumo), amake them available on a disk area, etc. This feels like something which might be more in scope for ERT storage, but unsure.

Yes, the first bullet point is easiest to solve.
The second one has value also without additional files stored in Sumo. E.g.

if you have a prediction ensemble in Sumo that was simulated from 2025 and onwards, the Sumo client could want to present the end user concatenated time series from that prediction ensemble together with the time series data in Sumo from the corresponding history matched ensemble it was restarted from.
...or you want to show the user which parameters where inherited from the AHM ensemble into the prediction ensemble (since it is a 1-1 correspondence between realizations in the two ensembles).

With that being said, the metadata to know which ensemble a given ensemble was restarted from is not owned by any software today (not even ERT), so perhaps we need the full solution like you point to @perolavsvendsen (being able to restart from previous run stored somewhere in a standard way) in order for fmu-dataio to even get hold of the required parent-child ensemble metadata.


individual records ack - java

Hi,
What can be done to provide individual records acknowledgement in the java module, similar to what is provided in node.js ? What about checkpointing ? Thanks.

Hi ngb18,
Could you give ussome more details on what you mean by "individual records acknowledgement" or point us to the piece of the NodeJS code that you're referring to?  Are you looking for a per-record callback?
As far as checkpointing goes, it depends on what methodology you're using to read from Kinesis.  Are you using Lambda?  Or the KCL?  Or are you doing it by hand?  I believe Lambda checkpoints for you and in the KCL case you're responsible for checkpointing yourself, though I've generally seen people checkpoint per batch rather than per record.

Hi ,
Thanks for the response. Yes, i was looking for a Lambda checkpointing for a per-record basis.If there is an error in processing the Lambda for a kinesis stream record, the entire batch is sent back to be retried again. Is this understanding correct ?  What i would like is the ability to checkpoint the "processed" records, so that i do not have to process them again as an entire batch. Thanks for your help!

Your understanding is mostly correct (see https://forums.aws.amazon.com/message.jspa?messageID=639825), but I did want to make one clarification:  the only way your Lambda function will "fail" (other than timing out) is if you have an uncaught exception or other fatal error.  If you wrap your per-record processing in a try/catch, you should be able to detect failing records (whatever failing means to you) and act on them appropriately.  That being said, I realize the streams API as we've provided it doesn't make that easy.
Would adding a new deaggregation method that takes in a single record solve your issue?  That way you could process your records one by one and easily use try/catch to detect the records that are malformed and handle them, but you'd be able to keep processing the entire batch.
As far as the checkpointing goes, I don't believe you can do your own checkpointing in Lambda.  I believe Lambda handles that for you.  It will checkpoint after each batch it processes.  You could in theory do what you want by setting a really small batch size, but I think that's a Kinesis/Lambda anti-pattern and I don't think I'd recommend it (though it obviously depends on how much data you're sending and how often).

Thanks for the response. Where do i find more information on the Lambda checkpointing ? I have not come across any information for lambda checkpointing in aws docs.

I'm not sure the docs explicitly call out the checkpointing behavior anywhere.  Let me follow up with the team and see what the official stance is.  The closest I can find is from the FAQ (https://aws.amazon.com/lambda/faqs/) where it explains failure behavior:
Q: What happens if my function fails while processing an event?

For Amazon S3 bucket notifications and custom events, AWS Lambda will attempt execution of your function three times in the event of an error condition in your code or if you exceed a service or resource limit. For ordered event sources that AWS Lambda polls on your behalf, such as Amazon DynamoDB Streams and Amazon Kinesis streams, Lambda will continue attempting execution in the event of a developer code error until the data expires. You can monitor progress through the Amazon Kinesis and Amazon DynamoDB consoles and through the Amazon CloudWatch metrics that AWS Lambda generates for your function. You can also set Amazon CloudWatch alarms based on error or execution throttling rates.

I've got an update in the works that will provide an API to let you deaggregate on a per-record basis as well.  It will hopefully be ready in the next week or two.

Hi, Thanks for the response! I wanted to follow up to see if you have an official stance from the team about the checkpointing. Appreciate your time!.

I'm sorry, I was out of the office for a few days.  I pinged the team again.  I'll let you know what I find out.

OK, I just confirmed with the team.  Lambda does indeed handle checkpointing on your behalf.  It will checkpoint after a successfully processed batch of records.  There is currently no way to checkpoint a partial batch (i.e. you can't checkpoint partway through processing a batch).  If you want to checkpoint more frequently, your best option at the moment is to reduce your batch size (smaller batches = more frequent checkpoints).
I believe that definitively answers your questions, so I'm going to go ahead and close this issue.  If you have further questions, feel free to reopen the issue or create a new one.


Branch-2.0fixThe CREATE TABLE IF NOT EXISTS AS SELECT statement should refrain from performing any INSERT operations if the table already exists

#35210

run buildall


Is card-reveal supported?

Is the card-reveal option working? If so, what attribute should I use to make it work?

Hmm... My issue might be related to using a minified version of jQuery, as I'm getting that error referenced on #78 again.
Now I'm also having the same issue experienced by @bernhardwaidacher: if I use the minified version, I get e.velocity is not a function; if I use the non-minified version, then I get the Cannot read property 'swing' of undefined error.

@wceolin is it using JS? I think it's plain CSS, so it should be working without any special support.
I tried the following HTML (taken straight from the MaterializeCSS site) and it worked in my angular app:

      Card Titlemore_vert

This is a link

      Card Titleclose

Here is some more information about this product that is only revealed once clicked on.

If you have a specific example that doesn't work please let us know. Otherwise, could you close the issue? Thanks.

Hmm... It's not working, but it's probably some silly mistake I'm making because I just copied and pasted the code above and it worked.
In my case, I have something like this right now:
card.html

  <app-fruits *ngSwitchCase="'fruits'"></app-fruits>
  <app-vegetables *ngSwitchCase="'vegetables'"></app-vegetables>

fruits.html

    Orange

Some code here

  Card Titleclose

Here is some more information about this product that is only revealed once clicked on.

Anyway, should I close it as it's not related to angular2-materialize itself?

Yes please. Thanks for the quick feedback.
On 16 Oct. 2016, at 4:07 pm, Will Ceolin <notifications<EMAIL_ADDRESS>wrote:
Hmm... It's not working, but it's probably some silly mistake I'm making because I just copied and pasted the code above and it worked.
In my case, I have something like this right now:
card.html

fruits.html

Orange
Some code here

Card Titleclose
Here is some more information about this product that is only revealed once clicked on.

Anyway, should I close it as it's not related to angular2-materialize itself?

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/InfomediaLtd/angular2-materialize/issues/134#issuecomment-254045830, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AB0dxr-8qDmUvTi6iZYJBpRwPj8lgiqUks5q0iGigaJpZM4KR4N7.


chore (workflows): update deploy all demos workflow to run on package release

TL;DR
Updated the trigger for the "Deploy Demos to All Environments" workflow.
What changed?
Modified the workflow trigger from push events on tags starting with 'v' to release events of type 'published'.
How to test?

Create a new release in the repository.
Publish the release.
Verify that the "Deploy Demos to All Environments" workflow is triggered automatically.

Why make this change?
This change ensures that the deployment workflow is triggered only when a release is published, rather than on every tag push. This provides more control over when deployments occur and aligns the process with the release lifecycle.

#127  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @keeganpotgieter and the rest of your teammates on  Graphite

Merge activity

Sep 2, 3:54 AM EDT: @keeganpotgieter started a stack merge that includes this pull request via Graphite.


Nested layout ignored

Nested layout (nested/_layout.tsx) is ignored, page should show h3 element Nested Layout, but doesn't.
Steps to reproduce:

clone waku repository
cd into examples/11_fs-router
npm i
npm run dev
open localhost:3000/nested/test

Hi, thanks for reporting.
I believe it's the same as #1055.
The fix has already been merged into main and it will be included in the next release.

v0.21.9 has been released. Let us know if that doesn't fix.


Error in AutoModel.from_pretained .... requires Accelerate and bitsandbytes but both of them already installed

I have got the below error when running the "FinGPT_Training_LoRA_with_ChatGLM2_6B_for_Beginners.ipynb"... but both Accelerate and bitsandbytes packages have been installed. Have I done anything wrong?

ImportError                               Traceback (most recent call last)
Cell In[22], line 5
3 model_name = "THUDM/chatglm2-6b"
4 tokenizer = AutoTokenizer.from_pretrained(model_name, trust_remote_code=True)
----> 5 model = AutoModel.from_pretrained(
6         model_name,
7         quantization_config=q_config,
8         trust_remote_code=True,
9         device='cuda'
10     )
11 model = prepare_model_for_int8_training(model, use_gradient_checkpointing=True)
File ~/anaconda3/lib/python3.11/site-packages/transformers/models/auto/auto_factory.py:479, in _BaseAutoModelClass.from_pretrained(cls, pretrained_model_name_or_path, *model_args, **kwargs)
475     model_class = get_class_from_dynamic_module(
476         class_ref, pretrained_model_name_or_path, **hub_kwargs, **kwargs
477     )
478     _ = hub_kwargs.pop("code_revision", None)
--> 479     return model_class.from_pretrained(
480         pretrained_model_name_or_path, *model_args, config=config, **hub_kwargs, **kwargs
481     )
482 elif type(config) in cls._model_mapping.keys():
483     model_class = _get_model_class(config, cls._model_mapping)
File ~/anaconda3/lib/python3.11/site-packages/transformers/modeling_utils.py:2257, in PreTrainedModel.from_pretrained(cls, pretrained_model_name_or_path, *model_args, **kwargs)
2255 if load_in_8bit or load_in_4bit:
2256     if not (is_accelerate_available() and is_bitsandbytes_available()):
-> 2257         raise ImportError(
2258             "Using load_in_8bit=True requires Accelerate: pip install accelerate and the latest version of"
2259             " bitsandbytes pip install -i https://test.pypi.org/simple/ bitsandbytes or"
2260             " pip install bitsandbytes"    2261         )    2263     if torch_dtype is None:    2264         # We force thedtypeto be float16, this is a requirement frombitsandbytes   2265         logger.info(    2266             f"Overriding torch_dtype={torch_dtype} withtorch_dtype=torch.float16due to "    2267             "requirements ofbitsandbytes` to enable model loading in 8-bit or 4-bit. "
2268             "Pass your own torch_dtype to specify the dtype of the remaining non-linear layers or pass"
2269             " torch_dtype=torch.float16 to remove this warning."
2270         )
ImportError: Using load_in_8bit=True requires Accelerate: pip install accelerate and the latest version of bitsandbytes pip install -i https://test.pypi.org/simple/ bitsandbytes or pip install bitsandbytes`

i have edited the above hopefully provide more detail.. any help?

I had the same and managed to fix this by running
pip install transformers==4.32.0
and restarting the session..

You need to restart the session if this happened. You may also refer to this repo for more detailed explanation with my articles inside. https://github.com/AI4Finance-Foundation/FinGPT-Research


[SPARK-42719][CORE] MapOutputTracker#getMapLocation should respect spark.shuffle.reduceLocality.enabled

What changes were proposed in this pull request?
MapOutputTracker#getMapLocation should respect spark.shuffle.reduceLocality.enabled
Why are the changes needed?
Discuss as https://github.com/apache/spark/pull/40307
getPreferredLocations in ShuffledRowRDD should return Nil at the very beginning in case spark.shuffle.reduceLocality.enabled = false (conceptually).
This logic is pushed into MapOutputTracker though - and getPreferredLocationsForShuffle honors spark.shuffle.reduceLocality.enabled - but getMapLocation does not.
So the fix would be to fix getMapLocation to honor the parameter.
Does this PR introduce any user-facing change?
No
How was this patch tested?
New ut

Is this still in draft @jerqi ?
Also, +CC @cloud-fan who reviewed this earlier.

Is this still in draft @jerqi ? Also, +CC @cloud-fan who reviewed this earlier.

Is this still in draft @jerqi ? Also, +CC @cloud-fan who reviewed this earlier.

Thanks @mridulm It's ready for review.

Will wait for the CI to succeed. Thanks for fixing this @jerqi !

The test failure is unrelated, I retrigger the test.

Merged to master.
Thanks for working on this @jerqi !
Thanks for the reviews @cloud-fan, @LuciferYang, @advancedxy :-)

We can reduce the network IO with local shuffle. Could we use parameter for different kind of PartitionSpec ?
Like
      case PartialReducerPartitionSpec(_, startMapIndex, endMapIndex, _) =>
        if (!shuffleLocalityEnabled) return Nil
        tracker.getMapLocation(dependency, startMapIndex, endMapIndex)

      case PartialMapperPartitionSpec(mapIndex, _, _) =>
        if (!localShuffleLocalityEnabled) return Nil
        tracker.getMapLocation(dependency, mapIndex, mapIndex + 1)

      case CoalescedMapperPartitionSpec(startMapIndex, endMapIndex, numReducers) =>
        if (!localShuffleLocalityEnabled) return Nil
        tracker.getMapLocation(dependency, startMapIndex, endMapIndex)


 Both of these are deprecated and were deleted in v0.7.0 of controller-runtime:
https://github.com/kubernetes-sigs/controller-runtime/commit/a32b29d13265e87521ead29bed96d7fb44f57e1e#diff-c4abdec7bd505d8a03b365a244374fd9cde3fd5b69976d463896b3d1c171772d
https://github.com/kubernetes-sigs/controller-runtime/commit/34eb1151fa01429133100ea94a240344aaf96adc#diff-c4abdec7bd505d8a03b365a244374fd9cde3fd5b69976d463896b3d1c171772d
We should replace them with something else. This will allow us to either update the version of our controller-runtime dependency or get rid of it entirely.
Anything else you would like to add:
More context - https://github.com/kubeflow/kfserving/pull/1305#discussion_r559771345

/assign


Fix IAC scan all on subdirectories

Currently, tars have two ways to be created in GGShield:

For iac/sca scan diff, filepaths are listed using git ls-tree --full-name, which return filepaths relative to the git root
For iac/sca scan all, filepaths are listed using directory.rglob("*") (where directory is the argument passed to the command), then returned relative to the directory using path.relative_to(directory)
The difference comes from the necessity of listing files for a given git reference, for diff scans

However, the all behavior introduces two issues when calling the command with a Git subdirectory as argument:

File contents are not shown in the output, as the output handler looks for files relative to the git root, but is given filepaths relative to the subdir argument
Only the subdir is added to the tar sent to the API, preventing from linking existing incidents properly (as their paths are relative to the git root)

This PR solves this issue by using the git root for all scans too as the root directory.
If the scanned directory isn't a Git repository, the current behavior is maintained.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8eb47db) 91.96% compared to head (0a04808) 91.96%.
Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
- Coverage   91.96%   91.96%   -0.01%
==========================================
  Files         160      160
  Lines        6786     6792       +6
==========================================
+ Hits         6241     6246       +5
- Misses        545      546       +1

Flag
Coverage Δ

unittests
91.96% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

For SCA, after the fix, the output will show filepaths relative to the git repository root, instead of relative to the given directory. Is that a problem?


toolkit: add file content viewer

Description

Added viewer for imported files

AI Description

This PR introduces a new feature for retrieving files by ID, with a focus on agent and conversation files. The changes include:

Adding a new function, get_file, in src/backend/crud/file.py, which retrieves a file by ID. The function now accepts an optional user_id parameter, allowing for more flexible file retrieval.
Creating new classes, ConversationFileFull and AgentFileFull, in src/backend/schemas/file.py, to represent conversation and agent files with additional attributes like file_content.
Modifying the get_files_by_agent_id function in src/backend/services/file.py to return a list of file IDs instead of files. A new function, get_file_ids_by_agent_id, is introduced to retrieve file IDs associated with a specific agent ID.
Adding new routes in src/backend/routers/agent.py and src/backend/routers/conversation.py to handle file retrieval by ID for agents and conversations, respectively. These routes use the get_file function from the file_crud module.
Enhancing the src/interfaces/assistants_web/src/cohere-client/client.ts file by adding new methods, getConversationFile and getAgentFile, to retrieve conversation and agent files by ID.
Introducing new types, AgentFileFull and ConversationFileFull, in src/interfaces/assistants_web/src/cohere-client/generated/types.gen.ts, to represent conversation and agent files with additional attributes.
Adding new functions, getAgentFileV1AgentsAgentIdFilesFileIdGet and getFileV1ConversationsConversationIdFilesFileIdGet, in src/interfaces/assistants_web/src/cohere-client/generated/services.gen.ts, to retrieve agent and conversation files by ID.
Creating a new component, FileViewer, in src/interfaces/assistants_web/src/components/UI/FileViewer.tsx, to display file content.
Enhancing the ConversationPanel component in src/interfaces/assistants_web/src/components/Conversation/ConversationPanel.tsx to handle file viewing and deletion.
Adding a new hook, useFile, in src/interfaces/assistants_web/src/hooks/use-files.ts, to retrieve agent and conversation files by ID.
Introducing new tests in src/backend/tests/unit/routers/test_conversation.py to ensure the proper functioning of file retrieval by ID for conversations.

@danylo-boiko Always happy to see more contributions from you.Will review when bandwidth permits

All checks are good too, asked @malexw to take a look at the frontend part

@danylo-boiko On an aside - and perhaps this chat can happen in a different channel, but I've been collecting internal/external feedback on the toolkit and I'm open to any suggestions you might have to build out a future roadmap, mainly look at features/dev experience improvements

@tianjing-li I'd be happy to help with building a future roadmap.


NetworkHttp should use Network Routes and not Node Routes

This can be possible once all the possible string enum values have been defined.
nemtech/nem2-openapi#44

@fboucquez I guess we could close this issue due to the roll-back.


[HOLD] Update gRPC docs for 2.29.0

Should not be merged until 2.29.0 (non-preview) packages are on NuGet.
https://www.nuget.org/packages/Grpc.AspNetCore

Ok, all set. I'll merge when I see that the release packages have gone live.


perf(Dependencies): Bump itk.js to 12.0.1

This improves the median filter speed by 60%.
Updates:

readImageDICOMFileSeries no longer accepts a web worker as its first
argument (it now uses an internal worker pool).
We can reliably re-use the the web wokrer with runPipelineBrowser.
The itkfiltering module needs to be built with the 12.0.1 itk-js cli /
Docker image for the new module API.
The Webpack rule should also copy the itkfilterWasm.wasm file that is
generated.
regeneratorRuntime is configured for babel to build for async
functionality used in readImageDICOMFileSeries.

Thank you!!!

:tada: This PR is included in version 4.7.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Jupyter "MicroPython - Unix Port" kernel

Hi,
I am conducting MicroPython education at an university and we're using Jupyter "MicroPython - USB" kernel with pleasure in our education; thanks to everybody who make this excellent tool possible.
On the other hand, as we're doing some experiments also with MicroPython Unix Port,  we also need to use Unix Port.
A Unix Port implementation will be very useful not only for us also for the others.
Regards,

I have a two questions about this.

If you already have a CPython kernel running on Unix, what does the MicroPython version give you that is extra?  I have found them almost the same -- except the MicroPython has the libraries to access hard-ware specific things like Pins, I2C, etc.

Are you running the Jupyter system on the Unix system?  If so, then the MicroPython kernel would be running just like a regular kernel for all the other languages available as kernels.  (The thing that is unique about this MicroPython kernel is that it sends the code down a serial line instead of executing it on the same machine.)

Hi Julian,
What we do is, we make our initial teoratical work, system - software design and tests with Unix port and afterwards move the embedded python solution onto the embedded harware;

  Yes we already have Cpython kernel running on Unix however we prefer to work with MicroPython Unix Kernel because

a.       First, as you’ve guessed uPy kernel has something extra, on the other hand uPy doesn’t have something the Cpython have!
b.       Second, we’re modifying the uPy kernel according to our harware and application, adding our own modules removing unneccasy modules and with the MicroPython’s known methods and tools (like upip) of course. This is not same and easy with Cpython (may be but we don’t know, this is not our focus).
c.       Third, with this way we test and debug our solution as close as possible to the target embedded platform.
d.       Also I plan to use Cpython kernel as well to be able to run some tools like mathplotlib for analysis demonstration etc. Purpose.

  May be, yes, I couldn’t think of it. Do you know how can I activate MicroPython Unix Kernel in Jupyter on Ubuntu (Unix).

Thanks and best regards,
Murat
From: Julian Todd<EMAIL_ADDRESS>Sent: Friday, November 01, 2019 2:11 PM
To: goatchurchprime/jupyter_micropython_kernel<EMAIL_ADDRESS>Cc: Murat Tologlu<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [goatchurchprime/jupyter_micropython_kernel] Jupyter "MicroPython - Unix Port" kernel (#46)
I have a two questions about this.

 If you already have a CPython kernel running on Unix, what does the MicroPython version give you that is extra? I have found them almost the same -- except the MicroPython has the libraries to access hard-ware specific things like Pins, I2C, etc.

 Are you running the Jupyter system on the Unix system? If so, then the MicroPython kernel would be running just like a regular kernel for all the other languages available as kernels. (The thing that is unique about this MicroPython kernel is that it sends the code down a serial line instead of executing it on the same machine.)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/goatchurchprime/jupyter_micropython_kernel/issues/46?email_source=notifications&email_token=ABFOX2ZQLHLOUIDI455FZDTQRQMFRA5CNFSM4JGXSJP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC2YHEY#issuecomment-548766611, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABFOX2ZTUO3UWIQ66VZ5SOLQRQMFRANCNFSM4JGXSJPQ.

Have you got a version of MicroPython for Unix that you use?
When I tried it on my Ubuntu PC, it said to do:
[sudo] password for julian:
micropython 1.11 from Jiawei Huang (hjiawei) installed
$ micropython
MicroPython d06c5a9 on 2019-06-10; linux version
>>> help("modules")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'help' isn't defined
>>>

Apart from missing the help() function, it had almost none of the standard libraries (except for math and sys).
What install are you using?
This Unix install does not have the Ctrl-A raw-mode, which is what I use to paste the code into the MicroPython interpretor, because it doesn't echo every character as it types it in.  There might be a work-around for it, but I am not sure.
But surely ESP8266s are cheap enough that you don't need to economize.  They cost less than a cup of coffee, don't they?

Yes, I know the MicroPython Unix Port has some limitations and bugs; that's the reason why I want to use it for our initial experiments: it is close to the actual MicroPython-USB  running on our target embedded system. Of course the bugs such as missing help function and  Ctrl-A have to be resolved ( I will write issues ). On the other hand if I find a way to activate the uPy-Unix kernel in Jupyter just like any other kernel on Unix-Linux then there will be no need for a work here.

It looks like it is possible to run MicroPython directly from Jupyter Notebook with ipython magics (  https://ipython.readthedocs.io/en/stable/interactive/magics.html ) therefore I close my issue, thanks for the interest.


how to disable "Missing space before function parentheses."

I didn't see anything in the README about this. How can I adjust my xo settings so that it does not complain "Missing space before function parentheses" when I have function() instead of function ()?

You can override the rules section, as stated here.
Default rules here.
ESLint docs on configuring rules here.
{
  "xo": {
    "rules": {
       "rule-you-wish-to-disable": 0
    }
  }
}

The default reporter lists the rule name to the right of the message.

Does this mean Github is using XO @cheshire137? :D

Haha nah, this was on a personal JavaScript project of mine!

@cheshire137 fair enough :)


Bumped Laminar to 16.0.0 etc.

Seems to be working (compiling) as-is. See the changes here – I don't expect any of that to actually affect these bindings.
Also bumped Scala/Scala.js versions to match Laminar's requirements.

Thanks! Sorry, I was on vacation then on stuff!


Request for Documentation: Document supported ES versions.

Mattermost user george from https://community-daily.mattermost.com has requested the following be documented:
Great, thanks @george
I think we should not this down in the docs, if we have specific version which we tested compatibility for.

See the original post here.
This issue was generated from Mattermost using the Doc Up plugin.

The page were we should document it: https://docs.mattermost.com/deployment/elasticsearch.html


concat: Presto throws while Velox doesn't

Description
Query: select concat(c0) from (values '123') t(c0);
Presto-0.289: Throws an exception "There must be two or more concatenation arguments".
Velox: Returns a result '123'.
Error Reproduction
No response
Relevant logs
No response

Shouldnt this be rejected at the co-ordinator level ? Is there concat with one argument ? How does it even get to velox ?

Shouldnt this be rejected at the co-ordinator level ? Is there concat with one argument ? How does it even get to velox ?

@kgpai No, this query is not rejected by the Java coordinator. My guess is that the check is inside the concat function in Java, not the expr compiler.

https://github.com/facebookincubator/velox/pull/10625 will address this


catching featureGraphic

was camouflaged as twitter:image

Hi, Can I know your name?
Merged, Thank you. :+1:

Hi, Can I know your name?

Hi Max, it's Izzy. And thanks for merging! I took the freedom to meanwhile make a little "rewrite", which will come with the next PR. Looks cleaner then, and fetches even more :smiley:
Guess by asking for my name you meant to know who I am? See e.g. here and here (both are my sites) – and here. I'm mostly known as "Izzy" or "IzzyOnDroid" (the latter in connection with the sites mentioned).


TypeError : Resnet : init() got an unexpected keyword argument 'init_cfg'

Greetings,
I am currently using qdtrack in python 3.8, Cuda 11 based environment for RTX 3090 GPU. While training as well as testing, I am getting this error.
All required datasets in required locations have been downloaded and maintained.
Any help would be appreciated.

We develop this codebase based on mmcv 2.14.0 and mmdet 1.3.10, please update the version of your mmcv.

I tried installing using pip install mmcv-full=1.3.10 but I get an error saying that such a version does not exist. @OceanPang

Hi Aman, I got the same issue. I was wondering did you solve it?

We develop this codebase based on mmcv 2.14.0 and mmdet 1.3.10, please update the version of your mmcv.
Hi Ocean, could you please guide me to solve it. Much appreciated!

@AmanGoyal99 , @Xiaofei-Kevin-Yang  This command can be used as the reference:
pip install mmcv-full==1.3.10 -f https://download.openmmlab.com/mmcv/dist/cu102/torch1.7.0/index.html


chart/otomi default values.yaml are outdated.

Describe the bug:
default values.yaml file in otomi chart are not correct.
Expected behavior:
The default values.yaml should conform with the values-schema.yaml

Can you please add only the minimal values there now? Just ask Sander if you don't know what that is, but there should be a script that generates those, right? Or did that not materialize? Probably not, so manually then for now

just updated in master