[Feature] Support alarm template configurable

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
In multiple environments, it is difficult to directly distinguish the alarm email information from which environment. It is important to support the customization of templates,
Usage Scenario
The alarm template is mentioned in the configuration file
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

good feature, I'm looking forward to it


Added auth info cache with notifiations to redis.

Problem
Current cache doesn't support any updates from the cplane.
Summary of changes

Added redis notifier listner.
Added cache which can be invalidated with the notifier. If the notifier is not available, it's just a normal ttl cache.
Updated cplane api.

The motivation behind this organization of the data is the following:

In the Neon data model there are projects. Projects could have multiple branches and each branch could have more than one endpoint.
Also there is one special main branch.
Password reset works per branch.
Allowed IPs are the same for every branch in the project (except, maybe, the main one).
The main branch can be changed to the other branch.
The endpoint can be moved between branches.

Every event described above requires some special processing on the porxy (or cplane) side.
The idea of invalidating for the project is that whenever one of the events above is happening with the project, proxy can invalidate all entries for the entire project.
This approach also requires some additional API change (returning project_id inside the auth info).
Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

What do you think about not using the GC for now? We can enable it later if necessary but I'm wonder whether it will really use that much memory if we just accumulate everything.

What do you think about not using the GC for now? We can enable it later if necessary but I'm wonder whether it will really use that much memory if we just accumulate everything.

Sure, I just added flag to configure gc interval.


Submit swapsway error

This is have error when I submit request Give me ETH

I have the same issue

I have a similar error too. After launching the app, I'm prompted to request for testnet ETH which fails (it doesn't even ask for address).

I am recieving this : Invalid faucet response: {"error":"captcha failed"} after requesting faucet funds

We are looking into it


resovle instead of resolve

Hi guys thanks for the free version. is there any specific reason in router folder -> index.js @ line 22 && 24 is resovle instead of resolve
/**
 * Vue Router
 *
 * @library
 *
 * https://router.vuejs.org/en/
 */

// Lib imports
import Vue from 'vue'
import VueAnalytics from 'vue-analytics'
import Router from 'vue-router'
import Meta from 'vue-meta'

// Routes
import paths from './paths'

function route (path, view, name) {
  return {
    name: name || view,
    path,
    component: (resolve) => import(  //SHOULDNT BE  resolve ?
<EMAIL_ADDRESS>    ).then(resovle)
  }
}

Vue.use(Router)

// Create a new router
const router = new Router({
  mode: 'history',
  routes: paths.map(path => route(path.path, path.view, path.name)).concat([
    { path: '*', redirect: '/dashboard' }
  ]),
  scrollBehavior (to, from, savedPosition) {
    if (savedPosition) {
      return savedPosition
    }
    if (to.hash) {
      return { selector: to.hash }
    }
    return { x: 0, y: 0 }
  }
})

Vue.use(Meta)

// Bootstrap Analytics
// Set in .env
// https://github.com/MatteoGabriele/vue-analytics
if (process.env.GOOGLE_ANALYTICS) {
  Vue.use(VueAnalytics, {
    id: process.env.GOOGLE_ANALYTICS,
    router,
    autoTracking: {
      page: process.env.NODE_ENV !== 'development'
    }
  })
}

export default router

Probably a typo
https://github.com/creativetimofficial/vuetify-material-dashboard/pull/5

Closing as resolved.


Updated Linting

This PR addresses "Update Linting" part of #8121.

I have updated to the latest version of stylelint-config-wagtail.
I have added necessary stylelint rules where we want to retain uppercasing.

Any fix for this conflict?

It looks like the ci failed when trying to use Airbnb
[frontend20199](https://app.circleci.com/pipelines/github/wagtail/wagtail/6700/workflows/8a68600b-2369-41c1-b025-c213fbd3f15c/jobs/20199/parallel-runs/0)
    npm run lint:js

0s

#!/bin/bash -eo pipefail
npm run lint:js

><EMAIL_ADDRESS>lint:js
> eslint --ext .js,.ts,.tsx --report-unused-disable-directives .

Oops! Something went wrong! :(

ESLint: 8.8.0

ESLint couldn't find the config "airbnb" to extend from. Please check that the name of the config is correct.

The config "airbnb" was referenced from the config file in<EMAIL_ADDRESS>
If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

Exited with code exit status 2

CircleCI received exit code 2

https://app.circleci.com/pipelines/github/wagtail/wagtail/6700/workflows/8a68600b-2369-41c1-b025-c213fbd3f15c/jobs/20199/parallel-runs/0/steps/0-107

Change in package.lock.json must be the reason for it. How to fix this?

What version of Node were you running locally? @PaarthAgarwal check that you used node 16 maybe.
We are using node 16 in this project and that can be the cause of some odd package lock file differences compared to node 14.

Our documentation at the latest (not stable) indicates node 16.
https://docs.wagtail.org/en/latest/contributing/developing.html#setting-up-the-wagtail-codebase
This may have caused some confusion

@lb- you are right. I was using node 14. that was causing the error.
I have resolved the conflicts.
The text-transform conflicts will be resolved when you will merge #8129. I'll rebase this branch then.

looking good @PaarthAgarwal - I reworked your commits and fixed a small linting issue, ran the code locally and new update works great.
Thanks again!
Awesome!🔥


conflicting packages

I'm a new user to nixos and thx to your repo I am easily able to use rime-double-pinyin and rime-ice!
Well, more precisely, any one of them, but not simultaneous. Errors like:
         /nix/store/1193ji55d4raiq2jlcjabdn9hg8ksc7j-rime-double-pinyin-69bf85d4dfe8bac139c36abbd68d530b8b6622ea/share/rime-data/double_pinyin.schema.yaml
         /nix/store/pwyblyypwsy2grg5y893b8lbv94msy01-rime-ice-ab648212584a5e54bf72583ba729e9d82c7f4888/share/rime-data/double_pinyin.schema.yaml
error: builder for '/nix/store/n79pz6...-user-environment.drv' failed with exit code 1;

Maybe instead of static files, computed file generated according to profile should be implemented?
（不过看上去有点复杂，我自己写的cmdstorm项目就碰到了诸如此类的问题于是停滞了）

It seems that the rime-ice AUR package solves this issue by spliting different schemas of rime-ice into different packages.

That seems a, not that satisfying, solution.
When I used arch, the rime-ice-git package enabled the word lib(globally), and the double-pinyin-flypy package didn't configure anything, for which I had to write default.custom.yaml by myself. Typically users in arch doesn't have nix-env so necessarily get hands dirty.
Is it possible to compute schema based on chosen pkgs? should be possible I guess? create a common dependency which changes according to profile?

That seems a, not that satisfying, solution. When I used arch, the rime-ice-git package enabled the word lib(globally), and the double-pinyin-flypy package didn't configure anything, for which I had to write default.custom.yaml by myself. Typically users in arch doesn't have nix-env so necessarily get hands dirty.
Is it possible to compute schema based on chosen pkgs? should be possible I guess? create a common dependency which changes according to profile? Sorry but, what does multiple outputs mean?

The issue is not related to compile. It happens simply because https://github.com/iDvel/rime-ice and https://github.com/rime/rime-double-pinyin both provide double_pinyin.schema.yaml.
Multiple outputs mean that nix derivation can have multiple output paths.
For example, we can place double_pinyin.schema.yaml and its compiled files into another output path, so that users can choose which schemas to include.

Like stopping double-pinyin from automatically install schema, but tell user to manually configure yaml instead?
Not sure if it's a good idea, maybe worth a try?
Actually I didn't say anthing about compile. I mean, there can be a schema.drv which computes and generates the schema file according to <rime-*> env vars(which shamefully makes it not supposedly pure)

I just added a schemaRegex option to rime-ice in https://github.com/linyinfeng/nur-packages/pull/667, which allows users to choose which schemas of rime-ice to include.
If you want to use https://github.com/rime/rime-double-pinyin and https://github.com/iDvel/rime-ice simultaneously, you may use this option like this:
rimeDataPkgs = with THIS_REPO.rimePackages; withRimeDeps [
  (rime-ice.override {
    schemaRegex = "^rime_ice$";
  })
  rime-double-pinyin
];

Thanks!Unfortunately I'm quite new to nix. I've tried to replace THIS_REPO with nur.repos.linyinfeng and put the block in ~/.config/nix/nix.conf or ~/.config/nixpkgs/conf.nix, and both failed.An hour's searching and reading didn't help me out. Seems getting needed info of nix is never easy. I really don't want to bother but could you please tell me how to apply that?Envoyé depuis mon téléphone Huawei-------- Message original --------De : Lin Yinfeng @.>Date : ven. 19 avr. 2024 à 19:50À : linyinfeng/nur-packages @.>Cc : AmourAmer @.>, Author @.>Objet : Re: [linyinfeng/nur-packages] conflicting packages (Issue #635)
I just added a schemaRegex option to rime-ice in #667, which allows users to choose which schemas of rime-ice to include.
If you want to use https://github.com/rime/rime-double-pinyin and https://github.com/iDvel/rime-ice simultaneously, you may use this option like this:
rimeDataPkgs = with THIS_REPO.rimePackages; withRimeDeps [
(rime-ice.override {
schemaRegex = "^rime_ice$";
})
rime-double-pinyin
];
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

~/.config/nix/nix.conf

I'm confused... To use the rime packages in this repository, the expected nixos configuration should be like this:
{ pkgs, ... }:
{
  # nixos configuration
  i18n.inputMethod = {
    enabled = "ibus"/"fcitx5";
    # for ibus
    ibus.engines = with pkgs.ibus-engines; [
      (rime.override {
        rimeDataPkgs = with pkgs.nur.repos.linyinfeng.rimePackages; withRimeDeps [
          rime-ice
          ...
        ];
      })
    ];
    # for fcitx5
    fcitx5.addons = with pkgs; [
      (fcitx5-rime.override {
        rimeDataPkgs = with pkgs.nur.repos.linyinfeng.rimePackages; withRimeDeps [
          rime-ice
          ...
        ];
      })
    ];
  };
}

If you install these packages with nix-env or nix-profile, they have no effect.

librime only works with three directories:
user_data_dir    ~/.config/ibus/rime
shared_data_dir  /usr/share/rime-data
staging_dir      ~/.config/ibus/rime/build

The rimeDataPkgs argument of ibus-engines.rime and fcitx5-rime sets the shared_data_dir to a customized rime data package.
That's why installing these packages using other methods has no effect.

Thanks for that! At least something has changed, it's just, seems to be some font issue and I need to further debug
Before that, may I confirm that if my conf is like this:
https://github.com/AmourAmer/debug/tree/ac7db96
all yamls in fcitx5/rime/ included
When I input "luoxiayuguwuqifei", it should be 落霞与孤鹜齐飞 对吧？
以及输入 feiji 的时候应该会有个选项是✈？但是都没有，我在arch上的时候只需要安装rime-ice-git包这些就都有了，我是还需要手动改什么文件么？

Thanks for that! At least something has changed, it's just, seems to be some font issue and I need to further debug Before that, may I confirm that if my conf is like this: https://github.com/AmourAmer/debug/tree/ac7db96 all yamls in fcitx5/rime/ included When I input "luoxiayuguwuqifei", it should be 落霞与孤鹜齐飞 对吧？ 以及输入 feiji 的时候应该会有个选项是✈？但是都没有，我在arch上的时候只需要安装rime-ice-git包这些就都有了，我是还需要手动改什么文件么？

No, fcitx5-rime should work out-of-box.
{
  inputs.nixpkgs.url = "github:nixos/nixpkgs/nixos-unstable";
  outputs = { self, nixpkgs }: {
    nixosConfigurations.test = nixpkgs.lib.nixosSystem {
      modules = [
        ({ config, pkgs, ... }: {
          users.users.test = {
            isNormalUser = true;
            password = "12345678";
          };
          services.xserver.enable = true;
          services.displayManager.sddm.enable = true;
          services.xserver.desktopManager.plasma5.enable = true;
          i18n.inputMethod = {
            enabled = "fcitx5";
            fcitx5.addons = with pkgs; [ fcitx5-rime ];
          };
          nixpkgs.hostPlatform = { system = "x86_64-linux"; };
          system.stateVersion = "24.05";
        })
      ];
    };
  };
}

nix run .#nixosConfigurations.test.config.system.build.vm -- -m 4G

And to enable rime-ice you should follow the instructions described in https://github.com/iDvel/rime-ice?tab=readme-ov-file#arch-linux.
# flake.nix
{
  inputs = {
    nixpkgs.url = "github:nixos/nixpkgs/nixos-unstable";
    nur.url = "github:nix-community/nur";
  };
  outputs = { self, nixpkgs, nur }: {
    nixosConfigurations.test = nixpkgs.lib.nixosSystem {
      modules = [
        nur.nixosModules.nur
        ({ config, pkgs, ... }: {
          users.users.test = {
            isNormalUser = true;
            password = "12345678";
          };
          services.xserver.enable = true;
          services.displayManager.sddm.enable = true;
          services.xserver.desktopManager.plasma5.enable = true;
          i18n.inputMethod = {
            enabled = "fcitx5";
            fcitx5.addons = with pkgs;
              [
                (fcitx5-rime.override {
                  rimeDataPkgs = with config.nur.repos.linyinfeng.rimePackages;
                    withRimeDeps [
                      (rime-ice.override { schemaRegex = "^rime_ice$"; })
                      rime-double-pinyin
                    ];
                })
              ];
          };
          nixpkgs.hostPlatform = { system = "x86_64-linux"; };
          system.stateVersion = "24.05";
        })
      ];
    };
  };
}

# default.custom.yaml
patch:
  __include: rime_ice_suggestion:/
  schema_list/+:
    - schema: double_pinyin

nix run .#nixosConfigurations.test.config.system.build.vm -- -m 4G

It does solve the installation conflict. However, it behaves weird.
Here's what I got with double_pinyin_flypy/luna pinyin and rime-ice on/off. The only normal line is input with luna pinyin and rime-ice:

Similarly double_pinyin behaves.
Maybe I can try to help? As I want to install fcitx-sogou for my friend. But I can't even know how to run NUR repo like yours locally. Can you help a bit, plz? Nix does have very bad documentation.
Here're some relevant links:

use sougou pinyin on ubuntu
AUR's fcitx-sogou

Maybe this should another issue?


Remove cross-project references in Kotlin DSL integration test project

The logic is no longer necessary. Depending on the ':kotlin-dsl-plugins' project to have the Jar with 'future-plugin-versions.properties' on the test runner classpath is sufficient.

@bot-gradle test QF

OK, I've already triggered QuickFeedback build for you.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test QF

OK, I've already cancelled the old build and triggered a new QuickFeedback build for you.


Updated OpenAPI definitions for new endpoints

@elmiko thanks. OpenAPI and server responses updated as per review. Request type detection changed.


Release artifacts for release v1.0.19

Description of changes:
Add Adoption by Annotation feature gate
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/retest

/retest


fix: skip injecting react refresh in production mode

This fixes a bug that I noticed in my original implementation in #4 where the react refresh preamble gets injected erroneously in production mode.
ViteReactRefresh has been updated to only inject the react refresh preamble in the development mode otherwise it will inject an empty string.

Hi!
Sorry for the late reply, I've been dealing with a nasty flu in the last month.
I'll get to this issue, review and merge your PR by next friday at latest!


"this._data[rowID].position" becomes undefined when using ES6

I copied your example and changed it into ES6 and it went wrong when I tried to do this._GiftedMessenger.setMessageStatus('ErrorButton', rowID);. It said undefined is not an object(evaluating'this._data[rowID].position').
(I have already bind this using =>)

API changed in 0.1.0. Please see https://github.com/FaridSafi/react-native-gifted-messenger/blob/master/GiftedMessengerExample/GiftedMessengerContainer.js#L134


fix: Grammar and Punctuation Corrections in Aztec Documentation

This Pull Request addresses several grammatical and punctuation errors identified in the Aztec documentation. Specific updates include corrections to certain words and phrases for better adherence to standard writing and grammar rules.
Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

Hi. We've recently decided on a policy that we will not be merging trivial PRs unless someone has done a significant contribution already. Really sorry. The recent usage of Github commits as a metric means we have to manage this a bit.
We will get changes in, just not through direct merges. However I don't think we'll merge all these changes, some are a bit opinionated.


Remove regex_filter_property.hpp from the moc lines.

Since it has no SLOTS or SIGNALS, we don't need to run MOC on it.  That will both speed up the compilation and remove a warning when building.
@ahcorde FYI

Linux
Linux-aarch64
Windows


1.0.1 update blocked by Apple review

Some bug showing a white screen on sign in on iPad 👎

@rnystrom  can you share any more info on device/os or steps to reproduce?

Launch the app connected to the internet
Tap Sign in with GitHub
App loads a blank white screen

I've tried reproducing and can't. Submitting an appeal.

I got a similar rejects before. At that time, they mentioned IPv6 supports issues too.  Ask them to try launching the app again.

They fixed it, should be available soon


No obvious way to navigate to workspace when logged in

When you have been logged in and you are back at the homepage the login and register buttons are missing. But there is no obvious way to navigate to workspace.
How to reproduce:

Log in at prod-preview.openshift.io
Open prod-preview.openshift.io

Solution:
Add Button "Go to home dashboard" with a link to https://prod-preview.openshift.io/_home

Currently, that is what the 'Home' link in the navigation is for. Clicking that should bring you to /_home.

ack. but that navigation is not recognisable to the user. especially since there where big buttons at that blank space before. as a user you are searching for them.

Easy enough to update. I'll put together a rough image and add it here for review.

This design was intentional, @catrobson can you please comment.

@mindreeper2420 - Can we just check if they are logged in and always redirect openshift.io to openshift.io/home if they are?  I think we don't want people to see this page if they are logged in.

When you log in you get auto-redirected. Not sure that disabling all access
to this page when you specifically request is a good idea. I think a better
approach is to have a CTA that sends you to _home.
On 13 April 2017 at 18:50, catrobson<EMAIL_ADDRESS>wrote:

@mindreeper2420 https://github.com/mindreeper2420 - Can we just check
if they are logged in and always redirect openshift.io to
openshift.io/home if they are? I think we don't want people to see this
page if they are logged in.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fabric8io/fabric8-ui/issues/726#issuecomment-293973698,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJoQX3r_ZtsBWRRXNZpa2rfPzNxBPYjks5rvmB-gaJpZM4M8mUj
.

--
Pete Muir
Technical Director, Red Hat Developer

@pmuir Why would you need to see the marketing page if you are a user?  If you look at many websites that have extensive applications behind them, the only way you can get back to their marketing page is by logging out - otherwise you only will ever see your homepage.

Yes, and I find that a very frustrating experience ;-) If I navigate somewhere, I want to see the page there, not be redirected.

@pmuir @catrobson what about changing the navigation on the marketing page if a user is already logged in? We already do that by adding the 'Home' link (hidden if a user is not logged in), so it would be simple to do that again. This would be similar to a variety of sites in how they show completely different navigation on the same page, depending on whether a user is logged in or not.

That works for me.
On 14 April 2017 at 14:24, Adam Jolicoeur<EMAIL_ADDRESS>wrote:

@pmuir https://github.com/pmuir @catrobson
https://github.com/catrobson what about changing the navigation on the
marketing page if a user is already logged in? We already do that by adding
the 'Home' link (hidden if a user is not logged in), so it would be simple
to do that again. This would be similar to a variety of sites in how they
show completely different navigation on the same page, depending on whether
a user is logged in or not.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fabric8io/fabric8-ui/issues/726#issuecomment-294152892,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJoQXXdPe5e3muRh1dDBs5_L0yvvddJks5rv3N-gaJpZM4M8mUj
.

--
Pete Muir
Technical Director, Red Hat Developer

@mindreeper2420 so how do you get to the landing/marketing page if you are logged in? Just go to the base URL? Should you also be redirected to Home during login but that is the only time you get redirected?

Quick wireframe of Logged Out vs Logged In
https://redhat.invisionapp.com/share/SGBBGSAZA#/229218879_Navigation_Options

@mindreeper2420 That works for me. But the question of flow hasn't been answered. Currently the user is redirected to Home if they are logged in. Can you and @catrobson work out the flow of how to get to this page while logged in?

@catrobson has this been worked out? Should we close this issue?

cc @maxandersen

I don't think this has been resolved.  I still go to the marketing homepage when I am logged in and type https://openshift.io into my browser.  Expected behavior:  skip marketing home page and bring me right into the account homepage (https://openshift.io/_home).

OK, closing this. When new designs and user flows are done we can make a new issue.

:tada: This issue has been resolved in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add China Partition and Failover Regions and Option to ignore role arn in okta-aws file

Have gov partition but did not include china partition so I added in china. I also modifed sts default to us-east-1 (which is default for sts without specifying a region) and if sts fails, it will try again in secondary region. This is to help obtain credentials even if Amazon is having api errors/issues in a particular region

I just realized that the -r option performs pretty much what this -s option does. The only addition -s does is not write it into the file. I would hope that @jmhale can incorporate everything else but that. I can always create a new push request if not


Fix folder output when processing multiple files

Fix for #343. The main issue was the array was not flattened which meant output paths when processing a directory ended up looking like mypath/dir1,dir2,fiename.json. Adding flat() fixes this.
Pull request:

also bumps version as the is currently does not match the npm version number
adds tests for the directory processing
adds an additional sld file to test processing multiple files
adds a note the the ReadMe

:tada: This PR is included in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Cannot render manual set html content as pdf correctly (SetContentAsync)

Before you file a bug, have you:

[x] Tried upgrading to newest version of PuppeteerSharp, to see if your issue has already been resolved and released?
[x] Checked existing open and closed issues, to see if the issue has already been reported?
[x] Tried reproducing your problem in a new isolated project?
[x] Considered if this is a general question and not a bug?. For general questions please use StackOverflow.

Description
When SetContentAsync(string html) is called, the content will be set correctly, but there is no way to detect/wait for something like "document ready". When i run the snippet below, i have the following results:

Breakpoint at PdfDataAsync, wait 1-2s, continue -> The expected and pixel perfect PDF
Breakpoint after PdfDataAsync or no breakpoint at all -> An empty/white PDF
Attaching event handler on Load Event and await those event to fire -> Partial rendered PDF

Complete minimal example reproducing the issue
// Arrange
var options = new LaunchOptions { Headless = true };
var browser = await Puppeteer.LaunchAsync(options, BrowserFetcher.DefaultRevision);

var html = System.IO.File.ReadAllText(@"C:\invoice.html");
var page = browser.NewPageAsync();
var pageLoadFired = new TaskCompletionSource<bool>();

page.Load += (sender, args) =>
{
    Console.WriteLine("Loaded");
    pageLoadFired .SetResult(true);
};

// Act
await page.SetContentAsync(html);
// await pageLoadFired.Task; // uncomment this, for test case 3

var data = await page.PdfDataAsync(new PdfOptions
{
    Format = PaperFormat.A4,
    PrintBackground = true,
    MarginOptions = new MarginOptions
    {
        Left = "1cm",
        Right = "1cm",
        Top = "1.5cm",
        Bottom = "1.5cm"
    }
});

// Assert
Assert.Equal(41564, data.Length); // 1. 877 Bytes -- 2.

// Result Case #1 - Breakpoint, wait 1-2s before RenderData = 41564 bytes - perfect!
// Result Case #2 - Breakpoint after RenderData or no BP at all = 877 bytes - white/empty page
// Result Case #3 - Uncomment and await pageLoadFired.Task = 5823 bytes - partial loaded/rendered

Expected behavior:
Either the await of SetContentAsync completes when everything is "finished" and ready to "render" or anything else, or some way to wait for the document to be ready. Something like jQuerys $(document).ready(...). The best i found was the "Load" EventHandler no "Ready" EventHandler or something like that.
Actual behavior:
No way to wait and ensure the document loading process to be finished. Its only possible by wait an random/high amount of time and hope the time/delay was long enought (await Task.Delay(5000)).
If the Network Request in the HTML file requires more than the 5000ms because of network load etc., it will be rendered wrong again.
Versions

Which version of PuppeteerSharp are you using? Latest, 1.6.2
Which .NET runtime and version are you targeting? E.g. .NET framework 4.6.1 or .NET Core 2.0. Latest, .NET Core 2.1.4 (Runtime) and 2.1.402 (SDK)

Additional Information
My example was created in a fresh and clean/new webapi project (dotnet new webapi).
I attached the source HTML file and some screenshots of the results.
Am i missing something or is this an behavior that should/can be improved?
I have also tried to solve the issue with WaitForNavigateAsync with many combinations of events, before and after SetContentAsync and also with Task.WhenAll etc. But WaitForNavigate results in timeouts because no navigation is happening at all (due to SetContent and not GoTo).
Thanks!!
Source of the input
invoice.html
Screenshots of all three cases (PDF Results)
Output Case 1
Output Case 2
Output Case 3

@essmd could you try waiting for any element in that HTML?
e.g.
await Page.WaitForSelectorAsync("DIV")

or
await Page.WaitForSelectorAsync(".some-class-your-are-injecting")

What the hell yes! I have not tried WaitForSelectorAsync because i thought it will only give me ElementHandles for my selector, and yes, since DOMDocumentReady fired, and even the Load-Event, it will find the Element...
But yes, its just working fine! Event the @font-face: src(...) requests will finishe before the Task completes. Thats amazing!
No i dont like it to query for something in the HTML, because i can not garantuee its always the same. So i tried to query for "body" which should be available always. And yes again, it works!!
Maybe this should be mentioned somewhere in the docs/readme? Just a note / hint or something? I think most people are using GoTo(..) which works fine, but SetContent - this would be a massive time saver.
Thank you for the solution and sorry for the "non issue". I gave my best to not open this issue but i thought i tried everything ... thanks!!
Working Code:
await page.SetContentAsync(html);
await page.WaitForSelectorAsync("body");

var buffer = await page.PdfDataAsync(new PdfOptions { ... });

Could you try adding this?
await Page.WaitForNavigationAsync(new NavigationOptions { WaitUntil = new[] { WaitUntilNavigation.Networkidle0 } });

Consider navigation to be finished when there are no more than 2 network connections for at least 500ms

I already tried, this (it was my first attempt) because it is exactly what i want to achive.
The thing is, it results in an timeout (there is an configurable option for an timeout after 30s). Timeout occurs because there never happens an navigation (which does when calling GoToUrl -> where it works!).
No navigation -> waiting forever.
I think  this is an issue / missing feature in the puppeteer "core" ?
Thanks for the support and help! Cheers!

I've run into the same issue and the workaround I've found is to inject code into the html to set a flag when the page is loaded. It's not pretty, but it works for now. If I have some time, I'll look to implement a proper page.WaitForPageLoadedAsync()
I've added the following into my html:
<script>window.onload  = function() { window.IsPageLoaded= true; };</script>
And then in my C# code I have:
await page.WaitForExpressionAsync("window.IsPageLoaded");

How about WaitUntilNavigation.Load?
https://github.com/kblok/puppeteer-sharp/blob/master/lib/PuppeteerSharp/WaitUntilNavigation.cs#L11

I have the same problem. Adding WaitUntilNavigation.Load increases the processing time by at least 30 seconds in my project, which is odd since, if I save the html I'm generating to a flatfile and open that in Chrome, it takes half a second to finish loading.

Closing this issue. @essmd feel free to reopen it if you think there is something to be done here.

I've had this issue too.
The workaround of @LamboJ fixes it, it feels quite hacky though ..

@LamboJ 's fix worked for me too. Thanks a lot.

I've run into the same issue and the workaround I've found is to inject code into the html to set a flag when the page is loaded. It's not pretty, but it works for now. If I have some time, I'll look to implement a proper page.WaitForPageLoadedAsync()
I've added the following into my html:
<script>window.onload = function() { window.IsPageLoaded= true; };</script>
And then in my C# code I have:
await page.WaitForExpressionAsync("window.IsPageLoaded");

Thanks a lot @LamboJ


feat(ts-types): 283 add type(number) in StylePropertyFunctionArg/data…

…Value

[中文版模板 / Chinese template]
🤔 This is a ...

[ ] New feature
[ ] Bug fix
[x] TypeScript definition update
[ ] Bundle size optimization
[ ] Performance optimization
[ ] Enhancement feature
[ ] Refactoring
[ ] Update dependency
[ ] Code style optimization
[ ] Test Case
[ ] Branch merge
[ ] Site / documentation update
[ ] Demo update
[ ] Workflow
[ ] Chore
[ ] Release
[ ] Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language
Changelog

🇺🇸 English

🇨🇳 Chinese

☑ Self-Check before Merge
⚠ Please check all items below before requesting a reviewing. ⚠

[ ] Doc is updated/provided or not needed
[ ] Demo is updated/provided or not needed
[ ] TypeScript definition is updated/provided or not needed
[ ] Changelog is provided or not needed

🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough

close #283


Consume generated jsapi types

Waiting on a core release, as the actions are not published nightly.

Ticket for nightly types https://github.com/deephaven/deephaven-core/issues/5150

Waiting on core to actually publish types, will need another patch version bump.


FR: autologon

Feature Request:
Command for autologon ssh credentials in integrated console

Configure password not work, need to manually enter password to log on. The reason is the keyword password as " Password : ", please make sure to modify

@ekopei ?. Sorry , I don't understand what you mean.


Blind 75

@Abiji-2020 As you are familier with the guidelines no need to mention pull request number as opened. You can direclty mention the number itself from the next pull request

@Abiji-2020 As you are familier with the guidelines no need to mention pull request number as opened. You can direclty mention the number itself from the next pull request

okok 🫡


Adds CURLOPT_INTERFACE configuration binding.

Hello? Excuse me, could you see it? Please, let me know what you think. Thank you.

i was thinking about this and will perhaps, instead, provide a 'more_curl_options' config that any other flags can be added into


The help text on the "--prefix" parameter for "mugc.py" is misleading/wrong.

https://github.com/capitalone/cloud-custodian/blob/4864a70e4f790817b199c576c2cf9e42724fec39/tools/ops/mugc.py#L123
Looks like a typo and its been accidentally copied from the "--profile" argument. The "--prefix" argument should be documented that its the function prefix to look for when conducting the garbage collection. I have a custom prefix for my functions and it took me a while to work out why mugc.py was not doing the clean-up.

See https://github.com/capitalone/cloud-custodian/pull/3116


Appstudio update test-component-pac-bqel

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-bqel-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
20 seconds
clone-repository

✅ Succeeded
42 seconds
build-container

✅ Succeeded
21 seconds
inspect-image

✅ Succeeded
14 seconds
deprecated-base-image-check

✅ Succeeded
17 seconds
clair-scan

✅ Succeeded
16 seconds
sbom-json-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
17 seconds
label-check

✅ Succeeded
8 seconds
show-summary

✅ Succeeded
9 seconds
show-sbom


--check should work on paths

Operating system: Win 10 x86
Python version: 3.6.5 64 bit
Black version: 18.4a2
Does also happen on master: Throws this backtrace instead:
Traceback (most recent call last):
  File "C:\Users\nikolaus.waxweiler\AppData\Local\Python\Python36\Scripts\black-script.py", line 11, in <module>
    load_entry_point('black==18.4a2', 'console_scripts', 'black')()
  File "C:\Users\nikolaus.waxweiler\AppData\Local\Python\Python36\site-packages\click\core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "C:\Users\nikolaus.waxweiler\AppData\Local\Python\Python36\site-packages\click\core.py", line 697, in main
    rv = self.invoke(ctx)
  File "C:\Users\nikolaus.waxweiler\AppData\Local\Python\Python36\site-packages\click\core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "C:\Users\nikolaus.waxweiler\AppData\Local\Python\Python36\site-packages\click\core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "C:\Users\nikolaus.waxweiler\AppData\Local\Python\Python36\site-packages\click\decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "C:\Users\nikolaus.waxweiler\AppData\Local\Python\Python36\site-packages\black.py", line 211, in main
    sources, line_length, write_back, fast, quiet, loop, executor
  File "c:\program files\python36\lib\asyncio\base_events.py", line 468, in run_until_complete
    return future.result()
  File "C:\Users\nikolaus.waxweiler\AppData\Local\Python\Python36\site-packages\black.py", line 296, in schedule_formatting
    loop.add_signal_handler(signal.SIGINT, cancel, _task_values)
  File "c:\program files\python36\lib\asyncio\events.py", line 499, in add_signal_handler
    raise NotImplementedError
NotImplementedError

Running black . works fine, but black --check . returns the error code 1 instead. It should search for ./**/*.py and check everything. Reason: I'd like to write
[testenv:black]
deps = black
commands = black --check .

in my tox.ini and not worry about exact paths, wildcards, etc.

Oops. This used to work, it's a regression. Will fix!

Hm, wait. There are two problems here. First: the NotImplementedError is a Windows-specific error that needs fixing. (apparently on Windows there are no signal handlers or something?)
On 18.4a2, the documentation for black --check . says it returns 1 if there are any changes in your directory. Are there any changes in your files? Why would it return 1 otherwise? Can you show your output of black --check .?

@zsol, you're a Windows user, it would be great if you could find a solution for the NotImplementedError.

I ran black . before the check and on all files individually just to be
sure. There is no output.

Does the output of --check give you only "good job" messages?

I don't think there's a great way to do the same kind of clean shutdown on Windows as those signal handlers let us do on other OSes, so IMO our best bet here is just to gate adding those signal handlers on OSes that have proper POSIX signals

@madig are you by any chance running black --check on an empty directory? :) That's the only way I can get black to produce no output

Nope, files exist 😕 as said, black . works fine. Just black --check . always retuns a 1 and no output.

@zsol, can you reproduce the lack of stderr output on Windows? AFAIK the "stderr" concept exists on Windows and should work just fine. I'm even using Click's echo to ensure colors are properly translated, and so on.
The lack of output here is likely what makes this hard for us to debug. Well, that, and me not having access to any Windows boxes.

Yep, I just managed to reproduce. Not sure what's going on, I'll have some time to dig tomorrow. Here are a couple of examples:
> black --version
black, version 18.4a2
> black --check .\black.py
black.py already well formatted, good job.
> black --check .\black.py .\tests\test_black.py
> black --check -l 80 .\black.py
would reformat black.py
> black --check -l 80 .\black.py .\tests\test_black.py
> black --check .
> black -l 80 .\black.py .\tests\test_black.py

Sounds like there's something wrong around how we schedule formatting of multiple files using asyncio.

Sounds like there's something wrong around how we schedule formatting of multiple files using asyncio.

This sounds Windows-specific.

OK, this is Windows-specific. We need to switch to use the ProactorEventLoop. See: https://docs.python.org/3/library/asyncio-eventloops.html#windows

We use AppVeyor, too :) https://packaging.python.org/guides/supporting-windows-using-appveyor/

The issue in 18.4a2 was the same NotImplementedError, but it was never output before https://github.com/ambv/black/commit/15d5e36ea38988084584639b02aafcaaa2744dcf for reasons I don't fully understand. AFAICT the same exception is being thrown before and after that commit, the only difference is one extra level of function call.

TLDR: this is fixed entirely by #156

Confirmed to work, thanks!


change URLencoding method to use %20 instead of + for spaces?

Is there a way to change the behavior of urltools to use %20 instead of + for spaces?

You can use the bundled omz_urlencode function which provides the -P option to encode spaces as '%20'.
Perhaps we should combine the urltools plugin with the core functions?


chore(ocean-api): set up docker image

What this PR does / why we need it:
Set up docker container for shift left sanity testing of ocean api.
Which issue(s) does this PR fixes?:

Fixes #942

Superseded by #1070


Point leagues

Documentation for https://github.com/mautic/mautic/pull/11891

Hi there!
Can you please make this on https://github.com/mautic/user-documentation as we will be deprecating this repo soon.
Thanks!


Get Hadoop reference loading code into htsjdk

@tomwhite wrote code to read in the reference from hdfs. We need to move that logic into htsjdk (to avoid the two getting out of sync). Assigning to @droazen for now.

Rather than adding a Hadoop dependency into htsjdk, it would be sufficient (and more general) to add overloaded methods for InputStream/java.nio.file.Path etc, so that it's possible to use other filesystems with htsjdk.
For example, this is the change needed for the fasta code: https://github.com/samtools/htsjdk/compare/master...tomwhite:hadoop.
It's fairly straightforward to hook this up with Hadoop in hellbender (either directly - which worked when I mocked it up, or using something like https://github.com/damiencarol/jsr203-hadoop - although I haven't tried that one).
Does this approach look ok to you @droazen? I'd like to add a few tests and support for reading a sequence dictionary too, but otherwise that code is almost ready.

Forgot to say - the java.nio.file API is only available from Java 7 onwards, and htsjdk is currently based on Java 6. However, I noticed that it will support Java 8 from October, so maybe it's OK.

I've created a pull request for this here: https://github.com/samtools/htsjdk/pull/308. Please take a look when you have time, @droazen.

I've added a comment there -- basically I need more information on the advantages of this approach over the one in https://github.com/samtools/htsjdk/pull/211 (which could in theory be merged now rather than in October). Is the main advantage avoiding adding the hadoop dependency in htsjdk, or are there other benefits as well? Do you think it would be cleaner/less invasive, and generalize well to the rest of htsjdk (beyond the reference classes)?

This is done! Closing


Add templates for bugs, features and questions

About the changes

Provide 3 different templates (bug report, features request and question / problem)
All templates include some comments that help the reporter fill out the predefined fields

What this PR improves
This PR aims to improve the bug reporting that is completely formless at the moment of writing
and every issue reporting a bug misses important information for reproduction. The PR also provides
some templates for questions and feature requests that can also be ignored but help people write down
their idea or question and get faster and easier a response.

Hey, sorry for the late reply. Thanks for your contribution!


Update request requirement

Update request requirement from version v2.14.2 to v2.18.4
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Hi @TopdRob,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Have you tested this change locally?

Yes, according to these instructions: https://home-assistant.io/developers/development_environment/
I have my test environment running on Raspbian

Hi @mgillespie,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Hi @mgillespie,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Hi @mgillespie,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Hi @mgillespie,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

I'm lost :-(


Add a RELEASE.md explanation

This is a first shot about a simple explanation of the release process to help anyone to do it.

WDYT @TheLortex about this PR?

Looks good !


Failed to launch browser!

Hi All,
I ran into this issue and not quite know how to resolve it. Any help would be appreciated.
Expected behavior
Scripts are deployed and run headless on the bitbucket-pipline code commit.
Actual behavior

/opt/atlassian/pipelines/agent/build/packages/server/app/tests/E2E/node_modules/taiko/.local-chromium/linux-800071/chrome-linux/chrome: error while loading shared libraries: libnss3.so: cannot open shared object file: No such file or directory

Steps to reproduce

Scripts are using: await openBrowser({
headless: true,
args: [
"--disable-gpu",
"--disable-dev-shm-usage",
"--disable-setuid-sandbox",
"--no-first-run",
"--no-sandbox",
"--no-zygote"],
});
E2E package.json : {
"name": "gauge-taiko-template",
"version": "0.0.1",
"description": "Starter template for writing JavaScript tests for Gauge",
"scripts": {
"e2e": "gauge run specs/"
},
"dependencies": {
"taiko": "latest",
"taiko-storage": "0.0.3"
}
}
The root level package.json has
"scripts": {
"e2etest": "cd packages/server/app/tests/e2e && npm install taiko && npm run e2e",
}

Versions
"node": "12.16.2" and<EMAIL_ADDRESS>

There a section in the FAQ for this https://docs.taiko.dev/frequently_asked_questions/#i-have-a-few-issues-launching-the-browser-instance-in-linux
Please try installing all the dependencies to see if it fixes the issue.


account_id "xxxxxxxxxxx" is incorrectly formatted AWS account id

When using the ~/.aws/accounts file AWS account ids that start with a 0 (zero) throw the error account_id "xxxxxxxxxxx" is incorrectly formatted AWS account id
It seems that because the id is specified as a json number the leading zero is removed. Then if the id is specified as a string the following error is thrown.
account_id ""xxxxxxxxxxxx"" is incorrectly formatted AWS account id
I think the solution is to use jq --raw-output on the account_id look up. However there may have been a good reason to use a number for the account id, I've only just started using this.

excellent issue, I have not run into. I will test this out and try get a fix for it out.

I have added a fix and released a new version. To have accounts that start with 0 you need to use a string in the accounts file.


typo: Double word "an"

@nschonni : Thanks for your contribution! The author, @minewiskan, has been notified to review your proposed change.

#sign-off


Backport cuda to 3.x

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

This backport will actually affect downstream packages. AFAIK, pennylane depends on kokkos =3.* and pennylane is the only downstream package.

Thanks again for this work @carterbox . I think the PR is good to go. To clarify the situation on PennyLane and plugins, we have:

PennyLane-Lightning depends on Kokkos & Kokkos-kernels 3.0 (serial backend). It will move up to 4.0 (serial backend) in the near future.
PennyLane-Lightning-Kokkos depends on Kokkos 3.0 (openmp backend). It will also move up to 4.0 (openmp backend) in the near future. With your work, it may now ship with Kokkos 3.0/4.0 (CUDA backend), which is a real nice addition.


show progress for etching

Fixes #3548
Fixes #3674

Now it shows a progress bar too:

@casey @raphjaph: can someone review it?

@raphjaph ^

@casey any update ^

LGTM
To remove an etching from the loop we need to use the clear_etching function. With that I was able to remove the enumerate and i in the loop. If the commit is not found I'd rather not delete the entry for now, since maybe you would want to recover that. We can change it back later but this way we don't accidentally delete something.

alright.


Failed to ingest events

Failed to ingest events .catch() NetworkError when attempting to fetch resource.
Machine ID: b2e2c6c0-ed57-49d2-9ae0-669a807b4a98

[!NOTE]
Book a call

key
value

id
14ou4uio3381721570008519

url
http://localhost:3002/

wifi

cpu
4

mem
undefined

gpu

time
1721570011572

items
0

bytes
0

Hi @walidoumechtak , we've just deployed a fix for you. Can you try running the setup script npx million@latest. Once it's done, please restart your VSCode/Cursor. Let me know if that works for you!


MB-2376 Reduce size of html page by splitting style sheet and svg images to files

Description
This PR is just refactoring the maintenance page so we can handle a max 1024 chars limit when setting alb response. This is a no op.
Code Review Verification Steps

[ ] There are no aXe warnings for UI.
[x] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[x] Request review from a member of a different team.
[x] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots

Messages

:book:
:link: MB-2376

  Generated by :no_entry_sign: dangerJS against f10fa42bd3c90dd9dc50c3995d409d82dbaa4e4d


Bots In infected are broken

During setup they continuously gib and when the match starts the game crashes after a few minutes

known and fixed in dev build


Update: MKVToolNix.MKVToolNix version 54.0.0

Removing old versions to reduce clutter
Microsoft Reviewers: Open in CodeFlow

/azp run


link: switch from tar to ar for .rlibs.

Fixes #711 by an almost-1:1 replacement of the tar crate with the ar crate. The documentation for those crates points to more information on the formats, but in short:

ar dates from 1971, holds a flat list of files, and is only used for .a static libraries (which contain the .o files they were created from, and optionally a symbol table) and .deb packages (for some reason)

it also has a BSD vs GNU split, but based on the GNU variant being used on Linux and Windows, I chose that, as it likely means better support

tar dates from 1979, understands directory trees, and has been used for pretty much any archive purpose on UNIX systems (often compressed as e.g. .tar.gz or .tar.xz)

While using tar (or anything else, like, say, zip) doesn't really cause any issues, since we don't need to interop with any tools (for now), switching to ar does let us deduplicate some code (sadly for now only the part that finds the rmeta file inside the .rlib).
For future reference, the rustc_codegen_cranelift code for handling archives, which could eventually be moved into rustc_codegen_ssa (or in some other crate, more dedicated to linking) can be found in its src/archive.rs (cc @bjorn3).

thanks @bjorn3 for the original pointer on this!

For future reference, the rustc_codegen_cranelift code for handling archives, which could eventually be moved into rustc_codegen_ssa (or in some other crate, more dedicated to linking) can be found in its src/archive.rs (cc @bjorn3).

Unfortunately not. The upstream ar crate doesn't handle symnol table generation. I am using a fork that does implement it. It works fine with Linux, FreeBSD and MinGW, but for some reason not on macOS. I hope that the object crate will eventually support writing object files and support macOS too.

Maybe a path forward could be object having a wrapper for the ar crate, that can read/write the symbol table information? Not sure how valuable ar is on its own without that support, but it makes sense on some level that you can have it for the "archive" part, and then object can handle "static library in ar format".

(disabled auto-merge until I can figure out why it failed on CI on windows - the HACK commit is for diagnosing that)

Not sure how valuable ar is on its own without that support,

Without symbol table no linker I know of will attempt to read anything from an archive.

but it makes sense on some level that you can have it for the "archive" part, and then object can handle "static library in ar format".

The symbol table writing and archive writing need to be handled by the same crate. Symbol tables contain offsets to the start of the defining object files, not an index. The symbol table is always the first member of an archive, even for gnu style archives which have a name table before all user defined members. The symbol table format also depends on the archive format. There is a program called ranlib that can create the symbol tables after the fact, but because it is after the fact, it needs to rewrite the archive, which is slow.

Without symbol table no linker I know of will attempt to read anything from an archive.

 :P - tbh though, there's no standard at all for shoving spir-v modules into an archive, and the concept of linking spir-v is only barely included in the spec, and is extremely, extremely rare to do in the spir-v world. We're basically just using tar/ar as "rustc expects us to bundle multiple compilation results into one file, I guess we'll use ar, even though they're not even object files"

Something I forgot to mention is that WASM uses ar but doesn't bother wrapping the .rmeta file in some kind of WASM binary file, and there's even a comment about it (I'll edit the PR description now).

Windows failure is https://github.com/mdsteele/rust-ar/issues/19 - I will work around it for now, but also try to fix it upstream.


[BUG] The value supplied for parameter 'instanceProfileName' is not valid

Describe the bug
The latest module (v0.5.2) throws the following error:
"The value supplied for parameter 'instanceProfileName' is not valid. The provided instance profile does not exist.

The might be a race condition here as I can see the resource on a destroy:
  # aws_iam_instance_profile.this will be destroyed
  - resource "aws_iam_instance_profile" "this" {
      - arn         = "arn:aws:iam::123443211234:instance-profile/test-pipe-imagebuilder-instance-profile-20210914083450236900000002" -> null
      - create_date = "2021-09-14T08:34:52Z" -> null
      - id          = "test-pipe-imagebuilder-instance-profile-20210914083450236900000002" -> null
      - name        = "test-pipe-imagebuilder-instance-profile-20210914083450236900000002" -> null
      - name_prefix = "test-pipe-imagebuilder-instance-profile-" -> null
      - path        = "/" -> null
      - role        = "test-pijp-tg-imagebuilder-role-20210914083448508400000001" -> null
      - tags        = {} -> null
      - tags_all    = {} -> null
      - unique_id   = "AIPA3JAHVOPNQES7DJZNN" -> null
    }

There is probably something that I'm missing here. I can see the resource and as the name is a simple string, you'd suspect it to be valid.
To Reproduce
terraform apply
Full Stacktrace
│ Error: error waiting for CloudFormation Stack creation: failed to create CloudFormation stack, rollback requested (ROLLBACK_COMPLETE): ["The following resource(s) failed to create: [distConfig, infraConfig]. Rollback requested by user." "Resource creation cancelled" "Resource handler returned message: \"The value supplied for parameter 'instanceProfileName' is not valid. The provided instance profile does not exist. Please specify a different instance profile and try again. (Service: Imagebuilder, Status Code: 400, Request ID: 50600df7-a4fd-4eec-8b01-916d0405b38b, Extended Request ID: null)\" (RequestToken: c97e2aa0-68ca-0cb5-cc52-6bb03c098380, HandlerErrorCode: GeneralServiceException)"]

have you double-checked that the instance profile is there? terraform is pretty convinced that

The provided instance profile does not exist.

So this module currently creates:
Plan: 5 to add, 0 to change, 0 to destroy.

and we can observe:
  # aws_iam_instance_profile.this will be created
  + resource "aws_iam_instance_profile" "this" {
      + arn         = (known after apply)
      + create_date = (known after apply)
      + id          = (known after apply)
      + name        = (known after apply)
      + name_prefix = "test-pijp-imagebuilder-instance-profile-"
      + path        = "/"
      + role        = (known after apply)
      + tags_all    = (known after apply)
      + unique_id   = (known after apply)
    }

After applying it we can see it failing with the error message above but after running a destroy we can observe that the resource was created:
Plan: 0 to add, 0 to change, 5 to destroy.

  # aws_iam_instance_profile.this will be destroyed
  - resource "aws_iam_instance_profile" "this" {
      - arn         = "***" -> null
      - create_date = "2021-09-14T14:00:10Z" -> null
      - id          = "test-pijp-imagebuilder-instance-profile-20210914140010269300000002" -> null
      - name        = "test-pijp-imagebuilder-instance-profile-20210914140010269300000002" -> null
      - name_prefix = "test-pijp-imagebuilder-instance-profile-" -> null
      - path        = "/" -> null
      - role        = "test-pijp-imagebuilder-role-20210914140008181200000001" -> null
      - tags        = {} -> null
      - tags_all    = {} -> null
      - unique_id   = "AIPA5JAMNOVNVTPKXPF5O" -> null
    }

Having the same issue. The resource is being created
  # aws_iam_instance_profile.this will be created
  + resource "aws_iam_instance_profile" "this" {
      + arn         = (known after apply)
      + create_date = (known after apply)
      + id          = (known after apply)
      + name        = (known after apply)
      + name_prefix = "Tf-pipeline-imagebuilder-instance-profile-"
      + path        = "/"
      + role        = (known after apply)
      + tags_all    = (known after apply)
      + unique_id   = (known after apply)
    }

and I can even see it after deployment running aws iam list-instance-profiles

    "Path": "/",
    "InstanceProfileName": "Tf-pipeline-imagebuilder-instance-profile-20210917132513598500000002",
    "InstanceProfileId": "AIPAQ6JXJPQVQI3IXZED6",
    "Arn": "arn:aws:iam::0XXXXXXXXXXX:instance-profile/Tf-pipeline-imagebuilder-instance-profile-20210917132513598500000002",
    "CreateDate": "2021-09-17T13:25:13+00:00",
    "Roles": [
        {
            "Path": "/",
            "RoleName": "Tf-pipeline-imagebuilder-role-20210917132512716700000001",
            "RoleId": "AROAQ6JXJPQVWYXSL2RDB",
            "Arn": "arn:aws:iam::0XXXXXXXXXXX:role/Tf-pipeline-imagebuilder-role-20210917132512716700000001",
            "CreateDate": "2021-09-17T13:25:12+00:00",
            "AssumeRolePolicyDocument": {
                "Version": "2012-10-17",
                "Statement": [
                    {
                        "Sid": "",
                        "Effect": "Allow",
                        "Principal": {
                            "Service": "ec2.amazonaws.com"
                        },
                        "Action": "sts:AssumeRole"
                    }
                ]
            }
        }
    ]
}

Do we have a fix on it? Will greatly appreciate any help as we have been stuck for a week?

@sblack4 I would appreciate if you can assist on this as we have been stuck for weeks. thanks

We've tested this too, even up to an hour we can still observe the same stacktrace being thrown.

This is where the instance profile gets passed to cloudformation but the "i" in InstanceProfile is capitalized. I thought this was the line throwing the error, when it tried to create the InfrastructureConfiguration but I'm not so sure now. Does the error message give more information?


Spurious "unused local definition" for type parameter of polymorphic function within a block

Hey all,
thank you so much for your amazing work and bringing warnings back. I might have found some spurious warning:
Compiler version
3.3.0 and 3.3.1-RC1
Minimized code
  {
    def func(pred: [A] => A => Boolean): Unit =
      val _ = pred
      ()

    val _ = func
  }

The val _ = ... stuff is just here to silence the warnings that might otherwise pop up, like pred being unused.
Output
[warn] -- Warning: /tmp/test/src/main/scala/Main.scala:3:20 ---------------------------
[warn] 3 |    def func(pred: [A] => A => Boolean): Unit =
[warn]   |                    ^
[warn]   |                    unused local definition

Expectation
Should not warn.
Scastie-Link:
https://scastie.scala-lang.org/JYhAvR0gQlKcAFTb9eOsFA
( Contains more newlines than normal to make it easy to spot which part the compiler considers to be unused )

Fixed in 3.3.2 by https://github.com/scala/scala3/pull/17929
Bisected on scastie. I wonder why scastie doesn't have a bisect button.
I'll add the small test to the existing test, since it's not an obvious duplicate.
            DefDef(func,
              List(List(
                ValDef(pred,
                  RefinedTypeTree(TypeTree(), List(
                    DefDef(apply,
                      List(
                        List(
                          TypeDef(A,
                            TypeBoundsTree(TypeTree(), TypeTree(),
                              Thicket(List()))
                          )
                        ),
                      List(ValDef(x$1, Ident(A), Thicket(List())))),
                      Ident(Boolean), Thicket(List()))
                  )),
                Thicket(List()))
              )),


Conversion between old and new SIMBAD classification

The historical list of object types in SIMBAD has been replaced by a reorganized list (see https://simbad.cds.unistra.fr/guide/otypes.htx). We should make the transition. The current class table, driven by SIMBAD classification, is rather big:
260.5 G  /hbase_fink2/data/default/ztf.class

There are 2 strategies to consider:
Recreating the class table
In this scenario, we would re-create the class table, but this time we would use the 3-digit code from SIMBAD instead of the long name. the advantage is that 3-digit codes did not change during the list replacement. But that would imply:

changing the xmatch in fink-science to output this 3-digits [easy]
performing the conversion to the long name on-the-fly in the portal [easy]
re-creating the whole HBase table [painful]

One big advantage, is that it would be more robust to change in the future.
[EDIT]: one big difficulty is that cdsxmatch is present on ALL HBase table. So re-creating the class table is not enough...
High-level name conversion
Here the idea would be to have a dictionary to convert types on-the-fly

we use the new object type names. This means user query automatically leads to 2 queries (old & new names).
the old names would be converted to new names automatically at the level of the web portal [easy]

The main advantage is that it is easy to implement, but the main disadvantage is that we need to maintain two definitions (hence the technical debt will become bigger and bigger).

We will follow the 2nd scenario for ZTF, and enforce the 1st scenario for LSST (when tables will be new).

Conversion will be done in fink-utils.


Nixpkgs: remove obsolete webhooks

These two webhooks don't seem to be used anymore:

I also don't know who these users are.
I'll remove them next weekend if there is no objection.

The first one is @andir.


Using EA launcher

I do not have steam version I am using EA Launcher. is there a piece of code somewhere i can change the file path with?

Okay, so quickly figured out how to launch with ea launcher but the new issue is this (exited with code 100010)
Anything I can do?
The game still launches but nothing happens as far as a trainer popping up


Documentation on how to move code from a private repository to a public repository

Tasks

[x] Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
[x] Give this pull request a descriptive title that can be used as a one line summary in a changelog
[x] Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
[x] Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
[x] Please use yamllint to check that your YAML files do not contain mistakes (not necessary)

Closes #1578

Have you tried building the documentation locally and checking how this contribution fits in? It renders a bit strangely for me.
As a reminder, if you installed esmvaltool from your working directory of this repository with pip install -e .[develop] then you should be able to build the documentation with python setup.py build_sphinx and this should produce the documentation as HTML in doc/sphinx/build/html.

Alternatively, you can check the documentation as produced by readthedocs for this PR here.

Alternatively, you can check the documentation as produced by readthedocs for this PR here.

I changed the underlining, and now the entry in the documentation is corrected. Well spotted!

Looks good! Would it make sense to move this content to the GitHub Workflow section? Or would that make it too hard to find and do we not like that section very much anyway anymore because it's a bit dated?

Honestly, I am not sure where I would prefer it. The GitHub Workflow section would work as well, but as you said, it is a little more hidden. And the the topic touches on both, the general contribution and the GitHub Workflow. If you think the GitHub Workflow section is anyway a little dated, then I would probably just leave the section where it is right now, and rething its placement when we update the Workflow section.

I only have one question left: Should the steps be numbered like this? Normally, I would say that this numbering is part of the structure of the document, so if desired, should perhaps be achieved with a :numbered: directive somehow. Otherwise, the style should be consistent across the documentation, so I was wondering if similar lists exist in other documents and if they use the parentheses style 1) or the pointed style 1. (which would fit more with the markdown numbered lists).

I only have one question left: Should the steps be numbered like this? Normally, I would say that this numbering is part of the structure of the document, so if desired, should perhaps be achieved with a :numbered: directive somehow. Otherwise, the style should be consistent across the documentation, so I was wondering if similar lists exist in other documents and if they use the parentheses style 1) or the pointed style 1. (which would fit more with the markdown numbered lists).

I have changed the numbering and underlining so that this section of the documentation is now consistent with the numbering in the documentation section "datasets".


Ignore case sensitivity when filtering headers

HTTP headers are case-insensitive, this patch will filter out headers defined on config even if they have different case.

Thanks!


Initial Redux Store

This has the basic store managed by actions and include unit tests to verify that the store is in a correct state

@hmhealey I added a few more changes to this PR, feel free to re-review

@hmhealey changes ready


Rerender

Alternative to #5

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


(new Duration) OR (const Duration)

Now... I can't see the advantages/pros for using const... in IntelliJ and Android Studio you can't fold your code if you leave out the "new" keyword... so I am always using it with (maybe a bug ?)
is there any disadvantage if you don't use any const's there, where you don't need? I see only using constants in a custom color definition. If you don't use, you can see the color icon in the gutter in IntelliJ and Android Studio (maybe a bug too ?)
const Duration d1 = const Duration(seconds: 1);
Duration d1 = new Duration(milliseconds: 1000);

const Duration d1 = const Duration(seconds: 1) will work only when you have provided constant values to seconds, but if your seconds value is dependent on some parameter, which changes according to different situations, 'const' keyword would raise an error. So, always prefer to use:
Duration d1 = Duration(seconds: timeDelay), where timeDelay is any variable holding integer values.
(not using 'new' keyword, since its not mandatory from Dart2).

const is used for performance improvements.
The difference is not huge but it may sum up.
https://news.dartlang.org/2012/06/const-static-final-oh-my.html
Can you please report the folding but in https://youtrack.jetbrains.com


Automated cherry pick of #8873: optimized: server delete log and wait time

Cherry pick of #8873 on release/3.4.
#8873: optimized: server delete log and wait time

Codecov Report

Merging #8875 (47349e7) into release/3.4 (02bcce1) will decrease coverage by 2.63%.
The diff coverage is 2.80%.

@@              Coverage Diff               @@
##           release/3.4   #8875      +/-   ##
==============================================
- Coverage         6.22%   3.58%   -2.64%
==============================================
  Files              759     304     -455
  Lines           117145   62567   -54578
==============================================
- Hits              7289    2243    -5046
+ Misses          109197   60169   -49028
+ Partials           659     155     -504

Flag
Coverage Δ

aFlag
3.58% <2.80%> (-2.64%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/appsrv/stats.go
0.00% <0.00%> (ø)

pkg/cloudcommon/notifyclient/events.go
0.00% <0.00%> (ø)

pkg/cloudcommon/notifyclient/notify.go
1.80% <0.00%> (-0.43%)
:arrow_down:

pkg/compute/models/buckets.go
1.10% <0.00%> (+0.03%)
:arrow_up:

pkg/compute/models/cachedimages.go
1.73% <0.00%> (-0.08%)
:arrow_down:

pkg/compute/models/capabilities.go
0.00% <0.00%> (ø)

pkg/compute/models/cloudaccounts.go
0.48% <0.00%> (-4.66%)
:arrow_down:

pkg/compute/models/cloudregionresource.go
0.00% <0.00%> (ø)

pkg/compute/models/cloudregions.go
1.54% <0.00%> (-0.04%)
:arrow_down:

pkg/compute/models/dbinstance_skus.go
2.83% <0.00%> (-0.02%)
:arrow_down:

... and 472 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9565f2...47349e7. Read the comment docs.


add openebs to helm hub

Signed-off-by: kmova<EMAIL_ADDRESS>

/lgtm

The Artifact Hub[https://artifacthub.io/] is another place you can list your repos. To do that, you login (or create an account), create an organization, and list your repository. You can link it to a user or organization.

Added to ArtifactHub: https://artifacthub.io/packages/chart/openebs/openebs


Running when merge to master

Report
What did you do?
Merge a MR to master
What did you expect to happen?
Still run Danger and show log.
What happened instead?
Not a GitLabCI Pull Request - skipping `danger` run

Is it possible running Danger when I merge to master, because I used  Danger-xcov to parse my coverage report.
Your Environment

Which CI are you running on?  GitLab CI
Are you running the latest version of Danger? Yes

Maybe through Danger local? I can't remember how danger ruby works anymore.


Indian frequency plan

Add support for IN865-867.
This can wait until TTN supports it.

Its working now, Use FP_IN865_867