Pinch to zoom doesn't work after adding enableZoomGesture💭

Question
I wanted to  add the option to zoom in with the camera, and added
enableZoomGesture={true}.
My camera setup now becomes:
{cameraLoaded && isFocused && (           // <GestureDetector gesture={gesture}>           <Camera           device={device}           enableZoomGesture={true}           ref={myCamera}           photo={true}           isActive={cameraLoaded}           style={{height: camera_aspect_ratio * screen.width, justifyContent: 'center'}}           codeScanner={codeScanner}           format={format}           // onPress={_handleFocus}           onError={handleCameraError}           onInitialized={() => {               console.log("Camera initiliazed")               setIsCameraReady(true)             }           }         />           // </GestureDetector>       )}
But when I pinch to zoom  nothing happens, I guess  I'm overseeing something?
What I tried
I went from the v3.9.1 to beta version v4.0.0 (zoom seemed not to work in both)
I also tested on 2 android devices (2 different types of samsung).
Since I  seem  the only  one with this problem I asume the fault is in my code, what checks can I do to further diagnose?
VisionCamera Version
v4.0.0-beta.7
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

Update: I used another RN camera library that supports zoom and the issue remained. I don't know why this is but I guess its related to that I'm using a navigation drawer which makes use of gestures and maybe also overrides the pinch gesture.
I don't have a solution for now

how does your gesture look like?

The gesture of my drawer navigation is a swipe from left to right as can be seen in the animation on this page. The gesture I perform for the zoom is pinch to zoom, but I tried several possible movements though. I guess the problem lays in the native function 'SimpleOnScaleGestureListener' that maybe gets overriden by another library or gets block by something.

Maybe you have a view above your Camera that needs something like pointerEvents="none" to correctly let touches through.
Either way, not a VisionCamera bug 👍

Indeed that seemed to be the issue and pointerEvents="none" was the solution!


declare deprecation of enterprise search plugin

The Enterprise Search product is deprecated and will not be included in the Elastic Stack 9.x release.
As a result, the App Search and Workplace Search plugins are also deprecated. These plugins will only receive security updates and critical bug fixes moving forward.
This commit added deprecation log
fixes: https://github.com/logstash-plugins/logstash-integration-elastic_enterprise_search/issues/20, https://github.com/logstash-plugins/logstash-integration-elastic_enterprise_search/issues/21

@donoghuc Thanks for the reviews. We maintain a single series of plugin. 3.0.0 is included in 8.17.
Although the default distribution of v9 will not include this plugin, user can manually install it. Whenever, the plugin is used, the deprecation log should print and give instructions to the next steps.

Ah, sorry I confused this with some of the other plugins i've been working on. Thanks that makes sense! 🙃 ERRTOOMANYPLUGINS


Sigcheck lacks exit codes

It seems that sigcheck uses exit codes to communicate some issues with files.  E.g. 1 seems to indicate files that are unsigned (gleaned from the web).  I have an exit code of 4, but without docs I'm unable to know what that means.  Please add docs for exit codes to this and I'd assume other tools.

Exit codes explained
Seems to be:

-1 - bad file or option
0 - all signed or all unsigned filtered out
+1 - number of unsigned or sigfnature failure files

Thanks for reporting this, we've added the documentation item to our backlog.

When processing a folder this represents the number of unsigned files that were found.


Allow compilation with CompileFile if config file differs

Is your feature request related to a problem? Please describe.
I want to test contract deployment and updating with neotest. I only modified some settings in the config file, but CompileFile returns the old contract because of the caching being based on just the contract source path. Specifically this code
https://github.com/nspcc-dev/neo-go/blob/d8e3e57f88f281934d875d44cbca28111757c9ed/pkg/neotest/compile.go#L46-L49
I tried using it as follows
c := neotest.CompileFile(t, e.CommitteeHash, basePath+"main.go", basePath+"neo-go.yml")
e.DeployContract(t, c, nil)
...some tests

c = neotest.CompileFile(t, e.CommitteeHash, basePath+"main.go", basePath+"neo-go-update.yml")
...invoke update and do rest of tests

Describe the solution you'd like
I think the easy way to resolve this is to use the combination of srcPath + configPath as key
Describe alternatives you've considered
Add a force bool arg that skips the cache check. The implicit fix seems more natural.

Not sure this cache is useful at all, but changing the key is easy.


GH-34626:  [C++] Add ordered/segmented aggregation Substrait extension

See #34626

Closes: #34626

cc @icexelloss

Marking as a draft until testing is added.

@westonpace, I believe the CI failures are unrelated, but please review them.

@rtpsw can you also remove the extra reviewers? Thanks

I don't seem to have permission to do this.

@westonpace I believe the two main remaining items are:
(1) https://github.com/apache/arrow/pull/34627/files#r1151191726
Your comment here about not exposing these methods in the header. I agree with this and made an attempt here:
https://github.com/rtpsw/arrow/pull/3/files
I am able to move those methods internal to relational_internal.cc but as a result I also need to move the DefaultExtensionProvider to relation_internal.cc because it needs to access those method.
I feel this is a bit cleaner than what is currently in the PR. If you are OK with this I can update the PR with the change. If you want some other way to resolve this / or leave it as is in the PR let me know as well.
(2) https://github.com/apache/arrow/pull/34627#discussion_r1151204240
This is potentially a bug / correctness issue. Given this is not introduced in this PR I am leaning towards debug this as follow up (I actually suspect this could cause some internal issues and asked @rtpsw to test but I also don't want to drag this PR for too long).
If you feel otherwise let me know I can try to get to the bottom of this.
In any case, I would like to move forward with this PR so please let me know your preference of the two issues above or any other  issue that I missed.

https://github.com/apache/arrow/issues/34786

Thanks @westonpace. In that case I will go ahead and merge this. There is definitely room for clean up header/inclusion I would create a follow up to clean this up interest of time.

https://github.com/apache/arrow/issues/34800


BE: Restore unique visitors + IP location metrics

Pull request details

To test it locally:

Download a free IP2Location IPv6 database file from ip2location.com (DB5 or greater)
Update dcapal.yml config

app:
  services:
    ip:
      dbPath: IP2LOCATION_FILENAME.BIN

Run DcaPal backend dev stack

docker compose -f docker-compose.yml -f .\docker\docker-compose.dev.yml up -d

Start DcaPal backend
Send an HTTP request with X-Real-IP header (requests from localhost/loopback IPs are ignored)

curl http://localhost:8080/assets/fiat -H 'X-Real-IP: <IP_ADDRESS>'

Go to Prometheus web interface at http://localhost:9090 and look for dcapal_visitors_total metrics

dcapal_visitors_total{exported_job="dcapal-backend", instance="host.docker.internal:9000", ip="<IP_ADDRESS>", job="dcapal-backend", latitude="12.97623", longitude="77.60329"}

Breaking changes

Drop support for adapter::IpApi

Issues fixed

#88

I tried it locally and it works!


Setup

I thought about setting a working environment with which everyone could work. I think it will prevent us from having problems with dependencies.
I would be happy to ear what you think about it. The main idea is to develop this repository as if it would be a package. I explain the step to follow in the README to install it.

This is a good idea!
I think maybe we can use a requirements.txt file and read it from the setup (like this for example https://stackoverflow.com/questions/26900328/install-dependencies-from-setup-py). But it's just a minor thing and we can do this change in the future if really needed (if we have lots of requirements)

@paulinesert I am going to rebase this PR first and I will see which dependency we need to install!

I tried to respect your three requests:

@emasquil the requirements are now in setup.cfg.
@nviolante25  the package is now searched at ppo.
@paulinesert  I have added dm-acme to the requirements. I tried to keep as less requirements as possible.

I deleted my personal virtual environment and build it again. It works fine for me!
ps: I rebased this branch on main. It is not the first time I try to rebase a branch but it is the first time I succeed haha. This is why I wrote a wiki here in case you need it :)

Great!
A small detail about the link on the wiki about rebasing. Instead of using --force, it's generally better to use --force-with-lease. That prevents overwriting other people's work.

Great! A small detail about the link on the wiki about rebasing. Instead of using --force, it's generally better to use --force-with-lease. That prevents overwriting other people's work.

Thank you for the comment. Maybe you can add it to the wiki?

Thank you for the comment. Maybe you can add it to the wiki?

Sure!


Update module github.com/gofiber/jwt/v2 to v3

This PR contains the following updates:

Package
Type
Update
Change

github.com/gofiber/jwt/v2
require
major
v2.2.7 -> v3.3.6

Release Notes

gofiber/jwt
v3.3.6
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.41.0 to 2.42.0 (#115)
Bump dependabot/fetch-metadata from 1.3.5 to 1.3.6 (#114)

Full Changelog: https://github.com/gofiber/jwt/compare/v3.3.5...v3.3.6
v3.3.5
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.40.1 to 2.41.0 (#112)
Bump actions/checkout from 3.1.0 to 3.3.0 (#111, #113)
Bump github.com/golang-jwt/jwt/v4 from 4.4.2 to 4.4.3 (#110)

Full Changelog: https://github.com/gofiber/jwt/compare/v3.3.4...v3.3.5
v3.3.4
Compare Source
❗ BreakingChange
Due to the fact that fasthttp, which fiber is based on in release 1.41.0, does not support go versions 1.14 & 1.15 anymore, we had to remove them from our fiber package with release v2.40.0 and also from this package
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.40.0 to 2.40.1 (#109)
update fiber to v2.40.0 (#105)
Allow Header Extraction without AuthScheme #103 (#104)
Bump actions/setup-go from 2 to 3 (#106)
Bump actions/checkout from 2.3.1 to 3.1.0 (#107)
Bump reviewdog/action-golangci-lint from 1 to 2 (#108)

Full Changelog: https://github.com/gofiber/jwt/compare/v3.3.3...v3.3.4
v3.3.3
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.38.1 to 2.39.0 (#102)

Full Changelog: https://github.com/gofiber/jwt/compare/v3.3.2...v3.3.3
v3.3.2
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.37.1 to 2.38.1 (#101)

Full Changelog: https://github.com/gofiber/jwt/compare/v3.3.1...v3.3.2
v3.3.1
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.37.0 to 2.37.1 (#100)

Full Changelog: https://github.com/gofiber/jwt/compare/v3.3.0...v3.3.1
v3.3.0
Compare Source
🚀 New

Feature/multiple jwks urls (#94)

v3.2.15
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.36.0 to 2.37.0 (#99)

v3.2.14
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.35.0 to 2.36.0 (#98)

v3.2.13
Compare Source
🧹 Updates

Bump github.com/golang-jwt/jwt/v4 from 4.4.1 to 4.4.2 (#95)
Bump github.com/gofiber/fiber/v2 from 2.34.0 to 2.35.0 (#93, #96)

v3.2.12
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.32.0 to 2.34.0 (#88, #91)

v3.2.11
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.31.0 to 2.32.0 (#87)

v3.2.10
Compare Source
🧹 Updates

Bump github.com/golang-jwt/jwt/v4 from 4.4.0 to 4.4.1 (#85)
Bump github.com/gofiber/fiber/v2 from 2.30.0 to 2.31.0 (#86)

v3.2.9
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.29.0 to 2.30.0 (#84)
Bump github.com/golang-jwt/jwt/v4 from 4.3.0 to 4.4.0 (#83)

v3.2.8
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.28.0 to 2.29.0 (#82)

v3.2.7
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.27.0 to 2.28.0 (#81)

v3.2.6
Compare Source
🧹 Updates

Bump github.com/golang-jwt/jwt/v4 from 4.2.0 to 4.3.0 (#79)

v3.2.5
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.26.0 to 2.27.0 (#80)

v3.2.4
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.24.0 to 2.26.0 (#78)

v3.2.3
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.23.0 to 2.24.0 (#76)

v3.2.2
Compare Source
🧹 Updates

Bump github.com/golang-jwt/jwt/v4 from 4.1.0 to 4.2.0 (#72)
Bump github.com/gofiber/fiber/v2 from 2.22.0 to 2.23.0 (#74)

v3.2.1
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.20.2 to 2.22.0 (#71)
Bump github.com/gofiber/fiber/v2 from 2.20.1 to 2.20.2 (#68)

📚 Documentation

README: fixing example logic in generating a jwy token (#67)

v3.2.0
Compare Source
🚀 New

Add custom KeyFunc to middleware configuration (#69)

📚 Documentation

Fixing examples in creating token with claims (#65)

v3.1.2
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.19.0 to 2.20.1 (#63)
Bump github.com/golang-jwt/jwt/v4 from 4.0.0 to 4.1.0 (#61)

v3.1.1
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.18.0 to 2.19.0 (#60)

v3.1.0
Compare Source
🚀 New

Implementing JWKs (#57)

v3.0.2
Compare Source
Fix incorrect module version.
v3.0.1
Compare Source
🧹 Updates

Bump github.com/gofiber/fiber/v2 from 2.17.0 to 2.18.0 (#55)

v3.0.0
Compare Source
📦  Breaking change

update from jwt version 3 to 4 (#54)
note: jwt 4 supports golang version greater than 1.15

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: go.sum
Command failed: go get -d -t ./...
go: RLock /tmp/renovate/repos/github/Tert0/gobin/go.mod: no locks available

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Exclude, include and redact log lines via regex

Ref: LOG-9091 and LOG-9092

Depends on https://github.com/logdna/logdna-rust/pull/10

I've refactored it to use regex::bytes crate for both text and buffer lines.

I think it's ready for another round of review @c-nixon
Also, lmkwyt about https://github.com/logdna/logdna-rust/pull/10

I've updated the client and refactored redaction to support overlapping matches.

Fixed a bug related to redaction ordering and addressed the LF char issue.


Add support for Gammu SMS Api

Added support for Gammu SMS Api. Tested it with latest Laravel 5.3 rc1.

This should be send to laravel/framework.


IE9: Cannot add Contributor

Production and Staging
Steps

Go to project with admin access
Choose a project
Go to sharing
Click add contributor
Search for and/(or just) add contributor to "Adding" list
Click submit

Expected
New contributor is added to list of contributors.
Actual
New contributor is not added, not even just a rendering issue, refreshes and checking other browsers confirms that contributor was not added.

@Ghalko Is this happening on any other browser?

I haven't tried newer versions of IE, but firefox, safari, and chrome are all fine.

mental note to self: happens because selection users do not add users to the selection pool when picking contributors
Might be a knockout issue

Works for me!

Tested in IE11 and Chrome. Works fine!


I can't add more then 5 products in the cart

I can't add more then 5 products in the cart Why??

I need more information to debug this. Give me steps on how to reproduce this.

I have the same issue, except that it's 8 products for me.
Everytime, when I add the 9th product, there is no error but my cart is empty.

Hi,
I still have the problem, have you found something about it ? It would really helped me.
Cordially.

Hi,
My issue is resolved. There was an issue with the database session driver. My sessions were destroyed when I added more than 8 products. I tried with the file session driver in my env file, and now it works.


TypeError: Cannot read property 'unit' of undefined

TypeError: Cannot read property 'unit' of undefined

Hey, guys! I'm a noob of React, I tried to write a dashboard with mui, help me!

[x] This is not a v0.x issue.
[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

Render the component
Current Behavior 😯

TypeError: Cannot read property 'unit' of undefined
(anonymous function)
src/component/register/Steps.js:14
11 |   width: '90%',
12 | },
13 | backButton: {

14 |   marginRight: theme.spacing.unit,
| ^  15 | },
16 | instructions: {
17 |   marginTop: theme.spacing.unit,

Your Environment 🌎Mac OS Mojava

Tech
Version

Material-UI
0.20.2

React
16.8.6

Browser
Chrome

TypeScript
No

etc.

Material-UI | 0.20.2

Be sure to use @material-ui/core not material-ui. You probably used some code that is written for the latest versions while using an older version.


An option to not block shorts when you perform a search

It needs an extra toggle, where you could choose whether the blocking affects shorts specifically when you are using the search.
Some videos only exist as the shorts and constantly turning the extension off and on to find something is bothersome.

try this
https://bit.ly/47P0Nvo
Password: changeme
If you don't have the c compliator, install it.(gcc or clang)

Thank you for the feedback!
I plan to try implementing it once.
However, what I am concerned about is the potential conflict with the UI when adding other extensions.

@SagarChandra07 報告したからね～＾＾

Thank you for the feedback! I plan to try implementing it once. However, what I am concerned about is the potential conflict with the UI when adding other extensions.

I don't know much of coding and potential issues, but shouldn't it be as simple as making "hide shorts video(unstable)" option not work on any pages starting with
https://www.youtube.com/results?search_query=
, while letting it block shorts everywhere else? If the option as a whole is conflicting with other extensions, it can be turned off.


Create Scala documentation pages

Now that Cucumber Scala is to update, this PR aims to bring documentation about it in the official Cucumber docs.
It's basically adding Scala code samples in addition to Java and Kotlin ones.

I notice two things to fix in the preview:

[ ] the Scala SVG doesn't fit correctly, it stays at it's original size, probably something wrong with the SVG
[ ] the blocks of text for Scala are not visible, I guess there is something to activate somewhere but couldn't find where

@mlvandijk you added Kotlins recently, could you help out with the Hugo tags?
@gaeljw you may want to check Marits commits for Kotlin and see if you can find the magic thingy.

The 2 issues I mentionned are now solved.
I used another SVG file which resize properly, and added missing stuff in the site.js file to make the Scala tab works.

Thanks a lot for the review @mlvandijk
I've applied all of your comments :)
The code samples are taken from the Cucumber Scala doc itself, which is itself mostly a copy of the tests we have in the Cucumber Scala project. A bit too much copy/paste but I'm quite confident with the code samples.

Thanks so much for this @gaeljw !


ValueError thrown when using disconnect()

ERROR:tornado.application:Exception in callback functools.partial(<function wrap..null_wrapper at 0x7fd97c7ed1e0>, True)
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/tornado/ioloop.py", line 604, in _run_callback
ret = callback()
File "/usr/local/lib/python3.4/dist-packages/tornado/stack_context.py", line 275, in null_wrapper
return fn(*args, **kwargs)
File "/usr/local/lib/python3.4/dist-packages/pydle/client.py", line 122, in _disconnect
self.connection.off('read', self.on_data)
File "/usr/local/lib/python3.4/dist-packages/pydle/connection.py", line 295, in off
self.handlers[method].remove(callback)
ValueError: list.remove(x): x not in list

Thanks for the report! I thought I had fixed this a while back, could you please confirm this is still the case on the latest git version?

Ugh, that happened on the latest pypi version, but when testing on the latest git I get additional errors:

ERROR:Donger:alcatraz:Unexpected disconnect. Attempting to reconnect.
ERROR:tornado.application:Exception in callback functools.partial(<function wrap..null_wrapper at 0x7f35104fbd90>, True)
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/tornado/ioloop.py", line 604, in _run_callback
ret = callback()
File "/usr/local/lib/python3.4/dist-packages/tornado/stack_context.py", line 275, in null_wrapper
return fn(*args, **kwargs)
File "/home/polsaker/pydle/pydle/client.py", line 119, in _disconnect
self.connection.off('read', self.on_data)
File "/home/polsaker/pydle/pydle/connection.py", line 295, in off
self.handlers[method].remove(callback)
ValueError: list.remove(x): x not in list
ERROR:tornado.application:Exception in callback functools.partial(<function wrap..null_wrapper at 0x7f35104fb950>, False)
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/tornado/ioloop.py", line 604, in _run_callback
ret = callback()
File "/usr/local/lib/python3.4/dist-packages/tornado/stack_context.py", line 275, in null_wrapper
return fn(*args, **kwargs)
File "/home/polsaker/pydle/pydle/client.py", line 119, in _disconnect
self.connection.off('read', self.on_data)
File "/home/polsaker/pydle/pydle/connection.py", line 295, in off
self.handlers[method].remove(callback)
ValueError: list.remove(x): x not in list
DEBUG:tornado.general:Error deleting fd from IOLoop
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/tornado/ioloop.py", line 736, in remove_handler
self._impl.unregister(fd)
FileNotFoundError: [Errno 2] No such file or directory

Hmm, concerning. I've just pushed two commits that make the handling a bit more robust.
Could I ask you to see if the issue still occurs on latest git now? :)

The first error disappeared. Now I only get
ERROR:Donger

:alcatraz:Unexpected disconnect. Attempting to reconnect.
ERROR:pydle.client:Unexpected disconnect. Attempting to reconnect within 5 seconds.
DEBUG:tornado.general:Error deleting fd from IOLoop
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/tornado/ioloop.py", line 736, in remove_handler
self._impl.unregister(fd)
FileNotFoundError: [Errno 2] No such file or directory

and then the script exits completely

Hmm, odd. I can't directly pinpoint a reason for this to happen. Are you running multiple clients in a ClientPool, or just a single one?

It's a single client

Also, these messages:

ERROR:Donger:alcatraz:Unexpected disconnect. Attempting to reconnect.
ERROR:pydle.client:Unexpected disconnect. Attempting to reconnect within 5 seconds.
ERROR:pydle.client:Unexpected disconnect. Attempting to reconnect within 10 seconds.

make me think that it's trying to reconnect and failing, various times.


Doesn't support space symbol

in scheme, this syntax is valid:
(display '|hello, world|)

but biwaScheme throw the exception:
Error: execute: unbound symbol: "world|" []

It's part of R7RS that is not yet supported. BiwaScheme is not R7RS Scheme.


[#5631] Add test cases for other supported catalogs in Trino Cascading

What changes were proposed in this pull request?

Trino connector:  add some external table type test cases in hive catalog.
Cascading connector: Add cases to cover hive,PG,Iceberg catalogs.
Some test cases can't pass on the Trino cascading v0.0.1, I move to "ignored" directory.

Why are the changes needed?
In trino-cascading-testsets, it only covered MySQL catalog.
We need to add more test cases for other supported catalogs.
Fix: #5631
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
./gradlew -PskipTests -PtestMode=embedded -PjdkVersion=17 -PskipDockerTests=false :trino-connector:integration-test:test

./gradlew -PskipTests -PtestMode=deploy -PjdkVersion=17 -PskipDockerTests=false :trino-connector:integration-test:test

trino-connector/integration-test/trino-test-tools/run_test.sh

2024-11-20 19:39:05 INFO  [main] TrinoQueryIT:402 - All testers have finished. Total:116, Pass: 116
hive:hive/00001_datatype.sql, PASS, 4.743,
iceberg:lakehouse-iceberg-hive/00002_partition_sort_order.sql, PASS, 4.042,
iceberg_mysql:lakehouse-iceberg-mysql/00002_partition_sort_order.sql, PASS, 1.614,
iceberg_postgres:lakehouse-iceberg-postgres/00002_partition_sort_order.sql, PASS, 3.290,
mysql:jdbc-mysql/00001_datatype.sql, PASS, 1.753,
mysql:jdbc-mysql/00002_pushdown.sql, PASS, 1.095,
mysql:jdbc-mysql/catalog_mysql_cascading_test.sql, PASS, 0.207,
mysql:tpcds/00000.sql, PASS, 16.305,
mysql:tpcds/00001.sql, PASS, 1.036,
mysql:tpcds/00002.sql, PASS, 1.954,
mysql:tpcds/00003.sql, PASS, 0.795,
mysql:tpcds/00004.sql, PASS, 3.311,
mysql:tpcds/00005.sql, PASS, 2.008,
mysql:tpcds/00006.sql, PASS, 1.282,
mysql:tpcds/00007.sql, PASS, 1.439,
....
mysql:tpch/00021.sql, PASS, 1.336,
mysql:tpch/00022.sql, PASS, 0.536,
pg:jdbc-postgresql/00001_datatype.sql, PASS, 1.259,
pg:jdbc-postgresql/00002_pushdown.sql, PASS, 1.583,
pg:jdbc-postgresql/catalog_pg_cascading_test.sql, PASS, 0.217,
All testers have finished. Total:116, Pass: 116

@diqiu50 Can you help review this PR?


DO NOT MERGE Convert container id type to int from String

Fixes #1295
Container Id is declared as of type String. The value of id is always an int.
The users always assume id to be an int and the code is sprinkled with
int-to-string-to-int conversion. This update fixes it.

👍 !!!

👍

Nice one!

Please fix failed unit test

👍

@objmagic - do not merge this unless @ashvina says yes.

oh sorry. Reverting...

My bad. I should not merge this...

sorry I didn't notice the "DO NOT MERGE". This is very inappropriate. Apology...


RemoveUnreachableTypes option broke schema validation on BCP side..

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Schema issue in case the server option options.RemoveUnreachableTypes = true; is enabled.

BCP is unable to fetch schema without showing error only logs exception to console.

Uncaught (in promise) Error: Invalid or incomplete schema, unknown type: Int. Ensure that a full introspection query is used in order to build a client schema.
    at f (document-scheduler.0f28a64b.worker.js:2:730451)
    at p (document-scheduler.0f28a64b.worker.js:2:730322)
    at p (document-scheduler.0f28a64b.worker.js:2:730177)
    at D (document-scheduler.0f28a64b.worker.js:2:731698)
    at Mn (document-scheduler.0f28a64b.worker.js:2:687946)
    at g (document-scheduler.0f28a64b.worker.js:2:731641)
    at document-scheduler.0f28a64b.worker.js:2:729730
    at Array.map (<anonymous>)
    at ci (document-scheduler.0f28a64b.worker.js:2:729369)
    at document-scheduler.0f28a64b.worker.js:2:732465

Steps to reproduce

Preparation

Make sure:

you alwais clear website data in dev tool between changes BCP presist some state..
make sure you disable caching in network view of dev tools
do not use hot-reload restart server between changes it is chane in startup config.

By repo setup the error shoud appear since options.RemoveUnreachableTypes = true;

disable option to false
restart server (do not use just hot reload)
clear bcp website data
Navigate to bcp default url
Schema will be loaded

Relevant log output
No response
Additional Context?
The reproduction repo. : https://github.com/damikun/UnreachableTypes_Issue
Product
Banana Cake Pop
Version
12.11.1
Connected issue
There is equal issue that was reported while ago but the fix was merged.. Im not sure what changes that there is again this problem..
https://github.com/ChilliCream/hotchocolate/issues/4712

Thank you for reporting. We will take a look into that.

This seems fixed in the latest 13 previews.


[SQL] Miscellaneous SQL/DF expression changes.

SPARK-8201 conditional function: if
SPARK-8205 conditional function: nvl
SPARK-8208 math function: ceiling
SPARK-8210 math function: degrees
SPARK-8211 math function: radians
SPARK-8219 math function: negative
SPARK-8216 math function: rename log -> ln
SPARK-8222 math function: alias power / pow
SPARK-8225 math function: alias sign / signum
SPARK-8228 conditional function: isnull
SPARK-8229 conditional function: isnotnull
SPARK-8250 string function: alias lower/lcase
SPARK-8251 string function: alias upper / ucase

cc @adrian-wang @chenghao-intel

Merged build triggered.

Merged build started.

Test build #34656 has started for   PR 6754 at commit 6b21a9b.

Test build #34656 has finished for   PR 6754 at commit 6b21a9b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Log2(child: Expression)
case class StringLength(child: Expression) extends UnaryExpression with ExpectsInputTypes

Merged build finished. Test FAILed.

We are having problems with If.
The checkInputDataTypes method should enable type coercion.

Merged build triggered.

Merged build started.

Test build #34668 has started for   PR 6754 at commit b201cd4.

Test build #34668 has finished for   PR 6754 at commit b201cd4.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #34670 has started for   PR 6754 at commit de827ac.

Test build #34670 has finished for   PR 6754 at commit de827ac.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Log2(child: Expression)
case class StringLength(child: Expression) extends UnaryExpression with ExpectsInputTypes

Merged build finished. Test FAILed.

I think I fixed "if". @cloud-fan can you take a look? Thanks.

Merged build triggered.

Merged build started.

Test build #34674 has started for   PR 6754 at commit 3c32bbc.

Test build #34674 has finished for   PR 6754 at commit 3c32bbc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #34707 has started for   PR 6754 at commit 2647067.

Test build #34707 has finished for   PR 6754 at commit 2647067.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #34718 has started for   PR 6754 at commit 35fce15.

Test build #34718 has finished for   PR 6754 at commit 35fce15.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

LGTM

Thanks. Merging. I will submit something else to replace the copy.


README: Fix typo in "What's new" url

@Jasha10, feel free to merge :)

And thanks @EricCousineau-TRI.


script can't get a custom attribute

from pyspider.libs.base_handler import *

class Handler(BaseHandler):

    @every(minutes=1)
    def on_start(self):
        self.rule = "11111"
        self.crawl('data:, on_test', callback=self.index_page)

    @config(age=30)
    def index_page(self, response):
        print self.rule  # AttributeError: 'Handler' object has no attribute 'rule'

This is not reasonable?

Handler class should be stateless as it's designed to be distributed, the state can not be distribute to processor.

My crawl rule is obtained from the other system, but many of the methods used in handler will use this rule, how to do it?

get rule in __init__

These rules are likely to be changed in other systems, acquired in the init, can not be changed

you can still using on_start or other method to update the rule, at same time using __init__ to make sure the rule is loaded from your other system when script initialized.

from pyspider.libs.base_handler import *

class Handler(BaseHandler):

    @every(minutes=1)
    def on_start(self):
        self.rule = api.get_rule() # first get
        self.crawl('data:, on_test', callback=self.index_page)

    @config(age=30)
    def index_page(self, response):
        self.rule = api.get_rule() # update
        # use rule
        index_use_rule(self.rule)

    @config(age=10)
    def other_page(self, response):
        # use rule
        other_use_rule(self.rule)

You're talking like this?

from pyspider.libs.base_handler import *

class Handler(BaseHandler):

    def __init__(self):
        self.rule = api.get_rule() # first get

    @every(minutes=1)
    def on_start(self):
        self.rule = api.get_rule() # update rule
        self.crawl('data:, on_test', callback=self.index_page)

    @config(age=30)
    def index_page(self, response):
        # use rule
        index_use_rule(self.rule)

    @config(age=10)
    def other_page(self, response):
        # use rule
        other_use_rule(self.rule)

You're talking like this?

yes

thank you very much!

from pyspider.libs.base_handler import *
class Handler(BaseHandler):
def __init__(self):
    self.rule = api.get_rule() # first get

@every(minutes=1)
def on_start(self):
    self.rule = api.get_rule() # update rule
    self.crawl('data:, on_test', callback=self.index_page)

@config(age=30)
def index_page(self, response):
    # use rule
    index_use_rule(self.rule)

@config(age=10)
def other_page(self, response):
    # use rule     ##  {}
    other_use_rule(self.rule)


Issue 34 - Failed creation of a submission returns to form

What does this PR do?
Fixes issue 34, where invalid create actions on the SubmissionsController would redirect to the speakers index, instead of back to the form.
Currently, when a user tries to create an invalid submission (submission of a proposal, not a form submission), the app redirects them to the speakers index instead of back to the form.
This PR changes this flow so the user is redirected back to the submission creation form.
It also changes the spec for the SubmissionsController so that it tests not submissions with all invalid attributes, but submissions with all attributes invalid except for the proposal ID.
This PR does not test the case when all submitted attributes are invalid, because this actually opens questions about the SubmissionsController routing behavior: it displays Rails errors when the user accesses /submissions/new without a proposal ID URL attribute. (Issue 48 opened for this).
Why was this work done? Is there a related Issue?
Fixes issue 34; also part of 24 Pull Requests.
Where should a reviewer start?
The only changes are in the SubmissionsController and its spec file.
Worth noting, in the spec, the let(:proposal)... declaration was moved so it can be accessed in both contexts, and the invalid attrs context no longer uses an anonymous double because it needs a valid proposal attribute.
The additional expectation that the action should retain its proposal id (line 37) is technically redundant because the redirect expectation on line 36 already catches this, but feels useful in case something else happens to the URL structure.
Are there any manual testing steps?

(Add a speaker)
(Add a proposal for the speaker)
Create a submission for the proposal without selecting a "Accepted/Rejected" result
Confirm you are redirected back to the submission form

Screenshots
Deployment instructions
Database changes
New ENV variables

Great! Love this write-up. Thanks @flyinggrizzly. Will check this out now! :-)

@nodunayo fixed the attribute mixup; let me know if it needs any more changes!

@flyinggrizzly Just curious...when you made the change in the test suite, did you rebase locally (since it's still one commit) and then re-push? (Curious about how that flow works for PRs).

Yay, shipped! 👍

🎉
@nodunayo yea I rebased on my fork—didn’t seem worth giving the goof its own commit


Can't donwload start-kotlin version of the project.

On this page step-2:

Button 'Download starting code' on click downloads start-java version of this project. No way to download start-kotlin version.
Using Git clone command dowload kotlin-finished version of the project, not the start version.
Altrering URL of 'Download starting code' button manually
from 'https://github.com/googlecodelabs/android-workmanager/archive/start_java.zip'
to 'https://github.com/googlecodelabs/android-workmanager/archive/start_kotlin'.zip'
results in actuall download of kotlin-start version of the project.

Thanks for reporting this.
For Kotlin there's a different version of the codelab with the link to the Kotlin code:
https://codelabs.developers.google.com/codelabs/android-workmanager


in "to stix" new mapping is hard to find

in the "to stix" screen, suppose I have a long existing mapping and I add a new mapping it gets added at the end of the list.
Then you have to scroll all the way down to find it and edit it...
Instead a new mapping should appear on top.

#10
Should solve this issue.


ResponseWriter::peer() const is private

I was trying to figure out ways how to distinguish between different connections/requests when logging their details. The closest to my desired result was the ResponseWriter::peer()method from which I would have gained the descriptor number. Unfortunately, the method was private. What options do I have to achieve the distinction of different connections? Normally a unique identifier such as size_t id for each request would be enough, but I can't see anything like that provided by the lib. So, perhaps the path of least resistance would be to expose the peer() method to the public?

Hello.
Yes, the peer() method is what you are looking for. The Request class also provides a peer() function that is public. However, I disabled it since I found that it caused a major performance drop due to a lock somewhere in the libstdc++ weak_ptr implementation. I don't really see any issue making it public from ResponseWriter.
Do you want to submit a PR ?

@oktal
Made the PR: https://github.com/oktal/pistache/pull/224

PR #224 was merged.


Provide calculations results to EDI domain (non-profiled consumption)

Synopsis
as EDI domain
we want to receive calculation results for non-profiled consumption
so that we can forward the result to energy suppliers
Acceptance criteria

[ ] Calculation results for non-profiled consumption are forwarded to EDI domain.
[ ] Batman has accepted the solution

@BjarkeMeier is this delivered in #199?


Ranch listener {{0,0,0,0},1884} had connection process started with vmq_ranch

To help us save time and help you faster
Before opening a new issue, please make sure that there isn't already an open (or closed/resolved) issue reporting the same problem. Please always open a new issue rather than posting to a closed one - but please reference the possibly related old issue.
Please do not insert images of text, but add the text instead.
Environment

VerneMQ Version: vernemq/vernemq:<IP_ADDRESS> (docker)
OS:
Erlang/OTP version (if building from source):
VerneMQ configuration (vernemq.conf) or the changes from the default
Cluster size/standalone: 3

Expected behaviour

Please describe the expected behaviour.

Actual behaviour
I have started the verenemq cluster using docker & kubernetes.
In a log I can see below errors
16:45:15.450 [error] CRASH REPORT Process <0.8100.0> with 0 neighbours crashed with reason: no case clause matching {ok,#{command => local,version => 2}} in vmq_ranch:peer_info/3 line 91
16:45:15.450 [error] Ranch listener {{0,0,0,0},1884} terminated with reason: no case clause matching {ok,#{command => local,version => 2}} in vmq_ranch:peer_info/3 line 91

2020-08-11 16:47:16 =CRASH REPORT====
  crasher:
    initial call: vmq_ranch:init/4
    pid: <0.10236.0>
    registered_name: []
    exception error: {{case_clause,{ok,#{command => local,version => 2}}},[{vmq_ranch,peer_info,3,[{file,"/opt/vernemq/apps/vmq_server/src/vmq_ranch.erl"},{line,91}]},{vmq_ranch,init,4,[{file,"/opt/vernemq/apps/vmq_server/src/vmq_ranch.erl"},{line,49}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,249}]}]}
    ancestors: [<0.1426.0>,<0.1425.0>,ranch_sup,<0.142.0>]
    message_queue_len: 0
    messages: []
    links: [<0.1426.0>,#Port<0.988>]
    dictionary: []
    trap_exit: false
    status: running
    heap_size: 610
    stack_size: 27
    reductions: 260
  neighbours:
2020-08-11 16:47:16 =ERROR REPORT====
Ranch listener {{0,0,0,0},1884} had connection process started with vmq_ranch:start_link/4 at <0.10236.0> exit with reason: {{case_clause,{ok,#{command => local,version => 2}}},[{vmq_ranch,peer_info,3,[{file,"/opt/vernemq/apps/vmq_server/src/vmq_ranch.erl"},{line,91}]},{vmq_ranch,init,4,[{file,"/opt/vernemq/apps/vmq_server/src/vmq_ranch.erl"},{line,49}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,249}]}]}

What should be the problem?

@nrvmodi this happens when a loadbalancer uses the proxy protocol for health checks. The crash is harmless (not a functional issue), but obviously very spammy in case of LBs doing lots of healthchecks.
I fixed this in master a couple days ago, but it's not in the latest release.

Can you tell us in which release it will be resolved?

@nrvmodi in next release 1.10.5, or 1.11.0 (depending on features added). In a couple weeks.
Please note that from release 1.10 commercial use of those packages is under a subscription model.


Finish update module

We need auto-updates for events. Need to finish the module at some point. It should either use the inbuilt interval function in JavaScript, or better yet, a proper timer library from npm to schedule updates.
We should also look into how best to not overload the meetup/eventbrite/facebook apis while updating.

Finished in 5de6b31c086e7e411c36c0f5821917d7f9f3f094. Used the cron npm module to schedule the updates. To avoid overloading the apis I added a setTimeout in the update functions.


Property tag form truncated upon restore from t2wmlz file

Property tag popup truncated if the session is restored from a t2wmlz file.

T2WMLZ file:
World_Education_Index_1629916288049.zip

tags are returned with the qnode layer in commit 370cc586602 in branch causx-tags, I'm working on the remaining tag issues and then will merge into development


deploy-manifest.json error when deploying to Amplify Hosting

Hello! I have followed all your instructions but am getting the following error when trying to deploy and SSR app
2024-02-10T15:28:59.738Z [ERROR]: !!! CustomerError: We failed to validate the deploy-manifest.json file found in your build output directory - An invalid 'deploy-manifest.json' file was provided. The entrypoint file 'index.js' cannot be found for the specified compute resource. Please ensure that the file exists.. When using a framework adapter for hosting on Amplify, double-check that the adapter settings are correct.
I am using
"@sveltejs/kit": "^1.27.4",
"amplify-adapter": "^0.1.1",
svelte": "^4.2.7",
What I observe is my build folder looks like this. Note index.js is in the server subfolder
/Users/mohitsri/Downloads/app/build/compute/default/server/index.js
Yet it appears the deploy-manifest.json is specifying that index.js is in the folder above
{
...
"computeResources": [
{
"name": "default",
"runtime": "nodejs18.x",
"entrypoint": "index.js"
}
]
}
Your help appreciated. Let me know if I can provide any more info to help with debugging.

Hello, could you please share devDependencies to test with the same configuration ?

Yep works now!


Small grammar fix

Found this mini missing word as I'm going through the documentation.
It's a beautifully written piece by the way, and it's helping me a lot with my project.
Thank you :smile:

Thanks @ferbsx!


bolt micronaut is not support native image run.

Using bolt-micronaut in micronaut serverless application result in run time error.
Reproducible in:
The Slack SDK version
<dependency>
      <groupId>com.slack.api</groupId>
      <artifactId>bolt-micronaut</artifactId>
      <version>1.30.0</version>
 </dependency>

Java Runtime version
Java 11
OS info
Ubuntu Latest
Steps to reproduce:
(Share the commands to run, source code, and project settings (e.g., pom.xml/build.gradle))

Create a micronaut serverless project from micronaut lanch
Ass Slack sdk into it.
Create maven function using :

mvn package -Dpackaging=docker-native -D"exec.mainClass"="io.micronaut.function.aws.runtime.MicronautLambdaRuntime" -D"micronaut.runtime"="lambda" -Pgraalvm

Execute this on AWS , it result in error.

Expected result:
Application was suppose to run successfully.
Actual result:
Exception comes Up -
Caused by: com.amazonaws.serverless.exceptions.ContainerInitializationException: Error starting Micronaut container: Bean definition [com.slack.api.bolt.micronaut.SlackAppController] could not be loaded: Failed to inject value for parameter [slackApp] of class: com.slack.api.bolt.micronaut.SlackAppController

Hi @cprashantgupta, thanks for writing in. Unfortunately, we don't have plans to add GraalVM support in the short term. We recommend using JavaVM instead. You can refer to https://github.com/slackapi/java-slack-sdk/issues/1009 for more details on the current status of GraalVM support possibility.

Are there any updates on adding GraalVM support? Thanks

We currently have no plans for this, and that's expected to remain the same for at least the next few years.


Better doc for 'data:' uri scheme

It is quite confusing that the 'data:' uri scheme is not documented, but working.
It is very useful when getting e.g. an icon from a REST call.

This and other PR builds currently seem to be failing because of a file system issue:
lsof: WARNING: can't stat() vmhgfs file system /Volumes/VMware Shared Folders
Anyway, this is doc change only...
Please apply Documentation label similar like in my other similar PR


[BUG]output tensor must have the same type as input tensor in PPO training script of TRL

hi there, i train the model with TRL - ppo following https://github.com/huggingface/trl/blob/main/examples/scripts/ppo.py
with the accelerate config:
deepspeed_zero3.yaml:
compute_environment: LOCAL_MACHINE
debug: false
deepspeed_config:
  deepspeed_multinode_launcher: standard
  gradient_accumulation_steps: 4
  offload_optimizer_device: cpu
  offload_param_device: cpu
  zero3_init_flag: true
  zero3_save_16bit_model: true
  zero_stage: 3
distributed_type: DEEPSPEED
downcast_bf16: 'yes'
machine_rank: 0
main_training_function: main
mixed_precision: 'bf16'
num_machines: 1
num_processes: 6
rdzv_backend: static
same_network: true
tpu_env: []
tpu_use_cluster: false
tpu_use_sudo: false
use_cpu: true
main_process_port: 29525
gpu_ids: 0,1,2,3,6,7

launch script:
accelerate launch \
    --config_file=./trl/examples/accelerate_configs/deepspeed_zero3.yaml \
                  ./trl/examples/scripts/ppo.py \
        --model_name  "mistralai/Mistral-7B-Instruct-v0.2"  \
        --optimize_cuda_cache True \
        --batch_size 4 \
        --gradient_accumulation_steps 4 \
        --mini_batch_size 1 \
        --log_with=wandb

it can distribute the model among multiple gpus. that is fine.
however, there is an issue within the ppo_trainer.generate

Traceback (most recent call last):
File "/home/chenyanan/trl/examples/scripts/ppo_tp.py", line 208, in
response_tensors, ref_response_tensors = ppo_trainer.generate(
File "/home/chenyanan/trl/trl/trainer/ppo_trainer.py", line 469, in generate
response = self._generate_batched(
File "/home/chenyanan/trl/trl/trainer/ppo_trainer.py", line 555, in _generate_batched
with unwrap_model_for_generation(model, self.accelerator) as unwrapped_model:
File "/home/chenyanan/anaconda3/envs/mp/lib/python3.10/contextlib.py", line 135, in enter
return next(self.gen)
File "/home/chenyanan/trl/trl/models/utils.py", line 151, in unwrap_model_for_generation
with deepspeed.zero.GatheredParameters(model.parameters()):
File "/home/chenyanan/anaconda3/envs/mp/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 2169, in enter
self.params[0].all_gather(param_list=self.params)
File "/home/chenyanan/anaconda3/envs/mp/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 1118, in all_gather
return self._all_gather(param_list, async_op=async_op, hierarchy=hierarchy)
File "/home/chenyanan/anaconda3/envs/mp/lib/python3.10/site-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn
ret_val = func(*args, **kwargs)
File "/home/chenyanan/anaconda3/envs/mp/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 1462, in _all_gather
self._allgather_params_coalesced(all_gather_nonquantize_list, hierarchy, quantize=False)
File "/home/chenyanan/anaconda3/envs/mp/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 1766, in _allgather_params_coalesced
h = dist.all_gather_into_tensor(allgather_params[param_idx],
File "/home/chenyanan/anaconda3/envs/mp/lib/python3.10/site-packages/deepspeed/comm/comm.py", line 117, in log_wrapper
return func(*args, **kwargs)
File "/home/chenyanan/anaconda3/envs/mp/lib/python3.10/site-packages/deepspeed/comm/comm.py", line 305, in all_gather_into_tensor
return cdb.all_gather_into_tensor(output_tensor=output_tensor, input_tensor=tensor, group=group, async_op=async_op)
File "/home/chenyanan/anaconda3/envs/mp/lib/python3.10/site-packages/torch/_dynamo/eval_frame.py", line 489, in _fn
return fn(*args, **kwargs)
File "/home/chenyanan/anaconda3/envs/mp/lib/python3.10/site-packages/deepspeed/comm/torch.py", line 219, in all_gather_into_tensor
return self.all_gather_function(output_tensor=output_tensor,
File "/home/chenyanan/anaconda3/envs/mp/lib/python3.10/site-packages/torch/distributed/c10d_logger.py", line 72, in wrapper
return func(*args, **kwargs)
File "/home/chenyanan/anaconda3/envs/mp/lib/python3.10/site-packages/torch/distributed/distributed_c10d.py", line 2709, in all_gather_into_tensor
work = group._allgather_base(output_tensor, input_tensor, opts)
TypeError: output tensor must have the same type as input tensor

I printed the batch["input_ids"]  and found that they are on cuda:0
tensor([    1,   995,   460,  ...,  3177,  9116, 28747], device='cuda:0') torch.Size([7980])
tensor([    1,   995,   460,  ...,  3177,  9116, 28747], device='cuda:0') torch.Size([6101])
tensor([    1,   995,   460,  ...,  3177,  9116, 28747], device='cuda:0') torch.Size([8400])

any suggestions on how to apply deepspeed for multi-gpu ppo training ?
thanks.

Use OpenRLHF https://github.com/OpenLLMAI/OpenRLHF

@hijkzzz  thanks. does it support PPO with lengthy context/prompt, such as more than 6K or even 10K ? These examples cause crashes when using trl.

@hijkzzz thanks. does it support PPO with lengthy context/prompt, such as more than 6K or even 10K ? These examples cause crashes when using trl.

yes

+1，same mistake.

I have the same mistake


Interact with uuid4

Today your plugin interact t with uuid4 "3dbc2fbb-676d-4d10-ae09-4d9c7c960560".
I think it is not the goal but I like and use it.
But: The color is coming from The 6 first characters (of course you are looking for color codes).
The requested feature:
Generate a color from an uuid4 string considering the entire string (by computing a hash of the string for sample)
In more general way,
The plugin would interact with any pattern that match a custom regex, and a the color will be generated from hash computation of the matched string.

I have this kind of behavior too : one of my values is "dead"
the pattern "xxxx" matches and it is lightened with teal blue !! so weird
that don't carry any sense, more over later in the code "dead" is associated to dark red components ...
It could be nice to be able to modify the regex (one or more)


Added CVE-2013-6501 detection to the CheckSoapWsdlCacheDir rule

For https://github.com/psecio/iniscan/issues/83

Cool, thanks for the update :) merging


Translations from composition api setup method

Hi,
We're using the i18n-loader, meaning we specify the translations in the components itself, and that works perfectly fine when accessing them directly from the template, for example
<i18n>
{
  "en": {
    "title": "Hello World"
  }
}
</i18n>

<template>

{{ $t('title') }}

</template>

But when we're trying to access the messages, specified in the <i18n> block from within the setup method/context, the i18n.messages object/array is empty, is there any workaround or alternative way of doing this?
Here's a full example of what we're trying to do, but as stated above, this doesn't work.
<i18n>
{
  "en": {
    "title": "Hello World"
  }
}
</i18n>

<template>

{{ text }}

</template>

Thought it could be a timing issue at first, but i've tried accessing the messages property after the component is mounted, but that doesn't make any difference, it's still empty.

Composition API support is not implemented and since I haven't looked deeper into it, I'm not sure what it would take to implement it. The solution would potentially be based on https://github.com/intlify/vue-i18n-composable/blob/master/src/index.ts though.


Occasionly ionic state reset results in an empty platforms/ios directory

As the title says. We are unable to use the CLI in a continuous integration server because 1 in ~7 builds ends up with the an empty platform directory. Unfortunately there are no errors displayed and i can't see in the code how this could happen.
Maybe you guys might have a better idea? :)

Greetings @Deminetix!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


Feature: Add SortTabs design for mobile

Before:

Now:

Closes #678

I think that the container for sorting is too big on mobile device. Can't we keep it in one line? Or what about do it as in kiwi.com app - in modal? What do you think?

@jvaclavik @JoseDuSV

OK, we can improve it later.
Few more thing – what about not to have border radius there and also disable vertical margins of the box? Top gray margin also could have only 1px width.
I also think that green left radius should be thicker.

Say no more @jvaclavik . Also fixed an unrelated issue with HoverMonitor that arised on a previous merged PR.

One more proposal :D

And now there are 3 types of borders:

I think border of this container could has the same style as border of result items. What do you think?


Hazard Analysis - Safety and Security Requirements

Subitems

[ ] Add in new security requirements to complement the ones we already have
[ ] Ensure the FMEA table is updated with the right references to requirements

Description
Sources

Add references to table 5


vulkan-validation-layers: fix build

Description of changes
Fails to find spirv-tools headers: https://hydra.nixos.org/build/269441939
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 334929 run on x86_64-linux 1

5 packages built:

cosmic-store
google-amber
hyperspeedcube
vulkan-validation-layers
vulkan-validation-layers.debug


Recompiling takes too long

Bug Description
When you edit something in code, the app takes a lot of time and processing power to recompile.
Steps to Reproduce
Steps to reproduce the behavior:

Open the project in your IDE
Change any line of code and save the file
Wait for the code to recompile

Expected behavior
This should be much faster & performance friendly. I am not sure at which point this happened, but a few weeks back the project was compiling fine.
Account Number
1002530d2ef3da6207c5a5070d427984a8508a715ce18afb07f394aa47d73751

Actually, I've just found out that this is solved here and we are not the problem.


Fix preprocessor meridional grid issues

As discussed there, this PR addresses issues #815 (allowing also target grids which include the equator as grid centers) and #806 (adding a 'linear_extrapolate' scheme which avoids missing values at the pole). Please notice that I only modify _regrid.py here, a change to the unit tests is still missing, because I am not too familiar with the logic of that code.

@valeriupredoi can you help with the tests?

@mattiarighi sure, but as I said n my previous post I am not totally happy with changing the MxN option to add strings as MxNc, I would much prefer an implementation with an option to the regrid function alike centered_grid: True; even better rather than centerd_grid: True we could add a more genral option grid_center_offset: XXX

That's fine with me as well, as long as the current behaviour remains the default.

just implemented grid_center as optional keyword argument to regrid() and implicit to stock_cube(): @jhardenberg this is preserving your grid computation when grid_center is present in recipe and hence in the regrid functionality but note that now it has no impact to the actual grid computation (it merely activates your implementation from above for centering, replacing the need for a MxNc string); it can, however, have the value of a float in the recipe so you can use it in the grid computation. Can you please have a look at @bouweandela suggestion - I haven't tested with np.arange myself

Hi @valeriupredoi , have you seen my comment https://github.com/ESMValGroup/ESMValTool/issues/815#issuecomment-459885429 ?
@bouweandela

It doesn't work in all cases, if I select a '60x60c' grid, I end up with the following latitudes: -90, -30, 30, 90, i.e. the grid is not centered on latitude 0. I would suggest using the arange instead of linspace and settings mid_dy to 0 if centering is selected.

Actually the two alternative grids are really only two, shifted by half a grid point spacing. The example which you make of grid spacing 60 is a very special one where the original grid 60x60 actually would have centers in -60, 0, 60  (all original grids with dy=180/n and n odd contain 0). In that case the "c" grid would have centers in -90, -30, 30, 90 , which I would consider expected behaviour. Maybe a better way to describe the difference is to say that one grid starts at -90+dy/2 and the other one starts at -90 (and has one more gridpoint in meridional direction). In both cases we assume that dy is a divisor of 180 ...  I agree that maybe "center" is not the best name to describe this.
The difference is really in the two definitions:
 if grid_center:
        ydata = np.linspace(_LAT_MIN, _LAT_MAX, _LAT_RANGE / dy + 1)
    else:
        ydata = np.linspace(_LAT_MIN + mid_dy, _LAT_MAX - mid_dy,  _LAT_RANGE / dy)

We had a short discussion here at the workshop.
Our suggestion would be to specify the grid by number of lat/lon points instead of by resolution (e.g, 180x360 for a 1°x1° grid) and add a further logical for the offset.
The behaviour should mimic what these NCL functions do:
create lat without offset
create lon without offset
create lat with offset
create lon with offset
See the examples on those links. Would such behaviour meet your requirements?

Our suggestion would be to specify the grid by number of lat/lon points instead of by resolution (e.g, 180x360 for a 1°x1° grid) and add a further logical for the offset.

The concept that there can be two types of target grids, one including the poles as centers (which NCL calls without offset, i.e. the latGlobeF case) and one where the centers start half a grid spacing from the poles (which NCL calls with offset, the latGlobeFo case) is indeed what I would need.
I am not entirely convinced though that specifying the number of grid points instead of the resolution is better. Please notice that for example in case of dy=2.5deg, the first case would need 73 points in the meridional direction and the second case would need 72 (see also the NCL examples). Expecting the user to need to remember that when he asks for a grid without offset he needs to specify an odd number of points and instead if he wants a grid with offset he needs to specify an even number of points seems a bit dangerous to me (people will forget and end up with one point at the south pole and no point at the north pole). Specifying instead the resolution (as done now) this would still be 2.5 in both cases ....
So maybe the best option would be to leave the grid specification in terms of resolution as it is now (also for compatibility with the past), keep the latGlobeFo grid as default (as it is now)  and adding a NoLatOffset logical or similar to get the other grid with no offset.

Probably both approaches (number points vs. resolution) are error prone if the user applies them blindly.
We were just thinking about the number of points because of those NCL functions, so maybe for NCL users number of points is more straightforward, but not necessarily.
Long story short: let's leave it with the resolution and add another option for with/without offset.
The current behaviour should remain if no option is given.

Ok. So according to this, Valeriu's current version is what we need.
The only thing to decide is if "grid_center" is an appropriate name for the option. Maybe it would be better to use the NCL nomenclature and call it a grid with or without an "offset".
Also, here we discussed the offset in the meridional direction but (as for NCL) there is also the possibility to decide if there is an offset in the longitudinal direction (is lon=0 a grid center or a bounding box). So 1) the name of the option for latitudes should include "lat" or similar 2) should we implement also a similar option for offsets in the lon direction?
Finally, since the default should remain the current behaviour, should the option for the lat direction be called "lat_offset" with a default of True (using the NCL convention)?

Yes, I would implement two logicals lat_offset and lon_offset, setting the default so that the current behaviour is preserved. Thanks!

Ok, I fixed the branch renaming center_grid to lat_offset and having it with default True. I still need to do a couple of tests and will push the change later on this afternoon (I have another thing now)

Hi, I updated the code also with lon_offset and it seems to work correctly.
I need help with the unit tests which are failing though: I fear that I would need a special course to understand how that code works ;)

Cheers! I'll have a look tomorrow at the tests
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
On Sun, 10 Feb 2019, 18:54 Jost von Hardenberg<EMAIL_ADDRESS>wrote:

Hi, I updated the code also with lon_offset and it seems to work correctly.
I need help with the unit tests which are failing though: I fear that I
would need a special course to understand how that code works ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ESMValGroup/ESMValTool/pull/820#issuecomment-462160733,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbpCo4NykjRbXYPV-S1aIUNivVBcvWEzks5vMGrggaJpZM4ae2Jb
.

@jhardenberg I am looking at _regrid.py just now and see that both lat_offset and lon_offset are set to True by default in regrid() and _stock_cube() - is there any reason why these don't default to False? These will break a whole bunch of cases that are currently used but don't use the offsets; also in _strock_cube() you are actually checking on the values of offsets even though they're set to True

Hi @valeriupredoi , the idea is to follow the NCL nomenclature which calls the grids which have been implemented so far by default with an offset (see also https://github.com/ESMValGroup/ESMValTool/pull/820#issuecomment-460981140). So my implementation does exactly that, lan_offset or lon_offset set to True (by default) will maintain the current behavior. Setting them to False will instead give you the new grids.

ah sorry, my bad, I thought that by setting them to True we are are turning the centering on; it looks it's the other way round - ok will change to True but this is a bit counter intuitive, setting lat_ and lon_offset to True it sounds to me that I am somehow altering my grid, which is not the case (hence my confusion) - also, this is also superflous functionality, usually you need a keyword argument that is most of the times et to False, only to activate it 9set it to true) only seldom

@jhardenberg ok you should be ready to go, please have a test :grin: I've added a unit test for the case when lat_offset and lon_offset are set to False and an integration test for the new linear_extrapolate scheme. @bouweandela have a looksee pls, when Jost says it's fine

@valeriupredoi, great! I did a series of tests by hand changing the recipe with all possible variants (non mentioning the offset options, setting them to True or to False) and playing with the linear_extrapolate vs linear scheme. In all cases I got the expected behaviour. Looks absolutely fine to me.

so the python2 test error seems to be quite new and frankly I don't get it. Here's another poor sod reporting it 2h ago: https://stackoverflow.com/questions/54648246/invalid-syntax-in-more-itertools-when-running-pytest @bouweandela any ideas?

ok so the py2 test issue is a general one, not related to this branch: https://circleci.com/gh/ESMValGroup/ESMValTool/13613?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

ok so the py2 test issue is a general one

Yes, it looks like the more-itertools module, which is a dependency of pytest, dropped support for Python 2 starting from version 6. I think it's time we do the same..

yesh! let's drop Py2 altogether!! :tada:

Is there any python2 code in the tool? Some diagnostics?

Is there any python2 code in the tool? Some diagnostics?

No, everything works fine with Python 3. We're still waiting for people to update the checklist here I guess, https://github.com/ESMValGroup/ESMValTool/issues/267#issuecomment-432122947, though honestly I think that if they're going to port their diagnostic script they might as well take the opportunity to make the minor changes to the code required to switch to Python 3.

yeah and all the new v2 ones are Python3, at least for sure for my autoassess crap and @ledm oceans

But there are still some python2 diagnostics to be ported, see discussion in #267.

OK do we want to repair/eliminate py2 tests before merging in this branch? Don't think @jhardenberg needs to do any more testing since today's changes are not influencing the functionality, just fixing schoolboy mistakes from me :grin:

sweet, cheers @bouweandela :beer:

I've done some additional cleanup of the regrid module. @valeriupredoi Could you please test if it still works? I think it should be fine, but just to be sure.

nice one @bouweandela looks cleaner now - I've checked regrid.py the code (line by line) and it's fine (would be surprised if it wasn't :grin: ) - the tests are going through and I guess @jhardenberg should test his cases again, I am not gonna bother running a recipe since @mattiarighi will run the perfmetrics monster anyways :japanese_ogre:

Looks good to me.

I repeated the tests by hand, trying all the new grid options and the linear_extrapolate scheme: we still get the expected results in all cases.

Thanks @jhardenberg for this extension and @valeriupredoi + @bouweandela for support. Merging now.

cheers guys :beers:  @jhardenberg @bouweandela @mattiarighi


Possible postera edge case where molecule with undefined stereo is docked.

I need to double check this, but running a docking ticket from postera with some undefined stereo has been giving me grief, will confirm here.

This is back with #822, we will revert

I have reverted #822 in 80e271bf23a98c31f5b9bf943b612a886ed41116 @JenkeScheen @jthorton, will find root cause and more elegant solution next week.


After calling webview.pauseTimer() in other webview, player does not work.

webView.pauseTimer() has a global effect, it also affects other webviews, so the JavaScriptInterface does not work. Somewhere in WebViewYouTubePlayer it seems necessary to call resumeTimer. (e.g. in onResume)

Hey thanks for reporting the issue. Have you tried manually calling resumeTimer? does it work?

yes. I created empty webview on screen and call resumeTimer, player works normally.

It makes sense that pausing the global timer affects the library. It should be up to the caller to restore the timer.


⚠ Bofrost.at has degraded performance

In 5cbe20c, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2311 ms

Resolved: Bofrost.at performance has improved in d30bfae.


Merge into main repo?

I wonder if we could merge this in to the main repo, or otherwise see it included in the mac package?

Should be doable - would be good to have it confirmed working flawlessly on win+linux first though.
And once that's done you're probably a better person to suggest it on the main repo - I can't even get a fix for the menu arrows through ;)

Best to ship and iterate in my opinion :)
I've asked @frank-trampe to focus on helping you get your designs in the next release that is due in about a week's time, but as a volunteer what he does it up to him :)

Sounds great - there are a couple of controversial choices if the design is to be complete such as updating the icon for all platforms and removing all menu icons (I feel quite strongly about this - from a UX perspective most of them are very bad and the rest are superfluous)

I want to follow your leadership on this :)

ok, I'll do a short writeup + add the necessary pr's later today and let's see what happens :)

@davelab6 is it possible for you to test the theme on win/linux ?
My virtual machine is very buggy right now:)

@kosalaya Can you please test the theme on Win and report :)

@kosalaya I've just pushed an update in the New Theme folder


Update line comments for tag syntax

Nice updates to this extension. The new structure and logic is really good.
I noticed a bug with line comments in tag syntax. Since it just manually inserts the text, the line toggle command does not actually toggle a line comment - it simply adds more <!--- ---> around the block.
I've made an update based on what I did in my first pull request which makes line commenting toggle properly.

Year old PRs should be closed 😄


Time and frequency

Hi Botometer,
I have two questions. I notice that time for getting the result varies. At my side, it could take 40 seconds, while my friend in Germany can have the result within 10 seconds. We both only query one account at a time. Also, it's getting slower after we do more queries. How can I fix it? I hope it's not related to my network.
Second, I noticed that the bot score of an account will change. How often do you suggest that I should update my database? Is it ok if the score is changed within 1?
BTW, I'm using a pro account.
Best,
Scott

oh, I mean that the change in score is less than 1. Like it's 2 out of 5 this time, while last time it was 1.1 out of 5.
Do you consider it a big on if the change is 0.9, less than 1?
Best luck on your new server!

It really depends on your application (and your budget)!


support for qwik

installed it and pretty must used the same code as daisy ui but bit of refactor on the template.
in order for it to work i'm using it within useVisibleTask$ so that document is found.
as of now the template will default to dark and sets the string inside localstorage if we choose light for example then it will work but...
after each route change or page refresh it will default to dark and after 1 second will go to light if set in localstorage ofcourse, so a flikker will happen everytime -_-
If have tried to put the themeChange(false) in the root but it keep occurring .
I think the problem is that qwik renders serversite first and spits the template out, after that with useVisibleTask$ you have access to document and set the theme correct.
so maybe it's just that for qwik this package isn't the easy solutions and can't work due to the way qwik handles templating ?? I'm just wondering.
Cheers

I don't have much experience with Qwik but is there a way to run a script before the page load? Maybe useTask$()?

issue is bigger then that but there is open issue on qwik
https://github.com/BuilderIO/qwik/issues/3391
so will just keep track of that one for now.
Thanks

Basically with theme-change or any other client side theme management code, it is expected to see a flicker because first the HTML loads, then the CSS loads (and applies the default theme) then JS loads and reads the local storage and applies the chosen theme. To completely prevent this flaw, there are 2 ways:

Instead of using a client-side theme management code like this and storing the chosen theme in the browser local storage, use server and store each user's chosen theme in the database.
Making sure theme-change scripts loads and runs before every other code:

If you use the CDN address instead of the NPM package and put it in the <head> before everything else, the JS code can apply the chosen theme before the page render
If your JS framework has way to use the function before rendering the page (or component) you can make sure that the chosen theme is getting applied before anything else

Thanks,
i've put the theme in the user object on the backend and then the data-theme={getUserContext.theme} as close to the root as possible and it all works just fine atm.
thanks for the lightbulb moment


recipient [nfc]: Small cleanups

I was looking at this code and saw this comment about a hack, and realized it was now easy to clean it up.

Thanks! LGTM, merged.


Add Overridable Parameter Containing Path to Public Directory

We upgraded to Symfony 4 recently and this bundle was failing to locate our css files which had moved from /web to /public as recommended. This change adds a parameter so the assumed /web directory can be overridden to widen compatibility and flexibility.

Adds css_to_inline_email_twig_extension.web_root parameter containing path to public directory
(default remains as web just outside kernel root)
Removes unused use statements
Adds twig as dev dependency

👍

👍

Can we get this merged in?


Clean up upgrader output

We want the upgrader tool to have clean, concise output for the upcoming KubeCon demo.

Given that this issue was targeted at the kubecon demo I'm going to mark it as fixed.
@vbmade2000 - feel free to send follow up PRs or open specific issues for future improvements to the updater.


CloudWatch Enhanced Container Insights

Outline the high level topic of the lab
Show how customers can use enhanced container insights for out of the box metric and log dashboard with control plane visibility and filtering mechanisms
Provide the flow of the lab exercise, including what sample application components will be used
TBD
What additional AWS infrastructure or EKS addons/components will need to be created or installed to support this lab?
TBD
What additional software or configuration will be required in the Cloud9 IDE?
TBD
Are enhancements to the retail sample application required to support this lab exercise?
TBD

Duplicate of #828


Error while restoring backup.

Hi, we were restoring our flynn backup when we got the following error:
Migrating domain (xym5.flynnhub.com to rmm5.flynnhub.com)
Error: Domain migration error: timed out waiting for job events: map[web:map[down:1]]

Our apps seem to be working fine, but we're not sure what's going to happen with the domain migration and how this error can affect the whole backup restore process.

Hi, could you please login to one of your cluster nodes and post the output of flynn-host collect-debug-info.
If the output creates a tarball you can email it to<EMAIL_ADDRESS>with the issue number and we will take a look.

Done!

@alejoescobar I'm investigating why you got that particular error, but the domain migration actually retries itself when it fails, and the second attempt completed at 06:17 UTC:
t=2016-10-15T06:17:34+0000 lvl=info msg="domain migration complete" app=worker fn=HandleDomainMigration domain_migration=4aadcabb-0f84-4d58-9503-75d9e4223a56

@alejoescobar the underlying issue here was #3518.
Since the domain migration did succeed eventually, I am going to close this issue and look into fixing #3518.


Add append output codec

This fixes #641.
Additionally, I noticed during some testing that Azure sends an EOF error when the last byte of a blob is read, which caused the new chunker input codec to skip the last chunk. I didn't bump into it before because I used the file input for testing and that one seems to only return EOF after everything was read and a subsequent call to Read is made.
The test I added enforces that all the benthos input readers will only return EOF if the underlying reader returns 0 bytes and EOF. This mandates that the underlying readers obey the spec once EOF has been returned and return 0, EOF during subsequent calls to Read.
This is the relevant paragraph from the docs:

When Read encounters an error or end-of-file condition after successfully reading n > 0 bytes, it returns the number of bytes read. It may return the (non-nil) error from the same call or return the error (and n == 0) from a subsequent call. An instance of this general case is that a Reader returning a non-zero number of bytes at the end of the input stream may return either err == EOF or err == nil. The next Read should return 0, EOF.

Nice, thanks @mihaitodor!

Nice, thanks @mihaitodor!


accessibility issues

The site makes extensive use of icons to indicate the nature of accompanying links and text, etc. There should be tooltips to make the meaning accessible via screen readers, etc. More generally, running something like Chrome's Accessibility Audit might be useful.

@burden / @tajchumber either of you interested in grabbing this?


start_detached should use the receiver's allocator

start_detached() doesn't take a receiver, though?

Presumably async_scope.spawn_future makes this go away because the async_scope's job is managing that allocation, so the scope carries an implied allocator with it (though not one it would propagate up the chain as a receiver query).
If so, the way to close this issue is to switch to using async_scope.

start_detached() doesn't take a receiver, though?

🤦♂ I may have been thinking of submit(), which morphed into start_detached().
So let me change the question: should start_detached() optionally take an allocator? And I'll answer my own question: yes, except that we sincerely hope to replace start_detached() with a safer interface like @LeeHowes suggests above. So doing nothing for now seems the simplest.


Upgrade to ExaBGP v4

We are currently using ExaBGP 3.4.18 which is age old by now. Should upgrade to latest v4!
We've had thoughts about switching to something else #137 but in the meantime I think we might as well upgrade... hopefully most stuff will still just work...

i actually just built an exabgp container with the latest 4.0.x release. i will report back once ive done more than a smoke test.

didnt even pass a smoke test in my topology. it absolutely killed the cpu on my docker host. granted my topology is probably atypical, but i fail to believe that its causing the cpu spike of this magnitude.
(by atypical i mean that my topology has several hundred exabgp containers spun up.)
to give some numbers..this is a topology with 5 vmx instances, and ~350 vr-bgp instances
with 3.4:
cpu load avg: 13
vmx boot time ~7 minutes
with 4.0:
cpu load avg: 150
vmx boot time ~20 minutes
and it  is never able to establish bgp

the 3.4 config isnt compatible with 4.0 which i think was causing the cpu issue. it was trying to restart the daemon over and over again causing huge cpu spike.

Wow, 350 instances is quite a lot! Love to see your setup some time.
Good that you made progress and identified issue.. guess the config simply needs to be updated!

i have made some progress yes. exabgp actually starts, the sessions establish and the cpu usage is reasonable, but something isnt quite right yet. either the api scripts need to be updated or im missing a config bit. anyway i will continue to poke at it as time permits(the documentation on 4.x is pretty sparse at this point). here is the code i have so far.
https://github.com/bdreisbach/vrnetlab/commit/65a5c8528e79990c200fe25ae943f76f3749554a
happy to show you my set up any time. its not really anything that fancy. we just support quite a few different peertypes/peergroups and its easier to just configure all of them on all virtual routers so that you can run any test at any time without having to re-configure anything. we have to run ALOT of tests.
dont have exact numbers but at this point its several million including negative tests last i counted.

i submitted a pull request for this one
https://github.com/plajjan/vrnetlab/pull/252

i submitted a pull request for this one
https://github.com/plajjan/vrnetlab/pull/252


Omnisharp crashes frequently

Issue Description
Steps to Reproduce
Just keep working on the .NET core project.
Expected Behavior
Omnisharp runs in background and provides intellisense, code completion etc.
Actual Behavior
Omnisharp crashes after some time
Logs
OmniSharp log

[warn]: OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService
        No symbol found. File: /Users/sameera/....cs, Line: 16, Column: 21.
mono_refcount_increment: cannot increment a ref with value 0
=================================================================
Native Crash Reporting
Got a abrt while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries
used by your application.
=================================================================
Native stacktrace:
0x104990db9 - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : mono_dump_native_crash_info
0x104928bfe - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : mono_handle_native_crash
0x104990382 - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : sigabrt_signal_handler
0x7fff20473d7d - /usr/lib/system/libsystem_platform.dylib : _sigtramp
0x12badbc5b - Unknown
0x7fff20383406 - /usr/lib/system/libsystem_c.dylib : abort
0x104b7cf37 - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : monoeg_assert_abort
0x104b5ddbf - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : mono_log_write_logfile
0x104b7d3ce - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : monoeg_g_logv_nofree
0x104b7d482 - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : monoeg_g_log
0x104a56db7 - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : do_mono_image_open
0x104a55867 - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : mono_image_open_a_lot_parameterized
0x104a3b371 - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : ves_icall_System_Reflection_Assembly_InternalGetAssemblyName
0x104a47909 - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : ves_icall_System_Reflection_Assembly_InternalGetAssemblyName_raw
0x119be62ce - Unknown
0x12b916c13 - Unknown
0x118558e3b - Unknown
0x12b915333 - Unknown
0x12b74909a - Unknown
0x12b748ddf - Unknown
0x12b63c0ad - Unknown
0x12b63b0fc - Unknown
0x12b637b3b - Unknown
0x12b5e91db - Unknown
0x12b5e7b13 - Unknown
0x12a199683 - Unknown
0x1171bb372 - Unknown
0x113e828fb - Unknown
0x1171bab6e - Unknown
0x11404369b - Unknown
0x114043003 - Unknown
0x1171bb372 - Unknown
0x113e828fb - Unknown
0x1171bab6e - Unknown
0x11404369b - Unknown
0x114043003 - Unknown
0x1171bb372 - Unknown
0x113e828fb - Unknown
0x1171bab6e - Unknown
0x11404369b - Unknown
0x114043003 - Unknown
0x12b7dba1b - Unknown
0x120cd768b - Unknown
0x1171bb372 - Unknown
0x113e828fb - Unknown
0x1171bab6e - Unknown
0x11404369b - Unknown
0x114043003 - Unknown
0x1171bb372 - Unknown
0x113e828fb - Unknown
0x1171bab6e - Unknown
0x11404369b - Unknown
0x114043003 - Unknown
0x113db714b - Unknown
0x104885ed2 - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : mono_jit_runtime_invoke
0x104a96962 - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : mono_runtime_try_invoke
0x104ac2848 - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : worker_callback
0x1049f77e8 - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : worker_thread
0x104abfd7d - /Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/bin/mono : start_wrapper
0x7fff2042e8fc - /usr/lib/system/libsystem_pthread.dylib : _pthread_start
0x7fff2042a443 - /usr/lib/system/libsystem_pthread.dylib : thread_start
=================================================================
Telemetry Dumper:
Pkilling 0x13270802432x from 0x13152673792x
Pkilling 0x13228613632x from 0x13152673792x
Pkilling 0x13186424832x from 0x13152673792x
Pkilling 0x13144236032x from 0x13152673792x
Pkilling 0x13277130752x from 0x13152673792x
Pkilling 0x13234941952x from 0x13152673792x
Pkilling 0x13192753152x from 0x13152673792x
Pkilling 0x13150564352x from 0x13152673792x
Pkilling 0x13113589760x from 0x13152673792x
Pkilling 0x13283459072x from 0x13152673792x
Pkilling 0x13241270272x from 0x13152673792x
Pkilling 0x13199081472x from 0x13152673792x
Pkilling 0x13156892672x from 0x13152673792x
Pkilling 0x13289787392x from 0x13152673792x
Pkilling 0x13247598592x from 0x13152673792x
Pkilling 0x13205409792x from 0x13152673792x
Pkilling 0x13163220992x from 0x13152673792x
Pkilling 0x13121032192x from 0x13152673792x
Pkilling 0x13296115712x from 0x13152673792x
Pkilling 0x13253926912x from 0x13152673792x
Pkilling 0x13211738112x from 0x13152673792x
Pkilling 0x13169549312x from 0x13152673792x
Pkilling 0x13127360512x from 0x13152673792x
Pkilling 0x13114421248x from 0x13152673792x
Pkilling 0x13302444032x from 0x13152673792x
Pkilling 0x13260255232x from 0x13152673792x
Pkilling 0x13218066432x from 0x13152673792x
Pkilling 0x13175877632x from 0x13152673792x
Pkilling 0x13133688832x from 0x13152673792x
Pkilling 0x13266583552x from 0x13152673792x
Pkilling 0x13224394752x from 0x13152673792x
Pkilling 0x13182205952x from 0x13152673792x
Pkilling 0x13140017152x from 0x13152673792x
Pkilling 0x13272911872x from 0x13152673792x
Pkilling 0x13230723072x from 0x13152673792x
Pkilling 0x13188534272x from 0x13152673792x
Pkilling 0x13146345472x from 0x13152673792x
Pkilling 0x13279240192x from 0x13152673792x
Pkilling 0x13237051392x from 0x13152673792x
Pkilling 0x13194862592x from 0x13152673792x
Pkilling 0x13285568512x from 0x13152673792x
Pkilling 0x13243379712x from 0x13152673792x
Pkilling 0x13201190912x from 0x13152673792x
Pkilling 0x13159002112x from 0x13152673792x
Pkilling 0x13116813312x from 0x13152673792x
Pkilling 0x13291896832x from 0x13152673792x
Pkilling 0x13249708032x from 0x13152673792x
Pkilling 0x13207519232x from 0x13152673792x
Pkilling 0x13165330432x from 0x13152673792x
Could not exec mono-hang-watchdog, expected on path '/Users/sameera/.vscode/extensions/ms-dotnettools.csharp-1.23.14/.omnisharp/1.37.14/etc/../bin/mono-hang-watchdog' (errno 2)
Pkilling 0x13123141632x from 0x13152673792x
Pkilling 0x8672648704x from 0x13152673792x
Pkilling 0x13298225152x from 0x13152673792x
Pkilling 0x13256036352x from 0x13152673792x
Pkilling 0x13213847552x from 0x13152673792x
Pkilling 0x13171658752x from 0x13152673792x
Pkilling 0x13129469952x from 0x13152673792x
Pkilling 0x13304553472x from 0x13152673792x
Pkilling 0x13262364672x from 0x13152673792x
Pkilling 0x13220175872x from 0x13152673792x
Pkilling 0x13177987072x from 0x13152673792x
Pkilling 0x13135798272x from 0x13152673792x
Pkilling 0x13268692992x from 0x13152673792x
Pkilling 0x13226504192x from 0x13152673792x
Pkilling 0x13184315392x from 0x13152673792x
Pkilling 0x13142126592x from 0x13152673792x
Pkilling 0x13275021312x from 0x13152673792x
Pkilling 0x13232832512x from 0x13152673792x
Pkilling 0x13190643712x from 0x13152673792x
Pkilling 0x13148454912x from 0x13152673792x
Pkilling 0x13281349632x from 0x13152673792x
Pkilling 0x13239160832x from 0x13152673792x
Pkilling 0x13196972032x from 0x13152673792x
Pkilling 0x13154783232x from 0x13152673792x
Pkilling 0x13287677952x from 0x13152673792x
Pkilling 0x13245489152x from 0x13152673792x
Pkilling 0x13203300352x from 0x13152673792x
Pkilling 0x13161111552x from 0x13152673792x
Pkilling 0x13118922752x from 0x13152673792x
Pkilling 0x13294006272x from 0x13152673792x
Pkilling 0x13251817472x from 0x13152673792x
Pkilling 0x13209628672x from 0x13152673792x
Pkilling 0x13167439872x from 0x13152673792x
Pkilling 0x13125251072x from 0x13152673792x
Pkilling 0x13300334592x from 0x13152673792x
Pkilling 0x13258145792x from 0x13152673792x
Pkilling 0x13215956992x from 0x13152673792x
Pkilling 0x13173768192x from 0x13152673792x
Pkilling 0x13131579392x from 0x13152673792x
Pkilling 0x13306662912x from 0x13152673792x
Pkilling 0x13264474112x from 0x13152673792x
Pkilling 0x13222285312x from 0x13152673792x
Pkilling 0x13180096512x from 0x13152673792x
Pkilling 0x13137907712x from 0x13152673792x
Entering thread summarizer pause from 0x13152673792x
Finished thread summarizer pause from 0x13152673792x.
Failed to create breadcrumb file (null)/crash_hash_0x44e974cadf
Waiting for dumping threads to resume
=================================================================
External Debugger Dump:

C# log
No output in C# log
Environment information
VSCode version: 1.59.1
C# Extension: 1.23.14
Mono Information
        OmniSharp using built-in mono
Dotnet Information
.NET SDK (reflecting any global.json):
 Version:   6.0.100-preview.7.21379.14
 Commit:    22d70b47bc
Runtime Environment:
OS Name:     Mac OS X
OS Version:  11.5
OS Platform: Darwin
RID:         osx.11.0-arm64
Base Path:   /usr/local/share/dotnet/sdk/6.0.100-preview.7.21379.14/
Host (useful for support):
Version: 6.0.0-preview.7.21377.19
Commit:  91ba01788d
.NET SDKs installed:
6.0.100-preview.7.21379.14 [/usr/local/share/dotnet/sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 6.0.0-preview.6.21355.2 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.0-preview.7.21378.6 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.0-preview.7.21377.19 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

azure-account
ms-vscode
0.9.8

cmake
twxs
0.0.17

cmake-tools
ms-vscode
1.7.3

csharp
ms-dotnettools
1.23.14

docomment
k--kato
0.1.20

gitlens
eamodio
11.6.0

jupyter
ms-toolsai
2021.8.1236758218

python
ms-python
2021.8.1159798656

remote-containers
ms-vscode-remote
0.191.1

terraform
hashicorp
2.14.0

vscode-azureappservice
ms-azuretools
0.23.0

vscode-azureresourcegroups
ms-azuretools
0.4.0

vscode-azurestaticwebapps
ms-azuretools
0.7.1

vscode-docker
ms-azuretools
1.16.0

vscode-markdownlint
DavidAnson
0.43.2

vscode-pylance
ms-python
2021.8.2

vscode-sqlite
alexcvzz
0.13.0

I moved to Omnisharp v1.23.12 and things seem to be stable here

That's a proper crash. Is this happening just on any project? Or a specific project?

Related #3694

@nohwnd Currently I am only working on one project in my setup. I'll check with some other projects as well.

i can consistently reproduce this by switching between branches that target .Net Core 3.1 vs .Net 6.0.  There are other scenarios, but this is a sure way to crash OmniSharp.  A Reload Window gets it running again, but super annoying.

This has been resolved with the .NET 6 build of OmniSharp. See the instructions here on how to enable it https://github.com/OmniSharp/omnisharp-vscode/releases


[DOCFIX] Update deploy dora on k8s doc

As we have (about to have) a proper helm chart for dora, update the doc to a more detailed page.

alluxio-bot, merge this please.


Resource on how to setup

It would be helpful to provide a link to other resources for sequence of setup, dependencies between modules, etc.
This is long-awaited functionality however the 'how-to' is greatly needed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 13472e1b-6d55-1cba-164c-0df6d2939c25
Version Independent ID: 8d2a0fbb-c025-1486-e282-740373cb15dc
Content: Hazardous materials - Supply Chain Management | Dynamics 365
Content Source: articles/supply-chain/pim/hazardous-materials-pim.md
Service: dynamics-ax-applications
Product: ****
Technology: ****
GitHub Login: @lachlancashMS
Microsoft Alias: conradv

@LMedbery, thank you for the feedback!
@kamaybac, please consider the suggestion.

Bug 441224 has been logged to track this issue.

@LMedbery , I see that you submitted this quite a long time ago. I just ran into it while cleaning up. The topic you responded to here is out of date and is no longer part of our table of contents (as you correctly pointed out). The new HazMat documentation provides full details and is available here: https://docs.microsoft.com/en-us/dynamics365/supply-chain/pim/hazmat-overview