Fix casting exception during backup NIC synchronization

Description
After a backup is successfully restored in Veeam, CloudStack tries to synchronize the restored VM; however, during the NIC synchronization process, all NIC devices are cast to VirtualE1000, whether they are an E1000 or not, resulting in a casting exception being thrown and the process failing when they are not.
This PR addresses the fix for this issue.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[X] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?
This was tested in a local lab.
Before the changes, whenever I tried to restore a backup of a VM that had a network adapter of types PCNet32, Vmxnet2 or Vmxnet3, I would receive the following error message:
(<vm_name>) Error during vm backup restoration and import: class com.vmware.vim25.VirtualPCNet32 cannot be cast to class com.vmware.vim25.VirtualE1000 (com.vmware.vim25.VirtualPCNet32 and com.vmware.vim25.VirtualE1000 are in unnamed module of loader 'app')

With these changes, I was able to successfully restore the backups.

@winterhazel thanks for your PR. As this is a bug fix can you change base branch of the PR to 4.18?

@blueorangutan package

@GutoVeronezi a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6713

@rohityadavcloud Sure.

@blueorangutan package

@winterhazel a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6714

@blueorangutan test rocky8 vmware-70u3

@blueorangutan test rocky8 vmware-70u3

@DaanHoogland a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

[SF] Trillian test result (tid-7357)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 67209 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7831-t7357-vmware-70u3.zip
Smoke tests completed. 101 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_add_primary_storage_disabled_host
Error
0.22
test_primary_storage.py

test_03_migration_options_storage_tags
Error
0.02
test_primary_storage.py

test_00_deploy_vm_root_resize
Error
1.36
test_deploy_vm_root_resize.py

test_05_update_cmd
Error
3.74
test_disk_provisioning_types.py

test_01_non_strict_host_anti_affinity
Failure
139.28
test_nonstrict_affinity_group.py

test_02_non_strict_host_affinity
Error
102.17
test_nonstrict_affinity_group.py

test_01_deploy_vm_on_specific_host
Error
0.10
test_vm_deployment_planner.py

test_04_deploy_vm_on_host_override_pod_and_cluster
Error
0.14
test_vm_deployment_planner.py

test_03_live_migrate_VM_with_two_data_disks
Error
61.99
test_vm_life_cycle.py

test_08_migrate_vm
Error
0.06
test_vm_life_cycle.py

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
680.88
test_vpc_redundant.py

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Error
680.89
test_vpc_redundant.py

@blueorangutan test rocky8 vmware-70u3

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

[SF] Trillian test result (tid-7376)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 46326 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7831-t7376-vmware-70u3.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File


Else Block Show Element as Text

- var myArray = ['HTML', 'CSS', 'PHP', 'MySQL', 'JavaScript']
each val, index in myArray
  div= index + ' : ' + val
else
  p There's No Value

Here "p" Must be Colored because its Element and its Rendered as Element but its show as Text

Also reported here: https://github.com/genoma/language-pug/issues/2
In that thread is a suggested fix, I someone wants to do a PR


Particle Dev can't find header files in libraries

in KhioneTrackerV2.ino

$ pwd
/Users/thomaseliot/Particle/projects/KhioneTrackerV2

When using the copy to current project feature in the library menu

Thank you, Thomas! We'll look into this!

Hi Thomas, we've recently introduced a fix for this. Are you still experiencing this issue?


Netezza JDBC error

System information:

Operating system (distribution) and version Windows 10
DBeaver version 5.3.5 Community Edition
Java version Whatever comes with DBeaver
Additional extensions

Connection specification:

Database name and version Netezza 7.2.1
Driver name JDBC from IBM
Do you use tunnels or proxies (SSH, SOCKS, etc)? no

Describe the problem you're observing:
Steps to reproduce, if exist:
When testing connection, getting this error:
Unexpected driver error occurred while connecting to database
java.lang.NullPointerException
Driver works fine from a Java program, but not from DBeaver.
Include any warning/errors/backtraces from the logs

Sorry for late reply.
Could you attach error/debug logs with this error? (https://github.com/dbeaver/dbeaver/wiki/Log-files)

there is no update more than a month. Ticket closed.
If issue is still actual feel free to reopen the ticket or create a new one.


Fixed Reorderering Bug

The problem with the reordering bug was twofold:

The reordering information was never correctly stored on the database. Part of the problem was that the reordering information was incorrectly associated with the dancers (the code calls them members) when it should have been associated with the position. This was especially cumbersome given that there can be many dancers per every position.
The frontend data structures buried the reordering data (that was always 0) and didn't try to use it when displaying ballets, either on the stand alone page or in the performance pages. And because the data was buried too far down, it was difficult to make it available at the right time.
I made a tiny extra change. The Alvin Ailey people don't like the word 'piece'. They wanted the 'pieces' called 'ballets'.

Comments about file changes:
The system did the change in backend/.project. I din't.
The WebSecurityConfig.java changes are reformatting only.
The change is PerformanceServices.java fixes a bug where the backend that never correctly updated the database.
applicatioin-dev.properties: cosmetic changes only.
performance-api.service.ts: added an ordering field field to the performance structure and populated it.
cast-drag-and-drop.component.ts: changed the sort from name based to based on the specified order information.
mock_performance_backend.ts: added an extra field to the performance data structure.
performance-editor.component.html: only reformatting.
performance-editor.component.ts: moved up the ordering information in the performance data structure and sorted using it.
piece-editor.component.ts: Changed 'piece' to 'ballet'.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.

@googlebot I signed it!

I signed it!


Removing hard coded place holders in templates as the build pipelines doesnt handle it well

All Submissions:

[ ] Have you followed the guidelines in our Contributing document?

[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

[ ] Does your PR follow our Code of Conduct?

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?

[ ] Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

[ ] Is this code designed to be testable?

[ ] Is the code documented well?

[ ] Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

[ ] Have you added tests to cover your changes?

[ ] Have you linted your code prior to submission?

[ ] Have you updated the documentation and README?

[ ] Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).

[ ] Have secrets been stripped before committing?

@eladiw Can you add documentation somewhere about the values that need to be filled (given that the placeholders are removed now)?

@eladiw Can you add documentation somewhere about the values that need to be filled (given that the placeholders are removed now)?

@sayar thanks. I have added a simple readme file to elaborate and explain the process and missing arguments. also one of the missing values was possible to turn into an argument, so I fixed it


XACML Policy Name with Colon is not Displayed Correctly

Describe the issue:

The Policy View incorrectly displays any policies with a colon in their name (they appear correctly under Policy Administration)

How to reproduce:

Expected behavior:

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version:  IS 5.10.0

Optional Fields
Related issues:

Suggested labels:

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


x/tools/go/packages: unhelpful when it returns nil, nil

at tip, packages.Load can return an empty list without any errors. While this might be the correct result sometimes (as when a pattern doesn't match) it gives the user nothing to work with. It might be more helpful to report some sort of error from the underlying build tool.

/cc @matloob


Template?

If there's a template, I'd love to help contribute to this so we can get this list even longer than it is now.  These are my absolute favorite list of icons.

Oh I'll absolutely provide the template. I'll appreciate help now there are just too many coins.
I'll write up some documentation on the wiki to outline my process and best practises.

Done! - https://github.com/cjdowner/cryptocurrency-icons/wiki


EIP-3541 london test fixes

What was wrong?

LondonComputation was raising an error where it should set the error and return the computation. This fixes broken ethereum tests related to this new logic from EIP-3541.
Ethereum tests released a new version (v10.0)

How was it fixed?

Set the computation.error and return the computation rather than raise the VMError
Updated ethereum tests submodule to new version v10.0

To-Do

[X] Clean up commit history

[x] Add entry to the release notes

Cute Animal Picture

@carver @kclowes, these changes should resolve the failing tests on #2021 related to the reserved bytecode (EIP-3541).

The big glaring issue is: no cute animal picture! X)

I'm a monster... how could I forget 😞

@kclowes @carver updated. I am good to merge this if you are. No write permissions on my end.

Also just added you for write access @fselmo


Feature: MyAlgo Wallet Multisig

Added support for multisig for MyAlgo Wallet

@Megha-Dev-19 Update changelog.md

Lets first merge the PR with the mock for myAlgo wallet and then add test to this one.

As I said I don't think we can add the test for multisig using unit test because the wallet actually wait for the cosigner signature, and I don't think it is possible with unit test, it can done from the wallet UX only


Need for parameter-overloading

How to do parameter-overloading with OpenAPI?
With the main API Gateway tools, like Apache and NGINX, it is natural using regular expressions.
... Perhaps it is a suggestion to the OpenAPI v3.1...
Example
The declarations say that A and B are distinct var-names with distinct datatypes... But tuday (v2.0) it triggs a "Semantic error: Equivalent paths are not allowed".
  /{A}/xxx:
    get:
      tags:
      - etc.
      summary: etc.
      operationId: op1
      description: etc.
      produces:
      - application/json
      parameters:
      - in: path
        name: A
        description: etc.
        required: true
        type: integer
        format: int32
        minimum: 1
        maximum: 9999999

  /{B}/xxx:
    get:
      tags:
      - etc.
      summary: etc.
      operationId: op2
      description: etc.
      produces:
      - application/json
      parameters:
      - in: path
        name: B
        description: etc.
        required: true
        type: string
        pattern: ^[a-z]+$

This is not supported by OpenAPI (neither 2.0 nor the upcoming 3.0).

Hi @ePaul , thanks feedback.
.... Perhaps v3.1?  4.0?

#TDC: Tagging this for consideration in a future OpenAPI Spec release

This is being addressed in OAS 4 Moonwalk under the operation signatures principle.  Please join the discussions in that repository if you are interested!


Cleaning up and removing unused private methods

Also adding edge case handling for Capitalize

I'll take a look at this soon, haven't forgotten about it.


Request to host package: Lawndart

This issue was originally filed by @sethladd

When you have a moment, please host Lawndart on pub.
https://github.com/sethladd/lawndart
Lawndart is an attempt to bridge the different persistence layers in the browser under one common API. I've received two pull requests, so there are at least a few people using it :)
Thanks!

This issue has been moved to dart-lang/pub#228.


Bump to v0.4.0

Waits for #166 and #224 .

I think we don't need to wait these PRs, upgrading to 1.14 is a huge change, we can release a version directly.

PTAL @siddontang and @BusyJay

CI failed


global: deposit search facets

Adds configuration for search facets.

Signed-off-by: Krzysztof Nowak<EMAIL_ADDRESS>

Coverage increased (+0.06%) to 93.68% when pulling 8710ea41bb96d5bbe4f9008c456605fde8a688aa on krzysztof:deposit_rest_facets into 25189eb316f00760e7f973a334453471d7c8259a on inveniosoftware:master.


[BugFix] Don't need to close _conjunct_ctxs explicitly in ESDataSource

Signed-off-by: Smith Cruise<EMAIL_ADDRESS>What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

ESDataSource's _conjunct_ctxs comes from ScanNode. All io tasks in one driver shared the same ExprContext from ScanNode, so we do not need to close ExprContext explicitly, because it will be closed automatically by ScanNode::close().
Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[x] 2.4
[x] 2.3
[x] 2.2

run starrocks_admit_test

run starrocks_admit_test

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4

@Mergifyio backport branch-2.3

@Mergifyio backport branch-2.2


Provide method to return CUDA source from user-defined kernels

Sometimes I want to see CUDA source generated by user-defined kernels.
It should help users to understand how to write custom kernels, especially when preamble, loop_prep, etc. is involved.

I think to address this, this nice comment can be documented somewhere? (I know the env var CUPY_CACHE_SAVE_CUDA_SOURCE is already listed in the reference, but perhaps a short tutorial or something could offer a better guidance.)

I think it's nice to document it in https://docs-cupy.chainer.org/en/latest/tutorial/kernel.html


Fixing python3 import error in requests_cache.backends.dbdict

This is a fix I created for the issue noted in #83

Coverage decreased (-0.3%) to 93.715% when pulling 68ceebd869ecbe1650b515d41892e32569911e88 on ErinMorelli:master into d5007c043667e3274247464860997557143c5bbb on reclosedev:master.

Coverage decreased (-0.3%) to 93.715% when pulling<PHONE_NUMBER>794fc8a94fa28422e727585a847b27 on ErinMorelli:master into d5007c043667e3274247464860997557143c5bbb on reclosedev:master.

+1. Why was this closed?


Optionlist drop down  spacebar causes list to lose focus.

Use the up/down keys to open the drop down, pressing spacebar causes list to lose focus, losing the ability to navigate with up/down


Id3 update

Document type: identy
Nationality: Turkey
Reeder p13 blue - Android 9
Describe process/experience: A different person was recorded by taking a selfie with a random ID on google.

confirmed:ID3
DocumentType:verified
Nationality:verified
DeviceDetails:verified
Experience:verified
Screenshot:verified

confirmed:ID3
DocumentType:verified
Nationality:verified
DeviceDetails:verified
Experience:verified
Screenshot:verified


Identifier lifecycle management support

Add support for "active", "replaces", and "replaced_by" lifecycle fields in CLI/API.
Cleanup some inconsistent formatting.
Bump version.

Added one comment, otherwise looks good to me! I'll try to pull it down and start incorporating it into the Minid Client.


multiscala configuration

Please look at #962 and consider earlier uncommitted PRs first. This PR is based on those PRs and will give you smaller PRs to review.
Description
This is the first PR for #962 . It creates/uses the configuration structure necessary to configure multiple scala toolchains but at this point only uses the default toolchain.
Changes to multiscala

create unstable/multiscala
combine user configuration and default configuration to create @io_bazel_rules_scala_configuration repo
maven_install rules_scala dependencies based on @io_bazel_rules_scala_configuration
create bind aliases for rules_scala dependencies when there is a default scala version
create scala_toolchain for configured versions
register scala_toolchain if there is a configured default version
create unstable/multiscala/private/example which can be run with bazel build :all && bazel run :all

Changes to stable code

add TemplateVariableInfo provider to scala_toolchain. Required when used as the value for the standard toolchains attr
create and use a few bindings so that they can also be configured in multiscala. Although I think long term we may want to remove all bindings, for now they're key to making multiscala opt-in.

Motivation
First step in being able to configure multiple toolchains based on a configuration with multiple scala versions.
This creates the toolchains but doesn't, at this point, use them. That will come in a subsequent PR.

At this point, there's not enough need/support for this (including myself) to continue forward.


54 add new exchange api

Implementing Hyperliquid API.
This won't be complete because HL is a futures exchange so has some client state (i.e. margin) but will try to implement most of the execution logic/order types that would be required for a backtest.
This also means that there will be no margined trading, everything is cash.

Need to check that stop loss/take profit are triggering correctly. There was a bug with SL triggering immediately so need to go over long/short test cases and make sure logic is correct.


Fixes problems finding raven libraries with conda

Pull Request Description
What issue does this change request address?
Closes #2217
What are the significant changes in functionality due to this change request?
Checks correctly for an existing environment.
If for example, the library name is raven_libraries but a raven_libraries_2_0 existed, the previous test would match, and then the conda remove could fail, but this is corrected by making sure the exact name is matched.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Job Mingw Test on 00c7e6e : invalidated by @joshua-cogliati-inl
failed in fetch


Add missing typing for classmethod Signature.from_dict(...)

ty! looks like it just needs to be reformatted!


IdentityServer4 with Javascript Client not working in Edge browser

Javascript client (provided in the documentation) doesnt work in edge.
I works as per expected in other browser.
I get the following error message when i try to log in or make an api call to the IdentityServer4 controller action from a javascript client application in Edge browser.
Issue / Steps to reproduce the problem

Download and setup the javascript client specified in the indentityServer4 documentation.
http://docs.identityserver.io/en/release/quickstarts/7_javascript_client.html

Open the javascript client in Edge. When you try to login you get the following error which can be seen in Edge Developer Console.

SCRIPT7002 : XMLHttpRequest: Network Error 0x2efd, Could not complete the operation due to error 00002efd.
And
Unhandled promise rejection Error: network error.

I just tested it with: Microsoft Edge 38.14393.0.0 and it's working for me.

Working fine for me too, on the "slightly older" Microsoft Edge 25.10586.672.0.


Add basic telemetry

Important
This issue is based on this specification: https://github.com/meilisearch/specifications/blob/main/text/0034-telemetry-policies.md
All the spec is not implemented, we discuss together with @gmourier to decide what should be added for v0.22.0.
⚠ For anything that is not clear or deeply detailed in this issue, please refer to this specification.

TODO

[ ] Number of indexes per instance
[ ] Number of documents per index
[ ] CPU and RAM per machine
- [ ] SDK distribution (spec is coming) will be done in a next version

This impacts:

@meilisearch/docs-team: the telemetry page should be improved
@meilisearch/integration-team: the SDKs should return the right information to MeiliSearch Will be done in a next version

@meilisearch/integration-team: checked with @gmourier, this will not be easy to add the SDK telemetry in v0.22.0, so the SDK telemetry addition is delayed! I removed the impacts integrations label then, the integration team is not concerned by this issue anymore 🙂

Since this issue has been delayed, is it still relevant for v0.22 docs?

The SDK telemetry has been delayed only. Not the rest of the issue.
The docs-team still have to document the remaining 3 points (Number of indexes per instance, Number of documents per index, CPU and RAM per machine)

understood, thanks!

Checked with @gmourier, finally, this will not be present in v0.22.0. We need more time to think about what we really need :)
I close this issue!


[GOBBLIN-1664] Allow table to flush after write failure

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1664

Description

[x] Here are some details about my PR, including screenshots (if applicable):

Currently if a table fails to write, we reset the writer that failed, and also remove it from the tableOperationTypeMap to avoid a no-op flush. However, if the writer that failed is not the first writer, there may still be other succeeding writers that we do want to flush. Removing this line so that we will still flush even if there was a failure of a writer for this situation.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Trivial

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3522 (5fc3f17) into master (2463eda) will decrease coverage by 3.25%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3522      +/-   ##
============================================
- Coverage     46.71%   43.46%   -3.26%
+ Complexity    10437     2044    -8393
============================================
  Files          2081      405    -1676
  Lines         81445    17510   -63935
  Branches       9092     2140    -6952
============================================
- Hits          38044     7610   -30434
+ Misses        39894     9046   -30848
+ Partials       3507      854    -2653

Impacted Files
Coverage Δ

...pache/gobblin/iceberg/writer/GobblinMCEWriter.java
75.55% <ø> (-0.56%)
:arrow_down:

...lin/util/filesystem/FileSystemInstrumentation.java
85.71% <0.00%> (-7.15%)
:arrow_down:

.../org/apache/gobblin/cluster/GobblinTaskRunner.java
62.69% <0.00%> (-0.95%)
:arrow_down:

...apache/gobblin/hive/avro/HiveAvroSerDeManager.java

...time/std/DefaultJobExecutionStateListenerImpl.java

...va/org/apache/gobblin/converter/EmptyIterable.java

.../gobblin/source/DatePartitionedJsonFileSource.java

...s/orchestration/AzkabanFetchExecuteFlowStatus.java

.../apache/gobblin/service/FlowConfigsV2Resource.java

... and 1670 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2463eda...5fc3f17. Read the comment docs.


Error when attempting to create new boards

I've been playing with gochan a bit.
In src/manage.go:738, an slice ( []interface{}{board} ) is being passed to the manage_boards_tmpl template (file manage_boards.html).
				if err := manage_boards_tmpl.Execute(manageBoardsBuffer, map[string]interface{}{
					"board":       []interface{}{board},
					"section_arr": all_sections,
				}); err != nil {

However, manage_boards.html doesn't range over the slice, so when one goes to the "Manage boards" menu, it shows an error under "Create new board":
template: manage_boards.html:20:72: executing "manage_boards.html" at <.board.Locked>: can't evaluate field Locked in type interface {}
What's the logic behind this code? From what I can see, "board" here contains the default configurations for new boards, so why pass an slice instead of simply "board"?

Nevermind, I just saw you fixed this yesterday...


Google Fonts are being added automatically

I went to add some Google Fonts to my newest project and I noticed that the most recent vesion is already adding Google Fonts. I can't seem to locate where they are coming from though. It is getting injected before the scripts are ever enqueued.
Here is what is showing up:

How can this bug be reproduced?

Step one - Install a fresh copy of Foundationpress
Step two - View Source
Step three

What did you expect to happen?
If Google Fonts are automatically being added, I would at least like to be able to change them.
What happened instead?
The Fonts aren't in the enqueue scripts or in header.php
Test case:
Please provide a link to a CodePen or JSFiddle that recreates the issue, if possible.

Sorry, false alarm. For anyone else who wonders why this is happening, the WP-Admin bar apparently automatically enqueues Open Sans whenever it is enabled. This only shows up if you are logged in.


SAP HANA DDL Functions: show under own category

It would be helpful if functions would be shown under an own category functions instead of procedures. In my case there are a lot of procedures and only a few functions. So for now I have to go through the whole list of procedures to find a specific function ;)
thx

This makes sense. However this should be configurable on driver basis (in some DBs procedures and functions are much the same).

For now by default this feature enabled for Derby and HANA.
And this is configurable for each Generic driver:

@serge-rider You are awesome!! Thank you


Simulator migration guide

closes #919

Should this show up in the table of contents? If so, what folder should it be under? We've also been adding migration guides to the index file.

Should this show up in the table of contents? If so, what folder should it be under? We've also been adding migration guides to the index file.

Yes - I just hadn't added it yet.  Thanks for the reminder!

@Eric-Arellano - this can't go live until the Qiskit Runtime API docs are updated, so we'll need to coordinate that.

@Eric-Arellano - this can't go live until the Qiskit Runtime API docs are updated, so we'll need to coordinate that.

The API is already there, so no need.

Some minor comments but other LGTM.
I have a question though. Should we mention that you don't get the built in error suppression / mitigation with local testing mode? Since you do with cloud simulators.

Good idea - are there other changes of note?  They can access Aer simulators now, which gives them the ability to handle larger circuits, and can also now incorporate noise models.  They couldn't do that with cloud sims, right?


Custom Environments

Reading the page, it seems to me that perhaps the Curated / Custom Environments need separate headings.  I read the section on Curated environments it also includes Custom environments.  Could you add Custom environments as a heading, then roll  into Create an environment which is a sub section of Custom environments.
https://learn.microsoft.com/en-us/azure/machine-learning/how-to-manage-environments-v2?view=azureml-api-2&tabs=cli#curated-environments

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a10c58c2-1767-778c-5591-8b6eb1e50969
Version Independent ID: ecc11aa4-56c9-d8b0-69c0-d9978de4adc5
Content: Manage Azure Machine Learning environments with the CLI & SDK (v2) - Azure Machine Learning
Content Source: articles/machine-learning/how-to-manage-environments-v2.md
Service: machine-learning
Sub-service: core
GitHub Login: @ositanachi
Microsoft Alias: osiotugo

@michaelspinks
Thanks for your feedback! We will investigate and update as appropriate.

@michaelspinks
I've delegated this to @ositanachi, a content author, to review and share their valuable insights.


Python basic projects

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ff556dcf-4de1-8483-702a-73699062be1f
Version Independent ID: cba846ae-6af4-af49-b194-28b546169426
Content: Create a network-based installation - Visual Studio (Windows)
Content Source: docs/install/create-a-network-installation-of-visual-studio.md
Product: visual-studio-windows
Technology: vs-installation
GitHub Login: @anandmeg
Microsoft Alias: meghaanand

@03112004 -- please consider these resources:

Ask a question or find an answer on the Microsoft Q&A page for Visual Studio.
Check the Visual Studio MSDN Forum.
Stack Overflow
Reddit

I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


ontolearn-webservice @app.get("/cel")

Introduce new arguments to upload json files
"kwards_json_lp":"LPs/Family/lps.json"
"kwards_json_learner" : "drill_config.json"

kwards_json_learner should contain all hyperparameters abour the learner (training or testing related)

After a reconsideration, I guess we do not need to introduce these new arguments for the following reasons:
Instead of using kwards_json_lp to upload multiple learning problems, multiple HTTP requests should be sent.
Although introducing kwards_json_learner might be usefull, currently we do not need this. If the necessitiy arries,
we can introduce additional hyperparameters as we have introduced max_runtime, iter_bound, etc. in the readme example, see below
import json
import requests
with open(f"LPs/Mutagenesis/lps.json") as json_file:
    learning_problems = json.load(json_file)["problems"]
for str_target_concept, examples in learning_problems.items():
    response = requests.get('http://<IP_ADDRESS>:8000/cel',
                            headers={'accept': 'application/json', 'Content-Type': 'application/json'},
                            json={"pos": examples['positive_examples'],
                                  "neg": examples['negative_examples'],
                                  "model": "Drill",
                                  "path_embeddings": "mutagenesis_embeddings/Keci_entity_embeddings.csv",
                                  "path_to_pretrained_drill": "pretrained_drill",
                                  # if pretrained_drill exists, upload, otherwise train one and save it there
                                  "num_of_training_learning_problems": 2,
                                  "num_of_target_concepts": 3,
                                  "max_runtime": 60000,  # seconds
                                  "iter_bound": 1  # number of iterations/applied refinement opt.
                                  })
    print(response.json())  # {'Prediction': '∀ hasAtom.(¬Nitrogen-34)', 'F1': 0.7283582089552239, 'saved_prediction': 'Predictions.owl'}


Add Sorbet shims for debug gem

To prevent distracting typecheck errors during development.

@andyw8 the debugger method is actually added to Kernel, not Binding.


Needs documentation on how to format filter strings in this action

[Enter feedback here]
This page needs to provide examples (and string formatting examples) of applying report and page level filters to the export action.  those used to creating filters in M-code and DAX won't know that this is a totally different format of filter strings.  Or at least provide a reference link to where those formats are defined.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d92e4209-59ef-2aed-dd62-b38c443d96d3
Version Independent ID: ba65faca-8ef1-3cb3-3a32-bc23fbb1e64c
Content: Export and email a report with Power Automate - Power BI
Content Source: powerbi-docs/collaborate-share/service-automate-power-bi-report-export.md
Service: powerbi
Sub-service: pbi-collaborate-share
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Thanks for your comment, @lordneeko. This issue has been assigned to the doc author for review.

Hi @lordneeko, I'm moving this issue to our work item backlog for better tracking and consideration. Closing it here now. Thanks for your input!


Fix UNIX check for missing components in OGRE2. Be more verbose with components

The check if (NOT "OGRE2-${component}" STREQUAL "OGRE2-${component}-NOTFOUND") is going to return always true since OGRE2-${component} is never going to be OGRE2-${component}-NOTFOUND. What we really want to check is the content of the whole variable which, if I'm not wrong, should be: ${OGRE2-${component}}.
The pull request includes a bit of output for the user to know when the detection of OGRE2 is failing the status of each component. Otherwise is hard to know what's going on. Example:
Current example in 2.2 (bug included that say OGRE2 was found, using a "fake component")
-- Looking for IgnOGRE2 - found

-- OGRE2_FOUND: TRUE
-- OGRE2_LIBRARIES: /usr/lib/x86_64-linux-gnu/OGRE-2.2/libOgreMain.soIgnOGRE2-HlmsPbs::IgnOGRE2-HlmsPbsIgnOGRE2-HlmsUnlit::IgnOGRE2-HlmsUnlitIgnOGRE2-Overlay::IgnOGRE2-OverlayIgnOGRE2-Fake::IgnOGRE2-Fake

With this PR:
-- Finding OGRE 2.2
--  Version: OGRE 2.2
--  component HlmsPbs: found
--  component HlmsUnlit: found
--  component Overlay: found
--  component Fake: not found!
-- Looking for IgnOGRE2 - not found

-- OGRE2_FOUND: false
-- OGRE2_LIBRARIES: /usr/lib/x86_64-linux-gnu/OGRE-2.2/libOgreMain.soIgnOGRE2-HlmsPbs::IgnOGRE2-HlmsPbsIgnOGRE2-HlmsUnlit::IgnOGRE2-HlmsUnlitIgnOGRE2-Overlay::IgnOGRE2-Overlay

This pull request has been mentioned on Gazebo Community. There might be relevant details there:
https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1


Ccd 1131 - Refactorings and enhancements to support automated definition imports from pipelines till production env

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CCD-1131
Change description
Added support for more generic logic to load definitions and roles onto definition store.
This required some of the environment variables to be named better for broader use across the programme.
An implication of this will be to add the new environment variables to ccd docker as well.
As one of the PRs linked to the Epic CCD-1131, this one will be merged along with a complementary one in ccd-docker.
Also changed was tolerance for unavailable environment variables for teams that will use only the data loading logic, but not other domain-agnostic actual functions of the framework.
Finally, support added for automatic translation of callback variables as per the environment the definitions are getting uploaded to.
Does this PR introduce a breaking change? (check one with "x")
[X] Yes
[ ] No

Merged after observing all BEFTA tests on data store, def store, user profile and activity api green multiple times. Def store stage failures are due to legacy test failures, not relevant to BEFTA version change.


dummy

Current dependencies on/for this PR:

main

PR #26

PR #35   👈

This comment was auto-generated by Graphite.


Setting loglevel for components

Is your feature request related to a problem? Please describe.
When using ArgoCD operator the loglevel of all components is set to the default value of 'INFO'. Depending on the use case this will produce a lot of unrelated log messages. As far as I see there is no option to adjust the loglevel of the ArgoCD components.
Describe the solution you'd like
Using the ArgoCD CR we could set the loglevel for the different components.
Describe alternatives you've considered
Setting the --loglevel in the Deployment will not work as these resources are operator managed.
Additional context
The loglevel could be set for all components, e.g. https://argoproj.github.io/argo-cd/operator-manual/server-commands/argocd-server/.

I agree on this. We should get some sort of Log level on the operator.


Provide a new emit command to send events

For local development, it would be nice if I could send simulated events to my function. I should be able to specify the source, type and optionally the data. I should be able to send the event to the deployed URL for my function, or to localhost. I propose the following interface.
func emit [--source="/some/source"] [--type="some.type"] [--id=someid] [--data=./path/to/json] [--local]

All flags are optional.

Done in https://github.com/boson-project/func/pull/332


179 s report firmware version mismatch on connect

This PR:

Add driver method for checking smoothieboard version compatibility (for firmware, config file, and ot_version), which is checked automatically on .connect()
axis_homed flag moved from driver to Robot
version compatibility returned along with version number in Robot.versions()

Changes Unknown when pulling 4cad4859ecaeaa3b97a4b69ff7c695f2458a92a5 on 179-s-report-firmware-version-mismatch-on-connect into ** on master**.

Changes Unknown when pulling d22745f7d7e02f28bf5374999a3cf8c827f1caac on 179-s-report-firmware-version-mismatch-on-connect into ** on master**.


[🐞] Error with Yarn PnP when Vite is type: module

Which component is affected?
Qwik Rollup / Vite plugin
Describe the bug
Following the guide at https://qwik.builder.io/docs/getting-started/ and running the script:
yarn qwik add static

I am able to use Qwik with Vite.

The generated Vite configuration is the type CommonJS since package.json does not include the keyword "type": "module". However, this causes building the project a warning:

The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.

Upon changing the Vite configuration to type: module, either by renaming vite.config.ts to vite.config.mts or specifying "type": "module" in the package.json. Running yarn build gave me this output:

Terminal output
vite v5.0.8 building for production...
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Opening $MyLocalAppData$\Yarn\Berry\cache\<EMAIL_ADDRESS>
Caused by:
    The system cannot find the path specified. (os error 3)', packages\qwik\src\napi\src\lib.rs:21:50
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
✓ 0 modules transformed.
[vite-plugin-qwik] called `Result::unwrap()` on an `Err` value: Opening $MyLocalAppData$\Yarn\Berry\cache\<EMAIL_ADDRESS>
Caused by:
    The system cannot find the path specified. (os error 3)
error during build:
Error: called `Result::unwrap()` on an `Err` value: Opening $MyLocalAppData$\Yarn\Berry\cache\<EMAIL_ADDRESS>
Caused by:
    The system cannot find the path specified. (os error 3)
    at transformFsAsync (file:///$MyProjectDir$/.yarn/unplugged/@builder.io-qwik-virtual-cb69891d7f/node_modules/@builder.io/qwik/optimizer.mjs:1408:20)
    at Object.transformFs (file:///$MyProjectDir$/.yarn/unplugged/@builder.io-qwik-virtual-cb69891d7f/node_modules/@builder.io/qwik/optimizer.mjs:1390:32)
    at Object.buildStart (file:///$MyProjectDir$/.yarn/unplugged/@builder.io-qwik-virtual-cb69891d7f/node_modules/@builder.io/qwik/optimizer.mjs:1926:38)
    at Object.buildStart (file:///$MyProjectDir$/.yarn/unplugged/@builder.io-qwik-virtual-cb69891d7f/node_modules/@builder.io/qwik/optimizer.mjs:3469:24)
    at async Promise.all (index 3)
    at async PluginDriver.hookParallel (file:///$MyLocalAppData$/Yarn/Berry/cache/rollup-npm-4.9.0-8c6d128a25-10c0.zip/node_modules/rollup/dist/es/shared/node-entry.js:18565:9)
    at async file:///$MyLocalAppData$/Yarn/Berry/cache/rollup-npm-4.9.0-8c6d128a25-10c0.zip/node_modules/rollup/dist/es/shared/node-entry.js:19467:13
    at async catchUnfinishedHookActions (file:///$MyLocalAppData$/Yarn/Berry/cache/rollup-npm-4.9.0-8c6d128a25-10c0.zip/node_modules/rollup/dist/es/shared/node-entry.js:18981:16)
    at async rollupInternal (file:///$MyLocalAppData$/Yarn/Berry/cache/rollup-npm-4.9.0-8c6d128a25-10c0.zip/node_modules/rollup/dist/es/shared/node-entry.js:19464:5)
    at async build (file:///$MyProjectDir$/.yarn/__virtual__/vite-virtual-7168a4a7b0/3/Profiles/Ryyvv/AppData/Local/Yarn/Berry/cache/vite-npm-5.0.8-7f71954365-10c0.zip/node_modules/vite/dist/node/chunks/dep-uAHLeuC6.js:66760:18)

Reproduction
https://github.com/yvvki/Typ/tree/bug
Steps to reproduce
yarn install && yarn build

System Info
System:

OS: Windows 11 10.0.22621

Binaries:

Node: 21.4.0
Yarn: 4.0.2
npm: 10.2.5
pnpm: 8.11.0

Browsers:

Edge: Chromium (120.0.2210.61)
Internet Explorer: 11.0.22621.1

Additional Information
No response

I tested with the latest version of Qwik and it's working, is it working for you @yvvki ?


FilePondPluginImageTransform hangs on safari iPhone x and above model

Filepond hangs in iPhone X and above with browser safari.
This is the final FilePond object:
<FilePond ref={ref => this.pond = ref}
        files={this.state.files}
        allowMultiple={true}
        imageResizeTargetWidth="200"
        imageResizeTargetHeight="200"
        server={{
            // fake server to simulate loading a 'local' server file and processing a file
            process: (fieldName, file, metadata, load) => {
                // simulates uploading a file
                setTimeout(() => {
                    load(Date.now())
                }, 1500);
            },
            load: (source, load) => {
                console.log(source);
                console.log(load);
                // simulates loading a file from the server
                fetch(source)
                .then(res => { console.log(res); return res.blob();})
                .then((blob) =>{console.log(blob); return load(blob);});
            }
        }}
        oninit={() => this.handleInit() }
        onupdatefiles={fileItems => {
            // Set currently active file objects to this.state
            this.setState({
                files: fileItems.map(fileItem => fileItem.file)
            });
        }}>
</FilePond>

Summary
FilePondPluginImageTransform hangs on safari iPhone x and above model
How to reproduce
You can reproduce it using sample code from here:
https://github.com/pqina/react-filepond/blob/master/example/src/App.js
Add filepond-plugin-image-resize and filepond-plugin-image-transform
Change the sample code to add two more properties:
imageResizeTargetWidth="200"
imageResizeTargetHeight="200"
Run the sample code, use iPhone x and above model to browse to the url with "Safari" and try to upload a picture, it will hang forever with status "Uploading...".
Expected behaviour
Should upload file correctly without hanging.
Additional information

Environment
Version

OS
MacOS  / iOS  /

Device
iPhone X and above /

Browser
Safari 11.1.1  /

Closed because double post.
https://github.com/pqina/filepond-plugin-image-transform/issues/6


docker-compose.yml ENABLE_FINS error

When using sudo docker-compose up you get an error:
ERROR: The Compose file './docker-compose.yml' is invalid because:
services.soarca.environment.ENABLE_FINS contains true, which is an invalid type, it should be a string, number, or a null

This is because ENABLE_FINS: true is not between "", the setting should be ENABLE_FINS: "true".
If you change this manually it works.

Hi @Cyb3rtus I can reproduce the error with docker-compose although when using ENABLE_FINS: "true" I get different docker-composer errors. On that note we use docker compose up as docker-compose (V1) is deprecated  https://docs.docker.com/compose/reference/


Reduce scope of experimental renderer

On a second look, I think I want to reduce the scope of this.
Windows: I want to push people towards D3D11 or Vulkan, even if OpenGL Experimental may behave better than OpenGL. That can be reconsidered in post, based on the Linux results.
macOS: OpenGL should practically never be used.

Hmm, my only concern would be windows, where there's a push from users to recommend people try opengl.
Would the next step be to move d3d to the deferred renderer for windows testing as a follow-up, rather than potentially moving focus to the opengl one?

push from users to recommend people try opengl

Separate from our own recommendations? I'm pushing towards D3D11 because it's more widely supported than OpenGL. I drafted up a discussion topic (currently locked) showcasing the sort of questions I want to ask: https://github.com/ppy/osu/discussions/27659
In particular, I think the relevant one is:

I'm using Windows and all options behave poorly for me.

To which I'd follow up for that user specifically to try out deferred/opengl via environment variable.

Would the next step be to implement/move d3d to the deferred renderer for windows testing as a follow-up, rather than potentially moving focus to the opengl one?

I'm not sure what you're asking here...

Separate from our own recommendations?

Yes, there are youtube videos, changelog comments and discussion resolutions where people recommend switching from d3d to opengl as a solution to various performance issues on lazer, with many people getting positive results. I've been turning a blind eye to this because if it works for them then all the better.
Ignore the question regarding d3d, I didn't realise there's already an experimental option for that, which is what I was asking about (I am not up to scratch on the renderer PRs as there's too many other things happening).

Separate from our own recommendations?

Well... about that...
People are complaining about d3d11 borderless being vsync-locked regardless of their frame limiter. This happens because WaitForNextFrameReady() does do something like that. To which my response has been: either go exclusive fullscreen (thus enabling tearable swapchain), or switch to another renderer. And because vulkan has been considered broken (and still is, to a degree, see here). And people do want borderless because tabbing out is faster.
So I dunno. Make of that what you will.

vulkan has been considered broken (and still is, to a degree, see here)

See my response to that in the following conversion - it's not a Vulkan issue. The deferred renderer should have fixed Vulkan otherwise (it bricking the game when entering gameplay). Have I missed something else?

Sometimes opengl also helps with the inscrutable "0xc000005 access violation exception" hard windows crashes that keep getting reported

OpenGL (i.e. legacy) is still available. Just not deferred/OpenGL.

d3d11 borderless being vsync-locked regardless of their frame limiter

Which wouldn't be an issue except for:

Bigger numbers = better (not true in all cases).
If being capped is causing framerate to drop below vsync or be unstable in situations where the GPU can handle well above vsync with no problem. This is likely caused by inter-frame dependencies and is definitely one of the things I want feedback on - the deferred renderer may already improve this.

See my response to that in the conversation following - it's not a Vulkan issue. The deferred renderer should have fixed Vulkan otherwise (it bricking the game when entering gameplay). Have I missed something else?

I'll admit I haven't exactly debugged but in profiling it appeared there was a vulkan-specific issue with constant allocation increases on the... buffering? masking? performance test scene that neither opengl nor d3d11 did not exhibit.


Use Bot instead of AutoShardedBot.

I am glad to announce that our highly trained engineer monkeys have finally accomplished the complex task that mankind struggled on for the entirety of 4 days, and made the bot use discord.ext.commands.Bot instead of discord.ext.commands.AutoShardedBot.
(Closes #87.)

I would approve this, however, although AutoShardedBot is no longer what the instance is, nearly all cogs have type hints dictating that self.bot or whatever is still a discord.ext.commands.AutoShardedBot. Until this is fixed this can not be approved.

Just need to update your branch from master, you are missing some cogs, I can see that RabbitMQ is missing off the top of my head.


problem with aggregated_by and mdtol and masks with iris2.1 and numpy1.15

When I run these commands in python2.7 with iris 2.1 and numpy 1.15, I get the error messages in traceback below.
PYTHON commands:
import iris
cube = iris.load_cube('example.nc')
#check to see if the data is there:
cube.data
cube = cube.aggregated_by(["year", "day_of_year"], iris.analysis.MEAN, mdtol=0.03)

The 20MB example.nc NETCDF file is available here:
https://drive.google.com/open?id=1hZNWXs7wOtBq2dXWM1zbAJnVMjy_DXc7
Traceback (most recent call last):
  File "test10.py", line 10, in <module>
    cube = cube.aggregated_by(["year", "day_of_year"], iris.analysis.MEAN, mdtol=0.03)
  File "/Users/pmcguire/fluxnet1/iris/cube.py", line 3414, in aggregated_by
    **kwargs)
  File "/Users/pmcguire/fluxnet1/iris/analysis/__init__.py", line 524, in aggregate
    result.mask = result.mask | mask_update
  File "/Users/pmcguire/.local/lib/python2.7/site-packages/numpy/ma/core.py", line 6339, in __setattr__
    "attributes of {!r} are not writeable".format(self))
AttributeError: attributes of masked are not writeable

I have tracked this down I think.
I could get test_fluxnet_evaluation.py to work if I comment out the three lines below from the _Aggregator(object).aggregate method in iris/analysis/init.py (near line 514) of a copy of iris2.1.
The result.mask below was not defined for some reason even though ma.isMaskedArray(result) is true.
      result = self.call_func(data, axis=axis, **kwargs)
        if (mdtol is not None and ma.isMaskedArray(data)):
            fraction_not_missing = data.count(axis=axis) / data.shape[axis]
            mask_update = 1 - mdtol > fraction_not_missing
            #if ma.isMaskedArray(result):
            #    result.mask = result.mask | mask_update
            #else:
            result = ma.array(result, mask=mask_update)

In version Iris1.13, this problem does not exist.
I can reproduce this problem if I upgrade from Iris1.13 to Iris2.2.0dev0, including all dependencies.
But then when I downgrade only Iris2.2 -> Iris.1.13, keeping the updated dependencies, the bug persists.
But then when I downgrade only Iris2.2 -> Iris.1.13 and numpy1.15->numpy1.12.1, keeping the updated dependencies, the bug goes away.
So I think it's something in numpy.
When it works with Iris1.13 and numpy1.12.1, Aggregrate (with iris.analysis.Mean) function tries to override the (non-array) mask value for the day, and it can do this, because the mask is writeable. But when it doesn't work with iris2.1 and numpy1.15, this function fails because this mask is not writeable.
2)A quick perusal of the numpy1.15 documentation suggests that they changed the mask behavior: https://docs.scipy.org/doc/numpy/release.html
"np.ma.masked is no longer writeable:
Attempts to mutate the masked constant now error, as the underlying arrays are marked readonly. In the past, it was possible to get away with...".
I am not sure if this is the change which is affecting us or not.
Can someone fix this problem in iris? Should I just maintain a separate iris branch (with those three lines commented out) for my own purposes till this is fixed? Or does anybody have a better solution? I am not sure if I should downgrade numpy or not.
Thanks,
Patrick McGuire
Department of Meteorology and Department of Geography & Environmental Science
University of Reading
Personal Web Page: http://www.personal.reading.ac.uk/~gn916173

Hi @mcguirepatr - thanks for raising this issue report! As it happens I was just looking at your post on Google Groups; apologies that no-one has responded to your post there as yet.
I've successfully reproduced the issue you report here, and I think you're spot on in looking at NumPy as the cause of this issue, so we'll try and dig in and see if we can get a fix in place. In fact, your note about removing the mask update lines is very helpful for pointing towards a fix for this as it points to what the origins of the problem likely are. There are two:

The NetCDF representation of data has recently changed such that all files are loaded with masked data by default, even if no masked points are present. This can cause a functionality problem in some cases, where the mask can be False (just a single value). I think this is happening here - but I need to check that.
The line that reads if ma.isMaskedArray(result): should read if ma.is_masked(result):, as that provides a more general check that can deal with the presence of a mask, even if no masked points are set (that is, it can deal with situations like the one I outlined in the previous bullet point).

By the way, you don't need to call cube.data, as per the third line in your sample code. What this will do is load all data points off of disk and into memory. This has a performance impact and memory usage impact that increases with increased data sizes. Most operations in Iris are fully-functional (and automatically parallelised) without needing to load data in this way. Those that aren't will automatically load the data when it's needed.
(In connection to this point, I tried running your sample code without loading the data, and I noticed that Iris did not use the lazy aggregator in this case, which should probably also be investigated.)
P.S. I edited your initial post as there was some odd styling going on.

Iris did not use the lazy aggregator in this case

This is explained by #3129.

Thanks for your help with this, Mr. Killick!
Did you figure out how to fix it?
Patrick McGuire

as supporting info, I confirm that the example given appears CORRECTLY in OSGeoLive 12.0
scitools-iris==2.1.0; Cartopy==0.14.2; cf-units==2.0.2 matplotlib==2.1.1; nc-time-axis==1.1.0 jupyter-core==4.4.0; jupyter-client==5.2.2 netCDF4==1.3.1; Cython==0.26.1; future==0.15.2; pyke==1.1.1; six==1.10.0
Ubuntu 1804;  Python 2.7;     iris_3190_bug_example.nc    21MB

I'm also having this problem on the same system as Patrick - I think it's happening when one or more of the elements are masked after applying the aggregating function but before using mdtol.
Is there a work-around?
Thanks!
Example 1:
import numpy as np
import iris
cube = iris.cube.Cube(np.ma.MaskedArray([3]))

cube.add_dim_coord(iris.coords.DimCoord([1],long_name='foo'), (0,))

cube.aggregated_by('foo', iris.analysis.MEAN, mdtol=0.5) # no error

cube.data[0] = np.ma.masked

cube.aggregated_by('foo', iris.analysis.MEAN) # no error
cube.aggregated_by('foo', iris.analysis.MEAN, mdtol=0.5) # ValueError: assignment destination is read-only

Example 2:
import numpy as np
import iris

cube = iris.cube.Cube(np.arange(4) * 10.0)
cube.data = np.ma.asanyarray(cube.data)

dim_coord = iris.coords.DimCoord(np.arange(4),long_name='sample')
aux_coord = iris.coords.AuxCoord([2000, 2000, 2001, 2001], long_name='year')
cube.add_dim_coord(dim_coord, (0,))
cube.add_aux_coord(aux_coord, (0,))

cube.aggregated_by('year', iris.analysis.MEAN, mdtol=0.03) # no error

cube.data[0] = np.ma.masked
cube.aggregated_by('year', iris.analysis.MEAN, mdtol=0.03) # no error

cube.data[1] = np.ma.masked
cube.aggregated_by('year', iris.analysis.MEAN, mdtol=0.03) # ValueError: assignment destination is read-only

This is what I've come up with so far as a work-around for Patrick's original example but it's pretty convoluted - there must be a better way! :)
import numpy as np
import iris
cube = iris.load_cube('~/example.nc')

try:
    agg_cube = cube.aggregated_by(["year", "day_of_year"], iris.analysis.MEAN, mdtol=0.03)

except ValueError:

    def make_doy_yyyy_arr(in_cube):
        '''
        Makes a list of the form ['DOY-YYYY', 'DOY-YYYY',....] using the 'day_of_year'
       and 'year' coordinates in a cube.
        '''
        mylist = [str(in_cube.coord('day_of_year').points[i]) + '-' + str(in_cube.coord('year').points[i]) for i in range(len(in_cube.coord('year').points))]
        return mylist

    # do the aggregation without mdtol
    agg_cube_no_mdtol_used = cube.aggregated_by(["year", "day_of_year"], iris.analysis.MEAN)

    # get rid of masked days (i.e. days with no valid data)
    agg_cube_no_mdtol_used = agg_cube_no_mdtol_used[~agg_cube_no_mdtol_used.data.mask]

    # get list of days which have at least one data point
    doy_yyyy_after_agg =  list(set(make_doy_yyyy_arr(agg_cube_no_mdtol_used)))

    # get list of 'DOY-YYYY' for each time step in original cube
    doy_yyyy_before_agg = make_doy_yyyy_arr(cube)

    # has_data indicates, for each timestep in the original cube, whether it's part of a day with at least some data
    has_data = []
    for i in range(len(doy_yyyy_before_agg)):
        if doy_yyyy_before_agg[i] in doy_yyyy_after_agg:
            has_data.append(True)
        else:
            has_data.append(False)

    # take out timesteps from days with no data
    new_cube = cube[has_data]

    # try the agggregation with mdtol again
    agg_cube = new_cube.aggregated_by(["year", "day_of_year"], iris.analysis.MEAN, mdtol=0.03)

print agg_cube

I've reproduced the errors from @mcguirepatr's and @kwilliams-mo's examples with latest master branch (almost v3).  However, I note that the problem goes away if the cube's input data is lazy (lazy aggregated_by was introduced at Iris v2.4).  So one way to fix this would be to implement #2418.

This is now fixed ready for Iris v3.3 (due out in the summer).  Sorry it took so long and thanks for your efforts in digging into the problem @mcguirepatr and @kwilliams-mo!


fix: Cannot find module 'fs-extra-promise’ during install

This change is

Test 89614235b5a16dd(b5a16dd) has failed
See https://github.com/ThaliTester/TestResults/tree/89614235b5a16dd_fix__Cannot_find_module__fs-extra-promise’_during_install_larryonoff/ for the fail logs

@yaronyg please review.
I'm almost sure that you won't like the install.js, line 368, but this's line as a brother to the line npm install --no-optional --production.

Test 896142354fd14d5(4fd14d5) has failed
See https://github.com/ThaliTester/TestResults/tree/896142354fd14d5_fix__Cannot_find_module__fs-extra-promise’_during_install_larryonoff/ for the fail logs

I don't believe this checkin is necessary. Please see the comments.

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.

thali/install/install.js, line 90 at r1 (raw file):

          return conf.thaliInstall;
        }
        return Promise.reject('Configuration error!');

Shouldn't this return new Error('Configuration error!');?

thali/install/install.js, line 309 at r1 (raw file):

  var thaliProjectName, thaliDepotName, thaliBranchName, btconnectorlib2;

  getReleaseConfig(thaliDontCheckIn)

Why are we passing thaliDontCheckIn to getReleaseConfig when it doesn't actually take an argument?

thali/install/install.js, line 354 at r1 (raw file):

        return uninstallPluginsIfNecessary(weAddedPluginsFile, appRootDirectory)
          .then(function () {
            // this section isn't valid, but it has to be at the moment

This section isn't necessary. What I believe caused the problem is that Rockwell didn't follow the instruction in the readme to 'mkdir -p FooBar/thaliDontCheckIn/localdev'. This instruction tells the install script to just copy the contents of the cloned depot instead of downloading the zip file. If that command had been executed then later on when we call 'jx npm install ../../../Thali_CordovaPlugin/thali/' this would trigger the postInstall script which runs installCordovaPlugin.js which then runs npm on the install directory thus rending this new code unnecessary.

Comments from Reviewable

PR is added to the queue for testing as 1. task. (33949f2)

Test (Success) 89614235 build is completed (33949f2)
See https://github.com/ThaliTester/TestResults/tree/8961423533949f2_fix__Cannot_find_module__fs-extra-promise’_during_install_larryonoff/ for the logs

Test<PHONE_NUMBER>949f2(33949f2) has failed
See https://github.com/ThaliTester/TestResults/tree/8961423533949f2_fix__Cannot_find_module__fs-extra-promise’_during_install_larryonoff/ for the fail logs

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.

thali/install/install.js, line 90 at r1 (raw file):
Previously, yaronyg (Yaron Y Goland) wrote…
> Shouldn't this return new Error('Configuration error!');?

The next `.then` block will receive error as a next value in case of returning `Error('Configuration error!')`, so returning Error isn't valid.

thali/install/install.js, line 309 at r1 (raw file):
Previously, yaronyg (Yaron Y Goland) wrote…
> Why are we passing thaliDontCheckIn to getReleaseConfig when it doesn't actually take an argument?

Looks very reasonable. It looks that it comes from some old logic when this function took arguments.
I'll fix it.

thali/install/install.js, line 354 at r1 (raw file):
Previously, yaronyg (Yaron Y Goland) wrote…
> This section isn't necessary. What I believe caused the problem is that Rockwell didn't follow the instruction in the readme to 'mkdir -p FooBar/thaliDontCheckIn/localdev'. This instruction tells the install script to just copy the contents of the cloned depot instead of downloading the zip file. If that command had been executed then later on when we call 'jx npm install ../../../Thali_CordovaPlugin/thali/' this would trigger the postInstall script which runs installCordovaPlugin.js which then runs npm on the install directory thus rending this new code unnecessary.

I've analysed readme and install.js. As result we have the following scenario.

jx npm install ../../../Thali_CordovaPlugin/thali/ --save --no-optional --autoremove "*.gz" is executed.
thali and thali/install packages are installed for the base directory ../../../Thali_CordovaPlugin/thali/
install.js script downloads Thali from GitHub
install.js runs cordova add for the folder downloaded from GitHub

As result since Cordova hooks depend on installer packages and since we've downloaded clean copy from GitHub packages cannot be found.
So we need somehow install packages for Cordova hooks.

Comments from Reviewable

PR is added to the queue for testing as 3. task. (98e234c)

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.

thali/install/install.js, line 354 at r1 (raw file):
Previously, larryonoff (larryonoff) wrote…
> I've analysed readme and install.js. As result we have the following scenario.
>
> 1. `jx npm install ../../../Thali_CordovaPlugin/thali/ --save --no-optional --autoremove "*.gz"` is executed.
> 2. `thali` and `thali/install` packages are installed for the base directory `../../../Thali_CordovaPlugin/thali/`
> 3. `install.js` script downloads Thali from GitHub
> 4. `install.js` runs `cordova add` for the folder downloaded from GitHub
>
> As result since Cordova hooks depend on installer packages and since we've downloaded clean copy from GitHub packages cannot be found.
>
> So we need somehow install packages for Cordova hooks.

In addition

"Why it works for build.sh"
Because script created thaliDontCheckIn/localdev directory what means that local thali clone will be used.

When the local folder already has all packages installed.

Comments from Reviewable

Test (Success) 89614235 build is completed (98e234c)
See https://github.com/ThaliTester/TestResults/tree/8961423598e234c_fix__Cannot_find_module__fs-extra-promise’_during_install_larryonoff/ for the logs

Test<PHONE_NUMBER>e234c(98e234c) has failed
See https://github.com/ThaliTester/TestResults/tree/8961423598e234c_fix__Cannot_find_module__fs-extra-promise’_during_install_larryonoff/ for the fail logs

PR is added to the queue for testing as 1. task. (8bc729a)

@yaronyg I've analysed the problem deeper. As result I see that README is correct and prepare.sh is correct. The problem occurs since how Cordova runs its hooks. It copies it's hooks into installed plugin directory and then run it's scripts, the hooks folder is for example ThaliTestApp/plugins/org.thaliproject.p2p/thali/install/cordova-hooks, so this folder obviously not having required packages, since it's already installed Cordova plugin folder and not our thali installer folder.

Test (Fail) 89614235 build is completed (8bc729a)
See https://github.com/ThaliTester/TestResults/tree/896142358bc729a_fix__Cannot_find_module__fs-extra-promise’_during_install_larryonoff/ for the logs

PR is added to the queue for testing as 1. task. (77ead0c)

Test (Fail) 89614235 build is completed (77ead0c)
See https://github.com/ThaliTester/TestResults/tree/8961423577ead0c_fix__Cannot_find_module__fs-extra-promise’_during_install_larryonoff/ for the logs

PR is added to the queue for testing as 1. task. (8645e5e)

Test (Success) 89614235 build is completed (8645e5e)
See https://github.com/ThaliTester/TestResults/tree/896142358645e5e_fix__Cannot_find_module__fs-extra-promise’_during_install_larryonoff/ for the logs

Test<PHONE_NUMBER>45e5e(8645e5e) has failed
See https://github.com/ThaliTester/TestResults/tree/896142358645e5e_fix__Cannot_find_module__fs-extra-promise’_during_install_larryonoff/ for the fail logs

PR is added to the queue for testing as 1. task. (fd4d6ce)

Test (Success) 89614235 build is completed (fd4d6ce)
See https://github.com/ThaliTester/TestResults/tree/89614235fd4d6ce_fix__Cannot_find_module__fs-extra-promise’_during_install_larryonoff/ for the logs

Test 89614235fd4d6ce(fd4d6ce) has failed
See https://github.com/ThaliTester/TestResults/tree/89614235fd4d6ce_fix__Cannot_find_module__fs-extra-promise’_during_install_larryonoff/ for the fail logs

this should be fixed. the fix is just to run setUpDesktop.sh before thali install.


Add optional simplified game abstraction core module

DO NOT MERGE YET!
See https://github.com/PistonDevelopers/piston/issues/1340

Closing, since this won't be added.


Add tests to ELTs

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/24
Originally created by @jschatz1 on 2018-04-11 14:00:13

This issue is to track the adding of tests to ELTs.
cc @mbergeron @tayloramurphy

View 11 previous comments from the original issue on GitLab


Allow awards to remove roles

Description
Allows for guild award level that remove a role rather than add it. This is to support trial runs.
Checklist

[x] Add tests for these changes
[x] Test coverage is not decreased
[x] Entire test suite passes

Codecov Report

Merging #710 (59c41da) into main (9c28b0d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #710   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           70        71    +1
  Lines         3145      3165   +20
  Branches       313       314    +1
=========================================
+ Hits          3145      3165   +20

Impacted Files
Coverage Δ

src/spellbot/cogs/admin_cog.py
100.00% <100.00%> (ø)

src/spellbot/interactions/admin_interaction.py
100.00% <100.00%> (ø)

src/spellbot/interactions/lfg_interaction.py
100.00% <100.00%> (ø)

...rsions/42f55401ef2b_adds_removeable_role_awards.py
100.00% <100.00%> (ø)

src/spellbot/models/award.py
100.00% <100.00%> (ø)

src/spellbot/operations.py
100.00% <100.00%> (ø)

src/spellbot/services/awards.py
100.00% <100.00%> (ø)

src/spellbot/services/guilds.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c28b0d...59c41da. Read the comment docs.

Codecov Report

Merging #710 (59c41da) into main (9c28b0d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #710   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           70        71    +1
  Lines         3145      3165   +20
  Branches       313       314    +1
=========================================
+ Hits          3145      3165   +20

Impacted Files
Coverage Δ

src/spellbot/cogs/admin_cog.py
100.00% <100.00%> (ø)

src/spellbot/interactions/admin_interaction.py
100.00% <100.00%> (ø)

src/spellbot/interactions/lfg_interaction.py
100.00% <100.00%> (ø)

...rsions/42f55401ef2b_adds_removeable_role_awards.py
100.00% <100.00%> (ø)

src/spellbot/models/award.py
100.00% <100.00%> (ø)

src/spellbot/operations.py
100.00% <100.00%> (ø)

src/spellbot/services/awards.py
100.00% <100.00%> (ø)

src/spellbot/services/guilds.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c28b0d...59c41da. Read the comment docs.


Ability to move another user from channel (with admin permission)

Rework the API to allow an admin to move another user into a channel.
I'll do this and submit a pr.

done in PR #47 (requires usage of mumble certificates, otherwise you won't have access rights)


Issue with Upload Button Directive

I keep getting the following error during installation:
The directive name [cld-upload-button] is not valid. Directive names must only contain alphanumeric characters and underscores.

Please i don't understand how I will replace - with _ for blade component directives cause I didn't use any - (dashes)

You are not supposed to replace - with _ , I had an issue while installing
the package in Laravel 6. Fixed it(hopefully) and sent in this pull
request. If you are having the same issue, I would advise you upgrade your
project to Laravel 7.
On Mon, 31 Aug 2020 at 17:24, Mbah Derek<EMAIL_ADDRESS>wrote:

Please i don't understand how I will replace - with _ for blade component
directives cause I didn't use any - (dashes)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cloudinary-labs/cloudinary-laravel/issues/2#issuecomment-683884602,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALP3ZWWQYQPNAJQ3PGKJ3A3SDPFFXANCNFSM4PUBHHNA
.

--

@derekdunes Are you having the same issue. I have to backport this issue just for Laravel 6 only. Laravel 8 will be out in a couple of weeks and I don't want to break anything.

I am even working with laravel 5.* ; will upgrade to 7 immediately. I just remembered I used it in laravel 7 and I had no issues with it. Thanks alot @unicodeveloper @aremu-smog. You guys are d best

I have made a fix to support Laravel 6. Please update to use the latest version: 1.0.2. @aremu-smog @derekdunes . Unfortunately, we can't support 5.8. Too backward from Laravel 8.


Add ColumnSubsetAnalyzer

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f131724) 99.89% compared to head (91b381a) 99.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   99.89%   99.89%
=======================================
  Files          46       47    +1
  Lines         940      961   +21
  Branches       93       93
=======================================
+ Hits          939      960   +21
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Feat/swerve

Implement Phoenix 6 swerve builder, should function very similarly (for basic drive, not sure about odometry, have to look into that)
In order to get rid of unrelated errors to work on swerve I... very messily commented out/deleted the offending files. So, anything related to pathplanner had been commented out and it's very messy (like GOOD GOD is it messy). Should I just delete those files so later pathplanner developments can just fill them in?
Also not entirely sure about how good the swerve implementation is.

don't merge yet. going to delete the jank pathplanner stuff; leave empty slate for future dev


Make .cs highlighting legible on dark themes

Fixes https://github.com/go-gitea/gitea/issues/19602.
Before:

After:

NOTE:
I'm not presently able to build Gitea from source, so I have demo'd this style change by editing theme-arc-green.css in devtools. I hope this is acceptable given the scope of the PR.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2d40a4a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #19604   +/-   ##
=======================================
  Coverage        ?   47.41%
=======================================
  Files           ?      953
  Lines           ?   132668
  Branches        ?        0
=======================================
  Hits            ?    62908
  Misses          ?    62180
  Partials        ?     7580

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d40a4a...971dd18. Read the comment docs.

@Eekle  if you want to have this fixe in 1.16.x, you can send a backport to 1.16 (a new PR for 1.16 branch)

@Eekle if you want to have this fix in 1.16.x, you can send a backport to 1.16 (a new PR for 1.16 branch)

Thank you I will!


Fix crash generated from super class restoreInstanceState method

@nasthagiri @shahidtamboli I have added try-catch block which fixes the crash. This is a workaround and I have added a FIXME comment.
JIRA: https://openedx.atlassian.net/browse/MOB-1287
Please review.

:+1:

Same question as over here https://github.com/edx/edx-app-android/pull/3#issuecomment-70756725

Seems like crash occurs in restoring some of the views. We don't save any view's state during orientation change. However, we have different layout in landscape and in portrait mode as Landscape only has player in full screen. This might be a cause.
However, we see that there are no implications of failure of super.onRestoreInstanceState.

I wish I understood why this happened, it seems like something else is the real issue, but this seems harmless, so I guess it's okay to commit.

@aleffert My comment on the other PR explains why this is happening.

:+1:

I merge this without any version check, as this fix works for us and I log the error if it occurs.

I close this PR as this PR is on old code structure and I merge the same fix on #125 .


[v2] Some Mac keystrokes (delete-word, jump-to-beginning, etc) don't work anymore

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: OSX 10.11.3
Hyper.app version: 2.0.2
The issue is reproducible in vanilla Hyper.app: Yes

Issue

On all OSX text editors:

Cmd+LeftArrow and Cmd+RightArrow jump to the beginning and end of the line.
Cmd+BackSpace delete the entire line.
Alt+Backspace delete the previous word.

That used to work on Hyper 1, but it doesn't work on Hyper 2 anymore.
The only thing which is still working is:

Alt+LeftArrow and Alt+RightArrow jump to the next or previous word.

Same on 2.0.3.
Also CMD + SHIFT + LEFT / RIGHT to switch tabs. And if you use hyperterm-tabs re-ordering tabs also stopped working with shortcut.

Any updates for this issue ? (see also https://github.com/zeit/hyper/issues/1361)

Fixed in canary branch with: https://github.com/zeit/hyper/pull/2426
It will be landed in next canary release

thanks @chabou

What about these keystrokes: alt+b jump backwards, alt+f to jump forward, alt+., etc?
These don't seem to work on the latest canary build. Using Mac OSX--and I did also try it with modifierKeys: { altIsMeta: true } in .hyper.js but no bueno.


Error: Decoding error on undefined: unprocessed data left on queue

Hello, I'd just received this error while using the API:
Error: Decoding error on undefined: unprocessed data left on queue (["20230727 02:49:21 EST",null]). Please report to https://github.com/stoqey/ib 505
It says to report it, so I am making this issue thread, feel free to close.
To get this error, I am using the reqMatchingSymbols method on IBApi. In particular, I am using React to take a text input, and whenver the user types, then sending this request using your library to IB, and getting the response. Furthermore, I am using both the ib.connect and ib.disconnect method every time the user types a single character in the react field, and the data itself is passed through electron IPC, so there is a lot of friction.Therefore, this error is most likely due to a very large amount of requests in a short amount of time, as I'm getting a couple other errors such as "Error: No parser implementation found for token: undefined (166). 505". If you would like to see the code, please let me know. Thank you for your time.

Hello,
thanks for reporting.
Can you tell us what parameters values for reqMatchingSymbols are raising this error?
This info would help to reproduce and investigate.
Thanks

Hello, thanks for reporting. Can you tell us what parameters values for reqMatchingSymbols are raising this error? This info would help to reproduce and investigate. Thanks

Certainly. I used ib.once(EventName.nextValidId) to obtain the orderId, which I passed as the first input for reqMatching symbols, and for the second parameter I used a string, usually something like "aa" or "tsl", anything that would be the beginning of a ticker symbol.
However, it is worth it to note that I implemented a delay of 0.5ms between each reqMatchingSymbols request, and this had completely solved any errors I had using the API. Hope this helps.

Hello,
I created a new unit test to try to reproduce your bug: src/tests/unit/api/matching-symbols.test.ts
Where I call reqMatchingSymbols 3 times with connection/disconnection each time but I didn't get your bug.
If you have some time to edit the test to show up the problem, we could investigate.
Thanks

Hello,
I close this issue because:

no more activity for 1 year
I fixed a bug with connection setup code that have probably solved this issue
Feel free to revert back if the issue is still alive


Roll Flutter Engine from 9600c6c39b72 to 8f3402e0018d (2 revisions)

https://github.com/flutter/engine/compare/9600c6c39b72...8f3402e0018d
2022-08-25<EMAIL_ADDRESS>Roll Skia from 848fe76219b0 to 1c68c37b1108 (2 revisions) (flutter/engine#35695)
2022-08-25<EMAIL_ADDRESS>Roll Skia from f0e6ef75e7f2 to 848fe76219b0 (1 revision) (flutter/engine#35694)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Use of Burp extension API to issue HTTP(S) requests

This is a draft to make boto issue HTTP(S) requests through the Burp extension API.

This allows to reuse upstream proxy settings defined in Burp
This gives an opportunity to log requests made by aws-extender (with Logger++ for instance)

Code is far from prefect, I will refine it if the concept is accepted.

Hey @SlivTaMere,
Thanks for the pull request. We do appreciate the effort you put into this so far; however, this will definitely increase the complexity of the code and possibly cause unexpected issues later on. I'll get back to you once we discuss the matter internally and agree on a decision in this regard.
Until then, you can continue to refine the code, and we'll be happy to merge it into a separate branch other than master.
Thanks!


fix the position of the nav bar

The position of the nav bar along with its elements has been fixed at the top of the webpage.
A translucent background for the nav bar to enhance visibility has been added.

@Virtual4087

Looks good @Divii2205

@Virtual4087 Thank you so much!


'iostream' file not found

Hello, I'm a bit new to vim so I apologize for my newbieness and my limited understanding of anything.

I have an issue where the 'iostream' file is not found.
I essentially followed this  YouTube video here: https://www.youtube.com/watch?v=7-dfpQ5sexk&t=627s . Where he shows how to install the clangd extension (7:26).
I already have MingW installed.
The clangd --version command doesn't show on the command line so I don't know if that should be concerning.
Operating System: Windows 10

You need to setup compile_commands.json for your project, checkout https://clangd.llvm.org/installation#project-setup


[Bug]: zscaler detecting scripts running as old version of chrome and blocking them from executing

What happened?
error that the scripts have been blocked by zscaler for emulating chrome v7.  need to be able to use edge or emulate a more recent version of chrome
Version
2403.889
What PowerShell edition/s are you running Evergreen on?
Windows PowerShell
Which operating system/s are you running Evergreen on?
Windows Server 2016+
Have you reviewed the documentation?

[X] Troubleshooting at: https://stealthpuppy.com/evergreen/troubleshoot/
[X] Known issues at: https://stealthpuppy.com/evergreen/issues/

Verbose output
zscaler has blocked chrome v7

Recommend we update UserAgent used in various functions to align to the Microsoft Edge user agent

This is included in the 2404.901 release. Could please test and see what the result is?

Will do when I return to the office next week
Get Outlook for iOShttps://aka.ms/o0ukef

From: Aaron Parker @.>
Sent: Tuesday, April 9, 2024 4:06:37 AM
To: aaronparker/evergreen @.>
Cc: sarjent @.>; Author @.>
Subject: Re: [aaronparker/evergreen] [Bug]: zscaler detecting scripts running as old version of chrome and blocking them from executing (Issue #642)
This is included in the 2404.901 release. Could please test and see what the result is?
—
Reply to this email directly, view it on GitHubhttps://github.com/aaronparker/evergreen/issues/642#issuecomment-2044506555, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIOUBVJKRSK7SH3UBUO6BWDY4OVR3AVCNFSM6AAAAABE62YO4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBUGUYDMNJVGU.
You are receiving this because you authored the thread.Message ID: @.***>

Hi Set it to version 122 does not realy solve the problem - my customer has zscaler to Block Chrome older than 123.x
see https://github.com/aaronparker/evergreen/discussions/659#discussion-6542850
Chrome is actually 124.x - but new updates come fast...


upgrade tutorials version

this PR does two things:

add tracking tutorial to TOC
update tutorial versions to ipython3 (else ipython2 pygment lexer issues)

note: please upgrade your ipython version and use python3

tip: you can change these metadata for all notebooks by updating cleannb.py


Bug in mir-gen-x86_64.c on bbv branch

Bug is here: https://github.com/vnmakarov/mir/blob/bbv/mir-gen-x86_64.c#L905-L907
      gen_add_insn_before (gen_ctx, insn, new_insn);
      va_reg = va_op.var;
      gen_mov (gen_ctx, insn, MIR_MOV,
               _MIR_new_var_mem_op (ctx, MIR_T_I64, 0, va_reg, MIR_NON_VAR, 1), treg_op);

va_op has type MIR_op_t, which definition is:
typedef struct {
  void *data; /* Aux data  */
  MIR_op_mode_t mode : 8;
  /* Defined after MIR_func_finish.  Only MIR_OP_INT, MIR_OP_UINT,
     MIR_OP_FLOAT, MIR_OP_DOUBLE, MIR_OP_LDOUBLE: */
  MIR_op_mode_t value_mode : 8;
  union {
    MIR_reg_t reg;
    MIR_reg_t var; /* Used only internally */
    int64_t i;
    uint64_t u;
    float f;
    double d;
    long double ld;
    MIR_item_t ref; /* non-export/non-forward after simplification */
    MIR_str_t str;
    MIR_mem_t mem;
    MIR_mem_t var_mem; /* Used only internally */
    MIR_label_t label;
  } u;
} MIR_op_t;

I think the currect code is va_reg = va_op.u.var;.

Oh, I think ci has already catch the bug:
D:\a\mir\mir\mir-gen-x86_64.c(906,22): error C2039: 'var': is not a member of 'MIR_op_t' [D:\a\mir\mir\mir.vcxproj]
D:\a\mir\mir\mir.h(251,16): message : see declaration of 'MIR_op_t' [D:\a\mir\mir\mir.vcxproj]

Thank you for reporting this.  I've just fixed this.
To be honest I do not test code on Win32 manually.  Therefore I should have looked at CI results to avoid this kind of issues.
Now I see that windows port on bbv branch is broken (master branch is ok on windows).  Some tests crashed by sigfault.  I'll investigate it later.

Thanks for your explanation!


VSCode loses connection with WSL:Ubuntu terminal after a period of time, requires restart

VSCode Version: 1.49.2
OS Version: Windows 10.0.18363

Steps to Reproduce:

Open VSCode with the WSL Extension into Ubuntu, develop with Python, using the debugging functionality for a some time
Observe the terminal becoming completely unresponsive, with the debugging functionality freezing, and losing the ability to save files.

Restarting the whole application resets "the timer", so to speak.
Sorry if this is too vague. I figured I'd try to report this anyway, since rumors can be helpful sometimes.

Does this issue occur when all extensions are disabled?: Probably not, since it depends on the WSL Extension.

I have updated to WSL 2 and have had a much better experience so far, no need for a restart yet. Will keep posted.

Haven't had the issue again. It's likely the better memory management in WSL 2 fixed my issues. Thanks!


Update the github issue template to be goal-oriented

The current template for feature requests focuses on the specific proposed solution, rather than the user need. It feels like we should be encouraging the opposite (and I usually find myself editing the template to do so when creating new issues)

LGTM.

I'm not totally sure this is an improvement. "What is the ask?" and "What is the goal / desired outcome?" do seem a little redundant, I think people have been interpreting them as "What is your situation / use case?" and "How do you imagine this being solved?" which is getting us the information we want. I worry that "What is the goal / desired outcome?" will just get us short answers like "I want to run my pipeline on historical data." without pushing people to tell us more about their use case / situation from which we normally discover that they're doing something else wrong with the system and won't need the behavior they think they want if they use the system as intended. That was the main purpose of this template initially.

Another worry I have is that by asking: "What is your proposal for a feature to solve this?" it makes it seem like we're looking for people to have a thought out implementation for the feature, some people will have this but we probably don't want people to feel like that's a requirement for opening an issue.

Changed this ever so slightly, ordering and specifying that feature recommendation is optional. Not sure if it really improves it much, I probably should have just merged this initially.


Add StreamMessage.mapAsync()

Currently, StreamMessage provides limited operations such as map, filter.
Those operations are synchronous and can not handle asynchronous tasks.
mapAsync would be useful to transform data with extra information that is in external services.
interface StreamMesage<T> {
    // The next item will be requested after the returned future is completed successfully.
    StreamMessage<U> mapAsync(Function<T, CompletableFuture<U>> function);
}

I'd like to work on this issue

Thanks in advance!


Solved public relationship issue Swift 1.2

#295 Solved this issue

When will this be merged to swift12 branch?

@anilreddi i don't know mate also i am not pretty much confident about the solution so might not sure about this , but i hope some expert find the solution soon because this is very Major bug and not allow us to build so lets hope for the best

Is this merged? I am still getting this error in 1.29

We are declaring pull request and issue 0 now that 1.3 is out. If this is still an issue you'd like to see address with 1.30 and going forward, please open a new issue so we can start a fresh discussion. Thank you!


[4.9.0] clearer documentation

The clutter has been removed out of the documentation site. It previously had mixed internals as well as the exposed API, which was confusing.

@all-contributors please add @pirix-gh

@all-contributors please add @pirix-gh for docs


Feature/ui tidy up

Task/Issue URL: https://app.asana.com/0/inbox/471012189846018/593495966844380/592667188539744
Tech Design URL:
CC:
Description:
There were a few big UI changes that happened since the last release, including the consolidation of the landing page and the introduction of tabs.
This task is about tidying up some of the rough edges around the UI that were either introduced during these features, or that couldn't be easily fixed until they were completed.
Steps to test this PR:

Test the animation on the DDG logo on the landing page.

Fresh app launch
Returning to running app
Launching using widget
Launching with assist intent
Returning to landing page from webview
Returning to landing page from settings/bookmarks/tabs screen

The toolbar shouldn't shrink in width (which was happening sometimes; though not easily reproducible
Keyboard should generally appear when you want it to and not when you don't.

If it ever surprises you, make a note of it and we'll compare expectations or determine if it's a bug.

Internal references:
Software Engineering Expectations
Technical Design Template

We're pretty close to finalising this - I have to leave for a few hours; happy to merge whenever you're happy with the final tweaks @subsymbolic

Added some final keyboard tweaks with @CDRussell permission.


Added signs to QuickAccent

Summary of the Pull Request
Added signs to QuickAccent
°C to C
© to C
ℂ to C
∈ to E
°F to F
ℕ to N
℗ to P
ℚ to Q
® to R
ℝ to R
™ to T
V̇ to V
ℤ to Z

PR Checklist

[X] Closes: #26025
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[X] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@microsoft-github-policy-service agree

I've added a commit to work out some conflicts.
@WilkoLu , I hope that's all as you still want.
From the comment in the issue, you said that this was made by a group of students. I can add some coauthor lines in the final commit so that the contribution gets associated with everyone that worked on this.
Here's an example of such a line when it's me:
Co-authored-by: Jaime Bernardo<EMAIL_ADDRESS>
That e-mail address is associated with my GitHub account, so the contribution would appear on my profile.
Can you please send me a list of lines with your classroom mates so I can properly attribute the contribution?

I've added a commit to work out some conflicts.
@WilkoLu , I hope that's all as you still want. From the comment in the issue, you said that this was made by a group of students. I can add some coauthor lines in the final commit so that the contribution gets associated with everyone that worked on this. Here's an example of such a line when it's me:
Co-authored-by: Jaime Bernardo<EMAIL_ADDRESS>
That e-mail address is associated with my GitHub account, so the contribution would appear on my profile. Can you please send me a list of lines with your classroom mates so I can properly attribute the contribution?

Thanks for your review @jaimecbernardo. Of course i can add some coauthors!
Co-authored-by: Eike Rodenbaeck<EMAIL_ADDRESS>Co-authored-by: Colin Sontag<EMAIL_ADDRESS>Co-authored-by: Dennis Mehner<EMAIL_ADDRESS>