Support RHEL 9 as OS

What it says on the title. Not sure what is missing for this, but we should make sure we support it and validate that support.

/remove-lifecycle stale

/remove-lifecycle stale

Any plan for this request?

/remove-lifecycle stale
Hi @waqarkhan88, sorry for the late reply. This currently doesn't have priority, but we welcome contributions or a request through our support portal if you are a customer.

/reopen

/remove-lifecycle rotten


Resources page

Would be a great addition to add. Thoughts welcome on where to place it!

Would these be resources for entrepreneurs/small business looking for help with different facets of their business?
I think it would be nice to have free resources available in different areas of business: branding, marketing, development, etc. So for example, I would love to help people with great ideas who are not sure where to start.


fix: memory leaks

cc @birros:
I think we should update the macOS & iOS side too.
Make sure check for MPV_FORMAT_NODE_MAP otherwise you may encounter crash.

I think we should update the macOS & iOS side too.

It's already done: https://github.com/media-kit/media-kit/blob/e5ab431183c81272e0a5545fb791273d751dbd8e/media_kit_video/common/darwin/Classes/plugin/MPVHelpers.swift#L13-L15
defer means that at the end of the method whatever is inside is called.

Make sure check for MPV_FORMAT_NODE_MAP otherwise you may encounter crash.

Here too: https://github.com/media-kit/media-kit/blob/e5ab431183c81272e0a5545fb791273d751dbd8e/media_kit_video/common/darwin/Classes/plugin/MPVHelpers.swift#L19-L21


NO_DUPLICATES causes deadlock as multiple tasks try to insert data into same global temp table

Because the temp table remains unique to a worker for a table, multiple tasks executing on the same worker will result in deadlock,

Hi  ankitbko
Try adding below option, it will solve your table lock issue.
option("tableLock", True)

@pramodnagare tablelock option is meant to be used with heap tables only. tablelock option is set to true automatically for staging tables.  https://github.com/microsoft/sql-spark-connector/blob/526f08dec3c6f12e375527d8c5c7531db4ea2864/src/main/scala/com/microsoft/sqlserver/jdbc/spark/connectors/ReliableSingleInstanceStrategy.scala#L85
cc: @shivsood

Hello, I am encountering the same issue. I need to use the following options
        .option("schemaCheckEnabled", False) \             .option("reliabilityLevel","NO_DUPLICATES") \

Any update on this ?

@ankitbko does this happen only on databricks? Can u send repro step and your scripts for us to repro this. @luxu1-ms as FYI

I also encounter this issue when running multiple instances of the same notebook on the same cluster (DBR 7.3 LTS) using Azure Databricks. My notebook attempts to load data from delta lake table source and to overwrite the data in an Azure SQL Database table using the following options:
try:   dfSource.write \     .format("com.microsoft.sqlserver.jdbc.spark") \     .mode("overwrite") \     .option("url", url) \     .option("dbtable", sinkTable) \     .option("user", userName) \     .option("password", password) \     .option("truncate", "true") \     .option("tablock", "true") \     .option("schemaCheckEnabled", "false") \     .option("batchsize", batchsize) \     .option("reliabilityLevel", "NO_DUPLICATES") \     .save() except ValueError as error :     print("Connector write failed", error)
The intent is to preserve the table definition (and indexes) in the sink database. I realise the tablock is only required for heaps, but this is a generic notebook that loads to both indexed and heap tables.
Importantly, I don't get an error when I run the notebook in isolation, so it appears that there is some shared global temp table that is causing deadlocks in parallel execution scenario.

I think this issue is related with #132

Certainly looks like it is caused by the name of the temp staging table not being granular enough. Adding the sink table name to the temp table should resolve this yes.

@ankitbko Could you please provide repro scripts? I am not able to repro this issue.

Close this issue since no more info provided and cannot repro it. Please reopen if more info provided.


[api-docs] Document Guild#nsfw_level

A new commit was made into the api-docs repo. This issue was created automatically. Need to review if we made any change to the library for this commit.
https://github.com/discord/discord-api-docs/commit/445832c88a7faa01166c320f87e1e08c6da7c661

Done


Support segment matching when disabling rules in file comments

For example, "api-linter: http-body=disabled" should match and disable"core::0131::http-body", core::0133::http-body, etc.

File-level or descriptor-level, please.

Done.


Javascript Capstone Project

In this PR, we have completed the following tasks...

Used the TVmaze API
Displayed the list of movies on the home page
Displayed comment popup with selected movie details
Displayed the number of likes for each item on the home page using the involvement API
Displayed comments for a given movie on the comments pop-up
Created two features for adding new likes and comment
Added counters for the number of movies and comments
Added tests for the counters
Recorded the 5 min video for the project description

Hi team
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request
⚠ Kindly make sure you ask for PR  from development to main. Please check this link to refresh your knowledge.

Open a pull request from the development branch to the main branch with all changes made by your team.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


No man page for pg_dump

Issue description
When I install the postgresql service, I don't have man pg_dump.
Steps to reproduce
In your config:
service.postgresql.enable = true
Rebuild.
Verify that the pg_dump executable does exist.  (It should.)
From the shell, man pg_dump reports no man page found.
Technical details

Nix version: 17.03

To get pg_dump and friends you can install the postgresql package; along with the service.postgresql you already have; service.postgresql uses postgresql.
As for the man page, there is a derivation for it ([hash]-postgresql-x.y.x-doc) but I don't know why man doesn't see it.
find /nix/store/x66g4f8v3vm1l5wd2gz6bj56w2h2vr3c-postgresql-9.6.2-doc/share/ -name pg_dump*
/nix/store/x66g4f8v3vm1l5wd2gz6bj56w2h2vr3c-postgresql-9.6.2-doc/share/man/man1/pg_dump.1.gz
/nix/store/x66g4f8v3vm1l5wd2gz6bj56w2h2vr3c-postgresql-9.6.2-doc/share/man/man1/pg_dumpall.1.gz

This is fixed now in 029125b973e4c44b20e288d43dfb9a46b18e3ef7. However I would like not to backport this at the moment, as it moves some files from one output to another, which might break other peoples setup. To get manpages in 17.03 or 17.09, just add postgresql.doc to systemPackages.


Cannot install the extension xxxx by zzz <IP_ADDRESS> because the tenant default already uses a different version of it.

Describe the issue
We try to run the ALValidation, but run into error "Cannot install the extension ... by ... <IP_ADDRESS> because the tenant default already uses a different version of it."
It is an "upgrade"-Test with a version 15- and version 18-App-File.
I think we detect the reason of the error: We have a "ö" in our company-name und in the app.json the publisher is "Comsol Unternehmenslösungen AG". An it looks, that the detection if "-install" or "-upgrade"-command is required come to the wrong result in the AIValidation-Script.
I changed the publisher in both apps to "Comsol Computerloesungen AG" (remove the "ö") and then it works. But i think this would be a breaking change for the Appsource-publishing, so we have to leave the "ö" in the publisher-property - or is it possible to do this change?
Scripts used to create container and cause the issue
Run-AlValidation     -licenseFile $env:DockerBcLicense
-previousApps @($Old_AppDocuTie, $Old_AppStripe)     -apps @($New_AppDocuTie, $New_AppSubscriptionManager)
-affixes $Affixes     -countries $Countries
-skipVerification
Full output of scripts
Previous Apps

C:\Users\jh\OneDrive - Comsol Unternehmenslösungen AG\Develop_Releases\Comsol Unternehmensloesungen AG_DocuTie_<IP_ADDRESS>.app
C:\Users\jh\OneDrive - Comsol Unternehmenslösungen AG\Develop_Releases\Comsol Unternehmenslösungen AG_Comsol Monetization_<IP_ADDRESS>.app
Apps
C:\Users\jh\OneDrive - Comsol Unternehmenslösungen AG\Develop_Releases\Comsol Unternehmensloesungen AG_DocuTie_<IP_ADDRESS>.app
C:\Users\jh\OneDrive - Comsol Unternehmenslösungen AG\Develop_Releases\Comsol Unternehmenslösungen AG_Comsol Subscription Manager_<IP_ADDRESS>.app

Screenshots
-> with "ö" in Companyname (publisher)

-> with "oe" in Companyname (publisher)

Hi guys,
just to underline Jochen's idea:
If I replace the german special chars, the upgrade - routine is running correctly instead of installing.
This way the AL-Validation runs correctly.

The "Replace-SpecialChars()" function:
(https://social.technet.microsoft.com/Forums/windowsserver/de-DE/8af91b31-7712-499c-a90b-a5cc8f95a8ff/umlaute-in-powershell-script-verwenden?forum=powershell_de)

function Replace-SpecialChars () {
    param ([string]$s)

    $SpecialChar = New-Object PSObject | Add-Member -MemberType NoteProperty -Name Name -Value $s -PassThru

    $characterMap = New-Object system.collections.hashtable
    $characterMap.ä = "ae"
    $characterMap.ö = "oe"
    $characterMap.ü = "ue"
    $characterMap.ß = "ss"
    $characterMap.Ä = "Ae"
    $characterMap.Ü = "Ue"
    $characterMap.Ö = "Oe"

    foreach ($property  in 'Name') {
        foreach ($key in $characterMap.Keys) {
            $SpecialChar.$property = $SpecialChar.$property -creplace $key, $characterMap[$key]
        }
    }

    $SpecialChar
}

Results in upgrading instead of new installation:

Probably this helps.

Thanks for this info.
The real problem here is not in this location though.
The real problem is that the PowerShell Get-Content function works poorly with UTF8 text files without BOM if you do not specify the encoding.
Extract-AppFileToFolder used Get-Content to read the NavXManifest (which doesn't have a BOM) and then it writes the file using Set-Content - which also doesn't write the BOM - leaving it to the reader to determine what's right and wrong.
I will add encoding to both, which should solve this issue.

Great, thank you!

this just shipped in the latest preview of BcContainerHelper - please let me know if this fix solves the issue

Hi Freddy,
now the update is triggered correctly using the updated Run-AlValidation() from the preview:

So this part seems to be fixed. But unfortunately, now i get an error that looks like an encoding problem as well:

Just to cross-check i've reinstalled version 2.0.12 and the error doesn't occur anymore (using my dirty fix from yesterday to avoid the underlaying problem).
So, probably a consequential error to your hotfix?

Could you email me a link to a .zip file with the apps you are running this with (Both previousapps and apps)?
You cannot email the .zip file.
freddyk at microsoft dot com

Just checked in another fix, which should fix this issue.
Another few cases of missing UTF8 conversion

I can confirm the Al-Validation is now running without any errors.
Thanks a lot!

Thanks for the assistance on troubleshooting:-)


tabComponent theme independence

Codecov Report

Merging #64 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master     #64      +/-   ##
=========================================
- Coverage    3.95%   3.94%   -0.02%
=========================================
  Files          78      78
  Lines         682     685       +3
  Branches      182     185       +3
=========================================
  Hits           27      27
- Misses        655     658       +3

Impacted Files
Coverage Δ

src/components/LayoutHeader/layoutHeader.tsx
0.00% <0.00%> (ø)

src/components/LayoutHeader/mobile/link.tsx
0.00% <0.00%> (ø)

src/components/LayoutRightDrawer/rightDrawer.tsx
0.00% <ø> (ø)

src/components/TabComponent/drawerItem.tsx
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d31e1c...3ca80c3. Read the comment docs.


my zed camera is not detected.

Hi,
I'm using ZED camera on windows10 and gtx1060.
Now my camera is not recognized by my PC.
So I tried another PC that has USB3.0, but it didn't recognize the ZED camera too.
I want to know if ZED camera is recognized by PC when it is inserted into USB3.0.
Please can anyone help me with this issue?

Hi,
This is not directly related to the python wrapper.
Try using the Diagnostic Tool and contact the support<EMAIL_ADDRESS>if the problem persists.


contributing guidelines and code of conduct

[msedgedevrel]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9046489c-0435-15c2-114f-1bd99ac3a58e
Version Independent ID: a6f1022e-0029-75d4-6c9b-b1f2c145d791
Content: Port a Chrome extension to Microsoft Edge - Microsoft Edge Development
Content Source: microsoft-edge/extensions-chromium/developer-guide/port-chrome-extension.md
Product: microsoft-edge
Technology: extensions
GitHub Login: @MSEdgeTeam
Microsoft Alias: msedgedevrel

Closing as incomplete. Please feel free to add more information if you have any and we can re-open the issue.


LogReader: use parallel sorting on PC

Unless @gregjhogan think this will give us significant speedups in the pipeline, I don't think this is worth it. We should be going for optimizations that'll work on both PC and the devices. I'm hoping that replay will also work on C2.


feat: render descriptions in Go comments via preset

Description

This PR adds a new GO_DESCRIPTION_PRESET similar to the JAVA_DESCRIPTION_PRESET with the ability to render descriptions from specs as comments on types (structs and enums) and struct fields.
The PR also removes the default preset's comments on structs and enums as these were conflicting and didn't seem to add much value.
I also fixed a file name, which seemed had a typo.

Related issue(s)

#648

Thanks for the review. I'll get to it tomorrow, I hope.

We are gonna re-create the next branch for version 2 changes, which will close your PR, feel free to re-create or retarget your PR for master as it contains the version 1 changes 🙂 Or if your change contains a breaking change, target it for the version 2 in next.


Develop 2.2.0 Docker Image

In prep for 2.2.0 create a docker file in https://github.com/Netflix-Skunkworks/zerotodocker for release.

Development complete. Will issue pull request to ZeroToDocker project after 2.2.0 release.


monetary goals

basically a list of things with a price tag
Soho club membership – $2000
Motorcycle – $5000
Ten thousand in savings – $10000
Goal can be accepted or deleted.
Accepted goals are hidden by default.

irrelevant


Continue after a batch job does not work

Queueing up 2 jobs (see below) executes the first job OK but the second one does not execute at all.
var jobTag = BatchJob.StartNew(x =>
{
foreach (var lcOverrideWithTemplate in overrides)
{
x.Enqueue(t => t.CalculateLoadcase(designId, dutyCycleId, lcOverrideWithTemplate.templateLoadCaseId, lcOverrideWithTemplate.loadCaseOverride, progressID));
}
});
jobTag = BatchJob.ContinueWith(jobTag, inbatch =>
{
foreach (var bearingId in bearingIds)
{
inbatch.Enqueue(t => t.CalculateOneBearingsLifeTest(designId, histogramTestId.GetValueOrDefault(), bearingId, progressID));
}
});

Hi @Hugh-walsh,
Thank you for submitting this. Unfortunately we don't have access to Hangfire.Pro features, this is uncharted territory.
We will contact @odinserj to try to get support on this.

Hi @gottscj, there may be problems even with regular background jobs as well. I've noticed that the MongoWriteOnlyTransaction.Commit method isn't atomic, and there may be problems with consistency. Nobody should see/modify the data referenced by a transaction, when it's running, and it should be either fully performed, or fully rolled back. I'm not sure how to achieve this with MongoDB, and don't know whether this can be achieved there at all, but perhaps the isolation operator at least can help with isolation.
This can lead to consistency issues:

Thread A creates a background job for a batch with a single job, and enqueues it.
Thread B fetches the background job and executes it.
Thread A creates batch data structures, but too late – Thread B already processed the only job.

Hi @odinserj,
Thank you for the feedback. We will look into honor the need for atomic commits. Its definitely possible to fix. either with distributed lock or two phase commits.

closing


Application Error

application is not working, please check the url.

this isn't related to codebase,
heroku don't offers free deployment now,
so all previously free deployed links stops working and shows this err


Fix targetPath pattern

What this PR does / why we need it:
Which issue this PR fixes

fixes #129

Given that the chart doesn't have the upstream CRDs released months ago, I think many other changes are left out... We need to have some test so this never happens again, who knows how many changes are omitted from the chart.

@stefanprodan Looks Like the CRDs updated Last with: https://github.com/fluxcd-community/helm-charts/commit/49e4ae4d166cedd4e963d8168fd570b76d6a8eb5

@haarchri is there a bug in the script that updates the CRDs then?

Yeah i will check at the moment what happend

i found the bug and will open a PR shortly

@as42sl  thanks for bring up the issue
please check: https://github.com/fluxcd-community/helm-charts/pull/132
if fixed the generator


version compare error

Semver semver1 = Semver.parse("1.0.16-lp-zc1-bate+fix-zc1");
Semver semver2 = Semver.parse("1.0.16-lp-zc1");

//java.lang.NumberFormatException: For input string: "1-bate"
System.out.println(semver1.isGreaterThanOrEqualTo(semver2));;

//java.lang.NumberFormatException: For input string: "1-bate"
System.out.println(semver1.compareTo(semver2));

@piotrooo the issue here is that the regex in Comparator.compareIdentifiers() only checks for the presence of one or more digits in the prerelease and doesn't check for whether there are non-digits after said digits:
        if (isBothContainsDigits(a, b)) {
            String digitsExtract = "(?<=\\D)(?=\\d)"; // <= This is producing "1-bate" based on the version string shown above
            String[] tokenArr1 = a.split(digitsExtract);
            String[] tokenArr2 = b.split(digitsExtract);
            if (tokenArr1[0].equals(tokenArr2[0])) {
                long digitA = Long.parseLong(tokenArr1[1]);
                long digitB = Long.parseLong(tokenArr2[1]);
                return compareIdentifiers(digitA, digitB);
            }
        }

What would be the best way to resolve this? Wrapping the lines to parse and compare digitA and digitB in a try/catch for a NumberFormatException works, but maybe the regexes in this code block need to be refined instead?

Many thanks @severn-everett

I've approved the pull request.
For future fixes, we can open a separate issue


Remove version: Rainmeter.Rainmeter version 4.5.14

This version is older than what has been set in max-versions-to-keep by the publisher.
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/rainmeter/rainmeter/releases/download/v<IP_ADDRESS>63/Rainmeter-4.5.14.exe
OK
(Automated message - build 917)


Add capthca

To reduce account spamming, some sort of captcha should be added to the registration form.

was fixed in d0fee2311575fdb96ae84a01350a6968e3d0e22a


⚠ Bofrost.de has degraded performance

In b216019, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1359 ms

Resolved: Bofrost.de performance has improved in 00eb2fc after 26 minutes.


Blazor circuits, security, and hosting guidance

Fixes #13294
Fixes #13360

Turns out that we had already started the process of covering "scalability" of Blazor Server apps via the new security topic. I think it was Ryan who said that these quasi-performance aspects were considered by engineering to be security matters. I can confirm the source and get the cross-link to that remark if needed. Therefore, the guidance here seemed to fit better into that existing security topic than elsewhere ... sans the specific bit on the JS interop timeout config, which really should go into the JS interop topic and get cross-linked (which is what I do here).
For consideration tho if the new security topic isn't the right spot: The Components topic is a BOOK at this point. Consider a best practices or performance-type of topic to keep Components from becoming War and Peace! :smile:
There are ~3 inline markdown comments that I left asking questions ... you'll see them on review.

Here's the comment from Ryan that I was referring to ...
<!-- Should the preceding add something to the effect that CPU exhaustion can reach a
point that it may even crash the server (or 'for all practical purposes crash the server
because the server slows to a crawl')? -->

I think the typical blurb is that we consider excessive resource consumption to be a security concern impacting availability. Where your server has crashed or not, if it's not responsive, that's the same outcome as a crash.

https://github.com/aspnet/AspNetCore.Docs/pull/14098#discussion_r320528718

@danroth27 @pranavkm Updates made. 🏍


Docs: add API reference based on docstrings

I saw this internal doc pop up, and went ... hey, isn't that what good API docs are for? And given this is on Github, pretty sure we can automate it, and then it'll be kept up to date, included in the release page and if docstring-based will also be accessible in IDEs.
So this PR:

[x]  uses sphinx-apidoc to generate the API docs
[x] integrates them into the existing docs
[x] tweaks some of the docstrings to demo the potential (using Google style)

And in order to make it actually useful, either as part of this or as a followup, should:

[ ] tidy up the way the docs actually present (on the .rst side)
[ ] fix, then add a stack more docstrings, at least enough to cover the basics and provide an example
[ ] use a workflow to autogen the docs on a PR to main
[ ] include docs in release package
[ ] nab the allocated fixate github.io subdomain and push it there

Sample

References

sphinx-autodoc
sphinx-apidoc
idiot's guide (ie me)

@josh-marshall-amp I deliberately overrode pre-commit for my commits, since there is a stack of stuff to fix overall and I wanted to get the concept up for feedback first... no point spending that time in case it was going counter to other folks' views on the direction for fixate. So I've marked them resolved without fixing first... but would do so before merge.

@jcollins1983 I also like to keep 'content' vs 'process' PRs separate... so my intention with the changes to the docstrings themselves were just as an example, and I can imagine those could be updated by those who know Fixate or are using it more than I. We should discuss whether Google- or numpy-style docstrings are a preference, as they seem to be online (much more readable and "pythonic")

Added the docs build to tox.ini. (I'm still running it with a manual sphinx-build invocation so I get the right filenames to fix, but the automation works)
added the special-casing so it doesn't spew errors on unimportable packages (PyQt, PyDAQ) and pulled the ftdi low-lever driver into its own _ftdi.py so that can be mocked as well
a few more simple fixups to docstrings

There's still quite a number of warnings on docstrings, so these will need to be cleaned up at some stage.
Still need the discussion on docstring style... but it does look like a mix of rst :param name: and the google style is acceptable to Sphinx, can migrate slowly.
Haven't added the docs built to the github workflow, but that's probably worthwhile even if we're not using them just yet. I don't want to fail builds on doc warnings yet though.

I've enabled PR preview builds on read the docs. Hopefully that works on the next push, but there might be other config needed. I'm not 100% sure.
https://docs.readthedocs.io/en/stable/pull-requests.html

I've pinned the docs build to 3.12 as requested. Confess I don't really quite get basepython vs the evnlist matrix... and how all that interacts with the build given we're still using the 3.8 build?

Still need the discussion on docstring style... but it does look like a mix of rst :param name: and the google style is acceptable to Sphinx, can migrate slowly.

I don't really have a strong preference, but I think I lean towards Google style, it looks a bit easier to read IMO.

I added a docs readme. Besides that, anything else for this PR?
I suggest we merge this, and then the next discussion can be about the structure and style of the docs themselves.
There was the discussion re: style for the examples but that can wait too.

I added a docs readme. Besides that, anything else for this PR?
I suggest we merge this, and then the next discussion can be about the structure and style of the docs themselves.
There was the discussion re: style for the examples but that can wait too.

Yes to all of that from me.
The only unresolved comments are from @jcollins1983 about if we should keep or remove TEST_SEQUENCE. I think that is a discussion for elsewhere.

I added a docs readme. Besides that, anything else for this PR?
I suggest we merge this, and then the next discussion can be about the structure and style of the docs themselves.
There was the discussion re: style for the examples but that can wait too.

Yes to all of that from me.
The only unresolved comments are from @jcollins1983 about if we should keep or remove TEST_SEQUENCE. I think that is a discussion for elsewhere.

Agree that the conversation RE TEST_SEQUENCE can happen elsewhere/later.


Promise logo

It would be awesome to have the A+ Promise Spec logo
https://github.com/promises-aplus/promises-spec/blob/master/logo.svg

Hey!
Added 7dc1b8b6910a254efec43994f348d06ffc3d683b


Rename and version number fix ETT ckan files

Fix version sorting

As https://github.com/KSP-CKAN/CKAN-meta/pull/860 changing filenames will have no effect.

Ah ok then. Merging with my thanks

I understand @Olympic1's point of view you're making the version formatting even more inconsistent. Instead of changing "version": "1.0_20150731", to "version": "1.0.20150731", why not change ETT-1.0.20150622 to ETT-1.0_20150622. This will maintain the author's consistent standard of ksp_version_date

oops, merged the moment you commented this

Yeah, funny timing. Will make a new PR shortly.

This is exactly how it was - which didn't sort correctly. _ sorts after ., so 1.0_20 comes after 1.0.2_20.


Request file

Hello, Mr. Zou, thank you very much for the running code you provided on Github. I have a question here and I want to ask you. The  test.py reports "No such file or directory: 'data/adjacent.csv" during running. May I ask Is the file not uploaded?
Thanks above.

Yes.Because my  paper is being reviewed for review. As long as the paper is accepted at the first time, I will open up the data, thank you!
------------------ Original ------------------
From: Anita @.>
Date: Sun,Nov 21,2021 9:42 AM
To: zouguojian/traffic-demand-prediction @.>
Cc: Subscribed @.***>
Subject: Re: [zouguojian/traffic-demand-prediction] Request file (Issue #1)
Hello, Mr. Zou, thank you very much for the running code you provided on Github. I have a question here and I want to ask you. The  test.py reports "No such file or directory: 'data/adjacent.csv" during running. May I ask Is the file not uploaded?
Thanks above.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Yes.Because my  paper is being reviewed for review. As long as the paper is accepted at the first time, I will open up the data, thank you!
…
------------------ Original ------------------ From: Anita @.> Date: Sun,Nov 21,2021 9:42 AM To: zouguojian/traffic-demand-prediction @.> Cc: Subscribed @.***> Subject: Re: [zouguojian/traffic-demand-prediction] Request file (Issue #1) Hello, Mr. Zou, thank you very much for the running code you provided on Github. I have a question here and I want to ask you. The test.py reports "No such file or directory: 'data/adjacent.csv" during running. May I ask Is the file not uploaded? Thanks above. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

Thank again. here is a little request. Is it convenient to provide versions of Python, Tensorflow and Keras in which you run your code?

I can tell you. But the premise is, I want to ask, what is your intention to use my thesis code. Because I am worried about the idea of the thesis leaking. Thank you for your understanding.


Permissions required?

This is another page which does not provide information about the permissions or roles required to perform these actions. We are not always global admin….
Please add what is required on the subscription, workspace etc to perform these actions

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 069802b7-9db6-f5d6-b1aa-52ebc42e96f8
Version Independent ID: 7b011f8a-0a1c-5066-5d20-3cedcdfc7403
Content: Auto-deploy agents for Microsoft Defender for Cloud
Content Source: articles/defender-for-cloud/enable-data-collection.md
Service: defender-for-cloud
GitHub Login: @memildin
Microsoft Alias: memildin

@andrePKI,  Thanks for taking time to share your valuable feedback. Your feedback has been shared with the content owner for further review.

Hi,
I found the following:

One should be owner of the subscription (i.e. Contributor is not enough)
because the enabling of the extensions auto provisioning is implemented via
Azure Policy and one must be able to create the policies on the subscription
Also, for Arc (but that is not specific to auto provisioning) the
Resource provider Microsoft.HybridCompute must be registered

Maybe the doc can be updated to specifically mention Owner of the
subscription is required.,
Thank you
Op wo 8 dec. 2021 om 05:55 schreef AjayKumar-MSFT @.***

:

@andrePKI https://github.com/andrePKI, Thanks for taking time to share
your valuable feedback. Your feedback has been shared with the content
owner for further review.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/84944#issuecomment-988498471,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFTL2FXDMJGFCJDJSYRNUJ3UP3QNPANCNFSM5JSH2CSQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Met vriendelijke groet,
André Hoekstra

Hi @andrePKI, at the top of the page there is an availability section. There, you'll see the note about the need to be Owner.
Thanks for the feedback and for taking the time to help us improve the docs.
I'm going to close this issue, but feel free to comment again here or open a new one if you have additional requests.
#please-close


Benchmarking

This issue is served as a place for discussing various ways / ideas we can benchmark runwasi the wasm shims that was proposed by @ipuustin

One idea is that we can write a simple wasm program (Fibonacci) and execute in runwasi and a native program executing in runc. This provides a base benchmark of comparising the performance of wasi program vs. native runc processes. It is not meant to benchmark the performance of WASI in general.
Having the base benchmark set, we can observe the performance difference for each version increments. For example, we can observe how much speed increase / descrease for version 0.2 vs. 0.3
Another idea of benchmarking is testing how "dense" of wasm pods can we go for a node. It is often advertised that wasm modules can increase CPU utilization and thus increasing the density of running pods per node. We can verify this point to push the containerd runtime to the extreme by running thousands of pods at the same time.

Feel free to add ideas and thoughts on this topic! Any suggestion is welcome 🙏

Close this one as #126 adds benchmarking support.

Wanted to reopen this issue because I think #126 does not fully address the scope of the issue mentioned above. A few things that will make runwasi benchmarking stories better

add #126 to the CI
run runc and crun in the CI to give comparison results
dense test

Check out SpinKube perf test: https://github.com/fermyon/spinkube-performance


dependencies updates

apache auxilury libs updates:
commons-codec - hash algorithms
commons-lang3
commons-io
commons-compress
commons-csv
org.apache.httpcomponents:httpclient
org.apache.httpcomponents:httpcore

Test and Verified
(*Pretty not working known issue)
Close & Moving to Done


Hi, I want to make sure whether there are any differences between engine generation by your python code and by trtexec?

And I also want to know how to quantize it in int8 model rather than fp32 by trtexec, if this is familiar to you.

I have python3.6 and pytorch1.3.1 and tensorrt 7.0.0. Are these the possible reason for this error?

I fixed this issue, but I still have problems on my own onnx model...

Hello,
That means you can produce a TensorRt engine and test some metrics (e.g. inference speed) with random data.
According to the picture below, there is no difference.

For my side, I use trtexec mainly for debugging.


test: Add slack integration to master job

From now on, if a job on master fails, it will be reported in our #team-monitoring slack channel.

lgtm


Fix: Add 5.10 series kernels to amazonlinux2 builder

Signed-off-by: David Windsor<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area cmd

/area pkg

/area docs

/area tests

What this PR does / why we need it:
Currently, the AmazonLinux2 builder won't build configs for the latest kernels:

Expected behavior:

Which issue(s) this PR fixes:

Fixes #137
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dwindsor
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hitting this issue too. Using this branch it fails to build the eBPF probe still but does build successfully build the kernel module.
If you run it for probe you get:
❯ ./_output/bin/driverkit docker --output-probe /tmp/probe.o --kernelversion=1 --kernelrelease="5.10.109-104.500.amzn2.x86_64" --driverversion=3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4 --target=amazonlinux2 -l debug
DEBU running without a configuration file
DEBU running with options                          driverversion=3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4 kernelrelease=5.10.109-104.500.amzn2.x86_64 kernelversion=1 output-probe=/tmp/probe.o target=amazonlinux2
INFO driver building, it will take a few seconds   processor=docker
DEBU doing a new docker build
DEBU looking for repo...                           url="http://amazonlinux.us-east-1.amazonaws.com/2/core/2.0/x86_64/mirror.list" version=core/2.0
DEBU downloading...                                url="http://amazonlinux.us-east-1.amazonaws.com/2/core/2.0/x86_64/cb59f2813ac390d40ecac3b1ba25c701b900c6cc8e1d71b705c0b88c234672dd/repodata/primary.sqlite.gz"
DEBU connecting to database...                     db=/var/folders/2r/n9f8qcwj7ds6k5h3fkxcmtj00000gp/T/amazonlinux2-935739517.sqlite
DEBU looking for repo...                           url="http://amazonlinux.us-east-1.amazonaws.com/2/core/latest/x86_64/mirror.list" version=core/latest
DEBU looking for repo...                           url="http://amazonlinux.us-east-1.amazonaws.com/2/extras/kernel-5.4/latest/x86_64/mirror.list" version=extras/kernel-5.4/latest
DEBU downloading...                                url="http://amazonlinux.us-east-1.amazonaws.com/2/extras/kernel-5.4/stable/x86_64/5859ce74bec5ec2d7c97966e5e179f31474f1b92ce2e84dca0e6c253db912ded/repodata/primary.sqlite.gz"
DEBU connecting to database...                     db=/var/folders/2r/n9f8qcwj7ds6k5h3fkxcmtj00000gp/T/amazonlinux2-742013368.sqlite
DEBU looking for repo...                           url="http://amazonlinux.us-east-1.amazonaws.com/2/extras/kernel-5.10/latest/x86_64/mirror.list" version=extras/kernel-5.10/latest
DEBU downloading...                                url="http://amazonlinux.us-east-1.amazonaws.com/2/extras/kernel-5.10/stable/x86_64/0510ac29f090c4abb8f1e512caf638f428653cdefd83bee7b60f141b7691af92/repodata/primary.sqlite.gz"
DEBU connecting to database...                     db=/var/folders/2r/n9f8qcwj7ds6k5h3fkxcmtj00000gp/T/amazonlinux2-738964919.sqlite
DEBU kernel header url found                       url="http://amazonlinux.us-east-1.amazonaws.com/blobstore/ca19e72b4e6b43af5c589209d1c44211800e1fd556633a0359f8e50c6b9dfacc/kernel-devel-5.10.109-104.500.amzn2.x86_64.rpm"
DEBU kernel header url found                       url="http://amazonlinux.us-east-1.amazonaws.com/blobstore/9b5902730105383e33cb83e5271b8fcaefc7af1538cac04566b34d2215bba402/kernel-5.10.109-104.500.amzn2.x86_64.rpm"
DEBU + rm -Rf /tmp/driver
DEBU + mkdir /tmp/driver
DEBU + rm -Rf /tmp/module-download
DEBU  + mkdir -p /tmp/module-download
DEBU r+ curl --silent -SL https://github.com/falcosecurity/libs/archive/3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4.tar.gz
DEBU %+ tar -xzf - -C /tmp/module-download
DEBU    + mv /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/CMakeLists.txt /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/GPL2.txt /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/MIT.txt /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/Makefile.in /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/bpf /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/dkms.conf.in /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/driver_config.h.in /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/dynamic_params_table.c /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/event_table.c /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/fillers_table.c /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/flags_table.c /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/kernel_hacks.h /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/main.c /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/ppm.h /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/ppm_compat_unistd_32.h /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/ppm_cputime.c /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/ppm_events.c /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/ppm_events.h /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/ppm_events_public.h /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/ppm_fillers.c /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/ppm_fillers.h /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/ppm_flag_helpers.h /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/ppm_ringbuffer.h /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/ppm_syscall.h /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/ppm_version.h /tmp/module-download/libs-3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4/driver/syscall_table.c /tmp/driver
DEBU 5+ cp /driverkit/module-Makefile /tmp/driver/Makefile
DEBU 4+ bash /driverkit/fill-driver-config.sh /tmp/driver
DEBU V+ DRIVER_BUILD_DIR=/tmp/driver
DEBU + DRIVER_CONFIG_FILE=/tmp/driver/driver_config.h
DEBU + cat
DEBU N+ API_VERSION_FILE=/tmp/driver/API_VERSION
DEBU + [[ -f /tmp/driver/API_VERSION ]]
DEBU 1+ SCHEMA_VERSION_FILE=/tmp/driver/SCHEMA_VERSION
DEBU &+ [[ -f /tmp/driver/SCHEMA_VERSION ]]
DEBU 1+ SCHEMA_VERSION_FILE=/tmp/driver/SCHEMA_VERSION
DEBU &+ [[ -f /tmp/driver/SCHEMA_VERSION ]]
DEBU + mkdir /tmp/kernel-download
DEBU + cd /tmp/kernel-download
DEBU + curl --silent -o kernel.rpm -SL http://amazonlinux.us-east-1.amazonaws.com/blobstore/ca19e72b4e6b43af5c589209d1c44211800e1fd556633a0359f8e50c6b9dfacc/kernel-devel-5.10.109-104.500.amzn2.x86_64.rpm
DEBU :+ rpm2cpio kernel.rpm
DEBU + cpio --extract --make-directories
DEBU 164871 blocks
DEBU + rm -rf kernel.rpm
DEBU + curl --silent -o kernel.rpm -SL http://amazonlinux.us-east-1.amazonaws.com/blobstore/9b5902730105383e33cb83e5271b8fcaefc7af1538cac04566b34d2215bba402/kernel-5.10.109-104.500.amzn2.x86_64.rpm
DEBU :+ rpm2cpio kernel.rpm
DEBU + cpio --extract --make-directories
DEBU 215887 blocks
DEBU + rm -rf kernel.rpm
DEBU + rm -Rf /tmp/kernel
DEBU + mkdir -p /tmp/kernel
DEBU w+ mv usr/src/kernels/5.10.109-104.500.amzn2.x86_64/Kconfig usr/src/kernels/5.10.109-104.500.amzn2.x86_64/Makefile usr/src/kernels/5.10.109-104.500.amzn2.x86_64/Makefile.kernel usr/src/kernels/5.10.109-104.500.amzn2.x86_64/Module.symvers usr/src/kernels/5.10.109-104.500.amzn2.x86_64/System.map usr/src/kernels/5.10.109-104.500.amzn2.x86_64/arch usr/src/kernels/5.10.109-104.500.amzn2.x86_64/block usr/src/kernels/5.10.109-104.500.amzn2.x86_64/certs usr/src/kernels/5.10.109-104.500.amzn2.x86_64/crypto usr/src/kernels/5.10.109-104.500.amzn2.x86_64/drivers usr/src/kernels/5.10.109-104.500.amzn2.x86_64/fs usr/src/kernels/5.10.109-104.500.amzn2.x86_64/include usr/src/kernels/5.10.109-104.500.amzn2.x86_64/init usr/src/kernels/5.10.109-104.500.amzn2.x86_64/ipc usr/src/kernels/5.10.109-104.500.amzn2.x86_64/kernel usr/src/kernels/5.10.109-104.500.amzn2.x86_64/lib usr/src/kernels/5.10.109-104.500.amzn2.x86_64/mm usr/src/kernels/5.10.109-104.500.amzn2.x86_64/net usr/src/kernels/5.10.109-104.500.amzn2.x86_64/samples usr/src/kernels/5.10.109-104.500.amzn2.x86_64/scripts usr/src/kernels/5.10.109-104.500.amzn2.x86_64/security usr/src/kernels/5.10.109-104.500.amzn2.x86_64/sound usr/src/kernels/5.10.109-104.500.amzn2.x86_64/tools usr/src/kernels/5.10.109-104.500.amzn2.x86_64/usr usr/src/kernels/5.10.109-104.500.amzn2.x86_64/virt usr/src/kernels/5.10.109-104.500.amzn2.x86_64/vmlinux.id /tmp/kernel
DEBU &+ ln -sf /usr/bin/gcc /usr/bin/gcc-10
DEBU l+ cd /tmp/driver/bpf
DEBU + make LLC=/usr/bin/llc-7 CLANG=/usr/bin/clang-7 CC=/usr/bin/gcc KERNELDIR=/tmp/kernel
DEBU ake -C /tmp/kernel M=$PWD
DEBU make[1]: Entering directory '/tmp/kernel'
DEBU make -f Makefile.kernel CROSS_COMPILE="gcc10-" CC="/usr/bin/gcc" HOSTCC="gcc10-gcc" HOSTCXX="gcc10-g++" LD="gcc10-ld.bfd" modules
DEBU *make[2]: Entering directory '/tmp/kernel'
DEBU Nscripts/Makefile.lib:8: 'always' is deprecated. Please use 'always-y' instead
DEBU /usr/bin/clang-7 -I./arch/x86/include -I./arch/x86/include/generated  -I./include -I./arch/x86/include/uapi -I./arch/x86/include/generated/uapi -I./include/uapi -I./include/generated/uapi -include ./include/linux/kconfig.h \
DEBU    -D__KERNEL__ -fmacro-prefix-map=./=  \
DEBU     \
DEBU     \
DEBU    -D__KERNEL__ \
DEBU    -D__BPF_TRACING__ \
DEBU    -Wno-gnu-variable-sized-type-not-at-end \
DEBU    -Wno-address-of-packed-member \
DEBU    -fno-jump-tables \
DEBU    -fno-stack-protector \
DEBU    -Wno-tautological-compare \
DEBU    -O2 -g -emit-llvm -c /tmp/driver/bpf/probe.c -o /tmp/driver/bpf/probe.ll
DEBU 9clang: error: unknown argument: '-fmacro-prefix-map=./='
DEBU Lmake[3]: *** [/tmp/driver/bpf/Makefile:35: /tmp/driver/bpf/probe.o] Error 1
DEBU =make[2]: *** [Makefile.kernel:1822: /tmp/driver/bpf] Error 2
DEBU )make[2]: Leaving directory '/tmp/kernel'
DEBU )make[1]: Leaving directory '/tmp/kernel'
DEBU +make[1]: *** [Makefile:9: modules] Error 2
DEBU %make: *** [Makefile:20: all] Error 2
DEBU log pipe close                                error=EOF
DEBU context canceled
FATA exiting                                       error="Error: No such container:path: 5d48462fbfb7c83b2a85998dff191faa9bf6b8c8d5df25a6c93186a956d610cd:/tmp/driver/bpf/probe.o"

Seems we have an error with using clang-7 for this. We may need to do a similar thing to https://github.com/falcosecurity/driverkit/pull/111 to enable the probe to build

tested this myself and it seemed to only fix kernel module and not the probe. I based off your PR and pushed this change to my branch and opened a PR https://github.com/falcosecurity/driverkit/pull/139 we should probably consolidate on one. If you want to merge in this change to yours I'm happy to close mine in favor of yours or vice-a-versa (don't want to take credit for your work but also wasn't sure best way to add additional fix)

Closing, as this is being addressed in #139 .


Some files remain in released state after "connection reset by peer" error

When restoring a dataset (1493347MB/269 blobs) by calling lfs hsm_restore <file> for all files, the operation often fails for a subset of them. It doesn't happen every time, but when it does the files that remain in released state (i.e. failed to be restored) have this corresponding error message in the logs:
 2020/12/04 19:47:37 lhsm-plugin-az2-stderr ALERT 2020/12/04 19:47:37 /usr/src/lemur_wastore/dmplugin/dmclient.go:183: fail: id:4 az.Download() of <filename> failed: read tcp <IP_ADDRESS>:55664-><IP_ADDRESS>:443: read: connection reset by peer
Would it be possible to add retries etc to make it more robust against handling failures from blob storage?
I'm able to reproduce it with different datasets, as long as there are a few files with with a size of several GB.

The config used:
num_threads=128 az_storage_account="<storage_account>" az_storage_key="<storage_key>" region="eastus2" bandwidth=0 exportprefix="" archive "archive1" {     id=1     num_threads=128     root=""     compression="off"     container="<container_name>"     region="eastus2" }

The config used:
az_storage_account="<storage_account>"
az_storage_key="<storage_key>"
region="eastus2"
bandwidth=0
exportprefix=""
archive "archive1" {
    id=1
    num_threads=128
    root=""
    compression="off"
    container="<container_name>"
    region="eastus2"
}

@nakulkar-msft I vaguely remember a similar issue from AzCopy, where certain network errors weren't retried, and we solved it by writing a dedicated retry policy inside AzCopy. Perhaps this is another manifestation of the same problem.

Closing this issue, fixed in c8bc6ac6dd06d68deecfa7667b6eb0f842348d44


Added filter to text content.

This merge request filter tags without user text.

Sorry, but this is outside the scope of this project, in my opinion.
Also note that your git/GitHub appear to be misconfigured.


Fixing the broken vs-code badge

Signed-off-by: Kamal Nayan<EMAIL_ADDRESS>Solves #2169

@jagpreetsinghsasan I don't think that would be possible unless I force push my branch , but it won't have any effect on the PR. So is it really needed ?

You can simply rebase and then reset on the the latest main branch commit. Then you can create a new commit out of this. And yes, its important to have a single commit with a proper commit message, to navigate through history of commits easily and proper management of code.
Please refer to our contributing guide for more information. You can also refer to various commits to have an idea of how the commit messages can be created, for example this one.

allright thanks for confirming in @jagpreetsinghsasan ✔

Closing due to inactivity. Happy to re-open later if it's still relevant.


Calling JS callback asynchronously from C++ thread.

Description
I am encountering an issue where my React Native app crashes when a JavaScript callback is called from C++ code running on a C++ thread asynchronously. However, when I call the same callback on the same thread from where the foo function is called, it works as expected without crashing.
Steps to reproduce
Nil
React Native Version
0.74.1
Affected Platforms
Runtime - Android, Build - Windows
Areas
TurboModule - The New Native Module System, JSI - Javascript Interface, Bridgeless - The New Initialization Flow
Output of npx react-native info
System:
  OS: Windows 10 10.0.19045
  CPU: (4) x64 Intel(R) Core(TM) i5-6500T CPU @ 2.50GHz
  Memory: 6.54 GB / 15.88 GB
Binaries:
  Node:
    version: 20.13.0
    path: E:\Program Files\nodejs\node.EXE
  Yarn:
    version: 3.6.1
    path: ~\AppData\Roaming\npm\yarn.CMD
  npm:
    version: 10.7.0
    path: E:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK:
    API Levels:
      - "29"
      - "30"
      - "31"
      - "34"
    Build Tools:
      - 30.0.2
      - 30.0.3
      - 33.0.1
      - 34.0.0
    System Images:
      - android-30 | Intel x86_64 Atom
      - android-30 | Google Play Intel x86 Atom
      - android-30 | Google APIs ATD Intel x86_64 Atom
      - android-34 | Google APIs Intel x86_64 Atom
    Android NDK: Not Found
  Windows SDK: Not Found
IDEs:
  Android Studio: Not Found
  Visual Studio: Not Found
Languages:
  Java: 17.0.11
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.1
    wanted: 0.74.1
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: false
  newArchEnabled: true
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Stacktrace or Logs
06-06 09:22:40.260 21837 21859 W libEGL  : EGLNativeWindowType 0xb40000786029bbc0 disconnect failed                     06-06 09:22:40.313 21837 22216 I MyApp   : Log message to Android                                                       06-06 09:22:40.367 21837 22216 I ReactNativeJS: 'error:', undefined, 'result:', 'hello world'                           06-06 09:22:40.369 21837 22216 E libc++abi: terminating due to uncaught exception of type facebook::jsi::JSError: Can't find variable: setHello                                                                                06-06 09:22:40.369 21837 22216 E libc++abi:                                                                             06-06 09:22:40.369 21837 22216 E libc++abi: callback                                                                    06-06 09:22:40.369 21837 22216 E libc++abi: onFastRefresh@http://localhost:8081/index.bundle?platform=android&dev=true&lazy=true&minify=false&app=com.bikegadgetmainappexample&modulesOnly=false&runModule=true:44263:35                        06-06 09:22:40.369 21837 22216 E libc++abi: performReactRefresh@http://localhost:8081/index.bundle?platform=android&dev=true&lazy=true&minify=false&app=com.bikegadgetmainappexample&modulesOnly=false&runModule=true:62080:34                  06-06 09:22:40.369 21837 22216 E libc++abi: http://localhost:8081/index.bundle?platform=android&dev=true&lazy=true&minify=false&app=com.bikegadgetmainappexample&modulesOnly=false&runModule=true:435:40                                        --------- beginning of crash                                                                                06-06 09:22:40.370 21837 22216 F libc    : Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 22216 (mqt_v_js), pid 21837 (tmainappexample)                                                                                06-06 09:22:40.472 22219 22219 I crash_dump64: obtaining output fd from tombstoned, type: kDebuggerdTombstone           06-06 09:22:40.473   249   249 I tombstoned: received crash request for pid 22216                                       06-06 09:22:40.481 22219 22219 I crash_dump64: performing dump of process 21837 (target tid = 22216)                    06-06 09:22:40.497 22219 22219 F DEBUG   : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***              06-06 09:22:40.498 22219 22219 F DEBUG   : Build fingerprint: 'Firefly/rk356x/rk356x:11/RD2A.211001.002/lwy07101153:userdebug/release-keys'                                                                                06-06 09:22:40.498 22219 22219 F DEBUG   : Revision: '0'                                                                06-06 09:22:40.498 22219 22219 F DEBUG   : ABI: 'arm64'                                                                 06-06 09:22:40.499 22219 22219 F DEBUG   : Timestamp: 2024-06-06 09:22:40+0000                                          06-06 09:22:40.499 22219 22219 F DEBUG   : pid: 21837, tid: 22216, name: mqt_v_js  >>> com.bikegadgetmainappexample <<< 06-06 09:22:40.499 22219 22219 F DEBUG   : uid: 10120                                                                   06-06 09:22:40.499 22219 22219 F DEBUG   : signal 6 (SIGABRT), code -1 (SI_QUEUE), fault addr --------                  06-06 09:22:40.499 22219 22219 F DEBUG   : Abort message: 'terminating due to uncaught exception of type facebook::jsi::JSError: Can't find variable: setHello

Reproducer
JSI-App
Screenshots and Videos
App.tsx
import * as React from 'react';
import { StyleSheet, View, Text } from 'react-native';
import { multiply, install} from 'react-native-bikegadget-mainapp';

const callback = (error, result) => {
  console.log('error:', error, 'result:', result);
  setHello("message from js");
}

export default function App() {
  const [result, setResult] = React.useState(multiply(4, 6));
  const [hello, setHello] = React.useState('');

  React.useEffect(() => {
    install();
    setHello(helloWorld());
    foo(callback);

    // callback("err123", "hello")
  }, []);

  return (
    <View style={styles.container}>
      <Text>Result: {result}</Text>
      <Text>Hello: {hello}</Text>
    </View>
  );
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    alignItems: 'center',
    justifyContent: 'center',
  },
  box: {
    width: 60,
    height: 60,
    marginVertical: 20,
  },
});

C++ module
#include "react-native-bikegadget-mainapp.h"
#include <jsi/jsi.h>
#include <jsi/jsilib.h>
#include <thread>
#include <android/log.h>
#include <ReactCommon/CallInvoker.h>

using namespace facebook::jsi;
using namespace std;

namespace bikegadgetmainapp
{
	// Function to register helloWorld in JSI
	void registerHelloWorld(Runtime &jsiRuntime)
	{
		auto helloWorld = Function::createFromHostFunction(
			jsiRuntime,
			PropNameID::forAscii(jsiRuntime, "helloWorld"),
			0,
			[](Runtime &runtime,
			   const Value &thisValue,
			   const Value *arguments,
			   size_t count) -> Value
			{
				string helloworld = "helloworld Ash 123";
				return Value(runtime, String::createFromUtf8(runtime, helloworld));
			});

		jsiRuntime.global().setProperty(jsiRuntime, "helloWorld", std::move(helloWorld));
	}

	void registerFoo(Runtime &jsiRuntime)
	{
		auto foo = Function::createFromHostFunction(
			jsiRuntime,
			PropNameID::forAscii(jsiRuntime, "foo"),
			1,
			[](Runtime &runtime, const Value &thisValue, const Value *arguments, size_t count) -> Value
			{
				if (count < 1 || !arguments[0].isObject() || !arguments[0].getObject(runtime).isFunction(runtime))
				{
					throw JSError(runtime, "Expected a function as the first argument");
				}

				// Create a shared reference to the user callback
				auto userCallbackRef = std::make_shared<Object>(arguments[0].getObject(runtime));

				// Lambda to be run in the new thread
				auto f = [&runtime, userCallbackRef]()
				{
					auto val = std::make_shared<std::string>("hello world");
					auto error = std::make_shared<Value>(Value::undefined());

					// Periodically log messages to Android log and sleep for 5 seconds
					while (true)
					{
						__android_log_print(ANDROID_LOG_INFO, "MyApp", "Log message to Android");
                        userCallbackRef->asFunction(runtime).call(runtime, *error, *val);
						std::this_thread::sleep_for(std::chrono::seconds(5));
					}
				};

				// // Launch the lambda in a new thread
				std::thread thread_object(f);
				thread_object.detach();

				return Value::undefined();
			});

		jsiRuntime.global().setProperty(jsiRuntime, "foo", std::move(foo));
	}
	// Function to install the JSI bindings
	void install(Runtime &jsiRuntime)
	{
		// Register the helloWorld function
		registerHelloWorld(jsiRuntime);
		registerFoo(jsiRuntime);
	}

	double multiply(double a, double b)
	{
		return a * b;
	}
}

Please create a repro using the Reproducer Template

@cortinico I have updated the issue with the required ReproducerApp.

In jsi.h, it specifies that JSRuntime can not be accessed concurrently. This crash

Represents a JS runtime.  Movable, but not copyable.  Note that
this object may not be thread-aware, but cannot be used safely from
multiple threads at once.  The application is responsible for
ensuring that it is used safely.  This could mean using the
Runtime from a single thread, using a mutex, doing all work on a
serial queue, etc.  This restriction applies to the methods of
this class, and any method in the API which take a Runtime& as an
argument.  Destructors (all but ~Scope), operators, or other methods
which do not take Runtime& as an argument are safe to call from any
thread, but it is still forbidden to make write operations on a single
instance of any class from more than one thread.  In addition, to
make shutdown safe, destruction of objects associated with the Runtime
must be destroyed before the Runtime is destroyed, or from the
destructor of a managed HostObject or HostFunction.  Informally, this
means that the main source of unsafe behavior is to hold a jsi object
in a non-Runtime-managed object, and not clean it up before the Runtime
is shut down.  If your lifecycle is such that avoiding this is hard,
you will probably need to do use your own locks.

@huzhanbo1996 Suppose only one thread in C++ is accessing the JS Runtime then how can we stop JavaScript from using Runtime when C++ is using it?

@huzhanbo1996 Suppose only one thread in C++ is accessing the JS Runtime then how can we stop JavaScript from using Runtime when C++ is using it?

In jsi.h, it suggests following solutions.

this could mean using the
Runtime from a single thread, using a mutex, doing all work on a
serial queue, etc.

It depends on what you want to achieve.  In code you post. I presume you want to dispatch the task in another thread and return the result by callback in JS  Thread. You could try things like serial queue or ReactContext.runOnJSQueueThread, both need some extra development and beyond this issue's scope.

hi @AbeereSpark, to ensure safe calls to JS functions from cpp files during asynchronous operations, you must use an jsCallInvoker. Your application crashes because most likely you are trying to access memory that is already allocated for other needs
1st - get jsCallInvoker from bridge context
for ios
auto& runtime = *jsiRuntime; auto callInvocker = bridge.jsCallInvoker; install(runtime, callInvocker); // install - cpp function
for android
`
this.reactApplicationContext.javaScriptContextHolder?.let { contextHolder ->
this.reactApplicationContext.catalystInstance.jsCallInvokerHolder?.let { callInvokerHolder: CallInvokerHolder ->
this.nativeInstall(contextHolder.get(), callInvokerHolder)
    return true
}

}
private external fun nativeInstall(jsi: Long, callInvoker: CallInvokerHolder)
`
in cpp
void install(Runtime &jsiRuntime, std::shared_ptr<react::CallInvoker> callInvoker) 	{ 		// Register the helloWorld function 		registerHelloWorld(jsiRuntime); 		registerFoo(jsiRuntime); 	}
then you will be able to use callInvoker something like this
while (true) 	{ 		__android_log_print(ANDROID_LOG_INFO, "MyApp", "Log message to Android"); 		callInvoker->invokeAsync([&runtime, error, val, userCallbackRef]{ 				userCallbackRef->asFunction(runtime).call(runtime, *error, *val); 		}); 		std::this_thread::sleep_for(std::chrono::seconds(5)); 	}
I haven't checked this code, maybe you need to play around with pointers, but the general idea is correct

@Evgen74 I am not sure if it's possible to get jsCallInvoker from bridge on a bridgeless mode. I am wondering if there is a way to access runtimeExecutor or CallInvoker in TurboModule on the JS thread. There was already a discussion about implementing something like that https://github.com/react-native-community/discussions-and-proposals/issues/196

@AbeereSpark You should be able to achieve something like that by generating C++ module which gets access to jsCallInvoker. You can read more about it here.

This seems to be more of a question and @coado kindly replied.
@Evgen74 @AbeereSpark can we consider it solved?

@coado @cipolleschi Tried to call Synchronously but it crashed and when calling from jsInvoker, the compiler says that the copy constructor is disabled. Please guide if i'm handling it incorrectly.

E:/AndroidSDK/ndk/26.1.10909125/toolchains/llvm/prebuilt/windows-x86_64/sysroot/usr/include/c++/v1/__memory/shared_ptr.h:279:37: error: call to
implicitly-deleted copy constructor of 'facebook::jsi::Function'

#include "NativeSampleModule.h"

namespace facebook::react {

NativeSampleModule::NativeSampleModule(std::shared_ptr<CallInvoker> jsInvoker)
    : NativeSampleModuleCxxSpec(std::move(jsInvoker)) {}

std::string NativeSampleModule::reverseString(jsi::Runtime& rt, std::string input) {
  return std::string(input.rbegin(), input.rend());
}

void NativeSampleModule::storeAndCallJSCallback(jsi::Runtime& rt, const jsi::Function& jsCallback) {
    #if 0
      auto callback = std::make_shared<jsi::Function>(jsCallback);
      jsInvoker_->invokeAsync([callback, &rt]() {
        std::string result = "Callback from C++!";

        callback->call(rt, jsi::String::createFromUtf8(rt, result));
      });
    #endif

    std::string result = "Callback from C++!";
    jsCallback.call(rt, jsi::String::createFromUtf8(rt, result));
}

} // namespace facebook::react

std::make_sharedjsi::Function(jsCallback)
have you tried std::move(jsCallback) instead? You can't create a copy of the function, but you can move it around.
Have a look at the TimerManager implementation for inspiration.

I think you should also be able to use the helper class AsyncCallback, that can be moved.
See here:
https://github.com/reactwg/react-native-new-architecture/discussions/216

@cipolleschi I implemented this approach, and it is working well. I will proceed as you and @hsjoberg suggested. Thanks for the solution @coado.
void NativeSampleModule::install(jsi::Runtime &jsiRuntime) {

    auto callFromCplusplus = jsi::Function::createFromHostFunction(
        jsiRuntime,
        jsi::PropNameID::forAscii(jsiRuntime, "callFromCplusplus"),
        1,
        [this](jsi::Runtime& runtime, const jsi::Value& thisValue, const jsi::Value* arguments, size_t count) -> jsi::Value {

            // Store the callback function reference
            auto userCallbackRef = std::make_shared<jsi::Object>(arguments[0].getObject(runtime));

            // Helper function to create "Hello {counter}" string
            auto createMessage = [&runtime](int counter) {
                return jsi::String::createFromUtf8(runtime, "Hello " + std::to_string(counter));
            };

            std::thread([userCallbackRef, this, &runtime, createMessage]() mutable {
                int counter = 0;  // Initialize counter

                while (true) {
                    // Prepare values
                    auto valPtr = std::make_shared<jsi::String>(createMessage(counter++));
                    auto errorPtr = std::make_shared<jsi::Value>(jsi::Value::undefined());

                    // Async call to JS function
                    jsInvoker_->invokeAsync([userCallbackRef, valPtr, errorPtr, &runtime]() {
                        userCallbackRef->asFunction(runtime).call(runtime, *errorPtr, *valPtr);
                    });

                    // Sleep for 5 seconds
                    std::this_thread::sleep_for(std::chrono::seconds(1));
                }
            }).detach();  // Detach the thread to run independently

            return jsi::Value::undefined();
        }
    );
    jsiRuntime.global().setProperty(jsiRuntime, "callFromCplusplus", std::move(callFromCplusplus));
}

@cipolleschi @hsjoberg, both of your solutions are working well. @hsjoberg, your solution simplifies things by eliminating the need for manual handling. Thanks to both of you for your great input!
void NativeSampleModule::storeAndCallJSCallback(jsi::Runtime& rt, jsi::Function jsCallback) {

    auto createMessage = [](int counter) {
        return "Hello " + std::to_string(counter);
    };

    std::thread([callback = std::make_shared<jsi::Function>(std::move(jsCallback)), this, createMessage]() mutable
    {
        int counter = 0;

        while (true)
        {
            std::string message = createMessage(counter++);

            auto messagePtr = std::make_shared<std::string>(std::move(message));

            jsInvoker_->invokeAsync([callback, messagePtr, this](jsi::Runtime& rt)
            {
                auto jsString = jsi::String::createFromUtf8(rt, *messagePtr);
                callback->call(rt, jsString);
            });

            std::this_thread::sleep_for(std::chrono::milliseconds(10));
        }
    }).detach();
}

void NativeSampleModule::callback(jsi::Runtime &rt, AsyncCallback<std::string> callback) {
    std::thread t([callback = std::move(callback)]() {
        int counter = 0;
        while (1)
        {
            /* code */
            callback.call("works without any issues " + std::to_string(counter++));
            std::this_thread::sleep_for(std::chrono::milliseconds(10));
        }

    });
    t.detach();
}

Closing as the author is unblocked and the current solution is working fine.


New package: GiulioSorrentino.astroni version 1.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/111023&drop=dogfoodAlpha

Installer type is not portable, is an exe created with winrar.
-s is silent install
-s1 is silent install with progress.

@wingetbot waivers Add Validation-No-Executables


Submission - Group 6: 2352117_2352743_2353077_2352698_2352152

Group 6 - Member List

No.
Full name
Student ID

1
Lê Quốc Bình
2352117

2
Lê Nguyễn Nhật Minh
2352743

3
Lý Trần Tân
2353077

4
Quách Kiến Long
2352698

5
Trương Vĩnh Cường
2352152

Description for BLD Policy
Our group submission introduces the BLD policy, a custom implementation of the Policy interface designed for efficiently managing stock and product placement in a simulated environment.
Key Features:

Initialization:

Maintains a counter to track actions and handles sorting of stocks and products by their size in descending order.
Attributes:

counter: Tracks the number of actions taken.
sorted_stocks_index: Stores indices of stocks sorted by area.
sorted_products: Contains products sorted by size.

Action Determination:

Implements a get_action method to decide placement of products in available stocks:

Iteratively checks stocks and products to find a feasible placement.
Prioritizes larger stocks and products for optimal space usage.

Sorting Logic:

Sorts stocks by area and products by size at the start of the process.

Placement Validation:

Includes submethods such as quick_check and _can_place_ to verify placement feasibility.

Our BLD policy is intended for simple implementation where efficient space allocation and inventory management strategies are necessary.

Description for FFDInspired Policy
We also want to introduces the FFDInspired policy, another implementation of the Policy interface inspired by the First-Fit Decreasing (FFD) algorithm. This class is designed to efficiently cut and allocate stocks to fulfill product requirements while optimizing space utilization.
Key Features:

Initialization:

Initializes with default attributes to manage action sequences and solve state:

actions: Stores the sequence of actions to be taken.
action: Tracks the current action index.
solved: Indicates whether the problem has been solved.

Action Determination:

Implements the get_action method:

Retrieves the next action based on the current state.
If the solution is not yet found, it calculates stock cuts based on the provided products and stocks.
Returns actions in sequence and resets once all actions are taken.

Stock Cutting Logic:

The cut_stocks method performs the following:

Matches products to stocks, maximizing the filled area.
Uses a recursive strategy to allocate products either vertically or horizontally.
Generates cutting patterns and builds actions based on these patterns.

Submethods:

not_empty: Checks if there are remaining stocks or products.
cut_stock: Determines the best stock and cutting patterns to maximize fill efficiency.
build_actions: Translates cutting patterns into actionable instructions for product placement.

FFD-Inspired Placement:

Adopts a recursive strategy (RFFD) to optimize placement within stocks by comparing vertical and horizontal fits.

Our FFDInspired policy is particularly suited for scenarios where efficient resource allocation and space optimization are critical.

Performance Evaluation

Avg / 1000 runs (seed 42-1041)
Filled ratio
Trim loss
Time (s)

BLD
0.12414
0.20217
1.81584

FFDInspired
0.15694
0.08105
0.70293

Please revise the PR in Dec 16. Otherwise, your group will get 0 score for code.


Update example-even-nums-parallel.erl

There was a missing end on the receive, and the function was only returning Even,
when the spec says it would return a tuple.

thanks!

@garazdawi
I'm a bit late to the party, but FWIW: The mapreduce function really doesn't suggest anything about what the function it gets may return, so Even is a bad name. For example, I may use mapreduce from a function like odd, analogous to how it is used in even but for checking odd-ness.


Please add comment how  ADAL EOS on Jun. 30 2022 affects on Office 2013 in which MSAL is not supported

[Enter feedback here]
Please add comment how  ADAL EOS on Jun. 30 2022 affects on Office 2013 in which MSAL is not supported.  I've received an question from customer if Modern Authentication cannot be used in Office 2013 after ADAL EOS.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7cd3a343-4140-e63d-5197-06cafdab4639
Version Independent ID: 12cf7dda-2caf-0fe2-1564-a14dea00d46f
Content: How modern authentication works for Office 2013 and Office 2016 client apps - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/modern-auth-for-office-2013-and-2016.md
Service: o365-administration
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

@MSFTTracyP Please help us in resolving this issue. Thanks

can Modern Authentication be used in Office 2013 after ADAL EOS?
The ADAL end of life announcement is in regards to support tickets and patches for security vulnerabilities.  The Azure AD endpoint is "standards-protocol complaint", and there will be no server-side change that will block an ADAL client or any other client using standards-based protocols.  This is more about expectation that there will be no new releases of ADAL even in the case of an security vulnerability.

Also, please note that ADAL end-of-life has been extended to Dec 2022:
https://docs.microsoft.com/en-us/azure/active-directory/develop/howto-get-list-of-all-active-directory-auth-library-apps

@aikoitoms Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Feature request: Automatically handle errors by rejecting proposal

It would be useful to  have the option to tell tell Turing that if it encounters any errors encountered whatsoever during sampling, to just reject the proposal.
This would make for simpler/more elegant code on the user end. Error handling can be optimised by Turing devs, for everyone's benefit, and relatedly will reduce frustration for new users encountering errors in perfectly well formulated models.
I believe Stan does something like this by default i.e. I have never had to (and wouldn't know how to) handle errors during sampling in Stan. It just throughs a warning, rejects the proposal and keeps going.

Can you explain what errors you have in mind? Would you like Turing to catch any exceptions when calling the model? Or are you thinking about specific numerical issues?
I think usually it's good if your code fails if there is a fundamental issue with it. I also assume that wrapping the model function in a try-catch block would cause slow downs and is e.g. not supported by Zygote. More generally, I don't think it's common to catch errors that generally (and I don't think it's good style), SciML and probably any optimization package will catch at most specific errors.
On the other hand handling specific clearly defined errors, e.g., related to incorrect user input, model specification etc., and presenting users with better error messages is probably a good thing to do (there are some recent improvements in that regard in SciML that are summarized in the latest announcement). We also already handle specific numerical issues in HMC and reject the corresponding proposal (but it could be a bit less verbose, I assume...).

Hi David
From personal experience I sometimes get out of domain errors related to the likelihood function where I know that this should not be possible, given the model specification. In cases like this, a flood of warnings will make it obvious that there is actually something wrong with the specification. But  one or two warnings is definitely preferable to the complete loss of a long running chain.
I guess, my initial thought was "Once I'm confident that my model is correct, let me have a setting that will catch (and continue) any exception at all that comes up during sampling". But maybe it would be better if this were restricted to errors during likelihood calculations, since if the user is doing additional calculations that could throw errors then they should be comfortable handling those errors themselves. However, for a fairly vanilla model that has a likelihood function with a restricted domain, it would be nice for (particularly new) users to have an option that warns rather than errors.


No event is now permissible

Prior to this PR, not having a to_state was permissible. This PR takes this notion further whether it is possible to have commands without any event emission.

While we are at it: these any cases ought to come after more specific cases for the same command.   I suppose we leave that to the person writing the the DSL.  Do they get a sensible error if an any case shadows another case for the same command?

While we are at it: these any cases ought to come after more specific cases for the same command. I suppose we leave that to the person writing the the DSL. Do they get a sensible error if an any case shadows another case for the same command?

They should. Some of the error handling is a little unhelpful though and could be improved

While we are at it: these any cases ought to come after more specific cases for the same command. I suppose we leave that to the person writing the the DSL. Do they get a sensible error if an any case shadows another case for the same command?

I've now created an issue and asked a question on the Rust lang forum: https://github.com/titanclass/edfsm/issues/4.


New Keolis feed

https://app.asana.com/0/584764604969369/1201382502693001/f
Preliminary PR for this. It was extremely difficult to reuse the existing parsing infrastructure because the new format is so different (particularly in field types), and I didn't want to compromise on validating the old format. I also did not go to much effort to refactor the existing code, because I know we're planning to replace it. Looking for suggestions on how best to test this code, again it seemed unwise to mingle it with the old paths. I'm not sure how to update the environment variables but I am deploying this to dev, so we can see that it hasn't broken the old feed.

did I miss tests for the new parsing, or the behavior for the new message type?

I haven't finished the tests yet and that's the plan for the today. What do you mean by behavior for the new message type? Like a new module?

did I miss tests for the new parsing, or the behavior for the new message type?

I haven't finished the tests yet and that's the plan for the today. What do you mean by behavior for the new message type? Like a new module?

I thought that the new messages were different from the old ones (different type for the trip ID, for example)? And I didn't see any tests of new message parsing.


6 additional GitHub actions

Which issues are addressed by this Pull Request?
#6
What does this Pull Request change?
This PR makes small improvements to current Actions, such as updating the CodeQL version and adding a check by Snyk, which runs on a schedule.
Does this Pull Request introduce any portentially breaking changes?
no

Closed and moved into the BiancoRoyal repository, available here


Create setup-node

Description:
Describe your changes.
Related issue:
Add link to the related issue.
Check list:

[ ] Mark if documentation changes are required.
[ ] Mark if tests were added or updated to cover the changes.

@brcrista just spam.
Noted a few of these PRs from this user. Not exactly sure the best method to report these users with GitHub?

@magnetikonline

Spam

Thx @vsafonkin 👍


failing to build on mac

trying to run the example in step 3 gives me this error on mac, any ideas?
cargo run --example minimal
Compiling sciter-rs v0.4.0
src/window.rs:82:33: 82:37 error: mismatched types:
expected platform::windows::OsWindow,
found *mut capi::sctypes::_HWINDOW
(expected struct platform::windows::OsWindow,
found *-ptr) [E0308]
src/window.rs:82 		Window { base: OsWindow::from(hwnd), host: Rc::new(Host::attach(hwnd)) }
^~~~
src/window.rs:82:33: 82:37 help: run rustc --explain E0308 to see a detailed explanation
error: aborting due to previous error
Could not compile sciter-rs.

when you build it on mac or linux,the struct OsWindow do not have a method named "from".so you can not built it on mac.
you can fix it like this:
/// Attach Sciter to existing native window.
 pub fn attach(hwnd: HWINDOW) -> Window {
		#![cfg(windows)]
		assert!( hwnd.is_null() == false );
		Window { base: OsWindow::from(hwnd), host: Rc::new(Host::attach(hwnd)) }
	}

Thanks for reporting this. Try now.


Put maas_excluded_checks removal into its own task

The logic around removing maas checks based on the maas_excluded_checks
list is flawed in that it runs after every "check/alarm" setup task, and
removes checks based on the checks it's setting up.
We need to remove checks in the list if they exist at all, regardless of
whether they are being set up or not.
This PR moves the removal task into its own included task file and will
remove any checks that exist with the listed checkname (for remote
checks) or checkname-inventory_hostname (for local checks).
Fixes-Issue: #681

+1

@andymcc this won't work for the network checks as they have a slightly different conf file naming convention - that's why I'd added that separate stanza to the networks file.

@mancdaz the stanza in the network checks didnt work at all... I fixed it up, and I tested this specifically with network checks - can you show an example of where it didnt work?

Here's my maas_excluded_checks var that I tested to remove checked for eth2/eth3 on my install, which worked as intended with the above patch.
maas_excluded_checks:

network_throughput-eth2
network_throughput-eth3

:+1: looks good, can we create a backport for kilo as well?

I can put a backport in once we get this merged - do we just need to re-run the gate?

master has been merged, we need a kilo backport for 11.1.1.

we'll need to backport @mancdaz PR first https://github.com/rcbops/rpc-openstack/pull/713
But it looks like there is another plan to backport these?
@mancdaz can you confirm how this is working/what needs to be done?

If this was in master at the time https://github.com/rcbops/rpc-openstack/pull/718 merged, then it won't need a kilo backport because it would have been brought in to kilo as a result of that large merge.
If it wasn't in master at that time, but has merged in since, then it will need a kilo backport

@mancdaz this was merged after #718, so I think it needs a kilo backport.

@d34dh0r53 backport was done here https://github.com/rcbops/rpc-openstack/pull/734


Fix IE11 support for MDCFoundation

Symbols don't exist on IE11

Sorry I didn't see this sooner @JetFault . It looks like you default to an empty array. This function is whats actually copying the class properties / methods over. I'm curious how this would work at all in this example.

My thinking is if Object.getOwnPropertySymbols doesn't exist, then there isn't any Symbols support, so it should return [].

Also, I didn't find any usage of Symbols in mwc-web or rmwc, and by default there are no Symbols on an object.

You're totally right, and I definitely misread the code. I'm not sure that needs to be in there at all, that was a copy pasta from stack overflow on runtime merging of classes! I'll get a patch out.


Mark new as unavilable interface

Add + (instancetype)new NS_UNAVAILABLE; in case there is mandatory initWithProtocol: interface.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @aranjan. Please complete the CLA and I can merge this in.

@artman I had already filled up CLA last week, its pending review.

Hmm, the assistant should be fully self-serve, not reviews needed...

CLA assistant still says that it hasn't received your signature...

Closing as stale.


SequenceVectors label alternative

At the moment SequenceVectors is still depended on the getLabel() method. So basically you are reducing your SequenceElement to a word again.
So in my opinion, there should be a more custom way on how to represent your SequenceElement. To make this work, I suppose the SequenceElement interface has to be extended with some methods:

Generic return type for your getLabel()
Compare method to compare your own implemented label to another label

Also the LookupTable has to be extended to handle those generic labels.

this is easy improvement, but label will be required for serialization to text via WordVectorSerializer

Isn't it possible to have other Serializers? I'm thinking that maybe a label could return a Double, INDArray, ... I guess those objects can also be Serialized without being converted to text?

Yes thats sure possible, i'm speaking about exactly saving model to text file. Binary serialization is another thing :)

Also when the SequenceVectors are plotted with TSNE, it would be great if the datapoints on the plot could have some other label based on the SequenceElement getTsneLabel() or something. Because SequenceVectors are hard to express and maybe a custom label for theTsne plot makes sense also.

Closing stale issue: cleanup.


New offset_groups() itertool

This addition is adapted from @joshbode's ActiveState recipe.
offset_groups() lets you specify a set of offsets by which to lead or lag the iterable. It will yield groups of items, the ith of which corresponds to the ith offset. This is a sort of generalization of a sliding window.
For example, to get a sliding window with both lookback and lookahead:
>>> list(offset_groups('abcdefg', offsets=(-2, -1, 0, 1)))
[(None, None, 'a', 'b'),
 (None, 'a', 'b', 'c'),
 ('a', 'b', 'c', 'd'),
 ('b', 'c', 'd', 'e'),
 ('c', 'd', 'e', 'f'),
 ('d', 'e', 'f', 'g')]

The longest parameter will continue until the last item of the iterable is the first item of the last group:
>>> list(offset_groups('abcdefg', offsets=(0, 1, 2), longest=True))
[('a', 'b', 'c'),
 ('b', 'c', 'd'),
 ('c', 'd', 'e'),
 ('d', 'e', 'f'),
 ('e', 'f', 'g'),
 ('f', 'g', None),
 ('g', None, None)]

fillvalue can be used in place of None as well. offsets is (-1, 0, 1) by default to get (before, during after) groups:
>>> for before, during, after in offset_groups('abcd', longest=True, fillvalue='?'):
...     print(before, during, after, sep='\t')
?	a	b
a	b	c
b	c	d
c	d	?
d	?	?

This is a nice feature.  It looks similar to windowed,  where offsets is a verbose form of n.   I see this as a windowed_offset.

Not sure if this is an issue, but zip(*iterables) is not lazy in Python 2 (though it is in Python 3)
which is why I went for izip(*iterables) in the original recipe.
Python 2
In [1]: import itertools

In [2]: x = range(10)

In [3]: iterables = itertools.tee(x, 3)

In [4]: zipped = zip(*iterables)

In [5]: zipped
Out[5]:
[(0, 0, 0),
 (1, 1, 1),
 (2, 2, 2),
 (3, 3, 3),
 (4, 4, 4),
 (5, 5, 5),
 (6, 6, 6),
 (7, 7, 7),
 (8, 8, 8),
 (9, 9, 9)]

Python 3
In [4]: zipped = zip(*iterables)

In [5]: zipped
Out[5]: <zip at 0x106522988>

In [6]: next(zipped)
Out[6]: (0, 0, 0)

In [7]: next(iterables[1])
Out[7]: 1

In [8]: next(zipped)
Out[8]: (1, 2, 1)

scratch that - looks like you're using zip/zip_longest from six.moves which is itertools.izip/itertools.izip_longest anyway.

Also, I'm open to a different name for this itertool. The original was offsetter; I went with offset_groups.
windowed_offset is suggested in this thread. I think of a "window"`as being continuous, which is not necessarily the case with this, so I think I'll steer clear of that.
It makes me thing of a "comb" function and the process of convolution from signal processing, but comb_slide is a weird name.

Another possibility: stagger as in a "staggered start" for a race/event (like a marathon), though the analogy breaks down since there's more than one racer, but only one teed iterable here.
Which makes me wonder if a useful generalisation to this function would be just that: a function to apply a list of offsets against a list of distinct iterables (rather than clones like here) - the function in this PR is then a special case.

Re: name, I like stagger! I asked my colleague, who is too cool for Github, and he also liked it. So I'll push that change shortly.
Re: generalization, this is a good idea. This one is actually easy to name - zip_offset().
My only issue is that it's really tough to write a docstring that covers the general case as well as the specific case concisely.
My thought is to make two functions: stagger() and zip_offset() - the former just calls the latter. Any objections?

Excellent :)
My thinking was that the generalised function could be called stagger and that the specialised cloning version would call it, i.e. stagger(tee(iterable, len(offsets)), offsets=offsets)

Mmhmm; I'm attached to stagger() being the cloning method and zip_offset() being the general method.
Very glad for the collaboration here; I really like how this has ended up!

Yeah! I don't feel too strongly about it being one way or the other, in any case :)

Plus, itertools might just be my favourite package in the standard library, so it is good to see this effort which I wasn't familiar with.

What implementations do you have in mind for stagger() and zip_offset()?

Applications? As Josh said in an e-mail:

I find myself reimplementing this function in any new language I'm using (did pretty much the same thing in Julia a few weeks ago) - for me, this function is key to doing simple lead/lag-type series analysis without resorting to something like pandas.

You can use stagger() to compute things like the number of points on surface of tetrahedron:
>>> from itertools import count
... from more_itertools import stagger, take
...
... squares = (n * n for n in count())
... points = (a + b for a, b in stagger(squares, offsets=(0, 2)))
... list(take(10, points))
[4, 10, 20, 34, 52, 74, 100, 130, 164, 202]

(though there are easier ways to do that...) I could also see it being useful for, e.g. Project Euler 263...

Please disregard.  I see now the implementations are already committed.  Thank you.

At the moment zip_offset and staggered are quite similar.  It took me a while to distinguish the difference.  For clarity, perhaps make in staggered this is a specialized case of zip_offset applied to one iterable.

They look reasonably distinct to me when rendered, especially since the first sentence of zip_offset()'s docstring says "zip the input iterables together" - what do you think?

I've been staring at this for a while.  I'll have to come back with fresh eyes.  Thanks for the reply.

The rendering does help.  For me, I think I would use zip_offset alone.

Looks like a good consensus! My only suggestion is to include in the docstring one example of a use case for it, perhaps the one from Josh's email. I like to do that for any of our more complicated routines.

Yep, good idea.


Add Add Device and Remove Device to Collections API

Ready for Review

This is looking good, merging now, thanks a lot!

Thank you Xuejie!


Scrollable dot is returning integers

The value in the scrollable info text decorator is returning integers instead. However my dataset only contains floats. Is this a bug?
scrollableInfoTextDecorator: (value) =>
                       this.state.chartCurrency === "xrp"
                         ? `${value} XRP`
                         : formatFiatCurrency(value, this.state.currency),

Same issue on my side


rgb values break inside

Wrap rgb value on secondary and tertiary  colours in a span the same as the CYMK sections

add
.rgb {
display: inline-block;
}
somewhere


Speed up duplicate checks

When we import publication data, the check for duplicates is slow. We are going to look at ways to improve the speed of that if we are going to import data on a more regular basis to prevent any issues of speed.

One way that we may be able to accomplish this is by building a GIN or GiST index on the title column for publications.
https://www.postgresql.org/docs/current/pgtrgm.html#id-<IP_ADDRESS>.7

I tried a few permutations of my original idea for this, but none of them seemed to improve anything. However, I discovered something simpler that seems to have sped the queries up by a couple of orders of magnitude. This should be enough to allow the whole process to complete in less than a day instead of taking weeks.


[reddit] "Add web site" page has a Content Security Policy error, and does not show the image

Noticed when I signed up using FireFox Nightly 76.0a1 (2020-04-06) (64-bit):

However, I'm not sure whether the image not being present is the same root cause as this CSP error.

hmm! i don't actually see that problem on firefox 75.0:

@jamietanna friendly ping?

I'm still seeing it, on ff77 (which I've just been upgraded to), but can't see it on ff75. I wonder if it's something new they're adding?

Or could it be something wrong with my user, perhaps?

hmm! ok. another step could be to try to repro it in firefox's safe mode, which i think would disable any browser settings, custom plugins, etc that might be affecting this. i'd hope we'd see a different console error message in that case, though, so only a guess...but it's complaining about a script inside a data:, which bridgy doesn't use at all, so i do kind of suspect a greasemonkey script or plugin or something similar.
otherwise, i still haven't reproed this, so if you do find time to dig in, please feel free!

@jamietanna checking in on this again, do you still see it on both of your reddit accounts? i'd love to fix this, but i still haven't managed to repro it myself.

I've managed to track it down to being the DuckDuckGo Privacy Essentials FIrefox extension. With that disabled, I can see the images again. So we can close this 👍
(Originally published at: https://www.jvt.me/mf2/2020/07/or4xo/)

aha. thanks for the extra sleuthing!


Empty requirements.txt

Does mailer have no requirements? If so, why have an empty requirements file?

It has. jinja2 is required. I'll make the required changes. Thanks for pointing it out!

Closed through #11.
Thanks @sananth12


Get Transmission by slug REST API enhancement suggestion

Suggest to add  new /transmission/slug/{slug}/start/{start}/end/{end}/{limit} API
The /transmission/slug/{slug}/{limit} GET API can only fetch the MaxLimit number of transmissions by specific Notification slug, which is unable to fetch large scale transmission data for a given slug.
Suggest to add a new /transmission/slug/{slug}/start/{start}/end/{end}/{limit} API so that user can query transmission data for a given slug by time range, to support large scale transmission data query for the specific Notification slug

@lindseysimple No promises on this for Edinburgh. Also, be advised that we are discovering {limit} has a different meaning under the transmission endpoint than everywhere else in the system. @cherrycl has more details.

@tsconn23 if you accept this API extension, could you please assign this issue to me?  We are making this request because we thought the GUI for Transmission needs this API to present the correct information for large scale.

@cloudxxx8 Assigned to you. Obviously, needs to be done quickly for inclusion in Edinburgh. I am assuming you'll also oversee any additions in the blackbox tests.

@tsconn23 PR is ready.


Narrow IDF dev metrics and decrease refresh interval for testing

Don't need to merge it.  Tested fine on branch.


Merge main to dev

Our dev branch is behind main, so we should merge main into dev so we get back on the same page with pull requests.

Merging just to get this back in order.

@all-contributors please add @tech3371 for review


Publish next version to npmjs-registry.ivyteam.io

I will add the version raise functionality with the our global version raise concept.


forge: introduce a compatibility test - (31)

Motivation
testsuite/compatibility-test functionality is added in ci, smoke test and forge.
Test Plan

cargo test

:sunny: Canary successful

/land

:broken_heart: Test Failed - ci-test

/land


<seed-transform-rest> should pass transformation result to slotted components

The component should query for slotted SEED components and pass the transformation result the way the slotted component needs it. E.g. pass it into a synopsis text.

changed epic to SCDH&3

added to epic SCDH&1

mentioned in commit 93fe3eb89a310c9db0c7e1ca47e4821811d7bc43

mentioned in commit 29ab5252a2a5ec0de8dd84d6e2cbcbf8af942464

Closed by 29ab5252.


feat: implement ENS reader on attester address input

implement ENS reader on attester address input

the component ENS reader from scaffold-eth
also add the ENS reader on the last step, if any recipient has ENS domain, to recognize it

Closing as solved in #8
cc: @HabacucMX


torrent?

I'm having trouble downloading the larger (mate-pinebook) image directly from github.   Is it possible to put the larger images at a torrent or other location where I can resume a stopped download instead of starting over.  Thx

curl has a -C that should work for github downloads.
details here

@itdaniher  Good suggestion didn't know curl had that option but the url for the release is actually a redirect to some AWS storage so it doesn't work.
So anyone know how to get the direct url to the image on aws?  If so using curl would work.  Otherwise I'm back to my initial request.

@dkebler I don't know if it is possible to download via the release page links, because as you point out, it re-directs, and curl grabs the redirect page instead. However, if you just want to grab the latest image (or even a specific one), you can use this script which is inspired by the install-to-emmc script.
It has some references to the rock64 in it as I originally knocked up a script for that, and then changed the bits I needed to make it work with the pine64. If you want the xenial-mate-pinebook image flagged as 'latest', just run it with 'xenial-mate-pinebook' as a parameter. If you want a specific version, tack that on the end. ie. for the 0.7.14 version of 'xenial-mate-pinebook', the command would look like ./dl_latest_pine64_image.sh xenial-mate-pinebook 0.7.14


CR37: Search Window: Add '(Req.)' text to date and location

Tools: JQuery

HTML "Required" added to date range boxes and location boxes as well


V2.0 Polar area arcs cover scale labels

The scale is drawn before the arcs thus the arcs cover the scale labels. @tannerlinsley thoughts on how to fix this?

Hmm.  There might need to be a flag and a callback for scales to be drawn post-dataset.  Or, we build in a layer controller that organizes all of it.  Probably the first option for now.  We can look into layering a lot of things down the road.

yeah, that's what I was thinking. We don't even need a flag since polarArea scales are in .scale instead of .scales we can just move one block in the Core.controller.draw() method however, then grid lines go over the arcs.

A note, I looked further into this. Seems like the canvas globalCompositeOperation is what we need to use. See MDN
There is some weird behaviour though when animating arcs that are drawn like this so the change needs to be made along with something else

Closing. This is a pretty low prio issue and no one has commented that they also need it.

I need it..., I think that it is a good idea, if you expand areas around labels you lost labels...