locale: Support setting locale on Windows

Signed-off-by: Kapil Chouhan<EMAIL_ADDRESS>Description

Now users can set the system locale on Windows with the help of locale resource.
Added test cases
Ensured chef-style on the code changes made

Related Issue
Fixes: #9450
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

@kapilchouhan99 looks it might not be idempotent.

Also make a point this only support language part for Windows and not lc_env so this will require document update.

So what you really want is something more like the windows_firewall resource:
https://github.com/chef/chef/blob/master/lib/chef/resource/windows_firewall_rule.rb
You'll want to get the lang resource for current_resource by powershelling out on windows or parsing the file on Linux. Then you can just use converge_if_changed(:lang) like is done in windows_firewall. That avoids a lot of the per platform logic here and is the correct way to load state and then change a system if the state doesn't match the desired state.


Problems reported in a file that doesn't exist

I deleted a Haskell source file and ghcide is still reporting compile errors in that module which no longer exists. VSCode keeps popping up an error message complaining that it can't open this file which no longer exists.

The text in the popup is:

Unable to open 'Concepts.hs': Unable to read file (Error: File not found (/home/chris/git/typeclasses.com/haskell/typeclasses/src/Typeclasses/Concepts.hs)).

Workaround: Restarting VSCode every time I delete a file fixes the problem.

This is entirely due to #123.  That probably needs to move from the DAML bit to ghcide proper.

Closing as a duplicate of #123, thanks for the report. We definitely need to fix this and given that we already have the logic in DAML it hopefully shouldn’t be too hard.


 So far so good. Image is still being downloaded. It would be nice though to have a second table (pretty much a copy of the container table) for all downloaded images, respectively all images that are being downloaded right now. Maybe even additional cancel buttons, one for stopping the download and one for stopping the overall creation of the container.

I am not yet sure what that flow should be. I will definitely implement an "image list" but am not sure how people will want to use the tool. Could you maybe explain in a bit more detail how you would want to work?
Anyway, this will be a later release as I first want to focus on getting what is already there stable and improve the existing components and then look to others. So again, thanks for very valid suggestion but it will be a bit until I start working on that area


Update the history before rendering promoted frames

Closes https://github.com/hotwired/turbo/issues/617
I'm extracting the history method selection to getHistoryMethodForAction in `util and using it in both Frames and Visits.
In case the frame needs to change the history, it update it before rendering the frame's content, and will call the proposed visit with updateHistory = false, which will avoid a second history update.
I'm also introducing the turbo:before-frame-render event. It started as a way of testing this change, but it became an actual valuable hook for frames. I'm following before-render steps and making the render pausable/resumable.

@seanpdoyle anything you'd like me to do to move this forward?

@seanpdoyle I'm rolling back the type changes in favor of #452. I'm bringing the as CustomEvent back while that's not merged. I don't think the casting is harmful especially because it's only in a test

Can you rebase/update the tests?

done!


Update Monsterstats to v1.1.0

Updating my plugin Monster Stats to v1.1 for improvements and bugfixes.
Change Log:
Version 1.1.0

Improvements and Bug Fixes:

Added support for monsters with multiple variants.
Improved visuals for mouseover tooltips.
Fixed mouseover tooltips not working with other tooltip plugins.
Added support for new/more NPCs.
NPC right click is now by ID and should be accurate to wiki data, all NPCs with wiki data stats/NPC Ids are available.

Please attribute the WrapLayout class according to the MIT license where it's from

Please attribute the WrapLayout class according to the MIT license where it's from

Apologies, this is done now. Do I need to submit a new PR?

not a big deal to wait until the next plugin update - or if you want to PR now, we can quickly approve it


Generalize Ctrl+DownArrow and Ctrl+UpArrow to most input-result widgets (Fix #179967)

Fix #179967.
This adds Ctrl+UpArrow and Ctrl+DownArrow navigation to

ExtensionsViewPaneContainer
KeybindingsEditor
CommentsPanel
MarkersView
Repl

The two keybindings are uniformly controlled by two new commands inputResults.focusResults and inputResults.focusInput.

Hey @hsfzxjy thanks so much for working on this. Something to consider - not sure if you have already thought of this - is are there pre-existing applications of this keybinding for each of the contexts?
IE in these views, does ctrl/cmd + up/downArrow have a function already that we will be overriding. I haven't gone through these yet individually, but that's what we'll need to do before proceeding with this so as to not break muscle memory.
for example, I adopted such a change in the search view - but did not realize that I broke muscle memory a bit since ctrl/cmd+downArrow when in the search in put box with multiline text should jump to the bottom of that, but currently instead jumps to the next input box.

@meganrogge Yes, I've investigated on this and ensure not breaking muscle memory.
The hardest part is that those Lists/Tables/Trees in the "results panel" by default use Ctrl+Up for scrolling up, which could conflict with the newly added action of focusing "input widget". I harmonize these two into:

If the List/Table/Tree is not scrolled at top most, Ctrl+Up will scroll it up as in the old version.
Otherwise, Ctrl+Up will focus corresponding "input widget", which is a new action compared with the old version.

Here's a list of behavior that this PR affects:
Extensions
Search box
Before: Ctrl+Down will focus extension list;
After: As-is.
Extension List
Before: Ctrl+Up will scroll up the extension list. If at top most position, nothing happens;
After: Ctrl+Up will still scroll up the extension list. If at top most position, focus the search box.

Keybinding Editor
Input box
Before: Ctrl+Down will focus keybinding table;
After: As-is.
Keybinding Table
Before: Ctrl+Up will scroll up the keybinding table. If at top most position, nothing happens;
After: Ctrl+Up will still scroll up the keybinding table. If at top most position, focus the input box.

MarkerView
Filter Box
Before: Ctrl+Down will focus view body;
After: As-is.
View Body
Before: Ctrl+Up will scroll up the view body. If at top most position, nothing happens;
After: Ctrl+Up will still scroll up the view body. If at top most position, focus the filter box.

CommentsView
Filter Box
Before: Ctrl+Down will focus the tree;
After: As-is.
Tree
Before: Ctrl+Up will scroll up the tree. If at top most position, nothing happens;
After: Ctrl+Up will still scroll up the tree. If at top most position, focus the filter box.

CommentsView
Filter Box
Before: nothing;
After: Ctrl+Down will focus the REPL Input.
REPL Input
Before: nothing;
After: Ctrl+Up will focus the filter box.

Amazing 🙌 thank you. I'll review this next week.

@meganrogge I see you are reviewing this PR. Is there anything you would need from me?

@roblourens could you pls make sure it looks good for your area?

@joaomoreno could you pls make sure this looks good to you? I tested and all works as expected 🙏🏼

I've completed a full rewrite on this PR in respond to @roblourens 's constructive suggestions. The changes at present are:

Disable command list.scrollUp when scrollbar is at top-most position. Also, disable command list.scrollDown when scrollbar is at bottom-most position.
Provide registerNavigatableContainer() function to enable Ctrl+Up/Down navigation among widgets in a container. Two new commands widgetNavigation.focusNext and widgetNaviagation.focusPrevious are added.
Enable such widget navigation under more cases, including ExtensionsViewContainer, KeybindingsEditor, Repl, CommentsPanel, MarkersView and TestingExplorerView.

@meganrogge I think we should start a new review? Sorry about the occupation of your precious time. Thanks! 🙏🏼

@hsfzxjy thank you so much for your continued work on this. based on my testing, things are working very well 🎉
I'm seeing this error though:
Error: vs/platform/list/browser/listService.ts(296,69): error TS2345: Argument of type 'this' is not assignable to parameter of type '{ readonly onDidScroll: Event<any>; readonly scrollTop: number; readonly scrollHeight: number; readonly renderHeight: number; }'.
  Type 'WorkbenchList<T>' is missing the following properties from type '{ readonly onDidScroll: Event<any>; readonly scrollTop: number; readonly scrollHeight: number; readonly renderHeight: number; }': onDidScroll, renderHeight

and found this part confusing - is there away we can avoid referencing this here?

@meganrogge Looks like the treeshaker is too aggressive in handling this:
class List<T> {
  // not being accessed in List<T> and its subclasses explicitly
  // this property got treeshaked away
  get renderHeight(): number { return xxx; };
}

class WorkbenchList<T> extends List<T> {
  constructor() {
    createScrollObserver(this);
  }
}

function createScrollObserver(widget: { renderHeight: number }) {
  use(widget.renderHeight);
}

Is there an elegant way to solve this?

The error is gone now. It was caused by an overly aggressive tree-shaking.


The admin logs page performs very badly with a lot of entries

At about 3000 pages of logs it takes 10 seconds to switch pages.

Fixed


WIP: Beam executor without writing to temporary arrays

This isn't ready for a full review yet since it doesn't have any tests -- I
haven't even run the code.

I'm going to close this. We implemented a variant of this executor inside xarray-beam (but on whole xarray datasets instead of numpy arrays):
https://github.com/google/xarray-beam/blob/0.0.1/xarray_beam/_src/rechunk.py
That would be a good starting point if anyone wants to revisit this.
In practice, Beam does seem to typically write out intermediate chunks to temporary storage, but it's still nice to have the whole thing in via Beam transforms, especially for composing into larger pipelines (e.g., Read Zarr -> Rechunk -> Calculate something -> Rechunk -> Write to Zarr)


When year filter (start or end) is cleared, the filter input is not updated

Possibly related to:

#75

Fixed by switching to @vueform/slider in 97178fc


Strings and Boxed types should be compared using "equals()"

This fixes 2 Sonarqube violations of rule S4973:
https://rules.sonarsource.com/java/RSPEC-4973
Sonarcloud violation URL:
https://sonarcloud.io/organizations/apache/issues?languages=java&open=AWoocNf3MflNeiYSIfWd&resolved=false&rules=squid%3AS4973&types=BUG
Jira Ticket:
https://issues.apache.org/jira/browse/SLING-8825

Merged, thanks for your contribution @HarisAdzemovic


Are you requesting a new package or reporting an issue on an existing one?
Reporting an issue with an existing package.
If reporting an issue on an existing one, what is the name of the package?
Please use the name as it appears in https://www.nixhub.io
bun
What changes are you requesting?
Summarize your request. If it's for an existing package that is not
working as expected, provide a concise explanation of what is going wrong.
bun seems to install as expected:
❯ devbox add bun

Installing package: bun@latest.

[1/1] bun@latest
[1/1] bun@latest: Success

❯ bun --version
1.0.2

❯ which bun
# <project-path>/.devbox/virtenv/.wrappers/bin/bun

however, when I try to run bun or bun --help, it just hangs.

Hey @theurgi I tried to reproduce this issue with<EMAIL_ADDRESS>but it seems to be running correctly on macOS without hanging. Can you share more information about the system you are testing this on?

Sure! Some very strange behavior indeed. I haven't had issues with any other Devbox packages. Devbox is amazing by the way, I absolutely love it, it's my favorite new thing! 😊
System info:
macOS 10.15.7
devbox-0.5.11
nix (Nix) 2.17.0
/bin/zsh

I know macOS 10.15.7 is deprecated but newer versions don't support my hardware, thanks Apple. 🙃 It's okay, Linux is way cooler anyway. And if Devbox integrates Home Manager... dream system. 😍
Reproduction
I've since made some changes on my system, so I'll recreate the setup and see if I encounter the same issue...
I originally had bun installed globally with nix-env:
❯ nix-env -q
bun-1.0.2

❯ which bun
/Users/user/.bun/bin/bun

❯ cat ~/.config/zsh/.zshrc
# ...
export BUN_INSTALL="$HOME/.bun"
export PATH="$BUN_INSTALL/bin:$PATH"
# bun completions
[ -s "$BUN_INSTALL/_bun" ] && source "$BUN_INSTALL/_bun"
# ...

I also wanted to create an isolated environment with Devbox:
~
❯ mkdir foo && cd foo

~/foo
❯ devbox init

~/foo
❯ devbox add bun
Ensuring nixpkgs registry is downloaded.
Downloaded 'github:NixOS/nixpkgs/8b5ab8341e33322e5b66fb46ce23d724050f6606' to '/nix/store/dwikaw0zm70m2jlv1ngjz2xf9j213jqm-source' (hash 'sha256-cJR9AFHmt816cW/C9necLJyOg/gsnkvEeFAfxgeM1hc=').
Ensuring nixpkgs registry is downloaded: Success

Installing package: bun@latest.

[1/1] bun@latest
[1/1] bun@latest: Success

~/foo
❯ devbox shell
Starting a devbox shell...

~/foo
❯ which bun
/Users/user/.bun/bin/bun # still the global version? 🤔

I thought maybe the global version was interfering and I really don't need a global version so...
❯ nix-env -e bun
uninstalling 'bun-1.0.2'
building '/nix/store/02lbcizi8442y58fcr03aj69vwp6ds8d-user-environment.drv'...

❯ nix-collect-garbage -d
removing old generations of profile /Users/user/.local/state/nix/profiles/profile ...

❯ cat ~/.config/zsh/.zshrc
# ...
#export BUN_INSTALL="$HOME/.bun"
#export PATH="$BUN_INSTALL/bin:$PATH"
# bun completions
#[ -s "$BUN_INSTALL/_bun" ] && source "$BUN_INSTALL/_bun"
# ...

> source ~/.config/zsh/.zshrc

~/foo
❯ which bun
/Users/user/.bun/bin/bun # still the global version? 🤔

> devbox rm bun # hangs ...

~/foo
❯ exit && cd # exit devbox shell

~
❯ which bun
/Users/user/.bun/bin/bun # wut??? very strange

~
> rm -rf .bun # this should do the trick

~
❯ which bun
bun not found # okay at least i'm not going insane 😅

Let's try again now that the global bun is gone.
~
> rm -rf foo && mkdir foo && cd foo

~/foo
❯ devbox init

~/foo
❯ devbox add bun
Ensuring nixpkgs registry is downloaded.
Downloaded 'github:NixOS/nixpkgs/8b5ab8341e33322e5b66fb46ce23d724050f6606' to '/nix/store/dwikaw0zm70m2jlv1ngjz2xf9j213jqm-source' (hash 'sha256-cJR9AFHmt816cW/C9necLJyOg/gsnkvEeFAfxgeM1hc=').
Ensuring nixpkgs registry is downloaded: Success

Installing package: bun@latest.

[1/1] bun@latest
[1/1] bun@latest: Success

~/foo
❯ devbox shell
Starting a devbox shell...

~/foo
❯ which bun
/Users/user/foo/.devbox/virtenv/.wrappers/bin/bun # Great!

~/foo
❯ bun
# blinking cursor ad infinitum...
# same with `bun --help`. 😞

~/foo
❯ bun --version
1.0.2 # this works? ¯\_(ツ)_/¯

~/foo
❯ cat devbox.lock
{
  "lockfile_version": "1",
  "packages": {
    "bun@latest": {
      "last_modified": "2023-09-19T14:14:51Z",
      "resolved": "github:NixOS/nixpkgs/8b5ab8341e33322e5b66fb46ce23d724050f6606#bun",
      "source": "devbox-search",
      "version": "1.0.2"
    }
  }
}

Spending a little more time with this and the issue seems to be between Nix, my system (macOS), and particularly nixpkgs.bun. I've not had this issue with any other Nix package.
Nix was installed on my system using the official and recommended multi-user installation script.
The strange thing is that, during the course of testing this by installing and uninstalling bun globally with nix-env, sometimes it worked while other times I experienced the same inability to run bun as I previously described.
In any case, this does not seem to be an issue with Devbox and it's not strictly blocking for me. I have no issues installing and running bun using the official script:
curl -fsSL https://bun.sh/install | bash

Just no isolated bun Devbox shell for now. 😞
Thanks for your help and consideration @Lagoja !


Home page not HTTPS by default (insecure login form)

If I navigate to http://codecombat.com, the Log in form is unsecured and would be sent over HTTP. 1Password pops up a big scary "This is not secure!" error if I try to use it to fill in my login.
We should probably have the homepage redirect to HTTPS by default to prevent it from ever having a page with a login form over HTTP.
Changing the URL to HTTPS manually fixes it for the current session and doesn't seem to cause problems.

See also #2505. @sderickson know any reason why we wouldn't just HTTPS-by-default the whole site at this point?

Not that I know of.

codecombat.com is now HTTPs all the time.


Decorators

What are decorators? How do they work? What can/should I use them for? What is the codegen, and how are they typechecked?

Now, decorators are a stage 2 proposal (in docs TypeScript, still stage 1](https://www.typescriptlang.org/docs/handbook/decorators.html))


[wip] Install phases termination

Terminate work and end lease after each install phase

I dont like this enough to merge. Need to think how to sort out some of our backend->install transitions to make it more readable and manageable. Current solution (to pass in stop channel looks like a hack). But we have 2 layers of independent stuff in the middle :/


direktivapps helper direktiv-actionid not set behaviour

Summary
If a client does not add the  direktiv-actionid header for e.g. testing the direktivapps helper sends a 200 OK back with no indication whats wrong.

By default it will error and say u need to provide an action id or 'development' as the action id incase you are developing the app locally.


Text rendering blurry on retina.

I noticed that text rendering is blurry on retina screens.

I see the same. Here screenshot for comparison

Thanks for the report and screenshot! I think it may be an issue with the rendering strategy I'm using. I think https://github.com/rhysd/NyaoVim handles some of the cases a bit better, need to try it out and see.
There's a few ideas in this StackOverflow post as well-
http://stackoverflow.com/questions/4550926/subpixel-anti-aliased-text-on-html5s-canvas-element
Will do some testing and report back

Aren't you drawing on quarter resolution? This looks too blurry to be the difference between pixel anti-aliasing and sub-pixel anti-aliasing. I think macOS renders applications at "normal" resolution by default, unless they explicitly intend to work correctly on retina screens. A way to test this would be to check the resolution of the canvas and see if it's how it'd be on a low-resolution screen or a retina screen (which should be double in both dimensions)
Either way it doesn't seem like the text is rendering with sub-pixel anti-aliasing anyway, but I believe that's a separate issue.

@darkwater - I believe you're correct. We're ignoring the devicePixelRatio value, which I believe on retina devices would be 2. So we're using the device-independent pixels, which would basically render at quarter resolution. Seems like that may need to be accounted for in the canvas rendering logic and the resize logic.


⚠ SkyfallMC Minecraft Server has degraded performance

In 16893d9, SkyfallMC Minecraft Server (play.skyfallmc.ga) experienced degraded performance:

HTTP code: 200
Response time: 1782 ms

Resolved: SkyfallMC Minecraft Server performance has improved in 76feba6.


iOS project is not compiling "No package 'openssl' found"

xcode log：Package openssl was not found in the pkg-config search path.
Perhaps you should add the directory containing `openssl.pc'
to the PKG_CONFIG_PATH environment variable
No package 'openssl' found
Could not run pkg-config.
I use "export PKG_CONFIG_PATH="/usr/local/opt/openssl/lib/pkgconfig" in terminal, it's no problem, pkg-config can search openssl. but how to do in Xcode?

@andrewstang Put that export line in your ~/.bashrc (the relevant Xcode bits are run in bash)?  Or manually run bootstrap from the command line in your terminal so that Xcode is not trying to do it.
That said, the symlink approach described at https://github.com/project-chip/connectedhomeip/blob/master/docs/guides/BUILDING.md#installing-prerequisites-on-macos should also work (including on an M1 Mac, as long as the paths are correct; it looks like in your case things are in /usr/local/opt, not /usr/local/lib or /opt/homebrew/opt/.., which may depend on the exact package manager you used to install openssl).

That said, the fact that this depends on openssl at all is broken.  I'll see if I can fix that.

@bzbarsky-apple I pull down new repos, but it still fails to compile. build log
Build CHIP Tool App_2023-02-08T19-32-57.txt

@andrewstang Is that with the export PKG_CONFIG_PATH bits added to your .bashrc?  If not, then "pull down new repos" is not going to change anything, since https://github.com/project-chip/connectedhomeip/pull/24901 is not merged yet.

@andrewstang OK, now #24901 is merged.  Try tip?

@bzbarsky-apple build success！！！thanks a lot

@andrewstang No problem, and thank you for filing this!


fix(client): Fix redundant query calls in React live query hook

The useLiveQuery React implementation had redundant calls to the adapter and some other redundant calls to subscribe/unsubscribe from changes.
I removed any unnecessary state and references to simplify the binding, and enhanced a couple of tests to ensure there are no redundant query calls.

This looks really great, massively easer to follow.
Have you fully tested this with your recipes app?

I have not tested this in the recipes app, it's not merged on main yet, but I've enhanced the existing tests a bit to check for number of calls and ensured nothing else was affected.
I think the next step would be to refactor the "subscribeToDataChanges" to a more generic, framework independent interface and then reuse it to create bindings for the various reactive frameworks.


(7.5-alpha)  ObserveOn adds System.Windows.Forms dependency

In version 7.4, you can use the .ObserveOn(IScheduler) extension methods without any dependency on System.Windows.Forms.  In upgrading to the latest alpha (in order to leave Rx behind), the compiler yells that Control requires System.Windows.Forms v<IP_ADDRESS>.
Repro

Create a new .Net 4.7 framework console application, and add the Alpha 7.5.0-alpha package.

Add a reference to WindowsBase.dll

Modify the Program.cs to the following:

using System;
using System.Reactive.Concurrency;
using System.Reactive.Linq;
using System.Reactive.Subjects;

namespace ConsoleApp1
{
    class Program
    {
        static void Main(string[] args)
        {
            Subject<string> a = new Subject<string>();
            a.ObserveOn(ThreadPoolScheduler.Instance).Subscribe(x => Console.Write(x));    //<<ObserveOn needs System.Windows.Forms so it can resolve Control, even though we just want to hand it a scheduler.
//please also ignore the 'why' you might want to do this, the same problem exists for any scheduler.
        }
    }
}

Note that there is now a requirement on System.Windows.Forms

System.Windows.Forms should not be required to use schedulers for non-winforms projects, especially WPF.  This appears to have been introduced by the changeover to the newer System.Reactive and is not an issue with 7.4.  This is an issue with 7.5-alpha30, and may be related to a binding redirect.

@PixelHero thank-you for the repro and high quality bug report. 👍

Looking into this over at https://github.com/reactiveui/ReactiveUI/pull/1411


Replace hardcoded github links by an extlink #3472

Building the docs locally failed with several error messages like. Warnings during build are treated as error:
docs/ci.rst:11:hardcoded link 'https://github.com/features/actions' could be replaced by an extlink (try using ':gh:`features/actions`' instead)
docs/ci.rst:332:hardcoded link 'https://github.com/ansible-community/molecule/issues/1567#issuecomment-436876722' could be replaced by an extlink (try using ':gh:`ansible-community/molecule/issues/1567#issuecomment-436876722`' instead)
docs/contributing.rst:11:hardcoded link 'https://github.com/ansible-community/molecule/projects' could be replaced by an extlink (try using ':gh:`ansible-community/molecule/projects`' instead)
docs/contributing.rst:12:hardcoded link 'https://github.com/ansible/community/wiki/molecule' could be replaced by an extlink (try using ':gh:`ansible/community/wiki/molecule`' instead)
docs/contributing.rst:32:hardcoded link 'https://github.com/ansible-community/molecule/issues/new/choose' could be replaced by an extlink (try using ':gh:`ansible-community/molecule/issues/new/choose`' instead)
docs/contributing.rst:37:hardcoded link 'https://github.com/ansible-community/molecule/blob/main/DCO_1_1.md' could be replaced by an extlink (try using ':gh:`ansible-community/molecule/blob/main/DCO_1_1.md`' instead)
docs/contributing.rst:51:hardcoded link 'https://github.com/ansible-community/molecule/blob/main/.github/CODE_OF_CONDUCT.md' could be replaced by an extlink (try using ':gh:`ansible-community/molecule/blob/main/.github/CODE_OF_CONDUCT.md`' instead)
docs/contributing.rst:58:hardcoded link 'https://github.com/ansible/community/wiki/Molecule#join-the-discussion' could be replaced by an extlink (try using ':gh:`ansible/community/wiki/Molecule#join-the-discussion`' instead)
docs/contributing.rst:58:hardcoded link 'https://github.com/ansible/community/wiki/Molecule#meetings' could be replaced by an extlink (try using ':gh:`ansible/community/wiki/Molecule#meetings`' instead)
docs/contributing.rst:185:hardcoded link 'https://github.com/retr0h' could be replaced by an extlink (try using ':gh:`retr0h`' instead)
docs/contributing.rst:185:hardcoded link 'https://github.com/ansible-community/molecule/graphs/contributors' could be replaced by an extlink (try using ':gh:`ansible-community/molecule/graphs/contributors`' instead)
docs/contributing.rst:185:hardcoded link 'https://github.com/ansible/community/wiki/Molecule' could be replaced by an extlink (try using ':gh:`ansible/community/wiki/Molecule`' instead)
docs/examples.rst:10:hardcoded link 'https://github.com/ansible-community/toolset' could be replaced by an extlink (try using ':gh:`ansible-community/toolset`' instead)
docs/faq.rst:53:hardcoded link 'https://github.com/kireledan/molecule/tree/playbook_proto' could be replaced by an extlink (try using ':gh:`kireledan/molecule/tree/playbook_proto`' instead)
docs/faq.rst:74:hardcoded link 'https://github.com/nylas/ansible-test' could be replaced by an extlink (try using ':gh:`nylas/ansible-test`' instead)
docs/faq.rst:74:hardcoded link 'https://github.com/nylas/ansible-test/issues/14' could be replaced by an extlink (try using ':gh:`nylas/ansible-test/issues/14`' instead)
docs/installation.rst:149:hardcoded link 'https://github.com/ansible-community/toolset' could be replaced by an extlink (try using ':gh:`ansible-community/toolset`' instead)

This commit replaced the hardcoded links by an extlink

Have you read that line https://github.com/ansible-community/molecule/blob/main/setup.cfg#L74 ? -- you will know why we do not upgrade Sphinx yet.

running tox -e docs locally gives me Sphinx==4.4.0 ¯\_(ツ)_/¯

running tox -e docs locally gives me Sphinx==4.4.0 ¯_(ツ)_/¯

Run tox -re docs once to force it to recreate it. That is because your old venv is very old. Upgrading to tox v4 would save you from similar bugs, where tox uses outdated venvs.

Closing as not really needed. The major problem is that this is making the editing harder with various editors as it makes use of special syntax.


Error using gtburst

Hello everyone, when I use the gtburst to download Fermi LAT data, I get an error.The specific gtburst.log file is as follows
Analysis started at 2022-10-13 16:23:38 by user jian

--------------------------------------------------
Welcome to the Fermi Burst Analysis GUI v. 03-00-00p5!
Credits: G.Vianello (giacomov@slac.stanford.edu), N.Omodei<EMAIL_ADDRESS>This software embeds:
 -gtapps_mp by J. Perkins (http://fermi.gsfc.nasa.gov/ssc/data/analysis/user/)
 -APlpy                   (http://aplpy.github.io/)
These packages are property of the respective authors.
-------------------------------------------------
Use the -fast flag when running gtburst to speed up the code
 (the coinsole will not be captured in the GUI)
-------------------------------------------------
Query parameters:
                    coordfield = 204.9,-8.4
                   coordsystem = J2000
                    shapefield = 60.0
                     timefield = 256534404.558,256549404.558
                      timetype = MET
                   energyfield = 30,1000000
        photonOrExtendedOrNone = Extended
                   destination = query
                    spacecraft = checked
url query: https://fermi.gsfc.nasa.gov/cgi-bin/ssc/LAT/LATDataQuery.cgi?coordfield=204.9%2C-8.4&coordsystem=J2000&shapefield=60.0&timefield=256534404.558%2C256549404.558&timetype=MET&energyfield=30%2C1000000&photonOrExtendedOrNone=Extended&destination=query&spacecraft=checked

Answer from the LAT data server:

Estimated Time For The Query....: 77.0
done
Local data repository (destination): /home/jian/FermiData/bn090217206 (already existent)
Retrieving L22101304284572741BED98_EV00.fits ...  done
Retrieving L22101304284572741BED98_SC00.fits ...  done

Download files done!
Writing /home/jian/FermiData/bn090217206/gll_cspec_tr_bn090217206_v00.rsp...
time -p gtselect infile=/home/jian/FermiData/bn090217206/gll_ft1_tr_bn090217206_v00.fit outfile=__temp_ft1.fits ra=204.9 dec=-8.4 rad=15.0 tmin=256538403.558 tmax=256540405.558 emin=10.0 emax=300000.0 zmin=0.0 zmax=110.0 evclass="INDEF" evtype="INDEF" convtype=-1 phasemin=0.0 phasemax=1.0 evtable="EVENTS" chatter=2 clobber=yes debug=no gui=no mode="ql"
/bin/sh: 1: time: not found
Writing /home/jian/FermiData/bn090217206/gll_cspec_tr_bn090217206_v00.pha...
 *  Get energy binning from the response matrix...
-------------- EXCEPTION ---------------------------

Snap! An unhandled exception has occurred at line 147 of file gtburst.py.

The program will try to continue running. If you think this is a bug, send a message to<EMAIL_ADDRESS>attaching your gtburst.log file.

The full traceback has been saved to the log and printed in the console.

Traceback (most recent call last):
  File "/home/jian/miniconda3/envs/fermi3ML/lib/python3.9/site-packages/fermitools/gtburst.py", line 137, in handle_exception
    return method(*args, **kwargs)
  File "/home/jian/miniconda3/envs/fermi3ML/lib/python3.9/site-packages/fermitools/gtburst.py", line 1588, in downloadDataSetFromFTP
    downloader.getFTP()
  File "/home/jian/miniconda3/envs/fermi3ML/lib/python3.9/site-packages/fermitools/GtBurst/downloadTransientData.py", line 342, in getFTP
    dataHandling._makeDatasetsOutOfLATdata(newFilenames['ft1'],newFilenames['ft2'],
  File "/home/jian/miniconda3/envs/fermi3ML/lib/python3.9/site-packages/fermitools/GtBurst/dataHandling.py", line 652, in _makeDatasetsOutOfLATdata
    gtllebin(**parameters)
  File "/home/jian/miniconda3/envs/fermi3ML/lib/python3.9/site-packages/fermitools/GtBurst/commands/gtllebin.py", line 56, in gtllebin
    run(**kwargs)
  File "/home/jian/miniconda3/envs/fermi3ML/lib/python3.9/site-packages/fermitools/GtBurst/commands/gtllebin.py", line 95, in run
    lleData                     = dataHandling.LLEData(eventfile,rspfile,ft2file)
  File "/home/jian/miniconda3/envs/fermi3ML/lib/python3.9/site-packages/fermitools/GtBurst/dataHandling.py", line 781, in __init__
    raise IOError("File %s does not exist!" % (eventFile))
OSError: File __temp_ft1.fits does not exist!

-------------- EXCEPTION ---------------------------
-------------- EXCEPTION ---------------------------

Snap! An unhandled exception has occurred at line 147 of file gtburst.py.

The program will try to continue running. If you think this is a bug, send a message to<EMAIL_ADDRESS>attaching your gtburst.log file.

The full traceback has been saved to the log and printed in the console.

Traceback (most recent call last):
  File "/home/jian/miniconda3/envs/fermi3ML/lib/python3.9/site-packages/fermitools/gtburst.py", line 137, in handle_exception
    return method(*args, **kwargs)
  File "/home/jian/miniconda3/envs/fermi3ML/lib/python3.9/site-packages/fermitools/gtburst.py", line 1105, in run
    self.root.mainloop()
  File "/home/jian/miniconda3/envs/fermi3ML/lib/python3.9/tkinter/__init__.py", line 1429, in mainloop
    self.tk.mainloop(n)
KeyboardInterrupt

-------------- EXCEPTION ---------------------------

Note:
OS: Linux DESKTOP-10UCA6U <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Mon Sep 19 19:14:52 UTC 2022 x86_64 GNU/Linux
Python V 3.9.13
pip V 22.2.2
Fermitools V 2.2.0
fermitools-data V 0.18

From your error log"/bin/sh: 1: time: not found"
It looks like you don't have the "time" shell command installed, which is very strange as I think it comes with every unix/linux distribution. time program can be installed as:
apt-get install time
All that said, are you sure your system's sh is pointing to bash?

Problem solved, thanks to all developers!


Support $grid-gutter-widths for responsive gutter widths

This is actually a missing feature that appears on the doc:
Variable : $grid-gutter-widths
https://v4-alpha.getbootstrap.com/layout/grid/#variables
This approach aims to define different gutter widths depending on the defined breakpoints.

I read from other PRs that this feature was removed because it generates to much code (~5k). Maybe there is a way to get less code using instead :
@include media-breakpoint-only($breakpoint, $breakpoints) {
  $gutter: map-get($gutters, $breakpoint);

  [class^='col'],
  [class*=' col'] {
    padding-right: ($gutter / 2);
    padding-left: ($gutter / 2);
  }

  .row {
    margin-right: ($gutter / -2);
    margin-left: ($gutter / -2);
  }
}

Hi @gloaec thanks a lot for your contribution.
The reference to the docs you provide is for an alpha release, beta docs are now here:
http://getbootstrap.com/docs/4.0/getting-started/introduction/
As you mention, the responsive gutters were removed here: https://github.com/twbs/bootstrap/commit/b013b987b0b770434b3bc1ec61a7b9971a73aedb
If we want to prosigue with getting them back, it should also be introduce back to the docs
And although I honestly don't think this approach solves the problem, and it's missing how to handle the make- mixns. http://getbootstrap.com/docs/4.0/layout/grid/#mixins I do think that
there is value is having responsive gutters.

Seems that @mdo idea is to implement responsive gutter width via implementtion similar to .no-gutters as per this https://github.com/twbs/bootstrap/issues/22944

Here in documentation it still stands
"Grid gutters now have a Sass map so you can specify specific gutter widths at each breakpoint."
https://getbootstrap.com/docs/4.0/migration/
https://getbootstrap.com/docs/4.1/migration/
I'd assume this is wrong?

@hrvojegolcic yup, from my knowledge, responsive gutters were definitely removed. I ended up adding custom sass in my projects (and honestly, since "css flexboxes", there's no real need for the grid system anymore).

I do think that there is value having responsive gutters.

@andresgalante I think it makes sense to a lot of people to have smaller gutters on smaller screens. No hard feelings if the goal is now to have the lightest library, but yeah, the docs needs to be updated ;)
Cheers !

Can someone please update the docs to remove this feature if it's not implemented! Went down a rabbit hole today trying to get this to work :(

While the solution from @gloaec works fine I have noticed that this breaks up no-gutters class. So in my case this worked:
@include media-breakpoint-up(lg) {
    .container,
    [class^='col'],
    [class*=' col'] {
        padding-right: floor($cust-grid-gutter-width-lg-up / 2);
        padding-left: ceil($cust-grid-gutter-width-lg-up / 2);
    }

    .row {
        margin-right: ceil($cust-grid-gutter-width-lg-up / -2);
        margin-left: floor($cust-grid-gutter-width-lg-up / -2);
    }
}

// Since we overwrite gutters in each viewports we need to repeat this class here
.no-gutters {
    margin-right: 0;
    margin-left: 0;

    > .col,
    > [class*="col-"] {
        padding-right: 0;
        padding-left: 0;
    }
}

@hrvojegolcic nice! Here's the mixin version I used from your example:
@mixin responsive-gutter($size, $gutter-width) {
  @include media-breakpoint-up($size) {
    .container,
    [class^='col'],
    [class*=' col'] {
      padding-right: floor($gutter-width / 2);
      padding-left: ceil($gutter-width / 2);
    }

    .row {
      margin-right: ceil($gutter-width / -2);
      margin-left: floor($gutter-width / -2);
    }
  }
}

@include responsive-gutter(xs, 16px);
@include responsive-gutter(sm, 20px);
@include responsive-gutter(md, 28px);

We're skipping on new grid gutters given our newly added negative margins. See #26825.


Coyote jump issue

It seems to me that the coyote jump is much larger than the normal jump. I did some testing for myself using print() and it comes out that line 58 for player.gd lets go of the condition and then continues to pass holding the key up.
Suggestion for change:
adding an additional variable for example coyote_jump_start. When you start timer - you set it to true. After line 58 you set it to false?
	if just_left_ledge:
		coyote_jump_timer.start()
		coyote_jump_start = false

	if is_on_floor() or (coyote_jump_timer.time_left > 0.0 and coyote_jump_start):
		if Input.is_action_pressed("jump"):
			velocity.y = movement_data.jump_velocity
			coyote_jump_start = false

I'm not good at godot. Maybe you know better methods.

Hey! thanks for bringing this up. I addressed this in the most recent commit (and future video).
Your solution works well. I ended up just calling stop() on the timer after executing a coyote jump for my solution.


Fix the length of generated OBC bucket name

To fix a bug where the length of the generated bucket name is larger than what is required

@umangachapagain  PTAL

/assign @umangachapagain


clang warnings

There are many warnings:
/usr/ports/math/universal/work/universal-7fb24e1058eccd17699d6147fefffd2a5468876c/./include/universal/posit/specializations.hpp:33:9: warning: unknown pragma ignored [-Wunknown-pragmas]
#pragma warning( disable : 4365 ) // warning C4365: 'initializing': conversion from 'long' to 'uint32_t', signed/unsigned mismatch
        ^
/usr/ports/math/universal/work/universal-7fb24e1058eccd17699d6147fefffd2a5468876c/./include/universal/posit/specializations.hpp:31:9: warning: unknown pragma ignored [-Wunknown-pragmas]
#pragma warning( disable : 4242 ) // warning C4242: 'argument': conversion from 'int32_t' to 'const int8_t', possible loss of data
        ^
/usr/ports/math/universal/work/universal-7fb24e1058eccd17699d6147fefffd2a5468876c/./include/universal/posit/specializations.hpp:45:9: warning: unknown pragma ignored [-Wunknown-pragmas]
#pragma warning( pop )
        ^

clang=9
FreeBSD 12.1

added compiler guards to filter these pragma statements for different compilers.


Use CSS to hide links that don't wrap images

It seems that sometimes the default display property for anchor elements can clash with flex stuff. I haven't quite nailed down the specifics. That said, setting anchor elements without dependents to display:none seems like the safer bet.
I will do this.

I think we aren't relying on display: none for anything other than the caption. Please re-open if I'm wrong.


Heartbeats

@Zerpet I put in a basic graceful close mechanism for the Heartbeat done channel. I might still be susceptible to a race condition. The test passes without panicking at least!
I'll make another test case to call the locator operation for sending a heartbeat shortly (to pass the failing static check)
I had tried to incorporate the gleak leak detector. I see you tried as well, but I couldnt not get it to fail? Let me know what you think about having a gleak test.

We have paused this work. Closing this PR. We have the branch in case we resume the effort in the future.


added tests to work with the new gate duration

The ioc side changes for https://github.com/PandABlocks/PandABlocks-client/issues/77

I'm not sure these changes are needed at all? The field GATE_DURATION (or SAMPLES) is not treated as special anywhere in this codebase, it is only the HDF scaling of the client that treats it as special...


User can't manage the lifecycle of THREAD_POOL in Azure Table Storage Java SDK

Discussed in https://github.com/Azure/azure-sdk-for-java/discussions/40107

Originally posted by luxianlong May 10, 2024
Hello Azure SDK Community,
I've been working with the Azure Table Storage Java SDK and encountered a scenario that I believe could benefit from a discussion and potential enhancement. Specifically, I'm referring to the management of the THREAD_POOL used in the TableClient and TableAsyncClient classes for handling asynchronous operations.
As it stands, the SDK initializes a static THREAD_POOL using Executors.newCachedThreadPool() and registers a JVM shutdown hook to clean up the thread pool. This approach generally works well for straightforward applications. However, it poses challenges in scenarios where the application has specific requirements for shutdown behavior or needs to manage the thread pool lifecycle more granitely.
For example, in my case, I need to perform certain operations against Azure Table Storage within my application's shutdown hook. The current implementation of the SDK's thread pool management doesn't easily allow for this, as the thread pool may be shut down before my shutdown logic executes.
I propose we discuss potential enhancements to the SDK that would give developers more control over the thread pool's lifecycle. Some ideas could include:

Providing a way to customize the ExecutorService: Allowing users to supply their own ExecutorService implementation could enable more sophisticated thread management strategies and integration with application-specific lifecycle management.
Exposing thread pool management operations: Adding methods to start, stop, or restart the thread pool could offer the necessary hooks for applications to manage the thread pool according to their lifecycle events.
Support for graceful shutdown: Enhancing the SDK to support graceful shutdown of the thread pool, with the ability to wait for active tasks to complete before shutting down, could be beneficial for ensuring data integrity and completeness of operations.

I'm interested in hearing the community's thoughts on this matter.
Thank you.

Thanks for posting this @luxianlong, I personally would prefer a case where the ExecutorService can be set externally as this is the most powerful mechanism and could integrate with existing threading logic used within an application. Since you posted this, would your expectation be that this ExecutorService would need to be set before running any SDK operations or could be set at any point during the lifetime of the application?

Hi, @alzimmermsft , from my personal perspective, I think the ExecutorService could be set at any point during the lifetime of the application. If you didn't set the ExecutorService, then the application will use the default one.

@luxianlong, with #41885 this should be doable now (as long as the downstream service SDK consumes SharedExecutorService rather than creating its own). There will be further work in this area in the future to push a provided ExecutorService rather than relying on ones we create.


Help: how do i change the scroll speed

What do you need help for ?
Please note that the documentation is still under construction.
i want to create a note that when hit changes the scroll speed of the whole chart to be more faster

i guess you could just script that to change the scroll speed at a certain time

PlayState.SONG.speed = scrollSpeed;

or if you want to set it for a specific strum
getStrum(id).scrollSpeed = scrollSpeed;

Not this way, i wanted to do it like whenever this note is hit it changes
the scroll speed by 0.5
Em ter, 19 de jul de 2022 17:48, YoshiCrafter29 @.***>
escreveu:

PlayState.SONG.speed = scrollSpeed;
or if you want to set it for a specific strum
getStrum(id).scrollSpeed = scrollSpeed;
—
Reply to this email directly, view it on GitHub
https://github.com/YoshiCrafter29/YoshiCrafterEngine/issues/258#issuecomment-1189536178,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYFVJYF4ICIDEF4NPZW5SPTVU4ICNANCNFSM53SUGPCA
.
You are receiving this because you authored the thread.Message ID:
@.***>


404 page not found

404 page not found
for both docs and api use

@arijit4 api is not hosted that's why you are facing that issue will update the link soon


Performance Meshing

Experiment with running meshing on down-sample segmentations.
Specially useful when doing human intervention to show meshes faster to the users.

This is already done.

https://github.com/seung-lab/neuroglancer/pull/159

it was fixed. close here?

oh, it was not merged yet.


Firefox addon?

Would you make it available on Firefox too?

Would you make it available on Firefox too?

Hello Iriman, sorry for the late response. Currently there are no plans for further development.
I would be more than happy if someone wants to contribute on this. Feel free to do so ;)
Thanks!


How does Optimize decide the File Size (Question)

Hi,
I used to use my own auto compaction method on a legacy system.
How it basically works is that it calculates the sum of file size for every hive partition, and consolidate the files in every partition.
Example:
for a partition, there are 1000 thousand files which are around 1 MB.
Sum is 1 GB and the method divides the sum to 128 MB and ceil it , which is 8 in our case. it makes repartition it to 8.
after compaction, new total size is much less than 1 GB, it might be 700 MB.
So ı needed to recursively run the function, till it reach the proper size. (generally two or three times.)
My question is that, How delta optimize deals with this issue ?
Thank you.

Optimize targets 1GB for the target files
Delta Lake targets 1 GB files when OPTIMIZE is run. This can be configure this property by setting the spark.databricks.delta.optimize.maxFileSize property.
Delta Optimize uses bin packing for compacting the files. In simple words

filter all files for only files < maxFileSize (default 1GB)
sequentially add them to "bins" until the bin is ~1GB
everytime you overflow a bin it starts a new bin
this happens per partition

Referrence : https://delta.io/blog/2023-01-25-delta-lake-small-file-compaction-optimize/


nanopolish eventalign taking to much time to finish...

in my case i ran the nanopolish eventalign, but it is taking to much time to finish...and
So, i had to chunk the original fastq into 10 parts (Will merge the eventalign.txt later for subsequent analysis)
then i had to reindex for each part.fastq.
but then the eventalign is not working, giving warning of skipping several fast5's.
i can see the issue can be with indexing,
the readdb file i can see is still containing as much number of rows (~reads) as in original undivided fastq.
is there anyway i can pull of the eventalign commands with these 10 parts and merge together eventalign.txt for further analysis with xpore?

You should partition the bam file into smaller chunks, not the fastq.


Windows Builds for Opencv.org binaries

I'm trying to build using the binaries provided by opencv.org but I'm having trouble linking apparently:
=== Setting up OpenCV library from environment, pkg_name: opencv4, link_libs: opencv_world420, link_paths: c:\OpenCV\x64\vc15\lib\, include_paths: C:\OpenCV\include      === OpenCV library configuration: Library {
    pkg_name: "opencv4",
    libs: [
        "opencv_world420.lib",
    ],
    link_paths: [
        "c:\\OpenCV\\x64\\vc15\\lib\\",
    ],
    framework_paths: [],
    include_paths: [
        "C:\\OpenCV\\include",
    ],
    version: "4.2.0",
    prefix: "",
    libdir: "c:\\OpenCV\\x64\\vc15\\lib\\",
    cargo_metadata: [
        "cargo:rustc-link-lib=opencv_world420",
        "cargo:rustc-link-search=native=c:\\OpenCV\\x64\\vc15\\lib\\",
    ],
}
=== Found OpenCV library version: 4.2.0 in headers located at: C:\Users\phote\.cargo\registry\src\github.com-1ecc6299db9ec823\opencv-0.31.0\headers/4

Why isn't it using the headers in the path I've specified?
I've attached the detailed build output.
opencv_build_output.txt

For building on windows please always use buildtime-bindgen feature (requires libclang from llvm choco/vcpkg package)

🤦♂ Thanks.

The directory you're seeing specifically is controlled by OPENCV_HEADER_DIR env var, it's due to somewhat unnecessarily complicated separation between headers for binding generation and headers for building. I plan to simplify it in the future.

Just as an afterthought, I'm using scoop and the official opencv binaries. I'd be happy to submit a PR to the readme with information for anyone else using Windows who does not want to endure the vcpkg build time of opencv and llvm.

Please do!


Rcint 3799

Coverage decreased (-0.03%) to 1.088% when pulling dfcef4e152a052dc730acab1b3bc2fbcfac663c3 on u9520107:rcint-3799 into 176fef6b20833611620085b4d6770b3b7b8fd975 on ringcentral:master.

@u9520107  If user don't have sms permission, should click to sms button be disabled?

right... permissions. Let me think over this.

Coverage decreased (-0.02%) to 1.103% when pulling 0b515420c7bbf1dfbee84b255459a216bbb8a64c on u9520107:rcint-3799 into 176fef6b20833611620085b4d6770b3b7b8fd975 on ringcentral:master.


Tybalt's Feature Request [692882904354783322]

Tybalt at 3/26/2020 11:49:17 PM +00:00

Way to disable cutting of characters from the string that would be "out of bounds" of a TextBox control. (Either show "..." or nothing at all, but do not cut from the string.

REF: https://discordapp.com/channels/531175899588984842/534490472224391169/692882904354783322

This is solved with the new textbox implementation, correct?


probleme with the constructor of NotificationClient.cs and the http client used / configured

there is no constructor for NotificationClient.cs that accept an IHttpClient if the baseUrl is not the default one, DI cannot be properly used there
which cause another issue, the HttpClientWrapper.cs doesnt follow proper Guidelines for using HttpClient
which can cause a wide variety of issues and also it is not possible to implement a proper retry pattern

Hi, if you're able to open a PR with an additional constructor to fix this that would be great. Otherwise it may be a few days before we are able to lend some developer time to a fix.


Better typed errors in fedimint-client.

We have too many errors in fedimint-client that just surface a string and not a type which the caller interpret more easily

maybe switch of error-stack^1, because it will force us to have strongly typed errors

example:
https://github.com/fedimint/fedimint/blob/01973bb4d4f4e31edc0efa04ba83742bbb86348d/modules/fedimint-ln-client/src/lib.rs#L1103-L1105
this should be typed error that caller can match on

we should avoid return string errors, use context where possible
example https://github.com/fedimint/fedimint/pull/4603

ref https://github.com/fedimint/fedimint/pull/5236

Motion to remove anyhow as a dependency


Add Directory features to Mock interface

[x] Create directory

[x] Remove Directory

[x] Add file to Directory

is there a mini documentation you could write as to how the directory system works?

See types/wasa/index.d.ts it's just comments but if that still doesn't make sense let me know.


IGAPP-333: Documentation

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

Build configs will be merged and moved in https://issues.tuerantuer.org/browse/IGAPP-271.

I am quite unsure as to what belongs in the common documentation and what belongs just in the separate projects. If you think anything is wrong in this concern, let me know! (@Taggotty ping because you already reviewed)


[Bug]:  name LB changed to k3s

Description
When you set custom cluster name like:
cluster_name = "h-asset-test"
and aftr creation you make some changes and play terraform apply
LB renamed to k3s.
Kube.tf file
locals {
TF_VAR_hcloud_token env

  hcloud_token = ""
}

module "kube-hetzner" {
  providers = {
    hcloud = hcloud
  }
  hcloud_token = var.hcloud_token != "" ? var.hcloud_token : local.hcloud_token

  network_region = "eu-central" # change to `us-east` if location is ash

  control_plane_nodepools = [
    {
      name        = "control-plane-fsn1",
      server_type = "cpx11",
      location    = "fsn1",
      labels      = [],
      taints      = [],
      count       = 1

      # Enable automatic backups via Hetzner (default: false)
      # backups = true
    },
    {
      name        = "control-plane-nbg1",
      server_type = "cpx11",
      location    = "nbg1",
      labels      = [],
      taints      = [],
      count       = 1

      # Enable automatic backups via Hetzner (default: false)
      # backups = true
    }
  ]

  agent_nodepools = [
    {
      name        = "agent-small",
      server_type = "cpx11",
      location    = "fsn1",
      labels      = [],
      taints      = [],
      count       = 2

      # Enable automatic backups via Hetzner (default: false)
      # backups = true
    },
    {
      name        = "agent-large",
      server_type = "cpx21",
      location    = "nbg1",
      labels      = [],
      taints      = [],
      count       = 0

      # Enable automatic backups via Hetzner (default: false)
      # backups = true
    },
    {
      name        = "storage",
      server_type = "cpx21",
      location    = "fsn1",
      # Fully optional, just a demo.
      labels      = [
        "node.kubernetes.io/server-usage=storage"
      ],
      taints      = [],
      count       = 1

    },

    {
      name        = "egress",
      server_type = "cpx11",
      location    = "fsn1",
      labels = [
        "node.kubernetes.io/role=egress"
      ],
      taints = [
        "node.kubernetes.io/role=egress:NoSchedule"
      ],
      floating_ip = true
      count = 0
    },
    # Arm based nodes, currently available only in FSN location
    {
      name        = "agent-arm-small",
      server_type = "cax11",
      location    = "fsn1",
      labels      = [],
      taints      = [],
      count       = 0
    }
  ]

   ingress_controller = "traefik"
   traefik_additional_options = ["--log.level=DEBUG"]

  initial_k3s_channel = "stable"

  cluster_name = "h-asset-test"

  k3s_registries = <<-EOT
    mirrors:
      eu.gcr.io:
        endpoint:
          - "https://eu.gcr.io"
    configs:
      eu.gcr.io:
        auth:
          username: _json_key
          password: ...
  EOT

plugins=PodTolerationRestriction,PodNodeSelector"

  traefik_values = <<EOT
deployment:
  replicas: 1
globalArguments: []
service:
  enabled: true
  type: LoadBalancer
  annotations:
    "load-balancer.hetzner.cloud/name": "k3s"
    "load-balancer.hetzner.cloud/use-private-ip": "true"
    "load-balancer.hetzner.cloud/disable-private-ingress": "true"
    "load-balancer.hetzner.cloud/location": "nbg1"
    "load-balancer.hetzner.cloud/type": "lb11"
    "load-balancer.hetzner.cloud/uses-proxyprotocol": "true"

ports:
  web:
    redirectTo: websecure

    proxyProtocol:
      trustedIPs:
        - <IP_ADDRESS>/32
        - <IP_ADDRESS>/8
    forwardedHeaders:
      trustedIPs:
        - <IP_ADDRESS>/32
        - <IP_ADDRESS>/8
  websecure:
    proxyProtocol:
      trustedIPs:
        - <IP_ADDRESS>/32
        - <IP_ADDRESS>/8
    forwardedHeaders:
      trustedIPs:
        - <IP_ADDRESS>/32
        - <IP_ADDRESS>/8

tlsOptions: {}
tlsStore: {}

certResolvers:
  letsencrypt:
    email<EMAIL_ADDRESS>    tlsChallenge: true
    httpChallenge:
      entryPoint: "web"
    storage: /data/acme.json

  EOT

controller:
  watchIngressWithoutClass: "true"
  kind: "DaemonSet"
  config:
    "use-forwarded-headers": "true"
    "compute-full-forwarded-for": "true"
    "use-proxy-protocol": "true"
  service:
    annotations:
      "load-balancer.hetzner.cloud/name": "k3s"
      "load-balancer.hetzner.cloud/use-private-ip": "true"
      "load-balancer.hetzner.cloud/disable-private-ingress": "true"
      "load-balancer.hetzner.cloud/location": "nbg1"
      "load-balancer.hetzner.cloud/type": "lb11"
      "load-balancer.hetzner.cloud/uses-proxyprotocol": "true"
  EOT */

ingress:
  tls:
    source: "rancher"
hostname: "rancher.example.com"
replicas: 1
bootstrapPassword: "supermario"
  EOT */

}

provider "hcloud" {
  token = var.hcloud_token != "" ? var.hcloud_token : local.hcloud_token
}

terraform {
  required_version = ">= 1.3.3"
  required_providers {
    hcloud = {
      source  = "hetznercloud/hcloud"
      version = ">= 1.39.0"
    }
  }
}

output "kubeconfig" {
  value     = module.kube-hetzner.kubeconfig
  sensitive = true
}

variable "hcloud_token" {
  sensitive = true
  default   = ""
}

Screenshots
No response
Platform
Mac

@dogonovm You posted this issue with your google json access key for the gcr reg, I just edited the post to remove it, but you might have been exposed, probably a good idea to regerate it.

@dogonovm About the LB issue, normally it's default name is k3s, so if you remove the cluster_name it takes the name of k3s. Also you have form extra indentation, maybe that is causing it too, though unlikely.

If that does not make sense, we would need to know which value you changed and then applied, that reverted the name of the LB to its default value.

May be need also change this settings?
  traefik_values = <<EOT
deployment:
  replicas: 1
globalArguments: []
service:
  enabled: true
  type: LoadBalancer
  annotations:
    "load-balancer.hetzner.cloud/name": "**k3s**"

I mean change in line:     "load-balancer.hetzner.cloud/name": "k3s"
same as cluster name.

@dogonovm Yes, that's the reason, I missed it, that replaces the variable. Change this and you should be good to go!


FileNotFoundError

I am trying to run the inference section in colab notebook, but when I try to test other images it gives this error .

even though the file is present.

Hi, make sure you specify the paths correctly.

Hi, make sure you specify the paths correctly.


Cutting a new release?

Is it possible to ship a new release that includes fixes from #205?
Thanks @poteto!

👍

@poteto I cut 1.3.17 and published to github if you can publish to NPM

Done, thanks! @Dhaulagiri Let me know your npm username and I can add you there as well so you have release rights.

Thanks @poteto! 🎉

Also thanks @Dhaulagiri 🎈


Could you please label ECCV2020 to our paper.

Hi. Thank you for your great efforts to maintain such an unbelievable exhaustive list for domain adaptation research.
Our paper, "Partially-Shared Variational Auto-encoders for Unsupervised Domain Adaptation with Target Shift", is currently listed as an arXiv paper, but it appeared in ECCV2020.
https://www.ecva.net/papers/eccv_2020/papers_ECCV/html/2472_ECCV_2020_paper.php
We are really happy if you could update the list.
Thank you very much again.

I forgot to provide the link to code.
https://github.com/iiyama-lab/PS-VAEs
Thank you very much for your attention.

OK! Your work is very interesting and impreesive!


Initial spike

🚧 Initial spike for discussion only
Starting point is the handler_plugin.go
Disclaimer
A lot of code comes directly or is inspired by the following projects:

https://github.com/CosmWasm/wasmd/
https://github.com/osmosis-labs/osmosis
https://github.com/osmosis-labs/cosmos-sdk

Credits go to the original authors

Main is already ahead of the initial spike. No need to keep this open


Move completion.sh to tools - #167

Moved completion.sh to tools

Just one last small thing -
Also, please update the "link" here to the new location:
https://github.com/google/startup-os/blob/master/commands.txt#L41
Thanks! :-)

Thanks a lot! Merging now :)

Pleasure :)


Python memory leaks on exit with outstanding calls

When python exits with outstanding calls, a hanging reference at the Cython level prevents proper cleanup, leading to a memory leak warning.
D0628 16:18:07.661735081   10465 iomgr.c:99]                 Waiting for 3 iomgr objects to be destroyed
D0628 16:18:08.663269688   10465 iomgr.c:99]                 Waiting for 3 iomgr objects to be destroyed
D0628 16:18:09.664535323   10465 iomgr.c:99]                 Waiting for 3 iomgr objects to be destroyed
D0628 16:18:10.665863923   10465 iomgr.c:99]                 Waiting for 3 iomgr objects to be destroyed
D0628 16:18:11.667386620   10465 iomgr.c:99]                 Waiting for 3 iomgr objects to be destroyed
D0628 16:18:12.668871835   10465 iomgr.c:99]                 Waiting for 3 iomgr objects to be destroyed
D0628 16:18:13.670009823   10465 iomgr.c:99]                 Waiting for 3 iomgr objects to be destroyed
D0628 16:18:14.671078765   10465 iomgr.c:99]                 Waiting for 3 iomgr objects to be destroyed
D0628 16:18:15.672284821   10465 iomgr.c:99]                 Waiting for 3 iomgr objects to be destroyed
D0628 16:18:16.673620721   10465 iomgr.c:118]                Failed to free 3 iomgr objects before shutdown deadline: memory leaks are likely
D0628 16:18:16.673701411   10465 iomgr.c:80]                 LEAKED OBJECT: tcp-client:ipv4:<IP_ADDRESS>:443 fd=6 0x7fea300045a8
D0628 16:18:16.673723755   10465 iomgr.c:80]                 LEAKED OBJECT: tcp-client:ipv4:<IP_ADDRESS>:443 fd=12 0x7fea30005168
D0628 16:18:16.673746282   10465 iomgr.c:80]                 LEAKED OBJECT: tcp-client:ipv4:<IP_ADDRESS>:443 fd=23 0x7fea30006888
D0628 16:18:16.673830891   10465 metadata.c:238]             WARNING: 1 metadata elements were leaked
D0628 16:18:16.673872448   10465 metadata.c:238]             WARNING: 3 metadata elements were leaked
D0628 16:18:16.673903482   10465 metadata.c:238]             WARNING: 2 metadata elements were leaked
D0628 16:18:16.673927907   10465 metadata.c:238]             WARNING: 2 metadata elements were leaked
D0628 16:18:16.673955019   10465 metadata.c:238]             WARNING: 1 metadata elements were leaked
D0628 16:18:16.673982805   10465 metadata.c:238]             WARNING: 9 metadata elements were leaked
D0628 16:18:16.674006559   10465 metadata.c:238]             WARNING: 3 metadata elements were leaked
D0628 16:18:16.674031913   10465 metadata.c:238]             WARNING: 3 metadata elements were leaked
D0628 16:18:16.674055336   10465 metadata.c:238]             WARNING: 2 metadata elements were leaked
D0628 16:18:16.674124369   10465 metadata.c:238]             WARNING: 2 metadata elements were leaked
D0628 16:18:16.674160625   10465 metadata.c:238]             WARNING: 2 metadata elements were leaked
D0628 16:18:16.674188014   10465 metadata.c:238]             WARNING: 3 metadata elements were leaked
D0628 16:18:16.674212776   10465 metadata.c:238]             WARNING: 2 metadata elements were leaked
D0628 16:18:16.674313468   10465 metadata.c:238]             WARNING: 7 metadata elements were leaked
D0628 16:18:16.674342804   10465 metadata.c:238]             WARNING: 4 metadata elements were leaked
D0628 16:18:16.674363545   10465 metadata.c:238]             WARNING: 2 metadata elements were leaked
D0628 16:18:16.674384519   10465 metadata.c:251]             WARNING: 2 metadata strings were leaked
D0628 16:18:16.674404965   10465 metadata.c:255]             LEAKED: Tue, 28 Jun 2016 20:17:40 GMT
D0628 16:18:16.674425889   10465 metadata.c:255]             LEAKED: 3
D0628 16:18:16.674449029   10465 metadata.c:251]             WARNING: 1 metadata strings were leaked
D0628 16:18:16.674470734   10465 metadata.c:255]             LEAKED: 443:quic
D0628 16:18:16.674491956   10465 metadata.c:251]             WARNING: 2 metadata strings were leaked
D0628 16:18:16.674518349   10465 metadata.c:255]             LEAKED: Tue, 28 Jun 2016 20:18:05 GMT
D0628 16:18:16.674541054   10465 metadata.c:255]             LEAKED: quic=":443"; ma=2592000; v="34,33,32,31,30,29,28,27,26,25"
D0628 16:18:16.674566538   10465 metadata.c:251]             WARNING: 5 metadata strings were leaked
D0628 16:18:16.674587736   10465 metadata.c:255]             LEAKED: Tue, 28 Jun 2016 20:17:55 GMT
D0628 16:18:16.674609252   10465 metadata.c:255]             LEAKED: /google.logging.v2.ConfigServiceV2/CreateSink
D0628 16:18:16.674633129   10465 metadata.c:255]             LEAKED: x-goog-api-client
D0628 16:18:16.674654447   10465 metadata.c:255]             LEAKED: Tue, 28 Jun 2016 20:17:35 GMT
D0628 16:18:16.674677346   10465 metadata.c:255]             LEAKED: Tue, 28 Jun 2016 20:17:29 GMT
D0628 16:18:16.674699780   10465 metadata.c:251]             WARNING: 1 metadata strings were leaked
D0628 16:18:16.674719762   10465 metadata.c:255]             LEAKED: Requested entity was not found.

Sorry, I mispoke.  It is a hanging reference.  When we put an operation on the wire, we manually call Py_INCREF() on the operation tag which holds a reference to the call.  The call never gets cancelled when it goes out of context, and so we never retrieve the operation tag on the other side of the completion queue.

I think I'm still not understanding "When python exits with outstanding calls" - doesn't the use of a cleanup thread inside the channel mean that calls will be cancelled when that thread is joined?
Are we seeing this leak-on-exit in the output of our unit tests? If so, which ones? If not, what would a unit test to exercise this defect look like? Or a sample user story, if a unit test would be too weird?
How certain are we that leak-on-exit-and-spew-some-logging is a GA blocker? To me it sounds like a minor annoyance that would be merely nice to fix.

Yes, the _exit_tests.py show this behavior.
gcloud + gax feels like a tier 1 use case to me.  I'm amenable to pushing this off the GA milestone if you disagree.

I'm still not understanding the defect itself - why doesn't the call get cancelled? It's a managed call, so why doesn't the cleanup thread cancel it? You mention a Py_INCREF on the operation tag and the tag holding a reference to the call, but why isn't there a corresponding Py_DECREF on that same tag? What's happening that the completion queue isn't getting drained at exit? Or is it, but somehow the tags that come out of it aren't getting Py_DECREFed as they should be?

Sorry, to clarify this is for synchronous calls.

Synchronous response-unary calls?

Yes.

... and what's the interpreter exit mechanism? Ctrl-C at the keyboard, or a signal, or something the application initiates?

Ctrl-C at the keyboard.  In the tests it is simulated as a SIGINT sent to the process, but the intent is for Ctrl-C interpreter exit.  I haven't tested calling sys.exit(0) from another thread, but I imagine it would have a similar effect.

I'm just not making the connections I need to make. I'm not getting "the operation tag which holds a reference to the call", because for synchronous (blocking) response-unary calls we use None as the tag (right?). None certainly doesn't hold a reference to the call, right?

The operation tag reference is done at the Cython layer:
https://github.com/grpc/grpc/blob/master/src/python/grpcio/grpc/_cython/_cygrpc/call.pyx.pxi#L46

This issue could probably be solved by removing only the Cython reference, and leaving our reference to managed calls to be cleaned up by the CleanupThread.
I'd like to move in the direction of less state tracking because of possible performance gains, but I'd be fine with making a minimal change to fix the issue pre-GA and revisiting un-needed state tracking post-GA

I'd originally added in the tag-as-GC-root thing to attempt to ensure memory safety whether or not things went wrong in the Python layers (attempting to ensure no use-after frees from Python). That said, I can't immediately come up with a situation where removing that reference could threaten that, so, I think I'm (tentatively) fine with that reference going away.

Although... regardless of that reference being there (or not), I'm feeling like a more proper solution would be pumping all queues on exit...

AFAICT, its only safe to pump a queue after shutting down (so you know when to stop), and that should only be done on completion queue destruction.  The issue there is that calls have references to their completion queues:
https://github.com/grpc/grpc/blob/master/src/python/grpcio/grpc/_cython/_cygrpc/channel.pyx.pxi#L69
I actually played around with removing that reference to do what you are suggesting https://github.com/grpc/grpc/pull/7122
As it turns out, it is possible for the completion queue to go out of scope before the calls, and if that happens, nothing cancels the calls, and then the completion queue hangs trying to shut down, so I abandoned that idea.

As I read and reread this issue, I get the sense that the invariant that's being violated is "calls that have operations started on them either get those operations finished or get cancelled", and that it's being violated just in the blocking sections of _channel.py, and that an appropriate fix would be to wrap the blocking synchronous RPC invocation code in a try/finally that cancels the call in the finally. Would that not be a small fix to make? Would it remedy this issue? Would it also remedy #7090?

I don't believe that will work.  We still need to get the call off the completion queue by calling grpc_completion_queue_next()  This completion queues get pumped as part of their destruction, but outstanding calls hold references to the completion queues.  We might be able to make this work, but it would end up being a larger change than what is proposed.
As far as  #7090, the issue is much harder to address.  #7090 is a result of a cancellation before connection.  An AVL tree is set up with "possible" connections, and gets destroyed when one of the connections is actually used.  When grpc_shutdown() attempts to free the AVL tree, it needs a valid "ext_ctx" to do so, but no such context is available during final cleanup.  Ensuring the cancelled call gets destroyed  seems to fix the issue, and I've verified that grpc_call_destroy() never gets called when the error occurs.

@tseaver
#7275 should have resolved the client side leaks with outstanding calls.  Could you verify that gcloud + gax no longer has this leak on the master branch?

@kpayson64 I'd be glad to try it.  Given that the repository is not Python-only, can you suggest a pip command-line that would install from the master?

@tseaver
From the repo root you could try:
python setup.py install
If that doesn't work you could try,
python setup.py sdist
pip install dist/grpcio-0.16.0.dev0.tar.gz

Quick note:
GRPC_PYTHON_BUILD_WITH_CYTHON=1 needs to be set and you must have Cython installed if you're going from a fresh repository check-out., e.g.:
GRPC_PYTHON_BUILD_WITH_CYTHON=1 pip install .

I've verified that this is fixed with the helloworld example.

Has this change been released? If not, is there an ETA? I'd also prefer to use pip and whatnot.


Add reverse for vectors.

Submisison Checklist

[ ] Run unit tests: ./runTests.py test/unit
[ ] Run cpplint: make cpplint
[ ] Declare copyright holder and open-source license: see below

Summary:
Just a quick resolution of https://github.com/stan-dev/math/issues/344 adding a reverse utility for std::vectors. Like our sort functions, it mutates its argument. We ok with that?
Intended Effect:
Add a missing minor feature.
How to Verify:
Code is short and there's a unit test.
Side Effects:
None, adds a function.
Documentation:
doxygen
Reviewer Suggestions:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

Three things:

It needs to be a constant reference, which is how arguments are passed in from the Stan language.  So it needs a copy.

It also needs tests for reverse, forward, and mixed modes.  That'll just test that the appropriate comparisons are defined for std::reverse to apply to the iterators.

It should be implemented for row vectors and column vector types, too.  If you take an ordered vector, it's an Eigen vector, and that's the kind of thing we'll have users reversing.

@bob-carpenter I hopefully fixed the const issue and am proceeding to the rest, I'm curious whether there are any good examples of of functions from vector to vector already in the language? I'm looking at fun/sum (in prim, rev, fwd), the autodiff paper, and a few other places but if there's an idiom it'd be nice to match
Also: I'm intending to put a little bit of noise on this pull request. Is there a nice way to avoid triggering CI builds on intermediate pushes?

In your commit, you should be able to include "[skip ci]", but I don't know how well that actually works as documented.
Both only build on push, so you can prevent constant builds if you push when it's actually ready to test.
Although, you really shouldn't worry about the builds that are fired off. Most of the time we're idle.

On Jan 26, 2017, at 6:10 PM, thelseraphim<EMAIL_ADDRESS>wrote:
@bob-carpenter I hopefully fixed the const issue and am proceeding to the rest, I'm curious whether there are any good examples of of functions from vector to vector already in the language? I'm looking at fun/sum (in prim, rev, fwd), the autodiff paper, and a few other places but if there's an idiom it'd be nice to match
Also: I'm intending to put a little bit of noise on this pull request. Is there a nice way to avoid triggering CI builds on intermediate pushes?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[ci skip] in a commit message has always worked as advertised for me. It
definitely comes in handy.
On Thu, Jan 26, 2017 at 11:05 PM Daniel Lee<EMAIL_ADDRESS>wrote:

In your commit, you should be able to include "[skip ci]", but I don't
know how well that actually works as documented.
Both only build on push, so you can prevent constant builds if you push
when it's actually ready to test.
Although, you really shouldn't worry about the builds that are fired off.
Most of the time we're idle.

On Jan 26, 2017, at 6:10 PM, thelseraphim<EMAIL_ADDRESS>wrote:

@bob-carpenter I hopefully fixed the const issue and am proceeding to
the rest, I'm curious whether there are any good examples of of functions
from vector to vector already in the language? I'm looking at fun/sum (in
prim, rev, fwd), the autodiff paper, and a few other places but if there's
an idiom it'd be nice to match

Also: I'm intending to put a little bit of noise on this pull request.
Is there a nice way to avoid triggering CI builds on intermediate pushes?

—

You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/479#issuecomment-275584652, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHb4Q2MJ5709ZIiKziA7rNFNWjst0M0pks5rWWzxgaJpZM4Ls-lr
.

I've just been killing off the builds that I know I've triggered if I have updates to the PR that makes running those tests obsolete.

You also don't need to create a pull request until it's
ready to go.  We can review branches until then.  But
sometimes it's easier with pull requests.

Bob

On Jan 26, 2017, at 11:05 PM, Daniel Lee<EMAIL_ADDRESS>wrote:
In your commit, you should be able to include "[skip ci]", but I don't know how well that actually works as documented.
Both only build on push, so you can prevent constant builds if you push when it's actually ready to test.
Although, you really shouldn't worry about the builds that are fired off. Most of the time we're idle.

On Jan 26, 2017, at 6:10 PM, thelseraphim<EMAIL_ADDRESS>wrote:
@bob-carpenter I hopefully fixed the const issue and am proceeding to the rest, I'm curious whether there are any good examples of of functions from vector to vector already in the language? I'm looking at fun/sum (in prim, rev, fwd), the autodiff paper, and a few other places but if there's an idiom it'd be nice to match
Also: I'm intending to put a little bit of noise on this pull request. Is there a nice way to avoid triggering CI builds on intermediate pushes?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

You can find the signatures in the math library functions
in the index of the manual.  So you're looking for something
that returns real[] or vector and takes a real[] or vector
argument.  For example, cumulative_sum.  But cumulative_sum
doesn't have specialized derivatives, so you're better off
looking at stan/math/rev/mat/fun/softmax.hpp
Also, we have an array allocator in memalloc_ that should've
been used in softmax.  You could replace that, too
vari** alpha_vi_array
    = reinterpret_cast<vari**>(ChainableStack::memalloc_
                               .alloc(sizeof(vari*) * alpha.size()));

should be
  vari** alpha_vi_array
    = ChainableStack::memalloc_.alloc_array<vari*>(alpha.size());

At least I think I have my types in a row here.  The memaalloc_ object
with alloc_array method is defined in stan/math/memory/stack_alloc.hpp.

Bob

On Jan 26, 2017, at 6:10 PM, thelseraphim<EMAIL_ADDRESS>wrote:
@bob-carpenter I hopefully fixed the const issue and am proceeding to the rest, I'm curious whether there are any good examples of of functions from vector to vector already in the language? I'm looking at fun/sum (in prim, rev, fwd), the autodiff paper, and a few other places but if there's an idiom it'd be nice to match
Also: I'm intending to put a little bit of noise on this pull request. Is there a nice way to avoid triggering CI builds on intermediate pushes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

jenkins, retest this please

I shouldn't have just kicked off retesting.  Looks like the reverse file isn't including the header for std::begin and std::end.

@bob-carpenter it wasn't using it because I shouldn't have had it there. pushing a micro-change this time just to see the [ci skip] in action

Was this all ready for final review?

@thelseraphim  Would you mind adding the autodiff tests for this?  Just one for fwd, one for rev, and one for rev nested in fwd (three test files in rev, fwd, and mix directories).

@thelseraphim mind finishing out this pull request?


add shader deletion

works like a charm.

Profile pages don't list any shaders when you aren't logged in:

This is privacy :D

Probably not the best solution for hiding 'unlisted' shaders also 3 rerenderers.
But we need to check user and id for sure, maybe better to fix rerenderers for editor itself first.

Maybe better to fix 'unlisted' in another PR. It's not so easy.

@davidar do you have any other issues with this PR?

Sorry, haven't had a chance to review it properly yet, will try to do that soon. Could you fix the merge conflict?


⚠ Jenkins Plugins Artifactory has degraded performance

In b3340b5, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1315 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 6a8f29d after 12 minutes.


Fixes #3

class-test2 seems broken to me, see https://github.com/reactjs/react-codemod/blob/master/test/tests/transform-tests.js#L57 which should not add the super class. Seems like something is wrong in class.js that I probably broke at some point. You mind removing those changes? I can look into them soon-ish.

While we don't completely require that you extend React.Component yet, we're going to. So I think that's right.

Right, so in that case we should remove the option to not extend React.Component from class.js and also remove this test?

Ah gotcha, didn't realize it was an option, just thought we changed code without updating the test. I'll remove those changes.


Remove: Anydo.Anydo version 5.0.14

Reason for removal
Hash mismatch; New version added in #91915

Microsoft Reviewers: Open in CodeFlow

wingetbot just woke up to auto-delete #92028


Hash long filenames

This is a restructured implementation of @holzman PR #15

Following @gordonwatts  suggestion to fix https://github.com/ssl-hep/ServiceX/issues/303, this PR replaces long filenames (where their full path would exceed MAX_PATH_LEN=255), with a truncated name with a hash appended.

Nice - thanks!!


Update 4 distributions latest version.

Fedora: https://fedoramagazine.org/fedora-26-is-here/
Mint: https://www.linuxmint.com/download.php
Mageia: http://www.mageia.org/en/downloads/
OpenSuse: https://en.opensuse.org/Portal:42.3

Thanks! I should probably make a bot to do this.


Update Post “README”

Automatically generated by Netlify CMS

👷 Deploy Preview for hotplate-docs processing.

Name
Link

🔨 Latest commit
96d33ab3ce327b562e8e3a94a22990374948eca8

🔍 Latest deploy log
https://app.netlify.com/sites/hotplate-docs/deploys/62bcf02ecb0c120008c4b6b3


Go To Definition for 'new someClass()'  goes to import not class definition

TypeScript Version:  2.0.3 (ts server via vscode 1.7.1)
import Menu = require('src/components/menu/Menu');
...
this.menu = new Menu()

Originally logged here (item 2) many moons ago: https://typescript.codeplex.com/workitem/2120
Expected behavior:
go to definition takes you to the class definition or constructor.
Actual behavior:
go to definition takes you to the import statement.

Menu is rely a local import. if you rename it, you would rename the use site, and the import site and not the class declaration in src/components/menu/Menu.
hitting F12 on Menu in import Menu = require('src/components/menu/Menu'); should get you to the file.

I get why it's doing it, but it's an inconvenience to navigate three times: first to the import, then to the class, then scroll to the constructor.
If I hover over the "new Menu" it gives me info about the (alias) constructor not the local import. Ctrl-hover shows both the alias and the import. Maybe this is more of a vscode request, but at the moment it's neither convenient nor consistent :(

It used to go to the class itself and then people complained that they couldn't quickly go to the import for the sake of renaming it. :shrug emoji:

I guess you can't satisfy everyone. I'd argue that there is an easy way to rename via F2/rename symbol without the need to go to the import. By going to the constructor wouldn't that satisfy both sides?


eclipse configuration file to IDEA configuration export function

Can you provide formatted configuration files directly exported to IDEA? Or directly export and overwrite IDEA format configuration.
Because, sometimes I want to modify the configuration, I still have to go to eclipse to operate it, and then export the configuration to IDEA, which is too troublesome

yes

Actually, I am not sure what you mean.
I can provide build-in eclipse profiles and even read workspace config eclipse-workspace\.metadata\.plugins\org.eclipse.core.runtime\.settings\org.eclipse.jdt.ui.prefs, so you don't have to export it or use project specific profile.
Then I could export them to a properties or xml files - but why would you edit them manually?
By overwrite IDEA format configuration I hope you don't mean this?

Actually, I am not sure what you mean.
I can provide build-in eclipse profiles and even read workspace config eclipse-workspace\.metadata\.plugins\org.eclipse.core.runtime\.settings\org.eclipse.jdt.ui.prefs, so you don't have to export it or use project specific profile.
Then I could export them to a properties or xml files - but why would you edit them manually?
By overwrite IDEA format configuration I hope you don't mean this?

The purpose of using this plug-in is to switch from eclipse to IDEA, and it is expected to use eclipse configuration, but IDEA itself has some personalized configuration. after using this plug-in, the personalized configuration of IDEA itself will not take effect, and if it can be exported to IDEA configuration, you can not use eclipse configuration

@tonycody I think you misunderstood how this plugin works and what the aim is:

it's purpose is to align developers on the same project using both Eclipse and IDEA. The developers using IDEA agree to disable IDEA's formatting in favor of Eclipse
There is no way to edit Eclipse formatter settings from within IDEA. Eclipse supports per-module formatting and the formatting is not compatible on settings level (there are settings Eclipse does not support and there settings IDEA does not support or implements differently)
If you want to use only IDEA and switched from Eclipse, then feel free to import Code formatter settings directly from Eclipse formatter Xml file and use IDEA without this plugin.
This plugin internally use eclipse.jar, it delegates formatting to Eclipse, nothing more. The files must be present in structure Eclipse would expect