Add validation on team name uniqueness

Actual: I can create teams with the same name if I have different players there.

Expected: Team name should be unique in the scope of all games, so when you see the team's name in the "Select team" dropdown you'd know what players are there.
Acceptance criteria:

If the team name isn't unique in the scope of all games then the warning message should appear under the team's name field, and the form shouldn't be valid, the user can't proceed.
Once the issue is fixed, the form should be valid and the user can proceed.

would be great:)

if the implementation is similar to the case you've worked on, it makes sense to share it via composable. It could go there for example client/src/use/common.ts


remove coveralls.io

It's disabled for a while now anyway (I wonder how). The full test suite regularly times out on submission to coveralls. Full suite runtime fluctuates from 35 to 50 minutes, but this likely out of our control, and this change is less intrusive than alternatives based on splitting the test suite into several runs.
Note that this only disables coveralls.io, not coverage itself. The latter still reports its findings in the CI log.

Thanks @ev-br, forgot about removing this one. I hope it helps....

@ev-br you managed to somehow push your branch to the scipy repo, from which you sent a PR. I deleted it now....

Ouch, sorry for the mess!
Note to self: this is what happens for a PR sent from a web interface. The error's clear in retrospect: need to do this from the fork, not the main repo.

@rgommers @ev-br did this end up helping? It's a bit sad we can't use coveralls. But if it did indeed end up causing problems it makes sense. If it's unclear if it had an impact, I could open a PR to try to add it back in. The longest run I see on e.g. #5186 is about 26 minutes which should be pretty safe to add a little bit of time to. Maybe the builds got faster because of using container infrastructure in the meantime?

I think we could consider re-adding coveralls (I'm currently manually running runtests.py -g --coverage for a PR...). It's in use for asv, and I haven't seen upload problems there.

I've found coveralls to be pretty disappointing to be honest:

the difference in coverage reported was usually 0.0% even when the actual coverage was different. Just because scipy was so large, so more or less coverage within a single function usually ends up being 0.0x% different.
coverage.io was slow
browsing to the output on coverage.io I usually got errors for individual files if they were larger than a couple of hundred lines.

Yes, it's true that their web interface is not good, and I'm not happy that it nowadays reports a failure if the coverage percentage decreases (so you get the red cross next to PRs).
The HTML report produced by Python's standard coverage module is much better.
Of course, it would be trivial to write a web service that just receives those reports, but someone would have to write and maintain it...

Maybe https://codecov.io/ is worth trying

codecov.io seems interesting. from the screenshot it looks like it would comment on PRs with the relevant part of the coverage report, which would be useful.

I know that on coveralls you can set the threshold for failure to something
other than 0% change, and recently the comments have gone to two decimal
places. But if the other site looks decent I'm happy to look into possibly
using it. I could even start by switching a different repo of mine over to
vet it first. Sound good?

Sounds good to me. If coveralls has improved a lot then I wouldn't be opposed to re-enabling it either. Maybe a good way to go is to enable whichever one you prefer on your own scipy fork? Then we can have a look at the results as they will be for this repo.

Good call, will do

It took me over a month to click some buttons on Travis and Codecov, and change a few lines in .travis.yml but I finally got it done. I have a demo up on my repo, and you can see the results of a PR here (ignore the failures I killed some of the non-coverage builds):
https://github.com/Eric89GXL/scipy/pull/6
https://codecov.io/github/Eric89GXL/scipy?pr=6
Then once it's merged into master, subsequent PRs get notices like this (if they're turned on):
https://github.com/Eric89GXL/scipy/pull/7

Looks like the first report link is dead -- I guess codecov gets rid of reports on PRs once they are merged, so the list of "branches" only includes those PRs that are still open.
In any case, I'm +1 for opening a PR into scipy master, as this seems to work well.

I also got an email from a codecov person asking for feedback. I mentioned that the grouping of branches with pull requests into a single menu is not as convenient as grouping the way e.g. Travis does it, and they informed me that they're working on an interface with better organization. So they seem responsive to feedback, too.

@Eric89GXL nice, that sounds promising. Browsing the coverage-highlighted code on codecov.io is much faster and more reliable then what it was on coveralls.io. A single comment by a bot that gets updated is probably less intrusive than repeated comments, so also sounds OK. So +1 from me.


⚠ Bofrost.de has degraded performance

In 180e071, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1855 ms

Resolved: Bofrost.de performance has improved in 4d4b53b after 14 minutes.


build/test improvements

Coverage increased (+0.1%) to 79.721% when pulling f70408efbf58d5899a347344ece09e9dfe451e2a on ryan-williams:tests into 2dcca1ef4a790c39b6a18b2b0cf7839610986334 on hammerlab:sbt.


Removed system Properties

Removed system Properties, because for my use case I need more clean output.

Also fixed issue: Inconsistency in pushing data from Jenkins to elastic search #2

Great! Thanks for your fixes.


Docker run -u option does not work

It looks like the docker run -u option is not working properly - this seems to be the my last hurdle before I can switch our dev team over to dlite for a true container-based hermetic build environment!
I'm guessing we need to get the local user/group information into the dhyve-os VM?

hmm.. yeah, we would need to somehow replicate the users and groups from the host into the vm. this should be possible, but won't be easy for sure

just to confirm - the users you would be interested in replicating are all created by you? no built in OS X users?

That's correct.  And I'd venture a guess that most Mac machines which host
docker have a single interactive dev user... Just getting that single
user/group working would probably solve a majority of the dev/test
scenarios.
On Feb 25, 2016 8:17 AM, "Nathan LaFreniere"<EMAIL_ADDRESS>wrote:

just to confirm - the users you would be interested in replicating are all
created by you? no built in OS X users?
—
Reply to this email directly or view it on GitHub
https://github.com/nlf/dlite/issues/99#issuecomment-188859911.

that was my assumption too, just wanted to make sure that you (as the only person that's asked for it) didn't have the need for more than that

Nice!!  I'm looking forward to picking up this change as soon as homebrew has the latest goodness. :)


Input hydrator (tmp)

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
✔

Fixed issues
-

Closed in favor #599


[2.0.0-prepare][Improvement#6655] [UI] remove registry monitor  (#6789)

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

:exclamation: No coverage uploaded for pull request base (2.0.0-release-prepare@5283e54). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             2.0.0-release-prepare    #6824   +/-   ##
========================================================
  Coverage                         ?   37.64%
  Complexity                       ?     3210
========================================================
  Files                            ?      648
  Lines                            ?    26383
  Branches                         ?     2849
========================================================
  Hits                             ?     9932
  Misses                           ?    15535
  Partials                         ?      916

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5283e54...c4958c7. Read the comment docs.


ZUI 75 trustpilot title

Changest trustpilot svg title to be dynamically set according to the rating:
https://jira.zopa/browse/ZUI-75

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

:tada: This PR is included in version 5.40.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Trunk generates relative urls for (at least) css resources

<head>
    <base data-trunk-public-url />
    <!--Some elements omitted for simplicity-->
    <link data-trunk href="styles/styles.scss" rel="scss">
</head>

This head of index.html is converted to
<head>
    <base href="/">
    <!--Some elements omitted for simplicity-->
    <link rel="stylesheet" href="styles-c779a680004c93da.css">
<script type="module">import init from '/index-d59ae4335718e745.js';init('/index-d59ae4335718e745_bg.wasm');</script></head>

Here, the link for stylesheet has a relative url but js and wasm files have absolute urls. The URL for stylesheet should also be absolute (with maybe an option to make it relative? I don't see where that would be needed though.)

Hmm, yea ... they should definitely be absolute. And actually, they should include the public-url as the base if one is provided, which is what the WASM pipeline does. Will fix this and push it as 0.7.2.

@hamza1311 thanks for being vigilant and reporting all of these issues. Very helpful! 0.7.2 is already in pipeline for release.

Thanks for that fix! This fixed for me that my CSS was broken when I got redirected to my 404 page 😄


Add a Gitter chat badge to README.md

NSwag/NSwag now has a Chat Room on Gitter
@rsuter has just created a chat room. You can visit it here: https://gitter.im/NSwag/NSwag.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Already added.


Playback Issue

Hi,
So I tried 2.1.1 and it has playback issue, and it glitches I guess between each chunk.
./plexdrive --chunk-size=20M --clear-chunk-age=10080m -t /Volumes/Backup/plexdrive -v 2 -c ~/.plex --refresh-interval=1m ./mtng
Which based of my setup, it glitch every 15 second or so for a video that I tried.
I compiled also from the source too, but it still have the problem with latest commit.
I revert back to version 2.1.0 and it’s working fine without any problem.
Side note:
My setup is 20M for chunk, when I’m on the 2.1.0, the chunk have exact number, but when I’m on 2.1.1, the chunk have different numbers.
The buffer works perfectly which I can see it’s way ahead of playback, but the video get glitch and jittery every 15 second or so.
Also I deleted the cache file and chunk folder before testing both.

I'm using default values and playback is working well. What happens when you shift to default values ?

@haljordan2814
I would still have problem with the default value, which I only used like
./plexdrive2 -v 2 -c ~/.plex ./mtng
And because the chunk is 5mb in the default, it was having glitch and jitter each 5 second.

I fixed an issue, that exists since 1.0.0.
With this fix (included in next release) the pre-buffering will be more "aggressive", so you won't get any stuttering while playing back movies, but if you stop a movie it will still load some data in the background and do not stop immediately.
In general: With the new release you will have more load on your network, but there should not be any playback issues anymore.
I have to do some more testing, so if you are using a custom build nightly there still could be bugs in this new logic ;)

@dweidenfeld
I tried to build from the latest commit you released few hours ago, and I still have the problem.

Buffer is very bad now, as of now 2.1.0 will take maximum 7 second to buffer the new video and start it, but with the latest commit, it will take minimum 16 second to buffer the video and it buffer it very slowly.
The glitch and jitter is still there, same spot for the video and still no change.

PS. I removed the cache file and chunk folder before test.

The release is not finalized yet. Please test the final releases.


Hide menu options

Question / Problem
Is There any way to hide menu (Three dots),if we don't want to share url.

Hi, not it's not possible. The IFrame player does not allow it.


Does not support real-life jobcode

add n/John Doe p/987654321<EMAIL_ADDRESS>j/2024-00083 t/N

Allow dash only

dash only


Move BeamFnDataGrpcMultiplexer to java-fn-execution

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

This can be used by both ends of the Data Service.
This is almost entirely a code move, with minor backports for java7 compatibility.

Rebase on top of master to pickup the fix that JB did to fix javadoc comment on non-existent close method and lets try to get this one in.


Use prefix to access the RGW API to fix a HTTPS/CORS issues

Fixes: https://github.com/aquarist-labs/s3gw/issues/31
Related to: https://github.com/aquarist-labs/s3gw-tools/pull/135
Signed-off-by: Volker Theile<EMAIL_ADDRESS>

I'm closing this issue because the documentation has been updated to inform the user about that issue and giving hints how to workaround it.


Move DenseSubset from Dataproc to Batch

Testing here https://batch.hail.populationgenomics.org.au/batches/433500

Test successful: https://batch.hail.populationgenomics.org.au/batches/433503/jobs/1


Update CONTRIBUTING.rst

Please refer to CONTRIBUTING.md for detailed instructions.
Summary

PR Checklist

[ ] My PR is less than 500 lines of code
[ ] I have added sufficient comment as docstrings in my code
[ ] I have made corresponding changes to the documentation

[ ] I have written unit-tests to test all of my code

will be added by https://github.com/sambanova/generative_data_prep/pull/65


Missing Python implementation of MakeAbs for LP

Hi,
i am using the GLOP solver to solve a linear problem and I need to add a constraint which depends on the difference of two values. These values are not fixed but are both equations of other VariableExpr objects and NumVars.
So I need the absolute difference of those values but it seems that the implementation for the abs function is missing in the or-tools Python wrapper? The documentation states that in C++ a function MakeAbs exists. Where is this in Python, I can't find it in the files?
Thanks

Hi,
usually python methods are defined in the swig file https://github.com/google/or-tools/blob/master/ortools/linear_solver/python/linear_solver.i
However on python we provide a natural language API here: https://github.com/google/or-tools/blob/master/ortools/linear_solver/linear_solver_natural_api.py
I think you want to add (PR welcome) an abs opname...

Hi,
I looked through both of the files but there is no reference to an abs function, nor an implementation of it.

abs is not linear.
You need to linearize it.
This is the first link found by Google :-)
https://optimization.mccormick.northwestern.edu/index.php/Optimization_with_absolute_values
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le mer. 8 août 2018 à 00:27, rummens<EMAIL_ADDRESS>a écrit :

Hi,
I looked through both of the files but there is no reference to an abs
function, nor an implementation of it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/792#issuecomment-411313177,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKj17eDHkmvtOMxJsWPLB2_8IxFpFwO3ks5uOpLtgaJpZM4VzXFG
.


Third-party library updates

Update 3rd-party libraries to current versions
Update various CMakeLists.txt to fix Unicode compilation issues
Raise CMake requirement to 3.15 to get around this MSVC issue

Thank you for working on this! Maybe you could dig a little more and figure out why the CI fails? You can find the logs here: https://ci.appveyor.com/project/QbProg/crashrpt2/history

Thank you for working on this! Maybe you could dig a little more and figure out why the CI fails? You can find the logs here: https://ci.appveyor.com/project/QbProg/crashrpt2/history


Review request for Microsoft.DBforPostgreSQL Flexible server to add version stable/2022-12-01

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

@ambrahma, please fix the tool check errors especially for the required ones. thanks

@ambrahma, please fix the tool check errors especially for the required ones. thanks

@lirenhe the tool errors especially LinDiff errors and the breaking change errors were also present for the 2022-03-08-preview api version. Please refer to one of the comment here https://github.com/Azure/azure-rest-api-specs/pull/21424/files#r1018602579
Avocado error for INCONSISTENT_API_VERSION doesn't seem to be a valid error as we have not included common-types.json in the readme file.
Swagger LintDiff errors are due to our RP currently supports 202 for PUT calls. This is a big change for our RP which is currently aligned to other RPs like Microsoft.SQL. This work will be taken up separately later on,

ARM review can proceed after Breaking changes review is complete

ARM review can proceed after Breaking changes review is complete. Please remove the ARMChangesRequested label once the breaking changes review is complete

ARM review can proceed after Breaking changes review is complete. Please remove the ARMChangesRequested label once the breaking changes review is complete

I reviewed the breaking changes and all appear to be benign. Marking as Approved-BreakingChange.

I reviewed the breaking changes and all appear to be benign. Marking as Approved-BreakingChange.

Thank you @mikekistler for your review. Can you please update the corresponding label as well. Looks like you missed to add the appropriate Approved-BreakingChange label

ARM review can proceed after Breaking changes review is complete. Please remove the ARMChangesRequested label once the breaking changes review is complete

Thank you @rkmanda , Mike has approved Breaking change above, hence removing the ARMChangesRequested label.

@ambrahma, please fix the tool check errors especially for the required ones. thanks

@lirenhe the tool errors especially LinDiff errors and the breaking change errors were also present for the 2022-03-08-preview api version. Please refer to one of the comment here https://github.com/Azure/azure-rest-api-specs/pull/21424/files#r1018602579
Avocado error for INCONSISTENT_API_VERSION doesn't seem to be a valid error as we have not included common-types.json in the readme file.
Swagger LintDiff errors are due to our RP currently supports 202 for PUT calls. This is a big change for our RP which is currently aligned to other RPs like Microsoft.SQL. This work will be taken up separately later on,

Signed off the change from ARM side, just curious what will be the plan for fixing this in future?

The breaks are pretty benign so I approved them.

/azp run unifiedPipeline

@ArcturusZhang , could you help to check the breaking change for Go?

Discussed offline, the Avocado error could be fixed in future release.

@JeffreyRichter can you once again take a look at SDK-Go Breaking change errors


Added 333

Added 333.

If I'm submitting multiple push requests into main whilst one or more hasn't been approved yet, I'm kind of aware I'm indirectly overwriting the lines of the other push request(s).   Does it matter?  What's the best way for me it submit a further request whilst a previous one hasn't been approved? Cheers.

If I'm submitting multiple push requests into main whilst one or more hasn't been approved yet, I'm kind of aware I'm indirectly overwriting the lines of the other push request(s). Does it matter? What's the best way for me it submit a further request whilst a previous one hasn't been approved? Cheers.

Hey Phil,
That's totally fine, multiple pull requests in parallel's nothing to worry about for us.
When a pull request gets accepted there's then a 'merge commit' where the relevant bits from the current main branch and the new rule's branch are combined together. Git tries to do this automatically, but it often gets confused (e.g. due to all the identical return error, _validate lines in validators.py), so I have to do it manually, but it's really straightforward, just making sure nothing accidentally gets deleted.
In principle it can get fairly fiddly and involved, but since we're usually just adding extra functions which are independent of one another, it's no big deal. On the other hand, if while working on the new rule branch there'd been a commit to main that, say, required a new parameter to ErrorDefinition for all the rules, or changed the name of a table in dfs, then that'd have to be incorporated into the new rule's branch before (by pulling from main and merging on the branch) or during the merge.

closes #136


feat: add str_contains() in text helper

I just include a new function "str_contain" which I know is already existing in php 8 but not in lower versions of php and codeigniter 4 started with php v7.2. So I think this will help other developers. I used this function to check if a certain needle is existing in a haystack. This returns boolean value
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPDoc blocks, only if necessary or adds value
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Thank you for sending PR.
We need unit testing and documentation:

https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#documentation

You merged develop into your PR branch.
But please use rebase insttead of merge.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#pushing-your-branch

You merged develop into your PR branch. But please use rebase insttead of merge. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#pushing-your-branch

Okay, thanks. Surely I will do that

composer requuire symfony/polyfill-php80 =)

composer requuire symfony/polyfill-php80 =)

but not required. the function is just simple so no need for that.

What is codeigniter using for boolean testing?

@ChibuezeAgwuDennis
You can see the implementation of the polyfill.
Plus there are other string function polyfills that could be added to this PR.

@ChibuezeAgwuDennis
This PR is only for str_contains().
Don't add oher functions even if you want to add.

@kenjis why not

@iRedds
Each pull request should address a single issue.
The larger the PR, the greater the chance that it will be closed.

@ChibuezeAgwuDennis It seems your code is reverted. You need more test cases. Now there is no tests.

what should i use to test the function because i tried
$needle = 'I';
$string = 'I tried to see what I can do
$this->assertSame(true, str_contains($string, $needle));

it return error

@ChibuezeAgwuDennis

it return error

I don't see your screen. I don't see the error message.
I can't help you.
I recommend you add extensive tests for the function first,
using @dataProvider.

@ChibuezeAgwuDennis

it return error

I don't see your screen. I don't see the error message. I can't help you.
I recommend you add extensive tests for the function first, using @dataProvider.

PHP CS FIXER RETURNS ERROR

PHP CS FIXER RETURNS ERROR

I don't see your screen. I don't see the error message.
Fix the error. Most errors can be fixed by php-cs-fixer.
See

https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#php-style
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#static-analysis-on-php-code

@ChibuezeAgwuDennis It seems your code is reverted. You need more test cases. Now there is no tests.

@kenjis what should i use to test the function because i tried
$needle = 'I';
$string = 'I tried to see what I can do
$this->assertSame(true, str_contains($string, $needle));

// Also tried this
$this->assertTrue(str_contains($string, $needle));

it return error

Use Data Providers. Your test would be something like:
/**
 * @dataProvider provideStrContainsCases
 */
public function testStrContains(bool $expected, string $haystack, string $needle): void
{
    $this->assertSame($expected, str_contains($haystack, $needle));
}

public function provideStrContainsCases(): iterable
{
    yield from [
        [true, '', ''],
        [true, 'foo', ''],
        // insert your other tests
    ];
}

Any updates on this?

No feedback from OP, closing.


⚠ Samsung has degraded performance

In ecba38e, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 1993 ms

Resolved: Samsung performance has improved in 6981672.


Give Tom the ability to read review comments

Signed-off-by: Ole<EMAIL_ADDRESS>

Thanks for submitting a pull request! Maybe @vpodzime can review this?

@olehermanse fixed, and rebased off of master.


Replaced spark3xx-common references to spark-shared

In https://github.com/NVIDIA/spark-rapids/pull/10993 we made changes to add support for Spark 4.0.0. This PR removes some left-over usage of spark3xx-common.

Update this comment as well
https://github.com/NVIDIA/spark-rapids/blob/2f3c0c276dba3e8870f3e3bfa9287e644809f4f6/dist/scripts/binary-dedupe.sh#L131-L133

Since this is a TODO and you wrote this comment do you think naming them spark32x-shared etc in future makes sense? Or were you thinking of renaming them to something different?

Since this is a TODO and you wrote this comment do you think naming them spark32x-shared etc in future makes sense? Or were you thinking of renaming them to something different?

spark32x-shared is a good way. However,  to follow best practice let us delete the TODO and I'll file an issue

can we please have a description on this as to what the problem is/what this relates to and what this is fixing?
Why are we changing name from common to shared, seems arbitrary?

can we please have a description on this as to what the problem is/what this relates to and what this is fixing?
Why are we changing name from common to shared, seems arbitrary?

I have updated the description, does that give enough context or should I add something more?

@jlowe @gerashegalov @tgravescs please take another look. This needs to be merged very soon

build

premerge is failing but I don't see anything on the page besides While reading class directory: /var/jenkins/jobs/rapids_premerge-github/builds/9620/jacoco/classes
re-kicking

build

Jacoco coverage report is still failing. I'm still trying to root cause this.

build

build

Updated the title to make sure all Databricks versions pass.

build


Problems with Current Selection -> Append To

Hi. I brought this up in the forum and it was suggested that I flag it as an issue. I'm trying to make a trigger that appends the current selection to a file, which seems like it should be pretty easy.
Current Selection -> Append To... -> the_file
Nothing appears in the file, though. It doesn't matter if I run it as a trigger or form it directly in the interface.
These things do work:
Current Selection -> Large Type
some_text -> Append To... -> the_file
Rob McBroom's theory is that "the process of getting the Current Selection from most apps ends up stealing focus from the window." That rings true to me.
I have qs 1.1.3 and OS 10.9.5
Thanks.

There was an issue with the 'Text Manipulation' plugin, in that the 3rd pane was not correctly showing files to 'append to'. But this has just been fixed.
I cannot reproduce the original issue, however.


create-react-app build on now fails

Hi. I'm trying to run 'react-scripts build' step in package.json scripts 'now-build' step.
I'm getting the following error:
> ▲ npm run now-build
>
>   - index.js:47 Compiler.<anonymous>
>     [src]/[b6a523076d54485fee7b51e624a717feb64ba053]/index.js:47:40
>
> Error Error: Command react-scripts build ended with code 1
>     at ChildProcess.<anonymous> (/usr/lib/node_modules/@zeit/ace/build/lib/run.js:1:599)
>     at emitTwo (events.js:106:13)
>     at ChildProcess.emit (events.js:191:7)
>     at maybeClose (internal/child_process.js:877:16)
>     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)

Any suggestions on how to handle this?
Thanks in advance!

Hey @jamo @reflog @rase- , I also threw this issue on their repository.
https://github.com/facebookincubator/create-react-app/issues/1185

Thanks for reporting this, current workaround is to downgrade react-scripts to version 0.7.0.
We are working on a fix

Just a friendly heads up—we’ll have to temporarily remove the section about Now in User Guide if support is broken so that people don’t waste time on it. Do you have any ETA on the fix? Sorry for being annoying.

I'm happy to announce that the underlying issue with now has been finally fixed and react-create-apps can now again be deployed on now
Demo app here: https://react-create-app-demo-zqahqhmybz.now.sh/
and src here: https://react-create-app-demo-zqahqhmybz.now.sh/_src/?f=package.json
Apologies for the radio silence 😅

Thank you so much!

Hi @jamo I'm still seeing errors trying to deploy create-react-app with now. you can conveniently see the error served here: https://replacement-idrrunzrtn.now.sh/ 😉  thoughts?

Based on the error:
Failed to compile.

Error in ./src/index.js
Module build failed: Error: EACCES: permission denied, mkdir '/home/nowuser/src/node_modules/.cache'
 @ multi main

Yea it is trying to do that, not sure why though... now should be running the build command right?

I also just tried now on create-react-app project and it fails with:
Failed to compile.

Error in ./src/index.js
Module build failed: Error: EACCES: permission denied, mkdir '/home/nowuser/src/node_modules/.cache'
 @ multi main

It doesn't ship with the a production webserver. And the start runs the dev server instead a production useable server...
So to deploy it you'll need to  npm run build to generate a minified bundle that may be deployed with ~any web server solution.
And then for example use serve to serve that static minified bundle:
npm i -S<EMAIL_ADDRESS>and add now-start script:
{
  "start": "react-scripts start",
  "now-start": "serve build/",
  "build": "react-scripts build",
  "test": "react-scripts test --env=jsdom",
  "eject": "react-scripts eject"
}

Here is a full empty demo app https://react-app-demo-vygvkezcul.now.sh/_src
(that I likely will one day accidentally delete...)

thank you! @jamo

@jamo works perfect!

I think this might be outdated, right @jamo ? If you do this now it will deploy as a site with a backing instance running serve, whereas if you just run yarn build and then now in the ./build directory, it will serve as a static site over CDN (and not count against your concurrent instances?

trying to deploy fails at build phase:
> Initializing…
> Building
> ▲ npm install
> ✓ Using "yarn.lock"
> ⧗ Installing 15 main dependencies…
> ▲ npm run build
><EMAIL_ADDRESS>build /home/nowuser/src
> react-scripts build
> Creating an optimized production build...
> > Error! The build step of your project failed. To retry, run `now --force`.

"react-scripts": "1.1.4",

@reflog Hi 😸, I will ignore the yarn.lock file and try again to deploy.
that should work ❤

@reflog If the problem persists, let me know 🙏 😄

it's working fine now, thanks


JSON Function

Hello, Did anyone has a trick or know how to use JSON function like
JSON_MERGE
or
JSON_REMOVE
in Objection.js?


Website

Will push a placeholder page for now so the repo is set up properly to handle it later.

Working on website for CSS-in-JS https://github.com/MicheleBertoli/css-in-js/pull/58. And in the end I realised I would prefer your approach with less option, but with bigger number of features. I also would like to see other features, like SSR or Size of runtime. Current version https://stereobooster.github.io/css-in-js/


Add one entry to congo users table

I added my personal portfolio website. Congo is credited on my About page
:beers:

Thanks for the PR, @boscacci, however I can't get the URL you submitted to work. It just takes me to a 404 at GitHub Pages?

Looks like it's working now, I'll merge this in!  Thanks for using Congo. Your site will appear on the public list when the next theme release is published.


Add auth dialog with social auth options using Firebase Authentication

This is something I believe really required, just like I am using another extension for notes and there is a feature of google sync. So in that case my notes are always synced with my google account. Just in case I lose this extension due to some system failure or any other reason, I won't lose the data and can sync it back.
So I believe a similar feature should be available here as well, So I don't lose all my planning because of any such failures.

Any update on this one?


QQMusic and NetEase sources are reportedly failing to find lyrics that actually are available

Reported at: https://www.reddit.com/r/foobar2000/comments/mm70rb/i_made_an_opensource_alternative_to/h51d9o3/
Songs in question:

Elvis Presley - Blue Moon
Sia - Hey Boy (feat. Burna Boy)

Closing because I can find lyrics no problem for both of these.


[Packaging | License] - Decide on the type of license of the repository

Describe the choice and link to this Issue the PR that adds the LICENSE file.

Closed with #22


Add Original Satoshi

Original Satoshi (https://www.originalsatoshi.com/) is a Bitcoin Store. We sell stickers accepting payment with lightning and also carry other bitcoin related goods from time to time.

Thanks for the request. Do you have a twitter account?

Use @originalsatoshi cheers!

Added


need to check we are using the most up to date  version of PSI-MOD

From Kim in e-mail
The OBO foundry links to:
https://raw.githubusercontent.com/MICommunity/psidev/master/psi/mod/data/PSI-MOD.obo
which is from 2014.
I can't remember if we  sorted this....

It doesn't really change much so it might be OK?

It doesn't really change much so it might be OK?

I'm doing a test load now on my desktop.
Needed a slight tweak to allow it to load: https://github.com/HUPO-PSI/psi-mod-CV/pull/19

I'm doing a test load now on my desktop.

The latest PSI-MOD.obo loads fine so I'll add to the main Chado load for tonight.

Great. All that for ONE modification. Nobody can say  we aren't comprehensive :)


cargo-deny: 0.8.5 -> 0.8.7

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/EmbarkStudios/cargo-deny/releases.
meta.description for cargo-deny is: "Cargo plugin to generate list of all licenses for a crate"
meta.homepage for cargo-deny is: "https://github.com/EmbarkStudios/cargo-deny"
meta.changelog for cargo-deny is: ""
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.8.7 with grep in /nix/store/yrvqzbhvdm18chnwqf2l7k6jv0kyfj46-cargo-deny-0.8.7

directory tree listing: https://gist.github.com/e982a009d72c5dc2dd5687d18dcc5fdb

du listing: https://gist.github.com/99387c0a1ed384a41e30ffa15ff196af

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
cargo-deny

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/yrvqzbhvdm18chnwqf2l7k6jv0kyfj46-cargo-deny-0.8.7 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-deny https://github.com/r-ryantm/nixpkgs/archive/06e8cbf83f895d73c7d3084e18d361771ab4c886.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/yrvqzbhvdm18chnwqf2l7k6jv0kyfj46-cargo-deny-0.8.7
ls -la /nix/store/yrvqzbhvdm18chnwqf2l7k6jv0kyfj46-cargo-deny-0.8.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cargo-deny

Maintainer pings
cc @matthiasbeyer for testing.

Diff LGTM


Update README.md with link to installing Anvil

Tried to run tests, noticed that they require anvil to be installed.  Updating readme to reflect this

thank you!


[Issue 523] Fix logic for createDatabase.enabled variable

What was changed
Fixed logic flow for .Values.schema.createDatabase.enabled to allow creating databases if they are not provisioned beforehand.
Why?
See bug described in https://github.com/temporalio/helm-charts/issues/523
Checklist

Closes 523

How was this tested:
helm template . -f values/values.postgresql.yaml --debug > test.yaml
and inspecting content of the resulting manifest. Tested for

.Values.schema.createDatabase.enabled=true
.Values.schema.createDatabase.enabled=false

Any docs updates needed?
N/A

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Should be fixed by #522, please test this and let me know.

Please let me know if #522 does not fix this for you, I'll re-open.

Tested just now and can see create-default-store and create-visibility-store init containers are rendered. Thank you @robholland !


unexpected compiler error: attempt to expose non-public symbol ''

Description:
balcompiler reports about a non-public symbol ''.
Steps to reproduce:
Build the following ballerina fragment:
public class A {
    public function increment(0 | 1 value) returns int {
        return value + 1;
    }
}

public type ZeroOrOne 0 | 1;

public class B {
    public function increment(ZeroOrOne value) returns int {
        return value + 1;
    }
}

public function main() returns error? {
    var a = new A();
    var result = a.increment(0);
}

The compiler reports the following error:
Compiling source
	test.bal
ERROR [test.bal:(2:5,4:6)] attempt to expose non-public symbol ''
WARNING [test.bal:(17:5,17:33)] unused variable 'result'
error: compilation contains errors

This is probably related to the type 0 | 1  on line 2.
Affected Versions:
Ballerina 2201.0.1 (Swan Lake)
Language specification 2022R1
Update Tool 1.3.9
OS, DB, other environment details and versions:
Linux integrationbox-02 5.13.0-35-generic #40~20.04.1-Ubuntu SMP Mon Mar 7 09:18:32 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
openjdk 17.0.2 2022-01-18
OpenJDK Runtime Environment (build 17.0.2+8-Ubuntu-120.04)
OpenJDK 64-Bit Server VM (build 17.0.2+8-Ubuntu-120.04, mixed mode, sharing)

Related issue #34839

Fixed with  #36959


feat(runtime-vapor): scheduler

scheduler.ts
Retained the effect method, aligning other methods with runtime core
warn.ts
Print only wanring messages without printing component context information, as the parent component cannot be obtained yet
component.ts
Add getComponentName function, but just can get function component name. If function component name is Falsy will return ''

pr 69 Implemented this function


random posts recommendation widget

This widget will be put under About widget, it's not sticky.
The count is configured in Setting.
In theory this result should be cached, but we will not implement any cache in 2018-A milestone, so we leave it as dynamic.

This should be smart enough, and differs against what page it's used for.
If we are at Index page, the results should be random, which we should cover as many categories as we can.
If we are at post page, the results should be first go to alike categories, then same month post all time. If the count still doesn't match what we need, we choose randomly.
If we are at category page, the results should exclude posts already shown in current pages. Same with archive page.
If we are at about page, the results should be same with Index.

public class RandomPostFactor
{
	public IEnumerable<Guid> ExcludePosts{get;set;}

	public Guid AlikePost {get;set;}

	public bool AdminView {get;set;}
}

public class RandomPostGenerator
{
	private readonly int _maxCount;
	private readonly Random _random;

	public IEnumerable<BlogPost> Execute(RandomPostFactor factor)
	{
		var posts = ...;
		var categories = ...;
		var result = new List<BlogPost>();

		if(ExcludePosts != null && ExcludePosts.Any())
		{
			posts = posts.Where(_ => !ExcludePosts.Contains(_.Id));
		}

		if(!AdminView)
		{
			posts = posts.Where(_ => !_.IsPrivate);
		}

		if(AlikePost != Guid.Empty)
		{
			var alikePost = posts.FirstOrDefault(_ => _.Id == AlikePost);
			if(alikePost != null)
			{
				posts.Remove(alikePost);
				foreach(var cat in alikePost.Categories)
				{
					var post = GetRandomPost(posts.Where(_ => _.Categories.Any(c => c.Id == cat.Id)));
					result.Add(post);
					posts.Remove(post);
				}

				if(result.Count() < _maxCount)
				{
					var sameMonthPosts = new List<BlogPost>(posts.Where(_ => _.CreateAt.Month == alikePost.CreateAt.Month));
					for(var i=0;i<_maxCount - result.Count();i++)
					{
						var post = GetRandomPost(sameMonthPosts);
						result.Add(post);
						posts.Remove(post);
						sameMonthPosts.Remove(post);
					}

				}
			}
		}

		for(var i=0;i<_maxCount-result.Count();i++)
		{
			var post = GetRandomPost(posts);
			result.Add(post);
			posts.Remove(post);
		}

		return result.OrderBy(_random.Next());
	}

	private BlogPost GetRandomPost(IEnumerable<BlogPost> posts)
	{
		return posts[_random.Next(0, posts.Count() - 1)];
	}
}


Likely bug in ThreadedTableModelUpdateMgr when adding more than 3000 elements to an AddressBasedTableModel

Describe the bug
I have a plugin that implements a GhidraThreadedTablePanel and GhidraTableFilterPanel on an AddressBasedTableModel. By binary search, I observed that trying to add more than 3000 (plus a bit, typically) elements to the model from a script was resulting in no rows after the script finishes, while adding less than that, or calling Thread.sleep with a sufficiently large wait time will allow the addition of all elements successfully.
I had similar issues when trying to add more than 3000 elements from a DockingAction, with the additional limitation of not being able to call long Thread.sleep due to a deadlock (Edit: I later resolved this by implementing a BackgroundCommand which adds the elements in batches, calling Thread.sleep between each batch.
ERROR Timed-out waiting to run a Swing task--potential deadlock!
Threads State:
java.lang.Throwable (Swing)
ERROR Unexpected Exception: Timed-out waiting to run a Swing task--potential deadlock! (LoadJob) java.lang.RuntimeException: Timed-out waiting to run a Swing task--potential deadlock!
	at ghidra.util.Swing.runNow(Swing.java:177)
	at docking.widgets.table.threaded.TableUpdateJob.applyData(TableUpdateJob.java:682)
	at docking.widgets.table.threaded.TableUpdateJob.processState(TableUpdateJob.java:346)
	at docking.widgets.table.threaded.TableUpdateJob.run(TableUpdateJob.java:129)
	at docking.widgets.table.threaded.ThreadedTableModelUpdateMgr$ThreadRunnable.run(ThreadedTableModelUpdateMgr.java:415)
	at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: ghidra.util.exception.UnableToSwingException: Timed-out waiting for Swing thread lock in 20 SECONDS
	at ghidra.util.Swing.waitFor(Swing.java:256)
	at ghidra.util.Swing.runNow(Swing.java:235)
	at ghidra.util.Swing.runNow(Swing.java:163)
	... 5 more

The approximate threshold of 3000 leads me to suspect that this is due to the implementation of ThreadedTableModelUpdateMgr:
(edit: it looks like this behaviour is intentional; if so (or if, as is fairly likely, I have done something wrong with my code), is there any recommendation on how to add many elements to the model safely + quickly?)
// make the delay large enough that a flurry of events will stay buffered
public final static int DELAY = 5000;
public final static int MAX_DELAY = 1000 * 60 * 20;
static final int TOO_MANY_ADD_REMOVES = 3000;
// this.maxAddRemoveCount = TOO_MANY_ADD_REMOVES;

	private void processAddRemoveItems() {
		synchronized (addRemoveUpdater) {

			if (addRemoveWaitList.isEmpty()) {
				return;
			}

			// too many requests for add/remove triggers a full reload for efficiency
			if (addRemoveWaitList.size() > getMaxAddRemoveCount()) {
				reload();
				return;
			}

			runJob(new AddRemoveJob<>(model, addRemoveWaitList, monitor));
			addRemoveWaitList = new ArrayList<>();
		}
	}

To Reproduce
The script:
public class AddFnsToPlugin extends GhidraScript {
	int MAX_FNS = 3100;
	@Override
	protected void run() throws Exception {
		MyFirstPlugin plugin = getPlugin(MyFirstPlugin.class);
		FunctionIterator fIter = currentProgram.getFunctionManager().getFunctionsNoStubs(true);
		int i = 0;
		while (fIter.hasNext()) {
			i++;
			plugin.addFn(fIter.next());
			if (i > MAX_FNS) {
				break;
			}
		}
	}

	private <T extends Plugin> T getPlugin(Class<T> c) {
		List<Plugin> list = tool.getManagedPlugins();
		Iterator<Plugin> it = list.iterator();
		while (it.hasNext()) {
			Plugin p = it.next();
			if (p.getClass() == c) {
				return c.cast(p);
			}
		}
		println("Error retrieving plugin by class ");
		return null;
	}
}

A partial reproduction of my plugin (which I am not able to share, unfortunately) is as follows:
public class MyFirstPlugin extends ProgramPlugin {
	RuntimeFuncProvider fnProvider;
	public MyFirstPlugin(PluginTool tool) {
		fsProvider = new RuntimeFuncProvider(this, pluginName);
	}
	void addFn(Function fn) {
		fnProvider.addObject(fn);
	}
}

public class RuntimeFuncProvider extends ComponentProviderAdapter {
	private FuncTableModel model;
	private GhidraTable table;
	private GhidraThreadedTablePanel<Function> threadedTablePanel;
	private GhidraTableFilterPanel<Function> tableFilterPanel;
	private TableModelListener listener;

	public RuntimeFuncProvider(Plugin plugin, String owner) {
		super(plugin.getTool(), "My Functions", owner, ProgramActionContext.class);

		model = new FuncTableModel(tool, null);
		threadedTablePanel = new GhidraThreadedTablePanel<>(model);
		GhidraTable table = threadedTablePanel.getTable();
		tableFilterPanel = new GhidraTableFilterPanel<>(table, model);
		panel = new JPanel(new BorderLayout());
		panel.add(threadedTablePanel, BorderLayout.CENTER);
		panel.add(tableFilterPanel, BorderLayout.SOUTH);

		listener = e -> {
			String subTitle;
			if (model.isFiltered()) {
				subTitle = "(filter matched " + table.getRowCount() + " of " +
					model.getKeyCount() + ")";
			}
			else {
				subTitle = "(" + table.getRowCount() + " fns)";
			}
			setSubTitle(subTitle);
			contextChanged();
		};

		table.getModel().addTableModelListener(listener);
		setDefaultWindowPosition(WindowPosition.BOTTOM);
		setVisible(true);

	}

	public void addObject(Function fn) {
		model.addObject(fn);
	}
}

public class FuncTableModel extends AddressBasedTableModel<Function> {
	FuncTableModel(PluginTool tool, Program program) {
		super("MyFunctions", tool, program, null);
		initialize(program);
	}

	private void initialize(Program program) {
	}

	@Override
	public Address getAddress(int row) {
		Function rs = this.getRowObject(row);
		return rs.getEntryPoint();
	}
	public int getKeyCount() {
		return getRowCount();
	}

	void reload(Program newProgram) {
		setProgram(newProgram);
		initialize(getProgram());
		reload();
	}

	@Override
	protected void doLoad(Accumulator<Function> accumulator, TaskMonitor monitor) throws CancelledException {
		return;
	}
}

Environment (please complete the following information):

Ghidra 1281fb9

Regarding the 3000 item limit, the intention is that at some point a full table reload is more efficient that performing individual add/remove/update operations.     Once the threshold is crossed, the table signals that a full reload is needed.  It seems like there is a path where this is not working correctly.
Regarding performing slow operations from an action (or any UI widget), we typically use a TaskLauncher for this, which will use a background thread and show the user a progress monitor.   Although, if you have the background command working, there is nothing wrong with using that.

Thanks, that was immensely helpful! I had a hunch that doLoad was the function I needed to implement but struggled to find an example in ghidra code that matched my use case.
I will close this as its clearly working as intended.


translation menu

Welcome! Please use this template for reporting documentation issues on https://developers.google.com/web/.
For questions about Chrome DevTools, checkout the
google-chrome-devtools tag on StackOverflow.
For questions about Chrome, check the google-chrome
tag. If you think you've found a Chrome bug, check out our
feedback page for more details on how to file it.
Page Affected: https://developers.google.com/web/TODO
What needs to be done?
Please provide description of what's needs to be done here. Please be sure to include the link to the original page
and any supporting links/data.

[ ] Appropriate type-something label has been added.
[ ] Appropriate section-something label has been added.

where i can find the translate button of language

@jhik2x it's on the bottom left corner of the page.


Add ability to lock in settings

I would love the ability to lock in my settings, and opt out of any new functionality. Frequently, I update VS Code and see that the editor is now different and not how I want it. I then have to hunt down the offending configuration setting(s) and turn them off, this has gotten frustrating enough that I am now opening an issue for it.
I have VS Code configured exactly how I want it, and new features being enabled by default is not ideal. I assume I'm not the only one that wants to opt out of new features that disturb our workflow or cause the editor to behave differently. The assumption that everyone will want these new features, or that it's "easy enough to disable" is becoming more and more unacceptable to me. I love VS Code, but enough is enough.

I understand how annoying changing default values and new features can be at times, but I don't believe that we can easily align our current development approach with your ask, so I'm marking this as out-of-scope.
The easiest mitigation is to switch the update mode to manual or off. A better mitigation could be to export the default settings file from an earlier version and merge that with your current user settings, but that doesn't help guard against new features, nor does it help with settings whose name or schema has changed.

Related: https://github.com/microsoft/vscode/issues/158144


stream.stop has been deprecated

stream.stop is going away, see http://blog.chromium.org/2015/07/chrome-45-beta-new-es2015-features.html

@fippo merged #9 into master and master back into this, and resolved conflicts. If this looks good, I'll merge this as well and publish. I think minor bump for these changes?

this would be patch, but the other thing is minor so let's combine the two :-)

@fippo Merged and pushed version bump to master - don't have npm publish rights on this one.


Corrected FileHandle JavaDoc

There are no such checks.
To be sure, I've tried both FileHandle.sibling(...) as well as FileHandle.child(...) with internal, non-existant files and no exceptions were thrown.

ah damnit, I forgot to squash this commit on top of one of Tomski's commits...

...

PR, Y U NO MERGED YET?!?!

For that comment, I don't even know if this deserves to be pulled anymore.

@MobiDevelop would still do it. He is nice. Not like some others taking part in this PR...!

@MobiDevelop ...
I am deeply disappointed.


Replace the word "subset" with "superset"

TypeScript is not a subset of JavaScript, it is a superset.

Hah, yeah, great point


image.-path ?

i've noticed that image-path function in the scss file is not resolved when i deploy my app,  where this function should be found?

Close old issues.


[deps] Updated dependencies

Coverage remained the same at 98.737% when pulling ede346b72f6f75ab0dfa6deb91867611ee3858c1 on dev into 6d618e3d1bfb0923ac3227854aaf30cfb39b4093 on master.


Please add intellisense for pytest fixtures (similar to PyCharm)

Pytest fixtures should have intellisense similar to https://blog.jetbrains.com/pycharm/2018/08/pycharm-2018-2-and-pytest-fixtures/

At some point, yes :-) LS is a young product so at this time we primarily investing in performance, making sure analysis understand language properly as well as basic editor functionality.


Add API to fix VStorageObjectControlFlags

Is your feature request related to a problem? Please describe.
When Node VM has no CBT but FCD has, FCD can not be attached to the Node VM.
Refer to the KB Article here - https://kb.vmware.com/s/article/88193 and GitHub Issue here - https://github.com/kubernetes-sigs/vsphere-csi-driver/issues/1416#issuecomment-1320732759
vSphere CSI Driver does not create FCD with CBT enabled, but when a customer uses some backup tooling somehow node VM got CBT enabled with all volumes attached to it. when this volume get detached from the Node and attempted to be attached to another node with CBT disabled, attach volume is failing with CnsFault error: CNS: Failed to attach disk when calling AttachDisk:Fault cause: vim.fault.InvalidState
Describe the solution you'd like
API should help clear enableChangedBlockTracking from FCD
Describe alternatives you've considered
No response
Additional context
No response

Thanks for filing this. In this case all our customer saw was - CnsFault error: VSLM task failed . While we fix the flag on FCD, can we improve error reporting at least ?


Renew Demo

Pull Request opened according to #407.
This demo provide a simple interface for choosing or uploading images and videos for processing.

Please make a separate file simplified_demo.py.

Why? I really don't think using Google Drive is a good option.

There is no visualizations and explanations troughout.

What explanations are required?
I can't see a meaningful explanation in your demo.

I think compromising by adding back your demo as old_demo.ipynb would be a good idea. What do you think?

Ok, seems reasonable. I cant see a colab button when I open your notebook in your repository. Did you commit it trough colab?

Since the Colab button is still missing even if I committed it through Google Colab, I manually added the button. This time the button should appear.

Ok. Thank you for your contribution.

Can you investigate issue #424 please?

It should work but as the questioner said there may be a file size limit. A simple workaround would be placing the video to demo/videos and name it 5.mp4 after cloning and changing range(5) to range(6) in the Python code.
And I recommend you to place the Open in Colab button directly in README like
[![this link](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/AliaksandrSiarohin/first-order-model/blob/master/demo.ipynb)


Pandas transformer fixes

Ensure totals values are reformatted to a human-friendly name, as this had been missed before.
Ensure set dimensions with custom labels can be transformed. This was causing issues because the set functionality manipulates the dimension label. Previously, the Pandas transformer converted the column names to use the label before pivoting, however, the set label override caused this to break. Now, columns and index names are only converted to the labels after the pivoting has occurred.

Coverage increased (+0.2%) to 93.453% when pulling 7b6e87f9fcc557b59166730719d519ed52b899c1 on mikeengland:pandas-transformer-changes into dba6df9c140839b205431dfbc0db1f790111c4c5 on kayak:master.

Coverage increased (+0.2%) to 93.453% when pulling 7b6e87f9fcc557b59166730719d519ed52b899c1 on mikeengland:pandas-transformer-changes into dba6df9c140839b205431dfbc0db1f790111c4c5 on kayak:master.


Feat 53 sns autoscale notifications

resolve #53

the node package vulnerability issues are from a dependency, and no fix for it provided by the dependent package. We can bypass this for this build.


SSL Pinning?

Hey,
Can we implement SSL Pinning? I saw some references to authenticationChallengeHandler but it's kind of unclear how to use it.
Can anyone share some lights?
Thank you

I have never tried implementing SSL pinning so I don't know if what's exposed is enough. You can configure a callback that will be invoked on the challenge in the HttpConnectionOptions:
https://github.com/moozzyk/SignalR-Client-Swift/blob/4c35a3a6d11132d7a0022db0c4e9264b223224d2/Sources/SignalRClient/HttpConnectionOptions.swift#L51
It was added in #179 which feels like what you are trying to do.
Here is an example of how to configure HttpConnectionOptions with HubConnectionBuilder:
https://github.com/moozzyk/SignalR-Client-Swift/blob/3713222eb4dd4c7c3e669595887e39ba35a43693/Tests/SignalRClientTests/HubConnectionTests.swift#L881-L886
The difference is that in your case you would set the authenticationChallengeHandler instead of headers.

Considering the question answered.

Huy @moozzyk , I've tried your approach, but like you said, it may be that the library is not exposed enough.
I've successfully implemented the feature ( SSL Pinning ) but had also to make some changes to the library.
Will come back here with a definitive answer  after some more investigation. I will create a pull request if needed.
Thank you

@moozzyk thank you for re-opening this.
I've created a pull request: https://github.com/moozzyk/SignalR-Client-Swift/pull/272
The delegate passthrough was not complete and the authenticationChallengeHandler was not called.
The code I used from my app, maybe it can help someone:
`let challangeDelegate: ((_ session: URLSession, _ challenge: URLAuthenticationChallenge, _ completionHandler: @escaping (URLSession.AuthChallengeDisposition, URLCredential?) -> Void) -> Void)? = { _, challenge, completionHandler in
guard let trust = challenge.protectionSpace.serverTrust, SecTrustGetCertificateCount(trust) > 0 else {
completionHandler(.cancelAuthenticationChallenge, nil)
return
}
        if let serverCertificate = SecTrustGetCertificateAtIndex(trust, 0) {
                // pinnedCertificate = .....
                if serverCertificate == pinnedCertificate {
                     completionHandler(.useCredential, URLCredential(trust: trust))
                     return
               }
        }

        completionHandler(.cancelAuthenticationChallenge, nil)
    }
     let connection = HubConnectionBuilder(url: url)
                .withHttpConnectionOptions() { options in
                    options.accessTokenProvider = { ....accessToken.... }
                    options.authenticationChallengeHandler = challangeDelegate
                    options.headers += ......
                }
                .build()
            connection.delegate = self
            connection.start()

`

Thanks for the fix and for the example. If you don't mind I will add your example to the F.A.Q.

No problem, hope it will help someone. Thank you for checking this

Please create a new tag so it's easier for CocoaPods to handle new version. I can also put commit id but it's more elegant with tag. Thank you

I am planning a new release in a few weeks. If you need it sooner, please consider: https://github.com/sponsors/moozzyk?frequency=one-time&sponsor=moozzyk

I pushed version 0.9.2 to Cocoapods.


Improved Test Fixtures for Different Types of Data and Time Zones

Here, multiple changes have been made to the script with an aim of enhancing the fixtures that are used in data manipulation and analysis in the test.
First of all, the datetime_frame fixture was adjusted so that it generates a DataFrame with the index of DatetimeIndex type and four columns named ‘A’, ‘B’, ‘C’, ‘D’. This DataFrame now employs the use of np. random. default_rng(2). standard_normal to generate random float values which are more coherent and reproducible. The index is a daily index starting from “2000-01-01” with business day frequency which makes it a more realistic data for testing.
The float_string_frame fixture was modified to have a new column contain constant string values alongside columns that contain float type values. This improvement makes it possible to consider the test scenarios when the data is represented both numerically and categorically in one DataFrame. To make the DataFrames more similar to real world data, a unique string is used as the index.
The mixed_float_frame fixture was enhanced to contain different float types, including float32, float64, and float16. This change is useful to test operations where different float precisions are used and where cross types compatibility is necessary.
For integer data the mixed_int_frame fixture has been enriched with columns of different integer kinds: int32, uint64, uint8, int64. This addition facilitates the testing functions that deal with different integer size and type to ensure that there is enough set of integer-based data to validate.
Finally, the ‘timezone_frame’ fixture was incorporated to deal with time intervals of a different timezone. This fixture generates a DataFrame with some missing data, which is a common case in time zone transformations, and thus these data will be used in the next sections for testing purposes.
In general, these changes improve the script’s capability of producing and evaluating different types of data and formats, thus increasing its effectiveness in different data analysis and manipulation tasks.

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Tests added and passed if fixing a bug or adding a new feature
[ ] All code checks passed.
[ ] Added type annotations to new arguments/methods/functions.
[ ] Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

This update improves the existing test fixtures used for creating DataFrame in our testing suite. The changes include:

Datetime DataFrame: Enhanced fixture to form a DataFrame with a DatetimeIndex, floats as column and well defined date range. This fixture will assist in testing of time series data and operations that include dates.

Float and String DataFrame: Added a fixture which contains float and string values with unique string index. This enhancement result in improved support for data of mixed type when used in tests.

Mixed Float Types DataFrame: Added a fixture for DataFrames with different floats including float16, float32 and float64. This is useful in test scenarios where there is need to have different floating point precision.

Mixed Integer Types DataFrame: Extending the fixture for the tests involving DataFrames with various integer types such as int32, uint64, uint8 and int64. This is useful in testing operations which involve different integer data types.

Timezone-Aware DataFrame: Defined a fixture which contained date_range Series with different time zones and how to deal with missing values (NaT). This is very useful for testing Timezone aware operations and data management in case of Time Series.

All of these updates are intended to offer an enlarged suite of test fixtures that address an extensive range of data types and conditions that will increase the stability and dependability of the test.
Impact
These improvements will help to improve the capability to test and verify some data manipulation and analytical operations especially those involving data of different types and timezone operations.


Added support for showing clock in different timezones

New optional config parameter: timezone where value can be any of the documented ones: http://momentjs.com/timezone/docs/ (example: America/Toronto)
New dependency: moment-timezone
Some errors are shown due to missing api, but it works
Future development idea: Show sun/moon icon based on whether it is night or day

NOTE: I'll update the mozaik-ext-time once the extensibility branch starts to work.

@juhamust If you use the mozaik demo repo as a base, you can make the mozaik-ext-* modules work.
There is already a repo/npm module for this https://github.com/plouc/mozaik-ext-time & https://www.npmjs.com/package/mozaik-ext-time.
I like the idea of having the sun/moon or swiching color theme accordingly.
However I do not really understand the need for the API.

Yes, I'm sure there is something in the changeset that can be left out: I somehow got into an understanding the mixin is needed in order to get parameters from the config.js but apparently that is not the case?
I'd had some problems with mozaik-demo earlier, but now it seems to start ok (or maybe it was some environmental issue): I'll rework the PR against the mozaik-ext-time, then.

The mixin is useful if you want to plug your widget to the client, all parameters except type, 'rows, columns, x, y` are passed down as props to your component.
It's true that the demo wasn't very stable, but I was able to build the same dashboard as the previous one today using only npm modules and it worked, be sure to update the widgets frequently if you play with it.

Re-created the PR against mozaik-ext-time with some additional improvements: https://github.com/plouc/mozaik-ext-time/pull/1
Thus, this PR can be closed.


chore: moved missing runtime deps

Moved devDependencies that are actually used during runtime. Lack of it causes apps that are using this library to fail due to missing dependencies. Without this fix it works on developer machine.
Haven't tested it that way (it failed when I deployed app to AWS Lambda) is to use npm install --production on app that uses dynamodb-onetable locally. I have verified (manually and on limited scope) that this change helps.

Thanks, looks good.