feat: add user sequence table

Tickets addressed: AERIE-1982
Review: By commit
Merge strategy: Merge (no squash)

Description

Add first-draft of user_sequence table for storing user-defined sequences for 0.13.0

Verification
Test the user_sequence table is added to the commanding database
Future work
Possible renaming:

aerie_commanding database to aerie_sequencing
sequence table to expansion_sequence

I was thinking about this for a couple of minutes and I realized we never talked about user-defined sequences with respect to their sequence ID. On the command expansion side, we make those unique but on the user side, they can create multiple sequences for a sequence ID with no sequence ID checking.
Use Case 1:
Create a new sequence with seqID A, save - no issue
I want to update the sequence, save - no issue
Use Case 2:
Create a new sequence with seqID A, save - no issue
I create a new sequence with seqID B, save - no issue
Use Case 3:
Create a new sequence with seqID A, save - no issue
I create a brand new sequence with seqID A, save - Problem: two sequences with the same seqID
This can get more complicated as there can be different states a sequence can be in ( Draft, Accepted, Rejected, etc.)
I am not saying we should address this in this ticket but something we should have a meeting about in the future.

I was thinking about this for a couple of minutes and I realized we never talked about user-defined sequences with respect to their sequence ID. On the command expansion side, we make those unique but on the user side, they can create multiple sequences for a sequence ID with no sequence ID checking.
Use Case 1:
Create a new sequence with seqID A, save - no issue I want to update the sequence, save - no issue
Use Case 2:
Create a new sequence with seqID A, save - no issue I create a new sequence with seqID B, save - no issue
Use Case 3:
Create a new sequence with seqID A, save - no issue I create a brand new sequence with seqID A, save - Problem: two sequences with the same seqID
This can get more complicated as there can be different states a sequence can be in ( Draft, Accepted, Rejected, etc.)
I am not saying we should address this in this ticket but something we should have a meeting about in the future.

Sequence IDs are very specifically NOT something we are managing. That is on the missions to determine. The unique ID for sequences we have are disconnected from the seqid and in fact the seqid isn't necessarily part of what is tracked by AERIE at all. I would think the workflow would haver the seqid somewhere in the name field, but ultimately, the seqid is determined by the seqid property on the sequence object in the body of the sequence file.

I was thinking about this for a couple of minutes and I realized we never talked about user-defined sequences with respect to their sequence ID. On the command expansion side, we make those unique but on the user side, they can create multiple sequences for a sequence ID with no sequence ID checking.
Use Case 1:
Create a new sequence with seqID A, save - no issue I want to update the sequence, save - no issue
Use Case 2:
Create a new sequence with seqID A, save - no issue I create a new sequence with seqID B, save - no issue
Use Case 3:
Create a new sequence with seqID A, save - no issue I create a brand new sequence with seqID A, save - Problem: two sequences with the same seqID
This can get more complicated as there can be different states a sequence can be in ( Draft, Accepted, Rejected, etc.)
I am not saying we should address this in this ticket but something we should have a meeting about in the future.

Sequence IDs are very specifically NOT something we are managing. That is on the missions to determine. The unique ID for sequences we have are disconnected from the seqid and in fact the seqid isn't necessarily part of what is tracked by AERIE at all. I would think the workflow would haver the seqid somewhere in the name field, but ultimately, the seqid is determined by the seqid property on the sequence object in the body of the sequence file.

You are right, I forgot we are not managing sequence ID and that a mission should do that. :P Let me close that can of worms and bury it.


293.remove usage of deprecated

Follow-up to #306, which added deprecation warnings to three methods, but we've been calling those allegedly deprecated methods internally. I failed to check for those usages, so I'm going around looking for where we've been using them.

Interface.get_os_interface(), which has a simple replacement in get_device_name(), so I replaced all calls accordingly.  Haven't actually tested this from a notebook, because I'm unsure what the replacements for the other two should be.

Node.set_ip_os_interface() is called by Interface.set_ip(), which itself should be deprecated.  I did not catch it in the previous pass because of the typo in comment ("Depricated" instead of "deprecated"), and I'm not sure what should replace either of these methods.

Node.add_vlan_os_interface() is called by Interface.config_vlan_interface() (which is not intended for API use), which is called by Slice.post_boot_config().  Again, I'm not sure what should replace Node.add_vlan_os_interface().

Help, @kthare10 and @paul-ruth? :-)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 6 (0.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 24.056%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

fabrictestbed_extensions/fablib/slice.py
0
1
0.0%

fabrictestbed_extensions/fablib/interface.py
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

fabrictestbed_extensions/fablib/slice.py
1
8.42%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1273

Relevant Lines:
4722

💛  - Coveralls


Webhook service upgrade selector should be AND if more than 1 label

Rancher versions: version 1.6.11-rc7
Steps:

Create 3 services with the labels:
Service1  foo=bar
Service2  foo2=bar2
Service3  foo=bar & foo2=bar2
Create a service upgrade webhook that has both foo=bar & foo2=bar2
Upgrade the service

Results:
It will upgrade Service3 and then randomly pick either Service1 or Service2.  It should only upgrade Service3

Version - v1.6.11-rc8
Verified fixed


Add ansible_ssh_private_key_file to the SSH test

We're waiting for the OpenStack VMs to be able to SSH into before
proceeding with the DNS playbook (because until 2.3 Ansible doesn't
handle that gracefully).
But if the private key for the SSH connection was only specified using
the --private-key argument to ansible-playbook, the test was
failing because it didn't take that possibility into the account.
Now it does.
Fixes #355

For this purpose, I'm using this with ansible 2.2. Wouldn't that be also applicable to you?
  - name: wait for the temp instance to come up
    wait_for:
      host: '{{ hostvars[prefix + "-tmp-instance"]["ansible_ssh_host"] }}'
      port: 22
      state: started

Thanks @pschiffe! I've tried wait_for (indeed, it's in there, too), but it doesn't always work -- as in, you can end up in a situation where sshd is up, but the login fails.
I think what happens is that that it's cloud-init's job to set up the pubkey to authorized_hosts and sometimes sshd comes up before that's done -- so you can connect to the port but the authentication will fail because the key is not in the right place yet.
Which is why there is a task that explicitly tries to SSH in.


Is v1.7 going to be available on npm?

I noticed a 1.7.2 tag a while ago, but there is no corresponding package on npm.

I think 1.7.3 will be the one available. the release in a the final stabilization phase, and should be available soon.

I'm also waiting for the 1.7.x release.


Create Initial Google Sheets App

Overview
This will likely need to be split into multiple tasks at some point. I'm just getting started here. I think it would be cool to eventually build the budget app with R and Shiny. However, I think it might be easier to start with Google Sheets. Additionally, it might make it easier to manually adjust the data tables if everything is in Google Sheets.
Useful links

2024 Budget
Budget app folder on Google Drive
DB Schema
Google Sheets GPT
Google Sheets: Test Query Function

Sheet types
I think I may end up with at least 4 different sheet types (and maybe I end up keep some of these in separate workbooks).

Development sheets: For testing and development notes.
Data sheets: For storing data. For example, payees and transactions.
UI sheets: The sheets I view and interact with. For example, dashboards and bill pay.
Worker sheets: Sheets that bridge data sheets and UI sheets. I don't interact with them directly, but they pull things together.

Other questions/ideas

I should also create a list here of what information each sheet contains at some point. Maybe add them as comments directly in the Google Sheet or in the DB schema.
I should make some tab coloring rules. Add them to the wiki.

Tasks

[x] Move the example data tables from the R/Shiny budget app repo to Google drive.
[x] Test importing transactions from USAA.
[x] Copy categories and subcategories from Quicken.
[x] Add all accounts from the 2024 budget to the Accounts sheet.
[ ] Use lookup to add current interest rate and current payment method to the accounts table.
[ ] Create a page that will tell me what is due given the following inputs: date, payee accounts table.
[ ] Figure out rules to categorize transaction categories.
[ ] Add details to the entity and accounts page.

2024-02-21

Working on the Dev Bills Due.
Tested out importing some transitions from USAA.
Add Quicken categories and subcategories to the Lists sheet.
Finish adding accounts to the accounts page.

2024-02-22

Working on the DB Schema

2024-03-01

Working on the Dev Bills Due sheet. Import one variable at a time.

Filling in the pay period stuff in the Accounts sheet so I can figure out the best way to make the appropriate rows appear.
Current thinking: Use the account_pay_period_manual column to set the pay period. Initially, I considered making this a calculated column based on due date. But, I sometimes like to shift  bills between pay periods manually. The value in this column will help determine if an account will appear or not when a given month and pay period are selected on the Dev Bills Due sheet.
Update schema when done.

2024-03-03

I left off working on the file called Test Select Rows By Pay Period.
At this point, I can select rows based on the following criteria:

The bill was created on or before the year and month selected using the selector. In other words, if it's June and I want to see what the bills looked like in February, I would choose February in the month selector. A bill that I didn't start paying until March wouldn't show up.
The bill is active (i.e., doesn't have a closed date). Although, I'm probably doing this in too simplistic of a way. Right now, it only checks to see if there is a closed date or not. It doesn't check to see if the account was closed on the date selected with the date selector, though. I need to add that functionality.
The pay period selected.

Next:

Tie the closed date (Accounts!C:C) to the date selected on Bill Pay.
Move payee selection code from Test Select Rows By Pay Period to Budget App Prototype.
Move on to working on pulling over the account balance (and other columns) after we have the list of payees for the selected year-month-period. I think we should do this in a separate Test file like we did with Test Select Rows By Pay Period.


Mindustry (client)

As requested in https://github.com/Calinou/scoop-games/issues/24 , https://github.com/Calinou/scoop-games/pull/27 brought Mindustry to scoop.
However, a) the json hasn't been updated in quite some time (the server binary has been)
b) it would maybe make more sense to provide the client via [Windows-64bit]Mindustry.zip from https://anuke.itch.io/mindustry ?
I don't know if direct linking to itch.io downloads is a thing though..

Fixed and updated mindustry.
itch.io downloads seem to be session-based, which is currently not supported by scoop.
But the only contain a java environment and an exe that just runs the same Mindustry.jar file.


Option to block indent arrays with 'mixed' multi-lining

Essentially, you currently have to choose between:
const SomeArray: &[usize] = &[1, 2, 3, 4, 5, 6, 7, 8,
                              9, 10, 11, 12, 13];

and
const SomeArray: &[usize] = &[
    1,
    2,
    3,
    4,
    5,
    6,
    7,
    8,
    9,
    10,
    11,
    12,
    13,
];

While I personally prefer the former, we use tabs at work and I'm not allowed spaces for visual indent (under pain of PR rejection). This is preventing me from using rustfmt at work, which is really annoying. If there was a "VisualNewLine" option that indented more like:
const SomeArray: &[usize] = &[
    1, 2, 3, 4, 5, 6, 7, 8,
    9, 10, 11, 12, 13,
];

it would mean that people who use tabs can indent arrays, since neither of the current options are satisfactory for users of tabs. Yeah, I know, I've tried convincing them to switch to RFC styling.

Edited the title for clarity - this is block indent, but with 'mixed' multilining (I don't know good terminology for the style of layout where we fit as many items on each line before line-breaking, rather than one item per line).


⚠ Bofrost.at has degraded performance

In 5bb54b4, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2083 ms

Resolved: Bofrost.at performance has improved in dbbe2b6 after 7 minutes.


In App Purchase Auto Buy on IOS

By definition, restore purchase will not be automatically invoked when uninstalling and reinstalling the app. but now IAP is automatic like in Project game Click Differences

Fixed in v2 automation  restore now affect only on Android


[Crashlytics] 'Crashlytics_Platform.h' file not found (macos)

Discussed in https://github.com/FirebaseExtended/flutterfire/discussions/7484

Originally posted by kostasoft December  7, 2021
The project is normally built for ios, but for macos it gives the following error.
I am laying out a screenshot from Xcode, it is well visible, which error and in which file appears.
The file pubspec.yaml contains the following code
...
  firebase_core: ^1.10.2
  firebase_messaging: ^11.2.0
  firebase_crashlytics: ^2.4.0
...

Again, the problem is only with the build of the project for MacOs.

I see the same behavior upon running plugin's official example on latest stable:
Running pod install...                                              3.9s
/Users/dhs/documents/fluttersdk/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_crashlytics-2.4.3/macos/Classes/FLTFirebaseCrashlyticsPlugin.m:6:9: fatal error: 'Crashlytics_Platform.h' file not found
#import "Crashlytics_Platform.h"
        ^~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
note: Using new build system
note: Building targets in parallel
note: Planning build
note: Constructing build description
** BUILD FAILED **

firebase_core: ^1.10.0
firebase_crashlytics: ^2.3.0

Although when I tried for the very first time, it compiled and built macOS app properly and launched, but for every subsequent tries, I started to get above error.
[✓] Flutter (Channel stable, 2.8.0, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    ! Flutter recommends a minimum Xcode version of 13.0.0.
      Download the latest version or update via the Mac App Store.
[✓] Chrome - develop for the web
[✓] VS Code (version 1.62.0)
[✓] Connected device (3 available)

! Doctor found issues in 1 category.

same

Upgraded to 2.2.4, still can't compile on MacOS
firebase_crashlytics: ^2.4.4

I have same issue, any workarounds until issue is solved?

Maybe manual modification of native iOS files, I'll try later today and comment in case of success.

I have same issue, any workarounds until issue is resolved?

Yes, just copy Crashlytics_Platform.h from iOS pod folder to macOS folder!

I have same issue, any workarounds until issue is resolved?

Yes, just copy Crashlytics_Platform.h from iOS pod folder to macOS folder!

Where is it located?

This is still not fixed. I just can't build my macOS app.

Yes, indeed. Still not fixed. But the solution from https://github.com/FirebaseExtended/flutterfire/issues/7558#issuecomment-997184425 works.

Yes, indeed. Still not fixed. But the solution from https://github.com/FirebaseExtended/flutterfire/issues/7558#issuecomment-997184425 works.

Yes its working on my local machine but what about CI/CD?
Im not sure if ios folder is available if you just want to build macos, probably not right?
If it is available you could copy as well even its annoying and can produce other bugs in the future.

While https://github.com/FirebaseExtended/flutterfire/issues/7558#issuecomment-997184425  did solve the import, I just get errors later on in the compilation, of "unknown receiver 'FIRAnalytics'; did you mean 'FIRCrashlytics'""
I'm using firebase_crashlytics: ^2.4.5
Here's a sample of the resulting errors:
--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:macOS, arch:x86_64, id:4C75388B-8D59-5986-BF55-2E2D0495D755 }
{ platform:macOS, name:Any Mac }
/Users/oththejoy/.pub-cache/hosted/pub.dartlang.org/firebase_analytics-9.0.5/macos/Classes/FLTFirebaseAnalyticsPlugin.m:85:6: error: unknown receiver 'FIRAnalytics'; did you mean 'FIRCrashlytics'?
    [FIRAnalytics logEventWithName:eventName parameters:parameterMap];
     ^~~~~~~~~~~~
     FIRCrashlytics
In module 'FirebaseCrashlytics' imported from /Users/oththejoy/Desktop/temp/MyApps/porridge/mobile/macos/Pods/Headers/Public/Firebase/Firebase.h:38:
/Users/oththejoy/Desktop/temp/MyApps/porridge/mobile/macos/Pods/FirebaseCrashlytics/Crashlytics/Crashlytics/Public/FirebaseCrashlytics/FIRCrashlytics.h:38:12: note: 'FIRCrashlytics' declared here
@interface FIRCrashlytics : NSObject

/Users/oththejoy/.pub-cache/hosted/pub.dartlang.org/firebase_analytics-9.0.5/macos/Classes/FLTFirebaseAnalyticsPlugin.m:85:19: error: no known class method for selector 'logEventWithName:parameters:'
    [FIRAnalytics logEventWithName:eventName parameters:parameterMap];
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/oththejoy/.pub-cache/hosted/pub.dartlang.org/firebase_analytics-9.0.5/macos/Classes/FLTFirebaseAnalyticsPlugin.m:87:6: error: unknown receiver 'FIRAnalytics'; did you mean 'FIRCrashlytics'?
    [FIRAnalytics logEventWithName:eventName parameters:nil];
     ^~~~~~~~~~~~
     FIRCrashlytics

What if I don't have the Crashlytics_Platform.h file on my machine?
How do I get it? And what directory should it go in for the Mac build?

While #7558 (comment) did solve the import, I just get errors later on in the compilation, of "unknown receiver 'FIRAnalytics'; did you mean 'FIRCrashlytics'""
I'm using firebase_crashlytics: ^2.4.5
Here's a sample of the resulting errors:
--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:macOS, arch:x86_64, id:4C75388B-8D59-5986-BF55-2E2D0495D755 }
{ platform:macOS, name:Any Mac }
/Users/oththejoy/.pub-cache/hosted/pub.dartlang.org/firebase_analytics-9.0.5/macos/Classes/FLTFirebaseAnalyticsPlugin.m:85:6: error: unknown receiver 'FIRAnalytics'; did you mean 'FIRCrashlytics'?
    [FIRAnalytics logEventWithName:eventName parameters:parameterMap];
     ^~~~~~~~~~~~
     FIRCrashlytics
In module 'FirebaseCrashlytics' imported from /Users/oththejoy/Desktop/temp/MyApps/porridge/mobile/macos/Pods/Headers/Public/Firebase/Firebase.h:38:
/Users/oththejoy/Desktop/temp/MyApps/porridge/mobile/macos/Pods/FirebaseCrashlytics/Crashlytics/Crashlytics/Public/FirebaseCrashlytics/FIRCrashlytics.h:38:12: note: 'FIRCrashlytics' declared here
@interface FIRCrashlytics : NSObject

/Users/oththejoy/.pub-cache/hosted/pub.dartlang.org/firebase_analytics-9.0.5/macos/Classes/FLTFirebaseAnalyticsPlugin.m:85:19: error: no known class method for selector 'logEventWithName:parameters:'
    [FIRAnalytics logEventWithName:eventName parameters:parameterMap];
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/oththejoy/.pub-cache/hosted/pub.dartlang.org/firebase_analytics-9.0.5/macos/Classes/FLTFirebaseAnalyticsPlugin.m:87:6: error: unknown receiver 'FIRAnalytics'; did you mean 'FIRCrashlytics'?
    [FIRAnalytics logEventWithName:eventName parameters:nil];
     ^~~~~~~~~~~~
     FIRCrashlytics

I also get the same error.
Here is my flutter doctor output:
[✓] Flutter (Channel master, 2.13.0-0.0.pre.108, on macOS 12.3 21E5227a darwin-arm, locale en-DE)
[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
[✓] Chrome - develop for the web
[!] Android Studio
    ✗ Unable to find bundled Java version.
[✓] Android Studio (version 2021.1)
[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
[✓] VS Code (version 1.66.0-insider)
[✓] Connected device (2 available)
    ! Error: iPhone is not connected. Xcode will continue when iPhone is connected. (code -13)
[✓] HTTP Host Availability

Hey folks, I've just tested this against the latest firebase_crashlytics and did not come across this issue. It does appear this file is symlinking correctly. Thanks.


Please release version with fixes

Hello @plashchynski
Last year I made this pull request https://github.com/plashchynski/rgb/pull/4
Could you please release a version ex: 0.1.1 that contains that fix so I don't need to install via a commit hash?
Many thanks for considering my request,
Anthony

Hello @anthony0030, thank you for your contribution. I've just released a new version 0.1.2 with your changes

Thank you 😄


Binding an existing route to an app does not close the dialog

The user is left on the same page and is not taken back to the application page.
Also, button is labelled 'Submit' which is inconsistent with other dialogs.

This is fixed


[Feature]: Add unmerge option when trading with another player

Describe the feature
When activating the "Merge Stacks" and "Unmerge at Shop" option it currently only unmerges the stacks when opening a shop or when sending a mail. I'd like to have the same feature when trading with another player. Currently I can't unstack items and trade a specific amount of flasks, potions etc. when trading with a player.
Describe the implementation
Basically just another checkbox here:

"Unmerge when trading". Or just add the unmerge when trading functionality to "Unmerge at Shop".

That's odd -- I that should work for trading with humans too. I'll look into it.

Hm, just tested, it works on my end. What version of WoW, and what version of betterbags?

Hi, sorry, I made a mistake. It actually works perfectly for me. It was Adibags where it didn't work and for some reason I assumed it was the same for BetterBags 😅


Cannot open source files from within file manager (Thunar)

Type: Bug
After the most recent update when I double click source files (*.php, *.js, etc.) a new instance of VS code is spawned and nothing is opened, neither in the already open vs code instance nor in the new one.
Files could be opened by dropping them on VS code window and by using the explorer as well as using search results.
My dev box has Xubuntu 20.04 and the file manager I use is Thunar.
Here is the version information from the "About" dialog:
Version: 1.89.0
Commit: b58957e67ee1e712cebf466b995adf4c5307b2bd
Date: 2024-05-01T02:08:25.066Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Linux x64 5.4.0-177-generic
VS Code version: Code 1.89.0 (b58957e67ee1e712cebf466b995adf4c5307b2bd, 2024-05-01T02:08:25.066Z)
OS version: Linux x64 5.4.0-177-generic
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8500Y CPU @ 1.50GHz (4 x 2949)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
2, 2, 2

Memory (System)
7.65GB (3.81GB free)

Process Argv
--unity-launch --crash-reporter-id e0cccab9-1704-45d5-9a6d-97943ca924da

Screen Reader
no

VM
0%

DESKTOP_SESSION
xubuntu

XDG_CURRENT_DESKTOP
XFCE

XDG_SESSION_DESKTOP
xubuntu

XDG_SESSION_TYPE
x11

Extensions (10)

Extension
Author (truncated)
Version

vscode-intelephense-client
bme
1.10.4

prettier-vscode
esb
10.4.0

copilot
Git
1.187.0

copilot-chat
Git
0.15.2024043005

todo-tree
Gru
0.0.226

remote-ssh
ms-
0.110.1

remote-ssh-edit
ms-
0.86.0

remote-explorer
ms-
0.4.3

material-icon-theme
PKi
5.1.0

php-debug
xde
1.34.0

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes516:30244333
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
2e7ec940:31000449
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
ccp2r3:30993541
dsvsc020:30976470
pythonait:31006305
chatpanelc:31018788
dsvsc021:30996838
jg8ic977:31013176
pythoncenvpt:31022790
dwnewjupytercf:31035177

This does not sound like a bug in VS Code but an issue with your setup, but leaving this issue open to see if others hit it as well.

If there's something I can do to test which one is the case, I am more than willing to try.
I could think of one test, which is not conclusive but seems to suggest the issue is related to VS Code:
I changed the Open With association of .js files from Visual Studio Code to Sublime Text. Double clicking .js files opened them in Sublime Text without an issue. I then changed the association back to VS Code and the issue was back.
I repeated that with Mousepad with the same results (working with Mousepad and failing with VS Code.)

So you cannot reproduce when you install 1.88.1?
VS Code Build: e170252f762678dec6ca2cc69aba1570769a5d39

cli-alpine-arm64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/vscode_cli_alpine_arm64_cli.tar.gz
cli-alpine-x64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/vscode_cli_alpine_x64_cli.tar.gz
cli-darwin-arm64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/vscode_cli_darwin_arm64_cli.zip
cli-darwin-x64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/vscode_cli_darwin_x64_cli.zip
cli-linux-arm64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/vscode_cli_linux_arm64_cli.tar.gz
cli-linux-armhf: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/vscode_cli_linux_armhf_cli.tar.gz
cli-linux-x64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/vscode_cli_linux_x64_cli.tar.gz
cli-win32-arm64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/vscode_cli_win32_arm64_cli.zip
cli-win32-x64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/vscode_cli_win32_x64_cli.zip
darwin: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/VSCode-darwin.zip
darwin-arm64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/VSCode-darwin-arm64.zip
darwin-universal: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/VSCode-darwin-universal.zip
linux-arm64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/code-stable-arm64-1712770481.tar.gz
linux-armhf: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/code-stable-armhf-1712770492.tar.gz
linux-deb-arm64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/code_1.88.1-1712770538_arm64.deb
linux-deb-armhf: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/code_1.88.1-1712770545_armhf.deb
linux-deb-x64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/code_1.88.1-1712771838_amd64.deb
linux-rpm-arm64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/code-1.88.1-1712770627.el8.aarch64.rpm
linux-rpm-armhf: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/code-1.88.1-1712770623.el8.armv7hl.rpm
linux-rpm-x64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/code-1.88.1-1712771932.el8.x86_64.rpm
linux-snap-x64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/code-stable-x64-1712773445.snap
linux-x64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/code-stable-x64-1712770462.tar.gz
win32-arm64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/VSCodeSetup-arm64-1.88.1.exe
win32-arm64-archive: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/VSCode-win32-arm64-1.88.1.zip
win32-arm64-user: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/VSCodeUserSetup-arm64-1.88.1.exe
win32-x64: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/VSCodeSetup-x64-1.88.1.exe
win32-x64-archive: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/VSCode-win32-x64-1.88.1.zip
win32-x64-user: https://vscode.download.prss.microsoft.com/dbazure/download/stable/e170252f762678dec6ca2cc69aba1570769a5d39/VSCodeUserSetup-x64-1.88.1.exe

I'm also experiencing the same issue with the Dolphin file manager after the last update, opening a file with the "Open file" dialog o dragging it to an opened Code window works fine.
Code is installed through the snap package manager.
These are the information displayed in the About dialog:
Version: 1.89.0
Commit: b58957e67ee1e712cebf466b995adf4c5307b2bd
Date: 2024-05-01T02:08:25.066Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Linux x64 6.5.0-28-generic snap

Please downgrade and see if its not reproducible then: https://github.com/microsoft/vscode/issues/212125#issuecomment-2097789123

I can confirm that reverting Code with the "snap revert" command resolved the issue, the current installation details are the following:
Version: 1.88.1
Commit: e170252f762678dec6ca2cc69aba1570769a5d39
Date: 2024-04-10T17:34:12.840Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Linux x64 6.5.0-28-generic snap

Interesting, can you add a --verbose to the command line invocation or configure VS Code runtime arguments and add:
"log-level": "trace"

And then attach the logs folder with a clean startup via your finder.

@majid4466 are you also on Snap?
Does this reproduce when not using Snap but Deb?

Yes, I have VS Code installed as a Snap package.
I am hesitant to experiment with my development machine by uninstalling VS Code and testing the deb version. If I get the chance to install the deb version on another machine I will report the result here.

Thanks

But it would still be interesting to get at the verbose logs when it works vs when it does not work.

I tried to reproduce the issue on another workstation and a virtual machine but the snap package 1.89.0 works fine.
It seems to be an issue with the snap refresh process and not with the version itself.
If I find some time today I will retry to upgrade Code again on the pc that presented the issue and let you know the result.

Yeah I am not expecting a regression in VS Code but a setup/install issue.

I attached the log generated by opening a file from file manager with both Code versions.
version-1.88.1-logs.zip
version-1.89.0-logs.zip

Yeah, as expected, in version 1.89 the instance receives the following argument for opening:
args: {"_":["/home/fabio/Downloads/New Folder/test.txt"]

And in 1.90:
args: {"_":[]

Moving to Daniel and Deepak as this seems Snap install related, I doubt we changed something how we create the Snap file, but I am not sure either.

I have the same issue on Gnome Nautilus, double click on the file in the file manager launches a new empty instance of VSCode. I'm using Arch and VSCode is installed through AUR.
Version: 1.89.1
Commit: dc96b837cf6bb4af9cd736aa3af08cf8279f7685
Date: 2024-05-07T05:16:23.416Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Linux x64 6.8.9-arch1-2

have the same issue on Gnome Nautilus, double click on the file in the file manager launches a new empty instance of VSCode. I'm using Arch and VSCode is installed through AUR.
same for me

Same problem with thunar file manager on ubuntu:
Version: 1.89.1
Commit: dc96b837cf6bb4af9cd736aa3af08cf8279f7685
Date: 2024-05-07T05:16:23.416Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Linux x64 5.15.0-76-generic
Installed through the deb package from apt repo http://packages.microsoft.com/repos/code stable main.

I can confirm that reverting Code with the "snap revert" command resolved the issue, the current installation details are the following:

After downgrading to 1.89.0 the issue still exists:
# downgrading code from 1.89.1-1715060508 to 1.89.0-1714530869
sudo apt install code=1.89.0-1714530869

First buggy version (.deb)
Version: 1.89.0
Commit: b58957e67ee1e712cebf466b995adf4c5307b2bd
Date: 2024-05-01T02:08:25.066Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Linux x64 5.15.0-76-generic

A further downgrade to 1.88.1 fixes the problem:
# downgrading code from 1.89.0-1714530869 to 1.88.1-1712771838
sudo apt install code=1.88.1-1712771838

Last working version (.deb)
Version: 1.88.1
Commit: e170252f762678dec6ca2cc69aba1570769a5d39
Date: 2024-04-10T17:34:12.840Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Linux x64 5.15.0-76-generic

Same problem with the latest version 1.90.2:
Version: 1.90.2
Commit: 5437499feb04f7a586f677b155b039bc2b3669eb
Date: 2024-06-18T22:33:48.698Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Linux x64 5.15.0-76-generic
@bpasero: Any news on that?

Based on the affected versions, seems like a regression from https://github.com/microsoft/vscode/commit/0da22a226000adc62cf7b8a83b045668fb8a9296

The issue still exists on the latest version:
Version: 1.93.1
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.15.0-76-generic
@Tyriar  Any news or workarounds for this?

I removed the --unity-launch flag back in April but did not realize it had to be substituted with another flag such as --new-window.
I'll put up a PR soon.
Additional verification steps once a new Insiders is out: https://github.com/microsoft/vscode/issues/21133#issuecomment-282107689

Based on the latest posts here and pointing to a regression from 0da22a2 I found a workaround. I am on an Xubuntu machine with XFCE and Whiskers menu. Here is what I did:

I found the VS code's icon in Whiskers menu, right clicked it and from the selected "Edit Application ..."
In the "Edit Launcher" window I had this in the "Command" field: /usr/share/code/code --unity-launch %F
I removed the --unity-launch flag and saved.

That was it! The issue gone.

Thanks @majid4466,
In that case, it sounds like the current post-install script does not successfully update the .desktop file.
As for the "Command" field, does changing it to /usr/share/code/code --new-window %F work as well as or better than /usr/share/code/code %F?

Changing the command to /usr/share/code/code --new-window %F results in having each opened file open in a new window not as a tab in the already opened VS Code instance. So, in my case at least I am better off without it.

I manually downloaded and installed VS Code 1.87 with sudo dpkg -i <package-name>.deb on Ubuntu (not Xubuntu), then used sudo apt-get update && sudo apt-get upgrade code to upgrade it to 1.93. I confirmed that the code.desktop file did not have the --unity-launch flag after.
@majid4466 my current assumption is that your update process left the --unity-launch flag in the code.desktop file or another file involved in launching code. I'm wondering what steps you use to update the code package?
@leukipp do you also see a --unity-launch flag in your code.desktop file? If yes, does removing that flag help? The code.desktop file in my case is under /usr/share/applications.

@rzhao271
I updated code the last time to version 1.93.1 on 2024-09-13 via apt. The current .desktop file(s) looks like this:
ls -lah /usr/share/applications/code*

-rwxrwxr-x 1 root root 708 Sep 11 20:06 /usr/share/applications/code.desktop
-rw-rw-r-- 1 root root 312 Sep 11 20:06 /usr/share/applications/code-url-handler.desktop

cat /usr/share/applications/code*

[Desktop Entry]
Name=Visual Studio Code
Comment=Code Editing. Redefined.
 Redefined.
GenericName=Text Editor
Exec=/usr/share/code/code --open-url %U
Icon=vscode
Type=Application
NoDisplay=true
StartupNotify=true
Categories=Utility;TextEditor;Development;IDE;
MimeType=x-scheme-handler/vscode;
Keywords=vscode;

No --unity-launch flag and the executable points to /usr/share/code/code which is a binary file.

When running code from the terminal, which gives:
which code

/usr/bin/code

ls -lah /usr/bin/code*

lrwxrwxrwx 1 root root  24 Sep 13 09:00 /usr/bin/code -> /usr/share/code/bin/code

This is a symlink and the executable points to /usr/share/code/bin/code which is a shell script.

Running /usr/share/code/code SOMEFILE.txt or /usr/share/code/bin/code SOMEFILE.txt from the terminal opens the file in a new tab as expected.
Double clicking the file opens an empty code window and the process output shows:
ps -fC code

UID          PID    PPID  C STIME TTY          TIME CMD
user      107051       1  1 02:55 ?        00:00:01 /usr/share/code/code --unity-launch /home/user/SOMEFILE.txt

The --unity-launch flag is present there. So somewhere it must still be added, which is likely the root cause of the problem.

Is the ~/.local/share/applications folder managed by Xubuntu or by hand? I'm unable to find a code pointer where the VS Code Debian package post-install script writes to that directory.
I can document on the VS Code website the issue of code.desktop files outside of $XDG_DATA_DIRS/applications not being updated automatically, but I'd like the issue to be filed upstream if it is specific to a distribution's package update process.


Upgrade Git.

Github Actions has a limitation: the checkout action does not leave a functional Git repository within the Docker container if you're using a 1.x Git release.
Upgrading to a more recent Git 2.x release fixes this.
Couple points to consider:

Hard-coding that yum repo's URL seems bad -- is there a more future-proof way to do this?
Are other ASWF projects hitting this problem? Should we consider merging this into the upstream image?

I'll let Aloys decide, but it looks like this may be a dupe of PR #33 although that PR tried to solve the issue at the ci-common level. That PR pulled an RPM from wandisco.com , you are using endpoint.com which both seem like somewhat ad-hoc locations to be pulling RPMs from. The Software Collections repos may be a more canonical location to install an updated Git from, and it looks like it has a Git 2.18 RPM package available. Furthermore, the script install_yumpackages.sh already adds the SCLo yum repository. So perhaps removing git from the first list of RPM packages to install and moving that after the SCLo repository has been added and calling yum install -y rh-git218 would fix this for the ci-common container and thus all other containers derived from it?

Thanks Brian! I like JF's idea, we had that #33 issue open for a while, using the rh-git218 in install_yumpackages.sh would be great!

Thanks all! Sounds good to me.
I updated the PR to use the method JF suggested.
Note that even with this new method, Git 1.x is still installed and you need to use the scl_source to select the newer version. I've baked that into the image but it should be possible to switch back to the older version downstream, if needed.

Looks good, thanks Brian!
It would be great if you could add a test there: https://github.com/AcademySoftwareFoundation/aswf-docker/blob/master/scripts/tests/[1-2]/test_common.sh to check the git version in the container (and catch potential future regressions).
Once done and working, we can merge your PR, then I'll have to update all the versions of all the images in the versions.yaml file and update the changelog. Finally I'll create all the github releases to deploy the new images... Should be a fairly painless process but it will take me a few hours over the weekend. And it will be my first large scale docker image rebuild with the new github release process...

Sure thing -- tests have been added now and are passing.

I've just did a pre-release of new aswftesting/ci-opencue images there https://github.com/aloysbaillet/aswf-docker/actions?query=workflow%3ARelease
Would you like to try them before I roll this out further?

Hi @bcipriano I've released the proper aswf/ci-opencue yesterday, are they working fine for you?

@aloysbaillet I just pulled aswf/ci-opencue:2019 and aswf/ci-opencue:2020, and in both of those images Git 1.8 is still the default version. Should I be pulling a different tag?

I've just noticed the same problem with aswf/ci-usd today... I was expecting this to work I'll try to find out more.

OK I actually only released aswftesting/ci-opencue images by mistake, I've now released the aswf/ci-opencue images as well (see https://github.com/AcademySoftwareFoundation/aswf-docker/actions?query=workflow%3ARelease )!
One thing I noticed though is that the GitHub checkout action doesn't detect this git version, even if it is definitely there... It only finds the /usr/bin/git one which means it still can't do a proper git clone :-(

Great. Latest ci-opencue version is up to date now, when I pull and exec that image locally Git 2.x is the default version.

One thing I noticed though is that the GitHub checkout action doesn't detect this git version

Yeah, I'm seeing the same behavior on Github Actions; it seems that the PATH modifications done by scl_source are either ignored or don't work for some reason. In addition, running scl_source as a step prior to doing the code checkout mysteriously fails. I missed this during initial testing.
You can use work around this by using Github Actions commands to modify PATH and LD_LIBRARY_PATH -- here's a draft PR which does that. I have those paths hardcoded in that example workflow but I'm sure there that could be improved to programmatically determine the paths instead. Still, it's not ideal.
The initial version of this PR (the one that used packages.endpoint.com) did not have this limitation, because it doesn't rely on modifying PATH or on the user profile, it just installs the new Git over the existing one. Might be worth reconsidering that kind of approach.

That's good news, thanks. I'm tempted to try the repo maintained by LF that Andrew mentioned: https://github.com/iusrepo/git224


SQLITE_ERROR: cannot start a transaction within a transaction

Describe the bug
If 2 inserts/updates are run in parallel the SQLITE_ERROR: cannot start a transaction within a transaction is thrown.
It may happen if 2 operations are run asynchronously and not awaited or within a Promise.all. It's extremely susceptible in electron, but I have noticed it in web as well.
The following errors occur:

Error: Error invoking remote method 'CapacitorSQLite-execute': Execute failed: ExecuteSQL: ExecuteSQL: BeginTransaction: SQLITE_ERROR: cannot start a transaction within a transaction
Error: Error invoking remote method 'CapacitorSQLite-execute': Execute failed: ExecuteSQL: ExecuteSQL: CommitTransaction: SQLITE_ERROR: cannot commit - no transaction is active : RollbackTransaction: SQLITE_ERROR: cannot rollback - no transaction is active

To Reproduce
Have multiple database operations run under a await Promise.all([ ... ]) in electron.
Expected behavior
The package should handle waiting a transaction to finish before another one starts
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: windows 10

@CosminCraciun you right multiple transactions is not implemented. Can you share an example with await Promise.all()

@CosminCraciun The sqlite transactions are going so fast especially with Electron that you can manage to do them sequentially. Sqlite does not provide a queuing transactions manager and anyhow if it was existing it will run transaction one by one.

@jepiqueau I managed to provide an example on the web version as well.
I understand, but the issue of colliding transactions will still exist, even unintentional. If an user event triggers a transaction, in the same time as some other service does some background work (for example some sort of synching might be done in the app).
I've created a repo with a simple example https://github.com/CosminCraciun/parallel-transactions

@CosminCraciun i will have a look to your repo

@CosminCraciun if you do this
        await Promise.all([
            await this.test('table1'),await this.test('table2'),
        ])

and
         await Promise.all([
          console.log(`t1 count: ${await this.getCount(this.t1)}`), console.log(`t2 count: ${await this.getCount(this.t2)}`)
         ])

where getCount
    private async getCount(tableName: string) {
      return (await this._db!.query(`Select Count(*) as count from ${tableName};`)).values![0].count;
    }

it works now is it going faster than
        await this.test(this.t1)
        await this.test(this.t2)
        const res1 = await this._db!.query(`Select Count(*) as count from ${this.t1};`),
        const res2 = await this._db!.query(`Select Count(*) as count from ${this.t1};`)

        console.log(res1.values![0].count);
        console.log(res2.values![0].count);

i did not test i you test it with 10000 items and measure the execution  time  revert to me the result

The problem with
 await Promise.all([
            await this.test('table1'),await this.test('table2'),
        ])

It defeats the purpose of the Promise.all, as the await forces it to run sequentially. The Promise.all won't get a list of Promises anymore.
I have run some tests as you suggested, but haven't seen any differences in times. Which makes sense, as both run sequentially.
The only difference I saw is in some kind of db warmup... as if I run in the same run 2 tests, the second one is faster, no matter what the second test is.
Test results for 10 000 inserts:

Promise.all with await inside: 5606 ms
Pure sequential: 5742
But repeating the tests they seem to converge, towards an average.

Are there any foreseeable plans of implementing a queuing transactions manager?

@CosminCraciun i have been googling again and see that we can use the Write-Ahead Logging (WAL). so i implemented in angular-parallel-access. In fact Android is handling it automatically not the others platforms so for these ones i use PRAGMA journal_mode=WAL; and run the db.execute and db.run commands without transaction enable. Seems to work. Can you test it more and confirm to me if it works as you expect.

Yes! It now it works as expected.
Thank you for your help.
Will this setting be included in a future version of the package?

@CosminCraciun What the good things about PRAGMA is that it is a SQLite command so nothing to do in the plugin itself it is there already

Great! I was thinking more that maybe the plugin could activate it automatically during the init phase, so you have more or less the same interaction without caring if you are on android or not.
Thanks a lot for your help. Ant thanks for maintaining this library!

@CosminCraciun thanks for your comments and to bring this to my attention. I do not think i will do the initialisation in the plugin as some developers will prefer the old and secure transaction way. Since the plugin exists you are the first and the  only one asking for this. What is nice is you can do parrallel access if you whish without impacting the code. You just have to know about the particularity of Android  and manage it in your app code.

Had the exact same issue in a work project where log messages were inserted into the database at the same time as other queries were run.
Just to be clear: Has this method without transactions enabled any downside? From your comments in the issue here I can't see anything related to this question.
And could you include the solution somewhere in the documentation so others will find this easier? I was googling way too long to find this issue.

Had the exact same issue in a work project where log messages were inserted into the database at the same time as other queries were run.
Just to be clear: Has this method without transactions enabled any downside? From your comments in the issue here I can't see anything related to this question.
And could you include the solution somewhere in the documentation so others will find this easier? I was googling way too long to find this issue.

Exact same thing for me. I could create a PR. I just don't know where this should be added. Maybe here:

? I think this should be as visible as possible. I am sure I am not the only one with @mtnair that searched very long until we found this. The repository which shows how to use WAL is great though! I could add a section and then add some explanations for what to add and quote the repository.
I think placing inside API.md would not be where users would be searching for something like this? But maybe it's just me as a rather unadvanced programmer


Added a very simple PG in Physics Forces

Hi core great contributors!
I learned Havok plugin and found no simple examples in "Forces" section.
My idea is that showing simple PGs helps for BJS beginners.
I'm very glad if you review my added PGs and any feedback would welcome. Thanks for taking your time.

thanks, just waiting for some of our physics ppl to review before merging :-)

Added my changes and removed the images @RaananW it's ready to merge


nwg-panel: init at 0.3.2

Motivation for this change
nwg-panel is a customizable panel for Sway.
cc: https://github.com/nix-community/nixpkgs-wayland/issues/274
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thanks for the review @SuperSandro2000!

@berbiche please resolve the merge conflict.

@SuperSandro2000 sorry, it should be good to go now


Exception when adding multiple Android PushDeviceToken objects with the same token

We're most likely seeing this exception because of https://github.com/zulip/zulip-mobile/issues/2128.
What I suspect is happening is the flurry of duplicate requests to register for push notifications at the same time end up racing with each other and trying to create duplicate entries.
However, I think there's a deeper bug here: if a user has accounts with multiple organizations on zulipchat.com, it appears that the Android app will use the same token for each of those apps.  So I think we need to change the unique constraint on token in the PushDeviceToken model to instead be a unique constraint on (token, realm_id) (or maybe just not exist, since there are testing reasons, one might want to have multiple accounts in the same realm and access both from a mobile device).
We got rid of a similar issue for the push bouncer in 735b49e505112798dbd4f7f6380b0cf0eecc40d8, though I think that fix probably shares this problem of multiple realms hosted on the same RemoteZulipServer installation; that's just a lot less common than the zulipchat.com case.
Traceback (most recent call last):
  File "/home/zulip/deployments/2018-03-23-17-37-15/zulip-py3-venv/lib/python3.5/site-packages/django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/zulip/deployments/2018-03-23-17-37-15/zulip-py3-venv/lib/python3.5/site-packages/django/views/decorators/csrf.py", line 58, in wrapped_view
    return view_func(*args, **kwargs)
  File "./zerver/lib/rest.py", line 124, in rest_dispatch
    return target_function(request, **kwargs)
  File "/home/zulip/deployments/2018-03-23-17-37-15/zulip-py3-venv/lib/python3.5/site-packages/django/views/decorators/csrf.py", line 58, in wrapped_view
    return view_func(*args, **kwargs)
  File "./zerver/decorator.py", line 508, in _wrapped_func_arguments
    return rate_limit()(view_func)(request, profile, *args, **kwargs)
  File "./zerver/decorator.py", line 716, in wrapped_func
    return func(request, *args, **kwargs)
  File "./zerver/decorator.py", line 409, in _wrapped_view_func
    return view_func(request, *args, **kwargs)
  File "./zerver/lib/request.py", line 174, in _wrapped_view_func
    return view_func(request, *args, **kwargs)
  File "./zerver/views/push_notifications.py", line 44, in add_android_reg_id
    add_push_device_token(user_profile, token, PushDeviceToken.GCM)
  File "./zerver/lib/push_notifications.py", line 366, in add_push_device_token
    ios_app_id=ios_app_id))
... (25 more lines of internal Django junk omitted)
django.db.utils.IntegrityError: duplicate key value violates unique constraint "zerver_pushdevicetoken_token_key"

In both GCM and APNs, the token belongs to the (device, app) pair, so it's absolutely correct that the Zulip app on a given device will use the same token for each Zulip account it logs into.
(Currently the app actually attempts to maintain just one account having a token for it at a time. We should fix that, but it won't do much good until this server-side change is made too.)

or maybe just not exist, since there are testing reasons, one might want to have multiple accounts in the same realm and access both from a mobile device

Yep, I think this is the right result.
A unique constraint that would actually be appropriate would be on (user_id, kind, token) for PushDeviceToken, and (server_id, user_id, kind, token) for RemotePushDeviceToken. (Or it'd probably be fine in practice without kind, but in principle token is namespaced by kind so this seems less likely to cause confusion.) That is: for a given user, on a given install of the app, there's just one record.
Relatedly, this logic is quite broken, and even more convoluted than it looks:
    # If another user was previously logged in on the same device and didn't
    # properly log out, the token will still be registered to the wrong account
    PushDeviceToken.objects.filter(token=token_str).exclude(user=user_profile).delete()

    # Overwrite with the latest value
    token, created = PushDeviceToken.objects.get_or_create(user=user_profile,
                                                           token=token_str,
                                                           defaults=dict(
                                                               kind=kind,
                                                               ios_app_id=ios_app_id))
    if not created:
        logging.info("Existing push device updated.")
        token.last_updated = timezone_now()
        token.save(update_fields=['last_updated'])
    else:
        logging.info("New push device created.")

It turns out the Django get_or_create does two separate queries -- first SELECT, then INSERT -- so combined with the delete above, this is doubly racy.
Starting with PostgreSQL 9.5 (in xenial), we could fix this approach to work correctly by using INSERT ... ON CONFLICT DO UPDATE.
But actually I don't see the point; all we're doing then is bumping last_updated, just to record the duplicate registration. I don't really want a last_updated anyway, as the duplicates are just noise; I'd be more interested in a date_created. And perhaps a last_seen or something for the last time we actually sent this device a notification (and didn't get told by GCM/APNs that it was gone and we should forget it.)
So with the appropriate unique constraint, and if we migrate last_updated to date_created, this becomes just
  try:
    PushDeviceToken.objects.create(...)
  except IntegrityError:
    pass

and makes much more sense.


Allow case-insensitive sorting in TdDataTableService

Feature Request
Screenshots or link to CodePen/Plunker/JSfiddle
TdDataTableService.sortData() versus a custom case-insensitive sort:
https://stackblitz.com/edit/covalent-4d6dxt
What is the expected behavior?
I was expecting sortData() to use String.prototype.localeCompare() for comparing strings, or allow the sortBy argument to be a comparison function.
What is the motivation / use case for changing the behavior?
I find case-insensitive sorting to be more intuitive. In a long list it's not clear that upper-case letters are sorted before lower-case letters.
Which version of Angular and Material, and which browser and OS does this issue affect?
All
Other information
Allowing sortBy to be a comparison function could be useful in other scenarios too.

This sorting service will be deprecated in favor of documented examples for sort.


Update next

Description
Updating next, small quality of life improvements see https://github.com/vercel/next.js/releases/tag/v14.2.5

Old PR closing


Fix strategyType

The thrift0.9.2 sampling endpoint returns strategyType as an integer but thrift0.9.3 sampling endpoint returns strategyType as a string.
This fixes the remote sampler to use the string strategyType.

We should be converting the JSON received from the agent to an internal thrift model like we do in go rather than doing string/integer comparisons like this. (I'll have to investigate if it's doable in node)

Coverage decreased (-0.007%) to 98.611% when pulling 5f9344e4fe13732df583d49d3ab70c6dbfdea34c on fix_strategyType into caac859468d29db6932a4923f5bb6ca2cd5513f0 on master.


[Q]where I can find the summary of each run like in the figure

where I find this data numbers in summary https://wandb.ai/
Run summary:
wandb:                 train/box_loss 0.03868
wandb:                 train/obj_loss 0.05482
wandb:                 train/cls_loss 0.05741
wandb:              metrics/precision 0.24984
wandb:                 metrics/recall 0.45605
wandb:                metrics/mAP_0.5 0.38431
wandb:           metrics/mAP_0.5:0.95 0.26096
wandb:                   val/box_loss 0.03014
wandb:                   val/obj_loss 0.02415
wandb:                   val/cls_loss 0.05598
wandb:                          x/lr0 0.00083
wandb:                          x/lr1 0.00083
wandb:                          x/lr2 0.06293
wandb:                       _runtime 288
wandb:                     _timestamp<PHONE_NUMBER>
wandb:                          _step 10

These values are in the table of your workspace, or they can be viewed from the run overview page for an individual run.  You can access the run overview tab by clicking the circle icon with an i in the center on the upper left hand side of the individual run page.  The summary metrics are in the lower right of the overview page.

thank you sir


How to integrate with DynamoDB using aws-record

As mentioned in title, how can I integrate this with DynamoDB using aws-record gem?
For example, I have this Project model
class Project
  include Aws::Record
  include ActiveModel::Validations

  string_attr :id, hash_key: true
  string_attr :state
  string_attr :title
  string_attr :description
  datetime_attr :start_date
  string_attr :status
  string_attr :company
  string_attr :created_by
end

and then I have this Company model
class Company
  include Aws::Record
  include ActiveModel::Validations

  string_attr :id, hash_key: true
  string_attr :name
end

and then I have the serializer for Project
class ProjectSerializer
  include FastJsonapi::ObjectSerializer

  set_type :project
  attributes :id, :state, :title,
             :description, :start_date, :status,
             :company, :created_by

  has_one :company
end

it return me error as follow:
{"message":"undefined method `company_id' for #\u003cProject:0x00007fbbeac09dd0\u003e\nDid you mean?  company\n               company=\n               company_was"}

I have no idea how to fix this. Please help.

@ljieyao assuming string_atttr :company in the Project model holds the id of the company you can use the :id_method_name option.
I have added to your example above
class ProjectSerializer
  include FastJsonapi::ObjectSerializer

  set_type :project
  attributes :id, :state, :title,
             :description, :start_date, :status,
             :company, :created_by

  has_one :company, id_method_name: :company
end

Here is the list of all such options available. If you need to configure your own method you can use these options
https://github.com/Netflix/fast_jsonapi#customizable-options

@shishirmk thx. I will try again later =)


Sidebar: Broken bottom menus when has many basic menu items

when fixed sidebar with bottom menus has many basic menu items on top, there will be overlap on both.

the bottom menu and the base menu will overlap


Added "version" key

This component is failing to load in the current beta without a version key.

Other pull requests are already submitted, sorry


Add support for Tracing

Find a way to add support for tracing. Something like calling a method "Trace" (it already exists and is used as a log level, but it's just an example) and calling a "TraceEnd". All logs dispatched between these two calls would be related to the same "trace".

No, decided to focus this library only on logging the information, not doing any kind of calculation or anything


Missing dependency undetected

A dependency missing from the agent's configuration went undetected by our framework's checks.
This dependency was present in a custom package. More info in https://github.com/valory-xyz/baby-degen/pull/68.

You need to define the custom package as dependency for the agent, this way the aea install will take care of installing the package dependencies.
customs:
- valory/trend_following_strategy:0.1.0:...


Add support for manual recurrence rule changes

When someone makes a manual change to a recurrence it appears to be modeled as new VEVENTs that have the same UID and SEQUENCE of a particular VEVENT with an RRULE and additionally there is a RECURRENCE-ID that identifies one particular instance of that recurrence that was modified. This modified event then supersedes the one that would have been generated from the RRULE.
As an example I created an empty calendar (in Outlook Web Access) and defined a weekly recurring event (no end date) on Fridays at 14:00, starting on the 18th of December.
Then I moved the second instance of this recurrence (the event on Friday the 25th of December) manually to the Wednesday before (the 23rd) at 10:00.
There appears to be a readable explanation of some aspects of this at icalevents.com,
The following ICS file was generated from this (I added the newlines between the VEVENTs):
BEGIN:VCALENDAR
METHOD:PUBLISH
PRODID:Microsoft Exchange Server 2010
VERSION:2.0
X-WR-CALNAME:Testcal
BEGIN:VTIMEZONE
TZID:W. Europe Standard Time
BEGIN:STANDARD
DTSTART:16010101T030000
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=10
END:STANDARD
BEGIN:DAYLIGHT
DTSTART:16010101T020000
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=3
END:DAYLIGHT
END:VTIMEZONE

BEGIN:VEVENT
DESCRIPTION:\n
RRULE:FREQ=WEEKLY;UNTIL=20210618T120000Z;INTERVAL=1;BYDAY=FR;WKST=MO
UID:040000008200E00074C5B7101A82E00800000000857ED29414D5D601000000000000000
<PHONE_NUMBER>976D1BBA755D145B165875C69398A49
SUMMARY:Test Weekly Recurrence
DTSTART;TZID=W. Europe Standard Time:20201218T140000
DTEND;TZID=W. Europe Standard Time:20201218T150000
CLASS:PUBLIC
PRIORITY:5
DTSTAMP:20201218T080644Z
TRANSP:OPAQUE
STATUS:CONFIRMED
SEQUENCE:0
LOCATION:
X-MICROSOFT-CDO-APPT-SEQUENCE:0
X-MICROSOFT-CDO-BUSYSTATUS:BUSY
X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY
X-MICROSOFT-CDO-ALLDAYEVENT:FALSE
X-MICROSOFT-CDO-IMPORTANCE:1
X-MICROSOFT-CDO-INSTTYPE:1
X-MICROSOFT-DONOTFORWARDMEETING:FALSE
X-MICROSOFT-DISALLOW-COUNTER:FALSE
END:VEVENT

BEGIN:VEVENT
DESCRIPTION:\n
UID:040000008200E00074C5B7101A82E00800000000857ED29414D5D601000000000000000
<PHONE_NUMBER>976D1BBA755D145B165875C69398A49
RECURRENCE-ID;TZID=W. Europe Standard Time:20201225T140000
SUMMARY:Test Weekly Recurrence
DTSTART;TZID=W. Europe Standard Time:20201223T100000
DTEND;TZID=W. Europe Standard Time:20201223T110000
CLASS:PUBLIC
PRIORITY:5
DTSTAMP:20201218T080644Z
TRANSP:OPAQUE
STATUS:CONFIRMED
SEQUENCE:0
LOCATION:
X-MICROSOFT-CDO-APPT-SEQUENCE:0
X-MICROSOFT-CDO-BUSYSTATUS:BUSY
X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY
X-MICROSOFT-CDO-ALLDAYEVENT:FALSE
X-MICROSOFT-CDO-IMPORTANCE:1
X-MICROSOFT-CDO-INSTTYPE:3
X-MICROSOFT-DONOTFORWARDMEETING:FALSE
X-MICROSOFT-DISALLOW-COUNTER:FALSE
END:VEVENT
END:VCALENDAR

This library aims to implement the rrule section of the iCalendar RFC. This feature is not part of the RFC, since it deals with combining multiple recurrence rules to model the feature correctly.
I think the correct approach here is for this library to just concern itself with the rrule aspect and leave it to the application to implement features that needs to combine different rrules to be modelled correctly. It should be quite straightforward for the application to implement this given the rrule abstracration provided by this library.
Feel free to reopen the issue if you want to discuss this further.

You are absolutely right, now that I think about it, this is a level on top of the rrule library. Makes total sense to keep it out. I think I can easily accommodate this in my application.


Using HTML in YML yields [Objcet Object]

Using HTML in YML yields [Objcet Object]
YML
context:
      fieldLabel: |

                       Some Bold Text
                    and now normal continued.

It's rendering as
context:
fieldLabel: ",[object Object], and now normal continued.↵"

but I want my output should be
context: { fieldLabel: '\n    Some Bold Text\n and now normal continued.\n' },

Can not reproduce. Everything works as expected.

@puzrin Yes, its works on online of JS-Yaml.
But when I using in my JS code as follows it throws object:
My YML :
context:
      fieldLabel: |

                       Some Bold Text
                    and now normal continued.

My JS Code :
const tests = YAML.safeLoad(this.props.children,{json:true});
console.log("tests",...tests)

Console output :
context:
fieldLabel: ",[object Object], and now normal continued.↵"

It is coming as [object Object] instead of \n Some Bold Text\n

Could you create a minimal executable sample?


added description for arch linux installation

Thanks for the MR 🙂

Thank you for your cool top bar :) I will use it in my distro :)


Feedback for "Step 1: Onboard Users in Your Identity Authentication Service"

https://help.sap.com/docs/CloudALM/08879d094f3b4de3ac67832f4a56a6de/f2a8a8cd38044f1aae04d8e5491530d4.html?locale=en-US
I would appreciate an easier way to find the template for the file to import users into SAP Cloud ALM via IAS.

Hi @jkmaeda,
Thanks a lot for your feedback!
Here's the documentation of the Identity Authentication service that deals with the import of users with CSV files: Import or Update Users for a Specific Application - SAP Help Portal
It also contains a few examples for the structure of such a CSV file, which you can use to create your own.
I've now added a link it to the setup docs for SAP Cloud ALM:

https://people.sap.com/jkmaeda2
On Wed, 4 May 2022 at 16:55, sap-doc-bot[bot] @.***>
wrote:

Thank you for your valuable feedback contribution, @jkmaeda
https://github.com/jkmaeda! So that we can recognize your contribution
in SAP Community
https://github.com/SAP-docs/contribution-guidelines/blob/main/docs/recognition.md,
please tell us your SAP Community profile URL in a reply to this comment;
don't include any other text, just the URL on its own, like this:
https://people.sap.com/your-user-name
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/SAP-docs/cloud-alm-setup-admin-guide/issues/5#issuecomment-1116984762,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXLSNE4ZDZEJTNFLHQ53TTVIINONANCNFSM5U3APY3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


fix: typo

Checklist

[x] Commit Messages follow the Conventional Commits pattern

A feature commit message is prefixed "feat:"
A bugfix commit message is prefixed "fix:"

[ ] Tests for the changes have been added
[ ] CI has been passed. (GitHub actions all turns green)
[ ] CLA has been signed

Description

please describe the changes that you are making, with the related issue number.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please make sure the following requirements have been met for your PR before we can continue reviewing it:

You have signed the CLA by clicking the [CLA | not signed yet] button from the comments.
The PR has passed all the CI tests and turns green. (you can execute all tests locally by running npm test)

I did sign the CLA.
After I clicked that button from the comment, it redirected me to CLA signing page and showing I have already agreed. It seems that the CLA update request does not always reach github, I am going to close this PR and open another new one for retriggering it.


ht9170: Initial implementation

The driver implements support for the DTMF Shield based on the ht9170.
Signed-off-by: Jon Trulson<EMAIL_ADDRESS>Signed-off-by: Zion Orent<EMAIL_ADDRESS>

Thanks, really cool driver! Now I can program the Edison to answer my :phone: :smile:.


Npm install electron-firebase messes up npm on windows 10

After I installed electron-firebase I was unable to run any npm commands in its directory and for any other projects that were using npm, yarn works fine it was just npm. I checked using the integrated terminal for vscode and also cmd. Both did not work. I had to spend all last night restoring to my last backup I didn't know what had caused the issue at the time. Thankfully I do daily backups but like an Idiot, I tried reinstalling electron-firebase and the same thing happened. I'm going to have to restore this morning's backup, I am not looking forward to it.

I've never experienced an npm misconfiguration on any platform and no one has reported it. Electron-firebase does not use yarn.
It would be helpful if you could give some details:

what platform are you working on?
what were the node.js and npm versions before you started?
did the electron-firebase installation show any errors?
did you start with a new project or an existing project?

It would also be helpful if you had a console log available that you could share, with commands and installation output.
You can see all of the dependent packages in the package.json file:
https://github.com/david-asher/electron-firebase/blob/master/package.json
And then the loading of firebase-tools and other configurations in the postinstall.js script:
https://github.com/david-asher/electron-firebase/blob/master/install_app/postinstall.js
So there's nothing obvious that would muck up the operation of npm, and I would have expected in any case that a reload of npm could solve your configuration problem without a system restore. We should be able to isolate what happened on your system and make this process far easier for you.

Hi David,
Thank you for responding, you're right I should have reinstalled npm before doing a system restore. That's what I did the second time around. I reinstalled NPM and now it works fine. As soon as I ran npm install electron-firebase, I was unable to run any npm run "scripts" commands. The output would seem likes it's running however nothing shows up or is executed. It occurs system-wide, in other projects, and npm doesn't work with cmd as well. However, since I reinstalled npm it nows runs fine and I am no longer facing any issues.
Output
C:\Users\ibnmu\LocalCode\FirebaseV2>npm install electron-firebae
....

C:\Users\ibnmu\LocalCode\FirebaseV2>npm start

  ><EMAIL_ADDRESS>start
  > electron ./main.js
C:\Users\ibnmu\LocalCode\FirebaseV2>


Tell dependabot to enable automerge

Dependabot doesn't support this; GitHub docs just recommend using GitHub Actions


Helper functions to create widgets, instead of creating a single one in the module

We also want a user-guide for how to deploy the widget/app.

I used this drawing for overall layout.
It's slightly different from the original layout where workflow selection widget was in the same row as the select-output and result.


Scenario name resets when using child functions

Readme is a bit obsolete - TestScenario do not exist anymore so maybe I am a bit off.
Provided I am building test scenario using TestScenarioFactory.Default() my expectation is that scenario definition is completed.  Thus I am expecting the Name to be defined exactly at this moment.
Consider following example:
public class NScenarioDemo
    {
        [Fact]
        public async Task Main_Test_Function()
        {
            var scenario = TestScenarioFactory.Default();
            var response = await scenario.Step("First step", () => {
                return new HttpResponseMessage(); });

            await HelperFunction(scenario, response);
            await scenario.Step("3rd step", () => { });
        }

        private async Task HelperFunction(ITestScenario scenario, HttpResponseMessage result)
        {
            await scenario.Step("Assert result code valid", () => { });
            await scenario.Step("Assert result content is valid", () => { });
        }
    }

My expected result would be something like:
SCENARIO Main_Test_function
STEP 1 First Step
STEP 2 Assert Result code valid
STEP 3 Assert result content is valid
STEP 4 3rd step
However, the actual result is
SCENARIO Main Test Function
STEP 1: First step
SCENARIO HelperFunction
STEP 1: Assert result code valid
STEP 2: Assert result content is valid
STEP 2: 3rd step
as you see:

new scenario added out of the blue
nesting is not happening.

Thanks for reporting this issue, I will try to fix it today later. The doc is outdated, sorry for your inconvenience, I need to fix that too.

A new version 3.0.0 with fix for this issue has been just released The DOC in  README should be updated. Please let me know if it's working as you expected.

Works perfectly, thanks!


Add support for data-node in the vegacapsule nodes unsafe-reset-all

There is a PR pending for the data-node: https://github.com/vegaprotocol/data-node/pull/721
After the above PR is merged We should modify the vegacapsule nodes unsafe-reset-all command to restart the data node as well as the vega core and tendermint.
Currently, there is a problem that after the network is restarted, a new chain id is generated and the full node returns an error, that different chain is required.
Command source code: https://github.com/vegaprotocol/vegacapsule/blob/main/cmd/nodes_reset_state.go

This is no longer required


Can't alott items into slots

I can add 1 item and when I try to add an item to any slot it does not keep it. When I hit submit it restarts my game and when I go back into the mod only the first item is there and none of the other items that I placed are there. No console errors either.

duplicate issue


Workaround 'Duplicate Protocol Conformance' Errors

Looks like Swift doesn't like certain protocol extensions and will sporadically fail. This should fix that.

@facebook-github-bot shipit


Fix multi body read streaming

Codecov Report

Merging #1322 (5619608) into main (90a26a9) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1322      +/-   ##
==========================================
+ Coverage   60.45%   60.71%   +0.26%
==========================================
  Files          71       71
  Lines        2526     2528       +2
  Branches       82       80       -2
==========================================
+ Hits         1527     1535       +8
+ Misses        999      993       -6

Impacted Files
Coverage Δ

...io-http/src/main/scala/zhttp/service/Handler.scala
73.91% <ø> (ø)

zio-http/src/main/scala/zhttp/http/HttpData.scala
81.81% <100.00%> (-1.52%)
:arrow_down:

.../src/main/scala/zhttp/http/HttpDataExtension.scala
90.90% <100.00%> (+2.02%)
:arrow_up:

zio-http/src/main/scala/zhttp/http/Response.scala
85.71% <0.00%> (+2.85%)
:arrow_up:

...ain/scala/zhttp/service/ServerResponseWriter.scala
90.69% <0.00%> (+6.97%)
:arrow_up:

zio-http/src/main/scala/zhttp/http/Patch.scala
42.85% <0.00%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a26a9...5619608. Read the comment docs.


Optimize min/max queries based on table statistics

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
In #620 a feature has been added to optimize queries like select count(*) from table.
We can do the same with min / max queries (select min(col) from table).
Describe the solution you'd like
Get the table statistics based on the column name from the table provider, add it to AggregateStatistics optimization rule.
Describe alternatives you've considered
Additional context

Following the example in https://github.com/apache/arrow-datafusion/pull/620 probably makes this PR fairly approachable to anyone who is interested

For it to work on parquet and in-memory data, a bit of work also has to be done there to summarize / expose those statistics.
https://github.com/apache/arrow-datafusion/issues/537

I'd like to do this.

Assigning to @b41sh  per request. Thank you!


Not work on android 13

Module can't run on android 13

Working on Android 12 or not?

Because Author only mentioned Android 8-10 supported. Never talk about Android 11-13 🥲

Please download the latest version.


(feature) user profile - controller

@poppin3000 and @protean-shake - based on our standup I'm reassigning this to Pavan so he can get his hands dirty with angular, but I can also do work on it

Actually nevermind... I'm gonna take a stab at this as Ryan said Pavan is busy working on testing.


Add additional support for multiple knowledge bases by employing all of them in one pass

Would close as won't fix now


It not working in Goland when use remote target

version：
GoLand 2022.2
EnvFile 3.4.1
example:

Add a SSH Server
Choice run on ssh target
Add a .env file in EnvFile

issue:
it can not working when use ssh target, but working nomally when use local machine

This also does not work when using a docker container as the target


Consider moving non-null-safe tests to their own file

Original comment by a reviewer in cl/460200489
In https://github.com/google/protobuf.dart/blob/7a832c248a0656ec47e6d927e0c6e8705c6f48b1/protoc_plugin/test/generated_message_test.dart we test behavior of the protobuf library when called from non-null-safe code.
Since protoc_plugin is null-safe, to be able to do that we override the language version with // @dart=2.11.
That disables null safety in the entire file. Ideally if we move the null-safety tests to another file then we don't need to run all the other tests in non-null-safe mode, and when we drop support for use from non-null-safe code we just delete the file.

Done in #791 (merged as cc0f287fb6a8680e431eb9210225f1d0ac33c047).


Component updates

Core - Full Integration Build 57 outcome was FAILURE using a merge of 667a594808cbf51ba81ceca49e165dcc46b65416
Summary: Exit code 1 (new) Build time: 00:00:13

Linux Build 71 outcome was FAILURE using a merge of 667a594808cbf51ba81ceca49e165dcc46b65416
Summary: Tests passed: 15; exit code 1 (new) Build time: 00:00:23

Windows Build 55 outcome was FAILURE using a merge of 667a594808cbf51ba81ceca49e165dcc46b65416
Summary: Tests passed: 15; exit code 1 (new) Build time: 00:00:24

Full integration - Windows Build 57 outcome was FAILURE using a merge of 667a594808cbf51ba81ceca49e165dcc46b65416
Summary: Exit code 1 Build time: 00:00:51

retest this please

Core - Full Integration Build 58 outcome was FAILURE using a merge of 667a594808cbf51ba81ceca49e165dcc46b65416
Summary: Exit code 1 Build time: 00:00:13


Customizable row/column reordering

The current reordering support is very useful, but quite limiting in terms of customizability.
In its current state, draggability can only be controlled by defining onRowMoved and onColumnMoved, at which point any row/column can be dragged to any position, and there's no control over whether that's an allowed action other than to have it jump back when the dragging is complete.
Some API additions that would help are:

Whether the current row/column is allowed to be dragged
When dragging has started / is in progress (and index of which is being dragged)
Control which rows/columns it is allowed to be dropped over / next to
Customizable styling/drawing for the column being dragged

In a similar vein, some additional onColumnResized APIs would also be helpful, such as:

Whether the current column can be resized
Column resizing has started / is in progress
Minimum and maximum sizes for each column

The column resize start/end events exist. I will add the ability to preventDefault on them. Then we can just do the same for rowMovedStart/End and would that be enough or do you also need to filter final positions not just start positions?

Closing due to inactivity and an unclear objective.

Sorry for the delay here.
We would also like to be able to limit/filter the final positions.
As more of a nice to have, it would be great if we could control how the currently-being-dragged row/column is styled, e.g. lighten or darken or otherwise indicate it is "grabbed".
An extra-nice-to-have would be a way to draw the moving row/column locked to the cursor, something like the gif below, but I imagine that would be a much more substantial undertaking.

Actually the ghost thing is much easier since it's sorta built into the browser.

This is now possible in 6.0.0 with onColumnProposeMove

Hi! Nice library, thanks!
How i can customize row reordering? I want to implement same styles with ghost like in column drag.
Thanks

Hi! Do you by any chance have an example how to draw the overshadow of the column when it is moved?


Search for best parameter when it is a string

Hello,
I'm trying to run the neuralnet strat and it has several possible parameters for the "training method" that are defined as a string;

// the neural network training method to use. Options are 'sgd', 'adagrad', 'windowgrad', 'nesterov'
method = 'adadelta'

I want to use BacktestTool to search several parameters combinations, including the "method".
When I try to set my TOML file as:
method = " 'adagrad', 'sgd', 'adagrad', 'windowgrad', 'nesterov', 'adadelta' "
Result:  Nothing happens
method = 'adagrad', 'sgd', 'adagrad', 'windowgrad', 'nesterov', 'adadelta'
or
method = adagrad, sgd, adagrad, windowgrad, nesterov, adadelta
Result: Syntax error (expected)
Thanks

Check: method = " \'adagrad\', \'sgd\', \'adagrad\', \'windowgrad\', \'nesterov\', \'adadelta\' "
Im not sure if your example with spaces before/after double quote will work. Double quote will should add automatically. This is needed to successfully parse data from the TOML file to Perl. Then the string between the double quote is replaced by regular expression.
I know that the Github version has a bug associated with this syntax of BF. Once you run backtest, you can make sure that all the options have been processed correctly, you can enable keep_logs in backtest-config.pl and check the files created in the log folder. The file includes config.js content from gekko.


AttributeError: type object 'tqdm' has no attribute '_lock'

Describe the bug
Getting a tqdm issue when writing a Dask dataframe to the hub.
Similar to huggingface/datasets#6066. Using latest Datasets version doesn't seem to resolve it
Steps to reproduce the bug
This is a minimal reproducer:
import dask.dataframe as dd
import pandas as pd
import random

import huggingface_hub

data = {"number": [random.randint(0,10) for _ in range(1000)]}
df = pd.DataFrame.from_dict(data)
dataframe = dd.from_pandas(df, npartitions=1)
dataframe = dataframe.repartition(npartitions=2)

repo_id = "nielsr/test-dask"
repo_path = f"hf://datasets/{repo_id}"
huggingface_hub.create_repo(repo_id=repo_id, repo_type="dataset", exist_ok=True)
dd.to_parquet(dataframe, path=f"{repo_path}/data")

Note: I'm intentionally repartioning the Dask dataframe to 2 partitions, as it does work when only having one partition.
Expected behavior
Would expect to write to the hub without any problem.
Environment info
Datasets version 2.14.4

@NielsRogge What's your full stacktrace? And which version of tqdm are you using ?
pip freeze [ grep tqdm

Ah I see, so the issue has already being identified and fixed in https://github.com/huggingface/datasets/pull/6068 ?
We can make the exact same fix for huggingface_hub as well. But very weird that I can't reproduce myself and that no-one complained so far :confused:


Implemented fullcalendar 'datesSet' callback

Hi Muhammad,
I noticed that the fullcalendar Streamlit component did not have a callback for date changes in the fullcalender yet. This is handy, for example, when the prev/next buttons are used in the calendar. As such, I implemented the fullcalendar's datesSet callback (https://fullcalendar.io/docs/datesSet) and wanted to share it.
For this update, I build upon your most recent release (22 dec 2023) and followed your style of coding (return format and variable naming).
One problem though: when the calendar’s dates change, both datesSet and eventsSet are triggered. I think setComponent causes only eventsSet to be triggered. As a result, the datesSet callback only works when there is no eventsSet callback requested. I added a warning in the component creation, but maybe you can think of a more elegant solution...
Best,
Max

@im-perativa little bump in case you missed it!

@MaxvandenBoom thanks for your contribution and sorry for such late reply. Initially i create this package to provide a simple calendar function in streamlit and I'm not sure if we should add every callback to it because in the end we also limited by the streamlit capabilites.
For now, I believe a comprehensive tests with all original callback and their impact with each other should be done first and then we can add all compatible callbacks to this package in a single release.


[CP] [Beta] - Add back accidentally removed pragma on scheduleMicrotask

Please cherry pick 98d5ecb5533d20677430b168e6672260cf2c2b4e into the beta branch
Reason : We had a fix for 177110012 in daef1f0dbf8a35c689ad478ce320eb452525af9b but that was inadvertently removed in b837038cf9ca8f3556b82c5056a29a126e7d6915
Impact: Some of the tests were timing out before this fix was made. All embedder code that uses the scheduleMicrotask could get affected
The change merges cleanly into the beta branch and builds fine.
Risk: Low, the change was in master and rolled into Flutter/Google3 before it was inadvertently deleted. The change is a one liner.
Link to original issue : 177110012
/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow @regis

Approved in SCRUM meeting

Merged to beta in cc15e7439ae2c596b2ca0c5c032e294a20843e30 (2.12.0-259.12.beta).


Disable 'Start Deployment' while DeploymentLauncher is running

Description
Make it so you can't attempt to start another deployment while DeploymentLauncher is running. This is especially noticeable when Build and Upload Assembly is unchecked, so 'Start Deployment' doesn't get greyed out.
Primary reviewers
@jessicafalk @jayprobable

@jayprobable I was considering that as well, but I went with the two async tasks for the sake of simplicity (especially since this is not a hot path and the performance impact is negligible)


Close #281: ESLint and using the force, Luke

This PR closes issue #281.

Also, please don't mind the merge, I made a change online and offline and it got confused, so I used that to fix it.

@MichMich, we need to enable Travis, but you need to do it using your GitHub account.

Will look into that asap.

https://github.com/MichMich/MagicMirror/blob/master/.github/CONTRIBUTING.md is still talking about jslint. Could you add the right listing info?


First DonutSection

The first section always occupies more, another section of similar amount. Can I change that somehow? Thank you earlier.

Hi, If I understand correctly, the appearance you are describing is caused by rounded stroke cap of DonutSection line when set to DonutStrokeCap.ROUND. We currently do not account for stroke cap width when displaying sections, so -- right now, unfortunately no, you cannot change that. We can look into that in future releases.

Thanks

This behavior was fixed in https://github.com/futuredapp/donut/pull/103


Jesse: Watch alltopbestblogger.com

Jesse requests the watch of the watch_keyword alltopbestblogger\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

alltopbestblogger\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


add: redirect for inline auth 401 error 🪃❌

Closes #244
Description

Add new error message window w/ redirect to PearAI login action.

Checklist

[x] The base branch of this PR is preview, rather than main

Update
Removed the dupliate word 'Error'
new error message

Good work! Is there anyway to hide the link to the server and make it something else? like "PearAI Server"

I can hard code it into the error message but this is what the API endpoint send in response to an Auth error.

Fixed merge conflicts @nang-dev @Fryingpannn


My copay wallet shows zero

I added about .0324 bitcoin to my wallet in August of 2019, it was there yesterday, I copied a blockchain from 5dimes.com to send them $200 dollars worth of bitcoin. After attempting the blockchain, nothing went to 5dimes.com, but yyen my wallet was at zero and there shows only a history of adding money to th e wallet nothing else. How can I of lost my bitcoin?

Hi, can you please share an address of your wallet, so we can investigate further?

How do I find the address of the wallet on copay?

go to the "receive" tab and you will see and address.

1GyigcERozxoQ2KxLSpJLdH5aRdFmK7D4P

Thankyou for your help

I put 90 dollars into the bitcoin machine and scanned my copay and everything went trhough but when i look at my copay wallet it shows zero balance on my wallet .

Kind regards.

we have developed our own hardware for cracking BITCOIN wallet PASSWORDS with superfast speed
and if you still has problem I can help you run it. you can find my contact details on my profile
or you can send me message in telegram: @johnjames333


Incorrect error message when using incorrect version number

Apologies if this is not the right repo for this.
To Reproduce

Put this in your elm-package:

{
    "version": "1.0.0",
    "summary": "helpful summary of your project, less than 80 characters",
    "repository": "https://github.com/user/project.git",
    "license": "",
    "source-directories": [
        "."

Could not find package elm-lang/navigation.

Maybe your elm-stuff/ directory has been corrupted? You can usually fix stuff
like this by deleting elm-stuff/ and rebuilding your project.

Expected Output
No packages exist for `"elm-lang/http": "3.0.0 <= v < 4.0.0"`.
Did you mean an earlier version?

Notes
The error mentions navigation but the issue was http version was incorrect.

I'm hitting this too. I get this message instructing me to delete my elm-stuff directory immediately after deleting it.

Actually, I think this could be #253


lineage frequency barplot

For next round I suggest we update the first plots of "Omicron sublineages in Canada" which is looking great, but is getting dated (no XBB, and it starts with the text description: "Here we take a look, sub-dividing the major sub-lineages currently circulating in Canada." but most of the plots are of lineages that aren't occurring anymore, or are heavily declining. :))
Move XBB into divergent?

re-classify XBB 1 and 1.5 into the Divergent lineages, rename to recombinants?
"Here we take a look, sub-dividing the major sub-lineages circulating in Canada." Remove the word current
Default tab is last 120 days.
Merge early and late BA.2, merge BA.5.1 and BA.5.2


feat(wallet-connect): support safe_setSettings

What it solves
The support of safe_setSettings in the WalletConnect app.
How this PR fixes it
The dependencies have been updated, permitting the safe_setSetting RPC call.
How to test it
Prerequisites:

Open the https://github.com/safe-global/web-core/pull/1162 deployment.
Run the EIP-1271 test DApp locally.

Method:

Open the WC app in the aforementioned deployment.
Connect to the aforementioned test DApp.
Toggle off-chain signing and attempt to sign a message.
Observe the off-chain signing modal.
Sign the message.
Observe the signed message in the "Signatures" tab of the transaction list.

Closing in favour of https://github.com/safe-global/safe-react-apps/pull/671.


pulled in signal-exit module

pulled in the signal-exit module, which ensures that an exit event is fired regardless of whether execution ends normally, via kill, or via exit.

Coverage increased (+1.82%) to 96.97% when pulling 8ca6e16f6ecb7fa488944cd00d84ae5d355345d2 on signal-exit into 0f701da5aa3ad8a02872c4c6c8c37d0deb2c5877 on master.


500 Internal server error on Installation

After step Install of pH7CMS - Step 4/8, when I press Next, I get 500 Internal Server Error
Testing on Ubuntu 14.04.2 LTS
<IP_ADDRESS> - - [07/Feb/2016:06:26:40 +0000] "POST /_install/?a=config_site HTTP/1.1" 500 416 "http://<IP_ADDRESS>/_install/?a=config_site" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.97 Safari/537.36"

Hi @aquilax
First of all, can you check if you have a log file in /_install/data/logs/ ?
Then, can you check your server log (Apache log) as it seems to be a server error...?

The log contains multiple:
[07-Feb-2016 00:33:22 America/Chicago] PHP Fatal error:  Call to undefined function ph7\is_internet() in /var/www/html/_protected/framework/Loader/Autoloader.php on line 68

This modif was really new and didn't check the installer (as this Github repo is dev place, some time you get bugs). Thanks for your help!
Here is the bugfixed: https://github.com/pH7Software/pH7-Social-Dating-CMS/commit/857a89704fcbd2899de1220eb701072aadb6e3a6
You can fix it by uploading this file again.


initial commit Japanese translation of readme

Hello. There is no Japanese translation on Knex. So I made Japanese version of README.

@kibertoad maybe we can plan other translation of README ?
If yes, I can do in French and we can add links in README.md


Fix path for kube-state-metrics dashboards

Hi 👋  During an activity we spotted a wrong link in kube-state-metrics and fixed it. The initial . breaks the links between dashboards, for example from thecluster dashboard if you click on a namespace for details, you get an error because it tries to go to <GRAFANA_URL>./d/<DASHBOARD>
Many thanks to @giusepperotella who spotted and fixed the issue.

I can't replicate the issue locally, it works for me with a port-forward and also using an ingress. Tested using version 1.14.1 of the module
https://user-images.githubusercontent.com/6362698/172201596-72ee7ea0-579e-4dcf-8b47-e3d826efc57e.mov
.

Hi @ralgozino , I found the problem with version 1.13.0 of the module.

Hi @giusepperotella! thanks for the info.
I tested this also with monitoring 1.13.0 and is working also. Do you happen to have the ingress definition that you used at hand so I can test it?
Thanks!

Hi @ralgozino , we encountered the problem both through ingress nginx and through port-forward.
The definition of the ingress is as follows:
--- apiVersion: networking.k8s.io/v1 kind: Ingress metadata:   annotations:     kubernetes.io/ingress.class: "nginx"     forecastle.stakater.com/expose: "true"     forecastle.stakater.com/appName: "Grafana"     forecastle.stakater.com/icon: "https://github.com/stakater/ForecastleIcons/raw/master/grafana.png"   namespace: monitoring   name: grafana spec:   rules:     - host: grafana.fury.info       http:         paths:           - path: /             pathType: Prefix             backend:               service:                 name: grafana                 port:                    number: 3000

I tried to replicate the issue with your ingress definition, port-forward using Chrome, Firefox and Safari. It always works for me, even with version 1.13.0.
Can I ask you for detailed instructions on how to replicate the issue, please?
Thanks!

hi @ralgozino , I have reviewed the video and the dashboard you are using is not the one on which we encountered the problem. The dashboard on which we encounter the problem is Kubernetes / Compute Resources / Cluster.
I checked and I also have the same problem with the v1.14.2 version of the module.