Improve German nlp pipeline

Hi,
I made a few improvements for the German nlp pipeline:

Scraped documents are more tidy
Added agency calculation and visualisation
Added analyses for all documents with some comments
Added note on SRL

I added version checks for spacy and pandas. I also added ignore_index = True to pd.concat().


Negative margin on rows inside of a collapsed row

(This is in version 4)
.row.collapse
  .large-6.columns
    .row
      .large-12.columns
        This inner row has an unwanted negative margin

It seems to me that when nesting a .row inside a .row.collapse there should not be a negative margin on the inner row. Is that expected behavior? Seems like we need something like this:
.row
  .row
    margin-left: -$column-gutter
    margin-right: -$column-gutter

.row.collapse
  > .column,
  > .columns
    > .row
      margin-left: 0px
      margin-right: 0px

I believe that I still have this issue on Foundation <IP_ADDRESS> (I have not tried updating, but Feb 22 2014 when @jhilden last commented on this issue, the latest version was older than this.)
For me, my organization is large and has a standardized theme that I may not be able to update.  The issue manifested itself as, when setting collapse on the outermost row in a grid, this has a recursive effect on nested grids.  The look of row/columns grids nested deep inside changes substantially.  I was hoping to use "collapse" to get rid of just the outer-most negative margin.
I wound up creating a container with this style, and wrapping my page content in it (inside of the main.site-content)
This way I can match the alignment of the page footer, which does use collapse and does not have nested grids:
.content-inner {
  margin-left:0 !important;
  margin-right:0 !important;
}

    <%= yield %>

This solution is sub-optimal, but I do not know if it would have been fixed, or what else would be changed, if I applied an update.  Just sharing in case anyone else has run into this problem.


Responsive List Views don't respect indentation from nesting

Currently converting subaccounts section to use responsive list-views, but it doesn't indent subaccount according to hierarchy.

Actual hierarchy (with indents) looks like this:


Prove design for rehydration of Operation and Operation

Operation types must provide a constructor that allows users to access an existing LRO.
Currently, protocol methods and their convenience APIs that start/complete long-running operations return either Operation or Operation<T>.  Neither of these types provides a way to access an existing LRO as required by the guidelines.
This issues tracks the work to provide a proof of concept that we can implement this functionality.  An implementation is not required for DPG GA, but will be a DPG v1.1 feature.

Related to https://github.com/Azure/autorest.csharp/issues/2158

Is this depend on https://github.com/azure/autorest.csharp/issues/2231 ?
And can we have this done in May?

Is this depend on https://github.com/Azure/autorest.csharp/issues/2231 ?

Having #2231 would speed up the implementation of this, and help with design, but it is not strictly required.

And can we have this done in May?

We are working toward this.  I have created a gist describing options here: https://gist.github.com/annelo-msft/f8d8ca10484081e395df23f518de91cc  Depending on the outcome of the design, the implementation may take more or less time.
@ArthurMa1978, can you help me understand your need to have it done in May?  Is it different from the DPG GA goals?

Per @KrzysztofCwalina, it is not required to produce a design prior to DPG v1.0 GA.  Having considered multiple approaches to design, I believe that any of them can be made to work with design tradeoffs and that all the pieces are in place such that we can add operation rehydration without making breaking changes to the protocol methods on DPG libraries.
Right now, we return Operation or Operation<BinaryData> in the method signatures of methods that invoke long running operations.  We don't expect to change this in the future.  If we need to add subtypes of Operation specific to DPG to add functionality in the future, we will require rehydration of the operation or a downcast to access that functionality.

or we add this missing functionality to the base type. i.e. we convinced ourselves that we will be able to support it post v1


Add sel_where to Datset and DataArray

Addresses #811 to provide a Dataset and DataArray sel_where which returns a Dataset or DataArray of minimal coordinate size.

@shoyer, I haven't added any specific documentation.  Would you recommend doing so and if so, should this go near here https://github.com/pydata/xarray/blame/master/doc/indexing.rst#L265?

Yes, expanding the section on "where" seems like the right place to put
this.
On Fri, Apr 1, 2016 at 11:08 AM, Phillip Wolfram<EMAIL_ADDRESS>wrote:

@shoyer https://github.com/shoyer, I haven't added any specific
documentation. Would you recommend doing so and if so, should this go near
here https://github.com/pydata/xarray/blame/master/doc/indexing.rst#L265?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/pydata/xarray/pull/815#issuecomment-204498369

This is very cool! Would it also work in that case?
a = xr.DataArray(np.arange(5**3).reshape(5, 5, 5), dims=('x', 'y', 'z'))
mask = xr.DataArray(np.arange(5**2).reshape(5, 5), dims=('x', 'y'))
a.sel_where(np.logical_and(mask > 6, mask < 18))

@fmaussion, for
array = DataArray(np.arange(5**3).reshape(5, 5, 5), dims=('x', 'y', 'z'))
mask = DataArray(np.arange(5**2).reshape(5, 5), dims=('x', 'y'))
actual = array.sel_where(np.logical_and(mask > 6, mask < 18))

it returns this
(Pdb) actual
<xarray.DataArray (x: 3, y: 5, z: 5)>
array([[[ nan,  nan,  nan,  nan,  nan],
        [ nan,  nan,  nan,  nan,  nan],
        [ 35.,  36.,  37.,  38.,  39.],
        [ 40.,  41.,  42.,  43.,  44.],
        [ 45.,  46.,  47.,  48.,  49.]],

       [[ 50.,  51.,  52.,  53.,  54.],
        [ 55.,  56.,  57.,  58.,  59.],
        [ 60.,  61.,  62.,  63.,  64.],
        [ 65.,  66.,  67.,  68.,  69.],
        [ 70.,  71.,  72.,  73.,  74.]],

       [[ 75.,  76.,  77.,  78.,  79.],
        [ 80.,  81.,  82.,  83.,  84.],
        [ 85.,  86.,  87.,  88.,  89.],
        [ nan,  nan,  nan,  nan,  nan],
        [ nan,  nan,  nan,  nan,  nan]]])
Coordinates:
  * x        (x) int64 1 2 3
  * y        (y) int64 0 1 2 3 4
  * z        (z) int64 0 1 2 3 4

where
(Pdb) array
<xarray.DataArray (x: 5, y: 5, z: 5)>
array([[[  0,   1,   2,   3,   4],
        [  5,   6,   7,   8,   9],
        [ 10,  11,  12,  13,  14],
        [ 15,  16,  17,  18,  19],
        [ 20,  21,  22,  23,  24]],

       [[ 25,  26,  27,  28,  29],
        [ 30,  31,  32,  33,  34],
        [ 35,  36,  37,  38,  39],
        [ 40,  41,  42,  43,  44],
        [ 45,  46,  47,  48,  49]],

       [[ 50,  51,  52,  53,  54],
        [ 55,  56,  57,  58,  59],
        [ 60,  61,  62,  63,  64],
        [ 65,  66,  67,  68,  69],
        [ 70,  71,  72,  73,  74]],

       [[ 75,  76,  77,  78,  79],
        [ 80,  81,  82,  83,  84],
        [ 85,  86,  87,  88,  89],
        [ 90,  91,  92,  93,  94],
        [ 95,  96,  97,  98,  99]],

       [[100, 101, 102, 103, 104],
        [105, 106, 107, 108, 109],
        [110, 111, 112, 113, 114],
        [115, 116, 117, 118, 119],
        [120, 121, 122, 123, 124]]])
Coordinates:
  * x        (x) int64 0 1 2 3 4
  * y        (y) int64 0 1 2 3 4
  * z        (z) int64 0 1 2 3 4

(Pdb) np.logical_and(mask > 6, mask < 18)
<xarray.DataArray (x: 5, y: 5)>
array([[False, False, False, False, False],
       [False, False,  True,  True,  True],
       [ True,  True,  True,  True,  True],
       [ True,  True,  True, False, False],
       [False, False, False, False, False]], dtype=bool)
Coordinates:
  * x        (x) int64 0 1 2 3 4
  * y        (y) int64 0 1 2 3 4

Is this what you were expecting?

At some point it might be useful to be able to use dask to compute the mask, so I made an issue for that: https://github.com/dask/dask/issues/1076

@shoyer, thanks for submitting the dask issue.

Forgive me if this is naive - is this equivalent to a pandas slice?

@pwolfram thanks. It's hard to tell form the print, but from the dimensions of the output it looks fine. The real use case would if you have (x,y,time), you would like to sel_where based on x,y only (for example a landmask or something).

@shoyer : I thought that operation like np.nonzero are not working with dask?
http://dask.pydata.org/en/latest/array-overview.html#limitations

@shoyer, user documentation added in 96677b5846603fcd3aa5fe11e56a65482a46f856

In this example I used where to produce a map:
>>> ds.states.where(ds.states == state_ids['California']).plot()

If I used sel_where, the plot would be automatically trimmed.
@fmaussion that's correct that you cannot do lazy computation with the result of nonzero on a dask array. However, computing nonzero itself could be an expensive operation if the mask is large, and we could do that with dask.

@shoyer, squashed the commits for simplicity.

Right, I see. I think it's equivalent only to a pandas slice on Series, rather than a DataFrame.
In [71]: series = pd.Series(range(10))

In [72]: series[series>5]
Out[72]:
6    6
7    7
8    8
9    9
dtype: int64

# ...same as sel_where

In [78]: df =pd.DataFrame(pd.np.arange(40).reshape(4,10))

In [79]: df[(df>11) & (df < 28)]
Out[79]:
    0   1   2   3   4   5   6   7   8   9
0 NaN NaN NaN NaN NaN NaN NaN NaN NaN NaN
1 NaN NaN  12  13  14  15  16  17  18  19
2  20  21  22  23  24  25  26  27 NaN NaN
3 NaN NaN NaN NaN NaN NaN NaN NaN NaN NaN

# ...same as where

FWIW I'm not a fan of the sel_where name, sel is otherwise associated with labels, and this is supplying bools.
Have you thought about including this in where, with a kwarg such as drop=?

@shoyer et al, I think @MaximilianR's suggestion makes sense.  This would reduce the amount of code that has to be accounted for too and would be cleaner.  Essentially have this method be called via array.where(mask, drop=True) instead of array.sel_where(mask).
All feedback on this proposal welcome.

+1 for drop=True
On Fri, Apr 1, 2016 at 1:59 PM, Phillip Wolfram<EMAIL_ADDRESS>wrote:

@shoyer https://github.com/shoyer et al, I think @MaximilianR
https://github.com/MaximilianR's suggestion makes sense. This would
reduce the amount of code that has to be accounted for too and would be
cleaner. Essentially have this method be called via array.where(mask,
drop=True) instead of array.sel_where(mask).
All feedback on this proposal welcome.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/pydata/xarray/pull/815#issuecomment-204564228

@shoyer and @MaximilianR, this is done and I added a few more test cases with nonuniform coordinates to hopefully ensure there aren't any hidden bugs.

looks good to me other than a few nits
Please also add a release note crediting yourself!

@shoyer, I believe I have addressed your comments and this should be ready to merge.  Thanks!

Thanks @MaximilianR and @shoyer!  I think we are at the last call before the merge now.

Thanks @pwolfram !

My pleasure, thank you @shoyer for all the really great help designing the code and making it much better!


Escaping of quotes in onStart and onStop commands

Currently, due to limitations in Bash, it is necessary to escape quotes in Tredlyfiles.
For example, onStart= echo nginx_enable=\\"YES\\" >> /etc/rc.conf. The double quotes (") will be escaped and be interpreted correctly. Without the escape characters, this command will be incomplete.
We are looking into alternatives. When attempting to set values in /etc/rc.conf we recommend using sysrc instead of echo

echo 'something_enable="YES"'>>/etc/rc.conf works for me.


unable to import /training/car_workspace.json

Hi,
When importing the training file, bluemix is throwing "incorrect syntax" error.
See http://imgur.com/a/PARfR
Edit: Importing from Windows 64

I think this is a duplicate of #100


PBIViz fails under version 1.11.2

I recently upgraded my version of powerbi-visuals-tools to 1.11.2.  Previously I was on 1.10 and was working successfully.
pbiviz start compiles my product and starts successfully, but I'm running into several issues connecting to localhost.

On app.powerbi.com, I get the "Can't contact visual server" error.
When I open Postman and execute a GET or POST to https://localhost:8080/assets/status following the troubleshooting steps here: https://github.com/Microsoft/PowerBI-visuals-tools/issues/20, I get an error that it could not get any response.
When I open Chrome and navigate to that page, I get the error:

This site can’t provide a secure connection localhost uses an unsupported protocol. ERR_SSL_VERSION_OR_CIPHER_MISMATCH
Thanks for any additional troubleshooting suggestions.
cc: @ignatvilesov

PBIVIZ used to use the static SSL certificate for all of developer but it was not securely enough.
PBIVIZ v1.11.2 generates a new certificate for each PC but it requires the following additional steps:

Create a SSL certificate
Install a SSL certificate

Thanks, this solved my issue.


Request for aws_launch_configuration resource

What resource do you need?
Terraform Resource Name: aws_launch_configuration
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/launch_configuration
Relates to private issue: https://github.com/upbound/official-providers/issues/826

https://marketplace.upbound.io/providers/upbound/provider-aws/v0.18.0/resources/autoscaling.aws.upbound.io/LaunchConfiguration/v1beta1

Thanks, @turkenf for confirming this is already in place. I will close this issue.


Disable implicit casts, update and fix lints

Security Insights
No security relevant content was detected by automated scans.
Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.


CalendarInteval can't be compared (another map thing)

ends up with the same behaviour currently if used through comparableMaps, so this should likely be added

to_yaml = to_yaml does work.


Audio spoken digit generation and other S4 questions

Hi! Like everyone else on here, I would like to first say, thank you very much for putting this all together.
I was looking at the unconditioned audio generation and have a few question about sequence generation specifically and conceptually:

https://srush.github.io/annotated-s4/#experiments-spoken-digits, it seems the embedded links are broken?
I was wondering for the spoken digit generation, is it conditioned on a sequence length of samples like MNIST completion task is given the first 300 samples? Or is it generated from scratch? I am curious if it's possible to generate condition samples (e.g., ask it to generate audio for a given number and speaker id)?
Also looking through the annotated-S4 post, it mentions that

Note as well that in the original paper Lambda, P, Q are also learned. However, in this post, we leave them fixed for simplicity.

But looking at the code:
def setup(self):         # Learned Parameters (C is complex!)         init_A_re, init_A_im, init_P, init_B = hippo_initializer(self.N)         self.Lambda_re = self.param("Lambda_re", init_A_re, (self.N,))         self.Lambda_im = self.param("Lambda_im", init_A_im, (self.N,))         # Ensure the real part of Lambda is negative         # (described in the SaShiMi follow-up to S4)         self.Lambda = np.clip(self.Lambda_re, None, -1e-4) + 1j * self.Lambda_im         self.P = self.param("P", init_P, (self.N,))         self.B = self.param("B", init_B, (self.N,))
It seems Lambda, P, (I guess P=Q here) are declared as params and thus would not optax still optimize them? I am new to flax/jax, so I am wondering how they are been fixed?

For my general understanding. It seems the matrix A is initialized with the HiPPO matrix rather than a random initialization, but is it still suppose to be updated during training like the B, C, D matrices?
Finally, I was wondering intuitively, how does the HiPPO matrix initialization change? It seems from the presentations made by Albert Gu, that it is a result of a chosen measure and the HiPPO matrix in the code here is based off of EMA? Is that correct higher level understanding (e.g., if my measure is a window, I would need a different HiPPO matrix) or is the HiPPO matrix initialization completely general?

Hi Peter, I'll reply to some of these questions.

Looks like @srush took care of it!
In the Sashimi paper it was unconditional. I believe it's the same in this codebase although I haven't run any of the experiments to check. Generating conditioned on extra information (e.g. number or speaker id) is orthogonal to generating conditioned on a prefix (e.g. the first 300 numbers of the sequence). There are standard ways to do this, such as passing an embedding of the label (e.g. the number) to every layer of the model
I think the original version had non-learnable P/Q. I later updated this in a fork which was merged in https://github.com/srush/annotated-s4/pull/60 and had several improvements to the original implementation. Some of the description to the original post was probably not updated and I'll go through and update them in the next few weeks.
Yes, the A/B matrices are initialized to fix values and still trained during training (at a lower LR compared to the rest of the network).
HiPPO is a more complicated framework. Couple of points corresponding to some of your questions:

Each specific measure corresponds to one fixed value of $(A, B)$
The measure that the "HiPPO-LegS" matrix (the one used in S4) corresponds to is an exponentially-decaying measure. It's somewhat related to EMA but quite different/more general in some ways; the EMA example I use in some talks is a motivating example that's an extremely restricted/special case of HiPPO-LegS.
If you wanted a "sliding window" measure, that corresponds to a different $(A, B)$ matrix.
The way that the matrices change during training is not understood. They do not necessarily correspond to HiPPO matrices throughout training.

The way I think about training is like this:

Suppose that you are forced to fix the $A$ and $B$ matrices (i.e. can't train them). Which matrices should you pick? The HiPPO theory prescribes some candidates which have long-range memorization abilities, in some particular theoretical sense. These do work much better than random matrices in practice
But there's no need to fix them during training; there's no computational downside to learning them automatically through backprop, and in deep learning we generally assume that this helps performance
Indeed, learning the matrices (at a lower LR) improves performance slightly. However the resulting matrices are not necessarily "HiPPO matrices"
Despite everything being trainable and not necessarily being HiPPO matrices, the initialization to these special matrices still seems to help performance. One intuition is simply that SGD might have limitations on how much it can learn, so the strength of the model at initialization still has a large factor on final performance.

TL;DR:

Theoretically, for fixed $(A, B)$ matrices, HiPPO theory gives matrices with very strong performance compared to others
Empirically, nothing is lost by continuing to train the matrices, although they might not be "HiPPO" anymore. The HiPPO initialization is still often better than other initializations, although the gap closes after training

Thanks for the prompt response Albert!
A quick follow up on 2), could you point me to where in the Sashimi code the set up for the unconditioned generation happens? And for clarification, the generation was not conditioned even on a prefix and the loss was maximizing the probability of p(x_t|x<t) ?

Yes to both. The generation script is here: https://github.com/HazyResearch/state-spaces/blob/main/generate.py
Instructions are in the main READMEs which provide the commands for Sashimi generation. I think you can specify the prefix length, i.e. l_prefix=0 means unconditional generation.

I see thank you!


FileNotFoundError - blocks.py

FileNotFoundError                         Traceback (most recent call last)
 in
61 if Use_Gradio_Server:
62   share='--share'
---> 63   for line in fileinput.input('/usr/local/lib/python3.8/dist-packages/gradio/blocks.py', inplace=True):
64     if line.strip().startswith('self.server_name ='):
65         line = '            self.server_name = server_name\n'
1 frames
/usr/lib/python3.8/fileinput.py in _readline(self)
340                     pass
341                 # The next few lines may raise OSError
--> 342                 os.rename(self._filename, self._backupfilename)
343                 self._file = open(self._backupfilename, self._mode)
344                 try:
FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/gradio/blocks.py' -> '/usr/local/lib/python3.8/dist-packages/gradio/blocks.py.bak'

either you missed the requirements cell or you are using aa very old version of the notebook


adding 3d to 2d snapshot for ecog plotting

Hey all - this a quick extension of @Eric89GXL's recent ecog plotting tutorial. We had discussed including a few functions in the example to show how you could create a snapshot of the current view for ecog plotting. In this PR, I'm adding these functions to the _viz3d module and added a snapshot_montage function for doing this automatically (and extended the example to show it).
I can delete those functions and just put the code in the example if people would prefer, but wanted to give an idea of what the code would look like if we just added the functionality. LMK what folks think.

btw, tests aren't written yet but I can do this for an example montage if people are friendly to the PR

CIs failed
please share a link to the rendered example
thx

Getting some weird behavior with Mayavi in building the docs which is why the tests are failing. The example runs fine if I just use python but when the docs build it the Mayavi figure somehow gets set to None.

looks like the circle test is passing now...@Eric89GXL how can I pull the artifacts from the docs build to see what the rendered HTML looks like? (and so I can post a link here)

Current coverage is 87.36% (diff: 9.75%)

Merging #3741 into master will decrease coverage by 0.05%

@@             master      #3741   diff @@
==========================================
  Files           343        343
  Lines         61000      61041    +41
  Methods           0          0
  Messages          0          0
  Branches       9326       9330     +4
==========================================
+ Hits          53326      53330     +4
- Misses         4924       4961    +37
  Partials       2750       2750

Powered by Codecov. Last update bc323fb...51ef986

https://3019-1301584-gh.circle-artifacts.com/0/home/ubuntu/mne-python/doc/_build/html/auto_tutorials/plot_ecog.html

@agramfort weird that the brain is upside down in this version. What version of mayavi do the docs use? I'm using the latest one which I think changed the behavior of screenshot so that it's up/dn flipped.
Also how did you get the link to the html? Or is that something that you guys only have access to?

ok got it !
how about
brain_montage_snapshot ?
or
snapshot_brain_montage?

maybe also
with_points -> hide_ecog_sensors ?

+1 to snapshot_brain_montage as well as to hide_ecog_sensors or maybe just hide_sensors since they don't technically have to be ecog

ok deal !

is there a way for me to grab the plot from the circle build w/o you needing to send the link? I think it will take a little tweaking to get the mayavi up/down behavior right, and I'll probably need to see what it looks like on the docs in the online build

you're now a member of mne-python org so you should see the artifact on
Circle
make sure to login on circle

ah great, thanks. I was confused why that wasn't showing up before. OK I'll take a pass at this later today

How do you guys deal with testing in Mayavi? I've found it to be really unpredictable (e.g. I'm not sure why the brain is flipped in the MNE docs, it doesn't render that way when I run the file on my computer). There are also cases where the Mayavi scene is set to None when I'm running tests, which is making it hard to test. Are there special considerations for getting mayavi to work in these cases?

On the current version of this PR I get an upside-down image of the brain with electrodes on it.
On my Anaconda install:
>>> import mayavi
>>> mayavi.__version__
'4.4.0'
>>> import matplotlib
>>> matplotlib.__version__
'1.4.3'

On my system install:
>>> import mayavi
>>> mayavi.__version__
'4.5.1.dev0'
>>> import matplotlib
>>> matplotlib.__version__
'1.5.2rc2+1930.g1bf3377'

What about your version of vtk @Eric89GXL ?
In [1]: import vtk
import
In [2]: import mayavi

In [3]: import matplotlib

In [4]: vtk.vtkVersion.GetVTKVersion()
Out[4]: '6.3.0'

In [5]: mayavi.__version__
Out[5]: '4.5.0'

In [6]: matplotlib.__version__
Out[6]: '1.5.3'

'5.10.1' and '7.0.0'. So probably a bug with VTK version 6-something.

Does PySurfer's brain.screenshot() method also produce upside-down images? If not, then look at the code there to see what you can use instead.

good question, lemme check pysurfer's screenshot w/ the last 3 major version numbers of VTK. Will get back to you

wow it seems like there are lots of interdependencies between vtk/tvtk/mayavi that have been changing over the last few releases. Having a hard time getting all the version numbers right so that things don't break. What can we assume MNE users are using in their vtk/mayavi setup? Whatever conda will install by default?

Yeah

kind of a bummer they haven't supported 4.5 yet...installing 4.4 on my machine downgrades a bunch of packages (e.g. numpy to 1.9.3-py27_3)

Someone mentioned a newer version being available on conda-forge.

but we can't assume users will use that, right? Need to assume whatever the default conda install mayavi will do?

Yes make it work for that please. It sounds like your 6.3 setup is pathological/exceptional in any case

ugh, ok, so after a bunch of debugging I think the problem is not with mayavi or vtk or any of that. The problem is a matplotlib backend. The issue is that I was debugging a lot of code with the notebook, which uses wxAgg as the backend. However running code via python was using just wx as the backend. If you manually set wxAgg then things behave differently.
I'm going to break it down below because there is some weird stuff going on. Here's the basic script I was running:
import mne
import surfer
import matplotlib.pyplot as plt
import matplotlib

subjects_dir = mne.datasets.sample.data_path() + '/subjects'
brain = surfer.Brain('sample', 'both', 'pial', subjects_dir=subjects_dir)

matplotlib.use('wx')
# matplotlib.use('wxAgg')
im = brain.screenshot()

fig, ax = plt.subplots()
ax.imshow(im)
plt.show()

And I would uncomment etc the wx lines to test the effects of the backend. I then ran this in both the notebook and via the command line. Basically, if I used wxAgg the brain is upside down, but using wx it is right-side up.
So at least it's not a vtk/mayavi problem. That said, what wx version does MNE-python use by default? (or if it's a different plotting backend what should we use?)

Some OSX people seem to use MacOSX backend, but Qt is what I use (and we recommend in the getting started pages)

ok, I'll switch it to be qt4 then. I think I changed it to wx a while back because of mayavi issues actually, but the plots seem to be working now :P
so if this is a matplotlib backend problem, I think it'd be better to just assume people use qt4, and maybe put a comment in the docstring saying "if you're getting upside down images, check your matplotlib backend". Does that work?

Latest push removes the flip_y parameter and adds a warning in the docstring. There are still 2 outstanding issues:

I can't use the ###### headers in order to make sphinx-gallery do its magic, because somehow fig.scene gets set to None if that header line is in there.
I'm not sure how to write tests for this because of the same problem in 1. fig.scene is None after calling plot_trans.

Perhaps there is some way to force the figure to persist even if it isn't being plotted on the screen?

Latest build of docs works now:
https://3035-1301584-gh.circle-artifacts.com/0/home/ubuntu/mne-python/doc/_build/html/auto_tutorials/plot_ecog.html
but see the appveyor error for what I'm talking about w/r/t the mayavi scene NoneType error...

So there are two incarnations of these errors, one in AppVeyor and another in CircleCI w/####?
For AppVeyor sometimes we can skip things if they cause problems that won't be experienced in practice. But it's weird that this happens on only the Windows CI and not the Linux one (Travis) that also runs Mayavi tests.

No the error shows up in both appveyor and travis (and the tests don't work on my computer when I run nosetests). The root issue is that the mayavi scene gets set to NoneType, which I think is what happens if you open a mayavi figure but then close it. The scene goes from a TVTKScene to None.
This problem happens in two different places, seemingly because of two causes.

In one case, if you're building sphinx-gallery documentation and you put the ##### after the initial mayavi figure creation, then an error pops up.
In the other case, running tests that require access to the fig.scene object will fail, because scene is set to None in the test.

http://t1.gstatic.com/images?q=tbn:ANd9GcR9CeiiEx6Wuh03gtYLxNmFkYgUntrZcmBiK--QmgEQZVXN-cKUje8O1NA :)

https://www.youtube.com/watch?v=3PbdyJ_ybSI

...but in all seriousness I'm not sure what to do about this bug...
here's the code that I am running:
    info = read_evokeds(evoked_fname)[0].info
    fig = plot_trans(info, trans=None, subject='sample',
                     subjects_dir=subjects_dir)
    xy, im = snapshot_brain_montage(fig, info)

if I put that code in a function (e.g. test_3d_to_2d()) then it returns the NoneType error. If I put the code outside of the function, then it works fine.

can you share a full script to replicate easily?

I narrowed the problem on the testing side a little bit. I found out that the problem actually only occurs when the @requires_mayavi decorator is there. If I comment that decorator and then just run the function in test_3d.py, it works fine. If I then uncomment that decorator, it breaks again...

Here's a link to a script that replicates this on my machine:
https://www.dropbox.com/s/rzed8o5u3xf2ab8/test_mne_mayavi.py?dl=0
It prints the type of fig.scene for 3 different plotting setups. On the last setup w/ a decorator, fig.scene is now NoneType for some reason.

It is probably because the original ones actually open windows whereas the test does not, as it calls mlab.options.backend = 'test'. So I guess you can skip the test there...?
But this shouldn't explain the sphinx_gallery issue.

So we just don't test those functions? In that case I should put some kind of warning in the docstring perhaps?
And for the docs, I found that if I include the ####### line, but call plot_trans after the header, then it works fine. The problem only occurs when you call plot_trans, then have a ########, then try to access fig.scene. So I could just add an extra call to fig.scene in the example. Would that work?

https://github.com/sphinx-gallery/sphinx-gallery/pull/161

So we just don't test those functions?

Actually what you can do is hack a solution. You know exactly what should be there, and we're just hitting a quirk of the test backend. So write your test, and when you hit the error, monkey-patch the fig.scene to have whatever property it needs to have before the call that needs it.

That's a good idea w/ the test. I'll try that and see if I can get it working, though that's the code that's pull out the "scene to camera" transformation matrix, so monkey-patching it might defeat the purpose of the test for that side of things. We could still test input checking etc though.

It looks like the main things we'd need to manually patch in there would be the clipping_size and method get_composite_projection_transform_matrix of the scene's camera, as well as the get_size method of the scene object.
Alternatively I could just do a few assert_raises tests to check for proper inputs etc. The error for the NoneType problem is a TypeError, so if we just check that we raise ValueErrors that would still cover some things...

Either way is fine by me

Will make changes when @Eric89GXL finishes comments, and will also update whats_new etc. How does this look like for the plots in the example now?
https://3050-1301584-gh.circle-artifacts.com/0/home/ubuntu/mne-python/doc/_build/html/auto_tutorials/plot_ecog.html

Not as good as my sphinx-gallery PR produces :)

nice :)
I can update this example whenever the sphinx-gallery fix goes live. That won't be until the next release of sphinx-gallery though, right?

we build the doc with sphinx-gallery master so it should be fast

ok sounds good, though just FYI there is a chance that after today I will decide to live the rest of my days as a recluse in the woods with limited access to the internet, so it would be good to get this merged before that.

OK so in an effort to pretend that life is continuing like normal, I made the changes suggested by @Eric89GXL. I removed the second call to plot_trans so the tutorial will fail now, but should start working once sphinx-gallery is updated.
How should we deal with the fact that code coverage checks are failing? I don't think we can test those functions with mayavi set to not plot things during tests...

This looks great!

@choldgraf my SG PR is getting stuck in API discussion, let's go ahead and proceed with this in its current form. Good to go from your end?

OK - I switched the example back to plotting the surface twice in that case. We can change it back when the SG code is changed. I think it's fine to pull, though code coverage isn't super happy because we aren't really testing a lot of the 3d to 2d transformation code...

code coverage isn't super happy because we aren't really testing a lot of the 3d to 2d transformation code...

Do you want to refactor it to be a a generic transformation function and put it in mne/transforms.py? It's probably overkill but if you feel a desire to save us some coverage you could.

can that potentially be a new PR? I'm at SfN right now feeling like I've spent too much time in the last few weeks doing coding stuff, and not enough doing research stuff :-/

Yeah that's fine with me

latest push has fixes along the lines of what you suggested

besides my nitpicks LGTM
can you just see why coverage decreased?

@agramfort coverage drops because some attributes in fig.scene are not set unless things are actually being rendered. The test backend doesn't have them.

ok. So let's address my nitpicks and merge !
you're almost there @choldgraf !

Sounds good, I'll get to this after the poster session this morning
On Wed, Nov 16, 2016, 10:28 AM Alexandre Gramfort<EMAIL_ADDRESS>wrote:

ok. So let's address my nitpicks and merge !
you're almost there @choldgraf https://github.com/choldgraf !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/pull/3741#issuecomment-261029782,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABwSHWz2Uf8Dov1CeWuIThNrVzk4KH-Zks5q-0tdgaJpZM4KqXRw
.

OK, latest push has these changes. If we ever figure out a way to let mayavi do plotting within tests, we can add tests for these matrix transformations. Otherwise we'll just have to keep an eye on the issues I suppose :-/

You need to rebase :(

that's weird...I just rebased before pushing the last commit

oops, I take that back, I had pulled into my own master but hadn't rebased yet...latest push has that

thanks @choldgraf

nice thanks!


Documentation for Time Distributed Layer

Documentation for Time Distributed layer in Keras mentions any Layer applied with it will be applied to every temporal slice
But in my assumption - for example consider mant-to-many sequence model trained for NER or Language Model with the following code, (if return_sequences==True) in the previous BiLSTM layer then Dense(n) and TimeDistributed(Dense(n))  are exactly the same and either of them can be used. Is my assumption correct?
model = Sequential()
model.add(Embedding(input_dim=voc_size, output_dim=embed_dim, input_length=50))
model.add(Bidirectional(LSTM(units=lstm_units,return_sequences=True),
                                         merge_mode="ave"))
model.add(TimeDistributed(Dense(n)))

@vignesh0710
Kindly open a stackoverflow issue for this as it is not a bug or feature request, Please post this kind of support questions at Stackoverflow. There is a big community to support and learn from your questions.
Thanks!

Created a CL with this change. Thanks!

@vignesh0710,
Yes, the assertion is correct. Please find this comment from Francois. Thanks!

@rmothukuru thanks. Can I close this issue thread then?

@vignesh0710,
No, please. The issue will be closed automatically once the CL is successfully submitted.


fix ACE in ∆i

(created by Steffan here)

Also ∆Ė

fixed by #868

but we still need to properly fix it

yeah, I'm going to make a real fix, I just want to mitigate it as quickly as possible on the production end

yes but we should reopen it then, right?

Sympy is unfixable. At some point we're gonna create Symvy, which will solve this.


Vendor file not found

Hello
vendor/autoload.php file not found. Where i find this file

Did you run composer install in the directory? That's what creates the file, for me.

where i find this composer install

Please google it: https://getcomposer.org/doc/00-intro.md


Newsletter-231-translate-in-French

ACK, thanks for translating this beast of a newsletter @Copinmalin !

I was not alone this time !
thanks too @Jluc-bitcoinfr and @fanismichalakis


Fix prop types silently being evaluated to nothing

Problems currently

oneOf is a union of possible values not types
indexing oneOf with number, string instead of calling it as a function is not a syntax error but oneOf has no property called the string value of string so the prop type will most likely be undefined which will silently not catch type mismatches.

Coverage decreased (-0.07%) to 91.379% when pulling c7b818f5b56a3e098427a69dd3a43f1a60c9ce18 on vinczemarton:master into dd68d50f054eaffdca4b835358d12105229ca5eb on coryhouse:master.

Great catch. Thanks! 👍


feat: fix workflow's coverage report

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


On event creation, raise if missing action network id on response

We suspect that there is some silent error case where Action Network API does not return an action network identifier on an event creation attempt. This PR makes a change to raise an error in this case, so that consumers can be aware of when it happens and handle appropriately.

I think it may, let's sync on this @wubini

See comment https://www.pivotaltracker.com/story/show/179727787/comments/227143281


Automatic detection of existing test framework.

Automatically detect which test framework a user is currently using.
Scanning the require statements should work for tap and tape.
Scanning for describe / it, etc. Should work for mocha.

Scanning for describe / it, etc. Should work for mocha.

Jasmine also uses describe/it.

Jasmine also uses describe/it.

Good point. Jasmine's assertion API differs from chai enough that I think we could make it automatic.
We could combine with examining devDependencies. That would be pretty reliable.

Also, we could just abandon this and give them a prompt. People are going to use these pretty rarely, so it may be better to just focus on providing really good, really smart transforms than focusing on little niceties that save them a few keystrokes. Actually, I think that is probably the better choice.

@jamestalmage Why not just check devDependencies? I can't think of a more reliable way than that.

You technically could have multiple test frameworks used in a large project (and the codemods become more and more valuable, the larger the project)

That honestly sounds like an extreme edge-case and premature concern, but if you really think this could be an issue, just fall back to requiring the user to specify which framework if it's ambiguous.

Also, we could just abandon this and give them a prompt

:+1: , don't see the value of trying to detect it. Feels error-prone and potentially hard (what if the user has two tests frameworks in a pretty big project, wouldn't want to prevent him to apply both transforms)


Fix #20

Note that I've also created a fix for version 3.5.0
https://github.com/SalomonBrys/android-maven-publish/tree/3.5.1
I cannot create a PR because there is no branch 3.5 in this repository

Coverage remained the same at 73.333% when pulling e1a70e3f91b368a4e805f8afe7ee2a2d9d38349f on SalomonBrys:3.6.1 into 6f52c05db1ace86b4b82d51ae29428fed2d0099a on wupdigital:master.

I created a branch for fix 3.5.0:
https://github.com/wupdigital/android-maven-publish/tree/support/3.5.x
Could you please add -SNAPSHOT after the version number in your PR?


Hook: implement IO.write

We need to implement https://github.com/runtimeverification/k/blob/master/k-distribution/include/kframework/builtin/domains.md#write-to-file. We will probably need to do something a bit hacky to implement this one, as it requires doing IO, so a bit of investigation is required.

Do we already support the system hooks already: https://github.com/runtimeverification/k/blob/master/k-distribution/include/kframework/builtin/domains.md#shell-access
If so, then IO.write should be implementable using that directly, though there is probably a more efficient way.

Not that I know of, so this will probably be more involved.


Ensure that generated todo files are created with consistent ordering

Not sure if this is a bug or feature request, but we've noticed that regenerating the todo.yml after adding or removing a violation often (always?) results in some reordering of the checks. This makes it hard for PR reviewers (or anyone looking back over commit history) to see what has actually changed.
Would it be possible to change this so that the ordering of checks in todo files is consistent? This would mean that looking at the diff in the database_consistency.todo.yml, only the added or deleted violations would be visible.
I have copied out the suggested workflow from our internal docs below, to give you an idea of what we're doing that's giving rise to this behaviour. These are the steps that devs are supposed to follow when fixing or adding a violation. (NB there are some violations that we do not intend to ever fix, so we store these in a separate .database_consistency.config.yml).
## What if I have fixed an existing violation?

- Once you have fixed an existing violation you will need to regenerate the `.database_consistency.todo.yml`.
- You can do this by deleting the existing `.database_consistency.todo.yml`, then by running `database_consistency` with the `--generate-todo` flag:

    bundle exec database_consistency --config .database_consistency.config.yml --generate-todo

Happy to try and recreate a minimal reproducible example if this inconsistent ordering behaviour is surprising.
Thanks again for your work on the gem, which is really appreciated.

Hi @greytape,
Thank you for your kind words! I would be happy to help with this request!
The ordering of executing checks is always the same. We don't have any "randomizer" in between to shuffle it. Could you please provide or at least describe in differences only the steps?

P.S. I'm so happy you use the gem an have internal guidelines!

Hi @greytape!
Thank you for the investigation and for sharing the results! I also think your suggestion makes a lot of sense.
Sorry that it took me long to respond! Could you please open the PR? I would be happy to merge it and release it.

I released it in 1.7.8. Please try it and let me know if it works for you. Thank you for the suggestion! Please keep it going!


Mobile phone display abnormal

My object need online pdf,used this plug-in,opend pdf the page number is right，but no content,there is a picture of my pdf files.

There is not nearly as much information as required for us to look into this issue. Please read https://github.com/mozilla/pdf.js/blob/master/CONTRIBUTING.md carefully and provide the mentioned information (OS name/version, console warnings, details about the hardware, et cetera). Closing as incomplete for now.


[Server Affinity] - Attach dwsid to SCAPI request headers

Description
For a Phased Launch storefront, SCAPI requires each request to contain ECOM dwsid in sfdc_dwsid header with each request.
To allow PWA Kit to read dwsid from cookies we require the cookie to be set with httpOnly=false.
Plugin SLAS manually sets response cookies and has been setting dwsid with httpOnly=false
We can leverage that cookie to be used in PWA Kit to send with each SCAPI request.

Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[x] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes

Added sfdc_dwsid header to all requests made in commerce-sdk-react

How to Test-Drive This PR

(Logon to www.phased-launch-testing.com

Clear Site Data using DevTools

Load Home Page

Open Network Tab and confirm /sessions requests are not made

Open Cookies and confirm dwsid is not being set

Add item to cart and navigate to cart page

Open cookies and verify dwsid is now set

Navigate back to PWA Kit page

Inspect any SCAPI request and confirm sfdc_dwsid exists in request headers

Checklists

General

[ ] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[ ] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[ ] Changes comply with WCAG 2.0 guidelines levels A and AA
[ ] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

Should we modify the config files in template-retail-react-app and the generator to remove the OCAPI proxy? I think our test mocks set up an OCAPI proxy mock that we'll need to clean up too.

Is this the only url/api that uses ocapi?

Should we modify the config files in template-retail-react-app and the generator to remove the OCAPI proxy? I think our test mocks set up an OCAPI proxy mock that we'll need to clean up too.

Is this the only url/api that uses ocapi?

Yes. It was the only OCAPI call we were making.

@vcua-mobify @unandyala Great callouts about OCAPI proxy. I tried removing the proxy and ran tests on the deployed store. Looks good to me.

One more spot we might want to clean up: https://github.com/SalesforceCommerceCloud/pwa-kit/blob/feature/server-affinity-cleanup/packages/pwa-kit-react-sdk/setup-jest.js#L35

This might be a separate clean up ticket but the generator prompts is for an instanceUrl that, according to a comment in the generator, is only used to set up the OCAPI proxy: https://github.com/SalesforceCommerceCloud/pwa-kit/blob/feature/server-affinity-cleanup/packages/pwa-kit-create-app/scripts/create-mobify-app.js#L801

This might be a separate clean up ticket but the generator prompts is for an instanceUrl that, according to a comment in the generator, is only used to set up the OCAPI proxy: https://github.com/SalesforceCommerceCloud/pwa-kit/blob/feature/server-affinity-cleanup/packages/pwa-kit-create-app/scripts/create-mobify-app.js#L801

Yeah. I'm leaving all generator changes out of this PR. I'll have a follow up ticket for that since it involves testing and changes to tests as well.


Link to "Gcloud" redirects to Not Found page

Clicking the nested "Gcloud" link in the left nav leads to the "Not Found" page.

I am guessing that this is due to missing JSON docs content for this type, which has no public members.

This was fixed today by updating gcloud/docs/toc.json in #1002.


[BUG] refresh in chain detail screen not working

Describe the bug
The refresh button on chain detail screen is not working
Expected behavior
Able to refresh the balance on chain detail screen.
Screenshots

Version 1.0.2

@antoni0dev please check, we need to complete it still


Fix: Bug many to many with custom keys in both entities

Coverage remained the same at 100.0% when pulling bad03ceb3b54d98df68fd19c9d4b6a39636f3e3c on fix/bug-many-to-many-custom-keys into fb18acb47864561f1174cc813e59a1cfbac21a22 on master.


plugins/todo-comments: migrate keymaps to mkMapOptionSubmodule

Follow up to https://github.com/nix-community/nixvim/pull/2030 can now be done since https://github.com/nix-community/nixvim/pull/2040 is implemented.

@mergifyio queue


terminate window cause node to stop

hello guys,
in my code, I need to open a window, do some processing then terminate it then continue doing some processing.
but once I terminate the window the whole node code stop suddenly without any error, nothing is getting executed after window termination.

resolved by moving the whole WebView related code in a separate worker.

Thanks for your feedback, this will be documented.


Add additional data for device groups by id

Description
Add additional data for the device property for /device-groups/{id} to match the data that is returned for /devices so the UI can display a list for devices that belong to a device-group.
Fixes # (THEEDGE-1831)
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I run go fmt ./... to check that my code is properly formatted
[x] I run go vet ./... to check that my code is free of common Go style mistakes

/retest


Restructure Contribute and Integrate & Extend sections.

Summary
This is a little clunky, but merging these sections required a lot of little changes in a ton of different files.
Here's a summary of everything these commits do:

Created 2 new pages for contribute/getting-started and /integrate/getting-started
Refactored all instances of non-image URLs containing` /extend/ to /integrate/
Moved all child content from Extend section to Integrate, created aliases for every document that was moved to handle redirects.
Replaced Extend on the homepage with Development Guides
Removed Extend from top nav
Reorganized items in the left nav bars for contribute and integrate sections.

I've tested everything locally, and it all seems to be working fine. But, I'd appreciate a 2nd set of eyes to make sure I haven't missed anything important.
Ticket Link
n/a

@BenLloydPearson - This is a really great PR. Thank you!!
There's one thing I've noticed throughout the PR that we should update before merging. Reference links in the following format should be changed to Hugo-friendly ref links so that they can check and resolve automatically:
The plugin [developer setup](/integrate/plugins/developer-setup/) and [developer workflow](/integrate/plugins/developer-workflow/) pages are useful to learn about the plugin development environment. You can find more information about plugins in general [here](/integrate/plugins/).
See this page as an example of how to format the ref links. Links formatted this way don't require us to change the link later if things move around. The ref is then looking for the MD file, rather than the path.
CC @justinegeffen @hanzei - Please correct me if I've mis-communicated our preferred link approach in the developer documentation set.

@cwarnermm I updated the new content that I generated with the appropriate markdown file references, but some of them are links to _index.md files inside directories and I'm not sure how to handle those. I also spotted a few links I needed to update to work with the new other-integrations sub-directory that I created.
However, many of the pages that I modified to update the URLs aren't currently following your recommendations. I agree that we should be consistent, but is that something we should create a separate issue to resolve? There are potentially hundreds of links that we'd need to review.

@BenLloydPearson, there are definitely a ton of inconsistencies in the docs which is something we should address long-term. What I've been trying to do is, going forward, use the Hugo ref as per @hanzei's recommendation. We will eventually get all the internal links changed to refs but that's a whole other set of work.
You mention that some are links to _index.md files inside directories - I don't actually know what the ref would be (good catch!). @hanzei, can you help out here?
Otherwise, this is an awesome PR and much-appreciated. :)

@BenLloydPearson - Agreed completely that there are likely hundreds of problematic links worth updating. That's definitely not on your a requirement of this PR.
However, if you're open to it, it would be great if the links within the scope of these PRs were updated based on @hanzei's recommendations.

@cwarnermm I've updated all of the links that are affected by this PR to the appropriate file references. I also realized that I forgot to create content for the new Other Integrations page, and I also corrected this.
I think this should address all of the concerns raised in this PR.
P.s. for _index.md files, the references look like this: ({{< ref "/integrate/" >}}) to get the _index.md inside the integrate directory.

 They should mainly be URL updates but they seem like they may be complex as GitHub requires them to be resolved in the command line. Let me know if you need any help with this.

I think I can see what happened - all the docathon changes were full URLs but these docs have all had the (correct) references added in the interim. Not sure how to resolve that easily. :(

@justinegeffen This should be ready to be merged now. One of the link changes is no longer relevant because it was removed in my new version. The other has been updated.


Build for Android 2.3 and below.

I just successfully tediously managed to compile a version and what did I get. Seriously speaking I got parsing error. Am using Android 2.3. Please is the app limited to only Android Api 22.

You need to provide more information on the issue if you need help.


Make button styles more accurate

I don't really use the stylesheet language that this project does, but I have HTML and CSS that imitates the default style of the button element in IE 4 on Windows 3.1x on a standard VGA display. The HTML is simply <button>Button Contents</button>
The CSS is:
button {
width:auto;
border-top:2px outset #FFF;
border-left:2px outset #FFF;
border-bottom:2px outset #000;
border-right:2px outset #000;
color:#000;
background-color:#CBD1D2;
padding:3px 2px;
font-weight:800;
}
button:active {
border-top:2px inset #000;
border-left:2px inset #000;
border-bottom:2px inset #FFF;
border-right:2px inset #FFF;
}
button:focus {
    outline:0;
}
button span {
    display:inline-block;
    border:1px solid #CBD1D2;/*Same color as button background*/
    -webkit-transform:scale(0.9,1.2); /* Safari and Chrome */
    -moz-transform:scale(0.9,1.2); /* Firefox */
    -ms-transform:scale(0.9,1.2); /* IE 9 */
    -o-transform:scale(0.9,1.2); /* Opera */
    transform:scale(0.9,1.2); /* W3C */
}
button:focus span {
    border:1px dotted #AAA;
}
Obviously, this displays more smoothly than the real browser, and is grayer than windows 95/98/NT 4/2000/ME(the windows 9x color scheme is more tan and I would probably have all 4 borders the same and just switch between inset and outset if I was simulating those versions of windows). The transform(s) and font-weight just make the default font look more like the default font in IE 4(it looks bolder, taller, and thinner than the standard fonts in modern browsers).

To me, the current button style looks more like windows 3.x than windows 95-2000/ME. IE 4's buttons are actually shaped more like Windows 9x/NT 4/ME/2000 buttons. Windows 3.x's buttons actually have rounded corners and swap from beveled out to flat and shift down and right when they're clicked, but Windows 9x/NT 4/ME/2000's buttons have square corners and just swap from beveled out to beveled in when clicked.


Document Customer API IN component-test module

Documented the Customer API IN the component-test module as per feedback on the mailing list.

Hey @Izakey
I ran the tests and customerApiDocs test all pass but for some cassandra timeout problem some tests in IdentityAPIDoc tests are ignored.
Here is the error: com.datastax.driver.core.exceptions.OperationTimedOutException: [localhost/<IP_ADDRESS>:9142] Timed out waiting for server response.
Did you ever face this problem? It might be due to my machine properties.
Apart from that, everything looks good so far.

Hey @awasum
ALL unit tests pass in my case, 15 in CustomerApiDocumentation and 9 in IdentificationsApiDocumentation. I don't face any timeout issues with Cassandra.
Any issues in the code with respect to style ?

Yes, Adjust your line start line for classes and methods to 2 lines not tabs. Just add another commit here and I will merge.

adjust the highlighted setting in your IDE then reformat by going to Code -> Reformat Code while in the source file.

LGTM. Thanks @Izakey
I am merging now.


ccm patch update from 1-28+

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold


Improve maintainability of dotnet tests

Some test fixtures are very long, due to complex setup; review if these can be simplified to reduce difficulties in maintaining the codebase.

Introduce helpers/builders?
Split up test fixtures into sub-fixtures

Fixtures with 500+ lines:

File
Lines

DivisionDataDtoFactoryTests.cs
1978

DivisionServiceTests.cs
1024

TemplateToHealthCheckAdapterTests.cs
887

DivisionFixtureDateAdapterTests.cs
855

FinalsNightReportTests.cs
853

UpdateScoresCommandTests.cs
814

AddressAssignmentStrategyTests.cs
744

DivisionDataGameVisitorTests.cs
742

AddOrUpdateTournamentGameCommandTests.cs
696

SeasonTemplateServiceTests.cs
642

RequestedDivisionOnlyReportTests.cs
633

AddOrUpdateTeamCommandTests.cs
623

GameServiceTests.cs
610

GameAdapterTests.cs
600

DivisionFixtureAdapterTests.cs
559

DataServiceTests.cs
541

WatchableDataDtoAdapterTests.cs
508

UserServiceTests.cs
508

FixtureDateAssignmentStrategyTests.cs
502

 get-childitem -recurse | where-object { $_.Name.EndsWith(".cs") } | select-object { "$($_.Name)`t$((Get-Content $_.FullName | Measure-Object -Line).Lines)" } | out-file lines.csv


VSC fails to launch 0xc00004b4

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:  Windows 10

Steps to Reproduce:

When I click to launch it appears a window
The window says : The application could not be started correctly(0xc00004b4) Click OK to close it.

This happened since 20 of August 2023.

Hi, can you attach a zip file of the crash dump following the instructions on Creating a crash report?
Also, which version of VS Code or VS Code Insiders are you on?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Added transferinfo REST API to access ReqMgrAux transfer related docs

Fixes #9198
Status
not-tested
Description
Created a new ReqMgr2 transferinfo REST API to be used to manage TRANSFER type documents under the reqmgr_aux DB.
There was no need to create a couch view, because it had already the precise view I needed (which was buggy though).
Last but not least, I made it possible to fetch all the documents under a given document/config type by providing a document name ALL_DOCS.
Is it backward compatible (if not, which system it affects?)
no, it depends on a new version of ReqMgr2 (and agents need to have the client part).
Related PRs
no
External dependencies / deployment changes
no

test this please

test this please

@vkuznet can you please have a look at this PR? It implements the REST apis to pull/push transfer documents to couch.

First, it is unclear why capitals should be used.
Second, in curl we use _all_docs (lower case) to access all docs in given
database.
Therefore, I thought it would be beneficial and consistent to use lower case
notation.
On  0, Alan Malta Rodrigues<EMAIL_ADDRESS>wrote:

amaltaro commented on this pull request.

@@ -169,7 +171,10 @@ def get(self, subName=None):
"""
try:
if subName:

           docName = "%s_%s" % (self.name, subName)

           if subName == "ALL_DOCS":

Is it a concern that something might change the arguments encoded in the url? Or just to make it easier to people interacting with this API?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/9302#discussion_r306507700

Again, put the comment in a code to avoid question I raised.
Plus it would be beneficial to explain why this value is used, i.e.
why 73.85 and not 1231.2349829304?
On  0, Alan Malta Rodrigues<EMAIL_ADDRESS>wrote:

amaltaro commented on this pull request.

@@ -140,7 +140,7 @@ def testRequestSimpleCycle(self):
self.assertEqual(len(response), 1)
clonedName = response[0]['request']
response = self.reqSvc.getRequestByNames(clonedName)

   self.assertEqual(response[0][clonedName]['TimePerEvent'], 15)

   self.assertEqual(response[0][clonedName]['TimePerEvent'], 73.85)

this value comes from the json template we load in the setUp() step
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/9302#discussion_r306506524

_all_docs is used when querying Couchdb directly. That's why I choose all capitals, to not confuse a couch native API with a ReqMgr2 REST API.
Nonetheless, I updated the code to consider all combinations of capital/non-capital.


Add "Skip to main content" to content pages

Fixes

Fixes #449 by @obulat
Description

This PR adds the "skip to main content" link to the content pages (About, Sources, etc).
It also updates the way VSkipToContent works. Instead of focusing on the first tabbable element inside the "main content", it focuses on the "main content" itself. This way, when you click "skip to content", the screenreader reads the main content instead of reading the first link.
 You should see the "Skip to content" button appear at the top. When you click on it, if screen reader is on, you should hear the first heading or the text of the main content.
Checklist

[x] My pull request has a descriptive title (not a vague title like
Update index.md).
[x] My pull request targets the default branch of the repository (main) or
a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible
errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Just noting: reviewer assignment based on the CODEOWNERS file didn't work properly 😢 I'll add this to the monorepo tasks: https://github.com/WordPress/openverse/issues/384


Dynamic Extractor is not working anymore in 1.4.2

Hello.
Thanks for the great package.
I used the extractor public property to set the extractor dynamically like this because I have multiple extractors for different purposes:
$svg->extractor = app(FirstAlphaNumericExtractor::class);
In 1.4.2 the property was changed to protected, so it stopped working.
Is it possible to add support for dynamic extractors again? Maybe a simple getter/setter.
Thank you.

That was actually a design flaw, it was never meant to be a public property. You're supposed to set custom extractor using the extractor key in the config. Actually I never thought there would be use cases for more than one extractor.
I'll try to resolve this. Thank you.

@vovarpd This is actually still possible to use on demand extractors. You can use the App facade to do so.
App::bind(Extractor::class, fn () => new CustomExtractor());

Hope that resolves your issue.


Twitter Notifications fail in 0.53.1

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.53.1
Python release (python3 --version):
Python 3.4.2
Component/platform:
notify.twitter
Description of problem:
Basic Twitter notifications don't work.
Expected:
Problem-relevant configuration.yaml entries and steps to reproduce:

Neither calling the service directly {"message":"Hello World!"} or calling via scripts/automations work.
Reverting twitter.py to the version in 0.52.1 works correctly.

Additional info:
No logging/tracing to indicate anything amis, and tcpdump shows HA isn't making a connection to Twitter.

I had same problem, also seemed to cause home assistant to restart at times when trying to tweet.
reverted to 52.1

Neither calling the service directly {"message":"Hello World!"} or calling via scripts/automations work.

I'm experiencing this too; nothing in the logs to indicate there is even an issue.

Apologies, @lukewayne @mannkind. Fixed in #9448. Targeted by @balloob for 0.53.2.


Activation Events shouldn't be *

https://code.visualstudio.com/api/references/activation-events#Start-up
The better configuration maybe:
[
     "workspaceContains:**/*.ans",
     "workspaceContains:**/*.ansi",
]

Fixed by relying on implicit activation events available as of VSCode 1.74.0


TOC doesn't work in 1-file docs

The problem
When I click a position in the Table of Contents (TOC), the URL changes, but nothing happens. So, it's impossible to navigate the huge docs in one file https://docs.perl6.org/perl6.html.
The problem exists on Kubuntu 17.10 / Chromium and Firefox, Windows 7 / Chrome, Windows XP / Chrome, Linux Mint 18.3 / Chromium and Firefox.
Suggestions
To fix the problem. Thanks!

Maybe it's not using the new module. Let me see to that and thanks for warning.

TOC works now, but index does not.

That's much better, thanks!

@JJ Thanks, everything works!


How to save the prediction results?

Hello, thanks for your contributions to RT-DETR! @lyuwenyu
And is there any code in place to save the predictions while inference? I haven't seen relevent setup yet. Could you please tell me more details about it or do you have any plans to implement this feature? Thanks again.

There is not related code, I think you can do it in deployment code.