ENH new README version

A redesign of the README file.
See it live

very beautiful @Badr-MOUFAD !


Postmortem: Incorrect rt-alias-key derivation in FMC

The key derivation done by the FMC (label "rt_alias_cdi") is not conformant with the HMAC-SHA-384 specification. The HMAC computation only includes the first HMAC block, and is missing a second block which includes padding and a length suffix. This is not believed to be a security issue, as (by luck) all measurements are in the first block. If circumstances were slightly different, the consequences to these mistakes could have been a lot worse, so a post-mortem is necessary.
Background
Issue #1520 was filed, noting that the rt-alias public key differed between the RTL and the sw-emulator. This occurred because the driver/hardware was ignoring all blocks except for the first one in the derivation, but the sw-emulator implementation processed all blocks "correctly".
Causes
When consuming keys from the keyvault, the combination of the HMAC peripheral and driver only include the first 128-byte data block in the computation. The multi-block case is decently well tested by driver tests when operating on data and keys supplied and retrieved by the CPU, but when operating with keys supplied by (and result written to) the key-vault, the hardware clears the key after processing the first block, and subsequent blocks are ignored. This behavior was not called out in the hardware spec. I think folks assumed there would never be a need for multi-block HMAC for key derivation; and there wasn't, until somebody tweaked the derivation logic to use HKDF, which expanded the data beyond what would fit in a single block. I believe the systemic root causes are miscommunication between the hardware and firmware teams, and missing validation at several layers of the stack:

hardware: missing validation for the multi-block HMAC key-vault use case.

hardware spec: missing documentation of how the HMAC/key-vault multi-block usage differed from the non-key-vault usage.

firmware: missing multi-block HMAC key-vault driver test case (this is somewhat tricky because the direct results of the computation are kept secret from the CPU)

firmware: missing assertion in end-to-end tests to independently derive the rt-alias-key from UDS and measurements and confirm it matched the public key in the cert.

I have confirmed in PR #1528 that reloading the key from the keyvault and reprogramming the destination registers after each block works around this multi-block issue in the driver.
What went well?

The ROM was not affected. The smoke-tests independently confirm the derivation of the ROM-generated fmc-alias-key from the UDS and measurements.

What went wrong?

Validation at several layers of the stack failed to notice this issue.

Where we got lucky

The sw-emulator HMAC implementation diverged from the RTL implementation, and somebody noticed the derivations weren't consistent.

The ignored HMAC block doesn't include any actual measurements (it just has padding + length):
# block 0 (this block included in rt_alias_cdi)
00000000  00 00 00 01 72 74 5f 61  6c 69 61 73 5f 63 64 69  |....rt_alias_cdi|
00000010  00 03 91 03 63 1e f7 9d  36 a1 5c 5a 38 07 ca 6a  |....c...6.\Z8..j|
00000020  71 42 de c4 7e 3c 90 8c  aa 9c 41 2b be 83 71 92  |qB..~<....A+..q.|
00000030  0a fe a7 2b ed 4d 52 a4  f0 7b c3 bb 7d b6 50 3f  |...+.MR..{..}.P?|
00000040  7e cb 5a c2 23 45 70 96  84 6a 6c da 09 3a 03 f2  |~.Z.#Ep..jl..:..|
00000050  78 c5 52 19 5f bb e4 76  26 2b 4d 05 90 60 b5 18  |x.R._..v&+M..`..|
00000060  28 54 df 20 81 0f a8 fe  59 2a 3c 3c e9 a5 27 bc  |(T. ....Y*<<..'.|
00000070  27 80 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |'...............|
# block 1 (this block was skipped)
00000080  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
00000090  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
000000a0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
000000b0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
000000c0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
000000d0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
000000e0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
000000f0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 07 88  |................|

Action Plan
(Do not mark this bug completed until all tasks are complete)

[ ] Add workaround to driver to support multi-block HMAC with keyvault keys (#1528)
[ ] Add driver test-case for multi-block keyvault-based HMAC (#1527)
[ ] Add end-to-end test assertion for FMC derivations (#1526)
[ ] Add end-to-end test assertions for runtime/DPE derivations (TBD)
[ ] Add HMAC/keyvault/multiblock validation test to RTL (TBD)
[ ] Update hardware specification with keyvault/multiblock usage details (TBD)

Opened https://github.com/chipsalliance/caliptra-sw/issues/1552 to track task 4 above


Cant build

CS0246 The type or name of the namespace "dnlib" could not be found (perhaps there is no using directive or assembly reference), the names "dnlib" (perhaps there is no using directive or assembly reference). DEObfuscar DEObfuscar Form1.cs Form1.cs 4 5
The type or name of the space could not be found
CS0246 The type or namespace name "dnlib" could not be found (perhaps the using directive or assembly reference is missing). DEObfuscar Form1.cs 6
CS0246 The type or namespace name "dnlib" could not be found (perhaps the using directive or assembly reference is missing). DEObfuscar Helper.cs 1
CS0246 The type or namespace name "dnlib" could not be found (perhaps the using directive or assembly reference is missing). DEObfuscar Helper.cs 2
CS0246 The type or namespace name "MethodDef" could not be found (perhaps the using directive or assembly reference is missing). DEObfuscar Helper.cs 16
CS0246 The type or namespace name "TypeDef" could not be found (perhaps the using directive is missing


Symbol provider not working

Hi,
the symbol search in elixir files does not work for me, when I invoke "Go To Symbol In FIle" with Ctrl+Shift+O I only see No symbol information for this file.
As I would like to use it to quickly move between functions, as I do in spacemacs, I did a little search and found there is an implementation that should work - vscode-elixir/src/elixirSymbolProvider.ts. I even see it is registered in the main file elixirMain.ts#L60
Why doesn't this work? Is it turned off on purpose or is that a bug?

I havent come around to release this version yet. Will try to do so this week.

Ah, good. I think I tried running the extension from source and saw no difference, but that was some time ago. I'll try the same today and let you know.

OK, on master it also doesn't work, although it behaves differently. On master it seems to be processing the file, as it displays an indefinite progress bar below the search input - https://imgur.com/a/e6K3H.

@Coffei full support for this is in the PR: https://github.com/fr1zle/vscode-elixir/pull/117 ... waiting for merge :)

OK, I got confused since the provider in master looks like it should do something but doesn't. Since we already have a PR for better implementation I guess we can close this issue.
Thank you!


Instructions for lovelace (icons etc).

I'm missing instructions for creating a nice Lovelace sensor for this component. Just like the picture shows.

Lovelace configuration is pretty personal. You can browse my hass config as an example, and you may find some useful information within the lovelace documentation. Good luck!

Your hass config does not include a lovelace config. I think a lot of people would find it helpfull (even when its personal preference)


swap time parameters in FixedWingPositionControl

The time constant parameters for TECS get mixed up in FixedWingPositionController, which is fixed here.
Mixup was introduced with commit 3dc23afb3e1, exchanging values 5.0 and 8.0:
PARAM_DEFINE_FLOAT(FW_T_TIME_CONST, 5.0f);
...
PARAM_DEFINE_FLOAT(FW_T_THRO_CONST, 8.0f);

Seems not to have a big impact, therefore we can probably simply swap them back.

Cherry-picked for v1.11.


spring-boot-prow-9 to 0.0.13

Promote spring-boot-prow-9 to version 0.0.13

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Issue on "learn to complete prototype"

Thanks for your interesting work.
We reproduce the results on the MiniImagenet ,When you learn "complete prototype", why not use the ".. / data / mini_imagenet_part_priority_train. Pickle" obtained by constructing the primitive knowledge for all classes, but use the ". / data / mini_imagenet_part_priority. Pickle" obtained by not knowing how.

The above two file is same


Add background in the hero section

Is your feature request related to a problem? Please describe.

Describe the solution you'd like
The hero section has no background. I would like to add background to it so that it looks good.
Please assign it to me under gssoc'23
Describe alternatives you've considered
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

thanks for the suggestion but we don't need it for now.


PUBLISH packet should NOT update the outgoing queue

Broker uses brokerCounter to track how many packets it emits, as messageId will be rotated after it reaches max 65535. If there are two PUBLISH packets which brokerCounter is different but same messageId, the second PUBLISH will update the first slot in the queue, as outgoingUpdate is using for loop starting at index 0.
We use outgoingEnqueue or outgoingEnqueueCombi to enqueue PUBLISH packets, and and use outgoingUpdate to update those PUBLSIH items to next state (say PUBREL), so outgoing array should not contain PUBLISH

What other persistences do you want to check?

aedes-persistence-mongodb https://github.com/mcollina/aedes-persistence-mongodb
inherits from aedes-cached-persistence
aedes-persistence-redis https://github.com/mcollina/aedes-persistence-redis
inherits from aedes-cached-persistence
aedes-cached-persistence https://github.com/mcollina/aedes-cached-persistence
does not depend on aedes-persistence
They all treat aedes-persistence functions as interfaces, and implemented by themselves. Quite confident it won't affect those.

what's the difference between this and #31?

https://github.com/mcollina/aedes-persistence/pull/31 is a superset of https://github.com/mcollina/aedes-persistence/pull/30
I just take a snapshot of my develop branch for a review.
If #30 is not good, #31 is required to change also. :)

Just wanna submit a small change for ease to have a review. :)

Can we close this and I review #31 instead?

sure.


Inconsistent parse results from simple ambiguous grammar

Describe the bug
I have a small grammar that is a starting point to parse regular expressions. When run repeatedly on the same input Lark produces two different parse trees.
There is an ambiguity in my toy grammar because a RE quantifier (*, +, ?) can also be interpreted as a printable_char (ASCII values between space and tilde). However my reading previous issues (#81, #83) indicates inconsistent parse results should be treated as a bug (and it was certainly a surprise).
To Reproduce
Lark 1.1.9, Python 3.10.12.
#!/usr/bin/env python

from lark import Lark

parser = Lark('''
start: factor+

?factor: atom quantifier?

quantifier: "*" | "+" | "?"

?atom: DOT | printable_char

printable_char: /[ -~]/

DOT: "."
''')

regex = r'a.?'
tree = parser.parse(regex)
print(tree.pretty())

Sample results
start
  printable_char	a
  .
  printable_char	?

start
  printable_char	a
  factor
    .
    quantifier

Does this still happen with the latest master? (pip install git+https://github.com/lark-parser/lark)

Yes, it does still happen. (pip list reports 1.2.0, I still get two different results).
I also see discussion https://github.com/lark-parser/lark/discussions/1288 and setting environment variable PYTHONHASHSEED=0 does indeed yield consistent results (the second of those presented above). Similarly increasing the priority to quantifier.2 also fixes it for me.

@mcarpenter Try the latest master again. (you might need to uninstall lark first)

That got it, thanks.


Crash: invalid memory address or nil pointer dereference

Pocketbase instance crashing while doing nothing
Yesterday I just installed pocketbase instance in cloud like usually via dockerfile, new instance fresh install fresh database just filling out bunch of schema and testing it works
today its crashes with this log
2023/04/05 20:45:46 Server started at http://<IP_ADDRESS>:8080/
➜ REST API: http://<IP_ADDRESS>:8080/api/
➜ Admin UI: http://<IP_ADDRESS>:8080/_/
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x7d3169]
goroutine 3565 [running]:
database/sql.(*Rows).close.func1()
/opt/hostedtoolcache/go/1.20.2/x64/src/database/sql/sql.go:3287 +0x29
database/sql.withLock({0x243b740, 0xc0003ce000}, 0xc0007c0700)
/opt/hostedtoolcache/go/1.20.2/x64/src/database/sql/sql.go:3405 +0x8c
database/sql.(*Rows).close(0xc00015c000, {0x24358c0, 0x30d3420})
/opt/hostedtoolcache/go/1.20.2/x64/src/database/sql/sql.go:3286 +0x16d
database/sql.(*Rows).awaitDone(0xc0007c07d0?, {0x2443fd8, 0xc00015e000}, {0x0?, 0x0?})
/opt/hostedtoolcache/go/1.20.2/x64/src/database/sql/sql.go:2940 +0xd2
created by database/sql.(*Rows).initContextClose
/opt/hostedtoolcache/go/1.20.2/x64/src/database/sql/sql.go:2924 +0x158

I have 2 instance running this one crash while the other one (0.12.3) already run for 1 month old perfectly fine
from the looks of it, I assuming its Go Garbage Collector doing something wrong

I'm not sure how to reproduce it. Please provide a minimal reproducible repo or at least details about your setup:

What PocketBase version you are using?

If you are using PocketBase as framework could you share your main file and how you initialize the application?

I'm not sure how to reproduce it. Please provide a minimal reproducible repo or at least details about your setup:

What PocketBase version you are using?

If you are using PocketBase as framework could you share your main file and how you initialize the application?

pocketbase version 0.14.2
prebuild
I make 1 collection of images with title,description and file images as schema then connect it via http and it just it

using these dockerFile. I dnt see anything wrong because its works yesterday and now it crash while no one use it (collection schema has only 1 account and it just me who can access it)
FROM alpine:latest

ARG PB_VERSION=0.14.2

RUN apk add --no-cache \
    unzip \
    # this is needed only if you want to use scp to copy later your pb_data locally
    openssh

# download and unzip PocketBase
ADD https://github.com/pocketbase/pocketbase/releases/download/v${PB_VERSION}/pocketbase_${PB_VERSION}_linux_amd64.zip /tmp/pb.zip
RUN unzip /tmp/pb.zip -d /pb/

EXPOSE 8080

# start PocketBase
CMD ["/pb/pocketbase", "serve", "--http=<IP_ADDRESS>:8080"]

Hm, I don't see anything unusual in the above.
It could be a disk or OOM error, I'm not sure. Are there any more details to the stacktrace?

Hm, I don't see anything unusual in the above.
It could be a disk or OOM error, I'm not sure. Are there any more details with the stacktrace?

that's the only log, this is reproduce schema maybe it can help.
[
    {
        "id": "_pb_users_auth_",
        "name": "users",
        "type": "auth",
        "system": false,
        "schema": [
            {
                "id": "users_name",
                "name": "name",
                "type": "text",
                "system": false,
                "required": false,
                "options": {
                    "min": null,
                    "max": null,
                    "pattern": ""
                }
            },
            {
                "id": "users_avatar",
                "name": "avatar",
                "type": "file",
                "system": false,
                "required": false,
                "options": {
                    "maxSelect": 1,
                    "maxSize": 5242880,
                    "mimeTypes": [
                        "image/jpeg",
                        "image/png",
                        "image/svg+xml",
                        "image/gif",
                        "image/webp"
                    ],
                    "thumbs": null
                }
            }
        ],
        "indexes": [],
        "listRule": "id = @request.auth.id",
        "viewRule": "id = @request.auth.id",
        "createRule": "",
        "updateRule": "id = @request.auth.id",
        "deleteRule": "id = @request.auth.id",
        "options": {
            "allowEmailAuth": true,
            "allowOAuth2Auth": true,
            "allowUsernameAuth": true,
            "exceptEmailDomains": null,
            "manageRule": null,
            "minPasswordLength": 8,
            "onlyEmailDomains": null,
            "requireEmail": false
        }
    },
    {
        "id": "ydbb2iyv448f0t9",
        "name": "images",
        "type": "base",
        "system": false,
        "schema": [
            {
                "id": "i9lj2rsa",
                "name": "image_variable_name",
                "type": "text",
                "system": false,
                "required": false,
                "options": {
                    "min": null,
                    "max": null,
                    "pattern": ""
                }
            },
            {
                "id": "4arv3bxq",
                "name": "image_description",
                "type": "text",
                "system": false,
                "required": false,
                "options": {
                    "min": null,
                    "max": null,
                    "pattern": ""
                }
            },
            {
                "id": "vrz80vtb",
                "name": "image_link",
                "type": "file",
                "system": false,
                "required": true,
                "options": {
                    "maxSelect": 1,
                    "maxSize": 52428800,
                    "mimeTypes": [
                        "image/jpeg",
                        "image/png",
                        "image/svg+xml",
                        "image/gif",
                        "image/webp"
                    ],
                    "thumbs": [
                        "480x720"
                    ]
                }
            }
        ],
        "indexes": [],
        "listRule": "",
        "viewRule": "",
        "createRule"<EMAIL_ADDRESS>!= \"\"",
        "updateRule": null,
        "deleteRule": null,
        "options": {}
    }
]

I just tested it locally with both v0.14.2 and v0.14.3 with your collections configuration and I'm not able to reproduce the goroutine panic.

that's the only log, this is reproduce schema maybe it can help.

The above stacktrace unfortunately is not enough to pinpoint the issue. Usually there would more than one goroutine panic. Since we don't call explicitly the database/sql drive, aka. something external has triggered it.
For now I'm closing the issue as it is not reproducuble, but feel free to create a minimal reproducible repo or paste a more detailed stack trace and I'll try to investigate it.


chore(develop): merge master into develop

Codecov Report

Merging #39 (e93f3fc) into master (56f610e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines            3         3
=========================================
  Hits             3         3

Flag
Coverage Δ

website
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


How to enable the FTPS deployment

I enable the basic auth publishing credentials but still cannot use FTPS.

The note will always be displayed here:

The Learn more link provided doesn't solve my problem.
FYI
https://azure.github.io/AppService/2020/08/10/securing-data-plane-access.html
Please provide an executable doc to use FTPS to deploy the web app.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f6924846-3993-db7f-92c2-96a069bda515
Version Independent ID: b0ec25d1-8ea8-c0e4-304d-ab03692fa8e7
Content: Deploy content using FTP/S - Azure App Service
Content Source: articles/app-service/deploy-ftp.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@moarychan
Thanks for your feedback! We will investigate and update as appropriate.

@moarychan FTPS still uses basic auth which has been disabled for internal applications. When navigating back to General Settings, you'll see that Basic Auth has been disabled per policy.
#please-close


Do not auto import relative paths ever

Please do not auto import relative paths ever, this is constantly in the way of my productivity.
Steps to repro:

Accept as a suggestion an unimported class in a Typescript file
The class is automatically imported as accepted, however the import is relative

This is easily reproducible anywhere in vscode.
p.s if I trigger a quick fix to import I am presented both options to import as relative or absolute. Which I guess is fine, but on suggest accept we should import in the style that most imports in the file are.

Duplicate of #43575


feat(modifications): Show all modifications in the list.

To address https://app.asana.com/0/131658553708053/195111948257994

Current coverage is 58.40% (diff: 66.66%)

Merging #177 into dev will increase coverage by 0.01%

@@                dev       #177   diff @@
==========================================
  Files           142        142
  Lines          2756       2750     -6
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1609       1606     -3
+ Misses         1147       1144     -3
  Partials          0          0

Powered by Codecov. Last update 97f0601...0dec8f8


missing Synapse setup instructions

The top half of the page is instructions for setting up a SQL dedicated pool.  The bottom half of the page is about setting firewall rules on an Azure Synapse Instance.  There are not instructions for creating an Azure Synapse Analytics instance.  The instructions reference a non-existent mySampleDataWarehouse.
This is supposed to be the page for setting up Azure Synapse Analytics as a Pre-requisite for the Azure Data Factory Tutorial here: https://docs.microsoft.com/en-us/azure/data-factory/lab-data-flow-data-share#:~:text=Create an Azure SQL Database linked service&text=You can use the search,to connect to your database.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 90467e66-9062-01e3-6d40-fce8625d005b
Version Independent ID: 8db6b4e9-fd3a-8b45-1283-7f7144772a88
Content: Quickstart: Create and query a dedicated SQL pool (formerly SQL DW) (Azure portal) - Azure Synapse Analytics
Content Source: articles/synapse-analytics/sql-data-warehouse/create-data-warehouse-portal.md
Service: synapse-analytics
Sub-service: sql-dw
GitHub Login: @pimorano
Microsoft Alias: pimorano

@durantmbie Thank you for sharing feedback. We are actively validating it. We will share updates shortly.

Thanks for this feedback @durantmbie, I agree. The link here should be modified to point to other walkthrough(s). @jonburchel  can you assist?

#reassign:jonburchel

Please include instructions on creating a Synapse Analytics instance, these instructions are practically useless without it.

#reassign:WilliamDAssafMSFT

Thanks @durantmbie for raising this issue on the wizard, and I apologize for our delay in response. This change was batched with other needed changes in this tutorial. A doc update is in flight and work internally is proceeding with a fix here.
#please-close


Help, when I try and decompile my game i get an issue saying to create an issue with an attached sharedassets2.assets

When I try and decompile a game, I get an error saying to go to Github and attach the sharedassets2.assets

go to Github - done
attach the sharedassets2.assets- not done

go to Github - done
attach the sharedassets2.assets- not done

Can you tell me how to attach the sharedasets2.assets. When I try to drag it it won't let me

upload it on any file sharing platform, like https://mega.nz/ or https://www.google.com/drive/

upload it on any file sharing platform, like https://mega.nz/ or https://www.google.com/drive/
and post the link here

K here:
https://drive.google.com/file/d/1p867WcOiSteFtNJ0NN-rZxj2JsNn62S4/view
lets you view sharedassets2.assets and download it

I don't have access to this file.  Perhaps the problem is one of its dependencies. In that case I need all game files.

Post the error message that ripper shows you.

Here are my error messages. (In the form of pictures)

Also the error message it shows me when I try and rip it says I need to create an issue and attach sharedassets2.assets so yeah

Move Managed folder to some other place and then process game files again.

ok, I'll try

If it doesn't work, I'll send you the game i'm trying to rip

Yoo thanks! It worked! Thanks for everything


Can't use Models defined as CloudFormation Output of different Stack

I have the following setup:

multiple stacks with shared API Gateway (see serverless docs)
stack 1 defines a specific model and exports it (see serverless docs)
stack 2 should make us of the model via Fn::ImportValue

Stack1:
custom:
  documentation:
    models:
      - name: BadRequest400ResponseJSON
        contentType: 'application/json'
        schema: ....

resources:
  Outputs:
     BadRequest400ResponseModel:
        Value: BadRequest400ResponseJSON
     Export:
        Name: BadRequest400ResponseModel-${self:provider.stage}

Stack2:
someFunction:
  handler: myHandler
  events:
    documentation:
      methodResponses:
        - statusCode: '400'
          responseModels:
            "application/json":
              Fn::ImportValue: 'BadRequest400ResponseModel-${self:provider.stage}'

The deployment of stack 2 fails because of Template format error: Unresolved resource dependencies [[object Object], [object Object]Model] in the Resources block of the template.
The CloudFormation Template contains for some resources the object
DependsOn: [
  "MyAweSomeModel1",
  "MyAwesomeModel2",
  "[object Object]Model", // <-- this causes the problem
]

The problem is line 59, which expects the resource to be a string. If it's an object (like in my case with { "Fn::ImportValue": "<my-export-name>" }, then it fails.
A simple workaround for me is to ignore objects in line 59 (i.e. don't add them as dependency).

The dependency is definitely needed, otherwise cloudfront won't build stuff in the right order.
There needs to be special handling for your case. If the model is an object, don't add them to the dependencies.
Also a good first issue to work on :)

Of course the dependency is required. Maybe I did not express myself correctly. In my case the resource already exists, because it has been created by a different stack. Therefore that certain object should not be added to the dependencies.
I don't know if every object should be omitted or if different kind of objects (i.e. a different key than Fn::ImportValue) have to be handled differently?!

+1 any update on this?  Can not use this plugin with multi-stacks currently unless someone has a clever workaround.

any update on this issue, or workaround !

Currently not. We also don't have that much time to investigate this. So if someone finds something, it would be really cool that they could fix it and make a PR to this project :)

+1 from me as well.  I might be able to try and see if I can work on a fix soon.

+1 any update on this? some workaround or solution ?

Sorry the project that I was working on that would have allowed me to spend some time on this has been on hold.  ATM, I just renamed the various components that were similar so they all had different names and didn't overwrite each other :/


NFS example needs updates

Is this now the best place to raise: kubernetes/kubernetes#48161
The NFS example is not on the list of supported examples, but if you're looking for maintainer volunteers... I am pretty sure I am going to need this NFS example to work personally, and I hope to keep up with Kubernetes upgrades with several dev/prod environments, so I might be a good fit for supporting maintainer.

@kingdonb Thanks for showing interest. Our goal with examples like NFS that are currently in staging/ directory is to find them maintainers and ideally move them to another repository. If you think you have cycles to maintain this, I recommend you suggest creating a kubernetes-incubator/kubernetes-nfs repository by discussing this with<EMAIL_ADDRESS>Alternatively you can create a personal repository until that happens and then move things over.
Also please consider creating a Helm chart for easy installation of NFS in multiple environments if applicable. I see around many issues regarding NFS and a "community-maintained Helm chart" could help prevent anyone trying to run NFS on Kubernetes go through the same pains. Would this be something you're interested in?

Yes, I am interested in that.
I'll review your notes on the linked PR and start working on a Helm chart tonight!

/sig storage

@msau42 I'm afraid we don't have SIG or area labels in this repository yet.

I'm working my way back around to this from deis/workflow#856 and deis/workflow#857 ... these are the things I need personally so, hopefully I will need to maintain them and thereby make a great maintainer for these examples...

Any updates here?

Not yet.  Sorry, will make a point to look at it this week.
The goal is still to convert the example to work as a helm chart though, and with some parameters.  (I'm learning ins and outs of building helm charts by porting Deis to OpenShift, which has been fun!)

@ahmetb

I still owe a helm chart for this story
I've actually got a number of inquiries from people that need a PV that can be written into by simultaneously running pods that have the volume mounted concurrently.  I'm trying to avoid coding a helm chart in a paper bag that only solves my problem, "engineering rule of three" says you can't make a general solution until you have at least three distinct customers with overlapping problems.
Not abandoned, but actively seeking that third customer if anyone needs this please reach out to me.

Well this looks like terrible news: https://stackoverflow.com/questions/42973882/configure-nfs-server-for-persistentvolume-either-via-dns-or-static-clusterip

OK, I have composed PR #108 in order to avoid "perfect getting in the way of good"
It simply converts the existing structure into a helm chart, does not adjust any documentation yet.
You can helm install -n nfs examples/staging/volumes/nfs/chart/ and you get three RCs as in the original example: nfs-server, nfs-busybox, and nfs-web.
The NFS server binds itself to a 200GB PV, then exposes itself to the cluster as a service with service.clusterIP from your examples/staging/volumes/nfs/chart/values.yaml.  This is the only parameter that the user is expected to set.  I have not been able to find a way to assign this dynamically, but it is not a regression from the previous non-helm example.
I personally think this is a bug in the NFS PV driver, but I do not know how any other similar PV driver works so maybe this is working as designed.

The new example from #108 works exactly once per cluster boot (using Minikube)... something does not terminate upon helm delete --purge nfs and the result is, upon the second attempt to helm install the chart you get:
Unable to mount volumes for pod "nfs-busybox-3227049434-5dch7_default(9ffcb0cc-ac55-11e7-aaaa-080027f5463e)": timeout expired waiting for volumes to attach/mount for pod "default"/"nfs-busybox-3227049434-5dch7". list of unattached/unmounted volumes=[nfs]
Error syncing pod

Whatever hangs around also prevents a minikube stop from happening cleanly.  If I terminate the VirtualBox instance and start it again, the service comes up and busybox/web workers all connect to the nfs-server successfully binding their PVCs to the ReadWriteMany service.
There may be many obstacles to overcome in order to make this example viable.  Restarting minikube is akin to doing a down/up on the entire cluster, so I'm going to assume this type of failure condition is "very bad" in terms of what someone using this example on a live cluster would look like.

There's another proposed change in kingdonb/examples#2
Is there any reason to keep these services as "replicationcontrollers" and have I done the conversion to Deployment resources correctly?  The changes work for me (the example pods still come up and do their job.)

Regarding service name resolution, @jingxu97 should have fixed the issue on GCE/GKE COS images with kubernetes/kubernetes#51645.  The underlying issue is that mounts are done at the host level, so you need to configure the host's resolv.conf to also add the kube-dns server.

Regarding termination, are you terminating everything in the right order?  All the NFS clients must be terminated first, and then finally the NFS server.  If you terminate the server first, then all the client Pods will fail to unmount during shutdown.

@msau42 That helps, thank you!  I will try terminating the clients first next time.
I'm not on GKE COS though, so I'll seek out a solution on my local OS.  That seems like a reasonable adjustment to make on the host OS.  I also have other components that require the client (off-cluster) must be able to resolve the service in the same way as the on-cluster services that utilize them do.  (I'm running a CAS server for federated HTTP authentication.)
Thanks very much!

I think the other solution vs terminating the clients first, is to set the mount option for soft errors... that way the client will produce an error when it loses contact with the server, and not hang forever.
You might want your production deployments to wait for the server to come back instead of erroring out, so this can be one of the parameters to add to values.yaml

There is https://github.com/kubernetes/charts/pull/2559 now which can be a new home for this concern, the example/staging/nfs was updated and also works fine for me without helm at this point.  Thanks!


eas build -p ios fails with

Build/Submit details page URL
No response
Summary
I receive this error in my build pipeline. Using the command eas build -p ios. I can provide the build details page if necessary.
Managed or bare?
managed
Environment
eas diagnostics
EAS CLI 0.47.0 environment info:
System:
OS: macOS 12.1
Shell: 5.8 - /bin/zsh
Binaries:
Node: 16.10.0 - /usr/local/bin/node
Yarn: 1.22.17 - ~/.npm-global/bin/yarn
npm: 7.24.0 - /usr/local/bin/npm
Utilities:
Git: 2.34.1 - /usr/local/bin/git
npmPackages:
@expo/webpack-config: ~0.16.2 => 0.16.16
expo: ^44.0.6 => 44.0.6
expo-dev-client: ~0.8.4 => 0.8.4
expo-updates: ~0.11.6 => 0.11.6
react: 17.0.1 => 17.0.1
react-dom: 17.0.1 => 17.0.1
react-native: 0.64.3 => 0.64.3
react-native-web: 0.17.1 => 0.17.1
npmGlobalPackages:
eas-cli: 0.47.0
expo-cli: 5.0.3
Project workflow: generic
Error output
I receive this error which is quite cryptic. Can anyone point me to a solution?
▸ ** ARCHIVE FAILED **

▸ The following build commands failed:

▸ 	PhaseScriptExecution Bundle\ React\ Native\ code\ and\ images /Users/expo/Library/Developer/Xcode/DerivedData/MY-APP-NAME-gfpiycnwdqyjfaaiwqvnkfdyemxa/Build/Intermediates.noindex/ArchiveIntermediates/MY-APP-NAME/IntermediateBuildFilesPath/MY-APP-NAME.build/Release-iphoneos/MY-APP-NAME.build/Script-00DD1BFF1BD5951E006B06BC.sh (in target 'MY-APP-NAME' from project 'MY-APP-NAME')

▸ (1 failure)

** ARCHIVE FAILED **

The following build commands failed:

	PhaseScriptExecution Bundle\ React\ Native\ code\ and\ images /Users/expo/Library/Developer/Xcode/DerivedData/MY-APP-NAME-gfpiycnwdqyjfaaiwqvnkfdyemxa/Build/Intermediates.noindex/ArchiveIntermediates/MY-APP-NAME/IntermediateBuildFilesPath/MY-APP-NAME.build/Release-iphoneos/MY-APP-NAME.build/Script-00DD1BFF1BD5951E006B06BC.sh (in target 'MY-APP-NAME' from project 'MY-APP-NAME')

(1 failure)

Exit status: 65

+-------------+-------------------------+

|           Build environment           |

+-------------+-------------------------+

| xcode_path  | /Applications/Xcode.app |

| gym_version | 2.185.1                 |

| sdk         | iPhoneOS15.0.sdk        |

+-------------+-------------------------+

Looks like fastlane ran into a build/archive error with your project

It's hard to tell what's causing the error, so we wrote some guides on how

to troubleshoot build and signing issues: https://docs.fastlane.tools/codesigning/getting-started/

Before submitting an issue on GitHub, please follow the guide above and make

sure your project is set up correctly.

fastlane uses `xcodebuild` commands to generate your binary, you can see the

the full commands printed out in yellow in the above log.

Make sure to inspect the output above, as usually you'll find more error information there

[stderr] [!] Error building the application - see the log above

Error: Fastlane build failed with unknown error. Please refer to the "Run fastlane" and "Xcode Logs" phases.
Fastlane errors in most cases are not printed at the end of the output, so you may not find any useful information in the last lines of output when looking for an error message.

Reproducible demo or steps to reproduce from a blank project
Will provide if no quick solution an be found.

check xcode logs in the last section on the build page
PhaseScriptExecution Bundle\ React\ Native\ code\ and\ images suggest that there is an error when building js bundle

This very problem occurs for me as well with the exact phrasing in the error description. Not really clear what goes wrong

@610consulting check my answer above


What's the tagset used by PyThaiNLP?

Is there any way to get all possible tags used by PyThaiNLP's POS taggers, or could you please give a reference for the tagset?
And since there are two different corpora used by PyThaiNLP ("orchid" and "pud"), so I suppose there would be two different tagsets? And will different tagging engines (unigram, perceptron and artagger) affect the tagset used?

Thanks.


What's the meaning of each input dimention?

Hello, I want to test the performance of this loss function on other dataset. Coud you explain the meaning of each input dimention in the demo?
x2 = torch.rand((2, 3, 97, 80))
x3 = torch.rand((2, 4, 112, 97, 80))

Same with the input of CE and DICE Loss.


SSIS job is not able to access the Azure File share path

Hi All,
I am testing the azure file share with SSIS hosted on Azure VM, however I am facing issue while running the job.

Package execution through Visual Studio is successful

Package execution through catalogue also is successful

Package execution through the Job is FAILING with the error The File Name "\.windows.net<FolderName>\file.csv" specificed in the connection was not valid

I tried running the job with the proxy account having access to the azure share folder, however it failed with the same error.
Any suggestion or advice on this will be highly appreciated.
Thanks in advance.
Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
We use GitHub issues as the primary channel for customer and community feedback about the Azure documentation.
Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[ ] The relevant Azure service or technology.
[ ] A link to the published documentation article that you have feedback about.
[ ] Clear, specific feedback that the author can act on.

Pull requests and article contributions
If you know the change that is needed in an article, we encourage you to submit the changes directly using a pull request. If the change is large, or if you want to contribute an entire article, follow these guidelines:

[ ] Don't surprise us with a big pull request or a pull request with a new article! Submit an issue that describes the details of the proposed large change or new article.
[ ] Include the service or technology area.

We'll route the issue to the appropriate content team for review and discussion.
Tech support and product feedback
If you would like to contact Microsoft about other things, such as product feedback or tech support, please review these guidelines:

If you need technical support using Azure, the paid and free support options are described here: https://azure.microsoft.com/support/options/.

Each article in the Azure technical documentation contains a product feedback button - it's best to submit product feedback directly from a relevant article. Otherwise, you can submit product feedback for most Azure products in the following product feedback forum: https://feedback.azure.com/d365community/forum/79b1327d-d925-ec11-b6e6-000d3a4f06a4.

@neelthomas Issues managed in this repo are for Microsoft documentation and in case your query in not related to document content, open a new forum thread either Microsoft Q&A or StackOverflow as it could be better place to get help on your scenario where the community members could provide their expert guidance to you based on their experience.

Thanks @SaurabhSharma-MSFT


[WIP] test commit, do not merge

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: GregHanson
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GregHanson: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
cffe61ddef2514791dcb5e6dc91b8dc2b638bbc4
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Support additional default flexvolume plugin directories

Feature Description

One-line feature description (can be used as a release note): Support additional default flexvolume plugin directories
Primary contact (assignee): Jared Watts (@jbw976)
Responsible SIGs: /sig-storage, @kubernetes/sig-storage-feature-requests
Design proposal link (community repo): TBD
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
@chakri-nelluri
@verult
Approver (likely from SIG/area to which feature belongs):
@saad-ali
Feature target (which target equals to which milestone):

Alpha release target (x.y): 1.9
Beta release target (x.y): 1.10
Stable release target (x.y): 1.11

Initial design proposal that was presented to SIG storage can be found here: https://docs.google.com/document/d/1U1oUgZmcGWrLMs4QlmPfLOElyI6D-Gp_6a-KlWRMAjs/edit
A design proposal in the community repo will be coming soon.

I don't believe this made it into 1.9. Removing from milestone. Please correct me if I am wrong.


can not updload demo to esp32-s2

hi
when I upload demo to esp32-s2 ,the arduino ide syas :
libraries\EspTinyUSB\src/usb_device.hpp:3:10: fatal error: usb/usb_host.h: No such file or directory
how can I use this lib correctly？
my esp32 lib is v2.0.0

The latest stable version is 2.0.2.

Maybe that slash makes a difference on your OS?

usb/usb_host.h

VS

usb\usb_host.h

thx,may be I should update the esp32 lib version, by the way ,my os is windows10


Cannot provide custom RetryTemplate

Before starting using Spring Cloud Stream our Spring Boot application has custom RetryTemplate bean configured for inner needs. When we added Spring Cloud Stream to the application org.springframework.cloud.client.loadbalancer.LoadBalancerAutoConfiguration.RetryAutoConfiguration kicked in and has replaced our RetryTemplate bean with its own. And with no way to supply our own bean.

@iNikem
Hello, just read your question, I checked the source code, the source code reads as follows:
	@Configuration
	@ConditionalOnClass(RetryTemplate.class)
	public static class RetryAutoConfiguration {
		@Bean
		public RetryTemplate retryTemplate() {
			RetryTemplate template =  new RetryTemplate();
			template.setThrowLastExceptionOnExhausted(true);
			return template;
		}
        }

According to my understanding can be amended as ：
	@Configuration
	@ConditionalOnClass(RetryTemplate.class)
	public static class RetryAutoConfiguration {
		@Bean
                @ConditionalOnMissingBean
		public RetryTemplate retryTemplate() {
			RetryTemplate template =  new RetryTemplate();
			template.setThrowLastExceptionOnExhausted(true);
			return template;
		}
       }

If this can solve your problem? best wishes！

Theoretically this is exactly what I would expect, yes :)

@iNikem Thank you for your reply, if yes I will submit a PR to fix this issue. best wishes

@ryanjbaxter Hello, do you think this change can be? If this change can solve this problem, I would like to submit a PR to be repaired.

Sounds good to me.

@iNikem I have submitted PR ：）

Closed in error


Renamed The DrawModes consts

Even though I prefer it the other way, it matches the V3 changes on the other consts like BLEND_MODES, etc...

on fire!

:+1:


[tern-es6] completion after "import {" throws error

I have tried the demo http://ternjs.net/es6/doc/demo/#ES6
Write in the editor import { and open completion, you have the error Uncaught TypeError: Cannot read property 'type' of null

That was a bug in Acorn's loose parser. Attached patch should fix it (I'll tag a new Acorn version when I release the ES6 stuff)


Reduce file listing parallelism for tests

This should make Vacuum tests a lot faster. It's running 10,000 individual Spark jobs right now due to the very high setting of file parallelism setting.
cc @rahulsmahadev

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

That's going to be required when we start supporting SparkExtensions and V2
Catalog. I think that'll be a good time to do that refactoring.
On Wed, Aug 7, 2019, 10:53 AM Mukul Murthy<EMAIL_ADDRESS>wrote:

@mukulmurthy approved this pull request.
LGTM, though eventually creating a base test spark config file that our
tests use might be cleaner than dumping everything in build.sbt.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/delta-io/delta/pull/113?email_source=notifications&email_token=ABIAE645YD6OQ2LM2KHEOIDQDMDZVA5CNFSM4IKCPNV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCA4GBJA#pullrequestreview-272130212,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIAE64XGVKTAQ67NYAPI5DQDMDZVANCNFSM4IKCPNVQ
.

Sweet, this cut down test time from 50 mins to 20!

Wow that's good to hear
On Wed, Aug 7, 2019, 11:28 Burak Yavuz<EMAIL_ADDRESS>wrote:

Sweet, this cut down test time from 50 mins to 20!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/delta-io/delta/pull/113?email_source=notifications&email_token=AMKLYPJMK6PCFLBKESMAVTLQDMH53A5CNFSM4IKCPNV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZJYTA#issuecomment-519216204,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMKLYPKMBHQRY7YYXLT3NKDQDMH53ANCNFSM4IKCPNVQ
.

lgtm. this is awesome. merging it soon.


Save-installer needs redirect for winget downloadlinks

Hi,
download for winget fetches wrong file when getting as example keepass from winget, because its sourceforge with redirect.
Solution:
Use -userAgent wget as param for invoke-webrequest
Best regards

Thanks, just validated that with e.g. KeePass and it works way better. I'll fix this.

Nice to see that i could support. I did it for mine in azure dev ops as well.
By the way. Much thanks again for this Factory Project.


Fix build for Xcode 13 beta 3

In beta 3, linking to Swift Packages using APIs normally unavailable to application extensions now results in a build error: cf https://developer.apple.com/documentation/xcode-release-notes/xcode-13-beta-release-notes#Swift-Packages
This PR addresses the issue by replacing the use of UIApplication.shared (which is indeed unavailable to app extensions) with a view controller API.

Thank you!


Rename AbstractViewBinder to AbstractViewController (Issue #634)

Refactoring of Code and respective Javadoc (see Issue #634)
All occurrences of AbstractViewBinder are changed to AbstractViewController and all occurrences of AbstractFXMLViewBinder are changed to AbstractFXMLViewController in both Code and javadoc documentation.

This change is

THX @crud3 for contribution 👍 👍


Fix ModelExpression's in section directive blocks.

The DirectiveRemovalPass runs at DefaultFeatureOrder + 50 in order to allow the design time directive tokens pass to consume directive intermediate nodes; however, this has a side effect of leaving around the original @section nodes a bit too long. The ModelExpressionPass would see two references to the sections body (SectionIntermediateNode and DirectiveIntermediateNode) and then do its work twice. To combat this behavior I bumped the ModelExpressionPass order to be 50 points higher than the directive removal pass.
Added MVC tests for current and 1_X extensions.

#1614

A high level suggestion I have to make this more flexible would be to add an annotation at the document level inside the model pass. That's something I considered when bringing up this feature anyway.

A high level suggestion I have to make this more flexible would be to add an annotation at the document level inside the model pass. That's something I considered when bringing up this feature anyway.

Like mark nodes that have already been handled by the ModelExpressionPass?

IIRC you said there was some trickiness about the ordering of passes wrt determining the model type. That's what I was referring to

IIRC you said there was some trickiness about the ordering of passes wrt determining the model type. That's what I was referring to

Ah, ya if we wanted to take that approach we could mark the document with an annotation stating the model type. Honestly wouldn't be that awful 😄

🆙 📅 to have the section directive pass move non-token section nodes from the directive intermediate node to the section intermediate node. This way there's no double reference of those nodes.


Add testing back for the old backend on Windows in CI?

Thanks to a collaborative debugging session with @alexcrichton, we've identified what the issue was with my test case failing on Windows: it was a combination of using the old-backend (before the type-confusion bug had been fixed) and Windows, following #2806 that broke unwind information generation on windows old-backend (I'll send a PR for this).
So the real question is, should we re-add the CI on Windows for support of the old-backend?

If the plan is to remove the old-backend before the next release, that means that it won't be available later, so there's not a real point in maintaining it.
If the plan is to remove the old-backend after the next release, then it'd be nice to not break it in the future, and in this case it would be worthwhile adding it back in CI, in my opinion.

@bnjbvr thanks for bringing this up, and I think it would be a good idea to do so!
The plan, FWIW, is definitely to take it slow with the removal of the old backend: I will (at some point, after at least one more release) write up an RFC to propose removing it, and we'll want to seek out any folks who are still depending on it (and possibly hold off until we can e.g. make sure the migration path to the new backend works for everyone). For now, the old backend is definitely still supported, even if it is not evolving further.

Obsoleted by #3009?

Indeed!


Fix ConstraintHandler

This resuscitates the ConstraintHandler and fixes a bug related to constraints and improper torsions in the code comparing the parameters of two Systems.
I was going to use this PR to add the FreeSolv tests, but I encountered a lot of problems that I will summarize in #175, and I think will require some time to address. In the meantime, these changes are independent and can be merged into topology.

Something worth mentioning is that I had to implement a mechanism to compare impropers from the 0.1 version (trefoil 3-fold) to those implemented in 0.04 (trefoil 6-fold). If we set compare_system_parameters(ignore_improper_folds=True), the code merges all the folds into a single improper with k = sum(k_i) (where k_i is the spring constant of fold i) before comparing the parameters.

Thanks for the review!

Is there a test that adds SMIRKS-based constraints to the system?

Actually, all the FreeSolv regression tests I'm working on will use SMIRKS-based constraints because that's how we set up the Systems for the hydration free energy calculations. At the moment though, I'm still trying to resolve a few problems so I was hoping to add them in a separate PR, if that's ok. Otherwise, I'll create a separate test here, no problem!

Great, thanks!

@andrrizzi

Something worth mentioning is that I had to implement a mechanism to compare impropers from the 0.1 version (trefoil 3-fold) to those implemented in 0.04 (trefoil 6-fold). If we set compare_system_parameters(ignore_improper_folds=True), the code merges all the folds into a single improper with k = sum(k_i) (where k_i is the spring constant of fold i) before comparing the parameters.

This sounds reasonable. Sorry you had to do that. Apparently the group of us had not fully thought things through with respect to the original six-fold impropers (they could only ever work for molecules which were planar, and not for nonplanar molecules) so we had to change this when we began considering molecules which were not supposed to be planar.
Presumably, your approach will ... not work ideally if we ever get to a force field which has impropers for non-planar molecules, because it will only be applying one of the potentially three relevant impropers. Still, it should be good enough for testing even then I think.


Disable sourcekit-lsp on Linux asan preset

This was an oversight and should not have been enabled (yet). When we're
ready we should enabled asan testing on macOS as well.
rdar://47973246

@swift-ci please smoke test

@swift-ci please smoke test macOS


Cursor position on Firefox completely wrong for CSS Plane

The cursor position for the Iframe containing the inner website is totally wrong, and this is due to an underlying bug in Firefox that has apparently existed since 9 years ago and gone through many regressions. Here are some resources I found:
Stack Overflow post #1
Stack Overflow post #2
Random Forum
Bugzilla #1
Bugzilla #2
For now this issue will remain open, however I am just blocking all Firefox users with the loading screen for the time being.

I know this particular site doesn't play well as a result of this bug but don't you think urge you to use a different browser could be better phrased as urge you to use a different browser while viewing this site ? Or do you really recommend people don't use Firefox as their browser?

Honestly, I calculating the actual position is not so hard to call it "an equally complicated workaround". :shrug:

@benjibee Yes, I realize now how poor the wording is. I just pushed a fix that is more aligned with my original intentions. I am an avid FireFox user and supporter, I wasn't trying to urge people not not use the browser, but just let them know if they wanted to view the site, they needed to use a different browser. Thank you for calling this to my attention.
Link to the fix
Thanks again, and I apologize for the confusion.  When I first came across this bug it was before actually adding interactions into my site, and also when I was planning on completely replacing the users cursor with a custom one inside of the iframe. Set on getting the custom cursor to work, my focus at the time was to get proper positional coordinates for mouse events inside of the iframe. When testing on FireFox I noticed the bug for the first time. I tried to fix it for a good few days, but ultimately felt that working any more was doing more harm to the project than good. I added this error, created the issue, and moved on. In light of this bug it also killed any motivations I had to make a custom cursor, which in hindsight was definitely a good move.
As I have tested my site on every browser I can get installed on my Mac, FF remains the only one with this issue. The issue now is in essence the same as it was when I first discovered it, but is noticeable just by the fact that all interactions on the iframe plane are offset by a seemingly random (but definitely not random) amount of pixels.
For anyone in this thread who wants to see how the website works with the bug, you can visit the site with the ?debug flag and it will skip the error. Thanks!
https://www.henryheffernan.com/?debug

@henryjeff I thought that might be the case! I'm just particularly protective of Firefox, especially in relation to Google Chrome!  I develop in Firefox but always have to check it in Google Chrome as well… let's just be happy it's not like "the good 'ol days" of IE, and the like.
Also I should point out your website is a masterpiece and genius, so there's that. Best of luck with the job hunt!

the website seems to work correctly on firefox 121.0 (linux)

could not see an issue browsing the debug website and playing doom on it on firefox 124.0.1 64-bit under windows 10.

https://www.henryheffernan.com/?debug

Trying this on Firefox 125.0b4 (64-bit) on Mac and it seem to work very well.

Works well on Firefox 123 (64bit Linux)

Hi I downloaded the inner website repo and when I run npm i and start it shows a blank white screen is there any solution to it?

Pushed a fix to remove the error, thanks everyone in this thread, sorry for not doing this sooner lol! (commit: ad58405 )


Teletype not responding

Diagnostics
Request: GET https://api.teletype.atom.io/protocol-version

Versions
Teletype version: v0.10.0
Atom version: 1.24.0
Platform: win32

Thanks for reporting!  As mentioned by Jason in https://github.com/atom/teletype/issues/320#issuecomment-364241144, the team is investigating this error but in the meantime, can you give the steps detailed in https://github.com/atom/teletype/issues/318#issuecomment-363559779 a try and let us know if that resolves the error for you?   We'll go ahead and close as a duplicate for now.


https://hitbits.io/

Domain
https://hitbits.io/
Link
https://hitbits.io/slk/f/KSMJspPUik
Version
0.0.0
What browsers are you seeing the problem on?
Chrome
What OS are you seeing the problem on?
Windows
(Optional) Anything else?
https://hitbits.io/slk/f/KSMJspPUik
https://hitbits.io/slk/f/_pNMqGIOMn
https://hitbits.io/slk/f/4UY1gd_oOO
https://hitbits.io/slk/f/d6ddAzniXD
https://hitbits.io/slk/f/yqXjjN4v1C
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Looks like it'll need crowdbypass


improve ErrorHandling

This PR improves the ErrorHandling of the GenericServiceTemplate. Instead of ignoring an error, we throw it as an RuntimeException. This way the user can decide if he wants to handle it or just ignore it.

bors try

The problem with cutting big rewrites into smaller PRs is that you sometimes get stuff like that @Disabled in there.
I removed it. It would be fixed in the following PRs anyway.

Ok, sorry about that, I thought it would be better to review and merge one by one because it becomes quite big and I don't want to miss the details :)

Bors merge


LS_COLORS -> LSCOLORS

Hey,
the environment variable LS_COLORS defined in .aliases doesn't work in Terminal.app.
The definition used is compatible with Linux, not with OS X. Also, in OS X the variable's name should be LSCOLORS (without the underscore).
Please refer to my version of my file (line 33, latest commit af9ab14) to see a working definition for this variable.

LS_COLORS is for GNU ls and LSCOLORS is for BSD ls. This repository assumes you have Bash 4 as your shell.

Is there a reason to use GNU ls over BSD?

If so, then there's no point in detecting what's the color flag is in .aliases - it should always be --color.

@asafch lots of other changes seem to have made it into this PR; I’d suggest it stands a better chance of being accepted if it does only what it says on the tin: properly utilize LS_COLORS and LSCOLORS, depending on flavor (GNU vs. BSD).

Good comment. I'll close this PR and open a new, specific one for this issue.


How to create a package with rollup using redux-saga

I am trying to create a package that exports a redux saga generator function, when I test via npm link, all seems great. However when I publish the package and import from the package I get an error. It can't seem to find my generator functions. Using rollup to package the code. Is there something wrong that I am doing to export the code? I have tried numerous settings with rollup? Please could you guide or tell me what I am doing wrong
below is some of the code from my package I am trying to create.
setupTrixtaSaga.js
import 'regenerator-runtime/runtime';
import { put, fork, all, takeLatest, takeEvery } from 'redux-saga/effects'
import {
  REACTION_RESPONSE,
  SUBMIT_ACTION_RESPONSE_SUCCESS,
  CHANNEL_JOINED_FIELDS,
  SUBMIT_ACTION_RESPONSE,
  UPDATE_TRIXTA_ROLES,
  SUBMIT_REACTION_RESPONSE,
  SUBMIT_ACTION_RESPONSE_FAILURE,
  SUBMIT_REACTION_RESPONSE_FAILURE,
  SUBMIT_REACTION_RESPONSE_SUCCESS,
} from '../constants';
import {
  updateAction,
  updateReaction,
  updateTrixtaError,
  updateReactionResponse,
  updateActionResponse,
  updateLoadingErrorStatus,
} from '../reduxActions';
import { getChannelName, isNullOrEmpty } from '../../utils';

/**
 * Check the roles returned for the user, join channels for these roles
 *
 * @param {Object} params
 * @param {Object} params.data
 * @param {Array} params.data.roles
 * @returns {IterableIterator<*>}
 */
export const checkTrixtaRolesSaga = function* checkTrixtaRolesSaga({ data }) {
  const roles = get(data, 'roles', []);
  try {
    if (!isNullOrEmpty(roles)) {
      yield all(
        roles.map((role) =>
          fork(checkLoggedInRoleSaga, {
            role,
          })
        )
      );
    }
  } catch (error) {
    yield put(updateTrixtaError({ error: error.toString() }));
  }
};

/**
 * Attempts to connect to roleChannel
 * @param role
 * @returns {IterableIterator<*>}
 */
export const checkLoggedInRoleSaga = function* checkLoggedInRoleSaga({ role }) {
  if (role) {
    const channelTopic = getChannelName({ role });
    yield put(getPhoenixChannel({ channelTopic }));
  }
};

export const setupTrixtaSaga = function* setupTrixtaSaga() {
  yield takeLatest(UPDATE_TRIXTA_ROLES, checkTrixtaRolesSaga);

}

import from package in another project
import { setupTrixtaSaga, updateTrixtaRoles } from '@trixta/trixtajs';

export default function* defaultSaga() {
yield all([setupTrixtaSaga()]);
}

For starters - you can't export things like this: https://github.com/trixtateam/trixtaJS/blob/370dce190f6d60392edbf10ac8dff239e71a8f55/src/index.js#L8 . You just shouldn't mix ESM and CJS module formats like this, it won't work in multiple scenarios. Please refactor this to named exports and check things then.

@Andarist thank you for the suggestion. Will try that

@Andarist
I had look at your amazing article and took some ideas on the rollup config. Your package is really a must have in all redux applications. I really want to thank you for your amazing work. I made the suggestions you did, changes .  rollup changes . Seems to be working now, but I am not sure what I did that made it work. Do you mind seeing if I am doing something wrong regarding the packaging?
Maybe you should as part of your examples you already have include build examples with webpack, rollup and so forth.

You should write it like this:
export { trixtaReducer, setupTrixtaSaga, trixtaActionTypes };
export const utils = { getChannelName, getMessageFromError, isNullOrEmpty };

module.exports is a CJS construct, if you author your modules in ESM then you should stick to ESM syntax. Rollup doesn't even understand natively CJS so it thinks module.exports is just some random global thing - it doesn't touch it unless your use its CJS plugin, but it should only be used to process external modules (the ones in node_modules) and not the code you have authored.

You should write it like this:
export { trixtaReducer, setupTrixtaSaga, trixtaActionTypes };
export const utils = { getChannelName, getMessageFromError, isNullOrEmpty };

module.exports is a CJS construct, if you author your modules in ESM then you should stick to ESM syntax. Rollup doesn't even understand natively CJS so it thinks module.exports is just some random global thing - it doesn't touch it unless your use its CJS plugin, but it should only be used to process external modules (the ones in node_modules) and not the code you have authored.

@Andarist Can you also write it like this
export * from './React/constants';

I see I am using the commonjs as well
import commonjs from '@rollup/plugin-commonjs';

const createConfig = ({ input, output, external, env }) => ({
  input,
  output: {
    sourcemap: true,
    name: OUTPUT_NAME,
    globals: GLOBALS,
    ...output,
  },
  external: makeExternalPredicate(external === 'peers' ? peerDeps : deps.concat(peerDeps)),
  plugins: [
    env === 'production' && terser(),
    json({
      // All JSON files will be parsed by default,
      // but you can also specifically include/exclude files
      exclude: ['node_modules/**'],

      // for tree-shaking, properties will be declared as
      // variables, using either `var` or `const`
      preferConst: true, // Default: false

      // specify indentation for the generated default export —
      // defaults to '\t'
      indent: '  ',

      // ignores indent and generates the smallest code
      compact: true, // Default: false

      // generate a named export for every property of the JSON object
      namedExports: true, // Default: true
    }),
    commonjs(),
    filesize(),
    nodeResolve({
      jsnext: true,
    }),
    babel({
      exclude: 'node_modules/**',
      babelHelpers: 'runtime',
    }),
    env &&
      replace({
        'process.env.NODE_ENV': JSON.stringify(env),
      }),
  ],
  onwarn(warning, warn) {
    if (warning.code === 'UNUSED_EXTERNAL_IMPORT') {
      return;
    }
    warn(warning);
  },
});

@Andarist Can you also write it like this

If it would result in the same structure to be exported, then yeah - sure. I haven't tracked your imports/exports to know if it would, but this should be possible.

I see I am using the commonjs as well

Yes, but as mentioned - it really should only be responsible for handling your node_modules that might contain some CJS-only modules. And it's also only useful if you plan on bundling some dependencies into your bundle. So it's somewhat useless for you right now as you only create cjs & bundles but with all of your dependencies listed as externals (as you should - when bundling a library code). It's useful when bundling for UMD target - which usually contains the code of your dependencies in it. UMDs are sort-of relicts of the past, I would not create them - unless you know that you need them for some reason (like allowing your consumers to load them using


fix: WebView updated too frequently

Revert a change made earlier in webViewHandleUpdates.
More details in #6bdb259

Thanks @borisyankov , especially for the detailed discussion in that commit message!
As I mentioned in chat (after you were offline for the evening), this reverts more than the shallow/deep-equals change -- it also reverts the fix to #2676, re-opening that bug.
I've just pushed 9fc769802 to revert specifically the shallow/deep-equals change. See that commit message for some further analysis of what's going on here.
Based on what I learned that's described in that message (and at greater length in the same chat thread linked above), I think this also doesn't go far enough: the fetching and typingUsers props, which we switched to === in the same commit, suffer from the same issue and also need a revert. The impact of those naturally is smaller than of the content, but still good to avoid sending unnecessary postMessage messages.


Add Windows gitlab job

This adds CI jobs on a Windows gitlab-runner with an NVIDIA GPU

This is a physical machine with an NVIDIA RTX 2060, an AMD RX 7600 and a valid Windows license. I am planning to try and get HIP running on Windows as well, see https://streamhpc.com/blog/2023-08-01/how-to-get-full-cmake-support-for-amd-hip-sdk-on-windows-including-patches/ for details.

All relevant pipelines ran through, so I'll go ahead and merge this


Dart Unhandled Exception: "SqliteException(1): no such column: valueName, SQL logic error (code 1)"

Describe the bug
I created a fetch function that receives a custom expression content:
 Future<List<D>> fetch<T extends Table, D extends DataClass>(
      {TableInfo table, String whereExp}) async {
    final statement = select<T, D>(table);
    if (whereExp != null) {
      statement..where((Table u) {
        return CustomExpression(whereExp);
      });
    }
    return statement.get();
  }

if I pass whereExp as 'columnName = valueName'
then I get this exception:
Dart Unhandled Exception: "SqliteException(1): no such column: valueName, SQL logic error (code 1)"
What am I doing wrong here?
Thanks in advance!

Well, does the table have a column named valueName? Judging by your other issue it might just be called value_name?

Nono... when I say valueName I mean the value that I'm trying to compare the column to...
I'm basically trying to create a select statement like this:
SELECT
	column_list
FROM
	table
WHERE
	column_1 = 100;

Oh, I see! But passing whereExp: 'total_people = 100' should work then? If you want to pass the column and the target value as two different parameters, you could also use this:
Future<List<D>> fetch<T extends Table, D extends DataClass>({
    required TableInfo<T, D> table,
    String? column,
    Object? value,
  }) async {
    final statement = select<T, D>(table);
    if (column != null) {
      statement.where((T row) {
        final col = table.columnsByName[column]!;
        return col.equals(value);
      });
    }
    return statement.get();
  }

Yes that works perfect! I made a change that works best for my use case:
Future<List<D>> fetch<T extends Table, D extends DataClass>({
    @required TableInfo<T, D> table,
    Map<String, dynamic> params
  }) async {
    final statement = select<T, D>(table);
    params.keys.forEach((key) {
      statement.where((T row) {
        final col = table.columnsByName[key];
        return col.equals(params[key]);
      });
    });
    return statement.get();
  }

But I was not aware of the columnsByName getter thanks!


undefined method `klass' for nil:NilClass (NoMethodError)

Hi,
My environment details are:
MacOS Ventura, M1
Rails <IP_ADDRESS>
Ruby 3.1.2p20
On running
OccamsRecord.query(DataVendors::NationalStockExchange::BhavCopy.all)
I am getting the following error:
gems/occams-record-1.3.0/lib/occams-record/query.rb:54:in initialize': undefined method klass' for nil:NilClass (NoMethodError)
@model = scope.klass
^^^^^^

Closing due to inactivity


Raw image with transparent pixels

Current behavior

New behavior

can you fix the lint ? (run make black then make lint)

Confused with the error.
When I run the command that fails in the build, I don't get an error.
~/img2dataset$ python -m black --check -l 120 img2dataset
All done! ✨ 🍰 ✨
3 files would be left unchanged.

yeah you have the wrong version of black, run pip install -r requirements-test.txt to install the right one

Hold off a bit before merging, I'm gonna try to apply the suggestions from @Skylion007

Should be good now!
I tested on these:

https://i.imgur.com/B922OoM.png
https://raw.githubusercontent.com/borisdayma/dalle-mini/main/img/logo.png
some regular images

should be ok but can you check if the speed is the same before/after ?
(I intend to add that to the CI after #65 but for now we still need to check manually)

There's probably not that very images with 4 channels to test the effect.
Anyway I tested on 500k images but my connection may be unstable:

before this PR: 674 img/sec
with this PR: 2 runs - 620 img/sec and 705 img/sec (same command, same data)

Thanks!


feat: Add derivatives, incl. high-order and mixed partial

Support ordinary derivatives \odv and partial derivatives \pdv.
It supports high-order mixed partial derivatives. The syntax emulates popular $\LaTeX$ packages that provide this sought-after feature.

Demo. More in test screenshots.
'yarn start' URL that produced the demo.
Sensible fallbacks; if users mistyped their expressions they wouldn't be confused by blankness on the screen.
Produced screenshots for tests.
Added to the docs.
Already signed CLA.

I noticed issue https://github.com/KaTeX/KaTeX/issues/3038 (citing https://github.com/KaTeX/KaTeX/issues/3184) mentioned maintainer @edemaine recommends using the macro system to implement derivatives instead of the genfrac function.
Therefore, I re-implemented this feature with a new PR https://github.com/KaTeX/KaTeX/pull/3703 🙂.

@Leedehai Thank you for the pull request. I have some questions.

MathJax has a physics extension that implements part of the LaTeX physics package. In the MathJax extension, some of the functions have behavior that does not quite match the LaTeX function. It appears that the MathJax behavior is simplified so that it can be expressed in MathJax macros. I'm guessing that you avoided using a macro for this PR because the current KaTeX macro language cannot fully express the functionality of the LaTeX commands. Is my assumption correct?

PR #3273 also takes a macro approach. Is this PR closer to LaTeX behavior than PR #3273?

If PR #3385 was approved and merged, could you then use macros to fully implement \odv and \pdv?

Hi @ronkok thanks for your response! To answer your questions:

KaTeX's macro system is powerful enough to implement derivative macros. Please see my PR 3703 as mentioned in the comment above. If you accept PR 3703, then you may ignore PR 3701 (this one).
My PR 3703 is covers more ground than the PR you mentioned, as the former supports mixed-order derivatives.
Not necessary to wait for that PR, because the existing macro system is able enough.

Thanks!


Description of the package is blank

https://www.npmjs.com/~grimoire.gl

I think you probably need to add a description to package.json.
https://github.com/GrimoireGL/grimoirejs-gltf/blob/master/package.json#L4

Merged with https://github.com/GrimoireGL/grimoirejs-gltf/pull/7


try-catch imgration NPE

Task/Issue URL: https://app.asana.com/0/1202552961248957/1206912668071189/f
Description
try-catch NPE we're seeing in production
Steps to test this PR
NA just code review

#4366  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aitorvs and the rest of your teammates on  Graphite


Organize tests of type checking into named subfolder

Previously, tests of type checking were scattered throughout the root of the test folder, providing no clear indication of their purpose. By relocating them to a dedicated subfolder, we can now precisely identify the target of these tests through the folder's name.

[!note]

We've chosen to name this subfolder typecheck in keeping with the naming convention used for codegen. However, we welcome any suggestions for improvement.
While these tests may also evaluate aspects of lexing and parsing, we have consolidated them to emphasize their primary focus on type checking, addressing the highest level of concern.

If we were to share the source test files, the tests would have to rely on identical test files. However, the concerns of tests at different phases are generally not going to be the same, so sharing them may not be feasible. Additionally, in turnt, a set of source test files shares a single configuration file. It seems like it doesn't support multiple configurations, although we could potentially achieve this by using a script to switch configurations.
Regarding the issue of duplicate frontend and backend folders across the structure, I don't think such duplication will pose a problem. Certain functionalities typically won't span across both frontend and backend. For instance, there's no type checking in the backend, and the input for code generation in the backend should be the IR rather than C, which is a fundamentally different test compared to the frontend QBE IR generation. Therefore, this should not be a significant concern.

If we were to share the source test files, the tests would have to rely on identical test files. However, the concerns of tests at different phases are generally not going to be the same, so sharing them may not be feasible. Additionally, in turnt, a set of source test files shares a single configuration file. It seems like it doesn't support multiple configurations, although we could potentially achieve this by using a script to switch configurations.
Regarding the issue of duplicate frontend and backend folders across the structure, I don't think such duplication will pose a problem. Certain functionalities typically won't span across both frontend and backend. For instance, there's no type checking in the backend, and the input for code generation in the backend should be the IR rather than C, which is a fundamentally different test compared to the frontend QBE IR generation. Therefore, this should not be a significant concern.

Fair enough 👍🏼


Bug: If a file has multiple functions in it, the extension jumps to the top of the file, not the method that was selected to "go to definition"

Description
Bug: If a file has multiple functions in it, the extension jumps to the top of the file, not the method that was selected to "go to definition"
This PR:

Adjusts the regex to match the named method name.
Adjusts selection calculation to select the named method name instead of the file path.
Works with default exports.

Linked Issues
None, can make an issue if needed.
Additional context
Feel free to adjust the regex if needed, not the best at regex. Seems to work fine.

This should not be needed after #18. Thanks for your contribution


Documentation example for sharing event handlers needs await

Current behavior
Page https://github.com/badeball/cypress-cucumber-preprocessor/blob/master/docs/event-handlers.md shows how to share event handlers with the preprocessor.
I implemented as described and found that the html report (cucumber-report.html) was not being generated. It was generated before I added the event handler workaround. I confirmed that cypress-cucumber-preprocessor.html.enabled=true.
Desired behavior
The HTML report is output by afterRunHandler.
I notice that @badeball\cypress-cucumber-preprocessor\lib\add-cucumber-preprocessor-plugin.js declares afterRunHandler as async.
Therefore the handlers should be awaited.
The example code in the documentation should be updated here: https://github.com/badeball/cypress-cucumber-preprocessor/blob/master/docs/event-handlers.md
Note I have also added the parameter names to the lambda as per the Cypress docs https://docs.cypress.io/api/plugins/after-run-api, so that those parameters are ready to be used in your own code.
  on("before:run", async (details) => {
    // Call cypress-cucumber-preprocessor handler
    await beforeRunHandler(config);

    // Your own `before:run` code goes here.
  });

  on("after:run", async (results) => {
    // Call cypress-cucumber-preprocessor handler
    await afterRunHandler(config);

    // Your own `after:run` code goes here.
  });

  on("before:spec", async (spec) => {
    // Call cypress-cucumber-preprocessor handler
    await beforeSpecHandler(config);

    // Your own `before:spec` code goes here.
  });

  on("after:spec", async (spec, results) => {
    // Call cypress-cucumber-preprocessor handler
    await afterSpecHandler(config, spec, results);

    // Your own `after:spec` code goes here.
  });

  on("after:screenshot", async (details) => {
    await afterScreenshotHandler(config, details);

    // Your own `after:screenshot` code goes here.
  });

Test code to reproduce
cypress.config.js:
const fs = require('fs');
const { defineConfig } = require('cypress');
const createBundler = require('@bahmutov/cypress-esbuild-preprocessor');
const {
  addCucumberPreprocessorPlugin,
  beforeRunHandler,
  afterRunHandler,
  beforeSpecHandler,
  afterSpecHandler,
  afterScreenshotHandler,
} = require('@badeball/cypress-cucumber-preprocessor');
const createEsbuildPlugin = require('@badeball/cypress-cucumber-preprocessor/esbuild');

async function setupNodeEvents(on, config) {
  // This is required for the preprocessor to be able to generate JSON reports after each run, and more.
  // Omitting handlers allows this suite to add to cypress after:run without cypress-cucumber-preprocessor overriding it.
  // Refer to https://github.com/badeball/cypress-cucumber-preprocessor/blob/master/docs/event-handlers.md
  await addCucumberPreprocessorPlugin(on, config, {
    omitBeforeRunHandler: true,
    omitAfterRunHandler: true,
    omitBeforeSpecHandler: true,
    omitAfterSpecHandler: true,
    omitAfterScreenshotHandler: true,
  });

  on("before:run", (details) => {
    // Call cypress-cucumber-preprocessor handler
    beforeRunHandler(config);

    // Your own `before:run` code goes here.
  });

  on("after:run", (results) => {
    // Call cypress-cucumber-preprocessor handler
    afterRunHandler(config);

    // Your own `after:run` code goes here.
    if (results) {
      fs.mkdirSync("cypress/report", { recursive: true });
      fs.writeFile("cypress/report/results.json", JSON.stringify(results));
    }
  });

  on("before:spec", (spec) => {
    // Call cypress-cucumber-preprocessor handler
    beforeSpecHandler(config);

    // Your own `before:spec` code goes here.
  });

  on("after:spec", (spec, results) => {
    // Call cypress-cucumber-preprocessor handler
    afterSpecHandler(config, spec, results);

    // Your own `after:spec` code goes here.
  });

  on("after:screenshot", (details) => {
    afterScreenshotHandler(config, details);

    // Your own `after:screenshot` code goes here.
  });

  on(
    "file:preprocessor",
    createBundler({
      plugins: [createEsbuildPlugin.default(config)],
    })
  );

  // Make sure to return the config object as it might have been modified by the plugin.
  return config;
}

module.exports = defineConfig({
  screenshotOnRunFailure: true,
  numTestsKeptInMemory: 2,
  e2e: {
    specPattern: "**/*.feature",
    supportFile: "cypress/support/e2e.js",
    setupNodeEvents,
  },
})

Versions

Cypress version: 12.0.1
Preprocessor version: 15.0.0
Node version: v16.17.0

Checklist

[x] I've read the FAQ.
[x] I've read Instructions for logging issues.
[x] I'm not using<EMAIL_ADDRESS>(package name has changed and it is no longer the most recent version, see #689).

Hey @joeboon, thanks for letting me know. I've updated the documentation with the above-mentioned changes.


Unable to start correctly

Please advise on the required dependencies for windows 10 64 bit. I have installed Microsoft Visual C++ 2010 Redistributable Package (x86) but cannot use any version of youtube-dl after 2016-05-21.2, later versions fail with "application was unable to start correctly (oxc000007b)". Thanks

Looks like it misses some dependencies. I was able to find this thread on SO, which recommends to use dependency walker to see what is missing. Have you considered giving it a try?

Yes I have tried it but I'm afraid that I don't understand the result. There are hundreds of errors.
Clearly some dependencies changed between versions: 2016-05-21.2 and 2016-05-30.2 as the former works but the latter (and all later versions) fails. The changelog doesn't go back that far, I checked there for clues!


Fix few bugs in benchmarks

New versions of xgboost and openml creates problems in the tree and pipelines benchmarks. This PR fixes this

Codecov Report

Merging #542 (87a83bf) into main (92215f1) will decrease coverage by 5.91%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   90.63%   84.72%   -5.92%
==========================================
  Files          78       78
  Lines        4516     4516
  Branches      839      839
==========================================
- Hits         4093     3826     -267
- Misses        237      498     +261
- Partials      186      192       +6

Flag
Coverage Δ

unittests
84.72% <ø> (-5.76%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ummingbird/ml/containers/sklearn/tvm_containers.py
17.24% <0.00%> (-75.87%)
:arrow_down:

...mmingbird/ml/operator_converters/sparkml/linear.py
42.85% <0.00%> (-57.15%)
:arrow_down:

...bird/ml/operator_converters/sparkml/discretizer.py
52.94% <0.00%> (-35.30%)
:arrow_down:

.../ml/operator_converters/_linear_implementations.py
75.55% <0.00%> (-22.23%)
:arrow_down:

...ird/ml/operator_converters/onnx/one_hot_encoder.py
62.50% <0.00%> (-18.75%)
:arrow_down:

hummingbird/ml/_topology.py
67.79% <0.00%> (-17.38%)
:arrow_down:

hummingbird/ml/convert.py
65.40% <0.00%> (-16.59%)
:arrow_down:

hummingbird/ml/containers/_input_containers.py
87.50% <0.00%> (-12.50%)
:arrow_down:

...ml/operator_converters/sparkml/vector_assembler.py
90.00% <0.00%> (-10.00%)
:arrow_down:

...perator_converters/_discretizer_implementations.py
90.32% <0.00%> (-9.68%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92215f1...87a83bf. Read the comment docs.


SVG support on top of this?

Hi,
this is an interesting looking little library. Any idea about the amount of work needed to build an SVG renderer out of this? I work on a game engine and I'm interested in exploring an integration of tiny SVG rendered for scalable resolution independent graphics.
Thanks!

Thanks!  Both rendering vector assets for games and rendering a subset of SVG are applications that I'd had in mind for this library.  In fact, I'd looked into a while back as a potential side project, but didn't want to get too sidetracked from just getting this library to release.
There are few avenues that I can see for this:

Build a little library that directly parses a subset of SVG and makes calls into canvas_ity to do the rendering.  Or if you want something already written for this purpose, have a look at NanoSVG.  As I understand it, canvas_ity is a much more fully-featured renderer than the one included with NanoSVG and so should make a good back-end for it.

Take a more heavy-weight existing SVG parser and adapt it to flatten the SVG to a series of calls to a canvas-like API which are then serialized.  Those then become your cooked assets and you just have a very thin layer that deserializes them and calls canvas_ity.  I've had some success at using Inkscape's HTML5 canvas export function to try this for a few SVG files such as the PostScript Tiger.  After exporting, I'd load the generated JavaScript into my editor and do regexp search and replaces until I'd turned it into the C++ equivalent that calls canvas_ity.  As another potential side project, I've been mulling binary serialized canvas API calls as a lightweight vector image format.

Cheers!

Thanks for the answer!
Regarding NanoSVG if there's some kind of glue code that is needed to plug these two together is that a contribution you'd be interested in having in your repo?

For now, I'd like to keep this repo fairly slim.  But if you do write such glue code and put it in your own repo, I'll be happy to add a link to it on the README here.


Update develop environment

Use jest v13.2.3
Use node v6
Add cache setting on travis-ci

Coverage remained the same at 94.598% when pulling 66514adc5acb6fdf3e54c3ee41b82182c283da6a on update-dev into d011ae5fc5f8e44ffcb56647f1cc161e88d3339f on master.


Better dependency checks

This MR fixes some problems with how dependencies are handled in the install-hammer.sh script:

the program now safely exits with status code 127 when missing a dependency
check-program is renamed to require-program to better describe the new behavior
zenity is now only used when the --no-gui flag isn't set, this allows running the script without zenity by setting the --no-gui flag
the program now prints an 'Install Finished' message to stdout as zenity no longer relays that information in all scenarios

Looks good, thanks again!
At some point we'll need to rework this script entirely because Hammer no longer runs properly with just WINE. Might be able to slip a dxvk_d3d11.dll in bin/win64 to get it working though.

I've tried installing dxvk to my WINEPREFIX following the guide from dxvk's README file which went amazing as you can see:

I also tried deleting my WINEPREFIX and installing dxvk through winetricks, but ended up with the same result.
It's not a Wayland/XWayland issue either, as trying in awesomewm didn't change anything.
I ended up trying Proton Experimental through Steam, which worked.
I have no idea what black magic Valve is doing and how we could reproduce it using the script

I ended up trying Proton Experimental through Steam, which worked. I have no idea what black magic Valve is doing and how we could reproduce it using the script

Update:
It's an issue with upstream wine, I'm not very experienced with the win32 APIs, but in upstream wine's x11 vulkan implementation, vkCreateWin32SurfaceKHR has this if case:
/* TODO: support child window rendering. */
if (create_info->hwnd && NtUserGetAncestor(create_info->hwnd, GA_PARENT) != NtUserGetDesktopWindow())
{
    FIXME("Application requires child window rendering, which is not implemented yet!\n");
    return VK_ERROR_INCOMPATIBLE_DRIVER;
}

Other wine forks, such as Valve's or GloriousEggroll's actually implements child window rendering, and hammer works properly with dxvk.
I'm not sure of how we should convey this information to the user in the install script.

Interesting, I appreciate you looking into this. For now we can just stick to wined3d even though that doesn't really work either :laughing:
Maybe we could try to set it up to use Proton? We can parse libraryfolders.vdf to find the install location of Proton. Unfortunately this would mean that moving your Proton install dir would break the installed shortcut. I quickly put together a utility in #11 for this task, if you want to use it.


Packages are only searched for in composer.lock packages, not packages-dev

workspace/xdependencies, workspace/xreferences all do not include data from dev dependencies

If you are developing the project wouldn't you have done a dev install thereby also having the dev dependencies installed and listed in composer.lock?

Yes, but we need to read it :)

Guess is misunderstood :)  Perhaps it would be nice if using dev dependencies would be configurable. Dev depending could add a significant number of classes and it could slow down the indexing or other features. I am just speculating here.

You are misunderstanding the issue, this is only about the mentioned methods.


Publish shade and non-shade jar

Context
Thanks for the excellent work of supporting Hetzner API with Java.
The current jar in maven central seems to be a shaded jar, which has compatibility issues with latest Spring Boot (I'm using Spring Boot 2.4.1):
2020-12-21 11:09:52.688 ERROR 82796 --- [           main] o.s.b.d.LoggingFailureAnalysisReporter   :

***************************
APPLICATION FAILED TO START
***************************

Description:

An attempt was made to call a method that does not exist. The attempt was made from the following location:

    org.springframework.context.support.GenericApplicationContext.setApplicationStartup(GenericApplicationContext.java:165)

The following method did not exist:

    'void org.springframework.beans.factory.support.DefaultListableBeanFactory.setApplicationStartup(org.springframework.core.metrics.ApplicationStartup)'

The method's class, org.springframework.beans.factory.support.DefaultListableBeanFactory, is available from the following locations:

    jar:file:/Users/zhb/.gradle/caches/modules-2/files-2.1/me.tomsdevsn/hetznercloud-api/2.11.0/b6dc04414fc5070ad48b7c8350d5aabaa0cf6b08/hetznercloud-api-2.11.0.jar!/org/springframework/beans/factory/support/DefaultListableBeanFactory.class
    jar:file:/Users/zhb/.gradle/caches/modules-2/files-2.1/org.springframework/spring-beans/5.3.2/289d8047f7cc524d60ca0c4cc6fedb8cb003e02d/spring-beans-5.3.2.jar!/org/springframework/beans/factory/support/DefaultListableBeanFactory.class

The class hierarchy was loaded from the following locations:

    org.springframework.beans.factory.support.DefaultListableBeanFactory: file:/Users/zhb/.gradle/caches/modules-2/files-2.1/me.tomsdevsn/hetznercloud-api/2.11.0/b6dc04414fc5070ad48b7c8350d5aabaa0cf6b08/hetznercloud-api-2.11.0.jar
    org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory: file:/Users/zhb/.gradle/caches/modules-2/files-2.1/me.tomsdevsn/hetznercloud-api/2.11.0/b6dc04414fc5070ad48b7c8350d5aabaa0cf6b08/hetznercloud-api-2.11.0.jar
    org.springframework.beans.factory.support.AbstractBeanFactory: file:/Users/zhb/.gradle/caches/modules-2/files-2.1/me.tomsdevsn/hetznercloud-api/2.11.0/b6dc04414fc5070ad48b7c8350d5aabaa0cf6b08/hetznercloud-api-2.11.0.jar
    org.springframework.beans.factory.support.FactoryBeanRegistrySupport: file:/Users/zhb/.gradle/caches/modules-2/files-2.1/me.tomsdevsn/hetznercloud-api/2.11.0/b6dc04414fc5070ad48b7c8350d5aabaa0cf6b08/hetznercloud-api-2.11.0.jar
    org.springframework.beans.factory.support.DefaultSingletonBeanRegistry: file:/Users/zhb/.gradle/caches/modules-2/files-2.1/me.tomsdevsn/hetznercloud-api/2.11.0/b6dc04414fc5070ad48b7c8350d5aabaa0cf6b08/hetznercloud-api-2.11.0.jar
    org.springframework.core.SimpleAliasRegistry: file:/Users/zhb/.gradle/caches/modules-2/files-2.1/me.tomsdevsn/hetznercloud-api/2.11.0/b6dc04414fc5070ad48b7c8350d5aabaa0cf6b08/hetznercloud-api-2.11.0.jar

Action:

Correct the classpath of your application so that it contains a single, compatible version of org.springframework.beans.factory.support.DefaultListableBeanFactory

It's clear that the shaded spring packages conflicts. I can't even exclude it because it's shaded inside that jar. I assume the shaded jar is necessary in some scenario, but this makes it impossible to integrate with latest Spring Boot application.

Thank you for opening this issue.
I'll notify you when I've published both shade and non-shade artifacts to maven central.

Any update on this ?

Will be done once the pagination support is merged @everflux

I have pushed 2.12.0 today (without pagination support since it is still in review) with a non-shaded artifact as default.


Wrong color on labels containing numbers

There is a visual issue with labels containing numbers as the numbers get highlighted as if they were a regular number in code.

P.S. Assembles as expected, no issues

Fixed as of 735050f113b7410d24b90a95732b0f8f07ad5430


Make these strings again, so that literal 'undef' doesn't get templated

Upon bumping to the master branch, I found 'undef' was being templated into my defaults files.  This may be Puppet version specific, but I believe that the empty string achieves our desired result under all circumstances.

Setting empty strings makes puppet 4 unhappy, what's your thoughts on #421?