Output is inverted

I'm trying do home automation and for that i use example 5 working LEDs and added 2 more accessories to control 4 relay module And i uploaded that code, now when i try to turn on LED it activates relays and leds. and when i turn it on it turns. I'm using version 1.4.2

Sorry, can you clarify the question.  Not sure I understand the issue.

https://user-images.githubusercontent.com/70468123/152733719-393a0db6-c849-4cd0-aa64-070b4d8015ce.MOV

Sorry, can you clarify the question.  Not sure I understand the issue.

When i try to then the switch on the opposite thing happens i have please can you help me

Without knowing the details of the relays and how you wired them it is not possible for me to know for sure, but my guess is that you are using relays that trigger on a LOW signal.  The example code is designed to produce a HIGH signal on the pins you specify when you turn ON a light, and a LOW signal when you turn OFF a light.  If an LED is connected (through a resistor) directly to those pins, the LED will operate properly.
But relays come in many forms - they can be normally open or normally closed.  They can be temporary or they can latch.  They can trigger on a HIGH signal or trigger on a LOW signal.  You'll have to look at your relays and determine what signals they expect to turn "on," and adjust the code accordingly, which likely will mean changing the logic of the digitalWrite() to produce the reverse.  Something like: digitalWrite(ledPin,!power->getNewVal()).

Without knowing the details of the relays and how you wired them it is not possible for me to know for sure, but my guess is that you are using relays that trigger on a LOW signal.  The example code is designed to produce a HIGH signal on the pins you specify when you turn ON a light, and a LOW signal when you turn OFF a light.  If an LED is connected (through a resistor) directly to those pins, the LED will operate properly.
But relays come in many forms - they can be normally open or normally closed.  They can be temporary or they can latch.  They can trigger on a HIGH signal or trigger on a LOW signal.  You'll have to look at your relays and determine what signals they expect to turn "on," and adjust the code accordingly, which likely will mean changing the logic of the digitalWrite() to produce the reverse.  Something like: digitalWrite(ledPin,!power->getNewVal()).

Thank you so much it worked


Support TOML grouping options for plugin configurations

And support TOML grouping based on [name] for plugin configurations.
For TOML based configuration of plugins we should support plugin groupings based on the plugin name.
For these example flags:
--p2p-port=42
--plugin-rocksdb-foo-cache=250000
--plugin-kafka-queue-name=demo

A plain toml looks like
### TOML w/o sections
p2p-port=42
plugin-rocksdb-foo-cache=250000
plugin-kafka-queue-name="demo"

But because we have plugin name sections this bug would ask for support for both the above TOML and this sectioned TOML:
## TOML w/ sections
p2p-port=42

[plugin-rocksdb]
foo-cache=250000

[plugin-kafka]
queue-name="foo"
``

The name passed into PicoCLIOptions#addPicoCLIOptions becomes the part after `plugins-`

This has been stale for >1 year. Closing for now. Feel free to copy/paste in a new issue if relevant. cc: @sajz


AP Documentation Sync

Tasks

Implement updated Accord Project documentation.

Related Issues:

Issue #37

Closed with #61


Display error with x-terminal-emulator

Some users have faced an issue regarding problems to find displays in terminal emulators

https://discord.com/channels/1237055789441487021/1276142313797845063/1276142418877743210
https://discord.com/channels/1237055789441487021/1275847428477550806/1275878556228124683


Setting Mylar reverse proxy link also changes it for Headphones and vice versa

Pretty much as the title says. Whenever i change the Reverse Proxy Link setting for Mylar or Headphones, it changes it for the other too. I'm running the latest versions

Fixed.


Fixed Errors - Refactored Images and Added Fallback

Fixes:  #701

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[x] I have made this from my own
[ ] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

@VidhiBhatt01 - Removed unnecessary files.
Kindly proceed with further review. Also will follow the process told by you from next time
Sorry for the inconvinience

@arpit456jain Please merge this PR and add labels


Proposals

This is a list of places where queue interop was proposed or could be helpful:
(The list is updated regularly)

Symfony. Async events PR - https://github.com/symfony/symfony/pull/23315#issuecomment-312904862
Symfony. Propsition to migrate to queue interop - https://github.com/symfony/symfony/pull/23650
Symfony. PoC. How amqp component could look like on amqp interop -
https://github.com/lyrixx/symfony/pull/14
Symfony. https://github.com/symfony/symfony/pull/23842
[CLOSED] Laravel. Queue interop bridge for Laravel queue -
https://github.com/laravel/framework/pull/20148
[MERGED] Bridge to queue interop transports - https://github.com/swarrot/swarrot/pull/155
[MERGED] Bridge to queue interop transports - https://github.com/bernardphp/bernard/pull/320
MQ based spool - https://github.com/swiftmailer/swiftmailer/pull/970
[CLOSED] MQ based logger handler - https://github.com/Seldaek/monolog/pull/1033
[CLOSED] Amqp interop - https://github.com/php-amqplib/php-amqplib/pull/500
[MERGED] Doc update - https://github.com/php-amqplib/php-amqplib/pull/502
[MERGED] https://github.com/liip/LiipImagineBundle/pull/919
[CLOSED] Populate command perf improvent -
https://github.com/FriendsOfSymfony/FOSElasticaBundle/issues/1186 - but released separatly as enqueue-elastica-bundle
[CLOSED] Bridge to queue interop https://github.com/yiisoft/yii2-queue/pull/104
[MERGED] https://github.com/yiisoft/yii2-queue/pull/158
PHP FIG queue discusions - https://groups.google.com/forum/#!msg/php-fig/CcFN7zr90Wo/3ihpslRDBwAJ
Proposition to join the group - https://github.com/jakubkulhan/bunny/issues/50
[MERGED] https://github.com/jakubkulhan/bunny/pull/51
https://github.com/cloudamqp/php-amqplib-example/pull/3
[MERGED] https://github.com/thephpleague/tactician/issues/113, https://github.com/thephpleague/tactician/pull/114
[MERGED] https://github.com/rabbitmq/rabbitmq-tutorials
[MERGED] https://github.com/vyuldashev/laravel-queue-rabbitmq/pull/154
[MERGED] https://github.com/sonata-project/SonataNotificationBundle/pull/276
[CLOSED] https://github.com/Codeception/Codeception/pull/4624
[CLOSED] https://github.com/gjedeer/celery-php/issues/105
https://github.com/php-amqplib/RabbitMqBundle/pull/516
[CLOSED] https://github.com/magento/magento2/issues/13360
https://github.com/renatocason/magento2-module-mq/issues/3

Consider create Exception folder and move all exceptions into.


Switcher Dropdown list to change between Assessment and FastPass doesn't announce changes

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
0.- turn on NVDA

Go to https://www.washington.edu/accesscomputing/AU/before.html
Click on Assessment, select start new (if there is an assessment in progress)
Using Keyboard, navigate to the switcher drop down list that allows you to go to FastPass
4.- open the list using space bar, up arrow to select FastPass,  space to select the option
Using Keyboard, navigate to the switcher drop down list that allows you to go to Assessment
6.- Open the list using space bar, down arrow to select Assessment, Space to select the option

Screen reader reads: "select workflow list collapsed FastPass" on change from FastPass to Assessment
Note: can't repro this consistently
Expected behavior
it should announce that the page changed to Assessment view
Extension (please complete the following information)

OS: [e.g. Windows/Mac] Windows
Version [e.g. 1.140.1] 2.1.2
Chrome Version [e.g 71.0] 73.0.3683.103
Target Page https://www.washington.edu/accesscomputing/AU/before.html

Are you willing to submit a PR?
If asked, will you be willing to submit a PR to fix this bug?No
Did you search for similar existing issues?
Did you search for similar issues in our github issues or on stackoverflow
Yes
Additional context
Add any other context about the problem here.

@ferBonnin checked on https://developer.microsoft.com/en-us/fabric#/components/dropdown using NVDA, it is not happening on their side. So this might be an issue from our side, or they've fixed the issue.

@haonliu how can we check if its fixed for us too?

@haonliu how can we check if its fixed for us too?

we can update office fabric and see if the issue is still there.

@markreay thoughts?

Just an update: so I tried to updated OF to 6.174.0, this issue is not fixed, and a bunch of a11y issue is found in e2e tests.

Investigated a bit more on this issue, I think the cause is: the 'selected option' of the switcher does not change immediately after user input, It goes through our flux loop before updating the UI. This makes NVDA anoucing the option change incorrectly.

Who should close this issue?

@haonliu the person who open it, in this case me.

verified in Canary version 2<IP_ADDRESS>08 with NVDA


Timeout while trying to connect to Docker Daemon

I'm getting a timeout while trying to connect to docker daemon. I'm running with my user which is part of "docker" group and does not requires sudo to access the docker socket. I've tried as root as well.
I only could get it to work using version 0.3-beta.1, build 3816d77.  So I believe it may be a bug at stop showing loading screen as it does not seems to be a connection problem.

Hi, not sure why it could be happening, the code to establish the connection with the Docker daemon hasn't really changed lately.
What is the Docker version?

I'm running docker 17.06-ce...
I did a little debugging session and on docker/connection.go:128 the docker client is returned without error. I'm having the feeling that it is simply a matter of signaling the channel to stop showing the loading screen at main.go. When does that should happen?

So it is not the Docker version. OS?
After the connection is established, the signal is sent to stop showing the loading screen (by closing the channel), this happens on main.go as well, see main.go:203.

It Worked!!!
I had too many containers.... 30secs was not enough to list and inspect each one. A docker container prune wiped away several unused containers and now I'm able to open it.
Btw, really nice job!! I'm looking forward to contribute to it if I have the opportunity. This should become native into the docker client.

Ah, good, so it was just taking too long to start.
Great that you like it, contributions are very welcome :)

Can the issue be closed?

Yes, sure!
Maybe we can think about creating some kind of paginated list for such cases. But if it makes sense, I believe it can be discussed in another issue.

Not sure if pagination is supported by the Docker API, but it might be worth checking.
I have not been able to reproduce the problem with the naive approach of running 100+ containers on low-end hardware (i.e. rPi), dry loads quite fast, even from a remote machine. So there might be additional factors, besides the number of containers, to explain why did it happen.


drivers: pinmux: stm32f7: Add LTDC pinmux entries to STM32F7

Working on #15591, add pinmux for AF14 and some of AF9 (STM32F7x6)
These are only tested for the stm32f746g_disco board (STM32F746NGH6 SOC). The rest were extracted from the datasheet. I'm adding the FMC pins to continue work and would like to avoid a later merge with this patch and the additional large number of pinmux additions coming in that.
Signed-off-by: Matthew Koch<EMAIL_ADDRESS>

@matthew-koch, I also would like to avoid reviewing that once again.


Bug Report

Report Message

Another test message, this time with Mark\ down

Report Metadata
Bug Reported By: PokestarFan#8524<PHONE_NUMBER>14224641)
Bug Reported At: Wednesday, December 29, 2021, 7:01:54 PM Eastern Standard Time

Test successful


Update Grant-CsExternalAccessPolicy.md

https://github.com/MicrosoftDocs/office-docs-powershell/pull/5887#issuecomment-643456643

Docs Build status updates of commit b36f9b8:
:clock10: Full build: the average full build time is 18 min(s) 1 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit b36f9b8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Grant-CsExternalAccessPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Feature/add digma instrumentation

@arik-dig Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


[Feature Request] Document set of suitable python versions

🚀 Feature
The package seems to work with a very narrow set of python versions. While the pyproject.toml specifies 3.7^ I noticed that some of the python versions within the SemVer bounds (python 3.7 and 3.10) don't work and it took me a while to find a version that works. It would be good to document which python version is recommended and perhaps narrow the version bounds in the pyproject.toml accordingly.
Checklist

[x] I have checked that there is no similar issue in the repo (required)

Some more information on what stops one from using other python versions:

python 3.7 does not work because of pandas which I guess you cannot do anything about

Installing dependencies from lock file

  SolverProblemError

  The current project's Python requirement (3.7.13) is not compatible with some of the required packages Python requirement:
    - pandas requires Python >=3.8, so it will not be satisfied for Python 3.7.13

  Because no versions of stable-baselines3 match >=1.2,<1.5.0 || >1.5.0,<2.0
   and stable-baselines3 (1.5.0) depends on pandas (*), stable-baselines3 (>=1.2,<2.0) requires pandas (*).
  Because pandas (1.4.2) requires Python >=3.8
   and no versions of pandas match !=1.4.2, pandas is forbidden.
  Thus, stable-baselines3 is forbidden.
  So, because eagerx-tutorials depends on stable-baselines3 (^1.2), version solving failed.

  at ~/.poetry/lib/poetry/puzzle/solver.py:241 in _solve
      237│             packages = result.packages
      238│         except OverrideNeeded as e:
      239│             return self.solve_in_compatibility_mode(e.overrides, use_latest=use_latest)
      240│         except SolveFailure as e:
    → 241│             raise SolverProblemError(e)
      242│
      243│         results = dict(
      244│             depth_first_search(
      245│                 PackageNode(self._package, packages), aggregate_package_nodes

  • Check your dependencies Python requirement: The Python requirement can be specified via the `python` or `markers` properties

    For pandas, a possible solution would be to set the `python` property to "<empty>"

    https://python-poetry.org/docs/dependency-specification/#python-restricted-dependencies,
    https://python-poetry.org/docs/dependency-specification/#using-environment-markers

python 3.9 seems to work (only tested 3.9.12)
python 3.10 fails because scipy is pinned to 1.6 in the poetry.lock but that scipy only supports python 3.10 starting from 1.7

Thanks Lasse!


Request for release of new version

I'm using Python3.8, and can't work well without https://github.com/mongomock/mongomock/commit/7fc6ae4dc991cbdf73596bfb278d8cb0092ee1a5.
So I wish a new version could be released.
I appreciate for your work, thank you.

Done. Enjoy :-) https://github.com/mongomock/mongomock/releases/tag/3.19.0

Thank you very much!


Exstension add extra Linebreak before {{ and after }}

This useful Extension adds Linebreaks before {{ and after }} if there are a whitespace.
Is it possible to prevent this?

    Variable1: {{ variable1 }} / Variable2: {{ Variable2 }}

When saving the above code:

    Variable1:
    {{ variable1 }}
    / Variable2:
    {{ Variable2 }}

Hey @mweissberg, I have just pushed an update to Twig Language 2 with a brand new formatter using Prettydiff 3 which brings about some major bug fixes. I just brought up this specific issue with the lead developer of the formatter and he replied:

I will think about how to approach example 1. This isn't a defect, but rather a design decision. I am providing the same spatial relationships to the template tags as I do to text and self-closing tags. White space in XML/HTML rendering is tokenized by default which means in the rendering of output all adjacent white space is collapsed into a single space character. My design decision is to indent where text/self-closing tags are separated by space which helps in identifying tags among long paragraphs of text without regard for word wrap.

Sorry about the slow development speeds and sub-par communication but hopefully these updates have fixed some of your other problems.


LINK-1034/add-venue-inside-outside-text.

Add more information about the venue inside/outside to the info text.
Description :sparkles:
Add more information about the venue inside/outside selection to the notification info text.
Issues :bug:
Part of:
LINK-1034
Screenshots :camera_flash:
The addition is highlighted selecting with the cursor in the below image.

Codecov Report

Merging #200 (7848321) into develop (1e2602e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #200   +/-   ##
========================================
  Coverage    99.88%   99.88%
========================================
  Files          506      506
  Lines         9452     9452
  Branches      2073     2073
========================================
  Hits          9441     9441
  Misses          11       11

Impacted Files
Coverage Δ

...n/event/formSections/placeSection/PlaceSection.tsx
100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Custom metrics sample not working

Hi,
I am trying to make work the sample about custom metrics on Request per second, but I cannot make it work...Also I do not understand the logs and application insights correlation.
So I have this error:
I0916 10:17:31.297948       1 metric_cache.go:57] metric not found CustomMetric/default/rps
I0916 10:17:31.297953       1 provider_custom.go:100] New call to GetCustomMetric: rps
I0916 10:17:31.297958       1 appinsights.go:110] Application insights key has been provided - using Application Insights REST API.
I0916 10:17:31.297995       1 appinsights.go:186] request to:  https://api.applicationinsights.io/v1/apps/XXXXXXXXXXXXXXXXXXXX/metrics/rps?interval=PT30S&timespan=PT5M
What really I do not understand is that rps is the name for the K8s object not an Application Inisghts metric...Shouldn't it always fail? And be like the following request below?
curl "https://api.applicationinsights.io/v1/apps/XXXXXXXXXXXXXXXXXXXXXXX/metrics/performanceCounters/requestsPerSecond?timespan=PT5M&interval=PT30S&aggregation=sum" -H "x-api-key: tYYYYYYYYYYYYYYYYYYYYYY"
Thanks

@zodraz  I was able to reproduce this. Instead of creating a separate yaml for rps custom metric, put it directly inside the hpa yaml:
`  metrics:

type: Pods
pods:
metric:
name: performanceCounters-requestsPerSecond
target:
type: AverageValue
averageValue: 50`

I believe this was caused by the image that was published image did not have support the v1alpha2 schema.  It should be available now:
docker pull mcr.microsoft.com/k8s/metrics/adapter:v0.7.3-296
You can find all the images version at https://mcr.microsoft.com/v2/k8s/metrics/adapter/tags/list and latest is tagged with the highest version.


[Security risk] Docker login action write login auth token to disk

https://github.com/Azure/container-actions/blob/master/docker-login/src/login.ts#L16
Why do we need to create a docker config file and write the base64 encoded password to disk? From what i understand, docker has it's own credential store which will handle credential secure for you when you run docker login, like osxkeychain, windows cred manager, etc.

The only major reason for using this approach is to ensure clean up from the machine, given that it's being created in the temp_directory of the runner.
If we used osxkeychain or a windows cred manager (FYI, docker Linux would be doing whatever we're doing in our current approach, i.e. the insecure writing to file), adding docker-logout step would be mandatory to every workflow. And if that's missed, there's was a potential security risk of the values staying on the machine even after the workflow is completed.
Eventually, when the private runner's scenario would light up, these credentials would end up staying on that machine if docker-logout step wasn't used leading to much higher risks cause of shared resources.
We could throw in an explicit warning to warn the users about our current approach in the logs.


fix star/flag action #5738

Fixes #5738
Changes proposed in this pull request:

We currently execute renderRow(tr, r, row, even) every time a row is starred/flagged, which is not necessary for the frontend;
Adding or deleting data-table-flag-on / data-table-flag-off in the classList of flag, data-table-star-on / data-table-star-off in the classList of star is sufficient;
By eliminating this unnecessary rendering, we can reduce the load and improve the overall performance.

Oops, that's an excellent point indeed - thanks for noticing that!


Change test directory for bazel-central-repository tests

Ideally there'd be an integration test within the repo that tests consuming the rules via bzl mod. For now this aims to release something in the short-term.

Relates to https://github.com/abrisco/rules_helm/issues/38


feat: api-management.service new v0.2

Description

Closes #2075
Closes #1929
Closes #1124
Closes #1104
Closes #2362
Closes #2444
Big update v0.2 release:

update all APIM apis to newer versions
new feat: Add PublicIP
new feat: add API Loggers
new feat: add API Diagnostics
new feat: add v2sku options
add test case for v2sku
updates to many default params to better align with PSRule suggestions for better reliability and security

Pipeline Reference

Pipeline

Type of Change

[x] Update to CI Environment or utilities (Non-module affecting changes)
[x] Azure Verified Module updates:

[ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[x] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] I have run Set-AVMModule locally to generate the supporting module files.
[x] My corresponding pipelines / checks run clean and green without any errors or warnings

@Azure/avm-core-team-technical-bicep sorry for the large PR but I thought it was the best way to get everything submitted in a timely manner. I promise I won't make this a habit... just trying to get a bunch of these open bugs resolved.

Hey @v-xuto that's correct. One of the tests failed due to an internal server error. We'll merge a new PR asap - including the suggested changes above.


How can I get the this reference inside renderContent?

I am using Accordion inside each header there is different dynamic content. e.g first accordion will contain a list of skills(From API) and in the second accordion, I want some other data in list view. I can not statically define the content in the SECTION. I can do this inside renderContent but I am not able to get the reference of this.props or this.state.

Just convert it to an arrow function and you will automatically bind this:
 _renderHeader = (section) => {
//Here you can use this
        return (
            <View>
                <Text>{section.header}</Text>
            </View>
        );
}


[TW#15676] Pins for using SPI >40MHz

I'm currently writing an ILI9225 SPI driver, based on the spi_master example. Using the pin numbers in this example, the maximum allowed frequency is 26 MHz. Anything beyond that and it will throw an error message saying
spi_master: spi_bus_add_device(234): No speeds >26MHz supported for full-duplex, GPIO-matrix SPI transfers

I am configuring the bus as follows:
   //chip select = 22, DC=21,RST=18
    spi_bus_config_t buscfg={
        .miso_io_num=PIN_NUM_MISO, // 25 (unconnected)
        .mosi_io_num=PIN_NUM_MOSI, // 23
        .sclk_io_num=PIN_NUM_CLK, // 19
        .quadwp_io_num=-1,
        .quadhd_io_num=-1,
		.max_transfer_sz = 8 * 2 * 176 * 220
    };
    spi_device_interface_config_t devcfg={
        .clock_speed_hz=26*1000*1000,           //Clock out at 26 MHz
        .mode=0,                                //SPI mode 0
        .spics_io_num=PIN_NUM_CS,               //CS pin (22)
        .queue_size=7,                          //We want to be able to queue 7 transactions at a time
        .pre_cb=lcd_spi_pre_transfer_callback,  //Specify pre-transfer callback to handle D/C line
    };

The documentation at https://esp-idf.readthedocs.io/en/latest/api-reference/peripherals/spi_master.html#_CPPv216spi_bus_config_t says

You can use this structure to specify the GPIO pins of the bus. Normally, the driver will use the GPIO matrix to route the signals. An exception is made when all signals either can be routed through the IO_MUX or are -1. In that case, the IO_MUX is used, allowing for >40MHz speeds.

The documentation doesn't however provide an example of a possible pin configuration in which "all signals can be routed through IO_MUX" and doesn't provide references to technical manuals in which IO_MUX is explained.
I have two requests:

Add a reference to the technical manual (https://espressif.com/sites/default/files/documentation/esp32_technical_reference_manual_en.pdf), beginning page 42 to 79. Maybe also add a new section in the documentation explaining these pin choices?
Provide an example pin configuration so that developers don't have to dig through ~40 pages of multiplexers, pin lists and register descriptions

It would be very nice if someone with a higher technical understanding of the ESP32 could take a look at this and help me figure out a pin mapping for which the ">40MHz" speeds can be reached.
Thank you.

Technical reference manual table 19 function 2

@gamer-cndg

For the operating frequency, ESP32 master clock is divided from APB clock (80MHz), so only 80, 40, 26.6, 20, 16, 13.3, 11.4, 10 MHz and lower are available.

The master needs a setup time of 2 APB clocks before the sample edge on the MISO line. When the GPIO mux is used, 2 APB  clocks of input delay are added to the MISO, increase 2 APB clocks to the setup time (in this case 4 APB clocks total).
This is the main reason we can not allow using of high frequency -- or master reads wrong data.
For this reason when GPIO matrix is used, only freq below 10MHz (80Mhz/2/4) works under all conditions; and when GPIO matrix is not used, only 20MHz (80MHz/2/2) works under all conditions.
Higher frequency communications are all achieved by some tricks, thus some restrictions exist.

In your case not reading, the restrictions and frequency limitations do not exist. You can remove the frequency check manually and set frequency to the list in (1). IMO ESP32 will work well in this case, no matter GPIO matrix is used or not. (we're discussing whether to add a new flag SPI_MASTER_NO_READING which disable the RX channel and checks for the RX)
BTW, by ILI9225 spec, the maximum freq is 12.5MHz, please do it at your own risk. By our experience, speed allowed for writing is a little higher than reading.

About the documentation,

I think it is a good idea to add IO_MUX pins into the programmer's guide
About the TRM, the writing structure is (1) MUXs and PINs, (2) then comes all peripherals, without discussing the pins again. It's big change to the document, we'll discuss whether to do this.


FileNotFoundError: dino_best_buddies/ dino_best_buddies_filter.pt

First of all, thank you for your wonderful work. I tried running python ./preprocessing/main_preprocessing.py
--config ./config/preprocessing.yaml
--data-path <VIDEO_DIR_PATH>，Is always unable to output the expected result correctly. Error message: FileNotFoundError: [Errno 2] No such file or directory:  '/dino-tracker/dataset/pig/dino_best_buddies/ dino_best_buddies_filter.pt '. How can I solve this problem

Hi @wuyiqii , thanks you your message!
Can you please send us the full output of running main_preprocessing.py ?
Since it comprises of running multiple sub-scripts, it is possible that one of them crashed, thus not creating the dino_best_buddies_filtered.pt file needed for the next subscript

Thanks you your message! I run  main_preprocessing.py again processed a 780kb video, and here are the output: Traceback (most recent call last):
File "/share/data02/wuyiqidata/dino-tracker/./preprocessing/extract_trajectories.py", line 282, in
save_trajectories(args)
File "/home/Wuyiqi/anaconda3/envs/dt/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/share/data02/wuyiqidata/dino-tracker/./preprocessing/extract_trajectories.py", line 185, in save_trajectories
masks, flows = get_flows_with_masks(
File "/home/Wuyiqi/anaconda3/envs/dt/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/share/data02/wuyiqidata/dino-tracker/./preprocessing/extract_trajectories.py", line 44, in get_flows_with_masks
flows = torch. zeros((2, len(images) - 1, 2, h, w), device=device)
RuntimeError: Trying to create tensor with negative dimension -1: [2, -1, 2, 476, 854]
----- Running python ./preprocessing/save_dino_embed_video.py --data-path /share/data02/wuyiqidata/dino-tracker/dataset/pig/ --config ./config/preprocessing.yaml
Traceback (most recent call last):
File "/share/data02/wuyiqidata/dino-tracker/./preprocessing/save_dino_embed_video.py", line 35, in
save_dino_embed_video(args)
File "/share/data02/wuyiqidata/dino-tracker/./preprocessing/save_dino_embed_video.py", line 20, in save_dino_embed_video
video = load_video(video_folder=video_folder, resize=(h, w), num_frames=400).to(device) # T x 3 x H x W
File "/share/data02/wuyiqidata/dino-tracker/data/data_utils.py", line 104, in load_video
return torch.stack(video)
RuntimeError: stack expects a non-empty TensorList
----- Running python ./preprocessing/save_dino_embed_video.py --data-path /share/data02/wuyiqidata/dino-tracker/dataset/pig/ --config ./config/preprocessing. yaml --for-mask
Traceback (most recent call last):
File "/share/data02/wuyiqidata/dino-tracker/./preprocessing/save_dino_embed_video.py", line 35, in
save_dino_embed_video(args)
File "/share/data02/wuyiqidata/dino-tracker/./preprocessing/save_dino_embed_video.py", line 20, in save_dino_embed_video
video = load_video(video_folder=video_folder, resize=(h, w), num_frames=400).to(device) # T x 3 x H x W
File "/share/data02/wuyiqidata/dino-tracker/data/data_utils.py", line 104, in load_video
return torch.stack(video)
RuntimeError: stack expects a non-empty TensorList

it seems the first error occurred when extracting the trajectories. I suspect either the path to the dataset is not correct, or the dataset folder does not contain any jpg or png files ?

I got this error on windows.
Problem is that line images = list(input_folder.glob("*.jpg")) + list(input_folder.glob("*.png")) is not find images. File extract_trajectories.py.
Need to convert linux path format to windows like input_path = input_path.replace('\\', '/')

thanks @Ivandanilovich , I'm closing this issue for now. If there'll be further questions please feel free to repoen it.

I also encountered this problem, what should I do to solve it?
Traceback (most recent call last):
File "/root/dino-tracker/./preprocessing/extract_trajectories.py", line 282, in
save_trajectories(args)
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/root/dino-tracker/./preprocessing/extract_trajectories.py", line 185, in save_trajectories
masks, flows = get_flows_with_masks(
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/root/dino-tracker/./preprocessing/extract_trajectories.py", line 44, in get_flows_with_masks
flows = torch.zeros((2, len(images) - 1, 2, h, w), device=device)
RuntimeError: Trying to create tensor with negative dimension -1: [2, -1, 2, 476, 854]
----- Running python ./preprocessing/save_dino_embed_video.py --data-path ./dataset/hursejump --config ./config/preprocessing.yaml
Traceback (most recent call last):
File "/root/dino-tracker/./preprocessing/save_dino_embed_video.py", line 35, in
save_dino_embed_video(args)
File "/root/dino-tracker/./preprocessing/save_dino_embed_video.py", line 20, in save_dino_embed_video
video = load_video(video_folder=video_folder, resize=(h, w), num_frames=400).to(device) # T x 3 x H x W
File "/root/dino-tracker/data/data_utils.py", line 104, in load_video
return torch.stack(video)
RuntimeError: stack expects a non-empty TensorList
----- Running python ./preprocessing/save_dino_embed_video.py --data-path ./dataset/hursejump --config ./config/preprocessing.yaml --for-mask
Traceback (most recent call last):
File "/root/dino-tracker/./preprocessing/save_dino_embed_video.py", line 35, in
save_dino_embed_video(args)
File "/root/dino-tracker/./preprocessing/save_dino_embed_video.py", line 20, in save_dino_embed_video
video = load_video(video_folder=video_folder, resize=(h, w), num_frames=400).to(device) # T x 3 x H x W
File "/root/dino-tracker/data/data_utils.py", line 104, in load_video
return torch.stack(video)
RuntimeError: stack expects a non-empty TensorList
----- Running python ./preprocessing/create_fg_mask.py --dino-embed-video-path ./dataset/hursejump/dino_embeddings/dino_embed_video-layer=23.pt --h 476 --w 854 --mask-path ./dataset/hursejump/masks --fg_mask_threshold 0.6
Traceback (most recent call last):
File "/root/dino-tracker/./preprocessing/create_fg_mask.py", line 72, in
run(args)
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/root/dino-tracker/./preprocessing/create_fg_mask.py", line 52, in run
dino_embed_video = torch.load(args.dino_embed_video_path) # T x C x H x W
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 986, in load
with _open_file_like(f, 'rb') as opened_file:
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 435, in _open_file_like
return _open_file(name_or_buffer, mode)
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 416, in init
super().init(open(name, mode))
FileNotFoundError: [Errno 2] No such file or directory: './dataset/hursejump/dino_embeddings/dino_embed_video-layer=23.pt'
----- Running python ./preprocessing/split_trajectories_to_fg_bg.py --traj_path ./dataset/hursejump/of_trajectories/trajectories.pt --fg_masks_path ./dataset/hursejump/masks --fg_traj_path ./dataset/hursejump/of_trajectories/fg_trajectories.pt --bg_traj_path ./dataset/hursejump/of_trajectories/bg_trajectories.pt
Traceback (most recent call last):
File "/root/dino-tracker/./preprocessing/split_trajectories_to_fg_bg.py", line 95, in
split_trajectories_to_fg_bg(args)
File "/root/dino-tracker/./preprocessing/split_trajectories_to_fg_bg.py", line 81, in split_trajectories_to_fg_bg
mask_filter_trajectories(args.traj_path, args.fg_masks_path, args.fg_traj_path, filter_bg=False)
File "/root/dino-tracker/./preprocessing/split_trajectories_to_fg_bg.py", line 56, in mask_filter_trajectories
trajectories = torch.load(traj_path, map_location="cpu")
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 986, in load
with _open_file_like(f, 'rb') as opened_file:
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 435, in _open_file_like
return _open_file(name_or_buffer, mode)
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 416, in init
super().init(open(name, mode))
FileNotFoundError: [Errno 2] No such file or directory: './dataset/hursejump/of_trajectories/trajectories.pt'
----- Running python ./preprocessing_dino_bb/main_dino_bb_preprocessing.py --config ./config/preprocessing.yaml --data-path ./dataset/hursejump
----- Running python preprocessing_dino_bb/extract_dino_best_buddies.py --dino-emb-path ./dataset/hursejump/dino_embeddings/dino_embed_video.pt --stride 7 --out-path ./dataset/hursejump/dino_best_buddies/dino_best_buddies.pt --h 476 --w 854
/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/functional.py:504: UserWarning: torch.meshgrid: in an upcoming release, it will be required to pass the indexing argument. (Triggered internally at ../aten/src/ATen/native/TensorShape.cpp:3526.)
return _VF.meshgrid(tensors, **kwargs)  # type: ignore[attr-defined]
Traceback (most recent call last):
File "/root/dino-tracker/preprocessing_dino_bb/extract_dino_best_buddies.py", line 65, in
run(args)
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/root/dino-tracker/preprocessing_dino_bb/extract_dino_best_buddies.py", line 21, in run
features = torch.load(dino_embed_video_path) # T x C x H x W
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 986, in load
with _open_file_like(f, 'rb') as opened_file:
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 435, in _open_file_like
return _open_file(name_or_buffer, mode)
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 416, in init
super().init(open(name, mode))
FileNotFoundError: [Errno 2] No such file or directory: './dataset/hursejump/dino_embeddings/dino_embed_video.pt'
----- Running python ./preprocessing/extract_trajectories.py --frames-path ./dataset/hursejump/video --output-path ./dataset/hursejump/of_trajectories/trajectories_wo_direct_filter.pt --min-trajectory-length 2 --threshold 1.5 --infer-res-size 476 854
Namespace(frames_path='./dataset/hursejump/video', output_path='./dataset/hursejump/of_trajectories/trajectories_wo_direct_filter.pt', infer_res_size=[476, 854], threshold=1.5, min_trajectory_length=2, filter_using_direct_flow=False, direct_flow_threshold=None)
Traceback (most recent call last):
File "/root/dino-tracker/./preprocessing/extract_trajectories.py", line 282, in
save_trajectories(args)
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/root/dino-tracker/./preprocessing/extract_trajectories.py", line 185, in save_trajectories
masks, flows = get_flows_with_masks(
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/root/dino-tracker/./preprocessing/extract_trajectories.py", line 44, in get_flows_with_masks
flows = torch.zeros((2, len(images) - 1, 2, h, w), device=device)
RuntimeError: Trying to create tensor with negative dimension -1: [2, -1, 2, 476, 854]
----- Running python preprocessing_dino_bb/of_filter_dino_best_buddies.py --dino-bb-path ./dataset/hursejump/dino_best_buddies/dino_best_buddies.pt --traj-path ./dataset/hursejump/of_trajectories/trajectories_wo_direct_filter.pt --out-path ./dataset/hursejump/dino_best_buddies/dino_best_buddies_filtered.pt --dino-bb-stride 7 --h 476 --w 854
Traceback (most recent call last):
File "/root/dino-tracker/preprocessing_dino_bb/of_filter_dino_best_buddies.py", line 124, in
run(args)
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/root/dino-tracker/preprocessing_dino_bb/of_filter_dino_best_buddies.py", line 45, in run
bb_data = torch.load(dino_bb_path)
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 986, in load
with _open_file_like(f, 'rb') as opened_file:
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 435, in _open_file_like
return _open_file(name_or_buffer, mode)
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 416, in init
super().init(open(name, mode))
FileNotFoundError: [Errno 2] No such file or directory: './dataset/hursejump/dino_best_buddies/dino_best_buddies.pt'
----- Running python preprocessing_dino_bb/compute_dino_bb_nms.py --dino-bb-path ./dataset/hursejump/dino_best_buddies/dino_best_buddies_filtered.pt --dino-emb-path ./dataset/hursejump/dino_embeddings/dino_embed_video.pt --out-path ./dataset/hursejump/dino_best_buddies/dino_best_buddies_filtered.pt --stride 7 --box-size 30 --iou-thresh 0.2
Traceback (most recent call last):
File "/root/dino-tracker/preprocessing_dino_bb/compute_dino_bb_nms.py", line 122, in
run(args)
File "/root/dino-tracker/preprocessing_dino_bb/compute_dino_bb_nms.py", line 82, in run
dino_bb = torch.load(args.dino_bb_path) # { 'i_j': { source_coords: [N x 2] } }
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 986, in load
with _open_file_like(f, 'rb') as opened_file:
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 435, in _open_file_like
return _open_file(name_or_buffer, mode)
File "/root/miniconda3/envs/dino-tracker/lib/python3.9/site-packages/torch/serialization.py", line 416, in init
super().init(open(name, mode))
FileNotFoundError: [Errno 2] No such file or directory: './dataset/hursejump/dino_best_buddies/dino_best_buddies_filtered.pt'


March webinar page

Story
No response
Description
Publish webinar page for March webinar. The topic will be Introduction to FlowForge.

@joepavitt can I get your help creating an image for the March webinar.
Title: DevOps for Node-RED: An introduction to FlowForge
Speaker: Nick
Date: March 30 @ 17:00CET/11amET

This'll be on my list for tomorrow if that's okay? Want something similar to the white style used last time, or more something different again?

Tomorrow is fine. I am fine with similar style as the last one but maybe with the FlowForge and Node-RED logo.

@iskerrett fyi - let me know any changes you'd like

cleaned the devops icon a little top-left

Looks good. Thanks

added into codebase via #441

sorry I was doing it right now too.

@iskerrett @joepavitt Should this be closed now?


Add Docs

This PR adds a few articles to the documentation, and resolves Issue #6 .

Can we merge this? If there are minor issues we can fix them on a future PR.


QueryForSubscription using List instead of ListAutoPaging

After being blindsided by the paywall (that is not mentioned anywhere outside of the source code), I started looking at the code enforcing it, and noticed that your logic for determining if someone has a subscriptionId will likely break after 100 guilds.

@nivekastoreth - Thanks for the issue!
After querying the 100 most recent subscriptions, we save the matched subscription here. So, in order for the limit to actually break anything, a guild would need to upgrade to pro and then never utilize any features that do the pro check before 100 more subscriptions were crated. While possible, I don't think this will occur any time soon.

Closing for now. Will reopen is issue arises.


Adding support for include and slot to graph safety

This is a log of thoughts and issues I encounter trying to implement that (see #46):
Currently the safety check is over the graph just after it is loaded. include and hence slot nodes are ignored.
Just evaluating the included graphs in isolation isn't going to work, as the safety constraints interact with the parent graph. For instance imagine a loop in the main graph (like in a React agent, see #52), which means the graph's input node's constraint are in part tied to the output node's constraints.
(1) One version that could work: Just incrementally evaluating the graph at each step. Abort when a contradiction is encountered. This is tempting, but not a great long term solution:

Runtime errors that could be foreseen
If there was another way upstream could have been laid out to avoid the safety issue, now it's too late
As long as we write graphs by hand and thoroughly test them, this isn't too bad. But for automated graph creation, it would be really nice to give "compile time" errors that the graph generator can fix by rearranging the graph.

(2) The next best option is re-evaluate the graph whenever an include or slot node is encountered, after adding the new graph to the prior full graph. This still means a runtime error, but it's a little more eager and consistently triggering. A complications we run into: ID namespaces are per graph, and so there could be name collisions. This requires changes to the current code, but shouldn't be difficult.
(3) We could then improve on that by trying to eagerly include all graphs before execution, basically recursively looking for all include and slot nodes and just loading these graphs. We have to be cautious about infinite loops, but otherwise this should work. Problems with this:

Load and parse each graph twice? Rearrange board's implementation of include and slot to do that front loaded as well?
Doesn't work, with dynamic selection of graphs, e.g. to support #44

(4) The most elegant solution to address the second concern (dynamic graphs) would be to effectively implement parametric polymorphism for graphs: That is, infer from where graph sits in the graph, including what graphs are being slotted in, what constraints it must have, then ensure that any code producing graphs that should be included only outputs valid types. This would support any number of complex scenarios, including most recursion cases and where constraints come indirectly via the slotted graphs.
As part of ensuring that only valid graphs can be added, the system would either have to convince itself for static inputs or perform a runtime test at the right point. Examples:

When loading graphs, perform the check. But also, provide a tool that allows for offline verification of all dependencies. The advantage over failing at runtime is that such tests could become part of a build system.
When selecting among many graphs, like e.g. #44 suggests, make it a filtering criteria for retrieval. A very general solution here might be possible with some offline calculations ahead of time.
When generating graphs, perform a check at runtime. But this isn't just about includes, this is the bigger idea of giving the generator safety feedback to iterate on before executing such a graph.

A new twist though is that feedback might be more nuanced, e.g. conveying that executing this graph will lower the trust for all subsequent steps and encouraging the generator to come up with a better solution.

My sense is to start with (2) and then go straight to (4), which subsumes the best of (3) as subsequent steps. Instead of implementing (1), I'm tempted to just implement fuse instead to get React agents working (see #52).

This is now implemented and should even work for dynamic graphs. In the end I went with incremental checking on every include.
We could eventually

compute constraints on includes and slots from the graph and propagate these to where graphs come from, including offline checking of included graphs
eagerly include to get errors earlier, while also raising false negatives. let's only do this once we have good alternative patterns.


Search component button height issue when text size is increased

Noticed this on Firefox, where my browser is set to zoom text only, and I'm using a zoom greater than 100%.

The search button doesn't fill the entire height of the search component. This can also be seen in the component guide preview (with similar browser settings).

I had a go at fixing this but it looks to be more complicated than I'd hoped. The component uses table and table-cell CSS to achieve the layout, with table-cell currently applied to the search input and a wrapping element on the button. I hoped that removing the wrapping element on the button and moving some styles around would fix it, but seems not. Not only does this not fix the problem but it introduces a new problem relating to the width of the input.

This is currently managed by the button wrapper being set to width: 1% and the button itself pushing out of that by setting its own width. Also, to achieve the layout above, appearance: auto needs to be set (currently set to none) otherwise the button wraps below the input.

https://github.com/alphagov/govuk_publishing_components/issues/2572 Was made as a duplicate of this, however I'm linking it here as there was a degree of useful discourse between myself and @maxgds on the priority and need of this.


Increase code coverage by 10%

We are tracking code coverage using goverage (shown here https://coveralls.io/github/kubevirt/kubevirt).
This issue is about adding tests to increase the code coverage.

this is great initiative! as we are at ~65%, getting to 80% line coverage would be awesome.
would recommend 2 things here:

provide some guidance and documentation around mocking (mock kubecli, mock http server etc.), what exist, and how to use it, as this is the main barrier (at least for me...) for writing unit tests
follow the "boy (or girl) scout rule" rather then treating it as a standalone issue - every time you enhance/fix some code, add more testing around the existing code as well

Is great - do you have a few pointers we can leave her to give new comers a good start? @yuvalif

For 2. + absolutely - tihs issue is basically an initiative to lift the base level :)

Can we take functional tests into account for code covergae - how?

@fabiand think this is not possible using the standard tools (see here: https://blog.golang.org/cover). Since the package code is generated with the coverage hooks, it is not possible to get coverage to binaries that were already generated and running.
they do mention that gcov may work, as this does dynamic coverage on the binary itself, it may give coverage results for the integration tests.
this would require building the binaries in way that gcov could run interact with them using gccgo.

generated files should be excluded from coverage report: https://stackoverflow.com/questions/50065448/how-to-ignore-generated-files-from-go-test-coverage
this will be a low hanging fruit for increasing coverage in significant numbers (thanks @SchSeba for the idea!)

@yuvalif I fear that most are already excluded. The only ones included are the defaulter and deepcopy files. They are tested with some fuzzing and have almost 100% coverage (another question is if it is really necessary since k8s would probably detect immediately if their generators are broken but it was just easy to do).

@yuvalif FYI: https://github.com/kubevirt/kubevirt/blob/master/hack/goveralls.sh

@rmohr the zz_generated... files are still pretty low, probably better to exclude them.
@stu-gott I have written a post on general guidelines http://kubevirt.io/2018/Unit-Test-Howto.html on unit testing in our project.
will try to identify and list areas of focus and will add here.

looked at files that were recently modified as part of bug fixes, and has low coverage (=indication that adding coverage will find bugs):

pkg/virt-api/rest/subresource.go
pkg/virt-handler/device-manager/generic_device.go
pkg/virt-handler/device-manager/device_controller.go
pkg/virt-launcher/virtwrap/cli/libvirt.go

another files that probably be on the list:

pkg/virt-api/api.go

if you feel that the list above is a good focus, will try to write-up some guidance per file as for how to do the testing.

@yuvalif that sounds like a plan. thanks!

pkg/virt-api/rest/subresource.go
subresource_test.go already exists, however, the actual logic is not tested. to test it, the calls from the test code should be calling into the request handler (ideally via the public APIs). most of the work there would be around mocking of websocker, upgrader and io.
pkg/virt-api/api.go
api_test.go already exists, covering mainly certification code . should add coverage to: composeSubresources() (or even better to the Compose() public interface). mocking of http server will be needed.
pkg/virt-launcher/virtwrap/cli/libvirt.g
according to this: https://github.com/libvirt/libvirt-go#testing there is a test driver, unrelated to libvirt running on OS. should investigate if this can be used. current test file exists, but does not cover only failure to open a new connection

Trying to help here, I think I will have PR soon at least for subresource.

@qinqon Great to hear it, you can comment with /remove-lifecycle stale if you want to work on it and also you can run /assign @qinqon.

/remove-lifecycle stale

/assign @qinqon

/assign @qinqon

Adding you as a member, @qinqon

@fabiand thanks, will try to do my best here!
/assign @qinqon

Added some subresource coverage, websockets and SPDY stuff:
https://github.com/qinqon/kubevirt/commit/dd7c82e9c29e49c0c4f76bf66e5c84449825d6d9
Now virt-api/rest has a coverage of 54.6%
It's good enough to create a PR with just that or better to add more coverage elsewhere ?

@qinqon cool, I think it is enough for the first PR.

Sound cool!

Ok, so I have around 60% of coverage of pkg/virt-api/api.go here this would be good enough for another PR ? also I have to fix some issues local running is working but timing out at travis.

@qinqon I can feel free to create additional PR :smile:

@cynepco3hahue here we are with the PR, maybe it's too big.


improve AOS config merging and add default duration

Summary

Fixed the merging of AOS configuration values from nuxt.config.ts and added default values for duration.
Improved AOS initialization to handle missing configuration values gracefully.

Changes

Merged the aosConfig values from config.public.aos and provided default values like duration: 600.
Used TypeScript's AOSOptions type to ensure correct configuration structure.
Updated the AOS initialization to correctly handle merged configuration.

Why
This fix ensures that the AOS configuration behaves as expected, even when certain values are missing from the config file, and provides reasonable defaults to improve the development experience.

Why Use app:mounted in Nuxt-AOS
1. Using app:mounted with AOS

Using app:mounted ensures that AOS starts working only after the DOM has been rendered, allowing AOS to function properly without issues.

Hi, thanks for your PR, I'll take a closer look and merge later tomorrow. Still need to test.
For now, whats the reason to use the 'app:mounted' hook? Check issue #21 and PR #22 for more info.

Hi [egidiusmengelberg],
I hope you're doing well. I just wanted to follow up on my PR from the 15th. I understand that you may be busy, but I wanted to check if there are any updates or if there's anything else I can do to help with the review process.
Thanks again for taking the time to look into it!

yeah sorry, was a bit busy
just took a better look. What is the reason to change the default behaviour?
The AOS library already has some good defaults. And you can overwrite them as needed. Why change them for everyone?
The default values used can be seen here: https://github.com/michalsnik/aos/blob/329fb34f777034345f4d3f4def4dc3bcc300cc2e/src/js/aos.js#L29

yeah sorry, was a bit busy
just took a better look. What is the reason to change the default behaviour?
The AOS library already has some good defaults. And you can overwrite them as needed. Why change them for everyone?
The default values used can be seen here: https://github.com/michalsnik/aos/blob/329fb34f777034345f4d3f4def4dc3bcc300cc2e/src/js/aos.js#L29

So, what should I improve, considering that the code for the AOS module only allows for very limited customization?


MountVolume.SetUp failed for volume "webhook-tls-certs" : secret "webhook-server-tls" not found

kubeflow / cache-server log
MountVolume.SetUp failed for volume "webhook-tls-certs" : secret "webhook-server-tls" not found

Unable to attach or mount volumes: unmounted volumes=[webhook-tls-certs], unattached volumes=[kubeflow-pipelines-cache-token-xbbbk webhook-tls-certs istio-envoy sds-uds-path istio-token]: timed out waiting for the condition

Would this by any chance be related to https://github.com/kubeflow/pipelines/issues/4505? What version of kubernetes are you using? How did you deploy kubeflow?

Hi @zhangchunsheng, which platform are you running Kubeflow on i.e. AWS, GCP, on-prem ?

Hi @zhangchunsheng, which platform are you running Kubeflow on i.e. AWS, GCP, on-prem ?

Aliyun

I have the same issue.

I have solved this problem in my env.
I commented out everything in the cat /etc/resolv.conf.


Use ~/.ccm/.dse.ini as dse credentials file if it exists by default.

I really like the recent addition of the '--dse-credentials' config parameter for loading credentials from a config file.   For convenience I think it would be nice if there were a default credentials file that, if exists, will be loaded to grab the dse credentials.   This would remove the need to pass the path of the credentials file each time you create a cluster.
The existing behavior:

If user passes in --dse-credentials, grab dse_username and dse_password from the passed in config file.
Else grab from --dse-username and/or --dse-password

The new behavior:

If user doesn't pass in --dse-credentials and .dse.ini exists, set dse_username and dse_password based on it's contents.
Else If user passes in --dse-credentials, grab dse_username and dse_password from the passed in config file.
If --dse-username and/or --dse-password were passed in explicitly, override the dse_username and dse_password values.

+1


✨Add prefix for generated users (continuation)

Good evening,
as mentioned in the PR #1378, it would be interesting to have the possibility of generating a prefix for the users created on the different managers.
I see that in some managers, the method is overridden.
I therefore still wanted to include this option.
Ignored option for CPanel due to restrictions (max 16 characters). This is specified on the front and translated into a few languages.
Thank you so much

Sorry thats a bug unwanted frome me. Have a good day

indeed, this is preferable. thanks for the advice

very likely not being an expert in English


[Volunteer Database] Hide promotional heading when already signed up

Title
[Volunteer Database] Hide promotional heading when already signed up
Platform / OS
Ubuntu 17
Browser
Chrome
Description
Suggestion to hide the promotional heading when already signed up. If the logged in user's email exists in volunteer database, then there should be no need to show the heading unless it is rephrased to onboard others. Though, this issue is not necessary if the promotion is not going to be active for very long.

won't fix now


Updated pom file to use new version of base-microservice-example

https://3.basecamp.com/3537281/buckets/4129302/todos/2034514413

@leonatherton No some problem appears when I rebuild.
Here also, I need to refractor conversion to com.idrsolutions.microservice.
Also, there seems to be import issue with BuildvuConverter (org.jpedal.examples.BuildvuConverter)class which I am unable to locate anywhere.

@niraliabhani You will need to use buildvu-svg.jar or buildvu-html.jar which has that class

@Leon I have added two new commits.
one query, should i have to chnage pom file to use buidvu-html to allow it to compile ?

@niraliabhani the package for BuildVuServlet needs to be com.idrsolutions.microservice
Would it be possible to update that today so that we can merge?

@leonatherton I have updated . Apologies, I thought I had used that but somehow it was not used.


Blog Post:  Admiral has a cheatsheet, let's talk about it!

Blog Post
Showcasing {admiral} cheatsheet!

Hi @sadchla-codes, how is this coming along?

@pharmaverse/admiral does anyone want to take this over from @sadchla-codes ? Would be a great one to get out!


[SPARK-16538][SPARKR] Add more tests for namespace call to SparkSession functions

What changes were proposed in this pull request?
More tests
I don't think this is critical for Spark 2.0.0 RC, maybe Spark 2.0.1 or 2.1.0.
How was this patch tested?
unit tests
@shivaram @dongjoon-hyun

#14195

Test build #62342 has started for PR 14206 at commit 2303a2c.

Test build #62342 has finished for PR 14206 at commit 2303a2c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62342/
Test PASSed.

LGTM. Thank you for doing this.

LGTM. Merging this to master, branch-2.0


ContinuityAnalyzer message for packets without payload but with the CC incremented is confusing

I deliberately generated a TS with the CC incremented for packets without any payload and ran it through tsfixcc --verbose --noaction .  tsfixcc correctly reported discontinuities, but it did so in a confusing fashion.  Here is an example of the output:
packet: 1,347,899, PID: 0x0164, missing:  0 packets
<snip>
2,493,804 packets read, 36 discontinuities, 0 packets updated

The "packet:" message is reported by the ContinuityAnalyzer class (in the feedPacketInternal() method), and even though I know that this message corresponds to an unexpected discontinuity caused by the CC value being incremented for a packet without any payload, I have no idea what this message means.  This message appears to be used for multiple possible situations, not just for the no payload situation, so perhaps it would be useful to have different messages for each of the different issues that might occur.

Yes, this is confusing indeed. In case of a detected discontinuity, the code computes the number of missing packets (modulo 16). For instance, if we get CC values 7 and 10, we know that 3 packets are missing. In the case of 7 and 8 without payload, the same algorithm reports 0 missing packets while the message should be different. I will fix it.

Fixed in commit cbd8859e71c93e809b2a8e1b52e07f8be1f8f78e

I know that you verified that this bug is fixed, but I can also confirm that it is verified.  I'd say now TSDuck offers the best CC checking of any TS tool on the market (free or non-free) of which I have experience with.  Two different pieces of software that I've used have reported that there is a CC error in this case, but neither reported why.  The new message is very clear, and if someone doesn't understand exactly what it means, it would be fairly quick to do a search on the Internet and find out.  BTW, nice job on abstracting out the code having to do with CC and creating the ContinuityAnalyzer class.


Daemon acquiring access toke on behalf of the user

Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
We use GitHub issues as the primary channel for customer and community feedback about the Azure documentation.
Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[ ] The relevant Azure service or technology.
[ ] A link to the published documentation article that you have feedback about.
[ ] Clear, specific feedback that the author can act on.

Pull requests and article contributions
If you know the change that is needed in an article, we encourage you to submit the changes directly using a pull request. If the change is large, or if you want to contribute an entire article, follow these guidelines:

[ ] Don't surprise us with a big pull request or a pull request with a new article! Submit an issue that describes the details of the proposed large change or new article.
[ ] Include the service or technology area.

We'll route the issue to the appropriate content team for review and discussion.
Tech support and product feedback
If you would like to contact Microsoft about other things, such as product feedback or tech support, please review these guidelines:

If you need technical support using Azure, the paid and free support options are described here: https://azure.microsoft.com/support/options/.

Each article in the Azure technical documentation contains a product feedback button - it's best to submit product feedback directly from a relevant article. Otherwise, you can submit product feedback for most Azure products in the following product feedback forum: https://feedback.azure.com/forums/34192--general-feedback.

@SaurabhSharma-MSFT So I understand the daemon would use app cert to get the token.  But then any user that runs this app would be able to acquire the token? So all I need to gain access to any users token then is to write a daemon and unbeknown to the a victim execute it in their account to acquire access token on their behalf.
Is it that the App is registered in Azure with each user allowed to run this application.  Once this is done access token can be acquired on that users behalf.  If a malicious user gains access to the app/daemon and executes it in some random user's account who does not have the daemon registered in AAD for him, then his access token request would be denied by AAD?  Is this correct?

@minhaj-dell Thanks for your question. Can you please share the url, if there is a particular Azure doc you have been following?

@Karishma-Tiwari-MSFT related to this discussion here: https://github.com/MicrosoftDocs/azure-docs/issues/14559

@minhaj-dell Since this issue is a duplicate of the other one which has been resolved, I will close this now.


Ceedling Gem 0.27.0 use_test_preprocessor: TRUE injects '@' Symbols in include statements.

Anytime I try to run "rake test:all" using Ceedling gem 0.27.0 I get the following failure.
../test/build/temp/_test_main.c:2:23: fatal error: @@@@unity.h: No such file or directory
compilation terminated.
Ceedling is generating the _test_main.c file and injecting the @@@@in the include filename.
Reverting to 0.25.0 or setting :use_test_preprocessor: FALSE and the issue goes away.
Here is a dump of the console log.
S C:\Users\isaac.rose\workspace\CeedlingTest\test> rake test > error.log
../test/build/temp/_test_main.c:2:23: fatal error: @@@@unity.h: No such file or directory
compilation terminated.
ERROR: Shell command failed.

Shell executed command:
'gcc.exe -I"test" -I"test/support" -I"test/support" -I".."
ShellExecutionException: ShellExecutionException
C:/Users/isaac.rose/workspace/CeedlingTest/test/vendor/ceedling/lib/ceedling/tool_executor.rb:78:in exec' C:/Users/isaac.rose/workspace/CeedlingTest/test/vendor/ceedling/lib/ceedling/generator.rb:95:in generate_object_file'
C:/Users/isaac.rose/workspace/CeedlingTest/test/vendor/ceedling/lib/ceedling/rules_tests.rake:17:in block in <top (required)>' C:/Users/isaac.rose/workspace/CeedlingTest/test/vendor/ceedling/lib/ceedling/task_invoker.rb:74:in invoke_test_results'
C:/Users/isaac.rose/workspace/CeedlingTest/test/vendor/ceedling/lib/ceedling/test_invoker.rb:104:in block in setup_and_invoke' C:/Users/isaac.rose/workspace/CeedlingTest/test/vendor/ceedling/lib/ceedling/test_invoker.rb:63:in setup_and_invoke'
C:/Users/isaac.rose/workspace/CeedlingTest/test/vendor/ceedling/lib/ceedling/tasks_tests.rake:4:in `block in <top (required)>'
Tasks: TOP => build/test/results/test_main.pass => build/test/out/test_main.out => build/test/out/_test_main.o
(See full trace by running task with --trace)

Do you mind posting your project.yml and telling us what version of ruby you are using? I can't reproduced the issue locally on any of my repos.
If you want to put in a little extra work, you can also try and create a bare minimum example on github and run it through travis to help pinpoint the issue as seen here and here.

In the attached zip file you will find:
/src/ - source...
/test.25/ - project created using "ceedling new test.25" command with only ceedling 0.25.0 installed.. Run "rake test:all" and it builds correctly.
/test.27/ - project created using "ceedling new test.27" command with only ceedling 0.27.0 installed. Run rake test:all" and it fails for the above issue.
CeedlingTest.zip

@dpostorivo , I will see about setting it up for GitHub and running it through Travis.

ruby 2.3.1p112 (2016-04-26) [i386-linux-gnu] (Ceedling 0.25.0)
ruby 2.3.3p222 (2016-11-21 revision 56859) [x64-mingw32] (Ceedling 0.27.0)
ruby 2.3.4p301 (2017-03-30 revision 58214) [x86_64-linux-gnu] (Ceedling 0.27.0)

There's a few things going on.
The first is an issue that I've seen before with this release as shown in #147 where it includes files with an underscore in build time compiling so the temp file called ``_test_main.cwhich is an intimidate file totest_main.c` is compiled. It should not be compiled.
The second is why you were seeing the issue and I wasn't which is the build path is in your source path so ceedling tries to compile every file in your build directory that matches the file pattern which due to the issue above includes the temp file. This can cause a number of issues, this being just an edge case that was introduced by another bug. I was able to get ceedling to work for you zip by changing this line in your project.yml:
:paths:   :test:     - +:test/**     - -:test/support   :source:     - ../**   :support:     - test/support
to this:
:paths:   :test:     - +:test/**     - -:test/support   :source:     - ../src   :support:     - test/support
If anything else arises or this doesn't fix it let me know. I'm going to look more in depth into the first issue which caused this issue, but changing the project.yml should resolve all your cases.

Hi @mvandervoord I have the same issue with ceedling 0.29.0 when I set test_preprocessor to true and my source files are located in the project folder instead of a src folder.
Compiling _test_myFile...
./build/temp/_test_myFile.c:2:23: fatal error: @@@@unity.h: No such file or directory

Disabling test preprocessor or moving source files in a separate folder fix this.
As explained by @dpostorivo setting project.yml to :
:paths:
  :source:
    - ./**

Make ceedling to search for source files in all project subfolders and the error in my case come from build/temp/_test_myFile.c.
I don't know if this should be considered as a bug or if users should not place any source directly in project folder but in both cases we should fix or document it to help new users to not make the same mistakes.
In the first case we could not check for subfolders when source path equals project path (but I think this is my requirement and does not apply to everyone) or we could search in subfolders that are not used for build / test... ? I don't know if there is a way to ignore subfolders, this may also solve this if user can choose which folders to ignore ?


Loss function in training code is different from paper.

i came across your work of Deep Photo Enhancer. it is truly amazing work. Currently i am trying to re-implement your work. The adversarial loss function in your Tensorflow training code is confusing to me. In your paper, you stated that Adversarial loss for discriminator is

Ad = E[Dx(x)] - E[Dx(x')] + E[Dy(y)] - E[Dy(y')], However in your code, it is E[Dx(x) - D[Dx(x')] + E[Dy(y') - E[Dy(y)].
It that a mistake? or i misunderstood the objective function?

Same goes to Adversarial loss for generator. In your paper, it is E[Dx(x')] + E[Dy(y')]. but in code, it is E[Dx(x')] - E[Dy(y')].
Look forward to your reply. Thank you.

Is this: https://github.com/nothinglo/Deep-Photo-Enhancer/issues/30#issuecomment-439091925 answer your question?

so in your code, u actually set real image as negative and fake image as positive for discriminator B while real image as positive and fake image as negative for discriminator A right?

Yes, I remember the setting in my code is that. Thanks.


QtTesting - Add unit test to the QtTesting library to test pqMyTranslator/Player

Unit test should added using the QtTest based framework. For example, see:

https://github.com/commontk/CTK/blob/master/Libs/Widgets/Testing/Cpp/ctkMessageBoxDontShowAgainTest.cpp
https://github.com/Slicer/Slicer/blob/master/Base/QTCore/Testing/Cxx/qSlicerExtensionsManagerModelTest.cxx


Fix duplicate fields bugs

Prevents duplicate phone numbers, emails or telegram handles but allow duplicate names as long as none of these fields are identical as two people can have the same name in real life.
closes #163
closes #165
closes #166
closes #167
closes #181

Codecov Report
Attention: Patch coverage is 40.62500% with 19 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

.../java/seedu/address/logic/commands/AddCommand.java
0.00%
3 Missing and 4 partials :warning:

...c/main/java/seedu/address/model/person/Person.java
14.28%
0 Missing and 6 partials :warning:

...a/seedu/address/model/person/UniquePersonList.java
60.00%
3 Missing and 3 partials :warning:

Files with missing lines
Coverage Δ
Complexity Δ

src/main/java/seedu/address/model/AddressBook.java
75.67% <100.00%> (+2.14%)
14.00 <3.00> (+3.00)

...rc/main/java/seedu/address/model/person/Phone.java
92.85% <ø> (ø)
6.00 <0.00> (ø)

...c/main/java/seedu/address/model/person/Person.java
69.23% <14.28%> (-7.05%)
24.00 <0.00> (+1.00)
:arrow_down:

...a/seedu/address/model/person/UniquePersonList.java
80.32% <60.00%> (-6.63%)
26.00 <6.00> (+6.00)
:arrow_down:

.../java/seedu/address/logic/commands/AddCommand.java
73.07% <0.00%> (-26.93%)
8.00 <0.00> (ø)


AWS, System, and Network hardening (t-shirt)

AWS, System, and Network hardening
Spike: solution for managing credentials and SSH keys (maybe eliminating them)
K8s (M)
Managed Services (M)
AWS platform (Cloudwatch/ GuardDuty) (L)

T-Shirt estimate was made on 05/31/19.

S: < 1 pair / .5 sprint
M:  1 pair / 1 sprint
L: 2 pairs / 1 sprint
XL: way >

07-02-2019 Migrated from SMRT-1322

Reduced due to cards that have been written

And again


Add Link OpenApiUrl in Registered Service View Object with HATEOS

fix #265

@baixinsui as discussed,

HATEOS is important here. So we use what is supported by HATEOS the best.
Data model and response matches - "links" or "_links" but it should be same everywhere.
Let the framework decide the URL. and enable "Forwarded Header" handling.

I fixed all above.


The save_to config param does not alias to sink, as specified by the deprecation notice in the docs

Guzzle version(s) affected: 7.x
PHP version: 8.0.9
cURL version: 7.68.0
Description
The docs mention that the save_to option has been deprecated, but it should still work as an alias to sink.
How to reproduce
$testUrl = 'https://people.sc.fsu.edu/~jburkardt/data/csv/addresses.csv';
$destinationPath = '/tmp/test-addresses.csv';

$client = new Client();

// This does not work, even though it's supposedly aliased to 'sink'
$client->get($testUrl, ['save_to' => $destinationPath]);

// This works perfectly
$client->get($testUrl, ['sink' => $destinationPath]);

I will try to come up with a PR as soon as I get some free time, unless somebody patches this in the meanwhile.

I think this was deprecated in 6.x and removed in 7?


Markdownlint warnings

The markdownlint plugin in VS-Code throws 68 warnings in Readme.md. Should I fix those?
Not important, just style. 😄

Ok, make a pull request...

No, just added the mention of Cairo as third factory.
I would fix the readme, but this would also mean that you have adapt your writing style in order to avoid future warnings ;)
If that's too much hassle, I'm not going to fix the lint warnings.


Avoid JS error on issue/pr list when logged out

When logged out, the checkboxes are not there on the issue/pr lists, which would cause an error here.

Fixes https://github.com/go-gitea/gitea/issues/29862?

Fixes #29862?

yes


[Formatting Bug]: Adds spaces where there shouldn't be

Version
1.11.1
Template before formatting
@php
    use Eagle\Utilities\Dates\TimeZone;
<- no spaces here
    $timezone_options =
        ['' => ''] +
        TimeZone::create()
            ->format('tz-label')
            ->countryCodePriority('US')
            ->get();
@endphp

Template after formatting
@php
    use Eagle\Utilities\Dates\TimeZone;
    <- four spaces here
    $timezone_options =
        ['' => ''] +
        TimeZone::create()
            ->format('tz-label')
            ->countryCodePriority('US')
            ->get();
@endphp

Expected Behaviour
The formatter shouldn't input spaces where there should just be a newline char---some editors show these whitespace characters and remove them automatically:

Note that this only applies to extra spaces at the end of the line
Relevant log output
No response

Fixed at https://github.com/shufo/prettier-plugin-blade/releases/tag/v1.13.1.
Thank you @CalebDW!


why the response header of my app miss the content-length when it pass the gateway layer

I have used spring cloud to build a multiple microservice,and i use a API-Gateway implemented using Spring Cloud Netfix's Zuul Server to route the requests to our micro services ,the gateway config like this(learn from https://gist.github.com/tiarebalbi/062a814d063ee694bbf6):
https://gist.github.com/jelen56/e70663b1b88d9ae16f6d69f7fa4048b7
when i passing througth the gateway layer,the response header is missing content-length,but it has the content-length when i directly invoke backend service.

Why do you have sensitiveHeaders: "*"?

Does't it mean to pass all the response headers from other inner service?ps:sorry,i am late to respond you.

IIRC it means don't pass any headers.

I have no idea for this issue,what do you think I should do?

have you tried removing the sensitiveHeaders config entry, or setting it to ''.

closing do to lack of feedback


Provide installation instructions

The Select2 "Download" link gives me a .zip file with a bunch of different files in it. I don't really see any explanation of what's going on here, though. Which files do I need to get the minimum functionality? What is a .js.template file? There are also several images. What file path does the library assume the images will be available at? What if my project is organized so that .js files are served out of a different directory than images? Is there a way to configure that?
Thus, my feature request is that the README provide a brief overview of how to get started using the library.

Quick start instructions are now displayed on the main page of the documentation.
https://select2.github.io/


Add HHH section to FAQ

OzLockCon is stepping up to help other hackers in need. Currently, the organisation "Hackers Helping Hackers" is stuck in legal-limbo sorting paperwork to allow them to continue to do their excellent work. In the meantime, they've advised that we accept applications direct. As a result, this application is a slimmed down and slightly modified version of the one you'd need to submit for HHH.
Applicants will be notified at least one month prior to the conference as to the success of their submission, sooner if logistics allow.
If you have any questions, please feel free to email directly to<EMAIL_ADDRESS>Otherwise, feel free to submit a Hackers Helping Hackers application.

Reword/simplify.

Done and on the live server. May need improvement however


OpenCV should copy/install opencv_ffmpeg340_64.dll

As we found out in #2613, opencv_ffmpeg340_64.dll is not copied over to the build/install folder, and causes all operations in OpenCV that use ffmpeg to sort-of "silently" fail. For example, reading from the camera or from video files doesn't work unless the file is manually copied.

I can try to figure this out in my free time.

I did a bit of investigation and determined the following:

The LoadLibrary call is inside the videoio component
You can actually run findstr /mrs "._.f.f.m.p.e.g.3.4.0._" *.exe and it will correctly identify applications which static link the videoio component (the name is UTF-16 encoded, thus the .s to match null bytes)

Hmm that's cool :D But how does it help us? Are you saying that vcpkg actually inspects the compiled executable, and then only copies the dll's that are necessary? So what you want to do is figure out after compilation whether an executable contains references to ffmpeg, and if so, copy the ffmpeg dll to the build/install directory?

Yep, we do exactly that [1]!

figure out after compilation whether an executable contains references to ffmpeg

And that's plan A if it works. The current issue that I'm aware of is that findstr isn't exactly designed to search large binary files so it can fail with "line too long" errors (though none of my test cases hit this). I think the longer-term replacement would be for us to implement a small C++ utility in vcpkg that performs the search which won't have this problem (and might be faster).
[1] https://github.com/Microsoft/vcpkg/blob/425d07ef7f82541e50cc8cb1e2716fc33bba7b12/scripts/buildsystems/msbuild/applocal.ps1

Maybe use ripgrep? It supports UTF-16 and crossplatform https://github.com/BurntSushi/ripgrep

I want to add that another issue with opencv_ffmpeg340_64.dll is that the opencv[ffmpeg] package does not export opencv_ffmpeg library target at all. Therefore I cannot easily create workaround in my project by copying this target explicitly. Could you please export the opencv_ffmpeg target when opencv[ffmpeg] is built?
I think that grepping target dependent libraries for a strings which look like names of other shared libraries, and assume that they are potentially run-time loaded is a quite fragile approach. IMHO the right way is to use the available CMake mechanisms to accomplish this. I never used the shared library property IMPORTED_LINK_DEPENDENT_LIBRARIES, but it seems to me that this could be the right way to express that opencv_videoio library has dependency to opencv_ffmpeg library.
https://cmake.org/cmake/help/v3.10/prop_tgt/IMPORTED_LINK_DEPENDENT_LIBRARIES.html
Unfortunately, it seems that vcpkg does not copy automatically the libraries added to IMPORTED_LINK_DEPENDENT_LIBRARIES. In my project right before the use of the exported target opencv_videoio I have added a workaround code which created imported shared library target named opencv_ffmpeg (based on the imported location of  opencv_videoio). I have added this opencv_ffmpeg target to the IMPORTED_LINK_DEPENDENT_LIBRARIES property of the opencv_videoio, but this does not fixed the installation of the opencv_ffmpeg340_64.dll.
Does one have to expect that vcpkg would copy the libraries listed in  IMPORTED_LINK_DEPENDENT_LIBRARIES property of a linked library target?
I have also noticed that opencv_ffmpeg340_64.dll is the only one library which is created in the Debug sub-directory located in the release binary directory. The same is exactly reversed for the debug build. In this case opencv_ffmpeg340_64.dll is the only one library which is created in the Release sub-directory located in the debug binary directory.
buildtrees/opencv/x64-windows-rel/bin/Debug/opencv_ffmpeg340_64.dll
buildtrees/opencv/x64-windows-dbg/bin/Release/opencv_ffmpeg340_64.dll
Is it this a bug or this is intentional?
In addition no import libraries are generated for opencv_ffmpeg, also not even in the build directory tree, but this is a way more probable to be intentional, in order to prevent users from linking directly to this library.

@coderaper Did you try the vcpkg branch with external ffmpeg? There's still some work to do, but it is almost ready to merge.
I proposed that and I am strongly for it, I need other users' opinions!
I'd like to see it merged soon...

@cenit I have tried to build the external ffmpeg branch, but opencv build fails because the FFMPEG package cannot be found. As far as I can see, another reason for the configuration error can be that the installed libpng headers are located in installed\x64-windows\include\libpng16 and not in installed\x64-windows\include\libpng.
vcpkg-ext-ffmpeg>vcpkg install opencv[qt,ffmpeg,core,eigen,tiff,png,jpeg]:x64-windows
The following packages will be built and installed:
opencv[qt,ffmpeg,core,eigen,tiff,png,jpeg]:x64-windows
Starting package 1/1: opencv:x64-windows
Building package opencv[qt,ffmpeg,core,eigen,tiff,png,jpeg]:x64-windows...
-- CURRENT_INSTALLED_DIR=C:/balkanski/work/vcpkg-ext-ffmpeg/installed/x64-windows
-- DOWNLOADS=C:/balkanski/work/vcpkg-ext-ffmpeg/downloads
-- CURRENT_PACKAGES_DIR=C:/balkanski/work/vcpkg-ext-ffmpeg/packages/opencv_x64-windows
-- CURRENT_BUILDTREES_DIR=C:/balkanski/work/vcpkg-ext-ffmpeg/buildtrees/opencv
-- CURRENT_PORT_DIR=C:/balkanski/work/vcpkg-ext-ffmpeg/ports/opencv/.
-- Using cached C:/balkanski/work/vcpkg-ext-ffmpeg/downloads/opencv-opencv-3.4.0.tar.gz
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Extracting done
-- Applying patch C:/balkanski/work/vcpkg-ext-ffmpeg/ports/opencv/0001-winrt-fixes.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch C:/balkanski/work/vcpkg-ext-ffmpeg/ports/opencv/0001-winrt-fixes.patch done
-- Applying patch C:/balkanski/work/vcpkg-ext-ffmpeg/ports/opencv/0002-install-options.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch C:/balkanski/work/vcpkg-ext-ffmpeg/ports/opencv/0002-install-options.patch done
-- Applying patch C:/balkanski/work/vcpkg-ext-ffmpeg/ports/opencv/0003-disable-downloading.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch C:/balkanski/work/vcpkg-ext-ffmpeg/ports/opencv/0003-disable-downloading.patch done
-- Applying patch C:/balkanski/work/vcpkg-ext-ffmpeg/ports/opencv/0004-use-find-package-required.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch C:/balkanski/work/vcpkg-ext-ffmpeg/ports/opencv/0004-use-find-package-required.patch done
-- Applying patch C:/balkanski/work/vcpkg-ext-ffmpeg/ports/opencv/0005-use-external-ffmpeg.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch C:/balkanski/work/vcpkg-ext-ffmpeg/ports/opencv/0005-use-external-ffmpeg.patch done
-- Using cached C:/balkanski/work/vcpkg-ext-ffmpeg/downloads/opencv-cache/tiny_dnn/adb1c512e09ca2c7a6faef36f9c53e59-v1.0.0a3.tar.gz
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Configuring x64-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:56 (message):
Command failed: ninja;-v
Working Directory: C:/balkanski/work/vcpkg-ext-ffmpeg/buildtrees/opencv/x64-windows-rel/vcpkg-parallel-configure
See logs for more information:
C:\balkanski\work\vcpkg-ext-ffmpeg\buildtrees\opencv\config-x64-windows-out.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_configure_cmake.cmake:248 (vcpkg_execute_required_process)
ports/opencv/portfile.cmake:203 (vcpkg_configure_cmake)
scripts/ports.cmake:72 (include)
Error: Building package opencv:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: opencv:x64-windows
Vcpkg version: 0.0.105-2018-02-23-d6aca74b0ccbab217d521a2e105658e6820a9f3d
Additionally, attach any relevant sections from the log files above.

-- Found LibLZMA: C:/balkanski/work/vcpkg-ext-ffmpeg/installed/x64-windows/include (found version "5.2.3")
-- Found ZLIB: optimized;C:/balkanski/work/vcpkg-ext-ffmpeg/installed/x64-windows/lib/zlib.lib;debug;C:/balkanski/work/vcpkg-ext-ffmpeg/installed/x64-windows/debug/lib/zlibd.lib (found version "1.2.11")
-- Found PNG: optimized;C:/balkanski/work/vcpkg-ext-ffmpeg/installed/x64-windows/lib/libpng16.lib;debug;C:/balkanski/work/vcpkg-ext-ffmpeg/installed/x64-windows/debug/lib/libpng16d.lib (found version "1.6.34")
-- Looking for C:/balkanski/work/vcpkg-ext-ffmpeg/installed/x64-windows/include/libpng/png.h
-- Looking for C:/balkanski/work/vcpkg-ext-ffmpeg/installed/x64-windows/include/libpng/png.h - not found
CMake Error at C:/Program Files/CMake/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find FFMPEG (missing: FFMPEG_INCLUDE_DIR)
Call Stack (most recent call first):
C:/Program Files/CMake/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
C:/balkanski/work/vcpkg-ext-ffmpeg/installed/x64-windows/share/ffmpeg/FindFFMPEG.cmake:11 (find_package_handle_standard_args)
C:/balkanski/work/vcpkg-ext-ffmpeg/scripts/buildsystems/vcpkg.cmake:252 (_find_package)
cmake/OpenCVFindLibsVideo.cmake:217 (find_package)
CMakeLists.txt:604 (include)
-- Configuring incomplete, errors occurred!
See also "C:/balkanski/work/vcpkg-ext-ffmpeg/buildtrees/opencv/x64-windows-dbg/CMakeFiles/CMakeOutput.log".
See also "C:/balkanski/work/vcpkg-ext-ffmpeg/buildtrees/opencv/x64-windows-dbg/CMakeFiles/CMakeError.log".
ninja: build stopped: subcommand failed.

Determining if the include file C:/balkanski/work/vcpkg-ext-ffmpeg/installed/x64-windows/include/libpng/png.h exists failed with the following output:
Change Dir: C:/balkanski/work/vcpkg-ext-ffmpeg/buildtrees/opencv/x64-windows-dbg/CMakeFiles/CMakeTmp
Run Build Command:"C:/balkanski/work/vcpkg-ext-ffmpeg/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "cmTC_cce1d"
[1/2] Building C object CMakeFiles\cmTC_cce1d.dir\CheckIncludeFile.c.obj
FAILED: CMakeFiles/cmTC_cce1d.dir/CheckIncludeFile.c.obj
C:\PROGRA~2\MICROS~3.0\VC\bin\amd64\cl.exe  /nologo   /DWIN32 /D_WINDOWS /W3 /utf-8 /MP  /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE /D _SCL_SECURE_NO_WARNINGS /Gy /bigobj /Oi        /MP8   /MDd /Zi /Ob0 /Od /RTC1 /showIncludes /FoCMakeFiles\cmTC_cce1d.dir\CheckIncludeFile.c.obj /FdCMakeFiles\cmTC_cce1d.dir\ /FS -c CheckIncludeFile.c
CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'C:/balkanski/work/vcpkg-ext-ffmpeg/installed/x64-windows/include/libpng/png.h': No such file or directory
ninja: build stopped: subcommand failed.
vcpkg-ext-ffmpeg>vcpkg list libpng
libpng:x64-windows                                 1.6.34-2         libpng is a library implementing an interface fo…
vcpkg-ext-ffmpeg>dir vcpkg-ext-ffmpeg\installed\x64-windows\include\libpng16
. . . . . . . . . . . .
03/02/2018  03:45 PM    <DIR>          .
03/02/2018  03:45 PM    <DIR>          ..
09/29/2017  09:42 AM           144,149 png.h
09/29/2017  09:42 AM            22,845 pngconf.h
03/02/2018  03:45 PM             7,839 pnglibconf.h
vcpkg-ext-ffmpeg>vcpkg list ffmpeg
ffmpeg:x64-windows                                 3.3.3-3          a library to decode, encode, transcode, mux, dem...
ffmpeg[openssl]:x64-windows                                         openssl support in ffmpeg

@ras0219-msft I don't know if the GNU Binutils are accepted as vcpkg tools, but the strings utility in combination with grep seems to work:
strings --encoding=l opencv_videoio340.dll | grep "\.dll"
opencv_ffmpeg340_64.dll
kernel32.dll
opencv_videoio340.dll
If the use of 16-bit littleendian encoding is not specified (--encoding=l command line switch), than I guess strings searches for single-8-bit-byte characters and other dll names are found:
strings opencv_videoio340.dll | grep "\.dll"
opencv_videoio340.dll
opencv_imgcodecs340.dll
MSVFW32.dll
AVIFIL32.dll
AVICAP32.dll
opencv_imgproc340.dll
opencv_core340.dll
KERNEL32.dll
USER32.dll
ole32.dll
OLEAUT32.dll
MSVCP140.dll
MF.dll
MFReadWrite.dll
VCRUNTIME140.dll
api-ms-win-crt-environment-l1-1-0.dll
api-ms-win-crt-stdio-l1-1-0.dll
api-ms-win-crt-runtime-l1-1-0.dll
api-ms-win-crt-heap-l1-1-0.dll
api-ms-win-crt-filesystem-l1-1-0.dll
api-ms-win-crt-string-l1-1-0.dll
api-ms-win-crt-math-l1-1-0.dll

Just stumbled upon this problem myself. Does anyone have any updates on this issue?


include tf.global_variables_initializer() in the demo

Perhaps users will all know this, but there needs to be
init_op = tf.global_variables_initializer()
and then
sess.run(init_op)
to get things to work. Perhaps these could be added to the demo code

Good call. I will update this shortly.


Bump Scala

This PR bumps Scala version as well as improving speed of tests (turns out we don't need to fork). Also added @Deeds67 as a developer plus removed depreciation message with  "-opt-inline-from:<sources>".
The PR saves ~3-4 minutes off the build time

👍


"csrf" cause "post" action fail

tower used "csrf"
but the scaffold FORM coffeekup template doesn't include csrf fields which will cause a 403 error in any post action.

same problem here...the example app doesn't have any csrf fields in the forms either but seems to work...were is my mistake?


can not refresh waybar status.

I use arch linux, sway wm .
When I suspend the systemd and then wake it up, waybar can not refresh the status. Such as the data of CPU or Clock is keeping still all the time.

It's not even refreshing after 1-2 minutes?

Closed for inactivity


Feature: Restrict output to given severity level

With -o, I can restrict output to particular hints. I would like an analogous argument—maybe --severity —that restricts to a particular severity.
hlint --severity warning --> only shows errors and warnings (not suggestions)

Sounds sensible. We already have the appallingly named --show which sets the cutoff to ignore. I like the idea of generalising this, but I'm worried that people won't know the HLint severity levels, and thus they won't know how to use the flag. But if we can figure out a nice flag names/conventions then it would be great.


File explorer copying wsl symlink files infinite loop

Version
Microsoft Windows [版本 10.0.22621.674]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 20.04
Other Software
No response
Repro Steps

wsl cmds:

mkdir ~/test
cd ~/test
echo "abcd" > test.txt
ln -sf test.txt test-symlink.txt

open file explorer and locate to ~/test in wsl
select test-symlink.txt file
press Ctrl-c and Ctrl-v

Warn!! These steps causes a circular copy of the file, which can only be stopped by restarting the explorer.exe process.
Expected Behavior
Only one copy of the file.
Actual Behavior
infinite loop
Diagnostic Logs
No response

Thanks for the report, I can reproduce this locally. I'll look into it.

Had this happen just now. Note to self incase I can fix.

Can confirm this still happens