Segfault on dgemm_oncopy_HASWELL triggered by numpy.matmul (v0.3.13.dev)

Hey, I'm still seeing segfaults when doing numpy.matmul with two big matrices (numpy v1.20.1, OpenBLAS v0.3.13.dev).
This looks like potentially related to #2728 ?
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007fd34c490fa3, pid=1, tid=0x00007fd34f134740
#
# JRE version: OpenJDK Runtime Environment (8.0_242-b08) (build 1.8.0_242-b08)
# Java VM: OpenJDK 64-Bit Server VM (25.242-b08 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# C  [libopenblasp-r0-5bebc122.3.13.dev.so+0xe77fa3]  dgemm_oncopy_HASWELL+0x193

The stacktrace points to a line where it does sth. like np.matmul(samples, samples.T).
I was running the code in a docker container (enterprise environment), where NumPy was installed using pip.
Here's the spec of the compute cluster, from which 6 CPUs were allocated to the container.

threadpool_info via threadpoolctl shows the following, which confirms it was OpenBLAS v0.3.13.dev and that num_threads was correctly recognized to be 6.
[{'filepath': '/job/.local/lib/python3.7/site-packages/numpy.libs/libopenblasp-r0-5bebc122.3.13.dev.so',
  'internal_api': 'openblas',
  'num_threads': 6,
  'prefix': 'libopenblas',
  'threading_layer': 'pthreads',
  'user_api': 'blas',
  'version': '0.3.13.dev'},
 {'filepath': '/job/.local/lib/python3.7/site-packages/torch/lib/libgomp-7c85b1e2.so.1',
  'internal_api': 'openmp',
  'num_threads': 6,
  'prefix': 'libgomp',
  'user_api': 'openmp',
  'version': None},
 {'filepath': '/job/.local/lib/python3.7/site-packages/scipy.libs/libopenblasp-r0-085ca80a.3.9.so',
  'internal_api': 'openblas',
  'num_threads': 6,
  'prefix': 'libopenblas',
  'threading_layer': 'pthreads',
  'user_api': 'blas',
  'version': '0.3.9'}]

Let me know if you need any other information!

As it turns out, it's not as straightforward for me to change the JRE setting as the docker container is set up and maintained by others (and then provided to users like me as a compute platform).
Just for my understanding though - why should JRE settings (like stacksize) even be relevant in this case?
To clarify, the code in question doesn't involve Java at all, and after I enabled faulthandler, this became what I saw
Fatal Python error: Segmentation fault

Current thread 0x00007f38d45fe740 (most recent call first):
  ...                           # Followed by the normal Python stack trace

and JRE no longer showed up in the log.
Maybe JRE is a red herring? I mean, it might well be that the segfault happened in Python first, and, with Python faulthandler disabled, JRE was just the first to "catch" it and log it?

Maybe, maybe not. Why does the JRE feature in your context at all, are you perhaps loading java-based libraries like libhdfs ? (#2821) ?

Ah I get what you say. We do use fastparquet to load parquet files from HDFS! And as a temporary workaround, I've set OPENBLAS_NUM_THREADS to 1 for now.
I'll look into this a bit further and post updates.

Can you confirm OPENBLAS_NUM_THREADS=1 do fix the problem 100% ?

It seems to be working so far, although I haven't got the time to isolate the issue into a minimal reproducible case to really test it.

Hi, I've managed to reproduce this issue as shown in this gist.
I was running it inside a docker container of the same spec as above (i.e. 6 CPUs and 16 GB memory), and can consistently reproduce the results there, i.e. NO SEGFAULT only when OPENBLAS_NUM_THREADS is set to 1, and SEGFAULT otherwise.

Computation takes little bit more than 16GB with threads. Docker thin-provisions memory while SGEMM will  certainly use all of it.

Good point, although I increased memory to 64 GB to no avail.
I noticed memory peaked at just above 16GB with the default Java stack size, and increased to 22GB when I bumped the stack size to 8M.
Another thing I noticed - the SEGFAULT actually only happens about 80-90% of the time, and increasing the stack size seems to bring down the frequency by a little bit, albeit not entirely.

Btw, when OPENBLAS_NUM_THREADS is set to 1 and the computation goes out of memory on a larger input matrix, it's a normal OOM error and I don't see a SEGFAULT.

Please update numpy to the level openblas versions match. I cannot repeat with pure 0.3.13 at all besides clearly OOM with 16GB RAM.
Could you update numpy (pip install --update --user numpy) so that openblas library versions match? Internals are not portable, it may call some locking function that does unexpected unintentionally.

But in all my cases, NumPy is already at its latest version (i.e. v1.20.1) installed from scratch using pip.

I cannot reproduce this problem (without docker/jre in the mix) so far. I do note however that the numpy-provided openblas binary gets built with a smaller GEMM buffersize than the usual default to limit memory requirements on big multi-core hardware - which may cause similar segfaults when the matrix size gets "too" big.

NumPy is already at its latest version (i.e. v1.20.1)

This looks dated {'filepath': '/job/.local/lib/python3.7/site-packages/scipy.libs/libopenblasp-r0-085ca80a.3.9.so',

@brada4 That's SciPy, not NumPy. That said, it did look fishy to me at first and that's why I enabled faulthandler to capture exactly where the segfault originated, and as it turned out it was numpy.matmul (hence nothing to do with SciPy).
If you check the above minimal example I shared in the gist, you'll see there's no longer SciPy involved, and yet the segfault still happens.

@martin-frbg Thanks that's interesting. Let me test the example without JRE or docker on my side and see what happens. Will update.

Indeed I can only reproduce this issue when running it inside the docker container provided to me, which has things like JDK and Hadoop installed by default (and I cannot circumvent it).
On my laptop, the above minimal example in the gist I shared works just fine.
To add to the trickiness, the stack traceback from faulthandler isn't very helpful either, as it only shows things up until they leave Python.
So I don't know if there's more info I can provide at this stage to help with the debugging.
Feel free to close the issue. And thank you both for taking a look!

Fault handler might be right that crash is in "new" library, but there might be sgemm_ or cblas_sgemm from the other library.
While numpy.dual is not explicitly selectable anymore, would be worth checking. If you have interactive console, just rename the 0.3.9 to something not ending in .so , and copy 0.3.13 over, maybe it cures magically.


Redesign: Update layer style panel

Context
This updates the layer style panel to use the generalized numeric input component. Along with some updates to said component.
User-facing changes

Before
After

Testing Instructions
QA
This PR can be tested by following these steps:

Add any element to a page
Observe the layer panel to adjust the layer opacity

UAT

[x] UAT should use the same steps as above.

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #6469

@miina, I know we talked about this bug with the focus border slightly hidden, but I think we should just close this one and fix in a followup when all P1 panels are in. Currently we're solving the same things in different ways all over the place, so I think we better fix it at the end when we know all the combinations:

I've filed a "closing" ticket for this: #6624


Issue when using uglifyjs in prod

When using UglifyJs in webpack i recieve the following error message:
ERROR in main.bcef97c51ee8a9942d5e.bundle.js from UglifyJs
Unexpected token: name (TinderCardDirective) [main.bcef97c51ee8a9942d5e.bundle.js:47943,6]

Any idea how to solve this issue. As the resultant js is not minified
Thanks in advance

Same here...


Add columns for sorting by last MTSS, NGE and 10GE on school overview, homeroom and section

Who is this PR for?
high school teachers, JR and other NGE teachers in particular
What problem does this PR fix?
short-term fix for not being able to find which students have recently had NGE notes.
What does this PR do?
Updates the school overview page, homeroom page and section page to add columns for last MTSS meeting, and in the high school last NGE meeting and 10GE meeting.  Per JR, they don't use MTSS at the high school but do still have SST.  This also reorders the columns to put house and counselor and homeroom on-screen.
In the process, a test bug surfaced where the students created by TestPals don't have an enrollment_status set, so this fixes that as well.
Screenshot (if adding a client-side feature)
Overview
before, HS:

after, HS:

before, K8:

after, K8:

Homeroom
before, HS:

after, HS:

before, K8:

after, K8:

Section
before, HS:

after, HS:

Checklists

[x] Author checked latest in IE - School Overview
[x] Author checked latest in IE - Homeroom Page
[x] Author checked latest in IE - Section Page
[ ] Reviewer checked latest in IE - School Overview
[ ] Reviewer checked latest in IE - Homeroom Page
[ ] Reviewer checked latest in IE - Section Page
[x] Author improved specs for code in need of better test coverage
[x] Author included specs for new code

@alexsoble Can you help review this when you get a chance?  Ideally we'd ship this Thursday ahead of the 10GE meeting Friday morning.

hmm, I'm stumped on why the authorizer_spec is failing, and pushed some debugging comments here: https://github.com/studentinsights/studentinsights/pull/1482/commits/5fe28fc925e85ec5a1300f06d41c6d996a42e347.  I'll take another look at this Thursday.

@kevinrobinson Reviewing now! 😄

@kevinrobinson I dove into the failing TestPals homeroom expectation since that seems like the biggest pain point on the PR right now.
I got the spec to go green by removing this line from the reindex! method on TestPals:
Homeroom.destroy_empty_homerooms

What's happening is that when we reindex!, many of the homerooms don't have their students_count counter cache set properly, so our Ruby code thinks they're "empty" and deletes them. Here's a SO article about this kind of rspec/counter cache issue: https://stackoverflow.com/questions/12171067/rspec-testing-of-counter-cache-columns-returning-0
I tried adding Homeroom.all.each { |homeroom| homeroom.reload } to reindex!, but it didn't fix the spec. So I think the simplest way to get the spec to go green is to remove the destroy_homerooms line. None of these homerooms are really empty so our TestPals don't benefit from us removing that line, as far as I can tell.

@alexsoble awesome, thanks for the help!  I forgot I had added that, and there's no need for that particular line here so it's gone now. 👍

@kevinrobinson 😎 😎


Which version of goBGP should be used with SRv6-PI?

Can't find goBGP version 2.3.4 ?

Hi @beyond2002, there is a typo in our docs, the correct version is goBGP 2.34.0.
Thank you


Can't Download from fanfox

Bug report

Description
Data

OS
MacOS 10.14.5

Python version
3.7.3

Pip version
19.0.3

Manga-py version
<IP_ADDRESS>

URL
http://fanfox.net/manga/the_story_between_a_dumb_prefect_and_a_high_school_girl_with_an_inappropriate_skirt_length/

To Reproduce:
manga-py http://fanfox.net/manga/the_story_between_a_dumb_prefect_and_a_high_school_girl_with_an_inappropriate_skirt_length/
Additional context
File "/usr/local/lib/python3.7/site-packages/manga_py/crypt/init.py", line 2, in
from .base_lib import BaseLib
File "/usr/local/lib/python3.7/site-packages/manga_py/crypt/base_lib.py", line 8, in
from Crypto.Cipher import AES
File "/usr/local/lib/python3.7/site-packages/Crypto/Cipher/init.py", line 27, in
from Crypto.Cipher._mode_ecb import _create_ecb_cipher
File "/usr/local/lib/python3.7/site-packages/Crypto/Cipher/_mode_ecb.py", line 29, in
from Crypto.Util._raw_api import (load_pycryptodome_raw_lib,
File "/usr/local/lib/python3.7/site-packages/Crypto/Util/_raw_api.py", line 34, in
from Crypto.Util.py3compat import byte_string

Just got it working after fixing some permission issues after an OS upgrade.


⚠ Jenkins Plugins Artifactory has degraded performance

In 221afb8, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1126 ms

Resolved: Jenkins Plugins Artifactory performance has improved in cc28c78 after 23 minutes.


OriginsTweaks x ReOrigins

Hey, I've stumbled over your port of OriginsTweaks, and I like your changes to it.
So I wanted to ask if its fine with you if I bring those changes to OriginsTweaks?
If you'd like, I can also put a link to your Datapack in my Project desciption stating this as an official port to Quilt and Datapack.
Maybe we can also collaborate on future changes?
Send me an DM on Discord if you're interested! Chromex#9707

Hey, feel free to use any parts of this project (and the datapack version), I'm glad you like it.
You could link it but I can not promise that I will update it.
Currently it is pretty rare for me to Minecraft...

Alright, thanks!
I'll link your Mod in my project, so that anyone looking for a quilt or datapack version of this mod can find yours!


Add a query RPC to get the number of accounts

Summary
I home for a new query RPC to get the number of accounts on a chain.
Problem Definition
LINE Blockchain Explorer needs to know the number of accounts in order to show it on one of its pages.
Originally we planned to get the number using auth.Query.Accounts RPC with PageRequest.count_total = true, but it was found that such counting is too slow (almost 6 minutes in case of Ebony).
Etherscan has the same feature (counting addresses) and may be simply counting addresses which appear in blocks, but it's not very easy for LINE Blockchain Explorer to adopt the same design because:

In case of Ethereum, there is only one transaction format and Etherscan only needs to monitor 'from' and 'to'. (Probably only 'to' for account generation)
In case of Finschia, there are a lot of transaction messages and it's not easy for LINK Blockchain Explorer to know all address-related fields and to implement a feature to monitor all of them.

Proposal
Add a new query API to get the latest account number, which is incremental and equal to the current total number of accounts.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

@ryu1-sakai , do you know how to get the number of accounts on Etherscan?

There is not the account counting query api. And it is not easy adding this api in current structure.
Could you count the number of accounts like Etherscan?
In the current version, finschia-sdk v047.0 and finschia v1.0.0, the case to create new account is below. Please monitor it.

cosmos.vesting.v1beta1.Msg/CreateVestingAccount

to_address

cosmos.bank.v1beta1.Msg/MultiSend

outputs

cosmos.feegrant.v1beta1.Msg/GrantAllowance

grantee

cosmos.vesting.v1beta1.Msg/CreateVestingAccount

to_address

cosmwasm.wasm.v1.Msg/InstantiateContract

address of respons

cosmwasm.wasm.v1.Msg/InstantiateContract2

address of response

There is not the account counting query api. However, as we have discussed in other channels, you can estimate the number of accounts by latest account number. It is incremented when new account is created in chain. However the account number is also incremented when the smart contract is instantiated or when new module or new ibc register is added.
And now there is not the query api to query the account number. We can add it temporary for LINK Blockchain Explorer for temporary, but please be careful. This is no substitute for account count lookup. And this api will add deprecated annotation because it is temporary api.
Please update the function which count the accounts like Etherscan later.


Shorten the query for pre-loading VimPerformanceStates

This bug was introduced by https://github.com/ManageIQ/manageiq/pull/22579
I misread this code and thought it was fetching all records a single time.
Turns out it was never running this query N+1 times.
So adding the extra resource_id values (and a large count at that) to the queries just made the query longer / more verbose.
After
We are running the same number of queries, but the query length is half the number of characters. (think the bind variables are in addition to that)
Details
One fix would have been to add a load, which loads the association before the
preloader. Then the preloader does not add any additional values to the query.
Since that change depends upon
our preloader monkey patch, I opted for a different solution: https://github.com/ManageIQ/manageiq/pull/22594/commits/ac9f6ca616e5b61d0a20ad8556e2200e37339a06
The number of queries are the same, the index usage is the same, the number
of rows returned is the same for unchanged, load, and not specifying the resource
But the PR in question does double the size of the query string. I think the bind variables are in addition to that.
 The query becomes too unweildy.
I opted to change the code rather than rollback because I liked the extra comments
around the block of code.
In the future, we want to consolidate the caching of vim_performance_states
as we currently have 2 methods of caching those values:

preload that association
store in an @ variable.

Numbers

ms
query
qry ms
rows
 comments

4,808.1
19
2,736.4
1,334
 340-2023-06-22 20:00:00Z-long-1#before

130.2
1
130.2

. SELECT vim_performance_states.* -- [30991]

---:
---:
---:
---:
---

4,431.2
19
2,500.3
1,334
 340-2023-06-22 20:00:00Z-short-1#after

82.6
1
82.5

. SELECT vim_performance_states.* -- [15036]

---:
---:
---:
---:
---

4,659.0
19
2,690.4
1,334
 340-2023-06-22 20:00:00Z-load-1#alt

107.9
1
107.9

. SELECT vim_performance_states.* -- [15036]

alt being to use load instead of removing resource from the query
the number in brackets is the string length of the query

update:

went away from load
update:
changed commit comment
update:
removed spacing (rubocop)

is this effectively just a revert of https://github.com/ManageIQ/manageiq/commit/a0b6768f20f308c8f003195ab2b08baf99fffa54 ?

is this effectively just a revert of a0b6768 ?

that's what I'm seeing too.
% git diff 8a15fb6~ HEAD app/models/metric/rollup.rb
diff --git a/app/models/metric/rollup.rb b/app/models/metric/rollup.rb
index 55b21353b8..d95f9be13c 100644
--- a/app/models/metric/rollup.rb
+++ b/app/models/metric/rollup.rb
@@ -266,9 +266,14 @@ module Metric::Rollup
     new_perf
   end

+  # @param obj parent object
+  # @param timestamp [Time] for hourly, time is at the beginning of the hour
+  # @param interval_name  ["realtime", "hourly", "historical"]
+  # @param assoc [Symbol] name of the association to rollup
   def self.rollup_child_metrics(obj, timestamp, interval_name, assoc)
-    ts = timestamp.kind_of?(Time) ? timestamp.utc.iso8601 : timestamp
-    recs = obj.vim_performance_state_association(timestamp, assoc)
+    timestamp = Time.parse(timestamp).utc if timestamp.kind_of?(String)
+    ts = timestamp.utc.iso8601
+    recs = obj.vim_performance_state_association(timestamp, assoc).to_a

     result = {}
     counts = {}
@@ -282,11 +287,18 @@ module Metric::Rollup

     perf_recs = Metric::Finders.hash_by_capture_interval_name_and_timestamp(recs, ts, ts, interval_name)

-    # Preload states for perf timestamp and the current hour. We need to cache
-    #   the current hour too because the capture in vim_performance_state_for_ts,
-    #   if not found for the perf timestamp, will return a state for the current
-    #   hour only.
-    MiqPreloader.preload(recs, :vim_performance_states, VimPerformanceState.where(:timestamp => [ts, Metric::Helper.nearest_hourly_timestamp(Time.now.utc)])) unless recs.empty?
+    # Preload states for perf timestamp and the current hour.
+    #   in a single query bring back all relevant performance states
+    #   preload puts the states into rec's association where vim_performance_state_for_ts can find it
+    #
+    #   We are only concerned with the timestamp of interest.
+    #   For infra, if that record is not found, use the current performance_state (can't capture in the past)
+    if recs.present?
+      rec_states = VimPerformanceState.where(
+        :timestamp => [ts, Metric::Helper.nearest_hourly_timestamp(Time.now.utc)]
+      )
+      MiqPreloader.preload(recs, :vim_performance_states, rec_states)
+    end

     recs.each do |rec|
       perf = perf_recs.fetch_path(rec.class.base_class.name, rec.id, interval_name, ts)

yea, this is a revert. I just like the added comments.
ok, I'll revert

yea, this is a revert. I just like the added comments.
ok, I'll revert

Yeah, can you put that in the beginning of the PR description and the top of the commit message?   We want to make it obvious it's basically a revert with with some local variables changed and comments.

update:

do a revert
add a quick comment

End result should be similar
git history is different

Backported to petrosian in commit f2772ce172687bfb2284499dd8b6180d2aecba86.
commit f2772ce172687bfb2284499dd8b6180d2aecba86
Author: Jason Frey<EMAIL_ADDRESS>Date:   Fri Aug 11 11:45:06 2023 -0400

    Merge pull request #22648 from kbrock/vim_performance_state_preload

    Shorten the query for pre-loading VimPerformanceStates

    (cherry picked from commit 98c8e85d45a873510956df442be5b37169e2735c)


labextension/package.json for 1.0.0 still contains version 0.4.1

Describe the bug
I noticed that Jupyterlab was reporting a version of 0.4.1 for the jupyter-fs extension when pip install jupyter-fs==1.0.0 clearly installed version 1.0.0.
Looking at /opt/conda/lib/python3.11/site-packages/jupyterfs/labextension/package.json shows why that is:
{
  "name": "jupyter-fs",
  "version": "0.4.1",
  "description": "A Filesystem-like mult-contents manager backend for Jupyter",
  "author": "The jupyter-fs authors",

[...]

Obviously this also affects the config file at
~/.jupyter/lab/user-settings/jupyter-fs/plugin.jupyterlab-settings and the writtenVersion
To Reproduce
Steps to reproduce the behavior:

pip install jupyter-fs==1.0.0
Start JupyterLab
Look at list of installed extensions in Extension Manager
See error

@timkpaine was this not a valid bug report? Or is this already fixed somehow?
I saw that there is PR https://github.com/jpmorganchase/jupyter-fs/pull/204

@frittentheke not a code problem, the sdist is fine so I did a post release on the wheel which you can use.


[Feature Request]: Configuration option for compression threshold to trigger PR

First things first, thank you for creating and sharing a magnificent development tool, I'm severely chagrined to have waited to say that until I also wished to prevail on you for an expanded feature set; my mother raised me better than that.
Nevertheless, I was curious if you had ever entertained giving users the option to set an explicit threshold for aggregate file size reduction for a PR to be sent? Put more plainly, I'd love to be able to set a precise value of kibibytes/mebibytes or a fractional amount of the total repository size that ImgBot would have to meet or exceed in compressing the contents before issuing a pull request.
I encountered a scenario recently where a confluence of the efforts of ImgBot and Restyled.io led to a "Groundhog Day-esque" scenario of duplicated PRs. As best I could determine, Restyled.io took umbrage at ImgBot failing to leave a trailing new line in the SVG files it compressed (a mildly compelling argument, at least to me...we shouldn't behave like wild animals in the pursuit of bandwidth/storage optimization, right? :wink:) Anyhow, after absent-mindedly nodding my assent and merging Restyled's PR, I barely had time to sneeze and find a facial tissue before sitting back down at my desk to see that ImgBot had already opened another PR for all of those SVG files, despite the compression achieved amounting to exactly one fewer line per file or <0.01%. *shaking his fist in the air at being kicked in the backside by his fondness for configuring systems to manage everything*
Now I'll beat you to the punch here and concur that the more effective, dignified and appropriate remedy is to grab a spanner and a torch and crank away on Restyled's innards such that it learns not to molest anymore SVG files. I'll be doing so promptly at the conclusion of this missive, to be sure, and perhaps I'll be pleasantly surprised by how self-evident the method is for doing so. All the same, Restyled is a lexical parser, you and I both know that having my hands up its skirt will be a thoroughly gruesome affair compared to doing the same with an algorithmic sorceress of graphics like ImgBot. *sighs* That's Life by Sinatra just came on the radio, I guess that's curtains for me here.
Again, thank you for sharing ImgBot with me and I hope this late-night folly of a feature request wasn't too much torture to read. Keep on keepin' on; life's a garden, dig it? :roll_eyes:
...
:grin:
Warmly,
Peter

Hi Peter 👋
This is a great idea! I am totally on board.
Here is some details of how I think it could be implemented, let me know what you think.
Right after we optimize the images we check to see what the total differential was
something like: var totalSaved = optimizedImages.Sum(x => x.SizeBefore - x.SizeAfter)
If there is a repo config setting set we compare and if it is not met then we bail out and do nothing.
something like: if (repoConfiguration.MinKBReduced > totalSaved) return false
How do you feel about the name "minKBReduced"?
// .imgbotconfig
{
  "minKBReduced": 25
}

It feels pretty spammy to send PRs for something less than 1 KB saved anyways, maybe we should set a default for this setting too?
Also we should update the docs along with this change:
https://github.com/dabutvin/Imgbot/blob/master/Docs/configuration.md
https://github.com/dabutvin/Imgbot/blob/master/README.md
https://github.com/dabutvin/Imgbot/blob/master/Docs/min-kb-reduced.md (new)

bump
I've got a small start on this already and really want to get it in

PR open to take care of this #624

This is now available to use in your repos with the .imgbotconfig file.
{
  "minKBReduced": 500
}

See https://imgbot.net/docs/#configuration
The default is set to 10KB


Fix google docs lists

Trello: https://trello.com/c/P5KBetGh/754-resolve-issues-identified-from-copy-and-paste-testing
See commits for details

Thanks for clarifying - I think I understand it enough to see that it works now :-). Just a few questions, which I don't think are blocking:

It looks like we depend on the indentation of the input HTML in order to do the actual nested. Is that right?

Nope, that's not the case. An input of the below still passes tests:
  const html = `

Parent

Child 1

Grand child 1

Grand child 2

Child 2

Child 3

Parent sibling

  `

I notice the conversion actually puts 3 spaces after the number/bullet marker, which is a bit weird and different to what our toolbar generates. But then I see it's also what the origin code does, so I'm guessing we're compromising here?

That's a good point, we were just dealing with that before but since I've hijacked the listItem markup I can update that to match what we have (hopefully) - I'll give that a whirl.

@benthorner I've set the spacing up now.

👍


Proposal: Add method Clone on All RUD

I mean if i set by default my predicate and i want to have a copy of this for my http handler in goroutines.
we have a method Clone on schema_query. Add method Clone for schema_delete and schema_update. No for schema_create

Hey @deyforyou and thanks for proposing this API.
I'm not sure I get the use case - you want to avoid copying the code that applying the predicate on the builders?
If you don't want to be blocked and want to add it to your project, use external templates to generate this functionality for you.

you want to avoid copying the code that applying the predicate on the builders?
Yes so if i work with a server i can set default predicate or value on the builders.
sorry for the delay

Imagine each builder have an http handler func.
e.g: For UserCreate I do my first request I set the field "Name" to "deyforyou" and my second request I dont set. the value will stay always "deyforyou".
But it works only if i clone UserCreate in the handler func.

The reason we added the Clone method to the query builder was because it's possible to chain multiple builders as follows -  e.QueryGroups().QueryPosts()...Clone(). We found many cases that it's useful and reduced our code duplication. However, if we want to share the same setters for create/update builders we use ent.Mutation. Or, in cases like yours, we do stuff like this:
func f() {
	// ...
	c1, c2 := baseUser(), baseUser()
	go saveUser(ctx, c1, "a8m")
	go saveUser(ctx, c2, "deyforyou")
}

func saveUser(ctx context.Context, c *ent.UserCreate, name string) {
	c.SetName(name).SaveX(ctx)
}

func baseUser() *ent.UserCreate {
	return client.User.Create().SetX(x).SetY(y).SetZ(z) // more setters.
}

Like I mentioned above, if you're blocked on this, you can use external templates to add it to your project. But, I don't want to add it to the default codegen since this will make the generated code bigger for something that I didn't find (yet) super necessary and can be replaced with a few lines of code.
Thanks. Please let me know if you decided to use external templates and you need help with that.

Thank you. You are kind

And I use well external templates. But if you want to help me. it will be wonderful

And I use well external templates. But if you want to help me. it will be wonderful

Sure thing, any specific issue? Did you start it already, or do you need help with writing the first template?
My suggestion is to start with adding a Clone method to the <T>Mutation object, and then, add another Clone method to the <T>Create/Update builder that will call the mutation clone method. Does it make sense?

I have already start. And I see now my error. But your suggestion is also good


Updated readme for users to invite Lookerbot

Added a line to the readme for users to make sure they invited the Lookerbot to the channel they are posting to.

Thanks!


fix: remove unused var

Try out this version of the Hiro Wallet - download extension builds.

Removes unused variable causing CI to fail for new PRs.

Oops, didn't mean delete the entire file here, haha. I just meant the one test for creating an account in the settings menu and the selector. Sorry for miscommunication. I will add back in my PR before I merge it.


How to train brain.js multiple times?

If I already trained my neural network once, how could I add more information( ''train'' more stuff) to it, without having to train everything(old knowledge + new information) again?
Actually found a way: https://stackoverflow.com/questions/51295463/training-brain-js-multiple-times

Woot woot!


Daily Average Overview

Check this out:

It's from https://github.com/henrywhitaker3/Speedtest-Tracker . Would be nice if this speed-tracker had something like that too. Just the Average from the last 24 hours to post on Telegram channel or via mail.

As my connection is highly volatile (T-DSL Hybrid, DSL+LTE aggreated with QOS for shared medium LTE) it would be cool to see the average also in the daily / weekly / monthly  graphs - because in the end I'm only interested if I get about what I paid vor (e.g. >= 100 MBit/s on average) - adding as feature or enhancemend request here.


sys/auth endpoints are not exposed

Currently the extension allows for managing secret engines but not auth methods. This functionality should be included to ensure users are able to completely management Vault instances via the extension.
Vault API docs: https://developer.hashicorp.com/vault/api-docs/system/auth

Fixed in #215


Add test case for removal of has-one polymorphic relationship with PATCH

This PR adds a failing test case for the issue in #1081
EDIT: For a fix suggestion, see PR #1083 that renders this PR obsolete.

This has been outdated for some time, and I don't know where I should add this test to. I'm gonna close this PR as it never got any attention, and I don't have time now to create another PR unless https://github.com/cerebris/jsonapi-resources/issues/1081 gets some attention.


7.0.0 beta1 -> master

already merged from another source branch

already merged from another source branch


Add FlagD to Snap

https://snapcraft.io/flagd

This is done, however we need some automation for builds


fix broken names

Description
remove no-braking space at beginning of name
Issues Resolved
[List any existing issues this PR resolves]
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] New functionality has been documented in CHANGELOG.MD

          1 Error

:no_entry_sign:
Please add a changelog

          1 Warning

:warning:
Should this include readme changes

  Generated by :no_entry_sign: Danger


Color enums

Zig does not appear to offer implicit conversion from enums to their underlying types. I've run into this issue as converting a u32 into an enum explicitly doesn't allow for values that aren't defined as values set in the enum, which becomes a problem when setting custom RGB colors.
Do you think a good solution would just be to change all color functions to use u32 as well (or offer enum-specific functions)? I've noticed as it is currently, it's a mixture of both

Hi
At some point Color was defind as:
pub const Color = enum(u32)

This was changed to a struct.
I had planned to add methods to it which would accept RGB values. These could then be used with widget methods taking Color.
I didn't get yet to refactoring the rest of the code.
As to my preference, I would prefer to stick with a Color struct, since the FLTK color representation (RGBI) is a bit unintuitive.

I've pushed a proof of concept. The changes might be a lot, but it's to make zfltk build with latest zig.


Do i have to make an action if i only use this client

Hi,
i'm using the V2.2.3 and i'm wondering if i have to update something in my code due to the new update of the Cloud Storage API (adding storage.googleapis.com).
Thanks.

So far as I'm aware, there haven't been any breaking changes in the API. Can you be a bit more specific about what you're asking? Do you have a code sample?

To be more specific, i'm using the client in a Symfony application in order to interact with Cloud Storage (downloading and uploading through gaufrette and VichUploader libraries).
The integration with Gaufrette looks like this :
<?php

namespace AppBundle\Factory;
use Google_Service_Storage;

class GoogleCloudStorageServiceFactory {

    public function createService() {
        // creating the google client
        $client = new \Google_Client();

        // setting the service account credentials
        $client->setAuthConfig('path_to_json_file');
        $client->setScopes([Google_Service_Storage::DEVSTORAGE_READ_WRITE]);
        // creating and returning the service
        return new \Google_Service_Storage($client);
    }

}

services.yml
app.google_cloud_storage.service:
    class: \Google_Service_Storage
    factory: [AppBundle\Factory\GoogleCloudStorageServiceFactory, createService]

knp_gaufrette:
    stream_wrapper: ~
    adapters:
        gcs_images:
            google_cloud_storage:
                service_id: 'app.google_cloud_storage.service'
                bucket_name: 'images'
filesystems:
    gcs_images_fs:
        adapter: gcs_images

vich_uploader:
    db_driver: orm
    storage: gaufrette
    mappings:
        motors_files:
            upload_destination: gcs_images_fs
            namer: vich_uploader.namer_origname

For downloading files without the help of gaufrette, i'm doing something like this :
<?php

namespace MyFM\WebPortalBundle\Service;

use GuzzleHttp\Psr7\Request;

class GoogleCloudStorageDownloader
{
    /** @var  \Google_Service_Storage */
    private $storageService;

    /**
     * @param \Google_Service_Storage $storageService
     */
    public function setStorageService($storageService)
    {
        $this->storageService = $storageService;
    }

    public function download($source, $fileName, $destination)
    {
        $file = $this->storageService->objects->get('bucket_name', 'path_to_file_in_bucket');

        $request = new Request('GET', $file['mediaLink']);
        $client = $this->storageService->getClient();
        $response = $client->authorize()->send($request);
        file_put_contents('path_to_file_where_to_put_file_content', $response->getBody());
    }
}

I'm wondering if there something to change due to the upcoming update in the API.
Thanks for you answer in advance.

To be more specific, i'm using the client in a Symfony application in order to interact with Cloud Storage (downloading and uploading through gaufrette and VichUploader libraries).
The integration with Gaufrette looks like this :
<?php

namespace AppBundle\Factory;
use Google_Service_Storage;

class GoogleCloudStorageServiceFactory {

    public function createService() {
        // creating the google client
        $client = new \Google_Client();

        // setting the service account credentials
        $client->setAuthConfig('path_to_json_file');
        $client->setScopes([Google_Service_Storage::DEVSTORAGE_READ_WRITE]);
        // creating and returning the service
        return new \Google_Service_Storage($client);
    }

}

services.yml
app.google_cloud_storage.service:
    class: \Google_Service_Storage
    factory: [AppBundle\Factory\GoogleCloudStorageServiceFactory, createService]

knp_gaufrette:
    stream_wrapper: ~
    adapters:
        gcs_images:
            google_cloud_storage:
                service_id: 'app.google_cloud_storage.service'
                bucket_name: 'images'
filesystems:
    gcs_images_fs:
        adapter: gcs_images

vich_uploader:
    db_driver: orm
    storage: gaufrette
    mappings:
        motors_files:
            upload_destination: gcs_images_fs
            namer: vich_uploader.namer_origname

For downloading files without the help of gaufrette, i'm doing something like this :
<?php

namespace AppBundle\Service;

use GuzzleHttp\Psr7\Request;

class GoogleCloudStorageDownloader
{
    /** @var  \Google_Service_Storage */
    private $storageService;

    /**
     * @param \Google_Service_Storage $storageService
     */
    public function setStorageService($storageService)
    {
        $this->storageService = $storageService;
    }

    public function download($source, $fileName, $destination)
    {
        $file = $this->storageService->objects->get('bucket_name', 'path_to_file_in_bucket');

        $request = new Request('GET', $file['mediaLink']);
        $client = $this->storageService->getClient();
        $response = $client->authorize()->send($request);
        file_put_contents('path_to_file_where_to_put_file_content', $response->getBody());
    }
}

I'm wondering if there something to change due to the upcoming update in the API.
Thanks for you answer in advance.

Nothing that I am aware of. You may however find that google/cloud-storage is easier and more intuitive to use than Google_Service_Storage. Since it's handwritten, we also take care of a lot of the complexity and changes in the underlying service.

Thank you for the prompt answer and guidance to the mentioned library.

Glad to help! Let us know if you have any other questions.


Wrap sncosmo models

Import the sncosmo model's library and wrap the models in a PhysicalModel. This is less efficient  because of the layer of indirection, however it provides flexibility while we port over essential models to be native PhysicalModels. The long term plan will be to port over all needed models so there is not a direct dependency.

That makes sense. I changed it over to Source can you take another look?


Build the unit test targets without immediately running them

Is your feature request related to a problem? Please describe.
We would like to integrate cups unit tests into our repository. However, unit test targets do not only build tests but also run them. This is not very convenient as we would also like to use cross-compilation and to run test executables on different architectures.
Describe the solution you'd like
Provide a way to build and run unit test targets separately. For instance, we can have an additional variable to switch launching tests immediately after building them.
Describe alternatives you've considered
None
Additional context
None

Hi @NedoL98 ,
that's a good idea, I wanted something like this some time ago when I enabled CI tests for CUPS in our distributions (right now we create symlinks and trigger the build which is not ideal), but I haven't had time to implement it yet.
Ack from my POV.

This is already done in the libcups (v3) repository, shouldn't be too hard to adapt to the CUPS 2.x repo.

Will do this for CUPS 2.5.

I guess the main part of this commit implements this issue - https://github.com/OpenPrinting/cups/commit/b1d42061 .

Looks like some parts are still run during 'make unittests' - testcgi, testhi, testmime.

[master 61a9e419e] Final cleanup for 'make unittests' to be separate from 'make test' (Issue #612)


Rework JsonNumber [WIP]

This is a work-in-progress PR that aims to use the fact that jawn 0.11 can now work with CharSequence values instead of strings, which means that for number parsing we don't need to instantiate additional strings in many situations.
Decoding into most numeric types is currently significantly faster (like 60% more throughput for decodeDouble in the new number parsing benchmark, and 11% more for decodeLong), but in some situations parsing is slower, since we no longer create lazily parsed JsonNumber instances from known valid JSON number strings. This is because we want to avoid instantiating strings for every number whenever we can.
I'm not sure I'm entirely happy about this trade-off, and I'm still experimenting with different options here.

Codecov Report

Merging #697 into master will increase coverage by 0.73%.
The diff coverage is 97.6%.

@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
+ Coverage   86.29%   87.02%   +0.73%
==========================================
  Files          71       72       +1
  Lines        2203     2336     +133
  Branches       94      104      +10
==========================================
+ Hits         1901     2033     +132
- Misses        302      303       +1

Impacted Files
Coverage Δ

...ain/scala/io/circe/literal/JsonLiteralMacros.scala
92.45% <ø> (-0.41%)
:arrow_down:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
89% <33.33%> (-8.03%)
:arrow_down:

.../main/scala/io/circe/jawn/CirceSupportParser.scala
94% <90.9%> (-2.88%)
:arrow_down:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
96.38% <94.73%> (+4.03%)
:arrow_up:

...main/scala/io/circe/numbers/JsonNumberParser.scala
99.51% <99.51%> (ø)

...re/shared/src/main/scala/io/circe/KeyDecoder.scala
97.29% <0%> (-2.71%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/Decoder.scala
91% <0%> (+0.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e17272...39e0976. Read the comment docs.

Closed due to age.
Please notify maintainers if this is done in error.


tuple error

Using: python3 japonicus.py -b --strat PPO -w
Tuple error on Step 2 section of evolution_bayes.py at:
DateRange = gekkoWrapper.getDateRange(chosenRange, deltaDays=settings['testDays'])
I know little to nothing about phython but was able to get past it by updating the getDateRange function in gekko.py to use:
Limits[1]['to'] instead of Limits['to']

This specific error is due to a bug that i just fixed. Your modification should break the GA workings...
Remember that genetic algorithm and bayes optimization (more prone) tends to overfit on tested candles... good results on real world will only come if your strategy already rocks ;d


Cleanup search index when a namespace is deleted.

Delete namespace cleanup search index, under that specific namespace
example:
create a namespace
$ kubectl create namespace development

Create a deployment with below yaml
apiVersion: apps/v1beta1 # for versions before 1.6.0 use extensions/v1beta1
kind: Deployment
metadata:
  name: nginx-deployment
  namespace: development
spec:
  replicas: 3
  template:
    metadata:
      labels:
        app: nginx
    spec:
      containers:
      - name: nginx
        image: nginx:1.7.9
        ports:
        - containerPort: 80

Then search /search?q=development gives search result associates with word development.
After delete development namespace /search?q=development show empty search result

Was already working


Prevent tuple related issues with traits and concept

Some situations made compilers try to compute traits too eagerly, leading to errors.
Some traits forced the requirements that UDT be literal while this is not necessarily enforceable.

Tests please


fix: pypy

WIP: still has debug CI changes & a few extra unneeded changes. Also using a branch of scikit-build.

This is just the FindPython changes now + main scikit-build. Can you see if it builds?

This repo has jarowinkler has dependency which has the same build issues. Could you create the PR over there: https://github.com/maxbachmann/JaroWinkler?
It has the same project structure and only a single module, so it should be relatively simple to apply the changes there

This makes the CI finish a lot faster as well :)

It looks like this is the same I already applied here: https://github.com/maxbachmann/JaroWinkler/pull/11/
which did find PyPy, but failed to name + install the so file.

wow first time seeing this failure https://github.com/maxbachmann/RapidFuzz/actions/runs/3100994873/jobs/5022090041 not quite sure what went wrong there ...

I am currently pretty strict with the versions, since the last releases often broke things and I release new versions more regularly than scikit-build. However allowing further patch releases should be fine. This needs the same change in tools/sdist.patch to work.


make failed  libtool: line 848: cc: command not found

on Solaris 11 make failed
uname -a
SunOS 5.11 11.3 sun4v sparc sun4v
./autogen.sh
/usr/share/aclocal/aalib.m4:12: warning: underquoted definition of AM_PATH_AALIB
/usr/share/aclocal/aalib.m4:12:   run info '(automake)Extending aclocal'
/usr/share/aclocal/aalib.m4:12:   or see http://www.gnu.org/software/automake/manual/automake.html#Extending-aclocal
configure.ac:8: installing ./install-sh' configure.ac:8: installing ./missing
./configure --with-apache=/opt/IBMIHS/bin/httpd --with-apxs=/opt/IBMIHS/bin/apxs --with-libmodsecurity=/usr/local/modsecurity
checking for a BSD-compatible install... /usr/bin/ginstall -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/gmkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
configure: looking for Apache module support via DSO through APXS
configure: found APXS at /opt/IBMIHS/bin/apxs
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... none
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /usr/bin/ggrep
checking for egrep... /usr/bin/ggrep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
configure: looking for libmodsecurity
checking for msc_init in -lmodsecurity... yes
checking modsecurity/modsecurity.h usability... yes
checking modsecurity/modsecurity.h presence... yes
checking for modsecurity/modsecurity.h... yes
checking if apache is wanted... yes
expr: syntax error
expr: syntax error
checking apache modules... in /opt/IBMIHS/modules
checking for perl... /usr/bin/perl
Loaded Modules:
core_module (static)
mpm_worker_module (static)
http_module (static)
suexec_module (static)
so_module (static)
authz_host_module (shared)
auth_basic_module (shared)
authn_file_module (shared)
authz_user_module (shared)
include_module (shared)
log_config_module (shared)
env_module (shared)
expires_module (shared)
headers_module (shared)
unique_id_module (shared)
setenvif_module (shared)
proxy_module (shared)
proxy_http_module (shared)
mime_module (shared)
autoindex_module (shared)
asis_module (shared)
info_module (shared)
cgid_module (shared)
dir_module (shared)
actions_module (shared)
alias_module (shared)
rewrite_module (shared)
status_module (shared)
mpmstats_module (shared)
backtrace_module (shared)
whatkilledus_module (shared)
Syntax OK
Loaded Modules:
core_module (static)
mpm_worker_module (static)
http_module (static)
suexec_module (static)
so_module (static)
authz_host_module (shared)
auth_basic_module (shared)
authn_file_module (shared)
authz_user_module (shared)
include_module (shared)
log_config_module (shared)
env_module (shared)
expires_module (shared)
headers_module (shared)
unique_id_module (shared)
setenvif_module (shared)
proxy_module (shared)
proxy_http_module (shared)
mime_module (shared)
autoindex_module (shared)
asis_module (shared)
info_module (shared)
cgid_module (shared)
dir_module (shared)
actions_module (shared)
alias_module (shared)
rewrite_module (shared)
status_module (shared)
mpmstats_module (shared)
backtrace_module (shared)
whatkilledus_module (shared)
Syntax OK
Found Apache with MPM Worker, .
./configure[4396]: [: argument expected
./configure[4399]: [: argument expected
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) none
configure: creating ./config.status
config.status: creating Makefile
config.status: creating build/apxs-wrapper
config.status: creating tests/regression/server_root/conf/httpd.conf
config.status: creating tests/regression/misc/40-secRemoteRules.t
config.status: creating tests/regression/misc/60-pmfromfile-external.t
config.status: creating tests/regression/misc/50-ipmatchfromfile-external.t
config.status: creating tests/run-regression-tests.pl
config.status: executing depfiles commands
make
chmod +x build/apxs-wrapper
build/apxs-wrapper
/opt/IBMIHS/build/libtool --silent --mode=compile cc -prefer-pic   -DSOLARIS2=10 -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT -D_LARGEFILE64_SOURCE -g -I/opt/IBMIHS/include  -I/opt/IBMIHS/include   -I/opt/IBMIHS/include   -fPIC -O0 -I/usr/local/modsecurity/include/  -c -o src/mod_security3.lo src/mod_security3.c && touch src/mod_security3.slo
/opt/IBMIHS/build/libtool: line 848: cc: command not found
apxs:Error: Command failed with rc=65536
.
*** Error code 1
make: Fatal error: Command failed for target `all'

I think your issue might be related with https://github.com/SpiderLabs/ModSecurity-apache/issues/60. Seems like the scripts are failing to find your compiler. Can you check if you get better results with LLVM instead of GCC?

Closing due to lack of feedback from reporter. If the issue persists, let us know. Thanks!


[Bug]: No longer able to add LN node peer

Describe the bug
It used to be possible to QR Scan or paste a LN node connection string in the format nodeId@ip:port into Bitkit to ass a new peer. Now this triggers the Manual Setup flow for a Lightning connection.
I don't think there is an other way to add a lightning peer. If there isn't, perhaps it should be added in a menu.
Reproduce

Go to https://lnbig.com
Scan one of the QR codes
Observe Manual Setup flow
If you want to simply add a peer, there is no option.

Screenshots / Recording
No response
Operating system
Android 14
Bitkit version
1.0.5 (136)
Log output
No response

@Jasonvdb?

For simply adding a peer you can use the debug feature by navigating to DevSettings -> LDK.

I missed that. Ok, we can close this.


Run in serverless environment

Is your feature request related to a problem? Please describe.
I would like to run pwa-asset-generator in a serverless environment. IIRC the current code does download the desired Chrome revision at run time. In order to work in a serverless environment the Chrome binary needs to be provided at build time.
Right now I get the following error message when trying to execute it on a AWS lambda (Vercel):
WARN	11:06:09 AM installer Chromium is not found in module folder, gonna have to download r818858 for you once 🤔
[Error: EROFS: read-only file system, mkdir '/var/task/node_modules/puppeteer-core/.local-chromium'] {
  errno: -30,
  code: 'EROFS',
  syscall: 'mkdir',
  path: '/var/task/node_modules/puppeteer-core/.local-chromium'
}

Describe the solution you'd like
A way to provide the Chrome binary to the module without triggering the revision download:
import chrome from 'chrome-aws-lambda'

const launchOptions= {
  args: chrome.args,
  executablePath: await chrome.executablePath,
  headless: chrome.headless
}

await pwaAssetGenerator.generateImages(
  "https://raw.githubusercontent.com/onderceylan/pwa-asset-generator/HEAD/static/logo.png",
  "./tmp",
  {
    scrape: false,
    puppeteer: {
      launchOptions
    }
  }
)

Describe alternatives you've considered
An alternative would be to use chrome-aws-lambda directly in the module. I think this isn't an option because
of the built-in dynamic revision fetching.

Thanks for your request @damianfrizzi. It would be nice to have this capability, I haven't tested it on serverless functions yet. Let me have a look at this.

same problem for me in a serverless cloud function on Google Cloud:

Have you found a solution to this? I'm facing a similar issue running on Alpine and the revisions from puppeteer aren't compatible, the executablePath is hard-coded to point to one in node_modules/puppeteer I'm wondering if it would make sense to have an option for this

No, didnt find a solution so far. @michaeltintiuc


Batch deletion

Fixes #69.
Could be extended to batch access control changes.
Should improve time for creation of zarr datasets where previous contents need to be cleared.

Once more, the tests pass locally, but not on Travis...


rtcninja 2.0 timeline

Can you please give me rough timeline about when you plan to release rtcninja 2.0?
Are you planning to do some kind of beta to get community feedback?
Thanks!

Let's say it will be started in January (2016). Hopefully it won't take more than 5-6 weeks.
I will announce it here so users can test it (it will be part of a different branch). Thanks a lot for the help!


Allow for translation of Jasperreports through resouce bundle properties file

I am looking into the ability to produce jasperreports in different languages using the same template. Having looked a little into the capabilities I understand that this is done using ResourceBundles and using the REPORT_LOCAL property. Within the archi source base I already do find an attempt to set this property, but it seems to be unfinished work. If I am not mistaken the real challenge is that the locale must be set at compile time to use the R() feature of jasper. So that would be setting the locale based on a new dialog value in the createJasperPrint routine. The other challenge I had sofar is the path of the resource file - I would like to see that file next to the .jrxml files, such that with a customized report I could add my own labels for translation. Using the default locale I have not been able to load such a localization.properties and localization_en_US.properties file in a report for which I have extended the root node using
<jasperReport xmlns="http://jasperreports.sourceforge.net/jasperreports"   ..... resourceBundle="localization"> (getting the error that the bundle for the local en_US cannot be found).

The main language localisation in Archi itself is dependant on the locale setting and whether a language pack is present for the externalised strings. Therefore the Jasper report will use these strings and whatever the user provides for element names, views, etc. What strings are you referring to?

Phil,
Thank you for your thoughts this fast. I should have explained myself better. All 😉 I want is to be able to have localized versions of  in the JasperReport files, for example ‘Purpose’ in main.jrxml.
Jan
From: Phil Beauvoir<EMAIL_ADDRESS>Sent: zaterdag 16 december 2017 00:56
To: archimatetool/archi<EMAIL_ADDRESS>Cc: Jan Cirpka<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [archimatetool/archi] Allow for translation of Jasperreports through resouce bundle properties file (#331)
The main language localisation in Archi itself is dependant on the locale setting and whether a language pack is present for the externalised strings. Therefore the Jasper report will use these strings and whatever the user provides for element names, views, etc. What strings are you referring to?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/archimatetool/archi/issues/331#issuecomment-352140744, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANI8RzveWqtyOF-oX9KCoWJCdrUlQM_Vks5tAwcmgaJpZM4RDpsT.

Within the archi source base I already do find an attempt to set this property, but it seems to be unfinished work.

Where is this?

https://github.com/archimatetool/archi/blob/master/com.archimatetool.jasperreports/src/com/archimatetool/jasperreports/JasperReportsExporter.java
line 228
But as said, for my scenario I need specify the locale in the dialog such that it can be set here.
Then secondly I wonder what the path for the resource bundle would be … I believe the most usable would be next to the .jrxml files – that would allow people to create their own versions based on a sample, versions that either have new translations or versions with a slightly changed layout.
Speaking of layouts … I have made a version where the background/cover image is local to the .archimate file – that allows me to have archimate files for different projects with different logo’s. I should make them available, will check how to do this one of these days.
Than you
From: Phil Beauvoir<EMAIL_ADDRESS>Sent: maandag 18 december 2017 11:42
To: archimatetool/archi<EMAIL_ADDRESS>Cc: Jan Cirpka<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [archimatetool/archi] Allow for translation of Jasperreports through resouce bundle properties file (#331)
Within the archi source base I already do find an attempt to set this property, but it seems to be unfinished work.
Where is this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/archimatetool/archi/issues/331#issuecomment-352389714, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANI8R7CB5Q2IZf2eihyZ4ZIqOSuXMUnNks5tBkFbgaJpZM4RDpsT.

I've figured out how to do this by specifying in code a resource bundle file that exists in the same folder as the jrxml files. The jrxml files also need to be changed to use text fields but not static texts.
So, it is possible.

Great! Reading ‘specifying in code’ I conclude that this needs an update of Archi. Please advise how I can help to test and validate the solution. That the jrxml file and in particular the  node needs to change is obvious and should be no problem at all for anyone.
Jan
From: Phil Beauvoir<EMAIL_ADDRESS>Sent: maandag 18 december 2017 16:18
To: archimatetool/archi<EMAIL_ADDRESS>Cc: Jan Cirpka<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [archimatetool/archi] Allow for translation of Jasperreports through resouce bundle properties file (#331)
I've figured out how to do this by specifying in code a resource bundle file that exists in the same folder as the jrxml files. The jrxml files also need to be changed to use text fields but not static texts.
So, it is possible.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/archimatetool/archi/issues/331#issuecomment-352455697, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANI8R_JDp8uYKpwWN9Bjy-4qlHFsOflGks5tBoIxgaJpZM4RDpsT.

It's in today's beta build:
https://www.archimatetool.com/dev/beta
The file "strings.properties" is in the customisable report folder. If you create a new file with the format "strings_en_US.properties" and edit that you could try if that works. I'm not sure if it will register the locale of your setup.

Yesterday's beta build was not correct. Try today's build:
https://www.archimatetool.com/dev/beta
For this to work you must ensure that the machine's locale is set to the target locale, as the code is getting the default locale from the system.

I tested todays download and it works like you described. Great and very quick service!
Ideally one can specify the locale in one of the wizard pages to support a scenario where I can use my laptop (with a default locale such as en_US) to produce a “Dutch” report (nl_NL) for one scenario and an “English” report for another scenario (stored in a different .archimate file). Toggleing the locale of my system is less elegant.
Jan
From: Phil Beauvoir<EMAIL_ADDRESS>Sent: dinsdag 19 december 2017 12:20
To: archimatetool/archi<EMAIL_ADDRESS>Cc: Jan Cirpka<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [archimatetool/archi] Allow for translation of Jasperreports through resouce bundle properties file (#331)
Yesterday's beta build was not correct. Try today's build:
https://www.archimatetool.com/dev/beta
For this to work you must ensure that the machine's locale is set to the target locale, as the code is getting the default locale from the system.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/archimatetool/archi/issues/331#issuecomment-352720066, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANI8R1ho-w7xmK9OUbcPTkL_SmPrxRzIks5tB5vdgaJpZM4RDpsT.

Ideally one can specify the locale in one of the wizard pages

OK, then look on the second page of the wizard in this latest build:
https://www.archimatetool.com/dev/beta

This is so cool! It works great and is exactly what I envisioned. Thank you so much!
From: Phil Beauvoir<EMAIL_ADDRESS>Sent: dinsdag 19 december 2017 16:30
To: archimatetool/archi<EMAIL_ADDRESS>Cc: Jan Cirpka<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [archimatetool/archi] Allow for translation of Jasperreports through resouce bundle properties file (#331)
Ideally one can specify the locale in one of the wizard pages
OK, then look on the second page of the wizard in this latest build:
https://www.archimatetool.com/dev/beta
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/archimatetool/archi/issues/331#issuecomment-352792731, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANI8RwEPVxSVqFNI6WUq8T24WSzCQmLZks5tB9aJgaJpZM4RDpsT.

OK, then I'll add it to the main code base...which means I have to re-do and re-generate the help documentation... ;-)

Phil,
What I also did in my reports to allow for image files local to the .archimate file is the following
         <variable name="MODEL_FILE" class="java.lang.String" calculation="System">
         <initialValueExpression><![CDATA[((com.archimatetool.jasperreports.data.ArchimateModelDataSource)$P{REPORT_DATA_SOURCE}).getModel().getFile().getAbsolutePath()]]></initialValueExpression>
         </variable>
         <variable name="MODEL_DIRECTORY" class="java.lang.String" calculation="System">
         <initialValueExpression><![CDATA[((com.archimatetool.jasperreports.data.ArchimateModelDataSource)$P{REPORT_DATA_SOURCE}).getModel().getFile().getParent()]]></initialValueExpression>
         </variable>

In the main.jrxml file. That is basically as I could not find (in the old version) variables that point to the directory of the .archimate file. In particular the MODEL_DIRECTORY variable is of importance (to me), as this allows for
         <variable name="MODEL_COVER_BACKGROUND_FILE" class="java.lang.String" resetType="Page" calculation="System">
         <variableExpression><![CDATA[$V{MODEL_COVER_BACKGROUND} != "" ? $V{MODEL_DIRECTORY}+"\\"+$V{MODEL_COVER_BACKGROUND} : ($V{MODEL_COVER_IMAGE} != "" ? "" : $P{REPORT_PATH}+"default.png")]]></variableExpression>
         <initialValueExpression><![CDATA[$V{MODEL_COVER_BACKGROUND} != "" ? $V{MODEL_DIRECTORY}+"\\"+$V{MODEL_COVER_BACKGROUND} : ($V{MODEL_COVER_IMAGE} != "" ? "" : $P{REPORT_PATH}+"default.png")]]></initialValueExpression>
         </variable>

As you see, a codebase change is not necessary, but together with the localization, I now can make specific configurations with their own localization and their own backgrounds.
Jan
From: Phil Beauvoir<EMAIL_ADDRESS>Sent: dinsdag 19 december 2017 17:15
To: archimatetool/archi<EMAIL_ADDRESS>Cc: Jan Cirpka<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [archimatetool/archi] Allow for translation of Jasperreports through resouce bundle properties file (#331)
OK, then I'll add it to the main code base...which means I have to re-do and re-generate the help documentation... ;-)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/archimatetool/archi/issues/331#issuecomment-352806940, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANI8R4GtvyFBnkwMdBufr5V-9ReIwwhCks5tB-EHgaJpZM4RDpsT.

Thanks for sharing that. But are you querying the locale in the report? The code loads the resource bundle according to the chosen local but I have not set JRParameter.REPORT_LOCALE to it.

Phil,
No, I do not do anything with the locale in the .jrxml file. The business case is the following scenario’s that I as architect want to handle from one and the same PC.

Model for a specific project that is targeted at a Dutch speaking department
Overview model for the programme that is targeted at the CIO level  in English speaking

The models have no overlap, so that the descriptive text (and naming of the nodes) is in model 1 Dutch and in model 2 English
For both models I want to create specific backgrounds and headers, so that they feel ‘specific’ to the audience. That I already could realize with the code snippets I sent, allowing me to store image files next to the .archimate file and reference it by a name. Storing it, like the original code, in the plugin/…/reports// directory is not very handsome, in particular as this directory, once installed with the regular installer, under the Program Files directory requires administrative privileges for modification (such as adding a file).
The second challenge, the localization reusing the , is now also addressed.
My snippet was mainly sent to complete the scenario (as described above). Eventually you want to include paramters like MODEL_DIRECTORY with the invocation of the main.jrxml file, even though my trick having gone through the source, does work. Alternatively you may consider to update the sample main.jrmxl file to show people how they can achieve results like I did.
Once more, thank you very much and my apologies for any misunderstanding!
Jan
From: Phil Beauvoir<EMAIL_ADDRESS>Sent: dinsdag 19 december 2017 17:31
To: archimatetool/archi<EMAIL_ADDRESS>Cc: Jan Cirpka<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [archimatetool/archi] Allow for translation of Jasperreports through resouce bundle properties file (#331)
Thanks for sharing that. But are you querying the locale in the report? The code loads the resource bundle according to the chosen local but I have not set JRParameter.REPORT_LOCALE to it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/archimatetool/archi/issues/331#issuecomment-352811945, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANI8R9BnjwjngZTuxFvgPOPnQop9W1RKks5tB-TMgaJpZM4RDpsT.

Storing it, like the original code, in the plugin/…/reports// directory is not very handsome

Don't know if you've noticed: You don't have to: you can use whatever directory you want to store your custom reports (Preferences > Jasper Report).

Don't know if you've noticed: You don't have to: you can use whatever directory you want to store your custom reports (Preferences > Jasper Report).

And the "Custom..." option allows you to choose any custom report.

I did not know this. Thanks for pointing this out. Honestly I still prefer my approach for the images – simply as I think that in my scenario the image belongs more to the project (thus the .archimate file) than to the report layout. But again, I already can achieve this today – the localization was the missing piece now resolved.
Jan
From: Jean-Baptiste Sarrodie<EMAIL_ADDRESS>Sent: dinsdag 19 december 2017 20:59
To: archimatetool/archi<EMAIL_ADDRESS>Cc: Jan Cirpka<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [archimatetool/archi] Allow for translation of Jasperreports through resouce bundle properties file (#331)
Storing it, like the original code, in the plugin/…/reports// directory is not very handsome
Don't know if you've noticed: You don't have to: you can use whatever directory you want to store your custom reports (Preferences > Jasper Report).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/archimatetool/archi/issues/331#issuecomment-352869664, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANI8RxVyuObNBCiC1e92lsdN2chgAtAgks5tCBWMgaJpZM4RDpsT.

Yes, I know (and use this). I have created my own layouts (with for example the lookup of the image in the same directory as the .archimate file).
From: Phil Beauvoir<EMAIL_ADDRESS>Sent: dinsdag 19 december 2017 21:03
To: archimatetool/archi<EMAIL_ADDRESS>Cc: Jan Cirpka<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [archimatetool/archi] Allow for translation of Jasperreports through resouce bundle properties file (#331)
Don't know if you've noticed: You don't have to: you can use whatever directory you want to store your custom reports (Preferences > Jasper Report).
And the "Custom..." option allows you to choose any custom report.
[image]https://user-images.githubusercontent.com/600504/34176373-9a5ef3c0-e4f7-11e7-9798-9aea443eb73d.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/archimatetool/archi/issues/331#issuecomment-352870690, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANI8R8NoqszKMomb5IieS5oFw8EULMKwks5tCBZ0gaJpZM4RDpsT.


Any plan for selenium wrap the headless chrome

just like https://github.com/SeleniumHQ/selenium/wiki/ChromeDriver, we can use a real browser.

Playwright is much better


Insert Item check causes some lag

Issue description:
I believe this to be an issue when a crafting job tries to fill an inventory which is full. A function checks whether or not there is space in the inventory and whether the item can be inserted, depending on the block this takes a lot of time.
What happens:
Tick time goes up significantly up to tps issues with Machines from other mods
Steps to reproduce:

Set up autocrafting for glass
Craft 1k glass
check forge tps
Depending on the furnace you may need some speed upgrades in the crafter.

I used a red matter furnace from project E but the exu2 furnace had the same problem with a bit less lag.
Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge:
Refined Storage:1.2 beta 5

nps file please
https://github.com/raoulvdberge/refinedstorage/issues/523#issuecomment-256419502

one of the more extreme cases here
https://sharedat.allions.net/?LZLSmwqY.nps

They just use an extremely inefficient way of checking if the item can be inserted. I guess the best you can do is add some buffer chest and insert it into the machine some other way.

Here is the same thing happening when only using solderer.
https://sharedat.allions.net/?g5odtEFX.nps

Hmmmm

This solves the slowness in comparing patterns, but there is no way we can improve the insert methods of other mods.


Linux kernel 5.11 hardened: error build

Describe the bug
Build log:
builder for '/nix/store/kb8jgbcj88pp61knx1qx32r499kd40kf-linux-config-5.11.7.drv' failed with exit code 255; last 10 log lines:
  warning: unused option: INET_MPTCP_DIAG
  warning: unused option: INET_RAW_DIAG
  warning: unused option: INET_TCP_DIAG
  warning: unused option: INET_UDP_DIAG
  warning: unused option: KEXEC_FILE
  error: unused option: PAGE_POISONING_NO_SANITY
  error: unused option: PAGE_POISONING_ZERO
  warning: unused option: RCU_PERF_TEST
  warning: unused option: SECURITY_WRITABLE_HOOKS
  warning: option not set correctly: STRICT_DEVMEM (wanted 'y', got 'n')
cannot build derivation '/nix/store/lvlv62yag4ndbc5j6a83kvxyjgacp7i0-linux-5.11.7.drv': 1 dependencies couldn't be built
[1 built (1 failed), 1 copied (112.2 MiB), 112.2 MiB DL]
error: build of '/nix/store/lvlv62yag4ndbc5j6a83kvxyjgacp7i0-linux-5.11.7.drv' failed

To Reproduce
Steps to reproduce the behavior:
Change to linux_latest_for_hardened = pkgs.linux_5_11; in pkgs/top-level/all-packages.nix
cc @NeQuissimus

@Izorkin
Are you doing this against master or 20.09?
For master, #117351 should have taken care of this.
For 20.09, #117350 needs to be merged.

Thanks, working. Update to master branch.


Selected item does not scroll into view

When the command is rendered the selected item does not scroll into view. The aria-selected and data-selected are both true.

My bad, looks like it needs to be a controlled value for this to work. The "hovered" item is the same as the selected so you need two states.
If that is intentional this can be closed


🛠Missing/not working translation strings + css problems

Below in the screenshots, I noted phrases that cannot be translated, because they are not in the file for translation, or are present in the file for translation but do not work.
Arrows indicate places that look extremely messy due to the fact that words in different languages have different lengths.
Separately, I would like to ask you to implement the installation process also in different languages, so that language support is at all stages.
I also want to ask to realize the ability to translate plugins and themes. To make the CMS look as user-friendly as possible.

Thank you for the contribution!
The multilanguage-feature is work in progress, some translations are missing because the core-version is still in heavy work and enhances regularly.
The plugins and theme translations are a separate task, not sure when we will find the time for it but it is on the list...

Ok, thank you for making open-source CMS! I'm glad to support and contribute Russian lang to your project. Hope in next releases you will fix some issues described here.
😃

iusvar added several improvements for translations to version 1.3.6 that has been published today....

Hi trendschau,
the latest_translations branch has been excluded, it can be safely combined with the new version137 branch, it makes changes (only three files: en.yaml, it.yaml and vue-shared.js) that concern the hero image in metadata.
To avoid misunderstandings, if and when I make changes I will do it in one branch, meanwhile I have deleted my old branches.

ahh, ok, I did not see that branch, but that is a good strategy: I will merge the latest_translation branch into the actual version branch regularly now and then everything is clean. The merges for version136 worked very smooth and without conflicts, so I think we found a good workflow now!


Fix code examples in README

:)

Hi @elerch !
Sorry for the very, very late answer: I hadn't time to work on requestz after summer...
I am currently rewriting large parts of requestz, h11 and http to make a big 0.2.0 release in the upcoming days/weeks. Unfortunately it will make your PR obsolete so I will close it.
Anyway, thanks for your help and have a nice day :)


Has a different suffix been considered to diferenciate SILE file formats?

Currently as I understand it there are two input formats: one vaguely resembling the LaTeX syntax and the other being strict XML. According to the manual the first character of the file (c === '<') decides how the file should be parsed. I just started a SILE syntax plugin for vim and before I got very far realized that the rules were going to have to operate in dual modes. This is doable in vim but will be an extra hassle. It occurred to me that not all editors will be this forgiving and there might be other situations where another method would be desirable.
Has using different extensions (say *.silx or *.slx) been considered as an alternate way to identify XML variants of the intput without having to open the file and parse some of the contents?
This is more of a brainstorm that a request as I haven't researched what the options are, but in the long run it seems like this might ease some implementation pain points as many other programs may want to interact with SILE data files.

I think it's fine to assume that a .sil file will be TeX-like. SILE doesn't care about extensions–you can (and probably should) run sile whatever.xml, but if appends .sil as a default if you don't provide an extension. So in that sense, the extension for XML flavour SILE inputs is .xml. Or .usx or whatever you like. :-)


Update README.md

The change should be made in Uthmanic-patch-1 in the other pull request...

Associated with #8


🚧 Refactor create profile

Description
The main purpose of this pull request is to enhance the process of creating a profile on Brassroots.
Test Plan
N/A
Motivation and Context
The general functionality of the app needs to be improved to be leaner and more performant overall. By refactoring not only the CreateProfile async thunk, but as well as the containers where the thunk is used, the process of creating the user's profile can be improved upon.
How Has This Been Tested?
I've manually tested the performance of the app by going through the containers in question and seeing how the new implementation is performing.
Types of Changes

Documentation
Bug fix
[x] New feature
Breaking change

Checklist

[x] My code follows the code style of this project

 Create profile thunk

 Get most played spotify track thunk


Snap packaging

Current coverage is 15.18% (diff: 0.00%)

Merging #135 into devel will decrease coverage by <.01%

@@              devel       #135   diff @@
==========================================
  Files           736        736
  Lines         26345      26355    +10
  Methods           0          0
  Messages          0          0
  Branches       2801       2806     +5
==========================================
  Hits           4002       4002
- Misses        22070      22080    +10
  Partials        273        273

Powered by Codecov. Last update e53b7f1...792ff48

Must split this in two PR


bpytop: No longer broken on Darwin

Description of changes
bpytop was last reported broken on Darwin in version 1.0.0. It is no longer broken.
https://github.com/NixOS/nixpkgs/pull/94625#issuecomment-668509399
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Works for me on x86_64-darwin.


Fix ChatConvExists decoding

This fixes the issue where NewConversation2 would fail for chats that already exist.
The problem was that ConversationID.String hex'd the redirect ConvID and ImportStatusAsError didn't decode it. Now it's explicitly hex'd and unhex'd.
This wasn't noticed probably because it isn't hit by the CLI at all, because the CLI pre-checks for conversations. I suspect that TLFIDs in exceptions might have the same problem (not fixed here).
r? @mmaxim

The commits 2d3397461d8b...410211c4ddb3 introduce visual changes on linux. :mag_right: 1 changed

Changed: Chat_Input-Emoji_Open (before) (after)

The commits 2d3397461d8b...4576d3731163 introduce visual changes on linux. :mag_right: 1 changed

Changed: Chat_Input-Emoji_Open (before) (after)

The commits 2d3397461d8b...640fe5077cae introduce visual changes on linux. :mag_right: 1 changed

Changed: Chat_Input-Emoji_Open (before) (after)


Deploy and use shared-data StarRocks: Unknown properties

Steps to reproduce the behavior (Required)
fe.conf:
run_model = shared_data
cloud_native_meta_port = 6090
cloud_native_storage_type = HDFS
cloud_native_hdfs_url = hdfs://10.122.33.***:8020/user/sr
be.conf:
starlet_port = 9070
storage_root_path = /data3,medium:ssd
SQL:
CREATE DATABASE cloud_db;
USE cloud_db;
CREATE TABLE IF NOT EXISTS detail_demo (
recruit_date  DATE           NOT NULL COMMENT "YYYY-MM-DD",
region_num    TINYINT        COMMENT "range [-128, 127]",
num_plate     SMALLINT       COMMENT "range [-32768, 32767] ",
tel           INT            COMMENT "range [-2147483648,<PHONE_NUMBER>]",
id            BIGINT         COMMENT "range [-2^63 + 1 ~ 2^63 - 1]",
password      LARGEINT       COMMENT "range [-2^127 + 1 ~ 2^127 - 1]",
name          CHAR(20)       NOT NULL COMMENT "range char(m),m in (1-255) ",
profile       VARCHAR(500)   NOT NULL COMMENT "upper limit value 65533 bytes",
ispass        BOOLEAN        COMMENT "true/false"
)
DUPLICATE KEY(recruit_date, region_num)
DISTRIBUTED BY HASH(recruit_date, region_num)
PROPERTIES (
"enable_storage_cache" = "true",
"storage_cache_ttl" = "2592000",
"enable_async_write_back" = "false"
);
Expected behavior (Required)
Real behavior (Required)
ERROR 1064 (HY000): Unexpected exception: Unknown properties: {enable_storage_cache=true, storage_cache_ttl=2592000, enable_async_write_back=false}
fe.warn.log:
PROPERTIES (
"enable_storage_cache" = "true",
"storage_cache_ttl" = "2592000",
"enable_async_write_back" = "false"
)) process failed.
com.starrocks.common.DdlException: Unknown properties: {enable_storage_cache=true, storage_cache_ttl=2592000, enable_async_write_back=false}
at com.starrocks.server.LocalMetastore.createOlapOrLakeTable(LocalMetastore.java:2455) ~[starrocks-fe.jar:?]
at com.starrocks.server.LocalMetastore.createTable(LocalMetastore.java:814) ~[starrocks-fe.jar:?]
at com.starrocks.server.GlobalStateMgr.createTable(GlobalStateMgr.java:2275) ~[starrocks-fe.jar:?]
at com.starrocks.qe.DDLStmtExecutor$StmtExecutorVisitor.lambda$visitCreateTableStatement$4(DDLStmtExecutor.java:235) ~[starrocks-fe.jar:?]
at com.starrocks.common.ErrorReport.wrapWithRuntimeException(ErrorReport.java:108) ~[starrocks-fe.jar:?]
at com.starrocks.qe.DDLStmtExecutor$StmtExecutorVisitor.visitCreateTableStatement(DDLStmtExecutor.java:234) ~[starrocks-fe.jar:?]
at com.starrocks.qe.DDLStmtExecutor$StmtExecutorVisitor.visitCreateTableStatement(DDLStmtExecutor.java:147) ~[starrocks-fe.jar:?]
at com.starrocks.sql.ast.CreateTableStmt.accept(CreateTableStmt.java:272) ~[starrocks-fe.jar:?]
at com.starrocks.qe.DDLStmtExecutor.execute(DDLStmtExecutor.java:133) ~[starrocks-fe.jar:?]
at com.starrocks.qe.StmtExecutor.handleDdlStmt(StmtExecutor.java:1250) ~[starrocks-fe.jar:?]
at com.starrocks.qe.StmtExecutor.execute(StmtExecutor.java:556) ~[starrocks-fe.jar:?]
at com.starrocks.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:349) ~[starrocks-fe.jar:?]
at com.starrocks.qe.ConnectProcessor.dispatch(ConnectProcessor.java:463) ~[starrocks-fe.jar:?]
at com.starrocks.qe.ConnectProcessor.processOnce(ConnectProcessor.java:729) ~[starrocks-fe.jar:?]
at com.starrocks.mysql.nio.ReadListener.lambda$handleEvent$0(ReadListener.java:69) ~[starrocks-fe.jar:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) ~[?:1.8.0_131]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) ~[?:1.8.0_131]
at java.lang.Thread.run(Thread.java:748) ~[?:1.8.0_131]
StarRocks version (Required)

You can get the StarRocks version by executing SQL select current_version()
version：3.0.3

Hi @RYiHui , could you please execute "show frontends" and check the "version" column in the result?
The "enable_storage_cache" property was renamed to "datacache.enable" in version 3.1, and the "storage_cache_ttl" attribute was removed since version 3.1.
Therefore, in version 3.1 you can write:
properties("datacache.enable"="true")

To enable the data cache.

Hi @RYiHui , could you please execute "show frontends" and check the "version" column in the result?
The "enable_storage_cache" property was renamed to "datacache.enable" in version 3.1, and the "storage_cache_ttl" attribute was removed since version 3.1.
Therefore, in version 3.1 you can write:
properties("datacache.enable"="true")

To enable the data cache.

hi, @sduzh ,thanks for your reply,but my starrocks version is 3.0.3 , when i try to use "datacache.enable"="true" in create table SQL,   report Unknown properties ，The results are as follows:

Steps to reproduce the behavior (Required)
fe.conf:
run_model = shared_data cloud_native_meta_port = 6090 cloud_native_storage_type = HDFS cloud_native_hdfs_url = hdfs://10.122.33.***:8020/user/sr

Should be run_mode not run_model

thanks !!!,Why can't  start the service  after I modify it?

Steps to reproduce the behavior (Required)
fe.conf:
run_model = shared_data cloud_native_meta_port = 6090 cloud_native_storage_type = HDFS cloud_native_hdfs_url = hdfs://10.122.33.***:8020/user/sr

Should be run_mode not run_model

thanks !!!,Why can't start the service after I modify it?

Steps to reproduce the behavior (Required)
fe.conf:
run_model = shared_data cloud_native_meta_port = 6090 cloud_native_storage_type = HDFS cloud_native_hdfs_url = hdfs://10.122.33.***:8020/user/sr

Should be run_mode not run_model

when i kill -9 this process, StarRocksFE Still can't start.

Steps to reproduce the behavior (Required)
fe.conf:
run_model = shared_data cloud_native_meta_port = 6090 cloud_native_storage_type = HDFS cloud_native_hdfs_url = hdfs://10.122.33.***:8020/user/sr

Should be run_mode not run_model

Should I uninstall starrocks and then reinstall the deployment?

Steps to reproduce the behavior (Required)
fe.conf:
run_model = shared_data cloud_native_meta_port = 6090 cloud_native_storage_type = HDFS cloud_native_hdfs_url = hdfs://10.122.33.***:8020/user/sr

Should be run_mode not run_model

 Should I uninstall starrocks and then reinstall the deployment?

Yes

@RYiHui, I wanted to check if the problems raised in this issue have been resolved on your end. If so, I plan to close this issue for now. Please feel free to reopen it anytime if you still have outstanding questions or issues.

I have resolved this problem,thanks for your help.

hey @sduzh . do i really need a cn for shared data mode? or can i stick with be + fe?

hey @sduzh . do i really need a cn for shared data mode? or can i stick with be + fe?

You can still use BE.


Change 'continue-on-fail' example to better reflect its description

Researching how this parallelism config feature functions and came across this example that I think wasn't accurately reflecting the description it had at the top of the file.
PS. Great work on Argo!

What's the effect on parallelism  add to the example ?

See description of the example:

Example on specifying parallelism on the outer workflow and limiting the number of its [emphasis mine]

Given that description it seems wrong to me that the config doesn't actually specify the parallelism value.

OK  LGTM
ping @sarabala1979

I didn;t see any difference in execution. Can you provide more information what this change is doing?

@sarabala1979 Perhaps the description of this example is what's incorrect.
The file is named continue-on-fail, and there is a continue-on-fail feature on C. The description mentions parallelism, but there's nothing I see in the example that is "specifying parallelism on the outer workflow" (<- from description).
Without knowing for sure what this example is supposed to demonstrate, it's hard to say what aspect of it should be changed, but I do think right now it's a confusing example.


Feature/verify and delete measurement

:tada: This PR is included in version 5.12.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


filter icmp id with sock_filter, to optimize rawsocket preformance

rawsocket will receive all packets matching the target protocol, including replies to another ping on this host.
with sock_filter we can filter icmp reply packets, only accepting icmp replies that match the id in the sent packet.

Thanks!
Sharing a single socket among all Pingers in a single-process scenario is a great idea, as it reduces redundant memory copies and IRQ caused by multiple raw sockets. However, I believe sock_filter has more advantages. It rejects unexpected packets in kernel space, resulting in even fewer IRQs or memory copies to user space compared to a single raw socket. Additionally, it offers better performance in multi-process scenarios.

Oh, I see! You mean using a single raw socket together with sock_filter? Maintaining a map to match ICMP IDs might make the BPF more complex, but it sounds really powerful!

My thought is that we can just remove the ID filter from the BPF. Just allow all ICMP packets to be read by the library.


cannot build demo

hello,
the demo will not build.
error is
SuperRecordDemo.xcodeproj cannot be opened because it is missing its project.pbxproj file.
xcode 6.1.1
iOS 8.1

I don't know why but the demo has been removed month ago by @michaelarmstrong.

The demo was broken... I'll be updating it with a new and better sample project shortly. Until then, feel free to ask any questions.

I think it should be better have a small demo project inside this project and spent more time and effort on keeping updated a wiki and the Readme.
In my opinion the only components that needs a demo project is NSFetchedResultsControllerExtension

that's ok, i just want to see it build and do something before spending hours integrating it.


chore: add benchmark tool

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Summary
(describe what this merge request does)
Implementation highlights
(describe how the merge request does for feature changes, share the RFC link if it has)
Test checklist

[ ] add new test cases
[ ] all code changes are covered by unit tests
[ ] end-to-end tests

[ ] deploy web console with CloudFront + S3 + API gateway
[ ] deploy web console within VPC
[ ] deploy ingestion server

[ ] with MSK sink
[ ] with KDS sink
[ ] with S3 sink

[ ] deploy data processing
[ ] deploy data modeling

[ ] new Redshift Serverless
[ ] provisioned Redshift
[ ] Athena

[ ] deploy with reporting
[ ] streaming ingestion

[ ] with Redshift Serverless
[ ] with provisioned Redshift

Is it a breaking change

[ ] add parameters without default value in stack
[ ] introduce new service permission in stack
[ ] introduce new top level stack module

Miscellaneous

[ ] introduce new symbol link source file(s) to be shared among infra code, web console frontend, and web console backend

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @dengmingtong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
8.60
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 7/12/2024, 08:24:40 (UTC+0)

SonarQube Code Analytics
Quality Gate passed

Additional information
The following metrics might not affect the Quality Gate status but improving them will improve your project code quality.
Issues
 0 Bugs
 0 Vulnerabilities
 0 Code Smells
Coverage and Duplications
No data Coverage
No data Duplication

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @dengmingtong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.70
< 80

Duplicated lines density
:white_check_mark: OK
8.60
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 7/12/2024, 08:28:33 (UTC+0)

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @dengmingtong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.70
< 80

Duplicated lines density
:white_check_mark: OK
8.50
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 7/18/2024, 11:03:27 (UTC+0)

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @dengmingtong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.70
< 80

Duplicated lines density
:white_check_mark: OK
8.50
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 7/18/2024, 11:28:41 (UTC+0)

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @dengmingtong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.70
< 80

Duplicated lines density
:white_check_mark: OK
8.50
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 7/21/2024, 12:54:54 (UTC+0)

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @dengmingtong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.70
< 80

Duplicated lines density
:white_check_mark: OK
8.50
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 7/21/2024, 12:58:13 (UTC+0)


Add Wiring 1.0

After reading https://arduinohistory.github.io/ I noticed this needed to be added to cask.

To solve common stylistic issues, run brew cask style --fix {{your_cask_file}} prior to submission.

Thank you for the contribution. It needed some fixes, so they were made in 5323afe0554acf22dd37f2b12f5a9e9014221b0f. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Suggestion: Windows 95 classic visual style

I would like an ability to enable Windows 9x/2k visual style on Windows 10 (not flat one based on High Contrast but real one that disables flat style and uses the old engine from windows 9x/2k, that exists for compability)

Would really love to better understand how as a power user, this makes you more productive. Honestly, I can't see us doing this.


fix: rename workspace active fix

Closes: https://github.com/Alexays/Waybar/issues/2481
Verified locally. With a hyprctl dispatch renameworkspace 3 "4" and saw old behavior (top) and new behavior (bottom) of it keeping the active state. My config visible = blue and active = green.

@Alexays bug fix for active status with a workspace rename whenever you get a chance.


control-service: remove executables from secure job builder

Why: In order to reduce the attack surface, we need to remove all unnecessary system executables after the job building.
What: The change aims to remove all left and unnecessary executables after job building - chown, uname and pip.
Testing done: built image locally.
Signed-off-by: Miroslav Ivanov<EMAIL_ADDRESS>

What about chmod? Also, fix the name of your PR.

The base image contains only chwon, uname, sh and python.