Solace PubSub+ Event Broker has no "latest" version

Visit https://keda.sh/docs/2.4/scalers/solace-pub-sub/
Click on Click here for latest

This results in a 404. I'd either expect the "latest" button to be absent or the target page to exist.

Also, we should make sure it's not absent :D

@tomkerkhove: should that page appear in all versions of the docs as of 2.4?

For example, consider the cron scaler, which has the following versions of that scaler's page:
$ find content -name "cron.md" | sort
content/docs/1.5/scalers/cron.md
content/docs/2.0/scalers/cron.md
content/docs/2.1/scalers/cron.md
content/docs/2.2/scalers/cron.md
content/docs/2.3/scalers/cron.md
content/docs/2.4/scalers/cron.md
content/docs/2.5/scalers/cron.md
content/docs/2.6/scalers/cron.md
content/docs/2.7/scalers/cron.md

It is my understanding that if a scaler appeared in version x.y, then there will be a page for that scaler under all doc versions >= x.y (unless the scaler no longer exists). Is that correct?
If so, then the problem with the Solace pub-sub page is that it hasn't been duplicated since its introduction:
$ find content -name "solace-pub-sub.md" | sort
content/docs/2.4/scalers/solace-pub-sub.md

Yes that is correct, ti should be copied to 2.4+

Ah, it seems that the files exist, but were renamed:
$ find content -name "**solace*" | sort
content/docs/2.4/scalers/solace-pub-sub.md
content/docs/2.5/scalers/solace.md
content/docs/2.6/scalers/solace.md
content/docs/2.7/scalers/solace.md

I'll rename them all to solace-pub-sub.md, does that work for you @tomkerkhove?

@chalin yeah, plase do that. Good catch!


Add paint event to labels layer emitting last history item

Description
@kephale and I are at the CellMap hackathon and came across #4194 which discusses the addition of a paint event to the Labels layer. Kyle is currently having to implement a tedious workaround to get access to the latest changes, and based on @jni's suggestion  in #4194 I think this minimal change would be sufficient to emit the event without affecting performance, as we only emit on mouse release if the undo_item is not empty.
I've had a think about any issues this could introduce but haven't been able to come up with any. Would love any feedback on the implementation, or if there's a better way to do it, some insight into what that would look like!
Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References
Closes #4194
How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change
[ ] example: I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

Test failure is about napari viewer cleanup prior to test_add_function_widget.
  E       AssertionError: Some instance of QtViewer is not properly cleaned in one of previous test. For easier debug one may use --save-leaked-object-graph flag for pytest to get graph of leaked objects. If you use qtbot (from pytest-qt) to clean Qt objects after test you may need to switch to manual clean using `deleteLater()` and `qtbot.wait(50)` later.
  E       assert 1 == 0

I'm not really sure if these changes could have triggered this test failure or not... I will try rerunning I guess

@DragaDoncila I'm testing this out now and it looks like I'm getting some Events that don't have valueattributes:
This is a dir(event) from an Event I'm receiving:
['__class__', '__delattr__', '__dict__', '__dir__', '__doc__', '__eq__', '__format__', '__ge__', '__getattr__', '__getattribute__', '__gt__', '__hash__', '__init__', '__init_subclass__', '__le__', '__lt__', '__module__', '__ne__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', '_blocked', '_handled', '_kwargs', '_native', '_pop_source', '_push_source', '_sources', '_type', 'blocked', 'handled', 'index', 'native', 'source', 'sources', 'type']

@jni the missing event value was a red herring, I think this is ready for review 🙏

Yes, @DragaDoncila solved my event typing issue!

Ok took me a while to get my head around even this short PR 😂, because it's weird that the events are being emitted from the mouse bindings file instead of the layer itself.
@DragaDoncila what do you think about emitting events as things are added to the history? Perhaps that whole history check should get moved inside the layer?
Other than that this looks good, I'd like a bit of testing and/or a usage example? One idea I've had for some time is to synchronise a different labels layer that only contains a binary mask of the areas that have been proofread (painted/erased) in one way or another, ie everything that gets painted gets a "True" value in the mask.

what do you think about emitting events as things are added to the history? Perhaps that whole history check should get moved inside the layer?

The nice and and important thing about this is that it allows other events (e.g. splitting labels with a plugin) to also be captured.

@DragaDoncila what do you think about emitting events as things are added to the history? Perhaps that whole history check should get moved inside the layer?

@jni are we talking as atoms are added to the history? Or after items are added to history. I think really emitting an item is much better than the atom as there are so many of those, and it wouldn't be clear to the user when an item was complete and signalled one full drag right? I'll look at emitting using the block_saving attribute maybe.
Also agree that the history item popping in the mouse bindings is kinda suss so I'll look at moving that too

This PR was superseded by #4702


initialIndex loading a blurry page

I am using the initial index to render the page at the last element of a list.
The correct page is loading but it has a blur as if it is beginning to transition.
PageFlipWidget(
key: _controller,
backgroundColor: theme.currentTheme.colorScheme.surface,
initialIndex: last_index,
lastPage: Container(
    color: Colors.white,
    child: const Center(child: Text('End of Story'))),
children: messages.asMap().entries.map((entry) {
  int index = entry.key;
  Message message = entry.value;
  return _buildBookPage(
      message, theme, last_index);
}).toList(),
)

Hello i wondered if you found a solution because i encountered the same issue with the initial index and the goToPage function.

Same Issue

Is this project basically dead? Setting nay index other than 0 seems to just freeze the widget. It doesn't look like anyone actively working on it. It really should be removed from pub.dev.


Send screen should default to Z address [privacy by default]

Send screen should default to Z address [privacy by default].
Accidentally sending from a T address is easy. Windows bug.

Hmm, This should already work. It selects a Sapling address by default, and will fall back to a t-Addr if there isn't one with balance.
Can you confirm that you have a z-addr with balance that it is not selecting by default?

Confirmed it is fixed. I believe I was a release behind and can't replicate
after update.
On Sat, Feb 2, 2019 at 7:07 PM adityapk00<EMAIL_ADDRESS>wrote:

Hmm, This should already work. It selects a Sapling address by default,
and will fall back to a t-Addr if there isn't one with balance.
Can you confirm that you have a z-addr with balance that it is not
selecting by default?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ZcashFoundation/zec-qt-wallet/issues/94#issuecomment-460018911,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AtApV_CRp1hlEaO_4oV2W7NpevB-poMOks5vJlJjgaJpZM4af54W
.

Thanks for confirming! I'll track the related android issue on the android github. Closing this issue.


Add feeds view for RSS, Atom & JSON feeds

Supports multiple sources
Items are sorted by published time
You can hide published time and feed title for smaller screens or if you only have one feed
Automatically computes the max number of items that fit into the view (you can also override it)

closes #1

@WyattHBrown Let me know if this is what you were looking for and if you have any more suggestions!

It depends on how you have installed and run blimp. Right now these changes aren't in the master branch yet so you would need to checkout or install from this branch.
I will merge the changes now so you should be able to install normally from the master branch :)

Awesome! I also realized my issue, I forgot to build the go file when making the changes! Got it all working now!


Problem on Windows 10.0.22621.4037

Thank you for this great work, but when I log in via the RDP. The local user is closed.
rdpwrap.ini -> 2024-08-21
I have Windows 11 22H2
Versión 10.0.22621.4037

PS: I try on Windows 10 and work fine.

Please, attach your RDPConf screenshot and termsrv.dll.

Thank for help me.
rdpwrap.ini
https://www.dropbox.com/scl/fi/ck0fh5vekcop5ic68wmul/rdpwrap.ini?rlkey=sljmm07pgbsmclaozfvyywd29&st=s81xd6k2&dl=0
termsrv.dll
https://www.dropbox.com/scl/fi/wfhnbfjij0x60b2a87zrd/termsrv.dll?rlkey=8sf81o8dxl4byjgrer4taacff&st=f0vy9imv&dl=0

Try reboot？

It works fine.


Create @font-face rule in CSS output

The tests are not perfect, but at least will catch if the thing is broken.
Example output:
@font-face {
    font-family: "Gimlet Variable Regular";
    src: url("GimletVariable-VF.woff2");
    font-weight: 300 900;
    font-stretch: 64% 100%;
    unicode-range: U+0020-007E, U+00A0-0137, U+0139-0148, U+014A-017E,
        U+0192, U+0218-021B, U+0237, U+0259, U+02BB-02BC, U+02C6-02C7, U+02C9,
        U+02D8-02DD, U+0300-0304, U+0306-0308, U+030A-030C, U+0312,
        U+0326-0328, U+0394, U+03A9, U+03BC, U+03C0, U+1E80-1E85, U+1EF2-1EF3,
        U+2010-2015, U+2018-201A, U+201C-201E, U+2020-2022, U+2026, U+2030,
        U+2032-2033, U+2039-203A, U+2044, U+2070, U+2074-2079, U+2080-2089,
        U+20AC, U+2116-2117, U+2122, U+2126, U+2190, U+2192, U+2202, U+2206,
        U+220F, U+2211-2212, U+2215, U+2219-221A, U+221E, U+222B, U+2248,
        U+2260, U+2264-2265, U+25CA, U+27B5, U+F6C3;
}

Thanks again @pascalw. Merging this now, and added an issue for improved testing.


WebExtension

It would be nice to have a basic WebExtension for ntfy similar to what Pushbullet is offering.

Nice idea. I do not think I have the capacity or time to make one, but I'm happy to accept contributions.


set_relation reltype can be ignored because of type(uid)==icalendar.vText

Description
When using set_relation on a component (e.g. todo), the reltype might be ignored. This is because the library icalendar ignores properties if the value of a property is already of an internal type (see code in question). This happens if the UID is directly taken from the icalendar object and is of type vText.
Testing
cal: caldav.Calendar  # assume valid calendar
task = cal.add_todo(summary="First Task")
dependent = cal.add_todo(summary="Dependent")
dependent.set_relation(other=task, reltype="DEPENDS-ON", set_reverse=False)
print(dependent.icalendar_instance.to_ical())

Check output that reltype got lost.
Possible Mitigations
Converting the uid to a string explicitly before calling self.icalendar_component.add in set_relation works for me. This may be a possible workaround until icalendar potentially fixes this unexpected behavior. I can a add a PR for that, if requested.
I also submitted this issue to icalendar (see collective/icalendar#557). However, I see that changing this behavior in icalendar might introduce issues for other dependent projects, so I do not expect them to fix this issue soon.

I've also been struck by this, but thought I had fixed it already.  Yes, converting vText to string whenever appropriate seems to be the solution.  Send a merge/pull-request (it would be awesome with a pull-request including test code), or perhaps I'll get around to do research on it myself later this week.

I added a PR, #335, but without the tests. I can try add them later this or next week, as I have not that much free time now.

My employer is currently having a customer with short deadlines and decent budget, unfortunately during the same days as I'm meeting up with family ... so I'm also overloaded for the moment :-)
I'll reopen the issue as tests are missing.


Creating _generated pb directory for datastore

Also updating the uses of these imports so that our library continues to work.
@tseaver Sorry I didn't do this originally with #1297, #1299, #1301.

LGTM


Typo in Changelog

Changelog in Marketplace:

0.8.0 - 2022-02-15
0.7.0 - 2022-12-05

I guess v0.8.0 was released in 2023 (not 2022), or did you achieve time travel? 😄

Thanks for pointing that out! We'll get that fixed. Thanks!

Fixed in v0.9.0. Thanks!


Add change namespace test for Namespace service

This PR adds a test to make sure that the router URL changes are successful even when the namespace changes to a non default namespace

@nfarruggiagl before I can review/merge this, the CLA needs to be handled.

@nfarruggiagl before I can review/merge this, the CLA needs to be handled.

Hey @bryanl CLA seems to be ready. Feel free to review it now.

@nfarruggiagl this change looks good. I'll approve and you can work on the merge conflict :)


Unable to get response from invoke function in RPC-API's

For the bleow code i am setting the value by calling setMethod using Storage.put.
Hear i am using RPC-API's testnet
`public class Test extends SmartContract {
public static Object Main(String name, Object[] args){
	if(name.equals("setMethod")) {
		 return setMethod(args[0]);
	}
	if(name.equals("getMethod")) {
		return getMethod();
	}
		return false;
}

public static Object getMethod() {
	 return Storage.get(Storage.currentContext(), "aaa");
}
public static Object setMethod(Object empName) {
	byte[] b= (byte[]) empName;
	Storage.put(Storage.currentContext(), "aaa" ,b);
	return true;

}

}`

POST Request :
{
"jsonrpc": "2.0",
"method": "invokefunction",
"params": [
"0x51c501c83af4ae5cf6ad28152dfd02cdd4ac1035",
"Main",
[
{
"type": "String",
"value": "setMethod"
},
{
"type": "Array",
"value": [{
"type":"String",
"value": "zzz"
}]
}
]
],
"id": 1
}

Response :
{
"jsonrpc": "2.0",
"id": 1,
"result": {
"script": "037a7a7a51c1097365744d6574686f6452c1044d61696e673510acd4cd02fd2d1528adf65caef43ac801c551",
"state": "HALT, BREAK",
"gas_consumed": "0.033",
"stack": [
{
"type": "ByteArray",
"value": ""
}
]
}
}

In response i am getting "state": "HALT, BREAK", but it is not returning the value. i mention above java code. I am getting empty response (i tested both set and get methods getting same response).

What parameters did you use to deploy the smart contract?

Did you find out how to manage this, @penlite.
Please fell free to ping us here or check the docs: https://docs.neo.org/
If this is already solved, please close this issue.

Closed because wasn't answered


build(deps): update tw-to-css to 0.0.12

Component / Package Name:
This PR contains:

[ ] bugfix
[ ] feature
[ ] refactor
[ ] documentation
[x] other

Are tests included?

[x] yes (bugfixes and features will not be merged without tests)
[ ] no

Breaking Changes?

[ ] yes (breaking changes will not be merged unless absolutely necessary)
[x] no

Description
Updating tw-to-css because in 0.0.11, it depends<EMAIL_ADDRESS>which is vulnerable.
https://github.com/vinicoder/tw-to-css/pull/10

Thanks for this. We'll get this in today


Improving SUT and test suite stability

Several issues causing test flakiness were addressed:

Problems related to the number of inotify instances.
Concurrency and lockdown issues with proxies, solved using custom Dockerfiles.
Dependency and SQL problems caused by the system starting under heavy load without migrations or a ready database.
Issues with order states remaining in a pending validation status under certain system loads were resolved.

Several minor fixes:

Enhanced integration of the logging system (RETORCH tool) within the Jenkinsfile.
Improved the readability of compose files, scripts, and code.

@augustocristian Check build 45 on this branch

@javiertuya
Several changes, including fixes to various versions of Docker, Compose, and containers, which seem to have resolved the test flakiness in TJobC. However, we are now finding some flakiness in TJobE attributed to timeouts and failure to update the order state. I believe this issue should be tackled in a separate branch.
Additionally, I've addressed proxy issues by implementing a combination of solutions suggested by Javier. This includes employing a custom waiter in the test method to monitor the database state, along with creating custom images tailored to each scenario's configuration

@augustocristian @ClaudiodelaRiva Remember: no changes until all critical regression issues are done.
In this case it seems that issue #56 has been already fixed without this PR, but not closed. Am I right?

@javiertuya  I've resolved all the flakiness issues in the system under test (SUT) caused by parallelization and low resource availability!

@augustocristian Do not add anything new to this endless PR, just revise the review comments. Any flakiness after merging the PR can be addressed later in separate issues/PRs
FYI @ClaudiodelaRiva

So, this PR is ready for review and merge @javiertuya


Make an EIA860m Changelog table

Overview
Closes #3330.
What problem does this address?
What did you change?
Testing
How did you make sure this worked? How can a reviewer verify this?
# To-do list
- [x] Review the PR yourself and call out any questions or issues you have
- [x] Make sure full ETL runs & `make pytest-integration-full` passes locally
- [x] For major data coverage & analysis changes, [run data validation tests](https://catalystcoop-pudl.readthedocs.io/en/latest/dev/testing.html#data-validation)
- [ ] Update the [release notes](../docs/release_notes.rst): reference the PR and related issues. ( i haven't added this bc
- [ ] If updating analyses or data processing functions: make sure to update or write data validation tests

Hello! What are the remaining pieces of work on this?

There are a handful of validation errors. I waited a few days to be able to get to this because there was a pr that got merged into main that I caught that had non-updated validation errors. I wanted to make sure I was trying to debug things from this pr only.. which are these:
FAILED test/validate/eia_test.py::test_minmax_rows[eia_raw-bf_eia923-1607752-1607752-128252] - ValueError: bf_eia923: found 1537748 rows, expected 1607752. Off by -4.354%, allowed margin of 0.000%
FAILED test/validate/eia_test.py::test_minmax_rows[eia_raw-frc_eia923-650671-265784-25443] - ValueError: frc_eia923: found 637127 rows, expected 650671. Off by -2.082%, allowed margin of 0.000%
FAILED test/validate/eia_test.py::test_minmax_rows[eia_raw-gf_eia923-2918170-2918170-246324] - ValueError: gf_eia923: found 2881840 rows, expected 2918170. Off by -1.245%, allowed margin of 0.000%
FAILED test/validate/eia_test.py::test_minmax_rows[eia_monthly-bf_eia923-1607752-1607752-128252] - ValueError: bf_eia923: found 1537748 rows, expected 1607752. Off by -4.354%, allowed margin of 0.000%
FAILED test/validate/eia_test.py::test_minmax_rows[eia_monthly-frc_eia923-650671-265784-25443] - ValueError: frc_eia923: found 259743 rows, expected 265784. Off by -2.273%, allowed margin of 0.000%
FAILED test/validate/eia_test.py::test_minmax_rows[eia_monthly-gf_eia923-2918170-2918170-246324] - ValueError: gf_eia923: found 2881840 rows, expected 2918170. Off by -1.245%, allowed margin of 0.000%

i suspect this is from the expand timeseries munging but i'm investigating now

[x] Is this loss of records in the core tables? No. I used the sqlite-table-diff and first checked the three core tables implicated and my local tables were all the exact same as the last nightly build tables.
[ ] Is this loss of records in the core tables?

okay i was jsut being a complete dufous with this validation tests. i just reran them everything is indeed fine.


Expose set_dsp_mcacc_memory_set AVR command as a service

Follow-up from crowbarz/aiopioneer#33

Possibly also add a select entity that renders a drop-down to select the MCACC memory.


Add opportunity to re-try request in case of error

[828] - https://transfer.sh/CjBNs/jdi-dark-tests.tar.gz

[828] - Allure report on Netlify: https://5e713884ebcc44018b02406b--jdi-dark.netlify.com

[830] - https://transfer.sh/szH0X/jdi-dark-tests.tar.gz

[830] - Allure report on Netlify: https://5e713bf274705d2facd14a8f--jdi-dark.netlify.com

[834] - Could not save metadata Could not save metadata Could not save metadata

[834] - Allure report on Netlify: https://5e71f3e4c1c3610228306eb9--jdi-dark.netlify.com


Cast datetimes to string

Dynamo seems to not support date or time, so I figure that casting it to a string at this point won't hurt.
Also, a tiny readme fix

@keithmgould what do you think of this addition to ensure that all datetime values passed into eventosaurus are cast to strings, just to be sure?

👍


refacto(air/layout): move compute_program_hash in utils.rs

Tell me if it's fine for it to leave in utils.rs

I think that better idea is to not create another file lets move this function to mod.rs there are some common utils there already so it fits in imo
https://github.com/tdelabro/swiftness/blob/factorize-compute-program-hash/crates/air/src/layout/mod.rs#L114

@Okm165 done
I removed the pub from the method, as we don't want it to be the go-to implementation for other crates in the rust ecosystem to depend on.
Sidenote: more than half of this file is Error definition. Maybe moving those into their own error.rs could make sense

@Okm165 I moved the errors to their own file.
Btw, is there a reason why you prefer to duplicate the error structs and use both thiserror and thiserror-nostd, rather than using only the latter but with or without its std feature: https://docs.rs/crate/thiserror-no-std/latest/source/Cargo.toml.orig

@Okm165 I will on a separated PR as it spans changes across multiple crates


Add circle.yml

Collect JUnit test metadata
Save reports to build artifacts
Cache all dependencies

I made a test fail to show that the test results look like for a failed test:

thanks Marc! looks great ;)

Awesome, we have artifacts:
tests:
https://circle-artifacts.com/gh/Swrve/rate-limited-logger/32/artifacts/0/home/ubuntu/rate-limited-logger/build/reports/tests/classes/com.swrve.ratelimitedlogger.RateLimitedLogTest.html
findbugs:
https://circle-artifacts.com/gh/Swrve/rate-limited-logger/32/artifacts/0/home/ubuntu/rate-limited-logger/build/reports/findbugs/main.html
code coverage:
https://circle-artifacts.com/gh/Swrve/rate-limited-logger/32/artifacts/0/home/ubuntu/rate-limited-logger/build/reports/jacoco/test/html/index.html


MANIFEST.in not including zinnia_tinymce/static/zinnia_tinymce/css dir

This is causing css errors in zinnia_tinymce
Please include zinnia_tinymce/static/zinnia_tinymce/css dir in MANIFEST.in

Version 1.2.1 has been released on Pypi


chore: removing webhooks from existence for the AKS provider

Fixes #
Description
Removing the webhooks from our self hosted provider.
How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.08%) to 97.623%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/imagefamily/image.go
3
84.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.08%

Covered Lines:
35725

Relevant Lines:
36595

💛  - Coveralls


Governance and sustainability?

I just stumbled on this library and it looks absolutely amazing. I'm so excited to try it out.
As I'm evaluating it for company use, I was wondering what the governance and sustainability model is for this project. What is the process for making decisions about the long term goals of the project? Additionally, rest-hooks seems to have a pretty small number of contributors. That's always worrisome when it comes to a library to depend on. Is there any sort of plan for expanding the number of contributors and maintainers to increase long term sustainability?
Thanks again for this library, it really does seem to solve problems about hooks and REST APIs in an elegant way.

Hi @wwahammy, great question!
Until recently we've been managing the direction and collaboration on projects within Coinbase via an internal group called the "Rest Hooks Council". There we would have meetings discussing the future of the group as well as having open reviews of "HEP"s (Hook Enhancement Proposals) for any major or breaking changes.
However, now @ljharb and me are working on opening the council. We'll likely be looking for some dedicated community members to join the council and at the very least, become involved in the reviews and community going forward. We'll have more to announce soon, until then we've setup a discord community and are currently getting that setup, etc.

Thanks @ntucker. That's all good to hear. I've joined the Discord.
Are you able to share a sense of how much Rest Hooks is used in Coinbase? Again, just want to know the likelihood that it will continue to be maintained, given that the community is still quite small. :smile:

Currently used by 3 public product teams (consumer, commerce, custody), and 3+ internal tools teams, as well as across both web and react native.


No VMs on startup

[systemd]
Failed Units: 5
  master0.service
  master1.service
  master2.service
  worker0.service
  worker1.service

$ sudo virsh list --all
Id   Name   State
-------------------

Use the below as a workaround.
$ sudo systemctl restart master0 master1 master2 worker0 worker1

$ sudo systemctl restart master0
[onp@localhost ~]$ journalctl -u master0
Aug 26 00:00:45 localhost systemd[1]: Starting master0.service...
Aug 26 00:00:45 localhost create-vm.sh[1906]: + VM_NAME=master0
Aug 26 00:00:45 localhost create-vm.sh[1906]: + MAC1=52:54:00:11:22:b1
Aug 26 00:00:45 localhost create-vm.sh[1906]: + MAC2=52:54:00:11:22:a1
Aug 26 00:00:45 localhost create-vm.sh[1906]: + VM_DIR=/opt/openshift-network-playground/libvirt
Aug 26 00:00:45 localhost create-vm.sh[1906]: + VM_DISK=/opt/openshift-network-playground/libvirt/master0/master0.img
Aug 26 00:00:45 localhost create-vm.sh[1906]: + VCPU=4
Aug 26 00:00:45 localhost create-vm.sh[1906]: + MEMORY=16384
Aug 26 00:00:45 localhost create-vm.sh[1906]: + NETWORK1=bridge=provisioning,mac=52:54:00:11:22:b1
Aug 26 00:00:45 localhost create-vm.sh[1906]: + NETWORK2=bridge=baremetal,mac=52:54:00:11:22:a1
Aug 26 00:00:45 localhost create-vm.sh[1911]: ++ /usr/sbin/ip r
Aug 26 00:00:45 localhost create-vm.sh[1912]: ++ grep default
Aug 26 00:00:45 localhost create-vm.sh[1913]: ++ awk '{print $9}'
Aug 26 00:00:45 localhost create-vm.sh[1914]: ++ head -n 1
Aug 26 00:00:45 localhost create-vm.sh[1906]: + HOST_IP=


Passing a non-email user_id field could give a clearer error.

Expected Behavior
The following code should work:
  track('Button Clicked 2', undefined, {
            user_id: 'Anonymous',
        });

Current Behavior
It appears that passing a user_id that is not an email address causes an error. I get this in my logs:
Amplitude Logger [Error]: Event rejected due to exceeded retry count
Amplitude Logger [Debug]: {
  "type": "invoke public method",
  "name": "track",
  "args": [
    "Button Clicked 2",
    null,
    {
      "user_id": "Anonymous"
    }
  ],
  "stacktrace": [
    "at Analytics.trackMessageInference (/Users/aleppard/frank/one/Frank_Slack/queue_consumer/dist/.common/analytics.js:33:36)",
    "at Object.run (/Users/aleppard/frank/one/Frank_Slack/queue_consumer/dist/runSlackMessageInference.js:107:19)",
    "at processTicksAndRejections (node:internal/process/task_queues:96:5)",
    "at async handleSQSEvent (/Users/aleppard/frank/one/Frank_Slack/queue_consumer/dist/app.js:51:13)",
    "at async poll (/Users/aleppard/frank/one/Frank_Slack/queue_consumer/dist/poll.js:47:9)"
  ],
  "time": {
    "start": "2023-03-22T22:58:06.136Z",
    "end": "2023-03-22T23:00:15.903Z"
  },
  "states": {
    "before": {
      "config.apiKey": "b8e03107dbf9088cf67165fca4ae0eab",
      "timeline.queue.length": 0
    },
    "after": {
      "config.apiKey": "b8e03107dbf9088cf67165fca4ae0eab",
      "timeline.queue.length": 0
    }
  }
}

This threw me as I didn't realise the problem it was having was the user_id. Changing the user_id to<EMAIL_ADDRESS>works for me.
Possible Solution
Obviously for me I can just pass an email looking field which will fix the problem.
Steps to Reproduce
As documented above.
Environment

Node 16
"@amplitude/analytics-node": "^1.1.0",
Yarn

Hi @andrewfrankcare, thanks for using Amplitude.
"Anonymous" is a reserved/invalid keyword. Amplitude TS Node SDK uses HTTP V2 API. You can refer HTTP V2 doc for more requirements of user Id and device Id


Add request timeout

This change adds a bit around timeout behavior.
First, there didn't seem to be an obvious way to set up a default request_timeout, so a keyword argument is added to AsyncHttpConnection. This will get passed through from constructing an AsyncElasticsearch instance.
Second, when a timeout occurs, it's possible that no body exists on the response object. This causes the callback to fail with unexpected error. A check has been added against the body being None to bypass this.

Any idea when this can be merged through? We'd like to set a custom timeout without having to resort to a custom build.


training accuracy 0.5, and didn't change

(tensorflow) forensics@forensics-hdu:~/CGvsPG/pycodes$
(tensorflow) forensics@forensics-hdu:~/CGvsPG/pycodes$
(tensorflow) forensics@forensics-hdu:~/CGvsPG/pycodes$ CUDA_VISIBLE_DEVICES=0 python model.py
random initialisation ...
('   random seed =', 2665)
config=Personal
('   tensorFlow version: ', '1.4.1')
Check-points directory : /home/forensics/CGvsPG/pycodes/weights/
Summaries directory : /home/forensics/CGvsPG/pycodes/summaries/
Visualizations directory : /home/forensics/CGvsPG/pycodes/visualization/
import data : image_size = 100x100...
('     number of classes :', 2, '   ', ['Real', 'CGG'])
 train data

('    ', 'Real', 20000, 'images loaded')
('    ', 'CGG', 20000, 'images loaded')
 test data

('    ', 'Real', 2000, 'images loaded')
('    ', 'CGG', 2000, 'images loaded')
 validation data

('    ', 'Real', 1000, 'images loaded')
('    ', 'CGG', 1000, 'images loaded')
 shuffle lists ...

create model ...
Model with statistics.
Creating layer 1 - Shape : 5x5x3x32
Creating layer 2 - Shape : 3x3x32x32
Creating layer 3 - Shape : 3x3x32x64
Creating feature extraction layer
Creating MLP
setup loss function and optimizer ...
test ...
model created.
Choose a name for the run : gogogo
start session ...
2018-01-22 14:31:17.462880: I tensorflow/core/platform/cpu_feature_guard.cc:137] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2 AVX AVX2 AVX512F FMA
2018-01-22 14:31:17.716957: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1030] Found device 0 with properties:
name: GeForce GTX 1080 Ti major: 6 minor: 1 memoryClockRate(GHz): 1.683
pciBusID: 0000:17:00.0
totalMemory: 10.91GiB freeMemory: 10.76GiB
2018-01-22 14:31:17.716987: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1120] Creating TensorFlow device (/device:GPU:0) -> (device: 0, name: GeForce GTX 1080 Ti, pci bus id: 0000:17:00.0, compute capability: 6.1)
variable initialization ...
 I have fixed this issue by changing the parameter.
define a single-image classifier
clf = Model(database_path, image_size, config='Personal', filters=[32, 32, 64],
batch_size=50, feature_extractor='Stats', remove_context=True,
remove_filter_size=5, only_green=False)
trains the classifier and test it on the testing set
clf.train(nb_train_batch=800*5,
nb_test_batch=80,
nb_validation_batch=40)

Furthermore, there are several questions I want to know. What parameter do you set for the article (WIFS2017, Distinguishing Computer Graphics from Natural Images Using Convolution Neural Networks)? I want to compare my method with your work.

converted RAW to JPEG format (compression rate is 95%) ?
only green channel are used in the method of the wifs2017 paper?

Thanks for you work again.

Hi,
Can you tell me which parameter you changed in the definition of the model in order to make it work? Maybe it is an error that I can fix directly.
Furthermore, if you want to use the implementation of the WIFS article, you should set remove_context = False and only_green = True. This repository includes some extensions of our work which are not published yet...
To answer your questions:

I answered the RAW to JPEG compression question in this issue.
Yes we only used the green channel in the WIFS paper.

in CGvsPhoto/examples/test_pipeline.py:     clf.train(nb_train_batch = 1,
I think it should be like the following:
define a single-image classifier
clf = Model(database_path, image_size, config='Personal', filters=[32, 64],
batch_size=50, feature_extractor='Stats', remove_context=False,
remove_filter_size=5, only_green=True)
trains the classifier and test it on the testing set
clf.train(nb_train_batch=800*20,
nb_test_batch=40,
nb_validation_batch=20)


Make Clean_Transformer_Demo.ipynb (linked in README) compatible with the latest version of TransformerLens

Hi Neel,
I successfully ran the Clean_Transformer_Demo.ipynb on Google Colab. However, when I ran it on my laptop (Ubuntu 21.x Linux Box), there was an error in the GPT2 check after the Attention layer. Here is the error, which seems to imply that the forward method of the attention model of GPT2 requires two arguments. I don't understand how the results could be different on two systems, UNLESS GPT2 is different, which seems unlikely. Any ideas? Thanks.
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
[/tmp/ipykernel_753165/3913931317.py](https://file+.vscode-resource.vscode-cdn.net/tmp/ipykernel_753165/3913931317.py) in ()
     64
     65 rand_float_test(Attention, [2, 4, 768])
---> 66 load_gpt2_test(Attention, reference_gpt2.blocks[0].attn, cache["blocks.0.ln1.hook_normalized"])
     67
     68 # In gpt2 requires: forward() missing 2 required positional arguments: 'key_input' and 'value_input'

[/tmp/ipykernel_753165/545637326.py](https://file+.vscode-resource.vscode-cdn.net/tmp/ipykernel_753165/545637326.py) in load_gpt2_test(cls, gpt2_layer, input_name, cache_dict)
     34     output = layer(reference_input)
     35     print("Output shape:", output.shape)
---> 36     reference_output = gpt2_layer(reference_input)
     37     print("Reference output shape:", reference_output.shape)
     38

[~/src/2022/TransformerLens/.venv/lib/python3.8/site-packages/torch/nn/modules/module.py](https://file+.vscode-resource.vscode-cdn.net/home/erlebach/src/2022/TransformerLens/clean_transformer/~/src/2022/TransformerLens/.venv/lib/python3.8/site-packages/torch/nn/modules/module.py) in _call_impl(self, *input, **kwargs)
   1192         if not (self._backward_hooks or self._forward_hooks or self._forward_pre_hooks or _global_backward_hooks
   1193                 or _global_forward_hooks or _global_forward_pre_hooks):
-> 1194             return forward_call(*input, **kwargs)
   1195         # Do not call functions when jit is used
   1196         full_backward_hooks, non_full_backward_hooks = [], []

TypeError: forward() missing 2 required positional arguments: 'key_input' and 'value_input'

The google colab is using this older branch of the TransformerLens code: https://github.com/neelnanda-io/TransformerLens/tree/clean-transformer-demo (way back when the library was called EasyTransformer).
You should either use that branch locally, or not use the Clean_Transformer_Demo.ipynb. I think we should rename this issue "Add Clean_Transformer_Demo.ipynb to the current repo". How does that sounds?

Thanks. Perhaps the do cumbersome should mention the branch that corresponds to the Clean_Transfirmer_Demo.ipynb? How could I have figured this out?

@erlebach the relevant line from the colab is
%pip install git+https://github.com/neelnanda-io/Easy-Transformer.git@clean-transformer-demo

this doesn't install the latest TransformerLens, but a specific branch.
I've made this an issue for the current milestone and changed the title to reflect the change I'd like to see.

@ArthurConmy : Thank you. My bad. I should have paid more attention.

I installed the branch in a separate repository, and ran the EasyTransformer_Demo  in the environment of TransformerLens. The code ran perfectly on the Ubuntu system. There was no error in the attention model. So I do not understand how that is possible, since the gpt2 model retrieved presumably came from within the virtual environment of TransformerLens.  The Attention class was identical in the two transformer codes I ran. Conceptually, how can I get an error in one code and not the other assuming they are both using the same gpt2 model? Thanks for any advice.

Arthur added a PR that changes the internal implementation of the model, so
attention layers have separate inputs for query, key and value. The testing
code uses a particular layer of the model, and isn't adapted to use the new
interface. It wouldn't be that hard to fix in the code
Possibly we should set it so that if ONLY query input is given, key and
value are also set to that?
On Sun, 21 May 2023, 5:33 pm Gordon Erlebacher, @.***>
wrote:

I installed the branch in a separate repository, and ran the
EasyTransformer_Demo in the environment of TransformerLens. The code ran
perfectly on the Ubuntu system. There was no error in the attention model.
So I do not understand how that is possible, since the gpt2 model retrieved
presumably came from within the virtual environment of TransformerLens. The
Attention class was identical in the two transformer codes I ran.
Conceptually, how can I get an error in one code and not the other assuming
they are both using the same gpt2 model? Thanks for any advice.
—
Reply to this email directly, view it on GitHub
https://github.com/neelnanda-io/TransformerLens/issues/283#issuecomment-1556220333,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASRPNKMHKO7FC4ULBOGY2V3XHI7WLANCNFSM6AAAAAAYJJ7IHI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks. Yes, I saw the differences in the components/ folder. Perhaps include an updated version of the Easy_Transfirmer_Demo in the repository?

@erlebach Sorry about this. We have recently reviewed them all in an open PR and I'm trying to find people who can validate they are currently working as expected. Please continue to raise any issues if you have them and we'll make sure you're unblocked.

@erlebach can you please let me if you are blocked by this, otherwise I might close the issue in a couple of days.

Note that Callum McDougall has an updated version of the tutorial here:
https://transformerlens-intro.streamlit.app/Transformer_from_scratch
On Mon, 22 May 2023 at 09:21, Joseph Bloom @.***> wrote:

@erlebach https://github.com/erlebach can you please let me if you are
blocked by this, otherwise I might close the issue in a couple of days.
—
Reply to this email directly, view it on GitHub
https://github.com/neelnanda-io/TransformerLens/issues/283#issuecomment-1556761923,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASRPNKP4AES4BZBBVNHVRHDXHMOYRANCNFSM6AAAAAAYJJ7IHI
.
You are receiving this because you commented.Message ID:
@.***>

Hi, with your help, I am unblocked. I basically have to update the testing for the Attention component since the forward method now takes three identical arguments (for self-learning). You can close the issue.


[bug] - Can't connect to coin98 wallet

Link to minimal reproducible example
https://share.cleanshot.com/FrvQWdTM
Summary
Hi there! Good day to all of you!
First of all, thanks for creating this library. It's great, and I love using it in my project.
I'm currently facing an issue where I can't connect to the Coin98 wallet. I scanned the QR code from my app, but nothing happened afterwards.
Here is a screen recording: https://share.cleanshot.com/FrvQWdTM
When I click on Coin98, I scan the QR code, and the connection request appears on my phone, but nothing happens after I click 'Accept Connection'.
List of related npm package versions
"@wagmi/core": "^1.2.0",
"@walletconnect/web3-provider": "^1.8.0",
"@web3modal/ethereum": "^2.4.5",
"@web3modal/html": "^2.4.5",

Nothing looks out of the ordinary, but I'd recommend this:

Remove @walletconnect/web3-provider (this is not needed in web3modal wagmi, are you using it for anything in particular?)
Update to latest web3modal versions (remove ^ from your package.json just in case to use strict versions)
Test with another wallet, does that work? If so, it could be an issue with coin98 wallet not supporting some of your proposed chains maybe.

I've upgraded to 2.7.0 and now I'm having this issues, also I have read the docs whether or not something is changed, but I've followed everything on it,

This happens when you have missmatch in wagmi / modal versions, try again via deleting you .lock file and re-installing. Alternatively this could mean that you are calling some modal functions that are not documented / before modal is initialized.

ok now I can open the modal but still can't connect to coin98, so you believe it's the error from their side?

Could be, do you see any error logs on dapp side after attempting to connect, usually wallets should send an error code and a message if something went wrong. Also some wallets had issues reading that "white on black" qrcode, on android phones, however now that you are updated to latest versions, you should always have "black on white".
Other than this, likely an issue on coin98 side.

Ok after upgrading, I can connect to it, thanks man!

sorry actually I still have problem with connecting directly with the coin98 app, it works with QR but when doing directly from their app, I just got 'Tap open to continue' and a loading screen, nothing is happened.. @0xAsimetriq

oh actually, when I click on "coin98" on mobile, it directs me to metamask rather than coin 98, is there a possible bug there?
https://github.com/WalletConnect/web3modal/assets/58819726/9d065a90-223e-43e4-833e-d2c409328b20

I just looked at their data in https://cloud.walletconnect.com and they have set wrong deeplink i.e. they added wc:// instead of coin98:// (or whatever theirs is). We'll reach out to them, but after that it depends how fast they resolve the issue. Will close this, as it is not web3modal related / wallet needs to fix their data.


Better support for updates to the Antrea base docker images

At the moment we have a CRON job running as a Github workflow which periodically (every 12 hours) updates the antrea/openvswitch and antrea/base-ubuntu Docker images. These images are then used in all CI builds, whenever we need to build the antrea/antrea-ubuntu image. This includes tests, but also jobs which update the antrea/antrea-ubuntu image (whenever the master branch is updated or a release tag is created).

This is sub-optimal and can be misleading, as it means that we sometimes push a Docker image tag which doesn't completely match the Dockerfiles (e.g. https://github.com/vmware-tanzu/antrea/blob/master/build/images/base/Dockerfile) which are checked into the repository: there can be up-to a 12 hour lag, and in the case of releases, we only ever build the Docker image tag once.

Another issue is that when someone submits a PR to update one of the Dockerfiles for a base image, that image needs to be built and pushed manually to ensure that CI tests run correctly. And of course, the image will be overwritten every 12 hours and ends up being used by other CI jobs...

This was meant to speed up builds by removing the need to rebuild the base image (and the antrea/openvswitch image, which is very expensive to build) too frequently, while at the same time ensuring that we pick up security patches in Ubuntu frequently enough. However, we may be able to achieve a similar result by leveraging Docker caching (the repo on Dockerhub can be used as the cache); this needs to be investigated. At the very least, we should consider building the base image for Antrea release builds, to ensure that it is completely up-to-date - even though that option will not help with issue 2) above.

This issue can be considered fixed. We now build all base images (leveraging Docker caching to reduce build times) for all Github workflows and Jenkins jobs.


[Segment Replication] Primary promotion on shard failing during node removal in RoutingNodes#failShard

Coming from https://github.com/opensearch-project/OpenSearch/issues/3988 where RoutingNodes#failShard was identified as another workflow where master eagerly promotes replica as part of node removal workflow. failShard method is also handles cluster state updates (e.g. assigned shards etc).

Broken down tasks in following sub-tasks:

[ ] Identify cause of two different failover mechanism i.e. PrimaryShardAllocator & RoutingNodes#failShard

[x] Code scan to identify cause of separate failover handling
[ ] Test if returning empty from activeReplicaWithHighestVersion doesn't cause shard failure (red cluster) and shard promotion works (with minor delay)
[ ] Identify is RoutingNodes#failShard can be removed all together.

[ ] Write a unit test with 1p and 2 replica on different checkpoints. Fail primary and check replica is promoted irrespective of replica's checkpoint state.
[ ] Add transport calls to active replicas to fetch shard state via AsyncShardFetch. This can be achieved by abstracting logic added in https://github.com/opensearch-project/OpenSearch/pull/4041
[ ] Update RoutingNodes#failShard to use the ReplicationCheckpoint info to select relica with highest RC
[ ] Ensure unit tests intially written passes, add more unit tests
[ ] Milestone 1. Primary promotion with segrep happy path works
[ ] Wait for https://github.com/opensearch-project/OpenSearch/issues/3989 or add stub to prevent failure during primary promotions
[ ] Write thorought integration tests around replica promotion as its a core change
[ ] Fix new bugs if any

Using AsyncShardFetch for RoutingNodes#failShard may not work as it start asynchronous workflow to recovery whereas existing mechanism uses cluster state to choose one of the active replicas. There are two options here:

Update ClusterState to add ReplicationCheckpoint info for each shard. This will be a log bigger change and is not really necessary as these checkpoints are used only during failover.
Use sync workflow to pull shard's ReplicationCheckpoint.

I am planning to move forward with option 2 above.
CC @Bukhtawar @mch2 @andrross

Using AsyncShardFetch for RoutingNodes#failShard may not work as it start asynchronous workflow to recovery whereas existing mechanism uses cluster state to choose one of the active replicas. There are two options here:

Update ClusterState to add ReplicationCheckpoint info for each shard. This will be a log bigger change and is not really necessary as these checkpoints are used only during failover.
Use sync workflow to pull shard's ReplicationCheckpoint.

I am planning to move forward with option 2 above.
CC @Bukhtawar @mch2 @andrross

I think 2 is the best option given we want this as a best effort.  I also wouldn't be worried about it delaying shard promotion right now, we can set timeouts to reduce that impact and measure the total time.

During standup discussion among @mch2 @kartg, we decided to take up this issue as part of next minor release and focus on existing open bugs in https://github.com/opensearch-project/OpenSearch/issues/3969 which have higher priority. This work basically is an optimization work which reduces the segment files copies amoung repilcas.
CC @CEHENKLE @anasalkouz @mch2

Discussed this during team standup, where we identified that we need to get data around segment replication performance when furthese ahead replica is not chosen. This is to also to evaluate the trade off we will get with implementing this core change.
CC @mch2 @anasalkouz @Bukhtawar

@dreamer-89 @mch2 this is tagged for 2.5. Can we make it ?

@dreamer-89 @mch2 this is tagged for 2.5. Can we make it ?

Thank you @saratvemulapalli for bringing this up. This work will not make into 2.5.0 release, removing the tag.
From previous discussion, this is an optimization task which tries to select the replica with highest checkpoint (this ensures minimum file copy ops from new selected primary). We also don't have data around how bad this I/O can go if we do not select the replica with highest replication checkpoint. Based on this, prioritizing existing GA task over this.
CC @mch2


is love2dcs cross platform when using .net core 2?

I have a simple question.
is love2dcs cross platform when using .net core 2?

no, it only work on windows platform .

ahh ok that's too bad hopefully in the future it will be cross platform

Okay, maybe he'll be able to do it in the future, but maybe it shouldn't be urgent.

Hi, any update?  is macOS supported?
if not, so pity, so many love2d developers use macOS.


How to send a message from inside a static worker to the main thread without having received a message first?

I'm a bit stumped on this one. I have a worker.ts script which contains the code that runs in a Web Worker. Sometimes, I want to send messages from the Worker to the main thread, without having received a message from the main thread (i.e. not in response to an existing message).
I cannot find a way to do this. In my worker I create a StaticEasyWebWorker like so:
const easyWorker = new StaticEasyWebWorker<WorkerMessage, WorkerResponse>();

However on easyWorker there is no method to send.
Do you have any suggestions?

To add detail to my request, I want to enable two-way communication between my worker and the main thread, allowing the worker to initiate sending messages and receive responses from the main thread. This should closely resemble the existing communication setup initiated by the main thread.

Hi @gabrielecirulli,
I'm sorry for the late response. Currently, easy-worker does not support messages with cancelable promises from inside the worker to the main thread.
Even so, let's try to solve this:
The first thing you're going to need is to use the parameter: "keepAlive", so the worker will be initialized immediately without the need for messages.
Then:

You can access the worker directly, so if no other configuration was added, there should be just one worker in the workers array.

const [worker] = easyWorker.workers;

Once you have the worker instance, you can wrap the default message handler and add whatever you need.
const { onMessage: onMessageBase } = worker;

worker.onMessage = (event: MessageEvent<IMessageData<TPayload>>) => {
  const { someFlag } = event.data;

  if (!someFlag) return onMessageBase(event);

  // your custom handler.

}

This option basically allows you to unblock whatever you need.
Another option that came to my mind is related to the fact that the messages do not expire. So, if you have just one process that eventually is going to resolve from inside the worker to the main thread, you can cache the first message inside the worker and resolve it once all the necessary conditions are met.
const worker = createEasyWorker();

worker.send().then(() => {
   // this promise will be alive as long as the worker is alive, so it can be resolved at any moment from inside the worker
});

Another option, depending on what you need, is to use the reportProgress method. So, again, having an open message, and from inside the worker, you can actually report as many times as you wish to the onProgress callback in the main thread. Example:
const worker = createEasyWorker();

worker.send().onProgress(() => {
    // this callback could be executed as many times as you wish from inside the worker as long as the message is not resolved

    // executes as many times as you want
}).then(() => {
  // executes just once
});

// Inside the worker:

const payload = {} // whatever you need

// this can be called multiple times
openMessage.reportProgress(0, payload, transferables);

I hope these options help in addressing your concerns.

Thank you for your response! In the end I wrote my own library, with two way fully typed RPC with promises (the only difference is they're not cancelable, I still haven't figured out the use case for that) and I also added event emitters and listeners as a bonus. I haven't open sourced it, I may do so later on.


Study panels should be expanded by default

Either the study panels should be expanded by default, or there should be an option to open all panels.

Completed in #231


Minify is niet minified in de browser. Hoe kan dat?

Mijn minified code in de code editor:

Bron in de browser:

Hoe kan dat???!

In the developer tools of modern browsers like Chrome or Firefox, the source code is often presented in a formatted and readable form, even if it was originally minified or obfuscated. This is done to assist developers in debugging and understanding the code during the development process.
While the source code may not appear minified in the browser's developer tools, it is still executed as the minified version. The browser interprets and executes the minified code, resulting in the same optimized performance as the minified version.
It's important to remember that the way the code is displayed in the browser's developer tools doesn't always match its actual execution. The browser executes the minified code even if it appears as a formatted and readable version in the developer tools.


Making the footer attractive and linking its items

I will assign you this issue when DCP will start from 10th July.

Okay @QAZIMAAZARSHAD sir

I would like to work on footer. please assign this to me @QAZIMAAZARSHAD

I would like to work on footer. please assign this to me @QAZIMAAZARSHAD

Look for some other issues. This will be assigned to @aakankshabhende.

Please assign this issue to me under DCP.

I would like to work on this issue under DCP.

I would like to work on this issue under DCP.

Already assigned look for some other issues.

Can you please send social links of Apni Dukaan @QAZIMAAZARSHAD sir as I want to link them in footer.

@aakankshabhende this is just a demo website.
Social links do not exist, just link them to social pages.

Hi can i contribute to this if no one was assigned?

Please assign this issue to someone else @QAZIMAAZARSHAD sir

What happened @aakankshabhende you had already made the PR?


Clarify documentation for extra dictionaries

Reading the documentation, I initially thought I could simply pass an extra kwarg to AsynchronousLogstashHandler:
"You can also specify an additional extra dictionary in the logging configuration with static values like the application name, environment, etc. These values will be merged with any extra dictionary items passed in the logging call into the configured extra prefix."
But the docs must mean the Logging File Config. They don't mention using a LoggingAdapter- which is the other way I know of to do this. It'd be neat to have an example of this in the docs, since I think adding extras to the Logger as a whole is a use case just as large as adding them to individual calls.
Thanks for your work on python-logstash-async!

The extra kwarg is meant to be passed the formatter, not the handler.
I added some example code in https://github.com/eht16/python-logstash-async/pull/26, do you think this is enough?

#26 looks great, thanks a ton!


WalkingCat's diff engines

Hi @SimonCropp ,
Feel free to close this if you don't have interest.  I found https://github.com/WalkingCat/ today via Twitter, and he has a ton of good diff tools:

https://github.com/WalkingCat/SymDiff - Diff tool for comparing symbols in PDB files
https://github.com/WalkingCat/ExpDiff - Diff tool for comparing export tables in PE images
https://github.com/WalkingCat/MetaDiff - Diff tool for comparing the CLI metadata in .NET assemblies or WinMD files.
https://github.com/WalkingCat/ResDiff - Diff tool for comparing Win32 resources in PE images
https://github.com/WalkingCat/PriDiff - Diff tool for comparing resources in PRI (Package Resource Index) files

Is the feature request related to a problem
More features 🗡 ❤
Describe the solution
I am not familiar with how to implement a new DiffEngine provider.
Describe alternatives considered
Doing nothing.
Alternatively, for some of these, there may be Roslyn APIs and it may be better to write Verify snapshots for Roslyn API dumps instead.
Additional context

i am interested. are you using these tools?

also an fyi. u can programmatically add your own tools https://github.com/VerifyTests/DiffEngine/blob/master/docs/diff-tool.custom.md


Enhancement: Support for Vertex AI model 'gemini-1.5-pro-002'

What features would you like to see added?
hi guys,
Currently, the supported models are for Vertex AI are
# Vertex AI
# GOOGLE_MODELS=gemini-1.5-flash-preview-0514,gemini-1.5-pro-preview-0514,gemini-1.0-pro-vision-001,gemini-1.0-pro-002,gemini-1.0-pro-001,gemini-pro-vision,gemini-1.0-pro,gemini-1.5-pro-001

We would like to use the gemini-1.5-pro-002. We already tried and it resulted in an error while processing the response.  (We simply switched the model from gemini-1.5-pro-001 to gemini-1.5-pro-002).
See the attached Screenshot and the log entries.
Thanks and Cheers
dani
More details
Log Output:
2024-10-17T08:11:11.229Z debug: Creating VertexAI client
2024-10-17T08:11:11.236Z debug: [saveConvo] api/app/clients/BaseClient.js - saveMessageToDatabase #saveConvo
2024-10-17T08:11:18.338Z error: [handleAbortError] AI response error; aborting request: Aborted
2024-10-17T08:11:18.339Z warn: AI Response error for conversation a6f672c3-713e-4510-84d2-9b045d40a7e5 likely caused by Google censor/filter
2024-10-17T08:11:18.339Z error: [handleAbortError] error while trying to abort message Cannot set headers after they are sent to the client

Which components are impacted by your request?
No response
Pictures

Code of Conduct

[X] I agree to follow this project's Code of Conduct

works on my site:

works on my site:

Try with a longer prompt that will generate a longer completion. As you can in see the original post it works until a certain point where it stops generating.
I can confirm that I am seeing the same issue: https://github.com/danny-avila/LibreChat/discussions/4283
Similar here: https://github.com/danny-avila/LibreChat/discussions/4358

Thanks Danny.
Yet, I updated the app, but I still have the issue. What is strange is that the first completion was particularly long (whereas there used to be an error after a few lines). And when I tested even more while asking for an even longer response, the second completion crashed after a few lines. Same error code as before :

And I still the same error messages in the log.

Hi, yes I am also experiencing the same issue with the model -

@mansiibm you need to update, several users have confirmed the issue is fixed

Hi Danny thanks for replying, I am using the v07.6-rc1 version in the picture I shared above. Thanks

Tried on Vertex AI, using gemini-1.5-pro-preview-0409
https://www.librechat.ai/docs/local/docker#update-librechat


Update documentation for Augur Call/Transaction/Events APIs

Issue moved to AugurProject/docs #19 via ZenHub


Add KorNLU dataset

Added Korean NLU datasets. The link to the dataset can be found here and the paper can be found here
Note: The MNLI tsv file is broken, so this code currently excludes the file. Please suggest other alternative if any @lhoestq

[x] Followed the instructions in CONTRIBUTING.md
[x] Ran the tests successfully
[x] Created the dummy data

Nice thank you !
Can you regenerate the dataset_infos.json file ? Since we changed the features we must update it
Then I think we'll be good to merge :)


Internals part #1: platform backends

What does the pull request do?
Hides (almost) all of interface implementations and public API types that should be internal in these assemblies:

Avalonia.Android
Avalonia.Browser
Avalonia.iOS
Avalonia.Native
Avalonia.X11
Avalonia.FreeDesktop (ended up with no public members at all, as it is directly used from the Avalonia.X11)
Avalonia.Win32
Avalonia.Skia
Avalonia.Direct2D

Note, win32 automation COM interfaces weren't made internal, as whole automation stops working because of that. I couldn't figure it out quickly, so moved it out of this PR.
Also, it seems to not be possible to disabled resources generation from _UpdateAndroidResgen, so these 1800 lines of public API are still there.
It should be easier to review changes with this commit from API-listing generator branch: https://github.com/AvaloniaUI/Avalonia/commit/aeea42f9f6780bac75ea0e0bc9afef1dd3d95a9f
Part of https://github.com/AvaloniaUI/Avalonia/issues/6666

You can test this PR using the following package version. 11.0.999-cibuild0029978-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

Note, win32 automation COM interfaces weren't made internal, as whole automation stops working because of that.

Yeah I ran into this: it seems that COM interfaces need to be public to work with the inbuilt COM interop? A pretty strange requirement, and one that I've not actually seen documented anywhere. @jkoritzinsky maybe you might have some insight here?
In the longer-term we need to move away from .NET's inbuilt COM support but that's not possible yet.

It looks like the interfaces are marked [ComVisible(true)]. The ComVisible attribute depends on visibility. Since you're consuming these interfaces instead of authoring them (aka Windows defines them, not you), you should mark them with [ComImport] instead of [ComVisible(true)]. Then it should work.


librime: 1.7.2 -> 1.7.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/librime/versions.
meta.description for librime is: "Rime Input Method Engine, the core library"
meta.homepage for librime is: "https://rime.im/"
meta.changelog for librime is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/b6v103h60jwn8g2ma2xcp5654x5zz9y1-librime-1.7.3/bin/rime_deployer passed the binary check.

/nix/store/b6v103h60jwn8g2ma2xcp5654x5zz9y1-librime-1.7.3/bin/rime_dict_manager passed the binary check.

/nix/store/b6v103h60jwn8g2ma2xcp5654x5zz9y1-librime-1.7.3/bin/rime_patch passed the binary check.

2 of 3 passed binary check by having a zero exit code.

1 of 3 passed binary check by having the new version present in output.

found 1.7.3 with grep in /nix/store/b6v103h60jwn8g2ma2xcp5654x5zz9y1-librime-1.7.3

found 1.7.3 in filename of file in /nix/store/b6v103h60jwn8g2ma2xcp5654x5zz9y1-librime-1.7.3

directory tree listing: https://gist.github.com/502777dcda46cceed0a522f3a9ec3f7e

du listing: https://gist.github.com/6e8b2447f427f8de5c08e5211d37e08b

Rebuild report (if merged into master) (click to expand)

15 total rebuild path(s)

5 package rebuild(s)

5 x86_64-linux rebuild(s)
5 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
5 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
brise
fcitx-engines.rime
fcitx5-rime
ibus-engines.rime
librime

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/b6v103h60jwn8g2ma2xcp5654x5zz9y1-librime-1.7.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A librime https://github.com/r-ryantm/nixpkgs/archive/4d0b5aa5c97a7d95d0a0d05a76f7115953435ccb.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/b6v103h60jwn8g2ma2xcp5654x5zz9y1-librime-1.7.3
ls -la /nix/store/b6v103h60jwn8g2ma2xcp5654x5zz9y1-librime-1.7.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages failed to build:

brise
fcitx-engines.rime
fcitx5-rime
ibus-engines.rime

1 package built:

librime

Maintainer pings
cc @sifmelcara for testing.

https://github.com/NixOS/nixpkgs/pull/126274#issuecomment-857226489

To me that looks like an error and other distros upgraded already as well https://repology.org/project/librime/versions

Result of nixpkgs-review pr 127078 at 4d0b5aa5 run on aarch64-linux 1

5 packages built successfully:

brise
fcitx-engines.rime
fcitx5-rime
ibus-engines.rime
librime


feat: pickup v2 protocol

Implemented pickup v2 protocol  along with unit testing for the implemented methods leaving room for future testing within the Mediation Recipient Module.

Codecov Report

Merging #711 (9195ec5) into main (dbcd8c4) will decrease coverage by 0.18%.
The diff coverage is 82.89%.

@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
- Coverage   86.18%   85.99%   -0.19%
==========================================
  Files         343      350       +7
  Lines        7454     7642     +188
  Branches     1156     1194      +38
==========================================
+ Hits         6424     6572     +148
- Misses       1029     1069      +40
  Partials        1        1

Impacted Files
Coverage Δ

packages/core/src/types.ts
100.00% <ø> (ø)

...ckages/core/src/modules/routing/RecipientModule.ts
69.62% <52.72%> (-2.32%)
:arrow_down:

...core/src/modules/routing/handlers/StatusHandler.ts
54.54% <54.54%> (ø)

...modules/routing/handlers/MessageDeliveryHandler.ts
58.33% <58.33%> (ø)

...core/src/modules/routing/messages/StatusMessage.ts
93.33% <93.33%> (ø)

...odules/discover-features/DiscoverFeaturesModule.ts
97.87% <95.83%> (-2.13%)
:arrow_down:

packages/core/src/agent/AgentConfig.ts
94.73% <100.00%> (+0.19%)
:arrow_up:

packages/core/src/agent/helpers.ts
100.00% <100.00%> (ø)

...ackages/core/src/modules/routing/MediatorModule.ts
79.54% <100.00%> (+1.49%)
:arrow_up:

...core/src/modules/routing/MediatorPickupStrategy.ts
100.00% <100.00%> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbcd8c4...9195ec5. Read the comment docs.

Is it correct this doesn't include the live delivery?

That's correct. We'd go ahead and implement it, but given ACA-Py's current logic for processing messages/queue/etc, this would be a more significant addition on that side of things. @dbluhm can probably communicate the specific issues better. So for as of right now this PR still just uses the trust ping response_requested: false mechanism within ACA-Py.

Also, it seems this doesn't include the mediator side of processing, is that right? I'm a bit reluctant to this approach as it means we can't e2e test the protocol. We already have this with revocation, but I'd like to keep this to a minimum. In addition I think it's important to not only have unit tests as we now don't have any guarantee it will actually work or we don't somehow break something in the future.

That's correct. From our side of things our needs plan on using ACA-Py as the mediator (with the acapy-pickup-plugin) so we don't have need for AFJ as a mediator--not to say we won't implement things out of our scope or that don't directly impact us but do benefit the project/community, but this does seem a little larger in scope to implement. Also, I know there's some things already implemented for being a mediator in AFJ that I'm not really familiar with that I think others likely would have better domain in.
So, I'd agree in that it'd be good to get the mediator portion of the protocol implemented for an E2E case. I know we'd be happy to help someone with that in testing/troubleshooting, etc. Does my hesitation to build both sides of the protocol make sense? Thoughts? (I'd like to know what you're thinking here) 🤔
Also, maybe it's worthwhile looking at some of our testing strategy to see if we can add an approach to better test the end to end case when we don't support part of a protocol?

In addition I think it's important to not only have unit tests as we now don't have any guarantee it will actually work or we don't somehow break something in the future.

Also, isn't this what the AATH is supposed to do? Or is the fact that it's separated enough mean it's insufficient for this problem?

In regards to changing the name of the status request method within the module we were thinking something along the lines of requestStatus, we are planning on running with that unless you had something more specific in mind.

Ok I've been thinking about it a bit more and maybe we should call it requestStatus, but not automatically send a message delivery request in the handler of the status message. This way an agent can choose to request the status of a message without being required to also pick up the messages.
We can then add an even listener (can be just the agent message processed event) that listens for a response message and triggers the pickup of messages -- but only if this is intended (so not when calling requestStatus, but do when initiating message pickup)
If we don't want to take this approach for now (understandable because more complex) I'd be in favour of not exposing this method in the public module until we actually allow to request the status without initiating message pickup

@TimoGlastra what's your thoughts on if we provide an agent config for whether or not to automatically followup with a delivery request message for status messages that default to true? This would require the initial message pickup to be manually triggered, but that may be a decent tradeoff for now?
We don't currently require the ability to send a status message from the public API, but we figured it'd be a good edition--so we're 100% good with keeping it private or using a config param (just figured I'd voice the option). Thoughts?

What work, if any, needs to be done before we can get this finalized and pulled in? As far as the naming scheme goes on your previous comment I think something like openWebsocketAndPickup sounds appropriate, if that is the only thing holding us up at this point let me know and I can get that change in today. Thank you for your time.

@TimoGlastra what's your thoughts on if we provide an agent config for whether or not to automatically followup with a delivery request message for status messages that default to true? This would require the initial message pickup to be manually triggered, but that may be a decent tradeoff for now?

Maybe we can keep it private for now and automatically pick up the messages? Then if we later have more knowledge on the usage patterns of pickup v2 and the status messages we can update accordingly. I think a global parameter may not be the right cut-off for configuration as sometimes you do want to pick up afterwards (when you want to retrieve all messages), and sometimes you just want to have the status.

What work, if any, needs to be done before we can get this finalized and pulled in? As far as the naming scheme goes on your previous comment I think something like openWebsocketAndPickup sounds appropriate, if that is the only thing holding us up at this point let me know and I can get that change in today. Thank you for your time.

Changing the method name seems fine to me for now. We can look at reoganizing and splitting up the mediation module later on to make it all a bit easier to understand and follow.

Okay, fixed all the unit tests and updated to main, ready to merge.

@KolbyRKunz can you update the branch with main so we can merge? I can't do that when you create a PR from an organization.

@TimoGlastra Got main merged back in and pushed up.

Awesome, thanks! Should automatically merge once CI passes


Fix issues related to Seabird Bottle data and NetCDF output

The following pull request add fixes to handle better bottle data and improve
NetCDF ouput:
fCNV

Correct issue with some variable names that are too long (ex: Sbeox0Mm/Kg) and are missing white space in the SBEDataProcessing CNV Output. Data fails to be appropriately parsed otherwise.
Make variable name matching between the CNV and refnames.json non case sensitive. Some of the variables in refnames.json do no have the same case format as outputted by SBEDataProcessing and fail to be matched.
Try to import any attributes available in refnames.json related to a variable.
Make matching of refnames.json with variable non case sensitive.
Replace "attrs" by "attributes" in prepare_data method. Same as Pull Request #62

NetCDF

datetime.date, and datetime.datetime object variables converted to "seconds from 1970-01-01T00:00:00" format.
datetime.time variable converted to fraction of day
Add available variable attributes to the NetCDF

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines           61        61
=========================================
  Hits            61        61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23073b2...76ad038. Read the comment docs.


Harmonize parameter names across modules

source parameter in readers
dictionary parameter in projectors
data structure parameter

layer name
feature name
relation name
...

@mandiayba qu'est-ce que tu penses de:

source parameter in readers

source for all readers.

dictionary parameter in projectors

Not sure they have to be synced.

data structure parameter

somethingLayerName
somethingFeatureName
somethingRelationName
somethingSectionName

That means that parameters in the form somethingLayer or somethingFeature will be renamed.

Recensement des paramètres.

In progress in branch 115-harmonize-parameter-names-across-modules:
Parameter deprecation
Parameters can be declared deprecated. If a deprecated parameter is used in a plan, as alias, or in the command line, then AlvisNLP issues a message at severe level.
In the parameter name harmonization, some parameters were duplicated with a new name. The new and old parameter values are in sync, which means that the user can use either the new or the old parameter. However the old parameter is declared deprecated.
Reader source
All readers that have a single parameter for the source. This parameter is named source.
Data structure pointers

sections: someSection
relations: someRelation
arguments: someRole
layers: someLayer
features: someFeature

Parameters like someLayerName, someRelationName, someFeatureKey, etc. are now deprecated. You can still use them but their support may be discontinued.
Documentation
Documentation is now checked:

that parameters for data structure pointers have the structure described above,
that deprecated parameters indicate the new parameter in its documentation,
that parameter mentions in the module documentation reference an actual documented parameter.

Support was dropped for parameter documentation hardcoded in the Java class.
Miscellanous
Unused @Param and @AlvisNLPModule properties were removed because never used.


--connection  option of database update is not supported

It seems like the --connection option of dotnet ef database update is not supported any more in version 3.1.5.
Is there an alternative?
> dotnet ef database update --help

Usage: dotnet ef database update [arguments] [options]

Arguments:
  <MIGRATION>  The target migration. If '0', all migrations will be reverted. Defaults to the last migration.

Options:
  -c|--context <DBCONTEXT>               The DbContext to use.
  -p|--project <PROJECT>                 The project to use.
  -s|--startup-project <PROJECT>         The startup project to use.
  --framework <FRAMEWORK>                The target framework.
  --configuration <CONFIGURATION>        The configuration to use.
  --runtime <RUNTIME_IDENTIFIER>         The runtime to use.
  --msbuildprojectextensionspath <PATH>  The MSBuild project extensions path. Defaults to "obj".
  --no-build                             Don't build the project. Only use this when the build is up-to-date.
  -h|--help                              Show help information
  -v|--verbose                           Show verbose output.
  --no-color                             Don't colorize output.
  --prefix-output                        Prefix output with level.

> dotnet ef database update --version
Entity Framework Core .NET Command-line Tools
3.1.5

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 263f21d6-6edc-7582-e0e2-fa1c9670bcc0
Version Independent ID: b3dd8c84-18b1-f98d-64f1-7897d1482692
Content: EF Core tools reference (.NET CLI) - EF Core
Content Source: entity-framework/core/miscellaneous/cli/dotnet.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @bricelam
Microsoft Alias: bricelam

It is available in 5.0 release https://github.com/dotnet/efcore/issues/10750

Ah. Thanks. I didn't realize that.
Another reason to upgrade.

Hi everyone, I came across this issue with 3.1.5 where i too got the --connection <CONNECTION> option of database update is not supported
If you go to the section Known issue with --connection... in this article i pulled together to explain my experience of this,   you'll see how I updated my appsettings.json connection string on the fly, in the pipeline, and then running dotnet ef database update.  Here's the link: https://markpatton.cloud/2020/07/03/entity-framework-core-migrations-in-azure-devops/
Hope you find it useful.


cocoapods-beta: 1.8.4 -> 1.9.0.beta.1

Motivation for this change
https://github.com/CocoaPods/CocoaPods/releases/tag/1.9.0.beta.1
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Thanks!


Refactor Folder Structure for Better Scalability and Maintenance

I have noticed that the current folder structure has all files inside the src and components folders, which might hinder scalability and maintainability as the project grows. To improve long-term sustainability, I propose refactoring the folder structure by:

Organizing components based on features and functionality (e.g., features, common, utils, etc.)
Creating clear separation for styles, hooks, services, and other utilities.
Structuring files in a way that facilitates easier navigation and code management.

This will make the project more modular and easier for future contributors to understand and maintain.
I would like to take up this refactoring task and implement the necessary changes. Please let me know your thoughts, and if this aligns with your vision for the project, I would appreciate it if you could assign this issue to me. Looking forward to your feedback!

Thanks for giving your invaluable time to this project!
Your approach is correct, and we appreciate refactoring the code to properly organize the file and code. We assign this issue to you under hacktoberfest

Thanks, I'll make sure the structure is scalable and follows best practices!

I've created the PR for the issue! @KrimsonSquad @devsdenepal


ICSharpCode.SharpZipLib.Zip.ZipException Wrong Local header signature

Full error: ICSharpCode.SharpZipLib.Zip.ZipException: 'Wrong Local header signature: 0x1861C282'
Thrown at the s.GetNextEntry() point below
ZipInputStream s = new ZipInputStream(File.OpenRead(zipPathAndFile));
if (password != null && password != String.Empty)
	s.Password = password;
ZipEntry theEntry;
string tmpEntry = String.Empty;
while ((theEntry = s.GetNextEntry()) != null) {

It doesn't seem to be an error with actual zip file, 21 files out of 39 unzip ok, it just gets stuck on one (always the same one).
Here's some info from a QuickWatch on the "s" variable (ZipInputStream) and "theEntry" (ZipEntry)
s	{ICSharpCode.SharpZipLib.Zip.ZipInputStream}	ICSharpCode.SharpZipLib.Zip.ZipInputStream
		Available	0	int
		CanDecompressEntry	false	bool
		CanRead	true	bool
		CanSeek	false	bool
		CanTimeout	false	bool
		CanWrite	false	bool
		IsStreamOwner	true	bool
			Length	's.Length' threw an exception of type 'System.InvalidOperationException'	long {System.InvalidOperationException}
			Data	{System.Collections.ListDictionaryInternal}	System.Collections.IDictionary {System.Collections.ListDictionaryInternal}
			HResult	-2146233079	int
			HelpLink	null	string
			InnerException	null	System.Exception
			Message	"No current entry"	string
			Source	"ICSharpCode.SharpZipLib"	string
			StackTrace	"   at ICSharpCode.SharpZipLib.Zip.ZipInputStream.get_Length()"	string
			TargetSite	{Int64 get_Length()}	System.Reflection.MethodBase {System.Reflection.RuntimeMethodInfo}
			Static members
			Non-Public members
		Password	null	string
		Position	716099584	long
		ReadTimeout	's.ReadTimeout' threw an exception of type 'System.InvalidOperationException'	int {System.InvalidOperationException}
		WriteTimeout	's.WriteTimeout' threw an exception of type 'System.InvalidOperationException'	int {System.InvalidOperationException}
		csize	677686656	long
		inf	{ICSharpCode.SharpZipLib.Zip.Compression.Inflater}	ICSharpCode.SharpZipLib.Zip.Compression.Inflater
			Adler	0	int
			IsFinished	false	bool
			IsNeedingDictionary	false	bool
			IsNeedingInput	true	bool
			RemainingInput	0	int
			TotalIn	0	long
			TotalOut	0	long
			Static members
			Non-Public members
			inputBuffer	{ICSharpCode.SharpZipLib.Zip.Compression.Streams.InflaterInputBuffer}	ICSharpCode.SharpZipLib.Zip.Compression.Streams.InflaterInputBuffer
			Available	2165	int
			ClearText	{byte[4096]}	byte[]
			ClearTextLength	4096	int
			RawData	{byte[4096]}	byte[]
			RawLength	4096	int
			Non-Public members

theEntry	{CCCR.csv}	ICSharpCode.SharpZipLib.Zip.ZipEntry
		AESKeySize	0	int
		CanDecompress	true	bool
		CentralHeaderRequiresZip64	false	bool
		Comment	null	string
		CompressedSize	677686656	long
		CompressionMethod	Deflated	ICSharpCode.SharpZipLib.Zip.CompressionMethod
		Crc<PHONE_NUMBER>	long
		DateTime	{13/07/2021 10:39:02 PM}	System.DateTime
		DosTime<PHONE_NUMBER>	long
		ExternalFileAttributes	-1	int
		ExtraData	null	byte[]
		Flags	2056	int
		HasCrc	true	bool
		HostSystem	0	int
		IsCrypted	false	bool
		IsDOSEntry	true	bool
		IsDirectory	false	bool
		IsFile	true	bool
		IsUnicodeText	true	bool
		LocalHeaderRequiresZip64	false	bool
		Name	"CCCR.csv"	string
		Offset	0	long
		Size	0	long
		Version	20	int
		VersionMadeBy	51	int
		ZipFileIndex	-1	long
		Non-Public members
			AESEncryptionStrength	0	byte
			AESOverheadSize	12	int
			AESSaltLen	0	int
			CompressionMethodForHeader	Deflated	ICSharpCode.SharpZipLib.Zip.CompressionMethod
			CryptoCheckValue	180	byte
			EncryptionOverheadSize	0	int
			_aesEncryptionStrength	0	int
			_aesVer	0	int
			comment	null	string
			compressedSize	677686656	ulong
			crc<PHONE_NUMBER>	uint
			cryptoCheckValue_	180	byte
			dateTime	{13/07/2021 10:39:02 PM}	System.DateTime
			externalFileAttributes	-1	int
			extra	null	byte[]
			flags	2056	int
			forceZip64_	false	bool
			known	Size | CompressedSize | Crc | Time	ICSharpCode.SharpZipLib.Zip.ZipEntry.Known
			@method	Deflated	ICSharpCode.SharpZipLib.Zip.CompressionMethod
			name	"CCCR.csv"	string
			offset	0	long
			size	0	ulong
			versionMadeBy	51	ushort
			versionToExtract	20	ushort
			zipFileIndex	-1	long

Steps to reproduce

try to unzip a file created by java "jar" command. I will try and get an example file with no client specific information and add to this issue. This zip file is being created by a third party and I have no control over it. I'm trying to find out what version of java/jar is being used.

Expected behavior
This header signature of the file inside the zip should not throw an error, 7zip and DotNetZip handle it
Actual behavior
Exception thrown as above
Version of SharpZipLib
<IP_ADDRESS>
Obtained from

Package installed using NuGet

This is likely due to how ZipInputStream reads zip files. It doesn't use the "header" to locate the contents, since it's located at the end of the archive. That's why 7zip and DotNetZip are not affected.
See #642


Follow-ups from #6

Couple quick follow-ups from https://github.com/dylanbstorey/pyo3-pylogger/pull/6:

fix pyo3 version constraint - This should have been >=, not >, because 0.21 and 0.22 are compatible :)
version 0.2.2 -> 0.3.0 - to match the GitHub release

Merged  and released as 0.3.0 for real


Node and Ruby currently aren't working in C.I

#20 has links to the NodeJS related problems.
The Ruby problems were around some symlink already existing. Was able to reproduce if I spun up an instance and cloned down the repo onto it.

Issue created for the NodeJS problems https://github.com/bazelbuild/rules_nodejs/issues/1701

NodeJS build still not working after upgrading to latest of rules_nodejs.

Tracking issue: https://github.com/bazelbuild/rules_nodejs/issues/1701


Fix undotree() sequence number

Problem (reported by @machakann)
undotree().seq_cur shows wrong value after the certain operations.
Repro steps
vim --clean
:normal! Afoo
:normal! Abar
:undo
:normal! Abaz
:undo

then last undotree().seq_cur is:
expected: 1
actual: 2
[3] baz
 |[2] bar
 |/
[1] foo
[0]

In detail:
When going back to the common parent node from branches, seq_cur should be set to the parent node number, but just decreased.
Solution

Fetch seq_cur of the parent node instead of decreasing

Ozaki Kiichi

Codecov Report

Merging #2319 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2319      +/-   ##
==========================================
+ Coverage   74.45%   74.48%   +0.02%
==========================================
  Files          90       90
  Lines      132145   132148       +3
  Branches    29017    29019       +2
==========================================
+ Hits        98394    98425      +31
+ Misses      33722    33698      -24
+ Partials       29       25       -4

Impacted Files
Coverage Δ

src/undo.c
82.26% <100%> (+0.22%)
:arrow_up:

src/ex_cmds.c
77.78% <0%> (-0.09%)
:arrow_down:

src/gui.c
47.39% <0%> (ø)
:arrow_up:

src/gui_gtk_x11.c
47.7% <0%> (ø)
:arrow_up:

src/os_unix.c
53.46% <0%> (+0.04%)
:arrow_up:

src/term.c
50.94% <0%> (+0.05%)
:arrow_up:

src/terminal.c
65.19% <0%> (+0.06%)
:arrow_up:

src/window.c
81.48% <0%> (+0.09%)
:arrow_up:

src/if_py_both.h
76.59% <0%> (+0.14%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 462455e...b3c5592. Read the comment docs.


32 bits and 64 bits integer status

I am a bit confused by the status of 32 bits and 64 bits integers:

integer math operations exist in 32 bits or 64 bits version (like MIR_ADD and MIR_ADDS)
but memory move only exists in 64 bits version with MIR_MOV, why is that?

I my application I'm using  32 bits integers. How am I supposed to generate MIR code then?

You can consider MIR VM is 64-bit register machine.  32-bit insns work with only 32-bit part of 64-bit registers (vars).  What happens with another part of 64-bit register is not defined (for some environment another part can be not changed, for other environments another part can be zeroed etc).
That is why integer variables can be declared only as 64-bit integers.  Function parameter declaration is an exception used to declare how parameter passing.  Still integer parameters are 64-bit too.
For 64-bit registers, you need only 64-bit mov.  If you want to move 32-bit value with zeroing another part of 64-bit register you can use UEXT32.  To do move with sign extension you can use EXT32.
So MIR currently is oriented for efficient implementation on 64-bit machines.  But with small effort implementation on 32-bit machines  can be efficient too (of course if you use mostly 32-bit insns).
Originally MIR had no 32-bit insns.  But to implement 32-bit arithmetic a lot of extension insns would require (for insn operands and results). So I decided that it is easier to add 32-bit insns.

Thanks !
I've got some sound coming from the Faust => MIR translator ((-; more later.


time querying for the db

I think this should work.   {"time": {"gte": 1}}

[ ] Add tests showing how this works

@asampat3090  Check out the tests to see how range queries work.

@pennyfx  I made a comment on the commit, but how exactly would this be passed at the higher level? Are the query parameters supposed to be passed in in mongo db query format? that doesn't seem extensible to other query formats. Or we'll we have to maintain that this query format is what we will always be able to handle?

It seems to be pretty standard for document databases.
https://docs.mongodb.com/manual/reference/operator/query/
http://docs.couchdb.org/en/2.0.0/api/database/find.html


PrivateEndpointNetworkPoliciesFlag and PrivateLinkServiceNetworkPoliciesFlag explication

Hello,
I cannot find any documentation about what PrivateEndpointNetworkPoliciesFlag and PrivateLinkServiceNetworkPoliciesFlag exactly do and why it should be set to  Disabled ?
Add-AzVirtualNetworkSubnetConfig cmdlet does not say anything ether.
Thank you for any information!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 07670d4a-481b-3ca2-5db7-65ac07e2fa48
Version Independent ID: 1a273de0-68c0-b77f-c5de-a9c665a1ee34
Content: Create an Azure Private Endpoint using Azure PowerShell
Content Source: articles/private-link/create-private-endpoint-powershell.md
Service: private-link
GitHub Login: @malopMSFT
Microsoft Alias: allensu

@ivanignatiev
Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

We have description and how to's here
https://docs.microsoft.com/en-us/azure/private-link/private-endpoint-overview#limitations
https://docs.microsoft.com/en-us/azure/private-link/disable-private-endpoint-network-policy
https://docs.microsoft.com/en-us/azure/private-link/disable-private-link-service-network-policy

#please-close


Translate theme

Hello.
I want to translate the theme. In other themes there is languages directory with translation files. But in this theme there is no files. Why? This theme does not yet support translation? Or how do I get the default translation file with english word set to create a translation based thereon?

This theme is built for hexo 2.4 before and not update since that time.
When I were free, I will do something to support Hexo 3, especially for i18n.

@taur-firiath Hello, duo to https://github.com/hexojs/hexo-theme-landscape/pull/43 , now you can do your translation. please let me know whenever you have problem~

Hello @Xuanwo.
Thank you for creating the translation files. However, these constants are not used.
In #53 I change ejs files to use constants, add Russian language and add some additional constants.

Well, do you have a test? I'm busy in finishing homework now, and do not have time to test the changes in layout.

Of course I tested. But only on Russian language.

I‘m afraid of the use of __() func because I remember an issue report the problem of that.
And as you tested, Iwill merge it soon.

OK.
I just use Internationalization docs and Light theme code


fundingmanager: log raw transaction on broadcast

Fixes https://github.com/lightningnetwork/lnd/issues/4336.

@wpaulino needs rebase


ARROW-3182: [C++][Java] Gandiva merge into Arrow

Merging Gandiva CPP and Java into Arrow. The build is off by default.
Some things pending

Update the licenses.
Use Arrow CMake functions instead of Gandiva CMake functions.
Address mix of styles in the cmake files, Gandiva follows modern cmake targets and all of the dependencies seem to be direct references in Arrow. Follow on consistently.

@praveenbingo thanks for setting this up. A couple things

Step 1 (fixing licenses) is the necessary one to proceed with the IP clearance. Everything else is secondary. The sooner you do that, the sooner we can merge this and move forward with the other stuff

In addition to each of you submitting ICLAs to the Apache secretary, Dremio Corporation will need to submit a Software Grant Agreement for this software

It's a small detail but if you could use [Gandiva] instead of [GDV] in the commit logs, that would help with readability

On Step 3 regarding CMake targets, I would definitely like to modernize and improve our use of CMake, so we can work on that together after the merge

I'll fix the commit messages before merging. You're failing RAT checks. Can you add a license header to your README.md?

Sure Wes, done.

Can you fix the cpplint issues or do you want help with that?

We can also deal with the linting issues while the IP clearance vote is under way, so getting your CLAs in so we can do that is the urgent thing

I will fix the linting issues. Just caught up with some release tasks, so was hoping we can do that post-merge. But looks like CI does a style check on all cpp code and not just the ones being built. I will do this today or over the weekend.
Will send out the ICLAs for me, Ravindra and Vivek today.

All of us have sent the ICLA.

OK, I have seen 1 acknowledgement from the ASF secretary and will look out for the other 2. Should be able to start the IP clearance vote today, then, and then this can be merged on Monday

I started the IP clearance vote<EMAIL_ADDRESS>I can merge the patch after 72 hours have elapsed

The linting clean up is taking significantly more time than i anticipated. make format is not fixing the issues (even with the 6.0 version).
There are couple of files which has most of the issues.
I see two paths forward,

Exclude the two files for now and fix them as part of a different PR.
Wait for a while on the merge.

Wes - what do you recommend.

Would you like me to help?

Can you push whatever changes you have now and I'll take a look in about an hour or so

Pushed the latest i had.

Thanks. I'm about to give a talk but I'll report back a little later this morning (central europe time)

BTW I ran into https://issues.apache.org/jira/browse/ARROW-3331 when trying to build this

I should have the lint fixes pushed in ~10 minutes

There are a number of build failures when building with -DBUILD_WARNING_LEVEL=CHECKIN, missing virtual dtors, integer conversion issues, etc. I'm going to fix those quickly here

OK, this is building and linting cleanly for me now, PTAL

It is not building locally for me now, errors in RE2 and hash.cc.

#include <cstring> and #include <string.h> should be the same thing http://www.cplusplus.com/reference/cstring/?

This branch needs to be rebased, but if you like I can take care of that right before merging

Barring anything crazy I'm going to rebase and merge this tomorrow morning CEST. Any objections?

Nope, please go ahead Wes. Thanks for helping out and sorry we did not pay enough attention this week on the merge.
The gandiva repo has gone ahead a bit from the time we started the merge, once our release is done we would move the remaining commits to Arrow and then start our development from the Arrow repo.

@praveenbingo OK -- it is important that you stop making PRs into the old Gandiva repo ASAP and instead open the PRs here. I'm going to look at merging this right now

Fixed some lingering lint issues

Merged. @praveenbingo can you let me know your ASF JIRA id so that I can assign https://issues.apache.org/jira/browse/ARROW-3182 to you?

I wrote on the mailing list about the additional work that needs to be moved over. Let's continue the discussion there

My JIRA id (i think) is praveenbingo.


chore: remove BackendTrafficPolicyConnection

It seems like BackendTrafficPolicyConnection is a redundant struct.

cc @liorokman I think that this is already covered by BackendConnection struct. Do we need this struct ?

/retest

Nothing is using this structure, it can be safely removed.


DI for Breadcumbs

Hello,
I want to use localized breadcumbs and I can't find a way to inject an IStringLocalizer instance into my breadcumb implementations. Is it somehow possible now?
Thanks for your answer!

This should work out of the box. All breadcrumbs are basically blazor components which support property injection.
The following should work just find, when added as a property in your breadcrumb.
[Inject]
public IStringLocalizer<YourBreadcrumb> Localizer { get; set; }

Ah okay, I'm still new in Blazor and I haven't noticed it!
Thank you very much for your support, it is working just fine!