Center buttons in preference section

Fixes #101
Description
I have centered the buttons in preference section.
Screenshots (if appropriate):

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.

SWOC Participation

Name: Sanya Saeed
Discord Username:sanya29#3771
[X] I have included the issue number in my PR

@developer-diganta I feel I have done something wrong even though U told me to make a fresh PR. I'm new to Github and hence facing such issues.
Sorry to make such kind of mistakes .Please guide if there is some mistakes or errors.

They are a few errors still. What you can do is make a fresh copy of the project by pulling latest changes(in main branch) and then in that again make an appropriate branch and there make changes for this file. If you have doubts do ask me!

How do I remove all these conflicts ??
When i'm opening main in Github desktop , it is showing conflicts in it so how do I remove everything and make a fresh copy??


fix exception with compiled pybind11 extension

Not attempting to collect c++ sources, just making sure everything else still works. The exception was:
TypeError: expected str, bytes or os.PathLike object, not NoneType
Apparently, my compiled extension has a file attribute, but it is set to None. I'm pretty close to pybind11 "hello world", so quite sure I'm not doing anything unusual (apart from using sacred with my own c++ code).

Ha, interesting! That is definitely something we should support. Thanks for the PR! I'm happy to merge, but could you add a small comment (or a test)? Just to make sure, no-one accidentally undoes your fix.

I made it part of the dependency_example, and verified that the test fails without the fix. (I looked at the travis CI failure which seems related, but isn't; the same failure happens on master.)

Perfect, thanks!


H-vscode

VSCode Version:
OS Version:

Steps to Reproduce:

Reproduces without extensions: Yes/No

Missing details.


Splitting problems

https://github.com/aidevnn/FastGoat/blob/9552d4d496bb800b6650ad647a5df6de79cf2020/FastGoat/Examples/NonSplitExtension.cs#L99-L102
https://github.com/aidevnn/FastGoat/blob/9552d4d496bb800b6650ad647a5df6de79cf2020/FastGoat/Examples/NonSplitExtension.cs#L116-L119
When running this code, some results are hard to understand and they need deepening in this question.

https://github.com/aidevnn/FastGoat/blob/6de2c5bd6e5a26313e9faf4321dbdd60c0f8b07f/FastGoat/Examples/NonSplitExtension.cs#L104-L112
Direct Product with easy Quotient Group can be used to have a better look on detail.


NodePort not working

Version:
v0.9.1
Describe the bug
Cannot access a nginx service from its NodePort
To Reproduce
k3scluster@node:$ cat > manifest <<EOF
> apiVersion: apps/v1
> kind: Deployment
> metadata:
>   name: nginx-deployment
> spec:
>   selector:
>     matchLabels:
>       app: nginx-app
>   replicas: 1
>   template:
>     metadata:
>       labels:
>         app: nginx-app
>     spec:
>       containers:
>       - name: nginx
>         image: nginx:1.13.12
>         ports:
>         - containerPort: 80
> ---
> apiVersion: v1
> kind: Service
> metadata:
>   labels:
>     app: nginx-app
>   name: nginx-svc
>   namespace: default
> spec:
>   type: NodePort  # use ClusterIP as type here
>   ports:
>     - port: 80
>   selector:
>     app: nginx-app
> EOF

k3scluster@node:$ kubectl apply -f manifest
deployment.apps/nginx-deployment created
service/nginx-svc created

k3scluster@node:$ kubectl get svc
NAME         TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)        AGE
kubernetes   ClusterIP   <IP_ADDRESS>      <none>        443/TCP        4m41s
nginx-svc    NodePort    <IP_ADDRESS>   <none>        80:32136/TCP   59s

k3scluster@node:$ kubectl describe svc nginx-svc
Name:                     nginx-svc
Namespace:                default
Labels:                   app=nginx-app
Annotations:              kubectl.kubernetes.io/last-applied-configuration:
                            {"apiVersion":"v1","kind":"Service","metadata":{"annotations":{},"labels":{"app":"nginx-app"},"name":"nginx-svc","namespace":"default"},"s...
Selector:                 app=nginx-app
Type:                     NodePort
IP:                       <IP_ADDRESS>
Port:                     <unset>  80/TCP
TargetPort:               80/TCP
NodePort:                 <unset>  32136/TCP
Endpoints:                <IP_ADDRESS>:80
Session Affinity:         None
External Traffic Policy:  Cluster
Events:                   <none>

k3scluster@node:$ curl localhost:32136

this just hangs forever and doesn't return anything.
Expected behavior
The default Nginx index.html should be returned on the curl command
Actual behavior
curl times out
Additional context
Running on RPi 3B with Raspbian Buster

@cjdcordeiro With service of Type: NodePort, a port between range 30000-32767 is allocated on the node which can be accessed from outside, using node's public ip:nodeport.
In your example:
curl http://<public ip>:32136
And can be access locally using ClusterIP:port
curl http://<IP_ADDRESS>
Hope this helps. Please verify.

@ShylajaDevadiga yes I know,  that's what the command I've posted in the ticket description above, and doesn't work.
My best guess is that this has something to do with iptables-nft, but I'm not a network expert so I'd rather have confirmation and/or a workaround from the developers

iptables needs to be in legacy mode.

@erikwilson any improvements to be made here? Does our check script check for iptables in legacy mode?

Hi,
I'm also stumbled across this problem but my setup is a bit different. I'm using K3d and created a nodeport service. Looking into the iptables, I can see that in the KUBE-EXTERNAL-SERVICES chain the port is blocked. It has a notice that the service has no endpoints.  In my example it's the mosquitto service:
Any suggestions, if this is a bug of K3s or a setup problem?
/ # iptables -L -n
Chain INPUT (policy ACCEPT)
target     prot opt source               destination
KUBE-FIREWALL  all  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0
KUBE-SERVICES  all  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0            ctstate NEW /* kubernetes service portals */
KUBE-EXTERNAL-SERVICES  all  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0            ctstate NEW /* kubernetes externally-visible service portals */

Chain FORWARD (policy ACCEPT)
target     prot opt source               destination
KUBE-FORWARD  all  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0            /* kubernetes forwarding rules */
KUBE-SERVICES  all  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0            ctstate NEW /* kubernetes service portals */
ACCEPT     all  --  <IP_ADDRESS>/16         <IP_ADDRESS>/0
ACCEPT     all  --  <IP_ADDRESS>/0            <IP_ADDRESS>/16

Chain OUTPUT (policy ACCEPT)
target     prot opt source               destination
KUBE-FIREWALL  all  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0
KUBE-SERVICES  all  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0            ctstate NEW /* kubernetes service portals */

Chain KUBE-EXTERNAL-SERVICES (1 references)
target     prot opt source               destination
REJECT     tcp  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0            /* mqtt/mosquitto-service has no endpoints */ ADDRTYPE match dst-type LOCAL tcp dpt:31883 reject-with icmp-port-unreachable

Chain KUBE-FIREWALL (2 references)
target     prot opt source               destination
DROP       all  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0            /* kubernetes firewall for dropping marked packets */ mark match 0x8000/0x8000
DROP       all  -- !<IP_ADDRESS>/8          <IP_ADDRESS>/8          /* block incoming localnet connections */ ! ctstate RELATED,ESTABLISHED,DNAT

Chain KUBE-FORWARD (1 references)
target     prot opt source               destination
DROP       all  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0            ctstate INVALID
ACCEPT     all  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0            /* kubernetes forwarding rules */ mark match 0x4000/0x4000
ACCEPT     all  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0            /* kubernetes forwarding conntrack pod source rule */ ctstate RELATED,ESTABLISHED
ACCEPT     all  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0            /* kubernetes forwarding conntrack pod destination rule */ ctstate RELATED,ESTABLISHED

Chain KUBE-KUBELET-CANARY (0 references)
target     prot opt source               destination

Chain KUBE-PROXY-CANARY (0 references)
target     prot opt source               destination

Chain KUBE-SERVICES (3 references)
target     prot opt source               destination
REJECT     tcp  --  <IP_ADDRESS>/0            <IP_ADDRESS>        /* mqtt/mosquitto-service has no endpoints */ tcp dpt:8883 reject-with icmp-port-unreachable
REJECT     tcp  --  <IP_ADDRESS>/0            <IP_ADDRESS>           /* mqtt/mosquitto-service has no endpoints */ tcp dpt:8883 reject-with icmp-port-unreachable

Same issue here : AWS EC2 ubuntu:20.04 , latest k3s,
I am able to : curl :
but not : curl :
checked security groups, everything is fine. but unable to reach my cluster via public IP.

I meet same problem too.

Actual problem

today i face this problem, unable to get nginx landing page using the nodeport on the worker!!!!

UPDATE:
Guys it was causing for different version of k3s in master and worker node for me.
after mentioning the version by
export INSTALL_K3S_CHANNEL="v1.20.15+k3s1"
for both master and worker solved the issue.

Closing this one due to age. Please open new issues and/or discussions as problems arise :)


stable docs link in README is broken

Fixed by https://github.com/JuliaLinearAlgebra/TSVD.jl/pull/23. I hadn't noticed that Travis had deprecated matrix.


arch/x86/intel64: Fix assumption with dummy threads

The intel64 switch implementation doesn't actually use a switch handle
per se, just the raw thread struct pointers which get stored into the
handle field.  This works fine for normally initialized threads, but
when switching out of a dummy thread at initialization, nothing has
initialized that field and the code was dumping registers into the
bottom of memory through the resulting NULL pointer.
Fix this by skipping the load of the field value and just using an
offset instead to get the struct address, which is actually slightly
faster anyway (a SUB immediate instruction vs. the load).
Actually for extra credit we could even move the switch_handle field
to the top of the thread struct and eliminate the instruction
entirely, though if we did that it's probably worth adding some
conditional code to make the switch_handle field disappear entirely.
Fixes: #19759
Signed-off-by: Andy Ross<EMAIL_ADDRESS>

I would like someone to address my concerns about the semantics of z_arch_switch() and switch_handle before we start forcing implementations to be conformant to this particular vision.

@gnuless this patch properly fixes a bug that dereferences a NULL pointer. It is a better fix than the one I provided which you approved.
If you want to have a discussion about the overall design, hash it out in #19938 or on the mailing list or something. It is not appropriate to block this particular patch for something which is far beyond its scope.

@gnuless this patch properly fixes a bug that dereferences a NULL pointer. It is a better fix than the one I provided which you approved.

No, it does not properly fix anything.  I mean, it's a fix, but it's not proper.

If you want to have a discussion about the overall design, hash it out in #19938 or on the mailing list or something. It is not appropriate to block this particular patch for something which is far beyond its scope.

Fine, you win...


please allow line chart animating from left to right instead of only bottom to top

Per the title!

I don't think we will implement this in the core. It could be done by changing the updateElement method of the line controller.


PyDAP module

From<EMAIL_ADDRESS>on 2012-03-07T05:39:13Z
I have installed pythonxy <IP_ADDRESS> and i can't find the module PyDAP, which is said it was added in Version 1.2.6.
Thanks for your help
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=965

From pierre.raybaut on 2012-03-18T08:44:15Z
Please report to the Python(x,y) project.
Status: Invalid


Custom element

If we want to create a custom element, it could be great to have a way to access config/* and helpers/* modules.

@jeanmatthieud I think this is what you were referring to, let me know if it's not and I'll reopen. Thanks!


Course descriptions not wrapping on mobile

Pretty sure this is a one line fix. I'll get to it after May 6th unless in a moment of weakness I do it sooner.

Closed by #142


TINKERPOP-911: Lets SparkGraphComputer Set ThreadLocal Properties

When running in persistent context mode, the configuration for the Spark
Context is always inherited from the origin configuration. This can be
overridden for select properties using setLocalProperty. By enabling
this for SparkGraphComputer a user will be able to take advantage of the
FairScheduler system with spark or add custom Spark JobGroupIDs to jobs in the
same JVM.

Hey, should there be a mention of this somewhere in the documentation or are javadocs enough in this instance?

This looks good to me. Test case seems legit (though I would like to simply this style which is also seen in PersistedInputOutputRDDTest. As @PommeVerte said -- do we need to mention this in docs? If so, please add to PR along with update to CHANGELOG.
VOTE +1.

Added in some documentation for this and an explicit list of allowable properties, the ascii doc looks ok in my IDEA preview, is there a way to build the docs and view them locally? I'd hate to break them again @okram  :(

Looks good to me, now that the docs are done.
VOTE: +1

@RussellSpitzer if your docs don't contain code examples you can typically get away with:
bin/process-docs.sh --dryRun

which just runs the asciidoc processor.  To see code examples generated too with output you gotta have all the other infrastructure running (i.e. hadoop, etc.).  In your case the --dryRun would seem sufficient.

I couldn't really test this as mvn clean install fails for me even on master with :  InputRDDTest.shouldReadFromArbitraryRDD:51 » IllegalState org.apache.spark.Spa...
(spark-gremlin project)
Am I the only one with this issue?
That failure aside, the docs build correctly and the spark integration tests pass.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache TinkerPop ................................... SUCCESS [  3.445 s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [  1.633 s]
[INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [ 25.242 s]
[INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [  9.935 s]
[INFO] Apache TinkerPop :: Gremlin Groovy ................. SUCCESS [ 36.015 s]
[INFO] Apache TinkerPop :: Gremlin Groovy Test ............ SUCCESS [  4.602 s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SUCCESS [01:32 min]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................. SUCCESS [04:03 min]
[INFO] Apache TinkerPop :: Spark Gremlin .................. SUCCESS [ 35.039 s]
[INFO] Apache TinkerPop :: Giraph Gremlin ................. SUCCESS [  4.346 s]
[INFO] Apache TinkerPop :: Neo4j Gremlin .................. SUCCESS [  2.158 s]
[INFO] Apache TinkerPop :: Gremlin Driver ................. SUCCESS [  6.774 s]
[INFO] Apache TinkerPop :: Gremlin Server ................. SUCCESS [  3.643 s]
[INFO] Apache TinkerPop :: Gremlin Console ................ SUCCESS [ 11.334 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 08:00 min
[INFO] Finished at: 2015-11-04T09:18:53-08:00
[INFO] Final Memory: 124M/1304M```

I finally managed to build this... It's a bit of a mystery as to why it works now, but that's good for me.
VOTE: +1


WIP: Introduce Request type and refactor flow.

This PR introduces a Request type that represents a
ready to execute request.
A Request can be obtained with RequestBuilder::build(), and executed
with Client::execute().
The RequestBuilder now also builds a Request and forwards it to the
inner client.
The execution logic was moved from Requestbuilder::send() to
ClientRef::execute_request().

@theduke I'm actually going to bring this up during the reqwest lib blitz meeting (Tuesday), as the API design is already a point of discussion in there.

I commented in #85 about this.

This should be pretty much ready now, @seanmonstar.
Let me know if you need any changes.

Merged via https://github.com/seanmonstar/reqwest/commit/e9f464aa7e62dc752e5345a68a7df3a920fb1546
Thanks for pushing on this!


Use Host ENV in environment files

config.action_mailer.default_url_options = { host: ENV["HOST"] }

I think staging.myapp.com is usually what we want but I take the 12factor point to store config in the environment.
https://github.com/thoughtbot/suspenders/pull/469


Switching from custom server.js to Next.js 9 API routes

Issue summary
Write a short description of the issue here ↓
Since we are using a custom server.js file, Now V2 cannot be used to host the Next app. With Next.js 9, API routes were introduced. When I try to migrate the graphQL proxy and the Shopify auth middleware like so:
// pages/api/gqlproxy.js

import Koa from 'koa';
import { graphQLProxy } from '@shopify/koa-shopify-graphql-proxy';

const server = new Koa();
const handler = (req, res) => {
     graphQLProxy({shop: "testshop", password:'testpass',});
};

export default server.use(handler);

It doesn't work.
Expected behavior
What do you think should happen?
Actual behavior
What actually happens?
Tip: include an error message (in a <details></details> tag) if your issue is related to an error
Steps to reproduce the problem

Comment out:

// server/server.js

  server.use(
    graphQLProxy({
      version: ApiVersion.October19
    })
  );

Add new folder to pages called api and create a new file gqlproxy.js.

// pages/api/gqlproxy.js

import Koa from 'koa';
import { graphQLProxy } from '@shopify/koa-shopify-graphql-proxy';

const server = new Koa();
const handler = (req, res) => {
     graphQLProxy({shop: "testshop", password:'testpass',});
};

export default server.use(handler);

Hit the endpoint localhost:3000/api/gqlproxy and the function should mount the graphql proxy, but it does not.

Reduced test case
The best way to get your bug fixed is to provide a reduced test case.
Specifications

Browser:
Device:
Operating System:

@junaid33
Try looking into the source of graphQLProxy: https://github.com/Shopify/quilt/blob/master/packages/koa-shopify-graphql-proxy/src/shopify-graphql-proxy.ts
The function returns another function with this notation:
(ctx: Context, next: () => Promise<any>) => void

So you are calling this graphQLProxy function, but you're not doing anything with the actual return value: a function that expects the ctx and a next middleware handler.

@junaid33 did you manage to get this working without the custom server in the end, so we can host on their ziet/vercel?

@jamescrowley No we put this issue on the back burner and just hosted the application on Heroku for now. I'm not exactly sure how to use Koa with serverless functions or if mounting the graphQL API would work. Maybe we can work together with @katiedavis to update this repo so it can be hosted on Vercel. Or maybe a sample repo showing how to use Shopify Quilt with serverless functions.

@jamescrowley @junaid33 -- Did either of you manage to get this working?

@foresttoney unfortunately not, the way the auth libraries work appear challenging to hook into the next js routes right now.
@katiedavis I'm not sure this issue should be closed. It seems to me there would be significant benefits to switching away from the custom server (more hosting options, and simplified setup for starters), that would be worth exploring?  (While @junaid33 raised a specific problem attempting to make this switch, it's a wider issue IMHO).

Anyone managed to get the pages/api routes to work as endpoints yet? It would be great if this could be possible

Hello,
I created a package to remove the custom server and managed to deploy an app shopify with only nextjs on Vercel.
The package: https://github.com/bluebeel/nextjs-shopify-auth
The demo app: https://github.com/bluebeel/nextjs-shopify
It only lacks the webhooks management if I have time or if someone wants to contribute.
Cheers :)
cc: @jamescrowley @foresttoney @junaid33


Add preact to nanocomponent adapters

Preact does not have createClass. You can emulate it of course, but I did not know if you wanted to do that. Just let me know what you think and I will update PR if needed.
#2

This is really cool! - whatever is most native to preact is ideal I think; don't think using createClass is desirable then (not even sure that's the best idea for react now haha - is it?)
Also I wonder: would it be better to use prototype methods? I know it's quite common in the preact / react world but it might save some compilation if we use prototypes. Some quick googling makes it seem we can replace:
class Clx extends preact.Component {}

with:
function Clx () {}
Clx.prototype = Object.create(preact.Component)
Clx.prototype.constructor = preact.Component

What do you think?

That was what I was going to suggest.  I did a quick test here (See Demo component) and it works fine. I wasn't sure if preact was doing any special tricks.

cool! :D
On Mon, Jan 30, 2017 at 3:20 PM Kye Hohenberger<EMAIL_ADDRESS>wrote:

That was what I was going to suggest. I did a quick test here (See Demo
component) http://codepen.io/tkh44/pen/oBpVqd?editors=0010#0 and it
works fine. I wasn't sure if preact was doing any special tricks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/yoshuawuyts/nanocomponent-adapters/pull/4#issuecomment-276224004,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWlelRNpQh40jhLKeZhQOLlWvtBL_TFks5rXnBMgaJpZM4Lx-do
.

Converted to es5.

Rad! - oh also @toddself just pointed out we can now just reuse the react
and preact code; e.g. alias it - that's like really cool :D
On Mon, Jan 30, 2017 at 4:07 PM Kye Hohenberger<EMAIL_ADDRESS>wrote:

Converted to es5.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/yoshuawuyts/nanocomponent-adapters/pull/4#issuecomment-276232959,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWlelJ-FOPgIXZMfHaZ2GY8iG_oddZkks5rXntDgaJpZM4Lx-do
.

v1.2.0 :sparkles:

Heh - I didn't even need to say anything lol.
Regarding prototype methods, preact doesn't care what gets used - the only requirement is that there is a render() method on the prototype. "Inheriting" from Component is just to get setState().


Allow project settings to sync

What would you like to be added?
I would like to be able to create a project and configure it on one computer then, using my desired sync method (I'm using iCloud), have the settings show up on a separate computer.
Why is this needed?
Currently, when I create a project and add notes on Computer A, the notes are all organized and synced to my other computer, as expected. Projects plugin is installed and enabled on both computers. However, when I go to Computer B and do the command Projects: Show projects, the project I created on Computer A does not exist and I have to recreate it, including the views, settings, sort methods, coloring, etc.
I would like to be able to do work on one computer, switch to another computer, and continue with the same work without having to reapply any changes I may have made to the projects (again, this is the project setup, not the notes themselves)

I'm going to close this because the settings do sync. It's just that the "reload plugin" action doesn't pull the changes. One has to exit out of and reopen the vault in order to read the new settings, which is cumbersome, but tolerable.
Aside from that minor thing, I think this is a fantastic plugin; kudos!


picture-issue with Edge and Firefox preferring .webp

I've got several picture elements on my webpage that use both .webp and .png or .jpg images for several sizes. The example code comes from the lazysizes examples, but that example did not have multiple filetypes specified.
When I do, Firefox and Edge try to display the .webp-images, but because they don't have support for that, the image can not be displayed.
The code I've used looks like this:
<picture class="fullwidth">
<!--[if IE 9]><video style="display: none"><![endif]-->
<source data-srcset="/img/home_header_screenshots_500.webp" media="(max-width: 543px)" />
<source data-srcset="/img/home_header_screenshots_500.png" media="(max-width: 543px)" />
<source data-srcset="/img/home_header_screenshots_800.webp" media="(max-width: 1024px)" />
<source data-srcset="/img/home_header_screenshots_800.png" media="(max-width: 1024px)" />
<source data-srcset="/img/home_header_screenshots.webp" />
<source data-srcset="/img/home_header_screenshots.png" />
<!--[if IE 9]></video><![endif]-->
<img src="data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" data-src="/img/home_header_screenshots.png" class="lazyload" alt="5X Screenshots" />
</picture>
I'd like lazysizes to use the next supported image when the .webp fails, but falling back to the regular img-element would be acceptable as well.
I'm using lazysizes 2.0.7 without other plugins.
Test site

You must add the  type="image/webp" to your source elements, that contain a webp image.
Please close if this helps.

Thanks so much, it works with type="image/webp" added to the source elements.


ETH fees not credited

Even though transcoders have fees sharing why arent the accounts credited with ETH? I've tried bonding to different transcoders But I still don't get ETH fees.  Looking for some help

Hey @ajukjose - the amount of fees in ETH you can expect depends on how much video is flowing through the network at any given moment and the amount LPT you have staked. Right now the network is in an alpha state and there's not much video being broadcasted into it which is why you're not seeing any fees. The usage so far in the alpha release has been people streaming events, conferences, and meetups. The upcoming "Streamflow" release takes the alpha from functional proof of concept, to actually scalable, cost-effective, and reliable enough to start targeting applications and video platforms to use the network. When this happens, expect to start seeing broadcasting fees in ETH make its way to your account.


change implementation of MAPL_getHorzIJIndex

This PR is replacing MAPL_GetHorzIJIndex with MAPL_GetGlobalHorzIJIndex. The indexes are converted back to the local index so the results are not changed.
Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Trivial change (affects only documentation or cleanup)

Checklist:

[ ] I have tested this change with a run of GEOSgcm (if non-trivial)
[x] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[x] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa , I am replacing the  implementation of subroutine MAPL_GetHorzIJindex.   Three reasons: 1) make it simple;  2) This call is also a collective call which is not desirable;  3) see if it fixes the issue

MAPL_GetHorzIJindex

Does GOCART have different grid other than cubed-sphere grid ? @bena-nasa @atrayano

GOCART inherits its grid from its parent.  In all current model configurations this will be CS, but it should never be hardwired.

@weiyuan-jiang  is this still a relevant PR?

@weiyuan-jiang is this still a relevant PR?

Somehow it is not working. I will take a look at it

Not sure why the GEOSgcm build failed. I restarted it and it seems happier now.

@weiyuan-jiang,  just a note that this modification removed the local index search for LL grid on each PET.

This PR needs to be closed or completed. I cannot see a reason for it to just optimistically stay open. (Aside from maybe @weiyuan-jiang does not have enough time to look at it.)

I remembered I change that function  grid_is_ok to  remove the collective call. But now the collective call MAPL_GridGetCorners  is still there. I need to change that

I think all the problem is caused by the lost of this PR .  It will replace this PR

Not necessary any more


Support for EPT format

Hi all,
We are very interested in the pdal/entwine/greyhound suite and thanks @hobu for the clarification regarding scope, makes total sense. I can still see use cases where greyhound comes in handy (as you mentioned) and we would actually like to have such service in place in order to abstract the logic for reading sections of a point cloud or grabbing a certain resolution. It does not seem that greyhound supports EPT at the moment, is there any plan to add that in the near future? If not, we would be ready to help with that if you are interested, any pointer to what should change would be ideal.
Thanks!

Thanks for you answer.

Entwine's previous organization that Greyhound is using is not so significantly different than EPT.

I see that data is read using entwine's data reader actually. So I guess most of the changes should happen in entwine itself (if that hasn't happened already), correct?

Greyhound evolves toward server software that is less focused on satisfying sub 40ms small queries for rendering (you can beat that easily with straight EPT) and more focused on "do PDAL-like things to data remotely over the internet".

That's really the kind of use case that we have in mind, having said that, do you feel that it is still a good idea to leverage the existing code base of Greyhound? Or are we talking about something that would really need a complete repurposing?

So I guess most of the changes should happen in entwine itself (if that hasn't happened already), correct?

@connormanning would have to comment, but I think most of the changes would be in Greyhound's "Entwine reader" implementation need to adapt to EPT.

do you feel that it is still a good idea to leverage the existing code base of Greyhound?

The case for keeping Greyhound includes:

The API is really simple (bounding cube and depth). For "heavier" applications, this is really useful
Greyhound has support for pushing data back into the tree. We still want software that can orchestrate that instead of doing it over naked EPT. See Connor's FOSS4G talk for more information.
Greyhound's server-side filters are really useful
We have a small installed Greyhound base that needs to keep using it

In short, we don't see Greyhound going away, but it has fallen down our queue at the moment. If you can invest software development into it, the things you want will happen much faster.

Here is a quickly hacked together example using the ept branch updated for latest entwine https://github.com/jw3/greyhound/tree/jw3/ept
It will be slightly behind latest but should update easy enough.  Was having problems with binary backend but that might have been an entwine issue that was fixed up.  Otherwise worked well enough for proof of concept.


Hangs for Resnet on TG, TGG after conv optimization

Changes introduced in 8e0e2e1 to optimize first convolution seems to cause Resnet on TG/TGG to hang. Hangs are not observed on T3K or single N300. This might imply that it could be di/dt. Another potential difference is that Galaxy uses tensix dispatch, but on T3K uses eth dispatch, though this doesn't seem like it would be the cause.
Changing self.conv1_config.act_block_h_override back to 64 instead of 256 also seems to work around and allow Resnet to pass again on TG/TGG. This is a workaround while we figure out why it's hanging.

act_block_h_override == 256 -> output sub_blocks 4x2 --> HANG
act_block_h_override == 128 -> output sub_blocks 2x2 --> PASS
act_block_h_override == 64 -> output sub_blocks 1x2 --> PASS
running 256 on 500Mhz pass as well (by hacking busy signal in UMD).
I've tested this on aus-glx-12, FW <IP_ADDRESS> (defaults to 900Mhz)
This really seems like di/dt issue.
@ttmtrajkovic any suggestion what I could do further?

Reproed on N300 as well.
Out of ~20 tested boards, 4 are hanging, usually on iteration > 5k


Project: Project story template

We want to make it easier for us to capture the story and artifacts of projects as we complete them.
Scope:

Single-page site with (jump link) navigation
Major sections that will apply to most projects
Ability to add/link to artifacts
Light Bixal branding (at least colors and fonts)
Repo template with readme instructions
Consider how we might use layouts includes and front matter for flexibility

The focus of this project has shifted as we have concentrated on preparing our material for the DCDW event and thinking about how to do it an accessible, web-based way.
Much of this work will apply to the original intent, but we're adjust the scope accordingly, removing some items from the original post and adding the following:

Organize content into slides
Assign slides to a variety of layout templates (title, text, image)

https://github.com/Bixal/rapid-prototyping-with-uswds-event


NDC error for CBC mode

Hello,
I tried to Test Recent Changes given for CBC mode Encryption.
when i tired to test same in test URL i am Getting NDC error for Both CBC and ECB mode.
Please Suggest.

Hello,
I'm unable to read any notification received using my private key, even with the sample application Dotnet posted on GitHub !?

https://www.irs.gov/pub/fatca/p5190idesuserguide.pdf,
9.3 Receive an IRS Notification
"Use your private key to decrypt the FATCAEntityReceiverId_Key file"

The Help Desk Support confirmed me "The test session uses the same keys as the Live session.", so i don't know where's the point to fix...
Did anyone encountered the same trouble please ?

@franckmorin
No trouble here.
Rather than tweak the code to my existing .NET application, I re-built the app from scratch based on the sample GitHub code provided and have no problems encrypting a transmission packet file using the new CBC encryption. During the current test window, we have uploaded 80-100 test files and de-crypted the notifications without any problems.
It maybe worth emailing your contact @ IRS for a sample test file containing both a test sender and receiver certificate. These can be used to determine whether your application or your certificate is at fault....If your app works with the test certs, then you know your app is good and something wrong with your own private certificate.
Hope this helps, thanks.

@ctaylor82
Thank you for your answer, your analysis confirms mine when you could validate on your side the good working of the .NET sample GitHub code.
Unfortunately, my conclusion is the key on IDES Enrollment is not the good one, so this is the reason why we cannot decrypt the notification downloaded. As we can't find the corresponding key, we can't perform the next steps to decrypt the notifications in the test environnment.
Thanks a lot for your helping answer.
Best regards


fix activiy in backgroud and killed by system,then get position crash

fix activiy in backgroud and killed by system,then get position crash


Implement lbaasv1.LoadBalancer resource

Description

This PR implements the LBaaS LoadBalancer API resource as a Terraform resource.
Checklist

[x] added release notes to Unreleased section in CHANGELOG.md, if user facing change

References

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

@LittleFox94 I did a rebase and configured the resource test to also run parallel (#102)


potential workflow for MultiMAP.Integration for cross species analysis

Hi,
I had a quick question in regards to using MultiMAP for cross species analysis, should I only have the 1:1 orthologues between the two species in each of the AnnData objects, or can i also have unshared features?
Best,
Devika

That's a neat application of MultiMAP!
You're welcome to have unshared features as well, and use those to compute the single-species dataset reductions. The transcriptomics plus ATAC integration in the demo has some number of unique features for each modality.

Great! We will try it with unshared features then. Thanks for getting back to me .
Best,
Devika


Fast TS has a bug related to ASI

See: https://github.com/nodejs/amaro/issues/24

cc @magic-akari Can you take a look?

Tangent: https://github.com/swc-project/swc/issues/9331#issuecomment-2249255068 asked a question, but that issue is locked & limited to collaborators, so the person asked could not answer


Final titer

Scientists provide the titer of the viral prep lot (and ultimately this will be ingested from TARS). But in virus cocktails, the final titer is different (i.e. when mixing multiple viruses together, each virus is diluted).
We need to add a function that calculated the final titer of each injection material based on the volume of each virus and the titer of the prep lot. Simple math.

I'm not actually sure how best to implement the final titer calculation... might need some help on that

resolved in PR #657


Add 200 response code in Preview API Version

ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[ ] New API version. (Such PR should have been generated with OpenAPI Hub).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix swagger quality issues in S360.
[ *] Other, please clarify:
-Add new Response code in existing Preview version

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

The service respond 200 but 200 is not defined in related swagger definition. Due to this SDK raise unexpected error. To fix this issue, We have added the Response code 200


sam1932 Blog Post

A blog post going over my bug fix for MonoGame.

At first glance, blog post looks good!


Plug-In doesn't open in VST-host in OSX 10.12.1

After building the plug-in and bundling it with osx_vst_bunder.sh script and copying it to the VST directory Ableton Live and Audacity cannot find the plug-in.

@PhilStem there is now a more up to date for of this repo that is under active development and improvement here https://github.com/rust-dsp/rust-vst
Have you verified that your DAW’s are pointing to the correct VST folder? On OS X there are usually two VST folders. One in users space and one in system space.  Please make sure that you are using the correct one. If you have other plugins in the folder you are using now and your DAW will recognize those then please disregard the previous, if the issue is still present using the correct folder please open an issue on the repo I linked above. Please provide us with the exact command you are using to bundle the vst as well as a copy of the bundle that is being created. We will take a look at it and try to reproduce the issue and make any needed adjustments.


Use Pinyin URL structure for Chinese website Baidu SEO

Often in E-Commerce solutions missed for growing China E-Commerce market. Pinyin URL structure
For example: 中文网站
Result in URL should be: zhong-wen-wang-zhan
Here is a good description of this topic: https://dengruo.com/en/blog/use-pinyin-url-structure-chinese-website-baidu-seo

I think we got it covered already, 中文网站 will be slugified to zhong-wen-wang-zhan, seems right, right?

I can help translate into german language. My girlfriend with the time the Chinese language (she speaks Mandarin)

AliPay is huge in China. Almost everyone is using it, even just to pay IRL. There are a lot of Saleor Chinese users, it would be great to add.
@alexander-sibert keep us updated! If you need help feel free to contact.

It looks like you can accept AliPay through Stripe, which is supported by Saleor.

I read it also but they charge per transaction? Then i have to clear if they support AliPay International or also AliPay within Mainland China.

Another thing are international address formats for checkout. For example China has also another address format than western world Europe or USA.

Saleor uses geolocation to enhance the experience of the customers, it understands international addresses, can convert prices to other currencies and offers translation where needed.

Ok Ok, i will install it and use it ;) for a hopefully growing project

@NyanKiyoshi maybe you can help me out with setup on Server and Docker?

@alexander-sibert Take a look at the Deployment section in our docs. Please reopen the issue if you have any particular questions or reach us out on Gitter.

@alexander-sibert have you finished include the alipay and wechat payment solutions?


x/vgo: create go.modverify by default

The security provided by go.modverify should not be opt-in.
I elaborated on why locking hashes into repositories is so important at https://groups.google.com/d/msg/golang-dev/MNQwgYHMEcY/Jl-piUJ_CgAJ
There is no reason we should encourage not using it, at least not until we have a solid story about alternative verification methods.

As I wrote on #24117:

Not yet. We're fixing one thing at a time. The first thing to fix is management of versions at all. The second thing is verification. There's no need to do both at once. We've gotten by this long with "go get" with no modverify. Let's get versions into go first, and then turn our attention to verifying.

Especially if we do have a solid plan for alternate verification methods, there is no point to littering everyone's repos with go.modverify files that will not be necessary in the long run.


Abolish Test conversion using unsafeBitCase

Test.current is converting IssueReporting.Test to Testing.Test using unsafeBitCast to determine whether Swift Testing is enabled.
However, I think that if you use canImport, conversion using unsafeBitCast is not necessary.
Not using unsafeBitCast will avoid crashes if Testing.Test changes in the future.

Hi @sk409, unfortunately this is not the right thing to do. We can never import Testing or XCTest in the IssueReporting library because that will cause Xcode to link those frameworks with the app target, and you will get compiler errors.
You can even see this in your branch by trying to compile the Examples target. You will see that it fails with these errors:

The main point of the IssueReporting library is to load these frameworks dynamically so that we do not have to important them. And then the IssueReportingTestingSupport library can import the real libraries in order to get coverage in release mode, but that library should never be linked to an app target.

@mbrandonw
Thank you for your detailed explanation.
I understand why you use unsafeBitCast.


Update Vitis AI quantization to support ORT 1.16, support TensorData and QuantizationParams

Describe your changes
Update Vitis AI quantization to support ORT 1.16, support TensorData and QuantizationParams
Checklist before requesting a review

[ ] Add unit tests for this change.
[ ] Make sure all tests can pass.
[ ] Update documents if necessary.
[ ] Format your code by running pre-commit run --all-files
[ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link
https://github.com/microsoft/Olive/issues/629

/azp run

/azp run

/azp run

/azp run


Create Song “2024-07-21/index”

Automatically generated by Netlify CMS

👷 Deploy Preview for neon-syrniki-8734f6 processing.

Name
Link

🔨 Latest commit
2d980cf8412247fc7a91a3551da013e28cf20d58

🔍 Latest deploy log
https://app.netlify.com/sites/neon-syrniki-8734f6/deploys/669c98732bb9d100080deef8


clear the selection after setState

Hi, just a simple question:
I've developed a component that allow my app to POST data retrieved by this dropdown selection.
One simple "save button" allow me to call my api and store the data then the setState is invoked to re-render the page (to show the new things) but inside the dropdown selection still remains the previous one value.
There is a way to "remove" this value from the dropdown view after the save?

I want to be able to see the dropdown "cleared" after setState, without do an hard page refresh. It's possible?
Thank you!

Hi @alessandronocera89 ,
You can set the "defaultValue" prop to empty string or empty array it will update the dropdown value.
Thanks

Hi @alessandronocera89 , You can set the "defaultValue" prop to empty string or empty array it will update the dropdown value. Thanks

Is there a way to do it without setState and by using useState.

I don't think so, how do you plan to do it ? @Chiragjot


Audio sync fails intermittently

When testing the audio functional test with multiple users in the space, sounds would not start for some users.
With 5 users in the space:

Background music would not start for one user, despite repeated starts and stops.
Doppler sound did not play for a different user.

Re: doppler sound, I don't think that's a sync issue. It never played for that user (the only user on Android), over multiple runs of the test. Need to retest as authoritative user.

Doppler didn't play for me, on PC.

More issues:

The music seems to auto-play some/most of the time

OK, I've reproduced this on Quest, and I believe issue may have been that the sample downloaded the music file from a very slow and unreliable website, and never finished. After including a new music file into the SDK, haven't reproduced it since.

Reopening this - I was going to write a cleaner bug describing the case, but reopening this is probably more correct,. to keep tracking. I think the bug will not happen anymore in the functional tests as it is
Additional Notes:

To reproduce, we need to change the music back to load from the slow/unreliable website.
It also seemed to fail until the music file was cached locally, so tests should maybe be done with changing to a new audio file for each test run.
This may have to do just with audio files, or may be with general downloading of any assets, or just textures/materials (as the downloading code is shared between multiple asset types).


Update Cloud Run sample code to use GCS configs

Update Cloud Run sample to utilize GCS files for connections

This is not necessary since the Cloud Run Flask application does not read from a connection file - the config is instead passed in as JSON data to the endpoint.


refactor: use LayerDesc in LayerMap (part 2)

Problem
part of https://github.com/neondatabase/neon/issues/4392, continuation of https://github.com/neondatabase/neon/pull/4408
Summary of changes
This PR removes all layer objects from LayerMap and moves it to the timeline struct. In timeline struct, LayerMapping maps a layer descriptor to a layer object, and it is stored in the same RwLock as LayerMap to avoid behavior difference.
Key changes:

LayerMap now does not have generic, and only stores descriptors.
In Timeline, we add a new struct called layer mapping.
Currently, layer mapping is stored in the same lock with layer map. Every time we retrieve data from the layer map, we will need to map the descriptor to the actual object.
Replace_historic is moved to layer mapping's replace, and the return value behavior is different from before. I'm a little bit unsure about this part and it would be good to have some comments on that.
Some test cases are rewritten to adapt to the new interface, and we can decide whether to remove it in the future because it does not make much sense now.
LayerDescriptor is moved to tests module and should only be intended for unit testing / benchmarks.
Because we now have a usage pattern like "take the guard of lock, then get the reference of two fields", we want to avoid dropping the incorrect object when we intend to unlock the lock guard. Therefore, a new set of helper function drop_r/wlock is added. This can be removed in the future when we finish the refactor.

TODOs after this PR: fully remove RemoteLayer, and move LayerMapping to a separate LayerCache.
Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

... I moved layer mapping and layer map into a single lock, so as to avoid behavior difference / race condition compared with main. In the next PR we would finally be able to make it in a separate layer cache.

the only remaining thing is to properly rewrite replace_historic in timeline and this PR should be ready then.

... and there are only 4 usages of is_remote_layer and 12 usages of get_from_desc, which should be removed when we fully remove remote layer and add the layer cache. LayerMap should become a simple storage state after the full refactor is done.

just rebased to latest main and should be ready for review :)

Thanks for the reviews!

So, I propose to rename LayerMapping to LayerFileManager.

Actually, LayerMapping is also something temporary and will be removed in the final PR. The purpose of this PR is that, we keep the mapping and the layer map in the same struct, so that the compiler can help us ensure mapping will have the same lifetime with the layer, and if it compiles, it should work. This tuple will be split and refactored in the future.

https://github.com/neondatabase/neon/pull/4479 further moves the layer mapping to something called layer_cache, and in that PR, layer mapping will be deprecated.
https://github.com/neondatabase/neon/pull/4510 replaces layer map with layer manager.

I'll look into the comments and resolve them today.

My understanding is that, in the future, we'll be able to split up the tuple of LayerMap and LayerMapping , so that e.g. on-demand-download/eviction, and layer spreading, can operate just on LayerMapping.

That's true, and I tried implementing it in https://github.com/neondatabase/neon/pull/4523 but it is not ready for review yet and not in the current refactor pipelines.

renaming of LayerMapping will be done in next commit

ready for review :)

Can we do some lifetime trick here to get back safety?

I was thinking something like returning &LayerDesc here so that it cannot outlive the layer map, but considering (1) the descriptor is easily clone-able and we cannot prevent people from misusing it (2) such errors will be easily detectable in debug env. Therefore, I prefer to keep it as-is. The current main branch is also prune to reading a deleted file if layer_removal_cs is not correctly held. I feel this is part of the code that we need manual review instead of relying on the compiler to give an error.

I was thinking something like returning &LayerDesc here so that it cannot outlive the layer map, but considering (1) the descriptor is easily clone-able and we cannot prevent people from misusing it (2) such errors will be easily detectable in debug env.

Does it need to be clone-able though?

I think if you add a PhantomMarker to it, you can even make it clon'able while still constraining the lifetime.

I tried removing derive Clone for PersistentLayerDesc and it seems necessary in multiple places:

When inserting into the layer map. The procedure of creating layers are like: first create the layer object with a descriptor inside, and then insert the layer object to mapping and the descriptor to the layer map. As we need two copies of that, clone seems inevitable.
LayerDesc is also part of the manifest. We will need to store it when serializing / deserializing the manifest.
Adding a phantom marker will result in we have something like PersistentLayerDesc<'a>, which makes it harder to be stored inside layer map / manifest / layer file manager.

I have a draft PR to ensure all layer descs from layer map always come with a guard so that we can only use it when layer map is in use, but I don't feel it's a good solution. Furthermore, the current implementation at main branch also doesn't prevent us from getting a layer object from layer map and then drop the layer map.
https://github.com/neondatabase/neon/pull/4587

Digesting some of my review insights (I'm sure everyone else just understood :P )
diff --git a/pageserver/src/tenant/timeline.rs b/pageserver/src/tenant/timeline.rs
index 9cb9ef4b..a07bc646 100644
--- a/pageserver/src/tenant/timeline.rs
+++ b/pageserver/src/tenant/timeline.rs
@@ -217,6 +217,18 @@ pub struct Timeline {

     pub pg_version: u32,

+    /// The tuple has two elements.
+    /// 1. `LayerFileManager` keeps track of the various physical representations of the layer files (inmem, local, remote).
+    /// 2. `LayerMap`, the acceleration data structure for `get_reconstruct_data`.
+    ///
+    /// `LayerMap` maps out the `(PAGE,LSN) / (KEY,LSN)` space, which is composed of `(KeyRange, LsnRange)` rectangles.
+    /// We describe these rectangles through the `PersistentLayerDesc` struct.
+    ///
+    /// When we want to reconstruct a page, we first find the `PersistentLayerDesc`'s that we need for page reconstruction, using `LayerMap`.
+    /// Then, we use `LayerFileManager` to get the `PersistentLayer`'s that correspond to the `PersistentLayerDesc`'s.
+    ///
+    /// In the future, we'll be able to split up the tuple of LayerMap and `LayerFileManager`,
+    /// so that e.g. on-demand-download/eviction, and layer spreading, can operate just on `LayerFileManager`.
     pub(crate) layers: Arc<tokio::sync::RwLock<(LayerMap, LayerFileManager)>>,

     /// Set of key ranges which should be covered by image layers to

looks good and added https://github.com/neondatabase/neon/pull/4437/commits/0b3e0dc35c5a11134a66ecc5fa0059a4fe9d9872 :)


Add span fields to events

I noticed that the fields on spans weren't appearing in Loki when I could see them in the console output while testing. Had a look in the code and saw that the span fields were being accumulated but were not sent along with the rest of the event data.

Could you instead add another struct field for the span fields with #[serde(flatten)]? This way, we can avoid some allocations.

Could you instead add another struct field for the span fields with #[serde(flatten)]? This way, we can avoid some allocations.

Good call. Done that now.
I did also have a question: what's the purpose of having both labels and extra_fields in the Layer? It was my understanding that you would define labels as application-level attributes, then define fields in spans or directly in events. What would you use the extra_fields in Layer for?

Thanks!

I did also have a question: what's the purpose of having both labels and extra_fields in the Layer? It was my understanding that you would define labels as application-level attributes, then define fields in spans or directly in events. What would you use the extra_fields in Layer for?

The idea is that labels should only be used for attributes that have a small amount of values, according to the Loki documentation. For stuff like a randomly generated run ID or a CI run number, this is inadequate because they have an infinite amount of possible values.

Do you need a new release with this commit?

Thanks!

I did also have a question: what's the purpose of having both labels and extra_fields in the Layer? It was my understanding that you would define labels as application-level attributes, then define fields in spans or directly in events. What would you use the extra_fields in Layer for?

The idea is that labels should only be used for attributes that have a small amount of values, according to the Loki documentation. For stuff like a randomly generated run ID or a CI run number, this is inadequate because they have an infinite amount of possible values.

Understood, thanks for the response.

Do you need a new release with this commit?

Yes please. It's not urgent though as I can point at the git repo directly in the mean time.

Released a new version tracing-loki 0.2.0 on crates.io. Sorry for the delay, when I tried publishing it last I got sidetracked looking up how to write a proper changelog.


event with startDate in the past shown in the upcoming events page

Describe the bug
Navigate to https://romajs.org/it/prossimi-eventi/  between 2024-08-22 and 2024-08-31
Current: The event 21 agosto 2024 is marked as upcoming.
Expected:  events with startDate in the past are NOT shown in the upcoming events page
Screenshot 2024-08-25

System Info
not relevant

Severity
major

The pipeline of the cronjob is not working properly: https://github.com/Roma-JS/roma-js-on-astro/actions/runs/10546849934/job/29218850872

Fixed by updating the GH token.


Add OCI Volume Source support to crictl [create|run] --with-pull

What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding support for the new OCI Volume Source feature.
Which issue(s) this PR fixes:
Refers to https://github.com/kubernetes/enhancements/issues/4639
Special notes for your reviewer:
Requires https://github.com/kubernetes/kubernetes/pull/125659
Does this PR introduce a user-facing change?
Added support to pull OCI object mounts on container creation if the `crictl [create|run] --with-pull` flag is specified.

/approve
/lgtm

New changes look good!
/approve
/lgtm

@kubernetes-sigs/cri-tools-maintainers PTAL

@kubernetes-sigs/cri-tools-maintainers PTAL

/approve
/lgtm


animatediff command not found on saturn cloud

hi, when I run generate codes on saturn cloud notebook it say "!animatediff command not found" but i runned that notebook on colab and it worked but while generating it disconnect the runtime

so, anyone can help me for this problem?


[Bug]: [Regression] No redirect on clicking the app link

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When I click on a link to an app, and I've not signed in. Upon signing in I'm taken to the apps home(app.appsmith.com). Then I have to come back and click the link again to open the app that I originally wanted to.
Do we know this, and shouldn't there be a redirect upon authentication to the original intended link?
Steps To Reproduce

Log out of app.appsmith.com
click this link: https://app.appsmith.com/app/appsmith-standup/standup-form-5fb67116322ddc249377f5eb?branch=master
you are prompted to login, so enter credentials and login
--> Expected result: upon successful authentication, you should see the stand up app
--> actual result: upon successful authentication, you see the apps home (https://app.appsmith.com/applications)

Public Sample App
No response
Version
Cloud

Duplicate of #14268


GPU Error with 'max_bin'

When set max_bin>255:
/install/anaconda3/lib/python3.7/site-packages/lightgbm/engine.py:150: UserWarning: Found `num_iterations` in params. Will use it instead of argument
  warnings.warn("Found `{}` in params. Will use it instead of argument".format(alias))
/install/anaconda3/lib/python3.7/site-packages/lightgbm/basic.py:1536: UserWarning: Using categorical_feature in Dataset.
  warnings.warn('Using categorical_feature in Dataset.')
[LightGBM] [Info] This is the GPU trainer!!
[LightGBM] [Info] Total Bins 3584
[LightGBM] [Info] Number of data points in the train set: 40695732, number of used features: 25
[LightGBM] [Info] Using requested OpenCL platform 0 device 1
[LightGBM] [Fatal] bin size 2946 cannot run on GPU
Traceback (most recent call last):
  File "base_model_gpu_v1.py", line 240, in <module>
    m_lgb = train_model(train_data,valid_data)
  File "base_model_gpu_v1.py", line 140, in train_model
    m_lgb = lgb.train(params, train_data, valid_sets = [valid_data], verbose_eval=50)
  File "/install/anaconda3/lib/python3.7/site-packages/lightgbm/engine.py", line 230, in train
    booster = Booster(params=params, train_set=train_set)
  File "/install/anaconda3/lib/python3.7/site-packages/lightgbm/basic.py", line 1976, in __init__
    ctypes.byref(self.handle)))
  File "/install/anaconda3/lib/python3.7/site-packages/lightgbm/basic.py", line 55, in _safe_call
    raise LightGBMError(decode_string(_LIB.LGBM_GetLastError()))
lightgbm.basic.LightGBMError: bin size 2946 cannot run on GPU

When set max_bin=255:
/install/anaconda3/lib/python3.7/site-packages/lightgbm/engine.py:150: UserWarning: Found `num_iterations` in params. Will use it instead of argument
  warnings.warn("Found `{}` in params. Will use it instead of argument".format(alias))
[LightGBM] [Info] This is the GPU trainer!!
[LightGBM] [Info] Total Bins 1898
[LightGBM] [Info] Number of data points in the train set: 40695732, number of used features: 25
[LightGBM] [Info] Using requested OpenCL platform 0 device 1
[LightGBM] [Info] Using GPU Device: TITAN RTX, Vendor: NVIDIA Corporation
[LightGBM] [Info] Compiling OpenCL Kernel with 256 bins...
[LightGBM] [Info] GPU programs have been built
[LightGBM] [Info] Size of histogram bin entry: 8
[LightGBM] [Info] 16 dense feature groups (620.97 MB) transferred to GPU in 0.544184 secs. 1 sparse feature groups
[LightGBM] [Info] Start training from score 0.312323
[LightGBM] [Fatal] Check failed: (best_split_info.left_count) > (0) at /install/LightGBM/src/treelearner/serial_tree_learner.cpp, line 628 .

Traceback (most recent call last):
  File "base_model_gpu_v1.py", line 242, in <module>
    m_lgb = train_model(train_data,valid_data)
  File "base_model_gpu_v1.py", line 139, in train_model
    m_lgb = lgb.train(params, train_data, valid_sets = [valid_data], verbose_eval=50)
  File "/install/anaconda3/lib/python3.7/site-packages/lightgbm/engine.py", line 251, in train
    booster.update(fobj=fobj)
  File "/install/anaconda3/lib/python3.7/site-packages/lightgbm/basic.py", line 2357, in update
    ctypes.byref(is_finished)))
  File "/install/anaconda3/lib/python3.7/site-packages/lightgbm/basic.py", line 55, in _safe_call
    raise LightGBMError(decode_string(_LIB.LGBM_GetLastError()))
lightgbm.basic.LightGBMError: Check failed: (best_split_info.left_count) > (0) at /install/LightGBM/src/treelearner/serial_tree_learner.cpp, line 628 .

When max_bin in (64,128):
OK!
Like #1116, but 3 years have passed, isn't there a better solution?
@guolinke You say GPU version cannot support categorical features with high cardinality. You can fix it by split one categorical feature into multi categorical features. What is number with high cardinality?  2?
What is standard toward high cardinality and max_bin?
Thx.

If you set max_bin < 255 can work, I don't think the problem is from categorical features.

@guolinke  I use all numeric features to work it, category features with gpu doesn't work. So I do not know What is number with high cardinality of category feature?  With all numeric features,  I also don't know what is number with max_bin can work.

@UlionTse set high cardinality <= 256 (max_bin)  should work.
for the Check failed: (best_split_info.left_count) > (0), it is a bug of current GPU implementation. So if you use small max_bin can work, you can use that temporarily.


Index passed to value functions does not respect original array order

When you call Velocity on an array of elements and use a  value function for one of the properties, the function receives an index as its first parameter.
You'd expect this index to always be the element's index in the array.
Nevertheless, the index is influenced by the elements' single per-element queues, which might lead to a totally different order: Here is a fiddle

Fixed


Monkey-Patch XMLHttpRequest.send() to send traceparent header and generate XHR span when the this method is called

I found out a bug in the xhr-interceptor when the XHR span is generated and the browser performance data is joined to the XHR span. The XHR span was being started when the XHR is in OPENED state (open() method is called), however, the http requests that the XHR generates are only done when the send() method is called. The problem here is that the method send() could be called a long time after  open() is called. This means that there might be a big gap between open() and send() calls, and within this gap, there might be requests from other interactions calling to the same URL, this will generate a wrong result in the performance resource timing selector, as those entries could have a better fit in the span.
The solution then is to monkey-patch XMLHttpRequest.send() to send the traceparent header and generate the XHR span when the this method is called, but before the HTTP requests are done.
This means that the Performance entries should fit almost exactly in the span's start/end times and the XHR span will actually measure the time taken by the XHR.

Codecov Report

Merging #142 into master will decrease coverage by 4.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   96.33%   91.47%   -4.87%
==========================================
  Files          31       31
  Lines         928      938      +10
  Branches      144      144
==========================================
- Hits          894      858      -36
- Misses         34       80      +46

Impacted Files
Coverage Δ

src/monkey-patching.ts
68.42% <0%> (-21.58%)
:arrow_down:

src/interaction-tracker.ts
76.15% <0%> (-17.22%)
:arrow_down:

src/perf-resource-timing-selector.ts
83.78% <0%> (-16.22%)
:arrow_down:

src/xhr-interceptor.ts
84.61% <0%> (-15.39%)
:arrow_down:

src/on-page-interaction-stop-watch.ts
95.65% <0%> (-4.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8abcac...713ee17. Read the comment docs.


Add additional network switches for devicelab racks

Please follow up with necessary netops team to get additional network switches installed for at least one (ideally all 3) of our additional racks in the devicelab.

Will do.

Hi @yusuf-goog Just checking... Are you still want me to following up with Network Teams on this service ticket?

We added our own switch to the rack. closing


Added SAST scans with Semgrep

What

Added static code scanning(SAST) with Semgrep OSS

Why
To improve the quality and security of the code. Find vulnerabilities.
Testing done
https://github.com/yeagerai/genlayer-simulator/actions/runs/10093296563/job/27908703416
Same like in the points system repo:
https://github.com/yeagerai/genlayer-points-system/actions/workflows/test-semgrep.yml

@cristiam86 @AgustinRamiroDiaz
Please review this PR

@YeagerAI-Bulat I have some doubts:

Given that it runs on a workflow, how will we be able to address these reports? What would be the developer flow? Should we go periodically and check the status of this job?


Remove superfluous query evaluation

Removed this superfluous query evaluation on a hot path.

deleted my fork but PR still valid.


libslang.so is duplicated in release archives

It's present in both lib and lib64
$ cmake --workflow --preset debug

<snip>

$ unzip -l build/dist-debug/slang.zip | grep libslang.so
207093392  01-01-1980 07:30   lib/libslang.so
207093392  01-01-1980 07:30   lib64/libslang.so

we should fix this before the next release

looks like it's caused by this https://github.com/shader-slang/slang/pull/5674


Fix Travis CI test

See https://travis-ci.org/TiagoDanin/Rock-Paper-Scissors-Web/builds/594217652?utm_source=github_status&utm_medium=notification. Problem with dependency

Hey @TiagoDanin, can I take this one, please?

Hey @TiagoDanin, can I take this one, please?

Yes :smile:


Initial architecture

Initial README and some architecture decisions.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


integration

Codecov Report

Merging #72 (5f68304) into master (780db06) will decrease coverage by 1.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   61.16%   60.09%   -1.08%
==========================================
  Files          30       30
  Lines        2243     2283      +40
  Branches      338      348      +10
==========================================
  Hits         1372     1372
- Misses        806      846      +40
  Partials       65       65

Impacted Files
Coverage Δ

adaptdl/adaptdl/torch/__init__.py
69.44% <0.00%> (ø)

sched/adaptdl_sched/supervisor.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 780db06...5f68304. Read the comment docs.


deepl.exceptions.AuthorizationException: Authorization failure, check auth_key

I have a valide auth_key but i still get this error

Hi @bengadi, this issue could be because your account is not a DeepL API Free or DeepL API Pro account, but some other type of DeepL account. Is this the case?

That is an unusual error. The problem seems to be related to your account. Can you please create a support request? Then we'll be able to look into your account.

I'm closing this issue now, please reopen it if you continue to have errors.


Formula request: fheroes2

fheroes2
Free Heroes of Might and Magic II (fheroes2) is a recreation of HoMM2 game engine.
Metadata

homepage URL: https://github.com/ihhub/fheroes2
source URL: https://github.com/ihhub/fheroes2/i
license: gpl2
platforms: linux, darwin

Relevant ticket: https://github.com/ihhub/fheroes2/issues/4169

Does existing package work for you as is?
https://github.com/NixOS/nixpkgs/blob/d7751c76153501c8b752be25e2f942d60fe24180/pkgs/games/fheroes2/default.nix

Actually it does. Thanks for the hint, I didn't know it's already available in unstable channel.


heap sort CPP code

Fixes #690
By submitting this pull request I confirm I've read and complied with the below declarations.

[x] I have read the Contribution guidelines and I am confident that my PR reflects them.
[x] I have followed the coding guidelines for this project.
[x] My code follows the skeleton code structure.
[x] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[x] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
[x] This pull request shall only be reviewed and merged once the Travis build passes. No maintainer or supporter shall be obliged to review it before this condition is met.
[x] I have mentioned the issue number correctly (with hyperlink) in this pull request description.

Output screenshots:

@nlok5923 add an ss or a GIF of the working of the code

@nlok5923 add an ss or a GIF of the working of the code

@yashshah2820 sir i had added the screen shots

@yashshah2820 sorry sir by mistake pr has been closed but i had reopened it now .

@nlok5923 lint the code according to the editorconfig

@yashshah2820  sir the code is formated according to editorconfig.

@iiitv/project-maintainers sir please can you review this pull request.


Failed to build

Hello.
I'm trying to install the latest version. I'm on the Almalinux 9.2 OS.
After a "git clone https://github.com/alchemy-fr/phrasea.git", I run bin/build.sh and I get the following error message:
bin/functions.sh: line 64: export: `BASH_FUNC_which%%=() { ( alias;': not a valid identifier
If I use release 1.0.12 it works ...
Any ideas?

Hello,
Here is the diff (at the moment writting) bin/functions.sh
Also, shell scripts now use docker compose instead of docker-compose which evaluates .env files differently.
Ensure are escaping values correctly in your .env.local (e.g. SECRET='my$Secret', note the single quotes).

First of all, thank you very much for your prompt reply.
I don't have an env.local file yet and, as a first step, I'm testing the installation with the .env provided ( without modifications ).
The docker-compose and docker compose commands work.

Can you please try with the latest commit?


Suggesion: Allow recursive/self-references in satisfies constraint

Suggestion
🔍 Search Terms

satisfies keyword, recursion, recursive, constraint, self referential
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code

It would only make previously rejected type assertions possible as it only widens the set of valid type restrictions.

[x] This wouldn't change the runtime behavior of existing JavaScript code

satisfies only exists during type checking and does not in generated JavaScript

[x] This could be implemented without emitting different JS based on the types of the expressions

As above

[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)

As above

[x] This feature would agree with the rest of TypeScript's Design Goals.

The same is already possible using a constrained identity function

⭐ Suggestion

It is currently not possible to reference the type of a variable that the satisfies constraint is applied on. Enabling this functionality should not be hard, as the same behavior can be recreated using a constrained identity function, see below. This would enable more precise verification of structures by the type checker.
📃 Motivating Example

// I define a (very simplified) state machine by the following type:
type States<S extends string> = Record<S, S>;

// I can then define a map of machine names to their states records:
const myMachines1 = {
  alan: {
    a: "b",
    b: "c",
    c: "c",
  },
  turing: {
    x: "y",
    y: "x",
  },
} satisfies Record<string, States<string>>;

// Problem: This is possible, though should be invalid:
const myMachines2 = {
  foo: {
    a: "x",
  },
  bar: {
    x: "a",
  }
} satisfies Record<string, States<string>>;

// Solution 1: Identity function with self-referential generic:
function defineMachines<T extends {
  [name in keyof T]: States<keyof T[name] & string>;
}>(machines: T) {
  return machines;
}

// Valid:
const myMachines3 = defineMachines({
  alan: {
    a: "b",
    b: "c",
    c: "c",
  },
  turing: {
    x: "y",
    y: "x",
  },
});

// Errors:
const myMachines4 = defineMachines({
  foo: {
    a: "x",
  },
  bar: {
    x: "a",
  }
});

// Solution 2: The same behavior should be achievable using the new `satisfies` keyword:
const myMachines5 = {
  foo: {
    a: "x",
  },
  bar: {
    x: "a",
  }
} satisfies {
  [name in keyof typeof myMachines5]: States<keyof typeof myMachines5[name] & string>;
};
// But errors: Block-scoped variable 'myMachines5' used before its declaration.

💻 Use Cases
As seen in the example above, this allows for a more precise control over (nested) type restrictions. It is already possible to self-reference type definitions, so why shouldn't this also be possible for variable declarations? The satisfies keyword does not modify the type itself to my knowledge.

The satisfies keyword does not modify the type itself to my knowledge.

It’s not supposed to, but in practice it triggers contextual typing which induces a circularity here (i.e. myMachines5 is contextually typed through itself).

I’m not super familiar with the compiler integrals but I believe in the case of recursive generics there’s logic for substituting T with some concrete constraint in order to resolve circularities like this.  That doesn’t apply for typeof localVar because it’s not generic - TS expects to be able to resolve it to a concrete type upfront.

The example as presented actually has a good opportunity to show what the true circularity involved really is here. Let's say you separated out the satisfies operator from the initializer, like this:
type States<S extends string> = Record<S, S>;

const myMachines5 = { // <- made valid
  foo: {
    a: "a",
  },
  bar: {
    x: "x",
  }
};

myMachines5 satisfies {
  [name in keyof typeof myMachines5]: States<keyof typeof myMachines5[name] & string>;
};

This is now an error because there wasn't any hint that foo.a should have the literal type a rather than string. The satisfies operator, were it not encountering a circularity, would be able to see that there should be a contextual type on the literal and it should have its literal type preserved. It's not technically circular because there's only one aspect of the type that needs to be resolved in order to produce the right result from keyof, but we don't have the machinery in place to do just half of some type resolution in this case and then come back to it later, knowing that the only thing we actually had to do was resolve the keyof operation. So it's very, very, very complicated to try to de-circularify this process.

@RyanCavanaugh is there a logical difference between the constrained identity and satisfies? I always think of them as equivalent, and they seem to be for all cases that came to my mind at least.

I have a related issue but with a simpler example ie
// y is typed
const y = {
//    ^?
    bar: () => 5,
    foo: () => y.bar() + 1
}

// x is any
const x = {
//    ^?
    bar: () => 5,
    foo: () => x.bar() + 1 // this causes the resulting type to be `any`
} satisfies Record<string, () => void>

Here satisfies seems to break typing if members of an object are used to define types of other members of an object. I would understand this causing an issue if the types were circular but in this case foo depends on bar and thats it, the compiler manages to resolve this without satisfies so I cant see why using satisfies would change this.
See playground:
https://www.typescriptlang.org/play?#code/PTAEE9QSwZ1AXcAHApgEwLACgDGB7AOxnglAF5QBvbEUO0APQH5t7QAjAQwCcAuUABQBKcgD5QAVgA0regDM8efsLEQAdF24qA1KACM2AL7YaYAB7Q4nAuGz4iJCxWpZa9ZrLqblIsuOmeoApKgr7iZho8OvqgtPAAFrCgOJwArjAocAkooNyZqQA28FAEAOYIyDnweBw5AAbW4HVGoDCcxTByUJmgAEoo+NxoADzE3CWlUqGqAG54UGiiQA


proposal: Go 2: Safer approach for directly calling functions from another package in Go

Go Programming Experience
Experienced
Other Languages Experience
Go, C++, TypeScript, PHP, JAVA
Related Idea

[X] Has this idea, or one like it, been proposed before?
[X] Does this affect error handling?
[X] Is this about generics?
[X] Is this change backward compatible? Breaking the Go 1 compatibility guarantee is a large cost and requires a large benefit

Has this idea, or one like it, been proposed before?
No
Does this affect error handling?
No
Is this about generics?
No
Proposal
Currently, when calling functions from another package in Go,
there are two main approaches:
Using var FunctionName = otherPackage.FunctionName,
Or using func FunctionName with linkname.
While the first approach is more aligned with Go's design principles,
it can be unsafe and may lead to unexpected behavior.
To address this issue, we propose a safer approach that leverages Go's type system to ensure type safety and better aligns with Go's design principles.
The proposed approach is to use the following syntax to call functions from another package:
func FunctionName = otherPackage.FunctionName

This approach ensures that the function being called is of the correct type and provides a more explicit and safer way to call functions from another package.
Justification
The proposed approach has several benefits:
Type Safety: By using the func keyword, we ensure that the function being called is of the correct type and avoids potential.
Better Alignment with Go's Design Principles: The proposed approach aligns with Go's design principles by providing a more explicit and safer way to call functions from another package.
Improved Readability: The proposed approach provides a clearer and more explicit way to call functions from another package, improving code readability and maintainability.
Language Spec Changes
No response
Informal Change
No response
Is this change backward compatible?
Yes,
The proposed change to use func FunctionName = otherPackage.FunctionName for calling functions from another package in Go is backward compatible.
This syntax enhancement does not break existing code or introduce any breaking changes.
It simply provides a more explicit and safer way to call functions, ensuring type safety and alignment with Go's design principles without affecting the compatibility with existing codebases.
Developers can choose to adopt this new syntax in their code while still maintaining compatibility with older Go code that uses the traditional method of calling functions from another package.
Orthogonality: How does this change interact or overlap with existing features?
No response
Would this change make Go easier or harder to learn, and why?
No response
Cost Description
No response
Changes to Go ToolChain
No response
Performance Costs
No response
Prototype
No response

Related Issues and Documentation

proposal: Go 2: allow packages to implement interfaces using .(package) syntax #28506 (closed)
proposal: Go 2: Function alias #58897 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

Why not directly call the function, like:
func FunctionName() {
    otherPackage.FunctionName()
}

@mateusz834
This approach has several pain points.

not flexible enough, if the function changes in other packages, you need to manually change the function you call
not concise enough, you need to define a function, and then call the function in other packages
not intuitive enough, it looks like a function, but in fact it is actually calling a function in another package

So more often than not,  var FunctionName = otherPackage.FunctionName is used.
Some global variables that can't be defined by const are at risk of being accidentally changed, not only functions, but also initial values defined by var, but it's more complicated with variables...
Because there is no readonly.
There are many uses of linkname in Go.
But I don't want to make heavy use of linkname in my packages

Duplicate of #58897


Fix a crash on client close

When a client closes a connection to a framed server the server was
crashing because the fact that the transport was framed was being
lost.  Looking through the file I noticed that the block from lines
87-95, looked different from the one from 59-66.  The culprit was
that when an error was occuring in the 59-66 block it was being
propagated up without rewrapping.  That would cause a failure
much further up the chain.  This patch fixes it.

Thanks for the fix - changes need a Jira ticket so we can track them through release notes.  See:
https://thrift.apache.org/docs/HowToContribute
Thanks!

This fix looks correct to me. The read and read_exact functions both pull the wrapped transport out of their state, and need to put the updated wrapped transport back into their state on return. The change fixes that in the error code path in the read function.

@dhull thank you!  Now we just need a Jira item for the change, and hopefully it sails through CI.

I added a jira ticket yesterday https://issues.apache.org/jira/browse/THRIFT-4339


Need to make Bars dashed in Bar type chart? i am using version 2.8

No built in method for that. Settings would need to be added to the rectangle object. This may be rather tough to implement given that the border is drawn using a special fill https://github.com/chartjs/Chart.js/blob/master/src/elements/element.rectangle.js#L154

Closing in favour of #6686 which has more discussion


:bug: [client] Start watching for sub-channel

Closes #251
Maybe add tests for watching sub-channels. We only test watching ledger channels.

Converting to draft, need to check a few things before we can review and merge.

@matthiasgeihs Changes related to fix the bug in Start Watching for sub-channels and the related tests that were added LGTM. However, I find the naming conventions were different from the one used for the other tests. Going by the existing convention, I think parts of code for Tim and Susie could go into a separate file and DisputeSusie, DisputeTim would be just Susie and Tim (just like Mallory and Carol). What do you think ?

We already were using a mixed naming convention. For the role tests, we were using specific first names. The virtual channel test however works differently, for a number of reasons I won't go into here. I found it hard to come up with new names this time, hence the naming I chose. I also think it's more expressive to name the tests by what they do instead of "TestHappySusieTim". We place the code of the two roles in one file together also for the sub-channel happy tests.

Also, I was not able to clearly follow the other changes (additional checks for withdraw, register). Are they related to this change ? If yes, could you provide some additional context about these changes in the commit message ?

The mock backend has only very limited functionality for testing exactly what we need in the relevant test cases. For making dispute tests work with the mock backend, I had to enhance it's functionality. Before it was mostly used for happy case testing.

Addressed all comments, still playing around with the timeout in the virtual channel dispute tests. I was hoping that I could decrease it a bit, but doesn't seem to be the case...

CI stability issues seem actually somewhat unrelated to the timeout in the virtual channel dispute test. At least it is not the virtual channel tests failing anymore.
I also saw that when the ledger channel watcher is shutting down, it sometimes errors with Error de-registering channel from watcher: cannot de-register when sub-channels are present.

Force push:

Fixed an issue where under certain circumstances an event was written to a closed event channel.
Fixed an issue where the test expected to receive events for registration of version 0 and version 1, while this may not be true as our event subscription logic may skip outdated events.

The last commit fixes an issue where a panic in one of the role executions was not propagated and thus resulting in a deadlock because the waitHandler was waiting for the client to be closed.

@matthiasgeihs LGTM overall. I have two minor suggestions:

Naming of runAliceBobTest, which I have mentioned above.
Reg the commit messages. Could you wrap the body of the commit message at 72 characters ? It is a widely used limit that makes the commit history more readable across different tools.

Rebase


/Zc:__cplusplus: linker input file not found: No such file or directory

When I use vcpkg install glog， meet a problem /Zc:__cplusplus: linker input file not found: No such file or directory

Problems were encountered while collecting compiler information:
cc1plus.exe: fatal error: /Zc:__cplusplus: No such file or directory

We do not maintain the vcpkg version of glog. Please submit the issue to the corresponding tracker.


Missing comma

There is missing comma at the end of that line.

Sorry for not getting to it earlier, can you rebase and i'll merge!

@brentvatne are you able to merge code under Examples/ or does that have to be done by FB folks? Seems like there is consensus here and @vjeux has blessed it.

@vjeux - This is the one I pinged you about on irc, seems pretty small. Would be nice if we could move the Examples dir out of the FB sync process with the exception of UIExplorer and SampleApp so I don't have to bother you with these things.

Yeah, need to figure a solution for those


Update page title & description

Title: Microk8s
Desc: Kubernetes for workstations and appliances.

Hi @Greggless ,
That should be MicroK8s (with capital K), right?
You want me to update the README and docs, what else?

Thanks @ktsakalozos. If you could update the README and docs with microk8s MicroK8s where applicable, that would be wonderful.
We're currently whipping the docs up into webpages in this pull request.


refactor build facility for speed and simplicity

Subject.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.75%. Comparing base (339409c) to head (159878a).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   91.75%   91.75%
=======================================
  Files          12       12
  Lines        1274     1274
=======================================
  Hits         1169     1169
  Misses         77       77
  Partials       28       28

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Shows "Invalid Date" on Calendar

The calendar pop-ups with the text "Invalid Date" on it, why is this so?
I am using it with Bootstrap 4.3. All the dates of the month are not appearing on the calendar and instead of day, month, year, it shows "Invalid Date". Can't I use it on the multiple pages by changing the id of inputs...
Please tell me the solution to this issue, I am working on an important project...

Same problem, do you have a fix?


Add template support to the completion provider

Remaining work is to provide a useful templates.json. @deltakosh

You rock