Change to prettify.js for better React support

I have been using this library in my latest create-react-app project. Whenever running Yarn Build which calls the build react-script, the uglify process errors on src/prettify.js due to the ES6 syntax of the modules.export object. By updating the syntax, as done here, the build process can run without error.

Sure thing. Thanks for the PR


chore(backend): added logging to chunking

sometimes the backend is not able to chunk the full text from the pdfs because of file not found errors.

@shauryr This LGTM, but do you have a sense of why this is happening? Was it just something that came up in your debugging?
I don't think it should have we happening in the app since the frontend knows all the file paths and passes them to the backend.

@shauryr This LGTM, but do you have a sense of why this is happening? Was it just something that came up in your debugging?
I don't think it should ever happen unless there is a bug on the front end, since the frontend knows all the file paths and passes them to the backend.

@gjreda when I ran the ingest command, the chunks variable was empty for me in references.json file. On closer inspection I found that for just chunking the code was not able to find the pdfs in the directory it was looking for.
Then I found out that python is writing .staging, .storage and .grobid to a different folder than the UI. Python was writing these folder to a dir outside refstudio dir in my dev work folder while UI was doing it here /Users/shaurya/Library/Application Support/studio.ref.desktop/project-x.
It maybe an issue because I have configured the project incorrectly. Am I doing something wrong here?

Then I found out that python is writing .staging, .storage and .grobid to a different folder than the UI. Python was writing these folder to a dir outside refstudio dir in my dev work folder while UI was doing it here /Users/shaurya/Library/Application Support/studio.ref.desktop/project-x.

This sounds like it is related to your environment variables. The application passes the env variables on each call to the sidecar (here), whereas if you are running just the python cli app, it will be using whatever env variables you have set.


Document release process

Once #790 has been resolved, document the process for creating a release.

#790 has been closed

@dcolligan, can you update the docs following your experience with v0.2.2 please?

Fixed in #1114


Rename Conversation to Assistant

@ljbennett62 another ask to review please, also travis is failing, i don't think it's related to this PR since we only changed .md files.


Error when changing stages

Describe your bug here.
This occurred just now.
So, basically if I open the chart editor, change the stage and play the song, I get this error:
PlayState.hx (line 2610)
PlayState.hx (line 2465)
PlayState.hx (line 1084)
flixel/FlxGame.hx (line 637)
flixel/FlxGame.hx (line 724)
flixel/FlxGame.hx (line 677)
flixel/FlxGame.hx (line 551)
openfl/events/EventDispatcher.hx (line 402)
openfl/display/DisplayObject.hx (line 1399)
Uncaught Error: Null Object Reference
This didn't happen before. I haven't modified PlayState.hx in any way.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, I edited MainMenuState.hx and made all items go to the left side of the screen.

Seems like you're trying to use an event hardcoded to one stage, if so this is not a bug

Seems like you're trying to use an event hardcoded to one stage, if so this is not a bug

Ahh thanks, I'm gonna take a guess that it was the dad battle spotlights.


Issue with elide_fill_value

If I run in the dev branch
cargo run -- import my.n5 dataset '{"type": "gzip"}' 256,256,5 data/*.png --elide_fill_value 0
I get errors:
thread '<unnamed>' panicked at 'attempt to multiply with overflow', /HOMEDIR/.cargo/registry/src/github.com-1ecc6299db9ec823/image-0.20.0/./src/buffer.rs:375:36
However, I run n5gest on master with same parameters n5gest import ... the process works correctly. Any idea what may cause the 'multiply with overflow'?

Strange, this is a bug in an upstream library, but it should be locked to the same version in dev and master still. In your dev branch copy try changing this one line:
diff --git a/Cargo.toml b/Cargo.toml
index c382a25..5589701 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -34,7 +34,7 @@ structopt = "0.2"
 serde_plain = { version = "0.3", optional = true }

 [dependencies.image]
-version = "0.20"
+version = "0.21"
 # Don't include jpeg_rayon dependency, hdr which includes scoped_threadpool, or ico.
 default-features = false
 features = ["gif_codec", "jpeg", "png_codec", "pnm", "tga", "tiff", "webp", "bmp", "dxt"]

Duh, the reason it wasn't happening in your master copy is that it's release mode and won't catch the integer overflow. Since you are overflowing, though, you should use the new version of image (that patch will select 0.21.3, the overflow was prevented in 0.21.1).

After some tests, this should be fixed in dev. Reopen if not. image will get bumped again before the next release for other features, but at least the overflow is fixed for now.

Indeed, this works now. Thanks!


Avoid C4819 warning during bootstrap-vcpkg.bat

Comment-only modification but fixes #15093 .
The C4819 warnings are introduced by UTF-8 characters in the comments.
So, I converted UTF-8 characters into Laten-1 ASCII characters.

LGTM.

Thanks!

Approved and merged within a day !
I'm happy such quick contribution. Thanks !


What happened?
The test beam_PreCommit_Python_Integration on Python 3.8 seems flaky.
https://github.com/apache/beam/actions/runs/6892029627/job/18748399857?pr=29360
The traceback is as follows.
> Task :sdks:python:test-suites:dataflow:py38:installGcpTest
  Building wheel for apache-beam (pyproject.toml): finished with status 'done'
  Created wheel for apache-beam: filename=apache_beam-2.53.0.dev0-cp38-cp38-linux_x86_64.whl size=16363509 sha256=5188645586567251024513a88bbac31956362cf76ce808a27745ece6c90683be
  Stored in directory: /home/runner/.cache/pip/wheels/6e/01/46/5eabd0c59402eb4e4ae5cb7edaa4433429fc8f45b9fa05dcc2
Successfully built apache-beam
Installing collected packages: sortedcontainers, pytz, pyjsparser, docopt, crcmod, zstandard, zipp, wrapt, websocket-client, urllib3, typing-extensions, threadpoolctl, tenacity, sqlparse, six, rpds-py, regex, pyyaml, pyparsing, pymysql, PyJWT, pyhamcrest, pycparser, pyasn1, pyarrow-hotfix, psycopg2-binary, protobuf, portalocker, pkgutil-resolve-name, parameterized, overrides, orjson, objsize, numpy, mock, joblib, jmespath, iniconfig, idna, grpcio, greenlet, google-crc32c, fasteners, fastavro, execnet, exceptiongroup, dnspython, dill, deprecation, cloudpickle, charset-normalizer, certifi, backports.zoneinfo, attrs, tzlocal, sqlalchemy, shapely, scipy, rsa, requests, referencing, python-dateutil, pytest, pymongo, pydot, pyasn1-modules, pyarrow, proto-plus, isodate, importlib-resources, hypothesis, httplib2, googleapis-common-protos, google-resumable-media, cffi, scikit-learn, requests-mock, pytest-xdist, pytest-timeout, pandas, oauth2client, jsonschema-specifications, js2py, hdfs, grpcio-status, google-auth, freezegun, docker, cryptography, botocore, azure-core, testcontainers, s3transfer, jsonschema, grpc-google-iam-v1, google-auth-httplib2, google-apitools, google-api-core, azure-storage-blob, msal, google-cloud-core, boto3, apache-beam, msal-extensions, google-cloud-vision, google-cloud-videointelligence, google-cloud-storage, google-cloud-spanner, google-cloud-resource-manager, google-cloud-recommendations-ai, google-cloud-pubsub, google-cloud-language, google-cloud-dlp, google-cloud-datastore, google-cloud-bigtable, google-cloud-bigquery-storage, google-cloud-bigquery, google-cloud-pubsublite, google-cloud-aiplatform, azure-identity
Traceback (most recent call last):
  File "/runner/_work/beam/beam/build/gradleenv/1922375555/bin/cibuildwheel", line 8, in <module>
    sys.exit(main())
  File "/runner/_work/beam/beam/build/gradleenv/1922375555/lib/python3.8/site-packages/cibuildwheel/__main__.py", line 129, in main

    build_in_directory(args)
  File "/runner/_work/beam/beam/build/gradleenv/1922375555/lib/python3.8/site-packages/cibuildwheel/__main__.py", line 248, in build_in_directory
    cibuildwheel.linux.build(options, tmp_path)
  File "/runner/_work/beam/beam/build/gradleenv/1922375555/lib/python3.8/site-packages/cibuildwheel/linux.py", line 384, in build
    build_in_container(
  File "/runner/_work/beam/beam/build/gradleenv/1922375555/lib/python3.8/site-packages/cibuildwheel/oci_container.py", line 134, in __exit__
    self.process.wait(timeout=30)
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/subprocess.py", line 1083, in wait
    return self._wait(timeout=timeout)
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/subprocess.py", line 1814, in _wait
    raise TimeoutExpired(self.args, timeout)
subprocess.TimeoutExpired: Command '['docker', 'start', '--attach', '--interactive', 'cibuildwheel-6e61cc96-1004-4d5e-88af-79f343c048bd']' timed out after 30 seconds

Issue Failure
Failure: Test is flaky
Issue Priority
Priority: 2 (backlog / disabled test but we think the product is healthy)
Issue Components

[ ] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

The test passed when I re-ran it the second time. https://github.com/apache/beam/actions/runs/6892029627/job/18750293487?pr=29360
@Abacn mentioned the flakiness may be caused by spinning off multiple docker containers (in our case 2) at the same time in GHA.

Yes, this is flaky and being tracked in https://github.com/apache/beam/issues/28703. I have oncall rotation coming next week. if no one picks it up, I will try to look into this during my rotation.

Closed as duplicate of #28703


旭日图label 颜色在交互中变化bug

Issue Type

[ ] I have a question to ask about how to use ECharts to ...；我想提问如何使用 ECharts 实现某功能
[x] I have a bug to report；我想要报 bug
[ ] I have a feature to request, e.g.: I'd like a new feature that ...；我需要一个新功能
[ ] I have a feature to enhance, e.g.: The current feature should be improved in the way that ...；我希望改进某个功能
[ ] There's something wrong with the documents；文档有些问题
[ ] Others, or I'm not sure which issue types to choose here；其他，或我不知道应该选什么类型

Issue Details
旭日图设置label minAngle属性，点击不含label item， zoom in, 再点击中心 zoom out，再点击不含label item，则整个旭日图 label 颜色发生变化

Expected Behavior

旭日图label颜色不发生变化

Current Behavior

旭日图label 颜色 发生变化

Online Example

http://gallery.echartsjs.com/editor.html?c=xnaTN9oHIF&v=1

Topics

Anything Else We Need to Know

Environment

ECharts version；ECharts 版本: {4.2.0}

[ ] It happens only on certain browsers or operating systems. 对于特定浏览器或操作系统才会出现的问题，请提供相应环境信息：{BROWSER_VERSION_OR_OS_INFORMATION_HERE}

Can't reproduce the bug


RDK-48604 New UserSettings Thunder Plugin

Reason for change: Adding IUserSettings.h interface file.
Test Procedure: Build and verify

Copyright scan failure
Commit: 672c9ba8fd4f560638fc3bf8ddb41891ada12fff
Report detail: https://gist.github.com/rdkcmf-jenkins/8278d182a815f33a4c98c4ca81102b3f

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/ThunderInterfaces/342/rdkcentral/ThunderInterfaces

Commit: 672c9ba8fd4f560638fc3bf8ddb41891ada12fff

Report detail: gist

Hi Sithanda:
Please add a credit for Synamedia to the NOTICE file by appending:
Copyright 2024 Synamedia Ltd.
Licensed under the Apache License, Version 2.0

Thank you - Martin Hughes, RDK CMF Compliance Team

Copyright scan failure
Commit: 1cb4e3797bf9eba0801cf9b2d8166bd0dec720c7
Report detail: https://gist.github.com/rdkcmf-jenkins/145a52c30f0d0441d7819fe25c79e1e3

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/ThunderInterfaces/342/rdkcentral/ThunderInterfaces

Commit: 1cb4e3797bf9eba0801cf9b2d8166bd0dec720c7

Report detail: gist

Copyright scan failure
Commit: 0c7176978f4abf3989c398753c1aca5532ad9539
Report detail: https://gist.github.com/rdkcmf-jenkins/e82623b9b16ac296b1972a77bd92ab85

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/ThunderInterfaces/342/rdkcentral/ThunderInterfaces

Commit: 0c7176978f4abf3989c398753c1aca5532ad9539

Report detail: gist

Copyright scan failure
Commit: 0c7176978f4abf3989c398753c1aca5532ad9539
Report detail: https://gist.github.com/rdkcmf-jenkins/0ecd4b06bbada4263b80911773047110

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/ThunderInterfaces/342/rdkcentral/ThunderInterfaces

Commit: 0c7176978f4abf3989c398753c1aca5532ad9539

Report detail: gist

Copyright scan failure
Commit: de59d531d967fba741f8ff3a5ee67d47fc78f365
Report detail: https://gist.github.com/rdkcmf-jenkins/1e38979c796c3ba1363e97e832c35050

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/ThunderInterfaces/342/rdkcentral/ThunderInterfaces

Commit: de59d531d967fba741f8ff3a5ee67d47fc78f365

Report detail: gist

Hi Sithanda: Please add a credit for Synamedia to the NOTICE file by appending:
Copyright 2024 Synamedia Ltd.
Licensed under the Apache License, Version 2.0

Thank you - Martin Hughes, RDK CMF Compliance Team

Thanks Martin, Now added the credit of synamedia in NOTICE file.

Please hold the merge of this review. We have few things to be taken care before it is ready to be merged.

Cancel this PR as per @ramasat comment.


Checking boxes on pagination - what actions should be available?

We can check boxes on tables, but for what we can use it?

I can't imagine any uses for payments and tickets. Checkboxes make some sense only in services table: mass renewal, unifying renewal dates, etc.

Maybe ticket and payment archiving? I use it a lot in in Gmail.


forgot password system

We need a forgot password system

link on log in page
reset password page, protected with a hash
email link with hash
expire hash after 10 minutes
explain the above on the page after the click on "forgot password"

Closed with PR #350
@mookman288 thanks for your previous work on this! Apologies for taking so long to get it merged in.


Add papers endpoints

Is your feature request related to a problem? Please describe.
For issue https://github.com/ag-gipp/NLP-Land-frontend/issues/8 we need to implement some things in the backend.
Describe the solution you'd like
Implement the following:

[x] An endpoint which offers paging for the retrieval of papers
[x] An endpoint which aggregates and counts the papers by year

Added in #40


opts.[direction].title should accept string and function

Did you check the docs?

[X] I have read all the edgy.nvim docs

Is your feature request related to a problem? Please describe.
It would be awesome if opts.[direction].title can accept a string and a function (the functions must return a string).
Two use cases:
bottom = {
    {
        -- Indicate in the windbar which help file is currently open
        title = function() local bufname = vim.api.nvim_buf_get_name(0)
            bufname = vim.fn.fnamemodify(bufname, ':t')
            return string.format('HELP: %s', bufname)
        end,
        ft = 'help',
    },
    {
        -- Indicate whether the location list or quickfix list is currently
        -- displayed
        title = function()
            local loclist = vim.fn.getwininfo(vim.fn.win_getid())[1]['loclist'] == 1
            return loclist and 'LOCATION LIST' or 'QUICKFIX LIST'
        end,
        ft = 'qf',
    }
}

Describe the solution you'd like
opts.[direction].title accepts string and function
Describe alternatives you've considered
Disabling the winbar winbar = false for a filetype and handling it manually with my winbar plugin. However this is a workaround and i'd love to handle all the winbar titles in edgy.nvim
Additional context
No response

I realized I can solve the second use case with the filter() function:
{
    title = 'QUICKFIX LIST',
    filter = function(_, win)
        return vim.fn.getwininfo(win)[1]['loclist'] ~= 1
    end,
    ft = 'qf',
},
{
    title = 'LOCATION LIST',
    filter = function(_, win)
        return vim.fn.getwininfo(win)[1]['loclist'] == 1
    end,
    ft = 'qf',
},

However, in cases where a single filetype covers various instances, like help documents and manpages, it would be very helpful to have the filename or bufname included in the winbar information. This feature request is kindly submitted for consideration, aiming to enhance user experience.


AdcFifo not configurable with DynPin

To configure the channel used by AdcFifo, one has to call the following function on AdcFifoBuilder:
     pub fn set_channel<PIN: Channel<Adc, ID = u8>>(self, _pin: &mut PIN) -> Self {

But for DynPin, Channel is defined with ID = (). Therefore, set_channel can't be with a DynPin as its parameter.

DynPin can be "concretised" before being used in the AdcFifoBuilder.

Is it the intended way of using it?
OneShot has a separate implementation for that case, so read can be called directly on a DynPin. IMHO it would be more consistent if all functions were callable on the same set of types (as long as it's meaningful).

As long as the required configuration is applied on the pin before the sampling and restored when the pin's no longer used as adc input, it's fine by me :)

As long as the required configuration is applied on the pin before the sampling and restored when the pin's no longer used as adc input, it's fine by me :)

As long as the required configuration is applied on the pin before the sampling and restored when the pin's no longer used as adc input, it's fine by me :)

The additional impl should still require an AdcPin<Pin<DynPinId, F, M>>, just with a where bound AdcPin<Pin<DynPinId, F, M>>: Channel<Adc, ID = ()> or similar. So the proper configuration should already be in place.


Re-using account from certbot client with letsencrypt-aws?

Is it possible to use an acme account created for another certificate request done with the official certbot client? I was looking around for a pem file created by certbot (to be used as private key in place of the one created with letsencrypt-aws as described in the readme) and couldn't find it.
In the end, my question is: is the above possible or should I create an account with the command in the README? If it's possible, any hint on where certbot stores that private key?
Thanks

It should be possible, but I don't know where certbot stores the key.
On Thu, Aug 25, 2016 at 6:44 PM, Matteo Scotuzzi<EMAIL_ADDRESS>wrote:

Is it possible to use an acme account created for another certificate
request done with the official certbot client? I was looking around for a
pem file created by certbot (to be used as private key in place of the one
created with letsencrypt-aws as described in the readme) and couldn't find
it.
In the end, my question is: is the above possible or should I create an
account with the command in the README? If it's possible, any hint on where
certbot stores that private key?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/alex/letsencrypt-aws/issues/76, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAADBFt-8FWRssoC6JbatooNzsj830mHks5qjhrVgaJpZM4Jtk-0
.

--
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: D1B3 ADC0 E023 8CA6


Structuted Gradient Tree Boosting

There's a typo, it's structured not structuted for the repo description.

Fixed. Thanks!


Feature Idea - File Browser

Hi!
I guess it could be a cool feature when Metro UI delivers the follow option for the File Browser.
At the moment the File Browser offers the a bar and a "data-caption"/Icon.
I think its could be cool when the File Browser offers the same function but just with an icon.
Idea when a file is picket:
The input field adds on the right site a little checkmark.
What you think?
Greets

In 4.2.22 I add new mode drop for input[data-role=file]

Great work!


Unable to use pymetamap in windows

I installed the pymetamap setup in windows and try to use it, but the metamap instance was unable to extract concepts from the sentences. I tried to run the same code given i.e

from pymetamap import MetaMap
mm = MetaMap.get_instance('...../public_mm/bin/metamap14')
sents = ['Heart Attack', 'John had a huge heart attack']
concepts,error = mm.extract_concepts(sents,[1,2])
but after this I get the error:
Traceback (most recent call last):
File "", line 1, in
File "C:\Anaconda2\lib\site-packages\pymetamap-0.1-py2.7.egg\pymetamap\Subproc
essBackend.py", line 127, in extract_concepts
os.remove(input_file.name)
WindowsError: [Error 32] The process cannot access the file because it is being
used by another process: 'c:\users\abhila~1.kas\appdata\local\temp\tmp00rn
u0'
I have metamap14 installed on my pc.

Currently the Subprocess backend does not work with windows currently. This is because I'm using NamedTemporaryFile. I will see what I can do to get it to work for you.

Thanks for your response, I would be grateful to you if you could help me in this.

Any update on this ?

Send me an email at<EMAIL_ADDRESS>I will send a zip file with a quick fix. I'm not really sure if I want to officially support Windows.

Is it possible to share the solution? Cheers

I am using Linux and I am having also problems with the Subprocess Backend. This is the error that appears.
_Traceback (most recent call last):
File "metamap_trying.py", line 6, in
concepts, error=mm.extract_concepts(sents, [1,2])
File "/home/ijauregi/Desktop/CMCRC/pymetamap-master/pymetamap/SubprocessBackend.py", line 117, in extract_concepts
metamap_process = subprocess.Popen(command, stdout=subprocess.PIPE)
File "/usr/local/python-2.7/lib/python2.7/subprocess.py", line 710, in init
errread, errwrite)
File "/usr/local/python-2.7/lib/python2.7/subprocess.py", line 1335, in execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
Do you know why is that?

Have a code sample?
Have you installed metamap? It looks like you may not be pointing to the correct metamap file.

You were right. I wasn't pointing to the correct Metamap file. Anyway, now I have a different problem. This is my error:
Berkeley DB databases (USAbase 2016AA strict model) are open.
Static variants will come from table varsan in /home/ijauregi/Desktop/CMCRC/Journal-Inigo/public_mm/DB/DB.USAbase.2016AA.strict.
Derivational Variants: Adj/noun ONLY.
Variant generation mode: static.

###MetaMap ERROR: Calling socket_client_open for TAGGER Server on host localhost and port 1795:
error(system_error,system_error(SPIO_E_NET_CONNREFUSED))

My code is the following:
from pymetamap import MetaMap
mm=MetaMap.get_instance('/home/ijauregi/Desktop/CMCRC/JournalInigo/public_mm/bin/metamap16)
sents=['Heart Attac','John had a huge heart attack']
concepts, error=mm.extract_concepts(sents, [1,2])
for concept in concepts:
    print concept

Thanks

I found the problem. I forgot to initialize the SKR/Medpost Part-of-Speech Tagger Server and the Word Sense Disambiguation (WSD) Server. I have first initialize them and now the code works.
Thank you anyway!

Glad you got it to work!

Is there any alternative way to make this work in windows.

Hi! Is it possible to share to workaround for getting this API wrapper working in Windows? I am working on a project but have a windows platform.

For me it's not working in Windows, installed the same in Linux machine and
made it work
On 07-Dec-2017 5:32 PM, "abhinavmishra590"<EMAIL_ADDRESS>wrote:
Hi! Is it possible to share to workaround for getting this API wrapper
working in Windows? I am working on a project but have a windows platform.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/AnthonyMRios/pymetamap/issues/1#issuecomment-350115004,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AReZTvDRrGSzg9sOsadjeitroBuKqDj4ks5s-GdrgaJpZM4Hp-md
.

Hi @AnthonyMRios ,
I have tried using the pymetamap on the windows OS.
It does get installed successfully, but when I try to run it over some sentences, it gives me an OS Error.
Runs Perfectly:
from pymetamap import MetaMap mm = MetaMap.get_instance(r'C:\Users\Kanishk Verma\Desktop\Radmol AI\MetaMap\public_mm\bin\metamap14') sents = ['Heart Attack', 'John had a huge heart attack']
Gives Error
concepts,error = mm.extract_concepts(sents,[1,2])
Error

OSError: [WinError 193] %1 is not a valid Win32 application

During handling of the above exception, another exception occurred:

PermissionError: [WinError 32] The process cannot access the file because it is being used by another process:

I checked the file in the temporary directory, but it is not being used by other applications.


feat(PyPI): add PyPI support

:tada: This PR is included in version 4.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[FEAT] Allow setting entrypoint in opaClient rather than package

It wasn't clear from the docs what the name of the rule which was to be evaluated should be, as only the package was requested in configuration. The name shouldn't matter however, and I think it would be preferable if the user could set an entrypoint instead of a package. Entrypoints would be either a package or a package/rule combination and using any level of nesting, like policy, policy/backstage/permissions or policy/backstage/permissions/decision.

Just adding some notes here so that I do not forget :sweat_smile:

Move away from response.decision.result so that users can set their own entrypoint (decision)

This would mean they do not need to evaluate the whole policy.


Does it support chinese ner task?

Yes. It supports any sequence labeling task includes Chinese.

Thanks ！


User is not Authenticated in app.components

I have below client setting :
export function getClientSettings(): UserManagerSettings {
  return {
    authority:environment.authApiURI,
    client_id: 'clientid',
    redirect_uri: environment.redirect_uri,
    post_logout_redirect_uri: environment.postLogoutRedirectUri,
    response_type: "id_token token",
    scope: "openid spa profile",
    filterProtocolClaims: true,
    loadUserInfo: true,
    automaticSilentRenew: true,
    silent_redirect_uri:environment.silentRedirectUri,
    userStore: new WebStorageStateStore({ store: localStorage })
  };
}

and AuthService is like this :

  private _authNavStatusSource = new BehaviorSubject<boolean>(false);

  authNavStatus$ = this._authNavStatusSource.asObservable();

  private manager = new UserManager(getClientSettings());
  private user: User | null;

  constructor(private http: HttpClient) {
    super();
    this.manager.getUser().then(user => {
      this.user = user;
      this._authNavStatusSource.next(this.isAuthenticated());
    });
  }

  login() {
    return this.manager.signinRedirect();
  }

  async completeAuthentication() {
    this.user = await this.manager.signinRedirectCallback();
    this._authNavStatusSource.next(this.isAuthenticated());
  }

  register(userRegistration: any) {
    return this.http.post(environment.authApiURI + '/account', userRegistration).pipe(catchError(this.handleError));;
  }

  isAuthenticated(): boolean {

    return this.user != null && !this.user.expired;
  }

  get authorizationHeaderValue(): string {
    return `${this.user.token_type} ${this.user.access_token}`;
  }

  get name(): string {
    return this.user != null ? this.user.profile.name : '';
  }

  async signout() {
    await this.manager.signoutRedirect();
  }
}

and I have an interceptor to add bearer token to all requests
import { Injectable } from "@angular/core";
import { Router } from "@angular/router";
import { HttpInterceptor, HttpRequest, HttpHandler, HttpEvent } from '@angular/common/http';
import { Observable } from "rxjs"
import { AuthService } from "./auth-service";

@Injectable()
export class AuthInterceptor implements HttpInterceptor {
  private authorizationHeader = "Authorization";

  constructor(
    private authService: AuthService,
    private router: Router) { }

  intercept(request: HttpRequest<any>, next: HttpHandler): Observable<HttpEvent<any>> {

    request = request.clone({
      headers: request.headers.set(this.authorizationHeader, this.authService.authorizationHeaderValue)
    });

    return next.handle(request);
  }

}

In app.component I call a service which is like this:
ngOnInit(): void {
   this.dashboardService.getDashboards().subscribe();
  }

but When this method calls, in the interceptor user is not authenticated. but in other components user is authenticated, I mean I call isAuthenticated() from auth.service  in app.component ngOnInit() and it return true which means the user is authenticated.
I searched a lot but could not find a similar issue.

I know this is stale, but I'm trying to get caught up. Do you think there is a bug, or was this issue just a question?

I know this is stale, but I'm trying to get caught up. Do you think there is a bug, or was this issue just a question?


Add register & profile performance profiling, disable jobs and allow dismissing loader view

IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #[issue number] or Closes #[issue number]
Engineer Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app

Code Reviewer Checklist

[ ] I have verified Unit tests have been written for any new feature(s) and edge cases
[ ] I have verified any strings visible on UI components are in the strings.xml file
[ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
[ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
[ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@ellykits Here is the code for profiling
Attached is the data set that should be loaded with app/debug since this allows the app to load resources from local configs
resources.zip
Make sure to run
CREATE INDEX IF NOT EXISTS `index_DateTimeIndexEntity_index_from` ON `DateTimeIndexEntity` (`index_from`)

on the database before copying it onto the device to replace the current one

can we make this configurable with a debug or a new profile flag and get this merged in?

the commented jobs that is

@pld We are considering writing benchmarks for specific areas of code using Jetpack Microbenchmark library. After the kotlin DSL migration PR is merged and dependencies upgraded. Closing this PR (was used while measuring register/profile) data load performance - currently being undertaken by the QA team.
cc: @ekigamba


ARROW-6065: [C++][Parquet] Clean up parquet/arrow/reader.cc, reduce code duplication, improve readability

This is strictly a refactoring PR. I'm going to start working (for a new PR) on some refactoring of the handling of schemas and nested types (which is also pretty messy in my opinion). The motivation for this is to be able to more cleanly reason about direct dictionary-decoding without having to resort to such hacks as the current FixSchemas function
Also cleans up Parquet includes using IWYU

@emkornfield I'm also trying to clean up some business logic in such a way that it will help you with implementing nested reads, though there is little enough logic related to nested data that you might want to start fresh anyway

Codecov Report

Merging #4963 into master will increase coverage by 1.64%.
The diff coverage is 90.65%.

@@            Coverage Diff             @@
##           master    #4963      +/-   ##
==========================================
+ Coverage    87.5%   89.14%   +1.64%
==========================================
  Files         998      722     -276
  Lines      141869   101612   -40257
  Branches     1418        0    -1418
==========================================
- Hits       124139    90587   -33552
+ Misses      17368    11025    -6343
+ Partials      362        0     -362

Impacted Files
Coverage Δ

cpp/src/parquet/column_writer.h
88.88% <ø> (ø)
:arrow_up:

cpp/src/parquet/file_reader.cc
94.3% <ø> (ø)
:arrow_up:

cpp/src/parquet/statistics.h
100% <ø> (ø)
:arrow_up:

cpp/src/parquet/bloom_filter.cc
91.13% <ø> (ø)
:arrow_up:

cpp/src/parquet/encoding.cc
93.73% <ø> (ø)
:arrow_up:

cpp/src/parquet/types.cc
93.76% <ø> (ø)
:arrow_up:

cpp/src/parquet/statistics.cc
87.96% <ø> (ø)
:arrow_up:

cpp/src/parquet/file_writer.h
100% <ø> (ø)
:arrow_up:

cpp/src/parquet/schema.cc
90.07% <ø> (ø)
:arrow_up:

cpp/src/parquet/arrow/writer.h
100% <ø> (ø)
:arrow_up:

... and 300 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171c3f7...cf9f5e3. Read the comment docs.

I'll address a couple comments in my follow up patch. I'm going to merge this so I'm not stacking up patches

@wesm thanks, I've been a little delayed with the parquet stuff and this week, I'd like to try to knock off java/c++ compatibility since it seems you still have a few more patches to do.

@emkornfield yes, I'll let you know when it's the "all clear" viz-a-viz refactoring


Remove Meecreeps from world

With the new limit to how many MeeCreeps you can have, is there a way you can terminate jobs if you can't find them?

Use the /creep_clear command


Added testing coverage for schema::types

Basic test coverage for schema::types. It's mostly straightforward. If anything more required let me know.

As usual, can you pls run cargo fmt?

Not sure what's happening. I did run cargo fmt multiple times. Did you push the update or I need to do it?

Pushed with cargo fmt.


Full width banner images

I'd like to have the option to stretch the image to the full width of the page.
Is this planned for a future release? Is there some other additional plugin I can use to achieve this?
Thank you for the work you have done on this library.
Cheers
Mulaiko

It's piece :cake:. Those image styles are meant to be extended. You can add your own like this:
$('.editable').mediumInsert({
    editor: editor,
    addons: {
        images: {
            styles: {
                wide: {
                    label: ''
                }
            }
        }
    }
});

Example: https://github.com/orthes/medium-editor-insert-plugin/blob/gh-pages/index.html#L155

Hi @orthes
Thanks for your reply.
I think I may have worded my initial comment incorrectly.
What I'm asking for is the actual "full width image stretch" functionality. I want to be able to embed an image that then can be stretched to the full width of the page.
Cheers

I understand. There is no built-in functionality like this and there'll never be. The plugin is meant to be extended and you should add your own styles. There is no universal solution for this. Every website has it's own layout, etc. You have to create this yourself.
Just add a new style like I've shown you above. This will create a new icon in toolbar and when you click on it, it will add this class to image container: medium-insert-images-wide
This way you can use this class and style it as you want:
.medium-insert-images-wide {
    width: 100%;
    // ...
}

The style will depend on your page layout.

@orthes There is just a 'medium-insert-images' when image attached. A 'medium-insert-images-wide' class will added at least click the image alignment toolbar. (Maybe this is bug, need to create issue)


Development server issues

I randomly get this error in the terminal from the development server
[2] /Users/cmichael/repos/patternfly-next/node_modules/yoga-layout-prebuilt/yoga-layout/build/Release/nbind.js:53
[2]         throw ex;
[2]         ^
[2]
[2] TypeError: Cannot read property 'write' of null
[2]     at Zlib.callback (zlib.js:499:33)
[2] gatsby develop exited with code 7

Zack recommended the fix in https://github.com/gatsbyjs/gatsby/issues/14553, which increases the system's file watcher limit. I've verified that it's writing this out to /etc/sysctl.conf and persists after rebooting
marvin:patternfly-next cmichael$ grep max_user_watches /etc/sysctl.conf
fs.inotify.max_user_watches=524288

Also updates to .hbs and the component example .md files aren't always reflected in the browser. However simply stopping the server and restarting (and sometimes after removing the .cache dir) will reflect the changes.
Occasionally something really weird happens - I'll make a change and don't see it in the browser, so I make some other change, then I see the original change but not the new change. Then I make another change, and see the previous change, but not the new one. I've verified I'm giving the server plenty of time to rebuild and reflect the change in the browser. Restarting the server will fix that, too.
cc @redallen @evwilkin

:tada: This issue has been resolved in version 2.57.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


AttributeError: 'Client' object has no attribute 'send_message'

I have got this Error and I don't know how to fix it, please help me

I believe the error is because you are using a recent version of discord.py and the bot was made on discord.py version 0.16, which you'll need to install for the bot to work.
something like   pip install discord.py==0.16.6    should, I believe, work

I got another error :(((

can you try this
https://github.com/Rapptz/discord.py/commit/1863a1c6636f53592519320a173ec9573c090c0b

can you try this
Rapptz/discord.py@1863a1c

Have the same problem, tried to solve it with the link you posted but it wasn't possible. I am currently running Python 3.8.2 and downgraded discord's dependency. It would be awesome if you could take a look. Thanks.


Split package:pack CLI command in helpful classes

The package:pack CLI command is very helpful: it can create a ZIP archive containing a package, compiling SVG icons to PNG images, creating .mo translation files from .po files, excluding dot files, etc...
All that also for legacy (5.6-) packages.
BTW that CLI command is very ugly (shame on me - I'm its author), and its code is hard to maintain and it really can't be used for any other purpose.
So, what about splitting it into some helpful classes?
In particular, this PR introduces:

a pretty nice offline package analyzer: given the path to the package controller.php file it can extract the package handle/version/name/description/minimum concrete5 supported version (yes, also for legacy packages). And this PR includes tests to be sure that it works
an easily customizable and extensible system to filter/process the package files.

I strongly believe that point 1. could be also used to do some pretty nice fancy stuff for PRB: at the moment users have to upload their packages and manually declare the package details (name, version, minimum core version, ...). With the code introduced in this PR all this could be done automatically (just upload the package archive and the system does all that magic). And that could be very useful if the core team implements some kind of integration between PRB and packages hosted on GitHub (IIRC PortlandLabs mentioned that - somewhere at some point)

There's a lot going on in this pull request – can we close it and move it into the 8.6.x-dev branch and then we can take a look at it?

can we close it and move it into the 8.6.x-dev branch and then we can take a look at it?

Sure: see #7969


:config task does not replace https port -1

$ rake neo4j:config[env] sets the http/s ports to 0 / -1
$ rake neo4j:config[env,7474]...

claims to set them to 7474 / 7473
actually changes only the http port, leaving 7474 / -1

Faulty regex — (\w+) in Neo4j::RakeTasks::ServerManager#modify_config_file
doesn't match the - in -1.
Easy fix: change it to (-?\w+) (or maybe you want the regex more general?).
The StarnixServerManager#config examples are a little, um, 'sparse' at the moment. :smile:
Better to check the actual saved config value(s) directly?
Is there a good/preferred way to do that?

Probably would be good to make it more general.  I would say that we could just match any character until the end of the line.
And yeah, the specs could definitely use some work ;)
Probably if we had specs for it we could just have a simple file (or maybe it could be refactored to work on a string) with just the property (or not).  Testing various values should do it.
I think also that config should require an argument for the port


FirebaseApp.delete() still has dangling thread

[REQUIRED] Step 2: Describe your environment

Operating System version: Windows 10
Firebase SDK version: 5.3.1
Library version: ?
Firebase Product: app

[REQUIRED] Step 3: Describe the problem
After app.delete(), there is still dangling thread. Bug can be reproduced on both 5.2.0 and latest 5.3.1 releases.
Steps to reproduce:
Run a trivial task, such as getUser, and call app.delete() after task complete. In my IDE, I observed three threads were created: pool-2-thread-1, pool-2-thread-2, pool-3-thread-1. After a while, pool-2-thread-[1,2] exited but pool-3-thread-1 is still dangling.
Relevant Code:
A trivial java test program
app = FirebaseApp.initializeApp(options);
Task<UserRecord> task = auth.getUser(uid);
task.addOnCompleteListener(new OnCompleteListener<UserRecord>() {

  @Override
  public void onComplete(Task<UserRecord> task) {
    app.delete();
  }
});

Test program won't exit after task completed.
Looks like TokenRefresher was not exiting. I have to add this hack after app.delete() call:
FirebaseExecutors.DEFAULT_SCHEDULED_EXECUTOR.shutdown();

Fix for this issue was released today: https://firebase.google.com/support/release-notes/admin/java#5.4.0
When running on the regular JVM, all threads will be started as daemons, which won't cause the process to stay alive. The FirebaseApp.delete() method can also be invoked to further guarantee a clean graceful shutdown (although this is not required). Proactive token refresher will not start until RTDB code is invoked.


Fetch

Fetch is mentioned several times on this page but is not in any of the code snippets.
Solution: Code snippets need to be updated to match what is on github.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 583ae3e7-5915-f22b-e54c-6c100cf2a7da
Version Independent ID: 95f2549e-29f9-e31a-b4d0-432b971643ff
Content: Tutorial: Create a web API with ASP.NET Core
Content Source: aspnetcore/tutorials/first-web-api.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@scottaddie  5 minute fix.

@Rick-Anderson I'll take a look.


Chore: update context.tf, build-harness assets

what

Update context.tf
Update build-harness assets by running make github/init.
Clean up unused providers
Drop Terraform support prior to 0.13

why

The latest version of context.tf (null-label:0.25.0), contains new labels. A module instantiating this module with version 0.25.0 of null-label and making use of new labels will not be able to use this module.
Running make github/init updates build-harness assets, which includes GitHub Actions Workflows and related files.
The latest distribution of context.tf (null-label:0.25.0) is not compatible with Terraform 0.12.* because it makes use of validation blocks.

references

https://github.com/cloudposse/terraform-null-label/releases/tag/0.25.0
closes #41

/test all

/test all


Hand E gripper Control

Script Control for the Robotiq Hand E Gripper

The Scripts needs to handle :

Configuration of the Baudrate and Timeout settings
Resetting of the Gripper
Activation  of the Gripper
Sending the Position command for the gripper

The xArm services for the actions listed in the https://github.com/Extend-Robotics/xarm_ros/issues/5#issuecomment-1683650525 could be found in the https://github.com/xArm-Developer/xarm_ros/issues/194#issuecomment-1650959335 and https://github.com/xArm-Developer/xarm_ros/issues/194#issuecomment-1655787899

The gripper_control_robotiq.py was created to make the service calls for the actions listed above.
The scripts when started :

Configures the Baudrate to 115200 ( specified for Robotiq Gripper) and timeout to 3ms
Resets the gripper and Activate it using the Modbus commands in the services /xarm/getset_tgpio_modbus_data
Subscribes to the topic /extend_gripper_command which contains the gripper position command from the AMAS App.
Send the position received in the topic to the gripper.

Changes in the commit : 62c10d6


Update the README.md file to describe the repo.

Maybe we can practice putting some description to the PR briefly describing at least:

What was changed?
Why was that need to be changed?

So reviewer can get an idea of the goal before looking into the code change?

Maybe we can practice putting some description to the PR briefly describing at least:

What was changed?
Why was that need to be changed?

So reviewer can get an idea of the goal before looking into the code change?

I update the PR comments:) Thanks for pointing that out!

One extra thing to practice. Maybe assign a label on the right side panel?
For this test PR, maybe we can assign an existing "documentation" label.

One extra thing to practice. Maybe assign a label on the right side panel?
For this test PR, maybe we can assign an existing "documentation" label.

Add the label just now:)


Support lists for "installs"

Hey,
I really like the idea of rotz. I saw the example for installs and was missing the ability to install a list of tools.
Let me outline my idea:

I have config.yaml with variables

variables:
  packages:
    darwin:
      - visual-studio-code
      - vim
      - rustup
    linux:
      - vscode
      - emacs
      - golang

I have a dot.yaml where I want to install a set of packages

darwin:
  installs:
    cmd: brew install {{ <package> }}
    # packages: {{ variables.darwin }}
    depends:
      - brew
linux:
  installs:
    cmd: yay install {{ <package> }}
    # packages: {{ variables.darwin }}
    depends:
      - yay

As rotz supports arrays, there could be a packages property for installs to install more than one package with cmd

Does this make any sense?
I'm happy to discuss the idea or answer any follow-up questions :)
Cheers
Stefan

Hey, something like this is already possible in two ways 😁
Option 1
One way is to basically do it like you suggested using variables and templates:
darwin:
  installs:
    cmd: |
      {{ #each config.variables.packages.darwin }}
        brew install {{this}}
      {{ /each }}
    depends:
      - brew
linux:
  installs:
    cmd: |
      {{ #each config.variables.packages.linux }}
        yay install {{this}}
      {{ /each }}
    depends:
      - yay

This works since the cmd key is just a shell script.
You could actually do it even more simple just like that:
darwin:
  installs:
    cmd: |
      brew install visual-studio-code
      brew install vim
      brew install rustup
    depends:
      - brew
linux:
  installs:
    cmd: |
      yay install vscode
      yay install emacs
      yay install golang
    depends:
      - yay

Option 2.a
The second way works using defaults files.
It is more complex but has the advantage of each application being split up into its own folder (but that's personal perference I guess ^^)
In the repo you have a file structure like that:
├── visual-studio-code
│   ├── ...
│   └── dot.yaml
├── vim
│   ├── ...
│   └── dot.yaml
├── rustup
│   ├── ...
│   └── dot.yaml
├── emacs
│   ├── ...
│   └── dot.yaml
├── golang
│   ├── ...
│   └── dot.yaml
└── defaults.yaml

In the defaults.yaml file you specify the default install commands:
darwin:
  installs:
    cmd: brew install {{ name }}
    depends:
      - brew
linux:
  installs:
    cmd: yay install {{ name }}
    depends:
      - yay

now you setup the dot.yaml files
vim/dot.yaml
linux:
  installs: false # by setting this to false it will not use the default on linux and will not be installed on linux

rustup/dot.yaml
linux:
  installs: false

emacs/dot.yaml
darwin:
  installs: false # by setting this to false it will not use the default on macos and will not be installed on macos

golang/dot.yaml
darwin:
  installs: false

visual-studio-code/dot.yaml
linux:
  installs: yay install vscode # Override the command because the package name is different on linux

Option 2.b
Basically the same thing as option 2.a but using multiple defaults.yaml files for each OS.
├── visual-studio-code
│   ├── ...
│   └── dot.yaml
├── darwin
│   ├── vim
│   │   ├── ...
│   │   └── dot.yaml
│   ├── rustup
│   │   ├── ...
│   │   └── dot.yaml
│   └── defaults.yaml
└── linux
    ├── emacs
    │   ├── ...
    │   └── dot.yaml
    ├── golang
    │   ├── ...
    │   └── dot.yaml
    └── defaults.yaml

And the darwin/defaults.yaml looks like this:
darwin:
  installs:
    cmd: brew install {{ name }}
    depends:
      - brew

the linux/defaults.yaml looks like this:
linux:
  installs:
    cmd: yay install {{ name }}
    depends:
      - yay

and the exception is the visual-studio-code/dot.yaml
darwin:
  installs: brew install visual-studio-code
linux:
  installs: yay install vscode

Something that would solve the problem of different package names in the second option would be to add support for a name key to the dot.yaml files where you could overwrite the package name 🤔
something like:
vscode/dot.yaml
darwin:
  name: visual-studio-code
linux:
  name: vscode

defaults.yaml
darwin:
  installs:
    cmd: brew install {{ name }}
    depends:
      - brew
linux:
  installs:
    cmd: yay install {{ name }}
    depends:
      - yay

Hey,
Option 1 seems more like the thing I want. Option 2... is cool, but I want to maintain a list of all my packages in a central place.

I thought as much 😁 If that works for you I'll close the issue

Yeah sure, thanks for the suggestions :)


Test with Python 3.13

Note that wheels are not yet published, because Python 3.13 is not yet ABI stable.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.00%. Comparing base (41248ed) to head (e0648a5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
+ Coverage   92.55%   93.00%   +0.45%
==========================================
  Files          91       94       +3
  Lines       11304    11408     +104
  Branches     1581     2089     +508
==========================================
+ Hits        10462    10610     +148
+ Misses        837      798      -39
+ Partials        5        0       -5

Flag
Coverage Δ

cpp
93.00% <100.00%> (+7.06%)
:arrow_up:

python_and_cython
93.00% <100.00%> (-2.72%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Moulin initial: support moulin build

The domf,domd and dom0 have been adjusted to meet the prod-aos requirements.
Build is base at yocto 5.1, main stream is dunfell.
Supported machine is h3ulcb-ab
User domain DomF is supported by default.
Signed-off-by: Ihor Usyk<EMAIL_ADDRESS>

not relevant


Card: Remove try/catch from Approve Order Flow

Summary of changes

This PR removes try/catch from CardClient.approveOrder()
To do this, we've renamed ConfirmPaymentSourceResponse to ConfirmPaymentSourceResult and made it a sealed class with .Success and .Failure subclasses
Also in Kotlin try/catch is unchecked, meaning the compiler will not notify us when we call a method that throws outside of a try/catch block.
Using "Result" types cleans up the codebase by providing compile time support for error handling

Checklist

[ ] ~Added a changelog entry~

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire

It's cleaner but just double checking my understanding of the Kotlin code, you were catching all the exceptions in the try catch block yourself in the functions, right?


Create business-readiness.md

Signed-off-by: Elizabeth Barron<EMAIL_ADDRESS>

@eyehwan thank you! 🤩 Do you want to go ahead and merge this too?

My pleasure :)


It does not work with DNG (but with BMP)

Hi,
First of all, thanks for this great script. 👍
I've noticed that it does not work with DNG files. But if I convert the DNG files to BMP first the script is working.
Regards
Mark

Try opening the DNG using the Windows Photo app. If that doesn't work, you are probably missing a CODEC and once that's installed for Windows, this script should work with that file.


could not complete the  picoScan launch process without any error report.

Dear sir
When I launch picoScan,it always stop in the process but without error report.
Ping the picoScan is ok and I tested the driver with TiM240 is ok.Seems the Ethernet connection and build driver are ok.
please refer to below file of the launch streaming and help to analysis what is the reason.
picoScan launch streaming record.md

Thanks for your feedback and log file. The picoScan lidar was successfully initialized via TCP, but did not send any scan data via UDP. Most likely the given parameter udp_receiver_ip is incorrect.
Parameter udp_receiver_ip must be set to the ip address of the local machine, i.e. the computer running sick_scan_xd.  This is the IP address to which the lidar sends the scan data via UDP. You can find it e.g. with ifconfig -a.
The call roslaunch sick_scan_xd sick_picoscan.launch hostname:=<IP_ADDRESS> udp_receiver_ip:=<IP_ADDRESS> is often used as an example. Replace <IP_ADDRESS> with the ip address of your local machine running sick_scan_xd.

Thanks for the recommend and that is the reason, Before I used the PC IP and solved this question after switch to Vmware IP.


V2 questions aren't numerated correctly

From Slack:
Also on https://www.zowe.org/vnext#latest-announcements page, the questions aren't numerated correctly (1. xxx, 1.xxx, 1.xxx etc) small things I'm finding randomly but nbd :slightly_smiling_face:

From Slack:
Also on https://www.zowe.org/vnext#latest-announcements page, the questions aren't numerated correctly (1. xxx, 1.xxx, 1.xxx etc) small things I'm finding randomly but nbd 🙂

I have corrected the numbering in after forking the repo in my profile. Also do I need to correct that in vNext.md? I have corrected it in a .gitignore file named vNext.html
I am new to opensource contribution and if this pull request gets accepted it is going to be my first contribution.

Fixed now.


City Record civic.json

{
"status": "Beta",
"thumbnailUrl": "http://assets.nydailynews.com/polopoly_fs/1.1683036!img/httpImage/city-record-jpg.jpg",
"bornAt": "City Hall",
"geography": "NYC",
"politicalEntity":"NYC City Council",
"type":"Dataset",
"needs": [
{"need": "NLP experts"},
{"need": "Python Devs"},
{"need": "Data Wranglers"},
],
"categories": [
{"category": "Finance"},
{"category": "Procurement"},
{"category": "Open Data"},
{"category": "Human Resources"},
]
}

@jqnatividad -- is this a project submission? We do have the city record project...

Yes. It is known as the CityRecord Online project < https://github.com/CityOfNewYork/CROL-PDF >


Add tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f87eb56) 100.00% compared to head (1f28745) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##                main      #181   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity       586       586
===========================================
  Files             53        53
  Lines           1809      1809
===========================================
  Hits            1809      1809

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remote read in Store API has a high overhead

Thanos, Prometheus and Golang version used:
thanos, version 0.8.1 (branch: HEAD, revision: bd8278859b2321aaaa7514edde764816cc039d34)
  build user:       root@2227d9a2fdb1
  build date:       20191014-12:03:55
  go version:       go1.13.1

prometheus, version 2.14.0 (branch: HEAD, revision: edeb7a44cbf745f1d8be4ea6f215e79e651bfe19)
  build user:       root@df2327081015
  build date:       20191111-14:27:12
  go version:       go1.13.4

/usr/bin/thanos sidecar --log.level=info --log.format=logfmt --grpc-address=<IP_ADDRESS>:10901 --http-address=<IP_ADDRESS>:10902 --prometheus.url=http://localhost:9090/prometheus --tsdb.path=/opt/prometheus/data --objstore.config-file=/etc/thanos/s3.yaml
/usr/bin/thanos query --log.level=info --log.format=logfmt --grpc-address=<IP_ADDRESS>:10903 --http-address=<IP_ADDRESS>:10904 --query.partial-response --store=localhost:10901
/opt/prometheus/prometheus --config.file=/etc/prometheus/prometheus.yml --web.external-url=http://<IP_ADDRESS>:9090/prometheus/ --storage.tsdb.path=/opt/prometheus/data --storage.tsdb.retention.time=6h --storage.tsdb.max-block-duration=2h --storage.tsdb.min-block-duration=2h --query.timeout=30s --query.max-concurrency=8 --web.enable-admin-api

Object Storage Provider:
S3
What happened:
Response time is 10 times slower using Store API than using Prometheus API endpoint for specific requests.
What you expected to happen:
Less overhead in response time using Store API.
How to reproduce it (as minimally and precisely as possible):
Compare response time during querying data with large amount of samples.
Anything else we need to know:
I have built a very simple setup to rid of any overhead by network and other components:
Thanos query --> Thanos sidecar --> Prometheus
Each of it runs on the same server and  loopback interface is used for IPC.
So there are two queries which are self-explanatory:
$ curl -sw '%{time_total} %{size_download}\n' -o /dev/null 'http://localhost:10904/api/v1/series?match[]=http%3Ainternal_request_client%3Aresponses_by_path'
9.869466 27584266
$ curl -sw '%{time_total} %{size_download}\n' -o /dev/null 'http://localhost:9090/prometheus/api/v1/series?match[]=http%3Ainternal_request_client%3Aresponses_by_path'
1.227189 22965566

As the result I got a response with ~35700 series.
Response size from Store API is larger due to lack of external labels in Prometheus API's response. Don't know whether it is expected behavior or not.
I tried querying with older Prometheus instance before remote read streaming was implemented and after ~7 seconds I get an error about exceeding sample limit while using Store API:
desc = query Prometheus: request failed with code 400 Bad Request; msg exceeded sample limit (50000000)

Requesting directly from the Prometheus API still works though.
As I can see, Prometheus is a bottleneck during the Store API querying wastes a lot of CPU cycles.
There are flamegraphs which can help to shed light on the root cause of this overheard. The short.svg and long.svg were recorded during the Prometheus API and Store API querying respectively. GitHub doesn't allow to attach SVG files so had to use shared hosting. Sorry about that.

I may suggest that there is some inefficient algorithm with querying metadata from Prometheus (/series endpoint) using remote read API comparing to HTTP Prometheus API.

Hi, thanks for reporting!
It looks to me like there is no regression, you just ask for a huge amount of data, and in previous Prometheus, we shutdown on a huge amount of samples, vs in newer we rely on latency and timeout.
Thanks for the flamegraphs, it actually shows things as expected, the majority of CPU is spent on encoding chunks. To resolve this we need: https://github.com/prometheus/prometheus/pull/5882 .. need to get back to this (:
I have two ideas on how to improve things even further:

Extend Series method of StoreAPI with some onlySeries bool or enum. This is to let know all implementations to do not send any samples, just labels of series. We might adjust the response, or just stream series with zero chunks. I think the latter makes sense.
Sidecar then based on this can decide to use series API of prometheus instead of remote read (:

cc @GiedriusS @squat to check on me if that makes sense (:

We propose this: https://github.com/thanos-io/thanos/issues/1822

One of the real use case.
There is a label_values function in Grafana templating which is relies on /series API calls. So, some invocations with a huge amount of series can be much slower using Thanos query rather than Prometheus.


Table breaking

Is it possible to prevent a table from breaking at the end of a page by completely moving it to the next one?

Not at the moment, though we could consider adding it.
This comes at a pretty high performance cost the way that Prawn works, though, because we have to render the whole table into a draft document to determine its height. We do that with other blocks already, but tables are the most complex thing to render, hence the reason its the highest cost.
What I recommend doing now is add manual page breaks temporarily once the document reaches a stable state (such as at a release). It's a manual typesetting step, but at least it gives you the result you desire currently.

We might be able to use the before_rendering_page page hook in Prawn::Table.

There's a whole bunch of related stuff in issue #2082

Related to #2022

In the upcoming release of Asciidoctor PDF 2.0, you will be able to prevent an orphaned table caption by assigning the option breakable to a table.
.Optional table caption/title
[%breakable]
|===
|Content |Content

|Content |Content
|===

Note that the table will still break if it flows from the current page to the next page. The breakable option only prevents the table caption (and ID, if one is assigned) from being orphaned. (We decided it was best if people choose to opt-in to this behavior due to the potential performance costs in some cases.)
Also, you'll be able to assign the unbreakable option to a table if you don't want it to break and flow to the next page when it doesn't fit on the current page.
.Optional table caption/title
[%unbreakable%header,cols="2*"]
|===
|Content
|Content

|Content
|Content
|===


Add a posibility to define initial balance for solidity unit tests

[x] I've asked for help in the Truffle Gitter before filing this issue.

Issue
The unit test contract has zero balance by default and that's why It's impossible to execute transactions.
It makes unit tests not as useful as they could be.
Steps to Reproduce
Try to use send in a unit test.
Expected Behavior
I expected them to have some initial ballance (like every account in testrpc has 100 ETH).
Actual Results
They're empty.
Environment

Operating System: macos
Truffle version: 3.0.5
Ethereum client: testrpc
node version: v7.5.0
npm version: 4.1.2

Another thing that we should consider is that if solidity unit tests would cause non-const calls than we would need to see and check the results of those calls. (instant blocks).
I have two solutions.

auto mine a new block after each transaction (using testrpc evm_mine)
have some instruction inside of the code itself to triger a new block. Both have their issues and limitations.

1st - Is limiting cause it does not allow you to test multiple transactions in the single block.
2nd - Solidity does not have such an instruction. And it breaks the EVM abstraction a lot. I don't like leaky abstractions. Maybe sol tests should be for constant functions only and js tests should be for interactions? But then we could as well just use JS tests.

Your last comment ^ should be a discussion in a different thread, as it's
not related to the initial balances for solidity tests. Let's chat on
gitter, and if in agreement make a new ticket.
On Feb 3, 2017 9:00 AM, "Leonid"<EMAIL_ADDRESS>wrote:

Another thing that we should consider is that if solidity unit tests would
cause non-const calls than we would need to see and check the results of
those calls. (instant blocks).
I have two solutions.

auto mine a new block after each transaction (using testrpc evm_mine)
have some instruction inside of the code itself to triger a new
block. Both have their issues and limitations.

1st - Is limiting cause it does not allow you to test multiple
transactions in the single block.
2nd - Solidity does not have such an instruction. And it breaks the EVM
abstraction a lot. I don't like leaky abstractions. Maybe sol tests should
be for constant functions only and js tests should be for interactions? But
then we could as well just use JS tests.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ConsenSys/truffle/issues/344#issuecomment-277302339,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFp1ZORuBaNJhU7b8x6i46PN6nniNECks5rY10xgaJpZM4L2juc
.

This was already added in Beta and will go out with the next release. Document here: http://truffleframework.com/docs/getting_started/solidity-tests#in-beta-testing-ether-transactions


After removing tag, auto-complete list doesn't open again

I am having this issue as well. So basically you have to click somewhere outside the input tag element and then click it again.

This issue was selected to be spring-cleaned by a script. More information can be found here.
If anyone thinks this was a mistake and this issue should be reopened, please leave a message below explaining why. Before doing so, please consider reading the CONTRIBUTING file.


Record when a visitor first loads the site to track visitor counts

In order to show the effectiveness of the site we need to record when visitors come to the site, this can be done by registering a callback when the site first loads. We should include country information if the user approves geo-location in the browser (only country information and nothing more specific) otherwise just record it as an anonymous visit.
These state will eventually allow us to create a report of where visitors are coming from to the Gates Foundation but also to show the number of visits in the statistics section of the homepage.
Acceptance Criteria:

[ ] A visit is recorded on the server when the site is loaded.
[ ] If the user consents to using their location then a country is recorded with their visit.
[ ] If the user doesn't consent to use their location then just an anonymous visit is recorded.

Superseded by #286


Issue with styling because of "wrapper"

Hello,
I'm having a few issues with the styling of this plugin because of "wrapper".
I'm incorporating this plugin into my website and this is what the issue looks like:

There is a big space between the name of the field and the component "textbox"
{
   "fields":[
      {
         "featured":false,
         "label":"Firstname",
         "disabled":false,
         "readonly":false,
         "model":"firstname",
         "type":"input",
         "inputType":"text"
      },
      {
         "featured":false,
         "label":"Second Name",
         "disabled":false,
         "readonly":false,
         "model":"second-name",
         "type":"input",
         "inputType":"text"
      },
      {
         "rows":4,
         "hint":"Max 500 characters",
         "max":500,
         "label":"Description",
         "placeholder":"",
         "model":"description",
         "type":"textArea"
      }
   ]
}

Here is a picture of the error css

I am using the "Uplon" theme from themeforest.

Sorry a wrapper div is necessary for most fields, since template must start with a single element.
Good luck !

YEs, but you can't use generic class.
make your own Classes or don't give Wrapper
its toooooo generic class.

I think we can probably provide some more advanced form level options, which would allow devs to override or amend their own classes at every level of the hierarchy.  We could also prefix all the internal classes with something like “vfg-“ so there are no conflicts with popular frameworks such as bootstrap.
For example a “wrapperClass” property that defaults to “vfg-wrapper”, but can be changed to anything.

Compatibility its key, rather than building a full CSS framework for it ill rather extend functionality by setting a value for main frameworks boostrap3 or 4 , etc.
(Former)[https://github.com/formers/former] for Laravel does it very clever in this aspect.
The wrapper right now breaks all apart.
Happy Days!

I agree with this - had to restyle my wrapper class myself because of it. At least prefix all classes with "vfg-" - that would allow for easier styling and would definitely solve these issues.

Maybe, it's too late to answer this and have solved, maybe you do not need it for another reason.
Even so, I leave my solution in case I can help someone.
I think you can create your "form wrapper class" and assign it globally to the form or you can add styleClasses in the fields that you need.
{
   "fields":[
      {
         "featured":false,
         "label":"Firstname",
         "disabled":false,
         "readonly":false,
         "model":"firstname",
         "type":"input",
         "inputType":"text",
         "styleClasses":"vfg-field-wrapper"
      }
   ]
}

With this css:
.vfg-field-wrapper .wrapper{
 /* changes that you need */
}

Maybe, it's too late to answer this and have solved, maybe you do not need it for another reason.
Even so, I leave my solution in case I can help someone.
I think you can create your "form wrapper class" and assign it globally to the form or you can add styleClasses in the fields that you need.
{
   "fields":[
      {
         "featured":false,
         "label":"Firstname",
         "disabled":false,
         "readonly":false,
         "model":"firstname",
         "type":"input",
         "inputType":"text",
         "styleClasses":"vfg-field-wrapper"
      }
   ]
}

With this css:
.vfg-field-wrapper .wrapper{
 /* changes that you need */
}


Incorrect results computing against interactive dict data

This introduces a failing test for interactive computation on a list-of-dictionaries. No solution as yet but opening the PR should allow the Travis-CI tests to complete, and provide a place for discussion. The test is in blaze/compute/tests/test_python_compute.py and named test_selection_interactive.
The test can be run on its own with:
py.test blaze/compute/tests/test_python_compute.py::test_selection_interactive

Having done some more work digging into this, as far as I can tell the issue seems to be that in some cases when we are mapping functions across iterators, an iterator's __next__ is being called while somewhere else there is another reference to the same iterator, which is not getting its state restored appropriately. (My best guess is in the pre_compute function here). Thus the iterator is advancing twice as fast as desired.

Closing to cleanup old PRs. Feel free to submit a new PR.


[ES] Translated Lighthouse

What's changed, or what was fixed?

src/content/es/tools/lighthouse/index.md

Fixes: #8928
Target Live Date: YYYY-MM-DD - not sure what this is. Also, in the file there's a "last updated" date, should I manually change it or will it change automatically on new deployment?

[ ] This has been reviewed and approved by (NAME)
[X] I have run npm test locally and all tests pass.

Note: There are no errors but some warnings have shown, it seems to detect slices of words like "programatic", which comes from the spanish word "programaticamente" as a typo. Is there a way to discard the warning?

[ ] I have added the appropriate type-something label.

What is this? I've read the contributing but this wasnt there

[X] I've staged the site and manually verified that my content displays correctly.

CC: @petele

Hi @petele! Have you been able to see this?

Hi @chybie! Sorry to bother but would you know when this could be reviewed? It's been almost 3 weeks since the PR was created and had no news on it 😿

Apologies for the delay. I'll try to get to it this week, or the first week of Sept (I'm out next week).


Barotrauma does not stop from Panel.

Stop code is not being passed to the barotrauma dedicated server. When Stop is pressed the panel console presents the stopping message, but does not stop the process and it continues operating.
Panel 1.11.3
Wings 1.11.4
I understand there are already issues with passing commands to the "console" in game. This is only to get the process to stop to safely shutdown the dedicated server.

use ^^C as stopcmd

as Goover stated, change the stop cmd of that egg for now to ^^C


Update build-plan CHANGELOG.md

@chanseokoh have we done a release with any of these changes before? I don't see any versioning in here?

Ah, yeah, sorry. I forgot to update the template. The current [unreleased] entries need to be under 0.3.1. (Strictly speaking, we should have both 0.3.0 and 0.3.1, but I think it's fine to go with a single 0.3.1.)

Good catch!

Yeah we probably should've provided some better guidance on this file. Anyway, while you're in here can you update the top to look more like https://github.com/GoogleContainerTools/jib/blob/master/jib-gradle-plugin/CHANGELOG.md#change-log including a title and [unreleased] header and stuff

I think we still need the "changelog" title and subtitle, and the "unreleased" subsection header?


fix check server running failed

Signed-off-by: x893675<EMAIL_ADDRESS>
What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

/kind bug

Codecov Report

Merging #497 (47b5798) into release-1.3 (1a152ef) will not change coverage.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           release-1.3     #497   +/-   ##
============================================
  Coverage        12.20%   12.20%
============================================
  Files              110      110
  Lines            16911    16911
============================================
  Hits              2064     2064
  Misses           14600    14600
  Partials           247      247

Impacted Files
Coverage Δ

pkg/cli/deploy/deploy.go
5.41% <0.00%> (ø)


[Feature] extract common utils and pkgs from practical develop operators

After developing several operators, we have accumulated some experience, so at this time, we need to extract some common tools and pkgs from the operators we have developed in practice.
The following task list will be  updated continuously:

[ ] reconcile result wrapper;
[ ] configuration generator for golang template;
[ ] ...

LGTM, Should we split the issure into functional units and associate them with the specified PR? In addition, the name should indicate the specific function implemented rather than using a generic name for a task that appears to have no end in time.

I think we can proceed from three units:

util package or other helper tools , maybe other naming
kds develop framework
commonly api struct

Each unit has at least one todo.
You can split these into multiple issues.

yes, you are right. I wonder if this issue is necessary? It is not a specific executable issue. Rather, it serves as a catalog role of collected all issues for this extraction. When all split issues are resolved, we finally close it


Move to updated terraform modules

Part of: https://github.com/wellcomecollection/platform/issues/4799
Updates the Archivematica infrastructure to be able to use the new deployment tool.
Remaining work:

[ ] Update the storage service image to use the image labels published by weco-deploy.

Looks reasonably. I haven't gone into too much detail, but I trust it plans cleanly.

It will plan cleanly, though it may require some manual intervention (removing target groups) when applied in prod as I think terraform does not remove the listener/target group in the correct order.


Provide shortcut for annotating destructured params

Search Terms

destructured label:Suggestion
Suggestion

It would be great to have a shorter way of annotating destructured params.
Use Cases

Annotations for destructuring have to be verbosely typed out, e.g.:
{ a, b, c }: { a: string, b: number, c: string }

This could be shortened to decrease the amount of code needed.
Examples

  public pipeThroughProcess({
    bucket,
    key,
    process,
  }: {
    bucket: string;
    key: string;
    process: ChildProcess;
  }) {
    //
  }

This is extremely redundant and there's no way to avoid it, other than creating an interface which also feels unnecessary for something that will be only be used once.
It would be ideal to just be able to do this instead:
public pipeThroughProcess({ bucket, key, process }: { string, string, ChildProcess }) {}

I've tried to think of some reason this wouldn't work, but it seems like this would work and would not be a breaking change (it could be optional).
Checklist
My suggestion meets these guidelines:

[X] This wouldn't be a breaking change in existing TypeScript / JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[ ] (unsure) This isn't a runtime feature (e.g. new expression-level syntax)

Duplicate of #7576


Roll Flutter Engine from 31d21cbed7b2 to 7ded18aad51d (2 revisions)

https://github.com/flutter/engine/compare/31d21cbed7b2...7ded18aad51d
2022-10-26<EMAIL_ADDRESS>Scroll inertia cancel for Win32 (flutter/engine#34452)
2022-10-26<EMAIL_ADDRESS>Fix typos in felt build help docs (flutter/engine#37016)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Escape character for fields name when exporting in SQL

It would be good to be able to have the field name escaped with the SQL exporter, and to be able to choose by which character.
This was discussed in Issue #1940
Proposed solution
Add a text field for an escape character in the SQL Exporter.
Alternatives considered
Data manipulation at the text level after exportation.
 I'll assign you to this! ☺

I have read the Issue #1940 .Could u please give me an example?I have read the Issue #1940 .So Does the text assign the unicode outside the text?For example,if the escape character is " and there is a column named abc,it would be "abc".Do I understand correctly?

I have read #1940 .Could u please give me an example?So Does the text assign the unicode outside the text?For example,if the escape character is " and there is a column named abc,it would be "abc".Do I understand it correctly?

@the-star-sea: if you try to SQL export a table, this is the current result.
CREATE TABLE TEST_food_small (
NDB_No VARCHAR(255) NULL,
Shrt_Desc VARCHAR(255) NULL,
(…)
Refuse_Pct VARCHAR(255) NULL
);

With a text field in which the tick character would be entered i.e. « ` », it would give this output:
CREATE TABLE `TEST_food_small` (
`NDB_No` VARCHAR(255) NULL,
`Shrt_Desc` VARCHAR(255) NULL,
(…)
`Refuse_Pct` VARCHAR(255) NULL
);

Regards, Antoine

Hello @antoine2711  , this issue looks amazing for me to dive into it  kindly assigne it to me , probably highlighting key points would be highly appreciated.

Hello @antoine2711 , this issue looks amazing for me to dive into it kindly assigne it to me

@sherrif10: unfortunately, someone is already « assigned » to the issue, @the-star-sea. Since it's only been a few days, he most probably still working the issue. Please choose another one, not assigned.
Regards, Antoine

Thank you so much for your great response , i appreciate, My plan is to push more code this week as much as possible.

Hello @antoine2711 , this issue looks amazing for me to dive into it kindly assigne it to me

@sherrif10: unfortunately, someone is already « assigned » to the issue, @the-star-sea. Since it's only been a few days, he most probably still working the issue. Please choose another one, not assigned.
Regards, Antoine

Thank u antoine,I am still working on it.

I have complete it!What should I do I do next?I have forked one repository many days ago.@antoine2711

I have complete it.However,I use fork and change on it.I am a new bee of opensource project.What should I do next ?Thank u so much.

I have complete it.However,I use fork and change on it.I am a new bee of opensource project.What should I do next ?Thank u so much.

Hi @the-star-sea , you should find some helpful tips from these links:

Contributing Guide
Your first pull request

I have complete it.However,I use fork and change on it.I am a new bee of opensource project.What should I do next ?Thank u so much.

@the-star-sea: Go on Gitter, and ask some help with creating your full pull request. But only do so after having read all the technical documentation. This aspect is in part covered, be help sometimes helps after reading it.
Regards, Antoine

Hi @antoine2711, is this really needed now that we are normalizing column names in the SQL export? Your proposal seem to be a different solution for a problem we have already solved another way, no?

Hi @antoine2711, is this really needed now that we are normalizing column names in the SQL export? Your proposal seem to be a different solution for a problem we have already solved another way, no?

I personally have work scenario where the fields name contains spaces, and they must be exactly like that. With a SQL query per table, I can rename them all, but having the SQL ready makes it's more useful. It's a very simple change for a worth feature, in my opinion. I will use it. I think replacing and escaping are two good solutions, that why I keep working this feature.
Regards, Antoine

Yes but then you need to make sure you can actually disable the replacing, which you have not mentioned in the issue so far, right?

Having read a good first issue, this is my contribution to this project. now so good as an Outreachy project applicant since I have not seen others participate. it though the interest I developed. still looking around for others. any review and guidance are welcome.

Yes but then you need to make sure you can actually disable the replacing, which you have not mentioned in the issue so far, right?

Yes, you are rigth to ploint out that both of these features make little sens togeter. It's more one or the other. But, having them both at the same time can't create problems. If the current contributor would have a good first draft, that would have been a suggestion. Maybe he would have done it by himself. For sure, coding this after is not more work in itself, so I would have guide the contributor through this process. I'm learning this, so if you have particular recommandation, please let me know. One of the reason to propose this feature was also because we were lacking first good issues. This seams in overall relatively simple to code. I'm all hear @wetneb, recommendations?
Regards, Antoine

ok Point taken
On Thu, Apr 21, 2022 at 3:12 PM Antonin Delpeuch @.***>
wrote:

You could try to salvage this issue by coming up with a user interface
proposal which would let the user choose between normalization of column
names and usage of an escape character.
I am not sure to which extend we need to let the user choose the escape
character: is there not a standard one that is understood by all
SQL vendors? Does the SQL spec not cater for that?
—
Reply to this email directly, view it on GitHub
https://github.com/OpenRefine/OpenRefine/issues/4716#issuecomment-1105124115,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXPBJMXFDUQINQJ4YE7YFKTVGFAZBANCNFSM5S3MH7TQ
.
You are receiving this because you commented.Message ID:
@.***>

my question is, do i use the code base for this or or use the open, if
code, i have tried several times to clone the git openrefine but after edit
rejected pushing. can i know which way please..
On Thu, Apr 21, 2022 at 3:34 PM lynate niyo @.***> wrote:

ok Point taken
On Thu, Apr 21, 2022 at 3:12 PM Antonin Delpeuch @.***>
wrote:

You could try to salvage this issue by coming up with a user interface
proposal which would let the user choose between normalization of column
names and usage of an escape character.
I am not sure to which extend we need to let the user choose the escape
character: is there not a standard one that is understood by all
SQL vendors? Does the SQL spec not cater for that?
—
Reply to this email directly, view it on GitHub
https://github.com/OpenRefine/OpenRefine/issues/4716#issuecomment-1105124115,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXPBJMXFDUQINQJ4YE7YFKTVGFAZBANCNFSM5S3MH7TQ
.
You are receiving this because you commented.Message ID:
@.***>

Hi @niyolynate, your question was not very clear, but these one are, so I'll answers them.
Once you have clone the git on your mechine, yes, you should create a NEW branch. This, in turn, will generate your own PR for this task. But I would not advise you to do so, because someone is already assigned to this issue.

You should find one that not taken. For starting, find one with the label Good First Issue, and preferably not the label To Be Reviewed. Hope that helps!
Regards, Antoine

yes, it is,   Glad I Asked. Thanks a lot.
On Thu, Apr 21, 2022 at 3:48 PM Antoine Beaubien @.***>
wrote:

Hi @niyolynate https://github.com/niyolynate, your question was not
very clear, but these one are, so I'll answers them.
Once you have clone the git on your mechine, yes, you should create a NEW
branch. This, in turn, will generate your own PR for this task. But I would
not advise you to do so, because someone is already assigned to this issue.
[image: image]
https://user-images.githubusercontent.com/12217525/164460991-8d47392e-b5bd-495d-8d71-ca2e01d63605.png
You should find one that not taken. For starting, find one with the label Good
First Issue, and preferably not the label To Be Reviewed. Hope that helps!
Regards, Antoine
—
Reply to this email directly, view it on GitHub
https://github.com/OpenRefine/OpenRefine/issues/4716#issuecomment-1105165824,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXPBJMUARPQ327B4H6BQ7ETVGFFABANCNFSM5S3MH7TQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes but then you need to make sure you can actually disable the replacing, which you have not mentioned in the issue so far, right?

https://github.com/OpenRefine/OpenRefine/blob/bef50d989b3c4b4216a5b71e99d4d4187046d0c3/main/src/com/google/refine/exporters/sql/SqlCreateBuilder.java#L85-L94
@wetneb: I feel that in my enthousiam, I might have overlooked the Java part, which is, as you know, not my strengh. So, to better answers your question, yes, a new option would be necessary. What is involve more than sending it thru the IP with the others options? For the extra option, how about escapeColNames?
Also, there should be a discussion of not sending nothing if the escaping character is null. In that case, it would be very safe to use the caret `.
Yes, I have a bit of review work to do here, since I volunteered. ;-)
Regards, Antoine

Actually I have a version without replacement merging into because this is
my first issue and I forget to fork before I complete it.I rewrite the code
after I fork and I have to change the code to make it harmony with the
replacement.
Antonin Delpeuch @.***> 于 2022年4月21日周四 19:41写道：

Yes but then you need to make sure you can actually disable the replacing,
which you have not mentioned in the issue so far, right?
—
Reply to this email directly, view it on GitHub
https://github.com/OpenRefine/OpenRefine/issues/4716#issuecomment-1105098538,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMMRV4KIUU5AYTSI2GIP2BDVGE5H5ANCNFSM5S3MH7TQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

in order to
public void EnableButtons()
{
btnImportHFR.Enabled = Convert.ToBoolean(Shared.FilesForImport.Count);
btnImportHFR.Text = btnImportHFR.Enabled ? "Find Available HFR" : "No HFR For Import";
btnGetFacilityStatus.Enabled = Shared.sqlWrap.GetDataForFacStat(Shared.DsFacStat);
updateButtons = false;

     CREATE TABLE userid(
id Country(30) NOT NULL PRIMARY KEY,
pwd Country30) NOT NULL,
fullname EnterName50),
email EnterEmail(50) );

Yes but then you need to make sure you can actually disable the replacing, which you have not mentioned in the issue so far, right?

https://github.com/OpenRefine/OpenRefine/blob/bef50d989b3c4b4216a5b71e99d4d4187046d0c3/main/src/com/google/refine/exporters/sql/SqlCreateBuilder.java#L85-L94
@wetneb: I feel that in my enthusiasm, I might have overlooked the Java part, which is, as you know, not my strength. So, to better answers your question, yes, a new option would be necessary. What is involved more than sending it thru the IP with the others options? For the extra option, how about escapeColNames?
Also, there should be a discussion of not sending nothing if the escaping character is null. In that case, it would be very safe to use the caret `.
Yes, I have a bit of review work to do here, since I volunteered. ;-)
Regards, Antoine

yes, Your right. Still Learning.

After a quick search, I found this StackOverflow answer which seems to suggest that the standard mandates double quotes to quote fields. THerefore, I do not think it is worth letting the user choose which quote character should be used.
A user could want:

the current behaviour where column names are normalized
or the preservation of the original column names, enclosed by double quotes

So I would say we could give the choice between those two options in the UI.

@the-star-sea: in regards to @wetneb last comment, I suggest this user interface.

What do you think?
Regards, Antoine

I am struggling to understand why we need three options here.
If we keep column names intact, then we need to surround them by quotes in general, so the first and last option seem to be identical to me.
Also, some grammar/style suggestions:

Keep Column Names intacts should be Keep column names intact (no s on adjectives that apply to plural nouns unlike in French, plus standard capitalization of words in English)
Trim Column Names -> "trimming" generally refers to removing whitespace at the beginning or the end. What we do is a more thorough normalization, so I would say Normalize column names
Use Escape Character for Column Names -> what we have been discussing is the use of a quote character, not an escape one, although you will indeed need escaping if the quote character occurs in the string to be quoted

Is there any other senior engineer to do the judge?It seems hard to do decisions efficiently here.

Actually,the hardest thing is not how to do but what to do.I don't know what I should do and it is the second month now since I publish the pull request.

I am struggling to understand why we need three options here. If we keep column names intact, then we need to surround them by quotes in general, so the first and last option seem to be identical to me.

Well @wetneb, it's to keep the possibility of having just the names, with no quotes or renaming. It's something we have now, so I didn't want to remove that possibility.
Thanks for the grammaticals corrections. I guess my french roots are still strong! ;-)
Regards, Antoine

Well @wetneb, it's to keep the possibility of having just the names, with no quotes or renaming. It's something we have now, so I didn't want to remove that possibility.

Hmm, unless I am mistaken I think what we have now is the second option (normalization introduced by a recent PR). Having just the names with no quotes or renaming can generate invalid SQL statements, so it is probably not an option we should offer to the user, should we?

Actually,the hardest thing is not how to do but what to do.I don't know what I should do and it is the second month now since I publish the pull request.

@the-star-sea: I understand this is frustrating sometimes. The discussions with the community is a rather lengthy and uncertain process. But it's really what can make the tool better, as they use the product and as such, might come with perspective that a new developper migth not have think of.
I think Antonin recommandation to « Ideally, you should feel invited to take part to those design decisions, and have opinions about the features you are implementing, because you can imagine how users will interact with them. » is important, because doing so stimulate the discussions in the community, making the process faster.
Regards, Antoine

Hmm, unless I am mistaken I think what we have now is the second option (normalization introduced by a recent PR). Having just the names with no quotes or renaming can generate invalid SQL statements, so it is probably not an option we should offer to the user, should we?

I think doing nothing (first option) is good for backward compatibility. I could also imagine a SQL engin that would allow UTF-8 field names, but not the double quote. I do agree that the 2 other options will probably satisfy 99% of the user base or popular SQL DB. So, definitely not a hill I would die for.

Use Escape Character for Column Names -> what we have been discussing is the use of a quote character, not an escape one, although you will indeed need escaping if the quote character occurs in the string to be quoted

Well @wetneb, I think that I made this mistake from the start, even in the title of this issue… So, should it be called Quote Column Names with (")?
Regards, Antoine

I think a good tool does not serve for all the people but for most of people.The more freedom,the less convenience.

I think doing nothing (first option) is good for backward compatibility. I could also imagine a SQL engin that would allow UTF-8 field names, but not the double quote. I do agree that the 2 other options will probably satisfy 99% of the user base or popular SQL DB. So, definitely not a hill I would die for.

Hmm, I really do not understand! Backwards compatibility is not about preserving existing bugs, right? The previous behaviour (before normalization of column names) was just incorrect. SQL engines have to support double quotes to quote column names, because that is specified by the standard. I cannot imagine a setting in which the user would enforce the generation of invalid SQL statements.

@the-star-sea: we now have a strong consensus about how to implement this features. Is it clear to you?
Regards, Antoine

Also, if we are indeed going for two options, then we can probably have just a checkbox rather than two radio buttons (no strong feelings about which way the checkbox should go: either normalizing when checked, or using quotes when checked - as long as it is consistent with the label of course…)

Yes, I am clear now.But these days I have 5 final exams coming soon to prepare.I will do it later.

Yes, I am clear now.But these days I have 5 final exams coming soon to prepare.I will do it later.

No rush @the-star-sea. I just wanted to make sure you were confortable with the discussions and that you had what you needed to go forward. Good examens to you!
Regards, Antoine

I have read and gone through each of discussion for this issue, I would like to give it a try
Regards, Aryan

I have read and gone through each of discussion for this issue, I would like to give it a try

@Sudo-Aryan : you already have one « good first issues » assigned, we try to keep one per contributors. You can look at « good second issues ».
Regards, Antoine

Hi!, I wanna try this, is it still available?

I've removed the Good First Issue label until there's a better specification of what's needed here. I've also changed the terminology to use the conventional term "quote", rather than "escape", which is something different.
It looks like SQL has two different classes of identifiers, regular identifiers and delimited identifiers, and there are (at least?) three different conventions for quoting "delimited identifiers":
1. "ANSI Standard"
2. [MS SQL Server]
3. `MySQL`

Our strategy for these has evolved over time:

Do nothing, the user is responsible for getting things correct
Attempt to transform column name into a legal regular identifier
Quote column name using the ANSI SQL quote character
... whatever's next ...

If we're going to support non-ANSI standard quote characters, I'd suggest that we should support both SQL Server and MySQL (plus any other legacy proprietary quoting schemes which exist?), rather than just one of them.

As a power tool for non-programmers (and also non-DBAs typically), I think it makes sense to ease the burden and make our SQL export dialog even more clear when we do introduce the new quote schemes.  We can just use paratheses after the option to give a hint of what to use for which db vendor.  He's what the defaults look like for the vendors:

[ ] Use ANSI quotes (PostgreSQL, SQL Server, Oracle, Snowflake, etc.)
[ ] Use backtick quotes (MySQL, MariaDB, etc.)

NOTED:  Each db vendor has their own override pragmas (system) or options to change the acceptable quoting of identifiers.  But we should just target or terminology and handling of quote schemes to the db vendors defaults, which the community would expect from us I think.  "cater to the masses of non-programmers and make it easier for them to export their data to standard db setups"

It's worth noting that the change we made in 3.8.0 to normalize by always wrapping with double quotes " does break things a bit for users of MySQL in particular which does not ship with ANSI_QUOTES mode turned on and thus our enforcement of double quotes " around identifiers will cause an error in MySQL when executing the script, but no error if there's no quotes, or wrapped in back ticks.