Failed validation: #/definitions/QuoteSummaryResult

Seeing this for ORSTED.CO
"error":{"name":"FailedYahooValidationError","errors":[{"instancePath":"/price/shortName","message":"must be string","schemaPath":"#/definitions/Price/properties/shortName/type","params":{"type":"string"},"keyword":"type","data":null}],"result":{"price":{"quoteType":"EQUITY","shortName":null,"regularMarketPrice":925.8,"marketCap":388898947072,"currency":"DKK","marketState":"PREPRE","regularMarketOpen":926.2,"regularMarketVolume":423244,"regularMarketDayHigh":945,"priceHint":2,"regularMarketChangePercent":0.0032509754,"longName":"Ørsted A/S","regularMarketSource":"FREE_REALTIME","toCurrency":null,"regularMarketDayLow":916.6,"exchangeDataDelayedBy":0,"lastMarket":null,"symbol":"ORSTED.CO","fromCurrency":null,"maxAge":1,"quoteSourceName":"Delayed Quote","exchangeName":"Copenhagen","underlyingSymbol":null,"regularMarketChange":3,"exchange":"CPH","currencySymbol":"kr.","regularMarketTime":{},"regularMarketPreviousClose":922.8}}

:tada: This issue has been resolved in version 1.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Oops, didn't mean to close this, but it's fixed now in the latest release.  If you can confirm, you can close.  Thanks :)  And thanks for reporting!

Hey @blaur, what version of typescript are you using?  Both globally (system-wide) and locally (in your project) if you have it installed in both places.  And also the output of where tsc and which tsc.  Try upgrading if you're not on 4.3.2.

Hey @blaur, I'm moving my reply to https://github.com/gadicc/node-yahoo-finance2/issues/198 for clarity.  Let's continue this part of the discussion there.


updates VM region info, ssh keys and uses ansible scripts

/cc: @joaofeteira @johnbelamaric @electrocucaracha @sandeepAarna

project id and region values look good, I look to others to check the real meat

/lgtm , I'm not sure if @joaofeteira has a preference on that. I think that this change affects the instructions provided in the README.md file, so @vjayaramrh do you want to change them as well?


svg2pdc should be a separate tool

svg2pdc seems to be a handy script and it could be moved to it's own Github repo. When it would be published to PyPI, it could easily be installed (maybe as part of the Pebble SDK 😉.

+1

The script was mistakenly published here, and remains here to serve as the de-facto public version (avoiding fragmentation). Perhaps in the future a more cohesive tool will be available.


crash if test module isn't importable

if a test module isn't importable (e.g. a syntax error, or it imports a non-existent module), it won't have a test name. In flaky_nose_plugin.py:_get_test_method_name, it crashes.

Thanks John!


How to: Pass resource into Map closure

Just getting started with Timely and running into an issue trying to pass a 'resource' in to use in a computation. I'm still struggling with closures in rust so maybe thats the problem, but I can't seem to figure out how to pass the resource into a map or flat_map or any function that uses a closure. Is there a way to do this? I'm sure I'm just doing something wrong but can't figure it out.
cannot infer an appropriate lifetime due to conflicting requirements

note: ...so that the types are compatible:
      expected &&mut std::string::String
         found &&mut std::string::String
note: but, the lifetime must be valid for the static lifetime...rustc(E0495)

Example Reproduce:
use timely::dataflow::operators::ToStream;

timely::execute_from_args(::std::env::args(), |worker| {
    let resource = "hello".to_string();

    worker.dataflow_core::<usize, _, _, _>("dataflow X", None, resource, |resources, scope| {
        (0..10)
            .to_stream(scope)

//ERROR HERE  V                                               V
            .map(|x| format!("{:?} {:?}", resources, x))

            .inspect(|x| println!("seen: {:?}", x));
    });
});

You'll almost certainly want to use the move keyword on the map closure:
.map(move |x| format!("{:?} {:?}", resources, x))

This tells Rust that you should move the ownership of closed-over bindings into the closure.

Also, from experience, you'll often be ok using the same keyword to capture the resource in the dataflow closure, without needing to use dataflow_core:
    let resource = "hello".to_string();
    worker.dataflow<usize, _, _>(move |scope| {
        (0..10)
            .to_stream(scope)
            .map(move |x| format!("{:?} {:?}", resource, x))
            .inspect(|x| println!("seen: {:?}", x));
    });

The cases where dataflow_core have come up (for me) have been settings where you need to very carefully control dropping of resources (e.g. unmapping of shared libraries, whose code is needed in other parts of the dataflow drop code).

Ah yes, there needed to be a move on both the dataflow closure and the map closure, that makes sense. Only issue is if you want to use the resource twice - in two different map statements, but I can deal with that.
Theres another issue though once the two moves are added. If the InputHandle and ProbeHandle are used, like in many of the examples, there's a conflict with the move because its consuming the handles so they can't be used in the for loop below.
Is there a way around that?
timely::execute_from_args(::std::env::args(), |worker| {
    let index = worker.index();
    let mut input = InputHandle::new();
    let mut probe = ProbeHandle::new();

    let resource = "hello".to_string();
    worker.dataflow::<usize, _, _>(move |scope| {
        scope
            .input_from(&mut input)
            .map(move |x| format!("{:?} {:?}", resource, x))
            .inspect(|x| println!("seen: {:?}", x))
            .probe_with(&mut probe);
    });

    for round in 0..10 {
        if index == 0 {
//ERROR V  -- "value borrowed here after move"
            input.send(round);
        }
        input.advance_to(round + 1);
//ERROR    V  -- "value borrowed here after move"
        while probe.less_than(input.time()) {
            worker.step();
        }
    }
});

Idiomatic Rust would probably have you create references and move those, so e.g.
    let mut input = InputHandle::new();
    let mut probe = ProbeHandle::new();

    let input_ref = &mut input;
    let probe_ref = &mut probe;
    let resource = "hello".to_string();
    worker.dataflow::<usize, _, _>(move |scope| {
        scope
            .input_from(input_ref)
            .map(move |x| format!("{:?} {:?}", resource, x))
            .inspect(|x| println!("seen: {:?}", x))
            .probe_with(probe_ref);
    });

though, probably other ways. You can create the string inside the dataflow closure, for example, and not need to move it. Generally you can get around move by creating references if you'd prefer to borrow some arguments (but, lifetimes are a thing and dataflow works but the map closure doesn't, as it needs to have static lifetime).

Wonderful, I haven't used that pattern before, thanks for the help!!


Content switcher: Document manual mode of selection

Overall the content switcher is a well implemented and documented component. There are however a few things we identify in the comments of our PDF exports of the Usage and Style pages (which should be thoroughly reviewed for content updates). The most significant of these are:

there is no mention of the content selection update variants: automatic and manual. They aren't mentioned in the Usage documentation nor illustrated on the Style page. (However, they are properly implemented on storybook.)
There's not mention of the child content of the Content switcher (it's equivalent to a tabpanel).  That seems like a pretty large gap

Whoever takes this on: Clarify last bullet with Gower.

I think some design considerations and decisions are needed on that second bullet, @sstrubberg. It would be good to get @jeanservaas, @laurenmrice and others talking about it. Perhaps something to cover in either an Carbon Accessibility Guild session, or in one of the issue refinement calls @tay1orjones organizes?

Closing in favor of tracking via https://github.com/carbon-design-system/carbon/issues/13521


X-Cache header's all values and descriptions are not listed

It would be helpful to have complete list of all values (and their descriptions) that the X-Cache header can contain.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c44a91d-f0a9-99cb-1ba6-a4a0918c1b8f
Version Independent ID: 3c43384c-6fce-25b0-eabb-49ba7667034b
Content: Protocol support for HTTP headers in Azure Front Door
Content Source: articles/frontdoor/front-door-http-headers-protocol.md
Service: frontdoor
GitHub Login: @duongau
Microsoft Alias: duau

@sushruth Thanks for your comment! We will review and provide an update as appropriate.

@sushruth Thanks for your comment! We will review and provide an update as appropriate.

@sushruth, we are assigning this issue to the respective content owner for updating the document accordingly.

@SubhashVasarapu-MSFT Just as an extension to this, I also want to request list of all possible values for all the headers on this page if that can be done as well. Thank you.

@sushruth I have added the values for the X-cache headers. I'm working with our PG team to see if there are other headers values we can expose in the article as well.
Thank you

#please-close


Cannot override legend style in outlinedtextfield

I am trying to override the style with:
export const overrides = {
 MuiOutlinedInput: {
    notchedOutline: {
       "$legend":{
         transition: "none"
      },
      legend: {}
    }
  }
}

but it displays the changes in the wrong place in the css:

Anything I am doing wrong?

I managed to find the problem but now I am stuck because of this issue:
https://github.com/mui-org/material-ui/issues/13364

@AlexCppns I'm curious. Would #15140 have helped with the overrides?


Creation a new SFTP session in an Azure Automation runbook blocks the job

I got a runbook which uses Posh-SSH for remote SSH work.
The following code seems to unregularly fail to execute, or, to pass execution back to powershell.
New-SFTPSession -ComputerName xxx -Credential $cred -KeyString $aws_ssh_key -AcceptKey
Following commands will not be executed, leading to infinite runtime (until Azure kills the job after 3h).
This happens on approximately 15-30% of all runbook executions. I have not found a way to implement error handling for this, since this does also not seem to work in background jobs.
Background jobs in Azure using this cmdlet instantly finish, without actually executing the cmdlet.

Weird I though runbooks did not had registry support. The module still depends on the registry
Sent from my iPhone

On Aug 29, 2019, at 5:21 AM, wirelessy<EMAIL_ADDRESS>wrote:
I got a runbook which uses Posh-SSH for remote SSH work.
The following code seems to unregularly fail to execute, or, to pass execution back to powershell.
New-SFTPSession -ComputerName xxx -Credential $cred -KeyString $aws_ssh_key -AcceptKey
Following commands will not be executed, leading to infinite runtime (until Azure kills the job after 3h).
This happens on approximately 15-30% of all runbook executions. I have not found a way to implement error handling for this, since this does also not seem to work in background jobs.
Background jobs in Azure using this cmdlet instantly finish, without actually executing the cmdlet.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Well it works just fine - most of the time. I basically just said "Deploy to Azure Automation" and started using it. Have not seen other unexpected behaviour from it, apart from the mentioned block/timeout.

Is there a way to troubleshoot this? As I mentioned, I was unable to build a workaround for this because of the execution-blocking behaviour.

dont know if its linked but Ive noticed when I run Get-SFTPsession | Remove-SFTPSession at the end of processing in Azure Automation it also seems to hang holding up the runbook.


slackSend @mention not working as part of message

When @ mentioning in a message using slackSend in a Jenkins Pipeline script, the mention @<slackUsername> only appears as plain text in the Slack notification. I previously provided @ mentions as part of "Custom Message" in an old style Jenkins job and it worked but does not seem to work with slackSend. Any ideas or does this just not work?
Example of what I'm trying to do:
slackSend ( message: 'I want to mention this @user as part of message', teamDomain: '<teamDomain>', token: '<token>', channel: '<channel>' )

We also use this to notify the channel as high priority (using @channel or @here), I think the @ symbol is getting escaped and it shouldn't...

@here works fine for me.

Any update on this? I can see @here work but not for a specific user :)

To notify a specific user you need to use their slack ID and enter it in this format:
<@UET1JGZEZ>
slackSend channel: '#tim-testing', message: '''<@UET1JGZEZ>
what's up
hi
'''

Auto parsing support to be tracked in: https://github.com/jenkinsci/slack-plugin/issues/367


Problem with heroku

Hello !
I tried to deploy this webhook directly on heroku and tried to use it on api.ai but the new app return a 404 page, problem with your script or problem with heroku ?
PS: i follow the documentation of API.AI :)
Thanks in advance!

sorry was an error from me


report not updated after remediating issue

It seems the report is not updated after fixing some issue and running invoke-maester few minutes after

We use extensive caching to improve performance. Please run Clear-MtGraphCache and see if this fixes the issue for you

Yep that works, thanks. What do you think about adding a -force parameter to invoke-maester so this will be done automatically?

Funny enough @merill had already thought about this and does it every time you call Invoke-Maester
So the original error might be related to stale data at some other point.
You can check if this actually happens when you use -Verbose. You should see the following message

Clearing the results cached from Graph API calls in this session

https://github.com/maester365/maester/blob/fcd1d8be2118150d251d4e54df9080f5f18e49e5/powershell/public/Invoke-Maester.ps1#L212

I ran another test : I mitigate an issue, ran Clear-MtGraphCache  and the report is not updated. (ran all of this in < 5min).
Confirmed the value is correct if I run the graph query.

Thanks for testing this. I will do a deep dive in the next few days. Already added an extra verbose message to see if it's grabbed from live data or the cache.
But sounds more like a debugger issue 🤔

Just want to add I'm having a similar issue when running this against multiple tenants.
For me all the reports are correct but its still pulling the tenant name from the cache. So its always the first tenant I run the tests on that end up as the title on all the reports. I too have tried Clear-MtGraphCache but this doesnt solve my problem. I've dived into the code and it does seem to be related to the cache when using the ConvertTo-MtMaesterResult cmdlet.
I have run -verbose and can see cache should be getting cleared as the provided screenshot from f-bader
I hope this helps, I was going to change the code to allow a -MultiTenant flag on invoke-maester but after finding this issue here, it seems you already have thought of this and im barking up the wrong tree?

This issue should be fixed in 0.0.125.
Please update the module to the latest version and try again.


New feature: Adds frontend side to allow the users to edit the dataset description

Description
On the dataset settings page, adds a form field to edit/add a description or annotation guidelines to the dataset. The form has a live preview of the markdown. Both the editor and the markdown renderer are not coupled to the DatasetDescription component so they could be used in any other place if required, for example, when rendering the description somewhere else. I started the VueX ORM implementation but did not finished it as there is no backend for this yet.
While setting up the local environment I noticed that the frontend does not work on recent nodejs versions (tested it on node 18, current LTS) and there is no documentation about this. I only was able to build the frontend with node 14.
Also, the frontend README is misleading, as it says to use yarn which did not work for me, neither on node 18 or 14. It only worked with npm.
I'm creating two new issues for this.
Type of change

[ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested

[ ] New cases on DatasetDescription.component.spec.js.
[ ] New test case on MarkdownEditor.component.spec.js.
[ ] New test case on MarkdownElement.component.spec.js.

Checklist

[x] I have merged the original branch into my forked branch
[ ] I added relevant documentation
[x] follows the style guidelines of this project
[x] I did a self-review of my code
[ ] I made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Nice :)

Resolved conflicts from upstream.

@DavidHernandez Thanks for the lovely PRs! They are very appreciated:)

https://github.com/argilla-io/argilla/pull/2953


feat: support login

Resolves #31

Codecov Report

Merging #42 (4432d9c) into main (aead42c) will decrease coverage by 0.65%.
 Consider uploading reports for the commit c2440f6 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   69.69%   69.04%   -0.65%
==========================================
  Files           1        2       +1
  Lines          33       42       +9
==========================================
+ Hits           23       29       +6
- Misses          9       11       +2
- Partials        1        2       +1

Impacted Files
Coverage Δ

native_store.go
69.69% <ø> (ø)

login.go
66.66% <66.66%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Implement --sdnotify cmdline option to control sd-notify behavior

--sdnotify conmon-only|container|none
With "conmon-only", we send the MAINPID, and clear the NOTIFY_SOCKET so the OCI
runtime doesn't pass it into the container. We also advertise "ready" when the
OCI runtime finishes to advertise the service as ready.
With "container", we send the MAINPID, and leave the NOTIFY_SOCKET so the OCI
runtime passes it into the container for initialization, and let the container advertise further metadata.
The "none" option does what it's always done in the past - passes NOTIFY_SOCKET
to conmon's process and the OCI runtime processes, and does no manipulation or "help".
This removes the need for hardcoded CID and PID files in the command line, and
the PIDFile directive, as the pid is advertised directly through sd-notify.
Signed-off-by: Joseph Gooch<EMAIL_ADDRESS>Includes #6689
References #6688

The more I think about this I'm not sure "none" is a valid option, though it was essentially requested...  Since "none" returns a broken situation. (MAINPID never advertised properly)... Unless there's a case when runc or crun advertises the correct MAINPID.

I think none is "I am not being managed by systemd, please ignore" - we've seen cases where Podman is run as a child of something actually managed by systemd, inherits NOTIFY_SOCKET from the parent (arguably a bug in the parent, but still), and then blocks forever as it tries to notify on an already-used socket.

I think none is "I am not being managed by systemd, please ignore" - we've seen cases where Podman is run as a child of something actually managed by systemd, inherits NOTIFY_SOCKET from the parent (arguably a bug in the parent, but still), and then blocks forever as it tries to notify on an already-used socket.

That's a reasonable interpretation.  In that case I should probably block NOTIFY_SOCKET from being passed down to the OCI runtime and conmon... correct?  That way everything will proceed as if the NOTIFY_SOCKET isn't there.
vs. what it does now, which means "libpod does nothing with NOTIFY_SOCKET other than pass it on", which is pretty similar to "container".

I think none is "I am not being managed by systemd, please ignore" - we've seen cases where Podman is run as a child of something actually managed by systemd, inherits NOTIFY_SOCKET from the parent (arguably a bug in the parent, but still), and then blocks forever as it tries to notify on an already-used socket.

That's a reasonable interpretation. In that case I should probably block NOTIFY_SOCKET from being passed down to the OCI runtime and conmon... correct? That way everything will proceed as if the NOTIFY_SOCKET isn't there.
vs. what it does now, which means "libpod does nothing with NOTIFY_SOCKET other than pass it on", which is pretty similar to "container".

In which case I think "ignore" is a better description.

Ignore works for me - and yes, we should not forward the socket in that case

Doesn't Podman have to respond to the ignore and set the ready state for systemd if it sees the flag and is set to ignore?  IE Systemd will never mark the unit file as ready unless someone says it is ready.

Doesn't Podman have to respond to the ignore and set the ready state for systemd if it sees the flag and is set to ignore? IE Systemd will never mark the unit file as ready unless someone says it is ready.

That's true - however, currently Podman doesn't respond at all.  Runc/crun do.  Ignore is only relevant when some other service is the responsible party.
The default is "container", which is the current behavior, which would mean Runc/Crun need to respond.  This PR just makes sure the correct MAINPID is set during the conversation.
conmon-only means Podman is the responsible party - the one responsible for sending READY=1, and keeps runc/crun out of the loop.
ignore would only be used if some other service is calling podman. I.e. some service that is sd-notify enabled, and therefore they are the responsible party.  Contrived example:
#!/bin/bash

#I'm a service
systemd-notify --status="Starting up"

#Spawn some containers
podman run --sdnotify ignore --rm -d alpine sleep infinity
podman run --sdnotify ignore --rm -d alpine sleep infinity
podman run --sdnotify ignore --rm -d alpine sleep infinity

#Do other stuff
sleep 1

#And we're good
systemd-notify --ready

Right now, each podman would see the NOTIFY_SOCKET set and assume that it's responsible for telling systemd when it's ready... Which is incorrect, the overall service is the shell script.
The other alternative is people explicitly changing the podman lines to do:
env -u NOTIFY_SOCKET podman run --rm -d alpine sleep infinity

As that's really what ignore is doing.

This removes the need for hardcoded CID and PID files in the command line, and
the PIDFile directive, as the pid is advertised directly through sd-notify.

Can you elaborate why this would remove the CID file? I think that's still needed to cleanly stop/remove a container in a unit.

Reviewing now. @giuseppe PTAL as well

Once comments are addressed, this LGTM

This removes the need for hardcoded CID and PID files in the command line, and
the PIDFile directive, as the pid is advertised directly through sd-notify.

Can you elaborate why this would remove the CID file? I think that's still needed to cleanly stop/remove a container in a unit.

CID file can still be used, it's just SystemD doesn't need it so it doesn't need to be hanging out in /run/%n-cid, it'll revert to being in userdata/
PID file can still be used, it's just SystemD doesn't need it so it doesn't need to be hanging out in /run/%n.pid, it'll revert to being in userdata/.... And we don't need to specify it in PIDFile because systemd will receive the appropriate PID via MAINPID= w/ Type=notify.
If for whatever reason people still want to use Type=forking, they can, they'll need to keep the PIDFile directive and put it somewhere it can be found... Otherwise Type=notify just makes things more clean and less hardcoded.

Oh man, I really like this PR. Thanks a ton!
Just a minor comment regarding input validation. @edsantiago , could you have a look as well? I wonder if you have a suggestion how we could test this in CI.

I too was struggling with this.  I can envision the tests - as I did the testing manually, but it's going to require forking which is currently beyond my ability to do in golang.
We'd need a thread that opens a UNIX dgram socket and captures input.  Perhaps (tmpdir)/notify.

Ensure podman ignores the socket
Create notify socket
Monitor notify socket
set env NOTIFY_SOCKET
Spawn podman run --rm --sd-notify=ignore alpine ls
Verify podman returns exit 0
Verify notify socket received absolutely no data.

Verify sd-notify=conmon (heres where it starts to get tricky)
Create notify socket
set env NOTIFY_SOCKET
Proc1) Monitor notify socket
Proc2) Spawn podman run --rm --sd-notify=conmon alpine ls
Proc1) wait for receipt of MAINPID=(pid) and verify it points to conmon, descendent of Proc2
Proc1) Wait for receipt of second MAINPID= and READY=1
Proc2) verify exit 0

Verify sd-notify=container
Create notify socket
set env NOTIFY_SOCKET
Proc1) Monitor notify socket
Proc2) Spawn podman run --rm --sd-notify=container alpine ls
Proc1) wait for receipt of MAINPID=(pid) and verify it points to conmon, descendent of Proc2
Proc1) sleep 3 seconds
Proc1) Find the socket - /run/runc/(CID)/notify/notify.sock or /run/crun/(CID)/notify/notify - and send READY=1 to it
Proc1) Verify you get back MAINPID= and READY=1
Proc2) verify exit 0

If podman exits in Proc2 before we send the READY in Proc1, then runc/crun didn't wait for a notification.

Test that not specifying sd-notify does the same thing as 3
Test that not setting NOTIFY_SOCKET does the same thing as 1

I'm not sure how to coordinate the test between two threads like that in Go.

All comments should be resolved at this point. PTAL!

I'm having a lot of trouble with sdnotify=container. It is very possible that the fault is mine, because it's been many months since I last fiddled with sdnotify.
I think someone/something (crun?) is intercepting NOTIFY_SOCKET. Note these two commands, differing only in the setting of that envariable:
$ env -u NOTIFY_SOCKET ./bin/podman run --privileged --rm -v /tmp/podman-sdnotify:/tmp/podman-sdnotify:Z alpine ls -l /tmp
total 0
srwxrwxr-x    1 root     root             0 Jun 22 17:24 podman-sdnotify
$ NOTIFY_SOCKET=/tmp/podman-sdnotify ./bin/podman run --privileged --rm -v /tmp/podman-sdnotify:/tmp/podman-sdnotify:Z alpine ls -l /tmp
total 0
srwxrwxrwx    1 root     root             0 Jun 22 17:36 notify

That is: when NOTIFY_SOCKET is unset, the (existing) socket is bind-mounted just fine in the container. When it is set, the bind mount doesn't work, and there's a socket called notify.
The context for this is that I was trying:
$ socat unix-recv:/tmp/podman-sdnotify -

[in another terminal]
$ ./bin/podman run --privileged --rm --sdnotify=container -v /tmp/podman-sdnotify:/tmp/podman-sdnotify:Z fedora systemd-notify --ready
Failed to notify init system: No such file or directory

I have a vague memory that this was intentional, but don't remember the details. @giuseppe perhaps you remember?

I'm having a lot of trouble with sdnotify=container. It is very possible that the fault is mine, because it's been many months since I last fiddled with sdnotify.
I think someone/something (crun?) is intercepting NOTIFY_SOCKET. Note these two commands, differing only in the setting of that envariable:
$ env -u NOTIFY_SOCKET ./bin/podman run --privileged --rm -v /tmp/podman-sdnotify:/tmp/podman-sdnotify:Z alpine ls -l /tmp
total 0
srwxrwxr-x    1 root     root             0 Jun 22 17:24 podman-sdnotify
$ NOTIFY_SOCKET=/tmp/podman-sdnotify ./bin/podman run --privileged --rm -v /tmp/podman-sdnotify:/tmp/podman-sdnotify:Z alpine ls -l /tmp
total 0
srwxrwxrwx    1 root     root             0 Jun 22 17:36 notify

That is: when NOTIFY_SOCKET is unset, the (existing) socket is bind-mounted just fine in the container. When it is set, the bind mount doesn't work, and there's a socket called notify.
The context for this is that I was trying:
$ socat unix-recv:/tmp/podman-sdnotify -

[in another terminal]
$ ./bin/podman run --privileged --rm --sdnotify=container -v /tmp/podman-sdnotify:/tmp/podman-sdnotify:Z fedora systemd-notify --ready
Failed to notify init system: No such file or directory

I have a vague memory that this was intentional, but don't remember the details. @giuseppe perhaps you remember?

runc/crun take care of proxying the socket. In fact they don't bind mount it, they create a unix-datagram inside the container, and write to the one outside.
I am attempting to decipher goroutines so I can write a proper test in e2e...
Basically though:
T1: socat unix-recvfrom:/tmp/podman-sdnotify,fork -
T2: env NOTIFY_SOCKET=/tmp/podman-sdnotify ./bin/podman run --rm --sdnotify=container fedora systemd-notify --ready
T1 shows
MAINPID=22842READY=1
MAINPID=22854
MAINPID=22842
This illustrates the sequence:
podman now sends 22842 (conmon) PID during oci_conmon_linux
runc/crun passes READY=1 back from systemd-notify
runc/crun passes MAINPID=22854 back from systemd-notify (which we can't monitor)
podman sends 22842 from container start - to overwrite the wrong PID

 MAINPID=22842READY=1

How are you getting this?! My entire rathole stemmed from my trying to do exactly that. I cannot get it to work, either root or rootless: systemd-notify in the container fails as I described above. I get MAINPID=xxx in the socat window, but never READY=1

I'm on Fedora 32 with crun

correction -
When NOTIFY_SOCKET is passed,

runc will create a socket in /run/runc/CID/notify/notify.sock, and then add a bind mount to /run/systemd/notify.sock (or similar).  This works as I illustrated
crun is creating a socket in /run/crun/CID/notify/notify.sock, but never adds the bind mount, so it crashes spectacularly.

Note that's not a problem with this PR, it's crun missing a bind mount - try on podman pre-this-PR without a sdnotify command line option - that fails too.
Just using your technique of adding the bind mount won't work - because runc and crun are explicitly blocking until THEIR socket receives a READY=1.

 MAINPID=22842READY=1

How are you getting this?! My entire rathole stemmed from my trying to do exactly that. I cannot get it to work, either root or rootless: systemd-notify in the container fails as I described above. I get MAINPID=xxx in the socat window, but never READY=1

Magic!
(Or, photon, cgroups 1 + runc)  :-D

correction -
When NOTIFY_SOCKET is passed,

runc will create a socket in /run/runc/CID/notify/notify.sock, and then add a bind mount to /run/systemd/notify.sock (or similar).  This works as I illustrated
crun is creating a socket in /run/crun/CID/notify/notify.sock, but never adds the bind mount, so it crashes spectacularly.

Note that's not a problem with this PR, it's crun missing a bind mount - try on podman pre-this-PR without a sdnotify command line option - that fails too.
Just using your technique of adding the bind mount won't work - because runc and crun are explicitly blocking until THEIR socket receives a READY=1.

I am looking in config.json for the bind mount - which probably isn't a good test if crun is doing it after the spec is loaded. I suppose I need to inspect the mount namespace

Phew - thank you. Ok, so it's crun then. That sure was a lot of time wasted this morning, but I'm glad the issue is identified. Please ignore my bind-mount comment, that was just a red herring, me trying to track down the root cause.
If crun is renaming the socket, shouldn't it reset NOTIFY_SOCKET in the container? I ran printenv and still see NOTIFY_SOCKET=/tmp/podman-sdnotify in the container

Phew - thank you. Ok, so it's crun then. That sure was a lot of time wasted this morning, but I'm glad the issue is identified. Please ignore my bind-mount comment, that was just a red herring, me trying to track down the root cause.
If crun is renaming the socket, shouldn't it reset NOTIFY_SOCKET in the container? I ran printenv and still see NOTIFY_SOCKET=/tmp/podman-sdnotify in the container

Yep I agree - I'm tracking it down

Phew - thank you. Ok, so it's crun then. That sure was a lot of time wasted this morning, but I'm glad the issue is identified. Please ignore my bind-mount comment, that was just a red herring, me trying to track down the root cause.
If crun is renaming the socket, shouldn't it reset NOTIFY_SOCKET in the container? I ran printenv and still see NOTIFY_SOCKET=/tmp/podman-sdnotify in the container

Yep I agree - I'm tracking it down

yeah it's the env variable that isn't being set right.
crun is mounting the socket at /run/notify.
env NOTIFY_SOCKET=/run/podman-sdnotify /usr/bin/podman --runtime /opt/podman/bin/crun run --rm  -it fedora sh -c 'printenv NOTIFY_SOCKET;ls -ld /run/notify; env NOTIFY_SOCKET=/run/notify systemd-notify --ready'
I'll see if I can find that in crun

Phew - thank you. Ok, so it's crun then. That sure was a lot of time wasted this morning, but I'm glad the issue is identified. Please ignore my bind-mount comment, that was just a red herring, me trying to track down the root cause.
If crun is renaming the socket, shouldn't it reset NOTIFY_SOCKET in the container? I ran printenv and still see NOTIFY_SOCKET=/tmp/podman-sdnotify in the container

Yep I agree - I'm tracking it down

yeah it's the env variable that isn't being set right.
crun is mounting the socket at /run/notify.
env NOTIFY_SOCKET=/run/podman-sdnotify /usr/bin/podman --runtime /opt/podman/bin/crun run --rm -it fedora sh -c 'printenv NOTIFY_SOCKET;ls -ld /run/notify; env NOTIFY_SOCKET=/run/notify systemd-notify --ready'
I'll see if I can find that in crun

Heh, this is weird.  It's apparently assuming the socket name is "notify".
When I pass /run/podman-sdnotify, it's mounted as /run/notify
When I pass /tmp/podman-sdnotify, it's mounted as /tmp/notify
I'm assuming this has just been working, because systemd's socket filename is notify. sooooo

Heh, this is weird. It's apparently assuming the socket name is "notify".
When I pass /run/podman-sdnotify, it's mounted as /run/notify
When I pass /tmp/podman-sdnotify, it's mounted as /tmp/notify
I'm assuming this has just been working, because systemd's socket filename is notify. sooooo

both crun and runc wraps the NOTIFY_SOCKET logic and expose a different socket to the container.
When the container notifies it is ready, crun/runc reads the notification on the socket they've created and propagate it back to systemd on the correct socket.
This is to address two issues:

workaround a systemd notify socket race where the sender of the notification cannot be correctly found with short lived processes if it is not directly monitored by systemd or in a different cgroup.

avoid that the container communicates directly with systemd and could send some weird MAINPID= value.  So both crun/runc filter anything received from the container except READY=1.  I think systemd-nspawn does the same thing.

Heh, this is weird. It's apparently assuming the socket name is "notify".
When I pass /run/podman-sdnotify, it's mounted as /run/notify
When I pass /tmp/podman-sdnotify, it's mounted as /tmp/notify
I'm assuming this has just been working, because systemd's socket filename is notify. sooooo

both crun and runc wrap the NOTIFY_SOCKET logic and expose a different socket to the container.
When the container notifies it is ready, crun/runc reads the notification on the socket they've created and propagate it back to systemd on the correct socket.
This is to address two issues:

workaround a systemd notify socket race where the sender of the notification cannot be correctly found with short lived processes if it is not directly monitored by systemd or in a different cgroup.
avoid that the container communicates directly with systemd and could send some weird MAINPID= value.  So both crun/runc filter anything received from the container except READY=1.  I think systemd-nspawn does the same thing.

I have no problem with any of that, except crun is doing it wrong.
When NOTIFY_SOCKET=/run/podman-sdnotify is passed,
CRUN creates /run/crun/CID/notify/notify.sock
CRUN bind mounts /run/crun/CID/notify/notify.sock to /run/notify
CRUN starts the container with NOTIFY_SOCKET=/run/podman-sdnotify
And it doesn't work.
Bind mount appears to be mounting to $(dirname $NOTIFY_SOCKET)/notify but passes the NOTIFY_SOCKET as is.
So, runc works regardless of what NOTIFY_SOCKET is
crun only works if the socket name is notify.  i.e. /run/systemd/notify, /run/notify, /tmp/notify, /tmp/some/path/here/notify, what have you.
Since this isn't related to my PR, I don't think it should be a blocker on this issue - if it needs to be corrected there'd need to be an issue in the crun repo.

Could use some feedback on the e2e test. It works. It's not entirely... understandable.
I could attempt to refactor the unix dgram stuff into a helper function
Also, obviously it wouldn't be merged focused.
I'd squash these 3 commits together.

https://github.com/containers/crun/issues/414

Changes LGTM, but I'd like someone else with more experience with notify to review the tests for accuracy

@giuseppe @edsantiago PTAL

Squashing commits and removing FIt

Yeah I'm not sure about the test failures.  From what I can tell rootless should work just fine.
I don't know how to solve this
"unlinkat /tmp/podman/imagecachedir/vfs/dir/083c11ecaa71f30cd96462da54e18aa870d7cddfa199f9ff31ed8d9913d56b40/run: permission denied"

Or this on fedora 32
Running: podman [options] run fedora sh -c ls -ld $NOTIFY_SOCKET; systemd-notify --ready; printenv NOTIFY_SOCKET
         MAINPID=241378
         MAINPID=241378
         Failed to notify init system: Permission denied
         srwxrwxrwx. 1 root root 0 Jun 24 14:20 /tmp/podman_test883637516/notify
         /tmp/podman_test883637516/notify
         output: srwxrwxrwx. 1 root root 0 Jun 24 14:20 /tmp/podman_test883637516/notify /tmp/podman_test883637516/notify
         [AfterEach] Podman systemd-notify

Or the networking test that's failing on Fedora32 - which I don't think I caused.
Ubuntu tests seem to be apparmor related.
If anyone has any ideas, let me know.  Otherwise, let me know how you'd like me to proceed - if we should merge as is or if you want me to do something else.

AppArmor - known problem, rebase to fix. But I don't think there's any point right now, because I don't think these tests are going to pass any time soon without @giuseppe's help.
@giuseppe, could you take a look at what crun is doing here, and how it's mounting the socket? In particular:
$ NOTIFY_SOCKET=/tmp/podman-sdnotify/notify ./bin/podman run --rm --sdnotify=container fedora sh -c 'ls -lZ /tmp'
total 4
-rwx------. 1 root root system_u:object_r:fusefs_t:s0       1379 May 15 06:48 ks-script-xz5dtd94
drwx------. 2 root root unconfined_u:object_r:user_tmp_t:s0   60 Jun 25 12:17 podman-sdnotify

$ NOTIFY_SOCKET=/tmp/podman-sdnotify/notify ./bin/podman run --rm --sdnotify=container fedora sh -c 'ls -lZ /tmp/podman-sdnotify'
ls: cannot open directory '/tmp/podman-sdnotify': Permission denied

$ sudo setenforce 0
$ NOTIFY_SOCKET=/tmp/podman-sdnotify/notify ./bin/podman run --rm --sdnotify=container fedora sh -c 'ls -lZ /tmp/podman-sdnotify'
total 0
srwxrwxrwx. 1 root root unconfined_u:object_r:user_tmp_t:s0 0 Jun 25 12:17 notify

This happens if I try /run/user/MYID/systemd/notify also: the parent directory and socket are created with user_tmp_t, and I get an AVC when the container tries to access the socket.

@giuseppe, could you take a look at what crun is doing here, and how it's mounting the socket? In particular:

crun is mounting the socket from the /run/user/$UID directory.  That is a socket created by crun itself.  crun will read from this socket and propagate the notification to systemd.
That is why we see the unconfined_u:object_r:container_var_run_t:s0 label.  Should we relax the selinux policy?  I'll try to change the label from crun, I'll let you know in a bit

I've opened a PR here: https://github.com/containers/crun/pull/419
What I see now:
$ NOTIFY_SOCKET=/run/user/1000/notify/notify  ./bin/podman run --rm --sdnotify=container fedora ls -lZ /run/user/1000/notify
ERRO[0000] Error notifying systemd of Conmon PID: dial unixgram /run/user/1000/notify/notify: connect: no such file or directory
ERRO[0000] Error notifying systemd of Conmon PID: dial unixgram /run/user/1000/notify/notify: connect: no such file or directory
total 0
srwxrwxrwx. 1 root root unconfined_u:object_r:container_file_t:s0:c421,c594 0 Jun 25 13:27 notify

AppArmor - known problem, rebase to fix. But I don't think there's any point right now, because I don't think these tests are going to pass any time soon without @giuseppe's help.

I'm rebased on origin/master... so...

This happens if I try /run/user/MYID/systemd/notify also: the parent directory and socket are created with user_tmp_t, and I get an AVC when the container tries to access the socket.

It's my intention to review the mount labels in the "Make libpod/conmon handle the notify socket" branch...

/ok-to-test

Can someone please advise me on how I can run the integration tests locally? I can't get them to work on F32 or Ubuntu 20.04, for different reasons.
I want to fix the checks locally as pushing and having Cirrus tell me they're wrong is going to make this a lot longer to resolve. (And ginkgo focusing local works, but that's using my VM's state, not whatever state Cirrus uses)
At this point my assumptions are that container-selinux 2.137 is included because the libpodimage appears to include updates-testing, but maybe it's failing because crun 0.14 isn't packaged yet.  I want to confirm my assumptions but I can't even get that far locally.
I'm trying make integration, but the "ADD / $GOSRC" looks questionable to me, so I changed it to "ADD . $GOSRC" as it looks like it should add the libpod source directory into the container.
F32 dies with:
[2020-07-01T13:36:10+00:00] Removing:
[2020-07-01T13:36:10+00:00]  runc      x86_64      2:1.0.0-144.dev.gite6555cc.fc32      @@System      9.0 M
[2020-07-01T13:36:10+00:00]
[2020-07-01T13:36:10+00:00] Transaction Summary
[2020-07-01T13:36:10+00:00] ================================================================================
[2020-07-01T13:36:10+00:00] Remove  1 Package
[2020-07-01T13:36:10+00:00]
[2020-07-01T13:36:10+00:00] Freed space: 9.0 M
[2020-07-01T13:36:10+00:00] Running transaction check
[2020-07-01T13:36:10+00:00] Transaction check succeeded.
[2020-07-01T13:36:10+00:00] Running transaction test
[2020-07-01T13:36:10+00:00] Transaction test succeeded.
[2020-07-01T13:36:10+00:00] Running transaction
[2020-07-01T13:36:11+00:00] RPM: error: Plugin selinux: hook tsm_pre failed
[2020-07-01T13:36:11+00:00] Error: Could not run transaction.
[2020-07-01T13:36:11+00:00] <exit 1> dnf erase -y runc
##### (failed with exit: 1)
##### (exceeded 5 attempts)
Error: error building at STEP "RUN bash $PACKER_BASE/fedora_packaging.sh &&     dnf clean all &&     rm -rf /var/cache/dnf": error while running runtime: exit status 125
make: *** [Makefile:280: libpodimage] Error 125

Focal dies with:
STEP 8: RUN bash $PACKER_BASE/fedora_packaging.sh &&     dnf clean all &&     rm -rf /var/cache/dnf
ERRO[0000] systemd cgroup flag passed, but systemd support for managing cgroups is not available
systemd cgroup flag passed, but systemd support for managing cgroups is not available
error running container: error creating container for [/bin/sh -c bash $PACKER_BASE/fedora_packaging.sh &&     dnf clean all &&     rm -rf /var/cache/dnf]: : exit status 1
Error: error building at STEP "RUN bash $PACKER_BASE/fedora_packaging.sh &&     dnf clean all &&     rm -rf /var/cache/dnf": error while running runtime: exit status 1
make: *** [Makefile:280: libpodimage] Error 125

For that matter it seems podman doesn't detect/use systemd cgroup manager on my Focal testbed... Should these tests be run as root?

@edsantiago PTAL

systemd support for managing cgroups is not available

Can you try:  setsebool -P container_manage_cgroup=1
As for running ginkgo tests locally, sorry. I've spent a ridiculous amount of time over the last few years trying to do that and never even gotten close. It must be possible, I suppose, but for me it's actually just faster and less frustrating to let CI do it.

One suggestion: since this is something I'm going to put in system tests anyway, why not just skip ginkgo and go directly to bats? I can help you write a test/system/xxx-sdnotify.bats test if you'd like. THOSE are completely trivial to run on a development system.

Already on container_manage_cgroup --> on
When I do sudo make integration I get
./hack/install_catatonit.sh
skipping ... catatonit is already installed
fatal: not a git repository (or any of the parent directories): .git
go build -ldflags '-X github.com/containers/libpod/libpod/define.gitCommit= -X github.com/containers/libpod/libpod/define.buildInfo=1593612156 -X github.com/containers/libpod/libpod/config._installPrefix=/usr/local -X github.com/containers/libpod/libpod/config._etcDir=/etc ' -tags "   selinux systemd exclude_graphdriver_devicemapper seccomp" -o test/checkseccomp/checkseccomp github.com/containers/libpod/test/checkseccomp
fatal: not a git repository (or any of the parent directories): .git
go build -ldflags '-X github.com/containers/libpod/libpod/define.gitCommit= -X github.com/containers/libpod/libpod/define.buildInfo=1593612157 -X github.com/containers/libpod/libpod/config._installPrefix=/usr/local -X github.com/containers/libpod/libpod/config._etcDir=/etc ' -o test/goecho/goecho github.com/containers/libpod/test/goecho
ginkgo -v  -tags "   selinux systemd exclude_graphdriver_devicemapper seccomp" -timeout=90m -cover -flakeAttempts 3 -progress -trace -noColor -nodes 3 -debug test/e2e/. hack/.
/bin/sh: ginkgo: command not found
make: *** [Makefile:331: ginkgo] Error 127
make: *** [Makefile:300: integration] Error 2

I'm game to test however.  I don't have experience with any of these tools, so I'm just guessing here. :-D
I'm on Kubernetes slack if that's easier.

@edsantiago This is how I'm currently testing
notifytesting.zip
For container, I'll test rootless with
bash notifytest-container.sh $HOME/tmp/notify.sock
bash notifytest-container.sh $HOME/tmp/a/long/path/notify.sock
Root
bash notifytest-container.sh /run/notify.sock
bash notifytest-container.sh /run/notify/notify.sock
bash notifytest-container.sh /tmp/no/particular/path/and/name
The others can run root or rootless since no bind mount takes place.
The --pids-limit 0 is an artifact of #6834
Any help you can provide is appreciated!

@goochjj what is your test environment where you can get this working? I'm just trying to get a manual confirmation that it works, and continue to get AVCs. I am using crun with the latest pr 419 (c04fd1508ab51d8e62bb29d40cddaf23a87e6a44) and the d46fd8ef266e84c70968a199991561c514618d6a commit of your PR. I have container-selinux-2.137.0-3.fc32. I still can't access the socket in the container:
$ NOTIFY_SOCKET=/tmp/podman-sdnotify/notify ./bin/podman run --rm --sdnotify=container fedora sh -c 'systemd-notify --ready'
Failed to notify init system: Permission denied

type=AVC msg=audit(1593618438.828:158200): avc:  denied  { sendto } for  pid=935032 comm="systemd-notify" path="/run/user/14904/crun/665079e2855b0ad745bec386e90b95825fbba4792ecdc710ac9a124f7ba7e38b/notify/notify" scontext=system_u:system_r:container_t:s0:c105,c402 tcontext=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 tclass=unix_dgram_socket permissive=0

@edsantiago place your podman in /usr/local/bin, chcon it to match /usr/bin/
Actually, sudo make install.bin-nobuild
And then use /usr/local/bin.
The SELinux policy tags the podman process based on its source location

Argh - missing chcon, that was it. Thank you!
PS location doesn't matter, all you need to do is chcon -t container_runtime_exec_t bin/podman

Interesting, when I didn't run it from /usr/local I don't think I got the process context, just the file context.   I'm only pretending to know what I'm doing.

@goochjj I submitted https://github.com/goochjj/libpod/pull/2 against your PR, it's a simple .bats file containing tests for each of your additions. Feel free to include it as part of your PR if you like.
Note that the tests are actually disabled, because they require a new conmon and container-selinux that is not available on the CI machines and probably won't be for a while. Since my tests pass, I'm pretty happy to just approve this without tests in CI. It will take time to get the CI systems updated.

@edsantiago  THANK YOU
So I should remove the test/e2e/ file then, ginkgo doesn't have to ALSO test it.
Should we maybe check crun and container-selinux directly? i.e
. /etc/os-release
if [ "$NAME" = "Fedora" -a "$VERSION_ID" = "32" ]; then
VER=$(rpm -q container-selinux --queryformat "%{VERSION}")
if [ -z "$VER" ]; then echo "Cannot find container-selinux"; exit 1; fi
rpmdev-vercmp 2.137 "$VER"
RET=$?
if [ "$RET" = "12" ]; then
#Package is 2.137.0 or newer
true
else
echo "Container-selinux is older than 2.137, skipping test"
fi
fi
Similarly look at crun --version....

So I should remove the test/e2e/ file then, ginkgo doesn't have to ALSO test it.

I'd be happy with that.

Should we maybe check crun and container-selinux directly?

...and add an equivalent check for Ubuntu? That's a scary amount of temporary code. Probably the cleanest option is to file an issue or maybe two: one to upgrade all CI machines, one to update the Fedora specfile to add a Requires: on the specific crun and container-selinux.

So I should remove the test/e2e/ file then, ginkgo doesn't have to ALSO test it.

I'd be happy with that.

Done

Should we maybe check crun and container-selinux directly?

...and add an equivalent check for Ubuntu? That's a scary amount of temporary code. Probably the cleanest option is to file an issue or maybe two: one to upgrade all CI machines, one to update the Fedora specfile to add a Requires: on the specific crun and container-selinux.

Yeah ok you're right.
It looks like you're already conspiring for a crun build, and I know rhatdan is working through the updates-testing branch.  Is there something I need to do? What would those issues look like?

I can file those once crun is packaged. One is an issue here, the other in the fedpkg repo for podman. I'm OOTO the rest of the week but have filed a reminder note for myself. Thanks for all your work on this!

Thank you!

Do I need to do anything else for this to be merged?

Let me re-kick the tests, I think they just flaked.
@rhatdan @vrothberg @giuseppe @baude PTAL

Restarted the last flake

@giuseppe PTAL

Two flakes, both on the Fedora repos. I'm just going to merge once this goes green.
/lgtm
/hold

/hold cancel

Thanks @goochjj Nice contribution.


Forem to Thredded migration questions

I am working on a Forem to Thredded migration.
Questions about some columns:

thredded_topics

type - is this obsolete?

thredded_posts

user_email - denormalized? what if the user changes their email? addressed in #41
source - is this used? should this perhaps be set to 'forem'?

Still figuring out how Thredded does moderation -- noticed a roles table but no state columns on things.
Forem handles moderation like this:

Topics and posts have a state column which can be approved, pending_review, or spam.
The first content a user posts does not get published until it is moderated. Then, the user's forem_state column is set to either approved or spam and all of their content gets the same value.

Here is the initial version https://github.com/jayroh/thredded/wiki/Migrate-from-Forem

See this page in the wiki for more information


Move performance profiler code to a separate package

This would allow the performance profiler to be used independently of the inspector.
Related discussion: https://forum.babylonjs.com/t/introducing-the-performance-profiler/27075/30

Closing as no activity. Feel free to re-open if needed.


Reusable authRights dictionary.

Thanks again, much better. Need to read up on the once blocks as I have thought about that approach on many occasions but haven't looked at it closer.


Korean update

updated korean from recent change of english

I'll take your word for it xD thanks!


Fix bug that prevented to filter sensitive data when there is an exception with multiple 'values'

if an exception has 2 arrays in 'values' key, only values in the 1st array are correctly filtered.
This means that data supposed to be filtered by the SDK is sent unfiltered to sentry
Fixed in PR #483

Closing this issue to discuss furthur in #438.


Fixup: action syntax id must start with a letter

Signed-off-by: austin<EMAIL_ADDRESS>https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions?query="id"#outputsoutput_id

Problem was: Unexpected symbol: '29_base_tag.outputs.tag'


upgrade otelgrpc

What would you like to be added:
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
upgrade to 0.46.0
Why is this needed:
https://avd.aquasec.com/nvd/2023/cve-2023-47108/
exist security problems

Related vulnerability reports:

GHSA-rcjv-mgp8-qvmr (or CVE-2023-45142 and GO-2023-2113)
GHSA-8pgv-569h-w5rw (or CVE-2023-47108)

Related dependencies:
# go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp
github.com/kubernetes-sigs/cri-tools/cmd/crictl
k8s.io/kubernetes/pkg/kubelet/cri/remote
k8s.io/component-base/tracing
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp

# go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
github.com/kubernetes-sigs/cri-tools/cmd/crictl
k8s.io/kubernetes/pkg/kubelet/cri/remote
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc

Currently reported vulnerabilities:

govulncheck:

Scanning your code and 749 packages across 272 dependent modules for known vulnerabilities...

=== Informational ===

There are 2 vulnerabilities in modules that you require that are
neither imported nor called. You may not need to take any action.
See https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck for details.

Vulnerability #1: GO-2023-2402
    Man-in-the-middle attacker can compromise integrity of secure channel in
    golang.org/x/crypto
  More info: https://pkg.go.dev/vuln/GO-2023-2402
  Module: golang.org/x/crypto
    Found in<EMAIL_ADDRESS>    Fixed in<EMAIL_ADDRESS>
Vulnerability #2: GO-2023-2113
    Memory exhaustion in go.opentelemetry.io/contrib/instrumentation
  More info: https://pkg.go.dev/vuln/GO-2023-2113
  Module: go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful
    Found in<EMAIL_ADDRESS>    Fixed in<EMAIL_ADDRESS>
No vulnerabilities found.

Share feedback at https://go.dev/s/govulncheck-feedback.

osv-scanner

╭─────────────────────────────────────┬──────┬───────────┬─────────────────────────────────────────────────────────────────────────────┬─────────┬────────╮
│ OSV URL                             │ CVSS │ ECOSYSTEM │ PACKAGE                                                                     │ VERSION │ SOURCE │
├─────────────────────────────────────┼──────┼───────────┼─────────────────────────────────────────────────────────────────────────────┼─────────┼────────┤
│ https://osv.dev/GHSA-8pgv-569h-w5rw │ 7.5  │ Go        │ go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc │ 0.42.0  │ go.mod │
╰─────────────────────────────────────┴──────┴───────────┴─────────────────────────────────────────────────────────────────────────────┴─────────┴────────╯

@tianzi13sha, thank you for getting in touch!
After looking into the reported security issues, I am happy to report that none affect the project.
To add, the packages against which vulnerabilities were reported are not direct dependencies; as such, there isn't any code path currently using the vulnerable code, and these dependencies are indirect or transitive at best.
I appreciate that vulnerability scanners are most likely picking up on this. That said, I am unsure when a new release will be cut, that might update some of these inessential dependencies.

Related:

https://github.com/kubernetes-sigs/cri-tools/issues/1285


Add Tag Endpoints

This PR adds tag endpoints (GET, PUT, DELETE) as per the spec (http://matrix.org/docs/spec/client_server/r0.2.0.html#client-config) to the sdk.
Also I extracted Room and User classes to their own files to make code a little better organized / easier to navigate (I'll extract that to a separate PR if it's preferred though).

Oooh, thanks :)
I would have preferred it if you had extracted the classes in a separate PR, but I was going to do it anyhow and it's more effort to start dissecting your commits.

Okay to test

ok to test

@pik If you could fix the errors, then I'd be happy with the changes

@Half-Shot Sorry about neglecting this -- updated.

@pik I forgot to ask you to sign this off. Could you read through https://github.com/matrix-org/matrix-python-sdk/blob/master/CONTRIBUTING.rst#sign-off and do so please :)


Request for Default GPU Utilization Metrics

The template below is mostly useful for bug reports and support questions. Feel free to remove anything which doesn't apply to you and add more information where it makes sense.
1. Issue or feature description
After assigning vGPU to a pod, we can retrieve detailed information about the pod's vGPU usage through metrics, such as memory usage and computational power. However, if the pod does not actually use the GPU, these metrics will be absent. Is it possible to add default values to these metrics? This way, when a pod is allocated vGPU, corresponding metrics will be exposed regardless of actual GPU utilization.
2. Steps to reproduce the issue
3. Information to attach (optional if deemed irrelevant)
Common error checking:

[ ] The output of nvidia-smi -a on your host
[ ] Your docker or containerd configuration file (e.g: /etc/docker/daemon.json)
[ ] The vgpu-device-plugin container logs
[ ] The vgpu-scheduler container logs
[ ] The kubelet logs on the node (e.g: sudo journalctl -r -u kubelet)

Additional information that might help better understand your environment and reproduce the bug:

[ ] Docker version from docker version
[ ] Docker command, image and tag used
[ ] Kernel version from uname -a
[ ] Any relevant kernel output lines from dmesg

/kind/feature

@archlitchi cc

Yes, I'm implementing this feature. Ref to https://github.com/Project-HAMi/HAMi/pull/258

Yes, I'm implementing this feature. Ref to #258

Even if pod does not use GPU, will there be a default value?

@CoderTH There are two monitors:
{scheduler node ip}:31993/metrics represents the 'allocated resources' of each containers, regardless of whether it uses or not.
{gpu node ip}:31992/metrics represents the real-time usage of gpu-resources of each container. These metrics are read from a mmap cache file. That file is generated by HAMi-core only when the container accesses the GPU-related cuda and nvml interfaces.  so if the pod does not actually use the GPU -> that file won't be generated -> these metrics will be absent.
It's hard to add a default value, i suggest to read from {scheduler node ip}:31993/metrics to get the information about these idle containers, or add a nvidia-smi in entrypoint of container to generate this cache file during container creation.


fix: issues with styling

Removed similar styles, merged them and fixed issues

Looks good you are good to go

This looks good. But in alert also the texts are aligned in the center. Can you look into it

Yes, I will definitely Improve it


There seems to be an issue importing the 2023-05-15 Azure OpenAI spec into APIM

This issue is for a: (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Spin up a new APIM resource
Click API blade
Import an OpenAPI spec
Use either the Azure API Spec URL or the spec saved to a file to import the API
Fails

Write up here https://github.com/Azure/azure-rest-api-specs/issues/24450

Please disregard. I was trying to import the OpenAI API spec without adding my endpoint to the definition. Rookie mistake! :)


Logo and favicon (could auto-generate)

Be nice to have some kind of bespoke favicon and/or logo for the site.

@stevesong any thoughts? Want to help out on this one?

I would be tempted to use something that hinted at the multidimensional nature of the issue.  Perhaps something like
https://www.onlinewebfonts.com/icon/546236


Include language name, family, and geo region in society results

 Issue by dleehr
Wednesday May 14, 2014 at 18:54 GMT
Originally opened as https://github.com/NESCent/dplace/issues/81

Requires geographic regions to be modeled, but languages will be simple.

 Comment by dleehr
Wednesday May 14, 2014 at 18:56 GMT

Depends on #83

 Comment by dleehr
Monday Aug 11, 2014 at 14:51 GMT

Language family doesn't currently appear


Audio issue

Whenever I try to start the server I get the following error:
Failed to start audio capture. Thread aborted before starting to loopback capture. message=IAudioClient::Initialize failed: hr = 0x88890008
I have already tried to set the system sound to 16bit,48000Hz(DVD) as suggested in other issues but it didn't help. Unchecking steam sound helps. I'm on experimental v6.
Greetings,
Avencore

Do you have a usb audio device? If yes, could you try to disconnect it?

No I don't. I disconnected all audio devices aswell as my monitor with speakers and still the same error message.

my monitor with speakers
Do you by any chance use the remote desktop to launch ALVR on your PC? Cause that is not working. I had to use TeamView to access my PC in the other  room

I'm not sure what you mean by remote desktop.
My procedure for starting is the following:
Start ALVR programm on PC
Start ALVR on Quest
-quest connects to pc automatically-
Press Trigger on Quest to start server/steamVr
Error message on PC appears
Quest app crashes

Ok, I was just wondering how you start ALVR without a monitor.
What audio devices do you have? ALVR tries to capture the audio at 48khz 16bit, the error you get suggests that this is not supported by your audio device. After a little research, I found that Realtek audio drivers sometimes misbehave in that regard. Maybe there is an updated driver for your hardware.
You can also enable ALVR debut log. Create the folder „logs“ next to your ALVR.exe
In the Uli under debug, you can enable the logging. Please post the log here.

Thank you for your time. Updating the Realtek driver indeed fixed the issue.


int8 question

I do some test about resnet50_int.pth and convert it to .xml and .bin,I find that its type is float32, not int8.How to understand fakequantize?I find it uses fakequantize.Is there a way to get a model which type is int8?Looking forward to your reply!

@AlexKoff88

The current approach in OpenVINO implies to keep model with FakeQuantize operations in IR. The real transformation to INT8 happens during model inference. This approach is under development now and full support from OpenVINO side should be enabled in the next release. Please follow up.

Hi,could you please show it how to transform to INT8 in details(because it does quantization by fakequantize, but I can not find it in inference-engine) or where I can find correspoing codes?In my opinion, the difference of quantization between openvino_training_extensions and inference-engine calibration tools is that it will do finetune in openvino_training_extensions, and calibration tools does calibration in eval mode,right?

@AlexKoff88

You are right. NNCF (part of training extensions) does the quantization with fine-tuning (Quantization-aware Training), OpenVINO has the calibration tool which does post-training quantization with no fine-tuning. The second post-training path has better support from the Inference Engine side and actually the representation of the models after NNCF compression and calibration tool is different even in IR.
In the next OpenVINO release, we are going to fix that and align the representation and inference pipeline for both paths.


Extracting parts of a datetime in a query

I have a datetime column from which I would like to extract the year part. I've tried a few different ways, all of which are valid (Postgre)SQL queries, but they all run afoul of SmartNoise SQL's parser:
SELECT count(*) AS num, col_a, DATE_PART('year', col_b) AS col_b_year FROM schema_name.table_name GROUP BY col_a, col_b_year

Errors out with ValueError: Bad token ( at line 1 column 40.  Message: missing FROM at '('
SELECT count(*) AS num, col_a, EXTRACT(YEAR FROM col_b) AS col_b_year FROM schema_name.table_name GROUP BY col_a, col_b_year

Errors out with AttributeError: 'str' object has no attribute 'children', coming from snsql/xpath/ast.py, line 222.
Would you have any advice on how to do this so that SmartNoise SQL would be able to parse the query? Thanks!
EDIT: The error message in the second case has been edited, the first version was an error on my side.

Thanks very much for reporting this issue.  It was indeed a bug in EXTRACT where symbol resolution made a copy with datepart and target expression swapped.  All of our unit tests for these functions are run on ASTs with no symbols loaded, so we totally missed this.  It should be fixed now in smartnoise-sql==0.2.11.  Note that you will need to use syntax like:
query = SELECT EXTRACT(YEAR FROM col_b) AS col_b_year FROM schema_name.table_name GROUP BY EXTRACT(YEAR FROM col_b)'

This is because the EXTRACT in the GROUP BY is executed in the database engine, while the EXTRACT in the SELECT is run inside SmartNoise, as post-processing over the differentially private aggregates.  Please let me know if the issue persists in the new release.

Works splendidly in 0.2.11, thanks @joshua-oss!


Issue: C#  VSCode Extension Stuck in "Installing" State, IntelliCode and OmniSharp Not Working

Description:
I am experiencing an issue with the C# extension in Visual Studio Code where it is stuck in the "Installing" state and does not complete the installation process. This issue prevents me from using the C# extension and its features in my development workflow.
Steps to Reproduce:
-     Open Visual Studio Code.
-     Go to the Extensions sidebar.
-     Search for the "C#" extension.
-     Click on the "Install" button for the C# extension.
-     Observe that the extension remains in the "Installing" state indefinitely.

Expected Behavior:
The C# extension should install successfully and transition from the "Installing" state to the "Installed" state. I should be able to use the C# extension for my coding tasks.
Actual Behavior:
The C# extension gets stuck in the "Installing" state and does not complete the installation process. I have tried restarting Visual Studio Code and my computer, but the issue persists.
Environment Information:
  -     Visual Studio Code Version: Version: 1.81.1
                                              Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
                                              Date: 2023-08-09T22:18:39.991Z
                                              Electron: 22.3.18
                                              ElectronBuildId: 22689846
                                              Node.js: 16.17.1
                                              V8: <IP_ADDRESS>-electron.0
                                              OS: Linux x64 6.2.0-26-generic snap

  -       Operating System: Linux ea 6.2.0-26-generic #26~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Jul 13 16:27:29 UTC 2
                                             x86_64 x86_64 x86_64 GNU/Linux

  -       C# Extension Version: Latest

Additional Information:
I have attempted to restart Visual Studio Code and my computer, clear the extension cache, and reinstall Visual Studio Code itself. Despite these efforts, the C# extension remains stuck in the "Installing" state.
The issue initially arose due to the malfunctioning of IntelliCode and OmniSharp features, which led to the decision to roll back to a previous version of the extension. I am now unable to install the previous version and the extension is nonfunctional.
I appreciate any assistance in resolving this issue and getting the C# extension back to a functional state.
Thank you for your attention to this matter.
Sincerely,
Elias
ElieAzar-Algo

Apologies for the late reply here.  I'm not sure there is much we can do here from the extension side - we don't have insight into the installation.  A couple of suggestions you can try:

Delete all folders starting with ms-dotnettools. in the extensions folder (when vscode is closed), and then re-installing.  You can find the extensions folder via this command:

If 1) doesn't work delete the folders again but try installing the vsix manually.  You can download the vsix for your platform here - https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.csharp (see screenshot below).

You'd then install it in VSCode via the 'install from vsix' item in the extensions menu:

If neither of those work, I'd try re-installing vscode entirely.  There's not much more advice I can give, you might have to reach out to the vscode team for this.


Lcam 691 stateless service

https://dsdmoj.atlassian.net/browse/LCAM-691
Core of new Stateless API calling into existing CMA code

The build is currently showing as failed, due to a security vulnerability. This is now fixed, so please go ahead and merge in your changes.


Validation Errors Issue

When you have roles attached to SimpleRepeatable Field anf you get a validation error that DOES NOT related to SimpleRepeatable filed, then you get an error

TypeError: Cannot read property '0' of null
Seems in case we have validation error, it tries to get first validation error. but as that validation  error belongs to another filed, it tries to get first item from NULL, and that brakes the JS code.
In this case Sorting and "Add Row" don't work anymore, and also the data can't be saved anymore, even when validation error is fixed.

An Update, I checked and it return a JSON string, my validation was set to expect an Array, that's why it was broken.
But still there is an issue that Validation error "Extensions field must be an Array" is not shown here.


Don't overwrite human decisions when the regression keyword is removed alongside other keywords

Coverage remained the same at 25.778% when pulling 6fa0ed4292c5ea60674a794f0ff78b20b9f7a0e8 on marco-c:dont_overwrite_when_regression into 0f7a6cd5a904f1b9bd972d635756def53b575220 on mozilla:master.


Feature ads logos and licensing

Added a page that contains the logos used by the ADS. The pull request is not final, and needs to be complete after some discussion. More specifically:

What licensing do we want?
Currently I have put the Creative Commons with Attribution license, which means anyone can copy, modify, redistribute, sell it, aslong as they attribute the author
I have put the author as SAO/NASA, but I would expect @aholachek gets credit also - I guess this is stipulated in our contracts somewhere? @aaccomazzi?
I have added download buttons, which would be nice if they were zip files that contain a set of sizes and background colors (if possible). Much like with github, it means you can use them out of the box asap, which is pretty cool.
We can add more images, these are the ones that came to my mind. We could include things like the 'Classic' style image on the new UI.

This should close adsabs/bumblebee/issues/420

so i should wait to merge this until we talk about it, right?

Just to clarify, there is no contractual specification regarding licensing.  So we should follow Smithsonian's general policy which is to use a license such as CC-BY (http://creativecommons.org/licenses/by/4.0/) for this content.  Since the logos were created by Alex as part of her work at SAO the copyright belongs to SAO with credit to Alex as the developer.

Noo think of all the royalties I'm going to miss out on
On Tue, Oct 13, 2015 at 11:06 AM, Alberto Accomazzi <
<EMAIL_ADDRESS>wrote:

Just to clarify, there is no contractual specification regarding
licensing. So we should follow Smithsonian's general policy which is to use
a license such as CC-BY (http://creativecommons.org/licenses/by/4.0/) for
this content. Since the logos were created by Alex as part of her work at
SAO the copyright belongs to SAO with credit to Alex as the developer.
—
Reply to this email directly or view it on GitHub
https://github.com/adsabs/help/pull/16#issuecomment-147743514.

I think it can be merged as is, given that Jonny specified the correct
CC-BY license already.
-- AA
On Tue, Oct 13, 2015 at 11:54 AM, Alex<EMAIL_ADDRESS>wrote:

Noo think of all the royalties I'm going to miss out on
On Tue, Oct 13, 2015 at 11:06 AM, Alberto Accomazzi <
<EMAIL_ADDRESS>wrote:

Just to clarify, there is no contractual specification regarding
licensing. So we should follow Smithsonian's general policy which is to
use
a license such as CC-BY (http://creativecommons.org/licenses/by/4.0/)
for
this content. Since the logos were created by Alex as part of her work at
SAO the copyright belongs to SAO with credit to Alex as the developer.
—
Reply to this email directly or view it on GitHub
https://github.com/adsabs/help/pull/16#issuecomment-147743514.

—
Reply to this email directly or view it on GitHub
https://github.com/adsabs/help/pull/16#issuecomment-147758102.

--
Dr. Alberto Accomazzi
Program Manager
NASA Astrophysics Data System - http://ads.harvard.edu
Harvard-Smithsonian Center for Astrophysics - http://www.cfa.harvard.edu
60 Garden St, MS 83, Cambridge, MA 02138, USA


Highlight sound settings are confusing

"Play sound" and "Custom sound" are very far away. Columns need to be reordered to make more sense.
"Cancel" in the file picker removes the custom sound. However there is no proper way to reset the custom sound appart from that.
"Fallback sound" settings is hard to understand.

Why is it a checkbox? Can we remove the checkbox and call it "Default sound:"?

The fallback sound check box should be removed imo, however the setting itself is really useful

Yeah, I'm not content with the design of the sound settings either. If anyone comes up with a better design, feel free to either implement it yourself or drop the idea here so I can implement it at some point in the future.

Let me try. I would personally get rid of the checkbox, implicitly enable it, and rename "fallback" to "default".
In other words:

If no custom default sound is set, use the standard sound shipped with the app.
If custom default sound is set, use that.

From the UX standpoint, there would be one button with text "Change default sound", and if changed, maybe have the filename label with X to remove it.

How about this:

Without custom/default sound

I'm not sure about the default name.

@Nerixyz Your suggestion looks good.
The name is fine IMO, but you can set a tooltip with further explanation if you think it's unclear.


Placing Home button in Login page

When the user once enter into login page if they need to come back again to home page i will make back button or home button in ligin page screen

@SHANMUGAPRIYA-1 I have assigned u the issue. Go ahead.

please label this issue


chore(bundle): publish on npm

Currently publishing doesn't work because of some issue:
error: Uncaught (in promise) TypeError: Failed to bundle ts:
Build failed with 102 errors:
node_modules/.deno/@dual-bundle+import-meta-resolve@4.1.0/node_modules/@dual-bundle/import-meta-resolve/index.cjs:39:42: ERROR: Could not resolve "node:assert"
node_modules/.deno/@dual-bundle+import-meta-resolve@4.1.0/node_modules/@dual-bundle/import-meta-resolve/index.cjs:40:30: ERROR: Could not resolve "node:fs"
node_modules/.deno/@dual-bundle+import-meta-resolve@4.1.0/node_modules/@dual-bundle/import-meta-resolve/index.cjs:41:42: ERROR: Could not resolve "node:process"
node_modules/.deno/@dual-bundle+import-meta-resolve@4.1.0/node_modules/@dual-bundle/import-meta-resolve/index.cjs:42:31: ERROR: Could not resolve "node:url"
node_modules/.deno/@dual-bundle+import-meta-resolve@4.1.0/node_modules/@dual-bundle/import-meta-resolve/index.cjs:43:40: ERROR: Could not resolve "node:path"

But this might be related to stylelint/stylelint#7556

See #86


fix flat history graph across runs with different values in ItemViewModel

[ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[ ] Ensure that the pull request title represents the desired changelog entry
[ ] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

fixes #3


Reenable 1.8V SD card signalling on RT600 Platform

Is your enhancement proposal related to a problem? Please describe.
The current USDHC driver for the NXP RT600 evaluation kit does not properly support operating SD cards at 1.8V signalling, and will fail to mount an SD card that attempts to utilize 1.8V signalling instead of the standard 3.3V.
Describe the solution you'd like
PR #38507 fixes this issue temporarily by disabling 1.8V signalling within the driver when running on this board. However, 1.8V signalling support would be preferable for power consumption. The evaluation board controls the signalling voltage level via a PMIC, which Zephyr does not support interfacing with.
Ideally, the PMIC should be accessible within Zephyr to enable utilizing SD cards at 1.8V on this evaluation board. This could be accomplished via adding board-specific code to interface with the PMIC, or via creating a driver api for PMIC devices and integrating the existing PMIC driver into Zephyr.
Describe alternatives you've considered
The simplest solution is likely to add board-specific code for this PMIC. The only alternative I've considered is creating a driver API, but this would likely be a secondary step after fixing the initial issue with 1.8V signalling on this board given how large of a change it requires.

PR #38580 should fix this issue correctly, by enabling the RT685 PMIC and interfacing with it to reduce the voltage


Failing to install prerelease packages

My package is marked as preview and an error occurs when trying to install on latest nightly build:

Actually it's failing to install any package :(

The problem is the '&' that is present in the query string of the --source parameter used by composer will be interpreted by the command line since it is not escaped. As such, cmd will say 'this is the end of the current command and the next command is to run prerelease.exe' which clearly doesn't exist. Did you add the package source yourself? If yes, could you share the name and url you added? If not, we likely just have to escape the query string in this url in the package manager code. Let us know which one it is and we can take it from there.


Pylance cannot provide intellisense for xml.dom.parse()

Example:
from xml.dom import minidom
doc= minidom.parse("abc.xml")
doc.

We cannot get any intellisense. And it shows that the return of parse is any.

However it should be document instead of any.

The type information for the xml library comes from typeshed. The parse function, in particular, can be found here. Note that it is missing a return type annotation. In general, typeshed has very complete type information for most of the stdlib libraries, but xml is an exception. It is quite incomplete. If you are familiar with the xml library and want to contribute type information, you can submit PRs directly to typeshed. Pyright and pylance (and other Python type checkers and language servers) bundle the typeshed stubs, so any improvements here will help the entire Python community.


gke: save raw kubeconfig to connection secret

Description of your changes
Implements https://github.com/crossplaneio/crossplane/issues/861 for GKE.

Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[x] Updated any relevant documentation, examples, or release notes.
[x] Updated the dependencies in app.yaml to include any new role permissions.

@muvaf Looks like this failing make check-diff, which means running make reviewable is resulting in a git diff when run by Jenkins. Would you mind fixing that and bumping crossplane-runtime to the newly released https://github.com/crossplaneio/crossplane-runtime/releases/tag/v0.2.2?


correct additionalWhere settings

I corrected the additionalWhere clause in the README. It only works with an prefixed AND.

Thank you 👍


local sst cache eviction

a follow up of https://github.com/slatedb/slatedb/issues/9
came across this strategy might be helpful while dealing with millions of cache files:

Cache size (in MiB, default to 102400) and minimum ratio of free size (default 0.1). Both parameters is able to control cache size, if any of the two criteria is met, client will evict cache using the simple 2-random strategy, i.e. randomly pick 2 blocks, and drop the one with an earlier access time. Under most real world scenarios, the overall outcome is similar to LRU algorithm, while random-2 comes with lower overhead.

from https://juicefs.com/docs/cloud/guide/cache/#data-cache

Awesome! Assigned to you.
@rodesai is in the process of merging a benchmark tool in #148. Think this would be enough to run some benchmarks if you instrument the code with metrics (#145 just got merged)?


Recipient in connectMP accept/reject actor messages is blank

Current Behavior

The recipient for connectMP messages is left blank.
Expected behavior

Should use either the current (hardcoded) value, or get the value based on sender of the original message.
How to reproduce

Send in a succesful or nonsuccesful connect request.
Environment

D-002.

@cmgrd Has this been fixed?


Adds perf test project

Description
Adds perftest project
Related issues
Addresses #358.

Nice to get a start on this! Have you thought about where we would run these and how we would track changes across builds?


[cudamapper] Do not do self-mapping of reads

When doing all-vs-all do not look for anchors of reads with the same read_id. Currently we are doing this for the sake of code simplicity, but this introduces additional overlaps which probably affect accuracy and definitely affect performance by creating additional anchors which take up more space and require time to be processed.
There are two options:

Make Matcher not look for anchors with the same read_id
If 1) turns out to be too complicated simply skip matching same indices. This would lead to all read pairs from those indices to be skipped, so option 1) is preferred

@tijyojwad @vellamike FYI


Rename repo root to path

I noticed this line in the code:
public let root: String  //TODO rename path

So I renamed this property to path. The tests seem to have the same pass/fail rate as they did before as well.

Thanks!


Improve the search engine, multi tag search

The search module should be improved, the user should be able to search for projects by selecting one or several tags.
The user should be able to find a list of projects by entering text (the current full-text search) and/or selecting one or several tags.
This new search engine should be included at the top of any page, a bit like Yarn does.
For the tag filter, we can implement a drop-down menu with autocomplete feature, like this one React Select
The problem: how we combine the 2 features (full-text search and filter by tags)?
Option A
Can the same input field be used for the 2 purposes?
it means that when the user starts to type, the matching tags are displayed (waiting for being selected by the user) and a list of projects that match the text is also displayed below (which can be confusing?)
Option 2
Or is it better to split the 2 controls?
For example: a textbox on the left to enter any text to trigger the full-text search and the "tags" auto-complete field on the right.

First iteration
It’s still Work In Progress but I’d like to share a preview of the next Best of JavaScript!
https://next--bestofjs.netlify.com/
The main change is a new search engine that lets you combine one or several tags with keywords, in the same search box.
Also, when you pick an option (like “show by number of stars since yesterday”) it’s preserved while you navigate.
The design has changed , no more huge sidebar, but it’s still quite raw.
It’s inspired by https://yarnpkg.com/.
Screenshots

personally I prefer one control (UX point of view), I think this is a great feature for people searching for packages with their need. I am loving it.
A use case for me: I would just go react and then forms

Thank you very much @bluebill1049 for the feedback.
I will try to improve the search by tag before releasing in production.
Specific tags like "Forms" are often related to more generic tags like "React" or "Vue.js".
For example if you pick Form, or Component Toolkit, it will be nice to be able to pick easily "React" or "Vue.js", because people often search for libraries related to a given framework.
An other point you could check: we improved the "bookmark" feature for logged-in users.
Maybe you could try to bookmark your 4 projects on Best of JavaScript 😄

aha yea I will try that :)

The search field is very useful, IMO it's the fastest way to find by tags or by name.
It's a good work and improves a lot the experience.
My UX remarks:

search field

on second spacebar press, just after the suggestions shown, it shouldn't insert the current selected item (almost always the first), it happens too often to accidentally insert a non wanted item
when emptied (eg. after deletion of all tags) it's the same state of the homepage, so the page should be the homapage and not a list of ALL projects; there's already the hidden button 'All Projects' to achieve that result

hamburger button: it's not appealing to use it and should not exists on non-mobile, the submenu has a very short list and a flat horizontal menu should be good enough

My 2 cents for now :-)

Thank you very much for your feedback @devhero!
About the layout, I removed the hamburger button and created a classic menu with. I feel like it's giving too much importance to these 2 menu items but I'm not sure and it's better than before, I think.
The mobile layout is on my todo list (either a basic dropdown menu or a off-canvas sidebar)

If the user reset the search query, I did what you said: back to the home page.
About the space key, it seems that the first space key opens the suggestions and the second one selects the focused element (or the first element if nothing is focused) I'm curious to know what would be the behavior you expect?

About the space key, my idea is that it should works just at the first click (showing suggestions) and once in that status nothing else.

Hello @devhero
Thank you very much for your time!
As soon as the drop-down menu opens to show the suggestions, the first element is focused and therefore a space key event means that the element is selected.
To solve the problem, I've inserted a blank element "Pick a tag..." that does not trigger any tag selection, it only closes the drop-down menu when it's clicked.
Could you check again?

Hello Andrew @ragamufin
I took into account 2 points you mentioned.
Point A: backspace key behavior
You can move the cursor just after the tag, before the free text, and press the backspace key, the last tag will be removed without removing the user query.

Point B: more flexible queries
You can now search for react native web and "React Native for Web" will come back.
Under the hood, if the user enters spaces, it's considered as a place holder for any character, it may have side effects.
Check: https://next--bestofjs.netlify.com/projects?query=react native web

Thank you again!

@michaelrambeau wow fast! nice
Yup, it works excellently now. Very smooth.
I guess the last bullet point I sent is pretty tricky to do huh? As it is now it is perfect so I'd let it be as it is, somehow now without the sidebar it feels spacious and breezy, good work!

@ragamufin Thank you very much for having checked Andrew!
About the third point, I will tell you if I can find a solution, I didn't have time to investigate but I'm keeping that point in mind.

Latest iteration, including improvement for mobiles
On desktops

On mobiles

Screenshot for the README.md

Released in v0.19 https://github.com/bestofjs/bestofjs-webui/releases/tag/0.19.0


SSR

Server Side Rendering
Should allow users to build their app on the server, and then serve up HTML as a string.
Tram-One Changes

toString

File Changes

centralized babelrc for builds
add config for source maps (unverified)
Node Launcher for Testem, so we can run tests in node.js
remove asserts from build and dependencies
two builds, umd and esm
new build script to build an es module
conditionalize tram-spec for server runs
short-circuit browser-specific tests if we're running on a server

Fixes

added eslint plugins that were required

Tests

TBD

Resolves #2
Resolves #7 <-- Rollup at its current state is not simple or obvious enough to use for both web bundles and es module builds.

Not ready quite yet, sanity check proves that exposed build is not functioning as expected.


Remove simplemde console.log spam

simplemde seems to contain console.log spam which is visible on every page with it running. No idea why this is even in there, but I silenced it via replacing the two statements with undefined (the return value of console.log).

Apparently this is https://github.com/sparksuite/simplemde-markdown-editor/pull/348/files

I will move it to npm and upgrade to latest version which does not have the spam.

Putting this up again because:

Latest version of SimpleMDE is not a drop-in, it fails at some CodeMirror stuff
Getting SimpleMDE+CodeMirror plugins/modes loaded in Webpack is a nightmare of its own because CodeMirror does not support bundlers with its lazy-loading approach.

I think it should be possible to use the version on npm by putting something like
import 'simplemde';
```.

import 'simplemde'; will include the code in the main JS bundle that needs to parse on every page load and for that SimpleMDE is just too big (around 250kB).
This here is just a stop-gap solution to the console spam. Either https://github.com/go-gitea/gitea/pull/9973 or a proper upgrade to latest 2016 version of SimpleMDE will fully resolve it.

@silverwind import 'simplemde'; can be added to new entrypoint also to not bundle it with main

Yeah, it can be lazy-loaded of course, but it's more than just that as codemirror's lazy-loading (which is incompatible with webpack) also needs to be re-implemented. See https://github.com/go-gitea/gitea/pull/9973#issuecomment-596125416.

I guess a individual chunk with just the sync import and the script tag replaced and pointing to the webpack chunk may also work.

Yes, that is what I mean

Yeah that would be similar to how jQuery is done currently. I'm not really a fan of such solutions because it will generate polyfill overhead as each chunk gets their own set of polyfills.

But at least we can update dependencies using npm

IMHO, our time is better invested removing SimpleMDE altogether. It weights in at 300kb for what could probably be done in 5-10kB with a simple <textarea> and a few buttons that insert snippets at the cursor.

Closing as this does not seem to get any acceptance.


Intel 14th-gen Meteor Lake

Describe the support request
I would like to add new Intel 14th-gen Meteor Lake as resources into my pod by:
resources:
  limits:
    gpu.intel.com/i915: 1

but pod wont initialize because of lacking resources.
System (please complete the following information if applicable):

OS version: [e.g. Ubuntu 22.04]
Kernel version: [e.g. Linux 5.15]
Device plugins version: [e.g. v0.29.0]
Hardware info: [e.g. SPR with QAT]

Hi @Kiryuumaru could please describe your environment? Which k8s version, which gpu plugin you installed etc.?

Closing. Please reopen with more details if this is still an issue.


Upgrade Apache Commons Collections to v3.2.2

Version 3.2.1 has a CVSS 10.0 vulnerability. That's the worst kind of
vulnerability that exists. By merely existing on the classpath, this
library causes the Java serialization parser for the entire JVM process
to go from being a state machine to a turing machine. A turing machine
with an exec() function!
https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-8103
https://commons.apache.org/proper/commons-collections/security-reports.html
http://foxglovesecurity.com/2015/11/06/what-do-weblogic-websphere-jboss-jenkins-opennms-and-your-application-have-in-common-this-vulnerability/

Can one of the admins verify this patch?

Thanks @bdspecht. We haven't setup a code contributer agreement yet, so if it's ok with you we'll merge this change to the develop branch. Thanks for the heads up.


React Native Showcase Link Broken

Hello, I was going through react native docs, in this Showcase section is has a broken link !

@sazzadsazib nice catch! the correct link seems to be https://reactnative.dev/showcase/
Would you like to send a PR to fix this?

Alright !


[Bug]: Attempting to select non-boolean expression.

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Branch name
main
Commit ID
7e3978a
Other environment information
No response
Actual behavior
[11:10:38.741] [129030] [critical] Attempting to select non-boolean expression@src/executor/expression/expression_selector.cpp:69
terminate called after throwing an instance of 'infinity::UnrecoverableException@infinity_exception'
  what():  Attempting to select non-boolean expression@src/executor/expression/expression_selector.cpp:69
Aborted (core dumped)

Expected behavior
No response
Steps to reproduce
Function test code can be found in python/test/test_delete.py`test_filter_expression`
Function test code can be found in python/test/test_update.py`test_filter_expression`
Please use `c1`

Additional information
No response

It looks fixed.


[Performance] Refresh Access Token Failed with Status code: 400

System Information (Required)

SDK Language: NODE
SDK Version: 3.7.0
Development Environment: LOCALHOST, AZURE_APP_SERVICE

Issue Description
Our Production Bot is deployed and configured for FB, Slack, Skype, Web. It was working perfectly well across channels. There's no new code / release to the prod env.
Since 30 mins, the bot is down with errors in log files - refresh access token issue.
Please find the log entries below.
I am not sure what's the issue. The Bot just stopped working, which seems some issues with Token Issue / Refresh API Endpoints.
2017-07-25T18:25:04.264999000Z Error: Refresh access token failed with status code: 400
2017-07-25T18:25:04.265192000Z     at Request._callback (/usr/src/app/node_modules/botbuilder/lib/bots/ChatConnector.js:489:28)
2017-07-25T18:25:04.265351000Z     at Request.self.callback (/usr/src/app/node_modules/request/request.js:187:22)
2017-07-25T18:25:04.265478000Z     at emitTwo (events.js:106:13)
2017-07-25T18:25:04.265627000Z     at Request.emit (events.js:194:7)
2017-07-25T18:25:04.265760000Z     at Request.<anonymous> (/usr/src/app/node_modules/request/request.js:1044:10)
2017-07-25T18:25:04.265870000Z     at emitOne (events.js:96:13)
2017-07-25T18:25:04.266006000Z     at Request.emit (events.js:191:7)
2017-07-25T18:25:04.266130000Z     at IncomingMessage.<anonymous> (/usr/src/app/node_modules/request/request.js:965:12)
2017-07-25T18:25:04.266257000Z     at emitNone (events.js:91:20)
2017-07-25T18:25:04.266393000Z     at IncomingMessage.emit (events.js:188:7)
2017-07-25T18:25:04.266521000Z     at endReadableNT (_stream_readable.js:975:12)
2017-07-25T18:25:04.266649000Z     at _combinedTickCallback (internal/process/next_tick.js:80:11)
2017-07-25T18:25:04.266826000Z     at process._tickDomainCallback (internal/process/next_tick.js:128:9)2017-07-25T18:25:04.264999000Z Error: Refresh access token failed with status code: 400
2017-07-25T18:25:04.265192000Z     at Request._callback (/usr/src/app/node_modules/botbuilder/lib/bots/ChatConnector.js:489:28)
2017-07-25T18:25:04.265351000Z     at Request.self.callback (/usr/src/app/node_modules/request/request.js:187:22)
2017-07-25T18:25:04.265478000Z     at emitTwo (events.js:106:13)
2017-07-25T18:25:04.265627000Z     at Request.emit (events.js:194:7)
2017-07-25T18:25:04.265760000Z     at Request.<anonymous> (/usr/src/app/node_modules/request/request.js:1044:10)
2017-07-25T18:25:04.265870000Z     at emitOne (events.js:96:13)
2017-07-25T18:25:04.266006000Z     at Request.emit (events.js:191:7)
2017-07-25T18:25:04.266130000Z     at IncomingMessage.<anonymous> (/usr/src/app/node_modules/request/request.js:965:12)
2017-07-25T18:25:04.266257000Z     at emitNone (events.js:91:20)
2017-07-25T18:25:04.266393000Z     at IncomingMessage.emit (events.js:188:7)
2017-07-25T18:25:04.266521000Z     at endReadableNT (_stream_readable.js:975:12)
2017-07-25T18:25:04.266649000Z     at _combinedTickCallback (internal/process/next_tick.js:80:11)
2017-07-25T18:25:04.266826000Z     at process._tickDomainCallback (internal/process/next_tick.js:128:9)

@sharmadine Thanks for reporting. We are experiencing a service interruption and we've got multiple engineers looking into it. Will update you when we have more details.

Hi @nwhitmont
Same here
Thank you for fast response.
We will wait

Also having the issue.

+1, for myself and my clients.

+1 Let us know when it is fixed

+1, arg

+1 bot is on mute

+1

+1

+1

+1

plus one

same here

We all know that it is still in Preview, but, for those who have their Bots under BotFramework infraestructure... how do you explain this downtime to your customers?

same

+1

I seem to have improved

The service is restored :)

The incident has been resolved, bots should be back to normal activity now.

Yes, the bot is alive again... thanks.

my bot is still not replying?

Notice last message says: Error sending to bot
This issue happens on all channels except emulator.
I'm even remote debugging to my azure app service, and bot framework is not sending the activities to it.

I apologize, I just found the issue. It made me get confused since the issue appeared along this one and was impossible for me to debug.
So, I changed the namespace and project name of my bot application. Apparently this made Azure app service believe there were multiple API controller endpoints somehow. And that's why the Bot Framework connector couldn't reach my bot application.
So even after cleaning my solution, recompiling, deleting bin and obj folders, etc it didn't work. What I had to do is delete the azure app service and create a new one, and voila!
Sorry for the inconveniences!