add validation for local origin errors

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
4eb665e98740a9aa1da31aa9f3c1eb2fbb7635ca
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster-tests_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
4eb665e98740a9aa1da31aa9f3c1eb2fbb7635ca
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster-tests_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
4eb665e98740a9aa1da31aa9f3c1eb2fbb7635ca
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/test all

When SplitExternalLocalOriginErrors set, does Consecutive_5Xx takes effect?

Yes it does unless we set it to zero


ASP.NET Core: Not allowed methods on TableController return 500 Internal Server Error

Describe the bug
Non-action methods in TableController appear as valid endpoints, causing an Internal Server Error when requesting non-valid endpoints like PUT on Listing.
Microsoft.AspNetCore.Routing.Matching.AmbiguousMatchException: The request matched multiple endpoints. Matches:
BlogServer.Controllers.UsersController.IsAuthorized (BlogServer)
BlogServer.Controllers.UsersController.PrepareItemForStoreAsync (BlogServer)
BlogServer.Controllers.UsersController.PrepareItemForStore (BlogServer)
   at Microsoft.AspNetCore.Routing.Matching.DefaultEndpointSelector.ReportAmbiguity(CandidateState[] candidateState)
   at Microsoft.AspNetCore.Routing.Matching.DefaultEndpointSelector.ProcessFinalCandidates(HttpContext httpContext, CandidateState[] candidateState)
   at Microsoft.AspNetCore.Routing.Matching.DefaultEndpointSelector.Select(HttpContext httpContext, CandidateState[] candidateState)
   at Microsoft.AspNetCore.Routing.Matching.DefaultEndpointSelector.SelectAsync(HttpContext httpContext, CandidateSet candidateSet)
   at Microsoft.AspNetCore.Routing.Matching.DfaMatcher.SelectEndpointWithPoliciesAsync(HttpContext httpContext, IEndpointSelectorPolicy[] policies, CandidateSet candidateSet)
   at Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware.<Invoke>g__AwaitMatch|8_1(EndpointRoutingMiddleware middleware, HttpContext httpContext, Task matchTask)
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

Expected behavior
The service should return a 405 (Method not allowed)
What platforms?

Server:

[ ] ASP.NET Framework (Legacy)
[x] ASP.NET Core
[ ] Node.js (Legacy)

Fixed in 01e6c2f


[BUG] - Can upgrade/downgrade ghost concstructions

Describe the bug
Title; happens with sorters but I assume other items too
To Reproduce
Steps to reproduce the behavior:

Paste Blueprint that contains items not in inventory (example sorter MK2)
Try to upgrade or downgrade the ghost item (for example a sorter) but you can't change to (example: sorter MK3).  Hover over item is blank.  You have to dlete it or get the item to your inventory

Expected behavior
Previously, we could upgrade sorters ghost and then have them construct

Is the behaviour you are looking for something that Blueprint Tweaks provided previously or is it something vanilla, that Blueprint Tweaks breaks?

Good question; I have never played vanilla, since your Mod came out.  I have tested some more and it appeared only for sorters when the blueprint was higher tier than had been researched.  I my case, BO had blue sorter and I only had researched green.  In the past, with the mod, these sorters could be downgraded using the in-game tool.


[Asset-Sync] Add Post-Checkout Git Hook Script to Restore all assets.json within repo

Problems:

test-proxy (our "restore" tool) may or may not be present on the machine
is there a post-checkout hook specifically that we can add to each repo?
The script should properly no-op (or inform user) if tooling is not present

Does this cooperate well?

@scbedd, not sure if you or @JimSuplizio will be doing this.  Assigning it to you first.

This task is supplanted by the shims of each repo passing the appropriate assets.json along to the proxy if detected.


Tidy up method signatures and Expectation blocks

Signed-off-by: Ross Pavitt<EMAIL_ADDRESS>

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Issue when upgrading from 1.3.1 to 1.4.0

Hello,
First, thank you for the Docbook XSL stylesheets!  They are great.
I've been using 1.3.1 to chunk my docbook file to html files.  All has been working fine.  I downloaded 1.4.0 today and ran through my scripts without changing anything and started getting this message:
java : Error at char 5 in expression in xsl:when/@test on line 93 column 37 of docbook.xsl:  ... XPDY0050  The root of the tree containing the context item is not a document node   In template rule with match="node()" on line 88 of docbook.xsl      invoked by xsl:apply-templates at file:///C:/docbook/docbook-xslTNG-1.4.0/xslt/docbook.xsl#68      invoked by xsl:for-each at file:///C:/docbook/docbook-xslTNG-1.4.0/xslt/docbook.xsl#66   In template rule with match="/" on line 37 of docbook.xsl The root of the tree containing the context item is not a document node
Without knowing all too much of what to do about it, I looked at the difference in the docbook.xsl file between 1.3.1 and 1.4.0.  I commented out lines 93 to 95.
<xsl:when test="not(/h:html)">  <xsl:sequence select="."/>  </xsl:when>
Then I re-ran my scripts and everything is working fine now.   This could be an issue on my end or with my docbook XML file, but I figured I'd post it here as an issue only because everything was working fine when I was using 1.3.1.
Thank you again for the style sheets!

Is there any chance you can provide a sample document that demonstrates this?


Using send vs pcap_sendpacket

Hi,
I just have a question regarding the code. Could you please tell me why you've used send instead of using pcap's pcap_sendpacket?
https://github.com/cmouse/ip-sla-responder/blob/3b6695973ce839fda4ac6206372d7364ffab85d6/main.c#L29

Got it, thanks for the quick response! :+1:


feature: support nginx proxy_next_upstream directive

Issue description
used to forward to the next one when the backend server is unavailable

Hi @Donghui0
Please see if this can solve your problem?
see retries option.


is not working in ue 5.3.1

i see the logo of wakatime and i have the correct api key, but is not working

also, is not compile the plugin.. i need to use it like a project plugin

When you copy the API code from the website, it's in the format waka_[api_key]. Could you please ensure, that you are only pasting in the api key, without the waka_ prefix?
As far as compilation when it comes to editor/project plugin, I am not sure what could be wrong there. Since I do not have UE5 installed, I am unable to check at this point.

hi, i use waka_[api_key] format with waka_ prefix.

When you copy the API code from the website, it's in the format waka_[api_key]. Could you please ensure, that you are only pasting in the api key, without the waka_ prefix?
As far as compilation when it comes to editor/project plugin, I am not sure what could be wrong there. Since I do not have UE5 installed, I am unable to check at this point.


Fix SDPA context manager perf regression

Funnily enough this also improved the perf baseline on H100 for 2.5 to match 2.4. The main problem was the old context manager was not using the math backend which is faster at small batch sizes
Basically the old context manager you'd need to set backends you don't want, so when a new backend gets added like cudnn the behavior changes
Side benefit: no more warning spews for the deprecated API and the uninstalled backends
(warn<EMAIL_ADDRESS>~/tinygemm]$ python t.py
Loading checkpoint shards: 100%|███████| 2/2 [00:01<00:00,  1.94it/s]
100%|█████████████████████████████| 131/131 [00:00<00:00, 189.94it/s]
100%|██████████████████████████████| 225/225 [00:25<00:00,  8.86it/s]
 84%|█████████████████████████▎    | 844/999 [00:23<00:04, 36.25it/s]
  6%|█▋                            | 57/999 [00:00<00:08, 107.56it/s]
 85%|████████████████████████▌    | 846/999 [00:03<00:00, 257.36it/s]
 63%|██████████████████▎          | 630/999 [00:02<00:01, 257.03it/s]
 16%|████▌                        | 157/999 [00:00<00:03, 255.79it/s]
100%|████████████████████████████▉| 996/999 [00:03<00:00, 257.29it/s]
(warn<EMAIL_ADDRESS>~/tinygemm]$

Thank you Mark, works great!


[ANDROID] - Notifications do not trigger onForegroundEvent

Notifications do not trigger onForegroundEvent (Android)
I did several tests, I do not understand how to solve it.
In my project I am using iterable, firebase messaging and notifee.
the question is that when a new notification arrives from iterable I receive it from firebase and it is shown automatically.
In android when I press that notification with the app open, nothing happens, no notifee event is executed where I can give an action in the code, the opposite happens in IOs, if the onForegroundEvent function of notifee is executed.
How can I implement an onPress in android, or how can I solve the problem?
I don't know if this issue should go here or in another of the packages I mentioned.
I am going to show the versions of the libraries and how I implemented it.
    "@iterable/react-native-sdk": "1.3.17",
    "@notifee/react-native": "7.8.2",
    "@react-native-firebase/analytics": "18.7.3",
    "@react-native-firebase/app": "18.7.3",
    "@react-native-firebase/crashlytics": "18.7.3",
    "@react-native-firebase/dynamic-links": "18.7.3",
    "@react-native-firebase/messaging": "18.7.3",
    "@react-native-firebase/perf": "18.7.3",
    "@react-native-firebase/remote-config": "18.7.3"

// Firebase notification events setup
  FirebaseMessaging().setBackgroundMessageHandler(handleRemoteNotification);
  FirebaseMessaging().onMessage(handleRemoteNotification);
  FirebaseMessaging().onTokenRefresh(updatePushNotificationToken);
  FirebaseMessaging().setAutoInitEnabled(true);

// Push android notifications setup
  await notifee.createChannel({
    ...channel,
    vibration: true,
    importance: AndroidImportance.HIGH,
    sound: 'default',
  });

 // Handle onNotificationPress while the app is running
  notifee.onForegroundEvent(({ type, detail }) => {
    console.log('\n\n', '# foreground', type, '\n\n');
    if (!detail.notification) return;

    switch (type) {
      case EventType.PRESS:
      case EventType.ACTION_PRESS:
        handlePushNotificationPressed(detail.notification);
    }
  });

  // Handle onNotificationPress while the app is closed
  notifee.onBackgroundEvent(async ({ type, detail }) => {
    console.log('\n\n', '# background', type, '\n\n');

    if (!detail.notification) return;

    switch (type) {
      case EventType.PRESS:
      case EventType.ACTION_PRESS: {
        handlePushNotificationPressed(detail.notification);

        // Remove the notification
        if (detail.notification?.id) {
          await notifee.cancelNotification(detail.notification.id);
        }
      }
    }
  });

   // Iterable setup
   const config = new IterableConfig();
  config.autoPushRegistration = true;

  const initialized = await Iterable?.initialize(
        env.iterableApiKey,
        config,
      );

    Iterable?.setEmail(user);

the code looks too simple, it is worth noting that when I receive an event from firebase and the notification is iterable I do not show it a second time with notifee

EDIT 1:
to explain a little bit about the execution flow

I send a notification from iterable with the app open but in the background.
Firebase catches it and executes onMessage or the callback of setBackgroundMessageHandler
As it is a notification from iterable, I don't execute any action with Notifee, otherwise it would be duplicated.
Then if I press that notification, it opens the application but nothing happens, no Notifee event is executed.

I was testing and the difference I can find between this notification and the one I launch from notifee is the channelID, which is the firebase default, although I don't think it has any relevance fcm_fallback_notification_channel

having same issue

I have the same issue

Any update on this? :(

This might help. On Android, remote notifications are handled a bit differently. If Iterable or FirebaseService is displaying the notification then they will receive the onPress events. You will have either hook into Iterable or FirebaseService to know which action was pressed. I know Iterable has a couple of handlers that will be called when you send the notifications through Iterable on Android.

Thanks @susonthapa for the notification event guide. That was helpful. I have mixed implementation of push notification using Amazon SNS where iOS uses APN directly and Android uses FCM.


Native federation: proxyConfig ignored when using @angular-architects/native-federation:build

It seems like using @angular-architects/native-federation:build on serve section of angular.json doesn't allow for any proxy configuration. I have tried applying a proxyConfig option in both architect.serve.options object and architect.serve.configurations.development, both seem to get ignored:
"serve": {
          "builder": "@angular-architects/native-federation:build",
          "options": {
            "target": "proxy-test:esbuild:development",
            "rebuildDelay": 0,
            "dev": true,
            "port": 4200,
            "proxyConfig": "src/proxy.conf.json"
          },
          "configurations": {
            "production": {
              "buildTarget": "proxy-test:build:production"
            },
            "development": {
              "buildTarget": "proxy-test:build:development",
              "proxyConfig": "src/proxy.conf.json"
            }
          },
          "defaultConfiguration": "development"
},

The steps to a minimal reproduction:
Create a new app:
ng g proxy-test
Add a proxy config to src/proxy.conf.json:
{
  "/mycdn": {
    "target": "https://github.githubassets.com/assets/",
    "secure": false,
    "pathRewrite": {
      "^/mycdn": ""
    },
    "changeOrigin": true
  }
}

Add a proxyConfig entry in angular.json:
"serve-original": {
          "builder": "@angular-devkit/build-angular:dev-server",
          "configurations": {
            "production": {
              "buildTarget": "proxy-test:build:production"
            },
            "development": {
              "buildTarget": "proxy-test:build:development",
              "proxyConfig": "src/proxy.conf.json"
            }
          },
          "defaultConfiguration": "development"
}

Use an image tag to trigger the proxy:
<img src="mycdn/GitHub-Mark-ea2971cee799.png" alt="">
and ng serve works as expected, proxying to the provided url.
Now initiate native federation:
npm i @angular-architects/native-federation -D
ng g @angular-architects/native-federation:init --project proxy-test --port 4200 --type dynamic-host
(Also, remove any mfe entries from manifest.json)
The serve section of angular.json should be similar to this:
"serve": {
          "builder": "@angular-architects/native-federation:build",
          "options": {
            "target": "proxy-test:esbuild:development",
            "rebuildDelay": 0,
            "dev": true,
            "port": 4200
          }
},

Applying a proxyConfig in the newly created serve section seems to just get ignored:
"serve": {
          "builder": "@angular-architects/native-federation:build",
          "options": {
            "target": "proxy-test:esbuild:development",
            "rebuildDelay": 0,
            "dev": true,
            "port": 4200,
            "proxyConfig": "src/proxy.conf.json"
          },
          "configurations": {
            "production": {
              "buildTarget": "proxy-test:build:production"
            },
            "development": {
              "buildTarget": "proxy-test:build:development",
              "proxyConfig": "src/proxy.conf.json"
            }
          },
          "defaultConfiguration": "development"
 },

see #394

Thanks @MaGnaL , missed that!

You're welcome.
I'm also looking forward to it.

Hello
I'm still having this problem. I'm working with angular 18.1.0 and native-federation 18.0.2


[Feature request]: Info and preview images side by side

As in the title. I would love to see an option to have the info text on the left and the preview images on the right of the screen.
It's a PITA to have to resize the text field, just to either read the text or to view the previews.
It should be possible to display split like the model dropdown and the filter box.

Many thanks for this quick change. 👍


Fix typo in composer.json

Noticed a trailing comma when trying to execute composer install.

Awesome thanks!


Improve ui of card and add more information about weather such as icons

Resolves #14
@irsayvid  resolved the city not found part and improved ui of card
@siddhi-244  added more weather info with icons and improved ui of card.
Please, go through these steps before you submit a PR.

[x] My Pod Leader knows I'm working on this Pull Request
[x] I've explained what the Pull Request is adding.
[x] I've explained why this is important.

@akshitadixit we have fixed the deploy issue. Could you redeploy or refresh it !

The UI seems quite nice. Great work 🚀


Broadlink Sensor - switch to connection-less mode

Solved the issue with broadlink sensor that occurs when short connection loss with RM2/3 is present on poor WiFi networks.
Description:
Related issue (if applicable): fixes #11795
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @Paxy,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

You still have some style issue: https://travis-ci.org/home-assistant/home-assistant/jobs/363810768
I do not think this is a good idea.
You make a new connection for every update and never close it.
You should only make a new connection when necessary, and make sure the old one is closed.

Don't see any disconnect() function, or socket close available from python-broadlink.
I had a connection-less setup running on my HA for 10 days without a single freeze, unlike to current version witch freeze every night. I have tried to catch the exception when the freeze occurs last troubleshooting attempt but without success. This fixes the issue.

Why is it overkill? It is UDP sensor service, it transport mechanism is designed to be connection-less.

Can you check the output from check_sensors_raw() and reconnect if the result not is as expected?

The problem is, when the wireless connection is the issue (temporal) then you can not even reconnect to the device. But, once the device is reconnected, you can get a correct reading if you try to establish a connection from the start.
I can try to handle error data again, but that still froze sensor reading in my last attempt.

Testing approach to call connect() only when auth() is called.

This the variant with optimization to call connect() only when auth() as called.
Looks like it solves the issue too but avoid to reinitiate connection each update.

Could you try to only connect if auth fails?
Move connect to the line before return self._auth(retry-1)

Sure, I will test with that.

:)


Unable to use authenticated proxy:  Error: net::ERR_NO_SUPPORTED_PROXIES

I am trying to connect to a web service using an HTTP proxy. Here is what I am doing:
`    const puppeteer = require('puppeteer');
(async () => {
    const browser = await puppeteer.launch({
        headless: false,
         args: [
             '--proxy-server=http://myusername:password@zproxy.luminati.io:22225'
         ]
    });
    const page = await browser.newPage();

    await page.goto('https://www.whatismyip.com/');
    await page.screenshot({ path: 'example.png' });

    //await browser.close();
})();`

This does not work at all. I get an error saying:
 UnhandledPromiseRejectionWarning: Error: net::ERR_NO_SUPPORTED_PROXIES at https://www.whatismyip.com/
I have verified that the proxy works using it with modules like axios, requestjs. Don't know the reason, why it fails here.
I even tried setting up a .env file with a variable named HTTP_PROXY as given here, which placed in the project root looks like:
HTTP_PROXY=http://myusername:password@zproxy.luminati.io:22225
but the same result.

page.authenticate works.  see: https://blog.apify.com/how-to-make-headless-chrome-and-puppeteer-use-a-proxy-server-with-authentication-249a21a79212#5875

you should add:
await page.authenticate({ username: 'lum-customer-MyUserName' , password:'MyPassword' });
Luminati userName and password can be find at: https://luminati.io/cp/api_example
See full example:
const puppeteer = require('puppeteer');
(async () => {
const browser = await puppeteer.launch({
headless: false,
args: ['--proxy-server=zproxy.lum-superproxy.io:22225']
});
const page = await browser.newPage();
await page.authenticate({ username: 'lum-customer-MyUserName' , password:'MyPassword' });
await page.goto('https://luminati.io');
await page.screenshot({path: 'example.png'});
await browser.close();
})();

Hi,
@roipaz
Nice, but have you got the same solution for playwright + (websocket) "chrome remote" please?
Best regards,
Anthony

Has anybody discovered solution?

            await page.authenticate({
                username: 'your squid user',
                password: 'your squid password'
            });


CI is broken in 0.3.0-pre branch

Opening a dedicated issue to track progress on fixing CI in 0.3.0-pre. It's failing consistently.

I will take a look at this today.
It seems that the node-bbs-signatures fails on Linux + node 17/18 and possibly more node versions.

Do you know if these node versions are supported? If node 17/18 are not supported there's nothing we can do about it 🤷. We should just be clear to document it in that case and skip tests for bbs in node 17/18

Adding the test results I previously posted in #935 here for context:
Ubuntu
Specs

Results for Node v14.19.3

Results for Node v16.16.0

Results for Node v17.9.1

Results for Node v18.5.0

macOs (M1)
Specs

Results for Node v14.20.0

Results for Node v16.16.0

Results for Node v17.9.1

Results for Node v18.5.0

So is there any clue about what the problem could be in CI with node 17/18? For development I'm using a x86_64 machine running Arch-based Linux (kernel 5.15.60) and all vc tests are passing. Also I've created a Dockerfile to replicate AFJ's CI setup (i.e. based in ubuntu-20.04 image and installing all dependencies) and it works fine as well.


refactor workspace delegates

motivaton: SwiftPM clients now need to reverse engineer the package identity from the url
changes:

add PackageIdentity to WorkspaceDelegate::willFetchPackage
add PackageIdentity to WorkspaceDelegate::fetchingPackage
add PackageIdentity to WorkspaceDelegate::didFetchPackage
rename WorkspaceDelegate::repositoryWillUpdate to WorkspaceDelegate::willUpdateRepository and add PackageIdentity
rename WorkspaceDelegate::repositoryDidUpdate to WorkspaceDelegate::didUpdateRepository and add PackageIdentity
add PackageIdentity to WorkspaceDelegate::willCreateWorkingCopy
add PackageIdentity to WorkspaceDelegate::didCreateWorkingCopy
add PackageIdentity to WorkspaceDelegate::willCheckOut
add PackageIdentity to WorkspaceDelegate::didCheckOut
add PackageIdentity to WorkspaceDelegate::removing
remove redundant (not in use) Diagnostics argument from WorkspaceDelegate::didCreateWorkingCopy
remove redundant (not in use) Diagnostics argument from WorkspaceDelegate::didCheckOut
update call sites and test

@swift-ci please smoke test

@swift-ci please smoke test

I suspect that this will break the Windows build - you didn't update CMakeLists.txt AFAICT.


Update README.md

Hi @xiamengzhou , when I try to reproduce your code,  I found that the latest version of transformers report error when import  hf_bucket_url in transformers.file_utils. And a lower version can work

Thanks for the update!!

Sorry, when I try to reproduce the code, I found that the version of transformers is a big problem. I have tried different versions like 2.11.0, 3.4.0, 3.6.0, 4.27.1,  but every version has some packages which dont not fit the code. Which the version do you use? Can I know the version of other packages not marked clearly in requirement.txt?


Where can I obtain the pre-trained model of ResNet trained with DCLS

In your paper , I saw a result of ResNet50-dcls given besides the ConvNeXt-dcls. But I didn't find the trained model. If I need to train it by myself,Could you give the setting about it?Thank you

Hello,
Here is a link with the best checkpoint for the two resnet-dcls runs of the paper along with the configs, summary and args used at that time. We used timm and a light training config for resnet (A3-config described in this paper).
link to the checkpoints
Besides, this last checkpoints use the v0 version of DCLS that uses bilinear interpolation. We discovered that a better interpolation (Gaussian) could be used instead please refer to this paper. We encourage you, if you want to do further investigations, to retrain using this last interpolation technique. More details are provided in this short blog post along with a script to replace all your convolutions with DCLS ones (see medium story).
We abondonned the research on architectures that do not use depthwise separable convolutions because implementing a dialted kernel of size 7 and higher is prohibitive in time if we don't use  depthwise separable convolutions  along with depthwise implicit gemm method link to the code of this method and original paper. Maybe you could investigate ResNeXt or ConvNeXt (as with did in our paper) as they use depthwise separable convs.

Thank you very much， It helps a lot!!!

You're welcome,
I'm closing this issue, but feel free to reopen it if you have any questions or comments.


Module parse failed error when using it in an angular project.

Below you find the compilation error which I am getting.
./node_modules/zoomist/src/scss/index.scss:1:0 - Error: Module parse failed: Unexpected token (1:0)
File was processed with these loaders:

./node_modules/resolve-url-loader/index.js
<EMAIL_ADDRESS>You may need an additional loader to handle the result of these loaders.

.zoomist-container {
|   position: relative;
|   touch-action: none;

I solved it by adding these to angular.json
      "schematics": {
        "@schematics/angular:application": {
          "styleext": "scss",
          ...
        }
...
            "styles": [
              "node_modules/zoomist/src/scss/index.scss",
              "src/styles.scss"
            ],

Thanks a lot @exodussystem


Support for Babel 7

Bug Report or Feature Request (mark with an x)
- [x] bug report
- [x] feature request

It's kind of both :-)
Command (mark with an x)
- [ ] new
- [x] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions
Latest.
Repro steps
Related issue in my case -> https://github.com/Polymer/lit-element/issues/54
The log given by the failure
Related issue in my case -> https://github.com/Polymer/lit-element/issues/54
Desired functionality

Babel 6 has an "ancient bug" that results in not being able to use LitElement when using older targets. While LitElement may not be everyone's cup of tea, I bet there are other reasons to upgrade to Babel 7 :-).
Mention any other details that might be useful

Babel 7 Announcement (August 27, 2018) https://babeljs.io/blog/2018/08/27/7.0.0

@clydin If not babel, what is being used to transpile for older targets?


Launching Blackboard Container

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

No information provided or steps to replicate - Closing


Doc: add queue.purge to doc

The documentation doesn't mention the queue.purge method… But it works perfectly.
Thanks

+1 I was looking for this and it was really useful


WebSocket https connection with self signed certificate on Android

[x] I have reviewed the documentation
[x] I have searched existing issues
[] I am using the latest React Native version

I tried to connect using websocket to a server using https with a self signed certificate. I customized the OkHttpClient using the factory reintroduced in the 0.54 version and it works as expected for https requests but it doesn't work for websocket connection. By looking at the WebSocketModule.java I found that in the connect method the OkHttpClient is created as a default OkHttpClient instead of using the OkHttpClientProvider.createClient() method that, from 0.54 version, allow us to customize the OkHttpClient.
Environment

Environment:
OS: macOS Sierra 10.12.5
Node: 9.9.0
Yarn: 1.5.1
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 8.3.2 Build version 8E2002
Android Studio: 3.0 AI-171.4408382
Packages: (wanted => installed)
react: ^16.2.0 => 16.2.0
react-native: ^0.54.0 => 0.54.4
Steps to Reproduce

Try to establish a secure web socket connection to a web server with an https certificate by using a custom OkHttpClientFactory
Expected Behavior

Connection established
Actual Behavior

This error occur

java.security.cert.CertPathValidatorException: Trust anchor for certification path not found.

@react-native-bot Yeah, I can reproduce the issue on the latest release 0.55.4


perf(elasticsearch): Improve search and index performance

Improve search and index performance when under high indexing
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[x] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[x] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[x] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

There is a problem here. The index is going to be reindexed on a change to refresh_interval and this is not required. Need to write a new code path to apply settings without reindex when possible.

Something is not working with the smoke tests, investigating.


Essentially useless cancel button on edit subjects page

A cancel button on the edit subject page does absolutely nothing unless you are editing a subject, in which case it stops you from editing the subject. It would be best if the cancel button would only appear when editing the subject.

The cancel button clears newSubject back to its default state. So if you're adding a new subject and change your mind, cancel clears the form. Worth keeping.


DOCS Update contribution guidelines around method visibility

This is in response to the RFC discussion in #8996

Could we make it a recommendation rather than a convention? Since it hasn't been approved by the core committers, I'm not sure if we can call it a convention.

It has been... at least the RFC is marked as accepted. The script is fairly high level anyway - it's basically a recommendation in the wording.


Make the board wider, and the slots wider and flatter.

Make the board wider, and the slots wider and flatter.  I’m trying to see it all on one screen (I know screen sizes vary, but 960 wide seems fine, and the landing pad for the "trash" needs to be available without scrolling).  Better still if it can be projected on a wall for workshopping - I’ll have a play with some projectors tomorrow to see how close we come.

Via @pgreenwo


istioctl experimental upgrade does not work

Bug description
Cannot upgrade Istio from 1.4.0 to 1.4.1 via istioctl:
I downloaded new versio of istioctl and try to upgrade by running upgrade command:
$istioctl manifest versions
Operator version is 1.4.0.
The following installation package versions are recommended for use with this version of the operator:
1.4.0
The following installation package versions are supported for upgrade by this version of the operator:

=1.3.3
<1.6

$istioctl experimental upgrade -f ${overlay_file}
Client - istioctl version: 1.4.0
Error: the target version 1.4.1 is not supported by istioctl 1.4.0, please download istioctl 1.4.1 and run upgrade again
Please advise.
Expected behavior
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
istioctl version
client version: 1.4.1
control plane version: 1.4.0
data plane version: 1.4.0 (4 proxies), 1.3.2 (2 proxies)
How was Istio installed?
istioctl manifest apply -f ${overlay_file}
Environment where bug was observed (cloud vendor, OS, etc)
AWS

I will debug this today. thanks.

any updates on this? currently we are in confusing situation since helm method will be deprecated so I chose istioctl method but now stuck because upgrade fails!
upgrade with istioctl fails from 1.4.0 --> 1.4.1 as well as 1.4.2

I believe you can still upgrade using --force. Could you verify that this works @elfinhe ? We need some kind of workaround asap for 1.4.2, even if this is fixed in 1.4.3.

upgrade works with --force option, thx for the workaround

I double checked that --force will work. working on a PR(https://github.com/istio/operator/pull/677) to fix this with forward compatibility.


fix(builder): Watch for pages/ creation when default page displayed

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Same as store/ but applied for pages/ creation.
TODO: Update tests
Checklist:

[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

Codecov Report

Merging #5753 into dev will decrease coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             dev    #5753      +/-   ##
=========================================
- Coverage   95.6%   95.57%   -0.04%
=========================================
  Files         82       82
  Lines       2662     2664       +2
  Branches     683      684       +1
=========================================
+ Hits        2545     2546       +1
- Misses        98       99       +1
  Partials      19       19

Impacted Files
Coverage Δ

packages/builder/src/builder.js
99.6% <66.66%> (-0.4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f391e5d...8c0d481. Read the comment docs.


Jazzer documentation

I have a question, where can I find the documentation about the arguments that the jazzer program can take?

First of all, Jazzer accepts all arguments that libFuzzer accepts (those starting with a single dash).
The arguments it supports on top of that are mostly explained in the README or used in the examples (https://github.com/CodeIntelligenceTesting/jazzer/blob/main/examples/BUILD.bazel). All arguments can be obtained by running Jazzer with the --help argument.
Let me know if you have questions about a particular argument and I will see whether I can add documentation.

Thanks for the answer.


[openimageio] Update to version <IP_ADDRESS>

Describe the pull request

What does your PR fix? Fixes #11762
Update openimageio to version <IP_ADDRESS> and fix old patches.
All features test pass on triplet x64-windows.
Which triplets are supported/not supported? Have you updated the CI baseline?
No
Does your PR follow the maintainer guide?
Yes

/azp run

Thanks Lily!


Make components headless for Close-button component

Description
Migrate styles from components to themes.
Since component styles in themes inherit styles from other components using mergeStyle etc., duplicate styles should be removed.
Problem Statement/Justification
Move static styles from close-button component to theme.
Proposed Solution or API
No response
Alternatives
No response
Are you willing to participate in implementing this feature and create a pull request include the implementation?
Yes
Additional Information
No response

Closed due to no migration required.


Add FlightSQL support

Which issue does this PR close?
Closes #92.
Rationale for this change
To use off the shelf tools with Ballista.
What changes are included in this PR?
A minimal FlightSQL service implementation.
Are there any user-facing changes?
They should be able to connect with off-the-shelf tools, given they have correctly installed and configured the FlightSQL JDBC or ODBC drivers.

I was able to retrieve query results from some custom Kotlin JDBC client code I'll post shortly:
[Test worker] INFO FlightSqlStatement - Execute SQL: SELECT 'keep alive'
[Test worker] INFO FlightSqlStatement - Got response: keep alive

Working via custom JDBC driver in DataGrip:

The official JDBC driver needs prepared statement support in order to work:

> select 'Hello, Apache Arrow Ballista2!'
[2022-07-24 17:33:31] Error while executing SQL "select 'Hello, Apache Arrow Ballista2!'": Implement do_action_create_prepared_statement
[2022-07-24 17:33:31] UNIMPLEMENTED: Implement do_action_create_prepared_statement

Also, it is necessary to set settings to:

no authentication
useEncryption=false

I think the remaining problems I'm having with prepared statements are actually do to the implementation of the JDBC driver, as described here: https://github.com/apache/arrow/pull/12830/files#r929303757

I'm undrafting this because it doesn't break anything and works against https://github.com/rafael-telles/arrow/pull/42 and now the code is a little cleaner. I'll probably keep improving it based on the feedback above, but that stuff could probably happen after merge.


a11y issues with Vega visualizations

[ ] Explore relationships between x and y in z	SR	[A11Y - Health Equity Tracker]: Graphs under Explore relationships page don't have a proper label_Web_1.1	"ENVIRONMENT:
macOS 11.3 | Chrome Version 90.0.4430.212 (Official Build) (x86_64) | Voiceover
Chrome OS Version 91.0.4472.60 (Official Build) beta (64-bit) | Chromevox
PRE REQUISITES:
Turn on the respective screen reader
STEPS TO REPRODUCE:
1). Open https://healthequitytracker.org/exploredata
2). Perform action on next button to reach the final sub page
3). Verify the options are selected as such, the page is 'Explore relationships between Diabetes and Covid-19 in United States.
4). Navigate to population profile card and expand the card
5). Linear navigate to the graphs under profile card
6). Observe the announcement.
EXPECTED RESULT:
Graphs on a page should have a label and they should be announced properly by screen reader.
OBSERVED RESULT:
Graphs (Population by race & Population by age) under population profile card don't have a label. Screen reader announces the graphs as Vega visualization visualization. Upon further navigation in mac, voiceover announces the graphs as unlabeled image.
Same issue is replicable across all graphs on the page.
Replication video attached"	https://drive.google.com/file/d/1X2WO3NmIkV9aUSzL0hTwJHAeJ-j1yB2q/view?usp=sharing	Same issue is observed on Compare rates page.

[ ] Explore relationships between x and y in z	SR	[A11Y - Health Equity Tracker]: Maps under Explore relationships page don't have a proper label_Web_1.1	"ENVIRONMENT:
macOS 11.3 | Chrome Version 90.0.4430.212 (Official Build) (x86_64) | Voiceover
Chrome OS Version 91.0.4472.60 (Official Build) beta (64-bit) | Chromevox
PRE REQUISITES:
Turn on the respective screen reader
STEPS TO REPRODUCE:
1). Open https://healthequitytracker.org/exploredata
2). Perform action on next button to reach the final sub page
3). Verify the options are selected as such, the page is 'Explore relationships between Diabetes and Covid-19 in United States.
4). Navigate through the page
5). Observe the announcement.
EXPECTED RESULT:
Maps on the page should have a label and they should be announced properly by screen reader.
OBSERVED RESULT:
Maps on the page don't have a proper label. Screen reader announces all the maps in the page as choropleth map. Upon further navigation in mac, voiceover announces the maps as unlabeled image.
Replication video attached"	https://drive.google.com/file/d/1FQ9sE5gnnIWl4aUj66_KmnX1uPOT9uB4/view?usp=sharing	Same issue is observed on Compare rates page.

[ ] Explore relationships between x and y in z	Screen Reader		[A11Y - Health Equity Tracker]: User unable to reach graphs on the page using talkback_mweb_1.2 (a)	"Device: Pixel 4
Android Version: 11
Chrome Browser Version: 91.0.4472.101
PRE REQUISITES:
Turn on Talkback (Settings > Accessibility > Talkback)
STEPS TO REPRODUCE:
1). Open https://healthequitytracker.org/exploredata
2). Linear navigate to next button and double tap till you reach the final sub page
3). Verify the options are selected as such, the page is 'Explore relationships between Diabetes and Covid-19 in United States.
4). Linear navigate profile card expand button and double tap
5). Linear navigate to graphs under profile card
6). Observe the behavior.
EXPECTED RESULT:
User should be able to reach all elements in a page using linear navigation
OBSERVED RESULT:
User is unable to reach the graphs under profile card using talkback, screen reader skips the graphs in the page. User won't have any idea that the page has graphs
Replication video - https://drive.google.com/file/d/1mYELr_rZ_vyuMjqiH2n49Brex66UzlWX/view?usp=sharing"

[ ] Explore relationships between x and y in z	Screen Reader		[A11Y - Health Equity Tracker]: User unable to reach maps on the page using talkback_mweb_1.2 (a)	"Device: Pixel 4
Android Version: 11
Chrome Browser Version: 91.0.4472.101
PRE REQUISITES:
Turn on Talkback (Settings > Accessibility > Talkback)
STEPS TO REPRODUCE:
1). Open https://healthequitytracker.org/exploredata
2). Linear navigate to next button and double tap till you reach the final sub page
3). Verify the options are selected as such, the page is 'Explore relationships between Diabetes and Covid-19 in United States.
4). Linear navigate to the maps on the page
5). Observe the behavior.
EXPECTED RESULT:
User should be able to reach all elements in a page using linear navigation
OBSERVED RESULT:
User is unable to reach the maps on the page using talkback, screen reader skips the maps. User won't have any idea that the page has maps
Replication video - https://drive.google.com/file/d/1e7o8LpYzP5L6LQXaEGbyh-4UdV8i141_/view?usp=sharing"

http://vis.csail.mit.edu/pubs/vis-text-model/
“This is a [chart-type] entitled [chart-title]. [y-encoding] is plotted on the vertical y-axis from [y-min] to [y-max]. [x-encoding] is plotted on the horizontal x-axis from [x-min] to [x-max].”

“I am totally blind, and virtually all data visualizations I encounter are undescribed, and as such are unavailable. This has been acutely made clear on Twitter and in newspapers around the COVID-19 pandemic and the recent U.S. election. Often, visualizations are presented with very little introduction or coinciding text. I feel very left out of the world and left out of the ability to confidently traverse that world. The more data I am unable to access, the more vulnerable and devalued I feel.”

A majority of blind readers (63%, n=19) were emphatic that descriptions should not contain an author’s subjective interpretations, contextual information, or editorializing about the visualized data (i.e., Level 4 content). Consistent with blind readers ranking this as among the least useful (Region 4.B), BR20 succinctly articulated a common sentiment: > “I want the information to be simply laid out, not peppered with subjective commentary… I just prefer it to be straight facts, not presumptions or guesstimates.”

https://medium.com/nightingale/writing-alt-text-for-data-visualization-2a218ef43f81
Here’s a simple formula for writing alt text for data visualization:

alt= “Chart type of type of data where reason for including chart”
Include a link to data source somewhere in the text

https://www.wgbh.org/foundation/ncam/guidelines/line-graphs


1.21.1 render crash with Xycraft + Stellaris

I'm running
mc: 1.21.1
Neoforge: 21.1.22
JEI: jei-1.21.1-neoforge-<IP_ADDRESS>
EMI: emi-1.1.11+1.21+neoforge
Stellaris: stellaris-1.21-neoforge-1.0.5
Xycraft: xycraft_core-0.7.45-all
xycraft_machines-0.7.45
xycraft_world-0.7.45
So what happens is when you search for oil in EMI the game crashes. If I remove stellaris it's fine but I dont have any other mods that add a liquid to know if its related to stellaris at all (I suspect not as we've had a similar crash searching for tritium with mekanism in the pack). Adding the xycraft mods along with EMi causes the crash to occur. Without Xycraft the crash doesnt occur and using JEI alone without EMI will cause the crash not to occur.
Here is the crashlog, I'm really unsure which mod is at fault here so if I need to open this issue with one of the other developers let me know. Thank you!
https://mclo.gs/NlmXqzM

This is a Stellaris (and likely an Architectury) bug:

A fluid texture SHOULD be present as per the documentation.

No problem! :) I was mostly thinking "I don't think either XyCraft or Emi have an issue with each other at the moment, it just has some quirks in regards to needing JEI currently" (Waiting on Gander before reimplementing any integrations at least)


[NEW ALGORITHM]  Deadlock Detection using Resource Allocation Graph

Issue will be closed if:

You mention more than one algorithm. You can create a separate issue for each algorithm once the current one is completed.
You propose an algorithm that is already present or has been mentioned in a previous issue.
You create a new issue without completing your previous issue.

Note: These actions will be taken seriously. Failure to follow the guidelines may result in the immediate closure of your issue.

Name:
Deadlock Detection using Resource Allocation Graph
About:
Deadlock detection in computer systems can be efficiently managed using a Resource Allocation Graph (RAG). In RAG, nodes represent processes and resources, with directed edges indicating the request and allocation of resources. If a process requests a resource, a directed edge is drawn from the process node to the resource node; if the resource is allocated, the edge goes from the resource to the process. Deadlocks occur when there's a cycle in this graph, meaning a circular dependency among processes and resources, which prevents processes from proceeding. By regularly analyzing the RAG for cycles, systems can detect deadlocks

Labels:
new algorithm, gssoc-ext, hacktoberfest, level1

Assignees:

[x] Contributor in GSSoC-ext
[x] Want to work on it

Additional Information
Please assign me this issue @pankaj-bind

assigned


Internal Data Backup Question

@WPringle @zacharyburnett we're losing access to some resources on Hera sometime soon, so I was wondering if you remember if there are any files there that I need to backup related to ensembleperturbation or in general the paper you wrote on the probabilistic modeling approach?

I don't believe so.. I had many of my files on Argonne machine and also uploaded to Zenodo

OK, so I'll close this issue, thanks!


Create aloberlin

please add anne-dore-leber-vocational  school

add

@Yousefi313 lib/domains/berlin/aloberlin: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@Yousefi313 I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host aloberlin.berlin not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


docs/basic instructions

docs: Add topics and setup instructions to README
docs(env): Add example .env file
ci(CODEOWNERS): assign us

@julizet  you have maintainer rights now

@all-contributors please add @julizet  for review


Can't Build RaspberryPi2/3 UEFI for Release

I actually posted an issue in the RPi-UEFI repo (https://github.com/ms-iot/RPi-UEFI/issues/20) but noticed that the repo said to post issues here. So I've just linked to my issue posted in the other repo in the url above.

I got a solution in the other repo.


fix the fuzzparams function with the -fuzz flag

I have been encountering errors during the fuzzing stage of parameters with Nuclei. Upon reviewing the documentation, I realized that it now requires a parameter to enable fuzzing mode. After making adjustments locally, I was successful.
Doc Nuclei:
-fuzz                      enable loading fuzzing templates

@six2dez he fixed it , i think it can be merged


release: Release shim 3.0.0-beta.2

Update release version according to new Clear Containers release.
Fixes: #63
Signed-off-by: Jose Carlos Venegas Munoz<EMAIL_ADDRESS>

lgtm


[Metal] Argument buffers as descriptor sets

With #1370 I started implementing the idea of using indirect argument buffers in place of descriptor sets on Metal2. The goal is to have descriptor sets behaving more natively, and binding done quickly.
The management of descriptor sets maps to argument buffers nicely, and this is implemented in the WIP PR. However, I'm having troubles actually hooking it up to the binding side.
When a descriptor set is asked to be bound, the backend needs to know if it's just a specific buffer binding point (for indirect arguments), or it needs to unwrap the descriptor set and bind all the contained descriptors individually (Metal1 style). Shader reflection knows about that (and hence, PSO), but we bind descriptor sets independent of the PSOs, so we can only rely on the PipelineLayout to know this information.
PipelineLayout is backend-specific, but it's created from a list of DescriptorSetLayout, which are standard. It appears that we need to add DescriptorType::ArgumentBuffer to the type enumeration, even though it's going to be ignored by all backends but Metal-2, which sounds quite unfortunate. And for the latter, we'll need some clever logic in the metal::Factory::create_pipeline_layout that would understand how those argument buffers should be mapped to the other descriptor sets...
@msiglreith @JohnColanduoni - any ideas?

Here is the solution we came up with, now implemented in #1370:

have a compile time feature that forces all descriptor sets to be treated as argument buffers
descriptor set range then becomes the buffer binding range, and can technically conflict with vertex buffers (containing attributes). It's currently the user's responsibility to avoid such conflict.


lidl parkside water machine does not show up as new devices

Adding lidl parkside water valve to zigbee2mqtt is ok. It shows up in domoticz plug in. adding new devices is on. but there are no new devices
Additional information
Zigbee2MQTT version: 1.23
Python version:

Domoticz version: 2022.1 build 141
Plugin version: 3.1 beta
Logs
Attach any additional logs here which might be useful: mqtt, domoticz, plugin logs
2022-08-29 11:11:57.012 Error: Zigbee2MQTT: 0x847127fffed814fa: can not process numeric item "timer"
2022-08-29 11:12:21.822 Error: Zigbee2MQTT: parkside water: can not process numeric item "timer"
2022-08-29 11:20:27.434 Error: Zigbee2MQTT: parkside water: can not process numeric item "timer"
{
"domoticz": {
"device_id": "0x847127fffed814fa",
"legacy_alias": "state",
"unit": 1
},
"zigbee": {
"address": "0x847127fffed814fa",
"endpoint": "n/a",
"feature": "state"
}
},
{
"domoticz": {
"device_id": "0x847127fffed814fa",
"legacy_alias": "signal",
"unit": 2
},
"zigbee": {
"address": "0x847127fffed814fa",
"endpoint": "n/a",
"feature": "linkquality"
}
}
]
}

delete the parkside and the two not working devices, removed the parkside from the zigbee configuration file, and finaly paired again. now we have 4 usefull devices in domoticz

however the timer settings of the parkside must be done with the front end of the zigbee2mqtt, see

picture


Habib/yellow lab font

Changes:

...

Type of change

[ ] Bug fix
[ ] New feature
[ ] Update feature
[ ] Refactor code
[ ] Translation to code
[ ] Translation to crowdin
[ ] Script configuration
[ ] Improve performance
[ ] Style only
[ ] Dependency update
[ ] Documentation update
[ ] Release

nice optimization


property 'maximumRecordDuration' is not available to IQAudioRecorderController in Swift

I am using this library in my Swift 2.2-based app, and it works beautifully, however, I found the property maximumRecordDuration is not available for an instance of IQAudioRecorderController to use.
I am wondering if it is possible to use maximumRecordDuration for Swift-based app. Thanks!

I don't think it should be an issue and it should work fine. Don't know why you are getting issues.

@hackiftekhar thanks for the reply.
In my briding header file, I imported this library as:
#import <IQAudioRecorderController/IQAudioRecorderController.h>

When I create an instance of IQAudioRecorderController in my Swift-based view controller, I cannot add maximumRecordDuration property to this instance. Is my way of importing this library wrong? thanks

@rcholic you need to use the github version instead the one from cocoapods.
pod 'IQAudioRecorderController', git: 'https://github.com/hackiftekhar/IQAudioRecorderController'

@hackiftekhar probably a good idea to update the version on github pretty soon?

I'm planning to update it soon. Thanks @siong1987

@siong1987 thanks for the info, but I've created basically a clone project of this at here https://github.com/rcholic/SwiftySoundRecorder  (or pod install SwiftySoundRecorder, my library pretty much does the same thing, but readily allows using maxDuration for recording, and it is in Swift 2.2.
If I knew the trick of installing this library by the git commit, I wouldn't have spent time writing up my own copy of the library :)

Updated CocoaPods


fixes for windows

enable npm test in window systems
enable npm link after run on bootstrap-compiler
add some doc how to build the github version

Should the .vscode file really be in there? I think that we shouldn't commit IDE configuration files to the repo since every developer has their own configuration.

lets get this merged and the deployment running again, and sort out any details later?


FromExtendedSchema fails to compile

PR#130 introduced FromExtendedSchema
when installing version 2.8.0 and trying to build my project I was getting the following error:
node_modules/json-schema-to-ts/lib/types/index.d.ts:16:314 - error TS2590: Expression produces a union type that is too complex to represent.
16 export declare type FromExtendedSchema<E extends JSONSchema7Extension, S extends ExtendedJSONSchema<E>, Opt extends FromExtendedSchemaOptions<E> = FromSchemaDefaultOptions, W extends $ExtendedJSONSchema7<E> = Cast<S extends Record<string | number | symbol, unknown> ? Writable<S> : S, $ExtendedJSONSchema7<E>>> = FromSchema<Cast<UnextendJSONSchema7<E, W>, JSONSchema>, Opt>;

I was using typescript 5 as it wasn't supposed to mess with anything on my side but seems like it doesn't like this new type

this is very critical as any sub-dependency that uses this, upon update fails to build.
please resolve this asap!
Thanks!

I ran into this with json-schema-to-ts 2.6.2.  It was the upgrade to TS 5.x that surfaced the compilation error.
my-repo
|- my-package
|  |- json-schema-to-ts 2.6.2
|- TS 5.0.4

Compilation in my-repo fails.

Should be fixed in 2.8.2


Filename length error when cloning the repo on windows via git bash

Checkout fails on Windows 10 machine via git bash.
fatal: cannot create directory at 'pinkerton/test/files/docker/registry/v2/repositories/pinkerton-test/_manifests/revisions/sha256/e3d939e790435a08a456e064203d1c8688342be817dc9f6a73f1d7610540122f/signatures/sha256/48f13e535c991476cdc4d2d811b83d23dbfaedd7d9c2e49d7300aa1a88ec62b8': Filename too long
warning: Clone succeeded, but checkout failed.

Those files are going to be dropped in an upcoming pull request.
In the meantime, could you perhaps try cloning into a folder with a shorter name?

clone it in the root of C:\flynn
C:\
λ git clone https://github.com/flynn/flynn
Cloning into 'flynn'...
remote: Counting objects: 41850, done.
remote: Compressing objects: 100% (23/23), done.
remote: Total 41850 (delta 9), reused 3 (delta 3), pack-reused 41824
Receiving objects: 100% (41850/41850), 24.93 MiB | 2.31 MiB/s, done.
Resolving deltas: 100% (24040/24040), done.
Checking connectivity... done.
fatal: cannot create directory at 'pinkerton/test/files/docker/registry/v2/repositories/pinkerton-test/_manifests/revisions/sha256/e3d939e790435a08a456e064203d1c8688342be817dc9f6a73f1d7610540122f/signatures/sha256/48f13e535c991476cdc4d2d811b83d23dbfaedd7d9c2e49d7300aa1a88ec62b8': Filename too long
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

@rdrsss @necenzurat I have removed those files in #3418, please let us know if you continue to have issues.

all good now.

Yep works! Thanks!


[add] css ids for toolbar

Will be easier to create custom rules to e.g. hide only one element (like mark all as read).

Thank you.


Menu bar edit menu on Method Browser missing most options (3.1pr4)

The Project Browser and the Method Browser have both Edit menu-bar menus and method pane pop-up menus.
The title bar and pop up menus for PB, and the popup menu on the MB, all look very similar.

But the MB edit menu is missing many options:

Still like this in 3.2.12


Package request: MControlCenter

Project description
This application allows one with select msi laptops to control fanspeed/battery settings/Keyboard lighting/camara toggle
This is basicly a replacement to dragon center on windows
Metadata

homepage https://github.com/dmitry-s93/MControlCenter:
source https://github.com/dmitry-s93/MControlCenter:
license: Gpl 3.0
platforms: linux

Worked a little bit on this today. It's pretty complicated due to the kernel module, dbus service, etc.

@Yvonne-Aizawa Good news! A package definition is now available:
https://github.com/dmitry-s93/MControlCenter/pull/123


Design Document for eth_subscribe and eth_unsubscribe

Signed-off-by: georgi-l95<EMAIL_ADDRESS>Description:
Adds design doc for subscription and introducing new methods - eth_subscribe and eth_unsubscribe
Related issue(s):
Fixes #861
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
Base: 74.33% // Head: 74.75% // Increases project coverage by +0.42% :tada:

Coverage data is based on head (82793cf) compared to base (419ea9f).
Patch coverage: 62.85% of modified lines in pull request are covered.

:exclamation: Current head 82793cf differs from pull request most recent head f6b6824. Consider uploading reports for the commit f6b6824 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
+ Coverage   74.33%   74.75%   +0.42%
==========================================
  Files          29       29
  Lines        1835     1838       +3
  Branches      341      344       +3
==========================================
+ Hits         1364     1374      +10
+ Misses        373      367       -6
+ Partials       98       97       -1

Impacted Files
Coverage Δ

packages/relay/src/lib/clients/sdkClient.ts
20.70% <0.00%> (-0.43%)
:arrow_down:

packages/relay/src/lib/errors/SDKClientError.ts
62.50% <0.00%> (-4.17%)
:arrow_down:

packages/relay/src/lib/eth.ts
84.74% <65.21%> (+1.84%)
:arrow_up:

packages/relay/src/lib/clients/mirrorNodeClient.ts
94.42% <100.00%> (+0.09%)
:arrow_up:

packages/relay/src/lib/errors/JsonRpcError.ts
72.72% <100.00%> (+2.72%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Has any consideration been given to the idea of isolating this functionality in it's own process/pod so that any issues with websockets in particular do not affect the functionality of the rest of the json rpc relay?

Has any consideration been given to the idea of isolating this functionality in it's own process/pod so that any issues with websockets in particular do not affect the functionality of the rest of the json rpc relay?
If we reject this idea then let's call out the explicit considered but rejected idea.

I haven't considered that idea, but it does make sense. The websocket connection will need to listen on a separate port. And if it runs in a different process then the logs would be easier to read and manage.
Another option is to just have a feature flag that enables the whole socket logic.

As per our conversation we should include on the design/HIP the metrics we would like to capture for this feature:

How many eth_subscribe and eth_unsubscribe do we get.
How long subscriptions stay alive/open
How many request de we perform to the mirror node for subscriptions
How many logs do we process/consume from the mirror node for subscriptions

@Ivo-Yankov
cc: @Nana-EC @georgi-l95 @ebadiere
This are the offered metrics of eth_getLogs
Mainnet:
Last 24 hrs: 55,464 requests
Last 48 hrs: 114,064 requests
Last 7 Days:
Mean: 58,985
Min: 56,907
Max: 61,742

Last 30 days:

This graph only shows that we don't have enough historical data to accurately predict the actual usage of the feature, taking into consideration the pushes for more adoption and unexpected waves of growth that could happen in the next couple months.
Last 24 hrs, as relative percentage of total requests:


Re-arrange buttons by logical clusters

Can you give an explanation of what this would change?

@BasThomas this will change the look of the app, and make the elements belong to corresponding cluster of elements. The PR is already there: #120
New look:


Output to stdout in addition to a log file

When chef is configured to use a log file then minitest (correctly) writes its output to the same file, but the output is then missing from stdout. This commit ensures minitest outputs to both locations when appropriate
The bit of code that detects if chef is logging to stdout is hideous, there must be a better way of doing this but my ruby/chef foo is limited :(
Fixes #75

This solution is really kind of terrible.  We seem to have a bug in Chef core where we used to log both to the logfile and stdout if we detected a tty.  If solving that problem would also solve this problem, that is by far the better solution.  The major surgery to Chef::Log here is only going to cause headaches in the future.


Removal of Pure Pursuit in favour of RoadRunner path following

https://rr.brott.dev/docs/v1-0/guides/path-following/
https://github.com/acmerobotics/road-runner-quickstart/issues/338
Base implementation of the path follower that we used in rr 0.5 is effectively the same as the path follower approach in 1.0, so it would be nice to migrate over to centralise and to improve

Base implemented, will make non-urgent improvements over time to it (new base impl is probably better than the old PP ever was anyways)


Idemix MSP Folder Structure incompatible with what Fabric expects

Currently, Fabric-CA generates an Idemix MSP folder structure and file content that Fabric is not able to load.
Namely:

The content of SignerConfig is encoded in json, Fabric expected proto
Fabric expects the revocation public key to be stored in a file named RevocationPublicKey and IdemixRevocationPublicKey.

This git issue is to fix the above issues.

Why was this change reverted?

Why was this change reverted?

It broke the Java client SDK.

Is anyone using the Idemix provided by Java client SDK's ? If no, I would suggest to drop it. No one is going to keep supporting that implementation.

Yes, people are using it. We already encourage people to use the Fabric Gateway client API instead of the legacy Java SDK, and plan to deprecate the legacy Java SDK once Fabric v2.5 LTS is released. Certainly for Fabric v3 we can break compatibility with the v2.x Idemix implementation.
Producing a new release (v2) of the CA without support for the old style Idemix to go along with Fabric v3 sounds perfectly reasonable. Breaking compatibility with existing client applications or removing capability in a patch release (or even a minor version release) does not seem reasonable.

But Gateway does not support Idemix yet, how are people using idemix moving there?

The identity credentials and signing implementation are pluggable in the Fabric Gateway client API. Anyone could use the Idemix implementation from the legacy Java SDK with the new client API. I suspect nobody has done that - certainly not that I've seen - and there is currently no Idemix signing implementation provided out-of-the-box with the Fabric Gateway client API so I don't think anyone is using Idemix with that client API.
I really don't understand how that impacts whether it's OK to make breaking changes to the CA in patch releases.


Deletion warning

To lessen the chance of a ChEBI entry being
accidentally deleted (as happened recently), we need a
warning message to be displayed whenever the status of
a compound is changed to DELETED. Something along the
lines of "Do you really want to delete this entry?"
might be appropriate.
Reported by: mennis

thanks www.movied.org


System crash when executing workflow

Recently my system got crashed when running your "txt2img - 48 frame animation with 16 context_length (uniform)," workflow but succedded run two of your beggining shared workflows! I had tried to disable xformers but still not solved this problem. Any workaround will be appreciated!

Can you provde details about what you mean by "system crash"? Did comfy crash or your whole computer? What hardware are you running? Can you pull up your taskmanager and monitor your VRAM usage while it runs? Thanks!

Thanks for your reply, what I mean by system crashed is my windows os
shutted down while executing running in progress about 30 percents. This
process consum all my vram upto 8 gb and eat a little bit my shared vram
about 0.5 gb but i have much shared vram upto 24 gb, i saw my utilization
of cpu, memory, and disk are not in heavy utilized but suddently my system
got crashed but I can not figure it out and no resume option in your
workflow so this process is totaly failed.
On Fri, Oct 6, 2023, 13:41 Jedrzej Kosinski @.***>
wrote:

Can you provde details about what you mean by "system crash"? Did comfy
crash or your whole computer? What hardware are you running? Can you pull
up your taskmanager and monitor your VRAM usage while it runs? Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/Kosinkadink/ComfyUI-AnimateDiff-Evolved/issues/69#issuecomment-1750063136,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDCQWGRYCYO7SQXQNMQS5VDX56RYXAVCNFSM6AAAAAA5VJ7WQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGA3DGMJTGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

I rerun it again, this is task manager image for this process.

Got succedded after i rerun it, why ai python consume so much energy and resources but i am very appreciated your work to make this node on comfyui because more hope to be succeded than the one that run on sd.

Thanks temporary close


WebSockets will not work over HTTPS

If the server is being accessed through HTTPS, anything that relies on WebSockets will fail silently and only show an error on the JavaScript command line. The most important feature that's unavailable when this happens is being able to submit jobs.
[blocked] The page at 'https://qiita.ibdmdb.org/analysis/wait/1' was loaded over HTTPS, but ran insecure content from 'ws://qiita.ibdmdb.org/moi-ws/': this content should also be loaded over HTTPS. moi.js:77
Uncaught SecurityError: Failed to construct 'WebSocket': An insecure WebSocket connection may not be initiated from a page loaded over HTTPS.

For more information, see this issue in moi and this StackOverflow question.

The fix seems to just be to use wss:// but we need to know when to use that vs the standard.

I tried by changing moi.js and compute_waiting.html to use wss but no
luck either.
On (Mar-17-15|21:07), Joshua Shorenstein wrote:

The fix seems to just be to use wss:// but we need to know when to use that vs the standard.

Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/issues/993#issuecomment-82730321

Some info if you google "tornado was". Are the certs etc setup in
webserver.py?
On Mar 18, 2015 7:05 AM, "Yoshiki Vázquez Baeza"<EMAIL_ADDRESS>wrote:

I tried by changing moi.js and compute_waiting.html to use wss but no
luck either.
On (Mar-17-15|21:07), Joshua Shorenstein wrote:

The fix seems to just be to use wss:// but we need to know when to use
that vs the standard.

Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/issues/993#issuecomment-82730321

—
Reply to this email directly or view it on GitHub
https://github.com/biocore/qiita/issues/993#issuecomment-82766021.

I tried this out, but it didn't work either.
On (Mar-18-15| 0:19), Daniel McDonald wrote:

Some info if you google "tornado was". Are the certs etc setup in
webserver.py?
On Mar 18, 2015 7:05 AM, "Yoshiki Vázquez Baeza"<EMAIL_ADDRESS>wrote:

I tried by changing moi.js and compute_waiting.html to use wss but no
luck either.
On (Mar-17-15|21:07), Joshua Shorenstein wrote:

The fix seems to just be to use wss:// but we need to know when to use
that vs the standard.

Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/issues/993#issuecomment-82730321

—
Reply to this email directly or view it on GitHub
https://github.com/biocore/qiita/issues/993#issuecomment-82766021.

Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/issues/993#issuecomment-82789170

I was able to verify that the websockets in fact work using Safari 8.xxxx. It seems that the problem is arising from the fact that the interface is not being properly updated and gives a misleading impression of nothing happening. My guess is that the creation of the HTML elements is not working.

Needs to be verified, but may have been solved by #1058

How can that be? I don't recall any changes to the webserver's configuration to take in a certificate.

Oh, I thought you had the certs up and it was just a ws:// vs wss:// issue. My bad.

Np, it's really both things. We should add a parameter to the config
file such that you can set what the certificates, etc you want to use
are.
On (Apr-28-15|12:37), Joshua Shorenstein wrote:

Oh, I thought you had the certs up and it was just a ws:// vs wss:// issue. My bad.

Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/issues/993#issuecomment-97180065

Now we are using https and we don't have this issue, @ElDeveloper can we close?

Yes, I believe this is the case, since we now have the system work with HTTPS.

with heroku how can I fix SecurityError: Failed to construct 'WebSocket': An insecure WebSocket connection may not be initiated from a page loaded over HTTPS.?


feat: add apps and libraries

Add apps directory and idstore-web, idstore-reports applications.
Add libs directory and idstore-commons, idstore-components libraries.

good


Change in aggregate_trainval_bags_by_patient

Ensure that bags is a np.ndarray with each element as of type list

This code does not ensure that bags is a np.ndarray with each element as of type list.


BiomeKeys mappings for 23w07a

All is in the title ^^.

This was already mapped in #362 which is in FCP!


CSS Ignore in style block

OK, one more thing and then I'll stop :)
I have css.validate disabled in VS Code because it throws errors on Tailwind CSS's @apply
It seems like this setting is ignored in volar's parsing of CSS blocks.  This bit of style throws a variety of css errors.
Both lines throw semi-colon expectedcss(css-semicolonexpected) and at-rule or selector expectedcss(css-ruleorselectorexpected)
Is there any way to have volar not pass along the CSS for validation?
<style scoped>
li :deep(a.router-link-exact-active) {
  @apply text-white bg-opacity-25;
}

li a {
  @apply flex flex-row items-center;
}
</style>

you can use @vue-ignore, see: https://github.com/johnsoncodehk/volar#using
btw maybe I will change to css.validate, I'm considering.

Does css.validate support monorepo now in VS Code, in normal use?

can it be set any more granular than that?

As I know it can't.
I'm not sure the final solution now, if has a replacement we should make sure it's a better way. css.validate cannot completely replace @vue-ignore, so I would like keep @vue-ignore way at least for now.
btw we will support postcss in future, and I personally recommend you join Discord group for discussion.

postcss is supported in 0.21.12.

I'm not sure the final solution now, if has a replacement we should make sure it's a better way. css.validate cannot completely replace @vue-ignore, so I would like keep @vue-ignore way at least for now.

Actually separate option for disabling CSS validation globally like in Vetur would be nice :) Adding extra line "@vue-ignore" in every file just to remove wrong IDE warning is not elegant solution.

@chojnicki I know @vue-ignore is annoying.. sorry. but also need to consider consistency support verification with command line tool. @vue-ignore support IDE and cmd, but global IDE option only work for IDE. I need to avoid confusion.
The standalone option can still be considered, I just need to solve the monorepo and cmd problem.
btw you can also use lang="postcss" to avoid error, it should better then @vue-ignore for you.

in 0.21.20 you can config "volar.style.defaultLanguage": "postcss" in vscode for experimental. please let me know it's good or not.
for command line tool I can also add default language option so not a problem, but I may have to give up monorepo support.

I did not know that I can replace scss/sass with postcss alone. It was good idea since Tailwind has it build in, so no need for scss packages.
After changing to <style lang="postcss"> it works fine ;) Thanks

I am using scss and I am running into the same issue.

I went back in time to see the referenced @vue-ignore tag and how to actually use it, however it doesn't seem to work anymore.
My vscode settings contain "scss.lint.unknownAtRules": "ignore" and  "css.lint.unknownAtRules": "ignore" just to make sure, but volar doesn't seem to respect these settings.
Any idea how I could hide the warnings for unknownAtRules?

@vaaski you can use lang="postcss"

@vaaski you can use lang="postcss"

this is not working when we need to use it with scss tho


Added a way to open / close the calendar outside of the datepicker component

Hi,
I work at Wix, and we needed a way to open / close the calendar outside of the component (for example, opening the calendar with an external button).
I've done that by adding 2 new props: "isOpen" (boolean) and "setOpen" (function).
This functionality will only work by adding these props, and will not affect the object in any way if those props were not added.
isOpen - will live alongside the internal ‘state.open’ in correlation.
setOpen - is a callback that will be called if the function is defined and the state has been changed.
I've also added a simple example that shows a connection between the calendar and a checkbox using this new feature.
Hope you will like it, have a nice week.
approved by @lbelinsk

The test above fails with / without my commit, what can I do about it?

Would you mind making it clearer that this is adding another way to open/close the component from outside? (It can already be set statefully via the the .setOpen() method.)
I'm all for allowing the state to be fully controlled via props, but in that case, the prop should always take precedence if it is specified. Otherwise we end up with confusing behavior, like the datepicker closes itself despite having isOpen={true}.
IE, we should use the value of the prop instead of treating it as an edge-trigger to toggle internal state.

@aij Since there are a lot of users for this library, we didn't want to break any existing behavior.
We have 3 interesting events:

constructor: state.open will be initialized by the props.isOpen value (which is false by default).
user did focus / blur: this.setOpen will take care of the state and will call the props.setOpen callback to allow the user to change the props.isOpen.
User passed a different props.isOpen: We handle this case in componentWillReceiveProps and call this.setOpen.

So in each case, we make sure the state and the prop are in correlation. The "react way" will be to delete the state.open boolean, and to work only with the props.isOpen, but we should remember to have backward compatibility.
This is our solution, but there is an alternative one, like you suggested, to completely ignore the state.open if the props.isOpen was given.
I personally like the first solution better, but we are open for discussion.

@lbelinsk When we call props.setOpen, and the user chooses not to change props.isOpen, how do we make sure the prop and the state are in correlation? It seems to me like we don't.

I agree with @aij; to summarize the requirements:

If the prop is not specified, we need to maintain the existing behavior of relying on component state for backwards compatibility
If the prop is specified, it must always override the state so that it always correlates to the observed state of the picker

I understand what you mean with the confusing behaviour, theoretically props.setOpen callback is used so the developer will change his external isOpen value, as shown in the example (the openCalendar function used to keep this correlation).
I've also made sure to expose this code in the example's description, so developers will understand how to use this callback.
the callback is triggered every time the internal "state.open" is being changed, so as long the developer chooses to keep the correlation it's his responsibility.

That said, it's only to explain our approach about the problematic behaviour you described.
Ultimately our first priority is to enable closing & opening the calendar from outside the component + not to harm in any way developers that are already using the component, your solution also provides this goal but here are some drawbacks I think you should consider:

In your suggested solution, where we will treat the prop.isOpen as an override over the state.open boolean, we can’t completely stop updating the internal state. even If I as a user want to be able to control the visibility of the calendar with a boolean prop, I would expect the component to close and open on focus and blur, without me doing anything from outside.

Future contributors will have to maintain 2 scenarios:
- the current one, calendar visibility fully controlled from the internal state.
- the alternative, a prop that is being practically used as a state (a function inside the
component, handleOpenChange that will change the prop).

The bigger the component will get, the harder it will be to maintain that 2 scenarios, I think in the long run it will cause that different developed attributes will work great alone, but might not work too well with different combinations because developers will overlook this new open-state-prop mutation.
After considering this and the example with the checkbox (that teach developers how to use the callback appropriately and maintain correlation between the prop.isOpen and state.open), advise which solution you prefer and I will change it accordingly.
Thanks.

If I as a user want to be able to control the visibility of the calendar with a boolean prop, I would expect the component to close and open on focus and blur, without me doing anything from outside.

I disagree with this -- if you choose to override the default behavior, you are giving up the automatic open/close handling.  You can decide how to update the isOpen prop via the onChange or various other existing callbacks.  Overriding the state when the prop is specified is much easier to understand than expecting a consumer to keep themselves in sync with the picker's state, rather than the other way around.

As @GBT3101 said before, we will go with the approach you will see best.
I care enough about this component, so I will just raise some final concerns:

The user would have to pass onFocus as props. This callback will have to modify the external state. It will be called here:
https://github.com/Hacker0x01/react-datepicker/blob/master/src/datepicker.jsx#L176-L180

The user would have to pass onBlur as props. This callback will have to modify the external state. It will be called here:
https://github.com/Hacker0x01/react-datepicker/blob/master/src/datepicker.jsx#L197-L202

IMHO, It feels like the user has too much control in his hands like he has 2 separated components, Calendar popup and an input which he needs to sync together from scratch.
Other than that, the user can decide to modify the external state with "onSelect" or "onChange" callbacks, which is fine.
Please let us know what is the final solution. We will make sure to implement it tomorrow according to your decision.
Thanks for the quick responses, it is really appreciated.

Possibly related question:
In my experience, the calendar closes by default when a date is selected. When showTimeSelect is true, the calendar does not close when a time is selected. The current default workflow is actually perfect if a user selects a time first and then a date, but that isn't necessarily intuitive. So it's nice to have @lbelinsk's shouldCloseOnSelect (https://github.com/Hacker0x01/react-datepicker/pull/992) solution to prevent any automatic closing. Would it be appropriate to have a more granular closing controls for when to internally close the calendar? Or does the solution proposed here sufficiently solve my case by passing the auto-close responsibility to the developer?

@micahalcorn we have discussed about 2 possible solutions:

Keep the current "uncontrolled" behavior but also allow add isOpen and setOpen props that would allow you to control the state of the calendar and keeping the state.open and props.isOpen synced. It means that as long as you won't provide these new props then everything will work normally, but when you do provide the new props then the control is in your hands by implementing the callback function to hide or show the calendar. It will update the inner state of the component as well. You won't have to take care of the obvious behavior of showing and hiding the calendar on focus and blur respectively.

The solution, which sounds like we are going to implement soon since the first approach was not approved here, is making the component support 2 modes: controlled and uncontrolled. It means that by passing the new props the component will no longer work with its internal state.open, and instead will only listen to the new prop which would get updated by the callback the user will pass.
So the user would have to also take care of onFocus and onBlur events to hide and close the calendar. so you basically going to get all or nothing.

@rafeememon @aij can you confirm that the desired solution is the second one?
@GBT3101 and I will take care of it hopefully this week (we had a lot of holidays here during the past few weeks :))

@lbelinsk I was thinking closer to 1, but making it so props.isOpen would actually allow you to control the state of the calendar. So the example in examples/set_open.jsx would stay the same, except that the opening and closing of the calendar would happen in response to the value of props.isOpen rather than in spite of it.
TBH, I'm not sure how useful it is to control the openness of the calendar via props. It seems kind of akin to  controlling focus via props, which React has decided not to do. It's not quite the same, because it never makes sense to have two inputs have focus at the same time but it might make sense to have more than one datepicker render as open at the same time, though I expect that would require other code changes as we've made assumptions that kind of tied calendar openness to focus.
I think we have some confusion in this discussion due to the original comment (and commit message) being slightly misleading. (See my first comment where I requested that be clarified.)
In case it wasn't clear enough earlier, the datepicker can already be opened and closed from outside the component, by calling .setOpen(true||false) on the instance of the datepicker that you want to open or close. (Much like focus on a regular input can be set by calling .focus() on it.)
Of  course, calling .setOpen() is kind of fire-and-forget. It lets the user set the current open state, but not take full control over it. (Since the calendar continues to open/close as usual in response to clicks/focus/etc.)
Perhaps another source of confusion is that this PR is adding a new setOpen prop, with the same name as the existing .setOpen() method. (Above, I was referring to the existing method, not the new prop.) Perhaps if we do keep the new callback prop it should be named onSetOpen to avoid confusion. (Much like React has .focus() and onFocus.)
That said, I still don't understand the motivation for this PR (other than perhaps misunderstanding what is already possible -- which is hopefully clearer now).
Is it just about being able to open or close the calendar externally? Then perhaps the new example could be updated to use the existing API.
Does someone need callbacks in order to respond to the opening/closing of the calendar? Then it seems the new setOpen prop is all that's needed (though I'd still prefer it be renamed to avoid confusion).
Does someone need to take control over when the calendar opens or closes? Then we could add the isOpen prop, but we should actually honor it.
Perhaps an example might help. This page shows how we are using react-datepicker at CCAP: https://wccabeta.wicourts.gov/lawEnforcementCalendar.html Note how clicking the little calendar buttons opens and focuses the corresponding datepicker. That is of course already possible.
Now could someone elaborate on what it is that Wix is trying to do? (And perhaps how that is different from what the existing API allows?)

@aij thanks for your response.
I will start from the beginning in order to explain our motivation. We needed to allow opening and closing the calendar not by focusing on the input (that's all :)).
Use case:
Actually, the CCAP example is pretty similar to out usage.
A form which has a checkbox "Today" and if you uncheck it then you will be requested to insert some other date. By unchecking this checkbox, a date-picker is being rendered and we wanted it to be rendered with an open calendar. So basically the "onClick" of the checkbox should open the calendar.
We implemented it on our side by placing ref prop on the react-date-picker and calling ref.setOpen(true||false). Of course It worked, but we felt maybe this is not exactly the "react way". In React the data flow is from top to bottom, and this approach kind of violates it.
We have a closed pr for that and I can share a link if it will be relevant.
Regarding this comment:

@lbelinsk I was thinking closer to 1, but making it so props.isOpen would actually allow you to control the state of the calendar. So the example in examples/set_open.jsx would stay the same, except that the opening and closing of the calendar would happen in response to the value of props.isOpen rather than in spite of it.

We thought about it in the beginning, but then we understood that there is one problem with this solution. Let's say we have a closed calendar. Now let's change props.isOpen to be true, and the calendar will be visible. Until here all good. Now let's say I clicked outside of the input, so now it got closed. Notice that the props.isOpen is still true, although the calendar is hidden. Now in order to open the calendar again with this prop, you can't really do anything since it's value is already true. You can change it to false and then again to true and this is the only way to open the calendar. This is not a nice solution. This is why we think the props.setOpen is needed. We can rename it of course.
@aij I completely agree with you that it is similar to ref.focus() of input, but we try to avoid using it in general.
This is why we thought it will be nice to enrich the component with "controlled calendar".
Having read your comment, I am convinced that the option of using the ref.setOpen() is better than solution #2 that was suggested here. We would still prefer having our #1 suggestion, although it creates some confusion in the component's behavior and adds some complexity to the state management.
Having said that, You guys are the watchers over the wall, and if this solution is not the one you want to go with then let's just roll back to the existing solution ref.setOpen().
We can update only an example of examples/set_open.jsx and not to add any further changes.

Let's go with (1) -- as you called out, the other solution adds confusion to the behavior and seems like one step forward and two steps backward.

Cool, so number 1 it is...


chore: use data-encoding arg to ensure data is not corrupted

Requires ipfs/js-ipfs#1420 to be merged in order to allow the test in ipfs/interface-ipfs-core#302 to pass.

Do you mean https://github.com/ipfs/js-ipfs/pull/1420 not https://github.com/ipfs/js-ipfs/pull/420 ?

Yes, have updated the description.

@achingbrain please rebase master onto this branch to get that CI green :)

This requires go-ipfs 0.4.17 to be released first - not much point merging this until then.

go-ipfs 0.4.17 has been released, should probably get this in so we can merge ipfs/js-ipfs#1420 and ipfs/interop#25.  Needs ipfs/interface-ipfs-core#342 merging first it seems.

@alanshaw CI is green, can it be merged?

Yes, it requires go 0.4.17.

Will this stop this from being merged?

0.4.17 has been released

@achingbrain would you mind adding a BREAKING CHANGE message to the commit? Also, do you think it's more appropriate to prefix with "fix:" than "chore:"?
This change will mean that the API will only work with go-ipfs 0.4.17 and above and we need to make sure there's no confusion around that when it's released.

Done, just trying to get Jenkins to pass.

Hmm, this new test is failing, but only on Windows and only some of the time.  Any ideas?

It times out so the repo might be missing the DAG node it's trying to get?  It's not clear to me where that node would come from so I've added it to the repo in the test.

...aaaand one of the Jenkins workers is out of disk space.


update my profile

so when i chat , and update my information, apparently it is not saved in the default profile. does it have an option to save information i share and refer to it automatically next time? Thanks

Use /save and /load. By default, /load will load the most recent files created with /save, but you can pass a specific .json file if you want to load a specific checkpoint/model.
https://github.com/cpacker/MemGPT#interactive-cli-commands


Have MultiSet.clear() return this

  // Methods   clear(): void;   add(key: K, count?: number): this;   set(key: K, count: number): this;   has(key: K): boolean;
It's currently not possible to write x.clear().add(...), which would be particularly handy.

Hello @kberg, I see your point but I am split on this problem as currently I am adhering to the ES6 data structure for consistency reasons and an ES6 Map clear method does not return this, and so currently no clear method from this lib does either.

Well, I see your point.
And, add returns this in the ES6 standard?

And, add returns this in the ES6 standard?

It does indeed: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/add#return_value

OK. Well, I hear you. Let's close these, then. Thanks.