nixos/scion: use RuntimeDirectory instead of StateDirectory

Description of changes
This PR doesn't cause any issues for existing deployments if there are any. It's just a re-routing of where the runtime files are placed, to prevent keeping them persistent on the disk.
It was wrong to use StateDirectory to keep the scion-control and scion-router runtime databases on disk for the next run. I observed that doing this means a reboot, or power outage can corrupt the temporary runtime databases for the next service start, leading scion ping and other functionality to stop working permanently, since those files are not managed in an atomic manner by the golang code.
This is supposed to be stateless, which is what RuntimeDirectory provides, as those dirs get cleaned up on each service start, leaving nothing behind.
 (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Please add the rationale to the commit message, otherwise it's not clear from the history why that change is made.

Done @fricklerhandwerk

According to @matzf this is not supposed to happen, but this kind of error happens in the context of SCIONLab Vagrant deployments all the time, and is documented here https://docs.scionlab.org/content/faq/troubleshooting.html#border-router-fails-to-start
For now, we should keep it as a RuntimeDirectory in systemd until it can be demonstrated safe and to not lead to these issues, at which point switching back to StateDirectory is simple.
Matzf suggested it could be an issue with service start order, or waiting for interfaces/IPs. But that 0 byte file has me wondering if it's not just an issue in how the upstream code read/writes the files on disk.

To clarify, my telediagnosis referred to the somewhat generic error messages in the control service log that you shared (here and in the chat) that indicate some connectivity issues during the SCION path discovery processes. Such failures of the underlying network can occur for any number of reasons; in SCIONLab, starting the router before establishing VPN connection is a particularly frequent case of such a connectivity problem.
Corrupt databases was not at all what I was referring to.
Furthermore, I'm not sure whether a 0 byte write-ahead-log "wal" file is (necessarily) a corrupt database. This could also "just" mean that there have not been any writes to the database since the last checkpoint.
While it's of course not impossible that the files do end up being corrupt, sqlite has an excellent track record for not creating invalid files even on a hard shutdown.
It's quite possible that the information contained in the database is entirely valid, but leads to different behavior which in your case leads to the path discovery not working. Good that you found a workaround for your problem by removing these cache files, even if this might not address the actual cause.

Continuing conversation in the scion dev channel, there was a mention that there are two sqlite implementations that can be switched between as documented here https://docs.scion.org/en/latest/dev/build.html#options
The two options are "real sqlite from c sources" and "pure golang sqlite". The latter is in use by default and could be less reliable than the C sqlite, leading to the above issues.
So I'm experimenting and testing both implementations to see if this issue still occurs.


fix translation structure

Looks good to me.

Coverage remained the same at 64.935% when pulling 330f4f4d420d59431691c25360c72ea70e5aa7f8 on fix-translation-structure into 8d3677171040bc784eb571562a02cf9bc0b6b566 on master.


chore(main): release 2.2.0

:robot: I have created a release beep boop
2.2.0 (2024-05-13)
Features

a new feature (6fadafb)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/frtibble/test-repo/releases/tag/v2.2.0 :sunflower:


Fix formatting in BLEU metric card

Fix #4148

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


passing props to component

Version
3.0.1
Reproduction link
https://jsfiddle.net/91vLms06/
Steps to reproduce
const CreateComponent = Vue.component('create', {
	props: ['user'],
  /*
  props: {
  	user: {
    	type: Object,
      required: true
    }
  },
  */
  template: '
User data: {{user}}
'
});

const router = new VueRouter({
  routes: [
    { path: '/create', name: 'create', component: CreateComponent},
  ]
});

const app = new Vue({
	el: '#app',
  router: router,
  created: function () {
    const self = this;
		// ajax request returning the user
    const userData = {'name': 'username'}
    self.$router.push({name:'create', props: { user: userData }});
  }
});

  <router-view></router-view>

What is expected?
I should see the user data in JSON format.
What is actually happening?
The user property is undefined or null.

That is working as expected, please see https://router.vuejs.org/en/essentials/passing-props.html and note the props attribute in the route record

@posva please notice this line self.$router.push({name:'create', props: { user: userData }});. I tried all the exemples from the provided link, it's still not working.

It's in the route record that you need to pass props, not in a push
BTW passing arbitrary state in a navigation that is not part or the url is
not supported.
If you need further help, please use the forums or discord
On Wed, 23 May 2018, 15:52 danieltutu<EMAIL_ADDRESS>wrote:

@posva https://github.com/posva please notice this line self.$router.push({name:'create',
props: { user: userData }});. I tried all the exemples from the provided
link, it's still not working.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vuejs/vue-router/issues/2210#issuecomment-391354746,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAoicctjMfk-IKuDCTb0iaYM-1cOOKQjks5t1WmrgaJpZM4UKcL8
.

--
Eduardo San Martin Morote


Avoid using write stream for logging

This fixes the problem where the deactivate function wasn't completing. See https://github.com/microsoft/vscode/issues/167481

Thanks for the tip - I won't change it this time, but noted for future reference.


HTML Attachment Publishing workflow

This PR contains the logic that decides what to do with an HTML Attachment when something happens to its parent.
The potential events are well defined in the Edition Services parts of Whitehall. We have a PublishingApiPusher service listener that deals with relevant events for the parent document and then forwards the event to this HTML Attachment-specific pusher.
The bulk of the complexity here is in removing attachments that were present on the previous (superseded) edition when a new edition is published.
A future PR will likely use this class (or a variation of it) to accurately republish all HTML Attachments in Whitehall.
/cc @gpeng

This is great. I'd personally find the tests easier to read with the expected behaviour in the test name but don't let that stop you merging if you disagree. :+1:

Good call. Done in aa21fa6

:+1:


Error encountered resolving symbol values statically.

Hi all,
anyone knows how to solve this?
[WARN] Error occurred during command execution from a CLI plugin (@ionic/cli-plugin-cordova).
Error: Error encountered resolving symbol values statically. Calling function 'ɵmakeDecorator', function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol Injectable in<EMAIL_ADDRESS>resolving symbol ɵf in<EMAIL_ADDRESS>resolving symbol ɵf in<EMAIL_ADDRESS>
npm -v
5.3.0

Thank you all!

Hi all,
I'm having the same error
ERROR in Error: Error encountered resolving symbol values statically. Function calls are not supported
. Consider replacing the function or lambda with a reference to an exported function (position 4:10 in
the original .ts file), resolving symbol RestangularConfigFactory
Here are my dependencies
{
"@angular/animations": "^4.2.4",
"@angular/common": "^4.2.4",
"@angular/compiler": "^4.2.4",
"@angular/core": "^4.2.4",
"@angular/forms": "^4.2.4",
"@angular/http": "^4.2.4",
"@angular/platform-browser": "^4.2.4",
"@angular/platform-browser-dynamic": "^4.2.4",
"@angular/router": "^4.2.4",
"core-js": "^2.4.1",
"ngx-restangular": "^1.0.11",
"rxjs": "^5.4.2",
"zone.js": "^0.8.14"
}


OpenVPN build with --enable-pkcs11 fails

Problem Description
On Lede image builder under Debian i686 with 4.9.0 kernel, if I edit package/network/services/openvpn/Makefile and change

--disable-pkcs11 to --enable-pkcs11

build fails. The configure script cannot find pkcs11-helper dependency.
Proposed Resolution
Add the pkcs11-helper software in Lede
Steps to reproduce
nano [BUILD_DIR]/package/network/services/openvpn/Makefile
make package/openvpn/compile

Wrong repo.
That openvpn package is in the main Openwrt/LEDE sources, not here in the LuCI repo for GUI.

Ok thanks.
Can you provide me the link?
THX

https://bugs.openwrt.org


ACTIVE MALWARE DETECTED

Kaspersky Total Security <IP_ADDRESS>5c detected a Trojan Horse inside \AppData\Roaming\Synctrayzor\syncthing.exe.
Trojan Program: Trojan.Win32.Ebowla.ab

False positive
https://forum.syncthing.net/t/kaspersky-treats-syncthing-as-virus/7659

This was a kaspersky issue which has now (apparently) been fixed by them

Who is to say Kaspersky was the troublemaker? I find it more likely the git got an infected binary.

If you read the forum thread which @ProactiveServices kindly linked you to, you'll see that:

Syncthing 0.13.7 was verified beyond reasonable doubt to to be free from malware. A build from source was done in a pristine environment, and was as close to byte-for-byte identical to the official release as can be expected.
The issue was reported to Kaspersky. They released updates to their definitions, and no longer identify Syncthing as malware.

Therefore I am certain that the official Syncthing release is free from malware, and the Kaspersky alert was (note: it no longer is) a false positive.
I have no idea what "git got an infected binary" means. Git deals with source, not binaries.
Finally, this is the wrong repository: this is the repo for SyncTrayzor, not Syncthing. The correct issue for this is https://github.com/syncthing/syncthing/issues/3329, which you also opened and was closed with the same explanation as I've given here.


Start interrupt failure

add to WhateverGreen.kext Unable to start，
-v failure code
@kec.corecrypto 1.0 attemptlng system restart...

Tracking in #34


Update to 2.12.

Changes according to new Electron Frontend/Backend initialization.

This PR should be abandoned in favor of the 2.13 one.


Update metadata.json, includes major bump for Approved program

When we moved to puppet-community the metadata.json got created and the version got bumped to a 1.0


Flag to track if useMouseHovered is dirty

A solution to #478
We could use NaN/null/undefined etc. for the variable values (i.e. docX, docY, elX and elY) but that would translate to poor DX overall. Moreover, it would break backward compatibility.
It would be much easier for those who are concerned with making updates after the mouse has moved once, to be able to wrap all their logic in a block that checks if the mouse has moved once, whilst the original values still stay 0 and not null or something.
I have given the name "dirty" to this flag.
Let me know what you think!

@thevtm does this solve your use case as well?
@xobotyi what do you think?

It's a nice solution.
I would change the name of the flag to something like "touched".

Can we check elW, elH for "dirtiness"?
const {docX, docY, posX, posY, elX, elY, elW, elH, dirty} = useMouse(ref);
const isDirty = !elW;

Also, docX and docY could probably be set from the very beginning. Other values could possibly be set faster if we used useLayoutEffect hook instead of useEffect.

@streamich yes that does make sense and works without changing the API.


Fails to run on 12.04LTS

script output:
[sudo] password for sjakubowski:
oab-java6.sh v0.2.9 - Create a local 'apt' repository for Sun Java 6 and/or Oracle Java 7 packages.
Copyright (c) Martin Wimpress, http://flexion.org. MIT License
By running this script to download Java you acknowledge that you have
read and accepted the terms of the Oracle end user license agreement.

http://www.oracle.com/technetwork/java/javase/terms/license/

If you want to see what this is script is doing while it is running then execute
the following from another shell:
tail -f /home/sjakubowski/oab-java6.sh.log

[x] Installing Java build requirements success
[x] Making build directories success
[x] Updating from https://github.com/rraptorr/sun-java6 success
[x] Removing local clones of sun-java6 success
[x] Cloning sun-java6 with v6.45-1 success
[x] Getting releases download page success
[x] Downloading jdk-6u45-linux-i586.bin : 68.47 MB success
[x] Symlinking jdk-6u45-linux-i586.bin success
[x] Downloading jdk-6u45-linux-x64.bin : 68.75 MB success
[x] Symlinking jdk-6u45-linux-x64.bin success
success
[x] Downloading jce_policy-6.zip : 8.89 KB success
[x] Symlinking jce_policy-6.zip success
[x] Updating the changelog success
[x] Building the packages success
ERROR! Packages failed to build.
log output:
dh_clean
debian/rules build
Build information
TOP         = usr/lib/jvm
VENDOR      = sun
RELEASE     = 6
PRODUCT     = java6
basename    = sun-java6
version     = 6
releng_ver  = 45
unpackdir   = jdk1.6.0_45
srcdir      = x64-jdk
all_archs   = i586 x64
arch        = x64
archdir     = amd64
bin_pattern = jdk-6u45-linux-%.bin
rm -rf jdk1.6.0_45
binsize=$(wc -c jdk-6u45-linux-i586.bin | awk '{print $1}');
zipstart=$(unzip -ql jdk-6u45-linux-i586.bin 2>&1 >/dev/null | sed -n -e 's/.* ([0-9][0-9]) extra bytes./\1/p');
tail -c $(expr $binsize - $zipstart) jdk-6u45-linux-i586.bin > tmp-jdk.zip
expr: syntax error
tail: jdk-6u45-linux-i586.bin: invalid number of bytes
make: *** [unpack-i586-stamp] Error 1
dpkg-buildpackage: error: debian/rules build gave error exit status 2
21050's retcode: 2
success

I got the same problem:
Build information
==========================
TOP         = usr/lib/jvm
VENDOR      = sun
RELEASE     = 6
PRODUCT     = java6
basename    = sun-java6
version     = 6
releng_ver  = 45
unpackdir   = jdk1.6.0_45
srcdir      = x64-jdk
all_archs   = i586 x64
arch        = x64
archdir     = amd64
bin_pattern = jdk-6u45-linux-%.bin

rm -rf jdk1.6.0_45
binsize=$(wc -c jdk-6u45-linux-i586.bin | awk '{print $1}'); \
	zipstart=$(unzip -ql jdk-6u45-linux-i586.bin 2>&1 >/dev/null | sed -n -e 's/.* \([0-9][0-9]*\) extra bytes.*/\1/p'); \
	tail -c $(expr $binsize - $zipstart) jdk-6u45-linux-i586.bin > tmp-jdk.zip
expr: syntax error
tail: jdk-6u45-linux-i586.bin: invalid number of bytes
make: *** [unpack-i586-stamp] Error 1
dpkg-buildpackage: error: debian/rules build gave error exit status 2
22291's retcode: 2
success

Problem seems to be in sun-java6:debian/rules#L316 because $zipstart is empty and expr and throws syntax error.
I try to make default to zero, but fails with:
unzip -q tmp-jdk.zip
[tmp-jdk.zip]
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of tmp-jdk.zip or
        tmp-jdk.zip.zip, and cannot find tmp-jdk.zip.ZIP, period.

Even unzip -ql fails with the original binary:
$ unzip -ql /var/local/oab/pkg/jdk-6u45-linux-x64.bin
[/var/local/oab/pkg/jdk-6u45-linux-x64.bin]
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /var/local/oab/pkg/jdk-6u45-linux-x64.bin or
        /var/local/oab/pkg/jdk-6u45-linux-x64.bin.zip, and cannot find /var/local/oab/pkg/jdk-6u45-linux-x64.bin.ZIP, period.

What could it be? The binary is not a valid ZIP file anymore? For info, downloaded binaries are 5307 bytes in my computer.

This is related with #127. The downloaded binaries are in fact just an HTML page with Unauthorized Request error.


FE: Auto Generate Heat Map overlay based on data selection

[ ] Generate heat map overlay based on the environmental condition selected

This is blocked by my work on the data selection (FE#14). I'll clear it as soon as I'm done.


chore: replace set_integral with setIntegral

Done with a global search and replace, and then (to fix the #align lines), replace (#align \S*)setIntegral with $1set_integral.

Thank you for doing this! My only comment be a lot of work: can you add deprecation aliasses to all the definitions, lemmas and theorems you're renaming? Actually: I think it shouldn't be too hard to write a script to do this. Hang on...

Such a script already exists somewhere, let me try to find it on Zulip.

I found the script, see https://github.com/leanprover-community/mathlib4/pull/10185#issuecomment-1925481325. I have it running on the PR, I'll upload the result once it's done.

Thanks! :tada:
bors merge


id: defenses explanation is very long and may not be helpful

This needs to be turned into a much simpler summary, maybe with accordions.
I think ideal is a bullet that can be read on one screen.

Decision:
Shorten to bullet points.
Have a longer version that the tenant can take and use on their own later.
Consider sending tenants a reminder text/email closer to their court date that reminds them of the key points in their Answer.

Thinking this through more: integrate this into the review screen, reviewing each defense and organizing them underneath the review screen categories.
Add a very short summary page before the review screen that says something like "you have 3 defenses. On the next page, you can review them in detail. If you aren't sure about a defense, look at the facts you provided and make any changes you need. At the end of this interview, you will get a summary of your defenses and the evidence that you should bring with you to court that you can download and print to bring to court."


Fan Requested Changes Custom Styles

Whats new:
-Multi gradient support (radial and conic) (example usage: Color Master on my gallery):

-Ability to set Question Text Color:

good


Refactored the code

Fixes #484
Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream master branch.
[x] I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

The whole code has been refactored 🎉
Redundant if-else conditions removed
There is one central call_appropriate_parser which calls the appropriate parser instead of having one for each qtype.

URL: https://shielded-shelf-27127.herokuapp.com/
Please review ASAP 😄

Resolve conflicts

@ParthS007 @vaibhavsingh97 Please review. This PR originally refactored the entire code, but since another PR of mine was merged before this, there's only one line difference. But this PR needs to be merged as it also provides the bug fix for Baidu news search, as of now that doesn't work.


Fix Quickstart notebook link

Reported in https://github.com/huggingface/datasets/pull/5902#issuecomment-1649885621 (cc @alvarobartt)

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


fix model modal state

What is this PR for?
fix error caused by second request of model upload.
Currently display the previous result as notification because
prevState of getDerivedStateFromProps is actually not previous state, so followings happen.

when call setState({submitting: true}) in onSubmit, getDerivedStateFromProps is called
from the second request, uploadModelStatus is already success or fail, depending on the previous result
nextState.submitting is true, so display the previous result as notfiication

This PR includes

remove state.form because it is not used
change from prevState to nextState` in getDerivedStateFromProps
modify order of changing state

What type of PR is it?
Bugfix
What is the issue?
N/A
How should this be tested?
write a method and a sample of command

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   83.73%   83.73%
=======================================
  Files          43       43
  Lines        2281     2281
=======================================
  Hits         1910     1910
  Misses        371      371

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 311f514...3393018. Read the comment docs.


Introduce High Level MR metrics

Description of your changes
This pull request introduces the following high level metrics in the MR reconciler and cherry-picks the relevant commit in this PR.

crossplane_managed_resource_exists{"gvk"}
crossplane_managed_resource_ready{"gvk"}
crossplane_managed_resource_synced{"gvk"}
crossplane_managed_resource_time_to_first_reconcile_seconds{"gvk", "claim", "composite"}
crossplane_managed_resource_first_time_to_readiness_seconds{"gvk", "claim", "composite"}
crossplane_managed_resource_deletion_seconds{"gvk", "claim", "composite"}
crossplane_managed_resource_drift_seconds{"gvk", "claim", "composite"}

The crossplane_managed_resource_time_to_first_reconcile_seconds and crossplane_managed_resource_first_time_to_readiness_seconds metrics are pushed only once for each resource, capturing the initial reconciliation time after creation and the first instance the resource becomes ready, respectively. It's important to note that these metrics won't be recorded in the event of a pod restart. One potential solution to this issue is to introduce an additional status subresource, such as "observations," where these values can be stored persistently.

Fixes #
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

Thanks @ezgidemirel! Still needs some work per @sttts's comments but I like this direction much better.

@ezgidemirel Your PR description mentions some crossplane_composite_resource_ metrics, but I don't see where those are implemented. Are you planning for them to be part of this PR? I'd expect core Crossplane to emit these metrics.

@ezgidemirel Your PR description mentions some crossplane_composite_resource_ metrics, but I don't see where those are implemented. Are you planning for them to be part of this PR? I'd expect core Crossplane to emit these metrics.

I was planning to add the state metrics with this PR, but then removed with this commit. I'll update the PR description.

@ezgidemirel Your PR description mentions some crossplane_composite_resource_ metrics, but I don't see where those are implemented. Are you planning for them to be part of this PR? I'd expect core Crossplane to emit these metrics.

I was planning to add the state metrics with this PR, but then removed with this commit. I'll update the PR description.

Hi @ezgidemirel I am running crossplane on 1.17 and can't see the crossplane_managed_resources_* metrics either (the rest are working fine. According to the docs they should be available, is this a bug or am I missing something? This is my crossplane configuration from ArgoCD:
apiVersion: argoproj.io/v1alpha1 kind: Application metadata:   name: crossplane   namespace: argocd spec:   project: system-apps   source:     chart: crossplane     repoURL: https://charts.crossplane.io/stable     targetRevision: 1.16.0     helm:       values: |         resourcesRBACManager:           requests:             cpu: 250m             memory: 512Mi           limits:             cpu: 250m             memory: 512Mi         resourcesCrossplane:           requests:             cpu: 250m             memory: 512Mi           limits:             cpu: 250m             memory: 512Mi         metrics:           enabled: true   destination:     server: 'https://kubernetes.default.svc'     namespace: crossplane   syncPolicy:     automated:       prune: false       selfHeal: false     syncOptions:       - ServerSideApply=true       - CreateNamespace=true

@eduardo-diaz-em, this is a crossplane-runtime PR. crossplane-runtime is used by Crossplane providers. Your provider version and which version of crossplane-runtime it uses is important, rather than your Crossplane version. For instance, provider-upjet-aws uses crossplane-runtime v1.16.0-rc.2.0.
I acknowledge that it would be helpful if the documentation clarified distinction between Crossplane and Crossplane provider metrics.

I'm using same xpkg.upbound.io/upbound/provider-aws-sqs:v1.9.0 which is using crossplane-runtime v1.16.0-rc.2.0.2024 along with crossplane v1.16 same happens to me, I can see all metrics but not the crossplane_managed_resources_* ones
@eduardo-diaz-em managed to get this solved?
@ezgidemirel @mergenci will appreciate any clue here
This is my v1.16 chart config :
extraObjects:

apiVersion: aws.upbound.io/v1beta1
kind: ProviderConfig
metadata:
name: default
spec:
credentials:
source: IRSA
apiVersion: pkg.crossplane.io/v1beta1
kind: DeploymentRuntimeConfig
metadata:
name: irsa-runtimeconfig
spec:
serviceAccountTemplate:
metadata:
name: crossplane-aws
annotations:
eks.amazonaws.com/role-arn: .....
apiVersion: pkg.crossplane.io/v1
kind: Provider
metadata:
name: provider-aws-sqs
spec:
package: xpkg.upbound.io/upbound/provider-aws-sqs:v1.9.0
runtimeConfigRef:
name: irsa-runtimeconfig

Please ignore, I found the problem was I was looking at crossplane pod metrics, but not at the provider pods ones :)
metrics are here: provider-aws-sqs-7a356e3a0f47-55bdc59969-vkmpt
Noting here, in case someone faced same confusion

Thanks for the quick follow up @pablomdc - if anyone else stops by this PR, one helpful resource is also this demo to use the high level metrics that I had put together a few months back with help from @ezgidemirel: https://github.com/jbw976/demo-metrics

Buena esa @pablomdc I was also looking at crossplane pods rather than provider ones. Gracias!


[BUG] EventHubBufferedProducerClient: Flushing the client results in ObjectDisposedException on subsequent enqueueing of events

Library name and version
Azure.Messaging.EventHubs 5.7.5
Describe the bug
After a FlushAsync has been called on the client, all subsequent enqueue calls fail on the client with a System.ObjectDisposedException.
Expected behavior
Either it should be possible to enqueue events after a flush without exceptions being thrown or the documentation should be updated indicating that no events can be enqueued after calling the flush.
Actual behavior
Calling EnqueueEventAsync after calling a FlushAsync throws the following exception:

System.ObjectDisposedException: The CancellationTokenSource has been disposed.
at System.Threading.CancellationTokenSource.ThrowObjectDisposedException()
at Azure.Messaging.EventHubs.Producer.EventHubBufferedProducerClient.d__90.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Azure.Messaging.EventHubs.Producer.EventHubBufferedProducerClient.d__75.MoveNext()

Reproduction Steps
        var client = new EventHubBufferedProducerClient("<connection string>", new EventHubBufferedProducerClientOptions()
        {
            EnableIdempotentRetries = true,
            MaximumWaitTime = TimeSpan.FromSeconds(1),
            MaximumEventBufferLengthPerPartition = 100,
            RetryOptions = new EventHubsRetryOptions()
            {
                Mode = EventHubsRetryMode.Exponential,
                MaximumDelay = TimeSpan.FromSeconds(30),
            }
        });
        client.SendEventBatchFailedAsync += HandleFailed;
        client.SendEventBatchSucceededAsync += HandleSuccess;

        await client.EnqueueEventAsync(new EventData("This is my first event"));

        await client.FlushAsync();

        await client.EnqueueEventAsync(new EventData("This is my second event")); //Throws ObjectDisposedException

Environment
.NET SDK:

Version:   7.0.100
Commit:    e12b7af219

Runtime Environment:

OS Name:     Windows
OS Version:  10.0.22621
OS Platform: Windows
RID:         win10-x64

IDE:

Visual Studio 2022
Console Application
Target Framework: .NET 6

Hi @LouisSkyline.  Thank you for reaching out and we regret that you're experiencing difficulties.  The intent is for you to be able to continue to use the buffered producer after flushing; enqueueing new events should work.   It looks like we don't have test coverage over this specific scenario; I'll take a look at reproducing and getting a fix for this.

Any update on this? When can we expect the next release?

Hi @LouisSkyline.   Apologies for the lack of communication; this got held up longer than expected in validation and missed the February release window.    The release is now expected the second week of March and is being tracked by #34422.  We'll be sure to communicate updates there.

Hi @LouisSkyline.   Thank you for your patience.  This has been released as part of v5.8.0.


Fix uber zero duration

Fixes https://sentry.io/organizations/tomorrow/issues/1625515511/?end=2020-05-19T09%3A00%3A00&project=1295848&query=is%3Aunresolved&start=2020-03-19T02%3A16%3A21

Also, why are there so many errors with this - is there something wrong like API changes? I'm unsure if this PR is ideal to be honest, as it means we will not know if anything is wrong in regards to the duration :)

Also, why are there so many errors with this - is there something wrong like API changes? I'm unsure if this PR is ideal to be honest, as it means we will not know if anything is wrong in regards to the duration :)

That's a very valid point. Maybe what we should do is not set any endDate? keep it at null? Then the carbon model can choose to consider a 20min ride if need be, but the data stays clean?


Docs redesign

Summary

Pierre's redesign. Looks like this:

Checklist

[x] Scope: The referenced issue is addressed, there are no unrelated changes.
[x] Run Locally: Verified that the docs build using make server
[ ] New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in README.md.
[x] Style Guidelines: Documentation obeys style guidelines in README.md.
[ ] Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
[x] Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer my guess is that since it's faster to load assets in parallel we try loading fonts from google first, and then fallback to serving them ourself if google is inaccessible for some reason. What's wrong with this approach?

ok, after pushing a few times, here are the changes I made, especially on the home page:
all page

added margin to all HTML (to make it structured)
reworked the UI of the cards (to make it cleaner)
added more white space between elements

navbar

centered the items
changed the state on hover items
changed the CTA size
updated the logo (let me know if its not too early)

footer

removed background to align tti.com

other

removed Inter (too early)
fixed the space for brackets

This is ready for review @kschiffer @htdvisser
I will take some time in the future to work on other pages of the doc

ok, after pushing a few times, here are the changes I made, especially on the home page:
all page

added margin to all HTML (to make it structured)
reworked the UI of the cards (to make it cleaner)
added more white space between elements

navbar

centered the items
changed the state on hover items
changed the CTA size
updated the logo (let me know if its not too early)

footer

removed background to align tti.com

other

removed Inter (too early)
fixed the space for brackets

This is ready for review @kschiffer @htdvisser
I will take some time in the future to work on other pages of the doc

hit the re-request review button to notify them

So I see two ways to go about it:

Adapt this design to use our current CI (Logo, Colors, Fonts), to be able to ship it right now

#1 please, @pierrephz can you do this? Shouldn't be too much work just logo, colors, fonts


Loading screen for clock

Description
Learning objectives

Objective

Todo
These points are a rough guideline. Please feel free to discuss with others on the team about the best way to design this component!

Todo

Useful links

Useful link

Starter Product Questions
These are some general questions that you can ask Nikhil or Archna. Feel free to ask additional, more in-depth questions, like specifications that you think we overlooked.

What role does this play within the project?
Why is it necessary? Is this a nice-to-have?
Where would users use this feature? In what situation?

not a priority


Add noise in images for testing

Coverage increased (+0.1%) to 99.033% when pulling fe1b8f43fbb8c2b7cdb9d6000b09e0f55bf4331c on JorgeMartinezG:image_noise into ec2295b35da9ace3e31425bf642284fbf085ba47 on boundlessgeo:master.


FS-4001: Add Assigned to you section to assessment overview

Add ticket reference to Pull Request title: e.g. 'FS-123: Add content', if there is no ticket prefix with BAU
Change description
A brief description of the pull request

[ ] Unit tests and other appropriate tests added or updated
[ ] README and other documentation has been updated / added (if needed)
[ ] Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test
If manual testing is needed, give suggested testing steps
Screenshots of UI changes (if applicable)

Ticket is currently blocked on design changes & access to environments - closing for combining
the frontends and we can support in gettin the branch pushed and PR raised against the new repo


☂ GraphQL formatter

Description

[x] #3319

[ ]  Comments: Handling of comments within GraphQL files for consistent formatting.  https://github.com/biomejs/biome/blob/main/crates/biome_graphql_formatter/tests/specs/prettier/graphql/comments/interfaces.graphql
https://github.com/biomejs/biome/blob/main/crates/biome_graphql_formatter/tests/specs/prettier/graphql/interface/separator-detection.graphql

[ ]  Performance tests

[ ]  Integration with VSCode

[ ]  Integration with IntelliJ

[ ] Integration with zed

:rocket:

For VSCode https://github.com/biomejs/biome-vscode/pull/252 should be enough, right?

@denbezrukov yes


feat(plugin-chart-echarts): add only_total control to ts chart

🏆 Enhancements
releated to https://github.com/apache-superset/superset-ui/pull/1279
individual values

total values

@stephenLYZ I'm unable to disable "Only total" on bar chart:

Also, for non-stacked it's showing the total on all labels:

@stephenLYZ I'm unable to disable "Only total" on bar chart:

Also, for non-stacked it's showing the total on all labels:

@villebro  Oh sorry! I think I misunderstood this feature. The total value is only for stacked bars, right? Like this:

@villebro Oh sorry! I think I misunderstood this feature. The total value is only for stacked chart, right? Like this:

@stephenLYZ yes, precisely 👍  So when stacking is disabled, the "Only total" control will be invisible. And when stacking, it will be available, and only show the total on the top if selected - otherwise it will show the series values (not summed). I think your screenshots look correct!

great work! @stephenLYZ


include food

Spoke has fooddb to foodon identifer mappings - add them to nodenorm

Steps

[ ] Update biolink model to include foodon and umls as allowed prefixes
[ ] add foodon to ubergraph
[ ] update babel to pull foodon from ubergaph, foodb ids from foodbid
[ ] update babel to pull the Spoke mappings and reformat them
[ ] Pull in UMLS/NCIT
[ ] Find UMLS / foodon mappings?

The first two are in progress

@brettasmi do you happen to have or know of mappings from foodon/foodb to umls or ncit?


Plan for cluster support

Is there any plan for cluster support?
Redis 3.0.0 beta has been released for a month.

@brycebaril any updates regarding Redis cluster support? I read there was a refactoring going on, but didn't see any recent updates. Thanks!

+1 for cluster support

+1

Redis cluster is out now, any chance to implement support for it now?

+1

:+1:

+1

+1

@mranney any comments sir?

We (sharelatex.com) would be interested in sponsoring this feature if that helps. I am not sure how much work it would be to develop, potentially a few other companies would pitch in?

There are already two alternative modules which support Redis 3.0 cluster and are better performant than node-redis:
https://github.com/thunks/thunk-redis
https://github.com/luin/ioredis

Very interesting, thanks!
On Wed, Apr 29, 2015 at 12:24 PM, Alisson Cavalcante Agiani <
<EMAIL_ADDRESS>wrote:

There are already two alternative modules which support Redis 3.0 cluster
and are better performant than node-redis:
https://github.com/thunks/thunk-redis
https://github.com/luin/ioredis
—
Reply to this email directly or view it on GitHub
https://github.com/mranney/node_redis/issues/574#issuecomment-97392398.

--
Henry Oswald
shareLaTeX.com co-founder

I'd be happy to try and manage getting cluster support into node_redis. I think I've got a pretty good base at https://github.com/gosquared/redis-clustr (stable in production with many ops). If anyone has suggestions/would like to jump in then go ahead :)

:+1:

In order to better support this project and its new group of collaborators under a new org we are trying to clean up and close issues older than 6 months. Your issue may have been fixed since the issue was open, however, if you are still experiencing a problem please re-open this issue and we will label it accordingly.

Reopening this as it is not resolved. @simontabor would you still be up to try getting cluster support into node_redis?

Yeah. Will need to find some time - hopefully soon!

@simontabor Sounds good :+1:

I'd like to keep cluster as a separate module but usable as default from node_redis. Right now I'm trying to clean up all other things and this is not soon on my list, even though I think it's one of the most important things to be included soon.
So if someone is willing to help out, that would be great! @simontabor you said you won't have the time for it soon but if I remember correct you have a cluster module that could be moved to NodeRedis, if you agree, right?

I've left GoSquared now, and the repo is under that organisation (https://github.com/gosquared/redis-clustr). I think they'd be willing to move the repo to NodeRedis org so long as there's a credit given to them, alternatively NodeRedis could quite easily fork the repo and continue to develop and maintain it over there.

The top of the readme states: "complete and feature rich Redis client", with the absence of cluster support I might debate the usage of the world "complete" here.

... and now I have to migrate to ioredis: https://github.com/luin/ioredis . It is "full-featured" that supports Cluster, Sentinel, and Pipelining.

@gsccheng In the same boat here. I was definitely under the impression that clustering would work.

I using redis 3.2.8 and setup nodes cluster

{ ReplyError: MOVED 8238 <IP_ADDRESS>:6380
at parseError (/home/tanmv/test/node_modules/redis-parser/lib/parser.js:181:12)
at parseType (/home/tanmv/test/node_modules/redis-parser/lib/parser.js:291:14)
command: 'SET',
args: [ 'test-4', 2017-02-27T07:39:07.656Z ],
code: 'MOVED' }

{ ReplyError: MOVED 8238 <IP_ADDRESS>:6380
at parseError (/home/tanmv/test/node_modules/redis-parser/lib/parser.js:181:12)
at parseType (/home/tanmv/test/node_modules/redis-parser/lib/parser.js:291:14) command: 'GET', args: [ 'test-4' ], code: 'MOVED' }

using this module not working.
I have found the module "Redis Cluster Client" (https://www.npmjs.com/package/redis-node-cluster), because before that I have not used so I parked it.
The ruby programming language support has examples in https://github.com/antirez/redis-rb-cluster

no news about this ? everyone who wants cluster feature needs to migrate to ioredis ?

my earlier comment is still 100% relevant: https://github.com/NodeRedis/node_redis/issues/574#issuecomment-169081871. redis-clustr is stable and actively in-use with some pretty big clusters

Ho great, it's a wrapper to this lib "It tries to be as unobtrusive as possible - mimicing the behaviour of the node_redis client.". Thanks @simontabor for the feedback

Indeed, have to move to ioredis package because of this. Didn't knew this package is not supporting clustering. It's a fail...
Why this is a recommended package?
Have to add a bold not in the read me. That this package is not supporting clusters feature. To stop confusing end users.

last update was almost a year ago so I think it's safe to say this library is deprecated.

@thelinuxlich nope. Not deprecated. We have updates that come from upstream (redis-parser and redis-commands) - it just doesn't show in this repo.

Eventually i have migrated to ioredis and successfully integrated sharded cluster. Suggest using ioredis and this team to move to ioredis team, to help them if possible.

As per https://redislabs.com/lp/node-js-redis/

Node_redis’ support for the Cluster API is provided by an additional shim, redis-clustr.

https://github.com/gosquared/redis-clustr

it's 2020, almost 6 years since this issue opened. Hopefully there will be good news.

6 years ago I switched to ioredis for the cluster support

Any update on Cluster support on this?

Any update on Cluster support on this?

Any update for cluster support?


profiler.sh file is missing

I have used async profiler earlier with profiler.sh for flamegraph. This file is missing but README file contains documentation for profiler.sh. This is confusing

Download async-profiler-2.9-linux-x64

Thanks! I have downloaded the aforesaid package. while I ran profiler.sh command
./profiler.sh -d 60 -f /tmp/flamegraph.html PID
it fails with error message
"Failed to inject profiler into PID"

The README refers to the latest release 2.9, which has profiler.sh as a launcher.
In the current version being developed, profiler.sh has been replaced with the binary launcher asprof - see #724 for details. In most cases, profiler commands will work with asprof just the same way as they did with profiler.sh.
As to "Failed to inject profiler" message, it is described in the Troubleshooting section in README. You can also find a number of previous discussions here among github issues. If you profile a containerized application, make sure the container can access profiler library at the same path as on the host. On Alpine Linux, you may also need to install libstdc++ package.


introtext now with mod folder support

we did it patrick we saved the city
(this is very bad please dont merge this

this doesn't look too bad tho

while i could approve of this, this needed a bit of work


SECURESIGN-186 | Enable easy install for Windows

No changes need to be made to the tas-installer for the install to work on windows, this pr just adds some docs related to signing and verifying on windows.

I know squat about running this on windows but as the changes are README only at this point...
/lgtm


How to change the delimiter to ';' for csv when i export a ModelResource

After exporting my ModelResource, the dataset.csv return a csv with ',' as delimiter, is there a way to change the delimiter to ';'
the default behavior gives:
dataset = BookResource().export()
print(dataset.csv)
id,name,author,author_email,imported,published,price,categories,description
2,Some book,1,,0,2012-12-05,8.85,1,some description that contains commas

and i want to get this:
id;name;author;author_email;imported;published;price;categories;description
2;Some book;1;;0;2012-12-05;8.85;1;some description that contains commas

Try using dataset.export('csv', delimiter=';')
dataset = BookResource().export()
print(dataset.export('csv', delimiter=';'))


Is not possible thinger.io + WebSocketsServer.h

Hi.
My project uses websockets. Everything is fine until I insert in the main loop ()
"thing.handle()". Right next comes the call to the socket loop.
Then the loop function of the socket stops working or it does erratically.
There's a solution?

Hi @vicen-t, I would require more information about the lib you are using and how you plan to integrate thinger.io with it.
Jus to know, why do you require to handle web sockets on the device? You can open web sockets over a thinger device, and query stream any resource at the frequency you want.
Best.

Hola Álvaro.
My project is composed of several esp8266 (nodemcu board) located in some rooms of my house. Every esp has a DHT22, and some of them are also connected to a relay or a TIP120 transistor for controlling led lights.
One ESP collects data from other ESP and take decisions. This ESP has a RTC clock and a HC-05 BT and is connected to de wifi/Internet. This ESP is acting as the "server". I can connect with it in a normal port (not websocket) and send orders with any mobile device.
All the ESP communicate using ESP-NOW, but some days ago the protocol stop working without reason. The project was connected to thinger.io over 6 month ago without problems, very solid.
After ESP-NOW collapse, I replaced it with a new own protocol based on websockets and json. The clients send own states to the server and the server send orders based on own decisions or on orders received via normal port throught mobile devices (man decisions).
Everything was good until I re-insert the module thinger.io. I planned to use thinger.io for displaying data over internet and provides a method for sending orders to the server over internet, extending the project outside my house.
Ok, it is a complex project ;)
This is a summary of the server sketch (I dont have access just now to the original code)
#include <WebSocketsServer.h>
#include <ThingerESP8266.h>

...
ThingerESP8266 thing(usuario, device_Id, device_credentials);
WebSocketsServer SOCKET = WebSocketsServer(9999);

...
SOCKET.begin();
SOCKET.onEvent(callbackfunc);
...
// I dont pass wifi parameters to thing object
// I will connect with my own methods later
//thing.add_wifi(WiFi_ssid, WiFi_password);

void loop() {
  SOCKET.loop();
  thing.handle();  // When I insert this line the SOCKET object stop working or work erratically
}

Gracias por tu amabilidad, Álvaro.
Saludos!


Bump version, update doc, Update build

Update docs to provide a better example
Bump version
Nixpkgs not so long ago updated it's "pattern" for how Darwin package are build, which is now more easy and better.

Thank you for your valuable contribution!
LGTM!


[$1000] Magic link fails to sign in on a fresh session

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Start login process to generate a magic link email
Open the magic link in the email in a fresh session (e.g. in incognito), or copy/paste it into an incognito window
Click the "sign in here" link
See a sign-in error

Expected Result:
You should be able to sign in successfully
Actual Result:
Magic code expired message shows
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.16-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/35e59bfa-bfe6-4827-9b17-6eacf2b40778

Expensify/Expensify Issue URL:
Issue reported by: @jjcoffee
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684250997259549
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012148c4a8a95d1ed1
Upwork Job ID:<PHONE_NUMBER>646405120
Last Price Increase: 2023-05-22

Proposal from @jjcoffee
Proposal
Please re-state the problem that we are trying to solve in this issue.
The sign in link doesn't work if the magic link is opened in a fresh session or on a different device.
What is the root cause of that problem?
In the ValidateLoginPage component we check first if the current user has the necessary permissions to use passwordless logins (via the betas prop) here:
https://github.com/Expensify/App/blob/07f17683fff5fee79fdb836aedb3d633d03726e3/src/pages/ValidateLoginPage/index.website.js#L66-L69
However, when we load the magic link in a fresh session we don't have any value for the betas prop as the user is not initialised or validated (this normally happens via BeginSignIn, which returns the available betas for the requested user).
This means we always assume the user doesn't have passwordless login permissions and so we always call ValidateLogin instead, which still requires a password to complete the login.
The "sign in here" link calls signInWithValidateCode directly:
https://github.com/Expensify/App/blob/main/src/components/ValidateCode/ValidateCodeModal.js#L42
But we've already used the code for ValidateLogin so it's been expired on the BE.
What changes do you think we should make in order to solve the problem?
I'm unsure if any users don't have access to passwordless logins anymore, but assuming we still need the check, we can check that the credentials.login is available before checking for permissions (as fresh sessions won't have this value).
So we move this line to the top:
https://github.com/Expensify/App/blob/07f17683fff5fee79fdb836aedb3d633d03726e3/src/pages/ValidateLoginPage/index.website.js#L73
and update this:
https://github.com/Expensify/App/blob/07f17683fff5fee79fdb836aedb3d633d03726e3/src/pages/ValidateLoginPage/index.website.js#L66-L69
to:
if (login && !Permissions.canUsePasswordlessLogins(this.props.betas)) {
We also need to update this line:
https://github.com/Expensify/App/blob/07f17683fff5fee79fdb836aedb3d633d03726e3/src/pages/ValidateLoginPage/index.website.js#L74
To allow for an additional AUTO_AUTH_STATE:
if (!login && isSignedIn && (cachedAutoAuthState === CONST.AUTO_AUTH_STATE.SIGNING_IN || cachedAutoAuthState === CONST.AUTO_AUTH_STATE.JUST_SIGNED_IN)) {
What alternative solutions did you explore? (Optional)
We could also remove the "sign in here" text here:
https://github.com/Expensify/App/blob/07f17683fff5fee79fdb836aedb3d633d03726e3/src/components/ValidateCode/ValidateCodeModal.js#L58-L63
in the case of not having the passwordless login permission. Or we could change the link so that it navigates to the password entry page.
These options seem a bit pointless as I assume we've either already or are nearly there with rolling out passwordless to everyone.

@jliexpensify I got assigned this after I was ooo already 😬 I'll stay assigned to pick it back up on Monday!

All good @adelekennedy - I can take this one.

I've tested on v1.3.16-6 and I can't log in after pasting the link in an incognito window. Video here:
Uploading 2023-05-22_13-53-21.mp4…

Reposting my proposal from above, updated slightly as the behaviour has changed a bit in the meantime. Now you get redirected to the password-based login instead of the magic code displaying with a "sign in here" link.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The sign in link doesn't work if the magic link is opened in a fresh session or on a different device.
What is the root cause of that problem?
In the ValidateLoginPage component we check first if the current user has the necessary permissions to use passwordless logins (via the betas prop) here:
https://github.com/Expensify/App/blob/07f17683fff5fee79fdb836aedb3d633d03726e3/src/pages/ValidateLoginPage/index.website.js#L66-L69
However, when we load the magic link in a fresh session we don't have any value for the betas prop as the user is not initialised or validated (this normally happens via BeginSignIn, which returns the available betas for the requested user).
This means we always assume the user doesn't have passwordless login permissions and so we always call ValidateLogin instead, which still requires a password to complete the login.
The "sign in here" link calls signInWithValidateCode directly:
https://github.com/Expensify/App/blob/main/src/components/ValidateCode/ValidateCodeModal.js#L42
But we've already used the code for ValidateLogin so it's been expired on the BE.
What changes do you think we should make in order to solve the problem?
I'm unsure if the passwordless rollout is fully complete by now, but assuming we still need the check for passwordless permissions, we can check that the credentials.login is available before checking for permissions (as fresh sessions won't have this value).
So we move this line to the top:
https://github.com/Expensify/App/blob/07f17683fff5fee79fdb836aedb3d633d03726e3/src/pages/ValidateLoginPage/index.website.js#L73
and update this:
https://github.com/Expensify/App/blob/07f17683fff5fee79fdb836aedb3d633d03726e3/src/pages/ValidateLoginPage/index.website.js#L66-L69
to:
if (login && !Permissions.canUsePasswordlessLogins(this.props.betas)) {
We also need to update this line:
https://github.com/Expensify/App/blob/07f17683fff5fee79fdb836aedb3d633d03726e3/src/pages/ValidateLoginPage/index.website.js#L74
To allow for an additional AUTO_AUTH_STATE:
if (!login && isSignedIn && (cachedAutoAuthState === CONST.AUTO_AUTH_STATE.SIGNING_IN || cachedAutoAuthState === CONST.AUTO_AUTH_STATE.JUST_SIGNED_IN)) {
As this is the auth state that is returned after the SigninUserWithLink API request completes.
I'm unsure if the BE will run a permissions check for the sign in call, but if it does return any error we could handle that and perform the original ValidateLogin call for users without the passwordless login permission.
What alternative solutions did you explore? (Optional)
If there is an API call we could use that allows to check for a user's validity and permissions using only the account ID (like BeginSignIn but without an email), we could run that on page load if credentials.login is not available.

@jjcoffee Seems there are answers in your slack thread. Kindly update the proposal if required and update here(even if no update is required on proposal) so that we can review it.

@abdulrahuman5196 I have updated my proposal for now, based on the feedback from Slack. I would ideally would need access to a user account without passwordless login permission so that I can test fully what happens (I've also asked for this on slack). Will update once that's done!

@abdulrahuman5196 Okay the conclusion from Slack seems to be that we can assume no more passwords going forwards, so I don't think we need to deal with someone without passwordless permission opening a magic link (verification link in their case) in an incognito tab (as would be the case here). I've updated my proposal to this effect.

@hayata-suenaga  This proposal needs a dive deep and testing to review it. Will try to complete in one day time.

kindly dumping @abdulrahuman5196

@jjcoffee 's proposal here https://github.com/Expensify/App/issues/19214#issuecomment-1556965831 is good. I tested exclusively and seems to be working fine.
🎀👀🎀
C+ Reviewed
cc: @hayata-suenaga

assigning @jjcoffee

Invited @jjcoffee and @abdulrahuman5196 .

Accepted, thanks!
PR coming today.

@abdulrahuman5196 PR is ready for review. Cheers!

Thanks @abdulrahuman5196 . @hayata-suenaga all good with that checklist and regression test?

@jliexpensify yes all look good to me! 👍

@jliexpensify I wonder if this one might still be due the timeliness bonus as I think it was mainly the delay getting the engineer review that pushed it over the 3WD. Timeline was:

assigned 30/5 01:17
PR raised 30/5 16:39
C+ approved 1/6 21:32 (3WD)
Engineer approved - 4/6 15:10
Merged 5/6 23:04

Thanks for considering!

@jjcoffee my understanding is that we pay a bonus based on the PR submission to merge timeline. So there's about a 5-6 day period for this one, which means no bonus is paid out.
Going back in the PR, I notice that @abdulrahuman5196 did ping Hayata for a review but since there are a few revisions, I can't pinpoint the length of time it took Hayata to review.
@hayata-suenaga since you're the assigned engineer, what are your thoughts? Do you think you were delayed in reviewing this? Were you OOO during that time that caused a delay? Thanks!

@abdulrahuman5196 thank you for your info. I agree with you. The comment edit was not a blocker.
it's your final call @jliexpensify 🙇

Awesome, thanks for that context, it's really helpful - and I agree, since it's just outside of the bonus period and it'd could be merged without resolving Hayata's suggestion, I'm happy to pay out the bonus.

@jjcoffee : $1500
@abdulrahuman5196 : $1500

Ok everyone hired, once accepted I'll pay!

@jliexpensify accepted the offer

@jliexpensify Thanks for considering the extra context, much appreciated! Offer accepted too.

Paid, thanks gents!


Training GPU Device minimum Require Specs.

Thanks for your wonderful work.
I saw you used 8 A100 40GB GPUs.
Is it possible to learn with 4 x RTX A6000 GPUs?

Hi @BigJoon,
Thank you for your interest in our work.
Training on 4 x RTX A6000 GPUs is possible. Please set the --gradient_accumulation_steps 2 to match the overall batch size used in our experiments.
Good Luck!

Thanks for your reply, @mmaaz60
I think this work is very interesting. I'll try to make a contribution someday.

Hi @BigJoon,
Thank you for your interest in our work.
Training on 4 x RTX A6000 GPUs is possible. Please set the --gradient_accumulation_steps 2 to match the overall batch size used in our experiments.
Good Luck!

would 2 A30 be able to support the training?

Thanks for your wonderful work.
Is it possible to learn with 1 A100 80 GPUs? Thanks


App restarts after taking a picture. Google Pixel Android 7.1.1

Works fine on Moto 3, Lenovo K5 Plus running Android 5.1.1.
However, after taking a photo on Google Pixel 7.1.1, the app restarts. Choosing image from photo library works fine though.
My Options:
var options = {
  title: 'Select meal image',
  storageOptions: {
    skipBackup: true,
    path: 'images'
  },
  quality: 0.6,
  mediaType: 'photo',
  maxHeight: 2000,
  maxWidth: 1000
};

    getBreakfastImage() {
        this.setState({
            breakfastLogged: true,
        });
        ImagePicker.showImagePicker(options, (response) => {
            if (response.didCancel) {
            }
            else if (response.error) {
            }
            else if (response.customButton) {
            }
            else {
                let source = { uri: response.uri };
                this.setState({
                    breakfastImageCount: this.state.breakfastImageCount+1,
                    imageCountStatic: this.state.imageCountStatic+1
                });
                breakfastImages.push({
                    key: this.state.breakfastImageCount,
                    imageSource: source,
                    imageID: null
                });
                breakfastImages64.push(
                    response.data
                );
                this.setState({ reRender: Math.random() });
            }
        });
    }

CAM_ActivityCloser: WARNING: Activity was artificially finished: CameraActivityController: Intent completed with a valid result. Closing activity.

@rexjrs do you lose the image when activity restarts?

@rexjrs I've got the same issue as yours, when I take a photo, sometimes (not always), the app is restarting. However, I don't have this issue when I choose a photo from library.
Did you manage to fix this?
@haitaoli, as for me, yep.
I'm working with a Nexus 5X, Android 7.1.2

@Blapi Is it always happening if you rotate the phone when taking the picture?

@haitaoli, no, not always. As I said it's only happening just sometimes, and I was not able to reproduce this issue after 20 tries..

@haitaoli I have the same issue, running  Android Marshmallow on Moto G2.
App restarts with splash screen. Since the components are reinitialised, I lose the captured images reference, the image remains saved in phone gallery applications.
Works fine when choosing image from gallery.
"react": "16.0.0-alpha.6",
"react-native": "0.43.3",
"react-native-image-picker": "^0.26.3",

Went though other similar issues, couldn't  find anything that helps.

I experience the exact same issue, random crashes when taking a picture. Choosing from gallery works fine.
Device: Samsung Galaxy S8 (Android 7.0) on Debug as well as Release
"react-native": "0.43.3",
"react-native-image-picker": "^0.26.3"

I have been facing the same issue for long time.
"react-native-image-picker": "^0.24.1",
"react-native": "^0.34.1",
Please help.

It also happens in HUAWEI MT7-CL00 ,Always!

I get the same problem too, in my case, when I take a photo and delay to confirm after about 8 seconds or later, the confirm button did not work or the app is aborting; any solution to fix it?

hi @spidergears ,
could u solve that Issue because am also facing same issue.i searched in google all are telling that downgrade the react-native-image-picker plugin to v0.22.9. for me its not working.can  u try if it works for u

I still not solved this problem but I found it's just happened on Android
7.0 and higher; And when App restarted the picture I took storage at
Pictures fold otherwise it will storage at DCIM fold, so I guess that's the
real problem, but I don't konw how to resolve it.
2017-07-12 14:21 GMT+08:00 gopikrishna<EMAIL_ADDRESS>
hi @spidergears https://github.com/spidergears ,
could u solve that Issue because am also facing same issue.i searched in
google all are telling that downgrade the react-native-image-picker plugin
to v0.22.9. for me its not working.can u try if it works for u
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/react-community/react-native-image-picker/issues/537#issuecomment-314666056,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ-2DJz59NAeD5UInqhXHamVBnFwmQQ9ks5sNGXxgaJpZM4MxSrX
.

Getting the same issue here -- choosing photo from library works fine, but taking a new photo immediately restarts the app.
Device: Huawei P9 Lite.
RN: 0.44.2
react-native-image-picker: 0.26.3

+1

Same here ...

Actually that issue is a duplicate of https://github.com/react-community/react-native-image-picker/issues/732

How can it be a duplicate of 732 when this one is 537?!

@Blapi are you trolling me man 😆 It's just the same problem, that's all I'm saying.

Possible Solution:
There is a high chance that this is not a React Native issue, rather that of your phone(Only Android) settings. Try this:
Go to Settings > Developer options.
Scroll Down till you find "Don't keep activities". Usually it should be under "App" heading.
Disable it IF it's enabled. (If its disabled, then this solution is not for you)
Try running the file upload now. It should work.
****** Description:
Don't keep activities - destroys every activity as soon as the user leaves it.
React native image picker opens system's file system using React-native-fs.
At this point your RN app becomes a background app, which is destroyed by the setting in step 3.
This is the case with all apps that use native file systems. Thats the reason some apps like facebook, messanger, whatsapp etc have their own native filesystem.
Happy coding

facing same issue ...

I was facing the same issue on some older Android phones, but only in development mode. Have you guys checked if the issue remains in production?
Good luck!  👍🏻

@afonsodelgado yes it's in production also. New devices of Mi and Huwai also showing the same issue.

Hey guys, any solution for this?
I'm facing the same problem on my Moto G2 (production and development)
"react-native": "0.49.3"
"react-native-image-picker": "0.26.7"

try on latest version of react
On Wed, May 23, 2018 at 7:48 PM, antonio94js<EMAIL_ADDRESS>wrote:

Hey guys, any solution for this?
I'm facing the same problem on my Moto G2 (production and development)
"react-native": "0.49.3"
"react-native-image-picker": "0.26.7"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/react-community/react-native-image-picker/issues/537#issuecomment-391364249,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALMqgq_zMZPgT_3mnyj5I6nE1DkiZGUjks5t1W-ugaJpZM4MxSrX
.

try on latest version of react and react native
On Thu, May 24, 2018 at 11:25 AM, Hk Xicor<EMAIL_ADDRESS>wrote:

try on latest version of react
On Wed, May 23, 2018 at 7:48 PM, antonio94js<EMAIL_ADDRESS>wrote:

Hey guys, any solution for this?
I'm facing the same problem on my Moto G2 (production and development)
"react-native": "0.49.3"
"react-native-image-picker": "0.26.7"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/react-community/react-native-image-picker/issues/537#issuecomment-391364249,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALMqgq_zMZPgT_3mnyj5I6nE1DkiZGUjks5t1W-ugaJpZM4MxSrX
.

can you ensure if you’re calling the imagepicker function by arrow function?
eg:
PickImage = () => {
Your code
}
....
...
<TouchableOpacity
onPress={() => this.pickImage()}
/>
Here it fails to return back to your app if you write
onPress={this.pickImage()}
Hence, arrow function ()=> is mandatory

This issue is still there. I am using a OnePlus 6T.
"react-native": "0.58.3"
"react-native-image-picker": "^0.28.0"

The issue got fixed when I changed the version in the package.json from "react-native-image-picker": "^0.28.0" to "react-native-image-picker": "0.28.0" and did an npm install.

@AnurajDev But what is the fixed version? Can you check your package lock file and post back?
Thank you

@SudoPlz  Changes were inside the fsevents of package-lock.json.
The thing is the issue was not there while I was testing the app in OnePlus 6T previously. It popped up very recently. So I rolled back to the 0.28.0 version.


Add the ability for bootstrap to manage r53 zones

This change adds the ability for bootstrap to create a r53 zone (when
the proper tag is provided)
This enables use cases where we want to use a delegated zone managed by
SN.

Once this is merged, can we get a new release cut?

LGTM. Added policy changes to the CloudFormation template file as well.


trying to compile the deep-vis version of caffe hangs the system!

When ever I try to compile the deconv-deep-vis-toolbox branch of caffe, it slows down everything to a point where I have to hard-reset the system to get back to the ubunu!.
I dont have such a problem with the official version of caffe.
Whats wrong?

I found the problem, since I have a single core CPU (Intel Pentium G3220), the -j switch made my system hang because it was trying to run the compilation processes in parallel.
removed the -j switch and everything just compiled fine.

Ahh yes, make -j can tax one's system. Closing.


Examples unclear on how to pass props to buttons

How do you pass a custom property such as a 'row id' to an onPress function on your swipeoutBtns? Since these actions are meant to act on list items, this seems like an obvious need. However I can't find how you approach this in any of your examples?
eg.
onPress: function(id) {     console.log('You clicked the button on row ' + id); }
??

Ok so I think I figured out an approach.
`
renderRow: function(rowData) {

    let swipeoutBtns = [
          {
            text: 'Mark as read',
            onPress: () => {
                   this.markAsRead(rowData);
                 },
          }
        ];

return (
      <Swipeout autoClose={true} right={swipeoutBtns}>
 // ... rest of your row render function

`

@bfarrgaynor Could you share a bit more of your code ? I'm having the same issue, and can't quite see how this should work

@SteffenC rather than calling a local function on the list component, I make each item it's own component.
In my main component (the list):
render: function() {

            return (
                <View style={gStyles.listViewMax}>

                       <ListView
                        dataSource={this.state.dataSource}
                        renderRow={this.renderAlert}
                        style={gStyles.jobListView}
                      />

                </View>
             );
},

renderAlert: function(job) {
        return (<AlertListItem alertKeyType={this.state.alertKeyType} job={job} />);
  },

My AlertListItem.js (Component)
 render: function() {

        var myButtons = null;

        if(this.state.read) {
                myButtons  = [
                      {
                        text: 'Mark as Unread',
                        backgroundColor: '#FCA612',
                        color:'white',
                        onPress: () => {
                               this.markRead('markunread');
                             },
                      }
                    ];
         } else {
                myButtons = [
                      {
                        text: 'Mark as Read',
                        backgroundColor: '#FCA612',
                        color:'white',
                        onPress: () => {
                               this.markRead('markread');
                             },
                      }
                    ];

         }

         let swipeoutBtns = myButtons;

        return (<Swipeout autoClose={true} job={this.props.job} right={swipeoutBtns}>
              <View style={gStyles.alertListViewItemContainer}>
                  <View style={gStyles.alertListViewItemContainerButton}>

                          <View style={gStyles.alertListViewItemPersonalDetails}>
                              <Text style={gStyles.alertListViewItemName}>{this.props.job.firstname} {this.props.job.lastname}</Text>
                              <Text style={gStyles.alertListViewItemNote}>{this.props.job.note}</Text>
                              <Text style={gStyles.alertListViewItemTimeAgo}>{this.props.job.datetime}</Text>
                          </View>

                          <View style={gStyles.alertListViewItemReadFlag}>
                            {this.readOrNot()}
                          </View>
                  </View>
              </View>
        </Swipeout>);

... in this way I can use the props or the state on the component to store anything I want about that particular list item.

@bfarrgaynor Beautiful ! Thank you very much!

How to pass the onPress function as a prop to the custom component, here I tried some but not working
` right: [
{
onPress() {
                    const deletingRow = this.state.activeRowKey;
                    const jsonData = this.state.jsonData;

                    Alert.alert(
                        'Delete',
                        'Are you sure you want to delete ?',
                        [
                            { text: 'No', onPress: () => console.log('Cancel Pressed'), style: 'cancel' },
                            {
                                text: 'Yes', onPress: () => {
                                    jsonData.splice(this.props.index, 1);
                                    this.props.parentFlatList.refreshFlatList(deletingRow);
                                }
                            },
                        ],
                        { cancelable: true }
                    );

                },

                component: <SwipeDelete onPressFun={onPress()} />     // here to pass above onPress() ?
            }
        ],

`

It's so simple, the solution is here
` right: [
{
onPress: () => {
                    const deletingRow = this.state.activeRowKey;
                    const jsonData = this.state.jsonData;

                    Alert.alert(
                        'Delete',
                        'Are you sure you want to delete ?',
                        [
                            { text: 'No', onPress: () => console.log('Cancel Pressed'), style: 'cancel' },
                            {
                                text: 'Yes', onPress: () => {
                                    jsonData.splice(this.props.index, 1);
                                    this.props.parentFlatList.refreshFlatList(deletingRow);
                                }
                            },
                        ],
                        { cancelable: true }
                    );

                },
                component: <SwipeDelete />,
            },
        ],`

@rsp8055
could you please create a demo for the same on https://expo.io/snacks/

Here you can find out the example : https://www.youtube.com/watch?v=9qof4eCt9UY


Integration test flakiness

Bug report criteria

[x] This bug report is not security related, security issues should be disclosed privately via netbox operator maintainers.
[X] Existing open issues have been checked and this is not a duplicate.

What happened?
The current integration tests are very flaky thus the integration test CI pipeline can't be enabled
What did you expect to happen?
The integration tests pass consistently when the CI pipeline is enabled
How can we reproduce it (as minimally and precisely as possible)?
Run the integration test with make integration-test
Netbox operator version
Commit 798a3082fc8b6703614da52b613ef89933a8f649
Netbox operator configuration (command line flags or environment variables)
paste your configuration here
Relevant log output
No response
Anything else we need to know?
No response

There are still failures @bruelea @jstudler @alexandernorth that we need to look into, but most of the runs can pass

https://github.com/netbox-community/netbox-operator/actions/runs/10737742627/job/29779850679?pr=46
https://github.com/netbox-community/netbox-operator/actions/runs/10737742089/job/29779849307?pr=45

Let's close this ticket for now and only reopen it if we see flaky tests still! :)

https://github.com/netbox-community/netbox-operator/actions/runs/11017312163/job/30594896657?pr=74

The integration tests are still very flaky. I have to manually trigger retest for almost 1/3 of the commits merged into main, let along the ones that I triggered for PRs.


Type instantiation is excessively deep and possibly infinite.

When using v.any() with combination of v.forward() I get following error:

Type instantiation is excessively deep and possibly infinite.

When v.any() is changed for instance to v.record(v.string(), v.string()) the error dissapears.
Here is the playground link which reproduces this bug.

Fixed in v1.0.0-beta.7 😎


Minor issue in documentation

The documentation for the arosics.CoReg module is currently inconsistent. The default value for the parameter force_quadratic_win and binary_ws of type bool is documented with 1 while all other bool type parameters have either True or False as default values.
This also does not match the class constructor.

Thanks for reporting, this will be fixed soon.

This is fixed in v1.7.2: https://github.com/GFZ/arosics/blob/master/HISTORY.rst#172-2021-11-09.


.Dockerignore files that are a symlink are not ignored

Docker CLI seems to handle symlinks, so we should have Furan match this behavior.

@mikeykhalil I think I have the same issue. The files in .dockerignore that are symlinks are present in the image, and what I expected is those symlinks to be ignored.
If this is also your case, how about you change the title of the issue to ".dockerignore files that are a symlink are NOT ignored"?
Regards.

@mikeykhalil I think I have the same issue. The files in .dockerignore that are symlinks are present in the image, and what I expected is those symlinks to be ignored.
If this is also your case, how about you change the title of the issue to ".dockerignore files that are a symlink are NOT ignored"?
Regards.

Think you are right in that I had a typo in the title, so I updated it. I filed this bug back when Furan was in v1 and it has since had a major version bump and a significant refactor, so I can't really comment on the current status of this issue.


Fix disassembly version

The default version has changed from 1.0 to 1.3, so the assert_eq in the README fails.

Actually this isn't the issue, so don't merge this. It seems like the version in the header is skipped during parse_header. I'll look into it.

I've updated parse_header to parse the version and reused the same Word -> (u8 u8) function which already existed (just moved it to a separate module). This fixes the README and some tests/doctests which seemed incorrect previously.
Let me know what you think.


Implement support for PsbtV2

Context
https://github.com/rust-bitcoin/rust-bitcoin/discussions/1921
Description
All the changes are done assuming this PR has been merged. The first commit contains changes to Input, Output, and PartiallySignedTransaction and introduces PsbtInner and Psbt. Will keep updating this section as more commits are added.

Can you cherry pick the commits from that PR?

Can you cherry pick the commits from that PR?

Yeah, done! Thanks.

Forgive me if I forget the previous context but while reviewing today I could not see the  motivation for creating PsbtInner? Can you tell me please?

Forgive me if I forget the previous context but while reviewing today I could not see the motivation for creating PsbtInner? Can you tell me please?

Thanks for reviewing it! Sorry, I forgot to mention it in the discussion.
Since PsbtInner introduces new optional fields, when a PsbtInner is created it should be validated first (as a PSBTV0 or PSBTV2) to ensure all the required fields of certain versions are present in it. If there would have been only PsbtInner,  all its functions would have needed to first validate it internally before doing further operations, or, developers using the library would need to call the validate function for validation -
// Lets assume PsbtInner is Psbt
pub struct Psbt {
    // all the fields for Psbt
}

impl Psbt {
    // Validate the psbt according to its version
    pub fn validate(&self) -> Result<(), Error> {
        // Some code
    }

    pub fn extract_tx(self) -> Transaction {
         match self.version {
             Version::PsbtV0 => {
                 // Still no guarantee that it is valid PsbtV0
                 // The developer needs to validate it, and here
                 // it is assumed that this psbt is valid and error is returned
                 // when something goes wrong (example below). Or each function needs
                 // to call the `validate` function before doing further operations.
             },
             Version::PsbtV2 => {}
         }
    }
}

// Example
let psbt = Psbt {
    version: Version::PsbtV0
    // do all the assignments
};
psbt.validate()?;
// all further operations assume the above line is present

This PR uses a wrapper Psbt that says "the psbt internally stored is checked and validated". Every non-creator role will be implemented for Psbt only. Hence, all those functions can safely assume the psbt to be already validated.

Oh I get, yep that works. The naming could be change to better express this, I overlooked that from_inner validates and is the only constructor. We can fix naming later. Thanks

Can you try to rebase on top on latest master?

Thanks for implementing review suggestions. Before this is mergable you'll need to rebase and put the changes in the last two patches into the original patch that they modify. In other words, when implementing review suggestions its customary to edit the original change not add a new change on top. For the formatting changes, you can use the githooks so that you catch mistakes during commit (see README).


Fix: oauth2 state encoding

Commit Message:

Changes the state pramater to a json object to store the user state before redirecting the user request to the auth server. Currently, the json object has two fields: the original url and a nonce for csrf prevention.
Changes the state econding to Base64URL to fix  AWS cognito doesn't support url encoded state value
Change the nonce from a plain timestamp to a random number to enhance its security robustness. This addresses the "1. Generation" in this issue https://github.com/envoyproxy/envoy/issues/36276
Small refacor: rename variables related to token_secret to hmac_secret to improve clarity and consistency.

Example:
original state: {"url":"https://localhost:8080/login","nonce":"IPOom6PfIoFS+MmiV04aTJai8vUYlzyO5zUgT2G8mZA="}
base64url encoded state: eyJ1cmwiOiJodHRwczovL2xvY2FsaG9zdDo4MDgwL2xvZ2luIiwibm9uY2UiOiJJUE9vbTZQZklvRlMrTW1pVjA0YVRKYWk4dlVZbHp5TzV6VWdUMkc4bVpBPSJ9
Additional Description: The nonce in the state parameter is used for csrf prevention and is applicable for both oauth2 and oidc. Please note that the OIDC spec defines a seperate nonce parameter ,which is specifically designed to prevent replay attacks and is unique to OIDC.
More discussion about state and nonce parameters and be found in this comment:  https://github.com/envoyproxy/envoy/pull/37050#issuecomment-2510418618
Risk Level:
Testing: Unit test and integration test
Docs Changes:
Release Notes: Yes
Platform Specific Features:
[Optional Runtime guard:] A runtime gurad "envoy.reloadable_features.oauth2_enable_state_nonce" has been added for the new nonce in the state parameter.
[Optional Fixes #37049]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
Related Envoy Gateway issue: https://github.com/envoyproxy/envoy/issues/36871
I've tested this PR against AWS cognito using Envoy Gateway SecurityPolicy, and it worked.
cc @missBerg @arkodg

/assign

LGTM except the example patch. You can create a PR at the envoyproxy/examples. And then, you can update the repo commit in this PR.

LGTM except the example patch. You can create a PR at the envoyproxy/examples. And then, you can update the repo commit in this PR.

https://github.com/envoyproxy/examples/pull/342

@zhaohuabing examples have been updated and the update is now landed in envoy

https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/oauth2_filter.html

Basically, I think this is optional because the state should be transparent for provider and users.

Yes, the encoding and context of the state is an implemenation detail of the oauth2 filter. I think we don't need to expose this to the doc unless it needs to be customized.

@zhaohuabing seems @phlax no explicit objection.
Could you merge main again and then I will merge it.

@wbpcode Merged main branch.
Can we cherry-pick this to v1.32.3 ? This would allow Envoy Gateway v1.2.x to fix https://github.com/envoyproxy/envoy/issues/36871 .


NotoNaskhArabic 2.011 (Bold marks batch 1)

Added bold weight for the following codepoints (https://github.com/googlefonts/noto-fonts/issues/1958)
uni0618
uni0619
uni061A
uni064E
uni064B
uni0650
uni064C
uni0651
uni0654_uni0652
uni0650_uni0655
uni064E_uni0654
uni064D_uni0655
uni0654_uni0652
uni064B_uni0654
uni064B_uni0651
uni0651_uni0670
uni064D_uni0651
uni064E_uni0651
Revised the change to uni0642 fixed https://github.com/googlefonts/noto-fonts/issues/2070

LGTM.
@nizarsq I opened #370 to fix googlefonts/noto-fonts#2085. Feel free to merge it in this branch instead if that's better.


[turborepo] cache request stalls for ~ 50 seconds

What version of Turborepo are you using?
1.9.1
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Linux
Describe the Bug
When running any operation interacting with a remote cache there is a long pause ~50 seconds before the request is made to the cache. This does not occur locally, but only in our CI (Jenkins DIND).
Turning the verbosity of the logs up, ended up seeing there is a unexplained gap:
[2023-04-15T08:20:42.140Z] > turbo run build:web build:server --token=abc123 -vvv
[2023-04-15T08:20:42.140Z]
[2023-04-15T08:20:42.140Z] 2023-04-15T08:20:42.048+0000 [DEBUG] turborepo_lib::shim: Global turbo version: 1.9.1
[2023-04-15T08:20:42.140Z] 2023-04-15T08:20:42.048+0000 [DEBUG] turborepo_lib::shim: No local turbo binary found at: /home/jenkins/agent/workspace/_app_app-feature-ci_PR-412/node_modules/turbo-linux-64/bin/turbo
[2023-04-15T08:20:42.140Z] 2023-04-15T08:20:42.048+0000 [DEBUG] turborepo_lib::shim: No local turbo binary found at: /home/jenkins/agent/workspace/_app_app-feature-ci_PR-412/node_modules/turbo/node_modules/turbo-linux-64/bin/turbo
[2023-04-15T08:20:42.140Z] 2023-04-15T08:20:42.048+0000 [DEBUG] turborepo_lib::shim: Local turbo path<EMAIL_ADDRESS>[2023-04-15T08:20:42.140Z] 2023-04-15T08:20:42.048+0000 [DEBUG] turborepo_lib::shim: Local turbo version: 1.9.1
[2023-04-15T08:20:42.140Z] 2023-04-15T08:20:42.048+0000 [DEBUG] turborepo_lib::shim: Repository Root: /home/jenkins/agent/workspace/_app_app-feature-ci_PR-412
[2023-04-15T08:20:42.140Z] 2023-04-15T08:20:42.048+0000 [DEBUG] turborepo_lib::shim: Running local turbo binary in<EMAIL_ADDRESS>[2023-04-15T08:20:42.140Z]
[2023-04-15T08:20:42.140Z] 2023-04-15T08:20:42.048+0000 [DEBUG] turborepo_lib::shim: supports_skip_infer_and_single_package true
[2023-04-15T08:21:38.310Z] • Running build:web, build:server

Is there anything we should know about when it comes to configuring turborepo? It feels like with verbose logs we could do with some more info to help debugging.
The cache hit/miss both suffer from this pause as well.

Expected Behavior
Cache hit is faster than 50 seconds.
To Reproduce
Turbo config:
{
  "$schema": "https://turbo.build/schema.json",
  "pipeline": {
    "build": {
      "dependsOn": ["build:web", "build:server"]
    },
    "build:web": {
      "inputs": ["src/**/*", "public/**/*", "next.config.js"],
      "outputs": [".next/**", "!.next/cache/**"]
    },
    "build:server": {
      "inputs": ["src/**/*"],
      "outputs": ["dist/**"]
    },
    "lint": {
      "inputs": ["src/**/*"],
      "outputs": []
    },
    "test": {
      "inputs": ["src/**/*"],
      "outputs": []
    },
    "typecheck": {
      "inputs": ["src/**/*", "tsconfig.json"],
      "outputs": []
    }
  }
}

TURBO_REMOTE_ONLY=true NODE_ENV=production pnpm build
Reproduction Repo
Unfortunately this doesn't exist

@admmasters We have close monitoring of performance for cache item response times which is an authentication wrapper around S3. I don't think this is a cache issue. Can you confirm by disabling the remote cache and let me know if the gap goes away?
Is the entire git repository present in Docker? If we don't have the git index we have to manually hash every single file. In a Docker environment file IO can be miserably slow, and those two thing combined would lead to precisely the experience you're describing.
Other things to try:

--no-daemon ... for CI you don't need it and setting up file watches is unnecessary. We may not be detecting that your environment is CI if it's particularly custom.
Upgrade to 1.9.7, it has a lot of improvements to code in that gap.

Thanks @nathanhammond after coming back to Turbo post 1.9.7 I can confirm there has been a LOT of improvements. Now a cache hit is significantly quicker (with no extra config) 👏🏽


Pin Docker :latest image tags to digests

The :latest tag changes, so future pulls of this image may retrieve a different image with different (and possibly erroneous, unexpected, or dangerous) behavior. Pin the image to an image digest for deterministic behavior. See also: Hadolint error DL3007.
Created by Sourcegraph batch change christine/pin-docker-images-xx.

PTAL due Friday

continue to PTAL


Emojis unsupported (vLLM integration)

Hi, using version 0.10.3 and the llama3 tokenizer, with vLLM, I can't seem to constrain to generate emojis.
 curl --request POST \
  --url http://localhost:8000/v1/chat/completions \
  --header 'Content-Type: application/json' \
  --data '{
  "model": "meta-llama/Meta-Llama-3-8B-Instruct",
  "messages": [
    {
      "content": "",
      "role": "user"
    }
  ],
  "guided_decoding_backend": "lm-format-enforcer",
  "guided_choice": ["🐈"],
  "temperature": 0.0,
  "top_p": 0.7,
  "max_tokens": 100,
  "stream": false
}'

[ERROR] Unknown LMFormatEnforcer Problem. Prefix: ''

Even though the tokenizer supports it
tok = AutoTokenizer.from_pretrained("meta-llama/Meta-Llama-3-8B")
tok.encode("🐈")
[128000, 9468, 238, 230]

It might be related to multi-tokens characters, outlines had to deal with similar issues: https://github.com/outlines-dev/outlines/pull/738

Yes, this is a known limitation of the approach taken by LM Format
Enforcer. I will look into how the outlines PR works and see if we can
adapt its approach.
If anyone wants to take a crack at it, they are more than welcome :)
On Thu, Jun 27, 2024 at 3:56 AM milesial @.***> wrote:

Hi, using version 0.10.3 and the llama3 tokenizer, with vLLM, I can't seem
to constrain to generate emojis.
curl --request POST
--url http://localhost:8000/v1/chat/completions
--header 'Content-Type: application/json'
--data '{
"model": "meta-llama/Meta-Llama-3-8B-Instruct",
"messages": [
{
"content": "",
"role": "user"
}
],
"guided_decoding_backend": "lm-format-enforcer",
"guided_choice": ["🐈"],
"temperature": 0.0,
"top_p": 0.7,
"max_tokens": 100,
"stream": false
}'
[ERROR] Unknown LMFormatEnforcer Problem. Prefix: ''
Even though the tokenizer supports it
tok = AutoTokenizer.from_pretrained("meta-llama/Meta-Llama-3-8B")
tok.encode("🐈")
[128000, 9468, 238, 230]
It might be related to multi-tokens characters, outlines had to deal with
similar issues: outlines-dev/outlines#738
https://github.com/outlines-dev/outlines/pull/738
—
Reply to this email directly, view it on GitHub
https://github.com/noamgat/lm-format-enforcer/issues/116, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKFA2E33F7S5V5SRKF2NUTZJNPLJAVCNFSM6AAAAABJ64YMKOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM3TMNJQGM3TANA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Framework not found ReactiveCocoa

I get this error after moving my project to RxSwift and removing ReactiveCocoa dependency from cart file. Do I have to add ReactiveCocoa as a dependency in my cartfile even if I don't use it?

hi @bitomule, it seems you didn't attach any error in the issue. please let me know so i can further investigate.
to answer the question too: no, you should not need reactive cocoa if you only want to use the base Moya-Gloss or RxSwift extension. you should only need to add github "spxrogers/Moya-Gloss" to your Cartfile and install (Moya declares both reactive projects explicitly in its own Cartfile so you'll get those dependencies out of the box). it will compile three frameworks (MoyaGloss, RxMoyaGloss, and ReactiveMoyaGloss), you should only import/link the one you desire.

Hi @spxrogers , sorry. This is the error I get when I do a cat of the log from Carthage build:
ld: framework not found ReactiveCocoa
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@bitomule i see you're using your own fork of Moya-Gloss.
quickly glancing at your latest pull from mine, you are building version 2.0.0 which is behind the latest patch (2.0.1) containing fixes for Carthage build errors.
version 2.0.1 might resolve your issues for you. please update and reply on this issue if that helps or not. if you're still getting the same error (or a new one) i'll investigate further.
also please keep in mind i cannot manage bug fixes on remote forks from the core repository, it'll add too much for me to try and track + manage.

 I'm sorry @spxrogers , the issue was using the fork. I don't remember why I started using it...

no worries @bitomule! i'm glad the latest version solved your issues :)
i welcome and love community PRs for fixes / Swift version updates and i always try to always get to them. unfortunately, with my schedule the past few months my average time to response ranges anywhere between 1-3wks, so that's caused a few forks for updates that i was slow to merge—so i can understand why you might have been doing such


User logged out after an hour or so of inactivity despite using Service Worker implementation

Issue and Steps to Reproduce
A user active on a tab works perfectly fine, but if the same user closes the lid or locks the screen and comes back after a day or even a couple of hours, they are logged out.
Versions
7.22.4
Expected
They shouldn't be logged out, but made to fetch a new access token using the refresh token if that exists, and if this is success, dont log the user out.
Actual
There is a oidc-configuration call that happens from the client side. This API call on failure, simply removes the token and possibly sets the internals to assume that the user has logged out. The api call should have been made on System wake or as long as internet is connected not simply make those calls and reject the user from being continously logged in.
Sorry to say this, its been a bit hard for us to continue using this lib and we are unsure if we will get support on it going forward.

Hi @abhilashlr7 , you are rigth thank you for your issue.
I know how to fix this and I will wheb i will be back from holiday. It is link to service worker lifetime.

Hi @abhilashlr7 thank you for your issue.
I will resolve it in priority when I will be back from holiday.
Temporaly,
You can try to use the new mode where refresh of the token is done only when a fetch is done.
Is is better because it reduce the number of refresh_token and it do it generaly when browser tab is active and have cpu time allowed and internet.


assimp

The upstream assimp repository includes some non-free samples which need to be removed to distribute/build using copr or other Fedora infrastructure.


CDA -> FHIR: name of free text medication (without gtin) is not transformed

Source: CDA File
<name>Préparation magistrale</name>
CDA element name should be transformed in FHIR element Medication.code.text, currently missing

reviewed and tested