_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m  6s
master passed

+1 :green_heart:
compile
0m 42s
master passed

+1 :green_heart:
checkstyle
0m 16s
master passed

+1 :green_heart:
spotless
1m  5s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 45s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 46s
the patch passed

+1 :green_heart:
compile
0m 41s
the patch passed

+1 :green_heart:
javac
0m 41s
the patch passed

-0 :warning:
checkstyle
0m 19s
hbase-rest: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
6m 44s
Patch does not cause any errors with Hadoop 3.3.6.

-1 :x:
spotless
0m 57s
patch has 63 errors when running spotless:check, run spotless:apply to fix.

-1 :x:
spotbugs
1m  2s
hbase-rest generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

31m 15s

Reason
Tests

FindBugs
module:hbase-rest

org.apache.hadoop.hbase.rest.client.Client.executePathOnly(Cluster, HttpUriRequest, Header[], String) uses the nextDouble method of Random to generate a random integer; using nextInt is more efficient  At Client.java:the nextDouble method of Random to generate a random integer; using nextInt is more efficient  At Client.java:[line 280]

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5804/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5804

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 81111b8a0192 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1a089cd393

Default Java
Eclipse Adoptium-11.0.17+8

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5804/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5804/2/artifact/yetus-general-check/output/patch-spotless.txt

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5804/2/artifact/yetus-general-check/output/new-spotbugs-hbase-rest.html

Max. process+thread count
82 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5804/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 48s
master passed

+1 :green_heart:
compile
0m 19s
master passed

+1 :green_heart:
shadedjars
5m 18s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 15s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 55s
the patch passed

+1 :green_heart:
compile
0m 19s
the patch passed

+1 :green_heart:
javac
0m 19s
the patch passed

+1 :green_heart:
shadedjars
5m 48s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
3m 42s
hbase-rest in the patch passed.

23m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5804/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5804

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 404e4a31452d 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1a089cd393

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5804/3/testReport/

Max. process+thread count
1713 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5804/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 18s
master passed

+1 :green_heart:
compile
0m 22s
master passed

+1 :green_heart:
shadedjars
6m  3s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 17s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 44s
the patch passed

+1 :green_heart:
compile
0m 22s
the patch passed

+1 :green_heart:
javac
0m 22s
the patch passed

+1 :green_heart:
shadedjars
6m  2s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
5m  7s
hbase-rest in the patch passed.

28m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5804/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5804

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 89a7d9be4b3f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1a089cd393

Default Java
Eclipse Adoptium-17.0.10+7

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5804/3/testReport/

Max. process+thread count
1668 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5804/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 17s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 32s
master passed

+1 :green_heart:
compile
0m 50s
master passed

+1 :green_heart:
checkstyle
0m 19s
master passed

+1 :green_heart:
spotless
1m 12s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 50s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 29s
the patch passed

+1 :green_heart:
compile
0m 34s
the patch passed

+1 :green_heart:
javac
0m 34s
the patch passed

+1 :green_heart:
checkstyle
0m 13s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
7m 32s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
1m  3s
patch has no errors when running spotless:check.

-1 :x:
spotbugs
0m 57s
hbase-rest generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

33m 42s

Reason
Tests

FindBugs
module:hbase-rest

org.apache.hadoop.hbase.rest.client.Client.executePathOnly(Cluster, HttpUriRequest, Header[], String) uses the nextDouble method of Random to generate a random integer; using nextInt is more efficient  At Client.java:the nextDouble method of Random to generate a random integer; using nextInt is more efficient  At Client.java:[line 273]

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5804/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5804

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux d43d7df10a6c 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1a089cd393

Default Java
Eclipse Adoptium-11.0.17+8

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5804/3/artifact/yetus-general-check/output/new-spotbugs-hbase-rest.html

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5804/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

Adding signed-off headers to kick off another CI run

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 48s
Docker mode activated.


Request to customize GitHub action to simplify workflow configuration

Currently, there are too many duplicates in workflow configuration. But they are very similar in themselves.
Just recently I found a potential solution to simplify the configuration, customizing GitHub action and providing inputs for vary agents, and please see:

https://docs.github.com/en/actions/learn-github-actions/finding-and-customizing-actions#adding-an-action-to-your-workflow
https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions

/kind enhancement

/kind feature

Please see GitHub blog also: https://github.blog/changelog/2021-08-25-github-actions-reduce-duplication-with-action-composition/

I'm willing to try this out.
/assign


Streaming audio from Youtube

Right now I'm trying to implement streaming audio from youtube and came across this discussion and your crate. It's a really great project, but youtube has some idiosyncrasies that I've had to work around to get it to work:
They are described in this really helpful blog post, but essentially to avoid being rate limited a streaming client needs to send various range requests that are all under ~10MB in size. For now this change is working for me with short audio, but I was wondering if adding support for youtube's weird streaming system would be something for this project in the long run?
Happy to help any way I can. Thanks!

Hey @mrhh69, thanks for submitting an issue. I'm not surprised that YouTube is a bit picky about this. Based on your code, it looks like there are two issues:

The GET response doesn't return the content length, but the HEAD request does. It should be simple enough to add a fallback to check this.
The built-in reqwest client doesn't provide a way to customize the stream behavior.

For the second issue, we probably need a new implementation of the stream method in the Response trait that continuously makes range requests until the stream is complete rather than using the bytes_stream method. The pseudocode would look something like this, possibly utilizing the async_stream crate:
stream! {
   for current_chunk in (chunk_start..content_length).step_by(chunk_size) {
       yield client.get_range(current_chunk, current_chunk + chunk_size).await;
   }
}

Are there any other issues you're seeing so far? I probably don't want to add anything too Youtube-specific to this crate, but I'd be happy to extend the core API to make it more flexible if necessary.

@aschey: Sorry, I'm not 100% on how to implement 1. I'm new to rust and not even sure what's meant my this. I'm trying to implement a similar audio streamer for live videos, such as one of those 24/7 lofi videos. Any guidance here would be greatly appreciated.

@cdrani thanks for bringing this up again. I think this take a bit more thought to plan out than I had initially given.
tl;dr on the long response below - Just use yt-dlp or some other dedicated Youtube download tool if you can. If someone wants to integrate this directly into stream-download, it will take a bit of research and planning.
--
Thinking about this some more, I think trying to support YouTube directly will be challenging and require a lot of effort to maintain. YouTube doesn't want external programs using their content so they're not gonna make it easy. Taking a look at yt-dlp, there's over 200k lines of code in that repo.
I think we have a few options here.

Just use yt-dlp in your project directly. There is a Rust wrapper.
Add some logic in your program that will use either stream-download or yt-dlp depending on whether it's a Youtube URL or not.
We modify stream-download to support getting info from yt-dlp or some other Youtube downloader library or external binary.
We add the Youtube logic directly into stream-download.

I'm not in favor of #4 as it will add too much extra maintenance burden for a specific use case. I think implementing #3 would be best, but without getting into the weeds, I can't say for sure what a proper design for that would be. If someone wants to take it on, I'd be happy to discuss the design and/or review a proof of concept. I'm also happy to make any necessary changes to the core traits in order to make them flexible enough.
I will look at implementing this myself eventually if no one else does, but I can't say when. In the meantime, I would recommend yt-dlp as mentioned above.

Got a demo of this working today. Thankfully, it seems to be doable without too much effort. We need to invoke the yt-dlp CLI and tell it to send the output stream over stdout. A tokio::process::Command can then read the output data asynchronously.
The only caveat is that seeking ahead of the downloaded portion won't be supported. It won't cause an error, but it will block the reader until the requested portion has finished downloading. If yt-dlp exposed an option to restart the stream from a byte offset, then it could work just like a normal HTTP stream, but I don't think that option exists (you can start it from a timestamp, but not a byte offset). YouTube downloads seem fairly quick and the initial setup logic that yt-dlp runs when you invoke it takes a few seconds, so I think it's likely faster to wait for the download to catch up anyway.
I couldn't get YouTube live streams to decode properly in Symphonia, but I think that's just a limitation of the formats that Symphonia supports. Nothing we can do about that here.

Turns out the issue with live streams is that yt-dlp doesn't perform realtime format conversion on the output stream in that case. Piping the raw output into ffmpeg before sending it to the decoder seems to do the trick.


Problem turning off RGBW Dimmer

I can control my RGBW LEDs with Siri, turn on, change color, set brightness, but turning them off, siri answers with okay, but the lights remain on.

Solved in v1.0.2


⚠ ClamAV has degraded performance

In b70cc59, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 67 ms

Resolved: ClamAV performance has improved in 2e4a513.


Update vpn-gateway-faq-p2s-all-include.md

Clarified ambiguous verbiage around firewall port 443 for IKEv2 and OpenVPN P2S connection. Updated to explain that port 443 outbound access is needed.

@caseywatson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


(sourcetree) Update release notes URL

Description
Update release notes to current URL
Motivation and Context
URL of release notes have changed
How Has this Been Tested?
Tested locally
Screenshot (if appropriate, usually isn't needed):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[x] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[x] All files are up to date with the latest Contributing Guidelines
[ ] The added/modified package passed install/uninstall in the chocolatey test environment.
[ ] The changes only affect a single package (not including meta package).

:white_check_mark: Package verification completed without issues. PR is now pending human review


hf package upload ledgers

MINA_LEDGER_S3_BUCKET env var now allows overriding the URL where we check for ledger tars.
Hardfork package uploads its ledgers during build, while being careful not to clobber existing tarballs.

!ci-build-me

!ci-build-me

!approved-for-mainnet


Add Ability To Specify Ordered Path Mappings In Project Config

The path mappings loaded from the project are loaded in a way that they are checked for a match in an unordered way. This allows you to specify paths to be checked in a way so more specific paths can match over less specific paths.
...
"ordered_path_mappings": [
["/path/that/is/specific", "/specific/local/path"],
["/path", "/general/local/path"]
]
...
a file '/path/that/is/specific/a.php'  will map to '/specific/local/path/a.php'
a file '/path/whatever.php' will map to '/general/local/path/whatever.php'

I've merged your fixes into my fork:
https://github.com/ryanpcmcquen/SublimeTextXdebugPlus
Which I am attempting to get into Package Control:
https://github.com/wbond/package_control_channel/pull/7658


crashes when trying to open the game

why doesn't the armeabi-v7a option work?, when editing the songlist file and adding the April fools chart file it crashes when opening the game

use 3.5.3c

but in that version it doesn't support April fools chart this year

but in that version it doesn't support April fools chart this year

You can modify 3.12.6 armeabi-v7a yourself


Internal Parse SDK crash

I am getting this error with V:1.14.2
Fatal Exception: NSInternalInconsistencyException
Cannot register subclasses in a bundle that hasn't been loaded!
it looks equal to this : #989
here is the stack trace stack trace
PFObjectSubclassingController.m line 344
-[PFObjectSubclassingController _registerSubclassesInBundle:]

PFObjectSubclassingController.m line 131
__63-[PFObjectSubclassingController scanForUnregisteredSubclasses:]_block_invoke

I have the same crash

I am having this crash too!!!

Having it too, but couldn't reproduced it. Only Apple during a validation process could ATM

We have the same crash.

Any solution?

@nlutsenko i am experiencing same exact crash as others. Would love some help here blocking a release. If you can point me on how to solve issue I can patch it.
@robertodias180 any workaround?
Fatal Exception: NSInternalInconsistencyException
0  CoreFoundation                 0x1928061c0 __exceptionPreprocess
1  libobjc.A.dylib                0x19124055c objc_exception_throw
2  CoreFoundation                 0x192806108 -[NSException initWithCoder:]
3  App                      0x1001f24a4 -[PFObjectSubclassingController _registerSubclassesInBundle:]
4  App                      0x1001f0f88 __63-[PFObjectSubclassingController scanForUnregisteredSubclasses:]_block_invoke
5  Foundation                     0x1931ee24c -[__NSObserver _doit:]
6  CoreFoundation                 0x1927a022c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__
7  CoreFoundation                 0x19279f930 _CFXRegistrationPost
8  CoreFoundation                 0x19279f6ac ___CFXNotificationPost_block_invoke
9  CoreFoundation                 0x19280eb9c -[_CFXNotificationRegistrar find:object:observer:enumerator:]
10 CoreFoundation                 0x1926e1bf4 _CFXNotificationPost
11 Foundation                     0x193246a30 -[NSBundle loadAndReturnError:]
12 UIAccessibility                0x19ec9ad34 -[NSBundleAccessibility loadAndReturnError:]
13 UIAccessibility                0x19ec9c5c4 +[UIAccessibilityLoader __loadActualAccessibilityBundle:didLoadCallback:loadSubbundles:]
14 UIAccessibility                0x19ec9bce4 +[UIAccessibilityLoader _loadAXBundleForBundle:didLoadCallback:forceLoad:loadSubbundles:loadAllAccessibilityInfo:]
15 UIAccessibility                0x19ec9ac50 __70-[NSBundle(UIAccessibilityLoader) _loadAXBundleForBundleOffMainThread]_block_invoke
16 UIAccessibility                0x19ec9bc94 +[UIAccessibilityLoader _loadAXBundleForBundle:didLoadCallback:forceLoad:loadSubbundles:loadAllAccessibilityInfo:]
17 UIAccessibility                0x19ec9a9c0 -[NSBundle(UIAccessibilityLoader) _loadAXBundleForBundleOffMainThread]
18 UIAccessibility                0x19ec9ae08 __44-[NSBundleAccessibility loadAndReturnError:]_block_invoke_2
19 libdispatch.dylib              0x191691200 _dispatch_call_block_and_release
20 libdispatch.dylib              0x1916911c0 _dispatch_client_callout
21 libdispatch.dylib              0x19169f444 _dispatch_queue_serial_drain
22 libdispatch.dylib              0x1916949a8 _dispatch_queue_invoke
23 libdispatch.dylib              0x19169f940 _dispatch_queue_override_invoke
24 libdispatch.dylib              0x1916a138c _dispatch_root_queue_drain
25 libdispatch.dylib              0x1916a10ec _dispatch_worker_thread3
26 libsystem_pthread.dylib        0x19189a2b8 _pthread_wqthread
27 libsystem_pthread.dylib        0x191899da4 start_wqthread

@nlutsenko any ideas or progress on this front?

Also seeing this in production app on iOS.  Does anyone know of a workaround / solution?

@nlutsenko I understand you have other stuff, but its been a month now. Suggestion on how to fix? Or where the issue is cropping up?

Sorry for the delay, but i fixed the problem with this: 8523fbfd0e5a3a976015929ed7d88771306e7ee2

@robertodias180 has that version been released? thanks man! what version of sdk?

@myusuf3 yes it is on release for almost 3 weeks. I changed my parse to that fork (pod 'Parse', :git =>'https://github.com/sirioz/Parse-SDK-iOS-OSX')

why hasn't there been a release with this fix? @robertodias180 i would like to stay on main version here.

@myusuf3 there is PR already

@robertodias180 ahh ok, is there a reason why it will take so much time?

The discussion about this bug is happening in #1006.

@robertodias180 ok, but who can we ping about this?

is a release fixing this problem coming soon? this is affecting many of our users

@fishandphil check this https://github.com/sirioz/Parse-SDK-iOS-OSX it solved the problem for me

Thanks @robertodias180, I was just hoping for an "official" release to come out. But will def go for that branch.


Flood fill in Javascript using p5.js

Implementation of flood fill using the p5.js framework.
I thought it would be nice to have a more visual showcase of the algorithms and p5.js makes this very easy.
If using p5.js is not acceptable, I'm fine with redoing it in node.js in a similar way to the Julia/C implementations. The actual algorithms can stay the same either way.
Link to the p5 sketch: https://editor.p5js.org/delphi1024/sketches/flzb29W1o

I think that an algorithm like flood fill benefits greatly from a graphical output, especially if the language supports this without too much boilerplate code. p5.js is one way to do it and, since it also has a web-based editor, one can try out and experiment with a sketch very quickly.
On the other hand I understand that it is a good idea to keep the implementations consistent across languages, including possible testing code. Using external libraries in general might also be an issue (if they are not related to the algorithm) since these certainly won't be the same across languages.
I am interested to see where this is going as well. In the meantime, I submitted the code again using node.js in a separate PR (#752), so that there is a JS implementation which is more similar to the already existing implementations.

[lang: javascript]

Hi @0xJonas, thank you for your PR.

On the other hand I understand that it is a good idea to keep the implementations consistent across languages, including possible testing code. Using external libraries in general might also be an issue (if they are not related to the algorithm) since these certainly won't be the same across languages.

Since 2020, we have decided we need to work on an output validation system (if you have not followed closely), so I am not sure if p5.js is a good idea for this indeed.
I'll let you the judge of if we need to close this PR :wink:

Yeah, p5.js is definitely not suited well for automatic output validation. I'll close this PR.


Plugin error on Startup // 1.14.4 Paper

The full error can be found here:
https://pastebin.com/5Ue4WJnr
In general I haven't been able to get the latest dev builds working, tried multiple ones and also the newest one from jenkins.

Did you modify the default config? The default config doesn't set default-backend so it appears you have to uncomment and set that yourself.

I'll try and let the plugin generate a new one quickly. I'll inform if it works.

Oh indeed it started up when deleting the config! Thanks.


Your terminal lacks the ability to clear the screen or position the cursor.

how to connect wifi on connected USB
OS : Windows 10

not connect Lan
mdt devices -> OK
mdt shell -> OK
but, nmtui command is "Your terminal lacks the ability to clear the screen or position the cursor."

WSL, Windows bash, cmd (same problem)

connected Lan
mdt devices -> not
mdt shell -> not
Also, USB connection is not possible when wired LAN is connected to the coral board.

WSL, Windows bash, cmd (same problem)

Humn, I haven't seen this one before.
Would this happens over putty or ssh in WSL also?

Hi,
I met similar problem while I use nmtui command to set up wifi. see picture:

It shows "Your terminal lacks the ability to clear the screen or position the cursor."

@harrison0451 Did you try to connect the board with any other host machine as well ?

@harrison0451  try this coomand: nmcli dev wifi connect <NETWORK_NAME> password  ifname wlan0
and then check: nmcli connection show
@kalron90 please try to connect using [https://coral.ai/docs/dev-board/serial-console/](serial console)

@manoj7410 using SSH WSL will solve this problem.


static inline function mocks

I'm trying out the CMock feature for mocking static inline functions in header files, but I cannot get it working...
What I have
I have a flat workspace, which looks like that:
:paths:
  :test:
    - unittest/**
    - softwaretest/**
    - .
  :source:
    - src
    - src/classB-tests
    - src/isotp-c
    - src/tiny-json
  :include:
    - src/Interfaces

where

src contains modulename.c, modulename.h
src/Interfaces contains i_modulename.h.
This is done to sepparate interface header information from implementation defined header information.

What I want to achieve
To increase test coverage in this automotive project, I want to unit test the drivers. For that purpose I have to get rid of all hardware registers and compiler dependend header files, but without creating a new source file. A new header file is created which is filled with static inline functions to wrap all hardware register accesses.
What I did so far
I started with the Architecture Support Package, as it was the first one in my project explorer. I created a header file and filled it with all registers and assembler instructions:
ASP_Registers.h
#include <stdint.h>

#ifdef __XC
#include <xc.h>
#endif

static inline void ASP_INTCON_set(uint32_t value)
{
    INTCON = value;
}

static inline void ASP_PRISS_set (uint32_t value)
{
    PRISS = value;
}
...

adding the path to project.yaml and added also the cmock feature
diff --git a/project.yml b/project.yml
index 01f0667..4331517 100644
--- a/project.yml
+++ b/project.yml
@@ -40,6 +40,7 @@
     - src/tiny-json
   :include:
     - src/Interfaces
+    - src/HardwareRegisters

 :defines:
   # in order to add common defines:
@@ -61,6 +62,8 @@

 :cmock:
   :mock_prefix: mock_
+  :treat_inlines:
+    :include
   :when_no_prototypes: :warn
   :enforce_strict_ordering: TRUE
   :plugins:

Running unit tests creates now:
Compiling test_ASP.c...
In file included from src/ASP.c:14:
src/HardwareRegisters/ASP_Registers.h: In function 'ASP_INTCON_set':
src/HardwareRegisters/ASP_Registers.h:25:5: error: 'INTCON' undeclared (first use in this function); did you mean 'INT8_C'?
     INTCON = value;
     ^~~~~~
...

By looking at the command line:
gcc.exe -I"unittest" -I"softwaretest" -I"src" -I"src/classB-tests" -I"src/isotp-c" -I"src/tiny-json" -I"src/Interfaces" -I"src/HardwareRegisters" -I"D:/Projekte/eclipse workspace/Helmholtz/ceedling/vendor/unity/src" -I"D:/Projekte/eclipse workspace/Helmholtz/ceedling/vendor/cmock/src" -I"build/test/mocks" -DCEEDLING_TEST -DGNU_COMPILER -g -c "src/ASP.c" -o "build/test/out/c/ASP.o" -MMD -MF "build/test/dependencies/ASP.d"

you can see that the include order is the wrong way around. The mocked headers should be included first! So I did:
diff --git a/ceedling/lib/ceedling/configurator_builder.rb b/ceedling/lib/ceedling/configurator_builder.rb
index da8a816..7cf9e18 100644
--- a/ceedling/lib/ceedling/configurator_builder.rb
+++ b/ceedling/lib/ceedling/configurator_builder.rb
@@ -250,8 +250,8 @@ class ConfiguratorBuilder
   def collect_test_support_source_include_vendor_paths(in_hash)
     return {
       :collection_paths_test_support_source_include_vendor =>
-        in_hash[:collection_paths_test_support_source_include] +
-        get_vendor_paths(in_hash)
+        get_vendor_paths(in_hash) +
+        in_hash[:collection_paths_test_support_source_include]
       }
   end

test_ASP.c compiles and runs fine, but it clashes somewhere else:
 Compiling test_ErrorStates.c...
In file included from src/errorStates.h:20,
                 from src/errorStates.c:17:
build/test/mocks/i_errorInfo.h:23:46: error: unknown type name 'uint32_t'
 void errorInfo_faultComponents(char* buffer, uint32_t bufferSize);
                                              ^~~~~~~~

because inclusion of <stdint.h> is not copied from original i_errorInfo.h to the mocked one. This was not an issue before, as ceedling never used the mocked headers because of the wrong include order.
And by the way, I had to add ./ to my include paths, as all mocks use workspace relative paths.
Has someone got this feature running? What am I missing here? Help is pretty much appreciated!
Kind Regards,
Florian Kaup
Sentinel Software GmbH

I'm not following why the order of the include directories would matter in this instance? It's only going to find you mock_ includes in the mock directory, no matter which order you place them in... and it's only going to find the non-mock includes in the other directory, no matter which order they are searched. So the end results should be identical, should they not?
In any case, you'll need to trick your compiler into being able to compile this. If you have a function declared as static inline, and a mock version of that same function declared in a mock, it's going to continue to use the static inline version at best (because they will have already been inlined in the build step) or fail during link due to multiple conflicting definitions.
You can get around this by doing something like this in that header file:
#ifdef TEST
// Mockable API
void ASP_INTCON_set(uint32_t value);
void ASP_PRISS_set (uint32_t value);
#else
// Real API
static inline void ASP_INTCON_set(uint32_t value)
{
    INTCON = value;
}

static inline void ASP_PRISS_set (uint32_t value)
{
    PRISS = value;
}
#endif

If you are going to want to test the low-level wrapper itself (which it sounds like you've decided against this already) you would have to get a little fancier with the defines there and allow for a custom define for testing this specific module.
I hope this helps. If I've misunderstood something, please let me know.

You are right, in the build/test/mock-folder only mock_*-files are present ... As long as you are not using ":treat_inlines: include". With this feature, cmock generates header files, which have the same name as the original ones.
Your idea with the compiler switch looks good, I will take that into consideration as soon as my refactoring is done and I can start testing.
BUT....
With the cmock "treat_inline"-feature, the work of creating special testable header files is done by cmock. The input file src/HardwareRegisters/ASP_Registers.h:
#ifndef ASP_REGISTERS_H_
#define ASP_REGISTERS_H_

#include <stdint.h>

#ifdef __XC
#include <xc.h>
#endif

static inline void ASP_INTCON_set(uint32_t value)
{
    INTCON = value;
}

static inline void ASP_PRISS_set (uint32_t value)
{
    PRISS = value;
}

static inline void ASP_IPC_set (uint8_t reg, uint8_t entry, uint8_t value)
{
    (&IPC0SET)[reg * 4u] = (uint32_t)value << (8u * entry);
}
...

is processed into build/test/mock/ASP_Registers.h:

void ASP_INTCON_set(uint32_t value);

void ASP_PRISS_set (uint32_t value);

void ASP_IPC_set (uint8_t reg, uint8_t entry, uint8_t value);

...

At that point the include order matters.
This new ASP_Registers.h has the appropriate mocks generated, which reside in the same folder.
The compiler searches all include paths until a matching file name is found. So the generated one must be first in paths, else the original static inline functions will be used.
As I mentioned already, these generated header files are missing some system includes (as you can see above, stdint.h is missing). Maybe this is a cmock issue?
Thank you for your quick response!
Kind Regards, Florian Kaup

:) Ah I see. Yes, this is a new feature that some community members have been rolling into CMock. It's possible that it's not fully baked yet? I suspect they're dropping the includes on purpose because they don't want it to try to pull in too much stuff?
You could force it to include those headers by adding to :includes maybe?

Adding to :includes does not solve this, as the includes are put into mock_filename.h, but not into the generated build/test/mock/filename.h. I will check with cmock project for this issue.
What about the include order issue?
https://github.com/ThrowTheSwitch/CMock/blob/master/docs/CMock_Summary.md states:

We have to set the mock folder before the other includes to avoid the test code including the original header instead of the newly generated header (without inline functions).

Yes, I'd appreciate it if you posted the issue on the cmock issues list. While they're all ThrowTheSwitch projects and I'm the primary maintainer of all of them, it is MUCH easier to keep track of things when they're organized. Plus, it'll be easier to get help from those who wrote this feature. :)
I'm understanding now why the include order matters in this instance. It should be a hard change. I'll try tackling that soon. :)

Thank you very much! You can find my proposal to solve this issue in my first post.

You rock. Thanks for being patient with me while I pieced together what you already knew. ;)

Fixed the Ceedling portion of this issue. Thanks!


Back-links: whitelist steps in journey history

Curry the path-matching function for re-use
Check history for matching back-links if referrer is not matched
Unit tests for whitelisting history items

offered as a solution to #38

Closing in favour of #42.


Release Google.Cloud.AccessApproval.V1 version 2.2.0

Changes in this release:
This is primarily a promotion of the previous beta, which includes REST transport support. No API surface changes; just dependency updates.

Created release for Google.Cloud.AccessApproval.V1-2.2.0


Different outcomes: format on save and format entire workspace

Describe the bug
Sorting the classes of the entire workspace and sorting the classes of a single file (either format on save or command) result in different outcome.
To Reproduce
Steps to reproduce the behavior:

Open command palette and sort entire workspace

Check files for any changes. A small number of our components are now changed.
For example, the classes of our button component gets sorted
Original: class="inline-flex items-center tracking-wider transition border border-transparent rounded-lg focus:outline-none focus:ring disabled:opacity-25"
Change: class="inline-flex items-center tracking-wider border border-transparent rounded-lg transition focus:outline-none focus:ring disabled:opacity-25"
Now either format on save or use the other command

The file has been sorted again and is back to the original
Original: class="inline-flex items-center tracking-wider transition border border-transparent rounded-lg focus:outline-none focus:ring disabled:opacity-25"
The button is no longer marked as changed

Other example:
Format entire workspace:
<div       class="py-1 mb-2 text-xs font-bold rounded grid grid-cols-12 bg-grey-300 gap-x-4 text-grey-700"     >
Format on save:
<div       class="grid grid-cols-12 py-1 mb-2 text-xs font-bold rounded bg-grey-300 gap-x-4 text-grey-700"     >
Expected behavior
Both ways of sorting behave the same and do not cancel each other out.
Screenshots
I removed all code from our button but the following and the problem still occurs
Format entire workspace:

... and many more
Format on save:
All files will be reverted to the original.
Desktop (please complete the following information):

OS: macOS Monterey 12.1
Browser: Chrome
Version 96.0.4664.110 (Official Build) (x86_64)

I believe this is a known issue. The packaged version of Rustywind is v0.7.1, but Headwind's own implementation matches the behavior of Rustywind v0.6.7 (which I found out the hard way: by testing them all.)
I've manually installed Rustywind v0.6.7 and use it from the command line instead of relying on the one shipped with Headwind.


Implement optional arguments

Some tags and filters such as slice can have an optional positional argument.

Added in 9c4064d


pipenv install is missing an equivalent to pip's --index-url=

Pipfile allows for defining multiple package sources, by providing multiple named [[source]] sections.
However there's no command line way to add a new package from a specific source.
It would be convenient to be able to call something like:
pipenv install some-private-repo-project --index-url=https://my.repo.lan/simple

And have the resulting Pipfile contain:
[[source]]
url = "https://my.repo.lan/simple"
verify_ssl = true
name = "my-repo-lan"

[dev-packages]

[packages]
some-private-repo-project = {version="*",  index="my-repo-lan"}

[requires]
python_version = "2.7"

I've confirmed that you can create a requirements.txt file of the form:
--index-url https://my.repo.lan/simple
some-private-repo-project

and import it with:
pipenv install -r requirements.txt

and get behavior similar to the desired result, though the index isn't explicitly set on the target package.
But it would be convenient to not have to construct that intermediate requirements.txt file first.

#1980


Missing seeds

Hello. The seed data you used is not found in the code. Would you like to share the seed data you used?

Hello. Thanks for sharing such a nice tool.
Just following @1789120321's issue, would you like to update the seed data and the command line used in the experiment? Specifically, I am interested in how you test C compilers. Did you use the seed programs from GCC or LLVM test suits and how did you add the optimization options to the command line while testing?
Any hints or suggestions are welcome! Thanks and waiting for your reply.
Best wishes,
Haoxin

Hello. We are not going to share the seed inputs for now. But the seeds we use for testing are all from the test suits from the targets we test. For javascript we use https://github.com/tunz/js-vuln-db instead.

how did you add the optimization options to the command line while testing?

This is just the same as how AFL does it because PolyGlot is based on AFL.

Hi @Changochen. Thanks for your reply.
Following your suggestions, I have tried using test suites from https://github.com/gcc-mirror/gcc/tree/master/gcc/testsuite/gcc.c-torture to start testing GCC compiler. But after around 40min running, I got an error from typesystem.cpp, and the assertion tells "afl-fuzz: ../src/typesystem.cpp:646: static void TypeSystem::collect_structure_definition(IR*, IR*): Assertion 'var_name' failed".
I have no idea what happened here. Did you have the same experience before? Or what kinds of code PolyGlot may fail to handle?
Thank you very much!

Sorry for the late reply. I haven't checked the repo for a long time. I think this is because there is an input containing a struct with a struct member without name.
For example,
struct X {
int;
};

PolyGlot assumes the initial seeds are correct and tries to produce correct mutated inputs, and it will filter the testcases it cannot handle during initialization. I only met this problem during development but not fuzzing. Have you modified the C grammar? If not it might be a bug in PolyGlot. One possible solution to fix this is to remove some of the incorrect seeds at the beginning.


I trained bloom7b model but for inference they give me error

This is the code
batch = tokenizer("Two things are infinite: ", return_tensors="pt")

with torch.cuda.amp.autocast():
    output_tokens = model.generate(**batch, max_new_tokens=50)

print("\n\n", tokenizer.decode(output_tokens[0], skip_special_tokens=True))

The error is
AttributeError: 'NoneType' object has no attribute 'device'

Please see https://github.com/huggingface/peft/issues/115, it's probably the same thing.
In my case (using alpaca model) I had to add a device_map parameter:
model = LlamaForCausalLM.from_pretrained(
    model_path,
    load_in_8bit=True,
    torch_dtype=torch.float16,
    device_map="auto",
)
model = PeftModel.from_pretrained(
    model,
    alpaca_path,
    torch_dtype=torch.float16,
    device_map={"": 0}
)

Please see #115, it's probably the same thing.
In my case (using alpaca model) I had to add a device_map parameter:
model = LlamaForCausalLM.from_pretrained(
    model_path,
    load_in_8bit=True,
    torch_dtype=torch.float16,
    device_map="auto",
)
model = PeftModel.from_pretrained(
    model,
    alpaca_path,
    torch_dtype=torch.float16,
    device_map={"": 0}
)

Thank you.
Please I m confused about the second one. You load two model. Which one should need to follow. !!

Sorry, should be the second one, I’ll edit the original comment.


Does this support Web android?

Would this package still work if I am using the web app on an android device?

No. None of the browsers in the market support serial port on mobile. More info here: https://developer.mozilla.org/en-US/docs/Web/API/SerialPort

I see. Thanks for the information.
On Thu, 14 Apr 2022 at 00:52, Mahdi K. Fard @.***>
wrote:

No. None of the browsers in the market support serial port on mobile. More
info here: https://developer.mozilla.org/en-US/docs/Web/API/SerialPort
—
Reply to this email directly, view it on GitHub
https://github.com/xclud/dart_serial/issues/1#issuecomment-1098399963,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASNFCJU2GOEDEOJPIGO7FC3VE4NFLANCNFSM5TLSR4EA
.
You are receiving this because you authored the thread.Message ID:
@.***>

@xclud I haven't been working with browsers much so just wanted to ask if there are any chances we might see serial port functionality on Android browsers in near future, if you happen to have any info about the same.

I don't think this will be possible in the next few years. I didn't hear anything about such a feature for the browsers.
Disclaimer: This is my personal idea.


[Broker] Fix logging in shutdown and improve it

Motivation
By default Log4J2 registers a shutdown hook which stops Log4J2 logging before the broker shutdown has completed. This makes it hard to diagnose issues in broker shutdown.
There's an issue #10289 reported about problems in broker shutdown. This PR will also help to diagnose that issue.
Modifications

add more logging to shutdown
pass -Dlog4j.shutdownHookEnabled=false option to broker and standalone startup
initiate Log4J2 shutdown manually by calling LogManager.shutdown() before the JVM exits
remove outdated code to flush Logback logger before shutdown
print the stacktraces for uncaught exceptions in the broker

/pulsarbot run-failure-checks


Overseerr - Requested by user (Plex or local username) using null instead of user name

Describe the bug
When implementing a rule with the filtering by overseerr user username the firstValue used for comparison is "null" instead of the actual username making the rule always fail
To Reproduce
Steps to reproduce the behavior:

Request movie on overseerr
Implement rule like so:

mediaType: MOVIES
rules:
  - "0":
      - firstValue: Overseerr.addUser
        action: EQUALS
        customValue:
          type: text
          value: <username>

Test rule in collection viewer
Observe that result is false

- plexId: <plexid>
  result: false
  sectionResults:
    - id: 0
      result: false
      ruleResults:
        - operator: OR
          action: equals
          firstValueName: Overseerr - Requested by user (Plex or local username)
          firstValue:
            - null
          secondValueName: text
          secondValue: <username>
          result: false

Expected behavior
Rule should use actual username and provide correct filtering like so:
- plexId: <plexid>
  result: true
  sectionResults:
    - id: 0
      result: true
      ruleResults:
        - operator: OR
          action: equals
          firstValueName: Overseerr - Requested by user (Plex or local username)
          firstValue:
            - <username>
          secondValueName: text
          secondValue: <username>
          result: true

Screenshots
If applicable, add screenshots to help explain your problem.
Device (please complete the following information):

TrueNAS Scale (image from truecharts, latest)
Version [2.0.2]

Additional context
Add any other context about the problem here.

Running into the same issue in 2.0.3

I have the same sort of issue, instead the first value is coming back with my Admin account name.

Is this the initial rule in the first section? If so, it seems the issue isn't directly linked to the rule itself but rather to an error during rule creation. The very first rule shouldn't contain an operator, and if it does, it will cause the rule to malfunction.
If this is indeed the scenario, I recommend exporting your rule, removing the operator from the first rule of the first section, and then re-importing the rule. This should resolve the issue.


Pandas 0.25 breaks plotting

Pandas 0.25 has removed pandas.plotting._style, it's now in pandas.plotting._matplotlib.style. Is there a way to avoid this reliance on a private module of pandas so this break doesn't happen in future (my brief look says no but just in case you have better ideas)?

Yeah, I wasn't happy about having to depend on a private module, but at the time saw no way around it. As a hotfix we can do something like
try:
    from pandas.plotting import _style as plt_style
except ImportError:
    from pandas.plotting._matplotlib import style as plt_style

Maybe it's worth posting to the pandas mailing list to ask for guidance with our specific use case though..

To note, we are now running into this on downstream dependencies: https://github.com/iiasa/message_ix/pull/220


HOTT-811 Adds the field declarable to the search serializers

Jira link
HOTT-811
What?
The reason is that we need to keep declarable in case of fuzzy search too,
which came from elasticsearch.
I have added/removed/altered:

[x] Added declarable in the search heading and commodities serializers
[x] Add the missing tests for those

Why?
I am doing this because:
to help the SWT to check if an entity is declarable.
Have you? (optional)

[ ] Added documentation for new apis
not yet!

Deployment risks (optional)
Risk should be low, since we are adding a new field (and not removing any)

Allowing the STW team to call the FE endpoint is not a good future-proof implementation,
so we decided on exposing a similar implementation on the BE (to be implemented).
That's the reason we are closing this PR, with no merge.


Please add support (or an example) showing how to document when using django_filters

Many people use django_filters to handle API parameters.
If this is already supported, please add an example. If not, this is a feature request. Maybe I will contribute to do this, but wanted to record to the request until then

Neither help_text nor verbose_name seem to be picked up.


Fix some bug risks and code quality issues

Changes:

In podaac/drive.py and podaac/l2ss.py, fix dangerous default argument (mutables) from being passed in methods
In podaac/oceancolor.py, fix one instance where a mix of tabs and spaces was used
Removed unused imports from podaac/drive.py
Removed an instance of superfluous parenthesis from podaac/podaac.py

This PR also adds .deepsource.toml configuration file to run Continuous Quality analysis on the repo with DeepSource. Upon enabling DeepSource, quality analysis will be run on every PR to detect 500+ types of problems in the changes — including bug risks, anti-patterns, security vulnerabilities, etc.
DeepSource is a free to use for open-source projects, and is used by teams at Uber, Stripe, Slack among many others.
To enable DeepSource analysis after merging this PR, please follow these steps:

Signup on DeepSource with your GitHub account and grant access to this repo.
Activate analysis on this repo here.

You can also look at the docs for more details. Do let me know if I can be of any help!
Cheers,
Sanket
Founder, DeepSource

Thank you @sanketsaurav I will go ahead and add DeepSource analysis to this project, thank you.


Update mattermost-v10-changelog.md

Add details about playbooks upgrade bug fix

@amyblais please go ahead and merge if this looks good. Thanks!


Editorconfig and enable prettier for yaml

Since the exclude is only configured in pre-commit. Editors and prettier itself will format yaml files with proseWrap=always. This is a problem for YAML. So why not configure prettier and editors through .editorconfig correctly so that it can be used to enforce proper formatting of YAML files.

Hi @real-yfprojects , thanks for opening this PR!  I've never used editorconfig before, so it's nice for me to learn a new tool.


Update sbt-bloop to 1.5.0-30-571d4c74

Updates ch.epfl.scala:sbt-bloop from 1.5.0-18-003e6c7b to 1.5.0-30-571d4c74.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "sbt-bloop" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "ch.epfl.scala", artifactId = "sbt-bloop" }
}]

labels: sbt-plugin-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #283.


Hello, can you provide the training code?

Thank you for your interest in our work. Right now this paper is being submitted to a conference, so we plan to open source the full code and dataset after the review. We have provided a toy dataset, trained models and processed files for quick verification and visualization.

Okay, good luck and look forward to your full announcement.


Inconsistent Crash - Hard to replicate - Possibly backlink

Goals
Crash-free write transaction
Expected Results
No crash. Successful write transaction
Actual Results
Saw a crash once so far. Unable to replicate. Maybe something to do with backlinks. Crash report and stacktrace attached below
Steps to Reproduce
Unable to reproduce
Code Sample
try! realm.write {
uplodadFile.entryBacklink.first?.engagementBacklink.first?.uploadsComplete = false
}
Crashed: NSOperationQueue 0x18209920 :: NSOperation 0x182c5e30 (QOS: USER_INITIATED)
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000000000000
0  Realm                          0x634606 realm::Table::get_backlink_view(unsigned long, realm::Table*, unsigned long) + 41
stacktrace.txt
Version of Realm and Tooling
ProductName:	Mac OS X
ProductVersion:	10.11.5
BuildVersion:	15F34

/Applications/Xcode.app/Contents/Developer
Xcode 7.3.1
Build version 7D1014

/usr/local/bin/pod
0.39.0
(not in use here)

/bin/bash
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin15)

(not in use here)

/usr/bin/git
git version 2.7.4 (Apple Git-66)

Realm version: 1.0.2
iOS/OSX version: 9.3.2
Dependency manager + version: None

Hi  @sehajc! Thanks for the report, and sorry to hear you're getting this intermittent crash
Could you please give us some more information on what your code is doing when this crash occurs? It looks like you're doing some work on a background thread; would you be able to post some snippets of that code so we can see how you've gone about implementing this?
Unfortunately, if this issue only happens intermittently and it's not possible to reliably trigger it, it's going to be very tricky for us to nail it down. The more information we can get about it, the better. :)
Thanks a lot!
NB: Here's the top part of the stack trace so it's a bit quicker to see than downloading that text file:
 # Crashlytics - plaintext stacktrace downloaded by Sehaj Chawla at Thu, 08 Sep 2016 14:54:41 GMT
# URL: https://fabric.io/limelight-platform/ios/apps/com.limelightplatform.limelightnew/issues/57d12d170aeb16625be390f3/sessions/a379ca052f7d412c9fcf49ca64d8ae3e
# Organization: Limelight Platform
# Platform: ios
# Application: Limelight
# Version: 2.1.5 (3)
# Bundle Identifier: com.limelightplatform.LimelightNew
# Issue #: 38
# Issue ID: 57d12d170aeb16625be390f3
# Session ID: a379ca052f7d412c9fcf49ca64d8ae3e
# Date: 2016-09-07T20:20:58Z
# OS Version: 9.3.2 (13F69)
# Device: iPad 3
# RAM Free: 42.2%
# Disk Free: 94%

#17. Crashed: NSOperationQueue 0x18209920 :: NSOperation 0x182c5e30 (QOS: USER_INITIATED)
0  Realm                          0x634606 realm::Table::get_backlink_view(unsigned long, realm::Table*, unsigned long) + 41
1  Realm                          0x43a1ab RLMGetLinkingObjects(RLMObjectBase*, RLMProperty*) (RLMAccessor.mm:381)
2  Realm                          0x43a1ab RLMGetLinkingObjects(RLMObjectBase*, RLMProperty*) (RLMAccessor.mm:381)
3  Realm                          0x4398df RLMDynamicGet (RLMAccessor.mm:901)
4  RealmSwift                     0x7d59bc LinkingObjects.first.getter (LinkingObjects.swift:491)
5  Limelight                      0x1709c0 UploadOperation.((markAsUploading in _0BF3821BD123B7A4A2D9BC95F8BE1EAC)() -> ()).(closure #1) (UploadOperation.swift:60)
6  RealmSwift                     0x7f2784 Realm.write(() throws -> ()) throws -> () (Realm.swift:776)
7  Limelight                      0x1703cc UploadOperation.main() -> () (UploadOperation.swift:61)
8  Limelight                      0x170910 @objc UploadOperation.main() -> () (UploadOperation.swift)
9  Limelight                      0x16b568 @objc ConcurrentOperation.start() -> () (ConcurrentOperation.swift)
10 Foundation                     0x2287f931 __NSOQSchedule_f + 192
11 libdispatch.dylib              0x21be6423 _dispatch_queue_drain$VARIANT$mp + 1758
12 libdispatch.dylib              0x21be5a61 _dispatch_queue_invoke$VARIANT$mp + 284
13 libdispatch.dylib              0x21be815d _dispatch_root_queue_drain + 396
14 libdispatch.dylib              0x21be7fcd _dispatch_worker_thread3 + 96
15 libsystem_pthread.dylib        0x21d9db29 _pthread_wqthread + 1024
16 libsystem_pthread.dylib        0x21d9d718 start_wqthread + 8

--

#0. com.apple.main-thread
0  libsystem_kernel.dylib         0x21ce2a00 syscall_thread_switch + 8
1  libsystem_platform.dylib       0x21d9975f _os_lock_handoff_lock_slow + 78
2  libobjc.A.dylib                0x21820e57 objc_object::sidetable_release_slow((anonymous namespace)::SideTable&, bool) + 22
3  libobjc.A.dylib                0x21820f37 objc_object::sidetable_release(bool) + 102
4  RealmSwift                     0x7df898 Object.init(realm : RLMRealm, schema : RLMObjectSchema) -> Object + 144
5  Limelight                      0x193a08 @objc EngagementFieldDefinition.init(realm : RLMRealm, schema : RLMObjectSchema) -> EngagementFieldDefinition (EngagementFieldDefinition.swift)
6  Realm                          0x449f87 -[RLMFastEnumerator countByEnumeratingWithState:count:] (RLMCollection.mm:97)
7  Realm                          0x44625b -[RLMArrayLinkView countByEnumeratingWithState:objects:count:] (RLMArrayLinkView.mm:214)
8  libswiftFoundation.dylib       0xd47088 NSFastGenerator.next() -> AnyObject? (__hidden#1408_:704)
9  RealmSwift                     0x7f5d2c RLMGenerator.next() -> A? (RealmCollectionType.swift:995)
10 RealmSwift                     0x7caf10 protocol witness for GeneratorType.next() -> A.Element? in conformance <A where ...> RLMGenerator<A> (Aliases.swift:994)
11 Limelight                      0xf8ed0 specialized AttendeeListViewModel.determineColumnTypes([String]) -> [Column]? (AttendeeListViewModel.swift)
12 Limelight                      0xf4108 AttendeeListViewModel.valueForCells(Engagement, columns : [String]) -> [String] (AttendeeListViewModel.swift:84)
13 Limelight                      0x2412e8 specialized AttendeeListVC.tableView(UITableView, cellForRowAtIndexPath : NSIndexPath) -> UITableViewCell (AttendeeListVC + Tableview.swift:29)
14 Limelight                      0x240e90 @objc AttendeeListVC.tableView(UITableView, cellForRowAtIndexPath : NSIndexPath) -> UITableViewCell (AttendeeListVC + Tableview.swift)
15 UIKit                          0x2692b465 -[UITableView _createPreparedCellForGlobalRow:withIndexPath:willDisplay:] + 672
16 UIKit                          0x2692b5a5 -[UITableView _createPreparedCellForGlobalRow:willDisplay:] + 68
17 UIKit                          0x2691ab51 -[UITableView _updateVisibleCellsNow:isRecursive:] + 2272
18 UIKit                          0x2692fd1b -[UITableView _performWithCachedTraitCollection:] + 78
19 UIKit                          0x266cf23b -[UITableView layoutSubviews] + 178
20 UIKit                          0x265e0a73 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 714
21 QuartzCore                     0x24679bdd -[CALayer layoutSublayers] + 128
22 QuartzCore                     0x24675385 CA::Layer::layout_if_needed(CA::Transaction*) + 348
23 QuartzCore                     0x24675219 CA::Layer::layout_and_display_if_needed(CA::Transaction*) + 16
24 QuartzCore                     0x246746e1 CA::Context::commit_transaction(CA::Transaction*) + 368
25 QuartzCore                     0x246743b5 CA::Transaction::commit() + 520
26 QuartzCore                     0x2466db3b CA::Transaction::observer_callback(__CFRunLoopObserver*, unsigned long, void*) + 138
27 CoreFoundation                 0x2202d6c9 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 20
28 CoreFoundation                 0x2202b9cd __CFRunLoopDoObservers + 280
29 CoreFoundation                 0x2202bdff __CFRunLoopRun + 958
30 CoreFoundation                 0x21f7b229 CFRunLoopRunSpecific + 520
31 CoreFoundation                 0x21f7b015 CFRunLoopRunInMode + 108
32 GraphicsServices               0x2356bac9 GSEventRunModal + 160
33 UIKit                          0x2664d189 UIApplicationMain + 144
34 Limelight                      0x23a6f0 main (AppDelegate.swift:19)
35 libdispatch.dylib              0x21c23873 (Missing)

Hi @sehajc, I'm just following up on @TimOliver's last comment. Have you seen this again since your initial report? Is there any more you could share that could help us reproduce this crash?
Specifically, if you've enabled logging support in Crashlytics, you should be able to recover the log and share the assertion failure that caused this, which may help shed some light on the situation.
Another thing to try is to upgrade to the latest version of Realm (2.0.2 as of this writing) to see if this issue still occurs. Thanks!

Hi @jpsim Sorry for the late reply. That was the only time I saw that crash. Haven't been able to replicate it.

I'll close this because we landed several bug fixes to backlinks since the version you reported was affected (1.0.2). Please reopen if you see this again with the latest version of Realm.


Feature Request: Auto Expand a filtered list

if i try to filter our list of AWS Accounts the Auto expand feature does not work. is it possible to add this as an option as we have many accounts.

Hello!
I did not know before today there was a way to filter accounts and indeed expanding does not work in this case. I'll look into it once I have some free time available.

Much appreciated!

Hi,
I just pushed an updated version that works in the filtered view. It's already available on Firefox's Add-ons, the Chrome Web Store should validate the version in the coming days.

Excellent, Works Great!


"Update Literature Notes" button doesn't update all fields

First of all, thanks a lot for this great plugin!
I followed this post (https://forum.obsidian.md/t/obsidian-zotero-import-templates/56901/2) and added the abstract to the note template by adding the following lines:
> [!abstract]- Abstract
><%= it.abstractNote %>

then I enabled the "Overwrite Existing Note" option.
Here are the steps I did:

Create a literature note, in which I can see the abstract and all annotations
Add one more annotation in Zotero PDF reader and click the "Update Literature Note" button in Obsidian. The annotations in the note are updated.
Modify the literature fields (abstract in my case) and click the "Update Literature Note" button in Obsidian. Nothing happens. The abstract in the note is NOT updated.
Restart Obsidian, and click the "Update Literature Note" button in Obsidian, now the abstract is updated correctly. (Sometimes restarting Obsidian is not enough. I think I have to restart both Obsidian and Zotero).

Is it because

Zotero doesn't write the changes to the Zotero Database immediately after changing the literature fields? (This may not be true, because sometimes I don't restart Zotero and the abstract can be updated).
Obsidian only read the Zotero database once when starting Obsidian? (This may not true, because the annotations are updated correctly without restarting Obsidian).
Other possible causes?

Thanks! "Refresh Zotero Data" works as expected.
I already enabled the following setting, so I thought the database should be automatically refreshed.

Feel free to close the issue if it's not a unexpected behavior.

Good to hear it works! I found that the database refreshes right after an annotation is edited. But it still needs to manually refresh after the doc item property is changed.


Add given method to create pbc for tests

Create a method to create a PBC for controller tests.

/lgtm
/approve


Composition characters mess up insertion point

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
I'm trying out edge (586b818b) since #15314 was merged. I have a command bound to alt-n (a composing diacritic in the macOS US keyboard layout) that moves the cursor. Under Atom 0.19 the keystroke would run the command and insert the diacritic. On this edge version, it only runs the command, which is awesome. 🎉
BUT, it seems like some internal buffer state then gets messed up. If after the alt-n I move the cursor with the arrows, and then insert a character, the cursor seems to jump back to where the alt-n left me, and the character gets inserted there. If I use a command that isn't a composition character, like alt-o, then the problem does not occur.
Steps to Reproduce
Keymap
'atom-text-editor':
  'alt-n': 'core:move-down'
  'alt-o': 'core:move-down'

Add the keymap above to your ~/.atom/keymap.cson
Have two lines of text in your buffer:

Foo
Bar

Have the cursor at the beginning of file(before F character) Type alt-n, then arrow right, then insert a character. Observe that the character is inserted at the beginning of the line (where the alt-n left you).
Repeat 2-3 using alt-o instead of alt-n. Observe the insertion happens where the cursor is, as expected.

Expected behavior: Character insertion following alt-n inserts the character where the cursor is.
Actual behavior: Character insertion following alt-n inserts the character at the wrong place (seems to be where the alt-n leaves you).
Reproduces how often: Always.
Versions
Atom    : 1.21.0-dev-586b818ba
Electron: 1.6.9
Chrome  : 56.0.2924.87
Node    : 7.4.0
OS: macOS Sierra 10.12.6

/cc: @nathansobo @as-cii

I was able to repro this issue with the following repro steps.
screenshot of issue:


Create additional info blocks

Add information about hobbies and interests, or what I like, some interactive content or a joke, an Easter egg, etc.

Add information about hobbies and interests, or what I like, some interactive content or a joke, an Easter egg, etc.


Compile with newest typescript 5.1

Getting errors using the library:
Great docu, however fail to use it.
Error: node_modules/colorsea/dist/index.d.ts:333:9 - error TS2502: 'Color' is referenced directly or indirectly in its own type annotation.

333     var Color: typeof Color;
            ~~~~~

Error: node_modules/colorsea/dist/index.d.ts:343:9 - error TS2502: 'deltaE' is referenced directly or indirectly in its own type annotation.

343     var deltaE: typeof deltaE;

Thank you very much for pointing out the error. The issue has been fixed and you can update to the latest version (v1.2.2). If you find any more problems, please continue to submit issues to me. thank you.


[QUESTION] Check validity of setup.py in build

H/T to http://inre.dundeemt.com/2014-05-17/pypi-setup-py-keeping-a-dry-long_description/ (I was Googling around for DRY in setup.py)
python setup.py check --restructuredtext --strict

For example, running it on the post #2442 version gives:
$ python setup.py check --restructuredtext --strict
running check
warning: check: Duplicate implicit target name: "contributing".

warning: check: Duplicate implicit target name: "license".

error: Please correct your package.

because we have sections named license and contributing as well as links with those names. This could be fixed via
diff --git a/README.rst b/README.rst
index 715368b..bbf0f72 100644
--- a/README.rst
+++ b/README.rst
@@ -96,16 +96,16 @@ Contributing

 Contributions to this library are always welcome and highly encouraged.

-See `CONTRIBUTING`_ for more information on how to get started.
+`See CONTRIBUTING`_ for more information on how to get started.

-.. _CONTRIBUTING: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/CONTRIBUTING.rst
+.. _See CONTRIBUTING: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/CONTRIBUTING.rst

 License
 -------

-Apache 2.0 - See `LICENSE`_ for more information.
+Apache 2.0 - `See LICENSE`_ for more information.

-.. _LICENSE: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/LICENSE
+.. _See LICENSE: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/LICENSE

 .. |build| image:: https://travis-ci.org/GoogleCloudPlatform/google-cloud-python.svg?branch=master
    :target: https://travis-ci.org/GoogleCloudPlatform/google-cloud-python

We should do this. Google-auth does it.

@jonparrott Jinx! I'm going to send a PR for adding this to nox -e lint for the subpackages. Should I add a nox -e lint for the top-level package?

I would prefer it be a separate nox session if possible.


"Export Result Set" from temp tables error on second temp table export when running in the pending transaction

Description
From this discussion, I know that I need to leave the "Open new connection(s)" unchecked from the Data Transfer modal window to export a Temp Table result set.

But, even with that, when running inside a transaction, the second attempt to export a temp table result set fails with:
SQL Error [42P01]: ERROR: relation "tmp2" does not exist
Position: 15

just as if it was creating a new connection. It doesn't matter if I try export the same result set twice or another result set.
DBeaver Version
Community Edition v<IP_ADDRESS>410201725
Operating System
Microsoft Windows 11 Pro 10.0.22631.4317
Database and driver
Server: PostgreSQL 14.10 on x86_64-pc-linux-musl, compiled by gcc (Alpine 12.2.1_git20220924-r10) 12.2.1 20220924, 64-bit
Driver: PostgreSQL JDBC Driver 42.2.5
Steps to reproduce

Run the following script

BEGIN TRANSACTION;

CREATE TEMP TABLE tmp1 AS
SELECT 1;

CREATE TEMP TABLE tmp2 AS
SELECT 2;

SELECT * FROM tmp1;
SELECT * FROM tmp2;

-- ROLLBACK; (Please note that the ROLLBACK is commented out (I'm running a migration test).)

Export the first result set (Do not check "Open new connection(s)")
Repeat step 2.

Additional context
No response

thanks for the bug report


2.0.12-rc.4 - can't open file on Windows

2.0.12-rc.4 Pre-release seems promising on non-Windows, but seems broken on winows 10. Installed with the setup.exe installer.
I get this error in the bottom-left after I select a file:

Problem exists in rc1, rc3, and rc4 as well. Didn't test rc2, but I'm sure it's there also.
Downgrading to 2.0.11 fixed it! I'd say it was a change from 2.0.11 to 2.0.12 rc1.

@DeflateAwning thanks for reporting this, but can I ask you to stick to the template? Thank you :)

@DeflateAwning I think technically it is not related to the Windows release. It might be a general bug in connection with existing persisted filters. But it is just guessing on my end, since I don't have enough information.
However one thing stuck out over the last releases. I included an adjustment in RC5 and wonder if this fixes the issue, let me know: https://github.com/ransome1/sleek/releases/tag/v2.0.12-rc.5

Appears to be fixed, thanks! The issue was only happening on my Windows computer, which lead me to believe the issue was related to that


Maven/Gradle support for v0.2

I see that https://github.com/dagger/dagger/pull/751 added support for v0.1 pipelines but it doesn't seem to be supported anymore.
Is anyone working on it? Else, I'm willing to pick it up.

Duplicate of https://github.com/dagger/dagger/issues/1615. Lets continue the discussion there. I'm currently not working on it, but I can help with this if you'll pick it up


Detect when "cargo fuzz init" is run on a binary package instead of a library package

I was trying out cargo fuzz init on a rust project that only had a main.rs but no lib.rs. As a consequence, the generated file fuzz_target_1.rs failed to build:
$ cargo fuzz run fuzz_target_1
       Fresh cc v1.0.8
       Fresh arbitrary v0.1.0
       Fresh libfuzzer-sys v0.1.0 (https://github.com/rust-fuzz/libfuzzer-sys.git#4594b1f3)
   Compiling merge-dags-fuzz v0.0.1 (file:///Users/mstange/code/merge-dags/fuzz)
[...]
error[E0463]: can't find crate for `merge_dags`
 --> fuzz_targets/fuzz_target_1.rs:3:1
  |
3 | extern crate merge_dags;
  | ^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
error: Could not compile `merge-dags-fuzz`.

It would be nice to detect this condition and show a more helpful error message.

The way I'm working around this is by putting all my code in a lib crate and then just invoking the lib from src/main.rs and the specific function I want to fuzz from the fuzz target.

The way I'm working around this is by putting all my code in a lib crate and then just invoking the lib from src/main.rs and the specific function I want to fuzz from the fuzz target.

How can I do that? I assume you're making 2 distinct crates, then.
I'm barely a novice with cargo and the module system, though. Is there a tutorial for this? It would also be nice to be able to have my lib crate in a local directory, because I can't currently publish it.

@felix91gr it's as simple as creating both src/lib.rs and src/main.rs. This can be done within the same crate, you can have a look at an example project (that also uses cargo-fuzz) over here.


Fix quality tasks

Proposed changes
Update poe tasks to add checks in addition to fixes, use checks in the GH quality actions, and fix outstanding files.
Types of changes
What types of changes does your code introduce? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionalitiy)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Other (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

[ ] Changes have been tested to ensure that fix is effective or that a feature works.
[ ] Changes pass the unit tests
[ ] Code has been run through the poe quality task
[ ] I have included necessary documentation or comments (as necessary)
[ ] Any dependent changes have been merged and published

Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

wonder if it using extend-ignore=<code> would work instead of having an # ignore <code> for flake8

This would work but I'd generally rather not do it so we see legitimate cases of this error -- I tried to document why I was disabling it in each case instead.


Add authorization to all endpoints

As a Trace-X admin, (ROLE_ADMIN)
I want to have all my endpoints secured via a Trace-X role,
so that my application is secured against unwanted access.
Blocker
We do not have a technical user on INT environments. Therefore, we need a concept how to authenticate (e.g. API key?)
Hints / Details

for example,  is not secured with any role. This could be resolved with adding:
@PreAuthorize("hasAnyRole('ROLE_ADMIN', 'ROLE_SUPERVISOR', 'ROLE_USER')")
All endpoints of https://github.com/eclipse-tractusx/traceability-foss/blob/c746f1d63875a3626e20019fd7ca63990a5f3175/tx-backend/src/main/java/org/eclipse/tractusx/traceability/submodel/application/rest/SubmodelController.java#L50 are unprotected.
Acceptance Criteria

[x] all endpoints need at least the ROLE_USER role for allowed usage (SubmodelController)
[x] Insomnia collection is updated and published to team members
[x] documentation is updated
[x] frontend provides additional view for triggering private api endpoints (sync, /api/registry/reload $assetId)

[x] usage of C-X style guide
[x] User feedback executing action - Reasonable message mapping http status code.

Out of Scope

...

Open Topics to Discuss:
Called from our Dataplane
These paths could be secured via network settings -> only access allowed within the cluster.

/qualitynotifications/receive
/qualityalerts/receive
/qualitynotifications/update
/qualityalerts/update
/callback/endpoint-data-reference
/internal/endpoint-data-reference

Used by IRS to Send Job Completed Info

/irs/job/callback
Currently, in IRS, there is no mechanism for authentication. It would be easy to work with a key within the jobRegistration. This key could be transferred to the /irs/job/callback address and validated to ensure that the request is acceptable.

Issue 1:
OPTION: Using API Keys instead of OAuth 2.
FIRST APPROACH: In my understanding, this option does not fit the goal of this story to secure the api endpoints in general.
SECOND APPROACH: Here I need some more details to understand what is extended here.

Target solution is to secure the endpoints via OAuth2  or API Key. We create a ticket for the target solution.
Now FIRST APPROACH will be implemented.

As discussed the following was defined:
Issue 1: We will use approach one and secure the apis to be only accessible within the kubernetes cluster.
As a long term solution we created a story: https://github.com/eclipse-tractusx/traceability-foss/issues/1132
Issue 2: IRS will evaluate an approach of how they can accept a authentication parameter. So that trace-x can use it to secure the api..

No insomnia update required.
Internal accessible APIs are returning a 404 from outside of the cluster:

Will be added to Known Knowns. @ds-mwesener

Tested on E2E: Cannot access endpoints through Insomnia. I get a 404 for all of them.
However, internal requests are failing as well. Sending notifications does not work currently and in the logs an identical error is mentioned: 2024-07-03T08:26:16.066Z  WARN 1 --- [nio-8080-exec-7] o.e.t.t.c.config.TrustedEndpointsFilter  : /api/internal/qualitynotifications/receive
2024-07-03T08:26:16.066Z  WARN 1 --- [nio-8080-exec-7] o.e.t.t.c.config.TrustedEndpointsFilter  : denying request for trusted endpoint on untrusted port

Hi @ds-crehm as discussed the public api should return 404 on the internal apis. I have fixed the behaviour that the notification callback apis used the wrong url. Now it should work please validate.

Tested on dev/test & E2E: Notifications can be sent again now. Endpoints are properly secured.
Ready for review.


change the resync interval to 12 hours

Signed-off-by: Rajat Chopra<EMAIL_ADDRESS>Discovered while testing on a large cluster of 40 nodes, 3000 pods and 5000 namespaces: we constantly spin over all resources every 10 minutes. This is needlessly aggressive, especially because we do not have a situation where a resync is needed.

@tong101 Fixed. Thanks.

Looks good to me as well. Would it be better to be configurable from the config file as well?

Would it be better to be configurable from the config file as well?

I think it's not needed. Only if we introduce code that depends on the resync interval.


NUDE and NUDENFT tokens -> Polygon.

We are going to move to Polygon network.
This will be epic.

We are on Polygon Mumbai testnet now!


TLS 1.3 handshakes fails with clients that do not announce RSA PSS* signature algorithms

Problem:
There are some clients that can handshake TLS 1.2 with s2n successfully but fails to handshake TLS 1.3 as they do not present RSA PSS* signature scheme that is required to verify a RSA cert.
This causes TLS handshakes to fail if the server choses to upgrade to TLS 1.3.
Here is a sample ClientHello
 ciphers   = [TLS_AES_128_GCM_SHA256, TLS_AES_256_GCM_SHA384, TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, TLS_RSA_WITH_AES_256_GCM_SHA384, TLS_ECDH_ECDSA_WITH_AES_256_GCM_SHA384, TLS_ECDH_RSA_WITH_AES_256_GCM_SHA384, TLS_DHE_RSA_WITH_AES_256_GCM_SHA384, TLS_DHE_DSS_WITH_AES_256_GCM_SHA384, TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, TLS_RSA_WITH_AES_128_GCM_SHA256, TLS_ECDH_ECDSA_WITH_AES_128_GCM_SHA256, TLS_ECDH_RSA_WITH_AES_128_GCM_SHA256, TLS_DHE_RSA_WITH_AES_128_GCM_SHA256, TLS_DHE_DSS_WITH_AES_128_GCM_SHA256, TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384, TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384, TLS_RSA_WITH_AES_256_CBC_SHA256, TLS_ECDH_ECDSA_WITH_AES_256_CBC_SHA384, TLS_ECDH_RSA_WITH_AES_256_CBC_SHA384, TLS_DHE_RSA_WITH_AES_256_CBC_SHA256, TLS_DHE_DSS_WITH_AES_256_CBC_SHA256, TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, TLS_RSA_WITH_AES_256_CBC_SHA, TLS_ECDH_ECDSA_WITH_AES_256_CBC_SHA, TLS_ECDH_RSA_WITH_AES_256_CBC_SHA, TLS_DHE_RSA_WITH_AES_256_CBC_SHA, TLS_DHE_DSS_WITH_AES_256_CBC_SHA, TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256, TLS_RSA_WITH_AES_128_CBC_SHA256, TLS_ECDH_ECDSA_WITH_AES_128_CBC_SHA256, TLS_ECDH_RSA_WITH_AES_128_CBC_SHA256, TLS_DHE_RSA_WITH_AES_128_CBC_SHA256, TLS_DHE_DSS_WITH_AES_128_CBC_SHA256, TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, TLS_RSA_WITH_AES_128_CBC_SHA, TLS_ECDH_ECDSA_WITH_AES_128_CBC_SHA, TLS_ECDH_RSA_WITH_AES_128_CBC_SHA, TLS_DHE_RSA_WITH_AES_128_CBC_SHA, TLS_DHE_DSS_WITH_AES_128_CBC_SHA, TLS_EMPTY_RENEGOTIATION_INFO_SCSV]
  complen   = 1
  comp      = null
  extlen    = 287
  \ext       \
   |###[ TLS Extension - Certificate Status Request ]###
   |  type      = status_request
   |  len       = 5
   |  stype     = ocsp
   |  \req       \
   |   |###[ OCSPStatusRequest structure ]###
   |   |  respidlen = 0
   |   |  \respid    \
   |   |  reqextlen = 0
   |   |  reqext    = ''
   |###[ TLS Extension - Supported Groups ]###
   |  type      = supported_groups
   |  len       = 32
   |  groupslen = 30
   |  groups    = [secp256r1, secp384r1, secp521r1, sect283k1, sect283r1, sect409k1, sect409r1, sect571k1, sect571r1, secp256k1, ffdhe2048, ffdhe3072, ffdhe4096, ffdhe6144, ffdhe8192]
   |###[ TLS Extension - Supported Point Format ]###
   |  type      = ec_point_formats
   |  len       = 2
   |  ecpllen   = 1
   |  ecpl      = [uncompressed]
   |###[ TLS Extension - Signature Algorithms ]###
   |  type      = signature_algorithms
   |  len       = 32
   |  sig_algs_len= 30
   |  sig_algs  = [ed25519, ed448, sha256+ecdsa, sha384+ecdsa, sha512+ecdsa, sha256+rsa, sha384+rsa, sha512+rsa, sha256+dsa, sha224+ecdsa, sha224+rsa, sha224+dsa, sha1+ecdsa, sha1+rsa, sha1+dsa]
   |###[ TLS Extension - Signature Algorithms Cert ]###
   |  type      = signature_algorithms_cert
   |  len       = 32
   |  sig_algs_len= 30
   |  sig_algs  = [ed25519, ed448, sha256+ecdsa, sha384+ecdsa, sha512+ecdsa, sha256+rsa, sha384+rsa, sha512+rsa, sha256+dsa, sha224+ecdsa, sha224+rsa, sha224+dsa, sha1+ecdsa, sha1+rsa, sha1+dsa]

The associated JA3 fingerprint is
ja3_string:
771,4865-4866-49196-49195-49200-157-49198-49202-159-163-49199-156-49197-49201-158-162-49188-49192-61-49190-49194-107-106-49162-49172-53-49157-49167-57-56-49187-49191-60-49189-49193-103-64-49161-49171-47-49156-49166-51-50-255,0-5-10-11-13-50-17-23-43-45-51,23-24-25-9-10-11-12-13-14-22-256-257-258-259-260,0

hash:
849d3331f3e07a0797a02f12a6a82aa9

Solution:
2 potential solutions for S2N are

optimistically roll forward, allowing the s2n server to pick a RSA-PSS-RSAE signature scheme even if the client does not advertise about it.
modify the handshake selection process such that if the server is unable to negotiate TLS 1.3 but TLS 1.2 to fallback to select a TLS 1.2 mode instead.

A description of the possible solution in terms of S2N architecture. Highlight and explain any potentially controversial design decisions taken.

Does this change what S2N sends over the wire? If yes, explain.
Does this change any public APIs? If yes, explain.
Which versions of TLS will this impact?

Requirements / Acceptance Criteria:
What must a solution address in order to solve the problem? How do we know the solution is complete?

RFC links: Links to relevant RFC(s)
Related Issues: Link any relevant issues
Will the Usage Guide or other documentation need to be updated?
Testing: How will this change be tested? Call out new integration tests, functional tests, or particularly interesting/important unit tests.

Will this change trigger SAW changes? Changes to the state machine, the s2n_handshake_io code that controls state transitions, the DRBG, or the corking/uncorking logic could trigger SAW failures.
Should this change be fuzz tested? Will it handle untrusted input? Create a separate issue to track the fuzzing work.

Out of scope:
Is there anything the solution will intentionally NOT address?

As a note, Option 1 is in keeping with the RFC: https://tools.ietf.org/html/rfc8446#section-<IP_ADDRESS>
"If the server cannot produce a certificate chain that is signed only
via the indicated supported algorithms, then it SHOULD continue the
handshake by sending the client a certificate chain of its choice
that may include algorithms that are not known to be supported by the
client.  This fallback chain SHOULD NOT use the deprecated SHA-1 hash
algorithm in general, but MAY do so if the client's advertisement
permits it, and MUST NOT do so otherwise."


[$1000]  FAB menu not opening on new Registration

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Platform A: Logout if logged in
Platform B: Register with new Email
Platform A: Open magic code link -> Click 'just sign in here'

Expected Result:
It should show FAB menu when Logging in for very first time
Actual Result:
Does not show FAB menu when logged in with magic code link on another device
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:
Reproducible in staging?: needs reproduction (applause team could not reproduce)
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/5278149d-c129-4338-81c4-f99fe88fb136
Expensify/Expensify Issue URL:
Issue reported by: @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692186526922569
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019d7177db6deed95f
Upwork Job ID:<PHONE_NUMBER>401539584
Last Price Increase: 2023-09-21

@garrettmknight
Still able to reproduce! Checked on Desktop/Chrome, make sure you don't have any login on that device.

I tried to registering from Mobile app
Received mail on desktop -> All instance were logged out from desktop
I clicked on the link magic SignIn link from magic code email
It showed me Magic code and option 'just sign in here' -> Click on 'just sign in here'

Attaching full video again:
https://github.com/Expensify/App/assets/58871336/eae19662-bc1d-47d5-a5fa-446cf49880b5

Still having trouble reproducing:

Signed out of both staging and prod in Chrome + signed out of the desktop app and closed it.
Signed up for a new account on the mobile app.
Clicked "Click here to sign into your Expensify account, like magic! 🪄" from the email on my desktop.
That opened a magic code page without the ",or just sign in here" option:

I had to clear my onyx local storage to reproduce, but I was able to.

Should be fixed in this PR. cc @garrettmknight

@garrettmknight @jjcoffee
I just checked that, My Issue log time is earlier than this.

Good call @jjcoffee, I'm going to close this as a dupe issue and suggest that @DinalJivani get the reporting payment.

@garrettmknight
Can you please reopen this bug, The linked bug and PR is merged but this issue is Still reproducible.
Check comments from here

@garrettmknight  bump ^^

Reopening to test tomorrow.

Thanks for the bump @DinalJivani - i was able to repro this time. Opening up.

Is it possible to reproduce it in development? The "Click here to sign in to your Expensify account, like magic!" link always opens production but  after changing the URL from prod to localhost and opening it, instead of the magic code, I got this screen

Changing to external, we waited to open this report up for outside proposals until another potential root bug was fixed.

I just tested this one again and I'm getting the above screen when I signup using a different browser/platform. @DinalJivani can you test and see if you're getting the same?

@garrettmknight
Still reproducible! Able to reproduce with same steps, Check full video below.
https://github.com/Expensify/App/assets/58871336/a0f806ed-e362-4bfa-906d-b1825a3bb1e8
Steps:

Logout of all instances, Staging and New
Register with new Email
Open magic code email -> Click 'Click here to sign into your Expensify account, like magic! 🪄'  Link
On magic code page -> Click on 'just sign in here'  Link

Thanks for reproducing - @ArekChr following those steps, are you having any luck on prod?

@ArekChr can you review this when you get a chance?

The proposal from @dukenv0307 looks good and seems quite straightforward. Could you share the outcomes resulting from this change? There are different behaviours between staging and dev, which I didn't have a chance to get to.

@tsa321 The proposal is about adding ValidateLogin to the white list screen, not to remove this check

@tsa321 You're right. The fab menu will show on the abracadabra page. Let's prevent making the same regression again. thanks for the details. Your proposal looks good to me.
:ribbon: :eyes: :ribbon: C+ reviewed

Summary of payments:

Urgency Bonus: Yes
Reporter: @DinalJivani $250 awaiting payment: https://www.upwork.com/en-gb/nx/wm/offer/27336930
Contributor: @tsa321 $1500 awaiting payment: https://www.upwork.com/en-gb/nx/wm/offer/27336930
Reviewer: N/A

@garrettmknight
Offer accepted! Thanks

All paid up


Is this thing on?

This is such a great project, I can see nothing much happened in the last year.
Is development for this still happening? Should I switch to any of the forks?

Hi @ditorelo! Yep, this project is still very much alive! (And your second question piqued my curiosity—I just looked at all of the forks and none of them appear to be active at all.)
While I disagree slightly with your characterization that nothing much happened in the last year, I take your point—it's hard to see whether a project should be used or not if it doesn't have a ton of commits. Thanks for reaching out to ask.
The thing is, I don't get a lot of issues or PRs. Without these to tell me what features folks would like, I'm left developing primarily for myself, and at this point I'm happy enough with friends as-is that I don't feel a ton of pressure to add more features or improvements. I do occasionally make improvements but I'd do them 1000x faster if they were in response to requests from external users.
So the short answer is:

This project is alive and well.
Please use issues and PRs to let me know what improvements you'd like to see! I try to respond pretty quickly.

Enjoy! ❤

Hi @JacobEvelyn!
I'm sorry, for whatever reason I looked somewhere and saw no there has been no activity since 2017. I was clearly mistaken!
I just started using the tools, and I'm loving it so I'll definitely come back with any questions, and I really appreciate your response!
I'll use it for a bit more and come back with suggestions / things. :)
Thanks so much for making this available to everyone!

No need to apologize, @ditorelo. Glad you're enjoying friends so far, and please let me know what you think as you use it more!


[Cropping] debug cursor VTK bug, switch to VTK 8.2.0

Fixes https://github.com/medInria/medInria-public/issues/452
It avoids the Cropping toolbox cursor bug which was a VTK 8.1.2 bug.
This PR switches medInria to VTK 8.2.0 and solve the crash in Reslice toolbox.
I am not sure about the milestone to add.
:m:

This PR has been rebased

NB: there is a problem with VTK 8.2, we loose the thumbnail of the output

On VTK 8.1.2, the current one, we loose also the cursor hand in Polygon ROI to move landmarks. This PR could solve the problem

I updated this PR, solved the thumbnail problem with VTK 8.2.0. And @juliencastelneau with this PR, i see a cursor change above a landmark in PolygonROI, that we did not have with VTK 8.1.2.

I rebased this PR about VTK 8.2.0, and i have a weird graphic bug in the view: the background is transparent. Need to be check for a future switch to VTK8.2 from VTK8.1.2

I rebased this PR about VTK 8.2.0, and i have a weird graphic bug in the view: the background is transparent. Need to be check for a future switch to VTK8.2 from VTK8.1.2

PR not needed anymore, current PR for VTK9 https://github.com/medInria/medInria-public/pull/875


[5.9][Executors] tryDiagnoseExecutor must survive null witness, when using Backdeploy library

Description: The recently introduced additional logic to handle missing witnesses was not expecting a null value since in CURRENT stdlib we always have a witness however, in backdeployment we would be missing witnesses and get a null here.  We do not test or build backdeployment library in CI, (not even in full tests), which meant this slipped through and was caught in other tests downstream.
Risk: Low, adds missing null check to avoid null pointer dereference.
Reward: Don't crash while building the backdeployment library. There should not be effect on other libraries building though.
Review by: @DougGregor @hborla
Testing:

CI testing - fake SDK tests were amended to closely replicate how the backdeployment library looks for real (and not just aproximately) -- the adjusted test reproduced the issue and confirms the fix.
Confirmed manually our previous Xcode reproducer project, still fixed (thanks to https://github.com/apple/swift/pull/67957)
Original PR: https://github.com/apple/swift/pull/68006
Radar: rdar://114029779

@swift-ci please test


APK is broken package

could you upload correct APK?

It works fine for me?! Can you provide more info on what you are seeing? Thanks!

Closing due to lack of info. Please reopen with more details if this is still an issue.

could you see this screen shot?  http://rupload.ir/upload/3jtazyoqlxboz1rissw.jpg
file size is 74KB

Same here - OP3T (6.0.1) and Nexus 7 (6.0.1) both report corrupted apk.
Same happens on https://github.com/Stocard/KeepActivitiesTile
Tried both downloading by device browser and loading APK files from PC, also renaming them.

Oh, I see minSdkVersion is 24, not 23 (in my case of both devices). This should be in Readme, also it is weird that it reports broken package nevertheless.

Ah yeah, Nougat+ as this is where the Quick Settings API was introduced. I updated the readme.


Some questions regarding lecture 6 and 7

Lecture 6, formula 20: Why can we suddenly add two times h_i s_i + h_j s_j
Lecture 6, formula 24 to following line: Why is the sum not over i<j but instead i,j? In formula 21 we still had i<j
Lecture 7: I still don't get what  fixed point is. Is it possible that you explain this again?

Lecture 6, formula 20: Why can we suddenly add two times h_i s_i + h_j s_j.
ANSWER: this comes from re-writing the 1-point marginal P_i(s_i) using the 2-point marginal as P_i(s_i) = \sum_{s_j} P_ij(s_i,s_j). If you do this for d_i terms, i.e. for all of the j such that J_ij is not zero, then you can incorporate then you get d_i  new terms that can be incorporated into the first terms of (20).
Lecture 6, formula 24 to following line: Why is the sum not over i<j but instead i,j? In formula 21 we still had i<j
ANSWER: this was a typo, will correct the notes! In general, either you assume that the network is undirected, i.e. J_ij = J_ji, and then you use i<j everywhere. Or you assume that the network is directed, i.e. J_ij  may be different than J_ji. In this case, you need to use sums over i,j.
Lecture 7: I still don't get what fixed point is. Is it possible that you explain this again?
ANSWER: fixed-point is a problem where you want to find a value x such that x = f(x), for a certain function f. There are  numerical routines optimized to find this x, usually starting by assigning x_0 and then updating x_t at each time step, until you see x_(t+1) = f(x_t).  This is also what we see in BP, where you initialize the messages m at random, and then at convergence m = f(m) where f(m) is the BP update.