Real compilers never crash

Work in progress branch while master is locked.

Wow! 14 crashers fixed – the best 🎄 🎁 ever!
Hooray for @slavapestov! 🥇

Now at 19 crashers fixed! Nice! 🥇

@xedin and I are at 19 crashes each now :-)

@slavapestov \o/
l will keep working on them too, maybe we can drop the count to 0 by new year :)

Let me know which ones you're looking at so we don't duplicate work :-)

I am going to take a look at what is left in your branch a bit later today, or if you have something already just let me know!

I looked at 28586 and 28592 a bit but couldn't figure out an elegant solution. The problem is we have InOutExpr in bad places and we end up with InOutType where we don't expect one as a result. I tried just failing constraints if one of the types was not materializable, but then the next problem is if you have a type like (in_out_type (type_var_type ...)), and the type variable itself has an InOutType then we crash inside simplifyType().

28544 looks interesting too -- infinite recursion in ConstraintSystem::solve()

Cool! I will start with 28544 and then take on other two, thanks!

@slavapestov I'll take 28505 as well since this is closure + call expression...

Now at 25 crashers fixed! 👍

@slavapestov 28586 and 28592 are both the good old computeAssignDestType related because if it sees type as type variable it creates another one and tries to bind original to it, which means that original type is "fixed" to the @lvalue T, I was slamming my head for a while trying to figure out how to go about it as well, _? = ... got fixed by unwrapping optional if destination if discarded but it was exactly the same problem...

@slavapestov I'll take 28449 next while still thinking how to go about computeAssignDestType related problems...

@xedin Unless you've started on any of these (I haven't, beyond root causing the issue) I'm calling dibs on 28350, 28389, 28508, 28509, 28482, and 28420. You can have the rest :-)

@slavapestov @xedin - really amazing work from you guys over the last couple of days! Really nice to see all those crashers being fixed!
This is the current status for the swiftc crasher cleanup (SCC) of December Holiday season 2016!
Currently there are 82 crashers marked as unresolved in the repo. Of those 82 crashers ...

49 crashers have been fixed in submitted PRs
6 crashers have been claimed by @slavapestov
27 crashers are still up for grabs :-)

Fixed:

28180-rawrepresentable-extension-with-initializer.swift (fixed by @slavapestov in #6484)
28293-irgensilfunction-visitfullapplysite.swift (fixed by @slavapestov in #6483 and #6484)
28377-swift-expr-walk.swift (fixed by @slavapestov in #6484)
28402-swift-typebase-getcanonicaltype.swift (fixed by @xedin in 6481)
28413-swift-typebase-getcanonicaltype.swift (fixed by @xedin in 6481)
28421-swift-constraints-constraintsystem-diagnosefailureforexpr.swift (fixed by @slavapestov in #6484)
28424-swift-valuedecl-getformalaccessscope.swift (fixed by @slavapestov in #6484)
28425-swift-constraints-solution-convertbooleantypetobuiltini.swift (fixed by @slavapestov in #6484)
28440-swift-typechecker-resolveidentifiertype.swift (fixed by @slavapestov in #6484)
28449-impl-getgraphindex-typevariables-size-out-of-bounds-index-failed.swift (fixed by @xedin in 6481)
28470-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in 6481)
28473-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift (fixed by @xedin in 6481)
28481-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in 6481)
28488-conforms-replacement-haserror-isopenedanyobject-replacement-replacement-is-gener.swift (fixed by @slavapestov in #6484)
28490-result-case-not-implemented.swift (fixed by @xedin in 6481)
28494-conforms-type-does-not-conform-to-protocol.swift (fixed by @slavapestov in #6484)
28497-unreachable-executed-at-swift-lib-ast-type-cpp-294.swift (fixed by @xedin in #6497)
28501-haderror-m-is-sourcefile-m-get-sourcefile-aststage-sourcefile-typechecked-overlo.swift (fixed by @xedin in #6489)
28503-iscomplete-missing-inherited-mapping-in-conformance.swift (fixed by @slavapestov in #6484)
28505-failed-call-arguments-did-not-match-up.swift (fixed by @xedin in #6492)
28507-swift-typerepr-getsourcerange-const.swift (fixed by @slavapestov in #6484)
28512-anonymous-namespace-traversal-visit-swift-typerepr.swift (fixed by @slavapestov in #6484)
28515-getmutableaddressor.swift (fixed by @slavapestov in #6484)
28517-getstoragekind-stored-storagekind-already-set.swift (fixed by @slavapestov in #6484)
28518-anonymous-namespace-verifier-walktoexprpost-swift-expr.swift (fixed by @xedin in #6489)
28520-args-size-fnref-getnumargumentsforfullapply-partial-application-was-throwing.swift (fixed by @xedin in #6501)
28527-e-gettype-isassignabletype-setting-access-kind-on-non-l-value.swift (fixed by @slavapestov in #6484)
28535-unreachable-executed-at-swift-lib-parse-parsedecl-cpp-610.swift (fixed by @slavapestov in #6484)
28537-result-case-not-implemented.swift (fixed by @xedin in 6481)
28541-anonymous-namespace-verifier-walktodeclpost-swift-decl.swift (fixed by @slavapestov in #6484)
28544-swift-type-transform-llvm-function-ref-swift-type-swift-type-const.swift (fixed by @xedin in #6491)
28546-anonymous-namespace-verifier-walktodeclpost-swift-decl.swift (fixed by @slavapestov in #6484)
28549-swift-typebase-getdesugaredtype.swift (fixed by @slavapestov in #6484)
28554-reftype-hastypeparameter-cannot-have-a-dependent-type-here.swift (fixed by @slavapestov in #6484)
28560-unreachable-executed-at-swift-lib-ast-type-cpp-1104.swift (fixed by @xedin in 6481)
28561-input-hastypevariable-output-hastypevariable.swift (fixed by @slavapestov in #6484)
28562-swift-typebase-getcanonicaltype.swift (fixed by @xedin in 6481)
28567-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in 6481)
28568-result-case-not-implemented.swift (fixed by @xedin in 6481)
28569-swift-declcontext-getastypeortypeextensioncontext-const.swift (fixed by @slavapestov in #6484)
28576-anonymous-namespace-findcapturedvars-checktype-swift-type-swift-sourceloc.swift (fixed by @xedin in 6481)
28577-isa-x-val-cast-ty-argument-of-incompatible-type.swift (fixed by @slavapestov in #6484)
28578-result-case-not-implemented.swift (fixed by @xedin in 6481)
28580-hastype-e-expected-type-to-have-been-set.swift (fixed by @slavapestov in #6484)
28581-anonymous-namespace-findcapturedvars-checktype-swift-type-swift-sourceloc.swift (fixed by @xedin in 6481)
28582-result-case-not-implemented.swift (fixed by @xedin in 6481)
28583-unreachable-executed-at-swift-lib-ast-type-cpp-1098.swift (fixed by @xedin in 6481)
28584-loc-isvalid.swift (fixed by @slavapestov in #6484)
28594-anonymous-namespace-verifier-verifychecked-swift-vardecl.swift (fixed by @xedin in #6489)

Claimed by @slavapestov:

28350-swift-typechecker-performtypocorrection.swift (claimed by @slavapestov in #6484)
28389-swift-lookupvisibledecls.swift (claimed by @slavapestov in #6484)
28420-swift-lowering-emitconditionalcheckedcast.swift (claimed by @slavapestov in #6484)
28482-hasaccessibility-accessibility-not-computed-yet.swift (claimed by @slavapestov in #6484)
28508-unreachable-executed-at-swift-lib-sema-csgen-cpp-2656.swift (claimed by @slavapestov in #6484)
28509-allowoverwrite-e-haslvalueaccesskind-l-value-access-kind-has-already-been-set.swift (claimed by @slavapestov in #6484)

Not yet fixed/claimed:

28368-swift-expr-propagatelvalueaccesskind.swift (up for grabs!)
28395-swift-expr-propagatelvalueaccesskind.swift (up for grabs!)
28396-swift-lowering-silgenfunction-emitclosurevalue.swift(up for grabs!)
28419-swift-silmodule-constructsil.swift (up for grabs!)
28442-swift-typebase-getrvaluetype.swift (up for grabs!)
28447-result-case-not-implemented-failed.swift (up for grabs!)
28457-unreachable-executed-at-swift-include-swift-ast-cantypevisitor-h-41.swift (up for grabs!)
28474-unreachable-executed-at-swift-lib-ast-type-cpp-1325.swift (up for grabs!)
28475-swift-typechecker-validatedecl-swift-valuedecl-bool.swift (up for grabs!)
28479-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift (up for grabs!)
28483-unreachable-executed-at-swift-lib-ast-type-cpp-1117.swift (up for grabs!)
28491-result-case-not-implemented.swift (up for grabs!)
28493-resolveidenttypecomponent-swift-typechecker-swift-declcontext-llvm-arrayref-swif.swift (up for grabs!)
28499-start-isvalid-end-isvalid-start-and-end-should-either-both-be-valid-or-both-be-i.swift (up for grabs!)
28504-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (up for grabs!)
28510-size-t-llvm-sys-locale-columnwidth-i-gettext-i-gettext-size.swift (up for grabs!)
28543-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift (up for grabs!)
28550-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift (up for grabs!)
28555-unreachable-executed-at-swift-lib-ast-type-cpp-1318.swift (up for grabs!)
28559-result-case-not-implemented.swift (up for grabs!)
28585-anonymous-namespace-verifier-walktostmtpost-swift-stmt.swift (up for grabs!)
28586-objectty-is-lvaluetype-objectty-is-inouttype-cannot-have-inout-or-lvalue-wrapped.swift (up for grabs!)
28587-child-source-range-not-contained-within-its-parent-sequence-expr-type-null.swift (up for grabs!)
28588-unreachable-executed-at-swift-lib-sema-csapply-cpp-5770.swift (up for grabs!)
28590-exprtypes-e-isequal-e-gettype-expected-type-in-map-to-be-the-same-type-in-expres.swift (up for grabs!)
28592-objectty-is-lvaluetype-objectty-is-inouttype-cannot-have-inout-or-lvalue-wrapped.swift (up for grabs!)
28593-unreachable-executed-at-swift-lib-ast-type-cpp-3771.swift (up for grabs!)

Let me know if I got anything wrong! :-)

@practicalswift Thanks for awesome report, very helpful! I will double check if I have missed any crashers related to result statement checking (maybe one or two at most if any), and will keep on going through the list of unclaimed...

@xedin If you want to automate the process,
../llvm/utils/lit/lit.py -sv ../build/Ninja-DebugAssert/swift-macosx-x86_64/validation-test-macosx-x86_64/compiler_crashers/ | ./utils/resolve-crashes.py

Oh, forgot to mention:
I've got 28499 and 28585 today.

@CodaFi Thanks!

@practicalswift Looks like there are 5 more crashers which are resolved by #6481 - 28447, 28483, 28491, 28504 and 28559 (pushed as a commit for aforementioned PR).

I think most of the remaining problems are related to the computeAssignDestType and it's way to enforce lvalueness of the destination type...

Looking at 28395 and 28368, these are due to UnresolvedDotExpr/UnresolvedMemberRefExpr which escape the type checker, and other code is not expecting them.  In https://github.com/apple/swift/pull/5751 I fixed something related by handling UNCHECKED_EXPR, but I wonder if that's the wrong approach in general, and instead something is supposed to be preventing these from escaping TC (but is failing to do so)?

@jtbandes Yes, @rudkx is working on improvements to the constraint system which is going to prevent type variables from escaping, he mentioned that in one of the comments in #6481.

@jtbandes I'm still working on finishing things up, but I added a side map for expression types to the constraint system. We're currently still writing types directly into expressions as well, until everything is updated. After that point, we should only be writing types into expressions when we apply a final solution, which should keep the type variables from escaping.
I haven't updated the types on TypeLocs or parameters yet, but that should be done as well.
More generally it would be great to have the type checker not mutate existing ASTs but that's a much bigger change.

Yeah, I just noticed your work on this side map. Looks great! (28490 is another one caused by escaping type vars.)
I'm guessing there's not much for an outsider to help with at this point (since you've probably got a lot of work in progress there)?

@rudkx FYI, while working on one of the crashers I've noticed that if system fails only types which had type variables are marked as erroneous but other are left alone and there is some code (not exactly sure what) which is relies on that behavior, so applying only "final" types to expressions upon successful solving might degrade code completion, because if there was no solution found whole AST should be marked as erroneous or unresolved, right?

crasher 28590 is related to the fact that failure diagnosis is going to modify types directly on AST while solving sub-expressions and main constraint system is not going to be made aware of that...

@CodaFi @xedin Great stuff! I've added your recently fixed crashes in this status update.
This is the current status for the swiftc crasher cleanup (SCC) of December Holiday season 2016!
Currently there are 82 crashers marked as unresolved in the repo. Of those 82 crashers ...

60 crashers have been fixed in submitted PRs
6 crashers have been claimed by @slavapestov
16 crashers are still up for grabs :-)

Changes since last update:

6 crashers fixed by @CodaFi in #6504
5 more crashers fixed by @xedin in #6481

Fixed:

28180-rawrepresentable-extension-with-initializer.swift (fixed by @slavapestov in #6484)
28504-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in #6481)
28585-anonymous-namespace-verifier-walktostmtpost-swift-stmt.swift (fixed by @CodaFi in #6504)
28293-irgensilfunction-visitfullapplysite.swift (fixed by @slavapestov in #6483 and #6484)
28377-swift-expr-walk.swift (fixed by @slavapestov in #6484)
28396-swift-lowering-silgenfunction-emitclosurevalue.swift (fixed by @CodaFi in #6504)
28402-swift-typebase-getcanonicaltype.swift (fixed by @xedin in 6481)
28413-swift-typebase-getcanonicaltype.swift (fixed by @xedin in 6481)
28419-swift-silmodule-constructsil.swift (fixed by @CodaFi in #6504)
28421-swift-constraints-constraintsystem-diagnosefailureforexpr.swift (fixed by @slavapestov in #6484)
28424-swift-valuedecl-getformalaccessscope.swift (fixed by @slavapestov in #6484)
28425-swift-constraints-solution-convertbooleantypetobuiltini.swift (fixed by @slavapestov in #6484)
28440-swift-typechecker-resolveidentifiertype.swift (fixed by @slavapestov in #6484)
28447-result-case-not-implemented-failed.swift (fixed by @xedin in #6481)
28449-impl-getgraphindex-typevariables-size-out-of-bounds-index-failed.swift (fixed by @xedin in 6481)
28457-unreachable-executed-at-swift-include-swift-ast-cantypevisitor-h-41.swift (fixed by @CodaFi in #6504)
28470-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in 6481)
28473-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift (fixed by @xedin in 6481)
28481-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in 6481)
28483-unreachable-executed-at-swift-lib-ast-type-cpp-1117.swift (fixed by @xedin in #6481)
28488-conforms-replacement-haserror-isopenedanyobject-replacement-replacement-is-gener.swift (fixed by @slavapestov in #6484)
28490-result-case-not-implemented.swift (fixed by @xedin in 6481)
28491-result-case-not-implemented.swift (fixed by @xedin in #6481)
28494-conforms-type-does-not-conform-to-protocol.swift (fixed by @slavapestov in #6484)
28497-unreachable-executed-at-swift-lib-ast-type-cpp-294.swift (fixed by @xedin in #6497)
28499-start-isvalid-end-isvalid-start-and-end-should-either-both-be-valid-or-both-be-i.swift (fixed by @CodaFi in #6504)
28501-haderror-m-is-sourcefile-m-get-sourcefile-aststage-sourcefile-typechecked-overlo.swift (fixed by @xedin in #6489)
28503-iscomplete-missing-inherited-mapping-in-conformance.swift (fixed by @slavapestov in #6484)
28505-failed-call-arguments-did-not-match-up.swift (fixed by @xedin in #6492)
28507-swift-typerepr-getsourcerange-const.swift (fixed by @slavapestov in #6484)
28512-anonymous-namespace-traversal-visit-swift-typerepr.swift (fixed by @slavapestov in #6484)
28515-getmutableaddressor.swift (fixed by @slavapestov in #6484)
28517-getstoragekind-stored-storagekind-already-set.swift (fixed by @slavapestov in #6484)
28518-anonymous-namespace-verifier-walktoexprpost-swift-expr.swift (fixed by @xedin in #6489)
28520-args-size-fnref-getnumargumentsforfullapply-partial-application-was-throwing.swift (fixed by @xedin in #6501)
28527-e-gettype-isassignabletype-setting-access-kind-on-non-l-value.swift (fixed by @slavapestov in #6484)
28535-unreachable-executed-at-swift-lib-parse-parsedecl-cpp-610.swift (fixed by @slavapestov in #6484)
28537-result-case-not-implemented.swift (fixed by @xedin in 6481)
28541-anonymous-namespace-verifier-walktodeclpost-swift-decl.swift (fixed by @slavapestov in #6484)
28544-swift-type-transform-llvm-function-ref-swift-type-swift-type-const.swift (fixed by @xedin in #6491)
28546-anonymous-namespace-verifier-walktodeclpost-swift-decl.swift (fixed by @slavapestov in #6484)
28549-swift-typebase-getdesugaredtype.swift (fixed by @slavapestov in #6484)
28554-reftype-hastypeparameter-cannot-have-a-dependent-type-here.swift (fixed by @slavapestov in #6484)
28559-result-case-not-implemented.swift (fixed by @xedin in #6481)
28560-unreachable-executed-at-swift-lib-ast-type-cpp-1104.swift (fixed by @xedin in 6481)
28561-input-hastypevariable-output-hastypevariable.swift (fixed by @slavapestov in #6484)
28562-swift-typebase-getcanonicaltype.swift (fixed by @xedin in 6481)
28567-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in 6481)
28568-result-case-not-implemented.swift (fixed by @xedin in 6481)
28569-swift-declcontext-getastypeortypeextensioncontext-const.swift (fixed by @slavapestov in #6484)
28576-anonymous-namespace-findcapturedvars-checktype-swift-type-swift-sourceloc.swift (fixed by @xedin in 6481)
28577-isa-x-val-cast-ty-argument-of-incompatible-type.swift (fixed by @slavapestov in #6484)
28578-result-case-not-implemented.swift (fixed by @xedin in 6481)
28580-hastype-e-expected-type-to-have-been-set.swift (fixed by @slavapestov in #6484)
28581-anonymous-namespace-findcapturedvars-checktype-swift-type-swift-sourceloc.swift (fixed by @xedin in 6481)
28582-result-case-not-implemented.swift (fixed by @xedin in 6481)
28583-unreachable-executed-at-swift-lib-ast-type-cpp-1098.swift (fixed by @xedin in 6481)
28584-loc-isvalid.swift (fixed by @slavapestov in #6484)
28587-child-source-range-not-contained-within-its-parent-sequence-expr-type-null.swift (fixed by @CodaFi in #6504)
28594-anonymous-namespace-verifier-verifychecked-swift-vardecl.swift (fixed by @xedin in #6489)

Claimed:

28350-swift-typechecker-performtypocorrection.swift (claimed by @slavapestov in #6484)
28389-swift-lookupvisibledecls.swift (claimed by @slavapestov in #6484)
28420-swift-lowering-emitconditionalcheckedcast.swift (claimed by @slavapestov in #6484)
28482-hasaccessibility-accessibility-not-computed-yet.swift (claimed by @slavapestov in #6484)
28508-unreachable-executed-at-swift-lib-sema-csgen-cpp-2656.swift (claimed by @slavapestov in #6484)
28509-allowoverwrite-e-haslvalueaccesskind-l-value-access-kind-has-already-been-set.swift (claimed by @slavapestov in #6484)

Not yet fixed/claimed:

28368-swift-expr-propagatelvalueaccesskind.swift (up for grabs!)
28395-swift-expr-propagatelvalueaccesskind.swift (up for grabs!)
28442-swift-typebase-getrvaluetype.swift (up for grabs!)
28474-unreachable-executed-at-swift-lib-ast-type-cpp-1325.swift (up for grabs!)
28475-swift-typechecker-validatedecl-swift-valuedecl-bool.swift (up for grabs!)
28479-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift (up for grabs!)
28493-resolveidenttypecomponent-swift-typechecker-swift-declcontext-llvm-arrayref-swif.swift (up for grabs!)
28510-size-t-llvm-sys-locale-columnwidth-i-gettext-i-gettext-size.swift (up for grabs!)
28543-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift (up for grabs!)
28550-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift (up for grabs!)
28555-unreachable-executed-at-swift-lib-ast-type-cpp-1318.swift (up for grabs!)
28586-objectty-is-lvaluetype-objectty-is-inouttype-cannot-have-inout-or-lvalue-wrapped.swift (up for grabs!)
28588-unreachable-executed-at-swift-lib-sema-csapply-cpp-5770.swift (up for grabs!)
28590-exprtypes-e-isequal-e-gettype-expected-type-in-map-to-be-the-same-type-in-expres.swift (up for grabs!)
28592-objectty-is-lvaluetype-objectty-is-inouttype-cannot-have-inout-or-lvalue-wrapped.swift (up for grabs!)
28593-unreachable-executed-at-swift-lib-ast-type-cpp-3771.swift (up for grabs!)

A lot of the 14 leftover are either nondeterministic memory smashers (ASAN confirms).  Destruction of Types allocated in the process of solving ConstraintSystems doesn't propagate to expressions and decls that got assigned those types during the solving process.  Either we need to traverse along the locators to unset these types and nuke the little RAII cleanup struct or allocate things outside the Constraint System's arena.
@rudkx, thoughts?

I'm currently working on 28592, that's related to opening generics and wrapping optional inout into lvalue type when trying to match possible type parameters, next up going to be 28586 - it's similar but different cause - computeAssignDestType with type variables binding to lvalue.
@practicalswift 28510 this one is going to be involved as todo suggests, i don't think we wouldn't be able to tackle it any time soon.

@xedin Regarding 28510 - you mean this comment in llvm/lib/Support/SourceMgr.cpp?
    // FIXME: This assertion is intended to catch unintended use of multibyte
    // characters in fixits. If we decide to do this, we'll have to track
    // separate byte widths for the source and fixit lines.

@practicalswift Yeah, that's the one.

@xedin Could one temporary work-around be to print the multi-byte characters escaped in some way instead?
In this particular case the problem seems to be 丏, so the escaped form form could be say U+4E0F, \u4E0F or the UTF-8 hex representation 0xE4 0xB8 0x8F (e4b88f).
What do you think? :-)

I think that's not going to be a user friendly thing, which kind of beats the purpose of fix-its, so unfortunately there is no easy work around, we have to make it proper...

I think for that one we should just file an llvm bug?

Yes, I concur. Sorry, didn't mean to imply that we have to fix it in swift :)

@xedin Thanks! I've added your two fixed crashers in this status update.
This is the current status for the swiftc crasher cleanup (SCC) of December Holiday season 2016!
Currently there are 82 crashers marked as unresolved in the repo. Of those 82 crashers ...

64 crashers have been fixed in submitted PRs
6 crashers have been claimed by @slavapestov
12 crashers are still up for grabs :-)

Changes since last update:

2 crashers fixed by @xedin in #6510 and #6511

Not yet fixed/claimed:

28368-swift-expr-propagatelvalueaccesskind.swift
28395-swift-expr-propagatelvalueaccesskind.swift
28442-swift-typebase-getrvaluetype.swift
28474-unreachable-executed-at-swift-lib-ast-type-cpp-1325.swift
28479-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
28510-size-t-llvm-sys-locale-columnwidth-i-gettext-i-gettext-size.swift
28543-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
28550-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
28555-unreachable-executed-at-swift-lib-ast-type-cpp-1318.swift
28588-unreachable-executed-at-swift-lib-sema-csapply-cpp-5770.swift
28590-exprtypes-e-isequal-e-gettype-expected-type-in-map-to-be-the-same-type-in-expres.swift
28593-unreachable-executed-at-swift-lib-ast-type-cpp-3771.swift

Fixed:

28180-rawrepresentable-extension-with-initializer.swift (fixed by @slavapestov in #6484)
28293-irgensilfunction-visitfullapplysite.swift (fixed by @slavapestov in #6483 and #6484)
28377-swift-expr-walk.swift (fixed by @slavapestov in #6484)
28396-swift-lowering-silgenfunction-emitclosurevalue.swift (fixed by @CodaFi in #6504)
28402-swift-typebase-getcanonicaltype.swift (fixed by @xedin in 6481)
28413-swift-typebase-getcanonicaltype.swift (fixed by @xedin in 6481)
28419-swift-silmodule-constructsil.swift (fixed by @CodaFi in #6504)
28421-swift-constraints-constraintsystem-diagnosefailureforexpr.swift (fixed by @slavapestov in #6484)
28424-swift-valuedecl-getformalaccessscope.swift (fixed by @slavapestov in #6484)
28425-swift-constraints-solution-convertbooleantypetobuiltini.swift (fixed by @slavapestov in #6484)
28440-swift-typechecker-resolveidentifiertype.swift (fixed by @slavapestov in #6484)
28447-result-case-not-implemented-failed.swift (fixed by @xedin in #6481)
28449-impl-getgraphindex-typevariables-size-out-of-bounds-index-failed.swift (fixed by @xedin in 6481)
28457-unreachable-executed-at-swift-include-swift-ast-cantypevisitor-h-41.swift (fixed by @CodaFi in #6504)
28470-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in 6481)
28473-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift (fixed by @xedin in 6481)
28475-swift-typechecker-validatedecl-swift-valuedecl-bool.swift (fixed, see #6505)
28481-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in 6481)
28483-unreachable-executed-at-swift-lib-ast-type-cpp-1117.swift (fixed by @xedin in #6481)
28488-conforms-replacement-haserror-isopenedanyobject-replacement-replacement-is-gener.swift (fixed by @slavapestov in #6484)
28490-result-case-not-implemented.swift (fixed by @xedin in 6481)
28491-result-case-not-implemented.swift (fixed by @xedin in #6481)
28493-resolveidenttypecomponent-swift-typechecker-swift-declcontext-llvm-arrayref-swif.swift (fixed, see #6505)
28494-conforms-type-does-not-conform-to-protocol.swift (fixed by @slavapestov in #6484)
28497-unreachable-executed-at-swift-lib-ast-type-cpp-294.swift (fixed by @xedin in #6497)
28499-start-isvalid-end-isvalid-start-and-end-should-either-both-be-valid-or-both-be-i.swift (fixed by @CodaFi in #6504)
28501-haderror-m-is-sourcefile-m-get-sourcefile-aststage-sourcefile-typechecked-overlo.swift (fixed by @xedin in #6489)
28503-iscomplete-missing-inherited-mapping-in-conformance.swift (fixed by @slavapestov in #6484)
28504-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in #6481)
28505-failed-call-arguments-did-not-match-up.swift (fixed by @xedin in #6492)
28507-swift-typerepr-getsourcerange-const.swift (fixed by @slavapestov in #6484)
28512-anonymous-namespace-traversal-visit-swift-typerepr.swift (fixed by @slavapestov in #6484)
28515-getmutableaddressor.swift (fixed by @slavapestov in #6484)
28517-getstoragekind-stored-storagekind-already-set.swift (fixed by @slavapestov in #6484)
28518-anonymous-namespace-verifier-walktoexprpost-swift-expr.swift (fixed by @xedin in #6489)
28520-args-size-fnref-getnumargumentsforfullapply-partial-application-was-throwing.swift (fixed by @xedin in #6501)
28527-e-gettype-isassignabletype-setting-access-kind-on-non-l-value.swift (fixed by @slavapestov in #6484)
28535-unreachable-executed-at-swift-lib-parse-parsedecl-cpp-610.swift (fixed by @slavapestov in #6484)
28537-result-case-not-implemented.swift (fixed by @xedin in #6481)
28541-anonymous-namespace-verifier-walktodeclpost-swift-decl.swift (fixed by @slavapestov in #6484)
28544-swift-type-transform-llvm-function-ref-swift-type-swift-type-const.swift (fixed by @xedin in #6491)
28546-anonymous-namespace-verifier-walktodeclpost-swift-decl.swift (fixed by @slavapestov in #6484)
28549-swift-typebase-getdesugaredtype.swift (fixed by @slavapestov in #6484)
28554-reftype-hastypeparameter-cannot-have-a-dependent-type-here.swift (fixed by @slavapestov in #6484)
28559-result-case-not-implemented.swift (fixed by @xedin in #6481)
28560-unreachable-executed-at-swift-lib-ast-type-cpp-1104.swift (fixed by @xedin in #6481)
28561-input-hastypevariable-output-hastypevariable.swift (fixed by @slavapestov in #6484)
28562-swift-typebase-getcanonicaltype.swift (fixed by @xedin in #6481)
28567-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in #6481)
28568-result-case-not-implemented.swift (fixed by @xedin in #6481)
28569-swift-declcontext-getastypeortypeextensioncontext-const.swift (fixed by @slavapestov in #6484)
28576-anonymous-namespace-findcapturedvars-checktype-swift-type-swift-sourceloc.swift (fixed by @xedin in #6481)
28577-isa-x-val-cast-ty-argument-of-incompatible-type.swift (fixed by @slavapestov in #6484)
28578-result-case-not-implemented.swift (fixed by @xedin in #6481)
28580-hastype-e-expected-type-to-have-been-set.swift (fixed by @slavapestov in #6484)
28581-anonymous-namespace-findcapturedvars-checktype-swift-type-swift-sourceloc.swift (fixed by @xedin in #6481)
28582-result-case-not-implemented.swift (fixed by @xedin in #6481)
28583-unreachable-executed-at-swift-lib-ast-type-cpp-1098.swift (fixed by @xedin in #6481)
28584-loc-isvalid.swift (fixed by @slavapestov in #6484)
28585-anonymous-namespace-verifier-walktostmtpost-swift-stmt.swift (fixed by @CodaFi in #6504)
28586-objectty-is-lvaluetype-objectty-is-inouttype-cannot-have-inout-or-lvalue-wrapped.swift (fixed by @xedin in #6511)
28587-child-source-range-not-contained-within-its-parent-sequence-expr-type-null.swift (fixed by @CodaFi in #6504)
28592-objectty-is-lvaluetype-objectty-is-inouttype-cannot-have-inout-or-lvalue-wrapped.swift (fixed by @xedin in #6510)
28594-anonymous-namespace-verifier-verifychecked-swift-vardecl.swift (fixed by @xedin in #6489)

Claimed:

28350-swift-typechecker-performtypocorrection.swift (claimed by @slavapestov in #6484)
28389-swift-lookupvisibledecls.swift (claimed by @slavapestov in #6484)
28420-swift-lowering-emitconditionalcheckedcast.swift (claimed by @slavapestov in #6484)
28482-hasaccessibility-accessibility-not-computed-yet.swift (claimed by @slavapestov in #6484)
28508-unreachable-executed-at-swift-lib-sema-csgen-cpp-2656.swift (claimed by @slavapestov in #6484)
28509-allowoverwrite-e-haslvalueaccesskind-l-value-access-kind-has-already-been-set.swift (claimed by @slavapestov in #6484)

@practicalswift I think most of the ones in the unclaimed list are actually @rudkx's. The first two lvalue ones look different though. Also I'm not promising to fix the ones I "claimed" any time soon, nor do I insist that I be the one to fix them -- it's just that I figured out the root causes. If anyone wants to look at them let me know -- I'll explain the fix.

@slavapestov I agree and i am going to take a look at first two, since (I think) I know what the problem is... I can also help out with the ones you claimed if you want!

@practicalswift I've submitted #6514 to resolve 28368 and 28395 (as well as one of the SIL crashers).

@practicalswift I've submitted the last one of this year which is going to address 28588 - #6515

@xedin Great! Update below :-)
This is the current status for the swiftc crasher cleanup (SCC) of December Holiday season 2016!
Currently there are 82 crashers marked as unresolved in the repo. Of those 82 crashers ...

65 crashers have been fixed in submitted PRs which will be merged once master is unlocked (great work by this team: 34 crashers fixed by @xedin, 25 crashers fixed by @slavapestov and 6 crashers fixed by @xedin)
One crasher should probably be reported upstream to LLVM.
Two disabled crashes marked as resolved in #6505.
The remaining 14 crashers can be divided into two distinct sets of crashes where the members of each set share the same root cause - @rudkx's upcoming improvements to the constraint system will likely solve 8 of those and @slavapestov has identified what needs to be done for the remaining 6 crashers :-)

Fixed:

28180-rawrepresentable-extension-with-initializer.swift (fixed by @slavapestov in #6484)
28293-irgensilfunction-visitfullapplysite.swift (fixed by @slavapestov in #6483 and #6484)
28368-swift-expr-propagatelvalueaccesskind.swift (fixed by @xedin in #6514)
28377-swift-expr-walk.swift (fixed by @slavapestov in #6484)
28395-swift-expr-propagatelvalueaccesskind.swift (fixed by @xedin in #6514)
28396-swift-lowering-silgenfunction-emitclosurevalue.swift (fixed by @CodaFi in #6504)
28402-swift-typebase-getcanonicaltype.swift (fixed by @xedin in #6481)
28413-swift-typebase-getcanonicaltype.swift (fixed by @xedin in #6481)
28419-swift-silmodule-constructsil.swift (fixed by @CodaFi in #6504)
28421-swift-constraints-constraintsystem-diagnosefailureforexpr.swift (fixed by @slavapestov in #6484)
28424-swift-valuedecl-getformalaccessscope.swift (fixed by @slavapestov in #6484)
28425-swift-constraints-solution-convertbooleantypetobuiltini.swift (fixed by @slavapestov in #6484)
28440-swift-typechecker-resolveidentifiertype.swift (fixed by @slavapestov in #6484)
28447-result-case-not-implemented-failed.swift (fixed by @xedin in #6481)
28449-impl-getgraphindex-typevariables-size-out-of-bounds-index-failed.swift (fixed by @xedin in #6481)
28457-unreachable-executed-at-swift-include-swift-ast-cantypevisitor-h-41.swift (fixed by @CodaFi in #6504)
28470-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in #6481)
28473-typevariables-impl-getgraphindex-typevar-type-variable-mismatch.swift (fixed by @xedin in #6481)
28475-swift-typechecker-validatedecl-swift-valuedecl-bool.swift (fixed, see #6505)
28481-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in #6481)
28483-unreachable-executed-at-swift-lib-ast-type-cpp-1117.swift (fixed by @xedin in #6481)
28488-conforms-replacement-haserror-isopenedanyobject-replacement-replacement-is-gener.swift (fixed by @slavapestov in #6484)
28490-result-case-not-implemented.swift (fixed by @xedin in #6481)
28491-result-case-not-implemented.swift (fixed by @xedin in #6481)
28493-resolveidenttypecomponent-swift-typechecker-swift-declcontext-llvm-arrayref-swif.swift (fixed, see #6505)
28494-conforms-type-does-not-conform-to-protocol.swift (fixed by @slavapestov in #6484)
28497-unreachable-executed-at-swift-lib-ast-type-cpp-294.swift (fixed by @xedin in #6497)
28499-start-isvalid-end-isvalid-start-and-end-should-either-both-be-valid-or-both-be-i.swift (fixed by @CodaFi in #6504)
28501-haderror-m-is-sourcefile-m-get-sourcefile-aststage-sourcefile-typechecked-overlo.swift (fixed by @xedin in #6489)
28503-iscomplete-missing-inherited-mapping-in-conformance.swift (fixed by @slavapestov in #6484)
28504-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in #6481)
28505-failed-call-arguments-did-not-match-up.swift (fixed by @xedin in #6492)
28507-swift-typerepr-getsourcerange-const.swift (fixed by @slavapestov in #6484)
28512-anonymous-namespace-traversal-visit-swift-typerepr.swift (fixed by @slavapestov in #6484)
28515-getmutableaddressor.swift (fixed by @slavapestov in #6484)
28517-getstoragekind-stored-storagekind-already-set.swift (fixed by @slavapestov in #6484)
28518-anonymous-namespace-verifier-walktoexprpost-swift-expr.swift (fixed by @xedin in #6489)
28520-args-size-fnref-getnumargumentsforfullapply-partial-application-was-throwing.swift (fixed by @xedin in #6501)
28527-e-gettype-isassignabletype-setting-access-kind-on-non-l-value.swift (fixed by @slavapestov in #6484)
28535-unreachable-executed-at-swift-lib-parse-parsedecl-cpp-610.swift (fixed by @slavapestov in #6484)
28537-result-case-not-implemented.swift (fixed by @xedin in #6481)
28541-anonymous-namespace-verifier-walktodeclpost-swift-decl.swift (fixed by @slavapestov in #6484)
28544-swift-type-transform-llvm-function-ref-swift-type-swift-type-const.swift (fixed by @xedin in #6491)
28546-anonymous-namespace-verifier-walktodeclpost-swift-decl.swift (fixed by @slavapestov in #6484)
28549-swift-typebase-getdesugaredtype.swift (fixed by @slavapestov in #6484)
28554-reftype-hastypeparameter-cannot-have-a-dependent-type-here.swift (fixed by @slavapestov in #6484)
28559-result-case-not-implemented.swift (fixed by @xedin in #6481)
28560-unreachable-executed-at-swift-lib-ast-type-cpp-1104.swift (fixed by @xedin in #6481)
28561-input-hastypevariable-output-hastypevariable.swift (fixed by @slavapestov in #6484)
28562-swift-typebase-getcanonicaltype.swift (fixed by @xedin in #6481)
28567-anonymous-namespace-verifier-verifychecked-swift-type-llvm-smallptrset-swift-arc.swift (fixed by @xedin in #6481)
28568-result-case-not-implemented.swift (fixed by @xedin in #6481)
28569-swift-declcontext-getastypeortypeextensioncontext-const.swift (fixed by @slavapestov in #6484)
28576-anonymous-namespace-findcapturedvars-checktype-swift-type-swift-sourceloc.swift (fixed by @xedin in #6481)
28577-isa-x-val-cast-ty-argument-of-incompatible-type.swift (fixed by @slavapestov in #6484)
28578-result-case-not-implemented.swift (fixed by @xedin in #6481)
28580-hastype-e-expected-type-to-have-been-set.swift (fixed by @slavapestov in #6484)
28581-anonymous-namespace-findcapturedvars-checktype-swift-type-swift-sourceloc.swift (fixed by @xedin in #6481)
28582-result-case-not-implemented.swift (fixed by @xedin in #6481)
28583-unreachable-executed-at-swift-lib-ast-type-cpp-1098.swift (fixed by @xedin in #6481)
28584-loc-isvalid.swift (fixed by @slavapestov in #6484)
28585-anonymous-namespace-verifier-walktostmtpost-swift-stmt.swift (fixed by @CodaFi in #6504)
28586-objectty-is-lvaluetype-objectty-is-inouttype-cannot-have-inout-or-lvalue-wrapped.swift (fixed by @xedin in #6511)
28587-child-source-range-not-contained-within-its-parent-sequence-expr-type-null.swift (fixed by @CodaFi in #6504)
28588-unreachable-executed-at-swift-lib-sema-csapply-cpp-5770.swift (fixed by @xedin in #6515)
28592-objectty-is-lvaluetype-objectty-is-inouttype-cannot-have-inout-or-lvalue-wrapped.swift (fixed by @xedin in #6510)
28594-anonymous-namespace-verifier-verifychecked-swift-vardecl.swift (fixed by @xedin in #6489)

This one should probably be reported upstream to LLVM:

28510-size-t-llvm-sys-locale-columnwidth-i-gettext-i-gettext-size.swift

Crashers with a known common root cause that likely will be fixed by @rudkx's upcoming improvements to the constraint system (see discussion in #6484):

28442-swift-typebase-getrvaluetype.swift
28474-unreachable-executed-at-swift-lib-ast-type-cpp-1325.swift
28479-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
28543-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
28550-unreachable-executed-at-swift-include-swift-ast-typevisitor-h-39.swift
28555-unreachable-executed-at-swift-lib-ast-type-cpp-1318.swift
28590-exprtypes-e-isequal-e-gettype-expected-type-in-map-to-be-the-same-type-in-expres.swift
28593-unreachable-executed-at-swift-lib-ast-type-cpp-3771.swift

Crashers with a known common root cause identified by @slavapestov (see discussion in #6484, ping @slavapestov if you want to help with these :-)):

28350-swift-typechecker-performtypocorrection.swift
28389-swift-lookupvisibledecls.swift
28420-swift-lowering-emitconditionalcheckedcast.swift
28482-hasaccessibility-accessibility-not-computed-yet.swift
28508-unreachable-executed-at-swift-lib-sema-csgen-cpp-2656.swift
28509-allowoverwrite-e-haslvalueaccesskind-l-value-access-kind-has-already-been-set.swift

@practicalswift I'm still working through issues to get my changes working, but can confirm that at least 28590-exprtypes-e-isequal-e-gettype-expected-type-in-map-to-be-the-same-type-in-expres.swift is fixed at this point. Hopefully I can wrap this stuff wrapped up soon.

@rudkx \o/

@rudkx That's excellent! 👍

@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - c18641a1376678cbb39cf95134159708bcd07c32
Test requested by - @slavapestov

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - c18641a1376678cbb39cf95134159708bcd07c32
Test requested by - @slavapestov

@slavapestov What happened to this branch?

@jtbandes Everything got merged a while ago :)


⚠ Bofrost.be has degraded performance

In 9376836, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2509 ms

Resolved: Bofrost.be performance has improved in 0cafb12.


[ginkgo] add version 1.8.0

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[x] The "supports" clause reflects platforms that may be fixed by this new version.
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

I got the following error when testing the feature locally.
CMake Error at C:/Program Files/CMake/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find MPI: Found unsuitable version "2.0", but required is at
  least "3.1" (found FALSE, )
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:598 (_FPHSA_FAILURE_MESSAGE)
  C:/Program Files/CMake/share/cmake-3.29/Modules/FindMPI.cmake:1837 (find_package_handle_standard_args)
  F:/ginkgo/installed/x64-windows/share/mpi/vcpkg-cmake-wrapper.cmake:9 (_find_package)
  F:/ginkgo/scripts/buildsystems/vcpkg.cmake:811 (include)
  CMakeLists.txt:206 (find_package)

Could NOT find MPI: Found unsuitable version "2.0", but required is at
least "3.1" (found FALSE, )

There is litte which can be done in vcpkg (except for presenting the error in a different way): Even for your platform, more capable compilers may exist.

The MPI feature has not changed since the last version, only Microsoft's MPI implementation lacks the necessary features for full 3.1 compliance. All other commonly used MPI implementations support 3.1, so this should not hold up the PR.


Failed to run the example dataset

Hello Decona developer - I  have successfully  installed decona, but failed  to run it.  Command line used :
decona -d -l 800 -m 1200 -q 10 -c 0.80 -n 100 -M -d -b ../example_data/small_database_aquarium.fasta
output:
Filtering data...
Data filtered with NanoFilt
Demultiplexing...
Multi threading is not yet supported in epi2mme mode. Falling back to using a single thread.
Adapters detected in 0 of 0 reads
Barcodes detected in 0 of 0 adapters
Demultiplexing finished in 0.56s
Data demultiplexed, working directory changed to:
/scicomp/home-pure/qlk5/Desktop/important_programs/decona/my_try/demultiplexed_data
Fastq reads are being transformed to fasta
Transforming fastq to fasta Complete
Clustering reads...
/scicomp/home-pure/qlk5/miniconda3/envs/decona/bin/decona: line 301: cd: */: No such file or directory
Please could you provide any help?
Cheers,
~DD

Hi there,
The example data is already demultiplexed, that's probably the problem. It should work without the -d flag.
If you do need to demultiplex your own data I recommend using the Guppy software from Nanopore instead of Qcat the tool build in in Decona.
Best,
Saskia

Hi there -  I   have removed the -d flag and I am having other error (rename: not enough arguments).  Note that I have run this command line inside of the 'example_data' folder as follow:
(decona) [qlk5@biolinux example_data]$ ls
barcode83.fastq  barcode84.fastq  small_database_aquarium.fasta
(decona) [qlk5@biolinux example_data]$
(decona) [qlk5@biolinux example_data]$ decona -l 800 -m 1200 -q 10 -c 0.80 -n 100 -M
Filtering data barcode83.fastq...
Filtering data barcode84.fastq...
Data filtered with NanoFilt
Data not demultiplexed
Fastq reads are being transformed to fasta
rename: not enough arguments
Usage:
rename [options] expression replacement file...
Options:
-v, --verbose    explain what is being done
-s, --symlink    act on symlink target
-h, --help     display this help and exit
-V, --version  output version information and exit
For more details see rename(1).
(decona) [qlk5@biolinux example_data]$
Any hep  please?
Cheers,
~DD

Hello,
The reads in the example data are around 2000 bases, filtering between 800 – 1200 reads will remove (most of) the data. Sorry I didn’t see it before. Filtering between 1800 – 2500 is more appropriate, I should give better example commands with that!
That hopefully also prevents rename from having empty arguments. If not, all I can say is that I have a version without rename on the way. It has been giving more issues.
Saskia


Can't detect the S3Client configuration in native mode

In a Quarkus 2.16.6.Final application, I'm using software.amazon.awssdk.services.s3.S3Client class. I have declared the following dependency:
...
<dependency>
  <groupId>io.quarkus.platform</groupId>
  <artifactId>quarkus-amazon-services-bom</artifactId>
  <version>${quarkus.platform.version}</version>
  <type>pom</type>
  <scope>import</scope>
</dependency>
...
<dependency>
  <groupId>io.quarkiverse.amazonservices</groupId>
  <artifactId>quarkus-amazon-s3</artifactId>
</dependency>
<dependency>
  <groupId>software.amazon.awssdk</groupId>
  <artifactId>url-connection-client</artifactId>
</dependency>
...

And in the source code I'm injecting:
@Inject
S3Client s3client;

Everything worsk as expected in JVM mode but, in native mode, the following exception is raised:
Caused by: java.lang.IllegalStateException: The S3Client is required but has not been detected/configured.
at io.quarkus.amazon.s3.runtime.S3ClientProducer.client(S3ClientProducer.java:34)
at  io.quarkus.amazon.s3.runtime.S3ClientProducer_ProducerMethod_client_c3e44358d8bba829ee2f6ae63d6f9ef0b4609f3a_Bean.create(Unknown Source)
at io.quarkus.amazon.s3.runtime.S3ClientProducer_ProducerMethod_client_c3e44358d8bba829ee2f6ae63d6f9ef0b4609f3a_Bean.create(Unknown Source)
at io.quarkus.arc.impl.AbstractSharedContext.createInstanceHandle(AbstractSharedContext.java:113)

What am I doing wrong here ? My understanding is that the default value of the quarkus-amazon-s3_quarkus.s3.sync-client.type is url, so I don't need to declare it in application.properties, right ?
Many thanks in advance for any help.
Kind regards,
Nicolas

Some more results after carefully testing: it appears that simply injecting the s3 client, as below:
@Inject
S3Client s3client;

Results in NPE as s3client is null. In order to avoid this exception, I need to initialize it as follows:
s3client = S3Client.builder().build();

Then I get the following exception:
Multiple HTTP implementations were found on the classpath. To avoid non-deterministic loading implementations, please explicitly provide an HTTP client via the client builders, set the software.amazon.awssdk.http.service.impl system property with the FQCN of the HTTP service to use as the default, or remove all but one HTTP implementation from the classpath

After googling for a while, I came with that which seems to work:
s3client = S3Client.builder().httpClient(UrlConnectionHttpClient.builder().build()).build();

It doesn't have much sense to set the HTTP client here because, be default, it is UrlConnectionHttpClient. Of course, nothing of these happens when running in JVM mode where the injection doesn't result to null and doesn't raise NPE and where I don't need to explicitly initialize the client, once injected.

Anyone please ?

I guess the main quesiton is, in which class do you inject the s3?
Is this class managed by quarkus?

Can you  attach the maven/etc project to this issue so i can have a look?

Is a class annotated with @QuarkusTest a class managed by quarkus ?

You cannot use @inject in native mode. See Native Executable Testing for more information


CI: update to Rust 1.77.0

coverage: 59.829%. remained the same
when pulling 8c96c06b248b3bc19e3ab6c486a3802b10b3d12c on feature/ci-bump-rust
into 1e4a28928f8e6ef6b6809d30232824b80c787e9b on master.


Cache website slow? - Something delays new nodes (organizational profiles) show up in a form

Hi,
I've been experiencing this problem when I add a LLR with a new publisher (so new organizational profile), it takes over half an hour before the organizational profile can be selected in the LLR form. This used to be something instantaneous.
When I mentioned this problem to Carlos, he cleared the cache and the profile showed up right away.
Vittoria mentioned it to me yesterday as well. The profiles used to show up instantaneously. This is a small thing, but really annoying because it means that you need to take about an hour to add a LLR.
And since it used to work before properly and I am not the only one experiencing this problem, can we please change this back? And let us know what exactly happened that this changed at all?

yes this special one is particularly longer than others.
This is because listing organizations are some of the most consuming queries. We need to get you a clear cache link , can you try to get to:
https://landportal.info/admin/config/development/performance
and use the clear all caches button if you can?

Last 2 weeks we found a few odd things with organization selections.
For now the cache should be disabled in the select lists (entity references).


JsonParameterProcessor::ProcessParameters fails when different objects share property names

Describe the bug
JsonParameterProcessor::ProcessParameters fails when different objects share property names.
Expected Behavior
Process duplicated property names, since they belong to different objects.
Current Behavior
Considering these two different parameters, both containing objects with same properties and different values:
/release/api/ObjectA { "Bucket": "arnA" }
/release/api/ObjectB { "Bucket": "arnB" }

JsonParameterProcessor throws System.ArgumentException: An item with the same key has already been added.
Reproduction Steps
Configure AddSystemManager:
builder.Configuration.AddSystemsManager(source =>
{
    source.ParameterProcessor = new JsonParameterProcessor();
    source.Path = $"/release/api";
});

Create two parameter:
/release/api/ObjectA { "Bucket": "arnA" }
/release/api/ObjectB { "Bucket": "arnB" }

Map those parameters into objects:
public abstract class AbstractSettings
{
    public string Bucket { get; init; }
}

public class ObjectA: AbstractSettings {}

public class ObjectB: AbstractSettings {}

Call Services.Configure:
builder.Services.Configure<ObjectA>(builder.Configuration.GetSection("ObjectA"));
builder.Services.Configure<ObjectB>(builder.Configuration.GetSection("ObjectB"));

I expect System.ArgumentException during the second call to Services.Configure.
Possible Solution
No response
Additional Information/Context
No response
AWS .NET SDK and/or Package version used
AWSSDK.SimpleSystemsManagement <IP_ADDRESS>
Amazon.Extensions.Configuration.SystemsManager 4.0.0
AWSSDK.Extensions.NETCore.Setup 3.7.1
Targeted .NET Platform
.NET 6.0
Operating System and version
OSX Ventura

Reproducible using customer's code.

The reason why the customer's scenarios fails is that it tries to process the parameter value that starts with path that begins with /release/api and convert it to Dictionary at https://github.com/aws/aws-dotnet-extensions-configuration/blob/e60c16d143ce38ac6b15233d6f1b447ececce862/src/Amazon.Extensions.Configuration.SystemsManager/JsonParameterProcessor.cs#L35
Here, it would first process JSON value for parameter for path /release/api/ObjectA and add value with key Bucket to dictionary. When it proceeds to process JSON value for parameter for path /release/api/ObjectB, duplicate key Bucket is added and hence exception is thrown.
The desired fix might be to path separate parameters by remaining path segment (e.g. ObjectA or ObjectB or somepath/ObjectA) using configuration builder convention (which is to separate parameter path with : separator), but would not work for issue reported in the case. It's the JsonParameterProcessor, not the JsonParameterDeserializer.

Fixed in Amazon.Extensions.Configuration.SystemsManager version 5.0.0. Kindly take note of the breaking change entry in RELEASE.CHANGELOG.md.


Prep0.1.14

Codecov Report

Merging #252 (77162e8) into master (5bd5247) will decrease coverage by 0.82%.
The diff coverage is 50.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage   87.34%   86.53%   -0.82%
==========================================
  Files           9        9
  Lines        1162     1144      -18
==========================================
- Hits         1015      990      -25
- Misses        147      154       +7

Impacted Files
Coverage Δ

dash_extensions/enrich.py
85.36% <50.00%> (-0.98%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Decouples Brave from zipkin2.Endpoint

This adds methods that decouple Brave apis from zipkin2.Endpoint:

Tracing.Builder.localIp, localPort for global config
Span.remoteServiceName, parseRemoteIpAndPort for remote endpoint

Interally, a MutableEndpoint type is used, though this might be
flattened depending on future benchmarks. It is not exposed as a
public api.
Fixes #745

I owe some more tests and benchmarks, but currently happy with the shape of this.

sometimes we use the word maybe.. ex maybeRemoteIpAndPort which returns true if it is, could be more sensible than parseRemoteIpAndPort.. especially as we usually use the word parse when scraping types like HttpRequest, and in this case it is just a string and int.
@jcchavezs @devinsba @marcingrzejszczak @llinder @devinsba @shakuzen @shimamoto any preferences? I agree this method is the odd-ball, definitely need to pick something sensible.
Here are some choices with real code. I didn't add "AndSet" as there are too many ands. Plus we don't use the word "set" in any of our code, but I could be convinced.:
Parse (current)
span.remoteServiceName("backend");
span.parseRemoteIpAndPort("<IP_ADDRESS>", 8108);

  /**
   * This sets the client IP:port to the {@linkplain HttpServletRequest#getRemoteAddr() remote
   * address} if the {@link HttpServerAdapter#parseClientIpAndPort default parsing} fails.
   */
  @Override public boolean parseClientIpAndPort(HttpServletRequest req, Span span) {
    if (super.parseClientIpAndPort(req, span)) return true;
    return span.parseRemoteIpAndPort(req.getRemoteAddr(), req.getRemotePort());
  }

Maybe (different word than parse)
span.remoteServiceName("backend");
span.maybeRemoteIpAndPort("<IP_ADDRESS>", 8108);
  /**
   * This sets the client IP:port to the {@linkplain HttpServletRequest#getRemoteAddr() remote
   * address} if the {@link HttpServerAdapter#parseClientIpAndPort default parsing} fails.
   */
  @Override public boolean parseClientIpAndPort(HttpServletRequest req, Span span) {
    if (super.parseClientIpAndPort(req, span)) return true;
    return span.maybeRemoteIpAndPort(req.getRemoteAddr(), req.getRemotePort());
  }

OrFalse? (allows you to read the methods lexicographically and have a suffix telling you it is different). Might be a different suffix choice
span.remoteServiceName("backend");
span.remoteIpAndPortOrFalse("<IP_ADDRESS>", 8108);

  /**
   * This sets the client IP:port to the {@linkplain HttpServletRequest#getRemoteAddr() remote
   * address} if the {@link HttpServerAdapter#clientIpAndPortOrFalse default parsing} fails.
   */
  @Override public boolean clientIpAndPortOrFalse(HttpServletRequest req, Span span) {
    if (super.clientIpAndPortOrFalse(req, span)) return true;
    return span.remoteIpAndPortOrFalse(req.getRemoteAddr(), req.getRemotePort());
  }

PS so far I am still fine with the parse prefix as it is used everywhere else, although only zipkin2.Endpoint returns boolean when doing so.

So far, I think this is a performance win outside statistical error, even if only a few microseconds
Before
Benchmark                                            Mode  Cnt    Score   Error  Units
EndToEndBenchmarks.server_get                        avgt   15  142.404 ± 4.273  us/op
EndToEndBenchmarks.traced128Server_get               avgt   15  198.336 ± 2.636  us/op
EndToEndBenchmarks.traced128Server_get_resumeTrace   avgt   15  202.861 ± 4.952  us/op
EndToEndBenchmarks.tracedExtraServer_get             avgt   15  210.209 ± 5.718  us/op
EndToEndBenchmarks.tracedExtraServer_get_request_id  avgt   15  213.879 ± 3.727  us/op
EndToEndBenchmarks.tracedServer_get                  avgt   15  199.546 ± 3.893  us/op
EndToEndBenchmarks.tracedServer_get_resumeTrace      avgt   15  207.808 ± 5.562  us/op
EndToEndBenchmarks.unsampledServer_get               avgt   15  157.828 ± 3.170  us/op

After
Benchmark                                            Mode  Cnt    Score    Error  Units
EndToEndBenchmarks.server_get                        avgt   15  142.165 ±  3.012  us/op
EndToEndBenchmarks.traced128Server_get               avgt   15  193.668 ±  3.397  us/op
EndToEndBenchmarks.traced128Server_get_resumeTrace   avgt   15  195.480 ±  2.659  us/op
EndToEndBenchmarks.tracedExtraServer_get             avgt   15  206.897 ± 13.223  us/op
EndToEndBenchmarks.tracedExtraServer_get_request_id  avgt   15  210.645 ±  5.961  us/op
EndToEndBenchmarks.tracedServer_get                  avgt   15  191.812 ±  1.660  us/op
EndToEndBenchmarks.tracedServer_get_resumeTrace      avgt   15  197.930 ±  6.315  us/op
EndToEndBenchmarks.unsampledServer_get               avgt   15  152.701 ±  2.938  us/op

renamed Span.parseRemoteIpAndPort to remoteIpAndPort to avoid the distraction. lemme know if works for you @jcchavezs!

revised description


Fix the index iterator overflow

The index iterator would overflow when the index module stores several streams' indices.
Signed-off-by: Gao Hongtao<EMAIL_ADDRESS>

Test fails. Please fix.


Compilation fails for Envoy 1.31.0

I am building Envoy 1.31.0 from sources and i am stuck while compilation with the following error :
ERROR: /root/.cache/bazel/_bazel_root/fc9d07c8fa1ae7ff490efa6f3e8eaa23/external/com_google_cel_cpp/runtime/standard/BUILD:23:11: Compiling runtime/standard/comparison_functions.cc failed: (Exit 1): clang-14 failed: error executing command (from target @com_google_cel_cpp//runtime/standard:comparison_functions) /usr/bin/clang-14 -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -Wunused-but-set-parameter -Wno-free-nonheap-object -fcolor-diagnostics -fno-omit-frame-pointer '-std=c++14' ... (remaining 34 arguments skipped)
Clang and LLVM version - 14
bazel build command :
bazel build --config=clang envoy --cxxopt=-std=c++20 --host_cxxopt=-std=c++20
Tried if it works with c++17 or c++14, both of them did not work :(
Could someone please suggest on how to proceed?

Error when i tried to build with c++17 :
source/extensions/filters/http/match_delegate/config.cc:279:7: error: designated initializers are a C++20 extension [-Werror,-Wc++20-designator]

I haven't seen those particular errors, but it can often help to start with docker builds, and try to narrow down what's different between your and the provided working build environment
cc @phlax

I am restricted to access dockerhub, and that is the only reason to build this from sources..

/opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/type_traits:1364:23: error: incomplete type 'cel::JsonObject' used in type trait expression                     __bool_constant<__has_trivial_destructor(_Tp)>>
observed this error incomplete type 'cel::JsonObject' used in type trait expression, in all of my trails

Any leads? @alyssawilk @phlax

start by trying to build with the envoy build container - ie ./ci/run_envoy_docker.sh - once you have that working you can try building in a different environment

the problem is not obvious im afraid - we provide the build container as a known good starting point - i would suggest trying a build in an env that can access dockerhub and then ..

... once you have that working you can try building in a different environment

Sadly, our entire organization's network is blocked from accessing dockerhub. Or else i would have used the same build container to directly build the image, instead of building from sources 😞
I have previously built earlier versions of Envoy, for which i didn't face compilation errors like this.. Seeing for the first time.

Yeah unfortunately there's a lot of finicky bits that go into the Envoy build.  We've supplied docker based builds because the maintainer team can't handle the overhead of debugging other people's builds.   Sorry we likely can't help more with this :-(

Will i be able to build that docker image used in the build container locally in my environment?

yeah - the recipe is here https://github.com/envoyproxy/envoy-build-tools/tree/main/docker/linux/ubuntu
you might find it easier to download and then load it into docker tho (assuming you can inject large files into your env)

will give a try, thanks!


minimal generating set broken for S = <1>

Description
When I try to call NumericalSemigroup(generators={1}).minimal_generating_set(), I encounter a ValueError.
Steps to Reproduce

Initialize a numerical semigroup with a generator set containing only 1.
Call the minimal_generating_set method.

from pocketpartition import NumericalSemigroup

s = NumericalSemigroup(generators={1})
s.minimal_generating_set()

Expected Behavior
The method should return the minimal generating set of the numerical semigroup.
Actual Behavior
An exception is raised:
{
    "name": "ValueError",
    "message": "max() arg is an empty sequence",
    "stack": "---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-59-23fc0721115f> in <module>
----> 1 NumericalSemigroup(generators={1}).minimal_generating_set()

c:\Users\eimat\miniconda3\envs\pocketpartition_env\lib\site-packages\pocketpartition\numerical.py in minimal_generating_set(self)
    171         The algorithm used here is based on the method described by Rosales and Vasco in their works on numerical semigroups.
    172         """
--> 173         generators = self._compute_generators_from_gaps()
    174         multiplicity = self.multiplicity()
    175

c:\Users\eimat\miniconda3\envs\pocketpartition_env\lib\site-packages\pocketpartition\numerical.py in _compute_generators_from_gaps(self)
    211         list of int: The generators of the numerical semigroup.
    212         """
--> 213         multiplicity = self.multiplicity()
    214         generators = [multiplicity]
    215         frobenius_number = max(self.gaps) if self.gaps else 0

c:\Users\eimat\miniconda3\envs\pocketpartition_env\lib\site-packages\pocketpartition\numerical.py in multiplicity(self)
    132         int: The multiplicity of the numerical semigroup.
    133         """
--> 134         small_elements = self.small_elements()
    135         nonzero = [element for element in small_elements if element !=0]
    136         return min(nonzero) if nonzero else self.frobenius_number + 1

c:\Users\eimat\miniconda3\envs\pocketpartition_env\lib\site-packages\pocketpartition\numerical.py in small_elements(self)
     70         """
     71         gaps = self.gaps
---> 72         frobenius_number = max(gaps)
     73         small_elements = []
     74         for s in range(frobenius_number):

ValueError: max() arg is an empty sequence"
}

Environment

PocketPartition version: 0.1.0
Python version: 3.6
Operating System: Windows

Issue was in the multiplicity method for NumericalSemigroups. Did not handle empty gapset.


Use UTF-8 encoding when marshaling string values into librdkafka

Marshaling of string values into librdkafka (for topic names and config) is currently achieved by decorating method arguments with [MarshalAs(UnmanagedType.LPStr)]. It would be better to do this using a custom function that encodes values as UTF-8.

For reference:
https://github.com/dotnet/coreclr/pull/4793/files
Only available in netcoreapp2.0 yet (not standard)


i18n(ko-KR): update errors/

Description (required)

update errors/
#9157

Related issues & labels (optional)

Closes #
Suggested label:

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

ko
reference/errors/env-invalid-variable.mdx
Localization changed, will be marked as complete.

ko
reference/errors/invalid-rewrite404.mdx
Localization changed, will be marked as complete.

ko
reference/errors/locals-not-serializable.mdx
Localization changed, will be marked as complete.

ko
reference/errors/markdown-content-schema-validation-error.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Add support for VMware node scenarios

This commit enables support for VMware provider to run various supported
node chaos scenarios.
Fixes https://github.com/redhat-chaos/krkn-hub/issues/59

Depends on https://github.com/redhat-chaos/krkn/pull/298.

@harshil-codes PTAL. Thanks.

I couldn't test this PR as I don't have access to VMware env at the moment.

I don't have a VMWare environment either, maybe I can look with Tom Mcginnis next week?

I don't have a VMWare environment either, maybe I can look with Tom Mcginnis next week? Code lgtm

Hi @harshil-codes, PR should be good for testing. We can merge it in once we get a green signal from you and Tom. Thanks.

Okay, but which krkn-hub image would have this? Is there a qa/pre-prod image that I can use to test? Since before the merge this image "quay.io/chaos-kubox/krkn-hub:node-scenarios" will not have the vmware support

Okay, but which krkn-hub image would have this? Is there a qa/pre-prod image that I can use to test? Since before the merge this image "quay.io/chaos-kubox/krkn-hub:node-scenarios" will not have the vmware support

Hi @harshil-codes, will build a test image which includes the commit. On it. Thanks.

@harshil-codes quay.io/chaitanyaenr/node-scenarios:latest can be used for testing the commit. Let me know in case of issues. Thanks.

This PR is co-authored and tested by @tcmcginnis. Merging Tom's commits along with the changes. Thanks.


Docs typo

Didn't find where I could make a PR; there's a typo here:
Theme structure > Templates > home.hbs > "is only be used to"

Fork the repository and then you can find it in your repositories. Makes changes there and raise a PR there.

@meenal21 Oh, so the docs are here?

Thanks @a2br - this has been fixed.


Function assigned to field should be completed as function

How are you using the lua-language-server?
Visual Studio Code Extension (sumneko.lua)
Which OS are you using?
Windows
What is the issue affecting?
Completion
Expected Behaviour
When providing an alias for a function in a table, the alias should be treated as a function.
Actual Behaviour
When providing an alias for a function in a table, the alias is treated as a field and does not get completed as a function. Hover shows that the field is a function, but completion does not agree or complete with parentheses.

Reproduction steps

Use the below code

---@class myTable
local t = {}

---Does a thing
---@param a integer
---@param b string
---@param c boolean
function t.myFunc(a, b, c) end
t.myAlias = t.myFunc

Try to get completions for the function t.myAlias

Additional Notes
This would be incredibly useful for aliasing a function — something that luassert does a lot.
Log File
No response

Might be related to https://github.com/sumneko/lua-language-server/issues/1533

Current implementation:
local t = {}

t.f = function () end
t.f = function (x) end
t.f = function (x, y) end

t.f --> Shows 3 items `f()`, `f(x)` and `f(x, y)` here, based on 3 `setfield`

t.g = t.f

t.g --> Only have 1 `setfield`, I can not expand it into 3 items

Need to refactor.


Where can I change the table name

Hello new to golang, where can I change the table name? I want to change the table name according to my convinience.
Thanks

Yes pls tell how can we change table names. i am fairly new to GO and can't seem to figure out what all files do i need to change.

https://gorm.io/docs/models.html

Yes pls tell how can we change table names. i am fairly new to GO and can't seem to figure out what all files do i need to change.

Hello If you were able to change the table name please let me know how. @9872617226 /

@sachinsangwanjr  http://gorm.io/docs/models.html

Yes pls tell how can we change table names. i am fairly new to GO and can't seem to figure out what all files do i need to change.

Hello If you were able to change the table name please let me know how. @9872617226 /

yo @sachinsangwanjr check out my fork of this repo..you might get something of use.
Since i just wanted to check something by changing the table names, i changed the models.go file to have a function that would change the name of the table already defined. I don't think this is a pretty solution but gets the job done.
It goes something like :

func (Description) TableName() string {
return "atf_descriptions"
}

Yes pls tell how can we change table names. i am fairly new to GO and can't seem to figure out what all files do i need to change.

Hello If you were able to change the table name please let me know how. @9872617226 /

yo @sachinsangwanjr check out my fork of this repo..you might get something of use.
Since i just wanted to check something by changing the table names, i changed the models.go file to have a function that would change the name of the table already defined. I don't think this is a pretty solution but gets the job done.
It goes something like :

func (Description) TableName() string {
return "atf_descriptions"
}

I tried to run you fork but the table created with the regular table name.

you need to rebuild after doing these changes. and then go for fetching the data.
try going for a clean build.
If that doesn't work, i am not sure how i could help as i only wanted to check something very small and these changes worked fine for me.

If that doesn't work, i am not sure how i could help as i only wanted to check something very small and these changes worked fine for me.

Problem Solved.
New Problem: I create a new Sub  Command dbprefix to get any prefix for the tablename ....example if table name is affect and somone added -dbprefix hi_ then the table name must be hi_affect.
I am able to get the dbprefix from the command line but not able to transfer it to the file model.
Help me to send the variable to model file from fetchnvd file

you need to rebuild after doing these changes. and then go for fetching the data.
try going for a clean build.
If that doesn't work, i am not sure how i could help as i only wanted to check something very small and these changes worked fine for me.

New Problem: I create a new Sub Command dbprefix to get any prefix for the tablename ....example if table name is affect and somone added -dbprefix hi_ then the table name must be hi_affect.
I am able to get the dbprefix from the command line but not able to transfer it to the file model.
Help me to send the variable to model file from fetchnvd file


Error: Failed to connect to the adapter

zigbee2mqtt add-on version: <IP_ADDRESS> (stable)
Operating environment (HassOS, Virtual Machine, Device/platform running Home Assistant): Home Assistant OS 5.9 installed though OVA.
Supervisor 2020.12.7 (stable)
Description of problem:
Fresh install, the plugin cannot connect to the MQTT broker. Tried to install Zigbee2MQTT on a Debian with same configuration and everything works as expected. The problem seems to be related to the home assistant plugin only.
Your entire configuration from the frontend (with sensitive fields redacted):
data_path: /share/zigbee2mqtt
external_converters: []
devices: devices.yaml
groups: groups.yaml
homeassistant: false
permit_join: true
mqtt:
  base_topic: zigbee2mqtt
  server: 'mqtt://core-mosquitto'
  user: mqtt
  password: my_super_secure_password
serial:
  port: /dev/ttyACM0
advanced:
  log_level: info
  pan_id: 6754
  channel: 11
  network_key:
    - 1
    - 3
    - 5
    - 7
    - 9
    - 11
    - 13
    - 15
    - 0
    - 2
    - 4
    - 6
    - 8
    - 10
    - 12
    - 13
  availability_blocklist: []
  availability_passlist: []
device_options: {}
blocklist: []
passlist: []
queue: {}
frontend:
  port: 8099
experimental:
  new_api: true
socat:
  enabled: false
  master: 'pty,raw,echo=0,link=/dev/ttyZ2M,mode=777'
  slave: 'tcp-listen:8485,keepalive,nodelay,reuseaddr,keepidle=1,keepintvl=1,keepcnt=5'
  restartdelay: 2
  initialdelay: 2
  options: '-d -d'

Your logs from Home Assistant
Zigbee2MQTT:error 2020-12-28 19:58:22: Error while starting zigbee-herdsman
Zigbee2MQTT:error 2020-12-28 19:58:22: Failed to start zigbee
Zigbee2MQTT:error 2020-12-28 19:58:22: Exiting...
Zigbee2MQTT:error 2020-12-28 19:58:22: Error: Failed to connect to the adapter (Error: SRSP - SYS - ping after 6000ms)
at ZStackAdapter. (/zigbee2mqtt-1.16.2/node_modules/zigbee-herdsman/dist/adapter/z-stack/adapter/zStackAdapter.js:94:31)
at Generator.throw ()
at rejected (/zigbee2mqtt-1.16.2/node_modules/zigbee-herdsman/dist/adapter/z-stack/adapter/zStackAdapter.js:25:65)
npm
ERR! code ELIFECYCLE
npm ERR! errno 1
npm
ERR<EMAIL_ADDRESS>start: node index.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2020-12-28T18_58_22_218Z-debug.log
Note:
Tried with the IP : same issue.
Tried to connect though another client (Zigbee2Mqtt installed on a Debian box) : it works
No network issue : I can successfully telnet my HomeAssistant on the 1884 tcp port

My bad, I was forgetting device: deconz in my config file ..
I close the issue. Sorry !


add venidium safe contracts

What was wrong?
Missing safe contract addresses for Venidium Mainnet network
How was it fixed?
updated setup_service.py
@gnosis/safe-services

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
78 unchanged lines in 10 files lost coverage.
Overall coverage decreased (-1.2%) to 87.47%

Files with Coverage Reduction
New Missed Lines
%

safe_transaction_service/tokens/clients/kraken_client.py
3
73.53%

safe_transaction_service/history/services/collectibles_service.py
4
90.48%

safe_transaction_service/tokens/tasks.py
4
89.86%

safe_transaction_service/tokens/clients/coingecko_client.py
6
80.72%

safe_transaction_service/tokens/clients/kucoin_client.py
6
60.0%

safe_transaction_service/tokens/clients/zerion_client.py
8
78.95%

safe_transaction_service/tokens/clients/binance_client.py
11
40.74%

safe_transaction_service/tokens/clients/kleros_client.py
11
64.71%

safe_transaction_service/tokens/services/price_service.py
11
90.11%

safe_transaction_service/tokens/clients/coinmarketcap_client.py
14
47.17%

Totals

Change from base Build<PHONE_NUMBER>:
-1.2%

Covered Lines:
5857

Relevant Lines:
6696

💛  - Coveralls


Specifiy minimum npm/nodejs version in README

The README does not specify which version of node is needed to run Sia-UI, but I seem to recall that it's higher than the latest LTS release (v4.6.0).

I was about to complain that their latest LTS was two major versions behind, but apparently their v6 LTS version gets released tomorrow.
Would still be good to specify a minimum version.


SAKIII-4743 - Fix test failures in Clean JS Test

https://jira.sakaiproject.org/browse/SAKIII-4743

Verified and merged via squash.


Nominatim connection is lost

Description
Since days I cannot search within OSM, it gives no results.
I tried Nominatim search site and it works: https://nominatim.openstreetmap.org/ui/search.html
And https://www.openstreetmap.org/#map=13/47.2939/17.5988 also works
But not when I am editing in OSM and I need to find a location.
There is no error message.
Version
2.0.3
What browser are you seeing the problem on? What version are you running?
Firefox 116.0.1
The OS you're using
Windows 11 with latest updates
Steps to reproduce
Search a location.
The browser URL at the time you encountered the bug
https://rapideditor.org/edit#background=FOMI_2007_2010&datasets=fbRoads,msBuildings&disable_features=landuse,boundaries,pistes,aerialways,past_future,others&map=16.60/47.30270/17.59411
The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)
No response

Closing as a dupe of #1007


F841 fix results in statement without effect or syntax error for multiline assignments

Example for statement without effect
def fn(a, b):
    sample = a if a is not None \
        else b
    pass

Result:
def fn(a, b):
   a if a is not None \
        else b
    pass

Expected:
def fn(a, b):
    pass

Example for invalid syntax
def fn(a, b):
    sample = (
        a
        if a is not None
        else b
    )
    pass

Result:
def fn(a, b):
    a
        if a is not None
        else b
    )
    pass

Expected:
def fn(a, b):
    pass

To reproduce
ruff example.py --select F841 --fix
Proposed solution

Make fix take multiline assignments into account (https://github.com/charliermarsh/ruff/blob/main/src/rules/pyflakes/rules/unused_variable.rs#L53)

Version
ruff 0.0.223

Definitely looks like a bug (in the latter case — the former was us being conservative, but we could be more aggressive). Will take a look! Thanks for the clear issue.


ResourceOwnerPassword with ReferenceToken assumes secret type of NoSecret

Im trying to use referencetoken with a client of GrantType ResourceOwner.
But as soon as i set
AccessTokenType = AccessTokenType.Reference,
I cannot use my API. The error I get is the following
fail: IdentityServer4.Validation.HashedSharedSecretValidator[0]
      Parsed secret should not be of type NoSecret
fail: IdentityServer4.Validation.SecretValidator[0]
      Secret validators could not validate secret
fail: IdentityServer4.Validation.ScopeSecretValidator[0]
      Scope validation failed.
fail: IdentityServer4.Endpoints.IntrospectionEndpoint[0]
      Scope unauthorized to call introspection endpoint. aborting.

This is how my Client looks
  public static IEnumerable<Client> GetClients()
        {
            return new List<Client>
            {
                new Client
                {
                    ClientId = "ro.client",
                    ClientName = "ro client",
                    AllowedGrantTypes = GrantTypes.ResourceOwnerPassword,
                    AccessTokenType = AccessTokenType.Reference,

                    ClientSecrets = new List<Secret>
                    {
                        new Secret("secret".Sha256())
                    },

                    AllowedScopes = new List<string>
                    {
                        "api1"
                    }
                }
            };
        }

Otherwise its pretty much the same as your examples. Ive tried using
                SupportedTokens = IdentityServer4.AccessTokenValidation.SupportedTokens.Reference,
on my api configuration but it doesnt change anything.
The Identification and Api works fine as long as I dont use AccessTokenType.Reference on my client settings.

Apparently the problem was because I didnt use AddConfigurationStore. I thought only AddOperationalStore was necessary to share tickets

Have you set a scope secret for for your API?

You are the correct. I had Scope secret but wasnt cleaver enough to actually use it in my API..
Thanks


#17835 full name for arrays

Uses full name for the array datatype
Test for array datatype
Closes #17835

Please attach screenshot with new DDL info

Still no screenshot here.

Attached the screenshot

Verified


Add help command to list available commands

With many new commands, help is needed. Most preferably, the help is printed when the bot is tagged in a message with help.

This help should be able to read from the code and not listed manually. This mean index.js needs to be refactored.

So this means we put all cmds and paths into a json.

Yep, but I haven't figured out how yet

I am not an expert in js stuff but I found this maybe it can help.
https://www.npmjs.com/package/discord-command-parser

It doesn't address this problem, but I need this so thanks.


What is Maximum utilization?

I Can't find anywhere what is the maximum utilization. What is it for?
Thanks

From https://github.com/dnauck/Portable.Licensing/blob/6ec8ce3b20d057b0da6d8e58f2c96a683a75a339/src/Portable.Licensing/LicenseBuilder.cs
// Sets the maximum utilization of the <see cref="License"/>.
// This can be the quantity of developers for a "per-developer-license".

but I guess it's whatever you want it to be, depends on how you assert it.


[CCXDEV-10802] [CCXDEV-10801] Updated message queue LOG message

Description
Changed log message from "No new messages in the queue since 2023-08-16- 19:03:36" to "No new messages in the queue" to stop duplicating errors in Glitchtip
Fixes # (issue)
Type of change
Please delete options that are not relevant.

Refactor (refactoring code, removing useless files)

Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.03% :warning:

Comparison is base (bb964da) 85.84% compared to head (0d227cd) 85.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   85.84%   85.82%   -0.03%
==========================================
  Files          23       23
  Lines         657      656       -1
==========================================
- Hits          564      563       -1
  Misses         93       93

Files Changed
Coverage Δ

ccx_messaging/consumers/kafka_consumer.py
98.40% <100.00%> (-0.02%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: allow toggling vibrant color for all charts

supports new config key app.vibrant_color or env WAKAPI_VIBRANT_COLOR
updates and extends data/colors.json with editor and os colors
fixes #343

hi @muety, please review

Great contribution, thanks a lot! To be honest, I was thinking to have this vibrant color toggling more on a per-user basis, rather than globally for the whole server. Like an option somewhere on the settings or a small, subtle toggle switch on the dashboard page or inside a chart container to swap between "muted" and "vibrant" colors. That switch would simply set a boolean value in the user's browser's localStorage (would not actually persist that server-sided), depending on which the respective color palette is chosen.
Would you be willing to change your current implementation accordingly? Large parts can still be kept of course.

Great contribution, thanks a lot! To be honest, I was thinking to have this vibrant color toggling more on a per-user basis, rather than globally for the whole server.

ok sure, that sound better. i'll add follow-up commits here.

That switch would simply set a boolean value in the user's browser's localStorage (would not actually persist that server-sided)

i guess this pref can be added to the users table. i won't want to toggle this setting every time i login to wakapi from a new browser.

i guess this pref can be added to the users table. i won't want to toggle this setting every time i login to wakapi from a new browser.

Since it would ideally be literally just one button click, I think it's a bit of overkill to persist that setting to the database. Do whatever you prefer, though.

Any news here? :)

Any news here? :)

hi sorry got busy with other stuff, will update this later if it's okay.

@muety hi how's this now?

Thanks a lot! This is exactly how I imagined it! Only did very few code changes in addition.


Code Availability

Hi,
are you planning to release the code and trained models?

Thank you for your question. We are sorry to tell you that we only provide training data for training models and do not intend to open source the code and model. You can submit calculations through the open source website we provide.

Hi,
are you planning to release the code and trained models?


Support for emojis

Hi, I tried to render a piece of HTML containing emojis, but they are not displayed - each one is replaced by a couple of empty square blocks.
Perhaps you can provide me with the necessary info so I can help fix this?

I got it to work (using the Avalonia-HtmlRenderer version) using the HTML entities for the emoji's Unicode codepoint.
So for example to show 👀 the codepoint is U+1F440. Then in the HTML you substitute the U+ with &#x so it becomes &#x1F440.


bug: edge-drag-threshold doesn't work on the first view

Type: bug
Platform: all
I have an issue where the edge-drag-threshold doesn't take effect on the first time view in a side menu, as someone else also found in http://forum.ionicframework.com/t/issue-with-ionic-side-menu-and-ignored-edge-drag-threshold/16378/2
I noticed that when you navigate to another menu view then it starts working as expected
The starter of the forum thread has this codepen demonstrating the issue
http://codepen.io/halfpt/pen/LELbXa
It's using beta14, which is where the regression occurred.  If you change the links to beta13 then it works as expected.  Also when changing to rc.2 the issue is still there.

Greetings @campers!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Are you still seeing this in rc3? It seems to be working fine for me? Is it only on certain devices?

Yeah I just changed the codepen to rc.3 and still saw the issue in Chrome and Safari.  I've also tested with an Android 4.4 phone.

Looking into this more, it seems to work on that first initial view, login. What you have to do is set the nextView to be the root of the navigation.
http://codepen.io/mhartington/pen/raXqxW
 .controller('LoginCtrl', function($scope, $ionicHistory) {
  $ionicHistory.nextViewOptions({
    historyRoot: true
  })
})

Thanks, that does the trick. Maybe add a note to the docs?

So would you potentially have to make that call in every controller to make sure the edge dragging worked on the next view? That doesn't seem like a fix but rather a temporary workaround.

No you wouldn't have to add that to every controller. The issue here is that the link from the login page messes with the side-menu's navigation logic. Another solution would be to put a menu-close attribute on the logic link.
http://codepen.io/anon/pen/WveoGV

So why doesn't the edge dragging work on the 'Facts' page in that code pen, which also uses a menu-close attribute?

Because of enable-menu-with-back-views, which is enabled by default. This will disable the menu on any non history root view.
http://ionicframework.com/docs/api/directive/ionSideMenus/#api

Makes sense, thank you!

In the codepens mentioned in this thread (http://codepen.io/anon/pen/WveoGV and http://codepen.io/mhartington/pen/raXqxW) edge-drag-threshold doesn't work as expected. At least for me.
If you click on login, edge-drag-threshold works correct on the next page in the first tab. You can only open a side-menu if you start swiping close to the border of the viewport. If you switch to the next tab, you can swipe from anywhere to open side-menu.
Does this has anything to do with setting historyRoot:true in $IonicHistory.nextViewOptions? Or is it a bug?
Using two side-menus (left and right) you're able to open the side-menu on the opposite by continue swiping after closing a side-menu. That's not very good, especially if you set edge-drag-threshold to true or a Number > 0.
Is there a solution?
Thanks!


feat: lower FSharp.Core requirements

Hello @cmeeren,
This PR is a suggestion I choose to make it via a PR instead of an issue because it is easier to showcase the impacted code.
I am currently exploring writing test for .NET and found your library. While giving it a try, I had this warning:
warning NU1605: Detected package downgrade: FSharp.Core from 7.0.400 to 5.0.2. Reference the package directly from the project to select a different version.
warning NU1605:  Ionide.XmlDocFormatter.Tests -> Faqt 4.0.0 -> FSharp.Core (>= 7.0.400)
warning NU1605:  Ionide.XmlDocFormatter.Tests -> FSharp.Core (>= 5.0.2)

This is happening because when creating a library I make FSharp.Core requirements as low as possible and in general I use FSharp.Core 5.0.2 because it has most of the goodies that are needed now days.
I am following the recommendation from F# Compiler Guide:

As an F# package author, you also need to make this decision with respect to FSharp.Core:

Targeting an earlier version of FSharp.Core increases your reach because older codebases can use it without issue
Targeting a newer version of FSharp.Core lets you use and extend newer features

This decision is critical, because it can have a network effect. If you choose a higher FSharp.Core version, then that also becomes a dependency for any other package that may depend on your package.

In my projects, I am using central package management which allows to handle versions for the packages at a single place instead of having to update each project individually. Because of these 2 reasons, I am getting the warning mentioned above when adding Faqt.
While looking at Faqt code, I discovered that there was only 1 place which needed a more recent version of FSharp.Core so I think it can be good to make the proposed change. It also means that Faqt can be used by a wider set of project without requirement then to depends on a newer version of FSharp.Core.

Thanks! This sounds good. Could you change the code to the following?
if countsLeft |> Map.forall (fun _ v -> v = 0) then

@cmeeren I made the changes

Releasing shortly in v4.0.1. Thanks again!


Theme will not import in Rstudio Daily Build

Hi there, I get a error when I try to add your theme:

In the console I get:
Error in regexpr(pattern, text, ignore.case = ignore.case, useBytes = useBytes,  :
invalid input '
Using RStduio 1.2.1327 on Windows 10.
Thanks

Hi @renekyewski,
Have you tried installing any other themes? You could download any of the .tmThemes here and see if they import for you: https://tmtheme-editor.herokuapp.com/#!/editor/theme/Atom Dark
I haven't changed anything in quite some time, so it might be an IDE issue, and not one I can fix on my end. (@MariaSemple – do you have any hints?)

You can also try importing the tmtheme file instead.

That was a fast reply :)
The Atom Theme with the link you sent me imported fine. Yours also does not work as the tmtheme file. This time giving me a different error:

Hmm… It's possible it's an encoding error (I'm on a Mac – don't have Windows to test). I just made a duplicate and imported it which worked fine (I'm using 1.2.1326, not .1327, but it would surprise me if that's the difference).
Here's the dummy theme:
https://gist.github.com/batpigandme/d84e1535f31c848f5902d4f0cfd9839b
What happens if you copy the text, and paste it into a file in a text editor? (Just save as <whateveryouwant>.rstheme).

Hmm, and that's a different error with the .tmtheme — I have no clue what Specification mandate value for attribute data-pjax-transient [41] means, but maybe that'll be a clue. 🤔

Manually pasting it and creating a new file did the job. Thanks for your help.

Awesome! I have zero clue why, but I'm glad it worked! 🎉


Documentation Changes for Git Usage, Branching Model, and Release Management

Modifying and expanding documentation related to release management and new Git branching model.
Additions

New RELEASE_MANAGEMENT.md doc with details on release process

Removals

Deleted gitflow.md doc in favor of using GIT_USAGE.md

Changes

Modified GIT_USAGE.md appropriately for move to new branching model
Moved a few items present in gitflow.md - in particular on pre-commit integration - to GIT_USAGE.md

Testing

None; doc updates only

Todos

The specifics for "testing and quality pre-release tasks" during the release process need to be decided upon and documented.
The exact process for peer reviewing changes made to release branches (e.g., bug fixes) during the release process needs to be decided upon and documented.

Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[x] Visually tested in supported browsers and devices (see checklist below :point_down:)
[x] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[x] Reviewers requested with the Reviewers tool :arrow_right:

Sure, @christophertubbs, that shouldn't be any trouble.

I think it looks good - thanks for putting up with my nit-picking!


Given name may not be shown

Describe the issue
I noticed that NIST IR 8441 ipd shows only author’s surname.

It appears that the underlying data source has author’s given name specified as ...person.name.given.forename[].content, whereas the template expects ...person.name.forename[].content.
Fix might be as simple as changing val.forename to val.given.forename on line 3 of person_name.html, but not 100% sure.

To assess after the fact:
Could be that source data source’s schema changed to add the intermediate given component without the template being updated correspondingly?
I believe we have designed it such that source-generating Ruby gems will be pinned to their minor versions, meaning data shape wouldn’t be affected unintentionally. Looks like either 1) this pinning system is broken, or 2) gem versions were updated without checking schema changes and adjusting templates accordingly, or 3) the people who publish gems accidentally made a schema-altering change under a patch version.
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

(Stefano separately mentioned it might be due to a not very well-tested gem version update, and he’s looking into it.)


Update abide.md

Provide example for form and element events listener.

Thanks! This is super useful.


Mobile UX: Lock Y scroll while swiping

Testing the waters on this, as this is how native clients tend to implement "swipe to archive." People tend to swipe on a diagonal, and a Y scroll lock during swipe keeps the screen from jittering. I also rarely like it when sites hijack scroll behavior, but I think this is a positive UX improvement. Would a PR be accepted for this? Thanks!

I didn't notice that on my iPhone. Is it happening only for some devices?

Seeing this on Android + Firefox. I'll try and work in a PR next weekend. Small tweak, but worth it IMO.

I don't think I'll be able to work on this for a while—happy to re-visit in a few weeks and/or if someone else stumbles upon this and sees the same. Otherwise, I think it's best to close for now.


Add detailed comment, simplify model, do ANOVA

For you to consider.

I think it's super useful to write out what we're testing, for clarity
Simplified model to just have Plot as a random effect, and not test for DBH by itself
Add dependencies on car and sjPlot packages for doing type III ANOVA and pretty-printing model in HTML

I find this clearer, and easier to think about.

Looks awesome thanks for the additions!


release 3.3.X breaks support for gradle < v3.3

Obviously since Gradle 3.3 was released in Jan 2017, that may not be a huge issue [1], but it might be worth documenting so that users aren't confused when updating the plugin version breaks their build. As far as I can tell from a quick glance, the breaking change was here due to use of the org.gradle.api.attributes.Attribute class, which was introduced in Gradle version 3.3
[1]: YMMV, but in my experience, way too many projects rarely, if ever, update their gradle wrapper unless something breaks, so I still see Gradle 2.X quite often.

It looks like the current minimum version of gradle for dependency-check-gradle 3.3.x is 4.0.  I'm debating putting the older dependency resolution back in and use it when the gradle version is less then 4.0 or just saying the minimum gradle version is 4.0.