Move tab close "x" to left-side for easy access

VSCode Version: Code 1.7.1 (02611b40b24c9df2726ad8b33f5ef5f67ac30b44, 2016-11-03T13:46:00.226Z)
OS Version: Darwin x64 16.0.0
Extensions:

Extension
Author
Version

xml
DotJoshJohnson
1.6.0

vscode-docker
PeterJausovec
0.0.7

code-settings-sync
Shan
2.3.8

githistory
donjayamanne
0.1.0

python
donjayamanne
0.5.2

haml
groksrc
0.0.2

Go
lukehoban
0.6.49

csharp
ms-vscode
1.5.2

Ruby
rebornix
0.10.2

Steps to Reproduce:

Open multiple tabs
See how the closing "x" in on the right-side? Move it to the left-side.

One of the things Safari gets right is its placement of the tab close "x". By placing it on the left, you can quickly close tabs without moving the pointer about (since the left-side remains constant, while the right-side moves about based on tab name). It would be nice if VSCode did likewise. :)

Why not just "Right click" and select "Close to the right"?

@TheColorRed Far, far less obvious and it is more clicks: One right-click to bring up the menu, second click to select "Close to the right." Better a single click on a left-justified "x". It's why Safari works this way.

I don't see where you get more clicks from...

Option 1 (middle mouse click): 1 click per tab
Option 2 (close to the right): 2 clicks for unlimited number of tabs

@TheColorRed Try Safari and you'll see the feature I'm after. I don't want to always close all tabs to the right.

@brendandixon I understand what you're saying... What I am saying is just place your mouse on the left side of the tab (or anywhere on the tab), and just middle mouse click it. You will get the same close effect.

@bpasero @jrieken Would a external contributor's PR for this feature be considered?

@reaktivo yes, we are always open to PRs as long as they make sense 👍

Verify: there is a new setting workbench.editor.tabCloseButton with the options left, right and off.  Changes update live and the dirty indicator is still always visible.


Add support for WD_CHROME_PATH.

Adds support for WD_CHROME_PATH environment variable. WD_CHROME_PATH takes precedence over Selenium::WebDriver::Chrome.path. Closes #137.

Other changes:

WD_INSTALL_DIR now has the highest precedence when determining the driver install (download) location. This is to make the behavior consistent with WD_CACHE_TIME and WD_CHROME_PATH.
Removed ENV handing logic from the rake tasks. They now rely on the core code to handle these.

UPDATE:

Fix bug where ENV vars took precedence over user defined configs in their project. The new order is:

User defined config
User defined ENV var
Default value

As implemented ENV['WD_CHROME_PATH'] is preferred over Selenium::WebDriver::Chrome.path - I think that should probably be the other way around since code setting is more deliberate than environment variable.

As discussed on Slack, the current behavior of ENV taking precedence over code is now categorized as a bug. I'll update the PR tonight with the new order:

User defined config
User defined ENV var
Default value

This way, any deliberate changes in the code will take precedence over ENV values.

@twalpole PR is ready for second review.

That looks better - 👍


[8.4.0] distro/rhel84: build qcow2 images with compat=0.10

By default, qemu-img convert creates qcow2 images usable in qemu 1.1 and
newer. RHEL 8 guest images are meant to be bootable on RHEL 6 though.
Unfortunately, RHEL 6 has qemu 0.12, therefore these images cannot be used
there.
To fix this, we need to use the new qcow2_compat option in qemu assembler
to override the default compat version and make qcow2 images that can be used
in qemu 0.10 and newer.
For this, we need a newer osbuild, therefore we need to change the pinning
in Schutzfile.
This pull request includes:

[x] adequate testing for the new functionality or fixed issue
[x] adequate documentation informing people about the change such as

[x] create a file in news/unreleased directory if this change should be mentioned in the release news
[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

Will this be added to the main branch as well?  Should we close #1344 and rebase this instead (later)?

Will this be added to the main branch as well? Should we close #1344 and rebase this instead (later)?

Yes but for that, we need a new osbuild release from the main branch, @gicmo is working on it.

force-pushed a unit test fix - I forgot to regenerate CentOS manifests.

We actually have to change all manifests because of the new image-info format otherwise image tests are failing. I force-pushed a fix.


Command line widget

Suggested new feature or improvement
I have multiple fun and handy widgets suggestions:

a command line widget, kinda weird that this isn't already a thing, maybe with custom commands etc...
a GitLab widget just like GitHub's one
a Spotify widget, because which developer doesn't listen music??
I love this, although it's just a preview!!! Keep up the good work!

Scenario
Fast command line acces (with maybe custom/pinned commands...), kinda opvious
A gitlab implementation just like Github's one would be realll cool too!!
Ofcourse a Spotify widget would be handy too..
Additional details
No response

A command line widget is an interesting idea!
Interest in a GitLab widget is being tracked by #794. Please go give it a thumbs up!
Spotify does ship with a widget that you can currently use in the Windows Widget Dashboard (accessed by 🪟+W key combo). At the moment, we limit the available widgets we show in Dev Home, but will open up to more in the future. I expect we'll use #908 to track that one.

It's much easier for us to track one ask per issue, and since your numbers 2 and 3 are covered elsewhere, I'm going to change the title and treat this as an ask for #1.
Additionally, you're more than welcome to create your own Dev Home extension(s) with the widget(s) you want to see!

Awesome!! Thanks, I didn't expect an answer :). I love the idea 👍


Debug - Unable to hit a breakpoint for git modified files and other oddness

Environment data
dotnet --info
.NET Command Line Tools (1.0.0-preview2-1-003177)

Product Information:
 Version:            1.0.0-preview2-1-003177
 Commit SHA-1 hash:  a2df9c2576

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.10
 OS Platform: Darwin
 RID:         osx.10.10-x64

VSCode Version: 2fbc979 Version 1.13.0-insider (1.13.0-insider)
C# Extension version: 1.9.0
Steps to reproduce
Modify git source controlled file.
Save.
Set breakpoint.
Go to debugger - hit the "play" button to start debugging.
Notice that breakpoint is not hit.
Additionally, when hitting a breakpoint in a non-modified file, then stepping into the git-modified file finds the breakpoint highlight misplaced. This is recent behavior. It used to "work the right way" before.

See Microsoft/vscode/issues/26846

cc @gregg-miskelly


Cannot Download output file from Galaxy

Hello,
I have successfully installed Galaxy and deployed it in the Kubernetes cluster. I ran some analysis using Prokka and it completed the analysis and produced some output files. But I cannot download the output files. If I click on the download button, I receive an error message. I have attached the error message. Could anybody please suggest how to solve this issue?
This is the value.yaml file:
galaxy:
  fullnameOverride: galaxy
  nameOverride: galaxy
  revisionHistoryLimit: 3
  images:
    galaxy:
      repository: quay.io/galaxyproject/galaxy-min
      tag: "23.1"  # Value must be quoted
      pullPolicy: IfNotPresent
  refdata:
   enabled: false
   type: cvmfs
   pvc:
     size: 10Gi
  cvmfs:
    deploy: false
    storageClassName: "{{ $.Release.Name }}-cvmfs"
  persistence:
    enabled: true
    name: galaxy-pvc
    annotations: {}
    storageClassName: XXX
    existingClaim: galaxy-kubernetes-pvc
    accessMode: ReadWriteMany
    size: 200Gi
    mountPath: /galaxy/server/database
  rabbitmq:
    enabled: true
    deploy: true
    persistence:
      storageClassName: XXX
  celery:
    concurrency: 1
  postgresql:
    enabled: true
    deploy: true
    galaxyDatabaseUser: postgres
    galaxyDatabasePassword: XXXXXX
  configs:
    galaxy.yml:
      galaxy:
        admin_users<EMAIL_ADDRESS>
This is the ingress.yaml file:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: galaxy.XX.XX.cloud
  namespace: galaxy
  annotations:
    cert-manager.io/cluster-issuer: letsencrypt-production
    kubernetes.io/tls-acme: "true"
    nginx.ingress.kubernetes.io/ssl-passthrough: "false"
    nginx.ingress.kubernetes.io/backend-protocol: HTTP
    nginx.ingress.kubernetes.io/proxy-body-size: "0"
spec:
  ingressClassName: nginx
  rules:
    - host: galaxy.XX.XX.cloud
      http:
        paths:
          - backend:
              service:
                name: galaxy-nginx
                port:
                  number: 8000
            path: /
            pathType: Prefix
  tls:
    - hosts:
        - galaxy.XX.XX.cloud
      secretName: galaxy.XX.XX.cloud

It would be great if you could provide me with any guidance.
TIA

Can you show your configuration for the ingress section in values.yaml? By default, it's configured to run under the /galaxy prefix, but looking at your ingress, it looks like it's running under /. If so, you should configure he ingress values to match as follows:
ingress:
  path: /
  hosts:
    - host: ~
      paths:
        - path: "/"
        - path: "/training-material"

If that's not configured, the galaxy internal nginx server could be picking up the wrong prefix when serving datasets, hence the issue with datasets only.

I do not have any ingress section in the value.yaml file. I have pasted the whole values.yaml file above. Should I copy the ingress code that you just shared?

Aah, that probably explains it - I take it you created the ingress shown above by hand? You can get the helm chart to create the ingress for you by setting values appropriately. And yes, you can use the values shown above, but will probably also need to include a tls section and set the host value + annotations to match your environment. Take a look at the values.yaml for sample values.

Hi @nuwang thanks for the helpful tips. Yes, I have created the ingress file by hand. How can I get the helm chart to create the ingress file? Could you please explain? Sorry, I am new in this field. So, maybe I am not understanding the simple things.
I got this following section from the original values-org.yaml file from the galaxy github.
ingress:
    enabled: true
    ingressClassName: nginx
    annotations:
      nginx.ingress.kubernetes.io/proxy-request-buffering: "off"
      nginx.ingress.kubernetes.io/proxy-buffering: "off"
      nginx.ingress.kubernetes.io/proxy-http-version: "1.1"
      nginx.ingress.kubernetes.io/connection-proxy-header: "Upgrade"
      nginx.ingress.kubernetes.io/proxy-body-size: "0"
    hosts:
      - host: ~
        paths:
          - path: "/galaxy/api/upload/resumable_upload"
    tls: []

I think you've extracted the tusd section. The main section you need to modify is here:
https://github.com/galaxyproject/galaxy-helm/blob/0afe341dcae427832ac232c8d87c842436daf971/galaxy/values.yaml#L270
And afterwards. you can update the tusd section to match.
Something like:
ingress:
  annotations:
    cert-manager.io/cluster-issuer: letsencrypt-production
    kubernetes.io/tls-acme: "true"
    nginx.ingress.kubernetes.io/ssl-passthrough: "false"
    nginx.ingress.kubernetes.io/backend-protocol: HTTP
    nginx.ingress.kubernetes.io/proxy-body-size: "0"
  path: /
  hosts:
    - host: galaxy.XX.XX.cloud
      paths:
        - path: "/"
        - path: "/training-material"
  tls:
    - hosts:
        - galaxy.XX.XX.cloud
      secretName: galaxy.XX.XX.cloud

Hello @nuwang Thanks for the suggestions. I have modified the values.yaml file like below:
galaxy:
  fullnameOverride: galaxy
  nameOverride: galaxy
  revisionHistoryLimit: 3
  images:
    galaxy:
      repository: quay.io/galaxyproject/galaxy-min
      tag: "23.1"  # Value must be quoted
      pullPolicy: IfNotPresent
  refdata:
    enabled: false
    type: cvmfs
    pvc:
      size: 10Gi
  cvmfs:
    deploy: false
    storageClassName: "{{ $.Release.Name }}-cvmfs"
  persistence:
    enabled: true
    name: galaxy-pvc
    annotations: {}
    storageClassName: freenas-nfs-csi
    existingClaim: galaxy-k3s-rdloc-galaxy-pvc
    accessMode: ReadWriteMany
    size: 200Gi
    mountPath: /galaxy/server/database
  rabbitmq:
    enabled: true
    deploy: true
    persistence:
      storageClassName: freenas-iscsi-csi
  celery:
    concurrency: 1
  postgresql:
    enabled: true
    deploy: true
    galaxyDatabaseUser: postgres
    galaxyDatabasePassword: password
  configs:
    galaxy.yml:
      galaxy:
        admin_users<EMAIL_ADDRESS>
# The suggested ingress configuration to be added to the values.yaml:
ingress:
  enabled: true
  ingressClassName: nginx
  annotations:
    cert-manager.io/cluster-issuer: letsencrypt-production
    kubernetes.io/tls-acme: "true"
    nginx.ingress.kubernetes.io/ssl-passthrough: "false"
    nginx.ingress.kubernetes.io/backend-protocol: HTTP
    nginx.ingress.kubernetes.io/proxy-body-size: "0"
  hosts:
    - host: galaxy.XX.XX.cloud
      paths:
        - path: /
          pathType: Prefix
        - path: /
          pathType: Prefix
  tls:
    - hosts:
        - galaxy.XX.XX.cloud
      secretName: galaxy.XX.XX.cloud

tusd:
  enabled: true

  ingress:
    enabled: true
    annotations:

    hosts:
      - host: galaxy.XX.XX.cloud
        paths:
          - path: /
            pathType: Prefix

But it did not solve the Download output files issue. I am still getting  the same error message that I showed.
Besides, there is another issue. After making these changes, I tried to upload a datafile in Galaxy and there is also an error message and the data file cannot be uploaded.
The error message is:
/bin/bash: line 1: /galaxy/server/database/jobs_directory/000/42/galaxy_42.sh: No such file or directory
This is the description file of the galaxy job from Kubernetes:

Name:                 gxy-galaxy-k3s-rdloc-ttmkc-4xdkq
Namespace:            galaxy
Priority:             -1000
Priority Class Name:  galaxy-job-priority
Service Account:      default
Node:                 xxx/xxxx
Start Time:           Mon, 08 Apr 2024 15:43:48 +0200
Labels:               app.galaxyproject.org/destination=k8s
                      app.galaxyproject.org/handler=job_handler_0
                      app.galaxyproject.org/job_id=41
                      app.kubernetes.io/component=tool
                      app.kubernetes.io/instance=gxy-galaxy-k3s-rdloc
                      app.kubernetes.io/managed-by=galaxy
                      app.kubernetes.io/name=x__DATA_FETCH__x
                      app.kubernetes.io/part-of=galaxy
                      app.kubernetes.io/version=0.1.0
                      batch.kubernetes.io/controller-uid=xxxx
                      batch.kubernetes.io/job-name=gxy-galaxy-k3s-rdloc-ttmkc
                      controller-uid=44343ed2-1e80-45fc-9b43-d474daea53d2
                      job-name=gxy-galaxy-k3s-rdloc-ttmkc
Annotations:          app.galaxyproject.org/tool_id: __DATA_FETCH__
Status:               Failed
IP:                   XX
IPs:
  IP:           XX
Controlled By:  Job/gxy-galaxy-k3s-rdloc-ttmkc
Containers:
  k8s:
    Container ID:  containerd://XX
    Image:         quay.io/galaxyproject/galaxy-min:23.1
    Image ID:      quay.io/galaxyproject/galaxy-min@sha256:XXX
    Port:          <none>
    Host Port:     <none>
    Command:
      /bin/bash
    Args:
      -c
      /galaxy/server/database/jobs_directory/000/41/galaxy_41.sh
    State:          Terminated
      Reason:       Error
      Exit Code:    127
      Started:      Mon, 08 Apr 2024 15:43:50 +0200
      Finished:     Mon, 08 Apr 2024 15:43:50 +0200
    Ready:          False
    Restart Count:  0
    Limits:
      cpu:     1
      memory:<PHONE_NUMBER>200m
    Requests:
      cpu:     1
      memory:<PHONE_NUMBER>200m
    Environment:
      GALAXY_SLOTS:               1
      GALAXY_MEMORY_MB:           4080
      GALAXY_MEMORY_MB_PER_SLOT:  4080
    Mounts:
      /cvmfs/cloud.galaxyproject.org from galaxy-k3s-rdloc-galaxy-pvc (rw,path="cvmfsclone")
      /galaxy/server/database from galaxy-k3s-rdloc-galaxy-pvc (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-rfcvn (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  galaxy-k3s-rdloc-galaxy-pvc:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  galaxy-k3s-rdloc-galaxy-pvc
    ReadOnly:   false
  kube-api-access-rfcvn:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   Guaranteed
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 20s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 20s
Events:                      <none>

Can you please suggest how to overcome these issues? I am a bit lost as to where this error is originating from.
Thank you very much.

Any update @nuwang?

Hey @DuttaAnik. In your latest values, you seem to have changed the paths under ingress.hosts.paths, but not under ingress.path as shown in Nuwan's example. Also, you have two identical paths for /. There might be other issues which might be hard to diagnose without access to your cluster, but something to try that might help is replacing:
ingress:
  enabled: true
  ingressClassName: nginx
  annotations:
    cert-manager.io/cluster-issuer: letsencrypt-production
    kubernetes.io/tls-acme: "true"
    nginx.ingress.kubernetes.io/ssl-passthrough: "false"
    nginx.ingress.kubernetes.io/backend-protocol: HTTP
    nginx.ingress.kubernetes.io/proxy-body-size: "0"
  hosts:
    - host: galaxy.XX.XX.cloud
      paths:
        - path: /
          pathType: Prefix
        - path: /
          pathType: Prefix

with
ingress:
  path: /
  enabled: true
  ingressClassName: nginx
  annotations:
    cert-manager.io/cluster-issuer: letsencrypt-production
    kubernetes.io/tls-acme: "true"
    nginx.ingress.kubernetes.io/ssl-passthrough: "false"
    nginx.ingress.kubernetes.io/backend-protocol: HTTP
    nginx.ingress.kubernetes.io/proxy-body-size: "0"
  hosts:
    - host: galaxy.XX.XX.cloud
      paths:
        - path: /
          pathType: Prefix

and let us know if that changes anything.

What chart are you using to install Galaxy? The values you provided do not coincide with the values for the galaxy-helm chart.  For example, the root level galaxy: element and the galaxy-helm chart expects persistence.storageClass but you have persistence.storageClassName.  So you may want to check the PVC and make sure it is using the storage class it is supposed to be using. You mention having a galaxy_ingress.yaml file in the templates folder, if you set ingress.enabled = true in the values file that extra template may be causing conflicts when the Helm chart tries to setup an ingress.  You should likely use one or the other.
Also, what version of Kubernetes are you using?  I saw similar errors with Galaxy 23.x on later versions of Kubernetes due to an incompatibility with the version of py-kube used by Galaxy.  That was fixed in 24.0 so you may want to try that Galaxy version.
Finally, I don't think the path in your tusd section is correct.  It should likely be something like:
tusd:
    hosts:
      - host: galaxy.XXX.cloud
        paths:
          - path: /api/upload/resumable_upload
            pathType: Prefix

If that doesn't solve your problem can you kubectl exec into the job pod and check the owner and permissions of the files in /galaxy/server/database/jobs_directory.  Those should be owned by the galaxy user and Galaxy should be running as the galaxy user.

Hi @ksuderman thank you for the reply and sorry for the delayed response. The Chart.yaml I am using to install Galaxy looks like this:
apiVersion: v2
name: galaxy
type: application
version: 1.0.0
dependencies:
 - name: galaxy
   repository: https://github.com/CloudVE/helm-charts/raw/master
   version: 5.9.0

The Kubernetes version is: v1.27.7+k3s2
The YAML for the PVC that I created (pvc-galaxy-k3s-rdloc-galaxy-pvc.yaml
) looks like this:
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  labels:
    app.kubernetes.io/instance: galaxy-k3s-rdloc
    app.kubernetes.io/name: galaxy
  name: galaxy-k3s-rdloc-galaxy-pvc
  namespace: galaxy
spec:
  accessModes:
    - ReadWriteMany
  resources:
    requests:
      storage: 200Gi
  storageClassName: freenas-nfs-csi

With the values.yaml file that I pasted in the first message, everything regarding the file upload was working smoothly, except the Downloading of output files. Then, I increased the PVC size to 400Gi from 100Gi but later on reduced to 200Gi. So, Once I increased the PVC to 400Gi, I could not reduce it. So, I deleted that PVC and created a new PVC with 200Gi. I checked with kubectl that the new PVC is there under the namespace of galaxy and the old one was removed. Then, I deployed again through ArgoCD and since then the upload does not work anymore.
I have also removed ingress.enabled=true from the values file and still it is not working.
Finally, I did kubectl to look into the kubernetes job pod:
kubectl describe pod galaxy-job-0-adad6b6c7-j9lc4 -n galaxy
Name:             galaxy-job-0-adad6b6c7-j9lc4
Namespace:        galaxy
Priority:         0
Service Account:  galaxy
Node:             XXXX
Start Time:       Tue, 09 Apr 2024 11:16:08 +0200
Labels:           app.kubernetes.io/component=galaxy-job-handler
                  app.kubernetes.io/instance=galaxy-k3s-rdloc
                  app.kubernetes.io/name=galaxy
                  pod-template-hash=adad6b6c7
Annotations:      checksum/galaxy_conf: XXXX
                  checksum/galaxy_extras: aaaa
                  checksum/galaxy_rules: aaaaa
Status:           Running
IP:               XXX.XXX.XX
IPs:
  IP:           XXX.XXX.XX
Controlled By:  ReplicaSet/galaxy-job-0-adad6b6c7
Init Containers:
  galaxy-wait-db:
    Container ID:  containerd://e5e4f307e99927a68cc28c00d1129126d791bb949d7791c9adab5a71fed920d5
    Image:         quay.io/galaxyproject/galaxy-min:23.1
    Image ID:      quay.io/galaxyproject/galaxy-min@sha256:aac7ab9f8f9422b76f62344c02ddc8772a1ee893accbfebf98ad7e9d7bfcaf6e
    Port:          <none>
    Host Port:     <none>
    Args:
      sh
      -c
      until [ -f /galaxy/server/config/mutable/db_init_done_1 ]; do echo "waiting for DB initialization"; sleep 1; done; until timeout 1 bash -c "echo > /dev/tcp/galaxy-k3s-rdloc-rabbitmq-server/5672"; do echo "waiting for rabbitmq service"; sleep 1; done; until [ -f /galaxy/server/config/mutable/init_mounts_done_1 ]; do echo "waiting for copying onto NFS"; sleep 1; done; until [ -f /galaxy/server/config/mutable/init_clone_done_1 ]; do echo "waiting for refdata copying"; sleep 1; done; echo "Initialization waits complete"; sleep 5;
    State:          Terminated
      Reason:       Completed
      Exit Code:    0
      Started:      Tue, 09 Apr 2024 11:16:12 +0200
      Finished:     Tue, 09 Apr 2024 11:16:17 +0200
    Ready:          True
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /galaxy/server/config/mutable/ from galaxy-data (rw,path="config")
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-mcsvz (ro)
Containers:
  galaxy-job-0:
    Container ID:  containerd://a90ac9a121caef579f6911deddf633996e6c123cc6cce3db20125f155ae6909e
    Image:         quay.io/galaxyproject/galaxy-min:23.1
    Image ID:      quay.io/galaxyproject/galaxy-min@sha256:aac7ab9f8f9422b76f62344c02ddc8772a1ee893accbfebf98ad7e9d7bfcaf6e
    Port:          <none>
    Host Port:     <none>
    Args:
      sh
      -c
      python /galaxy/server/scripts/galaxy-main -c $GALAXY_CONFIG_FILE --server-name job_handler_0 --attach-to-pool job-handlers
    State:          Running
      Started:      Tue, 09 Apr 2024 11:16:18 +0200
    Ready:          True
    Restart Count:  0
    Limits:
      cpu:                3
      ephemeral-storage:  10Gi
      memory:             7G
    Requests:
      cpu:                100m
      ephemeral-storage:  1Gi
      memory:             1G
    Liveness:             exec [sh -c python /tmp/probedb.py -c $GALAXY_CONFIG_OVERRIDE_DATABASE_CONNECTION -s job_handler_0 -o $HOSTNAME] delay=0s timeout=5s period=10s #success=1 #failure=30
    Readiness:            exec [sh -c python /tmp/probedb.py -c $GALAXY_CONFIG_OVERRIDE_DATABASE_CONNECTION -s job_handler_0 -o $HOSTNAME] delay=0s timeout=5s period=10s #success=1 #failure=12
    Startup:              exec [sh -c python /tmp/probedb.py -c $GALAXY_CONFIG_OVERRIDE_DATABASE_CONNECTION -s job_handler_0 -o $HOSTNAME] delay=30s timeout=5s period=5s #success=1 #failure=80
    Environment:
      POD_NAME:                                         galaxy-job-0-adad6b6c7-j9lc4 (v1:metadata.name)
      GALAXY_DB_USER_PASSWORD:                          <set to the key 'password' in secret 'postgres.galaxy-galaxy-postgresql.acid.zalando.net'>  Optional: false
      GALAXY_CONFIG_OVERRIDE_DATABASE_CONNECTION:       postgresql://postgres:$(GALAXY_DB_USER_PASSWORD)@galaxy-galaxy-k3s-rdloc-postgres/galaxy?sslmode=require
      GALAXY_CONFIG_OVERRIDE_ID_SECRET:                 <set to the key 'galaxy-config-id-secret' in secret 'galaxy-k3s-rdloc-galaxy-secrets'>  Optional: false
      PYTHONPATH:                                       /galaxy/server/lib
      GALAXY_CONFIG_FILE:                               /galaxy/server/config/galaxy.yml
      GALAXY_RABBITMQ_USERNAME:                         <set to the key 'username' in secret 'galaxy-k3s-rdloc-rabbitmq-server-default-user'>  Optional: false
      GALAXY_RABBITMQ_PASSWORD:                         <set to the key 'password' in secret 'galaxy-k3s-rdloc-rabbitmq-server-default-user'>  Optional: false
      GALAXY_CONFIG_OVERRIDE_AMQP_INTERNAL_CONNECTION:  amqp://$(GALAXY_RABBITMQ_USERNAME):$(GALAXY_RABBITMQ_PASSWORD)@galaxy-k3s-rdloc-rabbitmq-server:5672
    Mounts:
      /cvmfs/cloud.galaxyproject.org from galaxy-data (rw,path="cvmfsclone")
      /galaxy/server/config/build_sites.yml from galaxy-conf-files (rw,path="build_sites.yml")
      /galaxy/server/config/container_resolvers_conf.xml from galaxy-conf-files (rw,path="container_resolvers_conf.xml")
      /galaxy/server/config/galaxy.yml from galaxy-conf-files (rw,path="galaxy.yml")
      /galaxy/server/config/integrated_tool_panel.xml from galaxy-conf-files (rw,path="integrated_tool_panel.xml")
      /galaxy/server/config/job_conf.yml from galaxy-conf-files (rw,path="job_conf.yml")
      /galaxy/server/config/mutable/ from galaxy-data (rw,path="config")
      /galaxy/server/config/sanitize_allowlist.txt from galaxy-conf-files (rw,path="sanitize_allowlist.txt")
      /galaxy/server/config/tool_conf.xml from galaxy-conf-files (rw,path="tool_conf.xml")
      /galaxy/server/config/workflow_schedulers_conf.xml from galaxy-conf-files (rw,path="workflow_schedulers_conf.xml")
      /galaxy/server/database from galaxy-data (rw)
      /galaxy/server/lib/galaxy/jobs/rules/tpv_rules_local.yml from galaxy-job-rules (rw,path="tpv_rules_local.yml")
      /tmp/probedb.py from extra-files-probe-script (rw,path="probedb.py")
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-mcsvz (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             True
  ContainersReady   True
  PodScheduled      True
Volumes:
  extra-files-probe-script:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      galaxy-probedb-py
    Optional:  false
  galaxy-conf-files:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      galaxy-configs
    Optional:  false
  galaxy-job-rules:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      galaxy-job-rules
    Optional:  false
  galaxy-data:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  galaxy-k3s-rdloc-galaxy-pvc
    ReadOnly:   false
  kube-api-access-mcsvz:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   Burstable
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 20s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 20s
Events:                      <none>

So, the problem still persists.

I see you are still using 23.1; could you try with 24.0?
galaxy:
  image:
    tag: "24.0"

You should be able to helm upgrade an existing installation:
helm upgrade galaxy -n galaxy <your chart> --set galaxy.image.tag="24.0"

Out of curiosity and to help us better assist users in the future, what exactly resolved your problem?

So, I deleted the mountPath: /galaxy/server/database from the values.yaml file. Then, I created a new PVC and only kept the following storageClass: "freenas-iscsi-csi" and deleted storageClassName.

Thanks for the follow up.


[Bug] The server page of dashboard cannot display server info when refresh the page

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the bug
We have to click the other group e.g. decommission nodes and then click active nodes button, the server list can be displayed.
Affects Version(s)
master
Uniffle Server Log Output
No response
Uniffle Engine Log Output
No response
Uniffle Server Configurations
No response
Uniffle Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

@yl09099 Would you like to take a look at this issue?

@yl09099 Would you like to take a look at this issue?

I'll take care of it. Give it to me.


bioconda recipe

Hi @Xiaojieqiu,
Congrats on the CZI grant! I wanted to touch base to see if the lab would be open to publishing spateo on bioconda. If so, I'm happy to help build a recipe.
Best,
Mike

Thanks Mike! We are also very excited to use the CZI grant to make spateo, dynamo and dynast even more user friendly and functionality rich. If you may happen to know any motivated software engineers who may be interested in this very ambitious endeavor, I would greatly appreciate it if you can introduce them to me!  Thanks for the offering to publish Spateo on bioconda! Please feel free to make a pull request. I am interviewing faculty jobs this week but should be able to review and merge it into the main branch by the end of this week or early next week!
Thanks,
Xiaojie

Hi @Xiaojieqiu , I'm hoping to have some free time over the Christmas break to work on this

that's great. looking forward to it. and Merry Christmas ahead.
Btw, as you may know we have posted our spateo paper to biorxiv and see our tweet about it here for example, https://twitter.com/Xiaojie_Qiu/status/1602354469118906376

finish these this week


Questions on horovod-pytorch-synthetic-benchmark.yaml

Organization Name:

**Hi, I'm quite new to OpenPAI and Horovod.  I have a question on the example https://github.com/microsoft/pai/blob/master/marketplace-v2/horovod-pytorch-synthetic-benchmark.yaml command.
In this line  -mca btl_tcp_if_exclude lo,docker0 <% $parameters.nccl %>, what does the docker0 mean? Also, how does it find the file 'pytorch_synthetic_benchmark.py' to run? I didn't see where it imported the file！.
Thanks**:
Brief what process you are following:

How to reproduce it:

OpenPAI Environment:

OpenPAI version: v1.0.0
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Hardware (e.g. core number, memory size, storage size, GPU type etc.):
Others:

Anything else we need to know:

Hi @zhenhuahu - thanks for following openpai, and interact with us. would you mind share more info about what's the major usage for you when considering openPAI for yourself or your organization. if you don't mind, would you please share the org name? so that we can clustering issues together by org names.

what does the docker0 mean

pls refer to horovod's docs

Also, how does it find the file 'pytorch_synthetic_benchmark.py' to run

pls refer to horovod's dockerfile

what does the docker0 mean

pls refer to horovod's docs

Also, how does it find the file 'pytorch_synthetic_benchmark.py' to run

pls refer to horovod's dockerfile

Thank you so much!

Hi @zhenhuahu - thanks for following openpai, and interact with us. would you mind share more info about what's the major usage for you when considering openPAI for yourself or your organization. if you don't mind, would you please share the org name? so that we can clustering issues together by org names.

Hi Scarlett. Thanks for the question. Actually my company has been using OpenPAI for deep learning before I joined. I work at SenseBrain Technology. Thanks.


Language selector

Is there a way to change the ui-language via the frontend?

Not at the moment. It's all controlled via the environment variable NODE_LOCALE. Where the options are as follows:

English = en
Spanish = es
German = de

Though this is something that I do want to add at some point.

I have a vague recollection of looking at how to do it a while ago, but it was either really complicated or not possible without upgrading webpack and/or react. Considering our use case (small communities) all content will be in one fixed language so there's not a huge value in being able to change locale on the fly.

I agree with the above. If someone whats to submit a PR, I'm all for it. However I don't think that I will work on this any time soon.


Update API endpoints

Update API endpoints to
suggested path /api/version/invoke

"/did" : this is the synchronous invoke
"/async/did" : this is the async version
"/job/status/id": the API for getting job status
"/job/result/id": get job result

Fix for #37 & #29

I don't see why we should have separate "status" and "result" endpoints. A single map can convey all that is needed:
{:jobid "134",
 :status "completed",
 :results {........}

This can serve as the result of an async or sync invoke, and also as the result from a jobs/id request. So you only have one return type to handle!
I think we should prefer plurals when addressing objects, e.g. jobs/id`` rather than job/id`. This appears to be the usual convention.

This requirement was raised by you in a review (see https://github.com/DEX-Company/koi-clj/issues/37).

That's useful for Koi as an implementation (potentially), but I think we should avoid it in DEPs. The aim for the DEP Standards is to have as small an API surface as possible since it will be mandatory for all implementers.

In that case, I'll also revert Koi to implement just a single API (it's already been changed).

@mikera its been updated, please review

@shark8me feel free to merge as you are the editor for this one!


 Just have one dumb question: how to install the optimizer? I have PyTorch>=2.4.0 and update my pip, but cannot find a package called adopt.

Thank you for being interested in our work.
To use ADOPT, you should copy adopt.py into your code and import it.
We are planning to make it available as a pip package, but it is not currently supported, so you need to manually import it at the moment.
Thanks.

Got it! Thanks for the reply.


Words to revisit

Need to search through the package and make sure these words are used right.

[ ] flowline - flowpath
[ ] catchment - catchment boundary
[ ] collapse, reconcile, aggregate, combine.

Going to leave the use of "reconcile" a little vague. It's currently used in some internal functions as well as some exported functions. It's use is conceptually consistent from a little inconsistent when interpreted specifically. I think this is OK because in all cases, it is being used as an intermediate step that is not hydrologically-significant.

Collapse is only used to refer to collapsing the catchment-network with "flowlines" being used as a proxy for "catchment-network".

aggregate is being used in the HY_Features sense of a catchment aggregate. "Aggregation" in this sense involves a union operation on catchment boundaries and a main-stem-selection operation on flowpaths. There is a significant amount of logic in aggregation that ensures the resulting aggregated set of catchments (boundaries and flowpaths) form a valid and well connected catchment network.

Combine is being avoided as is union. These both have meaning from st_union and st_combine and aren't useful from a hydrologic point of view. Rather, "reconcile", implies the use of union/combine operations where needed as does "aggregate".

Probably more to do, especially in vignettes, but mostly took care of things.


Store caches errors

I'm not sure if this is intended behavior. If an Observable errors, subsequent calls to get just repeat that error.
I would expect the store to retry after an error.
public class DontCacheErrorsTest {

    private boolean shouldThrow;
    private Store<Integer> store;

    @Before
    public void setUp() {
        store = StoreBuilder.<Integer>builder()
                .fetcher(barCode -> Observable.fromCallable(() -> {
                    if (shouldThrow) throw new RuntimeException();
                    else return 0;
                }))
                .open();
    }

    @Test
    public void testStoreDoesntCacheErrors() throws InterruptedException {
        BarCode barcode = new BarCode("bar", "code");

        shouldThrow = true;
        store.get(barcode).test()
                .awaitTerminalEvent()
                .assertError(Exception.class);

        shouldThrow = false;
        store.get(barcode).test()
                .awaitTerminalEvent()
                .assertNoErrors();
    }
}

Agree on that issue, had stumble upon it before but did not have the time to open it. Retrying though is kind of obtrusive. I would expect that the Store would not write a resource and just hit the fetcher again.

Issue is due to inflight being unaware if it is a good or error response and caching it for 1 min.  I'll make a change that will clear inflight if an error is read.  I don't believe any additional retry logic is needed.  Thanks for reporting PR coming....

I was a little unclear. With retry I mean that in like in my test the second get should call the fetcher again.


Changes markdown fix

It's a one-line change, but my editor also realized that the file had Windows line endings, so I fixed that in a separate commit.

My bad. I let this through.
Would adding * text=auto to .gitattributes prevent this from happening again?
https://help.github.com/articles/dealing-with-line-endings/

Isn't it already auto be default? We have this setting https://github.com/highlightjs/highlight.js/blob/master/.editorconfig#L2, so I don't expect this problem to appear very often anyway.

Add an .editorconfig file.


[Request] Instant buy only on company

The option to instant buy only on company could be great.

The option to instant buy only on company could be great.

@andrzej2273  May i ask why

For game balance. I want mechanics like distracting dogs with dropship and ordering items when you land on moons to stay. In later qoutas, carrying 20+ items from dropship to ship on company is annoying and tidious af.

It is now possible to filter the items that will trigger the mod in the config file, e.g. you can write -1,0 in the config to make the walkie talkie arrive via dropship while other items will appear directly in the ship


v16 to v18

Bug report, debug log and your config file (FULL LOGS ARE MANDATORY)

Steps to reproduce
upgraded from v16 to v18 on a Raspbery Pi 2. I took a backup of my settings but cannot import due to incompatibility. anyway to use my json backup to retrieve my settings?
What is expected?
What is actually happening?
System

In case of problems I suggest you to upgrade to v17 first. Then to v18. If you have JSON backup from v16, then you must install HyperHDR v16 to restore it. HyperHDR v17 and above is using different backup format that includes all instances (previously one one instance was backup).

ok, I think I already have v18 reconfigured. Thank you again for the amazing work


Docs: How to install and run locally

Please document how we can install this and run it locally so as not to run into network slowness when recording.

I've now added the instructions to install and run locally https://github.com/MetaGenAI/MetaGenNeos/blob/main/README.md . I'll wait till a couple of people test it before closing this

The instructions have now been tested to work by a few people.


Fix job priority at submission time - wmagent branch

Fix job priority at submission time, taking into account  maxTaskPrio…rity, as it was originally.
Fixes #10759 , backported to 1.4.7
Status
ready
Description
Backport changes from #10760 to 1.4.7 branch
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
https://github.com/dmwm/WMCore/pull/10760

 Fix #10763 - Fix job priority at submission time


fix: Fix KeyValueConfigStore implicitly masking errors in the get method

Improve KeyValueConfigStore error handling
The KeyValueConfigStore was catching errors when fetching specific keys and returning an empty string without notifying the user. This behavior is undesirable for user experience. This commit enhances the error handling by rethrowing errors encountered during key fetching, ensuring proper error propagation, and allowing users to handle errors as needed.
#285

Hi @MeenuyD,
We appreciate your enthusiasm to contribute to our open-source project. However, we've determined that the related issue isn't ready for work just yet. The issue requires our team to discuss the right solution, and simply throwing an error does not align with our current product requirements.
We encourage your continued involvement, and if you have any questions or would like to work on other issues, please feel free to reach out. Thank you for your understanding, and we look forward to your future contributions.


Darken red colour in light theme for better contrast

@gregvanl ran Accessibility Insights on the website and noticed that there wasn't enough contrast between the red text and white background (such as with charset below). The website currently uses @shikijs for highlighting, which pulls the theme from VS Code itself.

I used a find and replace to fix the tests.
It looks like a lot of changes, but the only affected files should be test files.


Implement new config to override service host with consul advertise ip

Nomad in combination with Consul often register a service with an internal IP
Nomad doesn't respect to register services with the advertisement IP
With this setting all services host IP will be ignored and the consul advertise IP will be registered.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Christian Rustmeier seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Zonespeaker not turning off in using homekit

Goodmorning,
Thank you for your awesome plugin for homebridge.
I am using it for a while now and since the last update I have some trouble with it.
When I restart homebridge everything is working just fine. But after a while my sonos speakers are not turning off anymore using homebridge-zp.
I have set it up as following:
Homebridge --> Homebridge-zp.
And I use homekit and Home 3 app to configure everything. When I try to turn off my sonos it won't turn off. I can mute it, but thats not really turning off.
Is there a known issue for this? Or does it need a upgrade.
My loggings says the following:
Turning ON: (working fine)
Jun 12 06:00:04 raspberrypi homebridge[31290]: [6/12/2019, 6:00:04 AM] [ZP] Woonkamer Sonos: set group volume from 14 to 3 Jun 12 06:00:06 raspberrypi homebridge[31290]: [6/12/2019, 6:00:06 AM] [ZP] Woonkamer Sonos: set power (play/pause) from false to true Jun 12 06:00:21 raspberrypi homebridge[31290]: [6/12/2019, 6:00:21 AM] [ZP] Woonkamer Sonos: set current track from "Radio 10" to "Zedd & Alessia Cara - Stay"
Turning OFF: (not working)
un 12 06:17:36 raspberrypi homebridge[31290]: [6/12/2019, 6:17:36 AM] [ZP] Woonkamer Sonos: power (play/pause) changed from true to false Jun 12 06:17:38 raspberrypi homebridge[31290]: [6/12/2019, 6:17:38 AM] [ZP] Woonkamer Sonos: power (play/pause) changed from true to false Jun 12 06:17:39 raspberrypi homebridge[31290]: [6/12/2019, 6:17:39 AM] [ZP] Woonkamer Sonos: power (play/pause) changed from true to false Jun 12 06:17:39 raspberrypi homebridge[31290]: [6/12/2019, 6:17:39 AM] [ZP] Woonkamer Sonos: power (play/pause) changed from true to false Jun 12 06:17:40 raspberrypi homebridge[31290]: [6/12/2019, 6:17:40 AM] [ZP] Woonkamer Sonos: power (play/pause) changed from true to false Jun 12 06:17:40 raspberrypi homebridge[31290]: [6/12/2019, 6:17:40 AM] [ZP] Woonkamer Sonos: power (play/pause) changed from true to false
Just nothing happening on turning off.
I really don't know whats wrong.
Versions:
[homebridge-lib.Lib] homebridge-lib v4.2.7, node 10.16.0, homebridge v0.4.50
homebridge-zp v0.4.3
I hope to receive some help over here.

Can you please capture and attach a full debug log, see https://github.com/ebaauw/homebridge-hue#debug-log-file.

Here you go:
https://pastebin.com/uRs4JbAh

Here you go:

Sorry, I need a bit more than that.  Please run homebridge for several minutes, and turn the zoneplayer on and off from HomeKit several times during that time.  I need to see what commands homebridge-hue sends to the ZonePlayer, and how it responds.

Ow and about the warnings:

Nothing to do with homebridge-zp.  You probably used different ways to install different versions of node, causing it to move from /usr/local to /usr.  What does ls -l $(which node) report?  And ls -l $(which homebridge)?


how to set up guzzle

it seems to set up guzzle in a way that it throws exceptions when receiving a 403 response. that exception is correctly converted to a php-http exception, but still not expected if i understand correctly how we wanted things to be set up. (i did not add any plugins, so the plugin to convert error responses to exceptions is not there.)
it seems that we have the Middleware::httpErrors in the guzzle stack. looking at https://github.com/php-http/guzzle6-adapter/blob/master/src/Guzzle6HttpAdapter.php#L32 and https://github.com/guzzle/guzzle/blob/master/src/Client.php#L64-L65 i think we would need to provide an empty or reduced handler stack. this in turn means that using php-http results in a very bare-bone - but the alternative is inconsistent behaviour.
found this while working on https://github.com/FriendsOfSymfony/FOSHttpCache/pull/257 - to see a stack trace, look for Http\Client\Exception\HttpException: Client error: GET http://localhost:6181/user_context.phpresulted in a403 Forbidden response: in the travis output.

I remember that we set exceptions to false in case of guzzle 5, but to be honest, I don't know how this works in case of guzzle 6. But if it is solved as a middleware (like we are going to do) then we should customize the HandlerStack.

i can do a PR to provide an empty stack to avoid guzzle putting things
in the stack.
do we need any middleware? the default is
        $stack->push(Middleware::httpErrors(), 'http_errors');
        $stack->push(Middleware::redirect(), 'allow_redirects');
        $stack->push(Middleware::cookies(), 'cookies');
        $stack->push(Middleware::prepareBody(), 'prepare_body');

i guess the first 3 really are handled by our plugins. what about
prepare_body?
and also, if we make the default client extremly barebone, this is not
really convenient for users. they might want at least the body
preparation thing. should we have another service locator for a client
with a bunch of default plugins?

What does prepare body do?

its doing quite a lot: https://github.com/guzzle/guzzle/blob/master/src/PrepareBodyMiddleware.php
size and content encoding things. i would tend to add it, as it "only" adds things if they are not there anyways. still, it will hide problems when developing against guzzle and later running with a different client that does not automatically do this.

I think we could/should have similar plugins, but it is very unlikely that they will ever collide, so I would say we should have it.

in the PrepareBody middleware we also have a plugin which does that : https://github.com/php-http/plugins/blob/master/src/ContentLengthPlugin.php at the exception of the except header


Trying to a secret with the same name as an existing secret fails

now secrets add site-password "blah blah"
> Error! Unexpected error. Please try again later. (An unexpected internal error occurred)

It should fail, that's expected. You can only have one secret with the same name, because they're global in your team/user account... :blush:
What we can do is improve the error message!

Just ran into this when trying to update the value of a secret. Is there a way to update a secret without having to rm then add again?

@leo Was this issue fixed?
As today (10/07/2018), the console outputs Error! The secret name "my-secret" already exists for this user.

Just came here with the same issue: having a way to update a secret value without removing it would be kindly appreciated.

Closing in favor of https://github.com/zeit/now-cli/issues/1058


cannot get the email address when login using Azure Active Directory.

The document is well crafted and helps setup the authentication with local as well as Azure Active directory very well.
The one issue I face here is that I need the email address with which the user has logged in. For this, I tried giving signInNames.emailAddress as well as the email as the output claim.
The signInNames.emailAddress works for authentication with a local account but I am not able to get the email address when user login with the azure active directory account.
Please share your thought on this.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bf203c92-3847-c2f9-f966-edaca7b59818
Version Independent ID: 76f7519d-3040-646d-93a0-2657812d81e9
Content: Set up sign-in with an Azure AD account by using custom policies - Azure AD B2C
Content Source: articles/active-directory-b2c/identity-provider-azure-ad-single-tenant-custom.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@foramkumar-parekh Thank you for reaching out. We will investigate this and reach out to you.

@foramkumar-parekh For this purpose, Azure AD B2C first need to request email claim from the federated Azure AD. For this purpose, you need to add email scope to under <Metadata> tag in the Technical Profile for federated Azure AD.
<Item Key="scope">openid profile email</Item>
Then add below output claim to <OutputClaims> in that Technical Profile.
<OutputClaim ClaimTypeReferenceId="email" PartnerClaimType="email" />
Finally, make sure you have below <OutputClaim> present in your RP (SignupOrSignin.xml) file.
<OutputClaim ClaimTypeReferenceId="email" />

@amanmcse , thanks for your help.
I just have one more question.
I just figured out that not all the people, in my tenant, have an email address so now what I need is the userPrincipalName.
I tried using below, just as you suggested for email,
<OutputClaim ClaimTypeReferenceId="userPrincipalName"/>
But for that, I got the below output (i have replaced the original unique key with xxx)
"upn"<EMAIL_ADDRESS>Not sure how can I achieve below
"userPrincipalName"<EMAIL_ADDRESS>Please share some info on this as well.

@foramkumar-parekh  You need to define a new claim with id preferred_username under <ClaimsSchema> tag.
<ClaimType Id="preferred_username">
        <DisplayName>Preferred Username</DisplayName>
        <DataType>string</DataType>
        <DefaultPartnerClaimTypes>
          <Protocol Name="OpenIdConnect" PartnerClaimType="email" />
        </DefaultPartnerClaimTypes>
        <UserHelpText>Preferred Username that can be used to contact you.</UserHelpText>
        <UserInputType>TextBox</UserInputType>
        <Restriction>
          <Pattern RegularExpression="^[a-zA-Z0-9.!#$%&'^_`{}~-]+@[a-zA-Z0-9-]+(?:\.[a-zA-Z0-9-]+)*$" HelpText="Please enter a valid email address." />
        </Restriction>
      </ClaimType>

Then add below output claim to <OutputClaims> in the Technical Profile for federated Azure AD.
<OutputClaim ClaimTypeReferenceId="preferred_username" PartnerClaimType="email" />
Also, make sure you have below <OutputClaim> present in your RP (SignupOrSignin.xml) file.
<OutputClaim ClaimTypeReferenceId="email" />

@amanmcse , as I already mentioned, I cannot use email as PartnerClaimType as this is not available for all the users. I need to fetch the userPrincipalName from the B2B tenant.

@foramkumar-parekh These steps are to get UPN as email claim. Federated AAD sends UPN as preferred_username in the token.

Yes, that's what I would like to have.
But how can Partner claim type = email gives me UPN, is what I cannot understand. As shown below, the email claim does the same as you mentioned above. So how will it behave differently here?
<ClaimType Id="email">         <DisplayName>Email Address</DisplayName>         <DataType>string</DataType>         <DefaultPartnerClaimTypes>           <Protocol Name="OpenIdConnect" PartnerClaimType="email" />         </DefaultPartnerClaimTypes>         <UserHelpText>Email address that can be used to contact you.</UserHelpText>         <UserInputType>TextBox</UserInputType>         <Restriction>           <Pattern RegularExpression="^[a-zA-Z0-9.!#$%&'^_{}~-]+@[a-zA-Z0-9-]+(?:.[a-zA-Z0-9-]+)*$" HelpText="Please enter a valid email address." />

`

@foramkumar-parekh  PartnerClaimType is the claim name sent to the application by B2C. In Federated AAD TP, we are sending preferred_username as email to the application. Refer to below line that we added in the technical profile.
<OutputClaim ClaimTypeReferenceId="preferred_username" PartnerClaimType="email" />
If email value is causing confusion for you, you can define a new claim id (e.g. upn) and send preferred_username as upn.

So, to understand better, let's take an example of claim, mentioned below.

Surname
string

my understanding says that the b2c tenant will ask b2b tenant for the value of field family_name and then will represent it as a surname in the token.
If this is correct, then as per your solution, we are asking for email field from the b2b tenant. And as I already mentioned, I need to fetch the UPN and not the email from b2b tenant.

@foramkumar-parekh  Your understanding is not correct. B2B tenant also stores surname as surname and not as family_name. The claim family_name is returned by B2C to the application which is federated with the B2C tenant and the value of the family_name claim will be same as surname.

@amanmcse
I tried your solution to get the UPN, but i was not able to get the email field as suggested.
Please find below the decoded token for more details.

{
"exp":<PHONE_NUMBER>,
"nbf":<PHONE_NUMBER>,
"ver": "1.0",
"iss": "https://b2ctenant.b2clogin.com/xxxxxxx-xxxx-xxxx-xxxx-xxxxxxxx/v2.0/",
"sub": "xxxxxxx-xxxx-xxxx-xxxx-xxxxxxxx",
"aud": "xxxxxxx-xxxx-xxxx-xxxx-xxxxxxxx",
"acr": "b2c_1a_signin_local_and_ad",
"nonce": "defaultNonce",
"iat":<PHONE_NUMBER>,
"auth_time":<PHONE_NUMBER>,
"tid": "xxxxxxx-xxxx-xxxx-xxxx-xxxxxxxx",
"name": "User Name",
"userPrincipalName"<EMAIL_ADDRESS>}

Thanks

You are still passing userPrincipalName claim and<EMAIL_ADDRESS>is the format B2C stores the UPNs in. As I mentioned earlier, Federated AAD sends UPN as preferred_username in the token and you need to create and use preferred_username claim id, not userPrincipalName.

@amanmcse i tried also removing the UPN, but there was no preferred_username field or email field in the token.
I am sharing few details to make sure the thing are correct at my end.

Claim Schema

    <DisplayName>Preferred Username</DisplayName>
    <DataType>string</DataType>
    <DefaultPartnerClaimTypes>
      <Protocol Name="OpenIdConnect" PartnerClaimType="email" />
    </DefaultPartnerClaimTypes>
    <UserHelpText>Preferred Username that can be used to contact you.</UserHelpText>
    <UserInputType>TextBox</UserInputType>
    <Restriction>
      <Pattern RegularExpression="^[a-zA-Z0-9.!#$%&'^_`{}~-]+@[a-zA-Z0-9-]+(?:\.[a-zA-Z0-9-]+)*$" HelpText="Please enter a valid email address." />
    </Restriction>
  </ClaimType>

Technical Profile

    <TechnicalProfile Id="OIDC-Test">
      <DisplayName>New Test account</DisplayName>
      <Description>Login with your Test account</Description>
      <Protocol Name="OpenIdConnect"/>
      <Metadata>
        <Item Key="METADATA">https://login.microsoftonline.com/xxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxx/v2.0/.well-known/openid-configuration</Item>
        <Item Key="client_id">CLIENT_ID</Item>
        <Item Key="response_types">code</Item>
        <Item Key="scope">openid profile email</Item>
        <Item Key="response_mode">form_post</Item>
        <Item Key="HttpBinding">POST</Item>
        <Item Key="UsePolicyInRedirectUri">false</Item>
      </Metadata>
      <CryptographicKeys>
        <Key Id="client_secret" StorageReferenceId="B2C_1A_MSASecret"/>
      </CryptographicKeys>
      <OutputClaims>
        <OutputClaim ClaimTypeReferenceId="issuerUserId" PartnerClaimType="oid"/>
        <OutputClaim ClaimTypeReferenceId="tenantId" PartnerClaimType="tid"/>
        <!-- <OutputClaim ClaimTypeReferenceId="givenName" PartnerClaimType="given_name" /> -->
        <!-- <OutputClaim ClaimTypeReferenceId="surName" PartnerClaimType="family_name" /> -->
        <OutputClaim ClaimTypeReferenceId="displayName" PartnerClaimType="name" />
        <OutputClaim ClaimTypeReferenceId="authenticationSource" DefaultValue="socialIdpAuthentication" AlwaysUseDefaultValue="true" />
        <OutputClaim ClaimTypeReferenceId="identityProvider" PartnerClaimType="iss" />
        <OutputClaim ClaimTypeReferenceId="preferred_username" PartnerClaimType="email" />
        <OutputClaim ClaimTypeReferenceId="email"/>
        <!-- <OutputClaim ClaimTypeReferenceId="userPrincipalName" PartnerClaimType="userPrincipalName"/> -->
      </OutputClaims>
      <OutputClaimsTransformations>
        <OutputClaimsTransformation ReferenceId="CreateRandomUPNUserName"/>
        <OutputClaimsTransformation ReferenceId="CreateUserPrincipalName"/>
        <OutputClaimsTransformation ReferenceId="CreateAlternativeSecurityId"/>
        <OutputClaimsTransformation ReferenceId="CreateSubjectClaimFromAlternativeSecurityId"/>
      </OutputClaimsTransformations>
      <UseTechnicalProfileForSessionManagement ReferenceId="SM-SocialLogin"/>
    </TechnicalProfile>
  </TechnicalProfiles>

Relying Party

<DefaultUserJourney ReferenceId="SignInTestScorpio" />
<TechnicalProfile Id="PolicyProfile">
  <DisplayName>PolicyProfile</DisplayName>
  <Protocol Name="OpenIdConnect" />
  <OutputClaims>
    <OutputClaim ClaimTypeReferenceId="displayName" />
    <!-- <OutputClaim ClaimTypeReferenceId="givenName" /> -->
    <!-- <OutputClaim ClaimTypeReferenceId="surname" /> -->
    <OutputClaim ClaimTypeReferenceId="preferred_username" />
    <!-- <OutputClaim ClaimTypeReferenceId="email" /> -->
    <!-- <OutputClaim ClaimTypeReferenceId="signInNames.emailAddress" /> -->
    <OutputClaim ClaimTypeReferenceId="objectId" PartnerClaimType="sub"/>
    <!-- <OutputClaim ClaimTypeReferenceId="userPrincipalName" PartnerClaimType="userPrincipalName"/> -->
    <!-- <OutputClaim ClaimTypeReferenceId="identityProvider" /> -->
    <OutputClaim ClaimTypeReferenceId="tenantId" AlwaysUseDefaultValue="true" DefaultValue="{Policy:TenantObjectId}" />
  </OutputClaims>
  <SubjectNamingInfo ClaimType="sub" />
</TechnicalProfile>

You need to remove
<OutputClaim ClaimTypeReferenceId="email"/> from Technical Profile.
<OutputClaim ClaimTypeReferenceId="preferred_username" /> from Relying Party file.
and add
<OutputClaim ClaimTypeReferenceId="email"/> to Relying party file.

@amanmcse I made the suggested changes. But I still cannot have the email field in the token.


deduplicate

Prioritized the primary feed listed on the website itself and defaulted to the blog feed when two different feeds for the same site were present.
Solves #154

Amazing work!


⚠ Bofrost.at has degraded performance

In 20b9053, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1780 ms

Resolved: Bofrost.at performance has improved in 0d067da after 7 minutes.


Improve docstring of highcut

The docstring of highcut currently states nothing. We need a description of what it does, including a description of the parameters.

In that process, please also give the parameters descriptive names. Do not use symbols (e.g. lam) as a parameter name as this does not transport what it means without significant domain knowledge.


Major refactor and consistency fixes

This PR addresses several issues that have come up in the discussions:

Addresses #2 , by simply removing outdated code snippets that caused an issue with specific (newer) transformers versions. Note that this can be further improved in the future by revisiting how much of our actual code is required, and whether we can substitute these classes by inheriting from transformers directly, thus avoiding code duplication.
Adds the option to install the repository as a pip package. This solves several (related) issues, mostly centered around correct imports from parent-level folders, which is non-trivial with Python. For now, the option is to install it with python3 -m pip install . (in the root folder), however, I am actively working to get it on PyPI.org as well. This way, I have also verified that the examples are finally running correctly, which was a previous issue.
I've started to be more serious about "separation of concerns", and hopefully improved readability of the actual module by moving our scripts into subfolders.
Renaming some of the classes to be more consistent (e.g., BERT_CRF_NER is now BertWithCRF), as well as more expressive (NumbertTokenizer is now DateTokenizer).
I've contained the refactor of actual code to a minimum for now, since I was first trying to get the right code structure, which would then allow us to improve other aspects in a separate PRs, without further crowding changes into this one. There are some obvious fixes, but no deeper changes to the "business logic".
Also includes re-zipped versions of the LFS files (data and results), since the MacOS-zipped folders contain "ghost files" which show up on Linux systems, and cause the folder structure to become invalid.

Disclaimer: I have only tested functionality on the two model_hub scripts, which is not ideal. If you have any suggestions for which tests/scripts to run to see whether something is broken, please let me know.
This is also relevant for paths referenced in files. While I believe to have taken care of most paths, the package change might have invalidated some paths that were not found by PyCharm, so no guarantees here.

At the moment the pip installation only works with "pip install .".


[Feature request] Support smaller Bento icon size

This came up in this card (internal).
Problem
Currently when adding a leadingVisual to <Bento.Content>
<Bento.Content
  leadingVisual={<PulseIcon />}
>

a 24px icon is used and upscaled to 44px.

But Design would like to use a 16px icon, upscaled to 32px (doubled), which has "thicker" lines.

Possible solution
Allow the size prop to be passed to the icon:
<Bento.Content
  leadingVisual={<PulseIcon size={16} />}
>

which then can be resized with CSS to a 32px rendered size.
Or maybe a leadingVisualSize prop would be nice too.
<Bento.Content
  leadingVisual={<PulseIcon />}
  leadingVisualSize="small"
>

that would render the icon like:
<svg viewBox="0 0 16 16" width="32" height="32">

Urgency
Not too urgent, found a somewhat simple workaround by adding an extra stroke. Still not ideal though.
Also not sure if this is a "one-off" for that project, or if it's something we'll want to use more often.
/cc @nsolerieu

@simurai I brought this up during Primer Brand Office Hours - it's on our radar.
We've been doing this a log as the thicker 16px icons have more visual weight and carries our brand accent better so we're examinig what the best way to do this at the system level. CC @rezrah


[FLINK-22320][docs][table] Add documentation for new introduced ALTER TABLE statements

What is the purpose of the change
This PR is a subtask of FLINK-21634 to add documentation.
Brief change log
Add documentation for ALTER TALBE [IF EXISTS] <table_identifier> statements.
Verifying this change
This change can be verified by building the document locally at http://localhost:1313
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented?  docs

@flinkbot run azure


Oj 3 changes meaning of "indent" in compat mode, leading to a crash with pretty: true

In 2.x, it used to be valid to combine an integral indent with compat mode, as done here: https://github.com/intridea/multi_json/blob/b9622c5632cddf85c61480388407ae5a00b6130e/lib/multi_json/adapters/oj.rb#L19
But in 3.x, that is not supported: Oj was made closer to the JSON gem in this respect, per the author: https://github.com/ohler55/oj/issues/446.

fixed by https://github.com/intridea/multi_json/commit/5d8febdbebc428882811b90d514f3628617a61d5


ICACLS Useage

From my experience the line:
ICACLS C:\sites\MyWebApp /grant "IIS AppPool\DefaultAppPool":F
should be corrected to:
ICACLS C:\sites\MyWebApp /grant "IIS AppPool\DefaultAppPool:F"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9d172b69-845d-739a-742c-617b9eed04fe
Version Independent ID: 79d553f1-9112-b61a-0ad0-dfbb11e5071a
Content: Advanced configuration
Content Source: aspnetcore/host-and-deploy/iis/advanced.md
Product: aspnet-core
Technology: aspnetcore-hostdeploy
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hello @jguett ... I thought only the security identifier was quoted because of the space. The permission mask is tacked on to the end, after the quoted string. When you say, "from my experience," what do you mean? Are you saying that the line as it stands doesn't apply full access permissions? I think we need to confirm it one way or the other before changing this because the product unit approved the command as it appears.

I'm not very familiar with ICACLS. I just tried to perform this step on Windows Server 2022.  The command appears to succeed with :F inside the quote but fail with it outside.
Tangent:
:F seems to result in the target folder having "special permissions".  Looks like the special permissions from :F may be from :F not specifying inheritance.  The option, : :(OI)(CI)F, seems to result full permissions for the target folder.  The /T transverse option might also be relevant for descendent files and folders.

@Rick-Anderson ... I'll work on this one with @jguett ... I have some time for it.

Looks like ...
ICACLS C:\sites\MyWebApp /grant "IIS AppPool\DefaultAppPool:RX"

... might do the trick (RX = Read & execute).


coercion in yargs?

Is there something like coercion in yargs?
I want to use for range arguments.
Thank you.

Hi?
I asked this because if this feature does not exists I'm interested to implement it. And, maybe, somebody could suggest the name of method. I don't like coercion name. I suggest transform method.

Hey @xgbuils, haven't had a chance to dig into this issue yet but I'll be hacking on yargs a bit this weekend and will get you some feedback.

Thanks, @bcoe

closing in favor of https://github.com/yargs/yargs/issues/535
let's actually tackle this!


remove sqlite dependcies

@alphmth - looks like this package Sql https://github.com/brianc/node-sql is not well supported and we want to clean up our security issues with using this.
You can see the issue here where we want to move away from using that package: https://github.com/jaredwray/keyv/issues/166


remove libco-canonical

Motivation for this change
This set of patches removes libco-canonical from the nixpkgs. It was used for dqlite, lxd and some other canonical stuff. However, it is not used anymore. Canonical also deleted it's repo - hence I would like to remove it from the nixpkgs.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build libraft dqlite lxd

Result of nixpkgs-review pr 123139 at 3cfba505 run on x86_64-linux 1

3 packages built successfully:

dqlite
lxd
raft-canonical

1 suggestion:

error: no-flags-spaces
buildFlags cannot contain spaces, please use buildFlagsArray in Bash.
Near pkgs/tools/admin/lxd/default.nix:43:3:
   |
43 |   buildFlags = [ "-tags libsqlite3" ];
   |   ^


consider using ngMetadata

Writting angular 1 with pure typescript isn't very convenient dev experience. Would you consider using ngMetadata  https://www.npmjs.com/package/ng-metadata ? It allows flawless gradual update, and your codebase will be ready for future migration to ng2.
If you would be interested I can do PR with some component upgraded to ngMetadata.
Think about it :)
cheers
Martin

The NPM page doesn't have enough info to really understand what's going on IMHO. I take it this is your library? Feel free to fork & propose but personally I'd need to understand more before putting this requirement on contributors.
FWIW, your comment "writing ng1 with pure typescript isn't ver convenient dev experience" is simply an opinion. We're doing quite well so far & I personally find it to be just fine.

Yes @andrewconnell you are perfectly right about opinion etc.
We used the same "design patterns" for writing ng1 with typescript as you do.
But when Angular 2 core API went stable, I wrote ngMetadata to have cleaner code which makes sense IMHO. I've updated the Readme because it wasn't very clear from it what is it good for, please see that 1st example https://github.com/ngParty/ng-metadata. We are using it on production for our component framework internally. It supports all angular 1 API's which are covered behind nice Angular 2 API syntax.
I will migrate one of your components and do PR when I'll have little more time, hopefully till end this week as a showcase.
Thank you for hearing me out, I appreciate that :) and kudos to ngOfficeFabric!

I’m curious to see what it looks like. Thanks for the kind comments too! Great team effort!

@Hotell  have you had time to create a showcase yet?

@rolandoldengarm  I'm sorry I was supper busy by doing meetups/workshops .. you can imagine. I will do my best to do this till the end of this week. Thx!

@Hotell  I wanna see that as well. and what you think about version 1.5?

@jorgearteiro angular 1.5 is a must ( one way binding, multi slot transclusion, lazy $compile, perf boost...). I plan to support only 1.5 and higher with ngMetadata 2.0. In 2.0 there will be one way binding by default. I didn't have again much time to do the PR, I will do that till end of this week and that's a promise. Sorry for waiting so long folks. Thanks

https://github.com/ngOfficeUIFabric/ng-officeuifabric/pull/231

copied from PR comment here: https://github.com/ngOfficeUIFabric/ng-officeuifabric/pull/231#issuecomment-212852098
Hey @Hotell ... sorry for letting this hang out there... but I think at this time we want to get the current push to 1.0 because we want to make sure we are at the same parity with coverage with Office UI Fabric for ng1 before we start work on ng2. I don't think many (if any other than @rolandoldengarm) have spent time with ng2 so we don't know what's in store. As such, I don't think we want to stop and look at what to do to be forward compatible.
In addition, the Angular Material guys are doing some work to add infrastructure we'd be able to leverage to make building for ng2 easier. For instance, I understand they are building a library / framework that will do screenshot of rendered components and diff them when tests run to see that the rendering didn't change & matches the spec. How will that (and other things) be impacted by using different upgrade options, I don't know... but waiting to see where they go first.
For now, I'm going to close this PR so it doesn't just hang out there, but this is definitely something we can look at later when we look to start work on the ng2 implementation of this project.
Thanks for submitting & adding the explanation above comparing the different upgrade options!

Hey @andrewconnell , yes I completely see and understand your point about pushing 1.0 as a priority.
Few notes though:
about ngMaterial upgrade strategy:

there will be no upgrade strategy from the code base point
ngMaterial2 is being rewritten from scratch ( that's a good thing! ngMaterial 1 modularity === ZERO )

so in case of ngOfficeUiFabric you will have two options, when ngMaterial2 is finished and pushes out the correct implementation path:

you rewrite UiFabric from scratch for ng2
or you start preparation phase with ngMetadata after 1.0 of UiFabric which will allow you to easily migrate to ng2

Anyway good luck with the project and if you reconsider ngMetadata or want to ask anything related to ng2 or migration, don't hesitate to reach me. I'd love to help!
thanks for hearing me out and cheers to whole ngUiFabric Team!


Merge to publish.

Learn Build status updates of commit ed706b3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/microsoft-365-developer-program-faq.yml
:white_check_mark:Succeeded
View

docs/microsoft-365-developer-program-get-started.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Wrong amount presented on dashboard

Steps:

Create a mosaic with divisibility 0 and amount 500 000 000
Sent transaction with amount 100 000 000 to other address.
On dashboard correct amount is presented (100 000 000)
Send next transaction with amount 400 000 000

Result: After confirmation amount is presented as 100 and 400.
Additional question: Amount column is used for XYM and other mosaics. This may be confusing. Maybe we should mark someow that this amount is not XYM but other mosaic?
Video regarding bug:
https://share.getcloudapp.com/5zuA1gwG

In the block explorer and mobile wallet we display amount only for native currency. If the transfer transaction contains non-native mosaic or message we display icons of it

In the block explorer and mobile wallet we display amount only for native currency. If the transfer transaction contains non-native mosaic or message we display icons of it

@cryptoBeliever @OlegMakarenko  Not sure I understood why wallet wouldn't show the amount. The root cause of the issue afaik is when the none native coin balance dropped to zero, the divisibility is used the default xym's.  It looks to be a bug. The custom-created mosaic should be preserved and show the correct amount in the transaction history.

@rg911 not regarding a bug

Additional question: Amount column is used for XYM and other mosaics. This may be confusing. Maybe we should mark someow that this amount is not XYM but other mosaic?

We are about the amount field in the transaction list. I think there are two ways: display amounts only for native mosaic or display amounts for all transferred mosaics [{mosaicName, amount}]. The second one may overload the list view.
The transaction details definitely should display all transferred mosaics with amounts.

Also related to https://github.com/nemgrouplimited/symbol-desktop-wallet/issues/1090

@cryptoBeliever not reproducible

I'm not able reproduce it now too.


invisible navigation buttons in IE(missed font file)

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: EXACT RELEASE VERSION OR COMMIT HASH, HERE.

Live Link or JSFiddle/Codepen or website with isssue: PREFERABLY (IF YOU WANT YOUR ISSUE TO BE RESOLVED ASAP).

What you did
Don't exist configuration and font file *.eot for IE browser
Expected Behavior
Navigation buttons are visible in IE browser
Actual Behavior
if you open https://swiperjs.com/demos/ - you don't see any navigation buttons
P.S. Remember, an issue is not the place to ask questions. You can use Stack Overflow
for that.
Before you open an issue, please check if a similar issue already exists or has been closed before.

IE is not supported


[On-Prem] HDFS Interface

This is the HDFS interface using PyArrow.
In order to run this, it assumes that you have a working hadoop, jdk installed, and proper environmental variables set in the VM. (https://arrow.apache.org/docs/python/filesystems.html#hadoop-distributed-file-system-hdfs)

Hey Hailey, the general architecture looks fine for an initial draft. Left a few minor comments.


update Logos

Update logos.
Great improvements from Jonas.
More improvements from discussion with Bjorn, Marcel and Phil.

At some point I'll make something to show the evolution of the design of the logo ;-)

The font is still Eurostile.

Good catch @marcelm I must have used a wrong branch to update the logos.
I'll change that right away.


pusher keys implementation

I implemented 2 pusher keys in my project (1 from  my main server, 1 from my inbox server).
But they're not work at the same time. Only one works.
Please help me with this issue.
Thanks in advantage !

As far as I'm aware you can only use one pusher key at a time based on Pusher's specified API. Are you able to show an example of what it would look like using 2 keys?


feat(report-portal): plugin implementation

Changes

added Instances Page
added Projects Page
added Launches Page
Updated Report Portal API
Added api pagination for table
fixed tsc and lint issues in backend plugin
added Readme files for both plugins

Screenshots

Report Portal Global page / Instances Page

Projects Page

Launches Page

Test Statistics Card

Also, @yashoswalyo , the build is failing due to some changes in the yarn.lock. Can you update the yarn.lock in your branch?

Ok


Error uploading vhd image size in bytes<PHONE_NUMBER>0

*El Explorador de Storage no pudo crear el disco.
Respuesta del servicio: {
"name": "Error",
"message": "The upload size in bytes<PHONE_NUMBER>0 - 512 bytes for the VHD footer<PHONE_NUMBER>8 in this case) must be a multiple of MiB.",
"stack": "Error: The upload size in bytes<PHONE_NUMBER>0 - 512 bytes for the VHD footer<PHONE_NUMBER>8 in this case) must be a multiple of MiB.\n    at new RestError (C:\Users\jroales\AppData\Local\Programs\Microsoft Azure Storage Explorer\resources\app\node_modules\@azure\ms-rest-js\dist\msRest.node.js:2400:28)\n    at C:\Users\jroales\AppData\Local\Programs\Microsoft Azure Storage Explorer\resources\app\node_modules\@azure\ms-rest-js\dist\msRest.node.js:3544:37\n    at process._tickCallback (internal/process/next_tick.js:68:7)",
"code": "BadRequest",
"statusCode": 400,
"request": {
"streamResponseBody": false,
"message": "The upload size in bytes<PHONE_NUMBER>0 - 512 bytes for the VHD footer<PHONE_NUMBER>8 in this case) must be a multiple of MiB."

}
}

Hey @jroales.
When uploading a disk, it's size must be between 20972032 bytes (20 MiB + 512 bytes for the VHD footer) and<PHONE_NUMBER>7520 bytes (32 TiB + 512 bytes for the VHD footer). Additionally, the size minus 512 bytes must be a multiple of MiB. You'll need to resize your VHD before uploading. I think probably this article would be of help to you: https://docs.microsoft.com/en-us/azure/virtual-machines/windows/prepare-for-upload-vhd-image

Closing due to lack of response. If you are still having issues, please open up a new issue, thanks.

As I can see after 2 years still does not work. Even if you correct file length with adding 512 for footer error still appears.
It looks like mechanims for validation bigger vhd files is corrupted.
It is more disturbing because GCP does not have such problems with migration to cloud.

it does work, he needs to add 512 bytes to the total size in bytes for the VHD footer.
So<PHONE_NUMBER>0 + 512 =<PHONE_NUMBER>2. If he does that then Azure will accept the command and create the disk in Azure.


More cleanup of threads-asm.s

Now we don't need to reference the struct from assembly.  It's a little
awkward having the two C helper functions, but I think this is pretty clean.

Got out-of-band approval

Got out-of-band approval


Display SHA for ErrRefHasChanged error

For fixing https://github.com/kubernetes/publishing-bot/issues/162
If this lgtm, I will create a PR to point go-git in publishing bot to the display-sha-for-flake branch of my fork.
/cc @dims @sttts

LGTM


Update DW.FCMManager.pas

Returning DeviceID

I've added the method outside of this pull request, since it does not pass the requirements (not in alpha order). Please see:
https://github.com/DelphiWorlds/Kastri?tab=readme-ov-file#pull-requests


npcx9m6f_evb: drivers/watchdog/wdt_basic_api/ failing

Describe the bug
Tests from drivers/watchdog/wdt_basic_api/ failing. There is no console output and timeout as a result.
To Reproduce
Steps to reproduce the behavior:

cd <path/to>zephyrproject/zephyr
source zephyr-env.sh
twister --device-testing --hardware-map <path/to>/map.yaml -T tests/drivers/watchdog/wdt_basic_api/ -vv

Expected behavior
The tests pass
Impact
annoyance
Logs and console output
-- runners.openocd: Flashing file: /home/ztest/zephyrproject/zephyr/twister-out/npcx9m6f_evb/tests/drivers/watchdog/wdt_basic_api/drivers.watchdog/zephyr/zephyr.npcx.hex
DEBUG   - Timed out while monitoring serial output on npcx9m6f_evb
DEBUG   - Expected suite names:['wdt_basic_test_suite']
DEBUG   - Detected suite names:['wdt_basic_test_suite']
DEBUG   - run status: npcx9m6f_evb/tests/drivers/watchdog/wdt_basic_api/drivers.watchdog failed
INFO    - 10/10 npcx9m6f_evb              tests/drivers/watchdog/wdt_basic_api/drivers.watchdog  FAILED Timeout (device 61.920s)
Environment (please complete the following information):

OS: Linux
Toolchain Zephyr SDK 16.0
Commit: tested on the newest and older, always the same issue

@pkunieck, thanks for reporting this. The root cause of this issue is npcx wdt driver doesn't support WDT_OPT_PAUSE_HALTED_BY_DBG option so far. Nuvoton will submit a PR to resolve this.


Added geners to Movie entity

Added geners to Movie entity

Thanks for the PR. Will review soon.
Get Outlook for iOShttps://aka.ms/o0ukef

From: kalyankk<EMAIL_ADDRESS>Sent: Friday, October 4, 2019 12:03:33 AM
To: KManiKumarReddy/Popular-Movies<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [KManiKumarReddy/Popular-Movies] Added geners to Movie entity (#1)
Added geners to Movie entity

You can view, comment on, or merge this pull request online at:
https://github.com/KManiKumarReddy/Popular-Movies/pull/1
Commit Summary

Added geners to Movie entity

File Changes

M app/src/main/java/com/kmanikumarreddy/popularmoviesstage1/Movie.javahttps://github.com/KManiKumarReddy/Popular-Movies/pull/1/files#diff-0 (11)

Patch Links:

https://github.com/KManiKumarReddy/Popular-Movies/pull/1.patch
https://github.com/KManiKumarReddy/Popular-Movies/pull/1.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/KManiKumarReddy/Popular-Movies/pull/1?email_source=notifications&email_token=ADD656M6NTKS4ALA3I7COUTQMY3H3A5CNFSM4I5GV7GKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HPPMRGA, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADD656KOJJSRICI7BNGOTB3QMY3H3ANCNFSM4I5GV7GA.


food

can you please change the name of the index.html to foodPage.html .
it's easier ot link them later

Currently the merge request is for the food branch changes to be merged into the main branch. Make sure it is merging into the develop branch instead of main

Closing this old one to approve new one


Carthage: Wrong Alamofire version in doc

On doc page Carthage section shows
github "PromiseKit/Alamofire" ~> 1.0

But when I'm trying to run Carthage I'm getting errors:
carthage update --platform ios
*** Fetching Alamofire
*** Fetching Alamofire
*** Fetching PromiseKit
*** Checking out Alamofire at "4.2.0"
*** Checking out Alamofire at "1.0.5"
A shell task (/usr/bin/env git checkout --quiet --force 1.0.5) failed with exit code 1:
error: pathspec '1.0.5' did not match any file(s) known to git.

My Cartfile is:
github "mxcl/PromiseKit" ~> 4.0
github "Alamofire/Alamofire" ~> 4.0
github "PromiseKit/Alamofire" ~> 1.0

It looks like it tries to fetch Alamofire at "1.0.5" and fails, any ideas?

1.0.5 exists: https://github.com/PromiseKit/Alamofire-/releases/tag/1.0.5
So, seems like a bug in Carthage.

OK,  if you do github "PromiseKit/Alamofire-" ~> 1.0 it works.
Seemingly still a bug in Carthage since you can clone it without the -, but that's the fix.

README updated.

thanks, now it works!


TextField stays "open" when initialized as Google Place Autocomplete Widget

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
When initialize a TextField as google place autocomplete widget target, it "opens" like if the input is focused
Expected Behavior 🤔
The TextField should not trigger any focus animation unless I click on it.
Steps to Reproduce 🕹

Here's an example.
Context 🔦

Try to use material ui + places autocomplete widget
I don't know if it's a bug with material ui or the script of the autocomplete widget, in any case it would be great to have some kind of workaround on this issue

Hi @eps1lon ,
I didn't want to put a GMaps Key since the problem was visible even without it.
I updated the codesandbox and now se google maps library load fine as an external resource of the codesandbox.

@pierluigi-giancola The API is still not working and fails with "Google Maps JavaScript API error: RefererNotAllowedMapError".
I suggest you use StackOverflow to figure out how to use the Autocomplete with Google APIs. Once you've isolated the issue to a repro without 3rd party code, we can revisit.


Not dimming anything

Hi,
it seems that twilight is not dimming the text that I'm not editing. I have the impression that the plugin is not doing anything (see screenshot).
INFO:
neovim: v0.5.1
plugins:
Plug 'folke/zen-mode.nvim'
Plug 'folke/twilight.nvim'
Plug 'neovim/nvim-lspconfig'
Plug 'nvim-treesitter/nvim-treesitter', {'do': ':TSUpdate'}

The command :PlugInstall has been runned succesfully and neovim was restarted.
Zen-mode and twilight are configure as follow:

I'm trying to edit a bash script while being in zen-mode:

what am I doing wrong?

I am experiencing this same issue

Can you see if using another colorscheme fixes it?

I've just became aware that not all colorschemes have the tree-sitter support, included mine. I haven't tried yet to install a diffirent colorscheme with such TS support...but I suspect that the issue should be related  to that. Feel free to close the issue.

I have been experiencing the same issue. I don't use a colourscheme, I just use the default theme that ships with neovim.
If there is a requirement to use a specific colourscheme that is compatible with twilight, then it might be worth indicating this in the documentation and giving some examples of known colourschemes that work well with the plugin.
Also, is it not possible for this to work with the default scheme at all?

It should work with any color scheme, but something might go wrong with some colorschemes.
Can you give me the output for:
:hi Twilight
:hi Normal

The result for the 2 commands is the following:
:hi Twilight --> E411: highlight group not found: Twilight
:hi Normal --> Normal         xxx ctermfg=223 ctermbg=235 guifg=#ebdbb2
guibg=#282828

Experiencing the same issue and having the same output of these commands

Did you run twilight setup? The colorgroup should be defined

I think I know why it's not working for you. You probably change your colorscheme after twilight setup. That would clear any hl groups set by Twilight.

also had this issue, and can confirm that it works after moving twilight setup towards the top of my config. before :hi Twilight didn't find the group until after :Twilight was run, but at that point the highlight group was empty.

@folke Thanks for the troubleshooting steps. Unfortunately the issue is still present.
Output of :hi Twilight:
:hi Twilight
Twilight       xxx guifg=#404040 guibg=#000000

Output of :hi Normal:
:hi Normal
Normal         xxx cleared

Some additional context:

Nvim version is 6.0
Terminals tested are Terminal.app on macOS Big Sur 11.6.1 & Terminal on Chrome OS (Debian container)
Nvim config handled via init.lua and is completely Lua based
Config structure for neovim can be found here
Your other plugin, Zenmode, has also been installed
Twilight plugin setup occurs before any other options are set
No colourscheme is set in this config, the default neovim theme is used

Hopefully that helps with tracking this bug down! Please let me know if there's any other information I can provide and I'll be more than happy to assist.

I can reproduce the issue on my end, too. My nvim version is  v0.6.0.
Calling :hi Twilight first returns E411: highlight group not found: Twilight, but once I call :Twilight or :TwilightEnable, I get the same output as @brotherkaif does now. (I was able to reproduce this with or without changing the default colorscheme, no changes apart from different colors in the command output with my colorscheme...)
My scenario is a current Manjaro with KDE's Konsole. (21.12.0)

Turns out that I didn't have termguicolors enabled in my config.
I hope this works for Kaif, too. Maybe this deserves a mention in the requirements-section of the README, @folke?

in my opinion that's not a good move because it's not really a requirement. termguicolors is only used if it's enabled, like you said, but also only if cterm isn't set. for example, i use hi Twilight ctermfg=8 and it works as expected. a better change would be adding a ctermfg option to the highlight definition so termguicolors doesn't need to be enabled for console users.

Fair enough, I'm not really partial to either option, so I'll defer to the maintainer. :)

Hi, I had the same issue and basically the same situation as @brotherkaif, and setting hi Twilight ctermfg=8 fix the problem for me! (termguicolors are not set). Tnx @lilibyte for mentioning it and everyone else for investigating the problem.

Hi everyone, I have tested out the fix mentioned by @lilibyte and @yistarostin and can confirm that this has resolved the issue.
Is this something that should be considered a bug (i.e. should the plugin attempt to set hi Twilight ctermfg=8 itself? Or should this be an update to the documentation and considered as user configuration?
Either way, setting hi Twilight ctermfg=8 has fixed the problem. Thanks everyone for the help :-)


Add bdk badge when available

I don't think this is coming. Will reopen if it ever becomes available.


Investigate on supporting Tokio Console

Issue summary

We shoud investigate on how to use Tokio Console alongside Forest. This kind of tooling would really help us:

understanding Forest execution flow
debugging concurency or memory issues
optimizing our async code

While Tokio Console is not tight to the tokio runtime, as of today only tokio runtime supports it.
Few possible ways of supporting this tool would be (while not trivial):

Have a native support of tokio in forest (through a feature flag)
Implement tracing in async_std runtime (so the smol runtime)
Some other shortcut?

Other information and links

https://tokio.rs/blog/2021-12-announcing-tokio-console

While Tokio Console is not tight to the tokio runtime, as of today only tokio runtime supports it.

"While Tokio Console is not tied to a specific async runtime, as of today only tokio runtime supports it." ?

While Tokio Console is not tight to the tokio runtime, as of today only tokio runtime supports it.

"While Tokio Console is not tied to a specific async runtime, as of today only tokio runtime supports it." ?

Yes exactly, you reword it very well.

The [lemmih/tokio-async](https://github.com/ChainSafe/forest/tree/lemmih/tokio-async) branch contains a version of forest that works with tokio-console. There are still some kinks to be worked out because we call async code from a few non-async places.


Google_maps_flutter not clear cache memory ios after reopen widget google map for more time

Hi @SilaDeveloper, Thanks for filing the issue. Please share the steps to reproduce the issue along with the output of flutter doctor -v.


Produce templates for portrait plots

Following the 24th Sept 2014 email to GFDL the following improvements were listed:

Produce templates for portrait plots.

test_portrait.py already plots CMIP5 results for a large suite of variables, improvements include?

Thanks to @doutriaux1 we now have two templates 3obs and 4seasons for portrait plots. Was there anything else that we needed to provide here @gleckler1 or can this issue be closed?

let's close


Initial readme

Hopefully resolves #4
Markdown view: https://github.com/tadaskay/featuros/blob/documentation-init/README.md

Current coverage is 39.8%

Merging #9 into master will change coverage by 0% by a082fee

Uncovered Suggestions

+5.61% via ...aturos/Featuros.java#54...64
+5.10% via ...on/Notification.java#37...46
+4.59% via ...ment/Deployment.java#35...43
See 7 more...

Powered by Codecov

Looks nice given current status of the project. The things I would consider adding:

What data are we planning to store and explain the fields (name, product, group, version)
We have a licence file, but maybe we should also have a notice about it in the readme.

It makes perfect sense to add these things.
Let's talk about documenting metadata though. I could think of at least 3 places where to add it:

This main project README
featuros-gradle-plugin README
Wiki/docs

To avoid duplicating things, we should decide where we place it. What do you think?

As we discussed offline, let's use following structure for main readme:
Featuros
Install
Usage (without plugins, how to post notification from command line)
Plugins (data similar to current How It Works, just add links to plugin readmes)
Run the sample
Modules
Project Goals
License
Regarding the metadata documentation  - it should probably go to wiki. Let's keep documentation for quickstart usecases in readmes and we can go deeper in wiki.

Nice job guys. Keep going!


feat Auto upgrade column_statistics from 1.2

Proposed changes
In Doris ver1.2 all the stats fields is not null, which might cause insert failure in the ver2.0. Add logic to upgrade table schema automatically
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.07 seconds
stream load tsv:          535 seconds loaded<PHONE_NUMBER>9 Bytes, about 133 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size:<PHONE_NUMBER>3 Bytes


[Merged by Bors] - Release 0.25.3

Description
Please add a description here. This will become the commit message of the merge request later.

Review Checklist

[ ] Code contains useful comments
[x] (Integration-)Test cases added (or not applicable)
[x] Documentation added (or not applicable)
[x] Changelog updated (or not applicable)
[x] Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander can you have a quick look at the checkboxes again please?

done, not sure about the useful comments here?