Folding is not working correctly for #region surrounded by imports

Environment data

Language Server version: v2023.3.30 / v2023.3.31 Pre-Release
OS and version: Windows 10
Python version (& distribution if applicable, e.g. Anaconda): Python 3.10.10

Code Snippet
# Blah, blah, blah...

import module_a
# region
import module_b
# endregion

Repro Steps
See "Code snippet".
Expected behavior
Line import module_a is not foldable (because it's one line). And if there were multiple lines, the folding should stop before # region.
Or maybe there could be an option to disable folding of imports.
Actual behavior

Logs
I haven't seen anything interesting.

Folding is still working strangely on following sample --
import module_a
# region
import module_b
a = 0
# endregion

Yes, you're hitting a limitation of VS Code's folding system. It doesn't support interleaved regions. There's more info on this here. For what it's worth, Visual Studio does handle interleaved regions (it shows folding controls for both regions in this scenario), but VS Code does not.
Here's another example that exhibits the same behavior:
def func1():
#region
    pass

a = 0
#endregion

We could special case this for imports by splitting the imports into two folding ranges (before and after the #region), but it's not clear to me that this is an important scenario to handle. I'd want to see a strong indication from users that this was valuable before investing time there.


propose different title and cross linking

@rionam

Hmmmmmmm, I'm really not keen on mixing in "here's where you can learn about site organization" and "here's where you can learn about Hugo" - the former is "best practices" in the sense that it (hopefully) produces more usable content based on our user research and experience, the other is more tips and tricks for working with a new tool. They don't seem like the same category of thing.
How about:
We keep this page as Organizing your Content BUT! we drop it down a level and create a Best Practices section. It can contain Organizing your Content and also Hugo Tips.
@rionam? thoughts?

Hmmmmmmm, I'm really not keen on mixing in "here's where you can learn about site organization" and "here's where you can learn about Hugo" - the former is "best practices" in the sense that it (hopefully) produces more usable content based on our user research and experience, the other is more tips and tricks for working with a new tool. They don't seem like the same category of thing.
How about:
We keep this page as Organizing your Content BUT! we drop it down a level and create a Best Practices section. It can contain Organizing your Content and also Hugo Tips.
@rionam? thoughts?

People wont look in an "organizing" topic for tooling related best practices.
How about a "Best Practices" landing page with two children (writing best practices & tooling best practices)?

How about a "Best Practices" landing page with two children (writing best practices & tooling best practices)?

That's what I meant! (though I probably could have been clearer - I meant the Best Practices section would contain the two docs, not that Organizing your Content would contain them)
I'd just have the existing Organizing your Content page as one child, and then Hugo Tips or something as the other one. A lot of the Hugo info isn't so much tooling best practices as tips for working with it (ie it's not so much that we recommend doing these things as that you'll get weird results if you don't), but Best Practices is as good a heading as any for now.

PTAL


[BUG] Hot reloading does not work on save

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Whenever I save the view does not reload. I can manually run :FlutterReload and it works.
Expected Behavior
For the view to reload.
Steps To Reproduce
Default settings in flutter-tools.nvim and with an minimal app provided by flutter.
Environment
- OS: Ubuntu 22.04
- Flutter version: 3.16.2
- Is flutter in $PATH: yes
- neovim version: v0.10.0-dev-1734+g76a30f2bd

Anything else?
I realized that it worked if I added an autocmd with BufWritePre in my config instead of BufWritePost for whatever reason.

For anyone coming across this still looking for a solution:
The problem is that if you are using lazy as a package manager and have your package defined like this
    {
        'akinsho/flutter-tools.nvim',
        lazy = false,
        dependencies = {
            'nvim-lua/plenary.nvim',
            'stevearc/dressing.nvim', -- optional for vim.ui.select
        },
        config = true,
    }

but you also have a custom config for flutter-tools.nvim defined somewhere, the hotreload on save doesn't work while everything else works (i think). So the solution is to either remove the config = true or to remove the custom config.


Docker is required to build

Is your feature request related to a problem? Please describe.
Coming from https://github.com/opensearch-project/OpenSearch/issues/1379, docker is required to build. But there seems to be code in place trying to say "if you don't have docker, that's ok, I'll just skip those parts". That doesn't work.
Describe the solution you'd like
Skip distribution:docker* if docker is not available.
Additional context
Docker (checked [/usr/bin/docker, /usr/local/bin/docker, C:\Program Files\Docker\Docker\resources\bin\docker.exe]) is required to run the following tasks:
:distribution:docker:buildArm64DockerImage
:distribution:docker:buildDockerImage
you can address this by attending to the reported issue, or removing the offending tasks from being executed.

To reproduce, return null from DockerSupportServices.java, private Optional<String> getDockerPath() or run on Windows.
Current workaround:
$ ./gradlew build -x ":distribution:docker:buildArm64DockerImage" -x ":distribution:docker:buildDockerImage"

since i just ran into this issue:

But there seems to be code in place trying to say "if you don't have docker, that's ok, I'll just skip those parts". That doesn't work.

where'd you see that code? i only see the explicit failure implemented here:
https://github.com/opensearch-project/OpenSearch/blob/ae14259a2c4b9dcf203dc46ef217563a33ae2901/buildSrc/src/main/java/org/opensearch/gradle/docker/DockerSupportService.java#L153

Been a while since I wrote this TBH. I did a bit of searching and can't remember what I meant anymore :(


Google Suites for NonProfits/Google Drive

Hello, this plugin is set to work with Google Cloud Storage -- does it also work with Google Suites / Drive?  This is another form of cloud storage from Google, and it would be very helpful if I could use Google Drive cloud storage as the offload point for my WordPress media library.  Thanks for your response.

Sorry, it's not possible.

Not possible, or just not set to work that way now?

Not possible, or just not set to work that way now?

not set to work that way now.

What would it take to make the necessary changes to support GSuites/Drive?

@dvhirst it will require a lot of work. Though we use a separate adapter to upload to GCS (Google Cloud Storage), some codes are still here and there.
We don't have any plans to do it now. Currently, we are working on making the current GCS experience better.
If you are a developer you can send us a pull request.

OK, thanks for letting me know.  I am not a developer, more a system admin, not eager to take on additional resources/storage from Google when the organization already has plenty available.  If the situation changes, I'm eager to hear it.

We have no future plans on supporting Google Drive. WP-Stateless is only focused on Google Cloud Storage at this time.


API Antiforgery

The API controllers just inherit from the Controller which doesn't have the autoAntiforgery attribute.
Do we want to change this.

Interesting one -- probably we should fix.  As you say thought it might break several things since we'd need an automated way of getting the token and supplying it to all fetch POST requests.  Probably via context API.  Let me think about options.


Getting a wildcard directive warning from an OWASP zap scan that uses htmlunit-csp

I'm getting a CSP: Wildcard Directive medium-level warning from an OWASP zap scan that utilizes htmlunit-csp to determine the quality/security of a policy. This is when given the following policy:
default-src 'self'; script-src 'sha256-V9aCN36/azMjZ4UI2Gn224a5ZheabkDM9KlfEYVxacE=' 'sha256-2Az4yarMUUN/qlp7SBuAZ2xzTgO2hWYIiQ+FQuy/F7U='; style-src 'self' 'sha256-e/YMGdDlQb+SQxsaWl4HPQFw1kHpLE7FsvDQ3omByuU='; img-src 'self' data:; font-src 'self' data:; frame-ancestors 'none'; object-src 'none'; base-uri 'none';

As far as I can tell, the above does not contain a wildcard directive, although, I am no expert on the intricacies of these kind of policies. Is the above indeed a false positive caused by a wrong determination of htmlunit-csp or am I not parsing the above policy correctly and is there indeed something in there that causes it to be considered as a wildcard directive?

Will have a look....

Can you please provide the whole msg with all details...
I simply found this page https://www.zaproxy.org/docs/alerts/10055-4/ containing this statement:
The following directives either allow wildcard sources (or ancestors), are not defined, or are overly broadly defined: connect-src.
Maybe this is is the reason????

Hi  @rbri thanks for taking a look. I think that's it, I must be dense (it's been a long tuesday); I'll have a look-see and see what the OWASP zap-test does when I add connect-src to the policy. Thanks a lot + sorry for the I-did-not-RTFM-hard-enough!

I must be dense (it's been a long tuesday)

I know this kind of days :-) - no worries

@rbri I was discussing this with colleagues this morning, and connect-src missing should default-src which we set to self in this policy; are you aware of specific issues when connect-src is not defined that would neccesitate triggering this warning?

@rubin55 not really, i have more or less cloned this lib and applied some outstanding patches and improvments. Maybe that is something we have to discuss with the zac peoples..
@kingthorin?

I believe connect-src is amongst those that don't fallback. I'll dig into docs and see if something has changed or if I've gotten something wrong.
Either way this is a ZAP issue not an htmlunit-csp issue. So @rubin55  if you could create an issue here:    https://github.com/zaproxy/zaproxy/issues/new?assignees=&labels=bug&projects=&template=bug-report.yml and close this one that's probably best.
(You could link this issue in the "Additional context" field)

[!NOTE]
ZAP left OWASP over a year ago :wink:

Oh connect-src isn't specific to this issue that's just the doc's example alert.
The item that's actually wrong in your CSP should be listed in either the specific alert's Description or Other Info field.

Specific to the CSP listed in the original issue above:

The directive(s): form-action are among the directives that do not fallback to default-src, missing/excluding them is the same as allowing anything.

This issue can be closed and there's no need to raise one for ZAP.
If you have further questions/concerns please follow-up via the ZAP User Group.


Fix #476: Raise RuntimeError when chunked enabled and HTTP is 1.0

Fix for #476

Hmm, perhaps we should disable compression for HTTP/1.1 also.

It would be nice if the documentation for enable_chunked_encoding() would mention that, and that you don't need it if content_length is set.

i think RuntimeException is fine for chunking and compression.

Updated docs. @vbraun is it clear for you now?

Thats great, thank you for the help!


Incorporate additional metadata that's imported from tags via LMS scanner

At present LMS presents all albums an artist appears in as one consolidated list without distinguishing between albums, EP's, Singles, Bootlegs, Compilations, Appearances and Various Artist albums.
Given that LMS' scanner pulls tags that would help with being able to present recordings distinguishing between these types (and thus making it far easier to explore a large body of work) it'd be hugely beneficial for if Material skin could leverage this metadata where the tags exist.
The attached image shows three data points that lend themselves to an enriched exploration of a music collection:
LABEL: Record label, which would enable exploration of a library by record label
RELEASTYPE: Release Type (https://musicbrainz.org/doc/Release_Group/Type addressing albums, EP's, Singles, Bootlegs, Compilations, Appearances and Various Artist releases
)
VERSION: musicbrainz' _releasecomment to distinguish different releases of an album from one another

Would you consider leveraging these tags where they're present in the LMS database?

The items are not available via LMS' JSONRPC API.


api request error

the request parameter is a base64 image:
[2024-02-04 13:59:24,982] ERROR in app: Exception on /analyze [POST]
Traceback (most recent call last):
File "/home/andy/deepface/.venv/lib/python3.10/site-packages/flask/app.py", line 1463, in wsgi_app
response = self.full_dispatch_request()
File "/home/andy/deepface/.venv/lib/python3.10/site-packages/flask/app.py", line 873, in full_dispatch_request
return self.finalize_request(rv)
File "/home/andy/deepface/.venv/lib/python3.10/site-packages/flask/app.py", line 892, in finalize_request
response = self.make_response(rv)
File "/home/andy/deepface/.venv/lib/python3.10/site-packages/flask/app.py", line 1183, in make_response
rv = self.json.response(rv)
File "/home/andy/deepface/.venv/lib/python3.10/site-packages/flask/json/provider.py", line 214, in response
f"{self.dumps(obj, **dump_args)}\n", mimetype=self.mimetype
File "/home/andy/deepface/.venv/lib/python3.10/site-packages/flask/json/provider.py", line 179, in dumps
return json.dumps(obj, **kwargs)
File "/usr/lib/python3.10/json/init.py", line 238, in dumps
**kw).encode(obj)
File "/usr/lib/python3.10/json/encoder.py", line 199, in encode
chunks = self.iterencode(o, _one_shot=True)
File "/usr/lib/python3.10/json/encoder.py", line 257, in iterencode
return _iterencode(o, 0)
File "/home/andy/deepface/.venv/lib/python3.10/site-packages/flask/json/provider.py", line 121, in _default
raise TypeError(f"Object of type {type(o).name} is not JSON serializable")
TypeError: Object of type int32 is not JSON serializable
What needs to be modified?

I am currently working on this bug, will be sorted soon

Closed with PR - https://github.com/serengil/deepface/pull/1004

This change is not published in pip yet. You can use source code instead of pip package until a new release published.


Quote the license file

Place the license_file location in quotes for good measure.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Raised this anomaly as issue ( https://github.com/conda/conda-build/issues/2397 ).


AttributeError: module 'pymeshlab' has no attribute 'Percentage' when export mesh.

Description
The latest version of pymeshlab has removed attribute 'Percentage',you should downgrade the version to 2022.2 by
pip install pymeshlab==2022.2
Steps to Reproduce
pip install -r requirements.txt
Expected Behavior
AttributeError: module 'pymeshlab' has no attribute 'Percentage'
Environment
Ubuntu22.04 pytorch1.12.1+cu116,cuda11.6

Any solution for this?
Thanks.


Statically linking an executable with JPEG XL enabled breaks the build at link time

I'm working on a project where I want to CMake-consume (via FetchContent), build, and statically link all the dependencies (SDL, all the satellite libraries) for distributed release builds. Enabling JPEG XL breaks the build though, as it needs C++, and C++ doesn't get enabled properly in this setup, so the build output throws a bunch of C++ linking errors. For now, adding an enable_language(CXX) gets it working, but that doesn't really seem correct, I don't think a CMake project (mine) consuming another (SDL_image) should have to do that, if my project's code doesn't include any C++. So, somehow, C++ needs to get enabled so the final statically linked executable can get the C++ code linked in.
I've encountered this bug with both SDL2 and SDL3.

This is a CMake quirk you're encountering.
We do enable_language(CXX) in our cmake script.
This sets the LINKER_LANGUAGE property of the SDL_image targets to CXX.
For some reason CMake needs enable_language(CXX) at the same level when using any target that uses c++.
I cannot immediately find an issue at CMake's issue tracker.

C executable using a C++ static library
cmake_minimum_required(VERSION 3.25)
project(masterproject LANGUAGES C)

file(WRITE subproject/CMakeLists.txt [=====[
cmake_minimum_required(VERSION 3.25)
project(subproject LANGUAGES C CXX)

file(WRITE lib.cpp [=[
#include <filesystem>

extern "C" {

int exists(const char *filename) {
 std::error_code ec;
 return std::filesystem::exists(filename, ec);
}

}
]=])
add_library(sublibrary STATIC lib.cpp)
target_link_libraries(sublibrary stdc++fs)
set_property(TARGET sublibrary PROPERTY CXX_STANDARD 17)
]=====])

file(WRITE main.c [=[
#include <stdio.h>
extern int exists(const char *filename);

int main(int argc, char *argv[]) {
  if (argc < 2) {
   fprintf(stderr, "Need argument\n");
   return 1;
  }
  printf("Exists: %d\n", exists(argv[1]));
  return 0;
}
]=])
add_subdirectory(subproject)
add_executable(main main.c)
target_link_libraries(main PRIVATE sublibrary)

# Uncomment the following line to fix the link error
# enable_language(CXX)

I'm closing this issue.
Let's hope a future CMake release fixes this.


feat: native support for haptic feedback

This PR adds native support for haptic feedback!
It uses performHapticFeedback on Android and UINotificationFeedbackGenerator on iOS
It's enabled by default and can be disabled by passing hapticFeedbackEnabled={false} to the navigator

@benkingcode You are right, this should be set to false by default 😅 This can be changed in the next release


Increase timeout time for playground building

What this PR does / why we need it:
The playground building job is failed by timed out(10m), so increase the timeout limit.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/approve


Only (re)Publish if the Status is "Publish"

We should leave the previous version of the document in place if the current version has a Status that is not Publish.
This will require not deleting the destination docs directory, and that will require that we notice what documents are no longer in Notion at all, so that we can delete them.

Fixed in 7c956f02e5632bc7d35f4ab6f22cfe2199a25311


New Plug-in: --hashtag-posts

What would you like to be added: interact to post owners in recent hashtag view
Why is this needed: some people would be interested to interact with these users to grow up their visibility / create collaborations with them

closing


Update the current module when a new file is parsed

FixAnnotateJson.current_module is currently a constant value set in __main__, but this causes bugs when pyannotate is run on a package directory, where the current module should be updated for each file that is parsed.
To fix this, I implemented set_filename, which is inherited from BaseFix, to update the current module each time the file changes.
To test, I removed the annotation from parse_type_comment and created a type_info.json file to provide the type data:
[
  {
    "func_name": "parse_type_comment", "line": 213,
    "path": "/Users/chad/dev/pyannotate/pyannotate_tools/annotations/parse.py",
    "samples": 0,
    "signature": {
      "arg_types": ["str"],
      "return_type": "Tuple[pyannotate_tools.annotations.parse:List[pyannotate_tools.annotations.parse.Argument], pyannotate_tools.annotations.parse.AbstractType]"
    }
  }
]

I saw two types of bugs with the current implementation.

imports statements were added that imported types from the current module:

pyannotate --uses-signature pyannotate_tools pyannotate_runtime
Refactored pyannotate_tools/annotations/parse.py
--- pyannotate_tools/annotations/parse.py	(original)
+++ pyannotate_tools/annotations/parse.py	(refactored)
@@ -10,6 +10,9 @@
 import sys

 from typing import Any, List, Mapping, Set, Tuple
+from pyannotate_tools.annotations.parse import AbstractType
+from pyannotate_tools.annotations.parse import Argument
+from pyannotate_tools.annotations.parse import List
 try:
     from typing import Text
 except ImportError:
@@ -211,6 +214,7 @@

 def parse_type_comment(comment):
+    # type: (str) -> Tuple[List[Argument], AbstractType]
     """Parse a type comment of form '(arg1, ..., argN) -> ret'."""
     return Parser(comment).parse()

If I passed two packages on the command line the second would be completely ignored.

pyannotate --uses-signature pyannotate_runtime pyannotate_tools
No files need to be modified.

I looked into writing tests for this, but the test case base class from lib2to3 that’s in use here appears to be designed to test before-and-after code snippets. We would need something higher level that tested runs across multiple files.  Having tests at that level would be great but it’s an order of magnitude more work, and I’m not sure I’ll have time for it.  I’ll see if there is an existing test case from lib2to3 that we can use for this purpose, just to get a sense of the scope.

Alternately I can write a super simple test function that demonstrates that calling set_filename on an instance of the fixer class updates the current module.  Is that what you had in mind?

Yes please, we can still write regular tests.

Ok, added a test that confirms that our overridden set_filename is called.   That should give us a reasonable assurance that the module will be set.

Hm, it looks like I'm no longer on the team that can merge PRs on this repo. Hopefully @msullivan or @JukkaL can still do it?


Working on improving content-index responses to events in Indy

Working on improving content-indexer responses to events in the system, and formalizing the enable/disable event set so we can listen to it.
This is still under some development, with ContentIndexObserver and StoreEnablementListener in need of some uncommenting / debugging. I believe the concepts are sound though (the ones I have commented in those classes).
@pkocandr I wanted to submit this as a PR anyway to show where I was planning to go with the work, and see if you think it looks like a sound approach. In particular, I was planning to make StoreEnablementManager respond to ArtifactStoreEnablementEvent instead of the ArtifactStoreUpdateEvent that it uses to set the disabled timeout...and even more importantly, the ContentIndexObserver, which has a bunch of commented out code. Those commented sections were causing test failures, and I didn't want to leave this work on my localhost, so I took them out temporarily. You should find // FIXME comments in places I intend to get back to.
This PR isn't necessarily something I mean to merge as-is...it's more to provide you with my current progress.

retest this please

retest this please


CASMCMS-8645: Update many BOS v2 and multitenancy bugs

Summary and Scope
Updates BOS to pull in fixes v2 and multi-tenancy bugs as well as an updated spec that more accurately reflects the behavior of the API.
Issues and Related PRs

Resolves CASMCMS-8612
Resolves CASMCMS-8613
Resolves CASMCMS-8614
Resolves CASMCMS-8617
Resolves CASMCMS-8630
Resolves CASMCMS-8645
and other spec tickets

Testing
Mostly tested on Ashton.  See individual tickets for details.
Risks and Mitigations
None
Pull Request Checklist

[X] Version number(s) incremented, if applicable
[X] Copyrights updated
[X] License file intact
[X] Target branch correct
[X] CHANGELOG.md updated
[X] Testing is appropriate and complete, if applicable
[X] HPC Product Announcement prepared, if applicable

/backport stable/1.5


[misc]:  XHR failed 400  - {"error":"Failed to verify URL"}

I understand that this issue may be closed if it should be filed in another category

[X] I understand

My issue
Hi,
I am getting this error: XHR failed 400 - {"error":"Failed to verify URL"}. I was uploading some photos, and after uploading the first one, I tried to upload a second photo, but I got this error. Now, I am getting this error every time I try to upload. I have changed the keys, upgraded the dependencies, and double-checked everything, including trying to upload some photos on the dashboard, which were uploaded successfully.
System:
OS: Windows 11 10.0.22631
CPU: (12) x64 AMD Ryzen 5 5600X 6-Core Processor
Memory: 11.82 GB / 31.93 GB
npmPackages:
@uploadthing/react: ^7.1.1 => 7.1.1
typescript: ^5.4.5 => 5.4.5
uploadthing: ^7.3.0 => 7.3.0

Well, refreshing the broken date and time on my Windows 11 fixed the problem. I was on Linux trying to upload the first image, and when I switched to Windows, I forgot to refresh the date and time.


[Brackets] in content type's name are causing the model generator to fail

Brief bug description
What went wrong?
When running the model generator while having content type with brackets in its name, the error gets thrown:
Repro steps

Prepare content type with brackets in its name such as [Buggy] brackets
Run content generator
See error

SyntaxError: '=' expected. (9:18)
7 | * Codename: buggy_brackets_
8 | */

9 | export type Buggy[brackets] = IContentItem<{
|                  ^
10 |     /**
11 | * Test (text)
12 | * Required: false

...
throw Error(Failed to process content type '${type.codename}' (${type.name}));
^
Error: Failed to process content type 'buggy_brackets_' (Buggy[brackets])
Expected behavior
The error does not get thrown and the content type with brackets gets generated.
Test environment

Platform/OS: Windows 10
<EMAIL_ADDRESS>

Hi @lukas-lacko,
yeah, we found out that there could be many different characters used across objects which may cause issues. You may use name resolvers (see readme) to manually strip the name of unwanted characters. I'm also expecting to adjust the model generator to strip more unwanted characters so the custom name resolver might not be needed in future releases.

This is now fixed by default if no custom configuration is used.


Gradual buildup of Grid Control

This issue addresses the task of creating the Aurelia wrappers for KendoUI grid control. We established that the major problem is that both Kendo and Aurelia have their own templating and we need to find the solution how to make them collaborate in a most efficient way.
In order to really understand this whole situation, I decided to start analyzing things at a much lower level than this article, so consider this (Gradual buildup of Grid Control) article a predecessor.
So, I wanted to start with Templating in the context of aurelia kendoui plugin and immediately discovered that I need to describe even the more basic setup - KendoUI Grid walthrough where I am showing how to create the "models of grids" in KendoUI native context, without any references to Aurelia.
Check the following sections and note that this article will grow to cover all our needs for creating the KendoUI Grid wrapper.
Also note that all samples in KendoUI Grid walthrough are instrumented with support to run them in plunker.

Grid Creation
Our Basic Grid sample

Current status on 12/05/2019
The Basic Use case of the Grid demo is augmented to show the Our Basic Grid sample introduced above. However, the setup I managed to create is defective as the data shown in the grid

contains a lot of "garbage" meaning that the view
 <au-kendo-grid data-source.bind="datasource" auto-bind.bind="false" pageable.bind="true" sortable.bind="true">
 </au-kendo-grid>

and the view model
export class BasicUse {
  datasource;

  constructor() {
    this.datasource = {
      type: "odata",
      serverFiltering: true,
      transport: {
        read: "//demos.telerik.com/kendo-ui/service/Northwind.svc/Customers"
      }
    };
  }
}

are not "in sync"
Hints for next steps

fix the above mentioned grid rendering
note that the our basic grid sample is actually a slightly diminished version of this Kendo sample, where I took this template

                  template: "

" +
                                "
#: ContactName #
",

from the definition of columns (because I did not have the customers images). See if you can add such template (and provide access to images) so that the wrapped grid renders like the original

We will document this as part of the grid performance improvements mentioned in this issue


03 use redux in react components

In this pull request, I have implemented:

Keep state immutables
Initialize the array with a few books
Connect the app with Redux Store
Use useDispatch and useSelector
Add functionality to add a new book
Add functionality to remove the book
Check the status of categories

@Wes-Isaac Thanks for your kind review.


Package version inconsistency

The package version in manifest and pop-up view still is 0.6.0

Fixed in 0.9.2
Thanks


Always include geode param in authored urls [#182089196]

PT: [#182089196]
Demo: https://tectonic-explorer.concord.org/branch/author-url/index.html?authoring

Was that requested by the project team? Looks good 👍

[#182089196] Yes, otherwise authored Geode urls bypassed the mode selection wizard but authored TecRocks urls showed the mode selection wizard because the geode parameter was omitted.


Please include auto acknowledge for low priority issues

@shubham-wise since Low Priority issues don't escalate, what's the use case for wanting them to be automatically acknowledged?

My mistake,
I am not well versed with pagerduty vocabulary.
Sometimes, during on-call I receive too many notifications, and I want some of the these (matching some pattern or keyword) notifications do not even notify me and get auto acknowledged.


automatic token authentication should mention that it might not be possible to set read-write permissions

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token
What part(s) of the article would you like to see updated?
The text should clearly explain that it's possible for the setting for read-and-write permissions to be disabled at an org (or presumably enterprise) level.
Additional information
See https://github.com/orgs/community/discussions/21061

hi @jsoref,
Thanks so much for opening this issue. 💛
We agree with you that it would be helpful if there was a mention (perhaps a short paragraph) in "Modifying the permissions for the GITHUB_TOKEN" that explains why a user might see read-write permissions settings as unavailable in this content (due to restrictions set by an org owner or enterprise owner).
The new paragraph should link out to both the relevant for org owners and enterprise owners:

Enforcing a policy for workflow permissions in your enterprise
Setting the permissions of the GITHUB_TOKEN for your organization

You or another contributor are welcome to open a PR for this change! ✨


Upgrade to .NET 6

why force-push?

@SupinePandora43 Cause I always rebase this branch to main.

Automatic rebase to main has failed. Manual rebase is required.

Automatic rebase to 'main' has failed. Manual rebase is required.

Automatic rebase to branch 'main' has failed. Manual rebase is required.


[Improvement][Seatunnel-web] Rename package com.whaleops.datasource to org.apache.seatunnel

Renamed package com.whaleops.datasource to org.apache.seatunnel

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs

Executed integration tests to ensure existing functionalities are not impacted.


Haskell-ghc-mod: ghc-mod command check failed with error Error

[Enter steps to reproduce below:]

Make a file with this contents
module Main where
import Lib
import Control.Monad(forever)
import Data.Char (toLower)
import Data.Maybe (isJust)
import Data.List (intersperse)
import System.Exit(exitSuccess)
import System.Ramdom(randomRIO)
type WordList = [String]
minWordLength :: Int
minWordLength = 5
maxWordLength :: Int
maxWordLength = 9
allWords :: IO WordList
allWords = do
dict <- readfille ¨data/words
return (lines dict)
gameWords :: IO WordList
gameWords = do
aw <- allWords
return (filter gameLength aw)
where gameLength w =
let l = length (w :: String)
in l > winWordLength && l < maxWordLength
randomWord :: Wordlist -> IO String
randomWord wl = do
randomIndex <- randomIO ( 0, length wl - 1 )
return $ wl !! randomIndex
randomWord' :: IO String
randomWord' = gameWords >>= randomWord

.Save the file

Atom Version*: 1.5.4
System: Ubuntu 15.10
Thrown From: Atom Core
Stack Trace
Haskell-ghc-mod: ghc-mod command check failed with error Error
At caps: {"version":[5,5,0,0],"legacyInteractive":true,"fileMap":true,"rootExec":false,"quoteArgs":true,"optparse":true}
URI: /home/roelof/Documents/haskellbook/chapter_13/hangman/app/Main.hs
Args: --
message: spawn ghc-mod ENOENT
log:
-28.82s: Trying to run ghc-modi in /home/roelof/Documents/haskellbook/chapter_13/hangman
-28.819s: Checking for ghc-modi in /home/roelof/Documents/haskellbook/chapter_13/hangman
-28.819s: Found running ghc-modi instance for /home/roelof/Documents/haskellbook/chapter_13/hangman
-28.816s: Timeout
-28.768s: Trying to run ghc-modi in /home/roelof/Documents/haskellbook/chapter_13/hangman
-28.768s: Checking for ghc-modi in /home/roelof/Documents/haskellbook/chapter_13/hangman
-28.768s: Found running ghc-modi instance for /home/roelof/Documents/haskellbook/chapter_13/hangman
-28.768s: Timeout
-0.094s: running ghc-mod check,/home/roelof/Documents/haskellbook/chapter_13/hangman/app/Main.hs,-- with options.cwd = /home/roelof/Documents/haskellbook/chapter_13/hangman,options.env = [object Object],options.encoding = utf-8
-0.076s: running ghc-mod lint,/home/roelof/Documents/haskellbook/chapter_13/hangman/app/Main.hs,-- with options.cwd = /home/roelof/Documents/haskellbook/chapter_13/hangman,options.env = [object Object],options.encoding = utf-8
-0.063s: Main did-save triggered
-0.063s: Main updating
-0.063s: running ghc-mod browse,-d,--,Main with options.cwd = /home/roelof/Documents/haskellbook/chapter_13/hangman,options.env = [object Object],options.encoding = utf-8
-0.047s: Using fallback child_process because of spawn ghc-mod ENOENT
-0.029s: Using fallback child_process because of spawn ghc-mod ENOENT
-0.016s: Using fallback child_process because of spawn ghc-mod ENOENT
0s: Error: spawn ghc-mod ENOENT

Error: spawn ghc-mod ENOENT
    at exports._errnoException (util.js:837:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)
    at onErrorNT (internal/child_process.js:344:16)
    at doNTCallback2 (node.js:441:9)
    at process._tickCallback (node.js:355:17)

Commands
     -2:36.4.0 editor:newline (atom-text-editor.editor.is-focused)
     -1:46.3.0 core:move-right (atom-text-editor.editor.is-focused)
     -1:31.3.0 core:backspace (atom-text-editor.editor.is-focused)
     -1:27.9.0 core:move-left (atom-text-editor.editor.is-focused)
  2x -1:26.3.0 core:move-right (atom-text-editor.editor.is-focused)
  2x -1:20.2.0 editor:newline (atom-text-editor.editor.is-focused)
  2x -1:18.8.0 core:move-left (atom-text-editor.editor.is-focused)
     -1:17.9.0 core:move-down (atom-text-editor.editor.is-focused)
  5x -1:17 core:move-up (atom-text-editor.editor.is-focused)
  5x -1:15.7.0 core:move-down (atom-text-editor.editor.is-focused)
     -0:44.2.0 editor:newline (atom-text-editor.editor.is-focused)
  3x -0:41.9.0 core:backspace (atom-text-editor.editor.is-focused.autocomplete-active)
     -0:30.5.0 core:move-down (atom-text-editor.editor.is-focused.autocomplete-active)
     -0:29.7.0 autocomplete-plus:confirm (atom-text-editor.editor.is-focused.autocomplete-active)
  2x -0:07.6.0 editor:newline (atom-text-editor.editor.is-focused)
     -0:02.2.0 core:save (atom-text-editor.editor.is-focused)

Config
{
  "core": {},
  "editor": {
    "invisibles": {}
  }
}

Installed Packages
# User
autocomplete-haskell, v0.6.2
haskell-ghc-mod, v1.11.0
ide-haskell, v1.5.3
ide-haskell-repl, v0.0.19
ide-haskell-stack, v0.0.3
language-haskell, v1.7.2

# Dev
No dev packages

Sorry you're running into trouble here! This looks like an issue with haskell-ghc-mod though – feel free to open an issue there.

Sorry about this, apparently child_process reports incomplete stack in its error object, so that's why this happened. Should be fixed in latest release.


How to add Controlnet Unit into my code which use the way about "alwayson_scripts"

Sry to bother you ! I want to add more controlnet units in my code which use SD api to finish img2img.How to do that? My code is use "alwayson_scripts"  too.

You can use alwayson_scripts along with controlnet_units. webuiapi internally adds ControlNet to the alwayson_scripts by default. If you pass use_deprecated_controlnet=True, it will use old /controlnet/img2img api endpoint.


add APPLICATION_DATA_LINK to dimensions demo package

This is to conditionally show the app data link in the console.

jenkins, test this please

jenkins, test this please

jenkins, test this please

jenkins, test this please

jenkins, test this please


./gcloud.sh fails when tmp-instance disk is present but instance is not

TASK [deployment-create : check if deployment osd03-tmp-instance exists] **********************************************************************************************************
ok: [localhost]
TASK [deployment-create : debug] **************************************************************************************************************************************************
skipping: [localhost]
TASK [deployment-create : create deployment osd03-tmp-instance] *******************************************************************************************************************
skipping: [localhost]
TASK [refresh gce inventory] ******************************************************************************************************************************************************
ok: [localhost]
TASK [ssh-config-tmp-instance : configure ssh for ocp temp instance] **************************************************************************************************************
fatal: [localhost]: FAILED! => {"failed": true, "msg": "the field 'args' has an invalid value, which appears to include a variable that is undefined. The error was: 'ansible.vars.hostvars.HostVars object' has no attribute u'osd03-tmp-instance'\n\nThe error appears to have been in '/home/brad/openshift-ansible-contrib/reference-architecture/gce-cli/ansible/playbooks/roles/ssh-config-tmp-instance/tasks/main.yaml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: configure ssh for ocp temp instance\n  ^ here\n"}

Ultimately I had to gcloud --project openshift-dev-03 deployment-manager deployments delete osd03-tmp-instance.  So it seems that the logic checks that the deployment exists and if it does it then assumes the instance exists.  I think that I probably had an illegal imageSource definition in my configuration in that deployment.  After I fixed the problem the deployment didn't get updated because it already exists.

Correct, it checks only whether the deployment exists. Best fix, for now, is to teardown the infra and recreate it when you encounter similar problem again ./gcloud.sh --teardown && ./gcloud.sh. I'll see if I can check also the deployment state and not only its existence.
Thanks for the PR and the issue, feel free create more issues if you encounter more problems.

 (8) OpenShift-Ansible-Contrib issues and PRs


Mark all occurrences of alias named property depends on which token I click first

TS Template added by @mjbvz
TypeScript Version: 4.0.0-dev.20200624
Search Terms

documentHighlights

interface Foo {
	prop: number;
}

function bar(arg: Foo) {}

const prop = 123;
bar({ prop });

I think that when I select prop on line 8, all occurrences of prop should be highlighted, independently of having clicked prop elsewhere right before.

@alexdima I believe this code is why the requests are not fired again:
https://github.com/microsoft/vscode/blob/2f367a51c364c1cb95865960de29bfd82cb94776/src/vs/editor/contrib/wordHighlighter/wordHighlighter.ts#L88
I'm assigning to you since you've touched these files recently but please reassign if there is a better owner

PR welcome. That code was written at a time when document highlights were transitive in TS :).

and @CyrusNajmabadi if this is something that you're considering changing in VS Code.

Currently, Roslyn's take is that these are transitive (i believe).  So we are fine with teh current behavior and aren't asking for it to change.  I do see TS/Js's perspective here.   My major concern is that one could be navigating through the highlights, and then get to an item that causes there to be less highlights.  That would then break the ability to cycle through the original set, which seems unfortunate.

PR welcome. That code was written at a time when document highlights were transitive in TS :).

@alexdima I've added help-wanted.

As I mentioned above, I would be very wary of making such a change here. If you requery for highlights then you break the ability to cycle through all the highlights. The current behavior seems fine to me. The set of highlights is picked b based on the initial user selection, then navigation through them used that list.

I agree with @CyrusNajmabadi that cycling through references with F7 is a core experience which we shouldn't break.
I've removed the help wanted. Let's avoid asking for PRs which we might not take.


Python H11 0.8.0 Breaks mitmproxy

Steps to reproduce the problem:

Upgrade from Python-h11-0.7.0 to 0.8.0

Any other comments? What have you tried so far?
After Upgrading I get the following error (Please note that 0.8.0 is now being pushed by Arch Linux Repos)
Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/pkg_resources/init.py", line 574, in _build_master
ws.require(requires)
File "/usr/lib/python3.6/site-packages/pkg_resources/init.py", line 892, in require
needed = self.resolve(parse_requirements(requirements))
File "/usr/lib/python3.6/site-packages/pkg_resources/init.py", line 783, in resolve
raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (h11 0.8.0 (/usr/lib/python3.6/site-packages), Requirement.parse('h11~=0.7.0'), {'wsproto'})
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/bin/mitmproxy", line 6, in
from pkg_resources import load_entry_point
File "/usr/lib/python3.6/site-packages/pkg_resources/init.py", line 3088, in
@_call_aside
File "/usr/lib/python3.6/site-packages/pkg_resources/init.py", line 3072, in _call_aside
f(*args, **kwargs)
File "/usr/lib/python3.6/site-packages/pkg_resources/init.py", line 3101, in _initialize_master_working_set
working_set = WorkingSet._build_master()
File "/usr/lib/python3.6/site-packages/pkg_resources/init.py", line 576, in _build_master
return cls._build_from_requirements(requires)
File "/usr/lib/python3.6/site-packages/pkg_resources/init.py", line 589, in _build_from_requirements
dists = ws.resolve(reqs, Environment())
File "/usr/lib/python3.6/site-packages/pkg_resources/init.py", line 783, in resolve
raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (h11 0.8.0 (/usr/lib/python3.6/site-packages), Requirement.parse('h11~=0.7.0'), {'wsproto'})
System information

Mitmproxy: 3.0.3
Python:    3.6.4
OpenSSL:   OpenSSL 1.1.0g  2 Nov 2017
Platform:  Linux-4.15.11-1-ARCH-x86_64-with-arch

Not much we can do about this. Thats the reason why we have dependency management.
mitmproxy depends on wsproto>=0.11.0.
wsproto depends on h11 ~= 0.7.0.
I would recommend opening an issue with wsproto, or even better send PR to fix the incompatibility.


Load assets only as the collection view requests them

This greatly improves the speed for loading libraries with a large number of assets

Thanks for your code!!! Thanks for the performance improvement!!! I'll merge it, but I would like to separate the DKVideoAssetCell to DKVideoAssetCell and DKAssetCell, I'll make a small change :)

Hi @scottdelly
This branch has conflicts with develop and master, I have make a commit with your code:
https://github.com/zhangao0086/DKImagePickerController/commit/ed4b8d744e7489ea51a5096c0511eea2cc2ab7a2
Thanks for your contribution again!

Special Thanks
Thanks for scottdelly's contribution and performance improvement!


Wired things happen when applied to FPN

Hi, thanks a lot for your code.
But when I apply this code to my implemented e2e version of FPN, some wired things happen.
If I use 8 cards, the GPU memory continues to increase until one card occupies all GPU memory. Then the FPN get stuck and the GPU utilization of other not-full cards are 100%.
If I use 4 cards, the memory continue to increase and then FPN may get struck with all GPU utilization as 0.
I used PyTorch 0.4.0 with your DataParallelWithCallback and the input image size is different on different cards. And if I use BN from official pytorch, my code works well.
Could you pls give me any hints to help me to find the reason?

Hi @ShuLiu1993 thank you for your report.
In my guess, there might multiple reasons for this.

This code is tested for PyTorch 0.3.1. While 0.4 is still a very new release and there are some changes breaking the backward compatibility, I am not sure if this code works perfectly with 0.4. Can you try to switch your PyTorch version to 0.3.1 temporarily?
This code has been tested for real-world applications such as semantic segmentation (See https://github.com/CSAILVision/semantic-segmentation-pytorch). I am not sure about your own implementation of FPN. Is it possible that something in your code is not compatible with the SyncBN?

If possible, could you please provide a minimal example reproducing the result you encountered? It will be extremely helpful for finding out potential compatibility issue or bugs.

Hi @vacancy,
Thanks a lot for your reply.
I solved this problem by cleaning the environment and using the code from repo (https://github.com/CSAILVision/semantic-segmentation-pytorch), although they seem very similar.

Hi @ShuLiu1993
The repo semantic-segmentation actually does not use the official release of 0.4. Their code was based on a pre-release (a github) version of pytorch. Could you please try also 0.3.1? You can install it easily with conda by some command like conda install pytorch=0.3.1.
I am sorry that I can not reproduce the results you mentioned as I am not working on exactly your model. If it is convenient, could you please provide me with a minimal reproduction code? It will be also appreciated if you can instead help me debug out the issue.
If you can make sure that it is SyncBatchNorm that produce the "stuck", you can try to insert a try-catch block in SyncBatchNorm's forward function. By doing so you can better inspect the exceptions.

@ShuLiu1993 I see. The bug in PyTorch 0.3.1 is due to a bug reported in this issue.
Thank you so much for the help. For the debug, could you first check if there is any error reported in forward? Due to the python implementation, exceptions from subthreads may not be throw out. I recommend you to wrap the forward function manually with a try-catch block to inspect if there is any error occurred.
A sample code is:
def forward(self, input):
    try:
        self._forward(input)
    except Exception as e:
        logger.exception('Error occurred.')

def _forward(self, input):
    # original codes goes here.

You can also rewrite the code as a pythonic method decorator.

@ShuLiu1993
Hi,have you solved the problem about getting stuck?
I also get stuck after several iterations. I use official release of pytorch 0.4

@ShuLiu1993 Hi,Have you solved this problem?

@ShuLiu1993
Hi,have you solved this problem? I also get stuck after several iterations and all dataloder threads are dead

@ShuLiu1993
is this problem related with roi pooling implemented in pytorch?
if you use roi pooling in your codes?

I also get stuck after several iterations. My pytorch version is 0.4.1. I just try to use resnet101 in the segmentation task

@chauhochow Sorry to bother you. But can anyone provide a sample code (hopefully minimalist) that can reproduce the "stuck"?

Hi @ShuLiu1993 @leafxx @chauhochow,
When I was debugging some codes of someone else, I realized that your code getting stuck is probably attributed to some control-flow in your implementation. Recall one of the keynote I wrote on the README file:
The implementation requires that each module on different devices should invoke the batchnorm for exactly SAME amount of times in each forward pass. For example, you can not only call batchnorm on GPU0 but not on GPU1. The #i (i = 1, 2, 3, ...) calls of the batchnorm on each device will be viewed as a whole and the statistics will be reduced. This is tricky but is a good way to handle PyTorch's dynamic computation graph. Although sounds complicated, this will usually not be the issue for most of the models.

In short, if you are running your code on 4 GPUs (for example), all 4 replicas of your model must call the batchnorm module in a synchronized manner. Otherwise, it's difficult to define what's "synchronization".
There are multiple kinds of usage may violate this rule. Example 1:
if some_condition_function(input):
    output = module_contains_batchnorm(input)
else:
    output = another_module_contains_batchnorm(input)

# this kind of conditions exists in some detection-related implementations.
if some_early_break_condition(input):
    return 0

output = module_contains_batchnorm(input)

# due to some "buggy" thing in old python versions (e.g., python 3.5),
# sometimes exceptions from child threads can not be thrown out.
# In such cases, some child threads may die due to some bugs in your code
# and the main thread will get stuck.
output = some_function_may_trigger_error(input)
output = module_contains_batchnorm(output)


[BUG] keeps crashing and saying error 403

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
System.Net.Http.HttpRequestException: Response status code does not indicate success: 403 (Forbidden).

Update to v2.6.1


Required variables must have an expression

A variable declared but empty (e.g., key (int);) in the parent must have an expression in the child.
Currently the following does not throw an exception.
parent.conf
%constrain ['child.conf'];
key;

child.conf
key;

This should throw an error, as key was required, and had no expression provided.

Maybe I don't necessarily need to? In this case, the compiled result would be:
declare -A _DATA_1=( [key]="" )

This may be a desired result, as there's currently no other way of setting an empty string.
Need to think more about it.

Constraints no longer exist.


OCIO fails parsing configs with non-C locale

When OCIO is run on a Ubuntu 12.04 machine with a German locale, parsing of srgb.spi1d fails and we get an "Invalid 'From' Tag" exception. The issue is sscanf() there is attempting to parse the string using the German locale.
This should be fixed inside OCIO, the external user should not have to mess with locales before using.
See this thread on ocio-dev for additional information:
http://groups.google.com/forum/?fromgroups=#!topic/ocio-dev/xH47bLSIgwE

This problem has also been reported several times in appleseed:
https://github.com/appleseedhq/appleseed/issues/2567

I just got bit by this when writing a plugin for 3ds Max that uses OCIO.
I can't believe this has been open since 2012.
Will this ever get fixed?

I went through this a year or two ago with OpenImageIO. I had to ruthlessly find all printf, scanf, and iostream stuff and replace it all with a new set of calls that I guarantee to be locale-independent.
It's not super hard and you are welcome to steal what you need from OIIO (I can point out what is necessary), but it can be an extensive undertaking.

An alternative to changing the calls is to fix the locale around the call. We fixed this specific OCIO issue on the host side by saving the thread locale, setting it to "C" locale, calling the OCIO function, and then restoring the locale. It's all wrapped in an auto-style C++ class, so it's one line of code in the places we needed it. Yes, I reported it at the time, but we needed a fix ASAP so that's how we did it.
I recall it was a beautiful looking bug -- if you were running French language OS, one of our color managed looks got all posterized. It turned out to be because the LUT read only got integers instead of floating-point numbers (because decimal separator in French is not "."), so the curve because stair-steps.

Oh we got that one at Duran Dubois when compiling Qt for Maya. All the
artists got Minecraft like assets as everything was rounded to next
integer. The panic it caused was unbelievable :)
On Wed, 26 Jun 2019, 06:19 Dithermaster<EMAIL_ADDRESS>wrote:

An alternative to changing the calls is to fix the locale around the call.
We fixed this specific OCIO issue on the host side by saving the thread
locale, setting it to "C" locale, calling the OCIO function, and then
restoring the locale. It's all wrapped in an auto-style C++ class, so it's
one line of code in the places we needed it. Yes, I reported it at the
time, but we needed a fix ASAP so that's how we did it.
I recall it was a beautiful looking bug -- if you were running French
language OS, one of our color managed looks got all posterized. It turned
out to be because the LUT read only got integers instead of floating-point
numbers (because decimal separator in French is not "."), so the curve
because stair-steps.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/imageworks/OpenColorIO/issues/297?email_source=notifications&email_token=AAAYLQYYIKCIDSYKN2LTAV3P4JOS3A5CNFSM4ACPFBWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYREMDI#issuecomment-505562637,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAYLQ4766A5RUADV2YUQQ3P4JOS3ANCNFSM4ACPFBWA
.

What bugs me is that I spent a long time trying to figure out what was wrong. But after I found out it was locale, the fix was easy in the host (3ds Max in this case).
Took me about 10 minutes to code it. But in case someone doesn't want to reinvent the wheel, here's what I did.
// OCIO has a , vs . bug depending on system locale
// https://github.com/imageworks/OpenColorIO/issues/297
const char* curlocale = strdup(setlocale(LC_NUMERIC, NULL));  // save current numeric locale
setlocale(LC_NUMERIC, "C");  // set numeric locale to C

// Put your affected OCIO code here
processor = config->getProcessor(transform);

setlocale(LC_NUMERIC, curlocale);  // restore numeric locale

It's a very manual approach but it was quick. So I would love to see how @Dithermaster solved it :)
Keep in mind I only override LC_NUMERIC. Maybe some other languages/locales need to override more.

Our solution was based on the same APIs, but wrapped in C++ and with Windows support:
class AutoSetAndRestoreThreadLocale
{
public:
    AutoSetAndRestoreThreadLocale();
    ~AutoSetAndRestoreThreadLocale();

private:
#ifndef _WIN32
    locale_t oldLocale;
    locale_t currentLocale;
#else
    SoStringA ssaLocale;
    int previousThreadConfig;
#endif
};

and
AutoSetAndRestoreThreadLocale::AutoSetAndRestoreThreadLocale()
{

#ifndef _WIN32
    // set to C locale, saving the old one (returned from useLocale)
    currentLocale = newlocale(LC_ALL_MASK,"C",NULL);
    oldLocale = uselocale(currentLocale);
#else
    // set locale will only change locale on the current thread
    previousThreadConfig = _configthreadlocale(_ENABLE_PER_THREAD_LOCALE);

    // get and store current locale
    ssaLocale.convert(setlocale(LC_ALL, NULL));

    // set to "C" locale
    setlocale(LC_ALL, "C");
#endif

}

AutoSetAndRestoreThreadLocale::~AutoSetAndRestoreThreadLocale()
{

#ifndef _WIN32
    // restore the previous locale and freeing the created locale
    uselocale(oldLocale);
    freelocale(currentLocale);
#else
    // thread specific
    setlocale(LC_ALL, ssaLocale.c_str());

    // set back to global settings]
    _configthreadlocale(previousThreadConfig);
#endif

}

Then in a block where you're making OCIO calls, have
   AutoSetAndRestoreThreadLocale locale;
When it hits that line it saves and sets the locale, then when the object destructs it restores the old locale.


COMP: Gcc13.2 compiler warnings

Fix compiler warnings issues with python building turned on.
PR Checklist

[x] No API changes were made (or the changes have been approved)
[x] No major design changes were made (or the changes have been approved)

I ran all 3 files through the clang-format-Darwin binary from the build tree, but there are no changes identified.
I don't know how to fix the CI errors that are posted.

@hjmjohnson please rebase for style fixes

/azp ITK.macOS.Arm64

todo: rebase on #4642 after merged.

@thewtex The failing test is unstable, and has nothing to do with the PR.
This test is unstable Failed
It seems like perhaps the CI does not have access to the file, or the file is corrupt.  I don't know how to proceed.

/azp ITK.macOS.Arm64

@hjmjohnson patch for the Nifti tests here: https://github.com/InsightSoftwareConsortium/ITK/pull/4659


Specify mounts

This branch (which is a continuation of integration-test) contains a fix for #45
I've:

Moved the secret file parser to it's own file.
Added integration tests
Changed the HTTP request code so it makes use of mounts
Changed the secret file format to support the following syntax:

VERSION 2

MOUNT secret
testing#key
testing#otherkey

MOUNT otherbackend
testing2#foo
testing2#bar

Some edge cases:

We can have MOUNT secret two times. Doesn't matter, we just combine everything.
Each instruction needs to be on a separate line.
If version 1 of the secret file is used, we don't take the mount paths into account when translating from path to the name of the environment variable. If version 2 is used, we do use this. This will mean old files will continue to work as expected, but users can also have foo secrets in two mountpoints with the same keys

This does not contain breaking changes, as the parser detects the version of the secret format and adjusts behavior accordingly.
TODO:

Docs (functions are done, README is left)
Be more lenient about whitespace
Test a bit further?
Release?

I've addressed your style suggestions. Will look into the parser and test comments later

👍

Could this be merged anytime soon? I need to specify my own mount.

I've been using the default mount /secret right now. I think I can wait until this gets merged. 👍

@rkrzr I improved the parser to be more lenient about whitespace. Could you have another look?
@mesaugat Thanks for the patience :)

Addressed your suggestions. Can you take another look @rkrzr?


Unable to mount volumes on Nginx container in docker 1.6

I'm running docker 1.6 on Centos 6 to run nginx. However, mounting a volume doesn't seem to working. Could someone help debug this?
I've used the following command:
docker run --name a2 -p 443:443 -v /etc/nginx/conf.d:/etc/nginx/conf.d -P -d nginx

I checked
docker ps

There were no containers running.
However, if I run,
docker run --name a1 -p 443:443 -P -d nginx

I'm using the older version of docker because current version ( docker 1.7 ) is not being supported in Centos /RHEL 6

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Can you check the logs from the failed container, and the daemon logs from when you created this container?

@sbose78 could you check the log files, as requested by @cpuguy83 ?

Closing as we need more info here.
If you can still repro and provide the requested info please ping here and we can take a look.
Thanks!


Switch to plugin system for pipeline action providers

Discussed in https://github.com/awslabs/pipeformer/pull/18 -- allow users to define their own custom providers to further simplify the config files that users actually have to write.

Potential resource for this: https://github.com/openstack/stevedore

Closing down project: #52


Bug? with cursor during execution

Godot version
v3.5.beta4.official [b6968ab06]
System information
win10 64
Issue description
When the script editor is activated and there is a run, the cursor is displayed in text edit even though it is outside the script field.
In this video you can see that although the cursor is over the execution buttons, it is shown editing text.
https://user-images.githubusercontent.com/19652075/164676021-1f66683d-f55a-4b6c-9f37-a349d3229547.mp4
Steps to reproduce
In the script editor.
Run the scene.
Before the execution window appears, move the cursor to the script editor so that the cursor changes to a text editing cursor.
The execution window will appear.
Now the cursor will stay with the text editing aspect.
You can see all this in the video.
Minimal reproduction project
...

In this video you can see that I run first and the cursor doesn't change because it doesn't go into the script editor before the run window appears.
Then I run again but this time it takes the cursor to the script editor before the run window appears and then the problem occurs.
https://user-images.githubusercontent.com/19652075/164754967-fe3f7d6c-dd7e-43df-88aa-1aa845167352.mp4


Integration Test - Release - 2020/08/10 22:09:24

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

NonAllowedUser is not a valid GitHub ID, or is not a collaborator on this repo.

#reassign PRMergerTest2

GitHub user PRMergerTest2 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

#reassign NonAllowedUser

NonAllowedUser is not a valid GitHub ID, or is not a collaborator on this repo.

#please-close


Add retries for rsync

Describe what this PR does
Adds retries for rsync (copied from volsync rsync mover)
Refactors script for readability
Is there anything that requires special attention?

Related issues:

/cc @JohnStrunk

/approve
/lgtm


pull request for e2e test at 02/06/2017 08:26:07

:x: Validation status: errors
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fixes compile error for rand() can't be overriden on Windows (benchmarking.c)

Fixes compile error for rand() can't be overriden on Windows (benchmarking.c)
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo<EMAIL_ADDRESS>

You don't want to do this. There is no point in guarding out the benchmarking.c. This file is used to create a stable version of the jerry executable (called jerry-test) that ensures that all test cases execute the same, even if they use time or rng-related functions. If you guard out this file, that means basically that you don't want to have a jerry variant useful for benchmarking. Then, simply don't build that executable (i.e., configure the build with JERRY_CMDLINE_TEST=OFF).

You don't want to do this. There is no point in guarding out the benchmarking.c. This file is used to create a stable version of the jerry executable (called jerry-test) that ensures that all test cases execute the same, even if they use time or rng-related functions. If you guard out this file, that means basically that you don't want to have a jerry variant useful for benchmarking. Then, simply don't build that executable (i.e., configure the build with JERRY_CMDLINE_TEST=OFF).


Pulling resources and getting "no children"

The game that I am scrapping is Albion Online. The scrapper worked great until Albion updated to a newer version of unity. Any help would be great!

Use: https://github.com/Perfare/UnityStudio

There's no exe for that download, just a bunch of loose files, what are we supposed to do with that?

@Geoffw2009 You obviously don't know how to use GitHub and/or compile source code. If you want to compile the source code use: https://github.com/Stellarspace/UnityStudio and https://github.com/Stellarspace/UnityStudio/wiki/Getting-Started If you want to download the latest build, use https://github.com/Perfare/UnityStudio/releases


problems with snabbdom version

An error raise up when I try to update the proyect to the last commit.
[error] npm ERR! code 1
[error] npm ERR! Command failed: /usr/bin/git checkout 464535d git://github.com/cornerman/snabbdom.git#bac3e6a
[error] npm ERR! error: ruta especificada '464535d git://github.com/cornerman/snabbdom.git#bac3e6a' no concordó con ningún archivo(s) conocido por git
[error] npm ERR!

the problems seems to appear in the presence of
"com.clovellytech" %%% "outwatch-router" % "0.0.6",
relate to two different versions

Thank you for opening the issue!
I have tried it out, and resolution is working with yarn, but not with npm. Can you try adding useYarn := true to the project in your build.sbt?
Anyhow I think, we should have a better versioning for the git-dependency of our snabbdom fork and use tags for our version. Also, we might want to apply semantic versioning with npm and git-dependencies (https://github.com/npm/npm/pull/15308#issuecomment-314263640).

sorry, I can't be able to solve the problem
is almost the same error
[info] Updating NPM dependencies
[error] npm ERR! code 1
[error] npm ERR! Command failed: git checkout bac3e6a git://github.com/cornerman/snabbdom.git#464535d
[error] npm ERR! error: ruta especificada 'bac3e6a git://github.com/cornerman/snabbdom.git#464535d' no concordó con ningún archivo(s) conocido por git

now is:
'bac3e6a git://github.com/cornerman/snabbdom.git#464535d'

before was:
464535d git://github.com/cornerman/snabbdom.git#bac3e6a

by the way, about this:
Can you try adding useYarn := true to the project in your build.sbt?
yes I tried, no success

I also tried installing snabbdom with npm install git

@elyphas I have added a commit to semantic versioning with the snabbdom git-dependency. Can you try depending on this outwatch version? "com.github.cornerman" % "outwatch" % "ee5804fc"

Sorry, now other error:
[error] npm ERR! Only tag, version, and range are supported
[error] npm ERR!  So you have proper links to the scala files on github when debugging.

@elyphas I have cloned your repository https://github.com/elyphas/manik and changed the outwatch dependency to the commit as well as setting useYarn := true. This fixed the problem for me. Did you try with yarn, too?

sorry, seems I have not proper setup I set useYarn:=true in one of the first lines, I have a clean virtual machine, without npm only yarn, and I have this problem:
[error] (client / Compile / npmUpdate) java.io.IOException: Cannot run program "npm" (in directory "/home/elyphas/PrjsScala/manik/clien: error=2, No existe el archivo o el directorio

the last error was solved throught npm install --global yarn

I am so sorry, the same error with yarn
[info] Updating NPM dependencies
[error] yarn install v1.15.2
[error] info No lockfile found.
[error] [1/4] Resolving packages...
[error] info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
[error] error Couldn't find match for "bac3e6a git://github.com/cornerman/snabbdom.git" in "refs/heads/check-parent-exists,refs/heads/check-parent-exists-dist,refs/heads/equalityfn-thunk,refs/heads/fix-elm-child,refs/heads/gh-pages,refs/heads/master,refs/heads/modular,refs/heads/multiple-event-handlers,refs/heads/new-thunk,refs/heads/next,refs/heads/next2,refs/heads/patch-under-container,refs/heads/replace-root,refs/heads/set-boolean-attributes-correctly,refs/heads/type-tweaks,refs/tags/0.7.3,refs/tags/v0.2.2,refs/tags/v0.2.3,refs/tags/v0.2.7,refs/tags/v0.2.8,refs/tags/v0.3.0,refs/tags/v0.3.1,refs/tags/v0.3.2,refs/tags/v0.3.3,refs/tags/v0.3.4,refs/tags/v0.4.0,refs/tags/v0.4.1,refs/tags/v0.4.2,refs/tags/v0.5.0,refs/tags/v0.5.1,refs/tags/v0.5.2,refs/tags/v0.5.3,refs/tags/v0.5.4,refs/tags/v0.6.0,refs/tags/v0.6.1,refs/tags/v0.6.2,refs/tags/v0.6.3,refs/tags/v0.6.4,refs/tags/v0.6.5,refs/tags/v0.6.6,refs/tags/v0.6.7,refs/tags/v0.6.8,refs/tags/v0.6.9,refs/tags/v0.7.0,refs/tags/v0.7.1,refs/tags/v0.7.2,refs/tags/v0.7.3" for "https://github.com/cornerman/snabbdom.git".
[error] java.lang.RuntimeException: Non-zero exit code: 1

[info] Updating NPM dependencies
[error] yarn install v1.15.2
[error] info No lockfile found.
[error] [1/4] Resolving packages...
[error] info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
[error] error Couldn't find match for "bac3e6a git://github.com/cornerman/snabbdom.git" in
"
refs/heads/check-parent-exists,
refs/heads/check-parent-exists-dist,
refs/heads/equalityfn-thunk,
refs/heads/fix-elm-child,
refs/heads/gh-pages,
refs/heads/master,
refs/heads/modular,
refs/heads/multiple-event-handlers,
refs/heads/new-thunk,
refs/heads/next,
refs/heads/next2,
refs/heads/patch-under-container,
refs/heads/replace-root,
refs/heads/set-boolean-attributes-correctly,
refs/heads/type-tweaks,
refs/tags/0.7.3,
refs/tags/v0.2.2,
refs/tags/v0.2.3,
refs/tags/v0.2.7,
refs/tags/v0.2.8,
refs/tags/v0.3.0,
refs/tags/v0.3.1,
refs/tags/v0.3.2,
refs/tags/v0.3.3,
refs/tags/v0.3.4,
refs/tags/v0.4.0,
refs/tags/v0.4.1,
refs/tags/v0.4.2,
refs/tags/v0.5.0,
refs/tags/v0.5.1,
refs/tags/v0.5.2,
refs/tags/v0.5.3,
refs/tags/v0.5.4,
refs/tags/v0.6.0,
refs/tags/v0.6.1,
refs/tags/v0.6.2,
refs/tags/v0.6.3,
refs/tags/v0.6.4,
refs/tags/v0.6.5,
refs/tags/v0.6.6,
refs/tags/v0.6.7,
refs/tags/v0.6.8,
refs/tags/v0.6.9,
refs/tags/v0.7.0,
refs/tags/v0.7.1,
refs/tags/v0.7.2,
refs/tags/v0.7.3" for "https://github.com/cornerman/snabbdom.git".
[error] java.lang.RuntimeException: Non-zero exit code: 1

Hmm, that is weird. I have forked your repo here https://github.com/cornerman/manik and added a commit to update outwatch. Without this commit, I get the same error that you are seeing. But with the commit, it works for me. Not sure, what might be different from your setup.
The steps I am doing:
git clean -xfd
sbt client/fastOptJS::webpack

Does that work for you?

BTW which version of yarn and npm are you running?
I am using:
$ npm -v
6.9.0
$ yarn -v
1.15.2

npm -v
6.9.0
elyphas@projs1:~$ yarn -v
1.15.2
elyphas@projs1:~$

I have forked your repo here https://github.com/cornerman/manik and added a commit to update outwatch.

@elyphas Were you able to reproduce the problem in that repo?

the same exact problem. I have

it is compiled

I was running this way:
sbt ~server/run
where server is a subproject in sbt
and leaving all it has to do to sbt,
seems it is mandatory to run sbt client/fastOptJS::webpack  first, although now I have trouble with the server subproject but at least now is more clear the path to take,
Thank you very much. @cornerman

Good to hear that it starts working again.
Though, I am not sure about the reason for the server project problem. I have tried server/run and for me it just calls client/fastOptJs::webpack itself and happily compiles. Maybe you needed a sbt clean?

yes it works,
I was running sbt ~server/run, not works
with sbt server/run it works

by the way I had to state in certain order:
is mandatory this order:
1.-   "com.github.cornerman" % "outwatch" % "bb2dbc58",
2.-   "com.clovellytech" %%% "outwatch-router" % "0.0.6",

without that order the error appears

by the way I had to state in certain order:

Good point! Afaik, this will go away in the future when conflicting version both use semantic versioning. Right now, the latter one does not and somehow needs this order.

I was running sbt ~server/run, not works

Sadly, I cannot reproduce this. Let me know how it goes.

ok, I will,
thank you very much.

@elyphas I have merged the snabbdom versioning PR and therefore closed this issue. If you keep on having issues, please feel free to reopen this issue!


x/tools/internal/lsp: gopls breaks with C dependencies

Gopls (on vscode) fails to compile and autocomplete when using gocv.io/x/gocv as a dependency in your program.
To reproduce:

Follow the installation instructions here: https://gocv.io/getting-started/macos/
Create a Go program outside GOPATH with a go.mod file
Paste the following into main.go:

package main

import (
	"gocv.io/x/gocv"
)

func main() {
	webcam, _ := gocv.VideoCaptureDevice(0)
	window := gocv.NewWindow("Hello")
	img := gocv.NewMat()

	for {
		webcam.Read(&img)
		window.IMShow(img)
		window.WaitKey(1)
	}
}

From a terminal: run go run main.go and notice that it works by opening your camera.
However, notice that in VSCode, Gopls is unable to find any of the functions in this file:

Gopls version:
commit aa71c3f32488bfee7774668abdf1ae045e013079 (HEAD -> master, origin/master, origin/HEAD)
Author: Rebecca Stambler<EMAIL_ADDRESS>Date:   Tue May 28 18:13:06 2019 -0400

    internal/lsp: set env to os.Environ to start

duplicate of https://github.com/golang/go/issues/31561
will re open if 31561 is solved and this is still an issue.


Add actions support to global search results

Add support to include actions to global search result.
This actions are simple button or link which may open a URL or emit a Livewire event, like the ones on notifications.

@zepfietje Perhaps the best would be to allow the implementation of a custom GlobalSearchProvider where we can define a new class/view of GlobalSearchResult.
That way you are free to customize how the results would be presented.

What exactly would you like to customize?
If there's missing CSS classes to hook into, we could just add those.
I'm not sure if we really need the ability to customize the entire view.

What exactly would you like to customize?
nothing, just thinking about other possibilities.

Ah alright, let's keep things as simple as possible.
Also, just curious about what you would use global search results actions for, @dmandrade? 😄

to display shortcuts for some actions like exporting csv/pdf, copy to clipboard, and links to resource pages.
Ex:

an action to copy the task id in a project management system
action to preview blog posts in a cms
action to see all tickets/or the latest one for a client in a helpdesk system

@dmandrade is this PR ready for proper review? If so, you can mark it as "Ready for review" and we'll have a look!

Thanks

Thanks a lot for that feature. In special thanks for giving us that IDEA for that feature :).
I am adopting this in one of our projects now which will save us a lot of time !!!


Fix #9956 - Add support for private and protected methods in DbFunctions

Resolves #9956
Adds support for private, protected, internal, and protected internal

@pmiddleton - If you get some time then can you rebase this on latest dev?

Merged via 843929da0c1bc90813178e8fa16edf9dbbeb58df
Thanks for contribution.


Difference between the pan-cancer cnv signatures provided by the paper and those provided in the github data

Hello! Sorry for interruption but I got a problem when using SigProfilerAssignment. The aim to use SigProfilerAssignment is to define the CNV signatures of 100 different samples according to the impressing article (https://www.nature.com/articles/s41586-022-04738-6#Sec11). But I got 3 questions when I was using SigProfilerAssignment and SigProfilerExtractor.

What the differences between the pancancer signatures provided in the supplementary table 2 which contains 24 CN signatures and the one provided in the github data which contains 19 signatures? As the CN signature I concerned is different in the two files.
I have known that SigProfilerExtractor is used to de novo generate CN signatures and  SigProfilerAssignment is mainly used for refitting to the known signatures such as those mentioned in question 1. I'm wondering if it is possible for me to use SigProfilerExtractor first to generate de novo signatures, then compare them with the known ones. Does there exist a possible way to achieve the comparison?
As I cheked the 24 CN signatures, I noticed on cosmic CN signatures download page it's said those signatures were derived from GRCh37,  but the reference genome I have used was GRCh38, would it effect the results?
Thanks. Looking forward to the reply.

Hi @DingTin,

I want to point you to the correct file for the CN reference signatures. I figure you were looking at this file, which is a dated file that looks to no longer be used.

@marcos-diazg could you please comment on 2 & 3?
Thanks!

Hi @DingTin and thanks @mdbarnesUCSD,

Indeed, SigProfilerExtractor will automatically do the comparison with the known COSMIC CN signatures for you.
As mentioned at https://cancer.sanger.ac.uk/signatures/downloads/, no renormalization is available for CN signatures so you can use the reference COSMIC CN signatures independently of your reference genome.

Thanks for your interest, and please feel free to reopen the ticket if you have any additional questions.


Refactorized code

Simple optimization for a cleaner code, using lambda expressions.

We always use braces round if statements, even for single statements - ditto for loops etc. The code in SubscriberClient is all autogenerated.
While I'm fine to use expression-bodied members, I wouldn't suggest creating PRs just to change to using them. (It's not like they're actually faster or anything.)
Thanks for your time, but I'm afraid we won't be merging this PR.


Support a danger local command

Re: https://github.com/KrauseFx/danger/issues/17
So far I've added another commands danger local and set it up to use a non-existent  CI Source, the source's job is going to be to find the last PR it can find in the current history of the current repo, then fill in it's environment variables with that stuff.

Now grabs enough git data :tada:

Looks good, however HoundCI doesn't seem so happy

also, if you have a better idea for the name, I'd be interested

OK, I've removed match, and fui - it wasn't being used.
I've also updated Danger to this PR https://github.com/KrauseFx/danger/pull/40/ - which makes --verbose work - should make debugging DM easier for me.

Punted the tables stuff to https://github.com/danger/danger/issues/62


chore: delete owlbot.py

Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.

Blocked by https://github.com/googleapis/gapic-generator-python/issues/1035

This is ready for review


Settings page tab order

Put the cursor in the text box for Name, and press TAB several times.  You will see focus go:

Name
Value
Help text
Type

We should either prevent focus from going to help text, or swap 3 & 4 order.

https://github.com/Microsoft/RTVS/commit/15b3daef67a9e6af9066230afe4a057c7c3a7739


A flow to create individual tokens to access the API

Right now anyone can access the DB through the API. It would be better for security if we required people to create a token to access it, and that can then be revoked on an individual basis. This way we can keep it open but if there are bad actors/someone DDOSing the DB we can revoke it/turn off creation of new tokens etc.
The data on object storage can still be publicly available.

Possible implementation:

When you login with twitter, you see a token generated for you (stored in the DB?)
Use JWT for this? https://supabase.com/docs/guides/auth/jwts
how does revoking work? just go in the supabase dashboard and edit the DB? Or make this "user directory" view have an extra button if the logged in user is @TheExGenesis ? https://www.community-archive.org/user-dir

Given the current stage of development CA is at right now, it might even be smart to have a waitlist for access and issue tokens manually.


[8.0.0] Digital miner is broken when applying upgrades

Digital miner is broken. Seems to be related to speed upgrades, but when no speed upgrades is applied it mines a whole stack in seconds.
So think something broke during the new v8's upgrade module handling.
UPDATE:
Done some more debugging now. Seems that it also get messed up and unable to mine blocks when applied upgrades to and when it's breaked and replaced out in world. Maybe some NBT data getting corrupted?
When replaced into world it often mines 1 block then stops mining.

Yes, fixed.  I had two goofs in my new filter code.  Expect a commit soon!

Nice.


Add new CRD TemporalWorker to manage worker fleets

It would be great to have a CRD endpoint to manage workers. The temporal-operator could then be used not only by those self-hosting but also to help scale and manage workers which would likely be controlled by another group (developers instead of platform engineers).
Initial ideas:

CR should control worker farm for a given app/workflow
CR should allow setting resource limits
CR should support worker mtls and handling cert bootstrap
CR should allow image to be selected
CR should perform upgrade strategy if the image is changed

Nice to have:

CR to support autoscaling
CR to support SDK metrics metering
CR to support CI through tekton or something else

@alexandrevilain definitely looking for your feedback on this

Hi @ktenzer
What a great idea! I think it could become a killer feature for our users! Thanks for this proposition!
At first glance, I see few things we should care about before starting the development:

The naming. I often see confusion between the Worker service which is part of the temporal cluster and workers the user should implement. So we have to take care about naming and documentation.
The "locking". As we're taking opinion in the way of deploying worker, we should ensure that users will not have to do some big code changes to start using this CRD to deploy their workers. We will probably have to support volumes mounts, env variable or even sidecar injection to provide endpoint, credentials, certificates to the worker.
We have to still care about "classic" worker deployment. And if the user wants mTLS he should be able to use the TemporalClusterClient to retrieve its mTLS credentials.

WDYT ?

Hi @ktenzer
What a great idea! I think it could become a killer feature for our users! Thanks for this proposition!
At first glance, I see few things we should care about before starting the development:

The naming. I often see confusion between the Worker service which is part of the temporal cluster and workers the user should implement. So we have to take care about naming and documentation.
The "locking". As we're taking opinion in the way of deploying worker, we should ensure that users will not have to do some big code changes to start using this CRD to deploy their workers. We will probably have to support volumes mounts, env variable or even sidecar injection to provide endpoint, credentials, certificates to the worker.
We have to still care about "classic" worker deployment. And if the user wants mTLS he should be able to use the TemporalClusterClient to retrieve its mTLS credentials.

WDYT ?

I will add these points to requirements above.
Agree naming convention is critical. In the end the worker deployed w/temporal server is just another worker but it is used for orchestrating internal activities of Temporal.
Initially I would propose we simply deploy an image provided by the developer but I think we should eventually add volume mounts and injection. For v1 idea would be developer CI/CD produces container image as artifact and this would then be consumed by CR. Eventually though as you mentioned it would be really nice to inject code via mount or maybe sidecar.
Regarding mTLS yes this would be something we need to enable in v1 so that a worker can leverage the ClusterClient. Probably we can just create that CR but user would have to grab those certs from pre-defined ENV vars available to worker but I assume that should all work with what we have today.

Hi !
As seen with you, first iteration for this feature will ship with release 0.8.0.
I purpose to keep this issue open for incoming features:

default builder using kaniko
builder jobs customization options
autoscaling

Closing in favor of: https://github.com/alexandrevilain/temporal-operator/issues/205


[NoQA] fix: e2e long loading

Details
Fixed a problem where third test (chat opening) fails due to timeout.
Basically the problem happens because before that test we are running app 60 * 2 times. Each time we are sending ReconnectApp request. Typical time to finish that request is 2.5-5 seconds. But sometimes our test execution gets finished faster and we don't receive a response (please note, that we store this request in a persisted queue, so if we didn't receive a response -> we store it in storage and we will re-execute this query on the next app run).
When we run a third test - we have a condition to show skeleton if we have active network requests. Since we need to execute ~100 network request, with average duration 4s -> we have to spend 400 seconds just to wait for a screen to appear. Of course 400s > 300s (our timeout for test), so test gets failed because of a timeout.
To fix this error I had several ways:

terminate app only when SequentialQueue is empty;
re-install app for each test suite.

Initially I thought that first approach is good enough, but a little bit later I realized that:

it requires client code changes, so actual fix will work after a new release;
we fix only a particular case;
tests are still not independent (they must be run in certain order);
we add client code that will emit events when queue is empty, but this code is needed only for e2e tests (not for an actual app);

So in the end I decided to go in a slightly different direction - instead of terminating app when queue is empty we can simply reinstall the app (and queue will be cleared automatically).
However new approach requires to make a warmup two times (requiresDoubleWarmup) - before we performed login in first test, and a warmup for other tests actually executed the flow. After app re-installation we execute login only (first time) and the second time actual flow.
Also I discovered that if we run local dev test, then compare will be undefined -> in this PR I fixed this problem by assigning compare=baseline in case if compare is missing.
Fixed Issues

$ https://github.com/Expensify/App/issues/42987 https://github.com/Expensify/App/issues/42163
PROPOSAL: N/A
Tests

[ ] run e2e pipeline from this PR and it should be green;

Offline tests

QA Steps

Not needed.
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[Wallet] CELO activity disappears after confirmed

Expected Behavior
Past CELO purchases appear in CELO activity feed after they are confirmed
Current Behavior
Past CELO purchases appear in CELO activity feed only while confirming, but disappear once confirmed

@annakaz  Verified with latest build Valora Mainnet build v1.0.0 (11) and found that issue is still reproduced.

CELO activity disappears after confirmed
Verified device : Google Pixel XL(8.1) | Vivo 1606 (6.0.1)


update license to licenseKey

BREAKING CHANGE: Updates the option license to licenseKey, in order
to be consistent with the other options, which already match the name
in the New Relic JS snippet.
This is to address https://github.com/victorrodrigues/html-webpack-new-relic-plugin/issues/7

@victorrodrigues: This is ready when you get the chance to review. Thank you.


sdist-ghc builds more than necessarys

In the make-based build system make sdist finishes in around two minutes on my machine, with most of the time being spent compressing the final source tarball. Afterall, all it does is copy the source files into sdistprep.
However, Hadrian seems to want to build a stage1 compiler as well.

I've just tried this on Windows.
The sdist-ghc rule runs the boot and configure scripts and than copies the file, painfully reporting about each one on the screen. Then it does the archiving.
I don't think it builds stage1 compiler or anything else, the only problem is excessive amount of output information. This should be easy to fix.

With --progress-info=none the rule runs slightly faster (5:08m compared to 6:41m), but it's still rather slow.
Could the reason be file-by-file copying?
https://github.com/snowleopard/hadrian/blob/master/src/Util.hs#L144-L150

I don't think it builds stage1 compiler or anything else, the only problem is excessive amount of output information. This should be easy to fix.

Hmm, that isn't what I observed but perhaps I'm doing something wrong. I definitely saw it build some compiler objects.

With --progress-info=none the rule runs slightly faster (5:08m compared to 6:41m), but it's still rather slow.
Indeed I also had noticed that the copying itself was quite slow. At one point I eyeballed the copy rate at something like 30 files per second, which is significantly slower than I would expect. I'll try to look into why this may be.

So one thing that I've noticed is that Hadrian is remarkably rough on the GC. Productivity with -j4 typically hovers slightly lower than 50%. I suspect most of this time is spent trying to synchronize with threads in foreign calls.

It sounds like this may be due to #384. Indeed I was unable to reproduce this with a clean tree.


We do not have loss operators in CPP?

I can't find the loss operators in CPP codes, this makes it hard to control the backward process (in c/cpp).
Also, the trainning process seems to be sealed inside the python object mxnet.model.
All the above mean it is not easy to control the training process. For example, is it easy to give different learning rates to different layers?
so...I don't feel that a good practice.
Correct me if I missunderstood anything.

Seems the softmax-output operator is just the loss operator.
I will close this issue.


JEI incorrectly shows raw redstone ore as millable

JEI shows the raw redstone ore as millable by the small millstone, but it isn't.

Reproduction Steps

Place a small millstone and power it
Throw a raw redstone ore in it
Wait a minute
Right click the millstone and you get the raw redstone ore back

Expected behaviour

Either get redstone dust
Or not having the JEI recipe show up

Versions

createoreexcavation-fabric-1.20-1.4.3 (also reproducible on 1.4.0, didn't test older versions)

Create fabric bug.
Please report it to create-fabric.
Milling recipes break if an item can be processed in a millstone and crushing wheel. (The built in wool to string recipe is also broken).

Done:

https://github.com/Fabricators-of-Create/Create/issues/1398

The redstone milling recipe is missing it's duration so it doesn't work, but can be inserted into the millstone.
On Create Fabric this locks up the millstone after removing the item and it won't accept any items until break and replace (works correctly on Forge).
I'm releasing a patch to fix the missing duration.

so this isn't a Create issue?