Gibberish generated with deepseek-ai/deepseek-coder-6.7b-base

System Info
TGI Version: Tried  2.0.3, 2.0.4, 2.1.1 all does not work but 2.0.2 works
Information

[X] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction
def main():
    client = Client(base_url="http://<IP_ADDRESS>:8080")
    response = client.generate(
        prompt="def hel",
    )
    print(response.generated_text)

if __name__ == "__main__":
    main()

outputs
metryryryryryryryryryryryryryryryryryryry

Expected behavior
should be helloworld or something make more sense

find similar issue here https://github.com/huggingface/text-generation-inference/issues/1957 and it looks like versions after 2.0.2 is not working. I tried all versions after 2.0.2, all fails

Hi!
Thanks for reporting the issue 👍 could you share a bit on how to reproduce this?
E.g. which model are you using, what's the command to launch the docker container?

Hi @ErikKaum,
Thanks for responding. The model is
deepseek-ai/deepseek-coder-6.7b-base

and you can use the official docker container command to reproduce this
docker run --gpus all --shm-size 1g -p 8080:80 -v $volume:/data \
    ghcr.io/huggingface/text-generation-inference:2.1.1 --model-id $model

Thank you.
Yeah, I'm able to reproduce this on my machine. Also quickly checking seems that deepseek-ai/deepseek-coder-6.7b-base  is working with the transformers library. So most likely a bug in our end.
At the moment, I unfortunately don't have bandwidth to start debugging.
I'm seeing a lot of warnings like this:
2024-07-16T15:00:17.309591Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token 'õ' was expected to have ID '32000' but was given ID 'None'
2024-07-16T15:00:17.309615Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token '÷' was expected to have ID '32001' but was given ID 'None'
2024-07-16T15:00:17.309618Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token 'Á' was expected to have ID '32002' but was given ID 'None'
2024-07-16T15:00:17.309621Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token 'ý' was expected to have ID '32003' but was given ID 'None'
2024-07-16T15:00:17.309624Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token 'À' was expected to have ID '32004' but was given ID 'None'
2024-07-16T15:00:17.309626Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token 'ÿ' was expected to have ID '32005' but was given ID 'None'
2024-07-16T15:00:17.309629Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token 'ø' was expected to have ID '32006' but was given ID 'None'
2024-07-16T15:00:17.309631Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token 'ú' was expected to have ID '32007' but was given ID 'None'
2024-07-16T15:00:17.309641Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token 'þ' was expected to have ID '32008' but was given ID 'None'
2024-07-16T15:00:17.309643Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token 'ü' was expected to have ID '32009' but was given ID 'None'
2024-07-16T15:00:17.309646Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token 'ù' was expected to have ID '32010' but was given ID 'None'
2024-07-16T15:00:17.309648Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token 'ö' was expected to have ID '32011' but was given ID 'None'
2024-07-16T15:00:17.309651Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token 'û' was expected to have ID '32012' but was given ID 'None'
2024-07-16T15:00:17.309653Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token '<｜begin▁of▁sentence｜>' was expected to have ID '32013' but was given ID 'None'
2024-07-16T15:00:17.309656Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token '<｜end▁of▁sentence｜>' was expected to have ID '32014' but was given ID 'None'
2024-07-16T15:00:17.309658Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token '<｜fim▁hole｜>' was expected to have ID '32015' but was given ID 'None'
2024-07-16T15:00:17.309661Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token '<｜fim▁begin｜>' was expected to have ID '32016' but was given ID 'None'
2024-07-16T15:00:17.309664Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token '<｜fim▁end｜>' was expected to have ID '32017' but was given ID 'None'
2024-07-16T15:00:17.309666Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token '<pad>' was expected to have ID '32018' but was given ID 'None'
2024-07-16T15:00:17.309669Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token '<|User|>' was expected to have ID '32019' but was given ID 'None'
2024-07-16T15:00:17.309672Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token '<|Assistant|>' was expected to have ID '32020' but was given ID 'None'
2024-07-16T15:00:17.309674Z  WARN tokenizers::tokenizer::serialization: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokenizers-0.19.1/src/tokenizer/serialization.rs:159: Warning: Token '<|EOT|>' was expected to have ID '32021' but was given ID 'None'
2024-07-16T15:00:17.310063Z  INFO text_generation_router: router/src/main.rs:330: Overriding LlamaTokenizer with TemplateProcessing to follow python override defined in https://github.com/huggingface/transformers/blob/4aa17d00690b7f82c95bb2949ea57e22c35b4336/src/transformers/models/llama/tokenization_llama_fast.py#L203-L205

which makes me think it might be a tokenization issue.

How to fix this?


Adds remark.

This is the remark.

Codecov Report

Merging #11 (ca8b281) into master (0e65afd) will decrease coverage by 1.76%.
The diff coverage is 39.34%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e65afd...ca8b281. Read the comment docs.


No JSON Data

When double clicking the StartIMProxy.command, the server starts up as expected and I can connect to it in AndromedaB, but no JSON is displayed in the server console and AndromedaB complains that no JSON data is available.
I'm using a 2011 Mac Air on Sierra and Galaxy S7 running the latest Android OS with the latest OSXMessageProxy and AndromedaB installations.

Do you get nothing at all in the logs? When you say the app connects do you mean you see the banner pop up that says connected or whatever? It could be that your message database can't be read for whatever reason

When I click the startup script, I get this in the console and nothing else.
jordan:~ Jordan$ /Users/Jordan/Desktop/MessageProxy/StartIMProxy.command ; exit;

To summarize, after playing around with it for quite awhile:

I run the StartIMProxy.command by double clicking.
It makes a log folder, logs "Starting Server at ____" and displays nothing in the terminal.
OSXMessageProxy opens and says "Ready at _____".
I connect to the server from my Android and a banner shows up that says Connected.
A few seconds later, a banner appears on my Android that says "Unable to load conversationJSONDatab..s" (can't see the full banner on my phone).

If I browse to my.domain:8735/conversations?t=password, I can see a bunch of message JSON data so it's being loaded... Perhaps it's crashing because my contacts have emojis in their name?

This is actually an issue with AndromedaB. It is simply timing out before it receives the list of conversations (I have a lot. Like, 194000). Fixed by the addition of
stringRequester.setRetryPolicy(new DefaultRetryPolicy(500000,                 DefaultRetryPolicy.DEFAULT_MAX_RETRIES,                 DefaultRetryPolicy.DEFAULT_BACKOFF_MULT));
to line 45 of RemoteMessagesInterface#getConversations()

Yeah I'm going to say "wont-fix" to that issue haha. Guess I'm not popular enough to need that? I'd look at getting rid of some conversations because the conversation list is sent on every new message as needed which would mean a ton of useless data is sent if you have 194k conversations. I should limit it though to maybe only returning the 50 most recent conversations.

Ahaha yeah good plan. I've been working on some mods in an offline copy of Andromeda... I've got a compose message setup (had to add a /contacts command to the server to simplify) running and I weeded off any big conversations.
Something else I've come across is that the JSON (and therefore andromeda) will distinguish between one contact with two contact options (ie. email and phone) where iMessage will condense them into one conversation. This causes an issue to arise in some compositions.
I'll probably fork your repo and submit some PRs when I have reliable and tidy changes. Great project!
Sent from my iPhone

On Jun 21, 2017, at 4:27 PM, Salman Husain<EMAIL_ADDRESS>wrote:
Yeah I'm going to say "wont-fix" to that issue haha. Guess I'm not popular enough to need that? I'd look at getting rid of some conversations because the conversation list is sent on every new message as needed which would mean a ton of useless data is sent if you have 194k conversations. I should limit it though to maybe only returning the 50 most recent conversations.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.


no devices after Update to 0.25

no devices are displaying anymore after installing update to 0.25. (Eufy Base and Doorbell in my case)
Switch back to 0.24 solves the problem.

Thanks for or working on this project, much appreciated.
I have experienced the same issue. In my case it was Base Station and all attached devices. 2 x Motion sensors and 8 x contact sensors. Motion sensors do not update in HomeKit their status, whereas contact sensors do and are immediate.

I have rolled back this latest version until we can figure out how to fix some of these issues.


Check formatter stability on CI

I don't think we should use a dedicated job for this and i think this
needs some integration with the ecosystem scripts, this PR is just a
first step to get CI passing on this in principle

Current dependencies on/for this PR:

main

PR #5415

PR #5446   👈

This comment was auto-generated by Graphite.


[Bug Report] Found build error when using vuepress, at version：^v2.8.0

Element UI version
2.8.0
OS/Browsers version
Mac/nodeJS
Vue version
2.6.10
Reproduction Link
https://github.com/ElemeFE/element/issues/new
Steps to reproduce

upgrade ElementUI version to 2.8.0  (lower version have no this bug).

then import ElementUI to enhanceApp.js.

import 'element-ui/lib/theme-chalk/index.css';
import ElementUI from 'element-ui';

export default ({Vue}) => {
  Vue.use(ElementUI)
}

run : vuepress build

found error:

ReferenceError: HTMLElement is not defined

What is Expected?
no error
What is actually happening?
has error

同样的问题


oecore: Use CMakeLists to build libunwind

Currently libunwind building is very complex

It uses an external project that runs configure, make etc.
We do a bit of code transformation on the fly so that we can take control of unwinding (rewrite Gtrace.c, GStep.c) etc.

We need to rewrite libunwind building to use CMakeLists so that it builds seamlessly on Linux and Windows.
CC: @andschwa @mikbras

I believe I actually have your changes integrated... but they come with some other changes I am still reconciling. Making good progress though!

For some reason this wasn't automatic. Resolve dby #1154.


how to connect to clickhouse with password?

Where to set the username and password param when connect to my clickhouse ?

I've added two properties for SparkConf: 'spark.clickhouse.user' and 'spark.clickhouse.password'.


Product not available/ iap not defined

Plugin shows up in list but isn't available to install and shows a error.

Have you purchased this plugin?

Have you installed acode from Google Play, F-Droid, or Telegram? If so, then what version and version code?

Have you purchased this plugin?

No .

Have you installed acode from Google Play, F-Droid, or Telegram? If so, then what version and version code?

F droid

Have you purchased this plugin?

No . This is just a example. There is other plugins like moonlight theme. I don't think it is paid

I thought this is not available in your country because these are paid plugins

Have you purchased this plugin?

No . This is just a example. There is other plugins like moonlight theme. I don't think it is paid

I thought this is not available in your country because these are paid plugins

Even the moonlight one .

Yes Moonlight is also paid , you can check here

Yes Moonlight is also paid , you can check here

Well,no need to keep the issue then.
Thanks for helping.

Thanks for helping. Just one thing, if you can make it so that it says it's paid instead of giving an error.

Thanks for helping. Just one thing, if you can make it so that it says it's paid instead of giving an error.

Hmm,
As Acode uses Google SDK for payment and in some country it gives error (or not available)


upgrade stack.yaml dependencies

Issue Number

Overview

[ ] I have upgraded stack.yaml dependencies

Comments

bors r+


Kwxm/conformance/more polymorphism tests

This is a follow-up to #5658 , making some conformance test inputs a little more polymorphic.  I also noticed that the inputs for the various chooseData* tests used the wrong concrete syntax, so I fixed that (we should remember to fix that in the specification too: it was quite difficult to work out what the syntax is).
To test that some builtin arguments are #-polymorphic but not *-polymorphic, we'd need an input like (con list ??? [(lam x x)]), where ??? is some type.  However, all you can put in there are the names of builtin types, so we can't actually write a built-in list that contains a term:  such a thing is in fact rejected by the parser because it knows what type of constant it's expecting inside the list and uses the type-specific parser for that.  If we really want such a test we'd have to try constructing the AST directly, but I don't think the builtin machinery will even let you do that.  So I don't think we can write failing tests of the sort we thought we should have.

BTW, the concrete syntax of builtins was specified (I remember I had to decide on that).
There is a message on the Plutus mailing list and a comment on a relevant PR.


Hydration text content mismatch with Inertia SSR

I am struggling with using inertia SSR with localization, where I get a Hydration text content mismatch on warning.
As an example I set up a quick test project, with Home.vue looking like this:

<template>

{{ trans('test.hello') }}

</template>

Then for brevity, I added this to my default inertia app.js :
import { i18nVue } from 'laravel-vue-i18n'

createInertiaApp({
  ...
  },
  setup({ el, App, props, plugin }) {
    ...
    .use(i18nVue, {
      resolve: async lang => {
        const langs = import.meta.glob('../../lang/*.json');
        return await langs[`../../lang/${lang}.json`]();
      }
    })
    .mount(el)
  },
})

And this to my ssr.js:
import { i18nVue } from 'laravel-vue-i18n'

createServer(page =>
  createInertiaApp({
    ...
    },
    setup({ App, props, plugin }) {
      const lang = process.env.VITE_APP_LOCALE || 'en';
      return createSSRApp({
        render: () => h(App, props),
      }).use(plugin)
      .use(i18nVue, {
        lang: lang,
        resolve: lang => {
          const langs = import.meta.glob('../../lang/*.json', { eager: true });
          return langs[`../../lang/${lang}.json`].default;
        },
      })
    },
  }),
)

When I load my Home.vue page, I get this warning and error in the browser console:
[Vue warn]: Hydration text content mismatch on
Hello in english

  - rendered on server: Hello in english
  - expected on client: test.hello
 ...

Hydration completed but contains mismatches.
setup    @    app.js:25
Promise.then (async)
(anonymous)    @    app.js:10
Show 5 more frames

So it seems like the client isn't hydrating the frontend with the translation on page load, which causes this mismatch. Is this something I should just ignore, or is there a way that I can fix this?

I ran into this issue recently, paired with the translation keys flashing up on the screen during development, when the SSR was turned off.
Turns out the fix is fairly easy. You just mount the Vue app after the translation files got loaded, like in https://github.com/xiCO2k/laravel-vue-i18n/issues/117#issuecomment-1627295319.

Thanks @andreiio


broken link on makecode.com "csintro/about" page, "Unplugged: Events and Handlers"

Describe the bug
Broken link on csintro web page.
To Reproduce
Steps to reproduce the behavior:

Go to https://minecraft.makecode.com/courses/csintro/about
Scroll down to '2. Events and Event-Driven Programming.'
Click on 'Unplugged: Events and Handlers'
Page returned says "Sorry, the page is missing"

Expected behavior
The tutorial page for Events and Handlers should appear.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser Chrome Version 69.0.3497.100 (Official Build) (64-bit)

Retiring this as it seems that the material for the course has moved elsewhere.

This is a valid issue, we should revise our links in the about page, good catch and thanks for reporting

@ganicke could you please take a look at those links when you get the chance?

Should be fixed, thanks @ganicke and @geomacy


WIP: [python-package] remove unnecessary layer of try-catching in conditional imports

Optional dependencies in this project are handled via a pattern like this in compat.py:
try:
    from sklearn.preprocessing import LabelEncoder
    # ... many more ...
    SKLEARN_INSTALLED = True
except ImportError:
    LabelEncoder = None
    SKLEARN_INSTALLED = False

That ensures that importing from lightgbm and lightgbm.sklearn still works even in environments where scikit-learn is not installed.
Given this protection, this additional layer of try-catching in the top-level __init__.py is unnecessary:
https://github.com/microsoft/LightGBM/blob/53e0ddf7cd6eb281e3bec6273b19ff541c69bfa6/python-package/lightgbm/__init__.py#L15-L19
This proposes removing it, for the following reasons:

simplifies the code
makes debugging other import issues easier (see "Notes for Reviewers")
maybe speeds up imports a tiny bit? (I'm not sure)

Notes for Reviewers
The try-catches removed in this PR have been in lightgbm for 8+ years, since #97
How I tested this
Installed the library.
cmake -B build -S .
cmake --build build --target _lightgbm -j4
sh build-python.sh install --precompile

Tried importing uninstalling scikit-learn and them importing LGBMClassifier.
pip uninstall --yes scikit-learn scipy
python -c "from lightgbm import LGBMClassifier"

After thinking about it a bit, I decided against this... I think it's useful to have e.g. train(), Booster(), cv(), etc. still be importable even if some import error does slip into sklearn.py, like if for some reason inspect.signature was removed from the standard lib:
https://github.com/microsoft/LightGBM/blob/53e0ddf7cd6eb281e3bec6273b19ff541c69bfa6/python-package/lightgbm/sklearn.py#L5
Sorry for the noise.


npmignore dir

Prerequisites

[x] Plugin is in the latest version
[ ] Issue was not reported yet
[ ] Stack trace (if provided) contains mobi.hsz.idea.gitignore package name

Description
when we add folder by menu
it add
/screenshots/

this will not ignore /screenshots/ when npm publish
only
/screenshots

or
screenshots

Expected behavior: What you expect to happen
should not publish screenshots folder
Actual behavior: What actually happens
screenshots folder got publish
Reproduces how often: What percentage of the time does it reproduce?
Versions
Plugin:
Can be found in Settings > Plugins > .ignore

IDE:
Can be found in Help > About. Click on the copy icon on the left.

OS:
Information about operation system - type, version.

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

When adding /screenshots/ to the .npmignore,, screenshots directory located in the root of the project will not be published.
I couldn't reproduce your issue:
$ npm pack
npm notice
npm notice 📦<EMAIL_ADDRESS>npm notice === Tarball Contents ===
npm notice 867B   package.json
npm notice 73B    .prettierrc
npm notice 1.1kB  index.js
npm notice 11.5kB middy-secrets-0.2.1.tgz
npm notice 2.2kB  README.md
npm notice 1.2kB  .idea/codeStyles/Project.xml
npm notice 301B   .idea/composerJson.xml
npm notice 22.5kB .idea/dbnavigator.xml
npm notice 281B   .idea/middy-secrets.iml
npm notice 174B   .idea/misc.xml
npm notice 278B   .idea/modules.xml
npm notice 180B   .idea/vcs.xml
npm notice 23.2kB .idea/workspace.xml

$ echo /.idea/ > .npmignore
$ npm pack

npm notice
npm notice 📦<EMAIL_ADDRESS>npm notice === Tarball Contents ===
npm notice 867B   package.json
npm notice 73B    .prettierrc
npm notice 1.1kB  index.js
npm notice 21.6kB middy-secrets-0.2.1.tgz
npm notice 2.2kB  README.md


As an industry reporter, I want to see an overview of all the major sections of my report

Description:
When the user has started reporting, we want to see an overview step breakdown. We have implemented this design in registration so this ticket may involve pulling that component for reporting as well

Acceptance Criteria:
Given
When
Then
Development Checklist:

[ ] Checklist item
[ ] Checklist item
[ ] Checklist item
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

Refinement May 21st:
2 pieces of functionality:

the component takes a list of steps (text)
the component takes a highlighted step (probably a flag)

Hey @pbastia  and @suhafa - this ticket looks refined to me. Would you agree?

@patriciarussellCAS agreed!

@suhafa just flagging that the visual in this ticket is outdated.

@patriciarussellCAS updated, thanks for flagging!

@patriciarussellCAS
The component used in regisrtation for header, can be reused and it can be used under reporting in the same way

Design review:

The 'yellow' selected component needs to have its text in black within the cirlce, not white, as it fails contrast and accessibility standards (important)
The blue circles have to have the color '#38598A' (not as important)

I wasn't able to confirm the functionality by clicking through the entire component, and can note the above based on the screenshot @ayeshmcg attached. fyi - @patriciarussellCAS

There are a few design issues to fix, back to the sprint backlog :)
@ayeshmcg @patriciarussellCAS

@pbastia
Added a report page with multistep header, form will be added later when we have schema.
@suhafa
Added the changes you mentioned

https://cas-bciers-frontend-dev.apps.silver.devops.gov.bc.ca/reporting/report


[Update Request]: Citrix Workspace LTSR <IP_ADDRESS>

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
Citrix.Workspace.LTSR
Package Version
<IP_ADDRESS>
Please describe the changes you would like to see
if possible please update Citrix.Workspace.LTSR from current 22.03.4000 to <IP_ADDRESS>
https://github.com/microsoft/winget-pkgs/blob/master/manifests/c/Citrix/Workspace/LTSR/22.03.4000/Citrix.Workspace.LTSR.installer.yaml
https://www.citrix.com/downloads/workspace-app/workspace-app-for-windows-long-term-service-release/workspace-app-for-windows-LTSR-Latest.html

Hi @ericoevering,
The link provided goes to the current manifest. Do you have a link to the new package?

New versions can be founded here, currently version <IP_ADDRESS>(2402) released on Apr 8, 2024.
The InstallerUrl is dynamically generated and contains encrypted parameters. Also Referrer and Cookies are necessary to gain access to the file.


Automatically sync music from a network folder

It would be so cool if the drive will keep the music folder up to date with a network share... Not sure about how much effort that is though.

FWIW, I just added another rsync line in bin/archive-clips.sh to sync my music archive to the car.  You can use existing functions to ensure that the music archive is mounted first.  Adding configurability would be more effort than getting it to work, but isn't unreasonable.


Added command for how to get ingress port.

/cc @geeknoid

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: gyliu513
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
Assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Ah, I see, thanks @frankbu


nixos/services/samba: install samba when nixos module is enabled

Motivation for this change
It’s confusing that when I set services.samba.enabled = true; in configuration.nix I can’t use samba because smbpasswd is not (straightforwardly) accessible.
This fix was suggested in https://github.com/NixOS/nixpkgs/issues/22435.

This should probably use config.services.samba.package instead. Otherwise LGTM.

@GrahamcOfBorg eval
@GrahamcOfBorg test samba

This also needs to be squashed and the commit message changed to the format specified in https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md


Implement KHR_image_format_list validation

Test case yet to come.

This is no good. The codegen for safe_* doesn't do the right thing with pNext. Will have to fix that first, and then this will be the right thing.

@jzulauf-lunarg, was that you that was taking a look at this pNext issue?


Display the avatar in users#show

The avatar doesn't get displayed.
web/templates/user/show.html.eex

I asked how to do this on stackoverflow:
http://stackoverflow.com/questions/36938580/arc-url-for-images-in-local-storage


[Meta Issue] Specification documentation structure and supporting docs

This does not cover what the spec actually support, but rather how the specification documentation itself is provided. This issue will also cover suggestions for supporting docs.
Please don't add comments directly to this issue.

@OAI/tdc please send some feedback for documentation structure

I'll look to @webron for some advice / mentoring on this.

Will look at adding an index / table of contents (ToC): #673

@OAI/tdc here's an inventory of the documentation items for review / examples:
Metadata

[ ] OpenAPI Object

[ ] Info Object

[ ] Host Object

[ ] Contact Object

[ ] License Object

[ ] Tag Object

[ ] ## Paths + operations + body parameters

[ ] Paths Object

[ ] Path Item Object

[ ] Operation Object

[ ] External Documentation Object

[ ] Parameter Object

[ ] Request Body Object

[ ] Items Object

[ ] ## Responses + payloads

[ ] Responses Object

[ ] Response Object

[ ] Headers Object

[ ] Example Object

[ ] Links Object

[ ] Response Payload Values

[ ] Header Object

[ ] Examples Object

[ ] Reference Object

[ ] Schema Object

[ ] XML Object

[ ] ## Reuse

[ ] Components Object

[ ] Definitions Object

[ ] Parameters Definitions Object

[ ] Responses Definitions Object

[ ] ## Security

[ ] Security Definitions Object

[ ] Security Scheme Object

[ ] Scopes Object

[ ] Security Requirement Object

This meta-issue has served its purpose, and any remaining items are being tracked under new labeling now.


Export dictionary with named Enums as keys display integers in editor

Godot version
v4.1.1.stable.flathub [bd6af8e0e]
System information
Linux pop-os 6.4.6-generic
Issue description
Given the exported dictionary with named enum as a key like here:
@export var storage: Dictionary = {
	Types.RESOURCES.H2O: 0.0,
	Types.RESOURCES.ENERGY: 0.0,
	Types.RESOURCES.MINERALS: 0.0,
	Types.RESOURCES.CARBON: 0.0,
}

Note: named enum is defined in global 'Types'. But it does not make a difference if named enum is in the same script.
Editor displays integer values of these keys rather then text representation, like below

I would expect to see named enum text representation, or at least this would be more useful in editor.
I understand that dictionaries do not have fixed type for the key and the value and they can be different for each record in dictionary, still would be useful to have named enums displayed their name.
Not sure if this should go to proposals or can stay here
Steps to reproduce
Add
@export var storage: Dictionary = {
	Types.RESOURCES.H2O: 0.0,
	Types.RESOURCES.ENERGY: 0.0,
	Types.RESOURCES.MINERALS: 0.0,
	Types.RESOURCES.CARBON: 0.0,
}

to a node script and investigate the node in the editor.
Minimal reproduction project
not included, not required

Not sure if this should go to proposals or can stay here

This should be opened on godot-proposals indeed, as this isn't a bug.
Implementing this isn't trivial, as this relies on ClassDB reflection (which may have some caveats, especially with subclasses or named classes).


Minified Action to show just icons

Hi
Is there a minify action to show just the icons?
Thanks

comments the

This is supported now on the latest rewrite.
https://codesandbox.io/s/r7yo0konkn


Missing string in Transifex for Calculating raster area

String 29 from the website is missing in the doc for Transifex to translate

I have pushed updated translations and this seems to be fixed. Please reopen if you still see problems.


Fix typo: add missing space

Just reading through these docs (they're nice, by the way, thank you!) and spotted this missing space so I thought I'd  put in a quick PR to fix it - Hope that's okay!

Thanks!


Load BatchML into the power_perceiver.load_prepared_batches code

[ ] Get it working with satellite, PV & GSP
[ ] Need to make sure we're delivering the correct forecast time_utc for GSP and PV (I assume the forecast timesteps will be missing from the live batches)
[ ] Get it working with all the numpy batch processors we're using
[ ] Create load_prepared_batches.data_sources.nwp
[ ] To start with, lie to the model, and tell it that the PV and GSP ID is always 1. (Background: The ML model requires the PV system row number and GSP ID as a feature. The model has an embedding for these two IDs. Ultimately, before showing PP's predictions to users, we'll need to create a look-up-table that maps from the PV and GSP IDs used in production, to the PV row number and GSP ID expected by PP. But, just to get things working quickly, keep things simple and tell the model that the PV ID and GSP ID are always some fixed number, e.g. 1).

The forecast timestamps for GSP, PV and Satellite will not be present

It might be easier to load Batch into power_perceiver.load_prepared_batches as these will be xarray objects


querySelector and attribute's value

When specifying the value for an attribute in querySelector() method like tag[attr='value'] , the method doesn't work as expected and returns null.
Example to reproduce the issue:
<?php

require "vendor/autoload.php";

$html = file_get_contents("https://github.com");
$document = new \Gt\Dom\HTMLDocument($html);

//will print "Enterprise"
echo $document->querySelector("nav > ul > li > a[data-ga-click]")->innerText . "\n";

//will throw PHP Notice: Trying to get property 'innerText' of non-object
echo $document->querySelector("nav > ul > li > a[data-ga-click='(Logged out) Header, go to Enterprise']")->innerText . "\n";

The expected behaviour is that the last line should print "Enterprise"
If I try to run the exact querySelector call in my browser, it works correctly and both lines print "Enterprise":
document.querySelector("nav > ul > li > a[data-ga-click]").innerText
document.querySelector("nav > ul > li > a[data-ga-click='(Logged out) Header, go to Enterprise']").innerText

Thanks for reporting this. I'll look into it shortly.

Hi @dmitriy-krista, it looks like the problem is with the use of the comma character, which isn't taking into account the quotes surrounding it. I've tested a simple attribute selector which works fine, so it looks like the way the attribute selector is parsed in PHP.Gt/CssXPath is to blame.
I'll transfer this issue there and find a fix soon.


[Sensor] RayCaster: Different height calculation ways bewteen reward func : base_height_rough_l2 and height_scan func in observation

Observation func
sensor.data.pos_w[:, 2].unsqueeze(1) - sensor.data.ray_hits_w[..., 2] - offset
Reward Func
base_height = torch.mean(asset.data.root_pos_w[:, 2].unsqueeze(1) - sensor.data.ray_hits_w[..., 2], dim=1)
Don't know why there is an offset in the default function. Pls have a look and test.

Some discussions in https://github.com/isaac-sim/IsaacLab/discussions/774


Running with Kind (if Kind already running) Kills existing running Kind :(

run kind
run kuttl with --start-kind

💥

Introduced in https://github.com/kudobuilder/kuttl/pull/80
PR created to resolve (with details on what's what)


TechDocs Homepage

Closes: #4103
Closes:  #4102

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7

We'll wait until the app.support feature is merged in #4517 and reuse it for Support details on TechDocs homepage.

Hey - I noticed now that we've been skimming past this one but it actually needs approval. Sorry if that's been blocking you. Is it ready on your end? Apart from the merge conflict.

Oh sorry, now I read the support comment.

yeah no worries @freben its a little blocked right now and we will continue on it soon! Thank you anyways 👏

FYI should be unblocked now - app.support is in master.

FYI should be unblocked now - app.support is in master.

Oh, sorry. I didn't even realize this was blocked on that. Hopefully it works for the purposes of this PR.

Nice, thank you for the update @adamdmharvey, I'll look into it tomorrow and hopefully get it 🚢

So just a heads up. The updated SupportButton hasn't been fully extended for plugins. You can insert child content and it does internal read from a new app.support key which supports multiple item groupings.
The idea was to extend this further to allow plugins to add their own support item groups or somehow do this automatically via reading some metadata from the package.json.

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7

Understand @andrewthauer I just added some example support information around TechDocs for now.

But agree with that it would be nice to just be able to show TechDocs support config and not all configs on specific plugin pages.

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7

Hey - I noticed now that we've been skimming past this one but it actually needs approval. Sorry if that's been blocking you. Is it ready on your end? Apart from the merge conflict.

nooow its ready for review from your side @freben

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7

Tugboat has finished building the preview for this pull request!
Link:

https://pr4401-pvley4xwc81k5tq8nyd1ohuvajk3f1jm.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/601d20a098552d1fa65756d7


In findreplace, if nothing is highlighted, use word under cursor

Search/Replace can be simplified by placing the cursor on the word to be
searched and simply hitting the hot key (ctrl-f or ctrl-h)

@goanpeca, would you mind to review this one? Thanks ;-)

@sonofeft thanks for working on this.
I made some comments on style and some other minor issues that need to be handled. I will test the functionality later on.
Cheers :+1:

By the way, is there some issue that is being fixed by this PR, or it was just a random enhancement ;-) ?

Thanks for all the feedback.  I will make updates soon.
It was a random enhancement... I like that feature in Scintilla.

Made suggested changes:
used "to_text_string" helper function
got rid of multiple "_" usages
modeled exception clause after others in spyder codebase
added constant for "reasonable" search limit
made some formatting adjustments to accepted norms
changed "if len(text)" to more pythonic "if text" (including existing code base withing show()"
Let me know if there's anything else you'd like.

@sonofeft will try to review this one this weekend!

I think the whole functionnality could be replaced by something like cursor.select(QTextCursor.WordUnderCursor) (see http://doc.qt.io/qt-4.8/qtextcursor.html#select).
One downside is that you don't have a fine control over what is considered a word, but I don't think that's a problem for such a functionality. It would greatly simplify the code !

@sonofeft, what do you think about @Nodd suggestion?

Simple is good.
I'm more concerned with providing the functionality to reduce editing keystrokes than a specific implementation.
If a new, simpler implementation is available, I'm all for it.

Ok, I have two things to say:

Please restore the blanks you removed while working on this PR. That makes reviewing and porting PRs quite complicated, so we are not in favor of that :-)
Do you plan to follow @Nodd advice of using QTextCursor.WordUnderCursor or not? Sorry, but it was not clear to me :-)

Sorry about the blanks, I had the Spyder option to remove trailing blanks turned on, so Spyder does it automatically. (I guess the shame of pylint messages was too hard for me to bear)
Also sorry I mistook the @Nodd advice to be more notional than as a concrete proposal.
I can start from a clean fork (with blanks restored) and play around with his idea to see if I can make it work
I assume it would be something like:
cursor = self.editor.textCursor()
cursor.select(QTextCursor.WordUnderCursor)
text = to_text_string(cursor.selectedText())
I can see where a whole bunch of my code goes away it the above three lines get "text" populated.
If the above three lines look correct to you, I will try to get that done this week.

Using QTextCursor.WordUnderCursor went surprisingly fast...
I went ahead and just made the changes.
The testing I've done seems to work fine.

I need a suggestion from @Nodd to fix the python 3.4 w/o Conda error.
It looks like a Qt version issue.

All tests fail, but not with the same problem. One is:
-- Testing standard Python socket interface --
Traceback (most recent call last):
  File "spyderlib/utils/bsdsocket.py", line 160, in <module>
    client.send("data to be catched")
TypeError: 'str' does not support the buffer interface

The command "./continuous_integration/travis/modules_test.sh" exited with 1.

And the other with:

The build has been terminated

All of these are failures, I don't know where they come from. I'll close/reopen the bug to retrigger the checks, because it isn't related to your code.

@sonofeft, please rebase or merge with latest master and push again.
I changed some things about our integration with Travis and that's not letting our tests to finish in your branch :-)

@ccordoba12, or @Nodd can you review this one?

@ccordoba12, or @Nodd can you review this one?

Why all the updates to the translation files ? It isn't related to your PR. It looks like a merge with master gone wrong.
Apart from this the code itself looks fine.

I apologize if I merged badly.  As I recall, I was too out of date to merge cleanly and had to futz around.
On the "if text" comment... are you asking me to change the existing code's "if len(text) > 0" line to "if text"?

I think that you have to revert the changes to spyderlib.mo/spyderlib.po and keep only findreplace.py. Feel free to create another PR from scratch if it's simpler for you, since the changes are very small.
Yes please make the change, it will clean our codebase.

I went ahead and started a new Pull Request.
Added Find/Replace Enhancement #2957

Can we close this one then @sonofeft ?

That seems to be the case because this has some weird changes (e.g. to our translation files).
@sonofeft, thanks for your interest on this one! :-)

Glad to help. Thanks for guiding me through the process.


Property not found when modifying prototype

I extend the prototype of Date in the following way:
Date.prototype.getWeek = function () {
  var date = new Date(this.getTime());
  date.setHours(0, 0, 0, 0);
  // Thursday in current week decides the year.
  date.setDate(date.getDate() + 3 - (date.getDay() + 6) % 7);
  // January 4 is always in week 1.
  var week1 = new Date(date.getFullYear(), 0, 4);
  // Adjust to Thursday in week 1 and count number of weeks from date to week1.
  return 1 + Math.round(((date.getTime() - week1.getTime()) / 86400000 - 3 + (week1.getDay() + 6) % 7) / 7);
}

But on using the method Flow gives me the following error:
 34:     let week = now.getWeek();
                        ^^^^^^^ property `getWeek`. Property not found in
 34:     let week = now.getWeek();
                    ^^^ Date

The error itself seems logical to me because Flow doesn't know about this added method. Is there a way to make the error go away?

You can write (now:any).getWeek() to tell Flow to shut up, but you might consider rewriting your code a bit to avoid extending the prototype. function getWeek(date: Date): number as a util, for example.

Thanx for the tip. I will do the latter, that is the better solution.


Fix #92 add Cargo.toml to the git tree

Fix #92  and depends on #93
If everyone agree with the solution proposed in #92 this PR add a Cargo.lock with the last commit of atspi tracked.
If you don't agree, feel free to close it :smile:

After merging this PR, a good practice to follow updates in atspi repository is:

open a new branch (e.g.: atspi-update/<atspi-commit-hash>)
run cargo update
fix broken code
open a PR

Note that it's better to make this process regularly, to avoid having to fix big API breaks

Yes, this is a super annoying problem. The reason this happens is that Rust assumes the in x.y.z versions, y is a minor version bump, which is not the same as semantic versioning 2.0 (for 0.y.z), where y becomes the major version.
Thank you for adding the cargo lock to the git repo. I didn't realize that this was not the case.


project list

Can you add a command to list all projects ?  Eventually also filtering out projects without open tasks ?

Heyo! There's doist projects list, but I've not thought of a filter like that, let me think of something!

I'm thinking of something like:
doist list -P project_name

to filter for all open tasks of a project in addition to the -f filter. Eventually I hope to make doist projects list more interactive so you can browse tasks directly by going there (in addition to renaming projects or adding comments to them)
I'm still thinking of a good UX to not show projects that don't have any open tasks, let me get back to you here.

With 0.1.14 you can now do doist l -f all -P name to get all tasks under a project (or use a different filter), and the same with -S section and -L label for labels, so you can set this all up like you need it. Still thinking about the UX for

projects with open tasks
but I think I'm getting there.

Okay with 0.1.16 there's now a feature to do filters on the project list, #32 has some details in the comment. Cheers! In general more interactivity in the projects list is still planned (listing tasks of the selected project for instance)

thanks !


Missing documentation

Thanks for the sharing the awesome work, I'd like to replicate this and maybe use this in conjunction with voxelnet. It'll be great if the current README could be updated so that I work with this.

Great idea with the Voxelnet!!! Definitely, let me know if you gain any interesting insides with this approach! Really excited to hear back from you regarding this method :+1:
I just started to add a documentation / work through! You can find it in the ReadMe. Let me also know here if anything is buggy or needs better explanation!


Performance optimization opportunity

Version
nuxt-security: 1.0.0
nuxt: 3.9.1
Reproduction Link
https://stackblitz.com/edit/github-3cbcjk
Steps to reproduce
Go to the StackBlitz, and run npm run build && npm run preview.
And, reload the page.
By default, the app is not using the nuxt-security module. In server log, you will see how long it takes for Nitro to render the app. It averages just ~1ms for me.
To simulate a more real-life page, I am rendering 5000 elements on the page.
Now, enable the nuxt-security module and repeat the steps.
You will see that the Nitro render now averages a lot more now.
What is Expected?
The security plugins should not impact the Nitro render time that drastically and should scale well with the size of the page.
What is actually happening?
This seems to be happening in the Nitro plugins that iterate through the HTML context a few number of times using cheerio to get the elements to modify.
Maybe, we can improve this by reducing the amount of times we loop over the HTML context and making changes as efficiently as possible?
I noticed this issue on a very chunky page. So not sure how much this translates to real world pages. But, nevertheless thought it might be worth investigating if we can improve the performance here.

Hey @prashantpalikhe
Thanks for this issue and reasearch!
Yes, the module shouldnt decrease the performance. We have not yet receive any issues about performance but we can look at your recommendation and try to make it work.
@vejja What are your thougths on that?

I'll try to measure which part of the HTML parsing is taking most time to find out if there are low-hanging fruits somewhere
We can probably leverage the event.context.security object of #298 to cache some parsed objects there

Interestingly @Baroshem after releasing 1.0.1 from #335 our Page crashed in Cloudflare due to exceeding CPU Limits.
It appears that simply upgrading the nuxt-security module with no other changes we went from averaging 14ms responses to 200ms - 500ms on average.
With Nuxt-security 1.0.1 shipped
You can see the spike in the graph immediately after deploy at 13:25.

Reverting to nuxt-security 0.13.0
We can see the cpu response time drops back down when deployed around 14:00

@Baroshem @vejja
For us, the biggest bottlenecks were the nitro plugins for the SRI and CSP nonce, specifically the body section. Since that can be quite huge.
We use web components with Declarative Shadow DOM. That means the styles for the components are repeated in HTML per usage of a component. That is how it is right now with web components that are SSR-ed. But I can imagine, there are many other ways in which HTML can grow in size. The use of inline SVG icons comes to mind.
So as a workaround, we disabled nonce and contentSecurityPolicy in nuxt-security and we handle it ourselves. Where we do everything like nuxt-security does except we ignore the body section. That saves us 200-300ms in server response time.
I don't know how we can fix this in the module itself. Maybe a configuration option to set which sections to look into when setting nonce could be useful.
But that is hiding the issue, not really solving it.

@pi0 @huang-julien
We are using cheerio to parse the HTML in our Nitro plugins, but this seems to crash workers
Do you have a recommendation for a faster/lighter library ?
Or alternatively is it possible to hook deeper into Nuxt to avoid parsing HTML strings ourselves and directly use some kind of structured data before it is combined into HTML ?

@vejja

but this seems to crash workers

Is this reproducible easily?
Maybe parse5 can be used? Cheerio seems to use it internally. But, if the crashing of workers/exceeding of CPU limit, is easily reproducible, we can try using parse5 directly and see if that behaves better.

Hey guys,
Yes we had a regular regex before. I dont actually remember what was the issue back then. But seeing that this solution could improve the performance I am up for trying it instead of cheerio.
I think we could refactor the current html parsing to the previous approach for 1.1.0 and compare the performance with 1.0.0 (that uses cheerio)
If it will be causing any issues, we can release a patch 1.1.1 with a revert to use cheerio once again.
What do you think?

That sounds good.
And what do you guys think about allowing configuration of the sections to loop through.
Use case: if as a developer, I am confident that the body section won't contain any link/style/script tags, then parsing that string (usually the largest chunk) is wasteful.
So, if we could configure that somehow, that would be pretty rad.

Also, before we make the regex changes, it would be great to profile the CPU/memory consumption of the regex based apprach and compare with Cheerio.
Any ideas on how to best do that check?
I am using node --inspect right now and doing some memory profiling. But I always find it tedious to parse the result of that.

Hey guys,
Yes we had a regular regex before. I dont actually remember what was the issue back then. But seeing that this solution could improve the performance I am up for trying it instead of cheerio.
I think we could refactor the current html parsing to the previous approach for 1.1.0 and compare the performance with 1.0.0 (that uses cheerio)
If it will be causing any issues, we can release a patch 1.1.1 with a revert to use cheerio once again.
What do you think?

I think the classical example where this fails is if you write a documentation section for how to use some feature that includes the regex, e.g.
Documentation:
To do something with Vue 3, copy the following code
<script setup lang="ts">
...
</script>

Having a DOM Parser allows to make the difference between the tag itself and its innerHTML.
In addition the regex must be able to process both external scripts (<script ... />) and inline scripts (<script>...</script>). Our regex used to do that but it is tricky.

Also, before we make the regex changes, it would be great to profile the CPU/memory consumption of the regex based apprach and compare with Cheerio.
Any ideas on how to best do that check?
I am using node --inspect right now and doing some memory profiling. But I always find it tedious to parse the result of that.

I am using process.memoryUsage() in the code right now, but not sure it is any better as I find it extremely difficult to read too. And it's only available in Node.
I'm trying to see if there would be significant improvement by only invoking cheerio.load once and for all, as this seems to be the slowest part of the code.

 In Nuxt core, we're not currently using any external packages to replace html. We're mainly using regex .

I'm proposing a temporary patch for affected users while we refactor to regexes

Hey guys, I have merged the patch to the 1.1.0 branch.
You can either check it on the branch if the application is more performant or wait until I will release the 1.1.0 release this week and we could test it there.
Let me know :)

Hi @Baroshem, I'm proposing an additional patch above, maybe our CF users want to test that

Awesome @vejja
Lets merge it to the 1.1. branch and test it there :)

@unr @prashantpalikhe @vejja @huang-julien
1.1.0 version has been released with the performance optimizations by @vejja.
Could you check if now it is better? :)

@unr @prashantpalikhe any news from your side? :)

Hey there, @Baroshem
Sorry, due to some personal issues, I have not been able to code much the last month and a half.
I will test it out soon. But, regardless, on our end, we went with our custom CSP/nonce implementation because we want to skip parsing of the entire body which is significantly large in our case.
I will check against this new implementation regardless.

Thank you @prashantpalikhe and hope everything is ok!
In your custom solution, if you think that there is something that could be done better in Nuxt Security, please do not hesitate to let us know :)


Svelte 5 types support

Check that this is really a bug

[X] I confirm

Reproduction link

Bug description
Overall Konsta works fine with Svelte 5 as it's backwards compatible with 4 but there seems to be a small issues with Svelte 5 support:
Types have changed, leading to TypeScript errors in each component.

Argument of type 'typeof Actions' is not assignable to parameter of type 'ConstructorOfATypedSvelteComponent'.

Possible causes:
- You use the instance type of a component where you should use the constructor type
- Type definitions are missing for this Svelte Component. If you are using Svelte 3.31+, use SvelteComponentTyped to add a definition:
  import type { SvelteComponentTyped } from "svelte";
  class ComponentName extends SvelteComponentTyped<{propertyName: string;}> {}ts(2345)
(alias) class Actions

In addition, there are some small changes in Svelte 5 that now trigger a notice warning:
/Users/k/Documents/GitHub/x/node_modules/konsta/svelte/components/Actions.svelte:25:2 Self-closing HTML tags for non-void elements are ambiguous — use `<div ...></div>` rather than `<div ... />`

There's some background for this change here:
https://github.com/sveltejs/svelte/issues/11052
To reproduce

Start a new project with  npm create svelte@latest my-app
Select Svelte 5 alpha/beta during the installation process
Install Konsta UI and use any component in the SvelteKit project.

Expected Behavior
No errors when importing components
Actual Behavior
Errors in VSCoe
Konsta UI version
<EMAIL_ADDRESS>Platform/Target and Browser Versions
macOS
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Konsta UI issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

t0ggles-create konsta

I currently ported Konsta svelte to svelte 5 including all components, but stepping on one minor issue wrt config.js not providing a default export?
https://github.com/konstaui


Feature/the alexa skill

#109 Simple CDK pattern to upload a zipped Alexa Skill to S3 and then deploy the Alexa skill. Skill is fulfilled by AWS Lambda and writes session data to dynamo DB.

I ran the tests and 3 of them failed, something to look into.

I ran the tests and 3 of them failed, something to look into.

Not sure how I missed that. Originally the asset stack was creating a new S3 bucket and uploading a file to it. I since learned I could use the existing CDK asset bucket and removed a custom S3 bucket. The failing tests were in regards to the original bucket. With that said, the only resource the Asset stack now has is CDK metadata.
That leaves me with the following questions:

Does it need to be tested?

Should it be consolidated into the skill stack?

I would say that if you can consolidate it into one stack now then it makes it easier for people to see everything that is happening. With that logic not producing any Cloudformation due to it using the CDK asset bucket then I would say it is fine to not have a test for that

@nideveloper this has been reduced to 1 stack with all tests passing.

Hey, I have been trying to deploy this today.
Are there detailed steps anywhere on setting up an amazon developer account and getting your ClientID, ClientSecret, Refresh Token and VendorID? It took some googling for me to find the vendor id and I can't find where I get the refresh token at all.
I am also assuming this is an EU specific setting but it made me link to an official company privacy policy when signing up, definitely not a casual 5 minute signup process

Looks like I need to install the ask cli and use that to get the refresh token... I think detailed instructions on this part of the setup will be worth their weight in gold

Looks like I need to install the ask cli and use that to get the refresh token... I think detailed instructions on this part of the setup will be worth their weight in gold

Docs added!


New version: SoapySDR v0.3.5

Registering package: SoapySDR
Repository: https://github.com/JuliaTelecom/SoapySDR.jl
Created by: @sjkelly
Version: v0.3.5
Commit: 41edf5168cd553389ea9e43f8e0f96b30b5a62ae
Reviewed by: @sjkelly
Reference: https://github.com/JuliaTelecom/SoapySDR.jl/commit/41edf5168cd553389ea9e43f8e0f96b30b5a62ae#commitcomment-87081024
Description: Julia Wrappers for SoapySDR

Please close this should have been a minor release.

Block.


Crash on closing plugin window in ardour 5

When I execute a "close" (in openbox) on the plugin window, ardour crashes and I have to SIGKILL it.
I'm running self-built ardour5.6.0 on gcc 6.3.0, and running the latest release on airwave. My wine is self compiled biarch (so compiled with --with-wine64 and wine-tools on version wine-2.2-119-g1cc93e3f05).
The plugins observed with are u-he zebra2 2.7.2 and Loomer Strings 1.0.3.
Reproducing the error with the flood level gives me nothing useful, but I can provide it for you if you'd like.

Same with Ardour 5.8 (kxstudio repo) and Airwave 1.3.3. When I close the plugin window (ex. LePou, u-he, GlissEQ) Ardour crashes with the following error:

X Error of failed request:  BadWindow (invalid Window parameter)
Major opcode of failed request:  40 (X_TranslateCoords)
Resource id in failed request:  0x241cc13
Serial number of failed request:  436
Current serial number in output stream:  436

I am also having the same issue using the 4Front R-Piano http://www.yohng.com/software/rpiano.html with Ardour 5.8, openbox 3.6.1, wine-2.7, Airwave built from the current git: 8cd3507a46c2f7809a2ef8481cbded7dcbbae8ff

I have this problem, too, running airwave_1.3.3-1 and Ardour 5.10. No such problem on Tracktion or Bitwig.

Any update?

I've fixed an issue of crashed plugins upon closing on my branch. Try it to see if you have the issue: https://github.com/asb2m10/airwave


config option to expire always-on clients after some period

Suggested by @bogdomania: if an always-on client doesn't get any connections for months, it doesn't make sense to keep displaying it in 353 RPL_NAMREPLY etc. There should be a config option to sign these clients out.

#810 :)

haha, thanks!


the dropdown menus dont get applied

as the title says, the dropdown menus all of them don't get the same colour palette but a blinding white

Thanks for posting an issue! Can you update the extension and let me know if it is still happening? It is not happening for me after the latest update. If it is still happening, let me know what browser you're using.

Yes. Same for me. I installed from the extension tab couple of mins ago and tried changing every color in the theme but the drop down is white which makes the text unreadable.

Oh ok I see. The dropdown is unthemed and being colored by the browser. My firefox is catppuccin themed, which is why I reckon I didn't have an issue. I will quickly fix this.

No problem:-)Thank you for this awesome extension!

Alrighty I think the latest update resolves this issue. If the problem persists then feel free to reopen this issue and let me know what browser you're all using :)


consider note and command events with velocity 0 as end events

As the title says : to stay coherent with common MIDI abusing practice (i.e note on with velocity 0 is considered a note off), we should consider that note and command events with velocity 0 are end events and not start events (Events::isStart specializations should be modified accordingly)

member x.IsStart =
  match event with
  | NoteOn(_, _ , 0) | NoteOff(_, _, _) -> Some false
  | NoteOn(_) -> Some true
  | _ -> None

Hi @smoothdeveloper ! Long time no talk ...

I'm still on the line because I didn't parse the note on which is in fact a note off :D


Upgrade Flutter Version

Our project use channel stable:

Upgrade Flutter 2.2.3
Upgrade Dart version: 2.13.4
Migrate FlatButton to TextButton
Migrate RaisedButton to  ElevatedButton

@PormpimonPang  Leave some comments.


Lab 2 - Need to fix azure-pipeline.yml

at line 22 we need to add a sub-folder /deployment

task: CopyFiles@2
inputs:
sourceFolder: '$(Build.SourcesDirectory)/deployment'
contents: '?(gab2019.json|gab2019.parameters.json)'
targetFolder: $(Build.ArtifactStagingDirectory)

Fixed with commit d175d23


Package request: mp3splt-gtk

Project description
Utility to split mp3, ogg vorbis and FLAC files without decoding. It's the gtk-version; the console-version already exists on NixOS.
Metadata

homepage URL: https://sourceforge.net/projects/mp3splt/
source URL: https://github.com/mp3splt/mp3splt
license: mit, bsd, gpl2+ , ...
platforms: unix, linux, windows.

Add a :+1: reaction to issues you find important.

It's way too old 🥲


AttributeError: 'FileReader' object has no attribute 'workspace_restricted'

Description
Agent Training -> Select agent : Starchat -> Select Training Source : Github Repository
In Enter a GitHub repository for the agent to learn from.. For example, 'Josh-XT/AGiXT' i put "joshnh/Git-Commands" and I push "Train from GitHub Repository".
The result in console log is
...
agixt-agixt-1                    |   File "/usr/local/lib/python3.10/site-packages/fastapi/routing.py", line 163, in run_endpoint_function
agixt-agixt-1                    |     return await dependant.call(**values)
agixt-agixt-1                    |   File "/agixt/app.py", line 467, in learn_github_repo
agixt-agixt-1                    |     await GithubReader(
agixt-agixt-1                    |   File "/agixt/readers/github.py", line 80, in write_github_repository_to_memory
agixt-agixt-1                    |     await self.file_reader.write_file_to_memory(file_path=zip_file_name)
agixt-agixt-1                    |   File "/agixt/readers/file.py", line 33, in write_file_to_memory
agixt-agixt-1                    |     if self.workspace_restricted:
agixt-agixt-1                    | AttributeError: 'FileReader' object has no attribute 'workspace_restricted'

Steps to Reproduce the Bug
v1.3.109
Expected Behavior
Tu run.
Operating System

[X] Linux
[ ] Microsoft Windows
[ ] Apple MacOS
[ ] Android
[ ] iOS
[ ] Other

Python Version

[ ] Python <= 3.9
[X] Python 3.10
[ ] Python 3.11

Environment Type - Connection

[X] Local - You run AGiXT in your home network
[ ] Remote - You access AGiXT through the internet

Runtime environment

[X] Using docker compose
[ ] Using local
[ ] Custom setup (please describe above!)

Acknowledgements

[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of AGiXT.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

Also, learning from File has this error:
2023-08-16 13:26:39 INFO:     <IP_ADDRESS>:44922 - "POST /api/agent/Starchat/learn/file HTTP/1.1" 500 Internal Server Error


useSwrInfinite with react-infinite-scroll-component | after changing fetch key -> current index does not reset

Bug report
userSwrInfinite + react-infinite-scroll-component bug
Description / Observed Behavior
I have react-infinite-scroll-component with useSwrInfinite integration. I also have an input to search by name the api. if i'm beyond page 1 and do a search (thus changing the useSwrInfinite key), useSwrInifinite will start searching serially all pages until the current page i am 1...N.
It's interesting to observe that if my scroll position is viewing only the first page, then only the first page will be fetched not 1...N
Expected Behavior
I expect that on change of key in useSwrInfinite get key function will reset the index to 0 and only the first page will be fetched.
Repro Steps / Code Example
https://codesandbox.io/s/react-infiinite-scroll-component-with-userswrinfinite-bug-reproduce-ch7hi
Reproduce steps:

click the repositories link to go to the page where the bug happens
if you need to refresh please refresh the whole page (because of detecting mobile css)
scroll a few pages down (see that react-infinite-scroll-component fetches the pages)
now search for a name in the input field.
you can see useSwrInfinite serially fetching 1...N (pages) one by one.

Expected Behaviour steps:

instead of scrolling -> search after the first load of the page
you can see now useSwrInfinite only fetches the first (1) page.

another way to see expected behaviour:

scroll a few pages
pages are fetched normally
now scroll back to first (1) page
now search for a term
see that useSwrInfinite only fetches the first page

SWR version
0.4.0
Thank you guys I
https://user-images.githubusercontent.com/9368630/118966849-b04a4600-b972-11eb-8871-7cf439284d34.mov
appreciate it :)

@nandorojo can you help?

My guess is it defaults to just refetching the latest page. Not sure though, since I don't maintain swr.
You could try toggling revalidateAll, although I'm not totally sure what your expected behavior is.

@nandorojo basically I want the option to reset the page. If the key is changed because of propane it is obviousness that I want to always start from page 1 and not fetch all pages up until the page I was at for the precious key

What if you setSize(1)

The actual problem in this example is that the next callback of react-infinite-scroll-component would be called multiply times after changing the input (because the scroll position does not reset to top)
useSWRInfinite does reset the current index by default
According to the implementation https://github.com/ankeetmaini/react-infinite-scroll-component/blob/d5b4e5250669022db5217763afd22fb3995a505a/src/index.tsx#L88-L95
I try to use the initialScrollY and key to reset the scroll position but it does not work.
<InfiniteScroll
      key={repo}
      initialScrollY={0}
      dataLength={repos.length}
      next={() => {
        console.log('next')
        setSize(size + 1)
      }}
      hasMore={!hasReachedEnd}
      loader={
        !isLoadingInitialData ? (

            <Spin />

        ) : null
      }
      endMessage={
        repos.length ? (

            Yay! You have seen it all

        ) : null
      }
    >

I have a temporary workaround for this example by using the window.scrollTo
React.useEffect(() => {
    window.scrollTo(0, 0);
  }, [repo]);

FYI: https://codesandbox.io/s/using-window-scrollto-gv5pu

@promer94 You rock!! it works

useInfiniteQuery of react-query has the same problem, and manually setting the scroll position to 0 doesn't work...


why only use 22 joints rather than 24

hi, @Arthur151 , why drop last two hand joints

Parameters of last two hand joints are used to control hand gesture, while we don't estimate them.Get Outlook for Android


fix rerendering errors

This commit fixes issues with children rendeirng inside outdated parents. Two things:
First: when parents change, destroy the old children and create new ones.  We weren't doing that before.
Second: Check that the parent-according-to-react is the same as the parent-according-to-mathbox. If they are different, destroy-and-create as above...
But...why might they be different? I believe fundamentally the issue is:

we store parent value in context...
we update the context parent value using useEffect hooks..
useEffect hooks are called children before parents.

One wonders whether we really need to be using useEffect hooks for the mathbox components, or if we can just put all the node creation/removal stuff in the render function. Hooks seem nice for dependencies, but mathbox is pretty smart about diffing out the actual changes.

@ChristopherChudzicki nice! I went to try this out and found that if you move the const mathboxOptions into the App component as I did here: https://github.com/ChristopherChudzicki/mathbox-react/pull/18#discussion_r840704169
Then clicking to new values of width works with two problems.

it seems to be doing a full rebuild of the mathbox component. This lets me drop down to smaller widths, which is nice — ie, it gets around that mathbox bug you've already fixed!
BUT if you click around enough, or simply drag the width slider, the whole scene disappears with this error:

bundle.js:17326 Uncaught TypeError: Cannot read properties of undefined (reading 'clock')
    at Cartesian.is (bundle.js:17326:28)
    at Cartesian._find (bundle.js:17470:14)
    at Grid._inherit (bundle.js:17466:80)
    at Grid._added (bundle.js:17371:36)
    at Node.<anonymous> (bundle.js:17299:42)
    at Node._trigger (bundle.js:82241:22)
    at Node._added (bundle.js:16741:17)
    at Group.add (bundle.js:16163:17)
    at Controller.add (bundle.js:42468:19)
    at API.add (bundle.js:42163:18)

You might have seen this already , leading to #23, but if not I wanted to point it out as you go forward.
THANK YOU for your work on this!

@sritchie Oh neat. I see what you mean. A few comments:

I forgot we hadn't deployed the "decrease width" fix...that seems so long ago. The weekend is a blur of rerendering issues... I think I'll deploy that later tonight.
Good catch with the "lots of fast rerenders breaks stuff". Yep. I believe I know why that is happening.... queued mathbox updates are firing after the instance has been destroyed. I think that should be easy to avoid. (If it's not, then this can definitely be fixed by replacing useEffect with useLayoutEffect which is always syncrhonous. But that has a noticeable hit on UI performance.)
Re inlining the options / moving its definition inside the body: I'm glad you did this since it helped catch bugs, but as you've seen it causes unnecessary re-renders... If you want to put stuff like that in the function body, you can avoid unnecessary re-renders with useMemo.

THANK YOU for your work on this!

Happy to be working on it :) A nice react wrapper around mathbox will be great.
I wish I was a little farther along in math3d-next, then I'd have a reason to use it and might discover more bugs .... but in the meantime, I'm happy to fix them!

Okay, that all makes sense. I think I have been making a wrong assumption about how React decides to re-render.
Here is what I think (is this correct?) is going on: in the main case, where the options are created outside of the App, react knows that the props haven't changed, because the const is bound to the identical instance.
When I move the const INTO App, it's created fresh every time, and fails the equality check.
I'm so used to Clojure data structures using value equality for everything, so I had expected that there would be no difference.
Because I re-render is so expensive, is it worth us overriding shouldComponentUpdate and doing a value-equality comparison of props?
The way it "should" work, I think, is that we want users to be able to customize properties with incoming data. For example, I'd like to be able to change from OrbitControls to something else with incoming data, and not trigger a full re-render each time.
Let me know if I've got it right now, and if I should just be more defensive about the way Mathbox props come in or if there's something we can do here to prevent re-renders more often.


Make Order Quantity Fractional

Order quantity is currently an int. Change it to be a decimal.
The change will be fairly extensive covering API methods and brokerage implementations.

I've looked into this and just changing the order quantity is not necessarily very problematic. There are a few explicit variable declarations but apart from this, everything ties together with just a few field types. There should not be a great deal of breaking changes to algorithms, although I think some will be unavoidable.
If this is followed through, there will also need to be change to Tick and Tradebar classes to support decimalised volumes.

Fixed in https://github.com/QuantConnect/Lean/pull/982


chore: trigger new release by incrementing internal version

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Import from Thingiverse/Printables

Describe the solution you'd like
I use manyfold for offline storage of externally published models. A REALLY nice feature would be the ability to paste in a url to Thingiverse or Printables and have the model imported automagically. Ideally the description and licence would be populated and it would pull additional images that are not included in the files/images path.
Describe alternatives you've considered
Manually copying and pasting this data :(

Yes yes yes yes. I would love to do this. It's definitely on my one-day list.

I think it would also be cool to have Manyfold sync from thingiverse collections/likes.

Absolutely - that was one of my original ideas, back a long time ago before I started writing them down here :)

+1 for this option!  Also, maybe check for updates, although this would require versioning of models.  Additionally, possibly import from Github ?

Gitlab for 3d models actually sounds amazing.

automatically grabbing updated files is definitely on the wishlist for this, yes 👍🏻

Gitlab for 3d models actually sounds amazing.

Nice indeed but way too heavy in ressources to be a valid solution. Manyfold even if not perfect is way more adapted

Maker World would also be nice.

Maker World would also be nice.

also myminifactory and thangs (the stuff hosted there)

Anything with API, really!

+1


JavaScript errors

Split from https://github.com/iconify/iconify-sketch/issues/16

@digiklug When does it show? On startup or when you click somewhere?

when I open the plugin

it opens very small
when i type in search it shows like below
on click anywhere nothing happen nor does search give any result the plugin is simply failing with the latest update its not allowing to do anything

Thanks, that is very helpful!
As for small window size, plug-in remembers last window size, so window must have been resized at some point, maybe opening developer tools triggered that. I'll test it.

Found code for those errors. It exists in 2.0.2, but not in 2.0.3 and it is the bug I mentioned in issue which 2.0.3 fixes. Have you updated plug-in to 2.0.3?

i restarted the sketch and it worked.
Awesome thanks. your plugin is very good I like it very much
could you may be also add stockholm icons to it ?

Awesome. Please report any other issues if you find any!
As for Stockholm Icons, I've never heard of them. Quick search shows that it is a premium icon set. If that's the icon set you are talking about, then no. Iconify provides only open source icon sets.


Alternative set of conversions

@CAD97 what do yo think about this set of conversions? The idea here is that

we provide From's for u32, because TextSize is, transparently, an u32.
we don't provide other fixed sized conversions -- I don't think I've ever needed them, and TextSize is not exactly the number, so forcing the occasional user to two a two step conversion seems OK: first covnersions changes to a raw repr, the second conversion is a numeric cast. This is in contrast two a one-step conversion, which mixes both numeric cast and raw-typed.
We provide TryFrom<usize> (because that can fail) and Into<usize> (because that can't fail. If you are on 16bit machine, you probably want to use u16 for TextSize anyway). Unlike stdlib, we can be more aggressive here.

I'd prefer (for moral/purity reasons) to have some sort of 16bit usize protection against silent loss of information. I'm fine if that's a panic in usize: From<TextSize> or even just outright refusing to compile (#[cfg(not(any(pointer_width = "32", pointer_width = "64")))] compile_error!("16 bit usize not supported");). To be completely honest, I'm fine with not supporting 16 bit embedded targets, I'd just prefer to do it explicitly.
Plus, pub(self) fn crate::range::ix(size: TextSize) -> usize should use Into<usize> if we have it.

To be completely honest, I'm fine with not supporting 16 bit embedded targets, I'd just prefer to do it explicitly.

Yeah, this is a good call. Added an assert.

bors r+

(I assume that your previous comment meant "r+ with 16 bit cleannes infromed". If that's not the case, feel free to r+ a counter-pr :) )


fix: page not get reset after filter changes

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Closes #6853
[ ] Requires deployment <snek/rubick/worker>

Why use useRoute?
The $route provided in useNuxtApp() has a bug where it doesn't get updated when the page parameter in the URL is updated (https://github.com/nuxt/nuxt/issues/13032), replacing it with useRoute fixes this.
Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality

Optional

[ ] I've tested it at </ksm/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Did your issue had any of the "$" label on it?

[x] Fill up your DOT address: Payout

Community participation

[x] Are you at KodaDot Ecosystem Telegram?

Screenshot 📸

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 77548c9
Refactored History.vue to use Vue Router 4 and pagination. This improves the performance and usability of the profile history tab.

🤖 Generated by Copilot at 77548c9

History.vue changed
Vue Router 4 and pagination
Autumn leaves fall fast

pay 50 usd

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.24 USD/DOT ~ 11.792 $DOT
🧗 1CAv6Zq3yVxL3eKhC94GWTWVwp1w4jZbqeZ6wXx1rPAhrce
🔗 0xc86b3de30f9141f1afba407a2337894a3e36b762a3fe17e55f74ae0786f62fa1
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Fly mode from inside a string

I often use the fly mode and it works great. It doesn't work inside strings and I understand why but wonder if it would be possible to configure so that it does? In other plugins it worked and I had to do ctrl-v) to add a ')' inside a string because otherwise I would jump to the wrapping ).
If possible I would appreciate a config example. I'm guessing you could use "list_of_characters" but I'm not sure how.

Might be that these two are working against each other and I'm just not understanding but now when I'm writing normal text in markdown and I hit ' I get '' which I didn't get before. Can I get both?

Can you elaborate more specifically: can't reproduce glitch.

Before I only ran the setup function without any options:
use {
	'altermo/ultimate-autopair.nvim',
	event = { 'InsertEnter', 'CmdlineEnter' },
	config = function()
		require('ultimate-autopair').setup({
			-- extensions = {
			-- 	{ 'fly', { ')', '}', ']', ' ', "'", '"', nofilter = true } },
			-- }
		})
	end,
}

Now when writing in markdown files, I can write something like: That's nice without getting an extra ' in the end. However when I'm in code and I have something like require('ultimate-autopair|') (caret at "|"), if I hit ) I would get require('ultimate-autopair)') instead of jumping out: require('ultimate-autopair')|.
If I uncomment the option you gave me above I can jump out of require('ultimate-autopair') but when I write markdown I get That'' or rather That's nice' because I would continue writing after the first ' but the second one would be at the end when I'm done writing.

Well... The current way to configure built-in extensions is stupid: When setting extension you overwrite the builtin extensions and thus need to include all the builtin extensions in the config (probably should fix this).
So width that in mind:
use{
    'altermo/ultimate-autopair.nvim',
    event={'InsertEnter','CmdlineEnter'},
    config=function ()
        require('ultimate-autopair').setup({
            extensions={
                {'cmdtype',{'/','?','@'}},
                'multichar',
                'string',
                {'treenode',{inside={'comment'}}},
                {'escape',{filter=true}},
                'rules',
                'filetype',
                {'alpha',{before={"'"}}},
                {'suround',{'"',"'"}},
                {'fly',{')','}',']',' ',"'",'"',nofilter=true}},
            },
        })
    end,
}

Ah, yes, that makes it a little harder BUT your above config seems to work. Thanks!

I'm writing in this closed issue because I'm getting the following when I'm opening neovim:
|| ultimate-autopair:
|| Old configuration detected
|| The problem:
|| extensions option needs updating (aborting)
|| packer.nvim: Error running config for ultimate-autopair.nvim: ...vim/lua/ultimate-autopair/configs/default/utils/init.lua:44: attempt to compare two nil values

Here's my current config again which you helped me with above:
require('ultimate-autopair').setup({
	extensions = {
		{ 'cmdtype',  { '/', '?', '@' } },
		'multichar',
		'string',
		{ 'treenode', { inside = { 'comment' } } },
		{ 'escape',   { filter = true } },
		'rules',
		'filetype',
		{ 'alpha',   { before = { "'" } } },
		{ 'suround', { '"', "'" } },
		{ 'fly',     { ')', '}', ']', ' ', "'", '"', nofilter = true } },
	},
})


docker-pm2 vs pm2 + node in docker

Hello, this is more of a question.  What is the difference between using this module vs using regular pm2 and node in docker?  In other words, if I use your keymetrics/pm2:10-alpine, what's the benefit compared to using pm2 and node 10.x on Apline in docker container?
Thanks!

There's only 1 difference: you get more recent versions of packages if you do not use keymetrics/pm2 docker images.


2015 FRQ

2015 FRQ Answer

[x] Question 1
[x] Question 2
[x] Question 3
[x] Question 4

Connections
I have the same connections on the respective question blog
Question 1
Question 1 is about traversing and manipulating arrays and 2D arrays. Part A of the question asks to manipulate a one dimensional array or iterate through it to add up all the values in the array. A similar action in seen in the initialization of data in person database in the person.java file, where an array of type  person object is iterated over and added to the database as seen in the image below.

Question 1 part B and C have aspects of manipulating 2D arrays and 1D arrays. A similarity is seen in the way 2D arrays were used in this question as a look up table of sorts. The question made us use the rows as keys and the columns in those specific rows as values. A similarity is seen in the Map data structure that I used in the project to associate keys and vlaues as seen in the image below. Though 2D arrays and Map are two diffrent data structure they are similar in their theme of the way they are being used. For a 2D array, you might use the first dimension as a key and the second dimension as a value (though this is somewhat unconventional). Maps are naturally suited for this purpose, with clear key-value relationships and that is why I use Maps more as they are flexibility with dynamic sizing unlike 2D arrays which are more fixed in size. This is important in the working of the database as with the stocks data and also person the size can be very large.
I used Map in the personAPIController.java file for some of the api endpoint working as seen below -

Question 2 and 3
In Question 2 and at various places we use for loops nested if statements. For example, the modleinit.java file uses for loops with nested if statements to create databse entries and also assign roles to the person created.

Moreover, One difference consistent in all the questions and the project, especially Question 2, are the constructors. Because we use AllArgsConstructor and NoArgsConstructor from the Lombook library we do not need to make constructors, decreasing boilerplate code and making our code more clean.

Question 4
through out the project files at various places overide has been used to change specfic class methods to match out databse and requirements. One of the examples in the CustonDateSerialize.java file. Here the method deserialize is overriden from the calss StdDeserializer. The smae file also uses other polymorphing actions such as extending the StdDeserializer function.  Just as CustomDateDeserializer adapts the behavior of JSON deserialization to suit specific formatting requirements, the classes in question 4 (e.g., Range and MultipleGroups) implement or extend predefined behaviors (contains method from the NumberGroup interface) to fulfill specific contracts or interfaces.

Crossover Reviews - Adi

Note: We demonstrated running code in notebooks to verify functionality

FRQ #
Comments
Score

1
Code runs as expected and FRQ type correctly identified
1.1/0.9

2
Code runs as expected and FRQ type correctly identified
1.1/0.9

3
Code runs as expected and FRQ type correctly identified
0.9/0.9

4
Code runs as expected and FRQ type correctly identified
0.9/0.9

Overall
Combined score for 1.1 scale FRQs
4.0/3.6

Association Comments:
I appreciate including the context of the problem in your associations to give a brief summary for people who did not do the problems (Mr. Mort). I particularly liked how you took note of not only similarities but also the differences between the problems and your project, which shows a strong understanding of the content and more.
One suggestion I have to make this association really stand out is to add an overall reflection with your future plans regarding the course. Overall, great job. ⭐ ⭐ ⭐ ⭐ ⭐ ⭐ ⭐ ⭐ ⭐ ⭐
Association Score:
Overall, I would give you a 3.6/3.6 for your FRQ Association.

Crossover Reviews Reflection
Grading

I feel that I graded as fairly as I could. checking the output and code by copying and running it on my own code block. This helped check the code and also see if the runtime is correct.

Learning

Seeing different approaches to problems is useful for learning new methods
i.e. StringBuilder or using Char
This was useful in comparing outlooks and trying to change the mindset while approching these types of problems

Future Plans

Suggested to do more FRQs for learning and solidifying syntax
I am very, very excited to work with larger teams!


Add API Endpoints for GitHub integration for app creation, repository, and branch management

Add GitHub controller to manage GitHub apps, repositories, and branches

New routes for GitHub app management:

POST /github-apps: Create a new GitHub app
GET /github-apps/{github_app_id}/repositories: Load all repositories for a specific GitHub app
GET /github-apps/{github_app_id}/repositories/{owner}/{repo}/branches: Load all branches for a specific repository

Applied IgnoreReadOnlyApiToken middleware to all routes

This feature enables users to create GitHub apps, view repositories, and access repository branches.

This PR is the same as https://github.com/coollabsio/coolify/pull/3921 I think you have selected the worng branch.

Yes 🫥

So both changes are now in one PR right?

I want to have to seperate PR

yes both are in one #3921 . Ok thank you

I have closed this PR  and change the title of the fist PR #3921 and also change the details comment. Is it OK now

Perfect thanks


Spi speedup - first part - fine and coarse grain phase difference addition

Some minor nits, but I think we def need to write a sentence or two commentary on the different types of delay, and update the DTS string


Add RFC for Arrow Flight connector

Thanks for the proposal @elbinpallimalilibm , I think it sound like a useful addition. You hit on the main benefits already, with Flight being a standard RPC protocol, that would open up Presto to connect with any data source that is reachable by a Flight endpoint. Performance-wise, there can definitely be benefits, such as connecting to a PostgreSQL Flight endpoint where data is transferred in Arrow format. However, there are also cases where there might not be any benefit, e.g. connecting with a JDBC-based data source there will be overhead converting rows to columns.
Some questions:

Will this include other SQL operations besides reading data, such as update, delete, etc?
I think there needs to be more details about the FlightDescriptor. I see you mention JSON, however that puts a restriction on the Flight server to accept that format. There is also a lot that would need to be defined in order to use that command to implement the Presto connector interfaces, for example how will list tables?
Have you considered using a FlightSQL client? The FlightSQL protocol defines a way for a client to interact with SQL-based data sources, so this provides a standard with commands to list tables, etc. already baked in. The downside is the Flight server would need to implement FlightSQL, not just core Flight.

Ah, so (1) this is for Presto consuming data from other sources, not Presto serving Arrow data over Flight and (2) this is for generic Flight and not Flight SQL?
Since, I believe services advertising Flight support are generally doing so via Flight SQL (examples: InfluxDB, Dremio, and the PostgreSQL adapter). Flight SQL also is an actual service definition vs Flight which is more a grab bag of patterns and suggestions for building a service.

Thanks for the proposal @elbinpallimalilibm , I think it sound like a useful addition. You hit on the main benefits already, with Flight being a standard RPC protocol, that would open up Presto to connect with any data source that is reachable by a Flight endpoint. Performance-wise, there can definitely be benefits, such as connecting to a PostgreSQL Flight endpoint where data is transferred in Arrow format. However, there are also cases where there might not be any benefit, e.g. connecting with a JDBC-based data source there will be overhead converting rows to columns.
Some questions:

Will this include other SQL operations besides reading data, such as update, delete, etc?
I think there needs to be more details about the FlightDescriptor. I see you mention JSON, however that puts a restriction on the Flight server to accept that format. There is also a lot that would need to be defined in order to use that command to implement the Presto connector interfaces, for example how will list tables?
Have you considered using a FlightSQL client? The FlightSQL protocol defines a way for a client to interact with SQL-based data sources, so this provides a standard with commands to list tables, etc. already baked in. The downside is the Flight server would need to implement FlightSQL, not just core Flight.

This proposal is only for reading data. Insert, update, delete are not supported.

Ok, that sounds reasonable to me. (...I'd like to get away from Flight itself being such a heavy wrapper over things, but that's a long ways away.)

@elharo

High level meta comment: we'd like to move some of the existing connectors out of the main repo, and in general make builds more modular. This might make a good test project for that goal. Could this connector be implemented in a completely separate repository? If not, why not?

Just for your information, this is something we've discussed before and there's already alignment on pursuing this.  I think we just need someone to spend the effort to move plugins out of the main repo and setup build pipelines for each.  That being said, I don't think it's necessary or advisable to couple these two initiatives, as I think this effort deserves its own focus.

This proposal is only for reading data. Insert, update, delete are not supported.

Just curious, is the limitation here that Presto's "connectors" are specifically for Presto connecting to other data sources rather than for consumers interacting with Presto?
Would it make sense to have a separate proposal to add Arrow FlightSQL as a way for users to interact with Presto itself and retrieve column-oriented data to avoid the column->row overhead? (Correct me if i'm wrong, Presto is internally columnar for execution, right?)

@zeroshade as you mentioned, I think this proposal is for Presto itself to interact with Arrow-like systems.  In the future, we could implement support for updates and deletes on top of this proposal.
A separate thing altogether is Arrow FlightSQL support to supplant, or replace, Presto's client protocol.  This has been discussed before (see https://github.com/prestodb/presto/issues/19419), and I believe there's alignment to support that, it just needs someone to pick up this work and come up with a comprehensive design.  That ought to be separate RFC.
What this client-oriented RFC would buy us is, client's wouldn't have to go through the inconvenience of translating row-oriented JSON into Arrow buffers, however I don't think there would be a major performance improvement by doing this, because Presto's client architecture is already bottlenecked by the a single coordinator process, which limits parallelism and makes Presto not very suitable for very large reads.  A larger effort might entail perhaps moving fetching from the coordinator to workers, to give the client greater flexibility in the level of parallelism on fetching the data.  This effort of increasing parallelism for the reads has long been planned.  As part of an effort to move toward Arrow Flight, this might entail exposing Tickets for each worker.
I hope this context is helpful.

High level meta comment: we'd like to move some of the existing connectors out of the main repo, and in general make builds more modular. This might make a good test project for that goal. Could this connector be implemented in a completely separate repository? If not, why not?
Second meta comment, especially if this connector does need to belong to this repo: presto has noticeable problems with connectors that were contributed and then abandoned by their initial implementers. How much support does this have by whom? How long can we count on that support?

IBM will continue to support and maintain the Arrow Flight connector.

Thanks for this RFC. Would be great if you add more detail about Velox/Prestissimo design as well.

Yes, we are working on the details for Prestissimo. Will add that here.