Add Algorand (ALGO)

Currency name: Algorand
Symbol: ALGO
Website: https://www.algorand.com/
Theme color: ??
Logo (SVG): https://cryptologos.cc/logos/algorand-algo-logo.svg?v=001

Already requested on #341

true. i'll close this, and hope yours get merged soon


Merge feat/danque to feature/matrix

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: czmjbl:x: Xiadong Zhu:x: xdatcloudXiadong Zhu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[VS Code] Joining collaboration session: Could not join the collaboration session as it has already reached the maximum of 5 participants.

Error:
Joining collaboration session: Could not join the collaboration session as it has already reached the maximum of 5 participants.
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
0.3.1182

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.24.1

platformName
Linux

platformVersion
4.15.0-42-generic

@marcobarrosweb Thanks for reaching out. There is a setting to increase the number of participants to 30, please follow the instructions here https://github.com/MicrosoftDocs/live-share/releases/tag/0.3.788 (Feature Enhancements #1)
@lostintangent Do we want to enable the 30 limit by default?

Yeah I think we want to enable this setting by default moving forward. We can use this issue to track that change.


#eval String.fromUTF8Unchecked (ByteArray.mk #[0xab, 0xea]) hangs

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.
Reduced the issue to a self-contained, reproducible test case.

Description
This program hangs the LSP server in VS Code:
#eval String.fromUTF8Unchecked (ByteArray.mk #[0xab, 0xea])

Sebastian says: "Oh that's funny, it looks like it overshoots the following condition, trapping itself in an infinite loop:
https://github.com/leanprover/lean4/blob/185829d089080b290c012adb380beddfd49a4712/src/Init/Data/String/Basic.lean#L312
Steps to Reproduce
See above.
Expected behavior:
It should return the valid bytes that could be decoded from UTF-8 and drop the bytes that cannot be.
Actual behavior:
Hang.
Reproduces how often: 100%
Versions
You can get this information from copy and pasting the output of lean --version,
please include the OS and what version of the OS you're running.
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

See https://github.com/leanprover/lean4/issues/1462

cool, now when you fix it you can close 2 issues...

We have a "duplicate" button for that :)

But hang on this doesn't seem to be a bug in the name of fromUTF8Unchecked, instead it's a bug in https://github.com/leanprover/lean4/blob/185829d089080b290c012adb380beddfd49a4712/src/Init/Data/String/Basic.lean#L312 right?

The linked issue removes the primary(*) way to create a String that is not valid UTF-8. Under the, very reasonable, assumption that such strings do not exist (like Rust makes), that implementation is correct.
(*) There are probably some IO functions like lean_io_prim_handle_get_line that we should harden as well

I see so you are saying the new fromUTF8 would never return an invalid UTF-8 encoding in a string and that would stop this foldlAux`` from ever getting stuck while folding strings?  I guess the problem with foldlAux` is that this returns 4
#eval (String.fromUTF8Unchecked (ByteArray.mk #[0xab, 0xea])).next {byteIdx := 1}

which is off the end of the sting, so it never hits if i == stopPos then a, but if we changed this to if i >= stopPos then a then it would never get stuck no matter where the string came from... you don't think that's also a safe fix?

I guess the problem is there's a LOT of pos == stopPos tests in Basic.lean and we'd have to fix all of them...


adding httptrace package

hello folks,
Thank you for your wonderful work on TinyGo.
I am trying to update one of my app from TinyGo 1.29 to 1.31.x, and running into a problem because package net/http/httptrace no longer exists. an issue in TinyGo repo has been reported for this here: https://github.com/tinygo-org/tinygo/issues/4186
is there any objection (or obvious known blockers) to adding the package in this repo? I am happy to try to submit a PR for that if this is ok to add.
many thanks for considering
Rajat Jindal

There is a possibility that this might not work, in which case, I was thinking we can just stub out the exported functions. This will atleast allow the compilation to succeed.

This does introduce the problem that code that works with Big Go will compile but fail to actually work with TinyGo, which seems more dangerous than having to reimplement bits of httputil/httptrace in your own code though 😅

I would not mind a stubbed version of httptrace. we have other stubs, and so far I have also run into it as a dependency in packages that would otherwise work, such as upgrading to the latest paho mqtt package.


Concurrent branch merge into master

Redesigned server now works perfectly.

Sorry guys, accidentally open this. I wanted to pull into my own branch.


Client stuck in STATE_INITIAL

I had a client with Security object instances for a bootstrap server and a standard server, but no Server object instances. In this case I would expect it to bootstrap, however it never left STATE_INITIAL. This was because object_getServers (called from prv_refreshServerList) was returning -1 when it encountered the Security object instance for the standard server without a corresponding Server object instance. I think it should skip over any invalid servers and process all the Security object instances and only return an error if there are no good bootstrap or standard servers.

Hi,
The initial consideration was: if the configuration is flawed, the lwm2m_step() function returns an error.
However, with recent LwM2M specification changes, the configuration you describe is valid.
Regards,

Proposed fix in #280

It looks like that will fix the issue I encountered,
I am still concerned that a single misconfigured instance could render a device unusable. That sounds like a design decision for Wakaama that will need to be handled by the application.


Potential Issue with CurrHF and CurrINF Relationship After Decoding

Hi everyone,
CC: @jcp19
While proving the correctness of the router in the context of VerifiedSCION, I tried to confirm that the current Infofield (CurrINF) and the current Hopfield (CurrHF) point to the same segment after decoding. Within the codebase, there exists the following function:
func (s *Base) infIndexForHF(hf uint8) uint8 {
	switch {
	case hf < s.PathMeta.SegLen[0]:
		return 0
	case hf < s.PathMeta.SegLen[0]+s.PathMeta.SegLen[1]:
		return 1
	default:
		return 2
	}
}

However, this function is only used in incPath, which is called either when the packet leaves the AS or a segment switch is performed. This happens very late in the processing of a packet. This could lead to potential problems in the router. In particular, the checks validateHopExpiry() and verifyCurrentMAC() could be performed with the wrong Infofield.
I am not sure if it is possible to satisfy verifyCurrentMAC() in this way, but if it is, the router would incorrectly perform an xover step, which is not supposed to happen.
So far, I haven't found a concrete counterexample, but it seems that the missing check can have a significant impact. Do you think such a check is necessary, or was it intentionally left out?
Thank you for your help.

More generally, at the moment, the router seems to assume that the path is valid if parsePath returns successfully. After that point, the router might use that path, e.g., it may reverse it and use the result as the path of a SCMP packet. If we don't check the property above, the router might essentially produce packets with invalid paths.

As the info field and hop field information together is protected by the MAC, I think that this can't be exploited to circumvent path authorization. Still, I agree that it would seem prudent to check for this, to avoid forwarding (or replying to) packets with malformed path data.
We already have a issue to add general validation to the parsing layer, https://github.com/scionproto/scion/issues/4278. I've updated that to note that CurrHF should be checked to be in range for the CurrINF. In the meantime, it would seem appropriate to add a specific check for this into parsePath, as you're alluding to.
By the way; the path parser currently rejects truncated paths (length shorter than required for indicated number of hop fields), but allows longer paths (i.e paths with trailing garbage). I wonder if this should be forbidden for the same reason.

Fixed by #4556


Add newlines option to newline-after-import

My team likes to maintain two newlines after import statements instead of just one. In the interest of making that convention enforceable, these changes add a newlines option to the newline-after-import rule. This option defaults to 1 to maintain full backwards compatibility.

Coverage increased (+0.003%) to 94.915% when pulling 2ced295b6ff3d4d8b4313db38b1c2179651ebb46 on ntdb:newline-after-import into 0800951f40a8cd4f6459a09904be46e93372f380 on benmosher:master.

That history is super messy, apparently I should have reset my fork before making these changes. Hopefully I can open a new PR without the mess shortly.

Coverage increased (+0.003%) to 94.915% when pulling 2ced295b6ff3d4d8b4313db38b1c2179651ebb46 on ntdb:newline-after-import into 0800951f40a8cd4f6459a09904be46e93372f380 on benmosher:master.

@ntdb please don't open a new PR; if you rebase this branch on top of the latest master and force push, it should be cleaned up.

Coverage increased (+0.003%) to 94.915% when pulling c3ed12629ffb5a48673df3c1093f5ebfdd9b428a on ntdb:newline-after-import into 0800951f40a8cd4f6459a09904be46e93372f380 on benmosher:master.

@ntdb if source is the git remote for this repo, and origin is for your fork, run git fetch source && git checkout master && git reset --hard source/master && git push origin source/master:master -f && git checkout newline-after-import && git rebase source/master && git push origin newline-after-import -f.
After that (or amidst that if you get merge conflicts), you may want to edit the changelog so that you're not removing existing entries.

Coverage increased (+0.003%) to 94.915% when pulling 8fe720e33e31b7214518ca3c25e5470e0adee985 on ntdb:newline-after-import into 0800951f40a8cd4f6459a09904be46e93372f380 on benmosher:master.

I learned some very useful things about git tonight, thanks @ljharb.

Coverage increased (+0.003%) to 94.915% when pulling 8c7ea26ab9d49d27c61f2bc009f40d4f35077c8e on ntdb:newline-after-import into 0800951f40a8cd4f6459a09904be46e93372f380 on benmosher:master.

Coverage increased (+0.003%) to 94.915% when pulling 8c7ea26ab9d49d27c61f2bc009f40d4f35077c8e on ntdb:newline-after-import into 0800951f40a8cd4f6459a09904be46e93372f380 on benmosher:master.

Coverage increased (+0.003%) to 94.915% when pulling 1d757dcc15c86260f258edee04d583207f96b999 on ntdb:newline-after-import into 0800951f40a8cd4f6459a09904be46e93372f380 on benmosher:master.

Coverage increased (+0.003%) to 94.915% when pulling 1d757dcc15c86260f258edee04d583207f96b999 on ntdb:newline-after-import into 0800951f40a8cd4f6459a09904be46e93372f380 on benmosher:master.

Coverage increased (+0.003%) to 94.915% when pulling 1d757dcc15c86260f258edee04d583207f96b999 on ntdb:newline-after-import into 0800951f40a8cd4f6459a09904be46e93372f380 on benmosher:master.

@ljharb Thanks, I've added a schema/tests. 👍

@ntdb Nice job on the clean-up.
What do you think changing the option name to count? To me, this seems less repetitive and more explicitly descriptive.

@duncanbeevers I like it. Less repetitive, more explicit, and it sets a usable precedent for other rules with similar options.

Coverage increased (+0.003%) to 94.915% when pulling c0f733bfb7ce6a660801473d453e5289eee03369 on ntdb:newline-after-import into 0800951f40a8cd4f6459a09904be46e93372f380 on benmosher:master.

Coverage increased (+0.003%) to 94.915% when pulling 2323ece26dc640c9a67c0a90ab991b05f8d63c88 on ntdb:newline-after-import into 0800951f40a8cd4f6459a09904be46e93372f380 on benmosher:master.

Ugh, I just noticed there is already an auto-fixer PR for this rule, which now needs to be updated to handle this case https://github.com/benmosher/eslint-plugin-import/pull/696, sorry @eelyafi...

Coverage decreased (-1.3%) to 93.616% when pulling 49ea883c4e985453085af666b8bcb0cb0c641f27 on ntdb:newline-after-import into 0800951f40a8cd4f6459a09904be46e93372f380 on benmosher:master.

Coverage decreased (-1.3%) to 93.616% when pulling 49ea883c4e985453085af666b8bcb0cb0c641f27 on ntdb:newline-after-import into 0800951f40a8cd4f6459a09904be46e93372f380 on benmosher:master.

@jfmengels I'll open a new PR this weekend to update the auto-fixer. 👍


opt-refactor(torii-core): engine start health_check_provider

Description
@glihm Hi,I have submitted the PR, if you have time, please review it.

Related issue

close #2721
Tests

[x] Yes
[ ] No, because they aren't needed
[ ] No, because I need help

Added to documentation?

[ ] README.md
[ ] Dojo Book
[ ] No documentation needed

Checklist

[ ] I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
[ ] I've linted my code (scripts/clippy.sh, scripts/docs.sh)
[ ] I've commented my code
[ ] I've requested a review after addressing the comments

Summary by CodeRabbit
Summary by CodeRabbit

New Features

Introduced a health check for the provider to ensure operational status before data fetching begins.
Added an asynchronous function to check the health of the provider and log the latest block information.

Bug Fixes

Improved error logging when fetching data from IPFS, capturing detailed error information.

@glihm  Hi,I found that when I don't start Katana, Sozo also has the same error. Is it necessary to optimize it together.
➜  dojo-starter git:(main) ✗ sozo migrate
error: EOF while parsing a value at line 1 column 0
➜  dojo-starter git:(main) ✗ sozo migrate
error: EOF while parsing a value at line 1 column 0
➜  dojo-starter git:(main) ✗ sozo inspect
error: EOF while parsing a value at line 1 column 0
➜  dojo-starter git:(main) ✗ sozo migrate
error: EOF while parsing a value at line 1 column 0
➜  dojo-starter git:(main) ✗

@847850277 thanks for the fixes! For sozo, go ahead! Perhaps at some point we could factorize this health check though.

@847850277 we may have this into the dojo/utils crate where we already have some provider related stuff, wdyt?

Thanks for the work here @847850277, devX is better in case of failing. If doing it on Sozo in an other PR, could you consider the factorisation of the code in charge of checking the health of the provider?

Of course, I would be happy to do it！I would like to ask, what is devX?


Allow set style to content selected.

Close #413
Close #1007

To-Do

[ ] Add unit tests

To address in additional PRs
WIP List: If we decide to go on this way to fix the above mentioned issues, let's address anything out of the scope of that in other PRs to avoid big PRs and to consider that we have a bunch of issues on text styles to still work.

[ ] Add a mechanism to define the default font-weight when configuring the bold and regular aspects of a given text style (Specs on it will be complex and still under definition, so maybe will be better address this in other PR. Thoughts?)

Closing this PR in sync with the discussions here. The issues mentioned potentially will be fixed as soon as we decide the new approach for text styling, but if needed we can re-open.


✨ Enhance Rate Us

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Hello Project Admin
I would like to Enhance Rate us page by adding Toastify Message and also some hover Effects
Can you assign me this issue under GSSOC'24
Use Case
It will increase user Experience
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

/assign @sailaja-adapa


tab width?

Is there a way to change the tab  width?

Nope, that's (currently) hard-coded in https://github.com/troglobit/mg/blob/master/src/display.c#L310 tob stop at each multiple of 8 chars.

Ok, Thanks.


updated property name for babel

Looks like babel updated their config name for brunch to ESbabel, this worked for me, the older didn't.

Uh, nope. The original plugin config key was ES6to5, but now it's just babel
https://github.com/babel/babel-brunch/blob/master/index.js#L9

ah, yes thx, so they have to update their docs then:
https://babeljs.io/docs/setup/#brunch


1.21 Update

1.21 Update

Changed the necessary things to update to version 1.21.

I'll get a release out tomorrow (need to install java 21 lol), thanks!


Feature run pre post scripts

PreRunDirty & PostRunDirty attributes added to bob task
Pre run cmds and Post run cmds are being run before and after running the final task
git-pre-post-run task added to bob playground as an example of Pre and Post cmds
prerun and postrun tests implemented using git-pre-post-run task on build-test

hmm the issue was about to add pre&post hooks to bob run https://github.com/benchkram/bob/issues/32 . This PR adds them to bob build.


Omit 'Web Access' link for files untracked by most gitignores

Closes #169
File with obj path segment:

File without obj path segment:

@KirillOsenkov This was the last thing I was planning to look into in the near future.

Published https://www.nuget.org/packages/SourceBrowser/1.0.35.
Thanks for stopping by and do come and visit us again sometime!

@KirillOsenkov I won't hesitate if I think of something. Will source.dot.net etc pick up the new build? It would improve the dark mode arrows.

@alexperovich merges into his fork periodically, so hopefully in the near future

Either something is wrong with my robocopy /MIR or I didn't actually fix dark mode arrows properly (all the other changes came through):

Try https://github.com/KirillOsenkov/ContentSync, but carefully read the command-line help first :)
It was made precisely for the task of incrementally copying Index directories.

Also check the browser cache or server cache maybe.

Clearing my browser cache fixed it.


Locust  - A1 - [MQTT] - Check the solution for testing used on version 0.5.0

Study the code developed for load tests in dojot (https://github.com/dojot/dojot/tree/development/connector/mqtt/locust), build slides explaining the test flow (step-by-step of what it is done, for example, 1- devices created, 2- certificates generated, 3- certificates associated with the devices, 4- publishes a message with data X every Y seconds…), set up a demonstration with 100 devices and perform a presentation and demonstration.

Won't be done.


Need to update WebView docs messaging

Based on this PR, we need to modify the WebView docs with similar messaging.

hopefully, this solves it


How can I test 16bit gray images with ESRGAN model?

hi, thank you for your excellent work. Is it possible to test 16bit gray images  with the model? How?
Thank you for your time.

I am not familiar with it. Maybe you should finetune the model to support 16bit gray images~


tests: verify system assert when add wrong mem partition

Add test that verifies system will assert that the size and
starting address are compatible with the underlying memory management
system.
I faced with some difficulties:

I found a correct assertion which is responisble for that action
in /zephyr/kernel/mem_domain.c L153

I tried to add a wrong partition to a memory domain,
and system will assert if the size and address are compatible
with the underlying memory management system.

For x86 it is possible to trigger that assertion by
setting start addr equal 1 and size equal 0 like:
K_MEM_PARTITION_DEFINE(wrong_part, 1, 0, K_MEM_PARTITION_P_RW_U_RW);

For the ARM if to make the same action, I can't
compile the program, so unfortunately I can't port that test
to another architectures.

Looking for a comments from other developers, maybe you have another
opinion on that test and my approach. Maybe just keep that test only for x86, and for another architectures skip that test like in my code there.
Signed-off-by: Maksim Masalski<EMAIL_ADDRESS>

@andrewboie Please help me with that PR. Because I don't know how to trigger test for another architecture except of the x86.

you need to rebase this PR

you need to rebase this PR

For some PRs as I understand Github already notifies that it is necessary to rebase, should I rebase PRs, where is not that notification too?

you need to rebase this PR

Done

I don't think we should be testing against assertions either. There's already a bug open to have the mem domain APIs return error values if bad partitions are passed in, #24609 I think we should fix that instead and amend tests to check return values.
This PR tests behavior that is essentially a bug.

Understood.

PR closed till the issue https://github.com/zephyrproject-rtos/zephyr/issues/24609 won't be closed
After solving that issue, I will reopen PR.


use @variable instead variable in template

Hi @DavidS any chance I could get this one merged?  Ta.


ImportError: cannot import name 'ByoModelCfg'[BUG] Issue title...

----> 1 from timm.models import ByoModelCfg, ByoBlockCfg, ByobNet
2
3 from ._base import EncoderMixin
4 import torch.nn as nn
5
ImportError: cannot import name 'ByoModelCfg'

@onlinehuazai you probably have an old version of timm in your environment, works fine with latest


Create coreman000

ID4 Challenge coreman000

Marking closed as valid submissions are in another PR.

Marking closed as valid submissions are in another PR.


Update aws-java-sdk to 1.12.765

About this PR
📦 Updates com.amazonaws:aws-java-sdk from 1.12.761 to 1.12.765
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk" }
}]

labels: test-library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #1012.


Issue89

changed metamodel._parser --> metamodel._parser_blueprint
changed CHANGELOG

As mid-term goal we could provide a howto-page or a cheat-sheet page, with

Howto-Questions (like "how to get the position of a model element in the input file", "how to model a float", ...)
and links into unittests

What do you think of that?

Looks good. Feel free to merge.
Yes, I agree. Howto or FAQ page in the docs would be nice to have. A question with link to the unit test and/or issue with discussion. There is a lot of useful info in the tests and closed issues.


User Personas

Figma template: https://www.figma.com/file/KXyOex2lUeb2BxK3EecRdDM6/User_Persona?node-id=0%3A1

https://xtensio.com/user-persona/

18f card: https://methods.18f.gov/decide/personas/

To the extent it's useful, Sunlight Foundation has done some documentation of Madion, Wisconsin user personas and are collecting additional personas.


Use the same screen for superhero and league.aeternity

I will also add a preloader, because now switch from create room page and the current room page is not so smooth.

we also discuss with @davidyuk about memory leak because I didn't unsubscribe RPC listener

@mradkov https://github.com/aeternity/superhero-ui/pull/659#pullrequestreview-435217201

@mradkov Please check this question #659 (review)
It use league.aeternity.org domain. What should I use?

test.league.aeternity.org is ok for now.

@davidyuk
git reset develop
git add .
git commit -m "..."
Please, can you have a look?

@davidyuk it looks like I remove some files. I will redo that.

I guess it's better now

I found out that deeplinks are not works properly with an iframe. I guess I need to open new tabs to achieve that.


Feature request: Option to move audio playback above score

When a song has multiple verses printed below the score, rather than embedded in the score, the separation between the beginnng of score and the audio playback bar can be great enough that a reader must scroll up and down to see both. This makes it difficult to start the playback while looking at the beginning of a score.
An option to place the playback bar above the score would be nice, and I suspect, relatively easy to implement...

Hi @kjcole, I have added a option namedd "controls" for that (see: https://sphinx-notes.github.io/lilypond/#control-bar-at-the-top).
You can build a package byself, or waiting for the release of 1.3

Thank you!  I'll try it out later today.

sphinxnotes-lilypond==1.3 lands this changes.


Setting InitContainerEnv

Is this a request for help?:
Yes, need help with a PR

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT
Version of Helm and Kubernetes:
Helm:
Client: &version.Version{SemVer:"v2.12.3", GitCommit:"eecf22f77df5f65c823aacd2dbd30ae6c65f186e", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.12.3", GitCommit:"eecf22f77df5f65c823aacd2dbd30ae6c65f186e", GitTreeState:"clean"}

Kubernetes:
Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.3", GitCommit:"a4529464e4629c21224b3d52edfe0ea91b072862", GitTreeState:"clean", BuildDate:"2018-09-10T11:44:36Z", GoVersion:"go1.11", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.5", GitCommit:"753b2dbc622f5cc417845f0ff8a77f539a4213ea", GitTreeState:"clean", BuildDate:"2018-11-26T14:31:35Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
stable/jenkins
What happened:
When my valuesFile contains InitContainerEnv helm returns the following error:
# helm lint -f ../jenkins-values.yml stable/jenkins

[ERROR] templates/jenkins-master-deployment.yaml: unable to parse YAML
        error converting YAML to JSON: yaml: line 47: mapping values are not allowed in this context

Looking at the most recent commits to the repository, I found this PR: https://github.com/helm/charts/pull/9057. I was able to see that the indentation in the filetemplates/jenkins-master-deployment.yaml seems to have changed from the previous version causing the linting to fail:
Previous Line:
https://github.com/helm/charts/commit/c3e8c0b17ac553752ad0b2eecea315b61d14ce15#diff-3186f811e401dee5654955efc1ba4d42L71
Changed Line:
https://github.com/helm/charts/commit/c3e8c0b17ac553752ad0b2eecea315b61d14ce15#diff-3186f811e401dee5654955efc1ba4d42R92
What you expected to happen:
I expected the helm install to work with the settings defined in the jenkins-values.yml file
How to reproduce it (as minimally and precisely as possible):
helm lint -f ../jenkins-values.yml stable/jenkins
See attached jenkins-values.yml:
jenkins-values.txt
Anything else we need to know:
I am opening a PR to fix the issue. I will link to this issue.

Good job on the quick fix :)
Feel free to close the issue if this is indeed fixed.

Issue is fixed. Closing


Custom partitioning APIs

Terrastore default partitioning strategy uses consistent hashing to balance
the distribution of documents among clusters and related nodes.
As a consequence, Terrastore users cannot implement custom data locality
strategies over the default consistent hashing partitioning.

Custom partitioning solves such a problem, by providing a pluggable
strategy-based API to implement for placing buckets and documents into
specific, user-defined, clusters and nodes.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 7 May 2010 at 5:10

Custom partitioning strategies can now be adopted by implementing the following
interface in the terrastore-version-api jar:
terrastore.partition.CustomPartitionerStrategy.

The CustomPartitionerStrategy implementation must be currently hooked into
terrastore-config.xml file; just configure your CustomPartitionerStrategy bean,
and
then locate the "Partitioner" beans and replace both with the following ones:

<bean id="ensemblePartitioner"
class="terrastore.partition.impl.EnsembleCustomPartitioner">
<constructor-arg ref="yourCustomPartitionerStrategy"/>
</bean>

<bean id="clusterPartitioner"
class="terrastore.partition.impl.ClusterCustomPartitioner">
<constructor-arg ref="yourCustomPartitionerStrategy"/>
</bean>

I'm still investigating an easier way to configure custom partitioning.
Feedback is welcome!

Original comment by<EMAIL_ADDRESS>on 7 May 2010 at 5:18

Implemented, see:
http://groups.google.com/group/terrastore-discussions/t/c51e89669c3451a6

Original comment by<EMAIL_ADDRESS>on 10 May 2010 at 5:34

Changed state: Fixed

[deleted comment]


Changing the playback time period during video playback？

i want like this when i playing video:   player.update(start: const Duration(seconds: 5),
end: const Duration(minutes: 1),);

No.


Fixed truncation to take bytesize into account

Some Unicode characters have more than one char of size (for example '–'). So the size is not calculated correctly in truncation.

Hi there. Thanks for PR. It’s missing tests to demonstrate what has been fixed. Would you mind adding them?

@madrobby Well, i added specs, but they are failing on the ancient versions of ruby. What's funny that 1.9.2 and 1.8.7 are not even installing on CI (see errors: Requested binary installation but no rubies are available to download, consider skipping --binary flag.).
What should be done here?

To me, this PR changes the behavior described in the documentation:
Zaru.sanitize! "A"*400, :padding => 100
# resulting filename is 145 characters long

which mentions characters and not bytes, either this is a breaking change or this may be a new option like :padding_byte or truncate_bytes (as in active_support)


WiFi Module: added 3rd Page to configure System Options

Some users have started to receive their wifi modules and are unable to ssh into goggles.  This is due to a OS root password bug which relates to /etc/passwd and the shadowing of the password not being setup properly.
New 3rd Page has been added which allows users to configure the root password and enable/disable SSH access (defaults to disabled).

Ignore the first commit as we now have a dedicated page which allows the user to set their own root password and enable/disable ssh access.

Just like we can set the wifi ssid and password with a text file on the sd card, it could be nice to setup ssh the same way too, for consistency.
For instance:
[ssh]
password=my_pass

And it could work like this « if the [ssh] block is present, then ssh is enabled, otherwise it’s disabled »

Just like we can set the wifi ssid and password with a text file on the sd card, it could be nice to setup ssh the same way too, for consistency.
For instance:
[ssh]
password=my_pass

And it could work like this « if the [ssh] block is present, then ssh is enabled, otherwise it’s disabled »

The text file was deprecated in favor for the dedicated WiFi Module page.


port part of external_cmd_selector

Signed-off-by: kosuke murakami<EMAIL_ADDRESS>Description
port

[x]  autoware_vehicle_msgs::msg::ShiftStamped -> autoware_auto_vehicle_msgs::msg::GearCommand

pending since there are no compatible msgs in autoware.auto

[ ]  autoware_control_msgs::srv::ExternalCommandSelect
[ ]  autoware_control_msgs::msg::ExternalCommandSelectorMode
[ ]  autoware_vehicle_msgs::msg::TurnSignal, lasck of hazard
[ ]  autoware_external_api_msgs::msg::Heartbeat,
[ ]  autoware_external_api_msgs::msg::ControlCommandStamped,
[ ]  autoware_external_api_msgs::msg::GearShiftStamped,
[ ]  autoware_external_api_msgs::msg::TurnSignalStamped,
[ ]  autoware_external_api_msgs::msg::Heartbeat,

Review Procedure

Remarks

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[ ] Read pull request guidelines
[ ] Code follows coding guidelines
[ ] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code follows coding guidelines
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets
[ ] Write release notes

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the guidelines.
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

また、autoware_vehicle_msgs::msg::TurnSignal は TurnIndicatorsCommand と HazardLightsCommand に分割することになっていたと思います。（vehicle_cmd_gate 側でも対応が必要ですね……。）

 autoware_vehicle_msgs::msg::TurnSignal　は現在auto側でhazardの情報がないため、互換性がないと判断しポーティングをskipしています。
堀部さんから現在互換性のあるものだけ一旦移して欲しい、と言われているためこのようなPRになっています。

@k0suke-murakami
can you Re force push again? I accidentally push to external command selector commit not external command converter

Build and test for PR:
depends on https://github.com/tier4/AutowareArchitectureProposal_msgs/pull/7


Remove unnecessary line as already included in panda_controllers.yaml

Description
The line is already included in panda_controllers.yaml
https://github.com/ros-planning/moveit_resources/blob/galactic/panda_moveit_config/config/panda_controllers.yaml#L6
Removing to avoid confusion
Checklist

[ ] Required by CI: Code is auto formatted using clang-format
[ ] While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

These are two different parameters, aren't they?

Yes they are different parameters, but is one redundant / don't they have to be equal to each other?
https://github.com/rcywongaa/moveit2_tutorials/blob/galactic/doc/tutorials/quickstart_in_rviz/launch/demo.launch.py#L78-L84
    moveit_simple_controllers_yaml = load_yaml(
        "moveit_resources_panda_moveit_config", "config/panda_controllers.yaml"
    )
    moveit_controllers = {
        "moveit_simple_controller_manager": moveit_simple_controllers_yaml,
        "moveit_controller_manager": "moveit_simple_controller_manager/MoveItSimpleControllerManager",
    }

We have params

moveit_simple_controller_manager.moveit_controller_manager: "moveit_simple_controller_manager/MoveItSimpleControllerManager"
moveit_controller_manager: "moveit_simple_controller_manager/MoveItSimpleControllerManager"

moveit_simple_controller_manager.moveit_controller_manager comes from
https://github.com/ros-planning/moveit_resources/blob/galactic/panda_moveit_config/config/panda_controllers.yaml#L6
moveit_controller_manager: moveit_simple_controller_manager/MoveItSimpleControllerManager

moveit_controller_manager comes from
https://github.com/rcywongaa/moveit2_tutorials/blob/galactic/doc/tutorials/quickstart_in_rviz/launch/demo.launch.py#L83
        "moveit_controller_manager": "moveit_simple_controller_manager/MoveItSimpleControllerManager",

Is one of these parameters redundant / fully determined by the other?
Sorry, still learning :bow:

You are right. The name of the controller manager plugin is already defined in the yaml. In ROS1, all parameters of the dictionary were loaded directly into the namespace of the node. Thus, I would expect something like:
    moveit_controllers = moveit_simple_controllers_yaml

to work. However, the way these parameters are read might have changed in ROS2.
If so, the line defining the plugin within the yaml file could be removed, I think. @henningkayser, can you comment?


Create openjdk10-openj9 builds which align with Oracle July 2018 quarterly update

There is currently no AO10/J9 release pipeline - will add one this week to complete this now that OpenJ9 0.9 has been released.

Release pipeline added in https://github.com/AdoptOpenJDK/openjdk-build/pull/438
I've also had to tweak the pipeline job as it was trying to copy a .zip file as an artifact on LInux/ppc64 instead of a tar.gz

In progress ... First time we've done a release build of this so there may be unexpected problems:
https://ci.adoptopenjdk.net/view/Pipelines/job/openjdk10_openj9_release_pipeline_scm/1/

Scheduling issue in the pipeline - running again as https://ci.adoptopenjdk.net/view/Pipelines/job/openjdk10_openj9_release_pipeline_scm/3

Had to seed the initial json files (https://github.com/AdoptOpenJDK/openjdk10-openj9-releases/commit/1e9fa83bfcfda1bf0108162def17abef4ff7e807) but the release of jdk-10.0.2+13_openj9_0.9.0 is now available. All platform downloads can be seen at https://adoptopenjdk.net/archive.html?variant=openjdk10&jvmVariant=openj9


Strict parsing dates?

I am trying to use parseDate to parse dates supplied by user, but I need to catch incorrect dates. While in some cases it is seems to be possible, in others, like date '1/12/123' - is not, due yy in en_US locale matching 12 and silently dropping 3...
Is there any way force strict matching of the value provided?

Right now there's no way to force strict matching. I think this feature would be welcome.


Blocks from RPC Poller sometimes are missing full receipt

Fixed here: https://github.com/streamingfast/firehose-ethereum/commit/7b2f668c2921adc292a29245ccf3362330b374d9
Pushed in release v2.3.1


fix adding event infinite loop

Our team noticed if a handler adds new handlers to the same listener, all new handlers will be executed immediately.
I believe the expected behavior would be any handlers that were already listening when an event occurred should fire. Any new handlers added on account of a keystroke should not fire.

:+1:
This has affected me as well.


Reimagining sf::Rect

Description
Class sf::Rect is a simple and straightforward construct, widely used in SFML library. However, it lacks many basic features and doesn't follow object oriented intuition, as well as standards established in, among other things, PR #2055. This PR improves the Rect class by indroducing the following changes:

A Rect is now defined in terms of it's Vector2 position and size, rather than left, top, width and height
The class now has 4 methods for acquiring it's edges: getLeft(), getTop(), getRight() and getBottom()
The class now has 3 methods for acquiring it's measurements: getStart(), getEnd() and getCenter()
The class now has getAbsoluteSize() method
The class now has getAbsoluteRect() method, which returns the same bounding rectangle, but described with it's actual starting position and positive size
The class now has contains(Rect) method
All of the mentioned methods are negative-size-safe, meaning they are desined to handle rectangles with negative size
The implementation of the old methods (contains(Vector2) and findIntersection(Rect)) and several methods in other classes (which are dependent on the Rect class) has been refactored using the new functionality

Tasks

[x] Tested on Linux (CI unit tests)
[x] Tested on Windows (first-hand)
[x] Tested on macOS (CI unit tests)
[x] Tested on iOS (CI unit tests)
[x] Tested on Android (CI unit tests)

How to test this PR?
#include <iostream>
#include <SFML/Graphics/Rect.hpp>

// This example is basically a unit test.  Negatively sized rects are very rare, and they could be handled explicitly.

The new class architecture is based on the 4 methods for aqcuiring edges, and the fact that they are  universal. I'm sure the size checks are not expesive either. In my opinion, it's handy for them to be negative-size-safe, and it also makes the architecture nice and minimal

Also, you can use commit --amend to edit previous commits (or git rebase -i for many)

Got it. Never had experience with git before 😅

I don't think default parameters are the way to go; it's not meaningful to have Rect(position), let alone implicit

Agreed. Working on it

Maybe your main() example that prints comparisons could be translated to an actual unit test?

I have written the tests for the Rect class itself and changed those which depend on it

We try to use [[nodiscard]] rather conservatively

So do I keep it?

Why these unrelated changes? This makes code arguably less readable.

sf::Transform::Identity was used in like 5 places, and the unit tests for sf::Transform itself. In my opinion, a literal empty sf::Transform() perfectly represents an empty transform

I don't see a reason to remove the other constructor and change this

Agreed. Working on it

Just because sf::Transform::Identity was only used in 5 places doesn't mean it makes sense to include refactor changes alongside the feature you're adding, personally I think the refactor stuff should be its own PR so the merits of each refactor change you propose can be considered without it having an impact on the merging of a new set of functionality

I removed the unnecessary changes. Waiting for review, sir yes sir o7

Visual Studio broke some formatting when I was rolling back unnecessary changes. Fixing

Maybe two general suggestions regarding pull requests, which would reduce the need for discussion:

It usually helps to keep one PR limited to one semantic change. Why?

If there is less code to review, people can do so faster, which will lead to shorter feedback cycles.
The discussion can be linearly talking about one topic and does not need to diverge into completely unrelated "threads" or extended code comments.
There's less risk that people accidentally miss something (e.g. a bug or unintended change).

Try to include a rationale for each change.

Some of the arguments were along the lines of "are we really discussing two braces" or "we don't need sf::Transform::Identity". But if you propose a change, you need to argue in favor of it, and not others against it (burden of proof).
In particular, this means that if two ways of approaching a goal are roughly equivalent, there's usually no need for change.

This only as some friendly input, which could prevent you from doing unnecessary work in the future 🙂 with those, this PR is on a good track!

@Bromeon Thank you for poining out exactly the same things that everyone else has already pointed out several dozens of times in this comment thread and in the SFML Discord server. I assure you, that my congnitive and intelectual capabilities allow me to rather quickly learn on my mistakes and satisfy the demands which more experienced members of the community have placed on my pull request. I'm actively working on improving my contribution skills. Have a great good day.

Please write a more expressive commit message. "Reimagining" a type says little about what is actually happening. Maybe rewrite the commit message to something like

Refactor sf::Rect in terms of two vectors

That's short yet still explains a bit about what's going on. Feel free to use the extended commit section to write as much as you want though.

@Bromeon Thank you for poining out exactly the same things that everyone else has already pointed out several dozens of times in this comment thread and in the SFML Discord server. I assure you, that my cognitive and intelectual capabilities allow me to rather quickly learn on my mistakes and satisfy the demands which more experienced members of the community have placed on my pull request. I'm actively working on improving this PR, as well as my contribution skills. Have a ~great~ good day.

I genuinely meant this as good advice in a condensed form, rather than spread over 20 code comments (and maybe off-site messages). Please don't assume hostility where there is none. People here spend a lot of time trying to get this PR on the right track -- I for one definitely have better things to do than challenge someone's "cognitive and intellectual capabilities" for the fun of it.

@Bromeon

I understand.
Why did you assume that I've assumed hostility? I didn't.
I don't need for you to condense the advice for me. I'm tired of the advice itself in the first place.
I aprecciate your guys' time spent improving this PR. I'm sorry for the inconvinience.
I'm sorry if that comment is hostile itself. It is not directed towards you personally, rather, I was asking all of you to stop sticking it into my face


Test cases for P extension

This isn't going to get much further if merge conficts aren't sorted out...

This isn't going to get much further if merge conficts aren't sorted out...

I've regenerated test patterns using RISCV-CTG 0.6.3 and rebased to the latest master and resolved conflicts.

This seems to be a common issue: the CHANGELOG.md file has a merge issue. It should be easy to fix. I haven't looked at the actual PR yet.

@yungchinghsiao since we have migrated to RISCOF the references no longer need to be checked. Please remove them from your PR. Will review it once that is done.

@neelgala I removed references, Makefile and Makefrag from the P_unratified directory. I also took the chance to update arch_test.h to make the ordering of updating the _F flag consistent with other macros as noted by @allenjbaum .

@neelgala I removed references, Makefile and Makefrag from the P_unratified directory. I also took the chance to update arch_test.h to make the ordering of updating the _F flag consistent with other macros as noted by @allenjbaum .

@neelgala anything I need to do for this pull request?


System.TypeLoadException utilizing latest Blazor Web App Authentication build failure.

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Likely this issue can get handed off to it will be resolved in the final RC2 release but in case no one has noticed. Utilizing the latest daily build of DotNet creating a fresh Blazor Web App with Indvidual Accounts will not build. The .Client project won't successfully compile with a System.TypeLoadException related to Microsoft.CodeAnalysis.
Expected Behavior
The vanilla Blazor Web App with Individual Accounts template should build.
Steps To Reproduce

Use the latest VS 2022 Version 17.8.0 Preview 2.0
Download and install latest DotNet daily build.
Open VS and create a new Blazor Web App project with individual accounts and support for both Server rendering and Client Wasm rendering selected.
Add new item NuGet.config (xml) to be able to support daily build dependencies
Close and re-open solution to get dependencies to download.
Build the solution and observe the failure.

Exceptions (if any)
Unhandled Exception: System.TypeLoadException: Could not load type 'Enumerator' from assembly 'Microsoft.CodeAnalysis, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'.	BlazeAuth.Client	C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets	84
.NET Version
8.0.100-rtm.23479.1
Anything else?

Closing as this is fixed now in 17.8 Preview 3 + .NET 8 SDK RC2. The fix is also in 17.9 so will be available in internal builds within the next 24 hours.

@jaredpar this issue is potentially more serious than these just exceptions? Running rc2 on non-preview vs2022 results in mvc not being able to find any views, unless runtime compilation is enabled on my project.
running the same project on rc1, or rc2 on linux, or rc2 on vs preview on windows has no problems, so i assume it is related to this. would be appreciated if the docs could mention that it's not just this exception which is broken with razor?

Running rc2 on non-preview vs2022 results in mvc not being able to find any views, unless runtime compilation is enabled on my project.

Right, to develop with .NET 8 you really need to use the latest preview of Visual Studio. .NET 8 requires using Visual Studio 17.8 or later, at least when doing any Razor based development (MVC, Razor Pages, Blazor).


signalr "connection closed with an error"

Hi,
This is the code soure:
https://github.com/ranouf/AspNetCore-SignalR/tree/master/src
csproj

    <PackageReference Include="Microsoft.AspNetCore.SignalR" Version="1.0.0-rc1-final" />
    <PackageReference Include="Microsoft.AspNetCore.SignalR.Protocols.MessagePack" Version="1.0.0-rc1-final" />

package.json
  "@aspnet/signalr": "^1.0.0-rc1-update1",
I used this tutorial to update my code: https://damienbod.com/2017/09/12/getting-started-with-signalr-using-asp-net-core-and-angular/

Each time I try to connect to the Hub, I have this error message:
Information: WebSocket connected to ws://localhost:4053//chat?id=u9wrwlvaYiYfl1k8Jyl-yg
Utils.js:188 Information: Using HubProtocol 'json'.
Utils.js:188 Information: Close message received from server.
Utils.js:182 Error: Connection disconnected with error 'Error: Server returned an error on close: Connection closed with an error.'.

I tried to find information about that Google: signalr "connection closed with an error"
But I didnt find any answer.
Is there someone who can help?

On your server you can turn on detailed errors via:
services.AddSignalR(o =>
{
    o.EnableDetailedErrors = true;
})

This will then give you a more detailed error message on the client

I got a similar one behind AWS ALB. Locally everything works fine, but behind a load balancer I got this after turning on detailed errors:

WebSockets are supported and I have turned on sticky sessions. I'll update here if I figured out something.

Aaand got it. Exception thrown behind a hub are not propagated.
public override Task OnConnectedAsync()
{
     _logger.LogInformation("On connected: " + Context.User.Identity.Name);
     _memCache.Set(Context.User.Identity.Name, Context.ConnectionId);

     return base.OnConnectedAsync();
}

Looks like the Identity Name was null in my case and argument exception was thrown by IMemoryCache. @ranouf try enabling detailed errors, and add more logging to your hub.

David, sorry, yes I believe this is expected behaviour.
Regardless, if this helps someone, I managed to figure out my issue where the user principal is empty in the hub. So locally, I'm using AutoAuthorize middleware, and in our deployed environments we are using JwtAuthorizer one. I dunno why but with the latter one, the Context.User is empty, even though in our Controllers the User is very much populated. I figured I'll put Authorize attribute in my hub as well, so the middleware will surely run before the Hub is invoked.
Then did this on client side:
const opts =  { accessTokenFactory: () => this.authService.getAuthToken()};

const connection = new signalr.HubConnectionBuilder()
   .withUrl(`${environment.backendAddress}progress-notifier`, opts)
   .build();

This accessTokenFactory is the best thing ever! I didn't even need any workaround to apply my header and I love that.

@ranouf have you been able to get any additional error information by setting the option @BrennanConroy suggested above?

Closing this as we haven't heard from you. Please feel free to comment if you're able to get the information we're looking for and we can reopen the issue if we're able to identify the problem.

Hi, sorry I m working on something else currently.
Thanks for.your help, when I will have more time I will try your suggestions ;)


Release/v1.5.0

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[x] Bug fix
[ ] New feature
[x] Other, please explain: Usage of GitHub Actions instead of Travis CI + continuous-deployment

Which issue (if any) does this pull request address?
closes #111, #131, #135
Closing #131 since the VSCode extension is now actually maintained but of course we always welcome contributors.
Description
Time to release a new version, I think lot of people will benefit from this! :rocket:
Basically this PR increase the version number 1.4.0 to 1.5.0, update the changelog so it's no longer pending.
I also deleted && settings.engine !== 'standard' of this line https://github.com/standard/vscode-standardjs/blob/0f92bb6687eed39734d459c8a65594c67fd3d8aa/server/src/server.ts#L892
As it is discussed in #135
Also use GitHub Actions instead of Travis, as it is the case on standard repo since https://github.com/standard/standard/pull/1629.
And also add continuous-deployment, everytime we release a new version on GitHub it also releases on VSCode Marketplace and open-vsx automatically.
To do that, we need to set 2 new secrets on the GitHub repo :

OPEN_VSX_TOKEN : see https://github.com/eclipse/openvsx/wiki/Publishing-Extensions#2-create-the-namespace
VS_MARKETPLACE_TOKEN : see https://code.visualstudio.com/api/working-with-extensions/publishing-extension

I package the extension again and test it massively again to ensure everything working as expected also there are 5+ people saying it is working for them.
Here are some screenshots :

Hi, I'd love to have the [] filename fix. Is this release close to being ready? Thanks

Hey! @aldeed
The release is ready, we need someone to approve this PR changes from the standard/team and someone to add the OPEN_VSX_TOKEN and VS_MARKETPLACE_TOKEN secrets in the GitHub repository to allow automated deployment.
While we're waiting, we would appreciate if you could tell us that everything is working as expected in this new release by following these steps to install the extension locally :
git clone https://github.com/standard/vscode-standardjs.git
cd vscode-standardjs
git checkout release/v1.5.0
npm install
npm run package
code --install-extension vscode-standardjs-1.5.0.vsix
# restart VSCode

Maybe you could post a screen, that everything is working for you or if it's not the case, feel free to open a new issue.
Thanks for your help! :smile:

@Divlo Built and installed locally and confirmed the issue with brackets in filenames is fixed (standard checking and auto-fixing works in those files). Thanks for the fix.

Created an Open VSX account, generated token, asked to be verified for standard namespace: https://github.com/EclipseFdn/open-vsx.org/issues/383
Added the OPEN_VSX_TOKEN and VS_MARKETPLACE_TOKEN tokens as @Divlo requested. I haven't tested if the publish process actually works. Will leave that to @Divlo


add btc lightning client

Related issues:

#5

this pr still needs still needs #48 to be merged first


fix: missing status in satori

#241
koishijs/koishi#1367

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.93%. Comparing base (e5825f1) to head (53b029a).
Report is 12 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
+ Coverage   86.88%   86.93%   +0.04%
==========================================
  Files           1        1
  Lines         549      551       +2
  Branches      111      111
==========================================
+ Hits          477      479       +2
  Misses         72       72

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

? 怎么 CI 爆了

? 怎么 CI 爆了

Looks like the yakumo should be updated, but overall the PR looks good to me.

Testing is completed and the following issues have been fixed:

missing status
WebUI normal display login status


[WIP] Persist LNURL successAction in LnPaymentDetails

This PR persists the LNURL successAction in the LnPaymentDetails as per https://github.com/breez/breez-sdk/pull/88#discussion_r1095486697 :
https://github.com/breez/breez-sdk/blob/9561894c9206a50d70c0d29c010628a7e93c28ef/libs/sdk-core/src/models.rs#L295-L297
However I don't think this is a viable solution because we don't have the successAction at the point where we want to set it:
https://github.com/breez/breez-sdk/blob/9561894c9206a50d70c0d29c010628a7e93c28ef/libs/sdk-core/src/breez_services.rs#L192-L198
The LNURL successAction is not passed as an arg to the service method send_payment.
The tests work because the MockNodeAPI has the entire payment structure in advance (incl. expected successAction). However the real NodeAPI has to handle it in the send_payment.
@roeierez should I add a separate service method send_payment_lnurl with an extra arg for SuccessActionProcessed?
Or is this general approach too fragile and we should look for a different approach?

P.S. In addition, the udl doesn't parse and I haven't figured out why, but that's a small issue.

@ok300 I think the field you added on the LnPaymentDetails is OK but we need also to handle these two requirements:

persist the lnurl success action
fetch it from the db as part of the LnPaymentDetails.

IMO for 1 we should create another table for lnurl related data (data that is related to lnurl actions). The schema of this table should contain payment_hash field and the related data field in json format (in our case the success action).
When we have the success action we should just save it to that table.
For 2 we need to change the list_payment (https://github.com/breez/breez-sdk/blob/main/libs/sdk-core/src/persist/transactions.rs#L52) in the persister to join with the lnurl related data table baed on the payment_hash and use populate the returned model accordingly.
We also need to change the lnurl_pay so the returned Payment will contain the success action. We can do that by populating the returned Payment from send_payment with the success action we have before returning it to the user.
this way we decouple the greenlight LN payment conversion from the Lnurl related data.
Do you think it makes sense?

@roeierez thanks, makes sense! Working on it.


textmesh pro generated scrambles mode characters remains forever after playing sequences backward

hey ,  when i try to tween some text mesh pro texts in a numerical scramble mode the generated numbers will remain forever in the text mesh pro field.
is there any solution for it?

I can't reproduce it locally, can you share a bit more information?
What version of Unity?
What version of DOTween?
What version of Animation Sequencer?


add %version_tag% token

Hi!
I have a repo which uses tags of format vX.X.X.X to denote release versions, and I need to use these tags instead of assembly versions (as constantly changing latter was pretty cumbersome).
I did quick implementation of this and I'd like to share it in case anyone would need such thing. Probably could be implemented in a better way.

this project is no longer maintained. raise a new issue if u want to take ownership

Hi, if some unit tests are added, I like to merge this one

Thanks! Has added a test and renamed it to %lasttag% in #31


DeviceFlags.ExclusiveInputSink does not seem to work in RawInput

If I take the SharpDX RawInput sample, and change the line
Device.RegisterDevice(UsagePage.Generic, UsageId.GenericMouse, DeviceFlags.None);
to
Device.RegisterDevice(UsagePage.Generic, UsageId.GenericMouse, DeviceFlags.ExclusiveInputSink);
then mouse input breaks for the demo.
Am I doing something wrong?
I want to be able to do the same as in the demo, but not require the user to click the GUI to begin capture.

Duh, I need to pass the hwnd of the form. Never mind.


ERRO[0065] Error extracting ASAR

Hey, thanks for your efforts :-)
I compiled your code and tried to run it, without success:
$ ./bs-patch
INFO[0000] Reading config.yaml
INFO[0000] Finding Latest BluOS Controller
INFO[0002] Downloading Latest BlueOS controller: https://www.bluesound.com/wp-content/uploads/2020/11/BluOS-Controller-3.12.1.dmg
Downloading... 98 MB complete
INFO[0035] Extracting BlueOS Controller DMG
INFO[0037] Extracting ASAR
INFO[0039] Patching electron.js
INFO[0039] Patching app.js - Update Check
INFO[0039] Patching app.js - Update Platform
INFO[0039] Adding electron dependency
INFO[0055] Adding electron-builder dependency
INFO[0065] Building Snap and AppImage
ERRO[0065] Error extracting ASAR:
INFO[0065] Cleaning up

Additional information
+ git rev-parse HEAD
5faae18d4d77578a6e68685664f92a7c61906ad7
+ go version
go version go1.13.15 linux/amd64
+ lsb_release -d
Description:	Fedora release 31 (Thirty One)
+ npx -v
6.13.4
+ npm -v
6.13.4
+ whereis npm
npm: /usr/bin/npm /home/frafra/.nvm/versions/node/v12.15.0/bin/npm /usr/share/man/man1/npm.1.gz
+ whereis npx
npx: /usr/bin/npx /home/frafra/.nvm/versions/node/v12.15.0/bin/npx /usr/share/man/man1/npx.1.g
+ cat config.yaml
nodeBinPath: "/usr/bin"

Thanks for the info. I'll try to add additional details to the error handling and report out the issue. In the mean time, you can download the latest compiled version from here:  https://support1.bluesound.com/hc/en-us/community/posts/360033533054-BluOS-controller-app-on-Linux

Hi,
any update here? I'm running into same message "ERRO[0040] Error extracting ASAR:"
Before that, I manually installed node with nvm as described here (the link to manual NodeJS install. I also installed asar with /home/user/.nvm/versions/node/v16.2.0/bin/npm install -g asar but the error message resists.
I'm using Manjaro, npm is version 7.13.0, Node 16.2.0
Please let me know, if you need more info.

Hey @Wildbill-Z , I'm using PoP_OS (ubuntu based). I'm going to containerize this in the next couple of days so all you'll need is Docker. There are just too many variables on user's systems. In theory, any install of a modern version of Node should work. I'm using:

nvm: 0.35.3
node: 14.3.0
npm 6.14.5

@Wildbill-Z you should be able to replicate the environment by running:
nvm install 14.3.0
nvm use 14.3.0

and then re-running

Unfortunately, that didn't help. Installed 14.3.0, changed path in config.yaml and tried, but same error. Even after manually installing asar with /home/user/.nvm/versions/node/v14.3.0/bin/npm install -g asar and nvm use node 14.3.0 I'm getting the same error about asar.
Nevertheless, I'll use your snap with version 3.12.3 until you'll build a newer version or make it work with Docker.
Thanks


Update eigen library to 88fc23324517 to fix 24457

This fix updates eigen library to 88fc23324517 so that the issue raised in #24457 could be fixed.
This fix fixes #24457.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

Sorry I'm not familiar with this change. Please find someone else.


Adapter stops working without sign

Adapter showed "green" as well all WLED devices were shown as connected, but some of them multiple times.

After restarting the addapter following errors were shown:

No Datapoint will be updated either from WLED device side (if i change something on the web UI of the WLED device) or from the datapoint to the WLED device.
Restart don't help.
After a complete reinstallation everything is working again, but only found on WLED device automatically the other once i had to add manually.
Information to my system Running on a MW on Proxmox:

should be fixed in 0.5.7


feat(theoros): hyperlane service

Resolves #47
Changes

Adds a new HyperlaneService
On each tick, loops through the validators and their respective checkpoint storage.
Will retrieve the latest checkpoint from the location
Stores it in a new HashMap for later retrieval

Questions

What should we do when no checkpoint is found for the latest index ?
Should we add a retry mechanism ?
Do we want to keep historical checkpoints ?

What should we do when no checkpoint is found for the latest index ?
Should we add a retry mechanism ?

I think we should have a threshold of "functioning" validators. I.e. if for a certain checkpoint, we have less than 66% OK responses from the validators, the whole app should either crash or we should have a retry mechanism.
If the retry mechanism still fails after X times, we crash.
If it's just some validators that fail for a specific index, we should just ignore them and move on. Probably log it & monitor it.

Do we want to keep historical checkpoints ?

It should be the responsibility of the validators, right? Not Theoros


Output panel should not toggle on test runs

When using any of the "Test Explorer: Run *" commands, if the Output panel that shows the test errors is open, it will momentarily close, and once the tests are done, reopen. It has the effect of shifting all open panes back and forth.
Ideally it would not close the open Output section, and just refresh it once the tests have finished.

You can configure that in the settings I believe.

Yes, you can configure it with the testExplorer.hideEmptyLog setting.


integration with BigBlueButton

could you give me more details to integrate with virtual classroom of bigbluebutton please:  the consumer send the request to BBB provider but the response is " connection couldn't be established" , i 've checked that the Secret and URL are correct....any suggestion ?

I'm sorry, but I don't have any suggestions.


Process for Providers from Aggregators

Ticket work required.
To include:

process for "linking" records from aggregators (e.g. Europeana) to providers (https://github.com/creativecommons/cccatalog/issues/392)
-- we have a table of providers
process for adding new providers to provider table, including logo (this falls to Breno)

Update:

We now have a provider (which can also be an aggregator, or just the home institution) for every source.
We have a table where new sources are added with logos etc, from which we populate a list on the frontend.

This work is essentially complete.


uploading data can be a time-consuming process, how to determine the shortest time of HTTP POST (IDFGH-2113)

uploading data can be a time-consuming process, how to determine the shortest time of HTTP POST？

Thanks for reporting. For "how" questions and third party library question, we suggest that you could submit a post on our forum at https://esp32.com. Thanks.


Docusarus.io documentation menus don't work on mobile Safari

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[ ] I have tried the npm run clear or yarn clear command.
[ ] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[ ] I have tried creating a repro with https://new.docusaurus.io.
[ ] I have read the console error message carefully (if applicable).

Description
The Docusaurus.io documentation menus often don't work in mobile Safari. The hamburger menu often doesn't respond to click events and the table of contents menu doesn't either. Refreshing the page doesn't help.
At some point, after navigating around the docs using standard anchor tags (like the Next links at the bottom), the mobile nav begins to work.
Safari is somewhat notorious for these types of "works sometimes" issues with JavaScript. My guess is that the JavaScript that is handling the menus has a branch that fails in certain situations and that causes it to fail. Eventually the JavaScript is loaded properly and begins working, but that's only after numerous page loads and navigation.
Next time this happens I can try attaching to the desktop debugger and see what's up.
Reproducible demo
No response
Steps to reproduce

Open Safari on iOS
Navigate to the Docusaurus.io website
Open the hamburger (this one always seems to work) and click docs
Click the hamburger menu again and see if it opens

Expected behavior
The menus should always work.
Actual behavior
The menus periodically don't work.
Your environment

iOS 16.2

Self-service

[ ] I'd be willing to fix this bug myself.

That would indeed help if you could record a video or screenshot or send us the terminal output.
Keep in mind that if you are under a very slow network, the hamburger menu won't work until the JS has finished loading because it is not (yet) progressively enhanced. Most of the time you probably don't see it, but under bad networks this is likely more common.

Closing until someone show a video of the problem


ZeroTouch Enrollment apply configuration for multiple devices in one call

My Problems
One call is arround 1s so if i got 1000 devices i need to call this function 1000 times and it will take arrond 1000s.
Current result:
for device_reference in my_list_of_devices_references:
  service.customers().devices().applyConfiguration(
    parent=customer_account,
    body={"device": device_reference, "configuration": configuration["name"]}
  ).execute()

Feature request
We can apply one configuration for one device, it's possible to create a call which get list of device reference and apply configuration for all devices.
Expected:
service.customers().devices().applyConfiguration(
  parent=customer_account,
  body={"devices": my_list_of_devices_references, "configuration": configuration["name"]}
).execute()

Link
doc i use for this call

Hi @mBouamama ,
Please could you create a feature request for this feature using the zero-touch contact page?
You can submit feature requests through the zero-touch community or the send feedback button in this portal.
I'm going to close off this issue as zero-touch is an upstream API that lives outside of google-api-python-client.

Hi @mBouamama ,
Please could you create a feature request for this feature using the zero-touch contact page?
You can submit feature requests through the zero-touch community or the send feedback button in this portal.
I'm going to close off this issue as zero-touch is an upstream API that lives outside of google-api-python-client.


Optional "stickiness"

I don't know how much sense it has but it would be interesting feature if we would add ability for the developer to decide in runtime if something should be sticky or not. There may be a case that user has inner elements of same view type but that have different properties. For example, if we assume app for teachers that handles list of their schedule. Schedule can contain groups or singles (like private classes). Each group has list of students. Then they would have a list with following elements (where each group has : 1) Group A, 1.1) John, 1.2) Jack, 2) Emily, 3) Bob.
This example would require developer to have multiple classes for inner rows and top level student rows, although they are essentially same and differ in single flag. What about adding additional method, which can return default value if Java 8 is used? Or maybe investigating other approaches, I'm just now brainstorming :)

I could maybe see a potential for a MaybeSticky interface that would have a method isSticky.
It would require holding a reference to the dataset (or at least the subset containing items that implement the new interface). This means there would be a decent re-write needed. I might look into this, though don't have a whole lot of time immediately.


We used your template for our borch paper

https://arxiv.org/abs/2209.06168
In case you want to showcase it. :)

Awesome :smile: Congratulations, and thanks for letting me know! Added to the README.


Update LDAP_TLS_CIPHER_SUITE, remove LDAP_TLS_PROTOCOL_MIN

This addresses both issues raised in #69. @osixia please take a look, appreciate your review.
Did not really know which base branch is the right choice here, probably neither of stable and hotifx-1.1.4.

merged in 1.1.4

thanks !


Inconsistent Representation of Version Numbers in XML

Sometimes version numbers are written as hex, sometimes they aren’t.
<head>
    <tableVersion value="1.0"/>
    <!-- … -->
</head>

<hhea>
    <tableVersion value="0x00010000"/>
    <!-- … -->
</hhea>

Wouldn’t it be nice to consistently do it the same way?

Would be nice indeed.

What do you prefer? "1.0" or "0x00010000"?

The hex. We started switching because the float was confusing..

Would this apply to head.fontRevision, too? The value 2.003 would produce 2.00299 in the current implementation and as hex: 0x000200C4.

Would this apply to head.fontRevision, too?

I'd say no.  The spec says fontRevision is of type Fixed, whereas the version numbers we are talking about used to be of type Version.  Latest revision of the spec changed them to explicitly say uint16 major, uint16 minor.  It's the latter ones we want to write in hex.

The Fixed type has been problematic for versioning because of different interpretations for the fractional portion. In OT1.8, we changed all the instances we could to majorVersion/minorVersion uint16s. A few tables -- maxp, post, vhea -- were not amenable to this because of versions having been defined that would not work with that pattern.
The head.fontRevision field is another problematic case: I've seen fonts that handle the fractional portion in both ways. If you treat head.fontRevision as a floating value, then when reading an existing font you have to decide which interpretation to assume.
In these few remaining places where Fixed is used for versioning, I'd be inclined to treat the whole as a single, atomic value; or else treat it as two separate uint16s without trying to assume how to interpret the minor portion as a fraction.

Thanks Peter.
Let's not touch fontRevision for now and try to converge on the other ones first.  I agree post table is special in that it cannot be treated as major/minor.  Not sure if such distinction applies to maxp and vhea.


Please send column mapping data onSubmit

I appreciate  on getting this component to the users. It is really helpful. We want a new feature as can you please send column mapping metadata with submitted data and file info. It will really helpful and valuable for us if you guys get this feature.
const onSubmit = (data: any, file: any , columnmappinginfo : any) =>{
console.log(columnmappinginfo); //which prints like {'id' : 'ID' , 'name' : 'UserName' .. }
}

Any Update on this?
I made some changes to the code, so that we can get column mapping meta data. Follows :
Files :
src/types.ts
src/steps/UploadFlow.tsx
src/steps/ValidationStep/types.ts
src/steps/ValidationStep/ValidationStep.tsx
Attaching Zip files
src/types.ts as src_types.ts
src/steps/UploadFlow.tsx as UploadFlow.tsx
src/steps/ValidationStep/types.ts as validationsteps_types
src/steps/ValidationStep/ValidationStep.tsx as ValidationStep.tsx
I sincere request, please merge this changes to actual package, which gives us simple mapping information.
MappingInfoFiles.zip

@JulitorK @jeffnv  @ineentho  @jtordgeman please look into this new feature.

Hey @raomohan499 this data is already available in matchColumnsStepHook - you can store it in a local useState and then access it in the onSubmit function. PR for this to be part of onSubmit would also be welcome.

@masiulis , how can I get that data from matchColumnsStepHook, it would more helpful if you refer any example


Integration testing in ACA-Py

For adding multi-tenancy to ACA-Py I'm looking into adding integration tests to ACA-Py. Unit tests cover a large part of the codebase, but sometimes specific combinations of features and different workflows can cause ACA-Py to break. Even though the unit tests themselves pass.
I discussed with @ianco and @nodlesh today about how to approach this.
As AATH does a  lot of things integration tests in ACA-Py should also do, we also discussed how we could maybe (re)use parts of this.
We came to the following:

Use behave (gherkin syntax) to add tests.

A lot of Hyperledger / Aries projects seem to take this approach (framework-go, aries-agent-test-harness, fabric).
It also allows to reuse certain workflows, making it easy to create new test flows from already existing workflows.

Do not use the aries-agent-test-harness repo (at least for now) to run tests, but reuse some of the logic already implemented

Using AATH to run tests will make it harder to add integration tests to new features in ACA-Py. Instead of adding it to your ACA-Py PR you need to add this to AATH. This can give some chicken-egg scenarios where one of them will most likely break until both are merged
AATH is for interoperability testing

I'll make this a separate PR from the multitenancy work (as it is already getting a quite large PR) and start with recreating the alice/faber demo
The integration tests will be black box, meaning we send requests, and verify the response states and webhooks. We won't be verifying internal states.
We'll use a single agent that talks to itself to start with (maybe adding more agents later on).
Add Github actions pipeline that runs automatically for PRs on master branch

Posting this here for feedback and progress updates

I'm not a big fan of recreating what we have in AATH in ACA-Py, but don't have a lot of time to come up with something better.  A couple of comment/questions though:

The chicken-and-egg problem is not a big deal if you flag the test that is failing that it is expected to fail.  In my opinion, I would prefer we ran more tests and flagged some as "expected to fail" and then be notified when they pass them, so we can change the expected results.  "Hey, our test run fails because some tests have started to pass!!!"

I was wondering if this comment "The integration tests will be black box" was an indication that we are doing too much internal checking in AATH?

I am a fan of using Behave and (now) Allure for testing.  Awesome stuff!

The chicken-and-egg problem is not a big deal if you flag the test that is failing that it is expected to fail.  In my opinion, I would prefer we ran more tests and flagged some as "expected to fail" and then be notified when they pass them, so we can change the expected results.  "Hey, our test run fails because some tests have started to pass!!!"

In that case the chicken-and-egg problem is resolved. I've worked with external integration tests and it always felt like a burden to maintain and keep in sync (Interoperability tests are different IMO). We're already noticing this with ACA-Py updates breaking AATH startup, needing to add if/else statements based on the ACA-Py version. The same with .NET, where a change in the public API broke AATH. The fix was to update, but now all older versions of the .NET agent can't be tested with AATH anymore.
We need to solve these problems for AATH because we want to test different combinations of agents/versions. But for integration testing it doesn't really seem like we need to solve these problems. We just want to test the current branch and see if everything works as expected (that is my assumption). So besides doing interoperability and protocol compliance testing, AATH now also has to take ACA-Py implementation specific tests into account. Also the backchannel setup adds an extra layer, which makes writing tests more complex.
To add some extra clarity. The idea was not to void all the work done in AATH, I wanted to take it as a starting point and strip all unneeded functionalities not needed for integration testing. But you're definitely right on the fact that we're recreating some parts of AATH in ACA-Py. I'm going to think about it a bit more.

I was wondering if this comment "The integration tests will be black box" was an indication that we are doing too much internal checking in AATH?

I don't think black box is the correct term. What I meant (and what AATH is also doing with ACA-Py) is that we only make use of public apis. We're using ACA-Py in the same way everyone that uses ACA-Py for their applications is using. We don't 'hook' into the internals of ACA-Py to do custom checks. We validate whether certain input gives us the expected output.

I am a fan of using Behave and (now) Allure for testing.  Awesome stuff!

Great. We're all on the same page on this one :)

I disagree that we're duplicating AATH here, but in any case I think this is a moot point.
What we want to implement is a set of integration tests that are executed on each PR in the aca-py repository.  We want to be able to test aca-py-specific features, and we want to run on each PR, as opposed to on a schedule (the way AATH is run).  AATH could potentially fulfill these requirements, however we don't want to start building aca-py-specific tests into AATH (it should stay focussed on interoperability testing).
We decided the integration tests should use behave (same as AATH, and in fact this is consistent with how a lot of the HL projects are running integration tests, afgo and fabric are 2 examples) and should be "black box", in the sense that they run an aca-py instance and then run tests by invoking api calls and checking results - this will result in some duplication or reuse of AATH components, since AATH already does this.  However I don't know of a more efficient way to get the aca-py integration tests up & running.
I think we're probably all in agreement on the need for integration tests and approach, and I think it's wise to be careful of "duplication" - we should re-factor AATH if possible to use shared (rather than duplicated) code, and be careful that the aca-py integration tests are not just a duplication of tests that are already implemented in AATH.

One thing that came out of the meeting we had was to regroup after Timo had one or two tests written and reassess the separation from AATH.  I think there is room for different approaches in AATH (eg. a set of acapy integration tests that don't hit the backchannel), however, when doing testing directly against a product that probably won't be used against any other product, it is sometimes wise to keep the tests close to the product code it is testing. The feedback loop is shortened, which, Ian mentions, is key if developers want these tests to tell them they didn't break anything on a per PR basis. We have that problem now, the dev is not aware of the results of the tests on the daily run of AATH, plus the results may show cumulative PRs so narrowing down what broke it is more difficult.
One benefit to having the integration tests in the AATH is that you could mix interop test steps with integration test steps to do things with other types of agents within your integration tests. Not sure if the need for that would arise.
I do agree with Timo that the version problem, something that does need to be addressed in AATH, is not a concern for product-specific integration tests. However, whatever scheme we decide on to solve that problem, I don't think it would strap a set of integration tests to the solution that you would have to worry about it.
"Too much checking in AATH"? Geez, I held back a lot. 😎 For the most part, it only checks http response codes and agent states based on RFCs. Not sure how we would determine pass or fail otherwise.

We have integration testing in ACA-Py now (thanks @ianco !!). Closing.


"Show pictures" button displayed even if pictures already downloaded

Expected behavior
"Show pictures" button should be hide if all pictures are already present
Actual behavior
"Show pictures" button is always displayed when selecting a mail
Steps to reproduce

Select a message
Click on "show pictures" -> pictures are downloaded
Select another message
Reselect the first message
Bug: the button is showed whereas the pictures are present

Environment
K-9 Mail version: 5.717
Android version: 9
Account type (IMAP, POP3, WebDAV/Exchange):

Unless the "Show pictures" button was pressed we disable all network requests. If remote images are displayed anyway they are read from WebView's cache. I don't know if we can reliably detect this case to hide the button.


Pods with volumes stuck in ContainerCreating after cluster node is powered off in vCenter

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
One of the cluster worker nodes was powered off in vCenter.
Pods running on this node have been rescheduled on different nodes but got stuck in ContainerCreating. It failed to attach the volume on the new node with error "Multi-Attach error for volume pvc-xxx, Volume is already exclusively attached to one node and can't be attached to another" and hence the application running in the pod has no data available because the volume is not attached to the new node. The volume is still attached to powered off and no attempt is made to detach the volume by attach/detach controller. Hence attach the volume on the new node failed with error "Multi-Attach error". It's stuck for 6 minutes until attach/detach controller forcefully tried to detach the volume on the powered off node. After the end of 6 minutes when volume is detached on powered off node, the volume is now successfully attached on the new node and application has now the data available.
What you expected to happen:
Pod should be started correctly on a different node, with volumes attached to it very quickly. For an application to be down for 6 minutes is very bad.
How to reproduce it (as minimally and precisely as possible):

use k8s 1.7.0+ with vSphere cloud provider
Delete the node from the cluster by powering off the node from vCenter.

Anything else we need to know?:
Below are the logs from controller manager.
{"log":"I0818 23:27:01.933677       1 controller_utils.go:285] Recording status change NodeNotReady event message for node node2\n","stream":"stderr","time":"2017-08-18T23:27:01.933908764Z"}
{"log":"I0818 23:27:01.934012       1 controller_utils.go:203] Update ready status of pods on node [node2]\n","stream":"stderr","time":"2017-08-18T23:27:01.934110529Z"}
{"log":"I0818 23:27:01.934384       1 event.go:218] Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"\", Name:\"node2\", UID:\"14b8f7fb-846c-11e7-addd-0050569ccb52\", APIVersion:\"\", ResourceVersion:\"\", FieldPath:\"\"}): type: 'Normal' reason: 'NodeNotReady' Node node2 status is now: NodeNotReady\n","stream":"stderr","time":"2017-08-18T23:27:01.93448004Z"}
{"log":"I0818 23:27:01.939006       1 controller_utils.go:220] Updating ready status of pod redis-master-2401852951-w92hb to false\n","stream":"stderr","time":"2017-08-18T23:27:01.939064356Z"}
{"log":"I0818 23:27:01.944968       1 controller_utils.go:220] Updating ready status of pod heapster-v1.2.0-1794790591-94z4s to false\n","stream":"stderr","time":"2017-08-18T23:27:01.945054955Z"}
{"log":"I0818 23:27:01.956548       1 controller_utils.go:220] Updating ready status of pod kube-proxy-1lq8f to false\n","stream":"stderr","time":"2017-08-18T23:27:01.956639977Z"}
{"log":"W0818 23:27:02.043661       1 vsphere.go:625] VM node2, is not in poweredOn state\n","stream":"stderr","time":"2017-08-18T23:27:02.043753193Z"}
{"log":"I0818 23:27:02.043759       1 controller_utils.go:274] Recording Deleting Node node2 because it's not present according to cloud provider event message for node node2\n","stream":"stderr","time":"2017-08-18T23:27:02.043785273Z"}
{"log":"I0818 23:27:02.044235       1 event.go:218] Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"\", Name:\"node2\", UID:\"14b8f7fb-846c-11e7-addd-0050569ccb52\", APIVersion:\"\", ResourceVersion:\"\", FieldPath:\"\"}): type: 'Normal' reason: 'DeletingNode' Node node2 event: Deleting Node node2 because it's not present according to cloud provider\n","stream":"stderr","time":"2017-08-18T23:27:02.044320987Z"}
{"log":"I0818 23:27:02.050426       1 attach_detach_controller.go:465] error removing node \"node2\" from desired-state-of-world: failed to delete node \"node2\" from list of nodes managed by attach/detach controller--the node still contains 1 volumes in its list of volumes to attach\n","stream":"stderr","time":"2017-08-18T23:27:02.050519226Z"}
{"log":"I0818 23:27:06.964846       1 gc_controller.go:162] Found orphaned Pod redis-master-2401852951-w92hb assigned to the Node node2. Deleting.\n","stream":"stderr","time":"2017-08-18T23:27:06.96761137Z"}
{"log":"I0818 23:27:06.964850       1 gc_controller.go:62] PodGC is force deleting Pod: default:redis-master-2401852951-w92hb\n","stream":"stderr","time":"2017-08-18T23:27:06.967620391Z"}
{"log":"I0818 23:27:06.987612       1 replica_set.go:455] Too few \"default\"/\"redis-master-2401852951\" replicas, need 1, creating 1\n","stream":"stderr","time":"2017-08-18T23:27:06.987687983Z"}
{"log":"I0818 23:27:07.005200       1 gc_controller.go:166] Forced deletion of orphaned Pod redis-master-2401852951-w92hb succeeded\n","stream":"stderr","time":"2017-08-18T23:27:07.005265456Z"}
{"log":"I0818 23:27:07.027452       1 event.go:218] Event(v1.ObjectReference{Kind:\"ReplicaSet\", Namespace:\"default\", Name:\"redis-master-2401852951\", UID:\"3f1729f7-846c-11e7-addd-0050569ccb52\", APIVersion:\"extensions\", ResourceVersion:\"909\", FieldPath:\"\"}): type: 'Normal' reason: 'SuccessfulCreate' Created pod: redis-master-2401852951-wcx6h\n","stream":"stderr","time":"2017-08-18T23:27:07.027541497Z"}
{"log":"I0818 23:27:07.044256       1 nodecontroller.go:553] NodeController observed a Node deletion: node2\n","stream":"stderr","time":"2017-08-18T23:27:07.044322304Z"}
{"log":"I0818 23:27:07.044362       1 controller_utils.go:274] Recording Removing Node node2 from NodeController event message for node node2\n","stream":"stderr","time":"2017-08-18T23:27:07.048265998Z"}
{"log":"I0818 23:27:07.044485       1 event.go:218] Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"\", Name:\"node2\", UID:\"14b8f7fb-846c-11e7-addd-0050569ccb52\", APIVersion:\"\", ResourceVersion:\"\", FieldPath:\"\"}): type: 'Normal' reason: 'RemovingNode' Node node2 event: Removing Node node2 from NodeController\n","stream":"stderr","time":"2017-08-18T23:27:07.048273963Z"}
2017-08-18T23:27:07.048273963Z"}
{"log":"W0818 23:27:07.054184       1 reconciler.go:262] Multi-Attach error for volume \"pvc-2f53fe7e-846c-11e7-addd-0050569ccb52\" (UniqueName: \"kubernetes.io/vsphere-volume/[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\") from node \"node3\" Volume is already exclusively attached to one node and can't be attached to another\n","stream":"stderr","time":"2017-08-18T23:27:07.05423019Z"}
{"log":"I0818 23:27:07.054279       1 event.go:218] Event(v1.ObjectReference{Kind:\"Pod\", Namespace:\"default\", Name:\"redis-master-2401852951-wcx6h\", UID:\"bff886d1-846c-11e7-addd-0050569ccb52\", APIVersion:\"v1\", ResourceVersion:\"945\", FieldPath:\"\"}): type: 'Warning' reason: 'FailedAttachVolume' Multi-Attach error for volume \"pvc-2f53fe7e-846c-11e7-addd-0050569ccb52\" Volume is already exclusively attached to one node and can't be attached to another\n","stream":"stderr","time":"2017-08-18T23:27:07.054350162Z"}
{"log":"W0818 23:27:07.054184       1 reconciler.go:262] Multi-Attach error for volume \"pvc-2f53fe7e-846c-11e7-addd-0050569ccb52\" (UniqueName: \"kubernetes.io/vsphere-volume/[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\") from node \"node3\" Volume is already exclusively attached to one node and can't be attached to another\n","stream":"stderr","time":"2017-08-18T23:27:07.05423019Z"}
{"log":"I0818 23:27:07.054279       1 event.go:218] Event(v1.ObjectReference{Kind:\"Pod\", Namespace:\"default\", Name:\"redis-master-2401852951-wcx6h\", UID:\"bff886d1-846c-11e7-addd-0050569ccb52\", APIVersion:\"v1\", ResourceVersion:\"945\", FieldPath:\"\"}): type: 'Warning' reason: 'FailedAttachVolume' Multi-Attach error for volume \"pvc-2f53fe7e-846c-11e7-addd-0050569ccb52\" Volume is already exclusively attached to one node and can't be attached to another\n","stream":"stderr","time":"2017-08-18T23:27:07.054350162Z"}
{"log":"W0818 23:27:07.154442       1 reconciler.go:262] Multi-Attach error for volume \"pvc-2f53fe7e-846c-11e7-addd-0050569ccb52\" (UniqueName: \"kubernetes.io/vsphere-volume/[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\") from node \"node3\" Volume is already exclusively attached to one node and can't be attached to another\n","stream":"stderr","time":"2017-08-18T23:27:07.154554127Z"}
{"log":"I0818 23:27:07.155116       1 event.go:218] Event(v1.ObjectReference{Kind:\"Pod\", Namespace:\"default\", Name:\"redis-master-2401852951-wcx6h\", UID:\"bff886d1-846c-11e7-addd-0050569ccb52\", APIVersion:\"v1\", ResourceVersion:\"945\", FieldPath:\"\"}): type: 'Warning' reason: 'FailedAttachVolume' Multi-Attach error for volume \"pvc-2f53fe7e-846c-11e7-addd-0050569ccb52\" Volume is already exclusively attached to one node and can't be attached to another\n","stream":"stderr","time":"2017-08-18T23:27:07.15522094Z"}
{"log":"W0818 23:27:07.254711       1 reconciler.go:262] Multi-Attach error for volume \"pvc-2f53fe7e-846c-11e7-addd-0050569ccb52\" (UniqueName: \"kubernetes.io/vsphere-volume/[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\") from node \"node3\" Volume is already exclusively attached to one node and can't be attached to another\n","stream":"stderr","time":"2017-08-18T23:27:07.254837081Z"}

**At the end of 6 minutes, you will see attach/detach controller attempts a force delete after which attach volume on new node succeeds.**

**{"log":"W0818 23:33:07.140938**       1 reconciler.go:228] attacherDetacher.DetachVolume started for volume \"pvc-2f53fe7e-846c-11e7-addd-0050569ccb52\" (UniqueName: \"kubernetes.io/vsphere-volume/[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\") on node \"node2\" This volume is not safe to detach, but maxWaitForUnmountDuration 6m0s expired, force detaching\n","stream":"stderr","time":"2017-08-18T23:33:07.140998742Z"}
{"log":"I0818 23:33:07.141103       1 attacher.go:231]   Detach in attacher.go with deviceMountPath: \"[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\"\n","stream":"stderr","time":"2017-08-18T23:33:07.141180226Z"}
{"log":"I0818 23:33:07.141201       1 attacher.go:233]   Calling DiskIsAttached in attacher.go with volPath: \"[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\"\n","stream":"stderr","time":"2017-08-18T23:33:07.141248186Z"}
{"log":"I0818 23:33:07.141303       1 vsphere.go:1003]   DiskIsAttached with volPath: \"[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\" and nodeName: \"node2\"\n","stream":"stderr","time":"2017-08-18T23:33:07.141325846Z"}
{"log":"I0818 23:33:07.413977       1 vsphere.go:1041]   DiskIsAttached result with volPath: \"[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\" and nodeName: \"node2\" is isAttached: true and err: \u003cnil\u003e\n","stream":"stderr","time":"2017-08-18T23:33:07.414101776Z"}
{"log":"I0818 23:33:07.414265       1 attacher.go:250]   Calling DetachDisk in attacher.go with volPath: \"[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\"\n","stream":"stderr","time":"2017-08-18T23:33:07.414329139Z"}
{"log":"I0818 23:33:07.414359       1 vsphere.go:1225]   DetachDisk with volPath: \"[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\" and nodeName: \"node2\"\n","stream":"stderr","time":"2017-08-18T23:33:07.41448605Z"}
{"log":"I0818 23:33:08.855287       1 vsphere.go:1282]   DetachDisk result with volPath: \"[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\" and nodeName: \"node2\" is err: \u003cnil\u003e\n","stream":"stderr","time":"2017-08-18T23:33:08.855487181Z"}
{"log":"I0818 23:33:08.855387       1 operation_generator.go:348] DetachVolume.Detach succeeded for volume \"pvc-2f53fe7e-846c-11e7-addd-0050569ccb52\" (UniqueName: \"kubernetes.io/vsphere-volume/[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\") on node \"node2\" \n","stream":"stderr","time":"2017-08-18T23:33:08.855531178Z"}
{"log":"I0818 23:33:08.945540       1 reconciler.go:272] attacherDetacher.AttachVolume started for volume \"pvc-2f53fe7e-846c-11e7-addd-0050569ccb52\" (UniqueName: \"kubernetes.io/vsphere-volume/[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\") from node \"node3\" \n","stream":"stderr","time":"2017-08-18T23:33:08.945844415Z"}
{"log":"I0818 23:33:11.951325       1 reconciler.go:272] attacherDetacher.AttachVolume started for volume \"pvc-2f53fe7e-846c-11e7-addd-0050569ccb52\" (UniqueName: \"kubernetes.io/vsphere-volume/[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\") from node \"node3\" \n","stream":"stderr","time":"2017-08-18T23:33:11.951450457Z"}
{"log":"I0818 23:33:12.581761       1 operation_generator.go:275] AttachVolume.Attach succeeded for volume \"pvc-2f53fe7e-846c-11e7-addd-0050569ccb52\" (UniqueName: \"kubernetes.io/vsphere-volume/[vsanDatastore] kubevols/kubernetes-dynamic-pvc-2f53fe7e-846c-11e7-addd-0050569ccb52.vmdk\") from node \"node3\" \n","stream":"stderr","time":"2017-08-18T23:33:12.581846373Z"}

The issue is because of a recent change in kubernetes release 1.7 - https://github.com/kubernetes/kubernetes/pull/45346 which handles "Multi-Attach error for volume"
I think this is a very serious problems for us, as in case of vsphere volumes are not detached automatically when the node is powered off as in GCE or AWS.
@tusharnt @divyenpatel @luomiao @rohitjogvmw

Kubernetes issue tracking this - https://github.com/kubernetes/kubernetes/issues/50944

The PR - kubernetes#50944 on kubernetes is merged. I have created a new cherry-pick request onto 1.7 branch - https://github.com/kubernetes/kubernetes/pull/51226.

Cherry-pick into 1.7 release branch kubernetes#51226 merged.