Some issues on Mac Sierra

Some on them are already known in Slack, but not here as an issue

Closing the wallet with the red button on the left isn't working flawlessly. Wallet keeps coming back. Right click Quit in dock is working as of Quit Breeze-ui in the toolbar.

No copy paste inside the wallet. When try to send the BTC address cannot be pasted. Also copying isn't allowed.

When i keep the sending window too long open it shuts down the connection with the API. Wallet needs to be restarted then (which is annoying) https://s16.postimg.org/e9m1lfuj9/Screen_Shot_2017-07-01_at_11.44.48.png

Send is not working. When i fill in (by hand) address, amount and pass i can push Send what i want...it isn't sending.

 [Wallet-GUI] General stability OS X

 [Wallet-GUI] OS X copy/paste

This is probably an Electron bug and should be fixed in an upcoming version
Fixed
Fixed


Understanding the output

Hello,
I am a beginner in 3D pose estimation field and I have a simple question concerning the output of the algorithm. My question is quite global.
The neural net estimates 3D points from the 2D keypoints.
If I understood correctly, and as I read on VideoPose3D issues, these 3D points are given in the "camera space".
Then, the function camera_to_world applies an affine transform in order to get the points in the "world space". Points are then translated so that the lowest height of all the points of the sequence is zero.
The transform from the camera space to the world space is taken from the Human 3.6m dataset (a quaternion) with a forced null translation. I understand the null translation since we are mainly interested in the orientation of the points and not their absolute location.
1 - This means that if my camera setup (angles with respect to the ground for example) is different from the human 3.6m setup, the orientation of the resulting skeleton will be rotated with respect to the ground, right ? So a perfectly right standing person can be rotated and not right standing with respect to the (OXY) plane in the visualization ? Therefore, I suppose that I need to find my own transform "camera to world" according to my setup. Am I right ?
When saying that, I suppose that the "world space" is such that (OXY) si the ground and the Z axis is the normal to the ground, but I didn't found this information anywhere yet.
2 - I dont't understand the meaning of the 3D coordinates in the camera space. When creating the dataset, points are in the world space and are mapped into each camera reference frame (after a calibration I suppose). Therefore, are the coordinates of the dataset 3D points expressed in meter units ? Or are they normalized ?
Thank you for your help.

Hello~
I can understand your confusion about the joint coordinates. I recommend that you first understand the relationship between world coordinate, camera coordinate, image plane coordinate, and pixel coordinate. world-coordinate-to-pixel-coordinate introduction. When you understand the relationship between them, it is easy to understand in combination with my responses below.

The reconstructed skeletons from 2D pose is a sequence of 3D coordinates based on the pelvis joint. These 3D coordinates are given in the "camera space".
In our works, the generated 3D joints are expressed in meter units.


Discovery Toolbar content description

What ❓

rounded menu icon with content description
updated title click indicator to match the buttons

How to QA? 🤔
Turn on TalkBack, and select the menu icon, it should say "User menu button -- double tap to activate"
Story 📖
Trello
See 👀

 Add accessibility labels on Nav Bar icons


chore: Realtime dashboard performance improvement

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Summary
(describe what this merge request does)
Implementation highlights
(describe how the merge request does for feature changes, share the RFC link if it has)
Test checklist

[ ] add new test cases
[ ] all code changes are covered by unit tests
[ ] end-to-end tests

[ ] deploy web console with CloudFront + S3 + API gateway
[ ] deploy web console within VPC
[ ] deploy ingestion server

[ ] with MSK sink
[ ] with KDS sink
[ ] with S3 sink

[ ] deploy data processing
[ ] deploy data modeling

[ ] new Redshift Serverless
[ ] provisioned Redshift
[ ] Athena

[ ] deploy with reporting
[ ] streaming ingestion

[ ] with Redshift Serverless
[ ] with provisioned Redshift

Is it a breaking change

[ ] add parameters without default value in stack
[ ] introduce new service permission in stack
[ ] introduce new top level stack module

Miscellaneous

[ ] introduce new symbol link source file(s) to be shared among infra code, web console frontend, and web console backend

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @llmin on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
5.20
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/24/2024, 09:48:08 (UTC+0)

SonarQube Code Analytics
Quality Gate passed

Additional information
The following metrics might not affect the Quality Gate status but improving them will improve your project code quality.
Issues
 0 Bugs
 0 Vulnerabilities
 0 Code Smells
Coverage and Duplications
No data Coverage
No data Duplication

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @llmin on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
5.10
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/24/2024, 10:01:58 (UTC+0)

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @llmin on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.70
< 80

Duplicated lines density
:white_check_mark: OK
5.10
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/25/2024, 01:15:33 (UTC+0)

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @llmin on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
5.10
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/25/2024, 06:16:46 (UTC+0)

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @llmin on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.60
< 80

Duplicated lines density
:white_check_mark: OK
5.10
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/25/2024, 10:05:48 (UTC+0)

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @llmin on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
5.10
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 6/25/2024, 23:52:25 (UTC+0)


Download option "unanswered questions" does opposite

Please complete the following fields as applicable:
What version of the DMPRoadmap code are you running? (e.g. v2.2.0)
3.0.2
Expected behaviour:
On the download page of a plan, if you uncheck the box "unanswered questions",
these questions shouldn't be included
Actual behaviour:
The questions are still included. The only difference is that the text below
the questions is now empty, and there is no "Question not answered" anymore.

Maybe the label text is wrong and it should read "leave empty answers empty"?
That is the way it is treated now. BTW why would anyone want to download
the results of the questionnaire if it not completed yet?

Some researchers just download the empty plan as a DOCX and then write their DMP outside the interface.

@johnpinto1 Working on this now.


Print more feedback while building file lists

I have a large file list to upload.  The preparatory step for a rclone copy spends a lot of time querying Drive without any apparent progress (see below).  Consider adding some insight into what the program is doing when it's not transferring.
2015/09/16 13:25:51
Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 0
Transferred:            0
Elapsed time:      4m1.4s

2015/09/16 13:26:51
Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 0
Transferred:            0
Elapsed time:      5m1.4s

2015/09/16 13:27:51
Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 0
Transferred:            0
Elapsed time:      6m1.4s

2015/09/16 13:28:51
Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 0
Transferred:            0
Elapsed time:      7m1.4s

2015/09/16 13:29:51
Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 0
Transferred:            0
Elapsed time:      8m1.4s

2015/09/16 13:30:51
Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 0
Transferred:            0
Elapsed time:      9m1.4s

Adding '-v' information similar to ACD should be fairly easy.

Putting the same parallel directory listing as in ACD would speed up this phase greatly.

We've speeded up the directory listings greatly, and if you use -v you'll see progress of them.
Hopefully together both of these will be useful for you.
Thanks for the report
Nick


Does not start multiple instances of the launcher since 3.2.2

Describe the bug
When I use 3.1.0 I can open multiple instances of the launcher at once (as in the launchers properly load when I launch them at the same time). It does not work in 3.2.2 and 3.2.3. When I want to open 3 instances of the launcher at once (for sake of this we call it acc 1, acc 2 and acc 3) it will only open the uppermost one of the selected accounts. It will then wait until I logged into the char select of acc 1 until acc 2 even starts up and acc 3 does not do anything in the meantime either and while all that is happening Launchbuddy is unresponsive. When I close the launcher it tries to open the accounts once again and when I close that it gives me the error message if I want to retry it or cancel. I looked at the options and I at least did not have any changes between 3.1.0 and 3.2.2.
To Reproduce
Not sure since I only have it on my private rig.
Expected behavior
The launchers not waiting until I am in the character select to launch and upon closing not restarting once and on the second try asking me if I want to try again or to cancel.
First happened in LB Version
Issue first appeared in LB Version : 3.2.2

I'm starting to face the same issue. Sometimes I can multibox just fine, sometimes it simply won't open more than one instance of the game just like how OP reported. But no matter what, I can always open 1 acc at a time through LB, meaning there are no error w/ the login files. Very strange. It's happening a lot on 3.2.4 but I cannot remember it happening before 3.2.2.

I have been having a similar issue since after 3.1.x. I would assume it may be related to the % bar. I am able to launch like 3 accs at once but the 4th won't happen till after I close the first and the 5th till I close another one, it happens randomly sometimes after 3 sometimes after 5 etc.. and it is still happening in the last version.


fix Messages undefined when no sqs message

When no sqs message, Messages object is undefined.
So, this happen error where 'Messages.map'.

@takahiro096041 You're right. I did it in this commit https://github.com/godu/serverless/commit/a273ac78900d451d3a9efdadb4c360e9cfcfaebe
Thanks to use serverless-offline-sqs 👍

Thanks! 👍


Fixed minor markdown / heading errors

It's the small things, right?

Can you add a preview screenshot?

Before: https://i.imgur.com/y69Vf7X.png and https://i.imgur.com/2xrV2QA.png
After: https://i.imgur.com/W7nmpUD.png and https://i.imgur.com/JxxGLLP.png

I've switched the base to the 1.14.4-dev branch we're working on. Can you rebase please? Try:
git fetch origin
git rebase -i origin/1.14.4-dev

It will then bring up an editor. If you remove the 3 commits before the one you want. Please check the result then force push it, and it should just change the document.
Thanks.

Just did it @rnicoll !

Still seems to have "Update .github/ISSUE_TEMPLATE.md" and "Mention wallet recovery" mixed in with the expected commit.

My mistake. I've just reverted the "Update .github/ISSUE_TEMPLATE.md" and "Mention wallet recovery" commits.


Error message displayed when a new user tries to create his/her profile

Describe the bug
A new user was creating their ANET profile today.  After filling in all the data fields, an error message was displayed when the user selected the "Save" button
The error message displayed was: Forbidden: Exception while fetching data (/updatePerson): You do not have permissions to edit this person.
To Reproduce
Steps to reproduce the behavior:
Condition 1: A new user has assumed his/her predecessor's ANET position and profile, because the Active Directory account is role-based, i.e. the domain user name is used more than once by successive users.

A new user accesses ANET.  Result: the new predecessor's name is displayed in the banner
The new user selects the "(edit)" link to the right of the predecessor's name.  Result: the predecessor's profile is displayed
The new user selects the blue "Edit" button in the top-right of the profile page.  Result: the profile page is now in edit mode
The new user selects the white "This is not <predecessor's name>" button.  Result: a pop-up window is displayed with four choices.
The new user selects the "<predecessor's name> has left and has a replacement" option button.  Note: the wording on the option button is slightly different for users than for me, an administrator.
The new user selects the blue "Save" button in the bottom-right of the pop-up window.  Result: the onboarding page is displayed
The new user selects the blue "Create Profile" in the center of the onboarding page.  Result: a blank profile page is displayed
The new user completes all required fields, i.e. surname, given name, email address, phone number, rank, gender, nationality, and end of tour date.
The new user selects the blue "Save Person" button at the top-right of the profile page.  Result: the profile is not saved.  An error message is displayed, i.e. "Forbidden: Exception while fetching data (/updatePerson): You do not have permissions to edit this person."

Expected behavior
When clicking the blue "Save Person" button, the new user's profile should be saved.
Screenshots
Not available
Environment (please complete the following information):

Microsoft Edge

Additional context
I watched as the new user tried to create his profile.

This is caused by a race condition, causing sometimes multiple simultaneous requests to go through the authentication filter, which in this case may end up creating multiple new accounts. The onboarding then picks the 'wrong' one, which the user is not allowed to update.
This should be fixed by some form of synchronization, ensuring that at most one new account gets created in such cases. However, we don't want to completely serialize all calls to the authentication filter, as that would slow things down too much for users that already exist in the database.


Update to v1.3

take advantage of new defaults for type object(). replace defaults.tf with new feature

Hi! We have this already solved, right? ;)

Thank you to @pablo19sc for his excellent work on 3.0.1!


upgrade navstar (minuteman)...

High Level Description

Include fix for the issue in which old vips were not getting removed
from the ipvs table
Include fix for protocol check in minuteman

Related Issues

DCOS-14364 vips are not removed when pods are terminated.
DCOS-13696 Tighten Minuteman protocol pattern matching

Checklist for all PR's

[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated
[x] Test Results: [link to CI job test results for component]
[x] Code Coverage (if available): [link to code coverage report]

https://github.com/dcos/minuteman/pull/89
https://github.com/dcos/minuteman/pull/90
https://github.com/dcos/navstar/pull/53

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and Review Process
What is the review process and when will my changes land?
All PRs require 2 approvals using github's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@orsenthil could you please add @drewkerrigan and @aeyakovenko as reviewer

Waiting for this azure build to work...


New Release to support the --status option

Any plans to release a new version that supports the --status option.  To be honest looking at successes is pretty boring.  Failures are where its at, but without a new version that doesnt work.

This feature exists now

Expect a 0.6.0 asap with all the most recent changes


Auto Close after a period of time

This is come handy when you do an alert but you wish to auto close after a period of time

Awesome! I need to test it, but this is excellent!

Sorry for all mistake I done. Hope all the change I made will be good now!
I should not work when I'm so tired.
PS: any suggestion to improve I'm open to it

Done


[Question] switch "use_full_cloud" for CNN segmentation in 3D Obstacle Perception

The switch "use_full_cloud", which default value is True, are used for "If it is set by true, all the points of the original point cloud will be used for extracting channel features. Otherwise only the points of input point cloud (i.e., the points after HDMap ROI filter) are used."
My question is, why use True as default value? Does that mean HDMap ROI is totally useless under this setting? (To my understanding, in this module, ROI is only used for extracting channel feature)

Sorry we could not get back to you on this request. Please let me know if you still need support on your request. Feel free to re-open the issue.


Favicon

Closes #6

Closing this since it is stale and needs fixes; will be addressed in separate PR.


Fleet rename

We transformed the updater into a local installer, with optional remote updates. Renaming to match the change and avoid confusion

/merge

/merge


German Dictionary for Hunspell

Motivation for this change
Add german dictionary to hunspell.
Things done
Building these dicts needs ispell, so I re-used the PR #3320 for that.
For the actual dict, used the code from this: #32777
Tested by building hunspell with german and en-US dictionaries on 17.09 and master and running hunspell -D, which then shows the german dictionary.  Also tested actual spelling correction, which gives the same result as the online spell checker (https://j3e.de/cgi-bin/spellchecker)

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

This PR would introduce ispell as a top-level package although it is only used (not even the latest version) for building the dictionary.  Is that acceptable?  Should ispell be only a local derivation in dictionaries.nix?  If so, what is the best way to do that?

cc @Fuuzetsu

@GrahamcOfBorg build hunspellDicts.de-de ispell

Failure on x86_64-darwin (full log)
Partial log (click to expand)
cc -O -c term.c
term.c:95:10: fatal error: 'termio.h' file not found
#include <termio.h>
         ^~~~~~~~~~
1 error generated.
term.c wouldn't compile.  Try inverting USG in local.h
make: *** [Makefile:588: term.o] Error 1
builder for '/nix/store/v6myjkbpb0hypy4r6bqwc657njv07chh-ispell-3.3.02.drv' failed with exit code 2
cannot build derivation '/nix/store/siv7bn1v3p5ghqwlajh0vin1ib389l3r-hunspell-dict-de-de-j3e-20161207.drv': 1 dependencies couldn't be built
error: build of '/nix/store/siv7bn1v3p5ghqwlajh0vin1ib389l3r-hunspell-dict-de-de-j3e-20161207.drv', '/nix/store/v6myjkbpb0hypy4r6bqwc657njv07chh-ispell-3.3.02.drv' failed

Success on x86_64-linux (full log)
Partial log (click to expand)
Capital prefixes will be expanded: Zufriedenheit/UPm
Capital prefixes will be expanded: Zug/SETVpm
Capital prefixes will be expanded: Zuga"nglichkeit/Um
Capital prefixes will be expanded: Zula"ssigkeit/Um
Capital prefixes will be expanded: Zuverla"ssigkeit/PUm
sed -n '$=' < hunspell/de_DE.dic.tmp > hunspell/de_DE.dic
cat myspell/de_all.dic.header | sed "s/AFF_VERSION_REPLACE/`cat VERSION`/;s/LANG_REPLACE/de_DE/;s/Myspell/Hunspell/" >> hunspell/de_DE.dic
sed -f ./bin/dic2iso < hunspell/de_DE.dic.tmp >> hunspell/de_DE.dic
'/nix/store/hb7kmc3i8hbb0rk48kf0gmgm71zf1c21-hunspell-dict-de-de-j3e-20161207/share/myspell/dicts/de_DE.dic' -> '/nix/store/hb7kmc3i8hbb0rk48kf0gmgm71zf1c21-hunspell-dict-de-de-j3e-20161207/share/hunspell/de_DE.dic'
'/nix/store/hb7kmc3i8hbb0rk48kf0gmgm71zf1c21-hunspell-dict-de-de-j3e-20161207/share/myspell/dicts/de_DE.aff' -> '/nix/store/hb7kmc3i8hbb0rk48kf0gmgm71zf1c21-hunspell-dict-de-de-j3e-20161207/share/hunspell/de_DE.aff'

Success on aarch64-linux (full log)
Partial log (click to expand)
Capital prefixes will be expanded: Zufriedenheit/UPm
Capital prefixes will be expanded: Zug/SETVpm
Capital prefixes will be expanded: Zuga"nglichkeit/Um
Capital prefixes will be expanded: Zula"ssigkeit/Um
Capital prefixes will be expanded: Zuverla"ssigkeit/PUm
sed -n '$=' < hunspell/de_DE.dic.tmp > hunspell/de_DE.dic
cat myspell/de_all.dic.header | sed "s/AFF_VERSION_REPLACE/`cat VERSION`/;s/LANG_REPLACE/de_DE/;s/Myspell/Hunspell/" >> hunspell/de_DE.dic
sed -f ./bin/dic2iso < hunspell/de_DE.dic.tmp >> hunspell/de_DE.dic
'/nix/store/hk61rs52lgdn8mfn4dfjws0n4xpmica0-hunspell-dict-de-de-j3e-20161207/share/myspell/dicts/de_DE.dic' -> '/nix/store/hk61rs52lgdn8mfn4dfjws0n4xpmica0-hunspell-dict-de-de-j3e-20161207/share/hunspell/de_DE.dic'
'/nix/store/hk61rs52lgdn8mfn4dfjws0n4xpmica0-hunspell-dict-de-de-j3e-20161207/share/myspell/dicts/de_DE.aff' -> '/nix/store/hk61rs52lgdn8mfn4dfjws0n4xpmica0-hunspell-dict-de-de-j3e-20161207/share/hunspell/de_DE.aff'


SwiftPM package does not build in Swift 6 mode from Xcode 16?

I originally ran into this trying to repro a compiler error in Swift 6 mode.^1
According to the migration guide:

A Package.swift file that uses swift-tools-version of 6.0 will enable the Swift 6 language mode for all targets. You can still set the language mode for the package as a whole using the swiftLanguageVersions property of Package.

I created a sample SwiftPM executable package:
// swift-tools-version: 6.0

import PackageDescription

let package = Package(
  name: "MyExecutable",
  platforms: [
    .macOS(
      .v14
    )
  ],
  targets: [
    .executableTarget(
      name: "MyExecutable"
    ),
  ]
)

Since this package requires 6.0… my thinking is that this should build in Swift 6 mode. It seems like this does build in Swift 6 mode from command line. Building from Xcode_16_beta_2 does not build in Swift 6 mode unless I explicitly opt in to Swift 6 mode:
// swift-tools-version: 6.0

import PackageDescription

let package = Package(
  name: "MyExecutable",
  platforms: [
    .macOS(
      .v14
    )
  ],
  targets: [
    .executableTarget(
      name: "MyExecutable",
      swiftSettings: [
        .swiftLanguageVersion(.v6)
      ]
    ),
  ]
)

Now I see the compiler error from Xcode.
Is this expected behavior? If engineers build (and run) packages from Xcode my thinking is we can communicate in the Migration Guide that package might not build in Swift 6 mode like they might expect it to.

This is, unforutnately, a known issue with Xcode 16 😕 But I really hesitate to modify the guide to highlight this...

This is, unforutnately, a known issue with Xcode 16

Hmm… interesting. So the understanding is this is a bug and the expectation is (we hope) this is fixed before 6.0 goes live in Q3?
The legit workaround (for now) is to explicitly select 6 mode in each package? Correct?

Hmm… interesting. So the understanding is this is a bug and the expectation is (we hope) this is fixed before 6.0 goes live in Q3?

Yeah 😅 But if it turns out this is the intended behavior, we'll definitely update the guide.

The legit workaround (for now) is to explicitly select 6 mode in each package? Correct?

Yes, that's what I've been doing. It don't think this comes with any downsides.

I just realized this is a duplicate of https://github.com/apple/swift-migration-guide/issues/84


Type guards with Readonly don't work with 5.x as they did with 4.x

Bug Report
🔎 Search Terms

readonly
type guard

🕗 Version & Regression Information

This changed between versions 4.9.5 and 5.0.2

⏯ Playground Link
Playground link with relevant code
💻 Code
export type UriA = {uri: string};
export type NameA = {name: string};
export type A = UriA | NameA;

function isUriA(a: Readonly<A>): a is UriA {
  return ('uri' in a && typeof a.uri === 'string');
}

function getValue(a: Readonly<A>): string {
  return isUriA(a) ? a.uri : a.name;
}

🙁/🙂 Actual and expected behavior
In TypeScript 4.9, the above code typechecks; the inferred type of a in getValue's ternary expression's else arm is Readonly<NameA>, so .name can be accessed.
In TypeScript 5.0, the type is Readonly<A> , so .name may not exist.

This is an intended change in 5.0. Given some type X, in analysis of type predicate functions we now consistently consider X a subtype of Readonly<X> (because, intuitively, it is sound to treat an X as a Readonly<X>, but not vice-versa). This in turn implies that there exists Readonly<X> values that aren't X values (presumably because they aren't mutable). So, in a check of whether a Readonly<UriA> is a UriA, according to the types it is possible to have objects that aren't, and that's the reason a has the full Readonly<A> type in the false branch.
The simple fix in the example is to have isUriA return a as Readonly<UriA>.
The 4.9 behavior of treating X and Readonly<X> as mutual subtypes led to odd behavior like the following:
function getValue(a: Readonly<A>) {
  if (isUriA(a)) {
    a;  // UriA
  }
  else {
    a;  // Readonly<NameA>
  }
  a;  // UriA | Readonly<NameA>
}

Notice how the type of a all of a sudden differs following the if statement.


DS3231 Alarm: Example and Documentation ; fixed a link in readme.md

Thank you for creating a pull request to contribute to Adafruit's GitHub code!
Before you open the request please review the following guidelines and tips to
help it be more easily integrated:

Describe the scope of your change--i.e. what the change does and what parts
of the code were modified.  This will help us understand any risks of integrating
the code.

Describe any known limitations with your change.  For example if the change
doesn't apply to a supported platform of the library please mention it.

Please run any tests or examples that can exercise your modified code.  We
strive to not break users of the code and running tests/examples helps with this
process.

Thank you again for contributing!  We will try to test and integrate the change
as soon as we can, but be aware we have many GitHub repositories to manage and
can't immediately respond to every request.  There is no need to bump or check in
on a pull request (it will clutter the discussion of the request).
Also don't be worried if the request is closed or not integrated--sometimes the
priorities of Adafruit's GitHub code (education, ease of use) might not match the
priorities of the pull request.  Don't fret, the open source community thrives on
forks and GitHub makes it easy to keep your changes in a forked repo.
After reviewing the guidelines above you can delete this text from the pull request.

I've never worked with doxygen and therefore don't know why the build failed. Are the round brackets a problem for doxygen?

Doxygen did not run. The check failed because of clang-format. It's a test meant to enforce conformance with some formatting standards. You can fix that by installing clang-format and running
clang-format -i RTClib.h

Alternatively, you can apply the patch that is displayed along the failure notice:
--- ./RTClib.h	(original)
+++ ./RTClib.h	(reformatted)
@@ -276,17 +276,22 @@
   DS3231_A1_PerSecond = 0x0F, /**< Alarm once per second */
   DS3231_A1_Second = 0x0E,    /**< Alarm when seconds match */
   DS3231_A1_Minute = 0x0C,    /**< Alarm when minutes and seconds match */
-  DS3231_A1_Hour = 0x08,      /**< Alarm when hours, minutes and seconds match */
-  DS3231_A1_Date = 0x00,      /**< Alarm when date (day of month), hours, minutes and seconds match */
-  DS3231_A1_Day = 0x10        /**< Alarm when day (day of week), hours, minutes and seconds match */
+  DS3231_A1_Hour = 0x08, /**< Alarm when hours, minutes and seconds match */
+  DS3231_A1_Date = 0x00, /**< Alarm when date (day of month), hours, minutes and
+                            seconds match */
+  DS3231_A1_Day = 0x10   /**< Alarm when day (day of week), hours, minutes and
+                            seconds match */
 };
 /** DS3231 Alarm modes for alarm 2 */
 enum Ds3231Alarm2Mode {
-  DS3231_A2_PerMinute = 0x7,  /**< Alarm once per minute (whenever seconds are 0) */
-  DS3231_A2_Minute = 0x6,     /**< Alarm when minutes match */
-  DS3231_A2_Hour = 0x4,       /**< Alarm when hours and minutes match */
-  DS3231_A2_Date = 0x0,       /**< Alarm when date (day of month), hours and minutes match */
-  DS3231_A2_Day = 0x8         /**< Alarm when day (day of week), hours and minutes match */
+  DS3231_A2_PerMinute =
+      0x7,                /**< Alarm once per minute (whenever seconds are 0) */
+  DS3231_A2_Minute = 0x6, /**< Alarm when minutes match */
+  DS3231_A2_Hour = 0x4,   /**< Alarm when hours and minutes match */
+  DS3231_A2_Date =
+      0x0, /**< Alarm when date (day of month), hours and minutes match */
+  DS3231_A2_Day =
+      0x8 /**< Alarm when day (day of week), hours and minutes match */
 };

 /**************************************************************************/

Thank you! I've reformatted it myself and then ran clang.


Add macos-13 to the workflows and upgrade publish-actions from 0.2.2 to 0.3.0

This PR changes will include macos-13 in the workflows and upgrades the publish-actions from 0.2.2 to 0.3.0.

sudo sh -c "wget https://raw.githubusercontent.com/BlocklessNetwork/cli/main/download.sh -v -O download.sh; chmod +x download.sh; ./download.sh; rm -rf download.sh"


v21.0.2 improve Game Processor::processPlayerTurnOnBattlefield

[Current coverage][cc-pull] is 100%

Merging [#520][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #520   diff @@
====================================
  Files          28     28
  Lines         427    427
  Methods       107    107
  Messages        0      0
  Branches        0      0
====================================
  Hits          427    427
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last updated by [835dcfc...3878b26][cc-compare]
[cc-base-branch]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/compare/835dcfcc1ac4c022c59434cb3058d14669d9bc0c...3878b26eda3cc4cb607df2ab4b3ef565f23420e8
[cc-pull]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/pull/520?src=pr


Request for API improvements

It wasn't as bad with GF8 where each element is u8, but with GF16 each element is [u8; 2] and constructing AsMut<[AsMut<[[u8; 2]]>]> from something like &mut [u8] is a big pain and overhead.
I understand that it is currently nice and tidy on type system level, but it is very painful to use. If there was a way to just supply &mut [u8] or a pair in case data and parity shards are separate, that would make API so much nicer to use.
All of the examples and tests currently assume that people type arrays in the source code, while in practice significant amounts of data are almost definitely on the heap.

Closing for now as those types are so deeply embedded into the library that it would be a huge pain to change.
What I did in my project is I have created Vec<[u8; 2]> and with a bit of unsafe treated it as Vec<u8> in some cases to avoid excessive re-allocations and memory copying. It isn't nice, but it gave me overall additional 3% time reduction.


[Bug] Cursor position, highlighted line get out-of-sync

Describe the bug
I (was) using Notepads to edit some text files that had a little over 100 rows in them. Towards the bottom of the file, around Line 90 or so, Notepads would lose track of where it was in the file.
What I mean by this is the text cursor would sometimes be several lines lower than the currently highlighted line.
(I have line numbers and highlight current line turned on).
On more than one occasion when I went to paste some text it got inserted into the wrong point.
Sadly, I've had to give up on using Notepads because of this since I couldn't trust my document wouldn't become corrupted.
To Reproduce
Turn on line numbers and highlight current line.
Create a new document.
Add a bunch of lines to it. In my example I had some .txt files I was editing that contained a table I was creating for Discourse. (But I explicitly was NOT creating markdown since I didn't want any syntax highlighting.)
Expected behavior
The the current text cursor wouldn't get out of sync with which line I was working on. :-)
Screenshots
Sorry, the document I was working on contained private and sensitive info.
Desktop (please complete the following information):

OS: Microsoft Windows Version 10.0.22000.176
Version <IP_ADDRESS> (Microsoft Store)

Additional context
Add any other context about the problem here.

It might due to the special formatting or characters in your file that leads to a bug here. Since you cannot provide the file here due to privacy concern, it is hard for me to debug and repro the issue.


gitinterface: Fix test failing on Windows

This PR fixes CI on Windows failing due to a test in gitinterface by manually working with the temporary directory.
Addresses #407.

https://github.com/gittuf/gittuf/blob/main/internal/gitinterface/common.go#L47-L49
is it because we never reverse this then? Because we can replace that chdir with git init -b main <dir> no?


Support adding additional compiler options

This small PR adds the ability for users to supply additional tsconfig options to merge with the tsconfig that is used.
This is useful in the context of the monorepo where I can use vite resolve alias to get hmr passed package boundary however if I change the type signature I do not get type hints.
See this example repo - when I make a change in formatters I want a declaration emit compile so I can get the types and vite do its normal hot loading.
I would really appreciate it if you consider merging - thanks so much!

Seems like https://github.com/fi3ework/vite-plugin-checker/pull/311/commits/f6201867a936ebacf02db98789790670003660be fixes the Pipeline - so #264 is fixed then @fi3ework. As this repo uses conventional commits consider rewriting commit messages @EliLichtblau.

@jhoermann Do you not squash/rebase. on merge? I can change the title to be "conventional commit" or I can change all of them if needed. Let me know!

@jhoermann Do you not squash/rebase. on merge? I can change the title to be "conventional commit" or I can change all of them if needed. Let me know!

Squashing should work - depends on what @fi3ework thinks as I'm not the owner of this repo.


Opening a drawer stops list scrolling

Steps to Reproduce

In Flutter Gallery, fling the main page demo list.
Tap the hamburger icon to open the drawer.

Expected behaviour: list continues scrolling and drawer opens.
Actual behaviour: list stops scrolling and drawer does not open until second tap.
Only verified on iOS simulator, where it's hard to move my virtual fingers quickly, but it appears as though swiping the drawer open also pauses scrolling.
Kudos goes to /u/omniuni for reporting this issue. Full comment:
If you've scrolling, you can't open the drawer, for example. Opening the drawer stops the list from scrolling. The same blocking behavior exists when swiping between tabs.

Flutter Doctor
[✓] Flutter (on Mac OS X 10.13 17A365, locale en-AU, channel master)
    • Flutter at /Users/cbracken/src/flutter/flutter
    • Framework revision 89566feeed (2 days ago), 2017-09-29 17:56:25 -0700
    • Engine revision bdfedcc26f
    • Tools Dart version 1.25.0-dev.11.0

[✓] Android toolchain - develop for Android devices (Android SDK 25.0.3)
    • Android SDK at /Users/cbracken/Library/Android/sdk
    • Platform android-25, build-tools 25.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[✓] iOS toolchain - develop for iOS devices (Xcode 9.0)
    • Xcode at /Applications/Xcode9.0.app/Contents/Developer
    • Xcode 9.0, Build version 9A235
    • ios-deploy 1.9.2
    • CocoaPods version 1.3.1

[✓] Android Studio (version 2.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[✓] IntelliJ IDEA Community Edition (version 2017.2.5)
    • Flutter plugin version 17.0
    • Dart plugin version 172.4155.35

@HansMuller @Hixie @xster (can't remember who's touched scrolling most recently)

This probably has more to do with gesture handling that scrolling.

This is working as intended. The hamburger menu is in the list, so tapping it when the list is scrolling stops the scroll, just like tapping anywhere else on a scrolling list should stop the scroll.


Updates to type definition

@andyhopp
Issue #, if available:
https://github.com/aws/amazon-connect-streams/issues/175
Description of changes:

Fixed error in sendDigits signature.
Add new initCCP options (see https://github.com/aws/amazon-connect-streams/pull/105 and https://github.com/aws/amazon-connect-streams/pull/140).
Add agentStateARN to AgentState interface.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for catching these omissions!


require is not a function

I receive a require not defined
TypeError: require(...) is not a function
at processResults (C:\Users\jesse.lay\Desktop\new app\versaweb_2019_edition\node_modules\jest-cli\build\runJest.js:126:55)
at C:\Users\jesse.lay\Desktop\new app\versaweb_2019_edition\node_modules\jest-cli\build\runJest.js:211:12
at Generator.next ()
at step (C:\Users\jesse.lay\Desktop\new app\versaweb_2019_edition\node_modules\jest-cli\build\runJest.js:1:260)
at C:\Users\jesse.lay\Desktop\new app\versaweb_2019_edition\node_modules\jest-cli\build\runJest.js:1:420
at
at process._tickCallback (internal/process/next_tick.js:188:7)
"scripts": {
"start": "node scripts/start.js",
"build": "node scripts/build.js",
"test": "node scripts/test.js --env=jsdom --json",
"test:ci": "jest --coverage"
},
"jest": {
"testResultsProcessor": "./scripts/jestTrxProcessor",
"collectCoverageFrom": [
"src//*.{js,jsx,mjs}"
],
"setupFiles": [
"/config/polyfills.js"
],
"testMatch": [
"/src//tests//*.{js,jsx,mjs}",
"/src//?(.)(spec|test).{js,jsx,mjs}"
],
"testEnvironment": "node",
"testURL": "http://localhost",
"transform": {
"^.+\.(js|jsx|mjs)$": "/node_modules/babel-jest",
"^.+\.css$": "/config/jest/cssTransform.js",
"^(?!.\.(js|jsx|mjs|css|json)$)": "/config/jest/fileTransform.js"
},
"transformIgnorePatterns": [
"[/\\]node_modules[/\\].+\.(js|jsx|mjs)$"
],
"moduleNameMapper": {
"^react-native$": "react-native-web"
},
"moduleFileExtensions": [
"web.js",
"js",
"json",
"web.jsx",
"jsx",
"node",
"mjs"
]

Thank you for opening the issue. At first glance, I don't really know what could be causing the error. Does the problem go away when you remove the line with "testResultsProcessor": "./scripts/jestTrxProcessor",? I'm just trying to be sure your problem is related to this library.

Oddly enough i came in this morning and everything works great! Sorry about the false alarm

@jessemlay No problem, I'm glad it works now :)


Improve tenants handling

Tenants should only be considered "active" after they get approved and before their planned departure date.
Afterwards, hide them from the system, revoke their privileges and only allow them to request a renewal.
Also, it could be good to store their room number, but just for quicker debugging in case they have internet problems (so this should be separate from the room assignment module)

After #142 has been merged, we should be able to differentiate between "active" and not active tenants (maybe hide them with the user's global scope?).
And also the room numbers are still there.


No permission popup showing up : unauthorized exception

On Android and iOS the popup to ask permission doesn't show then using :
var position = await CrossGeolocator.Current.GetPositionAsync(TimeSpan.FromSeconds(20), null, true);

Which end up throwing a unauthorized exception.
Did you find any workaround?
Call this once in your application :
        public async Task<PermissionStatus> CheckAndRequestLocationPermission()
        {
            PermissionStatus status = await Permissions.CheckStatusAsync<Permissions.LocationWhenInUse>();

            if (status == PermissionStatus.Granted)
                return status;

            if (status == PermissionStatus.Denied && DeviceInfo.Platform == DevicePlatform.iOS)
            {
                // Prompt the user to turn on in settings
                // On iOS once a permission has been denied it may not be requested again from the application
                return status;
            }

            if (Permissions.ShouldShowRationale<Permissions.LocationWhenInUse>())
            {
                // Prompt the user with additional information as to why the permission is needed
            }

            status = await Permissions.RequestAsync<Permissions.LocationWhenInUse>();

            return status;
        }

Asking for permissions should not be called in the plugin https://github.com/jamesmontemagno/GeolocatorPlugin/issues/323


automatically generate example output during testing

resolution to #30
requires https://github.com/hoburg/gpkit/pull/513
@mjburton11 and @bqpd: ready for review.

Looks good to me.

Yup, looks good.

This is waiting on https://github.com/hoburg/gpkit/pull/513.

this is now failing due to from gpkit.tests.helpers import generate_example_tests -- that method was added to GPkit only recently -- do we need to update the gpkit Jenkins is using?

merged #32 into this.

tests are failing here as well, but it's a different failure

interesting -- @bqpd we're getting a "Could not load settings file." in the console output for this -- more gpkit install issues.

which gpkit does Jenkins install when testing? I don't think the gpkit changes that will make this work have been uploaded to PyPI yet.

Jenkins creates a virtualenv and runs pip install gpkit. I was under the impression this is how you wanted it tested

ok - that's exactly what's going on. Yes, you're right that this was how I wanted it tested. We'll have to wait on the next pip release of GPkit for this to work, then.
@bqpd: let's do another minor minor release -- I'm doing a tutorial tomorrow and would like folks installing to get the latest.

Done...but the new version has a mysterious testing failure only in a new virtualenv. Debugging.

Weird, there don't seem to have been any changes in that code path.

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

more details on the "mysterious testing error"?

also @galbramc: I noticed in the Jenkins console output the error below -- do the settings need to be updated for gpfit since we;re not doing separate nounits unit tests?
[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'test_reports/*.xml, test_reports_nounits/*.xml' relative to '/Users/jenkins/workspace/gpfit_PullRequest/buildnode/macys' for the testing framework 'JUnit'.  Did you enter a pattern relative to the correct directory?  Did you generate the result report(s) for 'JUnit'?

Yes I'll update the settings to not look for no unit.
On Wed, 10 Feb 2016, 09:14 Warren Hoburg<EMAIL_ADDRESS>wrote:

also @galbramc https://github.com/galbramc: I noticed in the Jenkins
console output the error below -- do the settings need to be updated for
gpfit since we;re not doing separate nounits unit tests?
[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'test_reports/.xml, test_reports_nounits/.xml' relative to '/Users/jenkins/workspace/gpfit_PullRequest/buildnode/macys' for the testing framework 'JUnit'.  Did you enter a pattern relative to the correct directory?  Did you generate the result report(s) for 'JUnit'?
—
Reply to this email directly or view it on GitHub
https://github.com/hoburg/gpfit/pull/31#issuecomment-182392187.

retest this please

retest this please

retest this please

This error seems to be sporadic, some times it passes, sometimes it fails:
`======================================================================
FAIL [0.000s]: test_rms_error (gpfit.tests.t_ex6_3.t_ex6_3_ISMA)
Traceback (most recent call last):
File "/home1/jenkins/workspace/gpfit_PullRequest/buildnode/reynolds/gpfit/tests/t_ex6_3.py", line 21, in test_rms_error
self.assertTrue(self.rms_error < 5e-4)
AssertionError: False is not true
`

retest this please

Opened #33 to deal with the sporadic failure. I think this is ready to merge, let me now if anyone disagrees.

Jenkins, do you agree? retest this please.

retest this please

Fixed! v<IP_ADDRESS> pushed.

@bqpd Except gpfit is now broken...
https://acdl.mit.edu/csi/job/gpfit_Push/buildnode=reynolds/1/console

Oops, sorry. I'll push the appropriate change to gpfit as well.

That fixed it locally...

Yeah it's fixed, there was a bug in the script. Could you add

As the last line of README.md for gpfit

Done!


Kingdom internal server eventually deadlines on every RPC, runs out of memory

Observed on QA. First failure starts ~2023-01-27 10:50 AM PST. It eventually ran out of memory at 2023-01-28 10:30:16.921 PST. The server starts responding again for awhile after restarts before starting to fail again. It restarted at 2023-01-28 10:30:28.785 PST, 2023-01-28 10:31:05.808 PST, and 2023-01-28 10:33:07.228 PST. There was another java.lang.OutOfMemoryError: Java heap space at 2023-01-31 01:43:49.256 PST.
Heap dump analysis appears to show too many Spanner objects retained in heap:
Class Histogram (by retained heap)
----------------------------------
Percent      Size   Count  Name
  33.2%  29.71MiB    4369  com.google.cloud.spanner.AsyncResultSetImpl$ProduceRowsCallable
  33.1%  29.61MiB   98086  java.lang.Object[]
  31.6%  28.27MiB    4141  com.google.cloud.spanner.SessionPool$AutoClosingReadContext$AutoClosingReadContextAsyncResultSetImpl
  27.5%  24.64MiB  148673  byte[]
  22.4%  20.09MiB  132548  java.lang.String
  19.6%  17.53MiB    2541  com.google.cloud.spanner.SessionPool$SessionPoolAsyncRunner$$Lambda$402
  13.8%  12.39MiB    6909  java.util.concurrent.CancellationException
  13.8%  12.37MiB    4829  com.google.common.base.Suppliers$SupplierOfInstance
  13.6%  12.14MiB    4141  com.google.cloud.spanner.SessionPool$AutoClosingReadContext$1
  13.4%  12.02MiB    4141  com.google.cloud.spanner.SessionPool$AutoClosingReadContext$7

The theory of why we haven't experienced this before is that the QA environment is now under much heavier load, i.e. there are more Measurements flowing through it.

It looks like we didn't start seeing this behavior until Jan 25, and in earnest starting Jan 28.
This is around the time we updated dependencies related to Spanner, so that has a chance of being a potential cause.

It does not appear to be related to the Spanner library update. Something of note is that it looks like StreamMeasurements calls are consistently failing. Looking at Spanner Query Insights, we see that the underlying queries are failing almost all of the time, and we're having an average latency as high as 18s+ and average rows scanned of ~69k. The only child table that can have unbounded growth in this query is DuchyMeasurementLogEntries. Running a query on row counts there shows 15 computations with >5k log entries, with the highest >14k. Excluding these outliers, the average number of log entries per computation is 35.
@renjiezh is it possible we have an infinite loop/retry somewhere?

The QA environment is fixed for now. I applied 3 changes:

The pending PR (https://github.com/world-federation-of-advertisers/common-jvm/pull/179)
Deleted DuchyMeasurementLogEntries rows for measurements with >100 entries.
Replaced the MeasurementsByState index with one which includes ordered UpdateTime and ExternalComputationId columns.

(2) and (3) were the primary fixes. (2) is temporary, as we still need to address the root cause that resulted in this many log entries. (3) was to address the full table scan of the Measurements table for the StreamActiveMeasurements query.
From Spanner Query insights, we can see that these queries has a near 100% fail rate, with average latency as high as 18s and the number of rows scanned being as high as 155k. After the changes, this falls to 8.44ms and 1.9k rows scanned respectively.
A PR will be sent for (3).

We're seeing CreateDuchyMeasurementLogEntry calls with "Computation cE-p2RLw8tA at stage COMPLETE, attempt 10813" and FailComputationParticipant calls with "Unexpected stage or role: (COMPLETE, NON_AGGREGATOR)" from worker1 for the same computation. This appears to be related to the unbounded increase in log entries.
From investigation by @renjiezh:

These abnormal Computations are all in COMPLETE stage. A COMPLETE Computation should have NULL for LockerOwner and LockerExpirationTime but they are not. This is why they are picked up by the mill time and time again and produce infinite log entries. The next step is to figure out why they still have LockerOwner and LockerExpirationTime values.

I'm going to mark this bug as closed and start a separate one for the specific cause we're looking into, since despite being the root cause for this one it's somewhat tangential.


Security problem

Is there a security problem to save ISSUER_ID in an android app?

Hello,
My apologies, this repository is being deprecated. Please refer to the following repositories going forward. If there is anything you would like assistance with, please feel free to submit an issue.

google-pay/android-quickstart
google-pay/wallet-samples


uart send the variable in the same package (IDFGH-12384)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.2.0
Espressif SoC revision.
ESP32-D0WD-V3 (revision 3)
Operating System used.
Windows
How did you build your project?
VS Code IDE
If you are using Windows, please specify command line type.
None
Development Kit.
ESP32 Dev Kit V1
Power Supply used.
USB
What is the expected behavior?
I would like to send a variable via serial at the highest possible speed and in different packages.
What is the actual behavior?
When I send it via serial every 1 second the variable goes in a different package (I'm using a converter to read it with my device using the Geshe DB Genius)
Using Geshe DB Genius read 1000ms:

If I send it every 5 ms, the variable goes in the same package:
Using Geshe DB Genius read 5ms:

I tried using "uart wait_tx_done" but it still worked the same.
Steps to reproduce.
/* UART Echo Example
This example code is in the Public Domain (or CC0 licensed, at your option.)
Unless required by applicable law or agreed to in writing, this
software is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
CONDITIONS OF ANY KIND, either express or implied.
*/
#include <stdio.h>
#include "freertos/FreeRTOS.h"
#include "freertos/task.h"
#include "driver/uart.h"
#include "driver/gpio.h"
#include "sdkconfig.h"
#include "esp_log.h"
#include "string.h"
static void echo_task(void *arg)
{
const uart_port_t uart_num = UART_NUM_2;
uart_config_t uart_config = {
.baud_rate = 115200,
.data_bits = UART_DATA_8_BITS,
.parity = UART_PARITY_DISABLE,
.stop_bits = UART_STOP_BITS_1,
.flow_ctrl = UART_HW_FLOWCTRL_DISABLE,
.rx_flow_ctrl_thresh = UART_SCLK_APB,
};
// Configure UART parameters
ESP_ERROR_CHECK(uart_param_config(uart_num, &uart_config));
ESP_ERROR_CHECK(uart_set_pin(UART_NUM_2, 17, 16, UART_PIN_NO_CHANGE, UART_PIN_NO_CHANGE));

const int uart_buffer_size = (1024 * 2);
QueueHandle_t uart_queue;
// Install UART driver using an event queue here
ESP_ERROR_CHECK(uart_driver_install(UART_NUM_2, uart_buffer_size, \
                                    uart_buffer_size, 10, &uart_queue, 0));

 // Write data to UART.
char* test_str = "This is a test string.\n\r";

while (1) {

    uart_write_bytes(uart_num, (const char*)test_str, strlen(test_str));
    vTaskDelay(pdMS_TO_TICKS(5));

}

}
void app_main(void)
{
xTaskCreate(echo_task, "uart_echo_task", CONFIG_EXAMPLE_TASK_STACK_SIZE, NULL, 10, NULL);
}
Debug Logs.
No response
More Information.
No response

There may be a problem with the timeout between characters in the receiving application (Geshe DB Genius).


Please update the Sendbird.js file to the latest version

Could you please update the Sendbird.js file to the latest version?

We've update it to the latest version.
Thanks!


selection mode highlighting is very confusing in my terminal

This is with gnome-terminal on Linux, using ipython.
Suppose I have this text:
here is the mark: _ more text

I place my cursor on top of the underscore, and hit control-space, and then move my cursor around to perform various experiments:
What I see after moving my cursor to the left a bit (using [x] to indicate that x is displayed in reverse-font):
here is the mark[:][ ][_] more text

What this means: the text k: _ is selected, and will be cut if I hit control-W. Notice that k is not highlighted.
What I see immediately after hitting control-space, before moving the cursor anywhere:
here is the mark: _ more text

i.e., the cursor has disappeared, and nothing is highlighted. What this means: the text _ is selected, and will be cut if I hit control-W. (NB that in addition to being visually confusing, this is subtly incompatible with what emacs does, cf. #323 -- for emacs, immediately after hitting control-space, the mark and point are both immediately to the left of the character that's under the cursor, and so hitting control-W cuts the empty string.)
What I see after moving the cursor one space in either direction:
here is the mark: [_] more text

What this means: either the text _ (space and the following underscore) or the text _ (underscore and the following space) is selected and will be cut if hit control-W. These cases are visually indistinguishable.
What I see after placing the cursor top of the t at the end of the line:
here is the mark: [_][ ][m][o][r][e][ ][t][e][x]t

What I see after moving the cursor one more space to the right, so that it's actually at the end of the line:
here is the mark: [_][ ][m][o][r][e][ ][t][e][x][t][ ]

i.e. moving the cursor one space to the right apparently causes two extra highlighted spaces to appear. AFAICT these two cases are identical in terms of what's selected: in both cases, hitting control-W will cut the text _ more text (which is not what's visually selected in either case!)
I think maybe there are two underlying bugs here:

prompt-toolkit should follow emacs and interpreter the mark and point as being placed at the space in between characters, to the left of where the cursor is when control-Space is pressed (for mark) and where the cursor is currently (for point)
prompt-toolkit's attempt to highlight the selected region by reversing the text colors collides with gnome-terminal's using this same approach to show the cursor. It would be better if prompt toolkit used some more distinctive mechanism for showing the highlight, like perhaps the light grey background that it uses for completion drop-downs.

I noticed this too. It means that if you select a line with Control-space + Down arrow and then cut it, it deletes the first character if the next line. This is not how selection works in emacs, but I just checked and apparently it is how it works in vim.

This fix is really easy too:
diff --git a/prompt_toolkit/document.py b/prompt_toolkit/document.py
index 25d817d..422a491 100644
--- a/prompt_toolkit/document.py
+++ b/prompt_toolkit/document.py
@@ -857,8 +857,8 @@ class Document(object):
                     new_cursor_position = from_

                 remaining_parts.append(self.text[last_to:from_])
-                cut_parts.append(self.text[from_:to + 1])
-                last_to = to + 1
+                cut_parts.append(self.text[from_:to])
+                last_to = to

             remaining_parts.append(self.text[last_to:])

Actually the selection itself is correct for what it is doing. This can be confirmed visually if you select text before the cursor.
The problem is that selection is treating the cursor as if it were after where it is. But in emacs, the cursor is treated as if it were before where it is (think in terms of a modern GUI where the cursor is in fact between characters).
In fact, if you change the terminal cursor to a vertical bar in iTerm 2 or in Terminal.app (assumedly also in Linux terminals if they support that), the bar is placed before the cursor character. vi's behavior in visual mark mode becomes a bit odd if you do this. v left selects what (appears) to be the character before the cursor.
Anyway, vi is older than I am, so I'm not going to argue it's logic. Apparently some people like it. But,

The default behavior of prompt-toolkit already matches emacs in most places,
The very keyboard shortcut Control-space comes from emacs. But pressing control-space in prompt-toolkit selects a character (the character under the cursor).
In fact, in vi_mode, the v also selects a single character, which is different from vi!  In vi (as in emacs), v creates an empty selection.

So I think there are two issues:

Control-space / v should create an empty selection
In emacs (and the default) mode, starting a selection and moving left or up should not select the character under the cursor. Or, rather, once the above point is fixed, in vi mode, doing so should select the character under the cursor (since just v would create an empty selection). Actually I think there might be some other weirdness with vi as well depending on whether you go left or right, so we should just try to replicate it.

Hi Nathaniel and Aaron,
Thanks a lot for this extensive analysis!
I did not had the time yet to focus on this issue. Right now, the focus is mainly on getting 2.0 released.
But in any case, I consider this a bug, which needs to be fixed.

Since this is somewhat of a backwards incompatible change, should this be considered for 2.0?

I think this should fix it: https://github.com/jonathanslenders/python-prompt-toolkit/pull/619
Would you mind trying that fix?

This fix has been merged: https://github.com/jonathanslenders/python-prompt-toolkit/pull/619
I think it should be fine now. Please let me know if I miss something.
It doesn't do the whole kill-ring thing yet, but that's a different issue.


Implement Event Detail Hero Section

Create and implement the hero section for individual event details pages. The hero section serves as the focal point of each event detail page, providing a visually appealing introduction to the specific event and encouraging attendees' interest.

Hey !!
I would like to work on this issue
can you assign it to me

Hey !!
I would like to work on this issue
can you assign it to me

Sure @lokesh-wagh !

Is there a discord channel or someway to content the maintainer's
I had some query about the design

Is there a discord channel or someway to content the maintainer's
I had some query about the design

Yeah @lokesh-wagh
https://discord.gg/2jEJNfT56a


⚠ Bofrost.lu has degraded performance

In 6165a80, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1277 ms

Resolved: Bofrost.lu performance has improved in 4562787 after 10 minutes.


Build failure adding plugin to cordova 8.0.0 project

Expected Behaviour
BUILD SUCCESS
Actual Behaviour
BUILD FAILED in 1s
(node:12300) UnhandledPromiseRejectionWarning: Error: cmd: Command failed with exit code 1 Error output:
FAILURE: Build failed with an exception.
What went wrong:
A problem occurred configuring project ':app'.
Cannot add task ':app:processDebugGoogleServices' as a task with that name already exists.
Reproduce Scenario (including but not limited to)
Creating hello sample project with cordova 8.0.0 and adding plugin (after enabling Firebase), the build process fails.
Steps to Reproduce

Create classic sample cordova project:  cordova create hello com.example.hello HelloWorld
Add android platform: cordova platform add android
Manually add Firebase downloading google-services.json and putting it in the root directory
Add tag <resource-file src="google-services.json" target="app/google-services.json" /> to platform android tag in confix.xml of the project
add plugin: cordova plugin add phonegap-plugin-push
It installs the pugin but with an older version: 2.1.3 instead of 2.2.3

Unmet project requirements for latest version of phonegap-plugin-push:
cordova-android (7.0.0 in project, >=7.1.0 required)
Fetching highest version of phonegap-plugin-push that this project supports: 2.1.3 (latest is 2.2.3)

try to build: cordova build android
BUILD FAILED

Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 8.0
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Cordova CLI version and cordova platform version
cordova --version                          8.0.0
cordova platform version android           7.0.0

Plugin version
cordova plugin version | grep phonegap-plugin-push   # e.g. 1.5.3

Version 2.1.3
Sample Push Data Payload
Sample Code that illustrates the problem
Logs taken while reproducing problem
Android Studio project detected
ANDROID_HOME=C:\Android\newsdk
JAVA_HOME=C:\PROGRA~1\Java\JDK18~1.0_1
studio
Subproject Path: CordovaLib
Subproject Path: app
publishNonDefault is deprecated and has no effect anymore. All variants are now published.
The Task.leftShift(Closure) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use Task.doLast(Action) instead.
at build_4hyhikkzj0alrgb5k5ie3f8ro.run(C:\Development\Apps\Test\Test2\hello\platforms\android\app\build.gradle:144)
Configuration 'compile' in project ':app' is deprecated. Use 'implementation' instead.
registerResGeneratingTask is deprecated, use registerGeneratedFolders(FileCollection)
Could not find google-services.json while looking in [src/nullnull/debug, src/debug/nullnull, src/nullnull, src/debug, src/nullnullDebug]
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':app'.

Cannot add task ':app:processDebugGoogleServices' as a task with that name already exists.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

Get more help at https://help.gradle.org

BUILD FAILED in 1s
(node:17948) UnhandledPromiseRejectionWarning: Error: cmd: Command failed with exit code 1 Error output:
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':app'.

Cannot add task ':app:processDebugGoogleServices' as a task with that name already exists.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

Get more help at https://help.gradle.org

BUILD FAILED in 1s
at ChildProcess.whenDone (C:\Development\Apps\Test\Test2\hello\platforms\android\cordova\node_modules\cordova-common\src\superspawn.js:169:23)
at emitTwo (events.js:126:13)
at ChildProcess.emit (events.js:214:7)
at maybeClose (internal/child_process.js:925:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
(node:17948) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:17948) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

You have to use cordova-android 7.1.1 instead of 7.0.0


Adjudicator.Subscribe takes channel.Params while only channel.ID is needed

Situation:
Adjudicator.Subscribe API  currently takes channel.Params as an argument. However, looking at the implementation of Subscribe for ethereum, I noticed only the ID field in params is used.
Problem
I noticed this when implementing the watcher for IoT use cases (#172). In the design of Watcher described in proposal#004, the client should register the channel by sending the channel.ID. Watcher would then subscribe for adjudicator events for this channel using this channel ID.
Because, the Subscribe API requires channel.Params, it will be required to pass channel.Params all over, while it needs only channel.ID.
Possible solution
Modify the Adjudicator.Subscribe API to take channel.ID instead of channel.Params

@matthiasgeihs @ggwpez

I made the same observation before. However, is there really a need to change this? I understand that having to pass around additional data seems inconvenient, but not like a major problem.
Changing backend interfaces affects all backend implementations and should only be done if justified clearly.

Can we do without this change....?
Yes, technically, it would be possible the Watcher without applying this change. In that case, the StartWatching function will take channel.Params instead of just channel.State.
But, this means because of Adjudicator.Subscribe function needing more than required arguments, other components using it (StartWatching API in this case) will also take additional arguments.
Justification...
Looking at the implementation of Adjudicator.Subscribe and its usage, it appeared that channel.State was sufficient. Not fixing this now means, effects will creep into StartWatching and later we would have to think more about fixing this as it involves more APIs.
@matthiasgeihs

During a discussion with @ggwpez the idea came up that we might want to take a grooming break at a suitable point in time where we address a bunch of such "cosmetic" issues together. I fear that if we do such interface changes on the fly while we concurrently on other parts of go-perun, we risk losing a lot more time than if we do them together in one go.
That being said, you are making a strong argument, that the change you propose should not be postponed.

Not fixing this now means, effects will creep into StartWatching

In this case, I am fine with changing it now.

Yeah, I agree that in most cases, we should collect such tasks in an issue and take it periodically.
I also noticed @ggwpez has created an issue for the same.


A way to lint a package in node_modules?

Hi,
I have a local node package in my dependencies, and would expect stylelnt-webpack-plugin to lint those files as they are directly imported by my JS files.
Is there a way to do so?
Thanks in advance,

You could try specifying another glob to the files array:
files: [
  'node_modules/package/styles/**/*.css',
  'your/css/files/**/*.css'
]

But I can't guarantee that will work. Give it a shot and let me know. I don't think that this is a totally unreasonable request if you explicitly specify that you want to lint something in the node_modules folder. I would support a PR for this if my suggestion doesn't work, but unfortunately I don't have the cycles to make one right now.

That didn't work, but I found a workaround by adding ../package/**/*.css in files. Indeed, my package is a node dependency served via linklocal.
Thanks for your help!

Interesting. Thanks for pointing this out! I have a feeling that stylelint itself ignores files in the node_modules directory. Going to close this now.


Add links to detection output

We want the output mesage for the detection functionality to include a link to the output generated, similar to what the commands iebaltab and iecorrect do:

Clicking on the link would open the output file

Solved by #28


[SURE-9154] cattle-cluster-agent does not start after apply cisProfile: cis

Issue description:
after apply cisProfile: cis to a deployed or a new rke2 CAPV cluster, cattle-cluster-agent does not start.
Business impact:
Can't apply cisProfile.
Troubleshooting steps:
Event:
Type Reason Age From Message

Warning FailedCreate 10m (x43 over 124m) statefulset-controller create Pod fleet-agent-0 in StatefulSet fleet-agent failed error: pods "fleet-agent-0" is forbidden: violates PodSecurity "restricted:latest": seccompProfile (pod or containers "fleet-agent-register", "fleet-agent", "fleet-agent-clusterstatus" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
Related:
https://github.com/rancher/rancher/issues/47255
If we try to import the CAPV rke2 cluster manually fixing the warnings at manifest:
Warning: spec.template.spec.affinity.nodeAffinity.requiredDuringSchedulingIgnoredDuringExecution.nodeSelectorTerms[0].matchExpressions[0].key: beta.kubernetes.io/os is deprecated since v1.14; use "kubernetes.io/os" instead
Warning: would violate PodSecurity "restricted:latest": allowPrivilegeEscalation != false (container "cluster-register" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "cluster-register" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "cluster-register" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "cluster-register" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
Repro steps:
From the error message in the cattle-cluster-agent pod, the  PodSecurityAdmission profile applied in this cluster is 'restricted'
fleet-agent failed error: pods "fleet-agent-0" is forbidden: violates PodSecurity "restricted:latest"
: seccompProfile (pod or containers "fleet-agent-register", "fleet-agent", "fleet-agent-clusterstatus" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")The PSA profile 'restricted' is from the upstream k8s, which is by default applied in 1.25 as a replacement of Podsecuritypoliciies.
You can read more in the RKE2 PSS section - [1]
I've reproduced your issue by:
Create a custom RKE2 1.30 cluster with cis profile enabled
Import this custom cluster into Rancher
root@rke2-custom-cis-aaller-02:~# curl --insecure -sfL https://xxxx/v3/import/xxx.yaml
kubectl apply -f -clusterrole.rbac.authorization.k8s.io/proxy-clusterrole-kubeapiserver
createdclusterrolebinding.rbac.authorization.k8s.io/proxy-role-binding-kubernetes-master
created
namespace/cattle-system created
serviceaccount/cattle createdclusterrolebinding.rbac.authorization.k8s.io/cattle-admin-binding
created
secret/cattle-credentials-c243511 createdclusterrole.rbac.authorization.k8s.io/cattle-admin
created*Warning: spec.template.spec.affinity.nodeAffinity.requiredDuringSchedulingIgnoredDuringExecution.nodeSelectorTerms[0].matchExpressions[0].key: beta.kubernetes.io/os is deprecated since v1.14; use "kubernetes.io/os" instead Warning: would violate PodSecurity "restricted:latest": allowPrivilegeEscalation != false (container "cluster-register" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "cluster-register" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "cluster-register" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "cluster-register" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost") deployment.apps/cattle-cluster-agent created*
service/cattle-cluster-agent created
root@rke2-custom-cis-aaller-02:~#
There are no pods in the cattle-system ns
root@rke2-custom-cis-aaller-02:~# kubectl get pods -n cattle-system
No resources found in cattle-system namespace.
root@rke2-custom-cis-aaller-02:~#

To work around this:
a) +Create a new Admission config file:+ /etc/rancher/rke2/rke2-pss-custom.yaml.
Create your custom config for the PodSecurity Admision,  adding required namespaces to the exemptions=>namespaces.

You could have this -[2] - as a guide of the namespaces Rancher considered as required. In the following example I've only added cattle-system and cattle-fleet-system as additional ns.
apiVersion: apiserver.config.k8s.io/v1
kind: AdmissionConfiguration
plugins:
name: PodSecurity
configuration:
apiVersion: pod-security.admission.config.k8s.io/v1beta1
kind: PodSecurityConfiguration
defaults:
enforce: "restricted"
enforce-version: "latest"
audit: "restricted"
audit-version: "latest"
warn: "restricted"
warn-version: "latest"
exemptions:
usernames: []
runtimeClasses: []
namespaces: [cattle-system, cattle-fleet-system, kube-system, cis-operator-system, tigera-operator]
b) Restart RKE2:
- rke2-killall.sh
- systemctl start rke2-server
c) Check the status:  Now the cattle-cluster-agent and the rancher-webhook should be Running after a few minutes.
[1] - PodSecurityStandards in RKE2
[2] - Rancher privileged PSA profile
Workaround:
Is a workaround available and implemented? not yet.

more info on topic https://docs.rke2.io/security/pod_security_standards


Update religions.csv

@omri374 since the raw data is updated should I run the data generation note book and create a new pull request? or shall we write a GitHub workflow which will do it and open a pull request each time the data inside raw_data directory changes.


Adding option (command) to rehash entire collection

hi there,
not sure if that has been requested before. I think it would be a good thing, if we could rehash our entire collection and match it against stored hashes (of course for once recognized files only).
That way, we could find damaged files and could take action to redownload them.

It's already been added and is apart of the 3.7 update for JMM Server.
We offer daily builds which you can try, http://jmediamanager.org/latestdownloads/daily/, its the Integrity Check tool.

Haha gotta love it when that happens

oh sry! But nice to hear :D


teuthology/config: Add container_images to site configs.

Every teuthology installation needs to have a different mirror for docker.io and
for the CI images. This means we shoudn't put the configs into any ceph git repos,
but instead in the site configs.
Later, if this is also backported to py2, we can then change the container sources for all branches at once.
Signed-off-by: Sebastian Wagner<EMAIL_ADDRESS>See https://github.com/ceph/ceph/pull/35308 for the ceph side

Since you're moving the containers config to teuthology, I think it is strange to have the code in ceph, maybe it is time to introduce containers module to teuthology?

I think having config data in teuthology for some specific test which is not reachable from teuthology is absolutely a mess, especially in the root namespace. Teuthology should contain code which can be reusable by any caller.
For now it looks like teuthology has nothing todo with containers, because it is not used by anything in teuthology code base. The reason only can appear if you move containers-common config file as a module to teuthology, and use it in your code like:
   from teuthology.orchestra.remote.cluster import set_mirror
   set_mirror(cluster, mirror_url)

That would make sense.
If you want some specific config base on code of specific code, like treat cephadm test as a separate entity from teuthology, maybe think about its own config file, like /etc/cephadm.conf?

If you want some specific config base on code of specific code, like treat cephadm test as a separate entity from teuthology, maybe think about its own config file, like /etc/cephadm.conf?

ok, but then how do I access this from the cephadm task?

I think having config data in teuthology for some specific test which is not reachable from teuthology is absolutely a mess, especially in the root namespace. Teuthology should contain code which can be reusable by any caller.

at the first glance, it might seems to be. but we should not encode lab specific settings in the test.

We should not encode test specific stuff in teuthology.config. I say more, I don't like the idea of having toml in setup.py, which is not a requiremento of teuthology as a framework.

For now it looks like teuthology has nothing todo with containers, because it is not used by anything in teuthology code base. The reason only can appear if you move containers-common config file as a module to teuthology, and use it in your code like:
   from teuthology.orchestra.cluster import set_mirror
   set_container_mirror(cluster, mirror_url)

That would make sense.
If you want some specific config base on code of specific code, like treat cephadm test as a separate entity from teuthology, maybe think about its own config file, like /etc/cephadm.conf?

this is overkill. and in future, we will deploy and test crimson using cephadm as well. so i think teuthology.yaml is a compromise which sucks less.
I don't agree this is a compromise, the compromise is using cephadm.conf

I don't like the idea of making recyclebin from teuthology.yaml, if you really want to go this way, then it should go like this in teuthology:
tasks: # this is not coincedent, it corresponds to module name `tasks` in ceph `qa`
    cephadm:
         #add whatever tasks specific config you want

or follow overrides style:
overrides:
    cephadm:
         #add whatever tasks specific config you want

But this is a new mechanism which should be properly documented in teuthology.

I don't like the idea of having toml in setup.py, which is not a requiremento of teuthology as a framework.

A good way to avoid this would be to make ceph/qa a dedicated python package with it's own dependencies.

I don't like the idea of having toml in setup.py, which is not a requiremento of teuthology as a framework.

A good way to avoid this would be to make ceph/qa a dedicated python package with it's own dependencies.

I like this idea, I was actually, thinking about it, like adding a qa/requirements.txt which will try and use it after bootstrap by the worker, and this is another good feature for teuthology, not trivial though, since to make it correctly handled we need to refactor worker a bit :-) however workarounds also would do the deal.
The current problem is that the only way to figure out what is wrong with requirements.txt is to look at worker.log which is not obvious from pulpito.

and off course the layout of the cephadm config file should be well documented in the cephadm.py task class, and it is not required to change teuthology to know anything about cephadm params, because it should not care about it at all.

@tchaikov turns out, I also need this for https://github.com/ceph/ceph/blob/master/qa/suites/rados/cephadm/workunits/task/test_adoption.yaml which is not using the qa/tasks/cephadm.py

@tchaikov turns out, I also need this for https://github.com/ceph/ceph/blob/master/qa/suites/rados/cephadm/workunits/task/test_adoption.yaml which is not using the qa/tasks/cephadm.py

@sebastian-philipp this is test specific configuration and should be managed on the tasks side.

i still think it's a compromise. this is probably not the best solution, but it's the most  practical one we have now. i'd be happy to review your PR, if you don't like it.

i still think it's a compromise. this is probably not the best solution, but it's the most practical one we have now. i'd be happy to review your PR, if you don't like it.

As I said, there is no need to merge these changes to teuthology in order to get cephadm task working.
Here is an example of patch you may work in cephadm: https://github.com/ceph/ceph/pull/35395

Also you can have any naming you want withing overrides/cephadm section, that would be flexible enough for your needs, just don't add anything not related to the teuthology core code base to teuthology/config.py.


Combobox documentation for website

Summary
Make sure we have website documentation for the Combobox.
Either in the website that's under development, or in the old one, which ever meets the release of 4.0.
We have this PR with the main combobox code merged https://github.com/vmware/clarity/pull/4286 but it only has dev-app docs, not website!

@Jinnie - closing this as done. Thanks to you it now lives in the new website docs.

"Mutli selection combobox" section in two areas needs checking


not able to sign out

Is there a way to sign out?
When i click 'sign out' in the messenger menu, it doesn't do a thing.
I also tried uninstalling and reinstalling the app, but it keeps me logged in.

Not really, no. Forcing sign-out would require us to blow all facebook cookies, which includes Safari and other apps using webviews with the shared cookie storage. In the meantime, you can use Safari to sign out and it should be reflected in the app.

Fixed in 0.1.7


switchToCorrectNetwork fails if the requiredNetwork is moonriver

When metamask is set to mainnet, and I want to switch to moonriver (chainId 1285), I'm getting error code 4902. This is most likely because a different chainId/rpcUrl is being added to handle the error: https://github.com/Developer-DAO/web3-ui/blob/43d7031185f683e9e64329ba020bd721502dc513/packages/hooks/src/hooks/useWallet.ts#L55
NOTE: moonriver network is already added to my metamask browser extension

Thanks for pointing this out. @Nazeeh21 since you implemented this (if I'm correct), why are we switching to/ adding the chain number 61 (which is ETH Classic)?

Thanks for pointing this out. Instead of 0x61, there must be the chainId passed by the user along with the RPC URL of that chain id. 0x61 was for testing purposes.


Add UserClassesASEPs.rep and add LocalServer32 to SoftwareClassesASEPs

Description
This UserClassesASEPs rep file reads the classes keys for UsrClass.dat which are currently missing using other rep files. Furthermore, this commit adds support for LocalServer32 in SoftwareClassesASEPs.rep to also read that key. This rep file can be used for among others to analyse com hijacking.
Checklist:
Please replace every instance of [ ] with [X]

[x] I have generated a unique GUID for my Batch file(s)
[x] I have tested and validated the new Batch file(s) work with my test data and achieve the desired output
[x] I have placed the Batch file(s) within the .\RECmd\BatchExamples directory
[x] I have set or updated the version of my Batch file(s)
[ ] I have made an attempt to document the artifacts within the Batch file(s)

Comment: same artifacts as with software hive now just adding support for usrclass

Thank you for your submission and for contributing to the DFIR community!

@Karneades please review the failed check above, i.e. too many spaces after a colon. Fix and recommit, at your leisure.

One last thing. I noticed you have {} instead of * in KeyPath: Classes\CLSID{}\LocalServer32. Did you confirm that works the same as *? I am asking mostly because I've only ever used * so I didn't know if that was also acceptable syntax to use the brackets.

I c&p from the existing SoftwareClassesASEPs. Not sure what the difference is.

Ah interesting. Alright, well if Lint doesn't hit on it then it should be all the same! I've not dove into the ASEPs yet but that's forthcoming. There's a lot in there, as you can see.

Thanks for merging. KAPE file is also comming shortly.


Component operations should be deferred to the end of the update cycle.

Currently systems are allowed to bind/unbind components immediately but this could have unforeseen effects depending on the order in which entities are updated.
For better concurrency a "component operation buffer" should be implemented. This would hold a queue of component operations that occurred during a system update. Then the buffer can be flushed after the system is done updating.

The TEcs class now has a TComponentOperationBuffer member object. If a call to TEcs.bind() or TEcs.unbind() happens while TSystem.update() is executing then the component operation is deferred.


Reply notification

This PR introduces possibility for posters to get email notifications when people reply to their posts. It is based on work done by @tsileo in 2013(!), and additions I made this year. The original PR was #50.
When posting a message, there is a checkbox labelled "Subscribe to email notification of replies". Checking that checkbox will set the notification flag in the database for that post. Any replies made to the post will cause an email to be sent to the author of the first post.
If you click the checkbox when making a reply, you will get notifications for all further replies to the same parent post, so you are basically subscribing to updates to that conversation thread.
Each email will contain an unsubscribe link for opt-out. Clicking that will unsubscribe you from notifications for that conversation thread.
This PR also contains a fix for #395 which was triggered (or worsened) by this functionality.
This PR is however broken for many setups because of #420, so a fix for that issue is crucial.

The notification column is automatically added the database if needed when starting isso (in the constructor of isso.db.comments).

Any news on this?

I consider it ready for merging. @blatinier ?

I'm soooo sorry, I miss time to test it :(
But I'm presonnally interested in it and hope to be able to do it during my holydays (coming next week)

I merged this pull 443 and I'm getting an db error message:
sqlite3.IntegrityError: NOT NULL constraint failed: comments.notification
I suppose it is necessary to some db upgrade first.  Are there some instructions for that?

@craigphicks The database is supposed to be upgraded automatically when Isso is started, and that works for me. Maybe it depends on version of Python or some library. Could you try this branch where I changed the order of the database commands?

I fetched your branch
git fetch git@github.com:pellenilsson/isso.git reply_notification_dbfix:reno-dbfix
git checkout reno-dbfix

Backed up the old database
cp /var/lib/isso/comments.db /var/lib/isso/comments.pre-update.db

Ran the branch code
python -m pdb ./bin/isso -c /etc/isso.cfg run

Unlike with the reply_notification branch,  with the reply_notification_dbfix there is no error on initial display of messages.
However, when adding a new comment isso returns 500 and the new comment is not displayed. The pre-exisitng  messages, which are presumably read from the successfully updated db, are displayed normally.
Checking the isso log file shows this diagnostic information:
connected to SMTP server
connected to https://example.net/
POST /new
Traceback (most recent call last):
File "/home/user/work/isso-positiv/isso/init.py", line 138, in dispatch
response = handler(request.environ, request, **values)
File "/home/user/work/isso-positiv/isso/views/comments.py", line 92, in dec
return func(self, env, req, *args, **kwargs)
File "/home/user/work/isso-positiv/isso/views/init.py", line 46, in dec
return func(cls, env, req, *args, **kwargs)
File "/home/user/work/isso-positiv/isso/views/comments.py", line 296, in new
rv = self.comments.add(uri, data)
File "/home/user/work/isso-positiv/isso/db/comments.py", line 68, in add
uri)
File "/home/user/work/isso-positiv/isso/db/init.py", line 62, in execute
return con.execute(sql, args)
sqlite3.IntegrityError: NOT NULL constraint failed: comments.notification
< repeated for every new message attempt>
Restarting several times and the behavior is always the same.

After updating the js files correctly, function seems good (*1).  It is a major improvement.  (*1 - so far I've only correctly tested with the reply_notification_dbfix branch, not 443)

The mail response to the original poster occurs before the moderator has approved the post.  This leaves an opening for unverified anonymous  spammers to use an isso installation as a broadcast base.  In the worst case, even if guard is enabled, a spammer with multiple addresses could cause an annoying number of spam mails to be sent to a single mailbox.

The original poster, having themselves been moderated, may be expecting the reply also to be moderated.  There's nothing next to the notify check box to indicate otherwise.  If advertising mail suddenly appears in a posters mailbox, they may claim an infraction of GDPR regulations, but the isso site owner wouldn't even get the joy of collecting advertising royalties.

Supposing the program is changed so that replies are moderated before mail is sent to the poster.  Still, the site administrator policy of enabling or disabling moderation now has different implications than it did before reply-notification.  When disabling, whereas before it would only be the site itself upon which spam could appear, it now also includes the possibility of spam appearing in a posters personal mailbox.

I've updated pull 458, to conform to your system of prioritizing the config file general/public_endpoint setting.
It is worth adding that there already exists a config setting general/name which may have overlapping functionality with config setting general/public_endpoint.
When setting up a second isso, and serving from an nginx location 'isso-2':
location /isso-2 {
    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header X-Script-Name /isso-2;      // <---- critical for subdirectory config
    proxy_set_header Host $host;
    proxy_set_header X-Forwarded-Proto $scheme;
    proxy_pass http://localhost:1234;
}

I found it was necessary to set
[general]
name = isso-2

in order to get the connection to work.  Indeed the isso documentation on Multiple Sites explains that it is necessary to specify the subdirectory in config under general/name.

Regarding your comments 1 and 2, I totally agree that notifications should only be sent after a comments gets through moderation. Apart from the spam issue, it would just be confusing to get a notification about a comment which is not yet visible on the site.
Regarding comment 3, you are basically saying that it's unwise to enable notifications while moderation is disabled. Do you think it should even be forbidden, or would it be enough to advice against it in the docs, and maybe print a warning at startup of Isso?
I noticed two more shortcomings:

Setting notify=smtp now enables both notifications to site administrator and to posters, there is no way to enable/disable them independently.

If you don't set notify=smtp, the checkbox to receive notifications is still displayed but has no effect.

That's a pretty complex and tough topic.  My instinct is to allow all functionality, to make the information readily available, and to make it difficult to accidentally make a mistake.  The related parameters could live in the database and be enabled through the admin GUI in a coordinated way where an explanation would have to be read.  But that a lot more work and I trust your judgment.

I find this issue very important to enable conversations in our websites. Thanks to all of you who are improving isso because that helps us switch away from alternatives that track users :+1:

I now changed the behavior so that notifications are sent after moderation, if applicable. I also added new configuration option reply-notifications on both server and client side, and documentation (which was missing completely) with a warning about enabling notifications without moderation.
I didn't have time to look at the possible overlap between name and public-endpoint. I will now be mostly offline for a few weeks.

It works great here! Thanks for your great work!

Thank all of you who worked on this. It was the only thing I missed in Isso. Just tested — it works! As far as I understand, it is possible to subscribe to replies to your comment but not to all comments in the thread?


Ajax Response is in different language with interface

PHP Version: 8.2.9   | Shopware Version: <IP_ADDRESS>  | Affected area / extension: Extension:B2B-Suite

Expected behaviour:
Ajax response is in the same language as the interface language
Actual behaviour:
Ajax response is in a different language with interface language
How to reproduce:

Your shop is in English
Create a new order number under /en/b2bordernumber
The success notification and the listing content (loaded by Ajax) are showing in German.

The issue is that, after calling Ajax, the controller forwards it to the success page without context (locale), and then the default language is selected.

[public] Shopware automated response: This issue is linked to the internal issue: B2B-1276
[created from B2B-1276, comment 503954]

The issue occurs when two languages are set up in a sales channel as follows: https://mysite.com/ for DE and https://mysite.com/en for EN. In this setup, the main language is always loaded in the context for B2B forwarding.
Reason: \SwagB2bPlatform\Routing\ControllerRoutingExceptionHandler::cloneRequest.
When a sub-request is created here, this sub-request has the base path without '/en (for example, '/b2bordernumber' instead of '/en/b2bordernumber'). As a result, the wrong domain is loaded in \Shopware\Storefront\Framework\Routing\RequestTransformer::findSalesChannel.
As a temporary workaround, decorate ControllerRoutingExceptionHandler:
class ControllerRoutingExceptionHandlerFixer extends ControllerRoutingExceptionHandler
{
    protected function cloneRequest(B2bControllerForwardException $forwardException, Request $request, string $url): Request
    {
        $subRequest = parent::cloneRequest($forwardException, $request, $url);
        $subRequest->server->set('REQUEST_URI', $request->attributes->get('sw-sales-channel-base-url') . $subRequest->server->get('REQUEST_URI'));
        return $subRequest;
    }
}

[public]

FixVersion Change: 4.8.1

This issue will be / was solved in Shopware version 4.8.1.
[created from B2B-1276, comment 525274]


Data source

Consider using http://overpass-turbo.eu/ as an alternative data source if https://wambachers-osm.website is down.

@bkmgit overpass turbo cannot return land-extracted polygons, as in GeoJSONs with boundaries on land, not water. Wambacher's website was the only one doing this, but unfortunately it is down, and he has announced it will not return.
We are hopefully setting up a new pipeline with @ImreSamu to make as an alternative to Wambacher's.

I started making a new custom pipeline in https://github.com/hyperknot/osm-admin-extracts, which hopefully will be a replacement for Wambachers once it's ready.


Add another password verification if a TOTP key should be deleted

Motivation

This is a reminder issue to add a verification check if we want to delete a TOTP key for a user. Right now, the implementation of #1884 allows to directly remove a given TOTP key from their account without additional checks.
Proposed Solution

Add an authentication and verification step for the deletion of a TOTP key.

There is a verification, but we have a 5 minute cookie session.