Header Alignment Issue

I use a style of "margin: auto" to cause my table to be centered in the viewport. However, the frozen header remains left aligned.
Any suggestions on how to fix this, or do it better?

You can also see it live at https://www.socalofficials.org/index.html?api/activeMemberStatus

Hey, friend. I've been involved in other projects and only got to see it today. Did you solve it or are you still having trouble?
I can't open the https://www.socalofficials.org/index.html?api/activeMemberStatus.
Sorry for only replying now...

Thanks for getting back to me. Yes, I'm still having the problem. The link
I sent you seems to work for me, but you can try
https://www.socalofficials.org, then click on the "Verify your meeting
attendance and dues status" link. As you scroll down, you'll see what I
mean.
The table with the header is centered using "margin: auto", but the frozen
header does not seem to inherit this. Not sure what to do about it.
On Wed, Mar 23, 2022 at 9:10 AM Laerte Mercier Junior <
@.***> wrote:

Hey, friend. I've been involved in other projects and only got to see it
today. Did you solve it or are you still having trouble?
I can't open the
https://www.socalofficials.org/index.html?api/activeMemberStatus.
Sorry for only replying now...
—
Reply to this email directly, view it on GitHub
https://github.com/laertejjunior/freezeheader/issues/23#issuecomment-1076520334,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AV54DZ2TQWOQYGWEWEXQJYLVBM66JANCNFSM5OTBQE3A
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi, i published a new version in a development branch with some changes.
https://github.com/laertejjunior/freezeheader/blob/feature/on-center/js/jquery.freezeheader.js
$("#rosterTable").freezeHeader({     onCenter: true });

Thanks! That works great for me.
On Fri, Mar 25, 2022 at 9:31 AM Laerte Mercier Junior <
@.***> wrote:

Hi, i published a new version in a development branch with some changes.
https://github.com/laertejjunior/freezeheader/blob/feature/on-center/js/jquery.freezeheader.js
http://url
$("#rosterTable").freezeHeader({ onCenter: true });
—
Reply to this email directly, view it on GitHub
https://github.com/laertejjunior/freezeheader/issues/23#issuecomment-1079196821,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AV54DZ4NXXA6W57J77PTTP3VBXS57ANCNFSM5OTBQE3A
.
You are receiving this because you authored the thread.Message ID:
@.***>

I saw that you are using Symfony in your project. In the .env file, I think you missed setting the APP_ENV=prod for the toolbar to stop appearing.

Thanks. Yes, I’m not quite ready to put it into production yet. From: Laerte Mercier JuniorSent: Friday, March 25, 2022 3:56 PMTo: laertejjunior/freezeheaderCc: mcclede; AuthorSubject: Re: [laertejjunior/freezeheader] Header Alignment Issue (Issue #23) I saw that you are using Symfony in your project. In the .env file, I think you missed setting the APP_ENV=prod for the toolbar to stop appearing.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


docs: Update documentation for URLs

Using absolute URLs overrides relative URL behavior. This should be explicit in the docs.

Thank you for the addtion.


Ai

Add the gpt_finetune document and corresponding scripts.

Please update commit message, PR title and description.


Outdated copyright year

Hello! In the LICENSE file, it says that "Copyright (c) 2017 Foodsaving Worldwide Dev Team". Should it be updated to 2018?

Indeed, it should be updated to 2018 because we made relevant changes this year: https://softwareengineering.stackexchange.com/questions/210472/is-renewal-of-mit-license-needed-on-github-at-the-beginning-of-each-year
I wonder if there's a bot around that can take care of this automatically...

React found a workaround to this problem:
Copyright (c) 2013-present, Facebook, Inc.
https://github.com/facebook/react/blob/master/LICENSE

Seems a good solution and a quick fix :)

Hello,
I would like to work on this issue.
Would the appropriate timeframe for the license be

Copyright (c) 2017-Present Foodsaving Worldwide Dev Team

now?

Thanks! Actually, it should say "2016-present", as the frontend history goes back to 2016.
On 15 April 2018 15:34:26 CEST, PhrydRhys<EMAIL_ADDRESS>wrote:

Hello,
I would like to work on this issue.
Would the appropriate timeframe for the license be

Copyright (c) 2017-Present Foodsaving Worldwide Dev Team

now?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/yunity/karrot-frontend/issues/997#issuecomment-381407112


For PPM don't turn zeros to nulls

FPARE01802-IA1001-ADNO006-770003-0000000-00000

Maybe just a graphQl endpoint issue.
Probably fine


Allow to extract code containing return statement if it's at the end of a function

TypeScript Version:  nightly (2.6.0-dev.20170904)
Code
export function f() {
    if (1) {
        return 1;
    }

    ...do stuff...
}

export function g() {
    ...do stuff...

    if (1) {
        return 1;
    }
}

Expected behavior:
Able to extract the if statement out of g.
Not able to extract from f because that would change the control flow.
Actual behavior:
Not able to extract in either case. (But somehow it works in #18091?)

I'm not sure I understand.  Are you taking advantage of the fact that the range of the if in g implicitly contains the implicit return at the end of g?  If so, I would say that is more of a suggestion than a bug, insofar as we don't guarantee that every meaningfully extractable range will offer the refactoring.

I think is should be as simple as saying that any selection inside a function that is not followed by anything else should be extractable. No matter where returns appear in it, it is equivalent to say return newFunction(); and move whatever control flow exists inside of newFunction instead.

From our offline suggestion, I understand this to be a suggestion that we create an exception to our "no extracting conditional returns" in the case where the extracted range is at the end of the method (easy: syntactically; harder: via control flow).


fix: 'flet' has no attribute BottomSheetTheme

Description
Fixes #3847

Summary by Sourcery
Fix the attribute error by adding the missing import for BottomSheetTheme in the flet_core package.
Bug Fixes:

Fix the missing import of BottomSheetTheme in the flet_core package, resolving the attribute error.

@FeodorFitsner, do you think we should set a default factory for all the theme-props in the Theme class?
Some props have it and some don't... (bias?)


R27: Home Page: The Software Home Page donut graph shall allow the user to mouse over the bar to display numeric values

Tools: JQuery
metadata: status, classification

c3 donut graph utilized to satisfy this requirement. c3 donut graph allows for hover over to show data

Completed.
SQA


[stable/nextcloud] duplicate location "/" in /tmp/nginx-cfg100189447:586

Version of Helm and Kubernetes:
Helm: 2.13.1
Kubernetes: 1.13.5
Which chart:
stable/nextcloud
What happened:
Deployment of ingress failed
How to reproduce it
Install the chart with the ingress annotations found in values.yaml
Error: exit status 1
2019/04/07 14:39:33 [notice] 19898#19898: ModSecurity-nginx v1.0.0
2019/04/07 14:39:33 [emerg] 19898#19898: duplicate location "/" in /tmp/nginx-cfg100189447:586
nginx: [emerg] duplicate location "/" in /tmp/nginx-cfg100189447:586
nginx: configuration file /tmp/nginx-cfg100189447 test failed

Anything else we need to know:
The is caused by the following rewrite rule found in the configuration snippet of values.yaml
location / {
  rewrite ^ /index.php$request_uri;
}

I got the same problem and removed the "location /" part from the snippet in values.yaml.

I got the same problem and removed the "location /" part from the snippet in values.yaml.

This broke Nextcloud for me because of the missing rewrite.

Hi guys,
I´m already on this and improved the snippet. The block location / {} cannot be defined in server-snippet annotation.
Pls try
    nginx.ingress.kubernetes.io/server-snippet: |-
      server_tokens off;
      proxy_hide_header X-Powered-By;

      rewrite ^/.well-known/webfinger /public.php?service=webfinger last;
      rewrite ^/.well-known/host-meta /public.php?service=host-meta last;
      rewrite ^/.well-known/host-meta.json /public.php?service=host-meta-json;
      location = /.well-known/carddav {
        return 301 https://$host/remote.php/dav;
      }
      location = /.well-known/caldav {
        return 301 https://$host/remote.php/dav;
      }
      location = /robots.txt {
        allow all;
        log_not_found off;
        access_log off;
      }
      location ~ ^/(?:build|tests|config|lib|3rdparty|templates|data)/ {
        deny all;
      }
      location ~ ^/(?:\.|autotest|occ|issue|indie|db_|console) {
        deny all;
      }

In my dev in my dev env I got rid of most of the security warning from nextcloud.

The snippet will be updated in the next few versions. I already have some pull requests open to get this live.

I did a quick test yesterday and it looked pretty promising, except that the new snippet probably broke certbot. The challenge URL returns 403:
Ingress Controller logs:

2019/05/17 05:04:02 [error] 313#313: *1455389 access forbidden by rule, client: <IP_ADDRESS>, server: XXX.XXX.XXX, request: "GET /.well-known/acme-challenge/loaCojgaBNjmPPGdL3RB2Hv5Bh_yVBRwR9S2XXGgzGY HTTP/1.1", host: "XXX.XXX.XXX"

Certbot logs:

I0517 05:04:08.007504 1 controller.go:171] certificates controller: syncing item 'cloud/nextcloud-tls'
I0517 05:04:08.007949 1 sync.go:274] Preparing certificate cloud/nextcloud-tls with issuer
I0517 05:04:08.008454 1 logger.go:43] Calling GetOrder
I0517 05:04:08.323505 1 logger.go:73] Calling GetAuthorization
I0517 05:04:08.494533 1 logger.go:93] Calling HTTP01ChallengeResponse
I0517 05:04:08.494876 1 prepare.go:279] Cleaning up old/expired challenges for Certificate cloud/nextcloud-tls
I0517 05:04:08.495063 1 logger.go:68] Calling GetChallenge
I0517 05:04:08.708374 1 http.go:134] wrong status code '403'
I0517 05:04:08.708673 1 ingress.go:49] Looking up Ingresses for selector certmanager.k8s.io/acme-http-domain=2410547817,certmanager.k8s.io/acme-http-token=1155272310
I0517 05:04:08.708825 1 helpers.go:201] Found status change for Certificate "nextcloud-tls" condition "Ready": "False" -> "False"; setting lastTransitionTime to 2019-05-17 05:04:08.708818463 +0000 UTC m=+215023.355417671
I0517 05:04:08.708960 1 sync.go:276] Error preparing issuer for certificate cloud/nextcloud-tls: http-01 self check failed for domain "nextcloud.hoellskitchen.de"
E0517 05:04:08.709070 1 sync.go:197] [cloud/nextcloud-tls] Error getting certificate 'nextcloud-tls': secret "nextcloud-tls" not found
E0517 05:04:08.713777 1 controller.go:180] certificates controller: Re-queuing item "cloud/nextcloud-tls" due to error processing: http-01 self check failed for domain "XXX.XXX.XXX"
I0517 05:04:08.713937 1 controller.go:168] ingress-shim controller: syncing item 'cloud/ncloud-nextcloud'
I0517 05:04:08.714041 1 sync.go:140] Certificate "nextcloud-tls" for ingress "ncloud-nextcloud" already exists
I0517 05:04:08.714112 1 sync.go:143] Certificate "nextcloud-tls" for ingress "ncloud-nextcloud" is up to date
I0517 05:04:08.714164 1 controller.go:182] ingress-shim controller: Finished processing work item "cloud/ncloud-nextcloud"

Ok I took the config from nextcloud doc and I think the following is the problem:
  location ~ ^/(?:\.|autotest|occ|issue|indie|db_|console) {
    deny all;
  }

The following should do the trick:
location ~ ^/(?:autotest|occ|issue|indie|db_|console) {
  deny all;
}

Ok I took the config from nextcloud doc and I think the following is the problem:
  location ~ ^/(?:\.|autotest|occ|issue|indie|db_|console) {
    deny all;
  }

The following should do the trick because it removes the matcher for "path begins with ."
location ~ ^/(?:autotest|occ|issue|indie|db_|console) {
  deny all;
}

Works like a charm, thank you!

No worries, would you please close the issue?


MMC is broken on master

Latest code raises the following error. Same code on 12.1 works properly.
Original stack trace for 'main_level/agent/main/online/network_0/behavior/behavior':
  File "C:\Anaconda3\lib\site-packages\rl_coach\graph_managers\graph_manager.py", line 148, in create_graph
    self.level_managers, self.environments = self._create_graph(task_parameters)
  File "C:\Anaconda3\lib\site-packages\rl_coach\graph_managers\basic_rl_graph_manager.py", line 72, in _create_graph
    level_manager = LevelManager(agents=agent, environment=env, name="main_level")
  File "C:\Anaconda3\lib\site-packages\rl_coach\level_manager.py", line 91, in __init__
    self.build(spaces_definition)
  File "C:\Anaconda3\lib\site-packages\rl_coach\level_manager.py", line 165, in build
    [agent.set_environment_parameters(spaces) for agent in self.agents.values()]
  File "C:\Anaconda3\lib\site-packages\rl_coach\level_manager.py", line 165, in <listcomp>
    [agent.set_environment_parameters(spaces) for agent in self.agents.values()]
  File "C:\Anaconda3\lib\site-packages\rl_coach\agents\agent.py", line 335, in set_environment_parameters
    self.init_environment_dependent_modules()
  File "C:\Anaconda3\lib\site-packages\rl_coach\agents\value_optimization_agent.py", line 46, in init_environment_dependent_modules
    super().init_environment_dependent_modules()
  File "C:\Anaconda3\lib\site-packages\rl_coach\agents\agent.py", line 380, in init_environment_dependent_modules
    self.networks = self.create_networks()
  File "C:\Anaconda3\lib\site-packages\rl_coach\agents\agent.py", line 353, in create_networks
    worker_device=self.worker_device)
  File "C:\Anaconda3\lib\site-packages\rl_coach\architectures\network_wrapper.py", line 86, in __init__
    network_is_trainable=True)
  File "C:\Anaconda3\lib\site-packages\rl_coach\architectures\tensorflow_components\general_network.py", line 74, in construct
    return construct_on_device()
  File "C:\Anaconda3\lib\site-packages\rl_coach\architectures\tensorflow_components\general_network.py", line 59, in construct_on_device
    return GeneralTensorFlowNetwork(*args, **kwargs)
  File "C:\Anaconda3\lib\site-packages\rl_coach\architectures\tensorflow_components\general_network.py", line 126, in __init__
    network_is_local, network_is_trainable)
  File "C:\Anaconda3\lib\site-packages\rl_coach\architectures\tensorflow_components\architecture.py", line 105, in __init__
    self.weights = self.get_model()
  File "C:\Anaconda3\lib\site-packages\rl_coach\architectures\tensorflow_components\general_network.py", line 262, in get_model
    input_placeholder, embedding = input_embedder()
  File "C:\Anaconda3\lib\site-packages\rl_coach\architectures\tensorflow_components\embedders\embedder.py", line 86, in __call__
    self.input = tf.placeholder("float", shape=[None] + self.input_size, name=self.get_name())
  File "C:\Anaconda3\lib\site-packages\tensorflow\python\ops\array_ops.py", line 2143, in placeholder
    return gen_array_ops.placeholder(dtype=dtype, shape=shape, name=name)
  File "C:\Anaconda3\lib\site-packages\tensorflow\python\ops\gen_array_ops.py", line 7400, in placeholder
    "Placeholder", dtype=dtype, shape=shape, name=name)
  File "C:\Anaconda3\lib\site-packages\tensorflow\python\framework\op_def_library.py", line 788, in _apply_op_helper
    op_def=op_def)
  File "C:\Anaconda3\lib\site-packages\tensorflow\python\util\deprecation.py", line 507, in new_func
    return func(*args, **kwargs)
  File "C:\Anaconda3\lib\site-packages\tensorflow\python\framework\ops.py", line 3616, in create_op
    op_def=op_def)
  File "C:\Anaconda3\lib\site-packages\tensorflow\python\framework\ops.py", line 2005, in __init__
    self._traceback = tf_stack.extract_stack()

The Doom_Health_MMC preset is running fine on my setup with the latest code on master, so need some more details:

Command line (or code) you're using to launch the training process
Are you getting the failure immediately when starting to train?
Which Tensorflow version are you using?

I am launching using my own code cause I have a very complex data generation setup
On Heatup
Tensorflow 1.14

It also affects Rainbow and a few others it seems.

Code is pretty straightforward.
Sample:
agent_params = MixedMonteCarloAgentParameters()

agent_params.network_wrappers['main'].replace_mse_with_huber_loss = with_default(training_profile.replace_mse_with_huber_loss, True)

# agent_params.exploration.evaluation_epsilon = with_default(mmc_config.evaluation_epsilon, 0.0)
agent_params.memory.max_size = (MemoryGranularity.Episodes, with_default(training_profile.max_episodes, 200))

for key, embedder in agent_params.network_wrappers['main'].input_embedders_parameters.items():
	embedder.activation_function = 'leaky_relu'
	embedder.batchnorm = with_default(model_profile.batch_normalization, True)

graph_manager = BasicRLGraphManager(
        agent_params=agent_params,
        env_params=env_params,
        vis_params=VisualizationParameters(print_networks_summary=True, tensorboard=False),
        schedule_params=SimpleSchedule(),
    )

# Ensure initialization
params = TaskParameters(experiment_path=agents_dir,
                        checkpoint_save_dir=os.path.join(agents_dir, 'checkpoint'))

graph_manager.create_graph(params)
graph_manager.task_parameters.experiment_path = agents_dir
graph_manager.task_parameters.checkpoint_restore_path = os.path.join(agents_dir, 'checkpoint')

graph_manager.improve_steps.num_steps = num_steps
graph_manager.steps_between_evaluation_periods.num_steps = 500
iterations = int(with_default(training_profile.timesteps, 1000000) / num_steps)

episodes_to_heatup = with_default(training_profile.exploration_heatup, 100)
graph_manager.heatup(EnvironmentSteps(episodes_to_heatup * env.max_steps))

for i in range(0, iterations):
	printout(f'Executing {i+1}/{iterations} iterations')
	graph_manager.improve()
	graph_manager.save_checkpoint()

I suggest you try running the Doom_Health_MMC preset to see if this might be a system configuration problem. This preset is running fine for me with the latest master code and with Tensorflow 1.14.
If it is working fine, then the only change that might be related to this failure is the recent batchnorm fix, so I would check whether your code works before and after this change.

Easy enough. I can confirm that d6795bd5245ba18604ce1b1ffa9fbee9c8ce7778 doesn't work and the commit before does.

Hi @redknightlois,  d6795bd fixed an issue with batchnorm for DDPG. Unfortunately, even with DDPG, we did not see any significant improvements with batchnorm being used.
At the moment, batchnorm is not supported generically enough to be applied for any other algorithm, other than DDPG. We might want to fix that at some later point, but have no short term plans to support batchnorm for other algorithms.

@gal-leibovich Good to know that there is a way to avoid the issue, wanted to try TD3 but master was misbehaving. One thing that striked me as odd when reading the code was that coach applies BatchNorm, the linear + activation and then dropout.
Recent research has been showing that with batch normalization order matters. I don't have the reference fresh though, but there are a few papers about it in the wild. The guys at FastAI which had tried almost everything has been using BatchNorm, Dropout, Linear + Activation instead.
Have you tried https://github.com/fastai/fastai/blob/master/fastai/layers.py#L44 ... I had been having excellent results on that setup on supervised environments.

@gal-leibovich This paper may shed some light into why BatchNorm is not showing improvements and also suggest a different normalization technique that may be of interest. https://arxiv.org/pdf/1902.05605.pdf


Switch executor sleep to subprocess.wait

When using time.sleep we are forced to wait for the full sleep_time, but
if we use subprocess.Popen.wait we will wait up to sleep_time.
(https://docs.python.org/3/library/subprocess.html#subprocess.Popen.wait)
With PROCESS_POLL_INTERVAL defaulting to 2 seconds, switching to this
logic can save up to 2 seconds for very fast executors, which adds up
with many stages and services on a single box.
Update test cases to use full paths for shell commands as we aren't
using shell=True

This PR is approved.


Document potential crashes when using SDK methods from background threads

SDK version: 6.4.2
Context
The SDK enforces main thread usage for initialization (setup and start), but other methods like add(event:) and logging don't have the same enforcement despite being unsafe for background thread usage.
Issue
While the documentation notes that using the SDK from background threads may lead to data inconsistency, testing shows it can actually cause crashes due to concurrent dictionary access:
func test_backgroundThreadUsageCrashes() {
    var sharedSpan = SpanData(
        traceId: .random(),
        spanId: .random(),
        name: "test",
        kind: .internal,
        startTime: Date(),
        attributes: ["emb.type": .string("sys.breadcrumb")],
        endTime: Date()
    )

    DispatchQueue.concurrentPerform(iterations: 100) { _ in
        _ = sharedSpan.attributes

        var attrs = sharedSpan.attributes
        attrs["test"] = .string("value")
    }
}

This crashes with:
Thread X: EXC_BAD_ACCESS

And a more complex test:
func test_aggressiveConcurrentAccess_shouldCrash() {
    var sharedSpan = SpanData(
        traceId: .random(),
        spanId: .random(),
        name: "test-span",
        kind: .internal,
        startTime: Date(),
        attributes: ["emb.type": .string("sys.breadcrumb")],
        endTime: Date()
    )

    let queues = (0..<5).map { i in
        DispatchQueue(label: "test.queue.\(i)", attributes: .concurrent)
    }
    let group = DispatchGroup()

    for i in 0..<100 {
        group.enter()
        queues[i % queues.count].async {
            _ = sharedSpan.embType
            group.leave()
        }

        group.enter()
        queues[(i + 1) % queues.count].async {
            sharedSpan = sharedSpan.settingAttributes([
                "emb.type": .string("perf.test_\(i)")
            ])
            group.leave()
        }

        group.enter()
        queues[(i + 2) % queues.count].async {
            let breadcrumb = Breadcrumb(
                message: "Message \(i)",
                attributes: [:]
            )
            sharedSpan = sharedSpan.settingAttributes(breadcrumb.attributes)
            group.leave()
        }

        group.enter()
        queues[(i + 3) % queues.count].async {
            let validator = LengthOfNameValidator()
            _ = validator.validate(data: &sharedSpan)
            group.leave()
        }
    }

    group.wait()
}

The above test can crash in multiple places, which furthers illustrates the problem.
Suggestion
Consider either:

Adding thread assertions to all public methods (like already done for setup and start).
Or updating documentation to warn about potential crashes, not just data inconsistency.

The SDK already has the infrastructure for thread checking (e.g., EmbraceSetupError.invalidThread), it could be extended to other public methods.
Mitigation
For other users that might find this issue. I am now enforcing access to the Embrace SDK on the main thread:
/// `client` is a property of type `Embrace?`
private func onMainThread(_ block: @escaping (Embrace) -> Void) {
    DispatchQueue.main.async {[client] in
        guard let client = client else {
            return
        }

        block(client)
    }
 }

func logBreadcrumb(_ message: String, properties: [String: String]?) {
    onMainThread { client in
       client.add(event: .breadcrumb(message, properties: properties ?? [:]))
    }
}

Hey @RuiAAPeres thanks for submitting this issue; seems like the problem under the hood is that SpanData (from OpenTelemetrySdk  provides access to different properties and most of them are not thread safe as far as I can see.
Probably, aside of documenting this, we'll probably have to create an anti-corruption layer to prevent this from happening, at least, from the public API.

but if somebody interacts with OpenTelemetry structures directly (like you do in both tests) crashes like this will still happen as those structures are not Thread Safe

In our app, all interactions with OpenTelemetry are indirectly via the Embrace SDK. The tests above serve as minimum replicable case and just use to narrow down the issue.
I would recommend sending an email to your existing customers warning about this situation. It's a pretty serious problem: the SDK used to  report crashes is crashing.

Thank you for taking the time to create the tests; they are really useful for replicating the issue. Obviously, we will be notifying through various channels and updating the documentation/changelog accordingly.
That being said, we're somewhat limited in how much we can prevent some of these cases when users directly use OpenTelemetry structures. While we can (and we will) improve our APIs to enforce access from a single thread, if any consumer imports OpenTelemetrySdk and performs operations like the ones you've shown in the test, it's likely to crash. I understand that this isn't a normal/expected behavior, which is why I've created an issue in the OTel repository.
Next steps: in the next release, we will be preventing some of these issues, and hopefully, if improvements are also made in OpenTelemetry, we might be able to prevent any type of crash related to concurrency.

Nice! Thank you.


Fixed wrong generator.

When using php artisan make:entity Cat --fillable="title:string,content:text" --rules="title=>required|min:2, content=>sometimes|min:10"
files were generated wrong.

Accept the pull request made at origin repository l5-repository


jib:build is not reproducible  in container

Description of the issue:
When I build the code in container,  it  will rebuild all the layer every time.
Expected behavior:
I don’t have to wait for Docker to rebuild your entire Java application - just deploy the layers that changed.
Steps to reproduce:

clone https://github.com/GoogleContainerTools/jib.git , cd  to examples/spring-boot
build with:

docker run -v `pwd`:/tmp/build -w /tmp/build -v $HOME/.m2:/root/.m2 maven:3-jdk-8 mvn clean compile jib:build -Djib.from.image=openjdk:8-alpine -Dimage=<myimage>

docker pull the new image.  I have to pull all the 3 layers, include the 14.38MB dependency layer every time .

Environment:
macos 10.14.3, docker Version <IP_ADDRESS>

Can you run docker history on the image to see if the digests are actually different?

Seems like a critical bug. Timestamps of directories are not set to the epoch+1 sec.
examples/spring-boot$ tar tvf target/jib-cache/layers/01*/f8*
drwxr-xr-x 0/0               0 2019-04-19 13:28 app/
drwxr-xr-x 0/0               0 2019-04-19 13:28 app/classes/
drwxr-xr-x 0/0               0 1969-12-31 19:00 app/classes/hello/
-rw-r--r-- 0/0             699 1969-12-31 19:00 app/classes/hello/Application.class
-rw-r--r-- 0/0             594 1969-12-31 19:00 app/classes/hello/HelloController.class

We need to track down since when this started to happen.

It doesn't have to run inside the container to reproduce.

I think #1571 added this regression: https://github.com/GoogleContainerTools/jib/pull/1571/files#diff-9f3ce3d4c2254dbe95c91624e7b434d9R110

Moving the time code in the link above doesn't account for parent directories added with uniqueTarArchiveEntries.add(entry);

Gosh. That explains it. That is in 1.1.0.

okay, fix is coming, behavior:

By default timestamp will be epoch+1.second
Order matters in layerEntries: to correctly configure a directory it must come before any file that exists in it, otherwise it will get default properties.

@eisig thanks again for reporting this. We just released 1.1.2 with the fix.

Great 👍


Put user defined userAgentString to the beginning of userAgentString

And also a bit of refactoring of ChannelOptions logic.
Fixes #4072.

OK, everything C# is green.


murex: 3.1.3100 -> 4.1.1100

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/lmorg/murex/releases.
meta.description for murex is: Bash-like shell and scripting environment with advanced features designed for safety and productivity
meta.homepage for murex is: https://murex.rocks
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.1.1100 in filename of file in /nix/store/xqyrwpcizjligmq1839lwdn02wi495lv-murex-4.1.1100

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
murex

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/xqyrwpcizjligmq1839lwdn02wi495lv-murex-4.1.1100 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A murex https://github.com/r-ryantm/nixpkgs/archive/b54b8411ccf24f485bafa23f4d525b670ba0c468.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/xqyrwpcizjligmq1839lwdn02wi495lv-murex-4.1.1100
ls -la /nix/store/xqyrwpcizjligmq1839lwdn02wi495lv-murex-4.1.1100/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

murex

Maintainer pings
cc @dit7ya for testing.

Supplanted by  #231831.


Please return to using the same folder and syntax as normal loras

I have hundreds of safetensors files, we all got used to them working exactly the same as each other, as they should. Now I have to check one by one to see which ones are lycoris and move them to their own folder?

Actually you can move all file in to LyCORIS if you want.
LyCORIS extension always support lora
And what's ridiculous is the suggestion you give.
If you have checked how locon ext make what you said possible, you will give up to maintain it.
Or you can just read all the issues in locon ext, and see how many of that is not related to my ext.
If you guys just want old way, just fork it and maintain by yourself. It's in Apache-2 licence.
If you want to say you don't do anything about programming or coding.
Please don't say this decision is "ridiculous"
I don't care about just make all the repo be private.

Are you trying to say it is hard for a computer to differentiate between lora and lycoris, thus making the old extension unmaintainable?
If so, how can you expect your human users to do the same?

I now understand you can place all files in the lycoris folder. If so, that's good, and I apologize for being sassy.


specialize collections holding bytes to turn into PyBytes rather than PyList

Followup to #4060
XRef #4182
This implements specialization for collections holding bytes (in the new IntoPyObject trait) by a provided, sealed iter_into_pyobject method. The method is intended to be overwritten by the element type (for now u8 only) and turns an iterator of elements into an appropriate Python type in type erased form. The default implementation creates a PyList while the u8 override returns PyBytes.
This method is then used by the generic IntoPyObject::into_pyobject implementation of collection types. I updated the implementations of Vec<T>, &[T], [T; N] and SmallVec<A> accordingly. (I hope did not forget something)
From a quick test everything seems to work out. If this seems sensible to work with, I will add a few tests and the newsfragment.
Big thanks to @diliop for the previous work in #4182!

You're right, this has an immediate effect, because of the macro specialization. I totally forgot that 😅 , I will add a migration entry 👍

I mean I guess we can probably add another layer to the autoderef specialization to prefer IntoPy only for these types, and emit a deprecation warning unless they wrap in a PyBytes::new or similar 😂

I kind of hope that it won't be necessary 🙃 , since it's also fairly easy to work around, if that conversion is not desired.

Superseded by #4442


#bugfix fix the release state of box trigger issue

m_state is the current state of the Box, state is the incoming one. So from what i'm seeing m_state has to be StatePressed to be released. I couldn't see any bug here. Can you give more details? What are you experiencing?

sry, it's a simple mistake.


auto reconnection after using creditiales on other device

What issue do you have? Please be as thorough and explicit as possible.
homebridge-ewlink is not properly reconnecting to ewlink cloud after using account on other devices/instances. Steps:
1/ hb-ewlink connected properly
2/ loging to ewlink account on mobile phone
3/ hb-ewlink gives WS 406 Error and trying to reconnect
4/ Login out of the app
5/ hb-ewlink still gives WS 406
6/ restarting hb solves the issue
Imho it should reconnect without restarting whole HB, and it should be done automaticly
WS 406 Error
12.08.2022, 10:35:47] [eWeLink] WS login failed [406] see http://bit.ly/hb-ewelink-errors
[12.08.2022, 10:35:47] [eWeLink] WS unknown command received.
{
  "error": 406,
  "apikey": "xxxxxxxxxxxxxxxxxxxxxxxx",
  "sequence": "1660293347288",
  "actionName": "userOnline",
  "params": {}
}
[12.08.2022, 10:35:47] [eWeLink] WS error event and will try to reconnect in 5 seconds [1000].

```### Details of your setup.
standard homebridge stable -

Hi @JacekKac
You need to use a separate ewelink account now.
Create a second ewelink account, share your devices to this account, but use your main ewelink account for the plugin and keep logged into the ewelink app with the second account

@bwp91 thank you, seems like good idea, but still is it not a bug that hb-ewlink is to able relogin sucesfully and restart is necesarry ?

@JacekKac
It's not a HB-EWeLINK bug.
The EWeLINK platform no longer allows multi device logins as part of their policy. It however does allow sharing an account with other users.
Therefore, the best solution available is to make User-EWeLINK accounts for each of the users and a HB-EWeLINK account that you share to your users needing device access through the platform.
There is no way around it. If you log into the HB-EWeLINK account from a phone or other device then you must restart Homebridge for the plugin to reconnect to that account again. EWeLINK will then disconnect you phone App if logged in to the HB-EWeLINK account.

@JacekKac
There is also no way for the plugin to first check if other users are logged out before attempting to log back in. So any auto reconnect would consistently knock your Phone App off if you were really trying to log into that account from it.

Seems like a dead end to me, I think good solution will be to add a option "force login" instead of manuall restart, maybe with some time setting.

add a option "force login"

I like that too.

Hi,
Closing this just as been a little overwhelmed with issues recently.
If this is still an issue or a feature you would like implemented then please do re-open this ticket!
Thanks for your understanding!


Segwit support

Segwit addresses fail. https://en.bitcoin.it/wiki/Bech32
ie If I run valid('bc1qar0srrr7xfkvy5l643lydnw9re59gtzzwf5mdq', 'bitcoin'); I get an invalid address when in fact it is a valid address.

@deefactorial @ognus Hi guys! Any updates?

@ulich-trade not much going on with this one atm, I might have a look at it some time later, but don't have specific plans...


TypeError: 'NoneType' object is not subscriptable

Worked fine for days but not even starting with this output
14:23:42: Fatal error encountered:
14:23:42:
14:23:42: Traceback (most recent call last):
14:23:42:   File "main.py", line 160, in main
14:23:42:   File "twitch.py", line 772, in run
14:23:42:   File "twitch.py", line 923, in _run
14:23:42:   File "twitch.py", line 1749, in get_live_streams
14:23:42:   File "twitch.py", line 1750, in
14:23:42:   File "channel.py", line 116, in from_directory
14:23:42: TypeError: 'NoneType' object is not subscriptable

#118


If an AttributeError is raised in ColoredString.color_str, python will raise a TypeError when printing

Hi,
The color_str property is checking if the stdout is a tty by running sys.stdout.isatty().
In our case, a 3rd party populated the sys.stdout with an object that did not implement isatty. Because of this, an AttributeError was thrown when running the code in color_str. Python implicitly caught this and defaulted to getting the value from __getattr__, which is, as you know, a function and indeed not a compatible type for printing.
An implicit fix would be
@property
def color_str(self):
    try:
        return self._color_str()
    except Exception:
        return self.s

def _color_str(self):
    # current existing code

An explicit fix would be
@property
def color_str(self):
    try:
        return self._color_str()
    except AttributeError as e:
        raise MyCustomError("An error was thrown when assembling the colored string: {}".format(e))

def _color_str(self):
    # current existing code

But I will leave it to your judgement to find the best approach.
Thanks for your time.

I think we could also just modify the check elif sys.stdout.isatty() and not DISABLE_COLOR: to be elif hasattr(sys.stdout, 'isatty') and sys.stdout.isatty() and not DISABLE_COLOR:
In any case, this should definitely be an implicit check, not an explicit check, as I would not classify colored output in abnormal environments mission critical.

Even better :) thanks for the quick reply.

This is fixed in the new 0.4.0 release

Thank you for taking care of this so quickly. Very much appreciated!


I plan to use YOLOv8 to do Facial Expression Detection with 5 classes ['anger', 'fear', 'happy', 'neutral', 'sad'] for GSSoC'24

Is your feature request related to a problem? Please describe.
Yes it is related to the Face Emotion Recognition
Describe the solution you'd like
I will use YOLOv8 on a dataset of 1000+ images, I have the dataset already, I just need to annotate it.
And then use YOLOv8. I can also make it run in Realtime with a Web Camera.
Describe alternatives you've considered
ANN and CNN can also be used but they are much slower compared to YOLO
Additional context
I have already worked on Face detection with YOLO under the FACE-X repo and I did a level 2 problem(issue 1767).
Thank You
GSSoC'24

@akshitagupta15june I would like to work on it if possible

@akshitagupta15june mam !
I would like to solve this issue I'm GSSOC24 contributer. Can u please give me a chance to solve this issue mam

@akshitagupta15june can u assign me this issue under GSSOC24

@akshitagupta15june mam !
I would like to solve this issue I'm GSSOC24 contributer. Can u please give me a chance to solve this issue


TopBar and Navigation components

There is any prediction about TopBar and Navigation components?

Hey @murilolopes
Thank you for requesting for components, for estimation we may release these components by end of July 2021.

Great, I would like to help in some way if I can, please don't hesitate to contact me.


Option to generate separate -dbg package with debug symbols when --separate-debug-symbols is used

With --separate-debug-symbols the debug symbols are separated from the binaries, however they are all combined in the same .deb package. Would it be possible to add an option so that the debug symbols would be placed in a separate packagename-dbg-$VERSION.deb package?

I think that would be a useful feature. It may need a bit of refactoring of cargo-deb, because it currently assumes it's writing only one deb file, and that deb file has all the usual metadata.
Would you like to lead a project to add this feature?


Add eth to tokens folder

ewa is trying to show this icon locally:
https://raw.githubusercontent.com/trakx/branding/dev/svg/tokens/eth.svg

OK! I am not sure we should keep on duplicating the icons from the /constituents folder into the /tokens folder 🤔 (agree it is already the case with USDc)
It is not a big deal, but we are going to have 5 more soon https://trakx.atlassian.net/browse/TKX-1574
Instead do you think it is complicated to add that logic in ewa?

Instead do you think it is complicated to add that logic in ewa?

We get the correct URL from https://dev-api.trakx.io/peatio/public/currencies
{
        "name": "Ethereum",
        "symbol": "eth",
        "decimals": 18,
        "quantity": 0.02044772921083773,
        "iconUrl": "https://raw.githubusercontent.com/trakx/branding/dev/svg/constituents/eth.svg",
        "coinGeckoId": "ethereum",
        "cryptoCompareId": "eth"
      }

I will try to fix the logic. Closing this PR.

@monsieurleberre  We are getting https://raw.githubusercontent.com/trakx/branding/dev/svg/tokens/eth.svg from https://dev-api.trakx.io/peatio/public/currencies
How can we fix this?
{
    "id": "eth",
    "name": "Ethereum",
    "description": null,
    "homepage": null,
    "price": "1.0",
    "explorer_transaction": "https://goerli.etherscan.io/tx/#{txid}",
    "explorer_address": "https://goerli.etherscan.io/address/#{address}",
    "type": "coin",
    "deposit_enabled": true,
    "withdrawal_enabled": false,
    "deposit_fee": "0.0",
    "min_deposit_amount": "0.00005",
    "withdraw_fee": "0.00005",
    "min_withdraw_amount": "0.00005",
    "withdraw_limit_24h": "0.0",
    "withdraw_limit_72h": "0.0",
    "base_factor":<PHONE_NUMBER>000000000,
    "precision": 8,
    "position": 19,
    "icon_url": "https://raw.githubusercontent.com/trakx/branding/dev/svg/tokens/eth.svg",
    "min_confirmations": 1
}

Hello, sorry for the delay: you can simply change that with tower or the admin API of peatio.
https://dev-tower.trakx.io/exchange/currencies/eth/edit


Is this free to use or commercial?

See the README and LICENSE files.

ok thanks but don't think so its very clear but thanks anyway.

Sorry if it's not clear. As per the LICENSE file,
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction,
For Jinx and com4j, see their respective license terms. Neither are included in this repo, but you will need both if you want to use this repo for anything. Jinx is commercial software (see https://exceljava.com, as per the readme), com4j is licensed under it's own license which you will have to read (free to use with some limitations).


[HOLD for payment 2023-04-07] [$1000] Chat - After tap on Go back to Home Page option, it's bring to conversation instead of LHN

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/15776
Action Performed:

Launch the NewDot app
Login with any account
Type something in URL to land on not existing page
Check that Link to go back exists
Click on URL should move back to main screen

Expected Result:
Clicking on URL should move back to main screen
Actual Result:
After tap on Go back to Home Page option, it's bring to conversation instead of LHN
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/224497275-b0d6c1de-2ddc-4f6e-b798-51dce9d27a5f.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0132ef531ea383db28
Upwork Job ID:<PHONE_NUMBER>093044736
Last Price Increase: 2023-03-21

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@flaviadefaria Whoops! This issue is 2 days overdue. Let's get this updated quick!

@flaviadefaria Huh... This is 4 days overdue. Who can take care of this?

@flaviadefaria 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Job added to Upwork: https://www.upwork.com/jobs/~0132ef531ea383db28

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

Triggered auto assignment to @madmax330 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The Not Found screen incorrectly redirects to the Report page instead of the home page.
What is the root cause of that problem?
The root cause of this is an incorrect route (Report page) mentioned here.
What changes do you think we should make in order to solve the problem?

We can simply change the route here to ROUTES.HOME.
What alternative solutions did you explore? (Optional)
N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
Got back to home page not navigating to home screen from notFound modal
What is the root cause of that problem?
Seems an incorrect route is given to the Go back to Home page link.
What changes do you think we should make in order to solve the problem?
Need to dismiss the modal(notFound) and  correct the route with ROUTES.HOME here.
https://github.com/Expensify/App/blob/ec2990bd36e5bd71fe6df9747b6dc8888f6dec92/src/components/BlockingViews/BlockingView.js#L54

Added the external label! @sobitneupane and @madmax330 should start reviewing proposals soon.

Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
Feel free to drop a note in #expensify-open-source with any questions.

Thanks for the proposal everyone.
Proposal from @allroundexperts looks good to me. @allroundexperts I think we can use Navigation.dismissModal(true) instead.
🎀👀🎀 C+ reviewed
cc: @madmax330

@sobitneupane just to confirm are you referring the dismissing the modal and then navigate to the Home page? If that is the case then I think I am the first one to propose it.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.92-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/16453

If no regressions arise, payment will be issued on 2023-04-07. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@sobitneupane / @madmax330] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@sobitneupane / @madmax330] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@sobitneupane / @madmax330] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@flaviadefaria] Determine if we should create a regression test for this bug.
[ ] [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@madmax330, @sobitneupane, @allroundexperts, @flaviadefaria Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@madmax330, @sobitneupane, @allroundexperts, @flaviadefaria Whoops! This issue is 2 days overdue. Let's get this updated quick!

Not overdue, just waiting on payment

@madmax330, @sobitneupane, @allroundexperts, @flaviadefaria Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ]  The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/15776

[ ]  The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/15776 PR adds the link to the error page that navigates to home. I am not sure if it was a bug or intended behavior back then. https://github.com/Expensify/App/pull/15776#issuecomment-1508369585

[ ]  A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

^

Regression Test Proposal

Open Expensify app
Send a non existing expensify url (example: https://staging.new.expensify.com/anything) in chat.
Click on the url to open it.
Press "Go back to Home page"
Verify that you are on home page (LHN if you are on small screen).

Do we agree 👍 or 👎

Looking to pay this today:
$1000 will be paid to both @sobitneupane and @allroundexperts (no bonus)
@madmax330 do you agree with the Regression Test proposal?
Also @sobitneupane can you check the boxes/complete the tasks here

@sobitneupane and @allroundexperts have been paid.

@madmax330 do you agree with the Regression Test proposal?
Also @sobitneupane can you check the boxes/complete the tasks https://github.com/Expensify/App/issues/15874#issuecomment-1491716046

@madmax330 and @sobitneupane when on you so that we can close this GH.

@flaviadefaria I have completed the checklist here

Ah I missed that, thank you @sobitneupane!

All done closing this.


Resolve detekt rules

          1 Warning

:warning:
Please start subject with capital letter.
f0143a00f1a15e32cb2c0862fb44145a02a79235

  Generated by :no_entry_sign: Danger


Support multiple chips

Hey @arctic-alpaca this is quite massive, lets maybe go through this together first, so I keep it in draft.

Since you anyways went through most of the code, let me undraft this PR.


Certificate Status Request Memory Leak Fix

Please note that while we are transitioning from travis-ci to AWS CodeBuld, some tests are run on each platform. Non-AWS contributors will temporarily be unable to see CodeBuild results. We apologize for the inconvenience.
Issue # (if available): https://github.com/awslabs/s2n/issues/1565
Description of changes: This pull request alters the code in two places. First, it changes the s2n_alloc in s2n_server_certificate_status_parse to s2n_realloc in order to avoid the memory leak. This means that each time we receive a certificate status request, it will overwrite the last one. Since each certificate status request message contains unique data that should be processed separately when it is received, this should not be a problem. Additionally, if we receive a malformed status request that causes an error, the other party can simply re-send their message and it will replace the malformed one. The second change is to ensure that we don't accept more than one copy of the same certificate extension type in each certificate extensions block. By doing this we conform to the RFC, which states that this is not allowed. This helps prevent realloc from being called more than once per certificate extensions block.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request head (mem-leak-fix@1047197). Click here to learn what that means.
The diff coverage is n/a.


Finished first draft

I'd like to get more people to review it, so I'm making a pull request, so that it can get into the collection of guides, where, hopefully, folks will pay more attention to it.

@mminella I have moved this PR into an operational yet private repo here => https://github.com/spring-guides/gs-reactive-rest-service. If would be willing to open new issue(s) with your feedback there, I think it would serve things best.

I'm going to close this PR, since it's been carried into the repo just mentioned.


Problems to add new records using dbf.appendRecords(records)

Hi guys, I'ave problema to insert a new register to DBF file, mi error is the next:
Error: SALESDATE: expected a date
my code:
let records = [
{
CID: 'JN0LZGRL',
CM: '01',
SALESDATE: '15/03/23',
CCOD_DOC: '07',
CSER: '00B070',
CNUM: '0000000000241',
}
]
Help me pls

Hi Guys
The problem is solved with new Date() function, thanks


Design UI for activity presets

Figma file for dev:
https://www.figma.com/file/Faz3BeV0SAwyuZ4Ld3Lz0u/Presets?node-id=870%3A63424&t=nMq1gmOoLF7CUuY0-1
Key features

[ ] Add preset panel
[ ] Add the ability to duplicate, save, or delete presets
[ ] Add confirmation model for saving over and deleting presets
[ ] Update dots to show when data comes from preset
[ ] Ability to click on dot to reset overrides


How to use knobs?

Hi!
I used your application to understand how these plugin works and I found it very useful. Unfortunately, I was not able to make the encoder show up in the AJAZZ application, have you ever tried that?
Here is my code: https://github.com/iu2frl/StreamDock.Plugins.Olliter

I haven't had a chance to test any other models besides the 293S. I plan to try it later.

Thank you for the feedback, I suspect there's a bug in the AJAZZ software because even the sample plugin from the official devs is not shown in the knobs actions


halt and halt_error filters

Original jq has these since 1.6.
halt/0 terminates the program with exit code 0, halt_error/0 terminates the program with exit code 5, halt_error/1 uses the provided exit code.

Thanks for catching this. This is probably impossible to support in jaq 1.x due to restrictions in the current API, but with jaq 2.0, this can work. The idea to make it happen is to attach some kind of bool to the new Exn (exception) type that registers whether the error can be caught or not.

This is now done in 0278cc0. The implementation was actually much simpler than I thought and did not need any change to the exception type.


[WIP] Added AutoValueAttribute to NUnit3 glue library

Added relevant tests
Added dependency to Moq in AutoFixture.NUnit3.UnitTest

Related to #343

@zvirja I dared to make a PR even if we saw some things to be fixed in #343 just to keep the development happening in one place instead of gists and random scripts :)

Added the WIP header to indicate that PR should not be merged as it's in progress.

@zvirja I haven't forgotten this. Just super busy, as of late.


Bugfix/#55 refactor to atomics

closes #55.
This is my first stab at refactoring Channels to use atomics instead of raw integers to get rid of data-races.
As for why, see commit message:

Head and Tail on ChannelRaw get accessed in channelSend and channelReceive
before a lock acquisition happens in those procs.
That means that the output of the template they get used in (isEmpty/isFull) is dependent on a data-race.

That is because as a thread that has the lock may modify those values while they are being
read by another thrread without the lock.
This is noticed by thread-sanitizer and should be eliminated for the following reasons:

Users should not catch "false positives" for thread sanitizier such as this, which they currently will
It is generally a good idea to have multi-threaded code such as this data-race free

This refactor to atomics makes the entire thing atomic and thus impossible to have a
data-race with.

While I was at it I also refactored access to atomicCounter, mostly for consistency since with head/tail since I access those via getters/setters.
This is a draft since I'd like to present it for now and I would also like to add thread-sanitizer and address sanitizer checks to the general tests in the test-suite.
Meaning the test-suite should fail if either of those notice something wrong (in my opinion).
I'll try to do that once I figure out how, my head is mildly foggy from a cold right now and infrastructure config was always a tad harder for me.

Awesome! Much appreciated!

What I don't like about this solution is if it indeed satisfies the thread sanitizer, it's a hack and the code itself (without the comments or commit messages) might pain a deceptive picture of its logic.

This refactor to atomics makes the entire thing atomic and thus impossible to have a data-race with.

Is it? The guarantees of the atomic access protect from conflicting access, but if I'm not mistaken it's perfectly legal^mo for the counter to be loaded by a thread A, then stored to by a thread B before thread A enters the lock's critical section, meaning the data race is still there.
The logic of buffer access does not require the cursors to be atomic, but it won't be evident from the code and in my opinion it's a much bigger issue than any performance regressions this change might bring (which are probably negligible in most common cases).

Okay, this is nice. We now definitely know that tsan failures crash the test-suite, I'll look into how to fix that.

Just to clarify my previous comment that's a bit vague because lines in question have two issues.
First is the data race that's found by TSAN. It's the concurrent access to the cursor values prior to acquiring the lock. This is probably not an issue. Even though it seems like partial reads for integer types are possible even on common architectures^lt, unless we subscribe by the view that the undefined behaviour here can be truly undefined, the worst that can happen is a trash read of the cursor value -> erroneous comparison -> wasted lock acquisition.
Second is the race condition created by the fact that between getting the cursor state and acquiring the lock the value can be changed by another thread. This situation is created intentionally to reduce wasted lock acquisitions.
It looks like both things boil down to the same state which is expected and dealt with by the code. With the exception of the undefined behaviour for non-atomic reads.

2 Notable changes I have here:

The allocator was changed from nim's default to malloc. Why? Tsan finds memory races inside the allocator itself here, so with nim's default allocator these tsan checks can not pass. If desired I can post the stacktraces I got.
There were some data-races in smartptrs.nim pertaining almost entirely to this proc:

proc decr[T](p: SharedPtr[T]) {.inline.} =
  if p.val != nil:
    # this `fetchSub` returns current val then subs
    # so count == 0 means we're the last
    if p.val.counter.fetchSub(1, AcqRel) == 0:
      `=destroy`(p.val.value)
      deallocShared(p.val)

Using "Release" here as before is a datarace according to tsan (I can not understand how, I assume some level of operation reordering is enabled by this that makes it possible).
Using AcqRel makes it work beautifully on linux and macOs but apparently blows up on Windows, I'll check if it can deal with using SeqCst

Please do not merge for now. I only just now realized that threading comes with its own atomics module, which is not what channels.nim uses.
It uses std/atomics.
For consistency it should be using threading/atomics. I'll adjust this accordingly.

Alright, now we're golden

Not to be getting confusing here - The commits with #56 do not refer to this PR - That was an experimental branch on my side that has nothing to do with this PR.
That was me mixing up the numbering in the commits.


Lack of documentation for lfec use / sample source file.

I am trying to put together the simplest example of 'compiling' a hello world lfe file.
I can see how to run such a file via lfescript using the factorial example, but do not understand how to generate a (native?  erlang module?) file using lfec (it pauses and will print if the file I am using as a source file has errors, but it never seems to generate any output anywhere).

Yeah, the CLI help doesn't give much usage information. If you can read the arcana in a Makefile, that might be the best place to look. In another Github issue ( #368) I just showed how to compile a module (in a running Docker container, but that's beside the point):
$ mkdir examples/ebin
$ lfec -I include -o examples/ebin examples/ring.lfe

That compiles ring.lfe to examples/ebin/ring.beam, at which point it can be run with the following, since Erlang will know where to find ring:main when you tell it use add examples/ebin to the path:
$ lfe -pa examples/ebin -smp disable -noshell -run ring main<PHONE_NUMBER>0

I've updated the CLI usage to include an example:
$ ./bin/lfec -h

Usage: lfec [options] file ...

Options:

-h             Print usage and exit
-I name        Name of include directory
-o name        Name of output directory
-pa path       Add path to the front of LFE's code path
-pz path       Add path to the end of LFE's code path
-v             Verbose compiler output
-Werror        Make all warnings into errors
-Wnumber       Set warning level (ignored)
-D             Equivalent to +debug-print
-L             Equivalent to +to-lint
-E             Equivalent to +to-exp
-S             Equivalent to +to-asm
--             No more options, only file names follow
+term          Term will be added to options

Terms include:

+binary, +no-docs, +to-exp, +to-lint, +to-core0, +to-core, +to-kernel, +to-asm
+{outdir, Dir}, +report, +return, +debug-print

Example:

$ lfec -I include -o ebin examples/ring.lfe

Thanks for the update and issue resolution.


Editor does not work in hello world tutorial

Basically, I came across a problem very similar to #351. I installed swagger using npm install -g swagger, created a hello-world app, and tried to launch the editor.
Unfortunately, it didn't work until I had to explicitly install swagger-editor myself (using npm install --save-dev swagger-editor). It seems strange to me that swagger-editor isn't automatically installed during the app creation phase. If that is the intended effect, perhaps the README instructions should be updated to show that.

see my answer at last #351

thanks @phiphamuet, closing this...


ValidParenthesis using Stack in Java, c++, c and python

Is your feature request related to a problem? Please describe.
A common problem in programming interviews is checking the validity of parentheses within a given string. The task is to determine if the parentheses in the string are balanced and properly nested.
Describe the solution you'd like
Given a string containing only parentheses (e.g., "(){}[]"), write a function or method to check if the parentheses are valid. The string is considered valid if each opening parenthesis has a corresponding closing parenthesis and they are properly nested. The following rules apply:
-Each opening parenthesis must have a closing parenthesis of the same type.
-The closing parenthesis must come after the corresponding opening parenthesis.
-The string may also contain other characters, which are to be ignored when checking for validity.
I would Like to add this question in all languages include Java, c++, c and python in Stack folder.
Additional context
Example:
Input: "({[]})"
Output: true
Input: "([)]"
Output: false

Can you assign me this issue as I'm SSOC'23 open source contributor? Thank you!

Assigned!
@Jiggy9 : C, C++, Python and Java

Please don't raise LeetCode, GFG or HackerRank problems, kindly raise issues regarding standard algorithm

Sure , I understand thank you for clarify.


CI Metrics

Summary
KubeCF CI platform should stream metrics (prometheus metrics) related with pipelines executions for a timeline analysis.
Intended Outcome
To build reports that shows data like:

total builds.
builds failed.
builds succeed.
builds running.
build jobs scheduled to start.
build execution time.

and more depending of the data that can be streamed from the CI platform.

https://github.com/cloudfoundry-incubator/kubecf/pull/1330


wrong dependency on helm in prometheus operator app

This issue is a:
[X ] Bug Report
[ ] Enhancement suggestion
[ ] Feature request
@akosveres
The manifest of prometheus operator app specifies helm as a dependency that is not needed.

@akosveres, I created a #44 solving this.

This is fixed, @andyjeffries or @jeka can you close this issue?

I can I guess.


Katib documentation for DARTS algorithm

Part of: https://github.com/kubeflow/katib/issues/1211.
I added documentation for DARTS.
/assign @jlewi @gaocegege @johnugeorge

@andreyvelich @gaocegege Could one of you open up an OWNERs file in the HP Tuning directory with the appropriate OWNERs for Katib ?
This way you will be able to approve your own PRs.

/lgtm


[Feature]: Browserstack Integration for Cross-browser Testing

Feature description
The Browserstack Integration feature aims to seamlessly integrate Puppeteer with Browserstack, a leading cloud-based testing platform. This integration will empower users to conduct comprehensive cross-browser testing effortlessly, leveraging Puppeteer's powerful browser automation capabilities.
Key Benefits:
Expanded Browser Coverage: Users will have access to Browserstack's extensive collection of real browsers and devices, enhancing the scope of cross-browser testing scenarios.
Efficient Testing Workflow: Developers and QA teams can utilize Puppeteer's API to automate interactions across various browsers provided by Browserstack, streamlining the testing process.
Compatibility Assurance: The integration ensures thorough validation of web applications on a diverse range of browsers, minimizing the risk of compatibility-related issues.
Parallel Testing Efficiency: Take advantage of Browserstack's parallel testing feature to execute Puppeteer scripts concurrently on multiple browsers, significantly reducing testing time.
Detailed Documentation and Examples: Comprehensive documentation and illustrative examples will be provided to guide users through the integration process, enabling them to get started with ease.
Implementation Considerations:

Coordination with both the Puppeteer and Browserstack communities will be essential to ensure seamless integration and compatibility.

The feature will include a dedicated module or plugin within Puppeteer to facilitate easy integration with Browserstack.

Proper authentication and API key management will be incorporated to establish a secure connection between Puppeteer and Browserstack.

Use Case:
A front-end developer working on an e-commerce website can utilize the Browserstack Integration feature to automate testing across a range of browsers, including older versions of Internet Explorer and various mobile devices. This ensures that the website maintains optimal functionality and appearance for all users.

I believe this goes beyond Puppeteer's scope.


#40119 broke how dbal array in config/database.php is handled.

Laravel Version: 8.78.1
PHP Version: 8.1.0
Database Driver & Version: MySQL 8

Description:
#40119 introduced an improvement for handling custom Doctrine types. But for some people it broke the test suites. (https://github.com/laravel/framework/pull/40119#issuecomment-1005854737 and https://github.com/laravel/framework/pull/40119#issuecomment-1006906061)
For sequential test runs issue happens when there is only the dbal array in config/database.php And the issue is gone when adding DB::registerDoctrineType call to AppServiceProvider. Which is not a good solution because it causes the application to make DB connection while the app is booting.
For parallel test runs issue happens in both cases.
Steps To Reproduce:
This repo shows the bug.

@canvural Thank you for creating an issue out of our previous discussion!

And the issue is gone when adding DB::registerDoctrineType call to AppServiceProvider.

This only works for sequential test runners. As soon as you run php artisan test --parallel both ways of custom DBAL type registration are broken.

@bakerkretzmar @TomHAnderson if we can't find a solution right now it might be best that we revert the PR.

@canvural thanks a lot for reproducing it in a repo, I'll dig into this right now. @driesvints agreed, I can do that later today if we can't figure this out.

I've been working with @bakerkretzmar all day.  I think his PR #40303 addresses 1) problems with running unit tests in series and 2) accounts for unit tests in parallel and makes concessions for them.
I'm not certain parallel testing is 100% because I've been unable to run such tests locally.  I don't feel reverting the #40119 is the right move.


Be able to use a Cookie Jar

In this small PR, I added the possibility to use a Cookie Jar for all the requests.
I find it convenient since when using jira-connector, one can prompt the user only once for its username & password, and then store the cookie in a file for example.
All the following requests would just use the created cookie. Like that, the user won't have to store its password, are re-type it everytime, or the developer won't have to go through the pain of implementing an OAuth Authentication.
I also updated the README with an example, and the JS-DocBlock :)

Looks great!

Merged and published as 1.2.0 :smile:

Great, thanks a lot ! :)

PS: there's a typo in the README, I forgot to remove the ../ when require jira-connector

Thanks for the heads up, I'll be sure to patch it in the next update


Make init, deploy & destroy more abstract for easier adaptions

Is your feature request related to a problem? Please describe.
Currently, it just grows and it will reach a point where it is not maintainable anymore without huge efforts.
Describe the solution you'd like
An adapter layer needs to be implemented.
Check which provider is affected:
[x] Azure
[x] AWS
[x] Google Cloud Platform

implemented by #28


Reuse binary file for inference during training.

NNtrainer generates the binary file for the inference.
It depends on the scenario but there is request to use saved binary file again to fine tuning the model.

:octocat: cibot: Thank you for posting issue #1867. The person in charge will reply soon.


Auto restart and rebuild angular universal on save

I turned my application to angular universal. It's great but I have a problem with developing mode. I need to see my editing result real-time. I need to restart my app on each atrl+s (save) like build --watch and nodmeon.
My server is Eexpressjs and I'm using the command  "npm run build:ssr" after each edit. It takes lots of time!!
How can I do that?

@samialmorshedi it writes on readme

@fulls1z3  I have read the whole readme file. I did not find that. Could you please help me find it or mention the exact part that I could find it? Thanks a lot.

How it is possible? Its here https://github.com/ng-seed/universal#-building


Start setting up oauth flow

TODO:

[ ] Add a sign in button somewhere
[ ] Make an authenticated request (account information for nav drawer header?)
[ ] Handle 401s
[ ] Sign out

lgtm, whether you want to merge now or keep adding to this PR

merge on success


Adding SpanByte to System

Description
Adding SpanByte to System which is a simplified version of Span for byte. This will be used to replace byte[] in I2C, SPI and other low level operation manipulating byte buffers.
Motivation and Context
Today low level operation to transmit data to an I2C or SPI device is using raw byte buffer. This sometimes involve allocating and copying buffers. This concept of Span originally introduced with .NET Core is in short, a T[], int start and int end class. As nano Framework doesn't support generics, this is a simple implementation of Span named SpanByte.
This will be widely available and will allow to migrate native byte[] transfers to SpanByte.
How Has This Been Tested?
This has been tested with various sensors ported to nanoFramework from .NET IoT
Types of changes

[x] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@Ellerbach on your attempt to set the language version.
According to the documentation as we are "kind of inline" with .NET Framework we should be supporting 7.3.
I've added that to the nfproj file and the build went fine: <LangVersion>7.3</LangVersion>
Except for the nullable reference type which is supposed to be available only with 8.0.
So feel free to add that one above.

@Ellerbach @krwq on a more high level look at this I was reading the documentation for the Span class and the remarks here got me thinking...
I'm starting a conversation about this on Discord

Span class and the remarks here got me thinking...

The stackalloc part is removed, the pointer part as well, we are in a fully managed environment. In short, to "migrate" code from .NET Core to nanoFramework, a global replace of Span to SpanByte and from stackalloc to new will make the trick

a global replace of Span to SpanByte and from stackalloc to new will make the trick

No doubts about that! My comments were more towards the overall implementation of this (. NET IoT included) and to point out these nuances that exist on smaller MCUs.

@Ellerbach FYI I've just added <LangVersion>7.3</LangVersion> to the project system targets. So this will be the default from now on. It's OK to add it to mscorlib nfproj for now until that's made available on a coming VS extension release.

It's OK to add it to mscorlib nfproj for now until that's made available on a coming VS extension release

All works for me :-)

Build is now OK with the update targets.


404 Error

Hi, the link to the pbix file returns an 404 error - could you please fix it?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7c22af6d-1ae9-9288-51b6-8d05c51d1b56
Version Independent ID: bd77226f-99c4-9f7f-c353-7fa0891a891c
Content: COVID-19 tracking sample for US state and local governments - Power BI
Content Source: powerbi-docs/create-reports/sample-covid-19-us.md
Service: powerbi
Sub-service: pbi-reports-dashboards
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Hi, @Krzysztof-Hyla -- hmmm, not good. I'll investigate soon. Thanks for letting me know!

Hi, @Krzysztof-Hyla -- hmmm, not good. I'll investigate soon. Thanks for letting me know!

Hi @Krzysztof-Hyla ,
Thank you for your question.  However, I am unable to replicate it, so I am going to close this Git Issue.  Perhaps the broken link has already been updated?  If you still have problems, just let us know.
Take care,
the DOCS team


fix @ to resolve to first of array or first of array o arrays

#2663
Change @ to resolve to turn.recognized.entities.first() and added a first() which tries [0][0] and then fallsback to [0]

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3


haskellPackages: Fix gi-glib, gi-cairo and gi-xlib for 8.2

Motivation for this change
This and https://github.com/NixOS/nixpkgs/pull/46766 fix the build for taffybar on 8.2
I'm not entirely sure what the reason for needing the override is
Ping @basvandijk @peti
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Fits CONTRIBUTING.md.

Looks like the authors have a problem with haskell-gi-overloading-1.0 on GHC 8.2. From the gi-glib cabal file:
      -- https://ghc.haskell.org/trac/ghc/ticket/14382
      if impl(ghc == 8.2.*)
              build-depends: haskell-gi-overloading == 0.0

Should we just unilaterally set haskell-gi-overloading to 0.0 for GHC 8.2.2?

Can't be bothered with this right now. It's almost not worth fixing these couple packages when I know lots more would fail. A mass fix would be nicer.


Fixed typo in Readme.markdown

Feedback server was using 'APNS' modified to the correct 'APNs'

Seems somebody else jumped in, made the same change, and got it merged while this was languishing in review, but thank you for the (entirely correct) PR.


Dropdown open/closed status cannot persist between renders

Describe the bug
Re-renders of a Dropdown instance render with the Dropdown in a "closed" state.  Current functionality does not provide for persistence of the Dropdown's open/closed status between render cycles.
Additional context

The desired behavior is that the parent component is given a means to control the Dropdowns open/closed status.
The following is an example where this behavior is not accessible:

Dropdown content consists of a form element.
Form element contains Checkbox elements, acting as toggleable filters.
Checkbox values are defined pre-render.  Therefore, Checkbox values are kept in parent component state.
Checkbox onChange functions manipulate parent component state, which causes the Dropdown to re-render in a closed state.

Drawer/Modal are examples of components which take an isOpen prop, whcih would provide the desired functionality.

Note: only fix in v3. Release before December 2022

Not reproducible. This is addressed by using Dropdown form.


Downgrade externals - tests for test platform nuget

Description
We found out that TraceDataCollector depends on Coverage.Interop.dll so previous deletion of Coverage.Interop.dll results in not be able to get code coverage. This was detected by manual test. PR is also adding automatic test to check TP + TraceDataCollector (from VS) integration.
Related issue
Kindly link any related issues. E.g. Fixes #xyz.

Could you fix the description, please? I don't understand what was this meant to do. And would like to know in the future, if it is identified in some regression.

Could you fix the description, please? I don't understand what was this meant to do. And would like to know in the future, if it is identified in some regression.

Done


Allow user to give advice when team advice exists

Would be nice to add some tests and break the changeset into more atomic commits.

noticed one small bug - have deployed to dev and asked Dan to check if it fixes the problem


PLNSRVCE-606 Multiple maven installations

@dwalluck @gabemontero so it seems like the 'standard' java images might not really be what we want, as the runtime image does not provide tools we need like 'javadoc', and the non-runtime one that we are using at the moment packages extra stuff (i.e. maven) that we don't really need (which is causing the linked issue about two different maven's being installed).
I wonder if we should just base these images on UBI and install Java ourselves? It seems like it would give us a lot more flexibility.

I wonder if we should just base these images on UBI and install Java ourselves? It seems like it would give us a lot more flexibility.

I think that's a good idea. We can just install java-*-openjdk-devel manually on top. Note that if using ubi-minimal, builds also seemed to require glibc-langpack-en.

does not provide tools we need like 'javadoc', and the non-runtime one that we are using at the moment packages extra stuff (i.e. maven) that we don't really need (which is causing the linked issue about two different maven's being installed).

You should be able to do dnf -y remove maven maven-lib, and it's cleaner than just doing rm, before installing the new maven because the files are in /usr/share/maven/lib.

closing for now, as this is moving to a new repo anyway


delete_expired_photos rake task should delete from both s3 buckets

For the same reasons described in https://github.com/inaturalist/inaturalist/issues/3068

This was fixed in 386dc66


Convert all path construction  to use lua-path instead of string concatenations

Might help with Windows compat later.

Fixed in adfb736399f2db3299f95e8c2fac40161b5288cc


improve android payments

GodotPaymentV3 currently consumes purchased item right after purchasing.
But, some in-app item should not consume like "remove ads permanently"
So, I added "setAutoConsume(boolean)", "requestPurchased()",
"consume(sku_string)".
AutoConsume is true by default as before.
usage:
func _ready():
	var payment = Globals.get_singleton("GodotPayments")
	payment.setPurchaseCallbackId(get_instance_ID())
	payment.setAutoConsume(false) # default : true
	payment.requestPurchased() # callback : has_purchased
	payment.purchase("item_name") # callback : purchase_success, purchase_fail, purchase_cancel, purchase_owned
	payment.consume("item_name") # callback : consume_success

func purchase_success(receipt, signature, sku):
	print("purchase_success : ", sku)

func purchase_fail():
	print("purchase_fail")

func purchase_cancel():
	print("purchase_cancel")

func purchase_owned(sku):
	print("purchase_owned : ", sku)

func consume_success(receipt, signature, sku):
	print("consume_success : ", sku)

func has_purchased(receipt, signature, sku):
	if sku == "":
		print("has_purchased : nothing")
	else:
		print("has_purchased : ", sku)

It would be great if this could be merged into the 2.0 release. :)


Need sort function for string array

Description:
Need this function for twitter connector.
Existing arrays:sort(string []) is not working in Ballerina 0.964.1-SNAPSHOT.
Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Related issue: https://github.com/ballerina-platform/ballerina-lang/issues/1433

You can use array.sort lang lib method and string.codePointCompare method to achieve this. Fixed with JBallerina 1.0.0-alpha.


Quite extended downtime of ksp.spacetux.net

just an FYI, my systems suffered a new DHCP address change today, so the calls to ksp.spacetux.net have been failing for a couple of hours.
I've just gotten the ddclient to run, so it should be ok in a few minutes.
Go ahead and close this when you read it, was just the fastest way I knew to get you the message

Thanks.
Interestingly we only received timeout notifications for 6 modules. All your other mods somehow managed to succeed:

You could write similar messages on our Discord in the future, though I'm not sure if you're using that actively.

I'll keep that in mind, although Discord is not a big thing for me

I think this may (still) be causing timeouts and overall bot slowness:
http://status.ksp-ckan.space/ (sort by Last Inflated, the LGG mods early in the alphabet are taking many many minutes to inflate, still have timeout warnings, and the inflation pass just stops at some point)

@linuxgurugamer, any chance your server can get fixed?

Should we consider setting a timeout for DownloadText()? This might help use keeping the bot at least somewhat alive when ksp.spacetux.net or ksp-avc.cybutek.net go down like this (or even GitHub's or SpaceDock's API).
I think I got something working using https://stackoverflow.com/a/3052637.
if we don't want to set it for normal client operations like build map and repo list download, we could make it a parameter of DownloadTest() and only set it when called from NetKAN.

Should we consider setting a timeout for DownloadText()?

Sounds good to me. I wonder how much of a risk there would be of false positives, timing out something that is actually working and just needs a few more seconds.


[#6253] Fix ITTest

Codecov Report

Merging #6295 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #6295      +/-   ##
=========================================
- Coverage   39.64%   39.6%   -0.05%
=========================================
  Files        3061    3064       +3
  Lines       91304   91370      +66
  Branches    11817   11829      +12
=========================================
- Hits        36202   36191      -11
- Misses      52118   52195      +77
  Partials     2984    2984

Impacted Files
Coverage Δ

.../navercorp/pinpoint/bootstrap/config/Profiles.java
0% <ø> (ø)
:arrow_up:

...npoint/bootstrap/config/PropertyLoaderFactory.java
0% <0%> (ø)

...inpoint/test/plugin/PinpointPluginTestContext.java
0% <0%> (ø)
:arrow_up:

...inpoint/bootstrap/config/SimplePropertyLoader.java
0% <0%> (ø)

...rp/pinpoint/test/plugin/DefaultProcessManager.java
0% <0%> (ø)
:arrow_up:

.../navercorp/pinpoint/bootstrap/PinpointStarter.java
0% <0%> (ø)
:arrow_up:

...int/bootstrap/config/ProfileLogConfigResolver.java
0% <0%> (ø)

...point/test/plugin/shared/SharedProcessManager.java
0% <0%> (ø)
:arrow_up:

.../com/navercorp/pinpoint/profiler/DefaultAgent.java
0% <0%> (ø)
:arrow_up:

...t/test/plugin/AbstractPinpointPluginTestSuite.java
0% <0%> (ø)
:arrow_up:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0cf16c...43b8bc1. Read the comment docs.


nsqd pod exited as 'completed' triggering app health check failures

Deis' own champagne cluster was affected by the nsqd pod exiting w/ Completed status, seemingly triggering errors in both the registry and workflow-manager pods.  (The alerts leading us to investigate were health check failures on the k8s-claimer app deployed on this cluster.)
Here is the log tail from said pod:
...
[nsqd] 2016/10/31 21:25:50.576088 200 GET /stats?format=json (<IP_ADDRESS>:34742) 39.962µs
[nsqd] 2016/10/31 21:25:51.050988 HTTP: closing [::]:4151
[nsqd] 2016/10/31 21:25:51.052387 TCP: closing [::]:4150
[nsqd] 2016/10/31 21:25:51.052510 NSQ: persisting topic/channel metadata to /opt/nsq/data/nsqd.905.dat
[nsqd] 2016/10/31 21:25:51.534562 NSQ: closing topics
[nsqd] 2016/10/31 21:25:51.534729 TOPIC(metrics): closing
[nsqd] 2016/10/31 21:25:51.534804 TOPIC(metrics): closing ... messagePump
[nsqd] 2016/10/31 21:25:51.534844 CHANNEL(consumer): closing
[nsqd] 2016/10/31 21:25:51.534921 DISKQUEUE(metrics:consumer): closing
[nsqd] 2016/10/31 21:25:51.534989 DISKQUEUE(metrics:consumer): closing ... ioLoop
[nsqd] 2016/10/31 21:25:51.536344 PROTOCOL(V2): [<IP_ADDRESS>:53476] exiting ioloop
[nsqd] 2016/10/31 21:25:51.547640 ERROR: client(<IP_ADDRESS>:53476) - failed to read command - read tcp <IP_ADDRESS>:4150-><IP_ADDRESS>:53476: use of closed network connection
[nsqd] 2016/10/31 21:25:51.549589 PROTOCOL(V2): [<IP_ADDRESS>:40500] exiting ioloop
[nsqd] 2016/10/31 21:25:51.549655 ERROR: client(<IP_ADDRESS>:40500) - failed to read command - read tcp <IP_ADDRESS>:4150-><IP_ADDRESS>:40500: use of closed network connection
[nsqd] 2016/10/31 21:25:51.551025 PROTOCOL(V2): [<IP_ADDRESS>:40500] exiting messagePump
[nsqd] 2016/10/31 21:25:51.551086 PROTOCOL(V2): [<IP_ADDRESS>:48059] exiting ioloop
[nsqd] 2016/10/31 21:25:51.551144 ERROR: client(<IP_ADDRESS>:48059) - failed to read command - read tcp <IP_ADDRESS>:4150-><IP_ADDRESS>:48059: use of closed network connection
[nsqd] 2016/10/31 21:25:51.551182 PROTOCOL(V2): [<IP_ADDRESS>:48059] exiting messagePump
[nsqd] 2016/10/31 21:25:51.551246 PROTOCOL(V2): [<IP_ADDRESS>:53476] exiting messagePump
[nsqd] 2016/10/31 21:25:51.664931 DISKQUEUE(metrics): closing
[nsqd] 2016/10/31 21:25:51.665069 DISKQUEUE(metrics): closing ... ioLoop
[nsqd] 2016/10/31 21:25:51.809062 TOPIC(logs): closing
[nsqd] 2016/10/31 21:25:51.809250 TOPIC(logs): closing ... messagePump
[nsqd] 2016/10/31 21:25:51.809313 CHANNEL(consume): closing
[nsqd] 2016/10/31 21:25:51.809359 DISKQUEUE(logs:consume): closing
[nsqd] 2016/10/31 21:25:51.809416 DISKQUEUE(logs:consume): closing ... ioLoop
[nsqd] 2016/10/31 21:25:51.810602 PROTOCOL(V2): [<IP_ADDRESS>:44983] exiting ioloop
[nsqd] 2016/10/31 21:25:51.810664 ERROR: client(<IP_ADDRESS>:44983) - failed to read command - read tcp <IP_ADDRESS>:4150-><IP_ADDRESS>:44983: use of closed network connection
[nsqd] 2016/10/31 21:25:51.810752 PROTOCOL(V2): [<IP_ADDRESS>:44983] exiting messagePump
[nsqd] 2016/10/31 21:25:51.961055 DISKQUEUE(logs): closing
[nsqd] 2016/10/31 21:25:51.961237 DISKQUEUE(logs): closing ... ioLoop
[nsqd] 2016/10/31 21:25:52.081016 QUEUESCAN: closing
[nsqd] 2016/10/31 21:25:52.081297 200 GET /stats?format=json (<IP_ADDRESS>:34742) 896.959019ms
[nsqd] 2016/10/31 21:25:52.166461 200 GET /stats?format=json (<IP_ADDRESS>:43496) 650.746772ms
[nsqd] 2016/10/31 21:25:52.167008 ID: closing
[nsqd] 2016/10/31 21:25:52.167217 LOOKUP: closing

Cluster state when investigated:
$ kd get po
NAME                                     READY     STATUS      RESTARTS   AGE
deis-builder-808234085-4er8f             1/1       Running     11         14d
deis-controller-3550476522-vjmsw         1/1       Running     0          19d
deis-logger-1750174080-h61sh             1/1       Running     0          19d
deis-logger-fluentd-0s73r                1/1       Running     1          19d
deis-logger-fluentd-m6m7c                1/1       Running     0          19d
deis-logger-fluentd-w2gbi                1/1       Running     0          19d
deis-logger-redis-4282343581-o53zz       1/1       Running     0          19d
deis-monitor-grafana-947410455-7cujl     1/1       Running     0          19d
deis-monitor-influxdb-802438432-eyz7v    1/1       Running     0          19d
deis-monitor-telegraf-6qx76              1/1       Running     3          19d
deis-monitor-telegraf-c8d4t              1/1       Running     0          19d
deis-monitor-telegraf-cz6g7              1/1       Running     0          19d
deis-nsqd-2528936859-oe5je               0/1       Completed   3          19d
deis-registry-2153931602-3jmt9           0/1       Error       0          19d
deis-registry-proxy-s9p27                1/1       Running     0          19d
deis-registry-proxy-vg02u                1/1       Running     1          19d
deis-registry-proxy-vih1z                1/1       Running     0          19d
deis-router-1833288991-6itpr             1/1       Running     0          19d
deis-workflow-manager-3855316227-r1z8o   0/1       Error       0          19d

Log tail from registry pod, unhelpful besides timestamps:
<IP_ADDRESS> - - [31/Oct/2016:21:23:20 +0000] "GET /v2/ HTTP/1.1" 200 2 "" "Go-http-client/1.1"
time="2016-10-31T21:23:20.983954657Z" level=info msg="response completed" go.version=go1.6.2 http.request.host="<IP_ADDRESS>:5000" http.request.id=7825c2e9-11a2-45f3-b906-af8f6094dfc2 http.request.method=GET http.request.remoteaddr="<IP_ADDRESS>:52909" http.request.uri="/v2/" http.request.useragent="Go-http-client/1.1" http.response.contenttype="application/json; charset=utf-8" http.response.duration=174.29994ms http.response.status=200 http.response.written=2 instance.id=bc726225-3d34-4142-a327-fc7f79f87ccf service=registry version=v2.1.1-601-g0afef00
<IP_ADDRESS> - - [31/Oct/2016:21:23:20 +0000] "GET /v2/ HTTP/1.1" 200 2 "" "Go-http-client/1.1"

Note: Interestingly, unless there is some time skew at play, the last log from registry is at 21:23:20 whereas the nsqd timestamp is a bit later at 21:25:51 -- so it may indeed be a registry issue...

This issue was moved to teamhephy/nsq#2


[Package Issue]: Microsoft.VisualStudioCode reports error code 67 "the network name cannot be found" when upgrading

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Installation issue.
Brief description of your issue
when updating visual studio code 1.75.0 to 1.75.1, the installer will download but will fail displaying the following error:
"ShellExecuteEx failed; code 67. The network name cannot be found."
Steps to reproduce
update visual studio code from version 1.75.0 to version 1.75.1.
Actual behavior
the installer will download and prompt for UAC credentials, after being supplied with these credentials, the installer will crash displaying the following error:
"ShellExecuteEx failed; code 67. The network name cannot be found."
Expected behavior
the update should be done successfully.
Environment
Windows Package Manager v1.4.10173
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19045.2546
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.10173.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

User Settings: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json

Screenshots and Logs
WinGet-2023-02-13-13-21-00.180.log

Same issue with Version 1.79.1. Noo clue what happened and why.

This should be resolved in WinGet v1.5 release candidate. @tranquilcarbon @cjwijtmans  Can you please upgrade your WinGet Client and try again?


Support CUDA gpus

Hi Simon,
I was just looking at https://huggingface.co/datasets/SciPhi/AgentSearch-V1
1 Billion passages and 50 Million documents with jina embeddings.
So it motivated me to add cuda support to your jina plugin. CPU is way too slow for me. Only problem is you need to drop the batch size to 1 or 2 for most consumer devices.
Changes

Add try/except block to move model to CUDA or keep it on CPU if CUDA is not available
No changes to functionality or API of the class

Timing tests
CPU - Batch size 10 (The maximum I can run in 64GB)
time llm embed-multi prompts-cpu-b10-run1 -d embeddings.db --attach logs $(llm logs path) --sql 'SELECT id, prompt FROM logs.responses LIMIT 1000' -m jina-embeddings-v2-base-en --prefix prompt/ --batch-size 10

Output:
llm embed-multi prompts-cpu-b10-run1 -d embeddings.db --attach logs  --sql  -m
  7142.22s user 3449.01s system 1320% cpu 13:21.98 total

GPU
time llm embed-multi prompts-gpu-b1-run2 -d embeddings.db --attach logs  --sql  -m jina-embeddings-v2-base-en --prefix prompt/ --batch-size 1

Output:
llm embed-multi prompts-gpu-b1-run2 -d embeddings.db --attach logs  --sql  -m
25.44s user 11.39s system 130% cpu 28.310 total

Hi @simonw I'd like to add a flag so we can choose cpu or cuda (and does metal need its own flag or will cpu work?) but I'm not familiar with click. I can make simple click apps with chatgpt, but I got lost trying to figure out exactly where and how to add a new click option to your project. Could you point me in the right direction? Thanks!


Allow arbitrary TFlint args (instead of --deep by default)

This changes the behaviour of the TFlint hook from enforcing --deep to allowing arbitrary args to be specified (including, but not limited to, --deep) in the hook configuration.
Addresses #71 and a few comments in #53.
I'm in a similar boat to the other commenters - using this hook for non-AWS Terraform code, in my case to enforce some terraform rules rather than AWS rules (commented variables, commented outputs, pinned versions etc).

Thank you, @choppedpork, for putting this all together!
v1.21.0 of this module has been just released.