ENH/CLN: Increase and tidy logging.

Description

Add INFO messages right before the plan is executed and right after
state is cleared up in the finally block.
Remove superfluous messages.
Make use of logging.exception to show full tracebacks in error logs.

Motivation and Context
As we prepare to capture logs systematically for all beamlines, I am reviewing what information we log.
How Has This Been Tested?
The pytest coverage of run_engine.py is extremely good, so I expect that will catch any typos. See interactive test below.
Screenshots (if appropriate):
The output of RE(count([det])) with DEBUG logs on is:
[I 09:01:41.499 run_engine:743] Executing plan <generator object count at 0x1174a0d68>
[I 09:01:41.500 run_engine:82] Change state on <bluesky.run_engine.RunEngine object at 0x11559bef0> from 'idle' -> 'running'
[D 09:01:41.500 run_engine:1184] stage: (SynGauss(name='det', value=1.0, timestamp=1542808901.4860082)), (), {}
[D 09:01:41.500 run_engine:1184] open_run: (None), (), {'detectors': ['det'], 'num_points': 1, 'num_intervals': 0, 'plan_args': {'detectors': ["SynGauss(name='det', value=1.0, timestamp=1542808901.4860082)"], 'num': 1}, 'plan_name': 'count', 'hints': {'dimensions': [(('time',), 'primary')]}}
[D 09:01:41.503 run_engine:1375] Emitted RunStart (uid='bfef98f6-2229-4eed-9cff-da60414061b4')
[D 09:01:41.503 run_engine:1184] checkpoint: (None), (), {}
[D 09:01:41.503 run_engine:1184] trigger: (SynGauss(name='det', value=1.0, timestamp=1542808901.4860082)), (), {'group': 'trigger-f2509b'}
[D 09:01:41.504 run_engine:1996] The object SynGauss(name='det', value=1.0, timestamp=1542808901.504054) reports trigger is done with status True.
[D 09:01:41.504 run_engine:1184] wait: (None), (), {'group': 'trigger-f2509b'}
[D 09:01:41.504 run_engine:1184] create: (None), (), {'name': 'primary'}
[D 09:01:41.504 run_engine:1184] read: (SynGauss(name='det', value=1.0, timestamp=1542808901.504054)), (), {}
[D 09:01:41.504 run_engine:1184] save: (None), (), {}
[D 09:01:41.506 run_engine:1690] Emitted Event Descriptor with name 'primary' containing data keys dict_keys(['det']) (uid='11605370-ea93-4b9b-b8eb-ae29974a945b')
[D 09:01:41.507 run_engine:1722] Emitted Event with data keys dict_keys(['det']) (uid='eb4fd8ed-9256-42fd-b55c-262124ebfc90')
[D 09:01:41.507 run_engine:1184] close_run: (None), (), {'exit_status': None, 'reason': None}
[D 09:01:41.507 run_engine:1408] Stopping run 'bfef98f6-2229-4eed-9cff-da60414061b4'
[D 09:01:41.508 run_engine:1433] Emitted RunStop (uid='c69989be-86e0-4cad-80ac-76b32f243523')
[D 09:01:41.509 run_engine:1184] unstage: (SynGauss(name='det', value=1.0, timestamp=1542808901.504054)), (), {}
[I 09:01:41.509 run_engine:82] Change state on <bluesky.run_engine.RunEngine object at 0x11559bef0> from 'running' -> 'idle'
[I 09:01:41.509 run_engine:1315] Cleaned up from plan <generator object count at 0x1174a0d68>

Codecov Report

Merging #1123 into master will increase coverage by 0.08%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #1123      +/-   ##
==========================================
+ Coverage   89.16%   89.24%   +0.08%
==========================================
  Files          51       51
  Lines        8537     8536       -1
==========================================
+ Hits         7612     7618       +6
+ Misses        925      918       -7

Impacted Files
Coverage Δ

bluesky/run_engine.py
95.8% <71.42%> (-0.01%)
:arrow_down:

bluesky/log.py
75.67% <0%> (+9.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd8552...e554d27. Read the comment docs.


added before open hook

this is a PoC of a "before open" hook: an user could perform async tasks before loading the sharer window.
missing e2e.

Interesting, wouldn't a "before open" event be more convenient here? no callback to pass, and it's easier for other developers to create any code they want around that.
Is there a specific use case that require a Promsie?

@nicolasbeauvais
Promises are useful when you need to run async tasks before the sharer popup gets opened, while events would be used just to read something or to execute sync tasks.
The situation would be different if you want to do message passing (through events) between the vue-social-sharing component and its father: in this case I think the promise approach is still better and less difficult to implement.

Alright, that use case seems good to me :)
you can pursue the PR code and I will merge it once you're done!

Closing for no activity.
Feel free to re-open if needed


alternate=true and submenus don't work together

#!/bin/bash

echo "Submenu Tutorial"
echo "---"
echo "Places"
echo "Places alt | alternate=true"
echo "--London"
echo "--In England | alternate=true"
echo "--Paris"
echo "--In France | alternate=true"
echo "--Tokyo"
echo "--In Japan | alternate=true"
echo "Fruit"
echo "--Apple"
echo "--Orange"
echo "--Melon"
echo "----Watermelon"
echo "----Honeydew"

default:

with option:

Notice how there is no submenu for 'Places' until you press . I think in the context of submenus, the alternate line should be considered the same as the default line. And treated as a single menu row.

Closing this. I figured out how to work this feature correctly:
#!/bin/bash
set -e
echo "Submenu Tutorial"
echo "---"
echo "regular"
echo "-- normal submenu"
echo "-- normal submenu alt | alternate = true"
echo "alternate only shown when option is pressed and mouse not on this item | alternate=true"
echo "--alternate submenu"
echo "--alternate submenu alternate | alternate=true"


Move module to k8c.io/machine-controller

What this PR does / why we need it:
Move the machine-controller module from github.com/kubermatic/machine-controller to k8c.io/machine-controller. We have done this a long time ago for other projects, but machine-controller had some technical blockers. Those blockers got resolved along the way, and now we can finally proceed with this change.
What type of PR is this?
/kind feature
/kind api-change
Does this PR introduce a user-facing change? Then add your Release Note here:
[ACTION REQUIRED] Move the machine-controller Go module from `github.com/kubermatic/machine-controller` to `k8c.io/machine-controller`. If you're using machine-controller types or packages, you'll have to update your code to use `k8c.io/machine-controller`.

Documentation:
NONE

/assign @xrstf
/hold requires infra changes

/test pull-machine-controller-e2e-kubevirt

/test pull-machine-controller-e2e-hetzner
/test pull-machine-controller-e2e-vmware-cloud-director

/test pull-machine-controller-e2e-azure
/test pull-machine-controller-e2e-vmware-cloud-director

/test pull-machine-controller-e2e-azure

/test pull-machine-controller-e2e-vmware-cloud-director

/override pull-machine-controller-e2e-kubevirt

/approve
/lgtm

/override pull-machine-controller-e2e-azure no RHEL sub anymore
/override pull-machine-controller-e2e-vmware-cloud-director capacity issues

/override pull-machine-controller-e2e-azure
/override pull-machine-controller-e2e-vmware-cloud-director

/hold cancel
:shipit:


Conditional writer lock contention

The collision free map uses buckets to group work.  These buckets have a 1:1 correspondence with Accumulo rows.  Turns out this is really bad because the conditional writer locks entire rows.  So there is a lot of lock contention when using the collision free map.  I noticed this problem when running the web index example on a 20 node cluster.  The schema used by the collision free map needs to be changed.
The problem is not apparent with a single worker because all updates are grouped into a single conditional mutation within the worker.

The export queue may have the same problem with its schema


Migrate to Protobuf>=5.26.0,<6

Housekeeping

[X] I am a maintainer of dbt-core

Short description
We're currently depend on protobuf 4.y.z, and protobuf 5 is coming out soon. Thus far they've released three release candidates (5.26.0-rc1, 5.26.0-rc2, 5.26.0rc-3). We don't know exactly when the 5.26.0 production release will happen. However, if history is any indicator, it'll probably be out by the end of March 2024 (less than a month). It's hard to say how long it will take for the python community at large to migrate, but we should be prepared to do so.
Acceptance criteria

dbt-core depends on protobuf v5
dbt-core doesn't depend on protobuf v4

Suggested Tests
The current tests should still pass
Impact to Other Teams
None
Will backports be required?
No
Context
No response

It's out now.
It lead to this issue: https://github.com/dbt-labs/dbt-core/issues/9759

Any updates on migrating to protobuf v5?

Bump

@Nikohm and @ogescalante We don't have a timeline for protobuf v5.

I've opened a PR in dbt-common that addresses this: https://github.com/dbt-labs/dbt-common/pull/211

Bump, really needing this

Thxs for the mitigation but I can't downgrade protobuf since my project already requires >5
Would LOVE a fix on that 🙂

Bump


Add fileKey types to typescript

Add figma.fileKey to the types
Here: https://www.figma.com/plugin-docs/api/figma/#filekey

Mind removing the comment first?

Oh sure


Basic implementation of tracker roles

This patch exposes the name of the assigned tracker role at the beginning of the device name.
This does not expose roles being changed, or allow editable tracker bindings.

Owh thats pretty cool! I don't think it's the right thing to do but I can understand why you did it this way. This ties into the action system, I'm actually pretty happy to see that it extends like this, the documentation around this is so poor.
With the latest version you should be able to just define actions for these, then bind the tracker to the right action, and then use https://github.com/GodotVR/godot-openvr-asset/wiki/OpenVR-actions#openvrpose instead of ARVRController.


assigning symbols to ODEFunction

To use the solution interface with LabelledArrays and ComponentArrays
using LabelledArrays
using DifferentialEquations
using SimpleUnPack
using Plots

## SIR model, in-place form: f!(du, u, p ,t)
function sir!(D, u, p ,t)
	@unpack s, i, r = u
	@unpack β, γ = p
	v1 = β * s * i
	v2 = γ * i

    D.s = -v1
    D.i = v1 - v2
    D.r = v2
	return nothing
end

# Parameters, initial conditions, and time span of the SIR model
p = LVector(β = 1.0, γ = 0.3)
u0 = LVector(s=0.99, i=0.01, r=0.00)
tspan = (0.0, 20.0)

prob = ODEProblem(sir!, u0, tspan, p) ## Define the problem
sol = solve(prob) ## Solve the problem
sol(0.:1.:20.)[:s] ## Error
plot(sol, idxs=(:s, :i)) ## Works?!

# Let's fix it
f = ODEFunction(sir!, syms=keys(u0), paramsyms=keys(p))
prob = ODEProblem(f, u0, tspan, p) ## Define the problem
sol = solve(prob) ## Solve the problem
sol(0.:1.:20.)[:s] ## Works

plot(sol, idxs=(:s, :i)) ## Works

The situation changed, and now it's the plot() function gives an error. Waiting for the symbolic packages to settle.


Uncaught TypeError: Cannot read property 'effect' of undefined

I've exported the animation into jso file and it also has required images with it but the animation won't play, I took the js from build folder and used the default bodymovin example to render the file.
I can't figure out the error and
test.zip
what i need to get this going could you please look at it?

There is an expression trying to get an effect from layer Falloff.
Is it possible that that layer is hidden or guided?
If you send me the .ae project I can take a look


Update appmetrics for NodeV4 compatibility

@apg84: Looks good, except for one nit: can you ensure all the files to UNIX line-endings?

@tunniclm Done!

This work relates to issue #34.
There is a little bit more to do to get things passing tests on all supported platforms, however.


Feat: Support Self-Hosted Instances

This MR will allow the plugin to be used with self-hosted Gitlab instances, addresses #8
This is a work in progress! It draws heavily from this fork: https://github.com/marcinmaciukiewicz/gitlab.nvim

I found one potential issue. In utils is_gitlab_repo you check for 'gitlab.com' but that might actually not be a pattern that occurs in the self hostet url.

Removed that check, since you have to have a .gitlab.nvim file in the root of the project anyway, so we can just check for that. Do you mind giving this branch a try? I do not have a self-hosted instance set up.

I tried. Running of server fails
✦ ❯ ./bin -- 53 {HOST} 21036 {MY_TOKEN}
2023/07/29 11:52:33 Failure: Failed to initialize client: Failed to list merge requests: Get "53/api/v4/merge_requests?source_branch={CURRENT_BRANCH_NAME}&state=opened": unsupported protocol scheme ""

Server not starting from main branch, not sure is it intended
API route for MRs should be "{HOST}/api/v4/projects/53/merge_requests/"

Hey all, I'm quite busy with work and probably can't get this MR over the finish line for self-hosted repositories. This is largely due the fact that I don't actually need/use them, and don't have one configured for testing purposes. However, if anyone in this thread (@mrparalon or @mkonig) wants this feature and is willing to take this MR over the finish line, I'd happily review and merge the code. You can see from this MR that it's quite close.

Hey, good news all:
Set up my own self-hosted instance on AWS today, and was able to connect to it. I've merged in another (breaking) MR that slightly adjusts the setup of the plugin. Please pull down the latest main branch and make sure you have rebuilt the binary (you can do this manually if necessary via :lua require("gitlab").build()
Then provide the URL of your self hosted instance in the .gitlab.nvim file in the root of the repository, which now takes multiple options.
project_id=1
gitlab_url=http://<IP_ADDRESS>
auth_token=glpat-PpqF9koVnhuw5xFiBibb

Then checkout the branch. The plugin should work! See the updated README for more information.

I just want to leave a comment that you just made my sunday. thank you for your work

Of course! Please post here if you have any issues. This plugin is very much still in alpha so there are lots of bugs probably, and missing features. Always happy to take pull requests fixing them or adding more functionality


Update release-notes.md

@kivenkat : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@kivenkat Please use the private repo, thanks! #please-close

Added to private repo.


Update circe-core, circe-generic, ... to 0.14.4

Updates

io.circe:circe-core
io.circe:circe-generic
io.circe:circe-parser

from 0.13.0 to 0.14.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.circe" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.circe" }
}]

labels: library-update, early-semver-major, semver-spec-minor, version-scheme:early-semver, commit-count:1

Superseded by #640.


needs should fully contain dependencies

Minimal .gitlab-ci.yml illustrating the issue
---
job:
  needs: [one]
  dependencies: [two]
  script:
    - echo "Should fail during parsing and never get to this script"

Expected behavior
Error should be printed that dependencies: is not fully contained by needs:
Host information
Ubuntu 20.04
gitlab-ci-local 4.25.0

Fixed / Added in https://github.com/firecow/gitlab-ci-local/commit/6aa64563ab8eb4d4f9ce77feec1e01776ac02e5f


reset user Password

Hello @gfosco
How to allow users to reset password , can you help me please ?
Regards

It's documented here: https://github.com/ParsePlatform/parse-server#email-verification-and-password-reset
This is your 6th closed issue.  Please consider doing some investigation and troubleshooting before opening more.  Thanks.


Support Edge Store

Hi
Sometimes diversity is needed for not depend on Chrome store too much. Is it possible to support Edge store?

@dtantono you are right. I will publish it for edge in their store too!


feature request: New formatter - go templ fmt

Did you check existing requests?

[X] I have searched the existing issues

Describe the feature
It would be cool to have templ fmt formatter for go.templ files.
Provide background
No response
What is the significance of this feature?
nice to have
Additional details
https://github.com/a-h/templ

We already have built-in support for templ fmt
https://github.com/stevearc/conform.nvim/blob/master/lua/conform/formatters/templ.lua


[BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

Dear friends,
Our tasks are listed in general as below:

Migrated Apache Beam website from Jekyll to Hugo.
Configured multilingual support.
Developed testing with link-checker.
Updated documentation.

For more details, please refer to README.md and CONTRIBUTE.md inside website dir. :)
Best regards!

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Hi @pabloem, please take a look! :)

retest this please

(retest this please is a code word to ask jenkins to trigger tests)

Staged website: http://apache-beam-website-pull-requests.storage.googleapis.com/11554/index.html
There's something odd with it. Most internal links don't seem to be working in the staged site. LMK if I can help figure that out.
FYI The RAT PreCommit is related to having Apache License headers in all files. That should be fixed before merging.

retest this please

retest this please

@pabloem : Thanks for letting me know. I'll look into it. There is a commit which cleans Jekyll files, it causes conflicts. I couldn't resolve due to no permission. Probably, it stops you "retest this please". :D

retest this please

retest this please

retest this please

Staging still looks odd: : / - http://apache-beam-website-pull-requests.storage.googleapis.com/11554/index.html

Hi @pabloem, we made a fix. You could do retest this please once again. 🙂

retest this please

Run RAT PreCommit

Run Website_Stage_GCS PreCommit

It looks like you first made a bunch of commits that added files to the new directory (e.g. https://github.com/apache/beam/pull/11554/commits/ff7ef26642a9abe148f43d07faf931f69e08333e) and then made one commit that deleted the entire old directory (https://github.com/apache/beam/pull/11554/commits/ee581993c039da3dfbb13b94180956f932ee8498). This means that changes that are effectively just file renames (like all of the blog posts) are not tracked as such, so it looks like a bunch of files were deleted and then re-created - which makes it really hard to review the change.
I think if you just squash all of your commits into one, then git should recognize the files are basically the same, and mark them as renames. More details here: https://stackoverflow.com/questions/433111/how-to-make-git-mark-a-deleted-and-a-new-file-as-a-file-move

retest this please

retest this please

I am not famliar with the staging functionality, so I'm not sure what those errors could be from...

staged site: http://apache-beam-website-pull-requests.storage.googleapis.com/11554/index.html

@bntnam Do we have a JIRA issue for this PR where we can refer to for background and context information ?

@bntnam Do we have a JIRA issue for this PR where we can refer to for background and context information ?

@manuzhang : Hey hey, here you have it. [1]
[1] https://issues.apache.org/jira/browse/BEAM-9876

retest this please

retest this please

retest this please

retest this please

retest this please

We need to stop re-testing this. Its creating a bunch of files owned by root on the workers, so then subsequent runs fail because they don't have permissions to clean it up:
bhulette@apache-beam-jenkins-1:~$ ll /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Website_Stage_GCS_Commit/src/website/www/node_modules | head
total 528
drwxr-xr-x 122 root    root     4096 Apr 28 20:02 ./
drwxrwxr-x   4 jenkins jenkins  4096 Apr 29 09:51 ../
drwxr-xr-x   2 root    root     4096 Apr 28 20:02 ansi-regex/
drwxr-xr-x   2 root    root     4096 Apr 28 20:02 ansi-styles/
drwxr-xr-x   2 root    root     4096 Apr 28 20:02 anymatch/
drwxr-xr-x   3 root    root     4096 Apr 28 20:02 argparse/
drwxr-xr-x   2 root    root     4096 Apr 28 20:02 array-union/
drwxr-xr-x   6 root    root     4096 Apr 28 20:02 autoprefixer/
drwxr-xr-x   2 root    root     4096 Apr 28 20:02 balanced-match/

It's causing the precommit to fail for other PRs too

Ok I removed beam_PreCommit_Website_Commit/src/website/www and beam_PreCommit_Website_Stage_GCS_Commit/src/website/www on apache-beam-jenkins-{1..15} . Hopefully that will unbreak those jobs. We need to figure out why this change is causing jenkins to create files owned by root though, any ideas?

restest this please

retest this please

okay, @bntnam we should not fail Website Precommit tests when some links are broken. This is consistent with previous policy, where we didn't fail on broken tests.

retest this please

retest this please

retest this please

retest this please

retest

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

Run Website PreCommit

Run Website_Stage_GSC PreCommit

retest this please

retest this please

Run Website_Stage_GCS PreCommit

retest this please

retest this please

retest this please

retest this please

Webiste stage https://builds.apache.org/view/PreCommit Builds/job/beam_PreCommit_Website_Stage_GCS_Commit/3498/

Run Java PreCommit

Run Java PreCommit

Another pair of eyes on website/build.gradle and the shell scripts would be useful too

I reviewed these files as well.

cc: @TheNeuralBit @aaltay
Adapted to reviews [1]
[1] https://github.com/apache/beam/pull/11554/commits/ba8b982110a034386641454725b85980a740c559

Last set of changes LGTM. Please ping us when you update with the next commit after running the diff script.

retest this please

retest this please

retest this please

retest this please

Run Python PreCommit

Run Python PreCommit

@bntnam - what is the state of this now? There are a few new commits, what should we be reviewing? Were you able to run the diff script?

@aaltay: Thanks for asking. I've been working on it. I pushed a few new commits to test them on the staged version. I'll let you know when I'm done. 🙂

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

Run Python PreCommit

Run Java PreCommit

retest this please

retest this please

Run Java PreCommit

retest this please

retest this please

retest this please

Run Python2_PVR_Flink PreCommit

Run Python2_PVR_Flink PreCommit

Before merging, please share a link to the archived copy of the old website.

Here's a zipfile with the staged website: https://drive.google.com/file/d/1LKL936tBJ79jpjvlL5vC5uYYwTHsWXiJ/view?usp=sharing
This comes from staging PR 11705 (any recent PR without website changes would work).

I'd think it's worth adding a tag to the commit, marking it as the first commit with hugo-based website.

(a committer can add this after merging)

I've tagged the commit 1d2700818474c008eaa324ac1b5c49c9d2857298 with the website-to-hugo tag.
fyi @aijamalnk @bntnam et al


Item 67 in the concept list

I'm looking through the concept list now to add it to the Concepticon and it seems like item 67 should be 'venir' meaning 'come' in English. The concept 'venir' is also mentioned in the study but I don't have the original data to check it.

Solved the issue by adding the DATA_IN_SOURCE column with the concepts from the digitized Lexibank list (the column SPANISH contains the glosses from the original data).


Update README.md

Fixed a small typo.

Ha! I remember seeing this but forgot to fix it clearly. Thank you!


New behavior of nmstatectl service breaks backwards compatibility

Describe the bug
As of the merge of  https://github.com/nmstate/nmstate/commit/dbb98e1d30c727b5e47ea7daacc8f2936ab5a0e0 the behavior of nmstatectl service is to store a checksum of the applied configs and not reapply configs that have previously been applied.
This is a breaking change as you can no longer evaluate the contents of the .applied file to determine what the current running state should be. The semantics of the behavior of the command have fundamentally changed as well as the contents/format of the files involved in the service. This should not have happened in a patch release (behavior is changed between 2.2.21 and 2.2.22), typically a change of this nature would be implemented in a manner that preserves backwards compatibility and would be in a minor release and removal of backwards compatibility would be noted as a coming deprecation/breaking change to be subsequently included in a major release.
Nmstate version

Version 2.2.23

NetworkManager version

Version 1.44.0

Platform

Platform: rhel 9.3

How reproducible

100%

Steps to Reproduce

create a file /etc/nmstate/somechanges.yml with some changes to be made
run sudo nmstatectl service
observe that:

/etc/nmstate/somechanges.yml is still present unlike in previous versions
/etc/nmstate/somechanges.applied file contains a sha256 digest instead of being a full copy of the applied change as in previous versions

any software integration that depended on the previous documented behavior is now broken in unanticipated ways

Additional context
The motivation for the change is documented as At some envs like openshift machine-config-operator moving configuration files can break in place upgrades which acknowledges that the existing behavior exists and the change fundamentally changes how this command behaves. It is inappropriate and unexpected that a downstream consumer of the nmstate failing to work correctly within the documented behavior of the software would be enough to motivate a breaking change in a patch release that is subsequently pushed out to a stable release of an enterprise OS distribution. @qinqon as an employee of Redhat  I'm surprised to see that you signed off on this change
Also, it should be noted that the accepted change does not include any update to the manpage for nmstatectl which still says:
       service
              Apply all network state files ending with .yml in specified( default: /etc/nmstate) folder.   The  applied  network
              state file will be renamed with postfix .applied to prevent repeated applied on next run.

and the changelog  fails to not that any breaking changes were included in the release instead declaring the changed behavior as a "bugfix" even though the original behavior was documented and behaved exactly as documented. Typically a "bug" is a behavior that varies from the expected and documented behavior.

I guess I can introduce a config in /etc/nmstate/nmstate.conf to use this new hash method:
[service]
remove_applied_yaml = false

Then by default, we still remove the applied YAML file and openshift machine-config-operator could use above config file.
@qinqon It that OK to you?

@drawks Are you seeking nmstate next release to change back to old behavior or expecting us to change the CHANGLOG.md and manpage?

I guess I can introduce a config in /etc/nmstate/nmstate.conf to use this new hash method:
[service]
remove_applied_yaml = false

Then by default, we still remove the applied YAML file and openshift machine-config-operator could use above config file.
@qinqon Is that OK to you?

Yes, the new behavior should be configurable and it should not be the default behavior.

@drawks we missed to document the change, although the .applied files were an implementation detail to prevent re-apply more than an nmtate interface.

I disagree, it was a documented behavior. As was the fact that all *.yml files in the directory would be applied. With the new change the very basis of the utility of the tool has changed. Let me do a better job of enumarating the problems:

one can no longer be assured that dropping a .yml in the directory and re-running nmstatectl service will apply the file
the contents of the .applied file can no longer be examined to see what state was being declared at the time of the last run
Since all the *.yml' files in the directory will be applied except for those with a .appliedfile that have a matching hash, there is no longer any guarantee that on a given run the files will be additively applied to arrive at a final declared state. e.g. if I have01-rename-interfaces.yml, 02-assemble-mlag-bonds.yml, 03-apply-policy-based-routing.yml` a change made to any of the config files will no longer have been guaranteed to have been applied before subsequent configs are re-applied.

There are other mechanism to check if the state was applied, like checking the nmstatectl show or if the nmstate.service unit was successful, but we are ok going back to old behaviour controller by a flag.

Yes, there are many ways to achieve various outcomes, but.... the existing documented behavior is depended upon for integration by myself and presumably others. Changing it in the manner it was changed is a breaking change to the documented and expected behavior.
I'm not saying that the behavior should never change or that the needs and intent of the maintainers should not drive development, but what I am saying is that version numbers should be meaningful and that existing documented behaviors/interfaces should not have changes of this nature made without relaying the change to the end users using the tools of documentation, version numbering, etc.

@drawks we missed to document the change, although the .applied files were an implementation detail to prevent re-apply more than an nmtate interface.

I disagree, it was a documented behavior. As was the fact that all *.yml files in the directory would be applied. With the new change the very basis of the utility of the tool has changed. Let me do a better job of enumarating the problems:

one can no longer be assured that dropping a .yml in the directory and re-running nmstatectl service will apply the file
the contents of the .applied file can no longer be examined to see what state was being declared at the time of the last run
Since all the *.yml' files in the directory will be applied except for those with a .appliedfile that have a matching hash, there is no longer any guarantee that on a given run the files will be additively applied to arrive at a final declared state. e.g. if I have01-rename-interfaces.yml, 02-assemble-mlag-bonds.yml, 03-apply-policy-based-routing.yml` a change made to any of the config files will no longer have been guaranteed to have been applied before subsequent configs are re-applied.

There are other mechanism to check if the state was applied, like checking the nmstatectl show or if the nmstate.service unit was successful, but we are ok going back to old behaviour controller by a flag.

Yes, there are many ways to achieve various outcomes, but.... the existing documented behavior is depended upon for integration by myself and presumably others. Changing it in the manner it was changed is a breaking change to the documented and expected behavior.
I'm not saying that the behavior should never change or that the needs and intent of the maintainers should not drive development, but what I am saying is that version numbers should be meaningful and that existing documented behaviors/interfaces should not have changes of this nature made without relaying the change to the end users using the tools of documentation, version numbering, etc.

Right, we will be more careful next time, thanks for reporting.

@drawks Are you seeking nmstate next release to change back to old behavior or expecting us to change the CHANGLOG.md and manpage?

Ideally the new behavior would be something that the user could opt into, the documentation would accurately describe both behaviors and if it is intended that the new behavior is going to be the default behavior at some future release there should be some form of deprecation warning in the docs and/or at runtime.

What's the reason to use a checksum in the first place? To me it seems that copying the file to $file.applied suffices, since then the original and the applied file can just be compared. This seems to reduce the dependencies, amount of code and also retains the ability to inspect what was applied. It will also be more matching a remove_applied_state configuration option because the change introduces two changes while the configuration option only mentions one change.

Also, the new dependency is a crypto library, so it is more likely to be subject to CVEs, therefore avoiding it has also most likely stronger benefits of not having to check for CVE issues because of it in the future.

@drawks Are you seeking nmstate next release to change back to old behavior or expecting us to change the CHANGLOG.md and manpage?

Ideally the new behavior would be something that the user could opt into, the documentation would accurately describe both behaviors and if it is intended that the new behavior is going to be the default behavior at some future release there should be some form of deprecation warning in the docs and/or at runtime.

Sure. I will work on PR for this opt-in.

Also, the new dependency is a crypto library, so it is more likely to be subject to CVEs, therefore avoiding it has also most likely stronger benefits of not having to check for CVE issues because of it in the future.

What's the reason to use a checksum in the first place? To me it seems that copying the file to $file.applied suffices, since then the original and the applied file can just be compared. This seems to reduce the dependencies, amount of code and also retains the ability to inspect what was applied. It will also be more matching a remove_applied_state configuration option because the change introduces two changes while the configuration option only mentions one change.

I think we are ok if we copy the file, the extra storage is not a big deal, also it means we are kind of retrocopatible with previous behaviour.
@drawks are you ok if just copy verbatim the .yml to .applied ? this way you can keep checking it as before, and also the original file is not changed.

I have also create PR https://github.com/nmstate/nmstate/pull/2546 which allow user to opt-in the new behavior, but still by default delete/rename applied state files.

I have also create PR #2546 which allow user to opt-in the new behavior, but still by default delete/rename applied state files.

I have added a comment to the discussion of your MR along with a specific example of a use case where the 2.2.21 behavior could be used in accordance with the documented behavior and a changed behavior would lead to negative outcomes.
https://github.com/nmstate/nmstate/pull/2546#issuecomment-1932515525
I very much appreciate the attention that is being given to this issue, but my primary concern is to not introduce ANY change that breaks the interface of the 2.2.21 release.
This software does have a 3 part version number which generally implies some amount of semantic versioning:

MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backward compatible manner
PATCH version when you make backward compatible bug fixes

introducing new non-breaking changes should happen in minor releases and breaking changes should happen in major releases

I have also create PR #2546 which allow user to opt-in the new behavior, but still by default delete/rename applied state files.

I have added a comment to the discussion of your MR along with a specific example of a use case where the 2.2.21 behavior could be used in accordance with the documented behavior and a changed behavior would lead to negative outcomes.
#2546 (comment)
I very much appreciate the attention that is being given to this issue, but my primary concern is to not introduce ANY change that breaks the interface of the 2.2.21 release.
This software does have a 3 part version number which generally implies some amount of semantic versioning:
1. MAJOR version when you make incompatible API changes

2. MINOR version when you add functionality in a backward compatible manner

3. PATCH version when you make backward compatible bug fixes

introducing new non-breaking changes should happen in minor releases and breaking changes should happen in major releases

With nmstate aimed to satisfy enterprise needs, following semantic versioning spec is essential.
From semver:

Bug fixes not affecting the API increment the patch version, backward compatible API additions/changes increment the minor version, and backward incompatible API changes increment the major version.

The next point release should revert this breaking change.

I think the point is not about whether @drawks is OK with #2545 , but maintain API stable.
I will rebase my PR #2546 over #2545.

The 2.2.24 release should fixed your problem. Please check again.

The 2.2.24 release should fixed your problem. Please check again.

It doesn't seem to have been released into the rhel 9.3 appstream repo yet for me to redo integration testing

9.3 got the update yesterday(2024 March 03), please check again.

I've tested the most recent RHEL packaged release and agree that this issue seems resolved. Thanks everyone!


Support for transactions, analyzers and views

This PR includes support for transaction and views, also it updates the surf to version 2.1.0. The docs for views and transactions are still missing

Thank you for your great effort!!
Is it ready for a review and merge now?

@fMeow there's still some documentation missing but I can put another PR for it, so yes, I thinks is ready for review


Create Arch AUR package for Ghost Desktop

Any chance you can create a PKGBUILD and publish on the Arch Linux AUR? I'm an Arch user and would love a more official publishing of this program for easy installation on Arch ;)

Hey @InAnimaTe! Thank you so much for your interest in Ghost Desktop - the bad news is that we won't have the resources to accommodate ARCH Linux, given that the few people using Linux on the Desktop are mostly using Ubuntu.
I'm afraid that building the app yourself will be the only option for the foreseeable future - unless we get a lot more of these requests, of course.


Validate build.json against a simple schema

Fixes #14
TODO:

[x] Tests
[x] Check RHEL's package and update .spec file

Wow, this is neat!
A couple of points:

a test would be greatly appreciated
what's the behavior of validate(build_json, JSON_SCHEMA): will it throw an exception if json's not valid? will we be able to figure out easily what's wrong?
luckily it seems that python-jsonschema is in rhel extras; could you please test this works with latest version there?
can you add the dependency to spec also please?

what do other maintainers think?

a test would be greatly appreciated

Right, will add those in the following commit

what's the behavior of validate(build_json, JSON_SCHEMA): will it throw an exception if json's not valid? will we be able to figure out easily what's wrong?

Yes, it will throw smth like:
>>> validate(
...     {"name" : "Eggs", "price" : "Invalid"}, schema
... )
Traceback (most recent call last):
    ...
ValidationError: 'Invalid' is not of type 'number'

I'll see if we can get an actual line:column from the file.

Luckily it seems that python-jsonschema is in rhel extras; could you please test this works with latest version there?

I used the one from pypi, I'll check if it works with the one from rhel and add a spec dependency.

I like it in general!
I wonder whether it would be useful to put the actual validation in its own plugin. That might make the jsonschema dependency easier to manage for some people. It would also make it easier to figure out what went wrong afterwards, once https://github.com/projectatomic/atomic-reactor/issues/425 is solved.

I wonder whether it would be useful to put the actual validation in its own plugin

Agreed, we can split validation in two parts:

Core - e.g. no build triggered if no image_name specified
Plugins - mark plugin as failed if plugin config is missing a key and etc.

This way we can limit this PR to core part

Want to re-base this?

Coverage decreased (-0.04%) to 87.961% when pulling 1eabace6624040ed8ab0c77d90ba14076e2e1893 on vrutkovs:json_validator into 615788aebd577e4301bd5dcbbeaa403729e9a9ce on projectatomic:master.

Coverage decreased (-0.04%) to 87.961% when pulling 1eabace6624040ed8ab0c77d90ba14076e2e1893 on vrutkovs:json_validator into 615788aebd577e4301bd5dcbbeaa403729e9a9ce on projectatomic:master.

Closing, will open a new PR when we're ready to work on this


panic while running job

The error just happened when I checked the URL., I hope the log and the Subfinder version I used can help to solve the problem.
subfinder.zip
$ '/home/user/AppImages/subfinder' -v -r <IP_ADDRESS>,<IP_ADDRESS> -d hashpower.co
===============================================
-=Subfinder v1.1 github.com/subfinder/subfinder
===============================================

Running Source: Ask
Running Source: Archive.is
Running Source: Baidu
Running Source: Bing
Running Source: Censys
Running Source: CertDB
Running Source: CertificateTransparency
Running Source: Certspotter
Running Source: Crt.sh
Running Source: Dnsdb
Running Source: DNSDumpster
Running Source: Dogpile
Running Source: Exalead
Running Source: Findsubdomains
Running Source: Googleter
Running Source: Hackertarget
Running Source: Ipv4Info
Running Source: Netcraft
Running Source: PassiveTotal
Running Source: PTRArchive
Running Source: Riddler
Running Source: Securitytrails
Running Source: SSLCertificates
Running Source: Shodan
Running Source: Sitedossier
Running Source: Threatcrowd
Running Source: ThreatMiner
Running Source: Virustotal
Running Source: WaybackArchive
Running Source: Yahoo

Found Wildcard DNS at hashpower.co
 - <IP_ADDRESS>
Running enumeration on hashpower.co

archiveis: Get http://archive.is/*.hashpower.co: dial tcp: lookup archive.is: Temporary failure in name resolution

[DNSDB] www.hashpower.co
riddler: failed to get authentication token

[SECURITYTRAILS] www.hashpower.co
[WAYBACKARCHIVE] hashpower.co
[HACKERTARGET] hashpower.co2018/07/02 19:20:16 panic while running job: runtime error: invalid memory address or nil pointer dereference
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: interface conversion: interface {} is runtime.errorString, not string
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x6bdc30]

goroutine 39 [running]:
github.com/subfinder/subfinder/libsubfinder/helper.(*Pool).subworker.func1(0xc4202c4190)
	/home/user/go/src/github.com/subfinder/subfinder/libsubfinder/helper/pool.go:61 +0x163
panic(0x7148a0, 0x92a970)
	/usr/lib/go/src/runtime/panic.go:502 +0x229
github.com/subfinder/subfinder/libsubfinder/sources/sslcertificates.Query(0xc4201c01a0, 0x2, 0x2, 0x6a6601, 0x940101)
	/home/user/go/src/github.com/subfinder/subfinder/libsubfinder/sources/sslcertificates/sslcertificates.go:35 +0xf0
github.com/subfinder/subfinder/libsubfinder/helper.(*Pool).subworker(0xc4201ee000, 0xc4202c4190)
	/home/user/go/src/github.com/subfinder/subfinder/libsubfinder/helper/pool.go:64 +0x6e
github.com/subfinder/subfinder/libsubfinder/helper.(*Pool).worker(0xc4201ee000, 0x3)
	/home/user/go/src/github.com/subfinder/subfinder/libsubfinder/helper/pool.go:78 +0xb3
created by github.com/subfinder/subfinder/libsubfinder/helper.(*Pool).Run
	/home/user/go/src/github.com/subfinder/subfinder/libsubfinder/helper/pool.go:181 +0x7f
[user@0 ~]$

$ git clone https://github.com/Ice3man543/subfinder.git
Klone nach 'subfinder' ...
remote: Counting objects: 2379, done.
remote: Compressing objects: 100% (51/51), done.
remote: Total 2379 (delta 39), reused 77 (delta 30), pack-reused 2279
Empfange Objekte: 100% (2379/2379), 471.49 KiB | 237.00 KiB/s, Fertig.
Löse Unterschiede auf: 100% (1198/1198), Fertig.
[user@0 ~]$ cd subfinder
[user@0 subfinder]$ go get -u github.com/Ice3man543/subfinder
# cd /home/user/go/src/github.com/subfinder/xurls; git pull --ff-only
warning: keine gemeinsamen Commits
Von https://github.com/subfinder/xurls
 + 20b927f...90a0f32 master     -> origin/master  (Aktualisierung erzwungen)
fatal: Verweigere den Merge von nicht zusammenhängenden Historien.
package github.com/subfinder/xurls: exit status 128

Remove your SubFinder directory completely from the gopath and then try again.
If your gopath is '/root/go/' then do rm -rf /root/go/src/subfinder

Hi @Ice3man543,
There is an issue with updating the project using go get -u github.com/subfinder/subfinder
go get -u github.com/subfinder/subfinder
# cd /Users/tech/Documents/go/src/github.com/subfinder/xurls; git pull --ff-only
fatal: refusing to merge unrelated histories
package github.com/subfinder/xurls: exit status 128

rm -rf /root/go/src/subfinder then go get github.com/subfinder/subfinder worked for me.

@Mzack9999 I think this happened when we moved your XURLS fork to be a standardised project. Any ideas?
From what I can see the solution is going to be to remove that directory and re-create it as above, can't see anything else.
Perhaps we should put an update.sh script in the main repo to handle this exception (with a prompt) but also to help with the number of  go get -u dm's / questions that come with a go project?

Can confirm this is happening to me as well on a wildcard domain, throwing panic. Removing completely and re-getting doesn't fix it

I have no idea what is causing that trouble. Most likely explanation is that changing xurls broke things somehow?

No idea either; this is what panicking on me: subfinder -nW -o test.out -d tesla.services

@eur0pa reinstall the tool and then try?

As I said, rm -rf + go get doesn't fix it

@eur0pa I'm assuming you're working outside of your gopath? If so, removing the main directory is just removing this branch, not the dependencies. You need to remove the path in your gopath, and then do a fresh go get.
We're working on a more permanent solution now. We have test cases / reviewed pull requests in place to prevent this, but this was a change to an outside dependency, and we're going to fix it in a way that it can't happen again.

No, I removed ~/go/src entirely

I'll ping you on slack - more information will be useful for us since half the team is travelling at the moment.

It's a problem with the shitty ssl certificate subdomains extraction code I wrote. Removing it will solve the issue.
@eur0pa try without sslcertificate

This issue has been fixed in v1.1.3
@ZeroDot1 @eur0pa  🙏 Please let us know if you have any further problems.

@picatz Sorry for answering so late, it works.
[user@0 ~]$ git clone https://github.com/Ice3man543/subfinder.git
Klone nach 'subfinder' ...
remote: Counting objects: 2409, done.
remote: Compressing objects: 100% (72/72), done.
remote: Total 2409 (delta 50), reused 101 (delta 38), pack-reused 2279
Empfange Objekte: 100% (2409/2409), 475.94 KiB | 219.00 KiB/s, Fertig.
Löse Unterschiede auf: 100% (1209/1209), Fertig.
[user@0 ~]$ cd subfinder
[user@0 subfinder]$ go get -u github.com/Ice3man543/subfinder
[user@0 subfinder]$ '/home/user/AppImages/subfinder' -v -r <IP_ADDRESS>,<IP_ADDRESS> -d hashpower.co
===============================================
-=Subfinder v1.1.3 github.com/subfinder/subfinder
===============================================

Running Source: Ask
Running Source: Archive.is
Running Source: Baidu
Running Source: Bing
Running Source: Censys
Running Source: CertDB
Running Source: CertificateTransparency
Running Source: Certspotter
Running Source: Crt.sh
Running Source: Dnsdb
Running Source: DNSDumpster
Running Source: Dogpile
Running Source: Exalead
Running Source: Findsubdomains
Running Source: Googleter
Running Source: Hackertarget
Running Source: Ipv4Info
Running Source: Netcraft
Running Source: PassiveTotal
Running Source: PTRArchive
Running Source: Securitytrails
Running Source: Shodan
Running Source: Sitedossier
Running Source: Threatcrowd
Running Source: ThreatMiner
Running Source: Virustotal
Running Source: WaybackArchive
Running Source: Yahoo

Found Wildcard DNS at hashpower.co
 - <IP_ADDRESS>
Running enumeration on hashpower.co

[DNSDB] www.hashpower.co
[WAYBACKARCHIVE] hashpower.co
[VIRUSTOTAL] www.hashpower.co
[FINDSUBDOMAINS] hashpower.co
[SECURITYTRAILS] www.hashpower.co
[HACKERTARGET] hashpower.co
archiveis: Get http://archive.is/*.hashpower.co: dial tcp: lookup archive.is: Temporary failure in name resolution

[Ipv4Info] .hashpower.co
[PASSIVETOTAL] ftp.hashpower.co
[PASSIVETOTAL] mail.hashpower.co
[PASSIVETOTAL] smtp.hashpower.co
[PASSIVETOTAL] www.hashpower.co
baidu: net/http: request canceled (Client.Timeout exceeded while reading body)

Total 5 Unique subdomains found for hashpower.co

.hashpower.co
ftp.hashpower.co
mail.hashpower.co
smtp.hashpower.co
www.hashpower.co

[user@0 subfinder]$


How to get the actual duration of the job，the appLaunchedTime have value while the job is still in waiting.

Organization Name: Advantech

Short summary about the issue/question: We want to calculate the actual duration time of a job, from the start of the job to the end of the job. We need to exclude the waiting time. At first we use the createdTime, and later we changed to use the appLaunchedTime. But when the job is still in waiting status, the appLaunchedTime appears.
Brief what process you are following:

How to reproduce it:

OpenPAI Environment: Cluster

OpenPAI version: 0.10.1
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Hardware (e.g. core number, memory size, storage size, GPU type etc.):
Others:

Anything else we need to know:

@yqwang-ms rest-server retrieve the status and appLaunchedTime from launcher, can you take a look?

@xianfeng appLaunched just means the app is launched, but it may still wait for resources to really run.
We have not yet record the start timestamp for running state, we may support it in future.
Sorry for this inconvenience.

@hellocandy Your feature request is just supported in frameworkcontroller (so will be supported in Pure K8S PAI soon).
For more details, please check:
https://github.com/microsoft/frameworkcontroller/pull/35
For a job attempt:
WaitingTime = RunTime - StartTime
RunningTime = CompletionTime - WaitingTime
For the whole job which may have multiple attempts:
WaitingTime = Sum_all_attempts (RunTime - StartTime)
RunningTime = Sum_all_attempts (CompletionTime - WaitingTime)

@abuccts Could you please help to expose the RunTime field through PAI RestServer (and WebPortal)?


Translate docs

[refs #627]

@quartzmo This looks good! Do you have the docs built on your github account?

@blowmage Demo docs are allmost there!

@blowmage https://quartzmo.github.io/gcloud-ruby/#/docs/master/gcloud/translate (still with the dark theme.)
I just noticed code object links in the guide are not working, looking into that now. Please hold off on merging.

The docs look fantastic.

Great job as always!


Add nbgrader as a default package in the cluster

hey @ryanlovett can we add nbgrader to the docker image for the cluster? That way connector instructors can use the connectortools module on datahub.

also note that this should should be whatever is in the latest master, not necessarily on pip, depending on when that was last updated

for now I added a pip install to the index.ipynb notebook, which should work OK

Regarding:

also note that this should should be whatever is in the latest master, not necessarily on pip, depending on when that was last updated

Would it be sufficient for us to use nbgrader's latest commit hash? We want to avoid underspecifying versions since that isn't reproducible.

actually I just tried pip-installing and that worked fine, so that works

I'll close this for now, since most instructors should be able to figure it out from the index.ipynb notebook...but LMK when you're able to get nbgrader on the cluster so I can remove that code

https://github.com/data-8/jupyterhub-k8s/commit/48034b24990402f20f47534f8019202291643c4a
Will post when it is pushed to cluster.

+1


Allow automating enchanting guide placement/removal

Describe the your request
As far as I can tell, there's no way to automatically add or remove an enchanting guide from a blaze burner, since deployers are unable to shift right click.
I wanted to make a system that would swap guides in and out of burners but without the ability to do that I will need to have a separate one for every single type and level of enchantment.

I'm pretty sure that isn't mentioned in the ponder right? I never tried that because I only had 1 guide and the ponder never mentioned it.


The package has been removed from packagist.org?

I got the following error when trying to install
[InvalidArgumentException]
  Could not find a matching version of package zakriyarahman/laravel-mysql-optimize. Check the package spelling, your version constraint and that the package is available in a stability which matches your min
  imum-stability (stable).

Any chance to make this package work again, and with Laravel 9?

+1

Hi @dgillier @colivinggit @madurapa I apologize for not noticing this issue. I'll work on this and get this updated by next week. I'm also open to anyone to contributing

Thanks !
When do you think you can do it ?

@dgillier I'm expecting sometime around this week or next


RESP and py27

Description
Aha! Once again, I'm not crazy — the code is. This PR checks RESP better and shows that 27 is a problem. Issue has to to with options processing and resp_a not getting reset to 0.001 in stage2. Looking into it, but at least I know I didn't break it. @alenaizan
Status

[ ] Click when ready for review-and-merge

Codecov Report

Merging #60 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Ok, this fixes the immediate problem. I suspect it was developed with py36, where dicts are inherently ordered? The sorted incorporates the assumption that lowercase resp_a trumps RESP_A. If instead you're relying on last-in trumps earlier-in, we'll have to revisit.

Well, dropping Py27 support soon. Wouldn't worry about it, is this ready?

For the psi4 plugin, I'll need Asim to answer the question about did I correct it with the right assumption. But current state of this PR is better than master so, sure, RTG. Can always do a follow-up PR.

Good catch @loriab . Never though about it. Is there a better way to guard against this kind of error?

Not that I know if besides always using OrderedDict if you’re going to depend on that behavior. Python used to expose your error pretty quickly but no more.


Repair-AuthorizedKeyPermission breaks public key authentication

I could log in using public key authentication by simply creating the .ssh\authorized_keys file with Notepad++ until I executed the Repair-AuthorizedKeyPermission command. After executing this I could no longer log in using public key authentication and got a password prompt instead.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 337c4ea8-1806-92a3-1501-b3ff5dde37bb
Version Independent ID: c411d389-578d-57c6-cd6e-eaca7f2837db
Content: OpenSSH Server Configuration for Windows
Content Source: WindowsServerDocs/administration/OpenSSH/OpenSSH_KeyManagement.md
GitHub Login: @maertendMSFT

+1 having a lot of issues here... hoping to learn from others. The docs feel out-of-date.


Allow choice of install program

This permits the use of, e.g., ginstall or uu-install.

If I understand the motivation for this change correctly, it's that it moves us towards a makefile that doesn't necessarily have dependencies on an already installed version of coreutils? Very cool idea.
We can ignore the appveyor failure as it's an occasional glitch we've been getting specifically on x86 winGnu with downloading the Mingw toolchain

Thanks!


ofxVicon for VS2012 and oF 0.8.4

Hi Kyle,
I'm trying to get ofxVicon running in Visual Studios 2012 with of 0.8.4
The project is building, but I'm getting a runtime error: "...unable to start correctly (0xc0150002)..."
Also, I manually copied the viconD.dll file over to the bin folder ... on a hunch that's what your commit comment was indicating.
I'd like to use ofxVicon to control a big ole' industrial robot :)
I just need to figure out how to get the solution setup in Visual Studio :'(
-Madeline

i think you might have to copy the dlls to your C:\Windows\System32 folder, not the bin folder.
but it sounds like the problem you're having is a generic linker problem. stack overflow recommends an app called "dependency walker" http://stackoverflow.com/questions/5126105/c-unable-to-start-correctly-0xc0150002
looking forward to what you make with the industrial robot!


Node/sorting algorithms

This node provides a variety of sorting algorithms that can be set via an additional parameter


Merge prTesting_201902110852 branch to master branch

OPS Build status updates of commit 8b2f694:
:clock10: Preparing: average preparing time is 48 sec(s)

OPS Build status updates of commit 8b2f694:
:clock10: Incremental building: average incremental building time is 15 sec(s)

OPS Build status updates of commit 8b2f694:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


More strategic simulations

Instead of completely random Rollout, perhaps we should consider more strategic simulations.
https://github.com/JunTaoLuo/KotlinMCTS/blob/580245510da4964e407110f9e2cfe66f4b04c41b/lib/src/main/kotlin/mcts/StatefulSolver.kt#L89

How would we evaluate the actions? That requires domain knowledge and the MDP may not have a meaningful reward function for non-terminal states.


Add Pacifica 2023 fingerprint

Car
Chrysler Pacifica 2023 Limited
Route
455d4e3be28ed18e|2024-01-07--16-56-32

Added your FW since we're removing CAN fingerprints soon. I checked your dongle with our new fingerprint & car checker bot and it looks good!
1 dongles (1 platforms) do not yet have enough data to be added:
View table

Dongle, platform, VIN
Name from VIN 🆚 CarInfo
Segments
Bad seg tags
Good seg tags

455d4e3be28ed18eCHRYSLER PACIFICA HYBRID 20192C4RC1GGX........
CHRYSLER Pacifica 2023 🆚Chrysler Pacifica Hybrid 2019-23
31 routes, 616 segments
- VIN spotty (info): 1
- all lat active: 39- no input all lat active: 5


[NoSsr] Convert to function component

[x] I have followed (at least) the PR section of the contributing guide.

I have rebased the pull request on the next branch.
I have added a new demo to better illustrate the defer property.
I have updated the source to use my proposed implementation (that fix the defer demo). I have made one change, the hydrationCompleted flag is useless. React is already smart, he doesn't render his children twice.

React is already smart, he doesn't render his children twice

The second setMounted bails out because mounted is already true :)


Guild Sharding

We should support guild sharding, and maybe provide some utility bot stuff for syncing shards.

Added.


Added system resources and component dependencies (components/resources) cards

Added EntityHasResourcesCard to display resources that are part of a system.
Added EntityDependsOnComponentsCard to display components that are dependencies of a component.
Added EntityDependsOnResourcesCard to display resources that are dependencies of a component.
Updated the example app to take advantage of these new components.

I do agree.  Initially, I took the tact that maybe several of these components could rely on a central component, since HasSubcomponents, HasSystems, HasResources and others seem to use almost identical logic.  I encountered some trickiness in implementation however, when starting down the depends on entities version, as the header logic again relies on a default component type, and there's no default for the dependsOn relationship.  As such, I followed the existing style.  I might have a look at it today and see if I can rework this into a single central component, or I could open an issue to refactor?

Yeah, an issue to refactor works for me! :)

Hi @jmgrimes, since you've looked into this a bit, do you think it would be reasonable to aim for a refactor straight away before merging this? These are a couple of components that I expect a fair number of people to pick up quickly, and we'll be creating unnecessary migrations for people if we release this and then refactor immediately after. Then again a migration of "use X instead of X1, X2, and X3" isn't that bad, so would also be up for releasing this if that's where we're headed.

Took a shot at a refactor, using a common 'RelatedEntitiesCard'.  Changeset now reflects these four additional changes.

Added RelatedEntitesCard as a base implementation of displaying entities that are related to another entity.
Refactored HasComponentsCard to use base RelatedEntitiesCard. Card remains backwards compatible.
Refactored HasSubcomponentsCard to use base RelatedEntitiesCard. Card remains backwards compatible.
Refactored HasSystemsCard to use base RelatedEntitiesCard. Card remains backwards compatible.

The cards used in other places across the system haven't changed, nor has how they are used changed; only the backing implementation.

Tugboat has finished building the preview for this pull request!
Link:

https://pr5361-9cd9u55oxlgqtrb9tunlql5l0gb4zrw4.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/608ae787f9542ab7ae30a0ec

Tugboat has finished building the preview for this pull request!
Link:

https://pr5361-9cd9u55oxlgqtrb9tunlql5l0gb4zrw4.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/608ae787f9542ab7ae30a0ec

Did a little more monkeying with this to add type parameterization and type safety between the columns and the asRenderableEntities properties, inspired from the EntityTable implementation.  Also renamed constants to presets, in line with the way EntityTable handles this.
I noticed that the api-docs plugin does some of this as well, but it feels like crossing from that plugin depending on the catalog plugin feels wrong, yet this lower level shared component seems to fit somewhere in the middle of both.  I left it alone for those reasons, but it might be worth a discussion about where this should go to make its features available to the ProvidingComponentsCard and ConsumingComponentsCard in that plugin as well.

Tugboat has finished building the preview for this pull request!
Link:

https://pr5361-9cd9u55oxlgqtrb9tunlql5l0gb4zrw4.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/608ae787f9542ab7ae30a0ec

@Rugvip Any further feedback on this pull request after refactor?

Hey, I'm the support goalie currently - it's on my queue here! :)

You know, way back when we made the relations initially, my gut feeling for how to visualize them in the frontend was not as individual cards, but as a single list grouped by relation and target kind.
Part of

[system icon] system-name-1

Exposes API

[api icon] api-name-1

Has subcomponents

[component icon] component-name-1
[component icon] component-name-2

Depends on

[component icon] component-name-3

But more on an icon list form using features from https://material-ui.com/components/lists/ and maybe something minimal in terms of what data to show per line item. Could even be a hybrid data table form, absolutely, but all collected in one place - and with ONE such card per SOURCE kind, such that it can contain custom logic for what the texts should be for each heading because it will know both the source and the target at that point and can make sense of them.
I'm open to ideas, but I'm overall wondering if a large number of individual cards with tables really scales as well.

Sure.  On the one hand, large numbers of individual cards is a pain, because there's a constant influx of needing to build new ones for each From -> Relationship -> To ultimately.  A higher order card would be nice to encapsulate a lot of this.  On the other, a larger encapsulating card doesn't support as much variance in layouts from the application side.  The smaller components do.
I can take this in either direction.  Would you like me to try and take a step at evolving these to more generally support source entity cards?

I'm tempted to have this merged and then look at something more collected separately. Both have their merits and ultimately the end user chooses which they prefer to use

Happy to take this in either direction.  Let me see if there's any way to make the source entity and relationship be passed in to reduce the number of properties.

I think I'm going to leave it as is for now, with respect to the passing in of parameters to the internal component.  With the refactor done, it can be evolved without impacting the "public" components already provided, as well as the new components this pull request adds.


Website design

Pull Request Template
Description
Added styles for index and packs pages.
Fixes #8
Fixes #9
Type of Change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@jonahlikescookies If you'd like to work on some of these changes feel free to do so.

Ok so I've added the "Enable Notifications" button to the comment success modal, but make sure to check if it needs any styling.

[ ] Adding to the date value for comments being used, the individual comment layout could probably use a refresh. The avatar is too big, it leaves a bunch of space behind and it just doesn't look nice. Here is a little sketch of what I think it could look like.

Due to the size of the section for comments, very little of people’s usernames are shown(only 2 characters in this case).

If we go off of the initial sketch, then we should definitely increase the width available to use. However, that would make the grid layout not fit, as currently, it barely does. Any ideas on how to fix this?

Probably the best solution would be to move the date below the username. There should be enough space next to the avatar.

I've also tried my best to create a mobile layout. I'd say it's pretty usable, but it definitely needs some minor adjustments, the image inside the comment toggle button looks a bit off for example and the pure black background for the comments in mobile layout is not final, I just set a random color as a placeholder.


Navigation of contour array generated with "opencv" is not normal in godot generation

Godot version
4.0-beta7
System information
win10
Issue description

Steps to reproduce
The 11,200 * 5760 image generates a contour shape array. The navigation of the godot generation is too slow. I can only split it into two parts, but many shapes are not cut.
In fact, the structure is very clear. There is a big outline outside and many small outlines inside
I occasionally adjust the size of the contour. Sometimes it is normal, but in most cases, many shapes cannot be cut
Minimal reproduction project

It's pretty evident why such a badly optimized shape would be demanding for navigation. You need to simplify it.
Without a minimal reproduction project we can't profile anything to see if some improvements could be made to the algorithm to increase performance. But even then it won't change that the input data is bad.

It's just that the map is big enough. You can see that the points are not optimized, but they have been optimized. Moreover, the coordinates of the "opencv" basic contour command are very clear and neat

"Optimized" means using simple shapes such as rectangles and ellipses.
Unless you're doing a sand simulation game, you don't need to be able to go in all the tiniest details of the relief.
Also, you don't need to process the whole game pad at once. Or if you do, you need to come up with clever optimizations on your own, this is not what the navigation API is designed for.

Why is it that this emphasis is always so strong that it is not appropriate to move around? What is the engine suitable for? It is only suitable for platform jumping games?

Looking at the pictures, I am thinking your units should only be able to move on the roads themselves, not in "courtyards" of buildings. That's a major optimization here, reducing your problem to just some rectangles.

If only a single polygon hole in the bool operation order is winded in the wrong order all following polygons will fail their bool operations. Also the Clipper lib that does the bool operations for polygons converts all polygon vertex to integers and upscales them for the operation to avoid precision issues and the result gets downscaled again before returned to user. Such a very large polygon map might simply run into the limit. Even if the operation would succeed such a detailed polygon map is basically completely useless for pathfinding performance.


Upload when comma three is on ethernet

currently, high priority files are only uploaded when on wifi.
ethernet can be used on the comma three and high priority files should also uploaded in this case.
fix https://github.com/commaai/openpilot/pull/22188

Thanks for the PR! No need to make an issue if you already have a PR open.


Decide how do we want to handle super-admin.conf kubeconfig

Description of the feature you would like to add / User story
There's a new kubeconfig file at /etc/kubernetes/super-admin.conf starting with Kubernetes 1.29 that's part of system:masters group. The original kubeocnfig at /etc/kubernetes/admin.conf is now bound by RBAC instead of using system:masters group.
We have to figure out how do we want to handle super-admin.conf:

do we want to delete it?
do we want to generate it on our own, but short-lived?

Solution details

TBD

Alternative approaches
TBD

Potentially can go in 1.8.1

We discussed:

deleting super-admin.conf
providing a KubeOne command to generate such a kubeconfig file (using system:masters) but that has limited validity (for a very short time)


Fix broken docker build

Docker build is borked, needs fixing before next release.
https://github.com/inventree/InvenTree/pull/4997#issuecomment-1582513974
### Tasks
- [x] Check previous versions
- [x] https://github.com/inventree/InvenTree/actions/runs/5210537105/jobs/9405692470

@SchrodingersGat I will watch the runs and restart them in the line of PRs

Actually looking at the things you linked: The runs did not fail, they were stopped due to concurrency rules

See:

https://github.com/inventree/InvenTree/actions/runs/5210537105/jobs/9405692470
https://github.com/inventree/InvenTree/actions/runs/5210674654/jobs/9402043420
https://github.com/inventree/InvenTree/actions/runs/5210919131/jobs/9403505957

This seems to be a known issue https://github.com/orgs/community/discussions/8336
@SchrodingersGat should we shut off concurrency-checks for now? I can create a PR for it

@SchrodingersGat it seems like the failed docker builds were just cancelled runs - I have submitted a PR that would remove concurrency:

pro: no failed runs because of cancellation
con: unneeded builds (ie burning energy for nothing)


Release 0.2.0

About

fix: rename function assert -> assert_true
update: README docs

https://hexdocs.pm/simple_assert/0.2.0/SimpleAssert.html


Do not override parameter cache values

In some cases it's needed to access parameter cache values that were set through the UE editor. The default behaviour doesn't allows it.

Hi,
Thanks for the suggestion. I will pass it into our development team to look into it further.

The project I'm working on uses a custom component replication system. And it requires these default values that cannot be acquired without changes proposed in the PR.

Hi,
Thanks for the clarification. I will pass your suggestion on to our development team to look into it further.

Hi. And thanks. Maybe there can be a better solution. So I will be glad to any feedback.


chore(main): release 1.1.1

:robot: I have created a release beep boop
1.1.1 (2023-12-02)
Bug Fixes

finnish spelling fixes (0c3d9da)
finnish spelling fixes, sitemap generation up (#24) (299a0d0)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Hessuew/flamethefreeze/releases/tag/v1.1.1 :sunflower:


[named] flow-typed definitions are not used unless node_modules are ignored

eslint-plugin-import: 7.2.0
I was having the same issue as #708, where modules whose types are defined in a flow-typed definition were throwing false positive import/named errors about not being found.
I realized that adding the following to my .eslintrc solves the problem:
settings:
    import/ignore:
      - node_modules

So, it seems that if node_modules are not ignored, this plugin will look into the node_module for the type definition, and if it doesn't find it, it throws an error.  Ideally, it would also look in flow-typed (using whatever method it's currently using when node_modules are ignored) before reporting the error.

Honestly just ignoring import type ... would be amazing.

Honestly just ignoring import type ... would be amazing.

this would be a great start, I would support this. not sure how to discriminate between flow imports and others, but I think an extra line or two in the checkSpecifiers function in the rule def would accomplish this. just need someone to figure out what the right predicate is to filter them out, apparently the ESTree node type must be the same. would guess there is some extra flag.

btw, adding node_modules to import/ignore means it's just not bothering to parse them at all, which is fine if that works for you but is not really ideal since the non-flow imports (all of them) are also then ignored.

It looks like #988 fixed this for no-extraneous-dependencies, but not named which is what the original issue is referring to. I still get flow related import/named errors in 2.9.0.

It looks like the resolution has been to ignore all import type statements.  Which concerned me at first, until I realized that flow itself will complain if you try to import a type that doesn't exist.  Thanks all! 👍

Thanks a lot for the work here all - this has been causing us some issues. Am I right in thinking this needs a new plugin release (not in 2.11.0)? If so, @benmosher could we plleeeeease get one, even if it's beta? :)


feat:Add pkg limiter

Signed-off-by: iiiceoo<EMAIL_ADDRESS>

CodeFactor — 2 issues found.


Act.to_Kleio() wrongly displays inferred relations

Timelink Python package version: 1.0.5
Python version: 3.10
Operating System: MacOS, devcontainer linux

Description
Acts contain inferred relations, that are added at the end of the translation of the act
and so are exported and "inside" the act. Current Entity.to_kleio() does not displays this
correctly.
Getting and act from the database and displaying it with Act.to_kleio()
What I Did
from timelink.api.models import Act
from sqlalchemy import select, func

stmt = select(Act).where(Act.the_date > '16850800',
                         Act.the_date < '16850900')

print(stmt)
with tlnb.db.session() as session:

    result = session.execute(stmt).scalars().all()
    for row in result:
        print()
        print(row.groupname,row.the_date,row.loc,row.obs)
        print(row.to_kleio())

relations do not appear inside the correct group.
Check:
bap$b1685.3/16850802/type=bap/ref=?/loc=igreja de s. tiago
n$ana/f/id=b1685.3-per1
    rel$function-in-act/n/b1685.3/16850802
    pai$antonio joao/m/id=b1685.3-per1-per2
    rel$function-in-act/pai/b1685.3/16850802
    ls$residencia/montais/16850802
    ls$ec/c/16850802
    mae$maria de oliveira/f/id=b1685.3-per1-per3
    rel$function-in-act/mae/b1685.3/16850802
    ls$ec/c/16850802
    pad$domingos simoes/m/id=b1685.3-per4
    rel$function-in-act/pad/b1685.3/16850802
    ls$residencia/sobral/16850802
    ls$profissao/padre/16850802
    mad$ana velho/f/id=b1685.3-per5
    rel$function-in-act/mad/b1685.3/16850802
    mrmad$nomes desconhecido/m/id=b1685.3-per6
        rel$function-in-act/mrmad/b1685.3/16850802
        ls$profissao/boticario/16850802
        ls$residencia/soure/16850802
rel$parentesco/pai/ana/b1685.3-per1/16850802  <-- this 4 lines should appear  next to the origin
rel$parentesco/mae/ana/b1685.3-per1/16850802
rel$parentesco/marido/maria de oliveira/b1685.3-per1-per3/16850802
rel$parentesco/marido/ana velho/b1685.3-per5/16850802

This is a problem with to_kleio() in Entity.
First the attributes and relations, should be output, then the contained groups which are not attributes
nor relations. Contained groups should be ordered by Order
The best way to handle this is to create a function that maps POM-SOM,
to obtain the Kleio Group from an entity in the database and then use
KGroup.to_kleio(). So other nice functions of KGroup can be used.
Assignees: joaquimrcarvalho
Labels: Bug
Milestone:

This should be fixed in the Kleio translator see https://github.com/time-link/timelink-kleio/issues/29
Nevertheless the POM-SOM mapping idea is good, should be a separate one.


MSWin32/ directory containing binary .dll file

Is the MSWin32/ directory inclusion in git history an accident ?
In particular there's an .exe and a .dll in there.
NOTE that removing them now would still keep them in history..

@ccrook , @palmerj , would you please comment on this ?

@ccrook @palmerj if you're happy to drop, here's a green button to push: #24

here's a green button to push

Nice solution :)

@strk @imincik  I've been on a course all day so not looked at.  However I'm happy to delegate pushing the button back to you as I've not really the time to look at it in detail so will not be adding value by pushing it!  @palmerj is now travelling and on leave...

@palmerj do you confirm it is ok to drop these binary files from repository ?

@strk yes it ok to drop the files.

If we still need windows binaries then someone should follow the standard process and download the source code and build it.


V2: Regl renderer typescript definitions and generator.

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Does your submission pass tests?

Note: please do NOT include build files (those generate by the build-xxx commands) with your PR,

Thank you for your help in advance, much appreciated !

I added a types generator command to npm scripts, it works fairly well and I only modified a couple lines to get some of the regl definitions. Doesn't use js docs since regl-renderer looks to be still in development.

@kenianbei quick question... why opt for the generation of definitions? there won't be many change to the definitions.

Just for convenience in case the code changed. Is it preferable to remove it from scripts and not included the tsconfig?
Also, after trying it out in my project there are still a bunch of "any" types that would be nice to have typed, I think I'll go through and type all the ones the generator missed when I have time this week.

Just for convenience in case the code changed. Is it preferable to remove it from scripts and not included the tsconfig?
Also, after trying it out in my project there are still a bunch of "any" types that would be nice to have typed, I think I'll go through and type all the ones the generator missed when I have time this week.

@kenianbei can you complete the changes? (See above) Also, your branch needs to up to date with the latest from the master branch.

I removed the auto type generation and fixed some types. We will definitely want to revisit this if it is cleaned up and has proper js docs. But for now it probably is good enough for most use cases.

@kenianbei can you spend some time to make the final changes? these changes would be great to have in the next release.

Will try to get time this week to finish. May just remove everything but the main render API for simplicity of maintenance.

Will try to get time this week to finish. May just remove everything but the main render API for simplicity of maintenance.

Super. And thanks beforehand.
FYI, there have been changes… lots… so please sync up with the master branch. 😃

Hey, I think it should be ready now, I tested it with jscad-react. Let me know if there is any other changes to do, I should have time this week if there is.

@hrgdavor can you review these changes for the TS definitions? I believe that you use TS sometimes.

@hrgdavor can you review these changes for the TS definitions? I believe that you use TS sometimes.

@z3dev unfortunately I do not have experience with TS. I am oldschool JS dude 😄
I was curious about a good setup that would wotk with old style js and TS for some transition, and somebody in one of the issues here promissed to share a good TS setup ... but that never happened.
Sorry, I am of no use here.


Random execution error appearing in place of components on localhost

Execution errors appear randomly in place of components when running near.org locally. One example is the "current component" in the "Develop" menu dropdown:

I suspect this is an issue with your local cache. Have you tried recreating node_modules? Are you referencing an older version of nearsocial/vm?


Repeat the previous question and ask him to reconsider answering it again

Sometimes I think his answer is incorrect, and I want to ask him again. Can there be a button to repeat the previous question? For the convenience of me, I don't need to copy the previous question again

For panel chat: you can press "up" to get the same question in the input box and send it again
For inline chat: you can either just resend or "regenerate"


chore(infra.ci.jenkins.io): use user content logo for the custom header

Follow-up of #4273 & https://github.com/jenkins-infra/docker-jenkins-weekly/pull/1379 to avoid logo "flashing"

Change without any particular incidence, self-merging.


Delete README.md

Facebook

You’re receiving notifications because you modified the open/close state.


⚠ Samsung has degraded performance

In 910471c, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2458 ms

Resolved: Samsung performance has improved in 9aa124a.


Consent page: Add fallback to ClientId if ClientName is left empty

The consent page was showing '[blank] is requesting your permission'.
The problem was that in my client configuration I didn't fill in the ClientName, I only filled in the ClientId.
I searched for all usages of the ClientName field, apparently the consent page was the only page where this problem existed. The grants page also uses the ClientName, but already falls back to the ClientId if the name is not filled in, so I applied the same fix for the consent page.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

thanks!


Feature Request: [safe as draft for the bulk calendar entry

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
I would like to be able to use the bulk entry and save it as draft before I upload into the Terrain Calendar, as I would not always be entering all the weekly activites at teh same time
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.  currenlty I have not come up with any alternatives a=other than to add three or four enteries at once and them come back later to add more or the rest.
Additional context
Add any other context or screenshots about the feature request here.  I went to add some term dates and signed out while i confrmed with the scout leader on a joint night, and when I came back all my dates were gone.  Sadly no screen shots available.

Makes sense I am currently rebuilding this screen for version 3 so I will see if I can add some sort of draft feature.

In version 3 we now have a new calendar which saves as you go and allows you to quickly delete / fix any upcoming events. This should solve these sorts of issues for you. Version 3 should be about in the next few weeks.

That sounds awesome thankyou
On Tue, 20 Feb 2024, 20:26 Peter McDonald, @.***> wrote:

In version 3 we now have a new calendar which saves as you go and allows
you to quickly delete / fix any upcoming events. This should solve these
sorts of issues for you. Version 3 should be about in the next few weeks.
—
Reply to this email directly, view it on GitHub
https://github.com/pete-mc/Summit/issues/88#issuecomment-1953800367, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BFLIX5SKW3P5NISGLSH34MDYURT4RAVCNFSM6AAAAABCOBQ6E6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTHAYDAMZWG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

This is fixed in the new V3 version.

Thank Peter
On Thu, 21 Mar 2024, 12:13 Peter McDonald, @.***> wrote:

This is fixed in the new V3 version.
—
Reply to this email directly, view it on GitHub
https://github.com/pete-mc/Summit/issues/88#issuecomment-2011008466, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BFLIX5QJBAUX5MXF5ADCEI3YZIX2BAVCNFSM6AAAAABCOBQ6E6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRGAYDQNBWGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Template vrendering with mustache

First as strings in JS code.
Then, as files imported through require(). See browserify transformers
https://www.npmjs.org/package/brfs
https://www.npmjs.org/browse/keyword/browserify-transform
https://github.com/kurttheviking/blissify
https://github.com/featurist/html2js-browserify
https://github.com/substack/node-browserify/wiki/list-of-transforms
This is the most basic API we want:
// vtreeFromTemplate(context : Object, template : String) -> VTree
Cycle.vtreeFromTemplate({name: name}, '' +
  '
' +
    'Name:' +
    '<input type="text" ev-input="inputText$">' +
    '
' +
    '
{{ name }}
' +
  '
'
);

I don't think we'll do this, at least not in Cycle's core, maybe as a separate library.


Global declaration via polyfill

🚀 Feature Proposal
Provide a global declaration of the Navigation API.
Motivation
When using polyfill, we expect the type declaration to be extended as well.
Example
For example, urlpattern-polyfill includes a global declaration at the entry point.

Ideally the definitely types version would be utilised
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/dom-navigation/index.d.ts
Any differences from it in this implementation should be filed as a bug. I did go to define it as linked cause it made sense, but it would be preferred if @types/dom-navigation was used.
The navigation instance isn't set globally in node, only in a browser, as it expects a window to attach to.
In node it would be expected to use it as a referenced variable, or to first create a window to bind to.

Any differences from it in this implementation should be filed as a bug. I did go to define it as linked cause it made sense, but it would be preferred if @types/dom-navigation was used.

Thanks for letting me know.
I understood that the type definition is out of scope for this project.
The issue is solved and I will close it.


Update howto-vm-sign-in-azure-ad-windows.md

Need a heading to identify as this is a step

@MicrosoftGuyJFlo
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Map-reduce should break down reduce step into manageable chunks

Map-reduce chain steps need split up the work of the reduce step into multiple steps if the chunks are too big.

Fixed in #19


Added Cisco BFD Feature Template

Pull Request summary:
Added Cisco BFD Feature Template
Description of changes:
[Add more in depth analysis of what changed, provide logs, examples of usage]
Checklist:

[x] Make sure to run pre-commit before commiting changes
[x] Make sure all checks have passed
[x] PR description is clear and comprehensive
[x] Mentioned the issue that this PR solves (if applicable)
[x] Make sure you test the changes

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/pull/357


AddRDF form -> Data format 'Autodetect' does not work

Affected version: 2.1.2 but probably the latest as well because I had that error for long time. (since sesame times).
Servlet is not able to identify Turtle format data file if I add RDF using input form. Data format: 'Autodetect' option returns following error:

This looks like the same issue as #647.

Closed because It was repeated #67 .


[WIP] Try turning on off-heap execution in tests to see what breaks

Merged build triggered.

Merged build started.

Test build #44467 has started for PR 9310 at commit 4f2b795.

Test build #44467 has finished for PR 9310 at commit 4f2b795.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44467/
Test PASSed.


'@JsonClassDescription' annotation is not taken into account

@JsonClassDescription supported by jackson-module-jsonSchema? I have tried to generate JSON schema with jackson-module-jsonSchema  2.7.4  However, it ignores @JsonClassDescription annotation

Version 2.7.4 is very old so I would recommend upgrade to a later version, ideally 2.9(.9).
If description is still not included, please file an issue (or change this one) to include reproduction of what you think should happen, ideally in form of failing unit test.

I try with 2.9.9 version and i have the same issue (JsonPropertyDescription annotation is ok but  not JsonClassDescription annotation)
Here is the example
package test;
import com.fasterxml.jackson.annotation.JsonClassDescription;
import com.fasterxml.jackson.annotation.JsonPropertyDescription;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.module.jsonSchema.factories.SchemaFactoryWrapper;
@JsonClassDescription("Description of calss Test")
public class Test {
@JsonPropertyDescription("Description of property name")
private String name;

public Test() {
}

public String getName() {
	return name;
}
public void setName(String name) {
	this.name = name;
}
public static void main(String[] args) throws JsonProcessingException {
	ObjectMapper mapper = new ObjectMapper();
	SchemaFactoryWrapper visitor = new SchemaFactoryWrapper();
	mapper.acceptJsonFormatVisitor(Test.class, visitor);
	com.fasterxml.jackson.module.jsonSchema.JsonSchema jsonSchema = visitor.finalSchema();
	System.out.println(mapper.writerWithDefaultPrettyPrinter().writeValueAsString(jsonSchema));
}

}
output
{
"type" : "object",
"id" : "urn:jsonschema:test:Test",
"properties" : {
"name" : {
"type" : "string",
"description" : "Description of property name"
}
}
}

Sounds like support for class description is missing then (I remember addition of property descriptions).
Contributions welcome!

I checked that code indeed does not fetch this information. It would be available from jackson-databind side using BeanDescription.findClassDescription(), but wiring does not exist.
This is different from description for properties which get access via JsonSchema.enrichWithBeanProperty() (using beanProperty.getMetadata().getDescription()).
So: someone would need to connect the dots. I do not work on this module, but maybe someone else has time and interest.

I decided to use the Swagger annotations instead with:
@ApiModel(
		value = "Party",
		description = "An organization or person")
public class Party {
...
}

Create the Swagger module and add it to config builder:
SwaggerModule swaggerModule = new SwaggerModule();
...
SchemaGeneratorConfigBuilder configBuilder = new SchemaGeneratorConfigBuilder(objectMapper,SchemaVersion.DRAFT_2019_09,OptionPreset.PLAIN_JSON).with(jacksonModule).with(swaggerModule)

I think, as a part of this effort, @JsonPropertyDescription annotation can also be taken into the account.

@JsonPropertyDescription's annotation only works on fields and I think it makes sense to keep it this way. Its probably best to update @JsonClassDescription so that it does actually work as intuitively intended.

Added pr-needed since I won't have any time to work on this. But it seems like a valid idea (within constraints that this module is itself unsupported ... but is released for Jackson 2.x, PRs accepted etc)


[Bug]:  Diagnostics are not meaningful

Description
Consider the attached screen capture where the shown diagnostic contains returnType variable name which is not available in the code. Also the shown diagnostic is not meaningful

Steps to Reproduce
No response
Affected Version(s)
Ballerina 2201.2.0 (Swan Lake Update 2)
Language specification 2022R3
Update Tool 1.3.10

OS, DB, other environment details and versions
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Related https://github.com/ballerina-platform/ballerina-lang/issues/36347

Related #36347

We will address this issue as suggested in https://github.com/ballerina-platform/ballerina-lang/issues/36347#issuecomment-1265107900


Cohesion (artificial XSPH viscosity)

vi = vi + cj(vi - vj)W(xi-xj, h)
Velocity + c * summation of all velocity differences with all of the neighbors * some weight (Poly6 SPH kernel)
C = 217, h = 7 (assuming particles with radius 1)
W(r,h) is Poly6 SPH kernel defined in separate paper
(Milestone 2)

Didn't want to mess with Wayne's code, so I'm writing some starting code here. Will hopefully save us time later.

float getW(d: number){
    var h = 7; // the smoothing distance specified in the paper (assumes particles with radius 1)
    var w = 0; // poly6 smoothing kernel

    if (0 <= d && d <= h) {
        w = 315 / (64 * PI * pow(h, 9);
        w *= pow( pow(h, 2) - pow(d, 2), 3 );
    }
    return w;
}

// The entire cohesion / viscosity term
var c = 217; // based on paper
var velAvg = 0; // weighted average of all the velocity differences

for (neighbor in neighbors){
    var d = distance(agent.position, neighbor.position);
    var w = getW(d);
    velAvg += (agent.velocity - neighbor.velocity) * w;
}
agent.velocity = agent.velocity + c * velAvg;


Docs update

Updated README to reflect corrected instructions
Added class level strings for all sketches
For all sketches except theta and tuple separated the static and non-static function documentations.

Gonna merge to make it easier to look for and fix any remaining issues without using a derivative of a branch.


[QA] When the user gets to the UI after logging in and appears on the sky platform, a strange sound is quickly triggered for a second

Explorer Alpha build version:
[0.3.477-g5ad20358-main]
Issue Description:
When the user gets to the UI after logging in and appears on the sky platform, a strange sound is quickly triggered for a second
Steps to reproduce:

Log in with your wallet
Wait until 100% is reached
Pay attention when getting to the UI

Expected behaviour:
No stranges sounds should be heard when getting to the UI
Current behaviour:
A strange sound is heard when getting to the UI
Reproduction rate:

[ ] < 10%
[ ]  < = 25%
[ ]  50%
[x ]  < = 75%
[ ]  100%

Severity:

[ ] Cosmetic
[x ] Minor
[ ] Medium
[ ] High
[ ] Critical
[ ] Blocker

Priority:

[ ] High
[ ] Medium
[x ] Low

Platforms / OS:

[x ] Windows 11
[ ] Windows 10
[ ] Mac Sonoma
[ ] Mac (specify the version on Additional Notes)

@m3taphysics I could never reproduce it in unity-renderer, just in Alpha. Yesterday I could repro this many times, but I havent found it possible to repro this so far. I will be attaching a video after reproducing it, I will keep trying. It's a short sound effect which shouldn't be triggered which lasts a second once you get to the UI.

Not a bug, unable to repro


Added Objective C adapter class.

This commit includes Objective C support. Use TLImagePickerAdapter for using the library in the Objective-C.

@rizwan95 your solution it works. But I extracted your files and put inside my project. Thankyou I hope you can integrate with all project. Thankyou

@Ihernandezpi I'm glad that it works. @tilltue , can you please merge these changes into the project?

👍 merge PR this branch: https://github.com/tilltue/TLPhotoPicker/tree/objective-c