update all VT client messages to priority 5 done

updates all VT client messages to priority 5 as stated in #378

I don't know why it's failing...

It's failing because the unit tests for the VT client are comparing the whole CAN ID of the expected message to the actual message that gets sent.

Here you can see that it's checking to see that the ID of this message begins with 0x1C, which is priority 7, but now we're sending it with a leading 0x14, which is priority 5. So, in order to get it to pass, you'd need to update the file test\vt_client_tests.cpp to change the expected ID of the failing messages.

You can check the output here to see the exact lines you'll have to modify: 919, 936, 952, 968, 979, and 992.

Thanks

Sorry, I'll do this when I come back from school.

Please check if this is what you wanted.

Good job! It'a almost there I think, only thing still left would be the line:
https://github.com/Open-Agriculture/AgIsoStack-plus-plus/blob/main/isobus%2Finclude%2Fisobus%2Fisobus%2Fisobus_virtual_terminal_client.hpp#L1657
Here again priority is not used anymore, so the std::pair can be removed, and you'd end up with the nested std::vector<std::vector<std::uint8_t>>
Also I saw you managed to squash your commits, nice!

Hey, I don't know why you would want to remove this, because we want the priority to still exist but it just to be set to 5? Anyways, I did this and the it->first and it->second statements stopped working. I tried to fix this but its most likely wrong. Check it out. Thanks!

Hey, I don't know why you would want to remove this, because we want the priority to still exist but it just to be set to 5? Anyways, I did this and the it->first and it->second statements stopped working. I tried to fix this but its most likely wrong. Check it out. Thanks!

Yeah, so basically the  commandQueue was the link between the queue_command function and send_command function. When that link first was created, I thought it could have different priorities, but with the current standard there we're no different priorities for VT commands.
However, that doesn't mean that messages (something different than the VT commands) can't have other priorities, it's just that the commandQueue is only for VT commands and not for messages in general. And since you already changes the send_command to have a fixed priority of 5, I figured we can just remove the priority for the VT commands further up the road, since after that fixed priority, they we're basically unused.
I hope this explanation makes sense to you hahah. I'm not sure about your knowledge of the CAN/J1939/ISO11783 protocols in general, but I understand it could be a bit hard to gasp otherwise.

Thanks again for taking the time to contribute to the project. Don't take the feedback personally, I like to keep the project up to a high standard haha. Your efforts are greatly appreciated!


Instant Answers in Extension

Acceptable criteria:

getting quick answers from the sites you visit with your questions

Challenge:

need to scrap the content and handle all the questions relative questions based on gpt 4.

Platform:
Browser - Extension

You can reference web integration plugin from autogpt.
https://github.com/gravelBridge/AutoGPT-Web-Interaction

it takes 5 days.


Ripple bug in layout 2

The ripple for the next page button has incorrect ripple bounds. The ripple effect is shown for its parent container instead of the small round button

What do you propose as a fix for this?

Here's a screenshot of the bug: http://imgur.com/h0RY2Sy

I think the main issue is that the done icon used in R.layout.intro_layout2 itself is a static graphic.
We can remove the ripple background and replace R.drawable.ic_done_white_24px with a new Drawable to fix this:
intro_layout2.xml (New code for done button)
<ImageButton
    android:layout_width="wrap_content"
    android:layout_height="fill_parent"
    android:id="@+id/done"
    android:layout_gravity="right"
    android:layout_marginRight="16dp"
    android:visibility="gone"
    android:src="@drawable/ic_done_white" />

button_done.xml (API < 21):
<?xml version="1.0" encoding="utf-8"?>
<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
    <item>
        <shape android:shape="oval">
            <size android:height="48dp" android:width="48dp"/>
            <solid android:color="@color/background_color_selector" />
        </shape>
    </item>
    <item android:drawable="@drawable/ic_done_"/>
</layer-list>

R.color.background_color_selector should be a color selector as described here.
button_done.xml (API >= 21):
<?xml version="1.0" encoding="utf-8"?>
<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
    <item>
        <ripple
            android:color="@color/ripple_color">
            <item>
                <shape android:shape="oval">
                    <size android:height="48dp" android:width="48dp"/>
                    <solid android:color="#8A000000" />
                </shape>
            </item>
        </ripple>
    </item>
    <item android:drawable="@drawable/ic_done"/>
</layer-list>

R.drawable.ic_done could be the default done icon using the Vector Assets Generator from Android Studio.
Same goes for back button...
I didn't test this but I hope this approach helps to fix this bug :)

I'm still seeing this bug, any idea when a fix might be released?

f you still have troubles with the ripple background you may take a look at HeinrichReimer/material-intro. It has some other cool improvements too.


Status traffic manager should fail if page is inaccessible

Right now, the status traffic manager is tied to the json endpoint, which fails if the json file that powers the page is degraded. Unfortunately, by only monitoring the json endpoint, we are not failing over if the status page itself is inaccessible. We should create an endpoint that fails if the json is degraded or if the page is degraded.

We should verify the case when both endpoints are unhealthy: make sure that the users still hit one of the degraded pages (probably by performance).

Let's just monitoring the front page, the page that users hit.


tokenize and bpe for src and tgt in DialogRG

Hello! I have two questions regarding the processing of src and tgt files in DialogRG.

For src and tgt, I wonder if your work followed Zhu et. al 2019 to use the PTBTokenizer for tokenization and then applied bpe using the code from subword-nmt? I plan to run bpe like the commands below, but I'm not sure about the num_operations you used.

subword-nmt learn-bpe -s {num_operations} < {train_file} > {codes_file}
subword-nmt apply-bpe -c {codes_file} < {dev_file} > {out_file}
subword-nmt apply-bpe -c {codes_file} < {test_file} > {out_file}

I noticed DialogRG/dataset_utils.py also included a bert_tokenize(tokenizer, src) function. Does it mean we can also use bert_tokenizer instead of bpe on src and tgt files?

Thank you again for your reply to my previous questions!

Hi,
In our scripts, we set BPE num_operation as 10000. We have tried BERT_tokenizer, but we don't observe significant improvements.

Thank you! Is it possible to share the bpe code_files you derived from the DailyDialog train_file? I might be missing something, but my bpe output is still very different from the files you provided after using num_operations=10000.

Sorry for my late reply, I can't find the exact codes file now, you can try this one. Also, please note that we do not apply bpe on AMR concepts follow Zhu et. al 2019.

Thank you! Sorry to bother you again, but looks like I can't open this link, "you can try this one". Any chance you can share it through another platform like google drive?

I have uploaded it to google drive here, please have a try.


Add support for minimum window size

glfw has support for setting the smallest size of a resizable window with glfwSetWindowSizeLimits. This would add support for this function.

[ ] Add window configuration option for minimum/maximum size
[ ] Add method on window struct for setting the minimum/maximum size after window creation

Adding the maximum size could be an easy addition as well.

Adding the maximum size could be an easy addition as well.

I updated the acceptance criteria to include maximums, may as well include it as it's essentially free! Thanks

Adding the maximum size could be an easy addition as well.

I updated the acceptance criteria to include maximums, may as well include it as it's essentially free! Thanks

Yep, same func for both in go-gl/glfw so may as well stick with that https://github.com/go-gl/glfw/blob/037f3cc74f2ab0b249928c4fc4b61e0f13befdb8/v3.3/glfw/window.go#L486C18-L486C31
Are you thinking we add something like BoundLimits pixel.Rect to WindowConfig as well?

I'm new to pixel but I don't understand why WindowConfig.Bounds is a rect instead of only the width and height. And if you had this WindowConfig could have a MinSize and MaxSize which are also vecs.

I'm new to pixel but I don't understand why WindowConfig.Bounds is a rect instead of only the width and height. And if you had this WindowConfig could have a MinSize and MaxSize which are also vecs.

You know.... that's a great point. At a glance window really only uses the bounds rect for width and height anyway.

Yeah +1 for using the unused x,y components for the min size!

I would do it separately. Because you have, min, max and default/initial.

I would do it separately. Because you have, min, max and default/initial.

Ahh good call

Maybe this should go on the v3 pile with color refactor? Change bounds to vec, and add min/max bound vecs.

Assuming we validate there's no reason to keep bounds as a rect

Assuming we validate there's no reason to keep bounds as a rect

The only thing I could think is we allow setting the initial window position with the x,y of the bounds, but I don't know if there's a use-case for that

There's already a WindowConfig.Pos option... maybe in v3 we combine that into the bounds?

hmmm yeah that could work.
Also realized a useful thing about having a rect for bounds is you get win.Bounds().Center(). Could of course add a win.Center() if we did decide to move to a Vec, but nice to get it free with rect.

Oooo yeah good point....and I think that's why it's a rect! I mean, we could have the config option be a Vec and just convert it to a rect when the window is created


"Enable taskbar styling" turns off each time computer restarts

Hi there,
I bought the app mainly for the transparency feature, however the "Enable taskbar styling" checkbox is always unchecked when my computer turns on. After opening FalconX Settings I can re-check the box, save and close and it works fine, but reverts back to "off" after restarting. Is this a known issue? Please let me know if you need any more information.
Cheers,
Eric

I have submitted version <IP_ADDRESS> to the store. It can arrive within 2 days.
Can you let me know if it's fixed when you get the update?

Hey mate,
It's been working perfectly for the last ~7 days (not sure what's caused it to) but I'll let you know if anything changes in the new update.
Cheers

Thanks :) for letting me know!


Docs: Fix a broken link in 3.6 blog post

It currently links to no-extra-paren, which is a 404. It should link to no-extra-parens instead.

Thanks!


named functions excluded

The plugin seems to exclude all named functions from minified output.
Without minification the named functions exist in the webpack output, but they are no longer there when the plugin is applied.
This is one instance of a function included in myfile.js:
 `function scrollToAnchor(aid) {
        var aTag = $("a[name='" + aid + "']");
       $('html,body').animate({
           scrollTop: aTag.offset().top
       }, 'slow');
   }
 `

On the same file, this showed up correctly on the minified version:
 `$(document).ready(function() {
       $(document).ajaxSend(function() {
            $("#spinner").show();
       });
      $(document).ajaxStop(function() {
            $("#spinner").hide();
      });
    });
 `

webpack.config.js:
 `const MinifyPlugin = require("babel-minify-webpack-plugin");
   .....
   module.exports = {
       ...
        plugins: [
            new MinifyPlugin(),
       ...
 `

babel.rc
 `{
 "presets": [
 ["env",
 {
  "modules": false,
  "useBuiltIns": true,
  "targets": {
    "browsers": ["last 2 versions", "safari >= 7"]
  }
 }],
 "react",
 "es2015"
 ],
 "plugins": [
  "transform-object-rest-spread",
  "transform-react-jsx",
  "transform-runtime"
  ],
"comments": false
  }
 `

Thanks

@BernardA plugin don't do minification directly, we just use babel-preset-minify, please create issue there. Thanks!


Quiet mode

It would be nice to have a command line switch that makes hermit-shell act more like hermit, by not displaying the result of every command run when it executes a script. When hermit runs a script, it only displays the state at the very end, after it runs every command.
Maybe the quiet mode should be on by default in hermit-shell too.
It looks like this is the line where it is being printed. Maybe we should wrap the existing Shell type in a Reader containing these kinds of options.

Well, I figured out a way to do this with zero parameter type classes and I added it to a new branch. None of the things that print stuff out is being imported directly by the hermit-shell executable source. It is being imported by the stuff that is loaded in by hermit-shell. As a result, we can define a type class
class ShellSettings where
  quietMode :: Bool

and use it like this
send :: ShellSettings => Shell a -> IO a
send (Shell g) = do
<...>
         ShellResult gss a
          | quietMode -> return a
          | otherwise -> do
                 sequence_ [ withNoStyle sty txt
                           | gs <- gss
                           , Glyph txt sty <- gs
                           ]
                 putStrLn "\n[Done]\n"
                 return a

The trick is: we don't define an instance in any of the normal source files. Instead, we define it in the .ghci-hermit file depending on whether or not we get the --quiet command line option.
We could add to the ShellSettings type class to have global settings for other things like colorized output as well.
What does everyone think? Ugly hack or a reasonable solution?

At some point, we should add something that tells the server not to try to send anything back at all if quiet mode is enabled.

I'd give that 'reasonable hack' status... seems nice and neat to me, though it means you cannot modify the settings at runtime like you could with state/reader. Is that a problem?
This paper might  even worth reading:
http://dl.acm.org/citation.cfm?id=1017481
I seem to remember it does something similar.

@xich That's the paper I had in mind, ha. At first, I was thinking I would need reflection for it to work at all.
Also actually, I just edited my comment above with regard to that. It depends on where you want to modify it. GHCi lets you redefine instances whenever you want (at any point using the REPL, you can enter instance ShellSettings where quietMode = ...), so we should be able to define a GHCi command to switch it on or off (I'm not sure if you could make a single command that toggles it though).
If we need more than that, we'll probably need reflection using a technique like that paper.

I like that zero-parameter typeclass idea a lot better than my old HERMIT.Debughack. We should probably replace all uses of when debug with ShellSettings.

Is there a use case where we would want to trigger "quiet mode" on/off programmatically instead of interactively, e.g. in a script or test suite?
Also, at what point do we abandon the behemoth that our .ghci file is becoming and write a proper wrapper executable?
This may be a good impetus for doing so, as if we are adding multiple configuration flags we probably want a help flag to explain what they do, right?

@ecaustin I'm not sure if we would want to change it inside a script, but with a test suite we always have control over the arguments we give to the hermit-shell command so that shouldn't be an issue.
The --help flag is already in place and it is separate from the .ghci file things (which reminds me, I should add info to it in this branch).
By a wrapper executable, do you mean something which would send everything we have as .ghci commands to the main hermit-shell program on initialization or something which would intercept all the REPL input, check for special command and then hand it off to the main program?
The second one would probably be pretty tricky because we (I think) need to have a GHCi session continuously running so would might need some interprocess communication. If that's the case, I would also wonder how the Windows compatibility would work out.
 Either way, we should probably change that.

Evan and I discussed this yesterday and I agree with his suggestion of using a global IORef. We will always use this inside IO so we don't need to worry about using tricks to maintain purity.

I'm reopening this for continued discussion because I think there was some confusion about the comments I made.
At no point in time did I endorse the use of unsafePerformIO.
My suggestion was to initialize a reference in the main thread of the program and pass it around either explicitly or implicitly using a monad.
Now that I've seen the changes you've made, I see that we can't do that because the output you want to suppress is triggered by our overloaded GHCI pretty-printer, not a method in our main execution loop.
I agree that the output behavior of the old shell was preferable, so I've removed your changes and redefined printForRepl to use void for Shell commands.  If people want the added output then they can make an explicit call to send and GHCI will handle the rest, provided that the result type has a Show instance.
I've simultaneously switched send to print response glyphs with their attached style, so we should have identical output as the old shell.
Obviously we'll need to regenerate the golden output for tests now.
If we want to make the behavior of printForRepl configurable then I have a few ideas that will keep us away from hacky workarounds, but I think the current comprise is close to, if not exactly, what we want.
By the way, this is in no way an indictment of you or the code you wrote.
I just really, really hate unsafePerformIO.

@ecaustin Haha, that's understandable. I'm not a big fan of unsafePerformIO either (in fact, this is one of the only times I've ever used it). I misunderstood your suggestion.
It looks like it still prints all the output though, currently. Is that the expected behavior for the moment?

Now it's my turn to have misunderstood things.
I thought the goal was to remove the duplicate output from the interactive shell.
If we want to silence the intermediate output from running scripts then we should transmit them in their entirety instead of step by step, such that the client only gets the final result.
I believe this corresponds to @andygill's "deep embedding" version of the remote monad protocol.

@ecaustin Oh, I see. There's been another miscommunication. I was intending quiet mode to be an optional switch to turn off intermediate output from scripts (which is the original HERMIT's default setting).
Also I'm not positive, but I was under the impression that the end goal was to do the deep embedding style thing where we send everything over at the start. @andygill would know for sure.
It seems to me that both modes could be useful: seeing intermediate steps could help with debugging scripts and, on the other hand, you might not want to have to print everything when you know that a transformation is working (or if you only want to take a look at the result of the last step without the overhead of printing every other step).

I think what @ecaustin is getting at is this:

Currently, lines in a script are sent over one-by-one. Hence, you get the resulting AST printed for each intermediate step.

Instead of having a switch to suppress AST printing for certain commands (quiet mode), just send over the entire script at once, so only the final AST is printed.

The 'stopScript' command should control this batching... so:
foo
bar
stopScript
baz

gets sent over as foo ; bar and then the AST resulting after bar is returned.

Yup, @xich nailed it on the head.


k8s after open logrotate, nebula restart failed

Please check the FAQ documentation before raising an issue

Normal   Pulled     25s                kubelet            Successfully pulled image "reg.vesoft-inc.com/cloud-dev/nebula-agent:v3.5.1" in 983.697057ms (983.704709ms including waiting)
  Warning  BackOff    9s (x4 over 39s)   kubelet            Back-off restarting failed container ng-agent in pod nebula-metad-0_nebula(44ed5413-29ea-43b6-b4b0-68d621362689)

the conf：
graphd:
  config:
    "timestamp_in_logfile_name": "true"
metad:
  config:
    "timestamp_in_logfile_name": "true"
storaged:
  config:
    "timestamp_in_logfile_name": "true"
logRotate:
  rotate: 3 #轮询三次就删除；
  size: 3K #达到3k大小就参与轮询；

Your Environments (required)
nebulaOperator:
image: reg.vesoft-inc.com/cloud-dev/nebula-operator:snap-1.2
nebula:
image: reg.vesoft-inc.com/rc/nebula-graphd-ent:v3.5.0-sc
agent:
image: reg.vesoft-inc.com/cloud-dev/nebula-agent:v3.5.1
Expected behavior
start success

https://github.com/vesoft-inc/nebula-operator/pull/227

新的镜像已解决


chore(package): update lodash to version 4.16.5

https://greenkeeper.io/
Not sure why this wasn't automatically merged into master

Coverage remained the same at 100.0% when pulling 6263ee5558793c3ebe1a624a23b58547ccc4f1f7 on greenkeeper-lodash-4.16.5 into 35bd2e1ddbfaa8df653c79b7d4a0327a868fd6f9 on master.

n/m this matches the semver range in package.json. I'm closing this PR.


Start working on supporting update

General question: can I assume that LockService is accessed in a single-threaded way?
If not, there are a handful of possible race conditions in my current implementation that would take time to properly (fix and) test.

General question @nvoxland: can I assume that LockService is accessed in a single-threaded way?
If not, there are a handful of possible race conditions in my current implementation that would take time to properly (fix and) test.

Yes, I think you can assume it's single-threaded. That is almost always the case with liquibase usage, and so probably not worth making sure it's handed correctly right now.
I'm working on a cleanup of the LockService implementation currently in progress (https://github.com/liquibase/liquibase/issues/1453) and I think any multi-threading support should be handled in the base framework vs. having to make you deal with it. I'll make a not in that ticket

@nvoxland is there any plan to switch to Duration type for changeLogLockWaitTime and changeLogLocRecheckTime? This would be easier for tests (currently they are integers in minutes and seconds respectively, which is a bit impractical for tests).

@nvoxland just for fun, I wanted to see if I could leverage ScheduledExecutorService for the waitForLock, I ended up with https://gist.github.com/fbiville/9b75d7cbe264b4f288c8f7c672a07867.
The usage looks like this:
ConditionCheckScheduler scheduledSupplier = new ConditionCheckScheduler(Duration.ofMinutes(this.getChangeLogLockWaitTime()));
        boolean lockAcquired = scheduledSupplier.scheduleCheckWithFixedDelay(
                this::acquireLock,
                isEqual(true),
                false,
                Duration.ofSeconds(this.getChangeLogLockRecheckTime())
        );

        if (!lockAcquired) {
            DatabaseChangeLogLock[] currentLocks = this.listLocks();
            if (currentLocks.length > 0) {
                throw new LockException(String.format(
                        "Could not acquire change log lock. Currently locked by %s",
                        currentLocks[0].getLockedBy()));
            }
            throw new LockException("Could not acquire change log lock despite no lock currently stored");
        }

Let me know if that can be of interest (or if it is too crappy ^^).

@nvoxland I think I will focus this first PR to just the lock service.
If that scope is OK with you, then the PR is ready for review.

I think it all looks good, and just fine to keep this focused on the lock service. Did I give you permission to merge this PR? Or would you like me to.
I've tended to not use Duration as much as I should, that is a good reminder it's out there. It's probably worth looking into in liquibase/liquibase#1541 .

Let me squash the commits into a single one and I'm happy to merge it now that you greenlighted it.


ssd1306 driver should support arbitrary height and width

Currently it's hardcoded to 128x64.

fixed in version 0.4

Fixed w/ https://github.com/androidthings/contrib-drivers/commit/a0092cffc0f41aafe90bab138c83141fb851f05b


[Core-HttpClient-JDK][BUG] Remove Wrapping of UncheckedIOException

fixes: https://github.com/Azure/azure-sdk-for-java/issues/35692

API change check
API changes are not detected in this pull request.

@alzimmermsft @lmolkova I added the test and CHANGELOG. Can I have another review before I merge it?


Add lwe.add, lwe.mul_scalar, and cggi.lut_lincomb

Also make the cggi.lut* syntax more consistent by removing parens from the operands.
This is to prepare for a new optimization pass involving more finely-crafted LUT ops by qu4ternion on Discord

Based on some more conversations I think I will tweak this one a bit more before submitting.

Tweaks done. Now there's a linear combination LUT op with specifiable coefficients. I think we could canonicalize the other two ops in terms of that op easily, and I'll look into that later.

I'll just go ahead and write the verifier now :)

@asraa sorry to keep bothering with updates, but I added the verifier.


[WIP] Uniformize num_dims and add it for LMNN

This solves #167 partially (only gives a num_dims argument to LMNN and ensures that the check is done uniformly between the algorithms)

Note: For LMNN, if we have shogun, it will do a pca if asked so, but I couldn't find how the dimension of pca is chosen... Also, maybe we'll not have to bother as soon as we have solved #124, because maybe we will chose that the 'pca' option triggers a scikit-learn PCA in both shogun/not shogun cases...

Have you checked what is the pca option of Shogun for? It could be simply a preprocessing applied to the dataset, not an initialization. In which case we will set this option to false when solving #125

Have you checked what is the pca option of Shogun for? It could be simply a preprocessing applied to the dataset, not an initialization of the algorithm. In which case we will set this option to false when solving #125

Yes, according to this page: http://shogun.ml/notebook/latest/LMNN.html, (in cell 5), they say PCA is used to find the initial matrix

Have you checked what is the pca option of Shogun for? It could be simply a preprocessing applied to the dataset, not an initialization of the algorithm. In which case we will set this option to false when solving #125

Yes, according to this page: http://shogun.ml/notebook/latest/LMNN.html, (in cell 5), they say PCA is used to find the initial matrix

Indeed. Looking at this, I do not think they reduce the dimension anyway:
https://shogun-list.shogun-toolbox.narkive.com/n6B3o0Mf/shogun-lmnn-pca-error
But I agree it will be safer to perform the PCA initialization ourselves and pass it to Shogun's train's method

Also, I kept the name num_dims for now, but in scikit-learn's NCA we went for n_components, which respects more scikit-learn's conventions. It would be good to change the name wouldn't it ? If so I'll add deprecation warning for it

I agree that n_components would be more intuitive, +1 for changing this before the 0.5.0 release with deprecation warning

I investigated the travis fail and there seems to be an issue with some shapes mismatch for LMNN when doing dimensionality reduction. There seems to be a problem with the gradient: Looking into this line the gradient seems to be of the shape of an outer product of Xs (when it should be of the shape of L):
https://github.com/metric-learn/metric-learn/blob/d4badc8adc0a8ce6689dd9a95e89181efaf5ee24/metric_learn/lmnn.py#L196
Looking at the PR on LMNN in scikit-learn, there might be a dot product with L missing:
https://github.com/scikit-learn/scikit-learn/pull/8602/files#diff2914dd42441ed8b594e69b2fe04d23f5R762
Doing this dot product solves the problem
I'll look into it

I just pushed a commit that warns the user with a ChangedBehaviorWarning when the init is not set, in the cases when the default init is not the same as it was before, let me know what you think, this happens in the following cases:

lsml: it used the inverse covariance by default (instead of identity now)
mmc: it used identity/10 (instead of just identity)
mlkr: it used pca (instead of 'auto')
nca: it used np.eye(X.shape[1])/(np.maximum(X.max(axis=0)-X.min(axis=0), EPS) (instead of 'auto')
sdml: it used the inverse covariance by default (since use_cov was True by default), instead of identity

If you agree with my last modifs (see comment https://github.com/metric-learn/metric-learn/pull/193#pullrequestreview-245994079), we should be ready to merge


bug: errors that have recently been manifesting locally and in a live env

kargo-management-controller-5669885dcd-7kzqp management-controller time="2024-01-23T20:05:10Z" level=info msg="Starting Kargo Management Controller" commit=8b6f58a4ddfc81e004bb782de69a45a575d29a44 version=main
kargo-management-controller-5669885dcd-7kzqp management-controller [controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
kargo-management-controller-5669885dcd-7kzqp management-controller Detected at:
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  goroutine 87 [running]:
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  runtime/debug.Stack()
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  	/usr/local/go/src/runtime/debug/stack.go:24 +0x5e
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.0/pkg/log/log.go:60 +0xcd
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).Error(0xc00047a080, {0x20b7540, 0xc00056e040}, {0x1e05c45, 0x21}, {0x0, 0x0, 0x0})
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.0/pkg/log/deleg.go:139 +0x5d
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  github.com/go-logr/logr.Logger.Error({{0x20d9d20?, 0xc00047a080?}, 0x0?}, {0x20b7540, 0xc00056e040}, {0x1e05c45, 0x21}, {0x0, 0x0, 0x0})
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  	/go/pkg/mod/github.com/go-logr/logr@v1.4.1/logr.go:301 +0xda
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind).Start.func1.1({0x20d49b8?, 0xc00065ec80?})
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.0/pkg/internal/source/kind.go:68 +0x1a9
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  k8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext.func1(0xc000654ee0?, {0x20d49b8?, 0xc00065ec80?})
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  	/go/pkg/mod/k8s.io/apimachinery@v0.29.0/pkg/util/wait/loop.go:53 +0x52
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  k8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext({0x20d49b8, 0xc00065ec80}, {0x20d30d0?, 0xc000654ee0}, 0x1, 0x0, 0x0?)
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  	/go/pkg/mod/k8s.io/apimachinery@v0.29.0/pkg/util/wait/loop.go:54 +0x117
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  k8s.io/apimachinery/pkg/util/wait.PollUntilContextCancel({0x20d49b8, 0xc00065ec80}, 0x0?, 0x0?, 0x0?)
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  	/go/pkg/mod/k8s.io/apimachinery@v0.29.0/pkg/util/wait/poll.go:33 +0x56
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind).Start.func1()
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.0/pkg/internal/source/kind.go:56 +0xee
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  created by sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind).Start in goroutine 82
kargo-management-controller-5669885dcd-7kzqp management-controller 	>  	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.0/pkg/internal/source/kind.go:48 +0x1d8

This may also have been related:
failed to wait for project caches to sync: timed out waiting for cache to be synced for Kind *v1alpha1.Project

I am a bit suspicious of recent controller-runtime  upgrades.

I think it's this:
https://github.com/kubernetes-sigs/controller-runtime/issues/2622

I don't think so. This is about timed out waiting for cache to be synced for Kind *v1alpha1.Project.
I think the log.SetLogger(...) was never called; logs will not be displayed. error is benign, and just indicates we need to set a logger for controller runtime.

I think the log.SetLogger(...) was never called; logs will not be displayed. error is benign, and just indicates we need to set a logger for controller runtime.

This commit should silence the log.SetLogger(...) was never called; logs will not be displayed error.

This was a network policy issue in my environment. Closing.


Release version 1.0.1

Purpose
Release new version.
Changes

Update changelog to reflect the release
Update build scripts to point to the new locations.

Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.

If the objects should be public by default the 3 aws s3 cp commands need to have --grants read=uri=http://acs.amazonaws.com/groups/global/AllUsers appended

Thanks. I have made them public.


Can't return const from factory constructors on widgets when app started directly from IntelliJ.

Steps to Reproduce
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: MyHomePage.create(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key key}) : super(key: key);

  factory MyHomePage.create() => const MyHomePage();

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("🐛"),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.display1,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ),
    );
  }
}

Run the code above from IntelliJ with Run (⌃+R).
Red screen with error is shown instead of the app.

When I run the app from a terminal with the flutter run command everything works normally.
Stacktrace
I/flutter (12403): ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
I/flutter (12403): The following _CompileTimeError was thrown building MyApp(dirty):
I/flutter (12403): 'package:untitled1/main.dart': error: Not a constant expression.
I/flutter (12403):
I/flutter (12403): When the exception was thrown, this was the stack:
I/flutter (12403): #0      MyApp.build (package:untitled1/main.dart:9:24)
I/flutter (12403): #1      StatelessElement.build (package:flutter/src/widgets/framework.dart:3789:28)
I/flutter (12403): #2      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3739:15)
I/flutter (12403): #3      Element.rebuild (package:flutter/src/widgets/framework.dart:3565:5)
I/flutter (12403): #4      ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3722:5)
I/flutter (12403): #5      ComponentElement.mount (package:flutter/src/widgets/framework.dart:3717:5)
I/flutter (12403): #6      Element.inflateWidget (package:flutter/src/widgets/framework.dart:2961:14)
I/flutter (12403): #7      Element.updateChild (package:flutter/src/widgets/framework.dart:2764:12)
I/flutter (12403): #8      RenderObjectToWidgetElement._rebuild (package:flutter/src/widgets/binding.dart:933:16)
I/flutter (12403): #9      RenderObjectToWidgetElement.mount (package:flutter/src/widgets/binding.dart:904:5)
I/flutter (12403): #10     RenderObjectToWidgetAdapter.attachToRenderTree.<anonymous closure> (package:flutter/src/widgets/binding.dart:850:17)
I/flutter (12403): #11     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2258:19)
I/flutter (12403): #12     RenderObjectToWidgetAdapter.attachToRenderTree (package:flutter/src/widgets/binding.dart:849:13)
I/flutter (12403): #13     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.attachRootWidget (package:flutter/src/widgets/binding.dart:736:7)
I/flutter (12403): #14     runApp (package:flutter/src/widgets/binding.dart:780:7)
I/flutter (12403): #15     main (package:untitled1/main.dart:3:16)
I/flutter (12403): #16     _runMainZoned.<anonymous closure>.<anonymous closure> (dart:ui/hooks.dart:199:25)
I/flutter (12403): #21     _runMainZoned.<anonymous closure> (dart:ui/hooks.dart:190:5)
I/flutter (12403): #22     _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:300:19)
I/flutter (12403): #23     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:171:12)
I/flutter (12403): (elided 4 frames from package dart:async)
I/flutter (12403): ════════════════════════════════════════════════════════════════════════════════════════════════════

flutter analyze
No issues found! (ran in 4.7s)

flutter doctor -v
There is an iOS issue but I just tested on Android.
[✓] Flutter (Channel beta, v1.5.4-hotfix.2, on Mac OS X 10.14.4 18E226, locale en-PL)
    • Flutter version 1.5.4-hotfix.2 at /Users/michalsikora/.flutter_sdk/flutter
    • Framework revision 7a4c33425d (3 weeks ago), 2019-04-29 11:05:24 -0700
    • Engine revision 52c7a1e849
    • Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/michalsikora/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/michalsikora/Library/Android/sdk
    • Java binary at: /Users/michalsikora/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/183.5522156/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[!] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.2.1, Build version 10E1001
    ✗ Verify that all connected devices have been paired with this computer in Xcode.
      If all devices have been paired, libimobiledevice and ideviceinstaller may require updating.
      To update with Brew, run:
        brew update
        brew uninstall --ignore-dependencies libimobiledevice
        brew uninstall --ignore-dependencies usbmuxd
        brew install --HEAD usbmuxd
        brew unlink usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
    • ios-deploy 1.9.4
    • CocoaPods version 1.6.1

[✓] Android Studio (version 3.4)
    • Android Studio at /Users/michalsikora/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/183.5522156/Android Studio.app/Contents
    • Flutter plugin version 35.3.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] VS Code (version 1.33.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.0.2

[✓] Connected device (1 available)
    • FRD L09 • 73QDU16B24003748 • android-arm64 • Android 7.0 (API 24)

! Doctor found issues in 1 category.

@MiSikora do you still encounter the issue?

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Fixed issue #181

Description: Fixed issue where tensors in the SSM of the mambablock module were not on the same device.
Issue: #181
Dependencies: None
Tag maintainer<EMAIL_ADDRESS>

@Bool1020 Appreciate you!


Code

Sorry to bother you again. I can't find the  implementation of the GRAM and RRAM is in [roi_attention_head.py] and I don't know how the gram and rram combine together. Is the code complete? I am a little confused. Hope for your answer and forgive my ignorance.

Indeed, the code is incomplete. I have found and uploaded the missing code files from the author's team project. Thank you for discovering this blind spot. Now the code link can be opened successfully.


CI should check that .h and .c files end with newline

Possible solution: https://stackoverflow.com/questions/38746/how-to-detect-file-ends-in-newline

A wholistic solution might be to use a tool like uncrustify to enforce style. It is capable of enforcing new lines at the end of the files as well as much more.
I noticed there is a clang-format file in the repo but it is not enforced and the code is already noncompliant with that style.
I have personally found uncrustify more flexible than clang-format. For example clang-format is not capable of enforcing new lines at the end of the file as far as I can tell.

@ekohandel , would you propose a solution by using uncrustify ?

@jyao1, I have opened #575 but from my experience style is very contentious so we may have to iterate on the configurations of uncrustify before the style is acceptable. Unfortunately uncrustify is an all or none tool so I couldn't pick to only apply some of its configurations.


Change timestamp alias to timestamp without time zone

Summary of the changes / Why this improves CrateDB
Resolves https://github.com/crate/crate/issues/11509
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

I think this can be removed as well:
https://github.com/crate/crate/blob/ffba331c0f012b8143ad233fe2b036938730b889/server/src/main/java/io/crate/analyze/AnalyzedColumnDefinition.java#L276-L282

Good catch, thank you!


Add missing database transaction for new issue

When creating an issue, inserting issue, assign users and set project should be in the same transaction.

I was unable to create a backport for 1.21. @lunny, please send one manually. :tea:
go run ./contrib/backport 29490
...  // fix git conflicts if any
go run ./contrib/backport --continue


clang: Disable reserved-identifer warning

Possible fix for #245.

Instead of putting it in the build setup, I think it would be better to have as a #pragma in rpmalloc.c (there are already a few) in order to make the code self contained.
#pragma clang diagnostic ignored "-Wreserved-identifier"

Makes sense, done. (I saw there was some in both places but I wasn't sure what the rationale for one place or the other was.)

Any reason not to submit this? For the record, this is impacting the GN build tool which links to rpmalloc to significantly speed up its operations (e.g. from 30s to 22s). Unfortunately, we had to disable this due to the issue, see https://gn-review.googlesource.com/c/gn/+/11720).
We can work with a local patch if more changes are necessary in this pull request, but we'd prefer to use upstream directly :-)

I just haven’t had time to verify this myself yet that it doesn’t interfere with builds using older clang versions.

It seems the pragma has to be surrounded with
#if __has_warning("-Wreserved-identifier")
#pragma clang diagnostic ignored "-Wreserved-identifier"
#endif
Or older clang versions will warn about the unknown warning

Thanks for verifying, and providing the necessary fix! I hope Scott can update his pull request (I believe he's on vacation right now). If not, I'd be happy to provide my own PR, but we've finally applied a local patch on our side, so there is no rush.
Thanks again for rpmalloc!

I did the change and merged #249


Bug in converting DIA-NN output

Description of the bug

nf-core/quantms execution completed unsuccessfully!

The exit status of the task that caused the workflow execution to fail was: 1.

The full error message was:

Error executing process > 'NFCORE_QUANTMS:QUANTMS:DIA:DIANNCONVERT (PXD037340-DIA.sdrf)'

Caused by:
  Process `NFCORE_QUANTMS:QUANTMS:DIA:DIANNCONVERT (PXD037340-DIA.sdrf)` terminated with an error exit status (1)

Command executed:

  diann_convert.py convert \
      --folder ./ \
      --diann_version ./version/versions.yml \
      --dia_params "0.02;Da;20;ppm;Trypsin;;" \
      --charge 4 \
      --missed_cleavages 1 \
      --qvalue_threshold 0.01 \
      2>&1 | tee convert_report.log

  cat <<-END_VERSIONS > versions.yml
  "NFCORE_QUANTMS:QUANTMS:DIA:DIANNCONVERT":
      pyopenms: $(pip show pyopenms | grep "Version" | awk -F ': ' '{print $2}')
  END_VERSIONS

Command exit status:
  1

Command output:
  /hps/nobackup/juan/pride/reanalysis/quantms/bin/diann_convert.py:370: PerformanceWarning: DataFrame is highly fragmented.  This is usually the result of calling `frame.insert` many times, which has poor performance.  Consider joining all columns at once using pd.concat(axis=1) instead. To get a de-fragmented frame, use `newframe = frame.copy()`
    out_mztab_MTD.loc[1, "study_variable[" + str(i) + "]-description"] = "no description given"
  /hps/nobackup/juan/pride/reanalysis/quantms/bin/diann_convert.py:369: PerformanceWarning: DataFrame is highly fragmented.  This is usually the result of calling `frame.insert` many times, which has poor performance.  Consider joining all columns at once using pd.concat(axis=1) instead. To get a de-fragmented frame, use `newframe = frame.copy()`
    out_mztab_MTD.loc[1, "study_variable[" + str(i) + "]-assay_refs"] = ",".join(study_variable)
  /hps/nobackup/juan/pride/reanalysis/quantms/bin/diann_convert.py:370: PerformanceWarning: DataFrame is highly fragmented.  This is usually the result of calling `frame.insert` many times, which has poor performance.  Consider joining all columns at once using pd.concat(axis=1) instead. To get a de-fragmented frame, use `newframe = frame.copy()`
    out_mztab_MTD.loc[1, "study_variable[" + str(i) + "]-description"] = "no description given"
  /hps/nobackup/juan/pride/reanalysis/quantms/bin/diann_convert.py:369: PerformanceWarning: DataFrame is highly fragmented.  This is usually the result of calling `frame.insert` many times, which has poor performance.  Consider joining all columns at once using pd.concat(axis=1) instead. To get a de-fragmented frame, use `newframe = frame.copy()`
    out_mztab_MTD.loc[1, "study_variable[" + str(i) + "]-assay_refs"] = ",".join(study_variable)
  /hps/nobackup/juan/pride/reanalysis/quantms/bin/diann_convert.py:370: PerformanceWarning: DataFrame is highly fragmented.  This is usually the result of calling `frame.insert` many times, which has poor performance.  Consider joining all columns at once using pd.concat(axis=1) instead. To get a de-fragmented frame, use `newframe = frame.copy()`
    out_mztab_MTD.loc[1, "study_variable[" + str(i) + "]-description"] = "no description given"
  /hps/nobackup/juan/pride/reanalysis/quantms/bin/diann_convert.py:369: PerformanceWarning: DataFrame is highly fragmented.  This is usually the result of calling `frame.insert` many times, which has poor performance.  Consider joining all columns at once using pd.concat(axis=1) instead. To get a de-fragmented frame, use `newframe = frame.copy()`
    out_mztab_MTD.loc[1, "study_variable[" + str(i) + "]-assay_refs"] = ",".join(study_variable)
  /hps/nobackup/juan/pride/reanalysis/quantms/bin/diann_convert.py:370: PerformanceWarning: DataFrame is highly fragmented.  This is usually the result of calling `frame.insert` many times, which has poor performance.  Consider joining all columns at once using pd.concat(axis=1) instead. To get a de-fragmented frame, use `newframe = frame.copy()`
    out_mztab_MTD.loc[1, "study_variable[" + str(i) + "]-description"] = "no description given"
  /hps/nobackup/juan/pride/reanalysis/quantms/bin/diann_convert.py:369: PerformanceWarning: DataFrame is highly fragmented.  This is usually the result of calling `frame.insert` many times, which has poor performance.  Consider joining all columns at once using pd.concat(axis=1) instead. To get a de-fragmented frame, use `newframe = frame.copy()`
    out_mztab_MTD.loc[1, "study_variable[" + str(i) + "]-assay_refs"] = ",".join(study_variable)
  /hps/nobackup/juan/pride/reanalysis/quantms/bin/diann_convert.py:370: PerformanceWarning: DataFrame is highly fragmented.  This is usually the result of calling `frame.insert` many times, which has poor performance.  Consider joining all columns at once using pd.concat(axis=1) instead. To get a de-fragmented frame, use `newframe = frame.copy()`
    out_mztab_MTD.loc[1, "study_variable[" + str(i) + "]-description"] = "no description given"
  /hps/nobackup/juan/pride/reanalysis/quantms/bin/diann_convert.py:369: PerformanceWarning: DataFrame is highly fragmented.  This is usually the result of calling `frame.insert` many times, which has poor performance.  Consider joining all columns at once using pd.concat(axis=1) instead. To get a de-fragmented frame, use `newframe = frame.copy()`
    out_mztab_MTD.loc[1, "study_variable[" + str(i) + "]-assay_refs"] = ",".join(study_variable)
  /hps/nobackup/juan/pride/reanalysis/quantms/bin/diann_convert.py:370: PerformanceWarning: DataFrame is highly fragmented.  This is usually the result of calling `frame.insert` many times, which has poor performance.  Consider joining all columns at once using pd.concat(axis=1) instead. To get a de-fragmented frame, use `newframe = frame.copy()`
    out_mztab_MTD.loc[1, "study_variable[" + str(i) + "]-description"] = "no description given"
  Traceback (most recent call last):
    File "/hps/nobackup/juan/pride/reanalysis/quantms/bin/diann_convert.py", line 924, in
      cli()
    File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
      return self.main(*args, **kwargs)
    File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1055, in main
      rv = self.invoke(ctx)
    File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
      return _process_result(sub_ctx.command.invoke(sub_ctx))
    File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
      return ctx.invoke(self.callback, **ctx.params)
    File "/usr/local/lib/python3.10/site-packages/click/core.py", line 760, in invoke
      return __callback(*args, **kwargs)
    File "/usr/local/lib/python3.10/site-packages/click/decorators.py", line 26, in new_func
      return f(get_current_context(), *args, **kwargs)
    File "/hps/nobackup/juan/pride/reanalysis/quantms/bin/diann_convert.py", line 196, in convert
      PRH = mztab_PRH(report, pg, index_ref, database, fasta_df)
    File "/hps/nobackup/juan/pride/reanalysis/quantms/bin/diann_convert.py", line 445, in mztab_PRH
      out_mztab_PRH = pd.concat([out_mztab_PRH, protein_details_df]).reset_index(drop=True)
    File "/usr/local/lib/python3.10/site-packages/pandas/util/_decorators.py", line 331, in wrapper
      return func(*args, **kwargs)
    File "/usr/local/lib/python3.10/site-packages/pandas/core/reshape/concat.py", line 381, in concat
      return op.get_result()
    File "/usr/local/lib/python3.10/site-packages/pandas/core/reshape/concat.py", line 612, in get_result
      indexers[ax] = obj_labels.get_indexer(new_labels)
    File "/usr/local/lib/python3.10/site-packages/pandas/core/indexes/base.py", line 3905, in get_indexer
      raise InvalidIndexError(self._requires_unique_msg)
  pandas.errors.InvalidIndexError: Reindexing only valid with uniquely valued Index objects

Command wrapper:
      done < <(ps -e -o pid= -o ppid=)

      pstat() {
          local x_pid=$1
          local STATUS=$(2> /dev/null < /proc/$1/status egrep 'Vm|ctxt')

          if [ $? = 0 ]; then
          local  x_vsz=$(echo "$STATUS" | grep VmSize | awk '{print $2}' || echo -n '0')
          local  x_rss=$(echo "$STATUS" | grep VmRSS | awk '{print $2}' || echo -n '0')
          local x_peak=$(echo "$STATUS" | egrep 'VmPeak|VmHWM' | sed 's/^.*:\s*//' | sed 's/[\sa-zA-Z]*$//' | tr '\n' ' ' || echo -n '0 0')
          local x_pmem=$(awk -v rss=$x_rss -v mem_tot=$mem_tot 'BEGIN {printf "%.0f", rss/mem_tot*100*10}' || echo -n '0')
          local vol_ctxt=$(echo "$STATUS" | grep '\bvoluntary_ctxt_switches' | awk '{print $2}' || echo -n '0')
          local inv_ctxt=$(echo "$STATUS" | grep '\bnonvoluntary_ctxt_switches' | awk '{print $2}' || echo -n '0')
          cpu_stat[x_pid]="$x_pid $x_pmem $x_vsz $x_rss $x_peak $vol_ctxt $inv_ctxt"
          fi
      }

      pwalk() {
          pstat $1
          for i in ${ALL_CHILDREN[$1]:=}; do pwalk $i; done
      }

      pwalk $1
  }

  nxf_stat() {
      cpu_stat=()
      nxf_tree $1

  (... more ...)
  ------------------------------------------------------------

  Exited with exit code 1.

  Resource usage summary:

      CPU time :                                   1059.00 sec.
      Max Memory :                                 1305 MB
      Average Memory :                             797.00 MB
      Total Requested Memory :                     30720.00 MB
      Delta Memory :                               29415.00 MB
      Max Swap :                                   -
      Max Processes :                              13
      Max Threads :                                116
      Run time :                                   1057 sec.
      Turnaround time :                            1059 sec.

  The output (if any) is above this job summary.

Work dir:
  /hps/nobackup/juan/pride/reanalysis/absolute-expression/platelet/PXD037340/work/83/8e8e22e767bff27f39b1f314d61fbd

Tip: view the complete command output by changing to the process work dir and entering the command `cat .command.out`

Command used and terminal output
No response
Relevant files
No response
System information
No response

Here the files needed: http://ftp.pride.ebi.ac.uk/pub/databases/pride/resources/proteomes/quantms-benchmark/8e8e22e767bff27f39b1f314d61fbd/

@ypriverol Same plasma dataset error in #268.

Yes.

@ypriverol Can you check the SDRF of PXD037340 again? In the experimental design file, I found that sample 31 corresponds to fraction 91, but it corresponds to 21 mass spectrometry files. This resulted in the protein_abundance_assay[91] appearing 21 times in mzTab.


make "call to boycott of a human being" violate the CoC

I was just wondering if this tweet: https://twitter.com/ameensol/status/1116078785286164480 violates our CoC - and after reading it seems it doesn't (IANAL) - but I think it should.

I would say that it would definitely violate it, if this happened in a DoD scenario (aka both being at ETHBerlin)
I think the community is in a weird place right now. Myself included, and we will need to be more flexible on this. But this particular case would - if happening in our DoD context


Sales Line - OnBeforeUpdateDeferralAmounts

Describe the request
Table Sales Line needs an OnBefore event publisher, allowing to skip the UpdateDeferralAmounts procedure.
procedure UpdateDeferralAmounts()
    var
        AdjustStartDate: Boolean;
        IsHandled: Boolean;
        DeferralPostDate: Date;
    begin
        OnBeforeUpdateDeferralAmounts(IsHandled); ////
        if IsHandled then
            exit;

        GetSalesHeader();
        OnGetDeferralPostDate(SalesHeader, DeferralPostDate, Rec);
        if DeferralPostDate = 0D then
            DeferralPostDate := SalesHeader."Posting Date";
        AdjustStartDate := true;
        if "Document Type" = "Document Type"::"Return Order" then begin
            if "Returns Deferral Start Date" = 0D then
                "Returns Deferral Start Date" := SalesHeader."Posting Date";
            DeferralPostDate := "Returns Deferral Start Date";
            AdjustStartDate := false;
        end;

        DeferralUtilities.RemoveOrSetDeferralSchedule(
            "Deferral Code", Enum::"Deferral Document Type"::Sales.AsInteger(), '', '',
            "Document Type".AsInteger(), "Document No.", "Line No.",
            GetDeferralAmount(), DeferralPostDate, Description, SalesHeader."Currency Code", AdjustStartDate);
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeUpdateDeferralAmounts(var IsHandled: Boolean)
    begin
    end;

Additional context
This is especially useful when creating temporary sales line record to simulate price calculation, to skip the deferral codeInternal work item: AB#493256

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 14606.


change "Streaming Analytics" to something like "Available on the cloud"?

I think the title could be improved here:

The main point of that what's new item is that it can now be used on the cloud, and the title should reflect that.   Possible alternatives:

Cloud-ready
Available on Cloud
On Bluemix
On Bluemix as Streaming Analytics
Now on Bluemix, IBM's cloud service
Available on Bluemix as Streaming Analytics
Available on the Cloud as Streaming Analytics

Rejecting this issue.  The Streaming Analytics name is the official name on the service.
The Cloud icon reflects that this is on the cloud.  In the description, we do mention that this is for Bluemix.  So I think we have enough clues that this is on the cloud.


[release-1.7] Update API version

@jasonwzm: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_client-go_release-1.7
a2c8ac73c509b93c9691b13358ba114066efbe65
link
/test gencheck_client-go_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Remove the old docker-multinode in favor for the new one

@johndmulhausen @orenye @mikedanese @pwittrock

@johndmulhausen Updated

@mikedanese Ping
Also cc @kelseyhightower if you have time :)

Please address comment in a follow up. @pwittrock this LGTM

Is it ok for me to merge this now?
I fixed @johndmulhausen's comments and @mikedanese LGTM'd it
I'll fix nits in follow-ups


Involved discipline

Instead of free selection, select non-math disciplines and mathematical areas.

Divided the 'involved disciplines' question into 'involved non-mathematical disciplines' and 'involved mathematical fields' questions. Answers will be shown separately in html template or wikipage, like this
Involved Disciplines
Mathematical Areas:

xyz (mardi:Qbla)

Non-Mathematical Disciplines

abc (mardi:Qfhg)

In Wikibase Mathematical Areas and non-mathematical disciplines are both added via 'field of work'.
Mathematical Areas answers can later on be used as option set provider!


Test keys show as valid ones?

Hi all,
I realized you accept/verify any signed SHC on the interface, even those we create for demos and other non-production environments. Those should not be a "Trusted Party" or a valid certificate in the real world.
Do you have any plan to add and maintain a Trust Registry with only the keys that have been verified to issue Proof of Vaccinations that effectively happened?
You can use ours to start if you wish: https://github.com/Path-Check/trust-registry
We use it on our app and it's working great to filter production keys for all the trash that is out there.
Happy to help in any way I can.
Best,

Hello @vitorpamplona, thanks for the idea! This behavior is more or less intended. Indeed, the purpose of this project is at first to allow people to understand how smart health cards work and to help them discover what personal information is contained in their QR code payload. In this sense, a correctly signed SHC will be marked as valid from the perspective of the SHC protocol.
Also, in Canada at least, merchants and restaurants are not supposed to use third-party applications to validate customers' QR codes, therefore I don't know how much of a need it is to implement this kind of verification in this project.


Define xrange() for Pyhton 3

xrange() is called on line 36 but it was removed in Python 3 in favor of range().

At some point real soon now, Apple will release an OSX update that upgrades the builtin Python from 2.7 to 3.7 and this script should be ready for that change.  Most Linux distros have already made this change and Apple will need to follow suit.  This PR does not break Python 2 compatibility but it does help with Python 3 compatibility.


TOC not working

using Python 3.7.3 and reportlab 3.5.
if i add TOC  <pdf:toc /> to my template following error occurs:

File "C:\development\projects\amdreport\venv\lib\site-packages\xhtml2pdf\reportlab_paragraph.py", line 1553, in drawPara
if f.underline or f.link or f.strike:
AttributeError: 'ParaFrag' object has no attribute 'underline'

same goes for the strike attribute. Deleting both in the if statement shows a toc, but i dont know which effects it has and if it works like it should now.
Also the TOC doesnt show headings if they are in tables, which i did for formatting, but well i could change that.

I have the same issue.

Seems like this has been solved by PR #486, just like #404 . So with the next release of xhtml2pdf, it should work without problems.
The following is running without errors, while using the current master branch, Python 3.9 and reportlab 3.5.53:

Heading 1

Some Text...

Heading 2

Some Text...

Heading 3

Subheading 1

Some Text...

Heading 4

Subheading 2

Some Text...

Subheading 3

Some Text...

<pdf:toc />

Result:
Test.pdf

That is great news as I just encountered this. Is there any work around until this is released?

@Swendude
You can simply use pip to install the master branch of xhtml2pdf on GitHub instead the default version on PyPI.

Hi, this was solved in 0.2.5  release, now available on pypi.


Fixes java version for hystrix plugin integration tests

Hystrix 1.4.0 - 1.4.2 requires Java 7

Codecov Report

Merging #3471 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3471      +/-   ##
==========================================
- Coverage   40.11%   40.09%   -0.02%
==========================================
  Files        2175     2175
  Lines       71136    71136
  Branches     9803     9803
==========================================
- Hits        28533    28522      -11
- Misses      39865    39879      +14
+ Partials     2738     2735       -3

Impacted Files
Coverage Δ

...p/pinpoint/rpc/client/WriteFailFutureListener.java
56.25% <0%> (-18.75%)
:arrow_down:

...rp/pinpoint/rpc/control/ControlMessageDecoder.java
64.28% <0%> (-14.29%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0%> (-11.12%)
:arrow_down:

.../pinpoint/rpc/client/PinpointClientHandshaker.java
61.11% <0%> (-4.87%)
:arrow_down:

.../com/navercorp/pinpoint/profiler/context/Span.java
48.27% <0%> (-1.73%)
:arrow_down:

...corp/pinpoint/rpc/stream/StreamChannelManager.java
70.68% <0%> (-1.73%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
70.37% <0%> (-0.93%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
79.37% <0%> (ø)
:arrow_up:

...p/pinpoint/collector/receiver/udp/UDPReceiver.java
78.44% <0%> (+0.86%)
:arrow_up:

...m/navercorp/pinpoint/test/OrderedSpanRecorder.java
74.03% <0%> (+1.92%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b41d160...606a12c. Read the comment docs.


Address overflow issue in documentation

Fixes #1049
Adds scrollbar which will make the overflow content available to the user

Thank you for merging ✨
Looking forward to contribute more 😄


nanodrz

Not a publication but I'll be working on getting this more e2e approach working with transformers:
https://github.com/mogwai/nanodrz

sounds good!


character.depthkit.play() doent work sometimes on safari mobile ios

in my app it plays fine on desktop, on mobile (ios safari) i get this error over and over again.
Unhandled Promise Rejection: NotAllowedError: The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission.
(anonymous function)
rejectPromise
play
value — depthkit.min.js:2:9573
(anonymous function) — main.js:620
update — main.js:300
animate — main.js:321
value — depthkit.min.js:2:9573

I do have it so the the user must tap the screen to start the whole experience, but the play itself is triggered by something else that happens after the user taps the screen. I suspect it might be because its not directly inside a user gesture? I say this because this toy project works fine: https://depthkit.glitch.me
this is whats supposed to happen: https://www.youtube.com/watch?v=_pZPpvudI7I&feature=youtu.be
This is my project: https://glitch.com/~ht94 you dont need to go through the experience just know its like the video except the character doesnt play. Posting it here incase you wanted to see the code (sorry i need to comment it)
how I got that video in the first place is that it used to work but i made some changes, i have been trying to pinpoint them to the exact moment it broken but its been taking hours, I thought id post this, keep looking and update when i find it, incase you have a suggestion for a quick fix... thank you!!
edit: I am not sure why it was working before I couldnt find any change in the code that caused it to break, I am sure it is there somewhere & there is a logical explanation but for now i cant spend any more time looking.

I figured it out, so my suspicion was valid. It was that the play() wasnt happening in the user input event handler. [This SO answer enlightened me on what to do in this case ](https://stackoverflow.com/questions/46483001/programmatically-play-video-with-sound-on-safari-and-mobile-chrome/46483345#46483345?newreg=2a2cff8eb834426eb5404165541a11e9
)for those who may happen upon this & need a solution:
First have a global or something named character
in the user input event handler:
   character = new DepthKit( 'mesh', scene1Text, scene1Video);    character.depthkit.setVolume(0);    character.depthkit.play();   setTimeout(function(){character.depthkit.pause(); },5000);
Waiting 5 seconds is a hack since the depthkitplay isn't a promise (i dont think), so i cant make the pause a callback function. I just assume 5 seconds is long enough for the play function to finish.


Embedding charts into HTML document?

Is there a way to create HTML code using PlotlyPlotter.save() for a series of charts and embed them into some "outer" HTML document without playing the templating blues (like with jinja2)? Well, I can think of a way to do this...

Hmmm. If you are thinking of the use case of rendering multiple charts in one HTML template,  there would be collisions with binding the charts to the same DOM element.  You would have to have a way to specify unique elements for each chart in the series.
What are your  concerns about the Jinja2 Templating?

Well, I have a prototype that takes output from PlotlyPlotter.save() like this

picks only the last script element, replaces the CSS id named chart and embeds this (for several plots) into some HTML template using Jinja2. Nothing wrong with that. I just think that Bokeh kind of did that already last time when I evaluated it. But, sadly, it's still unable to make a decent pie chart...
It would just be nicer to not create the snippets to be embedded as real files, but get them as simple strings, too.

Ah,  I think I understand.   I do want to keep most of the the api geared to single plots, buti have an idea.  What if I separate the script tags for loading the libraries from the template string and add a name paramter to the plotter.render() function that corresponds to the div id.  Then you could concatenate the html for multiple plots into one html string.  Then saving them to one file is simple, and even rendering them before saving them is trivial like so:
from iplotter.iplotter import PlotlyPlotter
from IPython.display import HTML

plotter = PlotlyPlotter()

trace1 = {
  "x": ['Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec'],
  "y": [20, 14, 25, 16, 18, 22, 19, 15, 12, 16, 14, 17],
  "type": 'bar',
  "name": 'Item 1',
  "marker": {
    "color": 'rgb(49,130,189)',
    "opacity": 0.7,
  }
}

trace2 = {
  "labels": ['Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec'],
  "values": [19, 14, 22, 14, 16, 19, 15, 14, 10, 12, 12, 16],
  "type": 'pie',
  "name": 'Item 2',
  "marker": {
    "opacity": 0.7
  }
}

charts = [
    [trace1],
    [trace2]
]

# plotter.head will return the html string containing script tags for loading the plotly.js/C3.js libraries
multiple_plot_html = plotter.head

for i, chart in enumerate(charts):
    multiple_plot_html += plotter.render(name="chart1_"+str(i), data=chart)

# Write multiple plots to file
with open("multiple_plots.html", 'w') as outfile:
    outfile.write(multiple_plot_html)

# display multiple plots in iframe
HTML(plotter.iframe.format(multiple_plot_html, 600, 900))


Example C on this page shows incomplete syntax.

OPEN MASTER KEY requires further info. See https://docs.microsoft.com/en-us/sql/t-sql/statements/open-master-key-transact-sql?view=sql-server-2017

@greglow : Thanks for your contribution! The author, @VanMSFT, has been notified to review your proposed change.

Thanks @greglow!
#sign-off


Feat importance page

Hi, this pull request is regarding issue #85
In this code:

The Feature Importance page has been created. I have included all the options that originally were customised in the side bar. Also, text has been added to explain further what the page does and what each of the options do. The page does not include any functionality, it is only to show how the page will look like
The navbar has been edited to include the Feature Importance page.

@dcl10 I have changed the file name, and corrected it in the navbar. Also, everything now matches British spelling.


clientid missing but complete

service keeps saying client ID is missing but the ID is filled:
service: whatsapp.send_message
data:
to<EMAIL_ADDRESS>body:
text: testbericht whatsapp
clientid: ralph

Ehh, when using the exact same string in the home assistant app on iOS, it works??

fixed it, but it's weird. In edge/chrome the data field should not be used:
service: whatsapp.send_message
clientId: ralph
to<EMAIL_ADDRESS>body:
text: testbericht whatsapp


python: bump version bounds on iam dep

Fixes #2865

bumps the version range of the python dependcy on grpc-google-iam-v1 to the v0.12.* minor version
removes the forced import name for google.iam.v1 that was added to fix #2160

The regeneration of grpc-google-iam-v1 was necessary because a new IAM proto message & file were added. This, however, resulted in the refactoring of the generated gRPC stub. It was previously part of the iam_policy_pb2.py generated code, but was moved to iam_policy_pb2_grpc.py by the newer code gen tooling. Pub/Sub and KMS are the only two Python GAPICs that depend on the IAMPolicyStub, and were being forced to import the iam_policy_pb2 file for the IAMPolicyStub. This change removes that forced import name and allows the use of the proper one.

FYI @crwilcox


PDFReader - MalformedPDFError - Error occured while inflating a compressed stream

Hello,
Thanks for the wonderful gem.
I am encountering an issue on few PDFs - I get PDF::Reader::MalformedPDFError: Error occured while inflating a compressed stream  when i try to read the Page text 'reader.pages[1].text'.
Here is the complete error details. Can someone please help here?
Details:
#<PDF::Reader::MalformedPDFError: Error occured while inflating a compressed stream (Zlib::DataError: invalid code lengths set)> Additional Details: C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/filter/flate.rb:34:in rescue in filter' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/filter/flate.rb:17:in filter' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/stream.rb:63:in block in unfiltered_data' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/stream.rb:62:in each' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/stream.rb:62:in each_with_index' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/stream.rb:62:in unfiltered_data' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/font.rb:136:in extract_base_info' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/font.rb:47:in initialize' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/page_state.rb:384:in new' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/page_state.rb:384:in block in build_fonts' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/page_state.rb:383:in each' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/page_state.rb:383:in map' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/page_state.rb:383:in build_fonts' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/page_state.rb:28:in initialize' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/page_text_receiver.rb:42:in new' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/page_text_receiver.rb:42:in page=' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/page.rb:154:in block in callback' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/page.rb:153:in each' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/page.rb:153:in callback' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/page.rb:104:in walk' C:/Ruby193/lib/ruby/gems/1.9.1/gems/pdf-reader-1.3.3/lib/pdf/reader/page.rb:75:in text' C:/Tellus/Utils/UtilsBB.rb:32:in VerifyPDFDownloaded'
Regards,
Ramya

Hey @yob I have a sample PDF having this problem. Can you take a look?

I too have run into this problem. Have yet to find a solution.


Kibana-datasweet-formula support for kibana 7.0.1

Thank you so much for this plugin. The plugin is not compatible with the latest version of Kibana 7.0.1. Please support.

Hi, we will, soon. It is a tough job to follow up with every minor update....for free, so please be indulgent regarding delays.
Tweaking the Kibana version number in your package might do the trick. We did not test our latest version against 7.0.1 yet, but maybe it can spare you some waiting time.

Hi.
Forgive me if i sounded rude. It wasn't my intention. Thanks for reply and trick. I will try.

Hi, @dancristi4n. You did not sound rude, no problems!
Fact is that the Elastic policy regarding plugins is clearly adding workload for small teams like we are. Add on top of it that breaking changes occur very often with every new minor or major release, AND the fact that Datasweet-Formula is a big hack of Kibana, then you get the perfect definition for hassle ! But we do it because we know that our plugin is useful and used (thousands of downloads per year). We wish more users like you take time to thank us and "star" this project.

Hi.
I tried the trick but didn't works.
I changed the Kibana version in my package file from "7.0.1" to "7.0.0". I downloaded the plugin and installed with successfull.
Initially, without return the version to "7.0.1", restarted the Kibana service and checked if dashboards, visualizations and anything else still working but some disappeared.
So, I returned the version to "7.0.1" and the dashboards and visualizations reappeared, but the function "datasweet formula" is disable.
Anyway, thanks.
I already gave the "star" for this project. I'll wait for a new release.

Hi @dancristi4n
We added the support to kibana v7.0.1 in this release
https://github.com/datasweet/kibana-datasweet-formula/releases/tag/v2.2.1


If both webhook URL and bot token are specified, action will run twice

Description
I think this mostly just affects running the tests in this repo. Currently, each individual test in this repo's GH Action CI workflow file executes possibly multiple times because of this bug.
If a bot token is specified via an environment variable, then this conditional block will execute, which might result in posting or updating a message.
If a webhook URL is specified via an environment varaible, then this conditional block will execute, possibly POSTing to the webhook URL.
If you consume this action and use it using a bot token, but also specify the webhook URL environment variable, the action will POST to the webhook URL.
I think the solution is to do either-or: either use the bot token, or use the webhook URL. A fix for this issue should also clean up the usage of the webResponse variable in the code, as this is only set and used in the bot-token scenario.

👋 This is now fixed with @v2 where including both webhook and token will cause the step to exit with an error!
I do agree that having both techniques possible at the same time can cause a bit of confusion. I'd also be so interested in knowing of workflows that share payloads between different techniques in general 👀
I'll close this issue with the latest changes 👍


Get data fails with l16

When using erc725.js to get data the provider fails to get the keys from the erc725 contract
This only seems to happen when using an l16 provider. Tested using same contract version on l14 and worked okay
Getting the same data from l16 using web3 contract instance works okay

Problem occurs when calling supportsInterface. RPC responds with
{
  jsonrpc: '2.0',
  id: 1,
  error: { code: -32602, message: 'missing value for required argument 1' }
}


Arranging nodes by name

In a graph like above it'd be nice to see nodes order on the basis of their names.

Ideally we should detect fully-connected cliques and lay them out in a better way:

Related to #1299

As @tomwilkie says, the example given is an instance of #1092.


Gallery not on full viewport

https://www.opensmartmesh.com/docs/3dprinting/house/
clicking on photos does not cover the full viewport

https://www.opensmartmesh.com/docs/3dprinting/light/
clicking on photos does not center the view on the window

fixed


Stats screen

Player stats: gold, name, golems acquired.
each golem stats:
speed, health, element, etc

I think we should push this back?


move search to alpha

Describe what this PR does / why we need it
Support search to view the current list of supported images

move search to alpha
modify default defaultDomain and defaultRepo

Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report
Base: 21.44% // Head: 21.44% // No change to project coverage :thumbsup:

Coverage data is based on head (fb39482) compared to base (48baeed).
 Consider uploading reports for the commit 6256d27 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1902   +/-   ##
=======================================
  Coverage   21.44%   21.44%
=======================================
  Files          74       74
  Lines        6891     6891
=======================================
  Hits         1478     1478
  Misses       5216     5216
  Partials      197      197

Impacted Files
Coverage Δ

pkg/image/reference/util.go
83.78% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add Staatliche Berufsschule I Traunstein

Homepage-URL: https://bs1ts.de/
Course-URL: https://bs1ts.de/bs1/berufe/elektroberufe/
The URL bs1traunstein.de redirects to bs1ts.de
If you scroll down on Course-URL, you can see teacher E-Mails, which end with this URL.
While this URL is also used for student E-Mails there is, to my knowledge, nothing on the website that confirms these are used for students.
Added an anonymized screenshot of me being logged into my student E-Mail.

@SpottedCheetah Pull request merged. Thank you!


subPackages do not work on Ubuntu

Hi,

documentation seems to be wrong regarding the subPackages format. Valid format is subPackages: '["nvcc", "cublas_dev"]'
subPackages do not work as expected on Ubuntu (16.04, probably others too). Since Ubuntu .run installer does not support them (or at least that's what I understand from the documentation), using subPackages results in failed build:

/usr/bin/sudo /opt/hostedtoolcache/cuda_installer-linux/10.2.89/x64/cuda_installer_10.2.89.run --silent --toolkit --samples nvcc cublas_dev
Unknown option: nvcc

Ah yeah it must be a Windows only thing then, I will clarify this in the documentation, thanks for letting me know!

Hi @Jimver
thanks for the fast fix!
Please don't forget to update example on the Marketplace, currently it still says that network version is not implemented on Linux.
Otherwise, this action now (at least for me) works as expected!

@DStrelak Thanks for pointing that out! Should be fixed now in v0.2.1


Bug re: Python 3.9

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/54
Originally created by @aaronsteers on 2021-03-19 23:39:49

Although we don't support Python 3.9 yet, this still seemed worth logging because it may be directly actionable.
User Mindy reported in Slack an error after what otherwise looks like a successful run:
type object '_asyncio.Task' has no attribute 'all_tasks'

Googling surfaced this related diagnosis: https://github.com/jupyterhub/jupyterhub/issues/3297
With this (fairly portable) fix: https://github.com/jupyterhub/jupyterhub/pull/3298/files

View 1 previous comment from the original issue on GitLab


Feedback - Additional Guidance for using the Invoke-PolicyToBicep.ps1

AB#29959
Contact Details
<EMAIL_ADDRESS>Let us know the feedback or general question
Feedback - End-user attempted to run the Invoke-PolicyToBicep.ps1 script and ran into an issue that the script cannot find a PowerShell module referenced within the ESLZ repo.
Consider updating documentation to include steps to run the script such as "cloning the Enterprise-Scale repo down within the same parent directory as the alz-bicep-accelerator repo for the script to pick up the module."
Version
Latest
Code of Conduct

[X] I agree to follow this project's Code of Conduct

FYI @sebassem


Responsive navbar

Linked Issue
Closes: #6
Describe the changes you've made
I have made the whole navbar responsive as given in issue description. firstly I made a hamburger icon and while it click a dropdown navbar came from top . . . .
Type of change
What sort of change have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Describe how have you verified the changes made
Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots

Original
Updated

 |  |
 | |

Congrats @JoydevDafadar your PR is merged.


Playlist fails when video doesn't exist

There are many playlists with deleted (or private?) videos, and that causes youtube-dl to give up. I would have expected it to just skip the missing videos instead of exiting.

This is expected behavior for now. Use -i to skip errors.

Ok, thanks.
Also noticed this for videos with copywrite claims.


[bal-button] loading state issue

if the same form is submitted more then one time in a row, the bal-spinner inside the submit button adds a new svg each time

linked with #897

@hirsch88 is this fix already released?


Grafana setup should use password from GF_SECURITY_ADMIN_PASSWORD

The environment variable to change the default admin password in Grafana is GF_SECURITY_ADMIN_PASSWORD and not GRAFANA_PASSWD. Therefore it would make sense to use that env variable in https://github.com/kubernetes/heapster/blob/master/grafana/setup_grafana.go

Similar issue reported in #1623

Fixed by  	05f739e


[Feature Request] webhook

add a webhook tool so for a example you can set a webhook and when someone leaves your server you can see who left your server
could be useful if you don't always have vrcx running in the background. and I feel like a lot of people would use that

You're asking the wrong people, and I'll save you the effort VRC will say no.


Add Dalli instrumentation gem

Closes https://github.com/open-telemetry/opentelemetry-ruby/issues/244

There's a conflict in the Rakefile and this gem should be added to the releases.yml file. Otherwise LGTM, thanks!


Upgrade the app plataform

Upgrade packages
Replace Jest with Vitest
Configure NestJS cli to use Vite + SWC

Just remade the bot from scratch for performance ;P


README.md expanded

Before I create a pull request.
Please review my expanded version of the README.md

Rather than ftpd is too big, ESP8266 has size restrictions :-)
listed commands implemented and those not
add using
rearranged and renamed some sections

https://github.com/DG12/FTP-Server-for-ESP8266-ESP32-and-PYBD/tree/expand-README.md#readme
And provide me with any feedback.

That looks ok. While you are working on it, please remove and mentioning for fireftp. That extension is not supported any more by Firefox.


math detail

Is there any math detail?for example ,how to get relative orientation task jacobian in kinetic and dynamic problem?

maybe some papers or books?

Hello,
What you want is likely to understand better the Lie theory. As a disclaimer, I am not myself an expert of it. I might spend some time writing the derivations needed in PlaCo in the future.
I would recommend Modern Robotics as an introduction reading: https://hades.mech.northwestern.edu/index.php/Modern_Robotics
Even if they don't provide very advanced derivations, they give a good introduction to twists and Jacobian, with most useful identities. I believe the advanced absolute reference would then be the works from Roy Featherstone, but you will need to invest more time to dive into it.

If I understand well, your question is more about how to compute the relevant terms using the underlying rigid body library (in our case Pinocchio) ?
Do you want me to provide details about relative orientation in particular ?

First of all, thank you very much for your reply. In fact, I have already studied Modern Robotics, but I am still a little far from understanding the content of Placo. Maybe I need to learn something else. If you have time, can you write some blogs to introduce the relevant calculations?for example relative_position_task,and relative_orientation_task.
`void RelativeOrientationTask::update()
{
auto T_world_a = solver->robot.get_T_world_frame(frame_a);
auto T_world_b = solver->robot.get_T_world_frame(frame_b);
auto T_a_b = T_world_a.inverse() * T_world_b;
Eigen::Vector3d error = pinocchio::log3(R_a_b * T_a_b.linear().transpose());
Eigen::MatrixXd J_a = solver->robot.frame_jacobian(frame_a, pinocchio::WORLD);
Eigen::MatrixXd J_b = solver->robot.frame_jacobian(frame_b, pinocchio::WORLD);
Eigen::MatrixXd J_ab = T_world_a.linear().transpose() * (J_b - J_a).block(3, 0, 3, solver->N);
Eigen::MatrixXd Jlog;
pinocchio::Jlog3(R_a_b * T_a_b.linear().transpose(), Jlog);
A = mask.apply(Jlog * J_ab);
b = mask.apply(error);
}`
`  auto T_world_a = get_T_world_frame(frame_a);
auto T_world_b = get_T_world_frame(frame_b);
auto T_a_b = T_world_a.inverse() * T_world_b;
Eigen::MatrixXd R_world_a = T_world_a.linear();
Eigen::MatrixXd J_a_pos = frame_jacobian(frame_a, pinocchio::LOCAL_WORLD_ALIGNED).block(0, 0, 3, model.nv);
Eigen::MatrixXd J_a_rot = frame_jacobian(frame_a, pinocchio::LOCAL_WORLD_ALIGNED).block(3, 0, 3, model.nv);
Eigen::MatrixXd J_b_pos = frame_jacobian(frame_b, pinocchio::LOCAL_WORLD_ALIGNED).block(0, 0, 3, model.nv);
return (R_world_a.transpose() * (J_b_pos - J_a_pos) +
pinocchio::skew(T_a_b.translation()) * R_world_a.transpose() * J_a_rot);
`
Thank you very much .

Ok, I started writing something here, currently covering only for the relative orientation:
https://gregwar.github.io/jacobians
Please tell me if it's understandable. If it is, I will add the derivation for relative position as well.

yes,thank you very much .i have understand this blog. i noticed  this in code :
Eigen::MatrixXd J_ab = T_world_a.linear().transpose() * (J_b - J_a).block(3, 0, 3, solver->N);
but i still dont understand this ：
pinocchio::Jlog3(R_a_b * T_a_b.linear().transpose(), Jlog);

Suppose the orientation of an effector is in the current configuration $R_0$, and you want to take it to the desired configuration $R_1$
By applying a space  angular velocity $\omega$, the resulting configuration will be $R = exp3(\omega) R_0$, where the $exp3$ operator refers to the exponent of the screw symmetric matrix associated to $\omega$
You then want the following to hold:
$$exp3(\omega) R_0 = R_1$$
To achieve this motion, you need to have
$$\omega = log3(R_1 R_0^T)$$
Where log3 is the opposite operator of exp3 (mapping a matrix to a vector of dimension 3).
You can use the pseudo-inverse of the Jacobian to try to achieve this $\omega$, but you might end up achieving another $\omega'$ (e.g if the task is overconstrained). In that case, the pseudo-inverse is equivalent to minimizing the error $|| \omega' - \omega ||^2$.
Somehow, this is fine because you try to get as close as possible to the desired $\omega$. However, this is not an euclidian space, so it seems ill-defined to use the squared norm as an error function.

Another way of defining the problem is:
$$
log3(R_0 R_1^T exp3(\omega)) = 0
$$
We want to have the log of the residual error to be 0. Else, we would like it to be minimized. If we were to take two candidates $\omega'$ through this expression, the one with the lowest norm would this time indeed be the closest in term of orientation error.
Using Pinocchio's Jlog3, we can take the first order approximation of the above expression as:
$$
log3(R_0 R_1^T exp3(\omega))
\approx
log3(R_0 R_1^T)
+
Jlog3(R_0 R_1^T)
\omega
$$
By using the fact that $-log(R) = log(R^{-1})$, we can write our first-order approximation objective equality to:
$$ Jlog3(R_0 R_1^T) \omega = log3(R_1 R_0^T)$$
It match the first formulation, except for a left multiplication of our velocity with the $Jlog3$ term.

Stéphane Caron (ping @stephane-caron ) wrote a blog post specifically about this:
https://scaron.info/robotics/jacobian-of-a-kinematic-task-and-derivatives-on-manifolds.html
I overall recommend you his blog as source of information as well :slightly_smiling_face:

As a more intuitive example, suppose you want to rotate by 1 rad about the x axis.
We compare the rotations $\omega_1 = [0.9, 0, 0]$ and $\omega_2 = [1.0, 0.1, 0.0]$.
In term of squared norm, both are producing the same error ($0.1^2$)
However, if you calculate:
import numpy as np
import pinocchio as pin

np.linalg.norm(pin.log3(R.T @ pin.exp3(np.array([0.9, 0., 0]))))
# 0.1

np.linalg.norm(pin.log3(R.T @ pin.exp3(np.array([1.0, 0.1, 0])))
# 0.0958...

In other words, less radians will be remaining from $[1.0, 0.1, 0]$ to reach the target.

thank you very much .I totally Understanded.If you have finished “relative position task” related blog,please let me know,sincerely thanks。

Thank you very much, I completely understand this problem. I'm an amateur robotics enthusiast trying to do some small personal projects. I have paid attention to robot projects like ocs2 and drake before, but these libraries are too big and not well understood by me. I noticed placo by chance. It is simple and precise, and it supports python and c++, which is friendly to me. Great job.

Nice discussion :slightly_smiling_face: Going back to the original question, you can also find some material on the extension to poses (coupled position-orientation) rather than orientation:

Is there any math detail?for example ,how to get relative orientation task jacobian in kinetic and dynamic problem?

The discussion above is about the relative orientation task Jacobian in $SO(3)$, and the blog post linked above by @Gregwar is about the same for poses in $SE(3)$.
The relative pose task Jacobian in $SE(3)$ can be derived in a similar way: @ymontmarin wrote this down in the documentation of RelativeFrameTask.compute_jacobian in Pink (another IK library implemented in Python and cousin to PlaCo).