feat(ui): display latest version in package overview

Closes #330
Fixes #330
📑 Description
This shows the LatestVersion and the Current version (if installed) on the package overview page
Images :

When a Package is installed

When a Package is not installed

✅ Checks

[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required

ℹ Additional Information

Hey @pmig can you please check this I think there is some mistake I made in my code repository and I couldn't update the entire code but the UI works for me. But I absolutely dont know how

@christophenne I have rebased the branch to main but still shows conflicts. I wonder why

It's possible that in the meantime something has changed in this file, and you need to rebase again.
Can you do us another favor please: We like to squash our commits before merging them into main, such that we don't have multiple commits with the same message but only one. Please read this: Squashing. Afterwards you need to force-push your branch, and it will show up in the PR as one commit.
We didn't require this for first-time or newer contributors yet because we can also do it for them, but since you open PRs quite frequently, we kindly ask you to try it – that would help us a lot :)

Hi @hanshal101 @christophenne will take care about the code review :-)

Thanks @pmig I'm totally confused why my PRs are working like this.


createPaymentMethod should also work with card from token

A related issue for Flutter: https://github.com/flutter-stripe/flutter_stripe/issues/153
Possibly related: https://github.com/stripe/stripe-react-native/issues/239
Essentially it should be possible to create a payment method based on the token that was received with Google / Apple Pay. Right now it's not possible because createPaymentMethod relies only on the information provided from the card field.

confirmPayment allows to pass in a token, that's the only client-side use case I see. Otherwise you can send the token to your server and attach it to a customer there etc.
Why would you need to create a payment method from a token client-side?

Well in my specific use case my backend only deals with a payment method (no tokens), whether that was created from a credit card or via native pay.  Hence the reason I expected to use the token to obtain a payment method.

@markphillips100 can you describe your flow a bit more please. Your backend can turn the token into a payment method if needed: https://stripe.com/docs/api/payment_methods/create#create_payment_method-card

I use an event driven architecture at the backend so "place order" from a client perspective doesn't give me the opportunity to confirm payment.  The payment flow works this way:

On user selecting place order, payment method Id for the order is sent to the backend resulting in a message being placed on a queue.  Client is now waiting for a message from server (via websocket) to determine what to do next.  It could receive a message to confirm payment or something else may need resolution, e.g. different payment method, etc.
Backend event handler takes care of creating the required payment intent from the supplied payment method.
Backend webhook receives stripe response from creation of payment intent and decides what to do next, e.g. send a message for client to confirm payment, etc.

I agree I can extend my backend api to support both a payment method Id or a token for step 1.  That's my plan B.  Plan A was to see if I can get away with no change to my code :-) .
If createPaymentMethod isn't meant to be used in this way then maybe Plan B is the only option and perhaps @jonasbark maybe indicate in migration doc the use case is not supported and what the alternative is?

@markphillips100 thanks for the details.


[ARTS-243] testbranch

PR for QA demo

Just for demo...not required

Just for demo...not required


Snapshot Rebuild

feat(snap-rebuild/grpc): impl grpc backend

Replaces the dummy impls with the actual implementation.
Snapshot Rebuilds are now created, destroyed and listed.

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

feat(snap-rebuild/cli): add snap rebuild cli commands

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

feat(rebuild/snapshot): initial dummy snapshot rebuild

Adds snapshot rebuild module, which only makes use of bdev
rebuild internally.
Adds rebuild option to copy only cluster allocated to the
current blob. This is a simply way of copying the allocated
snapshot without before the bitmap is in place.

Adds tests for simple snapshot rebuilds.

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

bors merge

bors merge


fix fixstates command can not fix new modules on subshops

Hello @keywan-ghadami-oxid,
Can you please explain me what do you mean by unable to fix new modules on subshops? Or yet better, give me your use case. Currently _getAvailableModuleIds() should return all modules ids independently on which shop this gets called.

@EllisV it's all about that workaround:
// We are calling getModulesFromDir() because we want to refresh
// the list of available modules. This is a workaround for OXID
// bug.
getModulesFromDir loads modules from directory and adds module information to oxid oxconfig database. But it must be called on the right subshop. to test it you can add a new module to the modules folder and then run "oxid fix:states -a" it will give some errormessages in the subshops

@keywan-ghadami-oxid Alright. I'll test it and evaluate the problem on a weekend. Stay patient! (:

thank you! BTW it's nothing urgent or even important just a nice to have thing in automated deployments

Can not really test it against EE version as I do not have access to it but I take your word that there is a bug on this. One little minor improvement that I want you to do is that _parseModuleIds() shouldn't be done on all shops. It can be done on just root shop. Just call _getModulesFromDir() on every shop loop entry. What do you think?

one important thing is that _getModulesFromDir() has also to be called before accessing that aModulePaths variable because it adds the new modules. The second thing to think about is that aModulePaths can also contain different corrupt entries for each subshop, i need that information to remove not existing modules in subshops.
BTW:
We currently thinking about back porting some stuff from new shopversions so we can unify oxidconsole1.1 and 1.2. We are working in both versions on the fixstate command to remove old modules, warn on error caused by errors in module meta data, giving information about what was fixed, and if modules will become active.

@keywan-ghadami-oxid I am aware of that calling _getModulesFromDir() on every shop oxConfig is the part of the fix. But within this pull-request you are also doing _parseModuleIds() on every shop oxConfig which is unnecessary. _parseModuleIds() is a command helper for getting ids of modules to fix - passed by an argument(-s) or get all if --all flag is specified. You can still call _getModulesFromDir() on every loop entry. Or am I overseeing something?
Also there were quite a few requests on having OXID console as composer package which I currently plan to have at 1.3. On this release I also plan to unify both 1.1 and 1.2 and provide clear migration path.

you are right _parseModuleIds() is a little bit much here, but if you only call getModulesFromDir within the loop it would not update the variable $aModuleIds (which not yet a problem, but might be needed for other stuff i am currently working on).


error when trying the custom indexer

Elasticsearch version: 5.3.0
Error: Scroll error: [illegal_argument_exception] No search type for [scan] :: {"path":"/zoe_old/impacts/_search","query":{"search_type":"scan","scroll":"1m","size":100},"body":"{}","statusCode":400,"response":"{\"error\":{\"root_cause\":[{\"type\":\"illegal_argument_exception\",\"reason\":\"No search type for [scan]\"}],\"type\":\"illegal_argument_exception\",\"reason\":\"No search type for [scan]\"},\"status\":400}"}
    at scroll_fetch (/Users/manuzenou/.nvm/versions/node/v6.9.4/lib/node_modules/elasticsearch-reindex/bin/elasticsearch-reindex.js:258:15)
    at respond (/Users/manuzenou/.nvm/versions/node/v6.9.4/lib/node_modules/elasticsearch-reindex/node_modules/elasticsearch/src/lib/transport.js:308:9)
    at checkRespForFailure (/Users/manuzenou/.nvm/versions/node/v6.9.4/lib/node_modules/elasticsearch-reindex/node_modules/elasticsearch/src/lib/transport.js:248:7)
    at HttpConnector.<anonymous> (/Users/manuzenou/.nvm/versions/node/v6.9.4/lib/node_modules/elasticsearch-reindex/node_modules/elasticsearch/src/lib/connectors/http.js:164:7)
    at IncomingMessage.wrapper (/Users/manuzenou/.nvm/versions/node/v6.9.4/lib/node_modules/elasticsearch-reindex/node_modules/lodash/index.js:3095:19)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:974:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

I think this may be a bug with 5.*
Still doing research but I'm not even using the custom indexer and I'm seeing this.

Indeed. From the deprecation guide:

The scan search type was deprecated since version 2.1.0 and is now removed. All benefits from this search type can now be achieved by doing a scroll request that sorts documents in _doc order

I will see if I can rustle up a PR.


Fix JSON Object deserialization.

Fixed JSON Object deserialization in SurrealWebSocketConnection. Errors occurred when trying to create/select/update/etc a database record with a specified ID, see more here.
This fixes those errors occurring, but after some testing, I encountered other problems such as: when trying to select a record with a specified ID, it would just return an empty Array.
EDIT: I also encountered problems with creating a new record with a specified ID.
Overall more testing and fixing need to be done for other parts of the code.
If there is any confusion, just ask me.
Thanks to @phughk for the explanations and help!

Nice! Thank you so much!
I was wondering if we could also have a test that verifies it. Something like the following in the websocket connection class test
    private static final String localAddr = "ws://localhost";
    private static final int localPort = 8000;

    @Test
    public void canHandleSingleObjectResult() {
        SurrealWebSocketConnection connection = new SurrealWebSocketConnection(localAddr, localPort, false);
        connection.connect(1);
        SyncSurrealDriver driver = new SyncSurrealDriver(connection);
        Map<String, String> leslie = Map.of(
            "name" , "Leslie",
            "surname","Lamport"
        );
        driver.create("person:leslie", leslie );
        List<Map> vals = driver.select("person:leslie", Map.class);
        assertEquals(1, vals.size());
    }

    @Test
    void canHandleMultiObjectResult() {
        SurrealWebSocketConnection connection = new SurrealWebSocketConnection(localAddr, localPort, false);
        connection.connect(1);
        SyncSurrealDriver driver = new SyncSurrealDriver(connection);
        Map<String, String> leslie = Map.of(
            "name" , "Leslie",
            "surname","Lamport"
        );
        driver.create("person:leslie", leslie );
        Map<String,String> barbara = Map.of(
            "name", "Barbara",
            "surname", "Liskov"
        );
        List<Map> vals = driver.select("person", Map.class);
        assertEquals(2, vals.size());
        Assertions.fail("expected");
    }

I tried running it with gradle integrationTest and it actually didn't run!? There is something wrong with the filter.
If you have time for it that is. If you don't I can create an issue instead and merge as is :)

Nice! Thank you so much! I was wondering if we could also have a test that verifies it. Something like the following in the websocket connection class test
    private static final String localAddr = "ws://localhost";
    private static final int localPort = 8000;

    @Test
    public void canHandleSingleObjectResult() {
        SurrealWebSocketConnection connection = new SurrealWebSocketConnection(localAddr, localPort, false);
        connection.connect(1);
        SyncSurrealDriver driver = new SyncSurrealDriver(connection);
        Map<String, String> leslie = Map.of(
            "name" , "Leslie",
            "surname","Lamport"
        );
        driver.create("person:leslie", leslie );
        List<Map> vals = driver.select("person:leslie", Map.class);
        assertEquals(1, vals.size());
    }

    @Test
    void canHandleMultiObjectResult() {
        SurrealWebSocketConnection connection = new SurrealWebSocketConnection(localAddr, localPort, false);
        connection.connect(1);
        SyncSurrealDriver driver = new SyncSurrealDriver(connection);
        Map<String, String> leslie = Map.of(
            "name" , "Leslie",
            "surname","Lamport"
        );
        driver.create("person:leslie", leslie );
        Map<String,String> barbara = Map.of(
            "name", "Barbara",
            "surname", "Liskov"
        );
        List<Map> vals = driver.select("person", Map.class);
        assertEquals(2, vals.size());
        Assertions.fail("expected");
    }

I tried running it with gradle integrationTest and it actually didn't run!? There is something wrong with the filter.
If you have time for it that is. If you don't I can create an issue instead and merge as is :)

No problem, thanks. Also, I tried running gradle integrationTest on the original repo but it failed as well, so most likely it's an existing issue. I will probably only have time over the weekend to finish it.

Yeah, easy! Theres no rush and we really appreciate the work you are doing! Thank you! :)

Yeah, easy! Theres no rush and we really appreciate the work you are doing! Thank you! :)

So I was working on different projects and I haven't had time to implement the other fixes. So let's merge this and I'll open another issue for those problems and if I'll have time to implement those other fixes I'll do it.

I have added this pr as accepted for hacktoberfest @Zyrenth, if you are participating :) Thanks again for the contribution!


virus start when user opens pc (pls add(if it already exists it’s not working))

Could you make a feature where the virus automatically starts when the user opens the pc?

Its already made

And its working


Reconnect after receive Error 4201

In my project I receive the following Error  and my app reconnect to the pusher service.  The Error fires al lot of times while running the app over a day.
pysher.connection:Connection: Received error 4201
 Connection: Received error 4201
 websocket:close status: 4201
 close status: 4201 `
I use Python 3.7.11 and pysher 1.0.4 with websocket-client 0.57.0.
What can I do to prevent my app from this error and the reconnect?

Errors 4200-4299 means Pong reply not received: ping was sent to the client by our cluster, but no reply was received. I'm suspecting this library is getting a bit old unfortunately, and isn't complying with our latest protocol.

We are seeing the same lately in our app too. Lots of 4201 events, but still haven't figured out what's the reason behind it.


Next13 appDir support

🚀 Feature Proposal
Next13 appDir support, make it work with react server component
Motivation
cannot use next-i18next when opening appDir feature
Example

https://github.com/i18next/next-i18next/discussions/1993


what results to keep producing block less than 12 in a node 。

Now， it work well.  reason is that  clock is out of sync.


Duplicate map id is only perform inside the same file

Here the code
 // Check to see if this is a duplicate map id, irregardless of src and dest class names.
      // Duplicate map-ids are not allowed
      if (!MappingUtils.isBlankOrNull(classMap.getMapId())) {
        if (mapIds.contains(classMap.getMapId())) {
          throw new IllegalArgumentException("Duplicate Map Id's Found. Map Id: " + classMap.getMapId());
        }
        mapIds.add(classMap.getMapId());
      }

If the mapId appears in an another file this check is useless, but nevertheless it works(if src/des class is different).
Maybe the test can be remove

@diorcety  ; is this still an issue? if so, can you create a github repo, that includes a unit test showing this behaviour and link it here.

Can't tell... i'm not working on that anymore.


Cannot recover from Math Processing Error

In this page and the code, when I remove a space as the following diff, the rendering for this code crashes and never recover even if I revert the change. Could you take a look?
  $$
  \frac{\pi}{2} =
- \left( \int_{0}^{\infty} \frac{\sin x}{\sqrt{x}} dx \right)^2 =
+ \left(\int_{0}^{\infty} \frac{\sin x}{\sqrt{x}} dx \right)^2 =
  \sum_{k=0}^{\infty} \frac{(2k)!}{2^{2k}(k!)^2} \frac{1}{2k+1} =
  \prod_{k=1}^{\infty} \frac{4k^2}{4k^2 - 1}
  $$

I have fixed this by https://github.com/falsandtru/securemark/commit/a9b51e6d87d5788cf677c7bf0d24097cbc7d6d56 by chance. Thanks.

Thanks for letting us know.  I was actually looking into it when you made your changes, and things started working for me unexpectedly.  So I was confused there for a while until I realized that the javascript had changed, and assumed you were making updates.
In any case, I'm glad you got it working.

Thanks for the response! FYI, you should still be able to repro this error using v0.19.0 and gulp view command. I felt MathJax has some wrong internal state.


Bug-Fix 3.11: WINDOW on OneShard

Scope & Purpose
*Serialization and deserialization of WINDOW Node in AQL was not working. This caused WINDOW to break on OneShard deployments *
Backport of: https://github.com/arangodb/arangodb/pull/19570

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[x] Tests

[x] Regression tests
[ ] C++ Unit tests
[] integration tests
[ ] resilience tests

[ ] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[x] Backport for 3.11: (Please link PR)
[x] Backport for 3.10: (Please link PR)
[x] Backport for 3.9: (Please link PR)

Related Information
(Please reference tickets / specification / other PRs etc)

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket: https://arangodb.atlassian.net/jira/software/c/projects/BTS/issues/BTS-1551
[ ] Design document:

The windows test issue is 100% unrelated and known


Dependencies have been renamed and no longer map correctly

worldcoin/world-id-example-airdrop does not exist.
Line
[submodule "lib/world-id-example-airdrop"]
	path = lib/world-id-example-airdrop
	url = https://github.com/worldcoin/world-id-example-airdrop

This airdrop repo no longer exists. Should probably be getting this stuff from world-id-contracts but the interfaces are all changed/renamed over there in newer versions.

Repo has been recreated, this should be fixed now :)


fix: update UI and Models

:tada: This PR is included in version 0.271.6 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Switch test backend enum to less type-system abusive version.

See discussion here: https://groups.google.com/forum/#!topic/julia-users/UPNpP91QGbE

Done.


A way to configure it to create folder by default

Hello.
Thank you for maintaining this fork.
I don't like the default behaviour of cloning to the current repository, I prefer it to always create a folder name, even if I don't provide one.
I think it will be useful to be able to configure this kind of things

I'm surprised I missed this feature request. This is indeed a very good idea.


Migrate documentation to Grails 3 for 2.0.0

PR follows

Be sure to do it against the 2.x branch. I can merge it up to master.

It would be good to include removing the section on Autobase and the discussion about the Searchable plugin from gettingStarted.adoc with this since both are quite dated and not applicable in 3.x


add unsafe method java.security.ProtectionDomain.getClassLoader

See
https://ackcent.com/blog/in-depth-freemarker-template-injection/

I close this, as it's not this simple to address this problem. Anyone interested in the status of this, see this: https://issues.apache.org/jira/browse/FREEMARKER-124

I know it is not simple to address, but it adds a quick fix to something many are exposed to. I agree that the trust level of template authors shall be as the level of source code writers, but from the file src/main/resources/freemarker/ext/beans/unsafeMethods.properties it seems that there are some blacklisted methods.
I understand that this list is not serious protection, but it will help some people that have made the mistake of trusting someone they shouldn't with a template.
Since this blog is out there, I would strongly recommend to add this method to the blacklist.

The recipe in that blog entry won't work anymore with the next release (2.3.30). But it's addressed differently (and some other methods will become banned as well).

Cool. Thanks!


Inheritence Hierarchy query and a potential feature request

Hi,
In the documentation regarding inheritance hierarchies, it states that searchable fields can only be declared on the top most class. I was wondering how this plays out when the base class is abstract and has properties.
I've got a case where I know I'm going to want to add several concrete types with the same properties so have abstracted them in to a base class.
I need to query on a property in of the base class and was wondering wht the best way of doing it was:
Firstly, extract this to it's own column, but then the question becomes how I tell Marten to use a custom data type.
or Improve Marten such that fields in base classes can be searches, but then I would like to know how I would do this and what would need to change.
Any help appreciated.
Cheers
Sean.

@SeanFarrow,
That's not quite accurate. At this moment, you can only specify indexes against properties or fields on the base class (but there's work coming soon to change that). You can happily query against anything in the subclass or the super class that you could normally with Marten. I don't think there's anything in Marten that needs to change for what you're asking for here.

@JeremyDMiller,
How soon is soon?
Ok, thanks.
How do I tell marten to use a datatype from another nuget package if I am creating a column for a specific field?
Cheers
Sean.
From: Jeremy D. Miller<EMAIL_ADDRESS>Sent: 20 August 2018 14:29
To: JasperFx/marten<EMAIL_ADDRESS>Cc: Sean Farrow<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [JasperFx/marten] Inheritence Hierarchy query and a potential feature request (#1073)
@SeanFarrowhttps://github.com/SeanFarrow,
That's not quite accurate. At this moment, you can only specify indexes against properties or fields on the base class (but there's work coming soon to change that). You can happily query against anything in the subclass or the super class that you could normally with Marten. I don't think there's anything in Marten that needs to change for what you're asking for here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/JasperFx/marten/issues/1073#issuecomment-414316535, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABY1ftDY1zGMIyK1H5d6fOwiY_oNZfDMks5uSrmagaJpZM4WD9qS.

@SeanFarrow All of that is documented in our website. You don't have to explicitly make any kind of searchable field upfront to be able to query on a field. What is it that you think is missing?

What I’m trying to do is create a column on a field that is of a type not natively supported by PostGres and the Npgsql provider, they provide a plugin for this specific type, so I was wondering how the extra columns are created, such that I can use an external type.
It’s one of the types from the Nodatime library for reference.
From: Jeremy D. Miller<EMAIL_ADDRESS>Sent: 20 August 2018 15:43
To: JasperFx/marten<EMAIL_ADDRESS>Cc: Sean Farrow<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [JasperFx/marten] Inheritence Hierarchy query and a potential feature request (#1073)
@SeanFarrowhttps://github.com/SeanFarrow All of that is documented in our website. You don't have to explicitly make any kind of searchable field upfront to be able to query on a field. What is it that you think is missing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/JasperFx/marten/issues/1073#issuecomment-414340469, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABY1fryHAQIXCv7f6_pi7-ygmQIGf05qks5uSsrhgaJpZM4WD9qS.

Meh, that's a bit of a different issue. If the Noda types can be serialized to JSON with Newtonsoft, you don't need to do anything else to add any kind of field to a Marten-ized database. If you want to search on the NodaTime data elements, I don't know. You'd have to teach Marten's Linq provider how to interpret that.

There's an open issue somewhere about adding NodaTime support to the Linq provider, but nobody has taken it up yet

Ok, and how extensible is the linq provider. I’m happy tro do the work and potentially produce an add-on/plugin.
From: Jeremy D. Miller<EMAIL_ADDRESS>Sent: 20 August 2018 15:52
To: JasperFx/marten<EMAIL_ADDRESS>Cc: Sean Farrow<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [JasperFx/marten] Inheritence Hierarchy query and a potential feature request (#1073)
Meh, that's a bit of a different issue. If the Noda types can be serialized to JSON with Newtonsoft, you don't need to do anything else to add any kind of field to a Marten-ized database. If you want to search on the NodaTime data elements, I don't know. You'd have to teach Marten's Linq provider how to interpret that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/JasperFx/marten/issues/1073#issuecomment-414343998, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABY1fiWDhAmirR8WVyo8QMsp65K6P2Wqks5uSs0LgaJpZM4WD9qS.

Yep, I’ve just found it and commented, so feel free to close this.
From: Jeremy D. Miller<EMAIL_ADDRESS>Sent: 20 August 2018 15:52
To: JasperFx/marten<EMAIL_ADDRESS>Cc: Sean Farrow<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [JasperFx/marten] Inheritence Hierarchy query and a potential feature request (#1073)
There's an open issue somewhere about adding NodaTime support to the Linq provider, but nobody has taken it up yet
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/JasperFx/marten/issues/1073#issuecomment-414344205, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABY1ft-0hLrNb6AsofOVyIAyeuqy2Jwfks5uSs0mgaJpZM4WD9qS.


Todo list

Following things need to be done before publishing the code:

[ ] Single pre-release script
[ ] Tutorial of deployment
[x] Hard-coded value cleaning
[x] Package reform

Consider this a personal service, currently there is no plan of open source.

Not going to fix.


fix docker warnings

What type of PR is this?
/kind bug

What this PR does / why we need it:
When doing docker build . I was seing a few warnings in the Dockerfile. When using buildah to build the container it was actually failing. This fixes all warnings and builds images without any errors.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
This is almost identical to the kueue docker file.
Does this PR introduce a user-facing change?

NONE

/hold

/hold cancel

/lgtm
/approve


About Page QA Items

-- Desktop --

Throughout page - horizontal rules appear too thick. Should be 1px (see homepage for guidance) - screenshot for example: https://www.dropbox.com/s/2onc7fpfzl1ex7b/Screen Shot 2020-09-25 at 5.04.59 PM.png?dl=0 - 2
Secured by Participants - update copy to "The Mina network is secured by an uncapped number of block producers via proof-of-stake consensus. A uniquely decentralized blockchain, Mina gets even more secure and resilient as it grows." - 1
That's why we created Mina section - Add back in the link for "powerful applications" to link to Snapps in the docs; also orange color seems different from design, see screenshot: https://www.dropbox.com/s/ozbs7kistpxbwnc/Screen Shot 2020-09-25 at 5.12.04 PM.png?dl=0 - 2
You can run a node section - body copy leading needs to open up - screenshot: https://www.dropbox.com/s/j6kgryxqtbr9sr7/Screen Shot 2020-09-25 at 6.03.43 PM.png?dl=0 - 2
Naval quote - Hang the apostrophe around his quote - 2
Team bios - ship the bios opening functionality (the + signs) - 2
Investors - background image looks blown up, refer to design - 2
Most sections don't appear to be center within the browser, right margin appears wider - 1
Team - Update Bijan's job title to "Head of Product" - 1

-- Mobile --

Header - headline type size is incorrect, see screenshot: https://www.dropbox.com/s/133pux7grwerr0a/IMG_2036.PNG?dl=0 - 2
It's time to own our future - headline type size is incorrect, see screenshot: https://www.dropbox.com/s/ua059ieerwccchj/IMG_2037.PNG?dl=0
It's time to own our future - link in body copy is hard to see against orange background, maybe move the gradient out from center a bit, see screenshot: https://www.dropbox.com/s/v2mndykagdaz9rk/IMG_2038.PNG?dl=0 - 2
You can run a node & secure the network section - "Get Started" CTA button is outside the container, see screenshot: https://www.dropbox.com/s/amtmy33uw8sal8l/IMG_2042.PNG?dl=0 - 2
Secured by participants section - too much space between illustrations and rule that is below, see screenshot: https://photos.app.goo.gl/oNynfUgvAGupbP1F9 - 2
Genesis Members section - too much space between the subhead and the photos of the GFMs, see screenshot: https://photos.app.goo.gl/cC6YTqZ5ukw1M6bB7 - 2
Secured by Participants section - update both "XXXX"s to "100s" and change "SNARK Workers" to "SNARK Producers"

-- Desktop --

Throughout page - horizontal rules appear too thick. Should be 1px (see homepage for guidance) - screenshot for example: https://www.dropbox.com/s/2onc7fpfzl1ex7b/Screen Shot 2020-09-25 at 5.04.59 PM.png?dl=0 - 2
Secured by Participants - update copy to "The Mina network is secured by an uncapped number of block producers via proof-of-stake consensus. A uniquely decentralized blockchain, Mina gets even more secure and resilient as it grows." - 1
That's why we created Mina section - Add back in the link for "powerful applications" to link to Snapps in the docs; also orange color seems different from design, see screenshot: https://www.dropbox.com/s/ozbs7kistpxbwnc/Screen Shot 2020-09-25 at 5.12.04 PM.png?dl=0 - 2
You can run a node section - body copy leading needs to open up - screenshot: https://www.dropbox.com/s/j6kgryxqtbr9sr7/Screen Shot 2020-09-25 at 6.03.43 PM.png?dl=0 - 2
Naval quote - Hang the apostrophe around his quote - 2
Team bios - ship the bios opening functionality (the + signs) - 2
Investors - background image looks blown up, refer to design - 2
Most sections don't appear to be center within the browser, right margin appears wider - 1
Team - Update Bijan's job title to "Head of Product" - 1

-- Mobile --

Header - headline type size is incorrect, see screenshot: https://www.dropbox.com/s/133pux7grwerr0a/IMG_2036.PNG?dl=0 - 2
It's time to own our future - headline type size is incorrect, see screenshot: https://www.dropbox.com/s/ua059ieerwccchj/IMG_2037.PNG?dl=0
It's time to own our future - link in body copy is hard to see against orange background, maybe move the gradient out from center a bit, see screenshot: https://www.dropbox.com/s/v2mndykagdaz9rk/IMG_2038.PNG?dl=0 - 2
You can run a node & secure the network section - "Get Started" CTA button is outside the container, see screenshot: https://www.dropbox.com/s/amtmy33uw8sal8l/IMG_2042.PNG?dl=0 - 2
Secured by participants section - too much space between illustrations and rule that is below, see screenshot: https://photos.app.goo.gl/oNynfUgvAGupbP1F9 - 2
Genesis Members section - too much space between the subhead and the photos of the GFMs, see screenshot: https://photos.app.goo.gl/cC6YTqZ5ukw1M6bB7 - 2
Secured by Participants section - update both "XXXX"s to "100s" and change "SNARK Workers" to "SNARK Producers"

it is 1px. unfortunately can't go further down than that


Provide an option to not publish results as a GIthub comment

There should be an option for this action for not publishing results as a Github comment.

Resolved in https://github.com/insightsengineering/bioc-check-action/pull/6


How is Eel loading HTML when there is no HTML file, as if its caching

Haroons-MacBook-Pro:eel ironbrotherz$ ls -l
total 16
-rw-r--r--@ 1 ironbrotherz  staff   73 Nov  7 17:56 buy_card.py
-rw-r--r--@ 1 ironbrotherz  staff  334 Nov  7 17:44 index.py
Haroons-MacBook-Pro:eel ironbrotherz$ cat buy_card.py
import eel

eel.init('web')
eel.start('buy_card.html', size=(1024, 768))
Haroons-MacBook-Pro:eel ironbrotherz$ python buy_card.py

Then a window opens and displays my old buy_card.html page without any styling.  The point is that I deleted my web directory with its others subfolders for css/js/images and somehow its still loading that page.  The issue was that I had my script load index.html and in that web page I have links to local html pages.  When I clicked a button in index.html it loaded my next local page but it was not displaying the updated version of that page after I edited some text.  I was confused so I started deleting stuff and Eel is somehow still opening up stuff that does not exist. I edited the eel script to load buy_card.html which doesnt exist as its been deleted and its still loading the page somehow.

Chrome might be caching it. If you bring up the dev tools with right click -> inspect element, go on network tab, you can tick Disable Cache. Then press CMD+R to reload, see what happens.
Either that or you have another instance of python still running

What you suggested seems to have fixed the issue. Thank you so much for such good support.


1.0.0 compatibility

The updates were merged and we have a bit of fixing to do.

We just did an RC3 as well
https://github.com/json-api/json-api/issues/484

I have a PR open for 1.0.0-rc.3 compatibility, but it's not fully there yet and I'm running low on time for working on it (and I don't have an active project using it).
The changes between the final and RC 3 are not that large, but the changes between RC 1 and RC 2 are.

If you have some spare time you can have a look at this branch - https://github.com/canufeel/drf-json-api/tree/nested-null-relationships i have spent some time working on it to support 1.0 "links" support is not there yet but it does a nice job to support "data" and "relationships" as well as "attributes" correct field names and model names. It also has support for nested serializers populating the "included" key value. However i believe it still needs a lot of work.


Using the Empty Corner of the Chart

What would be the best way to reuse this corner?
Most use case would be a context menu button.
another would be scroll to realtime ,
under inspection, the corner is nested under
#chart > div.tv-lightweight-charts > table > tr:nth-child(2) > td:nth-child(3) > div > canvas

So please offer your ideas.

In some cases this corner used to draw "connection pixel" for time and price axises' borders. Also, this "corner" is only when price axis is enabled, also it can be at the left of the chart.

Humm,  if enabled, and on left and right, without blocking the connection pixels....
do you think it would be a good idea if there was an api to write some text or blob/base64 png icon to draw on that canvas with a mouse click event?
or should i somehow alight a  over it

or should i somehow alight a  over it

I believe it already can be done somehow :)

do you think it would be a good idea if there was an api to write some text or blob/base64 png icon to draw on that canvas with a mouse click event?

Interesting... Let's wait some feedback and other suggestion for that place.

It seems that no one needs this so far, so I'm going to close the issue. If someone would have any idea - please ping me here with your thoughts.


feat(api)!: rename color functions

This renames two functions to be more idiomatic, in line with 0.2 API changes.

theme_from_source_color replaced with Theme::from_source_color
custom_color replaced with CustomColorGroup::new

Both are breaking.

Yes, I've been thinking about it too. Thanks!


Is there a description of the algorithm in a document/publication?

I might use pianoplayer in one of the intermediary steps in my master thesis. So, I was wondering whether its methodology is documented somewhere so I can give a proper description of the logic behind it, and also to properly cite it :)
Thanks!

Dear Alia
Thanks for the interest in the software, you can cite it as:
M. Musy, "pianoplayer, an automatic fingering generator for piano scores" (Version 2.1.0). Zenodo. http://doi.org/10.5281/zenodo.3376237. 2019, August 23.
The superficial algorithm description is given in readme:

The algorithm minimizes the fingers speed needed to play a sequence of notes or chords by searching through feasible combinations of fingerings.
One possible advantage of this algorithm over similar ones is that it is completely dynamic, which means that it takes into account the physical position and speed of fingers while moving on the keyboard and the duration of each played note. It is not based on a static look-up table of likely or unlikely combinations of fingerings.

So the algorithm basically loops over feasible combinations of finger sequences and finds the one that. at any given point in time, minimizes the average speed of the sequence of the future notes still to be played.
The length (search depth) of this sequence can be specified.
Such greedy search is possible because there's a number of combinations that can be ruled out from start (e.g. the 3rd finger crossing the 4th on a fast note).
Chords are dealt with by splitting the chord into a normal ascending rapid sequence of notes.
The algorithm in spite of its simplicity (the core of the python code is only 250 lines) can often yield surprisingly good fingering combinations, and to be fair sometime some very bad result too! :)
I hope I'll find soon some spare time to improve on some aspects and update the graphics rendering.


Prometheus: TLS certificate does not contain IP SANs

What version of descheduler are you using?
descheduler version: v0.26.0
Does this issue reproduce with the latest release? yes!
Which descheduler CLI options are you using?
      - args:
        - --policy-config-file
        - /policy-dir/policy.yaml
        - --descheduling-interval
        - 5m
        - --v
        - "3"
        - --leader-elect=true
        - --leader-elect-lease-duration=15s
        - --leader-elect-renew-deadline=10s
        - --leader-elect-retry-period=2s
        - --leader-elect-resource-lock=leases
        - --leader-elect-resource-name=descheduler
        - --leader-elect-resource-namespace=kube-system
        command:
        - /bin/descheduler

Please provide a copy of your descheduler policy config file
N/A
What k8s version are you using (kubectl version)? v1.24.12
What did you do?
Let Prometheus scrape metrics from the descheduler.
What did you expect to see?
A TLS certificate that allows Prometheus to scrape metrics would be nice.
What did you see instead?
The descheduler creates a TLS certificate that does not include an IP address, causing Prometheus to refuse to scrape even when instructed to skip TLS verification:
Get "https://<IP_ADDRESS>:10258/metrics": x509: cannot validate certificate for <IP_ADDRESS> because it doesn't contain any IP SANs

Looks like adding the Pod IP address would be sufficient. However, I am aware that IP address auto-detection might be tricky if the Pod has multiple interfaces attached (e.g., with Multus). Solutions could be

Resolve own Pod IP address through kube-dns
Use the Kubernetes Downward API and a command line argument to pass the IP address

Still an open issue …

/remove-lifecycle stale

Just ran into this as well.  Something that I was just wondering is why is the descheduler serving over HTTPS in the first place?  As best I can tell, there's just the metrics endpoint that is being served, which is unlikely to be exposed publicly.  Even if it is, all connections to it would fail as the provided TLS cert won't be valid...?
Is there a way to actually have prometheus scrape these metrics?  How are people collecting these metrics in a meaningful way?


New (Comfy-only) auto-segmentation-detailer! aka, "ADetailer"++

Hi, I got an error when I tried to use this function: ComfyUI execution error: expected str, bytes or os.PathLike object, not NoneType.
My usage is to fill in the end of the prompt directly: <segment:girl's face>
Also, a photo of a woman standing in the street smiling segment:yolo-face_yolov8m-seg_60.pt-1 a beautiful woman's smiling face, it works for me.
What's wrong?

This repo is way out of date. The new version of (now called) SwarmUI, is located here.. This version is no longer maintained. You need to install the new version.
Also join the discord to get find the entire Swarm community.. https://discord.gg/XDGYCWBG
https://github.com/mcmonkeyprojects/SwarmUI

Thank you. Actually I have already got the new version. Does the current version support this detailer?

This repo is way out of date. The new version of (now called) SwarmUI, is located here.. This version is no longer maintained. You need to install the new version.这个仓库已经过时了。新版本的（现在称为）SwarmUI，位于此处。该版本不再维护。您需要安装新版本。
Also join the discord to get find the entire Swarm community.. https://discord.gg/XDGYCWBG还可以加入不和谐来找到整个 Swarm 社区.. https://discord.gg/XDGYCWBG
https://github.com/mcmonkeyprojects/SwarmUI

Thank you. Actually I have already got the new version. Does the current version support this detailer?

Yes, there's a few ways you can do it but the most practical (imo) is with segmentation, type out your prompt as normal and then add something like this..
segment:face a beautiful hd photo of a woman's face
or as you did it it like this
segment:yolo-face_yolov8n-seg2_60.pt a beautiful woman's smiling face

@samliu315 let me know if you need anymore help. I’m signing out for the evening but your welcome to swing by the Discord and post there. Tag me if you do @southbayjay


Play youtube video inline.
Actual Behavior
What behavior did you actually see?
If I play the video, the video only plays in fullscreen mode. I have read on the Internet that adding playsinline should solve this issue but I don't see how to set this property in the youtube-player component.
Environment

Angular: 8.0.0
CDK/Material:8.2.0
Browser(s): Safari
Operating System (e.g. Windows, macOS, Ubuntu): iOS

It looks like you can pass in the playsinline value yourself through the playerVars input (see the docs). I'll close the issue since we try to avoid deviating from the default values when the user has the ability to change it themselves.

Hi @crisbeto, Could you give me an example of how can I pass the playsinline property in the youtube-player component? Please


Update telegram-alpha to 3.8-117736,915

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Verified locally.


Opentecture Bookmarks View-a-line R4.3 is up

@opentecture/owners
Demo: Opentecture Bookmarks View-a-line R4.3

Project: Opentecture Bookmarks Read Me
Script: Opentecture Bookmarks View-a-line Read Me
Concept
This script is a side project of the gbXML to JSON Lines project.
It is a work-in-progress continuation of exploring, manipulating and hacking the JSON Lines file format in unusual, useful and fun ways.
Objectives

Access very large numbers of bookmarks
View contents of many sites in a speedy fashion
Categorize and tag bookmarks with ease and speed
Speed up identification with descriptions added on-the-fly
Curate the output using comments

Features include:

Read JSON Lines files created by Opentecture Bookmarks Add-a-line
Display tree menu of bookmarks with HTML details elements
For every bookmark allow

Display web page in an iframe
Open web page in new tab
Edit bookmark json

Save edits to new file / Open local file for testing

To Do / Wish List

2019-02-17 ~ Replace all date references with UTC strings
2019-02-17 ~ Replace 'tags' with 'categories'
2019-02-12 ~ Turn titles of things like university names to links to suitable page
2019-02-11 ~ Add ability to do screen capture of pages and save / save to Imgur? for reuse instead of iframes

Notes

Best to have the JavaScript console open so you can view the errors. There are many issues still to be dealt with in displaying web sites in iframes

Also iframes issues with HTTP/HTTPS are different depending on whether you are running locally or on a sever

After editing a JSON bookmark, you must save to a file and then reload the page. Future release will be more convenient.
Be sure to create and keep back up files of the data files
Tags currently being used as catagories. This will change
Does not yet handle file not found errors well
Comments, adding new bookmarks will happen in future releases

Issues

handle CORS and other iframe errors better

Be sure to create and keep back up files of the data files

This step is the step where the experience as designed broke down for me.
I managed bookmarks in a browser. I don't want to get another repo up and running to manually enter bookmarks into it, then to re-save a .json file.
What is the Goal and/or Acceptance Criteria of this issue?


[WIP]: Why are the tree traversal methods not equal?

This was created as a result of a private discussion with @sschuberth .
This code implements a TraverseDepsFunTest.kt , that tests two different implementations for traversal of the dependency trees of all projects of a ortResult, but for the real world example

they are not equal and
neither catches all the dependencies

At some point this code might be worth to be moved to a better location, to be added as an actual test.

Type 1 tree traversal for example misses the following two packages:

was resolved


Fix comparison

Could you elaborate? What does this do? What does this fix?

The fix seems correct, but indeed the commit message and PR title should be made more explicit about what this does.
For example, "macOS export: Fix validation of codesigning certificate password".

Also agree with @akien-mga this looks fine barring the commit message. If you no longer want to update this PR do let us know and we can sort out the fix. :+1:

Thanks!

Cherry-picked for 4.0.3.


document PartialOrd difference to simd_min and simd_max

Avoids a migration pitfall from packed_simd as described in #402.
This adds a single line of documentation, no code change.

can you add it for Ord too?

@programmerjake Good point! Added the comment for Ord as well.


[two_dimensional_scrollview] The default scroll experience is different from one dimensional scrollview

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case
Hello, all:
Recently I'm trying to implement the two-dimensional scrolling experience by using the sample code from Here.
And I found that the scrolling experience is kind of different from one-dimensional scrolling.
Here is a video. Seems during scrolling the user's gesture is ignored. I'm not sure is it by design or it might have attribute somewhere I can override this behavior.
https://github.com/flutter/flutter/assets/107196519/2c57de1a-d0be-47e7-987e-acfb89aeeca9
Environment
Flutter 3.13.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision<PHONE_NUMBER> (7 days ago) • 2023-09-06 14:32:31 -0700
Engine • revision b8d35810e9
Tools • Dart 3.1.1 • DevTools 2.25.0

Proposal
What I'm expected is that it can accelerate the speed during scrolling just like the one-dimensional scrollview.

Hi @ZhiwenLuoAllIn. this is a known issue and is being tracked in https://github.com/flutter/flutter/issues/133529.
Kindly follow up in the original issue for updates.
Closing from here as duplicate.
Thank you


⚠ Bofrost.nl has degraded performance

In 316300d, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1304 ms

Resolved: Bofrost.nl performance has improved in 0025fb2.


Harpoon menu is filled with __harpoon-menu__number

Every time I open my Harpoon menu, it is randomly filled with '__harpoon__menu' followed by a random number. Trying to delete them using 'dd' will erase them temporarily, but when it reopens, they are filled again. Also adding a file to the harpoon buffer will also be place randomly alnogside those harpoon-menus


OPL3 waveform 7 (derived square) doesn't seem right

I've been doing some experimentation with using ymfm for OPL3-based MIDI playback. So far almost everything sounds great, but I've noticed an issue where waveform 7 sounds noticeably different than it should, whether it's being used as a carrier or a modulator.
I recorded a simple "1-operator" test patch using Nuked-OPL3 (via Wohlstand's patch editor) and my own ymfm-based application for comparison:

(Nuked on the left, ymfm on the right)
https://revenant1.net/opl3-dsq-nuked.ogg
https://revenant1.net/opl3-dsq-ymfm.ogg
It's especially apparent for patches that use it as a modulator, since the difference can have a pretty drastic effect on whatever other operators are involved.

Thanks for the report. Yes, my implementation of the derived square was on the list of things to revisit since I know it's probably pretty wrong. Since someone has now discovered my inadequacy 😉, I shall pop it to the top of the list of things to look at.

Quick check. Can you change line 99 of ymfm_opl.cpp to this:
wf7[index] = (bitfield(index, 9) ? (index ^ 0x13ff) : index) << 3;
and let me know if that works better?

Yeah, that sounds much better. Thanks for the quick response!

Great, I'll commit it.


Meaning of the output files of daric normalize, and link with daric runhmm

Hello,
I successfully run daric normalize, and I would like to run daric runhmm.
However, I do not know which files I should use for the -f, --deltaPIS parameter.
Namely, daric normalize produced several files, and I guess I should use one, or two of them.
Would it be possible to provide the list of commands that you used in your article?
The files that daric normalize produced are:

cond1-vs-cond2_cond1_avg_PIS.bedGraph
cond1-vs-cond2_cond2_avg_PIS_before-norm.bedGraph
cond1-vs-cond2_deltaPIS.before-norm.bedGraph
cond1-vs-cond2_deltaPIS.bedGraph
cond1-vs-cond2_cond2_avg_PIS_after-norm.bedGraph
cond1-vs-cond2.txt
cond1-vs-cond2_background_distribution_for_delta-PIS.png
cond1-vs-cond2_p-value.bedGraph

Moreover, I do not know the meaning of these files.
Would it possible to give a short description?
Last, the file cond1-vs-cond2_p-value.bedGraph, which should contain p-values in the 4-th column, has values greater than 1, which is unexpected for p-values.
Are they p-values, or maybe -log of p-values?
Thanks again.

Great to know that you have successfully run daric normalize. For 'runhmm', please use 'cond1-vs-cond2_deltaPIS.bedGraph' for the '--deltaPIS' parameter.
p-value in the 'cond1-vs-cond2_p-value.bedGraph' file is the -log10P-value.
Will add a description for those files soon in the documentation. Thanks!

Dear @ykai16
I wish you all the best for 2024.
I tried to start runhmm with the file you suggested, yet, I had another error:
File "[...]/hmmlearn/base.py", line 799, in _accumulate_sufficient_statistics_log
    stats['start'] += posteriors[0]
IndexError: index 0 is out of bounds for axis 0 with size 0

I could not understand why the posteriors have not been set.  I could share the file if you need.
Thanks again!

Hi @mzytnicki , could you share the full error message you got and the files you used for running ruhmm?

Sure, thanks!
You can find the files here: https://filesender.renater.fr/?s=download&token=7450d74a-23eb-4d17-81a6-1df43993edb5
(they will be available 2 weeks).
You have the bedgraph, and the error output file.
The command was:
daric runhmm -n es_vs_npc -f es-vs-npc_deltaPIS.bedGraph --reso 100000 --species mm10 --outdir results

Hi, just fixed the issue and pushed a new version v0.2.20 to pypi. Please uninstall daric and install it again using pip with the command "pip install daric". Let me know if there are still problems around.

Works like a charm, thanks!


Execute.launch_simulation does not check current ExecuteList status

If we call Execute.prepare_simulation_input, and then Execute.launch_simulation, we get an error that the scenario is still in 'created' state, not prepared. But if we call prepare_simulation_input, then print_scenario_status, then launch_simulation, everything works well. It seems print_scenario_status checks the latest ExecuteList status on the server (updating the current Scenario object accordingly), while launch_simulation does not. This step is easy to work around, but confusing to encounter.
Potential fixes:

prepare_simulation_input automatically updates the Scenario status to 'prepared' after completing all other tasks
prepare_simulation_input checks for the latest ExecuteList status after completing all other tasks
launch_simulation always checks for the latest ExecuteList status before checking that it is prepared
launch_simulation checks for the latest ExecuteList status if we think we are in 'created' (single-shot try/except)

Traceback:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-15-6923503eddff> in <module>
----> 1 scenario.state.launch_simulation(threads=num_threads)

c:\python38\lib\site-packages\powersimdata\scenario\execute.py in launch_simulation(self, threads, extract_data)
    227             process (if using ssh to server) or http response (if run in container)
    228         """
--> 229         self._check_if_ready()
    230
    231         if threads:

c:\python38\lib\site-packages\powersimdata\scenario\execute.py in _check_if_ready(self)
    172         valid_status = ["prepared", "failed", "finished"]
    173         if self._scenario_status not in valid_status:
--> 174             raise ValueError(
    175                 f"Status must be one of {valid_status}, but got status={self._scenario_status}"
    176             )

ValueError: Status must be one of ['prepared', 'failed', 'finished'], but got status=created

Closed via #378

Closed via #378


add operation annotation

fixes issue #793

It's my first (big) enhancement PR to go-swagger, so might need some extra feedback before this can be merged in @casualjim.

Once this feature is merged in, #790 can probably be closed as well.

Current coverage is 69.26% (diff: 66.36%)

Merging #815 into master will increase coverage by 0.22%

@@             master       #815   diff @@
==========================================
  Files            19         21     +2
  Lines          5624       5737   +113
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           3883       3974    +91
- Misses         1358       1366     +8
- Partials        383        397    +14

Powered by Codecov. Last update e63b284...0b75010


@conda-forge-admin, please add bot automerge

Additional comment:
No response

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/types-aiobotocore-lambda-feedstock#3.


Container logs module

Many thanks to @KLINGTdotNET in #43 for doing the work. After the big refactoring their PR wasn't auto-mergeable so I put that work into the new module format.

I've been running container for about two months, logs are huge, logs page loads too slow.
Let's say, I want just last 2000 lines
How it is possible to limit log output? docker 1.3 includes --tail=count_lines_to_show
I can and willing to contribute, how log output limit should work? A settings maybe?
I suggest default log limit to last 2000 lines

I think the easiest way would be to default to 2000 and expose the tail option on the logs page to let people change it.

what is the easiest way to create dev enviroment? this wasn't mentioned in readme
is grunt build enough?
i've got web part working, but it can't connect to docker api

https://github.com/crosbymichael/dockerui/pull/77


Codecov

WIP

@FabioLuporini should be mergeable now. Basically like numpy target to 1% coverage so that it passes but still part of CI, and removed patch (doesn't really add much). Should be around 90% most of the time unless upload failures

merged


Added the focusFirstInput option

Any update on this? I think this functionality would hep people having trouble with the inputs on the first elements. :)

I think my latest commits into master changed too much stuff...
Could you please try to solve the conflicts and also have a look within the new iron-routing pacakge?
See here

Done! Tnx


connection::Connection should transmit the Error packet

Right now it just uses the Error packet to create an io::Error. It'd be best to transmit the courtesy Error packet before returning the io::Error.
Do this for put and get.

Hi, I'm interested in working on this. To clarify, do you want to send an Error packet on io::{Read, Write} errors?

Hi @PurpleMyst! Thank you! 🙂

To clarify, do you want to send an Error packet on io::{Read, Write} errors in the given reader/writer?

No, we want to send the packet over the UDP socket, not the Read or Write objects. Depending on whether we're talking about get or put:

The Read object is the data we are sending over the socket. So we read from the Read object, create a packet, and send it.
The Write object is the place where we store the data that we receive. So we read from the socket, take the data out of the packet, and use the Write object to save it.

Right now, get will attempt to parse an Error packet if it failed to parse a Data packet it's expecting. If parsing the Error packet fails, then it returns early with an error.
Likewise, put will attempt to parse an Error packet if it doesn't parse the Ack packet it's expecting. If parsing the Error packet fails, then it returns early with an error.
For this issue, I don't want it to return early without sending an Error packet to its peer. That is:
IF we fail to parse the packet we're expecting AND we fail to parse an Error packet, that means we've received a packet that doesn't make sense and the connection should not continue. In this case, we will create an Error packet, send it to the peer, and then return an error.
Does that help any?

Understood. So my PR is totally unrelated to this issue, but does fix another issue. Should I tack on this change to my already-existing PR or create another one?

A separate PR would be best. Thanks! 🙂

Alright, I've unlinked #41 from this issue and created a new, linked, pull request numbered #43
The two are independent from eachother, so you can pick and choose when and if to merge them :)


[synthetic-minion] set MINION_PRIVATE_LOCATION_KEY from value or from secret

What this PR does / why we need it:
this will allow for more flexible deployments, as some people will call
helm directly with their secrets as values and others have automation
and will manage their secrets via other means.
Which issue this PR fixes

fixes #195

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [mychartname])

@Philip-R-Beckwith @sshah-nr @vkasanneni-nr @cleon-nr

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Verify the NULL_ACCOUNT works as specified

This account is supposed to have no possible way of passing an authority check.
The authority object should probably be able to represent:
always, never, and conditional (default).
I think a weight of 0 should represent "ALWAYS"
I think a weight > 1 with 0 keys, 0 accounts, and 0 addresses should be NEVER.

Also need to check that the TEMP_ACCOUNT can't change its authority.

Null account should be configured with a public key for which there is no private key.  This way we can avoid any special case logic.

The null account has a weight of 1 but no keys or child accounts which means it is impossible to reach the threshold.

Why is creating an account with an impossible authority threshold forbidden?

What is the reason to forbid people from using authority weights to "brick" an account?  I do not see any reason to prevent this at the blockchain level.  We've previously discussed that what I call autonomous accounts (a "bricked" account which has signed at least one proposed transaction) may be a useful primitive.
I am also aware there is at least one coin (I forget which one) that performed its genesis distribution to those who sent Bitcoins to a specific bricked Bitcoin address.  Being able to create a bricked account other than the null account would also be useful in case someone wants to do a similar thing on a Graphene-based blockchain.

I am also aware there is at least one coin (I forget which one) that performed its genesis distribution to those who sent Bitcoins to a specific bricked Bitcoin address. Being able to create a bricked account other than the null account would also be useful in case someone wants to do a similar thing on a Graphene-based blockchain.

Counterparty did a so called Proof-of-Burn:
http://counterparty.io/news/why-proof-of-burn/
The corresponding address was 1CounterpartyXXXXXXXXXXXXXXXUWLpVr

You can create a bricked account by adding the NULL_ACCOUNT as the required account authority.   This makes creating a bricked account for special purposes explicit and prevents accidental bricking of an account.


More granular stat change signals

Any reason for these signals? I don't mind new code but it should have a reason ideally x3

My use case is I've got a status effect (being hypnotized) that I knock stacks off of when the character gets punched. Other examples... Well, a traditional one is charging some sort of rage meter when taking damage? You could have some perk that automatically uses an energy drink when your stamina drops too low?

Perks/status effect don't really have access to signals, I do everything through just functions. I treat signal as something internal. Core game code can use them but high-level objects like perks shouldn't really.

That's a shame. Signals seem more modding-friendly from what I've seen so far, since you only need access to the instance to hook into them rather than having to rewrite the function itself to call modded code. That being said, I can work around it in this case anyway, so...

thankies


fix base_uri, close #3003

fix #3003

As the tests indicate, this is not a bug, but the proper behaviour, and this change is wrong.


Add SoudenMVDR module

Add a new design of MVDR module.
The SoudenMVDR module supports the method proposed by Souden et, al..
The input arguments are:

multi-channel spectrum.
PSD matrix of target speech.
PSD matrix of noise.
reference channel in the microphone array.
diagonal_loading option to enable or disable diagonal loading in matrix inverse computation.
diag_eps for computing the inverse of the matrix.
eps for computing the beamforming weight.

The output of the module is the single-channel complex-valued spectrum for the enhanced speech.

Docs: https://output.circle-artifacts.com/output/job/ea1e9c6d-ddf0-4a92-8070-f03a67187951/artifacts/0/docs/transforms.html#soudenmvdr


Improve Docs

use and contribute to open source projects. =use and contribute to open-source projects.
1st to 31st October, 2020. =1st to 31st October 2020.
Issues page is just for your reference. You are encouraged to submit implementation of your choice of algorithm in any programming language.
The issues page is just for your reference. You are encouraged to submit the implementation of your choice of the algorithm in any programming language.
mkdir open_source =made open source

Doing unnecessary update to existing content will be considered as spam.I have reported you. Its better you start working on the issues section.


Unable to process chalkboard writings

Hey guys,
First of all I wanted to say thanks for the continued work on this! It's real cool and me and a friend are using it for a school project. However, the issue we're running into is that it doesn't seem to be able to process the below image, and instead returns an empty text file.
Here's the image we're trying to read:

And here's the error we're getting:

Any suggestions as to what we can do to try and achieve this goal of processing text, numbers, and symbols on a chalkboard?
Thanks for the help,
Thomas
P.S. It works well with other images such as this:

So is the issue that the chalkboard writing has too much noise?

Hi Thomas,
convert 468.jpg  -bordercolor black -border 20x20 468-b.jpg
tesseract 468-b.jpg - -psm 11

I+I
2+2m

For further questions, please use the forum.


Organization and/or website

What about make this an organization? I'm about to create a draft for a Jekyll website, say a lite-xl.github.io repository, it could be nice if it will work on a lite-xl GH organization.

I would love to have a website, I just didn't have time to setup this properly. If you want to work on that you are welcome.
As for the organization I think it is a good idea. I may try to setup this to include all the current contributors. I guess we just need to find a good icon but it may be the icon of lite-xl itself through this maybe inappropriate because it is really rxi lite's original icon.

I've been thinking about that too, the project is maturing little by little and it would be great to have a website to promote it :)

I just did a draft (unfortunately ATM it won't work for some reason) as preview and to be transferred later once someone better than me with web design will work on the style and some TODO replaced by useful content. I used the current icon too for the site, it can be replaced later on, same for the Apache 2.0 license.

The truth looks super good and is very responsive (I'm on mobile) :)

@franko, would you agree to move the files from the /doc directory and part of the README to the site, redirecting to the latter for details?

I decided to take a shot at designing a logo for Lite XL, to help differentiate the project from vanilla lite:

The L stands for Lite of course, and the arrow is meant to represent the XL-ness - our improvements added to regular lite. It uses colors from the default color scheme, I think they work together pretty well for things beyond just code.
What are your thoughts on this design? I can send over the SVG/gvdesign file, and will also design a monochrome version based on the colored one later, after I receive some feedback on this.

@liquidev I like your design, it is quite minimalist. Only the corners of the triangle that are close to the rounded corners of the L make me noise.
I was making one too, don't kill me 😅. Anyway I show you:

I was making one too, don't kill me sweat_smile.

Looks really nice I can already imagine it on my launch bar xD

I just did a draft (unfortunately ATM it won't work for some reason) as preview and to be transferred later once someone better than me with web design will work on the style and some TODO replaced by useful content. I used the current icon too for the site, it can be replaced later on, same for the Apache 2.0 license.

Thank you @redtide, I like it too. To me now it is very important to put there useful contents for people using lite-xl.
As I have little time I propose to give you @redtide the responsibility for the website. This would mean that you should listen to the users and contributors but at the end you can decide and proceed publishing the website and the content. I you need additional administrative privileges I'll give them. I can give the same privileges to other contributors as well, just ask if you want.

I propose also that you @liquidev take the ownership of the graphical design aspect so I leave to you to decide about the icons but you can decide also about other graphical design aspects as well, both for the website and the application itself.
Otherwise I like both icons but if you agree @liquidev it will be up to you to decide!

For the code @liquidev, @adamharrison and @ŧakase1121 are already the main code contributors. I think you already have the right of directly pushing the code into the master or dev branch so may leave this as it is.
I expect non trivial modifications to be discussed in PR.
Otherwise I propose to @adamharrison that you take in charge the responsibility of bringing the regular expression stuff into the master branch. I propose that you also transition the syntax highlight system to use the regular expressions as well.

@Atreyu-94 looks good, I wouldn't mind if @liquidev could make a mix of the 2 if he agrees, like placing the "L" in place of the arrow and the X in place/inside the square, or something (just an example, I'm not the right person with gfx 😄 )
@franko thank you very much for your trust, delegate work to people is not trivial task as it seems. The only thing I ask for now if possible is to transfer this repo to a lite-xl organization, so that I can transfer there the website repo as well. It's very delicate step, I had no problems doing for my repos but they were not so "populated", so let me know.
Once done you can fork it from there again so this will be your personal workbench again.

I propose that you also transition the syntax highlight system to use the regular expressions as well.

I don't think this is a very good idea. It'll require a complete rewrite of the highlighting system, and will break all existing syntaxes unless gated behind a flag, in which case we then have two separate highlighting systems which introduces bloat.

I don't think this is a very good idea. It'll require a complete rewrite of the highlighting system, and will break all existing syntaxes unless gated behind a flag, in which case we then have two separate highlighting systems which introduces bloat.

I'd like to at least investigate how much extra code this'll be. If it's literally like two extra lines to have two concurrent sytnax systems (e.g. using the key regex instead of pattern), then I'm OK with it. If it's more than that, I'd generally agree. Let me look into it, and I'll get back to you all with the pull request for it, and we can talk about it on there.

Also, FWIW, I like both logos, but if I had to pick between them, I'd go for @liquidev 's.

@franko, would you agree to move the files from the /doc directory and part of the README to the site, redirecting to the latter for details? See from menu About the Contributors and Usage links as example

About this there is a question: how to preserve git commit history and move the files in the website repo? I tried both solutions like git filter-branch and git filter-repo without success 😛

About this there is a question: how to preserve git commit history and move the files in the website repo? I tried both solutions like git filter-branch and git filter-repo without success

I think we can just move the documentation in the website, which should itself be generated from a git repository. In the lite-xl repository we will keep only the a minimum of doc files like a basic readme, build instructions, license etc. It the website we will have the the complete documentation.

@franko the website is a git repository already, thanks for adding me to the new organization, I have just transferred the website repository there, I'll need if you can add me as maintainer on it in the access settings, please.
What I meant about the doc directory was to move the files from the lite-xl repository to the lite-xl.github.io, but then we'll loose the git commit history if not using some tool to preserve it.

You could also use a github action to deploy to a seperate repo with just the build and keep the files in this repo, if that's what you want.

You could also use a github action to deploy to a seperate repo with just the build and keep the files in this repo, if that's what you want.

No, they should be in one or another, not transferred at any time, it's just about to know if the history is important (there are 2 commits made by another contributor other than franko) and in that case how to preserve it when files are moved.

I don't think we need to bother to keep the history and a separate repository for the website should be fine. In this way the lite-xl repository will be just about the code.
In my experience a single repository for documentation and code is just confusing because you always have a mix of commits about core or documentation and the repository's history becomes "noisy".

OK, I'll do a PR for the doc directory removal and some rewrite of the README.


[CVE-2023-34054] Reactor Netty vulnerability

Describe the bug
CVE-2023-34054 is caused by reactor-netty-http 1.0.38 which is coming from azure-core-http-netty 1.13.9
Refer to the link here, upgrading to 1.0.39 (or 1.1.13) may fix this issue.
Could you please consider upgrading the version?
Description of CVE-2023-34054
In Reactor Netty HTTP Server, versions 1.1.x prior to 1.1.13 and versions 1.0.x prior to 1.0.39, it is possible for a user to provide specially crafted HTTP requests that may cause a denial-of-service (DoS) condition.
Specifically, an application is vulnerable if Reactor Netty HTTP Server built-in integration with Micrometer is enabled.

Release of azure-core-http-netty 1.13.11 resolves this.

Thank you @alzimmermsft ! We're using the azure-sdk-bom 1.2.18, which now depends on azure-core-http-netty 1.13.9. Would you also consider updating the version used there?


[Relay] Remove DynamicToStatic pass from graph runtime build

Closes https://github.com/apache/tvm/issues/10692
To solve this problem, we can either remove this pass from relay.build(...) pipeline or run DynamicToStatic in both VM and non-VM paths. I propose to remove it because  (1) usually DynamicToStatic is supposed to be applied after model import and (2) the only case running DynamicToStatic during relay.build(...) helps is when the input is entirely static but a frontend fails to produce a static mod AND a user forgets to run DynamicToStatic after model import.
I hope the latter case happens rarely but if not, that's something we should fix in the frontend side. We should avoid relying on DynamicToStatic that runs during relay.build(...) since not all use cases of TVM use relay.build(...) (BYOC, for example).

I realized that this is not specific to meta scheduler (the one I tested), but the same error could happen for auto scheduler as well since it also relies on the structure of the input relay subgraph for a workload lookup.
All tests have passed without DynamicToStatic in relay.build(...). As the diff shows, this investigation uncovered a few cases where frontends are introducing dynamic ops carelessly, or some TF frontend tests are using graph runtime for a model containing dynamic inputs (but just happen to be working thanks to DynamicToStatic since dynamic-inputs are bound to a constant tensor before relay.build(...), and after the frontend conversion. This is a very strange usage and they should be using VM in the first place).
So I believe it is better to remove DynamicToStatic in relay.build(...) to prevent those sloppy coding in the frontends. But if people instead prefer running  DynamicToStatic in the VM path as well, it's fine for me to do that. But I'd like to be convinced that such use of  DynamicToStatic really solves non-trivial problems. Let me know your thought @mbrookhart @tkonolige  @comaniac @zxybazh

I realized that this is not specific to meta scheduler (the one I tested), but the same error could happen for auto scheduler as well since it also relies on the structure of the input relay subgraph for a workload lookup.
All tests have passed without DynamicToStatic in relay.build(...). As the diff shows, this investigation uncovered a few cases where frontends are introducing dynamic ops carelessly, or some TF frontend tests are using graph runtime for a model containing dynamic inputs (but just happen to be working thanks to DynamicToStatic since dynamic-inputs are bound to a constant tensor before relay.build(...), and after the frontend conversion. This is a very strange usage and they should be using VM in the first place).
So I believe it is better to remove DynamicToStatic in relay.build(...) to prevent those sloppy coding in the frontends. But if people instead prefer running  DynamicToStatic in the VM path as well, it's fine for me to do that. But I'd like to be convinced that such use of  DynamicToStatic really solves non-trivial problems. Let me know your thought @mbrookhart @tkonolige  @comaniac @zxybazh

I am in favor of remove DynamicToStatic from the default set of passes.


Typescript definitions for Preact > 8.2.8 & Redux > 4.0 & Typescript > 2.8

The latest versions of Preact, Redux & Typescript cause a bunch of errors in the typings file for preact-redux.
This PR includes the fixes required for all of them.

Please merge, I've wasted 3 hours to solve that, eventually downgraded to redux 3 & preact-redux 1.X helped.


NPSP Data Import with person in c1 and later c2 hits runtime error

https://powerofus.force.com/0D58000002SvxYp
If you import the following 2 record csv, neither record will import and both will have the error
[NPSP_Data_Import_Template.xlsx](https://github.com/SalesforceFoundation/Cumulus/files/101660/NPSP_Data_Import_Template.xlsx
Update failed. First exception on row 1 with id a0Tj0000004AltzEAC; first error: ENTITY_IS_DELETED, entity is deleted: []
note that I had to rename the file from .csv to .xlsx to allow gitHub to attach it.  If it gets lost, the first sample csv file on the hub thread is the one to use.

**lurch: add

Tracking W-009193

Included in beta release version 3.65 (Beta 1) and higher

Included in production release version 3.65


Fix for total row click issue

Description of PR
This PR deals with issue #387 (Clicking on total row trowing error)
Type of PR

[x] Bugfix
[ ] New feature

Relevant Issues
Fixes #387
Checklist

[x] Compiles and passes lint tests
[x] Properly formatted
[x] Tested on desktop
[x] Tested on phone

Screenshots

Closing this since #389 was dealing with this


[Shortcuts] Support prefix keys

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case
Desktop apps often support keyboard shortcuts "chords" with multiple separate keypresses. Examples:

Visual Studio Code: Ctrl+K Ctrl+O opens a folder
Gmail: g i goes to the inbox

Proposal
Add a new ShortcutActivator to support this. Strawman example:
// Activated by Ctrl+K followed by Ctrl+O
const openFolderActivator = ChordActivator(
  activators: <ShortcutActivator>[
    SingleActivator(LogicalKeyboardKey.keyK, control: true),
    SingleActivator(LogicalKeyboardKey.keyO, control: true),
  ],
);

return Shortcuts(
  shortcuts: const <ShortcutActivator, Intent>{
    openFolderActivator: OpenFolderIntent(),
  },
  child: ...,
);

@gspencergoog Did you have any thoughts on sequences of keys in Shortcuts when you wrote it?


[e2e] create strategy

fix #832
Concerning the data correctness on the "Set Prices page" I currently check the 100% fill outcome, let me know if you see something else to assert.

@tiagofilipenunes Thanks for the review :

Concerning Firefox & Safari we decided to use only chrome for now because we'll need to define a specific strategy for screenshot. If you think it's important, maybe we can open an issue to discuss that.

Concerning the tenderly path, there is nothing secret, as long as you don't have any api key they cannot do anything. Contributors will still need to change the code to remove setting up the fork & removing it, and test will fail if they don't open a fork at the right blockNumber anyway.


Genesis File Sets pub_key_types to ed25519 Instead of secp256k1 with cometbft -k "secp256k1"

Bug Report
Setup
CometBFT version v0.34.35
Have you tried the latest version: yes
Environment:

OS : Mac OS Sequio 15.0
Install tools: go
Others:

node command runtime flags:   secp256k1
Config

What happened?
Genesis File Sets pub_key_types to ed25519, Instead of secp256k1 with cometbft -k "secp256k1"  init
  "validator": {       "pub_key_types": [         "ed25519"       ]     },
What did you expect to happen?
"validator": {       "pub_key_types": [         "secp256k1"       ]     },
How to reproduce it
cometbft -k "secp256k1"  init

Hi @vlasfama, this is not a valid command in cometbft
(cometbft) > cometbft version
0.34.35
(cometbft) > cometbft -k "secp256k1"  init
ERROR: unknown shorthand flag: 'k' in -k

@andynog thanks for the response. How can we init points on secp256k1 if not with the -k flag?
The docs seem to suggest there is a way https://docs.cometbft.com/v0.38/core/running-in-production
and IIRC tendermint was able to support secp256k1

The -k flag is only available in cometbft release v1.x. There are no commands to generate the keys specifying a key type.
Are you using cometbft standalone and building a separate ABCI app ? Maybe if you're using Cosmos-SDK you can use the keys command to generate the key.
Also, if using a different key type you have to ensure the consensus param for key types is set properly https://docs.cometbft.com/v0.34/spec/core/data_structures#validatorparams


allow appending to a constraintset

example code from @mjburton11
" wing.py "
import numpy as np
from gpkit import Variable, Model, SignomialsEnabled, ConstraintSet
from gpkitmodels.GP.aircraft.wing.wing import Wing as WingGP
from gpkit import Variable, Model, Vectorize, SignomialsEnabled

# pylint: disable=attribute-defined-outside-init, invalid-name

def Wingtest(N=5, lam=0.5, spar="CapSpar", hollow=False):
    wing = WingGP(N=N, lam=lam, spar=spar, hollow=hollow)
    mw = Variable("m_w", "-", "span wise effectiveness")

    with SignomialsEnabled():
        constraints = [mw*(1 + 2/wing["AR"]) >= 2*np.pi]

    wing.append(constraints)
    return wing

w = Wingtest()
print w["m_w"]

test models please

retest this please

@bqpd what's the status on this?

retest this please

merging so that gassolar passes tests. @whoburg, ready for review


Open on Page Load?

How would I trigged Sidr to open automatically when the page loads?

what the great the solution? link dead!

@berkant-fidan sorry for that. I have updated the link


No hpa resource viewer

Is there any hpa resource viewer to easily watch autoscaling status in pods.

Let's start by writing a printer for hpa

@puzzloholic This is now available on master. Feel free to leave any feedback for changes you'd like to see for 0.8


⚠ Processors has degraded performance

In cb116f3, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 503 ms

Resolved: Processors performance has improved in a3f652c.


Error for more then 12 items

That error is pretty annoying. Most of my submenus have more then 12 items, and I get a new error every time, and also need to press a key every time. Could you provide a way to turn this error off? I understand layout won't be optimal, but I've decided it's okay and don't want to further "submenurize" my options.

That can be taken out now. The columns approach now makes this irrelevant.


⚠ AGEG website (redirect) has degraded performance

In bdef20f, AGEG website (redirect) (https://ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 3440 ms

Resolved: AGEG website (redirect) performance has improved in 55cc50f.


chapter18_variational-methods-and-uncertainty/bayes-by-backprop-gluon.ipynb

When  I run the code in the "complete training loop",
it has the following errorr message:

AttributeError                            Traceback (most recent call last)
 in ()
17             # overwrite network parameters with sampled parameters
18             for sample, param in zip(layer_params, net.collect_params().values()):
---> 19                 param._data[list(param._data.keys())[0]] = sample
20 #                 param._data = sample
21
AttributeError: 'NDArray' object has no attribute 'keys'
So how can i correct the bug?

Encountered the same issue.

I ran into the same problem.
I think it should be
param._data[0] = sample
And the same thing in evaluate_accuracy function
param._data[0] = l_param


Disable upnp from being discovered

Description:
This disables upnp component from being discovered.
I realized that by making this discoverable, we are now suggesting every new user to open a port on their router and expose Home Assistant. We shouldn't do this.

As per #18066
StevenLooman commented 4 hours ago

Apparently upnp is forbidden completely from now on via #17937 by @pvizeli. While I agree with the danger by of the port forward, it was included after discussion with @dgomes.
Still, simply disabling discovery, effectively destroying the functionality was a bit of an overkill. @pvizeli was there no other way, such as discussing this with @dgomes or me about other options?

dgomes commented 4 hours ago

It would be dangerous if auto-discovery would enable the port-forwarding automatically. But users still needed to tick the option to open the port. Or did I miss a step ?

StevenLooman commented 4 hours ago

I agree that it is too easy to enable the port-forward. If a user does not know what it is, it is very easy to simply tick it.
If a port-forward can only be enabled via the configuration file, then users will be safer.

dgomes commented 4 hours ago

On the other hand the all point of using UPnP to port-forward stuff is not to mess with configurations :)
I think a warning in the GUI should have been enough
(BTW I think these comments should be moved to the other thread)

A solution would be that port-forward can only be enabled by using the configuration and not showing the port-forward option in the Integrations menu


AA0225 warns about missing caption when ShowCaption = false

Describe the bug
On page fields with ShowCaption = false there AA0225 warning about missing caption if the caption is not set, even though a caption would not be needed.
To Reproduce
Steps and to reproduce the behavior:

Create code like below

field(SomeField; MyInteger)
{
    ApplicationArea = All;
    ShowCaption = false;
}

Expected behavior
No AA0225 warning when ShowCaption = false
Screenshots

5. Versions:

AL Language: 5.0.232930

This issue has been fixed for AL extension with a version higher than 5.0.272418


This script can now be run from any directory

The current version of backend/start.sh requires that it be invoked from the backend directory.

Thanks for the PR! LGTM!


Plugins added to DBeaver eclipse framework are removed on new install

5.2.
Adding support for an eclipse plugin in DBeaver is removed on running windows executable to update installation.

If you use Windows installer or MacOS pkg then yes, installer removes previous version completely. It is made on purpose because quite often old plugins will become incompatible with new DBeaver API.
And this may produce tons of hard-to-reproduce bug reports.
So, basically it was done purpose to simplify our (developers) life. Hopefully will have more resources in future and will freeze API at least for optional extensions.


Windows Terminal title bar non clickable/interactable

Environment
Microsoft Windows [Version 10.0.18363.900]
Windows Terminal 1.0.1811.0

Steps to reproduce

Open terminal

Expected behavior

I should be able to use the buttons on the title bar to close / expand / reduce the app, or even add new tabs.
Actual behavior

Buttons are "dead", they don't receive clicks.

Environment
Microsoft Windows [Version 10.0.19041.264]
Windows Terminal 1.0.1811.0

I have the same issues as described in https://github.com/microsoft/terminal/issues/6784#issue-650885581
Furthermore, I am unable to select/copy text.
It seems that the terminal is not responding to mouse input at all
I have also confirmed the same behavior on Windows Terminal Preview v1.1.1812.0

Environment
Microsoft Windows [Version 10.0.19041.264]
Windows Terminal 1.0.1811.0

I have the same issues as described in https://github.com/microsoft/terminal/issues/6784#issue-650885581
Furthermore, I am unable to select/copy text.
It seems that the terminal is not responding to mouse input at all
The hover color change events for the UI buttons ( new tab, close tab, tab menu, minimize, maximize, exit ) do not fire when in the error state
I have also confirmed the same behavior on Windows Terminal Preview v1.1.1812.0
Restarting the computer fixes the issue in both builds.

Environment
Microsoft Windows [Version 10.0.19041.264]
Windows Terminal 1.0.1811.0

I have the same issues as described in #6784 (comment)
Furthermore, I am unable to select/copy text.
It seems that the terminal is not responding to mouse input at all
The hover color change events for the UI buttons ( new tab, close tab, tab menu, minimize, maximize, exit ) do not fire when in the error state
I have also confirmed the same behavior on Windows Terminal Preview v1.1.1812.0
Restarting the computer fixes the issue in both builds.

I did not try with the Preview, but restarting seems to fix the bug for now.

https://github.com/microsoft/terminal/issues/6120 describes similar symptoms.

@Sov3rain Are you using PowerToys at all? If so:

Are you using the Terminal on a high DPI display?

If so, and if possible, does dragging the window to a 100% scaling display magically restore mouse functionality to the Terminal?

Similarly, are you using the Terminal on your primary display?

If so, and if possible, does dragging the window to another display magically restore mouse functionality to the Terminal?

Does the PowerToys settings app similarly not respond to mouse input?
Do you have the Shortcut Guide enabled in PowerToys?

If so, does it actually work if you long press Win?

By any chance, did you recently uninstall any sort of IME (like a Chinese/Japanese/Korean language IME)?

If you're experiencing this, and you can interact with the PowerToys settings app (you might need to drag it to another monitor), then

can you fix the issue by disabling "Shortcut Guide" in PowerToys?

@zadjii-msft

Are you using PowerToys at all?

Yes I do.

Are you using the Terminal on a high DPI display?

No, just a regular full HD 1080p monitor.

Similarly, are you using the Terminal on your primary display?

I only got one display.

If so, and if possible, does dragging the window to another display magically restore mouse functionality to the Terminal?
Does the PowerToys settings app similarly not respond to mouse input?

I didn't encounter the bug again for now, I'll try that if it goes wrong.

Do you have the Shortcut Guide enabled in PowerToys?

Yes I do.

If so, does it actually work if you long press Win?

Yes it does.

By any chance, did you recently uninstall any sort of IME (like a Chinese/Japanese/Korean language IME)?

No I didn't.

If you're experiencing this, and you can interact with the PowerToys settings app (you might need to drag it to another monitor), then

can you fix the issue by disabling "Shortcut Guide" in PowerToys?

As I said, I didn't encounter the issue again in my recent use of the terminal. I'll let you know if it happens again.

Thanks for all the info. After all that, I'm gonna mark this as a /duplicate of #6120.
Cheers, all, and thanks for playing!


"choices" on typography field

Currently, I'm using the code below to load multiple variants on a typography field.
Kirki::add_field( 'test', array(
	'type' => 'typography',
	'settings' => 'font_body',
	'transport' => 'auto',
	'choices' => array(
		'variant' => array(
			'italic',
		),
	),
	'default' => array(
		'font-family' => 'Overpass',
		'subsets' => array( 'latin' ),
		'variant' => 'regular',
	),
	'output' => array(
		array(
			'element' => array( 'body' ),
		),
	),
) );

And it outputs CSS below which is exactly what I wanted.

Is using choices attribute on typography field like this safe? It wasn't mentioned in the documentation, so I would like to know if it's safe to use on production.

Hey there!
Yes, that's fine. The docs are simply currently undergoing a complete rewrite so there are a few things missing.

Hi there, thanks for your answer. Great plugin!


fix(userspace/libscap,userspace/libsinsp): properly add parsers for multiple EF_CREATES_FD events.

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libscap-engine-savefile
/area libscap
/area libsinsp
Does this PR require a change in the driver versions?

What this PR does / why we need it:
Moreover, properly state in EF_CREATES_FD and EF_DESTROYS_FD flags docs, that when used, a parser MUST always be created.
Practically, added parser for:

bpf
userfaultfd
io_uring_setup

exit events.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

fix: properly parse and add to sinsp state FDs coming from bpf, userfaultfd and io_uring_setup events.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.9.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 3063c49530e606500255e8eee4d036a45145a10b

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, leogr, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,LucaGuerra,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Allow building with the system codec2

I am trying to package LPCNet to Fedora, but we cannot bundle code. Would be possible to allow building with the system installed codec2? I.e. not detecting the codec2.cmake, but e.g. codec2.pc and linking with the libcodec2.so?

If it is technically possible and if you are OK with it, I could provide cmake patch for it.

Closing because the question was answered in issue 18.


Consider editor associations when opening notebook results in search

As discussed in https://github.com/microsoft/vscode/pull/192358, we should consider editor associations when deciding whether to open the result as a notebook in notebook search.

To verify, enable search.experimental.closedNotebookRichContentResults and:

Add to workbench.editorAssociations:

  "workbench.editorAssociations": {
    "*.ipynb": "default"
  },

Search for something in an ipynb file that only shows up in the raw text (ie: "cell_type":). The result should appear in the search.
Remove the setting and rerun the search.
The result shouldn't be there anymore.

After I remove the setting and rerun the search I still see results from the raw JSON

Hmm, I can't seem to repro on the latest main. Closing.


set isMuted to false on load method

set isMuted to false on new load
#1040

@katspaugh should I add this as an option to allow muting to continue even after loading new audio?

That would logical too. If I mute wavesurfer object maybe I want it to be muted on new tracks too, until I unmute.

Sure, let's add it. To me, it seems more logical to actually keep the next tracks muted by default since it's the same instance of the wavesurfer. But it's subjective.

Merged, thanks!


Add boost asio handler

As per issue #146 , this is an implementation of a boost::asio event handler that makes use of boost::asio::io_service.  On suitable for POSIX-based systems.

There was an AsioHandler in older copernica version have you seen it? It needed some fixes thought.
Why only POSIX? I can not find place where you disassociate sockets.

@fantastory Thanks for the review and subsequent approval/merge.
I had a look at the older AsioHandler, and I couldn't get it to work without hitting issues.  It's the reason that I started a new one from scratch.
The pertinent code which deals with disassociating from a socket:
https://github.com/CopernicaMarketingSoftware/AMQP-CPP/blob/9559dfb880defdc39ffdc727b671c6835a6c1c58/include/libboostasio.h#L189-L197
The specific call is '_ socket.release();'
You can read more here - https://github.com/chriskohlhoff/asio/issues/70


Enable -Wall in ouroboros-network-framework

Also use -Werror on CI; fix all the tiny issues.
This is done on top of #1981; I'll rebase it once #1981 is merged.

bors merge


Help with plugin

Hi
I was wondering if it was possible to retrieve a number from the project and divide it by the number of sub projects it has? So if Project had a field with value of 100, and it has 4 sub projects, all the sub projects would have a field of value 25.
Thanks

Hi. Try this code. But you need to re-save all sub projects to evaluate calculations.
return if parent_id.blank?
parent_cf_id = 1 # Use your ID
(parent.custom_field_value(parent_cf_id).to_f/parent.children.size).round(2)

Please feel free to reopen this issue if you need help.


I can see an user talk even if it is an anonymous voting

Hey folks 👋
I don't know if this is a valid issue or not.
For example: I checked this event https://speakerfight.com/events/1-encontro-mensal-do-opensanca-araraquara/ and it is an anonymous voting event (so, the proposer is hidden)

But if I enter on the profile of the person, I can see that she/he created the proposal
https://speakerfight.com/profile/duduribeiro/

Is this a real issue? For me, it should also be hidden from the profile page.

Hahaha.
That's make totally sense, its not right to display it.
We should fix that!
If you want to close it, it'll count for the Hacktoberfest!

Should this be closed?