Variable Group YAML Syntax

The documentation for variable groups in YAML just references one group.  Is it possible to have several as well as some single variables?
I know this doesn't work...
variables:
- group: 'Group-A
- group: 'Group-B'
  myVarA: 'foo'
  myVarB: 'bar'

Great feedback, I'll get this fixed. You can use this:
variables:
- group: 'Group-A
- group: 'Group-B'
- name: 'myVarA'
  value: 'foo'
- name: 'myVarB'
  value: 'bar'

Fix is set to publish today.


v2 port to 1.20

Hey, do you have any plans of porting v2 to older versions like at least 1.20?? I'd really love to use this on an SMP i'm making but honestly having the same pattern on every single tool regardless of the trim used is pretty boring... the new system looks WAY better and it'd be a shame to have it locked to newer versions only

It's being looked into, no promises yet.

i see, hope it does end up being a thing! thanks for the update!

Backport released.


ADR: Running out of Rancher Manager cluster

kind/documentation
What this PR does / why we need it:
Adds ADR for running Rancher Turtles out of Rancher Manager cluster.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #94
Special notes for your reviewer:
Checklist:

[x] squashed commits into logical changes
[x] includes documentation
[ ] adds unit tests
[ ] adds or updates e2e tests

Thanks for the reviews @richardcase @furkatgofurov7 @Danil-Grigorev. I updated the proposal and also used doctoc on the ADR.


https://downloads.pacbcloud.com/public/dataset/ not publicly available?

Operating system
Windows - MobaXterm v23.2
Package name
N/A
Conda environment
N/A
Describe the bug
I'm unable to access the example data needed to test the isoseq package (e.g. https://downloads.pacbcloud.com/public/dataset/IsoSeq_sandbox/2020_Alzheimer8M_subset/alz.1perc.ccs.bam ). I am also unable to access https://downloads.pacbcloud.com/public/dataset/ on my webbrowser (google chrome, see error pasted below), but I can access https://downloads.pacbcloud.com/public/ and several of its subdirectories.
Error message
Error message in terminal:

Error message in web browser:

To Reproduce
wget https://downloads.pacbcloud.com/public/dataset/IsoSeq_sandbox/2020_Alzheimer8M_subset/alz.1perc.ccs.bam
Expected behavior
I expected to download the example data set to try the Isoseq package

We've fixed the example


Add grap namespace

Changes proposed in this pull request:

Add GRAP namespace
Add GRAP's skin

@GrapFinance Hi can you update the PR following the new guide here: https://docs.snapshot.page/guides/create-a-space

@bonustrack Already got verify from trustwallet.

You need to make a new pull request with the new format see here: https://docs.snapshot.page/guides/create-a-space

Got it.


Vehicle makes collision when localization is bad.

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
Hi team,
I'm currently running Autoware with Carla, and I found a situation that the ego vehicle collides with a guardrail when the localization is bad.
Here's a video on rviz: [rviz] and frontview: [frontview]
In the frontview video, the vehicle invades lane at the last cornering(3:15~), and it collides with a guardrail, after escaping the corner.
Rviz video shows the last few seconds of the driving. At the start of the video, pointcloud and lanelet has some discrepancy due to a localization issue, and the ego vehicle drives and eventually makes a collision.
Here's a log file, but it does not contain any meaningful messages, except some warnings on localization: [launch.log]
Expected behavior
I think the vehicle should stop before the collision and it could stop by using the pointcloud data, even though the localization is bad.
Actual behavior
But the vehicle does not stop and makes collision, even though the pointcloud data saids there's an obstacle.
Steps to reproduce
Here's a ros2bag file to reproduce: [ros2bag]
Versions

Autoware: 20240115, prebuilt docker
Carla: 0.9.13
OS (host): Ubuntu 20.04
OS (docker): Ubuntu 22.04

Possible causes
According to RViz video, there's no virtual wall that saids an obstacle is at front.
So, in my opinion, the issue has to do with obstacle_stop_planner.
I also echoed to the two topics relevant to the obstacle stop planner, but they do not publish any information regarding the obstacle.
# /planning/scenario_planning/lane_driving/motion_planning/obstacle_stop_planner/output/stop_reasons
level: "\0"
name: ''
message: ''
hardware_id: ''
values: []

# /planning/scenario_planning/lane_driving/motion_planning/obstacle_stop_planner/virtual_wall
markers:
- header:
    stamp:
      sec: 311
      nanosec: 899856438
    frame_id: ''
  ns: stop_virtual_wall
  id: 0
  type: 0
  action: 2
  pose:
    position:
      x: 0.0
      y: 0.0
      z: 0.0
    orientation:
      x: 0.0
      y: 0.0
      z: 0.0
      w: 1.0
  scale:
    x: 0.0
    y: 0.0
    z: 0.0
  color:
    r: 0.0
    g: 0.0
    b: 0.0
    a: 0.0
  lifetime:
    sec: 0
    nanosec: 0
  frame_locked: false
  points: []
  colors: []
  texture_resource: ''
  texture:
    header:
      stamp:
        sec: 0
        nanosec: 0
      frame_id: ''
    format: ''
    data: []
  uv_coordinates: []
  text: ''
  mesh_resource: ''
  mesh_file:
    filename: ''
    data: []
  mesh_use_embedded_materials: false
- header:
    stamp:
      sec: 311
      nanosec: 899856438
    frame_id: ''
  ns: stop_factor_text
  id: 0
  type: 0
  action: 2
  pose:
    position:
      x: 0.0
      y: 0.0
      z: 0.0
    orientation:
      x: 0.0
      y: 0.0
      z: 0.0
      w: 1.0
  scale:
    x: 0.0
    y: 0.0
    z: 0.0
  color:
    r: 0.0
    g: 0.0
    b: 0.0
    a: 0.0
  lifetime:
    sec: 0
    nanosec: 0
  frame_locked: false
  points: []
  colors: []
  texture_resource: ''
  texture:
    header:
      stamp:
        sec: 0
        nanosec: 0
      frame_id: ''
    format: ''
    data: []
  uv_coordinates: []
  text: ''
  mesh_resource: ''
  mesh_file:
    filename: ''
    data: []
  mesh_use_embedded_materials: false
- header:
    stamp:
      sec: 311
      nanosec: 899856438
    frame_id: ''
  ns: slow_down_virtual_wall
  id: 0
  type: 0
  action: 2
  pose:
    position:
      x: 0.0
      y: 0.0
      z: 0.0
    orientation:
      x: 0.0
      y: 0.0
      z: 0.0
      w: 1.0
  scale:
    x: 0.0
    y: 0.0
    z: 0.0
  color:
    r: 0.0
    g: 0.0
    b: 0.0
    a: 0.0
  lifetime:
    sec: 0
    nanosec: 0
  frame_locked: false
  points: []
  colors: []
  texture_resource: ''
  texture:
    header:
      stamp:
        sec: 0
        nanosec: 0
      frame_id: ''
    format: ''
    data: []
  uv_coordinates: []
  text: ''
  mesh_resource: ''
  mesh_file:
    filename: ''
    data: []
  mesh_use_embedded_materials: false
- header:
    stamp:
      sec: 311
      nanosec: 899856438
    frame_id: ''
  ns: slow_down_factor_text
  id: 0
  type: 0
  action: 2
  pose:
    position:
      x: 0.0
      y: 0.0
      z: 0.0
    orientation:
      x: 0.0
      y: 0.0
      z: 0.0
      w: 1.0
  scale:
    x: 0.0
    y: 0.0
    z: 0.0
  color:
    r: 0.0
    g: 0.0
    b: 0.0
    a: 0.0
  lifetime:
    sec: 0
    nanosec: 0
  frame_locked: false
  points: []
  colors: []
  texture_resource: ''
  texture:
    header:
      stamp:
        sec: 0
        nanosec: 0
      frame_id: ''
    format: ''
    data: []
  uv_coordinates: []
  text: ''
  mesh_resource: ''
  mesh_file:
    filename: ''
    data: []
  mesh_use_embedded_materials: false

Additional context
No response

The default Autoware behavior does not stop for obstacle points but the obstacle_stop_planner can be used to stop in front of obstacle points:
https://autowarefoundation.github.io/autoware.universe/main/planning/obstacle_stop_planner/

Thank you for the response @maxime-clem!
I think I didn't get your point. Could you please tell your point again?
Do you mean I should change some parameters to stop Autoware in the situation?
I've checked that the default Autoware could stop behind the obstacle at front well, and I think the situation of this issue is not different with stopping behind the obstacle at front.
Thanks!

Sorry for not being so clear. Actually my previous comment was wrong. The default behavior of Autoware is to stop if there are points from /perception/obstacle_segmentation/pointcloud on the path.
In your case, even if localization is wrong, the points from the guardrail should trigger a stop. Make sure the pointcloud is correctly published and is in base_link frame.

Thank you for the details @maxime-clem!
I echoed to /perception/obstacle_segmentation/pointcloud if the pointcloud data is published well, and I could get the like data below continuously, not readable though.. so it seems the pointcloud data is published well.

pointcloud data
header:
  stamp:
    sec: 88
    nanosec: 49853103
  frame_id: base_link
height: 1
width: 5579
fields:
- name: x
  offset: 0
  datatype: 7
  count: 1
- name: y
  offset: 4
  datatype: 7
  count: 1
- name: z
  offset: 8
  datatype: 7
  count: 1
is_bigendian: false
point_step: 16
row_step: 89264
data:
- 160
- 87
- 185
- 63
- 160
- 118
- 227
- 64
- 79
- 117
- 79
- 63
- 0
- 0
- 128
- 63
- 160
- 130
- 185
- 63
- 0
- 171
- 227
- 64
- 68
- 90
- 57
- 63
- 0
- 0
- 128
- 63
- 160
- 225
- 191
- 63
- 160
- 173
- 227
- 64
- 48
- 182
- 56
- 63
- 0
- 0
- 128
- 63
- 224
- 163
- 185
- 63
- 64
- 7
- 144
- 65
- 210
- 178
- 27
- 63
- 0
- 0
- 128
- 63
- 192
- 13
- 204
- 63
- 88
- 20
- 146
- 65
- 112
- 167
- 20
- 63
- 0
- 0
- 128
- 63
- 64
- 44
- 205
- 63
- 248
- 225
- 146
- 65
- 143
- 199
- 70
- 63
- 0
- 0
- 128
- 63
- 64
- 179
- 209
- 63
- 120
- 93
- 195
- 65
- 214
- 125
- 25
- 64
- 0
- 0
- 128
- 63
- 96
- 145
- 231
- 63
- 24
- 16
- 196
- 65
- 86
- 121
- 25
- 64
- 0
- 0
- 128
- 63
- '...'
is_dense: true

And I tried to check if the pointcloud data is in base_link frame, but I have no idea.. Could you please tell me how?
By the way, I found somewhat weird situation that, the pointcloud data is not perceived well for some area.
Here's the video, and before the collision, some points of the guardrail near to the vehicle disappears, and appears after the vehicle goes far. (so the guardrail seems not connected as the image below.)

But, since the disappeared points are behind the vehicle, so this could not be the root cause.. do you have any idea on this?

In the message you shared we can see the frame_id in the header of the message.
header:
  stamp:
    sec: 88
    nanosec: 49853103
  frame_id: base_link

some points of the guardrail near to the vehicle disappears, and appears after the vehicle goes far

This can be caused by a dead zone in the lidar, or by the pointcloud cropbox filter. But I do not think this is causing any issue here.
I cannot understand why in your case the obstacle_stop_planner does not trigger a stop. If you can share a bag of your situation I will try to analyze the issue.

Thank you for the kind explanation and opinion @maxime-clem! Now I understood.
For the ros2bag file, I already uploaded it for better reproduction.
You can find it here.
Thanks!

Thank you for sharing your bag.
I found the source of the issue. By default, the obstacle_stop_planner does some filtering on the obstacle pointcloud using the Z axis. However, in your case, the z axis is somehow stuck to ~0.0 but the obstacle points are elevated and thus ignored.
Here are two videos taken from the bag you shared showing the correct and incorrect update.
https://github.com/autowarefoundation/autoware.universe/assets/78338830/2a0b7f86-2034-4232-8211-5f8dd8c77750
https://github.com/autowarefoundation/autoware.universe/assets/78338830/1da3aa0f-d62b-4e98-862e-a5c9dfe80f76
As a workaround, you can set parameter  enable_z_axis_obstacle_filtering to False.
I will ask someone else to investigate this issue since it is not related to planning but with localization.

Thank you for the detailed investigation @maxime-clem!!
I think I got your point.
The current obstacle_stop_planner ignores obstacles irrelevant to the ego(e.g., z value differs a lot), but in this case the z value is fixed as ~0.0(don't know why), and the ego vehicle ignores the guardrail since there's enough difference between the estimated z value of ego and that of the guardrail, so they eventually collides since the estimated z value of the ego is wrong.
So.. I agree that this issue would be from localization.
I always appreciate to your help! Thank you!

Hi! I haven't looked at the data yet, but I noticed that the launch.log provided by the questioner contains many warnings indicating that the NDT's NVTL(Nearest Voxel Transformation Likelihood) score is falling below the threshold.

1708804488.0783958 [ndt_scan_matcher-33] [WARN] [1708804488.075854158] [localization.pose_estimator.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 1.288186, Threshold: 2.300000

When the NVTL is low, NDT doesn't output a position, so the height won't be updated because only odometry is used to estimate the position.
I will check the rosbag to see why the NVTL is decreasing.

Hi @KYabuuchi!!
For the reason that the localization is getting bad, I want to share my opinion(could be wrong, but I hope it to be helpful).
The map the ego vehicle is driving is Town04, which is truly large.
It is something like highway, so there are many long monotonic(i.e., with no special surroundings) roads.
According to my observation, when the ego vehicle drives through the long monotonic road with no special surroundings, the localization gets worse. (The ego vehicle thinks itself driving little bit relative behind to the real position.)
For this issue, the ego vehicle also ran the long monotonic road before running into the corner, so I think it would have made the localization bad.

@Kim-mins
I agree with your analysis.  Autoware's localization often struggles on monotonic roads. However, performance can often be improved with adjustments to some parameters.
One thing I noticed is that your rosbag had a /clock topic at 10Hz. The EKF ideally calls the timer callback at 50Hz, so a /clock frequency of 50Hz or higher is preferable. If possible, try increasing the frequency of the /clock and test again.
(The log message [localization.pose_estimator.ndt_scan_matcher]: pose_buffer_.size() < 2 indicates that the EKF's timer callback is being called at a low frequency.)

I tried validating your rosbag in my environment, and for some reason, consistently successful localization was achieved.
I'll share the video with you.
https://github.com/autowarefoundation/autoware.universe/assets/24854875/4fed00e5-84df-43a7-bfb1-9a9732897e70

Thank you for the investigation @KYabuuchi!
For the clock frequency, I'm limiting it to 20Hz due to the computational cost, since I'm running co-simulation now. I'll check if I can apply higher frequency.
I also tried my bag file, but I could observe that the ego vehicle drives under the road in rviz.
Could you please check if the vehicle is under the road during the last cornering?
https://github.com/autowarefoundation/autoware.universe/assets/50267797/0a694926-5d2f-4cab-ab87-c9fd10839118

Hmm, in my environment, the estimated position consistently contacts with the ground.
Also, the score and iteration_number of the ndt_scan_matcher were stable before and after the curve.
https://github.com/autowarefoundation/autoware.universe/assets/24854875/dc708fc8-940b-4686-a753-cb1c40e99abb
Here is my command for rosbag playback.
ros2 bag play .  --topics
         /clock
         /sensing/gnss/ublox/nav_sat_fix
         /sensing/imu/tamagawa/imu_raw
         /sensing/lidar/concatenated/pointcloud
         /vehicle/status/gear_status
         /vehicle/status/steering_status
         /vehicle/status/velocity_status

When the clock frequency is low, the prediction frequency of the EKF becomes coarse, requiring the NDT scan matcher to start matching from a poor initial value. This can be challenging on monotonic roads. Additionally, as the frequency of prediction updates in the EKF decreases, the variance may become smaller than expected. In such cases, the observations by NDT may not be adequately reflected, leading to inaccurate estimation results.
Publishing the clock at a higher frequency, even with dummy values, may improve the situation. (But I am not familiar with CARLA so I do not know if we can do it.)

Thank you for checking again @KYabuuchi!
I also tried your command for playing ros2bag file, but the vehicle in rviz does not move at all. Could you please check the command again for me?
For the video of my last comment, I used the command below:
ros2 bag play .

which just plays message from every topic.
For the clock frequency, I got one question.
I'm running co-simulation with Carla, and I run it synchronously, that is, to my knowledge, the messages between Carla and Autoware are exchanged one by one.
So I expected that, since the messages are exchanged in synchronized manner, even if the frequency is too low, the issue from low frequency would not happen at all.
Could you please share your opinion on this?
Thanks!

Because the localization input topic was changed to /sensing/lidar/concatenated/pointcloud from /sensing/lidar/top/pointcloud about a month ago. https://github.com/autowarefoundation/autoware.universe/pull/6528
You are using the January version, so the required topic may be different.
ros2 bag play .  --topics
         /clock
         /sensing/gnss/ublox/nav_sat_fix
         /sensing/imu/tamagawa/imu_raw
         /sensing/lidar/top/pointcloud
         /vehicle/status/gear_status
         /vehicle/status/steering_status
         /vehicle/status/velocity_status

Thank you @KYabuuchi!
Actually, I don't know well about the topics for localization, I could not play the bag file with your specific topics.
So, could you please play the ros2bag file with all the topics?
When I play again with the command ros2 bag play ., I could observe that the vehicle goes under the road: [rviz]

@Kim-mins if you replay all topics from the bag, then the pose will be the one that was recorded in the bag where we observe the pose under the road at some points.
What @KYabuuchi is doing is only replaying the sensor data (so the pose is not replayed) while running Autoware. This way Autoware was able to produce a correct localization pose. This means that the issue was probably a performance issue.
I am hopping that the new carla_autoware interface (see https://github.com/autowarefoundation/autoware.universe/pull/6859/) will provide better performance and fix these kind of issues.

Thank you for clarifying @maxime-clem! Now I could get the point!
So maybe the performance issue is the cause and I should try the new bridge to test if the issue remains.
For the new bridge, frankly speaking, I check #6859 every day, and I really look forward to the release since I do want to free from this kind of weird issue..
Is there any specific plan for the release of the bridge?
Thank you!

I think we identified the issue (wrong z value because of localization failure), and possible workaround (set parameter enable_z_axis_obstacle_filtering to False).
I am closing the issue but we can reopen it if needed.


Freely resize images without maintaining aspect ration

Is it possible to configure editor, so it lets me scale the image the way i want (all four side), without forcing the aspect ration ?

Hi @snimavat - technically yes but the code is a little untested so...

I'd recommend implementing this in CoffeeScript but you could use a converter for my code below if need be (e.g http://js2coffee.thomaskalka.de/)

We need to define a new FlexibleImage element class that supports an attribute to determine if the aspect raitio is fixed when resizing, that would be done something like:
class ContentEdit.FlexibleImage extends ContentEdit.Image

    # An image element that can be configured with a flexible aspect ratio

    resize: (corner, x, y) ->
        # Resize the element
        unless @isMounted() and @can('resize')
            return

        flexible = @hasAttr('data-ce-flexible')
        ContentEdit.Root.get().startResizing(this, corner, x, y, flexible)

# Register `ContentEdit.FlexibleImage` as the tag to associate with images (over Image)
ContentEdit.TagNames.get().register(ContentEdit.FlexibleImage, 'img')

To then implement an image with a flexible aspect ratio we just need to set the data-ce-flexible attribute against it:

Great, i would try it out..
The other issue i am facing is, element.constructor.name is always c, but never 'Image'
Resizing:
 imageResizer = (element) ->
    $log.debug element.constructor.name
    return if element.constructor.name != 'Image'
    $log.debug "Image resized", element.constructor.name
    #src = element.attrs("src")
    #$log.debug src

ContentEdit.Root.get().bind 'taint', imageResizer

However, it never pass this condition -  if element.constructor.name != 'Image'

@snimavat I don't recommend using constructor.name it's not safe across browsers (I learned this the hard way). Instead CE provides the type() method against elements, so instead I'd recommend you try:
return element.type() != 'Image'

Perfect, that works.. i was following cloudinary example, which uses constructor.name

Ah I need to update that then (thanks for letting me know :+1: ) - I used to use constructor.name, then like I say discovered it's not reliable.

Thanks again for highlighting this @snimavat - I've now updated all references to element.constructor.name with .type() within the documentation.


add tomcat plugin to console project

pls help review

Coverage increased (+0.2%) to 92.542% when pulling 02e8ac65ec1e9278f29e5903be7b8bf8ec7d0091 on hoswey:master into 2840a02900373328edf763e1d7ed6a089d3e6840 on dangdangdotcom:master.

Coverage decreased (-0.05%) to 92.3% when pulling 02e8ac65ec1e9278f29e5903be7b8bf8ec7d0091 on hoswey:master into 2840a02900373328edf763e1d7ed6a089d3e6840 on dangdangdotcom:master.


Hyper parameter search

Most trading strategies are non-differentiable, but they have a lot of parameters that need to be tuned. Most simple hyper parameters searches take too much time, so research is required for viable alternatives.

Hi, we wrote a simple grid search that runs backtests in parallel, using a cached feed in order to accelerate the search. It's not optimized in any way regarding following a path of better results (like running some tree optimized search - don't know if it makes any sense...)

Might be a good starting point.  FYI, my ideal end goal would look something like this (not all for shorter term):

be able to define both discrete and continuous search spaces per parameter.
be able to define parameter constraints (like param1 has to be bigger than param2)
support for both basic (grid, random) and advanced (bayesian, ...) search optimisers
run across multiple machines to speed things up

But right now I personally just write hard-coded nested loops, so any start will be an improvement on that ;)

Added backtest package with basic optimising back test support


Add some more badges

@fleupold gave me badge fever!
Closes #18

What did he do to give you badge fever?

What did he do to give you badge fever?

#211

Ya, badges ROCK!


Feat: add WithRequest as a type and the callback

Add ability to  pass the request to the verification function this allows the user to connect a currently loggined in user to w/e auth provider they are trying to login

Still needs to be tested.
Will be tested after learning how to test

notes:

passport link: https://www.passportjs.org/concepts/delegated-authorization/

@thgh how do you usually test this? would I do a yarn link?

I'm not using this package as my needs changed over time 🥲
Ideally, there would be a vitest integration test that spawns an http server and simulates the oauth flow.

Check this out!
https://github.com/thgh/payload-plugin-oauth/commit/e7702f45c3d6dafcd1ada20f3c15f9b942770810

Check out this test 🙌 https://github.com/thgh/payload-plugin-oauth/blob/main/test/integration.test.ts

thanks, ill check it out! need to get some time to do this


Convert on plugin

Please, move this code to a npm moduile, so it easier to install and send PR

Sure, I'm working on it 👍


Continuing build and test issues

@doutriaux1 it seems that the travis build tests are continuing to fail - this time it appears that upstream issues with cdms2 have caused problems:
$ python test/test_suite.py
Traceback (most recent call last):
  File "test/test_suite.py", line 2, in <module>
    import test_from_param
  File "/home/travis/build/PCMDI/pcmdi_metrics/test/test_from_param.py", line 9, in <module>
    import pcmdi_metrics
  File "/home/travis/miniconda/lib/python2.7/site-packages/pcmdi_metrics/__init__.py", line 2, in <module>
    import io  # noqa
  File "/home/travis/miniconda/lib/python2.7/site-packages/pcmdi_metrics/io/__init__.py", line 2, in <module>
    import base  # noqa
  File "/home/travis/miniconda/lib/python2.7/site-packages/pcmdi_metrics/io/base.py", line 2, in <module>
    import cdms2
  File "/home/travis/miniconda/lib/python2.7/site-packages/cdms2/__init__.py", line 30, in <module>
    from dataset import createDataset, openDataset, useNetcdf3, \
  File "/home/travis/miniconda/lib/python2.7/site-packages/cdms2/dataset.py", line 6, in <module>
    import Cdunif
ImportError: /home/travis/miniconda/lib/python2.7/site-packages/cdms2/Cdunif.so: undefined symbol: Getname
The command "python test/test_suite.py" exited with 1.

@doutriaux1 master is now building successfully on linux should we amend the title of this issue to also get OS X working and then close this?

@doutriaux1 we've got OS X working too?

not yet I'll open an issue for osx


ppc64le: change dockerfile base from gcc to golang

Now that gccgo isn't supported, change the ppc64le dockerfile base image
from a debian:jessie based + gccgo image to a debian:jessie + golang image.
Also includes a go path change to be more consistent across Dockerfiles.
Signed-off-by: Christopher Jones<EMAIL_ADDRESS>

LGTM

LGTM


EACCES: permission denied

I'm trying to save a file that you need permission to be saved, but I'm not the vscode this option. For example in the sublime text he presents a modal requesting my password to allow me to save this file.
I have how to do the same in the vscode?
error
Failed to save 'hosts': A system error occured (EACCES: permission denied, open '/private/etc/hosts')

This would be more likely handed by code itself, you may want to file a ticket over @ [https://github.com/Microsoft/vscode] (https://github.com/Microsoft/vscode)
As this is a system file change you might be able to find a plugin to support sudo levelling, but I'm not sure.


Optimise combineReducers to avoid all reducers to be called on every action dispatched

Do you want to request a feature or report a bug?
This would be an optimisation for all users that define their action names as such:
const ADD_TODO_SUCCESS = '[todo] Add todo success' by preceding the action description with the state key name in square brackets on parenthesis '(todo) Add todo success', which from what I have experienced, most user do so.
What is the current behaviour?
Now the combineReducers function merges all reduces in such a way that on every action dispatched, all reducers are called. Considering a big store, with say 40 keys, and suppose we have 10 actions that are dispatched within 1-2 seconds at some point, we have 400 function calls, when it could be only 10, one for each action.
What is the expected behaviour?
combineReducers returns a combined reducer that shortcuts the function calls if the user defines the action names by prefixing them with the store key name in parenthesis (someStateKey)or square brackets [someStateKey]
Here's an example of how to accomplish that:
function getStateKeyFromAction(action) {
  const actionType = (action && action.type) || '';
  const keyMatches = actionType.match(/(?:\[|\().*?([a-zA-Z]+).*?(?:\]|\))/) || [null, '']
  const key = keyMatches[1]
  return key
}

Inside the function combination:
function combination(state = {}, action) {
  // existing code here

  const stateKey = getStateKeyFromAction(action)
  if (stateKey && state.hasOwnProperty(stateKey)) {
    const reducer = finalReducers[stateKey]
    const prevSubState = state[stateKey]
    const newSubState = reducer(prevSubState, action)
    if (typeof newSubState === 'undefined') {
      const errorMessage = getUndefinedStateErrorMessage(stateKey, action)
      throw new Error(errorMessage)
    }
    return newSubState === prevSubState ? state : { ...state, [stateKey]: newSubState  }
  }

  let hasChanged = false
  const nextState = {}
  for (let i = 0; i < finalReducerKeys.length; i++) {
    // more existing code here
  }
}

What do you folks think about this?

We've got an FAQ entry for this: https://redux.js.org/faq/performance#won't-calling-"all-my-reducers"-for-each-action-be-slow


Allow network selection for ssdp discovery

@PeterS1957:
Your issue is not related, but it's a valid request. Currently the interface that can connect to the internet is used. I could add a dropdown with the available networks and remember the last choice, while keeping current behaviour on the first start after installation.
Originally posted by @dheijl in https://github.com/dheijl/swyh-rs/issues/40#issuecomment-872925514

Should be fixed in 1.3.17 pre-release.


Make irradiance input names consistent across cmods

The global, beam and diffuse irradiance variables have different names across wfreader, irradproc, tcsgeneric_solar, pvwatts/pvsamv1, and pvwatts 1ts models.
In commit https://github.com/NREL/ssc/commit/9dfd5068bd8147ebbbd1cb094857e96332885a94 I changed the names of the first three to be consistent, with matching commits in https://github.com/NREL/SAM/commit/bd32aaab8020cb920bfbd3f3100d36a3c2d57e55 and https://github.com/NREL/SAM-private/commit/7d0e4b78ed4c4e11514f9a3bdb3dbfbead9439e8.
I am hesitant about changing the names for the PV models due to likelihood of breaking somebody's software that integrates, and figure we can either leave those alone using "diff", "beam" and "glob", or change the first three to those used by the pv models "gh", "dn" "dh".

If we are changing variable names, I would vote for more standard ones like dni, dhi, and ghi. Those are consistent with the nsrdb, pvlib.

Thanks, @cpaulgilman I like that as well, but none of the cmods listed use those standard ones. I think it's low-impact to change wfreader, irradproc, and tcsgeneric_solar, but pvwatts and pvsamv1 uses dn and df in the solar_resource_data. This would result in some folks needing to update their software eventually.
What we could do for the solar_resource_data users is to allow both dn and dni for a year or so, and throw up DEPRECATION warnings.

Relevant to this, there's an initiative to help the PV modeling community standardize on certain names: https://duramat.github.io/pv-terms/ . It's currently still in draft format, but ideally we would use the finalized names from something like this across all cmods, which I believe pvlib would also plan to upgrade to as well. @cwhanse do you have any other thoughts on this? Or insight into the status of the pv terms initative?

Relevant to this, there's an initiative to help the PV modeling community standardize on certain names: https://duramat.github.io/pv-terms/ . It's currently still in draft format, but ideally we would use the finalized names from something like this across all cmods, which I believe pvlib would also plan to upgrade to as well. @cwhanse do you have any other thoughts on this? Or insight into the status of the pv terms initative?

pvterms is an attempt to normalize names used in software and (hopefully) also to tag data, e.g. column names in csv files. The naming patterns are python friendly, it would be good to hear if the names are a problem for other languages.
pvlib will likely adopt a majority of these terms, but it will be a long process, since changing a function parameter's name needs to go through a deprecation cycle and isn't something pvlib developers take lightly.

Relevant to this, there's an initiative to help the PV modeling community standardize on certain names: https://duramat.github.io/pv-terms/ . It's currently still in draft format, but ideally we would use the finalized names from something like this across all cmods, which I believe pvlib would also plan to upgrade to as well. @cwhanse do you have any other thoughts on this? Or insight into the status of the pv terms initative?

pvterms is an attempt to normalize names used in software and (hopefully) also to tag data, e.g. column names in csv files. The naming patterns are python friendly, it would be good to hear if the names are a problem for other languages.
pvlib will likely adopt a majority of these terms, but it will be a long process, since changing a function parameter's name needs to go through a deprecation cycle and isn't something pvlib developers take lightly.

Thanks for the thoughts. I would like to just change wfreader, irradproc, tcsgeneric_solar to use dni, dhi, and ghi within SAM for now. The variable name "global" was causing issues for the irradproc class.
For the other, much more commonly used models, we can go through the same long deprecation cycle as pvlib once we're ready to start that.

Thanks for the thoughts. I would like to just change wfreader, irradproc, tcsgeneric_solar to use dni, dhi, and ghi within SAM for now. The variable name "global" was causing issues for the irradproc class.
For the other, much more commonly used models, we can go through the same long deprecation cycle as pvlib once we're ready to start that.


There is a problem in finalize operator page

Problem :
//output: 0,1,2,3,4,5....
Fix
//output: 0,1,2,3,4....
https://www.learnrxjs.io/learn-rxjs/operators/utility/finalize
https://i.imgur.com/XHq1PHv.png

I believe this is official docs: finalize
So Author of what you have found there is Brian Troncone

I believe this is official docs: finalize
So Author of what you have found there is Brian Troncone


Dependabot improvements

Description
This PR contains two Dependabot related improvements:

Dependabot can generate commit messages that don't comply with our commitlint rules. To prevent those from failing our CI checks, we now ignore them from commit linting. This required changing the configuration file from JSON to JavaScript.

By default, Dependabot creates commits with type "chore". Changed the type to "deps" which is the correct type for dependencies in our projects. "chore" was particularly problematic because it doesn't cause release-please to create a new release.

Related Issue(s)
RAT-201

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr423-ui.dev.hel.ninja :rocket::rocket::rocket:

e2e tests result is success for https://linkedcomponents-pr423-ui.dev.hel.ninja :laughing::tada::tada::tada:


gRPC index support for Pinecone

gRPC context : https://docs.pinecone.io/docs/performance-tuning
Presently, the method to initialize a Pinecone vectorstore from an existing index is as follows -
 index = pinecone.Index(index_name)
docsearch = Pinecone(index, hypothetical_embeddings.embed_query, 'text')
gRPC offers performance enhancements, so we'd like to have support for it as follows -
 index = pinecone.GRPCIndex(index_name)
docsearch = Pinecone(index, hypothetical_embeddings.embed_query, 'text')
Apparently GRPCIndex is a different type from Index

ValueError: client should be an instance of pinecone.index.Index, got <class 'pinecone.core.grpc.index_grpc.GRPCIndex'>

I have the same problem.

I have also same problem

pip3 install pinecone-client[grpc]

pip3 uninstall pinecone-client
pip3 install -U "pinecone-client[grpc]"

Following up on an issue with the current approach. Pinecone automatically converts metadata text to datetime objects if it is possible. This behavior is often more harmful than good.
Pinecone forums recommend a GRPPCIndex implementation instead of the Index if we don't want a conversion issue.
@dosu-bot

@XariZaru Yes, but still when instantiating vectorestore with GRPCIndex there is still an error
ValueError: client should be an instance of pinecone.index.Index, got <class 'pinecone.core.grpc.index_grpc.GRPCIndex'>


Add clean commands to all packages

It would be useful to add commands to remove lib, node_modules, and any other files that shouldn't be there, with a script.

closed by #52


Form Builder - User flow feels wrong when signing-in after creating a form in an unauthenticated way

If you create a form while not being logged-in but you decide to sign-up/sign-in at the end of the process when trying to publish it you will "lose" your form because the sign-in process will redirect you to the /myforms page.
However, you can still hit the browser previous button until you get back to your form which will have been saved by the local store.
https://user-images.githubusercontent.com/1763961/203595549-38da23ab-387d-4992-9b65-7e97029dfccf.mov

@srtalbot All users. I also tested the scenario with my Cognito account using my TBS email address.

@timarney
Can we add a link on this page to get back to the form builder? If I log in with my CDS account, it directs me here, and there is no easy way to get back.

How about we add a link under "Create Forms"

GC Forms
Upload Form Templates ... thinking this can go away as well but might be needed for a bit?

That sounds perfect.
Until we have all the functionality needed, like file upload and dynamic row, we'll need to keep the upload template.


Cookbook icon

Cookbook icon is clickable but text isnt

Any update on this ?

Fixed the issue, the cookbook icon is now clickable


Demo5 horizontal scroll view will mix up after pulling

Demo5

enter play mode
pull left (or right) then release
new items are loaded and the view will be a mix up.

I found that it's caused by the following commit. If I comment out the call to ScrollTo(index), it will be fine.
26627ae - fix: update the scroll position by a scrollbar
// by https://github.com/webitube
// Note: If the scroller position changed but the scroll velocity is exactly zero, the movement was done via a scrollbar. In this case, we need to ScrollTo() the indicated position directly.
// Note 2: The normalized scrollbar position is opposite from the ScrollTo() index. This is why the we take (1.0 - pos) instead of pos directly.
if (_scroll.velocity.magnitude == 0.0f) {
    var pos = (Type == 0) ? vector.y : vector.x;
    var index = Mathf.RoundToInt(_count * (1.0f - pos));
    ScrollTo(index);
}

https://github.com/user-attachments/assets/cb6b700b-594e-4e31-a8ea-3742d3aee7ba

Thanks, will check it


An inexplicable white rectangle

Issue Type: Bug
White opaque rectangles of different sizes often appear in the editor interface, without any text on them, and their appearance positions are not fixed. Sometimes they appear in the code writing area, sometimes in the side tree directory area, and sometimes in the top line of the menu bar. Their display level is very high, which will prevent the interface. When I move the mouse, they will also change their positions. I don't know how to trigger it to appear, nor how to make them disappear. So I caught the picture of it.
VS Code version: Code 1.69.2 (3b889b090b5ad5793f524b5d1d39fda662b96a2a, 2022-07-18T16:12:52.460Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E3-1230 V2 @ 3.30GHz (8 x 3292)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: unavailable_offraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: unavailable_offvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.97GB (2.55GB free)

Process Argv
--crash-reporter-id f6688489-470d-48a2-876d-5bf566e5ed2b

Screen Reader
no

VM
0%

Extensions (21)

Extension
Author (truncated)
Version

html-snippets
abu
0.2.1

cssrem
cip
3.0.0

vscode-eslint
dba
2.2.6

daily-anime
dee
1.2.0

jquerysnippets
don
0.0.1

vscode-html-css
ecm
1.13.1

vscode-element-helper
Ele
0.5.6

prettier-vscode
esb
9.5.0

vue
jcb
0.1.5

vscode-fix-checksums
leh
1.1.0

vscode-language-pack-zh-hans
MS-
1.69.7130921

debugger-for-chrome
msj
4.13.0

vscode-vue2-snippets
Nic
1.1.1

vetur
oct
0.35.0

material-icon-theme
PKi
4.19.0

any-rule
rus
0.3.15

rainbow-fart
sae
1.4.1

background
sha
1.2.1

vscode-scss-formatter
sib
2.4.3

html5-boilerplate
sid
1.1.1

JavaScriptSnippets
xab
1.8.0

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
pylanb8912:30529769
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253

![1659689749456](https://user-images.githubusercontent.com/54619541/183042783-96762f30-722d-41f2-bc6c-0e0f816d1d15.jpg)
![1659689769277](https://user-images.githubusercontent.com/54619541/183042807-55131def-aaef-4113-b34d-e4c5f2a334d3.jpg)

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


✨[Feature Request]: Sending "thank you" emails when subscribed to newsletter

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I would like to add a feature that automatically sends a "thank you" email to users when they subscribe to newsletter using EmailJS. This will involve capturing the subscriber's email address, and using EmailJS to send a personalized HTML email from<EMAIL_ADDRESS>to the subscriber. This enhancement will improve user engagement and provide immediate acknowledgment to new subscribers.
Use Case
Implementing this feature would greatly enhance user engagement and satisfaction by providing immediate acknowledgment and gratitude to users who subscribe to the newsletter. It creates a positive experience for users, fostering a sense of appreciation and connection with the project.
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@Anishkagupta04 please assign this issue to me under gssoc


Update CHANGELOG.md

leftover from #2165

Trying out the simplified workflows for markdown-only changes

simplified workflows for markdown-only change seems to work now. (Still needs to confirm with a changes that touches both markdown and non-markdown files....


Make it easier to use Quiche in projects that already link OpenSSL

Overview
Currently Quiche builds a static library that includes BoringSSL. Unfortunately this can't be linked into projects that already link OpenSSL because there will be symbol conflicts. To solve this issue we can also build a dynamic library alongside the static one. The change is pretty simple, just add cdylib as a crate type in Cargo.toml and fix the Makefile  in examples/ so that it still picks up the static library. I guess that other people will also encounter this problem, so I've added a small paragraph in the Readme explaining how to use Quiche in projects that already link OpenSSl.
I've also added a clean target to the Makefile in examples/.
Possible problems
The only problem I can think of is that if you have a static and dynamic library in the same directory gcc  will pick the dynamic one. If Quiche starts building a dynamic library alongside the static one some existing C/C++ projects that link Quiche might experience problems.

Thanks! Maybe we can go a step further and just build BoringSSL with -fvisibility=hidden by default. So we wouldn't need the note in the README and it would just work out of the box, what do you think?

Thanks! Maybe we can go a step further and just build BoringSSL with -fvisibility=hidden by default. So we wouldn't need the note in the README and it would just work out of the box, what do you think?

Good call-out. Turns out that BoringSSL  by default is compiled with -fvisibility-hidden under GCC or Clang, and MSVC does not export symbols anyway. - https://github.com/google/boringssl/blob/master/CMakeLists.txt#L126
I'll remove the instructions from the Readme.

Merged as 57e2936bdf49c3b9239f468470109d5689066d77, thanks!
It turned out that BoringSSL also needs to be built with -fPIC in release mode (but Travis CI didn't catch this because the library was only built in debug mode there), so I added that as well. Also slightly tweaked the examples Makefile since we already had a clean target.


How to super-res highly compressed gif?

   orig gif
 super-res 2x gif

Emmmm, I think it is very challenging. We should re-train the model.
It is a to-do job, but it may has low priority~


set_bits

This PR violates contributing guidelines. Don't make multiple PRs for questions of same company.


normalize should have access to props

Are you submitting a bug report or a feature request?

feature request
What is the current behavior?

normalizer does not receive all props
What is the expected behavior?
normalizer receives all props so that stuff like min, max can be dealt with dynamically.
What's your environment?

redux-forms version 6.5.0^
Other informations

What's the use case?
I usually end up creating a closure for normalize if it depends somehow on props and it works pretty well.

A generic normalize function which should be scope/closure agnostic.

What props do you talk about, the field or the input?


feat(Pydantic): added parameters in pydantic plugin to support strict validation and all the model_dump args

Combines the following stale PRs:

#3573
#3327

Closes #3572 and #3147
Context: https://github.com/litestar-org/litestar/pull/3327#issuecomment-2171148195

@kedod can you review this one as well?

@provinzkraut, is there a specific format for docstrings that I should use?

@all-contributors add @Anu-cool-007 for code


An error arises when creating a new emulator blob container

Storage Explorer Version: 1.14.0-dev
Build: 20200518.1
Branch: master
Platform/OS: Windows 10/ Linux Ubuntu 16.04/ macOS Mojave
Architecture: ia32/x64
Azurite Version: 3.7.0
Regression From: Previous release (1.13.0)
Steps to reproduce:

Install and run azurite -> Launch Storage Explorer.
Expand 'Local & Attached' -> Storage Accounts -> (Emulator - Default Ports) (Key).
Create a new blob container -> View the result.

Expect Experience:
Succeed to create the emulator blob container.
Actual Experience:

An error arises.
The created blob container displays on the tree view.

  InvalidHeaderValue The value for one of the HTTP headers is not in the correct format. RequestId:8ceb6607-50cc-4c19-aad6-6ae366729819 Time:2020-05-18T09:54:07.404Z x-ms-version 2019-10-10
More Info:
This issue also happens when opening one existing blob container.

This issue is fixed on build master/20200520.4. So we close it.


[DOC] - Create landing page video/gif

Preliminary Checks

[X] This issue is not a question, feature request, RFC, or anything other than a bug report. Please post those things in GitHub Discussions: https://github.com/nebari-dev/nebari/discussions

Summary
xref: #182
This issue is to track and iterate on the video/gif for the "Get started" section of the landing page.
Steps to Resolve this Issue

...

@trallard Here is the video demo we made for PyData NYC: link to upload on google drive (1:26 minutes long)
Shall we use this same video for the website, with the end slide updated to say something like "Get started: nebari.dev/docs"? Or, we can also remove the intro and end slides all together.
Would you like to make any other updates to the video?

how would we add this to our landing page? - we need to make sure we have a reliable source and that the way we embed this is not too problematic
maybe we could create a smaller/shorter gif?

@trallard Here is a shorter GIF with only Nebari deployment!
What do you think? Would you like to make any changes?

This will definitely work! Thanks for sorting this so quickly. Please go ahead and share with Gabriel


Query elapsed time not shown anymore

My dbeaver has stopped showing the timings in the info box at the bottom of the query results panel (where the number of rows in the result is shown). I haven't found a setting that could re-enable this. Google doesn't help either. How can I get the timings back? Thanks.
I'm connecting to a PostgreSQL and am using the latest build 3.8.5 on Ubuntu.

Yep, it's a known issue, already fixed in 4.0. You can try EA version to validate (http://dbeaver.jkiss.org/files/ea/).

Thanks for the quick response. Indeed, it works on version 4.0. Thanks!


Inspecting an empty dict causes the compiler to panic

This code should reproduce the issue:
app [main] {
    pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.15.0/SlwdbJ-3GR7uBWQo6zlmYWNYOxnvo8r6YABXD-45UOw.tar.br",
}

import pf.Stdout

main =
    emptyDict = Dict.empty {}
    Stdout.line! (Inspect.toStr emptyDict)

I get this error:
$ roc empty-dict.roc
thread '<unnamed>' panicked at crates/compiler/mono/src/ir.rs:6151:56:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The error goes away if I add a type annotation to emptyDict, such as:
emptyDict : Dict Str U64

It looks like ability implementations don't know how to specify for non-existent types. Which makes sense that it wouldn't be handled.


LOG files

Description of the new feature / enhancement
I use Udeler on Windows and I would like to have a file that contains a copy of the Logger information, so that I don't have to do a copy paste manually. How can I achieve such a thing?
Scenario when this would be used?
This allows for a reminder of any protected or problem parts of a downloaded

@mickybusy
Available in version 1.11.5.
https://github.com/heliomarpm/udemy-downloader-gui/releases/latest


[Wi-Fi fix] Maintaners please update kext for itlwm (for Ventura)

@simprecicchiani
Based on #172 issue
Finally Wi-Fi is working properly on v2.2.0 of itlwm on Ventura
https://github.com/OpenIntelWireless/itlwm/releases/tag/v2.2.0 (AirportItlwm_v2.2.0_stable_Ventura.kext.zip)
The issue with Wi-Fi is fixed here: https://github.com/OpenIntelWireless/itlwm/issues/799
Please update file AirportItlwm-13.kext with replacing to new patch of itlwm to same name 🙏

to other people who have this same issue: drop the latest release of the kext over your already existing (old and broken) one. it works perfectly fine without issue for me

Everyone is welcome to fork the repo and create a pull request


add --random-fully to MASQUERADE rule to reduce the chance of insertion failure

See https://tech.xing.com/a-reason-for-unexplained-connection-timeouts-on-kubernetes-docker-abd041cf7e02 for background.

@dbyron0 Thanks for the fix! Can you please sign the CLA so we can merge this fix and push out a new release?

I signed it, but the check still shows as failing.  When I click on details above (https://oss.lyft.com/cla/) it says "Signed and current (1.0)"

I can push e.g. an empty commit to the branch if that helps.

Welp, that didn't help.  Removing it...

Happy to help.

  Sorry for the trouble.

Very good idea!
This issue was a lot worse for us when we used kube-proxy in iptables mode


Not able to capture user input on internal terminal when debugging JAVA file

From @JerryGoyal on September 10, 2017 6:45

VSCode Version: 1.16
OS Version: Win10

Steps to Reproduce:

Install java debugger extension https://marketplace.visualstudio.com/items?itemName=donjayamanne.javaDebugger
configure launch.json:

{
    "version": "0.2.0",
    "configurations": [

        {
            "name": "Debug Java",
            "type": "java",
            "request": "launch",
            "externalConsole": false,                //user input dosen't work if set it to false :(
            "stopOnEntry": true,
            "preLaunchTask": "build",                 // Runs the task created above before running this configuration
            "jdkPath": "${env:JAVA_HOME}/bin",        // You need to set JAVA_HOME enviroment variable
            "cwd": "${workspaceRoot}",
            "startupClass": "${workspaceRoot}${file}",
            "sourcePath": ["${workspaceRoot}"],   // Indicates where your source (.java) files are
            "classpath": ["${workspaceRoot}"],    // Indicates the location of your .class files
            "options": [],                             // Additional options to pass to the java executable
            "args": []                                // Command line arguments to pass to the startup class
        }

    ],
    "compounds": []
}

Configure tasks.json:

{
    "version": "2.0.0",
    "type": "shell",
    "presentation": {
        "echo": true,
        "reveal": "always",
        "focus": false,
        "panel": "shared"

    },

    "isBackground": true,
    "tasks": [
        {

            "taskName": "build",
            "args": ["-g", "${file}"],
            "command": "javac"

        }
    ]
}

Now debug any java file which accepts user inputs. VS Terminal won't be able to capture those inputs.
Note: External console i.e. cmd works fine if I choose it to "externalConsole": true but not internal terminal.

Copied from original issue: Microsoft/vscode#34091

From @roblourens on September 10, 2017 19:25
I'm not sure what you mean by "VS Terminal won't be able to capture those inputs." Is that because it's not running the app in the integrated terminal? If so, this is a feature request for the extension.

VS terminal is the internal terminal of VS code. I've set the externalConsole": to false in launch.json but still i can't type anything in the terminal , i only see outputs of print statements. I'm not sure if this is the bug on extension side or your side. Your call.

From @Tyriar on September 11, 2017 17:6
I believe this is as designed, @isidorn can clarify

From @roblourens on September 11, 2017 17:20
Is it running in the terminal or the "debug console"?

From @isidorn on September 13, 2017 8:46
This is as designed, for programs that need input please use the external terminal.
There is probably already a feature request open that we start suporting user input in debug console / internal terminal.
@weinand would know more
Closing as designed

when I debug a java file:
In internal terminal(cmd) i see: >
Executing task: javac -g c:\Users\H213141\Documents\coding\console\java-debug\TestClass.java <

Terminal will be reused by tasks, press any key to close it.

but i can't provide user input here.
In debug console i see the program output ( i.e. System.out.println("provide some input:");) if any. But I can't provide any user input here. Although i can debug variables in debug console.

From @weinand on September 13, 2017 9:53
Please move the issue to the repository of the Java debugger you are using. VS Code provides no built-in Java functionality, so we do not know what the problem is.
You can move the issue with this tool: https://github-issue-mover.appspot.com

VS Code does take user inputs from internal terminal when we "run" the code (Java,c++, python etc). The problem comes when we "debug" the code.

Hi, seems like this issue is related to the java debugger extension. So I moved it from Microsoft/VSCode to your repo. Could you please take a look.

Please, next time comment just one, because one comment is one mail, I was a bit scared to see so many mails :sweat_smile:
And yeah, Java Debugger doesn't support integrated terminal yet, if you want to contribute send a  PR :smile:

Didn't mean to scare you :D Actually, I used some issue migrator tool to migrate this issue from Microsoft repository and it included previous comments too, hence the email bombardment :P

@faustinoaq supporting the VS Code integrated terminal is trivial since VS Code is doing all the heavy lifting for you. From the debug adapter just use the "runInTerminalRequest" and pass the command line arguments. See here how this is done for node-debug.

Oh, I see. Thanks you for the node-debug reference :+1:

Keep discussion here :point_right: #67

Reopen as suggested here


Kafka 1.0.x support, take 2

Current coverage is 73.00% (diff: 93.39%)

Merging #223 into master will increase coverage by 0.58%

@@             master       #223   diff @@
==========================================
  Files            68         68
  Lines          4500       4490    -10
  Methods           0          0
  Messages          0          0
  Branches        589        533    -56
==========================================
+ Hits           3259       3278    +19
+ Misses         1095       1069    -26
+ Partials        146        143     -3

Powered by Codecov. Last update b69c468...1463478

@Preetwinder pls have a look!

LGTM, nothing stuck out to me.

Now it works as it should be 👍

Oh, finally!!!


jenkins deployment scripts

Create the scripts necessary for full tear down and rebuild via jenkins issued job

[x] Backup database and media files
[x] Backup relavant deployment files
[x] Purge all docker related containers / images (dockerPurge.sh)
[x] Remove entire hydroshare directory
[x] Restore hydroshare repository with clean clone and deployment files in place
[x] Deploy HydroShare application (deploy-hs)

Running successfully on jenkins --> dev.hydroshare.org


Bump jmespath dep to latest version 0.7.1

This fixes a regression reported in the AWS CLI: https://github.com/aws/aws-cli/issues/1306
cc @kyleknap

:ship:

Coverage decreased (-0.02%) to 94.44% when pulling 07f8274a5154b497f677c2c1a37130c6605f44ed on jamesls:bump-jmespath-071 into 60e72b22bdebfa83e9b964aca232c7cad572212e on boto:develop.


How to achieve MVVM without Room

Hi
First off all thanks for the nice example for mvvm. Actually my project we don't want to use local database(Room). Can you help me how I can achieve the same using this project as reference.
Thanks in Advance.

@aptgopal , Since DbHelper is an interface, you can simply replace its implementation class AppDbHelper ( related to Room) with another one. Don't forget also update the injections in AppModule.


Add PUT for setting a company as primary company

This PR adds a call we have overlooked so far in implementing.
It also fixes a typo in the similar call to set a school as the primary school.
Therefore this PR adds a breaking change.

I also added a changelog.

Looks good to me, thanks for the changelog :+1:

Thanks!


C++ compilation error for fused type in __cinit__

Describe the bug
An extension type definition with fused type in __cinit__ leads to a C++ compilation error. I am not sure if this is because my code is not valid Cython or there is a bug.
To Reproduce
Code to reproduce the behaviour:

ctypedef fused ndcomplexview_t:
    complex[::1]
    complex[:, ::1]
    complex[:, :, ::1]

cdef class Foo:
    cdef complex *data
    def __cinit__(self, ndcomplexview_t arr):
        if ndcomplexview_t is complex[::1]:
            self.data = &arr[0]
        elif ndcomplexview_t is complex[:, ::1]:
            self.data = &arr[0, 0]
        elif ndcomplexview_t is complex[:, :, ::1]:
            self.data = &arr[0, 0, 0]

throws:
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
/home/fmheu/.cache/ipython/cython/_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d.cpp:2918:110: error: expected primary-expression before 'static'
 static PyMethodDef __pyx_fuse_0__pyx_mdef_46_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d_3Foo_3__cinit__ = static int __pyx_fuse_0__pyx_pw_46_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d_3Foo_3__cinit__(PyObject *__pyx_v_self, PyObject *__pyx_args, PyObject *__pyx_kwds) {
                                                                                ^~~~~~
/home/fmheu/.cache/ipython/cython/_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d.cpp:2969:1: error: expected ',' or ';' before 'static'
 static int __pyx_pf_46_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d_3Foo_2__cinit__(struct __pyx_obj_46_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d_Foo *__pyx_v_self, __Pyx_memviewslice __pyx_v_arr) {
 ^~~~~~
/home/fmheu/.cache/ipython/cython/_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d.cpp:3020:110: error: expected primary-expression before 'static'
 static PyMethodDef __pyx_fuse_1__pyx_mdef_46_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d_3Foo_5__cinit__ = static int __pyx_fuse_1__pyx_pw_46_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d_3Foo_5__cinit__(PyObject *__pyx_v_self, PyObject *__pyx_args, PyObject *__pyx_kwds) {
                                                                                ^~~~~~
/home/fmheu/.cache/ipython/cython/_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d.cpp:3071:1: error: expected ',' or ';' before 'static'
 static int __pyx_pf_46_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d_3Foo_4__cinit__(struct __pyx_obj_46_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d_Foo *__pyx_v_self, __Pyx_memviewslice __pyx_v_arr) {
 ^~~~~~
/home/fmheu/.cache/ipython/cython/_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d.cpp:3128:110: error: expected primary-expression before 'static'
 static PyMethodDef __pyx_fuse_2__pyx_mdef_46_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d_3Foo_7__cinit__ = static int __pyx_fuse_2__pyx_pw_46_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d_3Foo_7__cinit__(PyObject *__pyx_v_self, PyObject *__pyx_args, PyObject *__pyx_kwds) {
                                                                                ^~~~~~
/home/fmheu/.cache/ipython/cython/_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d.cpp:3179:1: error: expected ',' or ';' before 'static'
 static int __pyx_pf_46_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d_3Foo_6__cinit__(struct __pyx_obj_46_cython_magic_fed3fa8885216b9d3fc7a5864874ea9d_Foo *__pyx_v_self, __Pyx_memviewslice __pyx_v_arr) {
 ^~~~~~

Expected behavior
I would expect an error in Cython compilation step, if above is not allowed in Cython.
Environment (please complete the following information):

OS: Linux
Version 0.29.21 and 3.0a5

I suspect this is a duplicate of https://github.com/cython/cython/issues/1359 (but it's a little light on details).
It probably should work, or at least fail earlier and with a clearer message.
If you're looking for a workaround you could probably do something like:
ctypedef fused ndcomplexview_t:
    complex[::1]
    complex[:, ::1]
    complex[:, :, ::1]

def actual_cinit(Foo self, ndcomplexview_t arr):
        if ndcomplexview_t is complex[::1]:
            self.data = &arr[0]
        elif ndcomplexview_t is complex[:, ::1]:
            self.data = &arr[0, 0]
        elif ndcomplexview_t is complex[:, :, ::1]:
            self.data = &arr[0, 0, 0]

cdef class Foo:
    cdef complex *data
    def __cinit__(self, arr):
        actual_cinit(self, arr)

Indeed, moving the type declarations out of the __cinit__ arguments avoids the problem. Thanks for the workaround!

Hey quick question regarding this workaround, the answer to which may be generally enlightening for some stuff going on under the hood within Cython. Does the required omission of typing information for this workaround incur python overhead due to the need to handle the "arr" argument in cinit as a general python object? Or is such python overhead ALWAYS incurred by cinit and other special methods due to them being def instead of cdef?

There's always Python overhead in calling __cinit__. The point of redirecting to actual_cinit is that within actual_cinit you have a known memoryview type that you can use (for example by indexing into it quickly). The point is not to avoid overhead when calling - it's to get Cython to figure out the types when you call it, and use those types.
If you want to call it from Cython with known types quickly then use that @staticmethod factory function approach, and move the work out of __[c]init__

There's always Python overhead in calling __cinit__. The point of redirecting to actual_cinit is that within actual_cinit you have a known memoryview type that you can use (for example by indexing into it quickly). The point is not to avoid overhead when calling - it's to get Cython to figure out the types when you call it, and use those types.
If you want to call it from Cython with known types quickly then use that @staticmethod factory function approach, and move the work out of __[c]init__

Right, I suppose the purpose of the redirection to somewhere where the type information could actually be made use of should have been rather obvious lol - ty for the explanation (:


Improper handling of [Initialization(InitializationLevel.Skip)] in Installer/Factory

While constructor parameter omits fields with Skip Initialization, constructor body crates them like the attribute is not there.

Bug description desccribes behaviour, that is correct, but unexpected. Documentation needed.


Error: Kubernetes cluster unreachable:

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
helm install cilium cilium/cilium --version 1.11.1 \

--namespace kube-system
Error: Kubernetes cluster unreachable: Get "http://localhost:8080/version?timeout=32s": dial tcp [::1]:8080: connect: connection refused

Why is this？
Cilium Version
-bash: cilium: 未找到命令
Kernel Version
Linux k8s-master 3.10.0-1160.53.1.el7.x86_64 #1 SMP Fri Jan 14 13:59:45 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Kubernetes Version
Kubernetes v1.23.3
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @sorryforyou, can you add some more detail on the setup please? Is this a managed environment?

Hi @sorryforyou, can you add some more detail on the setup please? Is this a managed environment?

HI @jibi ，This is the cluster I built on my own server. The cluster has been initialized and has not joined any nodes. The installation command is based on the information on the official document。

Hi @sorryforyou, can you add some more detail on the setup please?  The cluster has been initialized and has not joined any nodes. The installation command is based on the information on the official document。

This seems unrelated to Cilium :thinking:
Is access to the cluster correctly configured on the machine where you are running the helm command? (e.g. does kubectl work?)

Hi @sorryforyou but this doesn't seem related to Cilium. Double check if your terminal has access to the kubernetes cluster so that helm command can work. Try using cilium/cilium-cli instead.

I was running into this issue https://github.com/techno-tim/k3s-ansible/discussions/448#discussioncomment-8655513. I think the installer uses the KUBECONFIG environment variable to locate the k3s cluster. If it can't find it, it defaults the cluster address to http://localhost:8080/


Refactor code with shorter variables and improved error messages

Updated the code with shorter function parameters and improved error messages.

Closing as this is succeded by #4


multBy method use the incr？

public String multBy(String key, String path, long num) {
    return commandExecutor.get(incrByAsync(key, path, num));
}

@JarvisZhu Hey, Thanks for reporting this issue. Would you be interested in helping to fix it? : )


API is down

Go to site and click on controllers or search for anything. only loading spinner is shown and nothing loads
https://production.contosotraders.com/

@MarcusFelling: This looks related to the ingress controller changes.
https://github.com/microsoft/contosotraders-cloudtesting/pull/299

@MarcusFelling: Related to the ingress controller changes? #299
FWIW: Weirdly, this issue only repro'es in prod and NOT in staging. I'm re-deploying to prod to see if this does the trick.

No, the products API runs on App Service, not AKS. I restarted the Web App and it's working now. I had a presentation yesterday to demo load testing, so I just cleaned up in case that was the correlated.


Added Tech stack Section in ReadMe

Resolved Issue #37; Added Tech Stacks used in ReadMe Section.

Could you make like this one?
Yes


podman does not create console if -t is present in noninteractive shell

/kind bug
Description
If we run podman exec -t  in non-interactive shell, it does not create console.
Steps to reproduce the issue:

podman run --rm -d --name test ubi8 sleep 1000

run this command in non-interactive shell:
podman exec -t test date
Describe the results you received:
exec failed: provided file is not a console
Error: exit status 1
Describe the results you expected:
It should work as with docker.
Additional information you deem important (e.g. issue happens only occasionally):
Output of podman version:
podman version 1.4.4

Hi @kubco2, thanks for opening the issue. Can you share the output of podman info --debug and podman --log-level=debug exec -t test date? I am unable to reproduce it on my Fedora 30 machine.

Hi, looks like it is fixed in master branch. Probably with this commit https://github.com/containers/libpod/commit/a1a79c08b72793cf2f75490d8ffc844c3d16bd4a

I don't think the issue is actually solved - conmon exec just introduced a new one over it.

Oh, nevermind. Working as advertised, per comparison with Docker. Neat.


Fix compatibility with Python > 3.10

Fix Module Loading for Compatibility with Python 3.10+
Problem
The thefuck project currently uses the imp module for loading source files dynamically, but this module has been deprecated since Python 3.4 and removed entirely in Python 3.10. As a result, users running Python 3.10+ encounter the following error:
ModuleNotFoundError: No module named 'imp'

Solution
This PR introduces a solution that maintains backward compatibility by replacing imp with importlib.util for Python 3.5+ while providing a fallback to importlib.machinery.SourceFileLoader for Python 3.3 and 3.4. For even older versions, it keeps the final fallback to imp, ensuring compatibility across a wide range of Python versions.
Changes

Replaced the imp module import with the following structure:

Use importlib.util for Python 3.5+.
Use importlib.machinery.SourceFileLoader for Python 3.3 and 3.4.
Retain the imp module for Python versions below 3.3.

Ensured the changes do not affect existing functionality on older Python versions.

Impact

Python 3.10+ users should no longer encounter the ModuleNotFoundError.
Existing users on older Python versions should see no changes in behavior.
Windows should now be fully compatible

Resolved Issues
This PR closes the following issues:

Fixes #1460, Fixes #1464, Fixes #1467, Fixes #1434, Fixes #1433, Fixes #1418, Fixes #1381

I'm hoping that's all of them, sorry if I missed any.

Can we get this approved? Would love to start using this again.

I just did
pip install https://github.com/DJStompZone/thefuck/archive/master.zip
And it worked

man ! thank you

A similar pr is needed for distutils

To fully support python 3.12 it's also needed to also merge #1404


Route with Custom Key and Scoping ignoring Eloquent Model's resolveRouteBinding()

Laravel Version: 8.10.0
PHP Version: 7.4.0
Database Driver & Version: MariaDB 10.4.7

Description:
I have a custom route binding resolver through a Trait I made and it works fine until I need to use Route Scoping, then it completely ignores it. I haven't seen any guidance regarding doing another function specifically for scoping on the docs ( https://laravel.com/docs/8.x/routing#implicit-model-binding-scoping ) .
Steps To Reproduce:
app/User.php
public function posts()
{
    return $this->hasMany(Post::class);
}

app/Post.php
use App\Traits\HasHashidRoute;

public function user()
{
    return $this->belongsTo(User::class);
}

app/Traits/HasHashidRoute.php
trait HasHashidRoute
{
    /**
     * @see parent
     */
    public function resolveRouteBinding($value, $field = null)
    {
        if ($field === 'hashid') {
            $field = null;
            $value = $this->decodeHashid($value);
        }
        return parent::resolveRouteBinding($value, $field);
    }
}

routes/web.php
Route::get('users/{user}/posts/{post:hashid}', [PostController::class, 'show']);

app/Http/Controllers/PostController.php
use App\{Post, User};
public function show(User $user, Post $post)
{
    return $post->load(['user']);
}

Error:
Browse to https://local/users/11/VAw9eEpl54JQRvld then you will get:
Illuminate\Database\QueryException
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'hashid' in 'where clause'
SELECT *
FROM `posts` where `posts`.`id` = 11
  AND `posts`.`id` IS NOT NULL
  AND `hashid` = 'VAw9eEpl54JQRvld'
  AND `posts`.`deleted_at` IS NULL
LIMIT 1

Workaround:
If I change the controller function to the way below, it works fine.
public function show($user, Post $post)
{
    if ($post->user_id != $user) {
        return abort(404);
    }
    return $post->load(['user']);
}

It seems that this issue ( #31946 ) was ignored months ago on Laravel 7.
The bug remains unfixed or the right way of doing it remains undocumented.

So what is the problem exactly? Does your posts table not have a hashid column?

When using implicit scoped binding, we don't call resolveRouteBinding, we call resolveChildRouteBinding.

So what is the problem exactly? Does your posts table not have a hashid column?

Nope, it's a hashid that's decoded and then the query looks for the primary key (usually id) with the decoded input. (translate an youtube-like ID to regular integer PK)

When using implicit scoped binding, we don't call resolveRouteBinding, we call resolveChildRouteBinding.

I tried to add the function below into app/Posts.php and into the app/Traits/HasHashidRoute.php but it didn't seem to work.
public function resolveChildRouteBinding($childType, $value, $field) {
    dd('a');
}

Screenshot below:

Nevermind, it worked, the function needs to be on the parent, which in this case it'sApp\Model\User.
It kinda breaks the trait design the way I did because for this I would need to add the Trait on both App\Model\Post and App\Model\User, but it makes sense.
I would appreciate having a note with this function on Laravel Docs thou. 😞

@icaroscherma feel free to send in a PR to the docs if you think anything should be clarified further 👍

@driesvints I'm not sure if I used the right wording but I just sent a PR with that. ;) Thanks for encouraging that.


detailed_info_GetInteriorVehicleDataCapabilities_1.md

use case for Requirement #1

App requests RC capabilities of available modules with corresponding control items

No parameters in the GetSystemCapability request to indicate "available modules". SDL just give all available in RemoteControlCapabilities.

SDL checks if requested modules are allowed by Policies.

This is old requirement. Not needed any more for GetSystemCapability request with REMOTE_COTNROL system capability type .

Alternative flow 1

6.a.1 One of the requested modules is not available on HMI

6.a.2 SDL transfers to mobile application capabilities of available on HMI module and responds with WARNINGS "%moduleType% is not available" for anavailable module

no longer apply

I created this PR before GetInteriorVehicleCapabilities were changed to GetSystemData. As of now keep this branch open just as a spare with opportunity to change it later, since GetSystemCapability is out of our scope

looks good to me


Add custom delimiter option

Users can now choose "sane" delimiter options such as:
"~", "+", "/", "#", among others.
Sticking with old ES5 syntax for forming strings.
Regex limits delimiters to certain sane delimiter values i.e. https://en.wikipedia.org/wiki/Delimiter-separated_values
Defaults to "-"
I think project is kinda old but we can add a tiny feature to it, probably not very useful though.

MFW i didn't see PR #2. FFS.

I guess the string padding at at the ends of the delimiter should be removed.
i.e " / " should be "/"


Tracing: redact query params in urls

We didn't sanitize URLs for tracing purposes. Fixing it:

this change implements the same redaction as on logs
adds allowed query params to tracing options.
Unfortunately it's not possible to reuse existing logging options for it (HttpLogOptions are not available in the pipeline 😢 )

It also includes a small refactoring in HttpLoggingPolicy and removes doble-logging of content-length if headers are enabled.

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure:azure-core


SF-1243: updateQuery action sets original and clears query state

Codecov Report

Merging #42 into master will increase coverage by 0.05%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   92.97%   93.03%   +0.05%
==========================================
  Files         203      201       -2
  Lines        5268     5298      +30
  Branches      641      641
==========================================
+ Hits         4898     4929      +31
+ Misses        283      282       -1
  Partials       87       87

Impacted Files
Coverage Δ

...ont/flux-capacitor/src/core/reducers/data/query.ts
0% <0%> (ø)
:arrow_up:

<EMAIL_ADDRESS>100% <0%> (ø)
:arrow_up:

...storefront/navigation/src/refinement-pill/index.ts
100% <0%> (ø)
:arrow_up:

<EMAIL_ADDRESS>100% <0%> (ø)
:arrow_up:

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>100% <0%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c5b8ed...b470c36. Read the comment docs.


Sync from instructlab

ebead99 Makefile: Fix check target to reference the correct repo
9457160 Sync from instructlab
Closes #5
commit ebead993ecbcc0b26007bc50c186ad712a4918d8
Author: Russell Bryant<EMAIL_ADDRESS>Date:   Mon Jun 3 18:07:22 2024 -0400
Makefile: Fix `check` target to reference the correct repo

This target checked the wrote git remote when looking for changes not
synced to this repo.

Signed-off-by: Russell Bryant<EMAIL_ADDRESS>
commit<PHONE_NUMBER>8f7255a2a0d86564a1cfc28758c9da
Author: Russell Bryant<EMAIL_ADDRESS>Date:   Mon Jun 3 18:08:38 2024 -0400
Sync from instructlab

Sync a change to the sdg code that merged into instructlab.

https://github.com/instructlab/instructlab/pull/1243

Closes #5

Signed-off-by: Russell Bryant<EMAIL_ADDRESS>

@russellb this ready for review?

@russellb this ready for review?

yes

@mergifyio rebase


[stable/nats] Add prometheus exporter

Signed-off-by: Javier J. Salmeron Garcia<EMAIL_ADDRESS>
What this PR does / why we need it:
This PR adds a Prometheus exporter to the Nats StatefulSet, essential for monitoring in production environments.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/ok-to-test
/lgtm


Error when fitting one-dimensional model

I am updating my post. The error below occurs when fitting a one-dimensional model in which one or more votes are dropped. Otherwise, it does not occur. Thanks!

Error in if (onedim.classification.errors[i, j] == 1) correct.class.binary[i,  :
missing value where TRUE/FALSE needed

Could you send us the data and your full code so we can have a closer look? Thanks!

You bet! Here is the error, and the attached files will replicate it.

ooc1 <- ooc(votes, dims=1, polarity=1148)

Preparing to run Optimal Classification...
Checking data...
... 1 of 1212 total members dropped.
Votes dropped:
... 1 of 117 total votes dropped.
Running Optimal Classification...
Generating Start Coordinates...
Running Edith Algorithm...
Permuting adjacent legislator pairs...
Permuting adjacent legislator triples...
Optimal Classification completed successfully.
Optimal Classification took 97.635 seconds to execute.
Error in if (onedim.classification.errors[i, j] == 1)
correct.class.binary[i,  :
missing value where TRUE/FALSE needed
On Thu, May 16, 2019 at 5:55 PM Tzu-Ping Liu<EMAIL_ADDRESS>wrote:

Could you send us the data and your full code so we can have a closer
look? Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tzuliu/ooc/issues/2?email_source=notifications&email_token=AADBIBL7PHV7JXZDLOSQVO3PVXJ3JA5CNFSM4HLEZK7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVTFHGY#issuecomment-493245339,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADBIBNXPSAFJRD6FCOY67LPVXJ3JANCNFSM4HLEZK7A
.

Sorry, I was not clear enough. Could you send us the data and the complete R script through my email if possible? So far I can tell which line goes wrong but I'm not sure exactly what causes this issue.

Hey sorry again! Turns out you did attach the data!

Through your codes, there are two issues I can identify. First, if you checked the demonstration code here, you should see that we removed all the NA's first, which you did not do. Second, the parameter polarity of  the function ooc is to assign one of the respondents as the "anchor" for estimation, and you set that parameter as 1148, which means you want the 1148th respondent as the anchor. However, if you checked your data, 1148 is not one of the indices of the rows. So you have to fix this first. Furthermore, once you remove all the rows with NA's and re-index the rows, you will find that there are totally only 595 respondents so you can only set polarity in between 1 to 595.
Below are the codes I fixed:
library(ooc)
load("votes.Rdta")
votes <- votes[complete.cases(votes), ]
rownames(votes) <- 1:nrow(votes)
ooc1 <- ooc(votes, dims=1, polarity=100)

Thanks -- the issue has to deal with how OOC handles lopsided responses to issue scale questions. In your dataset, the problem is with the scale in the 31st column:
> table(votes[,31])

  1   2   3   4
647 466  85   1

The response option 4 is lopsided. Right now, it's left to the user's discretion about whether to (a) drop the entire scale, (b) recode the lopsided response into a neighboring category, or (3) recode the lopsided response option as missing data.
We'll need to address this in a future release (either by deciding on one of the options and running it automatically in the wrapper or adding an argument that allows the user to choose). Until then this issue is best dealt with by processing the data before passing it to OOC.


drop the line to disable retries in HTTP.jl

https://github.com/RelationalAI/rai-sdk-julia/blob/935d4f1fe50e675ee462e290a0d3301a2d66d0a0/src/rest.jl#L88
https://github.com/RelationalAI/rai-sdk-julia/blob/935d4f1fe50e675ee462e290a0d3301a2d66d0a0/src/rest.jl#L130
See: #45

Closed by #48

Note: This issue has been migrated to https://relationalai.atlassian.net/browse/RAI-5949.
This link is only accessible to employees of RelationalAI.


chore: bdd-nh-1586284863 to 0.0.1

chore: Promote bdd-nh-1586284863 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Move Viper default setting to init()

Restore the functionality removed in https://github.com/istio/istio/pull/25633
The PR follows the example of tools/istio-iptables/pkg/cmd/root.go setting the defaults in an init() so it is guaranteed to occur exactly once during a run.

@esnible: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
5792383679f661b0c759b0aa61daac7480854a97
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@esnible: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
5792383679f661b0c759b0aa61daac7480854a97
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


PDF files: move all PDFs and set redirects

e.g. here https://main--bevespi--hlxsites.hlx.page/copd-management-resources

added pdfs
https://main--bevespi--hlxsites.hlx.page/docs/breatheinout-ebook.pdf
https://main--bevespi--hlxsites.hlx.page/docs/3311503-bevespi-consumer-how-to-use-tearsheet.pdf

https://main--bevespi--hlxsites.hlx.page/docs/bevespi-pi-central-digital-prescribing-information.pdf

https://main--bevespi--hlxsites.hlx.page/docs/bevespi-pi-central-digital-prescribing-information.pdf

Shouldn't this link stay external?

yes, I think it should, I've removed the usage of this pdf, but forgot to update the issue


feat(ts-typings): add TS type definitions

;) 🍺

I wonder if it's just worth writing in TypeScript :p. Not much code :)

well I and our team our work writes TS everywhere. Currently I have manually created those defs in blaze-elements https://github.com/wc-catalogue/blaze-elements/pull/130/files#diff-db0786508d94338729cb29f68ebd34cf
Anyway this project is very good guinea pig for you to try out TS ;) wdyt?

I'm keen to give it a go.

Merge this at your convenience. I've raised the TS rewrite in #9.

Oh I don't have rights to merge, cause we are not in Skate group :)
Can you merge this pls?
thx

Oh, haha. Sure.


CODE_OF_CONDUCT

Description

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md:
Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver,so make sure to pick the appropriate type. If in doubt feel free to ask :)

Hi @gaushikmr! I'll close this PR, as you made another one already. I'll review the other one tomorrow, just wanted to make sure we choose an appropriated CoC. Thanks so much for this! :)


Add visual indication when it's not possible to scale/rotate/move a 3d object

if an object has it's position/rotation/scale overridden, (1) it shouldn't be possible to adjust these attributes in the 3d editor and (2) there should be visual indication (grayed out handles?) that they shouldn't be adjusted

i think greyed out handles would work fine for this