Java py4j gateway server for trino queries still be open even after query finishes and in later makes queris Hang

Is there an existing issue for this?

[X] I have searched the existing issues

Description
The default connector for trino is jdbc as there is no sqlalchemy support as per my knowledge from sqlalchemy community.
When running hue with multiple clients, the jdbc class calls the py4j server, which still exist it does not close after we get the results, this leads to memory usage and hence the queries get slower as time passes and after certain time it still hangs . eg

hue      42923 27.1  1.2 2145458 191580 ?      Sl   07:28   0:10 java -classpath /usr/lib/hue/build/env/lib/python2.7/site-packages/py4j-0.9-py2.7.egg/py4j/../share/py4j/py4j0.9.jar:/usr/lib/trino/trino-j
hue      32133 17.3  1.2 2534676 321546 ?      Sl   07:30   0:10 java -classpath /usr/lib/hue/build/env/lib/python2.7/site-packages/py4j-0.9-py2.7.egg/py4j/../share/py4j/py4j0.9.jar:/usr/lib/trino/trino-j
hue      21692 17.2  1.2 6928376 216781 ?      Sl   07:32   0:10 java -classpath /usr/lib/hue/build/env/lib/python2.7/site-packages/py4j-0.9-py2.7.egg/py4j/../share/py4j/py4j0.9.jar:/usr/lib/trino/trino-j

For executing the trino query - code flow goes like this -

The code flow goes like this in short -

1. There is a api call (notebook/api/execute/{dialect}  -  here is dialect -> trino
2. This call goes through function - get_intepreter() , the interpreter returns a class - notebook.connectors.jdbc.JdbcApi  lass from the file -  /usr/lib/hue/desktop/libs/notebook/src/notebook/connectors/jdbc.py
3. This class will run execute , which calls other class from the file  - desktop/libs/librdbms/src/librdbms/jdbc.py
4. This class uses py4j as wrapper using jdbc connector to run the queries .

I have added various debugging points ,  to check where the bottleneck is
the bottle neck is this point -
def query_and_fetch(db, statement, n=None):
  data = None
  try:
    db.connect()
    curs = db.cursor()

    try:
      if curs.execute(statement):
        data = curs.fetchmany(n)
      meta = curs.description
      return data, meta
    finally:
      curs.close()
  except Exception as e:
    message = force_unicode(smart_str(e))
    if 'Access denied' in message:
      raise AuthenticationRequired()
    raise
  finally:
    db.close()

data = curs.fetchmany(n) this line is the bottleneck usually.
The issue should be solved if add the following lines in the close fxn of this file in jdbc class -
desktop/libs/librdbms/src/librdbms/jdbc.py
  def close(self):
    if self.conn is not None:
      self.conn.close()
      self.conn = None

#lines to be added
    try:
        self.gateway.shutdown()
    except Exception as e:
        LOG.error(e)

After adding these lines the child process of py4j gets killed. Verified by the ps auxxx and pstree command.
This can be a good first issue to solve to raise pr . Nowadays work on Hadoop so not that band width to raise here . Just trying to contribute to oss. This flow is also same for presto.
@Harshg999 @bjornalm
Regards
Vinay Devadiga
Steps To Reproduce
As stated in descritption use trino with hue , create multiple hue clients and fire huge trino queries . In some time, the py4j servers will take the memory , hence queries get hangs.
Logs
Attached above.
Hue version
Open Source 4.10

@divincode Thanks a lot for the detailed report and suggested solution. I've added the Good first issue but will also assign it to one of our core devs according to our new github issue process https://gethue.com/blog/hue-community-2023/

We also met this error, it will cause py4j jdbc connections leakage, and hue's memory grows up quickly

which engine are u using?

which engine are u using?

We are also using trino 433 jdbc with hue, you mention that we can use this code to fix this:
#lines to be added
    try:
        self.gateway.shutdown()
    except Exception as e:
        LOG.error(e)

Thanks a lot, we will try to modify the source code like this~

I think this wont work though  completely ..
Do try but i think we should use https://github.com/trinodb/trino-python-client ,
make the code changes to use this
def query_and_fetch(db, statement, n=None):
  data = None
  try:
    db.connect()
    curs = db.cursor()

    try:
      if curs.execute(statement):
        data = curs.fetchmany(n)
      meta = curs.description
      return data, meta
    finally:
      curs.close()
  except Exception as e:
    message = force_unicode(smart_str(e))
    if 'Access denied' in message:
      raise AuthenticationRequired()
    raise
  finally:
    db.close()

from trino.dbapi import connect

conn = connect(
    host="<host>",
    port=<port>,
    user="<username>",
    catalog="<catalog>",
    schema="<schema>",
)
cur = conn.cursor()
cur.execute("SELECT * FROM system.runtime.nodes")
rows = cur.fetchall()

use this this should remove py4j competely

If it works can u please contribute back to the community ? @hackeryang  @zhuzhengjun01

If it works can u please contribute back to the community ? @hackeryang @zhuzhengjun01

I tried use shutdown interface in the close function , but it does't work well, py4j gateway did not shutdown correctly

No i mean the trino python client, would solve the use case. Please try that.

No i mean the trino python client, would solve the use case. Please try that.

Oh understand, we extended hue jdbc_trino, but use trino java jdbc client, change to python client will be a big change, I will try again

The main thing is that the jdbc connector does not support set sessions, and some of our trino syntax depends on this

No i mean the trino python client, would solve the use case. Please try that.

I have tried using python client to connect to trino, the rss memory is fine, no more memory leaks, I will contribute this connector to the community if needed

Nice to hear ! do contribute it back or at least paste the diff , so that it can be used by others.
I added a new PR
https://github.com/cloudera/hue/pull/3831


Cannot save files

On Android 7, VimTouch 2.3 from f-droid, :w and :wq do not seem to have effect. The same files can be written by other apps, so it does not seem a permission issue.

Same problem, not sure what to do.

I've noticed that vim touch opens temporary files when used from an intent, rather than the actual file you expect.
The only way I've found around this so far is to:
:sav! /the/full/path/to/the/file
After that :w etc work ok
HTH


redisLibuvPoll crash when server closes the connetion

When server closes the connection, either by shutting down or some protocol irregularity, the libuv adapter crashes in redisLibuvPoll() when calling redisAsyncHandleWrite(). Reason for the crash is that the prior call to redisAsyncHandleRead() frees the context.
I have solved it by placing redisAsyncHandleWrite() before redisAsyncHandleRead(), however, considering that this happens because redisBufferRead(c) == REDIS_ERR causes the __redisAsyncDisconnect(ac) call, the better solution would be to make redisAsyncHandleRead() and redisAsyncHandleWrite() return status.

Hi, I'm going through old issues.
I think this may have been fixed in 9ce15c4b. Please reopen if that actually doesn't solve the problem and I will take the time to replicate the bug and submit a patch.


Fix scroll container min size calculation

The code responsible for accounting for the ScrollContainer scroll bars for it's minimum size calculation was broken, so that they would always be added, even if the scrollbar wasn't shown.
To test, create a scroll container and add a control with a minimum size (like a label with text). While vertical or horizontal scrollbars are on auto, try to resize the scroll container to be smaller than the contained control and observe minimum size not working properly on master

To test, create a scroll container and add a control with a minimum size (like a label with text).

It would be nicer if you have attach a small video to demonstrate this bug fix.

Horizontal scroll auto, vertical scroll disabled, pushed to vertical min size with resize gizmo.
Before:

After:

There is this annoying behavior with ScrollContainer where toggling scrollbar visibility will resize the content:
https://github.com/user-attachments/assets/6c94aeac-c261-418a-83d4-f8d4f70c6be6
Maybe the intended behavior was to actually use the extra margin for content.
Or at least it could be used like that.

I fail to understand what is happening here. Could you upload the scene?

It's a simple ScrollContainer with 2 controls:

When you toggle panel visibility, the ScrollBar will appear/disappear, changing content's width.
scroll_container.tscn.txt

I see. The alternative would be to always reserve space for the scrollbar, even when it's not visible, unless I'm missing a better way.
I don't really prefer it, I think that situations where the scrollbar is never visible will be way more that those in which the amount of elements changes just enough to show or hide it right when the user is looking at it.
Looked at some web app scrollbars (fb messenger right bar, reddit "recent posts" right bar) and they behave like that - if you resize chrome vertically the scrollbar will show and hide nudging the contents, but in practice the number of elements will almost always stay static while using the page

I run into this issue a lot in custom plugins or editors. It easily happens when the scrollable content is dynamic. You can even see it in the inspector:
https://github.com/user-attachments/assets/c720a0a9-7c9d-43a2-b459-0c2958e22a3e
Though I guess empty space reserved for scrollbar might look bad, so not sure what's the proper solution for that.

Maybe use always show for cases like this where it will change often, but change it's behavior when the contents are smaller.
Currently, always show will draw a huge scrollbar over the entire thing when the contents are smaller when the scrollbar. It would be better to instead draw the lower contrast background line only. This way the only thing that will change, when the contents become larger and smaller than the scroll container, is the scrollbar appearing and disappearing.

I was just reminded that a proposal exists:
https://github.com/godotengine/godot-proposals/issues/2121
I think it could be a new SCROLL_MODE. The problem is probably unrelated to this PR.

Thanks!


fix(branches): Not adding checks to existing branch protection contexts

All I can say is that the changed line implements what I assume is the intention of mutating the modifications parameter and fixes this particular case.

My bad,  my unit test was incorrect and the problem remains


itemCreatedAt field added in mlayer dataset related APIs

"itemCreatedAt" field added in Mlayer Dataset API (GET, POST) and mlayerPopularDataset API

Can one of the admins verify this patch?


risc-v/mpfs: Add error handling for PMP conf

Check return value of mpfs_board_pmp_setup() and
jump to mpfs_board_pmp_error() in case of error.
Summary
Impact
Testing

This is now also in upstream.


Could not compile in Xcode 6

Dear all,
I have compiled and intalled the libpointmatcher in my mac os machine successfully. However, I want to link to my current xcode projects and trying to compile the libpointmatcher project in xcode. I followed the instruction in advanced section but failed to compile the code in xcode. The errors are as follows:

May I know how to solve this issue?
Thank you very much.
Regards,
Jayden

My guess is that your problem is related to #66. As a temporary fix, you can copy libyaml-cpp-pm.a in your install folder. In you case, you should be able to find the library in:
./libpointmatcher/build/contrib/yaml-cpp-pm

and your install folder [1]:
/usr/local/lib

[1] confirm that libpointmacher.a is there, I'm not sure where make install will send it in your case.
This would be a temporary fix, while we arrange the whole yaml dependency problem.

Dear pomerlef,
Thank you very much. Now everything is working fine.
Cheers!
Regards,
Jayden


Futures even for non-Streamline functions?

Now that we have an explicit syntax for saying you want a future (!_), any reason Streamline couldn't support returning a future for any async function, not just Streamline ones?
Specifically, Streamline's implementation today returns futures from within Streamline function bodies... but now that the the compiler can see a !_ parameter, any reason it couldn't insert a call to create a future for Streamline function calls now?
That would be awesome — no more wrappers needed for parallelizing third-party calls.

@aseemk fixed by #282. That's one of the goodies.

Woot!

Fixed in 1.0.

Awesome @bjouhier. I'm excited to try this out, but haven't been able to yet.
Quick q in the meantime, if you don't mind: does this mean that non-Streamline functions that are called with a Streamline future will now get a function callback passed to them? (As opposed to false.)
Assuming so, awesome! Thanks.

Yes, that's how it works. The function will receive a callback :smiley:


Hide sparklines for episodes that have not received enough listens

Episodes with fewer than 20 listens per week for the last four weeks should not have a sparkline

This is mostly resolved.


Document how to integrate apps with libSQL with Wasm support

Due to the fact that our WebAssembly runtime is implemented in Rust, it's also not part of the customary sqlite3.c amalgamation file. Instead, users are expected to either:

integrate directly with our Rust bindings crate, if libSQL is integrated into a Rust project, or
statically link with a .libs/libwblibsql.a library, either compiled from source or precompiled, or
link dynamically by using the dynamic flavor of the library, or building from source with ./configure --enable-wasm-runtime

These steps might be obvious enough for libSQL maintainers, but aren't for users, so they need to be clearly documented and easily available.
Refs #116

Changing to rust toml to be:
crate-type = ["staticlib"]

Helped me link. Maybe separate the two rust configurations.

Not sure if SQLITE_OS_KV is hiding the wasm build on windows. Checking again.


[Addition]:

Hotspot b58 Addresses
11hsyViz32idrBHSrX4V5rdwwQJaZB4YnyV5vCkXVcfRTS8uYhj
Discord Handle
Rannsacker#0145
Reason(s)
It is very normal for this device to receive a signal from 2000 km.
Virtual Onyx Puma
example: https://explorer.helium.com/txns/Q6bDYFKXQzxoWooTh-ZVV08y-qZLhcg5vQFT_r_XnWg

Removal already requested in
https://github.com/helium/denylist/issues/2556
Please understand that requests are processed manually, and creating dozens of requests for the same hotspot may only delay the overall processing of those requests.


Standardization process

Sorry if this is the wrong place or the wrong way to ask, but are there any plans to submit this library or a version of it to be added to the C++ standard library? I know that there was a previous attempt to add something like this to the standard library (P1935) but that seemed to have stalled and stopped. How does this library compare to the previously proposed P1935 (https://github.com/mpusz/mp-units)?

This is a good place/way to ask; thanks for bringing it up!
I see you already got some info in mpusz/mp-units#471.  I can confirm that yes, I'm working with @mpusz and other leading units library authors to try to make a proposal for a standard C++ units library, targeting C++29.
As for Au, I never had any plans to propose it for standardization, and here's why.
One reason is that I couldn't figure out good interfaces.  Au gets a lot of usability/readability mileage out of having only one namespace, and having it be very short.  If we put it into the standard, that's at least std:: instead of au::... but it would probably be much worse, since many of our names (e.g., std::nano) are already taken.  I guess the best we could hope for is std::au::, but I doubt we'd get it, since au isn't very descriptive outside of the context of a library by that name that users explicitly included.  So I assumed we'd get stuck with std::units::, which makes for quite a mouthful.
// Today's syntax
auto speed = (au::kilo(au::meters) / au::hour)(100);

// Feared syntax
auto speed = (std::units::kilo(std::units::meters) / std::units::hour)(100);

Another reason is that due to our emphasis on accessibility --- and the associated constraint to preserve C++14 compatibility --- we can't take advantage of the wealth of new features enabled by the watershed C++20 release.  In particular, both concepts and non-type template parameters (NTTPs) unlock really exciting new possibilities, with big effects on the end user interface.  Any future standard C++ units library should take advantage of the features in the standard at the time that it's proposed.
I think that in some alternative universe, if au.hh were dropped into the C++ community's lap at the start of 2014, we could have added it to C++17, and it would have been a huge benefit: namely, having a widely available standard units library for an extra 12 years.  However, the way it actually turned out, these ideas simply took time to mature, and now we're in a place where it makes more sense to explore what we can do with more cutting edge interfaces like mp-units has.  The benefit of this delay is that the C++29 version of std::units, if it gets in, will have better interfaces than it otherwise would have.
The good news is that in making a standard units library, we basically get to cherry pick the best ideas from across the ecosystem.  So, ideas from Au --- such as magnitudes, and unit-safe interfaces --- have already made their way to mp-units, and are very likely to end up in any standard units library (unless we find something even better!).  And I have high hopes for other concepts: for example, I'd love to see a std::zero_t and std::zero object.
I'll close the issue just to keep our board clean, but thanks again for raising it!  We can keep discussing on mpusz/mp-units#471.


fix: set ANSIBLE_LOCAL_TEMP for ansible-runner

AAP-26860: unable to create local directories (/.ansible/tmp)

@bzwei the ansible-vault can also fail here https://github.com/ansible/eda-server/blob/24cd4b3e3c3ca19e83ddf3d6ef73a37a82ceea07/src/aap_eda/api/vault.py#L44
2024-06-27 16:09:57,986 - ansible_rulebook.engine - ERROR - Source error End Of File (EOF). Exception style platform.
<pexpect.pty_spawn.spawn object at 0x7f37ebc0fe20>
command: /app/.local/bin/ansible-vault
args: ['/app/.local/bin/ansible-vault', 'decrypt', '--vault-id', 'EDA_SERVER@/tmp/tmpz_ulnc4x']
buffer (last 100 chars): b''
before (last 100 chars): b"ible-local-63puar1zl3'. [Errno 13] Permission denied: '/app/.ansible/tmp/ansible-local-63puar1zl3'\r\n"
after: <class 'pexpect.exceptions.EOF'>

The above is from ansible-rulebook which does the decrypt using ansible-vault and on the eda-server side using the same executable we are doing the encryption

Turn to draft until we're allowed to merge it


Getting error message while running tests

getting error while running test_spdm_responder
[       OK ] test_spdm_responder_encap_get_certificate_case2
[ RUN      ] test_spdm_responder_encap_get_certificate_case3
Unable to open file ecp256/bundle_responder.certchain.der
0000: 5b 20 52 55 4e 20 20 20 20 20 20 5d 20 74 65 73 74 5f 73 70 64 6d 5f 72 65 73 70 6f 6e 64 65 72
0020: 5f 65 6e 63 61 70 5f 67 65 74 5f 63 65 72 74 69 66 69 63 61 74 65 5f 63 61 73 65 33 0a 00 73 29
0040: 2e 0a 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0
and while running test_crypt
Unable to open file ecp256/inter.cert.der

Looks the step of make copy_sample_key was missing. Would you try it and see if the issue is still there?
Note for Windows builds, try nmake copy_sample_key.
Good luck.


Video creating of app

similar to: https://www.youtube.com/watch?v=2hGSDD9-Tkc

https://www.youtube.com/watch?v=fPRqGjn_Fs4&t=65s


Feed accepts header

We have received some requests for /products that contain an ambiguous Accept: HTTP header of */*. This really confuses the controller action, so we default it to HTML if no format is provided.

ch9910

I assume you got that spec to run locally?

I assume you got that spec to run locally?

I did! Thanks for noticing that we don't have our own CI for this.

I assume you got that spec to run locally?

I did! Thanks for noticing that we don't have our own CI for this.

If we're going to continue to use this repo, it would probably be worth setting up.

I assume you got that spec to run locally?

I did! Thanks for noticing that we don't have our own CI for this.

If we're going to continue to use this repo, it would probably be worth setting up.

Since this is forked from an open source extension that's already set up to work with Travis CI, I think our best bet would be to open a private Travis account and use that. That way we don't have two sets of CI configs to deal with.

Approved upstream. I added this to travis but no badge has appeared yet.


function "project" expects an argument with Pynini 2.1.3

I recently moved to version 2.1.3. Now, project expects an argument. Did you change the API?
Traceback (most recent call last):
  File "/home/kmw/Documents/Work/timur/env/bin/timur", line 11, in <module>
    load_entry_point('timur', 'console_scripts', 'timur')()
  File "/home/kmw/Documents/Work/timur/env/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/kmw/Documents/Work/timur/env/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/kmw/Documents/Work/timur/env/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/kmw/Documents/Work/timur/env/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/kmw/Documents/Work/timur/env/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/kmw/Documents/Work/timur/timur/scripts/timur.py", line 76, in build
    timur = fsts.TimurFst()
  File "/home/kmw/Documents/Work/timur/timur/fsts/timur_fst.py", line 25, in __init__
    self.__syms = symbols.Symbols(pynini.SymbolTable.read_text(resource_filename(Requirement.parse("timur"), 'timur/data/syms.txt')))
  File "/home/kmw/Documents/Work/timur/timur/symbols/symbols.py", line 46, in __init__
    self.__characters = pynini.string_map(chars, input_token_type=alphabet, output_token_type=alphabet).project().optimize()
TypeError: project() takes exactly one argument (0 given)

(Code is here: https://github.com/wrznr/timur/blob/2fed6c980eda34a318aff088cac96f4d7ba19d05/timur/symbols/symbols.py#L46)
Documentation at http://www.openfst.org/twiki/bin/view/GRM/PyniniDocs says nothing about arguments...

Hi there, yes. Rather than treating one direction of projection as "default" and deriving the other with a non-default argument we follow the pattern used in other OpenGrm tools: one must specify "input" or "output" as an argument.
Information about the API is discoverable using the in-module help docs:
>>> help(pynini.project)

the type stubs (static type checking tools like mypy will tell you that it expects a mandatory "input" or "output" argument), or by reading the NEWS file updated with every release.
So you know API changes came fast in 2020 (the library gained many new internal users and we were in the process of developing a book that uses the library heavily) but far fewer are anticipated going forward.


Andkfork: tiny corrections and clarifications

Hi Max,
during first experiences with W:M:Chrome I could not resist to generate three little patches that should make live a bit more convenient for the next user.
I hope you like it.
Greetings from Perlin' for Berlin:)

Hello Andreas!
Thank you very much for trying out the module and fixing things!
I have applied your changes and also changed the upstream POD to recreate the markdown. After Amsterdam I'll push out a new release onto CPAN.
-max
Am 9. August 2017 09:29:46 MESZ schrieb andk<EMAIL_ADDRESS>
Hi Max,
during first experiences with W:M:Chrome I could not resist to generate
three little patches that should make live a bit more convenient for
the next user.
I hope you like it.
Greetings from Perlin' for Berlin:)
You can view, comment on, or merge this pull request online at:
https://github.com/Corion/WWW-Mechanize-Chrome/pull/3
-- Commit Summary --

s/README/README.txt/ and s/PhantomJS/Chrome/ in the examples
directory
Make mail address for bug reports a mailto link
Provide a bit of guidance for running the tests

-- File Changes --
M README.mkdn (19)
M examples/dump-links.pl (2)
M examples/gen_examples_pod.pl (32)
-- Patch Links --
https://github.com/Corion/WWW-Mechanize-Chrome/pull/3.patch
https://github.com/Corion/WWW-Mechanize-Chrome/pull/3.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/Corion/WWW-Mechanize-Chrome/pull/3

--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.


[Maintenance Windows] Create go module for MaintenanceWindowPolicy resolver

Description
In lifecycle-manager we create a new go module /pkg/maintwindow containing the logic for the window resolver as seen in internal.
Adding tests and notifying orchestration-operator team that the pkg can be used by them and shared.
Reasons
We want to offer the code for resolving MaintenanceWindowPolicy and ResolvedWindow to be shared.
Acceptance Criteria

[ ] New go.mod in /pkg/maintwindow containing resolver logic
[ ] Logic is unit tested
[ ] Ping orchestration-operator team (= SRE) that they can use and import the dependency to their project

Testing approach

Unit testing

Related issue

https://github.com/kyma-project/kyma/issues/18611

Notes
In Go projects, the pkg folder is typically used to store packages intended for use by other projects. If we place this resolver under pkg, it implies that other projects would depend directly on the lifecycle manager project, which is not our intention. Instead, we want this library to be a standalone Go module.
For reference, you can find numerous examples of how the pkg folder is used in other projects here:
https://github.com/golang-standards/project-layout/tree/master/pkg
Notably, there seems to be no concern regarding designing Go modules under pkg in these examples.
This also highlights another issue:

the existing pkg folder should be moved to internal since none of the current packages are designed for sharing purposes.

I propose we consider an alternative folder structure or use the api module instead. Personally, I prefer using the api module for sharing this resolver code, as it aligns well with its intended purpose.


sink(ticdc): remove useless op return value of AppendRowChangedEvent

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tiflow/issues/4423
What is changed and how it works?
remove useless op return value of AppendRowChangedEvent.

we do not need to return it when we append the msg to the buf.
the flushToProducer func never receive EncoderNeedSyncWrite op.

Check List
Tests

Unit test

Code changes

Has exported function/method change

Side effects
None
Related changes
None
Release note
None

Codecov Report

Merging #4630 (556bc20) into master (9607554) will increase coverage by 0.0058%.
The diff coverage is 56.0209%.

Flag
Coverage Δ

cdc
60.1927% <53.8194%> (+0.2705%)
:arrow_up:

dm
51.8298% <57.1303%> (-0.1990%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #4630        +/-   ##
================================================
+ Coverage   55.6402%   55.6460%   +0.0058%
================================================
  Files           494        506        +12
  Lines         61283      62973      +1690
================================================
+ Hits          34098      35042       +944
- Misses        23750      24435       +685
- Partials       3435       3496        +61

/run-kafka-integration-test

/run-kafka-integration-test

/run-all-tests /tidb=pr/32434

/merge

/run-kafka-integration-test /tidb=pr/32434
/run-integration-tests /tidb=pr/32434

/run-dm-compatibility-test
/run-dm-integration-test


Add pod security policies for prometheus components

What this PR does / why we need it:
This PR adds basic Pod Security Policies for the promethues components. This will allow this chart to be installed in an environment that has the PSP admission controller enabled.
Interestingly, there was a PSP included just for the node-exporter job. We just mimicked that PSP and added some for the other jobs.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

I just updated the Chart.yaml with correct version number again.


When exiting a screen with a ZxingScannerView and the torch is on, it stays on

If while on a Xamarin.Forms screen with a ZXingScannerView, if you turn on the torch/flash and then navigate away from the screen, the torch/flash doesn't turn off.  It does on Android.
I've tried to do ZXingScannerView.IsTorchOn = false during the OnDisappearing of the underlying form, but that doesn't do it.  I've tried to wrap it in Device.BeginInvokeOnMainThread, that didn't help.  It works fine if I push the Flash button again to turn it off, just not while exiting the screen...

Thanks for reporting this issue!  Unforunately it took me way too long to respond 😭.  Sorry, I apologize!  Recently the source code for this project was completely refactored to modernize it.  Many PR's were included in this effort, and many bugs were hopefully fixed.  Please try out the latest 3.x series of NuGet packages (currently in prerelease).  To try and make the project more maintainable in my spare time going forward, I've decided to close all existing issues to start with a clean slate.  If you're still experiencing this issue on the newest version, please open a new issue with as much detail as possible.  Thank you for your patience and understanding!  Happy scanning!


Fix mdcard

Shifted md-card styling over into app/ because it seems like you were using only as part of the example app and not the library itself. (Might be wrong)
The md-card styling was also disrupting other uses of md-card in other parts of my app.

Setting overflow: hidden on the card ensures the card will retain its border radius when elements flush to the edge of the card do not have a border radius. I could get fancy with pseudo selectors and do something like,
md-card > md-data-table:first-child,
md-card > md-data-table-toolbar:first-child {
  border-top-left-radius: 2px;
  border-top-right-radius: 2px;
}

md-card > md-data-table:last-child,
md-card > md-data-table-toolbar:last-child {
  border-bottom-left-radius: 2px;
  border-bottom-right-radius: 2px;
}

This might be a better solution than modifying the styles of md-card.

I removed overflow hidden form the card element, see 257b23c1b3ff0d4d0aca2ba4d0e91337f7014da2
I'm curious what was conflicting in your app. Were you trying to set overflow on cards to some other value?

Nice, thanks!
No, I was using md-cards (with dynamic content), and for some reason, having overflow:hidden truncated the height of all my md-cards, even chopping out my .md-actions div.


add TestRunInValidCPUShares

Signed-off-by: Yuan Sun<EMAIL_ADDRESS>

The test looks good to me.

I feel like there is already a test for this.

But I couldn't find one, some nits

@sunyuan3 can you please update the pr per the feedback and i think we can move this forward, thanks :)

Looks like we would not be able to merge this PR because of merge conflicts. Please rebase, fix conflicts, and force push to your branch.

Reopen it.

Sorry for delay. The codes have been updated.

LGTM

LGTM 🐶


Add Google Analytics to generated docs

Looking at https://staged_docs_host/documentation/test/0.12.32+2/
No analytics code there. It'd be great if we could track it!

Is there a different ID for it or the same as pub.dartlang.org?

If we're going to have a new domain, then yes – we should.
Or is everything going to be under pub.dartlang.org/documentation ?
On Tue, Mar 20, 2018 at 4:35 PM István Soós<EMAIL_ADDRESS>wrote:

Is there a different ID for it or the same as pub.dartlang.org?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/pub-dartlang-dart/issues/1131#issuecomment-374793350,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCipawPEPYvXX_gvsr609dYuQYMAtIks5tgZJHgaJpZM4Sy0E2
.

p.d.o/documentation will be only temp for testing until the domain is redirected, but we may have it under p.d.o eventually (TBD).

The current dartlang.org has a tracking id UA-51687523-1. Shall we use that for now because we have access to it, or a different one?

We should have a seperate ID for each domain – if at all possible.
Analytics is tough to parse if it crosses domains...
On Tue, Mar 20, 2018 at 4:49 PM István Soós<EMAIL_ADDRESS>wrote:

The current dartlang.org has a tracking id UA-51687523-1. Shall we use
that for now because we have access to it, or a different one?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/pub-dartlang-dart/issues/1131#issuecomment-374795810,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCij0r79Ji-NeLweEYf_cbYRKU9Brkks5tgZWIgaJpZM4Sy0E2
.

Who will create the new analytics tracking account? @jakobr-google @mit-mit @kevmoo ?

Actually, we changed the plan so we will put the documentation permanently on p.d.o/documentation, and then have dartdocs.org redirect to that. With that, I assume we need no new IDs?

Correct! Use existing pub site id
On Wed, Mar 21, 2018, 07:01 Michael Thomsen<EMAIL_ADDRESS>wrote:

Actually, we changed the plan so we will put the documentation permanently
on p.d.o/documentation, and then have dartdocs.org redirect to that. With
that, I assume we need no new IDs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/pub-dartlang-dart/issues/1131#issuecomment-374946766,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCiim03sBSgT7IW0HMYtjeOAV-fd-aks5tgl0tgaJpZM4Sy0E2
.


How to use myoArm models?

I use the latest version of myosuite.
I cannot find myoArm models in env_list from gym.envs.registry.keys().
Any idea about why there are no myoArm models or how can I use them?
Best,
Xiaoben

Hi @XiaobenLi00
Arm environments were used in the myochallenge 2023. You can find them with the name myoChallengeRelocateP1-v0 myoChallengeRelocateP2-v0.
In general, you can find the whole list of the environments with commands like:
from myosuite import myosuite_myochal_suite
print(myosuite_myochal_suite)

Hi @Vittorio-Caggiano
Thanks a lot for your answer!


charset: clean up some code about charset

What problem does this PR solve?

use a map to store the charset info directly
remove Desc struct, it is definitely same with Charset

Check List
Tests

Unit test

Code changes

Has exported function/method change

/merge

Do we also cleanup collation same way?

the collation is actually on the tidb side.😅

Do we also cleanup collation same way?

I think the whole file should be rewritten. 😅


Build Reports

Critical Changes
none
Changes
Created 6 reports to include in the core package.
Issues Closed

This work is already in the Master branch from another pull request, so closing this request as not needed

This work is already in the Master branch from another pull request, so closing this request as not needed


Make downloading of prisma client can resume from last break point

Problem
Downloading Prisma engines for Node-API for windows [========            ] 42%node:internal/process/promises:289
            triggerUncaughtException(err, true /* fromPromise */);
            ^

Error: read ECONNRESET
  code: 'ECONNRESET',
  syscall: 'read',
  attemptNumber: 1,
  retriesLeft: 2
}

With the break above, I restart the init command, and it downloads the engine from the very beginning! I think I can never finish it cause my bad internet condition.
Please add a break point resuming functionality!

Sorry, but that is not worth the effort on our side. The engine file is only a few megabytes, so downloading this is almost never a problem and almost none of our users are impacted by that. Trying to figure out how to make this download resumable would be major engineering effort.


Travis migration guide displays BUILD_REPOSITORYNAME instead of BUILD_REPOSITORY_NAME

The "Predefined variables" section of this guide
https://github.com/MicrosoftDocs/vsts-docs/blob/6f50897b7b87123d5b3d5bff9fcf667528b93fa2/docs/pipelines/migrate/from-travis.md#L40-50
should display BUILD_REPOSITORY_NAME instead of BUILD_REPOSITORYNAME

This has been fixed, thank you.


Fix/migration cleanup lost changes

This PR adds features and bug fixes which were removed by accident when merging our internal changes into the new develop branch.
Albin already approved this PR in our internal repo. @mattwalsh-unity since you made the commits which migrated those, could you confirm that these (especially the soft sync object part) weren't removed on purpose?

Confirmed these commits were not removed on purpose, but on looking at them seems like they could be organized a bit first

Confirmed these commits were not removed on purpose, but on looking at them seems like they could be organized a bit first


Update the game over message

Update the game over message so people know how to play again!

Looks good!!!

Step 5: Apply suggested changes


Feat/routinely updated field widget

ZH Card

I see what you mean about wanting to have the mutation in place before merging, but there's another card for linking the widget and the mutation, and that will include tests. So I think you've done everything your card requires.

Oh true, I didn't consider that card. so I think this card can go forward.


[BUG] Is RuntimeError: Unknown model

Can timm register my own model, I will always prompt RuntimeError: Unknown model after registering a new model

@lhl12395 you'll have to provide example code / notebook or I can't see what's going on, and versions as request in the issue templates

@rwightman Thank you for your reply. I have resoved this problem. I forgot to import my own model in the _init.py. Have good day!


Error while making request

When I run: $ borg list files I get the response:
Error while making request: Get http://borg.crufter.com:9992/v1/query?l=5&p=false&q=list: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0x6f276]

goroutine 1 [running]:
panic(0x30ba80, 0xc4200160b0)
	/usr/local/Cellar/go/1.7.3/libexec/src/runtime/panic.go:500 +0x1a1
github.com/crufter/borg/commands.Query(0x7fff5fbff79d, 0x4, 0x0, 0x0)
	/private/tmp/borg-20161029-46542-1hguymm/borg-0.0.2/src/github.com/crufter/borg/commands/query.go:29 +0x2d6
main.main()
	/private/tmp/borg-20161029-46542-1hguymm/borg-0.0.2/src/github.com/crufter/borg/main.go:29 +0x9e

Possibly this is due the port being blocked by the corporate firewall. Any idea how can I fix that?
In the other hand it should not fail. with SIGSEGV ;)

Hey, @pkuczynski, indeed, that SIGSEGV is not too pretty :D
Here is the thing: we had two hostnames pointing to the server, borg.crufter.com (in earlier versions) and ok-b.org.
Now since the server had an ephemeral IP address (because I'm lazy, terrible human being), when the server died and got a new IP address I forgot to update the borg.crufter.com one, hence your issue.
Should be fixed now if the gods of DNS propagation are merciful to us!

Taaaadaaaa! It works :) Thanks :)


highlight broken on end of script.

This Happens in all my .vue files.
Using the last version of sublime text.

Can you still reproduce that with the latest version of ST and the syntax? If so then you should post the code sample that reproduces since it would be impossible to do from the image.

@rchl I just started getting a similar issue where it doesn't seem to be parsing a template tag correctly. I could make a separate issue about it, I just saw this similar issue. The script and style tags work fine still, not sure what happened. I did update Node.js, don't know if that could be related. This started happening even before I update to the latest Sublime. Any thoughts? p.s. I've got a weird color scheme, but you can see the right > is white when usually the whole thing is grey.
<template>
  <div :foo="supposed.to.parse.js('sort of works')"></div>
</template>

It looks like this in the latest version of ST, syntax and Mariana theme:

The issue for you could be with your color scheme.

Right you are, that's a bummer though, been using that scheme for like 5 years now (
But, not on you, your code is flawless. Thanks for the help!

I can confirm this problem exists.
Environment:

Sublime Text 3 - build 4121
Vue Syntax Highlight v4.0.1
Color Scheme: Monokai

Screenshots:

its normal until you expand the <script> tag.

I've tested again with a clean ~/.config/sublime-text and only installed the Vue Syntax Highlight v4.0.1 package, now everything works fine. actually there is no problem at all, its just because of conflicting with other packages.


Upgrade to cabal-<IP_ADDRESS> rc5 on Windows for better caching.

This for better caching of cabal cache.
Also:

Introduce CACHE_VERSION to make it possible to invalidate cache.
Introduce dependencies.txt which will cause new cache to be generated when dependencies changed.
Upgrade to ghc-8.10.3 in Github Actions.

I'm unable to push branch to the repository, so I made a separate draft PR to show it builds:
https://github.com/newhoggy/cardano-crypto/pull/2

I'm unable to push branch to the repository, so I made a separate draft PR to show it builds:
https://github.com/newhoggy/cardano-crypto/pull/2

bors merge

bors merge

According to https://www.haskell.org/ghc/download.html ghc 8.10.3 is the current stable ghc release.

According to https://www.haskell.org/ghc/download.html ghc 8.10.3 is the current stable ghc release.


useReducer issue

https://github.com/WebReflection/lighterhtml/issues/40

Unfortunately I have no time to maintain this project, since I don't use it much myself.
I have hence updated the README with the current status:
https://github.com/WebReflection/dom-augmentor#dom-augmentor
Apologies for any inconvenience.


Use node parent when calculating offset

Hi,
I added some transforms to the examples as a quick way to see it's working. When calculating the tooltip position, the parent of the node should be taken as an offset, and not the target.
This is not a complete solution, because the node can be within multiple chain-of-parents with transforms (which have to be accumulated), but at least now if the target is inside a parent with transform the tooltip is in the right position.

I think we can't use node to replace the target here, because the logic doesn't make sense. And I can find another test case that makes this out of work... so I'm still thinking about it and trying to figure out a more clear logic.
Anyway, thanks for your PR and exploration, I'm closing this.

After spending almost one hour figuring out the logic behind this, the only thing I found is you are right, thanks 👍


should verification policies have an id

https://github.com/ockam-network/ockam/pull/770#discussion_r560388261

Looks rly outdated


Scala 2.12.12

https://github.com/scala/scala/releases/tag/v2.12.12

Codecov Report

Merging #731 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   81.20%   81.20%
=======================================
  Files          78       78
  Lines        5197     5197
  Branches      139      139
=======================================
  Hits         4220     4220
  Misses        977      977

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7354277...7311e95. Read the comment docs.


Fix/ipv6

Thanks for bringing this PR to a live branch of this project. I am happy to help with the test cases if needed or amend this change.

Hi,
I've been working on an improved for of the original project here with many improvements and the fix you provided. Test cases for it would be very welcomed

@thibaultCha will do, let me see if I can provide a fresh PR with above changes and test cases.

@thibaultCha perhaps you want to close this PR and use #2 as the main one, I've added test cases to this one.


Hygieia integration with chef. Possible?

Hi,
I would like to know if Hygieia with chef integration is possible. If it is please let me know.

I am aware that a team from another company has created this integration. Waiting on a PR from them.

Please let me know if you get it.

@parasbajaj https://github.com/RLIndia/Hygieia/tree/master/chef-collector


E-Tag Validation for DeleteEntity UpdateEntity (Merge) UpdateEntity (Replace)

The TableTransactionTypes "Delete", "UpdateMerge", and "UpdateReplace" support the ETag validation based on the Library Documentation: https://learn.microsoft.com/en-us/dotnet/api/azure.data.tables.tabletransactionactiontype?view=azure-dotnet
Would it be possible to add this functionality to the Cmdlets "Remove-AzDataTableEntity" and "Update-AzDataTableEntity"
I have many scenarios, where I need to Update or Delete an Entity only if it hasn't changed between the time of retrieval of the Entity (which also provides the Etag) and the Delete or Update Operation.
Let me know if more Context is needed, I'm happy to provide more Inputs.

That sounds like a useful feature for sure, I'll have a look.
I would consider this to be the new default behavior, with a -Force option to overwrite regardless. Would you agree this is an expected user experience?

Absolutely. This makes the most sense and it aligns with the rest API behaviour, where you have to pass the ifmatch header with * as value if you want the operation to execute unconditionally.

Hi, do you need some help with testing? I'd love to use your module in my next project. I do need the etag functionality for it though. Kind regards, Marc

I tested the functionality manually and released a new version of the module, let me know if something isn't working @Studermarc!

A bit late, but many Thanks for the development. I finally had the chance to put it to use in our project. it works nicely.

Happy to hear that 👍


Flink Doris Connector Release Note 1.2.0

Feature

Support Flink 1.15 read and write
Optimize log dependencies and delete log-related dependencies of pom files

Bugfix

Solve the exception when MaxRetries = 0

Thanks
Thanks to everyone who has contributed to this release:
@hf200012
@JNSimba
@link3280
@morningman
@yeyudefeng

is there any incompatible change should be mentioned?
eg. strip_outer_array

is there any incompatible change should be mentioned? eg. strip_outer_array

Replaced strip_outer_array with read_json_line write in 1.1.0


Add ability to get the root-router

What this PR does / why we need it:
This patch adds a way in event_emitter_router(label_name) to get the root event router. To use an empty string "" for the default router is just a proposal, maybe @DEFAULT would fit better.
Why I needed it:
I did not see another way to get an event it is once assigned to a label back the default route. The concat filter can send timedout events to a special label. With the route plugin the tag can be prefixed and with @label "" the event can be sent to the default filters and output.
Docs Changes:
Will be updated if there is any interest.
Release Note:

I'm not sure adding it and the label name are reasonable or not.
@repeatedly Do you have any opinions?

candidates of the label (Empty or @DEFAULT or @ROOT) name are reasonable or not.

We use ROOT in some places, so @ROOT is better than @DEFAULT and others.
https://github.com/fluent/fluentd/blob/da162e15bc95b1263f92eb0622c714f8b9d303b9/lib/fluent/config/v1_parser.rb#L44

@ferbar Could you replace with @ROOT and add unit test?
If you hard to add unit test, please let me know.
We'll add it.

@ashie I changed '' to '@ROOT', will test it tomorrow. I'm sorry I don't get it with the unit-tests. I found test/plugin_helper/test_event_emitter.rb, but I didn't find out how to do the
assert(event_emitter_router("@ROOT" == Engine.root_agent.event_router)
I will check what
<label @ROOT>
will do. That should probably be prevented...
Thanks!

I've added tests for event_emitter_router.
But ... I'm now doubting to use the label name @ROOT as a reserved word in this context.
I am sorry that I repeat the discussion...
Because it's too simple, users might be already using it in their configurations. It means it breaks backward compatibility.
Although the prefix @ is known as reserved word in Fluentd's configuration file, I think it's not applicable for label names because example configurations in the document uses @ prefix as label names.  Most users use @ prefix as label names  since the document exemplify it, it's not always necessary though.
When we add a new reserved word, we should ensure to select a word which is used rarely.
e.g.)

@ROOT_EVENT_ROUTER
@__ROOT__
...

How do you think about it? @cosmo0920 @kenhys @repeatedly

@__ROOT__

It may be better.
And another idea, how about  @__ROOT__@ or @ROOT@ (with prefix @ and suffix @ )

I think this is the right place to check if someone is using the root_event_router in a label tag:
https://github.com/fluent/fluentd/blob/master/lib/fluent/root_agent.rb#L133

BTW fluentd has a built-in label @ERROR.
To keep consistency of naming-convention, @ROOT might be better than names like @__ROOT__.

Added an error message for
<label @ROOT>
  <match debug.**>
    @type stdout
    @id stdout_output
  </match>
</label>

2021-07-29 15:08:16 +0200 [info]: parsing config file is succeeded path="fluent.conf"
2021-07-29 15:08:16 +0200 [error]: config error file="fluent.conf" error_class=Fluent::ConfigError error="Invalid label name (@ROOT)"

@ashie, @cosmo0920:
Should we add some documentation on these pages:
https://docs.fluentd.org/configuration/config-file#error-label
https://docs.fluentd.org/configuration/routing-examples
What about removing the @ in @SYSTEM @METRICS ?


integrate with fossa

@xinding33 I created another PR and tried to call fossa, and we got following error
FATAL Could not analyze: open thirdparty/rmm/python/requirements.txt: no such file or directory

it seems just the library rmm that we depend on don't have the equirements.txt, is there any way to exclude this directory so our build will not fail?


[Feature] Support subscriptions on PASE sessions

Feature description
In the spec, we says "A server may permit subscribe interactions even when there is no accessing fabric, subject to available resources (e.g. over PASE)"

For now, we reject all subscription over PASE, we should support it.

Platform
all
Platform Version(s)
N/A
Anything else?
No response

There are some issues in terms of how this should work (e.g. how a subscription report on the client side should be matched up with things, given that there are no authenticated operational node IDs involved).  Needs to be done pretty carefully.


Improve error message for wrong target names

What does this PR try to resolve?
Fixes https://github.com/rust-lang/cargo/issues/10982
We can print all available targets for users.
How should we test and review this PR?

[x] unit test

r? @epage
(rust-highfive has picked a reviewer for you, use r? to override)

I'll add a unit test later.

Thanks!
@bors r+

:pushpin: Commit 99b3564d0d984af37b96b1ade047d1a8f5ddca7c has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 99b3564d0d984af37b96b1ade047d1a8f5ddca7c with merge 6066463e27043a76de1302b3483ca443e44de68a...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 6066463e27043a76de1302b3483ca443e44de68a to master...


Adding RTEXT_FILTER* constants from linux/rtnetlink.h

Adding some constants needed for some specific netlink-route interactions (fetching information on a network interface). They are defined at linux/rtnetlink.h.

The RTEXT_FILTER_MST constant is available locally for me (Linux 6.0.12), but was not available on your CI and presumably is not available on the majority of active Linux systems yet (added to the kernel header ~9 months ago), so I removed it for this PR. I personally don't need it for my use case.

Thanks! @bors r+

:pushpin: Commit 691ac46199ed4821e77a76cd48f61f9f003ea595 has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 691ac46199ed4821e77a76cd48f61f9f003ea595 with merge c29d70af8693151759a24b695f13055e4c46335c...

:broken_heart: Test failed - checks-actions

The CI seems to fail since MUSL is still using modified headers based on Linux 4.19.* (https://github.com/sabotage-linux/kernel-headers), which are also missing RTEXT_FILTER_MRP (added 3 years ago), RTEXT_FILTER_CFM_CONFIG and RTEXT_FILTER_CFM_STATUS (added 2 years ago). Linux 4.19 is a longterm release with support until Dec, 2024.
I only need RTEXT_FILTER_VF and RTEXT_FILTER_SKIP_STATS at the moment, so I would be fine with only adding the first four constants (all added more than 7 years ago), but I guess it would be nice if there was a way to have them included for systems where they are available?
@JohnTitor What is your preference? Remove the "newer" constants and only add what's available for all LTR kernels? Or is there possibly a way to conditionally include this only for specific Linux versions?

Our musl image is too old because we haven't made a decision around the time64 breaking change.
Anyway, adding newer consts doesn't break the build for older musl users but the libc crate users have to care about it when using, so it should be totally fine to add them. Let's ignore them on the tests, you could tweak the below to do that:
https://github.com/rust-lang/libc/blob/72fba0ecc76bf385d8f7b687fa8e46a1f6c0ae43/libc-test/build.rs#L3385

@JohnTitor Sorry for taking so long. I added the exception as requested, here is hoping it goes through this time.

Sorry for the delay!
@bors r+

:pushpin: Commit 4b6f95e024f4ad9fcb1a5a875acdf48cc1cbf6e2 has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 4b6f95e024f4ad9fcb1a5a875acdf48cc1cbf6e2 with merge 11718c805f5951fb0aba0b0634eedbb3a7fb7f5e...

:broken_heart: Test failed - checks-actions

@JohnTitor I left in both exceptions/ifs now, hope that's fine.
I wonder if I can also re-try? @bors try

@jreppnow: :key: Insufficient privileges: not in try users

LGTM, thank you.
@bors r+

:pushpin: Commit 63ba3a046bac119995e2b5a21b6782398b92665a has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 63ba3a046bac119995e2b5a21b6782398b92665a with merge 3bb4f5276cc1faf9aa25570f8038450b8775676a...

:broken_heart: Test failed - checks-cirrus-freebsd-14

@bors retry

:hourglass: Testing commit 63ba3a046bac119995e2b5a21b6782398b92665a with merge 26c13fd57708475a83493387ca1a73a2b8ebdaa0...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 26c13fd57708475a83493387ca1a73a2b8ebdaa0 to master...


Discover - Feature Parity++

[WIP] Feature Parity++ is a release of Discover rewrite that allows for DevOps, backend, framework and library work to be discussesed, while positive impact is assessed. In parallel, when Feature Parity++ is undergoing Release Management, design efforts for net new Enhancements to Discover will ensue. This wil shorten the lifecycle and allow for more agile-like software dev and move away from colossal waterfall process, design bottlenecks and Pull Requests with too much going on. While this Pull Requests includes some Enhancements to the UI/UX, the focus is fixing everything underlying, while preserving the look, feel and functionality of current Discover, minus many of the bugs. There is a significant productivity gain by the rewrite from first principles, yielding a modernized, sustainable, more serviceable, easier to trace/debug, process for updating frameworks for security as well as incorporating new open source components and libraries for Enhanced UI/UX. This was a massive effort, spanning DevOps, performance engineering and over a decade of advancements and evolution in frontend software engineering, driven primarily by commercial products and teams. Developers, please start to learn the various aspects of the code and automation in the dev side and help me evangelize the benefits across global scope elimination, encapsulation, code grammar, linting, testability, modularity, object oriented coding, self-documenting naming, code comments, Django best practices, VueJS best practices, VueJS templates that consollidate scoped CSS, HTML template and JavaScript into comprehensive files, and much more. It's a large effort and will take many people to capture, realize and communicate the value of everything being delivered in this Pull Request and how it can be extended to all of HydroShare and other projects.

METRIC
VALUE

NEW VULNERABILITIES
8

NEW BUGS
29

NEW DUPLICATED LINES DENSITY
23.0683090705487

NEW SECURITY HOTSPOTS
0

NEW CODE SMELLS
32

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-3941

METRIC
VALUE

NEW CODE SMELLS
8

NEW VULNERABILITIES
0

NEW BUGS
22

NEW SECURITY HOTSPOTS
0

NEW DUPLICATED LINES DENSITY
27.7491408934708

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-3941

Note to team do not commit SOLR schema do develop/merge. See Alva based on Aug7 commit for tracing

METRIC
VALUE

NEW VULNERABILITIES
0

NEW CODE SMELLS
23

NEW DUPLICATED LINES DENSITY
29.250936329588

NEW BUGS
22

NEW SECURITY HOTSPOTS
0

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-3941

METRIC
VALUE

NEW BUGS
22

NEW CODE SMELLS
23

NEW VULNERABILITIES
0

NEW DUPLICATED LINES DENSITY
29.250936329588

NEW SECURITY HOTSPOTS
0

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-3941

METRIC
VALUE

NEW CODE SMELLS
17

NEW DUPLICATED LINES DENSITY
29.8890164561806

NEW VULNERABILITIES
0

NEW SECURITY HOTSPOTS
0

NEW BUGS
22

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-3941

METRIC
VALUE

NEW VULNERABILITIES
0

NEW BUGS
23

NEW CODE SMELLS
23

NEW SECURITY HOTSPOTS
0

NEW DUPLICATED LINES DENSITY
24.8771266540643

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-3941


[3pt] Form for add details: Member 5

When the user clicks the "Add item" link in the navigation panel they can see a form for adding a new item.

final screenshot


TreeSliver data disappears when scrolling

Steps to reproduce
in treesliver demo, add more testing data to let it fill the screen, and scrolling
Expected results
normal
Actual results
In the demo of the treesliver component, when the data fills the screen, the data disappears and reappears as you drag the scrollbar.
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

Thank you for the report. I can reproduce this issue using the first sample code on TreeSliver widget.

Demo
https://github.com/user-attachments/assets/f3a79ae9-d52b-428e-8cc4-26e9ef4a3632

Sample code
import 'package:flutter/material.dart';

/// Flutter code sample for [TreeSliver].

void main() => runApp(const TreeSliverExampleApp());

class TreeSliverExampleApp extends StatelessWidget {
  const TreeSliverExampleApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: TreeSliverExample(),
    );
  }
}

class TreeSliverExample extends StatefulWidget {
  const TreeSliverExample({super.key});

  @override
  State<TreeSliverExample> createState() => _TreeSliverExampleState();
}

class _TreeSliverExampleState extends State<TreeSliverExample> {
  TreeSliverNode<String>? _selectedNode;
  final TreeSliverController controller = TreeSliverController();
  final List<TreeSliverNode<String>> _tree = <TreeSliverNode<String>>[
    TreeSliverNode<String>('First'),
    TreeSliverNode<String>(
      'Second',
      children: <TreeSliverNode<String>>[
        TreeSliverNode<String>(
          'alpha',
          children: <TreeSliverNode<String>>[
            TreeSliverNode<String>('uno'),
            TreeSliverNode<String>('dos'),
            TreeSliverNode<String>('tres'),
          ],
        ),
        TreeSliverNode<String>('beta'),
        TreeSliverNode<String>('kappa'),
      ],
    ),
    TreeSliverNode<String>(
      'Third',
      expanded: true,
      children: <TreeSliverNode<String>>[
        TreeSliverNode<String>('gamma'),
        TreeSliverNode<String>('delta'),
        TreeSliverNode<String>('epsilon'),
      ],
    ),
    TreeSliverNode<String>('Fourth'),
  ];

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('TreeSliver Demo'),
      ),
      body: CustomScrollView(
        slivers: <Widget>[
          TreeSliver<String>(
            tree: _tree,
            controller: controller,
            treeNodeBuilder: (
              BuildContext context,
              TreeSliverNode<Object?> node,
              AnimationStyle animationStyle,
            ) {
              Widget child = GestureDetector(
                behavior: HitTestBehavior.translucent,
                onTap: () {
                  setState(() {
                    controller.toggleNode(node);
                    _selectedNode = node as TreeSliverNode<String>;
                  });
                },
                child: TreeSliver.defaultTreeNodeBuilder(
                  context,
                  node,
                  animationStyle,
                ),
              );
              if (_selectedNode == node as TreeSliverNode<String>) {
                child = ColoredBox(
                  color: Colors.purple[100]!,
                  child: child,
                );
              }
              return child;
            },
          ),
        ],
      ),
    );
  }
}

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.24.0, on macOS 14.6 23G80 darwin-x64, locale en-VN)
    • Flutter version 3.24.0 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 80c2e84975 (7 days ago), 2024-07-30 23:06:49 +0700
    • Engine revision b8800d88be
    • Dart version 3.5.0
    • DevTools version 2.37.2

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode15.4.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.91.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.94.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.6 23G80 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 127.0.6533.89

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.24.0-1.0.pre.525, on macOS 14.6 23G80 darwin-x64, locale en-VN)
    • Flutter version 3.24.0-1.0.pre.525 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 76107bdf50 (4 hours ago), 2024-08-08 16:50:40 -0700
    • Engine revision<PHONE_NUMBER>
    • Dart version 3.6.0 (build 3.6.0-130.0.dev)
    • DevTools version 2.38.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode15.4.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.92.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.94.0

[✓] Connected device (3 available)
    • Pixel 7 (mobile) • 2B171FDH20084L • android-arm64  • Android 14 (API 34)
    • macOS (desktop)  • macos          • darwin-x64     • macOS 14.6 23G80 darwin-x64
    • Chrome (web)     • chrome         • web-javascript • Google Chrome 127.0.6533.100

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

The bug can be reproduce in the official documentation:  https://api.flutter.dev/flutter/widgets/TreeSliver-class.html
https://github.com/user-attachments/assets/f6fa0a17-f824-4fa3-815a-0db632cd5fec


broken links in docs

https://monarch-initiative.github.io/pyphetools/
This section:
How to use pyphetools classes to convert tabular data (e.g., supplemental tables) to phenopackets
Information for developers
Both links don't resolve to a proper mkdocs page

thanks! Fixed with latest release


Make cargoPath configurable in settings

Can you please add a config option for the executable which is executed for cargo.
Something like it is already possible for the cargo runnables with setting rust-analyzer.runnables.overrideCargo.
But the autodetected tasks uses the fixed "cargo" from here
https://github.com/rust-analyzer/rust-analyzer/blob/a15d19619e097b14b670064a4edc054a4251f479/editors/code/src/toolchain.ts#L126
And it can't be overridden in the tasks.json, too.

we should have a setting here, workaround:
    "rust-analyzer.server.extraEnv": {
        "CARGO": "my-cargo.exe",
    },

Where do I put in that workaround?

Which editor are you using?

vscode insiders

In your settings.json which you can open using ctrl+shift+p > "Preferences: Open Settings (JSON)".

And then I just add it into that file?, anywhere in specific? just trying to put it at the end of the list gives me an error, I kinda suck with this type of stuff ngl

It has to be before the closing }.

yeah thought so,

so this should be fine?

Looks like there needs to be a , after the true. Other than that it looks good.

still getting this, rip

still getting this

One sec, might have figured something out

Alright so it now says it failed to fine my-cargo.exe, do I just copy paste my cargo.exe and rename it to my-cargo.exe?

You should replace my-cargo.exe in the settings.json file to the full path to cargo.exe.

ahhh ok, makes sense

Backslashes need to be doubled in json. So "C:\\Users\\logan\\.cargo\\bin\\cargo.exe", should work.

The more you know, alright.
now I'm getting the long error that I had before (I guess it already had found cargo... odd, especially since the error here says it couldn't be run)

I'm trying to use rust analyzer with Skyline/Smashline (a coding framework for smash that uses rust) giving it labels among other stuff, so my cargo.toml needs to have these dependencies

Where is the aarch64-skyline-switch target defined? It doesn't seem to be part of the official rustc builds.

just in the target folder

That is not the target itself. That are the build artifacts. Are you using a custom rustc version or are you using a target spec json file?

I just downloaded rust from the website, then did cargo install cargo-skyline, then got the dependencies from blujays github (The guy who made smashline) and let it build whatever it needed to build, never heard of target spec json files

https://github.com/skyline-dev/skyline skyline link
https://github.com/blu-dev/smashline smashline link

Looks like cargo-skyline does use a custom rustc: https://github.com/jam1garner/cargo-skyline/blob/8f3d8ec528173d066f6a69fce34a48dfda9a23d0/src/build.rs#L77 Do you have the C:\Users\logan\.rustup\toolchain\skyline\bin\cargo.exe file? If so can you point rust-analyzer to this file instead of C:\Users\logan\.cargo\bin\cargo.exe?

in that folder there's only a rustc.exe file, maybe that's why?
also I think we found another fix to it, just by deleting the .vscode and .cargo files in the workspace folder and making a new workspace seems to have gotten it to load

Thank you guys for all the help, you guys are amazing with what you do


Unit tests for SpriteButtonComponent

What could be improved
Currently the SpriteButtonComponent doesn't have any tests, it would be good to improve the test coverage here.
Why should this be improved
So that we don't accidentally break anything when doing changes.
More information
https://github.com/flame-engine/flame/blob/main/packages/flame/lib/src/components/input/sprite_button_component.dart
(This directory doesn't exist yet, but should be created with this issue)
https://github.com/flame-engine/flame/tree/main/packages/flame/test/input
Good to know
Make sure that you comment on the issue that you will be working on this before starting to program.
To set up the Flame environment you need to follow the instructions in our contributing.md doc, if you have any problems setting up your environment (or other issues of course) feel free to ask for help in the Flame channel on our Discord server.

Hi, Can take up this issue?

Hi, Can take up this issue?

Assigned you to the issue, make sure to join our Discord if you have any questions. :)

Hi, I know it's already assigned but still Can I take this issue ??

Hi, I know it's already assigned but still Can I take this issue ??

If @adityathakurxd is not planning to finish this you can take this, otherwise I can recommend this issue if you want to write up some unit tests.
I also see in your commit that you have added @mustCallSuper where we have missed them, you can upload that as a separate PR. Don't import material though, import package:meta/meta.dart instead.

@adityathakurxd : Hi, let me know if you are not planning to complete this issue. I have already implemented my code but I will create PR if you are not planning to complete as you have taken this first.

Hi @ShwetaChauhan18, sure please go ahead and make the pull request if you're already done with the code. I am still trying to understand how to write unit tests. It might take me some time to get hold of that and contribute here. Still somewhat new to writing tests.

Thanks @adityathakurxd
@spydon: Can you please assign this issue to me

Thanks @adityathakurxd
@spydon: Can you please assign this issue to me

Done!


fix(schema/absolutePaths): make absolute paths case insensitive

What kind of change does this PR introduce?

[x] Bugfix

Did you add tests for your changes?
No there seems to be no test case  in Validation.test.js
Summary

My motivation is to give people the opportunity to experience webpack on Windows aswell 😛 :D

#4530
Does this PR introduce a breaking change?
No
Other information
Closes #4530

Nice catch thank you

I probably reject this, because it was intended to only accept Uppercase drive letters. We had an issue which was cause by lowercase drive letters. C:\x.js is not the same module as c:\x.js.

@sokra Just fine close at will, thought it was urgent so I pick the solution from the issue and send PR, no needs on supporting this from my side 😛

I hope to merge as soon as possible.
Why not use /i instead of a-z ?

@zhe-he Why is /i  the better solution, I can update of course 😛

@michael-ciniawsky
I wrote a demo   http://jsbin.com/kumojomije/edit?html,js,console,output
Found that their performance is almost the same.
So, maybe... uh...   just a little word that can be reduced by a little bit of it.  /smile

Why not just use Node's path.isAbsolute? Another issue with the regexp check in Webpack is that it does not work with forward slashes, which are also valid in Windows.

I just updated webpack from 2.2.1 to 2.3.1 and it stopped working with the following error:
Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration.context: The provided value "c:\\data\\..." is not an absolute path!
 - configuration.output.path: The provided value "c:\\data\\..." is not an absolute path!

Patching webpack with this PR solved the issue, so I would really like to see this PR included.

Thanks


Create demo and refactor basic.rs

docs: add vhs tape
docs(example): make the example more robust

Add color_eyre for handling errors
Move init/restore terminal to functions
Move run function to App impl
impl Widget for App to render the app instead of ui function
Use updated Ratatui API functions for layout and rendering

docs(example): use enum instead of strings for actions
docs(readme): use enum in README and add demo gif

Added the png output on the website at: https://ratatui.rs/showcase/third-party-widgets/#tui-menu--


Bug fix 3.4/disallow subqueries in prune

Scope & Purpose
Disallow the usage of subqueries in AQL traversal PRUNE conditions, as they caused undefined behavior.

[ ] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[x] The behavior change can be verified via automatic tests

Testing & Verification
This PR adds tests that were used to verify all changes:

[x] Added new integration tests (i.e. in shell_server / shell_server_aql)

https://<IP_ADDRESS>/view/PR/job/arangodb-matrix-pr/6766/

https://<IP_ADDRESS>/job/arangodb-matrix-pr-windows/796/

Test blue.


Refer to IEC definitions for terms in the design_basis descriptions

In our meeting of 01 August 2023, we looked at the design_basis section in which we have a range of fields, such as inflow_angle ("gamma" in degrees).
For such values, there's an IEC standard defining the coordinate system, frame of reference and other aspects of these parameters. The descriptions of the fields should include a reference to this document.
Help required

get references to the (or all of the) IEC document(s) covering the parameters in the design basis section, and list them here so we can add those references into the schema (we probably only need the full document number)

@thclark I agree we should refer to IEC standard definitions - the editing tool can help with this.  (As an aside I made an error if I called inflow angle gamma.  Inflow angle / slope of the terrain is normally referred to as "theta" although theta is also used for direction and temperature -- so subscripts matter.  This is an editorial detail - we will get right once we send this out for review/before during internal clean up


Unable to resolve dependencies

After adding the package I can't build the project. Error:
A problem occurred configuring project ':app'.
> Could not resolve all dependencies for configuration ':app:_debugApk'.
   > A problem occurred configuring project ':react-native-google-fit'.
      > Could not resolve all dependencies for configuration ':react-native-google-fit:_debugPublishCopy'.
         > Could not find com.google.android.gms:play-services-auth:11.6.0.
           Searched in the following locations:
               file:/Users/wojciech/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-auth/11.6.0/play-services-auth-11.6.0.pom
               file:/Users/wojciech/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-auth/11.6.0/play-services-auth-11.6.0.jar
               file:/Users/wojciech/Documents/dev/uni/swifty-app/Swifty/android/sdk-manager/com/google/android/gms/play-services-auth/11.6.0/play-services-auth-11.6.0.jar
               file:/Users/wojciech/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-auth/11.6.0/play-services-auth-11.6.0.pom
               file:/Users/wojciech/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-auth/11.6.0/play-services-auth-11.6.0.jar
               file:/Users/wojciech/Documents/dev/uni/swifty-app/Swifty/android/sdk-manager/com/google/android/gms/play-services-auth/11.6.0/play-services-auth-11.6.0.jar
           Required by:
               Swifty:react-native-google-fit:unspecified
         > Could not find com.google.android.gms:play-services-fitness:11.6.0.
           Searched in the following locations:
               file:/Users/wojciech/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-fitness/11.6.0/play-services-fitness-11.6.0.pom
               file:/Users/wojciech/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-fitness/11.6.0/play-services-fitness-11.6.0.jar
               file:/Users/wojciech/Documents/dev/uni/swifty-app/Swifty/android/sdk-manager/com/google/android/gms/play-services-fitness/11.6.0/play-services-fitness-11.6.0.jar
               file:/Users/wojciech/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-fitness/11.6.0/play-services-fitness-11.6.0.pom
               file:/Users/wojciech/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-fitness/11.6.0/play-services-fitness-11.6.0.jar
               file:/Users/wojciech/Documents/dev/uni/swifty-app/Swifty/android/sdk-manager/com/google/android/gms/play-services-fitness/11.6.0/play-services-fitness-11.6.0.jar
           Required by:
               Swifty:react-native-google-fit:unspecified

I'd appreciate quick reply

Thank you for your response. I did have google repository set, however, I eventually abandoned the usage of your library, so I no longer need help. Feel free to close or remove this issue.
It was most likely something regarding the lack of setup of the stuff you listed in Readme file
   Android Support Repository
   Android Support Library
   Google Play services
   Google Play APK Expansion Library

Hi, i have a some problem:
><EMAIL_ADDRESS>android /Users/rsiqueira/Projetos/Asser/WalkaBit
> react-native run-android

Scanning folders for symlinks in /Users/rsiqueira/Projetos/Asser/WalkaBit/node_modules (26ms)
JS server already running.
Building and installing the app on the device (cd android && ./gradlew installDebug)...
File /Users/rsiqueira/.android/repositories.cfg could not be loaded.

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':app'.
> Could not resolve all dependencies for configuration ':app:_debugApk'.
   > A problem occurred configuring project ':react-native-google-fit'.
      > Could not resolve all dependencies for configuration ':react-native-google-fit:_debugPublishCopy'.
         > Could not find com.google.android.gms:play-services-auth:11.6.0.
           Searched in the following locations:
               file:/Users/rsiqueira/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-auth/11.6.0/play-services-auth-11.6.0.pom
               file:/Users/rsiqueira/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-auth/11.6.0/play-services-auth-11.6.0.jar
               file:/Users/rsiqueira/Projetos/Asser/WalkaBit/android/sdk-manager/com/google/android/gms/play-services-auth/11.6.0/play-services-auth-11.6.0.jar
               file:/Users/rsiqueira/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-auth/11.6.0/play-services-auth-11.6.0.pom
               file:/Users/rsiqueira/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-auth/11.6.0/play-services-auth-11.6.0.jar
               file:/Users/rsiqueira/Projetos/Asser/WalkaBit/android/sdk-manager/com/google/android/gms/play-services-auth/11.6.0/play-services-auth-11.6.0.jar
           Required by:
               WalkaBit:react-native-google-fit:unspecified
         > Could not find com.google.android.gms:play-services-fitness:11.6.0.
           Searched in the following locations:
               file:/Users/rsiqueira/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-fitness/11.6.0/play-services-fitness-11.6.0.pom
               file:/Users/rsiqueira/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-fitness/11.6.0/play-services-fitness-11.6.0.jar
               file:/Users/rsiqueira/Projetos/Asser/WalkaBit/android/sdk-manager/com/google/android/gms/play-services-fitness/11.6.0/play-services-fitness-11.6.0.jar
               file:/Users/rsiqueira/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-fitness/11.6.0/play-services-fitness-11.6.0.pom
               file:/Users/rsiqueira/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-fitness/11.6.0/play-services-fitness-11.6.0.jar
               file:/Users/rsiqueira/Projetos/Asser/WalkaBit/android/sdk-manager/com/google/android/gms/play-services-fitness/11.6.0/play-services-fitness-11.6.0.jar
           Required by:
               WalkaBit:react-native-google-fit:unspecified

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 23.068 secs
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/getting-started.html

Ok, i solve this issue following this steps:
add the maven url on the android/build.gradle


Websocket setup - Resolves #4 and Resolves #57

@trofej könntest du dir meinen pull request ansehen und mergen?


Support export interface Foo {}

Whilst un(der)-documented, interface is really useful, but it's unfortunate that I can't export an interface directly in the same way that I can export type T = string;, as export interface is a syntax error.
For now I can work around this limitation with
interface Foo {};
export type IFoo = Foo;

But it'd be much nicer to be able to do it directly:
export interface Foo {};

Fixed in #1145

awesome, thanks!


tests: timer_api: Use busy slew threshold when checking remaining ticks

On Nordic SoCs, the clock that drives the system timer and the one that is used in busy-waiting may be significantly skewed, so the test cases that compare durations derived from those two clocks need to take into
account a proper threshold. After the z_timeout_expires function was
corrected in 3d29c9fe546cd42554becee9dddcbe2e9e73d5cc, it turned out that the threshold was missing in one check and the related test case
started to fail on nRF platforms. This patch adds that threshold there.
Fixes #66075.
On the occasion, the threshold calculation is corrected to prevent 32-bit integer overflows.

@anangl  can you rebase please?

@anangl can you rebase please?

done


Would a "no-std" support be possible as a future feature?

I can think of a number of projects that execute in environments without a stdlib, but still require the ability to JIT or AOT compile wasm or something similar into native code.
Is this something that would be possible as a future feature?

The core cretonne code generator crate has minimal dependencies, and very likely could be made to work with just libcore and liballoc, which should be feasible in many limited environments.
My understanding is that full no_std excludes liballoc though, which would rule out featues like Vec, which would require extensive invasive changes, though I'd be happy to be corrected.

The environment that I'd be using does indeed have access to liballoc, so that's not a roadblock for me, but it may be for other projects. The largest obstruction that I've run into in adapting other crates to work without libstd is that liballoc does not have the HashMap type.
If I fork cretonne and submit a pull request with a no_std feature, will you consider merging it?

Ah, I wasn't aware that HashMap is not in liballoc. Cretonne codegen does use HashMap for some things. What are the options for converting code that uses it to no_std?
@stoklund may want to chime in here, but I'd be in favor of merging a no-std patch if it doesn't negatively impact Cretonne's other use cases, and doesn't make the code significantly harder to maintain.

There is a core_collections crate with supposedly exposes HashMap without stdlib. I was unable to get it to work through.
It wouldn't be overly difficult to write a type that proxies to HashMap when stdlib is available and has it's own, simplistic implementation otherwise.

It could make sense for us to support a more restricted environment. Some requirements are:

Cretonne currently builds on stable Rust, and it should stay that way.
Using Cretonne in a normal Rust environment should be unaffected.
Performance must be unaffected.

I am also concerned about how this affects maintenance of our current code and how it impedes development of new code.
It seems clear that we can't use a pure no_std environment, so how do we define the minimal environment that Cretonne needs? This environment needs to be usable by more than one external project.

I haven't done anything with features in Rust before, so I'm not sure how it would affect code quality. Since many projects do have a no_std feature or the equivalent, I'm guessing that it does not negatively affect maintainability or modularity of the code base.
I think the minimum environment for code generation without stdlib would have liballoc and a working global allocator implementation.
Execution of code would require memory protection attributes (e.g. mprotect or equivalent), if that's part of cretonne.

I look forward to seeing what it looks like! If you have any questions, please do ask (here, or file a new issue).
Cretonne is factored so that execution (and mprotect etc.) are not part of the core code generator crate, so embedded environments can provide their own code they need to get code executed.

If I have questions or need to discuss something that fits more with the style of a chatroom, should I ask it on the mozilla #cretonne irc room?

Yes, that works too.

Sweet. Thanks for you help. I'll close this issue and if need be, I'll open another.

Thanks for implementing this over in #204. That is very helpful.
Let me expand on the maintenance issues I mentioned above. @sunfishcode has already brought some of this up: It is one thing to get this feature working today, another to make sure that it keeps working as Cretonne evolves. To make sure that it stays working, we can (and should) document all the rules about which std modules can and can't be used etc, but no_std is still going to break almost instantly if the rules are not enforced automatically. Developers are only human, and they don't read documentation until something appears broken.
So the rules need to be enforced by the test-all.sh script which is used both by CI and developers to run all the unit tests. This script needs to be as fast as possible since it is part of the developer workflow. The script already compiles everything twice much to my chagrin (for unit tests and for file tests), so adding a third compilation of everything is not very appealing. I also think it would be problematic to require Cretonne developers to have a nightly Rust installed. (Personally, I don't have a nightly Rust installation because the daily 100+ MB downloads are excessive for something I don't need.)
It is extremely important that it is easy to get started working on Cretonne.
So the question is, how do we make sure that this feature doesn't get broken immediately without putting an unreasonable burden on Cretonne developers?

Regarding HashMap, Cretonne should probably have a pretty strict policy about using it outside testing code. The standard implementation has security features that prevents malicious data from causing a kind of DoS attack with deliberate hash collisions.

If Cretonne is depending on these security features anywhere, that should be documented loudly, and it would be a very bad idea to swap in an alternative implementation that doesn't have the same security features.
If Cretonne is not depending on the security features, we probably should not be using HashMap in the first place since the secure hash is very slow.

liballoc provides a BTreeMap, which could be used instead of HashMap

Would it be feasible to add a feature named something like "nonsecure_hashmaps", and then have no-std builds fail compilation with a helpful message if this feature isn't enabled?
In the future, we could use such a feature to also control whether we switch to fnv hashing in std-enabled builds (which I expect we'll want eventually).
That way, the high-level model is:

Cretonne's default is a std build that includes the std security measures
Users can enable features to opt out of some of these measures
Some features conflict with or require other features

Okay, so how about we create a Map type that has a set api for cretonne to use, then depending on features, we can have that type use HashMap, BTreeMap, or something else?

Can we keep the code itself using HashMap, but just change whether that ends up using std::collections::HashMap or hashmap_core::HashMap?

@sunfishcode Yep, that's definitely possible.


Lower Case after Hyphen in Explore Breadcrumbs

Hopefully a quick fix, but would be great to have capitalization after hyphen as elsewhere, e.g. "African-American" or "Afro-Asiatic" in attached screenshots

Strange! Should be an easy fix.


⚠ Bofrost.at has degraded performance

In 3743876, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 917 ms

Resolved: Bofrost.at performance has improved in 6fe7006 after 10 minutes.


Suggestion: distribute with --enable-tcb

Hi! Thanks for goAccess.
I installed following this instructions:
http://goaccess.io/download#debian
But unfortunatelly, this .deb package was compiled without --enable-tcb=btree, which is necessary to make incremental log analises, right?
So, why not distribute with this functionality enabled?
PS: I know it is possible compile by the source code, your instructions works very fine.
PS2: I tried by myself to make a .deb package, but is too hard to me, I have no expertise for that. (https://wiki.debian.org/IntroDebianPackaging)

@e-ruiz try this:
$ apt-get source goaccess
$ apt-get build-dep goaccess

You'll get a goaccess-0.6 directory (or similar). Open the debian/rules file using your favorite text editor and add the following (careful that dh_auto_configure is preceded by a tab, not spaces):

override_dh_auto_configure:
	dh_auto_configure -- --enable-tcb=btree

And finally:
$ cd goaccess-0.6
$ dpkg-buildpackage -rfakeroot -uc -us

This should give you a .deb package ready to install.

Just run into an issue, where my 8GB server is not big enough to run goaccess report for a month.
Believe btree on disk might help and having it shipped in the standard package would be awesome.

@LeeNX I plan to add this, but first I need to automate the process of adding them to the repo in the least amount of steps. Right now it takes some time to do it, especially for three archs, arm, i386 and amd64 .
BTW, removing the query string -q can greatly decrease memory consumption, especially on timestamped requests. You can also use -g to use less memory when querying GeoIP data.

@allinurl Thank you for your damed quick reply!!
Looking at around 150M requests to process for a month report, will test your above shortly and see how much info we might loose, else we will just have to rent a bigger VM for a report ... ;-)

v1.0 looking so awesome!! Thanks!!
Was really hoping v1.0 would ship with --enable-tcb=btree already compiled in. lazy_guy ;-)

Is there anything I, or anyone, can do to make this work?
Not so much from the lazy point of view, but more from the sysadmin view: having a dependency that is mainly used on larger projects compiled in really has an added value.

Alright, I was able to work on this and I got to the point where building goaccess with --enable-tcb=btree won't take too long. I plan to start distributing goaccess with on-disk support. I'll post the package details pretty soon.

Thanks! Looking forward to it.

Any ETA for this? Will be great for many sysadm ;)
Thanks...

@nutella I've working on the next release so I haven't had much chance, but I'll have this over the weekend.

It's finally here!!! Here are the details:
$ echo "deb http://deb.goaccess.io/ $(lsb_release -cs) main" | sudo tee -a /etc/apt/sources.list.d/goaccess.list
$ wget -O - https://deb.goaccess.io/gnugpg.key | sudo apt-key add -
$ sudo apt-get update
$ sudo apt-get install goaccess-tcb

Note: Since goaccess requires libtokyocabinet9, on-disk support is available from Trusty+ or Wheezy+.

Closing this.

@allinurl - Thanks, working very nicely, doing some crazy stuff again ... ;-)


Add new syscall instruction to the verifier

This is an alternative implementation of #614.
This PR adds the new syscall instruction to the verifier and write tests for it. It also introduces a dense function registry in the loader and distinguishes it from the sparse registry.
Execution tests for syscalls are only working for SBPFv1 and will be revamped once the instruction is properly implemented in the interpreter and jitter.

How about having get_dense_function_registry() and get_sparse_function_registry(), we instead have get_function_registry(sbpf_version)?