Which part of the code correspond to the graph alignment?

Hi, nice work and nice repo, but it seems that this repo does not contain the graph alignment part?

hello?

@thecharm

We add some necessary comments in the bert_encoder.py file. For structural alignment, we extract the alignment weights in advance and store them in our proposed dataset (rel1 directory), then it will be loaded in the data_loader.py. Thanks for your question, we will then upload the structural alignment codes.

We add some necessary comments in the bert_encoder.py file. For structural alignment, we extract the alignment weights in advance and store them in our proposed dataset (rel1 directory), then it will be loaded in the data_loader.py. Thanks for your question, we will then upload the structural alignment codes.

same questions, Could you please offer the code of graph generation and alignment feature output? which are exactly the core part of your paper, thanks a lot.

We add some necessary comments in the bert_encoder.py file. For structural alignment, we extract the alignment weights in advance and store them in our proposed dataset (rel1 directory), then it will be loaded in the data_loader.py. Thanks for your question, we will then upload the structural alignment codes.

And there are another 20 days past after your claim..

Sorry for the belated response, the code for structural alignment is provided in the directory "StructuralAlign", please feel free to try it and reply here if you met any problems.

Sorry for the belated response, the code for structural alignment is provided in the directory "StructuralAlign", please feel free to try it and reply here if you met any problems.

Thanks a lot! Could you please provide a little more instructions about how to generate scene graphs for images using the Scene-Graph-Benchmark.pytorch repository？For example, which modules did you use, and some general steps to use it？
Best wishes！

很抱歉迟到的回复，结构对齐代码在“StructuralAlign”目录中提供，如果您遇到任何问题，请随时尝试并在此处回复。

Thanks for the open source! This is a really great project! Can you provide the relevant algorithms for the generation of related scene graphs?

For Scene Graph Generation, please follow the guidelines of https://github.com/KaihuaTang/Scene-Graph-Benchmark.pytorch.

For Scene Graph Generation, please follow the guidelines of https://github.com/KaihuaTang/Scene-Graph-Benchmark.pytorch.

Hi, how do you get the object features?

For Scene Graph Generation, please follow the guidelines of https://github.com/KaihuaTang/Scene-Graph-Benchmark.pytorch.

Could you please provide a little more instructions about how to generate scene graphs for images using the Scene-Graph-Benchmark.pytorch repository？For example, which modules did you use, and some general steps to use it？

For Scene Graph Generation, please follow the guidelines of https://github.com/KaihuaTang/Scene-Graph-Benchmark.pytorch.

Scene-Graph-Benchmark.pytorch repository give us many options to choose, it's necessary for us to align our processing steps with yours, and I think it's necessary to give your whole processing steps in README, not only source code adapted from OpenNRE...

For Scene Graph Generation, please follow the guidelines of https://github.com/KaihuaTang/Scene-Graph-Benchmark.pytorch.

Hi, how do you get the object features?

The object features can be extracted with the faster-RCNN code provided in the Scene Graph Generation repository. FYI, This is the link https://1drv.ms/u/s!AmRLLNf6bzcir8xemVHbqPBrvjjtQg?e=hAhYCw.

For Scene Graph Generation, please follow the guidelines of https://github.com/KaihuaTang/Scene-Graph-Benchmark.pytorch.

Scene-Graph-Benchmark.pytorch repository give us many options to choose, it's necessary for us to align our processing steps with yours, and I think it's necessary to give your whole processing steps in README, not only source code adapted from OpenNRE...

We used the VCTree Setting and pre-trained the model on VG dataset by ourselves for a better SG performance. You can follow the guidelines and train your custom SG model.

For Scene Graph Generation, please follow the guidelines of https://github.com/KaihuaTang/Scene-Graph-Benchmark.pytorch.

Hi, how do you get the object features?

The object features can be extracted with the faster-RCNN code provided in the Scene Graph Generation repository. FYI, This is the link https://1drv.ms/u/s!AmRLLNf6bzcir8xemVHbqPBrvjjtQg?e=hAhYCw.

Hi, changmeng, I have read the repo of Scene graph Generation, but it seems that the repo can not output the object features by default, can you tell me how to modify the source code?

For the most important diagram alignment module in the paper, it would be nice if you could provide an example from the beginning of the picture and sentence to the generated aligned data.

How does the triplet from the original image correspond to your Graph(config.py) class?

Hope to give a complete example of how to from the beginning of the picture and sentence to the generated aligned data, Thanks!

How does the triplet from the original image correspond to your Graph(config.py) class?

Hi, I am another author of this article.  For your question, we first generate the node connection information files of the scene graph and dependency tree through the xnetmf.py file. Please see the main function and the folder 'combined_ graph_ edges_10' for details. We then use the files from the above folder to generate Graph objects for each sample of the dataset.  Please see the regal.py file for details.


$$ content $$  in table make error.

Describe the bug
Some text between double $ mark makes error
TypeError: Cannot read properties of null (reading 'match')     at isCustomHTMLInlineNode
To Reproduce
when using this MD
test

|a|b|c|d|
|--|--|--|--|
|a  | $$bb^b$$ | cc |dd|

Expected behavior
In the function " isCustomHTMLInlineNode " var html = node.literal; returns null and html.match in next line maybe make the error.
Additional context
When I add the code below, error not occur.
var html = node.literal;
if(!html){
    return false;
}
var matched = html.match(reHTMLTag);

Thank you for the issue. we'll check it later.

I have to say that I also encountered this error.
Is there any new progress and solution?

@jwlee1108  have any update?


Update Docs, License and SLUG

A few things changed since the last time I used your template. My first project was a mess because I deleted the development project on pypi without knowing this would remove the name I've choosen into the void.
lately I started a new project with the template again and I realized a few things. The most important one: The default access rule for the runner has changed which doesn't allow pages branch creation. I've added a section into the doc markdown to inform a user about it.
I am not sure about the change of the pylint settings. It seems that msg-template="{msg_id}:{line:3d},{column}: {obj}: {msg}" works perfect without include-ids, but why was include-ids ever there? In pylint 1.0.0 msg-template was introduced, which "killed" --include-ids option.
Fixed also some slug issues where your username instead of the cookiecutter users was used.

Just one more info, it seems that version bumping also has some issues, but this needs more investigations

the pylint configuration was mostly copy and paste from old projects so there could have definitely been some old holdovers in there like the --include-ids

closed in favor of #29


Server info

Added the ServerInfo to the list of parameters on the connect and reconnect callbacks. ServerInfo allows the clients to check for max message size, etc as provided by the server.
Updated tests to new avajs requirements
Regenerated docs

Pull Request Test Coverage Report for Build 40

25 of 29 (86.21%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 90.298%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/protocolhandler.ts
24
28
85.71%

Totals

Change from base Build 35:
-0.3%

Covered Lines:
995

Relevant Lines:
1053

💛  - Coveralls


Error when trying to configure a cmake build for static linking

Git commit reference
a1a32d227a49d92e637d3311468cc53508e6e446 (v10.0.32)
Describe the bug
I'm attempting to build my bot with dpp statically linked. This is the FetchContent config for dpp that I'm using:
include(FetchContent)

# Fetch and build DPP.
set(BUILD_SHARED_LIBS OFF)
set(DPP_CORO ON)

FetchContent_Declare(
    dpp
    GIT_REPOSITORY https://github.com/brainboxdotcc/DPP.git
    GIT_TAG v10.0.32
)

FetchContent_MakeAvailable(dpp)

target_link_libraries(
    ${PROJECT_NAME}
    PRIVATE
    dpp
)

And here's the output of running the configure command for the build:
$ cmake -B build -D CMAKE_BUILD_TYPE=Debug
-- The C compiler identification is GNU 13.2.0
-- The CXX compiler identification is GNU 13.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- INFO: Using VCPKG if detected
-- Looking for prctl
-- Looking for prctl - found
-- Looking for pthread_setname_np
-- Looking for pthread_setname_np - found
-- Performing Test HAVE_SINGLE_PARAMETER_SETNAME_NP
-- Performing Test HAVE_SINGLE_PARAMETER_SETNAME_NP - Failed
-- Performing Test HAVE_TWO_PARAMETER_SETNAME_NP
-- Performing Test HAVE_TWO_PARAMETER_SETNAME_NP - Success
-- Performing Test AVX1
-- Performing Test AVX1 - Success
-- Performing Test AVX2
-- Performing Test AVX2 - Success
-- Performing Test AVX512
-- Performing Test AVX512 - Failed
-- Performing Test AVX1024
-- Performing Test AVX1024 - Failed
-- Detected x86_64 AVX type: AVX2 (FLAGS: -mavx2)
-- Checking for ability to update autogenerated files
-- Autogeneration is not available
-- Building static library.
-- Found Opus: /usr/include
-- Found Opus /usr/lib/x86_64-linux-gnu/libopus.a;/usr/lib/x86_64-linux-gnu/libm.a
-- Detected libopus. VOICE support will be enabled
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.a (found version "1.3")
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.a (found version "3.0.13")
-- Building git version. Be aware git versions may be unstable!
-- CXX Namespace: ../include/dpp/mlspp/mls
-- CMake Export Namespace: MLSPP
-- OpenSSL Found: 3.0.13
-- OpenSSL Include: /usr/include
-- OpenSSL Libraries: /usr/lib/x86_64-linux-gnu/libssl.a;/usr/lib/x86_64-linux-gnu/libcrypto.a;dl
-- Enabled coroutine feature
-- Configuring test: coro_loop with source: ../src/coro_loop/*.cpp
-- Configuring test: davetest with source: ../src/davetest/*.cpp
-- Configuring test: soaktest with source: ../src/soaktest/*.cpp
-- Configuring test: unittest with source: ../src/unittest/*.cpp
Library install directory at /usr/local/lib
Include files install directory at /usr/local/include
-- Looking for C++ include filesystem
-- Looking for C++ include filesystem - found
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED - Success
-- Using bundled nlohmann::json
-- Configuring done (12.0s)
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "mlspp" that is not in any export set.
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "mls_vectors" that is not in any export set.
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "bytes" that is not in any export set.
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "tls_syntax" that is not in any export set.
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "hpke" that is not in any export set.
-- Generating done (0.1s)
CMake Generate step failed.  Build files cannot be regenerated correctly.

To Reproduce
Steps to reproduce the behavior:

Run cmake -B build -D CMAKE_BUILD_TYPE=Debug with the above cmake config to pull in dpp.

Expected behavior
Cmake configures the build without errors.
Screenshots
N/A
System Details:

OS: Ubuntu 24.04
Discord Client used for testing: N/A

Additional context
The above config works fine for a shared lib build.

wheres the rest of the cmake output? i dont see any error?

@braindigitalis the entire output is all there. The errors are at the bottom:
-- Configuring done (12.0s)
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "mlspp" that is not in any export set.
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "mls_vectors" that is not in any export set.
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "bytes" that is not in any export set.
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "tls_syntax" that is not in any export set.
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "hpke" that is not in any export set.
-- Generating done (0.1s)
CMake Generate step failed.  Build files cannot be regenerated correctly.

do you have vcpkg installed on your system?
DPP is trying to enable building using vcpkg which is not working on 10.0.32 which is why it isnt released there yet.
Add the following build rule to your cmake and try again: -DDPP_NO_VCPKG=ON
let me know if this fixes it!

@braindigitalis unfortunately the same errors still occur:
$ cmake -B build -D CMAKE_BUILD_TYPE=Debug -DDPP_NO_VCPKG=ON
-- The C compiler identification is GNU 13.2.0
-- The CXX compiler identification is GNU 13.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- INFO: Explicitly disabling VCPKG as running inside the CI action.
-- Looking for prctl
-- Looking for prctl - found
-- Looking for pthread_setname_np
-- Looking for pthread_setname_np - found
-- Performing Test HAVE_SINGLE_PARAMETER_SETNAME_NP
-- Performing Test HAVE_SINGLE_PARAMETER_SETNAME_NP - Failed
-- Performing Test HAVE_TWO_PARAMETER_SETNAME_NP
-- Performing Test HAVE_TWO_PARAMETER_SETNAME_NP - Success
-- Performing Test AVX1
-- Performing Test AVX1 - Success
-- Performing Test AVX2
-- Performing Test AVX2 - Success
-- Performing Test AVX512
-- Performing Test AVX512 - Failed
-- Performing Test AVX1024
-- Performing Test AVX1024 - Failed
-- Detected x86_64 AVX type: AVX2 (FLAGS: -mavx2)
-- Checking for ability to update autogenerated files
-- Autogeneration is not available
-- Building static library.
-- Found Opus: /usr/include
-- Found Opus /usr/lib/x86_64-linux-gnu/libopus.a;/usr/lib/x86_64-linux-gnu/libm.a
-- Detected libopus. VOICE support will be enabled
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.a (found version "1.3")
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.a (found version "3.0.13")
-- Building git version. Be aware git versions may be unstable!
-- CXX Namespace: ../include/dpp/mlspp/mls
-- CMake Export Namespace: MLSPP
-- OpenSSL Found: 3.0.13
-- OpenSSL Include: /usr/include
-- OpenSSL Libraries: /usr/lib/x86_64-linux-gnu/libssl.a;/usr/lib/x86_64-linux-gnu/libcrypto.a;dl
-- Enabled coroutine feature
-- Configuring test: coro_loop with source: ../src/coro_loop/*.cpp
-- Configuring test: davetest with source: ../src/davetest/*.cpp
-- Configuring test: soaktest with source: ../src/soaktest/*.cpp
-- Configuring test: unittest with source: ../src/unittest/*.cpp
Library install directory at /usr/local/lib
Include files install directory at /usr/local/include
-- Looking for C++ include filesystem
-- Looking for C++ include filesystem - found
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED - Success
-- Using bundled nlohmann::json
-- Configuring done (27.2s)
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "mlspp" that is not in any export set.
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "mls_vectors" that is not in any export set.
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "bytes" that is not in any export set.
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "tls_syntax" that is not in any export set.
CMake Error: install(EXPORT "dpp" ...) includes target "dpp" which requires target "hpke" that is not in any export set.
-- Generating done (0.1s)
CMake Generate step failed.  Build files cannot be regenerated correctly.

I don't think I have vcpkg on here (certainly never used it).

i think the problem is with static linking in general. I am not sure of the fix right now, but we'll come up with something. Until then are you able to use dynamic linking as a workaround?

Yes dynamic linking works fine, appreciate you looking into it!

I think this stackoverflow post may be relevant, but I haven't looked deeply enough at the dpp cmake config to confirm it: https://stackoverflow.com/questions/40183810/why-does-cmake-export-require-static-libraries-used-to-build-a-shared-library

There is a PR #1290 which should fix this once it makes its way to master.

Closing as #1290 has been merged.


Added 5 new columns: Services (names in CSV), Service Count, Thread Tokens, Privs & Groups counts

I've added 5 new columns:

Services (names in CSV),
"#" Svcs (Count of Services in a svchost),
"#" Groups (Group count),
"#" Privs (Privilege count),
"#" Thread Tokens (impersonating -- confirmed by seeing Impersonation column in a Process' thread list)

Feel free to change the name as needed, but I've been sitting on this change for 3 years now with no performance impacts that I have observed.

@AltF5 should we close this PR out for you to create a new one limited to the service info? Or will you be updating this one?

@AltF5 should we close this PR out for you to create a new one limited to the service info? Or will you be updating this one?

Let’s close it and I’ll start over :-)


/nodes/NODENAME endpoint has HEAD operation.

New operation for nodes.  Need to figure out what this means and if it is useful.

Fixed by # 199


Confirm Transceiver creation rules

Right now we create Transceivers implicitly when answering. I need to investigate if this is the right behavior.
If a user calls AddTrack after SetRemoteDescription but before CreateAnswer they might be confused.

Everything is correct!
At the time when I created this I didn't know answering creation was implicit.


Update README.rst

Coverage decreased (-0.3%) to 96.094% when pulling 050fe0bc6bf72fe7ec47378f15bb44fba9c7a129 on A888R:patch-1 into 7cdecf9bfe5ef0c960b782493c8e5cad6b5fa552 on nibrag:master.

Thanks!


Use transaction.atomic in do_create_user and do_change_user_role.

First commit is for do_create_user.
Second commit is for do_change_user_role.

I think most process_new_human_user would ideally be inside the transaction, but agree it'd be a challenging mini project to do so, and this is valuable even without that.  Merged, thanks @sahil839!
@mateuszmandera FYI just so you know we've integrated these bits.


[INTG-1762] iauditor-exporter Allow specifying inspection ID or name when saving PDF/Word files

added filename flag for the inspection report command

I've updated the documentation to reflect this change, too. Thanks @HarryTranAU!


Removing an extra channel in server RPC logs.

Instead of using a channel logger plus a go routine to
get the data out, use a callback logger, and write data
to the stream directly. Simpler all around.
@enisoc @michael-berlin

This change is

(by the way, ChannelLogger can be removed soon, it is used internally in one place, I'll fix that first, then remove it entirely.)

Changes Unknown when pulling 147c090ddcc3b117a6c2d61ac92f72ae8af21548 on alainjobart:serverrpclog into ** on youtube:master**.

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

go/vt/tabletmanager/grpctmserver/server.go, line 452 [r1] (raw file):
This comment isn't needed anymore since logging is now synchronous.

go/vt/vtctl/grpcvtctlserver/server.go, line 42 [r1] (raw file):
This comment isn't needed anymore since logging is now synchronous.

go/vt/worker/grpcvtworkerserver/server.go, line 42 [r1] (raw file):
This comment isn't needed anymore since logging is now synchronous.

Comments from the review on Reviewable.io

LGTM after Anthony's comments are adressed.

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 3 unresolved discussions.

go/vt/tabletmanager/grpctmserver/server.go, line 452 [r1] (raw file):
Done.

go/vt/vtctl/grpcvtctlserver/server.go, line 42 [r1] (raw file):
Done.

go/vt/worker/grpcvtworkerserver/server.go, line 42 [r1] (raw file):
Done.

Comments from the review on Reviewable.io

Coverage decreased (-0.08%) to 60.399% when pulling 0cbe54da969678858d50b9072830e35aa2ff5382 on alainjobart:serverrpclog into cd6313365eb6088d9c35a9fba33ab82585bc8634 on youtube:master.


feat: update vehicle info

Description
update vehicle.info.param.yaml to lexus 450h model.
ref:
https://lexus.jp/models/rx/spec_price/specification/rx450h/ (Japanese)
https://www.carsguide.com.au/lexus/rx/car-dimensions/2022
Related Link
https://github.com/tier4/lexus_description.iv/pull/35
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[x] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

LGTM


e2e: enable triggering hw jobs on PRs

Added event type 'pull_request' to the list of events
that trigger e2e-* workflows.
NOTE: this PR can be accepted only after setting "Require approval for all outside collaborators" option in the project configuration.

Codecov Report

Merging #856 (544d891) into main (9fbba6d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #856   +/-   ##
=======================================
  Coverage   54.38%   54.38%
=======================================
  Files          39       39
  Lines        3604     3604
=======================================
  Hits         1960     1960
  Misses       1531     1531
  Partials      113      113

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fbba6d...544d891. Read the comment docs.


Minor copy changes

Minor changes to some collection names - looks like this:

/cc @artsy/grow-devs

Ugh, opened from a fork. 🍴


Automatic error report

<!---   *** BEFORE SUBMITTING: PASTE CLIPBOARD HERE TO COMPLETE YOUR REPORT ***   ---!>

Closing because this is empty. This probably means that you're using a very old version of Spyder (three years old or more).
So please update to a more recent version, which you can download from here:
https://github.com/spyder-ide/spyder/releases


Swift 3

Hey, I'd love to contribute to Presentr and port it to Swift 3, but first you guys have to create a swift3 branch on the repo so I can start pushing stuff.
What are your thoughts? 😃

Good idea :) ! I'll create a Swift3 branch off of the Develop branch. You can send pull requests to that branch.


Is there a way to stop the gem requiring the app directory? (I'm using a Rails engine)

I'm using wicked as part of my own engine. That engine is used in a Rails app with a component architecture instead of a top-level app directory (here's an example). That means I don't have a top-level ApplicationController.
The app works in development, but when I deploy, I get the following stack trace:
../gems/wicked-1.0.3/app/controllers/wicked/wizard_controller.rb:5:in `<top (required)>': uninitialized constant ApplicationController (NameError)

Is there a way I can stop the gem requiring the app directory in production?

You need an ApplicationController for wicked to work

Yeah, I've had one for ages and removed it recently hoping to get rid of it. I guess if I really wanted to fix this, I'd have to fork your gem. Thanks anyway :smile:

Looks like the only thing that needs application controller is Wicked::WizardController which is an older way to make a wicked controller (inheritance instead of including a module). You could probably change that to be auto loaded instead of directly required. That way someone using Wicked::WizardController would need ApplicationController but otherwise it would not attempt to be loaded. If that works, can you give me a PR?

Yes, that's the real issue. I'll have to look into how to use auto loading, I've never used it in a gem before. Do you mean just let Rails find it or do I need to use autoload? I'd send you a PR, sure! Thanks :)

Hi @schneems, I've forked the gem, but I can't seem to find exactly where the wicked/wizard_controller is required in the gem, it doesn't seem to be in the engine.rb?

From what I've learned about engines, I think the contents of app automatically gets required when an app requires an engine. Is that how the Wicked::WizardController is made available to users?

I think this is a convention thing. By putting it in app/controllers it's available to the user just like if you had  added it to your app/controllers. Try moving that file into lib/wicked and adding something like this to lib/wicked/wicked.rb
module Wicked
  autoload :WizardController, "wicked/wizard_controller"
end

Thanks @schneems! I've raised #186 :sparkling_heart:


Edge case lab overlay

merciless-2023-08-22.txt

Edge case of lab overlay borking due to the fact that room 3 and 5 in current merc lab were called Estate Path.

1st image is raw file from poelab, 2nd is screenshot taken in Aspirant's lab room №8.
How to replicate: Boot a labyrinth into a state where entrance to trial will be the same name as the room after one.

Textfile attached was initially poelab compass file of .json format. Github doesn't allow .json files, i renamed to .txt

Thanks for reporting and including this much information. This layout exposes quite a few oversights, and I'll have to do some re-thinking. I'll probably also add some form of manual override in order to simply jump to the next room in case the script gets stuck.


Parser error when the body of a class is updated

See https://github.com/softwareventures/precise-commits/tree/updated-class-body for a failing test case

No longer reproducible as of 69e5939e.
Actually not reproducible in the linked branch, either. The test does fail but it fails because the test fixture is already formatted, not because of a parser error.
The test case does match my recollection of a situation that caused this problem in the wild, but it doesn't seem to be reproducible so closing this bug for now.

I sadly have exactly this issue
SyntaxError: Unexpected keyword or identifier. (1:1)
> 1 | get canSubmit() {
    | ^

@Clemens-E Yes, it does still seem to be possible to trigger this bug in certain circumstances. Prettier have fixed the specific cases I found upstream, but I do occasionally still hear about this happening.
Please check you are using the latest versions of @softwareventures/precise-commits and prettier.
If you still get this bug, if possible please send me the code that triggers it. I will need:

The contents of the file you're trying to commit.
The existing contents of the same file in your git repository.

You can paste these into a new issue on GitHub or, if you don't want the code to be made public, send them to me privately at<EMAIL_ADDRESS>If you're running precise-commits on git commit using husky or similar, then you might not be able to commit some changes because of this issue. If so you can skip commit checks one time by running git commit --no-verify instead of git commit.


feat: Utilize expected notes from ExecutedTransaction

Now that ExecutedTransaction contains all output note details, we can use that for checking that the notes that we expected were all correctly generated by the transaction, and after that tracking them accordingly.
This PR also contains a small refactor related to the NoteScreener's use of the Store. It removes the lifetime in favor of Rc.

@bobbinth don't mind the integration tests failing too much (I think there could be a bug related to tags on miden-base, still investigating), but just want to see if these are about what you had in mind


Adds the 'aad app role add' command. Closes #2145

Adds the 'aad app role add' command. Closes #2145

Merged manually


Maybe typo? (CON-417)

Code: esp_matter_attribute_utils.h
Line: 39
/* Nullable base for nullable attribute */
#define ESP_MATTER_VAL_NULLANLE_BASE 0x80

I think correct naming is ESP_MATTER_VAL_NULLABLE_BASE.

@YOGYUI That's right. It is a typo. Thanks for notifying. We will fix it.


visual indication of neighbour feeds on the slope diagram

Purpose is to help identify which incoming / outgoint systems are aggregators / distributors

Add a separate tab to indicate what you are doing to the data type (consume, generate, adjust, publish).

belatedly closing


Might Be a Bug, Might Just Need to Clarify the Setup For Bing

sample_agents_bing_grounding.py:
**Azure SDK **:
Linux Ubuntu:
3.8.10:

Describe the bug
When I run the example code it gripes about not having a Bing Search API key.
python3 raw_python.py
/subscriptions/16f866b6-7cb3-494f-b738-7ad0d449b655/resourceGroups/DefaultResourceGroup-EUS/providers/Microsoft.MachineLearningServices/workspaces/username-test1/connections/hubforbinggrou7517785039
Created agent, ID: asst_xxxxxxxxxxxxxxxx
Created thread, ID: thread_yyyyyyyyyyyyyyyyy
Created message, ID: msg_zzzzzzzzzzzzzzzzz
Run finished with status: failed
Run failed: {'code': 'missing_required_parameter', 'message': 'Bing Search API key is missing for Bing Grounding tool.'}
Deleted agent
Messages: {'object': 'list', 'data': [{'id': 'msg_zzzzzzzzzzzzzzzzzzzzzzz', 'object': 'thread.message', 'created_at':<PHONE_NUMBER>, 'assistant_id': None, 'thread_id': 'thread_yyyyyyyyyyyyyyyyyyyyyyy', 'run_id': None, 'role': 'user', 'content': [{'type': 'text', 'text': {'value': "How does wikipedia explain Euler's Identity?", 'annotations': []}}], 'attachments': [], 'metadata': {}}], 'first_id': 'msg_zzzzzzzzzzzzzzzzzzzzzz', 'last_id': 'msg_zzzzzzzzzzzzzzzzz', 'has_more': False}

A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

python3 sample_agents_bing_grounding.py

pip3 freeze raw_python.py
azure-ai-projects==1.0.0b4
azure-core==1.32.0
azure-identity==1.19.0
azureml==0.2.7
certifi==2024.12.14
cffi==1.17.1
charset-normalizer==3.4.1
cryptography==44.0.0
idna==3.10
isodate==0.7.2
msal==1.31.1
msal-extensions==1.2.0
numpy==1.24.4
pandas==2.0.3
portalocker==2.10.1
pycparser==2.22
PyJWT==2.9.0
python-dateutil==2.9.0.post0
pytz==2024.2
requests==2.32.3
six==1.17.0
typing_extensions==4.12.2
tzdata==2024.2
urllib3==2.2.3

Expected behavior
I expected to see some sort of GenAI summary of the Wikipedia article on Euler's identity.
Screenshots
N/A
Additional context
Very simple problem from my perspective. I suspect there is either a missing parameter that gets picked up in the developer environment, or that some (unmentioned in the Python code) switch needs to be set on the Azure/Cloud side when creating the Bing Service.
Glad for a little help on the bleeding edge. Couldn't find anything just searching  about.
Thanks

Thanks for the report. Did you setup BING_CONNECTION_NAME env variable on the sample?
Please see this document.
https://learn.microsoft.com/en-us/azure/ai-services/agents/how-to/tools/bing-grounding?tabs=python&pivots=overview

Yeah, sorry: It hit me last night I hadn't mentioned my environment variables, which are as below, though slightly redacted with ellipsis:
export BING_CONNECTION_NAME='hubforbing. . . . '
export MODEL_DEPLOYMENT_NAME='gpt-4o'
export PROJECT_CONNECTION_STRING="eastus.api.azureml.ms;. . . "

Thanks for the quick come-back.


Design system architecture

Design the system architecture for the ZK rollups layer 2 solution for Cardano. This should include some recommendations about how to architect dapps built on the layer 2 solution. The deliverable is an architecture document which includes diagrams presenting different views of the architecture: specifically, at least, a system diagram (showing the components and their connections) and process diagrams (showing the steps that occur in the normal cases of system operation and key exceptional cases).

Done.

@morganthomas is the "Orbis System Architecture" document an artifact that was created by this issue? When you said: "document which includes diagrams presenting different views of the architecture: specifically, at least, a system diagram (...) and process diagrams (...)" did you mean by that the diagrams that are present in the "Orbis System Architecture"?


Board Review: Attestation - Java

Thank you for submitting this review request. Thorough review of your client library ensures that your APIs are consistent with the guidelines and the consumers of your client library have a consistently good experience when using Azure.
The Architecture Board reviews Track 2 libraries only. If your library does not meet this requirement, please reach out to Architecture Board before creating the issue.
Please reference our review process guidelines to understand what is being asked for in the issue template.
To ensure consistency, all Tier-1 languages (C#, TypeScript, Java, Python) will generally be reviewed together.  In expansive libraries, we will pair dynamic languages (Python, TypeScript) together, and strongly typed languages (C#, Java) together in separate meetings.
For Tier-2 languages (C, C++, Go, Android, iOS), the review will be on an as-needed basis.
Contacts and Timeline

Responsible service team: Azure Attestation Service
Main contacts: LarryO, AnilBa
Expected code complete date: 1/10/2022
Expected release date: 2/1/2022

About the Service

Link to documentation introducing/describing the service:https://azure.microsoft.com/en-us/services/azure-attestation/
Link to the service REST APIs: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/attestation/data-plane/Microsoft.Attestation/stable/2020-10-01/attestation.json
Link to GitHub issue for previous review sessions, if applicable: https://github.com/Azure/azure-sdk/issues/2889 https://github.com/Azure/azure-sdk/issues/2652 https://github.com/Azure/azure-sdk/issues/1985

About the client library

Name of the client library: Azure Attestation
Languages for this review: Java

Artifacts required (per language)
Please read through “API Review” section here to understand how these artifacts are generated. It is critical that these artifacts are present and are in the right format. If not, the language architects cannot review them with the SDK Team’s API review tool.
Java

APIView Link: https://apiview.dev/Assemblies/Review/7649463a50d54f249be5ad0ee0580b05
Link to Champion Scenarios/Quickstart samples: https://github.com/Azure/azure-sdk-for-java/tree/main/sdk/attestation/azure-security-attestation/src/samples/java/com/azure/security/attestation

For all other languages, send a request to the Architecture Board to discuss the best format on individual basis.
Thank you!

scheduled for 1/20 2-4pm pst

Recording[MS INTERNAL ONLY]


BUG, when using q's defer.reject from the remote module

Leave these codes in a browser window:
var q = require('remote').require('q');
q().then(function () {
	var defer = q.defer();
	setTimeout(function () {
		defer.reject(new Error('Test throw error'));
	}, 100);
	return defer.promise;
})
.catch(function (e) { console.dir(e); });

and we will catch this Error object (see it in DevTool):

but what we want should be like this:

so i tried to dig in, put a breakpoint at this line defer.reject(new Error('Test throw error'));, found electron is using a wrap for remote calls, and it will run to below:

as Error object, the for-in statement can not get its property.
May solve this ? tks

The remote modules do not work well with Promise types, it is not designed for general PRC purpose anyway. The only solution is to use the ES6 Promise class, which is supported by remote.

tks!


compiler: update x/tools package

Close #2086 .
So there are some things to discuss:

New tools use go to handle versions and packages. This slows our compiler tests, especially the skipped one with different boolean conditions. Most likely we should refactor that test to be more precise and contain less cases.
What are the expectations of compiler writers regarding workflow? We can either extend documentation and write about go mod tidy/download or hide all such things in the compiler itself.
neo-go dependency in contracts produces undesired indirect dependencies in go.mod. This can be fixed with declaring pkg/interop as a separate module with its own go.mod.

This slows our compiler tests, especially the skipped one with different boolean conditions

That's unacceptable, we need these tests. Have you tried overlays?

What are the expectations of compiler writers regarding workflow? We can either extend documentation and write about go mod tidy/download or hide all such things in the compiler itself.

I don't think it's possible to write anything meaningful without modules now, so we better specify that proper modules configuration is needed.

neo-go dependency in contracts produces undesired indirect dependencies in go.mod

I wouldn't worry much about it. The behavior of Go itself has changed several times already wrt indirect dependencies and I doubt anyone cares.

BTW, if it takes a lot of time to load test packages maybe we need to profile it and see what's the problem? I wouldn't expect a change in x/tools to incur that big of a performance penalty, maybe we're doing something wrong.

@roman-khimov I have mentioned in the OP: it invokes go version internally which is at least one syscall per test. Overlays are already in use. I will look at what else we can do. One of the solutions is to generate a single big file with a lot of methods, each for testing a single boolean expression.
cpu.out.gz

One of the solutions is to generate a single big file with a lot of methods, each for testing a single boolean expression.

This doesn't seem bad, we'll compile once and run methods one by one then, I think it should work.

Before:
ok      github.com/nspcc-dev/neo-go/pkg/compiler        47.738s coverage: 93.1% of statements

After:
ok      github.com/nspcc-dev/neo-go/pkg/compiler        42.681s coverage: 92.8% of statements

So at least testing time is not a problem now.

Shouldn't our examples also have go.mod?


Providing nightly builds

Hi,
Thanks for the awesome library!
It would be great if acme can provide nightly builds (similar to tf-nightly and tfp-nightly) which would allow the users to pin the versions of acme to
exact versions
Alternatively, it would be good if there is a way to differentiate the versions when installing from the master branch. Currently, in setup.py the version specified on the master branch is 0.2.0, this may confuse the users as they cannot distinguish the version installed.
I am happy to create a PR if the acme authors have some ideas of how to do this in practice.
Thanks!

Hi @ethanluoyc, thanks for your offer. We'll look into providing a nightly version but unfortunately it's something that we have to do internally.


fix simultaneous duplicate server certificate generation

can still happen sequentially but should not cause exceptions.
see #816.

i've done my best to test this code and it seems to work

I just added some explanatory comments on why we create certificates without a guaranteed concurrency in below commit.
https://github.com/justcoding121/titanium-web-proxy/commit/2470c0a13316e096369319d0ee1bd98ef2ef7c0b
It should also resolve the SaveCertificate issue. Closing this. But thank you for your contributions.

locking in SaveCertificate suffers from the problem of allowing simultaneous duplicate certificate creation.   multiple threads can be generating redundant server certificates (5 seconds of CPU time on my machine).
your locking pattern also requires 2 locks- the ConcurrentDictionary.TryAdd and the lock() statement.
please reconsider my patch.  i does not have the issue you raised.

I apologize if this was closed prematurely.

Let's discuss below piece of code in your PR.
Task<X509Certificate2?> createCertificateTask;
await pendingCertificateCreationTaskLock.WaitAsync();
try {
	// handle burst requests with same certificate name
	// by checking for existing task for same certificate name
	if (pendingCertificateCreationTasks.TryGetValue(certificateName, out createCertificateTask))
	{
		return await createCertificateTask;
	}

	// run certificate creation task & add it to pending tasks
	createCertificateTask = Task.Run(() =>
	{
		var result = CreateCertificate(certificateName, false);
		if (result != null)
		{
			cachedCertificates.TryAdd(certificateName, new CachedCertificate(result));
		}

		return result;
	});
	pendingCertificateCreationTasks[certificateName] = createCertificateTask;
} finally {
	pendingCertificateCreationTaskLock.Release();
}

// create certificate outside of lock to allow other threads a chance to see the pending task.
// precludes the possiblility of multiple threads simultaneously generating the same certificate,
// we tolerate the case of a duplicate sequential generation due to a race (should be rare)
// t1: await createCertificateTask
// t2: cachedCertificates.TryGetValue->false
// t1: pendingCertificateCreationTasks.Remove
// t2: pendingCertificateCreationTasks.TryGetValue->false
var certificate = await createCertificateTask;

// cleanup pending task
await pendingCertificateCreationTaskLock.WaitAsync();
try {
	pendingCertificateCreationTasks.Remove(certificateName);
} finally {
	pendingCertificateCreationTaskLock.Release();
}

pendingCertificateCreationTaskLock is a global lock. I am worried about the statement return await createCertificateTask.
Let's imaging there are 5 hosts requesting new certificates, with each have a second request in burst (total 10 request together).
Let's assume each certificate creation takes 500 ms.
1st host gets the global lock at 0 ms
1st host' burst request waits at return await createCertificateTask for 500 ms.
1st host and its burst returns at 500 ms, meanwhile other 8 requests are waiting
2nd host gets the global lock at 500 ms
2nd host' burst request waits at return await createCertificateTask for 500 ms.
2nd host and its burst returns at 1000 ms, meanwhile other 6 requests are waiting
3rd host gets the global lock at 1000 ms
3rd host' burst request waits at return await createCertificateTask for 500 ms.
3rd host and its burst returns at 1500 ms, meanwhile other 4 requests are waiting
...
I could be wrong. You see the problem here. The global lock becomes a bottleneck and makes the process non-parellel.
I see your point about CPU usuage spike with duplicate certificate generation with my approach. But it won't have the bottleneck I mentioned above.

Also, the save certificate to disk is not part of request handling. I offloaded it to a separate task in my latest change. We can prevent the additional write to disk and save CPU resource by just checking if the file already exists inside the DiskCache implementation, just before write operation.

you're right, that is a mistake. i imagined that was happening outside the lock. gimme a minute to push a new patch candidate.

Also, the save certificate to disk is not part of request handling. I offloaded it to a separate task in my latest change. We can prevent the additional write to disk and save CPU resource by just checking if the file already exists inside the DiskCache implementation, just before write operation.

That's probably a good idea.  Just make sure you've got try/catch and the file writing is atomic since there will still be a race.

bah... screwed up rushing... gimme another sec to re-push

please review, i think the patch is good now.

I still see a rare possibility for multiple tasks still creating same certificates as described in following example.

Request A for abc.com acquires lock and awaits for generation to finish
Request B for host bcd.com acquires lock and awaits for generation to finish. Many others requests are doing the same and awaiting for unrelated hosts.
Another request C for abc.com waits to acquire lock
Request A for abc.com releases lock and removes the task from task creation dictionary
Request C for abc.com acquires lock and awaits for generation to finish
Request C for abc.com releases lock and removes the task from task creation dictionary
Request B for bcd.com releases lock and removes the task from task creation dictionary. Many others requests are doing the same for unrelated hosts.

In this example Request A and C are for same host abc.com. But the certificates are created twice. But I think it won't happen very often in practice.
Checking the cache one more time inside the 1st critical section should fix this issue.

I just added that check, one more lock acquire inside TryGetValue for cache dictionary. But I think it should be fast enough. Thanks for this PR.

I just added that check, one more lock acquire inside TryGetValue for cache dictionary. But I think it should be fast enough. Thanks for this PR.

i had considered doing this but for some reason i was worried about slowing down the non-cert generation code path.  but i don't see that as an issue when i think about it now.

I just added that check, one more lock acquire inside TryGetValue for cache dictionary. But I think it should be fast enough. Thanks for this PR.

i think you may want to remove my comment that discusses  a possible race.  i believe your additional check addresses that scenario.


ListBox virtualization gets turned off if control is hidden in different tab in TabControl

When the ListBox with virtualization enabled is hidden (for example in different tab) looks like virtualization is turned off.

Is this still happening? I tried to reproduce by adding tabs to the virtualization test, but I couldn't trigger it. If it is still happening do you have a repro?

Yes still happenning in Core2D. When I have ListBox in different tab and load project, switching to this tab causes huge memory spike and eventually crush.


Mariocube.BannerEditingTool version 0.8

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

This package appears to be installing Audacity instead of a banner editing tool:

2023-04-24 10:11:33.931 [CLI ] Starting: 'C:\Users\User\AppData\Local\Temp\WinGet\Mariocube.BannerEditingTool.0.8\extracted\tools\AudacityPortable.exe' with arguments '/S'

There were lots of other tools but selecting them crashed WinGetCreate so I chose it temporarily .

Again, in the folder are various portable Nintendo-related tools

Again, in the folder are various portable Nintendo-related tools

Yes, this is obvious to me now. The manifest launches AudacityPortable.exe, which is blocking validation. What's needed is a way to not launch anything - I tried removing that section from the manifest but it errored in a VM.

Closed: reason: will use the latest WinGetCreate to add the proper exe files

Closed: reason: will use the latest WinGetCreate to add the proper exe files


revert expected test_repr value for py3.10 following upstream

Type of changes

[ ] Bug fix
[ ] New feature
[ ] Documentation / docstrings
[x] Tests
[ ] Other

Checklist

[x] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[ ] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
All Enum changes were reverted from Python 3.10 just before rc1.  Revert
the test changes to fix test failures with 3.10.0rc1.

I don't think the original change to the test has been mentioned in the changelog, so I skipped it here too.

👍


Deprecate Python 3.6

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/316
Originally created by @edgarrmondragon on 2022-01-28 16:53:10

Summary
Python 3.6 has reached end of life last year on December 23rd, 2021.
Proposed benefits
Python 3.6 compatibility can be removed throughout the codebase.
Proposal details

Remove 3.6 from CI matrix
Remove dependency constraints for Python 3.6
Remove any compatibility hacks for 3.6 (e.g. those in singer_sdk/helpers/_compat.py)
Update any "old" Python syntax to >= 3.7 (via pyupgrade)

Best reasons not to build
It's really not that bad to continue supporting it for a while.

View 4 previous comments from the original issue on GitLab


GPU Plugin: Limit Login Screen FPS

Fixes #14360
Updates GPU Plugin to only unlock fps when the GameState is logged in and the config is set to true.

I apologize, I had prepared something internally yesterday for this as part of some other changes but had not pushed it. It additionally limits the fps on other game states such as the authenticator pin entry and early startup prior to login screen. I've pushed it now.

Ah, no worries


[docs] Add back uniforms-material info

Add back uniforms-material info to text component documentation as it was dropped at some point. We use it with Material-UI and it works great.

[ X] I have followed (at least) the PR section of the contributing guide.

@skirunman I have removed it as I think people need fewer options to choose from, but thank you for sharing. We will include it back, at some point in the future, if it gets more adoption :)

@skirunman I have removed it as I think people need fewer options to choose from, but thank you for sharing. We will include it back, at some point in the future, if it gets more adoption :)

@oliviertassinari Seems like a very strange position to take as more 3rd party solutions are better than less in my experience. What data do you have to come to this position? I have no "skin in the game" except as a very happy user. Maybe other Material-UI users would also like to use the technology if they new where to find it. See this comparison https://uniforms.tools/docs/compare-matrix

You can find more context in #15585.

Maybe other Material-UI users would also like to use the technology if they knew where to find it.

It's exactly what I want to avoid. We should document existing popular form integrations, anything else will create friction for the users, make them ask, which one they should use?

Based on your comments in  #15585 I'd say Material-UI should have Uniforms at the top of the list... In any case, your project, your decision, but stating this opinion

Fewer options => stronger options.

like it is fact just weakens your argument as based on my 20+ years of software engineering experience I have the completely opposite opinion.

I've not put a ton of thought in to this, but my initial criteria would be in this priority order:

A user (not necessarily the package developer) of both MUI and the forms package submits a PR to add the link to MUI docs.
Does the forms package have a wrapper/integration with MUI directly.
Does this MUI integration look to be well engineered and maintained and track MUI updates.
Is the overall package well engineered and maintained with a documentation site and with frequent commits/PRs merged, responses to issues, etc.
Does the forms package provide some potentially unique capabilities versus other forms package listed such as out of the box integrations with schemas/GraphGL or support for a new React API such as Hooks.
Does the package have at least enough adoption, or commitment by the package maintainers, that we feel it will be supported for at least the next 2-3 years.


fix: make got non optional peer dependency

Current dependencies on/for this PR:

main

PR #34   👈

This comment was auto-generated by Graphite.


Taylor/validate schema values also validates schema

:tada: This PR is included in version 7.2.14 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add additional documentation and unit tests for New-RubrikBootstrap and Get-RubrikBoostrap

Is your feature request related to a problem? Please describe.
New-RubrikBootstrap and Get-RubrikBootstrap were just added to the SDK. Now, additional documentation and unit tests for these cmdlets need to be added
Describe alternatives you've considered
N/A
Additional context
#373

I can probably work on this a little bit this week to help out. I'm not very knowledgeable about unit tests, but I can write documentation.

No worries @nshores . There are plenty of example tests out there if you want to take a look, but there is also  a learning curve. I'm writing lots of tests these days so this is something we can handle.


Fix wrong cert used in examples/client.rs

I got this error when trying to run the examples/client.rs
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: X509CertVerifyFailed', mbedtls/examples/client.rs:54:6
stack backtrace:
   0: rust_begin_unwind
             at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/std/src/panicking.rs:575:5
   1: core::panicking::panic_fmt
             at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/panicking.rs:64:14
   2: core::result::unwrap_failed
             at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/result.rs:1791:5
   3: core::result::Result<T,E>::unwrap
             at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/result.rs:1113:23
   4: client::main
             at ./mbedtls/examples/client.rs:49:5
   5: core::ops::function::FnOnce::call_once
             at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/ops/function.rs:507:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

I found that it's because of using the wrong cert in examples/client.rs
Fix with:
-   let cert = Arc::new(Certificate::from_pem_multiple(keys::PEM_CERT.as_bytes())?);
+   let cert = Arc::new(Certificate::from_pem_multiple(keys::ROOT_CA_CERT.as_bytes())?);

Same as #123

The certificate used for unit testing has expired #219

bors r+


Bootstrap before/after test checks

@happz is the documentation update planned in next PRs? I see now that there is alrady a dmesg check, but it is not documented at all?

@happz is the documentation update planned in next PRs? I see now that there is alrady a dmesg check, but it is not documented at all?

@happz what I more meant is tha tthe current spec docs mentions checks that are not even implemented?

I was hoping to add docs - user-facing docs, similar to ones describing various step plugins, a bit later, e.g. when adding a second check plugin. That would provide enough meat for docs, to establish their own section, examples, etc. With a single rather testing plugin, I still consider the area as settling done rather than being done & production ready.

@happz would be nice to show the checks in tmt test show at least.
Also I do not see the output anywhere else as in debug output, can come in later patches.

@happz would be nice to show the checks in tmt test show at least.
Also I do not see the output anywhere else as in debug output, can come in later patches.

@happz so we decided to defer also this one?

@happz would be nice to show the checks in tmt test show at least.
Also I do not see the output anywhere else as in debug output, can come in later patches.

@happz so we decided to defer also this one?

never mind, I was looking at wrong place


Having an issue with jasmine.any(Function)

Sorry to ask about this here (I know it's probably not an issue with meteor-jasmine), but I posted a question on Stack Overflow a few days ago and got no response. I've written a simple test but can't get it to pass. For some reason jasmine.any(Function) doesn't seem to be working as expected (or then maybe I'm doing something wrong).
Here is my test:
"use strict";
describe("Course", function () {
    it("should be created with a name", function () {
        spyOn(Courses, "insert").and.callFake(function(doc, callback) {
            // simulate async return of id = "1";
            callback(null, "1");
        });

        var course = new Course({name: "foo"});

        expect(course.name).toBe("foo");

        course.save();

        expect(Courses.insert).toHaveBeenCalledWith({name: "foo"}, jasmine.any(Function));
    });
});

and here is the result:
Course should be created with a name
 Expected spy insert to have been called with [ { name: 'foo' }, <jasmine.any(function Function() { [native code] })> ]
but actual calls were [ { name: 'foo' }, Function ].

This is what the insert function looks like:
Courses.insert(course, function(error, result) {
    return result;
});

Sorry, this is a bug with the current implementation. I'm working on fixing this. I the meantime you can run your test in the server integration mode.

Any progress on this?

Sorry, not yet.

+1, same issue here

The fix is to not use the server unit mode. Instead use the server integration mode for unit tests. The next release that will come this week, will no longer have different modes.

I'm getting this false failure in one test file, but not another with almost exactly the same call. (Different callbacks being passed in each module, respectively.)
The Jasmine version for the project I'm working on is "shrinkwrapped" to version 2.4.1
Will upgrading fix the test, or is this a regression?


Failed to locate bookmark index section

When I try the latest binary, I get an error messages as follows:
←[31m[error]←[0m   failed to locate bookmark index section

The server starts and I am able to access the web GUI but Scraper status remains Offline. Can you guide me as to I might be doing wrong. I do know there have been alot of changes from twitter so completely understand if the tbm is no longer working.

Hi @cannibalflea ,
many thanks for your report. A new version has been released :)
https://github.com/Webklex/tbm/releases/tag/2.2.0
The twitter api and website have indeed changed a bit, which caused some issues.


Activation Keys Refactor Promote "Teamnado-4774" to "master"

Description
This ticket involves code refactor of the following files : CreateActivationKeyWizard, ActivationKeys, and ActivationKeysTable. There are notes attached to the JIRA ticket to address the refactor suggestions.
Associated Jira ticket: # (issue)

Please include a summary of the change, what this fixes/creates/improves.
-AK Table - capitalized component throughout file
-CAKWizard - organized code into separate page components to condense file
-AKeys- ammends to  isLoading to match uniform across app.
How to test the PR
Please include steps to test your PR.
Before the change
After the change
Dependent work link
Checklist:

[ ] The commit message has the Jira ticket linked
[ ] PR has a short description
[ ] Screenshots before and after the change are added
[ ] Tests for the changes have been added
[ ] README.md is updated if necessary
[ ] Needs additional dependent work

Looks good


Reddit redirect is broken

Cannot GET /r/programming/comments/9lm757/core_data_concurrency/

I will grab this one


DNS system test is failing

See https://circleci.com/gh/GoogleCloudPlatform/google-cloud-java/11146 for sample failure log

The failure seems transient. I couldn't repro the issue on my machine and later circleci builds are successful.

Can we close this and re-open if it happens again?

Sure.


Reorganization of the Database downloading and the fixing #63

fixes #63
fixes #7
Change log:
Introduced a config.yml file to configure database download and to introduce a facility to configure other global parameters
fixed #63 - chebi database is now also downloaded once and that accessed as needed
downloading functions were adjusted to work with the new config.yml file
removed the unit tests for the download functions, as these have become obsolete
Ignoring synchronization of the Database directory
Added the figure for the general concept of MeMoMe in the concept directory

But it works for Stefano, so no idea whats wrong

Removing anconda from the channels makes most errors disappear

This is the problem with not manually curating the requirements file... I have no idea what is happening, but might be very specific to either your or my system. Lets discuss after Christmas, how to handle the requirements file in the future.


Custom note splashes on note type

Describe your problem here.
Any way to have specific note splashes on a specific note type? i tried stealing this line
setPropertyFromGroup('unspawnNotes', i, 'noteSplashTexture', 'NOTE_splashes_EYE');
but it makes it so only the first note of the type is a special note, all the others are normal, please help!
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No

for i = 0, getProperty("unspawnNotes.length") do
setPropertyFromGroup('unspawnNotes', i, 'noteSplashTexture', 'NOTE_splashes_EYE');
end

now the splashes dont get changed :/


ad.merge function

I would like to add a anndata.merge function, with similar functionality to xarray.merge.
Example
>>> expr_adata
AnnData object with n_obs × n_vars = 3000 × 15000
    layers: 'counts'
>>> pca_adata
AnnData object with n_obs × n_vars = 3000 × 15000
    uns: 'pca'
    obsm: 'X_pca'
    varm: 'PCs'
>>> ad.merge([expr_adata, pca_adata])
AnnData object with n_obs × n_vars = 3000 × 15000
    layers: 'counts'
    uns: 'pca'
    obsm: 'X_pca'
    varm: 'PCs'

Use cases
Partial-AnnDatas returned from functions
Many scanpy function take an anndata object, produce a number of elements, and add them back to the original anndata object. We could instead produce a new object which only holds the new elements, then ad.merge the results together. By itself, this is the exact same thing, but this refactoring would allow a few new uses.
Instead of updating the original, we could keep the results seperate. This would be useful for generating multiple parameterizations, or having a lightweight object to pass to further objects – as opposed to mutating or copying the whole original object.
Seperating parts of analyses
We could want to keep elements from annotation or analysis seperate until we need them. We could avoid keeping the large arrays in layers for a velocity analysis, until we actually want them.
scirpy
Scirpy has a function for doing this specifically with immense receptor data: scirpy.pp.merge_with_ir. This would be a more general case. The IR AnnData here is a bit like the "partial-AnnDatas" discussed above.
(please let me know if this isn't the case @grst)
Previous discussion
This has been suggested and discussed a number of places.

#266

The initial intent may be looking towards the backed case.
Being able to get the results of a function in an otherwise empty anndata function, then merging these results together would be quite useful.

#441, though the desired API is more like ad.merge(adata, {"obs": df}), i.e. other objects to merge can just be mappings.

Requirements
This would require full support for adata.X = None #467
Implimenting this would fit well with an anndata.align (#531) function (e.g. pass multiple anndata objects, return them with axes aligned). As the updates and reindexing are orthogonal.

sgkit does something similar to the "Partial-AnnDatas returned from functions", and controls whether a partial or updated object is returned with the merge kwarg

Just noting that the scirpy use-case is obsolete in favor of MuData after https://github.com/scverse/scirpy/pull/356/ gets merged.

This would be very nice to have, we produce a lot of heavy objects redundantly due to parametrisation of runs.


Allow Angle backend selection, add initial iOS Angle support.

Depends on https://github.com/godotengine/godot-angle-static/pull/3 (include workaround for massive leaks on macOS and iOS build config).

Adds project setting to select Angle backend (for all supported platforms).
Makes Angle over Metal usable on macOS (slow line drawing is still the issue).
Adds support for iOS build.

Update: Got it working with both ANGLE and native GL.

Great job. I've somehow managed to make it work. It was quite tricky because ios export don't work to me in this version. So I've used another exported project and just replaced the godot library.
There is no proper info how to create ANGLE build. I fortunately found this issue  #8345 and found that angle_libs need to be used. But also angle libs needs to be linked when compiling ios project.
Anyway I tried 3D platformer example - https://github.com/godotengine/godot-demo-projects/tree/master/3d/platformer
And it crashed. Here is the stack trace and log:

Godot Engine v4.3.dev.custom_build.ed40c756f - https://godotengine.org
ERROR: AudioOutputUnitStart failed, code: -50
at: start (drivers/coreaudio/audio_driver_coreaudio.cpp:251)
fopen failed for data file: errno = 2 (No such file or directory)
Errors found! Invalidating cache...
WARNING: Project setting "rendering/limits/global_shader_variables/buffer_size" exceeds maximum uniform buffer size of: 16384
at: MaterialStorage (drivers/gles3/storage/material_storage.cpp:1 114)
fopen failed for data file: errno = 2 (No such file or directory)
Errors found! Invalidating cache...
OpenGL API OpenGL ES 3.0.0 (ANGLE 2.1.21553 git hash: 430a4f559cbc) - Compatibility - Using Device: Google Inc. (Apple) - ANGLE (Apple, ANGLE Metal Renderer: Apple A10 GPU, Version 17.2 (Build 21C62))

ERROR: Couldn't get the CPU model name. Returning an empty string.
at: get_processor_name (platform/ios/os_ios.mm:367)
WARNING: Icon not supported by this display server.
at: set_icon (servers/display_server.cpp:587)
WARNING: MSAA is not supported on this device.
at: configure (drivers/gles3/storage/render_scene_buffers_gles3.cpp:232)
Warning: Compilation succeeded with:

program_source:81:39: warning: writable resources in non-void vertex function
vertex __VERTEX_OUT(ANGLE_VertexOut)  main0(ANGLE_VertexIn ANGLE_vertexIn [[stage_in]], constant ANGLEUniformBlock & ANGLE_angleUniforms [[buffer(17)]], uint32_t ANGLE_instanceIdMod [[instance_id]], uint32_t ANGLE_baseInstance [[base_instance]], uint32_t gl_VertexID [[vertex_id]] , device float* ANGLE_xfbBuffer0 [[buffer(30)]] )
                                      ^
program_source:81:298: note: writable buffer defined here
vertex __VERTEX_OUT(ANGLE_VertexOut)  main0(ANGLE_VertexIn ANGLE_vertexIn [[stage_in]], constant ANGLEUniformBlock & ANGLE_angleUniforms [[buffer(17)]], uint32_t ANGLE_instanceIdMod [[instance_id]], uint32_t ANGLE_baseInstance [[base_instance]], uint32_t gl_VertexID [[vertex_id]] , device float* ANGLE_xfbBuffer0 [[buffer(30)]] )
                                                                                ^
Warning: Compilation succeeded with:

program_source:81:39: warning: writable resources in non-void vertex function
vertex __VERTEX_OUT(ANGLE_VertexOut)  main0(ANGLE_VertexIn ANGLE_vertexIn [[stage_in]], constant ANGLEUniformBlock & ANGLE_angleUniforms [[buffer(17)]], uint32_t ANGLE_instanceIdMod [[instance_id]], uint32_t ANGLE_baseInstance [[base_instance]], uint32_t gl_VertexID [[vertex_id]] , device float* ANGLE_xfbBuffer0 [[buffer(30)]] )
                                      ^
program_source:81:298: note: writable buffer defined here
vertex __VERTEX_OUT(ANGLE_VertexOut)  main0(ANGLE_VertexIn ANGLE_vertexIn [[stage_in]], constant ANGLEUniformBlock & ANGLE_angleUniforms [[buffer(17)]], uint32_t ANGLE_instanceIdMod [[instance_id]], uint32_t ANGLE_baseInstance [[base_instance]], uint32_t gl_VertexID [[vertex_id]] , device float* ANGLE_xfbBuffer0 [[buffer(30)]] )
                                                                                ^
Warning: Compilation succeeded with:

program_source:622:39: warning: writable resources in non-void vertex function
vertex __VERTEX_OUT(ANGLE_VertexOut)  main0(ANGLE_VertexIn ANGLE_vertexIn [[stage_in]], constant ANGLEUniformBlock & ANGLE_angleUniforms [[buffer(17)]], metal::texture2d<float> ANGLE_184_skeleton_texture_texture [[texture(0)]], metal::sampler ANGLE_185_skeleton_texture_sampler [[sampler(0)]], uint32_t ANGLE_instanceIdMod [[instance_id]], uint32_t ANGLE_baseInstance [[base_instance]], uint32_t gl_VertexID [[vertex_id]] , device float* ANGLE_xfbBuffer0 [[buffer(30)]] )
                                      ^
program_source:622:439: note: writable buffer defined here
vertex __VERTEX_OUT(ANGLE_VertexOut)  main0(ANGLE_VertexIn ANGLE_vertexIn [[stage_in]], constant ANGLEUniformBlock & ANGLE_angleUniforms [[buffer(17)]], metal::texture2d<float> ANGLE_184_skeleton_texture_texture [[texture(0)]], metal::sampler ANGLE_185_skeleton_texture_sampler [[sampler(0)]], uint32_t ANGLE_instanceIdMod [[instance_id]], uint32_t ANGLE_baseInstance [[base_instance]], uint32_t gl_VertexID [[vertex_id]] , device float* ANGLE_xfbBuffer0 [[buffer(30)]] )
                                                                                ^
-[MTLDebugRenderCommandEncoder validateCommonDrawErrors:]:5775: failed assertion `Draw Errors Validation
Vertex Function(main0): argument vertexBuffer.2[0] from buffer(13) with offset(16) and length(48) has space for 32 bytes, but argument has a length(48).
Vertex Function(main0): argument vertexBuffer.3[0] from buffer(14) with offset(32) and length(48) has space for 16 bytes, but argument has a length(48).
'

2D platformer example works - https://github.com/godotengine/godot-demo-projects/tree/master/2d/platformer
But the performance is quite bad. With the release build, the iPad6th has about 20fps, iPhone 13 Max Pro about 40fps.
Debug texts themselves cause quite a significant fps drop, also it looks like GPU is not used at all.

also it looks like GPU is not used at all.

This is because GPU timing readouts are broken on mobile, at least when using the Compatibility rendering method. They only tend to work reliably on desktop platforms.


Update Rotate90.java

changed names of variables start and end to startIndex and endIndex for better understandibility of the code.
Summary by Sourcery
Enhancements:

Rename variables 'start' and 'end' to 'startIndex' and 'endIndex' for improved code readability.

Pls merge my Pr😇


fl_chart is so great

I want have scrollable on linechart,
Or can you guide me how to achieve it?
thanks by liuyasss

Hi, thanks, please choose meaningful names,
also, there is a duplicate issue here (there is a temporary solution), please search before creating an issue.
Cheers!

Hi, thanks, please choose meaningful names,
also, there is a duplicate issue here (there is a temporary solution), please search before creating an issue.
Cheers!

thanks


pipenv install add spurious "markers": "python_version == '3'" for a specific library since v2023.12.1, how to fix the library?

Issue description
pipenv install better-profanity adds "markers": "python_version == '3'", to Pipfile.lock. This started happening with pipenv v2023.12.1. The library has not changed, so this comes from a pipenv change. I would like to understand what to fix in better-profanity to avoid this behavior.
Expected result
pipenv install better-profanity makes an entry in Pipfile.lock that is usable
Actual result
            "markers": "python_version == '3'",

appears in Pipfile.lock
Steps to replicate
$ pipenv install better-profanity
$ grep -A8 better-profanity Pipfile.lock
        "better-profanity": {
            "hashes": [
                "sha256:8a6fdc8606d7471e7b5f6801917eca98ec211098262e82f62da4f5de3a73145b",
                "sha256:bd4c529ea6aa2db1aaa50524be1ed14d0fe5c664f1fd88c8bc388c7e9f9f00e8"
            ],
            "index": "pypi",
            "markers": "python_version == '3'", <<<< this is the bad line
            "version": "==0.7.0"
        },

I did some digging into this to see what version of pipenv changed behavior.
Using:
export VERSION=2023.8.25 && git checkout . && yes | pip uninstall pipenv && pip install pipenv==$VERSION && pipenv update && grep -A8 better-profanity Pipfile.lock

I got the following results:
2023.9.1 bad
2023.8.28 bad
2023.8.26 bad
2023.8.25 FAIL
2023.8.23 FAIL
2023.8.20 FAIL
2023.8.19 FAIL
2023.7.23 good
2023.7.11 good
2023.7.9 good
2023.6.26 good
2023.4.29 good
where FAIL is an error like this:
File "/opt/homebrew/lib/python3.11/site-packages/pipenv/utils/dependencies.py", line 620, in find_package_name_from_directory
    os.listdir(directory),
NotADirectoryError: [Errno 20] Not a directory: '/Users/bakert/pd/pipfile'

I wonder if the error is some kind of clue about what is going on here.

I ended up investigating this in some detail.
I isolated the problem away from my specific scenario. Now I'm just trying to pipenv install the better-profanity library in a new project:
[dent ~] mkdir test
[dent ~] cd test
[dent test] python3.12 -m venv .
[dent test] source bin/activate
(test) [dent test] for VERSION in 2023.12.1 2023.9.7 2023.8.28 2023.8.26 2023.8.25 2023.8.23 2023.8.22 2023.8.21 2023.8.20 2023.8.19 2023.7.23 2023.7.11 2023.7.9 2023.7.4 2023.7.3; do {echo $VERSION && \rm Pipfile*; yes | pip uninstall pipenv && pip install pipenv==$VERSION && pipenv install better-profanity && (grep -A8 better-profanity Pipfile.lock | grep -q "python_version == '3'" && echo "$VERSION bad" || echo "$VERSION good") || echo "$VERSION FAIL"} 2>/dev/null | egrep "(good|bad|FAIL)"; done

This gives me:
2023.12.1 bad
2023.9.7 FAIL
2023.8.28 FAIL
2023.8.26 FAIL
2023.8.25 FAIL
2023.8.23 FAIL
2023.8.22 FAIL
2023.8.21 FAIL
2023.8.20 FAIL
2023.8.19 FAIL
2023.7.23 good
2023.7.11 good
2023.7.9 good
2023.7.4 good
2023.7.3 good

The FAIL cases all give me an error like this:
  File "/Users/bakert/test/lib/python3.12/site-packages/pipenv/utils/resolver.py", line 812, in venv_resolve_deps
    return prepare_lockfile(
           ^^^^^^^^^^^^^^^^^
  File "/Users/bakert/test/lib/python3.12/site-packages/pipenv/utils/locking.py", line 143, in prepare_lockfile
    lockfile_entry = get_locked_dep(project, dep, pipfile, current_entry)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/bakert/test/lib/python3.12/site-packages/pipenv/utils/locking.py", line 126, in get_locked_dep
    lockfile_entry = clean_resolved_dep(project, dep, is_top_level, current_entry)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/bakert/test/lib/python3.12/site-packages/pipenv/utils/dependencies.py", line 300, in clean_resolved_dep
    current_entry.update(lockfile)
    ^^^^^^^^^^^^^^^^^^^^
AttributeError: 'String' object has no attribute 'update'

Probably needless to say a library like requests installs fine against any of these versions.
So pipenv's handling of something funky about better-profanity changed in 2023.8.19 to the point of crashing pipenv install. And then that was fixed up in some way in 2023.12.1 that meant that the bad line now gets added to Pipfile.lock.

My guess is in https://github.com/pypa/pipenv/commit/6ac1451ec86d2949855e557109c2eb92b61930fc by @matteius exposed an issue in whatever faulty metadata better-profanity is issuing. Before it was being swallowed/ignored in some way. That change caused it to instead crash pipenv. And then some change in v2023.12.1 stopped the crash, but now causes the bad line to be added to Pipefile.lock.
What might be the cause on the better-profanity side? I'm not sure as I don't really understand how pipenv works. I am guessing that something in the setup.py is not right:
    classifiers=[
        "Programming Language :: Python :: 3",
        "License :: OSI Approved :: MIT License",
        "Operating System :: OS Independent",
    ],
    python_requires="==3.*",

https://github.com/snguyenthanh/better_profanity/blob/master/setup.py
Maybe the wildcard isn't allowed. Or maybe a bare "3" with no minor version is causing the issue.
Maybe @matteius would be kind enough to take a quick look at this and help out an ignoramus :)

@bakert I greatly appreciate the amount of detail you have put into your analysis.    Here is what I can recall:

The conversion away from requirementslib was pretty good for the happy path, but then came the edge cases.
One such edge case involved some weird thing requirementslib was doing to pull in hashes/markers for top level dependencies that don't match the system being resolved on.
It was kind of a pickle, if I had more time I'd reference some of those issue reports, but I made some decision where sys_markers would continue to try resolving and if it could it would pull the right package data with markers, but if it couldn't then I'd advise users to move the sys markers to regular markers and then it would skip the package.
This was a mediocre compromise (as was the original implementation), but it kind of resolved those issues, though we still have some issues about people confused by that change in behavior.
As it related to this issue, with the markers, one thing I learned is the markers comparison logic that we use which I think is in packaging, is quite limited.
Off the top of my head I know for sure packaging is don't basic integer comparison on semver, and anything else kind of breaks it.
Quick check, look around here:  https://github.com/pypa/pipenv/blob/main/pipenv/patched/pip/_vendor/packaging/markers.py#L222-L244

I wish I could put a bit more time into now, but keep probing and I may be able to provide additional details.   There are other issues as it relates to those marker evaluations and dev dependency versions, so it could use more TLC.   I think my priorities are wrapping up the install refactor and some other things and getting the first pipenv 3000 semver release finalized; and if I had even more time I'd like to look at the pythonfinder bug reports/regressions I helped cause (but a proper solution).    Sorry to steal this post a minute for a general update, but I feel that the code base is finally to a point where we can support more Individual Contributions towards improving things -- there were a lot of hurdle to get over with pip-shims, requirementslib being its own repo that had ballooned into a mess, and not deterministic behavior from referencing the system pip prior--all of that has been resolved, and it should be easier than ever to contribute to pipenv, but I don't have a ton of time as of late to take on "everything".

I guess the "good" cases mean something else might have been happening in requirementslib, so looking back on that code base may provide more clues on possible improvements to pipenv.

Thanks for your comments @matteius . I think the one question I have now is … "is ==3.* a valid python version specifier?" What follows is a big discussion of what that matters but if you just know the answer to that question, that would be great!
I am coming around to the idea that this might be a pipenv bug rather than an issue with better-profanity's metadata.packaging seems to think ==3.* is a valid specifier, although that code is pretty permissive and not a strict check of the spec I don't think:
>>> from packaging.specifiers import Specifier                                                                                >>> "3.1" in Specifier("==3.*")
True
>>> "3.10" in Specifier("==3.*")
True
>>> "2.7" in Specifier("==3.*")
False

I've been debugging with a local copy of pipenv today and I've found that in more than one place during resolving of dependencies we take version specifiers and strip off any trailing .*. Notably in markers.normalize_specifier_set but also in markers._tuplize_version and maybe elsewhere too.
markers.normalize_specifier_set actually has this comment:
    .. note:: This function exists largely to deal with ``pyzmq`` which handles
        the ``requires_python`` specifier incorrectly, using ``3.7*`` rather than
        the correct form of ``3.7.*``.  This workaround can likely go away if
        we ever introduce enforcement for metadata standards on PyPI.

I guess it's much more normal to specify something like ==3.1.* or (more likely) >=3.1.* than it is to specify ==3.* as better-profanity does. But nothing I read in https://packaging.python.org/en/latest/specifications/version-specifiers/#version-specifiers suggests that ==3.* is not legal. There is even an example that involves ==2.*.
If we decide that ==3.* IS a valid identifier that we want to support I can look at making the necessary changes now that I'm passingly familiar with the code. But I guess we should rule on whether we even want that before I do that :)

@bakert I believe the workaround is to override the markers in the Pipfile so that it installs -- please see below:
Otherwise the package publisher would need to update their packages default markers:
matte@matteius-proart MINGW64 ~/projects/pipenv-triage/issue-6115
$ pipenv install better-profanity
Creating a virtualenv for this project
Pipfile: C:\Users\matte\projects\pipenv-triage\issue-6115\Pipfile
Using default python from C:\Users\matte\AppData\Local\Programs\Python\Python313\python.exe3.13.0 to create virtualenv...
[  ==] Creating virtual environment...created virtual environment CPython3.13.0.final.0-64 in 8770ms
  creator CPython3Windows(dest=C:\Users\matte\.virtualenvs\issue-6115-P366Bbhg, clear=False, no_vcs_ignore=False, global=False)
  seeder FromAppData(download=False, pip=bundle, via=copy, app_data_dir=C:\Users\matte\AppData\Local\pypa\virtualenv)
    added seed packages: pip==24.2
  activators BashActivator,BatchActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator

Successfully created virtual environment!
Virtualenv location: C:\Users\matte\.virtualenvs\issue-6115-P366Bbhg
Creating a Pipfile for this project...
Pipfile.lock not found, creating...
Locking [packages] dependencies...
Locking [dev-packages] dependencies...
Updated Pipfile.lock (494d5b4f482f0ef471f49afe28f00ec1a2ff75da2ce65060d8cabaeb3da2f100)!
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.
Installing better-profanity...
Installation Succeeded
Building requirements...
Resolving dependencies...
Success!
Building requirements...
Resolving dependencies...
Success!
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.
Installing dependencies from Pipfile.lock (f48753)...
All dependencies are now up-to-date!
Installing dependencies from Pipfile.lock (f48753)...

matte@matteius-proart MINGW64 ~/projects/pipenv-triage/issue-6115
$ cat Pipfile
[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[packages]
better-profanity = "*"

[dev-packages]

[requires]
python_version = "3.13"

matte@matteius-proart MINGW64 ~/projects/pipenv-triage/issue-6115
$ cat Pipfile.lock
{
    "_meta": {
        "hash": {
            "sha256": "1f0818c03397cae9ca8d519046ab327ffa3ba7659d3e1336d784aeb2baf48753"
        },
        "pipfile-spec": 6,
        "requires": {
            "python_version": "3.13"
        },
        "sources": [
            {
                "name": "pypi",
                "url": "https://pypi.org/simple",
                "verify_ssl": true
            }
        ]
    },
    "default": {
        "better-profanity": {
            "hashes": [
                "sha256:8a6fdc8606d7471e7b5f6801917eca98ec211098262e82f62da4f5de3a73145b",
                "sha256:bd4c529ea6aa2db1aaa50524be1ed14d0fe5c664f1fd88c8bc388c7e9f9f00e8"
            ],
            "index": "pypi",
            "markers": "python_version == '3'",
            "version": "==0.7.0"
        }
    },
    "develop": {}
}

matte@matteius-proart MINGW64 ~/projects/pipenv-triage/issue-6115
$ pipenv run pip freeze

matte@matteius-proart MINGW64 ~/projects/pipenv-triage/issue-6115
$ vim Pipfile

matte@matteius-proart MINGW64 ~/projects/pipenv-triage/issue-6115
$ pipenv lock -v
Locking [packages] dependencies...
Building requirements...
Resolving dependencies...
INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.starting()
INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.adding_requirement(SpecifierRequirement('better-profanity'), None)
INFO:pipenv.patched.pip._internal.operations.prepare:Collecting better-profanity (from -r C:\Users\matte\AppData\Local\Temp\pipenv-7x2zseht-requirements\pipenv-9935e7ew-constraints.txt (line 2))
INFO:pipenv.patched.pip._internal.network.download:Using cached better_profanity-0.7.0-py3-none-any.whl.metadata (7.1 kB)
INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.starting_round(0)
INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.pinning(LinkCandidate('https://files.pythonhosted.org/packages/f3/dd/0b074d89e903cc771721cde2c4bf3d8c9d114b5bd791af5c62bcf5fb9459/better
_profanity-0.7.0-py3-none-any.whl (from https://pypi.org/simple/better-profanity/) (requires-python:==3.*)'))
INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.ending_round(0, state)
INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.starting_round(1)
INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.ending(State(mapping=OrderedDict({'better-profanity':
LinkCandidate('https://files.pythonhosted.org/packages/f3/dd/0b074d89e903cc771721cde2c4bf3d8c9d114b5bd791af5c62bcf5fb9459/better_profanity-0.7.0-py3-none-any.whl (from https://pypi.org/simple/better-profanity/)
(requires-python:==3.*)')}), criteria={'better-profanity': Criterion((SpecifierRequirement('better-profanity'), via=None))}, backtrack_causes=[]))
INFO:pipenv.patched.pip._internal.network.download:Using cached better_profanity-0.7.0-py3-none-any.whl (46 kB)
[=== ] Locking packages...
Success!
Locking [dev-packages] dependencies...
Updated Pipfile.lock (68c786741e8dcc039f1e92f264953bbbb678c23f8aa33f14398ab5fe1a17955f)!

matte@matteius-proart MINGW64 ~/projects/pipenv-triage/issue-6115
$ pipenv lock -vc^C

matte@matteius-proart MINGW64 ~/projects/pipenv-triage/issue-6115
$ pipenv sync
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.
Installing dependencies from Pipfile.lock (17955f)...
All dependencies are now up-to-date!

matte@matteius-proart MINGW64 ~/projects/pipenv-triage/issue-6115
$ pipenv run pip freeze
better-profanity==0.7.0

matte@matteius-proart MINGW64 ~/projects/pipenv-triage/issue-6115
$ cat Pipfile
[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[packages]
better-profanity = {version = "*", markers = "python_version=='3.*'"}

[dev-packages]

[requires]
python_version = "3.13"

Thanks for the update. I do edit Pipfile.lock every time I pipenv install or similar to remove the bad line.
Are you saying that ==3.* is a valid version specifier that pipenv does not support? Or are you saying that it is an invalid version specifier and the library should change. If you let me know I'll try to fix it in the right place :)

I believe this is fixed by #6282

Circling back to this rather late in the day I can confirm that when I install a library in my project the better-profanity entry in my Pipfile.lock no longer gets updated to include "markers": "python_version == '3'". I struggled to test it in the manner I described above some months ago so I can't confirm total success, but practically speaking it seems to have done the trick. Thanks!


Publish UTBotJava-action on the GitHub Marketplace

Description
Publish UTBotJava-action on the GitHub Marketplace.
Expected behavior
Any developer can find our GitHub action on the Marketplace and then embed it into their workflow.

https://github.com/marketplace/actions/utbot-static-code-analysis


LDAP Authentication Support

Being able to leverage Active Directory via LDAP for authentication is a must-have for teams. Would love to see this!

This would be a real addition... I'm not sure I'm able to code this but would some code from the LDAP integration of Nextcloud help? https://github.com/nextcloud/server

If it would be great support ldap.
I have adapted the official niginx docker to add the auth-ldap module.
https://github.com/vsc55/docker_nginx_ldap
If it's any help.

I'd love to have LDAP in this repo! :)

+1

Same here!

+3

+1 I think in many (small) networks the the possibility of using ldap is not leveraged enough. SoHo / SMB networks should not have many unsynced passwords for different services as it reduces the likelihood of good password practices.

Would love to see this feature added.

+1

+1

+1

+1 😄

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1 😅

+1

Another +1

+1 definitely

+1

+1

Is LDAP supported?

+1

+1

+1

Is there any update on this feature? I’m eagerly waiting for it as it’s crucial for my project.

+1

+1

+1


Estimate maximum allowable timestep for moist baro wave

We need to estimate the maximum allowable timestep for:

moist baro wave
horizontal limiters (apply to advection + hyperdiffusion)
vertical FCT
SSP time stepper
target spatial resolution:

nh_poly = 3 (Nq = 4)
h_elem = 30
z_elem = 63

target time: 100days

Is the target resolution (which I grabbed from the dyamond job) okay? Also, how long should this be stable for to declare success? I've put 100 days for now, which will take ~1.5 hours to run assuming we can simulate at 10 SYPD, so this will need to be a long run. Based on the latest dyamond results (https://github.com/CliMA/ClimaAtmos.jl/issues/2314#issuecomment-1801136086), we're currently at 0.468 SYPD. So, at the moment, we should be able to finish 100 days in ~13 hours on the A100. Hopefully this will dramatically improve once we figure out what's wrong.
This issue is connected to the Update Limiters milestone. We can't reference ClimaCore milestones in ClimaAtmos, but I'd like to run these simulation in ClimaAtmos CI.

The high domain top in dyamond and other aquaplanet simulation is not realistic for baroclinic wave initial conditions, so that may cause some problems. Maybe you can keep z_max at 30000 but use 63 layers. If you want a faster turnaround I think 30 days would be good enough to check whether the simulation is stable. Having said that, it should be faster than dyamond, as there is no radiation.

Also, just note that the maximum timestep of moist held suarez and aquaplanet is in general 2 times smaller than that of moist baroclinic wave. See the current longrun pipeline (using ARS, central difference, and no limiter) for example.

@cmbengue, @dennisYatunin, @tapios, we've estimated the maximum timestep in #2542, can we close this?

Where are the results? We need the matrix of maximum allowable timestep and time to solution for ARS vs SSP, FCT vs CD, and possibly maximum number of Newton iteration. It needs to include a stable configuration with FCT.

These are the current results:
dts tested ∈ [50, ..., 300]
                     | stable  |   unstable
ARS_nolim_CD         | 150     |   160
SSP_nolim_FCT        |  none   |   all
SSP_lim_FCT          |  none   |   all
ARS_nolim_FCT (old)  | 80      |   90
ARS_nolim_FCT (new)  | 100     |   120
ARS_lim_FCT          | 80      |   90
ARS_lim_CD           | 120     |   150

I'll close out the second part of #2510, and then update the FCT cases since CD cases should not change, since changes so far have not changed CD-only behavior AFAIK.

Are the FCT cases using 1-moment microphysics? If not, then the second part of 2510 will not have any effect on them, since it will only change the results for simulations with passive tracers (q_rai, q_sno, etc.).

Thanks @charleskawczynski. Let's add the ARS_nolim_FCT to the longrun pipeline (maybe as an experimental longrun in the CPU pipeline, if you think it's sensitive to small changes in the numerics). And yes, the second part of 2510 should not have any effect, as there is no passive tracer in the current tests.

What is the SSP baseline without FCT (i.e., central differences in the vertical)?

I just started one with an without limiters here:

https://github.com/CliMA/ClimaAtmos.jl/pull/2576
https://github.com/CliMA/ClimaAtmos.jl/pull/2575

I'll update the table once they finish.

Thanks @charleskawczynski. Let's add the ARS_nolim_FCT to the longrun pipeline (maybe as an experimental longrun in the CPU pipeline, if you think it's sensitive to small changes in the numerics).

Sounds good, for now I'll add this at the largest stable dt, does that sound okay?

Thanks @charleskawczynski. Let's add the ARS_nolim_FCT to the longrun pipeline (maybe as an experimental longrun in the CPU pipeline, if you think it's sensitive to small changes in the numerics).

Sounds good, for now I'll add this at the largest stable dt, does that sound okay?

Yes, sounds good to me.

We need the matrix of maximum allowable timestep and time to solution for ARS vs SSP, FCT vs CD, and possibly maximum number of Newton iteration. It needs to include a stable configuration with FCT.

Does it need the maximum number of Newton iterations? What determines whether it's needed or not?
Regarding a stable configuration with FCT, should this be a separate issue being that SSP doesn't seem to be stable with FCT? I'd like to keep the scope of this issue narrow so that it can be closed in a finite time window.

Just checked some old notes. SSP may need more than 1 newton iteration, even for CD. see #1440 #1441. I'm fine with separating the issue into ARS and SSP, to keep the scope narrow.

In the Gardner et al. paper , they found they needed multiple Newton iterations for SSP (but only one for ARS).
SSP with CD should be stable with multiple Newton iterations. That's what Gardner et al. found. I'd like to know a baseline timestep for this.
If SSP IMEX is always unstable with FCT, we can table it for now (but document results in an issue). It must mean that there's something wrong with the implementation of SSP with limiters. In that case, we can use ARS for now and revisit this later (e.g., when @OsKnoth is visiting).

I've added SSP_lim_CD and SSP_nolim_CD to the table above. SSP seems to be unconditionally unstable. I'll retry both with more newton iterations.

It turns out that SSP is unstable even for 3 newton iterations

It turns out that SSP is unstable even for 3 newton iterations

Some of the jobs are stable, the build failed just because the artifact file size is too large to upload. e.g. https://buildkite.com/clima/climaatmos-ci/builds/16221#018d47cf-326f-4a81-aea7-775ae00ea867. I'm fixing it.


Recording filename sometimes missing stream name

I have an rtmp server created in Nginx designed to record streams manually. The application is thus defined in nginx.conf:
`
application hls {
live on;
meta copy;
on_publish http://localhost/auth.php;
recorder record {
record all manual;
record_suffix -%y%m%d-%H%M.flv;
record_path /var/videos/staging;
on_record_done http://localhost/recorded/index.php;
}
            hls on;
            hls_path /var/videos/hls/;
            hls_fragment 3;
            hls_playlist_length 60;
            wait_key off;
        }

`
The recorder has been working well until last week I modified the worker processes to "auto" and setup the rtmp_auto* and rtmp_socket_dir directives thus:
`
worker_processes  auto;
rtmp_auto_push on;
rtmp_auto_push_reconnect 1s;
rtmp_socket_dir /var/sock;
`
Now when a publisher starts a recording some of the recorded filenames are missing the stream name, For example, a stream with the name "syn" might produce a filename of "-180421-1300.flv" instead of "syn-180421-1300.flv".
Other problems with multiple threads were fixed with the rtmp directives I added, but this is a problem. Can this be corrected?
Thanks!
Gil Yoder

@jgyo Hi, in multi-processes mode, if recoding command is distributed to a worker process who is not the publisher, the recording file name disappears.
The following patch can fix it (remove the suffix '.txt').
bugfix.patch.txt

@immedia-eswar Hello, now everything is OK!
bugfix.patch.txt


MQTT subscriber example does not consider TD action Form broker information

observed behavior:
MQTT client subscribes and publishes to broker as specified in the reference.conf file
expected behavior:
MQTT client subscribes and publishes to broker as specified in the consumed TD

Yes, this is a known limitation of the current MQTT binding.
Unfortunately, we mention this limitation only in the source code: (https://github.com/sane-city/wot-servient/blob/master/wot-servient-binding-mqtt/src/main/java/city/sane/wot/binding/mqtt/MqttProtocolClient.java#L28)


Butterknife config is updated.

Butterknife config for version above 7.x is updated. I've kept the old $$ViewInjector line for the people using the old version of the library. Extra 1 line won't hurt. This way it will cover both versions.
Added a header.

Thanks for the contribution. I merged #54 to update the Butterknife config. I prefer having separate configs because some people will continue using the older version so I wanted references for both.

Mine was doing both. There is no harm having one more line in proguard
config. I think it is better to have 1 file for 2 versions.
On Sun, Jul 26, 2015, 8:02 PM Kevin Schultz<EMAIL_ADDRESS>wrote:

Closed #52
https://github.com/krschultz/android-proguard-snippets/pull/52.
—
Reply to this email directly or view it on GitHub
https://github.com/krschultz/android-proguard-snippets/pull/52#event-365544202
.


[android] Japanese translation updated. Added missing strings

Ticket #232

is that 100%?
Arigatōgozaimashita!

Yep