Allow pwd mount to be skipped

Kubernetes on Google Container OS doesn't like host mounts, so this adds a mount-checkout-path option so that this behaviour can be disabled.

I'm looking at this for a way to pre-build a single image and push to a registry, then parallelize all my tests against the image. The image would effectively replace the git commit sha for the rest of the pipeline.
I can use the docker-compose to build and push the initial image, but the "build" and "image" parameters in docker-compose seem incompatible. I'm thinking I either need to generate a new docker-compose field with the appropriate image reference at build time, or use the plain docker plugin for next steps... but the auto-mounted work directory is just in the way for this use case.

I don't have access to the build output. What was the failure?

This could probably be merged now @toolmantim. I can see it being useful when you don't actually want source in the container.
As more time goes on, I regret making the default behaviour that source and agent are mounted in by default.

I did figure my case out in the end with docker-compose plugin, but would still be nice to have this. One of my other pipelines occasionally has issues with dangling files with ownership issues that are a pain to clean up, since the buildkite-agent user isn't the owner.

I ran into another case where this "would be nice". I just want to run a step in a container without any real ties to the source repository. Basically just a step to download some thinks as attach them as build artifacts for another step - and there's really no need to mount the checkout directory for this. Any word on whether this can be merged?

I think this is better handled by #69.


[9.x] Names for on-demand log channels

This PR is connected with "On-Demand Channels" (https://laravel.com/docs/8.x/logging#on-demand-channels).
"On-Demand Channels" have been introduced by https://github.com/laravel/framework/pull/39273
Problem
Every call of a Log::build(...) uses the same log channel. Example (can be executed in tinker):
use Illuminate\Support\Facades\Log;

// ... some code

Log::build([
  'driver' => 'single',
  'path' => storage_path('foo/custom.log'),
])->info('foo');

// Now we have a "foo" record in a "foo" directory

// ... some code

Log::build([
  'driver' => 'single',
  'path' => storage_path('bar/custom.log'),
])->info('bar');

// New "bar" record, but still in a "foo" directory

Case
We have a queue running. Some jobs need certain channels (based on the names from a database). We've tried to use "On-Demand Channels". And now all information goes to one channel (the one is used by a first job appeared in a queue).
Possible solution
We can extend a "build" method by adding second optional parameter - the name of a channel.
For me it's hard to say is it good or bad from architectural perspective. But it certainly can be useful in some situations.
I've prepared a code change and a test method.
I've run tests by calling:
./vendor/bin/phpunit --filter=LogManagerTest

Eh, probably this should be fixed by simply making the manager not cache on-demand instances. I think that was the intended goal but was probably overlooked in the original PR.

It's likely this problem exists for on-demand disks as well.

Fixed by https://github.com/laravel/framework/commit/bc50a9b10097e66b59f0dfcabc6e100b8fedc760

Thank you.


Added bdd scenario for restock action

IBM Cloud toolchain: Delivery Pipeline deployed products to dev, including commit de6bae1e84fbbc86efe26e3d27f80d8f510ea397

IBM Cloud toolchain: Delivery Pipeline deployed products to prod, including commit de6bae1e84fbbc86efe26e3d27f80d8f510ea397


Suggestion: Lowering minimal Android version to KitKat

Welcome,
I would like to suggest lowering down the minimal Android version to API 19 - Android 4.4 KitKat.
It is still one of the most popular versions of the Android OS which still receive security updates from both Google and LineageOS (successor to CyanogenMod).
I have built and run successfully the Yuzu Browser with lowered to API 19 minimal version so it might not need much work with code (I have only changed this value).
Best regards,
mp107

It has some big problem.
First, biggest problem, Vector drawable isn't support on API 19. AppCompat isn't provide VectorDrawableCompat on getDrawable(). Google+
Second, I already removed the old API code and used the higher API code. I don't want to increase the code to support the older version.

I see.


elasticsearch-setup operation is not compatible with es 6.x or 7.x version

Describe the bug
When I start the elasticsearch-setup container, Something is wrong with ES v7.7.1:
{"error":"Content-Type header [application/x-www-form-urlencoded] is not supported","status":406}

When I add the Content-Type header, The following exception is reported:
dev@docker-build-1:/opt/datahub/docker/elasticsearch$ curl -sS -XPUT <IP_ADDRESS>:9200/corpuserinfodocument -H 'Content-Type: Application/JSON' --data @corpuser-index-config.json | jq .
{
  "error": {
    "root_cause": [
      {
        "type": "mapper_parsing_exception",
        "reason": "Root mapping definition has unsupported parameters:  [doc : {properties={skills={type=text}, urn={normalizer=custom_normalizer, type=keyword}, teams={type=text}, ldap={analyzer=lowercase_keyword, type=text, fields={ngram={analyzer=delimit_edgengram, type=text}}}, managerLdap={analyzer=lowercase_keyword, type=text, fields={ngram={analyzer=delimit_edgengram, type=text}}}, active={type=boolean}, fullName={type=text, fields={ngram={analyzer=delimit_edgengram, type=text}}}, title={normalizer=custom_normalizer, type=keyword}, aboutMe={type=text}}}]"
      }
    ],
    "type": "mapper_parsing_exception",
    "reason": "Failed to parse mapping [_doc]: Root mapping definition has unsupported parameters:  [doc : {properties={skills={type=text}, urn={normalizer=custom_normalizer, type=keyword}, teams={type=text}, ldap={analyzer=lowercase_keyword, type=text, fields={ngram={analyzer=delimit_edgengram, type=text}}}, managerLdap={analyzer=lowercase_keyword, type=text, fields={ngram={analyzer=delimit_edgengram, type=text}}}, active={type=boolean}, fullName={type=text, fields={ngram={analyzer=delimit_edgengram, type=text}}}, title={normalizer=custom_normalizer, type=keyword}, aboutMe={type=text}}}]",
    "caused_by": {
      "type": "mapper_parsing_exception",
      "reason": "Root mapping definition has unsupported parameters:  [doc : {properties={skills={type=text}, urn={normalizer=custom_normalizer, type=keyword}, teams={type=text}, ldap={analyzer=lowercase_keyword, type=text, fields={ngram={analyzer=delimit_edgengram, type=text}}}, managerLdap={analyzer=lowercase_keyword, type=text, fields={ngram={analyzer=delimit_edgengram, type=text}}}, active={type=boolean}, fullName={type=text, fields={ngram={analyzer=delimit_edgengram, type=text}}}, title={normalizer=custom_normalizer, type=keyword}, aboutMe={type=text}}}]"
    }
  },
  "status": 400
}

Ref: #1737

@cobolbaby The error is caused by the breaking change in ES 7.x with the removal of mapping types:
https://www.elastic.co/guide/en/elasticsearch/reference/current/removal-of-types.html

@cobolbaby It is caused by the breaking change in ES 7.x with the removal of mapping types:
https://www.elastic.co/guide/en/elasticsearch/reference/current/removal-of-types.html
Have you tried ES 6.x? Our current index mapping put “doc” as type for all indices, and it should be compatible with ES 6.X.
We will experiment to see if it is possible to create an index mapping that works for all three ES versions. Or, we can create a different version of index mapping for ES 7.x. However, to fully support ES 7.x,  we will need to pay effort on testing  & constructing new queries if necessary.

Yes, I have tried ES 6.7.0. It does not support.

@camelliazhang2018, In addition I have a question about the fields in the doc. If the current model definition already contains the information I need, do I only need to modify the content defined in index.json .

I would like to input some extra information about using the AWS ElasticSearch.
1 - I created a AWS VPC ElasticSearch version 5.6. The next version available is 6.0.
1.1 - I found this link explaining how to access the VPC ElasticSearch https://www.jeremydaly.com/access-aws-vpc-based-elasticsearch-cluster-locally.
1.2 - I am not sure if it will be necessary to amend  the application to use the AWS credentials/profile file in cause it is necessary to authenticate with ElasticSearch using access policy. I switched it off completely in order to be able to test the connectivity between the POD and ElasticSearch.
2 - Creating the index as per Dockerfile (commands below):
curl -XPUT https://vpc-datahub-es-pt-XXXXXXXXXXXXXXX.eu-central-1.es.amazonaws.com:443/corpuserinfodocument --data @corpuser-index-config.json
=> {"acknowledged":true,"shards_acknowledged":true,"index":"corpuserinfodocument"}%
curl -XPUT https://vpc-datahub-es-pt-XXXXXXXXXXXXXXX.eu-central-1.es.amazonaws.com:443/dataprocessdocument --data @dataprocess-index-config.json
==> {"acknowledged":true,"shards_acknowledged":true,"index":"dataprocessdocument"}
curl -XPUT https://vpc-datahub-es-pt-XXXXXXXXXXXXXXX.eu-central-1.es.amazonaws.com:443/datasetdocument --data @dataset-index-config.json
==> {"acknowledged":true,"shards_acknowledged":true,"index":"datasetdocument"}
3 - Updated the value.yaml
global:
elasticsearch:
host: "vpc-datahub-es-pt-XXXXXXXXXXXXXXX.eu-central-1.es.amazonaws.com"
port: "443"
4 - Deployed the helm charts using the command: helm3 install --namespace datahub datahub datahub/
When I check the logs of the POD I can see the error: 2020/07/24 13:33:13 Received 400 from http://vpc-datahub-es-pt-XXXXXXXXXXXXXXX.eu-central-1.es.amazonaws.com:443. Sleeping 1s
So I accessed the POD and execute the commands below:
curl https://vpc-datahub-es-pt-XXXXXXXXXXXXXXX.eu-central-1.es.amazonaws.com:443/_cat/indices
yellow open .kibana              YVSOjZ64QoK3PeTF7kX_Lg 1 1 1 0 3.2kb 3.2kb
yellow open corpuserinfodocument x0jqAtFMQcODYrUCC9PzQA 5 1 0 0  810b  810b
yellow open datasetdocument      bosiOF5YRC-X1NzgzYF1YA 5 1 0 0  810b  810b
yellow open dataprocessdocument  LgyAuMFlQYmQjEjftUSjNQ 5 1 0 0  810b  810b
curl https://vpc-datahub-es-pt-XXXXXXXXXXXXXXX.eu-central-1.es.amazonaws.com:443
{
"name" : "G8HxGZg",
"cluster_name" : "xxxxxxxxxxx:datahub-es-pt1",
"cluster_uuid" : "e7FpGywPRDWsxNshu9xKYg",
"version" : {
"number" : "5.6.17",
"build_hash" : "59bb0dx",
"build_date" : "2020-01-03T11:28:23.851Z",
"build_snapshot" : false,
"lucene_version" : "6.6.1"
},
"tagline" : "You Know, for Search"
}
I changed the logs level to DEBUG, but there is no other details that could help to understand the reason for code 400.
Any idea?
Thank you.
Fabio

@fabiofilz Hi Fabio, thanks for the sharing the steps in details. Not sure if you need to restart or anything else for log level to take effect. Without that, it is hard to guess what's wrong. For example, you can see a real error message for 400 such as one listed here .  A few things you may also want to try: 1. Check  the docker size and make sure to allocate at least 8GB of RAM + 2GB swap space. 2. Try a curl call to issue a match all query and see what returns?

@cobolbaby  I am a bit surprised that 6.x does not work, what is the error message for 6.7.0? Per ES documentation:
"Indices created in Elasticsearch 6.0.0 or later may only contain a single mapping type. Indices created in 5.x with multiple mapping types will continue to function as before in Elasticsearch 6.x. Types will be deprecated in APIs in Elasticsearch 7.0.0, and completely removed in 8.0.0.." I will try ES 6.x & 7.x and see how we can support. Will keep you posted.

@camelliazhang2018, In addition I have a question about the fields in the doc. If the current model definition already contains the information I need, do I only need to modify the map relationship in index.json . Ref: #1736
When improving the index configuration of different versions, can you make up the index.json, such as a table comment information?

I made the comment in that thread. Thanks.

@camelliazhang2018 Thx.

@camelliazhang2018, When I upgrade the ES version from 5.6.16 to 6.8.11, the ES console will show some prompts:
# ES console prompts when the service starts
[2020-07-28T09:41:29,044][WARN ][o.e.d.a.c.NGramTokenizerFactory] [b0pdh5T] Deprecated big difference between max_gram and min_gram in NGram Tokenizer,expected difference must be less than or equal to: [1]
[2020-07-28T09:41:33,565][WARN ][o.e.d.r.a.a.i.RestGetMappingAction] [b0pdh5T] [types removal] The parameter include_type_name should be explicitly specified in get mapping requests to prepare for 7.0. In 7.0 include_type_name will default to 'false', which means responses will omit the type name in mapping definitions.

[2020-07-28T09:41:31,885][WARN ][o.e.c.m.MetaDataMappingService] [b0pdh5T] [datasetdocument] re-syncing mappings with cluster state because of types [[doc]]
[2020-07-28T09:41:33,899][WARN ][o.e.c.m.MetaDataMappingService] [b0pdh5T] [dataprocessdocument] re-syncing mappings with cluster state because of types [[doc]]
[2020-07-28T09:41:36,965][WARN ][o.e.c.m.MetaDataMappingService] [b0pdh5T] [corpuserinfodocument] re-syncing mappings with cluster state because of types [[doc]]

# When searching for keywords
[2020-07-28T09:50:34,656][WARN ][o.e.d.c.ParseField       ] [b0pdh5T] Deprecated field [disable_coord] used, replaced by [disable_coord has been removed]
[2020-07-28T09:50:34,656][WARN ][o.e.d.s.a.I.Parser       ] [b0pdh5T] Deprecated aggregation order key [_term] used, replaced by [_key]
[2020-07-28T09:50:34,657][WARN ][o.e.d.s.a.I.Parser       ] [b0pdh5T] Deprecated aggregation order key [_term] used, replaced by [_key]

Although it does not seem to affect the work at present, it is best to adjust the index configuration to ensure that there will be no problems.

@camelliazhang2018 Would you mind to confirm how I should increase the log level?
I am using the helm charts to deploy datahub into k8s.
I executed the
curl https://vpc-datahub-es-pt-XXXXXXXXXXXXxx.eu-central-1.es.amazonaws.com/_search
{"took":17,"timed_out":false,"_shards":{"total":16,"successful":16,"skipped":0,"failed":0},"hits":{"total":1,"max_score":1.0,"hits":[{"_index":".kibana","_type":"config","_id":"5.6.8","_score":1.0,"_source":{"buildNum":15616}}]}}
Thank you.
Fabio

Hi,
As it used http instead of https, I disabled the option "Require HTTPS for all traffic to the domain" in AWS ElasticSearch and also changed the Port to 80 instead of 443 and it looks that it is working now.
2020/07/30 10:46:10 Received 200 from http://vpc-datahub-es-pt-XXXXXXXXXXXXXXX.eu-central-1.es.amazonaws.com:80
Regarding to logs:
ERROR StatusLogger No log4j2 configuration file found. Using default configuration: logging only errors to the console. Set system property 'log4j2.debug' to show Log4j2 internal initialization logging.
Thank you.
Fabio

@fabiofilz glad that you got it working in the end. I believe @shakti-garg-saxo & his team is working on adding https support for Elasticsearch. The logging level issue is tackled separately in https://github.com/linkedin/datahub/issues/1760.

Sorry, to clarify, what service is saying this?
ERROR StatusLogger No log4j2 configuration file found. Using default configuration: logging only errors to the console. Set system property 'log4j2.debug' to show Log4j2 internal initialization logging.

Hi @jplaisted, the datahub-gms-deployment service.

@fabiofilz That is great news, sorry that the lack of logging makes debugging harder and thanks for sharing the information with us. Please let us know if the rest of search queries work as expected.

@fabiofilz glad that you got it working in the end. I believe @shakti-garg-saxo & his team is working on adding https support for Elasticsearch. The logging level issue is tackled separately in #1760.

@mars-lan Is there a ticket for enabling https support for Elasticsearch?

@camelliazhang2018, When I upgrade the ES version from 5.6.16 to 6.8.11, the ES console will prompt some warnings:
# ES console prompts when the service starts
[2020-07-28T09:41:29,044][WARN ][o.e.d.a.c.NGramTokenizerFactory] [b0pdh5T] Deprecated big difference between max_gram and min_gram in NGram Tokenizer,expected difference must be less than or equal to: [1]
[2020-07-28T09:41:33,565][WARN ][o.e.d.r.a.a.i.RestGetMappingAction] [b0pdh5T] [types removal] The parameter include_type_name should be explicitly specified in get mapping requests to prepare for 7.0. In 7.0 include_type_name will default to 'false', which means responses will omit the type name in mapping definitions.

[2020-07-28T09:41:31,885][WARN ][o.e.c.m.MetaDataMappingService] [b0pdh5T] [datasetdocument] re-syncing mappings with cluster state because of types [[doc]]
[2020-07-28T09:41:33,899][WARN ][o.e.c.m.MetaDataMappingService] [b0pdh5T] [dataprocessdocument] re-syncing mappings with cluster state because of types [[doc]]
[2020-07-28T09:41:36,965][WARN ][o.e.c.m.MetaDataMappingService] [b0pdh5T] [corpuserinfodocument] re-syncing mappings with cluster state because of types [[doc]]

# When searching for keywords
[2020-07-28T09:50:34,656][WARN ][o.e.d.c.ParseField       ] [b0pdh5T] Deprecated field [disable_coord] used, replaced by [disable_coord has been removed]
[2020-07-28T09:50:34,656][WARN ][o.e.d.s.a.I.Parser       ] [b0pdh5T] Deprecated aggregation order key [_term] used, replaced by [_key]
[2020-07-28T09:50:34,657][WARN ][o.e.d.s.a.I.Parser       ] [b0pdh5T] Deprecated aggregation order key [_term] used, replaced by [_key]

Although it does not seem to affect the work at present, it is best to adjust the index configuration to ensure that there will be no problems.

Glad to see that works, and you can ignore those warnings if you decide to keep ES6.x. Upgrade to 6.x/7.x is definitely on our road map but not on priority list yet. Is there any specific feature you are looking for that is not currently supported?

@fabiofilz glad that you got it working in the end. I believe @shakti-garg-saxo & his team is working on adding https support for Elasticsearch. The logging level issue is tackled separately in #1760.

@mars-lan Is there a ticket for enabling https support for Elasticsearch?

Created https://github.com/linkedin/datahub/issues/1779 to track this. @shakti-garg-saxo can you confirm that you plan to work on it?

@camelliazhang2018 The motivation for the upgrade comes from our ES maintainers, who want to unify the version as much as possible.

@cobolbaby are you guys using DH in your production or just building POC? What's the name of your company? Mind if we add it to the list here? https://github.com/linkedin/datahub#adoption

Yes, we are currently building data warehouse for smart factory and looking for a metadata management platform to optimize the data warehouse model design and solve data quality issues.
Never mind, my company name is Inventec.

Yes, we are currently building data warehouse for smart factory and looking for a metadata management platform to optimize the data warehouse model design and solve data quality issues.
Never mind, my company name is Inventec.

Cool. I'm aware of Inventec. Added it to the "building POC & evaluating list". Please let us know once you've adopted DataHub so we can upgrade your company to the "adopter list".

Same story for you @fabiofilz. Please let us know if you'd like us to add your company to the list.

Hi, yes, that's ok. Company name is Kindred Group.

Bumping the thread. Has this been resolved?

cc. @dexter-mh-lee To take a look.

@shirshanka This should have been fixed along with the ES7 migration. Let's close the ticket!


Update pyproject.toml

removed qiskit-ibmq-provider

This PR is stale with no response from the author to feedback for > 2 months. Closing.


tests: watchdog: Do not fail on not permitted option

The test_wdt_callback_reset_none test doesn't account for the disable API returning -EPERM. This PR adds the skip option for the disable API, which returns -EPERM.

@martinjaeger @katsuster could you take a look please?


Websocket protocol violation

Beast Version: 70
Compiler: MSVC v141, compiled into an x86 binary
Calling async_write returns the error Websocket connection failed due to a protocol violation.
auto rtn = handle_read();

timer_.expires_from_now(std::chrono::seconds(15));

// Write Auth Message
ws_.async_write(boost::asio::buffer(&rtn[0], rtn.size()),
    strand_.wrap(std::bind(&connection::on_write,
        shared_from_this(), std::placeholders::_1)));

handle_read() is a function that returns a std::string based on the message read from the server. Sometimes a uint64_t that's been converted to an std::string, sometimes a hash. I've validated with a debugger that the string returned from handle_read is valid, printing and changing the string works fine as well as just turning it into a boost::asio::mutable_buffer, only when writing it does this occur.

Calling async_write returns the error Websocket connection failed due to a protocol violation.

That message corresponds to websocket::error::failed and can only be generated by a read operation:
https://github.com/vinniefalco/Beast/blob/fa1ac16584f03590ecea617a0dc2d8c86e48cda5/include/beast/websocket/impl/read.ipp#L663
https://github.com/vinniefalco/Beast/blob/fa1ac16584f03590ecea617a0dc2d8c86e48cda5/include/beast/websocket/impl/read.ipp#L677
I don't see how its possible for async_write to return that error. Here are all the places where async_write raises a specific error code:
https://github.com/vinniefalco/Beast/blob/fa1ac16584f03590ecea617a0dc2d8c86e48cda5/include/beast/websocket/impl/write.ipp#L485
It looks like you're running under Visual Studio, could you set a breakpoint on all occurrences of ec = error::failed; and get more information? That would help to track this down
Thanks

Sorry I made a bit of confusion. The error is thrown on a read operation, I just meant that using that write call is what is causing the error. Echoing back the sent binary works fine.
https://pastebin.com/QkXWhNYt This is the values for ec, and the error is being thrown in read.ipp, line 976.

You are using Beast for both client and server?

read.ipp, line 976.

This means that the other end is closing the websocket connection with a particular close code. Are you in control of the other end? The reason you are getting error::failed is because they did not cleanly shut down the connection.

I am using Beast for both client and Server. Let me log my server for a second and I'll step through and see where the close is sent.

The "Close the websocket connection" path (which causes the close frame to be sent) can be triggered from these locations:
https://github.com/vinniefalco/Beast/blob/78a065ba39836d91d7e70d93de7f9140f518083b/include/beast/websocket/impl/read.ipp#L216
https://github.com/vinniefalco/Beast/blob/78a065ba39836d91d7e70d93de7f9140f518083b/include/beast/websocket/impl/read.ipp#L247
https://github.com/vinniefalco/Beast/blob/78a065ba39836d91d7e70d93de7f9140f518083b/include/beast/websocket/impl/read.ipp#L324
https://github.com/vinniefalco/Beast/blob/78a065ba39836d91d7e70d93de7f9140f518083b/include/beast/websocket/impl/read.ipp#L365
https://github.com/vinniefalco/Beast/blob/78a065ba39836d91d7e70d93de7f9140f518083b/include/beast/websocket/impl/read.ipp#L387
https://github.com/vinniefalco/Beast/blob/78a065ba39836d91d7e70d93de7f9140f518083b/include/beast/websocket/impl/read.ipp#L480
The actual close frame is sent from here:
https://github.com/vinniefalco/Beast/blob/78a065ba39836d91d7e70d93de7f9140f518083b/include/beast/websocket/impl/read.ipp#L645
Thanks

So stepping through the code, here's essentially what happens now. The client opens a connection, handshakes properly, and writes the username to the server. The server reads correctly, handles the data and sends back a randomly generated number to use as an auth seed. Before the client receives the random number and after the server has sent it, the last call to be made is an async_read on the server's end. After this, the breakpoint on error::failed is triggered.
I set a breakpoint on every line you provided and it didn't trigger on any of them. At this point, I'll be happy to show you my source if you would like to inspect what's wrong, or I can also upgrade to the latest version of beast.

I'll have a look, my email is<EMAIL_ADDRESS>if you would like to keep the communications private (anything you send by email is presumed confidential unless otherwise specified).

Version 70 was June 28th, I don't see anything since then that might fix a bug in websocket:
https://github.com/vinniefalco/Beast/commits/develop/include/beast/websocket
That's the theory anyway. In practice who knows :) This is a mystery.

I responded by email, have we discovered the problem?

I don't feel like opening another issue but to continue this on, but the protocol violation was caused by writing a string of random numbers with the binary type of text. Using ws_.binary(true); solved the issue of the protocol error, however the data recieved on the client would be completely corrupted and be an array of null characters.
Ex:
Received: "ÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝ"```

Is this resolved?

Feel free to open a new issue if you get stuck again!


Aggregated report throws a runtime error

Can't process test artifacts for: testSurfaceLogging
Can't process test artifacts for: testAppQuitViaActivityFinish
Can't process test artifacts for: testSaveObstruction
Can't process test artifacts for: testOverflowObstruction
Can't process test artifacts for: testTriedItEndsImpressions
Can't process test artifacts for: testSaveObstruction
Can't process test artifacts for: testSaveObstruction
java.lang.RuntimeException: java.lang.RuntimeException: java.nio.file.NoSuchFileException: /project/bucket/2018-01-24_18:01:44.378000_Mlhf/41/NexusLowRes-25-en-portrait/logcat

The xml aggregated and uploaded fine.  I, unfortunately, don't know if the not found file was ever created.  I believe that the can't process test artifacts were all shards that partially failed.

I think JunitReport is somehow parsing temp files instead of waiting for the xml to finish downloading.

We assume that once the gsutil command completes the download is finished but apparently is not always the case. I'll try to figure out whats going on there.

Hi, thanks for opening an issue on the Flank repo. The Kotlin rewrite is now available for testing and feedback. This replaces the Java version of Flank.

https://github.com/TestArmada/flank/releases/tag/flank_snapshot

Join us in the#flank channel on the Firebase slack to chat. If this is still an issue in the new release, comment and let me know.

https://firebase.community/


Twitter addon suggestion:

So while the current twitter addon displays the latest tweet when it's sent out, why not have it so that if you do $twitter user it would fetch their latest tweet manually or have something like $twitter user 2 and it would fetch their second latest tweet and display it.
Examples
$twitter SomeRandomPerson
Output: [ Twitter ] @SomeRandomPerson: Hi Guys I'm some random person on twitter and this is my second tweet ever! :D
$twitter SomeRandomPerson 2
Output: [ Twitter ] @SomeRandomPerson: Hi Guys This is my first tweet ever!

Will do #63 before this.


I pray and hope Cosmic-Station will become the next best PS2 Emulator In Android History

If the dev needs testers I'm here to help as much as I can.

Someday, actually we're in a very initial stage by now, nothing works or anything could be seen on screen by now...

I imagine that now there's not much to test. Good luck with your emu! One question, why did you use dobiestation as reference instead of play! or pcsx2? Is performance related? The emu will be hle like play! or it will require bios files like pcsx2?

Basically, it's about the level of complexity. It's much easier for me to understand the (quick and dirty) code created by the Dobie group than to try to understand the feats of a much more sophisticated code like that of PCSX2, but in the future, yes, PCSX2 will become the base project for this one.

The next step now is to improve the interface and bring the first graphics to the screen

Thanks for your responses, I'll use my ps2 7004 dumped bios when you have something for testing, good luck :)

it will never be like play! it would be better if it weren't for netherx2

Yes, I think that netherx2 should be working in an open source project instead of patching a closed source one.


Refactor/firebase/functions/use on create

This is to tackle #641
I audited all of our cloud functions and it turns out that the user ref already used onCreate(). Apart from that, only in the post invocation write function, we seem to have a use case for onCreate(). Both, postLabWrite() as well as postExecutionWrite() perform actions that need to be executed at both, creation and update.
Only the second commit is relevant here as it's rebased on top of #789

Landed via: https://github.com/machinelabs/machinelabs/commit/f085367c9b9e3d644bdbfa0d9cb7a840a9ffdeb5


Added Pharo 7.0 32 and 64 bit versions to the build matrix

Pull Request Test Coverage Report for Build 563

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.423%

Totals

Change from base Build 561:
0.0%

Covered Lines:
4822

Relevant Lines:
4850

💛  - Coveralls


internal: Enable Envoy healthchecks

Fixes #695 by enabling a /healthz endpoint in Envoy to enable Kubernetes readiness probes. This also removes the ability to enable metrics since I'm reusing the same port to reduce the number of ports that we need to configure for Envoy.
Signed-off-by: Steve Sloka<EMAIL_ADDRESS>

@stevesloka metrics can still be enabled, just that the end-user must now specify an address & port. Right?

Will this cause issues if statsd is not deployed? I believe that flag was introduced when we added the ability to configure a statsd sink.

Although it seems like it was controlling more than just the statsd piece.

My idea to reuse the stats listener was to reduce the number of listeners. I could rever this and introduce another port if folks think that makes sense.
This now "enables" the stats listener, if the forwarder isn't turned on then its sort of a no-op. Specifying the the IP/Port is a way to override the default (if someone would like to).

I think reusing the port is fine. What might be an issue is unconditionally enabling Envoy's statsd feature where it pushes metrics to a statsd sink. What if statsd is not running? Does envoy error out? Is it just going to continue trying to push metrics even though nothing is listening for them?
An alternative would be to move the "if statsdEnabledcheck from old line 120 to old line 145 ininternal/envoy/config.go`.

Yeah, we could do that. Right now just enabling the statsd interface will send UDP to nowhere. But if you don't want that turned on then I agree we should probably allow it to be disabled, however, the Prometheus stats interface is still available.

+1 for disabling statsd-sink feature.  It's a CPU hog at scale.

@alexbrand @rosskukulinski I'm retesting this now, but should be updated so that the --enable-statsd now just enables the statsd piece.

@stevesloka ping, is this ready to merge?

yeah should be good now @davecheney, I just rebased it against master.

LGTM. Thank you.


Add Off-option in the available-schedules list

Selecting the Thermostat schedule "Off" option in pw-beta will turn the off the schedule for a location.
This could be a solution for what's discussed in https://github.com/plugwise/plugwise-beta/issues/523

Not working yet, needs a little more work...


fix(autoware_obstacle_stop_planner): register obstacle stop planner node with autoware scoping

Description
This PR updates the name of the composable node registration in CMakeLists.txt to include autoware:: scoping as specified in the node source file.
This change is fixes #8437 .
Parent Issue:

Link

How was this PR tested?
A composable node from an xml launch file was created as stated in the linked issue and the launch file was used to start the obstacle stop planner node.
The node started as expected in the component container and the expected obstacle slow down and obstacle stopping behaviors were visualized on RViz.
Notes for reviewers
This PR is created based on a previous PR and review by @brkay54 . In the process of fixing the sign off commits, I made some mistakes and that led to some unexpected workflow failures. So, I have closed the older PR #8438 in favor of this one. Apologies for the inconvenience!
Interface changes
None.
Effects on system behavior
None.

Hi @satoshi-ota @TakaHoribe @takayuki5168 , currently obstacle_stop_planner does not work. Could you check the PR when you are available?

@brkay54 @satoshi-ota Since I have not done PRs to this repo in the past, I am curious. Is it normal that some of the workflows like cppcheck-differential build-and-test-differential(humble) etc take more than a few days to report their statuses? I just wanted to know if there's anything pending from my side to have those workflow statuses.
Initially, I thought it may have something to do with not updating to latest main and I did that a few times last week. I can do it again, but just wanted to confirm if there's anything else.


Fixed broken links in "Meshery Operator, MeshSync, Broker Troubleshooting Guide"

Notes for Reviewers
This PR fixes #11737
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit c97eb90ed8ca75c4a0f5dfaf0634ae8c5ebbf6e7 at: https://66c7b2c137ef60bc6256a1dd--meshery-docs-preview.netlify.app


Adding data_path support for CLI operations

To resolve issue https://github.com/clemahieu/raiblocks/issues/328

Replaced with https://github.com/clemahieu/raiblocks/pull/586


feat: do not require default feature for unstable

This allows using the unstable features, without accidentally enabling the runtime.

@yoshuawuyts all fixed


Creating red-list array

Make an additional script for adding words that should not be stopwords. Typically words found in  facet arrays. Need to figure out how to handle filters containing several words.
Using the red-list is a different issue.

This will be something for libraries down-stream. But it should have the possibility to take a red-list array as input.


How do I use the saveAboveTolerance option?

Hi 👋
My tests are failing due to a minor difference which at the moment we want to ignore.

AssertionError
    + expected - actual

    -0.18
    +0

I saw the saveAboveTolerance option and have tried to implement it in my wdio test runner configuration file like this ...
exports.imageComparison = [
  'image-comparison',
  {
    baselineFolder: join(process.cwd(), './visualScreenshots/baselines/'),
    formatImageName: '{tag}-{logName}-{width}x{height}',
    screenshotPath: join(process.cwd(), 'visualScreenshots/'),
    savePerInstance: true,
    autoSaveBaseline: true,
    blockOutStatusBar: true, // mobile only
    blockOutToolBar: true, // mobile only
    scaleImagesToSameSize: true,
    ignoreAntialiasing: true,
    saveAboveTolerance: 1,
  },
];

But the test still fails with the same difference. I have also tried passing the option within checkElement, but that doesn't work either. I have tried to search for some example implementations and I can't see this in FAQ or any other open issue. Am I passing this incorrectly?
Environment (please complete the following information):

Node.js version: 18.1.0
NPM version: 8.8.0
Browser name and version: - unable to specify with sauce labs
Platform name and version: Android 12
WebdriverIO version: 7.20.5
wdio-image-comparison-service version: 3.1.1

Additional context
Add any other context about the problem here.

Hi @ayau1
The saveAboveTolerance option only saves the diffs above a tolerance, but does not have an impact on the assertions.
If you want to assert and allow a tolerance, then you need to change your assertions. You can doe something like this
await expect(
            await browser.checkElement(
                await $("#element-id"),
                "firstButtonElement",
                {
                    /* some options */
                }
            )
        ).toBeLessThan(1)

NOTE: Please prevent using tolerances like this, you might allow bugs you don't want to slip. Try to figure out why the difference is created

Ah ok, thanks for the clarification @wswebcreation


How to Connect MongoDB to Node.js Using Mongoose

Proposed title of article
How to Connect MongoDB to Node.js Using Mongoose
Introduction paragraph (2-3 paragraphs):
MongoDB is one of the most widely used No-SQL databases in the developer world today. No-SQL databases allow developers to send and retrieve data as JSON documents, instead of SQL objects. To work with MongoDB in a Node.js app, we need Mongoose.
Mongoose.js offers an "elegant MongoDB object modeling for node.js". It connects your MongoDB cluster with your Node app. It allows you to define objects with a strongly typed schema that is mapped onto your MongoDB document. Mongoose provides a lot of functionality for creating and working with schemas. In this tutorial we will look at how to integrate MongoDB with a Node.js application.
Key takeaways:
By the end of this tutorial, the reader will be able to:

Install Mongoose on a Node.js environment.
Import and setup Mongoose.
Create a database connection using Mongoose.
Verify the connection by performing a GET.

References:
N/A

Sounds like a good topic 👍  approved @nancy-maina


Cleanup and Dockerfile missing file

Cleanup in setup and added a missing file to copy on Dockerfile

Hey @michelpereira thanks for this PR, would you mind addressing the comments @cuducos made so we can aprove and merge this? I would really like that ;)

I was traveling, will follow up with this pull request.

Do I need to close this pull request and open a new one with the proposed changes?

Do I need to close this pull request and open a new one with the proposed changes?

No need for that, just commit and push changes to this same branch and the novelties will automagically be in this PR.


Rename dec2 to dask-ec2

We are in the process of renaming dec2 to dask-ec2 (https://github.com/dask/dask-ec2/pull/21) as a library and package in pypi and we would like to do the same for this conda-forge recipe. I don't know if this has happened in the past but I wanted to get opinions on the best way of doing this.
cc. @jakirkham

Hi @danielfrg. For the time being, simply renaming the package in the recipe will do the trick (I think). I have linked to an issue which should be the place to develop and document how to go about renaming a feedstock. I have done it once before manually, and honestly, I'd rather automate the thing 😉
Does that work for you for the time being?

Well, there isn't really much history here. Could we just put the renamed package through staged-recipes? Or is there something else I'm missing here?

Yes, submitting again through staged-recipes was my first idea but wanted to get some feedback first. I kinda just wanted to not have a zombie dec2-feedstock repo when we are going to be updating the new dask-ec2-feedstock. If you guys are ok with that then I will submit a new one feedstock.
If we prefer to rename the repo can I get one of the admins to rename this repo to dask-ec2? And I will update the recipe to match the new package.

Feel free to just update the package name in the recipe. The repo rename will have to be done once we have tooled appropriately - it will happen as there is a clear need for it.
Right now, I'd prefer taking this approach to the zombie repo approach of resubmitting to staged-recipes.

Would it be possible to put the outcome of this conversation where people could get at it more sally (an FAQ or manual?) This seems like an important thing to know (in case you miss-name a package) but takes some very artful googling to find.

Sure, that was at least one of the goals of issue ( https://github.com/conda-forge/conda-forge.github.io/issues/179 ). Would you be interested in doing a PR to docs repo, @CJ-Wright?

@jakirkham Is there anywhere in particular you would like this info in the docs?

Not sure ATM. Let's move this discussion over to webpage repo issue ( https://github.com/conda-forge/conda-forge.github.io/issues/179 ).


[Bug] In cdc database synchronization, data changes to new tables using the combined mode are not monitored, and the job needs to be restarted

Search before asking

[X] I searched in the issues and found nothing similar.

Paimon version
paimon-flink-1.18-0.9-20240610.002222-13
paimon-flink-action-0.9-20240610.002222-13
Compute Engine
flink1.18
Minimal reproduce step
In the cdc database synchronization, the combined mode synchronizes new tables, but does not monitor data changes to the new tables, so the job needs to restart
What doesn't meet your expectations?
I want to dynamically listen to the binlog of new table data without restarting the job
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

I encountered the same issue. I only saw the schema was synchronized, but the data was not synchronized.

Hi, you should use flink-sql-connector-mysql-cdc-2.3.0.jar. Other versions of this jar still have compatibility bugs with paimon.

Hi, you should use flink-sql-connector-mysql-cdc-2.3.0.jar. Other versions of this jar still have compatibility bugs with paimon.您好，应使用 flink-sql-connector-mysql-cdc-2.3.0.jar。其他版本的此 jar 还存在与 paimon 兼容性问题的 Bug。

Thank you very much, this is feasible.


Example from README not working

Hi, I tried to train the example on DMC Vision but got the following error:
python3 dreamer.py --configs dmc_vision --task dmc_walker_walk --logdir ./logdir/dmc_walker_walk
Logdir logdir/dmc_walker_walk
Create envs.
libEGL warning: MESA-LOADER: failed to open swrast: /usr/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/x86_64-linux-gnu/dri:$${ORIGIN}/dri:/usr/lib/dri, suffix _dri)
libEGL warning: MESA-LOADER: failed to open swrast: /usr/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/x86_64-linux-gnu/dri:$${ORIGIN}/dri:/usr/lib/dri, suffix _dri)
Traceback (most recent call last):
File "/home/stuart/Github/dreamerv3-torch/dreamer.py", line 418, in
main(parser.parse_args(remaining))
File "/home/stuart/Github/dreamerv3-torch/dreamer.py", line 332, in main
train_envs = [make("train") for _ in range(config.envs)]
File "/home/stuart/Github/dreamerv3-torch/dreamer.py", line 332, in
train_envs = [make("train") for _ in range(config.envs)]
File "/home/stuart/Github/dreamerv3-torch/dreamer.py", line 331, in
make = lambda mode: make_env(config, logger, mode, train_eps, eval_eps)
File "/home/stuart/Github/dreamerv3-torch/dreamer.py", line 190, in make_env
env = dmc.DeepMindControl(task, config.action_repeat, config.size)
File "/home/stuart/Github/dreamerv3-torch/envs/dmc.py", line 11, in init
from dm_control import suite
File "/home/stuart/miniconda3/envs/dreamer3.9/lib/python3.9/site-packages/dm_control/suite/init.py", line 24, in
from dm_control.suite import acrobot
File "/home/stuart/miniconda3/envs/dreamer3.9/lib/python3.9/site-packages/dm_control/suite/acrobot.py", line 20, in
from dm_control import mujoco
File "/home/stuart/miniconda3/envs/dreamer3.9/lib/python3.9/site-packages/dm_control/mujoco/init.py", line 18, in
from dm_control.mujoco.engine import action_spec
File "/home/stuart/miniconda3/envs/dreamer3.9/lib/python3.9/site-packages/dm_control/mujoco/engine.py", line 41, in
from dm_control import _render
File "/home/stuart/miniconda3/envs/dreamer3.9/lib/python3.9/site-packages/dm_control/_render/init.py", line 86, in
Renderer = import_func()
File "/home/stuart/miniconda3/envs/dreamer3.9/lib/python3.9/site-packages/dm_control/_render/init.py", line 36, in _import_egl
from dm_control._render.pyopengl.egl_renderer import EGLContext
File "/home/stuart/miniconda3/envs/dreamer3.9/lib/python3.9/site-packages/dm_control/_render/pyopengl/egl_renderer.py", line 75, in
raise ImportError('Cannot initialize a headless EGL display.')
ImportError: Cannot initialize a headless EGL display.

@StuartShanks
Hello,
It seems like the error is related to the rendering of DMC (DeepMind Control). You might find a solution by referring to this issue on GitHub. It could be beneficial in resolving the problem you encountered.


Break

Sorry I have to take break.

Something just doesn't feel right. Not sure ifs a test my humanity and integrity. But I can't do this anymore not when I feel the energy around not agree


server: implement column filters in Select()

Since the unit test for Monitor() requests all columns,
we now have to expect empty fields for those columns in
the response.
Previously Select() just ignored the columns that
Monitor() requested and thus elided empty columns from
the result.
@trozet @dave-tucker @jcaamano

Just a heads up on the different behavior of including empty columns whether they were requested or not. If no columns were requested, empty columns are not included. For requested columns, empty columns are included.
The RFC is not really explicit about it
   If "columns" is not specified, all the
   table's columns are included (including the internally generated
   "_uuid" and "_version" columns).

Should we check what the ovs ovsdb server does?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

22 of 32 (68.75%)  changed or added relevant lines in 4 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 73.399%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

server/transact.go
2
3
66.67%

server/server.go
4
6
66.67%

ovsdb/set.go
1
4
25.0%

mapper/mapper.go
15
19
78.95%

Files with Coverage Reduction
New Missed Lines
%

server/transact.go
2
69.57%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
4423

Relevant Lines:
6026

💛  - Coveralls


Roll Flutter Engine from 0629a5ca2ef4 to 497ce8e50b2f (3 revisions)

https://github.com/flutter/engine/compare/0629a5ca2ef4...497ce8e50b2f
2024-07-16<EMAIL_ADDRESS>Roll Skia from 93ddcf356a02 to 3a0067d2f105 (4 revisions) (flutter/engine#53933)
2024-07-16<EMAIL_ADDRESS>Bump github/codeql-action from 3.25.11 to 3.25.12 (flutter/engine#53930)
2024-07-16<EMAIL_ADDRESS>Bump actions/setup-python from 5.1.0 to 5.1.1 (flutter/engine#53932)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add a new data structure: Graph

Added a new folder for a new Data Structure - Graph.
Added the code for Depth First Search Traversal.

Please let me know if any changes are required

Hello @raghuramjee7 !!
Great job on implementing the Depth First Search algorithm for graphs. However, I believe it would be beneficial to include a main function that allows users to provide input, giving them a better understanding of how the algorithm works and what the output looks like after executing the code.

Also, it would be great if you can open an issue for this and link your PR there.

Any updates @raghuramjee7 ?

Stale now!


Prefer Wikidata SVG logos over social media icons for brand presets

When a brand entry in the name-suggestion-index has an SVG image as its Wikidata logo, prefer that image over any Facebook or Twitter logo.
Official Facebook and Twitter accounts are not always as reliable as Wikidata items for brand logos. A brand may adopt a non-logo as its social media photo as part of a marketing campaign. However effective the marketing message may be in the context of a social media profile, it’s simply jarring when it appears in iD preset search results, where the user isn’t expecting an advertising message.

Wikidata on the left.
Here, the SVG logo from Wikidata is much more recognizable than the profile picture KFC is currently displaying on Facebook and Twitter, which is meant to be viewed in the context of a larger profile cover photo. As I understand it, the point of putting these icons in the search results is to increase the presets’ recognizability.
KFC’s marketing campaign may be ephemeral, but some brands choose social media photos that are still less recognizable than a logo would be:

This isn’t to say that logos in Wikidata are always the most suitable for iD. But most of the time, an image from Wikidata would be unsuitable because it’s a photo of a store location or a very wide logo. To mitigate these issues, we could keep the current behavior whenever the Wikidata logo has an illegible aspect ratio like 1:6 or wider, or when the Wikidata logo is a JPEG or PNG.
https://github.com/openstreetmap/iD/blob/ddc9d16b62c2e84f3d3716bbcca01930686052ca/build_data.js#L253-L260

For the record, I see absolutely nothing wrong with this 😆

ok.. So I did this, and it didn't work as well as I had hoped..
The main problem is that these wiki commons logos are often really not square.  I left the code in build_data.js commented out for now, because it was producing noticeably worse results.
commons:

facebook:

Is non squareness sole problem or is it worse?

Is non squareness sole problem or is it worse?

That's the sole problem.  They just don't look good in the space where we are using them, in the way that a profile picture would..

Is allowing only relatively square ones too complicated or is it just case "someone needs to code it"?

Is allowing only relatively square ones too complicated or is it just case "someone needs to code it"?

Currently, iD only flags buildings if they are very close to being square (some corners are almost 90°), don't have too many nodes, and aren't connected to other buildings.  A triangular building, for example, would not be flagged

Is allowing only relatively square ones too complicated or is it just case "someone needs to code it"?

We'd need to fetch the images to determine their dimensions.
Also they can change at any time, and I wouldn't expect the Wikipedia folks to change all their logos to accommodate iD.  I understand the appeal of using Wikipedia commons logos, but it really feels like a dead-end to me.

Currently, iD only flags buildings if they are very close to being square (some corners are almost 90°), don't have too many nodes, and aren't connected to other buildings. A triangular building, for example, would not be flagged

This issue isn't about buildings - it's about logos.  😆
But for the record.. iD can detect and square triangular buildings just fine 👍

Yikes!  I confused two issues I've been following - plus I'm used to people not understanding the square validation.
I meant above that a triangle with only 60° angles won't get turned into a square.

We do have some triangular logos in the index, but thankfully they’re encased in rectangular images. 😉

We'd need to fetch the images to determine their dimensions.

The Wikimedia Commons API can fetch file metadata in bulk without fetching individual images: osmlab/name-suggestion-index#2641.

KFC is back to being… less buff… but now Burger King has joined in on the fun: osmlab/name-suggestion-index#2798.


Isn't there a loadFromJson method

great lib, but only thing missing is a loadFromJson method, which will be a great help in it

Hey!
Yes, i agree with you, it will be added very soon.
Thank you!

i will be waiting for it. Thanks for the response


I Think PageSize doesn't work

Hello,
I use search api (Tweetinvi 5.0.3) with a trending hashtag, it returns 15 or 13 etc. tweet everytime. I want to use max objects so I declare Pagesize :
 SearchTweetsParameters searchTweetParameters = new SearchTweetsParameters(searchQuery)
            {
                SearchType = SearchResultType.Popular,
                PageSize=100
            };

            var all =await _userClient.Search.SearchTweetsAsync(searchTweetParameters);

I still get 15 tweets although PageSize is 100. Can someone help please? I think there might be bug.

I realize when I choose popular results, I get 15 tweet, but except this I really get 100 tweets.


[FLINK-1740] Pass config param for numberOfExecutionRetries to the JobGraph for streaming jobs

We now use the config parameter for numberofExecutionRetries on the generated job graph.
Also piggypacked a minor fix for a compilation error that currently occurs in flink-tests

Added a comment to the JIRA issue, but the suggestion make sense, @senorcarbone. Let me add a bit of doc and merge this.

Thanks @mbalassi! If you merge can you remove the quickfix (2872308)?  It looks like @hsaputra  pushed it already

Sure, rebasing to master does that.

Indeed, cool. Good to know

Change looks good, but can you try and stick with the code style of the remaining project?

Just a minor thing: I vote that PR titles should include some text about what the PR is about, for example like the first commit msg. That way it is easier to figure out what is interesting to review or what has been reviewed already (imagine multiple PRs with only issue numbers).

@StephanEwen @uce  I definitely agree, thanks for the feedback!

@gyfora, did you really have to push this so eagerly?

The behaviour is not documented anywhere
Commit b6f183a is just plain useless after the rebase
I stated that I'm merging it and had a version fixing those issues that is currently running on travis

sorry this was a miscommunication between the three of us


contribution of words for nova memorial

I did not build the website after adding these words—hoping it just works!

In order to contribute to a Nivenly Foundation project you must sign and agree to the CLA. Reply with @cla-bot check to check again.

@cla-bot-check


Update ProxyTemplates examples for xDSv3

What happened?
We still haven't updated the docs.

It's done


fix(Dropdown): placeholder value changes on opening the dropdown without selecting a value

Steps to Reproduce

open the dropdown

Expected
Place holder value should remain intact until a value is selected
Result
Placeholder value changes to first option.
Testcase

I don't know if that case is a issue. Only happen when you have selection and it is not multiple or search. I solved that case to keep placeholder in this way.
<Dropdown         selectOnBlur={false}         onChange={this.handleChange}         placeholder="Select State ..."         selection         options={options}         text={value || "Select State ..."}       />
it is only a example, you can manage in other way. You can check it form here. See codepen

This is, in fact, the intended behavior of the Dropdown.  See the original Dropdown here:
https://semantic-ui.com/modules/dropdown#search-selection
The placeholder is used to show a preview of the selected item's value or text attribute.

@levithomason This is not happening on the link you shared, and the behavior is different if we check on React Semantic Dropdown and Semantic UI Dropdown.
On react the placeholder changes, on the other one not.

This behavior is indeed weird, please reopen


fix: csound-manual by using newer git revision

Motivation for this change
With tag 6.12.0 this error is produced
Traceback (most recent call last):
  File "csd2docbook.py", line 373, in <module>
    CsoundScoreLexer.tokens['root'][3] = (stateTuple[0], Token.Name.Builtin, stateTuple[2])
IndexError: tuple index out of range
make[1]: *** [Makefile:700: examples-xml/stamp] Error 1

This only started to happen recently after I updated my channels.
Things done
So tried the master branch of the manual, and it works, no idea what was done from the tagging to today. So I'm worried if I'm not versioning this right, if I should use the revision as version number, or it's ok to keep it like this, there hasn't been any new release of the csound manual.

[ x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ x ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

relevant for 19.03, #56826
@GrahamcOfBorg build csound-manual

@GrahamcOfBorg build csound-manual


Integrate Github API to the experiment request form for filing issues in refinebio repo

Context
When users submit the experiment request form for the experiments with non-downloadable samples (https://github.com/AlexsLemonade/refinebio-web/issues/221), we'll create a new github issue in the refinebio repo with a title Dataset Request EXERIMENT_ACCESSION_CODE.
e.g., The dataset request issue for the accession code SRP103305 filed in the refinebio repo:

Problem or idea
We'll need to integrate the Github API to the experiment request form for the experiments with non-downloadable samples in order to file a new issue in the refinebio repo  for the corresponding data request.
Solution or next step

Reuse #223 implementation
Integrate the Github API with the experiment request form

Create any sub-components or helpers as necessary

Clean up any mock data or temp code blocks created for demo

🗒  This was addressed in PR https://github.com/AlexsLemonade/refinebio-web/pull/301 , thus closing.


The connection to service named com.apple.commcenter.coretelephony.xpc was invalidated

run app on simulator with 'iPhone X' from xcode, in debug area, show this error info.
Detail Info
[NetworkInfo] Descriptors query returned error: Error Domain=NSCocoaErrorDomain Code=4099
 “The connection to service named com.apple.commcenter.coretelephony.xpc was invalidated.”
UserInfo={NSDebugDescription=The connection to service named
com.apple.commcenter.coretelephony.xpc was invalidated.}

Summary
react-native info
  React Native Environment Info:
    System:
      OS: macOS High Sierra 10.13.6
      CPU: x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
      Memory: 88.89 MB / 16.00 GB
      Shell: 5.6.2 - /usr/local/bin/zsh
    Binaries:
      Node: 10.15.0 - ~/./node/v10.15.0/bin/node
      Yarn: 1.13.0 - ~/./node/v10.15.0/bin/yarn
      npm: 6.5.0 - ~/.node/v10.15.0/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
      Android SDK:
        Build Tools: 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.3, 24.0.3, 25.0.0, 25.0.3, 26.0.2, 26.0.3, 27.0.3, 28.0.3
        API Levels: 17, 18, 19, 20, 21, 22, 23, 25, 26, 27, 28
    IDEs:
      Android Studio: 3.2 AI-181.55<IP_ADDRESS>56338
      Xcode: 10.1/10B61 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.7.0 => 16.7.0
      react-native: 0.57.8 => 0.57.8
    npmGlobalPackages:
      react-native-cli: 2.0.1

Thought I should take a stab at this. Running this fixes the issue:
xcrun simctl spawn booted log config --mode "level:off"  --subsystem com.apple.CoreTelephony

Source: https://stackoverflow.com/questions/52455652/xcode-10-seems-to-break-com-apple-commcenter-coretelephony-xpc
It simply disables logging for the CoreTelephony framework.
Not sure if this needs a PR.

Huh - that's some voodoo right there. I notice in the comments linked there (https://stackoverflow.com/questions/52455652/xcode-10-seems-to-break-com-apple-commcenter-coretelephony-xpc#comment92494959_52455652) that this seems to resolve on Mojave?
I personally haven't seen this because I keep my OS up to date on the macOS side which I expect most people do since it's up to date.
So I'd think this response in this issue should be sufficient assuming it is true that it is not present on macOS-current
Can you confirm that you actually saw this error (indicating we need some docs), or did you just go after an issue and find stackoverflow (as it frequently does) had the perfect answer (and we can just close this and let it go)?

I'm on Mojave 10.14.2. The error pops up when you run the example project.

Running the script fixes the problem. An alternative fix is to set the OS_ACTIVITY_MODE = disable variable to XCode's environment variables, which disables system level logging altogether. But it's something the user has to do.

Huh. Sounds like the perfect thing for the Troubleshooting section then? https://github.com/react-native-community/react-native-device-info/blob/master/README.md#troubleshooting

Sure. I can send a PR. Out of the two, which one do you think is more appropriate ?

I'd go for this one I think - seems focused?

xcrun simctl spawn booted log config --mode "level:off"  --subsystem com.apple.CoreTelephony
Source: [stackoverflow.com/questions/52455652/xcode-10-seems-to-break-com-apple-commcenter-coretelephony-xpc](https://stackoverflow.com/questions/52455652/xcode-10-seems-to-break-com-apple-commcenter-coretelephony-xpc)

It simply disables logging for the CoreTelephony framework.


As a user I want to be able to have an audit log of what happened to my data

I am interested in knowing when a specific pieced of data has been changed, by whom/what.
I also want to be able to visualize the changes if possible

This can also be enabled by #22.
If we have event streams, then building filterable audit view on top of those would be straightforward.

This can also be enabled by #22.
If we have event streams, then building filterable audit view on top of those would be straightforward.

Added to readme

Opening this as part of moving all user stories into issues again.


[💡 FEATURE REQUEST]: HTTP Middleware - Dynamic CORS origin support

Plugin
HTTP Middleware (any)
I have an idea!
Affected middleware: HTTP
The only thing that prevents us from completely getting rid of our NGINX is CORS support for wildcard subdomains.
The HTTP middleware currently only supports returning static values for the CORS headers.
Use case
We have a PHP API, this API is used by multiple sites that run on the same main domain.
Example
The API is running under api.example.com. We have example.com, cockpit.example.com, admin.example.com and various other sites that all call api.example.com via JavaScript in the browser. Thus, all these hostnames must be allowed as CORS origin.
This also applies to our staging & development environment, which run on the same main domain but under a separate subdomain. E.g. api.dev.example.com, dev.example.com, cockpit.dev.example.com & admin.dev.example.com.
Due to the large volume of hosts and differences between the environments, we decided to use a Regex pattern that allows the main domain, as well as all subdomains below it. This saves us the complexity of having to maintain a separate list of allowed hosts for every environment.
To accomplish this, we use the following NGINX config:
# Allow example.com and all example.com subdomains and sub-subdomains
map $http_origin $allow_origin {
    ~^https://(.*\.)+example.com(:\d+)?$ $http_origin;
    https://example.com https://example.com;
    default "";
}

more_set_headers "Access-Control-Allow-Origin: $allow_origin";

Feature request
HTTP Middleware support that allows us to return the requesting host as allowed_origin value if it is one of these:

example.com
Subdomain of example.com
Sub-subdomain of example.com.
etc..

Possible implementation ideas

Regex support. Similar to the NGINX config above. Probably the most flexible?
Wildcard config. Something like allowed_origin_wildcard: '*.example.com'
Definition of the main domain, allowing it and all hosts below it: allowed_origin_root: 'example.com'
...

Config ideas
Either create a new separate key for the matching-config. Or a new matching-type config.
For example:

allowed_origin || allowed_origin_wildcard

Probably more complicated because there would have to be a order of precedence?

allowed_origin && allowed_origin_type=['simple' || 'regex']

Hey @orlandothoeny 👋🏻
Oh, this is super detailed feature request, good job 👍🏻 ❤
The currently available allowed_origin option supports basic wildcards, such as: *.example.com. Is this something that can help you? Until I implement a more advanced version with regexp.

Hi @rustatian,
Thanks for the quick reply :)
I just saw that the middleware uses https://github.com/rs/cors, I'll have to try that out. In the test-cases I only found one with a simple subdomain, no nested ones: https://github.com/rs/cors/blob/20a76bd635d3c8a7ea58f49fad54b8eecb95aa46/cors_test.go#L116 Maybe it just works. Then nothing would have to change to be able to accomplish this. Except maybe to add this to the docs to prevent future issues.

I don't know Go, but just by looking at the code I think that should work. I don't see any special subdomain logic. I think it's just a simple wildcard. So something like allowed_origin: https://*.example.com should work

https://github.com/rs/cors/blob/20a76bd635d3c8a7ea58f49fad54b8eecb95aa46/cors.go#L179C13-L179C13
https://github.com/rs/cors/blob/20a76bd635d3c8a7ea58f49fad54b8eecb95aa46/cors.go#L470C11-L470C11
https://github.com/rs/cors/blob/20a76bd635d3c8a7ea58f49fad54b8eecb95aa46/utils.go#L15

Just realized that that wouldn't allow https://example.com. And using allowed_origin: https://*example.com would also permit requests from https://i-am-an-evil-hackerman-example.com

Oh yeah, you're right. Looks like regex pattern matching would be best here. Since I'm able to provide my implementation for the allow logic, it would be possible to use regexp here.
I'll put this FR to the next release, v2023.4 (or v2024). It would be available much sooner as a beta release.


Update Sponsor Section

Tweaked interested in sponsoring section, added new sponsors, reformatted sponsor logo sizes

Changes are done and can be seen on dev.makeuc.io to test


Stuck on "LORAWAN STARTING"

Hello,
I tried the program setting devEui/appEui/appKey, and in the platform.ini i use the same config as with the jas-williams sketch :
build_flags = -Wl,-Map,output.map monitor_speed = 115200 board_build.arduino.lorawan.region = EU868 ;board_build.arduino.lorawan.region = US915 board_build.arduino.lorawan.class = CLASS_A board_build.arduino.lorawan.netmode = OTAA board_build.arduino.lorawan.adr = ON board_build.arduino.lorawan.uplinkmode = UNCONFIRMED board_build.arduino.lorawan.net_reserve = OFF board_build.arduino.lorawan.rgb = ACTIVE board_build.arduino.lorawan.debug_level = NONE ; debug_level can be NONE, FREQ, FREQ_AND_DIO board_build.arduino.lorawan.at_support = OFF board_build.arduino.lorawan.preamble_length = 8
But i'm always stuck on the "LORAWAN STARTING" screen at startup. Enabling the DEBUG flag i only see these :
`AT Rev 1.3
+AutoLPM=1
+LORAWAN=1
+KeepNet=0
+OTAA=1
+Class=A
+ADR=1
+IsTxConfirmed=0
+AppPort=2
+DutyCycle=1000
+ConfirmedNbTrials=4
+ChMask=00000000000000000000FF00
+DevEui=6081F9D53XXXXXXXX(For OTAA Mode)
+AppEui=6081F968AXXXXXXX(For OTAA Mode)
+AppKey=996CC5E5EF5C65D948DECD310BXXXXXX(For OTAA Mode)
+NwkSKey=00000000000000000000000000000000(For ABP Mode)
+AppSKey=00000000000000000000000000000000(For ABP Mode)
+DevAddr=00000000(For ABP Mode)
LoRaWAN EU868 Class A start!
GPS Current baudrate detecting...
GPS Current baudrate detected:19200
GPS baudrate updating to 115200`
The jas-williams sketch works well on my board (except the GPS fix which is veeeerrrry long), and the only difference i noticed on the lorawan part is the userChannelsMask. But replacing it changed nothing :(
Do you have any idea of what i could investigate ? For reference, i'm in Bordeaux, France

Hi, thank you very much for fixing it so quickly ! I can confirm everything is working now


default parameters to reproduce all the dataset mentioned in the paper

@hsfzxjy Can you provide the parameters to reproduce the results in different datasets, such as market1501, CUHK03, etc. ? Thanks!

You could use the command mentioned in our training guide, with -s and -t substituded to corresponding dataset name. Market-1501, DukeMTMC-ReID and MSMT17 share the same training hyper-parameters. As of CUHK03, we are still doing the experiments, and will publish details in external journal work.

@hsfzxjy I use the command in the [https://github.com/TAMU-VITA/ABD-Net/blob/master/README_Training_and_Testing_Guides.md](training guide)
srun --mpi=pmi2 -p VI_UC_1080TI --gres=gpu:2  -u python train.py -s market1501 -t market1501 \     --flip-eval --eval-freq 10 \     --label-smooth \     --criterion htri \     --lambda-htri 0.1  \     --data-augment crop,random-erase \     --margin 1.2 \     --train-batch-size 48 \     --height 384 \     --width 128 \     --optim adam \     --lr 0.0003 \     --stepsize 20 40 \     --gpu-devices 0,1 \     --max-epoch 80 \     --save-dir log \     --arch resnet50 \     --use-of \     --abd-dan cam pam \     --abd-np 2 \     --shallow-cam \     --use-ow
But after training, the performance is poor:
`
Model size: 69.175 M
Loaded pretrained weights from 'log/checkpoint_ep80.pth.tar'
Evaluate only
Evaluating market1501 ...
Using Flip Eval
Extracted features for query set, obtained 3368-by-3072 matrix
Extracted features for gallery set, obtained 15913-by-3072 matrix
==> BatchTime(s)/BatchSize(img): 0.190/100
Computing CMC and mAP
Results ----------
mAP: 72.77%
CMC curve
Rank-1  : 88.15%
Rank-5  : 95.01%
Rank-10 : 96.56%
Rank-20 : 97.71%
`

You could use the command mentioned in our training guide, with -s and -t substituded to corresponding dataset name. Market-1501, DukeMTMC-ReID and MSMT17 share the same training hyper-parameters. As of CUHK03, we are still doing the experiments, and will publish details in external journal work.


Failed to use swiftc to compile swift code with import foundation.

Description

I have follwed the steps from this doc and run hello on android.  But when I want to use swiftc to compile a swift within import foundation. Errors will occurr.
date.swift:1:8  error: no such module 'Foundation'
import Foundation
Steps to reproduce

date.swift:
import Foundation
print("hello")
let time = Date()
print(time)
Expected behavior

I directly run this date.swift on x86_64. It can run successfully.
But when I use swiftc  to compile it into a exec file on android. it cannot.
So how can I compile it successfully? Should I add some parameters on utils or swiftc? Please help me.

Environment

Swift compiler version info
Xcode version info
Deployment target:

cc @buttaface

The official docs currently only show building and using the stdlib, not Foundation. Try out my Android SDK, that gives you Foundation and allows you to use the package manager too.

Closing, since the doc has never supported cross-compiling Foundation for Android, but once more patches get in, I will update this doc one day to show that too.


fast mode time out

fast mode should automatically disable itself after some specified amount of time. Otherwise too easy to leave it on and knacker the switch.

but, make sure that people understand in the docs that they shouldn't be using fast mode much anyway


Check if expanding instructions in step 3 can be replaced by clicking the "expand all" button

There's an "expand all" button just on the left of the header row. Is this is achieving the same as what you're doing with code?
This might be simplified telling the user to click on that button.

That button doesn't load every information, you would need to go slowly thru the page for the lazyload to catch on (I did try that button first when I started).

Isn't that already the case? You specify:

After everything is loaded/open

Just trying to see if this can be directly copy/pasted at the beginning of the main block of code, to have less manual steps.

No, because using the button only expans the boxes but don't load them. You need to force the load of the lazyload elements thus the need for that step (and the same to expand teams).

Ok, so is there a way to automatically proceed when all the fields required are loaded? So that the 2 expand sub-steps and the export code can be copy/pasted all at once?

Would be need to check if all the POST requests have been answered successfully (never had to use/search for this). Would probably need to add some listeners somewhere, but like I said, never had to do anything similar to that (specially with code that I don't "control") so don't know where to start

I've never coded in javascript more than an « hello world », so that would need a web person.

Will close this issue and also give a quick lock if this is a trivial thing to implement (I'm assuming it's not).

Keeping the issue open would allow other people to notice help is needed. I recommend you to let the bugs open and use a triaging tag, like help-wanted.

Sure that's code with a single month of expected lifespan, but the smoother the process is, the better. People with a very big history but not fluent with technology could will benefit from a process as simple as possible.

I think the options here might be:

Overriding their ToggleHistoryItemExpansion (executed when expanding/collapsing) function so that you can keep track of the items being finished.
Using setTimeout to check if they're all expanded every X amount of time. You could check if the number of .EventSummary existing matches the count of a.Expand.

Sidenote: DisplayTeamOpponents looks like it's just hiding/showing content, rather than fetching data via AJAX, so it might not be necessary to actually expand that?

I don't have any of those in my historic so I can't confirm it, assumed it was the case. Until confirmation I think it's best to keep it that way. If you have those events and can confirm, that step can be removed.

Good suggestion for the intervals, will see if can do something quick for that because I'm kind short of time available.


[webpack2] loader modules resolved only from root

If I have config:
module: {
  loaders: [
    {test: /\.css$/, loader: 'style!css'}
  ]
},
resolve: {
  modules: ['node_modules', __dirname + '/client/node_modules'],
  moduleExtensions: ["-loader"],
}

if install style-loader into /client/node_modules It will not find it, and have to install it to /node_modules. Though resolution from  /client/node_modules works inside  app's code.

resolveLoader: {
  modules: ['node_modules', __dirname + '/client/node_modules'],
}

@sokra so it is a bug, or it is supposed to work this way? I thought new resolve goes for all.

@whitecolor according to sokra's answer it seems to be resolveLoader instead of resolve

Well it is not completely clear.

It's working as intented. resolving should be separate for loaders (part of the build process) and modules (part of the runtime code)

resolving should be separate for loaders

agree

So this might be closed?

I'm getting this error in RSB:
Module build failed: (SystemJS) Error: ENOENT: no such file or directory, open 'C:\Projects\react-static-boilerplate\C:\Projects\react-static-boilerplate\node_modules\css-loader\index.js'
	    at Error (native)
	Error loading C:/Projects/react-static-boilerplate/C:\Projects\react-static-boilerplate\node_modules\css-loader\index.js
 @ ./pages/error/styles.css 4:14-236 13:2-17:4 14:20-242

@sokra "TypeError: Cannot read property 'default' of undefined\n    at C:\Projects\react-static-boilerplate\node_modules\loader-runner\lib\loadLoader.js:4:26"

@sokra loader.path contains a full path to the loader. If I change it to a relative path, the error disappears. What's the best way to resolve this issue?

@sokra if I change loader.path from absolute to a relative path, it loads css-loader/index.js but then throws an exception when you require stuff like require('./lib/loader'), require('path') etc.

@sokra The issue above seems like the biggest one I've encountered and has broken my build all week. I stepped through to no avail. Have you npm uped lately?

The code to reproduce the issue is here:
https://github.com/kriasoft/react-static-boilerplate/tree/webpack2
Rref kriasoft/react-static-boilerplate#102

I'm encountering the same issue as @koistya with Webpack 2 on Windows only. It seems to only be occurring (right now) with the HtmlWebpackPlugin
    ERROR in ./~/html-webpack-plugin/lib/loader.js!./src/index.html
    Module build failed: (SystemJS) ENOENT: no such file or directory, open 'C:\Users\matthewshwery\experiments\C:\Users\matthewshwery\experiments\node_modules\html-webpack-plugin\lib\loader.js'
        Error: ENOENT: no such file or directory, open 'C:\Users\matthewshwery\experiments\C:\Users\matthewshwery\rexperiments\node_modules\html-webpack-plugin\lib\loader.js'
            at Error (native)
        Error loading C:/Users/matthewshwery/experiments/C:\Users\matthewshwery\experiments\node_modules\html-webpack-plugin\lib\loader.js

@koistya the code requires postcss-import, which requires postcss-import\lib\resolve-id -> pkg-resolve -> jspm\api -> systemjs-builder -> systemjs
the systemjs package adds a global System which is used then by webpack -> loader-runner to load loaders.
dependency hell :smile:
Not sure who to blame:

pkg-resolve because it depends on jspm.
systemjs because it registers a global System (may be hidden behind a systemjs/register).
loader-runner because it uses System.import.

@sokra thanks for copying me in. I'm not completely sure I follow the details, but perhaps you can ensure that the System global is overridden before using the loader-runner? SystemJS originally didn't override System if it didn't already exist, but we had to add override behaviour because Traceur was overriding the global System. Unfortunately we've passed this virus on :)

Is this relevant still?

@bebraw It's still relevant, I came across this issue with webpack 2.2.0-rc.7. I use systemjs and systemjs-builder modules together with webpack in scope of one node.exe process. Here's the output of failed webpack bundles:
Module build failed: (SystemJS) ENOENT: no such file or directory, open 'd:\\<local_path>\\d:\\<local_path>\\node_modules\\babel-loader\\lib\\index.js'
    Error: ENOENT: no such file or directory, open 'd:\\<local_path>\\d:\\<local_path>\\node_modules\\babel-loader\\lib\\index.js'
        at Error (native)
   Error loading d:/<local_path>/d:\\<local_path>\\node_modules\\babel-loader\\lib\\index.js

I've tried to get rid of systemjs dependencies and webpack works properly for me. As a temporary solution I've removed global variable System:
delete global.System;

SystemJS Builder doesn't use that global variable, so it looks like it doesn't affect it, anyway I've not caught any issues.
@whitecolor Does it make sense to reopen it?

I'm not sure, but I will reopen to be checked or commented.

It is very much relevant.
It is totally broken.

@sergei-startsev
I had the same issue with "d:/<local_path>/d:\<local_path>\node_modules\babel-loader\lib\index.js"
(not for babel-loader but the webpack-html-loader)
I was able to solve it by doing the following :

In my %temp%, delete all the npm-* folders  (I removed all the file from %temp% to be precise)
then npm cache clean
then delete node_modules from my project
npm install

Problem solved. It seems that the npm-** folder in my %tmp% was the problem. I have not investigate further but I supposed files were corrupted..

@sokra

resolving should be separate for loaders (part of the build process) and modules (part of the runtime code)

This prevents creating a separate module where one would organize the build logic and reuse it across several modules. Is there any chance of changing this behaviour?

This prevents creating a separate module where one would organize the build logic and reuse it across several modules. Is there any chance of changing this behaviour?

In what way is it prevented?

@whitecolor
If someone creates a module with build related logic such as bundle creation among others then the dependencies necessary for the bundling will be specified at this module. Then, if this module for some reason is used as local dependency then it's dependencies will not appear in the node_modules folder of the 'host' module: it will be under host_module/node_modules/build_module/node_modules. Since loader resolution works only in the root module, it will not find the necessary loaders because they are not there. I don't know npm well enough to know in which other cases it doesn't flatten the dependencies, which causes the problem here.

@Katona I don't really get the case =) But anyway you can add all needed node_module folders to resolve.modules and resolveLoader.modules.

@whitecolor
Ah, sorry for that :) Then, without going into the details let's accept that resolving from the root module doesn't always work, there can be valid use cases when it's not. However, the standard module resolution of node.js works, is there any reason of webpack not using it?

@Katona So I believe it is to allow more controlled and flexible resolution strategies.
There is a module that webpack uses to resolve https://github.com/webpack/enhanced-resolve


Video doesn't work, only audio works.

Only a blank screen with audio. Video is not showing.
Code
import 'package:y_player/y_player.dart';

class YoutubePlayerWidget extends StatefulWidget {
  const YoutubePlayerWidget({super.key, required this.videoUrl, this.thumbnailUrl});

  final String videoUrl;
  final String? thumbnailUrl;

  @override
  State<YoutubePlayerWidget> createState() => _YoutubePlayerWidgetState();
}

class _YoutubePlayerWidgetState extends State<YoutubePlayerWidget> {
  @override
  Widget build(BuildContext context) {
    return YPlayer(
      youtubeUrl: 'https://www.youtube.com/watch?v=dQw4w9WgXcQ',
      onStateChanged: (status) {
        debugPrint('Player Status: $status');
      },
      onProgressChanged: (position, duration) {
        debugPrint('Progress: ${position.inSeconds}/${duration.inSeconds}');
      },
      onControllerReady: (controller) {
        debugPrint('Controller is ready!');
      },
    );
  }
}

Flutter Doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.24.1, on macOS 13.6 22G120 darwin-arm64, locale
en-BD)
[✓] Android toolchain - develop for Android devices (Android SDK version
32.1.0-rc1)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2024.1)
[✓] Android Studio (version 2022.1)
[✓] VS Code (version 1.92.2)
[✓] Connected device (5 available)
[✓] Network resources
Preview

Do you using latest version ? y_player: ^2.0.1

Yes, I am using the latest version 2.0.1.

I just tested the video you provided in the description.
https://www.youtube.com/watch?v=dQw4w9WgXcQ

I think this issue related to impeller on android. Also it will not work in emulators.

Try after disabling impeller on android
<meta-data          android:name="io.flutter.embedding.android.EnableImpeller"          android:value="false" />
Try real device to debug


create-model

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

175 of 185 (94.59%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.8%) to 99.213%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/hook/create-model.ts
129
139
92.81%

Totals

Change from base Build<PHONE_NUMBER>:
-0.8%

Covered Lines:
1511

Relevant Lines:
1521

💛  - Coveralls


Retext Simplified Documentation

Simplifies documentation language based on retext-mapbox-standard.
There are still several things that don't pass linter muster, but they're key terms for the product (namely "prioritize").

Very cool.

@rmglennon so this has your seal of approval?

@riordan - these are look fine. There was one about authoritative sources, but it still had the same meaning. (and can you show me how to run this on all our repos?)

Yeah, I couldn't figure out how to rewrite that one error effectively. :disappointed:
And absolutely.


fix(material/form-field): failing color contrast text to bg color ratio

Removes :hover and .mat-focused opacity changes to .form-field-focus-overlay
which was causing a low color contrast ratio between the text and form-field input
background fill color.

Googlers: see [internal discussion] (b/186036229)

Does this affect only "fill" appearance? or does it affect "outline" appearance to?
I added dev-app-preview tag, so that automation will deploy a test site of this PR.

Does this affect only "fill" appearance? or does it affect "outline" appearance to?
I added dev-app-preview tag, so that automation will deploy a test site of this PR.

Just the fill color I believe. The "outline" color change is still visible on focus:
Before:

Current:

Here are some screenshots comparing the perceived original colors failing as well as the updated perceived colors passing.

when will this be merged? I now have to overwrite the css variable --mat-form-field-focus-state-layer-opacity manually and set it to 0. This seems to work, however locally I saw it happen that the opacity is set by the private _form-field-focus-overlay.scss file and then the css variable does not work ...

Hello @simSmulders ,
Thank you for reaching out and letting us know that you're affected.
Our process requires the google-internal-tests check to pass before we can merge this. Since many components use form field, this affects a relatively large surface area. It could take some time.
This issue is actively being worked on, and I think it will land within the next week.
Best Regards,
Zach


fail2ban is not creating the iptables firewall chains

Issue description
When using iptables, fail2ban works by adding chains into which it inserts rules. According to the configuration (ex. /etc/fail2ban/action.d/iptables.conf) fail2ban should be creating chains with the prefix "f2b"
These chains are not being created, so although fail2ban is logging IPs those IPs are not being blocked.
How to reproduce
To reproduce, add services.fail2ban.enable = true; to configuration.nix, do the nixos-rebuild dance, and check your firewall chains with iptables -L.
Technical details

system: "x86_64-linux"
host os: Linux 4.14.43, NixOS, 18.09pre140920.5b468ea6b1d (Jellyfish)
multi-user?: yes
sandbox: no
version: nix-env (Nix) 2.0.2
channels(root): "nixos-18.09pre140920.5b468ea6b1d"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

I am observing the same problem. Could it be that the iptables command in /etc/fail2ban/action.d/iptables.conf need to be replaced by absolute paths?

Here's what I've learned. Unlike older versions of fail2ban which created the chains on startup, modern fail2ban it creates the chains on-demand. Right now I have the full path to iptables in the config, but once the SSH ban lifts and I can get back into my VM I'll try locking myself out again without the full path.
While the ssh filter is working quite well the nginx filter is not.

Yep, the chains are on-demand now. Closing.


Mojibake on Spell Cards names in TH08 Spell Practice

For some reason, thcrap seems to not recognize special characters in Spell Cards names into Spell Practice menu, and replaces any kind of non-ASCII characters with mojibake (As illustrated below).

Details:

Used language patch: pt-br
Used thcrap version: build by myself on 26/05/2021
Log files:
thcrap_log.txt
thcrap_log.1.txt
thcrap_log.2.txt
thcrap_log.3.txt

Reply to me if you need more information.

Things like this often happen when a string contains both UTF-8 and shift-jis (this usually happens when we have a mix of something from thcrap, in UTF-8, and something from the game, in shift-jis). The part "Futuro [...]" obviously comes from thcrap, and I would guess that "No. 194    " comes from the game and contains a shift-jis chatacter. I would also guess that lang_en replaces this with a non-shift-jis version, which explains why all the languages that depend on lang_en didn't notice but you did (lang_pt-br doesn't depend on lang_en).
I'm looking at it for more details.

 For some reason I thought this was the music room.

which explains why all the languages that depend on lang_en didn't notice but you did
Nvm, even languages that depend on lang_en have this problem.

Fixed in base_tsa. You will get the fix the next time you run the game.


why on IE not working?

Why this autocomplete not working on Internet Explorer.
i get this error:

Unable to get property 'empty' of undefined or null reference

the error in this code

this.queryResultArea.empty().append(h)

i think, the empty() method is undefined.
i test this with IE 10 on windows 8.
i don't know this error is showing on earliest IE or not.
please fix this error.

I see an error Object doesn't support this action after page load.
Relevant code:
@_element.dispatchEvent new Event('input')

Will investigate further and attempt to fix.
Pull requests are welcome.

i has been resolve this error and work on my IE, i don't test on IE earliest.
i will fork now.

ehm, i get this error too in ie11..
can you please tell us what you did to fix this error?

See my comment about a polyfill here

@cmckni3 Should we perhaps add some documentation on getting immybox running in IE?

Yeah that would be a good idea.
I think we should add the polyfill to do the demo so it works on IE as well.

awesome. with that polyfill immybox works for me in ie11
thanks a lot!

Glad to help @timotheus0106

Documentation added and polyfill added to demo.


Fixes for mobile usability issues

:warning: WIP

Increase mobile/tablet font-size

Ensures the minimum font-size of paragraphs will be 16px, which by all indications is what Google checks for when testing if text is too small to read.

Add bottom margin to list items

We are seeing a 'clickable items too close together' usability issue; we think this may be from where we have lists of links. Adding a small bottom-margin to the list items should hopefully improve their usability.

List items (padding under bullets) looks fine to me @ethax-ross
Font size increase on mobile/tablet - definitely feels easier to read for me on my iPhone :-D
However, I think we might need to do a couple of other tweaks - for example, the column headings on the Funding table now wrap on an iPhone 11 (should we address via content or dev?)
Is there an easy way to identify other issues like this?
cc'ing @gazcarr for info


Consider setting up automatical archiving of your source code to Zenodo

There's a guideline here

@willu47 the instructions only work if it's a repo I hold under my personal github, now that ownership is transferred to the CCG organisation I can't toggle on the automatical achiving - thoughts?

e.g.:


[WonderCMS 3.0.0 beta] Notice in plugin/theme install/update script makes redirection fail

When php notices are enabled, after installing a plugin/theme the redirection fails if gzip is disabled:
Notice: Only variables should be passed by reference in /var/www/html/index.php on line 947
Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/index.php:947) in /var/www/html/index.php on line 1322

Possible solution:
947c1,2
< $folderName = array_pop(explode('/', str_replace('/archive/master.zip', '', $url)));
---
> $folders = explode('/', str_replace('/archive/master.zip', '', $url));
> $folderName = array_pop($folders);

Nice catch @StephanStanisic 👏
I'll include this fix and run it for a test

Fix merged with latest update.
Thanks for another awesome fix @StephanStanisic!
Closing issue.


Is there any plan to rewrite redux-saga using async-await?

Not a big fan of generator, async-await seems more straight-forward and with a less steep learning curve.
By the way, Koa used to use generator, now their new api adopt async-await, and looks 100 times cooler imo.

redux-saga cannot be rewritten to async/await - that uses Promises and its way harder to coordinate 'parallel' tasks with those. It would also mean a big change in semantics, how things actually work. In example select effect is synchronous - cant achieve that with Promises.
Saga being an interpreter of effects is granting us the full control of how and when those effects are resolved + effects are just simple object which are easily comparable and can be monitored which is also way harder with Promises.

I definitely understand why async/await doesn't integrate with redux saga. But I have some thoughts on why it may be a steep learning curve vs async/await.
Async await doesn't really require any configuration, and can be used in any JS code. It's as simple as having a function marked async and awaiting a promise. Super easy! Additionally, many JS devs are reasonably comfortable with Promises because they are used everywhere. I have an understanding of them based on day-to-day use with many libraries, and async/await just makes using promises way easier. Generators really aren't that common, so it's not a tool many are familiar with. I don't understand them that well myself, even though I'm comfortable with redux-saga.
I think the other part of it is that people aren't just learning the API to redux-saga, but they also have to do a lot of configuration and integration with redux to use it.
For instance, here is a little function using a generator:
export function * getData () {
  try {
    const data = yield call(databaseFunc, /* parameter is passed using uncommon syntax */)
    yield put({type: 'NEW_DATA', data})
  } catch(e) {
    console.error(e)
  }
}

That's easy to understand! The hard part to understand is that this generator has to be forked from another saga, for instance triggered by a redux action. All that configuration and the forking model isn't common knowledge and requires practice and learning to understand. (not saying that's bad)
Here's what that function looks like with async await. You're right, the syntax looks really similar to redux-saga, but it feels a lot more like the JS we use on a day-to-day basis.
async function getData () {
  try {
    const data = await databaseFunc(/* I could pass parameters using normal function syntax here */)
    // get dispatch somewhere, maybe through a component and pass it to this function
  } catch(e) {
    console.error(e)
  }
}

async/await is syntax that people may be aware of from other languages (e.g. C#)
Everything works like "plain" js except "awaiting" functions
I can call that function directly anywhere in my app right away without setting anything up

I think that's why redux-saga has a higher learning curve than plain promises and async/await. It's a new API that's not quite anything developers have worked with before (yielding, using effects, forking, a lot of new terms to understand). Whereas async/await is just two keywords that help you use promises in a cleaner way. Not really much extra to understand or configure.
that said, I really love redux-saga and all the power it gives. I think it's certainly worth the learning-curve in many cases, but I figured I would try to outline the ways in which I think it's hard for new users.
Realizing this issue was closed a year ago, I should probably get back to fixing the bug I was looking for in the first place :P cheers

Here's a way to use async await inside a generator function. stackoverflow

@ntomallen thanks for the nice feedback, we understand the steep learning curve of redux-saga - but as said before - we just can't use anything other than generators to reach our goals, because only them are giving us the needed flexibility
and as u have noticed, you don't even need to understand generators (although I encourage people to get deeper understanding) to get proficient with the redux-saga

@Andarist node 10 has support for async generator functions, meaning we can now use both async/await and yield inside the same function, however it appears that take/takeLatest/et all do not correctly dispatch to async generators. I was wondering if there's something fundamental preventing this? It would be nice to be able to choose between the two approaches on a case-by-case basis, especially when using TypeScript, since async/await allows for type safety while yield does not.

Support for async generator functions, meaning we can now use both await and yield inside the same function, however it appears that take/takeLatest/et al do not correctly dispatch to async generators.

@Andarist I also ran into this today. I tried to yield put(action) and my actions were silently swallowed by redux-saga. Could AsyncIterables be supported, and if they can't be could we at least give some kind of error message instead of silently failing later on?

There should be a warning about using such - https://github.com/redux-saga/redux-saga/blob/8f60bcb27b088b4785bbd106eaf6cded13d99562/packages/core/src/internal/proc.js#L13


xcursor: add xorg-x11 and cursors path to XCURSORPATH

This should match default XCURSORPATH, which is used by libwayland-cursor
and other xcursor loading libraries more closely.

libwayland code: https://gitlab.freedesktop.org/wayland/wayland/-/blob/5d201df72f3d4f4cb8b8f75f980169b03507da38/cursor/xcursor.c#L620


Feature/lp vdtdrprod

Adjusting files for PDS/LE VD TDR production

All fhicls are running ok locally so I will approve this merge.


PredictDB 1KG Data Availability

Dear PrediXcan Team,
I am trying to access the GTEx V6p 1000 genomes prediction databases from PredictDB. Whenever I try to download any of the .db or text files, I get an XML page with an error that says "access denied". Do you know what could be preventing me from accessing this data? Thank you in advance for your time! I can provide additional details if necessary.
Best Regards,
Zane

We are updating the 1000 Genomes based models using covariance values
computed in the training set. This will avoid many issues with SNPs not
used in the models.
Please bare with us while we upload the new models. We expect the update to
be done by the end of this week.
Haky
On Mon, Nov 14, 2016 at 2:22 PM, zgoodwin<EMAIL_ADDRESS>wrote:

Dear PrediXcan Team,
I am trying to access the GTEx V6p 1000 genomes prediction databases from
PredictDB. Whenever I try to download any of the .db or text files, I get
an XML page with an error that says "access denied". Do you know what could
be preventing me from accessing this data? Thank you in advance for your
time! I can provide additional details if necessary.
Best Regards,
Zane
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hakyimlab/PrediXcan/issues/26, or mute the thread
https://github.com/notifications/unsubscribe-auth/AC2ouSTlycWKcyVfo6MwWlRXTWeDXnmLks5q-MLygaJpZM4Kxw9F
.

Thanks for the rapid reply! I'll go ahead and close the issue.
-Zane