WIP: Adding support for block volumes

Signed-off-by: Amarnath Valluri<EMAIL_ADDRESS>

should we also revert effect of #362 which added refusal all block volume requests

should we also revert effect of #362 which added refusal all block volume requests

Thanks, @okartau. Good point, I reverted the change, let's see if it breaks andy tests

What about deployment examples, should we show provisioning of a block volume ?
Also, should we describe block volume support in README ?

What about deployment examples, should we show provisioning of a block volume ?

I added an example app and PVC part of this change. Do you think need more?

Also, should we describe block volume support in README ?

Yes, I guess we should mention this in ReadMe, I will do that.

Also, should we describe block volume support in README ?

Yes, I guess we should mention this in ReadMe, I will do that.

Updated ReadMe with Block volume usage, @okartau  Can you check if it is clear enough.

@pohly Can you give review comments.

Needs to be rebased...

Do we already have tests (e.g. from Kubernetes or csi-test) which cover block volumes?

while working with #365 I noticed that if we dont respond NOT_SUPPORTED for block volume mode, and we enable VolumeMode suite, then some (just few) more tests are executed.
I guess these may be about block volumes. Needs to be clarified more.

Olev Kartau<EMAIL_ADDRESS>writes:

Do we already have tests (e.g. from Kubernetes or csi-test) which cover block volumes?

while working with #365 I noticed that if we dont respond
NOT_SUPPORTED for block volume mode, and we enable VolumeMode suite,
then some (just few) more tests are executed.  I guess these may be
about block volumes.

Can we pull that into this PR?

Looks like tests are failing?
https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/blue/organizations/jenkins/pmem-csi/detail/PR-380/11/pipeline
[Fail] PMEM Volumes [Driver: pmem-csi] [Testpattern: Dynamic PV (block volmode)] volumeMode [It] should create sc, pod, pv, and pvc, read/write to the pv, and delete all created resources

/go/src/github.com/intel/pmem-csi/vendor/k8s.io/kubernetes/test/e2e/storage/testsuites/volumemode.go:282

[Panic!] PMEM Volumes [Driver: pmem-csi] [Testpattern: Dynamic PV (filesystem volmode)] volumeMode [It] should create sc, pod, pv, and pvc, read/write to the pv, and delete all created resources

/go/src/runtime/panic.go:82

The second one is a timeout.

log shows tester tries to run local kubectl, seems some commits from #365 were left out that work around local kubectl?
For some reason I dont see error "kubectl not found on PATH", have we started installing kubectl on tester host? If not, attempt to use local kubectl may be part of problem here.

Looks like tests are failing?
https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/blue/organizations/jenkins/pmem-csi/detail/PR-380/11/pipeline
[Fail] PMEM Volumes [Driver: pmem-csi] [Testpattern: Dynamic PV (block volmode)] volumeMode [It] should create sc, pod, pv, and pvc, read/write to the pv, and delete all created resources

/go/src/github.com/intel/pmem-csi/vendor/k8s.io/kubernetes/test/e2e/storage/testsuites/volumemode.go:282

[Panic!] PMEM Volumes [Driver: pmem-csi] [Testpattern: Dynamic PV (filesystem volmode)] volumeMode [It] should create sc, pod, pv, and pvc, read/write to the pv, and delete all created resources

/go/src/runtime/panic.go:82

The second one is a timeout.

The other failure was also timeout, while creating a Pod:
Sep 26 09:10:22.329 FAIL: Unexpected error:
    <*errors.errorString | 0xc0008aa0c0>: {
        s: "pod \"security-context-c5352c9b-e03c-11e9-99ce-0242ac110002\" is not Running: timed out waiting for the condition",
    }
    pod "security-context-c5352c9b-e03c-11e9-99ce-0242ac110002" is not Running: timed out waiting for the condition
occurred
github.com/intel/pmem-csi/vendor/k8s.io/kubernetes/test/e2e/storage/testsuites.(*volumeModeTestSuite).defineTests.func6()
	/go/src/github.com/intel/pmem-csi/vendor/k8s.io/kubernetes/test/e2e/storage/testsuites/volumemode.go:282 +0xbe8
github.com/intel/pmem-csi/test/e2e.RunE2ETests(0xc0003eb000)
	/go/src/github.com/intel/pmem-csi/test/e2e/e2e.go:150 +0xa4
github.com/intel/pmem-csi/test/e2e.TestE2E(0xc0003eb000)
	/go/src/github.com/intel/pmem-csi/test/e2e/e2e_test.go:53 +0x2b
testing.tRunner(0xc0003eb000, 0x1ad4dd8)
	/go/src/testing/testing.go:865 +0xc0
created by testing.(*T).Run
	/go/src/testing/testing.go:916 +0x35a

In driver logs we don't have good explanation why pod is not created.
From Volume POV, I see VolumeCreation with mode=block, but there is no PublishVolume for that VolumeID (and I think Stage should not happen for mode=block volumes?).
I suspect the way tester code creates this pod, is different from how other pods are created in other testing. VolumeMode test code uses CreateSecPodWithNodeName to create a pod: is this different from other testing we use? What is this "SELinuxLabel" security context involved?

I added debug trace in pv_util.go CreateSecPodWithNodeName() printing all args to MakeSecPod, and it appears this is called twice with almost same args (as per calling code in volumemode.go).
The only difference seems to be in pvclaims: in 1st call VolumeMode=*Filesystem, this succeeds.
2nd call will have VolumeMode=*Block, this fails after 5-minute timeout.

I think the error is the one from kubelet emitted close to pod creation failure point:
kubelet pmem-csi-clear-govm-worker2} FailedMapVolume: MapVolume.SetUp failed for volume "pvc-150511aa-e10b-11e9-b34d-0242ac110002" : volumeattachments.storage.k8s.io "csi-2bc0683aaf417707b935a60597d8945cce77abb97a08d8d816addd01b613e70b" is forbidden: User "system:node:pmem-csi-clear-govm-worker2" cannot get resource "volumeattachments" in API group "storage.k8s.io" at the cluster scope: no relationship found between node "pmem-csi-clear-govm-worker2" and this object.
This gives a hint it is a rights/permissions issue.
Search for other discussion by error text leads to
https://github.com/rancher/k3s/issues/732
where a work-around was proposed via adding some rights like this:
rules:
- apiGroups:
  - storage.k8s.io
  resources:
  - volumeattachments
  verbs:
  - create
  - watch

Also, it is mentioned that this gets fixed by migration to k8s 1.15 (our CI still runs 1.14, also my trials on stand-alone cluster).
I will re-try in another stand-alone cluster running 1.15, to verify this "fixed in 1.15" claim.
Note that pointed discussion does not touch the aspect why this is related to Block mode

confirmed, Block-mode volume creation and publish works in 1.16 cluster (govm-ubuntu cluster with 4xVM).
There are other errors in test suite, but bock volume test does work.

@pohly  Is it good enough to merge.


Add variation of XCTAssertWorkflowLaunched for use with AnyWorkflow

Linked Issue:

Checklist:

[x] Did you sign the Contributor License Agreement?
[x] Is the linter reporting 0 errors?
[x] Did you comply with our styleguide?
[x] Is there adequate test coverage for your new code?
[ ] Does the CI pipeline pass?
[ ] Did you update the documentation?
[ ] Did you update the sample app?
[ ] Do we need to increment the minor/major version?
[x] Did you change the public API?
[x] Have you done everything you can to make sure that errors that can occur are compile-time errors, and if they have to be runtime do you have adequate tests and documentation around those runtime errors? For more details.

If Applicable:

[ ] Did you test when the first item is skipped?
[ ] Did you test when the last item is skipped?
[ ] Did you test when middle items are skipped?
[ ] Did you test when incorrect data is passed forward?
[ ] Did you test proceeding backwards?

If Public API Has Changed:

[ ] Did you deprecate (rather than remove) any old methods/variables/etc? Our philosophy for deprecation.
[ ] Have you done the best that you can to make sure that the compiler guides people to changing to the new API? (Example: the renamed attribute)
[ ] If necessary, have you tested the upgrade path for at least N-1 versions? For example, if data persists between v1 and v2 then that upgrade should be tested and as easy as we can make it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@nallick This looks good. I'll need you to sign the CLA before I can approve it.

@nallick This looks good. I'll need you to sign the CLA before I can ~approve~ merge it.

There's something weird going on with the CLA tool. I signed it at the same time as I created the PR, but it doesn't show here. When I try to sign it again I get the page with You have agreed to the CLA for wwt/SwiftCurrent and the signing controls at the bottom disabled.

@nallick This looks good. I'll need you to sign the CLA before I can ~approve~ merge it.

@Tyler-Keith-Thompson There's something weird going on with the CLA tool. I signed it at the same time as I created the PR, but it doesn't show here. When I try to sign it again I get the page with You have agreed to the CLA for wwt/SwiftCurrent and the signing controls at the bottom disabled. Also clicking the "recheck" button doesn't make a difference.

I think the problem is you contributed with 2 accounts. One is "nallick" and the other is "nick-nallick-wwt". Both need to sign the agreement for it to work.


dotnet runtime errors in docker container on Ubuntu 16.04.3

Steps to reproduce the issue

Login to a vanilla Ubuntu 16.04.3 LTS instance.

Welcome to Ubuntu 16.04.3 LTS (GNU/Linux 4.4.0-98-generic x86_64)

Ensure latest docker-ce version is installed.

root@ship02:/home/ahazelwood# docker --version
Docker version 17.09.0-ce, build afdb6d4

Create a local Dockerfile

root@ship02:/home/ahazelwood# cat Dockerfile
FROM microsoft/dotnet:2.0-runtime
WORKDIR /app
ENTRYPOINT ["/bin/bash"]

Run:  docker build . -t testah

root@ship02:/home/ahazelwood# docker build . -t testah
Sending build context to Docker daemon  14.34kB
Step 1/3 : FROM microsoft/dotnet:2.0-runtime
 ---> c73382e1bbf7
Step 2/3 : WORKDIR /app
 ---> e7c12683c292
Removing intermediate container 5f02eb55c496
Step 3/3 : ENTRYPOINT /bin/bash
 ---> Running in 31dddb3f96ba
 ---> 61b80806a390
Removing intermediate container 31dddb3f96ba
Successfully built 61b80806a390
Successfully tagged testah:latest

Run the container and issue the command dotnet --version

root@ship02:/home/ahazelwood# docker run -it testah
root@bd50671c6ca1:/app# dotnet --version
Did you mean to run dotnet SDK commands? Please install dotnet SDK from:
  http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409

Expected behavior
I would expect the latest version to get printed from the console.
Actual behavior
Error message as stated in point 5 above.
Additional information (e.g. issue happens only occasionally)
I was attempting to create a custom dotnet core console app from my windows machine within a linux container.  However, whenever I attempt to run my container with the following docker container, I get the output below.
FROM microsoft/dotnet:2.0-runtime
WORKDIR /app
COPY ./bin /app
ENTRYPOINT ["dotnet", "CI.Processing.ProcessTest.dll"]

It was not possible to find any compatible framework version
The specified framework 'Microsoft.NETCore.App', version '2.0.0' was not found.
  - Check application dependencies and target a framework version installed at:
      /
  - Alternatively, install the framework version '2.0.0'.

Output of docker version
root@ship02:/home/ahazelwood# docker version
Client:
 Version:      17.09.0-ce
 API version:  1.32
 Go version:   go1.8.3
 Git commit:   afdb6d4
 Built:        Tue Sep 26 22:42:18 2017
 OS/Arch:      linux/amd64

Server:
 Version:      17.09.0-ce
 API version:  1.32 (minimum version 1.12)
 Go version:   go1.8.3
 Git commit:   afdb6d4
 Built:        Tue Sep 26 22:40:56 2017
 OS/Arch:      linux/amd64
 Experimental: false

Output of docker info
root@ship02:/home/ahazelwood# docker info
Containers: 10
 Running: 8
 Paused: 0
 Stopped: 2
Images: 12
Server Version: 17.09.0-ce
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 06b9cb35161009dcb7123345749fef02f7cea8e0
runc version: 3f2f8b84a77f73d38244dd690525642a72156c64
init version: 949e6fa
Security Options:
 apparmor
 seccomp
  Profile: default
Kernel Version: 4.4.0-98-generic
Operating System: Ubuntu 16.04.3 LTS
OSType: linux
Architecture: x86_64
CPUs: 6
Total Memory: 9.732GiB
Name: ship02
ID: XYF3:R35G:JFAH:YC22:OH46:4SQX:6XR3:VJYK:T44D:LKR5:VWZK:7PUE
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

WARNING: No swap limit support

It turns out that I had an issue with an earlier version of the dotnet-2.0 runtime hanging around in docker and docker was not pulling the latest.  Once I force a re-pull of the runtime, things worked as expected.  I also noticed that I have to do a dotnet --info instead of --version now.


Added html export of items

Added a straightforward HTML option for the items.
I've tested this on an export of my own WordPress site and it exports over a thousand entries in less than a second.

Hi @Petess ! I merged your PR and made some minor adjustments regarding error handling and some other items.
Please try it out and let me know what you think.

That's great, thank you very much, sorry, I didn't run a linter over it.

I revved this to v0.3.0. Please try it out.

Thanks, that works well.


ENH: Fixed COPY_INSTEAD_OF_MOVE in MultiThreaderBase

Detected by Coverity 2023.6.2.
Used "lambda capture initializers" (C++14) to fix the issue.
In my tests (Linux, GCC 12.2) this saves copy of 32 bytes * number of threads for multi-threaded filters.
330  template <unsigned int VDimension>
331  ITK_TEMPLATE_EXPORT void
332  ParallelizeImageRegion(const ImageRegion<VDimension> &           requestedRegion,
333                         TemplatedThreadingFunctorType<VDimension> funcP,
334                         ProcessObject *                           filter)
335  {
336    this->ParallelizeImageRegion(
337      VDimension,
338      requestedRegion.GetIndex().m_InternalArray,
339      requestedRegion.GetSize().m_InternalArray,
   CID 315595 (1-2 of 2): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)1. copy_constructor_call:
   funcP is copied in call to copy constructor std::function<void (itk::ImageRegion<3u> const &)>,
   when it could be moved instead.
   Use std::move(funcP) instead of funcP.
340      [funcP](const IndexValueType index[], const SizeValueType size[]) {
341        ImageRegion<VDimension> region;
342        for (unsigned int d = 0; d < VDimension; ++d)
343        {
344          region.SetIndex(d, index[d]);
345          region.SetSize(d, size[d]);
346        }
347        funcP(region);
348      },
349      filter);
350  }

Maybe alternatively [&funcP] to pass funcP by reference.

@issakomi The pull request I just did is inspired by yours  😃 Please have a look:

#4347

Thanks!

A side-effect of capturing by reference is that access to funcP inside the lambda will no longer be "const".

Perhaps make the variable itself constant (pass as 'const' to the functions), if possible?
int main()
{
	const int x{42};
	auto f = [&x]() -> int { --x; return x; };
	f();
	return 0;
}

r@deb2:~$ g++ test.cpp
uu.cpp: In lambda function:
uu.cpp:4:36: error: decrement of read-only reference ‘x’
    4 |         auto f = [&x]() -> int { --x; return x; };
      |                                    ^

Perhaps make the variable itself constant (pass funcP as 'const' to both functions), if possible?

Perhaps... but obviously the loss of const-ness wasn't really a show-stopper to me anyway. (Because std::function::operator() is already const.)


farming simulator 19

Anyone have one account with this game for donation?
Farming Simulator 2019

This is not the place for account exchanges.


Tor as a transport

I probably can't implement this immediately, as I am still getting familiar with the software, but I noticed it already supports I2P tunnels as a transport layer.
It probably wouldn't be particularly hard to implement Tor support - it would just be a change to the tcpclient interface implementation to use a SOCKS proxy, and for the tcpserver interface implementation, just spinning up a hidden service (probably using the Stem library) pointing to the tcpserver port (bound to localhost by default in Tor mode?).
Unless I am missing something?
Love the project by the way, I hope at some time to pick up some of the associated hardware.

Unless I am missing something?

I don't think you are missing anything. Pretty sure right now you could use the existing TCPServer and TCPClient interfaces to tunnel a Reticulum connection through tor.
Do you know if there are any python libraries that would provide an easy method of managing tor hidden services? Using I2P, you can tunnel normal Reticulum TCP connections, but there's also an API that allows the Reticulum process to manage all the I2P-related things programmatically, and more efficiently that spawning a setting up a TCP interface for every I2P peer.
One other fairly significant option that a tor interface could provide, is the ability for a RNS Instance to easily connect to some public-facing TCPServer, using tor exit nodes.

Stem and PySocks would probably be the two "new dependancies" added to implement this.
PySocks would allow TCPClient interfaces to connect over a SOCKS proxy to a public facing instance running a TCPServer interface, including ones operating as hidden services.
Stem will allow to programatically control the Tor process, for example, by launching a hidden service.

One other fairly significant option that a tor interface could provide, is the ability for a RNS Instance to easily connect to some public-facing TCPServer, using tor exit nodes.

That is pretty much it. And with hidden service support for TCPServer's, you can have location-hidden RNS Instances behind NAT that offer a "public facing" interface for clients to connect to.
I think I'll try get a draft/test of adding SOCKS support to the TCPClient interface first. Should allow me to get familiar with the codebase.

That sounds like a good approach. Let me know if you bump into any problems or have questions along the way, I will try my best to be helpful :)


How can I make sure I get code warnings every single time?

I am kinda new to Scala and this might be be an SBT thing, but I get the linter warnings only the first time I compile the code. Every subsequent compile goes thorough without any warnings. This might be because the compiled class files are not compiled again unless there are any changes, but is there a way to show the warnings every time nonetheless?

sbt only recompiles the files that have changed since the last compile, and Linter is a compiler plugin so it only sees what the compiler sees, and doesn't have any memory of previous compilations.
One way is to do a sbt clean compile, but it will make your compile time a lot longer.


Openai function

Issue number:
Summary
OpenAI can call functions
Changes

OpenAI agents now can call functions

User experience

Call function

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] I have performed a self-review of this change
[x] Changes have been tested
[x] Changes are documented

Is this a breaking change?
RFC issue number:
Checklist:

[x] Migration process documented
[x] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Hi,
Thank you  @leonardo2204 for the PR.
I did some refactoring on OpenAi agents (typescript and python).
For python we have a new PR with a new definition for tools, it should be merged today.
Could you merge the main branch to yours and see if any adjustments are needed?


maven issue

Hello Effektif Team,
I'm a student at the University of Bamberg and am currently working on a Projekt from our Distributed Systems group in which we check current BPMN engines for BPMN Standard conformity and correctness. So in order to get an understanding of the Effektif engine I was trying to go through the Tutorial and hit a roadblock right at the installation.
I cloned the project from the git repo then tried to do a "mvn clean install" but I get compilation errors.
I included a screencap of the output (the error list goes on for about 400 lines with the same message about not being able to find symbols, but I think you get the idea)

Can you gist your mvn command output ?
I just tried a clean mvn clean install -DskipTests and it had no errors

Which JDK are you using?
On 17 March 2015 at 17:20, Vijay Kiran<EMAIL_ADDRESS>wrote:

Can you gist your mvn command output ?
I just tried a clean mvn clean install -DskipTests and it had no errors
—
Reply to this email directly or view it on GitHub
https://github.com/effektif/effektif/issues/4#issuecomment-82442961.

--
Nicolas Leroux

this is to do with one of the optional components: a rhino native javascript engine.
the pom files says this:
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-compiler-plugin</artifactId>
        <version>3.1</version>
        <configuration>
          <encoding>UTF-8</encoding>
          <source>1.7</source>
          <target>1.7</target>
          <compilerArguments>
            <!-- This is to get the Rhino internal classes compiled -->
            <bootclasspath>${java.home}/lib/rt.jar</bootclasspath>
          </compilerArguments>
        </configuration>
      </plugin>

so indeed it would be interesting to know on which jdk this doesn't work

The better solution is not to use the internal package. Instead add this dependency to effectif-workflow-impl:
<dependency>
  <groupId>org.mozilla</groupId>
  <artifactId>rhino</artifactId>
  <version>1.7R3</version>
</dependency>

and replace sun.org.mozilla.javascript.internal with org.mozilla.javascript in the sources.

great suggestion!
i ll fix it in one of the next days

Cool. I am not sure if this brings any improvements, but it might be a good idea to move to the latest version of Rhino then. I tried to use 1.7R5, but this caused some problems in the unit tests.

i ll keep that in mind.  we ll also have to move it into a separate optional package.
another approach that i might try first is to implement the feature we want inside of the standard scripting api.  i want nested json structures to behave like real javascript objects.  also these nested structures have to be resolved dynamically.  that might be a challenge with the standard scripting api where I have to wrap dynamic objects in Maps.  Afaict, rhino supports that you perform a.b (instead of a.get('b').  But I recall reading this is rhino specific.  So other javascript engines might not support that.

Here is the printout from the mvn -v. As you can see this uses the Java 8 Jdk
adding the dependencies seemed to work, but I got a connection reset while trying to download the files. But this is probably a completely different error and most likely has to do with the network in the University.
Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T18:37:52+01:00)
Maven home: [...]\dsg-project\maven\apache-maven-3.2.1\bin\..
Java version: 1.8.0_31, vendor: Oracle Corporation
Java home: [...]\Java\jdk1.8.0_31\jre
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"

I forgot to add the -DskipTests statement to my maven command, now it worked.
replacing the source files was kind of a hassle though. Thanks for the help


[DOC]Clarify transaction conflicts

@Tryneus and @ysimonson let me know if this clarifies it or whether we should the wording further.


Fix "set but unused" warning when using armclang 6.17

Compiling with armclang 6.17 and BUILD_TYPE=release causes compilation error. Fixes #717

@advaitjain @petewarden Does this look OK from your end?


0.21.0-rc5 wrong http method with WS

In the rc5 release I get the error:
ERROR error establishing WebSocket connection to backend ws://[::1]:8000/api/v1/ws for proxy error=Protocol(WrongHttpMethod)

I have config:
[[proxy]]
backend = "ws://[::1]:8000/api/v1/ws"
request_headers = { "host" = "example.org" }
ws = true

With the rc4 version it works fine.

Yup, that was me. Sorry.

Hm, I can't reproduce the issue though. There's a wrong HTTP method being provided to the internal function creating the request. However, that actually get overridden with GET, and that's what I see on the wire.
Can you provide some more detail, logs, maybe a packet capture of the issue?

Ok, I should have sniffed the connection between trunk and the backend, not the WS client and the backend :rofl: … So I can reproduce is, and there's a PR fixing this: https://github.com/trunk-rs/trunk/pull/884

I can confirm that the new rc6 release fixed it.


[This tool is amazing, why dont deploy it in all the big EVM´s?]

Description
[This tool is amazing, why dont deploy it in all the big EVM´s?]
Proposal
Deploy the contracts in all the bigs EVM chains
Screenshots
If applicable, add screenshots to help explain your problem.

Coming soon maybe! Keep an eye on this Discord thread: https://discord.com/channels/775859454780244028/969921228435501076


Clean up terminal output

Yes, its nit picky and yes i could just press enter again to get a clean line. But please make it so that the prompt appears on a new line and not after the end of the output text.
ajones@C560:~$ curl -H "Content-Type: application/json" -X POST -d '{"username": "ajones", "password": "r3deem227!"}' <IP_ADDRESS>:3000/auth/login
{"login":true,"token":"8e805832-40a1-4e3b-8a81-e8e4e77b6926","groups":["ajones"]}ajones@C560:~$
ajones@C560:~$ curl -H "auth-token: 8e805832-40a1-4e3b-8a81-e8e4e77b6926" <IP_ADDRESS>:3000/api/
{"hosts":["jbjc.asura.vm42.us","stuff.asura.vm42.us","transmission.asura.vm42.us","emby.asura.vm42.us","remotevm.asura.vm42.us"]}ajones@C560:~$
ajones@C560:~$ curl -H "Content-Type: application/json" -H "auth-token: 8e805832-40a1-4e3b-8a81-e8e4e77b6926" -X DELETE -d "{"host": "jbjc.asura.vm42.com"}" <IP_ADDRESS>:3000/api/
{"message":"Host jbjc.asauth-token: 8e805832-40a1-4e3b-8a81-e8e4e77b6926" <IP_ADDRESS>:3000/api/
{"hosts":["jbjc.asura.vm42.us","stuff.asura.vm42.us","transmission.asura.vm42.us","emby.asura.vm42.us","remotevm.asura.vm42.us"]}ajones@C560:~$

This is designed function of  curl, see https://stackoverflow.com/questions/12849584/automatically-add-newline-at-end-of-curl-response-body

stale


Randomly closes files when it's supposed to. Randomly doesn't

With:
"Workspace_Formatter.closeAfterSave": true,
"Workspace_Formatter.saveAfterFormat": true,
It's a coin flip as to whether files that are opened and formatted are actually closed by the extension, but it seems like usually it isn't. I tried to isolate some situations but couldn't. I thought it might be related to not closing files that didn't need formatting/saving but no luck. I tried keep closeaAfterSave as true, and changing saveAfterFormat to false, and I'd even come up with situations where every file that need formatting was opened, modified, kept dirty/unsaved, and I was never even asked to close anyone one of them, out of about a dozen.
Maybe it's an API change, maybe a timing issue.. but this auto close feature is usually not working right now.

Also just have situation where it randomly doesn't execute the format action on the file, either. Just to be sure I've tested with the "Format in context menus" addon (lacroixdavid1.vscode-format-context-menu) which does not exhibit this behavior.

I have to dig into the closing issue.
THe VSCode API is there a bit strange


Building project => error: Variable "x" first declared in externs.zip//html5.js

info: '--force' allows to proceed further
log:
Warning: ./src/js/externs/externs.js:32: WARNING - Redeclared variable: HTMLContentElement
function HTMLContentElement() {}
^
./src/js/externs/externs.js:43: WARNING - Redeclared variable: HTMLShadowElement
function HTMLShadowElement() {}
^
./src/js/externs/externs.js:32: ERROR - Variable HTMLContentElement first declared in externs.zip//html5.js
function HTMLContentElement() {}
^
./src/js/externs/externs.js:43: ERROR - Variable HTMLShadowElement first declared in externs.zip//html5.js
function HTMLShadowElement() {}

I did a "bad" thing and commented out the above mentioned code from externs.js and after that the project was building successfully, new axs_test.js was generated.
With the above mentioned error (not commenting the code out) during the build, the new audit file is not being generated.

I have similar errors trying to build it (master branch, OS X Yosemite):
$ grunt --version
grunt-cli v0.1.13
grunt v0.4.5

$ npm --version
2.7.5

$ grunt
Running "save-revision" task

Running "git-describe" task
Git Revision: 7339ac43b963264ef74b69458aefebb4ea222697

Running "closurecompiler:minify" (closurecompiler) task

Compiling ./lib/closure-library/closure/goog/base.js,./src/js/axs.js,./src/js/BrowserUtils.js,./src/js/Constants.js,./src/js/AccessibilityUtils.js,./src/js/Properties.js,./src/js/AuditRule.js,./src/js/AuditRules.js,./src/js/AuditResults.js,./src/js/Audit.js,./src/audits/AriaOnReservedElement.js,./src/audits/AriaOwnsDescendant.js,./src/audits/AriaRoleNotScoped.js,./src/audits/AudioWithoutControls.js,./src/audits/BadAriaAttribute.js,./src/audits/BadAriaAttributeValue.js,./src/audits/BadAriaRole.js,./src/audits/ControlsWithoutLabel.js,./src/audits/DuplicateId.js,./src/audits/FocusableElementNotVisibleAndNotAriaHidden.js,./src/audits/HumanLangMissing.js,./src/audits/ImageWithoutAltText.js,./src/audits/LinkWithUnclearPurpose.js,./src/audits/LowContrast.js,./src/audits/MainRoleOnInappropriateElement.js,./src/audits/MeaningfulBackgroundImage.js,./src/audits/MultipleAriaOwners.js,./src/audits/NonExistentAriaRelatedElement.js,./src/audits/PageWithoutTitle.js,./src/audits/RequiredAriaAttributeMissing.js,./src/audits/RequiredOwnedAriaRoleMissing.js,./src/audits/TabIndexGreaterThanZero.js,./src/audits/UnfocusableElementsWithOnClick.js,./src/audits/UnsupportedAriaAttribute.js,./src/audits/VideoWithoutCaptions.js -> gen/axs_testing.js
Warning: ./src/js/externs/externs.js:32: WARNING - Redeclared variable: HTMLContentElement
function HTMLContentElement() {}
         ^

./src/js/externs/externs.js:43: WARNING - Redeclared variable: HTMLShadowElement
function HTMLShadowElement() {}
         ^

./src/js/externs/externs.js:32: ERROR - Variable HTMLContentElement first declared in externs.zip//html5.js
function HTMLContentElement() {}
         ^

./src/js/externs/externs.js:43: ERROR - Variable HTMLShadowElement first declared in externs.zip//html5.js
function HTMLShadowElement() {}
         ^

2 error(s), 2 warning(s)
 Use --force to continue.

Aborted due to warnings.

Sorry for missing this until @ckundo brought it to my attention!
Will make a fix for it asap, but in the meantime you can work around it by just deleting the duplicate declarations in src/js/externs/externs.js - clearly Closure has caught up!

Thanks, I can confirm that commenting out these lines makes grunt build work again :+1:

Thanks @alice -- the warnings about duplicate declarations are now gone, but I get this error now:
$grunt build
Running "save-revision" task

Running "git-describe" task
Git Revision: 22e4b17455b96fbb262c6093c5f8bca82822bab0

Running "closurecompiler:minify" (closurecompiler) task

Compiling ./src/js/axs.js,./src/js/BrowserUtils.js,./src/js/Constants.js,./src/js/AccessibilityUtils.js,./src/js/Properties.js,./src/js/AuditRule.js,./src/js/AuditRules.js,./src/js/AuditResults.js,./src/js/Audit.js,./src/audits/AriaOnReservedElement.js,./src/audits/AriaOwnsDescendant.js,./src/audits/AriaRoleNotScoped.js,./src/audits/AudioWithoutControls.js,./src/audits/BadAriaAttribute.js,./src/audits/BadAriaAttributeValue.js,./src/audits/BadAriaRole.js,./src/audits/ControlsWithoutLabel.js,./src/audits/DuplicateId.js,./src/audits/FocusableElementNotVisibleAndNotAriaHidden.js,./src/audits/HumanLangMissing.js,./src/audits/ImageWithoutAltText.js,./src/audits/LinkWithUnclearPurpose.js,./src/audits/LowContrast.js,./src/audits/MainRoleOnInappropriateElement.js,./src/audits/MeaningfulBackgroundImage.js,./src/audits/MultipleAriaOwners.js,./src/audits/NonExistentAriaRelatedElement.js,./src/audits/PageWithoutTitle.js,./src/audits/RequiredAriaAttributeMissing.js,./src/audits/RequiredOwnedAriaRoleMissing.js,./src/audits/TabIndexGreaterThanZero.js,./src/audits/UnfocusableElementsWithOnClick.js,./src/audits/UnsupportedAriaAttribute.js,./src/audits/VideoWithoutCaptions.js -> gen/axs_testing.js
Warning: ./src/js/AuditResults.js:36: ERROR - variable goog is undeclared
goog.exportSymbol('axs.AuditResults', axs.AuditResults);
^

1 error(s), 0 warning(s)
 Use --force to continue.

Aborted due to warnings.

Related: https://code.google.com/p/accessibility-developer-tools/issues/detail?id=11

@jaimeiniesta Did you use git clone --recursive when you first checked out?
If not, you may need to run
git submodule init; git submodule update

Thanks @alice -- that was it, I forgot about that. Now it works. :+1:

There's one weird thing, though -- the generated axs_testing.js file has its contents between single quotes:
'/*
 * Copyright 2015 Google Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.

(...)

  return !a.querySelectorAll("track[kind=captions]").length;
}, code:"AX_VIDEO_01"});

'

Wow, yeah, I see the same thing. It's like grunt has become 'ironic'.
Digging into it now...


Improve the errors and test them

Important
This issue is based on this specification: https://github.com/meilisearch/specifications/pull/61
The specification gathers all the information related to this feature: the motivation, the API and technical changes, the future possibilities...
⚠ For anything that is not clear or deeply detailed in this issue, please refer to this specification.
Especially, for the @meilisearch/docs-team and the @meilisearch/integration-team, don't refer to this issue and always use the specification for your work.

[x] errorCode, errorType and errorLink are changed into code, type, link
[x] The exhaustive list of errors present in the spec should be well implemented. Most of them are already present, we need to check the message, the type, the code, and the link are correct according to the spec.
[x] Add tests: each error should be tested. We might need to find a smart way to test the MeiliSearch errors. Except for 500 errors (aka internal errors) of course.

Since there are a lot of errors, this can be done in multiple PRs.

[x] Variant: Specifying a custom ranking rule on reserved fields _geo or _geoDistance
[x] Variant: Specifying a custom ranking rule on reserved expression _geoPoint
[x] Variant: Specifying a custom ranking rule on reserved expression _geoRadius

[x] invalid_filter

[x] Error Type & Code
[x] Error Message

[x] Variant: Filtering on a non filterable attribute
[x] Variant: Using _geoDistance as a filter expression
[x] Variant: Using _geo or _geoPoint as a filter expression
[x] Variant: Invalid syntax for the filter parameter

[x] invalid_sort

[x] EError Type & Code
[x] Error Message:

[x] Variant: Sorting on a non sortable attribute
[x] Variant: Using _geoDistance as a sort expression
[x] Variant: Using _geo or _geoRadius as a sort expression
[x] Variant: Invalid syntax for the sortparameter
[x] Variant: Specifying sort at search time while the sort ranking rule isn't set in the ranking rules settings

[x] invalid_geo_field

[x] Error Type & Code
[x] Error Message

[x] payload_too_large

[x] Error Type & Code
[x] Error Message

[ ] not_found
[x] index_not_found

[x] Error Type & Code
[x] Error Message

[x] document_not_found

[x] Error & Code
[x] Error Message

[x] dump_not_found

[x] Error Type & Code
[x] Error Message

[x] task_not_found

[x]  Error Type & Code
[x]  Error Message

[x] dump_already_processing

[x] Error Type & Code
[x] Error Message

[x] invalid_content_type

[x] Error Type & Code
[x] Error Message

[x] missing_content_type

[x] Error Type & Code
[x] Error Message

[x] missing_payload

[x] Error Type & Code
[x] Error Message

[x] malformed_payload

[x] Error Type & Code
[x] Error Message

[x] Variant: Syntax error
[x] Variant: Sending a valid but empty []/{} payload on POST/PUT - indexes/:indexUid/documents.

internal type

[x] internal

[x] Error Type & Code
[x] Error Message

[x] index_creation_failed

[x] Error Type & Code
[x] Error Message

[ ] index_not_accessible

[ ] Error Type & Code
[ ] Error Message

[ ] unretrievable_document

[ ] Error Type & Code
[ ] Error Message

[ ] invalid_state

[ ] Error Type & Code
[ ] Error Message

[ ] dump_process_failed

[ ] Error Type & Code
[ ] Error Message

[x] database_size_limit_reached

[x] Error Type & Code
[x] Error Message

[x] no_space_left_on_device

[x] Error Type & Code
[x] Error Message

[x] invalid_store_file

[x] Error Type & Code
[x] Error Message

auth type

[x] missing_authorization_header

[x] Error Type & Code
[x] Error Message

[x] invalid_api_key

[x] Error Type & Code
[x] Error Message

Closed thanks to https://github.com/meilisearch/MeiliSearch/pull/1873 and https://github.com/meilisearch/MeiliSearch/pull/1873


feat: use microseconds for measuring pool checkouts

What is the current behavior?
Currently we measure pools checkouts in milliseconds, but these do not give us enough resolution and almost everything is crammed into le="1" bucket.
What is the new behavior?
Change time unit used for measures to microsecond so all measurements are multiplied by factor of 1000 which should give us better insights into real distribution.

@chasers I have changed the metric name in Prometheus/VictoriaMetrics to include the unit, so it wouldn't be confused with "old" metrics, but it will require updates in the Grafana dashboards.


How to automate the complex dropdown in the dialog.

As a part of my project, i wnted to automate the complex dropdowns in the aem dialog, as present in the screenshot.
Please suggest how to, or if there already is a way.

@ShuklaShubh89 Please share the component with sample tabs. We can try to recreate the problem.

Hi @ShuklaShubh89,
have been some time since I've used AEM's ClassicUI but it seems like Tag picker - try using the AemTags field: link
If it does not work - you can still use that example for writing your own custom dialog field.


[service-bus] API: move settlement/renewLock from message object to Receiver

As part of an internal API review we've decided that the settlement and lock renew methods are located in two separate spots across our SDKs - on the Receiver (Java, C#) or on the ServiceBusMessage (Python, JavaScript).
Rather than allowing these SDKs to diverge we've chosen to unite them and to put the methods onto the Receiver object. This also aligns with the idioms we've applied across our other packages in the Azure SDK - generally, data is not "smart" and doesn't carry actions.
There are other potential benefits in the future, like allowing the ability to process multiple items at a time, etc... None of these are coming in any planned version of the SDK but they do exist as a potential API extension in the future.
The names of the methods will change slightly to indicate they are message specific:
Methods:

renewMessageLock
completeMessage/abandonMessage/deferMessage/deadLetterMessage

@richardpark-msft My one concern with this move of settlement methods to the receiver is that you now need to access the receiver from inside the message callback to settle messages or renew their locks. Before this, the callback was passed everything that you would need from the client. So, I could define my callback in another part of my code and simply pass that in. Now, I need to ensure that the callback can access the receiver.
Should we consider a ProcessMessageArgs or ProcessMessageContext and have the settlement methods in there?
cc @HarshaNalluru, @bterlson

With #11962, I have retained the overloads for createReceiver and createSessionReceiver methods even though there is no difference between the overloads anymore. This is to facilitate the next step of ensuring that users in ReceiveAndDelete mode do not see the settlement methods or the renewMessageLock method. There are two approaches to this which are experimented with in

https://github.com/ramya-rao-a/azure-sdk-for-js/pull/4
https://github.com/ramya-rao-a/azure-sdk-for-js/pull/5

@bterlson, @richardpark-msft, @HarshaNalluru Thoughts?

I am not convinced this complexity is paying for itself anymore. Can we reconsider using the fancy TS-magic and just throwing an informative error and documenting when these methods apply?

I think we're good to stop here and just leave things with the same receiver for both peekLock and receiveAndDelete.
The original thinking here was well intentioned but I think that most users are not going to get too confused about what's going on - we can clarify this in the readme and samples simply enough and we'd always have to deal with the runtime aspects regardless, since we want to properly support pure JS users. This also brings us in line with what other languages are doing and that consistency does count for something.
We will find a better spot for dynamic types in our API (but not today)! ;)

@richardpark-msft My one concern with this move of settlement methods to the receiver is that you now need to access the receiver from inside the message callback to settle messages or renew their locks. Before this, the callback was passed everything that you would need from the client. So, I could define my callback in another part of my code and simply pass that in. Now, I need to ensure that the callback can access the receiver.
Should we consider a ProcessMessageArgs or ProcessMessageContext and have the settlement methods in there?
export interface MessageHandlers {
    processError(args: ProcessErrorArgs): Promise<void>;
    processMessage(message: ServiceBusReceivedMessage, args: ProcessMessageArgs): Promise<void>;
}

cc @HarshaNalluru, @bterlson

This problem is shared with all the other SDKs as well - I think we're okay to just leave it as is. Then there's no difference in how you deal with message settlement whether you're using subscribe, receiveMessages or the iterator.

This problem is shared with all the other SDKs as well - I think we're okay to just leave it as is. Then there's no difference in how you deal with message settlement whether you're using subscribe, receiveMessages or the iterator.

The .Net and Java counterparts to our subscribe() call is the processor which has only start/stop/close methods. The call back gets passed ways to settle the message
This change can be additional in the future if needed as well.

So, I could define my callback in another part of my code and simply pass that in. Now, I need to ensure that the callback can access the receiver

Also, settling messages in the callback is not a must. Users can very well store the messages from the callbacks and settle them wherever they have the access to the receiver.
Keeping this in mind, providing multiple ways of settling would rather be confusing for the users?

I am in favor of doing the simpler thing now (not passing in the settlement methods), and adding them later based on feedback!


GetxControllers methods (onInit, onReady, onClose) are not called when navigating to a previously rendered page

Describe the bug
When starting to navigate between the different pages, when navigating to a previously loaded page the controller methods are not called. So you cannot reset controller values.
Reproduction code
https://github.com/jedidas/GetX-navigation-example-issue
example:
To Reproduce
The application has a timer and automatically navigates between the pages.
You can navigate using the drawer menu to any page.
Expected behavior
The controller methods (onInit, onReady, onClose) are called when the view is loaded every time and not only the first time.
Screenshots

In navigation, when navigating to a view that has already been rendered the controller methods (onInit, onReady, onClose) are not called again.

Flutter Version:
Flutter 1.22.5 • channel stable • https://github.com/flutter/flutter.git
Framework • revision<PHONE_NUMBER> (7 weeks ago) • 2020-12-10 11:54:40 -0800
Engine • revision ae90085a84
Tools • Dart 2.10.4
Getx Version:
get: ^3.24.0
Describe on which device you found the bug:
Virtual device Pixel_2_API_28
Minimal reproduce code
Provide a minimum reproduction code for the problem

Seems like the link of reproduction code is not available.
Can you share a block of your code - especially in the build method of page side?

The expected behavior for onInit, onReady and onClose is to be called only once. You can create a method called init and call it in your View's build method

Okay, it seems to me that you don't really understand how Stacks works.
Flutter, unlike the native android that works with activitys, for example, works with Stacks.
When you push a route, you are just stacking a route up, the route below is still there in the stack.
That way you are not opening a screen again, but just removing the view above it.
Life cycles are called only once, since it is the same controller.
This is expected behavior, so I'm closing this.


custom-element-react-wrappers:  React events are binded late, connectedCallback and firstUpdated are already dispatched

I posted this in the old CEM repository, but after testing I noticed the same problem occurs in this repository
I generated react wrappers
And when I attach a listener, which awaits an event directly from the original component on connectedCallback or firstUpdated it is not catched.
<QtiAssessmentItemRef onQtieItemConnectedCallback={(event) => { console.log('late to the party' }}>
</QtiAssessmentItemRef>

I debugged this code and the component, and the components lifecycle already travelled connectedCallback and firstUpdated before the eventlistener is attached in the below code:
react-utils.js
export function useEventListener(targetElement, eventName, eventHandler) {
  useEffect(() => {
    if (eventHandler !== undefined) {
      targetElement?.current?.addEventListener(eventName, eventHandler);
    }

    return () => {
      if (eventHandler?.cancel) {
        eventHandler.cancel();
      }

      targetElement?.current?.removeEventListener(eventName, eventHandler);
    };
  }, [eventName, eventHandler, targetElement]);
}

Thanks! I believe updating this to use useLayoutEffect should add the listener sooner. I will get an update out.

I deployed this fix in 1.0.5 (#36). Let me know if you still run into any issues.

Hi, I had some time to test this. It was missing the import of useLayoutEffect, so I added that in a pull request.

Awesome! Thank you!

I deployed 1.1.0 that includes your fix as well as an update to use useLayoutEffect for attributes as well. I tried using it for properties, but it was logging an error because the component is undefined.

Additional updates for this have been deployed in release 1.2.0 (https://github.com/break-stuff/cem-tools/pull/67). Let me know if you run into any issues.

Closing this for now. Let me know if you run into any issues.


[CodeCompletion] Introduce 'NotApplicable' and 'Unknown' type relation

Now, kinds of type relations are:

NotApplicable: The result is not relevant for type relation (e.g. keywords, and overloads)
Unknown: The relation was not calculated (e.g. cached results), or the context type is unknown
Invalid: The result type is invalid for this context (i.e. 'Void' for non-'Void' context)
Unrelated: The result type has no relation to the context type
Convertible: The result type is convertible to the context type
Identical: The result type is identical to the context type

rdar://problem/59201827

@swift-ci Please smoke test

Added 2 commits.

Handle new kinds in type relation printing.
Fixed a bug where cached results weren't Unknown.

@swift-ci Please smoke test


Feature Request: BOOST_DATA_TEST_CASE with descriptive identifiers

would it be possible for there to exist a variant of BOOST_DATA_TEST_CASE where something like

BOOST_DATA_TEST_CASE(my_data_test_case,
                       boost::unit_test::data::make({EMyEnum::val1, EMyEnum::val2, EMyEnum::val3}),
                       values)
{
    //Do Something
}

Could be identified using a syntax like
my_data_test_case/val1
my_data_test_case/val2
my_data_test_case/val3

or
my_data_test_case(val1)
my_data_test_case(val2)
my_data_test_case(val3)

instead of
my_data_test_case/_0
my_data_test_case/_1
my_data_test_case/_2

within the output from the test suite where val1, val2, val3, etc. represent the value produced by the given member of the dataset when using the insertion operator?

This would lead in test cases that are either not directly runable with the --run_test command line argument, or that would not lead to a valid test name. Consider for instance the cases where there is a combination of values for each test cases (using eg. grid).
With this in mind, Boost.Test considers the my_data_test_case as a unique test /suite/ (we can run all the tests from it) and of course we can run each test  individually. This would not be possible with the propose approach.
Does this make sense?


BUG: ListCommits() has empty committer name for "verified" commits

The repo client's code https://github.com/ossf/scorecard/blob/main/clients/githubrepo/graphql.go#L218 contains empty string for the committer name for certain commits.
Here are example commits that have an empty committer name:
d50788f6381d1fea21e4e50caa2de41012a38982
5f9fff3b20ce7eb933978c7a4f9391cb2c9b3d89
7a6eb2812a85ed047582b86a3e77e16302506558
16c0d375d64391c617df8f3994f15167b6798dbb
and more.
Looking at https://github.com/ossf/scorecard/commits/main, all these PRs have one thing in common: they are marked "verified" This commit was created on GitHub.com. Not sure why this changes the behavior though.
This blocks https://github.com/ossf/scorecard/issues/1524
@azeemsgoogle assigning to you since you've played with graphql and you may know an easy fix.

When I looked at the commits which returned empty committer - committer.name is GitHub and committer.email is<EMAIL_ADDRESS>Most likely these are commits which had auto-merge enabled. So technically, there was no committer.
What we can do is, pull-in either committer.name and committer.email and check if it was auto-merged by GitHub. Can send out a PR for this soon.

When I looked at the commits which returned empty committer - committer.name is GitHub and committer.email is<EMAIL_ADDRESS>Most likely these are commits which had auto-merge enabled. So technically, there was no committer.

You're saying Login is ``, but name is GitHub? If that's the case, just knowing it's empty means it's GitHub and I can add this as part of the check itself. I'm worried that GitHub and<EMAIL_ADDRESS>may be spoof-able by committers via their git config. I suspect GitHub checks for it but I don't know. I'd say empty string means merged by GitHub and I can implement this logic in the check by simply setting the results of the committer's login to GitHub. Nobody can spoof this field since logins are unique. wdut?

What we can do is, pull-in either committer.name and committer.email and check if it was auto-merged by GitHub. Can send out a PR for this soon.

If you agree on the above, no need for a follow-up PR :-)

My concern here is we'll bake in the assumption that nil means auto submitted. This might not be true for non-GitHub clients.
So, we can explicitly return<EMAIL_ADDRESS>as the User.Login and let Scorecard make the call here?

My concern here is we'll bake in the assumption that nil means auto submitted. This might not be true for non-GitHub clients.

good point.

So, we can explicitly return<EMAIL_ADDRESS>as the User.Login and let Scorecard make the call here?

+1 let's do that! Let's set it to github since GitHub logins don't contain @?

+1 let's do that! Let's set it to github since GitHub logins don't contain @?

Wfm. My thinking in choosing noreply@ was - since it's not a valid username, anyone can reason that it must be some automated bot. Whereas github is a valid GitHub username - https://github.com/github. I'll leave it upto you.

+1 let's do that! Let's set it to github since GitHub logins don't contain @?

Wfm. My thinking in choosing noreply@ was - since it's not a valid username, anyone can reason that it must be some automated bot. Whereas github is a valid GitHub username - https://github.com/github. I'll leave it upto you.

it's the platform's name though, the one that's used to run as GitHub user. For example, github-actions are run under user github. Does not really matter in the end, both are fine I think

I was quite wrong here.  Here are some example commits where committer.name and committer.email is non-empty but not  github:
https://github.com/criticalmanufacturing/dev-tasks/commit/a781f660ea1fd8121379817a8fe577c49ae6c171
https://github.com/AhmedAlatawi/ngx-treant-js/commit/cb5d84d72040db1fb61b39664ed0b34980c3a29a
Basically, if GitHub is unable to assign a GH userID to a commit, it takes the name and email from the Git commit. This is very easily spoof-able and someone can also commit using a<EMAIL_ADDRESS>email or github name as well. So, question is how do we proceed here? Should we go back to the way things were?

I was quite wrong here.  Here are some example commits where committer.name and committer.email is non-empty but not github:
criticalmanufacturing/dev-tasks@a781f66 AhmedAlatawi/ngx-treant-js@cb5d84d
Basically, if GitHub is unable to assign a GH userID to a commit, it takes the name and email from the Git commit. This is very easily spoof-able and someone can also commit using a<EMAIL_ADDRESS>email or github name as well. So, question is how do we proceed here? Should we go back to the way things were?

Something seems off. How can GitHub not be able to assign a GH userID yet have an email/name for it?
I've created a support ticket for it. @azeemshaikh38 do you want to file an issue on GitHub for them to update their doc? This behavior should be explained. In which context does GH not know who authored a merge request? Only autom-merge. or are there other corner cases?
@josepalafox appreciate any input from your team.
Context: users want to add policies on top of scorecard results, e.g. "code was reviewed and merged by users in list [X,Y,Z, ...]". For this we need a reliable way retrieve the username/login of a user. We found a corner case where, if we use auto-merge in the GitHub UX, the login field is null. The name and email fields are available but those can be spoofed via git settings. Is there a way to retrieve this information reliably?

Sent out #1576 to revert this change for now since it'll be erroring out for wrong reasons.

I was quite wrong here.  Here are some example commits where committer.name and committer.email is non-empty but not github:
criticalmanufacturing/dev-tasks@a781f66 AhmedAlatawi/ngx-treant-js@cb5d84d
Basically, if GitHub is unable to assign a GH userID to a commit, it takes the name and email from the Git commit. This is very easily spoof-able and someone can also commit using a<EMAIL_ADDRESS>email or github name as well. So, question is how do we proceed here? Should we go back to the way things were?

I've created a support ticket for it. @azeemshaikh38 do you want to file an issue on GitHub for them to update their doc? This behavior should be explained. In which context does GH not know who authored a merge request? Only auto-merge. or are there other corner cases?

fyi, the commits we get from graphql when querying only the commits don't have the login information. But it looks like the CommitMerge.Committer.Login is correct when querying the AssociatedPullRequests. By looking at the commit hash, we can match one against the other and recover the login: this may be a workaround the problem.
@azeemshaikh38 please tell me if you can reproduce my results.

Hmm, no. The committer and author info in commit vs. associated PR is the same. Maybe you are comparing commitAuthor with committer?

ah yes. But for a commit to the main branch, the committer is the author of the merge commit. Are they not the same thing?
What is the author of a commit to branch supposed to be, if not the merge commit's committer?

according to https://docs.github.com/en/graphql/reference/objects#commit, there's both an Author and a Committer. Not sure about the difference :/

so the way to ensure it's a cmmit authored by GH is to query the signature of a commit and verify it's signed by GH's public key.
Fyi, there's also a autoMergeRequest.enabledBy.login which may be an interested field. Not sure it's necessary, just fyi.

follow-up. We don't need to verify the signature to start with, we can simply use
isValid and wasSignedByGitHub field to verify it's GitHub.

Is looking for wasSignedByGitHub not enough? Seems like that boolean is only set to true if committer is GitHub and is null otherwise.

Yes wasSignedByGitHub should be enough for us. I added the other links as fyi in case we want to more in the future.

Makes sense, thanks for finding this! Do you want to send a PR for this?

unless someone else wants to do it, happy to.

Thanks, assigning this to you.


Ctrl + Backspace does not delete whole word in integrated terminal

Does this issue occur when all extensions are disabled?: Yes/No
Yes

VS Code Version:  1.92.1
OS Version:  Windows 10 Pro 22H2 x64
Steps to Reproduce:

No steps needed, trying to erase whole words in the terminal does not work, it deletes a single character instead.
This has been mentioned before here in these issues:
https://github.com/microsoft/vscode/issues/208551
https://github.com/microsoft/vscode/issues/98404
Both were closed without a practical solution and the answer appeared to be "works on my machine™".
Here are my bindings for ctrl + backspace:

As you can see there are no user bindings, it should just work.
Here's the actual behavior, CMD:

Powershell:

Same as the other user mentioned in that first issue.
Ctrl backspace works fine in CMD, Powershell and Windows Terminal. Disabled all extensions, there are no other programs hogging that shortcut globally. There seems to be an issue somewhere.

Bu sorun, entegre terminalde Ctrl + Backspace tuş kombinasyonunun tüm kelimeyi silmemesiyle ilgili. TerminalInstance modülünde bu kombinasyonun doğru işlevi yerine getirmesi için bir düzeltme öneriyorum. _deleteWord() fonksiyonunu ekleyerek, imlecin solundaki kelimenin tamamını silen bir işlev tanımladım. Bu değişiklik, entegre terminaldeki yazı düzenleme deneyimini iyileştirecek.
This issue relates to the Ctrl + Backspace key combination not deleting the entire word in the integrated terminal. I've proposed a fix by modifying the TerminalInstance module. The fix involves adding a _deleteWord() function that correctly deletes the word left of the cursor. This update should improve the text editing experience in the terminal by ensuring expected behavior for this key combination.

what args are you using for sendSequence?

what args are you using for sendSequence?

I did not change the default bindings so I'd assume the default values for those.
Here's the default bindings file:

Here's the log of a single ctrl + backspace from the debugging output:
2024-08-19 14:10:19.727 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-08-19 14:10:19.727 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2024-08-19 14:10:19.727 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 17, key: Control
2024-08-19 14:10:19.727 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 5 ('Ctrl')
2024-08-19 14:10:19.728 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2024-08-19 14:10:20.233 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-08-19 14:10:20.233 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2024-08-19 14:10:20.234 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 17, key: Control
2024-08-19 14:10:20.234 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 5 ('Ctrl')
2024-08-19 14:10:20.234 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2024-08-19 14:10:20.264 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-08-19 14:10:20.265 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2024-08-19 14:10:20.265 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 17, key: Control
2024-08-19 14:10:20.265 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 5 ('Ctrl')
2024-08-19 14:10:20.266 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2024-08-19 14:10:20.278 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-08-19 14:10:20.279 [info] [KeybindingService]: | Resolving ctrl+Backspace
2024-08-19 14:10:20.279 [info] [KeybindingService]: \ From 3 keybinding entries, matched workbench.action.terminal.sendSequence, when: terminalFocus && terminalShellType == 'cmd', source: built-in.
2024-08-19 14:10:20.279 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: Backspace, keyCode: 8, key: Backspace
2024-08-19 14:10:20.279 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: Backspace, keyCode: 1 ('Backspace')
2024-08-19 14:10:20.280 [info] [KeybindingService]: | Resolving ctrl+Backspace
2024-08-19 14:10:20.280 [info] [KeybindingService]: \ From 3 keybinding entries, matched workbench.action.terminal.sendSequence, when: terminalFocus && terminalShellType == 'cmd', source: built-in.
2024-08-19 14:10:20.280 [info] [KeybindingService]: + Invoking command workbench.action.terminal.sendSequence.
2024-08-19 14:10:20.351 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-08-19 14:10:20.351 [info] [KeybindingService]: | Resolving ctrl+Backspace
2024-08-19 14:10:20.351 [info] [KeybindingService]: \ From 3 keybinding entries, matched workbench.action.terminal.sendSequence, when: terminalFocus && terminalShellType == 'cmd', source: built-in.
2024-08-19 14:10:20.374 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-08-19 14:10:20.375 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2024-08-19 14:10:20.375 [info] [KeybindingService]: + Ignoring single modifier ctrl due to it being pressed together with other keys.

If you need me to test anything, I'll gladly do it.

@meganrogge  Hey megan,  was this completed though? I can still reproduce this on the latest 1.95.2 version.


Consistently handle build and imports in cosmos/init.py

While reviewing #1153, I noticed we were inconsistent with Build operators, especially how we import and expose them in Cosmos __init__.py This PR addresses this.
These were the changes introduced:

Add DbtBuildAzureContainerInstanceOperator
Expose the build operators for all execution modes in Cosmos __init__ (missing for most, except ExecutionMode.LOCAL)
Be consistent with import error messages in __init__ (we were missing AWS EKS)

Thanks for the light-of-speed review, @pankajastro !

It's not in this PR, but @tatiana, do you think it makes sense to add a script in the pre-commit to check the class from the constant and operator module included in the init file?
Yes, I believe that it makes sense to automate the check for imports, I logged a ticket so we don't forget this: #1216

In the mid-long term, I'd love to stop this practice of having everything exposed in cosmos/__init__.py. People could just import them from other locations. I logged a ticket for this: #1213


Support for VM publishing

Added support for publishing previously replicated images

I have updated the command. By default publish does what the name says it publishes but with the option --private or --msdn you can limit the scope


mapping quality

Hi,
May I know the formula of mapping quality in sam. I wonder how to calculate this value, and the threshold of high mapping quality.
Thanks.

Every mapper does it slightly differently. It is basically representing the edit distance between the first and 2nd best alignment of a read. There is greater detail in the SAM documentation I think.
https://genome.sph.umich.edu/wiki/Mapping_Quality_Scores
Typical thresholds are either 10+ or 20+ depending on how much you want to filter.
For NGM MQ=0 is saying that its not a unique mapping read. MQ1-5 says its unique mapping but there might be a 2nd alignment that is just different by 1-2 bp.
Hope that helps
Fritz


Fixed the threading issue

Reuse of a single thread pool
This closes https://github.com/zalando/baigan-config/issues/13 and requires https://github.com/zalando/baigan-config/pull/12

:+1:


EF migrations not working with access token

While the approach described works fine in regular code EF tooling seems to be buggy. When running update-database the following error is generated:

"This operation requires a connection to the 'master' database. Unable to create a connection to the 'master' database because the original database connection has been opened and credentials have been removed from the connection string. Supply an unopened connection."

even if the connection string contains Persist Security Info=True;
And it seems empty initializer is ignored (Database.SetInitializer<MyContext>(null);) , why?
System.InvalidOperationException: This operation requires a connection to the 'master' database. Unable to create a connection to the 'master' database because the original database connection has been opened and credentials have been removed from the connection string. Supply an unopened connection. ---> System.Data.SqlClient.SqlException: Login failed for user ''.
   at System.Data.SqlClient.SqlInternalConnectionTds..ctor(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, SqlCredential credential, Object providerInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString userConnectionOptions, SessionData reconnectSessionData, DbConnectionPool pool, String accessToken, Boolean applyTransientFaultHandling, SqlAuthenticationProviderManager sqlAuthProviderManager)
   at System.Data.SqlClient.SqlConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions)
   at System.Data.ProviderBase.DbConnectionFactory.CreatePooledConnection(DbConnectionPool pool, DbConnection owningObject, DbConnectionOptions options, DbConnectionPoolKey poolKey, DbConnectionOptions userOptions)
   at System.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
   at System.Data.ProviderBase.DbConnectionPool.UserCreateRequest(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
   at System.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at System.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at System.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)
   at System.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at System.Data.ProviderBase.DbConnectionClosed.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at System.Data.SqlClient.SqlConnection.TryOpenInner(TaskCompletionSource`1 retry)
   at System.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry)
   at System.Data.SqlClient.SqlConnection.Open()
   at System.Data.Entity.Infrastructure.Interception.DbConnectionDispatcher.<Open>b__36(DbConnection t, DbConnectionInterceptionContext c)
   at System.Data.Entity.Infrastructure.Interception.InternalDispatcher`1.Dispatch[TTarget,TInterceptionContext](TTarget target, Action`2 operation, TInterceptionContext interceptionContext, Action`3 executing, Action`3 executed)
   at System.Data.Entity.Infrastructure.Interception.DbConnectionDispatcher.Open(DbConnection connection, DbInterceptionContext interceptionContext)
   at System.Data.Entity.SqlServer.SqlProviderServices.<>c__DisplayClass33.<UsingConnection>b__32()
   at System.Data.Entity.SqlServer.DefaultSqlExecutionStrategy.<>c__DisplayClass1.<Execute>b__0()
   at System.Data.Entity.SqlServer.DefaultSqlExecutionStrategy.Execute[TResult](Func`1 operation)
   at System.Data.Entity.SqlServer.DefaultSqlExecutionStrategy.Execute(Action operation)
   at System.Data.Entity.SqlServer.SqlProviderServices.UsingConnection(DbConnection sqlConnection, Action`1 act)
   at System.Data.Entity.SqlServer.SqlProviderServices.UsingMasterConnection(DbConnection sqlConnection, Action`1 act)
   --- End of inner exception stack trace ---
   at System.Data.Entity.SqlServer.SqlProviderServices.UsingMasterConnection(DbConnection sqlConnection, Action`1 act)
   at System.Data.Entity.SqlServer.SqlProviderServices.CreateDatabaseFromScript(Nullable`1 commandTimeout, DbConnection sqlConnection, String createDatabaseScript)
   at System.Data.Entity.SqlServer.SqlProviderServices.DbCreateDatabase(DbConnection connection, Nullable`1 commandTimeout, StoreItemCollection storeItemCollection)
   at System.Data.Entity.Core.Common.DbProviderServices.CreateDatabase(DbConnection connection, Nullable`1 commandTimeout, StoreItemCollection storeItemCollection)
   at System.Data.Entity.Core.Objects.ObjectContext.CreateDatabase()
   at System.Data.Entity.Migrations.Utilities.DatabaseCreator.Create(DbConnection connection)
   at System.Data.Entity.Migrations.DbMigrator.EnsureDatabaseExists(Action mustSucceedToKeepDatabase)
   at System.Data.Entity.Migrations.Infrastructure.MigratorBase.EnsureDatabaseExists(Action mustSucceedToKeepDatabase)
   at System.Data.Entity.Migrations.DbMigrator.Update(String targetMigration)
   at System.Data.Entity.Migrations.Infrastructure.MigratorBase.Update(String targetMigration)
   at System.Data.Entity.Migrations.Design.ToolingFacade.UpdateRunner.RunCore()
   at System.Data.Entity.Migrations.Design.ToolingFacade.BaseRunner.Run()

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 31b0d33c-f88e-d50c-2926-7933940f3b92
Version Independent ID: 4aaef906-f501-6947-5d23-1b704470f09d
Content: Secure SQL Database connection with managed identity - Azure App Service
Content Source: articles/app-service/app-service-web-tutorial-connect-msi.md
Service: app-service-web
GitHub Login: @cephalin
Microsoft Alias: cephalin

@MicahMcKittrick-MSFT @cephalin - please can we reopen this one. I am running to problems with automatic migrations using MSI / access token - and I can't see a solution anywhere in this thread.

@tomgallard @sergey-netdev this doc has been updated to use an Azure AD user as the admin, which, along with the new AppAuthentication version, allows for direct connectivity from VS, including EF migrations. #please-close


increase barrier for available profiles to be ready

Co-authored-by: Daniel Imms<EMAIL_ADDRESS>
This PR fixes #138999

tests are failing


Add support for Claude 3 Haiku

Overview
This PR adds support for the new Anthropic model Claude 3 Haiku.
References

https://www.anthropic.com/news/claude-3-haiku
https://docs.anthropic.com/claude/reference/messages_post

My pleasure!


Provide rapid/fast/slow (in addition to average and custom) options in actionsheet for transaction confirmation

Closes #2242

Fetch and show gas estimates from https://www.gasnow.org/api/v3/gas/price
Show informational footer about gas fee in configure gas/nonce screen

Before PR
After PR

Thanks!


Modular mobile menu fix

Change base html twig to use header_navigation block with tree: true for mobile-menu.  This allows modular one-page sites to have a working menu on mobile.

It's been our opinion that on mobile it really doesn't make sense to show the on-page menu links as they swiping is just such a simple process on mobile.  At least compared to going to hamburger, and then clicking something.  Also modular is often used in more complex sites, where navigation needs to focus on those other pages.


Toolbar is not shown

supportActionBar is not being shown. Here is options:
CropImageOptions(
imageSourceIncludeCamera = includeCamera,
imageSourceIncludeGallery = includeGallery,
guidelines = CropImageView.Guidelines.ON_TOUCH,
fixAspectRatio = true,
aspectRatioX = 4,
aspectRatioY = 3,
activityTitle = "activityTitle",
cropMenuCropButtonTitle = "cropMenuCropButtonTitle",
backgroundColor = colorCompat(R.color.color_black),
toolbarColor = colorCompat(R.color.textBrand),
toolbarTintColor = colorCompat(R.color.textBrand)
)
Am I missing some parameter in options?

any uck bro?

Please have a look at the sample app.

@vanniktech Atleast Add some example to roll own activity. Also Add disclaimer in notes with Bold Letters. I wasted 2 hours for this. Because I am using No Action bar Activity Theme in App. Now these days all the devs using this practice.


Fix (mux-player-react): missing token props (#821)

Add missing playbackToken, thumbnailToken and storyboardToken to MuxPlayer react component.

Hi @mmvsk -- good eye.
<MuxPlayer /> the React component actually has a tokens prop that takes an object: { playback: string; thumbnail: string; storyboard: string; }
Since React allows for setting objects as props, this felt like a cleaner API compared to the web component which requires attribute values to be strings. That's why we went with:
Web component:
<!-- web component -->
<mux-player
  playback-token="eyJhbGciOiJSUzI1NiI..."
  thumbnail-token="eyJhbGciOiJSUzI1N..."
  storyboard-token="eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCIsI..."
  ></mux-player>

React:
// React component
<MuxPlayer
  tokens={{
    playback: "eyJhbGciOiJSUzI1NiI...",
    thumbnail: "eyJhbGciOiJSUzI1N...",
    storyboard: "eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCIsI...",
  }}
/>

Sidenote for the web component usage:, when using the <mux-player> HTMLL element, it exposes a similar property in Javascript where the tokens= value can be set to an object:
// web component
const muxPlayer = document.querySelector("mux-player");
muxPlayer.tokens = {
  playback: "eyJhbGciOiJSUzI1NiI...",
  thumbnail: "eyJhbGciOiJSUzI1N...",
  storyboard: "eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCIsI...",
};

We have an example here in the docs
If you have a suggestion for where we could better document this, please let me know! Closing b/c this is the intended behavior -- thank you for the PR though, appreciate the effort!

That's right, I totally missed the relevant part in the docs.
Now I see, it's pretty clear :)


Add RedisProvider

This provider feels a bit complex compared to the other providers in the project. This is partly because I'm supporting multiple use models: with or without in-memory caching and with or without the ReJSON module. Additionally, I must confess it's been a while since I've written JavaScript, so it's possible that the code could be simplified or made to be more idiomatic. I'm very open to suggestions.
I have attempted to include ancillary project assets like docs and linking the provider into index.js and index.d.ts. Again, very open to input/suggestions.
Thanks much for considering this contribution.

If you haven't already, you might want to look into using ioredis - its commands support both callbacks and native Promises, meaning you shouldn't have to rely as much on promisify.

@Alcremie I picked the library that appears to be suggested by RedisLabs. Even if it's slightly harder to use, it is likely to work when Redis changes stuff and since our provider is very simple it seemed reasonable.

i need this.


chore: update gas prices (ECO 918)

This PR updates the gas price configurations for the localnet, stargateworld, andromeda, and mainnet to match the "average" price that was set in our keplr fork's gas prices config.
I have not been able to test these changes as it seems that a Ledger device is required to operate an account in the app (and I don't currently have one).

Seems all good, just sharing the tx so you can double-check the numbers:
This is with actual gas settings (0.02):

https://explore-capricorn.fetch.ai/transactions/CAAC9977A2750863A74A6F061C62FB2EAE14BB0BA2024B5D040DA463FBB6CB12

This is with updated price<PHONE_NUMBER>):

https://explore-capricorn.fetch.ai/transactions/1323DFEC4AD3474531F42FEE4BF7BB3AE90F5A435A8CB5E3FAF34E08392789D6

Now, these settings files here are just configs for local tests so we can merge it without any issues. I did also create the missing  Capricorn settings over https://github.com/fetchai/cosmos-explorer/pull/147.
So the next step I guess is to set this in the helm charts so we can deploy it on Capricorn testnet & mainnet (don't bother with Stargateworld and Andromeda, they'll go down in a near future I guess)


68decode uri

closes #68 and #63

Decoding unicode with JSON.parse and catching errors if JSON is not valid
Increased test coverage by passing in request object to getResults

Coverage increased (+1.1%) to 98.969% when pulling b6ef61e3a6752c08127f831672e640aae0321a55 on 68decodeURI into 0e76d45a2d111abc5bdde4e840247376cdaa06f5 on master.


Test for RC client extra_services field

Description

Motivation

Workflow

⚠⚠ Create your PR as draft
Follow the style guidelines of this project (See how to easily lint the code)
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Once your PR is reviewed, you can merge it! :heart:
Reviewer checklist

[ ] Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
[ ] CI is green

[ ] If not, failing jobs are not related to this change (and you are 100% sure about this statement)

[ ] if any of build-some-image label is present

is the image labl have been updated ?
just before merging, locally build and push the image to hub.docker.com

[ ] if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

Don't worry about the conflict, I'll handle it before doing the review

Don't worry about the conflict, I'll handle it before doing the review

Too late! (Well, needed to do it to get the CI to run).


⚠ St. Lawrence Global Observatory CKAN Sitemap has degraded performance

In 58c98e9, St. Lawrence Global Observatory CKAN Sitemap (https://catalogue.ogsl.ca/sitemap/sitemap-1.xml) experienced degraded performance:

HTTP code: 200
Response time: 8813 ms

Resolved: St. Lawrence Global Observatory CKAN Sitemap performance has improved in 7647a4f after 25 minutes.


Deleting rows from customToolbarSelect

In discussing the original implementation of the customToolbarSelect property (#49), @gregnb gives the example of using customToolbarSelect and adding a DeleteIcon to the custom toolbar to continue supporting deleting rows. The example goes on to show a handleClick, but not actually the deleting of the rows.
Beyond either manually modifying the data as a property (which would reinitialize the table removing current filters/page number, or creating a ref and updating the state through that (using setTableData as is done in the selectRowsDelete method now and manually triggering the onRowsDelete)  I can't delete rows when customToolbarSelect is enabled
Expected Behavior
I should be able to delete rows when customToolbarSelect is selected
Current Behavior
I can't delete rows when customToolbarSelect is selected
Steps to Reproduce (for bugs)

Enable customToolbarSelect
Try to delete rows

Looks like this was also requested on #5 by @JesusADS

for delete row with  customToolbarSelect i did like this...
I have in my index a function
deleteUsers(rowsSelect)
inside I use rowSelect.data.map() in order to modify my original data and set new state
this.setState({ mydata: new_data})
so when i use customToolbarSelect i just pass my function as props in my component
const options = {
     filterType: 'checkbox',
     customToolbarSelect: selectedRows => (
       <MyCustomToolbarSelect
         selectedRows={selectedRows}
         onRowsDelete={this.deleteUsers}
       />
     ),
   }

and inside my component i use like this:
handleClick = () => {
   //console.log('click!', this.props.selectedRows)
   // a user can do something with these selectedRow values

   this.props.onRowsDelete(this.props.selectedRows)

 }

this is what I ended up doing @matteo1976, but since there's a delete prop, would be great to have this baked in.

I'm sorry, but I do not quite understand the code snipplets that @matteo1976 posted (which is supposed to illustrate how this issue can be resolved by ourselves).
Is this.props.onRowsDelete(this.props.selectedRows) the one that passes the selected rows to be deleted, resulting in the deletion?

I tried to do evrything like it was described by @matteo1976 , but it's not working. If I'm perfoming delete then table deletes rows. But on the second call the table is again full with deleted rows.

for delete row with customToolbarSelect i did like this...
I have in my index a function
deleteUsers(rowsSelect)
inside I use rowSelect.data.map() in order to modify my original data and set new state
this.setState({ mydata: new_data})
so when i use customToolbarSelect i just pass my function as props in my component
const options = {
     filterType: 'checkbox',
     customToolbarSelect: selectedRows => (
       <MyCustomToolbarSelect
         selectedRows={selectedRows}
         onRowsDelete={this.deleteUsers}
       />
     ),
   }

and inside my component i use like this:
handleClick = () => {
   //console.log('click!', this.props.selectedRows)
   // a user can do something with these selectedRow values

   this.props.onRowsDelete(this.props.selectedRows)

 }

Please, I don't understand your code. Can I have the full code of the function please

Can someone please give a working example on how to achieve this? I am struggling get this to work

@krisgoks check out the examples folder in this repo. Here's a codesandbox of the selectable rows example, which shows one way of handling row deletion:
https://codesandbox.io/s/muidatatables-custom-toolbar-hv5n9?file=/index.js

Has this been solved by anyone? I can't seem to figure it out. I have tried to have the data in a state variable passed to the MuiDataTable, but when I update it, the table stays the same.

It's pretty easy. Thank you @patorjk for pointing it out.  This is what I did:
const [tableData,setTableData] = useState([]);
. . .

function deleteSelectedRows(selectedRows) {
    // Collect all row indicies from selected rows.
    const indexesToDelete = selectedRows.data.map((row, k) => row.dataIndex);
   // Create a temp list and insert data that are not in selected rows.
    let temp = [];
    for (var i = 0; i < data.length; i++) {
      if (!indexesToDelete.includes(i)) {
        temp.push(tableData[i]);
      }
    }
    // Set table
    setTableData(temp);
 }

For those of you still experiencing this issue, you can use my fork which exposes the onRowsDelete method. You can include it from npm: https://www.npmjs.com/package/@amovsesy/mui-datatables.


Add SassDoc

Add SassDoc to the project.
http://sassdoc.com/

Closed until I decide to create a cool sassdoc theme.


Allow running job in gurobi environment

I would like to run a gurobi job in an environment that I configure rather than the default environment.
Currently I dont believe there is a way to pass either configuration for the environment or an environment itself.
I have two reasons I want to do this.

I would like to take the COMPUTESERVER parameter from the envornment rather than use a gurobi.lic file.
I would like to run multiple jobs in parallel, but gurobi environments are not thread safe.

For me I would be happy with either a new option grb_create_new_env, I dont really care about reusing envs, or a new option grb_env where I can pass the gurobi env I already created straight down.
Happy to implement this and raise a PR once an approach is agreed.
https://github.com/PyPSA/linopy/blob/8f8682bb50f94bee742aca655aadc38532787c89/linopy/solvers.py#L551C1-L551C1

hey @dannyopts, this seems to be very much related but not fully solved (as far as I can see) by #162. Perhaps you could build up on this? The easiest approach would be to allow passing an env keyword argument via the solver_options, i.e. using something like this:

def run_gurobi(
    model,
    io_api=None,
    problem_fn=None,
    solution_fn=None,
    log_fn=None,
    warmstart_fn=None,
    basis_fn=None,
    keep_files=False,
    **solver_options,
):
    # ... (existing code)

    with solver_options.get('env') or gurobipy.Env() as env:
        # ... (existing code)

perhaps @tgi-climact has one more thought about this?

@FabianHofmann @dannyopts Sounds good to me !

solved by #162 (please reopen, if that is not correct)


Error during unshare(CLONE_NEWUSER): Invalid argument

Error
The following error occurs when we execute the task defined hereafter on openshift
Error during unshare(CLONE_NEWUSER): Invalid argument
--
  | User namespaces are not enabled in /proc/sys/user/max_user_namespaces.
  | time="2019-05-22T12:21:37Z" level=error msg="error parsing PID "": strconv.Atoi: parsing "": invalid syntax"
  | time="2019-05-22T12:21:37Z" level=error msg="(unable to determine exit status)"

Task executed
    - # Build a Container image using the dockerfile created previously
      name: build
      image: quay.io/openshift-pipeline/buildah:testing
      command:
        - buildah
      args:
        - bud
        - --layers
        - --tls-verify=${inputs.params.verifyTLS}
        - -f
        - Dockerfile
        - -t
        - ${outputs.resources.image.url}
        - /sources
      volumeMounts:
        - name: libcontainers
          mountPath: /var/lib/containers
        - name: generatedsources
          mountPath: /sources

Steps to configure Openshift's security
oc adm policy add-scc-to-group anyuid system:authenticated
oc adm policy add-scc-to-user anyuid system:serviceaccount:build-bot:tekton-pipelines-controller

@vdemeester you have any insight into this error? :innocent:

@cmoulliard buildah needs privileged for now (in SecurityContext) (or needs enviroment variable to be set-up BUILDAH_ISOLATION=chroot, and STORAGE_DRIVER=vfs). We are working on that with the runtime team, but, anyway this has nothing to do with Tekton, it's a buildah+containers issue.
/close


Issue with insert

I think there is an issue with insert.
https://github.com/jprochazk/uecs/blob/5d56d2a1fb1cc9e6178a4800d8097b55adf11064/src/world.ts#L85
if (entity > this.entitySequence) this.entitySequence = entity + 1; should be if (entity >= this.entitySequence) this.entitySequence = entity + 1;
Currently if we call a create after an insert, the create will have the same id than the last insert.

Thank you for reporting this. I published 0.4.2 with the fix.


Is it possible to hook up some more /sys/class locations

I wanted to use WSL 2 for developing in C++ on Windows 10. But I have found its not working like a full Linux Distro. I have upgraded to Ubuntu 19.10 server on WSL 2 but found it missing /sys/class folders.
I would like to be able to test and use "/sys/class/thermal/thermal_zone0/temp" to read the CPU temperature. I assumed WSL 2 would work exactly the same as Ubuntu 19.10.
Unfortunately it means I will need to use a real Linux box.

Hi @sfoxover
Did you find a way to do this?

This has not been fixed in WSL2, I am running Ubuntu 22.04 on WSL2 and do not have thermal_zone folders in /sys/class/thermal:

I'm running Debian (bullseye) on WSL2 and also do not have thermal_zone folders in sys/class/thermal :


How many Sols should you get as a minimum?

I got an i7 - 3820 with hyperthreading mining on 7 cores and a R9 290 GPU.
Right now I'm mining with 27 sols in total and my GPU seems to be quite relaxed about it.
Is this a good amount of Sols for my gear or could I squeeze out way more juice than this?

It went up to 32 sols by itself. I figure that this is about the limit of my GPU?

Issue related to older version.
Closing...


[BUG] ServiceBusMessageBatch does not preserve message order reliably

Describe the bug
When the ServiceBusMessageBatch class is used to send batches of ServiceBus messages, the order of adding the messages to the ServiceBusMessageBatch object is not reliably the order the messages are added to the destination queue.
Exception or Stack Trace
Add the exception log and stack trace if available
To Reproduce
It was confirmed by testing and comparing the resulting order of the messages on the queue.  When not using ServiceBusMessageBatch the send order was reliably the message order on the queue, but when using ServiceBusMessageBatch the order was frequently not preserved, leading to erroneous processing by the received.
Code Snippet
I have a simple wrapper around the ServiceBus client that enable switching between batched sends and un-batched sends - the actual send method looks like this:
void sendMessage(ServiceBusMessage serviceBusMessage){
if(!batchingEnabled) {
log.trace("Send single service bus messages to {}", getNameQualifier());
senderClient.sendMessage(serviceBusMessage);
} else {
if(!serviceBusMessageBatch.get().tryAddMessage(serviceBusMessage)){
flush();
if(!serviceBusMessageBatch.get().tryAddMessage(serviceBusMessage)){
String msg = String.format("Unable to add SB message to batch - too large - %d?", serviceBusMessage.getBody().toBytes().length);
ServiceBusSink.this.senderClient = null;
throw new RuntimeException(msg);
}
}
}
}
Expected behavior
Batches of messages assembled using ServiceBusMessageBatch should be written to the destination queue in the order in which they are added to the ServiceBusMessageBatch object.
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):

OS: Linux in K8S Container
IDE: n/a
Library/Libraries: com.azure:azure-messaging-servicebus:7.4.2
Java version: 11
App Server/Environment: AKS Pod
Frameworks: Micronaut,

If you suspect a dependency version mismatch (e.g. you see NoClassDefFoundError, NoSuchMethodError or similar), please provide

verbose dependency tree (mvn dependency:tree -Dverbose)

Additional context
Add any other context about the problem here.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[ X] Bug Description Added
[ X] Repro Steps Added
[ X] Setup information Added

@ki1729 can you please give an update?

Sure Josh,  the fix for this causes a significant hit in performance, but giveth that this is a fix and not a perf enhancement, will be going ahead with it.  This fix should be done and hopefully be out in the Jan release of the sdk

Has there been any progress on this issue?


[select2 4.0.0-beta3] Display a link to add a new item if no results are found

In previous versions, the formatNoMatches option could be used to provide a link to add a new item if no matches were found:
formatNoMatches: function(term) {
  return "Add New Item";
 }

However when trying to replicate this using 4.0-beta3's new languages.noResults function:
language: {
  noResults: function() {
    return "Add New Item";
 }
}

the raw unformatted string appears in the dropdown, rather than a link. Manually creating a DOM object in the function and returning that also doesn't work, though I wouldn't really expect it to. Is there another way to achieve this functionality in 4.0?  Thanks.

I've updated the code to allow for HTML to be passed back from the language options, but keep in mind that it is passed through escapeMarkup.
You can get around this by building it out as a jQuery object and passing that back, or by overriding escapeMarkup to be a no-op.

Awesome, thanks for quick response!

Hey ,
Can you pls explain how can I customise ' No results found' to a link like ' Add Item'?

@JayatiTehri use language->noResults and escapeMarkup options to customice the no result text. ;-)
$('select').select2({
     language: {
             noResults: function(term) {
                 return "Add";
            }
     },
    escapeMarkup: function (markup) {
        return markup;
    }
});

Where can I found documentation about those functions? I didn't find anything in the main website.

The general docu for Select2 can be found here.
The language keyword: Internationalization
The code I provided is just a "workaround". It is a combination of a customized "No results" text and the overridden escapeMarkup function to use HTML in the language strings.

Its any workaround to provide a link to add a new item on the top of the results? I need a fixed option so its always available to the user, but I couldn't figure out how to do it. Im using a custom dataAdapter to set some records when the user open the select.

still not working ..  can't get the term entered to use in the formatting of the text

		language: { 			noResults: function (term) { 				return '
' + term + '</dev>' 			} 		}
term is undefined always.
Please fix it ASAP.

@icrm-amusienko : Please open a new issue. This issue has been closed a year ago...

@icrm-amusienko this is how i showing term
language: {
  noResults: function (term) {
    term = event.target.value;
    return 'add item ' + term + ''
  },
  escapeMarkup: function (markup) {
        return markup;
  }
}


Converting response from <IP_ADDRESS> to JSON failed:

Hi
After installation opendtu want start properly.
current.log in attachment
current.log

Well it does not work with the official one, you need to run ahoy or opendtu.

As we'll not be able to help here more, I'll close this. Feel free to open a new issue, if you still have problems when using ahoy or opendtu.


update imbuedfart to 1.2.1

change classloader resource handling to make the plugin actually work again

You absolutely don't need to be using a classloader to get your wav files from resources.

Would love your input for how best to achieve my desired effect if you don't think my current approach is appropriate! :)

Found via internet search for "java load audio file resource": https://stackoverflow.com/a/18709515/540162

This is also described in the plugin-hub readme: https://github.com/runelite/plugin-hub#plugin-resources

https://stackoverflow.com/a/18709515/540162

Prefer getResourceAsStream (wrapped in BufferedInputStream) over getResource, though

Swapped to getResourceAsStream thank you all for assistance

You should also perform Clip#close on plugin shutDown to avoid a resource leak