Multiple choice with commas

https://augur.net/markets/-ef4640dbf34e54d212d59e606c372ed8c0b7f24e14a96acaf40541f9bd41b94e
I entered the multiple choice using the format
Lastname, First Name
ex.
Binay, Jejomar
Poe, Grace
Viewing the market  Poe(28%)  Binay(18%)   Jejomar(18%)
Commas not allowed in multiple choice?

Fixed in 8f2fa8bfc0b65e6efe5d479659a8a49f000adc3c.  The outcomes are now pipe-delimited which (Stack Overflow informs me) is the least-used ASCII character.  (Might be worth making the outcomes separate fields on-contract to avoid this issue altogether.)


Added More Information Section with links

Header for Elm architecture section

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you @svpham29 for your contribution and congratulations on your first PR merge to this repo! 🎉
Hope to see more contributions from you in the future.


2019u2: test_task_arena fails

The test fails with the following output:
sh ../test_summary.sh ./test_task_arena.exe
Warning: So many cases when threads join to different arenas.
Call stack info (7):
./test_task_arena.exe(_Z16print_call_stackv+0x54)[0x55a6ac8581e4]
./test_task_arena.exe(_Z11ReportErrorPKciS0_S0_+0x1b)[0x55a6ac85831b]
./test_task_arena.exe(_Z39TestArenaWorkersMigrationWithNumThreadsi+0xa34)[0x55a6ac85d974]
./test_task_arena.exe(_Z8TestMainv+0x90)[0x55a6ac85e5c0]
./test_task_arena.exe(main+0xe)[0x55a6ac85775e]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb)[0x7f158113109b]
./test_task_arena.exe(_start+0x2a)[0x55a6ac8579fa]
../../src/test/test_task_arena.cpp:1585, assertion *it <= 0.3: A lot of cases when threads join to different arenas.

Kubuntu 18.10, x86_64, Core i7 2600K.

After some deeper investigation, it turns out that this failure is caused by one of our local patches for TBB. I will follow up with a different issue.


Fix: Handle errors caused by invalid hostnames

Fixes #2575
This catches the errors generated by missing or invalid hostnames, logs them, and exits, thereby stopping the "spamming".
The change can also be made in one place by logging and exiting here:  https://github.com/locustio/locust/blob/6ce340bc61624d39e3df5dbfdd3e20def3164638/locust/clients.py#L174-L183
but this seemed like more of a core function and perhaps it makes more sense in other cases to re-raise.
Please feel free to let me know if there's a better approach. We've been using locust at work (thanks) and wanted to contribute.

Thanks for wanting to contribute!
I'm not completely sure this is the best approach. Wrapping every call in a try-except block just in case it fails seems excessive, perhaps it could be caught here instead: https://github.com/locustio/locust/blob/7a966f68988523bb86726e17b187bc81ecdb51f1/locust/user/task.py#L342
... but even then, exiting while a test is running if a request fails due to an invalid URL is a bit harsh. I dont know off hand what is the best way to handle it though.
Oh, and it seems some test cases will need to be updated https://github.com/locustio/locust/actions/runs/8012293307/job/21887280183?pr=2610

Thanks for taking a look. What about simply validating the host value passed via -H or the web UI and show an error message if invalid?

Yes! Sounds great! That is probably the more common problem anyway.

I'll open a new PR with this approach


[backport] Fallback to synchronous transfer if pinned memory could not be allocated

Backport of #1593

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit e06dd997ea01d1d7e1fb16bac0df608205aaed93, target branch v4) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

LGTM!


Miscellaneous minor changes.

What happened?
This PR makes a few minor changes to the backer airdrop PR. Primarily:

introduces a backer-specific grant reason
combines multiple grants belonging to the same address, for more efficient claiming
expands the number of decimal places in grant amounts from the spreadsheet, so that the total GFI awarded by the airdrop sums to the total expected from the spreadsheet

Why?

How has this been tested?

Checklist

[x] I have reviewed this code myself
[ ] Screenshots of the key change are present (if this is a front-end PR)

Replaced by https://github.com/goldfinch-eng/mono/pull/11.


Add TLS support for rkm-outpost connections to InfluxDB

The InfluxDB connections may be TLS encrypted and rkm-outpost must be able to handle custom certificates.

We need to check this again as soon as we rewrite rkm-outpost from Bash to Go.


Increasing the default cc startup timeout for CORS integration tests

In the CORS integration test, the CC startup timeout was 20 seconds,
which we would often see fail on reasonable-enough dev workstations
(MacBook Pros). While running the parallel tests, the system can get under significant load and therefore might not finish doing the CC startup before the timeout.
We've bumped this up to 60 seconds, which seems to make the tests pass more reliably.

[x] I have reviewed the contributing guide

[x] I have viewed, signed, and submitted the Contributor License Agreement

[x] I have made this pull request to the master branch

[x] I have run all the unit tests using bundle exec rake

[n/a] I have run CF Acceptance Tests

Thanks,
SAPI Team (Luis and @jenspinney )

@@Gerg @zrob Since this isn't really services related it would be good if CAPI approves this change.

Seems reasonable to me, thanks @lurraca and @jenspinney!


Remove dlig tags, because sometimes make spelling problems

On branch oldhun-dligs-remove-omly
Changes to be committed:
modified:   src/NotoSansOldHungarian/Noto Sans Old Hungarian GSUB.txt

@marekjez86
Please merge it. If some things is wrong, drop me a message.
It resolve #215, except doesn't prepare "ab" incorrect form.
Thank You

That is the final dlig remover pull request.

Sorry, It have a mistake: not only dlig tags, liga tags don't work, too.


Add script!

Complex cron-script added.

Thank you for your time and interest.
Unfortunately, your PR has not been approved because the "Record ID" in your code need another way to obtain and it may be a problem.
Our colleagues will contact you for a gratitude gift from ArvanCloud.
ArvanCloud wishes you all the best for the future. We are sure that you will soon be approved in one of our future projects.

Thank you for your time and interest.
Unfortunately, your PR has not been approved because the "Record ID" in your code need another way to obtain and it may be a problem.
Our colleagues will contact you for a gratitude gift from ArvanCloud.
ArvanCloud wishes you all the best for the future. We are sure that you will soon be approved in one of our future projects.


Is ide.coder.com shutting down?

When logged into ide.coder.com, there is a message in the top right that "Coder hosted will be ending on May 5th" and a link to self-host.
That date has passed, but for clarification, does that mean existing account holders won't be able to access the hosted installation of code-server in the imminent future? Or does Coder hosted refer to something else?

Yep, it means existing account holders won't be able to access ide.coder.com anymore.
When it happens, you'll be able to contact us to retrieve your files back if you haven't downloaded them already.
I'm not sure exactly when it will happen but I expect soon-ish

Is there likely to be anything hosted offered again?

@BinaryBen There isn't any plan as of this moment for a hosted Coder service.

Why is it shutting down? This is such a good product.

It's hard to run a hosted IDE product like Coder @wadeziegler, while we do have a good premise for a product, the costs to run hosted IDEs are larger than usual apps. To give you an idea, look at how GCP prices VM instances. The reason why people like TypeFox can run because they have large corporate backing already (Red Hat usually for TypeFox), Coder simply don't have that large corporate backing to run such services.


Status Bar background color turns BLACK

My issue is happening in the latest version of SideMenu.
My issue was not solved in the README.
My issue cannot be answered on stackoverflow.com.
My issue is not a request for new functionality that I am unwilling to build and contribute with a pull request.
My issue is reproducible in the demo project.

When the SideMenu is presented, the status bar background color automatically turns black.
I haven't set any status bar background color for my app, still when the side menu is presented, the status bar background color automatically turns black. Please see the screenshot.

You did not read the Readme. It clearly tells you why this happens and what you have to do to change the behavior.

Well, Readme tells why the view controller background color appears black, not the STATUS BAR BACKGROUND COLOR

You could even tell exactly where it is, because there are no troubleshooting guide in the readme.

You could even tell exactly where it is, because there are no troubleshooting guide in the readme.
SideMenuManager.menuFadeStatusBar = false

SideMenuManager.default.menuFadeStatusBar = false


Creating a customised scrollbar

Description
Adding a customised scrollbar in place of default scrollbar

@ShivangamSoni This issue was never assigned to you without that how & why you created PR?

@2024-SANDHYA I suggested this issue on our discord server. Could please assign this issue to me?

2024-SANDHYA Can I work on this issue. Can you please assign it to me


Black screen

Please paste the output of the following command here: sudo edit-chroot -all

name: trusty
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/trusty...
crouton: version 1-20170214182546~master:163e0d26
release: trusty
architecture: amd64
xmethod: xorg
targets: xfce
host: version 9000.82.0 (Official Build) stable-channel peppy
kernel: Linux localhost 3.8.11 #1 SMP Wed Feb 1 15:13:00 PST 2017 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
Unmounting /mnt/stateful_partition/crouton/chroots/trusty...
Please describe your issue:
When i use sudo startxfce4 turns blackscreen, cant acces to linux
If known, describe the steps to reproduce the issue:

Same exact problem, I haven't found a fix yet but working on it

getting same issue i think it was due to the most recent chrome update since i just installed it. On Version 56.0.2924.87 (64-bit) on my toshiba chromebook 2 (2014)

@Jonathan1223 Can you please not write the issue title in capitals. Thanks.
Also if you look at the known issues there are several of them that mention black screen. Did you look at those and see if this is not a duplicate?

@divx118 I did and tried shut down and open again but didnt work

Try installing the xiwi target using the command, sudo sh ~/Downloads/crouton -u -n chrootname -t xiwi. This fixed the black screen issue for me.

See #2923.


Display brightness of intervals in the matrix

Abnormality | positivity arc — Today at 12:46 AM

an option to see brightness for intervals within their scale degree would be nice. color would probably be a good way to do it. you could go blue->red, or maybe blue->yellow(so you can still see cs violations), dividing the colors between into whatever the variety that degree has. here are some concepts i did in google sheets. i did diasem(mv3, and always 3) and blackdye(mv4, sometimes 2, 3 or 4) as examples for light and dark mode. honestly this helps me a lot to analyze stuff. and maybe for colorblindness accessibility you could just have an option for a grayscale version.

https://jiffyclub.github.io/palettable/cubehelix/
0.5deg recommended these color schemes, which ascend in brightness (or perceptual brightness) while using many colors and roughly consistent saturation
I could probably tackle this.


Alternative?

This is not really an issue. But I went through remaking the repo from scratch using newer web technology and features: https://github.com/msqr1/Vosklet. Can I merge some changes over there to here, there are lots of stuff to be improve, as this is getting outdated. @ccoreilly

Hi @msqr1 ! Great initiative :) software evolves and needs to be maintained. I do not have time to dedicate to this repository so it is good that better alternatives surge and gain traction.
I'll have a deeper look at your work later this week. In the end, users decide based on the developer experience and the features of these libraries so I'd be interested on what other users like @Yahweasel or @erikh2000 think.

The core thing I need out of vosk-browser is to not have an AudioContext-level API. I do all of my own audio capturing and ten other layers of processing. Further, although in my own project I do use threads, so SharedArrayBuffer is a nonissue, it's valuable to have a version that runs synchronously, because some users (including myself) manage their own threads. I would rather have a vosk running synchronously with a Worker thread I created on my own than running asynchronously with a Worker thread created by a library. To excessively toot my own horn, my own libav.js allows the user to load it in a synchronous mode, a worker mode, or a threaded mode, and provides the same API in all three.
Basically: I wouldn't mind a more up-to-date vosk adapter, but as stands, your API is too opinionated for me.

You're right, I try to make this as easy to use as possible, just some minimal setup and you can start recognizing. I agree that more features should be added, but for now, I do have an extremely easy, quick, and non-blocking on main thread setup.

@msqr1 I'm interested in your project, but I'm likely to stick with vosk-browser out of inertia and not having any complaints with it. The main thing I saw in Vosklet that I'd like to see in vosk-browser, if practical, is more of the Vosk functions exposed. I had told myself that at some point I'd get vosk-browser building and try to contribute that myself, but I never got around to it.
The faster processing time is intriguing too. What kind of metrics are you seeing?

I didn't really measured it ngl, so maybe i should remove that line. But,  I moved hot computations to c++, I also use a simpler mechanism to communicate between js and c++, I used the faster new emscripten wasmfs, I turned on lto and simd optimization, and many more...

No worries, @msqr1. I don't expect you to be super-scientific in your claims. I was just curious about what kind of speed increase you might be seeing. Your changes for performance seem promising.

Well, the thing is kaldi just refuses to compile with simd off, so I have to turn it on. It may not do anything.

Oh, well that's just lovely X-D

Just curious, how do you use a speech recognition library with your libav project? Isn't that for audio formats?

I do not. I use both in Ennuicastr.

I can make a sync version, I just don't know how it is possible. If you block the current thread to recognize, how do you stop it? Synchronous model and recognizer loading should be easy. I'm not sure about the recognizer loop.

I can make a sync version, I just don't know how it is possible. If you block the current thread to recognize, how do you stop it? Synchronous model and recognizer loading should be easy. I'm not sure about the recognizer loop.

We're on an issue submitted to a synchronous version of the same API ;)

The recognizer,  I can't see how it is synchronous? The only way I can think of is to run it on another thread and send result over.

The API of Vosk just takes a chunk at a time. That API is synchronous.

I get it, but wouldn't that block itself from other action? I can surely add acceptWaveformSync() that recognize (will block) on the same thread, and return the result.

My case is that I have vosk-browser loaded in a Worker thread which is also responsible for echo cancellation, noise suppression, audio metrics, and encoding. Each of these steps takes raw Float32Array audio in and spits raw Float32Array audio out, and I want them all to be synchronous because I'm managing all the threading myself. What I mean when I say that your API is opinionated is that it's doing more than just vosk: it's handling capture, it's handling threading, it's handling formats. For some people, that's presumably very useful. For me, that's actively unhelpful.
Also, to be clear: you should not be writing your code to fit my use case if that doesn't help you in any way. I'm perfectly happy with vosk-browser, and have no urgent need for a more updated version, though as a general principle I'd like for things to be up to date. I'm only presenting my case on this thread because I was asked to.

No, I just want to find out how you use it, because I just want to see what use case would synchronous vosk be needed, so thanks for your information!

My case is that I have vosk-browser loaded in a Worker thread which is also responsible for echo cancellation, noise suppression, audio metrics, and encoding. Each of these steps takes raw Float32Array audio in and spits raw Float32Array audio out, and I want them all to be synchronous because I'm managing all the threading myself. What I mean when I say that your API is opinionated is that it's doing more than just vosk: it's handling capture, it's handling threading, it's handling formats.
No, I just want to find out how you use it, because I just want to see what use case would synchronous vosk be needed, so thanks for your information! The above really helped me learn!

I can be totally precise: https://github.com/ennuicastr/ennuicastr/blob/3b3830fc979b039c245429a5ec7657594af4a705/awp/ennuicastr-worker.ts#L786
There's my call to acceptWaveformFloat :)

I completely understand it now :)))))))

@ccoreilly did you go over it?

FWIW I'd also be interesting in a "updated" alternative that is actively maintained. Yet I would need to better understand in what the alternative is different.
If it is entirely compatible, e.g

does NOT require anything new (i.e works at least on all contexts e.g browsers, servers for hosting wouldn't require SharedArrayBuffer thus secure context, etc),
no new tooling to build,
uses exactly the same interface to program with it,

even without providing any improvement, I would probably be interested.
Yet, if it does have any trade off, e.g breaks compatibility with some context, like older browsers, Chromium only, etc, then IMHO they should be made explicit.

I have Vosklet that i make as an alternative. You would want to check it out @Utopiah!


feat: local tts support

use piper as default.
issue #16

Wow. Neat work. Will test and work on merge after this weekend. Thanks for the contribution.

I'm experiencing some issues with installing Piper on Mac, and I'm still working on resolving them.

@p0n1, I included another example in the README for https://github.com/coqui-ai/TTS, maybe you could try that instead.

Hi @timgreen. I didn't expect that it could support both Coqui and Piper at the same time. That's really cool. I originally planned to test the use of Piper in a Linux environment, without considering the installation issues on Mac. However, my work has been busy lately, so I have to postpone it.
In addition, there are new contributors joining recently. @Bryksin has done a great job and has comprehensively refactored the code to facilitate the future integration of more TTS engines. You can find some discussions here: https://github.com/p0n1/epub_to_audiobook/issues/21#issuecomment-1824987948.
I apologize again for not being able to merge your code in a timely manner. Perhaps it would be better if you could contribute based on the refactored code once it got merged. Or I can help if you don't have the time.
Beside, we have a discord server now for syncing up and any discussion. Feel free to join. You could find the invite url here https://github.com/p0n1/epub_to_audiobook/issues/15#issuecomment-1825854839.

@timgreen I've attempted to build your branch to see if I could get the piper TTS working as I find it far better than Edge_TTS, however when running the command to use --tts local I get the following error
epub_to_audiobook.py: error: argument --tts: invalid choice: 'local' (choose from 'azure', 'openai')
Apologizes if this isn't the correct place to reach out with a question on this.

@EnderSyth, this PR hasn't been merged yet. So you will need to try from my branch: https://github.com/timgreen/epub_to_audiobook/tree/local_tts

@EnderSyth, this PR hasn't been merged yet. So you will need to try from my branch: https://github.com/timgreen/epub_to_audiobook/tree/local_tts

That is the one I cloned
git clone https://github.com/timgreen/epub_to_audiobook.git
It executes via 'epub_to_audiobook.py' which I believe is unique to your branch.
After following the normal build process I used the code example on that Repo
`python3 epub_to_audiobook.py "path/to/book.epub" "path/to/output/folder" --tts local'
But modified to the following for my environment.
python .\epub_to_audiobook.py .\Saved_by_certain.epub .\Test\ --tts local usage: epub_to_audiobook.py [-h] [--tts {azure,openai}] [--log LOG] [--preview] [--language LANGUAGE]                             [--newline_mode {single,double}] [--chapter_start CHAPTER_START]                             [--chapter_end CHAPTER_END] [--output_text] [--remove_endnotes] [--voice_name VOICE_NAME]                             [--break_duration BREAK_DURATION] [--output_format OUTPUT_FORMAT]                             [--openai_model OPENAI_MODEL] [--openai_voice OPENAI_VOICE]                             [--openai_format OPENAI_FORMAT]                             input_file output_folder epub_to_audiobook.py: error: argument --tts: invalid choice: 'local' (choose from 'azure', 'openai')

Timgreen, thanks for your work on this.
Whilst it hasn't been murged yet unfortunately, I've been able to test this branch locally on Linux and it's working well for me so far.
Local tts is something I've been waiting on with this utility and piper is a good choice in my book.
You might not want to spend any more time on this which is completely understandable, although I'm getting a consistent error at the start of a new chapter from piper:
WARNING:piper.download:Wrong size (expected=7010, actual=4885) for /home/daniel/
epub_to_audiobook/en_US-lessac-medium.onnx.json
INFO:piper.download:Downloaded /home/daniel/epub_to_audiobook/en_US-lessac-medium.onnx.json (https://huggingface.co/rhasspy/piper-voices/resolve/v1.0.0/en/en_US/lessac/medium/en_US-lessac-medium.onnx.json)
I'm not sure what's up with this, although everything else is working great.

EnderSyth , make sure to checkout the local_tts branch after cloning the repo

EnderSyth , make sure to checkout the local_tts branch after cloning the repo

Why thank you, I'm new to this so I missed that bit. After doing that indeed I can run it, though now its giving me issues with piper not being a recognized command. I'm trying to figure out how to get that installed but appear to not be able to get pip install piper-tts working due to missing piper-phonemize which also can't be found. But at least I'm one step further thank you.

no problem at all, happy to help.
Are you running python 3.12 by any chance?
I tried to build this on Ubuntu 24.04 and ran into a similar issue, although setting up a venv (virtual environment with python 3.11) fixed it.
Hope this helps.

I'm doing this under WSL on Ubuntu 20.04.6 LTS. I get Python 3.10.11 as the output running python -V.
I saw many posts when looking into the errors about different versions of python causing issues but 3.10 was supposed to be good from what I read.

no problem at all, happy to help. Are you running python 3.12 by any chance? I tried to build this on Ubuntu 24.04 and ran into a similar issue, although setting up a venv (virtual environment with python 3.11) fixed it. Hope this helps.

Well I bite the bullet deleted the venv and decided to redo it with python 3.11, but thanks to WSL I couldn't install Python 3.11...long story short Bing GPT was able to guide me through compiling my own Python 3.11 and somehow it works!
Now I just have to figure out how to change to libritts_r properly. I think I need the --voice_name tag so going to play with that next.

So I didn't see this and just opened a pull request specifically for piper.
See #77
On the one hand it's less generic on the other hand it "maps" parameters like silence and speed directly into piper parameters.
Any suggestions welcome.

This PR is out of date and seems like implemented before major refactoring and project restructurisation.
I will close it soon if it will not be updated

I think this local_tts feature is quite flexible. I might adapt it to the latest code when I'm available.


Updated to add my proposal

Thanks @Nayan-Das, please remember to also create your application on the GSoC website.


Fix typo in flash-messengers.md

Simple typo I noticed while browsing the flash messenger cookbook.

Thank you.


Merge Scripts: Allow for per-episode adjustments of imported files

E.g. if a scene change in the OP is delayed by a few frames in a specific episode, it would be nice if you could still use the same source file for the song, but specify that a given imported line should be timed differently. Currently you would have to save the retimed version of the song to a completely different file and import it instead.
I have no idea how to implement this without breaking the bidirectional nature of Merge Scripts. Would have to first figure out how powerful and how automated these per-episode adjustments should be, and then try to come up with a design that still allows for bidirectional importing and exporting of lines (e.g. how should the timing changes be specified, should the import statement have something to select what lines to use, etc).

This is probably better handled by SubKt.


Ramp up @vrajmohan on cloud.gov

I will fill this in shortly. Will trim down the onboarding tasks since his work will be focused on Masonry/fedramp-templater.

This didn't end up working out, for staffing reasons. Shame!


Return 404s intead of 500s for invalid cluster ids for many endpoints

Not urgent, but let's clean up some of these 500 errors when passing an invalid cluster id (and return 404 Not Found / {"error": "Invalid cluster id, or cluster is unavailable."} instead).

List nodes - curl localhost:9000/explore/clusters/invalid/nodes returns 500
List bucket types - curl localhost:9000/explore/clusters/invalid/bucket_types returns 500
Get bucket type props, invalid cluster - curl localhost:9000/explore/clusters/invalid/bucket_types/default returns 500
Get bucket type jobs, invalid cluster - curl localhost:9000/explore/clusters/invalid/bucket_types/default/jobs returns 500
Get bucket type's buckets, invalid cluster - curl localhost:9000/explore/clusters/invalid/bucket_types/default/buckets returns 500
Get a bucket's jobs - localhost:9000/explore/clusters/invalid/bucket_types/default/buckets/$bucket/jobs - returns 500
Get a bucket's key cache - localhost:9000/explore/clusters/invalid/bucket_types/default/buckets/$bucket/keys returns 500
All the Riak proxy endpoints - localhost:9000/riak/clusters/invalid/... return 500.

Tested, on latest master. Results:
Fixed:

All the Riak proxy endpoints - localhost:9000/riak/clusters/invalid/... - Perfect. Returns 404, with JSON error: {"error":"Node is not running."}.
List nodes - curl localhost:9000/explore/clusters/invalid/nodes now returns 404 (though with an HTML 'not found', rather than a JSON error).
Get bucket type's buckets, invalid cluster - curl localhost:9000/explore/clusters/invalid/bucket_types/default/buckets now returns 404 (though with an HTML 'not found', rather than a JSON error).
Get a bucket's key cache - localhost:9000/explore/clusters/invalid/bucket_types/default/buckets/$bucket/keys now returns 404 (though with an HTML 'not found', rather than a JSON error).

Not quite fixed:

Get bucket type jobs, invalid cluster - curl localhost:9000/explore/clusters/invalid/bucket_types/default/jobs returns a 200 OK, with an empty jobs list. Should probably still be a 404 with the json error.
Get a bucket's jobs - localhost:9000/explore/clusters/invalid/bucket_types/default/buckets/$bucket/jobs - returns a 200 OK, with an empty jobs list. Should probably still be a 404 with the json error.

Still returns 500:

List bucket types - curl localhost:9000/explore/clusters/invalid/bucket_types returns 500
Get bucket type props, invalid cluster - curl localhost:9000/explore/clusters/invalid/bucket_types/default returns 500

Ok, I've addressed your comments.

Perfect, all fixed.

curl localhost:9000/riak/clusters/invalid/ping -> 404 Not Found, {"error":"Cluster doesn't exist."}
curl localhost:9000/explore/clusters/invalid/nodes -> 404 Not Found, {"error":"Cluster doesn't exist."}
curl localhost:9000/explore/clusters/invalid/bucket_types/default/buckets -> 404 Not Found, {"error":"Cluster doesn't exist."}
curl localhost:9000/explore/clusters/invalid/bucket_types/default/buckets/users/keys -> 404 Not Found, {"error":"Cluster doesn't exist."}
curl localhost:9000/explore/clusters/invalid/bucket_types/default/jobs -> 404 Not Found, {"error":"Cluster doesn't exist."}
curl localhost:9000/explore/clusters/invalid/bucket_types/default/buckets/users/jobs -> 404 Not Found, {"error":"Cluster doesn't exist."}
curl localhost:9000/explore/clusters/invalid/bucket_types  -> 404 Not Found, {"error":"Cluster doesn't exist."}
curl localhost:9000/explore/clusters/invalid/bucket_types/default -> 404 Not Found, {"error":"Cluster doesn't exist."}

Closing.


Update serverlist.json

MonsterLyrics Server with new link to welcome page.

Static serverlist is no longer used.
Submit your server at DiscordServers.com


Increase PackageIdentifier segments to max 8

null
Microsoft Reviewers: Open in CodeFlow

Maybe we need to review the PR build rules and include a build when these schema files change.  While they don't affect the client in most cases, there are some and there are tests that will cover those.

/azp run


Prevent the alternative route (-new)

Someone can create (and reserve) the alternative route required for blue-green deployment: "<original_app_route>-new", thus compromising blue-green deployment (since the routes are unique per landscape).
My proposal is to skip removing of the route after smoke test execution and only unbind it from the application. This way the alternative route will be reserved too for any future blue-green deployment, preventing any malicious software to reserve it and compromise blue-green deployment. Or at least there should be parameter to control this, similar to --keep-old-apps

dallashudgens did you find solution for this?


Update README.md

Module is now deprecated. Drupal modules now found on drupal.org.

Replaced by:  https://www.drupal.org/project/byu_academic_calendar


test_ForceDependentSlip  failure with libode==0.16.2==*_13

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
After the new build of libode that uses libccd (see https://github.com/conda-forge/libode-feedstock/pull/22), now the dart's test test_ForceDependentSlip fails, see https://github.com/conda-forge/dartsim-feedstock/pull/61/checks?check_run_id=22760346822 and https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=897543&view=logs&jobId=47084397-e614-5090-05b8-c04ebacb88b9 .
Installed packages
.

Environment info
.

Example failure log:
2024-03-17T21:58:52.3326856Z       Start 34: test_ForceDependentSlip
2024-03-17T21:58:52.6935278Z 34/71 Test #34: test_ForceDependentSlip ...........***Failed    0.36 sec
2024-03-17T21:58:52.7013219Z Running main() from $SRC_DIR/unittests/gtest/src/gtest_main.cc
2024-03-17T21:58:52.7061822Z [==========] Running 2 tests from 1 test case.
2024-03-17T21:58:52.7069568Z [----------] Global test environment set-up.
2024-03-17T21:58:52.7070630Z [----------] 2 tests from ForceDependentSlip
2024-03-17T21:58:52.7102803Z [ RUN      ] ForceDependentSlip.BoxSlipVelocity
2024-03-17T21:58:52.7103255Z [       OK ] ForceDependentSlip.BoxSlipVelocity (222 ms)
2024-03-17T21:58:52.7103572Z [ RUN      ] ForceDependentSlip.CylinderSlipVelocity
2024-03-17T21:58:52.7103874Z $SRC_DIR/unittests/integration/test_ForceDependentSlip.cpp:265: Failure
2024-03-17T21:58:52.7104532Z The difference between extForceX * slip and body1->getLinearVelocity().x() is 0.00043832661683589763, which exceeds 1e-4, where
2024-03-17T21:58:52.7104981Z extForceX * slip evaluates to 0.02,
2024-03-17T21:58:52.7105347Z body1->getLinearVelocity().x() evaluates to 0.020438326616835898, and
2024-03-17T21:58:52.7105654Z 1e-4 evaluates to 0.0001.
2024-03-17T21:58:52.7105918Z $SRC_DIR/unittests/integration/test_ForceDependentSlip.cpp:266: Failure
2024-03-17T21:58:52.7106350Z The difference between 0.0 and body1->getLinearVelocity().y() is 0.005297929413959148, which exceeds 1e-4, where
2024-03-17T21:58:52.7106629Z 0.0 evaluates to 0,
2024-03-17T21:58:52.7107069Z body1->getLinearVelocity().y() evaluates to 0.005297929413959148, and
2024-03-17T21:58:52.7107376Z 1e-4 evaluates to 0.0001.
2024-03-17T21:58:52.7107631Z $SRC_DIR/unittests/integration/test_ForceDependentSlip.cpp:280: Failure
2024-03-17T21:58:52.7108200Z The difference between 0.0 and body2->getLinearVelocity().y() is 0.001254381120491032, which exceeds 1e-4, where
2024-03-17T21:58:52.7108591Z 0.0 evaluates to 0,
2024-03-17T21:58:52.7109367Z body2->getLinearVelocity().y() evaluates to 0.001254381120491032, and
2024-03-17T21:58:52.7109870Z 1e-4 evaluates to 0.0001.
2024-03-17T21:58:52.7110323Z $SRC_DIR/unittests/integration/test_ForceDependentSlip.cpp:265: Failure
2024-03-17T21:58:52.7111077Z The difference between extForceX * slip and body1->getLinearVelocity().x() is 0.00035668589428858657, which exceeds 1e-4, where
2024-03-17T21:58:52.7111420Z extForceX * slip evaluates to 0.02,
2024-03-17T21:58:52.7112755Z body1->getLinearVelocity().x() evaluates to 0.020356685894288587, and
2024-03-17T21:58:52.7113109Z 1e-4 evaluates to 0.0001.
2024-03-17T21:58:52.7113539Z $SRC_DIR/unittests/integration/test_ForceDependentSlip.cpp:266: Failure
2024-03-17T21:58:52.7113959Z The difference between 0.0 and body1->getLinearVelocity().y() is 0.0043113150438673625, which exceeds 1e-4, where
2024-03-17T21:58:52.7114245Z 0.0 evaluates to 0,
2024-03-17T21:58:52.7114716Z body1->getLinearVelocity().y() evaluates to 0.0043113150438673625, and
2024-03-17T21:58:52.7123500Z 1e-4 evaluates to 0.0001.
2024-03-17T21:58:52.7123884Z $SRC_DIR/unittests/integration/test_ForceDependentSlip.cpp:279: Failure
2024-03-17T21:58:52.7124482Z The difference between mass * accel.x() * slip and spinVel - linVel is 0.00048835745446274004, which exceeds 2e-4, where
2024-03-17T21:58:52.7124812Z mass * accel.x() * slip evaluates to 0.026508948770409546,
2024-03-17T21:58:52.7125413Z spinVel - linVel evaluates to 0.026997306224872286, and
2024-03-17T21:58:52.7126092Z 2e-4 evaluates to 0.00020000000000000001.
2024-03-17T21:58:52.7128069Z $SRC_DIR/unittests/integration/test_ForceDependentSlip.cpp:280: Failure
2024-03-17T21:58:52.7128526Z The difference between 0.0 and body2->getLinearVelocity().y() is 0.0013606856166480091, which exceeds 1e-4, where
2024-03-17T21:58:52.7128959Z 0.0 evaluates to 0,
2024-03-17T21:58:52.7135293Z body2->getLinearVelocity().y() evaluates to -0.0013606856166480091, and
2024-03-17T21:58:52.7135836Z 1e-4 evaluates to 0.0001.
2024-03-17T21:58:52.7136113Z $SRC_DIR/unittests/integration/test_ForceDependentSlip.cpp:265: Failure
2024-03-17T21:58:52.7136553Z The difference between extForceX * slip and body1->getLinearVelocity().x() is 0.00024724163885008962, which exceeds 1e-4, where
2024-03-17T21:58:52.7136863Z extForceX * slip evaluates to 0.02,
2024-03-17T21:58:52.7137190Z body1->getLinearVelocity().x() evaluates to 0.02024724163885009, and
2024-03-17T21:58:52.7137491Z 1e-4 evaluates to 0.0001.
2024-03-17T21:58:52.7137751Z $SRC_DIR/unittests/integration/test_ForceDependentSlip.cpp:266: Failure
2024-03-17T21:58:52.7138178Z The difference between 0.0 and body1->getLinearVelocity().y() is 0.002784063048611347, which exceeds 1e-4, where
2024-03-17T21:58:52.7138454Z 0.0 evaluates to 0,
2024-03-17T21:58:52.7138773Z body1->getLinearVelocity().y() evaluates to 0.002784063048611347, and
2024-03-17T21:58:52.7139058Z 1e-4 evaluates to 0.0001.
2024-03-17T21:58:52.7139330Z $SRC_DIR/unittests/integration/test_ForceDependentSlip.cpp:280: Failure
2024-03-17T21:58:52.7139749Z The difference between 0.0 and body2->getLinearVelocity().y() is 0.0012537817663281056, which exceeds 1e-4, where
2024-03-17T21:58:52.7140024Z 0.0 evaluates to 0,
2024-03-17T21:58:52.7140352Z body2->getLinearVelocity().y() evaluates to 0.0012537817663281056, and
2024-03-17T21:58:52.7140643Z 1e-4 evaluates to 0.0001.
2024-03-17T21:58:52.7140910Z $SRC_DIR/unittests/integration/test_ForceDependentSlip.cpp:265: Failure
2024-03-17T21:58:52.7141340Z The difference between extForceX * slip and body1->getLinearVelocity().x() is 0.00011317467529363065, which exceeds 1e-4, where
2024-03-17T21:58:52.7141740Z extForceX * slip evaluates to 0.02,
2024-03-17T21:58:52.7142074Z body1->getLinearVelocity().x() evaluates to 0.020113174675293631, and
2024-03-17T21:58:52.7142523Z 1e-4 evaluates to 0.0001.
2024-03-17T21:58:52.7142787Z $SRC_DIR/unittests/integration/test_ForceDependentSlip.cpp:266: Failure
2024-03-17T21:58:52.7143198Z The difference between 0.0 and body1->getLinearVelocity().y() is 0.00050173758912424411, which exceeds 1e-4, where
2024-03-17T21:58:52.7143478Z 0.0 evaluates to 0,
2024-03-17T21:58:52.7143791Z body1->getLinearVelocity().y() evaluates to 0.00050173758912424411, and
2024-03-17T21:58:52.7144088Z 1e-4 evaluates to 0.0001.
2024-03-17T21:58:52.7144350Z $SRC_DIR/unittests/integration/test_ForceDependentSlip.cpp:279: Failure
2024-03-17T21:58:52.7144767Z The difference between mass * accel.x() * slip and spinVel - linVel is 0.00048677195781898774, which exceeds 2e-4, where
2024-03-17T21:58:52.7145078Z mass * accel.x() * slip evaluates to 0.0265112720574745,
2024-03-17T21:58:52.7145401Z spinVel - linVel evaluates to 0.026998044015293488, and
2024-03-17T21:58:52.7145848Z 2e-4 evaluates to 0.00020000000000000001.

Wow, this is fishy. At least in 0.16.2, cmake with ccd enable pass the following flags:
-DdLIBCCD_BOX_CYL
-DdLIBCCD_CAP_CYL
-DdLIBCCD_CONVEX_BOX
-DdLIBCCD_CONVEX_CAP
-DdLIBCCD_CONVEX_CONVEX
-DdLIBCCD_CONVEX_CYL
-DdLIBCCD_CONVEX_SPHERE
-DdLIBCCD_CYL_CYL

while compiling with autotools:
-DdLIBCCD_CAP_CYL
-DdLIBCCD_CONVEX_BOX
-DdLIBCCD_CONVEX_CAP
-DdLIBCCD_CONVEX_CONVEX
-DdLIBCCD_CONVEX_CYL
-DdLIBCCD_CONVEX_SPHERE
-DdLIBCCD_CYL_CYL

The CMake build has an additional -DdLIBCCD_BOX_CYL flag that is not there in autotools. If one pass ODE_WITH_LIBCCD_BOX_CYL=OFF to the CMake build, indeed all dart test work fine.

That's a good catch! I also confirmed that this fixes the same issue on archilinux: build log, tested docker

Ack, thanks! I will align manually cmake and autotools in the conda-forge build, and then open an issue upstream.

By the way, the fact that box-cylinder check is not enable by the enable-ccd autotools flag is documented: https://bitbucket.org/odedevs/ode/src/bcfb66cd5e18e32e27cfaae3651ead930bbcda13/configure.ac#lines-428 .

@traversaro  Can this be closed?

Yes!


How to get angular velocity of radar detection

As we all know, we can get range/velocity/azimuth of radar detection from carla, but I want to know how to get detection angular velocity of radar?

As of right now, you can't get the angular velocity of the actors using the RADAR


Create hbov.txt

@logistef Sorry for the delay - we've been launching rebranding and I hadn't time to check the repo for a while.
Regrading the request - could you please point out the page, that describes long-term IT-related (>1year) educational courses, that the school provides? thank you!

@logistef As far as I see from http://www.hbov.be/over-onze-school/opleidingsniveau-hbo5.html HBOV offers a study of nursing and elderly care. There are programs which take 3 years or more, however JetBrains maintains SWOT list on GitHub for colleges or universities in order to help automating the process of approving or rejecting academic discounts. HBOV seems to have no courses related to informational technologies, thus the discount for JetBrains software tools seems to be useless for HBOV.
Please let us know if we are mistaken, and HBOV students study informational technologies and therefore need to obtain free license for JetBrains tools.

I'm closing the request due to being obsolete. @logistef please reply to reopen.


GO:0051235   maintenance of location parentage

GO:0051235   maintenance of location
is a "regulation of a biological quality"
That doesn't seem right, but I don't know why.
For example, is an adaptor that maintains a protein/ complex or organelle at a specific location a  "regulation of a biological quality" - that seems odd.

This was done here: #21220


Getting demo to work with localhost rails app

Thank you for an excellent contribution to the eco system!
I'm trying to test out turbo-android and turbo-ios in a greenfield Rails 7 app.
For turbo-ios, set up to use localhost was well documented, and easy to do:

struct Demo {
    static let local = URL(string: "http://localhost:3000")!

    static var current: URL {
        local
    }
}

But for turbo-android I haven't managed to get localhost to work, after a few hours of trying, neither with localhost:3000 or a custom local domain dev.local:3000 (however it works fine with an online production rails 7 app I also control):
I've tried to change BASE_URL in Constants.kt
// In Constants.kt
const val BASE_URL = "http://dev.local:3000"

and
// In Constants.kt
const val BASE_URL = "http://localhost:3000"

I get the following error message in the emulator, and while I've tried to look for logs to see what's going on, I'm not very well versed in Android Studio and haven't found anything useful there:

Any idea why this might be the case?

localhost refers to the emulator itself; you'll probably want to use <IP_ADDRESS> instead.
https://developer.android.com/studio/run/emulator-networking#networkaddresses

Thank you! That worked :)


Enable dependabot on the dependabot configuration

The shared Dependabot CI workflow added by #2 will also need to be updated by dependabot.
There's a chicken-and-egg problem here; this repo defines a dependabot workflow to add change notes; which means there is a workflow that needs tone updated by dependabot. However, this repo doesn't use towncrier (since there's nothing to release). To allow for this, an empty placeholder directory has been added where change notes can be written (and then ignored)
PR Checklist:

[x] All new features have been tested
[x] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

@rmartin16 If the "shared workflow" folder approach will work, that definitely makes sense to me.

whelp....
https://github.com/orgs/community/discussions/9050
Tried it just to confirm in my test setup:

guess we're stuck with this for now

That makes sense. Other repos have to opt-in to the change note behavior by importing this workflow explicitly; so adding a self-exclusion should be sufficient AFAICT.


Fix sanitizer and redthedocs build

Overview
This PR (hopefully) fixes #220
Changes:

Removed the erroneously committed output_sanitize.cfg and added it to the .gitignore
Fixed a badly configured Python version in one of the builds

Related Issue / Discussion
This PR is another attempt to fix the docs that were building and suddenly started failing right when I thought I had fixed them. This also configure the notebook tests to use the Jupyter notebook sanitizer from https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests.
Additional Information
#221
Links to other issues or sources.
https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests/pull/41

The issue seems to have resolved itself. This PR is building without memory limitation errors.


Added events npm dependency

https://github.com/mathiasvr/tiny-timer/issues/13

The events module from node is really supposed to be polyfilled when used in the browser e.g. by webpack.
I plan to release a browser first approach for the next major version but haven't had time for it recently.
For those still having problems, does this actually work? I don't mind merging as a temporary solution, but I'm not sure how this would work if not already using a bundler?

I made this pull request because i used the library in react native and i had similar issue
events module doesn't come by default in react native
So i made the changes and used my branch temporarily until this is merged
Thank God so far its working fine with my changes
It should be tested in browsers as well.

Okay sounds good, I updated as v1.5.1 🎉


DONOTMERGE: check a single event in geth tests

this branch is for debugging ci, because I can't reproduce this locally

Are you using nextest locally? I think it might be some issue with ports or multiple geth instances running in parallel

yeah I'm running nextest locally. port collisions would lead to errors we can see in ci, and the geth instances should be set to start in unique dirs. anyways tests seem to be fine here? not sure why test_outgoing_connect_with_single_geth was timing out earlier in main


Automator: update istio/client-go@master dependency in istio/istio@master

Generated by Automator - 2021-07-29T16:23:50+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0942c00ceb6b0e795c487fad8753756e56281484
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0942c00ceb6b0e795c487fad8753756e56281484
link
/test release-notes_istio

integ-security-multicluster-tests_istio
0942c00ceb6b0e795c487fad8753756e56281484
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
0942c00ceb6b0e795c487fad8753756e56281484
link
/test integ-security-multicluster-tests_istio

release-notes_istio
0942c00ceb6b0e795c487fad8753756e56281484
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0942c00ceb6b0e795c487fad8753756e56281484
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio


PropertiesDictionary - Added support for case-insensitive property lookup

Resolves #4507

Updated wiki: https://github.com/NLog/NLog/wiki/EventProperties-Layout-Renderer with IgnoreCase-parameter.


Introduce command update-powershell

Summary of the new feature/enhancement
Command is hopefully self-explanatory :)

Proposed technical implementation details (optional)

Most installations are performed using package managers. So the cmdlet could be useful only for SxS scenarios if zip package is used. Since we have new version notifications in 7.0 I think the cmdlet has very small value.
/cc @daxian-dbw Thoughts?

@iSazonov you are correct. This applies to the Windows variant only and would replace/enhance
iex "& { $(irm https://aka.ms/install-powershell.ps1) } -UseMSI -Preview"
I had the beginner/lazy in mind. But enhancing/improving the documentation here, providing a more friendly manner like this script could/should suffice.

@peppekerstens You could ask in https://github.com/PowerShell/PowerShell-Docs or pull a PR there.
Also I guess MSFT will promote AppX package from Store for beginners.

Duplicate of https://github.com/PowerShell/PowerShell/issues/12678

@SteveL-MSFT and @TylerLeonhardt and @iSazonov
Could we combine the MSIX PS versions with the MSIX commands to create a more package-like install/update experience within the console environment of Windows (with the non GUI core versions in mind)?
On that note: why are the MSIX packages published to the MS store but not within Github anymore?
https://github.com/PowerShell/PowerShell/issues/12009 - not really fixed this way...

@peppekerstens Appx module does not compatible with current PowerShell 7.1 version.
I am not a proponent of a self-renewal approach. I believe this is a task for package managers and each distributive  vendor can have a different approach. We have a good compromise today in notifying users of new versions.

@iSazonov I totally agree on your perspective and 'get' the way it is being done within a *unix/*linux env . So maybe I am missing something here....
I am trying to move forward to that same principle within Windows... What is the preferred packagemanager within the Windows environment and in which way has that manager updating for PowerShell covered?

What is the preferred packagemanager within the Windows environment and in which way has that manager updating for PowerShell covered?

MSFT actively works on WinGet :-) but it is your preference which manager to use. In any case you could try WinGet and feedback in WinGet repository.

This looks like a duplicate of https://github.com/PowerShell/PowerShell/issues/8663.


Reload page if new version detected on error page

Resolves #210 (again)
Note: this is just a guess, I don't really know how to reproduce this state.
See: https://github.com/sillsdev/languageforge-lexbox/issues/210#issuecomment-1777124454 and following.

It seems to me that we should have a module-level variable checking if an update was detected, and subscribe to the updated store at the top level of the hooks.client.ts module, updating the module-level variable. The Svelte-Kit docs say that in the browser, updated can be subscribed to at any time, so it's safe to do so in hooks.client.ts. That way we don't create a new subscription (which is a memory leak) every time handleError runs.

Here's my suggestion for moving updateDetected outside the function:
diff --git a/frontend/src/hooks.client.ts b/frontend/src/hooks.client.ts
index 5160b2b..8d2107f 100644
--- a/frontend/src/hooks.client.ts
+++ b/frontend/src/hooks.client.ts
@@ -11,15 +11,14 @@ import { APP_VERSION } from '$lib/util/version';

 await loadI18n();

+export let updateDetected = false;
+updated.subscribe((value) => { updateDetected = value; })();
+void updated.check(); // Needs to be called at least once to kick off the interval
+
 // eslint-disable-next-line func-style
-export const handleError: HandleClientError = async ({ error, event }) => {
+export const handleError: HandleClientError = ({ error, event }) => {
   const handler = 'client-error-hook';

-  // someone has to have subscribed to updated before `check` is allowed to be called
-  // this seems to work and provide the correct value :shrug:
-  // eslint-disable-next-line @typescript-eslint/no-empty-function
-  updated.subscribe(() => { })();
-  const updateDetected = await updated.check();
   const autoReload = shouldTryAutoReload(updateDetected);

   const traceId = ensureErrorIsTraced(error, { event }, {

Hmm. The Svelte-Kit documentation doesn't actually mention this, but looking at the source code I see that if you're running in dev mode, the updated store is replaced by one that always returns false, and whose .check() method does nothing. So this is only testable by doing a production build, i.e. against staging. (Or running pnpm run build and then pnpm run preview in your frontend directory).

@rmunn Yeah, it's a bit finicky to test, because there's no versioning in dev. I documented some scenarios I went through as I was trying to reproduce the original error.
Also, the reason I explicitly call check() is because updated is dependant on the version polling interval we define. I.e. It's not necessarily up to date. If you want to know now if there's a new version, I think check() is the way to go.

I can't see any reason why you have to subscribe to the store before you're allowed to call updated.check(). I'll try to test that out sometime.

I just got an exception that said something like: "you have to subscribe before calling check()", which was pretty funny. Perhaps something changed in v4. Also, note that we do subscribe in the root layout, so the subscription here is just a fallback (that should maybe be commented) and if you want to test if a subscription is required, you probably want to comment out all the other places that subscribe.


Ensure that the result of |constructStichedFromIRResult| is within the range of the function (issue 6113)

Fixes #6113.
It appears that when we switched to using Float32Array (in PR #5134), we may now occasionally encounter rounding errors, which cause the result to become NaN thus leading to incorrect rendering.

/botio-windows preview

/botio-linux preview

/botio test

The one time that I don't bother testing locally before pushing a patch, since I figured it's probably fine anyway, I obviously break something. :-(
Unsurprisingly I should just have done what Yury suggested right away. Anyway, a new and locally tested patch has been pushed. Sorry about the wasted time/testing here!
/botio-linux preview

/botio test

/botio makeref

Nice, thanks!


Change plots with parking occupation

Change the y-axis on the plots which show the parking occupation. 100% occupied should be the max. Now the maximum is 100% free

Low priority, because not relevant for model building.


Redirect on activate page loaded

Description
The purpose is to redirect to the login page if activate page is loaded
I added 2 toasters to alert the user of the status of the activation
closes #194

closes #194

Please use already defined toast to get the same UI and behavior https://github.com/BearStudio/start-ui-web/blob/eb62ec5d0e20d51e17280af690cdfd23a654dae3/src/components/Toast/index.ts#L10

fix


The document says the api_key is optional, but it is required in CDKTF

In the document, the api_key field is optional.
https://github.com/mackerelio-labs/terraform-provider-mackerel/blob/8efe2a4569ed1982b4c14c0d7a3d7029a102d68c/docs/index.md?plain=1#L61
But it is required in the provider code and generated code by CDKTF.
https://github.com/mackerelio-labs/terraform-provider-mackerel/blob/8efe2a4569ed1982b4c14c0d7a3d7029a102d68c/mackerel/provider.go#L22-L24
https://developer.hashicorp.com/terraform/cdktf/cli-reference/commands#provider-add

Sorry, it was my mistake, there were no such problems.


Symlink related bug

GitLens Version: 9.8.2
VSCode Version: 1.36.0-insider
OS Version: 10.14.5

Steps to Reproduce:

mkdir /work
ln -s /work /home/username/stuff
work in /home/username/stuff
Use GitLens to see line history
Fail. And we see /work/home/username/stuff/file1 pattern in the log

This bug is in method resolve in gitUrls.ts, where
repoPath is recognized as /work, while fileName is recognized as /work/home/username/stuff/file1. resolve simply join these two strings giving the wrong pathname.

Duplicate of https://github.com/eamodio/vscode-gitlens/issues/677


Skip Media&Other items in vCloud Catalogs

Purpose or Intent
VMware vCloud Catalogs contain two types of items, vApp Templates and Media&Other.  Currently we only want to inventory vApp Templates because you cannot provision anything from the Media&Other items.  This will skip all Media&Other items in a vCloud catalog.

@miq-bot add-label providers/vmware/cloud

Looks good to me but I wrote it :smile: @blomquisg can you take a look?
@miq-bot assign blomquisg


Add custom message headers support (from JIRA-LOGSTASH-1753)

From https://logstash.jira.com/browse/LOGSTASH-1753

Stomp supports message headers, which may be useful for subscribers to filter event types (for instance).
Additionally, ActiveMQ uses an "amq-msg-type" header to choose between text and bytes message (see https://issues.apache.org/jira/browse/AMQ-2833); this would easily fix LOGSTASH-959.
The attached patch adds support for custom headers with string expansion in header values. It was successfully tested in practice on my personal server.

Patch
diff --git a/lib/logstash/outputs/stomp.rb b/lib/logstash/outputs/stomp.rb
index bf89266..c96978f 100644
--- a/lib/logstash/outputs/stomp.rb
+++ b/lib/logstash/outputs/stomp.rb
@@ -27,6 +27,12 @@ class LogStash::Outputs::Stomp < LogStash::Outputs::Base
   # The vhost to use
   config :vhost, :validate => :string, :default => nil

+  # Custom headers to send with each message. Supports string expansion, meaning
+  # %{foo} values will expand to the field value.
+  #
+  # Example: headers => ["amq-msg-type", "text", "host", "%{host}"]
+  config :headers, :validate => :hash
+
   # Enable debugging output?
   config :debug, :validate => :boolean, :default => false

@@ -61,7 +67,14 @@ class LogStash::Outputs::Stomp < LogStash::Outputs::Base
   def receive(event)
       return unless output?(event)

-      @logger.debug(["stomp sending event", { :host => @host, :event => event }])
-      @client.send(event.sprintf(@destination), event.to_json)
+      headers = Hash.new
+      if @headers
+        @headers.each do |k,v|
+          headers[k] = event.sprintf(v)
+        end
+      end
+
+      @logger.debug(["stomp sending event", { :host => @host, :event => event, :headers => headers }])
+      @client.send(event.sprintf(@destination), event.to_json, headers)
   end # def receive
 end # class LogStash::Outputs::Stomp

The patch is working correctly. Tested with ActiveMQ 5.7,0.
Please add this solution to the next release

+1

+1
I've forked this repo to apply the patch and it works perfectly for me as well on ActiveMQ.

3.0.1 and 2.0.5 now support this feature, done in #9


Update legal_strings.xml UA Bug fix EXPOSUREAPP-7099

fixes https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-7099
@harambasicluka please check and approve. Do we need to add 2.3 as well?

@NataliaLemmerth as this is only a german issue and we'll deliver a hotfix for 2.2 this can be included.


Gather instance data directly, without relying on instances.mastodon.xyz

At the moment, data gathering is done as follows:

We fetch instance list and stats from https://instances.mastodon.xyz/instances.json
We fetch countries separately

I suspect as time will pass, we will want to gather more specialized data (such as versions, as described in #12) which may not make sense in the context of instances.mastodon.xyz. Maybe it's time to move top another workflow:

Fetch the instance list from https://instances.mastodon.xyz/instances.json
Fetch each instance data separately

By doing that, the whole system will be more resilient to failure in the event instances.mastodon.xyzgoes down, and we can also imagine fetching data from instances that are not listed in this directory.

Instances.mastodon.xyz (now instances.social) is actually pretty stable, so I'm gonna close this.


show-routes command not working

Raises an exception for undefined method 'name':
undefined method `name' for #<Sprockets::Environment>

@parreirat Which version of pry-rails are you using. I am using version 0.3.2 and I don't see this issue.
This could be issue with sprocket version. What is sprocket version?
May be you are using old version or this error is introduced in latest version

@Shwetakale meanwhile I've gotten another computer and never ran across the same issue again, sorry. No idea which I were using at the time.

@parreirat Ok Good you are not facing this issue :+1:


UX: Tile Icons

With a growing number of tile icons it becomes harder and harder to differentiate the different tile icons. Each new tile also requires a dedicated icon. Not every team has a UX/UI designer that can create custom tile icons. Maybe we consider about moving to a Gutenberg-like approach with a popup that offers more space for showing the available tiles with a title and a description.

@sneridagh @albertcasado this is also something I would like us to discuss during the upcoming sprints. We have clients asking for 30-40 different tiles for projects. With that amount of tiles it will be impossible to differentiate them by icons (and being able to provide those icons). Maybe looking at Gutenberg can give us a few ideas:


Raise fatal error If FQDN duplicated

Description
If fqdn is duplicated, it raises fatal error. Because it sometimes does not notice that it is duplicated.
Check List

[x] New functionality includes tests
[ ] All tests pass
[ ] RELEASE_NOTES.md, has been updated if required (not required for bugfixes, required for API changes)
[ ] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

I would like to solve that is not possible to execute chef-client as expected for duplicated fqdn on node files with knife-zero. Because knife-zero manages nodes as static file. So chef database does not matter.

@linyows this is looking good. We're gonna need you to do two things, and then we can get this merged.
First is to fix the chefstyle failures: https://travis-ci.org/chef/chef/jobs/340760026 . You can do this by running bundle exec chefstyle -a.
Second is to add a DCO sign off. If you've got the chefdk installed, run dco sign in your branch.

Ok, thanks.

Thanks for sticking with this, and thanks for your contribution to Chef!


[rtorrent] filebot doesn't load libmediainfo properly, fails as a result

Still trying to get my setup just right, but running into an issue with filebot / mediainfo. Here's the log from a test run I did in the console:
/filebot/filebot.sh -script fn:amc --output "/data/Media" --action test -non-strict --conflict skip -non-strict --log-file amc.log --def excludeList=
amc.excludes unsorted=y music=y "seriesFormat=/data/Media/TV/{n}/Season {s.pad(2)}/{s00e00} - {t}" "animeFormat=/data/Media/Animes/{n}/{e.pad(3)} - {t}"
"movieFormat=/data/Media/Movies/{n}" "musicFormat=/data/Media/Music/{n}/{fn}" "ut_dir=$TORRENT_PATH" "ut_kind=multi" "ut_title=$TORRENT_NAME" "ut_label=$
TORRENT_LABEL"
Locking /filebot/data/logs/amc.log
Run script [fn:amc] at [Fri May 12 03:39:34 GMT 2017]
Parameter: excludeList = amc.excludes
Parameter: unsorted = y
Parameter: music = y
Parameter: seriesFormat = /data/Media/TV/{n}/Season {s.pad(2)}/{s00e00} - {t}
Parameter: animeFormat = /data/Media/Animes/{n}/{e.pad(3)} - {t}
Parameter: movieFormat = /data/Media/Movies/{n}
Parameter: musicFormat = /data/Media/Music/{n}/{fn}
Parameter: ut_dir = (redacted)
Parameter: ut_kind = multi
Parameter: ut_title = (redacted)
Parameter: ut_label = Music
Use excludes: /data/Media/amc.excludes (1)
Input: (redacted).flac
Input: (redacted).flac
Input: (redacted).flac
Input: (redacted).flac
Input: (redacted).flac
Input: (redacted).flac
Group: [music:(redacted)] => [(redacted).flac, (redacted).flac, (redacted).flac, (redacted).flac, (redacted).flac, (redacted).flac]
Rename music using ID3
UnsatisfiedLinkError: Unable to load library 'mediainfo': Native library (linux-x86-64/libmediainfo.so) not found in resource path ([file:/filebot/FileBot.jar])
Processing 6 unsorted files
[TEST] From [(redacted).flac] to [/data/Media/Unsorted/(redacted).flac]
[TEST] From [(redacted).flac] to [/data/Media/Unsorted/(redacted).flac]
[TEST] From [(redacted).flac] to [/data/Media/Unsorted/(redacted).flac]
[TEST] From [(redacted).flac] to [/data/Media/Unsorted/(redacted).flac]
[TEST] From [(redacted).flac] to [/data/Media/Unsorted/(redacted).flac]
[TEST] From [(redacted).flac] to [/data/Media/Unsorted/(redacted).flac]
Processed 6 files
Finished without processing any files
Failure (°_°)

and with strace, to see what files it's trying to load:
strace -f /filebot/filebot.sh -script fn:amc --output "/data/Media" --action test -non-strict --conflict skip -non-strict --log-file amc.log --def ex
cludeList=amc.excludes unsorted=y music=y "seriesFormat=/data/Media/TV/{n}/Season {s.pad(2)}/{s00e00} - {t}" "animeFormat=/data/Media/Animes/{n}/{e.pad(3
)} - {t}" "movieFormat=/data/Media/Movies/{n}" "musicFormat=/data/Media/Music/{n}/{fn}" "ut_dir=$TORRENT_PATH" "ut_kind=multi" "ut_title=$TORRENT_NAME" "
ut_label=$TORRENT_LABEL" 2>&1 | grep libmediainfo
[pid   674] open("/usr/lib/jvm/java-1.8-openjdk/jre/lib/amd64/server/libmediainfo.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
[pid   674] open("/usr/lib/jvm/java-1.8-openjdk/jre/lib/amd64/libmediainfo.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
[pid   674] open("/usr/lib/jvm/java-1.8-openjdk/jre/../lib/amd64/libmediainfo.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
[pid   674] open("/filebot/libmediainfo.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
[pid   674] open("/filebot/lib/x86_64/libmediainfo.so", O_RDONLY|O_CLOEXEC) = 19
[pid   674] open("/usr/lib/libmediainfo.so", O_RDONLY|O_NONBLOCK|O_CLOEXEC|O_PATH) = -1 ENOENT (No such file or directory)
[pid   674] stat("/usr/lib/libmediainfo.so", 0x7f6014125640) = -1 ENOENT (No such file or directory)
[pid   674] open("/lib/libmediainfo.so", O_RDONLY|O_NONBLOCK|O_CLOEXEC|O_PATH) = -1 ENOENT (No such file or directory)
[pid   674] stat("/lib/libmediainfo.so", 0x7f6014125640) = -1 ENOENT (No such file or directory)
[pid   674] open("/usr/lib/jvm/java-1.8-openjdk/jre/lib/amd64/server/libmediainfo.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
[pid   674] open("/usr/lib/jvm/java-1.8-openjdk/jre/lib/amd64/libmediainfo.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
[pid   674] open("/usr/lib/jvm/java-1.8-openjdk/jre/../lib/amd64/libmediainfo.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
[pid   674] open("/filebot/libmediainfo.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
[pid   674] open("/filebot/lib/x86_64/libmediainfo.so", O_RDONLY|O_CLOEXEC) = 19
[pid   674] write(2, "UnsatisfiedLinkError: Unable to "..., 161UnsatisfiedLinkError: Unable to load library 'mediainfo': Native library (linux-x86-64/libmediainfo.so) not found in resource path ([file:/filebot/FileBot.jar])

libmediainfo does exist in /filebot/lib/x86_64:
ls -la /filebot/lib/x86_64/
total 10000
drwxr-xr-x    1 1029     65536          122 May  7 00:34 .
drwxr-xr-x    1 1029     65536           46 May  7 00:34 ..
-rw-r--r--    1 1029     65536      2745145 Sep 26  2015 lib7-Zip-JBinding.so
-rw-r--r--    1 1029     65536       111408 Sep 24  2016 libjnidispatch.so
-rw-r--r--    1 1029     65536      7065248 Apr  3 07:47 libmediainfo.so
-rw-r--r--    1 1029     65536       308352 Feb  9 19:57 libzen.so

Setting LD_LIBRARY_PATH as per this post's recommendation doesn't seem to help.
This seems to be an identical issue to this one, but in that case the user was able to resolve it by simply installing filebot through package management - Alpine has mediainfo packages, but they're still only in the testing repositories (and shouldn't be neccesary?). Any bright ideas?

I have update file but the problem is filebot version I think
When I have change build argument filebot work...
So I use :
ARG MEDIAINFO_VER=<IP_ADDRESS>
ARG FILEBOT_VER=4.7.7
If this version not work, I share my Dockerfile (I have add libzen (thank @xataz ))


fix: Union schemas with null args[0] hooks

Motivation

null params means 'do nothing' for all our hooks. Currently the inferencing breaks assuming args[0] is an object.
Solution

Build in protection in union, as well as not trying to 'infer' for null params since that makes no sense.

Codecov Report

Merging #1779 (3d5f29d) into master (c936bcf) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1779      +/-   ##
==========================================
+ Coverage   98.46%   98.51%   +0.05%
==========================================
  Files         102      102
  Lines        1885     1887       +2
  Branches      378      379       +1
==========================================
+ Hits         1856     1859       +3
  Misses         14       14
+ Partials       15       14       -1

Impacted Files
Coverage Δ

packages/core/src/controller/Controller.ts
93.40% <100.00%> (+0.07%)
:arrow_up:

packages/normalizr/src/schemas/Object.ts
100.00% <100.00%> (ø)

packages/normalizr/src/schemas/Union.js
100.00% <100.00%> (ø)

...es/core/src/react-integration/newhooks/useCache.ts
100.00% <0.00%> (+5.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c936bcf...3d5f29d. Read the comment docs.


836 preview page fix

Ticket: #836
Issue
The "Preview Changes" button in a WordPress post on the admin side was grabbing the last or oldest revision, not the newest revision, meaning the preview changes button would not show your latest changes, but the oldest revision of the post or page.
Solution
instead of grabbing the post id from last element of the $revisions array, I am grabbing it from the first element.
…last revison from a list of revisons sorted in desc order, meaning it was always showing you the first revision ever made, and not the latest change

Coverage remained the same at 88.287% when pulling 70de6640c68a1321394aaa95202dea70e0755664 on dknoben:836-preview-page-fix into 68d3c57fd45c16e71a1128cbea16c39a149c1842 on timber:master.

Thanks @dknoben! Great catch on this guy. I added a test in #1052 where we can double-confirm this and merge it in!

Thanks @dknoben! Great catch on this guy. I added a test in #1052 where we can double-confirm this and merge it in!

Thanks @dknoben !


wasmtime 22 update

@rylev I'm working through updates for the dependencies of this crate
minor changes for wit-parser
wrt wasmtime = "22" there are a few more substantive changes
wasmtime 21.0 changed the default for host generated bindings to be trappable_imports: false - e.g. the Result<Result< model - my branch here  retains that default as a 1st pass - it looks like the fallible operations in the wit already return result so changing that default should just be work (happy to do it)
the bigger issue is that the Host* traits now result in "conflicting implementations of trait..."
error[E0119]: conflicting implementations of trait `component::dyna::dynamic_component::HostEngine` for type `&mut _`
  --> src/lib.rs:6:1
   |
6  | / wasmtime::component::bindgen!({
7  | |     trappable_imports: true,
8  | |     with: {
9  | |         "component:dyna/dynamic-component/engine": Engine,
...  |
13 | |     }
14 | | });
   | |__^ conflicting implementation for `&mut _`
...
31 | / impl<T> dynamic_component::HostEngine for T
32 | | where
33 | |     T: DynamicComponentView,
   | |____________________________- first implementation here
   |
   = note: downstream crates may implement trait `DynamicComponentView` for type `&mut _`
   = note: this error originates in the macro `wasmtime::component::bindgen` (in Nightly builds, run with -Z macro-backtrace for more info)

it does look like wasmtime >= 22 now generates this:  impl<_T: Host + ?Sized> Host for &mut _T {} - if you have thoughts on direction to go here I'm happy to run with it

thanks @rylev - nicely done!


Solver diverges for small recombination lifetimes

Hi,
I am struggling with solver instability issues for small lifetimes. In simple stacks, such as a typical GaAs pn junction, one could go up to 1e-15s. But for more complex (or should I say realistic) stacks, this can happen already at 5e-12s.
I can only guess about hitting the floating point precision somehow due to strong recombination. I checked that JAX can only do 64bits and does not support np.longdouble. But that's just me without deeper insights into many choices that were made in the code. Would you agree with this assessment for a start or there is something else that could be turned over?
Thanks a lot for your help in advance!
Kind regards,
Shakeeb

This worked like a sounding board! I noticed that the problem could be due to a poor initial guess. Providing the solver with a converged solution solved the problem.


Check withContiguousStorageIfAvailable before copying byte by byte

Check withContiguousStorageIfAvailable before copying byte by byte.

Resolves SR-14886.

@swift-ci please smoke test

@weissi

thank you @wongzigii , that looks good to me!

@swift-ci test

@swift-ci please benchmark

@swift-ci please test windows platform

@glessard Done. If buffer.baseAddress == nil, then buffer.count would be zero.

Can somebody trigger the @swift-ci again ?

I am adding a benchmark in #38621. Once that is merged I will trigger the CI.

@swift-ci please benchmark

@swift-ci please benchmark

Build failed before running benchmark.

@swift-ci please benchmark

Performance (x86_64): -O

Regression
OLD
NEW
DELTA
RATIO

DictionaryOfAnyHashableStrings_insert
2170
3710
+71.0%
0.58x

Set.isDisjoint.Box25
282
395
+40.1%
0.71x (?)

Set.isDisjoint.Int50
198
237
+19.7%
0.84x (?)

DictionaryKeysContainsNative
13
15
+15.4%
0.87x (?)

StringRemoveDupes
181
200
+10.5%
0.91x (?)

Improvement
OLD
NEW
DELTA
RATIO

RawBufferInitializeMemory
130
88
-32.3%
1.48x

RawBufferCopyBytes
25
20
-20.0%
1.25x (?)

UTF8Decode_InitDecoding
160
129
-19.4%
1.24x (?)

UTF8Decode_InitFromCustom_noncontiguous
279
248
-11.1%
1.12x (?)

Calculator
156
140
-10.3%
1.11x (?)

StringHasSuffixAscii
1520
1380
-9.2%
1.10x (?)

NSStringConversion.MutableCopy.LongUTF8
384
358
-6.8%
1.07x (?)

Code size: -Osize
Performance (x86_64): -Onone

Improvement
OLD
NEW
DELTA
RATIO

RawBufferCopyBytes
149028
20
-100.0%
7451.03x

UTF8Decode_InitDecoding
164
134
-18.3%
1.22x (?)

UTF8Decode_InitFromCustom_contiguous
166
136
-18.1%
1.22x

Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: 6-Core Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@wongzigii Thanks for the contribution! The improvement is good with optimizations on, but very large in debug mode. That's worth it. Could you add or modify a test in test/stdlib/UnsafeRawBufferPointer.swift so that both code paths are exercised with copyBytes? Right now I think only the new fast path is exercised in those tests.

@swift-ci Apple Silicon benchmark

Performance (arm64): -O

Regression
OLD
NEW
DELTA
RATIO

DictionaryOfAnyHashableStrings_insert
1260
2282
+81.1%
0.55x (?)

Set.isDisjoint.Int25
86
130
+51.2%
0.66x (?)

StringRemoveDupes
117
142
+21.4%
0.82x (?)

DictionaryGroupOfObjects
441
531
+20.4%
0.83x (?)

SubstringFromLongStringGeneric
5
6
+20.0%
0.83x (?)

Set.isStrictSubset.Box25
83
94
+13.3%
0.88x (?)

SetIsSubsetBox25
83
94
+13.3%
0.88x (?)

DictionaryRemove
1730
1930
+11.6%
0.90x (?)

DictionaryGroup
114
127
+11.4%
0.90x (?)

NSArray.bridged.objectAtIndex
194
216
+11.3%
0.90x (?)

StringHasPrefixAscii
1210
1340
+10.7%
0.90x (?)

StringHasSuffixAscii
1310
1430
+9.2%
0.92x (?)

SetIsSubsetInt50
83
90
+8.4%
0.92x (?)

LazilyFilteredArrays2
1300
1400
+7.7%
0.93x (?)

Improvement
OLD
NEW
DELTA
RATIO

LessSubstringSubstring
21
18
-14.3%
1.17x (?)

EqualSubstringSubstring
21
18
-14.3%
1.17x (?)

EqualStringSubstring
21
18
-14.3%
1.17x (?)

EqualSubstringSubstringGenericEquatable
21
18
-14.3%
1.17x (?)

EqualSubstringString
21
18
-14.3%
1.17x (?)

LessSubstringSubstringGenericComparable
21
18
-14.3%
1.17x (?)

ArrayAppendToGeneric
190
170
-10.5%
1.12x (?)

ArrayAppendToFromGeneric
190
170
-10.5%
1.12x (?)

Set.filter.Int100.24k
853
778
-8.8%
1.10x (?)

Dict.CopyKeyValue.24k
867
796
-8.2%
1.09x (?)

Set.filter.Int100.20k
729
671
-8.0%
1.09x (?)

Dict.CopyKeyValue.20k
742
691
-6.9%
1.07x (?)

Code size: -O

Improvement
OLD
NEW
DELTA
RATIO

BufferFill.o
7314
7118
-2.7%
1.03x

Performance (arm64): -Osize

Improvement
OLD
NEW
DELTA
RATIO

RawBufferCopyBytes
249
12
-95.2%
20.75x

EqualStringSubstring
21
18
-14.3%
1.17x (?)

EqualSubstringString
21
18
-14.3%
1.17x (?)

LessSubstringSubstring
22
19
-13.6%
1.16x (?)

EqualSubstringSubstring
22
19
-13.6%
1.16x (?)

EqualSubstringSubstringGenericEquatable
22
19
-13.6%
1.16x (?)

LessSubstringSubstringGenericComparable
22
19
-13.6%
1.16x (?)

NSArray.bridged.objectAtIndex
219
196
-10.5%
1.12x (?)

Code size: -Osize
Performance (arm64): -Onone

Regression
OLD
NEW
DELTA
RATIO

ArrayAppendToFromGeneric
160
180
+12.5%
0.89x (?)

Improvement
OLD
NEW
DELTA
RATIO

RawBufferCopyBytes
74031
13
-100.0%
5694.25x

ArrayAppendGenericStructs
940
430
-54.3%
2.19x (?)

LessSubstringSubstring
39
35
-10.3%
1.11x (?)

EqualSubstringSubstring
39
35
-10.3%
1.11x (?)

EqualSubstringSubstringGenericEquatable
39
35
-10.3%
1.11x (?)

LessSubstringSubstringGenericComparable
39
35
-10.3%
1.11x (?)

COWArrayGuaranteedParameterOverhead
2650
2400
-9.4%
1.10x (?)

EqualStringSubstring
39
36
-7.7%
1.08x (?)

EqualSubstringString
39
36
-7.7%
1.08x (?)

Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini9,1
  Total Number of Cores: 8 (4 performance and 4 efficiency)
  Memory: 16 GB

Is it true that RawBufferCopyBytes is 5694x faster than before? Can't believe that.

Just to clarify, should I need to use a separately memory layout array to test the old path?
From https://forums.swift.org/t/contiguous-collection-protocols/17875/6, a separately array would need be nested in a class with NSArray bridging.

Can't believe that RawBufferCopyBytes in Apple Silicon is 5694x faster. 🥇

Yes, this is expected, especially in debug mode. Previously, it would call the getter for every single byte, and then the setter. Now, it'll just call memmove once. And memmove is a libc function so it's always optimised. Ie. there's just a lot less Swift code running to transfer the bytes.
In -Osize, you'll see that it's "just" 20x and that's because the compiler was able to better optimise the getter & setter. But now, that's no longer necessary, we'll just do memmove.
Great stuff, thank you!

Just to clarify, should I need to add another separately memory layout array to test the old path?

The test needs to call copyBytes with a Collection that does not implement withContiguousStorageIfAvailable. Range might work. I believe that right now all tests of calls to copyBytes use Arrays, which means they all go through the new code path.

Updated test case!

Ah, Nice! I was thinking about 1..<2 is an array, but actually it is an Range. :D
Updated again and would be good to go now.

@swift-ci please test

@wongzigii Could you rebase and force-push the changes as a single commit? We have more commits than necessary here! --Thanks

Squashed into a single commit. Done.

@swift-ci please smoke test

Thanks @wongzigii !


Changelog and update to 2.1.5

Current coverage is 91.30%

Merging #933 into master will not affect coverage as of 0f0f16f

@@            master   #933   diff @@
=====================================
  Files           72     72
  Stmts         4301   4301
  Branches       862    862
  Methods          0      0
=====================================
  Hit           3927   3927
  Partial         10     10
  Missed         364    364

Review entire Coverage Diff as of 0f0f16f

Powered by Codecov. Updated on successful CI builds.

We may wanna wait for that one #932 as we have a major issue with FB/OAuth login

So far the changelog has only been including stuff that the end user sees (eg. the don't care about less warnings when running tests or converting source code from ES5 to ES6). @nlutsenko wanted to put that info in releases and have the changelog include literally everything, are you going to do that for this release? Eg. put a more end-user centric release notes/changelog into releases?

I included all of the PRs, didn't evaluate which was end-user facing or not... I am not sure it's worth the additional effort to make them less comprehensive, so my vote is for including them.

Is there a way I can install 2.1.5 before it's officially released?

I think it's important to have a list of user facing changes so that people can evaluate whether or not to update to the newest version. What @nlutsenko wanted was to have the user facing changes go into "releases" tab and have changelog be comprehensive. As long as the list of user facing changes is somewhere, I'm cool with that.

Yes. We can even skip the New/Improved/Fixed portion and just list things chronologically...
If people want to see the user facing things - they go look at the Releases page (I think that's what it's for). We can even cross-link them :grin:
The purpose of changelog is to show what changed in any given version, up to the slightest detail.
For example, if people are forking the server (which is a legitimate use case) and have their changes there - any change, even internal, is going to impact people.
Another use case - if we have pre-releases, like RCs which is supported for GitHub - a good example is Docker. Things that go into Releases is user visible, but those things don't necessarily need to go into Changelog.
Also documenting PRs instead of git commits is a way better approach, since it reduces amount of noise in the changelog...


Feature: GitHub Enterprise Server (GHES) support for 'cosign generate-key-pair github:'

Description
cosign generate-key-pair github: currently only supports github.com repositories.
It would be nice if GitHub Enterprise Server (GHES) would be also supported by the above command.

sounds good to me, let me take a look

or are you willing to implement this @netsandbox?

I already created a PR with the changes.
I introduced a new GITHUB_HOST environment variable, similar to the GITLAB_HOST environment variable.
Maybe it makes sense to also support other environment variables for GitHub host and token.
For example GitHub CLI supports the following environment variables:

GH_TOKEN
GITHUB_TOKEN
GH_ENTERPRISE_TOKEN
GITHUB_ENTERPRISE_TOKEN
GH_HOST

Supporting the same set of environment variables would make it easier for users who use both, GitHub CLI and cosign.
But I'm not sure if this is just to much.

cool, thanks!

I already created a PR with the changes. I introduced a new GITHUB_HOST environment variable, similar to the GITLAB_HOST environment variable.
Maybe it makes sense to also support other environment variables for GitHub host and token. For example GitHub CLI supports the following environment variables:

GH_TOKEN
GITHUB_TOKEN
GH_ENTERPRISE_TOKEN
GITHUB_ENTERPRISE_TOKEN
GH_HOST

Supporting the same set of environment variables would make it easier for users who use both, GitHub CLI and cosign. But I'm not sure if this is just to much.

this we can do in a follow up


Implementation of LFQ

Hi,
Thank you for the quick integration of LFQ while we work on the official release! I'd like to clarify two points regarding the details to avoid confusion of users:
(1) By default we do not use an activation function - https://github.com/lucidrains/vector-quantize-pytorch/blob/master/vector_quantize_pytorch/lookup_free_quantization.py#L57
(2) We use the commitment loss as in VQVAE - https://github.com/lucidrains/vector-quantize-pytorch/blob/master/vector_quantize_pytorch/vector_quantize_pytorch.py#L987
These do not change anything at inference time given the simple nature of LFQ, but do affect the training performance. For the binary case, an activation function isn't actually needed, as denoted in the formulas in our paper.
These are also key differences between LFQ and FSQ - https://github.com/lucidrains/vector-quantize-pytorch/blob/master/vector_quantize_pytorch/lookup_free_quantization.py#L5
Thank you!

A third point:
(3) We use global or sub-groups to estimate the codebook entropy, which is different from the bitwise entropy - https://github.com/lucidrains/vector-quantize-pytorch/blob/master/vector_quantize_pytorch/lookup_free_quantization.py#L183

Here is a reference that hopefully helps: https://github.com/google-research/magvit/blob/main/videogvt/models/vqvae.py#L44
Compared to this VectorQuantizer class, in LFQ quantized becomes jnp.where(x > 0, 1, -1) and there is no q_latent_loss. The codebook entropy term stays the same as VQ for codebooks <= 2^18, and is factorized into multiple subgroups for larger ones.

not sure if this is relevant, but when I run LFQ with trainining=True, it seems that the entropy loss is always the same. Maybe we should not compute bit-wise entropy?

@Lijun-Yu Hi Lijun! Thanks for opening this issue and for your new magvit2 paper
I will get this all resolved by sundown

@Lijun-Yu what surprises me the most is the lack of activation. what did you see when you tried it with a tanh or sigmoid?

not sure if this is relevant, but when I run LFQ with trainining=True, it seems that the entropy loss is always the same. Maybe we should not compute bit-wise entropy?

i've updated the entropy calculation, if you'd like to give it another shot

@theAdamColton 🤦  should be fixed! thanks!

all points should be addressed

A third point:
(3) We use global or sub-groups to estimate the codebook entropy, which is different from the bitwise entropy - https://github.com/lucidrains/vector-quantize-pytorch/blob/master/vector_quantize_pytorch/lookup_free_quantization.py#L183

How to calculate entropy loss in lfq, I don't know how to calculate 'distance' and probs