Error using init

Whenever I try to initialize a project this is what I get:
npx: installed 172 in 25.046s
internal/validators.js:125
throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
^
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
at validateString (internal/validators.js:125:11)
at Object.join (path.js:427:7)
at Object. (C:\Users\NAME\AppData\Roaming\npm-cache_npx\19764\node_modules\create-caccl\helpers\getPackageJSON.js:8:30)
at Module._compile (internal/modules/cjs/loader.js:776:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)
at Module.require (internal/modules/cjs/loader.js:690:17)
at require (internal/modules/cjs/helpers.js:25:18)
Any tips on how to resolve this issue?
Thanks!

I’ll take a look at it! What version of node and what version of npm are
you using?
Also, just in case it’s relevant, what OS are you using?
Thank you!
On Sat, Jul 13, 2019 at 8:44 PM STaylorY<EMAIL_ADDRESS>wrote:

Whenever I try to initialize a project this is what I get:
npx: installed 172 in 25.046s
internal/validators.js:125
throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
^
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type
string. Received type undefined
at validateString (internal/validators.js:125:11)
at Object.join (path.js:427:7)
at Object.
(C:\Users\NAME\AppData\Roaming\npm-cache_npx\19764\node_modules\create-caccl\helpers\getPackageJSON.js:8:30)
at Module._compile (internal/modules/cjs/loader.js:776:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)
at Module.require (internal/modules/cjs/loader.js:690:17)
at require (internal/modules/cjs/helpers.js:25:18)
Any tips on how to resolve this issue?
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/harvard-edtech/caccl/issues/4?email_source=notifications&email_token=ADLSIACXO6UQAPB5KP35LJ3P7JZFLA5CNFSM4IDFCFVKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7BYTSA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADLSIAC6ZONHG5V2TFUGX2LP7JZFLANCNFSM4IDFCFVA
.

--
––
Gabriel Abrams
Senior Software Engineer
<EMAIL_ADDRESS>Harvard Division of Continuing Education
Room 513, 125 Mount Auburn St
Phone:<PHONE_NUMBER>
Pronouns: he/him/his

Node :: v10.15.1
npm :: v6.4.1
OS: Windows 10 Enterprise 2016 LTSB 64-bit
Thank you for looking into this!

Hi STaylorY, I've been looking into this and it seems that the environment variables set by windows aren't what we were expecting. Unfortunately, we don't currently support running this on Windows and we don't plan on starting to support Windows at least not in the near future.
I recommend developing on either Mac or Linux if you plan on using CACCL. If you want to stick with Windows, I'd recommend using a bash shell: https://itsfoss.com/install-bash-on-windows/
If you're using Mac, Linux, or a bash shell and keep getting this error, please let me know!
P.S. I'm adding a note to the docs.

Hi Gabriel,
i have encountered the same issue when deploying the application to google app engine.
locally the app runs on my MAC OS just fine, but when deploying to google app engine nodejs application, i got the following error:
2020-07-06 20:40:46 default[20200706t233945]  TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
2020-07-06 20:40:46 default[20200706t233945]      at validateString (internal/validators.js:125:11)
2020-07-06 20:40:46 default[20200706t233945]      at Object.join (path.js:1147:7)
2020-07-06 20:40:46 default[20200706t233945]      at readConfig (/srv/node_modules/caccl/validateConfigAndSetDefaults/server.js:23:29)
2020-07-06 20:40:46 default[20200706t233945]      at module.exports (/srv/node_modules/caccl/validateConfigAndSetDefaults/server.js:33:26)
2020-07-06 20:40:46 default[20200706t233945]      at module.exports (/srv/node_modules/caccl/server/index.js:133:18)
2020-07-06 20:40:46 default[20200706t233945]      at Object. (/srv/index.js:7:13)
2020-07-06 20:40:46 default[20200706t233945]      at Module._compile (internal/modules/cjs/loader.js:778:30)
2020-07-06 20:40:46 default[20200706t233945]      at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
2020-07-06 20:40:46 default[20200706t233945]      at Module.load (internal/modules/cjs/loader.js:653:32)
2020-07-06 20:40:46 default[20200706t233945]      at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
2020-07-06 20:40:47 default[20200706t233945]  "GET /favicon.ico HTTP/1.1" 500
2020-07-06 20:40:48 default[20200706t233945]  internal/validators.js:125
2020-07-06 20:40:48 default[20200706t233945]      throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
2020-07-06 20:40:48 default[20200706t233945]      ^
any ideas?
thank you for your help!
Lior.

Hi Lior,
Thank you for the detail you provided! I pushed a small fix that might work for the Google App Engine, though I am less familiar with that platform so could you test it out?
Please update to CACCL v1.1.26 and try again.
Looking forward to seeing how this goes :)
Best,
Gabe

Hi Gage,
thanks for your answer and fix!
well i haven't tried your fix yet, but i have found the cause of the error
apparently, when using the standard app engine (as opposed to the flexible app engine) there is no postscript running after the npm install to check for more depndencies to install. i uploaded the app to flexible app eninge (which costs money...) and all worked well :)
so this is the fix for the standard app engine: simply don't use it and deploy on flexible app engine...
btw, i have another question: i have deployed the app on heroku (piece of cake!!!) i have followed the instructions, set all config vars (CANVAS_HOST, CLIENT_ID,  CLIENT_SECRET, CONSUMER_KEY, CONSUMER_SECRET) tho i'm not usin the API, and set the initCaccl  to this:
// Initialize CACCL
const app = initCACCL({
disableAuthorization: true,
disableClientSideAPI: true,
disableServerSideAPI: true,
});
added and called the app from canvas. got this error: "Please launch this app via canvas" and set
any ideas?
thank you again for your time and for the amazing lib1 i've been through many libs but this one simpley works out of the box, it's truly amazing.
lior.

Stale. Closing due to inactivity. Please feel free to re-open if helpful!


[FEATURE] Triumphant crossing out of completed tasks (~~fanfare~~)

When a task is completed (i.e. moved to Done status) there should be some sort of user feedback that helps the user feel accomplishment at finishing a task.

Is this issue still available then I would like to give it a try.

You're absolutely welcome to give it a go! I was planning on adding confettijs to the done event but I'm welcome to other input.
I don't yet have a contributing guide but please make your changes to the testing branch.

Hi,
I was also thinking of using https://github.com/loonywizard/js-confetti
I also saw that you are trying to migrate to FastAPI but have you seen Streamlit? It’s implementation is fast and easy

I haven't seen Streamlit, but it definitely seems cool. I don't think it's a good fit for NoScrum, but I will definitely consider it for future projects.


Benchmarks are misleading

After looking at the reason for the speed improvements the benchmarks are misleading/invalid.  The majority of the speedup comes because cuprite is set Capybara.default_max_wait_time to 0 for a large part of the Capybara specs, which means a large number of them aren't actually testing anything and makes the timing non-comparable to Selenium headless Chrome.  If Selenium headless Chrome is run with the same modified wait times  on Travis it's time drops from around 14 minutes to under 10 (but again it's not valid to do so since it means a large number of tests aren't actually doing anything).  Assuming a similar percentage speedup for the invalid tests, running Selenium headless Chrome on the hardware you benchmarked it on should be in the 7 minute range just like cuprite

@route I have been unable replicate a speed improvement using Capybara.server = :webrick -- that slows it down by a couple minutes relative to puma in our environment.
I have observed something else of interest, though... we are building on CircleCI using two containers and I was seeing some sporadic failures due to timeouts with the default 5 sec browser timeout. As I increased the timeout, however, the rspec job became much slower... when profiling the run, it looks like increasing the timeout is causing a slower overall run for some reason.
Here's an example comparing two successful runs:
10 sec timeout:
Top 10 slowest examples (296.26 seconds, 29.8% of total time):
Top 10 slowest examples (247.2 seconds, 21.8% of total time):
=> 27.1 sec avg across the 20 slowest examples, 19:54 total time

15 sec timeout:
Top 10 slowest examples (368.18 seconds, 28.6% of total time):
Top 10 slowest examples (373.79 seconds, 30.0% of total time):
=> 37.1 sec avg across the 20 slowest examples, 22:49 total time

Looking at Ferrum, it seems like the key line is simply data =<EMAIL_ADDRESS>in browser/client.rb's command method.
It does not seem like increasing the timeout should reduce the responsiveness of the call to pending.value!, but that is what appears to be happening... and I've not used concurrent-ruby before.
I would have expected that increasing the timeout would allow for occasional slow responses without generating a Timeout error, but not in general result in overall slower performance. In my case, increasing the timeout makes our test suite take longer. A run with a 30 sec timeout topped out at 34:58 total time.
Curious if you've seen anything like that in your experience...

@lawso017 I haven't found the issue with Capybara.server but that means the issue is in our application then.
In Ferrum/Cuprite there are a few places that are related to timeout but in general if your test is passing then it usually means test is not properly written but it can be a bug somewhere. I've seen some cases even in our application I had to rewrite tests a bit but can't remember now. Run FERRUM_DEBUG=true bundle exec rspec spec/file for one of the suspicious tests with increased timeout and send me the log file to email, I'll save you some time I can find the issue pretty quick.


Add a waiting bar / progress bar widget.

A widget like a graphical progress bar (or other graphic element) based on values supplied by user code.  Could be used as load waiting progress, other progress indicator, player health, etc.

Good idea. Will look into it.

Done


Users Component

Component for generating, adding, and removing new users to the UI

Probably should use the Polkadot Browser Extension for this actually...


You should be able to add a turbofish in a struct expression

This Sway code should work:

struct Data<T> {
    value: T
}

impl Data<T> {
    fn new(value: T) -> Data<T> {
        Data {
            value
        }
    }
}

fn main() -> bool {
    let data = Data::<u64>::new(7);
    let data2 = Data::<u64> {
        value: 7
    };
    true
}

See the equivalent Rust code: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=8075e3f15fc8b382b58030adb8b88c23

Closed by #913 and #1013


Rasberry Pi Art

Represents a rasberry pi since I have one at my own workstation. I used python to generate the coordinates needed by taking an image, applying lots of filters to it and detecting outlines/contours on it to output the final list of coordinates which I put in the js file. The section at the bottom of the canvas is meant as a reflection and can be omitted. Any image can be generated as well!

Hey! Cool idea, but blot pieces need to be generative! That means that each time you run the code, something about this art piece needs to change. Please look over the submission guidelines carefully and update your PR. Once updated, I will be happy to re-review! (btw your art cannot exceed the size of 125x125, please keep it in that square!)


Lights controlled as group are not marked as manually controlled

Home Assistant Adaptive Lighting Issue Template
Bug Reports
If you need help with using or configuring Adaptive Lighting, please open a Q&A discussion thread here instead.
Before submitting a bug report, please follow these troubleshooting steps:
Please confirm that you have completed the following steps:

[x] I have updated to the latest Adaptive Lighting version available in HACS.
[x] I have reviewed the Troubleshooting Section in the README.
[x] (If using Zigbee2MQTT) I have read the Zigbee2MQTT troubleshooting guide in the README.
[x] I have checked the V2 Roadmap and open issues to ensure my issue isn't a duplicate.

Required information for bug reports:
Please include the following information in your issue.
Issues missing this information may not be addressed.

Debug logs captured while the issue occurred. See here for instructions on enabling debug logging:

Your Adaptive Lighting configuration:

adaptive_lighting:
  - name: "Bedroom"
    lights: [light.bedroom_ambient, light.bedroom_ambient_2]
    prefer_rgb_color: true
    initial_transition: 10
    transition: 0
    sunrise_time: "07:30:00"
    sunset_time: "20:00:00"

Describe the bug and how to reproduce it:

AL stoped marking lights as manually controlled when light is controlled by a group (HA group, not zigbee).
Following code tha reacts to my pilot:
- alias: Ikea remote
  id: "1499"
  description: ""
  use_blueprint:
    path: ikea_remote.yaml
    input:
      remote: sensor.pilot_1_action
      button_on:
        - type: brightness_increase
          device_id: e0f41cbd8d042797468be62c40b663cf
          entity_id: light.automatic
          domain: light
      button_off:
        - device_id: e0f41cbd8d042797468be62c40b663cf
          entity_id: light.bedroom_ambient
          type: brightness_decrease
          domain: light
      button_left_click:
        - service: input_boolean.toggle
          entity_id: input_boolean.night_enabled

Works: When buttton off is presed and a brightness is decreases only of a single light.
Doesn't work: When button on is pressed and brightness is increase for a group of lights (they go back to AL control after few seconds).

This is referenced in state of AL when manual control contains only lights changed directly, but does not include lights of group.

Steps to reproduce the behavior:

Add light (controlled by AL) to group

Set brightness to group manually. Light will come back to AL brightness after a while

I'm sure this was working before, but not sure in which version.

light.automatic is a group of lights
light.bedroom_ambient is single light

For clarification

I'm having mixed results with this.  In my living room, it seems like light.living_room has no problem whatsoever listing out the lights in the group and then applying them under manual control.
In my office, I can't get any of them to be manual control, regardless of whether it is a group or not.


Unable to run the test.sh No resources found error

Hi,
I am using this starterkit to deploy jmeter within k8s, I have deployed within my EKS cluster and all the pods are up and running which can be seen here as well. When I run the test with this ./start_test.sh -j my-scenario.jmx -n default -c -m -i 10 -r command it does not work.

NAME                              READY   STATUS      RESTARTS   AGE
pod/grafana-57cd5db667-n5jrs      1/1     Running     0          2d17h
pod/influxdb-d6f8b6c89-g7f9j      1/1     Running     250        2d17h
pod/jobs-cleanup-27574868-m9sbh   0/1     Completed   0          24s
pod/telegraf-jqxfj                1/1     Running     0          2d17h
pod/wiremock-7cf4bfbc68-kjj96     1/1     Running     0          2d17h

**NAME                        TYPE           CLUSTER-IP      EXTERNAL-IP                                                              PORT(S**
)                       AGE
service/grafana             LoadBalancer   <IP_ADDRESS>   a2f6114d9eb4949e18215f8f25f13394-311111111.us-east-2.elb.amazonaws.com   443:31
509/TCP                 2d17h
service/influxdb            ClusterIP      None            <none>                                                                   8086/T
CP                      2d17h
service/jmeter-slaves-svc   ClusterIP      None            <none>                                                                   1099/T
CP,50000/TCP,4445/TCP   2d17h
service/kubernetes          ClusterIP      <IP_ADDRESS>      <none>                                                                   443/TC
P                       5d18h
service/wiremock-svc        ClusterIP      None            <none>                                                                   8080/T
CP                      2d17h

****NAME                      DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE****
daemonset.apps/telegraf   1         1         1       1            1           <none>          2d17h

**NAME                       READY   UP-TO-DATE   AVAILABLE   AGE**
deployment.apps/grafana    1/1     1            1           2d17h
deployment.apps/influxdb   1/1     1            1           2d17h
deployment.apps/wiremock   1/1     1            1           2d17h

**NAME                                  DESIRED   CURRENT   READY   AGE**
replicaset.apps/grafana-57cd5db667    1         1         1       2d17h
replicaset.apps/influxdb-d6f8b6c89    1         1         1       2d17h
replicaset.apps/wiremock-7cf4bfbc68   1         1         1       2d17h

NAME                                               REFERENCE             TARGETS   MINPODS   MAXPODS   REPLICAS   AGE
horizontalpodautoscaler.autoscaling/hpa-wiremock   Deployment/wiremock   0%/30%    1         5         1          2d17h

NAME                         SCHEDULE      SUSPEND   ACTIVE   LAST SCHEDULE   AGE
cronjob.batch/jobs-cleanup   */1 * * * *   False     0        32s             2d17h

NAME                              COMPLETIONS   DURATION   AGE
job.batch/jmeter-master           0/1                      3m12s
job.batch/jmeter-slaves           0/1 of 10                3m9s
job.batch/jobs-cleanup-27574868   1/1           1s         32s

After running the test using this command ./start_test.sh -j my-scenario.jmx -n default -c -m -i 10 -r :
:~/Downloads/talha/cdpaas/jmeter-k8s$ ./start_test.sh -j my-scenario.jmx -n default -c -m -i 10 -r
 [ INFO ] [ 06-06-22 10:15:42 ] Recreating pod set
job.batch "jmeter-master" deleted
job.batch "jmeter-slaves" deleted
job.batch/jmeter-master created
persistentvolumeclaim/jmeter-data-dir-pvc unchanged
service/jmeter-slaves-svc unchanged
job.batch/jmeter-slaves created
job.batch/jmeter-slaves patched (no change)
 [ INFO ] [ 06-06-22 10:15:55 ] Waiting for all slaves pods to be terminated before recreating the pod set
 [ INFO ] [ 06-06-22 10:15:57 ] Scaling the number of pods to 10.
job.batch/jmeter-slaves patched
 [ INFO ] [ 06-06-22 10:16:00 ] Waiting for pods to be ready
No resources found in default namespace.

No resources found in default namespace.

No resources found in default namespace.

No resources found in default namespace.

No resources found in default namespace.

No resources found in default namespace.

No resources found in default namespace.

No resources found in default namespace.

No resources found in default namespace.

No resources found in default namespace.

@Rbillon59 Please help me out with this issue. I liked your work and want to utilize it for stress testing of my APIs. I will be waiting for your quick response, Thank you!

Hello,
It seems the jmeter pods creation are failing
Would you please run the kubectl describe command against one of the Jmeter pods and paste the logs here ?
Thank you

$ kubectl describe jobs.batch jmeter-master
Name:           jmeter-master
Namespace:      default
Selector:       controller-uid=c480e86c-1f71-4476-911f-44f3562d6b55
Labels:         jmeter_mode=master
Annotations:    <none>
Parallelism:    1
Completions:    1
Pods Statuses:  0 Active / 0 Succeeded / 0 Failed
Pod Template:
  Labels:       controller-uid=c480e86c-1f71-4476-911f-44f3562d6b55
                jmeter_mode=master
                job-name=jmeter-master
  Annotations:  telegraf.influxdata.com/class: app
                telegraf.influxdata.com/inputs:
                  [[inputs.jolokia2_agent]]
                    urls = ["http://localhost:8778/jolokia"]

                    [[inputs.jolokia2_agent.metric]]
                      name  = "java_runtime"
                      mbean = "java.lang:type=Runtime"
                      paths = ["Uptime"]

                    [[inputs.jolokia2_agent.metric]]
                      name  = "java_memory"
                      mbean = "java.lang:type=Memory"
                      paths = ["HeapMemoryUsage", "NonHeapMemoryUsage", "ObjectPendingFinalizationCount"]

                    [[inputs.jolokia2_agent.metric]]
                      name     = "java_garbage_collector"
                      mbean    = "java.lang:name=*,type=GarbageCollector"
                      paths    = ["CollectionTime", "CollectionCount"]
                      tag_keys = ["name"]

                    [[inputs.jolokia2_agent.metric]]
                      name  = "java_last_garbage_collection"
                      mbean = "java.lang:name=G1 Young Generation,type=GarbageCollector"
                      paths = ["LastGcInfo/duration", "LastGcInfo/GcThreadCount", "LastGcInfo/memoryUsageAfterGc"]

                    [[inputs.jolokia2_agent.metric]]
                      name  = "java_threading"
                      mbean = "java.lang:type=Threading"
                      paths = ["TotalStartedThreadCount", "ThreadCount", "DaemonThreadCount", "PeakThreadCount"]

                    [[inputs.jolokia2_agent.metric]]
                      name  = "java_class_loading"
                      mbean = "java.lang:type=ClassLoading"
                      paths = ["LoadedClassCount", "UnloadedClassCount", "TotalLoadedClassCount"]

                    [[inputs.jolokia2_agent.metric]]
                      name     = "java_memory_pool"
                      mbean    = "java.lang:name=*,type=MemoryPool"
                      paths    = ["Usage", "PeakUsage", "CollectionUsage"]
                      tag_keys = ["name"]

                  [[inputs.jolokia]]
                    context = "/jolokia/"
                  [[inputs.jolokia.servers]]
                    host = "<IP_ADDRESS>"
                    port = "8778"
                  [[inputs.jolokia.metrics]]
                    name = "heap_memory_usage"
                    mbean  = "java.lang:type=Memory"
                    attribute = "HeapMemoryUsage"
                  [[inputs.jolokia.metrics]]
                    name = "thread_count"
                    mbean  = "java.lang:type=Threading"
                    attribute = "TotalStartedThreadCount,ThreadCount,DaemonThreadCount,PeakThreadCount"
  Containers:
   jmmaster:
    Image:      rbillon59/jmeter-k8s-base:5.4.1
    Port:       60000/TCP
    Host Port:  0/TCP
    Command:
      /bin/bash
    Args:
      -c
      trap 'exit 0' SIGUSR1 && while true; do sleep 30;done
    Limits:
      cpu:     1024m
      memory:  2Gi
    Requests:
      cpu:     1024m
      memory:  1Gi
    Liveness:  exec [cat /opt/jmeter/apache-jmeter/bin/jmeter] delay=5s timeout=1s period=5s #success=1 #failure=3
    Environment:
      MODE:       MASTER
      NODE_NAME:   (v1:spec.nodeName)
      POD_NAME:    (v1:metadata.name)
      NAMESPACE:   (v1:metadata.namespace)
    Mounts:
      /report from jmeter-data-dir (rw)
  Volumes:
   jmeter-data-dir:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  jmeter-data-dir-pvc
    ReadOnly:   false
Events:
  Type     Reason        Age                  From            Message
  ----     ------        ----                 ----            -------
  Warning  FailedCreate  12s (x6 over 2m42s)  job-controller  Error creating: admission webhook "telegraf.influxdata.com" denied the request: secrets is forbidden: User "system:serviceaccount:telegraf-operator:telegraf-operator" cannot create resource "secrets" in API group "" in the namespace "default"

Oh it seems the telegraf operator is messing at some point.
I'll try to reproduce the issue. In the meantime, you can delete the operator, you will miss some monitoring metrics, but you should be able to run your test

I think I I got it.
Try to launch the test again without specifying the namespace in the command line, and let me know the output please.
Thanks

@Rbillon59 It does not work if the namespace is not provided,
~/Downloads/talha/cdpaas/jmeter-k8s$ ./start_test.sh -j my-scenario.jmx  -c -m -i 20 -r
 [ ERROR ] [ 06-06-22 12:09:39 ]  Namespace not provided!
 [ INFO ] [ 06-06-22 12:09:39 ] -j <filename.jmx>
 [ INFO ] [ 06-06-22 12:09:39 ] -n <namespace>
 [ INFO ] [ 06-06-22 12:09:39 ] -c flag to split and copy csv if you use csv in your test
 [ INFO ] [ 06-06-22 12:09:39 ] -m flag to copy fragmented jmx present in scenario/project/module if you use include controller and external test fragment
 [ INFO ] [ 06-06-22 12:09:39 ] -i <injectorNumber> to scale slaves pods to the desired number of JMeter injectors
 [ INFO ] [ 06-06-22 12:09:39 ] -r flag to enable report generation at the end of the test

I deleted the telegraph operator namespace , and then ran the test (namespace provided) and it worked.

Thank you @Rbillon59 I must appreciate the immediate response from your side. I am very thankful to you, Rbillon. I will look into it and create a bug (issue) for the problem in telegraph operator so that it can be fixed. Regards


another simple cvxopt unknown example

For future analysis, here is a relatively simple but perfectly valid Model that cvxopt cannot solve with default settings.
"""Commercial Aircraft Model loosely inspired by TASOPT"""
import numpy as np
from gpkit import Variable, Model

rho = Variable("\\rho", 0.4, "kg/m^3", "air density")
a = Variable("a", 300, "m/s", "speed of sound")
Wtemp = Variable("W_deleteme", 1, "lbf")
e = Variable("e", 0.85, "-", "Oswald efficiency")
S = Variable("S", 1300, "ft^2", "wing area")
A = Variable("A", 9.45, "-", "Aspect ratio")
Wwing = Variable("W_{wing}", "lbf", "wing weight")
CD = Variable("C_D", "-", "drag coefficient")
CL = Variable("C_L", "-", "lift coefficient")
Wfuel = Variable("W_{fuel}", 36864.9, "lbf", "fuel weight")
W = Variable("W", "lbf", "total weight")
V = Variable("V", "knots", "true airspeed")
T = Variable("T", "lbf", "thrust")
M = Variable("M", "-", "Mach number")
We = Variable("W_e", 84749.8, "lbf", "empty weight")
Wpay = Variable("W_{pay}", 38700, "lbf", "payload weight")
Wdry = Variable("W_{dry}", "lbf", "dry weight")

constraints = [W <= 0.5*rho*V**2*CL*S,
               T >= 0.5*rho*V**2*CD*S,
               Wwing >= Wtemp,
               CD >= 0.02 + CL**2/np.pi/e/A,
               W >= Wdry + Wfuel,
               M == V/a,
               Wdry >= We + Wpay + Wwing,
              ]

m = Model(T/V, constraints)
sol = m.solve()

As far as I can tell there is nothing wrong with this model. Here are two solver changes that cause it to solve:

solve with Mosek (sol = m.solve(solver="mosek"))
solve with cvxopt's ldl kktsolver (sol = m.solve(kktsolver="ldl"))

And for analyzing the cvxopt failure, here are some model changes, each of which causes cvxopt to solve the model with default settings:

change the first inequality to an equality (W == 0.5*rho*V**2*CL*S,)
remove the isolated constraint M == V/a
Increase the constant value of Wtemp to 10000
Remove the last constraint and replace W >= Wdry + Wfuel with W >= We + Wpay + Wwing + Wfuel

Super weird.

Pretty sure it's a rank issue associated with solving the KKT system -- we might want to consider changing our solve default to use kktsolver="ldl" for cvxopt

I think we should do that. Does it require a newer version of cvxopt?

any reason to keep this open now that #795 is merged?

Smells like success to me.


Merge s3_success and s3_build_error tests into one test

Which issue does this PR close?
Closes #3601
Rationale for this change
Fixing fragile tests
What changes are included in this PR?

Merge s3_build_error and s3_success into one test

Are there any user-facing changes?
No.

Thank you


chore(cmd-socketio-server): rename package to match directory name

Describe the bug
The package is called cactus-cmd-socket-server while the directory is called cactus-cmd-socketio-server
To Reproduce
Look at the package and the directory names.
Expected behavior
Package and directory names match exactly. Package should be renamed to match the directory name.
cc: @outSH @izuru0 @takeutak

To Reproduce
Look at the package and the directory names.

:heart:


optoth and merlinth on torch >= 2.0

Is merlinth, in general, supported with torch version >= 2.0? I have trained models in the past using torch 1.10+cu111, but upgraded to torch 2.1+cu118 to use some packages only supported in torch >= 2.0. I can evaluate my merlinth models using torch 2.1, but when I try to continue training, after a single backprop step all the weights become NaN. I'm curious as to whether optoth/merlinth are compatible with the newer versions of pytorch. I see that in the setup.py file it only requires >= 1.0. I'm just not sure if this is something not currently supported at all or if there is something wrong with the way I am building.
Thanks!
Best,
Brian

After some more testing I realize that this only occurs when I load a torch 1.10 model and try to continue training in torch 2.1. But it does not occur when I start training a torch 2.1 model from scratch. So I think this is a torch issue, not a merlinth one. Sorry for any confusion. Thank you for this fantastic package!
Best,
Brian

Good to hear! Thanks for letting us know.


External app transaction refund problem

What I'm trying to achieve
I'm trying to make refund with external app.
Steps to reproduce the problem

create order
make transaction (mark order as paid because of #10153)
update transaction with charged status
make refund
external app updates transaction with refund_amount
order still have FULLY_PAID status, so in Dashboard refund amount is 0

What I expected to happen
Order payment status will be updated with updating transaction
System information
Saleor version:

3.5

Hey  @batas
Can you provide more details here?
point 2 - Please share the mutation data that you use
point 3. - Please share your mutation data
point 4. What exactly do you mean? Do you mean calling a refund from Saleor dashboard? From Payment provider?
point5 - Please share the mutation data that you use
point 6 - can you make a query for the order with details like order.transactions, order.payments, order.paymentStatus, order.authorizeStatus, order.total, total.balance

I found a problem. My case it was a result of wrong usage of API. Major problem is with handling
        if not payment:
            payment = self.get_last_payment()
        if not payment:
            return False
        order_status_ok = self.status not in {OrderStatus.DRAFT, OrderStatus.CANCELED}
        return payment.can_capture() and order_status_ok

    def can_void(self, payment=None):
        if not payment:
            payment = self.get_last_payment()
        if not payment:
            return False
        return payment.can_void()

    def can_refund(self, payment=None):
        if not payment:
            payment = self.get_last_payment()
        if not payment:
            return False
        return payment.can_refund()

    def can_mark_as_paid(self, payments=None):
        if not payments:
            payments = self.payments.all()
        return len(payments) == 0

in saleor/order/models.py
With transactions (not payments) I have MARK_AS_PAID only. When I patch this code to have other actions, the system works properly.
Should I create a new ticket with this bug? It is exactly, what I described in https://github.com/saleor/saleor/issues/10153


Incorrect array size validation for vec3 in Python bindings

I believe there's a typo in the Python bindings which impacts writing vec3 attributes into OpenEXR headers from numpy arrays.
https://github.com/AcademySoftwareFoundation/openexr/blob/39010bff70a3911a32a725cb2f349244635a7024/src/wrappers/python/PyOpenEXR.cpp#L1557
    else if (py::isinstance<py::array_t<T>>(object))
    {
        auto a = object.cast<py::array_t<T>>();
        if (a.ndim() == 1 && a.size() == 2)
        {
            auto p = static_cast<T*>(a.request().ptr);
            v.x = p[0];
            v.y = p[1];
            v.z = p[2];
            return true;
        }
    }

The 2 should be a 3 for it to correctly detect arrays of the correct size.

Thanks for the catch, yes, apparently a copy/paste error from objectToV2.  And unfortunately the but was specific to float but the test only validated double. Should be fixed in #1945.


Enable manual specification of curve

There's a lot of discourse online that the NIST curves are cooked. I should itemize what curves are supported and detail them in the README.

https://safecurves.cr.yp.to/


UX Fluent and language indicator icons not displayed nicely when screen width is narrow

When using the CMS in split mode and with a narrow screen width the Fluent icons and language indicator icons get smooshed with the field titles. See screenshot below:

This is related to #343 which isn't merged yet - hold for now!

Indeed #343 has been closed without being merged.
In the feedback @clarkepaul suggested the following UX changes https://projects.invisionapp.com/share/ZBFVZJCKU38#/screens/279729292_X_Fluent to indicate the locale instead.
I am closing this issue as it is not relevant any longer.


Update Objects via Query

Is it possible to update objects via a query return?

I don't know what you mean by "query return" but you can update objects. See the README.

Can I update objects that match a query?
—
Sent from Mailbox
On Sat, Feb 7, 2015 at 9:44 PM, Jayson Basañes<EMAIL_ADDRESS>wrote:

I don't know what you mean by "query return" but you can update objects. See the README.
Reply to this email directly or view it on GitHub:
https://github.com/shiki/kaiseki/issues/27#issuecomment-73398163

I think this is a question on the Parse API. Try checking their API documentation.


ClusterAdmin Support

@eapache @buyology @Mongey @mimaison @ongardie-ebay
I started working on ClusterAdmin support and wrote an initial draft version. Want to get your comments that I am moving in the right direction. After your comments i will close to the pull request.

@eapache  what is the convenient way to access broker (CreateTopic , DeleteTopic from client. I exposed Any() from client interface but i agree it is not needed.I tried using brokers but it is not guaranteed they are open always. My tests failed with broker not connected.  Can you please suggest any other way to access the underlying brokers which are opened .  I will make  those changes .

I would suggest that we first settle on the design in #1048 before finalising the implementation.
Also, the answer to the question about how to access the broker is that some of the methods (CreateTopics, DeleteTopics, CreatePartitions) must go through the controller — and the method for retrieving the controller is not yet implemented.

Thanks @buyology  , will wait for the design to be finalized and method for retrieving the controller.

@eapache  @buyology , I integrated the controller for this pull request. let me know if you have any comments or changes that needs to be done .

Did you intend to push https://github.com/Shopify/sarama/pull/1116 to this PR instead?

This looks pretty good to me now. Could you please squash/rebase your commits?

Done squashing all the commits .

Thanks!


Dashboard of DMP CMS

Delayed due to #412

@MohitNSamagra to pick in 2412

BE changes done by Sasi
Call pending with PT to create the dashboard.

Call with PT done - metabase dashboard to be made by PT

Db reviewed by @MohitNSamagra
PT to pick up on 19th June

To be picked by PT next week

Being tested by PT.

Closing this as no update from PT


build-product: docker lint error is not shown

fe https://github.com/datavisyn/aelixir_product/actions/runs/3486803730

handled in https://github.com/datavisyn/github-workflows/issues/16


Suggestion: option to show/hide function parentheses in autocomplete entries

In some past version (I don't remember which one), rust-analyzer started adding parentheses to functions in autocomplete suggestions. In the example below, parentheses are appended to function names:

functions without arguments receive ();
those with arguments receive (...):

My suggestion is making these parentheses optional, so their rendering can be enabled or disabled by the user.

These are already optional (at least on VSCode):
simply add "rust-analyzer.completion.addCallParenthesis": false to your settings.json file and the parentheses are gone.

It'd be interesting if you could elaborate why you want to disable them, though.

@mahdi-frms Yes, rust-analyzer.completion.addCallParenthesis gets rid of the parentheses in the list. However, it also gets rid of the auto-added parentheses when you hit Enter. I believe these should be controlled by two different settings.
@flodiebold I have three reasons to justify why I don't need them:

Latest version brought #9494, which I personally consider fantastic, but now we have a lot of parentheses on each line;
We already have the second box with parentheses and parameters – in my screenshot, it's the box at the right of the autocompletion list, showing fn(&self, i32).
We already have different icons with different colors to differentiate methods from fields.

Yes, I personally believe we should have separate settings for them.

I'd like these parens to be optional at the time of autocompletion, rather than as a blanket setting.  In particular, they're a pain when I'm trying to pass a function as a callback, rather than trying to call the function directly.


Error message logged when creating NetMHC

INFO:root:Skipping allele Unrecognized parameter: -A: Malformed MHC type A

What do you mean "when creating"? Is this a 3.x vs. 4.x issue?

netmhc = mhctools.NetMHC(alleles=["HLA-A0201"])
I seem to have NetMHC 4.0:
$ netmhc
# /Users/iskander/code/netmhc-bundle/netMHC-4.0/Darwin_x86_64/bin/netMHC
...

On Tue, May 24, 2016 at 6:22 PM, Tavi Nathanson<EMAIL_ADDRESS>wrote:

What do you mean "when creating"? Is this a 3.x vs. 4.x issue?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/hammerlab/mhctools/issues/53#issuecomment-221419774

I seem to have NetMHC 4.0:
$ netmhc
# /Users/iskander/code/netmhc-bundle/netMHC-4.0/Darwin_x86_64/bin/netMHC

I should have said "instantiating": netmhc = mhctools.NetMHC(["A0201"])

This is the same as Topiary #41

Thanks @JPFinnigan, I knew it looked familiar!


Using Capture to save results in CQLSH with Tracing on incorrectly saves the trace details

The Cassandra Jira

Hi @bschoening ,
Here are the changes I have made.
When code is able to redirect the results to file and traces to stdout (i.e shell). But the color is not preserved.
As you can see, the below image is the output of Trace without Capture

The below image is the output of Trace during capture.

Open to suggestions. Thank you.

Hi @bschoening,
The current changes works as expected.
Open for suggestions.
Thank you


Is it possible to do gzip() a file with a password? If so, how please?

I would like to zip and unzip my files with a password if possible, I am not sure ! Thanks.
				if let compressedData = html.data.gzip() {
					try compressedData.write(to: filePath)
				}

Encryption is not supported by this library. But it is of course possible to add encryption after compression.
Maybe you can find what you need here:
https://developer.apple.com/documentation/cryptokit/performing_common_cryptographic_operations
Just for info, compression should be performed before encryption. If not, the high entropy of encrypted data streams will cause a very poor compression rate, regardless of which compression algorithm you use.


Task version upgrade to support latest arm rest v2 package

Task name: AzureResourceManagerTemplateDeployment
Description: Task version upgrade to  install latest version of arm-rest-v2 package
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) https://dev.azure.com/mseng/AzureDevOps/_workitems/edit/1874576
Checklist:

[x] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected

@tejasd1990 Could you please approve changes.

@v-abajaj although it is not mandaotry, it would be good to increment the azure-pipelines-tasks-azure-arm-rest-v2 version to ^2.0.6 in package.json. Also, as discussed, you should increment task version for V2 version of the task as well.

@tejasd1990  I have done the suggested changes. Please review.


Allow high-level HACL-WASM API to only load a subset of the WASM files

This leverages the latest changes in krml.
Note that to test these changes, one has to first do cp ../../dist/wasm/* . then do node test2.js and/or http-server . to navigate to test.html

Would love a review from @w95psp... thanks!

For some reason I can't seem to be able to request a review from you... weird


Mix use entry in plugin and in webpack

Mix use entry in plugin and in webpack
I want to take advantage of the recursive entries in the plugin config which is very convenient, but I also have non-html entry points that I want to specify in webpack-level entry field. I'm wondering what is the best practice to do so.
It would be very nice if anyone can guide me over that.

Hello @dawnchan030920,
you can use default Webpack entry for your JS/CSS entires:
module.exports = {
  mode: 'production',

  output: {
    path: path.join(__dirname, 'dist/'),
  },

  entry: {
    main: './src/main.js', // => dist/js/main.js
    style: './src/styles.scss', // => dist/css/style.css
  },

  plugins: [
    new HtmlBundlerPlugin({
      entry: {
        index: 'src/views/index.html', // => dist/index.html
      },
      js: {
        // output filename for JS files defined in webpack.entry and in html
        filename: 'js/[name].js',
      },
      css: {
        // output filename for CSS files defined in webpack.entry and in html
        filename: 'css/[name].css',
      },
    }),
  ],

  module: {
    rules: [
      {
        test: /\.(s?css)/,
        use: ['css-loader', 'sass-loader'],
      },
    ],
  },
};

advantage of the recursive entries in the plugin
what do you mean? An example?

advantage of the recursive entries in the plugin

what do you mean? An example?

keep the directory strcucture

I have non-html entry points

I can only imagine one use case: if you build a css/js package to use as a library.

I want to transform markdown files using remark-loader and the loader this plugin

@dawnchan030920
can you please create small repo with minimum required files (html, *.md, js, css, webpack.config.js, ...) then I can help you.

Sorry for being unclear about my question and providing little information😭
the minimal example
I'm wondering if I could set entry in plugin's option to bundle all html files under src and set entry in webpack to specify the markdown as entry.
Thank you for your patient answering!

@dawnchan030920
the Webpack.entry and plugin.entry is the same place with the same structures.
But only in plugin.entry you can provide template variables, because the original Webpack.entry structure doesn't this feature. Also, the plugin.entry is the same Webpack.entry + the data option to pass external variables into the template.

Thank you for your explanation.


Avoid deprecated has_key function

The has_key function was removed with:
https://github.com/puppetlabs/puppetlabs-stdlib/pull/1319

Thanks!


Support hardhat

A list of known issues:

New provider design (see buidler 608)
New artifact pipeline (see synthetix 739)

Hey Chris!
Lot's of new things are coming out with hardhat. We'll have a migration guide for plugins in a few days.
We also took some time to adapt solidity-coverage. We'll send a PR soon. We are just finishing some details on how plugins are managed. Hardhat will be closer to the og version of Buidler, were plugins were just imported/required. This means that users won't need to deal with the type extensions manually.

Hey @cgewecke, we have a migration guide for plugins now: https://github.com/nomiclabs/buidler-ts-plugin-boilerplate/blob/hardhat-migration/MIGRATION.md
There are @rc version of the hardhat plugins now. The main package is hardhat, and the plugins @nomiclabs/hardhat-*

@alcuadrado
Do you think it might make sense to make a new repo called hardhat-gas-reporter and deprecate this one?

We are planning to rename the repos and leave a 1-line message explaning about the migration in the readme.

@cgewecke @alcuadrado
How is adding support for hardhat coming along?

@mudgen Will look at this weekend. Should be simple here...

hola!
any news on the support for hardhat?
thanks!

@jmonteer Doing it today!!    I am curious.  Is it easy or hard to port a buidler plugin to hardhat?

Let me know if you need help with this, Chris!

@alcuadrado Thanks Patricio!

@mudgen There's a beta published now if you need this ASAP.
npm install --save-dev hardhat-gas-reporter@beta

If there are contracts that Hardhat needs a path-qualified name to load the artifact of, they'll be missing from the report.
This should only happen if the contract name is duplicated somewhere in the project (like in a node_modules dependency) or you're staging multiple versions of the same contracts in your project (like old/, new/)

@cgewecke Great. Thank you.

This is out as<EMAIL_ADDRESS>Please just lmk if you run into problems with this. One thing that jumped out in e2e testing is that projects with qualified contract names have wide reports. (Perhaps over-wide, really)
Addressing that in a forth-coming patch at eth-gas-reporter and tracking the issue here in #40.


[EasyTesting] Update wording error on ValidateFixtureSkipNamingCommand

ref https://github.com/rectorphp/rector/pull/5081#issuecomment-753648064

The ----- check need to be added as well ref https://github.com/rectorphp/rector/pull/5081#issuecomment-753649295

The ----- check need to be added as well ref https://github.com/rectorphp/rector/pull/5081#issuecomment-753649295


Override DisplayName to match PropertyName on complex properties

Consider your example from the wiki.
public class Customer {
  public string Name { get; set; }
  public Address Address { get; set; }
}

public class Address {
  public string Line1 { get; set; }
  public string Line2 { get; set; }
  public string Town { get; set; }
  public string County { get; set; }
  public string Postcode { get; set; }
}

public class AddressValidator : AbstractValidator<Address> {
  public AddressValidator() {
    RuleFor(address => address.Postcode)
        .NotNull()
        .WithMessage("{PropertyName} should not be null.")
        .WithName("Address.Postcode")
        .OverridePropertyName("Address.Postcode");
  }

public class CustomerValidator : AbstractValidator<Customer> {
  public CustomerValidator() {
    RuleFor(customer => customer.Name).NotNull();
    RuleFor(customer => customer.Address)
        .SetValidator(new AddressValidator())
        .OverridePropertyName("Customer");
  }
}

Same as oaiko on issue https://github.com/JeremySkinner/FluentValidation/issues/579, I expected that PropertyName and DisplayName could be configured to be the same. I am using fluent on deep BL and need the displayName to be the same as propertyName so I can override it higher up in the user interface applications.
Both WithName and OverridePropertyName work fine for flat types like Address.
i.e. If I validate Address as a stand-alone I get the expected displayName (overridden with WtihName("Address.Postcode") in the error message: "Address.Postcode should not be null."
However if I validate Customer I will get the same error message: "Address.Postcode should not be null."
even though now the PropertyName in the ValidationFailure is "Customer.Address.Postcode".
Is there anyway I can force the display name to get the prefix of the parent class?
I tried a custom MessageFormatter but there is no access to the context data (e.g. RootContextData).
I also tried adding the parent name to the RootContextData but I couldn't get access to the ValidatorContext from rule.Configure(..) and therefore can't get LazyStringSource to use the context data.

Thanks for the quick response. Here is an example of a use case:
public class Employee {
  public string ID { get; set; }
  public Address Address { get; set; }
}

try
{
    employeeValidator.ValidateAndThrow(employee);
    customerValidator.ValidateAndThrow(customer);
}
catch (ValidationException ex)
{
     _logger.Warn(ex.Message) //Validation Failed: -- Address.Postcode should not be null.
}

Unfortunately from the logged exception message alone we can't tell whether the problem is the employee's address or the customer's address.
I wanted to avoid rewriting another ValidateAndThrow extension or creating an abstraction model to AbstractValidator.
If as you say this is not possible today we can close this issue.

The ValidationException exposes the underlying Errors collection as a property, so you can use this to build a message that includes the full property path, rather than just relying on the exception message directly.
catch(ValidationException ex) {
  var messageParts = errors.Select(x => Environment.NewLine + " -- " + x.PropertyName + ": " + x.ErrorMessage);
  var message = "Validation failed: " + string.Join("", messageParts);
  _logger.Warn(message);
}

Unfortunately this is not a good option for us. Several client apps are catching general exception and logging ex.Message without knowledge of what comes inside. Consumers wouldn't remember or want to remember to do handle it like that. Also ex.Message should be meaningful on its own.
We can use extension method ValidateAndThrow override which would be the easiest option but the validation implementation could mistakenly use the original method instead of the override.
Thanks for all the suggestions and sorry for being so pedantic about this.

I can look at adding the full property path into the exception message for the next release.

Awesome, thank you ;-)

I've added the property name into the exception message in f34a51e. This will be in the 8.0 release. Sorry it took so long to implement.

Thanks @jeremymeng. Much appreciated.

@mesteves-mw you should thank @JeremySkinner


Add a coordinator agent implementation

The coordinator will have an LLM and will be responsible for determining which agent to send a message to next and processing the response it gets back until the final solution is determined.

this is related (@fjuma or even duplicate?) #121

Closing this one since it duplicates https://github.com/wise-agents/wise-agents/issues/121.


consul: rewrite nixos module

Motivation for this change
This is a major simplification of the consul service exposed in nixos.
The primary motivation was to match the systemd unit settings provided by Hashicorp here.
Additionally, this service was previously discovering host IP addresses in an unnecessarily complex way, when Consul supports using go-sockaddr templates in configuration.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This PR has some backwards incompatible changes to the module's configuration. I am happy to adjust that if necessary.

The primary motivation was to match the systemd unit settings provided by Hashicorp here.

Great. Maybe you can submit a PR to actually include that systemd unit in the upstream code repository. If upstream maintains and ships a systemd unit we can utilize this unit via systemd.packages and automatically stay (mostly) in sync with the upstream unit.

we can utilize this unit via systemd.packages and automatically stay (mostly) in sync with the upstream unit.

Is it explains somewhere how that works, e.g. will it still be overridable in NixOS?

I'm not sure. I don't see it in the manual... It is fairly straightforward, though. If pkgs.consul has $out/lib/systemd/system/*.service then these will be included in the resulting system if you specify systemd.packages = [ pkgs.consul ]; You can then specify customization/overrides like so:
systemd.services.consul = {
  restartTriggers = settingsFiles;
  serviceConfig = {
    ExecStart = [ "" "${cfg.package}/bin/consul agent"
      + concatMapStrings (file: " -config-file=${file}") settingsFiles ];
    StateDirectory = "consul";
    ExecStop = mkIf cfg.leaveOnStop "${cfg.package}/bin/consul leave";
  };
};

The idea is to get as much upstream as possible:

free review from upstream
minimize customization in NixOS module in favor of PRs upstream
easy to keep in sync with upstream unit
other distros benefit
etc...

As a simple example we want StateDirectory = "consul"; so we should propose the addition of this in the upstream unit, instead of the NixOS module.

The primary motivation was to match the systemd unit settings provided by Hashicorp here.

Great. Maybe you can submit a PR to actually include that systemd unit in the upstream code repository. If upstream maintains and ships a systemd unit we can utilize this unit via systemd.packages and automatically stay (mostly) in sync with the upstream unit.

I agree with you here. Is an upstream unit a blocker to get this PR merged? This service hasn't seen any maintenance in NixOS for a while, so I do think there's benefit to getting this in before an upstream unit is merged.

I agree with you here. Is an upstream unit a blocker to get this PR merged? This service hasn't seen any maintenance in NixOS for a while, so I do think there's benefit to getting this in before an upstream unit is merged.

Most certainly not, but if you circle back around to that later you get full bonus points :sparkles:
You also might want to consider listing yourself as a maintainer in the NixOS module, if you have interest.

Thanks for the PR! I will make a bit longer comment on the after work, if I can fit it in today.

The NixOS tests fail, which is misleading:
The Github action https://github.com/NixOS/nixpkgs/pull/107798/checks?check_run_id=1617881367 says

Success
Attempted: consul
The following builds were skipped because they don't evaluate on x86_64-linux: consul.passthru.tests

So it says success when in fact it wasn't successful.
What can we do against that in general?
From https://logs.nix.ci/?key=nixos/nixpkgs.107798&attempt_id=2ae55234-6480-4039-a2ae-1214c7ec5326 the actual failure output is:
Cannot nix-instantiate `consul.passthru.tests' because:
...
The option `services.consul.extraConfig' does not exist.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/can-we-make-ofborg-show-broken-tests-as-red/10717/1

@nh2 Thanks for your review! I think this PR is probably easier to review and get merged if I split it into a number of smaller ones:

Use the systemd unit provided by upstream (well, the consul website) and move to dynamic user creation.
Replace the ip usage with go-sockaddr templates.
Deprecate extraConfig(Files)? in favor of settings(Files)?
Remove the interface config altogether.
Optionally remove the directory usage (I personally don't mind keeping that)

In light of that I'll close this one out and start on the split.

I am also wondering if it makes sense to keep the old module for 1 release, in addition to the new module proposed here (e.g. keep the old one as services.consul_deprecated or so), so that people who use this in production servers have an easier migration path.

Since NixOS is so flexible I don't think there is any value in that. You can just import the module from 20.09 and continue with that.

Since NixOS is so flexible I don't think there is any value in that. You can just import the module from 20.09 and continue with that.

@aanderse  Hmm, I guess that is true. You mean like in here, right?

I think this PR is probably easier to review and get merged if I split it into a number of smaller ones

@cpcloud Not sure if it's easier/faster, as it'll require more roundtrips, and it won't allow people to see the entire plan at once as a single commit or multiple commits in a single PR would, but I'll try to review any approach you pick.

Use the systemd unit provided by upstream (well, the consul website) and move to dynamic user creation.
Replace the ip usage with go-sockaddr templates.
Deprecate extraConfig(Files)? in favor of settings(Files)?
Remove the interface config altogether.
Optionally remove the directory usage (I personally don't mind keeping that)

Do you want to do the release notes at the end or also add them step by step (just so I know whether I should check for them in the individual PRs)?

@nh2 exactly :+1:


feat(public): adjusted api typehints and tests for new way of seriali…

…zing qprograms into stringified yamls

Force merge to solve the problems due different versions of qibo between qiboconnection and API


no copy to tmux from system

cant copy from system to tmux with this plugin, only from tmux to system.

Correct.  Copying from TMUX to the system clipboard(s) is the whole point of this plugin.


feat: authenticate with authserver

Review Checklist

Summary*

[ ] fix: Bug fix for Add the items tackled here as checklists
[x] feat: Completed task
[ ] chore: Incomplete task

[ ] test: Sub-task 1

Structure*

[ ] The Pull Request has a proper title that conforms to our MR title standards
[ ] The Pull Request has one commit, and if there are more than one, they should be squashed
[ ] The commit should have a proper title and a short description
[ ] The commit must be signed off
[ ] Unused imports are not present
[ ] Dead code is not present
[ ] Ensure dry running library to confirm changes

Tests

[ ] Proper and high quality unit, integration and acceptance(if applicable) tests have been written
[ ] The coverage threshold should not be lowered

Sign off*

[ ] All comments have been resolved by the reviewers
[ ] Approved by Czar {replace_with_czar_name}
[ ] Signed off by second reviewer {replace_with_name}
[ ] Ensure all checks are done before merging :warning:
[ ] All PRs needs to be signed before merging :warning:

N/B:

Add a checklist if more than one item is done.
Add screenshots and/or images where necessary
Indicate any breakages caused in the UI :exclamation:
Where necessary, indicate which issue the Pull Request solves (Closes #)
Any new files are updated in the folder structure in the README

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

29 of 32 (90.63%)  changed or added relevant lines in 3 files are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-2.1%) to 77.465%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

enums.go
0
1
0.0%

sms.go
14
16
87.5%

Files with Coverage Reduction
New Missed Lines
%

sms.go
6
78.62%

Totals

Change from base Build<PHONE_NUMBER>:
-2.1%

Covered Lines:
220

Relevant Lines:
284

💛  - Coveralls


9.7

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@trelau do you have any idea why it is failing?
win: Cannot open include file: 'smIdType.hxx': No such file or directory
linux: fatal error: smIdType.hxx: No such file or directory
osx: fatal error: 'boost/shared_ptr.hpp' file not found
osx-arm: boost/shared_ptr.hpp' file not found


SpatialUnderstanding HoloToolkit dll src - first time checkin

This module builds on top of the spatial mapping component, analyzing
the environment and supporting queries like - what is floor, ceiling,
and much more. This module exposes the analysis techniques used in
Conker and Fragments.

Hi @jevertt, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Jeff Evertt). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

So does this mean HoloToolkit is currently behind HoloToolkit-Unity? Any reason not to accept this?


show experiment toggle in preview mode

@kul3r4 PTAL

Fixed amp-live-list samples along the way. PTAL

LGTM


onClick is ignored if collapsible prop is false

[X] Implementation
[ ] Unit test
[ ] Docs

In /src/Tree/index.js, line 187, the handleNodeToggle method only calls the handleOnClickCb method if this.props.collapsible is true.
I don't think it makes sense to make the onClick prop dependent on using the collapsible prop.

Fix may look something like:
handleNodeToggle(nodeId) {
    const matches = this.findNodesById(nodeId, data, []);
    const targetNode = matches[0];

    if (this.props.collapsible) {
      const data = clone(this.state.data);
      targetNode._collapsed
        ? this.expandNode(targetNode)
        : this.collapseNode(targetNode);
      this.setState({ data }, () => this.handleOnClickCb(targetNode));
    } else {
      this.handleOnClickCb(targetNode);
    }
  }

What do you think?

Hi Justin, yes you're absolutely right it doesn't really make sense to exclude non-collapsible trees from handling onClick events, I was clearly too tired when I added that prop!
PR looking good, going to check over it and then merge if we're all good 👍