Add support for publishing on IPv6 networks

:recycle: Current situation
Ciao, while it can publish AAAA records over IPv4, cannot publish any records at all over IPv6. This means that on IPv6-only networks, or people who are using routers with broken IPv4 multicast support (Arris and CenturyLink - I am talking about you!), Ciao does not work. 'No Response'!
:bulb: Proposed solution
I recently made a PR for HAP-NodeJS which adds Avahi/D-Bus as a new advertiser. This supports IPv6 and generally I would recommend it. But some platforms don't/can't have Avahi, e.g. macOS and Windows. So there's still a hole.
So here is a PR to bridge that gap, and add IPv6 publishing to Ciao (which otherwise is pretty complete).
:gear: Release Notes
MDNSServer.options now adds a new advertiseIpv6 option. It defaults to false, but if you set it to true it'll publish over IPv6.
Testing
Not done much, but I have tested these things on macOS and Linux, and they at least superficially work: (adding, deleting, updating records)

advertising IPv4 only on IPv4-only networks
advertising IPv6 only on IPv6-only networks
advertising IPv4 only on dual stack networks
advertising IPv6 only on dual stack networks
advertising IPv4 and IPv6 on dual stack networks

I made the decision to implement IPv6 support by effectively creating "wrapper interfaces" around IPv6-capable network interfaces, which then get special treatment to handle IPv6 vs. IPv4 differences. Out of all possible approaches this keeps the largest proportion of the existing Ciao code intact, which I felt was important because it is very easy with mDNS to subtly break things. (I don't promise I haven't already done that, unfortunately.)
For completeness, it is probably worth adding equivalents to Avahi's publish-aaaa-on-ipv4 and publish-a-on-ipv6 options.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 72 (0.0%)  changed or added relevant lines in 2 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.7%) to 35.089%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Responder.ts
0
12
0.0%

src/MDNSServer.ts
0
60
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/Responder.ts
1
0%

src/MDNSServer.ts
5
6.92%

Totals

Change from base Build<PHONE_NUMBER>:
-0.7%

Covered Lines:
1200

Relevant Lines:
3085

💛  - Coveralls

HI,
are there any plans to merge this PR to support IPv6 for ciao in the near future?
Thanks!

going to merge into the beta branch for now.


[Discussion] Best practices for data storage location/home directory

Keeping in mind that https://github.com/Microsoft/BashOnWindows/issues/1475 (*1) and (*2) what is the consensus on the best place for storing your projects?
*1) Windows and Linux symlinks are incompatible
*2) You are not supposed to edit files inside WSL (both system and user directory) from Windows applications.
I was leaning towards having my Linux $HOME directory same as my Windows %PROFILEDIR% in /etc/passwd, however the dotfiles in both cases would have incompatible link format. So that's out.
However, I'm thinking it would still be better if everything was stored on the "windows side" so that I can edit files from both sides, modulo the link related problems.? My primary environment for development would be WSL so I would do the filesystem manipulations on the WSL side only.
My question is what do you guys think about it? Does anybody have any cons to this approach.

Calling all WSL devs and non-dev experts that I know of (@fpqc, @aseering, @therealkernc). What best practices do you guys follow?

I have my projects at %userprofile%\proj with a symlink from ~/proj to this directory. I also have a symlink form ~\z to my Windows user profile. Additionally, some directories or files are directly linked from WSL to their Windows equivalent (e.g. ~/.aws), and for SSH keys/config I have scripts I call to copy the data back and forth when something was changed because symlinking doesn't work due to the requirement of 600 permissions (while DrvFs will always show 777).
I develop with VSCode under Windows, but I run the projects only under WSL. I use a special script in my projects which makes sure that npm tasks are always run under WSL even if they are called through a git commit hook which is triggered by Windows Git from VSCode, for example.
This setup has a few inconveniences (one of them is that npm link is incompatible, so I don't see linked packages under Windows directly, and another is that FS performance is not so fast because of DrvFs) but mostly works OK.
If I needed better support of symlinks or better FS performance, I would switch to using a WebDAV or SSH server in WSL and map my home folder (or even root) to a drive letter in Windows.

My setup is actually very similar to @CherryDT 's.  I exclusively use ssh et al from within WSL so I don't need the key-management scripts.

if I needed better support of symlinks or better FS performance, I would switch to using a WebDAV or SSH server in WSL and map my home folder (or even root) to a drive letter in Windows
@CherryDT how would you map your Linux FS to Windows with a SSH server running?

@aseering On my end it's basically just Git inside VSCode which is using the Windows-side SSH.
@ajaykagrawal With a third party tool like SshFs.

Thanks. I'll keep these tips in mind.


Training fix

This should solve the issue with the training-method implementation (checked via testing).

I'm closing without a review since the merge is not into main. The review will be done when basic_jax is merged into main.


Issues with null initial states for form objects when upgrading from 6.6.0 to 9.0.1

This is a...

[ x ] bug report

What toolchain are you using for transpilation/bundling?

[x ] @angular/cli

Environment
Angular CLI: 6.0.8
Node: 8.9.4
OS: win32 x64
Angular: 6.0.4
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.8
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        0.6.8
@angular/cli                      6.0.8
@ngtools/webpack                  6.0.8
@schematics/angular               0.6.8
@schematics/update                0.6.8
rxjs                              6.2.0
typescript                        2.7.2
webpack                           4.8.3

Expected Behaviour:
Connect to an empty form without issue.
Actual Behaviour:
After upgrading 6.6.0 => 9.0.1, if the initial state of the form was null, it would crash on trying to connect before any state changes were made; it's now expecting initial values when before it didn't care.  If this is intended, then it would be good to have it documented as before I had a form as null until an @angular-redux/form action was fired.
Stack Trace/Error Message:
State.traverse line 26 (e.g. can't call  on a null object).
Another
core.js:1542 ERROR Error: Uncaught (in promise): Error: Must supply a value for form control with name: '<formControlName>'. Error: Must supply a value for form control with name: '<formControlName>'.
Additional Notes
We used @angular-redux/form in a production-level application that is using @angular-redux/form 6.6.0 and Angular 5.2.6 and are trying to upgrade it to Angular 6 for access to i18n.

Maybe I don't quite understand the scenario, but I have been unable to replicate this. I am assuming that you are using reactive forms. If I pass null as the initial value to a control, I am not seeing any errors.
Can someone please provide a sample repo/project that shows this bug in action?


feat: async support tested

Got any more details? :-)

@alexellis issue to test that the provider works with async function invocation

https://github.com/ewilde/terraform-aws-openfaas-fargate/pull/7 fixes this issue

No changes were needed to OpenFaaS

Nice progress with this! :ok:


Move offset coordinates

I have run into a few cases where an elements center may not be the actual center of the element I wish to click. I suggest extending the move function to have x, y offsets from the element center.

Can be simply accomplished with pywinauto.mouse

Hi @Pegmode,
Glad you were able to solve your problem.
I just want to point out that by default Pywinauto Recorder does not record relative coordinates and therefore it plays back by clicking in the center. But it is possible to activate the "Process events -> % relative coordinates" option in the taskbar menu.

Thanks, I'll keep this in mind for the future.
There was an odd element in something I was interacting with. I needed manual offsets for portability so I went with doing things manually.


Nullable reference types enabled, but not used

I noticed that nullable reference types are enabled in the project, but are not used where it would be necessary.
Shouldn't the methods of the IRepositoryBase interface for example somtimes declare their return types as nullable?
For example in this case: Link
It would be more appropriate for this method Task<T> GetByIdAsync(int id); to be declared with a nullable return type like this:  Task<T?> GetByIdAsync(int id);. The ef implementation of the repository uses the FindAsync method for this under the hood and this method returns null if the entry has not been found. With the current implementation someone would get wrong warnings in Visual Studio like this:

Hey @mrukas
Yes, you're right. We're not fully supporting it, just fixed the initial warnings. All public constructs should be analyzed and updated accordingly.
Want to work on this issue? If you're not available, I'll try to fix it for the weekend maybe.

@fiseni
I can fix these things and submit a pull request. But I am not sure if this will happen before the weekend.

@fiseni @ardalis
Is there a reason why you avoid project references? Usually visual studii recognizes tjose and references them as nuget dependencies if you publish both separately.
Link

Thabks, that's great. As I said, I'd love not to, I just wasn't sure if that would work. This section in the link clarifies that (I've missed this)

If a referenced project includes a .nuspec file of its own, then NuGet adds that referenced project as a dependency instead. You need to package and publish that project separately.

We should try it. We just to fix the project build order for the solution.

It works really great. I've done that already. I just wanted to ask because i saw that my changes didn't get recognized.

Great. If @ardalis is Ok with it, you can add additional commit in the PR where you remove the nuget package and add project ref instead.

I have nothing against project references, I just didn't think they worked well for dependencies between Nuget packages. For instance, how does Nuget decide which version to use, since project references aren't versioned?

That's good point. I just did some quick tests. If you add the project reference (instead of nuget dependency), this is the nuspec generated for the EF package (nuspec is located within the .nupkg file in the bin folders).
<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
  <metadata>
    <id>Ardalis.Specification.EntityFrameworkCore</id>
    <version>4.0.0</version>
    <title>Ardalis.Specification.EntityFrameworkCore</title>
    <authors>Steve Smith (@ardalis),Scott DePouw</authors>
    <requireLicenseAcceptance>false</requireLicenseAcceptance>
    <icon>icon.png</icon>
    <projectUrl>https://github.com/ardalis/specification</projectUrl>
    <description>EF Core plugin package to Ardalis.Specification containing EF Core evaluator and abstract repository.</description>
    <releaseNotes>New API for building the specifications.</releaseNotes>
    <tags>spec specification repository ddd ef ef core entity framework entity framework core</tags>
    <repository type="git" url="https://github.com/ardalis/specification" commit="d237a864fcba656fa8ed09f6759bd49ac0c56964" />
    <dependencies>
      <group targetFramework=".NETStandard2.0">
        <dependency id="Ardalis.Specification" version="4.0.0" exclude="Build,Analyzers" />
        <dependency id="Microsoft.EntityFrameworkCore" version="3.1.6" exclude="Build,Analyzers" />
      </group>
    </dependencies>
  </metadata>
</package>

As we can see, indeed the project ref is converted into nuget package dependency. But, the referenced version is defined as the version written under the base project file. More precisely, whichever version is defined within the generated nuspec file of the base project.
  // Whatever we write here in the base project file, will be translated into version of the nuget dependency in EF package
  <PropertyGroup>
    <Version>4.0.0</Version>
  </PropertyGroup>

So, if you just write a version 5.0.0, that will be picked up, even though that version is still not available on nuget.org. Probably it's not a big issue, but whenever we do changes in both projects, base package should be published first to nuget.org, and only then the EF package.
We can't reference older versions, though. I'm not sure if we need that at all, can't think of a specific case now.

I think this sounds like a bigger problems than it will be. I tried it with a sample solution that looks like this:

The parent library has the version 2.1.0 and is referenced by the child library. If you now package the child library as a nuget package, the dependency gets translated to this:

So in fact nuget does not pin this to a specific version but uses the following resolution algorithms: Link
As written in the document the version downloaded should be the lowest applicable version it can find. That would mean as long as your ef package references for example version 4.0.0 of you base package it should only install version 4.0.0 as long as you're not manually installing a newer version of it.
How do you currently increase the versions of your packages? Is this done by the CI/CD pipeline of do you increase them manually?
 This would lead to a dependency that could not get fulfilled i think. But this shouldn't be the case right? 😁

That's actually great news, thanks! What we've been doing is having the primary/base package deploy first (with manual version update to project file), and then CI/CD publishes it. This takes 5-10 minutes typically. Then we update the dependent projects to use the new version (manually) and make whatever updates are needed to them, and then publish them using the same process.
It sounds like just using project references everywhere should let us make version updates that impact multiple related packages in a single commit. Nice!

The PR #14 is merged. Additionally, the project is updated to use project references instead of nuget package.
Closing the issue.


Instantiate Modelling

Label encoding for the emotion column classes
Train Test split of the dataset with a test size of 0.3 and a random state of 42
Vectorization using tfidf vectorization technique
Instantiate Models; Logistic Regression, SVC, Randomforest model and naive bayes model


Unable to run fabric8 launcher in minishift

I am running
minishift v1.15.1+f19ac09
CDK v3.4.0-2
openshift v3.9.14
kubernetes v1.9.1+a0ce1bc657
and am attempting to work through
https://access.redhat.com/documentation/en-us/red_hat_openshift_application_runtimes/1/html-single/install_and_configure_the_fabric8_launcher_tool/#introduction-to-the-launcher-application
The backend seems to OK (it manages to clone everything and doesn't log any errors) but the front has the following problems (screenshot from the browser console in Chrome). I had to make one change for the frontend to deploy successfully in the cluster configmap (I added a blank entry for launcher.keycloak.clientId otherwise the it wouldn't start and I got a configuration error).
It seems that
launcher.frontend.sentry.dsn | ${LAUNCHER_FRONTEND_SENTRY_DSN}
Is a problem?

Thank you for letting us know about this issue @petenorth.
I have found the problem, it should be fixed soon. I will keep you updated.
Sorry again..

@petenorth it should be ok now :)
Don't hesitate to reopen the issue if the fix didn't solve the problem for you.

@ia3andy Yes, created a clean project and did a clean install and everything works fine. Managed to create both a 'build and run locally' and a 'Use Openshift' style project with the latter successfully building etc.
Thanks for the quick fix.


Elixir dependency parsing fails with latest mix.lock format

Dependabot opened an issue called "Dependabot can't evaluate your Elixir dependency files" with the following error:
** (FunctionClauseError) no function clause matching in Parser.parse_lock/1

    The following arguments were given to Parser.parse_lock/1:

        # 1
        {:hex, :libcluster, "3.1.1", "cbab97b96141f47f2fe5563183c444bbce9282b3991ef054d69b8805546f0122", [:mix], [{:jason, "~> 1.1.2", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "8eaf6b0ca713f70ff588596743becba3e0ddda9ec14873adf7634ea705afc6f3"}

    parse_deps.exs:69: Parser.parse_lock/1
    parse_deps.exs:19: Parser.build_dependency/2
    (elixir) lib/enum.ex:1336: Enum."-map/2-lists^map/1-0-"/2
    parse_deps.exs:101: (file)

{"error":""}

This appears to be due to an update to the hex package to v0.20.2. Specifically, this PR adds outer_checksum to the end of the mix.lock dependency tuple. This issue is still present in the latest version, v0.20.4.
The error shown above is occurring because parse_lock pattern matches against the mix.lock tuple and it doesn't have a match for the new tuple format with the new checksum at the end.

There isn't a straightforward way to roll back the version of hex for a given project. You run mix local.hex and it goes and finds the latest version for your version of elixir. I looked in the code for that mix task and found that it identifies the latest version by looking at the CSV https://repo.hex.pm/installs/hex-1.x.csv. hex v0.20.4 is listed for all Elixir versions from 1.0.0 to 1.10.0, so this isn't limited to the latest version of Elixir. However, the problem does not occur until you run mix local.hex and commit the updated mix.lock file.

We're seeing this as well.
** (FunctionClauseError) no function clause matching in Parser.parse_lock/1

    The following arguments were given to Parser.parse_lock/1:

        # 1
        {:hex, :ex_doc, "0.21.3", "857ec876b35a587c5d9148a2512e952e24c24345552259464b98bfbb883c7b42", [:mix], [{:earmark, "~> 1.4", [hex: :earmark, repo: "hexpm", optional: false]}, {:makeup_elixir, "~> 0.14", [hex: :makeup_elixir, repo: "hexpm", optional: false]}], "hexpm", "0db1ee8d1547ab4877c5b5dffc6604ef9454e189928d5ba8967d4a58a801f161"}

    parse_deps.exs:69: Parser.parse_lock/1
    parse_deps.exs:19: Parser.build_dependency/2
    (elixir) lib/enum.ex:1336: Enum."-map/2-lists^map/1-0-"/2
    parse_deps.exs:101: (file)

{"error":""}

Also being discussed on Elixir Forum.
https://elixirforum.com/t/dependabot-recently-broke/28919
@ericmj  also mentioned Dependabot should ignore extra tuple fields it does not recognize so they do not fail again if we add more fields.


IndexedUnfoldable

Should this not exist for maps, etc? Thoughts?

(for consistency, I suppose it should be UnfoldableWithIndex)

This seems like it isn't going to work (see #15), so I'll close this.


Corrections/refinements to the Economist example

I tweaked the final code in the excellent Economist example to more precisely match the actual figure. In the attached file I've done the following:

Corrected the order of the smooth line vs the dots (should be in background)
Italicized the axes titles (not the axes labels)
Changed the order of the legends on the top (R^2 should be on the right)
Added the 'Sources' caption to the bottom, left-justified

I didn't tweak the font face ;)
## Final Version:
library(ggplot2)
library(dplyr)
## install.packages("ggrepel")
library(ggrepel)

dat <- read.csv("dataSets/EconomistData.csv")

mR2 <- summary(lm(HDI ~ CPI + log(CPI), data = dat))$r.squared
mR2 <- paste0(format(mR2, digits = 2), "%")

png(file = "images/econScatter11.png", width = 800, height = 800)

p <- ggplot(dat,
            mapping = aes(x = CPI, y = HDI)) +
  geom_smooth(mapping = aes(linetype = "r2"),
              method = "lm",
              formula = y ~ x + log(x), se = FALSE,
              color = "red") +
  geom_point(mapping = aes(color = Region),
             shape = 1,
             size = 4,
             stroke = 1.5) +
  geom_text_repel(mapping = aes(label = Country, alpha = labels),
                  data = transform(dat,
                                   labels = Country %in% c("Russia",
                                                           "Venezuela",
                                                           "Iraq",
                                                           "Mayanmar",
                                                           "Sudan",
                                                           "Afghanistan",
                                                           "Congo",
                                                           "Greece",
                                                           "Argentinia",
                                                           "Italy",
                                                           "Brazil",
                                                           "India",
                                                           "China",
                                                           "South Africa",
                                                           "Spain",
                                                           "Cape Verde",
                                                           "Bhutan",
                                                           "Rwanda",
                                                           "France",
                                                           "Botswana",
                                                           "France",
                                                           "US",
                                                           "Germany",
                                                           "Britain",
                                                           "Barbados",
                                                           "Japan",
                                                           "Norway",
                                                           "New Zealand",
                                                           "Sigapore"))) +
  scale_x_continuous(name = "Corruption Perception Index, 2011 (10=least corrupt)",
                     limits = c(1.0, 10.0),
                     breaks = 1:10) +
  scale_y_continuous(name = "Human Development Index, 2011 (1=best)",
                     limits = c(0.2, 1.0),
                     breaks = seq(0.2, 1.0, by = 0.1)) +
  scale_color_manual(name = "",
                     values = c("#24576D",
                                "#099DD7",
                                "#28AADC",
                                "#248E84",
                                "#F2583F",
                                "#96503F"),
                     guide = guide_legend(nrow = 1, order=1)) +
  scale_alpha_discrete(range = c(0, 1),
                       guide = FALSE) +
  scale_linetype(name = "",
                 breaks = "r2",
                 labels = list(bquote(R^2==.(mR2))),
                 guide = guide_legend(override.aes = list(linetype = 1, size = 2, color = "red"), order=2)) +
  ggtitle("Corruption and human development") +
  labs(caption="Sources: Transparency International; UN Human Development Report") +
  theme_bw() +
  theme(panel.border = element_blank(),
        panel.grid = element_blank(),
        panel.grid.major.y = element_line(color = "gray"),
        axis.line.x = element_line(color = "gray"),
        axis.title.x = element_text(color = "gray", face="italic"),
        axis.title.y = element_text(color = "gray", face="italic"),
        legend.position = "top",
        legend.direction = "horizontal",
        legend.box = "horizontal",
        legend.text = element_text(size = 12),
        plot.caption = element_text(color = "gray", hjust=0),
        plot.title = element_text(size = 16, face = "bold"))
p
dev.off()

This is great, thanks! I added these improvements and a few other tweaks in https://github.com/IQSS/workshops/commit/1267e69104c3b34554c632ecd94ca644f3c7a53d. Thanks for your contribution.


⚠ Bofrost.at has degraded performance

In a4a6be7, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2206 ms

Resolved: Bofrost.at performance has improved in 5b87cfc after 10 minutes.


Adds devcontainer.json file

This PR adds the setup for creating a developer environment anytime to run the code.
It uses the Golang image to install the latest version of Go and run the code as needed.
The only thing left would be for the user to add their GitHub Secret, which will have to be updated in the documentation.

You can give it a try on your own by creating a Codespace on the top right


Error ofcompilation in  angular 9

getting an error of compilation:
ERROR in Failed to compile entry-point mat-select-autocomplete (module as esm5) due to compilation errors:
node_modules/mat-select-autocomplete/fesm5/mat-select-autocomplete.js:282:30 - error NG1010: Value at position 3 in the NgModule.imports of SelectAutocompleteModule is not a reference: [object Object]

I am getting the same exception. Is any one working on this ?
It looks like the 2 files are referring to older version of Material components:
Existing:
import { MatButtonModule, MatCheckboxModule } from '@angular/material';
Expected:
import { MatButtonModule} from '@angular/material/button'; import { MatCheckboxModule} from '@angular/material/checkbox';

No, it's just that angular 10 has ivy enabled by default, which supports tree-shaking, so you need to include each component on it's own.

No, it's just that angular 10 has ivy enabled by default, which supports tree-shaking, so you need to include each component on it's own.


LOG4J2-3366 Fixes order of property sources

This PR fixes the order of the property sources to:

Spring Boot properties with lowest numerical priority (overrides all others). In a Spring Boot application with log4j-spring present it will use in order: the servlet context init parameters, JNDI environment entries (from java:comp/env exclusively), Java system properties and system environment variables (among others, cf. the complete list).
Java system properties,
OS environment variables,
log4j2.component.properties to allow devs to provide some defaults.

Due to some issues with the previous implementation, the logic of the Environment class has been rewritten:

the normalized map maps any key to the value of its normalization in the highest priority property source. E.g.: the key log4j.configurationFile will contain the value of the log4j2.configurationFile property (remark the 2) in Java's system properties or the value of the LOG4J_CONFIGURATION_FILE environment variable. Previously it contained two separate mappings: log4j2.configurationFile -> value in Java's system properties, LOG4J_CONFIGURATION_FILE -> value of the environment variable. This caused a miss for 95% of the PropertiesUtil#getStringProperty calls, which usually use the legacy property name.
the three caches (normalized, literal and tokenized) are filled in two steps: first we recover all the keys from enumerable sources and then we query all sources to retrieve the appropriate values. Previously non-enumerable sources didn't get a chance to provide a value in these caches (the Spring Boot property source is non-enumerable).

This PR should also solve the problem of PR #601.

This change along with https://github.com/apache/logging-log4j2/pull/975 broke one of our systems on upgrading to 2.19.
In our applications we had both LOG4J_CONFIGURATION_FILE environment variable as well as log4j.configurationFile system property set.
In version 2.17.2 log4j.configurationFile gets priority vs in 2.19 LOG4J_CONFIGURATION_FILE gets priority. This also breaks the contract mentioned in the documentation

Hi @adwsingh,
Old pre-2.10 properties such as log4j.configurationFile are overridden by any property in normalized form (e.g. the log4j2.configurationFile Java system property or the LOG4J_CONFIGURATION_FILE environment variable). Changing from log4j.configurationFile to log4j2.configurationFile should work for you.
If you believe this to be a bug, please submit an issue on JIRA.

I have created a bug here, https://issues.apache.org/jira/browse/LOG4J2-3621


PhoneHint is not compatible with Android S and above.

Please check below issue:
D/ContentValues(14201): Account Picker on Activity Result phone hint
D/ContentValues(14201): 711012
E/MethodChannel#account_picker(14201): Failed to handle method call
E/MethodChannel#account_picker(14201): java.lang.IllegalArgumentException: com.example.taxi_app: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
E/MethodChannel#account_picker(14201): Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.

Did you find a solution for this?

I'm also experiencing the issue on Android 14.

Should be fixed with 2.2.0


Add Computer Vision Classification Template with MobileNetV3 Baseline

Overview
This pull request introduces a new template for computer vision classification tasks, along with a strong baseline implementation using MobileNetV3. The additions have been thoroughly tested end-to-end to ensure reliability and ease of use.
Key Features

CV Classification Template: A reusable template for computer vision classification tasks, promoting consistency and efficiency in future projects.

MobileNetV3 Baseline: Implementation of a strong baseline model using MobileNetV3, known for its efficiency and performance in various computer vision applications.

End-to-End Testing: Comprehensive testing to validate the entire pipeline from data input to model output.

Technical Details

model is based on pytorch implementation (https://github.com/pytorch/vision/blob/main/torchvision/models/mobilenetv3.py#L117) and could load pre-trained weights if needed.

Sample paper outputs
adaptive_channel_thresholding_mobilenetv3.pdf
mb4-pre.pdf
I welcome any feedback or suggestions for improvement. Please let me know if you need any additional information or clarification.

Thank you for creating this.
Are you giving your LLM access to modify your experiment.py file?
Can you please walk me through the steps you used to create your own experiment? The repo maintainers are not being helpful.

Thanks so much for the contribution - could you remove the changes to the README and follow the current style, the template.tex file should have more appropriate base cites. There is also an incorrect modification to the nanogpt ideas.

Thanks for the feedback @conglu1997 !
I've modified based on your suggestions above. Let me know if there's anything else I should change :)

@conglu1997 I am starting to think that there needs to be a prompt meta-template that allows people to, through dialogue, vaguely hint at which piece of research they would like to pursue, and provide example papers (e.g. DOI/ArXiv links) so that it understands, and fetch the relevant GitHub repo by itself.


manager.Run refactoring

This is the first step of a brainless refactoring of the manager.Run function.
My work started when I read this comment:
// TODO(aluzzardi): /!\ This function is *way* too complex. /!\
// It needs to be split into smaller manageable functions.
func (m *Manager) Run(parent context.Context) error {

The Run function still contains a lot of domain logic and it is still too complex,
but a little bit less now.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "refactoring_manager" git@github.com:liuggio/swarmkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Current coverage is 55.25% (diff: 100%)

Merging #1369 into master will decrease coverage by 0.08%

@@             master      #1369   diff @@
==========================================
  Files            80         80
  Lines         12635      12635
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           6993       6982    -11
- Misses         4681       4690     +9
- Partials        961        963     +2

Powered by Codecov. Last update d5f249e...c479492

This is a welcome improvement, thanks!

Thanks a lot @aaronlehmann for the feedback :)
I also added 2 new funcs to that commit,  let me know what do you think

Thanks. Added a few more comments.

Pointed out a very small thing. Otherwise it looks good.

@aaronlehmann good catch and fixed, thanks a lot!
this is the first PR to this project and I've got few days off and I think I'll try to do my best to contribute (I don't know which could be the next task)

I'm gonna run this PR through docker/docker integration tests

Can't get docker integration tests to run on my laptop today, so don't wait up for me.

I ran the docker integration tests and they passed.

LGTM


Only resolve paths in REPL if path is relative

Added back the root component capture to the regexp and call toResource conditionally. I would appreciate it if someone could check this out and test, still have trouble building, this is untested

@felixfbecker thanks a lot for your contributions!
The changes look good. Now let's try to fix your build issues.
From pr #15174 and looking at your original errors they all seem to be related to the generated monaco editor api file. I think we can just ignore those and still be able to run out of source with \scripts\code.bat. More details https://github.com/Microsoft/vscode/wiki/How-to-Contribute
As for the monaco.d.ts errors, maybe try good old git clean -fxd, and again scripts\npm install and gulp watch. Basically the monaco.d.ts file gets generate from monaco.d.ts.recipe and for some reason on your machine he is looking for other definition files which I do also do not have.
If running out of source does not work with these errors let me know and I will ask around for a solution for your issue.

Another bug

@felixfbecker did you succeed in runnning vscode out of source?

Yes. I tested it, absolute paths work correct now. How can I get the node debugger? Mocha always throws the relative paths, would like to test those

@felixfbecker awesome! To get the node debugger in the oss dev build install it from the gallery, to enable the gallery in the oss dev build first add the following to the product.json before building the oss dev vscode. Let me know how it looks and if it seems good I will merge it in
"extensionsGallery": {
	"serviceUrl": "https://marketplace.visualstudio.com/_apis/public/gallery",
	"cacheUrl": "https://vscode.blob.core.windows.net/gallery/index",
	"itemUrl": "https://marketplace.visualstudio.com/items"
}

@felixfbecker let me know how this is working once you test those mocha relative paths

Just tested, works!

Side effect: the parens are underlined. No that much of a deal imo though

PHPUnit works:

Normal call stacks not unfortunately:

Awesome, let's merge this baby in.
You have a beer from me once you are in Zurich

@felixfbecker we can not handle each and every case. This should improve once we start using the editor intead of the tree. Might investigate into that over Christmas

Yeah I don't know how to handle it while still supporting spaces in paths (without matching the whole line by mistake).

You have a beer from me once you are in Zurich

I will come back to that offer 😄


fix(FMP-418): use promise queue for fee prediction

⏳ This pull request is set to merge as part of a Graphite merge job
Job ID: OaGZUWhFK5gwcxOkc2wk.
See details on graphite.dev


Profanity filter words list (enhancement for issue #19)

Probably one of the most complete bad italian words list you can find in GitHub for the profanity filter:
++ Added bad words from https://github.com/LDNOOBW/List-of-Dirty-Naught-Obscene-and-Otherwise-Bad-Words/blob/master/it
++ Added bad words from https://en.wikipedia.org/wiki/Italian_profanity#List_of_profanities_in_the_Italian_language
++ Added bad words (manually)
-- Removed some words from previous lists (not necessarily profanity)

Altre parole vanno sempre bene, grazie


PENV-686: add record queue via chennels and unit tests

- What I did
- How I did it
- How to verify it
- Description for the changelog

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4eaf4f4). Click here to learn what that means.
The diff coverage is 93.33%.

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage          ?   93.33%
=========================================
  Files             ?        1
  Lines             ?       15
  Branches          ?        0
=========================================
  Hits              ?       14
  Misses            ?        1
  Partials          ?        0

Impacted Files
Coverage Δ

internal/queue/queue.go
93.33% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eaf4f4...f025407. Read the comment docs.


Added the taskName not empty check plus a snackbar for user

Added The Check for taskName for it to be not Empty
Also Added a snackbar for it to notify user to enter some taskName before Saving it
before :

-After :

Hey @Arsh-78 Great Work!


Implement ?roll command

Also includes various documentation updates and code improvements to other commands
Closes #4

Ok I think I'm happy with this now. I'll merge and make any necessary changes on master as soon as they appear


Adding YAML files for DL4NLP project

Adding YAML files for DL4NLP project

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update top-level lint deps

To answer your earlier question—we unpinned ESLint config in https://github.com/facebookincubator/create-react-app/issues/1110.

We actually need to add stricts to Node-targeted code. Like react-scripts/config/*.

Most of these configs contain module.exports which eslint argues doesn't need 'use strict';, but I've adjusted the config for the other files -- what do you think now?

Most of these configs contain module.exports which eslint argues doesn't need 'use strict';

This is weird (and I think it's wrong). use strict is only unnecessary for code using ES Modules. It is necessary in Node.

Sorry, I didn't mean to state that as fact -- I derived it's been a problem before from the conversation on https://github.com/eslint/eslint/issues/4832, but nothing I change seems to be making it catch and require the 'use strict';. I'm not sure if there was a regression or some really weird configuration bug, but I'm stumped.

Instead let's do #1729.


[NEW ALGORITHM]  Adding New Scheduling ALgorithms

Issue will be closed if:

You mention more than one algorithm. You can create a separate issue for each algorithm once the current one is completed.
You propose an algorithm that is already present or has been mentioned in a previous issue.
You create a new issue without completing your previous issue.

Note: These actions will be taken seriously. Failure to follow the guidelines may result in the immediate closure of your issue.

Name:
[NEW ALGORITHM]
Adding Whole Directory of Scheduling Algorithms:-
-First Come First Serve Scheduling Algorithm
-Round Robin Scheduling Algorithm
-Priority Scheduling Algorithm
About:
Propose a new algorithm to be added to the repository

Propose the First Come First Serve (FCFS) scheduling algorithm to be added to the repository. This non-preemptive algorithm serves processes in the order they arrive in the ready queue, ensuring fairness but potentially leading to long wait times for short processes.

2)Propose the Round Robin (RR) scheduling algorithm to be added to the repository. This preemptive algorithm assigns a fixed time slice to each process, allowing for fair time-sharing among processes in a cyclic manner. It is well-suited for time-sharing systems.
3)Propose the Priority Scheduling algorithm to be added to the repository. This scheduling method selects processes based on their priority, allowing for efficient handling of critical tasks. It can be preemptive or non-preemptive, depending on the implementation.
Labels:
new algorithm, gssoc-ext, hacktoberfest, level1

Assignees:

[  yes  ] Contributor in GSSoC-ext
[ yes ] Want to work on it

yes

Yes I am contributor in GSSoC ext I want to work on this issue

IT's already done guys work on new Issue-

Yes I am contributor in GSSoC ext I want to work on this issue

IT's already done guys work on new Issue-

In which folder I didn't find so raised a pull request sorry


Scala.js support

In some cases, using a template from Scala.Js could be useful. Have you tried compiling it to SJS?

#109?

Yes, duplicate of https://github.com/playframework/twirl/issues/82 (with another spelling of SJS).


Does this library work with complex/nested objects

Does this library work with complex/nested objects? For example
{
  "Name": "John",
  "PhoneNumber": "00101010101",
  "Address":{
    "Street": "Another street"
  }
}

Will it serialize this object?

@anton-bot Thank you for your help. I think flat will do the trick for me.


execute jupyter notebook

Hello, I execute jupyter notebook. I can't see anything on the page.

Could you describe the steps you follow to execute the demo in the jupyter notebook?
Are you able to see the demos in the colaboratory links provided?
Run "shortest path demo" in browser
Run "sort demo" in browser
Run "physics demo" in browser

test@test:~/graph_nets/graph_nets$ jupyter notebook --ip=<IP_ADDRESS>
[I 16:29:14.313 NotebookApp] Serving notebooks from local directory: /home/test/graph_nets/graph_nets
[I 16:29:14.313 NotebookApp] The Jupyter Notebook is running at:
[I 16:29:14.314 NotebookApp] http://<IP_ADDRESS>:8888/?token=3720036fe1897ce51b7658d9e0aaecbaf802337285d631b8
[I 16:29:14.314 NotebookApp] Use Control-C to stop this server and shut down all kernels (twice to skip confirmation).
[W 16:29:14.314 NotebookApp] No web browser found: could not locate runnable browser.
[C 16:29:14.314 NotebookApp]
Copy/paste this URL into your browser when you connect for the first time,
to login with a token:
    http://<IP_ADDRESS>:8888/?token=3720036fe1897ce51b7658d9e0aaecbaf802337285d631b8

[W 16:29:15.317 NotebookApp] 404 GET /api/kernels/0b3af765-af29-4ee0-9d67-4d036a95de45/channels?session_id=543d4d7175554cdb8898f264cfb4cd50 (<IP_ADDRESS>): Kernel does not exist: 0b3af765-af29-4ee0-9d67-4d036a95de45
[W 16:29:15.381 NotebookApp] 404 GET /api/kernels/0b3af765-af29-4ee0-9d67-4d036a95de45/channels?session_id=543d4d7175554cdb8898f264cfb4cd50 (<IP_ADDRESS>) 96.71ms referer=None
[W 16:29:19.394 NotebookApp] Replacing stale connection: 0b3af765-af29-4ee0-9d67-4d036a95de45:543d4d7175554cdb8898f264cfb4cd50
[W 16:29:25.463 NotebookApp] Notebook demos/sort.ipynb is not trusted
[I 16:29:26.273 NotebookApp] Kernel started: 34b4ed89-21d5-445e-a727-580a066a28c0
Traceback (most recent call last):
File "/usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
"main", mod_spec)
File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/usr/local/lib/python3.5/dist-packages/ipykernel_launcher.py", line 16, in
app.launch_new_instance()
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 657, in launch_instance
app.initialize(argv)
File "", line 2, in initialize
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 87, in catch_config_error
return method(app, *args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 456, in initialize
self.init_sockets()
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 259, in init_sockets
self.init_iopub(context)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 267, in init_iopub
self.iopub_thread = IOPubThread(self.iopub_socket, pipe=True)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/iostream.py", line 66, in init
self.io_loop = IOLoop(make_current=False)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/tornado/util.py", line 208, in new
instance.initialize(**args)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/tornado/platform/epoll.py", line 26, in initialize
super(EPollIOLoop, self).initialize(impl=select.epoll(), **kwargs)
TypeError: initialize() got an unexpected keyword argument 'make_current'
[I 16:29:29.271 NotebookApp] KernelRestarter: restarting kernel (1/5), new random ports
Traceback (most recent call last):
File "/usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
"main", mod_spec)
File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/usr/local/lib/python3.5/dist-packages/ipykernel_launcher.py", line 16, in
app.launch_new_instance()
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 657, in launch_instance
app.initialize(argv)
File "", line 2, in initialize
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 87, in catch_config_error
return method(app, *args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 456, in initialize
self.init_sockets()
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 259, in init_sockets
self.init_iopub(context)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 267, in init_iopub
self.iopub_thread = IOPubThread(self.iopub_socket, pipe=True)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/iostream.py", line 66, in init
self.io_loop = IOLoop(make_current=False)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/tornado/util.py", line 208, in new
instance.initialize(**args)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/tornado/platform/epoll.py", line 26, in initialize
super(EPollIOLoop, self).initialize(impl=select.epoll(), **kwargs)
TypeError: initialize() got an unexpected keyword argument 'make_current'
[I 16:29:32.278 NotebookApp] KernelRestarter: restarting kernel (2/5), new random ports
Traceback (most recent call last):
File "/usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
"main", mod_spec)
File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/usr/local/lib/python3.5/dist-packages/ipykernel_launcher.py", line 16, in
app.launch_new_instance()
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 657, in launch_instance
app.initialize(argv)
File "", line 2, in initialize
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 87, in catch_config_error
return method(app, *args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 456, in initialize
self.init_sockets()
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 259, in init_sockets
self.init_iopub(context)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 267, in init_iopub
self.iopub_thread = IOPubThread(self.iopub_socket, pipe=True)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/iostream.py", line 66, in init
self.io_loop = IOLoop(make_current=False)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/tornado/util.py", line 208, in new
instance.initialize(**args)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/tornado/platform/epoll.py", line 26, in initialize
super(EPollIOLoop, self).initialize(impl=select.epoll(), **kwargs)
TypeError: initialize() got an unexpected keyword argument 'make_current'
[I 16:29:35.288 NotebookApp] KernelRestarter: restarting kernel (3/5), new random ports
Traceback (most recent call last):
File "/usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
"main", mod_spec)
File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/usr/local/lib/python3.5/dist-packages/ipykernel_launcher.py", line 16, in
app.launch_new_instance()
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 657, in launch_instance
app.initialize(argv)
File "", line 2, in initialize
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 87, in catch_config_error
return method(app, *args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 456, in initialize
self.init_sockets()
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 259, in init_sockets
self.init_iopub(context)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 267, in init_iopub
self.iopub_thread = IOPubThread(self.iopub_socket, pipe=True)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/iostream.py", line 66, in init
self.io_loop = IOLoop(make_current=False)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/tornado/util.py", line 208, in new
instance.initialize(**args)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/tornado/platform/epoll.py", line 26, in initialize
super(EPollIOLoop, self).initialize(impl=select.epoll(), **kwargs)
TypeError: initialize() got an unexpected keyword argument 'make_current'
[I 16:29:38.300 NotebookApp] KernelRestarter: restarting kernel (4/5), new random ports
Traceback (most recent call last):
File "/usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
"main", mod_spec)
File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/usr/local/lib/python3.5/dist-packages/ipykernel_launcher.py", line 16, in
app.launch_new_instance()
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 657, in launch_instance
app.initialize(argv)
File "", line 2, in initialize
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 87, in catch_config_error
return method(app, *args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 456, in initialize
self.init_sockets()
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 259, in init_sockets
self.init_iopub(context)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/kernelapp.py", line 267, in init_iopub
self.iopub_thread = IOPubThread(self.iopub_socket, pipe=True)
File "/usr/local/lib/python3.5/dist-packages/ipykernel/iostream.py", line 66, in init
self.io_loop = IOLoop(make_current=False)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/tornado/util.py", line 208, in new
instance.initialize(**args)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/tornado/platform/epoll.py", line 26, in initialize
super(EPollIOLoop, self).initialize(impl=select.epoll(), **kwargs)
TypeError: initialize() got an unexpected keyword argument 'make_current'
[W 16:29:41.314 NotebookApp] KernelRestarter: restart failed
[W 16:29:41.314 NotebookApp] Kernel 34b4ed89-21d5-445e-a727-580a066a28c0 died, removing from map.
[W 16:30:26.457 NotebookApp] Timeout waiting for kernel_info reply from 34b4ed89-21d5-445e-a727-580a066a28c0
[E 16:30:26.458 NotebookApp] Error opening stream: HTTP 404: Not Found (Kernel does not exist: 34b4ed89-21d5-44

Do you install jupyter correctly? It looks like a mismatched tornado version.
Look here
https://github.com/jupyter/help/issues/272#issue-285474280

Closing due to inactivity.


Added more features to timer

The intent is to add more features (Including, but not exclusively for PWM) to the timer.rs module, to expand functionality, and avoid ownership issues of dp.TIMx. WIP, in that it's missing features. Non-breaking, but exposes a second API for PWM, that's not compatible with the EH trait. The current approach to PWM gives the pwm.rs module ownership of the dp.TIMx peripheral. If you want to modify timer features, you must use raw pointers, or timer::Timer and pwm::PwmChannel will have a conflict.
This exposes more features from the hardware, and follows the Ref Man and register action more closely. It avoids using raw pointers, which would otherwise be required in your code, and are currently used in pwm.rs. Note that the previous version only included features shared by all timers. I think we should have 3 categories, per the ref man, since their features are different. The current approach only includes the set of features they all share. I added General Purpose timers. Haven't added Advanced Timers, and Basic Timers.
Have only implemented these for the 3 general purpose timers. Expanding to the others would be easy by copying the macro and modifying according to the datasheet. Haven't done it yet. Doesn't have full functionality.
My intent is to make this explicit by making heavy use of enums corresponding to register entries.
Example, using 3 channels in asymmetric mode:
let mut timer = Timer::tim2(dp.TIM2, 94.hz(), &clocks);

timer.set_resolution(85_106);

timer.set_preload(timer::Channel::One, true);

timer.set_output_compare(Channel::One, OutputCompare::Pwm1);
timer.set_output_compare(Channel::Two, OutputCompare::Pwm1);
timer.set_output_compare_mode(Channel::Three, OutputCompare::AsymmetricPwm1);
timer.set_output_compare_mode(Channel::Four, OutputCompare::AsymmetricPwm1);

timer.set_duty(Channel::One, timer.get_max_duty() / 2);
timer.set_duty(Channel::Two, timer.get_max_duty() / 5);
// Set a phase offset for Channel 3, using asymmetric mode.
timer.set_duty(Channel::Three, timer.get_max_duty() * 3 / 5);
timer.set_duty(Channel::Four, timer.get_max_duty() * 4 / 5);

timer.set_alignment(Alignment::Center1);

timer.enable(Channel::One);
timer.enable(Channel::Two);
timer.enable(Channel::Three);

This is missing features and could use more documentation / ref man quotes, but is non-breaking, and I'd be happy merging even without the features. (And adding them later as required). The main thing that needs to be done is borrow clocks instead of own.
Tangent: Does anyone know whypwm.rs

Broke the macros into 4 categories, but the only effective changes thus far are for timers 2, 3, 4.
Support for the unique timers to f373 and f378 are currently broken.

This is a nice way to get around the shared register ownership problem, but sacrificing the ability to impl traits seems like a high cost :(  I feel like the ability to write code that just says "I just need a timer/PWM/etc, I don't care which chip" is valuable.
Somewhat loosely related and maybe of interest, this comment goes over a recent attempt to offer safe flexibility in regard to the shared-global-register problem.  Users choose their exclusivity type, allowing zero-overhead if a user only needs one channel, and potentially Critical Sections if they need more than one.
I suppose an advantage of the strategy in this PR has no runtime penalty at all no matter how many channels are used.  Doesn't seem like we're gonna be able to have our cake and eat it too with common traits and zero overhead in all cases.
It may be worth using typed channel enums so that timers that don't support four don't have invalid inputs.

Tangent: Does anyone know why pwm.rs broke the macros into 4 categories, but the only effective changes thus far are for timers 2, 3, 4.

There's a couple of levels of macros in the timers, because some needed to set break registers and others didn't.  This split was just trying to reduce duplication.

I completely agree on the traits being important. I'm starting to think offering both APIs is the way to go: Use the existing approach for the general use case, and the new one for when you need to customize.
pwm.rs API is good for supporting embedded-hal traits, eg writing generic code, which is probably majority use case. timer.rs API is good for exposing more functionality in high-level code, and documenting it. Bonus of avoiding raw pointers and using the ownership-of-registers model.
I'm starting to worry less about embedded-hal traits, since they by nature only support the most generic traits for a class of hardware. Eg I gave up on using them in the DAC pr, since evidently, functionality other than setting a word is not generic enough. As soon as you need a feature not part of the eh spec, you lose the ability to take advantage of the traits anyway. Eg see the DAC PR, where I tried to make an EH trait, but couldn't get the guys to agree on anything beyond setting a word value. Then you have to consider if you need to use raw pointers to get around ownership issues.
I love your idea about choosing exclusivity.

I completely agree on the traits being important. I'm starting to think offering both APIs is the way to go...  I think it makes sense to have PWM in 2 locations.

This also makes sense!  I think abstraction in layers is a good way to go.  PAC -> Ergonomic but Low level access -> Generic Traits does seem reasonable.

I love your idea about choosing exclusivity. Thoughts on putting up the PR from your fork?

Hey, great!  I had added it to the issue, but hadn't got feedback yet (and been quite busy!), but I do think it's essentially ready for review.  Would also be interested to get broader feedback from the community and see if it helps address some of the RTIC folks concerns about CSes (in that hopefully they can supply their own Mutex impl).  It mostly just needs some polish/suggestions/tweaks at this stage, which a PR can do!
It notably would also break the interface, so if could be serendipitous to potentially change the frequency/resolution interfacing around the same time to just have one break.

Tangent: (What I meant to post before - oops!) what does the pin selection in the pwm module do? AFAIK, the MCU knows to output to the correct pin if it's set up as an output on the right AF.

Ah, the pin selection in to try and hide the AFx settings all together.  So a user doesn't have to lookup how to configure the pin, they just pass it in and everything else is wired for them.  That particular bit of abstraction I do think worked out nicely!


Move to puppet/download_file as suggested by source

We were running into https://github.com/puppet-community/puppet-download_file/issues/10, since fixed in the puppet/download_file module, but iis_rewrite was still referencing the original (pre-fix) opentable/download_file as a dependency.
This PR updates its dependency to point at the newer version of download_file.
I wasn't sure what to rev the version number to - I guess under semver it should probably be 2.0.0 since it includes a major version rev to a dependency, but I don't see any obvious breaking changes in the dependency, so it may be a little excessive?

I was just about to send a PR for the same thing.. what's needed to merge this, just fixing the build and bumping the version number?
With regards to fixing the build - is it worth just dropping support for Ruby 1.8.7, given that it's ancient at this point?
cc @liamjbennett @amwilson @rmc47


refactor: sink.ts to async-first

Towards #390
Refactor: sink.ts to async-first

[x] Tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)

@stephenplusplus Please take a look.


⚠ ClamAV has degraded performance

In 9ed2ca9, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 34 ms

Resolved: ClamAV performance has improved in c9e70e7.


Scaffolding resolvers

I'd like to request a "scaffolding resolvers" feature. I know that graphqlgen has a feature called "scaffolding resolvers". I'd like this feature to be in this repo as well, it would be awesome several reasons:
I'd like to have a framework for my resolvers scaffolded so it can reduce cognitive overhead when implementing a schema. This goes for two things: 1. best-practices wise and 2. for convenience. I understand that best-practices regarding resolvers could be situation specific, but there are certainly parts where it applies. Convenience being mainly that it doesn't require to know all the ins-and-outs of the types that's being used, and not needed to think about how to setup the resolvers-object with which typings, but that a Schema is converted one-to-one to the resolvers.
I also know that graphqlgen seems to not really tried to be compatible with this awesome generator (as can be read here) and that's why I'm asking this feature here, where I would have to rely on prisma/graphqlgen otherwise

/Going to work on in when porting graphback.dev generator to codegen.


PARQUET-1043: Raise minimum CMake version to 3.2, delete cruft.

Also fixes a gcc 4.8 buglet (std::vector::erase does not accept a const_iterator in gcc 4.8)

Appveyor build for this one https://ci.appveyor.com/project/wesm/parquet-cpp/build/1.0.32

@majetideepak is this ok with you?

LGTM +1

OK, merging this for now since I'm going to do some more work on the build system after ARROW-1142 goes in

Sorry, I was traveling the whole of last week.
This is okay with me. Thanks!


Downgrade file-loader to 0.11.2

Downgrade file-loader to 0.11.2 as the latest version is causing the fonts to be loaded with an object instead of a url.

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   95.29%   95.29%
=======================================
  Files         306      306
  Lines        4121     4121
  Branches      496      496
=======================================
  Hits         3927     3927
  Misses        173      173
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97fa40f...913bd0d. Read the comment docs.

Before downgrading:

After:


undoable when using setValues with context provide old state in function

useUndoable always provide new setter of state (second prop of array) and because of that older setter when using setValues(prev => ({prev}) get a old prev state. When using useState prev argument always will be actual state and setState will be the same function. I have an issue when my app drop some fields from state because of that.
Example:
There is interval that set value. Type smth in inputs, these values will be drop, because in prev state this values will be old because prevState depends on setValues version
If remove setValues from useEffect deps prev will be old state, if u change useUndoable to useState the issue was gone. But if you add setValues in useEffect deps it also was fine. I think useUndoable should be same by API with useState
https://codesandbox.io/s/floral-moon-d4ycmi

I fix my issue by passing setValues into useRef, maybe do smth like this under the hood?

Why not pass state into ref?

Hey @geril2207, thanks for opening this! Thank you for your patience here. I will be looking into this issue this week!

@geril2207 I'm afraid I'm not entirely sure what the issue is here. What do you mean by "drop values?"
Also, have you looked into the static_setState function? By design, it's not a functional updater, so it doesn't have to change along with your state. Could you more clearly describe what is happening and what the expected behavior is?
Your CodeSandbox is a little reductive; I'm not sure if an interval is the proper method of checking the value over time...

@xplato by static_setState you can't  get prev snapshot of state(using function with prev => {} to update state). With setValues u can do this but there prevState actually does not provide actual state(only actual state for current link of function). Yeah i agree with you about my code sandbox, it doesn't show anything. But what if you have two setValues in one function(for example, in real apps you can have handlers that executes with little delay useEffects, other triggers, and in this case you will have an old link to setValues and not actual prevState.
I think about this cases

In this cases second setValues will be not actual setValues and therefore will have an old prevState. To have an actual prevState you always need to have actual setValues link on function.
I hope you understood me)

I think it's easily fixes with passing setValues into ref or state inside of hook. Because if you pass state into ref it does not matter which actual or not actual link on setValues fn you have, you always provide actual prevState like useState API. But if nobody in community worries about this, should let developers option to manually pass setValues into ref to always have an actual link.

Ah, I understand now. I think this is a natural limitation of state updates with useState, no? You are correct that passing this into a ref would give direct access to the current state, though I am hesitant to make this change because it might introduce very subtle state update bugs with projects expecting the more synchronous method of access.

@xplato in useState does not matter which link on setState you use old or new, in all cases your prevState will be actual snapshot of state. In example i have two setValues in one function. I think you can avoid this by batching updates into one setValues, but in my case i have one trigger that execute first update in one place, and then execute second update in another place(different components). In this case component does not render and second update executes on older link on setValues and therefore i have no first updates in second prevState.Yeah, this change maybe can provide some bugs.


Python3 compatibility

I have modified the files for python3 compatibility. Can you do some testing to be sure everything is still working? I do not have a working server at the moment
Also, try to follow indentation standard.
Thanks! :)

Please read the below.
http://stackoverflow.com/questions/1125653/python-4-whitespaces-indention-why
Thank you

I don't care if we use tab or whitespace. We just need to be consistent.
Let me know what you prefer.
Thanks
Le 2015-10-02 01:25, "ole"<EMAIL_ADDRESS>a écrit :

Please read the below.
http://stackoverflow.com/questions/1125653/python-4-whitespaces-indention-why
Thank you
—
Reply to this email directly or view it on GitHub
https://github.com/indepth666/py3rcon/issues/7#issuecomment-144927666.

Sorry, but why you have than change almost all files to use tabs instead if you dont care?
4 spaces as the community said is recommended and we should use it that way.
Now I already merged your things into my repo. So please change it back after i have tested your python3 modification.
Thanks

Because sometime it was tab and sometime it was space. I just wanted to be
uniform. Python3 was throwing error when indentation was not uniform across
the file.
4 spaces it would be since I also prefer it that way. The script I used to
standardize the files was using tabulation but it will be easy to go with
space indentation instead.
Also, another point I would like to discuss with you. Maybe we could use
branching for new feature implementation. What do you think ?
Thanks again.
Le 2015-10-02 10:37, "ole"<EMAIL_ADDRESS>a écrit :

Sorry, but why you have than change almost all files to use tabs instead
if you dont care?
4 spaces as the community said is recommended and we should use it that
way.
Now I already merged your things into my repo. So please change it back
after i have tested your python3 modification.
Thanks
—
Reply to this email directly or view it on GitHub
https://github.com/indepth666/py3rcon/issues/7#issuecomment-145042316.

sure, branching is a good idea and we should already do this for python 3 because many server dont have  python3 installed by default

K. I think it's now standard on Debian, centos and Ubuntu but you are right
that it may be a problem on older server or bsd system. But we may be able
to be python 2.7 and 3 compatible by using newer standard.
Deprecating the use of the curved brace in print and using .format instead
would be a good start. That way we would only have one branch to maintain.
I'll try this weekend and we will see how ti goes.
Le 2015-10-02 10:56, "ole"<EMAIL_ADDRESS>a écrit :

sure, branching is a good idea and we should already do this for python 3
because many server dont have python3 installed by default
—
Reply to this email directly or view it on GitHub
https://github.com/indepth666/py3rcon/issues/7#issuecomment-145050770.

well just installed a brand new server with debian 8 - python 2.7 was installed by default.
So I woudl not recommend to set !#/bin/python3 - ppl will complain "its not running on my server" without checking the python version.

think this issue can be closed as it is compatible with python >=2.7  and >= 3. Except issue #8


Compile flags and not unsets

Please use compile flags (like -D ENABLE_IMAP) and not "everything enabled and just disable what you want by editing a core file) to set which component has to be incuded.
This would be much easier for platformio users. Also, it's impossible to include Custom_ESP_Mail_FS.h in the same directory as ESP_Mail_FS.h if you are using a library manager like platformio, because the ESP_Mail_FS.h is outside the project directory.
So:
A. please use compile flag so that we can choose what to compile, by chaging the platformio config file
B. please don't search for Custom_ESP_Mail_FS.h in the same directory of ESP_Mail_FS.h but use the project directory. (but solution "A" is much better)

Yes, tried and build size is always the same regardless build_unflgas

build_unflags =
	-D ENABLE_IMAP
	-D ESP_MAIL_DEFAULT_SD_FS
	-D ESP_MAIL_DEFAULT_FLASH_FS
	-D ENABLE_NTP_TIME

i would expect a much smaller library, but the firmware is always the same.

Update:
Use build flags -D and -U can't take effect when that preprocessor macros are already defined.
You should remove preprocessor macro from ESP_Mail_FS.h then you can use build flags to def and undef.
If you use PlatformIO, please read PlatformIO documentation first.
-D followed by preprocessor name without space.

You can folk the library to work in your customization version.
By default, in ESP_Mail_FS.h file it can be only following.

#include <FS.h> //<- use in v3.4.0
#define ESP_MAIL_DEFAULT_DEBUG_PORT Serial

Forking is what i'll do if i can't use the build_flag/unflag from pio


Why I didn't get any message?

Hello
Could you give me some suggestion, thanks.
My code:
class ViewController: UIViewController, WebSocketDelegate {
@IBOutlet weak var textView: UITextView!

override func viewDidLoad() {
super.viewDidLoad()
// Setup WebSocket
    let uuid = UIDevice.currentDevice().identifierForVendor!.UUIDString;
    let socketHost = "wss://xwww.italki.com:4433/api/message/ws-poll/007/\(uuid)/websocket"
    let socket = WebSocket(url: NSURL(string: socketHost)!)
   socket.headers["type"] = "auth"
   socket.headers["token"] = "TVRJek1qRTF8MTQ2NjUwODY1Nnw4NTVjMjI5OGQ4MjY4OGY4ZWMyMTQ1MjFmNjkxMTAwMzI1YTZjNjdj"
    socket.delegate = self
    socket.connect()

    if (socket.isConnected == true) {
        print("Connection is successful");
    } else {
        print("Connection is failure")
    }
}

func websocketDidConnect(socket: WebSocket) {
print("web socket is connected")
}
func websocketDidDisconnect(socket: WebSocket, error: NSError?) {
    if let e = error {
        print("Web socket is disconnect: \(error!.localizedDescription)")
    }

//        print("Web socket is disconnect: (error!.localizedDescription)")
}
func websocketDidReceiveData(socket: WebSocket, data: NSData) {

    print("got some data: \(data.length)")
}

func websocketDidReceiveMessage(socket: WebSocket, text: String) {
    print("got some text: \(text)")
    let json :NSDictionary
    do {
        try json = NSJSONSerialization.JSONObjectWithData(text.dataUsingEncoding(NSUTF8StringEncoding)!, options: NSJSONReadingOptions.MutableContainers) as! NSDictionary
        if (json["content"] != nil) {
            textView.text = (json["Content"] as! String) + "\n\n" + textView.text
        }

    }
    catch {
        print("Could not parse json message")
    }

    print("Receive text: \(text)")

}

}
My questions is:
1, Why I always get  print("Connection is failure")
2, Could you give me a demo about auth of starscream
Thanks

This is a common design problem. You have to retain the socket as a property in your class if you don't want it to follow out of scope. See the SimpleTest example.

I'm not sure what you mean by "demo about auth of starscream". Are you talking about doing basic auth with HTTP headers?

Some feedback:
This is a common design problem. You have to retain the socket as a property in your class if you don't want it to follow out of scope. See the SimpleTest example.
--- Yes, I did, it works. thanks
I'm not sure what you mean by "demo about auth of starscream". Are you talking about doing basic auth with HTTP headers?
--- After connection is successful, I need send auth message to server, it means server know Who I am
func websocketDidReceiveMessage(socket: WebSocket, text: String) {
print("Receive text: (text)")
    if (socket.isConnected) {

        let json : JSON = ["token":"TVRJek1qRTF8MTQ2NzY4NTA4OHw2NmEwMDU0NTdiZDFlOTczZTU3ZjUwYzRiMTIxNzEzYWNmMzliZWJi",
                           "type": "auth"]
        socket.writeString(json.rawString()!)
        print(json)

    }
}

However I didn't get any message from server

By the way , I am using SwiftyJSON.

I resolved this issue. I used this string with special format, it looks like:
let sendString = ["{"type":"auth","token":"TVRJek1qRTF8MTQ2NzY4NTA4OHw2NmEwMDU0NTdiZDFlOTczZTU3ZjUwYzRiMTIxNzEzYWNmMzliZWJi"}"]
    if (socket.isConnected && text == "o") {

        socket.writeString(JSON(sendString).rawString()!)

}
Now I have connected with websocket server (sockJS) and gotten this response data from websocket
Thanks


python311Packages.scmrepo: 2.0.3 -> 2.0.4

Diff: https://github.com/iterative/scmrepo/compare/refs/tags/2.0.3...2.0.4
Changelog: https://github.com/iterative/scmrepo/releases/tag/2.0.4
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 283275 run on x86_64-linux 1

14 packages built:

dvc (python311Packages.dvc)
dvc-with-remotes
dvc-with-remotes.dist
dvc.dist (python311Packages.dvc.dist)
python311Packages.dvc-gdrive
python311Packages.dvc-gdrive.dist
python311Packages.dvc-hdfs
python311Packages.dvc-hdfs.dist
python311Packages.dvclive
python311Packages.dvclive.dist
python311Packages.gto
python311Packages.gto.dist
python311Packages.scmrepo
python311Packages.scmrepo.dist


Add Generators with examples in the generated comments

what to include

how to override model in operations
what data is available inside an operation
what data is available inside a policy

also add a generator for a controller using SkinnyControllers::Diet

[x] rails g operation resource_name
[ ] rails g policy resource_name
[ ] rails g skinny_controller resource_name

in progress on the generators branch

closing in favor of PR


Fixed #31552 -- Added support for LZMA and XZ fixtures to loaddata.

https://code.djangoproject.com/ticket/31552

@felixxm thanks for your review int he updated commit I added support for LZMA archives , fixes documentation issues and added a section in 3.2 release notes.

@pauloxnet Thanks :+1:

@felixxm Thanks for your review and merge. 👌


On Conversation Update - Direct line web chat calling Root Dialog again

I have the following code to proactively send a message to the user when they enter the web chat and then begin the root dialog:
bot.on('conversationUpdate', function (message) {
    console.log("Conversation update")
    if (message.membersAdded) {
         message.membersAdded.forEach(function (identity) {
            if (message.membersAdded[0].id === message.address.bot.id) {
                bot.send(new builder.Message()
                    .address(message.address)
                    .text("Hello! You've started a conversation"));
               console.log("Conversation Updated")
               bot.beginDialog(message.address, "/")
            }
        });
    }
});

The root dialog will then begin another dialog which is be chained to more dialogs to ask a series of questions:
bot.dialog('/',function (session){
    console.log("Root Dialog")
    session.send("Root Dialog")
    session.replaceDialog("/dialog1");
});

bot.dialog("/dialog1", [function(session){
    console.log("Dialog1")
    builder.Prompts.choice(session,"Are you there?", "Yes|No", {listStyle: builder.ListStyle.button});
},function(session){
.....
}]);

The bot will then start the dialog and ask a series of questions. This works fine on the emulator, however when I deploy the bot and run it in a web chat (or test in web chat on azure), the bot will start the root dialog again after receiving a response from '/dialog1' prompt, and then continue as normal.
Maybe the root dialog should be called upon the bot receiving a message from the user for the first time - either way both the emulator and web chat should be doing the same thing.  Therefore, I'm not sure if the issue lies in the emulator or direct line/ web chat.
Logs:
2018-02-23T09:16:43.315918+00:00 app[web.1]: restify listening to http://[::]:21401
2018-02-23T09:16:43.785044+00:00 heroku[web.1]: State changed from starting to up
Disconnected from log stream. There may be events happening that you do not see here! Attempting to reconnect...
2018-02-23T09:16:37.821517+00:00 heroku[web.1]: Restarting
2018-02-23T09:16:37.822135+00:00 heroku[web.1]: State changed from up to starting
2018-02-23T09:16:38.557504+00:00 heroku[web.1]: Stopping all processes with SIGTERM
2018-02-23T09:16:38.621179+00:00 heroku[web.1]: Process exited with status 143
2018-02-23T09:16:40.829258+00:00 heroku[web.1]: Starting process with command `npm start`
2018-02-23T09:16:42.697800+00:00 app[web.1]:
2018-02-23T09:16:42.697831+00:00 app[web.1]: ><EMAIL_ADDRESS>start /app
2018-02-23T09:16:42.697832+00:00 app[web.1]: > node index.js
2018-02-23T09:16:42.697833+00:00 app[web.1]:
2018-02-23T09:16:43.315918+00:00 app[web.1]: restify listening to http://[::]:21401
2018-02-23T09:16:43.785044+00:00 heroku[web.1]: State changed from starting to up
2018-02-23T09:17:08.944909+00:00 app[web.1]: Conversation Updated
2018-02-23T09:17:08.946087+00:00 app[web.1]: The Bot State API is deprecated.  Please refer to https://aka.ms/I6swrh for details on how to replace with your own storage.
2018-02-23T09:17:08.948859+00:00 heroku[router]: at=info method=POST path="/api/messages" host=mybot.herokuapp.com request_id=e0064177-f453-4b66-8b58-9a6a1bd405f4 fwd="<IP_ADDRESS>" dyno=web.1 connect=0ms service=181ms status=202 bytes=117 protocol=https
2018-02-23T09:17:12.070370+00:00 app[web.1]: Root Dialog
2018-02-23T09:17:12.070882+00:00 app[web.1]: Dialog1
2018-02-23T09:17:12.330680+00:00 app[web.1]: The Bot State API is deprecated.  Please refer to https://aka.ms/I6swrh for details on how to replace with your own storage.
2018-02-23T09:17:18.504947+00:00 app[web.1]: The Bot State API is deprecated.  Please refer to https://aka.ms/I6swrh for details on how to replace with your own storage.
2018-02-23T09:17:18.699714+00:00 app[web.1]: Root Dialog
2018-02-23T09:17:18.699893+00:00 app[web.1]: Dialog1
2018-02-23T09:17:18.462740+00:00 heroku[router]: at=info method=POST path="/api/messages" host=mybot.herokuapp.com request_id=a7af5e93-5c33-46ab-aec0-707a6e45d16f fwd="<IP_ADDRESS>" dyno=web.1 connect=0ms service=4ms status=202 bytes=117 protocol=https
2018-02-23T09:17:18.507719+00:00 heroku[router]: at=info method=POST path="/api/messages" host=mybot.herokuapp.com request_id=e26f9bbc-7484-46e4-b0e7-b0173fac069d fwd="<IP_ADDRESS>" dyno=web.1 connect=0ms service=5ms status=202 bytes=117 protocol=https
2018-02-23T09:17:18.950503+00:00 app[web.1]: The Bot State API is deprecated.  Please refer to https://aka.ms/I6swrh for details on how to replace with your own storage.

Conversation Update is sent by the direct line connector once when the bot joins the conversation, and once when the user joins the conversation. In the emulator, these are both sent immediately (not the same behavior of the direct line connector). Using WebChat or directline, the bot's ConversationUpdate is sent when the conversation is created and the user's ConversationUpdate is sent when they first send a message. When ConversationUpdate is sent, there isn't enough information in the message to construct the dialog stack... this means that prompts do not work correctly as a response to ConversationUpdate. There is a workaround you can use described here: https://github.com/Microsoft/BotBuilder/issues/4245#issuecomment-369311452

@EricDahlvang Thanks for the prompt reply. To me it looked like a bug but now it makes more sense. I will implement in the way you suggested. Thanks again.

@victorliafook I added a bug on Emulator side to make sure the behavior match the same as on Direct Line service.
I am closing this for now and tracking it over there. Thanks!


[Registration] Edit order status

Here is how the tab for the entry of the treatment orders should look like:

Acceptance criteria

Initially, the status for all order types is "Not required" and the action button has the label "Request"
When an order was requested, then the label of the action button changes to "Edit"
When the "Edit" button was clicked, then a dialog opens where the user has to possibility to cancel the order
When the "Request" button for a lab order was clicked, then a dialog with a text area appears where the lab orders can be written down. (The contents of this dialog will be improved later in a follow-up issue.)
If the status is "In progress", then the order can't be edited.
Given there is an order with status "Done", when a new order is created and then canceled, then the status is "Done" again.

@meddoc-ksplus ,
I have implemented the HTML part of the order table like we discussed in February:

When starting to think about adding behavior to it, it felt like it is too complicated to map the order status to checkboxes (both for the user to understand and the developer to implement). Also it seems not appropriate when users might want to add a further order of some type which is already done.
So I suggest that we proceed with a slight modification: Using a plain text for the order status. For now, it can be "Not required" (intial state), "Pending" (right after the request), "In progress" (e.g. when lab tests started), and "Done".
See the page concept and description above for details.


Add documentation on the stack trace dump capability of the daemon

Add a paragraph about how to force a stack trace dump to the daemon log.
This feature was added in Docker 1.9 I believe, but documentation was
never added.
Docker-DCO-1.1-Signed-off-by: Phil Estes<EMAIL_ADDRESS>(github: estesp)

LGTM

LGTM

couple of nits, but LGTM after those are addressed. Nice!

thanks @thaJeztah! PTAL

cool, LGTM!


Improve RestElement, SpreadElement, ObjectPattern and ObjectExpression handling in lval.js

This makes handling of these four node types in checkLVal and toAssignable(List)? more generic and is a nice preparation for rest and spread properties.

Looks good!


bugfix: containerd instance exit may cause container exit

Signed-off-by: Michael Wan<EMAIL_ADDRESS>Ⅰ. Describe what this PR did
fix problem: container may be killed when containerd process exit
we use a channel to listen container's task status, when channel return, we think the container is quit in simple, so we will kill container and container's task.
but when we restart pouchd, it will cause all channels broken, so we wrongly judge container task exited, and will  kill running container.
time="2018-05-24T11:42:49.209164971+08:00" level=info msg="the task has quit, id: 5e487dbae0b37c8d2c83328c1a5cccc449645365b58036e3b5c4795b8bd86c6c, err: rpc error: code = Internal desc = transport is closing, exitcode: 255, time: 0001-01-01 00:00:00 +0000 UTC"
time="2018-05-24T11:42:49.209504432+08:00" level=error msg="failed to delete task, container id: 5e487dbae0b37c8d2c83328c1a5cccc449645365b58036e3b5c4795b8bd86c6c: grpc: the client connection is closing: failed precondition"
time="2018-05-24T11:42:49.209601826+08:00" level=error msg="failed to delete container, container id: 5e487dbae0b37c8d2c83328c1a5cccc449645365b58036e3b5c4795b8bd86c6c: grpc: the client connection is closing: failed precondition"
time="2018-05-24T11:42:49.577074167+08:00" level=info msg="close containerio backend: jsonfile, id: 5e487dbae0b37c8d2c83328c1a5cccc449645365b58036e3b5c4795b8bd86c6c"
time="2018-05-24T11:42:49.577130322+08:00" level=debug msg="%p after pop end wait %d %d %v&{{1 0} 0xc420d29200 0xc42169e4a0 0xc42169e4e0 true} 0 1 <nil>"
time="2018-05-24T11:42:49.577178302+08:00" level=info msg="finished to subscribe io, backend: jsonfile, id: 5e487dbae0b37c8d2c83328c1a5cccc449645365b58036e3b5c4795b8bd86c6c"
time="2018-05-24T11:42:49.577145494+08:00" level=debug msg="%p after pop end wait %d %d %v&{{9 0} 0xc420d29180 0xc42169e300 0xc42169e320 true} 0 1 <nil>"
time="2018-05-24T11:42:49.577199819+08:00" level=info msg="finished to subscribe io, backend: jsonfile, id: 5e487dbae0b37c8d2c83328c1a5cccc449645365b58036e3b5c4795b8bd86c6c"
time="2018-05-24T11:42:49.577213563+08:00" level=info msg="close containerio backend: jsonfile, id: 5e487dbae0b37c8d2c83328c1a5cccc449645365b58036e3b5c4795b8bd86c6c"
time="2018-05-24T11:42:49.577295216+08:00" level=debug msg="remove endpoint(0c8079230c201c1c63ca159798885fb0ac8ebeaf78fcd3e9b81bb0e84d491468) on network(bridge_<IP_ADDRESS>)"
time="2018-05-24T11:42:49.577385785+08:00" level=debug msg="Revoking external connectivity on endpoint 5e487dba (0c8079230c201c1c63ca159798885fb0ac8ebeaf78fcd3e9b81bb0e84d491468)"

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1407 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
+ Coverage   38.57%   38.59%   +0.02%
==========================================
  Files         248      248
  Lines       16517    16529      +12
==========================================
+ Hits         6372     6380       +8
- Misses       9326     9329       +3
- Partials      819      820       +1

Impacted Files
Coverage Δ

ctrd/watch.go
78.12% <100%> (+4.54%)
:arrow_up:

ctrd/client.go
54.93% <100%> (+0.27%)
:arrow_up:

apis/server/utils.go
61.11% <0%> (-5.56%)
:arrow_down:

daemon/logger/jsonfile/utils.go
70% <0%> (-1.67%)
:arrow_down:

LGTM


Add 16-bit storage InputOutput performance sample

Description
This performance sample demonstrates the bandwidth savings you can achieve on some TBDR architectures when using StorageInputOutput16. It does not modify common framework code.
General Checklist:
Please ensure the following points are checked:

[x] My code follows the coding style
[x] I have reviewed file licenses
[x] I have commented any added functions (in line with Doxygen)
[x] I have commented any code that could be hard to understand
[x] My changes do not add any new compiler warnings
[x] My changes do not add any new validation layer errors or warnings
[x] I have used existing framework/helper functions where possible
[x] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions
[x] My changes do not add any regressions
[x] I have tested every sample to ensure everything runs correctly
[x] This PR describes the scope and expected impact of the changes I am making

I've tested build on Linux and Android, don't have an easy setup to test Windows/macOS build atm. Regressions are not relevant as it doesn't touch other samples. There is no common framework code that warrants Doxygen.
Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

[x] I have tested the sample on at least one compliant Vulkan implementation
[x] If the sample is vendor-specific, I have tagged it appropriately
[x] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
[x] Any dependent assets have been merged and published in downstream modules
[x] For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme

I have tagged the sample as "Arm", but other IHVs might benefit. If so, I can remove the tag. Tested on NVIDIA, AMD (RADV ACO) and Arm Mali.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@gary-sweet @wasimabbas-arm Fixed clang formatting check, please re-approve.

@aurolou Hi Lou, can you review this sample from a DT standpoint?  Would like to verify this on DT before merging.  Thanks!

@aurolou Hi Lou, can you review this sample from a DT standpoint?  Would like to verify this on DT before merging.  Thanks!

sure, I have a look!

sure, I have a look!

@r-potter,  @mattruschnv, hi guys, we'd like to get this one merged soon, but need 3 reviews.  Lou agreed to look at it.  Can you guys take a loo too?  LMK, thx,
mcj

@r-potter,  @mattruschnv, hi guys, we'd like to get this one merged soon, but need 3 reviews.  Lou agreed to look at it.  Can you guys take a loo too?  LMK, thx,
mcj

Can we get one more review on this one so we can merge?  Thanks!
@aurolou, @gary-sweet, @JoseEmilio-ARM, @ZandroFargnoli, @mattruschnv, @AlejandroCosin, @carlosadcq

Can we get one more review on this one so we can merge?  Thanks!
@aurolou, @gary-sweet, @JoseEmilio-ARM, @ZandroFargnoli, @mattruschnv, @AlejandroCosin, @carlosadcq

Can we get one more review on this one so we can merge?  Thanks!
@aurolou, @gary-sweet, @JoseEmilio-ARM, @ZandroFargnoli, @mattruschnv, @AlejandroCosin, @carlosadcq

Can we get one more review on this one so we can merge?  Thanks!
@aurolou, @gary-sweet, @JoseEmilio-ARM, @ZandroFargnoli, @mattruschnv, @AlejandroCosin, @carlosadcq

I tested on Adreno, the sample runs and marks the VK_KHR_16bit_storage extension as 'noop - unsupported' but it is actually supported and listed when device lists out all the extensions supported by the device. I'm not sure yet as to why this is happening since I haven't been able to review the code yet.

I tested on Adreno, the sample runs and marks the VK_KHR_16bit_storage extension as 'noop - unsupported' but it is actually supported and listed when device lists out all the extensions supported by the device. I'm not sure yet as to why this is happening since I haven't been able to review the code yet.

@carlosadcq 16-bit InputOutput feature is probably not supported in that case, it's not just the extension that needs to be supported.

@carlosadcq 16-bit InputOutput feature is probably not supported in that case, it's not just the extension that needs to be supported.

I can't approve, but this LGTM and works as expected on my NVIDIA RTX 2060 (Windows 10).

@HansKristian-Work, can you check out the minor conflicts above and resolve?  Then we should be OK to merge this one.  Thx,
mcj

@HansKristian-Work can you resolve these ones too so I can merge?  Thanks

@marty-johnson59 resolved


lyxal: Watch chancerychambers.net

lyxal requests the watch of the watch_keyword chancerychambers\.net. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

chancerychambers\.net has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


Support clickhouse db

Implementation to support clickhouse db throw clickhouse-driver. Tested manually with remote clickhouse db.

Hi @eskomorokhov would be pretty good to have tests to your code. Can you do that?
And take a look in the way we initiate/import the driver for the other databases.
The way you did it will require me to have the driver installed no matter if I will use it or not.


startsample.bat error when executing

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:
I installed the AVS device SDK for Windows according to your instructions. Everything went fine until I tried to execute the sampleapp.bat. Then I get the error:
SampleApp.exe D:/Profiles/Default/Desktop/msys64/home/myname/build/Integration/AlexaClientSDKConfig.json DEBUG9
The command "SampleApp.exe" is either written wrong or could not been found (translated from German)
Tell us about your environment:
Windows 10 64bit
What version of the AVS Device SDK are you using?
newest AVS device SDK from github
Tell us what hardware you're using:

[x] Desktop / Laptop
[ ] Raspberry Pi
[ ] Other - tell us more:

Tell us about your OS (Type & version):

[ ] Linux
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[x] Other - tell us more: Win 10

Hello j0k3r87,
Can you look in your folder <msys64_installed_path>/alexa_sdk/build/bin and see if SampleApp.exe exists?
If it does not exist, could you capture the output of a re-run of make and post it to this thread (as an attachment would be preferred) ?
Thank you,
-SWH


Restructuring the read me file and creating a docs folder

The read me file should contain the main reasons for the project and how to do code that is related to set up a SCIM API. Having a step by step guild for people who are new to Visual studio, Postman, etc. is very good and useful for many people, but not for experienced developers.
I have moved out the beginners guide to another file in docs, and moved the screenshots there as well. This way we can continue writing docs/adding more resources in the near future. Plus it's a standard for most projects in github.

Hey are the launch.json and task.json required?

Hey are the launch.json and task.json required?

Nope, sorry for that. Auto generated code from VS code committed unintentionally :)