Tool version specification

With the current cli v1.4.1, we get an error when specifying versions for tools with alphabetic suffix such as STAR https://quay.io/repository/biocontainers/star?tab=tags.
$ cwl-ica create-tool-from-template --tool-name star --tool-version 2.7.10b
2023-01-06 08:19:45,683 - ERROR    - create_from_template      - check_shlex_version_arg                  : LineNo. 124  - Was not able to parse 2.7.10b as a version for parameter --tool-version
Traceback (most recent call last):
  File "/Users/kanwals/miniconda/envs/cwl-ica/bin/cwl-ica", line 13, in <module>
    sys.exit(main())
  File "/Users/kanwals/miniconda/envs/cwl-ica/lib/python3.10/utils/cli.py", line 649, in main
    _dispatch()
  File "/Users/kanwals/miniconda/envs/cwl-ica/lib/python3.10/utils/cli.py", line 305, in _dispatch
    create_tool_obj = CreateToolFromTemplate(command_argv)
  File "/Users/kanwals/miniconda/envs/cwl-ica/lib/python3.10/subcommands/creators/create_tool_from_template.py", line 76, in __init__
    self.check_args()
  File "/Users/kanwals/miniconda/envs/cwl-ica/lib/python3.10/subcommands/creators/create_tool_from_template.py", line 104, in check_args
    self.check_shlex_version_arg("--tool-version", tool_version_arg)
  File "/Users/kanwals/miniconda/envs/cwl-ica/lib/python3.10/subcommands/creators/create_from_template.py", line 128, in check_shlex_version_arg
    raise InvalidVersionError
utils.errors.InvalidVersionError

Adding support for this use case will be useful, IMO.

This is a conflict with the semantic version specifications at https://semver.org/ rather than an issue with anything in cwl-ica
I'd recommend specifying the version as 2.7.0--b instead.
Happy to raise an issue in STAR on this.
>>> from semantic_version import Version
>>> Version("2.7.0b")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/alexiswl/mambaforge/envs/cwl-ica/lib/python3.10/site-packages/semantic_version/base.py", line 105, in __init__
    major, minor, patch, prerelease, build = self.parse(version_string, partial)
  File "/home/alexiswl/mambaforge/envs/cwl-ica/lib/python3.10/site-packages/semantic_version/base.py", line 318, in parse
    raise ValueError('Invalid version string: %r' % version_string)
ValueError: Invalid version string: '2.7.0b'
>>> Version("2.7.0--b")
Version('2.7.0--b')

@skanwal reluctant to make any changes to this. Using the semver parser saves a lot of otherwise manual regex hacking on our side.  I am happy to submit a PR to the STAR GitHub page to see if they will change the versioning syntax for releases but would otherwise recommend the --b workaround.

would otherwise recommend the --b workaround.

Sounds good to me.

Suggestion added to STAR - https://github.com/alexdobin/STAR/issues/1738


MultiPart overload for ContentTypeForFile

Hi Bas,
I am trying to upload a File using MultiPart method that has extentions .csv and I am facing an issue because the request is using default file content type as below:

but the endpoint request as below:

Is there a way that you can overload the MultiPart method so it accepts custom File ContentType as example: "text/csv" instead of this:

Also is possible to keep in mind as future improvements to upload multiple files as bulk at the same time using the same method MultiPart?
Have a great day ahead!
Thanks!
Cristian.

Hey @MuresanCristianRichard,
the first part of your request is fairly straightforward, so I'll implement and release that tomorrow. I'll look into uploading multiple files, too, although that might take me a little longer. Or maybe not. We'll see. I'll keep you posted!

Sounds great!
Thanks!
Cristian

Quick question: because the control name is also optional, and all arguments are strings, it's impossible to determine which value goes where without using named arguments when you call the MultiPart() method.
So, this:
Given().MultiPart(controlName: "customControl", fileName: this.csvFileName, contentType: "text/csv")

Alternatives are

Creating a method with a different name (I don't like this)
See if there's another data type that I can use to make it easier to use the overload, but this might break the library API, which I also don't like

Thoughts / ideas are welcome, I'll have a good think about this tonight / tomorrow, too.

@MuresanCristianRichard, I'm thinking of deprecating the existing MultiPart() methods (so you can still use them) and providing a new one with three arguments:

fileName of type FileInfo - mandatory
controlName of type string - optional, defaults to file
contentType of type MediaTypeHeaderValue - optional, when left empty it will be determined automatically as we do right now

Your thoughts?

Hi @basdijkstra,
Deprecating MultiPart() method and providing a new one with three arguments sounds good to me.
Also having default values as MultiPart() is working right now is nice because there will be edge cases when we need to override these arguments, so mostly we will stick to what exists.
Thanks,
Have a great day,
Cristian

Thanks for the quick response. I'll get to work on that later today! Will let you know once I've published a test/preview version.

@MuresanCristianRichard, version 2.5.0-beta is now available on NuGet: https://www.nuget.org/packages/RestAssured.Net/2.5.0-beta
Could you please have a look at the new MultiPart() method overloads? Signature looks like this:
public ExecutableRequest MultiPart(FileInfo fileName, string controlName = "file", MediaTypeHeaderValue? contentType = null)

As you can see, controlName defaults to file as it used to do, contentType defaults to null, in which case it will be automatically determined as before. If specified, the specified value will be used.
Looking forward to your feedback.

Hi @basdijkstra
Sorry for late answer.
Looks good to me. I`ve tested and it works. I successfully imported a CSV file using that method.
Thanks,
Have a great day!
Cristian

No worries, thank you for letting me know @MuresanCristianRichard. I'll have a quick look to see if I can also add uploading multiple files (or rather, if calling MultiPart() multiple times adds separate files properly) and then I'll create a new proper release later this week.

I did a very small but important fix in the way multipart form data is added, which now also makes it possible to upload multiple files in a single API call. What you need to do, like in the original REST Assured, is adding multiple calls to MultiPart().
See this commit and especially the test for an example: https://github.com/basdijkstra/rest-assured-net/commit/c67c06dc25affcaac4a6328ce73716c9f68efb36
@MuresanCristianRichard hope this helps. I'll close this issue when 2.5.0 is released.

Hi @basdijkstra
Sure uploading multiple files using multiple MultiPart() calls will help. Thanks a lot!
Thanks for enhancement too!
Cristian


E2: Helper does not search for registered constants

Perhaps add an option to search (registered) constants?

Well, you can type "_" and the autocomplete thingy will list them all for you, since there aren't that many. But sure I guess it could be added to the E2Helper as well.

Ok. Nice.
Looks like this one were left open. Closing it manually.
NOTE: Use fixes #N in the title of PR next time, where N is issue's ID to auto-close referenced issue in future ;)


New release?

It's been awhile since a release, and I'd love to be able to use this.

soon :) like 2 weeks

OOI, being a bit of a noob with npm and the like, how do I upgrade bower?

npm update -g bower

Doh! :-D

Is it possible to alias this within bower itself, so just like composer, I can use composer selfupdate and bower selfupdate. I would love to have the same mechanics for composer and bower. Ideally, the same config file for all. MY project is PHP+PECL+JS+etc. So it would be nice to have it all in 1 config. I can but dream!

I've just ran the bower update and saw ...
<EMAIL_ADDRESS>C:\Users\RichardQ\AppData\Roaming\npm\node_modules\bower-installer\node_modules\bower
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>bl@
0.9.4<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Note the 1.3.12 at the top.
Running bower -v does show 1.4.1 which ties up with the latest tag.
Is this important? Or just something I'm misreading?

I don't believe npm update -g bower actually upgrades bower if you already have it installed.

I think bower install -g bower also can update.

I don't want to install bower as a project dependency, so using bower to install bower will work.


Add support for query logics

Currently, all tokens are treated using the OR logic ("science medicine" is "science" or "medicine"). The query parser should support the following requirements:

[x] AND,  OR as well as NOT logic.
[x] Alternative syntax using &, | and - (minus means exclusion, e.g. science -medicine)
[x] Grouping: (C OR C++ OR Python) AND developer AND (Linux OR Unix OR BSD) AND NOT (C# OR Java)
[x] Nesting: (software AND (engineer OR developer))
[x] Exact terms using quotes, e.g. ("software engineer" OR "software developer")
[x] Defined order of operations: does A | B & C mean (A | B) & C or A | (B & C)? I'd say stick with standard  precedence in logics: ¬, ∧,∨. But left-to-right might also be an option.

Consider using re2c and lemon for lexer and parser.

Note: support for quoting implemented, but exact string search is a separate ticket.


Pushable blocks!

You can now push blocks.

We can also add these:

Max moves (to limit number of pushes)
Direction constraint (so they can only be pushed one way as in Z1)

And a companion object "block detector" that could trigger another node. (like a door to open it).

I hate to close this after some good code and discussion, but #22 is more easily configurable and works with networking. I was actually trying to implement networking and one-shot to this PR last night but woke up to another very nice solution. Sorry about this!

No worries!


Which is the fastest learner?

Hi,
wow this is really a great repository :+1:
Which method do you recommend to try first?
The optimality tightening paper makes some really impressive claims, about the speed that they learn. I was just wondering if you've managed to reproduce any of their results? I just saw a theano implementation by one of the authors here
Thanks for your advice,
Aj

Thanks Aj :)
Both Double-Q learning and Persistent Advantage Learning seem to work well
My first impression of optimality tightening is that it doesn't seem to give too much improvement, but I haven't tried it out on many games and it's quite possible that there's a bug somewhere. I haven't been trying to reproduce results so much as learn how all these algorithms work
Let me know if it works for you


Drop sbt 0.13 slash syntax

This PR fixes warnings in sbt like this:
[info] /build.sbt:18: warning: method in in trait ScopingSetting is deprecated (since 1.5.0): `in` is deprecated; migrate to slash syntax - https://www.scala-sbt.org/1.x/docs/Migrating-from-sbt-013x.html#slash
  javacOptions in (Compile, compile) ++= Seq("-source", "1.8", "-target", "1.8"),
               ^
/build.sbt:48: warning: method in in trait ScopingSetting is deprecated (since 1.5.0): `in` is deprecated; migrate to slash syntax - https://www.scala-sbt.org/1.x/docs/Migrating-from-sbt-013x.html#slash
  publishArtifact in Test := false

Fixed in #409


Patch issue with Grading in production

There was a regression bug in production which caused grading to fail. This was due to a mismatch of the fields passed into the backend API.
This bug has been patched. This PR updates the current master to be in sync with the deployed version.
Changes

Removed comment from SUBMIT_GRADING action
Send empty string as comment to backend

Pull Request Test Coverage Report for Build 2261

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 34.301%

Totals

Change from base Build 2207:
0.0%

Covered Lines:
1777

Relevant Lines:
4562

💛  - Coveralls

This is what the action looked like:
export const submitGrading: ActionCreator<actionTypes.IAction> = (
  submissionId: number,
  questionId: number,
  comment: string,
  gradeAdjustment: number = 0,
  xpAdjustment: number = 0
) => ({
  type: actionTypes.SUBMIT_GRADING,
  payload: {
    submissionId,
    questionId,
    comment,
    gradeAdjustment,
    xpAdjustment
  }
});

However, the grading component passed this in:
this.props.handleGradingSave(
        this.props.submissionId,
        this.props.questionId,
        gradeAdjustmentInput,
        xpAdjustmentInput
      );

The mapDispatchToProps will not be able to map the parameter fields in as well based on the name. So instead, it just passes the first four into the first function. So comment takes the gradeAdjustment and xpAdjustment is always 0.
You can test this out by simply inspecting the HTTP request/response packets when making the POST request.


Include additional interactions between disease modules

Include additional interactions between disease modules:
HIV - other adult cancers
HIV - CVD (ischaemic heart disease)
HIV - depression
DM - TB
Schisto - bladder cancer

This has now been merged with PR #1273 and can be closed.


Extra state secret when using the kubernetes backend

What happened?
I have the terraform provider installed and configured to use kubernetes incluster-config as a state store. This seems to work great, and I get a state file for my Workspaces. However, once I apply a Workspace (terraform-test), I also get a state file secret that says it is from a non-existent default Workspace.
apiVersion: v1
data:
  tfstate: H4sIAAAAAAAA/0SMwa6CMBBF93xFM+tX8nAAW37FGDLgqMRKzbR1Q/h307pwec85uVulFLxZwuJXGFT7l3dkEbp6eY4/A03d1R0UH1gWcjCopk
y3rEw3zhEREpqj0Whx0r39R92ZA+rJXLi1vWUk+n74FF8pBhjUthcgHHySmTM6nQua7zw/RuGQXCnX5Fy1V58AAAD//5qciza0AAAA
kind: Secret
metadata:
  annotations:
    encoding: gzip
  creationTimestamp: "2023-11-09T20:22:32Z"
  labels:
    app.kubernetes.io/managed-by: terraform
    tfstate: "true"
    tfstateSecretSuffix: providerconfig-default
    tfstateWorkspace: default
  name: tfstate-default-providerconfig-default
  namespace: crossplane-system
  resourceVersion: "3127887"
  uid: 04bc13f5-9cc0-447f-81b4-bbea6baa164c
type: Opaque

This seems to happen the first time I apply a workspace with a new providerconfig.
tfstate-default-providerconfig-default                  Opaque                       1              38s
tfstate-default-providerconfig-defaulttwo               Opaque                       1              71s
tfstate-terraform-test-providerconfig-default              Opaque                       1              33s
tfstate-terraform-test-2-providerconfig-defaulttwo           Opaque                       1              66s

And if I delete my workspace, the tfstate-default-providerconfig-default secret remains.
How can we reproduce it?
aws-irsa DeploymentRuntimeConfig not included
apiVersion: pkg.crossplane.io/v1
kind: Provider
metadata:
  name: provider-terraform
spec:
  package: xpkg.upbound.io/upbound/provider-terraform:v0.11.0
  runtimeConfigRef:
    name: aws-irsa
---
apiVersion: tf.upbound.io/v1beta1
kind: ProviderConfig
metadata:
  name: default
spec:
  credentials:
    - filename: aws.json
      source: None

  configuration: |
    provider "aws" {}

    // Modules _must_ use remote state. The provider does not persist state.
    terraform {
      backend "kubernetes" {
        secret_suffix     = "providerconfig-default"
        namespace         = "crossplane-system"
        in_cluster_config = true
      }
    }
---
apiVersion: tf.upbound.io/v1beta1
kind: Workspace
metadata:
  name: terraform-test
spec:
  forProvider:
    source: Inline
    module: |
      data "aws_region"          "current" {}

      output "region" {
        value       = data.aws_region.current.name
        description = "The current AWS region."
      }

What environment did it happen in?

Crossplane Version: 1.14.0
Provider Version: 0.11.0
Kubernetes Version: v1.28.3-eks-4f4795d
Kubernetes Distribution: EKS

I believe this is caused by the way the terraform CLI is implemented.  If I remember correctly we have to run terraform init before we can set the specific workspace name - we can't set the workspace before we run terraform init.  So that causes the default workspace to be created.
We don't use the default workspace for anything, it's just an artifact of the way the CLI works.
Is there a problem with having it there?  I don't know that we can delete it permanently - it will come back every time the terraform CLI is executed.

It's not really a problem, just confusing and I don't think it's documented. I do wonder though what would happen if I named a workspace "default"

I think it would just use the default workspace.  The problem would be if you have more than one Workspace with the crossplane.io/external-name set to "default" because that's where we get the workspace name from.  That's true for any external-name, since it's not unique it would cause collisions between Workspaces/workspaces.  We should probably change that to use metadata.name instead so we are guaranteed a unique workspace name.   @ytsarev any thoughts?

I did just try out making a workspace called default, and then making other workspaces and it didn't seem to cause an issue. I was worried it would delete the default workspace resources or something

It will not try to delete the default workspace unless you use it as a workspace external-name, so in this case when you deleted the Workspace it also deleted the default workspace and then it was recreated the next time the terrform command was run.


JSON-LD support

Is there any thought to adding support for JSON-LD? If no, any interest in pull requests that attempt to add rudimentary support?

JSON-LD support would be great! Parsing or serialisation, or both? It's not something I could commit time to, but a pull request would be very welcome. The existing parsers use the W3C test suite as its unit tests, which covers the rdf4h parsers for lots of corner cases, so having support JSON-LD with corresponding Haskell tests for the W3c JSON-LD tests would be ideal. See:
https://github.com/json-ld/json-ld.org/tree/master/test-suite

Cool, I'll put some thought into it over the holidays. For my specific use case I need to parse, but serialization into JSON-LD looks remarkably straightforward. I'll see what I can do! :-)

Using aeson, say?
I'd been working on a serializer in Scala using a writer monad (I just adapted my existing JSON serializer and used the writer monad to "write" the parts I stripped away in converting to JSON into the context.) https://github.com/LeifW/Treeify/blob/master/src/main/scala/treeify/Treeify.scala

Hi @biesnecker , how far did you get with this JSON-LD parser?

Not far, sadly. Ended up having to write the project in C++ so didn't work
too much on the Haskell parser.
On Thursday, October 27, 2016, Rob Stewart<EMAIL_ADDRESS>wrote:

Hi @biesnecker https://github.com/biesnecker , how far did you get with
this JSON-LD parser?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/robstewart57/rdf4h/issues/34#issuecomment-256594424,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAR9dvmMp4etCDw9omjOwbKTlQo9h8yFks5q4HCTgaJpZM4G4nNH
.


When I run apollo.sh, I can't get access to abseil, how to solve this problem

When I run apollo.sh(./apollo.sh build_cpu), I can't get access to abseil, how to solve this problem ？
ERROR INFORMATION:
INFO: (05-23 10:25:58.589) Timeout connecting to https://github.com/abseil/abseil-cpp/archive/cd95e71df6eaf8f2a282b1da556c2cf1c9b09207.tar.gz

When I run apollo.sh(./apollo.sh build_cpu), I can't get access to abseil, how to solve this problem ？
ERROR INFORMATION:
INFO: (05-23 10:25:58.589) Timeout connecting to https://github.com/abseil/abseil-cpp/archive/cd95e71df6eaf8f2a282b1da556c2cf1c9b09207.tar.gz

On which  branch ?   What's the bazel version (By  running bazel version) ？
Generally, u can use a proxy when before running apollo.sh by setting like
export HTTP_PROXY=agent.example.com:8018
export HTTPS_PROXY=agent.example.com:8018

On which branch ? What's the bazel version (By running bazel version) ？
Generally, u can use a proxy when before running apollo.sh by setting like
export HTTP_PROXY=agent.example.com:8018
export HTTPS_PROXY=agent.example.com:8018

I have checked the code, this issue happened when I run this code
"  bazel build $JOB_ARG $DEFINES -c $@ $BUILD_TARGETS" <Line 147 in apollo.sh>
The bazel version is 3.1.0
I have already set the HTTP_PROXY, but it doesn't work.
Can I install "abseil" by myself without by the code?
我觉得我的问题在于即使设置了代理，bazel也不能从网上下载东西，一开始是不能下载“https://github.com/ApolloAuto/apollo-contrib/releases/download/v3.0.0/plat-sw-<IP_ADDRESS>.zip”，我看代码发现写在WORKSPACE.in中，于是自己把这个文件下载，放在/home/tmp中。但是我不知道这个“abseil”安装包是应该放在哪一个文件夹中。这个能够自己先安装吗，不通过指令？

On which branch ? What's the bazel version (By running bazel version) ？
Generally, u can use a proxy when before running apollo.sh by setting like
export HTTP_PROXY=agent.example.com:8018
export HTTPS_PROXY=agent.example.com:8018

I have checked the code, this issue happened when I run this code
" bazel build $JOB_ARG $DEFINES -c $@ $BUILD_TARGETS" <Line 147 in apollo.sh>

As far as I know, only the docker_dev branch has bazel 3.1.0 enabled.
With bazel 3.x, you can place your pre-downloaded tarballs under /apollo/.cache/distdir, and enable the --distdir=/apollo/.cache/distdir option when calling bazel build/test. Eg. bazel build --distdir=/apollo/.cache/distdir //cyber/..., or  bazel test --distdir=/apollo/.cache/distdir.

When I run apollo.sh(./apollo.sh build_cpu), I can't get access to abseil, how to solve this problem ？
ERROR INFORMATION:
INFO: (05-23 10:25:58.589) Timeout connecting to https://github.com/abseil/abseil-cpp/archive/cd95e71df6eaf8f2a282b1da556c2cf1c9b09207.tar.gz

Fixed in #11362 .
Re-open this issue if it still doesn't  work for you.


Create .gitpod.yml

Closes #20

Maintainers kindly Install https://github.com/apps/gitpod-io for this to work!

@saurabh-prakash Can you please also add hacktoberfest-accepted label for this PR, after review? thanks 👍🏻

@Smartmind12 How will this run? And what benefit will it provide? Can you paste a URL or screenshot to provide evidence of this in action?


Typo on your web page

Hi, only a small thing.
On your page (http://jglue.org/cdi-unit/)
The tags of the artifact are wrong, so copy/paste is not so comfortable.
 &
Thanks
Uwe / Germany
 org.jglue cdi-unit 0.9.7 test

Fixed thanks!


Module/qc/1.0

Pull Request Checklists
Important: When opening a pull request, keep only the applicable checklist and delete all other sections.
Checklist for New Module
Required

[X] I used the cookiecutter template and updated the placeholder rules.

[X] The snakemake rules follow the design guidelines.

[X] All references to the rules object (e.g. for input files) are wrapped with str().

[X] Input and output files are being symlinked into the CFG["inputs"] and CFG["outputs"] subdirectories, respectively.

[X] I updated the final target rule (*_all) to include every output rule.

[X] I tested the module on real data for all supported seq_type values.

[X] I updated the default.yaml configuration file to provide default values for each rule in the module snakefile.

[X] I did not set any global wildcard constraints. Any/all wildcard constraints are set on a per-rule basis.

[X] I ensured that all symbolic links are relative and self-contained (i.e. do not point outside of the repository).

[X] I replaced every value that should (or might need to) be updated in the default configuration file with __UPDATE__.

[X] I recursively searched for all comments containing TODO to ensure none were left. For example:
grep -r TODO modules/<module_name>/1.0

If applicable

[ ] I added more granular output subdirectories.

[ ] I added rules to the reference_files workflow to generate any new reference files.

[ ] I added subdirectories with large intermediate files to the list of scratch_subdirectories in the default.yaml configuration file.

[ ] I updated the list of available wildcards for the input files in the default.yaml configuration file.

Checklist for Updated Module
Important! If you are updating the module version, ensure the previous version of the module is restored from master.
If you want to restore a deleted file or directory from the remote master, you can use git checkout origin/master path/to/file,
then a git commit will ensure that file is tracked on your branch again.
Example:
mv modules/strelka/1.1 modules/strelka/1.2
git checkout origin/master modules/strelka/1.1

The typos and changelog has been now fixed!


Context awared tab placement.

Suppose I have three tabs : 1, 2 and 3, and the current tab is 2. If I open three new tabs, currently it will end up like this : 1, 2 , 6, 5, 4, 3. Is there a way to get this tab order : 1, 2, 4, 5, 6, 3 ?

Isn't that the default behaviour? If not, there is certainly another add-on that is doing that. I am not interested in implementing it.


Add consts for page orientations

As a new user I'd prefer to have page orientations available as consts, so that it's easier for me to get started. Also, I moved strings.ToLower(..) call on orientationStr to the top of the function so that you don't lowerize a default value, and the sanitization in a single place.

Thanks @slomek -- welcome changes!


ci: merge opae-libs

Automated changes by create-pull-request GitHub action.
Must be use a normal merge (not squash-merge and not rebase-merge)

Coverage remained the same at 61.301% when pulling 58f3aacdea5f2aafe0049442554886277fd3c20e on auto/update-libs into 824e59d4a1d48fa6acdcf7b15cd78cd1be9cf27a on master.


Support larger list of version and AWS API v4

Support larger list of version and AWS API v4

This is a small problem with this PR. I will make a better version later.

Sorry about the delay in reviewing. I've made some comments, and also fixed up tests to run on travis.


fix different attribute order

fixes the issue as reported in #86

@naltatis can you check this pull request?

@waldemar-schneider  This project seems abandoned. One month and no responses...

Sorry for the slow responses. I will definitely look into this in the next says.

@naltatis That's great to hear! :)

Is there any progress in this PR?

@marlonbernardes you were right. This project seems abandoned...

This be fixed with the merged PR cae9c91142f3c8e560ffd062d51de6ca51d63427 from @IRus.


[MM-T1791] Cypress Test for Permalink 'Jump to' in Search

Summary

Adds an E2E test for Permalink 'Jump to' in Search.
Ticket Link

MM-T1791

@saturninoabril Updated to include the suggestions you made!

/update-branch


Update ncproxy API and adjust hcn support

The primary change in this PR is the update of the ncproxy API with additional messages for a new "ncproxy network" and "ncproxy endpoint". The PR refactors and updates the existing code flow for hcn networks and leaves the implementation of the ncproxy network and ncproxy endpoint for later PRs.
Signed-off-by: Kathryn Baldauf<EMAIL_ADDRESS>

Reminder to push new commits for ease of review


serd: 0.28.0 -> 0.30.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/serd/versions.
meta.description for serd is: '"A lightweight C library for RDF syntax which supports reading and writing Turtle and NTriples"'.

Checks done (click to expand)

built on NixOS
/nix/store/27g41a39l8rkif2g64qkiv5068na7n9d-serd-0.30.0/bin/serdi passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 0.30.0 with grep in /nix/store/27g41a39l8rkif2g64qkiv5068na7n9d-serd-0.30.0
directory tree listing: https://gist.github.com/6993a4124c2acb7e428a57c2f40c0d37
du listing: https://gist.github.com/1b90c4671a801867163f6bdec4958e1d

Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 0e420de73ab2c3e8a7e68a1968b45bc7773b3475 && nix-shell --pure -I nixpkgs=. -p serd

cc @cillianderoiste for testing.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: serd
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: serd
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/27g41a39l8rkif2g64qkiv5068na7n9d-serd-0.30.0
shrinking /nix/store/27g41a39l8rkif2g64qkiv5068na7n9d-serd-0.30.0/bin/serdi
shrinking /nix/store/27g41a39l8rkif2g64qkiv5068na7n9d-serd-0.30.0/lib/libserd-0.so.0.30.0
gzipping man pages under /nix/store/27g41a39l8rkif2g64qkiv5068na7n9d-serd-0.30.0/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/27g41a39l8rkif2g64qkiv5068na7n9d-serd-0.30.0/lib  /nix/store/27g41a39l8rkif2g64qkiv5068na7n9d-serd-0.30.0/bin
patching script interpreter paths in /nix/store/27g41a39l8rkif2g64qkiv5068na7n9d-serd-0.30.0
checking for references to /build in /nix/store/27g41a39l8rkif2g64qkiv5068na7n9d-serd-0.30.0...
/nix/store/27g41a39l8rkif2g64qkiv5068na7n9d-serd-0.30.0

Success on aarch64-linux (full log)
Attempted: serd
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5w1p3xmgk90f3339xdrvp3r3pahis4w5-serd-0.30.0
shrinking /nix/store/5w1p3xmgk90f3339xdrvp3r3pahis4w5-serd-0.30.0/bin/serdi
shrinking /nix/store/5w1p3xmgk90f3339xdrvp3r3pahis4w5-serd-0.30.0/lib/libserd-0.so.0.30.0
gzipping man pages under /nix/store/5w1p3xmgk90f3339xdrvp3r3pahis4w5-serd-0.30.0/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5w1p3xmgk90f3339xdrvp3r3pahis4w5-serd-0.30.0/lib  /nix/store/5w1p3xmgk90f3339xdrvp3r3pahis4w5-serd-0.30.0/bin
patching script interpreter paths in /nix/store/5w1p3xmgk90f3339xdrvp3r3pahis4w5-serd-0.30.0
checking for references to /build in /nix/store/5w1p3xmgk90f3339xdrvp3r3pahis4w5-serd-0.30.0...
/nix/store/5w1p3xmgk90f3339xdrvp3r3pahis4w5-serd-0.30.0

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: serd
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Timed out, unknown build status on x86_64-linux (full log)
Attempted: serd
Partial log (click to expand)
cannot build derivation '/nix/store/j10zr312hl94i98v3id24qahi701ndn2-perl-5.28.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/da17mp9k8dxyq3dwbi892dvm973pkdvc-pkg-config-0.29.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/h620r5izbncj2cadbljxwn3n1qlwldn3-python-setup-hook.sh.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/9nbsc9dyb56gjxmgw8aq4gdmb3r6rd6p-sqlite-3.24.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/1mjvz8lz3645j73mfs82bfy6kk4dpfk9-ncurses-6.1.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/34h8gi0snij0d543scm366920im8nfq3-openssl-1.0.2o.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/b85cv5acg7anansh3k0j1rqm4y627svl-readline-6.3p08.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/zyfzwl6a52dzzj9addbhw9pqzaiif20l-python-2.7.15.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/kbndysyy57j4slsk962swhpazan6mk05-serd-0.30.0.drv': 4 dependencies couldn't be built
error: build of '/nix/store/kbndysyy57j4slsk962swhpazan6mk05-serd-0.30.0.drv' failed

@GrahamcOfBorg build serd

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: serd
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: serd
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/38868w2rrpscc42x7dmd1401lkn58iiv-serd-0.30.0
shrinking /nix/store/38868w2rrpscc42x7dmd1401lkn58iiv-serd-0.30.0/bin/serdi
shrinking /nix/store/38868w2rrpscc42x7dmd1401lkn58iiv-serd-0.30.0/lib/libserd-0.so.0.30.0
gzipping man pages under /nix/store/38868w2rrpscc42x7dmd1401lkn58iiv-serd-0.30.0/share/man/
/nix/store/n46a0fr3h4nhj5rhg557ly7idmxpmrjq-binutils-2.30/bin/strip is /nix/store/n46a0fr3h4nhj5rhg557ly7idmxpmrjq-binutils-2.30/bin/strip
stripping (with command /nix/store/n46a0fr3h4nhj5rhg557ly7idmxpmrjq-binutils-2.30/bin/strip and flags -S) in /nix/store/38868w2rrpscc42x7dmd1401lkn58iiv-serd-0.30.0/lib  /nix/store/38868w2rrpscc42x7dmd1401lkn58iiv-serd-0.30.0/bin
patching script interpreter paths in /nix/store/38868w2rrpscc42x7dmd1401lkn58iiv-serd-0.30.0
checking for references to /build in /nix/store/38868w2rrpscc42x7dmd1401lkn58iiv-serd-0.30.0...
/nix/store/38868w2rrpscc42x7dmd1401lkn58iiv-serd-0.30.0

Success on aarch64-linux (full log)
Attempted: serd
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/269lalbps3diyjv00qfl8c6m9jpzxhmi-serd-0.30.0
shrinking /nix/store/269lalbps3diyjv00qfl8c6m9jpzxhmi-serd-0.30.0/bin/serdi
shrinking /nix/store/269lalbps3diyjv00qfl8c6m9jpzxhmi-serd-0.30.0/lib/libserd-0.so.0.30.0
gzipping man pages under /nix/store/269lalbps3diyjv00qfl8c6m9jpzxhmi-serd-0.30.0/share/man/
/nix/store/3bq0zgzfmfynpkwxs0f6r5xrasi987ps-binutils-2.30/bin/strip is /nix/store/3bq0zgzfmfynpkwxs0f6r5xrasi987ps-binutils-2.30/bin/strip
stripping (with command /nix/store/3bq0zgzfmfynpkwxs0f6r5xrasi987ps-binutils-2.30/bin/strip and flags -S) in /nix/store/269lalbps3diyjv00qfl8c6m9jpzxhmi-serd-0.30.0/lib  /nix/store/269lalbps3diyjv00qfl8c6m9jpzxhmi-serd-0.30.0/bin
patching script interpreter paths in /nix/store/269lalbps3diyjv00qfl8c6m9jpzxhmi-serd-0.30.0
checking for references to /build in /nix/store/269lalbps3diyjv00qfl8c6m9jpzxhmi-serd-0.30.0...
/nix/store/269lalbps3diyjv00qfl8c6m9jpzxhmi-serd-0.30.0


Insist on HTTPS Connection

We should check for https connections and only let them flow through the api. All other connections should be responded with an error.

I'd suggest making this configurable and turning it off in dev mode.

Good point.


Change position of region end handler

Short description of changes:
Currently start handler is located inside the region while end handler is outside of the region boundary.
PR solves the issue by relocating the end handler to be a part of whole region block
Breaking in the external API:
No breaking changes
Breaking changes in the internal API:
No breaking changes
Todos/Notes:

Related Issues and other PRs:

Coverage remained the same at 79.677% when pulling 1bbd347f52b4d05586529721c704b7db2a34205d on corticph:regions-handler-position into 8ba3328102da9746ce1fd390c0801f01edaaf612 on katspaugh:master.

thanks @viliuslinge, looks good to me.


Fix fox DnsDB failure

Handles #118

Spoke with @picatz on Slack. We are going to merge directly.


SafariViewController in iOS 10

Just an FYI really that as of iOS 10 safariviewcontroller cannot be hidden:
From https://developer.apple.com/app-store/review/guidelines/:

SafariViewContoller must be used to visibly present information to users; the controller may not be hidden or obscured by other views or layers. Additionally, an app may not use SafariViewController to track users without their knowledge and consent.

Trying to do so just results in nothing happening. :(

Oh shoot! You confirmed that it did work in iOS 9 and doesn't in 10? Then I need to deprecate that property and update the doc..

@jamessharp Good catch. So we probably need a PR to update the docs at least.

Yup

Does this mean that passing cookie authentication in the background will no longer work?

A fix has been merged into master - I've seen it compiles fine and all seems good at runtime, but I'd be even happier if someone with a real need for this feature tests the current version on GitHub.
Thanks!


Updating primitives names for 'mimcap 1p0fF' in lvs gds files

Fixes https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/issues/1

Renaming mim_cap1p0fF device with its new name in the gds files used in LVS testing under the following directory:

globalfoundries-pdk-libs-gf180mcu_fd_pr/rules/klayout/lvs/testing/testcases/

@mithro Changes is completed including cap_mim as you agreed with @atorkmabrains


ToC broken because of emoji

When an emoji is used in a header, the table-of-content link will not be generated properly.

# foo 💣 as header generates     - [foo 💣](#foo-%F0%9F%92%A3), wich is invalid.
The solution would be to ignore the emoji. This does work:     - [foo 💣](#foo-)

Nope. The link is just broken

I guess - [foo 💣](#foo-%F0%9F%92%A3) works well within vscode preview, right?
And there is a setting encodeUri you can set to false. Then it will be - [foo 💣](#foo-💣)
See more information in #98.


spec: Typo - Types

The term "Flavour" was defined in the Cloak protocol, should we port it over to zkvm or leave a pointer?

Looks great, thank for editing this!

Sorry for the last 3 typographic nitpicks, looks good.

No worries, let me know if there are anymore mistakes :)


Update 01-install.md

Added command for windows to access the argocd ui ,i find difficulty in finding the solution so raising the pull request.

Thanks for the contribution @baroonjha


"Proxy setup broken" after master deployment

After a successful deployment of a master instance, Jenkins complains that: It appears that your reverse proxy set up is broken.
This is on an Ubuntu 16.04 amd64 VM with a default Ubuntu Server install, working DNS and public hostnames. Both pre- and post-jep-200 version of buildfarm_deployment.

@RonaldEnsing: FYI.

The Jenkins says my reverse proxy setup is broken page discusses this and provides some hints on what to check / how to address this. The last post (by Gary Phillip) helped.
For this particular host, I had to add the following settings to /etc/apache2/sites-available25-master.conf:
AllowEncodedSlashes NoDecode

and append nocanon to ProxyPass / http://localhost:8080/.
I've also:

updated ServerName from master to the actual hostname of the server
set ProxyPreserveHost to On

@nuclearsandwich: the proxy warning has popped up on all deployments for me, would it be an idea to add this to the Apache setup in modules/profile/manifests/jenkins/master.pp?

@nuclearsandwich: the proxy warning has popped up on all deployments for me, would it be an idea to add this to the Apache setup in modules/profile/manifests/jenkins/master.pp?

Yeah this has been present on all deployments (including the original Trusty canonical buildfarm) and because it never interfered with operation I let it be. But if there's a way to resolve the error message while still being flexible enough to work without too much manual config, I would merrily review the PR.

because it never interfered with operation I let it be

yes, it doesn't seem to really impact operations, but a warning/error is a warning/error, and I've noticed people wondering whether something is really broken.
I'll submit a PR.

Resolved by @gavanderhoorn in #215. Thanks!


#52 Improve the error message of the node status command

Addressing #52

@n1rna Thanks for the PR! Could you also implement a panic-handler that shows the panic messages in a beautiful format?
Maybe staring with a red-colored “Error:” and then the panic message :)

Codecov Report
Patch coverage has no change and project coverage change: +53.50 :tada:

Comparison is base (9d313fe) 0.00% compared to head (069a5c6) 53.50%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #79       +/-   ##
===========================================
+ Coverage        0   53.50%   +53.50%
===========================================
  Files           0      106      +106
  Lines           0     5398     +5398
===========================================
+ Hits            0     2888     +2888
- Misses          0     2510     +2510

see 106 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@n1rna Looks perfect! We will make it better over time, thanks!


Documentation add optional field in variant_recoder/

Description
Need to change the description of endpoint variant_recoder/ because a new optional field was added
Use case
This documentation is needed to allow users to know it is possible to output VCF format.
Benefits
Users may get VCF format as output.
Possible Drawbacks
None
Testing
No tests needed
Changelog
The functionality of the endpoint is the same.

Coverage increased (+0.004%) to 44.311% when pulling 364686caf6228f752659283d3f777920ac6728f4 on dglemos:docs/vcf_format_variant_recoder into 462a49cecc246d2536a15603ca2c97fca963d3f5 on Ensembl:master.


[release-4.15] OCPBUGS-36036 go.*,vendor: bump go-retryablehttp

This is a manual cherry-pick of https://github.com/openshift/cluster-image-registry-operator/pull/1064.
Automated cherry-pick failed due to conflicts (probably caused by this branch having an older version of golang.org/x/sys).

/jira cherry-pick OCPBUGS-36037

/retitle [release-4.15] OCPBUGS-36418: go.*,vendor: bump go-retryablehttp

earlier branches seem to have more similar dependencies to this one, so I'm hoping the cherry pick won't conflict again 🤞🏼
/cherrypick release-4.14 release-4.13 release-4.12

/retitle [release-4.15] OCPBUGS-36036 go.*,vendor: bump go-retryablehttp

/retitle [release-4.15] OCPBUGS-36036: go.*,vendor: bump go-retryablehttp

/label backport-risk-assessed
/retest

/lgtm
/label backport-risk-assessed

/retest

/label qe-approved
/label cherry-pick-approved


[WIP] test - olm should resume operator install

OLM should install the operator for user defined Service Account for OperatorGroup after granting the proper permissions
https://bugzilla.redhat.com/show_bug.cgi?id=1740332

/test e2e-aws-console-olm

I don't think approach will work (well) since syncObject will constantly attempt reinstalling without any change in the cluster. Since install plans aren't reconciled constantly by design, I'm thinking the best way to proceed is to watch newly created roles and see if they apply to existing install plans (or perhaps check the status of failed install plans?)

/retest


Fixing json output html

Should fix this issue.

Summary:

JSON Output includes hasAttachment now
JSON output gives text/html and text/plain back

@soywod review pls

@soywod update

@soywod review pls


docs: update Snapshot section to provide details on how to use with concurrent test

docs: update Snapshot section to provide details on how to use with concurrent test
close #2729

@dammy001 can you review this PR, please?


Bumped version to v0.7.0 and removed a commented line

Description:

Minor update of CMakeLists.txt

One comment about this though is that master version of torchvision is now at 0.8.0

@fmassa correct. I think it would be better to find out a way to fetch the version from setup.py. What do you think ?

I think we are moving towards using CMake inside setup.py, so that might come naturally.


sap.ui.core.Element tooltip type documentation is partially wrong

OpenUI5 version: 1.32.10
sap.ui.core.Element  constructor has tooltip aggregation type as sap.ui.core.TooltipBase, but it should be  string|sap.ui.core.TooltipBase  to match getTooltip.

This looks like a missing piece in our JSDoc generator.
An alternative type is specified in the code, but won't be considered in the JSDoc result.
@codeworrior could you please have a look into this?

I think we omitted the altTpes by intention to keep the overview in the constructor more readable. Details can always be found in the accessor method documentation.
The next generation demokit most likely will use a totally different structure for the API Reference (less noise, better readable, similar to Explored App). We'll take care that the altTypes will appear there.
Last but not least, we're not able to simply change the docu generation for older releases as this (depending on the change) might cause too many changed files in the next patch. Otherwise, this would  cause trouble for SAPUI5 customers that import that release.
I'll see how many pages would be affected in 1.38 when we change this, but I most likely won't fix it for older releases.


fix(ContainerAuthenticator): add sa-token as default CR token filename

This commit adds support for a second default CR token filename. If the user doesn't specify a CR token filename, the authenticator will first try /var/run/secrets/tokens/vault-token, and then /var/run/secrets/tokens/sa-token in that order.

:tada: This PR is included in version 5.13.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Feature Request] Support Competition/Tournament Playlists

Matt — Today at 8:10 PM
I'm not sure if I've missed it in any documentation but I thought it would be a cool idea that once you have setup a competition on VPinStudio that it puts a value (either specific or custom value) in one of the custom fields as I would love to make a playlist of just my live competition tables running locally but there's no easy way to do this without manually everytime putting a custom value in the file.

This will become more relevant with the upcoming tournaments and iScored integration.

Fixed with 2.20.1


Asset register form on website

Form itself: https://beamx.explorer.beam.mw/assets/create
Need to check if it produces correct CLI.

Before it handled special symbols incorrectly (for example ") and the resulting command line did not worked.
Need to check if it works for linux & windows (different CLI rules, may be add switch)
Need to check if all fields from asset descriptor are supported. https://github.com/BeamMW/beam/wiki/Asset-Descriptor-v1.0
Need to check that only correct data is accepted (URL in url field)
Need to set some sane limit on some fields. For example not allow very long unit name & small unit name

1.The command line does not handle symbols such as  "  or  .
If such symbols are not accepted for creating an asset,then you need to display errors if the user enters them when creating the asset

Before it handled special symbols incorrectly (for example ") and the resulting command line did not worked.

2.Need to either define the system or make a switch so that the command is generated for the system that the user uses. In this case, the command will not work because Windows does not use ". / " when entering the command.

Need to check if it works for linux & windows (different CLI rules, may be add switch)

Every description should be in English. need to display errors.

NTH_RATIO= cannot be an infinite number when creating an asset

Need to set some sane limit on some fields. For example not allow very long unit name & small unit name

I also want to make a suggestion to add abbreviations in small font at the bottom to make it easier for users.

Also

Command line should be correct for Win & Linux & Mac (shadow special symbols like ", space: "blah\ blah). Rules of shadowing and allowed symbols can be different for Win & Linux. Should check.
N, SN, UN,  NTHUN  fields should allow only alphanumeric chars + space dot (.) comma (,) dash (-) and underscore (_)
OPT_SHORT_DESC <= 128 chars
OPT_LONG_DESC <= 1024 chars
Need to add all properties from https://github.com/BeamMW/beam/wiki/Asset-Descriptor-v1.0
OPT_COLOR should accept only valid hex color (#FFFFF0)
xxxx_URL fileds should be checked for valid urls


[WIP] Filter functions, extern vars, defines and unused types from included headers

Closes #13
Ignore functions, extern variables and defines from included headers.
Removed HeaderManager, added LocationManager that creates instances of Location for each TypeDef.
Location has 2 subclasses:

ScalaLocation means that type is defined in another scala object (not supported yet)
SourceLocation indicates that type is defined in main header or in included header

If type is defined in included header and it is not used then it is removed.
Now I think that ScalaLocation is a bad idea because it does not prevent creation of Struct, Union etc and TypeDef instances.
So it would be better to create an ImportedType instead of TypeDef with ScalaLocation.
TODO:

[ ] Add tests

Not ready for review


[Abide] Form error does not show when form element labels are siblings

How can we reproduce this bug?

Step one
Create a form like this:

<form data-abide>

  <input type="text"  required/>
  Error message

<input type="text"/>
</form>

What did you expect to happen?
Form error should show class should show (get the is-visible-class
What happened instead?
Does not show
Problem lies in
 findFormError($el) {
    var $error = $el.siblings(this.options.formErrorSelector);

    if (!$error.length) {
      $error = $el.parent().find(this.options.formErrorSelector); <--- Fallback which triggers on $el pointing to the last the input type="text"
    }
    return $error;
  }

add a novalidate attribute to the form element and it works fine for me

@designerno1 are you sure about this? We have the novalidate in our form (missed it in my example). As you can see in findFormError it will look in the parents if it doesnt find a sibling element, which incorrectly selects the "form-error" class attached to the other input

@jontro
you are right now i see the error, i try to debug

@jontro
ok only thing i see at the moment is to wrap the second input in an element like a label tag
<form data-abide novalidate>

  <input type="text" required />
  Error message

  <input type="text" />
  <button class="button" type="submit" value="Submit">Submit</button>
</form>

Yeah. That's why I reported the bug ;) The problem was finding out why it behaved this way, might be good to update the documentation in case this behaviour is intended / hard to fix

This issue just bit on a form where the submit was a simple <input type="submit"> that was not wrapped, while the rest of the inputs with required were wrapped by divs.   Codepen example with working and not working code
This might warrant it's own bug report since it doesn't make much sense for an input of type submit to impact abide except to trigger the validation.

We have found the same issue, when creating complex styled forms the validator works but it does not show the error messages;

Check if you qualify for funding…

Step 1 – enter your details:
				<input name="honey" type="text"  class="hide">

                                <select name="Title" >
                                    <option>Title*</option>
                                    <option>Mr</option>
                                    <option>Ms</option>
                                    <option>Miss</option>
                                    <option>Mrs</option>
                                    <option>Dr</option>
                                </select>

                                <input name="Surname" type="text" placeholder="Surname*" required pattern="text" />
                                 Surname Required

                                <input name="Name" type="text" placeholder="First name*" required pattern="text" />
                                 Name Required

                                <input name="Middle Name" type="text" placeholder="Middle name"  />
                                <input name="DOB" type="text" placeholder="Date of birth"  />
                                <input name="Telephone" type="text" placeholder="Phone number"  />

                                <input name="Address1" type="text" placeholder="Address line 1*" required pattern="text" />
                                 Address Required

                                <input name="Address2" type="text" placeholder="Address line 2*" required pattern="text" />
                                 Address Required

                                <input name="Address3" type="text" placeholder="Address line 3" />
                                <input name="Address4" type="text" placeholder="Address line 4" />

                                <input name="Postcode" type="text" placeholder="Postcode*" required />
                                  Postcode Required

Step 2 – read through the data protection statement:

				In order for UK Carbon Care Ltd to confirm whether you are entitled to ECO Affordable Warmth funded measures, we will share your personal data with our trusted third party service provider, the Energy Saving Trust, and with the Department for Work and Pensions. Your details will be used as follows to assess your eligibility for the service, we will:

					Get in touch with the Department for Work and Pensions via the Energy Saving Trust to check if you may be eligible for this assistance.

					Receive information from the Department for Work and Pensions about you,   this will be limited to information relating to your entitlement to assistance.

					Share your details with our service provider Energy Saving Trust so they can  check if you may be eligible for this assistance and provide services to us.

					Share your details with the scheme administrator, Ofgem, so they can review the scheme.

Please tick the following to agree to allow us to confirm your eligibility for the grant:

						<input name="Data Protection" type="checkbox" id="check1" required />

						I, the customer acknowledge that I have read and understood the Data Protection Statement at the top of this page

						<input name="Data Sharing" type="checkbox" id="check2" required />

						I hereby give my consent for the appropriate and necessary data being shared with the Energy Saving Trust and The Department for Work and Pensions.

						I hereby give my consent for the appropriate and necessary data being shared with the Energy Saving Trust and The Department for Work and Pensions.

<button type="submit" class="btn green-btn"  >Accept and continue</button>

		</form>

Hey @stevewinni-cc please use markdown like this below for next time
```javascript
function fancyAlert(arg) {
  if(arg) {
    $.facebox({div:'#foo'})
  }
}```

See

https://guides.github.com/features/mastering-markdown/
https://help.github.com/articles/creating-and-highlighting-code-blocks/

I have edited your comment for this time :)

I'm always using JS that force to show error message.

    <input type="text" class="input-group-field" id="my-input">

        <button class="button" type="submit"></button>

    Сообщение не должно быть короче 8 символов

/* ZURB Foundation Plugin ABIDE */
$(document).on('invalid.zf.abide', function (e) {
    $('.form-error[data-form-error-for="'+ e.target.id +'"]').addClass('is-visible');
});

$(document).on('valid.zf.abide', function (e) {
    $('.form-error[data-form-error-for="'+ e.target.id +'"]').removeClass('is-visible');
});

Update - After looking at this it appears that Abide wanted all of the Inputs surrounded by labels not just the ones which were being validated against. once all inputs were enclosed with labels the error messages showed correctly...

@mikeevstropov Thanks for your solution. Your code solved my problem. My "form-error" spans where never visible when used with "data-form-error-for" attribute.
Sample of my code :

        Z Pièce

            <input id="input_zpiece" name="input_zpiece" class="input-group-field" type="number" required pattern="positive_integer" data-validator="greater_than smaller_than" data-greater-than="0" data-smaller-than="10001">
            dents

               Il faut entrer un nombre entier (par ex. : 9) entre 1 et 10000

Update - After looking at this it appears that Abide wanted all of the Inputs surrounded by labels not just the ones which were being validated against. once all inputs were enclosed with labels the error messages showed correctly...

a11y wise they should be always have a label

If I understand this issue correctly, this is a duplicate of #7802. I replied to it in https://github.com/zurb/foundation-sites/issues/7802#issuecomment-361083271.

I looked further and I can confirm that this is not a bug. Foundation automatically detect form errors in the same parent than the <input>, but we cannot extends this behavior without creating conflicts between fields.
Globally, this is always a good thing to explicitely declare relations between elements. So the recommanded usage is to use data-form-error-for="inputId" to declare this relation without depending on the form error and field positions.
The following usage is recommended:

  $
  <input class="input-group-field" type="text" id="exampleInput" required>

Please enter amount.

The following work arounds are NOT recommended:

Changing the form error CSS
Changing the HTML template just to "get it works".
Using [data-abide-error] in the form error (or it will be displayed when any field in the form in invalid)

See: https://foundation.zurb.com/sites/docs/abide.html#form-errors

Closing as the other issue is also closed as resolved.


change access permission to default in general.

backport of #1576 for release-v1.1
What type of PR is this?
/kind bug

https://sonarcloud.io/project/issues?id=openyurtio_openyurt&pullRequest=1598&resolved=false&types=CODE_SMELL is unrelated to the fix.
@rambohe-ch friendly ping.


Is there a C++ port?

I want to use this toolkit with my C++ UWP project. Is there a way to use it with C++/CX or with C++/WinRT?
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e0e16194-ea45-a07e-02fb-13297f123b9a
Version Independent ID: 25435dd2-9458-5613-7af2-8e3767f3c599
Content: Windows Community Toolkit Documentation - Windows Community Toolkit
Content Source: docs/index.md
Product: community-toolkit
GitHub Login: @nmetulev
Microsoft Alias: nikolame

Hi @Arush-Agarampur,
There is some possibility for them to work, but not directly as I'm thinking you're asking about.  I have been able to in the past wrap them up in a page and then include that page in a C++ app, similar to how you'd composite an app with XAML Islands.
So, if you don't mind pulling in the dependency on the .NET runtime in order to use our C# controls it is technically possible to make use of them.  I believe there's some tooling issues still which make it harder to make it intuitive to setup, but I don't think I've tested in VS 2019 yet.
That said, I believe what I did was create a separate project C# Windows Runtime Component (I believe it was that over a Class Library, that'd make sense).  Then I included the toolkit controls via NuGet.  I created a new page/control in that library and composited the toolkit controls I wanted.  Then you should be able to then reference that in the C++ project and be able to plunk the custom page/control into your UI.  The missing build piece was that it wasn't copying the C# toolkit dlls over to the output of the C++ project, so I had to do that manually in order for the reference to work.
What we really should do is evaluate which controls we can split out into their own runtime component library, as then they should be directly consumable to C++ apps.  There's just a lot more restrictions on runtime components, but we should evaluate in the future.  Feel free to file an issue on our main repo to start that conversation there as a feature request.
If there's something specific control you use a lot or experience that's missing in the built-in controls, you can also file a request on the WinUI repo as all their stuff works in C++.
For now, I'll leave this issue open on the docs repo, as I should see if I can dig up my old test for this or create a new sample which at least shows how to make it work.
Hope that helps, Thanks!


works for all pics expect for one pic no matter how big it saved

just a simple test demo.
works for all pics expect for this one, with different sizes:

but the screenshot works?!

Please read the docs or consult forum before writing issue.


Carrier Board / PCB for Boron and OpenMV

Current status:

Thanks to hard work from @efarq , we now have a stable prototype some new bits of hardware (i.e., a MOSFET - thanks for the suggestion @SUPScientist !). The wiring, microcontrollers, and cell antenna fit in the polycase, and are mounted using 3D printed parts (thanks @jacobstasiewicz ).

In the future, it would simplify future builds if there was a manufactured PCB where the electronic parts were pre-populated on the board, and the microcontrollers could just plug into headers. to do this we would likely need:

A PCB design that accounts for the microcontroillers and the electronic components (see the circuit diagram)
new 3d printed parts that attach the PCB to the polycase

Hi everyone! I am Matthew Saenz. I am a master's student in Electrical and Computer Engineering at Carnegie Mellon University and an intern at the Field Research Facility in Duck, NC. Evan has brought me on to work on this task, as well as investigating the solar power supply.
I'd like to begin with listing high level system requirements I derived from my discussion of the project with @ebgoldstein this morning:

The PCB shall have mounting locations for all devices in the circuit diagram, i.e. the Boron board, the OpenMV board, the MOSFET, and the voltage divider resistor.
The PCB shall connect the devices as specified in the circuit diagram via circuit traces.
The PCB shall not displace the antenna mount location, but may modify the other mounting hardware as necessary.
The PCB shall include a mounting location for a screwhead terminal or similar to enable testing alternative power supplies.
The USB and SIM card ports of the Boron board shall be easily accessible in the fully assembled configuration.
The SD card port of the OpenMV board shall be easily accessible in the full assembled configuration.

Regarding the placement of the PCB, would it be better to mount it on top of the Boron and OpenMV, or below them? I am currently leaning towards below the boards, as it would enable a simpler form factor for the PCB reducing manufacturing costs, but in the baseplate assembly drawing, the header pins appear to be oriented upward from the boards.
Please let me know if you have any feedback on these design requirements, as well as if there are any other desired features of the PCB.

Great to meet you, Matthew, and welcome to the team :) In case @efarq doesn't have automatic notifications, I'm tagging her here explicitly as she has spent the most time of any of us with hands on the device. @efarq, maybe you could share your google slide deck with @mjsaenz as well as it has some helpful photos (while you're at it, could you add a couple of those to the assets folder here?
Responding to your system requirements below where there's anything to add. If I haven't added anything, then I agree!

The PCB shall have mounting locations for all devices in the circuit diagram, i.e. the Boron board, the OpenMV board, the MOSFET, and the voltage divider resistor. PJB response: we haven't been able to use the voltage divider for meaningful voltage monitoring. @efarq please confirm but I recommend removing unless we anticipate future usability. FET switch (with its resistor definitely stay.
The PCB shall connect the devices as specified in the circuit diagram via circuit traces.
The PCB shall not displace the antenna mount location, but may modify the other mounting hardware as necessary. PJB response: please see https://docs.particle.io/hardware/certification/antenna/#cellular-antenna-dimensions for antenna spec. @jacobstasiewicz please confirm that current antenna mount meets spec.
The PCB shall include a mounting location for a screwhead terminal or similar to enable testing alternative power supplies.
The USB and SIM card ports of the Boron board shall be easily accessible in the fully assembled configuration. PJB response: Boron uses a soldered on eSIM so access is not required.
The SD card port of the OpenMV board shall be easily accessible in the full assembled configuration.

Regarding the placement of the PCB, would it be better to mount it on top of the Boron and OpenMV, or below them? I am currently leaning towards below the boards, as it would enable a simpler form factor for the PCB reducing manufacturing costs, but in the baseplate assembly drawing, the header pins appear to be oriented upward from the boards.
PJB response: Boron has male header pins pointing downward (such that your carrier PCB should be underneath Boron with female headers/sockets). I thought this was also the case for OpenMV but a recent photo from @efarq shows the opposite, so we need her confirmation.
Other desired features. PJB response: the current connector that accepts the solar panel cable's plug and converts it to micro-USB (this: https://voltaicsystems.com/A101/) is a little clunky in my opinion, but it works. Would like @efarq's opinion here also (if it ain't broke, don't fix it?) but the power jack socket on this board (https://github.com/iorodeo/iorodeo_feather_tripler_enc1) that then runs the 5V trace to the Boron's VUSB input could also work. Researcher needs to remember to unplug solar before using USB cable from computer or vice versa.

Hi @mjsaenz , thx for the list.
@SUPScientist - this morning @mjsaenz and I had a call to discuss these issues, and he is connected to @efarq via email to get an actual device. Jacob is away for the week, but the antenna works so my opinion is that we not mess with the configuration.
the carrier board should attach from below. I can confirm via a phone call w/ @efarq that the OpenMV @mjsaenz will get has downward facing male headers.
Power:

I spoke to @mjsaenz about power, and trying to estimate power budget, which we have discussed in variou issues: #1, #9, #10, #43, and #45 .
I mentioned that the voltaic panel and battery we are sending over is regulated, and will not output meaningful numbers for power budget estimation.
I mentioned that Particle boards expose a way to monitor battery voltage from a LiPo via the C++ API (https://docs.particle.io/reference/device-os/api/fuelgauge/getvcell/), so we are interested in working with a new battery that could integrate with this ability.
I mentioned that we want to future proof this PCB by allowing for other battery and solar panel solutions to be connected, and monitored (so using ones that are not regulated). This might necessitate adding or retaining things on the PCB (voltage divider, screw terminals, etc).
the power management stuff is definitely a 'stretch goal', so my opinion is that we ask @mjsaenz to focus first on just building the basic PCB, and then if he has time tackle some of the power stuff.

how does this sound?

Nope, shouldn't mess with the antenna holder itself, agreed. The important spec to bear in mind for PCB design is this:

All portions of the antenna should maintain proper spacing from electronics, grounded metal, or active metal.
Recommended: 12mm
Minimum: 8mm

I didn't mean we should mess with antenna holder, just that we should maintain minimum distance between antenna and other electronics.
As for monitoring battery voltage, what we do on the water level sensors is (1) use the same Voltaic panel/battery as TinyCamML and (2) also use a small LiPo inside the polycase and the code:
// Get battery charge      float cellVoltage = batteryMonitor.getVCell();     float stateOfCharge = batteryMonitor.getSoC();

so there are two batteries - the voltaic one and then a smaller LiPo? is the idea that the small battery is just extra, and will better reflect the state of the charge for the both batteries?

Hi all,
I have indeed shared the TinyCamML google drive with Matthew, so let me
know if you don't receive it. Also, I realized the current configuration of
the OpenMV has the female headers facing down (opposite of what I told you,
Evan). However, this could be easily changed for all future TinyCamMLs, as
each OpenMV comes with male headers that can be soldered on instead of the
female ones.
I am going to mail you the TinyCamML tomorrow, Matthew, so I can get
together a few extra items to include. I just bought a fresh openMV as well
to ship to you, so that you can have the correct male header configuration
so you can move forward with a pcb design where the Boron and OpenMV just
"plug in". Do you have access to a soldering iron to solder on the male
headers when it arrives?
In response to some of the other inquiries above:

We haven't been using the voltage divider, so that can be excluded in
the initial PCB design, unless you find a way to incorporate it for voltage
monitoring later on. Sounds like there are other options though for voltage
monitoring, such as including a mini lipo battery inside the casing.
However my question about this is, would we still be able to use the VUSB
pin on the Boron if a battery is plugged in?
The microusb needs to be easily accessible on the OpenMV as well.

I think I like the idea of sticking with the
https://voltaicsystems.com/A101/ part for now until we figure out a
solution for decreasing solar panel size and/or maybe getting rid of the
external battery?
Best wishes,
Liz Farquhar
On Wed, Dec 18, 2024 at 9:24 AM Evan B. Goldstein @.***>
wrote:

so there are two batteries - the voltaic one and then a smaller LiPo? is
the idea that the small battery is just extra, and will better reflect the
state of the charge for the both batteries?
—
Reply to this email directly, view it on GitHub
https://github.com/TinyCamML/TinyCamML/issues/34#issuecomment-2551453569,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATFA7W62YSCMMX7BFDXAMDD2GGARXAVCNFSM6AAAAABMFBOLIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJRGQ2TGNJWHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

so there are two batteries - the voltaic one and then a smaller LiPo? is the idea that the small battery is just extra, and will better reflect the state of the charge for the both batteries?

Correct, @ebgoldstein. Voltaic panel/battery pack @ 5V is hooked up to VUSB on Boron and VIN on OpenMV, both of which can handle 5V. A smaller lipo @ 3.7V nominal is hooked up to Li+ on Boron. The Boron's PMIC draws from VUSB and charges the lipo if there's extra juice. See fig below; lipo stays fairly close to full charge for months.

However my question about this is, would we still be able to use the VUSB pin on the Boron if a battery is plugged in?

Yes, @efarq, also described above. The Boron's PMIC handles current flow. Something would likely break if we had two things plugged into Boron's VUSB, such as a computer connected via micro-USB cable + voltaic battery wired to VUSB via a trace on a new PCB.
This figure shows an almost yearlong time-series of two water level sensors that measure/report hourly. The first few weeks used an internal lipo as described above with a solar panel without an extra battery pack plugged into VUSB. Swapped out the battery packless solar panel in April for the identical Voltaic panel/pack we're using here. Battery V shown here is that of the internal small lipo.

Thank you all for the input! I apologize for the delay in replying here, I am getting caught up after driving home all day Wednesday. I have updated my design requirements for the PCB as follows (changes bolded):

The PCB shall have mounting locations for all devices in the circuit diagram, i.e. the Boron board, the OpenMV board, the MOSFET, and the voltage divider resistor.
The PCB shall connect the devices as specified in the circuit diagram via circuit traces.
The PCB shall not displace the antenna mount location in order to maintain the recommended distance from electronics of 12mm, but may modify the other mounting hardware as necessary.
The PCB shall include a mounting location for a screwhead terminal or similar to enable testing alternative power supplies.
The USB and SIM card port**s** of the Boron board shall be easily accessible in the fully assembled configuration.
The microUSB and SD card ports of the OpenMV board shall be easily accessible in the full assembled configuration.
7. The OpenMV board and Boron board shall be mounted above the PCB, i.e. "slot-in."

As for your question @efarq, I unfortunately will not have easy access to a soldering iron while at home,, but i will reach out to some friends in the area who may have their own.

Nicely done distilling this thread. Looks good to me!

Question for the MOSFET and its resistor, do we want to continue to use the through-hole components listed in the BoM, or would we want to change to surface mount components?

Additionally, would it be desired for the Boron and OpenMV boards to be directly soldered into the PCB, or mounted into female header pins on the board. Directly soldering would allow for the overall boardstack to be shorter by trimming the extra pin length, but would make substituting/replacing the boards more difficult.

My preferences are:

through-hole components for ease of soldering.
boards mounted via female headers for easy replacement. (As long as it fits in the enclosure)

Hi all,
I have begun digging into the schematic layout for the PCB and wanted to clarify the role of the mosfet in the circuit schematic, as its source is connected to the GND pin of the boron board and its drain the GND pin of the OpenMV. Does the switch provide a form of voltage regulation, and if so, should the GNDs of the two boards not be tied together?
I also wanted to note that for the alternative power supply (requirement 4), this will have to be a non-standard voltage, as the boron board only accepts an input voltage in the range of 3.6-4.2 VDC. This is within the input range of 3.6-5V of the OpenMV's Vin pin.

Hi, The mosFET switch is only used to turn on and off the power to the OpenMV, which was necessary because otherwise the OpenMV gets “out of sync” with the Boron. I’ll try to find the documentation that informed why I set up the mosfet that way. I believe the Boron also accepts ~5V voltage in its microusb port. Best wishes, Liz FarquharEl dic. 29, 2024, a la(s) 3:36 p.m., Matthew Saenz @.***> escribió:
Hi all,
I have begun digging into the schematic layout for the PCB and wanted to clarify the role of the mosfet in the circuit schematic, as its source is connected to the GND pin of the boron board and its drain the GND pin of the OpenMV. Does the switch provide a form of voltage regulation, and if so, should the GNDs of the two boards not be tied together?
I also wanted to note that for the alternative power supply (requirement 4), this will have to be a non-standard voltage, as the boron board only accepts an input voltage in the range of 3.6-4.2 VDC. This is within the input range of 3.6-5V of the OpenMV's Vin pin.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Thanks for the clarification on the mosFET @efarq ! Any documentation you have on it would be appreciated.
As for the second point, while the Boron does take in 5V via the microUSB port and outputs it at 5V on the VUSB pin, for its use, it is regulated down to 3.3V by a step-down regulator. The Li+ pin is the only pin which functions as a voltage in pin on the boron board, which accepts an input voltage in the aforementioned range of 3.6-4.2 VDC. I realized almost immediately after stepping away from the computer that we could also achieve this via a voltage divider, allowing the OpenMV board to receive its full 5V input, and the Boron board to receive an input voltage within its accepted range.
Here is the power documentation for the boron board: https://docs.particle.io/reference/datasheets/b-series/brn404x-datasheet/#power


Eloquent ->has() or ->whereRelation() do not respect soft deleted items

Laravel Version: ^10
PHP Version: 8.1
Database Driver & Version:

Description:
Documentation says (https://laravel.com/docs/10.x/eloquent-relationships#querying-relationship-existence):
When retrieving model records, you may wish to limit your results based on the existence of a relationship. For example, imagine you want to retrieve all blog posts that have at least one comment. To do so, you may pass the name of the relationship to the has and orHas methods
Unfortunately, if the relationship model uses SoftDeletes trait, we will anyway get trashed records.
Steps To Reproduce:

Let's look at the example from docs:
use App\Models\Post;

// Retrieve all posts that have at least one comment...
$posts = Post::has('comments')->get();

it always produces this query, independently if Comment is without SoftDeletes trait or with it:
select * from `posts`
where exists (select * from `comments` where `posts`.`comment_id` = `comments`.`id`)
and `posts`.`deleted_at` is null

though when Comment has SoftDeletes trait, we should have these items filtered out and the query should look like this:
select * from `posts`
where exists (select * from `comments` where `posts`.`comment_id` = `comments`.`id` and `comments`.`deleted_at` is null)
and `posts`.`deleted_at` is null

Similarly, whereRelation() does not respect SoftDeletes, either.
$posts = Post::whereRelation('comments', 'comments.author_id', '=', 5)->get();

will not narrow down the results to only not deleted comments.
A workaround is to explicitly filter by deleted_at field:
$posts = Post::whereRelation('comments', 'comments.deleted_at', '=', null)->get();

Heya thanks. This is the current expected behavior. We'd appreciate a PR to the docs to clarify this.

This is a huge surprise for me.
This should not be too hard to add an extra where clause.

All other places (relations) support soft deletes. It is very misleading and I cannot understand why this is the expected behavior?

@driesvints You could keep it opened and add "help-wanted" tag.

We'd appreciate a PR to the docs, thanks.

has(), whereRelation() etc. do respect soft-deleted items. This is the query from a fresh Laravel installation:
select *
from `posts`
where exists(
  select * from `comments` where `posts`.`id` = `comments`.`post_id` and `comments`.`deleted_at` is null
) and `posts`.`deleted_at` is null

@boryn This is an issue in your application. Did you customize your models and/or the query builder? Are you using any traits from third-party packages? Are you overriding any framework methods?

According to Dries;  This is the current expected behaviour.
Who is correct?  staudenmeir or Dries ? :thinking:

I indeed have some traits which could modify the query builder. Will check again after disabling them.

You need to add ->whereHas('comments') to your custom query


WIP Scala 2.13 Cross Build

Fixes #141

@SethTisue this is the output from compiling...
[error] unresolved dependency: org.tpolecat#doobie-h2_2.13.0-M5;0.6.0: not found
[error] unresolved dependency: org.tpolecat#doobie-scalatest_2.13.0-M5;0.6.0: not found
[error] unresolved dependency: org.tpolecat#doobie-hikari_2.13.0-M5;0.6.0: not found
[error] unresolved dependency: com.beachape#enumeratum-circe_2.13.0-M5;1.5.19: not found
[error] unresolved dependency: org.http4s#http4s-blaze-server_2.13.0-M5;0.20.0-M5: not found
[error] unresolved dependency: org.http4s#http4s-circe_2.13.0-M5;0.20.0-M5: not found
[error] unresolved dependency: org.http4s#http4s-dsl_2.13.0-M5;0.20.0-M5: not found
[error] unresolved dependency: io.github.jmcardon#tsec-common_2.13.0-M5;0.1.0-M2: not found
[error] unresolved dependency: io.github.jmcardon#tsec-password_2.13.0-M5;0.1.0-M2: not found
[error] unresolved dependency: io.github.jmcardon#tsec-mac_2.13.0-M5;0.1.0-M2: not found
[error] unresolved dependency: io.github.jmcardon#tsec-signatures_2.13.0-M5;0.1.0-M2: not found
[error] unresolved dependency: io.github.jmcardon#tsec-jwt-mac_2.13.0-M5;0.1.0-M2: not found
[error] unresolved dependency: io.github.jmcardon#tsec-jwt-sig_2.13.0-M5;0.1.0-M2: not found
[error] unresolved dependency: io.github.jmcardon#tsec-http4s_2.13.0-M5;0.1.0-M2: not found
[error] unresolved dependency: org.http4s#http4s-blaze-client_2.13.0-M5;0.20.0-M5: not found
[error] unresolved dependency: org.scalatest#scalatest_2.13.0-M5;3.0.5: not found

for ScalaTest, use 3.0.6-SNAP6, as per https://github.com/scala/make-release-notes/blob/2.13.x/projects-2.13.md
for doobie, 0.7.0-M2
for enumeratum-circe, I opened https://github.com/lloydmeta/enumeratum/issues/216
http4s and tsec already have open tickets for M5 support

travis.yml needs scala version added too: https://github.com/pauljamescleary/scala-pet-store/blob/master/.travis.yml#L4

I updated doobie and scalatest as well as travis.  Cut down on some of the failures, looks like http4s, enumeratum-circe, and tsec are the 3 left.

according to Lloyd at https://github.com/lloydmeta/enumeratum/issues/216#issuecomment-461436434, enumeratum-circe should resolve now

@SethTisue confirmed, it looks like enumeratum-circe resolves now...
[error] unresolved dependency: org.http4s#http4s-circe_2.13.0-M5;0.20.0-M5: not found
[error] unresolved dependency: org.http4s#http4s-dsl_2.13.0-M5;0.20.0-M5: not found
[error] unresolved dependency: io.github.jmcardon#tsec-common_2.13.0-M5;0.1.0-M2: not found
[error] unresolved dependency: io.github.jmcardon#tsec-password_2.13.0-M5;0.1.0-M2: not found
[error] unresolved dependency: io.github.jmcardon#tsec-mac_2.13.0-M5;0.1.0-M2: not found
[error] unresolved dependency: io.github.jmcardon#tsec-signatures_2.13.0-M5;0.1.0-M2: not found
[error] unresolved dependency: io.github.jmcardon#tsec-jwt-mac_2.13.0-M5;0.1.0-M2: not found
[error] unresolved dependency: io.github.jmcardon#tsec-jwt-sig_2.13.0-M5;0.1.0-M2: not found
[error] unresolved dependency: io.github.jmcardon#tsec-http4s_2.13.0-M5;0.1.0-M2: not found
[error] unresolved dependency: org.http4s#http4s-blaze-client_2.13.0-M5;0.20.0-M5: not found

Looks like this should be possible soon: https://twitter.com/http4s/status/1108728305098940418

http4s is released for 2.13, waiting on tsec crossbuild: https://github.com/jmcardon/tsec/pull/207

Lots of fixing needed to upgrade doobie to 0.7.0. I think I'll open a separate pull request to handle that.

This should pass CI, but I'm getting a couple strange deprecation errors in 2.13 coming from circe
[info] Compiling 32 Scala sources to /Users/zak/projects/oss/scala-pet-store/target/scala-2.13.0-M5/classes ...
[warn] /Users/zak/projects/oss/scala-pet-store/src/main/scala/io/github/pauljamescleary/petstore/infrastructure/endpoint/OrderEndpoints.scala:22:37: method right in class Either is deprecated (since 2.13.0): Either is now right-biased
[warn]   implicit val orderDecoder = jsonOf[F, Order]
[warn]                                     ^
[warn] /Users/zak/projects/oss/scala-pet-store/src/main/scala/io/github/pauljamescleary/petstore/infrastructure/endpoint/PetEndpoints.scala:30:58: method right in class Either is deprecated (since 2.13.0): Either is now right-biased
[warn]   implicit val petDecoder: EntityDecoder[F, Pet] = jsonOf[F, Pet]
[warn]                                                          ^
[warn] two warnings found
[info] Done compiling.
[success] Total time: 17 s, completed Apr 9, 2019, 3:12:38 PM

@pauljamescleary let me know if you can get a look at this.

@zakpatterson I am thinking we hold off on merging this until the official release?

We'll keep this branch going for a while until doobie stabilizes / goes to 0.7.0

@pauljamescleary Now that doobie 0.7.0 is out, I think we should merge this. We will of course still have issues moving from 2.13.0-M5 -> 2.13.0-RC2 and on to 2.13, but at present this all builds for 2.13.0-M5, and I think it'll be valuable to finalize this with 2.12 remaining the primary version, and then handle subsequent versions of 2.13 as needed in following PRs. Let me know if you agree.

@zakpatterson  👍

very exciting to see this land! a lot of 2.13 migration work is capstoned here. 👏

(btw, the delta between Scala 2.13.0-RC2 and RC3 is so small that even though RC3 is out, RC2 migration is still worth attempting. the M5->RC2 delta isn't enormous, but it's not insignificant, either.)


Don't have add variables in dashboard

Describe the bug
I have issue , when i want did add variables in dashboard .

Software versions
| Grafana | Zabbix | Grafana-Zabbix Plugin |
| ------- | ------ | --------------------- |
| 9.3.6  | 6.2.2  | 4.2.8                 |

me too
Software versions
| Grafana | Zabbix | Grafana-Zabbix Plugin |
| ------- | ------ | --------------------- |
| 8.5.21 | 6.4.0 | 4.3.0 |


Implement has_schema_privilege scalar function

Relates to https://github.com/crate/crate/issues/12457
Checklist

[ ] Added an entry in CHANGES.txt for user facing changes
[ ] Updated documentation & sql_features table for user facing changes
[ ] Touched code is covered by tests
[ ] CLA is signed
[ ] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

https://www.db-fiddle.com/f/5YRUUseBEQuLDfZf4GKtBc/5

Hi @seut, could you please take a look?
The main change besides scalar code itself is exposing Binder in ScalarFunctionModule so that scalars can access binder -> specific class provider and can later on request it.
A lot of files is just result of adding findByOid into UserLookup - it's not a func interface anymore and I had to create UserLookupStub and replace all shortcut usages.

I spot a bug, pushed a fixup https://github.com/crate/crate/pull/12553/commits/d86b5f7680c19a3cdf5bb98aedd2c49b50447c3d

unrelated test_schema_changes_of_subscribed_table_is_replicated_and_new_data_is_synced - cannot reproduce locally with the same seed
retest this please

retest this please


Uncaught (in promise) TypeError: Cannot read properties of null (reading 'isUnmounted')

Reproduction
https://github.com/ixiaoq/vue-router-bug.git
Steps to reproduce the bug
路由跳转后返回，反复几次可复现
Expected behavior
路由跳转后返回，反复几次可复现
Actual behavior
路由跳转后返回，反复几次可复现
Additional information
No response

As the warning in the console suggests:
vue-router.mjs:35

       [Vue Router warn]: Component "default" in record with path "/search" is a function that does not return a Promise. If you were passing a functional component, make sure to add a "displayName" to the component. This will break in production if not fixed.

Book.displayName = "Book"


[ISSUE-2688] LRULinkedHashMap does not work as an LRU Cache

Fixes the issue #2688
Describe the bug
LRULinkedHashMap.java.
LinkedHashMap is used incorrectly.
To make LinkedHashMap an LRU cache, a true boolean should be provided for the param accessOrder of the constructor.

How to merge the commits? @JackieTien97

How to merge the commits? @JackieTien97

Hi, we are working on the performance test of this PR in order to make sure the improvement before the commits merged. We'll share the result once we get it. Thanks!

Test result:
https://cwiki.apache.org/confluence/display/IOTDB/PR-2689+LRULinkedHashMap+does+not+work+as+an+LRU+Cache


Link that only updates the query (this.updateQuery)

Very often you want a link that only updates one or a few parts of the query or params, having to reconstruct and then mutate the current stuff is a pain (I'll type up some real-world use-cases later, I'm in a bit of a hurry right now).
Perhaps we can do a couple things to <Link/> make this awesome:
Optional to
I know, we had this once and @machty is awesome.
If you leave off to in a link, it will just use the current route.
add setQuery and setParams
These would work like setState in a component, namely, it merges the current data with new data.
add replace option
Would be false by default, if true the router will use replaceWith instead of transitionTo.
 Finally, you don't want an entry in the history.
<Link setQuery={{sortBy: 'firstName'}} replace={true}>First Name</Link>
<Link setQuery={{sortBy: 'lastName'}} replace={true}>Last Name</Link>

WHATCHOOTHINK?

Hi, friends! I'm feeling the pain right now of building a whole link just to set a query string. Has this ticket taken a back seat?

Welp, I don't really know what I'm doing, but here's a pull request!
https://github.com/rackt/react-router/pull/773
Feel free to tell me that I don't know what I'm doing! :camel: :fireworks: :leaves:

Earlier @mjackson said

setQuery and setParams do kind of make sense as helper methods for programmatically updating the URL, but that's what transitionTo and replaceWith are for.

I have the case where I'm using a <select> to switch between view states:
<Input type="select" value={this.props.query.groupBy} onChange={this.handleGroupBy}>
  <option value="category">View by Category</option>
  <option value="date">View by Date</option>
</Input>

and then in my handler I do:
handleGroupBy(ev) {
  // ...
  this.context.router.replaceWith(this.context.router.getCurrentPathname(),
    this.props.params, {groupBy: value});
}

It seems like a lot of code just to update the query as opposed to
this.context.router.setQuery({groupBy: value});

Changing the path or params seems to imply a transition, but updating the query quite often only affects the layout/state of the current page. I would, therefore, argue that the setQuery method does have merit. I gather that the <Link> element can solve this issue, but changing the query programmatically would also be handy.
If there is a better way to do the above which I'm missing please let me know!

The last suggestion is very welcome


[Tech Debt] Improving Test Quality

Configuring separate profile for tests
Improving exception handling
Improving assertions to ensure high test quality

Separate profiles for tests have been added
Exception handling has been covered
Proper assertions have been added in tests to ensure test quality


Task: Manage RLN membership(s) and keys

This is a bug report/feature or change request/support request
Summary
Ensuring that on all Waku clients publishers can manage RLN membership(s) and keys
Proposed Solutions
A JSON keyfile is used by nwaku to manage credentials. We need to provide a package, compatible with js-rln (or part of?) to enable import and export of this key file..
We need to also review how we want users to manage their RLN credentials in the browser.
Current proposal is to generate the RLN secret from a web3 wallet signature: sign a passphrase, hash it, use it as a secret.
This does not help the membership id, that needs to be retrieved from the smart contract.
We could provide tools to easily save credentials in local storage with a password.
We could also review the PSE work https://github.com/CryptKeeperZK and whether this can be used for RLN credentials.
Acceptance Criteria

[ ] Lib to easily to import/export key store file as implemented on nwaku https://github.com/waku-org/js-rln/issues/48
[ ] Lib to easily create and recover zk credentials using web3 wallet
[ ] Review if https://github.com/CryptKeeperZK can be used for RLN credentials

Notes

@rymnc Do you know if https://github.com/CryptKeeperZK can be used for RLN credentials?

Yes, you can use https://github.com/CryptKeeperZK/rlnjs

but it doesn't export the keystore the same way go-waku and nwaku do, so some effort would be required in that direction

@rymnc Do you know if https://github.com/CryptKeeperZK can be used for RLN credentials?

the original would be better - https://github.com/rate-limiting-nullifier/rlnjs

implement encrypted KeyStore (features: persistence, import / export, encryption);
implement FE interface by using prev point (features: simplicity, import / export, rpc or rest to nwaku);

(1) For implementing KeyStore worth looking into possibility of extending rlnjs library so that we offload following support. Important to keep in mind that encryption part should be consistent between waku clients. Possible mitigation - making it a configurable parameter or directly implementing in @waku/rln on our side.
(2) FE should use dotenv approach for easy integration in dockerenvironment. Docker spins nwaku then feeds multiaddr to node.

Weekly update:

achieved: completed flow up items and main stream of work;