Usability: NVDA is not announcing when "Breakpoint" is added to the code.

VS Code Version: 1.6.1
OS Version:1607
NVDA version:-2016.2.1
Steps to Reproduce:
Prerequisite: Node.js and git repository need to be installed.
1.Open Visual studio code editor.
2.open any file and using "Ctrl+1" key  navigate to the  first vs code editor.
3.Adding a "breakpoint" to the line of code By pressing  "F9" and observe the NVDA behavior.
Expected result:
NVDA should recite like "breakpoint added to the line of code n".
Actual Result:
NVDA is not reciting any information when any breakpoint is added to the line of code.
Note:-Inconsistent NVDA behavior is observed sometimes.
User Impact:
Screen Reader user doesn't get to know whether the Breakpoint is added or not as no announcement after "Breakpoint" has been applied.
Attachments:

Works for me
Same as my comment here https://github.com/Microsoft/vscode/issues/17249#issuecomment-268218869

@isidorn  The issue is fixed in vs code editor 1.8.1.


502 Bad Gateway

Hi, the codeball is failing on pipeline, also the website doesn't works
Thanks

Hi @PH7-Jack — I am sorry for this disruption of the service. The app should be back online now, let me know if it's not working.
I will get back with a more detailed update soon (I intend to open source the stack).
Thanks

Closing this now, as the api appears to work


[IMPROVE] Focus main window on second app instance event

Closes #1209

icon in taskbar when you clicked  not open the application immediately, you must re-render

@HieuHongLe94 Which operating system?

@ HiếuHongLe94 Hệ điều hành nào?

Win 10 version 1909 bro !


Auto update listings to include a newly added moderator

When the user selects another moderator to add in the settings, any of their existing listings don't have that new moderator included in the contract. What the user has to do is edit the contract in order for the new moderators to be added. The more contracts they have, the worse this UX problem is.
Ideally when new moderators are selected in Settings, all of the listings should auto updated to include them. This is really important as we've found that users are quick to add listings before they add moderators, which weakens the transaction security... what's worse is that the user doesn't intuitively know that they need to update their contracts to add moderators, and they shouldn't have to anyway.

Also applies to newly removed/blocked Moderators. If the Vendor finds that one of the Moderators is not responding or performing badly, and removes them, all of their listings need to be immediately updated... otherwise the Moderator will still be involved in transactions.


HTTPS server and Google Chrome

Does this actually work for anyone on any hardware platforms?
Running the latest azure rtos & netxduo on a NUCLEO-H753ZI here. UDP, TCP, SNTP, DNS, HTTP server all working fine.
Updating to 6.1.9 with the fixes in issues 48  and 50  gets past the chrome erroring with ERR_SSL_VERSION_OR_CIPHER_MISMATCH but the SSL library still bombs with NX_SECURE_TLS_NO_SUPPORTED_CIPHERS.

I'm sorry that you're having issues. Unfortunately, the error NX_SECURE_TLS_NO_SUPPORTED_CIPHERS means that Chrome isn't presenting any ciphersuites that are supported in your HTTPS server configuration.
According to the TLS RFCs (https://datatracker.ietf.org/doc/html/rfc5246 for TLS 1.2, https://datatracker.ietf.org/doc/html/rfc8446 for TLS 1.3) all TLS implementations MUST implement TLS_AES_128_GCM_SHA256 for TLS 1.3 and TLS_RSA_WITH_AES_128_CBC_SHA for TLS 1.2 (see "Mandatory Ciphersuite" sections). Azure RTOS TLS supports these ciphersuites by default.
However, we've seen different browsers (and Chrome in particular) refuse to send the mandatory ciphersuites in the TLS ClientHello. You can verify this is the case with Wireshark (or similar) and observe the TLS ciphersuites provided by the browser.
Due to the fact that Azure RTOS TLS is designed for microcontroller applications, it doesn't have a broad set of cryptographic algorithms so browsers that don't adhere to the RFCs will have issues when connecting to an Azure RTOS HTTPS server.
You have a few options:

Try to configure your browser to send compatible ciphersuites
Find a different browser that respects the RFCs (e.g. Firefox)
Attempt to implement your own cryptographic routines to support the browser and configuration you've chosen (see  https://docs.microsoft.com/en-us/azure/rtos/netx-duo/netx-secure-tls/chapter3#cryptography-in-netx-secure-tls).
Use a less-specialized TLS stack (e.g. OpenSSL) that supports a larger number of ciphers with the assumption that there will be a match with your browser.

Unfortunately, we can't control what browser manufacturers do with regard to ciphersuites and if they don't follow the RFCs there's no guarantee that the browser will be compatible with any particular TLS server.

Thanks for the quick update! Glad to know it's not just me going crazy. A little surprised this hasn't been raised before.
I have found Firefox has the same problem. Internet explorer works.
I think you should prioritise making this work becuase:

The world has moved on from IE, and even Microsoft is now pushing it's Chrome based browser
For this product to gain traction, it will need a HTTPS server that works with the most popular browsers in the world
Even for cloud deployments, https is a good way to recover or troubleshoot access to devices.

It's definitely been raised before but I'll raise it again (not up to me to decide). Our primary focus for Azure RTOS is on being a TLS/HTTPS Client (device-to-cloud) and it's difficult keeping the TLS server up to date with whatever decisions the browser distributors make about TLS support. Azure RTOS TLS isn't a web-focused stack like OpenSSL and many devices we target don't have the resources to have both a cloud connection and run an HTTPS server anyway so it's likely that browser compatibility will remain somewhat limited. That being said, I will try to push get some of the Chrome-favored ciphers added to hopefully close the gap a little.
I will point out that Edge and Chrome are both based on Chromium (open-source browser core functionality) - ciphersuite choice is made by the distributor (Microsoft or Google) and not something intrinsic to the browser core so there's no technical reason for Edge and Chrome to offer the same ciphers.

Hi,
I like to chime in here as we experienced this issue as well. We solved it by setting NX_SECURE_ENABLE_AEAD_CIPHER which resulted our NetXDuo server working with Chrome 93.
I do agree with @hmckinlay that a web server offering makes only sense if the typically used browsers can access it. Regardless whether Chrome follows RFC or not, they dominate at present the market.
If resources are the problem, then some of the outdated cybersuites could be removed or become optional. Also the uC market is moving to devices with larger memories like 1MB RAM and 2MB flash so these high end devices would be suitable to offer HTTPS.
From my observations encrypted networking will become more and more a standard requirement so HTTPS support will become mandatory.

Hi, I like to chime in here as we experienced this issue as well. We solved it by setting NX_SECURE_ENABLE_AEAD_CIPHER which resulted our NetXDuo server working with Chrome 93.
I do agree with @hmckinlay that a web server offering makes only sense if the typically used browsers can access it. Regardless whether Chrome follows RFC or not, they dominate at present the market.
If resources are the problem, then some of the outdated cybersuites could be removed or become optional. Also the uC market is moving to devices with larger memories like 1MB RAM and 2MB flash so these high end devices would be suitable to offer HTTPS.
From my observations encrypted networking will become more and more a standard requirement so HTTPS support will become mandatory.

Good to know. I have tried this and it does not work for me with the latest Chrome 96. Does it work for you with the latest Chrome?

What is the likelyhood that when the TLS 1.3 issues are resolved, Chrome will also work ?

Good to know. I have tried this and it does not work for me with the latest Chrome 96. Does it work for you with the latest Chrome?

Just tried again and I can confirm that latest Chrome 96.0.4664.110 is able to connect to the NetXDuo 6.1.9 nx_web_http_server component using these nx_user.h settings:
//
// NetX Secure.
//
// TLS 1.2 is enabled by default, TLS 1.0 and v1.1 are deprecated as are all SSL versions.
// #define NX_SECURE_TLS_ENABLE_TLS_1_3
// #define NX_SECURE_TLS_DISABLE_PROTOCOL_VERSION_DOWNGRADE
#define NX_SECURE_TLS_DISABLE_CLIENT_INITIATED_RENEGOTIATION
#define NX_SECURE_ALLOW_SELF_SIGNED_CERTIFICATES
// #define NX_SECURE_KEY_CLEAR // Slightly faster if diasabled by 1%
// #define NX_CRYPTO_ENABLE_UNALIGNED_ACCESS // Marginally faster by 0.3% but compilation error w/ FSP 3.4.0
#define NX_SECURE_ENABLE_AEAD_CIPHER // To enable connection with Chrome 93
// #define NX_SECURE_POWER_ON_SELF_TEST_MODULE_INTEGRITY_CHECK
#define NX_SECURE_TLS_CLIENT_DISABLED

I am using a self signed cert atm, so you will get NET::ERR_CERT_COMMON_NAME_INVALID but you can bypass this in Chrome by clicking on Advanced and then Proceed to <IP_ADDRESS> (unsafe). Once our product gets into production we will obtain a proper CA certificate.

I also tried using TLS 1.3 with these changed settings based on above settings:
#define NX_SECURE_TLS_ENABLE_TLS_1_3
#define NX_SECURE_TLS_DISABLE_PROTOCOL_VERSION_DOWNGRADE

and strangely I get this error ERR_TLS13_DOWNGRADE_DETECTED in Chrome. I have not investigated but surprised to see this despite setting NX_SECURE_TLS_DISABLE_PROTOCOL_VERSION_DOWNGRADE. I have the suspicion that NX_SECURE_TLS_DISABLE_PROTOCOL_VERSION_DOWNGRADE has not effect.

According to the TLS RFCs (https://datatracker.ietf.org/doc/html/rfc5246 for TLS 1.2, https://datatracker.ietf.org/doc/html/rfc8446 for TLS 1.3) all TLS implementations MUST implement TLS_AES_128_GCM_SHA256 for TLS 1.3 and TLS_RSA_WITH_AES_128_CBC_SHA for TLS 1.2 (see "Mandatory Ciphersuite" sections). Azure RTOS TLS supports these ciphersuites by default.

@tstapko Just reading your comment again. Chrome is in fact offering TLS_RSA_WITH_AES_128_CBC_SHA. But the _nx_crypto_ciphersuite_lookup_table does not contain TLS_RSA_WITH_AES_128_CBC_SHA. It contains TLS_RSA_WITH_AES_128_CBC_SHA256 instead. So it looks like it's the other way round and Azure RTOS is the one not compliant with the RFC5246 or am I overlooking something?

Ah, yes I forgot about that. You are correct - Microsoft security policy requires us to disable SHA-1 ciphersuites by default so we aren't technically compliant with the RFC for TLS 1.2 out of the box. You would have to create your own entry in the ciphersuite lookup table for TLS_RSA_WITH_AES_128_CBC_SHA

As for the TLS 1.3 downgrade error, I'm not sure exactly what the issue is you're seeing, but my guess is that Chrome isn't providing an ECC curve that Azure RTOS TLS supports and then it attempts to downgrade to TLS 1.2 because it can't connect with 1.3.

What is the likelyhood that when the TLS 1.3 issues are resolved, Chrome will also work ?

It's unlikely that fixing the TLS 1.3 issues would change anything unless you are using RSA certificates in your server - the issue there is that TLS 1.3 currently only supports ECC certs (a known issue we are aiming to fix in an upcoming release). If you have an ECC cert now and it doesn't work, that fix won't change the behavior.

Close as no response.

Does anyone know if there have been any updates on this in the last year? Thanks!

Does anyone know if there have been any updates on this in the last year? Thanks!

@hmckinlay I initially was quite interested to have Chrome working with HTTPS but since my last post here, I have not continued with NetxDuo as the MCU I wanted to use is not available for the foreseeable future, so development has been shelved.

@hmckinlay I tested it with Chrome and it is working when NX_SECURE_ENABLE_AEAD_CIPHER is defined. Can you take a look at the nx_crypto_tls_ciphers that is used for the nx_web_http_server_secure_configure function and check if TLS_RSA_WITH_AES_128_GCM_SHA256 is included in the _nx_crypto_ciphersuite_lookup_table?
I also tested it with TLS 1.3 and it works only when ECC certificates are used for the HTTPS server.

Just got back to this after a long break. Right now working on a STM32F7XX. The middleware is based on Azure® RTOS release 6.1.8. I don't think TLS_RSA_WITH_AES_128_GCM_SHA256 is included in the lookup table, how do I add this?
Thanks!

@hmckinlay I tested it with Chrome and it is working when NX_SECURE_ENABLE_AEAD_CIPHER is defined. Can you take a look at the nx_crypto_tls_ciphers that is used for the nx_web_http_server_secure_configure function and check if TLS_RSA_WITH_AES_128_GCM_SHA256 is included in the _nx_crypto_ciphersuite_lookup_table?
I also tested it with TLS 1.3 and it works only when ECC certificates are used for the HTTPS server.

Can we please re-open this case? This problem is preventing us from moving to this product =(

If you want to add the SHA1 cipher suite, you can add the following line in the lookup table:
 { TLS_RSA_WITH_AES_128_CBC_SHA, &crypto_method_rsa,  &crypto_method_rsa, &crypto_method_aes_cbc_128, 16, 16, &crypto_method_hmac_sha1, 20, &crypto_method_tls_prf_sha_256 },
For the connection reset problem, can you get the corresponding error code from NetX Secure?

The crypto method for the PRF is crypto_method_tls_prf_sha256, but the hash size for SHA1 should be 20.
   {TLS_RSA_WITH_AES_128_CBC_SHA,    &crypto_method_rsa,     &crypto_method_rsa,     &crypto_method_aes_cbc_128,     16,      16,        &crypto_method_hmac_sha1,       20,        &crypto_method_tls_prf_sha256},
If you are using nx_crypto_tls_ciphers, then add this line to _nx_crypto_ciphersuite_lookup_table. If you are using nx_crypto_tls_ciphers_ecc, you can add this line and the following to _nx_crypto_ciphersuite_lookup_table_ecc.
   {TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,    &crypto_method_ecdhe,     &crypto_method_ecdsa,     &crypto_method_aes_cbc_128,     16,      16,        &crypto_method_hmac_sha1,       20,        &crypto_method_tls_prf_sha256},     {TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,      &crypto_method_ecdhe,     &crypto_method_rsa,       &crypto_method_aes_cbc_128,     16,      16,        &crypto_method_hmac_sha1,       20,        &crypto_method_tls_prf_sha256},
If the 'not secure' appears, the cipher suite is accepted by Chrome. The problem looks like there are packet leaks somewhere. Could you please log the available pool count of the packet pools before or after each connection and see if it will drop to 0. For example printf("%lu, %lu", NxAppPool.nx_packet_pool_available, WebServerPool.nx_packet_pool_available)

Closing, no further response.

Is there any update on this? I have the same problem with Chrome.
I am also trying to use a self-signed certificate to set up an HTTPS server, but I am having trouble loading the private RSA key: the function nx_secure_x509_certificate_initialize always returns the error NX_SECURE_PKCS1_INVALID_PRIVATE_KEY. Has anyone had this problem? How do you generate the key and certificate?

I’m not connecting yet on my project, but I was able to get NX_SUCCESS from that specific function call.
For my project, I’m using Renesas Synergy Software Platform v2.6.0 and using their GUI configurator tool to configure NetX/ThreadX
I enabled “Allow Self Signed Certificates” and the code generator updated my nx_secure_user.h to include #define NX_SECURE_ALLOW_SELF_SIGNED_CERTIFICATES.
I read through these instructions and example to determine my initialization function call sequence:
https://github.com/eclipse-threadx/rtos-docs/blob/main/rtos-docs/netx-duo/netx-duo-web-http/chapter2.md
I used these instructions to generate everything:
https://devcenter.heroku.com/articles/ssl-certificate-self?ref=caffeinecoding.com
I followed these instructions to convert the cert and key to DER format:
https://wiki.segger.com/HOWTO_convert_PEM_certificates_and_keys_to_DER_format_for_emSSL
I’m still not connecting though, wireshark shows some failures in the TLS handshaking elsewhere but I haven’t finished debugging to see what my issue is, but I hope this is slightly helpful at least.
Alex Grutter
Engineer
Future Designs, Inc.
996 A Cleaner Way SW Huntsville, AL 35805
Mobile:<PHONE_NUMBER>
Phone:<PHONE_NUMBER> ext. 34
Fax:<PHONE_NUMBER>
From: Robert Buss Kaufmann @.>
Sent: Wednesday, July 17, 2024 8:30 AM
To: eclipse-threadx/netxduo @.>
Cc: Subscribed @.***>
Subject: Re: [eclipse-threadx/netxduo] HTTPS server and Google Chrome (Issue #67)
Is there any update on this? I have the same problem with Chrome.
I am also trying to use a self-signed certificate to set up an HTTPS server, but I am having trouble loading the private RSA key: the function nx_secure_x509_certificate_initialize always returns the error NX_SECURE_PKCS1_INVALID_PRIVATE_KEY. Has anyone had this problem? How do you generate the key and certificate?
—
Reply to this email directly, view it on GitHubhttps://github.com/eclipse-threadx/netxduo/issues/67#issuecomment-2233330730, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIBCG7MSYGU7KYHT3ECQ6ZTZMZWU5AVCNFSM6AAAAABLAUWHAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTGMZTANZTGA.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>

Hi, @agrutter
Thanks for the response.
Even generating the certificate and key with the provided instructions, I am still facing the same problem. Following the initialization function, the point where it fails is here, where tlv_type is 16 and not 2, like NX_SECURE_ASN_TAG_INTEGER:

Can you tell me the version of your OpenSSL?

I’m using the 1.1.1 that comes with the WSL Ubuntu.
I was able to work through my remaining issues yesterday, but as I already mentioned, I didn’t have your specific issue.
If the cert isn’t the issue, maybe you could find something by comparing Wireshark traffic coming in with what is available in the buffers at the point of failure?
Good luck!
Here is the specific command I used to create the cert that ultimately worked for me.
openssl req -x509 -nodes -days 365 -newkey rsa:2048 -keyout server.key -out server.crt -config config.cnf -extensions 'req_ext'
config.cnf:
[req]
distinguished_name = req_distinguished_name
req_extensions = req_ext
prompt = no
[req_distinguished_name]
C = US
ST = StateName
L = CityName
O = CompanyName
OU = DepartmentName
CN = www.commonname.comhttp://www.commonname.com
[req_ext]
subjectAltName = @alt_names
[alt_names]
DNS.1 = www.commonname.comhttp://www.commonname.com
Thanks,
Alex Grutter
Engineer
Future Designs, Inc.
996 A Cleaner Way SW Huntsville, AL 35805
Mobile:<PHONE_NUMBER>
Phone:<PHONE_NUMBER> ext. 34
Fax:<PHONE_NUMBER>
From: Robert Buss Kaufmann @.>
Sent: Wednesday, July 17, 2024 9:42 AM
To: eclipse-threadx/netxduo @.>
Cc: Alex Grutter @.>; Mention @.>
Subject: Re: [eclipse-threadx/netxduo] HTTPS server and Google Chrome (Issue #67)
Hi, @agrutterhttps://github.com/agrutter
Thanks for the response.
Even generating the certificate and key with the provided instructions, I am still facing the same problem. Following the initialization function, the point where it fails is here, where tlv_type is 16 and not 2, like NX_SECURE_ASN_TAG_INTEGER:
image.png (view on web)https://github.com/user-attachments/assets/d7322695-acfe-4ed6-b3a5-1173ca55a673
Can you tell me the version of your OpenSSL?
—
Reply to this email directly, view it on GitHubhttps://github.com/eclipse-threadx/netxduo/issues/67#issuecomment-2233495510, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIBCG7LP7AV3HQ4NF7UP6ZTZMZ7DDAVCNFSM6AAAAABLAUWHAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTGQ4TKNJRGA.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Thanks for the information. This information helped me find the source of the problem. I was using OpenSSL version 3.0, which generates the RSA key with a different and higher version than PKCS#1. I used the -traditional flag, including the conversion from PEM to DER, and it started working.
I'm just noticing a 5s delay in loading the http page with TLS, when compared to the connection without TLS. I'm investigating how to improve this.
Also, I'm trying to use an elliptic curve key, to use TLS 1.3.

I'm just noticing a 5s delay in loading the http page with TLS, when compared to the connection without TLS. I'm investigating how to improve this.

You would need hardware encryption to improve the connection speed. I am using a Renesas RA6M5 device and when using hardware encryption for TLS it takes about 148ms for the first page load which is reasonable. After that (assuming you keep connection alive) the next page loads within 2ms.

Just to be mentioned. There are two types of hardware accelerators which can improve TLS performance.

RSA accelerator which can improve TLS establishing time (as was illustrated by @hwmaier)
AES accelerator which improve overall data throughput for TLS

Not all MCU are equipped by RSA accelerator. But almost all modern MCUs have AES accelerator. If MCU is not equipped by RSA accelerator to improve software RSA is important this: enabled compiler optimisation; use highest CPU clock as possible; if MCU have data cache (like Cortex-M7) make sure that data cache is enabled by MPU unit at RAM which is used as stack for thread which used TLS.


Setup of Twilio service

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

The status of this has changed right @telmodias ?

Yes , for some reason I have difficulties to manage my issues on the project. I was checking yesterday and only had 3, but this was not present. I'll mark it done.


Update showcase.js

Added a link to android app of DockMan.

Hey @genki . Can you sign the CLA?

@satya164 I've tried to sign, but the form said "The 'Email' value has been registered on this form before."
Ain't I already signed?

That's weird. cc @mkonicek

@vjeux Something wrong with the bot?


fix: Updated Twitter Icon To X

Description
Removed Twitter's old bird Icon and added a New X icon In the Footer, Contributor Highlight card, and Contributor Profile info.
This PR fixes the bug #1681.
What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[x] 🎨 Style
[x] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents
Fixes #1681
Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

Nice job @lalitkumawat1m 👏 .
 Looks related to the change but needs some triaging.
run this and report back on thoughts
npm test

The changes look good but the CI checks need to be resolved.

Looks like some stuff is out of sync which is why some of the CI checks are failing.
npm ci can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.

Invalid: lock file's<EMAIL_ADDRESS>does not satisfy<EMAIL_ADDRESS>
@lalitkumawat1m you need to npm i because the lock file does not contain v4.11.0 but rather v4.7.1 of react icons

Perhaps we can cherry this pr on a new one. This is a nice to have, but perhaps the author got busy.
cc @open-sauced/engineering


Update nl.json

The current nl.json file is missing a comma, causing it to be an invalid JSON file.
This will cause an exception when you login to the admin and your language is set to Dutch.

Thanks! Published this patch in v3.0.6
Looks like we will need to extend the language unit tests to plugins.


Next release

Allow copypasting between Vizor tabs (Chrome only)
Update THREE.js to r74
Add smoothing input to FFT analyser
Internal: Fix connection referencing so that slots can be reordered
Remove broken presets
Fix editing link in embedded files
Fix file and user name display in embedded files
Fix issue with default/loading texture flashing for one frame
Show empty user page for user with no files (instead of opening editor)

please hold release till we resolve player stereo issues.


Fix w3c validation warning type style

Summary
Removes type="text/css" from the <style /> tag, as it causes the warnings

The type attribute for the style element is not needed and should be omitted.

in w3c validator, see https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.styled-components.com%2F for an example.
Motivated by https://spectrum.chat/?thread=085d48f2-47e2-43ac-8459-500722a0ba3f
Tests looked fine, snapshots changed as expected. I couldn't see any problems with SSR, jest-styled-components or babel-plugin-styled-components.
TBD
Does styled-components support html 4 environments? If so, this PR should be adjusted to add the type attribute only if in html5-"mode"

It used to be before html5. Now it’s just a legacy thing.
On Sat, Feb 24, 2018 at 10:57 AM Phil Plückthun<EMAIL_ADDRESS>wrote:

@kitten commented on this pull request.
This is fine overall but can you explain why it is recommended to leave it
out please? I’m not quite aware of the intricacies of having or not having
it, but previously I was under the impression that it’s a best practice to
specify the type 😅
In CHANGELOG.md
https://github.com/styled-components/styled-components/pull/1551#discussion_r170424737
:

@@ -2,414 +2,416 @@

All notable changes to this project will be documented in this file. If a contribution does not have a mention next to it, @geelen or @mxstbr did it.
-The format is based on Keep a Changelog and this project adheres to Semantic Versioning.
Can you remove your formatting from this file please? It’s be great to
preserve its previous history and format
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/pull/1551#pullrequestreview-99115982,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiy1rEAPQ8cPwNH--piN-AyRXbrD-Wvks5tYDFYgaJpZM4SR1wE
.

@kitten right, its not hurting to include the type attribute, but since HTML5 it default to text/css and w3c validation considers its declaration redundant.
Do we have to consider pre html5 environments?

I’m a little concerned about IE9, but if this  works for it that’d be awesome 😎

I tested the sandbox in IE8, which didn't seem to have any Problems 😃

Btw. I just checked https://emotion.sh/ out of curiosity. It doesn't seem to set type attributes either

Thank you so much for helping us improve styled-components! Based on our Community Guidelines every person that has a PR of any kind merged is offered an invitation to the styled-components organization—that is you right now!
Should you accept, you'll get write access to the main repository. (and a fancy styled-components logo on your GitHub profile!) You'll be able to label and close issues, merge pull requests, create new branches, etc. We want you to help us out with those things, so don't be scared to do them! Make sure to read our contribution and community guidelines, which explains all of this in more detail. Of course, if you have any questions just let me know!


Bulk change "http://..." to "https://..."

Following a recent comment by @DocOtak I checked the files in this repo for the obsoleted http:/ vs. the current practice https://:
$ grep "http://" ./*.{adoc,md} | wc -l
64
$ grep "https://" ./*.{adoc,md} | wc -l
43

Would it be possible to do a bulk update of to bring all links up-to-date to use https:// ?

Thanks Lars. I'm glad someone is suggesting this. I noticed a while back that we were usually referring to links with HTTP which, as per Andrew's comment, is indeed quite antiquated. I would support getting this updated (though as an infrastructure/admin change I doubt it needs the approval).
I can't see any reason we can't make the update like you suggest, since any updated link would always point to the same place but go there with a more secure and standard protocol.

Aha, well in that case I am happy to volunteer (I am in that team), though I've got quite a lot on at the moment so probably won't be able to do it until next week at the earliest. Does that work?

Thanks Sadie! (For the record: Despite your quick response, I wasn't at all specifically aiming at you in my previous post.) And personally I think that getting #445 into v1.11 is more important.

For the record: Despite your quick response, I wasn't at all specifically aiming at you in my previous post

No worries, Lars, it was clear you weren't but regardless I was and I am happy to volunteer because the change is non-controversial and should be quick to make via sed replacement so no won't take long. And the reference to HTTP has long stuck out to me. I assign myself here to show that I'll sort it (not immediately but soon enough, by next week).

I suggest that every changed link be checked for functionality, before committing.  Occasionally I still run into HTTP functioning websites.  Just my opinion, not a blocker.

Yes, I think this is a good idea. And I always wondered why we do not have a link checker kicking in with some regularity (weekly, 15 days, monthly, ...) to check also the conventions document, much as is now done for the CF website.

Hello - just a friendly reminder that this would have to be implemented by 12th November 2023 to make it into CF-1.11. Thanks!

The PR is now up for this: see #476. Thanks.

Excellent work Sadie!
I commented in the PR regarding the problematic links that you found.

After a few minor technical adjustments to the PR#467, I think these purely housekeeping changes ready to be merged. Thanks @Dave-Allured for pointing at the possibility of http links without a https counterpart.
Because the PR in no way influence the conventions as such I do not think that we have to wait the three weeks before accepting it. What do you think @davidhassell and @JonathanGregory?

Dear @sadielbartholomew and @larsbarring
Thanks for this very useful and careful piece of work.
Once we have completed this release, we ought to think a bit about the rules which should apply for accepting minor changes. However, my understanding is that "acceptance" refers to agreement about the principle and the wording of the change to be made. It does not refer to the PR. We don't have any rules about the timescales for PRs, because our rules were agreed before we moved to GitHub. The PR is "just" the implementation of an agreed change. No-one objected and enough people supported this change being made a month ago, when you first proposed it, so I think it already qualifies as "accepted" and it's fine to merge the PR now.
Cheers
Jonathan

Thanks @JonathanGregory. In which case, I will merge the PR now since both yourself and Lars are happy for me to do so and as you point out, we have no objections.

Once we have completed this release, we ought to think a bit about the rules which should apply for accepting minor changes.

In my opinion it would indeed be useful to do this. Though I would point out that a proposal, however major or minor, may be implemented in a way that is or isn't satisfactory, so ideally the new rules could include the role of review of the PR(s) corresponding to the approved Issue such that merging is then allowed. For example, if one assigned reviewer (who is suitably informed e.g. understands the background and code details) gives formal approval then it can be merged, or similar. Some projects like two, and sometimes each is given a different focus or one does a thorough review and the other just a simple sanity check after that.

I am closing this as completed via #476


fix cold start on reward ready topic pagination

oh I see this is a draft pr
well the work up until now looks ok :joy:

@xmariachi took over in https://github.com/allora-network/allora-chain/pull/212


Added vite.config.js

Provide a description of your code and a screenshot as  comments.

Used above code snippet to create my portfolio


ConcatenatingSampleProvider

I can't concatenate multiple pieces: the resulting sound contains only the signals that are different
var StartPulseLow = (new NAudio.Wave.SampleProviders.SignalGenerator() { Frequency = freq, Gain = 0.9, Type = NAudio.Wave.SampleProviders.SignalGeneratorType.Sin  }).Take(TimeSpan.FromMilliseconds(1700));
            var silence = new SilenceProvider(StartPulseLow.WaveFormat).ToSampleProvider().Take(TimeSpan.FromMilliseconds(800));
            var PulseLow0 = (new NAudio.Wave.SampleProviders.SignalGenerator() { Frequency = freq, Gain = 0.9, Type = NAudio.Wave.SampleProviders.SignalGeneratorType.Sin }).Take(TimeSpan.FromMilliseconds(200));
            var PulseLow1 = (new NAudio.Wave.SampleProviders.SignalGenerator() { Frequency = freq, Gain = 0.9, Type = NAudio.Wave.SampleProviders.SignalGeneratorType.Sin }).Take(TimeSpan.FromMilliseconds(700));
            var pezzi = new System.Collections.Generic.List<ISampleProvider>();
            pezzi.Add(StartPulseLow);      //<=THIS IS PLAYING
            pezzi.Add(silence);                //<=THIS IS PLAYING
            pezzi.Add(StartPulseLow);   //<=THIS IS NOT PLAYING
            pezzi.Add(silence);              //<=THIS IS NOT PLAYING
            pezzi.Add(StartPulseLow);  //<=THIS IS NOT PLAYING
              pezzi.Add(silence);            //<=THIS IS NOT PLAYING

 var playlist = new NAudio.Wave.SampleProviders.ConcatenatingSampleProvider(pezzi);
           using (var wo = new WaveOutEvent())
            {
                wo.Init(playlist.ToMono());
                wo.Play();
                while (wo.PlaybackState == PlaybackState.Playing) Thread.Sleep(500);
            }

I can hear only the first two samples
Is there a workadound?

You've created a silenceprovider that is 800ms long. Once it reaches the end, it will not play anymore. You need to create new silence providers for each period of silence.
The same with StartPulseLow. You've reached the end of it, so it won't play any more sound. You'd need to create another.
Alternatively, create your own ISampleProvider implementation that switches between silence and tone


[SPARK-25684][SQL] Organize header related codes in CSV datasource

What changes were proposed in this pull request?

Move CSVDataSource.makeSafeHeader to CSVUtils.makeSafeHeader (as is).
Rationale:

Historically and at the first place of refactoring (which I did), I intended to put all CSV specific handling (like options), filtering, extracting header, etc.
See JsonDataSource. Now CSVDataSource is quite consistent with JsonDataSource. Since CSV's code path is quite complicated, we might better match them as possible as we can.

Move CSVDataSource.checkHeaderColumnNames to CSVHeaderChecker.checkHeaderColumnNames (as is).
Rationale:

Similar reasons above with 1.

Put enforceSchema logics into CSVHeaderChecker.
Rationale:

The checking header and column pruning stuff were added (per https://github.com/apache/spark/pull/20894 and https://github.com/apache/spark/pull/21296) but some of codes such as https://github.com/apache/spark/pull/21296 are duplicated
Also, checking header code is basically here and there. We better put them in a single place, which is quite error-prone. See (https://github.com/apache/spark/pull/22656).

How was this patch tested?
Existing tests should cover this.

cc @cloud-fan and @MaxGekk

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3814/
Test PASSed.

Test build #97147 has started for PR 22676 at commit 5690668.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3816/
Test PASSed.

Test build #97149 has started for PR 22676 at commit 89f7911.

Test build #97149 has finished for PR 22676 at commit 89f7911.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97149/
Test FAILed.

Test build #97147 has finished for PR 22676 at commit 5690668.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class CSVHeaderChecker(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3825/
Test PASSed.

Test build #97162 has started for PR 22676 at commit c504356.

Test build #97162 has finished for PR 22676 at commit c504356.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97162/
Test PASSed.

retest this please

Test build #97235 has finished for PR 22676 at commit c504356.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97235/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3874/
Test PASSed.

Test build #97240 has started for PR 22676 at commit c504356.

Test build #97240 has finished for PR 22676 at commit c504356.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97240/
Test PASSed.

Merged to master.

Thank you @cloud-fan and @MaxGekk for reviewing this.


Assertion error node->parent == this

Hi @yindaz ,
I encountered following error when running the scn2scn binary. Do you have an idea what is going on? Thank you!
GAPS FATAL ERROR.  ABORTING:: No such file or directory
Assertion error node->parent == this at line 368 in file R3SceneNode.cpp
Aborted (core dumped)

The error message means that GAPS cannot find some files as input. Please check scn2scn.cpp for the required input by scn2scn.


Randomly will not resume from stop cleanly

Describe the bug
There are two issues I've experienced. Both while OP is engaged.
Issue 1 (more severe one, but no logs yet. Will provide logs when issue happens again.):

Come to a complete stop with lead vehicle
Lead vehicle departs
Observe FrogPilot press gas slightly, then slam on brakes
From this point, FrogPilot will not resume and you must completely disengage FrogPilot by pressing the brake. At this point the car will move again. If you press the accelerator without pressing the brake first, the car will stay still but the engine will rev.

Issue 2 (logs provided):

Come to a complete stop with lead vehicle
Lead vehicle departs
Observe FrogPilot press gas slightly, then brake to a stop (didn't feel like a slam)
From this point, FrogPilot will not resume and you must press the accelerator to resume movement

Provide a route where the issue occurs
20e394a46517a2ad/2024-03-20--09-38-45/12
openpilot version
f1b6bf66bae8ba8a4bbb3114b6b679f0b14aa091
Additional info
Branch: mazda-frogpilot-dev
Device: Comma 3

I'll try to look at this on the weekend. I have had something this happen to me but it didn't slam on the brakes and I just override the gas because I thought it was just the model being dumb.

These issues have been happening to me over the past few months, and I believe on the non-FrogPilot branches. I just unfortunately haven't had the time to report until now.
I also mistyped on the descriptions of the issues (now corrected), only Issue 1 causes brake slamming. I will try to get logs soonish, assuming it happens again.


how to use pretrained model for text classification

Really appreciate your efforts.
I am not getting how to use  pretrained model  for text classification.

Hey @008karan, you can refer this notebook
The link above from fastai covers how you can fine tune this language model and use it for text classification.
You can also refer the Fast AI Course Video Lesson 4 here: (link to timestamped video)

Hey @NirantK, I have gone through the notebook.
Things which I understood:

They are using wikitext103 LM for transfer learning. So I can use the pre-trained models provided by you in place of that.
As there  5 pre-trained models, I am not getting which one to use.
Is configuration of models is same as provided in notebook em_sz,nh,nl = 400,1150,3.
I need to replace source language model with the one provided by you and follow all the steps given in the notebook.
correct me if I am wrong?
Again thanks for the great work!

With respect to 3, The notebook is on how to create the language models.
Not on how to use them.
With respect to 2, yes, the parameters are as per what worked.
With respect to 1, use what works Karan.
On Tue 9 Oct, 2018, 01:55 Karan Purohit<EMAIL_ADDRESS>wrote:

Hey @NirantK https://github.com/NirantK, I have gone through the
notebook.
Things which I understood:

They are using wikitext103 LM for transfer learning. So I can use
the pre-trained models provided by you in place of that.
As there 5 pre-trained models, I am not getting which one to use.
Is configuration of models is same as provided in notebook em_sz,nh,nl
= 400,1150,3.
I need to replace source language model with the one provided by
you and follow all the steps given in the notebook.
correct me if I am wrong?
Again thanks for the great work!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NirantK/hindi2vec/issues/6#issuecomment-427991835,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADGaPbheCAoQ6LLipWOhqhcStSVkoqBnks5ui8m_gaJpZM4W_5Rq
.

In the original notebook by fastai.
Or, you could wait - I'll add the examples for text classification based on
FastAI version1.0 in a few days.
On Tue 9 Oct, 2018, 11:27 Karan Purohit<EMAIL_ADDRESS>wrote:

So where can I find how to use that language model?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NirantK/hindi2vec/issues/6#issuecomment-428088849,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADGaPSAFpSM7DFx_jcG8VRx3y5UQVDwGks5ujE_fgaJpZM4W_5Rq
.

have you added any example?

Not yet. I'm still working on a different project.
You can pickup from the FastAI course Lesson 4.
On Mon 22 Oct, 2018, 22:05 Karan Purohit<EMAIL_ADDRESS>wrote:

have you added any example?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NirantK/hindi2vec/issues/6#issuecomment-431889803,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADGaPTypv_TWaQAKGRNKBpl2LlioZixKks5unfPhgaJpZM4W_5Rq
.

I went through the lesson 4 notebook.
I got to know that vocab file (TEXT.pkl) and encoder (adam_enc) is required to do any classification task.
But there is embedding being used in between but not getting which one. They are just defining dimentions.
Also how to use hindi2vec embedding for classification


Support Redux 3.0.0

The tests still pass, so this could be merged.
~If you are interested, I will port the travis configuration over from redux_thunk.~ Just noticed it's already here. :)

OK, the tests only passed locally.. now checking.

Any progress? Pub version still not compatible with redux 3


Documentation is replaced by auto-generated RBI comments.

brew doctor output
N/A

Verification

[X] My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update twice and am still able to reproduce my issue.
[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output
N/A

What were you trying to do (and why)?
Documentation for e.g. RuboCops only shows auto-generated comments from RBI files:
From https://rubydoc.brew.sh/RuboCop/Cop/Homebrew/Blank.html:

DO NOT EDIT MANUALLY This is an autogenerated file for dynamic methods in RuboCop::Cop::Homebrew::Blank. Please instead update this file by running bin/tapioca dsl RuboCop::Cop::Homebrew::Blank.

What happened (include all command output)?
I assume the reason is that yard-sorbet is run last. It should be changed to skip any comments in RBI files.
What did you expect to happen?
Original documentation should be shown.
Step-by-step reproduction instructions (by running brew commands)
1. `brew rubydoc --open`
1. Look at `RuboCop::Cop::Homebrew::Blank` documentation.

I opened a PR upstream: https://github.com/Shopify/tapioca/pull/1885 🤞

Thanks for issues @reitermarkus and @dduugg!

We can also patch Tapioca if upstream doesn't accept the patch (early feedback isn't positive) 🙈. Something like: https://github.com/Homebrew/brew/compare/tapioca-patch?expand=1

We can also patch Tapioca if upstream doesn't accept the patch (early feedback isn't positive) 🙈. Something like: tapioca-patch?expand=1 (compare)

@dduugg This would work fine for me, monkey-patching like this is IMO fairly inconsequential when we're not exposing it to end-users.

@dduugg, fine by me. We can always revert it once it is fixed upstream.

Upstream PR was accepted, this will be fixed in the next tapioca release


⚠ PrivateHD has degraded performance

In 550575c, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2240 ms

Resolved: PrivateHD performance has improved in 13dc1f5.


[1.10.2]bow stuff(crossbow/longbow/shortbow) Only get EXP when u melee with them

is that intended or bugged?

#19

Fixed in newest version


Update 2.nuxt-config.md

Add the missing comma after defaultProvider: undefined
Closes # .
Checklist:

[ ] issue number linked above after pound (#)

replace "Closes " with "Contributes to" or other if this PR does not close the issue

[ ] manually checked my feature / checking not applicable
[ ] wrote tests / testing not applicable
[ ] attached screenshots / screenshot not applicable

Thanks @rannien ❤


Set-SPOUnifiedGroup - No synopsis, description and example given

This cmdLet lacks

a correct synopsis
description
parameter descriptions
an example

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 62578c9d-40f1-3979-76fa-54cc0405f86b
Version Independent ID: d1f2ce2c-8e0b-0cad-4c40-e796bab74e2d
Content: Set-SPOUnifiedGroup (sharepoint-online)
Content Source: sharepoint/sharepoint-ps/sharepoint-online/Set-SPOUnifiedGroup.md
Service: sharepoint-powershell
GitHub Login: @trent-green
Microsoft Alias: trgreen

@officedocsbot assign @yogkumgit

@tseward  Thank you very much for the contribution and updating the documentation with PR. @andikrueger Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Unit testing

Add unit test using jest to the generateCard() function to make sure the movie cards are being properly added to the home page with the input data

@danielamoreno699 you can review and approve if it all seems correct


[sw] Bazel: Move default --output_base to within OpenTitan Repo

Bazel by default is putting in $HOME/.cache.  For some users the $HOME directory has fairly restrictive quotas.  (For instance our job-queuing system rejects all jobs launched in the $HOME filesystem).  The --output_base option to bazel can be used to fix this, and select something like $OT_ROOT/bazel-build, which I see is already in the .gitignore file.
We can in principle request users to put this in their individual .bazelrc files, but because our user environments aim to maintain some isolation between project-specific environment configurations (and some of us are frequently switching configs), this is somewhat clumsy.
Could we perhaps make --output_base point to somewhere inside $OT_ROOT as part of the the project .bazelrc file?

IIUC, the suggestion is to move Bazel output directories to a subdirectory of the checkout path. Off the top of my head, I have a couple questions:

Do any CI runners currently benefit from persistent Bazel build directories? If they delete and re-clone the repo, they would now be throwing away build directories and increasing build times. (I suspect they start from scratch, so this is a non-issue.)
Some folks use git worktrees locally. Will this increase their build times too much? (This is probably mitigated by the remote cache.)

Backing up to address some technical points:

Did you perhaps mean $REPO_TOP instead of $OT_ROOT? I only see a few references to $OT_ROOT in sw/vendor/patches/riscv_compliance/. I'm also struggling to find $OT_ROOT/bazel-build in a .gitignore file :)
We probably would want to set --output_user_root rather than --output_base. In the Bazel docs example (https://bazel.build/remote/output-directories), the output base is /home/user/.cache/bazel/_bazel_$USER/7ffd56a6e4cb724ea575aba15733d113, whereas the output user root is the prefix /home/user/.cache/bazel/_bazel_$USER.

Hi Dan,
Thanks for your comments!  My bad about $REPO_TOP vs. $OT_ROOT (we have a local convention of using $XYZ_ROOT ) for each project.)
Right now it looks like the easiest way to handle this may be to adopt @a-will's suggestion in #14768 of just having a secondary bazelrc file (e.g. something like .bazelrc-site) that does not go into git, but allows each site to add their own policies for this.


Support bundle type = 'collection'

Synthetic data from synthea are produced as collections. Posting the data to hapi-fhir-cli results in the error:
WARN  c.u.f.r.s.i.ExceptionHandlingInterceptor - Failure during REST processing: ca.uhn.fhir.rest.server.exceptions.InvalidRequestException: Unable to process transaction where incoming Bundle.type = collection

Check https://github.com/synthetichealth/uploader

https://github.com/synthetichealth/uploader was not updated for 2 years. It's missing support for some models from FHIR v3.0.1 that synthea uses. As a result it frequently fails to post the bundle with null pointer exception. You need to either update the  models in the vendor directory and rebuild the uploader or just use https://hub.docker.com/r/conceptant/synthea-fhir/ where it's already done.


Align helm charts with those from starboard-app

Checklist

[x] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml and values.schema.json are valid.

This at least gets trivy-operator deployed in MCs and WCs. We still need to get to 0.1.0 before doing a release, but this gets us closer


Docs small change

Added missing param for adding helm repo
Pulled out section on accessing the console and referenced this in both helm and github cases

LGTM


transactions tab should display number of confirmations and not YES/NO for confirmations

We should also test that this updates on reorgs correctly.

Committed changes to master on 2020/03/26 commit 9598a05a801bf8a99e0aacf3fd0d30c4d05f7169


feat: add support for norg

It will capture the headings (up to level 6):

I am done.

Looking at both the examples looks like headings that are captured can be very long.
Are you sure having such long heading names and stuff show up in statusline would be helpful? 🤔

Indeed, I am following VSCode.
But the font size in VSCode is smaller.

If you think that it is a bad idea to display such a long string, just ignore the two PR.

Thanks.

Users can always disable on per language basis if they don't want it.

You are right.


falcon.request.Request.get_header returning unicode

I have very unusual architecture, so I will describe it first.
I have 2 applications: one is Falcon 1.0.0 and second is Django. All on python2.7
I need to test Falcon and Django together. So I'm using wsgi_intecept with requests.
So, I'm reating request.Session() which is leading thru wsgi_intecept to falcon. First request is creating me cookies. This works fine. But the second request is raising an error.
After some debbuging I found this:
class Request(object):
    @property
    def cookies(self):
        if self._cookies is None:
            parser = SimpleCookie(self.get_header('Cookie'))
            cookies = {}
            for morsel in parser.values():
                cookies[morsel.key] = morsel.value

            self._cookies = cookies

        return self._cookies.copy()

The error is in here:
parser = SimpleCookie(self.get_header('Cookie'))

self.get_header is returning unicode, but should return str. Why? Because of Cookie.SimpleCookie(Cookie.BaseCookie)
class BaseCookie(dict):
    def load(self, rawdata):
        if type(rawdata) == type(""):
            self.__ParseString(rawdata)
        else:
            for k, v in rawdata.items():
                self[k] = v
        return

The problem is whit this line:
if type(rawdata) == type(""):

Which change the flow for unicode strings.
My question is: should get_header force to return str? Or it should be fixed somewhere else? Or I just made some error in the configuration of my tests?

Problem was not in the Falcon, but in the wsgi_intercept. Sorry for this.
https://github.com/cdent/wsgi-intercept/issues/39


Request queue error handling

@aaustin @qinweigong
Adding some handling to the queue to handle request retrieve/persist failures.

:+1:


Why can't my remarkable2 be upgraded?

Via the CLI
reMarkable: ~/ systemctl start update-engine
Failed to start update-engine.service: Unit update-engine.service is masked.
How to solve the above problems？
Thank you.

This is my device interface.


UI issue in macOS - Red notifications on a red icon

My Setup

Operating System: macOS Big Sur 11.1

App Version: 3.1.1

Installation type: dmg from https://github.com/RocketChat/Rocket.Chat.Electron/releases/tag/3.1.1

[x ] I have tested with the latest version

[x ] I can simulate the issue easily

Description
Since the changes in the Dock icon, notifications are easy to ignore as they are a red over red.

Expected Behavior
The Dock icon should not be the same or very similar colour shade as system notification icons.

I totally support this request. Red on red is awful .

I totally support this request. Red on red is awful .

Seconded. However, #1941 should mitigate the issue as the icon should be shrunk down to proper scale (like how notification badges show up on iOS)

Seconded. However, #1941 should mitigate the issue as the icon should be shrunk down to proper scale (like how notification badges show up on iOS)

Second this too. I also don't think, resizing the icon migitates this issue enough. If the dock is small enough (necessity on small screens or with many applications in it), the badge will still not be visible, which is quite a problem with a chat application.

For me it's appearing as in the image below:

Closing it since it appears to be fixed here: https://github.com/RocketChat/Rocket.Chat.Electron/pull/1941. If you have any problems related, please reopen it.


running dcnv2 problems

init() got an unexpected keyword argument 'with_dcn'

Please follow the Error report issue template.


Envoy random segmentation fault

Envoy random segmentation fault
Description:
Envoy crashes randomly with a segmentation fault. It happens when we have two Kubernetes services, one head (with cluster IP) and another headless (without cluster IP) pointing to the same set of pods.
We have not observed any pattern, it can crash once or seven times during a period of 24h. It doesn't seem related with load or network activity
We use envoy with Istio 1.2.2 and Kubernetes 1.11.7
Title: Envoy random segmentation fault
Description:
Envoy shouldn't crash. It seems related to the fact we use two services, one head and one headless for the same statefulset
Repro steps:
Create two services, one headless and one head for the same Kubernetes Statefulset
Logs
[2020-02-24 09:23:30.689][36][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #5: Envoy::Event::DispatcherImpl::run() [0x90e60d]
[2020-02-24 09:23:30.697][36][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #7: Envoy::Thread::ThreadImplPosix::ThreadImplPosix()::$_0::__invoke() [0xe3ba55]
[2020-02-24 09:23:30.659][36][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:69] Backtrace (use tools/stack_decode.py to get line numbers):
[2020-02-24 09:23:30.678][36][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #2: Envoy::Event::FileEventImpl::assignEvents()::$_0::__invoke() [0x90f825]
[2020-02-24 09:23:30.659][36][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:81] Caught Segmentation fault, suspect faulting address 0x40
[2020-02-24 09:23:30.686][36][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #4: event_base_loop [0xcb9e30]
[2020-02-24 09:23:30.660][36][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #0: __restore_rt [0x7f8a262e9390]
[2020-02-24 09:23:30.674][36][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #1: Envoy::Network::ConnectionImpl::onFileEvent() [0x914972]
[2020-02-24 09:23:30.682][36][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #3: event_process_active_single_queue [0xcbb87d]
[2020-02-24 09:23:30.693][36][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #6: Envoy::Server::WorkerImpl::threadRoutine() [0x908d42]
[2020-02-24 09:23:30.697][36][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #8: start_thread [0x7f8a262df6ba]
2020-02-24T09:23:30.781544Z	warn	Epoch 0 terminated with an error: signal: segmentation fault

[2020-02-22 01:31:23.390][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #7: Envoy::Network::ConnectionImpl::~ConnectionImpl() [0x912923]
[2020-02-22 01:31:23.363][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #0: __restore_rt [0x7fae07465390]
[2020-02-22 01:31:23.371][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #2: bssl::SSL_CONFIG::~SSL_CONFIG() [0xb411a7]
[2020-02-22 01:31:23.374][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #3: ssl_st::~ssl_st() [0xb40957]
[2020-02-22 01:31:23.378][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #4: SSL_free [0xb412d3]
[2020-02-22 01:31:23.362][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:81] Caught Segmentation fault, suspect faulting address 0x8
[2020-02-22 01:31:23.362][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:69] Backtrace (use tools/stack_decode.py to get line numbers):
[2020-02-22 01:31:23.367][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #1: bssl::CERT::~CERT() [0xb549af]
[2020-02-22 01:31:23.396][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #8: Envoy::Network::ConnectionImpl::~ConnectionImpl() [0x912aed]
[2020-02-22 01:31:23.382][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #5: Envoy::Extensions::TransportSockets::Tls::SslSocket::~SslSocket() [0x56ba47]
[2020-02-22 01:31:23.386][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #6: Envoy::Extensions::TransportSockets::Tls::SslSocket::~SslSocket() [0x56bade]
[2020-02-22 01:31:23.401][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #9: Envoy::Server::ConnectionHandlerImpl::ActiveConnection::~ActiveConnection() [0x90b565]
[2020-02-22 01:31:23.407][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #10: Envoy::Server::ConnectionHandlerImpl::ActiveConnection::~ActiveConnection() [0x90b5be]
[2020-02-22 01:31:23.416][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #12: event_process_active_single_queue [0xcbb349]
[2020-02-22 01:31:23.412][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #11: Envoy::Event::DispatcherImpl::clearDeferredDeleteList() [0x90ddb7]
[2020-02-22 01:31:23.424][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #14: Envoy::Event::DispatcherImpl::run() [0x90e60d]
2020-02-22T01:31:23.500070Z	warn	Aborted all epochs
[2020-02-22 01:31:23.428][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #15: Envoy::Server::WorkerImpl::threadRoutine() [0x908d42]
[2020-02-22 01:31:23.420][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #13: event_base_loop [0xcb9e30]
[2020-02-22 01:31:23.432][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #16: Envoy::Thread::ThreadImplPosix::ThreadImplPosix()::$_0::__invoke() [0xe3ba55]
2020-02-22T01:31:23.500103Z	info	Epoch 0: set retry delay to 200ms, budget to 9
[2020-02-22 01:31:23.432][28][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #17: start_thread [0x7fae0745b6ba]
2020-02-22T01:31:23.700195Z	info	Reconciling retry (budget 9)
[2020-02-22 01:31:23.723][29668][warning][config] [bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:86] gRPC config stream closed: 14, no healthy upstream
2020-02-22T01:31:23.500046Z	warn	Epoch 0 terminated with an error: signal: segmentation fault

Also opened an issue with Istio: https://github.com/istio/istio/issues/20940

cc. @lizan

Istio 1.2.2 and Kubernetes 1.11.7 are quite old. Istio just released 1.4.5 and Kubernetes is 1.17. The Istio 1.2.x train went all the way to 1.2.10 and likely includes an old version of Envoy. Can you upgrade your components?

We plan to upgrade soon, but we would like to fix it before that.

Sorry Istio 1.2.x is EOL'd https://istio.io/news/support/announcing-1.2-eol/ and it is based on pretty old version of Envoy (even not a stable one) that we don't have bandwidth to provide support either.


License issue

Noticed some stuff missing from the license. Just an FYI.
https://github.com/channelcat/sanic/blob/master/LICENSE#L3

Speaking of Licensing, has it been considered to switch to Creative-Commons Zero (CC0) license?
It serves all of the same use cases and preserves the intents of MIT but has significantly superior internationalization support.


fix the typo in CarbonDioxideSensorService

Pull Request Checklist
Please confirm that you've done the following when opening a new pull request:

[ x] For fixes and other improvements, please reference the GitHub issue that your change addresses.
[ x] For fixes, optimizations and new features, please add an entry to the CHANGES.md file.
[ x] Run mvn compile before committing, so that the auto-code formatter will format your changes consistently with the rest of the project.

look good for me
@ccutrer could you please review and merge


Rephrasing required & other errors

These are phrasing errors of which i'm not entirely sure of how to fix them

"To prove soundness and completeness requires is not easy" -  (Relating natural deduction and semantics)
"We will write use the following notation"   -  (Operational semantics)

Other errors you might want to double check:
In the answers of 3.12 the reorganized proof should have the initial program p1;(p2;p3)
Near the end of Case study: gcd
gcd(x,y) = gcd(x - y, x)
should be:
gcd(x,y) = gcd(x - y, y)

Thanks Daniel -- I'll fix these and push the changes.
Wouter

From: Daniel van Vliet<EMAIL_ADDRESS>Sent: Friday, 29 January 2021 11:44
To: wouter-swierstra/logic-notes
Cc: Subscribed
Subject: [wouter-swierstra/logic-notes] Rephrasing required & other errors (#6)
These are phrasing errors of which i'm not entirely sure of how to fix them

"To prove soundness and completeness requires is not easy" - (Relating natural deduction and semantics)
"We will write use the following notation" - (Operational semantics)

Other errors you might want to double check:
In the answers of 3.12 the reorganized proof should have the initial program p1;(p2;p3)
Near the end of Case study: gcd
gcd(x,y) = gcd(x - y, x)
should be:
gcd(x,y) = gcd(x - y, y)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/wouter-swierstra/logic-notes/issues/6, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAMDYFLL3PJCY4CTBJLSYH3S4KGRPANCNFSM4WYUVKMQ.


Setting nginx configuration "client_max_body_size" results in error

I have to increase the "client_max_body_size" of nginx, so i added a "nginx-http.conf" to my root dir with one line:
client_max_body_size 200m;
But this prevents nginx from starting, with the following message:
"nginx: [emerg] "client_max_body_size" directive is duplicate in /etc/nginx/conf.d/nginx-http.conf:1
The configuration is already set at https://github.com/GoogleCloudPlatform/php-docker/blob/37e17678d8438e2ff9b9e30dd918937ef36c2232/php-base/nginx.conf#L35
Maybe this directive could be moved to the default "nginx-http.conf" to make it overwritable.

I'm ok moving it to the default "nginx-http.conf". @chingor13 WDYT? In the meantime, you can have the whole nginx.conf.

It's possible it might break users that are already providing their own nginx-http.conf file without that entry?

The default value for client_max_body_size is 1m, so yeah it will break. One option is to add client_max_body_size 32m; to user-provided nginx-http.conf if it doesn't have it.


[Bug]: Custom version fields cannot be compared

What happened?

Versions are recognized as numbers, multiple point suffixes cannot be entered, and comparisons are not valid.
To Reproduce
No
Expected behavior
No response
Additional context
docker deploy..
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for reporting this, I'll take a look.

The operator "bigger equal than" is a numeric operator. Since "1.3.4" is not a legal number, we thought they'd never match. FeatBit not support semantic version comparison for now, this feature is still on our TODO list.
"大于等于" 操作符是一个数字类型的操作符。由于 "1.3.4" 不是一个合法的数字，我们会认为匹配条件是不可能满足的。我们现在还不支持语义化版本的大小比较，这个功能还在我们的 TODO 列表中。


RGB camera error when connect the azure kinect through usb-c cable only

Describe the bug
The k4a viewer receive errors (camera time out error)the azure kinect device when only use a usb-c cable to connect to the computer. The kinect didn't have any problem when visualize depth data only. The problem will occur when trying to visualize RGB data.
To Reproduce

Connect the usb-c cable
Azure kinect no amber light, only white light
Open k4a viewer
the k4a viewer  can found the device with serial number displayed
when press open device -> (no problem)
press start button (-> problem occured)

Expected behavior
I can receive all kinect frame including depthm, rgb, etc.
Logs

with depth + RGB *

[ info     ] : k4a_device_start_cameras(). Starting camera's with the following config.
[ info     ] : k4a_device_start_cameras().     color_format:3
[ info     ] : k4a_device_start_cameras().     color_resolution:1
[ info     ] : k4a_device_start_cameras().     depth_mode:2
[ info     ] : k4a_device_start_cameras().     camera_fps:2
[ info     ] : k4a_device_start_cameras().     synchronized_images_only:1
[ info     ] : k4a_device_start_cameras().     depth_delay_off_color_usec:0
[ info     ] : k4a_device_start_cameras().     wired_sync_mode:0
[ info     ] : k4a_device_start_cameras().     subordinate_delay_off_master_usec:0
[ info     ] : k4a_device_start_cameras().     disable_streaming_indicator:0
[ warning  ] : capturesync_add_capture(). Dropping depth capture as TS is too large TS:   8951066
[ warning  ] : capturesync_add_capture(). Dropping depth capture as TS is too large TS:   8984400
[ warning  ] : capturesync_add_capture(). Dropping depth capture as TS is too large TS:   9017733
[ warning  ] : capturesync_add_capture(). Dropping depth capture as TS is too large TS:   9051066
[ warning  ] : depth_engine_thread(). Dropping depth image due to bad timestamp at startup
[ info     ] : k4a_device_start_cameras(). k4a_device_start_cameras started
[ info     ] : k4a_device_start_imu(). k4a_device_start_imu started
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:     17733 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:     51066 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:     84400 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    117733 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    151066 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    184400 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    217733 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    251066 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    284400 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    317733 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    351066 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    384400 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    417733 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    451066 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    484400 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    517733 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    551066 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    584400 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    617733 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    651066 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    684400 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    717733 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    751066 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    784400 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    817733 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    851066 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    884400 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    917733 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    951066 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:    984400 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:   1017733 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:   1051066 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:   1084400 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:   1117733 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:   1151066 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:   1184400 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:   1217733 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:   1251066 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:   1284400 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:   1317733 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:   1351066 type:Depth
[ error    ] : replace_sample(). capturesync_drop, releasing capture early due to full queue TS:   1384400 type:Depth
[ info     ] : k4a_device_stop_cameras(). k4a_device_stop_cameras stopping
[ warning  ] : queue_disable(). Waiting for blocking call to complete
[ warning  ] : queue_error(). Error detected, shutting down queue and notifying consumers
[ warning  ] : queue_error(). Error detected, shutting down queue and notifying consumers
[ warning  ] : queue_error(). Error detected, shutting down queue and notifying consumers
[ warning  ] : capturesync_add_capture(). Capture Error Detected, Depth
[ info     ] : k4a_device_stop_cameras(). k4a_device_stop_cameras stopped
[ info     ] : k4a_device_stop_imu(). k4a_device_stop_imu stopping

with RGB only *

[ info     ] : k4a_device_start_cameras(). Starting camera's with the following config.
[ info     ] : k4a_device_start_cameras().     color_format:3
[ info     ] : k4a_device_start_cameras().     color_resolution:1
[ info     ] : k4a_device_start_cameras().     depth_mode:0
[ info     ] : k4a_device_start_cameras().     camera_fps:2
[ info     ] : k4a_device_start_cameras().     synchronized_images_only:0
[ info     ] : k4a_device_start_cameras().     depth_delay_off_color_usec:0
[ info     ] : k4a_device_start_cameras().     wired_sync_mode:0
[ info     ] : k4a_device_start_cameras().     subordinate_delay_off_master_usec:0
[ info     ] : k4a_device_start_cameras().     disable_streaming_indicator:0
[ info     ] : k4a_device_start_cameras(). k4a_device_start_cameras started
[ info     ] : k4a_device_stop_cameras(). k4a_device_stop_cameras stopping
[ info     ] : k4a_device_stop_cameras(). k4a_device_stop_cameras stopped

with depth only *

[ info     ] : k4a_device_start_cameras(). Starting camera's with the following config.
[ info     ] : k4a_device_start_cameras().     color_format:3
[ info     ] : k4a_device_start_cameras().     color_resolution:0
[ info     ] : k4a_device_start_cameras().     depth_mode:2
[ info     ] : k4a_device_start_cameras().     camera_fps:2
[ info     ] : k4a_device_start_cameras().     synchronized_images_only:0
[ info     ] : k4a_device_start_cameras().     depth_delay_off_color_usec:0
[ info     ] : k4a_device_start_cameras().     wired_sync_mode:0
[ info     ] : k4a_device_start_cameras().     subordinate_delay_off_master_usec:0
[ info     ] : k4a_device_start_cameras().     disable_streaming_indicator:0
[ info     ] : k4a_device_start_cameras(). k4a_device_start_cameras started

Screenshots

Error message*

Depth Only

RGB only

Desktop (please complete the following information):

OS with Version: Ubuntu 18.04.3
SDK Version:  1.2.0
Firmware version:   Firmware version for RGB is 1.6.102. Firmware version for Depth is 1.6.75.

Additional context

I don't think this is a USB C issue. If you plug in the extra power supply can you still reproduce the issue?
I don't see an error in the log that would explain why you aren't getting color images. Are you seeing debug output going to the console window you launched K4aViewer from? If so that is LibUvc debug output and that would be useful to see as well.

Yes, when I plug in the usbc cable with the extra power supply, I can still reproduce the issue.
The strange behavior is that I can use the usbc cable to start all of the sensor including depth camera, IMU and microphone except RGB camera .
I am using the K4aViewer's log to output the log message. I set the Severity level to Info.
What shout I do to output another useful debug message?

I solve the problem.
When I plug the azure kinect to the USB-c port at the computer's back panel. Everything is normal. I can obtain all of the sensor data without any problem.
Maybe the USB port on the front panel is not compatible with Kinect. Btw, I am using Zotac En72070V.

The front panel's usb ports on Zotac En72070V is using ASMedia Technology Inc chip.
only the back panel usb ports is using Intel usb3.1 chip

Great info, thanks for sharing!


[Distance] Report preview does not display receipt image after creating a distance request

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log into NewDot as a workspace member
Global Create > Distance
Enter any address for start and finish
Submit the request to the workspace expense chat

Expected Result:

The policy expense plate displays with a report preview for the expense
The report preview uses a placeholder receipt image while offline
When going online, the report preview updates with the receipt image dynamically

Actual Result:
The report preview displays with no receipt image for the distance request and it does not update until the report is opened
https://github.com/Expensify/App/assets/6833644/b7a2ec58-e03c-4acd-88fd-5243430c03c9
Workaround:
Opening the report will load the receipt image
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
View all open jobs on GitHub

Came from this slack discussion.

per this Slack convo, I gonna change the priority of the issue from LOW to HIGH

I'll take over BZ on this from @puneetlath

👋 So I think we just need to pay @0xmiroslav $500 for the internal PR review, correct?

Cool, popped it on weekly and made a note in the title.

@0xmiroslav done here yet?

Okay, sounds good!


Vulnerability roundup 63: binutils-2.30: 1 advisory

search, files

[ ] CVE-2018-14038 (nixos-18.09)

Scanned versions: nixos-18.09: 37694c8cc0e. May contain false positives.

I wonder that binutils-2.30 is still in 18.09. Should have been updated IIRC. Could someone please verify?
See also #49784 and #49324

I confirm that yes, binutils-2.30 is still in the 18.09 channel:
nixos-version
18.09.2474.222950952f1 (Jellyfish)

An with a lot of CVEs:
vulnix --system
...
------------------------------------------------------------------------
binutils-2.30

CVEs:
	CVE-2018-10372
	CVE-2018-10373
	CVE-2018-10534
	CVE-2018-10535
	CVE-2018-12641
	CVE-2018-12697
	CVE-2018-12698
	CVE-2018-12699
	CVE-2018-12700
	CVE-2018-12934
	CVE-2018-13033
	CVE-2018-6543
	CVE-2018-6759
	CVE-2018-6872
...

Closing as 18.09 is no longer supported. (also, the reject mention redirects to https://nvd.nist.gov/vuln/detail/CVE-2018-7642 ; it was just a duplicate assignment)


Merge PR when checks are ready

There is an issue that you can not enable auto-merge when a PR is ready to merge.
For this situation, I have added a try/catch block where it evaluates if the error contains the message Pull request is in clean status. If so, it will use the mergePullRequest mutation to merge the PR directly.
This fixes #12

/merge


g++: error: unrecognized command line option ‘-faligned-new’

Hi
I am try to run simple system hello test.
when i use below command to build the simulation
"fusesoc --cores-root=. run --target=sim --setup --build lowrisc:ibex:ibex_simple_system --RV32M=1 --RV32E=0"
But i got the error message, my g++ version is 4.8.
Any suggestion will be welcome.
 I don't think that Verilator lists a required GCC version, but Verilator 4.028 is very recent and GCC 4.8 is ancient (released in 2013!). I think you just need to install a more recent GCC.
Note that, even if you're on an old system, you can often install newer GCC versions to somewhere nonstandard (/opt, for example). Then you just need to prepend that directory to your path or alternatively set the CC and CXX environment variables to tell Verilator which compiler to use.

GCC 4.8 should work fine with Verilator, as long as you disable C++11 when configuring Verilator at build time.
If I remember correctly, Verilator only adds -faligned-new to its flags if it was deemed safe so at configure time. So please double-check the way you compile/install Verilator, and file a bug at https://github.com/verilator/verilator to get more help otherwise. There's unfortunately nothing we can do here on the Ibex side.


Docs - Update spelling & reference in release notes for UserViewSet

Just a small spelling item + cross-reference to the docs.

Thanks


[custom response filter] Prevent overriding the status code with 100

Commit Message:
Additional Description:
Risk Level: Low
Testing: ran //test/... and built docs
Docs Changes: N/A
Release Notes: Added release note

/retest


Use ACMEDNS issuer for host certificates (non-wildcard)

Is your feature request related to a problem? Please describe.
I want to use cert-manager with ACMEDNS challenge to generate host certificates. Currently, the domain name is not correctly detected from dnsNames except for a wildcard certificate.
ie:

dnsName leaf.domain.com => domain leaf.domain.com
dnsName *.domain.com => domain domain.com

Describe the solution you'd like
The correct way, IMHO, should be to have domain.com as the domain for both dnsNames.
Describe alternatives you've considered
For now, I'm using only wildcard certificates with this challenge/issuer type.
Additional context
Add any other context about the feature request here.
Environment details (if applicable):

Kubernetes version (e.g. v1.10.2): v1.14.6
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): openstack version Train
cert-manager version (e.g. v0.4.0): 0.13.0
Install method (e.g. helm or static manifests): static manifest

/kind feature

I'm not sure what the issue you are describing here is, or what the feature request is.

Currently, the domain name is not correctly detected from dnsNames except for a wildcard certificate.

What do you mean?
ie:

dnsName leaf.domain.com => domain leaf.domain.com
dnsName *.domain.com => domain domain.com

This is correct behaviour as far as I can see from your description - if you request leaf.domain.com, we should validate leaf.domain.com etc :)

The correct way, IMHO, should be to have domain.com as the domain for both dnsNames.

Not sure what you mean here either - if you request a certificate for leaf.domain.com, you'll get a certificate for leaf.domain.com 🤔

Maybe that was not clear enough. I indeed want to generate a certificate leaf.domain.com. But I want to use the DNS-01 challenge type. So I have to set a _acme-challenge.domain.com txt entry in the domain domain.com.
For the moment, cert-manager tries to update the _acme-challenge.leaf.domain.com entry instead of _acme-challenge.domain.com.
It's working fine if I want a wildcard certificate such as *.domain.com.
It'll be more clear with the logs, I guess:
I0218 15:34:53.584391       1 dns.go:106] cert-manager/controller/challenges/Present "msg"="presenting DNS01 challenge for domain" "dnsName"="leaf.domain.com" "domain"="leaf.domain.com" "resource_kind"="Challenge" "resource_name"="leaf-domain-com-3465074992-2466411541-3333565223" "resource_namespace"="default" "type"="dns-01"
I0218 15:34:53.625418       1 controller.go:129] cert-manager/controller/orders "msg"="syncing item" "key"="default/leaf-domain-com-3465074992-2466411541"
I0218 15:34:53.625801       1 logger.go:100] Calling DNS01ChallengeRecord
I0218 15:34:53.625977       1 sync.go:179] cert-manager/controller/orders "msg"="No action taken" "resource_kind"="Order" "resource_name"="leaf-domain-com-3465074992-2466411541" "resource_namespace"="default"
I0218 15:34:53.626027       1 controller.go:135] cert-manager/controller/orders "msg"="finished processing work item" "key"="default/leaf-domain-com-3465074992-2466411541"
E0218 15:34:53.626798       1 controller.go:131] cert-manager/controller/challenges "msg"="re-queuing item  due to error processing" "error"="account credentials not found for domain leaf.domain.com" "key"="default/leaf-domain-com-3465074992-2466411541-3333565223"

Look at "msg"="presenting DNS01 challenge for domain" "dnsName"="leaf.domain.com" "domain"="leaf.domain.com": the domain is the same as the dnsName. It doesn't seem correct, IMHO.
Then "error"="account credentials not found for domain leaf.domain.com" which is correct since I don't have a leaf.domain.com domain, just domain.com.
Now with a wildcard entry:
I0218 14:47:36.483427       1 dns.go:106] cert-manager/controller/challenges/Present "msg"="presenting DNS01 challenge for domain" "dnsName"="domain.com" "domain"="domain.com" "resource_kind"="Challenge" "resource_name"="wildcard-domain-com-1601273398-2797371380-786616965" "resource_namespace"="default" "type"="dns-01"
I0218 14:47:36.682124       1 dns.go:121] cert-manager/controller/challenges/Check "msg"="checking DNS propagation" "dnsName"="domain.com" "domain"="domain.com" "resource_kind"="Challenge" "resource_name"="wildcard-domain-com-1601273398-2797371380-786616965" "resource_namespace"="default" "type"="dns-01" "nameservers"=["<IP_ADDRESS>:53"]
I0218 14:47:36.721909       1 wait.go:73] Updating FQDN: _acme-challenge.domain.com. with its CNAME: 07bd4fc7-4f0e-41c8-a94b-11fb20056c68.acme.domain.com.
I0218 14:47:36.780878       1 dns.go:133] cert-manager/controller/challenges/Check "msg"="waiting DNS record TTL to allow the DNS01 record to propagate for domain" "dnsName"="domain.com" "domain"="domain.com" "resource_kind"="Challenge" "resource_name"="wildcard-domain-com-1601273398-2797371380-786616965" "resource_namespace"="default" "type"="dns-01" "fqdn"="_acme-challenge.domain.com." "ttl"=60

The challenge is correctly set as _acme-challenge.domain.com.

Do I need to elaborate further?

Look at "msg"="presenting DNS01 challenge for domain" "dnsName"="leaf.domain.com" "domain"="leaf.domain.com": the domain is the same as the dnsName. It doesn't seem correct, IMHO.

This is correct. The ACME spec says we must perform a validation against the DNS name, not the zone 😄

Then "error"="account credentials not found for domain leaf.domain.com" which is correct since I don't have a leaf.domain.com domain, just domain.com.

Have you delegated leaf.domain.com to another zone/provider then? cert-manager will recurse up the DNS hierarchy from leaf.domain.com to domain.com in order to find the 'root' of the zone that needs to be updated in your DNS provider, which is in this case domain.com (the leaf record needs setting in this zone).

OK, let's make a step-by-step example to generate a certificate for leaf.domain.com manually.

get the challenge from let's encrypt: ChAllenge1
put it in my DNS system: _acme-challenge.domain.com. TXT "ChAllenge1"
tell let's encrypt to check the challenge
get the generated certificate

Now, using cert-manager + acmedns, it does the following (to my understanding):

get the challenge from let's encrypt: ChAllenge2
configure acmedns with this challenge
check that the challenge is correctly set
tell let's encrypt to check the challenge
get the generated certificate

It fails at 2. because cert-manager tells acme-dns to create a challenge entry for a leaf.domain.com domain that doesn't exist (see logs above) instead of the domain.com domain which is the one we want to use for the challenge. As I said before, it's correctly setting the challenge in the domain.com domain if I ask for a wildcard certificate *.domain.com.
I hope this is clearer now.

Or do I have some big misunderstanding of how dns-01 challenges work?

It seems I had misunderstood how this challenge work, indeed.
If I understand correctly now, to validate a leaf.domain.com certificate, I'd have to create a _acme-challenge.leaf.domain.com TXT entry. I thought that we needed to validate the ownership of the domain not the subdomain.
Am I understanding right, now?

Yep, exactly 😄 you validate ownership of the domain/subdomain (e.g. leaf.domain.com, not the zone (which would be domain.com in your example).

In my mind, leaf.domain.com is a host, not a domain. That was the ground of my misunderstanding, I guess.


I want to change play music speed  in our app. how is it possible.

I want to change music play speed in our app. how is it possible.

my issue resolved


add 'repo' install method to fetch and install package directly from packagecloud

This add's an additional install method 'repo' which includes the packagecloud repositories for install and update grafana. Enhanced for Debian/Ubuntu and RedHat.
Also fix package name of libfontconfig to libfontconfig1 which is the correct one on Ubuntu LTS. This fixes the reinstallation of libfontconfig each time the puppet runs.
spec file is enhanced, but needs a review from a more experienced spec file writer.

Many modules add an enable_repo parameter. This allows people who create mirrors or packages to opt out of the module managing the repo.

Hi @rplessl thank you for the pull request! I'd like to merge this, though I have some comments / questions.

I am in agreement with @adamcstephens that we should provide the ability for the module to not manage the package repository, in case the user has their own local repository they are maintaining.

Have you tested this code on Red Hat systems? I ask because I don't believe this code will work as the package name is fontconfig.

There is no ordering of the package resources via the require metaparameter, so there is the possibility of the module attempting to install Grafana before libfontconfig1 (or fontconfig, as the case may be).

Items 2 and 3 are not caught by the tests in the repo install method context because the install_method parameter is not being set to repo and it is falling back to the default, package. See the code in the archive install method context for an example of this.

Again, thanks for the submission!

Hi @bfraser!
Thanks for your quick reply.

I agree, there should be a way for local repositories ... I will change my code

Not tested with RedHat System, I agree, the marked install section should be moved to plattform specific part ... will follow in the next commit.

Agree, will fix that in the next commit.

Ok, will fix that too.

Thanks for the review! A new submission of the pull request will follow.

Hi @bfraser @adamcstephens,
I have added the suggested points:
Finding 1 / 4: There exist now a configuration value manage_package_repo to enable / disable the packagecloud repository.
Finding 2 / 3: Fixed.
Thanks for review again!

Hi @rplessl this looks good. Thank you, I appreciate the contribution!


Update datasets to work with integer timestamp

Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[x] Did you write any new necessary tests?
[x] Did you update the CHANGELOG?

Proposed Changes

Closing issues
#139.

We usually create TSDataset like this:
TSDataset(TSDataset.to_dataset(df), freq=freq)

So, I think, we should add here additional info about possible types of "timestamp" column in docstring:
https://github.com/etna-team/etna/blob/f1990a96989f5675fb09df172ae2591cc569ec40/etna/datasets/tsdataset.py#L766

In the issue   there is two points:

Clarify in the docs that timestamp could be integer for describe method
Clarify in the docs that timestamp could be integer for info method

Should we take them into account in this task?


Feature request: Automatic stacked icon detection

fa_icon could be assumed to be stacked if a base option is present. And if that was done, fa_stack_icon could be deprecated and the API would be simpler, just one helper.

Closing this out due to lack of progress.
I once spent a small amount of time on this, but the complexity blew up more than the feature was worth.


Adapt to '.devcontainer' folder restriction to follow latest spec for local-features

Adapt to the spec for local-features - https://github.com/devcontainers/spec/blob/main/proposals/devcontainer-features-distribution.md#addendum-locally-referenced

A local feature is placed in a .devcontainer/ folder at the root of the project workspace folder and referenced in a user's .devcontainer/devcontainer.json by relative path.

🛑 Blocked - https://github.com/devcontainers/spec/blob/main/proposals/devcontainer-features-distribution.md#addendum-locally-referenced is not supported yet by the CLI

Depends on

[ ] https://github.com/devcontainers/cli/issues/136

Closing as completed.


When executing the Aromatize function, the drawn Template structures on the canvas change their position

Steps to Reproduce

Launch "Ketcher"
Draw three Benzene and two more any Templates on the bottom (or on the right, or on the left, or on the top) of the canvas
Click on the "Aromatize" button
Verify the position of the Templates on the canvas
Compare the result of 2 and 4 points
Сlean the canvas
Draw one Benzene in each corner of the canvas
Click on the "Aromatize" button
Verify the position of the Benzenes on the canvas
Compare the result of 7 and 9 points

Actual behavior
When executing the Aromatize function, the drawn Template structures on the canvas change their position
Expected behavior
When executing the Aromatize function, the drawn Template structures on the canvas should stay where they are
Screenshots

Desktop (please complete the following information):

OS: Windows 10 Pro (version 22H2) x64
Browser: Сhrome
Version: (114.0.5735.199) x64

Ketcher version 2.14.0-rc.2

Test cases written


[Feature request] Option to disable TAB

It would be a nice option to SunEditor if it could be possible to optionally disable TAB.
Some other editors have this option:

https://summernote.org/deep-dive/#disable-tab

Would it be possible?

Hi @madarche
Thank you for a good idea. :)
I'll add it to the next version.

Nice @JiHong88 😀

The 2.29.0 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.

A very big thank you @JiHong88! Thanks a lot for this feature. We'll test this release very fast!

@JiHong88 please see #370 for both feedback on the new tabDisable option and a potential improvement. Thanks!


Question about drivessd function in startup.sh

I'm not very experienced in coding, but if the action is the same in both cases (lines 272,274) isn't this function redundant?
Here's a screenshot:

The mount options are not the same though. Notice the 'ssd' option if yes

@EliteCodexer Got it, thanks!