Graceful handling of features source outage

At the moment ghcr.io is experiencing an outage and returning 503 responses for all requests:
https://www.githubstatus.com/incidents/ybnn77s3lyf8
This results in a failure to load a devcontainer even when the devcontainer has already been built.
The only option seems to be to comment out the /* "features": {...} */ definition in the devcontainer.json file.
As an alternative, consider more gracefully handling 503 errors as temporary and allow the (existing) devcontainer to launch as before, perhaps issuing a warning that the container may be missing features due to a temporary upstream outage.

@joshspicer this is another situation where we should cache the feature artifacts locally for true offline builds after the first build.

As an alternative, consider more gracefully handling 503 errors as temporary and allow the (existing) devcontainer to launch as before, perhaps issuing a warning that the container may be missing features due to a temporary upstream outage.

I'd rather not do this, as we want devcontainers to be fairly deterministic, and if a specific feature is requested, it should either be present in the final container or fail the build. But if we have better caching/offline support, it will mitigate the need to do this. The first time you pull in a feature it would need to be online, but once it's cached locally, it can be used offline.

Agreed, this scenario is an argument for https://github.com/devcontainers/cli/issues/399

That'd be a fine solution to my mind as well.
The problem, at least as I see it, atm is that when there's such an outage (which granted should be rare) then the only recourse to be able to get working again is to comment out that section.  That could easily be forgotten to revert, which could lead to a new sort of non-determinism.
Really, once the image is built (be it through the cli or via vscode directly), the features should probably only need to be checked again upon rebuild, so caching them locally and checking that instead seems like a fine solution to me.

I don't think we should require repos to check in the downloaded features, but the devcontainer CLI can keep a local cache of downloaded features and prefer that cache if matching feature versions are already downloaded.
When doing a devcontainer build, we should attempt to resolve the latest version of a feature with a fallback to the cache. For instance, if you pin to the latest major version :1, we should attempt to resolve the latest 1.x version of the feature, but if that fails, we should fall back to the latest cached version as long as it satisfies the requested version (e.g. the latest cached 1.x would be used).


Question about Nemesis and tail latency

From your blog post:
One thing we have observed is that with nemeses enabled, rqlite struggles to maintain acceptable tail latency.
Can you define what "acceptable" is? This testing involves deliberately slowing down the network. What are you expecting to happen?

'Acceptable' is admittedly left quite vague in our post. The latency graph in the blog post shows that for some requests, the latency is as high as 10 seconds, which I would consider unacceptable for many usecases. For that latency graph we did not slow down the network, we only isolate certain nodes from eachother for (5 seconds).
What I would expect in this case is that if consensus cannot be reached due to a partition, a new leadership election should occur and the request should be processed, if with slightly higher than usual delay. I'll note that the way we partition makes sure that there is always a group of nodes that can still reach quorum and thus handle the request, so I would expect that even within a 5 second isolation window, we can always make progress.
I did not investigate exactly what is triggering these high-latency requests, maybe a leader election that takes a long time? We did not tweak any timeout values, so the effect could be less pronounced for other settings.

Did you know that the timing behavior of Raft (and rqlite) is configurable? I'm not sure if it would address what you are seeing, but the timings are highly configurable (heartbeat, election timeout, etc). Run rqlited -h to see all your options.

That sounds promising! Taking a look at the default values I see most timeouts are around 1 second, so individually too low to explain 10 seconds of latency, but perhaps there is some interaction under certain conditions. If I can find some time I will try to tweak those flags and see if it helps, thanks! :)


When returning to workflow launch object, know if said workflow was abandoned or completed successfully

Is your feature request related to a problem? Please describe.
When a workflow finishes, we have no way of knowing if the workflow was abandoned or completed
Describe the solution you'd like
We want a way to know if a workflow was abandoned or completed
Describe alternatives you've considered
Flagy
Additional context
Add any other context or screenshots about the feature request here.

Closing this issue due to inactivity - please reopen in the future if interested in a solution


Need to include  for std::toupper and std::isalnum

I had to include <cctype> to get the C++ files to build.  I would be interested to learn how everyone else managed to build them without this include.  Is it perhaps a question of Visual C++ version?

I am using

Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27031.1 for x64

I'm not sure what that corresponds to, but 19.xxx sounds like VS2019.  It's strange.  Anyway, I shall merge it.


[FEAT] Additional Text in Main Page

Feature Description
Please describe the feature you are requesting in detail.
What should it do, and how should it behave? E.g., I would like a feature that allows users to...
Since now the About page has a simple 'who am I' text, I would like to assume that some other text should be added to enhance viewer knowledge on the person. Things like 'What I do During My Free Time?' or like 'What are my Hobbies', etc etc.
Problem to Solve
What problem or issue does this feature address?
Why is it needed? E.g., Currently, users face an issue where...
This feature should address the lack of information in the about me section. Will give viewers a more indepth knowledge on the person.
Additional Context
Add any other context, screenshots, or references about the feature request here.
As of right now the about me page will follow this wire frame.

For subsequent text, can add similar design but image and text will be flipped.
Checklist
Before submitting, please ensure you've done the following:

[x] I have searched the existing issues to ensure this is not a duplicate.
[x] I have provided a detailed description of the feature.
[x] I understand that not all feature requests may be implemented.

Completed
This feature is implemented in the about branch and has been merged to dev branch at #10 . Therefore, this issue will be closed.


getRelationship method gets called twice per each resource in response

suppose we have a request url http://xxx/jsonapi/speakers/1654?include=sessions
the result will be one primary resource of speakers, and it will include sessions, which will come from (in this test scenario) from SpeakerSerializer->sessions()
but that sessions() method gets called twice (and it should be called only once, since there is only 1 primary element). if  the request would call for a list of speakers, like so: http://xxx/jsonapi/speakers/?include=sessions, then the SpeakerSerializer->sessions() will get called twice the time of the count of the speakers items
i debugged the code, and found that the SpeakerSerializer->sessions() gets called:

here
AbstractSerializer.php
line 75, inside of public function getRelationship($model, $name)

$relationship = $this->$method($model);

this AbstractSerializer.php:getRelationship() gets called from Resource.php:toArray()

and again the same line (meaning  AbstractSerializer.php:getRelationship()) will be called from Document.php::toArray() from within the line saying:

$resources = $this->getIncluded($this->data);

so to sum it up:
Documen.php:toArray() calls the same code twice per each resource, and does so on the line saying
$document['data'] = $this->data->toArray();
and just next to it
$resources = $this->getIncluded($this->data);

Thanks for the detailed report @bebor. I've pushed a fix, can you confirm it's working as expected?


MonadRandom instead of IO

Would you be open to relaxing function type sigs from IO to MonadRandom for testability? Even at some cost of performance?

Absolutely! Best way forward is to put in a basic benchmark so we have some idea of the performance impact and can maintain the type specialized variants if the delta is large. However, there's a reasonable chance the user's computation over the sample combined with potentially out-of-cache data loading will swamp the random number part, so I'd be fine with just cutting over to MonadRandom and adding specialized versions if someone finds it to be a problem.


FEATURE - Include Account Name in Output Models

Are you a Fivetran customer?

Fivetran created request
Is your feature request related to a problem? Please describe.

The account name is not included within these reports. This therefore means the account name is not included in the ad reporting model.
Describe the solution you'd like

Include the account_name in the source models and also flow into the ad_adapter model within Pinterest to then also be included in the ad reporting model.
Describe alternatives you've considered

No alternatives available currently.

@bnealdefero I wanted to tag you here as we had chatted a few weeks ago that you may be open to sharing a sample .csv file of the advertiser_history. Since our team does not have this data internally, it is pretty difficult to recreate the table structure with accuracy. As such, a sample .csv should help us integrate the account name information into this model and others downstream.
Let me know if this would be possible share 😄  Also, let me know if you believe the account information is somewhere other than advertiser_history. From my inspection of the ERD, that seems to be the table for this information but would love your insight on this as well. Thanks!

Hi @fivetran-joemarkiewicz , shared a .csv file with you via slack. Let me know if you need any additional data to play with..
Thanks!

Thanks again for sharing the sample seed data with our team @bnealdefero 🙌
Since then, I was able to open a few PRs that implement the advertiser_history fields into the final models. Let me know if you have a chance to test the working branches. Otherwise, the team will review the open PRs and integrate into the next releases.

FYI both the Pinterest Ads and Ad Reporting working branches have are only compatible with dbt v1

The Pinterest Ads working branch:
packages:
  - git: https://github.com/fivetran/dbt_pinterest.git
    revision: feature/advertiser_addition
    warn-unpinned: false

The Ad Reporting working branch:
packages:
  - git: https://github.com/fivetran/dbt_ad_reporting.git
    revision: feature/pinterest_account_addition
    warn-unpinned: false


Package Title is incorrect in NuSpec

This is the case for both the NuGet and the Chocolatey packages. In the case of Chocolatey, it is listed incorrectly in the gallery.

:tada: This issue has been resolved in version 2.1.1 :tada:
The release is available on:

GitHub Release
NuGet Package
Chocolatey Package


Update translation strings as of 20180831T233621

yarn run v1.9.4
$ eslint *.js settings InstanceSearch
/home/jenkins/workspace/folio-org/ui-plugin-find-instance/PR-3/project/InstanceSearch/InstanceSearch.js
49:24  error  Must use destructuring props assignment  react/destructuring-assignment
54:12  error  Must use destructuring props assignment  react/destructuring-assignment
54:37  error  Must use destructuring props assignment  react/destructuring-assignment
57:21  error  Must use destructuring state assignment  react/destructuring-assignment
/home/jenkins/workspace/folio-org/ui-plugin-find-instance/PR-3/project/InstanceSearch/InstanceSearchModal.js
35:5   error  Must use destructuring props assignment  react/destructuring-assignment
42:5   error  Must use destructuring props assignment  react/destructuring-assignment
55:59  error  Must use destructuring props assignment  react/destructuring-assignment
57:12  error  Must use destructuring state assignment  react/destructuring-assignment
57:67  error  Must use destructuring state assignment  react/destructuring-assignment
61:37  error  Must use destructuring props assignment  react/destructuring-assignment
✖ 10 problems (10 errors, 0 warnings)
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.


Converted the stencil to a compiled function using autowrap

On a smaller grid (14 x 14 x 14), the run time went from 231 seconds to 5 seconds because of this change.
The compiled function couldn't accept parameters as p(x,y,z) (as far as I understood the problem) so I had to make a variable for each array access. Sorry for dirtying up your code. Will work on beautifying the code again, however I want your feedback on whether its producing equivalent results. I compared the numerical output at the last time step and its the same (x,y) matrix.
This version doesn't contain any vectorisation. Further speedups should be expected once that is done.

When you say a 14 x 14 x 14 grid, do you min you reduced the domain size (xmin, xmax..) or change the grid size(hstep).
The grid size in the current setup (mine) is based on cfl condition. So modifying it would generate unstable or very dispersive wavefield which is very bad (Strong high frequency ripples will break the inversion)
I will run it to see what it does and if it is still consistent enough with the wave equation

I did not change the values in the committed code. I was reporting the grid size at which I compared the execution times.  I reduced the domain only to be able to test faster since I was only tracking execution time while testing. The code here should have the same simulation parameters that you put in.

I don;t have the right compilers to run your implementation, I am looking into it to see what I can do.

@navjotk  @mlange05 . I have lambdified with numy the stencils which changed the computation time from hours to seconds. It has the advantage to run without external librairies or compillers

Closing for now. Can be re-evaluated when we are in a position to run better performance tests.


YAML update

YAML stands for "yet another markup language" the current acronym expansion is both confusing as it contains the acronym itself and its incorrect

@mlearned - Could you review the proposed update?
The internet seems to indicate that the definition started out with one value, and that YAML's "maintainers" later changed the definition to something else: https://rollout.io/blog/yaml-tutorial-everything-you-need-get-started/

@jeffadavidson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

YAML is now a recursive acronym for YAML Ain't Markup Language, which is currently correct. Originally, it was a regular acronym for Yet Another Markup Language.
#please-close


Implement an independent library for mapping code

This is to be used in snforge (for printing latest failed line), cairo-coverage, and cairo-profiler
This should include:

CallTrace structure definition (versioned, like cairo-lang's VersionedProgram, so that we can recover from failures on unmatched/unsupported versions, with aborting the print)
Definition of mappings structures for coverage and profiler
This function:

fn map_vm_trace<T>(
  vm_trace: Vec<TraceEntry>,
  casm_debug_info: CasmDebugInfo,
  sierra_mapping: HashMap<StatementIdx, T>,
  run_with_header: bool,
) -> MappingResult<T>

and this structure:
MappingResult<T> {
   Concrete(T)
   Header,
   PcOutOfFunctionArea,
}

cc @piotmag769 to provide the rationale

Is this really done?


Do not display null tails for hangul_to_jamo

>>> j2hcj(h2j("자모=字母"))
'ㅈㅏ\x00ㅁㅗ\x00=字母'

This isn't really the best, probably.

to be changed in 0.4.


#1757 add jupyter notebook checkpoints to .gitignore

Adds .ipynb_checkpoint files to .gitgnore
These files are created if notebooks as auto-save files if notebooks are saved within the source tree.
Explicit notebooks will be added to git as usual, this prevents accidental auto-saves from being checked in.
Signed-off-by: Nigel Jones<EMAIL_ADDRESS>

I fully support this proposal - thank you @planetf1


Retain class observers

Observers are referenced as __unsafe_unretained, but sometimes observers released, leading to crash on notification. Fix this by retaining observers.
Other approach may be keeping week references to observers, but i've took simple way :)

Bump @PaulTaykalo

@zintus In case if we'll do this, no instance will be ever released, and everything will be in memory.
It's probably ok for small projects, but on big ones, you'll be out of memory very short :)
If you know what objects are not being released, then, probably, we'll be able to fix this one.

Your point is perfectly valid, it's not viable solution for big projects.
I've investigated further and did find that unsubscription fails for objects changing their class after initialization. Realm doing this, so disable notifying objects with RLM class prefix. Injecting realm classes is meaningless anyway, because live schema changes aren't supported.

@PaulTaykalo gentle bump :)

Sorry, @zintus I missed your commit.
Will check this one :) you can use your branch for a now. I 'll check if it's not crashing other parts of application.
Also, for next releases, I think it's better to allow sue to select what objects he want to be injected.
Ping me in few days, please

It's good to have a project with libraries installed to check how it's working and check if it's failing or not
Probably, will make one


Testing for null pointers

I have a linked discussion here (https://github.com/microsoft/GSL/issues/1006).
Take this code:
XMLElement* pReminder = m_docReminders.NewElement(CT2CA(rReminder.GetKey(), CP_UTF8));
XMLText *pText = m_docReminders.NewText(CT2CA(rReminder.GetReminder(), CP_UTF8));
pText->SetCData(true);
pReminder->InsertEndChild(pText);

Do we need to test pReminder and pText against nullptr? Or, are they guarenteeds to be not null?

According to the code you can get only an exception if your system is low in memory, as you get an pointer created with new.
So I think there is no chance to get a nullptr from NewElement at all

According to the code you can get only an exception if your system is low in memory, as you get an pointer created with new.
So I think there is no chance to get a nullptr from NewElement at all

Thanks @khReichel . Technically though, if we are using new under the hood then we must test the pointer for being null.

Thanks @khReichel . Technically though, if we are using new under the hood then we must test the pointer for being null.

Nope new returns either a valid pointer or throws an exception, but will not return null.

Nope new returns either a valid pointer or throws an exception, but will not return null.

Awesome. They should document it in the xml library usage.

From: Karl-Heinz Reichel @.>
Sent: 01 January 2022 19:57
To: leethomason/tinyxml2 @.>
Cc: ajtruckle @.>; Author @.>
Subject: Re: [leethomason/tinyxml2] Testing for null pointers (Issue #881)
Nope new returns either a valid pointer or throws an exception, but will not return null.
—
Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fleethomason%2Ftinyxml2%2Fissues%2F881%23issuecomment-1003608916&data=04|01||0b55c145b2404dfafe1108d9cd6101eb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637766638785997493|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Cj2nikgAzMRhekAfQyuow1nOIvs2KjZAZFIbdTGRx6E%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB45RM6DOGMGLUIFXWEQTQLUT5MEJANCNFSM5GPAZVZA&data=04|01||0b55c145b2404dfafe1108d9cd6101eb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637766638786007445|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=DugbcQRJM5fVghheKYly1Mp6Y8aOs0szNkLhpnKged8%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

Awesome. They should document it in the xml library usage.

From: Karl-Heinz Reichel @.>
Sent: 01 January 2022 19:57
To: leethomason/tinyxml2 @.>
Cc: ajtruckle @.>; Author @.>
Subject: Re: [leethomason/tinyxml2] Testing for null pointers (Issue #881)
Nope new returns either a valid pointer or throws an exception, but will not return null.
—
Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fleethomason%2Ftinyxml2%2Fissues%2F881%23issuecomment-1003608916&data=04|01||0b55c145b2404dfafe1108d9cd6101eb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637766638785997493|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Cj2nikgAzMRhekAfQyuow1nOIvs2KjZAZFIbdTGRx6E%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB45RM6DOGMGLUIFXWEQTQLUT5MEJANCNFSM5GPAZVZA&data=04|01||0b55c145b2404dfafe1108d9cd6101eb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637766638786007445|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=DugbcQRJM5fVghheKYly1Mp6Y8aOs0szNkLhpnKged8%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>


Gem::RemoteFetcher::FetchError: Received fatal alert: bad_record_mac

If you do a bundle install on ladle using JRuby you may run into an error Gem::RemoteFetcher::FetchError: Received fatal alert: bad_record_mac

This is relates to Java Version less than Java 1.7.0_51 b04 and is fixed for future releases. Wanted to document it here that this occurred. Similar issue with logstash found here.

Thanks, @keaplogik.


Allow object arrays as data source & use newest polymer versions

Hi,
not sure if you are interested in it - but in my fork, in addition to tell bower to always use the newest Polymer versions, I added a "getValFn" to your code, so I can put my own function in there, allowing me to use object arrays as data source. Strings should still work the same way as before. I am using it for an auto-fill-form, giving objects with pre-filled fields and filtering them by their title. I updated the demo to show what it does, using the last 2 inputs, filling each other if one gets filled.
https://compufreak345.github.io/paper-typeahead/components/paper-typeahead/demo/
So, this is my fork :
https://github.com/compufreak345/paper-typeahead
Are you interested in a pull request or is it a too specific problem?
I'm not 100% satisfied with strings being returned as value when nothing was selected, making some special handling necessary, but I couldn't think of a better way.
Unfortunately my automatic code formatting changed some indents, let me know if this is a problem.
Oh, and I just grabbed that country-list I found on google. https://gist.github.com/Keeguon/2310008 . No license mentioned there, if you have any better example let me know xD

:+1: PRs welcome


As a developer, I want all code to be run through TDTM or equivalent, for consistency

All triggers and controllers use TDTM, but we need to review batch, future, and especially schedulable calls to make sure that they also use it.
For example, this is an error that seems to be coming from an schedulable:

Apex script unhandled exception by user/organization: 005A0000001Hv2g/00DA0000000ARMg
Failed to process batch for class 'npsp.RLLP_OppSoftCreditRollup_BATCH' for job id '707F000001iliJY'
caused by: System.DmlException: Update failed. First exception on row 191 with id 003F000001aXN05IAG; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, There is already another Primary Account Contact.  Please uncheck the box and try to save again.PrimaryContact Diana Chapman Walsh 003F000001aXN05IAG: [Primary_Account_Contact__c]
Class.npsp.RLLP_OppRollup.rollupSoftCredits: line 685, column 1
Class.npsp.RLLP_OppSoftCreditRollup_BATCH.execute: line 56, column 1

(Searching for "label:npsp-errors class.npsp" in the error emails gives you all the existing npsp errors.)

Caveat for Batch classes: we should not capture exception and log errors in their execute method, because if we don't let the exception bubble up the stack, then the batch will think it all succeeded. If we were to log it, and then propagate the exception, the transaction would get rolled back, and the logging would be erased.

Included in beta release version 3.32 (Beta 8) and higher

Included in production release version 3.32


#321 - update readme with tagui editor gif video

Hi @ryzalk and @Aussiroth , adding on to Alvin's update, this PR updates readme to point to the gif video for @adegard 's TagUI Editor. The gif is hosted at Arnaud's repo and is < 2MB so it's ok to put that instead of having a static TagUI Writer screenshot.
PS - I edited on a patch branch as my own repo at tebelorg has overly verbose commit history to be desirable to merge upstream here.

Hi @kensoh! Apologies for the delay in merging this pull request. Just came back from my vacation. Thanks for the update :) Cheers!

Welcome back from holidays and thanks @ryzalk ! =)


fixed an issue of overflow using expanded and textoverflow

@ajay963 Can you add attach a screenshot also

before overflow after over flow for mobiles devices

Any further updates on this issue sir ??


Request: Provide a .app package for macOS

Would be fantastic if you could bundle this into a .app for macOS as part of your releases.

Hint: https://github.com/excelsior-oss/excelsior-jet-gradle-plugin/wiki/Creating-OS-X-Application-Bundles-And-Installers

Hi @Redth , @asashour
Please check https://github.com/skylot/jadx/issues/1308. I made and attached JADX 1.3.0 MacOS DMG/APP version.


1.2.0: missing return generated

Apologies if this is a duplicate, this is the simplest syntax I could come up with:
	_test: =>
		for a in b
			if c == d then return true
			for e in f
				if g then true

Notice the missing return statement in the last if statement:
    XYZ.prototype._test = function() {
      var a, e, _i, _j, _len, _len2;
      for (_i = 0, _len = b.length; _i < _len; _i++) {
        a = b[_i];
        if (c === d) return true;
        for (_j = 0, _len2 = f.length; _j < _len2; _j++) {
          e = f[_j];
          if (g) true;
        }
      }
    };

Some odd variations do work (take the first return out):
	_test: =>
		for a in b
			if c == d then true
			for e in f
				if g then true

Produces the expected result:
    XYZ.prototype._test = function() {
      var a, e, _i, _len, _results;
      _results = [];
      for (_i = 0, _len = b.length; _i < _len; _i++) {
        a = b[_i];
        if (c === d) true;
        _results.push((function() {
          var _j, _len2, _results2;
          _results2 = [];
          for (_j = 0, _len2 = f.length; _j < _len2; _j++) {
            e = f[_j];
            if (g) {
              _results2.push(true);
            } else {
              _results2.push(void 0);
            }
          }
          return _results2;
        })());
      }
      return _results;
    };

Here's a simpler example where a comprehension isn't generated:
_test: ->
  for i in arr
    return if condition
    value

The active ingredient is the potential return from the loop. Likewise, the loop won't be a comprehension if there's a potential return after it:
_test: ->
  for i in arr
    value
  return val if condition

It seems like the CoffeeScript compiler is treating potential returns the same way that it treats definite returns when it comes to deciding whether a loop should be a comprehension or not. I'd call that a bug. What does @michaelficarra think?

I just noticed this got labelled as a question. Doesn't really seem to be a question to me. Seems more like a bug. =)

I don't see either of @TrevorBurnham's examples as bugs. Can you go into why that's apparently erroneous behaviour?

@michaelficarra
Can you explain why in my example above:
if c == d then true
would produce different code than:
if c == d then return true
That seems to fail the law of least surprises.

Placing a return inside your loop tells us that you can't possibly want to use it as a value, since you're controlling the flow of the surrounding scope from within the loop. It would also make the compilation way messier because we use IIFEs to produce the returned list. The return would have to compile to a thrown (and later caught) value or some specially tagged (and later unwrapped) value.

@michaelficarra Why couldn't
_test = ->
  for i in arr
    return if condition
    value

compile as
test = function() {
  var i, _i, _len, _results;
  _results = [];
  for (_i = 0, _len = arr.length; _i < _len; _i++) {
    i = arr[_i];
    if (condition) return;
    _results.push(value);
  }
  return _results;
}

? All I did there was add the if (condition) return; line to the compiled output that you get without the return if condition. IIFEs don't come into play in this case.

$ coffee -bps
_test = ->
  x = for i in arr
    value
var _test;

_test = function() {
  var i, x;
  return x = (function() {
    var _i, _len, _results;
    _results = [];
    for (_i = 0, _len = arr.length; _i < _len; _i++) {
      i = arr[_i];
      _results.push(value);
    }
    return _results;
  })();
};
$ coffee -bps
_test = ->
  x = for i in arr
    return if condition
    value
SyntaxError: cannot use a pure statement in an expression.

Right, "cannot use a pure statement in an expression" seems like too broad a rule to me. It's just an unfortunate side effect of the fact that we currently use IIFEs for x = key for key of obj. But if we're not scoping loops (and I realize there's an open issue to bring scoped loops back), then what's the justification for using IIFEs rather than the compilation you've just described?

Agree with @michaelficarra, this doesn’t feel like a bug. Sorry if it surprises; a PR that updates the docs would be welcome, or if someone wants to submit a PR that changes this behavior, it would be considered.


Performance

Did you end up making this work?

Not yet. I was busy working on other things. Probably would pick this up in several months. 😭

I dont think you are filtering out detections with score < 0.05? This is decrease fp and increase recall


description of split should specify what happens in edge conditions

It appears that split('hello', 'nonexistent delimiter') returns a single-element array ["hello"] as might be expected, but it should be documented.
Edge conditions are WAY too important in programming to not mention them in the reference documentation!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 03aa9e88-7fa0-56ab-f794-58f0c37b6d7a
Version Independent ID: 25c5ef5c-6ba4-f5ff-f94b-8f2818ec2feb
Content: Reference guide for functions in expressions - Azure Logic Apps
Content Source: articles/logic-apps/workflow-definition-language-functions-reference.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

@plbowers Thanks for the feedback! We are currently investigating and will update you shortly.

I've sent a PR request to the doc author to add a second example when the delimiter is not contained in the text. It will go live once it has completed review.


Add privacy safety information to the main website.

Hello,
Thank you for this awesome project. I just came across this project and would love to use it. I was wondering whether there is any logging of the text that we write using markdown-here? I wanted to know how safe would it be before I give it access to my emails. Since, this is an open source project, I am sure people other than the original author might have combed through the code to see for this. Please let me know what you think. If it indeed doesn't log anything, then this should definitely be in the sales pitch on the main website as many people who would like to use it, just don't because of this fear.
Thanks
P.S. I skimmed through the code and I don't see anything that does any logging. I am not an expert in JS or web programming though.

Hello,
any update on that issue?
In my company, the extension has been blocked because it lacks privacy policy statement.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_770e685a-5c0f-4d8c-afff-58fce4073a01/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_770e685a-5c0f-4d8c-afff-58fce4073a01.git

Docs Build status updates of commit 07f8a13:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


chore(flake/stylix): 1e9ec16a -> 0eea8bcb

Commit
Message

0eea8bcb
spicetify: init (#574)

need to probably remove theme name and then decide weather to merge or reject


Default dashboard deployment has GQL errors

Summary
When running on a minikube cluster and following the readme, the default published helm chart displays HTML error message in the dashboard projects list:
"Error: Something went wrong while loading the project list. Unexpected token '<', "<html> <h"... is not valid JSON"
and an error message when trying to create a project:
Error: Unexpected token '<', "<html> <h"... is not valid JSON

Kubernetes pod logs show 405 GQL errors, I guess POST is not allowed:

<IP_ADDRESS> - - [23/Nov/2022:16:48:47 +0000] "GET /projects HTTP/1.1" 200 796 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" "-"
<IP_ADDRESS> - - [23/Nov/2022:16:48:47 +0000] "POST /graphql HTTP/1.1" 405 571 "http://<IP_ADDRESS>:51178/projects" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" "-"
<IP_ADDRESS> - - [23/Nov/2022:16:48:48 +0000] "POST /graphql HTTP/1.1" 405 571 "http://<IP_ADDRESS>:51178/--create-new-project--/edit" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" "-"

How to reproduce
minikube delete
minikube start
k create ns cypress-dashboard
helm repo add sorry-cypress https://sorry-cypress.github.io/charts
helm install -n cypress-dashboard sorry-cypress sorry-cypress/sorry-cypress
minikube service -n cypress-dashboard --url sorry-cypress-dashboard

Environment

sorry-cypress version: not relevant
cypress version: not relevant
helm chart version: not relevant

I have the same issue, someone did success to solve the issue?

After some research, we have to set dashboard.environmentVariables.graphQlSchemaUrl in values to call the right api url which is https://[YOUR_API_URI]/cypress-api

Im having the same issue. I set the API url in the values.yaml to cypressapi.full.url.systems and set the     graphQlSchemaUrl to "https://cypressapi.full.url.systems/cypress-api" and now the error is "Error
Something went wrong while loading the project list. Failed to fetch"

Hey @Adriien-M, I'm kinda new to helm. Can you give an example on how to set dashboard.environmentVariables.graphQlSchemaUrl - do I set it when installing the chartor somewhere else?

Today I spent the entire day trying to get sorry-cypress running in k3s.
The API wasn't working.
"Error: Something went wrong while loading the project list. Unexpected token '<', " <h"... is not valid JSON"
But eventually, I found the problem in the config:
# set BASE_PATH
basePath: 10

It was enough to change it to -
# set BASE_PATH
basePath: ""

and everything started working immediately.
Thanks for not letting me get bored...


Readme.md does not say how to provide a session name

The command line interface says that /start "Tells vcperf.exe to start a trace under the given session name.", but it does not say how to provide a session name.
Please add at least one or two examples of a complete command line.
Also, I think the solution will not build using VS 2017, so the instructions should say to open it in VS 2019.
Thanks

Hi Scott,
Thanks for reporting the issue with the README. This will be fixed soon.
It's possible to build vcperf with VS 2017 if retargeting the project to use the v141 toolset and a different version of the Windows 10 SDK (whichever one is available on your PC).
I will add notes to this effect in the documentation as well.


retryWhen with subscriptions not working

I am using Apollo client SDK for android v1.0.0.
I am facing an issue while I am trying to retry an Apollo Graphql Subscription. I am using a "retryWithDelay" Kotlin method as follows and I have also added the code block where I am trying to subscribe with a "retryWithDelay".
I am also cloning in the getSubscriptionCall() method ->
return subscriptionClient.subscribe(subscriptionQuery).clone()).map { it.data() }
Use case: The web socket connection is auto closed from the backend after a certain time. When this happens, we get an onError() in the rx stream of android client. Here we have to retry websocket connection and resubscription. This is what im trying to achieve using retryWhen.
Still, when the ACTUAL RETRY happens, the resubscription is not happening. The log added in the "doOnSubscribe" is printed, but the re-subscription to the query does not happen. At the end of maxRetries, onError callback is called, and the exception thrown is
com.apollographql.apollo.exception.ApolloCanceledException: Call is cancelled.
Can you pls check the following code and tell me if I am missing something? The retry is working fine, added logs and checked.
//Attempts a retry for "maxRetries". Each retry will be after
//retryDelayMillis. After final retry, error callback will be called
fun  Flowable.retryWithDelay(maxRetries: Int, retryDelayMillis: Int): Flowable {
var retryCount = 0
return retryWhen { thObservable ->
    thObservable.flatMap { throwable ->
        if (retryCount < maxRetries) {
            retryCount++
            Flowable.timer(retryDelayMillis.toLong(), TimeUnit.MILLISECONDS)
        } else {
            retryCount++
            Flowable.error(throwable)
        }
    }
}

}

getCompositeDisposable()?.add(getSubscriptionCall()
.doOnSubscribe{println("doOnSubscribe called")}
.retryWithDelay(5, 1000)
.observeOn(AndroidSchedulers.mainThread())
.subscribeOn(Schedulers.io())
.subscribe({ data -> onSuccess(data) }, { error -> onError(error) })
)

Hi 👋 . Can you try with version 2.4.1? There have been a number of fixes since 1.0.0, most notably https://github.com/apollographql/apollo-android/pull/2587. You will want that if you're using the RxJava extensions.

Hi @gayathri-nair03 any news about this? Let us know if we can help with anything. If not, I'll close this next week.

Closing this as this should work with 2.4.1 . Let me know if it doesn't and you want me to reopen.


Maven

Can you deploy the project to maven central?

If there's a gradle build file then you could get this as a dependency from:  https://jitpack.io

This fork works with https://jitpack.io


[Future Request] response not only a link to the original image, but also a collection with modified dimensions using strapi-plugin-responsive-image

Using the strapi-plugin-responsive-image plugin allows you to generate several image formats, it is very convenient.
It would be great if strape-plugin-react-editor js in response gave an array of images of different formats

To do this, you need to add the format field to the loader's response, which comes in the response from Strapi Upload
EditorJs allows you to give any additional fields in the response

@Yurgeman
1 - I totally agree and lazy-load is really good, but now it is not necessary to use several formats of one image, it is quite possible to use the same base64 and implement something similar as on medium.com, when the blurry image is loaded first, and after  original.
2 - I don't see any point in this, strapi currently does not have a built-in ability to load the same file in different formats.  And even if there is, then it already needs to be controlled at the stage of adding content.
3 - no matter how ideal the system is, again, you have to control your managers, give guidelines, or write your controller according to the maximum size of the input data, depending on the type.  In my opinion, strapi has such an opportunity.  Strapi also has a built-in optimization of the used images, which is configurable in the settings.  In any case, this problem should not be solved by my plugin, but by you personally!
So in any case, all the above proposals you have given need to be publicly reviewed and voted on, because even if this approach is implemented, it will significantly increase the data returned by the plugin, which may not be liked by many users.


Please confirm responsibility for Sandbox environments as its unclear from the text

This page states - For a managed cloud service such as Finance and Operations, Microsoft is responsible for actively monitoring the health of production environments at all times.... However, you're responsible for proactively or reactively monitoring and troubleshooting the health of non-production environments.
For managed cloud service sandboxes (i.e. Tier 2 environment(s)) these aren't as accessible to either partner or customer in the same way as Tier 1 non production environments, and yet the Tier 2 environment is hosted by Microsoft. Its reasonable to expect that Microsoft is monitoring the environments that are managed, but the wording suggests that it is only production and not the other provided (as part of the D365FO subscription) UAT/non production sandbox - can the wording be changed to clarify this - whichever way round it is please ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 64b5b03d-9169-f94e-f999-63bc5a8e68ac
Version Independent ID: 177eb187-6962-ba30-7a63-86b0bf3452d7
Content: Monitoring and diagnostics tools in Lifecycle Services (LCS) - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/lifecycle-services/monitoring-diagnostics.md
Service: dynamics-365-cross-app
Product: ****
Technology: ****
GitHub Login: @AngelMarshall
Microsoft Alias: tsmarsha

Fixed.


Shouldn't App Protection be Required?

The scenarios have the policies listed select one of the conditions instead of all required. Shouldn't it be all conditions are required?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 14348ba7-48f0-1862-ebec-0fc3640e587d
Version Independent ID: 8188cee4-3f28-6014-f3be-1ee9e9b183b6
Content: App protection policies with Conditional Access - Azure Active Directory
Content Source: articles/active-directory/conditional-access/app-protection-based-conditional-access.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@cconrado
Thanks for your feedback! We will investigate and update as appropriate.

Thanks for this feedback. There is an open work item to address some of the confusion in the UI and with that language https://github.com/MicrosoftDocs/azure-docs/issues/80147
From my understanding from previous discussions, if you select both options "Require approved client app" and "Require app protection policy" with the Grant set to "Require one of the selected controls" the "Require app protection policy" is always enforced if the app supports it, even if the "Require approved client app" is already satisfied. So if the app that is used supports app protection policies, the option "Require one of the selected controls" under grant controls is more like an AND clause, even though the note at the top of this document says that it's like an OR clause.
But the "Require App Protection Policy" setting does not currently support the use of all applications and services, so your requirements will still dictate whether you choose "AND" or "OR."
Adding @MicrosoftGuyJFlo
Related threads:
https://github.com/MicrosoftDocs/azure-docs/issues/78912
https://github.com/MicrosoftDocs/azure-docs/issues/80147
https://github.com/MicrosoftDocs/azure-docs/issues/73762
https://github.com/MicrosoftDocs/azure-docs/issues/58022


[update] update gem version

change version 1.0.0 to 1.1.0 in version.rb

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #2   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          92     92
=====================================
  Hits           92     92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bdd934...fadaec4. Read the comment docs.


Update Composer dependencies (2023-03-14-00-10)

Visual regression test passed!
View the visual regression test report


DO NOT MERGE - test big repo

Learn Build status updates of commit ef2fdf8:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit ef2fdf8:
:bulb: Validation status: suggestions

File
Status
Preview URL
Details

xml/Microsoft.ApplicationInsights.Extensibility.Implementation/CloudContext.xml
:bulb:Suggestion
n/a (file deleted or renamed)
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

xml/Microsoft.ApplicationInsights.Extensibility.Implementation/CloudContext.xml

[Suggestion: file-not-redirected - See documentation] File xml/Microsoft.ApplicationInsights.Extensibility.Implementation/CloudContext.xml was deleted without redirection. To avoid broken links, add a redirection.
[Suggestion: file-not-redirected - See documentation] File xml/Microsoft.ApplicationInsights.Extensibility.Implementation/CloudContext.xml was deleted without redirection. To avoid broken links, add a redirection.
[Suggestion: file-not-redirected - See documentation] File xml/Microsoft.ApplicationInsights.Extensibility.Implementation/CloudContext.xml was deleted without redirection. To avoid broken links, add a redirection.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit ef2fdf8:
:warning: Validation status: warnings

File
Status
Preview URL
Details

xml/Azure.ResourceManager.DataBoxEdge.Models/EdgeIotRole.xml
:warning:Warning
View
Details

xml/Azure.ResourceManager.DataBoxEdge/DataBoxEdgeRoleData.xml
:warning:Warning
View
Details

xml/Azure.ResourceManager.DnsResolver/DnsResolverExtensions.xml
:warning:Warning
View
Details

xml/Azure.ResourceManager.ServiceFabricManagedClusters/ServiceFabricManagedClusterData.xml
:warning:Warning
View
Details

xml/Microsoft.ApplicationInsights.Extensibility.Implementation/CloudContext.xml
:bulb:Suggestion
n/a (file deleted or renamed)
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

xml/Azure.ResourceManager.DataBoxEdge.Models/EdgeIotRole.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Azure.ResourceManager.DataBoxEdge.Models.IotEdgeAgentInfo'.

xml/Azure.ResourceManager.DataBoxEdge/DataBoxEdgeRoleData.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Azure.ResourceManager.DataBoxEdge.Models.MecRole'.

xml/Azure.ResourceManager.DnsResolver/DnsResolverExtensions.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Azure.ResourceManager.DnsResolver.VirtualNetworkDnsResolverResource.CreateResourceIdentifier(System.String,System.String,System.String)'.

xml/Azure.ResourceManager.ServiceFabricManagedClusters/ServiceFabricManagedClusterData.xml

Line 0, Column 0: [Warning: file-not-found - See documentation] Invalid file link: './ClusterVersion.md'.

xml/Microsoft.ApplicationInsights.Extensibility.Implementation/CloudContext.xml

[Suggestion: file-not-redirected - See documentation] File xml/Microsoft.ApplicationInsights.Extensibility.Implementation/CloudContext.xml was deleted without redirection. To avoid broken links, add a redirection.
[Suggestion: file-not-redirected - See documentation] File xml/Microsoft.ApplicationInsights.Extensibility.Implementation/CloudContext.xml was deleted without redirection. To avoid broken links, add a redirection.
[Suggestion: file-not-redirected - See documentation] File xml/Microsoft.ApplicationInsights.Extensibility.Implementation/CloudContext.xml was deleted without redirection. To avoid broken links, add a redirection.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Frontend checks failing due to outdated packages

Describe the bug
We have frontend checks failing internally due to outdated packages:
00:21:52 ║ ID      │ Module │ Title                                              │ Paths                                              │ Sev. │ URL                                               │ Ex. ║
00:21:52 ║ 1097615 │ ws     │ ws affected by a DoS when handling a request with  │ @aws-amplify/core>ws                               │ high │ https://github.com/advisories/GHSA-3h5v-q93c-6h6q │ n   ║
00:21:52 ║         │        │ many HTTP headers                                  │ @aws-sdk/middleware-retry>ws                       │      │                                                   │     ║
00:21:52 ║         │        │                                                    │ @react-native-community/cli-server-api>ws          │      │                                                   │     ║
00:21:52 ║         │        │                                                    │ @react-native/dev-middleware>ws                    │      │                                                   │     ║
00:21:52 ║         │        │                                                    │ webpack-dev-server>ws                              │      │                                                   │     ║
00:21:52 ║         │        │                                                    │ ...and 1 more                                      │      │                                                   │     ║
00:21:52 ║ 1097616 │ ws     │ ws affected by a DoS when handling a request with  │ @aws-amplify/core>ws                               │ high │ https://github.com/advisories/GHSA-3h5v-q93c-6h6q │ n   ║
00:21:52 ║         │        │ many HTTP headers                                  │ @aws-sdk/middleware-retry>ws                       │      │                                                   │     ║
00:21:52 ║         │        │                                                    │ @react-native-community/cli-server-api>ws          │      │                                                   │     ║
00:21:52 ║         │        │                                                    │ @react-native/dev-middleware>ws                    │      │                                                   │     ║
00:21:52 ║         │        │                                                    │ webpack-dev-server>ws                              │      │                                                   │     ║
00:21:52 ║         │        │                                                    │ ...and 1 more                                      │      │                                                   │     ║
00:21:52 ║ 1097617 │ ws     │ ws affected by a DoS when handling a request with  │ @aws-amplify/core>ws                               │ high │ https://github.com/advisories/GHSA-3h5v-q93c-6h6q │ n   ║
00:21:52 ║         │        │ many HTTP headers                                  │ @aws-sdk/middleware-retry>ws                       │      │                                                   │     ║
00:21:52 ║         │        │                                                    │ @react-native-community/cli-server-api>ws          │      │                                                   │     ║
00:21:52 ║         │        │                                                    │ @react-native/dev-middleware>ws                    │      │                                                   │     ║
00:21:52 ║         │        │                                                    │ webpack-dev-server>ws

https://github.com/advisories/GHSA-3h5v-q93c-6h6q was published 3 days ago, so my guess is we dont have a fix for these yet which is what is causing the frontend checks to fail.
How to Reproduce
*P.S. Please do not attach files as it's considered a security risk. Add code snippets directly in the message body as much as possible.*

Run frontend checks
Expected behavior
No response
Your project
No response
Screenshots
No response
OS
Mac
Python version
3.8
AWS data.all version
2.5
Additional context
No response

Thanks @anushka-singh !
We will take care of it

@anushka-singh  in our current dependencies we use
"ws": "^6.2.3" or "ws": "^8.17.1"
which are listed as patched.
Could you please confirm, that the problem is still present?

After our most recent deploy of 2.6 on staging, we dont see any frontend related failures anymore. We can close this ticket.
Thanks @SofiaSazonova !


Cleaned up test_data input and output for notebook templates

Generated new output files for iSeqnormpool because we changed default behavior to normalized pooling on 'Raw Reads' and the previous output file was not reflecting this. Separated the test_ouput files for the matrix notebook and the legacy notebook (plate map based) because they were overwriting the same output file with small sample_name discrepancies that resulted in unstable changes to files in repository depending on which notebook was being run last before committing changes. Fixed a small issue with katharoseq barcodes being present in matrix tube template when we instead are trying to default to a metagenomic template with no katharoseq samples.

I actually deleted duplicated matrix tube barcodes from the blanks_1.tsv file (not sure how they got introduced in the first plate), and changed the tube_ids that were katharoseq related from the matrix_tube_plate_scan file (2022_summer_Celeste_Adaptation_21_plate_map.tsv) and replaced them with blank tube_ids that I found in the blanks_1.tsv file. I think that is a clean fix. If we want to add katharoseq test functionality in the future, the katharoseq_tube_ids.tsv file in the katharoseq directory should still hold the tube_ids that I replaced, and they would not be anywhere else.

I approve these changes, and, since they are all in the notebooks and their ad-hoc test files, I think it is low-risk to merge into master. @charles-cowart, are you on board with that?

Agreed it's low-risk so long as the users of the notebooks are in the loop.


Support NaN and Infinity in KBase

@MrCreosote  Can we add a specific example of where this is an issue?  I think that would be helpful.

I personally ran into this problem way back when I was working on the experimental stuff. BarSeq and TnSeq can have NaNs in the data set, IIRC. I remember @realmarcin had the same issue with some of his data as well, but I don't remember the context.

I assume this is regarding type specs? Or is it content in json objects? Perhaps both ...
In any case, this comes up in gene expression data which we handle in FeatureValue and RNAseq as NaN values correspond to no measurement for a gene in a given sample. This is notorious when analyzing multiple samples, especially for RNAseq but also other data types. In general its a way to represent 'no measurement' in biological data.
As for Infinitity, that can come up in tree distances, taking logs, p-value=0 -- but no immediate kbase bio examples I can think of (perhaps in the output of Sequence Search? perhaps the ratio creation steps in RNAseq?).

So can you draft up one concrete example to include in the user story section?

Sure, though I can't edit on this branch:
A user would like to upload and use a collection of RNAseq gene expression ratios as a FeatureValue matrix. Some of the genes were never observed in only certain samples, hence when creating comparisons between treatment and control samples those sample values and sample-to-sample ratios need to allow an NaN value corresponding to 'gene was not measured'. This is to distinguish from 0 values which would correspond to a actual measurement, would be included in normalization etc.

Great.  Gavin: Can you add this and then I can go ahead and merge it.

On May 25, 2016, at 4:29 PM, realmarcin<EMAIL_ADDRESS>wrote:
Sure, though I can't edit on this branch:
A user would like to upload and use a collection of RNAseq gene expression ratios as a FeatureValue matrix. Some of the genes were never observed in only certain samples, hence when creating comparisons between treatment and control samples those sample values and sample-to-sample ratios need to allow an NaN value corresponding to 'gene was not measured'. This is to distinguish from 0 values which would correspond to a actual measurement, would be included in normalization etc.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub https://github.com/kbase/roadmap/pull/81#issuecomment-221737685

@scanon done


Looking help

Thanks for your control. This is really helpful.
Now I am trying to implement this with Swift. I am not sure how do I use following property.
@property (nonatomic, copy) void (^selectButtonAction)(RMDateSelectionViewController *controller, NSDate *date);
Thanks in advance.

Hi, you can use it like follows:
func buttonTouched(sender:AnyObject) {
    let controller = RMDateSelectionViewController.dateSelectionController();

    controller.selectButtonAction = {(controller:RMDateSelectionViewController?, date:NSDate?) in
        //Do something here...
        NSLog("Selected date: %@", date!);
    }

    self.presentViewController(controller, animated: true, completion: nil);
}

Hope it helps :)


Won't animate with setOn method on iOS 12

Tickbox animation doesn't work on iOS 12 anymore

checkBox.setOn(true, animated: true)

Fixed in https://github.com/Boris-Em/BEMCheckBox/pull/90

Seems to be okay in the Swift version too :-) (#93)

Closed as fixed with https://github.com/Boris-Em/BEMCheckBox/pull/95.


Fixed the #bins error factor

I have made modifications to the compute_summary_data function to return a bin dependent summary data.

That is great news! I am not sure I understand the explanation you provided on slack, but I might when I am not sleepy tomorrow morning. Have you checked if the likelihood calculation is now consistent?

Yup. They match up to the second decimal.

Also, fdecb57 had a lot of code-style issues. Don't you have the pre-commit checks configured as per development instructions? I suggest you do this if you haven't.
Anyway, I have fixed the issues in 21f8326 using autopep8.

Nope. I need to figure that out.

If you are evaluating the likelihood for the fiducial parameters, then I guess it will match since waveform_ratio is 1 and a1 or b1 do not contribute to the calculation.
Yeah, but right after shifting the frequency_factor to second arguments the likelihood evaluations were off by duration**2 * 10^18or so


created quarry texture

https://github.com/voxel/voxel-quarry/issues/3
Here are the files, let me know what you think.
I'm not to sure how to incorporate them into this and then the voxel project, how would I go about doing that?

Looks good! Unfortunately, I'm not sure either how to incorporate into ProgrammerArt/voxel.js. I have another open issue to decide how to handle non-vanilla items/blocks: https://github.com/deathcap/ProgrammerArt/issues/13 'Mod' content support

Doesn't the new file layout work with mods? Why don't you just use it?


Update fansi to 0.4.0

The fansi dependency is not shaded so this is a small binary incompatible change. Without updating scalafmt-core has a binary compatiblity issue since it depends on sourcecode 0.3.0 through scalameta trees and on sourcecode 0.2.7 through fansi 0.3.0. Updating fansi fixes this incompatibility.

Looks like we should also bump Scala JS, we haven't kept the repo up to date much :thinking:

@tgodzik can you approve the pipeline again?

@tgodzik can you approve the pipeline again?

Done! Though it seems now to be failing on native :/  Most likely a bump is needed there too

It's finally green! Thanks for the patience to approve all the workflows 😄.
(Github should change how this works IMO, I've contributed many merged PRs to scalameta and I still need approve on every commit to run the CI)


Cannot return null for non-nullable field Subscription.count

The example for subscriptions on the website is not working. Trying to trigger subscriptions from either postman or the built-in graphiql web app results in the following error: Cannot return null for non-nullable field Subscription.count.
In fact, I'm unable to get any subscriptions working in my web app. I've created a fresh new project and pulled down a fresh copy of strawberry-graphql and sanic.
System Information

Operating system: Widows & Macos
Strawberry version: 0.193.1
Sanic version: 23.3.0

Additional Context

Below is the sample application I'm encountering this issue.
import asyncio
import strawberry
from typing import AsyncGenerator
from sanic import Sanic
from strawberry.sanic.views import GraphQLView

@strawberry.type
class Query:
    @strawberry.field
    def hello(self) -> str:
        return "world"

@strawberry.type
class Subscription:
    @strawberry.subscription
    async def count(self, target: int = 100) -> AsyncGenerator[int, None]:
        for i in range(target):
            yield i
            await asyncio.sleep(0.5)

schema = strawberry.Schema(query=Query, subscription=Subscription)

app = Sanic(__name__)
app.add_route(GraphQLView.as_view(schema=schema, graphiql=True), "/graphql")

# Launch Application
if __name__ == '__main__':

    # dev mode
    app.run(dev=True)

requirement.txt
aiofiles==23.1.0
graphql-core==3.2.3
html5tagger==1.3.0
httptools==0.5.0
multidict==6.0.4
python-dateutil==2.8.2
sanic==23.3.0
sanic-routing==22.8.0
six==1.16.0
strawberry-graphql==0.193.1
tracerite==1.1.0
typing_extensions==4.7.1
websockets==11.0.3

Submitting the following query:
subscription {
    count(target: 10)
}

Results in this error:
Cannot return null for non-nullable field Subscription.count.

@ndortega I think this is because we don't support websockets via sanic just yet

@patrick91
Ah, well that would make sense. In that case, would you recommend closing this and opening a new one or repurposing this current issue to cover support for sanic.

@ndortega I've updated the title! 😊


sudo docker is still the old docker

I installed the docker as described in the documentation and it seems it worked very well.
but I need to run a command using sudo .. and that runs docker (maybe using also sudo docker) .. but the docker reached is the old docker ... is there any workaround for this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e363794a-15bb-94f5-5a0f-021a5b068d2f
Version Independent ID: 262421e1-9598-fa0c-74f3-ad8baf56374e
Content: Docker Installer task - Azure Pipelines
Content Source: docs/pipelines/tasks/tool/docker-installer.md
Product: devops
Technology: devops-cicd
GitHub Login: @shashankbarsin
Microsoft Alias: shasb

@xmnlab  Thank you for the question.
Please try finding the location of the docker daemon and running it using the absolute path.
The code uses azure-pipelines-tool-lib/tool but I'm not familiar with .ts files.

hey @msebolt thanks for the feedback.
just to add more details: the command I am running is minikube start --vm-driver=none .. using --vm-driver=none needs sudo to run ... and internally it runs sudo docker ..
as it is a binary .. I cannot change this call .. as you can see in this example: https://github.com/kubernetes/minikube/blob/master/pkg/minikube/cruntime/docker.go#L87

@shashankbarsin any idea about this?

@shashankbarsin Any suggestions here?

Hi @msebolt,
I'm just following up on this since I'm having the same issue. Did you have a chance to look into it? I'm wondering if the DockerInstaller task shouldn't replace the existing docker (default path) to avoid this issue. Thoughts?
Thanks.


Aim bot doesn't work when the overly is disabled

the title

thanks for the report. I will investigate this.

Hi @Ca7-R1z, I'm unable to reproduce this issue. Aimbot appears to be working with the default config and  draw_overlay = "0";. Would you send more info about the config you are using (your settings file) and your OS?

Before you do that, make sure you have typed "bind mouse1 +alt2" in console.

Edit: it's not connected to the overly.
It seems very random for me but it happens when changing the settings many times.
here's this config that the aimbot doesn't work nor the ragemode
fov = "18";aim_smooth = "5";draw_overlay = "0";

I did a few minutes of testing at your settings, I couldn't get the aimbot to stop working. I'd like to mention, if you are using distance based fov with 5 smooth and 18 fov, you will usually instantly aim to the target because 5 degrees is,in most situations, larger than the 18 fov.
If you could go into detail about the problem that occurs and what you are doing just before it occurs, that would help me debug it.

Since the issue in the title is resolved, I'll close this. Feel free to open another issue if you have one.


[CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read

Describe the bug
When I try to sync a new folder with kubeconfig files LENS, nothing happens. In debug mode it show this error
[CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read
To Reproduce
Steps to reproduce the behavior:

Go to 'add cluster'
Click on 'Sync folder'
Select the folder
See error

Expected behavior
It should add the cluster to LENS
Environment (please complete the following information):

Lens Version: 5.3.3
OS: [macOS Monterey 12.1]
Installation method (e.g. snap or AppImage in Linux): DMG package

Logs:
error:   ▪ [CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read +1ms
info:    ▪ [STORE]: SAVING /Users//Library/Application Support/Lens/lens-user-store.json +9s
info:    ▪ [MENU]: navigating to /preferences +2m
info:    ▪ [WINDOW-MANAGER]: Main window has reported that it has loaded +54ms
info:    ┏ [KUBECONFIG-SYNC]: stopping sync of file/folder +4s
info:    ┗ [1] { filePath: '/Users//kube/AKSCADDEV' }
info:    ▪ [STORE]: SAVING /Users//Library/Application Support/Lens/lens-user-store.json +3ms
error:   ▪ [CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read +42ms
info:    ┏ [KUBECONFIG-SYNC]: stopping sync of file/folder +240ms
info:    ┗ [1] { filePath: '/Users/*****/kube/AKSCADPRO' }
info:    ▪ [STORE]: SAVING /Users//Library/Application Support/Lens/lens-user-store.json +2ms
error:   ▪ [CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read +46ms
info:    ┏ [KUBECONFIG-SYNC]: stopping sync of file/folder +90ms
info:    ┗ [1] { filePath: '/Users//kube/AKSEASSETSPRE' }
info:    ▪ [STORE]: SAVING /Users//Library/Application Support/Lens/lens-user-store.json +1ms
error:   ▪ [CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read +43ms
info:    ┏ [KUBECONFIG-SYNC]: stopping sync of file/folder +637ms
info:    ┗ [1] { filePath: '/Users//kube/AKSEASSETSPRO' }
info:    ▪ [STORE]: SAVING /Users//Library/Application Support/Lens/lens-user-store.json +1ms
error:   ▪ [CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read +46ms
info:    ┏ [KUBECONFIG-SYNC]: stopping sync of file/folder +590ms
info:    ┗ [1] { filePath: '/Users//kube/AWSCADPRE' }
info:    ▪ [STORE]: SAVING /Users//Library/Application Support/Lens/lens-user-store.json +2ms
error:   ▪ [CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read +46ms
info:    ┏ [KUBECONFIG-SYNC]: stopping sync of file/folder +664ms
info:    ┗ [1] { filePath: '/Users//kube/AWSCADPRO' }
info:    ▪ [STORE]: SAVING /Users//Library/Application Support/Lens/lens-user-store.json +1ms
error:   ▪ [CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read +42ms
info:    ┏ [KUBECONFIG-SYNC]: stopping sync of file/folder +564ms
info:    ┗ [1] { filePath: '/Users//kube/AWSEASSETSPRE' }
info:    ▪ [STORE]: SAVING /Users//Library/Application Support/Lens/lens-user-store.json +1ms
error:   ▪ [CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read +47ms
info:    ┏ [KUBECONFIG-SYNC]: stopping sync of file/folder +263ms
info:    ┗ [1] { filePath: '/Users//kube/AWSEASSETSPRO' }
info:    ▪ [STORE]: SAVING /Users//Library/Application Support/Lens/lens-user-store.json +1ms
error:   ▪ [CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read +44ms
info:    ┏ [KUBECONFIG-SYNC]: stopping sync of file/folder +597ms
info:    ┗ [1] { filePath: '/Users//kube/AKSASSETSLATAMPRO' }
info:    ▪ [STORE]: SAVING /Users//Library/Application Support/Lens/lens-user-store.json +1ms
error:   ▪ [CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read +46ms
info:    ┏ [KUBECONFIG-SYNC]: starting sync of file/folder +7s
info:    ┗ [1] { filePath: '/Users//kube/AWSCADPRE' }
info:    ▪ [STORE]: SAVING /Users/****/Library/Application Support/Lens/lens-user-store.json +1ms
error:   ▪ [CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read +44ms
error:   ▪ [CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read +31ms
info:    ┏ [KUBECONFIG-SYNC]: stopping sync of file/folder +19s
info:    ┗ [1] { filePath: '/Users//kube/AWSCADPRE' }
info:    ▪ [STORE]: SAVING /Users/****/Library/Application Support/Lens/lens-user-store.json +2ms
error:   ▪ [CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read +45ms
Your logs go here...

Finally the problem was the kubeconfig files.

Hi guillermobandres,
I ran into the same error - can you please provide information about the problem with your kubeconfig files?
Thanks a lot!

Hi, you have to add this part on config file
contexts:

context:
cluster: <cluster_name>
user: <user_name>
name:

Un saludo / Best regards
Guillermo Bandrés Magallón | Assets&Products
<EMAIL_ADDRESS>NTT DATA
Avenida de Juan Pablo II, 35, planta 5. 50009 Zaragoza
Leer más en: es.nttdata.com
[signature_910751466]
De: DanielMcKracken @.>
Fecha: lunes, 21 de febrero de 2022, 17:51
Para: lensapp/lens @.>
CC: Guillermo Bandres Magallon @.>, State change @.>
Asunto: Re: [lensapp/lens] [CLUSTER-MANAGER]: failed to add cluster: Error: EISDIR: illegal operation on a directory, read (Issue #4711)
NTT DATA Security Awareness - This is an incoming mail from an EXTERNAL DOMAIN. Please verify sender before you open attachments or access links.
Hi guillermobandres,
I ran into the same error - can you please provide information about the problem with your kubeconfig files?
Thanks a lot!
—
Reply to this email directly, view it on GitHubhttps://github.com/lensapp/lens/issues/4711#issuecomment-1047069578, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANANSAYU5GLTC5SSR6MP2ETU4JURLANCNFSM5MHOLLQA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you modified the open/close state.Message ID: @.***>

This email and any attachments are sent in strictest confidence for the sole use of the addressee and may contain legally privileged, confidential, and proprietary data. If you are not the intended recipient, please advise the sender by replying promptly to this email and then delete and destroy this email and any attachments without any further use, copying or forwarding.


No mouse control and keybord on y smartphone

Hi, i didn't have any mouse and keyboard control on my smartphone. Is there a option to change on it ?
I have an xiaomi pocophone
thank you
jonathan
Environment

OS: ubuntu
scrcpy version: last
installation method: [sudo install...
device model: xiaomi pocophone
Android version: [e.g. 10] 10

**Describe

https://github.com/Genymobile/scrcpy/issues/1392#issuecomment-629224380


Handle Multiple Number Groupings

Our Globalization Engineering team at PayPal found a bug that is affecting those in India. Since the number grouping "#,##,###" isn't supported, our team found it was necessary to put in a bit of time and development to support users in India. Please see Indian comma placement found under Wikipedia's Indian rupee.
The pull request includes code development and tests that supports (1) the Indian comma placement for the number grouping "#,##,###"; and (2) other future number groupings. The hope for (2) is that regardless of how absurd the number grouping might turn out, it will be supported in Google Closure.
Please contact me, John Vu at<EMAIL_ADDRESS>if you have any questions.
P.S. This is my first time contributing to an open-source project so please let me know if there's anything else I should do aside from your guidelines for contributing.

Hey @nanaze , based on @DuaneOBrien 's comment, are we good now?

I signed it!

Hi!  It looks like the CLA was signed - is there any ETA for when this PR will get merged into master?

I'm trying to work through the pull requests (doing the obvious and easy ones first).

@jvu   I don't see a CLA signed for jvu or PayPal under what account was it signed?

@concavelenz : I'm going to re-sign it. Please let me know if you still don't see it.

I signed it!

I signed it!

Ok, I verify the CLA has been recorded, now we can see about getting someone to review the change.

You're awesome @concavelenz :heartbeat:

@jvu One thing that would help speed things up is to get the PR into Google JS Style conformance. There are quite a few basic things (e.g., 80 col limit, spacing) that could be addressed now and save your reviewer time. Here's the style guide. The Closure linter should help.

LGTM

@mihnita , I'm scheduled for next sprint to work on this. After I abide to the style guide and the Closure linter that @joeltine set out, I can at least get done correctly.

You should be able to just run this to lint: https://github.com/google/closure-library/blob/master/scripts/ci/lint_pull_request.sh. If not, just use the same gjslint arguments.

Hey All,
My colleagues and I finally scheduled in this next sprint for me to get this done. I'll be starting on it today.
John

@joeltine , I see your lint_pull_request.sh is now part of the continous-integration. Danke!

Ugh ... there are some issues I've never made. :\
Oh well. I'll try to fix it.

I signed it!

According to https://travis-ci.org/google/closure-library/builds/79554451, the issue is unrelated to my changes. Do you have any suggestions for my next task?

Hmm, is this PR rebased on top of the current master?

Actually, NVM, I see you merged the latest. I really want to run the CI tests against this PR. I'll troubleshoot the issue.

In the meantime, you're going to need to squash all your commits down into 1.

@joeltine : I don't think I've ever done that before (squash all your commits down into 1). Are you implying that I should re-do my work again?

Nope: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html.

Thanks @joeltine ... I'll be learning quite a lot.

@joeltine : I think I did that correctly? First time squashing ... that was an odd one.

FYI: https://github.com/google/closure-library/pull/556 should fix the CI failure. Can you rebase on master to run the tests again?

@jvu I'm still seeing 17 commits for this PR. I should only see 1.

@joeltine : Sorry, I'm still new to this rebasing ... never done it before. At least you're telling me the goal, now I'm curious how to "get there."

@joeltine : Either we tried or I'm doing it wrong! https://travis-ci.org/google/closure-library/builds/79570092 :stuck_out_tongue_winking_eye:
Is there a way I can ping or talk to you online? I feel going back and forth might not be the best idea. However, if not, I can let you know what's concerning me. As of right now, I see the squash works great if the git history included my last number of commits. However, if it includes other commits (such as merging from upstream), I haven't seen a way to cherry pick my own commits into one commit.

Hey @joeltine & everyone else:
I talked with some of my colleagues to help me out. They don't know how to easily make it into one single commit due to the following reasons:
(1) My first commit was from August 20, 2014
(2) My repository has been pulling upstream changes throughout the time
(3) I'm getting noop when running git rebase -i
I'll continue to look at options on how to get my 17 commits down to 1 commit but I don't know the answer at the moment. Any insights from all of you will be great. Heck, maybe I need to rewrite my code in a new pull request?
@jvu

Yes, merging master over this period of time can making squashing difficult. You have options:

When you do the interactive rebase (-i), you can actually re-arrange your commits however you wish. I.e., delete the lines containing your commits and paste at the top of the history as a contiguous set. Then the "squash" instructions should work much more nicely.
Create a separate PR as you suggested.

Honestly, #2 is probably easiest at this point considering it's only 3 files. You could just create backups of the 3 files, force this branch to be equivalent to master, paste in your back ups, then --force push the branch. This would allow us to preserve the comment history in this PR.

Also had another suggestion from a co-worker. You can:

Create a new branch synced to latest master
From the new branch run

git checkout old-branch -- file1.js file2.js...

This will just cherry pick the files you need from this branch into a fresh one. Commit.
Do a git reset --hard in the old-branch to match the new clean branch.
--force push for this PR.

Thank you @joeltine , I'll try one of these options tomorrow at work! Really appreciate all of your help. :smiley:

Just FYI: I'll be out of office until Monday.
On a side note, I just took a closer look at your changes, and I think I'm going to need to do a more thorough review. There are a few stylistic things that stand out, and that subformatFixed method is a monolithic monster. It's hard to believe there can't be some improvements here.

Open to all suggestions @joeltine ! I haven't been able to clean up the code for a long time and I'd love to have my work assist the 1.252 billion people of India with my fix.

So apparently this closed when I did a force on my end. :\

@joeltine : Failure is due to something with selenium standalone server: https://travis-ci.org/google/closure-library/builds/79691329

Argh... I just found out that Sauce Labs doesn't work with Travis for PRs outside of the main repo :(. That's why it continues to fail.  I'll figure out what to do on Monday.
Note that due to security restrictions, the Sauce Labs addon is not available on pull request builds.

Sorry @joeltine for bugging you during your vacation. I appreciate your message. :)

Monday's the day. Let me know how I can help you since I'm allocated to get this done and moving. :)

I signed it!

Re: the CI failures, I've disabled the tests for external PRs in https://github.com/google/closure-library/pull/557. Can you rebase on to that change to get Travis green?

Finished initial pass. In general, I'm finding it difficult to read and understand this. I think it mostly has to do with 1) my general lack of experience with this i18n lib 2) it's doing too much all in the same method and 3) this problem seems to require (probably?) a brute force approach.
I think once the logic is broken up, it'll be easier. LMK when ready and I'll take another pass.

@joeltine : Thanks for the initial pass. I apologize for the lack of response due to other company's commitments today. I'll definitely look at it tomorrow and take in your feedback. I really appreciate it.

Alright. Just committed my latest code @joeltine . Feel free to have me elaborate more if necessary. I'm still trying to digest my beastly code!

Something's weird with the PR, there should only be 1 commit.

@joeltine , no, not weird. Just me trying to learn your process that you want me to wrap up all my sexy commits into one each time.

Wrapped it all for you: https://github.com/google/closure-library/commit/9b96aa147495656fd7af04bc60578d390947551e

Not quite, it should say 1 commit, not 22, if done correctly.

That commit is correct, but your master branch points to a child commit of it that merges in many more - hence why github still shows 22 commits in the PR.  To visualize this, try git log --graph --decorate --color master upstream/master (where upstream is whatever you named Google's remote) and see the extra lines all over the place.  What you need to do is to reset your master branch to it (git checkout master; git reset --hard 9b96a11 and then do git push --force origin master (where origin is whatever your fork's remote is named), which will allow you to rewind the branch on your own fork.
I'm assuming the mess is because you tried to push the squashed commit to your fork and it complained that github was ahead of your local commit so the push failed, and it recommended you pull first, which you did, and ended up re-merging everything.  The correct solution then is not to pull but to --force your push.  Since you don't have anybody downstream to cause problems to, rewriting your history is exactly what you want here.

Thanks @shicks and @joeltine for your comments. Yes, I'm still learning this and this is indeed a very new concept to me. I'll try it tomorrow with your suggestions.

@shicks : The second paragraph is exactly what happened to me. Before I read your message yesterday, I reverted my quash commit yesterday so I'm somewhat stuck now today. I'll try to figure out today and hopefully get this working again.

@joeltine and @shicks , that took a while but I believe I did it correctly. I copied my changed file again, force reset before the merge, did a rebase  These resources helped me out a bit more:

https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit
https://robots.thoughtbot.com/keeping-a-github-fork-updated
Running git push --force origin master instead of a pull after the merge via rebase

Yes, that's much better.  Thank you.

One a side note, I'd recommend compiling/linting before pushing new changes to this PR. Will help you iterate faster. Take a look at https://github.com/google/closure-library/blob/master/scripts/ci/compile_closure.sh for a command to compile.

@joeltine, I miss that step before I pushed it. I've been running gjslint --strict --jslint_error=all whenever I can.

@joeltine , just trying to write you the paragraph right now.

@joeltine : The error in the build doesn't clearly make any sense to me:
found   : (Array<string>|null)
required: Array<string>

What you originally told me to do was:
{!Array<string>}

I can run compile_closure in the future but if I don't understand, how would I even proceed?

You have a type mismatch. You're passing in a nullable parts and returning it, but the @return annotation requires that it be non-nullable.
Changing all your function params to non-nullable should fix it.

@joeltine : Hope that's better.

Much better! Thanks for sticking with it.
I don't know what's wrong with googlebot. I manually verified we have a CLA for @jvu with email<EMAIL_ADDRESS>Maybe you changed your account's email address?
I'll merge this now, and hopefully it sticks internally. Thanks again!

@joeltine : Thank you! I think the reason why Googlebot was going back and forth could be due to my merges. Thanks again for helping me through this entire process. The next I contribute to ANY open source project, I will keep in mind the high standards to help EVERYONE.


🐛 [Transmission] Add-on doesn't start.

Description
Add-on doesn't start. See error in attached logs.
Can be connected with https://github.com/linuxserver/docker-transmission/issues/239
Reproduction steps
1. Start add-on Transmission
2. Go to add-on journal log
3. See error
ERR transmission-daemon Error loading config file -- exiting. (/home/buildozer/aports/community/transmission/src/transmission-4.0.5/daemon/daemon.cc:914)
tail: invalid PID: ‘’

Addon Logs
[14:06:44] INFO: Your settings.json was checked and seems perfectly normal!
/etc/cont-init.d/32-nginx_ingress.sh: executing
/etc/cont-init.d/90-customUI.sh: executing
[14:06:45] INFO: Alternate UI enabled : transmission-web-control. If webui don't work, disable this option
/etc/cont-init.d/90-dns_set.sh: executing
[14:06:51] INFO: DNS SERVERS set to <IP_ADDRESS> <IP_ADDRESS>

Starting the upstream container

[migrations] started
[migrations] no migrations found
───────────────────────────────────────

      ██╗     ███████╗██╗ ██████╗
      ██║     ██╔════╝██║██╔═══██╗
      ██║     ███████╗██║██║   ██║
      ██║     ╚════██║██║██║   ██║
      ███████╗███████║██║╚██████╔╝
      ╚══════╝╚══════╝╚═╝ ╚═════╝

   Brought to you by linuxserver.io
───────────────────────────────────────

To support LSIO projects visit:
https://www.linuxserver.io/donate/

───────────────────────────────────────
GID/UID
───────────────────────────────────────

User UID:    0
User GID:    0
───────────────────────────────────────

[custom-init] No custom files found, skipping...
crond: crond (busybox 1.36.1) started, log level 8
[2024-03-13 14:06:52.342] ERR transmission-daemon Error loading config file -- exiting. (/home/buildozer/aports/community/transmission/src/transmission-4.0.5/daemon/daemon.cc:914)
tail: invalid PID: ‘’
[2024-03-13 14:06:53.576] ERR transmission-daemon Error loading config file -- exiting. (/home/buildozer/aports/community/transmission/src/transmission-4.0.5/daemon/daemon.cc:914)
tail: invalid PID: ‘’
[2024-03-13 14:06:54.751] ERR transmission-daemon Error loading config file -- exiting. (/home/buildozer/aports/community/transmission/src/transmission-4.0.5/daemon/daemon.cc:914)
tail: invalid PID: ‘’

Architecture
aarch64
OS
HAos

Hi, could you please post the addon log from the start (including the header) ? thanks!

Hi. Unfortunately I can't because it's too big and until that error everything is overwritten. But I guess I know what you want to see (correct me pls if I'm wrong)

...
Local Disks mounting...
... volume is a device by label
[15:07:22] INFO: Mounting volume of type ext4
[15:07:22] INFO: Success! volume mounted to /mnt/volume
/etc/cont-init.d/00-smb_mounts.sh: executing
/etc/cont-init.d/01-config.sh: executing
Updating folders
[15:07:22] INFO: UI selected : transmission-web-control
Creating config
[15:07:22] WARNING: If UI was changed, you need to clear browser cache for it to show in Ingress
Updating permissions
Incomplete dir set: /mnt/volume/torrents/incomplete
[15:07:22] INFO: User {MESSAGE} Pass set, authentification will be with user : <my login> and pass : <my pass>
/etc/cont-init.d/01-config_yaml.sh: executing
Setting permissions for the config.yaml directory
Load environment variables from /config/addons_config/transmission-ls/config.yaml if existing

If accessing the file with filebrowser it should be mapped to /homeassistant/addons_config/transmission-ls/config.yaml
---------------------------------------------------------
Wiki here on how to use : github.com/alexbelgium/hassio-addons/wiki/Add‐ons-feature-:-add-env-variables

... no env variables found, exiting
/etc/cont-init.d/01-custom_script.sh: executing
Execute /homeassistant/addons_config/transmission-ls/transmission-ls.sh if existing
Wiki here : github.com/alexbelgium/hassio-addons/wiki/Add-ons-feature-:-customisation
/etc/cont-init.d/19-json_repair.sh: executing
Checking settings.json format
[15:07:23] WARNING: alt-speed-down was missing from your settings.json, it was added with the default value 50
[15:07:23] WARNING: alt-speed-enabled was missing from your settings.json, it was added with the default value false
[15:07:23] WARNING: alt-speed-time-begin was missing from your settings.json, it was added with the default value 540
[15:07:23] WARNING: alt-speed-time-day was missing from your settings.json, it was added with the default value 127
[15:07:23] WARNING: alt-speed-time-enabled was missing from your settings.json, it was added with the default value false
[15:07:23] WARNING: alt-speed-time-end was missing from your settings.json, it was added with the default value 1020
[15:07:23] WARNING: alt-speed-up was missing from your settings.json, it was added with the default value 50
[15:07:23] WARNING: bind-address-ipv4 was missing from your settings.json, it was added with the default value <IP_ADDRESS>
[15:07:23] WARNING: bind-address-ipv6 was missing from your settings.json, it was added with the default value ::
[15:07:23] WARNING: blocklist-enabled was missing from your settings.json, it was added with the default value false
[15:07:23] WARNING: blocklist-url was missing from your settings.json, it was added with the default value http://www.example.com/blocklist

And yes. My settings.json is empty (and this can be the reason). I'm not sure if it was not empty before, never looked, but I'm absolutely sure that I didn't edit it manually.

Hi, could you please try to delete your transmission and transmission-ls folders that are located in /homeassistant/addons_config/ ? Thanks

Oh. I see your idea. I did a lil another trick. I couldn't remove that directories because I'd lost my seeding torrents. I renamed that directories, started addon so new directories were created. Then I stopped add-on, moved settings.json from new directory to the old one and renamed directoris back. After that I started addon and everything worked fine.
Thanks for your help! Without that I guess wouldn't managed to fix it.

great !!! Glad it worked !!! Thanks for the feedback

by any chance did you kept a version of the erroneous settings.json ? So I could check what was inside to automatically delete it if needed

It was absolutely empty inside. No contents. Even no brackets that must be in json.

Thanks!


[Snyk] Security upgrade webpack from 3.12.0 to 5.94.0

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):

package.json

⚠ Warning
Failed to update the package-lock.json, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Cross-site Scripting (XSS) SNYK-JS-WEBPACK-7840298
  688

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Cross-site Scripting (XSS)

Declining; duped in https://github.com/uConnect/combobo/pull/53


Rotated+uploaded pic not considered uploaded by custo picker

Steps:

Find an encyclopedia-worthy pic which needs to be rotated (ask me if you want some).
Start upload it.
At the caption step, rotate it to correct angle.
After upload, open the folder in the custom picker.
Custom picker shows already uploaded pictures with a Commons overlay icon. Problem: Pic does not have this overlay applied.

Ideally the app would insert the "already uploaded" info into the local database.

Tried replicating this by changing screen orientation to landscape from portrait at the caption step, it showed correctly for me then after upload is finished in custom picker. Anything I am missing here?

@srishti-R Do you mean it shows with the Commons logo icon at the bottom of the thumbnail? If not sure would you mind posting a screenshot and precise which pic you uploaded with rotation? Thanks! :-)

Here's the screen capture.
https://github.com/commons-app/apps-android-commons/assets/53987325/614ac2a8-aaaa-4c64-a0f9-1afd04a822b9

Sorry yes, you have to tap Edit image then Rotate, I will edit the description to make it unambiguous. Thanks! :-)

@nicolas-raoul I tried to attempt this by making LLJTran write the rotated bitmap to the source file instead of creating a separate file. Even when it does, the SHA of the image that is fetched from commons server tells the custom selector that the unrotated image is not the one that was uploaded. Is SHA stored on server dependent on bitmap or the file that was uploaded? If its bitmap, cant do much, since the bitmap was changed and not the file.

We have a local table containing SHA1 of uploaded files, which we use as a cache.
For this issue, it would be enough to just add the SHA1 of both unmodified and modified files to that local cache table.
This cache unfortunately disappears when reinstalling the app, but the solution proposed here is a lower-hanging fruit than the solution proposed at #5295, and probably good enough for most users.

Could you point me to the file where the local cache of SHA1s is present? All I could find out was the code that is checking if the image exists on server using APIs.

You mean we don't call insertUploaded to modify uploaded_table after uploading?

Hi @nicolas-raoul, I was able to reproduce this issue. Follow the steps, and you are correct, after rotating the image and saving it and when opening the folder in the custom picker, the Commons overlay icon on pic is not showing, despite being uploaded correctly. Assign it to me, and I will work on resolving this.

can you assign this issue to me, i think it is related to #5363 issue i just fixed

@mshdabiola Did you get a chance to check my feedback on your pull request at https://github.com/commons-app/apps-android-commons/pull/5569#pullrequestreview-1893148253 ? Thanks a lot! :-)

@mshdabiola  I unassign for now, but if you are you still working on this, please let us know. If no answer, someone else may be assigned to it. Thanks a lot. :-)