Fix/ac rate limiting

Description
AC seems to have introduced rate limiting, unfortunately without the usual retry-after return header. This works around the rate limiting, right now just waiting for 1s fix.
Additional information
The three added tests run 1s each due to the sleep, not sure if we should try to mock that out?
Checklist
Mark "not applicable" if item on the list does not apply to this pull request.

[x] I have created/adapted unit tests for new code

[ ] not applicable

[ ] I have added new dependencies as described at the Contributing page

[x] not applicable

[ ] I have made corresponding changes to the documentation (incl. tutorial, etc.)

[x] not applicable

[ ] I have provided release notes (in description or as comment) if this PR is a new feature OR a change worth mentioning for next release

[x] not applicable

[ ] I have obtained API approvals if a new SAP API or endpoint is used

[x] not applicable

Yes, I'd prefer to mock time.sleep for these specific tests. Adding these 3 seconds seems easily avoidable that way and it will not affect the aim of the test.


getAllDocsRequestBuilder getDocsAs returns docs that include null and deleted documents

Please read these guidelines before opening an issue.

Bug Description
getAllDocsRequestBuilder getDocsAs returns docs that include null and deleted documents, while getDocs returns docs not included null (not sure about the deleted documents). The implementation between getDocsAs and getDocs are different, so wondering if this is expected. If so, can you provide another method that will behave the same as getDocs that will not return non null or deleted documents.
1. Steps to reproduce and the simplest code sample possible to demonstrate the issue
Make sure that you pass the ids that not existed or deleted in the Cloudant database.
list = databaseSource.getAllDocsRequestBuilder().keys(uniqueIds.toArray(new String[uniqueIds.size()])).includeDocs(true).build()
                    .getResponse().getDocsAs(docType);

Calling this method, it will return all of the docs that matched the id even including the null document and deleted ones
Looking at the code, not sure if this was done on suppose, if so, can you create a method that we can get access to AllDocsRequestResponse.AllDocsValue so that we can filter out the null ones?
It seems like the getDocs method was implemented differently, so wondering why the difference?
getDocsAs implementation:
        @Override
        public <D> D getDocumentAsType(Class<D> docType) {
            D doc = super.getDocumentAsType(docType);
            if (doc == null) {
                // The doc could be deleted, or include docs might be false, we can try to generate
                // a sparse doc for these cases.
                AllDocsRequestResponse.AllDocsValue v = getValue();
                if (v != null) {
                    JsonObject sparse = new JsonObject();
                    sparse.addProperty("_id", getId());
                    sparse.addProperty("_rev", v.getRev());
                    sparse.addProperty("_deleted", v.isDeleted());
                    doc = gson.fromJson(sparse, docType);
                }
            }
            return doc;
        }

getDocs returns non-null documents and probably non-deleted ones as well...
    protected List<Document> internalGetDocs() {
        if (docs == null) {
            docs = new ArrayList<Document>();
            for (Row row : getRows()) {
                Document doc = row.getDocument();
                if(doc != null) {
                    docs.add(doc);
                }
            }
        }
        return docs;
    }

2. What you expected to happen
getDocsAs should only return the non-null document and non-deleted ones, or provide access to the AllDocsRequestResponse.AllDocsValue so that the client can do that.
3. What actually happened
getAllDocsRequestBuilder getDocsAs returns docs that include null and deleted documents.
Environment details

Version(s) that are affected by this issue.

2.13.0 (we are using this version, but seems there is no change in this code even in the latest version 2.19.2)

Java version including vendor and platform

1.8.0_151 OpenJDK macOS

Using the optional okhttp dependency.

No

Hi @josephine-zhuang, when you say null document do you mean a document with only an _id and _rev?
We have a comment in our javadoc.io documentation under the interface AllDocsResponse about the inclusion of deleted documents when using keys for both getDocsAs and getDocs:

If interested, this is the closed issue related to the work for including deleted documents.
A couple of options for handling deleted docs:

Are you looping or streaming through the getDocsAs in your application? You can use Java streams API to filter and collect documents that do not contain the _deleted field.
Create a view with an if block that only returns documents that are not deleted.  You can use the getViewRequestBuilder for querying views.

If you're new to using java-cloudant, I'd recommend using our new beta cloudant-java-sdk library which will get the latest features and updates.
We also include documentation with a code example for just about every Cloudant endpoint.  For example, the _all_docs endpoint: https://cloud.ibm.com/apidocs/cloudant?code=java#postalldocs

@emlaver

Hi @josephine-zhuang, when you say null document do you mean a document with only an _id and _rev?

No, the document itself is null... so my workaround was to loop the result of getDocsAs to exclude the null document...
        list = list.stream().filter(document -> document != null)
                .collect(Collectors.toList());

Are you looping or streaming through the getDocsAs in your application? You can use Java streams API to filter and collect documents that do not contain the _deleted field.

Yes, this was going to be my workaround, however, I am using this method for multiple POJO objects, and currently none of them have the field _deleted exists in POJO objects, so I would need to add it to all of the POJO objects.

Create a view with an if block that only returns documents that are not deleted. You can use the getViewRequestBuilder for querying views.

It is good that you brought this up, in getViewRequestBuilder, you have access to the actual ViewResponse as the response, therefore can get to the response.getRows(), is it possible for getAllDocsRequestBuilder to actually return a response similar to getViewRequestBuilder where I can get access to the actual rows? This way, we can decide what to do with the documents ourselves.

If you're new to using java-cloudant, I'd recommend using our new beta cloudant-java-sdk library which will get the latest features and updates.

Unfortunately, we are using java-cloudant in our code for the past 3 years, so it is not possible to migrate to cloudant-java-sdk library at this time.

No, the document itself is null... so my workaround was to loop the result of getDocsAs to exclude the null document...

Ok, so it sounds like one or more of the document ID strings you pass to keys are for non-existing documents.  I'm guessing these doc IDs are for documents that existed at one point?

Yes, this was going to be my workaround, however, I am using this method for multiple POJO objects, and currently none of them have the field _deleted exists in POJO objects, so I would need to add it to all of the POJO objects.

This might be inefficient depending on how many documents you have but you could get the _all_docs result as List<JsonObject> (JsonObject from gson library) and have a loop to skip null/deleted documents and serialize the documents you want into your POJO.

It is good that you brought this up, in getViewRequestBuilder, you have access to the actual ViewResponse as the response, therefore can get to the response.getRows(), is it possible for getAllDocsRequestBuilder to actually return a response similar to getViewRequestBuilder where I can get access to the actual rows? This way, we can decide what to do with the documents ourselves.

Your options for getting documents in the response of getAllDocsRequestBuilder are getDocs and getDocsAs.  If you want to use getRows then you'll have to query a view.
You could use our client.executeRequest. It could look something like:
Database myDb = client.database("<your-db>", false);
HttpConnection response = client.executeRequest(Http.GET(
           new URL(myDb.getDBUri().toString() + "/_all_docs?include_docs=true&keys=...")));
// Use try-with-resources or try/finally to ensure stream is closed after use
try (InputStream inputStream = response.responseAsInputStream()) {
     // convert stream to POJO
}

You can use Java streams API to filter and collect documents that do not contain the _deleted field.

currently none of them have the field _deleted exists in POJO objects, so I would need to add it to all of the POJO objects.

I think you can just take advantage of the Document metadata that is already available to you from getDocs() so that you don't need to add the deleted field to your POJOs, e.g.
// Do the all docs request
AllDocsResponse response = databaseSource.getAllDocsRequestBuilder().keys(uniqueIds.toArray(new String[uniqueIds.size()])).includeDocs(true).build()
        .getResponse();

// Use getDocs to find the list of undeleted doc ids
List<String> undeletedDocIds = response.getDocs().stream().filter(doc -> {return !doc.isDeleted();}).map(Document::getId).collect(Collectors.toList());
// Use the undeleted list to filter getDocsAs
list = response.getDocsAs(docType).stream().filter(doc -> {return undeletedDocIds.contains(doc.getId());}).collect(Collectors.toList());

@emlaver @ricellis
Thank you both for your responses. I will try out the suggestion from @ricellis first. If that doesn't work, then I will try to build the request on my own using client.executeRequest.


Enable warnings as errors for analysis tools

This issue is related to #2367 and should be done after configuring hierarchical rules for the repo and adhered current code to the standard.

@axelsrz , this seems to be a duplicate of #4061. Unless this item is meant for a specific project not addressed there. Please advise.


Media upload via Admin

Question
Hello, when uploading an image of my shop via the admin, the image is not allowed to be displayed correctly.
The image is created in the CDN storage. If the link of the picture is copied in the admin, this is exactly the path to the picture in the CDN. This structure is correct. However, when I call up this link, I get a 404: No route found for "GET /media/6b/d9/36/1626943107/listing.png
Images that have been uploaded to via FTP can be successfully accessed via your link.

Sounds like you have not correctly set the domains. Would you please check them?

I checked the domains again and I don't see any errors here. The origin url is correct, and Hostname is okay too.
The link does not work for an image that was uploaded via the admin. If I adapt the path behind the domain to an image that was created via the FTP import, I can access this image.
I also checked the shopware.yaml file again.

admin imported image, image path in ftp correct, image not visible
https://myproject.b-cdn.net/media/56/fe/29/1626954295/2560x2560.jpg
ftp imported image, image path in ftp correct, image visible
https://myproject.b-cdn.net/media/f1/48/28/1620395992/testing.jpg
If i check in bunny.net the path of admin imported file, i can see the image in preview by hovering over over the file. Copy link of file, the link doesnt returns the image.

"Domain suspended or not configured". :-(
Please check your config and use the "test"-button in plugin config.

Hey,
I am closing this as the issue is stale. Feel free to write again when you checked your credentials in your shop.


images10.png

I hope you like it.
please merge/add my file to your repository with the label hacktoberfest. Happy Hacktoberfest-2022 bro 🎉

Closing; this PR doesn't address any issue.


Create app skeleton with registration/login feature

@PetrPoling @trnvdn please review.

@saryyyyy Please to re-review.


HOPS-123

Guard against null data
https://hopshadoop.atlassian.net/browse/HOPS-123

Can one of the admins verify this patch?

Closed. Opened a new PR by @smkniazi


Chatbot without text to speech

It seems as though most of my problems installing this submod are from the text-to-speech feature, could you provide a tutorial/separate download for just the chatbot? I also worry my laptop wont be able to handle so much, and I generally leave the volume off anyway. Downloading only the chatbot would likely make installing this much easier and give access to other people who aren't particularly good at coding too.

You can use only the chatbot since the beginning, just don't check Yes for TTS related options

"check yes"? I'm not sure what you mean, where would I "check" yes or no? I haven't seen anything like that in the code. I suppose what I'm asking is, could you provide a more detailed tutorial, or one on how to install/set it up manually?


Move test scripts into ocdata

closed due to error PR on multiple things, will reopen separate PR's


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

this is my work


Fix consistency of GradientTexture changes

Gradient texture queues an update when a property changes, EXCEPT in set_gradient() in GradientTexture2D, which calls the update immediately and emits the changed signal twice. Another weird thing is that gradient texture changes would queue the update and the changed signal would be emitted in the _update() method. That's not how this signal works.
This PR removes the inconsistency and _queue_update() is now called for every change, but the deferred emit_changed() is removed. Instead the signal is emitted right in the setter. I also added a public (not exposed) method update_now(), which forces the pending texture update to be done right now. It's automatically called when you attempt to get the image.

EXCEPT in set_gradient() in GradientTexture2D

Just for future readers, this except comes from https://github.com/godotengine/godot/pull/60361.

The interesting part is that this change wasn't done in GradientTexture1D.

Thanks!

Yes.

This PR removes the inconsistency and _queue_update() is now called for every change

Some leftovers (for whatever reason it's connecting to GradientTexture1D::_update instead of GradientTexture1D::_queue_update):
https://github.com/godotengine/godot/blob/bc88dca176cef6b8943ded58c68a60f7c127baea/scene/resources/gradient_texture.cpp#L66-L72


fix: support CI address for vault

What this PR does: We've had this addressCI in our box config for ever, but never exposed it. Now we do. 🎉

Pull Request Test Coverage Report for Build 9fee576e-e26e-4bc3-8400-3e05e9e9c472

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 54.419%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/box/fetch.go
0
3
0.0%

Totals

Change from base Build 6118a119-87cb-4126-b9e8-ec4d1c7a5fbf:
-0.04%

Covered Lines:
2081

Relevant Lines:
3824

💛  - Coveralls


Provide a second more advanced Helm sample values.yaml

The chart is very flexible, which makes it possible to deploy Console even in a heavily customized fashion. We are using Helm's tpl function, we ask users to use the variables in a more flexible way if they want to bring their own, existing secrets.
This flexibility comes at the cost of a higher complexity when writing the values.yaml file. Therefore we should provide a second values.yaml example that shows a more advanced configuration including:

Mutual TLS
Using the tpl functions for topologySpreadConstraints
How to bring your own secrets

cc @joejulian
JIRA Link: K8S-15

Closing due to age and inactivity. Feel free to re-open.


Missing style guide

The style guide mentioned in
https://github.com/docker/docker.github.io#style-guide
is missing. The link redirects to
https://docs.docker.com/opensource/doc-style/
which doesn't seem to exist in the source repo, so it defaults to
https://docs.docker.com/opensource/
This issue may be considered related to #5412, where the problem is in the TOC (here this issue refers to the repo README.md), but I'm filing a separate issue because my main interest is to find where the style guide is located.

The style guide seems to be removed in #5232 (the document can be viewed in its corresponding commit).
Has the style guide been moved to Moby? It's contributing guide also references the same missing link:
https://docs.docker.com/opensource/doc-style
Can I still consider the deleted style guide the most up-to-date reference?

@schomatis We don't have a particular style guide to recommend right now; we'll have to do some thinking and decide what guidance to provide in the future.


Unexpected migration occurs when executing supabase db diff --local --schema storage --use-migra -f {name}

I always use the local dev server to develop. And I also create storage policies locally.
When I prepare to deploy these policies to the remote server.
I executed the following command to generate a migration file for storage policies.
supabase db diff --local --schema storage --use-migra -f {name}
And the output includes some functions that were created by Supabase not myself.
set check_function_bodies = off;

CREATE OR REPLACE FUNCTION storage.extension(name text)
 RETURNS text
 LANGUAGE plpgsql
AS $function$
DECLARE
_parts text[];
_filename text;
BEGIN
    select string_to_array(name, '/') into _parts;
    select _parts[array_length(_parts,1)] into _filename;
    -- @todo return the last part instead of 2
    return split_part(_filename, '.', 2);
END
$function$
;

CREATE OR REPLACE FUNCTION storage.filename(name text)
 RETURNS text
 LANGUAGE plpgsql
AS $function$
DECLARE
_parts text[];
BEGIN
    select string_to_array(name, '/') into _parts;
    return _parts[array_length(_parts,1)];
END
$function$
;

CREATE OR REPLACE FUNCTION storage.foldername(name text)
 RETURNS text[]
 LANGUAGE plpgsql
AS $function$
DECLARE
_parts text[];
BEGIN
    select string_to_array(name, '/') into _parts;
    return _parts[1:array_length(_parts,1)-1];
END
$function$
;

I guess if I run migrations and replace these functions it may cause some issues even if I don't change any logic. (Such as if Supabase official will change these functions' logic someday)
I am also curious as to why only extension, filename and foldername these three functions should be migrated.
Other functions and tables under the storage schema won't be included in the migration file.
Is it caused by permissions?
I know I can remove them from the migration file by myself.
But next time I run the command to generate another migration file for storage policies update. These three functions will be included in the new migration file again.
Therefore I think remove them by myself may not be a good solution.
To Reproduce

run supabase db diff --local --schema storage --use-migra -f {name}
check the migration file

Expected behavior
The generated migration file doesn't include extension, filename and foldername functions
System information

Version of OS: Mac OS 14.4.1
Version of CLI: v1.165.0
Version of Docker: v26.0.0
Versions of services:
supabase/postgres      │ <IP_ADDRESS>            │ -
supabase/gotrue        │ v2.149.0             │ -
postgrest/postgrest    │ v12.0.1              │ -
supabase/realtime      │ v2.28.32             │ -
supabase/storage-api   │ v1.0.6               │ -
supabase/edge-runtime  │ v1.45.2              │ -
supabase/studio        │ 20240422-5cf8f30     │ -
supabase/postgres-meta │ v0.80.0              │ -
supabase/logflare      │ 1.4.0                │ -
bitnami/pgbouncer      │ 1.20.1-debian-11-r39 │ -
darthsim/imgproxy      │ v3.8.0               │ -

This is quite strange indeed because I can't reproduce this on a fresh local project. The steps I took

supabase init
supabase start
go to http://localhost:54323/project/default/storage/policies and add bucket and object policies
supabase db diff --local --schema storage

Diffing schemas: storage
Finished supabase db diff on branch develop.

create policy "Enable read access for all users"
on "storage"."buckets"
as permissive
for select
to public
using (true);

create policy "Enable read access for all users"
on "storage"."objects"
as permissive
for select
to public
using (true);

Output only contains the changed policies and not other functions.

If you are still running into this error, try supabase db reset to remove any potential changes to storage schema on local database.


Workflow step does not complete; sits there and times out.

Summary
Leveraging Argo Workflow to standup the entire application/services cluster infra;  as step 1 using EKSCTL to create a cluster. However the workflow step just sits there and times out; this is despite the fact that EKS cluster does get created OK but other bits pertaining to service account does not get triggered or completed (including nodegroups). The command also doesnt complete and workflow just times out after 1 hour
Diagnostics
What Kubernetes provider are you using?
1.18
What version of Argo Workflows are you running?
latest
Paste a workflow that reproduces the bug, including status:
kubectl get wf -o yaml ${workflow}

name: create-cluster
container:
image: weaveworks/eksctl:0.36.0-rc.0
command: ["/bin/sh"]
args: ["-c", "eksctl create cluster -f /mnt/vol/src/eks/cluster-id-cluster.yaml"]
volumeMounts:                     # same syntax as k8s Pod spec

name: workdir
mountPath: /mnt/vol

Paste the logs from the workflow controller:
kubectl logs -n argo $(kubectl get pods -l app=workflow-controller -n argo -o name) | grep ${workflow}

[ℹ]  eksctl version 0.36.0-rc.0
[ℹ]  using region us-east-1
[ℹ]  subnets for us-east-1a - public:x.x.x.x/19 private:x.x.x.x/19
[ℹ]  subnets for us-east-1b - public:x.x.x.x/19 private:x.x.x.x/19
[ℹ]  subnets for us-east-1c - public:x.x.x.x/19 private:x.x.x.x/19
[ℹ]  using Kubernetes version 1.18
[ℹ]  creating EKS cluster "eks-apps" in "us-east-x" region with
[ℹ]  will create a CloudFormation stack for cluster itself and 0 nodegroup stack(s)
[ℹ]  will create a CloudFormation stack for cluster itself and 0 managed nodegroup stack(s)
[ℹ]  if you encounter any issues, check CloudFormation console or try 'eksctl utils describe-stacks --region=us-east-x --cluster=cluster-id'
[ℹ]  CloudWatch logging will not be enabled for cluster "eks-apps" in "us-east-x"
[ℹ]  you can enable it with 'eksctl utils update-cluster-logging --enable-types={SPECIFY-YOUR-LOG-TYPES-HERE (e.g. all)} --region=us-east-x --cluster=cluster-id'
[ℹ]  Kubernetes API endpoint access will use provided values {publicAccess=true, privateAccess=true} for cluster "cluster-id" in "us-east-x"
[ℹ]  2 sequential tasks: { create cluster control plane "cluster-id", 2 sequential sub-tasks: { 5 sequential sub-tasks: { update cluster VPC endpoint access configuration, update public access CIDRs, associate IAM OIDC provider, 2 sequential sub-tasks: { create IAM role for serviceaccount "kube-system/aws-node", create serviceaccount "kube-system/aws-node" }, restart daemonset "kube-system/aws-node" }, create addons } }
[ℹ]  building cluster stack "eksctl-cluster-id-cluster"
[ℹ]  deploying stack "eksctl-cluster-id-cluster"

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

For anyone else who may run into this issue; nothing to do Argo Workflow or EKSCTL;  it had to do with the following snippet in cluster creation; Had to add the NAT EIP of the EC2 instance where the workflow was running from
vpc:
  clusterEndpoints:
    privateAccess: true
    publicAccess: true
  publicAccessCIDRs:
    - x.x.x.x/32
    - y.y.y.y/32
      #

For anyone else who may run into this issue; nothing to do Argo Workflow or EKSCTL;  it had to do with the following snippet in cluster creation; Had to add the NAT EIP of the EC2 instance where the workflow was running from
vpc:
  clusterEndpoints:
    privateAccess: true
    publicAccess: true
  publicAccessCIDRs:
    - x.x.x.x/32
    - y.y.y.y/32
      #


ADR-4 Proposal: alternate character encodings in headers

NATS users may want to send header keys and values other in encodings other than ASCII.  This is especially popular in languages other than English.
Highlight that header key/value encodings that are backward-compatible with ASCII can optionally be offered by NATS Clients.
Allow clients to select UTF-8 as their default encoding, and annotate that UTF-8 is the preferred character encoding.
Understandably, client implementations may rely on HTTP header parsing libraries that enforce ASCII.  For this reason, and also for backward compatibility reasons, ASCII should remain a valid default encoding option.

As it turns out, nats.go already partially supports UTF-8, at least in the Header Values:

So are we talking about the client encoding as it puts the key/value into the headers (and then across the wire).
For instance if the user presents z Ḁ Ḃ Ḉ x as the actual value, we actually store/transfer it as \u007a\u0020\u1e00\u0020\u1e02\u0020\u1e08\u0020\u0078 and that somewhere in our headers handling, the user can tell us to do this encoding?

@scottf correct, this is to determine how to Encode Header key/value strings -> byte[] on the wire when sending a message, and Decode Header key/value byte[] -> string off the wire when parsing a message

So that's encoded to ascii, similar to json/url encoding. Java built in string conversion to bytes allows for an encoding such as UTF-8, but for instance these are the actual 15 bytes 122 32 -31 -72 -128 32 -31 -72 -126 32 -31 -72 -120 32 120 it makes for that string, so it's really just double(?) byte, so just making sure that is not what we want.

UTF-8 is variable length encoding, between 1-4 bytes per character.  So the []byte count may not be equal to the character count, the header payload length would need to be the encoded bytes length.

Am not opposed to providing additional encodings but imo the default should be ASCII, which all clients would need to support.  This would allow NATS to better facilitate direct interop with HTTP, gRPC, etc and is the lowest common denominator across languages, tooling, browsers, etc.  Could expand to support RFC 2047 (MIME) as in ISO-8859-1 (https://www.w3schools.com/charsets/ref_html_8859.asp). Is there a specific use case driving the proposal?
More on this here:  https://www.jmix.io/blog/utf-8-in-http-headers/

The reason for wanting UTF-8 to be the preferred default is it would allow for much broader character support out-of-the-box in headers while maintaining byte-for-byte compatibility with ASCII if only ASCII characters are in-use.
string in most programming languages supports Unicode.  It seems like a very limiting practice to allow the user to create a header collection of Dictionary<string, string[]> with full Unicode support, but then limit that down to just 128 ASCII characters.
If folks want to interop with HTTP that is fine, just don't use any non-ASCII characters, and UTF-8 will encode the to the exact same thing as ASCII.

1 to provide for optional encoding, but I think default should be restricted as currently defined, not even UTF-8. The caveat being that if we provide a way to optional encode in one client, this really becomes a parity item that all clients must provide optional encoding.

The reason for the keys to be ASCII is because that is the HTTP and MIME header specification.
one question on this is whether this is customer driven or we just want to be able to support it. The main issue as Scott points out, the minute that a client writes one of these encoded things, client parity for all clients becomes an issue.

I would think that this is pretty rare use case, especially that NATS headers are perceived as being pretty close to HTTP headers.
Not being actually HTTP header spec compatible already caused problems in quite a few languages that wanted to reuse really well optimized and tested http headers libraries, but couldn't (as our NATS headers for JS/KV/ObjectStore are required to be sent case-sensitive to the server).
This change could make things harder.
I see one more reason: as we're having some ideas around nice NATS microservices tooling, connectors and more, straying further from HTTP headers spec could bring even more problems.
I think the simplest solution is to just suggest users to keep Keys according to HTTP headers spec, which should not be a big issue, and if they need non-asci values, just base64 them.

I don't think it is that rare of a use case, say an app wants to pass around X-User-Name and someone's name is in a different language not covered by ASCII.
But upon further reading of the spec, it seems that optional encoding for field values.  Excerpt from RFC9110 for Field Values:

Field values are usually constrained to the range of US-ASCII characters [USASCII]. Fields needing a greater range of characters can use an encoding, such as the one defined in [RFC8187].

So maybe this isn't even needed then, it is already laid out in the spec.  ASCII should probably be the default, but clients "can use an encoding"


realSR_BSRGAN_DFO x2 pth model structure

Hi, thanks for your nice work and nice code.
I have little issue about using pre-trained model. I'm tring to use 003_realSR_BSRGAN_DFO_s64w8_SwinIR-M_x2_GAN-with-dict-keys-params-and-params_ema.pth file.
But there is no test code for BSRGAN x2 file in SwinIR and KAIR github. And SwinIR only support x4 for BSRGAN setting.
https://github.com/cszn/KAIR/blob/88164a013c9e393a379744f13a22b90839d1a2ef/models/network_swinir.py#L752
I think using
model = net(upscale=args.scale, in_chans=3, img_size=64, window_size=8,
img_range=1., depths=[6, 6, 6, 6, 6, 6], embed_dim=180, num_heads=[6, 6, 6, 6, 6, 6],
mlp_ratio=2, upsampler='nearest+conv', resi_connection='1conv')
for model define and
removing https://github.com/cszn/KAIR/blob/88164a013c9e393a379744f13a22b90839d1a2ef/models/network_swinir.py#L756 and https://github.com/cszn/KAIR/blob/88164a013c9e393a379744f13a22b90839d1a2ef/models/network_swinir.py#L829 line will work.
Is it right way to use realSR_BSRGAN_DFO x2 pth file?

We haven't updated KAIR yet.  Please use the codes here https://github.com/JingyunLiang/SwinIR/blob/main/main_test_swinir.py.


Set the Guid of the Virtual Entity

Please can you add some comment about setting the Primary Key field of the Entity. In the RetrieveMultiplePlugin.cs is see this example:
Your Example:
Entity e = new Entity("new_ticket");
e.Attributes.Add("new_ticketid", reader.GetGuid(0));
My First Example:
I normally set the ID field like this:
Entity e = new Entity("new_ticket", reader.GetGuid(0));
Or like this:
My Second Example:
Entity e = new Entity("new_ticket");
e.Id = reader.GetGuid(0);
Normally in a plugin all three examples give the same result. But with a Virtual Entity only the first one works.
It took me a while the solve this issue. Please make this clear in the documentation.
Error I got:  Create privilege violation encountered

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: edbeb418-f5d9-da8d-7598-d4965f666e50
Version Independent ID: f28b539d-69f1-5f2e-6f32-4248cb96eedf
Content: Sample: Custom virtual table provider with CRUD operations (Microsoft Dataverse) - Power Apps
Content Source: powerapps-docs/developer/data-platform/virtual-entities/sample-ve-provider-crud-operations.md
Service: powerapps
GitHub Login: @Nkrb
Microsoft Alias: nabuthuk

@Miesjh Thanks for reaching to us. We will update the docs accordingly. Will update the issue once we publish the docs live.


add workflow

This is supposed to trigger a preview deployment whenever there's a PR that updates the docs. Only way to test it is to merge it and make a PR with an innocuous change

preview: https://svelte-dev-git-preview-clisveltejsdocs-preview-create-request-svelte.vercel.app/
this is an automated message

Hmm. The actual URL is this https://svelte-dev-git-preview-clisveltejsdocs-preview-cr-c42404-svelte.vercel.app/
Back to the drawing board

preview: https://svelte-dev-git-preview-cli-264-svelte.vercel.app/
this is an automated message


Helm Project Operator isn't aware on existing project member

As described in RBAC section the operator watches for changes on project member to apply RoleBindings on release namespace.
This works pretty good, but what are with existing project members if the Operator is installed afterwards?
Workaround would be to remove member from the project list and re-add them to get permissions.
Another workaround would be a change of the ProjectRoleTemplateBinding object for a specific user, which triggers also the Operator to do things.
The question are:  how to handle existing user? Is there already a way in the Operator? A better workaround would be fine to handle, let's say, 2000 users in 500 projects.
thx!

Just so I understand the context, have you tested this out with existing project members if the Operator is installed afterwards?
The operator should pick up existing members on a fresh install since creating or modifying the Project Registration Namespace should trigger recreating all the operator-managed role bindings for all users with RoleBindings in that namespace based on https://github.com/rancher/helm-project-operator/blob/c573121b61184b92f040a850d8e7321602ead02a/pkg/controllers/project/controller.go#L283-L294


fix label shorthands

Description
First pull request, please be kind, I'd like to learn. :)
Fixes #1808
I fixed the xlabel!, ylabel! and zlabel shorthands as described in #1808. However, tests fail on precompilation LoadError: UndefVarError: Axis not defined. This makes sense, but I still would like to dispatch on the Axis and Figure Makie types. How can I improve this?
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist

[x] Added or changed relevant sections in the documentation

I'm still wondering if we need these functions. They exist because Scene didn't have xlabel etc attributes, so they needed to use setter functions. However, Axis and Axis3 do have such attributes so having the setters is a duplication of API. However, as long as the methods for Scene exist, users might be confused why they don't work for Axis and Axis3. I don't know the best way around it, but I do feel that it's also confusing if some arbitrary attributes have setter functions that do nothing special and the rest don't.

I'm still wondering if we need these functions. They exist because Scene didn't have xlabel etc attributes, so they needed to use setter functions. However, Axis and Axis3 do have such attributes so having the setters is a duplication of API.

So some options would be:

Remove all setter functions that modify accessible axis attributes like xlims!, and replace them with the lengthier notation ax = current_axis(); ax.limits.val= (0, 10, ax.limits[][2]) notation. xlabel! would be a bit easier as ax = current_axis(); ax.xlabel = "string".
Add setter functions for the majority of the axis attributes to keep the interface constant. This would duplicate some API but would not require user knowledge about the inner attribute structure of Makie. From a non-developer point of view, it is completely arbitrary why ax.xlabel =  should work while ax.xlims =  shouldn't.

Yes but xlims and hidedecorations to not have direct correspondences to attributes. That's the main difference, why should all the other attributes not have functions to set them?

I mean its really up to you @jkrumbiegel. If you don't like Makie having multiple ways to accomplish the same task, here's another idea.

Scrap this PR. Open a new PR where we:
Add a note in the docstring for xlabel! that the function is depreciated, and to use ax.xlabel =  instead.
Throw a warning when a user attempts to use ax.xlims, saying to use xlims! instead because the attribute does not exist.
(optional) Change the plot limits from being held in ax.limits to being held in ax.xlims, ax.ylims, ax.zlims. That way xlims has a direct correspondence to an attribute.

why should all the other attributes not have functions to set them?

I'd say they should, at least the common ones. And I think grouping them like this would be good to avoid having a million setter functions.
xlabel!(ax[, str][; visible, font, fontsize, color, padding, text = str])

Making more useful setters that do multiple things at once is a different thing I'd say, could be useful.

That's kind of in the same vein as hidedecorations


Properties of User Stores doc not in APIM

Description:
[1] points to [2]. This content in the admin guide should be evaluated and moved to the APIM docs.
[1] https://apim.docs.wso2.com/en/latest/administer/managing-users-and-roles/managing-user-stores/configuring-secondary-user-stores.md
[2] https://docs.wso2.com/display/ADMIN44x/Working+with+Properties+of+User+Stores

@pubudu538  , is it ok to move this content as is it to the API-M docs OR has the configuration changed now.

These configs are still valid. We can move those here. https://apim.docs.wso2.com/en/next/administer/managing-users-and-roles/managing-user-stores/configure-primary-user-store/configuring-a-jdbc-user-store/#configuring-a-jdbc-user-store

@ruthryi , move the mentioned page to the APIM docs.

Fixed in 3.1.0. Need to fix in 3.2.0 and master.


Customizing

Summary of the issue
Is it posible to use .yml to customize file structure of a generated module?
Steps to reproduce

step 1
step 2
...

Environment in which this issue happens

CLI version:
node.js version:
Operating system:

hi @smooJitter sorry for the late answer,
what exactly do you want to customize?
I already customized the modules-directory so that you can use meteor 1.5. lazy loading.
I now want to also make the libs folder more customizable

@macrozone , In what version of mantra-cli was added the changes for meteor 1.5?

@vladejs mantra cli 0.5.1.
I now updated RELEASE_NOTE.md, sorry for that.

thanks @macrozone . I created a project today with the following structure:
/client
- imports
   - configs
   - modules
main.js

I don't understand how I would benefit from Meteor 1.5 dynamic imports, if the main.js file imports and bootstrap every module the app has.
Could you point me on the right direction here?
I am also trying to update the project to use latest mobx, mobdux and space:mobx-tracker-autorun package.

@macrozone , there some work to do here.
Currently I can set modulesPath variable, but when I create a component/container, tests are still being created under /client/modules/...

The customizations were really necessary. When I generate a new module, I like to have it pre-populated with a standard set of components and associated containers and actions ( EntityList, EntityDetail, EntityNew, EntityEditor, and EntityFilters for components. CRUD from actions).  where Entity corresponds (mostly) the moduleName. I've done a little hacking to figure it out.
I really do miss the activity on this project.  It is a very solid framework.  I still why it was abandoned.  I understand the personal issue may have gotten in the way, yet I still wonder if the original contributors still believe in the mantra approach.   It would be great to at least hear a few suggestions.  I noticed, even mantra-talk is gone.

Hi @smooJitter.
It's a shame indeed, that this wonderful architecture get abandoned by the
community.
I truly believe that Mantra could be adapted to keep up with the latest
technologies out there. If you are interested, I upgraded Mantra to be used
with this stack:

MobX 3.0
Meteor 1.5+

I modified mantra-core by removing old react-komposer 1.x and included
Mobdux, a thiny wrapper for mobx-react library wich has the advantages that
you don't need to decorate your dumb components with @observer.
For more info, you can check out the Project which I called MantraX here
https://github.com/vladejs/mantrax

@smooJitter I sympathize with your concern. As a maintainer of this CLI, it is sad to see Mantra being abandoned. While I would like to see the development being continued, I have been using neither Mantra or Meteor for more than a year, and I am not in a suitable position to lead or contribute to the framework.
I agree that Mantra is a solid specification and has potential. Therefore, in the meantime, I would like to encourage the community to step up if interested in maintaining the CLI project along with @macrozone.
It would be nice to see some handover effort from @arunoda, so that Mantra can be further developed under the community governance.

@vladejs ok, can you open an issue? should also not be too hard to fix. PR welcome

That's the beauty of Mantra.  There isn't much too it. There isn't a lot to maintain.  The only thing @arunoda vision of where he saw it going, and what constraints he was concerned about.  I simple Medium article, thats it.  I don't know how much I could contribute but I would be willing to have some dialogue about various issues.  I think it would be best to have the discussion via Meteor Forums, a 3 - 5 part series.  (WARNING, TYPOS are likely, no time to proof this)

Enhancing  the core class (i.e., app = createApp(context)). @sammjk has already offered a few good extension (vis mantra-plus) on extending the core with mantra and apollo middleware.  I would like to consider the communities view regarding extending the core like so.

export class App {
  constructor(context) {
    // standard
    if (!context) {
      const message = 'Context is required when creating a new app.';
      throw new Error(message);
    }
    this.context = context;
    this.actions = {};
    this._routeFns = [];

    // @sammjk extensions,
    this._moduleWillLoad = [];
    this._moduleWillInit = [];

    //  with this the core can respond to state updates
    this.context.Store.subscribe(this.onStoreUpdate.bind(this));
    store.dispatch(appActions.appInitialized());
  }

  onStoreUpdate(){ ... }

  ...

@markoshust have offered a few simple but use extensions to the core ( hymn-core and hymn-di), most importantly, he address the promise of name spacing mantra actions. The question here what might be some interesting  ways to enhance the core?
2). Redux actions and action types.  This is probably one of the most interesting opportunities.  Redux is here and whether we support it completely, I do think it provides solid support for local state (e.g., ui things like buttons, drawers, toggles, etc) The issues with redux, theres already to much complexity ( etc, actions, reducers, actionTypes ) while mantra helps reduce the reliance of redux (almost to zero), what are some efficient ways to incorporate redux, particular better integrate redux actions with mantra actions. Should we store a load redux actions the same way we load mantra actions. Since mantra relies on limited use of redux,  might it be possible to adopt one of the rogue approaches to reducing redux boiler (e.g, jumpstate is especially interesting)
3).  graphQL containers, actions, mutations, and queries.  Good news is apollo has done a great job with graphql container, furthermore, recompose  provides a more flexibility in compose components. In interesting question here how should we integrate mutations and queries.  Should with write graphQL queries in the actions? Should we write them in the containers?  Or should we write them at the component level.
4). Mantra beyond react-komposer, frankly react-compose provides access to tracker which is really only useful in the meteor context. Furthermore results are return via the data prop. graphql containers also return data on the data prop.  Fortunately, for me at least, graphql has a nice way to get around it.
5). What's up with?
   load(context, actions) {
       // do any module initialization
    },

There's a lot to explore with this.  What did @arunoda  have in mind with this.  Furthermore, what about passing  parameters or functions to app.init(...).  These features seem to be under utilized.  I haven't seen a repo that leverages load(...) other then when used with method-stubs.  Speaking of method-studs, whats the conceptual equivalent if one is using say GraphQL on Firebase as remote persistent state.
Essentially, It would be nice to hear some ideas with the main theme of "Mantra for React" or "Mantra Beyond Meteor".   Mantra was intended to be  front-end "react" framework, and not a meteor framework.  Unfortunately @arunoda adopted too many meteor dependencies (Meteor, FlowRouter, React-dict, Tracker etc), too many Kadira dependencies (react-komposer, react-di, FlowRouter) with only a promise of how mantra can be used beyond.  It still provides a fantastic way of organizing the code, and I support the framework.  Franking, I think @sungwoncho was the last man standing in this game. The CLI may have a few bugs here and there but it too is already a great tool.  It can only go further if the framework is expanded.
Note, I'm using react-native so I don't rely on the meteor context (react-native-meteor somewhat).  I only hung around because I was waiting for Mantra's most import promise (future proof).

@smooJitter Supporting redux and graphql is partly supported with mantra-cli, at least you can define templates for your containers that have the basic boiler-plate (add connect and graphql hocs).
@remolueoend, me and others in my company are currently using mantra-cli (havily) in redux/apollo/react-native projects and we think about how we can make it easier to scaffold actions and reducers. The actions folder in these projects contains non typical mantra-actions, but redux action creators and we have an additional folder reducers per module, which we combine in one main-reducer.
We do not use a global context anymore in these (non-meteor) projects and therefore neither mantra-core, react-simple-di nor the module load functions. Actions are therefore also not bound to any context.
I think arunoda's idea of mantra-context was that you can inject and therefore mock meteor-specific stuff into your containers and actions which makes unit-testing of these components easy (without booting meteor at all)
On the other hand, a global context is not so common in the rest of the react-community and therefore should be optional in mantra-cli.
So my bottom line:

general structure of mantra (modules and every module has components, containers, actions) fits for every react project and also for every way of state management
mantra-cli should be more configurable for the different flavors (meteor-react-tracker, meteor-redux, meteor-apollo, react-nativ-redux, with/without context, etc.)
mantra-cli might be the missing cli for react projects (angular has one, vue has one). create-react-app is great for initial scaffolding though, but has no option to scaffolding your components, actions etc after that. In fact you can start with create-react-app and use mantra-cli after that

I will create a roadmap for mantra-cli in the next weeks. Please leave issues or comments for features that you want!
I am also interested if anyone knows whether yeoman might also be a valid option to use as scaffolding engine.


构建不成功

<EMAIL_ADDRESS>dev /Users/sharexie/Documents/project/vuedemo/douban-master
node build/dev-server.js

events.js:160
throw er; // Unhandled 'error' event
^
Error: listen EADDRINUSE :::8080
at Object.exports._errnoException (util.js:1026:11)
at exports._exceptionWithHostPort (util.js:1049:20)
at Server._listen2 (net.js:1257:14)
at listen (net.js:1293:10)
at Server.listen (net.js:1389:5)
at EventEmitter.listen (/Users/sharexie/Documents/project/vuedemo/douban-master/node_modules/express/lib/application.js:618:24)
at Object. (/Users/sharexie/Documents/project/vuedemo/douban-master/build/dev-server.js:71:22)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.runMain (module.js:604:10)
at run (bootstrap_node.js:394:7)
at startup (bootstrap_node.js:149:9)
at bootstrap_node.js:509:3
npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/Cellar/node/6.8.1/bin/node" "/usr/local/bin/npm" "run" "dev"
npm ERR! node v6.8.1
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>dev: node build/dev-server.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dev script 'node build/dev-server.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the douban package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node build/dev-server.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs douban
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls douban
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/sharexie/Documents/project/vuedemo/douban-master/npm-debug.log
麻烦看下这是什么问题

Thanks for opening an issue with me.😀
There could be port conflicts.Please close the associated application or change the port number.


Searchbar behind a modal close button causes searchbar to focus.

Short description of the problem:
After closing a modal on top of a page with a searchbar, the click on the modal close button causes the searchbar to focus. This happens on an iOS device and emulator but not in a browser.
What behavior are you expecting?
Close modal without focusing the search bar behind the modal.
Steps to reproduce:

Create a page with ion-header, ion-navbar and ion-searchbar
Add a modal to the page with a close button in the top left.
Close the modal with the button and the searchbar becomes focused.

Page
<ion-header>
  <ion-navbar>
    <ion-searchbar></ion-searchbar>
  </ion-navbar>
</ion-header>

Modal
<ion-header>
    <ion-toolbar>
      <ion-buttons start>
        <button (click)="close()">
           Close
        </button>
      </ion-buttons>
    </ion-toolbar>
  </ion-header>

Which Ionic Version? 1.x or 2.x
2.x

Remove me please
On Aug 12, 2016 11:40 PM, "Thiery Laverdure"<EMAIL_ADDRESS>wrote:

Short description of the problem:
After closing a modal on top of a page with a searchbar, the click on the
modal close button causes the searchbar to focus. This happens on an iOS
device and emulator but not in browser.
What behavior are you expecting?
Close modal without focusing the search bar behind the modal.
Steps to reproduce:

Create a page with ion-header, ion-navbar and ion-searchbar
Add a modal to the page with a close button in the top left.
Close the modal with the button and the searchbar becomes focused.

Page

Modal

           Close

Which Ionic Version? 1.x or 2.x
2 Beta 11
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/driftyco/ionic/issues/7693, or mute the thread
https://github.com/notifications/unsubscribe-auth/AH3Ui58rf9dgbmwT1JU8B8OrEvItzSFRks5qfNofgaJpZM4JjcM9
.

@tlaverdure I confirmed this bug only happens in UIWebView. Can you try start using our WKWebView cordova plugin? https://github.com/driftyco/cordova-plugin-wkwebview-engine
You should expect a huge performance improvement.
http://blog.ionic.io/cordova-ios-performance-improvements-drop-in-speed-with-wkwebview/
I will close this a possible fix could be too complex, I don't think it would worth it.
Please reopen if you have an idea to fix this issue easily.

@manucorporat I actually haven't had any issues with this since I did the wkwebview upgrade, it's a weird corner case so I'm fine with just using wkwebview to fix. Thanks!


Update better vietnamese translate. :octocat:

I'm vietnamese developer, so i finished your translate locate!
Hope you merge my pull request , thanks you ^^
Please make sure these boxes are checked before submitting your PR, thank you!

[ ] Make sure you follow Element's contributing guide (中文 | English).
[ ] Make sure you are merging your commits to dev branch.
[ ] Add some descriptions and refer relative issues for you PR.

Translate done! ^^


fixes README formatting

Wow, the formatting near the bottom is totally jacked up! This fixes it.

thank you :D


HIVE-26613. Upgrade jettison to 1.5.1 to fix CVE-2022-40149.

JIRA: HIVE-26613. Upgrade jettison to 1.5.1 to fix CVE-2022-40149.

@ayushtkn Can you help review this pr? Thank you very much!

@ayushtkn Thank you very much for helping to review the code!


HtmlWebpackPlugin's templateParameters is not used

Before opening a new issue, please take a moment to review our community guidelines to make the contribution process easy and effective for everyone involved.
 Display a message if JS has been disabled on the browser. -->
  If you're seeing this message, that means
    JavaScript has been disabled on your browser, please
    enable JS to make this app work.

<%= foo %>

  <link href="https://fonts.googleapis.com/css?family=Open+Sans:400,700" rel="stylesheet">

then i run the script: npm run build,

and open the build/index.html, the <%= foo %> was not replaced by the templateParameters.foo

Steps to reproduce
Steps to reproduce the behavior:
(Add link to a demo on https://jsfiddle.net or similar if possible)
Expected behavior
A clear and concise description of what you expected to happen.

the <%= foo %> should be replaced by templateParameters.foo

Screenshots
If applicable, add screenshots to help explain your problem.
Versions

React-Boilerplate: 4.0
Node/NPM:
Browser:

i found a solution, but don't know if it's the best, see here:
https://github.com/jantimon/html-webpack-plugin/issues/1210#issuecomment-491661391

You need to add a Handlebars loader to webpack. See here: https://github.com/jantimon/html-webpack-plugin#writing-your-own-templates
Closing this as it's not related to react-boilerplate.


Is NCCLCacheManager only used  in test scenarios???

i grep the all source code, it seems that only ParallelGptDVBenchmark.cc used NCCLCacheManager  to transfer the kv cache
ParallelGptDVBenchmark.cc looks like a test code ???

Hi,
Since all of our proposed solutions involve copies to/from CPU memory, we didn't end up using NCCLCacheManager for actual transfering. We define it as:

we want to evaluate the efficiency of streaming in NCCL p2p scenarios as well
it is useful for future implementations of direct GPU-GPU communication, since we provide the basic primitives to build upon

Please note that the main reason we did not use NCCL p2p when doing prompt-token disaggregation was that we want to pipeline prompt transferring of some requests with token generation of other requests.  Using direct GPU-GPU copies would mean that we need to keep the KV cache of more requests in GPU memory, which would add extra memory pressure.


Moving Daml Finance and Good Design Patterns

These two pages are being moved to better locations within the restructured TOC.
[CHANGELOG_BEGIN]
[CHANGELOG_END]

I would move the Good Design Patterns menu item one up again, to above Testing, as the testing section assumes you have done the design and build already.

Thanks! I misread the ticket.


Add shop registration information

(eg BUSINESS REGISTER, REA)

@kenlog Could you merge your 2 PR in the same PR #29 / #30 ? Thanks


Fix incorrect default values in docs (#4294)

That file is auto generated, so editing it directly is not the right way to do this

Right. @555cider what seems to happen is that the default values in @ConfigurationProperties classes defining those props (for example, EurekaClientConfigBean, EurekaServerConfigBean), are not explicitly specified, but using math equations with constants instead, for instance: https://github.com/spring-cloud/spring-cloud-netflix/blob/57dd4f06744dba5af4fe4ac8dfb971665fd73f30/spring-cloud-netflix-eureka-client/src/main/java/org/springframework/cloud/netflix/eureka/EurekaClientConfigBean.java#L99, so what you'd need to do is instead of changing that configprops file, change the default values in those @ConfigurationProperties classes to explicit values (you could add comments such as "5 * MINUTES" where helpful.

I have applied all the changes you requested except for the regeneration of the configprops file. I was unable to regenerate the file because it involves removing any manual changes and running ./mvnw clean install -Pdocs locally.
Just in case, I've reverted the _configprops file back to its original state.
Also, I accidentally merged the main branch while clicking around the site. I force pushed to clean up the git history, but if this action is not allowed, I will create a new pull request. In that case, I will modify the branch based on the "4.1.x" branch and submit the request.

Thanks @555cider - waiting for the new PR.

Creating a new pull request (#4999) and closing this pull request (#4321).


Bootstrap 4.5.0 modal "keyboard: false" don't work

Operating system: Ubuntu 20.04
Browsers: Chrome 83.0.4103.61, Firefox 76.0.1
Bootstrap version: 4.5.0

https://jsfiddle.net/4sujahx5/

I am strongly convinced you are missing data-backdrop="static" in your .modal div.

The docs say Escape won't close the modal if the modal is static.

In version 4.4.1 "keyboard: false" works fine without data-backdrop="static"
https://jsfiddle.net/q23up7n8/

@Johann-S I guess this is the intended behavior, right?

This issue is with v5 also @XhmikosR
https://codepen.io/rohit2sharma95/pen/XWKQmYj


No module named 'src.data'

Dear Sir，
When I used 'main.py' and implement 'from src.data import RSNAHemorrhageDS3d, Qure500DS', there is an error 'ModuleNotFoundError: No module named 'src.data'. It seems I cannot find 'data' file in your 'src' file. Any advice?

Hi @bbb801, the data directory was accidentally ignore by my local .gitignore, I have committed the code.
Regards.


Update Blog “biryani”

Automatically generated by Netlify CMS

👷 Deploy Preview for kidskingdom processing.

Name
Link

🔨 Latest commit
cc00a390f0c3675316341ca2974f2abe314ad42b

🔍 Latest deploy log
https://app.netlify.com/sites/kidskingdom/deploys/63b7e758fb7d1e0008c0a8c1


[SPARK-32088][PYTHON][FOLLOWUP] Replace collect() by show() in the example for timestamp_seconds

What changes were proposed in this pull request?
Modify the example for timestamp_seconds and replace collect() by show().
Why are the changes needed?
The SQL config spark.sql.session.timeZone doesn't influence on the collect in the example. The code below demonstrates that:
$ export TZ="UTC"

>>> from pyspark.sql.functions import timestamp_seconds
>>> spark.conf.set("spark.sql.session.timeZone", "America/Los_Angeles")
>>> time_df = spark.createDataFrame([(1230219000,)], ['unix_time'])
>>> time_df.select(timestamp_seconds(time_df.unix_time).alias('ts')).collect()
[Row(ts=datetime.datetime(2008, 12, 25, 15, 30))]

The expected time is 07:30 but we get 15:30.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By running the modified example via:
$ ./python/run-tests --modules=pyspark-sql

Test build #124688 has started for PR 28959 at commit aa6a0e1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29300/
Test PASSed.

Test build #124688 has finished for PR 28959 at commit aa6a0e1.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124688/
Test FAILed.

It seems the build failure is not related to the changes:
[error] /home/jenkins/workspace/SparkPullRequestBuilder@6/core/src/main/scala/org/apache/spark/SSLOptions.scala:71: type Server is not a member of object org.eclipse.jetty.util.ssl.SslContextFactory
[error]       val sslContextFactory = new SslContextFactory.Server()
[error]                                                     ^
[info] No documentation generated with unsuccessful compiler run
[error] one error found

Hi, @MaxGekk . Are you sure that is due to #28863 ?

Hi, @MaxGekk and @jiangxb1987 . Could you give me more hints?

Until now, I'm observing the following. I'll monitor more, but it would be great if you can give me more evidence so that I can help you, @MaxGekk and @jiangxb1987 .

GitHub Action is healthy all profile combination.
Jenkins job is running on the latest master branch.

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-sbt-hadoop-2.7-hive-2.3/907/

retest this please

Sure, let's block before the test results.

Test build #124718 has started for PR 28959 at commit aa6a0e1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29329/
Test PASSed.

Test build #124718 has finished for PR 28959 at commit aa6a0e1.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124718/
Test FAILed.

retest this please

Test build #124729 has started for PR 28959 at commit aa6a0e1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29340/
Test PASSed.

Test build #124729 has finished for PR 28959 at commit aa6a0e1.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124729/
Test FAILed.

retest this please

Test build #124735 has started for PR 28959 at commit aa6a0e1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29346/
Test PASSed.

Test build #124735 has finished for PR 28959 at commit aa6a0e1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124735/
Test PASSed.

Merged to master.

FYI,
[error] /home/jenkins/workspace/SparkPullRequestBuilder@6/core/src/main/scala/org/apache/spark/SSLOptions.scala:71: type Server is not a member of object org.eclipse.jetty.util.ssl.SslContextFactory
[error]       val sslContextFactory = new SslContextFactory.Server()
[error]                                                     ^
[info] No documentation generated with unsuccessful compiler run
[error] one error found

This is from unidoc when you generate the documentation. It sorts of compiles Scala files back to Java files, and extract the documentations from there. It's kind of buggy time to time.


Test memoize min time

This change is related to the ticket: https://trader.atlassian.net/browse/MCNG-380
Unhaggle is storing all unnecessary data in a cache. As a result, I'm altering Unhaggle's caching condition so that we may check our memoize decorator, which determines the time limit and whether or not to cache that query.
Any other application that uses this library won't be affected by this change.
Test Case results

@jhonatandarosa , @4fuss , @danialmalik
Can I proceed to merge this PR?

Travis is not running on this PR. probably we need to integrate travis with this repo. Could you please connect with infra team to do so?


Make communication channels more obvious

fixes #306
@Remi-Gau let me know if this also fixes #291.
Also, this needs approving reviews by some, to make sure that everybody is on board with my suggestion: https://github.com/bids-standard/bids-website/issues/306#issue-1732393543

As discussed in yesterday's maintainers meeting, I adjusted this PR to more explicitly mention our 4 main communication channels

google mailing list
neurostars
brainhack mattermost
twitter

I sent an email to all people who had responded to the "email newsletter survey" that we won't use these emails in the future and that they should please sign up via our 4 common communication channels.


Bug: Incorrect error on swift imports "module xxx not found"

Description
In Xcode editor, opening a swift source file shows a red error on import lines complaining "module XXX is not found"
This is not a true error in that the build would succeed regardlessly.
Reproduction steps

Have a swift_library A which depends on swift_library B.
Generate Xcode project and open swift source file in A which has line import B
Xcode will mark the line import B with message "module A not found"

Expected behavior
Xcode doesn't mark the line import B with message "module A not found"
rules_xcodeproj version
1.6.0
Xcode version
14.1
Bazel version
6.1
rules_apple version
No response
rules_swift version
No response
Additional information
This is expected to resolve once the Xcode's Index build for target B is completed, however, more intuitive experience would be if source file in A is open, then the Index build for target B is scheduled with high priority.

This is Xcode behavior that, as far as I know, we can't change. It's because Xcode hasn't indexed the file yet. Not sure what we can do differently, so I'm not sure this is a bug on our side.


Add sorting to TaskTypes admin page

Feature Description

The table headers should be sortable like the volunteer list is sortable.
Expected solution

Implement the same sorting as the volunteer list page on the tasktypes page.
Testing

New contributor here: can this be assigned to me, please? I'd like to work on this.

Yes, go for it!


Acrylic title does not work completely

Windows Terminal version
1.16.10261.0
Windows build number
10.0.19045.2604
Other Software
No response
Steps to reproduce

acrylic tab row open
Expected Behavior
I want the acrylic background to be covered with headlines
Actual Behavior

the title and Tab function bar not working，It's too uncoordinated and looks ugly

This is something that should work better in 1.17 (and maybe 1.16?) by editing the theme. At the very least, in 1.17, you can set the tab.background to something like #00000000 and get transparent tabs, or (for example) #ff000044 for semi-transparent red tabs:


Main doesn't return nonzero exit code on failure.

When Main run fails, it does not return with nonzero exit code, which means that in a shell script, an invoker does not have a way to know that the process failed.

Thanks for the report @bdw-g! Could you provide an example?


added new section of drawing the text

added a new section of drawing the text
additionally i add the download btn, color picker,clear canvas btn to edit the canvas

my issue no. is #50

sorry i made mistake


How to get the current Model object in Build Enumerable?

Hi,
I would like to have the current PersonModel inside Build method as for example the line
var CurrentModelEnum = ???
Thanks,
AG
@model IEnumerable<PersonModel>

@(Html
    .Grid(Model)
    .Build(columns =>
    {
        columns.Add(model => model.Name).Titled("Nom");
        columns.Add(model => model.Surname).Titled("Nom de famille");

        var CurrentModelEnum = ???

        columns.Add(model => model.Age).Titled("Âge");
        columns.Add(model => model.Birthday).Titled("Date de naissance");
        columns.Add(model => model.IsWorking).Titled("Employé");
    })
    .MultiFilterable()
    .Filterable()
    .Sortable()
)

It will be available as model in columns.Add(model => model.Age) for example, so you can write any code block in side if you want to.

I have a model class with sub items as list in other class so for each object in the main class I would like to get the list of the sub class with foreach and inside it to use columns.Add

You can't add columns dynamically, they have to be known from the start.
If you know them you can use iterate them and add columns as needed.
Maybe you could share an example of what is not working?

Hi,
Attached a zip file with .NET Core code of what I would like to do.
In Models folder you can find the MainClass and SubClass(List).
My code for grid is at Index.cshtml and I am using HomeController and Index action.
Thanks,
AG
MVC6.Grid_Test.zip

Well I don't think you can do that, the best you could do is create a child grid within a main grid.

Thanks you for your help, I will look how to solve this...


API Resource Routes and Route Groups not working

Laravel Version: 5.7.8
PHP Version: 7.2.6
Database Driver & Version: MariaDB 10.2

Description:
When making HTTP requests to routes within a route group, where an API Resource route group has been registered before, the routes do not match and a 404 response is returned.
Steps To Reproduce:

Create a new Laravel project
In your routes file, add the following routes:

$router->group(['prefix' => '/v1', 'middleware' => ['auth:api']], function ($router) {
    $router->apiResource('/contacts', 'ContactsController');

    $router->group(['prefix' => '/contacts'], function ($router) {
        $router->apiResource('/groups', 'Contacts\\GroupsController');
    });
});

GET requests to /api/v1/contacts/groups then returns 404 responses. However POST and PUT requests still work.
The fix for this is changing the order. If I put the contacts api resource below the route group, it then works.
$router->group(['prefix' => '/v1', 'middleware' => ['auth:api']], function ($router) {
    $router->group(['prefix' => '/contacts'], function ($router) {
        $router->apiResource('/groups', 'Contacts\\GroupsController');
    });

    $router->apiResource('/contacts', 'ContactsController');
});

Is this intended behaviour? It seems strange that in the first case POST and PUT requests work, but GET requests return 404 responses.
For more information, please see the following Stack Overflow thread - https://stackoverflow.com/questions/52736365/unable-to-make-http-request-to-laravel-endpoint/52736636

Using $router->apiResource('/contacts', 'ContactsController'); will register the ContactsControllers actions index, show, store, update and destroy  for routes.
For the show action it registers /v1/contacts/{contact}. Because this route is ahead of /v1/contacts/groups, the route will match the ContactsControllers route and use 'groups' for the wildcard.

Thanks @SPie - makes sense.


[SPARK-50044][PYTHON] Refine the docstring of multiple math functions

What changes were proposed in this pull request?
Refine the docstring of multiple math functions
Why are the changes needed?
1, make them copy-pasteable;
2, show the projection: input -> output
Does this PR introduce any user-facing change?
doc changes
How was this patch tested?
updated doctests
Was this patch authored or co-authored using generative AI tooling?
no

+1, LGTM. Merging to master.
Thank you, @zhengruifeng and @HyukjinKwon for review.


Remove PII from AC view

User story
As an AC member, I should NOT be able to view PII within to applications associated with my account. This is an effort to increase privacy and security, and protect applicant information.
Describe the solution you'd like in Hypha
PII should not appear on applications for the AC role. Please hide:

[ ] telephone number
[ ] email
[ ] address
[ ] legal name, when there is a redundancy between a person's name (to be removed) and an organization's name

@Parbhat @sks444 Would it be possible to add a "pii_status" (PII = personally identifiable information) to fileds like address and e-mail address like this:
 class AddressFieldBlock(ApplicationSingleIncludeFieldBlock):
     name = 'address'
     description = 'The postal address of the user'
     pii_status = True

And then check for that when the field is rendered?
try:
      pii_status = field.block.pii_status
except AttributeError:
       pii_status = False

The best would be if we can get this in to Wagtail group permissions, then each organisation using Hypha can set what groups/roles should be able to view fields with personally identifiable information.
If the last is complicated we can just have a setting in base.py that is a list of groups. The default should be the same as how the system works today, that anyone who can view the submission can also see PII fields.

@frjo All these options sound good. Sorry for the late response.


Memory leak due to non-existing image rendering

I actually found this issue when I was using EChart. The issue becomes very serious when I have a logic that tries to get image based on a variable. Size of globalImageCache keeps increasing after EChart's setOption.
When image is being loaded, pendingWrap from createOrUpdateImage is pushed to pending in globalImageCache.
https://github.com/ecomfe/zrender/blob/fdd600891646644d215fcae015d3ebeb71e695f3/src/graphic/helper/image.js#L50
The pending array is only cleared when the image is loaded successfully. For non-existing image, i.e. onerror, the array will not be cleared.
Memory Increase:

After I added a non-existing image 10 times

After fix:

Submitted pull request https://github.com/ecomfe/zrender/pull/340


zsh-fzf-tab: 1.1.1 -> 1.1.2

Description of changes
https://github.com/Aloxaf/fzf-tab/releases/tag/v1.1.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 311237 run on x86_64-linux 1

1 package built:

zsh-fzf-tab


Fix quay try2

Type of change
Note: Fill x in []

[ ] bug
[ ] enhancement
[ ] documentation
[ ] dependencies

Description

For security reasons, all pull requests need to be approved first before running any automated CI

Old version


esp32s3_rtc: use small lock in arch/xtensa/src/esp32s3/esp32s3_rtc.c

Summary
esp32s3_rtc: use small lock in arch/xtensa/src/esp32s3/esp32s3_rtc.c
reason:
We would like to replace the big lock with a small lock.
Impact
esp32s3_rtc
Testing
ci

[Experimental Bot, please feedback here]
No, this PR does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details in several sections.
Here's a breakdown of what's missing:

Summary:  While it states the change, it doesn't explain why replacing the big lock with a small lock is necessary. What problem does it solve? What are the benefits (e.g., performance improvement, reduced resource usage)?  It also lacks mentions of related issues.
Impact: This section is far too brief. It simply repeats the affected module.  It needs to address all the listed impact points (user, build, hardware, documentation, security, compatibility) with specific YES/NO answers and descriptions where necessary.  Even if the answer is NO, explicitly state it.  For example: "Impact on user: NO".
Testing:  "ci" is insufficient.  It needs to list the specific build hosts and targets used for testing.  Critically, it's missing the actual testing logs before and after the change.  Without these logs, there's no way to verify the change works as intended.

Example of how to improve the PR description:
Summary
This change replaces the big lock in esp32s3_rtc.c with a small lock to improve performance and reduce overhead. The big lock caused unnecessary contention in multi-threaded scenarios, leading to performance degradation. This change aims to alleviate this issue by using a more fine-grained locking mechanism.
Related NuttX Issue:  (If applicable - add link)
Related NuttX Apps Issue/PR: (If applicable - add link)
Impact

Impact on user: NO
Impact on build: NO
Impact on hardware: YES - Affects esp32s3 architecture.
Impact on documentation: NO
Impact on security: NO
Impact on compatibility: NO
Anything else to consider: This change might slightly increase code size due to the additional small lock implementation.

Testing
I confirm that changes are verified on local setup and works as intended:

Build Host(s): Linux (Ubuntu 22.04), x86_64, GCC 11.3.0
Target(s): esp32s3:sim

Testing logs before change:
<Insert actual logs demonstrating the issue with the big lock, e.g., timing measurements, evidence of contention>

Testing logs after change:
<Insert actual logs demonstrating the improvement after applying the small lock, e.g., improved timing measurements, reduced contention>

By providing this level of detail, reviewers can understand the context of the change, assess its impact, and verify its effectiveness through the provided test logs. This makes the review process significantly smoother and increases the chances of the PR being accepted.


More 32 bugfixes

Just boringly updated the submodule to get more bugfixes from upstream

Coverage remained the same at 76.42% when pulling 91a2b4833a46bc8b48e8ebd2e53a2ad0c3939421 on asottile:more_32_bugfixes into 08baa8f33cccf33a2bbaba2d25521d06983edeb6 on dahlia:python.

Thanks!


Release 1.0.3

close #5

Description of change

Pull-Request Checklist

[ ] Code is up-to-date with the main branch
[ ] npm run lint passes with this change
[ ] npm run test passes with this change
[ ] This pull request links relevant issues as Fixes #0000
[ ] There are new or updated unit tests validating the change
[ ] Documentation has been updated to reflect this change
[ ] The new commits follow conventions outlined in the conventional commit spec

:tada: This PR is included in version 1.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix owner_rels.cid foreign key reference

Also improves testing to catch attempts to use incorrect foreign keys.

I also checked the code, everywhere uses owner_rels.cid to refer to crates, not releases.


revert struct name

Coverage decreased (-0.4%) to 61.509% when pulling 908dc203a15f1243b292c41d1b1cb122f65ade23 on tianxiaoliang:master into 53f761dc0acea5c901e969cb0822b79a969af24e on ServiceComb:master.


Field factories should be configurable

Field factories should be fully configurable. For example, the adapters are right now hardcored, but should be set with parameters or a configuration file.

Classes are no longer hardcoded. But they still need a good way to configure the dependencies.


redaxios

Suggested light-weight alternative for axios.
https://github.com/developit/redaxios
Cheers!

Thanks for the awesome suggestion.


prefix

how to change the prefix?

Please use the support server for help requests.
The prefix can be changed using the prefix configuration option:
https://github.com/Dragory/modmailbot/blob/master/docs/configuration.md#prefix


io: fix typo in TestMultiWriterSingleChainFlatten

This PR fix a typo in function TestMultiWriterSingleChainFlatten.
Compare between 'TestMultiReaderFlatten' and 'TestMultiWriterSingleChainFlatten', I guess that it should be 'mw' instead of 'w'.

@googlebot I signed it!

The CLA still seems to be failing. Are you sure you've signed it with the same email address you use in git? See https://go.dev/doc/contribute#cla.


Fix for newer versions of React Native

View.PropTypes is now deprecated, which means that if you try to use this module in a release build, it will crash and not work.
This commit fixes that and allows the module to work as expected (both in debug and release).

Thank you for your help :)


Release Google.Cloud.ApigeeRegistry.V1 version 1.0.0-beta06

Changes in this release:
New features

Change netstandard2.1 target to netstandard2.0 (commit 82bea85)

Created release for Google.Cloud.ApigeeRegistry.V1-1.0.0-beta06


[Technical Task] Check the current status and expiration date of the production Instagram token

Brief Overview
The task is to verify the production Instagram token to ensure it is still valid and functioning correctly. This verification is necessary to maintain the integration with Instagram and prevent any disruptions in service.
Expected Result
The production Instagram token is verified and confirmed to be valid. If the token is invalid, it should be renewed, and the integration should be tested to ensure continued functionality.

Потрібно заупстити джобу для оновлення токена на проді


changes in physics to enable trigger collisions with the world and to make triggers have their own collision groups

Contains
changes in physics to enable trigger collisions with the world and to make triggers have their own collision groups. It also makes slight changes in PhysicsLiquidWrapper and PhysicsWorldWrapper so that the latest TeraBullet module can recompile with the engine.
Outstanding before merging
Will need to merge https://github.com/MovingBlocks/TeraBullet/pull/2 before merging this.
NOTE: After merging this pr you will need to recompile the engine module with latest TeraBullet module.

Uh oh, something went wrong with the build. Need to check on that

Pinging @Cervator for reveiwing the pr, to merge it before coming saturday for proper testing of CombatSystem module.

@0shine0 Could you maybe re-do the pr? Not exactly sure what's wrong with the checks

@portokaliu The checks have failed because this repo references to an old version of teraBullet. The methods that i defined in the PhysicsLiquidWrapper and the PhysicsWorldWrapper class are not introduced in this old version. This repo needs to include the latest teraBullet version before merging the pr and for the checks to work.

Yeah I'm working with the merge locally right now and figured that was it :-)

Released TeraBullet v1.3.0, bumped the engine's dependency to use it, tested locally with the CombatSystem and Rails (and lots of railgun), and merged! :-)
One quirk: Dropped physics objects now seem to keep going waaaay longer, as if they're not being drained by friction fast enough. Very bouncy and slippery, will keep sliding across the ground slowing down so incrementally that they go poof from "timing out" before they actually stop moving entirely.
Also added CombatSystem + AdventureAssets to the module lineup!


Issue #64 build, pull and push of container images

Fix #64
Will have to remove/replace
  - docker login -u gbraad -p $DOCKER_PASSWORD

but this is something I used before to prevent the rebuild of the images for socat, ethtool, etc

@gbraad To make this PR to work , we first need to push the intermediate images to github, right?

AFAIR this is to force a truth check. If you have another option that works
from the dind based shell, let me know. They do not use bash... and this
works accross the board with dind images and our CI option
On Tue, Apr 24, 2018 at 3:55 PM, Lalatendu Mohanty<EMAIL_ADDRESS>
wrote:

@LalatenduMohanty commented on this pull request.
In iso/build.sh
https://github.com/minishift/minishift-b2d-iso/pull/80#discussion_r183635583
:

@@ -31,22 +31,25 @@ docker run $DOCKER_RUN_OPTIONS jpetazzo/nsenter cat /nsenter > $tmpdir/nsenter &

do not remove nsenter, as this image is not big, and quite generally used
Get socat
-docker build -t socat -f Dockerfile.socat .
-docker run $DOCKER_RUN_OPTIONS socat cat socat > $tmpdir/socat
+[ "${BUILD_CONTAINER_IMAGES+1}" ] && docker build -t minishift/b2d-socat -f Dockerfile.socat .
Why the +1 in ${BUILD_CONTAINER_IMAGES+1} . If anyone wants to build the
images locally we can set export BUILD_CONTAINER_IMAGES=1, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/minishift/minishift-b2d-iso/pull/80#pullrequestreview-114668284,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAHZmydbjwyTqST2TPbOxhKoF9oAm4Kks5trtpdgaJpZM4RMSTL
.

--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]

retest this please


put ansible-service-broker log in /var/log

The service broker logs to /tmp/ansible-service-broker.log, this file should be located in /var/log. Also need to configure a logrotate.

Fixed by current release:
https://github.com/openshift/ansible-service-broker/blob/master/build/Dockerfile#L18
https://github.com/openshift/ansible-service-broker/blob/master/build/Dockerfile-src#L27
https://github.com/openshift/ansible-service-broker/blob/master/build/automated-build#L20
https://github.com/openshift/ansible-service-broker/blob/master/templates/deploy-ansible-service-broker.template.yaml#L196
https://github.com/openshift/ansible-service-broker/blob/master/ansible-service-broker.spec#L196-L197


[PHP] provide enum mapping from value to key in addition to from key to value

Is your feature request related to a problem? Please describe.
If I define an enum like this in a proto file:
enum Animals {
  CATS = 0;
  DOGS = 1;
}

When I generate code in Go I end up with mappings from the key to the value and from the value to the key like this:
var Animals_name = map[int32]string{
    0: "CATS",
    1: "DOGS",
}

var Animals_value = map[string]int32{
    "CATS": 0,
    "DOGS":  1,
}

But when I generate code in PHP, I only get mappings from the key to the value and not the other way around:
class Animals
{
    /**
     * Generated from protobuf enum CATS = 0;
     */
    const CATS = 0;
    /**
     * Generated from protobuf enum DOGS = 1;
     */
    const DOGS = 1;
}

Describe the solution you'd like
I'd like to be able to get the key from the value as well, like I can in Go.
Something like this would work:
class Animals
{
    const VALUES = [
        "CATS" => 0,
        "DOGS" => 1,
    ];

    const NAMES = [
        0 => "CATS",
        1 => "DOGS",
    ];
}

Describe alternatives you've considered
The only alternative is for me to create something like the "values" mapping manually, which will quickly get out of date.
Additional context
Add any other context about the feature request here.

I have logged an issue https://github.com/protocolbuffers/protobuf/issues/6875 to the protobuf team to track this.

Sounds like a protobuf feature request that is being tracked accordingly


Post submitted check from v1 to master

https://github.com/saxulum/saxulum-crud/commit/fe9639c2c6fde6d97a5a24080d0e2e70ad0a2afe

https://github.com/saxulum/saxulum-crud/commit/8b63b9a99e3d0d96153994a337e432c4a1ac7442


Add null check for link element or single image

There was already some code to check if a multiple image picker was empty, but not an individual image or link. It probably could be tidier, but I replicated the existing code for consistency.

Thanks again Tom


Any way to open existing files?

Is there an open file button or command?

Unfortunately no. You can put the .csx file in the RoslynPad documents folder (by default under User\Documents) and it will show up in the Documents pane next time you open the app.

Use Ctrl+O or the toolbar at the bottom of the documents pane to open a file.


Light strip not lighting up.

I've got the circuit set up properly and the NodeMCU software was uploaded as well. I have the proper components and automations set up in Home Assistant and I can tell that the NodeMCU receives the proper command but the strip does not light up.
What kind of voltage/amps should I expect on the output pin? I'd like to confirm the output is working properly before I try to get a replacement strip from Amazon.
Thanks!

Is the pin number correct? In your code if the following correct and have you connected the data in to the D5 pin of the nodeMCU.
#define DATA_PIN    5
In some nodeMCU the D5 pin is not after D4, you will have 3v and GND in between D4 and D5.

If you take a look at the pinout for the NodeMCU, D5 is the pin after the ground and 3.3v. See here:
https://cdn3.bigcommerce.com/s-vt19phz/product_images/uploaded_images/pinout.png?t=1491966337
If this still isn't working, try another pin and change the #define DATA_PIN 5 to the new pin in the code

I have the same issue with FAST LED, the issue is which is the DATA_PIN value i should use with D5

I solved ! If you are using NodeMCU version 3, and want to use D5 , add
#define FASTLED_ESP8266_NODEMCU_PIN_ORDER
before importing the Fast Led Library,
Then it will work when using DATA_PIN 5
Hope this helps,

#define FASTLED_ESP8266_NODEMCU_PIN_ORDER doesn't work for me. in fairness, nothing does... so far. I know my system works as I can use the McLighting code which works a treat. But, that code uses the NeoPixel.h library.
The mqtt side of things is working fine as i can see the messages coming in from HomeAssistant. I know FastLED works with my LEDS because i can do a simple script which turns the lights on just to prove the software works. I usually use D2 labelled on the board which effectively is GPIO4, which is also the same as i used in McLighting. LEDS are WS2812B, wouldn't have thought that the colour order would stop them from working, just give them the wrong values is all from what I've read.
Only other thing i can think of is that i've had to add the int MILLION = 100000; section to get over the error that the MILLION caused in the temp section. Should that be at the very beginning or lower down in the JSON bit?
I'm just rather puzzled!


BAH-2348 | Pulled translations and Updated locale list with which have significant translations available

@SanoferSameera - even though clinic-config repo has been created brand new few months ago, i see translations in your PR. I am assuming these are generated by transifex from "memory", since many strings in clinic-config are duplicate of our older default-config repo. Please confirm this. Thanks!
cc: @angshu

Is the "app" in Transifex the same for default-config and clinic-config, and that is why the memory is shared?
e.g : [o:openmrs:p:bahmni:r:default-customization-of-clinical-app]

Is the "app" in Transifex the same for default-config and clinic-config, and that is why the memory is shared? e.g : [o:openmrs:p:bahmni:r:default-customization-of-clinical-app]

there is no separate transifex for clinic-config. Both config uses same set of files and directories. Rather that, default-config has some modules like ipd, orders which is not included in clinic-config. we are pulling transifex for only those modules whic exist in clinic-config

Can you update the README.md of clinic-config and default-config, to indicate that from transifex perspective, they are currently sharing the same configuration. Because, these are technically DIFFERENT config folders. They may have same files right now, but as time progresses, they can easily deviate. For instance for same MESSAGE KEY, the english strings can change in future. e.g:
[clinic-config]
APPOINTMENT_REMINDER=You have an upcoming apointment at clinic {clinic-name}
[default-config]
APPOINTMENT_REMINDER=You have an upcoming apointment at hospital {hospital-name}
To avoid this from happening, we will need to ensure we don't do the above, and instead create unique keynames across clinic/default config, if they are deviating in english values.

Approved from my side. thanks!


GUI soon ?

Hi,
In the future, are there plans to make the script more "ergonomic" and provide it with an interface with simples buttons to click on ?
thanks for the answer 👍🏻

Heya,
The script has expanded to a point where a GUI might be very nice to have. It's definitely something I want to implement, but there's a few outstanding issues that take priority.

That's cool I can't wait for it to happen ! And when it does I will propose (if it's feasible) a French translation.


SPTrustedRootAuthority: Need to add possibility to get the certificate from a file path, as an alternative to its thumbprint, as done in resource SPTrustedIdentityTokenIssuer

Details of the scenario you tried and the problem that is occurring
If the certificate is generated in DSC configuration, its thumbprint is unknown at design time so we cannot use it.
The alternative is to use a file path to the public key of the certificate, as done in resource SPTrustedIdentityTokenIssuer.

I Think it is a common practice to use thumbprint in certificate DSC resources: for example, https://github.com/PowerShell/CertificateDsc/wiki/CertificateImport or https://github.com/PowerShell/xwebadministration#xwebsite.
The workaround I use on the compiling machine:
            $pfxPath = "c:\certs\contosoclubbwebb.pfx";
            $pfx = New-Object -TypeName "System.Security.Cryptography.X509Certificates.X509Certificate2";
            $pfx.Import($pfxPath,$pfxPassword,[System.Security.Cryptography.X509Certificates.X509KeyStorageFlags]::PersistKeySet);

            xWebsite WA00Site
            {
                Name        = "Contoso Klubbwebb"
                State       = "Started"
                BindingInfo = @(
                    MSFT_xWebBindingInformation {
                        Protocol = "HTTPS"
                        Port = 443
                        CertificateThumbprint = $pfx.thumbprint
                        CertificateStoreName = "My"
                        HostName = $hostName
                        SslFlags = 1
                    }
                )
            }

Mind you that in this case, $pfx.Import( does not actually install the certificate in any storage, but only in loads info that you can use to figure out the thumbprint for the cert.

@shurick81 I wanted to test and comment your solution much earlier but I didn't find the time until now.
I cannot use your solution because it assumes that "contosoclubbwebb.pfx" already exists at compilation time.
In my scenario, I populate a completely new environment and the certificate doesn't exist yet, so DSC function fails to generate the MOF with this error:
Exception calling "Import" with "1" argument(s): "The system cannot find the path specified."

Will be added in my next PR


runtime data corruption

Hi!
With the current version 1.2.1 I reproducibly have the situation where a login works well immediately after (re)start, but after some hours, it only results in:
token signature is invalid: crypto/rsa: verification error
My config is rather minimal:
    plugin:
        oidcclient:
          encryptionSecretFile: /etc/traefik/encryption_secret.json
          idps:
            - name: default
              providerUrl: "https://XXXX/"
              postLogoutUrl: "https://XXXX/"
              clientSecretFile: /etc/traefik/oidc_secrets.json
              scopes:
                - openid
                - portal

Hi @KampfCaspar ,
When the validation of the token fails, you should get a 401 if the call was an Ajax call. Otherwise, it should redirect to the IDP. Would you have some Traefik logs from around the moment this happens?

traefik.log
The traefik log seems quite normal... Note I get redirected to the zitadel login and the error appears upon the 'callback'.
For testing, I deleted all cookies and retried with the same result. The log for that:
traefik2.log

Then I don't understand the difference between the first login and the subsequent ones. The plugin is not aware of this. The only state it has is the tracking cookie, but that doesn't appear in the callback. I can add more logging to try to make sense of it.

That's why I suspected some sort of data corruption. If the key verification fails, might something corrupt the one part of the key pair?

I have released v1.2.2, which has more error logging. It will also log the tokens that can't be consumed correctly, not the correct ones.

I installed 1.2.2 and got the result:
traefik.log

For one token I see the verification error, but when I copy it in the debugger on jwt.io it works fine. It is not even expired yet at the time of writing. I have no explanation for this.

That's not surprising, as the error literally occurs just after I get returned from zitadel. At that moment, I just got a new token.
Might the error message give a hint? It seems the verification fails within a rsa check. That's why I suspected the key material might have been corrupted (in RAM?).

The token that follows the error message in the log is the one that caused the error. If there has been any corruption, then it should be visible in that string in the log. But since it works, I would conclude the token hasn’t been changed.

jwt.io also correctly verifies the signature with the key offered by my zitadel instance. Is there any way I can compare the key the plugin uses at that moment with the key from zitadel?

I will have to add that to the log.

Logging the public keys in a way you can compare is less trivial. In fact, when there is an error message during validation, then it is always about the last key in de the array the discovery URL returned. The keys are loaded once and never touched after. They are tried in the order they come out of the discovery.

There is only one key in the array; that key did not change.
The interesting issue is: immediately after a restart of traefik, eveything works fine. It works multiple times, too. However, after several hours, it fails.
I wanted to check therefore, if the plugin (for whatever reason) uses differing values immediately after the restart vs. several hours later. Might the loaded key somehow get corrupted?
This weekend we meet at the national hackspace reunion. I will try to learn go at least to the extend I can answer that question...

I had this issue also with one of my IDPs. The reason is the rotation of the keys by the IDP. In release 1.2.3 the keys are reloaded if a key ID is offered that is not in the list.