Cannot login in the first time

Describe the bug
I setup new flagsmith from docker
After start as the ReadMe.md : https://github.com/Flagsmith/flagsmith/blob/main/README.md
I cannot see reset password link, so I cannot login
To Reproduce
Log from docker :
docker-compose -f self-hosted/docker-compose.yml up
[+] Running 3/0
 ⠿ Container flagsmith_postgres                 C...                                0.0s
 ⠿ Container self-hosted-flagsmith-1            Created                             0.0s
 ⠿ Container self-hosted-flagsmith_processor-1  Created                             0.0s
Attaching to flagsmith_postgres, self-hosted-flagsmith-1, self-hosted-flagsmith_processor-1
flagsmith_postgres                 |
flagsmith_postgres                 | PostgreSQL Database directory appears to contain a database; Skipping initialization
flagsmith_postgres                 |
flagsmith_postgres                 | 2023-11-28 09:58:30.224 UTC [1] LOG:  listening on IPv4 address "<IP_ADDRESS>", port 5432
flagsmith_postgres                 | 2023-11-28 09:58:30.224 UTC [1] LOG:  listening on IPv6 address "::", port 5432
flagsmith_postgres                 | 2023-11-28 09:58:30.228 UTC [1] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
flagsmith_postgres                 | 2023-11-28 09:58:30.243 UTC [22] LOG:  database system was shut down at 2023-11-28 09:47:32 UTC
flagsmith_postgres                 | 2023-11-28 09:58:30.249 UTC [1] LOG:  database system is ready to accept connections
self-hosted-flagsmith-1            | System check identified some issues:
self-hosted-flagsmith-1            |
self-hosted-flagsmith-1            | WARNINGS:
self-hosted-flagsmith-1            | ?: (axes.W002) You do not have 'axes.middleware.AxesMiddleware' in your settings.MIDDLEWARE.
self-hosted-flagsmith_processor-1  | System check identified some issues:
self-hosted-flagsmith_processor-1  |
self-hosted-flagsmith_processor-1  | WARNINGS:
self-hosted-flagsmith_processor-1  | ?: (axes.W002) You do not have 'axes.middleware.AxesMiddleware' in your settings.MIDDLEWARE.
self-hosted-flagsmith-1            | System check identified some issues:
self-hosted-flagsmith-1            |
self-hosted-flagsmith-1            | WARNINGS:
self-hosted-flagsmith-1            | ?: (axes.W002) You do not have 'axes.middleware.AxesMiddleware' in your settings.MIDDLEWARE.
self-hosted-flagsmith_processor-1  | System check identified some issues:
self-hosted-flagsmith_processor-1  |
self-hosted-flagsmith_processor-1  | WARNINGS:
self-hosted-flagsmith_processor-1  | ?: (axes.W002) You do not have 'axes.middleware.AxesMiddleware' in your settings.MIDDLEWARE.
self-hosted-flagsmith-1            | Operations to perform:
self-hosted-flagsmith-1            |   Apply all migrations: admin, admin_sso, amplitude, api, api_keys, app_analytics, audit, auth, authtoken, axes, contenttypes, custom_auth, datadog, db, dynatrace, environment_permissions, environments, feature_versioning, features, heap, identities, invites, launch_darkly, metadata, mixpanel, multivariate, new_relic, organisation_permissions, organisations, permissions, projects, rest_framework_api_key, rudderstack, segment, segments, sessions, sites, slack, softdelete, tags, task_processor, traits, trench, users, webhook, workflows_core
self-hosted-flagsmith-1            | Running migrations:
self-hosted-flagsmith-1            |   No migrations to apply.
self-hosted-flagsmith-1            | Cache table 'chargebee-objects' already exists.
self-hosted-flagsmith-1            | Cache table 'environment-documents' already exists.
self-hosted-flagsmith-1            | System check identified some issues:
self-hosted-flagsmith-1            |
self-hosted-flagsmith-1            | WARNINGS:
self-hosted-flagsmith-1            | ?: (axes.W002) You do not have 'axes.middleware.AxesMiddleware' in your settings.MIDDLEWARE.
self-hosted-flagsmith-1            | System check identified some issues:
self-hosted-flagsmith-1            |
self-hosted-flagsmith-1            | WARNINGS:
self-hosted-flagsmith-1            | ?: (axes.W002) You do not have 'axes.middleware.AxesMiddleware' in your settings.MIDDLEWARE.
self-hosted-flagsmith-1            | [2023-11-28 09:58:52 +0000] [1] [INFO] Starting gunicorn 20.1.0
self-hosted-flagsmith-1            | [2023-11-28 09:58:52 +0000] [1] [INFO] Listening at: http://<IP_ADDRESS>:8000 (1)
self-hosted-flagsmith-1            | [2023-11-28 09:58:52 +0000] [1] [INFO] Using worker: gthread
self-hosted-flagsmith-1            | [2023-11-28 09:58:52 +0000] [13] [INFO] Booting worker with pid: 13
self-hosted-flagsmith-1            | [2023-11-28 09:58:52 +0000] [14] [INFO] Booting worker with pid: 14
self-hosted-flagsmith-1            | [2023-11-28 09:58:52 +0000] [15] [INFO] Booting worker with pid: 15
self-hosted-flagsmith-1            | axes.handlers.database WARNING  AXES: New login failure by {username<EMAIL_ADDRESS>ip_address: "<IP_ADDRESS>", user_agent: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36", path_info: "/api/v1/auth/login/"}. Created new record in the database.
self-hosted-flagsmith-1            | django.request WARNING  Bad Request: /api/v1/auth/login/
self-hosted-flagsmith-1            | axes.handlers.database WARNING  AXES: New login failure by {username<EMAIL_ADDRESS>ip_address: "<IP_ADDRESS>", user_agent: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36", path_info: "/api/v1/auth/login/"}. Created new record in the database.
self-hosted-flagsmith-1            | django.request WARNING  Bad Request: /api/v1/auth/login/
self-hosted-flagsmith-1            | axes.handlers.database WARNING  AXES: Repeated login failure by {username<EMAIL_ADDRESS>ip_address: "<IP_ADDRESS>", user_agent: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36", path_info: "/api/v1/auth/login/"}. Updated existing record in the database.
self-hosted-flagsmith-1            | django.request WARNING  Bad Request: /api/v1/auth/login/

I can't do it either.

Hi there, there appears to be an issue with the logic that generates the password reset via the CLI, could you please change the ALLOW_ADMIN_INITIATION_VIA_CLI environment variable in your docker compose file / docker environment to false and retry? You should then be able to create an admin user by browsing to e.g. http://localhost:8000/api/v1/users/config/init/ and following the steps.

An alternative solution here would be to set the DJANGO_SECRET_KEY environment variable in your docker environment before startup. You may need to clear down the database volume again before doing this as the functionality relies on there being no user in the database.

This was resolved as of this PR.


Update to netty-tcnative 2.0.1.Final

Cherry-picked into 4.1 (4436d697a6e4a01342a364c05592647f00eb85fc) and 4.0 (5ffd325a610d6fdf48f9584649e4005df450bd49)


The bindgen crate needs to provide streamlined support for components

https://github.com/microsoft/windows-rs/blob/1c720d8dd1db8c519b627a0b4a9fc4edcb10099a/crates/tests/component/build.rs#L15-L26

Marking this as a bug as its quite a bit more complicated than the current release and we should fix it before 0.38.


Explore whether non-academic partners can contribute in writing conversations

[ ] Discuss with Anke on Thursday

First need to resolve issue #18


Polygons on terrain

This is @bagnell's polygon on terrain work-in-progress.  Part of #2172.
It is not ready to be reviewed.
We opened this pull request so we can coordinate testing it the algorithm.

@bagnell can you add a TODO list to this pull request, e.g., jitter on zoom out, texturing, and other things you are still working?

Zoomed in, looking straight down, the multifrustum artifact can be minor:

Or major:

Here is the viewer is not in the volume, but a near plane intersects it.  The artifact in the upper-left slides across the screen as we zoom in:

until is appears OK:

Zooming in a bit farther creates the artifact you mentioned to me offline, but I don't think the viewer is inside the volume.  It looks like it is capturing the terrain skirts (perhaps of the farther frustum?):

Unrelated to polygons on terrain, I get a lot of false collision detection when zooming into Mount St. Helen's that causes the camera to bounce.  We could fix it in a separate PR if it is easy or submit a new issue.

RE: inside volume issue:
I think this is only inside the first frustum, that is why we see the skirts of the second frustum.  Use the Cesium Inspector to Show globe depth to see what I mean.

Well, maybe it is always the first frustum, but this view has two frustums and they are both wrong:

Set debugVolume to true.  Perhaps the vertex shader near plane clamping is wrong as you mentioned offline?
Here is a similar view to the above screenshot but showing the volume:

It might be a bit easier to visualize if we could toggle this on/off and optionally depth test it.

Another way to track this down is to debug with only a single view frustum.  This doesn't have as many artifacts, but still has the same problem when the view is inside the volume and starts to look up.
Try this code:
//Create the viewer.
var viewer = new Cesium.Viewer('cesiumContainer');
var scene = viewer.scene;
scene.terrainProvider = new Cesium.CesiumTerrainProvider({
    url: '//cesiumjs.org/stk-terrain/tilesets/world/tiles',
    requestVertexNormals : true
});
scene.globe.depthTestAgainstTerrain = true;

var positions = [new Cesium.Cartesian3(-2358138.847340281, -3744072.459541374, 4581158.5714175375),
                 new Cesium.Cartesian3(-2357231.4925370603, -3745103.7886602185, 4580702.9757762635),
                 new Cesium.Cartesian3(-2355912.902205431, -3744249.029778454, 4582402.154378103),
                 new Cesium.Cartesian3(-2357208.0209552636, -3743553.4420488174, 4581961.863286629)];

var polygonHierarchy = { positions : positions };

var groundPolygon = scene.primitives.add(new Cesium.GroundPolygon({
    debugVolume : true,
    polygonHierarchy : polygonHierarchy
}));

viewer.scene.farToNearRatio = 100000000.0;

viewer.camera.lookAt(new Cesium.Cartesian3(-2354331.3069306486, -3742016.2427205616, 4581875.591571755), new Cesium.HeadingPitchRange(Cesium.Math.toRadians(20.0), Cesium.Math.toRadians(-35.0), 10000.0));
viewer.camera.lookAtTransform(Cesium.Matrix4.IDENTITY);

viewer.extend(Cesium.viewerCesiumInspectorMixin);

Sandcastle.addToolbarButton('Toggle', function() {
    groundPolygon.debugVolume = !groundPolygon.debugVolume;
});

Then hit the Toggle button to see how the debug volume shading changes when the polygon disappears:

Apologies in advance for the OT nature of this comment.  @pjcozzi what tool(s) are you using to create those nice looking gifs?

http://www.cockos.com/licecap/. @mramato found it recently.

@pjcozzi This is ready for testing with the new method. All of the artifacts you mentioned above should be fixed.
Currently, this only works with polygons and they can only have one hole. It was a custom implementation for testing. I'll be modifying it to work with the general Primitive (as long as the geometry is on the ground).

Have you seen this multifrustum precision (?) issue?

Is the volume high/low enough?  Are we taking into account the curvature of the ellipsoid, not just the min/max terrain height?

Below, I am zoomed in close on the polygon with the hole.  Note the precision issue.  Is this the same as the precision issue above?  Also, it looks like the volume winding order for the interior could be backwards when we get the bottom wall artifact.

Can you also test the volume (including unit tests when we're ready) across the IDL and poles?

Is the volume high/low enough?

You can also test Mount Everest (or anywhere else) with this Sandcastle example:
var viewer = new Cesium.Viewer('cesiumContainer');
var scene = viewer.scene;
scene.terrainProvider = new Cesium.CesiumTerrainProvider({
    url: '//cesiumjs.org/stk-terrain/tilesets/world/tiles',
    requestVertexNormals : true
});
scene.globe.depthTestAgainstTerrain = true;

var deltaX = 20.0;
var deltaY = 10.0;

for (var i = -180.0; i < 180.0; i += deltaX) {
    for (var j = -90.0; j < 90.0; j += deltaY) {

        var positions = [Cesium.Cartesian3.fromDegrees(i, j),
                         Cesium.Cartesian3.fromDegrees(i + deltaX, j),
                         Cesium.Cartesian3.fromDegrees(i + deltaX, j + deltaY),
                         Cesium.Cartesian3.fromDegrees(i, j + deltaY)];

        var polygonHierarchy = { positions : positions };

        var instance = new Cesium.GeometryInstance({
            geometry : new Cesium.PolygonGeometry({
                polygonHierarchy : polygonHierarchy,
                vertexFormat : Cesium.PerInstanceColorAppearance.VERTEX_FORMAT
            }),
            attributes: {
                color: Cesium.ColorGeometryInstanceAttribute.fromColor(Cesium.Color.fromRandom({ alpha : 0.5}))
            },
            id : 'polygon'
        });

        scene.primitives.add(new Cesium.GroundPrimitive({
            geometryInstances : [instance]
        }));
    }
}

Also, it looks like the volume winding order for the interior could be backwards when we get the bottom wall artifact.

I think this is because the volume is not convex.  Try this example:
var viewer = new Cesium.Viewer('cesiumContainer');
var scene = viewer.scene;
scene.terrainProvider = new Cesium.CesiumTerrainProvider({
    url: '//cesiumjs.org/stk-terrain/tilesets/world/tiles',
    requestVertexNormals : true
});
scene.globe.depthTestAgainstTerrain = true;

var pointPrimitives = scene.primitives.add(new Cesium.PointPrimitiveCollection());

var positions = [];
var centerX = -100.0; // in degrees
var centerY = 38.0;
var length = 5.0; // shady
var randomMaxLength = 5.0;
var step = 5.0;

for (var theta = 0.0; theta < 360.0; theta += step) {
    var l = Math.random() * randomMaxLength;
    var x = Math.cos(Cesium.Math.toRadians(theta)) * (length + l);
    var y = Math.sin(Cesium.Math.toRadians(theta)) * (length + l);
    var p = Cesium.Cartesian3.fromDegrees(centerX + x, centerY + y);
    positions.push(p);

    pointPrimitives.add({
        position : p
    });
}

var polygonHierarchy = { positions : positions };

var instance = new Cesium.GeometryInstance({
    geometry : new Cesium.PolygonGeometry({
        polygonHierarchy : polygonHierarchy,
        vertexFormat : Cesium.PerInstanceColorAppearance.VERTEX_FORMAT
    }),
    attributes: {
        color: Cesium.ColorGeometryInstanceAttribute.fromColor(Cesium.Color.fromRandom({ alpha : 1.0}))
    },
    id : 'polygon'
});

scene.primitives.add(new Cesium.GroundPrimitive({
    geometryInstances : [instance]
}));

@pjcozzi This is ready for another look. The issues that we talked about offline with multiple polygons and batching are still issues. Everything you mention above should be fixed.

Multifrustum issue with the Sandcastle example:

The above artifact can also be reproduced with the Ellipse Geometry snippet in the Sandcastle example.
Given how simple the volume is, instead of it being a winding order or geometry issue, perhaps it is due to the size, e.g., overlaps multiple frustums, goes past the far plane, is in front of the near plane, etc.

Using the Corridor snippet, there is a minor precision issue when zoomed in very close.  Unless this is a trivial fix, e.g., add more points, I suggest we submit an issue and not worry about it for this pull request.

The rectangle example is not in good shape:

The Everest code above still has issues:

The issues that we talked about offline with multiple polygons and batching are still issues. Everything you mention above should be fixed.

Can you please add a TODO list to the top of this pull request, e.g., doc, tests, batching, and whatever else?

@pjcozzi This is ready for another look.

This doesn't work in 2D.  Is the globe not writing depth?

Use the Everest code above and check out the north pole:

It's probably a tessellation issue where longitude = 0.

Using the Everest code again, but with:
var deltaX = 10.0;
var deltaY = 5.0;

Are you sure the vertex shader is drop the lower cap far enough below the surface based on the terrain LOD?

If you want to test overlapping non-convex polygons, I modified the star example above:
var viewer = new Cesium.Viewer('cesiumContainer');
var scene = viewer.scene;
scene.terrainProvider = new Cesium.CesiumTerrainProvider({
    url: '//cesiumjs.org/stk-terrain/tilesets/world/tiles',
    requestVertexNormals : true
});
scene.globe.depthTestAgainstTerrain = true;

var numberOfPolygons = 15;
var delta = 40.0; // in degrees

for (var n = 0; n < numberOfPolygons; ++n) {
    var positions = [];
    var centerX = -130.0 + (Math.random() * delta); // in degrees
    var centerY = 25.0 + (Math.random() * delta);
    var length = 5.0; // shady
    var randomMaxLength = 5.0;
    var step = 5.0;

    for (var theta = 0.0; theta < 360.0; theta += step) {
        var l = Math.random() * randomMaxLength;
        var x = Math.cos(Cesium.Math.toRadians(theta)) * (length + l);
        var y = Math.sin(Cesium.Math.toRadians(theta)) * (length + l);
        var p = Cesium.Cartesian3.fromDegrees(centerX + x, centerY + y);
        positions.push(p);
    }

    var polygonHierarchy = { positions : positions };

    var instance = new Cesium.GeometryInstance({
        geometry : new Cesium.PolygonGeometry({
            polygonHierarchy : polygonHierarchy,
            vertexFormat : Cesium.PerInstanceColorAppearance.VERTEX_FORMAT
        }),
        attributes: {
            color: Cesium.ColorGeometryInstanceAttribute.fromColor(Cesium.Color.fromRandom({ alpha : 0.5}))
        },
        id : 'polygon'
    });

    scene.primitives.add(new Cesium.GroundPrimitive({
        geometryInstances : [instance]
    }));
}

They look good.

Let me know when the code is ready for review.

@pjcozzi This is ready for another look and the code is ready for review.

Did you test this on mobile?  If not, can you?

Looks good.  I want to take a second pass through it, but I can wait until it has tests and doc.

@pjcozzi This is ready for another review. Tests and doc are done.

Did you test this on mobile?

Yes, it works well.

How is test coverage (I'm on Mac)?

var primitive = scene.primitives.add(new Cesium.GroundPrimitive({
    geometryInstances : new Cesium.GeometryInstance({
        geometry : new Cesium.PolygonGeometry({
            polygonHierarchy : polygonHierarchy
        }),
        attributes: {
            color: Cesium.ColorGeometryInstanceAttribute.fromColor(Cesium.Color.RED.withAlpha(0.5))
        },
        id : 'polygon1'
    }),
    debugShowBoundingVolume : true
}));

Are we serious?

Might need to address to the min/max height.

@bagnell with the OBB approach we discussed offline, we'll be able to check off the first part of #2861

Use OBB for determining what frustums a command belongs in. This should result in fewer commands overlapping more than one frustum. It will have additional overhead, but perhaps we can exploit temporal coherence to reduce the number of distance checks?

How is test coverage (I'm on Mac)?

Code coverage for GroundPrimitive is at 98%. I needed to add a lot of code to support using other bounding volumes besides BoundingSphere for frustum culling that still needs to be tested.

@pjcozzi This is ready for another look.

In Firefox only, picking is inconsistent.  Check out the blinking when mousing over the green rectangle:

In Firefox only, picking is inconsistent.

This isn't specific to this branch/polygons, see #2942

The GroundPrimitive tests fail in IE.  Can we just bail on them when we don't have stencil bits?
We should also make this more clear in the Sandcastle example.

That's all.  This is basically ready.

Can we just bail on them when we don't have stencil bits?

I checked the spec and depth-stencil renderbuffers must be supported. If you go to the picking Sandcastle example, it still works with a depth-stencil renderbuffer attachment.
The reason it fails in IE is because we need the EXT_frag_depth extension. I added a check to the tests that render.

@pjcozzi This is ready.

@pjcozzi I added an isSupported function like we talked about offline. This is now ready.

Amazing.

Where's the +1 button?  :+1:

@bagnell can you merge master into 3d-tiles and fix the conflicts in Primitive.js and PolygonGeometry.js?  The conflict in Scene.js is just:


Attempting to use AscendEqual

I'm trying to use the AscendEqual function to iterate through entries, but it's not returning the results I'm expecting. I've narrowed the issue down to the following large-ish (sorry) test case:
func TestNameEquals(t *testing.T) {
	iter := func(key, value string) bool {
		i, _ := strconv.Atoi(key)
		fmt.Printf("%2d - %v\n", i, value)
		return true
	}

	j := func(v string, a int) string {
		return fmt.Sprintf("{\"name\":\"%v\", \"age\":%v}", v, a)
	}

	name := func(v string) string {
		return fmt.Sprintf("{\"name\":\"%v\"}", v)
	}

	db, _ := buntdb.Open(":memory:")
	db.CreateIndex("name", "*",
		buntdb.IndexJSON("name"),
		buntdb.IndexJSON("age"),
	)
	db.Update(func(tx *buntdb.Tx) error {
		tx.Set("1", j("bob", 42), nil)
		tx.Set("2", j("james", 55), nil)
		tx.Set("4", j("logan", 14), nil)
		tx.Set("11", j("james", 11), nil)
		tx.Set("3", j("clark", 33), nil)
		tx.Set("5", j("tommy", 15), nil)
		tx.Set("6", j("zane", 19), nil)
		return nil
	})

	db.View(func(tx *buntdb.Tx) error {
		fmt.Println(" -- Greater than d")
		tx.AscendGreaterOrEqual("name", name("d"), iter)

		fmt.Println(" -- Equals James")
		tx.AscendEqual("name", name("james"), iter)

		return nil
	})
}

The output from running the test case is:
=== RUN   TestNameEquals
 -- Greater than d
11 - {"name":"james", "age":11}
 2 - {"name":"james", "age":55}
 4 - {"name":"logan", "age":14}
 5 - {"name":"tommy", "age":15}
 6 - {"name":"zane", "age":19}
 -- Equals James
--- PASS: TestNameEquals (0.00s)

AscendGreaterOrEqual works exactly as expected, but I was hoping that AscendEqual would allow me to iterate only the james entries sorted by the age field. Have I misunderstood the purpose of the function?

Worked a bit more and realized the following (which I perhaps should have caught earlier): Removing the second index makes the AscendEqual work as expected. Alternatively, including the age field in the search term also yields results.
Is there some way to make AscendEqual treat an omitted field in the search term as "wildcard", ie. I do not care about this value?

Is there some way to make AscendEqual treat an omitted field in the search term as "wildcard", ie. I do not care about this value?

I don’t think that that is possible with AscendEqual. It’s meant to grab exact matches.
One idea is to use AscendGreaterOrEqual, which will jump you to the first candidate. Then, from inside the iteration function, do a custom comparison on each item, and then break out of the iterator moves past the possible range.
This is basically how the AscendEquals works. It uses AscendGreaterOrEquals in the hood, and it’s comparison is looking for an exact match.

Thanks for the prompt and helpful reply. Definitely the solution to use.
Just for fun, I also tried to implement an "optional" JSON index, which will not match in case any of the JSON paths offered do not exist. Using that does actually seem to have solved my issue, although I'm not completely sure that I haven't violated the contract of the comparison function in the most obscene way possible or missed some test cases that will break functionality. :)
func IndexJSONOptional(path string) func(a, b string) bool {
	return func(a, b string) bool {
		opa := gjson.Get(a, path)
		opb := gjson.Get(b, path)

		if !opa.Exists() || !opb.Exists() {
			return false
		}

		return opa.Less(opb, false)
	}
}

@haasted I came up with a similar solution to your IndexJSONOptional and I think that it should be fine. But given my brief experiments, it looks like it only works when all optional indices appear last in the multi-index list. I wouldn't really be able to say exactly why, though.


refactor(meta): readability improvements on source manager

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Current dependencies on/for this PR:

main

PR #14170   👈

PR #14171

PR #14172

This stack of pull requests is managed by Graphite.

requested review from 😄s

Need an approval from Cargo.lock @stdrc


Request_Channel

Implementation of Request_Channel interaction type as per https://github.com/ReactiveSocket/reactivesocket/issues/30

@NiteshKant @stevegury @tmontgomery You okay with me adding requestChannel behavior?
We need to update the protocol to support it if so, which I've superficially begun in https://github.com/ReactiveSocket/reactivesocket/pull/42.

Note the method signature:
	/**
	 * @param initialPayload
	 *            The first Payload contained in Publisher<Payload> 'payloads'.
	 *            <p>
	 *            This is delivered each time to allow simple use of the first payload for routing decisions.
	 * @param payloads
	 *            stream of Payloads.
	 * @return
	 */
	public abstract Publisher<Payload> handleChannel(final Payload initialPayload, final Publisher<Payload> payloads);

The initialPayload is unique to this interaction model. It greatly simplifies the channelHandler implementation for routing decisions to have this initialPayload arg. See this unit test setup as an example: https://github.com/ReactiveSocket/reactivesocket-java/blob/b34eca96d2e95d9603a1099e3f955f61d43aad6e/src/test/java/io/reactivesocket/ReactiveSocketTest.java#L107

The use case makes sense.
There'll be one thing that we need to be careful about: because of the propagation lag it's possible that you receive "old events" even after sending another "update request". This seems obvious, but I'm sure you may have subtle bug if you don't pay attention to that.
I'm just saying, it's worth noting in the doc.

Thanks for the review.
Good point on documenting behavior. How do you recommend writing that? I tried writing something and it didn't really help, it just effectively said "this is async messaging" :-)

I briefly reviewed the requestChannel functionality with @stevegury and @NiteshKant so I'm merging this to allow other stuff to progress in master since master is under active development.
Open questions for later change:

documentation
backpressure is not hooked in at all, which the protocol doesn't support right now for a stream of requests


Default Icon

@TylerLeonhardt, @markwragg, @steviecoaster
Thoughts on a default icon (for those platforms that support it)?
In the interest of keeping things generic, my vote is for the (/a) PowerShell logo.

PowerShell logo makes sense to me.
Another option is the logo but just the outline.
Basically just:
[ >_ ]
No background color.

I've swapped out to the above for a default image. Just based on your suggestion above on PowerShell blue using the Hack font.
Will close this for now, anyone can feel free to ship a better one :P

I really like that design!


esp8266

with an esp8266 is it possible to do something? Or is there another lib?

Do you know a lib?

mmm
And it could become a feature

@AugustinMauroy this mostly worked for me: https://github.com/Mixiaoxiao/Arduino-HomeKit-ESP8266

Ok thanks but the lib is little lost


[3311] Consider only distributions issued during current year when calculating year to date quantity

Resolves #3311
Description
Method quantity_year_to_date in Partner model changed so it only considers distributions issued during the current year when calculating total quantity.
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Tested generating PDF for a distribution locally, verified the change through spec.

@dejanbj Merging it in to main now.  We should have a new release around the end of the month.

@dejanbj Thanks for your work on this -- we just released it!  [After far too long]


Update sites.json

Adds "Kununu" and "McVIP" to supported sites

These changes look good--just make sure you fix the missing commas and whitespace for CI and this should be all set to be merged.

Thank you for your contribution!


Workspace edition option not available

I am trying to create ML workspace but I am not able to see the option to select the edition.
This option was available earlier.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2caff87f-9f38-988a-12f3-fc96798e3c99
Version Independent ID: 80ab1cdf-282d-29d6-c146-68d1ce8d00b8
Content: Create workspaces in the portal - Azure Machine Learning
Content Source: articles/machine-learning/how-to-manage-workspace.md
Service: machine-learning
Sub-service: core
GitHub Login: @sdgilley
Microsoft Alias: sgilley

@thecpshah Thanks for the details. @sdgilley Could you please help with workspace edition as we are unable to see whenever we create the machine learning workspace.

@thecpshah,
For more information on the changes to the Enterprise SKU, see "What happened to Enterprise edition"

@thecpshah We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


[DDMD] Add explicit narrowing casts

toInteger returns a 64-bit int, and on 32-bit systems this doesn't implicitly convert to size_t in D.

Auto-merge toggled on

Thanks


import missing

missing random import in layers3.py?

Could you specify the problem, i.e., in which line of the code?

https://github.com/ddddwee1/sul/blob/master/model3.py#L424 - i see  here use of random module,
but I can't find import statement, and my ide also doesn't see it, maybe i miss something in environment?

Thanks for the reminder! Issue is fixed already


filebeat keeps restarting

Hi uschtwill,
checked out your new version. Thanks for the updated tagging. Just maybe something to mention in the description:
when you git clone the repository and then start the package, filebeat keeps restarting. The reason is permissions (unfortunately you only get this message after turning logging of. verbose is of no help here, which is why i share it, as it is not obvious right away):

filebeat2017/09/27 17:24:38.488455 beat.go:339: CRIT Exiting: error loading config file: config file ("filebeat.yml") must be owned by the beat user (uid=0) or root
master-filebeat_1           | Exiting: error loading config file: config file ("filebeat.yml") must be owned by the beat user (uid=0) or root

so you need to chown the .yml to root and all is up and running!
Thanks again for your great work!

Thanks for reporting, @pir1981. Would you up to submitting a PR? I would like that. :)

@pir1981 I tried running chown on the config file to no avail. I assume you are talking about the one in logging/filebeat in the repo, correct?

@packruler yes, I mean the logging/filebeat/filebeat.yml
One more info: If you delete your setup and copy it again, you might need to reset the rights again. I did that today, and was for some reason actually seeing that the file is owned by root, yet was still getting the error message above. chown root:root filebeat.yml fixed it

I believe this is still an issue. I did as told above, in both unsecure and secure, prima/filebeat:5.3.0 continues to restart.


illuminate/http requirement

Hi Nuno,
I encountered a dependency conflict due to the illuminate/http version requirement. The package currently requires version 11, but any chance to allow version 10 as well?
Thanks!

Hi!
absolutely, I shouldn't have started it with such high requirements. lowered to 10.


name '_VariableHandler' is not defined

I have been testing out all the new features in 0.8 dev3.
All of them seemed to work really well, but suddenly this error has occurred..
After it occurred once, whenever I start a new scripted form containing a variable I have the same error again
Do you have any suggestions?
It may be because of the way I installed the package, I transferred the files from the github repository into a 8.0 portable installation I had previously downloaded. Can only get the portable version to function while at work..

Okay, so I have done buckets of work making this nasty little bug go away :). I think I have also managed to knock the issues on the head you might have been having with the start section :) #217
Take scriptedforms-0.9.1.dev2 for a spin and let me know your mileage. :)

@OxygenLithium Okay, so I have done buckets of work making this nasty little bug go away :). I think I have also managed to knock the issues on the head you might have been having with the start section :) #217
Take scriptedforms-0.9.1.dev2 for a spin and let me know your mileage. :)


Feature request: Keep a footnote's lines together

Hi,
Often, my footnotes are long and break across pages. Is there a way to elect to stop this happening?

Almost certainly not unfortunately. Google docs' layout of pages is not
something add ons have much of any control over. You could try formatting
your footnotes as a single long paragraph and use soft line breaks to
separate the text so it looks like paragraphs. No idea if it'll work...
On Thu, 13 Dec 2018, 02:53 OroNZ<EMAIL_ADDRESS>wrote:

Hi,
Often, my footnotes are long and break across pages. Is there a way to
elect to stop this happening?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/davidrthorn/footnote-style/issues/3, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AI_q0NW_Ot-vXrmPVC7PMKgWcHC9PyvXks5u4bMtgaJpZM4ZQx1z
.

Rats. Thanks for looking into that though - I'll 'let my publisher handle it' :P


IMPORT FAILED how o fix this?

Cannot import D:\ComfyUI_BackUp\ComfyUI_windows_portable_nvidia_cu121_or_cpu (3)\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-3D-Pack module for custom nodes: No module named 'kiui'

Hi, please check out this issue


Update pool metrics collector to also take into account the pool of the schedulers

We collect metrics on pool exhaustion and pool usage.
We should make sure to add the pools of the schedulers as well

Hey team! Please add your planning poker estimate with Zenhub @arnaudsjs @hlloreda @Hugo-Inmanta @jptrindade


Temp fix for issue #2042 based on #667's solution

Preflight Checklist

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

Electron Forge Version:

6.0.0-beta-54

Electron Version:

11.2.1

Operating System:

Windows 10 pro, Version 20H2, released date 2020-09-15, 19042.746

Last Known Working Electron Forge version::

6.0.0-beta-54 (with Electron v10)

Expected Behavior
npm run start should start the electron app as usual.
Actual Behavior
npm run start fails with Could not detect abi for version 11.0.1 and runtime electron.
To Reproduce
Not applicable: based on prior proof contained in issue #2042
Additional Information

I have followed issue #667's solution and it works.

To temporarily fix the issue on your machine without waiting for an official release of Forge, you can try deleting your project's node_modules completely and also the package-lock.json if you use npm (for yarn delete yarn lock or something similar).

Then, in your projects folder run npm install and it should not throw the node-abi error anymore.

This isn't really something that can be fixed in Electron Forge itself. As mentioned in other bugs, you need to update the node-abi dependency. Although as of electron-rebuild >= 2.3.4, node-abi is only called if there's actually a native module to rebuild.

This isn't really something that can be fixed in Electron Forge itself. As mentioned in other bugs, you need to update the node-abi dependency. Although as of electron-rebuild >= 2.3.4, node-abi is only called if there's actually a native module to rebuild.


[WIP]must-gather:Adds support to collect ocs related operator logs

This commit adds support to collect storagecluster resources using OCS-must-gather.
Signed-off-by: Rajat Singh<EMAIL_ADDRESS>

cc @ashishranjan738  please have a look.


Error.captureStackTrace polyfill

We could implement it. It would work only by normal mode properly, since by strict mode we cannot use the caller, and so we cannot find the slicing position. A possible alternative solution in non-v8 environment is using the toString() and guess the function based on the name, etc. available in stack. This is far from accurate... Function.caller is another option, I'll check that, but it is deprecated as far as I know.

It would be nice to have this feature, since we would be able to do something like
var container = new ErrorContainer(userError)
Error.captureStackTrace(container, fn);
Object.defineProperty(userError, "stack", {get: cache(function (){return container.stack;})})

By non-v8 strict mode we could degrade to Function.caller or all or nothing by frame shifting... Probably all is a better choice. We could probably add a warning frame about shifting problems...

Just to mention, I hate polyfills, so I need to think about this again...

It cant be there, since it requires the stackAdapter, so this will cause an infinite loop.. :S :S :S

If we want to have a captureStackTrace either we need to polyfill it outside the adapter (since it uses the adapter), or do an adapter, that polyfills and uses it instead of the presentStack we currently have. I think polyfilling it will result the simplest code, but we need modifications on the current system to do that.

If we want to move the presentStack reading to a polyfill, then probably a the pastStack reading should be in a polyfill as well. E.g. Error.getStackTrace(error) would suffice.

Let's check what the cST does:
"use strict";

function a(){
	var x = {};
	Error.captureStackTrace(x);
	return x;
}

function b(){
	return a();
}

var x = b();
console.log(x.stack)

name: message
    at a (file:///C:/Users/inf3rno/Desktop/q.html:9:8)
    at b (file:///C:/Users/inf3rno/Desktop/q.html:14:9)
    at file:///C:/Users/inf3rno/Desktop/q.html:17:9

Error.captureStackTrace(x, a);

name: message
    at b (file:///C:/Users/inf3rno/Desktop/q.html:14:9)
    at file:///C:/Users/inf3rno/Desktop/q.html:17:9

This is the default behavior.
What happens by UserError?
var UserError = function (){
    Error.captureStackTrace(this, this.constructor);
};

I think this is nice...

Deciding about stack availability should be in a higher level, since the captureStackTrace has the constructorOpt, not the low abstraction level helpers. So I should move the code containing the arguments.callee.caller to this function and inject the functionValues into the frame string source. I believe I need to break the frame string source down into multiple small classes, so it will be much easier to understand.

I think the calibration is not the best term here. What does that class do?
I does environment tests and based on the results it creates a new class, that can be used. It is almost the same as by choosing an adapter. Probably developing a pattern for these problems would be the optimal solution. This pattern must be compatible with browserify too, since it has issues... :S #7

var Class;
if (capability(x))
    Class = require("x");
else
    Class = require("y");
return Class;
// or
return new Class();

this is roughly what I need.

By browserify it load both x and y, but sets the value of the Class variable properly.

Let's check some examples with the current code:
var capability = require("capability");

var StackAdapter;

if (capability("Error.captureStackTrace"))
    StackAdapter = require("./v8");
else if (capability("Error.prototype.stack"))
    StackAdapter = require("./non-v8");
else
    StackAdapter = require("./unsupported");

module.exports = StackAdapter;

var FrameStringSource;

module.exports = {
    getClass: function () {
        if (FrameStringSource)
            return FrameStringSource;
        FrameStringSource = Class(AbstractFrameStringSource, {});
        var calibrator = new FrameStringSourceCalibrator();
        if (!calibrator.calibrateClass(FrameStringSource))
            throw new Error("Cannot read Error.prototype.stack in this environment.");
        return FrameStringSource;
    }

};

The first one is more or less okay, but the second one is not okay. What is the problem here? We don't have if-else, since we are trying whether one of the implementations work on the environment. We don't know how many implementations we will have in the future, so we cannot write if-else blocks.

Can we do something similar by the first example?
It would be something like
var alternatives = {
    v8: require("./v8"),
    nonv8: require("./non-v8"),
    unsupported: require("unsupported")
};
var adapter;
for (var i in alternatives)
    try {
        var Class = alternatives[i];
        adapter = new Class();
    } catch(e){
        continue;
    }

It's not that hard. What's  the problem then?
The real problem is, that requiring the v8, non-v8, etc... would throw an error if we had a real analogy.
What can we do?
var alternatives = {
    v8: require("./v8"),
    nonv8: require("./non-v8"),
    unsupported: require("unsupported")
};
var adapter;
for (var i in alternatives)
    try {
        var promise = alternatives[i];
        var Class = promise();
        adapter = new Class();
    } catch(e){
        continue;
    }

var loaders = {
    v8: require("./v8-loader"),
    nonv8: require("./non-v8-loader"),
    unsupported: require("unsupported-loader")
};
var adapter;
for (var i in loaders)
    try {
        var loader = loaders[i];
        var Class = loader();
        adapter = new Class();
    } catch(e){
        continue;
    }

We can have more fancy names by classes, e.g. in this case we have the StackAdapter class and we create a StackAdapter instance.
var stackAdapterComposers = {
    v8: require("./v8-composer"),
    nonv8: require("./non-v8-composer"),
    unsupported: require("./unsupported-composer")
};
var adapter;
for (var i in stackAdapterComposers)
    try {
        var stackAdapterComposer = stackAdapterComposers[i];
        var StackAdapter = stackAdapterComposer.createClass();
        adapter = new StackAdapter();
    } catch(e){
        continue;
    }
module.exports = adapter;

var composer = new CompositeComposer([
    require("./v8-composer"),
    require("./non-v8-composer"),
    require("./unsupported-composer")
]);

var StackAdapter = composer.getClass();
module.exports = new StackAdapter();

CompositeComposer, shit name.

What will we do, when we need an adapter, e.g. by captureStackTrace?
var composer = new Composer(
    function a(){},
    function b(){},
    ....
);
module.exports = composer;

var FrameStringSource = require("./frameStringSourceComposer").getClass();
var frameStringSource = new FrameStringSource();

So yes, we need different naming, we cannot have a ./FrameStringSource module, when we need to use a callback to get the FrameStringSource class.

Another option to use the cache method to do the same:
module.exports = cache(function (){
    // ...
    return Class;
});

var composeFrameStringSource= require("./composeFrameStringSource"),
    FrameStringSource = composeFrameStringSource();
var frameStringSource = new FrameStringSource();

We have 2 options here:

put everything into the ./composeFrameStringSource module
create very small modules, which contain the different implementations, but define only classes or functions instead of running anything. only the compose function can call any code, the others are not prepared for that...

Created a polyfill from the FrameSourceAdapter using these techniques.

I need to move the arguments.callee.caller code to a higher level, so to the Error.captureStackTrace from the FrameStringSource. After that I can start to work on the Error.prepareStackTrace polyfill.


trying to open the satellite bay

I'm playing on all the mods 3 Version: v5.9.8d
Im playing on a friends server and im trying to make my first ship launch everything should be working (i have played this mod alot) but when i build the ship it has a sat bay and a guidence computer aswell as a seat when i try to access the sat bay after building the ship (when the ship becomes an entity not just blocks) i get this error that crashes just my game not the server and i havent found a reason yet and was hoping some one here might be able to help.
This is the direct crash message from the Minecraft launcher:
The game crashed whilst unexpected error
Error: java.lang.RuntimeException: World (zmaster587.advancedRocketry.world.util.ProviderDummy) does not have BetweenlandsWorldStorage capability
and here is the paste bin link: https://pastebin.com/6waRGDfR

Can you try build 101?  Betweenlands issue was patched only added 3 days ago.


Dragging a file from Explorer over top of a WebView2 in the application window will launch another process

Describe the bug
I am working on a project that is basically an alternative to the Event Viewer MMC snap-in where we load evtx files and parse and display those events. Recently, I have noticed that dragging and dropping a .evtx files onto the application window is now launching an additional application process. If go into settings and change the .evtx extension default handler back to the Event View MMC then dragging and dropping a file onto the window will launch the Event Viewer MMC snap-in.
There have been no code changes to how we handle OnDrop or OnDragging and I have not been able to pinpoint any specific change around when this issue started. If I install a previous version of the app before the issue started then it does not repro but if I roll back to the commit tied to that release then I can reproduce the issue again. I have also tested previous .NET SDK versions with no success.
My suspicion is that it may be tied to the fix for the following issue that was recently resolved but do not have any hard evidence against this right now.
https://github.com/microsoft/microsoft-ui-xaml/issues/7366
I have been able to reproduce this issue on a clean MAUI Hybrid project in VS 17.9.
Initially filed this over on the Maui repo but was recommended to bring this issue over here.
https://github.com/dotnet/maui/issues/22556
Steps to reproduce the bug

Create New Project > .NET MAUI Blazor Hybrid App
Add the following to MainPage.xaml inside BlazorWebView

<BlazorWebView.GestureRecognizers>
    <DropGestureRecognizer AllowDrop="True" />
</BlazorWebView.GestureRecognizers>

Run the app and drag a file over the window and 2 ghost icons will show up

Release the mouse button and the default application for the extension of the file being dragged will be launched. In the case of the above screen shot, dragging a .PML file over the window and releasing will launch procmon

Expected behavior
App should be able to handle this file via OnDrop and no other applications should be launched
Screenshots
No response
NuGet package version
None
Windows version
Windows 11 (22H2): Build 22621
Additional context
No response

If it helps, it seems like it may be EmbeddedBrowserWebView!base::LaunchProcess that is making the call to CreateProcess that results in the default extension handler in windows launching based on the extension.
kernel32.dll!CreateProcessWStub
windows.storage.dll!CInvokeCreateProcessVerb::CallCreateProcess
EmbeddedBrowserWebView.dll!base::LaunchProcess
EmbeddedBrowserWebView.dll!embedded_browser_webview::internal::WebViewFactory::EnsureConnection
EmbeddedBrowserWebView.dll!embedded_browser_webview_current::EmbeddedBrowserWebView::CreateWebViewOnIOThread
<snip>

Looks like this is the last version that doesn't reproduce the issue
<PackageReference Include="Microsoft.Maui.Controls" Version="8.0.14" />
<PackageReference Include="Microsoft.Maui.Controls.Compatibility" Version="8.0.14" />
<PackageReference Include="Microsoft.AspNetCore.Components.WebView.Maui" Version="8.0.14" />

Curious as to why this regression is being closed as not planned? This is a major accessibility feature for our app that is widely used by CSS and not fixing this regression will result in us being unable to update to latest WebView.

@jschick04 apologies. I mistook your last comment that this was fixed in the last release. Could you provide a simple repro project for this in WinUI3 (not MAUI?). EmbeddedBrowserWebview.dll is not part of WinUI. Let me follow up to find more.

I will see if I can repro this with a WinUI project.
My app and the repro provided above was done with Maui hybrid and I initially opened an issue with Maui and was directed to this repro (issue linked in the first comment).

Ok, I was able to reproduce the issue by creating a WinUI3 project and adding the following to MainWindow.xaml
<WebView2 x:Name="webView" AllowDrop="True" DragOver="OnDragOver" Drop="OnDrop"></WebView2>
Inside of MainWindow.xaml.cs I replace MainWindow constructor with the following and add the OnDragOver function to allow the copy operation.
public MainWindow()
{
    InitializeComponent();

    webView.Source = new Uri("https://www.bing.com");
}

private void OnDragOver(object sender, DragEventArgs e)
{
    e.AcceptedOperation = DataPackageOperation.Copy;
}

private void OnDrop(object sender, DragEventArgs e) { }

Running the application will show the double icons as shown in the initial post. This scenario doesn't launch the default extension handler but will launch a separate window with a prompt to download the file that I drag over the application.

There is an API to intercept the new window creation – have you tried using that to see if you can achieve the experience you want? The code below works for me. It automatically downloads the file without asking for consent, but I assume that can be added in the code below if needed.
webView.CoreWebView2.NewWindowRequested += CoreWebView2_NewWindowRequested;

private void CoreWebView2_NewWindowRequested(Microsoft.Web.WebView2.Core.CoreWebView2 sender, Microsoft.Web.WebView2.Core.CoreWebView2NewWindowRequestedEventArgs args)
{
    args.Handled = true;
    this.webView.Source = new Uri(args.Uri);
}

Using the NewWindowRequested callback and just setting args.Handled = true prevents the new window but still shows the double icon. I can probably work around this by just disabling the icon and text from the XAML side.
I will need to see how I can adapt this to Maui Hybrid to see if it works around the issue there and to see how this interacts with the addition of the drag handlers on the web side of things. This was another issue that I ran into is the WebView2 drag/drop functionality did not play well with Blazor Hybrid but that is another issue for when we can go back to using the most recent version of WebView2.
Ideally it seems that WebView2 should respect the drag/drop handlers from the XAML side or XAML should defer to WebView2 if that is where the drag/drop functionality is going to have to be configured. Or maybe a global option to configure XAML or WebView2 as the default handler for drag/drop, especially since it looks like the addition of drag/drop functionality from WebView2 is where this all started.

Looks like this workaround isn't viable for Maui or at least I cannot find the NewWindowRequested callback for how this is implemented with Maui Hybrid.


The artifacts/extract directory is never cleaned

See original issue on GitLab
In GitLab by [Gitlab user @tacgomes] on Aug 7, 2018, 15:17
Summary
The artifacts/extract directory is never cleaned after BuildStream terminates.
Steps to reproduce

bst build $somebst
bst checkout $somebst dir

What is the current bug behavior?
The artifacts/extract directory has debris when BuildStream terminates.
What is the expected correct behavior?
The artifacts/extract directory is empty when BuildStream terminates.
Possible fixes

Clean directory at startup.
Clean the directory whenever the cache size exceeded the quota.

In GitLab by [Gitlab user @toscalix] on Aug 20, 2018, 09:14
assigned to [Gitlab user @valentindavid]

In GitLab by [Gitlab user @toscalix] on Aug 20, 2018, 09:19
marked this issue as related to #584

In GitLab by [Gitlab user @valentindavid] on Aug 20, 2018, 16:19
mentioned in commit ed1e78b9b2274aa227f1403e25a4145eb1fe3cc3

In GitLab by [Gitlab user @valentindavid] on Aug 20, 2018, 16:23
mentioned in merge request !685

In GitLab by [Gitlab user @valentindavid] on Aug 20, 2018, 16:37
mentioned in commit 970008b75037fecb1835627bed7eb99485e101e9

In GitLab by [Gitlab user @valentindavid] on Aug 22, 2018, 10:11
mentioned in commit 2dc881a108d1d7ba2fda78b2797b46dd3aa558c7

In GitLab by [Gitlab user @valentindavid] on Aug 23, 2018, 09:02
mentioned in commit 2ac654a834fa4636f0c604b5b63571db3aa27a87

In GitLab by [Gitlab user @valentindavid] on Aug 23, 2018, 09:04
mentioned in commit 3e1ea8d9772c2c2abc879d2a38dfb4440f6ba801

In GitLab by [Gitlab user @tristanvb] on Aug 23, 2018, 10:10
closed via merge request !685

In GitLab by [Gitlab user @valentindavid] on Aug 23, 2018, 10:10
closed via commit 2ac654a834fa4636f0c604b5b63571db3aa27a87

In GitLab by [Gitlab user @tristanvb] on Aug 23, 2018, 10:10
mentioned in commit 176aa09fba06d478c6d138400e855e85e6526a19


help me image appear at editor

Duplicate https://github.com/Microsoft/vscode/issues/59682

We are building exploration builds that use a much newer version of Electron (our UI framework). I wonder if this issue reproduces with one of these builds, could you try? Download:

macOS: Download
Linux: Download
Windows: Download


Backtesting issue

Interested in this project and possibly working on it more. Just starting out with ML but I was curious to try and figure out the issue with the backtesting. From what I can tell it is that you are training the model on future data but then making predictions for stocks in the past...
It seems like the solution would be to first, randomly select the year you'd like to predict and then ensure the spit for both training and test is only run on years before that. Just wanted to check and see if I'm right about at least the issue. Feel free to drop me an email (on my profile) if you'd rather talk there, I know you said you want to let other people try and figure it out.

Yeap, that's correct!


polymer-cli global install error

Description
npm error when running npm install -g polymer-cli as root.
This is done in CI process in a Docker container.
Versions & Environment

Polymer CLI: 1.3.1
node: 8.2.1
npm: 5.3.0
Operating System: Debian 8

Steps to Reproduce
To reproduce, build this Dockerfile:
FROM node
RUN npm install -y polymer-cli

Expected Results
NPM should install polymer-cli without an error.
Actual Results
We get an error in the output and the installation exists with error code 1:
><EMAIL_ADDRESS>install /usr/local/lib/node_modules/polymer-cli/node_modules/wd
> node scripts/build-browser-scripts

/usr/local/lib/node_modules/polymer-cli/node_modules/mkdirp/index.js:90
                    throw err0;
                    ^

Error: EACCES: permission denied, mkdir '/usr/local/lib/node_modules/polymer-cli/node_modules/wd/build'
    at Object.fs.mkdirSync (fs.js:891:18)
    at sync (/usr/local/lib/node_modules/polymer-cli/node_modules/mkdirp/index.js:71:13)
    at Object.<anonymous> (/usr/local/lib/node_modules/polymer-cli/node_modules/wd/scripts/build-browser-scripts.js:6:1)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Function.Module.runMain (module.js:605:10)
    at startup (bootstrap_node.js:158:16)
npm info lifecycle<EMAIL_ADDRESS>Failed to exec install script
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node scripts/build-browser-scripts`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2017-08-02T04_53_27_270Z-debug.log

The log file mentioned in the output says:
...
24890 silly install<EMAIL_ADDRESS>24891 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>24892 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle false
24893 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/local/lib/node_modules/npm/bin/node-gyp-bin:/usr/local/lib/node_modules/polymer-cli/node_modules/wd/node_modules/.bin:/usr/local/lib/node_modules/polymer-cli/node_modules/.bin:/usr/local/lib/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
24894 verbose lifecycle<EMAIL_ADDRESS>CWD: /usr/local/lib/node_modules/polymer-cli/node_modules/wd
24895 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'node scripts/build-browser-scripts' ]
24896 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
24897 info lifecycle<EMAIL_ADDRESS>Failed to exec install script
24898 verbose unlock done using /root/.npm/_locks/staging-3a08f0df5026584d.lock for /usr/local/lib/node_modules/.staging
24899 verbose stack Error<EMAIL_ADDRESS>install: `node scripts/build-browser-scripts`
24899 verbose stack Exit status 1
24899 verbose stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:289:16)
24899 verbose stack     at emitTwo (events.js:125:13)
24899 verbose stack     at EventEmitter.emit (events.js:213:7)
24899 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:40:14)
24899 verbose stack     at emitTwo (events.js:125:13)
24899 verbose stack     at ChildProcess.emit (events.js:213:7)
24899 verbose stack     at maybeClose (internal/child_process.js:921:16)
24899 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
24900 verbose pkgid<EMAIL_ADDRESS>24901 verbose cwd /
24902 verbose Linux 4.10.0-29-generic
24903 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "-g" "polymer-cli@next"
24904 verbose node v8.2.1
24905 verbose npm  v5.3.0
24906 error code ELIFECYCLE
24907 error errno 1
24908 error<EMAIL_ADDRESS>install: `node scripts/build-browser-scripts`
24908 error Exit status 1
24909 error Failed at the<EMAIL_ADDRESS>install script.
24909 error This is probably not a problem with npm. There is likely additional logging output above.
24910 verbose exit [ 1, true ]

Workarounds:
Using node:6 as the base image, works out fine.

Error still exists and sudo npm install -g polymer-cli --unsafe-perm still fixes it.

Using the option
--unsafe-perm
works fine with me to solve the permission denied issue..

--unsafe-perm didn't work for me. The problem was that I had no permissions in the folder, so I used:
sudo chown -R myuser:myuser .
and it solved the problem


strongly typed config properties that are enum types throw an exception when read

to work around this issue, use the Get method, or Dictionary<string, string> to specify your configuration.

Are these kinds of issues "up for grabs"? Or are they being swept up into the big revamp PR?

go for it on this one! the way to do this is target the mhowlett/gooderr branch, which is 5 PR levels deep on top of master, then when everything is merged up to master retarget the PR to master (and there won't be any issues). thanks for the help!


Naming bug on doScan()

Line name = strings.Replace(name, alias+"_", "", 1)
in doScan() causes an issue if alias+"_" is part of the column name. Eg.
column name: "order_id", alias "r" will produce "ordeid" and hence fail.
For now make sure your alias+"_" is not part of a column name.

Are you using ColumnsAliased to generate your column names?

Yes I am using ColumnsAliased


SO-4892: field selection support

This PR adds a new field query parameter to all list and get endpoint to restrict the payload size of the returned result and make fetching of documents as fast as possible.

Codecov Report

Merging #858 (2ee0ada) into 8.x (b69b88a) will increase coverage by 0.02%.
The diff coverage is 68.13%.

:exclamation: Current head 2ee0ada differs from pull request most recent head 5c3b8eb. Consider uploading reports for the commit 5c3b8eb to get more accurate results

@@             Coverage Diff              @@
##                8.x     #858      +/-   ##
============================================
+ Coverage     60.57%   60.60%   +0.02%
- Complexity    11079    11096      +17
============================================
  Files          1651     1651
  Lines         54277    54341      +64
  Branches       5267     5278      +11
============================================
+ Hits          32880    32932      +52
- Misses        19267    19278      +11
- Partials       2130     2131       +1

Impacted Files
Coverage Δ

.../core/rest/commit/RepositoryCommitRestService.java
9.37% <0.00%> (-2.17%)
:arrow_down:

...2international/snowowl/core/commit/CommitInfo.java
0.00% <0.00%> (ø)

...snowowl/snomed/core/domain/SnomedRelationship.java
79.46% <ø> (-0.54%)
:arrow_down:

...e/converter/SnomedReferenceSetMemberConverter.java
59.43% <0.00%> (ø)

...d/datastore/index/entry/SnomedConceptDocument.java
71.83% <ø> (ø)

...nowowl/core/rest/resource/ResourceRestService.java
45.83% <11.11%> (-5.39%)
:arrow_down:

...nomed/core/rest/SnomedReferenceSetRestService.java
53.40% <50.00%> (-0.08%)
:arrow_down:

.../datastore/request/SnomedConceptSearchRequest.java
66.91% <50.00%> (-0.52%)
:arrow_down:

...m/b2international/index/es/EsDocumentSearcher.java
76.20% <57.14%> (+0.58%)
:arrow_up:

...b2international/index/mapping/DocumentMapping.java
72.02% <75.00%> (+0.50%)
:arrow_up:

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b69b88a...5c3b8eb. Read the comment docs.


footer is now bottom bound

Summary of changes
Provide a detailed description of proposed changes.
Proposed area of change
Put an x in the boxes that apply.

[x] apps/bridge-dapp
[ ] apps/stats-dapp
[ ] apps/webbsite
[ ] apps/faucet
[ ] apps/tangle-website
[ ] libs/webb-ui-components

Reference issue to close (if applicable)
Closes #1097
Screen Recording
If possible provide a screen recording of proposed change.

Code Checklist
Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

@vutuanlinh2k2 let's also make the footer the minimal version, which is just the social tags as depicted in the issue.

Dark theme is off: @vutuanlinh2k2

@monaiuu can you review this when you can please. The design aesthetics of the minimal footer does not seem fitting. Would like your thoughts.

Footer Update
Please reference to the Figma design system (footer page)for the updated footer component on both light and dark mode.
For some context, we will remove the background colour of the footer component in anticipation of the updated swirl background image.
Screenshots

@vutuanlinh2k2 @dutterbutter

There seems to also be a bug (unsure if introduced here) with respect to light/dark theme switching.
https://www.loom.com/share/d688378cf6bc42bf936e120cc938404a

Is this ready to merge do @AtelyPham ?


[WIP] Add reference docs for pod PreStop hooks

Description
This PR introduces automated, testable documentation for Kubernetes Pod Lifecycle Behaviors, with a focus on PreStop hook behaviors. It leverages a Python script to dynamically populate placeholders in Markdown files with test-backed autogenerated documentation, covering the following:
Behavior Steps: Provides a clear understanding of the flow of lifecycle behaviors.
Behavior Logs: Displays expected logs to help end users validate complex behaviors.
Behavior Pod Specifications: Includes YAML configurations relevant to the behaviors being documented.
The script ensures consistent formatting and accuracy by using placeholders. Two Markdown files—area.md and area-postinsertion.md are included to validate the content before and after running the script.
Issue
Closes: kubernetes/kubernetes#126369

@steve-hardman We are restructuring the pod lifecycle events and I am performing a demo to generate documentation from the lifecycle event test cases along with @SergeyKanzhelev @tallclair. Will add some description and make this
a draft pull request.

/sig node

BTW if this is documenting something for v1.32, please set the base branch to dev-1.32

You'll find https://kubernetes.io/docs/contribute/style/style-guide/ helpful @impact-maker - please check against that before marking this ready for review.

@impact-maker you need to sign a copyright agreement before we can formally review this - see https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/51478266/48342/#/?version=2
An approver may close this PR if we don't see that covered.

@sfTim Could you assist with reviewing this pull request? @SergeyKanzhelev, your feedback and insights would be greatly valuable as I am making merge ready documentation.

I looked at https://deploy-preview-48342--kubernetes-io-main-staging.netlify.app/docs/reference/lifecycle-events/hooks/prestop/ - the preview for these changes
I think if a reader saw that page, as it appears right now, they might well file a bug report.
Here's a screenshot of what they'd see:

So, is this a work-in-progress? It doesn't look like a change we could merge as is.

@sftim  I am looking to get the work approved and ideally merge ready, I have created a slack thread for all the follow up questions. Aslo I have already got an approval from sig-docs on this work in the community biweekly meeting and looking got a wholesome review on this so that I can iterate over this and close it.


Initialize bools in the headers in editor/

This PR is a codestyle enhancement which initializes bools in the headers instead of the constructors. I only did this for the editor/ folder. I also deleted a few unused bools - future PRs can add them back if they're needed.

Thanks!


make-vis-flexible does not work with grid

The FlexibleXYPlot component does not resize correctly when using CSS grid. We suspect this is an issue within make-vis-flexible and the xy-plot component. There's an assumption that the parent component will always, and accurately, downsize "correctly". In the case of CSS grid, that isn't true.
The child component's explicitly set width will override any upstream re-flows and re-renders. In our specific case, that implies that our graph will only act responsively when the browser window is increased in size, not when it's decreased.
Unexpected behavior:

use CSS grid
load page
make page smaller
chart overflows in the x-axis

Internally set, explicit width:

Trivial example:
https://codepen.io/anon/pen/vvJBoM?editors=1100
Naive suggestions to fix:
There's likely context that we're missing, but it seems peculiar to have "two separate components" for flexible and non-flexible plots. IMHO all charts should be flexible, and their size should be constrained by their parent components only. Internally, they should always strive to expand to 100%.
Calculating the the width of the component and setting it via JS (in React) is prone to exactly this type of issue. We suspect this was for a reason. Likely due to the needs of internal calculations for plotting data, animations, etc. Ideally we'd love to see (and help!) with making this styling less JS-centric, more CSS-native, and possibly condensed into one component.
This is a lot to ask, and we're happy to help. We'll need feedback first.
Thanks!

Had this same issue with grid and <FlexibleXYPlot>. The plot width would only increase, and not decrease.
<AutoSizer> from react-virtualized seems to work well.
Pseudo code for the workaround I used:
import AutoSizer from 'react-virtualized-auto-sizer'

// ...

<AutoSizer>
  {({ width }) => (
    <div className="plot">
      <XYPlot
        height={150}
        width={width}
      >
        // .....
      </XYPlot>
    </div>
  )}
</AutoSizer>


Add vizviewer and make perfetto work

add vizviewer and let --open use vizviewer

Codecov Report

Merging #99 (47655f5) into master (de92708) will decrease coverage by 1.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   99.79%   98.51%   -1.29%
==========================================
  Files          20       21       +1
  Lines        1990     2024      +34
==========================================
+ Hits         1986     1994       +8
- Misses          4       30      +26

Impacted Files
Coverage Δ

src/viztracer/main.py
98.42% <ø> (-1.58%)
:arrow_down:

src/viztracer/util.py
100.00% <ø> (+9.75%)
:arrow_up:

src/viztracer/__init__.py
100.00% <100.00%> (ø)

src/viztracer/viewer.py
100.00% <100.00%> (ø)

src/viztracer/report_builder.py
94.59% <0.00%> (-5.41%)
:arrow_down:

src/viztracer/viztracer.py
94.92% <0.00%> (-5.08%)
:arrow_down:

src/viztracer/patch.py
95.28% <0.00%> (-4.72%)
:arrow_down:

src/viztracer/simulator.py
96.77% <0.00%> (-3.23%)
:arrow_down:

src/viztracer/flamegraph.py
97.59% <0.00%> (-2.41%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de92708...47655f5. Read the comment docs.


[AutoRelease] t2-databoxedge-2023-02-13-46178(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/3763
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1337

issue link:https://github.com/Azure/sdk-release-request/issues/3763


How to use the Standalone HydroDyn

Hi, i want  to use the standalone HydroDyn to get the wave's results.  I have download the  HD_v2.05.00.exe, and expanded archive into  my folder. But when i run it from the DOS command prompt, i get an error messages：

Would you mind to tell me  how to solve this error?
Thanks!

There may be an issue with how this version of the HydroDyn driver parses relative paths. It probably thinks the paths are relative to where you are running the code, not relative to the Test_001.dvr file location. I would try to either (1) cd into your C:\Users\user\Desktop\FJTJ\wave\HydroDyn\CertTest directory and run the code from there or (2) change the HDInputFile parameter to be the full file location instead of a relative file location (i.e., C:\Users\user\Desktop\FJTJ\wave\HydroDyn\CertTest\Test_001.dat. The OutRootName probably has the same issue.

Hi ,thank you very much for your reply. I have obtained the calculation result according to your first suggestion.


ingest/ledgerbackend: getLogLineWriter() leaks goroutines and pipes

getLogLineWriter() creates a pipe and a goroutine, but the goroutine never exists (and the pipe is never released).
Every time captive core is restarted this causes a leak.
The easiest fix is probably returning a CloseWriter and making sure that the writer is closed (releasing the pipe and the goroutine).

Discovered while investigating https://github.com/stellar/soroban-rpc/pull/207

It turns out the goroutines are closed in many places but something must be amiss, since they are still left behind in some cases. All the (*pipe).read goroutines in this dump are from Closed() core ledger backends:

I think stellarCoreRunner.handleExit() may not be closing the pipes in some cases

Here's another dump:

It looks like there are createCmd calls where we do not close the log line writers:
https://github.com/stellar/go/blob/a4e5a3fc6664f7cf6b26fb3196b366910563636f/ingest/ledgerbackend/stellar_core_runner.go#L311
https://github.com/stellar/go/blob/a4e5a3fc6664f7cf6b26fb3196b366910563636f/ingest/ledgerbackend/stellar_core_runner.go#L400-L404
https://github.com/stellar/go/blob/a4e5a3fc6664f7cf6b26fb3196b366910563636f/ingest/ledgerbackend/stellar_core_runner.go#L311


Guild Create handler does not cache Guild Members

Is your feature request related to a problem? Please describe.
Rn guild create handler does not cache members itsn't so a big problem that we are not caching them so what do you guys think?
Describe the solution you'd like Cache the members
Describe alternatives you've considered Don't cache the members cause it is not really necessary but idk

@Skillz4Killz

We need to fix this


BMR Calculator

@PamThanrada
Your PR will be merged soon in the meantime give a star to the repo if it helps 🙌🏻

@PamThanrada
Your PR has been successfully merged Thank you so much for your valuable contribution. Do give a follow if it helped you and star the repo and check other repo too for more contribution. Keep hacking


CFR header style updates

Style intro CFR change description.
Correct section header width per eregs/notice-and-comment#130

NOTE: There's a slight issue with CFR ToC links where it appends the hash of the CFR section number so it will anchor page load to the section number instead to the top of the page that shows the change description.

Heads up, branch conflict

We'll figure out the templates; I'm betting they've not been right from the beginning.


fix: propagate async context in callbacks

Fixes #1751
I've tested this on Windows with real hardware (repro'ed the issue in #1751). I can't get WSL to work with a serial port right now to test on Ubuntu.
I can't think of a good way to make this commit smaller. AsyncResource needs to be constructed with a const char* name unique to each of your structs (so can't inherit from some other class that extends AsyncResource). Constructing the AsyncResource (in a ctor or initializer list) makes it necessary to initialize everything else that you were relying on value-initialization for. Rather than only initializing the members that you're not setting where the structs are used, I went with the safer option of initializing (almost) everything explicitly. Using more C++ features (std::strings) would shorten the code overall (possibly making initialization unnecessary) but would make this commit even bigger. /ramble

Urgh, those CI failures are due to a GCC bug that's fixed in 4.10.0, I think (see https://travis-ci.org/node-serialport/node-serialport/builds/475554563, which used GCC5 and was successful).
I can't figure out how NAN's AsyncResource test, which uses the same syntax, builds with 4.8.5 (e.g. https://travis-ci.com/nodejs/nan/jobs/166028162). Anyone see something I'm missing?

It looks like the compile error messages are pointing at the wrong lines of code and that it's actually the non-static data member initializers for strings like this one or this one that are causing the errors.
There's an online compiler for doing some tests with gcc 4.8, for example, this doesn't work and shows the compile error "array used as initializer", but this works and displays "all ok".
If the non-static data member initializers for strings are replaced with code in the constructor I think it will work.


We have two different claim list test files

no claims test file for claimant and one for approver

some how "main activity.java" has been renamed, so I changed it on the files to the new name ClaimantClaimsListActivity

I changed that names of two files because I realized the one I was working on should have been the ClaimantClaimsListTest.java and the one that was called that was actually just testing Claims not the ClaimsList hence I renamed it ClaimTest. Sorry for the confusion if this is what you're refering to.


Modify Login Page Responsive

I like to modifying the login page.
Issue: Form and footer is Not responsive.
So please assign me to resolve this issue.

@Vasanth1009 Assigned!


New ofb cipher stream failing

The current update is not working on a hardware sgx enclave. It's failing with:
Illegal instruction (core dumped)
This is happening during the AesOfb key creation: https://github.com/integritee-network/worker/blob/master/enclave/src/aes.rs#L70
The problem seems to be the new cipher dependency of ofb:
Old Verison:
https://github.com/RustCrypto/stream-ciphers/blob/ofb-v0.1.1/ofb/src/lib.rs#L83-L91
fn new_var(key: &[u8], iv: &[u8] ) -> Result<Self, InvalidKeyNonceLength> {
        if Self::NonceSize::to_usize() != iv.len() {
            Err(InvalidKeyNonceLength)
        } else {
            let cipher = C::new_varkey(key).map_err(|_| InvalidKeyNonceLength)?;
            let mut block = GenericArray::clone_from_slice(iv);
            cipher.encrypt_block(&mut block);
            Ok(Self { cipher, block, pos: 0 })
        }
    }

new version:
https://github.com/RustCrypto/traits/blob/master/cipher/src/lib.rs#L66-L77
#[inline]
    fn new_from_slices(key: &[u8], nonce: &[u8]) -> Result<Self, InvalidLength> {
        let kl = Self::KeySize::to_usize();
        let nl = Self::NonceSize::to_usize();
        if key.len() != kl || nonce.len() != nl {
            Err(InvalidLength)
        } else {
            let key = GenericArray::from_slice(key);
            let nonce = GenericArray::from_slice(nonce);
            Ok(Self::new(key, nonce))
        }
    }

The error only occurs in ofb version 0.5.1. In v0.4.0 (=> cipher version 0.2.0) it is working. But since we don't want to be stuck on v0.4.0 we will need to look into this problem somewhen in the near future.

Also: Be careful here - GA will not detect HW errors.


Building SimpleRTK under Windows 64bit

Hi,
I'm trying to build SimpleRTK with Python wrapping. Unfortunately, I'm getting the following error:
[ 22%] Performing build step for 'SimpleRTK'
Scanning dependencies of target SimpleRTKCommon
[  1%] Building CXX object Code/Common/src/CMakeFiles/SimpleRTKCommon.dir/srtkImage.cxx.obj
In file included from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/srtkPixelIDTypeLists.h:26:0,
                 from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/srtkMemberFunctionFactoryBase.h:26,
                 from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/srtkDetail.h:21,
                 from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/srtkImage.h:23,
                 from c:/RTK-master/utilities/SimpleRTK/Code/Common/src/srtkImage.cxx:18:
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::Visit<TTypeList>::operator()(Predicate&)':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:326:43: error: expected primary-expression before '>' token
     visitor.CLANG_TEMPLATE operator()<Head>( );
                                           ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:326:46: error: expected primary-expression before ')' token
     visitor.CLANG_TEMPLATE operator()<Head>( );
                                              ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:328:45: error: expected primary-expression before '>' token
     next.CLANG_TEMPLATE operator()<Predicate>( visitor );
                                             ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::Visit<TTypeList>::operator()(const Predicate&)':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:335:43: error: expected primary-expression before '>' token
     visitor.CLANG_TEMPLATE operator()<Head>( );
                                           ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:335:46: error: expected primary-expression before ')' token
     visitor.CLANG_TEMPLATE operator()<Head>( );
                                              ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:337:45: error: expected primary-expression before '>' token
     next.CLANG_TEMPLATE operator()<Predicate>( visitor );
                                             ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::DualVisit<TLeftTypeList, TRightTypeList>::operator()(Visitor&) const':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:378:50: error: expected primary-expression before '>' token
     return impl.CLANG_TEMPLATE operator()<Visitor>( visitor );
                                                  ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::DualVisit<TLeftTypeList, TRightTypeList>::operator()(const Visitor&) const':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:385:50: error: expected primary-expression before '>' token
     return impl.CLANG_TEMPLATE operator()<Visitor>( visitor );
                                                  ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::DualVisitImpl<TLeftTypeList, TRightTypeList>::operator()(Visitor&) const':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:417:45: error: expected primary-expression before '>' token
     goLeft.CLANG_TEMPLATE operator()<Visitor>( visitor );
                                             ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::DualVisitImpl<TLeftTypeList, TRightTypeList>::operator()(const Visitor&) const':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:427:45: error: expected primary-expression before '>' token
     goLeft.CLANG_TEMPLATE operator()<Visitor>( visitor );
                                             ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::DualVisitImpl<TLeftTypeList, TRightTypeList>::visitRHS(Visitor&) const':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:433:47: error: expected primary-expression before ',' token
     visitor.CLANG_TEMPLATE operator()<LeftHead, RightHead>( );
                                               ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:433:58: error: expected primary-expression before '>' token
     visitor.CLANG_TEMPLATE operator()<LeftHead, RightHead>( );
                                                          ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:433:61: error: expected primary-expression before ')' token
     visitor.CLANG_TEMPLATE operator()<LeftHead, RightHead>( );
                                                             ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:436:44: error: expected primary-expression before '>' token
     goRight.CLANG_TEMPLATE visitRHS<Visitor>( visitor );
                                            ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::DualVisitImpl<TLeftTypeList, TRightTypeList>::visitRHS(const Visitor&) const':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:441:47: error: expected primary-expression before ',' token
     visitor.CLANG_TEMPLATE operator()<LeftHead, RightHead>( );
                                               ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:441:58: error: expected primary-expression before '>' token
     visitor.CLANG_TEMPLATE operator()<LeftHead, RightHead>( );
                                                          ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:441:61: error: expected primary-expression before ')' token
     visitor.CLANG_TEMPLATE operator()<LeftHead, RightHead>( );
                                                             ^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:444:44: error: expected primary-expression before '>' token
     goRight.CLANG_TEMPLATE visitRHS<Visitor>( visitor );
                                            ^
c:/RTK-master/utilities/SimpleRTK/Code/Common/src/srtkImage.cxx: In member function 'rtk::simple::Image& rtk::simple::Image::operator=(const rtk::simple::Image&)':
c:/RTK-master/utilities/SimpleRTK/Code/Common/src/srtkImage.cxx:54:12: warning: 'template<class> class std::auto_ptr' is deprecated [-Wdeprecated-declarations]
     nsstd::auto_ptr<PimpleImageBase> temp( img.m_PimpleImage->ShallowCopy() );
            ^~~~~~~~
In file included from c:/Program Files/mingw-w64/x86_64-7.1.0-posix-sjlj-rt_v5-rev1/mingw64/lib/gcc/x86_64-w64-mingw32/7.1.0/include/c++/memory:80:0,
                 from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/nsstd/auto_ptr.h:23,
                 from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/srtkImage.h:28,
                 from c:/RTK-master/utilities/SimpleRTK/Code/Common/src/srtkImage.cxx:18:
c:/Program Files/mingw-w64/x86_64-7.1.0-posix-sjlj-rt_v5-rev1/mingw64/lib/gcc/x86_64-w64-mingw32/7.1.0/include/c++/bits/unique_ptr.h:51:28: note: declared here
   template<typename> class auto_ptr;
                            ^~~~~~~~
c:/RTK-master/utilities/SimpleRTK/Code/Common/src/srtkImage.cxx: In member function 'void rtk::simple::Image::MakeUnique()':
c:/RTK-master/utilities/SimpleRTK/Code/Common/src/srtkImage.cxx:724:16: warning: 'template<class> class std::auto_ptr' is deprecated [-Wdeprecated-declarations]
         nsstd::auto_ptr<PimpleImageBase> temp( this->m_PimpleImage->DeepCopy() );
                ^~~~~~~~
In file included from c:/Program Files/mingw-w64/x86_64-7.1.0-posix-sjlj-rt_v5-rev1/mingw64/lib/gcc/x86_64-w64-mingw32/7.1.0/include/c++/memory:80:0,
                 from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/nsstd/auto_ptr.h:23,
                 from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/srtkImage.h:28,
                 from c:/RTK-master/utilities/SimpleRTK/Code/Common/src/srtkImage.cxx:18:
c:/Program Files/mingw-w64/x86_64-7.1.0-posix-sjlj-rt_v5-rev1/mingw64/lib/gcc/x86_64-w64-mingw32/7.1.0/include/c++/bits/unique_ptr.h:51:28: note: declared here
   template<typename> class auto_ptr;
                            ^~~~~~~~
make[5]: *** [Code/Common/src/CMakeFiles/SimpleRTKCommon.dir/srtkImage.cxx.obj] Error 1
make[4]: *** [Code/Common/src/CMakeFiles/SimpleRTKCommon.dir/all] Error 2
make[3]: *** [all] Error 2
make[2]: *** [SimpleRTK-prefix/src/SimpleRTK-stamp/SimpleRTK-build] Error 2
make[1]: *** [CMakeFiles/SimpleRTK.dir/all] Error 2
make: *** [all] Error 2

If I deactivate SimpleRTK wrapping, everything's fine! I'm on a Win 10 (64bit) machine. The error occurs with both MSYS Makefiles and MinGW Makefiles.
Many thanks in advance for any support!

Hi,
SimpleRTK is based on SimpleITK and MinGW does not seem to be supported:
https://itk.org/Wiki/SimpleITK/FAQ#Is_my_compiler_supported.3F
Can you try MSVC?
Thanks,
Simon
On Mon, Aug 14, 2017 at 9:33 PM, Frederic Madesta<EMAIL_ADDRESS>wrote:

Hi,
I'm trying to build SimpleRTK with Python wrapping. Unfortunately, I'm
getting the following error:
[ 22%] Performing build step for 'SimpleRTK'
Scanning dependencies of target SimpleRTKCommon
[  1%] Building CXX object Code/Common/src/CMakeFiles/SimpleRTKCommon.dir/srtkImage.cxx.obj
In file included from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/srtkPixelIDTypeLists.h:26:0,
from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/srtkMemberFunctionFactoryBase.h:26,
from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/srtkDetail.h:21,
from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/srtkImage.h:23,
from c:/RTK-master/utilities/SimpleRTK/Code/Common/src/srtkImage.cxx:18:
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::Visit::operator()(Predicate&)':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:326:43: error: expected primary-expression before '>' token
visitor.CLANG_TEMPLATE operator()( );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:326:46: error: expected primary-expression before ')' token
visitor.CLANG_TEMPLATE operator()( );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:328:45: error: expected primary-expression before '>' token
next.CLANG_TEMPLATE operator()( visitor );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::Visit::operator()(const Predicate&)':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:335:43: error: expected primary-expression before '>' token
visitor.CLANG_TEMPLATE operator()( );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:335:46: error: expected primary-expression before ')' token
visitor.CLANG_TEMPLATE operator()( );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:337:45: error: expected primary-expression before '>' token
next.CLANG_TEMPLATE operator()( visitor );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::DualVisit<TLeftTypeList, TRightTypeList>::operator()(Visitor&) const':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:378:50: error: expected primary-expression before '>' token
return impl.CLANG_TEMPLATE operator()( visitor );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::DualVisit<TLeftTypeList, TRightTypeList>::operator()(const Visitor&) const':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:385:50: error: expected primary-expression before '>' token
return impl.CLANG_TEMPLATE operator()( visitor );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::DualVisitImpl<TLeftTypeList, TRightTypeList>::operator()(Visitor&) const':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:417:45: error: expected primary-expression before '>' token
goLeft.CLANG_TEMPLATE operator()( visitor );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::DualVisitImpl<TLeftTypeList, TRightTypeList>::operator()(const Visitor&) const':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:427:45: error: expected primary-expression before '>' token
goLeft.CLANG_TEMPLATE operator()( visitor );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::DualVisitImpl<TLeftTypeList, TRightTypeList>::visitRHS(Visitor&) const':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:433:47: error: expected primary-expression before ',' token
visitor.CLANG_TEMPLATE operator()<LeftHead, RightHead>( );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:433:58: error: expected primary-expression before '>' token
visitor.CLANG_TEMPLATE operator()<LeftHead, RightHead>( );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:433:61: error: expected primary-expression before ')' token
visitor.CLANG_TEMPLATE operator()<LeftHead, RightHead>( );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:436:44: error: expected primary-expression before '>' token
goRight.CLANG_TEMPLATE visitRHS( visitor );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h: In member function 'void typelist::DualVisitImpl<TLeftTypeList, TRightTypeList>::visitRHS(const Visitor&) const':
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:441:47: error: expected primary-expression before ',' token
visitor.CLANG_TEMPLATE operator()<LeftHead, RightHead>( );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:441:58: error: expected primary-expression before '>' token
visitor.CLANG_TEMPLATE operator()<LeftHead, RightHead>( );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:441:61: error: expected primary-expression before ')' token
visitor.CLANG_TEMPLATE operator()<LeftHead, RightHead>( );
^
C:/RTK-master/utilities/SimpleRTK/Code/Common/include/Ancillary/TypeList.h:444:44: error: expected primary-expression before '>' token
goRight.CLANG_TEMPLATE visitRHS( visitor );
^
c:/RTK-master/utilities/SimpleRTK/Code/Common/src/srtkImage.cxx: In member function 'rtk::simple::Image& rtk::simple::Image::operator=(const rtk::simple::Image&)':
c:/RTK-master/utilities/SimpleRTK/Code/Common/src/srtkImage.cxx:54:12: warning: 'template class std::auto_ptr' is deprecated [-Wdeprecated-declarations]
nsstd::auto_ptr temp( img.m_PimpleImage->ShallowCopy() );
^~~~~~~~
In file included from c:/Program Files/mingw-w64/x86_64-7.1.0-posix-sjlj-rt_v5-rev1/mingw64/lib/gcc/x86_64-w64-mingw32/7.1.0/include/c++/memory:80:0,
from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/nsstd/auto_ptr.h:23,
from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/srtkImage.h:28,
from c:/RTK-master/utilities/SimpleRTK/Code/Common/src/srtkImage.cxx:18:
c:/Program Files/mingw-w64/x86_64-7.1.0-posix-sjlj-rt_v5-rev1/mingw64/lib/gcc/x86_64-w64-mingw32/7.1.0/include/c++/bits/unique_ptr.h:51:28: note: declared here
template class auto_ptr;
^~~~~~~~
c:/RTK-master/utilities/SimpleRTK/Code/Common/src/srtkImage.cxx: In member function 'void rtk::simple::Image::MakeUnique()':
c:/RTK-master/utilities/SimpleRTK/Code/Common/src/srtkImage.cxx:724:16: warning: 'template class std::auto_ptr' is deprecated [-Wdeprecated-declarations]
nsstd::auto_ptr temp( this->m_PimpleImage->DeepCopy() );
^~~~~~~~
In file included from c:/Program Files/mingw-w64/x86_64-7.1.0-posix-sjlj-rt_v5-rev1/mingw64/lib/gcc/x86_64-w64-mingw32/7.1.0/include/c++/memory:80:0,
from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/nsstd/auto_ptr.h:23,
from C:/RTK-master/utilities/SimpleRTK/Code/Common/include/srtkImage.h:28,
from c:/RTK-master/utilities/SimpleRTK/Code/Common/src/srtkImage.cxx:18:
c:/Program Files/mingw-w64/x86_64-7.1.0-posix-sjlj-rt_v5-rev1/mingw64/lib/gcc/x86_64-w64-mingw32/7.1.0/include/c++/bits/unique_ptr.h:51:28: note: declared here
template class auto_ptr;
^~~~~~~~
make[5]: *** [Code/Common/src/CMakeFiles/SimpleRTKCommon.dir/srtkImage.cxx.obj] Error 1
make[4]: *** [Code/Common/src/CMakeFiles/SimpleRTKCommon.dir/all] Error 2
make[3]: *** [all] Error 2
make[2]: *** [SimpleRTK-prefix/src/SimpleRTK-stamp/SimpleRTK-build] Error 2
make[1]: *** [CMakeFiles/SimpleRTK.dir/all] Error 2
make: *** [all] Error 2
If I deactivate SimpleRTK wrapping, everything's fine! I'm on a Win 10
(64bit) machine. The error occurs with both MSYS Makefiles and MinGW
Makefiles.
Many thanks in advance for any support!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SimonRit/RTK/issues/106, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAT_cE_CFnZ-0n22aKiK--eZGa5uG1W-ks5sYKD4gaJpZM4O2zIW
.

Hi Simon,
I rebuilt both ITK and RTK with MSVC (MS Visual Studio 2017). Now everything's working.
Thank you and best wishes from Hamburg!

@dericdesta, sorry to trouble you. I am trying to build simpleRTK in windows 10 64bit system as well. However, I have failed a couple of times, including using VS 2017 and cuda 9.0.
May I ask you the version of ITK, RTK you used? From commit comments, it looks ITK v4.12 has been supported. However, on the wiki page, it says RTK uses ITK 4.2.0 while it checks out v4.5.1 in the example commands below it. So I am a bit confused about the version.
If anyone can help answer this, it would be appreciated.


Click and drag on canvas background pans the view

Fabric has an option to drag the canvas surface and move it in it around to recenter your object to your view.
Implementing this would require setting limits for where the camera or whatever tracks view position.

Canvas can be panned by clicking and dragging anywhere but on an object.

Awesome Sauce!


[cdc] clean-up cdc constraints

with #13016. cdc constraints are now being introduced to the flow.
These constraints are separate from sdc constraints and need their own mechanism of sourcing (right now I am temporarily including it into run-cdc.tcl, which is not right).
Further, some of the cdc constraints should be made more specific, as it is too broad from async_fifo rdata output to ibex rvalid.

@tjaychen it sounds like this is mainly a cleanup item - can we potentially move this into M3?

yes let's move this to M3.

@cindychip does this need to be part of M2.5 or should we move it to Backlog?

I don't think we have time to clean up the constraints locations for M2.5. since this is mostly cleanup, I think I am ok with postponing this.

Remaining CDC/RDC work is carried over to M5.

@andreaskurth - when you get back could you sync with @rswarbrick and see what remains. If it can be done in the scope of M5 then that's good - otherwise we need to consider whether this makes sense to do as a later cleanup vs putting it in the backlog.

I do not know much about the tooling that the constraint files control. Removing the assignment from myself because I'm not sure I'd be much help!

Just discussed in triage: Carrying CDC work over to M6

We discussed in the triage meeting to give higher priority to this to ramp up a new resource asap.