Don't stop automatic rotation when rotating Preview3D

This has come up on Discord a couple of times (1, 2) and I happened to have a local patch for this already :smile:

Actually, I think it is a good think that autorotation stops. When navigating the 3D preview one is usually aiming for a specific perspective. If the rotation didn't stop the preview would continuously change which is not what one would expect when explicitly navigating the camera to a different position.

Closing in favor of #510.


Added Payload class Trogdor to describe producer payload

Added class that describes producer payload (key and value). For now constant value size, null keys, and default expected compression rate. Makes sure that values are populated to achieve expected compression rate if compression is used.
Added messageSize parameter to producer spec.

LGTM after comments addressed

looks good, I re-reviewed

retest this please

LGTM

Retest this please

This test is failing: kafka.server.DynamicBrokerReconfigurationTest > testAddRemoveSslListener FAILED

retest this please


Deprecation warning with Webpack 4.x

Hi!
We've updated to Webpack 4.x and are using this resolver plugin. However now we are seeing deprecation warnings related to it:
$ node --trace-deprecation ./node_modules/.bin/webpack --progress --color --mode development
 10% building modules 1/1 modules 0 active(node:28) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
    at ComponentResolverPlugin.apply (/app/node_modules/component-webpack-resolver-plugin/src/index.js:11:14)
    at plugins.forEach.plugin (/app/node_modules/enhanced-resolve/lib/ResolverFactory.js:276:10)

Is this a quick fix, or is there another resolver plugin you could recommend?
Thanks
Edit: The full error output is here: https://gist.github.com/joffotron/b517f64df99b6a790043e9bfe6df4814
It seems there are a couple of places that might be affected

This plugin is deprecated and the recommended usage is directly via a babel plugin:

https://github.com/mgcrea/babel-plugin-component-resolver

I'll update the README.


Campaign creation and voting doesnt work

Describe the bug
When creating a campaign on beta gamedao I receive a success message but no event is triggered and no campaign is created.
Same applies on voting on a proposal
To Reproduce
Steps to reproduce the behavior:

Go to Campaigns

Create a campaign

receive success message and look into polkadot.js > network explorer > recent events

See that no event was triggered

Go to a proposal which is votable

vote on it

see success message and look into polkadot.js > network explorer > recent events

See that no event was triggered

Expected behavior
Getting a success message should trigger a result. In fact a success message should only be shown on success.
Additional Information

no error messages are shown in the console

at least on chain campaign creation works as expected.
is there a console log?


Item embed broken for multi volume works

Encountered while working on a new exhibit https://dpul.princeton.edu/shibui.
Page for the book "Nanshoku okagami/ Mirror of Male Love" is causing this error.
[Pomegranate/production] ActionView::Template::Error: key not found "tile_source_ssim"
Backtrace
line 25 of [PROJECT_ROOT]/app/models/solr_document.rb: fetch

View full backtrace and more info at honeybadger.io

This is a bug with the item embed widget for multi volume works.

This appears fine now.

Not fine. The "item embed" widget does not work for MVW items. Example:
https://figgy.princeton.edu/catalog/317ae996-c459-4482-9d33-6571313a26d7

Guessing it has something to do with indexed MVW records:
https://github.com/projectblacklight/spotlight/blob/f1169e19631e2c79c88648ca310375634739e405/app/models/spotlight/resources/iiif_manifest.rb#L123

@eliotjordan, if it helps, MVW thumbnail selection did not work in the old DPUL either. I remember running into it when I first started learning about DPUL and selecting images for banners/etc...

Would be really great to get this to work, if we can. It opens up options for the growing number of MVWs in the collection.


Admin can download submitted claims

This allows an admin to download a CSV version of all submitted claims with all the relevant information. It also generates a unique reference number for each claim which can be presented to the user later on in case of any queries.

 Admin can download submitted claims

I don’t think it’s on the ACs, but I can imagine the school URNs being an important piece of of information when checking claims. It’s just an assumption though

I don’t think it’s on the ACs, but I can imagine the school URNs being an important piece of of information when checking claims. It’s just an assumption though

@robbiepaul possibly, but lets worry about adding that down the road if it turns out we definitely need it


i should be signed off automatically

Signed-off-by: Zeke Sikelianos<EMAIL_ADDRESS>

This is a test to see if we can use git hooks to simplify the process of git commit signoff process.

That hooks appears to work for commits from GitHub Desktop too. 💪🏼
https://github.com/replicate/cog/pull/237/commits/1e31046135ea27c493fd171e28f9c49d8a8eebb9

replaced by https://github.com/replicate/cog/pull/342


Correct sequence point issue in t-object.c

Correcting these issues on a case-by-case basis is not the right way to do it (I discussed a strategy for using compiler checks in #230).  But I just spotted this one while reading.
VAL_OBJ_FRAME(value) = obj = Copy_Block(VAL_OBJ_FRAME(value), 0);

= is not a sequence point in C/C++.  (Unless it's an operator overload in C++, in which case it's syntax on top of a function call, which is a sequence point.)
You might think it would be worth it for compiler authors to declare = as a sequence point, so that such constructs would be guaranteed to evaluate Copy_Block(VAL_OBJ_FRAME(value), 0) before assigning obj to VAL_OBJ_FRAME(value).  It doesn't work that way for a reason:
http://stackoverflow.com/questions/4362501/any-good-reason-why-assignment-operator-isnt-a-sequence-point
So what could happen here is that the previous value of obj is assigned to VAL_OBJ_FRAME(value).  Then obj gets the Copy_Block result, which is not put into VAL_OBJ_FRAME(value).  :-/  It's up for grabs what the compiler will do.
http://www.ganssle.com/rants/sequencepoints.htm
"While it's easy to brush C off as a super-assembly language it's actually quite rich, expressive and has some dark holes that elude too many developers. Indeed, the C99 standard is over 500 pages long, is rather cryptic, and reading it is a sure cure for the worst case of insomnia."

Thanks for the scrutiny. Please just add this commit to the already pending #230, so that we have a single PR for sequence point issues (until it is merged, that is).


Media is auto-playing

Audio based media is auto-playing for some reason.

This is due to the media not being a named control. Will need to parse through it differently.

Fixed in current beta branch. Will be merged in next PR.

PR complete.


v 1.03 quits at step 21/51 on ipad mini 2

Hi jailbreaking unc0ver quit @step 21/51 (unc0ver v1.03)
uncover downloaded via Tweakbox kernel exploit MP (with the default kernel exploit

process stuck at the first step)
device ipad mini 2 wifi+cellular (with no sim) ios 11.3.1
airplane mode siri disabled no former jailbreak present
error messages (two different numbers but they look the same) in the pictures

This can "just fail" sometimes and has to do with the reliability of the apfs remount bypass we're using. Other than "reboot and try again with your fingers crossed", you can't really do anything to fix this, and neither can we.

45 times ??? this is the number of times i tried ...
did you hear of any specific issue of this kind with ipad mini 2 ?
shoud i try an older version ???
hlp me i am sinking .. .


Fix ecsdemo-cicd Dockerfile

Description
Fixed ecsdemo-cicd Dockerfile for resolving the error.
Motivation and Context
With previous Dockerfile, the ensurepip process failed when setting up Python in Docker container. Based on error log suggestion, change codes for being managed using apk and installing additional packages in the virtual env.
How Has This Been Tested?

[X] I have tested and validated these changes using one or more of the provided examples/* projects
[X] I have executed pre-commit run -a on my pull request

@arvindsoni80 Can you please confirm this?


MSI conversion even if iohgatp is bare

Addressing issue #192

That was unfortunate. However qualifying by "not Bare" is not necessary - the statement can be
"Use the second-stage address translation process specified in ..."
If second-stage is Bare then SPA is same the input GPA.

PR #196 to make this update


split Card.jsx in differents files

Hi everybody !
I splited the Card code in different files, I think it's more readable like this.
What do you think ? :)

This is probably a good idea.
Also, I wonder if all this code should be moved to vulcan:ui-bootstrap to avoid duplication for those that use vulcan:ui-material.

Thank's Erik.
Actually I do not know exactly how is the better way to do this, I'm afraid to destroy Vulcan :laughing:
So, If you agree, I let you do this, is it ok for you ?

Okay, no worries.

Thank you very much Erik :smiley:

Not sure if moving too Bootstrap is the right solution. It's the same issue with the Datatable and the Form, it makes sens to reduce the bundle size, but you keep having duplicate code in the end.
What I tried to do instead is to split big components in a lot of smaller components whenever there is the slightest piece of logic, so the Material UI version only replace the visual components, with almost zero logic or at least zero non trivial logic.
Eg if you compute a "showEdit" based on currentUser, you then pass this value to a replaceable components, so yo don't do the computation again in Material UI or Bootstrap.
It's difficult to figure out the right structure though.

This piece of code from Card is a good example:
  const canEdit =
    showEdit &&
    currentUser &&
    collection &&
    collection.options.mutations.update.check(currentUser, document);

  return (
    <div
      className={classNames(className, 'datacard', collection && `datacard-${collection._name}`)}>
      {title &&
{title}
}

          {canEdit ? (
            <CardEdit collection={collection} document={document} {...editFormProps} />
          ) : null}

Instead it should be smth like:
  const canEdit =
    showEdit &&
    currentUser &&
    collection &&
    collection.options.mutations.update.check(currentUser, document);

  return (
    <Components.CardInner canEdit={canEdit} {...props />
  )

So the UI can be replaced more easily. I don't know if this is realistic but I'd be glad to reduce the code duplication in UI packages somehow.

Yes, that's right separating the logic and the actual rendering into different components is usually the best solution to minimize duplication.


https://github.com/microsoft/vscode/issues/229111

https://github.com/microsoft/vscode/issues/229111

Also, python allows redefining variables, if you have a variable that you are using, and in the middle you redefine it, this redefinition affects the lines above, which have no sense (I know that the code is bad written)


EntryPoints digicert_cis_source missing comma

Simple typo, missing comma for EntryPoints digicert_cis_source and extra comma on csr_export.

Coverage increased (+0.03%) to 61.0% when pulling 21bb1fb545a66efaf318dbe79a4b66b9c6b4da4d on cjwaian:patch-1 into 412757b1785a889662f07518871f7c7b36b02da7 on Netflix:master.

lgtm, thanks!


python27Packages.ropper: 1.12.1 -> 1.12.5

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ropper/versions.
meta.description for python27Packages.ropper is: '"Show information about files in different file formats"'.
meta.homepage for python27Packages.ropper is: '"https://scoding.de/ropper/"

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.12.5 with grep in /nix/store/gc06mwip0vbr6px6v3fs9f5rhixy440f-ropper-1.12.5

directory tree listing: https://gist.github.com/ecb197f3091aeae4c036f1a9541bdda1

du listing: https://gist.github.com/21e788495d1bc2af293d29ee432c73a5

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)
2 package rebuild(s)
2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
python27Packages.ropper
python37Packages.ropper

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gc06mwip0vbr6px6v3fs9f5rhixy440f-ropper-1.12.5 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A python27Packages.ropper https://github.com/r-ryantm/nixpkgs/archive/600e283ee65becc38653ed4dd69f9ffe37efa749.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gc06mwip0vbr6px6v3fs9f5rhixy440f-ropper-1.12.5
ls -la /nix/store/gc06mwip0vbr6px6v3fs9f5rhixy440f-ropper-1.12.5/bin

cc @bennofs for testing.

darwin failure not related to this package


Error when installing TVM : > make: *** [all] Error 2

When running
%%bash
[[ ! -e /tools/google-cloud-sdk ]] && exit
echo "Building TVM ..."
cd "/content/gdrive/My Drive/tvm/build"
make -j4

I get this error

Building TVM ...
[ -2%] Performing configure step for 'project_libbacktrace'
CMakeFiles/project_libbacktrace.dir/build.make:107: recipe for target 'libbacktrace/src/project_libbacktrace-stamp/project_libbacktrace-configure' failed
CMakeFiles/Makefile2:146: recipe for target 'CMakeFiles/project_libbacktrace.dir/all' failed
[  0%] Built target vta_tsim
[ 85%] Built target tvm_objs
Makefile:129: recipe for target 'all' failed
/bin/sh: 1: /content/drive/My Drive/TESI/FastDepth/fast-depth/tvm/cmake/libs/../../3rdparty/libbacktrace/configure: Permission denied
make[2]: *** [libbacktrace/src/project_libbacktrace-stamp/project_libbacktrace-configure] Error 126
make[1]: *** [CMakeFiles/project_libbacktrace.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2

How can I fix it?

I am getting the same error. Can you pls help@vegaluisjose

any updates on this? I am also getting the same error..


[Project Addition] : NYC Taxi Trip Duration Prediction

This project involves predicting the duration of NYC taxi trips using various regression models. The notebook includes steps for data exploration, preprocessing, model training, and evaluation.
Model Training and Evaluation:

Linear Regression
Decision Tree Regressor
Random Forest Regressor
AdaBoost Regressor
Gradient Boosting Regressor
XGBoost Regressor

The models are evaluated based on their performance metrics such as R² score and Mean Absolute Error.

Kindly assign this issue to me.

@bristiHalder the issue has been assigned.

@invigorzz313 please mention level  too


Fix undefined log name in delete-last-log-entry confirmation message

Before

After

This bug was introduced via this change, I think: https://github.com/davidrunger/david_runger/commit/e522ab38d9935278cc1f5db7e07c922a6da5d538#diff-b8e0c29abca6d5ed1f3add9e5c9a0accR79
That change in https://github.com/davidrunger/david_runger/pull/1486 (Lazy load log entries on-demand) started just passing a log prop to the Log component, rather than passing each prop individually (log_name, log_id, etc.).
Tests should have protected against this bug, but they were lacking. A test has been added in this PR.


Update readme.

Add new authors
Mention ambiata support and ivy repo
Remove limitations that no longer exist on applicative branch

Done


Support for navigator.geolocation

I'm attempting to use zombie to test a page I've written which uses the new HTML5 Geolocation API (navigator.geolocation) to populate a couple of lat/lon hidden fields which get submitted as part of a form.
What I'd really like to be able to do in my test is to give zombie some mock location details which it would then return to my page's JS code when it calls navigator.geolocation so that I can verify those details are being handled correctly.
I've scoured the API docs but can't find any indication of whether this is supported and how it could be done.
Is this supported and if not, is there a clever workaround anyone can suggest?

Is there a way to edit the navigator object prior to loading pages? This could be way to mock the geolocation functionality...

There's an open event you can hook into: https://github.com/assaf/zombie#opened-window


xsdgen: missing dependent type from another namespace

Using xsdgen to generate code from http://standards.iso.org/ittf/PubliclyAvailableStandards/MPEG-DASH_schema_files/DASH-MPD.xsd
Produces code such as the following:
type EventStreamType struct {
	Actuate     ActuateType `xml:"actuate,attr"`
	SchemeIdUri string      `xml:"schemeIdUri,attr"`
	Value       string      `xml:"value,attr"`
	Timescale   uint        `xml:"timescale,attr"`
	Items       []string    `xml:",any"`
	Event       []EventType `xml:"urn:mpeg:dash:schema:mpd:2011 Event"`
}

Without including the declaration for ActuateType. Here's the relevant part of the XSD:
<xs:complexType name="EventStreamType">
  <xs:sequence>
    <xs:element name="Event" type="EventType" minOccurs="0" maxOccurs="unbounded"/>
    <xs:any namespace="##other" processContents="lax" minOccurs="0" maxOccurs="unbounded"/>
  </xs:sequence>
  <xs:attribute ref="xlink:href"/>
  <xs:attribute ref="xlink:actuate" default="onRequest"/>
  <xs:attribute name="schemeIdUri" type="xs:anyURI" use="required"/>
  <xs:attribute name="value" type="xs:string"/>
  <xs:attribute name="timescale" type="xs:unsignedInt"/>
</xs:complexType>

Notably, the actuate attribute is actually pulled in as a reference to another XSD. The xsdgen package should have known that its type declaration was necessary and produced it in the generated code.

In addition, I believe the xlink attributes should have a namespace in their struct tags.


Special TVR RUN

Thanks Sreepad, please note: we will need to get our unit testing up to passing threshold.


Remove invalid breadcrumbs aria role

role="breadcrumbs" is not a thing.
https://www.w3.org/TR/wai-aria/roles#role_definitions
We previously removed from the component:
https://github.com/alphagov/static/pull/737

Thanks @fofr LGTM 👍

@nickcolley There's this one too: https://github.com/alphagov/contacts-frontend/pull/48

@fofr sweet thanks, (stop checking github! :P 🌴 😎 )


Fix css url detector regex.

Suggested fix for #615
As the reporter of the original issue I also spotted it when minifying bootstrap.
The regex proposed in issue report was breaking quote-less urls tests by stripping the first path component. I've fixed it and this now works for my case as well as suits the test cases.

Hey @vskh thanks for your PR. Really happy that you found a solution :)


fix: length of the result buffer may less than the nodeCrypto's

Add the following codes in test
t.equals(myEnc.length, nodeEnc.length, 'my public encrypted length node public encrypted length')

and find the bug.
I think the results should have the same length.

thanks, this solved my problem


Undo problem emerging after multiple highlights

In undoable demo file,
I highlghted the neighbours of Jerry and get the following screen,

Then I highlighted the neighbours of Kramer and get the following screen,

Finally I performed an undo operation and get the following result,

I think that something must be wrong with undo operation performed after multiple times highlights.

It seems fixed now. May you confirm it? Then I can publish it on npm.

It seems to be fixed, thanks.

Published.


Autowrap

if you specify a name to dale-autowrap.pl (the filename without extension), it will only handle everything defined in that file
also added an example usage in the same directory (c2dale.sh)
usage:
$ export INCLUDE_PATH=/usr/include/GL #the directory where the included files are
$ ./c2dale.sh gl glut freeglut freeglut_std freeglut_ext #etc.

(includes still have to specified oneself, it may be possible to add support to this to the perl-program by not just "next;" when wrong filename but also adding (include "wrong-filename.dt") (problem: everything has to included only once, even if in different files / other problem: some files should not be included anyway (like c's stdlib.h or similar)

i do all updates on autowrap here instead of in single pull requests, if you don't like an addition, you can cherry-pick, I think.

Thanks, this has been merged.


The view does not show on iOS with Ionic

Describe the bug
I'm using the plugin as described in the README in a Ionic app on an iPhone, and when I'm scanning a code it works (I see the result of the scan displayed) but no view is shown that allows me to see what the phone is pointing at (it stays on my screen, and does not show a camera view)
To Reproduce
I'm using the code from the README
      async function doScan() {
        BarcodeScanner.hideBackground();
        const status = await BarcodeScanner.checkPermission({ force: true });
        const result = await BarcodeScanner.startScan({ targetedFormats: [SupportedFormat.DATA_MATRIX] }); // start scanning and wait for a result
        if (result.hasContent) {
          console.log(result.content); // log the raw scanned content
          data.value = result.content as string;
        }
}

Expected behavior
It should show a camera window with a guide to scan the QR code

This was because I had to set transparency on some elements


Footer with badges actually ripple effect round.

@GeekyAnts, @akhil-geekyants :
Hi, using the footer with native base badges as I can recreate the same effect as the image you see in the gif. That ripple round effect. And the text and icon are seen in the foreground when they are selected. In other cases the text can not be seen.

#38


add multicall forwarder to Optimism-Mainnet omnibus

This is a required pre-req for the gov v3 deployment. Important to get this merged asap !

They should be already automatically deployed with the latest version of this system, so I don't understand why this PR is necessary.

We most likely need to bump the synthetix package version, as this is the old deployment and relies on old version of core

They should be already automatically deployed with the latest version of this system, so I don't understand why this PR is necessary.

Where is it deployed? I don't see it here https://usecannon.com/packages/synthetix-omnibus/latest/10-main

Where is it deployed? I don't see it here https://usecannon.com/packages/synthetix-omnibus/latest/10-main

Because it is an old deployment with old core. Need to update synthetix package version.

closing because it is not strictly necessary for us to run our test deployment


[BUG] Harvester version control on upgrades

Describe the bug
Versions should be defined as approved for the air-gapped upgrade procedure.
To Reproduce
Steps to reproduce the behavior:

Create air gapped upgrade config
use version 1.1.0-rc3
The version is accepted but the upgrade match is later discarded.

Expected behavior
A version that is acceptable/approved should be documented/specified in the upgrade documentation that works for future upgrades and/or a revision number should be acceptable for unofficial releases/fixes. ie 1.1.0-1, 1.1.0-2

We'll not support an upgrade from RC to a formal release but will remove the restriction in the code.
Also, we can add a pop-warning in the GUI if the current version is RC or master head builds.

A version that is acceptable/approved should be documented/specified in the upgrade documentation that works for future upgrades and/or a revision number should be acceptable for unofficial releases/fixes. ie 1.1.0-1, 1.1.0-2

@abonillabeeche, I'll close the issue. Upgrading from RC will not be officially supported. The supported upgrade paths are documented at https://docs.harvesterhci.io/v1.1/upgrade/automatic#upgrade-support-matrix
To upgrade from an RC version for test purposes, we'll implement it in https://github.com/harvester/harvester/issues/3040


Allow the File browser to work with screens that are below minimum requirement.

Currently, the confirm button on the filebrowser is cut off on screens that are too small.

closing as this can easily be achieved by zooming out


Implement a UI for multiple phrase search

This adds a Phrase search checkbox to the viewer. Kindly refers to following topics for more details:

#7368
#5579

Important notes:

Internationalization for find_phrase_label is currently missing.
Because of missing experience and because I am running out of time, I did not build the whole library from the scratch with given changes. However, the changes have been applied to the artifacts provided by the project homepage to an application running in a production environment.

Looks good. We do need to decide how to deal with https://github.com/mozilla/pdf.js/pull/7501#issuecomment-234765370, i.e., differences between the find bar from the viewer and that of the extension.

Without any (current) way of supporting this in the native Firefox findbar, it's probably (unfortunately) best to close the PR since it would lead to inconsistent find UI in different PDF.js builds.

I agree. The issues will remain open in case we can fix this in a better way in the future.


Changed log.Fatal to log.Fatalf

I can’t merge this because the sys repo doesn’t build on 1.3 anymore.
If you want to unblock landing of this pr please send me a different pr that updates the Travis config to go 1.8 and 1.9 then rebase this pr once the Travis update has marged.
Thanks.

Okay, thank you Dave.

Can you please rebase this so I can merge it (can’t merge failing jobs on mobile)
Thanks.


validetta with autocomplete

when I select an item in the jQuery autoComplete list and it lost the focus, the bubble not disappear.
You can see all the fields above it we have Validetta, and everyone is ok (invisible bubble/validated), the problem is just with jQuery AutoComplete labeled Comprador.

Hi @flavioafc
Probably You need to trigger the change event after selection.
Try this;
$( ".selector" ).autocomplete({
  select: function( event, ui ) {
     $(this).trigger('change');
  }
});

OH, yeah! It works. I forgot that.
Thank you so much!


Add AssumeRole functionality for credentials/config files

The role_arn and source_profile fields within a credentials file have been
ignored up until now.  This fix adds support for assuming a role from a
credentials and/or config file.

Can someone from the AWS C++ sdk team suggest how to unit test this?
In order to unit test this, we need a role to assume.  How do you generally handle creating various AWS resources for unit testing?

Added some basic unit tests.  I guess I don't need to actually assume a role, I can just mock the STS role functionality.

Any chance you could resolve these conflicts, @LantosDavid? I would love to get this feature!

This feature has been supported by SDK team, see https://github.com/aws/aws-sdk-cpp/commit/3dce455d83033d81fac4f4411de2a3e530970314


XGBoost (and potentially h2o4gpu) hanging on PPC64

GPU XGBoost is hanging on power (ppc64le) machines for some reason. CPU code works fine, only GPU part hangs in different places depending on what is being ran, gcc version etc.
To reproduce:

get a Power machine (Nimbix's CentOS 7 + CUDA9 for ppc64le will do, use the cheapest K80 instance)
sudo yum install -y make, cmake3, git
sudo ln -s /usr/bin/cmake3 /usr/bin/cmake
git clone https://github.com/h2oai/h2o4gpu.git
cd h2o4gpu && git submodule init && git submodule update
cd xgboost && git submodule init && git submodule update
mkdir -p gtest/include && mkdir -p gtest/lib
cd $HOME && git clone https://github.com/google/googletest.git
cd googletest/ && mkdir build && cd build && cmake -DBUILD_SHARED_LIBS=ON ..
cp googlemock/gtest/*.so ../../h2o4gpu/xgboost/gtest/lib/ && cp googlemock/*.so ../../h2o4gpu/xgboost/gtest/lib/
cd .. && cp -r googletest/include/gtest ../h2o4gpu/xgboost/gtest/include/
mkdir -p ../h2o4gpu/xgboost/build/ && cd ../h2o4gpu/xgboost/build/
cmake .. -DGOOGLE_TEST=ON -DUSE_CUDA=ON && make testxgboost
run tests cd ..; ./testxgboost -> the first GPU test will hang

Things already tried:

installed (and built against) GCC 4.9.2 -> hangs in a bit different place but still more or less the same issue
built without OpenMP support (completely removed from xgboost and dmlc-core make/cmake) -> still hangs
tried building/running against glibc 2.19 -> segmentation faults all over the system

Ideas for debugging (in no particular order):

the memset thing is so weird that it can’t execute a single step non-branching instruction in gdb.  that’s so weird.
maybe its a bad address.
can try to single step other pthread creates into memset and see what happens.
the ubuntu toolchain is much newer.  what would happen from compiling everything on ubuntu.
what happens from running what we already have on ubuntu
is the dynamic linker stitching in something totally wrong?
is that “memset” really a stack address thats getting rewritten somehow?
is it executing code on the stack there?
look at source code and object code for pthread_create and compare those with the disassembly from gdb
look at the souce code for the thread local storage stub and compare with the disassembly from gdb
single step pthread create for other cases and watch it
could be cuda version.  i think our working ibm machine instancs in ibm lab is cuda 8
could be cuda driver version.
does the address of the hang bounce around from run to run or is it stable?
what’s it really even doing?  faulting over and over? why can’t it make progress single stepping

Looks like Nimbix comes with CUDA 9.1, trying to downgrade to 9.0 with yum install -y cuda-9-0 and see if that's the cause.

Scripts making google test setup and testing a bit easier: https://github.com/RAMitchell/xgboost-build-helper/tree/master/ubuntu

Might need to remove in xgboost/src/tree/tree_updater.cc this line DMLC_REGISTRY_LINK_TAG(updater_gpu_hist2);

Turns out was a kernel issue on Nimbix, ppc64le works fine.


Key Vaults should disable their public network

Existing rule
No response
Suggested rule
I realized that some network rules concerning public endoint are implented in the storage and sql but not in Keyvaults.
I think we could have a check to see if KV has it firewall set to deny in order to push for stronger network intergration.
This is a recomandation of the security baseline
https://learn.microsoft.com/en-us/security/benchmark/azure/baselines/key-vault-security-baseline?context=%2Fazure%2Fkey-vault%2Fgeneral%2Fcontext%2Fcontext#disable-public-network-access
and can be implemented by the following azure policy
https://www.azadvertizer.net/azpolicyadvertizer/405c5871-3e91-4644-8a63-58e19d68ff5b.html
Pillar
Security
Additional context
Taking the next step woulf be to create a policiy check for Private endoint or disabling the trusted services cheks.
However, my experience is that trusted services integration is very usefull (eg: WAF, API managenement, ...) and therefor I won't push for more than recommending to only connect from trusted network.
After all Keyvault would still need a valid access policy to give access to any of its content.

I'd like to contribute on this one.

Hi Benjamin, thank you very much.
we already have a PR running as I had the check ready to go. (this was a homemade check I am using)

Hi Benjamin, thank you very much. we already have a PR running as I had the check ready to go. (this was a homemade check I am using)

Great and good work!


Traefik crashes with SIGSEGV when PUTting empty file to TLS-secured minio backend service

Do you want to request a feature or report a bug?
Bug
What did you do?

Our java application accesses Minio using the Amazon S3 Java Client (group: 'com.amazonaws', name: 'aws-java-sdk-s3', version: '1.11.913' )
This setup works fine as long as TLS is not activated in Minio itself.
When TLS is activated in Minio and an empty file is uploaded to Minio using the application the request is served by Traefik, but after that it will crash with SIGSEGV.
It is reproducable. See attached docker-compose setup.
What did you expect to see?
Traefik is serving the request and not crashing afterwards.
What did you see instead?
Traefik is serving the request and crashing afterwards.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x5c9862]

goroutine 186 [running]:
bufio.(*Writer).Available(...)
	/usr/local/go/src/bufio/bufio.go:624
bufio.(*Writer).WriteString(0x0, 0x34d8845, 0x19, 0xc0007b85a0, 0x8, 0x7ffff)
	/usr/local/go/src/bufio/bufio.go:705 +0x82
net/http.(*expectContinueReader).Read(0xc0007b9800, 0xc000680000, 0x7ffff, 0x80000, 0xc0008aacd8, 0x410670, 0x8)
	/usr/local/go/src/net/http/server.go:904 +0x1ae
github.com/traefik/traefik/v2/pkg/middlewares/accesslog.(*captureRequestReader).Read(0xc0007b9860, 0xc000680000, 0x7ffff, 0x80000, 0x438dfb, 0x203000, 0x7f23245627d0)
	/go/src/github.com/traefik/traefik/pkg/middlewares/accesslog/capture_request_reader.go:13 +0x51
net/http.(*readTrackingBody).Read(0xc0007b9d80, 0xc000680000, 0x7ffff, 0x80000, 0xc000022120, 0x60, 0x58)
	/usr/local/go/src/net/http/transport.go:621 +0x55
golang.org/x/net/http2.(*clientStream).writeRequestBody(0xc0002874a0, 0x3984020, 0xc0007b9d80, 0x7f22fd720a28, 0xc0007b9d80, 0x0, 0x0)
	/go/pkg/mod/golang.org/x/net@v0.0.0-20200822124328-c89045814202/http2/transport.go:1308 +0x682
golang.org/x/net/http2.(*Transport).getBodyWriterState.func1()
	/go/pkg/mod/golang.org/x/net@v0.0.0-20200822124328-c89045814202/http2/transport.go:2585 +0xd0
sync.(*Once).doSlow(0xc0002fede0, 0xc0007bbef0)
	/usr/local/go/src/sync/once.go:66 +0xec
sync.(*Once).Do(...)
	/usr/local/go/src/sync/once.go:57
golang.org/x/net/http2.(*Transport).getBodyWriterState.func2()
	/go/pkg/mod/golang.org/x/net@v0.0.0-20200822124328-c89045814202/http2/transport.go:2603 +0x47
created by time.goFunc
	/usr/local/go/src/time/sleep.go:167 +0x45

Output of traefik version: (What version of Traefik are you using?)

Ubuntu 20.04
Linux 5.4.0-54-generic #60-Ubuntu SMP Fri Nov 6 10:37:59 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Docker-CE 19.03.13
Same issue on RHEL7
Same issue on Docker 19.03.2
entryPoints:
  minio:
    address: :9100
providers:
  file:
    filename: /etc/traefik/dynamic_conf.yml
api:
  insecure: true
log:
  level: DEBUG
accessLog: {}
serversTransport:
  insecureSkipVerify: true

http:
  routers:
    router-minio:
      rule: "HostRegexp(`{any:.*}`)"
      entryPoints:
        - minio
      service: minio

  services:
    minio:
      loadBalancer:
        servers:
          - url: "https://minio1:9000"
          - url: "https://minio2:9000"

If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)
time="2020-12-09T12:21:28Z" level=debug msg="vulcand/oxy/roundrobin/rr: begin ServeHttp on request" Request="{\"Method\":\"PUT\",\"URL\":{\"Scheme\":\"\",\"Opaque\":\"\",\"User\":null,\"Host\":\"\",\"Path\":\"/test/emptyFile.txt\",\"RawPath\":\"\",\"ForceQuery\":false,\"RawQuery\":\"\",\"Fragment\":\"\",\"RawFragment\":\"\"},\"Proto\":\"HTTP/1.1\",\"ProtoMajor\":1,\"ProtoMinor\":1,\"Header\":{\"Amz-Sdk-Invocation-Id\":[\"b29b6301-00cb-0f8a-4b7f-7942c6960995\"],\"Amz-Sdk-Request\":[\"attempt=1;max=4\"],\"Amz-Sdk-Retry\":[\"0/0/500\"],\"Authorization\":[\"AWS4-HMAC-SHA256 Credential=admin/20201209/us-west-2/s3/aws4_request, SignedHeaders=amz-sdk-invocation-id;amz-sdk-request;amz-sdk-retry;content-length;content-type;host;user-agent;x-amz-content-sha256;x-amz-date;x-amz-decoded-content-length, Signature=44934cf1d08a3611def481d434fe1c7df0903dbd2e17e91f3f428b289f2e05c2\"],\"Connection\":[\"Keep-Alive\"],\"Content-Length\":[\"86\"],\"Content-Type\":[\"application/octet-stream\"],\"Expect\":[\"100-continue\"],\"User-Agent\":[\"aws-sdk-java/1.11.913 Linux/5.4.0-54-generic OpenJDK_64-Bit_Server_VM/<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 java/<IP_ADDRESS> vendor/Ubuntu\"],\"X-Amz-Content-Sha256\":[\"STREAMING-AWS4-HMAC-SHA256-PAYLOAD\"],\"X-Amz-Date\":[\"20201209T122128Z\"],\"X-Amz-Decoded-Content-Length\":[\"0\"],\"X-Forwarded-Host\":[\"localhost:9100\"],\"X-Forwarded-Port\":[\"9100\"],\"X-Forwarded-Proto\":[\"http\"],\"X-Forwarded-Server\":[\"1820cc6bd079\"],\"X-Real-Ip\":[\"<IP_ADDRESS>\"]},\"ContentLength\":86,\"TransferEncoding\":null,\"Host\":\"localhost:9100\",\"Form\":null,\"PostForm\":null,\"MultipartForm\":null,\"Trailer\":null,\"RemoteAddr\":\"<IP_ADDRESS>:60690\",\"RequestURI\":\"/test/emptyFile.txt\",\"TLS\":null}"
time="2020-12-09T12:21:28Z" level=debug msg="vulcand/oxy/roundrobin/rr: Forwarding this request to URL" Request="{\"Method\":\"PUT\",\"URL\":{\"Scheme\":\"\",\"Opaque\":\"\",\"User\":null,\"Host\":\"\",\"Path\":\"/test/emptyFile.txt\",\"RawPath\":\"\",\"ForceQuery\":false,\"RawQuery\":\"\",\"Fragment\":\"\",\"RawFragment\":\"\"},\"Proto\":\"HTTP/1.1\",\"ProtoMajor\":1,\"ProtoMinor\":1,\"Header\":{\"Amz-Sdk-Invocation-Id\":[\"b29b6301-00cb-0f8a-4b7f-7942c6960995\"],\"Amz-Sdk-Request\":[\"attempt=1;max=4\"],\"Amz-Sdk-Retry\":[\"0/0/500\"],\"Authorization\":[\"AWS4-HMAC-SHA256 Credential=admin/20201209/us-west-2/s3/aws4_request, SignedHeaders=amz-sdk-invocation-id;amz-sdk-request;amz-sdk-retry;content-length;content-type;host;user-agent;x-amz-content-sha256;x-amz-date;x-amz-decoded-content-length, Signature=44934cf1d08a3611def481d434fe1c7df0903dbd2e17e91f3f428b289f2e05c2\"],\"Connection\":[\"Keep-Alive\"],\"Content-Length\":[\"86\"],\"Content-Type\":[\"application/octet-stream\"],\"Expect\":[\"100-continue\"],\"User-Agent\":[\"aws-sdk-java/1.11.913 Linux/5.4.0-54-generic OpenJDK_64-Bit_Server_VM/<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 java/<IP_ADDRESS> vendor/Ubuntu\"],\"X-Amz-Content-Sha256\":[\"STREAMING-AWS4-HMAC-SHA256-PAYLOAD\"],\"X-Amz-Date\":[\"20201209T122128Z\"],\"X-Amz-Decoded-Content-Length\":[\"0\"],\"X-Forwarded-Host\":[\"localhost:9100\"],\"X-Forwarded-Port\":[\"9100\"],\"X-Forwarded-Proto\":[\"http\"],\"X-Forwarded-Server\":[\"1820cc6bd079\"],\"X-Real-Ip\":[\"<IP_ADDRESS>\"]},\"ContentLength\":86,\"TransferEncoding\":null,\"Host\":\"localhost:9100\",\"Form\":null,\"PostForm\":null,\"MultipartForm\":null,\"Trailer\":null,\"RemoteAddr\":\"<IP_ADDRESS>:60690\",\"RequestURI\":\"/test/emptyFile.txt\",\"TLS\":null}" ForwardURL="https://minio2:9000"
time="2020-12-09T12:21:28Z" level=debug msg="vulcand/oxy/roundrobin/rr: completed ServeHttp on request" Request="{\"Method\":\"PUT\",\"URL\":{\"Scheme\":\"\",\"Opaque\":\"\",\"User\":null,\"Host\":\"\",\"Path\":\"/test/emptyFile.txt\",\"RawPath\":\"\",\"ForceQuery\":false,\"RawQuery\":\"\",\"Fragment\":\"\",\"RawFragment\":\"\"},\"Proto\":\"HTTP/1.1\",\"ProtoMajor\":1,\"ProtoMinor\":1,\"Header\":{\"Amz-Sdk-Invocation-Id\":[\"b29b6301-00cb-0f8a-4b7f-7942c6960995\"],\"Amz-Sdk-Request\":[\"attempt=1;max=4\"],\"Amz-Sdk-Retry\":[\"0/0/500\"],\"Authorization\":[\"AWS4-HMAC-SHA256 Credential=admin/20201209/us-west-2/s3/aws4_request, SignedHeaders=amz-sdk-invocation-id;amz-sdk-request;amz-sdk-retry;content-length;content-type;host;user-agent;x-amz-content-sha256;x-amz-date;x-amz-decoded-content-length, Signature=44934cf1d08a3611def481d434fe1c7df0903dbd2e17e91f3f428b289f2e05c2\"],\"Connection\":[\"Keep-Alive\"],\"Content-Length\":[\"86\"],\"Content-Type\":[\"application/octet-stream\"],\"Expect\":[\"100-continue\"],\"User-Agent\":[\"aws-sdk-java/1.11.913 Linux/5.4.0-54-generic OpenJDK_64-Bit_Server_VM/<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 java/<IP_ADDRESS> vendor/Ubuntu\"],\"X-Amz-Content-Sha256\":[\"STREAMING-AWS4-HMAC-SHA256-PAYLOAD\"],\"X-Amz-Date\":[\"20201209T122128Z\"],\"X-Amz-Decoded-Content-Length\":[\"0\"],\"X-Forwarded-Host\":[\"localhost:9100\"],\"X-Forwarded-Port\":[\"9100\"],\"X-Forwarded-Proto\":[\"http\"],\"X-Forwarded-Server\":[\"1820cc6bd079\"],\"X-Real-Ip\":[\"<IP_ADDRESS>\"]},\"ContentLength\":86,\"TransferEncoding\":null,\"Host\":\"localhost:9100\",\"Form\":null,\"PostForm\":null,\"MultipartForm\":null,\"Trailer\":null,\"RemoteAddr\":\"<IP_ADDRESS>:60690\",\"RequestURI\":\"/test/emptyFile.txt\",\"TLS\":null}"
<IP_ADDRESS> - - [09/Dec/2020:12:21:28 +0000] "PUT /test/emptyFile.txt HTTP/1.1" 200 0 "-" "-" 2 "router-minio@file" "https://minio2:9000" 26ms
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x5c9862]

goroutine 72 [running]:
bufio.(*Writer).Available(...)
	/usr/local/go/src/bufio/bufio.go:624
bufio.(*Writer).WriteString(0x0, 0x34d8845, 0x19, 0x80000, 0x7f39c84bd7d0, 0xc000700000)
	/usr/local/go/src/bufio/bufio.go:705 +0x82
net/http.(*expectContinueReader).Read(0xc0005780e0, 0xc000700000, 0x7ffff, 0x80000, 0xc000700000, 0xc000429c98, 0x1212f0a)
	/usr/local/go/src/net/http/server.go:904 +0x1ae
github.com/traefik/traefik/v2/pkg/middlewares/accesslog.(*captureRequestReader).Read(0xc0005781c0, 0xc000700000, 0x7ffff, 0x80000, 0x438dfb, 0x6909b9, 0x6948de)
	/go/src/github.com/traefik/traefik/pkg/middlewares/accesslog/capture_request_reader.go:13 +0x51
net/http.(*readTrackingBody).Read(0xc000578700, 0xc000700000, 0x7ffff, 0x80000, 0x1000, 0x397f0a0, 0xc000098180)
	/usr/local/go/src/net/http/transport.go:621 +0x55
golang.org/x/net/http2.(*clientStream).writeRequestBody(0xc0001b51e0, 0x3984020, 0xc000578700, 0x7f39a15023
[traefik-error.zip](https://github.com/traefik/traefik/files/5665908/traefik-error.zip)
80, 0xc000578700, 0x0, 0x0)
	/go/pkg/mod/golang.org/x/net@v0.0.0-20200822124328-c89045814202/http2/transport.go:1308 +0x682
golang.org/x/net/http2.(*Transport).getBodyWriterState.func1()
	/go/pkg/mod/golang.org/x/net@v0.0.0-20200822124328-c89045814202/http2/transport.go:2585 +0xd0
sync.(*Once).doSlow(0xc0001fcaa0, 0xc0008970b0)
	/usr/local/go/src/sync/once.go:66 +0xec
sync.(*Once).Do(...)
	/usr/local/go/src/sync/once.go:57
golang.org/x/net/http2.(*Transport).getBodyWriterState.func2()
	/go/pkg/mod/golang.org/x/net@v0.0.0-20200822124328-c89045814202/http2/transport.go:2603 +0x47
created by time.goFunc
	/usr/local/go/src/time/sleep.go:167 +0x45

traefik-error.zip

Hello @cgoeller :wave Thanks for reporting the issue and big thanks for providing a reproducible test case.
I'm able to reproduce the issue and we are currently investigating it.

I ran the race detector while uploading an empty file using your test client:
Race Detector output

WARNING: DATA RACE
Read at 0x00c0001d60f8 by goroutine 83:
  net/http.(*expectContinueReader).Read()
      /usr/local/go/src/net/http/server.go:904 +0x264
  github.com/traefik/traefik/v2/pkg/middlewares/accesslog.(*captureRequestReader).Read()
      /home/jspdown/Containous/traefik/pkg/middlewares/accesslog/capture_request_reader.go:13 +0x78
  net/http.(*readTrackingBody).Read()
      /usr/local/go/src/net/http/transport.go:621 +0x8a
  golang.org/x/net/http2.(*clientStream).writeRequestBody()
      /home/jspdown/go/pkg/mod/golang.org/x/net@v0.0.0-20200822124328-c89045814202/http2/transport.go:1308 +0x761
  golang.org/x/net/http2.(*Transport).getBodyWriterState.func1()
      /home/jspdown/go/pkg/mod/golang.org/x/net@v0.0.0-20200822124328-c89045814202/http2/transport.go:2585 +0x13d
  sync.(*Once).doSlow()
      /usr/local/go/src/sync/once.go:66 +0x109
  sync.(*Once).Do()
      /usr/local/go/src/sync/once.go:57 +0x68
  golang.org/x/net/http2.(*Transport).getBodyWriterState.func2()
      /home/jspdown/go/pkg/mod/golang.org/x/net@v0.0.0-20200822124328-c89045814202/http2/transport.go:2603 +0x85

Previous write at 0x00c0001d60f8 by goroutine 71:
  net/http.(*conn).finalFlush()
      /usr/local/go/src/net/http/server.go:1690 +0xd2
  net/http.(*conn).close()
      /usr/local/go/src/net/http/server.go:1696 +0x38
  net/http.(*conn).serve.func1()
      /usr/local/go/src/net/http/server.go:1805 +0xba
  net/http.(*conn).serve()
      /usr/local/go/src/net/http/server.go:1935 +0xb54

Goroutine 83 (running) created at:
  time.goFunc()
      /usr/local/go/src/time/sleep.go:167 +0x51

Goroutine 71 (finished) created at:
  net/http.(*Server).Serve()
      /usr/local/go/src/net/http/server.go:2969 +0x5d3
  github.com/traefik/traefik/v2/pkg/server.createHTTPServer.func1()
      /home/jspdown/Containous/traefik/pkg/server/server_entrypoint_tcp.go:506 +0x52
==================
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x6dd0db]

goroutine 100 [running]:
bufio.(*Writer).Available(...)
	/usr/local/go/src/bufio/bufio.go:624
bufio.(*Writer).WriteString(0x0, 0x4d9a147, 0x19, 0x10100000047836a, 0x0, 0x80000)
	/usr/local/go/src/bufio/bufio.go:705 +0x9b
net/http.(*expectContinueReader).Read(0xc000993c40, 0xc000da6000, 0x7ffff, 0x80000, 0x4561820, 0x1ffffff01, 0xc000da6000)
	/usr/local/go/src/net/http/server.go:904 +0x28c
github.com/traefik/traefik/v2/pkg/middlewares/accesslog.(*captureRequestReader).Read(0xc000993ca0, 0xc000da6000, 0x7ffff, 0x80000, 0x0, 0x0, 0xc000da6000)
	/home/jspdown/Containous/traefik/pkg/middlewares/accesslog/capture_request_reader.go:13 +0x79
net/http.(*readTrackingBody).Read(0xc000d7e1a0, 0xc000da6000, 0x7ffff, 0x80000, 0x0, 0x0, 0x0)
	/usr/local/go/src/net/http/transport.go:621 +0x8b
golang.org/x/net/http2.(*clientStream).writeRequestBody(0xc0003a29a0, 0x551a8c0, 0xc000d7e1a0, 0x7f9f9e4cc198, 0xc000d7e1a0, 0x0, 0x0)
	/home/jspdown/go/pkg/mod/golang.org/x/net@v0.0.0-20200822124328-c89045814202/http2/transport.go:1308 +0x762
golang.org/x/net/http2.(*Transport).getBodyWriterState.func1()
	/home/jspdown/go/pkg/mod/golang.org/x/net@v0.0.0-20200822124328-c89045814202/http2/transport.go:2585 +0x13e
sync.(*Once).doSlow(0xc000536da0, 0xc000249ad0)
	/usr/local/go/src/sync/once.go:66 +0x10a
sync.(*Once).Do(0xc000536da0, 0xc000249ad0)
	/usr/local/go/src/sync/once.go:57 +0x69
golang.org/x/net/http2.(*Transport).getBodyWriterState.func2()
	/home/jspdown/go/pkg/mod/golang.org/x/net@v0.0.0-20200822124328-c89045814202/http2/transport.go:2603 +0x86
created by time.goFunc
	/usr/local/go/src/time/sleep.go:167 +0x52
exit status 2

This indicates that we are calling WriteString on an already closed connection. It appears that theio.ReadCloser expectContinueReader (from Golang standard library) does not protect correctly against reading the body from an already closed connection:
https://github.com/golang/go/blob/9b955d2d3fcff6a5bc8bce7bafdc4c634a28e95b/src/net/http/server.go#L895-L920
A commit which addresses exactly this issue as landed recently on their master branch: https://github.com/golang/go/commit/dfee3332e66bd3f3afd76615767d2cd9b1905b26. Once released we will make sure to update Traefik.

May be I have similar issue with download files(more then 40Mb) when use traefik+tls. How you think could it connected with this bug?
Client -> Internet -> Traefik(TLS) -> Caddy file server(without TLS)
Traefik TLS config. Tested with Traefik 2.2.1 and 2.3.5
tls:
  certificates:
    - certFile: /etc/traefik/ssl/selfsigned.crt
      keyFile: /etc/traefik/ssl/selfsigned.key
      stores:
        - default
  options:
    default:
      minVersion: VersionTLS12

wget and Connection closed
# wget --no-check-certificate --server-response https://URL/file.exe
HTTP request sent, awaiting response...
  HTTP/1.1 200 OK
  Accept-Ranges: bytes
  Content-Length: 55740568
  Content-Type: application/x-msdos-program
  Date: Sun, 13 Dec 2020 11:29:07 GMT
  Etag: "ql71crx6pp4"
  Last-Modified: Fri, 11 Dec 2020 21:07:39 GMT
  Server: Caddy
Length: 55740568 (53M) [application/x-msdos-program]
Saving to: ‘file.exe’

file.exe                                            75%[================================================================================================================================>                                           ]  40,13M  1,47MB/s    in 29s

2020-12-13 14:29:37 (1,37 MB/s) - Connection closed at byte 42077979. Retrying.

But when TLS on Traefik side disabled (only http) then all works fine, without any disconnect!

@atomlab If you get the same stacktrace there is a high chance the problem is similar. You can still try the patch on the v2.3 branch if you want to make sure.
If you think there's a bug in Traefik and you can't find a similar reported bug please open a new issue. If you need help from the community, please visit the community forum

Just for the record, we are expecting this fix to land in go 1.16. It has currently been released in v1.16beta1.

Just for the record, we are expecting this fix to land in go 1.16. It has currently been released in v1.16beta1.

Closed by #7932.

This error still occurs with version traefik 2.4.7
Version:      2.4.7
Codename:     livarot
Go version:   go1.16
Built:        2021-03-08T17:18:28Z
OS/Arch:      linux/amd64

I tested it using the same test setup based on docker compose, this time with Docker for desktop windows 20.10.5
The error message is still the same:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x5cbc02]

goroutine 95 [running]:
bufio.(*Writer).Available(...)
        /usr/local/go/src/bufio/bufio.go:624
bufio.(*Writer).WriteString(0x0, 0x3122da3, 0x19, 0x1011a6cb3d91140, 0x7f14b5b4e568, 0x0)
        /usr/local/go/src/bufio/bufio.go:705 +0x82
net/http.(*expectContinueReader).Read(0xc0003221e0, 0xc0008da000, 0x7ffff, 0x80000, 0xc0008da000, 0xc0005c9c50, 0x13641a5)
        /usr/local/go/src/net/http/server.go:906 +0x1ac
github.com/traefik/traefik/v2/pkg/middlewares/accesslog.(*captureRequestReader).Read(0xc0005ee060, 0xc0008da000, 0x7ffff, 0x80000, 0x43981b, 0xcd789caf12786139, 0x77ac15571539dc9a)
        /go/src/github.com/traefik/traefik/pkg/middlewares/accesslog/capture_request_reader.go:13 +0x51
net/http.(*readTrackingBody).Read(0xc0005ee3d8, 0xc0008da000, 0x7ffff, 0x80000, 0xc96109a73a8d8465, 0x6a4735e1080d1c04, 0x70af7f221f94a428)
        /usr/local/go/src/net/http/transport.go:632 +0x55
golang.org/x/net/http2.(*clientStream).writeRequestBody(0xc0000dc9a0, 0x35b6300, 0xc0005ee3d8, 0x7f14b5b04340, 0xc0005ee3d8, 0x0, 0x0)
        /go/pkg/mod/golang.org/x/net@v0.0.0-20200904194848-62affa334b73/http2/transport.go:1308 +0x6aa
golang.org/x/net/http2.(*Transport).getBodyWriterState.func1()
        /go/pkg/mod/golang.org/x/net@v0.0.0-20200904194848-62affa334b73/http2/transport.go:2585 +0xd0
sync.(*Once).doSlow(0xc00052cdb0, 0xc00026e720)
        /usr/local/go/src/sync/once.go:68 +0xec
sync.(*Once).Do(...)
        /usr/local/go/src/sync/once.go:59
golang.org/x/net/http2.(*Transport).getBodyWriterState.func2()
        /go/pkg/mod/golang.org/x/net@v0.0.0-20200904194848-62affa334b73/http2/transport.go:2603 +0x47
created by time.goFunc
        /usr/local/go/src/time/sleep.go:180 +0x45

Hello @cgoeller,
I've conducted some tests with the new Traefik version, and it seems that this issue is now fixed.
Can you confirm this in order to close this issue ?
Thanks,
Tom

Hello @tomMoulard,
I can confirm that the testcase now works with Traefik 2.5.2 👍
Thanks for the good work

Awesome !


Milestone 3 Updates

Closes #83
Closes #71
Closes #75
Updates to message styling (flash & form errors)
Search Function for FAQ Page
Templating in error forms - ensures ease of management

What prevents #71 from being completed?
#75 can also be completed here.

What prevents #71 from being completed?
#75 can also be completed here.

Nothing, #71 code is not fully functional yet I think. Changes does not take place. Did not get round to debugging yet. Was doing the other stuff. But will only merge when we can close #71.

Line 132 of app/main/views.py. Should remove the emailForm from render_template:
return render_template('settings.html', title=' | Settings', image_file=image_file, form=form, knewbieForm=knewbieForm, pwForm=pwForm)

Note that class settings page HTML is not done yet.

This PR can be closed in lieu of #87.


add fibonacci

Codecov Report
Attention: Patch coverage is 11.11111% with 8 lines in your changes are missing coverage. Please review.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

storey/utils.py
60.00% <11.11%> (-2.25%)
:arrow_down:


remarks rake task is broken

I think this is a result of refactoring in #2423
@aclar48 could you please take a look?
The error message is
ActiveRecord::UnknownAttributeError: unknown attribute 'remark_result_id' for Submission.

Looks like it broke a lot of tests too.

I fixed the tests in a separate PR. Didn't do the take task though.

#2436


CarouselView.PositionChanging no longer being fired when manually setting CurrentIndex

In version 1.4.0 and 1.4.1 I'm no longer getting any event on CarouselView.PositionChanging when manually setting the CurrentIndex. Is this intentional?

Downgrading to 1.3.9 works. Will use it for now.

Nevermind, not getting it on Android in 1.3.9... Just cleaned and rebuilt project, still not getting it. Not sure what's happening, but not certain it's the plugin. Trying some things.

Was able to get around it by running the logic I need to manually whenever I update that index, so non-critical.

Hi
Yes, I did it intentionally.
Because I need to differentiate, whether it hand's changing or autonavigating..
So, I added two new categories
AutoNavigationStartedCommand
AutoNavigationStarted //event
AutoNavigationEndedCommand
AutoNavigationEnded //event

It's regarding to one plugin's feature..namely ability to manage prev/next/current card by hands..
Check this class CardsSampleCustomView in samples. As you can see, it hasn't got any Items collection. PrevContextProperty/NextContextProperty/CurrentContextProperty manage it.
So.. we need to know exactly if it was autonavigating or swipe gesture, because we need to know, if we should change contexts or no)
Sorry for my English.. but i hope it's clear)

Sounds good to me, thanks!
So in your project, the term 'Auto Navigating' is just referring to the index being set manually in the code?
I had guessed that it meant there were some way to make it automatically start scrolling through the views on a timer.

So in your project, the term 'Auto Navigating' is just referring to the index being set manually in the code?
yes

So, if CurrentIndex changing from ViewModel, autonavigating will start (or just from code)
OR
If you use "Context Feature"... if you change CurrentContext from code too

I think, i can close this issue.


i18n

Ref #69
This is partially implemented. The i18n plugin is fully operational, but I believe it's good to adapt the methods components to it. I tried but didn't find available time to do it.
@tkellen can you take a look here as well? I'll talk to @susanjrobertson later today to see how it fits to the project.

Extra info:

this is using https://github.com/Anthony-Gaudino/jekyll-multiple-languages-plugin
to install it, run a bundle install on the CLI.
The site needs to be generated with jekyll before sent to gh-pages as custom plugins are not used by github's automatic generator.

There are non-designed links to toggle from one language to another.
We can also update the language picker with a new plugin feature, but once again I didn't have time to test.

Met with @leobalter to go over this work and I think i understand what has to be done to move forward.
@tkellen I'm thinking of merging in this PR and then doing another branch to finish the work with the methods. What do you think?

:+1: to landing! If we're serious about localization we should get this in as soon as possible. This is one of those foundational pieces that is really difficult to add later.


GC: SharePoint: Restore: Libraries: Custom Files

Custom scripting files (e.g. .aspx) are blocked by the SharePoint Server by default. Files that match this criterion require a different workflow to be able to be placed back into the M365 back store.
Related

#1615

Newly released within Microsoft Graph Beta API, there is the Site Page API that allows for the creation of a .aspx file.
It is a 2 part process.

Create the page via POST /sites/{site-id}/pages, which returns the newly created site Page.
Publish the new page --> POST /sites/{siteId}/pages/{pageId}/publish

SharePoint.Pages to be saved as their own object within Corso

SharePoint.Libaries and SharePoint.Pages decoupled at this stage.

Libraries no longer downloads the Site Pages document library.


Cassandra node process is terminated when there is an issue with Cassandra-exporter agent

Cassandra node process is terminated when cassandra-exporter agent fails to initialize. The impact may be less for smaller Cassandra environments, but the impact is more on bigger Cassandra environments. Agent should not terminate the node process if there any error during initialization. Introduce a new flag based initialization logic to drop agent initialization in case of any error allow the node process to continue.

I am going to work in this enhancement.

I will work on this enhancement.

I disagree. The agent is an extension to Cassandra. Any error in the Cassandra config prevents Cassandra from starting. Likewise, any config error with the exporter agent should follow the same pattern.

I completely agree that patterns wise the process should get terminated in case of any issue with config, and that should be the default behavior.  Adding a flag (--dont_exit_on_error) to continue the node process if agent could't initialize will give peace of mind to the users who maintain huge clusters.

What kind of errors are we talking about here? Configuration problems should abort IMO.

Configuration problems should abort cassandra-exporter agent initialization, should the node process be aborted if Casandra-exporter fails to initialize?

Hi @podile. I now have a better understanding of the need for this feature and happy for abort-on-config-problems to be put behind a flag.


feat(rich-text-editor): tests for rich text editor link extension and utils

tests for rich text editor link extension and utils

:hammer_and_wrench: Type Of Change

[ ] Fix
[x] Feature
[ ] Refactoring
[ ] Documentation

:book: Description
Tests for rich text editor link extension, https://github.com/dialpad/dialtone-vue/pull/991
:crystal_ball: Next Steps
Add the Vue3 version of the component with the tests.
:link: Sources
https://github.com/dialpad/dialtone-vue/pull/991

Thanks for the tips @braddialpad, definitely made the tests feel and look more solid!


Add TWSA's Payload Adapters! from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of tristonwilson12, to add TWSA's Payload Adapters! to CKAN.
Mod details:
name = /mod/729/TWSA%27s%20Payload%20Adapters%21
author = tristonwilson12
abstract = This is a small mod that includes 1 part. its a payload adapter thats compatible with tweakscale! Payload adapters ar what go between the Payload, and the Farings on a rocket!
license = CC BY-NC 4.0
Homepage =
description = This is a small mod that includes 1 part. its a payload adapter thats compatible with tweakscale! Payload adapters ar what go betweek the Payload, and the Farings on a rocket!
Heres some pics! (the one all the way to the left is the standered size, 2.5m, the other 2 or Tweakscaled)

Please direct questions about this pull request to tristonwilson12.

Closing in favour of #4171


Added Powershell solution for review :)

Created a new FizzBuzz function as my solution for this Hacktoberfest 2020 challenge.

Neat! thanks :)


Latest update power state commands

In the latest updates I have started having issues with Epson L1500U and L610U units not responding to power commands or doing so inconsistently.  I’m not sure how to give more detail because the problem is very inconsistent as to what causes it but it is prevalent.  Sometimes pressing and holding a button to send the power command for a long while seems to work.  Other times not.    No issues until the rewrite where power state became one commands with different arguments vs a separate power on and power off command.  Any ideas? Have downgraded to beta 4127 for now.
Thanks!

We have found a similar issue with our system too - When the power to the projector is switched on after Companion is loaded, the pjlink module appears to not be communicating with the projector.
The command to turn on the projector is not sent, nor is the feedback about projector power state working (if the projector is turned on with its remote).
The Companion log shows an error of "Unavailable Time" for the pjlink module. This error message appears in the log multiple times if left un-touched for a while.
Disabling then enabling the pjlink module doesn't fix the issue.
Clicking Edit on the module, then clicking Save (without changing anything) resolved the issue.
Beta 4187 works ok; Beta 4191 and newer has the issue.

@obcocav - what was the original companion beta you tried before downgrading to 4127...?

@JonathanPowe & @obcocav - there was an update to the pjlink module that was in companion 2.2.0-4450-beta..
Are your problems still showing when using that beta?

Our upgrade path was: 3505 (worked ok) -> 4450 (issue encountered) -> 4443 (issue still present) -> 4191 (issue still present) -> 4187 (worked ok).
On the newer versions I tried adding the Actions again and removing the original one, but that didn't fix it.
(The last downgrade to 4187 necessitated re-adding the Actions again due to the change in action type between those versions.)

Tested the latest beta 4480: unfortunately the same issue with 'power-on' not working, however feedback might actually work even when the power-on command doesn't function:
I added a feedback of 'power status: standby' which correctly highlighted the button.
Pressing the PJlink button to turn on the projector did nothing. Turning on the projector using the remote, or using the new Epson BusinessPJ module, resulted in the PJlink feedback colour changing correctly to 'warm up', then 'on'.
Pressing the PJlink button to turn the projector off worked successfully.
The Companion log showed the same "Unavailable Time" error on the PJlink module as before.
Is this referring to the projector's internal clock time setting? as that is probably set to the wrong time in comparison to the computer running Companion.
The PJlink module now correctly reports a communication error when the projector mains power is off. However when the mains power is then turned on to the projector, the PJlink module remains stuck in this error state. I waited about a minute and it still didn't show as Connected.
A temporary workaround I've found is to add 'internal instance disable pjlink' as part of the shut down sequence button Actions, between PJlink sending 'power off' and the power switcher Action to turn off the mains power;
and add 'internal instance enable pjlink' as part of the start-up sequence button Actions, a few seconds after the power switcher Action to turn on the mains power.
This workaround unfortunately does not resolve the original issue of 'power on' not working.
If you would like me to test anything else I am happy to do so.

I'm having the same issue with an Epson L360U projector. The pjlink module seemed to work before I upgraded to Companion 2.1.

Unavailable time (ERR3) is returned by the projector when some commands are sent too close together.
If the projector just turned on and hasn't completed warm-up, it may not want to switch inputs yet and will return this error.
I have some time to look through this, but do not have access to a projector :(

Thank you @istnv
I've made a Wireshark capture (attached linked below) of the PJLink traffic (port 4352) between the computer running Companion and our Epson EB-G7905U projector.
Also included is the Companion log running at the same time.
I started Wireshark, then enabled the PJlink module in Companion, let it sit there for a couple of minutes,
I then disabled the PJlink module in Companion, then stopped the Wireshark log.
Several "Unavailable time" errors appeared in the Companion log
No Companion buttons were pressed, nor were any Companion pages opened whilst the Wireshark log was running.
A few buttons have Feedbacks from PJlink programmed, (not sure if those update themselves if the page they are on isn't loaded anywhere?)
PJlink-enable-disable-logs.zip
If you would like me to do any more testing I am happy to help.

feedbacks are meant to auto-update so you have a current (within a few seconds) status.
If you set button color for power state, the button should change color even if you power on/off from the projector or the IR remote.
The module now polls the projector for variables and feedbacks so periodic traffic is normal.

I suspect the Unavailable Time is due to some of the polling while the projector is off - such as Input Resolution etc...
I've got some code in progress to add more info to the ERR3 error to see what commands are causing it when.
I added the feedback to the original code, which I think buffers the commands until a response back from the projector, but I suspect that it needs adjustment to work with the polling functions I added.
Unfortunately I'm travelling for work, so don't have access to a projector to carry on testing. I had tested it against the PJLINK test app successfully, but I suspect that it doesn't interact like a true projector.

I have some time to look through this, but do not have access to a projector :(

@istnv - any and all help appreciated

I have some time to look through this, but do not have access to a projector :(

@istnv - any and all help appreciated

I'm looking through it now with the simulator. It can be set to throw random errors to check all of the error handling/checking routines.
Some are improper: It just sent an 'ERR2 Out of parameter' response to a 'LAMP ?' query.
Allowing commands cue cue up until a 'sent' command is acknowledged (with or without error) before sending the next command should reduce the ERR3 results.

Yeah - I think the simulator just sends out random errors - not applicable to the actual command was sent...

There's something around lines 390 to 442 that puts commands into a buffer, and then shifts them off

It cues the commands, but does not wait for a response. Protocol says it could take 10 seconds or more for a response.  I have similar code in other modules that checks responses to commands. I'm looking to bring some of that logic in.

Also, projector 'details' only needs retrieved when the module starts. The manufacturer, serial number, etc. should be stable. Then only poll for the info that can change (input, lamp hours, on/off). That will also reduce traffic.

Ah... I thought I was only collecting the initial details once, but maybe the self.socket.on('connect'... is called every time is connects to the projector with a new password...

the self.socket.on('connect'... is called every time is connects to the projector with a new password...

Correct. Every time the challenge token changes or the session times out.
Re-reading the protocol docs, the timeout period is 30 seconds.
I questioned that when I was working on this and remember reading 4 seconds somewhere.

Just for more data.  Tried the latest 2.3.0 beta this morning.  This module still will not command power on or off on the Epson L1500 or L610U.  Feedbacks work and power commands work if I use the new Epson EB module for power commands only.  Let me know if I can help diagnose any more.  Thanks for all yalls work and help.

Same here with a "Digital Projection E-Vision Laser 13k" and "Eiki LC-HDT 700".
Power ON/OFF is not working.
ON THE Eiki the connection of the instance fails after a while. (ERROR) Sometimes I could get it running again by sending commands with a button (AVMT on/off).
PJ Link commands out of Putty and Watchout work with both projectors, but only when pjlink instance is disabled.
The Evision's Feedback of AV mute is often wrong. After sending off/on it shows the right state, then it jumps back to the opposite on/off state. The commands trigger the shutter correctly.
I will roll back to the last build before "generic pjlink" update and report.

@JonathanPowe

Several "Unavailable time" errors appeared in the Companion log...
Edit to add: the projector was in 'Standby' state throughout the test

Those errors are a result of feedbacks polling for 'Mute' status while the projector is in standby.

Hi, we are having power on issues with Panasonic projectors with the latest beta build, is there a resolve yet? 2.2.0 works perfectly, it is only when updating to the latest 2.3.0 beta. Not sure if 2.2.1 works either.

@istnv .  Just tried the latest beta and still have the issue.  Feedback is working but power commands do not.  Again not sure if it helps but this issue started for us after the update that consolidated the power state commands into a drop down selection rather than separate commands in the list.  Hope this helps and thanks for working on this!  Let me know if I can help.

@obcocav An update here does not automatically push forward to the betas. Core devs need to approve and integrate them into the build. That can take days (or weeks).
What OS do you use? I do not have access to a projector at this time but I may be able to generate a non-official build you can test. What modules do you use (my dev environment may not have all of the modules)

@istnv .  Ok.  Saw build 4505 had PJlink 1.1.2 so figured that was it.  I’ll check back later.  Using win64.  LOTS of modules. Let me get a list when I can fire it up but may not be practical.  Thank you!

@obcocav That build added a couple of debugging messages.
A temp build should not be a problem if you make sure to back up your current install beforehand.

Here’s a list of my current modules.

@obcocav ... What OS do you use? I do not have access to a projector at this time but I may be able to generate a non-official build you can test. What modules do you use (my dev environment may not have all of the modules)

Thank you for working on this. I am happy to test it too.
The projector I have connected is an Epson EB-G7905U
OS:
Windows 10 64-bit
Modules:
Blackmagic Design atem
TVOne Corio
OBS obs
PJLink pjlink
Epson epsonpj
Behringer wing
Resolume arena
Generic tcp-udp
Generic osc

If you're on slack I can send a link to a test windows build.

If you're on slack I can send a link to a test windows build.

Thank you. I have created an account on Slack and sent you a message.

Appears solved with build 4510!
Thanks @istnv!

@obocav My updates aren't in there yet. I think you are seeing a byproduct of the config-update procedure running properly.

@istnv .  Yep got a little too excited.  It worked a few times and now back to square one on the public beta build.  Your build did work great testing.

PR merged into master, and have asked core devs to include it in companion beta

@obcocav - the update should now be v in the latest companion beta

@istnv @jmcc94 .  Hey guys.  Finally got to try out the beta.  Power commands work perfect!  Only issue now is the AV MUTE command doesnt work on either the L1500U or L610Us.  Neither the ON,OFF, or Toggle commands work for me.  Button show an error indicator when pressed.  Thanks

@obcocav There should be a message in the log when that happens.

@istnv .  Here you go:
22.07.05 22:50:22 instance(LEFT PROJECTOR): Projector reported %1AVMT: Out of parameter
22.07.05 22:50:22 instance(RIGHT PROJECTOR): Projector reported %1AVMT: Out of parameter
22.07.05 22:50:22 instance(MAIN PROJECTOR): Projector reported %1AVMT: Out of parameter

@obcocav
Well at least it is showing the correct error :)
The mute function has 3 modes, audio, video, both. In order to simplify, the module assumed 'both' would work. Apparently some projectors (including yours) don't have audio and complain about it.
Open a new issue for this while I figure out how to refactor the options.

@istnv .  haha.  The variables are "A/V mute Off" and "A/V mute On".  Let me know if I can get you more data.  Thank you!

Thank you @istnv for your work on fixing this issue with the Power commands.
Tested Beta 4517 (generic-pjlink v1.2.1) and can confirm that it now works nicely with the Epson EB-G7905U.
No errors in the log, and communication with the projector works as expected.

@istnv .  AV Mute now works perfectly in the latest beta!  Thank you so much for your work on this!

Fixed by #34


Update player ECS data from the admin view

Overview
We currently do not have a way to update player ECS data from the admin view (/admin). This would be useful so we could more easily fix players in broken game states.
Ideal Solution
A new page /admin/ecs-state-editor that allows you to view and update a player's ECS values. This could start as simple as something for editing just the player's position.

I am interested in this issue. Please assign it to me.

Deployed.


Re-enable bitmanip tests

Also tweak the verification.rst documentation a little bit to reflect how things now work (ovpsim won't).

Regression run here: https://dev.azure.com/lowrisc/lowrisc-private/_build/results?buildId=68733&view=results

Well all bitmanip tests failed, but that's with cosim enabled.
Cosim is meant to be disabled for those specific tests but I guess the disable function has broken somehow!
Rerunning the regression without cosim but I'm happy to merge this as those test failures don't cause any big issues (and it may all pass without cosim enabled).

Thanks @rswarbrick , this looks great!


obj_sticher erro

I executed "obj_sticher. Exe" But there are some mistakes.
The generated MTL file is empty. And obj file has texture coordinates but no corresponding texture "usemtl".
my test data:
test.zip

Probably you are failed to find .mtl. Please add mtl search path in LoadObj, or run obj_sticher in .obj folder for example:
../bin/native/Release/obj_sticher 01.obj 02.obj combined.obj


Is it possible to use in Nuxt.js

Hi team,
I tried to install the package like this:
yarn add @worldcoin/idkit
and then import and init it:
import * as idkit from '@worldcoin/idkit' // If you installed the JS package as a module

idkit.init('idkit-container', {
	enable_telemetry: true,
	app_id: 'app_BPZsRJANxct2cZxVRyh80SFG', // obtain this from developer.worldcoin.org
	action: 'your_signal',
	onSuccess: result => console.log(result),
})

but i got tons of errors from the node_modules:
ERROR in<EMAIL_ADDRESS>214:46-59
Can't import the named export 'Branch' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>101:7-22
Can't import the named export 'Children' from non EcmaScript module (only default export is available)
ERROR in ./node_modules/framer-motion/dist/es/components/AnimatePresence/index.mjs 22:4-12
Can't import the named export 'Children' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>12:26-41
Can't import the named export 'Children' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>21:20-35
Can't import the named export 'Children' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>21:66-81
Can't import the named export 'Children' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>42:11-26
Can't import the named export 'Children' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>42:49-64
Can't import the named export 'Children' from non EcmaScript module (only default export is available)
ERROR in ./node_modules/framer-motion/dist/es/components/AnimatePresence/PopChild.mjs 8:30-45
Can't import the named export 'Component' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>249:42-65
Can't import the named export 'DismissableLayer' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>243:104-121
Can't import the named export 'FocusScope' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>412:46-61
Can't import the named export 'Fragment' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>553:137-152
Can't import the named export 'Fragment' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>243:46-61
Can't import the named export 'Fragment' from non EcmaScript module (only default export is available)
ERROR in ./node_modules/framer-motion/dist/es/components/AnimatePresence/index.mjs 97:36-50
Can't import the named export 'Fragment' from non EcmaScript module (only default export is available)
ERROR in ./node_modules/framer-motion/dist/es/components/AnimatePresence/index.mjs 156:32-46
Can't import the named export 'Fragment' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>48:46-61
Can't import the named export 'Fragment' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>551:67-80
Can't import the named export 'Portal' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>103:46-59
Can't import the named export 'Portal' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>289:46-61
Can't import the named export 'Presence' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>101:81-96
Can't import the named export 'Presence' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>119:62-77
Can't import the named export 'Presence' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>157:46-61
Can't import the named export 'Presence' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>234:42-58
Can't import the named export 'Primitive' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>429:42-58
Can't import the named export 'Primitive' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>560:46-62
Can't import the named export 'Primitive' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>572:46-62
Can't import the named export 'Primitive' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>609:42-58
Can't import the named export 'Primitive' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>621:46-62
Can't import the named export 'Primitive' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>75:46-62
Can't import the named export 'Primitive' from non EcmaScript module (only default export is available)
ERROR in<EMAIL_ADDRESS>139:42-58

...

and there are a lot...

any help will be appreciated.

Are you setting "type": "module" in your package.json?

I think using import idkit from '@worldcoin/idkit instead of import * as idkit should work

❤

I am currently working on adding Vue support – https://github.com/vinayakkulkarni/idkit-js/tree/feat/add-vue-support


Thread crashes in PPMC simulations with cooling

The recent changes in the VL integrator (i.e. beyond this commit) are causing a large number of thread crashes in the wind tunnel simulations that I'm running. They originate early on in the simulation at the boundary of the cloud-wind shock and propagate out until the simulation volume is filled up with NaNs. After playing around with various simulation setups to see what reproduced the issue, I discovered that a hydro-only simulation (i.e. with -DCUDA -DMPI_CHOLLA -DPRECISION=2 -DPPMC -DHLLC -DVL -DOUTPUT -DHDF5 build flags) works fine (the simulation did have ~15 thread crashes per timestep at the beginning, but that stopped after ~50 timesteps). However, when I turned on CIE cooling (which I use in the wind tunnel simulations) I'm able to reproduce the large number of thread crashes that I was originally seeing. I also found that I could get the hydro-only simulation to run (with no thread crashes at all) by switching to PPMP.

I should also note that I tried using the simple integrator with a PPMC reconstruction, which also led to a large number of thread crashes.
I'm attaching a parameter file and the lines of code in the Clouds() initial conditions function and Wind_Boundary() boundary condition function that can be used to recreate this issue.
Clouds():
Line 1320: Real R_cl = 0.005;
Line 1335: cl_pos[nn][0] = 0.1 * H.xdglobal;
Line 1341: n_bg   = 1e-2;
Line 1342: n_cl   = 1;
Line 1345: vx_bg  = 1000*TIME_UNIT/KPC;
Wind_Boundary():
Line 321: vx = 1000 * TIME_UNIT / KPC;
Build flags:
-DCUDA -DMPI_CHOLLA -DPRECISION=2 -DPPMC -DHLLC -DVL -DCOOLING_GPU -DOUTPUT -DHDF5
cloud-wind.txt

Did the previous version have thread crashes when cooling was turned off (for pure hydro)? Or equivalently, does the simulation run with PPMP have thread crashes? If not, it seems likely that the cause is in the updated PPMC methods, not in cooling, and that cooling is just exacerbating the problem that is leading to the thread crashes in the pure hydro case.

Also, are you running with density and temperature floors?

I am not sure where the bug is, but I have determined that an asymmetry appears in the Einfeldt strong rarefaction test (123.txt in the 1D examples directory, although I had to run it in 3D because of the other bug I identified) with the current version of PPMC that is NOT present in the earlier commit that Helena identified. This is running with plain hydro, i.e. build flags -DPPMC -DHLLC -DVL.

Did the previous version have thread crashes when cooling was turned off (for pure hydro)? Or equivalently, does the simulation run with PPMP have thread crashes? If not, it seems likely that the cause is in the updated PPMC methods, not in cooling, and that cooling is just exacerbating the problem that is leading to the thread crashes in the pure hydro case.

There were no thread crashes in the simulation runs with the previous version or the current version with PPMP.

Also, are you running with density and temperature floors?

I don't think I tried a density floor at any point, but I did use a temperature floor, and that did not prevent thread crashes.

I'm not sure I'm seeing the same asymmetry in the hydro Einfeldt strong rarefaction. Here's a per time step animation of a central strip and the parameter file I used
123.txt
https://github.com/cholla-hydro/cholla/assets/41171425/fe6ff539-858a-433e-9df5-332a65af639e

You're right, I forgot that I had modified the CFL number. Helena, does the issue start behind the cloud? Sometimes the cloud-wind setups can be quite sensitive to the initial vacuum created behind the cloud, so it could be that the slight modification Bob made to the reconstruction is triggering a problem that was getting smoothed over in the past. Are the thread crashes from a negative density?

The thread crashes have negative densities and energies. And it's hard to tell exactly where they're originating from, but here's a slice from after the first timestep. It sort of looks like they're coming from the sides of the cloud, not behind it.

Resolved in #361

Partially resolved in #361. Still some thread crashes in PPMC


feat: show vars switch when running in dev environments

This changes the dev task by setting a development NODE_ENV variable at run time.
The siteComponent Pug template has been updated to conditionally display the vars version switch, depending on what value is read from the NODE_ENV.
--
Currently, we'd only like to show the "Vars Version" switch when running the site locally. We can do this by restricting that drop down to only run when a specified environment variable is set. We're not currently asking folks to use .env files for environment variable management, so I've gone the route of setting the NODE_ENV to development when the yarn start task is invoked.
Once merged, these changes will close #1263

Description

How and where has this been tested?

How this was tested:

Tested locally by changing the environment variables to see how the Pug conditional renders

To-do list

[ ] If my change impacts other components, I have tested to make sure they don't break.
[ ] If my change impacts documentation, I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.

[ ] This pull request is ready to merge.


Use tab and select first match in completion #127

It can be enabled through LspOptionsSet (It really should be named LspSetOptions)
call LspOptionsSet({
	ignoreMissingServer: true,
	noNewlineInCompletion: true,
	noSelInCompletion: false,
	useTabInCompletion: true,
})

"noSelInCompletion" is a bit of an odd name. What about "selectFirstCompletion", which defaults to false? Or in any case, I'd drop the "no" prefix and flip the default value.


Exceptions in async functions may not have being logged

Version
3.0.4
Reproduction link
https://github.com/linden5/vue-cli-not-logging-error-reproduce
Node and OS info
Node 8.12.0 / yarn 1.12.3 / Windows 10
Steps to reproduce

yarn install
yarn serve

and the console would log 'Failed to compile with 1 errors' without error details
What is expected?
Error details can be properly logged
What is actually happening?
Error details are not logged

This problem is actually caused by friendly-errors-webpack-plugin, but I think vue-cli should log error details to help users locating problems quickly.
After having a glance of vue-cli-service source code, this problem may be related to error handling of async functions such as service#run.

So it's an upstream problem? we can see if we can work around it, but I don't really think so right now.


Modify generation temperature for code generation keyword args to 0.2

What does this PR do?
This PR changes the generation temperature from the default 1.0 to 0.2 for code evals. For generation of code, lower temperature leads to more deterministic and better outputs. Also, this is the standard in other frameworks, see: https://huggingface.co/spaces/bigcode/bigcode-models-leaderboard.
What issue(s) does this change relate to?

Before submitting

[ ] Have you read the contributor guidelines?
[ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
[ ] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
[ ] Did you update any related docs and document your change?
[ ] Did you update any related tests and add any new tests related to your change? (see testing)
[ ] Did you run the tests locally to make sure they pass?
[ ] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

Wouldn't this break backwards compatibility for users for ICL code evals, and such that users cannot recover the temperature=0.1 behavior without editing the code? Instead, we should add a temperature argument to the class that gets passed to the generation kwargs.

Wouldn't this break backwards compatibility for users for ICL code evals, and such that users cannot recover the temperature=0.1 behavior without editing the code? Instead, we should add a temperature argument to the class that gets passed to the generation kwargs.

Yes, that is true, it would break backward compatibility. However, the default temperature right now is 1.0 not 0.1 which is something I would consider more of a "bug" that should be fixed/a warning should be raised saying that  the temperature is not standard and the results will be suboptimal.
However, I do agree that we should add generation kwargs and I think there is another PR for that.
I will leave this open so that @abhi-mosaic  can use this branch as a temporary workaround and will close it once the other PR gets merged in.

If it's a bug, and the other PR makes it in before a next release, that's fine to merge.

@mansheej im guessing this should be closed now?


Module resolution: Package Entrypoints not correctly used for types / source

Demo Repo
https://github.com/jorenbroekema/ts-entrypoints-bug
Which of the following problems are you reporting?
The module specifier resolves, but to the wrong file
Demonstrate the defect described above with a code sample.
import { isFoo } from "foo";

const whatever = isFoo(); // TS2693: 'isFoo' only refers to a type, but is being used as a value here.

export { whatever };

Creates error: TS2693: 'isFoo' only refers to a type, but is being used as a value here.
It resolves to the "types" entrypoint, which is okay for getting an understanding of the "type", but then when compiling it should use the "value" which is coming from the "default" entrypoint.
Run tsc --showConfig and paste its output here
{
    "compilerOptions": {
        "target": "esnext",
        "module": "esnext",
        "moduleResolution": "bundler",
        "declaration": true,
        "emitDeclarationOnly": true,
        "strict": true,
        "noImplicitThis": true,
        "alwaysStrict": true,
        "noImplicitAny": true
    },
    "files": [
        "./foo-test.ts"
    ],
    "include": [
        "**/*.ts"
    ],
    "exclude": [
        "node_modules",
        "**/coverage/*"
    ]
}

Run tsc --traceResolution and paste its output here
======== Resolving module 'foo' from '/home/joren/code/type-entrypoint/foo-test.ts'. ========
Explicitly specified module resolution kind: 'Bundler'.
Resolving in CJS mode with conditions 'import', 'types'.
Found 'package.json' at '/home/joren/code/type-entrypoint/package.json'.
Loading module 'foo' from 'node_modules' folder, target file types: TypeScript, JavaScript, Declaration, JSON.
Searching all ancestor node_modules directories for preferred extensions: TypeScript, Declaration.
Found 'package.json' at '/home/joren/code/type-entrypoint/node_modules/foo/package.json'.
Entering conditional exports.
Matched 'exports' condition 'types'.
Using 'exports' subpath '.' with target './types/foo.d.ts'.
File '/home/joren/code/type-entrypoint/node_modules/foo/types/foo.d.ts' exists - use it as a name resolution result.
Resolved under condition 'types'.
Exiting conditional exports.
Resolving real path for '/home/joren/code/type-entrypoint/node_modules/foo/types/foo.d.ts', result '/home/joren/code/type-entrypoint/node_modules/foo/types/foo.d.ts'.
======== Module name 'foo' was successfully resolved to '/home/joren/code/type-entrypoint/node_modules/foo/types/foo.d.ts' with Package ID<EMAIL_ADDRESS>========

Again, this looks fine, but I want to get the conditional export "default" for the actual value rather than the type, to prevent 'isFoo' only refers to a type, but is being used as a value here.ts(2693)
Paste the package.json of the importing module, if it exists
{
  "name": "foo",
  "version": "1.0.0",
  "description": "",
  "type": "module",
  "keywords": [],
  "author": "",
  "license": "ISC",
  "exports": {
    ".": {
      "types": "./types/foo.d.ts",
      "default": "./index.js"
    }
  }
}

Paste the package.json of the target module, if it exists
{
  "name": "type-entrypoint",
  "version": "1.0.0",
  "description": "",
  "type": "module",
  "devDependencies": {
    "typescript": "^5.3.3"
  },
  "scripts": {
    "build": "tsc"
  },
  "keywords": [],
  "author": "",
  "license": "ISC"
}

Any other comments can go here
Perhaps I'm completely misunderstanding how conditional package entrypoints should behave for types vs values, feel free to educate me 😅

The file specified by types is supposed to describe 1:1 the exports of the corresponding .js file.  In this case it doesn’t - the .d.ts exports a type alias, while the .js file exports a const.

The file specified by types is supposed to describe 1:1 the exports of the corresponding .js file. In this case it doesn’t - the .d.ts exports a type alias, while the .js file exports a const.

Would there be a way to have the .d.ts file export a const as well then rather than a type alias? Or would that then break it again for type imports because they're now changed to be values?

You can import a dual-meaning type/value binding with import type. import type only controls whether or not you can use the import as a value in the importing file.

You can import a dual-meaning type/value binding with import type. import type only controls whether or not you can use the import as a value in the importing file.

That explains how to force it into using the type, but that's what it imports by default already, how do I force it to import the value instead?
Can you give an example in the context of:
node_modules/types/foo.d.ts:
interface Options {}

export type isFoo = (opts: Options) => boolean;

Importing it in foo-test.ts:
import { isFoo } from "foo"; // imports the type, but I want the value

const whatever = foo();

export { whatever };

Hi
Isn't the issue just needing to change /node_modules/foo/types/foo.d.ts content
to:
interface Options {}

declare const isFoo: (opts: Options) => Boolean;

Hi
I think the issue is just needing to change /node_modules/foo/types/foo.d.ts content to:
interface Options {}

declare const isFoo: (opts: Options) => Boolean;

Thanks, that solved it. so to summarize:

const isFoo = ... means it's a value
type isFoo = ... means it's a type (exclusively)
declare const isFoo: ... means this is the type declaration that belongs to the value isFoo

I also see now that I made the mistake of not differentiating properly:
const isFoo = (opts: Options) => boolean; // error, `boolean` is type instead of value

and
const isFoo: (opts: Options) => boolean; // type

Note: Don't use Boolean, always use boolean (same goes for number and string).  The former refers to "boxed" object values that you get by calling new Boolean.

Note: Don't use Boolean, always use boolean (same goes for number and string).  The former refers to "boxed" object values that you get by calling e.g. new Boolean(true).

you are right......I wrote that from my phone and the autocorrect did their thing 🙈


Forgot master password. Need to reset connection profiles

Hi,
How do I reset connection profile master password?

Hi,
I don't think it's possible without knowing the old one.

May be I didn't explain myself well. I don't want to recover anything. I want to nuke the profiles, create a new one with master password, and add profiles one by one. That should be possible, right? I just can't figure out how do I do that.

In your g:vorax_homedir folder there are the key files: id_rsa and 'id_rsa.pub'. Just drop them. Also, you should edit the profiles.xml files and get rid of the password attribute.

Thank you. I didn't know where to find profiles.xml but deleting the keys worked.


Add version 10.0.0

Hi,
I add version 10.0.0 of markdown-pdf. If my code is ok, please merge it.

Thanks for the contribution! (Sorry for the delay in noticing.)
LGTM
Due to changes in the DockerHub specification, pistatium/markdown-pdf can no longer host the new version of Image.


chore: pass knuu as an argument to the testnet.New

As pointed out before in one of the comments, if we pass knuu as an argument to the testnet constructor, user will have more flexibility in playing with knuu options and can optimize the resource consumption based on the test requirements.
This PR attempts to achieve that goal.

CI is failing b/c NewBenchmarkTest also needs to be updated to account for the TestnetOptions modification

Thanks for pointing it out. now it is fixed.

golangci-lint is complaining

forgot to save a file, pushed again

Oops nvm I can't push to your fork until you add me as a collaborator.

Approving to unblock. I can address nits in a follow-up if this merges before I get permission to push my commit that addresses nits.

also, as a broad question, why were we able to merge this PR when only a single core app engineer approved?

also, as a broad question, why were we able to merge this PR when only a single core app engineer approved?

yes there was another issue in the ci as well. There were some unresolved conversations too which is fixed by Rootul.


Modules: Prefer local composable instead of exposed ones from modules

Environment

Operating System: Linux
Node Version:     v20.11.0
Nuxt Version:     3.10.3
CLI Version:      3.10.1
Nitro Version:    2.8.1
Package Manager<EMAIL_ADDRESS>Builder:          -

Reproduction
Same as in https://github.com/nuxt/nuxt/issues/12569 but for modules.
Describe the bug
I don't have a reproduction but the request is exactly the same that was made here: https://github.com/nuxt/nuxt/issues/12569 but for modules.  By default, local composables should override the ones defined in local or third party modules.
Additional context
No response
Logs
No response

I see, thank you @danielroe


Feature Request: support TypeScript syntax.

It would be great if you could add support of typescript react syntax.

A new version is published that adds support for both TypeScript and TypeScript React. Sorry that it tool me too long.


Please provide me slack invitation link

Please provide me slack invitation link

Please see the link to join the Slack workspace provided in our InstructLab Slack Guide.


Rename key to custom_curl_opts

A continuation of #112

I'll merge in the changes. I guess the key should ideally be added to the input_variables dict of all the processors, but that would mean everyone having to update their overrides, so I'll leave it be.

They could also add it via preferences which would allow folks to add custom opts, enter it via the key value under run or use a pre-processor to add it without modifying recipes or overrides.

Yes of course, it's only to properly document the available keys.


Remove ad-hoc dependency from Gemfile

This code was introduced in https://github.com/thoughtbot/ember-cli-rails/pull/598/commits/367e42831771f9e0fbcb6430016b3bc9c490b27a
However, ember-cli-rails-assets 0.7.0 solved Rails ~>7.0 issues.

@seanpdoyle
Could you review this PR?
This is a development-only refactoring.


Nudge Green Brightness

I might be wrong but this seems to be less transparent than previous version.
I have uninstalled this latest version and gone back to using older one from 23 days ago.

Seems like I change the nudge green to be brighter without noticing it..
I changed it to be exactly like the old green so it should be fine for next version

Fixed with https://github.com/Khroki/MCEdit-Unified/commit/ec2bc210a15b87ab7f27c969b2a9f68ab74b37d0

So now, the only thing we did was add the selection tool green nudge button glow to the clone tool and import tool green nudge buttons: http://imgur.com/a/KRq7B
You may have to read that sentence a few times...

I actually added it and it took me 3 times to read this sentence to understand it! :P