SQL formatted changelogs mistakenly identify rollbackEndDelimiter value for endDelimiter value

Search first

[X] I searched and no similar issues were found

Description
When using SQL formatted changelogs, Liquibase mistakenly identifies the rollbackEndDelimiter value for endDelimiter value when rollbackEndDelimiter is defined after the endDelimiter.
The issue is that the sql formatted changelog's changeset attributes are being parsed with regular expressions and endDelimiter is a substring of rollbackEndDelimiter. This allows the regex looking for endDelimiter to actually match on the rollbackEndDelimiter definition.
Steps To Reproduce
Run the following changelog. It will throw an error because the endDelimiter is not set to the correct value
--liquibase formatted sql

--changeset jlyle:mytest stripComments:false runOnChange:true runAlways:true endDelimiter:/ rollbackEndDelimiter:;

select 1 from sys.dual
/

select 1 from sys.dual
/

select 1 from sys.dual
/

begin
    null;
end;
/

Expected/Desired Behavior
endDelimiter and rollbackEndDelimiter to be able to be dfined correctly regardless of the order in which they are specified.
Liquibase Version
4.27.0
Database Vendor & Version
No response
Liquibase Integration
No response
Liquibase Extensions
No response
OS and/or Infrastructure Type/Provider
No response
Additional Context
The solution is simple, the src/main/java/liquibase/parser/AbstractFormattedChangeLogParser.java file just needs modified so changeset attributes look for a word boundary immediately before the attribute name. For example:
ROLLBACK_END_DELIMITER_REGEX = ".*rollbackEndDelimiter:(\\S*).*";

becomes
ROLLBACK_END_DELIMITER_REGEX = ".*\\brollbackEndDelimiter:(\\S*).*";

In order to avoid substring matching.
I am having some issues with my liquibase project setup right now I am trying to figure out. I will submit a PR as soon as I get those issues figured out. But this is super small, so if one of the team wants to grab it and get this handled, I wouldn't complain about that either!
Are you willing to submit a PR?

[X] I'm willing to submit a PR (Thank you!)

Awesome, thanks @wwillard7800 ! I've narrowed my issues down to 2 previous PRs and reached out to members involved there, so I'm hoping to be able to get back to contributing before too long!


Edit submenu

I don't think there is a need for edit submenu. As option like cut copy paste are of not much use.

Which option do you mean? I am not sure if I understand.

Ah, I see. This is from electron. Not sure if I can edit this menu.

Isn't it visible only when not in release mode? I have downloaded stretchly from GitHub releases and the menu is not there. It may also be Windows specific, not sure...

It is not visible on my friends Mac. I am unsure about the behavior. It is visible for me.

@jainaman224 you are also on mac?
I've tested on my Debian/XFCE and I don't have it.

@hovancik With my friends PC. I have also tested it on windows. There is no such menu. So, maybe we can close this issue. But it gives me an idea to have a menu like this. So, that we don't need to have separate about and settings page.

My bad, I have it on Settings page, but I do not have it on break window.
Anyway, I will close this as it is not big issue. Probably depends on platform...


allow to override the default os.Hostname() when creating PrometheusURLs

@juliusv PR for #716

I added a getServerHostname func to be used in both "MustBuildServerURL" and "globalURL". If preferred, I can squash the commits.

I guess, I need a lesson in setting up my local go environment. go build didn't fail, but travis-ci did.

sorry for the failing builds - I'll fix it at home in a working Go environment.

@juliusv looks like the simple new flag now doesn't break the build. I also updated the Dockerfile to reflect the recently changed config format and changed logging.

:+1: otherwise

now the hostname flag with os.Hostname() fallback are available in Hostname().

:+1: thanks!

thank you, too, especially for your patience discussing such a simple piece of code with a Go noob ;-)

@gesellix My pleasure :)


As a User I want to have a cli with configuration file

Issue moved to gnames/gnfinder #89 via ZenHub


feat: Allow usage of force in fingerprint method + fix cache with new path for fingerprint tests

Hey,
The first thing of this PR was to provide the possibility to pass --force option to a task and provide it to fingerprint(force: $force)
This is a case i have in some projects, when i want to force run the task even if already runned.
I want your return about fingerprint_save(...), should be only saved in the case of "non-force" case or save it anyway the value of force ?
Additional :
This PR include changes for fixes some tests (fingerprint)
When running multiple times the tests locally, the second run fail because the new path of cache as changed recently

👍🏼
Thanks
Could you add an entry in the CHANGELOG? Thanks

Changelog updated 🍻

Thanks 👍🏼


feat(es/parser, es/transform): support  class static blocks

[x] AST definition
[x] Visitor support
[x] Parser support (ES)
[x] Parser support (TS)
[x] Codegen
[ ] Transformer support

How do you think about splitting this into parser / codegen PR (done?) and transform PR?
It will unblock Deno.
cc @dsherret
(https://github.com/swc-project/swc/issues/2125#issuecomment-907667223)

It sounds good.

@kdy1 I'm okay with merging this PR! But please review some additional commits


Could be a node instead of a string of an id

https://github.com/ghosh/micromodal/blob/bc03d6d972caf11dccff557eadcd00b7ab75b2f3/src/index.js#L34

@kud, I do not understand what you mean. Could you explain it in more detail?

Hey @ghosh , sorry, it's not well explained.
There, this.modal = document.getElementById(targetModal) you're asking for targetModal as a string of an id.
I would like to be able to give a node instead of a string of an idea, like
document.querySelector("my-selector")
It allows the user to give anything they want as node, instead of necessarly an id.

hmm..ok fair point. Will consider this. Thanks for opening an issue.

No worries, thank you so much :)
Most of libs give the possibilty to enter either an id either a DOMNode. It's useful for beginners and advanced developers IMO.

this.modal = typeof targetModal === "string" ? document.getElementById(targetModal) : targetModal

Duplicate of #65


Persistent node ID

To keep our peer that is used in bootstrap nodes list having the same nodeID we need to define it after restoration from the snapshot before the node start.

Connected with: https://github.com/protofire/Filecoin-node-hosting-management/issues/47


Usage license

Hi Antoine,
Thanks for building and sharing this. Could you please add a license file to clarify any restrictions on reuse?

Hi,
Thanks for your feedback. I just added the MIT license.


Project setup

Following tasks were completed:

Fix linter errors.
Include minimum styling.
Set up routing using React Router.
Created the React part of the app.

Hi @TayyabKM 😊,
STATUS: APPROVED! 🥇 💯

Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit: 🚀
Congratulations! 🎉
Highlights
✅ Project has met all the technical aspects you needed for this project. Keep rocking!
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


On214 correct logout url

Fixes https://github.com/CartoDB/onpremises/issues/214
The old code extracted the username from the domain, the new code also takes into account subdomainless mode.
Acceptance
Test logout for the 4 combinations of org user / normal user and subdonmainless / domainful. All of them should redirect to the user dashboard.

Uhm, this didn't trigger backend tests! I'll fix the typo to check if it's now triggered before moving to acceptance.


[Feature] Multiplayer support.

Is multiplayer support possible and if so could it be implemented?
Currently if a friend join's a session while the art-net control panel is placed he gets the attached error.

Multiplayer is currently not implemented and supported, therefore I renamed the issue to be a feature request. I have it already on my "would be nice to have" feature list, but not with a high priority, yet. Probably I want to wait until modding for dedicated servers is available, to consider this directly when starting to think about the multiplayer implementation, and not now implement something which I might have to throw away then.


Release JDK11 compatible version

Make Scriptella compile and run on JDK11.
JDK11 is a major release with many breaking changes. It's important to support it since many companies are transitioning to openjdk due to Oracle's updated support terms for JDK.
Issues to resolve:

Discontinue mail driver (probably replace with shell) due to javax.mail excluded
JavaScript compat?

Also fix ScriptellaDriverITest in #2

Better support for Janino 3

Early preview is available as 1.3-SNAPSHOT https://oss.sonatype.org/#nexus-search;quick~org.scriptella


Fix reference to django and empty web role templates.

Fix #1898 Empty Web Role and Django Web Role templates don't work

Make sure we don't have any other references to these by name (thinking specifically in unit tests, but a full text search is going to be the easiest way to check anyway).

The only hits are in the old msi. Fix it or leave it?  I don't even know if that still builds.

It should still build, but it's not of huge value. Let's fix them so that we don't leave it too far from working.

Updated installer.

LGTM


[Feature Request] Add an optional delay between keystrokes

Is your feature request related to a problem? Please describe.
At the moment, if there are multiple text boxes relating to something, e.g: a date of birth field, or passcode. When inputting the text it can sometimes try to type too quickly (much quicker than a human would) and can subsequently miss inputting some characters.
Describe the solution you'd like
What would be a nice addition if on inputText you could specify a time delay between keystrokes, like 100 (in ms), very similar to what other frameworks do such as https://playwright.dev/docs/api/class-keyboard#keyboard-type-option-delay
Describe alternatives you've considered
At the moment, I'm clicking between the various inputs even though the cursor moves to the same box just to guarantee the input is done correctly, this however slows down the tests by a couple of seconds as I have to wait for the next input to be selected.

it would only miss if you're blocking the UI thread on the device, which is a code smell, or you're running on a very low memory host or something ?  How is it missing the input keystrokes ??? You should be able to capture all keyboard strokes without having to introduce delays

@sdfgsdfgd - I appreciate that this happens on CI (but a reasonable amount of power considering) but there are also benefits in that it would allow the input to appear more human rather than machine with a small delay between the keystrokes.
I also get a similar issue with @orestesgaolin where it can sometimes input extra characters as well:


fix(GRO-315): navigation button hit area size in MobileNavMenu panes

The type of this PR is: fix
This PR resolves GRO-315..
Description
This PR fixes the hit area size of the backLink button in MobileNavMenu panes. Now the hit area of the button has a larger tap surface what is important for UX.
(https://user-images.githubusercontent.com/83413732/118157093-cc099580-b422-11eb-8cca-6b71a2cf0b0d.jpeg)

👍


Picovoice Issue: PicovoiceActivationError on RPi Buster

Make sure you have read the documentation, and have put forth a reasonable effort to find an existing answer.
Expected behaviour
Run initialization without any error
Actual behaviour
With my code
import time
import sys
from picovoice import Picovoice

class VoiceAgent():

    def __init__(
        self,
        access_key="********************************************"):

        self.handle = Picovoice(
            access_key=access_key,
            keyword_path="/path/to/wakeword.ppn",
            wake_word_callback=self.__wake_word_callback,
            context_path="/path/to/context.rhn",
            inference_callback=self.__inference_callback)

    def __wake_word_callback(self):
        print("Wake up Word detected ")

    def __inference_callback(self, inference):
        print("Inference detected")
        print(inference)

if __name__ == "__main__":

    voice_agent = VoiceAgent()
    print("starting voice agent")

I get
Traceback (most recent call last):
  File "/home/pi/.local/lib/python3.9/site-packages/picovoice/picovoice.py", line 185, in __init__
    self._porcupine = pvporcupine.create(
  File "/home/pi/.local/lib/python3.9/site-packages/pvporcupine/__init__.py", line 77, in create
    return Porcupine(
  File "/home/pi/.local/lib/python3.9/site-packages/pvporcupine/porcupine.py", line 158, in __init__
    raise self._PICOVOICE_STATUS_TO_EXCEPTION[status]()
pvporcupine.porcupine.PorcupineActivationError

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/path/to/script.py", line 30, in <module>
    voice_agent = VoiceAgent()
  File "/path/to/script.py", line 13, in __init__
    self.handle = Picovoice(
  File "/home/pi/.local/lib/python3.9/site-packages/picovoice/picovoice.py", line 192, in __init__
    raise _PPN_RHN_ERROR_TO_PICOVOICE_ERROR[type(e)] from e
picovoice.picovoice.PicovoiceActivationError

Picovoice console shows 0/3 connected devices
Steps to reproduce the behaviour
RaspberryPi 4 model B
Raspbian Buster Lite
Python 3.9.10
Picovoice V2.1
AccessKey created via Picovoice Console
.ppn file and .rhn accessible

Installed via
python3 -m pip install picovoice
Script run without sudo (modules installed locally)

do you have internet connectivity?

Do I need internet connection? I thought this service would work offline.

You do periodic internet connections for AccessKey validation.

Alright, works like a charm now. Thank you!


ayâw (II, AI, TI) do not get paradigms

When searching with ayâw, one does not get a paradigm for any of the three readings of this verb as an II, AI, or TI, cf. nothing appears when clicking for paradigms (only the TA reading with ayâwêw as the lemma gets the paradigm):

This appears to have been fixed in #419.


First shades implementation

Hi, and thank you for making this open-source project. I have successfully installed your newest build, but still only get Climate, Sensor and Light Platforms, not the Covers. The Covers are visible in the xComfort Bridge app. Is there something I need to configure?


DAVIS build broken

Hi,
It looks like after adding DAVIS_CONFIG_DVS_FILTER_..... the build is broken. I pulled the latest of the libcaer, however, that did not help. I went back to a few commits and it works fine. I did not validate exactly which step it broke but I checkout 4c1e1ee00c4b87fa0280344aa1b87d572ad9ee9a commit and it seems to be working fine. From the code, it looks like the changes were due to support for miniDVS so I went to that commit. Please fix or let us know if there is an extra step I might be missed to get over this issue with the latest commit.
Best,
Snehesh

Hi Snehesh,
Can you checkout the master branch of the davis_ros_driver (and make sure it is up to date), and try the following?
cd path_to_your_catkin_workspace
rm -rf build/libcaer_catkin/ build/davis_ros_driver/ devel/lib/libcaer.so devel/lib/davis_ros_driver/
catkin build --force-cmake libcaer_catkin davis_ros_driver

Please let us know if that works, or what error message you get if that does not.
Best,
Henri

Hi there,
i've checked it out myself.
Still does not build with the indicated workaround. The output error is:
make[2]: *** No rule to make target '/home/vagrant/catkin_ws/devel/lib/libcaer.so', needed by
'/home/vagrant/catkin_ws/devel/lib/liblibcaer_catkin.so'.  Stop.
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/libcaer_catkin.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

Cordialement,
Nicola

Hi,
The error looks like this one: https://github.com/uzh-rpg/rpg_dvs_ros/issues/36
Have you tried using the fix given by cJarvers there? Can you tell us a bit more about your system (which linux distribution / version, which version of ROS)?
Also, if that does not work, have you tried checking out commit https://github.com/uzh-rpg/rpg_dvs_ros/commit/4c1e1ee00c4b87fa0280344aa1b87d572ad9ee9a (as sneheshs), clean your build and devel folders as indicated above, and rebuild it? Does that solve the issue?
Thanks,
Henri

Hi Henri and Nicola,
I had to revert back to 4c1e1ee commit for this to work. However, please make sure you update to the latest caer library as well. I needed to do that for this to work.
Best,
Snehesh

Hi There,
I am on an up-to-date ArchLinux, ros LUNAR installed through package manager and works with other stuff.
I have managed to get past the libcaer compilation by applying the fix of cJarvers you mentioned (modifying libcaer's CMakeLists.txt and libcaer-extras.cmake.in, no symlinks).
The fix both works with HEAD and 4c1e1ee (the libcaer part).
However, afterwards, catkin build gets stuck with davis-ros-driver as it does not find the rospkg python module.
I know there are issues with ArchLinux being built around python3 and conflicting with ROS but the workaround suggested in ArchWiki (forcing python2, that works with all the other packages i tried) seems to be ignored by rpg_dvs_ros.
I'm looking into it.
Cordialement,
Nicola R.

Hi There,
I've fixed the python problem for ArchLinux.
To get rid of missing package error, I just forced dvs_ros_driver to use python2 by modifying rpg_dvs_ros/dvs_ros_driver/cfg/DVS_ROS_Driver.cfg.
In the end it compiled. I did not test it because the DAVIS camera is at the lab.
When I tried to compile instead dvs_rendered, problems started to rain down.
To make it compile and, most important, run, I had to:
symlink all the references to:

libopencv_core.so.3.3.0
libopencv_imgproc.so.3.3.0
libopencv_imgcodecs.so.3.3.0

to their 3.3.1 version.
Also, I had to symlink

libPocoFoundation.so.48

to its .49 version.
After unsuccesfully searching how to modify these "requests for libraries" on the rpg_dvs_ros side, I gave up and grabbed a sandwich.
On another system, building the dvs_rendered produced the same kind of problems of before (wrong library version), but with libboost.
After this I really gave up.
Best,

Tried again, camera is "busy" so no driver tests.
No luck with the rendererer though.
Still gives back a "attempted to unlock mutex that was not locked" and dies (exit code -6).
At this point IDK if the problem is the code or in the wrong libraries.
Best,

Just for the sake of validating your steps vs Arch Linux related issues, I'd recommend trying it out in an Ubuntu setup.

In *buntu it works out of the box.
Best,

Thanks supitalp,
I've tried it, no out-of-date stuff found.
It was less time consuming to bring up a *buntu vm and now it happily works.
Best,

Official libcaer build is now used, see README for further details.


Archlight Server Error

Is it a mod compatibility issue?
Select One
If it's a mod compatibility issue, please provide the link(s) to the incompatible mod(s)
No response
Minecraft version
1.18.x
Describe the issue
So i just am running a 1.18.2 Archlight server and after i added immersive portals and tried to join it gave me this error:
Internal Exception: io.netty.handler.codec.EncoderException: java.lang.NullPointerException: Cannot Invoke "net.minecraft.resources.ResourceKey.m_135782_()" because "dimension" is null Arclight when using Immersive Portals
Couldnt find any fix (i did find a forum abt this but no solution)

I'm sorry but Immersive Portals for Forge only supports running on Forge Servers. Due to missing development capacities we can not support Hybrid Servers. I'm open for PRs, if you want to contribute.


Where can i download sponge version?

In old GP discord it says GriefDefender is free to use but If you require support, purchase it on https://www.spigotmc.org/resources/griefdefender.68900/ to get access to the private discord. i saw a channel called as Updates and there is Sponge GD files however you told me that griefdefender-sponge-1.2.4-B15.jar is a very old build and it's the last one you shared in that discord channel

Build it on github.


General/ Credentials Creation Process

Credentials will be initialized each time when we sync Jira ticket through the request.


Problem with ampersand in folder name

Description

When a folder has an ampersand in the name and you right click and choose "Show in Explorer" it returns the following warning:

Opening folder in Explorer failed
'Test' is not recognized as an internal or external command,
operable program or batch file.

("Test' is everything after the &)

If you choose a file within that folder Atom return the following warning:

Opening file in Explorer failed
The system can not find the path specified.

Steps to Reproduce

Click a folder with an & in the name
Right click on the folder and choose "Show in Explorer".

Expected behavior: Atom opens the folder in explorer
Actual behavior: Atom opens the parent folder and returns an error
Versions
Atom version: 1.5.3
OS and version: Windows 10

Can't reproduce.
I've got Windows 10, too and Atom 1.5.3.
Opening a folder & Test works flawlessly.
Maybe you had an old version of Atom installed previously?
What does your regkey look like?
HKEY_CLASSES_ROOT\Directory\Background\shell\Atom\command
and
HKEY_CLASSES_ROOT\Directory\shell\Atom\command

Reproduced on Windows 10 x64, Atom 1.7.0-dev-fa6905f.

My atom has since updated to version 1.5.4 it seems.
"HKEY_CLASSES_ROOT\Directory\Background\shell\Atom\command" has the following value:
"C:\Users\Maxim\AppData\Local\atom\app-1.5.4\atom.exe" "%V"
and "HKEY_CLASSES_ROOT\Directory\shell\Atom\command" has the following value:
"C:\Users\Maxim\AppData\Local\atom\app-1.5.4\atom.exe" "%1"

I totally misread the issue, please forgive me.
I can reproduce it as well on Win10 and atom 1.5.4 and 1.7.0-dev.

I've copied this issue to the correct repo thanks.


Sequencing UB

May need some modification of the expected output. It's extremely hard to reason about what someone would actually expect these programs to do.
Signed-off-by: Scotty Bauer<EMAIL_ADDRESS>

woops I have kernel tabbing on, I'll fix that in the morning match the rest of the code.


ArgumentNullException

I tried seeing if this was on my end, but even after resetting the bot entirely I still received the same error message.
Stacktrace: http://hastebin.com/rokojulolu.xml | From errors.txt
Additional: https://s31.postimg.org/7du6uuujf/Untitled.png | From console output
OS: Ubuntu Server 16.10

It pretty much means song cannot be found. Sometimes it works on another try, sometimes you need to modify search parameter, in this case try another link. It's videolibrary being unable to find the song's audio stream, i could try dropping the audio quality restriction which would maybe resolve a small part of those, but I think it mostly occurs due to blocked videos.

Tried another song and it worked, of course. In retrospect I should've tried that before coming here but either way thank you for the quick reply.


Can Scheduled executor run non-serializable tasks?

I have a non-serializable task to schedule. The executor is failing to submit this task with a NotSerializableException. The task is available to the worker node in its classpath. Is there a way I can execute these kind of tasks on the worker node.
public class NonSerializableTask implements Runnable {

    @RInject
    private RedissonClient redissonClient;

    // several members which are non-serializable

    @Override
    public void run() {

    }
}

Which codec do you use? Default is json codec and it serializes non-serializable objects

Yes actually to begin with I was using the default json codec which produced this error
 java.lang.IllegalArgumentException: com.fasterxml.jackson.databind.JsonMappingException: Infinite recursion (StackOverflowError)
Since I could not make it work, I was trying to play around with different codecs but without any success.
Please any suggestion would be helpful.

One more bizarre thing is that the json recursion is happening between these classes
 java.lang.IllegalArgumentException: com.fasterxml.jackson.databind.JsonMappingException: Infinite recursion (StackOverflowError) (through reference chain: java.security.ProtectionDomain["classloader"]->sun.misc.AppClassLoader["defaultDomain"]->java.security.ProtectionDomain["classloader"]->sun.misc.AppClassLoader["defaultDomain"]->java.security.ProtectionDomain["classloader"]

Yes actually to begin with I was using the default json codec which produced this error
java.lang.IllegalArgumentException: com.fasterxml.jackson.databind.JsonMappingException: Infinite recursion (StackOverflowError)

Could you share your test code to reproduce it?

Sorry for a late response...
Unfortunately I cannot share the actual Task code, but here is what I did to reproduce the problem
This code generates the exception
       JsonJacksonCodec jjc = new JsonJacksonCodec();
        try {
            byte[] b = jjc.getValueEncoder()
                    .encode(new NonSerializableTask());

        } catch (IOException e1) {

            e1.printStackTrace();
        }

This one works fine
        ObjectMapper om = new ObjectMapper();

        try {
            om.writeValueAsBytes(new NonSerializableTask());
        } catch (JsonProcessingException e) {
            e.printStackTrace();
        }

Try to use another codec as workaround

Can't reproduce it. Here is my test code:
    public static class MyClass {

    }

    public static class NonSerializableTask implements Runnable {

        @RInject
        private RedissonClient redissonClient;

        private MyClass clazz = new MyClass();

        @Override
        public void run() {
            // TODO Auto-generated method stub

        }

    }

    @Test
    public void test() throws IOException {
        JsonJacksonCodec jjc = new JsonJacksonCodec();
        byte[] b = jjc.getValueEncoder().encode(new NonSerializableTask());

    }

This is how I was able to reproduce it
import java.io.FileNotFoundException;
import java.io.IOException;
import java.nio.charset.StandardCharsets;

import org.redisson.api.RedissonClient;
import org.redisson.api.annotation.RInject;
import org.redisson.codec.JsonJacksonCodec;

import com.fasterxml.jackson.databind.ObjectMapper;

public class TestProgram {

    public static void main(String[] args) throws FileNotFoundException {

        JsonJacksonCodec jjc = new JsonJacksonCodec();
        try {
            byte[] b = jjc.getValueEncoder().encode(new NonSerializableTask());
            System.out.println(new String(b, StandardCharsets.UTF_8));
        } catch (IOException e1) {
            e1.printStackTrace();
        }

    }

}

class NonSerializableTask implements Runnable {

    @RInject
    private RedissonClient redissonClient;

    private ObjectMapper mapper = new ObjectMapper();

    @Override
    public void run() {

    }

}

@mrniko Never mind, find out the original issue here http://stackoverflow.com/questions/9567103/make-jackson-objectmapper-serializable...  Thanks a lot for taking a look into this issue.

Why don't you create it right in run method?

or mark it transient, or even better, create a static helper to return a singleton (it is thread safe).


1-sized array's pointer typed element set to nil, after received from channel and print in a loop

What version of Go are you using (go version)?
go version go1.9.2 linux/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/helin/env/gopath"
GORACE=""
GOROOT="/home/helin/env/go"
GOTOOLDIR="/home/helin/env/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build809756853=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?
package main

import (
	"fmt"
)

const arraySize = 1

// comment above and uncomment below, will work as expected.
// const arraySize = 2

type foo struct {
	bar [arraySize]*int
}

func main() {
	ch := make(chan foo, 2)
	var a int
	var b [arraySize]*int
	b[0] = &a
	ch <- foo{bar: b}
	close(ch)

	for v := range ch {
		// uncomment below, will work as expected.
		// fmt.Println(v.bar[0])
		for i := 0; i < 1; i++ {
			fmt.Println(v.bar[0], b[0])
		}
	}
}

What did you expect to see?
// Output:
// 0x10410020 0x10410020

What did you see instead?
// Output:
// <nil> 0x10410020

Playground link:
https://play.golang.org/p/Qd8fDy-ls3

I dont understand the issue. Why are you closing the channel and then attempting to recieve on that closed channel?

@as receiving from the closed channel is safe, it will read all the remaining values.
In this case I just don't want the for ... range to block forever.

Given that there are no explicit goroutines and that printing a value changes the behavior, I think this is a compiler bug or perhaps a runtime bug.

/cc @mdempsky @dr2chase @aclements

I can repro this with Go 1.9, but it seems to work as expected at master.

Array-of-size-1 is a special case in the SSA code, too.

This is the buggy rule:
(ArraySelect [0] (Load ptr mem)) -> (Load ptr mem)

It allows the load to move blocks.  It needs an @v.Block modifier, I think.

The bad rule was removed at tip during https://go-review.googlesource.com/c/go/+/71731 .  Seems coincidental that it was removed, but that's why tip is ok.

Add test + candidate for backport?

The removal was indeed coincidental; since I was freshening someone else's old patch, I just kept the change.  I'm trying to figure out if we need it, given the other make and select rules.


Anyone has been able to upgrade react-router-redux to ^4.0.0?

React-router-redux has some breaking changes and I was wondering if anyone was able to upgrade to 4.0.0? If so, is there a PR I can look at?
I've been looking at this PR: https://github.com/davezuko/react-redux-starter-kit/commit/0df26907 but react-redux-universal-hot-example is a little different.

Here
https://github.com/erikras/react-redux-universal-hot-example/pull/951

Great. Thanks!


[FEAT] Ability to prefill from & to tokens, and amounts using the URL parameters in the liquid staking page

CC @vutuanlinh2k2 @vutuanlinh2k2 @devpavan04 this is something I think we should be doing all across the flows too. It allows us to pass around links that will auto-fill details as needed. All things can be configured from the URL for LST, Restaking pages

Connected chain ("from")
Destination chain ("to")
Token
Amount
Operator selected
etc


Cannot configure gmail

I'm getting this message from gmail:
5.5.1 Authentication Required. Learn more at 5.5.1  https://support.google.com/mail/?p=WantAuthError
I enables access for less secured apps in gmail.
My config is: http://pastebin.com/fnup7W8j
In debug I can see that in SMTP.php $this->transport is 'tcp' - shouldn't be 'tls' ?

For gmail, the connection_class property has to be "login", not "smtp"

Now that's a quick response!
Works.
Thanks!

I'm glad that it works. I'm closing this then.


{"error":"No X-Hub-Signature found on request"}

I've  been disturbed about this error for a while，until  i resolved it by configuring the webhook secret. The secret parameter must be set since it need a x-hub-signature,does the secret necessary and what about cancel this expression:if (!sig).

Sorry @Gan-Jason I can't quite figure out what you're reporting here. The signature is a necessary part of the process, are you suggesting it shouldn't be for some reason or is this a usability or documentation problem?

i didn't konw the signature is necessary ,forget what i said and thank u


Model can't find files while training

Greetings.
I try to train detector using next code
import os
os.chdir("/content/gdrive/My Drive/python_projects/kuzushiji reconginition/")
from imageai.Detection.Custom import DetectionModelTrainer
objects_to_detect = ['U+306F', 'U+304C']
trainer = DetectionModelTrainer()
trainer.setModelTypeAsYOLOv3()
trainer.setDataDirectory(data_directory="detection_input_2/")
trainer.setTrainConfig(object_names_array=objects_to_detect, batch_size=4, num_experiments=10)
trainer.trainModel()
I get the following error during 1st epoch:
Generating anchor boxes for training images and annotation...
Average IOU for 9 anchors: 0.86
Anchor Boxes generated.
Detection configuration saved in  detection_input_2/json/detection_config.json
Training on: 	['U+304C', 'U+306F']
Training with Batch Size:  4
Number of Experiments:  10
Pre-trained Model not provided. Transfer learning not in use.
Training will start with 3 warmup experiments
/usr/local/lib/python3.6/dist-packages/keras/callbacks.py:1335: UserWarning: epsilon argument is deprecated and will be removed, use min_delta instead.
warnings.warn('epsilon argument is deprecated and '
Epoch 1/13
Cannot find  detection_input_2\validation/images/200003076_00043_2.jpg
Cannot find Cannot find Cannot find Cannot find   detection_input_2\train/images/umgy005-001.jpgdetection_input_2\validation/images/200021851_00022_2.jpg
Cannot find   detection_input_2\validation/images/200003076_00154_1.jpgdetection_input_2\train/images/100249371_00007_2.jpg
Cannot find Cannot find    detection_input_2\validation/images/200014740-00065_2.jpg
detection_input_2\train/images/hnsd011-002.jpg
detection_input_2\train/images/umgy001-007.jpg
Cannot find Cannot find  Cannot find Cannot find  detection_input_2\validation/images/200003076_00134_1.jpg detection_input_2\train/images/200021660-00049_2.jpg
detection_input_2\train/images/hnsd010-015.jpgdetection_input_2\validation/images/hnsd008-026.jpg
Cannot find Cannot find   detection_input_2\validation/images/hnsd005-013.jpg
detection_input_2\train/images/200021712-00075_2.jpg
Cannot find  detection_input_2\train/images/brsk005-021.jpgCannot find  detection_input_2\validation/images/200005598_00033_1.jpg
The problem seems to be in \ instead of / because
print(os.path.exists("detection_input_2\validation/images/200003076_00154_1.jpg"))
print(os.path.exists("detection_input_2/validation/images/200003076_00154_1.jpg"))
False
True
How to fix such problem? I've tried using data_directory="detection_input_2/" and data_directory="detection_input_2". Encountered such problem in google colab and windows 10.

I can't try right now. But it looks like an issue with using / and \ at the same time. As far as I can see, the problem is con custom/init.py
Look at the following lines:
self.__train_images_folder = os.path.join(data_directory, "train/images/")
        self.__train_annotations_folder = os.path.join(data_directory, "train/annotations/")
        self.__validation_images_folder = os.path.join(data_directory, "validation/images/")
        self.__validation_annotations_folder = os.path.join(data_directory, "validation/annotations/")

Slashes are hard coded! They must be changed to is.path.join operations, as it is done later in the code.
I'll write a or to fix it, but would be nice you to double check it by just editing the source code of your installation

Seems to be problem also in create_training_instances
I've removed hardcoded slashes but train_ints returned from create_training_instances still have wrong paths:
'filename': 'detection_input_2\train/images/100241706_00005_1.jpg', 'width': 200, 'height': 200}

Your fix is ok, parse_voc_annotation loaded labels from cache which I forgot to clear.
Btw paths in parse_voc_annotation are constructed this way: img_dir + elem.text, ann_dir + ann.
So the one should add / in the end of folder paths or use os.path.join there too.
Thanks for your assistance.

hi @AlekseiPol
Would be great to hear your thoughts on #336 which should solve this issue
thanks

shouldn't this be closed? @AlekseiPol ?

Since the path issue has been fixed in #336 and released in the latest version v2.1.5 , I will be closing this issue.

I don't think it is fixed still facing the same error

same error even with upgraded imageai


Support for IIO RGBC "intensity" based sensors

My laptop uses an apds9960 based sensor that doesn't report a single processed illuminance value, but uses RGBC. An illuminance value has to be manually calculated from the values.

What:		/sys/bus/iio/devices/device[n]/in_intensity_clear[_input|_raw]
What:		/sys/bus/iio/devices/device[n]/in_intensity_red[_input|_raw]
What:		/sys/bus/iio/devices/device[n]/in_intensity_green[_input|_raw](
What:		/sys/bus/iio/devices/device[n]/in_intensity_blue[_input|_raw]
KernelVersion:	3.6.0
Contact<EMAIL_ADDRESS>Description:
This property is supported by sensors that have a RGBC and if expressed in SI units, should include _input. If this value is not in SI units (irradiance, uW/mm^2), then it should include _raw.

There's an easy formula that produces wrong results but is a good start:
(-0.32466F * color_data.r) + (1.57837F * color_data.g) + (-0.73191F * color_data.b)

There's a more complex formula but we don't know the constants for apds9960 sadly:
https://github.com/adafruit/Adafruit_CircuitPython_TCS34725/blob/master/adafruit_tcs34725.py#L282-L332

Very interesting, thanks for letting me know! I will get back to you once I implement something, I'm still considering what is the best approach moving forward, light sensors are too imprecise (at least on my laptop) to provide a completely pleasant auto-adjusting brightness experience, so I'm considering alternative algorithms, maybe base the decision on time of the day and only take illuminance as an additional factor... 🤔
If you have time, could you try to test if your sensor is able to distinguish complete darkness from dim light? Especially if the light is not shining directly at your laptop sensor or to your face (thus reflecting directly to your laptop sensor), but e.g. the light is on your right or left hand side.

I think it should be quite reliable! It measures ambient light levels as opposed to reflected light. The sensor in my device (Surface Laptop 3) is not only used for brightness, but also for adaptive color profiles on Windows. (I think that's why they chose a RGBC sensor. It also does proximity and gesture detection, I think they use that for the "Windows Hello" login) The iio sysfs entries have a few options for setting the sensitivity and scale of the sensor.
I think you might need to apply a kalman filter over the sensor data to smooth out the values, and then map the values to a custom curve. This whitepaper intended for hardware manufacturers might be interesting because it provides a few example curves and a reference table of what the lux values are at various settings (indoors, etc.).
I'm primarily interested in ambient light adjustments for potential battery savings, not the screen content sensing (wlsunset takes care of day vs night changes by adjusting the color profile). Was going to write my own daemon but then I found wluma :)

Thank you, this is very interesting info!
I honestly think that when done right, screen content sensing enhances the experience so much that it is then impossible to live without once it you try it out, especially with the fast reaction time and low CPU usage that I managed to achieve so far.
Unfortunately I don't think my current algorithm is good enough yet, so I want to try to win you over, and with your additional feedback and ideas to perfect the algorithm 😜
Implementing the approximation formula for your sensor should be easy enough to get you going. I'm only not sure if the formula applies to both _input and _raw or only to one of them? 🤔 And which of these values does your specific sensor provide?
By the way if you feel like sending a PR, by all means, please do 🙂

Implemented in main, untested but should work 😅 Thanks for all the hints.


[SwiftSyntax] Remove another link dependency from swiftAST to clangAST when building the parser lib

Remove another link dependency from swiftAST to clangAST when building the parser lib.

@swift-ci Please smoke test

@ahoppen does this really guarantee that the dependency is cleaved?  That is, is LLVM guaranteed to DCE the rest of the method after the early return?  Or would it be safer to guard the rest of the code within an else clause?

That’s the pattern we’ve been using before as well and it always worked in a sense that it removed any linker errors about clangAST missing. If you search for SWIFT_BUILD_ONLY_SYNTAXPARSERLIB in the codebase you’ll see a few early returns.

For more context, this relies in linker's dead-stripping to avoiding building and linking libraries we don't need.


The 'Program' model is sometimes referred to as 'Department'

In accounts/models.py > Student model:
department = models.ForeignKey(Program, on_delete=models.CASCADE, null=True)

In the Students page :

In the Add Student page :

I do not know if it is intentional but it is confusing for users and developers.
If possible, I want to create a PR to fix it, should Program become Department or vice-versa?

Hello,
I believe that the term "Program" is more specific and indicates the area of study or major, such as "Computer Science," "Business Administration," etc. On the other hand, the term "Department" refers to the academic department or discipline within the institution, such as the "Department of Chemistry" or the "Department of History." It's a broader category that may encompass multiple programs.
In conclusion, I suggest that we use the term "Program" consistently throughout the app.

So you can contribute by changing the term "Department" to "Program" throughout the app.
Thanks :)

Great, I'll start working on it


Inline images not shown

RainLoop version, browser, OS:
6.0.4, under Nextcloud, Linux, any browser
Expected behavior and actual behavior:
In certain emails, inline images are not shown.
Steps to reproduce the problem:
N/A
Logs or screenshots:
I reported this issue to Roundcube yesterday, and they fixed it rather quickly. It's Microsoft generating too large Content-Id headers not fitting in a single line, hence not being correctly parsed, hence content not being shown.
Their commit:
https://github.com/roundcube/roundcubemail/commit/c1c534d67c70f172199c45cb3be6fec880d79982
Attached proof.

Sad how poor the support is here. Anyway...
File app/rainloop/v/1.13.0/app/libraries/MailSo/Imap/BodyStructure.php, line 879, inside of
return new self(
$sContentID,

must be
trim($sContentID),

Regards.


bug:rc4, ng new command ignores --ng4 flag

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.
$ ng --version
    _                      _                 ____ _     ___
   / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
  / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
 / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
/_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
               |___/
@angular/cli: 1.0.0-rc.4
node: 6.9.4
os: linux x64

Repro steps.
run: ng new rc4ng4example --ng4=true
also tried --ng and -ng without the =true
The log given by the failure.
package.json contains:

    "@angular/common": "^2.4.0",
    "@angular/compiler": "^2.4.0",
    "@angular/core": "^2.4.0",
    "@angular/forms": "^2.4.0",
    "@angular/http": "^2.4.0",
    "@angular/platform-browser": "^2.4.0",
    "@angular/platform-browser-dynamic": "^2.4.0",
    "@angular/router": "^3.4.0",

Desired functionality.
package.json should contain
    "@angular/common": ">=4.0.0-beta <5.0.0",
    "@angular/compiler": ">=4.0.0-beta <5.0.0",
    "@angular/core": ">=4.0.0-beta <5.0.0",
    "@angular/forms": ">=4.0.0-beta <5.0.0",
    "@angular/http": ">=4.0.0-beta <5.0.0",
    "@angular/platform-browser": ">=4.0.0-beta <5.0.0",
    "@angular/platform-browser-dynamic": ">=4.0.0-beta <5.0.0",
    "@angular/router": ">=4.0.0-beta <5.0.0",

Mention any other details that might be useful.
n/a

This is also happening in RC2

Have you tried ng new --ng4 or ng new --ng4 true? Just worked for me.

@yarrgh it was a local issue, can be ignored.


Matrix data structure has dropdown, importing data doesn't set the right value to the dropdown

I have created a dropdown as a field in Matrix and import doesn't assign the right value from json data to the dropdown.
I see similar issue for a dropdown that is not a part of Matrix field.

I see the same issue, which I’ve just mentioned in another unrelated (https://github.com/engram-design/FeedMe/issues/64#issuecomment-228288644) issue.

I managed to resolve this issue by making sure the imported data for the dropdown is the field label and not the value. I hope this helps.


Make filter more powerful by matching partial words [Nice-to-have].

@ChuaPingChan like identifying substrings?

Yeah, just a small change but it makes MultiTasky much more user-friendlier.


feature request: automatically migrate struct update syntax into pattern matching

Relates to: https://github.com/elixir-lang/elixir/issues/13974
It is planned to deprecate the struct update syntax %MyStruct{x | ...} in a future Elixir release. I asked José if this is a feature they're planning to integrate into mix format --migrate, but it is not likely at the moment.
Since styler also added an automatic rewrite for unless to !if, this would be a nice feature, although it's probably it bit more complicated.

thanks for bringing this up @SteffenDE!
styler definitely does more than a few deprecation rewrites, so i'm happy to add another. i wouldn't be surprised if formatter itself starts doing more of them though, since they did add the unless => if! rewrite on their end too.
(the following is me thinking out loud, pardon me)
for this new deprecation, jose gives this:
# bad
for entry <- conf.entries do
  %UploadEntry{entry | preflighted?: entry.preflighted? || entry.ref in refs}
end

# good
for %UploadEntry{} = entry <- conf.entries do
  %{entry | preflighted?: entry.preflighted? || entry.ref in refs}
end

making this change with styler is trivial, both to detect and to fix:
-  %UploadEntry{entry | preflighted?: entry.preflighted? || entry.ref in refs}
+  %{entry | preflighted?: entry.preflighted? || entry.ref in refs}

whereas this one i'd have to spend time experimenting with to see how do-able it is:
-for entry <- conf.entries do
+for %UploadEntry{} = entry <- conf.entries do

as it'd require backtracking in the ast upon encountering the %Struct{var | ..} syntax to find where var was defined. i don't think there's anywhere equivalent to that in styler's existing behaviours...
anyways, the second change isn't necessary as part of removing the deprecated syntax. but it sure would be nice to do for folks who are concerned about the type warnings that structs provide

Unfortunately I would say that the second part is essential. So if we can't do it automatically, it may be best to ask users to do it. Perhaps what Styler could do is to remove the update syntax IF the variable has been bound to the same struct before. This way, Styler can remove the redundant information, and users are only required to refactor it when it is not redundant?


[Feature Request]: I want to add pagination feature in contributors page.

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description

I want to add pagination feature in contributors page.

Use Case

Without pagination option we cannot see all the contributors.

Benefits

Pagination will help users to see all the amazing contributors of this project.

Add ScreenShots
https://github.com/user-attachments/assets/f36ac27e-1426-45ef-9300-27fd54dd5f26
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSOC'24 contributor
[X] I have starred the repository

@apu52 @itsekta please assign this issue to me.


[flash_ctrl,dv] Fix constraint error in nightly regression

Description
The pass rate for flash_ctrl on the nightly regressions is below 90%. The main error is the following:
  Error-[CNST-CIF] Constraints inconsistency failure
  ../src/lowrisc_dv_flash_ctrl_env_0.1/seq_lib/flash_ctrl_base_vseq.sv, 154
    Constraints are inconsistent and cannot be solved.
    Please check the inconsistent constraints being printed above and rewrite
    them.

This should be fixed to check it's not hiding other errors.
P1 as if it is hiding other errors there may be additional flash_ctrl DV work to do.

estimate 4

Estimate range 2 - 4

@GregAC This error doesn't show in flash_ctrl nightly anymore

Latest pass rate was 98% with the constraint error gone.
@jdonjdon could you have a look at a latest nightly to check there's no failures of concern? If there aren't this issue can be closed.


TP has weird values when set to zero

When the TP is set to zero, and the TP Pips/Price hotkey is pressed, it returns some weird values
https://www.youtube.com/watch?v=jJDZGW3wyHI

USDCAD133680729105445027.txt
Sample settings file if needed

Should be fixed in 3.10.


Update the names of the find methods for collection

The docs said find and findBy but the actual names are findOne and findOneBy.

Thanks! And sorry for the delay. Will update docs site shortly.

updated http://ember-cli-page-object.js.org/docs/v1.17.x/api/collection


[REVIEW] Krish Gupta

Please ensure that you don't have any personal details in your Portfolio that you don't want to share publicly.
Portfolio link: @krishdevdb
You can also join the Discord community here
Feel free to check out other cool repositories of the EddieHub Community here

Nice profile @krishdevdb
some thoughts

remove the "Opensource Projects" Section -> duplicate with pinned repos
think the stats are overall really big maybe you could align them with less space

@schmelto I respect your feedback. I didn't knew you were so fast, I thought that I will make a new profile completely from scratch until someone sees this. Today I deleted my old profile to make changes thus, kinda your feedback went unused sorry 😢 But first I thought to work upon github's new features, rebrand my self (use my original image [Inspired by Eddie's livestream which I had to watch 3 times to understand the original image thing])... So I am closing this as that might take some time thanks! I really appreciate your feedback.

yes feel free to reopen when your profile is ready

yes feel free to reopen when your profile is ready

Yep sure It might take some time, but late is better than never ❤


Searching on Genetics gives a 404

Describe the bug
Searching for a gene, variant, or study on Open Targets Genetics and pressing return leads to a 404 page.
Observed behaviour
If I search for a gene, variant, or study and press return, I get a 404 page. This does not happen if I click on the suggested entities from the search bar.
Expected behaviour
Pressing return should bring up a page with the list of suggested entities.
To Reproduce
Steps to reproduce the behaviour:

Go to 'genetics.opentargets.org'
Search for an entity, and press return
See error

Additional context
Issue submitted by external user.

Not really, this bug is essentially that there was no landing search page for genetics, and we used to not show "search for " option in genetics, it was only for platform. But i think in changes that condition got removed and now it shows that option which was never there.

This issue can't be resolved in its current state. It will be resolved in due time with the release of the new genetics product.


Can you give some connection pool cases of MySQL, Redis and other services

@leeyisoft Hi!
I created this Erlang application because I believe it is the best approach for providing a connection pool in a CloudI service.  However, I haven't needed to add it to any CloudI services yet because I haven't yet had any performance problems that would require it.  If a CloudI service isn't using any process pool, the service can always have its number of processes increased to handle more load and that can help keep the CloudI service logic simpler.
So, using a process pool inside a CloudI service could be used for situations with read-only connections/operations and other decisions based on the content of a request.  However, it still would likely be beneficial to handle that with CloudI service name patterns being different for different routing to the separate CloudI service processes (to split the throughput), so it may be hard to justify needing any process pool inside a CloudI service (i.e., the CloudI service only would need configuration arguments for the variation in its initialization).


How to run ....

Hello
Thanks for sharing your program,
I want to run  "stock_pred_main.py" but  It displays  the following error:
 can't find '__main__' module

what should I do?
Regards
ARZ

how are you trying to run it?

Can you please write the complete method to run the program?
Thanks


Fine tune yc2_100m_coot_vidclip_mart for smaller videos

I was finetuning the provided model with my out dataset. My dataset is really small, so I want to use the pretrained weight. However I got size mismatch of wordembedding.
Do you know how I can solve this error?
I run
python train_caption.py -c config/caption/paper2020/mydata_coot_vidclip_mart.yaml

As it says in line 5 of your screenshot you seem to have created a vocabulary with 173 words. Now you are loading the model which has an embedding with 992 words in the vocabulary which does not work.
You could try not loading the embedding and initialize them from scratch or from GloVe weights. Or if all the 173 words appear in the original 992 words vocabulary you could map the embeddings from 992 to 173.

@gingsi Thank you for your quick response.
I think the better option now is to initialize from Glove weights since all the words doesn't appears in the original vocabulary.
So how do I initialize from glove? can you help me with what to change?

To build the new vocab and glove embeddings see file mart_build_vocab.py.
Then you need to intercept model loading in trainer_base.py function hook_post_init, there you delete the embedding from the state_dict so it does not crash.
Instead set the glove embeddings as in file mart/model.py function create_mart_model, see the line with model.embeddings.set_pretrained_embedding.
Another thing to note is that if you change the vocabulary the pretrained model will not produce output that makes sense anymore, but it could be worth a shot to then finetune it.

@gingsi Thank you very much for your help. It work good with the glove embeddings. for anyone who wants to do the same, this is the change in trainer_base.py
if self.load_model:
    # load model from file. this would start training from epoch 0, but is usually only used for validation.
    self.logger.info(f"Loading model from checkpoint file {self.load_model}")
    model_state = th.load(str(self.load_model))
    ignore_weights = ["decoder.decoder.weight", "decoder.bias", "loss_func.one_hot", "embeddings.word_embeddings.weight"]

    model_state['model']["embeddings.word_embeddings.weight"] = th.from_numpy(th.load(
    Path("cache_caption") / "dataset_vocab_glove.pt")).float()
    self.model_mgr.set_model_state(model_state)

well I realize that with the above modification, there is still some error during retrieval so the better one is to put a condition like this:
if self.load_model:
  # load model from file. this would start training from epoch 0, but is usually only used for validation.
  self.logger.info(f"Loading model from checkpoint file {self.load_model}")
  model_state = th.load(str(self.load_model))
  if self.cfg.config_type == "mart":
    model_state['model']["embeddings.word_embeddings.weight"] = th.from_numpy(th.load(
    Path("cache_caption") / "crime_vocab_glove.pt")).float()
  self.model_mgr.set_model_state(model_state)


Session Middleware along with Cookie Middleware

Hi, I am planning to share authentication cookie between my aspnetcore and my 4.6.1 framework application using documentation from aspnetcore docs. I am using Redis as TicketStore for CookieMiddleware to cache the Authentication ticket
Is it also possible to share session between these two apps?
If yes, how do I order the cookie middleware with session middleware in the pipeline?
Also,  how do I manage the two cookies (one from CookieMiddleware and one from Session Middleware)??
I am very confused....please advise.

I think this is a duplicate for issue #122

So based on your reference above, is it still not possible to share session data between two apps in IIS??

AFAIK it's not possible, @Tratcher any idea?

No, we don't provide any way to interop session data or cookies.


Wallet Connection problem

What version of Wallet are you using?
Zip file you provided
What is happening?
" Cannot read properties of undefined (reading 'connect') " i get this error sometimes when refreshed the https://fuels-wallet.vercel.app/docs/how-to-use/ page and trying to connect my wallet.
steps to reproduce
Open https://fuels-wallet.vercel.app/docs/how-to-use/ , click Connect
How it should behave?
Could Connect and Disconnect without changing google chrome extension allowances of Fuel wallet, or refresh page.
What os are you seeing the problem on?
Mac/Apple Desktop
What browser?
Chrome
What is your browser version?
Latest chrome

Do you have the wallet extension install?

Yes of course, it sometimes gives error when trying to connect, and
sometimes not.
5 Ara 2022 Pzt 22:07 tarihinde Luiz Estácio | stacio.eth <
@.***> şunu yazdı:

Do you have the wallet extension install?
—
Reply to this email directly, view it on GitHub
https://github.com/FuelLabs/fuels-wallet/issues/331#issuecomment-1337990210,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZROWYWF5B2XZO5RU7KUZD3WLY4NLANCNFSM6AAAAAASTFUFLU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks for the reply. This will be fixed by issue #308.

Awesome, thanks!
6 Ara 2022 Sal 00:34 tarihinde Luiz Estácio | stacio.eth <
@.***> şunu yazdı:

Closed #331 https://github.com/FuelLabs/fuels-wallet/issues/331 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/FuelLabs/fuels-wallet/issues/331#event-7959231804,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZROWYT2VJX7ITY5DH3WEMTWLZNVLANCNFSM6AAAAAASTFUFLU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Shadowmapping show bias artifacts on mobile

Check out this scene on desktop:

This is how it appears on mobile (iPhone 6):

This scene has a shadow-casting spotlight.

We had the same issue with shadowmapping artifacts on iOS, with the latest update issue seems fixed.

Fixed in 2c1bb5ae20f0e41e1d3a4a53fddc923af1f366e3


style

modify css to more closely match the style of perplexity
before:

after:

Thank you!
Closes https://github.com/anjor/lmptfy/issues/2


Update Makefile

Wouldn't this break compatibility on non-Debian systems?

I guess yes.

@aunali1 I already update the code. So the software will install on Debian-based system.

Do not update first. I want to double check. Sorry


ockam node show - OCK500   A node named default already exists

Observed behavior
I am following this doc link to https://docs.ockam.io/guides/use-cases/add-end-to-end-encryption-to-any-client-and-server-application-with-no-code-change
but encountered this error:
❯ ockam node show
OCK500

  × A node named default already exists
  help: Please report this issue, with a copy of your logs, to https://github.com/build-trust/ockam/issues

  Version 0.90.0, hash: 8a77aa9dec024b05d9da00f4e75acd188ff6e785

(base)

Steps to reproduce

ockam node create server_sidecar
ockam node show

Expected behavior
should be listing all the nodes
Ockam Version
Version 0.90.0, hash: 8a77aa9dec024b05d9da00f4e75acd188ff6e785

Thank you for filing this.

For anyone investigating, the code for the node show command is here:
https://github.com/build-trust/ockam/blob/develop/implementations/rust/ockam/ockam_command/src/node/show.rs

When I tried to stop node, it throw error:
❯ ockam node stop default
OCK500

  × A node named default already exists
  help: Please report this issue, with a copy of your logs, to https://github.com/build-trust/ockam/issues

  Version 0.90.0, hash: 8a77aa9dec024b05d9da00f4e75acd188ff6e785

(base)

After stop the nodes, (the Default can't stop by using ockam, so stop it use kill -9) and run ockam reset.
then running the : ockam node show working fine.

I think is the Default node causing trouble.

Hi @mrinalwadhwa and @9to1url ,
I tried it, able to reproduce the issue.
May I start working on this issue?

@bharattech that would be awesome. Thank you. Let us know if you have any questions

I found another issue might related to this issue, so put here first:
$ ockam node list
       ┌───────────────────┐
       │       Nodes       │
       └───────────────────┘

     │ Node relay (default) UP
     │ Process id 15904

$ ockam node stop relay
OCK500

  × No such file or directory (os error 2)

  Version 0.90.0, hash: 8a77aa9dec024b05d9da00f4e75acd188ff6e785

Actually the node been stopped but the error msg misleading.

Checking up on this issue, @bharattech are you still taking it up?

Hi @metaclips
I appreciate your inquiry, but I currently do not have the capacity to work on this issue.
Thanks

@bharattech that's totally okay. Thank you for time you spent thinking about the issue.

Thank you for your understanding. I appreciate your patience


alpine.gliderlabs.com DNS SERVFAIL

Reproduce:
docker run gliderlabs/alpine apk update

Result:
fetch http://alpine.gliderlabs.com/alpine/v3.9/main/x86_64/APKINDEX.tar.gz
ERROR: http://alpine.gliderlabs.com/alpine/v3.9/main: temporary error (try again later)
WARNING: Ignoring APKINDEX.4b0f3aca.tar.gz: No such file or directory
fetch http://alpine.gliderlabs.com/alpine/v3.9/community/x86_64/APKINDEX.tar.gz
ERROR: http://alpine.gliderlabs.com/alpine/v3.9/community: temporary error (try again later)
WARNING: Ignoring APKINDEX.e20d04a5.tar.gz: No such file or directory
2 errors; 11 distinct packages available

nslookup result (DNS Resolver: <IP_ADDRESS> / <IP_ADDRESS>):
nslookup alpine.gliderlabs.com
;; Got SERVFAIL reply from <IP_ADDRESS>, trying next server
Server:		<IP_ADDRESS>
Address:	<IP_ADDRESS>#53

** server can't find alpine.gliderlabs.com: SERVFAIL

I had the same problem and I solve it by switching the host from gliderlabs to one of the alpine linux mirrors
I used https://dl-cdn.alpinelinux.org/alpine/
I hope that helps you

I dont understand.

I had the same problem and I solve it by switching the host from gliderlabs to one of the alpine linux mirrors
I used https://dl-cdn.alpinelinux.org/alpine/
I hope that helps you

How do you switch the gliderlabs ? do you use another image ?

Hi @toandph
Yes, you can use one from https://hub.docker.com/_/alpine
and here is a  github https://github.com/alpinelinux/docker-alpine


Faster search

Typing in the search box is a little painful because we're not throttling events and updates to the Flux store... this will slow down the update cycle a bit without impacting the user experience too much.

:+1:


Support PATCH in addition to PUT on all entities

Bug Report
Version
latest as per dockerhub; most likely `v0.63
Platform
docker
Description
Suggest using PATCH instead of PUT in all the apis where we perform an update operation. It is inconvenient to pass in all the data, just to update a couple of fields. This has side-effects & can cause issues elsewhere
Example - I created an endpoint & later wished to update the URL. Using PUT caused all the other data fields like events, etc to be set to NULL.

I agree, we've been deferring doing this for a while, I'll see if we can get to it soon.

@svix-daniel, is this one done? (other than libs)

I'm pretty sure it's done (other than the libs which are tracked in #608 so closing this.


Tests

Write a suit of tests, probably using FactCheck

[ ] Write tests
[x] Coveralls

How many and which tests are still missing?

Fixed by latest commits


Dependency order not honored by tooling API

I think I'm having a problem with this issue https://issues.gradle.org/browse/GRADLE-2294 which I did not find on github.
My problem is that I have JUnit 4 tests that use JMockit. Everything works fine when run from gradle, but if I try to run in Intellij all of the Mocked objects are null implying that JMockit was not initialized which implies that JUnit is getting loaded before JMockit despite the correct order being present in the testCompile dependencies. I can work around it by using RunWith(JMockit.class) but this prevents me from combining JMockit with JUnitParams or any other JUnit runner.
As you can see from here https://youtrack.jetbrains.com/issue/IDEA-119709 JetBrains claims this is the responsibility of the tooling API

I'm using gradle 3.2.1
Here are my test deps:
    testCompile 'commons-io:commons-io:2.5'
    testCompile 'pl.pragmatists:JUnitParams:1.0.5'
    testCompile 'org.hamcrest:hamcrest-all:1.3'
    testCompile 'org.jmockit:jmockit:1.30'
    testCompile 'org.assertj:assertj-core:3.5.2'
    testCompile 'org.yaml:snakeyaml:1.17'
    testCompile 'com.fasterxml.jackson.core:jackson-core:2.8.3'
    testCompile 'com.fasterxml.jackson.core:jackson-databind:2.8.3'
    testCompile 'com.fasterxml.jackson.core:jackson-annotations:2.8.3'
    testCompile 'com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.8.3'
    testCompile 'org.slf4j:slf4j-api:1.7.21'
    testCompile 'uk.org.lidalia:slf4j-test:1.1.0'
    testCompile 'com.jcabi:jcabi-log:0.17.2'
    testCompile 'junit:junit:4.12'
    testCompile 'org.jooq:jool:0.9.12'
    testCompile 'org.languagetool:language-all:3.4'
    testCompile 'com.optimaize.languagedetector:language-detector:0.5'
    testCompile 'org.antlr:ST4:4.0.8'


Running test error with "SIG 11 - SIGSEGV: segfault"

Hi, I`m running the test scripts with "python3 sofa_env/scenes/controllable_object_example/controllable_env.py". I can see a red ball and blue soft board. When the red ball slid off the board, the process crashed whit the SIG 11.  Here is the whole log:
---------------------------------------
Checking SOFA_ROOT and SOFAPYTHON3_ROOT
Using environment variable SOFA_ROOT: /home/yangyang/sofa/build/install
---------------------------------------
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Topology.Container.Constant.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.LinearSolver.Iterative.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Topology.Container.Grid.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Constraint.Lagrangian.Solver.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.SolidMechanics.FEM.Elastic.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Mapping.NonLinear.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/plugins/ArticulatedSystemPlugin/lib/libArticulatedSystemPlugin.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Collision.Detection.Intersection.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.LinearSolver.Direct.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Mass.so
[DEPRECATED] [SofaBoundaryCondition] SofaBoundaryCondition is deprecated. It will be removed at v23.06. You may use Sofa.Component.Constraint.Projective and Sofa.Component.MechanicalLoad instead.
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Constraint.Projective.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.MechanicalLoad.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/collections/SofaBoundaryCondition/lib/libSofaBoundaryCondition.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Collision.Detection.Algorithm.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Setting.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.SceneUtility.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.IO.Mesh.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Collision.Response.Contact.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.SolidMechanics.Spring.so
[DEPRECATED] [SofaEngine] SofaEngine is deprecated. It will be removed at v23.06. Use Sofa.Component.Engine.Select instead.
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Engine.Select.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/collections/SofaEngine/lib/libSofaEngine.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.ODESolver.Backward.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.AnimationLoop.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Constraint.Lagrangian.Correction.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Visual.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Constraint.Lagrangian.Model.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Collision.Geometry.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.ODESolver.Forward.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.GL.Component.Rendering3D.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Topology.Mapping.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.GL.Component.Shader.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Mapping.Linear.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.StateContainer.so
[INFO]    [PluginManager] Loaded plugin: /home/yangyang/sofa/build/install/lib/libSofa.Component.Topology.Container.Dynamic.so
[WARNING] [MechanicalObject(unnamed)] Could not read value for data field showColor: 255 0 255
[WARNING] [BoxROI(BoxROI)] No rest position yet defined. Box might not work properly.
This may be caused by an early call of init() on the box before
the mesh or the MechanicalObject of the node was initialized too
[WARNING] [MeshOBJLoader(unnamed)] Could not read value for data field handleSeams: None
[WARNING] [InteractiveCamera(camera)] Too many missing parameters ; taking default ...
[WARNING] [CGLinearSolver(CGLinearSolver)] denominator threshold reached at first iteration of CG
Check the 'threshold' data field, you might decrease it

########## SIG 11 - SIGSEGV: segfault ##########
  sofa::helper::BackTrace::sig(int)
  PyErr_Fetch
  on_exit+0
  __libc_start_main
Segmentation fault (core dumped)

Is the "SIG 11 - SIGSEGV : segfault" normal? If not, what`s wrong with this process?
looking forward to your replay, thanks

Hi @Yangon0620 ,
yes that was the normal behavior.
The SIG 11 happened after the env was done.
I added a fix to the baseclass that now correctly unloads the simulation, when closing the env.
https://github.com/ScheiklP/sofa_env/commit/2f0020d18f135118adfee179670793111e2a9e21
Thanks for noticing! :)
Cheers,
Paul


Requiring version string have static lifetime makes for awkward code

In trying to get the version string to automatically populate based on the version I specify in my Cargo.toml using something like:
...
    let version = format!("{}.{}.{}{}",
                          env!("CARGO_PKG_VERSION_MAJOR"),
                          env!("CARGO_PKG_VERSION_MINOR"),
                          env!("CARGO_PKG_VERSION_PATCH"),
                          option_env!("CARGO_PKG_VERSION_PRE").unwrap_or(""));

    let matches = App::new("signing-participants")
        .version(&version[..])
...

However, this fails with:
% cargo build
   Compiling signing-participants v0.0.1 (file:///Users/jacobhelwig/btsync/projects/signing-participants)
src/main.rs:27:19: 27:26 error: `version` does not live long enough
src/main.rs:27         .version(&version[..])
                                 ^~~~~~~
note: reference must be valid for the static lifetime...
src/main.rs:24:78: 93:2 note: ...but borrowed value is only valid for the block suffix following statement 1 at 24:77
src/main.rs:24                           option_env!("CARGO_PKG_VERSION_PRE").unwrap_or(""));
src/main.rs:25
src/main.rs:26     let matches = App::new("signing-participants")
src/main.rs:27         .version(&version[..])
src/main.rs:28         .author("Jacob Helwig<EMAIL_ADDRESS>src/main.rs:29         .about("Generate a list for key-signing parties")
               ...
error: aborting due to previous error
Could not compile `signing-participants`.

To learn more, run the command again with --verbose.

I can get it to work if I don't care about the prerelease marker, and switch to concat! (haven't been able to get concat! to play nicely with option_env!):

    let version = concat!(env!("CARGO_PKG_VERSION_MAJOR"), ".",
                          env!("CARGO_PKG_VERSION_MINOR"), ".",
                          env!("CARGO_PKG_VERSION_PATCH"));

    let matches = App::new("signing-participants")
        .version(&version)

% cargo run -- --version
   Compiling signing-participants v0.0.1 (file:///Users/jacobhelwig/btsync/projects/signing-participants)
     Running `target/debug/signing-participants --version`
signing-participants 0.0.1

Sticking with format! so I can use option_env! is really not nice (as it involves unsafe code provided by dougxxx in the #rust IRC channel):
#![feature(collections)]
use std::mem::forget;
use std::mem::transmute;

unsafe fn as_static(v:&str) -> &'static str {
  let tmp = String::from_str(v);
  let boxed = Box::new(tmp);
  let rtn: *const str = &**boxed as *const str;
  forget(boxed);
  return transmute(rtn);
}

fn awkward_function(v:&'static str) {
  println!("{}", v);
}

fn main() {
  let foo = String::from_str("Hello World");
  unsafe { awkward_function(as_static(&*foo)); }
}

Is there a way the elements of the App struct could be changed to not require static lifetimes on its elements?  I haven't looked at what the implications of this would be with the rest of the code, but allowing the format! trick I initially tried for defining the version seems like reasonable usage of the library.

I'll take a look at this tonight and report back. Thanks for the detailed write up!

Thanks for taking a look! This library has been working really well for me so far. :)

I got it working in a backwards compat way allowing lifetimes other than 'static. Let me know if that fixed what you needed. Thanks again :+1:

Yup, works like a charm.  Thank you!


added copy block to prevent compile error

This fixes the compile error on iOS.

We can't do this -- this leads us down a rabbit hole of memory management that the SDK doesn't otherwise take care of. Simply specifying the ARC flag as mentioned in the ReadMe will fix this, though.

Additionally, while this does fix compilation, since the rest of the file isn't ARC-ified, or made memory safe, you'll see random crashes on callbacks and other stuff when C Strings get deallocated before we expect them to.

Nevermind, I see it.

On Jun 23, 2015, at 2:16 PM, Graham Mueller<EMAIL_ADDRESS>wrote:
We can't do this -- this leads us down a rabbit hole of memory management that the SDK doesn't otherwise take care of. Simply specifying the ARC flag as mentioned in the ReadMe will fix this, though.
—
Reply to this email directly or view it on GitHub https://github.com/BranchMetrics/Branch-Unity-SDK/pull/1#issuecomment-114643841.


New package: LinearInterpolators v0.1.5

Registering package: LinearInterpolators
Repository: https://github.com/emmt/LinearInterpolators.jl
Created by: @emmt
Version: v0.1.5
Commit: 7b464d563a23fb0e774e13e2c708e9aa260ff3d1
Git reference: v0.1

[noblock]
This package is used by others so I would like to not change its name to not bother them.


Thanks for creating this and four proposals.

@dobomode  It is such a nice to see this happen. Outstanding!
I propose to add the following:

Ability of download lecture notes, transcripts of the video in the specified languages and
Ability to download the courses in batch mode with a list of courses
Ability to read the login info and CAUTH from a config file (similar to coursera-dl.conf)
Ability to specify the user's requirements in the config file as above in 3.

Cheers, and stay safe,
/z

Thanks for the suggestions.
At the moment, I don't have any plans to expand the tool with further functionality as this project is intended as a temporary fix while we get the proper fix in coursera-dl.


Support kwargs with from_attributes

Draft PR based on the #223 details but got stuck on the actual usage in the python api side.
Would like some help defining the expected test cases and if the optional args in the macro_rules changes are expected?

As per the issue,

I guess the input validator needs to support a tuple of (object, kwargs) too.

Basically validate_typed_dict on the Input implementation for python should also accept a tuple of (object, kwargs).
Does that make sense?

hi @samuelcolvin , maybe I should've clarified the impl before starting.
I took some time to dig through the code base but still quite confused about the translation from pydantic to pyo3 to rust
So based on my understanding - this is used by pydantic in Model.from_orm(expected_fields, **additional_kwargs)
by adding (object, kwargs) to validate_typed_dict do you mean I should modify the input_abstract and input_python signature to something like
fn validate_typed_dict(
    &'a self,
     strict: bool,
    from_attributes: bool,
    additional_kwargs: Option<(&'a PyAny, Option<&'a PyDict>)>,
) -> ValResult<GenericMapping<'a>> {
    if from_attributes {    //  <-- does from_attributes relate to this additional_kwargs?
            if let Some((object, kwargs)) = additional_kwargs {
                return Ok(GenericMapping::PyGetAttr(object, kwargs));
            }
   ...
}

and if that's correct, how would I get this additional_kwargs from the typed_dict validate function? does the input parameter get casted into this?

Not your fault, I think the problem is me 1) not thinking it through enough before creating the issue 2) not giving a clear description of what I have thought of.
Part of this is an in avoidable result of "thinking by coding" - I often don't know how to do things until I'm half way through doing things.

"from orm" will change a lot in V2, not just being renamed to from_attributes:

if from_attributes=True, passing an object to parse_obj (now called model_validate) it should "just work" - the model is constructed by extracting attributes from the object, instead of extract items from a dict; this should already work
Similarly if from_attributes=True, a submodel could be populated from an object as it would be from a dict
there should be no need for an explicit from_orm method

The way to allow a higher priority dict (aka kwargs) together with an object, is to support parsing (my_object, kwargs) as well as just kwargs.
So the signature of validate_typed_dict doesn't need to change, instead we change the logic at
https://github.com/pydantic/pydantic-core/blob/da0a6c72a497fc78e59a5ab10672389d58f82c1b/src/input/input_python.rs#L345-L346
to something like
            if from_attributes_applicable(self) {
                Ok(self.into())
            } else if let Ok((obj, kwargs)) = self.extract::<(&PyAny, &PyDict)>() {
                if from_attributes_applicable(self) {
                    // return a generic mapping with the object and kwargs
                } else {
                    // note the error here gives a hint about from_attributes
                    Err(ValError::new(ErrorKind::DictAttributesType, self))
                }

Then the logic in python will take care of passing (input_value, from_attributes_kwargs) to the validate instead of input_value, if from_attributes_kwargs is provided.
Hope that makes sense?

thanks for the explanation @samuelcolvin!
that cleared it up for sure, I think I implemented most of it through your guidance but still learning to debug this locally - would the test case added to typed-dict here be an example of how the python api uses this new feature?
so setting from_attributes=True and submitting an input with extra attributes than defined in the fields from SchemaValidator? if so I will have to debug some more why it's not working

Sorry for the slow reply, somehow I missed this.
Yes that looks right.
Let me know when this is ready to review.

Hi @jcsho when do you think you'll be able to finish this? Let me know if you have any questions.

@samuelcolvin sorry also didn't see this notification - just got back from vacation so will try to continue tackling this this weekend.

@samuelcolvin actually I took some time to debug the issue tonight and I found that I might still be confused about the usage. I pushed my current working code to this branch.

in validate_typed_dict I attempted to debug by swapping the if-statements to match the expected behaviour discussed above but the code path never reaches into the if-statement here when I run the sample test case here

what I expected to happen

a, b, c fields are extracted as it currently does, but the extra field d should've been extracted to the kwargs field

what actually happens

a, b, c fields are correctly extracted, but any extra fields are ignored
then I realized maybe it'll always match the current predicate first...

if let Ok(dict) = self.cast_as::<PyDict>() {
                return Ok(dict.into());

so maybe I didn't quite understand how the current input can be parsed?

debugging - wondering if it's possible to hook into the vscode debugger or any step through debugging for the Rust side?

Codecov Report

Merging #306 (5c5bff0) into main (883048a) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   97.13%   97.12%   -0.02%
==========================================
  Files          59       59
  Lines        6981     6989       +8
  Branches       47       47
==========================================
+ Hits         6781     6788       +7
- Misses        200      201       +1

Impacted Files
Coverage Δ

src/validators/dict.rs
95.04% <0.00%> (ø)

src/input/input_python.rs
97.92% <75.00%> (-0.25%)
:arrow_down:

src/validators/union.rs
98.36% <75.00%> (ø)

src/input/return_enums.rs
97.87% <100.00%> (ø)

src/lookup_key.rs
92.38% <100.00%> (+0.15%)
:arrow_up:

src/validators/typed_dict.rs
98.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883048a...5c5bff0. Read the comment docs.

Hi @samuelcolvin, took awhile but finally understood what the expected behaviour was. I added the corresponding test cases to the exiting from_attributes test.
Just need a review on the Rust side macros re-arrangements of the arguements to allow optional final fields as well as any edge cases to test if needed!

bump @samuelcolvin in case you didn't get to see this is ready for review :)

This is awesome, thank you so much @jcsho, I'm sorry I didn't see you had completed this until now - entirely my mistake 🙏.


Documentation updates for the configuration system

The configuration system uses mbed_config.h to export configuration
data, but when this change was made, the documentation was not properly
updated. This commit updates the documentation with the correct
behaviour of the configuration system.

@0xc0170 @screamerbg
@geky: if you can find the bandwith to add the missing pieces in this document (regarding features and the overridable target attributes that are not configuration parameters), it would be great. I can help with the targets part at least.

Can do, I will make this my priority.

Opened a pr over here https://github.com/mbedmicro/mbed/pull/2279, let me know thoughts on the documentation.


Turn off Manage Users

forgot to turn off the "Manage Users" page when i yolo merged when i merged in #698

im gonna go ahead and merge this in.


internal/sync config with clarin

Clarin config
Check and compare with our clarin-dspace.cfg, probably after finishing all features.

We created clarin-dspace.cfg property file


Circle blocks don't expand enough to fit the array block

It may be better to have the get random value from expand to the right to accommodate the entire array block. Although I'm probably the only person who does this anyways.😂

Also if I click on the get random value from block it draw the highlight on the array block:

Better now:


Breaks main menu options added by other mods

Specifically in my case the ones added by Enhanced Battle Test. It adds a couple of main menu options for different battle tests, but these disappear when using the Community Patch. I have only these two mods enabled, ordering doesn't seem to matter.

All of these options are regrouped in the "More Options" option in the main menu.
I'm pretty sure, though, that the community patch does not provide any fixes for custom battles.

Oh you are right they are there, thanks! Although I'm not sure why this would be done, it seems beyond the expected remit of something claiming to be a patch.


v1 bug: the module at gopkg.in/urfave/cli.v1 is broken

my urfave/cli version is
1.22.4
Checklist

[x] Are you running the latest v1 release? The list of releases is here.
[x] Did you check the manual for your release? The v1 manual is here
[x] Did you perform a search about this problem? Here's the Github guide about searching.

Dependency Management

[x] My project is using go modules.
[ ] My project is using vendoring.
[ ] My project is automatically downloading the latest version.
[ ] I am unsure of what my dependency management setup is.

Describe the bug
The bug is described in this StackOverflow issue: https://stackoverflow.com/questions/63013135/what-to-do-when-go-list-doesnt-show-the-newest-version-of-a-package
In short: when importing the package with path gopkg.in/urfave/cli.v1 using go modules, the versions onwards 1.20 are broken, because the go.mod file states that the import path is github.com/urfave/cli.
To reproduce
Add line gopkg.in/urfave/cli.v1 v1.22.4 to your go.mod requirements and run go build.
Observed behavior
go<EMAIL_ADDRESS>go.mod has non-....v1 module path "github.com/urfave/cli" at revision v1.22.4

Expected behavior
I'm not sure if this can be fixed, as with go modules the package can have only one module path. Maybe gopkg.in/urfave/cli.v1 should be deprecated, and it should be stated clear in the documentation and on the gopkg.in page. I'm not entirely sure though, maybe there's some way to get it work.
Additional context
This happened to me when upgrading old code to use go modules. It worked with dep.
Want to fix this yourself?
Not sure if this can be fixed?
Run go version and paste its output here
go version go1.14.4 darwin/amd64

Run go env and paste its output here
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/REDACTED/Library/Caches/go-build"
GOENV="/Users/REDACTED/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY="REDACTED"
GONOSUMDB="REDACTED"
GOOS="darwin"
GOPATH="/Users/REDACTED/go"
GOPRIVATE="REDACTED"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.14.4/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14.4/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/REDACTED/repos/jln-lab/jlab-batch-go/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/5d/nl4d9w0j4s5bnrxd6jp969rmnppcjn/T/go-build935024432=/tmp/go-build -gno-record-gcc-switches -fno-common"

Right now, the only URLs we officially support are github.com/urfave/cli/v2, or github.com/urfave/cli for v1. I'm not sure what the story was historically for gopkg.in, but as far as modules go, you'll need to use the current import URL.
This is consistent with what our docs describe, and I don't think there's anything that gopkg.in buys anyone in a module-aware world, so the path forward to get your project working again is just to update your references from gopkg.in/urfave/cli.v1 to github.com/urfave/cli.

Would it be possible to update the contents of the page at http://gopkg.in/urfave/cli.v1 ? Not sure who controls that or how.

Seems to be auto-generated. This is a gopkg.in link that points to my fork of this repo, despite me not registering anything: https://gopkg.in/rliebz/cli.v1
Having gone through the gopkg.in docs, it looks like there's no user input there. It's just a service that maps gopkg.in URLs to GitHub projects.

I see. In that case, there's hardly anything that could be done. I'll close this issue.


Extension not working - wrong endpoint? https://mercury-epub-to-kindle.herokuapp.com/send-to-kindle

Expected Behavior
After configuring kindle's email extension shoud send file to reader.
Current Behavior
After clicking on 'Send to Kindle' shows 'Sent succesfully', but nothing happens.
Detailed Description
In dev tools (network):
Request URL: https://mercury-epub-to-kindle.herokuapp.com/send-to-kindle
Request Method: POST
Status Code: 500 Internal Server Error
Remote Address: <IP_ADDRESS>:443
Trying https://mercury-epub-to-kindle.herokuapp.com/send-to-kindle and getting:  {"errors":["Not found"]}
Possible Solution

Now it works.


Merge master (as of 1.12.1) into 2-0-dev

Very WIP, much spec fail

@segiddins it's green! (I know the compact index stuff is still pending, but I want to fix that in another PR) r?

I can't review this, you should r? it yourself

@homu r+

:pushpin: Commit f7f48c3 has been approved by indirect

:zap: Test exempted - status


Use pg_restore version matching target DB server

Needed for user mover to run migrations from PG11 to PG12 machines. Related to https://app.clubhouse.io/cartoteam/story/72097/pg-12-manually-test-pg-upgrade-and-pg-dump-pg-restore
What does this PR do?
Modifies get_pg_restore_bin_path so it returns the bin version matching the target DB server version. Previously it was using the bin version matching the origin DB server.
Proposed steps for acceptance
Migration from PG11 to PG12

Deploy branch to a dedicated staging instance (PG12 installed)
Generate a dump

user = Carto::User.find_by(username: "amiedes-movetest1")
export = Carto::UserMigrationExport.create(user_id: user.id, organization_id: nil, export_metadata: true, backup: false, export_data: true)
export.enqueue
# wait for job to complete
export.exported_file
export.json_file

Import the dump from a Rails console launched in the dedicated instance:

exported_file = "<fill_with_import_values>"
json_file = "<fill_with_import_values>"
db_host = "<IP_ADDRESS>" # PG12 server is installed in the dedicated instance itself
org_id = nil
user_id = nil
org_import = false
import_metadata = true

import = Carto::UserMigrationImport.new(exported_file: exported_file, json_file: json_file, database_host: db_host, org_import: org_import, user_id: user_id, organization_id: org_id, import_metadata: import_metadata, dry: false, import_data: true)
import.save

import.run_import
# puts import.log.entries

Migration from PG11 to PG11

Deploy branch to CartoDB staging
Generate a dump as in the previous path (or you can reuse the same one)
Import the dump by enqueing a job from a RUI server:

exported_file = "<fill_with_import_values>"
json_file = "<fill_with_import_values>"
db_host = "dbd02.stag.cartodb.net" # Any staging DB running PG11
org_id = nil
user_id = nil
org_import = false
import_metadata = false

import = Carto::UserMigrationImport.new(exported_file: exported_file, json_file: json_file, database_host: db_host, org_import: org_import, user_id: user_id, organization_id: org_id, import_metadata: import_metadata, dry: false, import_data: true)
import.save

import.run_import
# puts import.log.entries

✅ Migration PG11 -> PG12 (chooses the right version of pg_restore)

✅ Migration PG11 (cloud) -> PG12 (ded): chooses the right version of pg_restore


JacocoTestReport task dependent on compile not test

The JacocoTestReport task executes as expected when test task has previously been executed. However, just running JacocoTestReport on a clean environment, executes compile but does not execute test compile and test.  The console report JaCoCoTestReport SKIPPED.   This behavior is a bit unclear. Please clarify in documentation at [(https://docs.gradle.org/current/userguide/jacoco_plugin.html)]
Expected Behavior
Please change the dependency of JacocoTestReport to dependsOn: test  or provide explanation on the documentation page as to why not.
Current Behavior
Execute JacocoTestReport and task is SKIPPED if tests not previously executed. What is the use case for not depending on the test task?
Context
If I misunderstood the operation and there is a use case, then please clarify for me.
Steps to Reproduce (for bugs)
Just setup a java app with tests including standard implementation as defined in the documentation sited above.
Your Environment
Nothing special.

@big-guy I think we discussed this before. Do you remember the reason? I believe the report task is not incremental, same for the coverage verification task. IMHO that's not a good enough reason for not depending on the test task.

It was intentional, but I don't know the reasons exactly.  It's not that the report task isn't incremental. I think it's so you could run the report on existing coverage data without rerunning the tests.
@breskeby and @adammurdoch were involved in that: https://github.com/gradle/gradle/commit/971f7815d55103aaed979c50620800b9abd911d6#diff-87d7c4e4b93105fdd221177a26e106e0

Please fix this issue.  The documentation for the Jacoco Plugin still says:
"If the Java plugin is also applied to your project, a new task named jacocoTestReport is created that depends on the test task."
The argument that the task dependency isn't automatically created makes no sense to me... folks who want to regenerate the report but not re-run tests can simply apply "-x test" to the commandline.
In general, task dependencies should be added by plugins automatically.  Adding this task dependency in my build script just adds meaningless clutter.  Issues like this sort of make it feel like users have to cross Gradle's T's and dot its I's, which certainly isn't the feeling we want to generate.

@andreas-schilling

the documentation is still a bit confusing

why not contribute - #9597 ? 😉


Claim devices

Part of bbc/hive-runner#146

Users should be able to claim a device on the device info page which would then put the device into a state whereby it would finish running its current tests and not pick up any new tests.
Would we want to have some sort of time out on this feature? i.e. if a device has been claimed and nothing has been done (i.e. disconnected, unplugged, etc.) then the claim is removed and the device is allowed to start running tests again


Add support for @autosubmit rebase

In some cases when PRs are very old it is useful to have a tool to auto rebase based on a comment.

Yeah we can do. I will take a look today.

This is same as the update branch from GitHub. Closing.


WIP: fix-2427 scripts/qiita_script

This script automate the installation over Travis, useful to install in dev and master environments.

Thanks @danteese! Renamed to WIP as there are errors in the builds and I think we should have a couple of the qiita-spots using the script to know that it's working as we want. Suggest starting with https://github.com/qiita-spots/qp-deblur and https://github.com/qiita-spots/qtp-visualization. I'll be in Slack if you have any questions.


Add Cognitive Service fairness assessment notebooks

Adds two notebooks for fairness assessment of face validation systems and speech-to-text systems.

@LeJit it looks like there are still some flake8 errors:

@LeJit I've merged the PR, but we will need to move the datasets out at some point


This PR fixes the bug. Let me know if we should create an 'issue' too.


Example of using a joystick or controller?

trying a couple things and not having any luck:
  sdl.joystick.on('deviceAdd', (device) => {
    console.log('JOYSTICK ADDED', device);
  });

  sdl.controller.on('deviceAdd', (device) => {
    console.log('CONTROLLER ADDED', device);
  });

  try {
    sdl.joystick.openDevice(0);
  } catch (err) {
    console.error('ERROR', err);
  }

  try {
    sdl.controller.openDevice(0);
  } catch (err) {
    console.error('ERROR', err);
  }

having a controller connected and clicking buttons, but still never seeing the deviceAdd events firing.
the openDevice(0) calls result in ERROR TypeError: A number was expected

I've made some progress:
const sdl = require('@kmamal/sdl');
const { controller } = sdl;

const [device] = controller.devices; // controller 1
if (device) {
 // this instance has buttons and axes
 const instance = controller.openDevice(device);
}

The instance's buttons and axes arrays don't change value, however the instance has events that are fired when axes are moved and buttons are pressed and released.
This is possibly a different pattern than a web browser's navigator.getGampads() which is read continuously to get the controller's state, as opposed to listening for button/axes events.
What I'm still uncertain of is if I should be calling controller.openDevice(device) continuously to get the latest state, or if I should only be listening for events and keeping track of the controller state myself with those events.